Add 'Use time range' option, skip date type field validation

What this PR does / why we need it:

When we have many indices in elasticsearch with different names of date type (not universally @timestamp) field.
In some cases we have indices that doesn't contain any date type field.

We can't search data for this cases.
Which issue(s) this PR fixes:

This PR allows to skip validation for date field, and doesn't block adding new datasource.

This PR also adds switch option Use time range for raw_data and raw_document search type. This option includes/excludes time range filter and sort in query request for raw_data and raw_document types only. Default value is enabled.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zohe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@z0h3 thank you so much for your contribution! This is a great suggestion! Would you mind signing our CLA? Just follow the link in the above comment.

@sarahzinger Done!


failed to run custom build command for nexus-network v0.4.0 (/Users/admin/.nexus/network-api/clients/cli)  Caused by:   process didn't exit successfully: /Users/admin/.nexus/network-api/clients/cli/target/release/build/nexus-network-b9098be9342c089f/build-script-build (exit status: 1)   --- stdout   cargo:warning=Failed to run protoc: No such file or directory (os error 2)    --- stderr   Error: Os { code: 2, kind: NotFound, message: "No such file or directory

failed to run custom build command for nexus-network v0.4.0 (/Users/admin/.nexus/network-api/clients/cli)
Caused by:
process didn't exit successfully: /Users/admin/.nexus/network-api/clients/cli/target/release/build/nexus-network-b9098be9342c089f/build-script-build (exit status: 1)
--- stdout
cargo:warning=Failed to run protoc: No such file or directory (os error 2)
--- stderr
Error: Os { code: 2, kind: NotFound, message: "No such file or directory

Fixed for me after installing protobuf (Ubuntu 22.04):
sudo apt update sudo apt install -y protobuf-compiler

Fixed for me after installing protobuf (Ubuntu 22.04):
sudo apt update
sudo apt install -y protobuf-compiler

macos bro

macos bro

Then install it with brew
brew install protobuf

macos bro

Then install it with brew
brew install protobuf

on macOS, you probably got the error below.
Error: An exception occurred within a child process:
  FormulaUnreadableError: cmake: undefined method `cellar' for #<BottleSpecification:0x00007f8902969a78>

the fix is:
rm -rf /usr/local/Homebrew/Library/Taps/homebrew/stable/homebrew-core
git clone https://github.com/Homebrew/homebrew-core.git


Additional link removed

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

server-2013/lync-server-2013-configuring-network-region-links.md
:white_check_mark:Succeeded

server-2013/lync-server-2013-create-network-region-links.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Subscribing to an empty list returns an object rather than an empty array

For example:
var shrubs =ds.record.getList('shrubs');
*wait a bit, or wrap in .whenReady()*
shrubs.subscribe(function(shrubEntries) { console.log('shrubEntries', shrubEntries) }, true);

Produces an empty object rather than an empty array:
shrubEntries Object {}
Digging into the Record code which backs a List I tried initially setting this._$data to [] but it seems to be overwritten in the _onRead handler here:
https://github.com/hoxton-one/deepstream.io-client-js/blob/master/src/record/record.js#L347
I don't understand why a message reading the record is setting its data, or am I misinterpreting something?
What I would like to be able to do (for a potentially new list 'shrubs') is:
ds.record.getList('shrubs').subscribe(function(shrubEntries) { console.log('shrubEntries', shrubEntries) }, true);

But this doesn't log anything unless the subscribe is separated and wrapped in a .whenReady().
The way I'm using deepstream at the moment I was hoping to rely on an empty array turning up, to tell the application that the data has loaded but there is nothing there, so that ie. a loading spinner can be replaced with a blank list. Are there any situations where you would pass true to subscribe's triggerNow and not want an initial subscription?
I know I can wrap things in .whenReady() but I'm not sure why you wouldn't want this behaviour as default if you have passed true to triggerNow.
Thanks for open sourcing this excellent framework, I have been enjoying experimenting with it.

Thanks for the feedback, much appreciated!
I'll divide your questions into a few parts, they are also ordered a bit different to in your question.
I don't understand why a message reading the record is setting its data, or am I misinterpreting something?
When a record is requested from deepstream it tries to load its current state, and if the record doesn't exist will create it as an empty object and return that value.
Once that value is retrieved it will then fire the whenReady event, which means the record has set its data to be in sync with what the server has and you can start using it.
Since requesting the record the first time is an async operation, this._$data will be updated with the current state of the record from the server as soon as it is loaded, which is why it is being overriden on read events.
Produces an empty object rather than an empty array
The way lists work is they provide convenience APIs ontop of a normal record. This is to make it easier than having to deal with arrays directly and provide extra callbacks.
What you raised is actually a bug in the API where it exposes the default record content when it's first created ( which is an empty object ).
The method getEntries could instead be used to return an array instead so your code would look like this:
var shrubs =ds.record.getList('shrubs');
*wait a bit, or wrap in .whenReady()*
shrubs.subscribe(function(shrubEntries) { console.log('shrubEntries', shrubs.getEntries() ) }, true);

Doesn't log anything unless the subscribe is separated and wrapped in a .whenReady()
This is intended behaviour, since no events are actually fired until the isReady event occurs.
In your example:
ds.record.getList('shrubs').subscribe(function(shrubEntries) { console.log('shrubEntries', shrubEntries) }, true);

Since shrubEntries is not yet loaded from the server, you can't actually be told what the current state is.
By putting it in whenReady:
ds.record.getList('shrubs').whenReady( function() {
	subscribe(function(shrubEntries) { console.log('shrubEntries', shrubEntries) }, true);
} );

It's now saying that as soon as the information is loaded from the server ( its initial state ) subscribe to the any changes and be told what the initial value is.
In your case of finding out if it's loaded or not would be:
// Set Default Loading Behaviour
var list = ds.record.getList('shrubs');
list.whenReady( function() {
	subscribe( function( shrubEntries ) {
		var shrubEntries = list.getEntries();
	}, true);
        // Remove loading behaviour ( this should only be triggered once during the list lifetime )
} );

Normally, using records, you won't need to use closures, but given the issue mentioned in part 2 the record is still exposed in a few callbacks instead of the list. Raised #33 as well to capture that.
Hope this helps, and feel free to let me know if something doesn't make sense!


add replay tag in bg sync queue

R: @jeffposnick @addyosmani @gauntface
Fixes #384
Adds another constant tag for replaying the queue

The code change is 👍
Are there any tests that can be updated to ensure that this behaves as expected?

@jeffposnick @addyosmani current tests are mostly unit tests for sub pieces, there is no test on service worker behaviour as such.
Can you guys point me to any other tests which cover service worker functionality in the repo(e.g activate/fetch event etc)?

https://github.com/GoogleChrome/sw-helpers/blob/master/packages/sw-routing/test/browser/end-to-end.js is an example of an end-to-end test.
If there aren't any existing tests that would need to be updated to reflect this new functionality, then I'd be fine with moving ahead with this PR and then filing a separate issue to track the creation of new end-to-end tests that covered it.

yeah there are no end to end tests right now, i'll open a separate PR for these


Make it easy to register a Delta table in Hive metastore

A Delta table can be created without a corresponding entry in the Hive metastore:
df.write.format("delta").save("my/cool/table")

We should make it easy to register this table in the Hive metastore.

I am taking this next.

@brayanjuls - awesome, thank you!


Player page needs more sections

We are missing a section in the video details page. We don't have the section with video title. This is what actual youtube look like.

This is what ours look like

You can continue to work from the player-frame branch, just make sure to git pull on the master branch, then git rebase master while on the player-frame branch.

I've got everything in that section now, except the number of subscribers next to the subscribe button. That would require a separate API call to pull, so if you think it's worth it I can set that up too. Otherwise it's good to have Alex work on it.

Pretty sure that extra api call doesn't cost too much, let's add it in.
Are you working on player-frame branch still?

Sounds good, and yes.


Pip install fails on windows

Hi,
I'm trying to install in a conda virtual environment on Windows 10, but fails:
Are there any pre-requisites for using the package?
TIA,
$ pip install pylusat
Collecting pylusat
  Using cached pylusat-0.5.2-py3-none-any.whl (4.2 MB)
Requirement already satisfied: scipy in c:\users\********\miniconda3\envs\gisenv\lib\site-packages (from pylusat) (1.7.3)
Collecting geopandas
  Using cached geopandas-0.10.2-py2.py3-none-any.whl (1.0 MB)
Collecting rasterio
  Using cached rasterio-1.2.10.tar.gz (2.3 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: 'C:\Users\********\Miniconda3\envs\gisenv\python.exe' 'C:\Users\********\Miniconda3\envs\gisenv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py' get_requires_for_build_wheel 'C:\Users\********\AppData\Local\Temp\tmpb4umxeh5'
       cwd: C:\Users\********\AppData\Local\Temp\pip-install-wggztvbu\rasterio_805f398dafc749ffbe2842e9b17b14ad\
  Complete output (2 lines):
  INFO:root:Building on Windows requires extra options to setup.py to locate needed GDAL files. More information is available in the README.
  ERROR: A GDAL API version must be specified. Provide a path to gdal-config using a GDAL_CONFIG environment variable or use a GDAL_VERSION environment variable.
  ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/44/5e/9f19e1e6fe980b59d8da8809f2e8f81eb7f0322c71914f077edcbcd9a110/rasterio-1.2.10.tar.gz#sha256=6062456047ba6494fe18bd0da98a383b6fad5306b16cd52a22e76c59172a2b5f (from https://pypi.org/simple/rasterio/) (requires-python:>=3.6). Command errored out with exit status 1: 'C:\Users\********\Miniconda3\envs\gisenv\python.exe' 'C:\Users\********\Miniconda3\envs\gisenv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py' get_requires_for_build_wheel 'C:\Users\********\AppData\Local\Temp\tmpb4umxeh5' Check the logs for full command output.

PyLUSAT depends on geopandas, which itself depends on GDAL. On Windows system, you can download a pre-built gdal wheel from https://www.lfd.uci.edu/~gohlke/pythonlibs/#gdal. Checkout an example tutorial of installing GDAL on Windows here.


Fix scope issue

Hello,
The issue I am having is if I do the following:
useSubscription([`/topic/user-${user.id}-notifications`], onMessage)
If onMessage uses any value that changes, it does not update inside the function. The onMessage function stores the first instance of itself.
I see the reason is setting the onMessage function into a useRef. Why was the reason this was done?
This PR should fix this if there is no underlying reason for this

Hello!
Thanks for your contribution!
I have used a ref there because I wanted to prevent unsubscribing and resubscribing to the topics on each change of the onMessage function. Implementing your suggested change would cause every change of the function to clean up the effect (unsubscribe) before afterwards running the effect again with the new function (resubscribing), which is in my eyes undesirable.
However, the ref should of course be updated to point to the new function every time the hook runs, to not cause the exact issue you are currently experiencing. The reason that is currently not done is simply an oversight, which happened during the typescript rewrite I had done. In the original commit which implemented this, the ref was updated, while it currently is not.
I therefore will start updating the ref again, and not merge your pull request. Please let me know tough if you disagree with me or have any further feedback!
Sven


fix(rules): fix no-unused-vars rule and add ignoreRestSiblings

@marlonmleite it looks OK for me as well.


Set a configurable limit to the number of redis pool connections

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

[x] Settings

[x] New settings are documented and present in app.json
[x] New settings have reasonable development defaults, if applicable
[ ] Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?
https://sentry.io/organizations/mit-office-of-digital-learning/issues/3123801638/?environment=production&project=5739976&query=is%3Aunresolved
What's this PR do?
Sets a max number of redis pool connections to avoid overloading redis.
How should this be manually tested?
Start some celery tasks, they should run normally.

Codecov Report

Merging #1170 (5a67f91) into master (a7c1584) will increase coverage by 4.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   90.95%   95.38%   +4.43%
==========================================
  Files         211       98     -113
  Lines        8382     2689    -5693
  Branches     1439      554     -885
==========================================
- Hits         7624     2565    -5059
+ Misses        661      124     -537
+ Partials       97        0      -97

Impacted Files
Coverage Δ

main/settings.py

main/tasks.py

videos/youtube.py

ocw_import/tasks.py

...gement/commands/markdown_cleaning/testing_utils.py

main/middleware.py

websites/__init__.py

websites/config_schema/api.py

...mmands/markdown_cleaning/metadata_relative_urls.py

websites/site_config_api.py

... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c1584...5a67f91. Read the comment docs.


One huge commit that included two new notebooks

Also dramatically changed the IGP one.

The pretty LLC4320 plot is still brewing. But this is ready


H1Z1: KotK Support

Would love to see support for this game.

I believe it was either H1Z1 or DayZ that had Razer lighting support. But it did not work because BattlEye would prevent loading of Aurora's uncertified wrapper dlls.

On Mar 20, 2017, at 20:35, Zallee90<EMAIL_ADDRESS>wrote:
Would love to see support for this game. # # # @
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ah, ok.. :/ Are we able to make timers for how long a key should have a certain color in the future? eg. If i apply a bandage i know it takes 3 secs, so the key binded to the bandage can be another color during the "cooldown".
And to bind an area of keys to light up when i press another key? eg. If i press M for map, all the keys within 3 keys from M lights up in green until i press M again to close map.
Love the software, but miss having it on the game i play the most.. :P Hehe!

There doesn't appear to be any realistic way to add support for this. Closing until plausible. You can make a generic profile for it to show stuff like shortcuts, but you won't be able to make changes based on the current in-game information.


Path

Travis fix:
add $HOME/miniconda#s to path to accommodate miniconda, miniconda2, miniconda3, etc...
Was causing tests to fail since last push to master

Coverage increased (+0.8%) to 94.472% when pulling c9b68668eb333edbc3d3eae93336862eb7320ee3 on path into 371e02494889d2ea3470ecbaa225f46028bb631a on staging.


[CHEF-15] Fix order of connection before registering node

Signed-off-by: dheerajd-msys<EMAIL_ADDRESS>Correct the order of connection before registration
Description
Updates order of connection  before registration for any node, Ensures the connection object to be live.
Related Issue
Fixes https://github.com/chef/knife-ec2/issues/579
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@dheerajd-msys we register the client first and then go for connection. So this will change the current behavior.

@dheerajd-msys I am working on with @btm in fixing the #8576. So may be we can close this PR.

@Vasu1105 I guess there is a mismatch, connection to the machine should be established before registration of any machine/node to the chef server.

@dheerajd-msys may be I am not sure. I have look around the code. @btm  any thoughts on this?

What I see here in new bootstrap we are using connection to identify the platform so that we can use the right bootstrap_context. Due to which just to get that connection we have to call connection first but I am not sure how much this is in relation with bootstrap process.

@dheerajd-msys is there a particular error this fixes? can you post the output here? there are a couple issues going around so we should be specific about which ones this intends to fix.
I made https://github.com/chef/chef/pull/8567 to fix https://github.com/chef/chef/issues/8534 but that caused https://github.com/chef/chef/issues/8576. I think that's what you're trying to fix here.

The problem was that I was fixing the 'validator' bootstrap path and broke the 'validatorless' bootstrap path, which @marcparadise had been testing. So we need to test both.

This tested working for me locally with both validatorless and validator bootstrap paths. :+1:

Yes @btm I was trying to fix https://github.com/chef/knife-ec2/issues/579 which is same as https://github.com/chef/chef/issues/8576. And I have verified that this change works for 'validator as well as 'validator-less'. 👍


Add ".gql" as a GraphQL file extension

👋 Hey @gdi2290, thanks for your pull-request, and welcome to Linguist.
Before I review your PR, we'll need you to accept the GitHub CLA, which is a mandatory first step for everybody who contributes to GitHub's codebases. Nothing to worry about, it's similar to accepting an EULA when you install a program. =)

@Alhadis thanks, just signed

Yikes, there're tonnes of GraphQL files with this extension. :| A few unrelated files in the search results, but nothing egregious.


The application is not public

The Serverless Application Repository does not show the application yet because it is not public:
https://console.aws.amazon.com/serverlessrepo#/available-applications

The application is now public! Thank you @rishm069


Store groups as uint16_t

Instead of storing supported groups in on-the-wire format store
them as parsed uint16_t values. This simplifies handling of groups
as the values can be directly used instead of being converted.
Note: quite a lot needed to be changed to get this to work. There isn't really a way to cut this up into smaller pieces because as soon as you change the type of the group fields everything breaks. This now passes all the tests but I may have missed something.
This is the first of several PRs which will tidy up and generalise the group handling.

This seems to upset some of extended tests... Red cross in post-merge test will lead you there...


Fixes for resource reference resolution templates

Fix for code originally in:  https://github.com/aws-controllers-k8s/code-generator/pull/401
Description of changes:
There were some syntax errors in generated controller code for resource reference resolution.  See here for some examples of compilation errors
Fixes here:

correct use of double-quotes in error messages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Yeah this was a good lesson about using %q in generated code. Thanks

/hold

We decided to revert #401 and #412 instead of fixing issues; closing this one but the fix here should be incorporated into the future un-revert PR


About the  Params and FLOPs of Laplacian-Former(with bridge)

What are the parameters and FLOPs? Why can't I measure it? My result is 36.49M, not 27.54M?

Hi @1580827935,
The number of n_skip_bridge is set to 1. By configuring it this way, you obtain 25.476M parameters and a FLOPs count of 6.485G. We used the fvcore library for calculating FLOPs and the number of parameters.

Yes, I got 25.476M parameters and a FLOPs count of 6.485G.But why not 27.54M parameters in your paper？

I've cleaned and optimized the code, leading to a reduced number of parameters. I've updated the table in the repo to reflect this change. I appreciate your attention to detail!

Ok, I see. Thank you very much for your answer and help!


Bug Report: Instrument doesn't play in Story Mode if dialogues or any cutscenes functions were used.

If you are playing a downloaded version of the game, what operating system are you using?
Windows 10 x64
What version of the game are you using? Look in the bottom left corner of the main menu.
1.6.2
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
In KadeEngine 1.6.2. Any weeks that used functions for cutscenes or dialogues will not load any background music from 'dialogueBox.hx' or play instrument when dialogue or any cutscenes is done.
In 'PlayState.hx' around line 1251 (an if-else statement with switch function for loading cutscenes, dialogues and stuffs), if every cases were removed except for default case, instrument will play properly.
Please fix this as fast as possible. Thank you.
Minimal Footage:
https://user-images.githubusercontent.com/25416809/129477924-153f92f6-c6f0-4a65-9ab2-9859361449bf.mp4

well, same here but you can play it on free play


Ingestion for GCS ingest fails with stateful ingestion

Describe the bug
When running ingestion for gcs with stateful_ingestion: enabled: true, I get the error
datahub.ingestion.run.pipeline.PipelineInitError: Failed to configure the source (gcs): Checkpointing provider DatahubIngestionCheckpointingProvider already registered.

Even if disabling stateful ingestion, the log will show the lines
INFO     {datahub.ingestion.source.state.stateful_ingestion_base:241} - Stateful ingestion will be automatically enabled, as datahub-rest sink is used or `datahub_api` is specified
[...]
INFO     {datahub.ingestion.run.pipeline:571} - Processing commit request for DatahubIngestionCheckpointingProvider. Commit policy = CommitPolicy.ALWAYS, has_errors=False, has_warnings=False
WARNING  {datahub.ingestion.source.state_provider.datahub_ingestion_checkpointing_provider:95} - No state available to commit for DatahubIngestionCheckpointingProvider
INFO     {datahub.ingestion.run.pipeline:591} - Successfully committed changes for DatahubIngestionCheckpointingProvider.

To Reproduce
Prerequisites:

gcs bucket
service account with Storage Object Viewer on the bucket
hmac id and secret for service account
datahub token

Steps to reproduce the behavior:

Minimal recipe:

source:
  type: gcs
  config:
    path_specs:
      - include: gs://<my bucket>/*.parquet
    stateful_ingestion:
      enabled: true
      remove_stale_metadata: true
    credential:
      hmac_access_id: <my hmac_access_id>
      hmac_access_secret: <my hmac_access_secret>

pipeline_name: gcs-pipeline

sink:
  type: "datahub-rest"
  config:
    server: <my gms endpoint>
    token: <my token>

Run datahub ingest run -c <my minimal recipe>.yml

Expected behavior
The pipeline should run without errors and write the state correctly, removing any stale metadata if configured.
Additional context
I think I have already found a fix that I will commit in the near future. The root cause is the creation of a equivalent s3 source that leads to re-registering of the checkpointing provider. Also, the platform attribute is missing which leads to the state being written to the platform "default".

This is also related to https://github.com/datahub-project/datahub/issues/10736


Season Group Filter

Leaving this here as notes. No feedback needed unless there's an error in my logic.
An anime year is broken into 4 seasons called cours. They start in January, April, July, and October.
SELECT MainTitle, DATENAME(MONTH, AirDate)
FROM AniDB_Anime
WHERE DATENAME(MONTH, AirDate) NOT IN ('January', 'April', 'July', 'October') AND AnimeType = 2

returned too many results, so I'm thinking of making it fuzzy of up to half of a month. Only normal shows apply, as OVAs, ONAs, Movies, etc don't follow standard release schedule and therefore don't apply.
The Filter will be an IN, NOTIN filter, with the standard comma separated format.
It will have two comboboxes for Season and Year, followed by an ADD button:
Winter
Spring
Summer
Fall

2014
2015
2016
...

For long running shows, they will continue to show up in the filter until they stop airing or become a separate listing on AniDB (AniDB lists things as being separate if they are broken into chunks, rather than shows like D.Gray-man which started and just kept going)
I know this has been requested, at the very least by me, but there was no issue for it, so I figured I'd make one while my brain is capable of planning.

Yoy could always have one drop down for the season and an input box for the year.

That's an idea.

https://github.com/japanesemediamanager/ShokoServer/commit/7b3a9e71997989cfe49627ed496cf224467926c7

Hmm, rather than making this something to add manually, should I make it like the years filter?

Great idea :)
Will add 15 days before the season, since some show starts before the first
of the month...
On Fri, Jul 14, 2017 at 4:23 PM, da3dsoul<EMAIL_ADDRESS>wrote:

Hmm, rather than making this something to add manually, should I make it
like the years filter?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/japanesemediamanager/ShokoServer/issues/641#issuecomment-315446237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHDbaG1KR8w6ntZJ2wcGNzrdx5BjTHOks5sN8BNgaJpZM4OYi0d
.

Yeah. I had to add functionality because winter lands on the border of the year

Yeah good idea @da3dsoul, make it easier to set the filter condition up.

I'm done for today. Things that need doing:

[ ] Proper sorting in Desktop (already made a string comparator, just need to somehow work it into the main list sorting)
[ ] Adding it to the Group Filter Condition form
...I think that's it actually.

I want a Season Group Filter too! Thanks!! :)

Right I was going to possibly make the ui for this...and the year filter.


possible fix of 'ago' problem in Russian

'2000 год' in Russian is 'year 2000'
Before was parsed as '2000 years ago'
parse('2000 год')
datetime.datetime(17, 8, 3, 18, 44, 48, 222615)

After
parse('2000 год')
datetime.datetime(2000, 8, 3, 0, 0)

Please, see https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data

The reason behind this is that he relative-time parser is applied before the absolute-time parser... so it could be fixed by using the PARSERS settings, either deleting the relative-time parser or putting it in the last position.
i.e.:
dateparser.parse('2000 year', settings={'PARSERS': ['timestamp', 'custom-formats', 'absolute-time', 'base-formats', 'relative-time']})

Your approach is not good because we can't hardcode that regex there and would have side effects for other languages. However, the issue is still valid.
We could probably add a regex into the ru.yaml file.
Maybe a simplification as  - (\d+)\s*год\s+: \1 would work, however, I can't speak Russian and I don't know if we should add something more, as it could be that with other following or preceding words (as "ago" or "in") this simplification shouldn't be applied.


Add a .uncontainer utility function

So I have had this issue, where I need a div to be full-width within a .container class that is in the layout so I don't want to break it.
With other SO contributors, I was able to write a solution that does this and called it .uncontainer so that we get :
body
  .container
    .row
    .uncontainer // this is full width

I wanted it to be clean, reusing bootstrap variables, so I went for:
@import '~bootstrap/scss/functions', '~bootstrap/scss/variables';

@mixin make-uncontainer-responsive($max-widths: $container-max-widths, $breakpoints: $grid-breakpoints) {
  @each $breakpoint, $container-max-width in $max-widths {
    @include media-breakpoint-up($breakpoint, $breakpoints) {
      // Still hesitating with two other attribute : margin-left and translateX;
      // Anyone has an opinion on this?
      left: calc((#{$container-max-width} - 100vw)/2);
    }
  }
}

.container {
  position: relative;
  .uncontainer {
    position: absolute;
    width: 100vw;
    @include make-uncontainer-responsive();
  }
}

How about making this a utility class available by default?

I personally don't like this approach. If you need something outside of a container that's where it should be, or you can use other already available classes to accomplish what you need.
Can you provide a CodePen or JSFiddle example.  I want to see why it would be needed and if it can be accomplished another way.

You should just change your markup and go for a solution like this:
body
  .container
    .row
  div // this is full width

I've also experimented with this technique in the past but the fact is it's quite hard to provide a solid solution. Just changing the markup is the way to go.

Hi,
Thanks for getting back. I wish discussion could have gone further before immediate closing but fine.
I am very aware that the simplest/cleanest solution is to move the div out of the .container.
But in my case, (and this has happened to me several times, hence the desire to find a reusable solution, and I am sure I am not the only one), more or less everything in my website is within the .container, which logically is in my layout file.
But for a specific landing page, there are background images that are within the content, but stuck to the very left of the screen. Doing what you guys suggest means the following:

Adding a noContainer variable to the layout that defaults to false, which means writing :

render("my-fancy-landing.html", {
  noContainer: true
});

Editing layout.html to:

.body
  = "navbar.html"
  #content{class: noContainer ? '' : 'container'}
    = yield
  = "footer.html"

In my-fancy-landing.html, repeating:

.container
  // Beginning of my content
div{style: "background-image: url('image/left.jpg'); background-position: left;"}
  .container
    // more content
.container
  // other content
div{style: "background-image: url('image/right.jpg'); background-position: right;"}
  .container
    // more content

I find this to be:

a lot of work/code rewrite
quite inelegant, nor DRY`
bad separation of concern: besides decoration, it makes perfect sense to have the .container within the layout
not responsive

which means many flaws only for a background image.
I wish there was a CSS-only solution, but for now, the only solution I found is this hacky one.
Hope I was clear and this eventually will speak to some readers.
Best


Genome Browser: make patric and refseq default tracks

currently, only PATRIC annotations are shown as default. I think we should add refseq features as well, so that users are aware of them and can make comparisons.
-Maulik

The tracks are in the list by default, so people should be able to see them.  Enabling them all just so they are seen just make the browser loading slower.

Fixed.  On alpha soon.


Request: Add Pocketbase Logs DB to Litestream

Update the litestream.yml so logs.db in Pocketbase are replicated as well.

good catch !!


fix(cmdfactory): Set arguments during initial object attribution

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

This commit fixes an issue where arguments were not attributed to the initial object (representing the command invoked by New).  In KraftKit, this did not matter since the arguments are passed again by AttributeFlags when the internal config is associated with the root command during the bootstrapping of the core application.  However, when used externally, and without using the AttributeFlags method independently from New, this causes a late-parsing issue where flags were not fully parsed before relevant subsystems were invoked.  For example, when calling the --help flag would not work because the system to recognise this has already executed.

@nderjung maybe you can also revisit this if you are touching cmdfactory


Fix FutureWarning in permute_adj func

Fix this warning.
FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    out_adj[in_indices] = adj[tuple(out_indices)]

Codecov Report

Merging #277 into master will decrease coverage by 7.53%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   89.27%   81.73%   -7.54%
==========================================
  Files         122      122
  Lines        6116     6116
==========================================
- Hits         5460     4999     -461
- Misses        656     1117     +461


Merge GH Updates to Trihydro Fork

Summary
Currently, our Trihydro master branch of GraphHopper is out of date. We need to pull from their main branch in order to reduce the amount of code changes and review in order to get our BufferResource working.
Solution
Pull from GH main branch.

Closing PR made by mistake.


Add xarray to environment requirements.txt

Add the xarray package to the list of requirements. Satisfies a requirement in profile.py.

@twsearle I think the failing tests can be patched by converting to datetimes. The many flavours of datetime objects are becoming real maintenance issue that would be better tackled in a different PR. Quick and dirty fix for now should do it

@twsearle it turns out that xarray is already in the conda environment at 0.7.0. Perhaps this PR can be a tidy up of those two failing tests?

I had a go at this and I think I have traced it to a difference in behaviour of numpy.ma.argmax. I have test case where it appears to be returning an index of zero in error (this is under the mask)? Perhaps I need a sanity check on this though.
We went from numpy  1.17.5  py38h95a1406_0   to numpy   1.18.1   py38h95a1406_0
Under  1.17.5  you get what you expect:
>>> import numpy as np
>>> import datetime as dt
>>> mask = [ True,  True, False,  True,  True]
>>> times = [dt.datetime(2019, 1, 1, 3, 0), dt.datetime(2019, 1, 1, 3, 15), dt.datetime(2019, 1, 1, 3, 30), dt.datetime(2019, 1, 1, 3, 45), dt.datetime(2019, 1, 1, 4, 0),]
>>> times = np.asarray(times, dtype='datetime64[s]')
>>> valid_times = np.ma.array(times, mask=mask)
>>> np.ma.argmax(valid_times)
2
>>> valid_times
masked_array(data=[--, --, datetime.datetime(2019, 1, 1, 3, 30), --, --],
             mask=[ True,  True, False,  True,  True],
       fill_value=numpy.datetime64('NaT'),
            dtype='datetime64[s]')

Under 1.18.1 I get:
$python
>>> import numpy as np
>>> import datetime as dt
>>> mask = [ True,  True, False,  True,  True]
>>> times = [dt.datetime(2019, 1, 1, 3, 0), dt.datetime(2019, 1, 1, 3, 15), dt.datetime(2019, 1, 1, 3, 30), dt.datetime(2019, 1, 1, 3, 45), dt.datetime(2019, 1, 1, 4, 0),]
>>> times = np.asarray(times, dtype='datetime64[s]')
>>> valid_times = np.ma.array(times, mask=mask)
>>> np.ma.argmax(valid_times)
0
>>> valid_times
masked_array(data=[--, --, datetime.datetime(2019, 1, 1, 3, 30), --, --],
             mask=[ True,  True, False,  True,  True],
       fill_value=numpy.datetime64('NaT'),
            dtype='datetime64[s]')

@twsearle perhaps there is a different default fill_value for datetime64 in numpy 1.18 than 1.17?

I don't think so, they are both 'NaT' I think?
I think the problem is deeper:
>>> np.argmax(valid_times.filled())
0

In both cases:
>>> valid_times.filled()
array([                'NaT',                 'NaT',
       '2019-01-01T03:30:00',                 'NaT',
                       'NaT'], dtype='datetime64[s]')
>>> type(valid_times.filled()[0])
<class 'numpy.datetime64'>

so confused!
>>> np.datetime64('NaT') > valid_times.filled()[2]

Yarp https://numpy.org/devdocs/release/1.18.0-notes.html#numpy-argmin-argmax-min-max-returns-nat-if-it-exists-in-array

https://github.com/numpy/numpy/pull/14717

@twsearle I keep forgetting github references everything everywhere

What? That is on purpose!? OK

How about we stick with 1.17 for now?

OK fair enough. I will change the requirements to <=0.17 for numpy. Probably worth learning how that works anyway!

Agreed, I think there must be a good reason for the 1.18 version of np.ma.argmax that we ought to be using

I think what we are supposed to do to fix this properly is use something like np.nanargmax(dates.filled()), but perhaps another day.


How to perform mutations

Hi!
I'm trying to use your library, but was wondering how to use it for mutations instead of queries.
Is it something like:
client.request({
  query: mutationName
  variables: {
    input: {
      id: "test
    }
  }
});

In case it matters, I'm using AWS Amplify.

Mutations are queries.

As chrisharrison says you can just put the full mutation in the query field (not just the mutation name) because under the hood all mutations are just queries of type Mutation


URL template to allow multiple replacements

Seems like the logic of parsing the URL for Custom "Open in" only is replacing the first occurrence, but it would be great to allow to replace all. An example, I was trying to set an URL for OsmAnd with a pin, so I have to set two sets of coordinates, one for the pin and other for the map itself, something like:
https://osmand.net/map/?pin={x},{y}#9/{x}/{y}
But what's being sent to the browser is only the first set replaced

Already done, will be in the next release.


Optimize job fetching.

Description
Currently CORGI fetches all 365 previous days of jobs every 10 seconds, this is obviously inefficient.
Details
In order to reduce the load we will split it into 2 queries.

Page loads, fetch all jobs from last 365 days.
Update jobs, fetch all jobs from last x hours or minutes.

Tasks

[ ] Add time query params to this endpoint
[ ] Update the Jobs store to use the new url, add new logic to combine the new list into the old one, and add a way to initialize the store with all the jobs
[ ] Update tests

Given
corgi client has no jobs locally yet
When
corgi polls for jobs
Then
it pulls all the jobs.
Given
corgi client has jobs locally
When
corgi polls for jobs
Then
it pulls only the jobs after the oldest currently running in the last 24hrs

verified in local setup and on corgi prod.
job times are updated only for the latest jobs (witihn 24h)


rename gc_spl to game_controller_spl in jazzy

As requested in #40578, splitting up the changes into PR per distro.

Repository was renamed recently from gc_spl to game_controller_spl. Instead of updating the name just for rolling's distribution.yaml, for consistency, I updated the names in humble and iron's distribution files too. I'm hoping there are no issues with this manual change.

Source repo
Releas repo

Related issue in ros2-gbp

This one will need to be rebased to fix the conflict.  After that, we can see what CI doesn't like about it.

Rebased this PR. The diff isn't great, but should be correct.

The CI failure was due to missing tags. I've updated the tags to match the latest ones on the new release repo.


Vipul/next state

add script to update next_state

Just a thought for the 'Set next state' script. Can we actually do this as a new API call in duffy itself and have a script that calls that?
For the v1 API we can just add a /Node/setstate route, but we'll want to do that "REST-properly" in the v2 API


clarify that multiple quotas can be specified per ns

/check-cla

Hi @uliul-carpatin!
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

@uliul-carpatin 👋 Please sign the contributor agreement in order to continue.
/close


[WFCORE-5255] / [WFCORE-5169] Revert WFCORE-5255 and WFCORE-5169

https://issues.redhat.com/browse/WFCORE-5255
https://issues.redhat.com/browse/WFCORE-5169
Reverts commits 219f896d77cbedfe2f3b025d0781e7e94e2cb670 and 95ed79c22dc854c0f591e753ea020991c6a9c2b1
Revert caused by https://issues.redhat.com/browse/WFCORE-5432

@SoniaZaldana thanks, I've reopened WFCORE-5255 & WFCORE-5169 to address them in a later release


What is distribution defined in Ballerina.toml?

Hello, 👋
Just curious, what is distribution defined in Ballerina.toml?
[package]
distribution = "2201.3.0"
name="helloworld"
org="jreleaser"
version="1.0.0-SNAPSHOT"

I believe this is the version of the Ballerina runtime to be used.

OK, thanks. 👍
Indeed, Ballerina runtime has an unusual versioning scheme (I thought "2201" was a typo 😉):
https://ballerina.io/downloads/swan-lake-release-notes/swan-lake-2201.3.1 🤯


[FLINK-25492][state/changelog] Place metadata into the beginning of the in-memory state changelog

What is the purpose of the change
On recovery, metadata is assumed to be in the beginning of the state changelog.
InMemoryStateChangelogWriter currently violates this assumption.
This change adds sorting to fix this.
Verifying this change
Added ChangelogDelegateHashMapInMemoryTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

@masteryhx can you please take a look?


SteamVR_PlayArea doesn't support Recentering Standing Position

Hi y'all,
Trying to keep objects tracked with a persistent coordinate system across Unity and Unreal, and at a basic level struggling to adapt to the changes with the new SteamVR 'Recenter Standing Position' functionality.
Repro steps are as follows:

In the Unity Editor, launch a scene with the default [CameraRig] prefab from the SteamVR plugin (which includes a SteamVR_PlayArea component)
Open the SteamVR dashboard in-headset and select Recenter Standing Position
Note that the SteamVR_PlayArea gizmo is now misaligned to the HMD position.

Note that it doesn't appear that a new call to GetPlayAreaRect is the solution, since that actually produces a different rectangle that is also misaligned (probably dependent on headset pose at time of recentering).
Edit: Actually, Play Area coordinates do appear to realign to the HMD poses if you update post-event. Just needs the hook added then I suppose!

Seems also somewhat related to #834, where I'm finding I can't get any notification of a reset view done via SteamVR which makes it awkward to reset and in-game transforms used to align the virtual and physical environment (which is important in the app I'm developing) - would be good to know if you're finding a way to hook in and recognise when a reset is happening.


ble_hci_rx_acl failed to allocate ACL buffers;

I am getting the following error after adding the nimble ota to my code, any idea how to fix it?
TX  AA 00
E (32453) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32456) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32458) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32466) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32474) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32481) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32489) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32497) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32505) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32512) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32520) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32528) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32536) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32543) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32551) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32559) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32566) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32574) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32582) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32590) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32597) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32605) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32613) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32620) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32628) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32636) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32644) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32651) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32659) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32667) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32675) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32682) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32690) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32698) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32705) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32713) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32721) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32729) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32736) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32744) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32752) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32760) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32767) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32775) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32783) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32790) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32798) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32806) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32814) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32821) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32829) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32837) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32845) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32852) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32860) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32868) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32875) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32883) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32891) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32899) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32906) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32914) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32922) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32929) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32937) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32945) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32953) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32960) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32968) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32976) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32984) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32991) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (32999) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33007) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33015) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33022) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33030) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33038) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33045) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33053) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33061) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33069) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33076) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33084) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33092) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33099) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33107) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33115) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33123) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33130) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33138) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33146) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33154) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33161) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33169) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33177) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33184) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33192) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33200) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33208) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33215) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33223) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33231) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33239) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33246) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33254) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33262) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33269) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33277) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33285) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33293) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33300) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33308) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33316) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33324) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33331) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33339) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33347) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33354) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33362) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33370) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33378) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33385) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33393) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33401) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33408) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33416) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33424) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33432) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33439) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33447) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33455) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33463) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33470) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33478) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33486) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33493) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33501) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33509) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33517) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33524) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33532) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33540) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33548) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33555) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33563) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33571) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33578) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33586) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33594) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT
E (33602) NimBLE: ble_hci_rx_acl failed to allocate ACL buffers; increase ACL_BUF_COUNT

Please note that changing the partition type to min_spiffs.csv helped, was able to get into 7%...

Nevermind, it works if USB is not plugged!


loss gap between train and test

in the final epoch , the training loss is much less than the test loss, is this a overfitting problem. If so , overfitting occurs in the second epoch. detail as belows
2021-12-22 08:38:09,866 Epoch: [29][3223/3234]  Eit 97010  lr 2e-05  Le 17.5955 (16.2388)       Time 0.054 (0.000)      Data 0.037 (0.000)
2021-12-22 08:38:10,415 Epoch: [29][3233/3234]  Eit 97020  lr 2e-05  Le 9.2004 (16.2394)        Time 0.054 (0.000)      Data 0.038 (0.000)
2021-12-22 08:38:10,455 Test: [0/40]    Le 65.0238 (65.0238)    Time 0.040 (0.000)
2021-12-22 08:38:10,861 Test: [10/40]   Le 64.3841 (64.6037)    Time 0.040 (0.000)
2021-12-22 08:38:11,264 Test: [20/40]   Le 64.7672 (64.5425)    Time 0.041 (0.000)
2021-12-22 08:38:11,670 Test: [30/40]   Le 64.4232 (64.6411)    Time 0.041 (0.000)
2021-12-22 08:38:12,840 Image to text: 42.1, 75.0, 85.0, 2.0, 8.8
2021-12-22 08:38:13,407 Text to image: 33.6, 67.4, 80.3, 3.0, 18.0

Overfitting is typically referred to when the test loss increases while the training loss decreases. A gap between train and test loss is not necessarily an indicator of overfitting. If you suspect overfitting, it makes sense to increase regularization to prevent it.


Have @usage decorator apply to operations

Clear and concise description of the problem
We have @usage for individual models and properties: we want to be able to apply this to all models referenced by an operation through a decorator that takes in an operation. More granularity down the line wins out
| Decorator State                   | Model with Public Usage | Model with Private Usage | Model without Usage |
|-----------------------------------|-------------------------|--------------------------|---------------------|
| `@usage(Usage.None)`              | Used                    | Used                     | Not Used            |
| `@usage(Usage.Input/Usage.Output)`| Used                    | Used                     | Used                |

Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

i think it is meaningless to set @usage to any value except roundtrip. what is the real scenario for this?


Potential TFTP Bugs in Development Branch

I found some issues in TFTP in development branch:

Error message isn't closed with a null char (see L72 pbertera/PyPXE@6a95bf8e31b06ec461f2b871598efe5c4d1c3ca4)
sock in "ongoing" are not initialised for data transfers (see L132 pbertera/PyPXE@6a95bf8e31b06ec461f2b871598efe5c4d1c3ca4)
blocks are never sent (see L133 pbertera/PyPXE@6a95bf8e31b06ec461f2b871598efe5c4d1c3ca4)

I did this patch only looking at differences between master brench where TFTP is working, so can contains issues. I did some tests and seems working as well.

is valid, RFC says it should be null terminated.

I can't reproduce 2 and 3, files are being sent properly and are all recieved correctly.

About 2 and 3: I have a vanilla "development" branch here, I send TFTP requests using a tftp client (linux netkit) I receive nothing. Looking the code at tftp.py I can't understand how should work: if opcode is 1 sendBlock()is never called..

sendBlock isn't used for an opcode of 1. For an opcode of 1 we so some options handshake on L127, and then we sendBlock after the ack.
I've managed to reproduce the error (busybox works, tftp-hpa doesn't). It seems to be related to the lack of tsize being sent

Your fix isn't quite right. We only want to use sendBlock if not response, and you might as well move self.ongoing[address]['sock'] = socknew up to just after the bind().
The bug is becuase some clients don't use the tftp extensions such as tsize or blksize.
Note that although this should be fixed, both the Intel and iPXE PXE clients use the extensions, this is not an acceptable standalone tftp server.

This has been fixed now.


Update sbt, sbt-dependency-tree to 1.10.2

About this PR
📦 Updates

org.scala-sbt:sbt
org.scala-sbt:sbt-dependency-tree

from 1.10.1 to 1.10.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #198.


Added Custom Sample dashboards for ACM Observability

Original PR: https://github.com/stolostron/multicluster-observability-operator/pull/1110 by provided by @maemmanu.

/hold

/unhold

/retest


Bug: Unable to  capture the widgets with OBS (Stream Mode already ON)

Thank you for creating this wonderful mod, I have been using this it v1. :)
Issue:
I am trying to use OBS with the source of Game Capture, to capture MHW and the overlay. Stream Mode is turned on for all widgets, and I have tried both with and without administrator, but still, OBS cannot capture the overlay. (As shown in the below capture; sorry that my UI is not in English)

Setup Environment:
Windows 11
Latest HunterPie v2
Monster Hunter: World
MHW Screen Mode: Borderless Window
P.S.
Actually, I am trying to play MHW through Steam Remote Play because of some reason. And the Steam Remote Play is not able to capture the overlay. Then I’m guessing that maybe it is using a similar technic as the OBS Game Capture. So, I gave a try to use OBS to capture the overlay with HunterPie’s Stream Mode (although the technic of Steam Remote Play and OBS may not be related). Thus, I found this issue that OBS cannot capture the overlay either.

Stream Mode isn't implemented yet, not sure when I'll implement it but I don't have plans for it at the moment

Any news on this?


Pretrained model

Hi,
Is there any way to access the pretrained VMRN model to reproduce the results in paper?
Thanks

Hi,
Is there any way to access the pretrained VMRN model to reproduce the results in paper?
Thanks

Sorry, I cannot find the old VMRN checkpoint. But I keep a ALL-IN-ONE model (including object detection, grasping, and relationship detection) at the following link:
https://drive.google.com/file/d/1OHiigeoJBeC_AZM6T5f-KuHXM3DY1LbX/view?usp=share_link
You can try that to see the performance.


python312Packages.diffusers: mark as broken on python 3.12

Description of changes
The current release of diffusers does not support python 3.12. Let's mark it as broken until this is fixed.
This is an effort at de-polluting nixpkgs-review reports.
cc @natsukium
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

In the end I fixed it in #310295 by disabling failing tests.

Anyway, thank you for the review @natsukium !


feat(Network): implement request.redirectChain() api

The request.redirectChain() returns all the requests issued to fetch
the resource.
Fixes #1816.

Response.fromServiceWorker failed on cirrus. Is that related to this patch?

@JoelEinbinder i don't think so. I think I fix flakiness in https://github.com/GoogleChrome/puppeteer/pull/2195 (btw, ptal)

@JoelEinbinder addressed comments; ptal.


Eats up all the storage space

Problem
Every file system change I make adds a few MB to the indexed db.

200MB and I only have 30 quotes and a small list of quote ids on the file system.

Video
Here's a video (from a different session) that shows the storage-usage going up.
http://icidasset-public.s3.amazonaws.com/Kapture 2020-08-04 at 21.53.05.mp4
Relevant code
https://github.com/icidasset/quotes/blob/6cd2d1ee5058548eae744bfb0bcc3c8a9c2716ed/src/Main.js#L49

Fixed with file system refactor.


Fix EOH recipes not being generated in some dimensions

Ross128b and Ross128ba don't generate GT ores

What about Toxic Everglades?

GTNEIOrePlugin doesn't support GT++


Improvements to FileIO and Network packages

Changelog:

Added ability to suppress error messages with the global suppressErrorMessages variable. This is used in the Execute package, in function try to facilitate a very basic form of exception-handling. Rationale: Persistable relies on the deserialize function to throw an error when a deserialization fails (tampered data, missing file, etc.), but since this is acceptable behaviour, and the error is properly handled upstream with try, there is no need for the player to see the inevitable error message. This shouldn't affect regular errors.
Renamed MultiIO to MultifileIO, renamed SimpleIO to PreloadIO. Rationale: PreloadIO is meant to be a simple wrapper around the Preload API, and does no checks for Local Files. The reasoning is that there may be use cases where you want to use the Preload API without having to pull in the LocalFiles dependency, together with Network, which is a very heavy package, such as for simple logging or saving of other data, without reading it back.
Added LocalFiles package providing functionality to detect 1.26 version and whether Local Files are enabled, and automatically syncs those results.
Added Local Files checks to MultifileIO and Persistable during loading. Now all load callbacks return a mandatory status enum reflecting the status of the operation. Saving, however, works without Local Files anyway, so I don't enforce that check.
Added 1.26 fallback support to MultifileIO, moving it outside of PreloadIO.
Added disconnection detection to Network. Now the callback returns a status enum depending on whether or not the operation succeeded or not.
Updated Network/SyncSimple global hot-docs to apply to the package, instead of enums inside them.
Fixed various typos in docs and updated them to reflect latest changes.
Added int/string to bool conversions.

Sweet, thanks again for the nice work @SamuelMoriarty 🍭


Add a Gitter chat badge to README.md

kinggoesgaming/Foundations now has a Chat Room on Gitter
@kinggoesgaming has just created a chat room. You can visit it here: https://gitter.im/kinggoesgaming/Foundations.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Manually done already


Wrong behavior with -c flag

$ gopass -c test
Entry 'test' not found. Starting search...
Found exact match in 'test.com/user'
<password>

I would expect it to copy the password to the clipboard and not print it to the console.

Works on master. Please try again with the latest master or the 1.5.0-alpha.3 release.


mix release fails with "Appup generation failed with bad_new_appvsn"

This is with version 1.0.0-rc7

@aussiegeek What was the new version of your app when building the release?

The issue was I hadn't set a @vsn in a genserver. When I added one it started working


Is there any way to test ReactDnD interaction by not installing react-dnd-test-backend

Maybe it's a silly question, but I'm working on a rails app without Bower/NPM and wondering if it's possible to test ReactDnD dragging and dropping interaction without npm install --save-dev react-dnd-test-backend. Any thoughts?
Thanks all.

If you build the package yourself and maintain it, you can use it. :wink:
Not sure how to answer this.
We provide the package precisely because we suggest you to use it.

I guess you can try the Browserify CDN build: https://wzrd.in/standalone/react-dnd-test-backend@latest
That's in case you need a UMD build.

Thanks @gaearon ! It's so helpful.


Changing the lidar angel from 180 to 360 degrees will make the model to perform better or not?

Dear @reiniscimurs ,
One question. Have you tried or heard someone try to successfully train the mobile robot with lidar at a 360-degree angle instead of 180 degrees? In your code, you are using 180 degrees. I was wondering if changing it to 360 degrees will increase the trained agent's performance. I understand it will take longer to train the model, but I wondered if changing the environment dimension from 20 to 40 will help the robot perform better.
Thank you for your attention.

Hi,
You can go through some still open and closed issues. Some people have tried this approach with varying results. There are papers out there that use 360 degree FOV but it is hard for me to say if that improves the performance.

Thank you for your reply!


[file explorer] Invisible character warning

I would like to have a distinction when a file contains a space or an invisible character
Here in the images below, one the folder is workflows  (with a trailing space)

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Add TIMES-NZ to benchmarks

...and use checkout@v4

@siddharth-krishna what do you think? Please feel free to modify...

Great, thanks! Yes, I think it is better to do that. I completely forgot to check whether there were any files in the old format!

Shall we merge this in for now, and update the CI once the format of the file has been updated?

Sounds good!


change patients fulfillment partial to not autocomplete any forms

I rule and have completed some work on Case Manager that's ready for review!
(brief, plain english overview of your changes here)
This pull request makes the following changes:

Change form fields in patients/_fulfillment partial to not autocomplete

(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:

Fixes #838

Codecov Report

Merging #1060 into master will increase coverage by 4.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage    90.9%   95.44%   +4.54%
==========================================
  Files          51       42       -9
  Lines        1077      878     -199
==========================================
- Hits          979      838     -141
+ Misses         98       40      -58

Impacted Files
Coverage Δ

app/helpers/dashboards_helper.rb
88.88% <0%> (-11.12%)
:arrow_down:

app/controllers/clinics_controller.rb
80.76% <0%> (-6.33%)
:arrow_down:

app/models/patient.rb
96.29% <0%> (-2.71%)
:arrow_down:

app/models/clinic.rb
100% <0%> (ø)
:arrow_up:

app/controllers/application_controller.rb
100% <0%> (ø)
:arrow_up:

app/controllers/patients_controller.rb
100% <0%> (ø)
:arrow_up:

app/helpers/patients_helper.rb
100% <0%> (ø)
:arrow_up:

app/models/concerns/callable.rb

app/models/concerns/statusable.rb

app/models/concerns/notetakeable.rb

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb8d82...0ad5f78. Read the comment docs.


Sort out multiplatform Unit Tests

There are two issues:

I haven't been able to get the netstandard2.1 version of the test run to execute. I've tried specifying 2.1.x in the setup-dotnet task, but that doesn't work.
The output looks like this:

Package
Line Rate
Branch Rate
Health

NModbus.Transport.Tcp
0%
0%
❌

NModbus.Interfaces
54%
100%
✔

NModbus
16%
20%
❌

NModbus.BasicServer
0%
0%
❌

NModbus.Transport.Tcp
0%
0%
❌

NModbus.Interfaces
54%
100%
✔

NModbus
16%
20%
❌

NModbus.BasicServer
0%
0%
❌

NModbus.Transport.Tcp
78%
50%
✔

NModbus.Interfaces
79%
100%
✔

NModbus
57%
58%
✔

NModbus.BasicServer
92%
57%
✔

NModbus.Transport.Tcp
3%
0%
❌

NModbus.Interfaces
0%
100%
❌

NModbus
4%
2%
❌

NModbus.Transport.Tcp
3%
0%
❌

NModbus.Interfaces
0%
100%
❌

NModbus
4%
2%
❌

NModbus.Transport.Tcp
78%
50%
✔

NModbus.Interfaces
79%
100%
✔

NModbus
57%
58%
✔

NModbus.BasicServer
92%
57%
✔

Summary
27% (2066 / 7096)
22% (280 / 1168)
❌

The projects are being duplicated a number of times. Determine how to avoid this.

Part of the challenge is that the .NET Standard builds can't really be tested with a dedicated framework as they're just considered an interface. The challenge remains for the multiple versions of .NET.


Added HttpMaster Express

Microsoft Reviewers: Open in CodeFlow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: joxi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


When updating a task list with push-task-list order is not preserved

If you add a task in the middle of the children of an item and push the task list again, the newly created task shows up at the bottom of the list instead of at the position in the org file

Also updating an already pushed task's headline just adds a new task at the bottom of the list and leaves the old version


Backport GUID_t refactor to 1.9.x [6781]

Original task: [6644]
Original pull request: #797

Build status:

Linux
Mac
Windows
Performance

Build status:

Linux
Mac
Windows
Performance


build infrastructure: get rid of " = pkg-config ..." idiom

Followup to #80 and #81. This time using shell macro.

FWIW I tested on Wheezy. Builds. I am still not sure whether supporting debian oldstable is worth having these ugly shell macros.

Added another commit because testing on Wheezy revealed that current header test is not sufficient. Also, pkg-config --exists ... is more readable then bunch of [ -f ... ].

thank you :)