Some YouTube video can't be downloaded without manifest

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.02.16
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

PS C:\WINDOWS\system32> youtube-dl -f 137 https://www.youtube.com/watch?v=1lcm1M4CV6Y --youtube-skip-dash-manifest --ver
bose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', '137', 'https://www.youtube.com/watch?v=1lcm1M4CV6Y', '--youtube-skip-dash-manifest', '--verbose']
[debug] Encodings: locale cp936, fs utf-8, out utf-8, pref cp936
[debug] youtube-dl version 2020.02.16
[debug] Python version 3.6.2 (CPython) - Windows-10-10.0.17134-SP0
[debug] exe versions: ffmpeg N-86994-g92da230
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:1081', 'https': 'https://<IP_ADDRESS>:1081', 'ftp': 'ftp://<IP_ADDRESS>:1081'}
[youtube] 1lcm1M4CV6Y: Downloading webpage
[youtube] 1lcm1M4CV6Y: Downloading video info webpage
[debug] Invoking downloader on 'https://r5---sn-p5qlsndk.googlevideo.com/videoplayback?expire=1583002854&ei=hmBaXvOsAsiJhwbBsZDoAw&ip=<IP_ADDRESS>&id=d65726d4ce0257a6&itag=137&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C278&source=yt_otf&requiressl=yes&mm=31%2C26&mn=sn-p5qlsndk%2Csn-vgqsrnes&ms=au%2Conr&mv=m&mvi=4&pl=23&initcwndbps=96250&vprv=1&mime=video%2Fmp4&otf=1&otfp=1&dur=0.000&lmt=1455968812291948&mt=1582981171&fvip=5&keepalive=yes&fexp=23842630&c=WEB&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cotf%2Cotfp%2Cdur%2Clmt&sig=ADKhkGMwRQIhAICZqtXQRadTCzOQmIIyMGuV1HKm_sr3Kl2lNDeYhZrAAiBeLKaoEenAYsWFoeVskQGNGfpxXkdwHU-uY2GtCUSf0g%3D%3D&lsparams=mm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=ABSNjpQwRQIgSdvs44FVO3pzUkztjdRyd7WGHxMnFC9ev1QT_ogc4aECIQDUCU_U2xO2KPAS4-24LJnSAqJYF4nkox0D8sM-auD5Gw%3D%3D&ratebypass=yes'
ERROR: unable to download video data: HTTP Error 404: Not Found
Traceback (most recent call last):
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 1925, in process_info
    success = dl(filename, info_dict)
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 1864, in dl
    return fd.download(name, info)
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\downloader\common.py", line 366, in download
    return self.real_download(filename, info_dict)
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\downloader\http.py", line 341, in real_download
    establish_connection()
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\downloader\http.py", line 109, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "d:\program files\python\python36\lib\site-packages\youtube_dl\YoutubeDL.py", line 2237, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "d:\program files\python\python36\lib\urllib\request.py", line 532, in open
    response = meth(req, response)
  File "d:\program files\python\python36\lib\urllib\request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "d:\program files\python\python36\lib\urllib\request.py", line 570, in error
    return self._call_chain(*args)
  File "d:\program files\python\python36\lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "d:\program files\python\python36\lib\urllib\request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

Description

It returned HTTP 404 error, and the problem seems to appear only in some specific formats.

This is what they return. Blame Youtube for that.

This is what they return. Blame Youtube for that.

So it isn't a bug? OK, I know. Thanks.


Move ProjectAPIKeyOperator so it doesn't get deleted by the automated PR updater

@displague Could you add a /lgtm here? Looks like I don't have write access on this repo.


fix(@angular-devkit/build-angular): serve assets

Turns out the test for asset serving didn't actually test asset serving because of a missing whenStable() - it always succeeded, even with random filenames. This change adds a custom middleware to serve our static files since it seemed easier (and more predictable) than to try to map the assets concept to Karma's files+proxy logic.
One side effect of adding the middleware is that we don't actually need the Karma files anymore with the exception of any files that we'd want to include on page load. I don't touch that part here because it will be cleaner to change it when also addressing the naming collisions between spec files.
Fixes https://github.com/angular/angular-cli/issues/28754
P.S.: Currently the first commit is from a different PR (https://github.com/angular/angular-cli/pull/28794), I'm planning to rebase after landing it.

The changes were merged into the following branches: main, 19.0.x


[fix] later.setInterval is advancing 3 hours

Describe the bug

Later version: 4.1.0
Node.js version: v16.13.1
OS & version:  "Debian GNU/Linux 9 (stretch)" / "Debian GNU/Linux 10 (buster)"

I'm using the following code snippet to schedule a routine that runs daily on the same hour later.parse.recur().every(1).dayOfMonth().on(10).hour().on(33).minute();
through the later.setInterval
Actual behavior
The execution takes place well for 2 days, but in the 3rd execution it is executed 3 hours in advance.
...
Expected behavior
I expect setInterval to run daily at the same time every day
...
Code to reproduce

let routine = later.parse.recur().every(1).dayOfMonth().on(10).hour().on(33).minute();

//JSON.stringify -> {"schedules":[{"D":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31],"h":[10],"m":[33]}],"exceptions":[]}

later.setInterval(function() {execRoutine(data)}, routine, timeZone); //timezone = "America/Sao_Paulo"
...

Checklist

[x] I have read the documentation.
[x] I have tried my code with the latest version of Node.js and @breejs/later.

I have several routines scheduled this way, and only a few had no problem executing in advance.


Disable unset preset mode if the temperature is manually defined on a thermostat

Versatile Thermostat unset the thermostat mode, because he think a have manually define a new temp set point on my TRV...
But, the probleme come from my Danfoss TRV, who doesn't execute the last set point temp change asked by versatile thermostat....
So here a simple explanation
1/ Preset to comfort (20°) on Vtherm, he send the set point the the TRV with a temp ajustement (21°)
2/ The TRV doesn't execute the setpoint change, and tell the set point is 18°
3/ Vtherme disable the preset.
I have to reboot my TRV (Danfoss Ally under Z2M)
Could it be possible to disable the unset preset mode on some vtherm ?
Best regards

Could it be possible to disable the unset preset mode on some vtherm ?

No, it is a feature used by most people to be able to control their device manually.
You can notice that the next time the Scheduler will send a preset, the Vtherm will go back to the preset mode. The manual mode (without preset) is temporary until the next Scheduler change.


Update apiVersion in documentation descriptor

What does this PR do?
Update apiVersion in documentation descriptor
Motivation
The old extensions/v1beta1 Deployment API is deprecated.
More

[X] Updated documentation

@dduportal I greped through the directory and didn't find other references to extensions/v1beta1 for Deployments.
However there are many references to extensions/v1beta1 Ingress which should be updated for Kubernetes 1.20, but as the networking.k8s.io/v1beta1 Ingress is only served since 1.14 I think this could be done later.


Add Settings dialog for kubernetes api

Description
Upon first running mlbench and accessing the dashboard, a user should be prompted to configure Kubernetes access for the master node, so it can manage the workers and gather metrics from kubernetes

Not sure this is actually needed. a lot of config can be done through helm


MacOS: Dialog text does not appear

The problem
Describe the bug
When a dialog node is added to the scene, the dialog text does not appear. However, the number of events remain the same.
To Reproduce
Steps to reproduce the behavior:

Create a timeline
Add a Text event with any text and character
Play Timeline, or add dialog node to any scene
See only a gray rectangle at the bottom and a dark gray background

Expected behavior
When a dialog is added, the text from within the text event should be visible.
Screenshots

System (please complete the following information):

OS: macOS Monterey Version 12.0.1
Godot Version: 3.4.1
Dialogic Version: 1.4.1

Solutions
Workaround
No workaround found yet.
Possible fixes

Have you changed your window size?

I just tried resizing the window. Still no effect :(

@mcsantiago I was asking because it looks a lot like the dialog is appearing but is HUGE, so you only see the bottom part of the panel. This happens if you set the window size of your project in the setting to something tiny like 300x150 or so (often for pixel-art games). You can fix that if you adjust the box and font size in the dialogic theme. Otherwise I don't know what could cause this.

Oh I see. Yes this project was originally started as a pixel art game. Then I thought it would be better as a sort of 2.5D game. I forgot that I had the window size set to that 350x190 range. Project Settings > Display > Window to adjust the window size. I'm not really sure if this is a bug at this point rather than user error. You can close this if you want.

Per user, closing this.


[BEAM-11088] Clean up incorrect comment

Fix comment mismatch with renamed test function
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck


licenses of the images (especially the .png)

From<EMAIL_ADDRESS>on 2013-08-19T14:25:21Z
Hello,
I am preparing the spyder 2.2.2 version, so I decided to double check the licenses.
this is a preparation for the 2.3. version and itspython3 support.
This will generate a few new binary package so the NEW process of Debian will be necessary.
During this New process the ftpmaster team enforce the legacy of the archive -> check all the files licences (boring but essential)
So here the problem:
Can you give me the licenses of all these icons ?
thanks
Frederic
----------------- spyderlib/images/actions/arrow-continue.png -----------------
new file mode 100644
index 0000000..82fbcff
Binary files /dev/null and b/spyderlib/images/actions/arrow-continue.png differ
--------------------- spyderlib/images/actions/control.png ---------------------
deleted file mode 100644
index 195a9d7..0000000
Binary files a/spyderlib/images/actions/control.png and /dev/null differ
-------------------- spyderlib/images/actions/maximize.png --------------------
index 6121e52..5a66388 100644
Binary files a/spyderlib/images/actions/maximize.png and b/spyderlib/images/actions/maximize.png differ
------------------- spyderlib/images/actions/stop_debug.png -------------------
new file mode 100644
index 0000000..6987989
Binary files /dev/null and b/spyderlib/images/actions/stop_debug.png differ
------------------- spyderlib/images/actions/unmaximize.png -------------------
index 59db8ae..0e6daba 100644
Binary files a/spyderlib/images/actions/unmaximize.png and b/spyderlib/images/actions/unmaximize.png differ
---------------- spyderlib/images/actions/window_fullscreen.png ----------------
index cb20ada..f275b74 100644
Binary files a/spyderlib/images/actions/window_fullscreen.png and b/spyderlib/images/actions/window_fullscreen.png differ
--------------- spyderlib/images/actions/window_nofullscreen.png ---------------
index 4b42215..f5d4be4 100644
Binary files a/spyderlib/images/actions/window_nofullscreen.png and b/spyderlib/images/actions/window_nofullscreen.png differ
-------------------- spyderlib/images/editor/breakpoint.png --------------------
deleted file mode 100644
index 3c4809b..0000000
Binary files a/spyderlib/images/editor/breakpoint.png and /dev/null differ
------------------ spyderlib/images/editor/breakpoint_big.png ------------------
new file mode 100644
index 0000000..5a3e9b6
Binary files /dev/null and b/spyderlib/images/editor/breakpoint_big.png differ
----------------- spyderlib/images/editor/breakpoint_cond.png -----------------
deleted file mode 100644
index 3fe6527..0000000
Binary files a/spyderlib/images/editor/breakpoint_cond.png and /dev/null differ
--------------- spyderlib/images/editor/breakpoint_cond_big.png ---------------
new file mode 100644
index 0000000..f197e83
Binary files /dev/null and b/spyderlib/images/editor/breakpoint_cond_big.png differ
-------------- spyderlib/images/editor/breakpoint_cond_small.png --------------
new file mode 100644
index 0000000..8119166
Binary files /dev/null and b/spyderlib/images/editor/breakpoint_cond_small.png differ
----------------- spyderlib/images/editor/breakpoint_small.png -----------------
new file mode 100644
index 0000000..88eca0d
Binary files /dev/null and b/spyderlib/images/editor/breakpoint_small.png differ
---------------------- spyderlib/images/editor/debug.png ----------------------
new file mode 100644
index 0000000..6782896
Binary files /dev/null and b/spyderlib/images/editor/debug.png differ
----------------------- spyderlib/images/editor/run.png -----------------------
index 15f1ed1..45d041b 100644
Binary files a/spyderlib/images/editor/run.png and b/spyderlib/images/editor/run.png differ
-------------------- spyderlib/images/editor/run_again.png --------------------
index f0f2e05..2294813 100644
Binary files a/spyderlib/images/editor/run_again.png and b/spyderlib/images/editor/run_again.png differ
------------------ spyderlib/images/editor/run_selection.png ------------------
index 667de81..012ac4c 100644
Binary files a/spyderlib/images/editor/run_selection.png and b/spyderlib/images/editor/run_selection.png differ
------------------- spyderlib/images/editor/run_settings.png -------------------
index 90277af..c622426 100644
Binary files a/spyderlib/images/editor/run_settings.png and b/spyderlib/images/editor/run_settings.png differ
---------------------- spyderlib/images/filetypes/js.png ----------------------
new file mode 100644
index 0000000..ae6b907
Binary files /dev/null and b/spyderlib/images/filetypes/js.png differ
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1522

From pierre.raybaut on 2013-08-20T09:33:39Z
This issue was updated by revision 280f6fe7aaae .
@-Carlos: I assumed that you draw by yourself the new icons that you introduced in Spyder
(they are all under the Spyder License Agreement). Please correct me if I'm wrong.
Status: Fixed

From ccordoba12 on 2013-08-23T15:04:41Z
Labels: MS-v2.2.3

From pierre.raybaut on 2013-08-21T05:01:10Z
Status: Fixed


Install of the CLI fails

When using this action with the following yaml
- name: Setup Phrase CLI
  uses: phrase/setup-cli@v1
  with:
    version: 2.19.3

it fails to install the CLI with the following error message:
Run npm install -g json
  npm install -g json
  shell: /usr/bin/bash -e {0}
npm ERR! code EACCES
npm ERR! syscall symlink
npm ERR! path ../../../lib/node_modules/json/man/man1/json.1
npm ERR! dest /usr/local/share/man/man1/json.1
npm ERR! errno -13
npm ERR! Error: EACCES: permission denied, symlink '../../../lib/node_modules/json/man/man1/json.1' -> '/usr/local/share/man/man1/json.1'
npm ERR!  [Error: EACCES: permission denied, symlink '../../../lib/node_modules/json/man/man1/json.1' -> '/usr/local/share/man/man1/json.1'] {
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'symlink',
npm ERR!   path: '../../../lib/node_modules/json/man/man1/json.1',
npm ERR!   dest: '/usr/local/share/man/man1/json.1'
npm ERR! }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It is likely you do not have the permissions to access this file as the current user
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator.

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/[2](actions/runs/8596340083/job/23558778567#step:4:2)024-04-08T10_10_01_728Z-debug-0.log
Error: Process completed with exit code 24[3](actions/runs/8596340083/job/23558778567#step:4:3).

Hi @ueman, is it possible that the command npm install -g json is coming from somewhere else than this CLI action? The whole run logic is in this file and it's not trying to install the json package globally: https://github.com/phrase/setup-cli/blob/main/index.js

Oh you're right thanks! Sorry for the inconvinience


Add E2E option to patch SHARED_MESH_CONFIG (#46074)

Add shared mesh config option to e2es

rm artifacts files

Update methods

Remove extra flag

Adjust spacing

Import istio

fix return

Fix nil check

Fix var assignment

Fix flag

Please provide a description of this PR:
Resolves: https://github.com/istio/istio/issues/46788

@nshankar13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio_release-1.18
fe0e179dc30b80e492aa42044bb9be403b286b4b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes


fix: Name fee is empty

Description

resolves #727
Not sure why it stopped working now. I believe all was working before, there has not been any change in files for a year.
Demo
https://github.com/aeternity/aescan/assets/15363559/2f936ea6-ab6d-4947-a8a6-89f4f9d3b063
Checklist:

[x] I have read and followed the Contributing Guide

@janmichek to me it sounds something got removed from the mdw endpoint so I would first investigate that with them also to understand if fee / name fee are equal.

@janmichek to me it sounds something got removed from the mdw endpoint so I would first investigate that with them also to understand if fee / name fee are equal.

Question raised here https://aeternity-workspace.slack.com/archives/C04K21DM61L/p1713356209778889

@janmichek solution: the fee box should be hidden if nameFee is not available

@janmichek solution: the fee box should be hidden if nameFee is not available

fixed


kotlin version needed upgrade

having the following issues
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
The following dependencies do not satisfy the required version:
project ':document_file_save_plus' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50

was my mistake, instaled old version of this plugin, am on latest now


Report offenses, ignoring source code disable comments

Is there an existing config we can set when running rubocop that reports all offenses, ignoring any source code comments that might be in place to inline disable a rule? I might have missed it but didn't see it in: Basic usage

Yes there is. It's the ---ignore-disable-comments option, which you can get from ruboco --help, but which didn't make it onto the Basic usage page. I guess we'll have to assume that someone made the decision at some point that it was an advanced option and didn't list it with the basic ones.


Manage Users Index

Made changes as per the Open Source Docs Migration Plan.
Purpose of this pull request
This pull request (PR) to edit the Manage Users Index under Users and Roles.
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

looks great

Thanks Kim!


Implement werf.io/show-logs-until annotation

Depends on https://github.com/flant/kubedog/issues/168.
Werf resource annotation to control deploy logs behaviour:
werf.io/show-logs-until: ControllerIsDone|PodIsDone(default)|EndOfDeployProcess

Too complex (requires low-level trackers refactoring), too little value. Does not fit in the Task paradigm of Kubedog Dynamic Tracker, where we stop further processing as soon as task is completed. Won't implement.


chore(mojaloop/#3459): nodejs upgrade

chore(mojaloop/#3459): NodeJS version upgrade - https://github.com/mojaloop/project/issues/3459

Upgraded nodejs from v16 to v18 LTS
Applied CI changes as previously implemented in sdk-scheme-adapter
Updated NPM dependencies
Resolved all audit issues
Migrated master branch to main branch

Completed in https://github.com/mojaloop/ml-testing-toolkit-ui/pull/181


Add full round trip integration testing for all attribute rule types

We need to test the full flow of the platform. Add integration tests that encrypt and decrypt with different types of attributes. Ensure that certain clients/users are able to decrypt and others are not.
Possible setup:
Attributes:

AllOf -- Language: French, English, Spanish
AnyOf -- Colors: Red, Blue, Green
Hierarchy -- Cards: King, Queen, Jack

// maybe test with a user as well
Mappings for '.clientId' == opentdf-sdk:

English, Red, Queen

Runs:
Success:

encrypt with English
encrypt with Red
encrypt with Red and Green
encrypt with Jack
encrypt with Queen
encrypt wtih Engligh, Red, Green, Jack

Failures:

encrypt with English and French
encrypt with Blue
encrypt with King
encrypt with English, French, Red, Green, Queen
encrypt with English, Blue, Green, Queen
encrypt with English, Red, Green, King

Blocked by https://github.com/opentdf/platform/pull/759 and possibly https://github.com/opentdf/platform/issues/786


proxy now works, needs more tests

[x] Proxy working
[x] basic tests
[ ] further tests
[ ] enable cors for this request

Interesting travis might have some proxy for external resources, this needs further testing

r+


Pop Back...

I'm trying to implement the equivalent of Navigator.pop(context) in this architecture's Navigation Service.
the scenario is i have transitioned from ViewA to ViewB and that works fine... the transition is great ...
In ViewB i have a button to go back ... and in my onTapped I call a function on the model something like Future navigateBack() async {} ...
In this function if i do ... await _navigationService.navigateTo(Routes.viewA); ... it works but the transition is not great and looks wonky.
if I do await _navigationService.navigateWithTransition(HomeView(), transition: "leftToRight",); it works, the transition is better but not really the same as if I had to do Navigator.pop(context)
is there another call that i need to use?
Also note in the video you emulate on Android, which has a hardware back button which we don't have on iOS...
The transition i am after on iOS is the same as if I had to swipe the page to the right... which behaves like Navigator.pop(context);

So I solved this issue with passing my context from my view to the model and then executing Navigator.of(context).pop(); there...
The question is shouldn't this functionality be supported by the Navigation Service out the box? I would argue that going back is a navigation route!

@PeerLabs this is supported in the stacked services.  If you're using get you don't need the context.

@PeerLabs you need to pass current page route in the back({dynamic result})
Example

locator().back(result: Routes.profileViewRoute);

or

_navigationService.back(result:` Routes.profileViewRoute);


Disallow filter with non-existant tags

closes #94

Codecov Report
Base: 79.86% // Head: 80.11% // Increases project coverage by +0.24% :tada:

Coverage data is based on head (f45c471) compared to base (c0d0ea5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     79.86%   80.11%   +0.24%
- Complexity      665      674       +9
============================================
  Files            91       91
  Lines          1788     1800      +12
  Branches        209      210       +1
============================================
+ Hits           1428     1442      +14
+ Misses          288      286       -2
  Partials         72       72

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...edu/address/logic/commands/FilterClearCommand.java
95.23% <100.00%> (+0.23%)
:arrow_up:

...va/seedu/address/logic/commands/FilterCommand.java
94.11% <100.00%> (+2.45%)
:arrow_up:

.../java/seedu/address/logic/commands/TagCommand.java
93.33% <100.00%> (ø)

...address/model/person/TagMatchesQueryPredicate.java
100.00% <100.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
78.89% <0.00%> (+1.83%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


The Right Click Auto Selects an Option

System Details

OS: Ubuntu 24.04 (Mint 22 XFCE)
Thorium Version: 126.0.6478.231 (AVX2)

Problem
Basically the bug consists in the fact that when you do a right click to open the context menu, if your mouse pointer it's over some menu's option, this option will be triggered.
Did you read the FAQ?
Yes.
Additional Notes

You can see more details about this bug here https://github.com/microsoft/vscode/issues/113175
It's a well-known bug on the vscode app as well.
You can mitgate this bug by hold the right click while move the mouse pointer.

@Alex313031 Sorry for tagging you here, but to mitigate this problem would it be possible to make the mouse pointer always stay outside the clickable area like Firefox/Mercury? I believe that is the best possible approach for this.

Looks more like a problem upstream or caused by a problem in DE.

It could be, for sure, but i don't know. Btw I've tested Thorium ia a different distro and the it's the same. Tried the stock Chromium on both and it doesn't happend.


No colors for some prompt themes

In the example above, only the funky and possibly agnoster themes appear to be colored correctly (though I'm missing the necessary fonts for agnoster), while the rest are either correct except for colors or even entirely broken. Colors seem to be working correctly otherwise; it's only the prompt theme I seem to be having trouble with.
I use grml-zsh-config and I'm trying antigen for the first time. I'm on Arch Linux and I've installed gmrl-zsh-config-git and antigen-git via the AUR.  Here is my ~/.zshrc:
# vi keybindings
set -o vi
bindkey "^?" backward-delete-char
bindkey "^H" backward-delete-char

# "prompt off" disables gmrl's prompt theme
# this is necessary to let antigen themes work properly
prompt off
source /usr/share/zsh/scripts/antigen/antigen.zsh
autoload -Uz colors && colors
setopt promptsubst
antigen use oh-my-zsh
antigen bundle zsh-users/zsh-syntax-highlighting
antigen bundle git
antigen theme bira

I've discovered that unsetting the TERM environment variable seems to fix the color issues, but the robbyrussell and simple themes are still missing components as shown above.  I think the missing components appears to be a separate issue, so I'll open a new issue for that later.
However, unsetting TERM has some undesirable side effects and seems like a bad idea in general to me. FWIW, I'm using Terminator as a terminal emulator and my TERM variable was set to xterm. I haven't found any values of TERM besides a blank string that fix the color issues.
I'm not sure if the grml config is related at all.  grml doesn't seem to be messing with TERM directly, but there may be a more subtle conflict between grml and antigen.

Let this be a warning against troubleshooting and filing issue reports at 2:30am :stuck_out_tongue_winking_eye:
The grml config does not seem to be related; removing it has no effect on the issue.

Ok, nevermind, this issue is a false alarm. After some troubleshooting, I determined that the color palette (Solarized Dark) in my terminal emulator (Terminator) simply had too little contrast for me to tell apart some of the colors, especially the "bold" colors. I'm a bit colorblind, which I'm sure doesn't help. The reason that unsetting TERM "fixed" the issue was because it effectively disabled bold colors - without a TERM variable, zsh was unable to initialize $terminfo to an appropriate value, and since many themes use $terminfo[bold] rather than $fg_bold for bold colors, the normal colors, which I could distinguish, were displayed instead of the intended bold colors/
Now I'm off to find a better colorscheme...


JB-Hi-Fi

Added JB-Hi-Fi deletion instructions and link in its appropriate position alphabetically.

Thanks for your contribution!


Data gap 9.1.1

Data received, pending dissemination to fill the data gap.

July 11th

Indicator is updated. Do we want to add census subdivisions? Or another disag?


Remove main method wrapper from all test files.

All of the test files are current wrapped in a main method which is no longer necessary. The describe block can simply exist on the top level.

Closed via #494


Bug: Deployment status isn't visible for few seconds when we open the modal

📜 Description
Deployment status isn't visible for few seconds when we open the modal
👟 Reproduction steps

Deploy any app on GitOps
Go to app details page for same env and check deployment status

👍 Expected behavior
Live deployment status should be visible
👎 Actual Behavior
Deployment status is visible after few seconds
☸ Kubernetes version
EKS 1.23
Cloud provider

AWS

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#4955

Fixed by https://github.com/devtron-labs/dashboard/pull/1194


md-select deselects when the value is 0 (instead of selecting the item with value of zero)

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Selecting the value 0
What is the current behavior?
Deselects everything
What are the steps to reproduce?
One your changes for version beta 6 is:
"select: allow option with undefined or null value to clear selection (#3141) (13524c1), closes #3110 #2634"
This causes the issue of deselecting if the value is 0. So it deselects the mdselect if it's null or undefined or zero.
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
beta 6
Is there anything else we should know?

This has been fixed in master and will be in the next release. See https://github.com/angular/material2/commit/2e3910c86c1a1486222f639bb9404aaaf5661d9b.

Perfect. Thanks

I checked the link and I guess it's a different issue. My problem is that when my ngModel is zero, instead of selecting the option zero, it deselects it all.

It should be the same issue. Can you reproduce it in a Plunkr? You can use this one which runs the latest build.

We had a similar PR today and I wasn't able to reproduce it in this Plunkr. I'm not sure whether you have a different setup though.

Here is the plunker:
http://embed.plnkr.co/showVK2SkoBhUyBFOyKr/
but I'm getting a strange error:
"Can't bind to 'ngModel' since it isn't a known property of 'md-select'"
how come???!!!

It's because the template doesn't include the FormsModule. Here's a fixed version and it also looks like selecting 0 works.

Thank you for fixing the issue. Is the plunker you sent the one in dev (fixed) or beta 6 (released)?

The Plunkr is using the latest master build.

Perfect! so it's fixed.

Any idea when the next release is that will deliver this fix?

Good question. I would love to know too.


chore: fix ci.yaml

The needs contexts were pointing to old job steps.
Invalid workflow file: .github/workflows/ci.yaml#L58](https://github.com/knative/func/actions/runs/3237468662/workflow)
The workflow is not valid. .github/workflows/ci.yaml (Line: 58, Col: 12): Job 'build-and-publish' depends on unknown job 'test'. .github/workflows/ci.yaml (Line: 98, Col: 12): Job 'publish-image' depends on unknown job 'test'.

/kind bug

/lgtm


Allow users to react to certain events

As a user, you might be interested in note flows and lifecycles specific to your application only. In this sense, the client does not currently provide many mechanisms to programmatically react to events in a specific manner. In other words, in order to update the local view of the blockchain, the user needs to periodically call the Client::sync_state() API which updates the local entities based on the information that it requests and receives. These information is, in turn, based on the previous state (for example, nullifiers are requested for any note that the store is tracking as Committed) and tags (which can be added and removed by the user).
It would be useful for the user to have a way to react to certain events. In general, any received updates might be of interest to the user depending on the application, but some that come to mind as important are:

Notes matched by tags: It might be of interest to the user to update some other part of the application state based on received notes, or decide which received notes are stored, since tags only partially provide this functionality. This is somewhat related to the NoteScreener which already does this filtering, so perhaps it could be solved by adding a way to programmatically add checks here.
Notes being consumed (matched nullifiers).
Transactions getting committed/canceled: This might not be as important, since reacting to updates is currently virtually similar to just manually searching for transactions after syncing. Perhaps this can be solved with just changing the APIs accordingly (for instance, just returning a list of rejected and accepted transactions after a sync).

The mechanisms through which the user could react to these events (event queues that can be consumed, trait objects, callbacks, channels, etc.) can be discussed separately.

Notes matched by tags: It might be of interest to the user to update some other part of the application state based on received notes, or decide which received notes are stored, since tags only partially provide this functionality. This is somewhat related to the NoteScreener which already does this filtering, so perhaps it could be solved by adding a way to programmatically add checks here.

I'm wondering if the current NoteScreener can somehow be "morphed" into this customizable functionality. For example, conceptually we could have some on_note_detected() method that could take a note as an input and return NoteConsumability.
Or we could take it even further on_note_detected() look something like this:
pub fn on_note_detected(&self, note: CommittedNote) -> Result<Option<NoteWithProof>, SomeError> {
    ...
}

The default implementation of this method would do all the work of transforming a CommitedNote into some struct (NoteWithProof) which will then be upserted into the store. But the user will be able to override this functionality with a custom implementation.
Not sure if the above makes sense yet - just brainstorming the ideas.

Two separate functionalities are mentioned here:

Being able to influence the client functionality, in this case when receiving new notes or when analyzing it's consumability.
Notify the user when certain note transitions happen.

I think they should be tackled in separate PRs

After working a little bit on the miden order book, I feel like this type of functionality could have been used for some quality of life improvements. Specifically, if we could somehow let the Client know which custom notes are consumable by which tracked accounts. In the order book, for example, we could hide non-consumable orders (there are some orders the user may not have enough funds to fill) by simply calling client.get_consumable_notes when listing.
In terms of specific note events, with the new input note state handling we have some better defined events which we could notify the user when they happen. I'm not sure how difficult would it be to add this, but I think it would be more granular than just detecting new notes.

Yes, there should be probably multiple PRs to implement various aspects of what is discussed here. I think first we need to figure out how the user can "plug in" certain functionality into the client (i.e., come up with a general approach) and then we can figure out what specific things we may want to extend.
A much more radical approach could be to break the client into independent components somehow which the user would then be able to compose to in the ways they see fit (in this model CLI would demonstrate how these components can be combined to build a user-facing client).

I think a simple but maybe effective approach would be if we could have a component in Client that looks something like this:
pub struct Client<R: FeltRng> {
    // ...
    listeners: Vec<Arc<dyn NoteEventListener>>,
}

and we could provide at least a default event listener that essentially replaces NoteScreener:
struct StandardNoteScreener;

impl NoteEventListener for StandardNoteScreener {
    fn on_input_note_synced(&self, note: &Note, new_status: NoteStatus) -> NoteEventOutcome {
         // Check if note is P2ID, P2IDR or SWAP and if so return the correct outcome
    }

    fn on_input_note_state_changed(&self, note: &Note, old_status: Option<NoteStatus>, new_status: NoteStatus) {
    }

    fn on_input_note_discarded(&self, note: &Note) {
    }

    fn on_nullifier_spent(&self, note: &Note) {
    }

    // ...
}

let mut client = Client::new(/* args */);
client.add_listener(MyListener);

// Or perhaps have a builder API for the client

ClientBuilder::new(store, rpc)
    .with_prover(RemoteTransactionProver::new(endpoint))
    .with_listener(StandardNoteScreener) // Should probably be a default
    .with_listener(CLOBNoteEventListener);

Where NoteEventOutcome would describe if the client should keep the note, discard it, save it as an input note (for output notes), maybe even completely remove them from the store, etc. Obviously function signatures here and events are just a draft.
Or maybe we could add these event listeners to NoteScreener and have that be a more explicit component of Client.
It feels like as the protocol evolves, this would be a good way to progressively build toward a more "reactable" client since it should be (hopefully) fairly backward compatible as long as fundamental lifecycles don't change too much.
One problem that would need solving with this (although it already exists with user-added note tags), is that if users create an incorrect set of event listeners but the client has already synced past the point of "interesting" events then there might be some information loss there, so maybe there should be a special way to sync from-to specific blocks, but this is outside the scope of this issue.

I like the idea of the NoteEventListener instead of an exposed event queue. I remember @SantiagoPittella also mentioned, in one of our meetings, having specific callback functions for these events. These could be set up like the listeners:
ClientBuilder::new(store, rpc)
    ...
    .with_new_note_received_callback(custom_clob_callback);

This approach may be simpler, but we wouldn't have the reaction functions centralized in one struct (which is something I personally prefer). Especially if we could have default implementations for most of the methods so that users only implement whichever they prefer.

A much more radical approach could be to break the client into independent components somehow which the user would then be able to compose to in the ways they see fit

I'm not sure if I understand this completely. Do we mean having the user implement specific components? (like what we do with the store and rpc). Maybe by having well defined interfaces for the NoteScreener and creating objects that deal with the internal sync and transaction workflows this could be possible. The user would need to have a good mental model of how the client works and deals with state changes (this is also true for the previous approach, I think improving the public documentation of these workflows will be an important part of the changes).

I'm not sure if I understand this completely. Do we mean having the user implement specific components? (like what we do with the store and rpc). Maybe by having well defined interfaces for the NoteScreener and creating objects that deal with the internal sync and transaction workflows this could be possible. The user would need to have a good mental model of how the client works and deals with state changes (this is also true for the previous approach, I think improving the public documentation of these workflows will be an important part of the changes).

I don't have any well-formed ideas on this, but the general idea was to provide more "stand-alone" components that the user would be able to combine in various ways that we cannot currently anticipate.
For example, one such component could be StateSync component. We'd instantiate it with some set of parameters (e.g., note tags, nullifiers, etc. we are interested in) as well as some sub-components (e.g., RPC to use to make requests to the network). Then, we'd call sync() on it and it would run the sync and give us all the relevant data, but without saving it to the store. So, basically, StateSync becomes an independent component that can be used even outside of the Client. Then users would be able to compose it with the Store component as they see fit.
Not sure if this specific example makes sense, but that's roughly what I was thinking here.

Yeah, I think I understand better now. I do think this is a separate issue that the one about events. I created issue #643 to track this and will be adding some ideas.
Both of this issues are related though. If we have better defined stand-alone components that users can compose/modify and we clearly define their interactions, then users can change them and they would serve as glue between the client processes and the user functionality.


[bug] Composite primary key constraint fails

Describe the bug
Unable to apply a multiple column primary key
Steps To Reproduce
Simple model:
select
'a' as col_1,
'b' as col_2

adding col_1 as the PK works as expected.
models:
  - name: model_a
    config:
      contract:
        enforced: true
    columns:
      - name: col_1
        data_type: string
        constraints:
          - type: not_null
          - type: primary_key
      - name: col_2
        data_type: string
        constraints:
          - type: not_null

models:
  - name: model_a
    config:
      contract:
        enforced: true
    columns:
      - name: col_1
        data_type: string
        constraints:
          - type: not_null
      - name: col_2
        data_type: string
        constraints:
          - type: not_null
    constraints:
      - type: primary_key
        columns: [col_1, col_2]

However, updating to try and use a composite primary key does not work.  In the second scenario it tries to create the primary key

alter table model_a add constraint 0a36b673f037eb84f703cefef2531521 primary key(col_1, col_2);

However, it is not setting the two columns as not_null first and so creation of the PK fails.

: Cannot create the primary key 0a36b673f037eb84f703cefef2531521 because its child column(s) col_1 is nullable. Please change the column nullability and retry.

Expected behavior
The columns are set to NOT NULL before the primary key is applied
Screenshots and log output
`       create or replace table `model_a`

    using delta
      as
    select col_1, col_2
    from (
select
'a' as col_1,
'b' as col_2
    ) as model_subq`

alter table `model_a` add constraint 0a36b673f037eb84f703cefef2531521 primary key(col_1, col_2);

18:59:38 Databricks adapter: Cursor(session-id=01ef186d-6818-15d1-b37f-1642bf4c4ff9, command-id=Unknown) - Closing cursor
18:59:38 Databricks adapter: Exception while trying to execute query
/* {"app": "dbt", "dbt_version": "1.7.14", "dbt_databricks_version": "1.7.15", "databricks_sql_connector_version": "2.9.6", "profile_name": "user", "target_name": "dev", "node_id": "model.databricks_analytics_dbt.model_a"} */

        alter table `model_a` add constraint 0a36b673f037eb84f703cefef2531521 primary key(col_1, col_2);

: Cannot create the primary key `0a36b673f037eb84f703cefef2531521` because its child column(s) `col_1` is nullable. Please change the column nullability and retry.

System information
The output of dbt --version:
18:59:18 Running with dbt=1.7.14
18:59:18 Registered adapter: databricks=1.7.15

DBT Cloud
The output of python --version:
Additional context
Add any other context about the problem here.

Do you happen to know if you see the same behavior without using a composite key?  It seems from your description that the core issue is that not-null constraints need to be applied first, which I would think would be a problem regardless.  Thanks for reporting.

The same error occurs if I just have col_1 in the primary key.
So really its the difference of primary_key being added in the column constraints definition, which works correctly and applies not_null then primary_key. Compared to putting it at the model level constraints which is not first applying the not_null property. So it would seem order of operations would need to be apply column level constraints, then model level ones. I'm not sure if that breaks for any other combinations though.

Probably stating the obvious, but can confirm this is also present in 1.8.3

There is actual code to make sure the not_null is applied first: https://github.com/databricks/dbt-databricks/blob/ec63dce4ff287756ce1821d4f6d2f36b756fb8b2/dbt/include/databricks/macros/relations/constraints.sql#L82


Include subgroup checks when deserialising points

Checking the code here : https://github.com/ethereum/c-kzg-4844/blob/main/src/c_kzg_4844.c#L498 It seems that we are not checking whether points are in the subgroup and are just checking whether points are in the group.

Is there a test we could add to one of the bindings that would expose this issue?

Yes we should figure out if we can add a test.

This is kinda what we are looking for https://github.com/ethereum/bls12-381-tests/blob/master/main.py#L599

We added unittests for this in https://github.com/ethereum/c-kzg-4844/pull/102

So we can close this now right? I will close but reopen/message me if incorrect.


[New Port Request] include-what-you-use

Library name:
include-what-you-use
Library description:
A tool for use with clang to analyze #includes in C and C++ source files
Source repository URL:
https://github.com/include-what-you-use/include-what-you-use
Project homepage (if different from the source repository):
https://include-what-you-use.org/

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Update Badge design

Remove border for light variants
Allow leading and trailing icons

@PavelHolec where is the leading/trailing icon version from? I can only see the text OR icon versions in figma at https://www.figma.com/file/YMfJkmUMV8xiY7fgeW6QAr/[Orbit]-Native-Components?type=design&node-id=468-801&t=YZ10OTk30SNzpZCQ-0

@PavelHolec where is the leading/trailing icon version from? I can only see the text OR icon versions in figma at https://www.figma.com/file/YMfJkmUMV8xiY7fgeW6QAr/[Orbit]-Native-Components?type=design&node-id=468-801&t=YZ10OTk30SNzpZCQ-0

It is taken from the component. New figma component composition has a tradeoff in terms of visibility for devs - it does not show all variants/combinations - it needs to be used in a draft for example, to be able to explore all options.

Done in #525.


doc: fix markdown

Basics

[ ] I added a line to changelog.md
[ ] The PR is rebased with current master.
[ ] Details of what you changed are in commit messages.
[ ] References to issues, e.g. close #X, are in the commit messages and changelog.
[ ] The buildserver is happy.

Checklist

[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added automated tests or a manual test protocol
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
[ ] Code is consistent to our Design Decisions
[ ] Exceptions to any guidelines are documented

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] I've read through the whole documentation
[ ] I've checked conformity to guidelines

Great, thx for the PR! :heart:
@4ydan can you check if this works for you and also fix the CI so that such errors cannot pass in the future?

@danielsteinkogler pls add changelog, otherwise it works for me, good job! :heart:

Great job! make test-mdbook now runs again flawlessly (and does not return 2 anymore). It is still unclear why CI did not fail.


Fix a bug with early text parser reinitialisation (issue #2237)

Fix a bug #2237 with early text parser initialisation when switching between text tracks with different MIME types

I signed it!

@googlebot I fixed it.

@googlebot I fixed it.

@googlebot I fixed it

@googlebot I fixed it.

@googlebot I fixed it. CLA is signed.


D3Net: inference on CPU

Separation of one source (vocals) from 3-minute track using D3Net takes ~2.5 hours on machine with 4 cores. Is there a way to speed up inference on CPU?

Thank you for checking!
Yes, it takes a bit long time. We would like to share how to reduce inference time.
Please give us some time to check and summarize.

We've added an inference script which runs the model on OpenVINO runtime by Intel which should be faster.

In previous script, nnabla and openvino were not separated.
So we prepared script that can be run in openvino only environment.
https://github.com/sony/ai-research-code/pull/30
In my environment, original d3net-mss takes 554m49sec by cpu, but openvino (4cpus) takes 8m53sec.


cdls bug

In cdls, the change directory command should use all of the passed in commands, not just the first one.
Change:
cd "$1"
ls

to:
cd "$@" && ls

Resolved with #24.


[packagers] Readme of homebrew tap points to wrong repository owner

Task List

[x] Steps to reproduce provided
[ ] Stacktrace (if present) provided
[ ] Example that reproduces the problem (link to git repository is ideal)
[x] Full description of the issue provided (see below)

Steps to Reproduce

Configure a brew packager.
Configure a different owner for the tap repository than the one used for the release
Execute jreleaser prepare
Inspect the generated README.md file

Expected Behaviour
The name of the tap repository owner matches the configured tap owner and not the release owner.
Actual Behaviour
Both release owner and tap owner are the same.
FWIW the name of the tap in the readme may also be wrong. The default is homebrew-tap but one can change the name to homebrew-tools for example. The readme uses "tap" everywhere but it should match the configured value
Environment Information

Operating System: N/A
JReleaser Version: 1.3.1
JDK Version: N/A

Released in v1.4.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.4.0


Some field names in the sqlite database have Nullable types that's awkward to handle in Python

Here's an example of the issue:
https://github.com/DHI/mikepluspy/blob/891dfbec466b20ec3267a68232a0464766bdd9f2/notebooks/run_multiple_rainfall_events.ipynb#L200-L202
The preferred syntax would be for python integers to work, without needing to wrap them in System.Nullable.

Isn't that the job of this library. The user supplies a value, either an int or None, and mikepluspy translates it to a .NET nullable int if if goes through a .NET DAL?

Verify pass with MIKE+ Development branch 2004.03.29.
Now we can modify the test script:
"         VariationNo = 3, # set temporal variation to timeseries\n",
"        FlowTypeNo = 5, # set boundary condition type to Rainfall\n",
"        LoadTypeNo = 1, # set load type to stormwater runoff\n",


Add parsing of OpenStreetMap links to allow accurately setting locations for HC

I added a simple parsing based on RegEx to factory/runs.py, which allows manually copying an OpenStreetMap link into the Location URL field on Wordpress, that is then hopefully used as a base for defining the location of the events in HC. This would also allow precisely defining meeting points for hashes, while the displayed location could still be a station name, for example.

Great idea, should we add a google maps variant as well?

That would be nice, but I haven't figured out how to get a link with coordinates by clicking on the map in Google Maps, and the API access seems to be a bit tricky.


[SS4.1] Any docs about Session USER_AGENT usage

Just found following code at Session::init()
// Funny business detected!
        if (isset($this->data['HTTP_USER_AGENT'])) {
            if ($this->data['HTTP_USER_AGENT'] !== $this->userAgent($request)) {
                $this->clearAll();
                $this->destroy();
                $this->start($request);
            }
        }

I'm curious why? I use "Random User-agent" plugin for testing and to protect my browser against fingerprinting. It won't protect u against man in a middle attacks by HTTP cuz it's easy to get your user-agent and cookies. And it doesn't looks like it even works cuz random user-agent will return "Your session was expired" only when u will use AJAX request, but new session will be created on refresh using cookies and it will work again

Closing this in favour of https://github.com/silverstripe/silverstripe-framework/issues/8073, there’s more detailed discussion in that issue already :)


java hashicorp vault integration

PR to add support for vault in java as requested in #167

Thanks, this is awesome! We'll merge this, but maybe not in 1.5.0 because it'll take us some time to import HashiCorp Vault API to our internal repo.

Scratch my last comment. This looks so good that I think it should make 1.5.0. I'll review early next week.

It looks like this won't make 1.5.0, as there's a few things that I want to discuss before merging.

@thaidn @rosstimothy are there any updates on the above, and is there anything an external contributor could do to help things along? We are also very interested in using Tink in conjunction with Hashicorp Vault.

@thaidn what else do I need to do to get this merged?

Is there a plan to get this integrated and released?


Allow multiple puncts in a row in NodeName

Removed NodeNameFragment::peek_any, since this function should always return true because it can be NodeNameFragment::Empty. This allows NodeNameFragment::Empty to actually separate puncts which allows multiple puncts in a row to be parsed as NodeName::Punctuated

@PizzasBear Hi, Thanks for contribution, could you please add a test for that case?

I've added the test

Codecov Report

Merging #42 (fd3630c) into main (12753af) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

:exclamation: Current head fd3630c differs from pull request most recent head ba78bbb. Consider uploading reports for the commit ba78bbb to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   76.86%   76.80%   -0.07%
==========================================
  Files          12       12
  Lines         752      750       -2
==========================================
- Hits          578      576       -2
  Misses        174      174

Files
Coverage Δ

src/node/node_name.rs
75.00% <100.00%> (+0.40%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Provide example configurations

now that documentation is mostly taken care of, the main thing missing to make eww approachable is good examples. These examples should include both the css and xml and explain how and why things are used the way they are. It should also be shown how a script can be used to change the eww-state from outside. The use of the literal tag as well as script vars (both interval and tail) should be included.
These examples may in the future be used in the CI-pipeline as a means of veryifying that changes don't brake existing functionality.
acceptance criteria

example widget config fulfilling the criteria stated above is implemented.
screenshots showing the widgets are provided.
examples are mentioned in the appropriate places in the documentation.

@Swexti would you be willing to look into this? just writing a couple minimal, functional examples that showcase the functionality and configuration of eww

uh, idk, how in-depth do i have to go with "explain how and why things are used the way they are"? Like a tutorial? Or just a short description of what it does?
so e.g:
If we take a look at this script we can see that once it gets the weather information (shown by the `weather=$("curl wttr.in")`), it tries to find what `if` tag equals the weather. So if the weather is Rain and we have two if fuctions that look like this:
`
if [ $weather = 'Sun']; then;
   eww update weather Sunny
elif [ $weather = 'Rain';] then;
   eww update weather Rain
`
It matches the secon if tag (the elif) with 'Rain' since the $weather = Rain. And since the $weather isn't Sunny, it doesn't match with `$weather = 'Sun'

After that it updates the `<script-var>` to match what weather information it gave with `eww update weather <weather>`

or something like
This script updates the `<script-var>` once the weather information matches the `if` tag.

just some actual, full configurations with a couple short comments that explain the non-obvious stuff. so more like version 2 :D

non-obvious stuff

ah okay i thought i had to explain everything. But i don't have to do like This is the <image> tag, it displays an image with the specified width and height? Since the widget documentation takes care of that?

yea, exactly. no need to explain everything, it's mostly just about having examples. just write some stuff and i'll tell u where some comments may be good

ah okay

perfect, I'll assign you!

bruhhh, i know this is an example, but still

if [ $weather = 'Sun']; then;
   eww update weather Sunny
elif [ $weather = 'Rain';] then;
   eww update weather Rain

You quote the plaintext argument, but not the variable, which should be in double quotes
you don't put a space before the end bracket, which will just not work
on the second one you put the ; before the end bracket, and you put ; after then, but not after the eww command? I can understand preferring lines to end with ;, but i dont even know here

bruh

Has there been any progress on this? I'd really like to see some example configs since the docs only cover so much. For example, I've seen the templates when the link to this repository is shared and it looks great! I'd really love to see some sample configs but I understand we all have our lives and managing time can be hard. Still, I'd really like to see some progress on this subject

Oh wow, you created a gh account (presumably) just to comment here
@elkowar you're famous

@Axarva you started work on this, correct?

@Axarva you started work on this, correct?

Yes, it's going a bit slow but it definitely is going on
One question, where are we going to provide these configurations? In a subdirectory of the repository on some other place?

Yes, it's going a bit slow but it definitely is going on
One question, where are we going to provide these configurations? In a subdirectory of the repository on some other place?

@Axarva any progress on this?

@Axarva any progress on this?

I'm finished, here's a screenshot

I'll add some more comments in the XML file, and I'll be fully done, except if you have something to edit here.

I'm finished, here's a screenshot

I'll add some more comments in the XML file, and I'll be fully done, except if you have something to edit here.

Since there is no updates on this, i thought to myself "Why don't you go back and do it? You're I was assiged anyways." Although Axarava did one, i thought widget like examples would fit better. So i'm taking the task to do it, and I'm actually gonna do it this time.

Since there is no updates on this, i thought to myself "Why don't you go back and do it? You're I was assiged anyways." Although Axarava did one, i thought widget like examples would fit better. So i'm taking the task to do it, and I'm actually gonna do it this time.

@Swexti After all, the more the merrier :)

@Swexti After all, the more the merrier :)

Examples are there! Although there is still room for improvement, I'll close this for now


Adds Support for Outlook.com

This PR adds support for Outlook.com events.

Codecov Report

Merging #9 into master will increase coverage by 1.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   88.63%   89.79%   +1.15%
==========================================
  Files           2        2
  Lines          88       98      +10
==========================================
+ Hits           78       88      +10
  Misses         10       10

Impacted Files
Coverage Δ

src/helpers/index.js
100% <100%> (ø)
:arrow_up:

src/ReactAddToCalendar.js
82.14% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef4066...3d1e358. Read the comment docs.

looks good! thanks for adding this!


Benchmark Adlink Ampere Altra Dev Kit - 64-core 2.2 GHz

I have been sent an ADLINK Ampere Altra Dev Kit with a Q64-22 CPU for testing.

I've installed 96 GB of Samsung DDR4 3200 ECC RAM, and would like to see how it compares to some of its beefier bretheren (see #10 and #17).

Running with this repository's non-Ampere-optimized blis setup:
TODO

Total system power consumption (average): 145W

Also going to try with Ampere's optimized config: https://github.com/AmpereComputing/HPL-on-Ampere-Altra

Optimized version, 655.9 Gflops, at about 140W again. So 4.685 Gflops/W
================================================================================
HPLinpack 2.3  --  High-Performance Linpack benchmark  --   December 2, 2018
Written by A. Petitet and R. Clint Whaley,  Innovative Computing Laboratory, UTK
Modified by Piotr Luszczek, Innovative Computing Laboratory, UTK
Modified by Julien Langou, University of Colorado Denver
================================================================================

An explanation of the input/output parameters follows:
T/V    : Wall time / encoded variant.
N      : The order of the coefficient matrix A.
NB     : The partitioning blocking factor.
P      : The number of process rows.
Q      : The number of process columns.
Time   : Time in seconds to solve the linear system.
Gflops : Rate of execution for solving the linear system.

The following parameter values will be used:

N      :  105000
NB     :     256
PMAP   : Row-major process mapping
P      :       8
Q      :       8
PFACT  :   Right
NBMIN  :       4
NDIV   :       2
RFACT  :   Crout
BCAST  :  1ringM
DEPTH  :       1
SWAP   : Mix (threshold = 64)
L1     : transposed form
U      : transposed form
EQUIL  : yes
ALIGN  : 8 double precision words

--------------------------------------------------------------------------------

- The matrix A is randomly generated for each test.
- The following scaled residual check will be computed:
      ||Ax-b||_oo / ( eps * ( || x ||_oo * || A ||_oo + || b ||_oo ) * N )
- The relative machine precision (eps) is taken to be               1.110223e-16
- Computational tests pass if scaled residuals are less than                16.0

================================================================================
T/V                N    NB     P     Q               Time                 Gflops
--------------------------------------------------------------------------------
WR11C2R4      105000   256     8     8            1176.66             6.5590e+02
HPL_pdgesv() start time Tue Oct 10 02:36:51 2023

HPL_pdgesv() end time   Tue Oct 10 02:56:27 2023

--------------------------------------------------------------------------------
||Ax-b||_oo/(eps*(||A||_oo*||x||_oo+||b||_oo)*N)=   2.33469497e-03 ...... PASSED
================================================================================

Finished      1 tests with the following results:
              1 tests completed and passed residual checks,
              0 tests completed and failed residual checks,
              0 tests skipped because of illegal input values.
--------------------------------------------------------------------------------

End of Tests.
================================================================================


Check size of keys slice

If not enough keys are provided to SetKeys, this may cause a panic. This
should not cause problems with the current integration in Docker 1.12.0,
but the panic might happen loading data created by an earlier version,
or data that is corrupted somehow. Add a length check to be defensive.
This is related to https://github.com/docker/docker/issues/24406.

LGTM

@aaronlehmann In the first RC keyring had 2 keys and later we changed it to 3 keys. So the length check should check for 3 (keyringSize variable) keys for each subsystem. But there are some pieces of code that handles 2 keys which were left around for graceful upgrade from earlier RCs. Those have to be cleaned up. As part of that PR I will change the length check as well.
This change LGTM as a defensive check to prevent the panic.


PP-6257 Improve transactions report

Include 'Sector' and 'Service went live date' columns in report.
Filter out all internal and archived services.
Filter out gateway accounts that do not have an associated service.
These can be assumed to be "archived".

Just noticed some minor white spaces.  Is this something we can remove?
I left a comment on one of the line.


[TA] Add values methods to ExpandableStringEnum models

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics


1.6.0 should be marked as latest release

When I look at https://github.com/fzaninotto/Faker/releases, 1.5.0 is still marked as the latest release.
This page also misses the 1.6.0 changelog.

Fixed: https://github.com/fzaninotto/Faker/releases/tag/v1.6.0
Thanks for the report


URLs "Run in Google Colab" and "View source on GitHub" are reversed.

The URL links at the head of http://github.com/tensorflow/hub/blob/master/examples/colab/object_detection.ipynb are reversed in order (ie. 'Run in Google Colab' links to github source, and 'View source on GitHub' links to the colab)

Not sure if this was somehow fixed in the meantime, but the links appear to be correct/properly ordered for me -- please double check & reopen if I'm missing something.


simple crafting table required in tinkers quest

Would love to know when this is fixed. Currently unplayable because of this. Also the store doesn't ever show anything

the store is a bug in that mod itself


requesting an open-source license (eg. MIT)

Thanks for the great work. Have you considered adding a license to your code so that people can reuse the code, modify it and distribute?
Github's default license is that no one has the right to reuse, modify or redistribute your code - https://choosealicense.com/no-permission/ unless you choose a different open-source license (such as MIT).

:+1:
It would be wonderful if you could add a licence. Thanks for the great work!

I have added a MIT license to this github repo.

Thanks for the great work. Have you considered adding a license to your code so that people can reuse the code, modify it and distribute?
Github's default license is that no one has the right to reuse, modify or redistribute your code - https://choosealicense.com/no-permission/ unless you choose a different open-source license (such as MIT).

I have added a MIT license to my github repo.

👍
It would be wonderful if you could add a license. Thanks for the great work!

I have added a MIT license to my github repo.


docs: add localization links

:white_check_mark: Build TheIdServer 1.0.0-i18n1-0102 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/e6d42e1058 by @aguacongas)


Stack Overflow in IE when creating an SVG.Image

I came across an issue in the SVG.image function in IE 11. It hit a stack overflow, which I was able to trace back to the SVG.BBox function called on create.
In particular it was the line in the try statement of SVG.BBox.create
if(!document.contains(element.node)) throw new Exception('Element not in the dom'),
which would send it to the catch where it would get caught on
if(element instanceof SVG.Shape){var clone = element.clone(SVG.parser.draw)
I was able to fix it with a polyfill to add IE's support for document.contains, however it really screwed me over for a few hours to track down.

Refer to #490 for the solution of this problem. The fix is already merged in the master. Unfortunately there was no release since then. Coming soon!

Done


fill-rule and clip-rule Warning

When using Tremor, the console displays these warnings:
Warning: Invalid DOM property 'fill-rule'. Did you mean 'fillRule'

Warning: Invalid DOM property 'clip-rule'. Did you mean 'clipRule'?

if it's possible, fix this issue. Thanks

Hey @Mrahmani71, thanks for submitting this, we will fix asap!


Publish pipeline options to flink web ui

This PR adds functionality to publish the job's pipeline option values to Flink's web UI (issue #26822). This is quite useful for debugging purposes where users can inspect the runtime arguments passed to the beam job, for flink runner.

------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @mxm @damccorm

Hi @mxm, would you be able to review this PR or point me to someone who would be the best candidate for this review?
Thanks!

Hi @damccorm, pinging you for review of this PR. Tagged you since you were the last one to update this file. Let me know if someone else would be better suited to review this PR. Thanks!

Hey @kkdoon unfortunately that was a non-functional change and I don't really have the context needed here.
@je-ik or @xinyuiscool would either of you be good reviewers for this change?

Hi @mxm, I addressed your review comments. Could you kindly re-review it again, when you get a chance.
Thanks!

@mxm re-pinging for review. Thanks!

Sorry for the delay on my side!

Thanks @mxm for the approval! Could you merge it from your side or something is pending from my side first?

Run Java PreCommit

@kkdoon Could you please file a JIRA for this change or link an existing one? Apologies, I just saw that the change doesn't have a JIRA associated yet.

@mxm i created issue #26822

@mxm re-pinging to see if it can be merged now. Thanks!

Thanks @kkdoon!!


Improve support for Terragrunt projects

Currently our CI/CD integrations ask users to read https://www.infracost.io/docs/iac_tools/terragrunt, which doesn't mention how the user should use Infracost with Terragrunt in those integrations. For example, for GitLab, they could currently do the following.
However, could we detect a Terragrunt project from --path and support this natively without the user having to create a config file? That would make it easier to run Infracost with Terragrunt projects that have many modules, as currently the user has to update the config file.

Create an infracost config file, called infracost.yaml, with:
version: 0.1

projects:
  - path: myproject/module1
    terraform_binary: terragrunt
  - path: myproject/module2
    terraform_binary: terragrunt

Test the above works locally, by running infracost breakdown --config-file infracost.yaml

Add a GitLab CI stage for infracost - the same can be done with other CI/CD integrations by setting the config file param:
  stages:
    - infracost

  include:
    # Use a specific version of the template instead of master if locking the template is preferred
    remote: 'https://gitlab.com/infracost/infracost-gitlab-ci/-/raw/master/infracost.yml'

  infracost-job:
    only:
      - merge_requests
    stage: infracost
    extends: .infracost
    variables:
      config_file: infracost.yaml

When supporting the terragrunt run-all commands we need to work out how to handle usage file parameters. Since this will show multiple projects, and each project can have the same resource names, then there's no way of scoping the usage file resources to a specific terragrunt module.
As an initial version we could apply the matching usage file values to all resources that match, but I would like to be able to set different values for my different terragrunt modules.

Currently for Terragrunt projects with a hierarchy we require each Terragrunt module to be specified in the Infracost config file. Using this method you can pass in a different usage file for each module.
version: 0.1
projects:
  - path: my/terragrunt/project/dev
    terraform_binary: terragrunt
    usage_file: usage-dev.yml
  - path: my/terragrunt/project/prod
    terraform_binary: terragrunt
    usage_file: usage-dev.yml

When we support Terragrunt as first-class, we will allow the root Terragrunt directory to be passed in, like:
version: 0.1
projects:
  - path: my/terragrunt/project

The issue with this is that we now cannot specify a different usage file for each module. Multiple Terragrunt modules may have the same resources, so we have no way of uniquely identifying them in the usage file.
To solve this we could:
Option 1: Update the config file to allow multiple usage files and specify which module they are for
For example:
version: 0.2
projects:
  - path: my/terragrunt/project
    usage_files:
      - match_path: 'dev/base'
        file: infracost-usage-dev-base.yml
      - match_path: 'prod/base'
        file: infracost-usage-prod-base.yml
      - match_path: 'dev/api'
        file: infracost-usage-dev-api.yml
      - match_path: 'prod/api'
        file: infracost-usage-prod-api.yml

Option 2: Update the config file to support multiple projects:
Both below examples are additive only so wouldn't break existing usage files.
Example A:
version: 0.1

# This contains the default resource usage
resource_usage:
  aws_lambda_function.my_lambda_function:
    monthly_requests: 20000
    request_duration_ms: 600

# This contains any overrides for the dev/base project
resource_usage[dev/base]:
  aws_lambda_function.my_lambda_function:
    monthly_requests: 100
    request_duration_ms: 600

Example B:
version: 0.1

# This contains the default
resource_usage:
  aws_lambda_function.my_lambda_function:
    monthly_requests: 20000
    request_duration_ms: 600

# This has any overrides/per-project usage
projects:
  - path: my/terragrunt/project/dev/base
    resource_usage:
      aws_lambda_function.my_lambda_function:
        monthly_requests: 100
        request_duration_ms: 600

Option X: Any other suggestions / comments on the above options?
We will also need to consider how this would work if we support auto-detecting Terraform workspaces or if we support Terraform monorepos (as per #490 and #188).

@ljhurst, @Ian-T-Price and @mikejk8s just FYI that we shipped improved support for Terragrunt in v0.9.7, see docs here: https://www.infracost.io/docs/iac_tools/terragrunt
We'd love to hear your feedback on it, and also https://github.com/infracost/infracost/issues/934 if you use the usage-file.


Improve ergonomics of the AUX struct

Currently, an instance of the corresponding Aux struct has to be created and then passed to the request, like so:
https://github.com/psychon/x11rb/blob/bcfe334da2aada4a0142213d1773517597cbd4a3/examples/simple_window.rs#L23-L26
https://github.com/psychon/x11rb/blob/bcfe334da2aada4a0142213d1773517597cbd4a3/examples/simple_window.rs#L33
This API is similar to what Xlib does and what libxcb does (when one opts-in to use this extra support, which apparently no one does). Still, it "feels weird" to have to write "create window" twice. Can this be improved somehow?

Slightly related: AsRef or Borrow could be used for the argument in create_window. That would at least get rid of the & in the call.

I can think of two ways to avoid this:
conn.create_window(24, win_id, screen.root, 0, 0, width, height, 0, WindowClass::InputOutput, 0)
    .event_mask(EventMask::Exposure | EventMask::StructureNotify | EventMask::NoEvent)
    .background_pixel(screen.white_pixel)
    .win_gravity(Gravity::NorthWest)
    .send();

This should produce a warning if the "builder object" is not sent (similar to unused Results). We can also provide a discard operation in case someone changes their mind after producing the builder.
The other way is to do something like
CreateWindowAux::new()
     .event_mask(EventMask::Exposure | EventMask::StructureNotify | EventMask::NoEvent)
     .background_pixel(screen.white_pixel)
     .win_gravity(Gravity::NorthWest)
     .send(&conn, 24, win_id, screen.root, 0, 0, width, height, 0, WindowClass::InputOutput, 0)

I personally find the former more intuitive, but it might lead to inconsistencies between the actions that have an AUX and those that don't.


Error Occuring building splitter on 3rd planet

Used the mode fine on first 2 planets, now when building on my 3rd planet I'm getting this error message. It prevents placing any splitter, overlapping or not.
System.MissingMethodException: int NearColliderLogic.GetBuildingsInAreaNonAlloc(UnityEngine.Vector3,single,int[],bool)
at SplitterOverBelt.SplitterOverBelt+Patch.BuildTool_Click_CreatePrebuilds_Prefix (BuildTool_Click __instance) [0x00048] in0
at BuildTool_Click.CreatePrebuilds () [0x00005] in0
at BuildTool_Click._OnTick (System.Int64 time) [0x0006a] in0
at BuildTool._GameTick (System.Int64 time) [0x000cf] in0
== Mod patches on the stack ==
CreatePrebuilds(Prefix): static void SplitterOverBelt.SplitterOverBelt+Patch::BuildTool_Click_CreatePrebuilds_Prefix(BuildTool_Click __instance)

Just ran into the same error since today, I think the game had a small update earlier, perhaps it is connected

That would make more sense, I didn't notice an update so good catch.

Yeh I had been using it without issue today, then when I restarted the game and it updated, immedietely recieved this error.

Might be fixed in 1.1.7.


Feature Request: onError callback

I think a decent amount of my personal friction with using the library could be removed if the onus of error handling was moved onto the consuming developer from the library itself.

I'm seeing error logging in my monitoring tool from the NetworkImage not being able to load content, which is giving me false positives
I want to be able to choose exactly how my error is presented using language of the error itself
I want to be able to determine what I actually consider is a true error based on the content of the error

Proposed change:

AnyLinkPreview has a property that is: Widget Function(Context, Metadata, Error) onError; , that returns a widget to be displayed in the event of a caught exception.
-- Personally, I think this would trump the need for errorImage, errorBody, errorTitle, and errorWidget, but I recognize that backwards compatibility wins.

Hi @osheron
I didn't get your proposed solution.
If you are asking to add onError Widget, It's already available.
If you are asking to remove the other props and use onError Widget for all sorts of errors including caught & uncaught, That makes sense.

Since there's no response after the last query, I am closing this request. Feel free to open he ticket or new one if you face some issue. Thanks!

I am having an issue here as well, I have seen there is a Error widget, but I am in need of a "onError" function, that allows me to write a check in case the links fails.

Just to add my two cents: AFAIK there is no way to 'see' the error, which makes debugging difficult. If there was an onError function, it could be used to log the error, as a first step to debugging.


fix app's path when mgmt cmd creates a component

fixes #228

Closing this and continuing the work in https://github.com/adamghill/django-unicorn/pull/242.


Crashes on loading into backup world

when trying to load into a backup i get this crash
https://paste.dimdev.org/fasitudela.mccrash

Does it crash every time you load the backup? Is it only that specific backup or does it happen with all backups?

Yes it crashes with every backup of that world. When I try to load a backup the first time it gives me a crash and if I attempt to load it again it gives me a different type of crash. I'll try to get a crash log of both attempts.

Fixed in version 1.5.6.


Not getting reverse shell after completely

Not getting reverse shell after procedure complete fully.

There are several reasons for reverse shell faild although the script procedure complete fully.
You can manual test referer https://github.com/mpgn/CVE-2019-7609，see what happens.

First of all thanks for the quick response and yes i verfied it also its not working on 6.6.0 version


Gdp 935

This implements  the GDP Submit processing action. We still need to add code to handle the result.
Major things to note:
Added a lot of methods to JobModel to hand HubView the properly formatted data and to do error processing. Most of these have had tests added.
When using jquery to parse xml that has namespace tags, you have to select both the tag with the namespace (to work on Firefox) and without (to work on Chrome).
Each tile on the hub will indicate whether enough information has been filled out in order to submit a processing job.

@cschroed-usgs , will you have some time to review this? I still have work to do on GDP-935, but this represents the work it took to get correctly gather the inputs and correctly submit a processing job to GDP. Still need to handle the results.

@mbucknell, I can review by Friday afternoon at the latest.

This work is now complete. Added the ability to download the results and to be informed via email. Added some tests for HubView.

Looks good. My strongest recommendation is to centralize the xml parsing quirks into one util function, but this is definitely :ship:-able. Merge if ya like.

I will go ahead and merge. I've made a large number of changes in SpatialView and some in JobModel and wps. Before I make the pull request for the next ticket I'll review your comments and definitely add a utility for the xml parsing.

:+1:


Getting started created and other modifications

I created a Getting Started example in Literate.jl
Also changed the Gol Lazar Belta Literate to work with PyPlot instead of Plots (now it's more uniform and a conflict was arising on the Docs when mixing both)
Other small modifications in plotting.jl and controlsystem.jl for computing pre-images were also done

Codecov Report

Merging #111 (a31fa99) into master (8e30fe3) will decrease coverage by 1.33%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   64.35%   63.02%   -1.34%
==========================================
  Files          19       19
  Lines        1310     1344      +34
==========================================
+ Hits          843      847       +4
- Misses        467      497      +30

Impacted Files
Coverage Δ

src/plotting.jl
0.00% <0.00%> (ø)

src/Abstraction/controlsystem.jl
98.27% <100.00%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e30fe3...a31fa99. Read the comment docs.


Added time frame to lock

Now the library accepts one optional value: secondsToLock. This value will be used with lastRefreshDate to lock the app with lockIfNeeded. In order to refresh the lastRefreshDateValue the user has to call to updateRefreshDate method whenever he needs. The changes has been made so the previous functionality is not affected.

This doesn't appear to function well when you don't set up a time, please include an example of this in operation. as well as tests.


[NEW ALGORITHM] Moore Voting Algorithm

Name:
Moore Voting Algorithm
About:
The Moore Voting Algorithm is a linear time algorithm used to find the majority element in an array,

Greetings!
I would like to take up this particular issue. Please guide me with the steps that need to be taken for contributing to this project in an efficient and correct manner.
Thank you.

@eshaalal assigned


Panic on Not Enough Locations

If there are not enough destinations to write chunks to, a panic will occur. This is intended to be checked before even creating shard writers, but has been omitted due to complication features added like zone rules.

2fe6e7a8effdc9f1cadf5099e9de3d950db77fa8


Use ExUnit.CLIFormatter only when extra_formatters are not provided

Hey 👋🏼! Thanks for the work on the elixir adapter.
I work on a project where we cannot use ExUnit.CLIFormatter due to certain issues. We use a custom formatter instead. I think it's more a sensible default to not include ExUnit.CLIFormatter when extra_formatters are provided (as one can add ExUnit.CLIFormatter as an extra formatter anyways)

Interesting... Thanks for contributing.
Can you update the README to say something like:
      -- Other formatters to pass to the test command as the formatters are overridden
      -- Can be a function to return a dynamic value.
      -- Default: {"ExUnit.CLIFormatter"}
      extra_formatters = {"ExUnit.CLIFormatter", "ExUnitNotifier"},

To point that the CLI formatter is the default and needs to be added if you change the option.


redirect_back failing from argument error

Deprecated conversion of keyword arguments causes the redirect_back to raise a ArgumentError: wrong number of arguments (given 1, expected 0; required keyword: fallback_location)

Thanks @Hassanelashram! I've been using activeadmin and paranoia for a long time, but I just discovered this gem. I've been cherry-picking all of the open PRs into my fork (https://github.com/DocSpring/active_admin_paranoia), which I am happy to maintain because I will be using this feature regularly. Thanks for the fixes!


bold cannot work.

 <QuillEditor style="height:500px;" toolbar="essential" :placeholder="contentText" v-model:content="content" content-type="text" />

this is my code, bold cannot work in browser.

Hello ... Please provide more information, are you using Vue? Composition or options API ? What is the Method you are using, can you share or code, so we can analyze it better. Thank you!


Injector

Hello,
When i click start the R3nzSkin injector, - The injector status : Working
- League Client Status : Found
- LeagueGame Status : Found
- R3nzSkin Status : Not injected
Someone can help me to understand why the injector won't work :( ?

Hello,
When i click start the R3nzSkin injector, - The injector status : Working - League Client Status : Found - LeagueGame Status : Found - R3nzSkin Status : Not injected
Someone can help me to understand why the injector won't work :( ?

not updated

https://discord.gg/leagueplus check here, 2 versions that work

Hello,I meet the same problem,have you solved it?


Cli port input

Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Allow running the kernel with a given port number.

Fixes Issue #725 .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):

[ ] Bug fix.
[x] New feature.
[ ] Enhancement.
[ ] Unit test.
[ ] Breaking change (a fix or feature that causes existing functionality to not work as expected).
[ ] Requires documentation update.

Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification
Insert x into the following checkboxes to confirm (eg. [x]):

[x] I have self-reviewed my own code and conformed to the style guidelines of this project.
[x] New and existing tests pass locally with my changes.
[x] I have added tests for my fix or feature.
[ ] I have made appropriate changes to the corresponding documentation.
[x] My code generates no new warnings.
[ ] Any dependent changes have been made.

@aion-kelvin I agree in the general case, but here I think we should opt for setting the port to the default 30303 value when given an incorrect value as input.

@aion-kelvin I agree in the general case, but here I think we should opt for setting the port to the default 30303 value when given an incorrect value as input.

I'm ok with that.  @beidouz could we implement it this way?  Also, make sure it doesn't write to the config file if the port is detected to be not valid.  It should also print an error/warning.


Document importing components with @using directives

Fixes https://github.com/aspnet/AspNetCore.Docs/issues/11829

@guardrex, the preview doesn't show the [!NOTE] section correctly. Is that expected?

@ajaybhargavb ... I'll look :eyes: right after the engineering lingo is worked out. I'll perform a quick grammar+style pass on it.

@ajaybhargavb I think we'll need to reconstitute this PR. These topics (this one) will be physically moving on the docs repo on Monday morning (time frame of ... say 🤔 ... noon CST, which is 10am PST), and that's going to :boom: this PR.
Would you like to reconstitute it, or would you like me to take care of it?

@guardrex, sorry I missed your edit. I'll reconstitute this PR with the feedback addressed and then you can take it from there. Does that sound good?

@ajaybhargavb Yes ... I'm mere minutes away from submitting a commit that will radically change the physical file locations. It will break this PR.
There are just a couple of sections here to paste into a new PR, so it's an easy job to just submit a new PR.
I'll ping u here when we get the updates merged to master. Then, you can close this and set up a new PR on the new location for this topic.

Sounds good. Thanks @guardrex

@ajaybhargavb Done ... https://github.com/aspnet/AspNetCore.Docs/pull/11984.
Reconstitute the PR on https://github.com/aspnet/AspNetCore.Docs/blob/master/aspnetcore/blazor/components.md.

@ajaybhargavb I can do it if ur busy.

@guardrex, please go ahead if you have the bandwidth. Otherwise, I'll get to this later today.

Sure ... I'm sitt'in and waiting on "developments" on the engineering side. I'll take care of it and ping u on the PR.


Add HTML comments linking to documentation before macro calls in specification

Recently, a number of users have mentioned that the schema-related macros in the specification are difficult to work with for folks who are not already familiar with them. The maintainers are working on improving documentation of the schema-related code, and one idea was to add an HTML comment before each macro call in the specification linking to documentation and clarifying what the code snippet means.
Something like this (proposed by @effigies):
<!-- This block generates a metadata table. The definitions of these fields can be found in src/schema/objects/metadata.yaml and a guide for editing at <link>. -->

The comment would vary based on the type of macro call, so suffix tables would link to the suffixes YAML file, etc.

I think this would be very helpful.


Layer opacity stacking issues after 6.8.1 version

Describe the bug
After updating to OL 6.9.0, the layer opacity for independent layers (tiled ArcGIS REST layers at least) will now make the top-most layer opaque (but only in reference to other OL layers (tiled ArcGIS REST layers in this case). The layer opacity does allow basemaps to display through.
To Reproduce
Steps to reproduce the behavior:

Go to:
https://codesandbox.io/s/layer-group-forked-mokjq?file=/package.json

This is a screen capture using OL version 6.9.0

Compare the image output after changing to OL version 6.7.0.

This appears to only be an issue in version 6.8.1 and greater. 6.7.0 and below renders as I expect. I determined that version could be the issue with localhost testing, but the sandbox doesn't seem to be able to target 6.8.1...

This may be related to how the layers are rendered in the canvas element?
In the linked code sandbox, if you change the opacity values for individual layers to NOT be identical then the image is rendered "correctly" with transparency for each Layer.
For example if layers are not all set to opacity of "0.5", but with values of 0.49, 0.50, 0.51 (for three separate layers) then the layers rendered "correctly".

This might be a regression introduced by #12760.


spreadsheet scrollbars jumping

Thanks for macpaste, it is great.
My only problem with it thus far is that I am encountering undesirable behaviour when I use Microsoft Excel (as I unfortunately have to do occasionally). When I use one of the scrollbars to navigate to another part of the spreadsheet this involves clicking the mouse and macpaste does a copy of the current selection. Unfortunately Excel then returns to a view that shows the copied cell(s). If its a big enough spreadsheet the scrollbars become useless because no matter where you try to go to it the view always bounces back to the current selection.
I don't get this problem in other spreadsheet applications or in Microsoft Word.
So my question is whether it's possible to configure macpaste so that it is inactivated in certain contexts or applications?
Thanks

I had an issue where weird things were happening in virtualbox, so I forked this repo and added functionality to skip an application. https://github.com/jb0n/macpaste