Update node-newrelic dependency to v11 to account for certain bug fixes especially high CPU utilization bug

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. The issue provides a reproduction available on
Github,
Stackblitz
or
CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
Higher CPU utilisation, higher max CPU time per tick. See this issue for the exact problem we are facing:
https://github.com/newrelic/node-newrelic/issues/1775
To Reproduce Steps to reproduce the behavior:
N/A -- will try to see if I can create a reproducible issue.
Expected behavior
CPU spikes shouldn't happen when mesh is
Environment:

OS: Linux
@graphql-mesh/...: latest
NodeJS: v20

Additional context
Please see the aforementioned issue. I think everything around our problem is well explained there.

We don't have a control over that dependency which is the official package they provide. However, we are planning to deprecate NewRelic plugin in favor of OTEL plugin with NewRelic integration;
https://the-guild.dev/graphql/hive/docs/gateway/monitoring-tracing#exporters
If you have any suggestion about what we can do with the current plugin, let us know. We'd love to help you with that even if it is going to be deprecated.

^nvm I managed to get a CPU profile using NODE_OPTIONS='--inspect-brk'


Add support for more abbreviations - startOf(PERIOD) and endOf(PERIOD) literals - to autocompletion

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description

Add support for literals for inputting dates faster in the task dialog
Add support for literals for inputting dates faster in the task auto-suggestion

The literals would be as follow :

date(eow) | A date representing the end of the current week
date(som) | A date representing the start of the current month
date(eom) | A date representing the end of the current month
date(soy) | A date representing the start of the current year
date(eoy) | A date representing the end of the current year

Once the simple literals are added, one could add support for :

Adding support for literals like start of PERIOD and end of PERIOD. PERIOD being a week, month, quarter or year.

✔ Solution
I don't know about the technical aspect of such a thing, but it was done in dataview and might even be part of momentjs or something.
❓ Alternatives
Auto-complete while typing something entirely like :

end of year instead of eoy
start of week istead of sow

📝 Additional Context
N / A

Thanks for the suggestion.
I'm not sure that I fully understand the suggestion.
Does date(eow) mean that the user is required to type that text in full? Or what doe the date( and )  mean?

Thanks for the suggestion.
I'm not sure that I fully understand the suggestion.
Does date(eow) mean that the user is required to type that text in full? Or what doe the date( and ) mean?

The idea would be that while typing inside the task dialog inside the due date box, writing eow would autocomplete to the end of week date.
For now, I can "only" type today, td, tomorrow, tmr, in 10 days, and so on.
I think it could be a nice addition for fast input of date.
But one could also use something like end of feb to add a task to the last day of February for instance.
Hence the scope of this FR is twofold :

Adding support for dataview like literals for faster input in current periods : sow, eow, som, etc.
Adding support for literals like start of PERIOD and end of PERIOD. PERIOD being a week, month, quarter or year.

Same thing while on a markdown document with the task auto-completion feature that must share the same code I reckon.

I checked, and you are correct, they do use the same code:
https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/src/DateAbbreviations.ts
https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/tests/DateAbbreviations.test.ts
The abbreviations are documented here:
https://publish.obsidian.md/tasks/Getting+Started/Create+or+edit+Task#Date+abbreviations
I don't think I noticed that - I can't see the abbreviations mentioned in https://publish.obsidian.md/tasks/Getting+Started/Auto-Suggest
I'll add the Help Wanted label to this. It seems like a reasonably localised area of code for contributions to.

Same thing while on a markdown document with the task auto-completion feature that must share the same code I reckon.

I checked, and you are correct, they do use the same code:
https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/src/DateAbbreviations.ts
https://github.com/obsidian-tasks-group/obsidian-tasks/blob/main/tests/DateAbbreviations.test.ts
The abbreviations are documented here:
https://publish.obsidian.md/tasks/Getting+Started/Create+or+edit+Task#Date+abbreviations
I don't think I noticed that - I can't see the abbreviations mentioned in https://publish.obsidian.md/tasks/Getting+Started/Auto-Suggest
I'll add the Help Wanted label to this. It seems like a reasonably localised area of code for contributions to.

You know what, I think I'd like to take care of this one. I'll finish with the basics soon enough and will be glad to take a throughout look at this.

Just a small update here.
I found that indeed, startOf('TIME') and endOf('TIME') are momentjs functions.
I'm just looking at the codebase to find the place where dates are changed so that I can add these o/

I think it may be simpler than that.
The current abbreviations in DateAbbreviations.ts appear to not need DateParser.ts and DateRange.ts at all...
They expand short strings like td into text that would already be recognised if the user typed it by hand (like today) - and then the expanded text is processed just as though the user had typed the whole thing.
If I'm wrong and it looks more complicated than that, may I suggest that you and I have a session pairing on it? It would likely save us both quite a lot of time...

I am wrong!

I think it may be simpler than that.
The current abbreviations in DateAbbreviations.ts appear to not need DateParser.ts and DateRange.ts at all...
They expand short strings like td into text that would already be recognised if the user typed it by hand (like today) - and then the expanded text is processed just as though the user had typed the whole thing.
If I'm wrong and it looks more complicated than that, may I suggest that you and I have a session pairing on it? It would likely save us both quite a lot of time...

There's that and I've done it on my fork. The next part would be to make this abbreviation work while typing markdown tasks (Suggestor.ts is where I'll look) and to auto-match a date with text such as end of month => 2023-12-31. I see that there's already some kind of end of february and the likes, so I don't intend to be redundant and will look after what's missing and what's already there in DateParser.ts and DateRange.ts.
But sure, let's see that during a session someday, no rush I'm just learning around for now o/

Hi @mathisgauthey, how are you getting on with this?
I'm asking as I have in progress a date-picker widget, which I am testing in my own fork.
It's looking rather promising, and is a lot more flexible than typing abbreviations.
So I am inclined to think that the date-picker is a better use of developer time than this???

Oh wait, this is also talking about use of the abbreviations in Auto-Suggest as well as in the Edit Task modal...
That complications things a bit, as there isn't a likely to be a date-picker in Auto-Suggest...

Oh wait, this is also talking about use of the abbreviations in Auto-Suggest as well as in the Edit Task modal...
That complications things a bit, as there isn't a likely to be a date-picker in Auto-Suggest...

Hey there ! Yes indeed I was mainly looking at some autocomplete feature to type dates faster using sow = start of week for example !
But I did not do anything so don't bother with merge issues 😅

Hey there ! Yes indeed I was mainly looking at some autocomplete feature to type dates faster using sow = start of week for example !

Yes, I forgot that... I was thinking of this as purely an Edit Task Modal thing...

But I did not do anything so don't bother with merge issues 😅

Hahah, it was more about whether to just close the ticket!
But I'll leave it open for now.


Error adding entities

Since the crew-1 mission, the spacex integration fails to add the entities for the next launch.
Logger: homeassistant.components.sensor
Source: custom_components/spacex/sensor.py:467
Integration: Sensor (documentation, issues)
First occurred: 10:11:32 PM (2 occurrences)
Last logged: 10:11:32 PM

Error adding entities for domain sensor with platform spacex
Error while setting up spacex platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 316, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 507, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 531, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 296, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 320, in _async_write_ha_state
    sstate = self.state
  File "/config/custom_components/spacex/sensor.py", line 467, in state
    self._state = launch_data["mission_name"]
KeyError: 'mission_name'

Logger: homeassistant.components.binary_sensor
Source: custom_components/spacex/binary_sensor.py:144
Integration: Binary sensor (documentation, issues)
First occurred: 10:11:32 PM (2 occurrences)
Last logged: 10:11:32 PM

Error adding entities for domain binary_sensor with platform spacex
Error while setting up spacex platform for binary_sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 316, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 507, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 531, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 296, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 320, in _async_write_ha_state
    sstate = self.state
  File "/usr/src/homeassistant/homeassistant/components/binary_sensor/__init__.py", line 158, in state
    return STATE_ON if self.is_on else STATE_OFF
  File "/config/custom_components/spacex/binary_sensor.py", line 144, in is_on
    if launch_data["is_tentative"] is True:
KeyError: 'is_tentative'

Appears that the SpaceXData API is currently down which is resulting in these errors. I can try to release a patch at some point that will fail more gracefully, but until they fix the issues it will continue to not work. As an alternative you can try my RocketLaunch.Live sensor at https://github.com/djtimca/harocketlaunchlive which will also give you the SpaceX launches.

Appears that the SpaceXData API is currently down which is resulting in these errors. I can try to release a patch at some point that will fail more gracefully, but until they fix the issues it will continue to not work. As an alternative you can try my RocketLaunch.Live sensor at https://github.com/djtimca/harocketlaunchlive which will also give you the SpaceX launches.

I think it would be a good idea to move away from the deprecated v3 api onto the v4 api.

Thanks @thijsdejong - the documentation on the API is still stuck at v3... had to muddle through queries to get structure etc. so there might still be some issues come up, but latest will now be working in HA (for now).

@djtimca thank you for the effort! Working great again!

@djtimca Perhaps this is useful to you: https://github.com/r-spacex/SpaceX-API/blob/master/docs/v4/README.md . Taken from https://github.com/r-spacex/SpaceX-API


getPskEntry unit test bug

Describe the bug
The latest changes to the tcgapi caused a couple of test cases, particularly related to that of the getPskEntry function to fail. It raises an exception when handling the conversion of integers from bytes to hexadecimal.
To Reproduce
Steps to reproduce the behavior:

Build steps
python3 setup.py opensea
python3 setup.py build
Python script :test_tcgapi.py
Command: python3 test_tcgapi.py
Type of drive interface that's being used (SAS/SATA).
Product type: Seagate SED

Expected behavior
The unit tests should not raise an exception and handle the base conversion appropriately.
Desktop

OS: CentOS 7
Python version: 3.6

This issue has been fixed in the recent commit. I am closing this issue.


build: generate README

Instead of manually updating the information in the README, which can be cumbersome with all of the links, let's use a script to generate it automatically. It also supports the legacy JS scripts, so that should make it easier to do the TS migration for each script individually without needing to spend time changing the README.
I've also added a check to the build process so that the build (and by extension, CI) will fail if the README becomes outdated.

/deploy-preview


[Suggestion] Config option to turn off Llama caravans

Description
The ability to disable Llama's caravan feature. This should be a simple option within purpur.yml in the Llama section.
Reason for the change

The caravan feature of Llamas can cause extreme lag under some circumstances. I've had a server drop to 8 TPS with 3 players, and from looking at timings, it was all because of the Llama's caravan feature. It was because 7 Llamas were tied to a fencepost with a leash, and because of that, they were attempting to follow each other - and failing.
No one really uses the caravan feature of Llamas. Any player is better off carrying shulker boxes or using a mule/donkey for transport, and I've never once seen a player ACTUALLY use it.

I've only used the feature once, and that was only to move a bunch of llamas into one area with just a single leash. I agree that this should be added.


Allow ignoring of implementation

Hi,
It would be great if there was an option to allow implementation to be ignored in the comparison. Ideally this option would appear after assemblies are chosen, thus allowing the user to turn it on and off for the current comparison without any need to re-select assemblies.
The idea here would be to make it quick and easy to see what signatures have changed, ignoring the implementation thereof.

The command line interface that was just merged allows this.


Remove, or isolate, Phoenix Live View Dependency

I'm thinking about using this library on the resolution of a :absinthe field, with a custom computation. But this repo requires a specific version of LiveView, which I'm not using and it makes me unable to add safe_code as a dependency.

That's an interesting idea, even though I think it was not planned.
Wdyt @TheFirstAvenger? Contributions are welcome for this feature?


Styling

It looks like the styling is binded to bootstrap buttons. Is it possible to change the style of the selectors without having to change all bootstrap buttons? Just to keep it separate.

Seems ng2-select has been not developed for a long time:( I faced the same issue, and done some workround (not nice, but anyway):
on component which uses select I added to onChange hook:
.....
let btn = this.el.nativeElement.querySelector('span.btn.ui-select-toggle'),
input = this.el.nativeElement.querySelector('input.form-control');
if (btn) {
btn.classList.remove('form-control');
btn.classList.add('btn-sm');
}
if (input) {
input.classList.add('input-sm');
}
.......
where this.el is ElementRef to current component
(in my case I want to use small button styles for select)

Thanks garkuwa, that's a nice solution! So in the if clauses I can specify the new styles?
What I did:
Since bootstraps specifies multiple button types (default, primary etc.) and ng-select uses the default styles, I separated the styles by changing the default color of ng select accordingly and for the other buttons i switched to the primary type.

May be help somebody, solution for bootstrap 4
add global css style
.select-sm > .ui-select-container > input.ui-select-search.form-control {
  padding: .25rem .5rem;
  font-size: .875rem;
  line-height: 1.5;
  border-radius: .2rem;
}

.select-sm > .ui-select-container > div.ui-select-match > span.ui-select-toggle.form-control {
  padding: .25rem .5rem;
  font-size: .875rem;
  line-height: 1.5;
  border-radius: .2rem;
}

add class to ng-select
<ng-select
    [items]="index_select"
    [active]="value_index_select"
    (selected)="selectTriggerIndex($event)"
    class="select-sm">
</ng-select>

Work by supporting Bootstrap 4 was planned: https://github.com/optimistex/ng2-select-ex/issues/5


Update builder to include gardenlinux/builder#57

This should fix the failed nightly builds
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

CI is red now because the builder image was not yet pushed. WIP here https://github.com/gardenlinux/builder/actions/runs/7724005235/job/21055243308, should work once that succeeded.

Sadly this currently does not work because the builder is (currently) based on debian stable which does not contain systemd-ukify

This will soon change, because the TPM2 feature is using debian testing for the builder and includes systemd-ukify


Simplify record access to unrelated field update

Woohoo :partying_face:
This one will probably apply more often than #35


Nuget package doesn't implement the same as master branch

Hey thuba, first of all amazing sdk, much better than the current notification handler from purecloud, though have have one problem.
I am trying to use the instantiator
public GenesysTopics(GenesysAuthTokenConfig config, ILogger logger, System.Net.Http.HttpClient httpClient)

But the GenesysAuthTokenConfig isn't known to the solution downloaded through the nuget system. When I try to F12 my way through the nuget I find that IGenesysConfig also looks differnet from the solution on github:
Nuget IGenesysConfig:
namespace Genesys.Client.Notifications
{
    public interface IGenesysConfig
    {
        string ClientId { get; set; }
        string ClientSecret { get; set; }
        string Environment { get; set; }
        bool Reconnect { get; set; }
    }
}

Master branch IGensysConfig:
namespace Genesys.Client.Notifications
{
  public interface IGenesysConfig
  {
      string Environment { get; set; }
      int ChannelExpiresHours { get; set; }
  }

  public class GenesysAuthTokenConfig : IGenesysConfig
  {
      public GenesysAuthTokenInfo Token { get; set; }
      public string Environment { get; set; }
      public int ChannelExpiresHours { get; set; } = 24;
  }

  public class GenesysConfig : IGenesysConfig
  {
      public string ClientId { get; set; }
      public string ClientSecret { get; set; }
      public string Environment { get; set; }
      public int ChannelExpiresHours { get; set; } = 24;
  }
}

I have installed the 6.0.2 version, and I can see that the intialisation method is there as:
public GenesysTopics(IGenesysConfig config, ILogger logger, HttpClient httpClient);

So it is both a question and a headsup, keep up the good work!

Hi @seanLindholm
Sorry not replying you.
I've created a new nuget packege with different internal updates.
https://www.nuget.org/packages/Genesys.Client.Notifications/6.1.0
Please check and let me know.
Best regards, Taras


Is it possible to inference on CPU device/windows?

Looking at the dependency of cuda operator which generates multiscaledeformableattention extension cuda operator, is it possible to inference model on windows/cpu device?

Can this code run on CPU as I see MultiScaleDeformableAttention is supported only for GPU?


yarn test failing

yarn test is failing.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behaviour 😯
yarn test is failing with following logs:
~/hdd/mui-github-codebase $ yarn test
yarn run v1.22.4
$ yarn lint && yarn typescript && yarn test:coverage
$ eslint . --cache --report-unused-disable-directives --ext .js,.ts,.tsx --max-warnings 0

/Users/[username]/hdd/mui-github-codebase/benchmark/browser/scenarios/box-material-ui/index.js
  2:17  error  Unable to resolve path to module '@material-ui/core/Box'  import/no-unresolved
...
...
...
/Users/[username]/hdd/mui-github-codebase/test/utils/user-event/index.js
  3:51  error  Unable to resolve path to module '@material-ui/core/Unstable_TrapFocus/Unstable_TrapFocus'  import/no-unresolved

✖ 2768 problems (2768 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Expected Behaviour 🤔
yarn test should run successfully
Steps to Reproduce 🕹
Run yarn test from project root
Context 🔦
Trying to run Automated tests locally.
Your Environment 🌎
 System:
    OS: macOS Mojave 10.14.6
  Binaries:
    Node: 12.18.0 - ~/.nvm/versions/node/v12.18.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.18.0/bin/npm
  Browsers:
    Chrome: 88.0.4324.96
    Edge: Not Found
    Firefox: 84.0
    Safari: 13.1
  npmPackages:
    @emotion/react: ^11.0.0 => 11.1.4
    @emotion/styled: ^11.0.0 => 11.0.0
    @material-ui/codemod:  5.0.0-alpha.24
    @material-ui/core:  5.0.0-alpha.24
    @material-ui/data-grid:  4.0.0-alpha.18
    @material-ui/docs:  5.0.0-alpha.24
    @material-ui/envinfo:  1.1.6
    @material-ui/icons:  5.0.0-alpha.24
    @material-ui/lab:  5.0.0-alpha.24
    @material-ui/styled-engine:  5.0.0-alpha.24
    @material-ui/styled-engine-sc:  5.0.0-alpha.24
    @material-ui/styles:  5.0.0-alpha.24
    @material-ui/system:  5.0.0-alpha.24
    @material-ui/types:  5.1.6
    @material-ui/unstyled:  5.0.0-alpha.24
    @material-ui/utils:  5.0.0-alpha.24
    @types/react: ^17.0.0 => 17.0.0
    react: ^16.14.0 => 16.14.0
    react-dom: ^16.14.0 => 16.14.0
    styled-components:  5.2.1
    typescript: ^4.1.2 => 4.1.3

@plug-n-play There is likely something wrong with your environment. I'm on macOS too without any issue. I'm closing as we can't reproduce. I fear you would have to debug the issue on your own. It could make a great first contribution if you find that the origin in on the repository and not your env :).

@oliviertassinari kindly share your environment details where this is working as expected

System:
OS: macOS 11.1
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 298.19 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 12.16.1 - ~/.nvm/versions/node/v12.16.1/bin/node
Yarn: 1.22.5 - /usr/local/bin/yarn
npm: 6.14.9 - ~/.nvm/versions/node/v12.16.1/bin/npm
Managers:
Cargo: 1.42.0 - ~/.cargo/bin/cargo
Homebrew: 2.7.0 - /usr/local/bin/brew
pip3: 19.3.1 - /usr/local/bin/pip3
RubyGems: 3.0.3 - /usr/bin/gem
Virtualization:
Docker: 19.03.13 - /usr/local/bin/docker
VirtualBox: 6.1.4 - /usr/local/bin/vboxmanage
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Monorepos:
Yarn Workspaces: 1.22.5
Lerna: 3.22.1


Added LinkedIn Connections Scraper files

Fixes
#240

Description
A Python script that scraps linkedin connections and dump the extracted data into a CSV file.
Type of change

[x] New project (non-breaking change which adds functionality)

How Has This Been Tested?
Unfortunately I can't add a demonstration video on this as there are many personal information to expose for such a project including account credentials. but I did explain how to run the project in the readme. and here is a portion of my scrapped connections in the csv file
https://user-images.githubusercontent.com/64689436/162078666-919588b7-ff2d-46e0-9186-aeff9bfc0d41.mp4
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have included a README.md file
[x] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[x] I have added demonstration in the form of GIF/video file
[x] I am a GSSoC'22 Participant

fixes #240

@heet-kumar Done.

Umm nope, I uploaded the wrong video.

@heet-kumar Done.

Yes, it contains this command but with my account credentials.

@heet-kumar any updates?


Namespacing using class leads to falsely undocumented classes

Inch CI says my class is undocumented, but it actually is. In the suggestion reference it used the class definition of one of the inner classes of this class.
See the fully documented class here:
https://github.com/Overbryd/adyen_client/blob/37fbd929a6693394b702fd69f96cc51fedbab86d/lib/adyen_client.rb

Re: [U] AdyenClient in Overbryd/adyen_client

Hi there,
the class itself is actually undocumented. Class documentation precedes the class definition and often describes the intended purpose of the class and sometimes usage examples:
# Base class for building linters that check source code
#
# Linters are used by authors of ROM adapters to verify that their
# integration complies with the ROM api.
#
# Most of the time, authors won't need to construct linters directly
# because the provided test helpers will automatically run when required
# in tests and specs.
#
# @example
#   require 'rom/lint/spec'
#
#
# @api public
class Linter
  # ... snip ...
end

Example taken from ROM

Ah ok, good to know how inch sees this.
But it seems inch still sees the file lib/adyen_client/utils.rb as the main AdyenClient file.
https://github.com/inch-ci/inch_ci-web/issues/new?title=&body=

---
Re: [U] [AdyenClient](http://inch-ci.org/github/Overbryd/adyen_client/revision/a4d6f53a/code_object/1881953?branch=master) in [Overbryd/adyen_client](http://inch-ci.org/github/Overbryd/adyen_client)
Although the class is now documented: https://github.com/Overbryd/adyen_client/blob/master/lib/adyen_client.rb

You are right about the incorrect file detection. Will have to look into it!


No QR code

Dear maintainers, thank you for all your hard work and beautiful project! In my mind this project is a real work of art 🧑🍳
In the README.md it seams apparent that a QR code should be visible after boot. I have not been able to see the QR code on any of the machines I have booted into using the newest x86-64 iso from releases nixos-kexec-installer-x86_64-linux.tar.gz from nixos-23.11 (build 2023-12-10). Is this expected behaviour?

Are you using the actually the ISO? We do not have qrcode support in our kexec image.

So only in the "normal" iso? I may have mixed these up... lemme check.

The iso provided here: https://github.com/nix-community/nixos-images/releases/download/nixos-24.05/nixos-installer-x86_64-linux.iso


FATAL ERROR: Class "Propel\Runtime\Propel\Runtime\Map\TableMap" not found in Collection.php

// $bookmarkedMatches is type Propel\Runtime\Collection\Collection
When I call $bookmarkedMatches->toArray() I get the following error:
FATAL ERROR: Class "Propel\Runtime\Propel\Runtime\Map\TableMap" not found D:\cmp\ct\htdocs\app\v1\lib\vendor\propel\propel\src\Propel\Runtime\Collection\Collection.php : 632 Full Trace: #0 D:\cmp\ct\htdocs\app\v1\actions\BaseAction.php(92): Propel\Runtime\Collection\Collection->__call('toArray', Array)
...
In testing Collection.php, if I change the original line:
$keyType = $params[2] ?? Propel\Runtime\Map\TableMap::TYPE_PHPNAME;
to:
$keyType = $params[2] ?? TableMap::TYPE_PHPNAME;
The method works.

Please ignore; a copy/paste operation went wild.


Firestore: remove unneeded base64 encoding applied to BLOB fields

It looks like fields of type 'bytes' can be set using binary streams. Before the change however the contents of a stream would be base64-encoded in google-cloud-firestore/lib/google/cloud/firestore/convert.rb which would lead to the actual value of the corresponding 'bytes' field to be base64 encoded as well (in addition to the base64 encoding
the Web Console does, for example).

@blowmage Replaced tabs with spaces.

@schmidt-sebastian Can you weigh on on this. When the client was first implemented both the RPC Value and the REST Value documentation said the value should be Base64 encoded. But now the RPC Value documentation is not showing that. I think it makes sense the RPC endpoints would not need Base64 encoding. Can you confirm?

We use Protobuf-encoding in our GRPC based API. You should not need to Base64-encode any values. All encoding should be taken care of by Protobuf.

Yeah, that's what we've done for other GRPC libraries as well. Thanks!


fix(cli): release performance improvements around json read/write

This pull request introduces performance enhancements for the fern generate command, particularly when working with large API specifications and Intermediate Representations.

The stream-json dependency is upgraded, improving performance when reading large API specs.
The fern generate command now benefits from performance improvements when stringifying large Intermediate Representations, potentially reducing execution time by minutes.
The version number is updated from 0.40.3 to 0.40.4.

@mstade this will release your changes and make them accessible

@mstade this will release your changes and make them accessible

Thanks @dsinghvi and team – this helps a lot! I just ran the generation with debug logging for v0.41.15 and v0.40.4 of the CLI and TS generator respectively, and writing the temp IR JSON file took about 2.5 seconds, down from 2-3 minutes, and parsing it back again in the TS generator container took about 20 seconds, down from about a minute or so. I'm surprised the parsing was so improved, in my testing I only saw about a 30-35% improvement but this is more like double that, which is of course wonderful!
May I ask for new releases of the Go and Python generators as well, incorporating these improvements? Thank you so much! 🙏


Introduce Absorb/Challenge traits

Currently the Sponge type looks like this:
impl<P: SWModelParameters, SC: SpongeConstants>
    FqSponge<P::BaseField, GroupAffine<P>, P::ScalarField> for DefaultFqSponge<P, SC>
where
    P::BaseField: PrimeField,
    <P::BaseField as PrimeField>::BigInt: Into<<P::ScalarField as PrimeField>::BigInt>,
{
    fn new(params: ArithmeticSpongeParams<P::BaseField>) -> DefaultFqSponge<P, SC> {
        ...
    }

    fn absorb_g(&mut self, g: &[GroupAffine<P>]) {
        ...
    }

    fn absorb_fr(&mut self, x: &[P::ScalarField]) {
        ...
    }

    fn digest(mut self) -> P::ScalarField {
        ...
    }

    fn challenge(&mut self) -> P::ScalarField {
        ...
    }

    fn challenge_fq(&mut self) -> P::BaseField {
        ...
    }
}

Meaning there is a method for every type you can absorb and every type you can squeeze. I suggest getting rid of this in favor of using two traits: one for "absorbable" objects and one for "squeezable" objects.
Concretely I suggest adding traits like these:
pub trait Challenge<F: FftField + PrimeField> {
    fn generate(sponge: &mut Sponge<F>) -> Self;
}

pub trait Absorb<F: FftField + PrimeField> {
    fn absorb(&self, sponge: &mut Sponge<F>);
}

And changing the sponge type so it looks more like this:
impl<F: FftField + PrimeField> Sponge<F> {
    pub fn new(constants: Constants<F>) -> Self {
        ...
    }

    // absorb an instance of T using the sponge
    pub fn absorb<T: Absorb<F>>(&mut self, val: &T) {
        val.absorb(cs, self);
    }

    // sample an instance of T using the sponge
    pub fn challenge<T: Challenge<F>>(&mut self) ->  T {
        T::generate(self);
    }
}

In addition we provide a few special implementations of Challenge<F> and Absorb<F>:
// can absorb a element from the same field
impl<F: FftField + PrimeField> Absorb<F> for F {
    fn absorb(&self, sponge: &mut Sponge<F>) {
        ...
    }
}

// can generate a variable from the same field (a digest)
impl<F: FftField + PrimeField> Challenge<F> for F {
    fn generate(sponge: &mut Sponge<F>) -> Self {
        ...
    }
}

This enables describing/deriving absorbing/squeezing of more complex types elsewhere in terms of these "base" implementation, e.g.
// can absorb a slice of absorbable elements
impl<F: FftField + PrimeField, T: Absorb<F>> Absorb<F> for [T] {
    fn absorb(&self,  sponge: &mut Sponge<F>) {
        self.iter().for_each(|c| c.absorb(sponge))
    }
}

// define a curve point type
pub struct Point<G>
where
    G: AffineCurve,
    G::BaseField: FftField + PrimeField,
{
    _ph: PhantomData<G>,
    x: G::BaseField,
    y: G::BaseField,
}

// can absorb curve points using a base field sponge
impl<G> Absorb<G::BaseField> for Point<G>
where
    G: AffineCurve,
    G::BaseField: FftField + PrimeField,
{
    fn absorb(&self, sponge: &mut Sponge<G::BaseField>) {
        sponge.absorb(&self.x);
        sponge.absorb(&self.y);
    }
}

Without changing the Sponge type/trait, this also enables implementing the traits for new types outside the module. In particular the above allows:
sponge.absorb(&points);

For a sequence of points (exactly like sponge.absorb_g currently), but also enables sponge.absorb(&field_elements) without changing the sponge type.

have some start here: https://github.com/o1-labs/proof-systems/pull/680/commits/4a95a2d39cbe85cf75cb8bdae7bbfc5ebe21b303

I think what would be even more useful:

on the prover side you can't put STUFF in a proof if you haven't absorbed it first (so absorb could return a special type that is in a proof)
on the verifier side you can't extract what's in STUFF without absorbing it first (so absorb there could consume the special type and return the actual types we can manipulate)


fix xhtml:body padding on pages with bib-base (bootstrap) involvement

On medium and small screen sizes pages with bib-base inclusion get padding-left:20px; padding-right:20px. This seems due to bootstrap involvement in the bib-base inclusion.

Yes, this seems to be a known issue with bib-base inclusion, see https://bibbase.userecho.com/communities/1/topics/160-bootstrap-css-conflicts-with-page
A workaround could be to have an inline style="padding-left:inherit; padding-right:inherit" on the body, but I am not sure if there are any side-effects.


Enable Chromium/Chrome testing

Most of the necessary code is in place, but need to figure out how to properly load the right Chromedriver binary.

Done


feat(http,model): scheduled event cover images

Adds GuildScheduledEvent::image. Adds methods to CreateGuildScheduledEvent's derivatives and UpdateGuildScheduledEvent to add and update the image.
Closes #1502.

Shouldn't the image data be a string? Like it is for the webhook requests.

It's &[u8] elsewhere, and I prefer that more since it is more flexible (doesn't require an allocation in some cases)
https://github.com/twilight-rs/twilight/blob/ecf3c0ef9ce5e63e36d5cf44ff77efff99f54d6e/http/src/request/attachment.rs#L6


API: Formalise app state

Is your feature request related to a problem? Please describe.
In order to show the state of an application (errored/red, caution/yellow, all good/green, etc) the client needs a formalised state.
At the moment, in v0.0.21, it looks like the app only has a string value that could either show a status sentence or number of instances running (haven't played around with this, so could be wrong about specifics).

0/1
Inactive, without workload. Launch via "epinio app push"

I've tried fetching the stage associated with the app to see if it had anything more, but just get a 404 - /api/v1/orgs/<org name>/staging/<stage_id>/logs.
Describe the solution you'd like
A clear enum based state regarding the health of the application, a separate state for number of instances running and another for target number of instances.
The enum could be any number of values, they would just need to be defined so we can associate certain behaviour in the UI.

Relevant #786

As we discussed in a call, we are going to report 2 different statuses back:

The workload status. This is the answer to "is my app reachable?" question (or how reachable it is)
The application status. This is providing information that reflects some user action on the application

Useful workload status information:

Number of ready replicas (the properly running ones) - could be zero if there is no workload yet or zero is explicitly asked for
Desired replicas
Status of all replicas (to be able to tell why the failed ones fail)

Possible application statuses:

no workload (when no Deployment exists)
Staging (when a PipelineRun is currently running) - with various workload statuses
Running (with various workload statuses)
Being deleted

For example:
A workload status "1/1" with an application status "staging" means your application is reachable and someone is pushing the application right now.
Other example:
A workload status "0/0" with an application with no workload means nobody pushed the application yet. It was simply "created".
This is the rough idea. The details of the various possible statuses and the format of the json responses from the API can be refined.

I like the split of workload status vs application status vs application health.


Query syntax

I tested the PaNOSC search API and read more attentively the query documentation from loopback.
The correct syntax for the document query when applying conditions on parameters of the related datasets is the following:
{
 "limit" : 10,
 "include" : [
  {
   "relation" : "datasets",
   "scope" : {
    "include" : [
     {
      "relation" : "parameters",
      "scope" : {
       "where" : {
        "and" : [
         { "name" : "sample_temperature"},
         { "value" : { "between" : [0, 0] } }
        ]
       }
      }
     }
    ]
   }
  }
 ]
}

As I did a couple of changes to how parameters are handled on the new branch that link no longer works, I might tweak this later.
https://pan-dev-portal.eli-laser.eu/search/?q=test&incident_wavelength=320~2000'between


Snowflake - Add quotes on col names to preserve the casing

Description
What is the current behavior?
Currently, we were changing the case of col names to lowercase for snowflakes. Which trips user.
closes: #917 #1098
What is the new behavior?
We can keep the col names intact by passing them in quotes when creating tables added quotes.
We no longer need the ColCapitalization feature.
Does this introduce a breaking change?
Yes, for pandas path, we will also load "data twice" - one during schema detection (where we load and truncate) and second during actual load
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

@pankajastro @sunank200 need your feedback on this PR

@pankajastro @sunank200 need your feedback on this PR

I still think python-sdk does not change the column, the snowflake DB store it in capital unless we pass it in quotes. So I'm not sure about preserving the col name by putting quotes from our side is the right idea or not.


Add CI

Are windows builds tested and verified working? Upload example output?

Works for me under Wine.


Fix null attribute in XML write

This supersedes https://github.com/databricks/spark-xml/pull/336
This also partially resolves https://github.com/databricks/spark-xml/pull/247

Codecov Report

Merging #353 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##           master   #353   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          14     14
  Lines         728    731    +3
  Branches       66     66
=====================================
- Misses        728    731    +3

Impacted Files
Coverage Δ

...atabricks/spark/xml/parsers/StaxXmlGenerator.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b65d2...c917f91. Read the comment docs.


Fix autoscroll in various situations (retrieval actions, citations...)

Autoscroll is performed when a message is generating and the page is already scrolled down; but if the user has scrolled the page up after the start of the message, we do not want to scroll it back down.
Checking the conversation is already at the bottom of the screen is done modulo a small margin (50px). This value is small because if large, it prevents user from scrolling up when the message continues generating (forces it back down), but it cannot be zero otherwise the scroll does not happen.
This PR fixes a few issues with the previous version, namely:

it did not listen to some new content events (e.g. actions, citations) and thus did not scroll in this case;
it did not scroll if the newly generated content was larger than 50px (e.g. citations);

The former is fixed via useeffect dependencies.
The latter is ensured by keeping a ref on the message's height, and accounting to the height difference when new parts of the message are generated.

Technical Note
I investigated using transitions and transitioning the height of new content from 0 to their actual height. It was appealing because it would in addition make for a nicer content display (smooth rather than blunt), but:

fixing an autoscroll issue with transitions seemed brittle;
there were situations in which I could not make it work;
transitioning on the height had various implications on children of the transitions that made it IMHO bad code style;

But

this can be revisited, TBD
It might still be worth using transitions when content appears, independently on the scroll

Wait, don’t we want to scroll on new messages? Even if the user is scrolled up?

Yes, this we still do, this is done in conversation

Seems there is still an issue on mobile, when there are citations. Will investigate when I get back


MVP0 landing page

Landing Page Breakpoints

XSmall (320x 568 iPhone SE)

Design File
Prototype Preview

Small (554x964)

Design File
Prototype Preview

Medium (768x1024 iPad Mini)

Design File
Prototype Preview

Large (1012x588)

Design File
Prototype Preview

XL (1280x832 MacBook Air)

Design File
Prototype Preview

XXL (1440x900 MacBook Air 12-inch)

Design File
Prototype Preview

XXXL (1920x1080)

Design File
Prototype Preview

Resources

HRA Design System: Figma Design System File

Style Guide
Component Library

User Stories for Development

Navigation User Stories
Landing Page User Stories

Notes

Modeled after Primer's Breakpoints

Design Review: Landing - Medium (768x1024 iPad Mini)
Thanks for getting this breakpoint over for review, @bhushankhope! It's looking great!

Development prototype
Figma design file

Development Feedback

The splash image appears a little pixelated
The horizontal scrollbar needs to be removed from the collaborator section and a horizontal scroll feature will be added
Hover states are needed everywhere in the footer menu

Design Updates

Splash container size and vertical padding have been adjusted
Increased upper vertical padding on the collaborator section heading container
Adjusted position of collaborators frame, so it's more central within the overall frame
Footer Menu

Adjusted vertical padding
Adjustments to spacing of menu frames

New Ready for dev sections have been added to all breakpoint pages.
Everything outside of these sections is not ready for development. Let me know if you have questions!

@libby-maier I have implemented the mobile menu for 320px breakpoint, please review and let me know your feedback. Thanks
https://cns-iu.github.io/hra-portal-mvp0/

@libby-maier Just implemented the mobile menu for Small breakpoint(544*964). please review and let me know your feedback. Thanks
https://cns-iu.github.io/hra-portal-mvp0/

@libby-maier I have implemented the XXL breakpoint (1,440px * 900px). Please review and let me know your feedback. Thanks.
https://cns-iu.github.io/hra-portal-mvp0/

Design Review: Mobile 544px
Thanks so much, @bhushankhope! This breakpoint is looking great too!

@libby-maier Just implemented the mobile menu for Small breakpoint(544*964). please review and let me know your feedback. Thanks
https://cns-iu.github.io/hra-portal-mvp0/

Mobile Menu Questions & Feedback

Looking at the menu expand more and less button font: Is this the same size as the page buttons just below it? It looks slightly bigger in production when these were specified with the same font style in Figma.

The file format type font captions seem a little larger than the specification.
Verify all fonts in the build match the spec font styles.

Verify spacing & padding match the spec.
Verify all colors match the spec (specifically for the arrow icon).
Hover states are needed wherever they have been specified.
The logo appears a little clipped on the right side.

Landing Page Feedback

Do all fonts match the spec exactly? The primary CTA button looks bold.
Regarding the primary CTA button, is the text centered on the button precisely? It looks slightly shorter in height than specified. Depending on the answer, I might need to change it to make it taller.
Hover states are still needed on this landing page breakpoint for all buttons with specified hover states in the splash section, use the access section and the footer.
Are you still working on the scrolling feature? I see it scrolls right when I get in line with the HuBMAP logo, but it would be nice if it triggered the horizontal scroll right when the user gets in that blue section. Let me know if we need to adjust our expectations for this ask.

544px Resources

Figma design file
Figma prototype presentation

Design Review: Landing 1440px

@libby-maier I have implemented the XXL breakpoint (1,440px * 900px). Please review and let me know your feedback. Thanks. https://cns-iu.github.io/hra-portal-mvp0/

Thanks so much, @bhushankhope! This is looking super.
Feedback & Questions

The logo looks lower resolution. Is there a way to fix this?
The CTA button seems to be using a heavier weight than specified. Is this accurate?
States are needed for all buttons that have specified states.

Meeting with Bhushan:

Top padding for the menu is fine
No states for mobile but states will show on browser. Review browser sizes without inspect for larger breakpoints for browser view. Also, use this setting:

Libby to review states in browser.
Libby to discuss font appearance online with Ushma.

Hi @bhushankhope, thanks for the great meeting today! The states look good on browser!
I just finalized the design for the 1012px nav menu component and moved it to the ready-for-dev section.
Thanks so much!

@libby-maier Implemented menu for Medium breakpoint (768px)

@libby-maier Implemented mobile menu for Medium breakpoint (768px)

Thank you, @bhushankhope! That was quick!

Design Review: Landing 768px

Reviewed in browser without the inspect tool

Menu

The icons should be in the same spot. Currently the jump around a little bit. Can we get this closer to the spec?
The fade effect goes over the top of the browser window bar.
The Open in New icon should change colors with the button's different states. See the Figma Design System file for this component.

Landing

I think you mentioned today that you're still working on the button states for the footer. I'll keep an eye out for those eventually!

This is looking great otherwise! Thanks so much!

@bhushankhope - I have completed the navigation menus for 1280px & 1440px. All nav menus have been moved to their ready for dev sections on their specific breakpoint page!

@libby-maier I have created the navigation menu for xl, xxl and xxxl screens, Added hover states to remaining menus. Please let me know if anything needs to be changed. Thanks

@libby-maier I have created the navigation menu for xl, xxl and xxxl screens, Added hover states to remaining menus. Please let me know if anything needs to be changed. Thanks

Thanks @bhushankhope! It's looking good!
1920x menu feedback

Please check the active/pressed state of the main nav buttons. The underlined bar and text need to be the same color when pressed.
Verify the spacing of the nav menu item button font and "open in new" icon match the spec. It looks more spacious in the specification.
Explore flyout menu: The alignment of the compass icon needs to match the spec.

1440px menu feedback

Same feedback about the active/pressed states of the main navigation category buttons.
Same feedback on the spacing of the external routing button fonts and "open in new" icon.
Contribute flyout menu: The ASCT+B Reporter menu button is bugging out and throwing off the symmetry of this component.

1280px menu feedback

Same feedback about the Explore flyout menu
Same feedback about the Contribute flyout menu

Resizing between 1280px to 1012px

Can we implement the hamburger menu once browser sizes are reduced below 1280px? This is currently too cluttered and certain buttons are obscured. We don't want to see a horizontal scroll bar.

@libby-maier fixed all the above issues.

@libby-maier I have implemented the scroll functionality. Please review. Thanks.

Hey @bhushankhope, I glanced at just now, and it looks good.
We may tweak the responsive resizing of the footer for some breakpoints.
I will ping when I arrive at the office tomorrow so we can meet. Thanks!

@bhushankhope and I met this morning and made a few minor changes.
He is checking a few components after we made some small adjustments:

We updated the mage in the splash section to show the human better between 1012 and 1280
We updated the spacing on the footer navigation to 1 rem
Bhushan adding<EMAIL_ADDRESS>as the mailto: email in the footer

We met again! We discussed the responsive resizing of the footer between widths 1440px and 1920px.
Getting closer!

@LibbyUX I have made the changes as we discussed.

Fabulous, thank you @bhushankhope! Ushma and I will review MVP0 later this afternoon!

@bhushankhope We have updated Omnes font with Nunito Sans

Updated font to Nunito Sans

@bhushankhope - I have implemented the following changes in Figma:

Updated all instances of Organ Gallery in VR and VR Organ Gallery to HRA Organ Gallery

All breakpoint navigation menus and footers

Updated Contribute secondary navigation button to Get Involved

1920px breakpoint
320px breakpoint

Reduced footer padding in both sections on 544px breakpoint
Swapped Consortia section Heading 4 for Heading 3 on two breakpoints:

544px breakpoint
320px breakpoint

Updated the Contribute menu so that the buttons are aligned on both sides

1920px
1440px
1280px

Let me know when this is completed and I will send out the MVP0 for review!

@LibbyUX made above changes in PR #32

Design to Dev Updates
Hi @bhushankhope, here are the current updates based on the MVP0 review. Also, I am mentioning @u-p-design for visibility!
Global updates & design system updates
Typo in production footers

Please fix the Functional Tissue Unit (FTU) Explorer button label

All HRA category icons resized

Sizes reduced in both sets of category icons and their rounded button component for all landing pages

Significant updates to footer components
The footer component was one of the biggest sources of issues during the review. Please ensure each breakpoint is well inspected and as close to spec as possible.

Spacing and padding adjusted on nearly every component breakpoint
430px breakpoint variant added
Logos updated
Secondary navigation buttons updated: smaller variant added and font styles updated
Font styles updated on every breakpoint for CNS Copyright, Funded By, and Medical Disclaimer text

Breakpoint updates
320px breakpoint
Splash section:

Vertical padding and vertical height adjusted
Spacing adjusted in text container

Consortia section:

Vertical height and vertical padding updates to make this section smaller

Use the Atlas section:

Icon size reduced in Use the Atlas Section
Vertical padding reduced
Spacing reduced in container
Spacing in category containers reduced

Breakpoint Added: 430x932

A new breakpoint has been specified because the reviewers require excellent mobile experiences.
Please see 430x932 XSmall iPhone 15 & 16
XSmall iPhone SE has been renamed to XXSmall

544px breakpoint
Splash section:

Font updated
Vertical padding and vertical height adjusted

Consortium section:

Font updated
Vertical padding and vertical height adjusted

Use the Atlas section:

Font updates
Icon size reduced
Spacing updates
Smaller button variant used

768px breakpoint
Use the Atlas section:

Horizontal padding decreased to match footer

Issue superseded by https://github.com/hubmapconsortium/hra-ui/issues/356
Thanks for everything @bhushankhope! Closing this one out now!


tmux module: Fix escaping in TMUX_TMPDIR

5404595b55eeefae69f2952a34dfc70e32523060 relocated code but kept
one backslah too many, leading to
$ tmux
error creating /run/user/1000/tmux-1000 (No such file or directory)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Review per https://nixos.org/nixpkgs/manual/#reviewing-contributions-module-updates
Reviewed points

[x] changes are backward compatible
[x] removed options are declared with mkRemovedOptionModule (none)
[x] changes that are not backward compatible are documented in release notes (none)
[x] module tests succeed on ARCHITECTURE (no tests available)
[x] options types are appropriate (not changed)
[x] options description is set (not changed)
[x] options example is provided (not changed)
[x] documentation affected by the changes is updated (none)

Possible (but certainly not necessary) improvements

The commit message could be changed to match the format given in https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches , e.g. "nixos/tmux: Fix escaping in TMUX_TMPDIR".
I cannot reproduce the error message in the commit message's body. When the issue occurs (with this pull request applied), I'm seeing this instead: error creating /run/user/$(id -u)/tmux-1234 (No such file or directory). Maybe the commit message was accidentally passed through a shell?

Comments

I had a hard time to exact the bug fixed by this pull request as -- under normal circumstances -- pam_systemd correctly sets XDG_RUNTIME_DIR and the default value for TMUX_TMPDIR is not needed. In case someone else wants to investigate why the default value (thus the pull request at hand) is helpful: I added a systemd user service that sleeps 30 seconds while starting and thereby provokes a timeout in pam_systemd during login which prevents XDG_RUNTIME_DIR from being set. This renders tmux unable to start without this pull request.
With this pull request applied, tmux works even without XDG_RUNTIME_DIR.
The tmux.nix module has no maintainer set.
I recommend merging this (trivial) pull requests.

@Yarny0 I pushed a newer version of the commit (with a more descriptive message). Does it make more sense to you now?

@Yarny0 I pushed a newer version of the commit (with a more descriptive message). Does it make more sense to you now?

Yes, thank! I didn't know about the connection of /run/user with polkit.
I have no further objections.


Expose GP to user

The GP's performance is highly dependent on its hyperparameters, obviously (see here from the george docs, so my scheme of a "general" way of initializing the GP is not going to work for everyone's use case.  I need to allow the user to full define the GP, provide initial guesses for hyperparameters, e.g. the metric, amplitude, etc..., and so on.  My hyperparameter optimization scheme should be ok, however.

I'm going to do this and break the API, but we have the technology, we can rebuild it.

Reasons for this change:

I have no idea a priori what the likelihood space topology will look like for any given use case.  Designing a GP initializer would have to scan over a huge space to find a reasonable choice.  This initialization would add needless computation.
A user should have some idea on what the likelihood space will look like and can use that intuition to initialize GP.

New API:
#Create a training set to condition the GP

# Randomly sample initial conditions from the prior
theta = np.array(lh.rosenbrock_sample(m0))

# Evaluate forward model to compute log likelihood + lnprior for each theta
y = list()
for ii in range(len(theta)):
    y.append(lh.rosenbrock_lnlike(theta[ii]) + lh.rosenbrock_lnprior(theta[ii]))
y = np.array(y)

# Guess initial GP metric
initial_metric = np.nanmedian(theta**2, axis=0)/10.0

# Create kernel (the Wang+2017 example is 2D)
kernel = george.kernels.ExpSquaredKernel(initial_metric, ndim=2)

# Guess initial mean function
mean = np.nanmedian(y)

# Create GP
gp = george.GP(kernel=kernel, fit_mean=True, mean=mean)
gp.compute(theta)

ap = bp.ApproxPosterior(theta=theta,
                        y=y,
                        gp=gp,
                        lnprior=lh.rosenbrock_lnprior,
                        lnlike=lh.rosenbrock_lnlike,
                        prior_sample=lh.rosenbrock_sample,
                        algorithm=algorithm)

I think this makes more sense since it gives the user granular control over the GP and the run method now doesn't require theta or y, which probably how it should have been in the first place.


Please validate the stretch of a header part also at the time of Loading.

Hi Chris,
First of all, thanks a lot for your code.
Please validate the stretch of a header part also at the time of Loading.

sorry.
Please enable it to scroll ListView also at the time of Loading.
Is it transmitted?

@Override
public final boolean onTouch(View view, MotionEvent ev)
{
if (isPullToRefreshEnabled)
{
// Returning true here stops the ListView being scrollable while we
// refresh
if (state == REFRESHING)
{
return true;
}
else
{
return onAdapterViewTouch(view, ev);
}
}
return false;
}
change that to:
@Override
public final boolean onTouch(View view, MotionEvent ev)
{
if (isPullToRefreshEnabled)
{
// Returning true here stops the ListView being scrollable while we
// refresh
return onAdapterViewTouch(view, ev);
}
return false;
}
hope that helps!

I've added a method to enable this in e6f9846180b5e6e83aae2226a41c398cfa14f137


Cannot connect to the drone instance

Hi,
thank you for your extension!
Unfortunately I cannot login into my self-hosted drone server

The server is totally fine, publically accessible and has a valid certificate. The token I use is the personal token that I got in the UI
Could you provide some hints why this could happen?
Thanks!

Hey! Thank you for reporting! I need more details to help you: 1) your versions of VSCode and extension, 2) your environment (web?), 3) will you be able to debug the extension?

Hi

the version of VSCode: 1.85.1, extension: v2.0.0
macos
sure, however wanted to avoid it :) seems like it is inevitable. I'll check what I can find there

Actually I get 403 on this line
https://github.com/maximtrp/droneci-vscode-extension/blob/c54a9fefeeea5d586858aed4edd56bbf672b56de/src/repos.ts#L54
However if I change getRepos to selfRepos, it seems the extension works as expected.
My drone instanse is quite restricted by the organization and members, that's probably the reason the original flow does not work.
I'm totally unsure if selfRepos is not breaking another (e.g. your) drone setup. Could you check if this can be used instead of getRepos?

Perfect! Thank you! Fixed in the latest release. This API seems preferrable based on the official documentation.

Thanks! Works as expected now :)


Added some more hand-holding for dummies like me

Added some notes so people new to Edge DTH work can have an easier time using this.

First wanted to say thank you for the work here.  This is not really my skill set but if there are things I can help with testing or other please let me know.  I was wondering about the multi press.  I have two switchs on the  edge drivers but the automations I've attempted do not seem to work.  I've tried to control a couple devices that have edge drivers and some that donot so I'm unclear if this feature is working yet.  Any firmware dependency for the homeseer switches?  I'm sure mine are probably outdated as I have never updated them in the 4 years since they were installed

@stgubala you want to install the more up to date drivers from https://github.com/jshessen/SmartThingsEdgeDrivers . If they have those edge drivers the multi-tap routines should work as indicated in the README file.
My WS100/WD100 Homeseer switches I installed in 2017 are working with multi-tap with those drivers and I never updated firmware on them.

Thanks I missed that these were in the separate branch.  Switching over made them work great.  Any thoughts on addressing the LEDs?

@RandomEngy Thanks for getting me straightened out on the automations.  I can see that in the settings page you can change the switch into status mode and control the LED's .  Is there guidance yet on how to address the LED's in automations?

@stgubala I only have the 100+ model switches and I've never tried to directly control the LEDs.

@stgubala I opened a feature in the main repo jshessen/SmartThingsEdgeDrivers/issues/19

Thank you for the update.  I have all 200 and 300 series dimmers and
switches.  I'm more than happy to test your code on the 200 series
switches.  But I looked around the github repository and perhaps I'm just
blind.  Bu I could not find the invite to the beta drivers.
Steve G
On Fri, Jan 27, 2023 at 6:50 AM Jeff Hessenflow @.***>
wrote:

@stgubala https://github.com/stgubala I opened a feature in the main
repo jshessen/issues/19
https://github.com/jshessen/SmartThingsEdgeDrivers/issues/19
—
Reply to this email directly, view it on GitHub
https://github.com/ryanjmulder/smartthings-edge-drivers/pull/9#issuecomment-1406609913,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI2LQX4HUCIZREVXPDCYODLWUPOCFANCNFSM6AAAAAAUAU7X24
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'm not sure how this PR got to be such an active thread but the real repository is at https://github.com/jshessen/SmartThingsEdgeDrivers . That has the channel invite link and you can open issues directly there.

As far as the PR.  There was a post on the r/smartthigns redit about them and I connected the Homeseer forum where a few of us were discussing these switches.  I suspect that the two things have sent a few people here.
I guess I'm already on the Beta channel as they already show installed on the invite.  And I unistalled devices and select the driver when it was suggested I use that channel a day or so ago.  Current showing driver version 2023-01-21T04:06:45:843229802  but I can't address them in autmations.  Not sure how to force an update however.
I just realized that I should probably use the smartthings forum for items like this.  So I'll follow up there.


In mobile after click on hamburger details not showing

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello @thestarsahil please assign this issue to me under gssoc 24


Tables Dynamic export csv file with Chinese will Garbled and can‘t export excel

no excle button show on the page

Is this related to gentelella?
Please elaborate more on this with steps or else we can close this.


Fix ODH release

Description

Fixes an issue with odh deployment that prevented the image from running when built by openshift-ci.
How Has This Been Tested?

Create a build with this Dockerfile
Deploy it in your cluster

Also, the main test was done in https://github.com/opendatahub-io/odh-manifests/pull/806
Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@andrewballantyne @LaVLaS tagging you on this PR too, I got the test in https://github.com/opendatahub-io/odh-manifests/pull/806 by the image of this PR, hopefully this will fix the issue we had.

Thanks for investigating -- impressive that cache is the issue here 🤔


Improve README

See https://github.com/stryker-mutator/stryker/pull/197

Currently the logo is broken https://github.com/stryker-mutator/stryker/blob/master/stryker-80x80.png


use lenspath library to simplify replica maps wrapping/unwrapping

move lenspath to covalenthq/

Also, the lenspath path needs to be updated across the repo from - 	github.com/sudeepdino008/lenspath to github.com/covalenthq/lenspath
github.com/covalenthq/lenspath<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/sudeepdino008/lenspath
	        but was required as: github.com/covalenthq/lenspath

@noslav ack. Please check now.


[💡 FEATURE REQUEST]: OTLP support for gRPC

Plugin
GRPC
I have an idea!
Trace collection for gRPC is currently not supported.
While the spiral side of the trace could be done manually, there will still be a lag on the RR side.
Would be nice to have it for RR, too.

Hey @rauanmayemir :wave:
Traces for the gRPC can be configured via env variables for the RR at the moment. We have an updated stats handler attached.
Better support via otel plugin will be added in 2024.1.0.

@rustatian Which env vars should I use? I'd like to add at least some basic otel support.

@rustatian Here you are: link
I didn't test them, tho. You may try to play with them, but the real support for the OTEL will be added in v2024.1.0.


[flash/sram/tlul] Enhance tlul_lc_gate to better outstanding transact…

…ions

enhance tlul_lc_gate to better handle outstanding transactions

when lc_en drops when there are outstanding trasnactions, any
further commands are blocked but existing trasnactions are allowed
to complete. Then the tlul_lc_gate transitions to an error state
where all future commands are directly err'd.

Also switch sram_ctrl to using tlul_lc_gate

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

hey all,
this PR enhances the tlul_lc_gate module to handle outstanding transactions that i think @msfschaffner and i discussed some time back.  It turns out we also needed this for correct (non hanged bus) behavior on flash_ctrl.
This change, if it goes through, impacts flash_ctrl, sram_ctrl, otp_ctrl and rv_dm, so it would be good to probably pull it and make sure it doesn't cause a fire with those blocks. I did some basic checks on each block, and things seem okay. The sram_ctrl_tl_intg_err test needs some updating as discussed with @weicaiyang , and it looks like otp_ctrl_test_access is having separate issues related to the prim csr change.
@msfschaffner i've written out the assumptions i made in this..and possibly the need for some hardening due to the fact there is an fsm in here that could be pretty sensitive. Let me know what you think. I prefer not to go down that route if possible, since it would cause a chain reaction of more sparse fsm handling.

lets wait until @msfschaffner has a chance to look at this to see what he thinks.
I THINK this is what we had discussed, but to be honest i don't remember..want to make sure there aren't other corner cases.
@weicaiyang let me know if you see problems on sram_ctrl side, likewise for otp_ctrl @cindychip

flash_ctrl regression all passes except unimplemented test.

thanks for checking!

@weicaiyang let me know if you see problems on sram_ctrl side

I checked the sram_ctrl intg test. It looks good. Will make a fix in the TB to align with this change

Oh.. I see, I saw the code incorrectly, I thought the function is testing True. :)
Make sense.

On Jun 6, 2022, at 5:53 PM, tjaychen @.***> wrote:
@tjaychen commented on this pull request.
In hw/ip/tlul/rtl/tlul_lc_gate.sv https://github.com/lowRISC/opentitan/pull/13037#discussion_r890674795:

 StActive: begin

   if (lc_tx_test_false_loose(lc_en_i)) begin

     state_d = StOutstanding;

   end

 end

 StOutstanding: begin

   block_cmd = 1'b1;

   if (outstanding_txn == '0) begin

     state_d = lc_tx_test_false_loose(lc_en_i) ? StError : StActive;

   end

 end

ah it only comes to StOutstanding if lc_en_i is made false.
So during normal operation, when lc_en_i is true, the logic should never transition here.
If lc_en_i is false, then the transition should be StActive -> StOutstanding -> StError.
The transition back to StActive in the false condition there was actually something I forgot to remove after the I added the big comment in StError below. Let me do that.
Does this make sense? Let me know where my logic is wrong.
—
Reply to this email directly, view it on GitHub https://github.com/lowRISC/opentitan/pull/13037#discussion_r890674795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDG3X6RNIESWIMZ5Q2WGTVN2MR3ANCNFSM5XZUULFA.
You are receiving this because your review was requested.


[IMPAC-641] IE11: Cash Balance & Projection widget

@cesar-tonnoir
-Resizing of cash balance widget fixed

Actually, no need for you to push more changes on this one => this is going to be fixed by #398


(PA-4234) Update Networking Facts test

In GCE the VMs we use can have a networking.netmask of <IP_ADDRESS>.
This causes failure in the networking_facts.rb, and networking_facts_with_secondary_ips.rb test, this PR updates the regex
to allow for such an IP.
Also we need to have some small changes to the dmi test because if we use a Google Cloud VM
some default DMI settings are changed.

nit the commit check is failing because of the PA JIRA ticket. Maybe just add (maint) ... and then reference the PA ticket in the body?


Put images in images/ folder

Hi there,
what if we put images in a separate folder, eg: images/? This will make the repo more structured and IMHO, cleaner.

Good idea. PR created. Please comment on https://github.com/ossf/secure-sw-dev-fundamentals/pull/147


Mirror CPC with universities/provide some redundancy

We need to (eventually) provide some redundancy for the CPC.
This will involve a couple things:

rsync (or other endpoint, some way to mirror things when the CPC updates)
various volunteers offering to host a complete copy of the CPC with their universities/etc
a new galaxy tag to support CPC downloads where we can update Galaxy on the backend to specify CPC hosts that can be used.

Unlikely to be implemented given the present course of the project. Closing.


Question: Fragment

is it possible to use your library in fragments?

I have used this in fragments but ran into issues and made it a full size activity i don't remember the issue i had,
i wouldn't suggest using a fragment it looses a certain amount of valuable space due to toolbars, etc..
Just a suggestion...


Monitor page for changes

I have implement page change modification.
For now only basic comparison is implemented. So might nog work for more complex pages having iframes etc.
I also added href to title of check in checks overview. So it is more easy to navigate to the monitored url.

Incorrect Code formatting


[index] Make sure that we index implicit constructors

These can be explicitely referenced so we should index their definitions as well

@swift-ci smoke test and merge

@swift-ci smoke test


Add Dark Mode support and guidance

Dark mode is a display options for many.
Currently, we most often leave it alone and avoid intentionally adding inentional dark mode styles.
Per this article, Google may be auto enabling an applying a dark mode theme to sites.
There are a few options to explore:

Intentionally disable dark mode with this: <meta name="color-scheme" content="only light">
Add guidance and starter css for enabling dark mode with intentionally set custom properties
Actually apply a dark mode theme by default - with guidance on how to customize / modify as needed
If we add a dark mode option, should we add / provide guidance for toggling on or off by the user?

I think that if we add the dark mode support by default, it would be the obvious decision that the developer has to make - continue supporting it or disable the dark mode support (which will be documented).
And for dark mode tactics on the CSS properties, I found this to work well:
:root {
  --c-base: white;
  --c-base--invert: black;

  --c-text: black;
  --c-text--invert: white;

  --c-primary: red;
  --c-primary--invert: white;
}

@media (prefers-color-scheme: dark) {
  :root {
    --c-base: black;
    --c-base--invert: white;

    --c-text: white;
    --c-text--invert: black;

    --c-primary: tomato; /* Red becomes too dark to see, so we make it lighter */
    --c-primary--invert: black; /* White won't be readable, so the text becomes black. */
  }
}

The idea is that each color has an "invert". This is a color you can place as the opposite (background-foreground) that has contrast. Base would be body, base-invert would be the text on it.
For button, —primary is the red color, —primary—invert would be the text on top of the button.
This allows for change to the primary color without worry for the contrast of the text itself. Here is another example: https://codepen.io/xavortm/pen/RwLrjZW - this showcases the codebase above.
I think that the —invert suffix helps in dark mode as often, the color itself is slightly adjusted.
Color changes:
With dark mode, as mentioned above, the color will also change (primary color, accent color etc). This is an excerpt from Google Material design: https://material.io/design/color/dark-theme.html#anatomy

Desaturation: Primary colors are desaturated so they pass the Web Content Accessibility Guidelines’ (WCAG) AA standard of at least 4.5:1 (when used with body text) at all elevation levels
Limited color: Large surfaces use a dark surface color, with limited color accents (light, desaturated and bright, saturated colors)

And because we have to desaturate the colors, it's possible that we need to also change the invert. Brighter red, will no longer work with white text to keep contrast. In fact, sometimes it could be a design decision to add color to the invert as well, so we have Light red background with deep red text

@joesnellpdx - my 2 cents here is to follow on what industry giants are doing - Slack, Bear, Sketch, Zeplin etc all by default inherit Dark Mode from the OS preference and provide an option to override this (not sure how, maybe a JS script or CSS override)
I'd also like to find some way of programmatically calculating dark mode colours for accessibility - often Dark Mode is just an "invert" of colours - which often looks terrible. It would be great to try find the dark mode contrast alternative to a colour and set that using CSS variables...like white text is to black text but for all colours used / defined in the theme.

@joesnellpdx totally onboard with Daine here. And what @xavortm outlines is really great. I love the desaturation mention. We should definitely aim to support dark mode. CSS Props are the best way to go IMHO.

Backing on what others have said ( @dainemawer and @xavortm ) I think what I'd like to see in the scaffold:

Update our colors.css to include @media (prefers-color-scheme: dark) or similar as an example of a simple implementation that'll respect the OS + browser setting.
Include comments with the meta mentioned so that if a color scheme hasn't been planned in discovery, the browser can't mess up the design and accessibility by guessing/inverting.
Possibly also include comments to how to use JS to handle using matchMedia, but honestly I think a search for the engineer would be fine in this instance.

Much as I hate to say, I don't think the scaffold should go crazy with adding a bunch to support this. Reason being, is that this is an issue that needs to be brought up and planned for earlier in the process. I think having examples / docs in the scaffold is good to have though for our "preferred" implementation, in which case I like @xavortm's example.


PFObject thinks 'YES' and 'NO' in BOOL property is a 'number'

I got an error on saveEventually about this when I updated to 1.8.0.
Say I have a custom subclass called MyObject. The following errors out:
MyObject *obj = [MyObject object];
obj.isAwesome = NO;
[obj save];

Just following syntax here: http://blog.parse.com/announcements/stay-classy-objective-c-introducing-native-subclasses-for-parse-objects/
The workaround for now is of course to set a bool value on the object:
...
obj[@"isAwesome"] = @NO;
...

Hey @fatuhoku, looks like this is duplicate of #13 (BOOL vs NSNumber) and it was already fixed in master.

@nlutsenko Fantastic!


mini.files: error when - called on unsaved file

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.files
Description
If I open a new file and then try to navigate its parent directory using -,  I get an E5108: Error executing lua: (mini.files) path is not a valid path error. I don't think the file not being written should matter, since the parent directory exists.
Neovim version
v0.10.0-dev-c81b784
Steps to reproduce

mkdir -p foo
echo "a" > foo/a.txt
nvim foo/b.txt
press -

Expected behavior
show me my directory explorer
Actual behavior
error

This is intended and documented behavior. Ensuring that path actually exists on disk simplifies code logic down the line by removing the need to do later checks.
Plus I assume that - calls MiniFiles.open() with the path of the current file, which should result with cursor placed on that file in the explorer. This is impossible because there is no file on disk (yet).
The cost of not being able to open explorer with focus on non-existing path seems OK for me.
Closing as not planned.


Duplicate or unclear list items in "Gallery onboarding checklist"

The "Gallery onboarding checklist" contains two items with nearly identical wording that are either (a) accidental duplicates or (b) insufficiently differentiated.

Establish engineering and support contacts to guide customers post gallery onboarding (Required)
...
Establish an engineering and support point of contact to support customers post gallery onboarding (Required)

If (a), remove one of the items and clean up wording of the remaining one as desired.
If (b), reword one or both as necessary to make it clear what they're asking. The two items should also probably be next to each other on the list since they deal with the same requirements area.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 271dc426-fb47-7441-d627-ec11f8c7a6ea
Version Independent ID: 4cb8bfc8-4748-e501-425a-e4c2da0f5f5a
Content: Tutorial - Develop a SCIM endpoint for user provisioning to apps from Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/app-provisioning/use-scim-to-provision-users-and-groups.md
Service: active-directory
Sub-service: app-provisioning
GitHub Login: @kenwith
Microsoft Alias: kenwith

@scarson
Thanks for your feedback! We will investigate and update as appropriate.

@scarson
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

Moved to work item in backlog. #please-close


nodeos does not start syncing after genesis block

I installed eos from sources
inited it with genesis:
/home/studnev/eosio/1.8/bin/nodeos --extract-genesis-json genesis.json
and started as
/home/studnev/eosio/1.8/bin/nodeos -e --genesis-json genesis.json --disable-replay-opts
config file, text output is attached.
I do not see ant syncing progress with mainnet. It is showing the latest block as 1.
logout.txt
config.ini.txt

Problem was that i used genesis .json generated by nodeos --print-genesis
which does NOT generate genesis for the Mainnet which is very confusing

"Mainnet" is just one of many.

I understand, but this is not said in the help of the method and not very well described in the documentation. Do not use genesis.json generated by the node automatically!

Fair enough. I'll see if we can make the doc clearer.
To be clear can you provide a link to the doc you are following?

@dskvr


Monitoring

Expose metrics using prometheus
Allow users to give feedback on the answer of the model

The following metrics where added:

request_count (Count)
request_duration (Histogram)
phishing_url_count (Count)
safe_url_count (Count)
prediction_accuracy (Gauge)
user_feedback_correct (Count)
user_feedback_incorrect (Count)

I fixed some minor style things in that commit I added


Custom connector for Zipwhip SMS

Description of Problem:
Unable to easily run a bot using Zipwhip
Overview of the Solution:
Create a Zipwhip custom connector
Examples (if relevant):
https://rasa.com/docs/rasa/user-guide/connectors/custom-connectors/
Blockers (if relevant):
No
Definition of Done:

[ ] Tests are added
[ ] Feature described the docs
[ ] Feature mentioned in the changelog

Thanks for submitting this feature request 🚀 @tttthomasssss will get back to you about it soon! ✨


Should a CI/CD pipeline stack be part of the scope here?

Do you think this spec here should be opiniated about a CI/CD pipeline?
I mean, that’s not something you must have in order to use this stack, but it is something nice to have.
Maybe a “Nice to have” session where we could put something like CI/CD, Bots integration, Backup routines, and so on...
What are your thoughts on this?

Great. What are your thoughts about that CI/CD pipeline?
By the way, I updated the TODO list https://github.com/flaviostutz/docker-swarm-cluster/commit/0bc87ab3e1b09d6a2d91a4886eb6844bbed24843

Just a way to integrate the running cluster to an existing repo. We could start with GitLab, so we would have the Docker registry already integrated with the repo.
We could specify everthing needed for a source code push trigger a CI/CD pipeline from building the package until runnint it.

As you put GitLab in the TODO list, I'm closing it here.
closes #1


Incorrect github alert for transitive dep on cryptiles

The alert says we have an vulnrable version of cryptiles, but the fix for the issue has been backported and the CVE report has not been updated. The alert is outdated.
The alert: https://github.com/ipfs-shipyard/ipfs-desktop/network/alert/package-lock.json/cryptiles/open
The ipfsd-ctl issue:  https://github.com/ipfs/js-ipfsd-ctl/issues/312
and cryptiles PR where it is backported: https://github.com/hapijs/cryptiles/issues/35

I've cleared the alert. This research is for posterity.


ImportError: No module named packaging.version how to fix it

I updated the ubuntu system.
Unbale to install python packages , receiving following error.
ImportError: No module named packaging.version
Traceback (most recent call last):
File "/usr/local/bin/easy_install", line 7, in
from setuptools.command.easy_install import main
File "/usr/local/lib/python2.7/dist-packages/setuptools/init.py", line 12, in
import setuptools.version
File "/usr/local/lib/python2.7/dist-packages/setuptools/version.py", line 1, in
import pkg_resources
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 70, in
import packaging.version
ImportError: No module named packaging.version
Please someone help me how to fix it

Python2.7 is not supported.
You should use python 3.

how can I proceed with  python 2.7. it was working before this morning. After updating system it giving the error.
how do I revert the changes

Python 2 has not been supported since 2014:
https://github.com/home-assistant/home-assistant/releases/tag/Last-Python2-release

This is my whole error.
root@user-virtual-machine:/home/s.viswanathan/automation/fm_system_test# pip install paramiko
Traceback (most recent call last):
File "/usr/bin/pip", line 5, in
from pkg_resources import load_entry_point
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 70, in
import packaging.version
ImportError: No module named packaging.version

Use pip3 to ensure it uses python3

I dont have python3 installed in my machine

If you want use Home-assistant, you will need to use python3.


[Question] Can this tool be used to add/modify localization in the game?

Sorry for asking this question, but I looked through possible links and still couldn't find the answer.
Actually, the question is in the title of the topic.
Can it be used to somehow influence the localizations available in the game?
For example, load a modified Game.locres, packed or not. Or some other way.
And is it possible to add a localization language using this tool?

You can load modified Game.locres by using simple pak patching methods, you don't need ue4ss for this. If localisation is stored in datatables, in the future when #260 is released it will be possible to edit datatables in lua or c++ mod without breaking things if other mods try to do the same thing. But you can still just edit datatable in an asset editor like uassetgui and then pak that as a replacement mod, don't need ue4ss for that. And again if strings are hardcoded in kismet bytecode you need to use uassetgui to edit that as a replacement mod.
So the anwer to your question is, for the most part no, this tool isn't used for localisation modding.


Update native dependency install to install msal-node-extensions

msal-node-extension has native dependency in the same way keytar package has. So this package needs to be reinstalled before running test. PR modified current native dep install code to support more dependency.

@sadasant : This PR should resolve native dependency issue you are facing for identity changes.
@mikeharder : Identity PR is failing with new changes which adds msal-node-extensions package and this has native dependency.

We can do this for now to unblock pipelines, however we should carefully review this native dependency.  Some of our customers refuse or are unable to use packages with native dependencies, as documented in https://github.com/Azure/azure-sdk-for-js/issues/13950.
@sadasant: Are we planning to minimize the scope of this native dependency so customers can avoid installing it unless they require its functionality?

@mikeharder I've made a new issue to resolve this as part of this month's tasks before we release the 2.0.0 version: https://github.com/Azure/azure-sdk-for-js/issues/14346 how does that sound?

@mikeharder I've made a new issue to resolve this as part of this month's tasks before we release the 2.0.0 version: #14346 how does that sound?

Sounds good, I agree this is a separate issue and I will put further comments in #14346.


FontLoaderCallback removed?

Hi,
we were using a rather old version of svg (nuget svg.core). We require to override PointsPerInch which wasn't available in SVG.Core, and then we found out there is also nuget SVG which is far more active then the SVG.Core library anyway.
But, we made use of the FontLoaderCallback, which was still present in SVG.Core (latest tag: nuget3.0.49), but for some reason got refactored out in SVG.
This is the diff where it got removed:
https://github.com/svg-net/SVG/commit/41c2bf78c07f1502428143f6753788905c0f509e?diff=split#diff-091a92f6e2b9f631466f75115d6fd305ee49b1fc2d3d44f8793f025828aabd51
In the git comments I can't find any reason that this was removed intentionally.
Maybe some context how we used this:

We are using SVG to render stuff on a graphics object which is printed on an HID element printer.
The SVGs are typically designed in Inkscape, on a different pc.
When our software loads the SVG layout, the special fonts defined by the ID card designer, are located next to the SVG layout, and we'd load them in on this FontLoaderCallback callback.

Would you remember why this is refactored out? Was there a problem with this design? I don't really see a better alternative then forking your library and restoring the callback.
Am I missing the obvious?
Would it make sense to make a pull request to svg-net?

Old SvgFontManager can not manage font resources, so I redesigned it.
Since this is a complementary feature to inability to specify fonts within SVG, I don't think it's necessary to load fonts dynamically.

Argh, I completely missed the public static SvgFontManager.PrivateFontPathList which serves this purpose just fine.... My apologies, "problem" solved


Create Appointment API

In this PR, I did -
Appointment API:

Create GET Appointment API endpoint

Create POST Appointment API endpoint

Create DELETE Appointment API endpoint

Add validation in Appointment model

Add API control file with necessary actions

Update routes.rb file to match controller actions

Unit Tests:

Add unit tests for  Create show and destroy Appointment APIs in spec 📂

Thanks, @Enning94 for Approving this PR 🙂.


Add FBX SDK

Adds the compiled FBX package that results from following the steps in https://github.com/icosa-gallery/open-brush/blob/main/Support/fbx/README.md
I haven't tested this on my Quest specific fork so there may be CI issues to solve.

@mikeage I'm guessing we need to add another exclusion filter to precommit for the packages folder?

I actually like the changes it made… but I don’t think we should be touching 3rd party code unless it’s an actual bug fix, so yes

Github is being a bit wonky when showing me the diff (because it's huge) -- in projectsettings, can you remind me what the 14 is for?
   scriptingDefineSymbols:
    1: USD_SUPPORTED;UNITY_HAS_GOOGLEVR;TILT_BRUSH;FBX_SUPPORTED;FBXSDK_RUNTIME
     7: TILT_BRUSH;OCULUS_SUPPORTED
     14: USD_SUPPORTED;UNITY_HAS_GOOGLEVR;TILT_BRUSH

I know 7 is Quest -- I think 1 covers both SteamVR and Rift native, right?

Do we need to exclude the autodesk stuff from the code format checks?

Yeah we do, I was having a look at how to exclude multiple folders from pre-commit but can't quite work out the regex!

I'll take care of the pre-commit stuff now

Done. @mikeskydev  / @andybak , is there any more testing that needs to be done?

I suppose this might potentially break exports in builds. I've tested in Unity.
I've slightly lost track of the state of affairs without this PR. The decider should probably be "What's the worst that can happen?" vs "How broken is it before this?"

By my recollection - fbx support worked in official builds before but not in the editor. Is that right? And it wasn't enabled in PR builds. It will still fail in experimental builds because of the new brushes (I've got a branch that fixes this crudely - at least to the point where the exports work but new brush strokes look weird).

Yeah, on official builds I just built it from my own computer to add FBX.
Sidenote, I'll update the README to remove the references to adding FBX support!


Fix flaky backend tests - snapshots ignore included array

Using fork of snaphost gem, until I make a PR to main gem and it's merged.
Testing instructions
I was no longer able to get any failing specs when running specs multiple times this way
for i in `seq 20`; bundle exec rspec spec/requests; done

Tracking
Link to the task(s), if any

I'm not sure if I did it correctly as the author of the library is sorting ignored Arrays by arrays of elements hash values, maybe there is a better way, but it's ok for now.


Render question text with markdown formatting

Description
Renders question text with markdown formatting in five new places
Some screenshot samples

question bank

program edit view

question list view

Checklist
General
Read the full guidelines for PRs here

[x ] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[x] Extended the README / documentation, if necessary

Issue(s) this completes
Fixes #6420

I added markdown and regenerated screenshot tests for the eligibility predicates. For operator-help-text.png the screenshot was regenerated without any changes and I think I'll have to rebase to remove the file as changed. I hope that leaving it as-is is okay!


Fix webhook tests for rewrite probe

In https://github.com/istio/istio/pull/28800, we changed to reading the
probe setting indirectly from the injection template to reading it
directly from the source (values). This made these tests, which have a
custom template and don't set the values, not test the right thing.
This updates the tests to set the values correctly. Additionally, I
removed the obsolete field in injector template.
An alternative to this PR would be to continue to read the setting from
the template. I do not think its a better option, but don't feel
strongly either way; it should not impact users either way

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
1f990f48c9db2e5a8ddba1cb63d71b8198372bb0
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Mapping: Ignore NSNull in source collections

@segiddins This is useful if you're mapping a nested optional value from a collection. Say you want to map all the parole officers in the response, you might add a descriptor for key path users.parole_officer. But without this fix, RestKit will attempt to map NSNull onto a newly-created ParoleOfficer entity and everything will explode.
{
  "users": [{
  		"id": 1,
  		"username": "dan",
  		"parole_officer": {
  			"id": 3,
  			"username": "iamthelaw"
  		}
	},{
		"id": 2,
		"username": "jake"
	}]
}

Could you add a test for this?

@segiddins Sure thing, doing that now…

@segiddins Test is up! Confirmed it fails without the tweak.


[Bug]: Player aggro music does not play

Minecraft Version
1.20.1
Mod Version
1.0
Mod Loader
Forge
Mod Loader Version
47.2.0
Describe the bug
Player aggro music does not play at all
Steps to Reproduce

Get hit by player/hit another player
No music plays

Crash Reports/Logs
No response
Is OptiFine installed?

[ ] OptiFine is installed

Screenhots
No response
Mod List
Essential
Mod Battle Music

Pretty sure this was resolved

Yeah, make sure you're hitting the player with a weapon since that's the only way it'll go off


[WIP] [Feature sheet] Refactor bottom sheet using custom FloatingHeaderBehavior

[x] Split up and simplify BottomSheetBehaviors
[x] Split up and simplify metrics an transitions
[x] Let header remain on screen when bottom sheet expanded, simplifying code and obviating need for negative expanded offsets or other workarounds.
[ ] Fix: Bottom sheet is collapsed and screen remains frozen after returning from add/edit observation screens

Punted additional fixes, refactors, and UI tweaks to follow-up PR(s):

[ ] Additional simplifications to feature sheet layout file structure
[ ] Consistent naming of feature/bottom sheet components
[ ] Fix styles to work with latest  Material components, upgrade version
[ ] Delete custom BottomSheetBehavior class
[ ] Add back drop shadow below header / above observation list
[ ] Fix: Marker not centered in collapsed map
[ ] Remove toolbar drop shadow when  bottom sheet is expanded
[ ] Make toolbar background transparent until sheet is expanded

Expanded/collapsed states:

@dturner Almost there.. only issue remaining is the bottom sheet UI state doesn't seem to get persisted after tapping an item in the list; the sheet is returned to its HIDDEN state, even though the HomeScreenFragment still has the map as locked. This works in master. Any idea what in this change could have prevented the BottomSheetBehavior from preserving its state?

@dturner Almost there.. only issue remaining is the bottom sheet UI state doesn't seem to get persisted after tapping an item in the list; the sheet is returned to its HIDDEN state, even though the HomeScreenFragment still has the map as locked. This works in master. Any idea what in this change could have prevented the BottomSheetBehavior from preserving its state?

Please disregard - I've started a new PR (#463) to merge in relevant pieces of this change incrementally.