Restart Hive Admission when certs expire

Adds a hash to the operator config to keep track of the openshift-config-managed/kube-apiserver-aggregator-client-ca configmap's contents. If it changes, admission is redeployed.

/retest

/retest

Looks good just some logging nits.

/hold

Review comments addressed, but I'm seeing admission still break during manual testing. Need to figure out the cause first.

@csrwng I am working on a PR for hiveadmission fixes we uncovered for 3.11 in hive-stage. Cert problems due to removing something needed for 3.11 during the recent refactors. This probably isn't your issue if you're on 4.x though. We also caught the webhook name conflict so will include a fix for that as well.

/hold cancel

@dgoodwin so it looks like the issue I am seeing is due to the kube-apiserver-aggregator-client-ca configmap not getting updated when certs rotate. The master team is following up. However, when it does change, it looks like we're doing the right thing. I've removed the call to force a restart of the admission deployment and now simply set an annotation with the latest configmap hash. When that changes, a redeploy should occur.

/lgtm

/lgtm

[test]

Timeout exceeded waiting for the cluster to be ready:
level=debug msg="Still waiting for the cluster to initialize: Working towards 0.0.1-2019-03-25-140449: 99% complete"
level=fatal msg="failed to initialize the cluster: Working towards 0.0.1-2019-03-25-140449: 99% complete: timed out waiting for the condition"

/retest

level=fatal msg="failed to initialize the cluster: Working towards 0.0.1-2019-03-25-160142: 98% complete: timed out waiting for the condition"

/retest

/retest

/retest


public Team-dashboard

Scenario:
A sales team has a shared team-dashboard, which is shown on a smart-TV screen using a built-in browser.
This would require:

option to access a Dashboard through a public url (e.g. protected by a hashkey, no login)
show a dashboard outside the context of the nova gui / hide the nova frontend and disable all other resources

following hack into nova/layout.blade.php will hide the nova menu when ?plain is added to the url - so the dashboard appears to be standalone

missing is a way to authenticate the url - maybe with setting the plain parameter in url


Add nav bar component to the application

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Consider a more explicit and simpler contributor acknowledgment workflow for project maintainers and contributors

My workflow for acknowledgment of user efforts currently includes a scan of included issue reports and pull requests with each new release, followed by an update of the project CONTRIBUTORS.md file.  I attempt to link contributor GitHub accounts with their name on the CONTRIBUTORS.md page.  This is a time consuming manual task for projects with a low-moderate number of contributors and I would venture to guess it is not a sustainable model for projects with large numbers of contributors who meet these criteria.  My acknowledgment workflow includes far less information/modification of the contributors page than you propose here.  I would consider modifying your spec to support the following:

encourage contributors to pull request their own information into the acknowledgment section/page that you specify
include an information page that explicitly defines the project specific contribution levels that meet criteria for inclusion as a contributor

This has been an issue for us in the Hack project where source code commits are a very minor component of the intellectual/design/development contributions that have occurred in the project and therefore acknowledgment of these efforts is an entirely manual process outside of the contributors list provided by GitHub.  I've chosen to be very inclusive in the level of contribution necessary to be considered a project contributor because I highly value this input and it leads to modifications/improvements in the project.  In my opinion, the acknowledgment is both appropriate and important for this project.  If someone else were maintaining this project or a similar type of project, the criteria could be very different.  IMO, a contributor is entitled to this information and I look forward to how you approach this issue as guidance for those of us who maintain open source projects.
As a project maintainer, I want to commit to the acknowledgement of, and actually acknowledge, contributions according to your specifications, but it needs to be feasible to do so when the proposal is a manual task like you suggest here.  As a contributor to other projects, I want to understand the type of contribution that is necessary to be included as a project contributor and expect that contributions of my time at these levels are appropriately acknowledged.  I think that you have the opportunity to try to bridge that divide here.
Kudos to you for this effort.

Yeah, this definitely adds some overhead. You may be interested in what @jfmengels is working on here.
I definitely feel like having an external CONTRIBUTORS.md is acceptable for projects with a ton of contributors.
You may also be interested in what @mgechev is working on here. Though this only covers the people who have code/PR/issue contributions.
I agree with your first suggestion. As for the second suggestion, I would recommend that this definition lives in the specification. Projects can divert from the spec if they so choose, but they'll have to do that in their own contributing guidelines.
So I'll happily accept a PR that adds your first suggestion :+1:

I would recommend that this definition lives in the specification

By this you mean that all who report an issue, submit a pull request, or contribute to the conversation in an issue report / pull request GitHub thread are included as project contributors?

Yes, that's what I mean. Each of those scenarios you mentioned are valuable contributions to a project. But like I said:

Projects can divert from the spec if they so choose, but they'll have to do that in their own contributing guidelines.

Just to throw in a :+1: for the spec supporting this in CONTRIBUTORS.md because, in large or even medium sized projects, this could get out of control. Additionally, some projects use their README.md for their primary documentation, which means it's already quite a lot of info for users to peruse.
None of that should take away from the fantastic effort to recognize and encourage all sorts of community contributions to a project, for sure!

Yeah, I'm personally not convinced that using a CONTRIBUTORS.md file accomplishes nearly what putting it in the README.md does. So I'd say that you'd need a lot of contributors before you move it out. I'm willing to accept a PR that adds this disclaimer allowing maintainer prerogative on this subject, but I want the language to indicate that the preference is somewhere prominent for the project (whether that be a README or the website).

Sadly I don't think I've ever looked in a CONTRIBUTORS.md file, so I'm going to have to agree with @kentcdodds

Yeah. It's gotta be somewhere where people can't help but see it for it to have the right effect of truly showing recognition and appreciation.

From https://github.com/kentcdodds/all-contributors/issues/9#issuecomment-190318041

Yes, that's what I mean.

We may differ in opinion here, but my feeling is that this is too inclusive of a definition as a project contributor and opens the automated approaches that you recommended to abuse.  An all comers (rather than moderated all contributors) approach assumes that users use issue reports for project contributions alone.  Many issue reports are clarifications, need for additional information style questions, & overlapping issue reports from those who did not take the time to search closed issues that have previously been addressed.  I do not consider these contributions to a project.  On the sometimes benign/sometimes nefarious side of things, well meaning issue reports can be pulled off topic and new issue reports can be submitted by a GitHub account user who has absolutely no constructive intent.  I think that you will have a tough time with adoption if you cast this broad of a net with your term "all".

I think you're misunderstanding what I'm saying. I'm not saying that anyone who files an issue gets on the list. I'm saying anyone who contributes to the project gets on the list. Contributions include anything listed in the specification. It says nothing about people who ask questions or file duplicates. But people who file bugs or answer questions certainly are contributing to the project.

the automated approaches that you recommended

I actually don't recommend @mgechev's approach because I believe that it could lead to this kind of abuse. But I called it out because I think it's cool work and think it's worth looking at. As for @jfmengels solution, it still requires human interaction to make it happen and I think that's a good thing.
Does that help clear up confusion?

@Jameskmonger & @kentcdodds

Sadly I don't think I've ever looked in a CONTRIBUTORS.md file, so I'm going to have to agree with @kentcdodds

Yeah. It's gotta be somewhere where people can't help but see it for it to have the right effect of truly showing recognition and appreciation.

I think that this effectively eliminates use in large projects distributed over a number of maintainers where I feel that this is likely most valuable and needed!

Right... As I said:

So I'd say that you'd need a lot of contributors before you move it out. I'm willing to accept a PR that adds this disclaimer allowing maintainer prerogative on this subject, but I want the language to indicate that the preference is somewhere prominent for the project (whether that be a README or the website).

Does that help clear up confusion?

Yes it does.  Thank you.  I misunderstood your original response to the question and the automated link/image generators.
For point 1, this is actually an implementation issue and probably not an issue for your spec though I do see it as a problem.  Automation won't be granular enough to define contributors, manual maintainer driven tasks will will be onerous for extremely active projects.  Users should feel welcomed to add themselves to a contributors list where ever it may live in a repository and a mechanism is in place with the pull request.
I would be interested in your thoughts on point 2 though.  Has your experience been that projects that include a CONTRIBUTING.md file commonly include information about how one will be acknowledged as a contributor to the project?  My experience has been that these are largely instruction files that deal with how one contributes to the project, not how one's contributions will be acknowledged after that contribution.  While point 1 was intended to make this spec easier to implement for the project maintainer, point 2 will without a doubt create additional work for this group of individuals.  However, I think that this additional work creates a more responsible environment for the management and appropriate acknowledgment of open source contributions.  The specification of the need for an explicit set of definitions for the term "contributor" would be very appropriate in a specification that is designed to acknowledge all contributors.

Yes it does. Thank you.

Glad we got that worked out :+1:
So I definitely recommend that all projects have a CONTRIBUTING.md file to define how to contribute, but I think that if a project wants to follow the spec, they can just direct people to this spec for them to know what contributions will result in them being added. As I said, projects can feel free to divert from the spec and they could specify that diversion in the CONTRIBUTING.md file.
As for managing additions to the list, I think that it primarily should be the responsibility of the contributor to add themselves. "It's our code. We're maintaining this project together." These are attitudes I hope that doing this will foster.
I think I may be missing something from what you're trying to say though :-)

I think I may be missing something from what you're trying to say though

Simply stated, the emoji list will not be explicit and project-specific enough to define the term contributor.  It is good to have these general categories that include guidance about non-source code contributions.  I think that this is an important first step to actually acknowledge that these are important contributions to a project irrespective of the way in which GitHub classifies a contributor.  I am suggesting that you also provide guidance within the spec that projects offer a project-specific set of definitions about how contributors achieve the contribution milestones in your contribution category list (currently called emoji key) and if project maintainers elect not to support some of the categories in the spec as defined over the course of time by yourselves and others who weigh in here, that this information is explicit as well.  I think that we can do a much better job with objectivity and transparency in the relationship between maintainers and contributors and a spec like this is a great place to start.

:+1: sold. Thanks for explaining. I'm happy to accept a PR that adds both of those to the spec, (ensuring that the language leans toward ensuring the list is in a prominent place if reasonable).
Be sure to add yourself to the list of contributors ;-)
Thanks!

#12

#12 merged


Annotate fallthrough paths with attribute

This uses the GNU extension of __attribute__((__fallthrough__)) to
indicate the fallthrough paths.  The comments were introduced in GCC 7,
which introduced this attribute.  Adding this attribute additionally
silences the warning from clang.

Thanks, but that is bit too ugly with compiler detection conditionals spread all over the code.
Can you explain a bit more about how and why clang now complains without supporting GNU comment convention - or does with a slightly different spelling? Or is there a clang warning that can be disabled?
Alternatively, the portable library should add a new fallthrough.h facility that defines a macro that implements fallthrough.
How do other projects handle this?

I agree that this is ugly due to the macro.  I couldn't figure out how to ensure that the header would be included by default, but that would be better.  If you could point me to how to ensure that the header is always included, I could refactor this.  You could disable the warning using -Wno-implicit-fallthrough, though it seems better to address this for better static analysis.  I don't believe that clang ever supported the comment form - the attribute is explicitly indicating the fallthrough - which one could argue is the alternative (and compatible) spelling.

As to including in a common header, I can help look into that. There is a flatcc header that includes the most relevant files from portable which will get included just about everywhere. But I am not quite ready to invest in that.

__attribute__((__fallthrough__)) is supported by both gcc[>=7], which is what the comments were introduced for in the first place, and clang.  However, __attribute__ is not supported by MSVC and will require a check no matter what.

@mikkelfj - I think that this was the alternative version.  I couldn't figure out how to plumb this through portable.h, but this does show how it could work.

I'll need to think about this a bit.
As to your latest fallthrough commit, that is fine as a proof of concept. There are some style changes required such as portable not being flatcc specific, so it would define either FALLTHROUGH or PFALLTHROUGH, or lower case ditto. The file would be named pfallthrough.h, and some flatcc header would include the portable header, and possibly redefine PFALLTHROUG to FLATCC_FALLTHROUGH, or just use FALLTHROUGH directly in switch statements.
But I'm mostly inclided to just disable the warning.

Se also [clang] detect switch fallthrough marked by a comment (PR43465)

Linux kernel uses fallthrough; in the code, but not sure how fallthrough is defined. I suspected this would be a convention which is why I mentioned lower case in the above comment.

C17 apparently introduces [[fallthough]] syntax similar to C++17, but that will never be portable because the code must also work with older & different compilers.
https://en.cppreference.com/w/c/language/attributes/fallthrough
Also, I supect defining fallthough as a macro will not work with C17 syntax. This is unusual - normally C standards make sure you can be backwards compatible through macro definitions.
Linux note
https://mjmwired.net/kernel/Documentation/process/deprecated.rst

As there have been a long list of flaws due to missing "break" statements <https://cwe.mitre.org/data/definitions/484.html>, we no longer allow
implicit fall-through. In order to identify intentional fall-through
cases, we have adopted a pseudo-keyword macro "fallthrough" which
expands to gcc's extension __attribute__((__fallthrough__)) <https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html>.
(When the C17/C18  [[fallthrough]] syntax is more commonly supported by
C compilers, static analyzers, and IDEs, we can switch to using that syntax
for the macro pseudo-keyword.)

I think the proper action is to define fallthrough as macro along the lines of
But I am afraid that might conflict with a C17 keyword.

https://stackoverflow.com/a/60682054
I think the solution is to have PORTABLE_FALLTHROUGH similar to LLVM_FALLTHROUGH and then define FLATCC_FALLTHROUGH as PORTABLE_FALLTHROUGH where a flatcc header includes "portable/pfallthrough.h".

Or maybe it will work with fallthrough as a macro. We need to test that against C17 and C++17. That would be the cleanest solution.
You are welcome to do some research. Once we reach a conclusion I will probably write a pfallthrough.h file and put it on a branch where you can pick it up just to make sure the portable file follows convention. I'll also find a hook for its inclusion.

I'm pretty sure that the solution here is portable across C/C++ with both clang and gcc: https://godbolt.org/z/8bf34P89W

The question is if fallthrough is defined as __fallthrough__ because then defining a new falltrough could have interesting effects. Mere testing #ifndef fallthrough won't work then because semantics are different.

It is not, it is defined as __attribute__((__fallthrough__)): https://github.com/torvalds/linux/blob/master/include/linux/compiler_attributes.h#L210

No, that is just Linux source. They are doing the same thing we are trying to do - that is not authoritative, but a reason to use #ifndef. The question is what C17 and C++17 do, and possibly other compilers. I quick check on godbolt suggests it is not a problem to define fallthrough and also that it isn't defined already, but who knows what stdlib header might do that?

The fallthrough that you are referring to IS a Linux extension.  The C2x PoR is to use the C++ style [[fallthrough]] which will be compatible with C++ (the attribute is not required to be namespaced).  [[fallthrough]], [[gnu::fallthrough]], [[clang::fallthrough]] are all interchangeable with C++11.  C2x will adopt the same spelling as per WG14.

C11 does a lot of macro definitions so you cannot conclude fallthrough is freely available along that line of reasoning, although it appears to be. For example alignas is widely used in flatcc and emulated in the portable library. It is a C11 macro.
Also, I'm not arguing that it isn't a Linux extension, on the contrary. But is still a compatibility patch.
BTW: I wonder if there should be a pattributes.h instead of pfallthrough.h in portable. That would allow for adding other common attributes similar to the Linux file you found.

C11 does a lot of macro definitions so you cannot conclude fallthrough is freely available along that line of reasoning, although it appears to be. For example alignas is widely used in flatcc and emulated in the portable library. It is a C11 macro.

C2X draft §<IP_ADDRESS>p1 states that fallthrough shall not be treated as a token literal outside of the attribute declarator.

That is useful info, although it still doesn't preclude fallthrough being defined as a macro in some library header.
So I think we should define a portable/pattributes.h file inspired by Linux and LLVM definitions. I'll whip something up and get back to you.

BTW: I wonder if there should be a pattributes.h instead of pfallthrough.h in portable. That would allow for adding other common attributes similar to the Linux file you found.

That is probably a good idea.  fallthrough is just one of the interesting attributes introduced in C2x.  There is also [[deprecated]] (aka __attribute__((__deprecated__(...)))) as well as [[nodiscard]] (aka __attribute__((__warn_unused_result__)).

I just read you edit: I agree I don't think it is a concern, I am just not sure. It is kind of annoying they didn't handle this the same as alignas, but I can see that they wanted to avoid attributes being sprinkled around without [[ ]] markers. But unfornately that makes it totally not portable leaving it for random users like us and Linux library developers to come up with suitable conventions.

In the case of alignas it was for compatibility with C++ - C++ used the alignas expression, C used the compatible _Alignas keyword.  The stdalign.h extension allowed it to be compatible across C/C++.  This time, they did the compatibility by adding [[...]] attribute spellings.

I have now added
https://github.com/dvidelabs/flatcc/blob/attributes/include/flatcc/portable/pattributes.h
to the attributes branch.
The file is included here:
https://github.com/dvidelabs/flatcc/blob/8bdaefa84f999d82d9b0ce61b716b1a356423ce6/include/flatcc/flatcc_flatbuffers.h#L26-L27
I also fixed pprintint.h in the portable library.
The changes to config.h should not be necessary.
I patched up luthor.c with a goto statement to avoid introducing a dependency on the portable library.
I think you should be able to just use fallthrough; in the remaining source.

I'm not sure how to update the other instances.  If you were to merge that change to main, I can rebase this change and update it.

I can merge to master, but please test on the branch first, notably make sure it is running on Linux if you can.
Unfortunately Travis has stopped working, and I don't have your problem on my system.
Also please verify that you have what you need aside from trival fallthrough; changes. I.e. that you don't need to include anything extra. I did test one case briefly.

@mikkelfj seems that I do need to include flatcc/portable/pattributes.h in a few different instances.  This PR includes the contents of the attributes branch and the change needed on top to build on Linux.

Yeah, I think that is reasonable. This is in the compiler. It could make sense to put it in config.h but I think it is better is you have done. Only, I suggest you add a /* fallthrough */ comment on the include line of pattributes.
I'll merge my changes to master so I get clean commits on the differ source code areas.

BTW: do you have any suggestions to the pattributes.h file. I kind of like how it turned out without having to test for a lot of compiler versions, but I might have missed something.

attributes branch has been merged

I think that its pretty good for a starting point.  It covers the major compilers (gcc, clang, MSVC).  With the recent changes, ARMCC/DS and xlC/xlClang should also be covered by the existing file.  The one other larger compiler which may be interesting for comparison would be GHC, but I don't know enough about that one to speculate.

OK thanks. GHC? Great Hadron Collider, or Glasgow Haskell Compiler?
Latest commit looks fine. Ready to merge?

GHC is the Green Hills Software C compiler.  But, I'll take the other two expansions as well :-p.  Yes, I believe this is ready to merge.

Thanks

FYI:
I updated pattributes.h such that names like fallthrough can be optionally namespaced using pattribute(fallthrough)
https://github.com/dvidelabs/flatcc/commit/f06da091109d19296ff603e0f91bf9c7eb23e983

The change did not handle already defined names correctly. Fixed. Also, this makes it possible to use the portable attribute even if the name is used for something else by using pattribute(<attribute>).
https://github.com/dvidelabs/flatcc/commit/c6c2064ec1f1eb8e9734c7d3a1105fa6102eba9a
And here a link the latest version of the full file for reference
https://github.com/dvidelabs/flatcc/blob/master/include/flatcc/portable/pattributes.h


Typo in TestTask.groovy

Hello,
There is a typo in the soapui-gradle-plugin. In src/main/groovy/io/byteshifter/plugins/soapui/tasks/TestTask.groovy, line 219, projectProperties() should be getProjectProperties().
This causes the setting of the projectProperties key in the soapui -> test closure to throw a NullPointerException.
The fork at [https://github.com/creising/soapui-gradle-plugin] is also affected.

Hi @80586 ,
Thanks for highlighting this. I will look to fix this soon. If in the meantime you would like to make a pull request I will be happy to merge that in.

This should fix your immediate problem, but this has highlighted concerns elsewhere in the plugin.


last_sell_price not updated when changing currency

I first tried the bot without real trading using the default BTC/USD config.
After that (3 days) I changed to BTC/EUR and filled the GDAX api info, in an accocunt with just Bitcoins. Looking at the logs I noticed that three sells failed due to low performance. It made no sense and looked a the code, and discovered that last_sell_price was the USD price, which was higher than the euro, and thus the low score.
I run dropped the entire run_states collection and that solved it,  but this could be really misleading for people without coding knowledge.
I hope this helps, thanks for the amazing work!

Every pair should be treated separately, you can't simply test your config on one pair and run it on the other, it will not be as effective/profitable. You should always run simulation of the pair you are going to trade prior to bringing it live to make sure your config is good.

Thank you egorbenko, maybe I did not explain propely, but what I was trying to say is that if somebody tries zenbot in one currency, and then on the other, that variable takes the value of the first one until a buy AND a sell is done, which can make the bot not take any action. Unless I am missing something else that I should have changed in the EUR config file.


gRPC Python test infrastructure

@griffithjames please also review; GitHub being GitHub won't at the moment let me add you to the reviewers. :-\
I believe I've addressed everything (in the timing-related parts of the test infrastructure) from the last round of review.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Seriously, GitHub?

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

@kpayson64, @mehrdada, @griffithjames: who wants to click the approve button on this?

LGTM but I'd like kpayson@ to chime in as well.
On Jul 25, 2017 10:56 AM, "Nathaniel Manista"<EMAIL_ADDRESS>wrote:

@kpayson64 https://github.com/kpayson64, @mehrdada
https://github.com/mehrdada, @griffithjames
https://github.com/griffithjames: who wants to click the approve button
on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/11901#issuecomment-317816899, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA29O4CLLWfmDHdQkhrpNllWClGOpEz4ks5sRiwvgaJpZM4Oe6uD
.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Fix crash in GCP iam binding middleware

Q
A

🐛 Bug fix?
yes

🚀 New feature?
no

⚠ Deprecations?
no

❌ BC Break
no

🔗 Related issues
#1311

❓ Documentation
no

Description
Fix a weakness in the GCP IAM binding transformer

Codecov Report

Merging #1312 (1ece665) into main (4e4f13d) will increase coverage by 11.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1312       +/-   ##
===========================================
+ Coverage   70.17%   81.95%   +11.78%
===========================================
  Files         469      398       -71
  Lines       17412    14416     -2996
===========================================
- Hits        12218    11814      -404
+ Misses       4874     2309     -2565
+ Partials      320      293       -27

Impacted Files
Coverage Δ

pkg/middlewares/google_iam_binding_transformer.go
100.00% <100.00%> (ø)

pkg/terraform/plugin_client.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/remote/google/init.go
0.00% <0.00%> (-77.78%)
:arrow_down:

pkg/remote/google/repository/storage.go
0.00% <0.00%> (-76.93%)
:arrow_down:

...g/remote/google/repository/cloudresourcemanager.go
0.00% <0.00%> (-76.93%)
:arrow_down:

pkg/remote/github/init.go
0.00% <0.00%> (-76.32%)
:arrow_down:

pkg/remote/terraform/provider.go
6.08% <0.00%> (-65.55%)
:arrow_down:

pkg/terraform/provider_factory.go
0.00% <0.00%> (-62.50%)
:arrow_down:

pkg/resource/google/google_project_iam_member.go
46.15% <0.00%> (-53.85%)
:arrow_down:

pkg/terraform/providers.go
52.94% <0.00%> (-47.06%)
:arrow_down:

... and 84 more


Remove sort in GroupBy._reduce_for_stat_function.

Codecov Report

Merging #1147 into master will decrease coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   95.19%   93.58%   -1.62%
==========================================
  Files          35       35
  Lines        7075     7075
==========================================
- Hits         6735     6621     -114
- Misses        340      454     +114

Impacted Files
Coverage Δ

databricks/koalas/groupby.py
91.41% <ø> (-0.22%)
:arrow_down:

databricks/koalas/frame.py
96.32% <100%> (-0.56%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.32% <0%> (-72.98%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
76.59% <0%> (-8.52%)
:arrow_down:

databricks/conftest.py
92% <0%> (-6%)
:arrow_down:

databricks/koalas/generic.py
95.76% <0%> (-0.43%)
:arrow_down:

databricks/koalas/indexes.py
96.09% <0%> (-0.36%)
:arrow_down:

databricks/koalas/plot.py
94.04% <0%> (-0.24%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b569f...ac1f17b. Read the comment docs.


graphite parser: apply tags from the Parser on the template

follow-up to #4348, fix tag parsing behavior

Yes, this should do as the PR title says. +1.


fix bz1215107. Use the lbr gateway as the tun device address.

@mrunalp Review please.
I created a new cluster and all the service stuff works. If this bugs comes back clean, we should be ready to merge. https://bugzilla.redhat.com/show_bug.cgi?id=1215107

sure

LGTM


How to handle components in components

Currently we have instances where we include a component in a component (.pf-c-button in .pf-c-chip, for example) and instances where we could have a component in a component (.pf-c-button in .pf-c-dropdown). And things like the .pf-c-button in .pf-c-popover that is wrapped in .pf-c-popover__close - is that wrapper necessary?
We should sort out how we decide when to include components in components, what to name them, etc.

We decided on a method, and have made a few small updates as part of the refactoring work to better utilize components in components, so I think this one is OK to close out.


machine name in .netrc

.netrc in following examples lists two different names for machine. What should it be? Or, are they the same?

Step 2 lists as: machine urs.earthdata.nasa.gov
Notebook has uat. added as in: machine uat.urs.earthdata.nasa.gov

Thanks!

Thanks for your issue! you will more than likely use machine urs.earthdata.nasa.gov.
The machine uat.urs.earthdata.nasa.gov entry is for non-operational products and products in our 'test' environment. We originally wrote tutorials against ht eUAT environment because we were in the middle of our transition to the cloud and wanted to build out tutorials that worked. Now that much of PO.DAAC data is in our production cloud instance, we should go back and update those to non-UAT environments.

i've added this as an issue in the tutorials repo (https://github.com/podaac/tutorials/issues/45) so i'll close this out in favor of fixing it there.


Another missing import and instantiation

Describe what this patch does to fix the issue.
Missing another Flask module import and app variable instatiation
Link to any relevant issues or pull requests.

Thanks, but I'm going to close this. I'm sure there's been discussions on this tracker previously about this, but I deliberately don't add boilerplate that's already been shown earlier in the doc because it just gets noisy and is not relevant to the specific thing being shown.


Proposal: Ability not to auto-close comments

As far as I can tell this is not currently available.
Oftentimes I need to comment out blocks of code and use /** and immediately a */ auto inserted resulting in one extra step.  Not a huge deal by any means, but it would be a nice added feature to be able to turn off auto-closures on comments. Or maybe even in the configs an array of chars not to close? If nobody else feels this way though, probably not worth the effort. I suppose I am looking for input on this feature.

We currently have editor.autoClosingBrackets but this does take care of the comments

@variab1e When commenting out blocks of code, I personally always choose // via Ctrl+/. The reason I do it is that // can comment out block comments and it is cumulative:
	// /**
	//  * Returns the column for the text found at a specific offset inside a rendered dom node
	//  */
	// getColumnOfNodeOffset(lineNumber:number, spanNode:HTMLElement, offset:number): number;

	// // /**
	// //  * Let the line know that decorations might have changed
	// //  */
	// // onModelDecorationsChanged(): void;

I am not sure why you choose to comment block of codes with /**. Why not use /* ?

I think this is annoying behaviour too

Me too. Doesn't seem too hard to fix.

Yup, I am also not thrilled with this would like a way to switch it off.

@alexandrudima You asked why someone would do that?
This came up for me recently as I was trying to find some problematic code. Basically doing bisection search commenting things out. I started by commenting out a huge region of code and then incrementally moving the start of the commented region down the file, but the auto inserted characters were a nuisance.
Definitely a +1 from me on making this configurable.

For me, this behaviour does more harm than good and is pretty annoying.

Any news on this? It's really annoying

I see I'm not the only one checking this thread more than three years after it was opened. Any updates on this, MS? Should just be a simple "set this property to false" to not add the extra "*/"...

Adding my voice also here. Incredibly annoying that this cannot be disabled alone.

Aghghghg this is the worst

Try this:
Open the extensions directory
(\Microsoft VS Code\resources\app\extensions)
There open your languaje directory
(C# for example, \csharp)
Edit the language configuration file
(language-configuration.json)
From "autoClosingPairs" group delete the line for the comments:
{ "open": "/*", "close": " */", "notIn": ["string"] }
Save the file. It's worling for me.

 This solution works!

@FereBlanco or anyone else - any idea where this can be found in linux?
I looked in ~/.vscode/extensions but it's not there.

Any news ?
OK we have a good workaround, OK VSCode is entirely free and dudes are making an amazing job, but come on, this kind of details is the very basics of a programmer's like, it shouldn't have to be a hack to tweak this thing :)

@FereBlanco and others - There is one flaw in the workaround, which should be addresses at the same time as the original issue.
When typing /*, all folded code below becomes unfolded... what a nuisance!
What I do, when I remember to, is to first type */ below the code I want to comment, and then type /* above that code block. Then the folding doesn't change.
Has anyone found a workaround for this?

Unless I'm missing something, the behavior introduced in #73841 can not be undone via configuration.
This is something I find very annoying and rather important to be addressed: this kind of automation is really in a way.
Spent some time this evening getting project compiled and hacked it a little bit. Ended up with this WIP code. It's a so called seems-to-work-for-me state of change. Close to be a proof-of-concept.
Would really be cool if such option is implemented in an official VS Code. I don't mind spending time on wrapping it up, but need input from more experienced VS Code developer about overall design and approach. Not sure if pull-request will be a way to go about it?

I find this behavior quite annoying too, especially because it currently seems to break automatic generation of doxygen comments via extensions.

@HDHarry, if it breaks functionality, is probably better to submit a bug report. Such things are very easy to get lost between cracks in the feature-request type of an issue.
At the meantime cleaned up the branch a bit and created #75053.

Thanks for the hint! I do not have time right now to take care of it, but will do so later.

Could somebody just fix this already please? It is extremely annoying, having to type "/*" with the key sequence [/ * DEL DEL DEL].
Also, for the future I would recommend implementing the rule that all newly added auto-closing features need to ...

be disable-able by configuration.
be disabled by default.

After all, in software engineering projects, adding new features that change the behavior in a way that requires adaption from the user (as is clearly the case here) should be avoided if possible and should only happen during mayor releases.

+1, completely agree with all comments here. Clearly this only covers some use cases and breaks others. At least this should be configurable without having to manually edit the language configuration file. As others, I would be very happy if it was disabled by default.

Seems to have been fixed in the latest release (1.37.1).

@MulattoKid Please tell us which config option has been added for this. I looked and found nothing.

@MulattoKid Please tell us which config option has been added for this. I looked and found nothing.

So I recently did a fresh VSCode install on Ubuntu 18.04.02. At the time (August 1st), update 1.36.1 was the most recent one. I then immediately updated my settings.json file to be:
{
    "workbench.colorTheme": "Visual Studio Light",
    "editor.autoClosingBrackets": "never",
    "editor.autoClosingQuotes": "never",
    "editor.autoIndent": false,
    "editor.acceptSuggestionOnCommitCharacter": false,
    "editor.acceptSuggestionOnEnter": "off",
    "editor.snippetSuggestions": "none",
    "editor.suggest.filterGraceful": false,
    "files.maxMemoryForLargeFilesMB": 8192,
    "editor.wordBasedSuggestions": false
}

I quickly noticed that upon entering /* in C++ files, the comment was closed on the same line with */ (which I had never experienced before - I had an old version before the fresh install).
Then, without changing the settings.json file, I downloaded the newest update, 1.37.1, and the problem disappeared. That's why I thought it had been fixed, but maybe I'm wrong...?

The issue itself seems to be present (at least for PHP, see below) even in Version 1.78.2, Commit b3e4e68a0bc097f0ae7907b217c1119af9e03435, installed under Linux, Ubuntu as Snap package with the --classic option.

Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:47:05.613Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.2.0-20-generic snap
Sandboxed: Yes

The solution, provided by @FereBlanco is not applyable for me; Due to the Snap installation, that File (in my case /snap/code/current/usr/share/code/resources/app/extensions/php/language-configuration.json which resolves to /snap/code/129/usr/share/code/resources/app/extensions/php/language-configuration.json) is on a read-only; since it is provided by the snap package:

From "autoClosingPairs" group delete the line for the comments:
{ "open": "/*", "close": " */", "notIn": ["string"] }

So I applied the configuration, suggested by @isidorn and added the following to my User's settings.json:
{
	...
	"[php]": {
		...
		"editor.autoClosingBrackets": "never"
	}
	...
}

Though this not only disables the autocompletion of /**, but also of every Bracket, I type. This behavior fits its name, though it disables way more, than I intended to disable.
I will keep this enabled, since I usually type closing brackets, anyway.

@alexdima I can't speak for @variable, but I can explain, how and why this affects me:
I am used to write comments (explaining, why some code exists) using /**/ comments, so they are clearly distinguishable from code, being commented out (by using //).
When doing this, I go used to write /**/ first and then insert the actual text. This way, writing the comment does not mess up the existing Code, alongside its Syntax-Highlighting, which again prevents the IDE (this is not limited to VSC, but applies to all IDEs) from complaining about Syntax errors, just because I am typing a comment (which I did not close yet).
So whenever I intend to type [/ * * /], after typing [/ * *] the "closing sequence" [space * /] is inserted and I end up with [/ * * / space * /], which actually does break my code.
Then again, the current autoClosingPair (in PHP, though) would produce a /** */ comment, which is not, what I want.

Here are some things, I would like to note:

I abstain from modifying installation files, as the modifications would be lost with the next update.
The language-configuration.json for csharp does not contain the autoClosingPairs in question ({ "open": "/*", "close": " */", "notIn": ["string"] }) any more (at least not in my installation).
The language-configuration.json for php however does contain the following autoClosingPairs: { "open": "/**", "close": " */", "notIn": [ "string" ] }
Other languages (C++ got mentioned, as well) may or may not be affected by this, at time of writing.

Would it be possible to add an option to ignore or disable pre-defined autoClosingPairs for a language (or for all languages)?
This would make it easier to disable a specific autoClosingPair, opposed to having this-many Flags to disable this or that.
E.g. (suggestion)
{
	"[php]": {
		"editor.ignoredAutoClosingPairs": [
		    "/*",
		    "/**",
		]
	}
}

It is now 2023, and this annoying bug is still present.
None of the solutions listed above works to fix this.

@alexdima this works, I didn't understand how to trigger beforeWhitespace though


added @brightway-lca documentation to example gallery

Thank you for the quick response - I will update the PR once our API documentation has been updated and our 'legacy' documentation is offline in favour of the new pydata-sphinx page.


Resynchronise pkgs/dmd with Nixpkgs dmd.

An year ago or so, the generic.nix and binary.nix in OldDDerivations were basically the same as in Nixpkgs. It was easy to upstream and downstream any improvements, Nixpkgs only lacking the version-specific hash files.
If possible, I would like to reintroduce this synergy. Obviously this does depend on reaching agreement with other Nixpkgs maintainers (I'm one of the dmd maintainers there though so I should have some power). However, I think we should first get DMD versions from 2.084.1 (oldest in OldDDerivations) to the latest stable working first, otherwise people in Nixpkgs don't have much reason to accept any changes from here.

There's currently an open PR for nixpkgs#dmd (https://github.com/NixOS/nixpkgs/pull/111525) that slims down the package, would be nice if this could get added here if needed. I haven't been able to try this repo's dmd package yet, since dmd is x86 exclusive.

Agreed.


com.google.fonts/check/name/familyname failing on family name with camelcase

I am getting this fail from fontbakery because it looks like fontbakery made a family name with spaces by adding a space before every upper case letter but my name ID 1 is meant to be in camelcase:

🔥 FAIL: Check name table: FONT_FAMILY_NAME entries.

com.google.fonts/check/name/familyname

--- Rationale ---

Checks that the family name infered from the font filename matches the string
at nameID 1 (NAMEID_FONT_FAMILY_NAME) if it conforms to RIBBI and otherwise
checks that nameID 1 is the family name + the style name.

🔥 FAIL Entry [FONT_FAMILY_NAME(1):WINDOWS(3)] on the "name" table: Expected "Georama X Cn" but got "GeoramaXCn". [code: mismatch]

These are the name tables:
ID 1 FONT_FAMILY_NAME: BananasXCn
ID 2 FONT_SUBFAMILY_NAME: Regular
ID 4 FULL_FONT_NAME: BananasXCn Regular
ID 6 POSTSCRIPT_NAME: BananasExtraCondensed-Regular
ID 16 TYPOGRAPHIC_FAMILY_NAME: Bananas ExtraCondensed
And the filename is: BananasXCn-Regular.ttf
ID 1 and ID 4 are shortened in this way across the family to meet the 27 character maximum elsewhere in the family. Wouldn't this issue come up anytime there's a font family name which has camelcase?

In general we currently avoid camel case family names. We might add special cases for those, but that would require hard-coding such exceptions in fontbakery itself, which is probably a very bad solution.
Also, I think "XCn" to represent "Extra Condensed" is extremely non-intuitive for the font users.

This issue seems related to #2448, so I suggest we close it now and weigh in that other issue.


Is it possible to crop a image with its full width?

I have a image with {width: 500, height: 1000}. i want to crop the image to like {width: 500, height: 500}.
But my device's width is only 420, then i can't get the full width of the image as my device can not show the full image.

nvm, i just found the problem

Hi @alvazzlau! Glad you found a solution to the problem. If you have time, can you describe a solution to the problem here? Maybe it will be useful to someone. Thank!

Is it possible to do this?


[AzureMonitorExporter] added metrics example to demo and test

While working on the documentation, I made sure we had the same examples in our Demo and Tests.
Changes

Added Histogram to Demo
Added Gauge to Demo
Added Gauge to Tests
refactored TelemetryItemValidationHelper for metrics.

API change check
API changes are not detected in this pull request.


table file is about 10m starting keys 0x1

i just see your working code, its difrent from my invented 8 month old code , where i load in same ram 10x mean 100m keys and my logics, thats will work more 10 time faster then these codes, discus here or in discord group, ?

Yes a bigger bP table means more speed, theoretically the increment of the size of the bP table is lineal with the increment in the speed, but in practice sometimes this is not true at all, more points in memory means a bigger space in memory to access, more false positives in the Bloom filter or hashtable used, and in my case more binary searchs, depending of the size the increment in the speed can be only from 70% to 90% of the increment in bP table size

let me explain you, you compare full pubkey 66 in generated and minus to real pubkey for result , if you take first 12 char of pub in table, and compare, by this way same size of file, and same memory will work, just when compare hit first 12 char then generate full key for final compare, by this way you will pass 100m keys,m not 10m keys, tested these way before 8 months on cpu, yes if you build these on GPU, maybe much better

Closing it as we discussed and already tested.


Improved documentation Makefile

Summary
The documentation Makefile failed to activate its own virtualenv for many of the commands it
provides.
Proposed changes in this pull request

Prepended ". $(VENV);" to lines that invoke sphinx-build

[ci only docs]

Coverage remained the same at 82.688% when pulling f087fd93535f9478400a00695d53dad09c698add on evildmp:improve-docs-makefile into d90102f61014e822fc863dbf0eb9e82bf6e02898 on divio:release/3.4.x.


ScrollArea overflows

I'm trying to make the content of a Card scrollable; the content of the Card will consist of multiple Cards displayed using a .map. I want the page to have no scroll, so from the first container, I'm using h-full and different h-1/6, h-5/6, etc. In the case of CardContent, where I want to make it scrollable, I have set h-5/6, and it works until I start adding Cards to the list of content Cards, which makes it a bit larger and creates a scroll on the page:
'use client'
import { Button } from '@/components/ui/button';
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
import { Input } from '@/components/ui/input';
import { ScrollArea } from '@/components/ui/scroll-area';
import { Textarea } from '@/components/ui/textarea';
import { useState } from 'react';

interface OTabParams {
}

interface data {
  oPhysicalExamTitle: string
  oPhysicalExamText: string
  oPhysicalExamFiles: string
}

export default function OTab({}: OTabParams) {
  const [cards, setCards] = useState<data[]>([])

  function addPhysicalExamHandler() {
    const card = {oPhysicalExamTitle: "Titulo", oPhysicalExamText: "text", oPhysicalExamFiles: "file"}
    setCards([card, ...cards])
  }
  return (

        <Card className="w-full lg:w-3/4 h-full">
          <CardHeader className='h-1/6 w-full flex flex-row justify-between items-center'>
            <CardTitle>Physical exam</CardTitle>
            <Button onClick={addPhysicalExamHandler}>+</Button>
          </CardHeader>
          <CardContent className='m-2 h-5/6'>
            <ScrollArea className='h-full'>

                {cards.map((card, index) => (
                  <Card key={index} className='w-full h-40'>
                  </Card>
                ))}

            </ScrollArea>
          </CardContent>
        </Card>
        <Card className="w-full lg:w-1/4 h-full">
          <CardHeader><CardTitle>Vitals</CardTitle></CardHeader>
          <CardContent>Contenido</CardContent>
        </Card>

      <Card className="w-full h-1/4">
        <CardHeader><CardTitle>Notes</CardTitle></CardHeader>
          <CardContent>Contenido</CardContent>
      </Card>

  )
}

When it's empty it works great:

But when I add cards it doesn`t:

I have this issue too

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


My Account Page - Upload Avatar - Dependent on #459

Web Path
Home Page -> John Doe -> My Account -> Upload

Requirement
When user click Upload, user is able to choose a local file.
You task is to save this file to database using Rest API.

Rest API
Endpoint: POST /api/user/{userId}/uploadAvartar
Documentation: Call the Rest API on http://localhost:8080/swagger-ui.html

Test the Rest API
Here is how you test the uploadAvartar endpoint: ( You need to have backend running)

Go to: https://www.base64encode.org/
Upload an image file, and get the base64 string
Go to http://localhost:8080/swagger-ui.html, Rest API /api/user/{userId}/uploadAvartar
Provide the input parameters, with File content in base64 format
Click Try out
Check the file is uploaded to : \C4SG\C4SGSvc\avartars
If you have question on this Rest Endpoint, you could talk to the developer: nightcapybara on Slack

Note
This task is dependent on task #459. Hold off until #459 is done.

This issue was moved to Code4SocialGood/c4sg-web#12


JS: Introduce JavaScript's usage in the Command-Line

Introduce JavaScript's usage in the Command-Line
Discuss the growing use of JavaScript in the command-line,
for front-end web development using frameworks, back-end
web development using servers and API libraries, and desktop and/or
mobile application development.
Directory
Topics/4.Command_Line

Description

Talk about standalone JavaScript scripts that run in the command-line.
Can we use Node.js and NPM for front-end development?
Can we use Bootstrap, et cetera, via NPM?
What frameworks can be used with Node.js to ease front-end development?
What popular back-end API frameworks do we have in Node.js?
Discuss the domination of Electron as the most popular hybrid desktop application
development framework of the times.
Discuss React Native and Ionic as hybrid/near-native mobile application development
frameworks in JavaScript.

Hints

Check out the about page of Node.js.

Formats

[x] Document
[ ] Video
[ ] Audio

Hey I want to work on this!!

@paramsiddharth sir I want to work on this

Sir, if possible assign these to me too.

Sir, I will go for the documentation for this.  Thus, specified. Thank you for the assignment.

I am a GWOC'21 contributor from Batch 3 of JavaScript. Please assign this issue to me. I assure you that this issue's title will be the same as my PR's title as well as I will be Contributing under the Guidelines and Code of Conduct.
Discord : agarwalSakshi | Contributor#9567

I am a Gwoc contributor from batch 16 which include front-end with JavaScript.Kindly provide me this domain for contribution.

I am a Gwoc contributor from batch 16 which include front-end with JavaScript.Kindly provide me this domain for contribution.

@Divyanshigarg Please make sure you are allowed to contribute to the JavaScript domain. There's often a clash between us and FEWD. Cheers!

@paramsiddharth Sir, raised a PR for this issue.

@paramsiddharth Sir plz close the issue, since it has already been merged, Thank you

@paramsiddharth Sir, please it is a request to do the needful to close the issue. Thank you.

@TishaJhabak1014 No, I won't close the issue yet. As the workflow for us has been, this same issue will be reopened and reused for the other formats.

@paramsiddharth sir, okay I got it. Actually, I guess, this issue is counted as open and even I am not working on 3 open issues, the bot prompts 3 issue at a time is exhausted for me. Thus, I cannot work on rest domains.

@paramsiddharth sir, okay I got it. Actually, I guess, this issue is counted as open and even I am not working on 3 open issues, the bot prompts 3 issue at a time is exhausted for me. Thus, I cannot work on rest domains.

In such a situation, you can just unassign yourself from an issue that you are done working on. :)

Thank you sir : )


How to convert HTML to an NSMutableAttributedString

I have tried but not able to render whole attributed string with html tag. is it any way to apply HTML string as well?

I made a new parser that is based on pure String Regexr, feel free the check my works :)
https://github.com/ZhgChgLi/ZMarkupParser


Play and phantom version bump

Hi,
Upgraded phantom and play. The only weird issue was a compatibility issue between Scalaz and Specs. Hope it helps others.
Regards

@alexflav23 Resolved the conflicts after your latest push but not sure what I can do about this travis error "No Rakefile found". Is there anything I should do? Have never used Rake.

Hi @meddulla,
I've updated this project independently to the latest version, it was missing a travis conflict which was added on develop, I'll either merge this or close it if it's no longer necessary, but thank you very much for your contribution, I basically fixed the conflicts manually by branching from your work.
Regards.

Hi @alexflav23,
The main difference is Play's update from 2.3.9 to 2.5.10. There the most notable issue is the test code, where instead of
val nonExistent = route(FakeRequest(GET, "/boum")).get // deprecated in 2.5.
we now do
val nonExistent = route(app, FakeRequest(GET, "/boum")).get
It's not that important, the most important was the phantom update so I'm fine with you closing this.
Thanks for building Phantom :)

Hi @meddulla, Thank you for pointing that out, I will make sure to include it in the final merged PR.


monitoring: enhance the demo with more telemetries

this is the demo config file https://github.com/opiproject/otel/blob/main/config/telegraf-spdk.conf
we can add

https://github.com/influxdata/telegraf/tree/master/plugins/inputs/gnmi
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/bond
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/cpu
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/disk
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dns_query
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/docker
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dpdk
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/ethtool
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/interrupts
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/iptables
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/kernel
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/mem
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/netstat
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nfsclient
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nginx
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/sensors
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/snmp
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/syslog

also check new eBPF https://www.splunk.com/en_us/blog/devops/announcing-the-donation-of-the-opentelemetry-ebpf-collector.html

Hey @glimchb , is this issue available for the LFX mentorship session Jul-Dec ?

Hey @glimchb , is this issue available for the LFX mentorship session Jul-Dec ?

yes

Hey @glimchb , I'm interested in working with this project under LFX, I'm familiar with Go, but rest of things are little new to me.

Could you suggest me a way to approach this project or any topics I should get familiar with first.
Are there any pre-task related to the selection process ?

Hey @glimchb , I'm interested in working with this project under LFX, I'm familiar with Go, but rest of things are little new to me.

Could you suggest me a way to approach this project or any topics I should get familiar with first.
Are there any pre-task related to the selection process ?

start by running the repo docker compose and explore all metrics and all containers that are up and running

Hello @glimchb. I was trying to apply for the LFX mentorship and was trying to attach my Resume and cover letter, but the website seems to be broken. Do you want me to email them to you? Sorry for asking here I wasn't sure where else to ask.

this is the demo config file https://github.com/opiproject/otel/blob/main/config/telegraf-spdk.conf
we can add

https://github.com/influxdata/telegraf/tree/master/plugins/inputs/gnmi
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/bond
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/cpu
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/disk
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dns_query
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/docker
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dpdk
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/ethtool
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/interrupts
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/iptables
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/kernel
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/mem
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/netstat
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nfsclient
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nginx
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/sensors
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/snmp
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/syslog

also check new eBPF https://www.splunk.com/en_us/blog/devops/announcing-the-donation-of-the-opentelemetry-ebpf-collector.html

Hi @glimchb , I was exploring all the metrics by running docker in my local machine and tried to tackle this issue, the thing is when I click the above demo config file above i.e, https://github.com/opiproject/otel/blob/main/config/telegraf-spdk.conf its showing file not found.

Hi @glimchb , I was exploring all the metrics by running docker in my local machine and tried to tackle this issue, the thing is when I click the above demo config file above i.e, https://github.com/opiproject/otel/blob/main/config/telegraf-spdk.conf its showing file not found.

I fixed the link above

Hi @glimchb , I was exploring all the metrics by running docker in my local machine and tried to tackle this issue, the thing is when I click the above demo config file above i.e, https://github.com/opiproject/otel/blob/main/config/telegraf-spdk.conf its showing file not found.

I fixed the link above to https://github.com/opiproject/otel/blob/main/config/telegraf.conf

Oh ok, I'll work on it.

@glimchb i'm currently working on the https://github.com/influxdata/telegraf/tree/master/plugins/inputs/docker

I am working on syslog

@glimchb I am facing some issue in syslog. probably I am missing something in configuration, will figure it out by tomorrow probably. I have added few more telemetry

@glimchb let's change the desc with this it would be super easy to keep track of what is done and what is not.
- [ ] [gnmi](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/gnmi)
- [ ] [bond](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/bond)
- [ ] [cpu](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/cpu)
- [ ] [disk](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/disk)
- [ ] [dns_query](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dns_query)
- [ ] [docker](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/docker)
- [ ] [dpdk](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/dpdk)
- [ ] [ethtool](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/ethtool)
- [ ] [interrupts](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/interrupts)
- [ ] [iptables](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/iptables)
- [ ] [kernel](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/kernel)
- [ ] [mem](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/mem)
- [ ] [netstat](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/netstat)
- [ ] [nfsclient](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nfsclient)
- [ ] [nginx](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/nginx)
- [ ] [sensors](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/sensors)
- [ ] [snmp](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/snmp)
- [ ] [syslog](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/syslog)

@glimchb let's change the issue description with this it would be super easy to keep track of what is done and what is not.

done

@glimchb, can you please put the check mark in the issue description for the plugin which are completed.
Cpu, disk, dns_query, ethtool, kernel, mem, netstat, nginx,

@Kevin222004 done

while this exercise of adding more plugins is nice, we should pause for a bit.

as you noticed, this repo is CI and not running on real HW
while updating plugins, we are not building or enhancing any grafana dashboards to have meaningful representation

please take a look https://github.com/opiproject/lab/tree/main/telegraf.d
this is running on real hardware we have in OPI lab
it also has dashboards
I was migrating slowly all plugins from this repo to lab repo
while testing real hardware setup
and adding grafana dashboards


Stage Question

What is your question?
Is it possible to change the stage mid-song (with lua)? If so/yes, then how?

this might be similar to those others asking for a stage change event, "ShadowMario has ALREADY stated he wont do it*, but you can use setProperty("spr.visible", true)

https://github.com/ShadowMario/FNF-PsychEngine/issues/1753


DPL-505 Bioscan OKR: Lysate and Library prep pipelines

Description
Discuss the process flow with R&D and determine the steps requiring tracking for both Lysate prep and Library prep pipelines. Discuss and document purpose requirements and any other details like bed verifications, QC steps and export files required [see process diagram v2 that Scott T can supply]. Also consider the split at the end of Lysate prep where samples may also go down an alternate ANOSPP pipeline route.
Aim is to collect enough information to build an MVP version of the pipelines and have a clear understanding of where any non-standard complexity lies that may generate further development stories.
Who the primary contacts are for this work
Naomi P
Scott T
Knowledge or Stake holders
Emma B
Andrew S
Additional context or information
See summary diagram here: https://lucid.app/lucidchart/b21a6020-df09-4be1-af69-26403ed467a1/edit?viewport_loc=1647%2C48%2C1511%2C835%2C0_0&invitationId=inv_44a43cc4-479b-4e19-924c-2a0182f4255c#
This diagram has the currently understood basic process flow.
What is not clear is where the split would happen (ANOSPP may need a different positive control than is used for Bioscan),  how many steps there are before the non-destructive robot extraction, whether we need any custom labware creators, and details like library type, purpose names, submission template details, where the sample summary export file needs to be available, and whether there are XP and Norm tubes at the end. There may also be outstanding questions on the above diagram that need answers.
See R&Ds process flow PDF

From mtg 6th Oct:
Action for R&D - need to discuss ANOSPP pipeline requirements especially regarding positive controls before we can finalise the requirements here.

Mtg 8th Nov clarified pipeline requirements.


Adding 'GetGradientColors()' and 'GetGradientColorsHexCodes()' to ColorUtils

Added two functions that return lists of colors representing gradient steps between two colors.
One uses IColors and returns IColors, the other accepts Hex strings and returns a list of Hex strings, for HTML usage convenience.

Hi @hfloyd
I haven't heard back from you, so I've now merged your changes, and updated your implementation to address to comments I made earlier.
As part of my testing, I noticed that the precision of the interval values were lost due to dividing two integers numbers. So I've updated the implementation so that the division is now double based instead, which improves the end results greatly.
As an example, I tested with a gradient from #fff to #000 with 100 steps (left is with integers, rights is with doubles):

The implementation using division based on doubles gets a lot closer to #000. The difference isn't however super noticeable with only 10 steps:

I had some uncommitted work for adding alpha support to the package, so I've now also updated the GetGradientColors method to support alpha levels - eg. as shown here with a gradient from #ff000000 (fully transparent) to #ff0000ff (fully opaque) - first with 100 steps:

and then with just 10 steps:

Hi @abjerner , So sorry I didn't get back to you. I had the message flagged in my inbox, but it arrived while I was in the middle of a big project, then it totally slipped my mind :-) Your improvements are awesome. Thanks so much for that!

@hfloyd no worries - I know that feeling 😉

@abjerner Do you plan to make an updated NuGet release?

@hfloyd Yes. I didn't get around to it the other day, but I plan on doing that some time this week 😉
Last release was back in 2018 as I have worked on the package a bit here and there and never got around to pushing a new release 🙃


rename wsgsmax to sfcWindmax

Hy guys,
I tried to rename wsgsmax to sfcWindmax for ERA5 test data.
See https://github.com/Ouranosinc/xclim/pull/1358
Cheers, Ludwig

Hi @ludwiglierhammer fantastic!
If you could simply remove the accompanying .md5 file and run make_check_sums.py, I think this PR will be good to merge!


Problems with convention mapping in Kotlin build script

I'm having a really hard time using the GithubPublish task (https://plugins.gradle.org/plugin/net.wooga.github) from a Kotlin build script in Gradle 5.3.1.
This seems to be a problem with the handling of convention mappings.
When I do in my Kotlin build script
tasks.githubPublish {
    onlyIf = Spec<GithubPublish> {
        println(it)
        println(it.repositoryName)
        println(it.tagName)
        println(it.releaseName)
        it.repositoryName != null
    }
    enabled = !"$version".endsWith("-SNAPSHOT")
    repositoryName = "githubRepository/Name"
    tagName = "releaseTagName"
    releaseName = "releaseTagName"
    isDraft = true
}

it outputs
task ':githubPublish'
null
1.0.7
1.0.7

and the task is not run. (The plugin itself adds such an onlyIf that fails the same, just without the printlns and just making the onlyIf true does not help, as it then fails later due to the wrong values.)
I debugged a bit and found that the task actually has the correct values set when it is evaluated.
Having a breakpoint at the first line of org.gradle.internal.extensibility.ConventionAwareHelper#getConventionValue shows that the last parameter isExplicitValue is set to false though, which cases the method to use the value from the convention mapping instead of the explicitly set values.
Changing the Kotlin code to
apply(from = "gradle/githubPublish.gradle")
tasks.githubPublish {
    onlyIf = Spec<GithubPublish> {
        println(it)
        println(it.repositoryName)
        println(it.tagName)
        println(it.releaseName)
        it.repositoryName != null
    }
}

and in the gradle/githubPublish.gradle
githubPublish {
    enabled true
    repositoryName 'githubRepository/Name'
    tagName 'releaseTagName'
    releaseName 'releaseTagName'
    draft true
}

outputs
task ':githubPublish'
githubRepository/Name
releaseTagName
releaseTagName

and the breakpoint shows that now isExplicitValue is set to true.
So it seems that when setting a property from Kotlin, there is some flag or whatever not set, that makes the convention mapping mechanism use the explicit value.

Seems to be a regression from 5.2 on according to https://github.com/wooga/atlas-github/issues/28

And actually I missed the setter methods the plugin provides like repositoryName("githubRepository/Name").
With those it works fine.

This works properly again without work-arounds, tested with 6.6.1


Dragging external wrapped object to sortable tree

I am trying to wrap my own object into drag resource so that i can drag that external object to sortable tree directly with preview. I am currently having an issue that if i specify a dndtype as prop to sortable tree, once i drag the external object over to the tree, the draggingTree state will be overwritten completely and the treeData won't get update as expected. I wonder what's the difference between dragging a node from inside the tree and outside the tree. I looked inside the source code, can't really figure that out.

@ncphillips

Can you try out

Whoops. Try out the example in the storybook linked from the readme? I have a simple implementation of external nodes there.

Have already tried it and It works really well on our side now. Thanks


feat(file upload): increase size limit for uploaded documents

Description
previously handling the uploaded pdf documents with maximum size of 0.8 mb and now the allowed limit has increased to 5 mb.
Changelog entry:
- **File Upload**:
  - increased size limit for uploaded documents to 5 mb [#866](https://github.com/eclipse-tractusx/portal-frontend/pull/1187)

Why
Files like Contract & concern, Agreements could have bigger sizes then 0.8 mb so suggested limit was 5mb.
Issue
https://github.com/eclipse-tractusx/portal-frontend/issues/1186
Checklist
Please delete options that are not relevant.

[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally

@oyo I have addressed the feedback changes. PR is ready for to get reviewed . Thanks

@evegufy  can you please review now ? I resolved merge conflict by rebasing.


Add some new operators for ZIO parity

Adds a number of new operators to close the gap with ZIO. I avoided some of the ones that seemed to make less sense for ZQuery like delay or bracket, though I was considering a runManaged since that pattern is present in a lot of the other ancillary types (e.g. Ref).
Also if there are any that I missed that you think could be part of this I'm happy to add them, since the most of the work was just copy-paste.

@paulpdaniels Thank you! Will review tomorrow.

@adamgfraser comments addressed


lock async at 1.5.2

unfortunately async v2.0 uses lodash, which adds 100-200 ms to load time from the various libs we use. might not seem like much, but it builds up.
I'll be doing this in all libs that use async until we can implement other libraries

Might worth if v2.x does the things faster than v1.x (faster than 200-300ms). Just saying that this also need check :)

perhaps but I'd be surprised. async is one of the most vetted, battle-tested libraries in node.js. But you're right, I'll look into it more. thanks

closing since this is really not an issue


feat: support array_value attribute type, closes #82

semantic_conventions/trace/http.lua is automatically generated by https://github.com/yangxikun/opentelemetry-lua/blob/main/Makefile#L36, so we should move the functions added there to a different file.

Ok, I will refactor this pr.

semantic_conventions/trace/http.lua is automatically generated by https://github.com/yangxikun/opentelemetry-lua/blob/main/Makefile#L36, so we should move the functions added there to a different file.

The specification had changed file format from yaml to markdown: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md
I think we should maintain semantic_conventions manually now.


Apps Refactor: Collapse Utilities App to Core

The bulk of the guts of the utilities app should no longer exist in v2. The primitives such as filters, forms, fields, template tags, etc., should move to core.
Ultimately, we might need to leave it around until v2.2 if we decide we want to maintain any modicum of forward-compatibility, otherwise we may just consider this entire endeavor a breaking change.

[x] Subdivide different components of utilities
[x] Lift-and-shift the code from utilities to core
[x] Correct import paths from other apps to the now core import path
[x] Create migration docs for Apps to fix imports from now missing module

Implemented by #3132 for 2.0.


[Diapers Calculator] Incorrect placement of the results of the diaper count in the container onCalculator page"

Environment: Windows 11 Home Version 22H2 Build	22621.2506
Chrome Версія 118.0.5993.118 (Official build) (64-bit).
Reproducible: always
Build found:
Preconditions
https://zero-waste-staging.onrender.com/uk is opened in browser
Steps to reproduce

Click on 'Let`s go' button

Actual result
Results of the diaper count are displayed unequally (3 icons in the first line and 1 icon in the second)
Expected result
Results of the calculation are arrandged  unevenly with 2 icons in each line.
User story and test case links
Labels to be added
"Bug", Priority ("pri: medium"), Severity ("severity: low"), Type ("UI").

![expected result diapers

Fixed


Create a special theme for mobile

Too many mobile issues that may be solved by a custom theme. Create one so that LiChess Tools and lichess features are simpler to use on mobile

This should have a higher priority. Playing interactive lessons on mobile is a drag. All the elements are in the wrong place.

Implemented in v2.1.30


Added noun-store composer package.

The noun-store package was written to allow projects to use the store functiontionality without having to pull in the entire FlexibleMink composer package. It was written initially for api.starfish.com.
I have removed the duplicate functionality from FlexibleMink and replaced it with the noun-store package.

Paging @PrinceMegahit to review the back-end work in this pull request!
Paging @joshmedeski to review the testing work in this pull request!
I couldn't recognize who these files were relevant to:
composer.json
composer.lock


Include NEXRAD imagery from other sites within envelope of given site ID and radius

If the radius is wide enough to cover other radar sites around the one specified by the site ID, the data from those sites should be included to generate a more complete image within the map.

I took a stab at this.  As far as I can tell, there's not a way to have python-awips query for a list of radar sites within a given envelope.
There is a getAvailableLocationNames() for a radar-type request, but there's not a way to filter this list based on a coordinate envelope.
I could query the METAR list, and this kind of works, but this includes other stations besides just radar, and larger radii can cause this to time out with a EOFError: EOF exception (the resulting dataset can be too big).  It helps to filter down to the past hours' worth of data, but you can still get duplicates and... it's just messy, and the wrong way to do this.
The closest I got was to basically duplicate the MapGenerator._generate_cities() method, but instead of setting the table identifier to mapdata.city, I was hoping to find another table besides .city.  According to [this list(https://unidata.github.io/awips2/appendix/maps-database/), I didn't see any table that looked like it would contain just radar sites.  There is an .airport table, which is where most WSR-88D sites are located, but I don't think every airport has one, and I don't think every radar site is at an airport.
For now, this is a "won't fix."


Error passing LocalTarget to Pandas DataFrame to_csv() method - but works with earlier version

Here is an example which creates a Luigi local target, defines an example Pandas DataFrame, and attempts to write to the local target.  Something changed so that the example doesn't work with the latest versions of Luigi and Pandas.
import luigi
import pandas as pd
df = pd.DataFrame({'a':[1,2,3]})
target = luigi.LocalTarget('example.csv')

# Works with luigi v3.0.0 and pandas 1.1.1
# Does NOT work with luigi v3.0.3 and pandas v1.2.4
#     Error message:  TypeError: write() argument must be str, not bytes
fobj = target.open('w')
df.to_csv(fobj)

# This works with both pairs of the versions above
df.to_csv(target.path)

This error normally means you should have target.open('wb') rather than just 'w'


Amplify console saying stack with id ab-websites-20190415111215 does not exist, when it does.

Describe the bug
My amplify console build is failing with an amplify-cli based project. It is saying that the stack does not exist, when it actually does. I can go into the cloudformation console and find the root stack with exactly the same id. I'm confused about how I can resolve this issue.
I'm happy to provide build logs to someone - I can send to an email.
To Reproduce
Steps to reproduce the behavior:

Commit to a project to trigger a build
Read the build logs, noticing the failure

Expected behavior
Amplify builds the project
Screenshots
The relevant lines of the build error:

The corresponding stack (which exists, and is in a valid state):

Can you check what region you are in the AMplify Console and CloudFormation? I suspect you have deployed projects in different regions.

they are deployed in us-east-1

Can you also check if the amplify project is also in us-east-1?

@steveoaustin if they are in the same region, please share your app arn. Found in General > App settings

@steveoaustin following up here: Please email your appARn to<EMAIL_ADDRESS>

@steveoaustin are you unblocked on this issue?


Diagnostic for computing horizontal averages of fluxes

We need a diagnostic to compute the horizontal average of terms like K * dT/dz which can't be done with the existing HorizontalAverage diagnostic.
I have an implementation that needs to be polished up, and may take a bit of thought if we want to integrate it with the existing diagnostics:
https://github.com/ali-ramadhan/seasonal-cycle-mixed-layers/blob/6e9834000561bdbbbcb9812e87f8dbdd876e48b0/simulation/deepening_mixed_layer.jl

I am planning to implement a diagnostics specification system (abstraction for defining kernels in terms of operations on fields) which will address this issue.

Nice!
Seems like you've already implemented some useful stuff here:
https://github.com/glwagner/ColumnModelOptimizationProject/blob/master/les/utils.jl
https://github.com/glwagner/ColumnModelOptimizationProject/blob/master/les/kernels.jl

True, but the abstraction I was thinking about would be far more general! Users would define fluxes by writing code of the form
average_flux = HorizontalAverage(κₑ * ∂z(T), frequency=10)

for example, where κₑ and T are eddy diffusivity and temperature fields. The operator ∂z(T) will return an object Derivative and the operation κₑ * ∂z(T) will return a BinaryOperation. These objects will behave like fields in the sense that calling getindex(obj, inds...) will perform the necessary interpolation, difference, and arithmetic operations to calculate the values at the specified indices. In particular, running such HorizontalAverage diagnostic will compute the flux with a kernel (eg compute!(scratch_array, binary_operation)) and store it in some intermediate scratch array (like pressure), and then compute the horizontal average of that.
Still not sure how to specify momentum fluxes, since those expressions are a bit more complicated. But we can provided aliases for those cases that utilize this abstraction system.

Awesome! Still need to take a look at PR #463.

Still not sure how to specify momentum fluxes, since those expressions are a bit more complicated. But we can provided aliases for those cases that utilize this abstraction system.

Yeah might make sense to define convinient aliases for these complicated expressions. The "available diagnostics" lists from MITgcm, ECCO, or SOSE might give an idea for what diagnostics people usually ask for.
With #463 it seems like we'll be able to provide all existing diagnostics (+ infinitely many more) just be defining one-liner abstract operations.

With #463 it seems like we'll be able to provide all existing diagnostics (+ infinitely many more) just be defining one-liner abstract operations.

Yes, that is the goal. Convenient aliases make sense to me; with the abstraction they will hopefully be easy to maintain.


⚠ Bofrost.de has degraded performance

In 4bc3f2b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1385 ms

Resolved: Bofrost.de performance has improved in df62ee4 after 312 days, 18 hours, 27 minutes.


basioccipital and occipital

I believe that 'abnormal basioccipital bone morphology' should not be a subclass of 'abnormal occipital bone morphology', since 'basioccipital bone' is not a subclass of 'occipital bone'.
Since both of these phenotypes are defined with equivalent class expressions, this relationship leads to mistaken inferences for other other expressions involving these two structures (when MP is used with other ontologies).
It looks like other subclasses of 'abnormal occipital bone morphology' might have the same problem.

I believe MP is correct, as MP is scoped to mammals.
We have a taxon-GCI in uberon:
id: UBERON:0001692
name: basioccipital bone
relationship: part_of UBERON:0001676 {source="ISBN10:0073040584",
gci_relation="part_of", gci_filler="NCBITaxon:40674"} ! occipital bone

The mistake is in assuming MP is applicable outside mammalia, as we do
in monarch and phenoscape. Largely this is fine. Whilst many classes
in MP are inapplicable for, say, fish, this is not a problem if we don't
use those classes to describe fish. The problem arises when we use a
class C applicable to T where C has axioms inapplicable to T.
I think this is relatively rare (should be easy to get an estimate using
uberon taxon GCIs). It's not massively consequential for monarch, but
for phenoscape who are interested in precise questions of loss of
structures over entire clades this is a problem.
I think the correct fix is to have uberon-like phenotype classes that
formally subsume MP
As a quick fix you might want to consider some kind of local override
system (ugly I know...)
On 23 Feb 2016, at 7:17, Jim Balhoff wrote:

I believe that 'abnormal basioccipital bone morphology' should not be
a subclass of 'abnormal occipital bone morphology', since
'basioccipital bone' is not a subclass of 'occipital bone'.
Since both of these phenotypes are defined with equivalent class
expressions, this relationship leads to mistaken inferences for other
other expressions involving these two structures (when MP is used with
other ontologies).
It looks like other subclasses of 'abnormal occipital bone morphology'
might have the same problem.

Reply to this email directly or view it on GitHub:
https://github.com/obophenotype/mammalian-phenotype-ontology/issues/2140

Oh, I forgot about propagating phenotype over part of. I was focused on comparing the anatomy class hierarchy here (and in Uberon) to the phenotype hierarchy. So considering the part of GCI I guess this does make sense. I am thinking of writing a little processor for MP which swaps in X and part_of some mouse for every anatomical term X, to use in Phenoscape.

This is a bit more complex that species differences.  The basioccipital, exoccipital and supraoccipital bones are distinct bones in prenatal, neonatal and some early juvenile stages in primates and rodents. In adult organisms, these structures are fused to form the unified adult occipital bone.  From what I understand, these are never fused in teleosts and are separate bones?
The FMA correctly has separate classes for the adult 'occipital bone' and 'region of fetal occipital bone'.  The basioccipital, exoccipital and supraoccipital bones are subclasses of the 'region of fetal occipital bone'.   I will review this for the MP and I expect that we will restructure by splitting the occipital bone term and annotations, keeping the existing term for the adult annotations, and creating another class similar to 'region of fetal occipital bone'. The basioccipital, exoccipital and supraoccipital bones can be subclasses of that new term.

Great analysis thanks!
Will the proposed additional complexity buy us much in the MP case? Are there fetal abnormalities that we wouldn't want to see listed under the whole-basicoccipital grouping?

Ah- good point.  Probably this is why I organized it this way in the first place...
I'll add some comments for clarity and perhaps revise the text definitions somewhat.

Added comments to the abnormal basioccipital, exoccipital and supraoccipital bone morphology terms for clarity.


Bump rand_core to 0.6

Hi @emgre! :wave:
Quite a few crates in the ecosystem are already using rand_core 0.6 (like ed25519-dalek 2.0). To be able to generate keys there using win_crypto_ng::random::RandomNumberGenerator::system_preferred API an upgrade of rand_core is needed.
rand_core 0.6 was released 2 years ago.

If both version 0.5 and version 0.6 work, you could loosen the dependency by doing `>= 0.5, <0.7".

Okay, I've modified the Cargo.toml file :+1: Thanks for the suggestion!

I'm comfortable with that, do you need a release on crates.io for a particular project?

If that wouldn't be a big problem then yes.
I'm working on upgrading ed25519-dalek in Sequoia (the old version has a security advisory assigned) and can't complete it due to rand_core version conflicts.
Thanks for your help and time! 👋

Release 0.5.1 is available on crates.io.

Thank you very much! 🙇♂


WIP Adding redfish node for chassis/system combo

Adding Redfish manager node type and adding a Defined Error for 501 Not Implemented
adding spec tests

Part of Changes in on-core, on-http, on-tasks, on-taskgraph
The combination of these changes is to fully implement redfish device discovery. This includes the fillowing items:

The implementation of unique device identifiers in place of the RackHD GUID identifers.
a) These ids provide the user the ability to know which node they are looking at. This is usefull for
aggregation.
b) All RackHD Redfish calls can use either the new id or the original RackHD GUID. The RackHD api still can
only use the GUID.
c) Currently this id is made with a combination of the serial number and sku from the redfish discovery.
Creation of redfish and redfishManager node types.
a) redfish nodes are combination of systems and chassis in one node. This is because some redfish implementations
report system and chassis as one object.
b) redfishManagers are a node object to store information about the managers discovered durring redfish discovery.
c) Maintains support with /Chassis /Systems and /Managers Redfish calls.
Dynamic modification of redfish catalogs.
a) injection of the unique device id into the discovered redfish catalogs.
b) catalog names and id use the unique device id.
c) stored in only the relavent node with the source as the odata.id of the call that got the info.
ie. /Systems/{identifier}/...
Implemented support for redfish discovered devices in the redfish API (GET, PATCH, and POST).
a) GETs returned the stored catalogs from discovery
b) PUTs and POSTs start a wrokflow that does the Redfish call on the discovered device with the provide payload
Modified spec test to support redfish devices.
a) Changed from nodeApi stubbing to waterline stubbing in system and chassis spec tests.
Implementation of general purpose REST API workflow.
a) Currently used for doing redfish calls but can be run with any REST calls.
RackHD Redfish API only works for calls which the device<EMAIL_ADDRESS>match the RackHD Redfish implementation
a) not all devices follow this implementation due to the opaque nature of the Redfish odata links
b) To support all would require work to interpret all data during discovery and dynamically store it.

Reddish Discovery allows for the aggregation of Redfish complaint devices. The discovery creates node objects for compute, enclosure, redfish, and redfishManager nodes. The redfish nodes are a combination of a system and chassis and the redfishManager is for storing the manager objects discovered.

@jimturnquist @larry-dean

test this please

test this please


[Backport] Add validation test for etcd only backup and restore

Backport PR #39936
Issue:
https://github.com/rancher/qa-tasks/issues/405
Note:
This validation test takes around 16 mins to complete which is more than default timeout for the test that's why we need to use -timeout option with value either greater than 16 mins or 0. Similar to below command
go test providers.go etcd_backup_restore.go etcd_only_backup_restore_test.go -v -timeout 0
Also it will also requires one k8s version and CNI provider in the cattle config file as per below:
provisioningInput:
   kubernetesVersion:
    - v1.24.8+rke2r1
  cni:
    - calico

@vivek-infracloud overall, lgtm. I left a comment in the forwardport PR for something I missed earlier while I was reviewing this.

One last rebase Vivek, there was a recent merge that affects your branch. Thank you!

@markusewalker @igomez06 Sorry for misunderstanding, backport PR needs to be updated as per the forward port PR. I will update it and ask for reivew again.


[continuelist addon] Update continuelist addon to also support ) as a…

… ordered list bullet
Sorry for not including this yesterday.

Thanks! Merged as 6fa7e27


Installation issues on MacOS with Pathogen

Issue
Running sbcl --script ~/.vim/bundle/vlime/lisp/start-vlime.lisp produces the following error:
While evaluating the form starting at line 29, column 0
  of #P"/Users/seneca/.vim/bundle/vlime/lisp/load-vlime.lisp":
Unhandled VLIME::QUICKLISP-NOT-FOUND-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
                                                        {1004A88203}>:
  Quicklisp not found. Please set up Quicklisp or install the dependencies for VLIME manually.

Full error backtrace
System
Vim 8.2 (w/ +channel)
ASDF 3.3.1
Quickstart latest version (I've verified installation by running (ql:quickload "vecto") in a fresh SBCL REPL).
SBCL 2.1.9

sbcl --script won't use .sbclrc, and so QL won't be loaded already.
You either need to use sbcl --load instead, or configure your own command to start sbcl; see :help g:vlime_cl_impl within Vim, and/or the vlime function vlime#server#BuildServerCommandFor_sbcl.
I'll keep that issue open for now, so that you can report whether that's working for you.

Thank you for correcting the sbcl command, the command executed successfully, but running :help vlime in vim fails regardless.
Could you please suggest what I should do?

nvm, had to run :Helptags.


Incorporate new Kubeflow site design into the hugo theme

Created a new theme (kf) out of the design templates for the site.
Updated templates according to the new design
Some fixes for navigational links
restructured to have all getting started documents in a section of their own.

/issue #14

resolve #14

/lgtm
/approve

fixes #15


Add vue-at

At.js for Vue
https://github.com/fritx/vue-at

My bad! Thank you all for pointing it out..
I forgot to make it public..


Unable to install pyviz tutorial

Hi,
I'm trying to install the pyviz tutorial as explained on https://pyviz.org/installation.html
My working environment is inside a docker container and the following fails (see below) during the build process or if I run inside the jupyter terminal.
Any ideas or workaround ?
Thanks,
Dov
$ sudo conda activate pyviz-tutorial

CommandNotFoundError: Your shell has not been properly configured to use 'conda activate'.
To initialize your shell, run

    $ conda init <SHELL_NAME>

Currently supported shells are:
  - bash
  - fish
  - tcsh
  - xonsh
  - zsh
  - powershell

See 'conda init --help' for more information and options.

IMPORTANT: You may need to close and restart your shell after running 'conda init'.

Have you tried what it suggests, i.e. running conda init bash before conda activate?
BTW, sudo conda isn't something I've ever needed myself, and I would hope that most people would never need to do that, though maybe you have some good reason I've never encountered.

Thanks for the reply.  Yes, I tried running conda init bash before conda activate  and got the response below.
A key detail to mention here is that I'm running everything inside a docker container on an Ubuntu 16.04 VM on Azure cloud.  There are multiple reasons to run inside a Docker image (simplified setting & deployment flexibility).  I eventually got most of the pyviz tutorial to work after installing the tutorial on a stand alone windows machine and copy the pyviz-example folder manually to an Ubuntu folder mounted by the docker container.  The only things that are still failing on the Tutorial inc everything involve with reading .parq files (like dd.read_parquet('../data/nyc_taxi_wide.parq').persist()). I'll open a separate issue for that.
I'm not sure what would be the correct way to include the pyviz tutorial in a Docker container.  Forwhatever it worth, below are more details of my failed attempt:
The docker image is based on the all-spark-notebook image from the Jupyter Docker Stacks.  The Docker file first lines look as below:
FROM jupyter/all-spark-notebook:65761486d5d3
USER root
RUN conda update conda
RUN conda update conda
RUN conda init bash
RUN conda create -n pyviz-tutorial python=3.6
RUN conda activate pyviz-tutorial

The docker image build output looks as below:
Sending build context to Docker daemon  6.144kB
Step 1/36 : FROM jupyter/all-spark-notebook:65761486d5d3
 ---> dd098532dbb2
Step 2/36 : USER root
 ---> Using cache
 ---> f3e1a02c309d
Step 3/36 : RUN conda update conda
 ---> Using cache
 ---> 96ef4dc579f3
Step 4/36 : RUN conda update conda
 ---> Using cache
 ---> cdbb069c88b2
Step 5/36 : RUN conda init bash
 ---> Using cache
 ---> b3f4368310bb
Step 6/36 : RUN conda create -n pyviz-tutorial python=3.6
 ---> Running in 0e6f5957b12a
Collecting package metadata: ...working... done
Solving environment: ...working... done

......
#
# To activate this environment, use:
# > conda activate pyviz-tutorial
#
# To deactivate an active environment, use:
# > conda deactivate
#

Removing intermediate container 0e6f5957b12a
 ---> 7a6c9855ef18
Step 7/36 : RUN conda activate pyviz-tutorial
 ---> Running in f8943301c414

CommandNotFoundError: Your shell has not been properly configured to use 'conda activate'.
To initialize your shell, run

    $ conda init <SHELL_NAME>

Currently supported shells are:
  - bash
  - fish
  - tcsh
  - xonsh
  - zsh
  - powershell

See 'conda init --help' for more information and options.

IMPORTANT: You may need to close and restart your shell after running 'conda init'.
The command '/bin/sh -c conda activate pyviz-tutorial' returned a non-zero code: 1

That looks like a conda issue, whether it's a bug or a usage error; nothing to do with pyviz or the pyviz-tutorial per se. (This message happens before it tries to set up the particular environment, so you'd have the same results with any py36 envt).  My guess from the message "You may need to close and restart your shell after running 'conda init'" is that the init procedure isn't fully completed and that you'd need to somehow launch bash again, which of course is tricky if it's part of a Docker script.
What I've found to work in a somewhat analogous case is to do initialization of the shell the "old way", before conda init was supported, which requires finding some of the setup that conda init does and pasting it into your script directly.  I don't remember where I found the code to do that; it was definitely by snooping around where I wasn't supposed to!  In any case, I'll close this because really your question is about how to activate a conda environment that you just set up, on a shell you just set up, nothing about pyviz, and so I think you'd have to make an issue on https://github.com/conda/conda or see if someone else already has.

Thanks.    I  found  the following wirteups from people worked around the issues:
Conda Environments with Docker
[Using Docker with Conda Environments](Using Docker with Conda Environments)
I'll report if I'll get any of this to work..


[mgmt] computeschedule release

https://github.com/Azure/sdk-release-request/issues/5497

/azp run prepare-pipelines

/azp run js - computeschedule - mgmt - ci