<EMAIL_ADDRESS>Jenna Ortega Lea𝚔ed Video Full Original Viral On Social Media Trending

33 seconds ago - X.XX Jenna Ortega S.ex video l.eaked Viral the internet by storm and amazed viewers on various social media platforms. X.XX Jenna Ortega S.ex L.ea𝚔ed Video V.iral On Social Media. X.XX Jenna Ortega S.ex Lea𝚔ed V.ideo Viral On Social Media. X.XX Jenna Ortega S.ex Lea𝚔ed Video Viral On Social Media.
[🔴📺📱 Cl𝚒ck Here To link 👉👉 (Full Jenna Ortega 2024 Video1)
🔴📺📱 Cl𝚒ck Here To link 👉👉[ (Full Jenna Ortega 2024 Video2)]

X.XX Jenna Ortega S.ex Lea𝚔ed Video Viral On Social Media 2024. X.XX Jenna Ortega S.ex Lea𝚔ed Video Viral On Social Media 2024.
The recurrent theme of Lea𝚔ed tapes and the subsequent fallout serves as a reminder of the fragility of reputation in the digital era. As the lines between private and public life continue to blur, celebrities like Prison Officer find themselves at the mercy of internet chatter, where a rumor can ignite a firestorm of speculation and judgment.
In the ever-evolving landscape of celebrity culture, the Ishowspeedscandal underscores the relentless pursuit of sensationalism, a pursuit that often comes at the expense of truth and dignity. As we navigate the complexities of the digital age, the line between entertainment and exploitation remains perilously thin.
As the situation unfolds, the truth remains shrouded in mystery, leaving the public to ponder the authenticity of the rumors. In a world where fame and infamy are two sides of the same coin, the saga of Ishowspeed is a testament to the power of social media to shape narratives and challenge the boundaries of privacy and consent.
The viral video of X.XX Jenna Ortega S.ex Nude Lea𝚔 emerging online has amassed tremendous views across fan accounts and social media sites with one video clip. The viral video circulating recently shows X.XX Jenna Ortega S.ex Nude Lea𝚔 in an unexpected and hilarious moment while in public running errands.
Numerous fans have rushed to watch the viral video and share the clip among followers featuring X.XX Jenna Ortega S.ex Nude Lea𝚔 caught in an amusing and awkward situation. While surprising, the authentic and candid video showing X.XX Jenna Ortega S.ex Nude Lea𝚔 handling a real life blooper so genuinely has earned praise from viewers. Nevertheless, fans watch the current viral video of X.XX Jenna Ortega S.ex Nude Lea𝚔 that emerged online with delight and clamor for what the celebrity icon's reaction to the widely spread viral video will be.
The fan video showing X.XX Jenna Ortega S.ex Nude Lea𝚔 first emerged on Twitter on Monday, posted by an amused fan who claimed to have captured the silly incident on their phone camera while out and about. The viral clip of X.XX Jenna Ortega S.ex Nude Lea𝚔 had garnered over 2 million views by Tuesday morning as more users on Instagram, Facebook and YouTube began uploading and sharing the embarrassing yet entertaining video.
 Jenna Ortega Lea𝚔ed Video Viral Trending ON Twitter
Here's xnx X.XX Jenna Ortega S.ex Nude Lea𝚔ed 2024 Video Viral On Soc𝚒al Med𝚒a Tw𝚒tter.
Lea𝚔ed viral link download
Lea𝚔ed viral link twitter
Viral video link website
Telegram viral video link 2024
Telegram viral link download
Viral video link download
[🔴📺📱 Cl𝚒ck Here To link 👉👉 (Full Jenna Ortega 2024 Video1)
🔴📺📱 Cl𝚒ck Here To link 👉👉[ (Full Jenna Ortega 2024 Video2)]

xcffe


Add docs for referencing local modules in bundles

Add example on how to create bundles using local module paths.

I was about to come ask if this was possible or request it. Love it 😍


Fetch templates via url and cache

Would be great to be able to reference templates via url as seen with https://github.com/acrontum/openapi-nodegen

Duplicate of #235
This is indeed in the roadmap before we reach v1.0.0. Thanks! :)


Waitconditions without handles?

This appears to be valid CloudFormation:
https://github.com/awslabs/aws-batch-helpers/blob/master/gpu-example/create-ami.yaml#L23
Doing this in troposphere, it complains about a missing resource handle on the WaitCondition, and indeed the CloudFormation documentation says it is required. Is the dependsOn clause somehow implicitly creating a WaitConditionHandle? How can I do this in troposphere?

I can't say why the create-ami.yaml would work in CloudFormation. Something AWS support might be able to discuss.
As you noted, the CF documentation states a WaitConditionHandle is a required property for WaitCondition and troposphere enforces it. The easy fix is to add a handle and just ref it into your WaitCondition. There is an example here.

Oh interesting...thanks for following up. I did find this reference to use a CreationPolicy instead of wait conditions for some resources.
I did a quick PR #988 for you to check out if you need the override in the required fields.

Thank you @markpeek, works as expected :)


Bug: allowAnnotation status is ignored when logged out

When I am logged out and access a link to a data set for which the annotation mode is activated (...allowAnnotation=true), after the login the annotation mode is not active.

I've just done some test and, after logout, the allowAnnotation query param changes to false automatically. @leiyre  could you inspect this behaviour, pls?


Incidents: show report datetime in archive embed

As it is, the archive embeds in #incidents-archive show the datetime the report was actioned in both the message send time A the archive embed footer B.

This means that we're archiving duplicate information and failing to archive the datetime that the incident was reported.
The proposal is to adjust the embed to show incident.created_at instead of utcnow(). This would be a trivial fix here:
https://github.com/python-discord/bot/blob/65e2c2946ddd4d2dcc6b00ec68c0b456048840db/bot/cogs/moderation/incidents.py#L91-L95
Pros

We would be archiving a possibly useful piece of information, which can be used to calculate interesting stats such as response time w.r.t. time of day or whether the report contains a @Moderators pingu.

Cons

I think the embed would be somewhat confusing. It'd be a lot more logical to have A and B switched around, so that the mod's identity is shown next to the time the report was actioned, and the helper's next to the report time. That sadly isn't possible though. Neither is it possible to have a custom footer format, e.g. Actioned by X, Reported on: Y as we're using the timestamp field, which will convert the utc timestamp to the client's local timezone (as it does with the message sent time, so they are in sync).
If multiple incidents reported by the same user are actioned in succession, the Discord GUI won't show the send datetime for each, but will show the embeds as if they were sent together. This means that we will only see when each incident was reported, but not when actioned. Both pieces of information can still be easily retrieved when accessing the Message object programmatically, e.g. via int e though.

Conclusion
As shown above the technical side of things is trivial but we should discuss whether this is a change that we'd want. It'd make a lot of sense to archive both datetimes, but using the embed footer doesn't seem very elegant to me for the reason outlined above.
We originally discussed this with @TizzySaurus.

There likely isn't much need to see the exact time, so "Actioned by x#1234 after 53 minutes · 2020-08-06" sounds like a good alternative.

There likely isn't much need to see the exact time, so "Actioned by x#1234 after 53 minutes · 2020-08-06" sounds like a good alternative.

This seems to be a good solution to the issue. Only think I’d say is perhaps using “6th August [2020]” rather than “2020-08-06” due to the American vs Non-American way of doing dates, although I suppose this isn’t a big deal as long as users are aware of the format being used.

That date is formatted by the Discord client. It will use whatever format your computer is configured with.

That date is formatted by the Discord client. It will use whatever format your computer is configured with.

Then I believe the above method is the best way of proceeding with this.

There likely isn't much need to see the exact time, so "Actioned by x#1234 after 53 minutes · 2020-08-06" sounds like a good alternative.

This reads fine, but it'd be difficult to work with programmatically if we ever want to crawl the channel to see average times, etc.
I think we should first try to answer the question of what we want this piece of information for.


Delete keyvault-common from the source tree

"Keyvault-common is abandoned"
Originally posted by @vhvb1989 in https://github.com/Azure/azure-sdk-for-cpp/pull/2718#r685417878
So, should we delete it from the source tree then?

keyvault-common as a package was removed from the repo some time ago.  I added azure-security-keyvault-shared folder, but it's not a package, but only code that gets compiled into packages directly


host: assertion in ble_eatt_tx

While going through GATT/SR/GAW/BV-10-C test case (and several other GATT/SR test cases), an failed assertion occurs in function ble_eatt_tx() after PTS sends ATT_READ_REQ. This is because ble_l2cap_send() returns BLE_HS_EBADDATA error (SDU length is greater than the peer device's MTU). For some reason this doesn't happen every time.
ble_eatt_tx(uint16_t conn_handle, uint16_t cid, struct os_mbuf *txom)
{
    struct ble_eatt *eatt;
    volatile int rc;

    BLE_EATT_LOG_DEBUG("eatt: %s, size %d ", __func__, OS_MBUF_PKTLEN(txom));
    eatt = ble_eatt_find(conn_handle, cid);
    if (!eatt || !eatt->chan) {
        BLE_EATT_LOG_ERROR("Eatt not available");
        rc = BLE_HS_ENOENT;
        goto error;
    }

    rc = ble_l2cap_send(eatt->chan, txom);
    if (rc == 0) {
        goto done;
    }

    if (rc == BLE_HS_ESTALLED) {
        BLE_EATT_LOG_DEBUG("ble_eatt_tx: Eatt stalled");
    } else if (rc == BLE_HS_EBUSY) {
        BLE_EATT_LOG_DEBUG("ble_eatt_tx: Message queued");
        STAILQ_INSERT_HEAD(&eatt->eatt_tx_q, OS_MBUF_PKTHDR(txom), omp_next);
        ble_npl_eventq_put(ble_hs_evq_get(), &eatt->wakeup_ev);
    } else {
        BLE_EATT_LOG_ERROR("eatt: %s, ERROR %d ", __func__, rc);
        assert(0);
    }
done:
return 0;

error:
    os_mbuf_free_chain(txom);
    return rc;
}

FYI @rymanluk

I'm not sure why we need to send SDU greater then peer's MTU, which is not according to spec (3.4.2 L2CAP SDU Length field (2 octets)). But the second thing is, does this really need to hit assert? Maybe we should add clause for BLE_HS_EBADDATA, log it and goto error

this might be useful GATT_SR_GAW_BV-10-C_2024_06_26_12_08_01.zip

Fixed https://github.com/apache/mynewt-nimble/pull/1868


When a key or value parameter is null/empty IllegalArgumentException should be thrown instead of NullPointerException

Assign it to me, I'll do it over the weekend.

I definitely agree about this. 👍


Update attributes of List command, add Mark and Unmark command

Updated List command for Gernene to work on her v1.3, Created mark and unmark command for Andy to work on his v1.3

Codecov Report

Merging #100 (a631d69) into master (479bc0f) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     41.48%   41.12%   -0.36%
  Complexity      406      406
============================================
  Files           113      115       +2
  Lines          2189     2208      +19
  Branches        242      242
============================================
  Hits            908      908
- Misses         1222     1241      +19
  Partials         59       59

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/ListCommand.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/MarkCommand.java
0.00% <0.00%> (ø)

...va/seedu/address/logic/commands/UnmarkCommand.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/parser/TAssistParser.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479bc0f...a631d69. Read the comment docs.


[ACR / Build] Refactor context upload size.

Describe the bug

The current logic in _upload_source_code won't handle sizes of 1 TB+.

Expected behavior

[ ] The method for calculating size is extracted into its own helper method.
[ ] Aforementioned method supports 1 TB+, even though we won't accept contexts of this size.
[ ] Unit tests are added for this method.

@northtyphoon  - who do you want to reassign this to?


Adding Extensions

If I try to add a Feed Writer extension in this way:
$extensions = new ExtensionPluginManager();
$extensions->setInvokableClass('mediaentry', \MyApplication\Feed\Writer\Extension\Media\Entry::class);
Writer::setExtensionManager(new ExtensionManager($extensions));
Writer::registerExtension('Media');

it says:

Argument 1 passed to Zend\Feed\Writer\ExtensionManager::__construct() must implement interface Zend\Feed\Writer\ExtensionManagerInterface, instance of Zend\Feed\Writer\ExtensionPluginManager given

If I change this line into the \Zend\Feed\Writer\ExtensionPluginManager (and also in \Zend\Feed\Reader\ExtensionPluginManager):
class ExtensionPluginManager extends AbstractPluginManager

into this:
class ExtensionPluginManager extends AbstractPluginManager implements ExtensionManagerInterface

it works.
Is it the right way?

PS: if somebody think it's ok to do this edit, I can send a PR

Anybody?


Schema building: retrieving indexes

Feature discussion / request
Knex has a bunch of methods aimed at providing an interface to build out a schema in any of the supported environments (MySQL / PostgreSQL / SQLite / etc). This includes creating new indexes. However, Knex does not currently offer a way to retrieve some of this schema information, including existing indexes.

Explain what is your use case
In my exact case, I need to be able to retrieve what the primary key is of a given table. However, this can and probably should be seen as a bigger use case of retrieving all indexes.

Explain what kind of feature would support this
By being able to read more existing schema information next to setting it, it would allow users to use Knex for more in-depth applications that work with dynamic database schemas that can be edited at will. It would basically turn Knex into a core engine that can be used to create things like PHPMyAdmin or Sequel Pro, but in JS.

Give some API proposal, how the feature should work
We could extend columnInfo with information on indexes, we could extend the existing methods for schema building with a way to retrieve some of that information, or provide a whole new interface for reading schema information.

Needs quite a more investigation how this can be implemented with different databases + proper API design. Though I would rather have some separate knex-schema inspector package (I would actually rather have also all migration APIs separated from knex for easier maintenance and since those are breaking knex's basic design principles of creating just single query per builder).

That's sounds like a great idea. What would be a good place to get such a conversation / design spec started? As I'm planning on using something like that quite extensively starting right away, I'm down to pick that up! I am a little new to the Knex ecosystem though, so I would need some help coming up with a good API design. I'm assuming we can go the Bookshelf route where you can initialize this package using an instance of Knex to power the queries, but other than that, I don't really know where to start..
Would you be willing to help out plan an ideal API for a stand-alone package like this @elhigu?

Here is good place to draft plans and get comments to the ideas.  Sure I will comment if I have any thoughts / ideas about it, but your approach sounds good.

@rijkvanzanten Personally I'm open to create it as a separate repo under the Knex org umbrella if that works for you.

@kibertoad Absolutely! I just figured as it's something I would have to build for this project anyway, I might as well try turning it into something that the whole community can enjoy 🙂
I suppose the rough next steps to get this rolling would be to extract all the Schemabuilder stuff into a separate installable package under a new repo in the Knex org, and start brainstorming on how we can extend the existing / add new methods to support reading as well as writing

I don't think it is necessary to move schema builder there right now. Just having separate knex-schema-inspector should be fine.

Based on your previous comment I figured it could be a similar effort:

I would actually rather have also all migration APIs separated from knex for easier maintenance and since those are breaking knex's basic design principles of creating just single query per builder

But it's probably too massive of an undertaking to migrate the userbase from a single package to a split approach like that like that

https://github.com/knex/knex-schema-inspector
Personally I wouldn't mind if it's written in TypeScript from day one, but whatever works for you :)

Sweet! Thanks 🙂
I primarily work in TypeScript these days so that works for me 👍

@rijkvanzanten I'll add CI pipeline to the repo later this week.

Closing this feature request in favor of a new project:
https://github.com/knex/knex-schema-inspector


Feature request for @geom_density macro

Would be great if we could also create density plots as they are part of the basic visualization types in R4DS.
I guess it is a fairly low hanging fruit because AlgebraOfGraphics.jl provides the density function.
Here are some hypothetical examples:
using Tidier, PalmerPenguins
penguins = DataFrame(PalmerPenguins.load())

@ggplot(penguins, aes(x = body_mass_g)) +
  @geom_density()

@ggplot(penguins, aes(x = body_mass_g, color = species, fill = species)) +
  @geom_density(linewidth = 0.75, alpha = 0.5)

This is added - and adding new geoms that are supported in AoG really is low hanging fruit if anyone wants to try! See commit https://github.com/TidierOrg/TidierPlots.jl/commit/ecfc96f5eb609f8d2d059670dbcaa0224efe3ce9 for all the code that was required to add this functionality :)
@ggplot(penguins, aes(x = body_mass_g, color = species, fill = species)) +
  @geom_density(linewidth = 0.75, alpha = 0.5)

That's pretty amazing that it's so straightforward to add a geom on top of what you've already built.
Okay if I update the version and release to the registry?

Yep! I fixed the automatic missing value handling as well from issue https://github.com/TidierOrg/TidierPlots.jl/issues/24


Add :limit to queries

At present we take limits as an argument alongside the query.
That's flawed: the limit is used when algebrizing (no need to use DISTINCT when only fetching one result); in some cases it can be included in the generated SQL; and it breaks our ability to associate cached prepared statements back to input Datalog. Quite apart from all that, it's nice to be able to stuff everything — including ordering and limiting — into the same blob, and supporting limit arguments makes our code more complex.
I plan to:

Parse :limit alongside :order.
Allow the use of variable bindings for :limit.
Remove the existing limit argument mechanism.

This PR goes part-way to allowing algebrizing to occur without all variables being bound.
You'll see a TODO in the test where we do the wrong thing. But variable limits are working just fine!


[Event Request] Table 39 - new event on procedure UpdateVATOnLines

Hi,
We need a new event on table 39 procedure UpdateVATOnLines :
...
end else begin
  NewAmount := CalcLineAmount();
  NewVATBaseAmount :=
  Round(
    NewAmount * (1 - PurchHeader."VAT Base Discount %" / 100),
    Currency."Amount Rounding Precision");
  > New event
  IsHandled := false;
  OnBeforeVATAmountCalc(Rec, PurchHeader, Currency, VATAmountLine, TempVATAmountLineRemainder, NewVATBaseAmount,
  VATAmount, IsHandled);
  if not IsHandled then
  < new event
  if VATAmountLine."VAT Base" = 0 then
    VATAmount := 0
  else
    VATAmount :=
      TempVATAmountLineRemainder."VAT Amount" +
      VATAmountLine."VAT Amount" * NewAmount / VATAmountLine."VAT Base";
end;
NewAmountIncludingVAT := NewAmount + Round(VATAmount, Currency."Amount Rounding Precision");
...

[IntegrationEvent(false, false)]
local procedure OnBeforeVATAmountCalc(var PurchaseLine: Record "Purchase Line"; PurchaseHeader: Record "Purchase Header"; var Currency: record Currency; var VATAmountLine: Record "VAT Amount Line"; var TempVATAmountLineRemainder: Record "VAT Amount Line"; NewVATBaseAmount: decimal; VATAmount: decimal; IsHandled: Boolean);
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update PortablePdbReader.cs

Fixes an issue in PortablePdbReader.GetMetadataReader.
This method is supposed to return a value from the cache (if one exists) and otherwise try to create one from the assemblyPath.
The previous code only ever did any work or added anything to the cache if the following condition was satisfied:
 if (!_cache.TryGetValue(assemblyPath, out var provider) && provider is not null)

So if it couldn't find anything from the cache and also, if that thing it didn't find isn't null (which would never be possible - if it couldn't find anything, the out value will always be null).

CI is failing with:

error NU1903: Warning As Error: Package 'Microsoft.NETCore.App' 2.1.0 has a known high severity vulnerability,

Might need some fixing too (drop support for example?)

Worth opening a PR upstream on https://github.com/benaadams/Ben.Demystifier too


[$1000] [MEDIUM] Scan - No red dot for transaction thread in LHN when scanning fails

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/31448
Action Performed:

Go to workspace chat
Create a scan request with receipt that will fail the scanning
Wait for the scanning to fail
Click on the preview to open report page
Click on the preview to open details page

Expected Result:

The transaction thread should have the RBR on the LHN for the submitter.
The transaction thread should not have the RBR on the LHN for the admin.
The expense report should not have the RBR on the LHN for either user

Actual Result:
Both expense report and details page do not show red dot in LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/de240dda-8f67-4d86-babe-83e5914a0238
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e2581b13bb117eee
Upwork Job ID:<PHONE_NUMBER>539257344
Last Price Increase: 2024-02-16

We should fix this but I dont think its that major to be a deploy blocker now cc @cead22

Agreed, let's HOLD this one too, since I think it may be fixed by a fix for a bug we just found in the main violations PR -- context here https://expensify.slack.com/archives/C01GTK53T8Q/p1705693401154309?thread_ts=1705692222.233999&cid=C01GTK53T8Q

on hold for bug mentioned above, not overdue

Hi @cead22, this is the PR we were holding for this issue, correct?

It looks like it, so we can remove the HOLD here if this is still happening

Both expense report and details page will show red dot in LHN

That said, the expected result is that

The transaction thread should have the RBR on the LHN for the submitter.
The transaction thread should not have the RBR on the LHN for the admin.
The expense report should not have the RBR on the LHN for either user

I'm already assigned to other wave issues. Dropping it in wave6 channel https://expensify.slack.com/archives/C02MW39LT9N/p1707498241279089

Just to be clear - is this one internal @marcochavezf @cead22 ?

This one's external

increased bounty

I don't think this is reproducible anymore.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Based on the new expected result, I see only the last one that doesn't match, that is the red dot shown in the expense report.
What is the root cause of that problem?
We have a logic here to get the report errors that include expense/IOU reports which will show the red dot error if the user is the owner.
https://github.com/Expensify/App/blob/20af9e52db6031dea6d0086a6692682eb15e422a/src/libs/OptionsListUtils.ts#L487-L490
This was first added in https://github.com/Expensify/App/pull/27494.
What changes do you think we should make in order to solve the problem?

If we want to change it, then we can simply remove the condition or just the expense report if we want to keep the IOU one.
(IOU report only) Related to the red dot, I see that the red dot is shown in the report preview, DM chat LHN, and the request preview even though they are not the owner. I think the red dot shouldn't be shown if they aren't the owner because they can't edit it. We need to check the owner, but I didn't include the details here as it could be expected and probably out of scope

Please re-state the problem that we are trying to solve in this issue.
Scan - No red dot for transaction thread in LHN when scanning fails
What is the root cause of that problem?
In trying to reproduce this bug, the following expectations from https://github.com/Expensify/App/issues/34827#issuecomment-1928050071 were fulfilled:

The transaction thread should have the RBR on the LHN for the submitter.
The transaction thread should not have the RBR on the LHN for the admin.

However the third expectation, "The expense report should not have the RBR on the LHN for either user", is not fulfilled.
https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L481-L493
The third expectation is caused by the third condition in the getAllReportErrors function since the function does not consider report?.ownerAccountID === currentUserAccountID.
Therefore, the third condition will pass because the ReportUtils.hasSmartscanError returned true for the reportActions.
What changes do you think we should make in order to solve the problem?
In the third condition, check if the report is an expense report, to prevent reportActionErrors.smartscan to be being set to expense reports that didn't meet the report?.ownerAccountID === currentUserAccountID  conditions.
Hence, let's use the ReportUtils.isExpenseReport function as such:
else if (!(ReportUtils.isExpenseReport(report) && report?.ownerAccountID === currentUserAccountID) && ReportUtils.hasSmartscanError(Object.values(reportActions ?? {})))

https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L491-L493

Please re-state the problem that we are trying to solve in this issue.
Scan - No red dot for transaction thread in LHN when scanning fails
What is the root cause of that problem?
In trying to reproduce this bug, the following expectations from https://github.com/Expensify/App/issues/34827#issuecomment-1928050071 were fulfilled:

The transaction thread should have the RBR on the LHN for the submitter.
The transaction thread should not have the RBR on the LHN for the admin.

However the third expectation, "The expense report should not have the RBR on the LHN for either user", is not fulfilled.
https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L481-L493
The third expectation is caused by the third condition in the getAllReportErrors function since the function does not consider report?.ownerAccountID === currentUserAccountID.
Therefore, the third condition will pass because the ReportUtils.hasSmartscanError returned true for the reportActions.
What changes do you think we should make in order to solve the problem?
In the third condition, check if the report is an expense report, to prevent reportActionErrors.smartscan to be being set to expense reports that didn't meet the report?.ownerAccountID === currentUserAccountID  conditions.
Hence, let's use the ReportUtils.isExpenseReport function as such:
else if (!ReportUtils.isExpenseReport(report) && ReportUtils.hasSmartscanError(Object.values(reportActions ?? {})))

https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L491-L493

Proposal
Please re-state the problem that we are trying to solve in this issue.
Scan - No red dot for transaction thread in LHN when scanning fails
What is the root cause of that problem?
In trying to reproduce this bug, the following expectations from https://github.com/Expensify/App/issues/34827#issuecomment-1928050071 were fulfilled:

The transaction thread should have the RBR on the LHN for the submitter.
The transaction thread should not have the RBR on the LHN for the admin.

However the third expectation, "The expense report should not have the RBR on the LHN for either user", is not fulfilled.
https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L481-L493
The third expectation is caused by the third condition in the getAllReportErrors function since the function does not consider report?.ownerAccountID === currentUserAccountID.
Therefore, the third condition will pass because the ReportUtils.hasSmartscanError returned true for the reportActions.
What changes do you think we should make in order to solve the problem?
In the third condition, check if the report is an expense report, to prevent reportActionErrors.smartscan to be being set to expense reports that didn't meet the report?.ownerAccountID === currentUserAccountID  conditions.
Hence, let's use the ReportUtils.isExpenseReport function as such:
else if (!ReportUtils.isExpenseReport(report) && ReportUtils.hasSmartscanError(Object.values(reportActions ?? {})))

https://github.com/Expensify/App/blob/91ea9792fe54b795115106965b2682dd1ef36847/src/libs/OptionsListUtils.ts#L491-L493

@allroundexperts couple of proposals to review ^^

Still reviewing these. Need a little more time. Will provide an update shortly.

Can we confirm if even for IOU reports, we don't want to show the RBR in LHN if there is a smart scan error? @marcochavezf @cead22

@bernhardoj Removing the second condition won't work in this case since the third condition would simply kick in, causing the RBR to show up.
@Tony-MK Removing only the last condition would result in showing of an RBR for the expense report if the user is admin which we don't want. As such, I don't think that your proposal would work.

Still looking for a more accurate proposal.

The third condition won't kick in because it will return false if it's not a report preview action. The condition is used to show the RBR on the chat report if there is a split bill or report preview error.
https://github.com/Expensify/App/blob/0797c0ac556e9d3822f6121e4a9fd3943d990a2c/src/libs/ReportUtils.ts#L4767-L4770

Ah, I did not notice this condition. Given this, your proposal should be good.
We just need to confirm if we need to show the RBR for IOU report or not.
🎀 👀 🎀 C+ reviewed

If by IOU report you mean reports holding p2p request between users and outside of a workspace, then those won't get violations. Only money requests on workspaces get violations. Let me know if that answers your question

@allroundexperts, I think you might be confusing the two Prospal.
My proposal did not suggest removing the third condition.
Kindly, could you re-review my proposal?

@allroundexperts, I think you might be confusing the two proposals.
My proposal did not suggest removing any conditions.
Kindly, could you re-review my proposal?
Thanks

Hi @cead22, Just a quick question.
In a p2p request, is it expected to show the RBR of IOUs for only the requestor to be notified? 🤔

Hi @cead22, just a quick question.
In a p2p request, is it expected to show the RBR of IOUs for only the requestor to be notified? 🤔
Thank you.

In a p2p request that is outside of a workspace, there should be no RBR for violations showing for any user
In a money request made in the context of a workspace, the RBR should show for everyone on the report preview, and theh money request preview. And the RBR on the LHN should only be shown to the person making the request

Issue not reproducible during KI retests. (First week)

I am closing based on the above comment that this is no longer reproducible

Hey folks, this is still reproducible in https://github.com/Expensify/App/issues/37044
Should we handle it there or re-open this issue?

We should re-open this. cc @laurenreidexpensify


WIP: Refactor executions exporter to own file

I am moving executions exporter to own file. This is needed for introducing exporters for other models. All model exporters will have a base class. This will probably be next PR.

We had a discussion whether we want to ship entities to backend yet. Except for metrics like how many rules were created vs deleted, there isn't a lot that we'd get out of shipping entities like rules, actions. We also decided to punt on this in interest of other priorities. So closing this PR. Will open when needed.


fix: migrate all slices off the old time grain format

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
At Airbnb, we see a decent number of errors like No grain spec for day for database presto. It appears that this is because we never merged a migration to move slices from the old type to the new one (see https://github.com/apache/incubator-superset/pull/4755#issuecomment-401981272).
I've replicated/updated @jeffreythewang's work (thanks Jeffrey!) from https://github.com/apache/incubator-superset/pull/5485 in this PR to migrate slices to the proper time grain format
TEST PLAN
set time_grain_sqla for a chart to "day", run the migration and see it converted to "P1D"
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[x] Requires DB Migration.
[x] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
to: @john-bodley @villebro @mistercrunch @jeffreythewang

Codecov Report

Merging #9684 into master will decrease coverage by 6.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9684      +/-   ##
==========================================
- Coverage   65.75%   58.77%   -6.98%
==========================================
  Files         581      399     -182
  Lines       30319    12508   -17811
  Branches     3096     3095       -1
==========================================
- Hits        19937     7352   -12585
+ Misses      10201     4975    -5226
  Partials      181      181

Flag
Coverage Δ

#javascript
58.77% <ø> (-0.02%)
:arrow_down:

#python
?

Impacted Files
Coverage Δ

...explore/components/controls/AdhocFilterControl.jsx
59.22% <0.00%> (-1.57%)
:arrow_down:

superset/utils/import_datasource.py

superset/db_engine_specs/kylin.py

superset/views/filters.py

superset/dashboards/filters.py

superset/models/slice.py

superset/models/datasource_access_request.py

superset/views/database/filters.py

superset/charts/commands/bulk_delete.py

superset/utils/pandas_postprocessing.py

... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13ba25...120fc86. Read the comment docs.


It will crash when run develop when another pc git clone this demo

Hello,
I'm sure that I cooked completed and successed.
But when run it, somehing image happened.I used to rewrite it in a new project and found that I loss the stars cycles.

Hello there!
I understand you are having some kind of problem, but without a reproduction case or a more detailed description of the problem, I'm not sure what I can do.
/Temaran


GoogleAppsCardV1DateTimePicker unuse

{ 	"actionResponse": { 		"dialogAction": { 			"dialog": { 				"body": { 					"sections": [ 						{ 							"widgets": [ 								{ 									"textInput": { 										"label": "休暇理由", 										"name": "remark", 										"type": "SINGLE_LINE" 									} 								}, 								{ 									"dateTimePicker": { 										"label": "开始時間", 										"name": "startTime", 										"type": "DATE_AND_TIME" 									} 								}, 								{ 									"dateTimePicker": { 										"label": "終了時間", 										"name": "endTime", 										"type": "DATE_AND_TIME" 									} 								} 							] 						} 					] 				} 			} 		}, 		"type": "DIALOG" 	} }
I use bot-dialogs in Hangouts Chat. Wrapped into json as shown above.
dateTimePicker is GoogleAppsCardV1DateTimePicker ，but  it cannot be displayed properly.
Thank you very much.

Date picker is not yet supported in Chat dialogs. It's on the roadmap, but I don't have a specific ETA for it at this time. Since this is more of a general help/feature request and not an issue with any of the samples in this repository, I suggest checkout out the resources in the support guide.


Fixed an issue when invalid height/width were added to caps

Summary: Fixed an issue when invalid height/width were added to caps
Type: Fix
Test Plan: Unittests, Component test, Manual tests
Jira: RIALTO-546

https://jenkins.code.rdkcentral.com/job/github-triggered/52031/ started

https://jenkins.code.rdkcentral.com/job/build-component/91298/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/16019/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/23596/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/52035/ started

https://jenkins.code.rdkcentral.com/job/build-component/91301/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/16021/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/23599/ started.

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/44560/

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/44563/

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/16036/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/52065/ started

https://jenkins.code.rdkcentral.com/job/build-component/91308/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/23610/ started.

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/44576/


Blockchain support?

Are there any plans for supporting blockchain?! :laughing:

Yeah, it already works, check out version 1.0:

The 1.0.0 release marks the first release of no code that we consider production ready. No code supports the following languages:

Blockchain (everything can run on a blockchain)


Add functionality to get a File's content

Summary
Starting with Connect 1.3.0, the users can get files that are stored in an Item. Connect Node SDK should enable the users to do that.
In this issue, we will get a file's content.
Tasks to be done

[ ] Implement getFileContent function in the Items class in src/lib/resources.ts. The API endpoint that this function needs to call is v1/vaults/vaultId/items/itemId/files/fileId/content. You'll have to figure out the object type the promise expects./**
 * Get an Item File's content.
 *
 * @param {string} vaultId
 * @param {string} itemQuery
 * @param {string} fileId
 * @returns {Promise<>}
 * @private
 */
private async getFileContent(
         vaultId: string,
         itemQuery: string,
         fileId: string,
     ): Promise<> {
     // functionality
}

Note: Feel free to place this functionality in a separate class (e.g. Files) if you feel it's more suitable. This is just a suggested approach.
[ ] Implement getFileContent function in OPConnect class in src/lib/op-connect.ts:/**
 * Get an Item File's content.
 *
 * @param {string} vaultId
 * @param {string} itemQuery
 * @param {string} fileId
 * @returns {Promise<>}
 */
public async getFileContent(vaultId: string, itemQuery: string, fileId: string): Promise<> {
      return await this.items.getFileContent(vaultId, itemQuery, fileId);
}

[ ] Add a test for the new function in __test__/op-connect.test.ts:test("get file content", async () => {
    // actual test here
}

This issue is blocked by #62


Remove createJSModules for RN 0.47.

Many react-native libraries removes this method (e.g. https://github.com/Microsoft/react-native-code-push/issues/894).

Thanks for the PR @exKAZUu ! Will the code still be downards compatible to older RN versions after removing this overriding method?

I think this PR breaks backward compatibility (e.g. RN 0.46 doesn't work on this).
Removing only the annotation (@Override) is perhaps able to keep the compatibility. I'll check it!

I found we could keep the backward compatibility via https://github.com/Microsoft/react-native-code-push/pull/895#issuecomment-325700522 and https://github.com/Microsoft/react-native-code-push/pull/980, so I modified my PR.

Excellent! Thank you! Could you please also add the comment // Deprecated RN 0.47 as it was done here. Then it is visible to everyone.
After this change I'll accept your PR.

Thank you for your feedback! I modified my PR.

Thanks for the fix! I merged it and the new version 2.0.3 contains it.

Thank you for the release! My team will use your library :)


fix IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/33125
PROPOSAL: https://github.com/Expensify/App/issues/33125#issuecomment-1856848682
Tests
Same as QA step

[ ] Verify that no errors appear in the JS console

Offline tests
Same as QA step
QA Steps

Click FAB > Request money > Manual
Enter amount and select a participant
On the confirmation page, click Amount
Change the amount and save it
Click on the back button twice to return to Manual page
Verify that the new amount is preserved in Manual page

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/97676131/d2b50ed3-b057-4a3d-a422-833e435607a2

Android: mWeb Chrome
https://github.com/Expensify/App/assets/97676131/2ff0a901-c6c4-47d5-b574-0445c8e4572d

iOS: Native
https://github.com/Expensify/App/assets/97676131/7a6bbd52-a56f-4ad3-9e10-8f6f4fc13ec3

iOS: mWeb Safari
https://github.com/Expensify/App/assets/97676131/eaecd198-bb9d-4651-b0f7-cb0cd8ad1b21

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/96077027/4f79a866-da43-41dd-bc27-7514158a8dd4

MacOS: Desktop
https://github.com/Expensify/App/assets/97676131/ab476166-baf2-4676-90fe-bb8f1abbbf8c

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/c2ee1be6-e905-4146-950e-bdb2e97e2a0a

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/f8ac0918-dab6-407a-845d-122696ef1958

iOS: Native
https://github.com/Expensify/App/assets/108292595/0a7b3d84-336f-4190-81b0-9900038bbb7b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/ac39904e-8dcd-4387-a53e-a71a06f3d7f9

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/a187914c-9861-43a2-a7e2-d269143a5a4b

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/8ac6eb3b-07b3-403d-85e2-57f4ec8e2edb

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.32-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[ENSWEB-5706] Allow multiple "ancestral" databases in the Registry

Same as #488 but on release/102

Coverage decreased (-0.01%) to 79.019% when pulling 1b819f7acebfa3cf54231d198b0b35942d6fb725 on bugfix/multi_ancestral_registry_102 into 006ed67988648d167382ef120be7cac41e8e7d09 on release/102.


Fixes issues introduced by PR 151

Superceded by https://github.com/kubernetes-sigs/service-apis/pull/161


Format JSON file to Pytorch File

First of all, many thanks for the code!
I am trying to convert the sample json file in the ../json_data directory to a Pytorch file in the ../bert_data directory (testing this out so I can use my own text in JSON format:
python preprocess.py -mode format_to_bert -oracle_mode greedy -n_cpus 4 -log_file ../logs/preprocess.log

However, the code doesn't seem to do much. I get the following back:
[('../json_data\\cnndm_sample.train.0.json', Namespace(dataset='', log_file='../logs/preprocess.log', lower=True, map_path='../data/', max_nsents=100, max_src_ntokens=200, min_nsents=3, min_src_ntokens=5, mode='format_to_bert', n_cpus=4, oracle_mode='greedy', raw_path='../json_data/', save_path='../bert_data/', shard_size=2000), '../bert_data/bert.pt_data\\c
nndm_sample.train.0.bert.pt')]

And it has been stuck on this for the last 2/3 hours. I would think that converting the .json files to .pt shouldn't take this long (also my CPU's are not utilized at all). Have you encountered this?

Not sure what you encountered here. I ran the same code and get the correct results in seconds.

Thank you for the very quick reply and testing it out. I probably have a misconfiguration in my Windows somewhere as I installed a Linux VirtualBox and it runs there smoothly as well.

I am getting the following error myself I think there is something a miss
gpu_rank 0
[2019-06-25 15:25:49,112 INFO] * number of parameters: 109483009
[2019-06-25 15:25:49,113 INFO] Start training...
[2019-06-25 15:25:49,218 INFO] Loading train dataset from ../bert_data/cnndm.train.123.bert.pt, number of examples: 2001
Traceback (most recent call last):
File "train.py", line 340, in
train(args, device_id)
File "train.py", line 272, in train
trainer.train(train_iter_fct, args.train_steps)
File "/home/kiran1/KiranResearch/BertSum/src/models/trainer.py", line 157, in train
report_stats)
File "/home/kiran1/KiranResearch/BertSum/src/models/trainer.py", line 321, in _gradient_accumulation
sent_scores, mask = self.model(src, segs, clss, mask, mask_cls)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/KiranResearch/BertSum/src/models/model_builder.py", line 93, in forward
top_vec = self.bert(x, segs, mask)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/KiranResearch/BertSum/src/models/model_builder.py", line 52, in forward
encoded_layers, _ = self.model(x, segs, attention_mask =mask)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/pytorch_pretrained_bert/modeling.py", line 733, in forward
output_all_encoded_layers=output_all_encoded_layers)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/pytorch_pretrained_bert/modeling.py", line 406, in forward
hidden_states = layer_module(hidden_states, attention_mask)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/pytorch_pretrained_bert/modeling.py", line 391, in forward
attention_output = self.attention(hidden_states, attention_mask)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/pytorch_pretrained_bert/modeling.py", line 349, in forward
self_output = self.self(input_tensor, attention_mask)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/kiran1/Downloads/yes/envs/pointer/lib/python3.7/site-packages/pytorch_pretrained_bert/modeling.py", line 310, in forward
attention_scores = attention_scores / math.sqrt(self.attention_head_size)
RuntimeError: CUDA out of memory. Tried to allocate 60.00 MiB (GPU 0; 7.92 GiB total capacity; 6.31 GiB already allocated; 69.31 MiB free; 39.90 MiB cached)
Any solution please advice

The log already told you that this is a out-of-memory error

How can I get summerisation for one article
The pipeline is not working as it requires the urls as the article may not be from internet or have webpage?

The log already told you that this is a out-of-memory error

I reduced the batch size further to get out of the situation. Thanks

Not sure what you encountered here. I ran the same code and get the correct results in seconds.

I am having another strange problem. When I follow the Option2 for pre-processing data, I can tokenize .story files successfully and generate .story.json file. But When I run the step-5 I always get three empty square bracket:
[nhassanp@uc1f-bioinfocloud-assembly-base src]$ /data/conda_envs/20200204/miniconda3/bin/python preprocess.py -mode format_to_bert -raw_path ../merged_stories_tokenized/ -save_path ../bert_cnn/ -oracle_mode greedy -log_file ../logs/preprocess.log
[]
[]
[]
(Since I don't have url for my data, I skip step-4)

I am having the same issue. Did anybody able to resolve it? Anybody can help me regarding this matter. I am also getting these three empty square brackets. What possible error it could be??

Also, the parameter oracle_mode is not working for me. It gives an error for wrong arguments.

@AyeshaSarwar I guess your raw_path is empty or is not correct. You may need to change the paths that were defined inside the original code


drop handshake keys when the handshake is confirmed

Not sure why GitHub is being a jerk, but the PR build succeeded https://travis-ci.com/cloudflare/quiche/builds/122448234


new_tab support on open_url

This fixes hyperlinks opening in a new tab whether modifiers are pressed or not.
There is still an issue: opening a hyperlink in a new tab, then coming back to the previous tab, will leave the modifier keys pressed even if they've been released in the meantime. But I believe this is an issue with bevy and not bevy_egui.

Perfect, thanks!


请问skywalking ui中的related  logs 如何上报

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion

Question

请问skywalking ui中的related  logs是什么概念呢？ 如何上报数据？golang sdk

Why report duplicated issue? You are wasting other's time.

log4j2 grepc appender report


Python waitFor Timeout not working properly

Hello all!
I'm having some troubles with the python version of this lib when using the following command:
execute_script('flutter:waitFor', element.id, 0)
When I define a timeout, it should wait until time expires, returning immediately if element is found. Instead, it wait the seconds defined and then return the result.
I also tested using a js test, which works properly, but I'm having this issue with the python library.
Am I doing something wrong?

Could you share the appium server log in both languages to compare issued requests between them?

Sorry, I think I have found the error!
Thanks anyway.

Calling AppiumDriver.execute() with args: ["flutter:waitFor",["eyJmaW5kZXJUeXBlIjoiQnlWYWx1ZUtleSIsImtleVZhbHVlU3RyaW5nIjoiaW50cm9QYWdlRGVzY3JpcHRpb25LZXkxIiwia2V5VmFsdWVUeXBlIjoiU3RyaW5nIn0=",10],"fce1da5a-b345-4e4e-b481-610d5d6d1d52"]
[FlutterDriver] Executing Flutter driver command 'execute'
[FlutterDriver] >>> {"command":"waitFor","finderType":"ByValueKey","keyValueString":"introPageDescriptionKey1","keyValueType":"String","timeout":10}
[FlutterDriver] <<< {"isError":true,"response":"Timeout while executing waitFor: TimeoutException after 0:00:00.010000: Future not completed\n","type":"_extensionType","method":"ext.flutter.driver"} | previous command waitFor
[FlutterDriver@a60b (fce1da5a)] Encountered internal error running command: Error: Cannot execute command waitFor, server response {
[FlutterDriver@a60b (fce1da5a)]   "isError": true,
[FlutterDriver@a60b (fce1da5a)]   "response": "Timeout while executing waitFor: TimeoutException after 0:00:00.010000: Future not completed\n",
[FlutterDriver@a60b (fce1da5a)]   "type": "_extensionType",
[FlutterDriver@a60b (fce1da5a)]   "method": "ext.flutter.driver"
[FlutterDriver@a60b (fce1da5a)] }
this is my server log, @KazuCocoa can you check it?
@marcosmko what was the error?

The error came from Flutter/Dart VM internal. Was your timeout too short? (guessed from the error message)


cleanup: Remove unused variables

Found some variables throughout the code which are not being used.
They can be removed.
Signed-off-by: Wido den Hollander<EMAIL_ADDRESS>

i think we can merge this one if travis agrees (no smoke tests needed)

I agree. The Maven could build the project from the source without any problem :+1:


Use a lib for constructing yaml

https://github.com/DataONEorg/hashstore/blob/294b4fe9168edb7fa9f44fe9d285bf4be4f33f01/src/hashstore/filehashstore.py#L226
YAML has a number of gotchas that can cause surprising behavior. Suggest creating YAML using a library instead of building from a formatted string.

This has been completed via Feature-139: Path Construction & Clean Up

Thank you for this suggestion @datadavev! This has been completed via Feature-138: Construct HashStore Config Yaml with Library
The key-value pair content is now built through yaml.dump(...) and combined with the comments section to form the contents of the hashstore.yaml file.


Update cloud info response

This endpoint orgs/{{orgId}}/cloudinfo/amazon?fields=k8sVersion&location=eastus&secret_id={{secret_id}} should send back this Kubernetes version: 1.9.5
instead of: Not supported key in case of amazon error message.

Cloudinfo is not available through Pipeline API anymore.


tf.mul after tf.split + tf.sigmoid produces wrong numerical results with MKL enabled

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
intel-tensorflow 2.8 - 2.12
Custom Code
No
OS Platform and Distribution
Ubuntu 22.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
When running with an MKL enabled tensorflow (e.g. intel-tensorflow from pypi) (or self-compiled with --config=mkl). Starting with tensorflow 2.8.0 up until 2.12.0 The attached code produces the wrong numerical result. (1.7615 vs expected 2.6439).
If line 25 is changed to m = sig * (b + 0.0) one can get the correct result.
This issue does not occur if installing "vanilla" tesorflow from pip with pip install tensorflow.
This issue also does not occur if one uses tf.exp or tf.log instead of tf.sigmoid.
Standalone code to reproduce the issue
#!/usr/bin/env python3

import math

import tensorflow as tf
import numpy as np

def sigmoid(x):
  return 1 / (1 + math.exp(-x))

data = [[[2.0, 3.0]]]

tf.compat.v1.disable_eager_execution()

s = tf.compat.v1.Session()
p = tf.compat.v1.placeholder(dtype=tf.float32)
a, b = tf.split(p, 2, axis=2)
sig = tf.sigmoid(a)
m = sig * b

out = s.run([p, m], feed_dict={p: data})
print(out)

print('computed: ', out[-1][0,0,0])
print('expected: ', sigmoid(data[0][0][0]) * data[0][0][1])

Relevant log output
2023-06-21 18:37:35.713027: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-06-21 18:37:35.715264: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting:
[array([[[2., 3.]]], dtype=float32), array([[[1.7615942]]], dtype=float32)]
computed:  1.7615942
expected:  2.642391233933647

Hi @curufinwe ,
You have used TF1.x version styling which is not supported currently.Though i tried to replicate the issue but for me results are same with both tensorflow-cpu and tensorflow-intel also. I tried to convert the code to V2 style and testing done and it also produces same results. Please refer to attached gist.

I think we were using the package intel-tensorflow, not the other way around. I'm not sure it uses the correct TF package in your Gist.

Hi @SuryanarayanaY ,
you can reproduce the issue in a docker container build from the following Dockerfile:
FROM ubuntu:22.04

RUN apt update && apt upgrade -y && apt install -y python3-pip
RUN pip3 install intel-tensorflow
ADD test.py .
CMD python3 test.py

This assumes that you put the python script from the bug description next to the Dockerfile in a file called test.py.

Hi @curufinwe ,
Thanks for confirmation.It might be possible the bug was fixed in later versions. Since 1.x versions are not supported anymore and the issue fixed in latest versions already shall we mark it as closed?
Thanks!

This bug occurs with recent TF 2 versions. @curufinwe refers to using disable_eager_execution in TF 2.

If there is no intention to fix the v1 API anymore then yes, one can consider this bug closed.

HI @albertz , @curufinwe ,
The API tf.compat.v1.disable_eager_execution was designed for TensorFlow v1 . For TF V2 coding we need to use tf.function for enabling graph mode.Please refer the attached doc source for same.
If the reported behaviour can able to reproducible with tf.function() then definitely it needs to be looked into. I modified the code using tf.function and can see same results as per attached gist which indicates this might have fixed already in TF 2.X versions. WDYT ?
Thanks!

From your blog post Building the Future of TensorFlow, 2022, you state:

The future of TensorFlow will be 100% backwards-compatible

By that, I understand that this V1-style API using tf.compat.v1.disable_eager_execution() is still sth you want to support. If so, then in any case I think the bug is still relevant.

Despite that, as we still do not fully understand the bug itself, it might be that the bug also exists when using tf.function, just that it will not be reproduced this way, but needs some other code to be reproduced (but we don't know).
I think it still would in any case be good if this can be verified.

I have eliminated the disable_eager_execution function call and am still able to reproduce the error by importing the tf function into a graph and running it within a session. The problem is that this graph based execution is the only form of execution for programs that use the C++ API for tensorflow afaik. Thus I think the bug is still relevant.
#!/usr/bin/env python3

import math

import tensorflow as tf
import numpy as np

def sigmoid(x):
  return 1 / (1 + math.exp(-x))

data = [[[2.0, 3.0]]]

@tf.function
def my_func(data):
    a, b = tf.split(data, 2, axis=2)
    sig = tf.sigmoid(a)
    m = sig * b
    return m

concrete_func = my_func.get_concrete_function(tf.constant(data))
g = concrete_func.graph.as_graph_def()

s = tf.compat.v1.Session()
tf.import_graph_def(g)
out = s.run(['mul:0'], feed_dict={'data:0': data})

print('computed: ', out[0][0][0])
print('expected: ', sigmoid(data[0][0][0]) * data[0][0][1])

Hi @curufinwe ,
I tried to replicate the behaviour with the latest provided code snippet but failed to replicate the behaviour.Please refer attached gist.
tensorflow-intel package is built,maintained and tested by intel for Windows CPU.Same mentioned in TF documentation as well as Pypi. As per my understanding this package has to be installed on windows only. I am not sure whether it is cross compiled for other OS also.
CC' ing @TensorFlow-MKL for more details.

Hi @SuryanarayanaY ,
the tensorflow-intel package on pypi is indeed a Windows only package. But intel-tensorflow is also available for Linux and you can use the Dockerfile I provided above to reproduce the issue. Just replace the test.py with the latest code-snippet I posted.
I have now also created a gist to reproduce the issue.

Hi @curufinwe ,
I am acknowledging that now the issue can be replicable from my side as per attached gist. The issue persists with intel-tensorflow package only but not with TF package itself which was tested in attached gist.
Though the code involves V1 style session there is difference in outputs wr.t intel-tensorflow and tensorflow. Hence assigning the issue to respective team for their comments.
CC : @TensorFlow-MKL for commenting o this issue.
CC: @learning-to-play

I can reprodue this on tensorflow 2.10, 2.11, 2,12 on a ice-lake CPU, Intel(R) Xeon(R) Gold 6346.
$  ONEDNN_VERBOSE=1 python test_repoduce.py
2023-06-28 17:29:34.639477: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-06-28 17:29:35.705623: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
Tensor("split:0", dtype=float32)
Tensor("split:1", dtype=float32)
2023-06-28 17:29:35.708384: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:353] MLIR V1 optimization pass is not enabled
onednn_verbose,info,oneDNN v2.7.3 (commit N/A)
onednn_verbose,info,cpu,runtime:OpenMP,nthr:64
onednn_verbose,info,cpu,isa:Intel AVX-512 with Intel DL Boost
onednn_verbose,info,gpu,runtime:none
onednn_verbose,info,prim_template:operation,engine,primitive,implementation,prop_kind,memory_descriptors,attributes,auxiliary,problem_desc,exec_time
onednn_verbose,exec,cpu,eltwise,jit:avx512_core,forward_training,data_f32::blocked:abc:f0 diff_undef::undef::f0,,alg:eltwise_swish alpha:1 beta:0,1x1x1,40.9431
[array([[[2., 3.]]], dtype=float32), array([[[1.7615942]]], dtype=float32)]
computed:  1.7615942
expected:  2.642391233933647

If m = sig * b is changed to m = sig * (b + 0.0) one can get the correct result.
In this case, oneDNN log is not output.

Looks like related to oneDNN.
Please  run ONEDNN_VERBOSE=1 python test.py to output oneDNN verbose log, to double confirm if oneDNN library and the incorrect result appear at the same time for all cases.
Not sure it's happed on all CPU or only those support AVX512 instrucions only.
We'll look into this.
Thanks!

change the input data = [[[2.0, 3.0]]] to  data = [[[2.0, 1.0]]]
computed:  1.7615942
expected:  0.8807970779778823
or data = [[[2.0, 4.0]]]
computed:  1.7615942
expected:  3.5231883119115293
It seemed the calculate process or input is not passed correctly.
I am not familiar to the process.
Could you help to check this?

Hi @xiguiw ,
I have an AMD system (3970X) that does not have AVX-512, so it's definetly not related to that.
I think what the tensorflow code computes is sigmoid(data[0][0][0]) * data[0][0][0] (wrong index on second multiplier.
Here the code to test it:
#!/usr/bin/env python3

import math
import os

import tensorflow as tf
import numpy as np

os.environ['ONEDNN_VERBOSE'] = '1'

def sigmoid(x):
  return 1 / (1 + math.exp(-x))

data = [[[2.0, 3.0]]]

@tf.function
def my_func(data):
    a, b = tf.split(data, 2, axis=2)
    sig = tf.sigmoid(a)
    m = sig * b
    return m

concrete_func = my_func.get_concrete_function(tf.constant(data))
g = concrete_func.graph.as_graph_def()

s = tf.compat.v1.Session()
tf.import_graph_def(g)
out = s.run(['mul:0'], feed_dict={'data:0': data})

print('computed: ', out[0][0][0])
print('expected: ', sigmoid(data[0][0][0]) * data[0][0][1])
print('expected error computation: ', sigmoid(data[0][0][0]) * data[0][0][0])

and here the output on my system:
2023-06-28 15:24:14.769259: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-06-28 15:24:16.354506: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
2023-06-28 15:24:16.393142: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
2023-06-28 15:24:16.394160: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:353] MLIR V1 optimization pass is not enabled
onednn_verbose,info,oneDNN v2.7.3 (commit N/A)
onednn_verbose,info,cpu,runtime:OpenMP,nthr:64
onednn_verbose,info,cpu,isa:Intel AVX2
onednn_verbose,info,gpu,runtime:none
onednn_verbose,info,prim_template:operation,engine,primitive,implementation,prop_kind,memory_descriptors,attributes,auxiliary,problem_desc,exec_time
onednn_verbose,exec,cpu,eltwise,jit:avx2,forward_training,data_f32::blocked:abc:f0 diff_undef::undef::f0,,alg:eltwise_swish alpha:1 beta:0,1x1x1,39.157
computed:  [1.7615942]
expected:  2.642391233933647
expected error computation:  1.7615941559557646

Hi @curufinwe,
Thank you for your feedback!
I agree with you that it's not related to oneDNN libary itself.
I changed data = [[[2.0, 3.0]]] to data = [[[2.0, 1.0]]] or data = [[[2.0, 4.0]]]
The output keep the same.
However, with or without oneDNN, the result are different.
My understanding is it's a graph calcuation in tensorflow.
It creates a 'graph' and setup the calculation process internal.
I guess the input data are not passed in correctly.
Anyway, we are investigating this issue.
Thank you!
Xigui

@curufinwe
Intel TF team has a fix for it, and we are working on upstreaming the fix into TF.
The fix will be in future TF release soon.
thanks

Glad to hear it. Thank you very much!

Hi @SuryanarayanaY,
I have applied the changes to a locally compiled version of tensorflow 1.13 and I do get the correct result now. This issue can be closed now.
Thank you for your efforts!


how can i use it for my use case.

My use case is I'm gonna pass a face image to the GAN model and it should return the same image with eyeglasses.
can i use your code to do it ? If yes , i need some suggestion.
Thanks .

Hi @alan-ai-learner, please try the celeba_128_eyeglasses pre-trained model. (1) Clone the repo. (2) Install all dependencies. (3) Download the pre-trained model and put it under ./results/. (4) Write an inference script like generate.py. You cannot use generate.py directly because it generates images with opposite attributes against the original images (labels).

hey @elvisyjlin  thanks for replying, but I tried the way you said, but the results are not that promising.
If you can suggest any different way that will be great.
Thanks in advance!

Sorry that I'm not sure about your "not that promising". Is the generated image has low quality? looks the same as input? or total a garbage?
Please understand that the model learns the distribution translation between with attribute A and without attribute A. However, it is quite a naive model with limited capacity. The results are not guaranteed to be perfect.
If you're looking for a stabler model which generates amazing images, StyleGAN is a good choice.


Report shows passed steps as pending

When using mocha steps, if  step 6 out of 10 steps pass, the suite summary shows that 5 tests passed, 1 failed and 9 pending. This is also reflected in the suite summary chart.  Each step shows the icon for pending for those that passed.  It should actually be showing 5 passed, 1 failed and 4 pending.
The report works correctly when using mocha it.

Thanks for opening an issue but you'll need to provide more information in order for me to look into this. Please use the following template:
Describe the bug
A clear and concise description of what the bug is.
Code Reproduce
Link to repo where the issue can reliably be reproduced:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Platform
mochawesome version
mocha (or other test library) version
Node version

Additional context
Add any other context about the problem here.

The Bug
When using Mocha step functions, the following steps:
Step1 Pass
Step 2 Pass
Step 3 Pass
Step 4 Fail
Step 5 Skipped
Have a summary of :
5 Tests, 3 Passed, 1 Failed, 4 Skipped
The steps before the failed step are reported as 'Passed' but they are also reported as 'Pending'. This is reflected in the summary section as text and chart form.
This issue is not seen when using Mocha it functions. The reporting is correct. (3 Passed, 1 Failed, 1 Skipped)
Also when using Mocha steps, if a step is skipped instead of failed, the report also shows the correct summary. (4 Passed, 1 Skipped)
Expected behaviour
For the Mocha step issue, the test steps:
Step1 Pass
Step 2 Pass
Step 3 Pass
Step 4 Fail
Step 5 Skipped
I expect the summary to show:
5 Tests, 3 Passed, 1 Failed, 1 Skipped
Code
I do not have a repo on github to reproduce But I have attached the test report and test files.
mochawesome_pending_bug.zip
Environments
Node version 16..17.0
NPM version 8.19.2
Mocha version 10.0.0
Mochawesome version 7.1.3
mochawesome-report-generator version 6.2.0


Update issue template

glocaltokens version is linked to integration version, let's not ask people to figure out that.
Also remove duplicated Logs section and hide instructions to the comment.

Nice 🚀


Segmentation fault (core dumped) with Term 2 Simulator in Ubuntu Bash on Windows 10

I was setting up the environment for the EKF project. I installed the Ubuntu bash on Windows 10, and I was trying to run the simulator.
First I extracted the simulator to a folder, changed the permission to execute the file
chmod ug+x ./term2_sim.x86_64
Then I found that in order to run the exe there are some dependencies, so I installed all the dependencies it complained for
sudo apt-get install libglu1
sudo apt-get install libxcursor1
sudo apt-get install libxrandr2
But now wen I run this command to run the simulator.
sudo ./term2_sim.x86_64
I get this error
"Segmentation fault (core dumped)"
I am not sure if I am doing something wrong, could you please help ?

Hi there! Please note that usually support issues should usually go through Student Hub in the classroom first.
A segmentation fault will occur with this project (or many other C++ projects) in a few situations. Two of the more common ones are:

Trying to access out of bounds in an array
Trying to run the code when a function is not returning something as expected.

For this project, the second issue is the most likely - take a look at tools.cpp. If you have not yet implemented either of the functions there, your code is trying to get either a vector or a matrix from these functions, but they don't return anything yet! So if you have not implemented anything in that file yet, a Segmentation Fault will likely occur.

No further comments in a month; closing.


Trace Ruby allocations

The firefox profiler viewer can show allocations as well as time spent. Recording both time and allocations should allow for a single profile run to contain all the information users should need from their application 😊.

https://github.com/jhawthorn/vernier/pull/57
https://www.youtube.com/watch?v=ELa9vgPA1B4


*: update grpc, grpc-gateway, gogo/protobuf

@fanminshi @heyitsanthony @xiang90

@gyuho build has failed.

Yeah had to update all grpc-related packages; grpc, grpc-gateway, golang/protobuf, gogo/protobuf
Fixed.
PTAL.

LGTM

@gyuho Do we know why there are so many new dependencies?

@xiang90 It's all from the new gogo/protobuf, which has bunch of sub-dependencies.
We haven't updated it for awhile.

ack

This vendored all of golang.org/x/tools. Opened issue #6838


Add 'delete-service-key' for CC

implementation of story [#90471234]
Signed-off-by: Edward Zhang<EMAIL_ADDRESS>

Hey @xingzhou,
We merged this pull request with some modifications using a new locking pattern we recently switched to (see changes we added).
Thanks! :smiley:
@jeffh & @rmasand
Services API Team