Fix/vue ui sparkstackbar

Before:

After:

Finally:

@2113ic
Your fix was included in v2.3.90
However I changed your code: setting a default width to width / items.length has undesirable consequences (for example, if only one value is > 0, the proportions are wrong).
Instead, if total == 0, an empty bar is now showed.


Add support for custom options on: oneofs, enums, and enum values

Fixes: https://github.com/timostamm/protobuf-ts/issues/37 and https://github.com/timostamm/protobuf-ts/issues/537

@jcready , do you have timeline for when this PR would be shipped? I have a protoc plugin that is blocked by the support for custom options on enum values.

May I know the latest status of this MR? I think these cool changes can bring benefits to many projects. I am trying to add description text by enum value options for some protobuf enum defined for objects status, and I read these options value in order to show on pages.


Get x-csrftoken of opened page

When try get hearders of request, cannot get x-csrftoken.
const response = await goto('URL;gf=all'); if(response.status.code === 200) {console.log("Success!!")}
Only possible get status code and url.
Steps to reproduce

const response = await goto('URL;gf=all'); if(response.status.code === 200) {console.log("Success!!")}
response.status
{ code: 200, text: '' }

Versions
Version: 1.0.12 (Chromium: 81.0.3994.0) RELEASE

Request header can be fetched by intercepting the request.
Example,
intercept('google.com',(request) => {
            console.log(request);
            request.continue(request);
        });

Do let us know if looking for something different.

Request header can be fetched by intercepting the request.
Example,
intercept('google.com',(request) => {
            console.log(request);
            request.continue(request);
        });

Do let us know if looking for something different.

Thank you for answer, all ok now.


Update API documentation

The API documentation in the README is not up to date (some function are missed). See https://github.com/NodeSecure/i18n/blob/main/index.d.ts.
Also I think it would be nice to have API example for extend and extendFromSystemPath*.

will fix it


Language Embedded 3D Gaussians codes released.

Thank you for your excellent work!
Codes of Language Embedded 3D Gaussians has been released!

Thx


Can not use showPopperArrow

Describe the bug
I have upgraded to 2.9.6 because I would like to use the showPopperArrow prop to remove the arrow. After upgrading I noticed that it wasnt working when using the prop as shown in the examples on the demo page. The docs state 'Below are examples which also can be edited directly via the editor on the left side and will be rendered on the right.' and the example works on the site but not locally.
I looked at the jsx on github and saw the conditional rendering the showPopperArrow code uses :
{showPopperArrow && (
      <div className="react-datepicker__triangle" {...arrowProps} />
    )}

however in my node_modules folder. When searching for 'triangle' in the code I find
return e.createElement("div",{className:r},e.createElement("div",ie({className:"react-datepicker__triangle"},a)),n)}
which doesnt seem to show any conditional rendering and only ever renders the triangle no matter what value the prop is given.
I believe the issue is either that the showPopperArrow code did not make it into the latest release as intended or the docs are just showing examples for something that isnt released yet.
To Reproduce
Steps to reproduce the behavior:
Add showPopperArrow={false} prop to DatePicker component in render
Observe that the arrow still shows.
Observe differences in code on github vs code in node_modules.
Expected behavior
Arrow should not render when prop is set to false

When will this be resolved?  This is an issue for our team as well.


Added portmap cni plugin

Added CNI portmap plugin to allow for hostPort in Pod definitions. We could put this in a separate CNI configuration file but i decided to keep both portmap and bridge plugins in one conflist. Don't know what you think but it works.

Thanks for the suggestion but I prefer to stick to a single config and allow others to experiment after following the happy path.


Problem with displaying items

Hello, while shaka works well on computers, it often doesn't work correctly on TV. I mean, for example, the lack of controls or the cursor not disappearing. I found the biggest bug on the Samsung QLED QE65Q7FAM TV.

https://ibb.co/37r8LY7
As you can see in the attachment half of the elements are missing. The software is up to date, the browser too. Other sites like yt (Browser) vimeoo and others display correctly.

Our UI is not designed to work on SmartTVs, sorry! For SmartTVs you should create your own interface or fix ours so that it works well in your case.


update for ipnybs for newer TF version

global_variables_initializer is now initialize_all_variables

Thanks for your feedback.  I suppose you mean the reverse: the initialize_all_variables() method was deprecated in favor of global_variables_initializer().  I updated all the Jupyter notebooks and the book a while ago to reflect this.
Cheers!


Align demos with the structure of AddonStarter

Describe the bug
#125 did not pass the tests in AddonsDemo
Expected behavior
LayoutTest must pass
Minimal reproducible example
https://github.com/FlowingCode/AppLayoutAddon
Add-on Version
6.0.1-SNAPSHOT
Vaadin Version
24.5.0
Additional information
See https://github.com/FlowingCode/AddonsDemo/blob/vaadin24/src/test/java/com/flowingcode/vaadin/addons/LayoutTest.java

I did reset the master branch and moved the code of #125 to new-demo


Address FPC RFC comments

Description
Address comments from RFC PR#40
Link to feature or bug
Link to dependent issues

RFC updated addressing comments

RFC updated addressing comments


Replacing available commands with basic and advanced commands

This pull request closes:

#2147

Changes made:

Added "github.com/spf13/pflag" package to the project dependencies.
Divided the available command list into two - Basic and Advanced commands
added the custom help function output using SetHelpFunc
added a function printCommands to print all the commands. Used the function in SetHelpFunc.

Output of limactl help  after changes:
Lima: Linux virtual machines

Usage:
  limactl [command]

Examples:
  Start the default instance:
  $ limactl start

  Open a shell:
  $ lima

  Run a container:
  $ lima nerdctl run -d --name nginx -p 8080:80 nginx:alpine

  Stop the default instance:
  $ limactl stop

  See also template YAMLs: /usr/local/share/lima/templates

Basic Commands:
  create          Create an instance of Lima
  delete          Delete an instance of Lima.
  edit            Edit an instance of Lima
  list            List instances of Lima.
  shell           Execute shell in Lima
  start           Start an instance of Lima
  stop            Stop an instance

Advanced Commands:
  copy            Copy files between host and guest
  disk            Lima disk management
  factory-reset   Factory reset an instance of Lima
  info            Show diagnostic information
  protect         Protect an instance to prohibit accidental removal
  prune           Prune garbage objects
  show-ssh        Show the ssh command line (DEPRECATED; use `ssh -F` instead)
  snapshot        Manage instance snapshots
  sudoers         Generate the content of the /etc/sudoers.d/lima file
  unprotect       Unprotect an instance
  validate        Validate YAML files

Flags:
  --debug           debug mode
  --help            help for limactl
  --log-level       Set the logging level [trace, debug, info, warn, error]
  --tty             Enable TUI interactions such as opening an editor. Defaults to true when stdout is a terminal. Set to false for automation.
  --version         version for limactl

Use "limactl [command] --help" for more information about a command.

Sorry @AkihiroSuda! Now I made the necessary changes to implement the fix using groupID.

Thanks, but please squash commits

Thanks, but please squash commits

Thank you for reviewing @AkihiroSuda. Now I have squashed the commits.


getBittr Account Setup

Currently the saga for getBittr xpub verification is sending a dummy xpub.
Correct xpub should be generated and sent instead of the dummy.
The allocated path and other details should be saved in the app database.
xpub is sent via this service https://github.com/bithyve/hexa/blob/ef1ee0a030e1797331d260988157c952bd1b2e50/src/services/bittr.ts#L41

All the dummy data is currently being picked up from here: https://github.com/bithyve/hexa/blob/development/src/storage/bittr.ts
We need to update to retrieve this set of data from the correct location in our database where required. Most of the data will be sent by the screens as it will be available in the existing state.
Depends on issue #412

GB Xpub generation available as a part of derivative accounts


CB-9362 on aws rds postgres version is 10.14 instead of 10.6

CB-9362 on aws rds postgres version is 10.14 instead of 10.6

Embedded DB should default to the same version

@akanto  Do we specify a minor version for embedded install? https://github.com/hortonworks/cloudbreak-images/blob/76d44d0eddb60b4a64e84545c56bc53fde731a7a/saltstack/base/salt/postgresql/init.sls#L16-L18

You might be right: https://github.com/hortonworks/cloudbreak-images/blob/76d44d0eddb60b4a64e84545c56bc53fde731a7a/saltstack/base/salt/postgresql/yum/postgres10-el7.repo#L3
And this is updated continuously: https://download.postgresql.org/pub/repos/yum/10/redhat/rhel-7-x86_64/


Disallow @macro_edge_target on union type

Coverage remained the same at 94.662% when pulling 745bc77e4f7443bf0fe4f9e435c535b76e4d74e9 on fix_macro_tests into 5cf256451d9be8f6783529f34035820558ca6ca5 on macro_system.


Add Kafka 1.0 support for realtime ingestion.

The druid extension for druid to ingest data from Kafka is druid-kafka-eight, which based on Kafka 0.8.2.
Using Kafka 0.8.2, we need to connect to the Zookeeper of the Kafka cluster using zookeeper.connect, which actually may not be known.
The newer version of Kafka(0.9.x and so on) uses bootstrap.servers to connect to the Kafka cluster. And we just need to know the broker of Kafka cluster.
I also faced one more problem. In some Kafka clusters, several records may be combined into one message instead of one message per record.
For example, we have some records (record_1,record_2,...,record_n). In a general way, each record is a message in Kafka cluster. For performance reason, the records may be combined into one message as record_1\nrecord_2\n...\nrecord_n in some Kafka clusters.
I write a druid extension based on Kafka 1.0 and also add some support to solve the problem above.

I think there is a better way to accomplish this like using FirehoseV2. So closing this.


Using await rather than 'then'

I often see in the code the use of then rather than await
https://github.com/cheminfo/nmr-displayer/blob/f6f30e9e12256c2b0c54ed69da5f87084294613f/src/component/reducer/Reducer.ts#L160-L167
I really prefer to have the
const data = await SpectraManager.addBruker(
   { display: { name: zipFile.name } },
   zipFile.binary,
 )
 action.payload = data;
 dispatch(action);

The code is shorter and easier to read.
@hamed-musallam  Why not using this ?
@targos What do you think ?

because dispatch and dispatchMiddleware are synchronous. You have to use .then when you manipulate promises in synchronous functions.


Standalone pages for displaying projects, events and connected collectives

We want to be able to link to standalone page for projects, events and connected collectives from the NavBar.
For the design, we can re-use the layout from the tiers page and make sure we re-use the contribute cards in there. Filtering can be done in the frontend given that there are not a lot of entries.
We want to have three distinct routes:

/slug/events
/slug/projects
/slug/connected-collectives

I really want this feature.... @Betree could it be a bounty?

Since this issue is mostly about refactoring properly the existing page, writing specs for a bounty could end up taking more time than doing it directly. I'll look at it

Woo! That was super fast. Thanks Ben!


Get list of possible parameters programatically?

Hello,
I saw the help page https://elastix.lumc.nl/doxygen/parameter.html and I was wondering if there is a way to get all possible parameters for the elastix parameter-file including parameter name, parameter type, and maximum number of values?

@devlaurence This could also be interesting to you.


Add remote option

Solved Issue #710

Codecov Report

Merging #711 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   74.33%   74.38%   +0.05%
==========================================
  Files          72       72
  Lines        2731     2733       +2
==========================================
+ Hits         2030     2033       +3
+ Misses        701      700       -1

Impacted Files
Coverage Δ

src/proposals/forms/mixins.py
100% <ø> (ø)
:arrow_up:

src/proposals/forms/proposals.py
100% <ø> (ø)
:arrow_up:

src/core/models.py
94.64% <100%> (+0.19%)
:arrow_up:

.../proposals/management/commands/recent_proposals.py
98.76% <0%> (+1.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db0119...2943a40. Read the comment docs.

@MadRex2000 I think the field in English should be "Remote Policy" instead "Remoting Policy". Please change it, thanks!


Handle failed APK installation and patching

If "adb install" command is used with "-g" flag, we may get java.lang.SecurityException on some devices because granting runtime permissions at installation time is only allowed for system apps (however we can enable it in the device's Developer options menu).
Also, pulling APK from /data/app/ may be restricted. We can workaround by copying the APK to a directory which we can access then try to pull the APK from there.

@tabikati This is breaking on my system. When adbExecCommand(deviceID, "install -r -g \"" + apk + "\""); returns, the adbCheck.strStderror contains "Success" but because it's not empty this is identified as a failure and the code takes the wrong path.
I think as always adb is very unreliable and unpredictable between systems, so this check should be changed: Instead of looking at the stderr output I'm going to just check to see if the package is now installed (since it should have been removed prior to the call to InstallRenderDocServer, there shouldn't be a possibility of false-positives after a failed install). Do you have any thoughts?

I didn't expect the error message to be "Success". I agree that checking if the app is installed is a good solution here. The only problem is that in developer mode it's possible to have a different version installed and the check will return false. Could this check return true in developer mode and return false only if the app is not installed?

What do you mean 'developer mode'? I'm not sure when a different version would be installed, this code is running when we've uninstalled any existing versions are installing the local apks. If the version doesn't match that would mean that the uninstall failed and an old apk is left installed, but we don't currently have a way to recover from that.

In that case the workflow is already broken because the assumption that version codes are accurate no longer applies. RenderDoc developers should either make sure the git commit hash is the same in both apk and host UI, or install & run the apk manually and avoid the automatic installation entirely. It can never work with inaccurate version hashes.


Feature - context onstatechange event and listeners

First working version
Todos

[ ] create proper Event instance (missing target, etc)
[ ] clear listener when the rust instance is dropped? (is it dropped actually?)

I was wondering if it may not be easier and more general to perform actual event dispatching, like so:

when an audiobuffersourcenode is created
always register an on_ended on the rust side
in on_ended, call dispatchEvent on the Js object
monkey patch the setter of onended to an addEventListener call

In any case, the current implementation also looks good to me

Hum, that's more or less what is done, but maybe your solution would be more elegant yes, I will have a try
In any case, the current implementation is not clean as it prevents the event target to be garbage collected...
I will also have another look on that article https://www.nearform.com/blog/node-js-and-the-struggles-of-being-an-eventtarget/ which might also help having something more clean


[ICON] Reply icon

Icon Request

Icon name: Reply
Use case: Like the Reply icon in Mail apps
Screenshots of similar icons:

The Forward icon would also be cool, just not my top need at the moment :)
Love your work, thank you!

Thank you!


[CSL-230] Message prehashing

@gromak
See last part of [this documentation|https://www.stackage.org/haddock/lts-7.9/ed25519-<IP_ADDRESS>/Crypto-Sign-Ed25519.html]. There are pros and cons of doing it. Probably in some cases we should do it, but in some cases we should sign data w/o hashing it before. That's why it makes sense to provide both versions.

@georgeee
I observe it only as optimization. Like hash + sign for small messages is useless overhead. But before doing anything, we need to see hashing small messages is really a concern (of CPU/mem usage and/or network load we produce).
If we ever would like to implement this feature, I think of having constant threshold on byte length, above which we hash data, bellow - just signing it. And when signature is to be checked, we can deduce which method was used by data/signature length


fix(tls) remove depth param in ffi_set_upstream_ssl_verify

I think it is an error in C declaration of ffi_set_upstream_ssl_verify.
There is a redundancy param depth,
and in lua-resty code, the declaration is
int ngx_http_lua_kong_ffi_set_upstream_ssl_verify(ngx_http_request_t *r,
int verify);

Good catch!


#457 fixing the problem of chance.character({ alpha: false })

there were some problems in character like bellow
chance.character({ alpha: false })
"c"
chance.character({ alpha: false })
"I"
chance.character({ alpha: false })
"6"
chance.character({ alpha: false })
"P"
chance.character({ numeric: false })
"8"
chance.character({ alpha: false, numeric: true })
"j"
chance.character({ alpha: false, numeric: true })
"]"

and before creating the pool i check if there is a a false element in option

Coverage decreased (-0.2%) to 95.276% when pulling 13a1a2864b21156e1f4d8cf3054662c2d26e80ee on sh3rLock3d:new_issue into 93b384673074fe959c9691d02d2a0fec8cd394fa on chancejs:master.


Pipelines Badges Are Broken

Before submitting bug
Bug Report Template
ScottPlot Version: N/A
Operating System: N/W
Application Type: N/A
Bug Description: The badges in the readme for the build pipelines are broken:

Reproducing: What do others have to do to reproduce the bug? A code sample may be helpful.
Visit the readme on github.

I saw this today too ... Maybe these third party badges only last for one month and ScottPlot hasn't had a public commit for 4 weeks now?
I could use the official badges (which maybe never expire?) or I could do better at not letting 30d go by again...
I've been putting all my effort recently into a few of my other projects (AbfSharp and pyabf) but I'm wrapping those up and I intend to focus again on ScottPlot again within the next couple days ...

I think you can make an empty commit to check/fix. Nobody will condemn for this.

It seems this is an Azure Pipelines thing, and changing the badge URL wouldn't fix it.
Since I'm using a free plan, Azure Pipelines only retains build run details for 30 days.

I think you can make an empty commit to check/fix. Nobody will condemn for this.

This is one option! Another option is to set-up Azure Pipelines to automatically build/test the latest master branch nightly. I'll look into this...
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/scheduled-triggers


not working with new architecture on RN 0.75

When compiling in XCode I get following errors:

'react/renderer/components/iostextinput/conversions.h' file not found
'react/renderer/components/iostextinput/primitives.h' file not found
'react/renderer/components/text/BaseTextProps.h' file not found

We have not upgraded to 0.75 yet but PR's are welcomed :)

commenting so i can subscribe to this –
we really wanna use this in our app (Photodare.ca) but Expo is including RN 0.75 in Expo 51 and getting past the ton of breaking changes in expo 50–>51 took us MONTHS, so I'm nervous about using this in case expo forces .75 with SDK 52
I'm our designer who happens to do a lot of front end development, unfortunately not skilled enough to commit back on this


Fix caching of VISIT_CONFIG_SITE

Description
This is to fix caching of VISIT_CONFIG_SITE command-line option so that re-run attempts will remember the setting.
I also removed all modification comments in CMakeLists.txt prior to 2020.

Type of change

[x] Bug fix~~
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?

Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[ ] I have commented my code where applicable.
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@cyrush I believe this should fix your issues with VISIT_CONFIG_SITE


Ensure code standards/rules using GitHub Actions

Is your feature request related to a problem? Please describe.
There are some code formatting rules defined inclang-fomat.5file in age repo, but as far as I see, there is no workflow for ensuring that any new PR or commit is actually meeting that standard.
Describe the solution you'd like
A Github Action to ensure that any files touched or created by PR or commit is meeting the code formatting standard/rules defined in clang-format.5. We can use pre-commit to scan the code and generate automatic warnings on code style violations allowing the reviewer to focus on architecture of a change while not wasting time with trivial style nitpicks.
Describe alternatives you've considered
An alternative to having a CI tool such as pre-commit would be to manually review code for style violations which is a tedious and unnecessary time-consuming task.
Additional context
This GitHub Action will also run in the forked copies of the repository, so contributors can verify their code before creating a pull request.
Suppose a PR is created that only touches age_graph.c and the modified code does not meet the age repo code standards. The CI Action will detect the violation(see img 1) and point the exact line of code where violation occurs(see img 2).

@MuhammadTahaNaveed Why was this closed? It sounds like a good idea.

@MuhammadTahaNaveed Why was this closed? It sounds like a good idea.

There was some issue due to which checks were failing. I have fixed it. It's ready to be reviewed now.

@MuhammadTahaNaveed I've added some questions to the PR.


prevent accidental self- lockout in multiSelect (WIP, discussion?)

With admin rights you can semi-accidentally send a request to set a random new+default password for yourself; which can cause you not to be able to login again.
This only displays a confirmation if you selected yourself; you can still do it.
Should there be warnings for locking yourself out of groups (which ones?) too?
(Deleting yourself is not possible, so no warning there, yet)

Editr: Do a filter. If the operator was affected prompt him with a message, that  "his password wasn't changed, because he wouldn't had the possibility to retrieve his new password. Please change it manually.".

@FinnStutzenstein I changed it to 'reset everything except own, raise an error bar if own account was selected

Please change the wording, then this can be merged.

@FinnStutzenstein please confirm that the two-week old 'can be merged' is still valid (it is rebased and with changed wording)

@MaximilianKrambach It's ok, but please re-add the true.

Succcessfully tested


Scala Compiler Warnings

We should probably not tolerate compiler warnings in Scala any longer, especially since there's only a handful that I can see in the project (currently 13 in each spark project 1.6 & 2.0). This is a meta ticket for fixing compiler warnings in Scala, and after this ticket is completed, the compiler should be configured with '-Xfatal-warnings' to ensure no more compiler warnings are committed going forward (as they will fail the build).

[x] #970 Fix discarded return value Scala compiler warnings
[x] #971 Fix unchecked type Scala compiler warnings.
[x] #972 Fix dead code Scala compiler warnings
[x] #973 Fix implicit conversion method Scala compiler warnings
[x] #974 Enable Fatal Warnings on Scala Compiler

I can work for them.

Closing this issue out as all sub-items have been closed out or merged.


Update scss and images for v6 presentation of kilo

+1 Was tested also for Liberty?

That's the version for kilo (needed for SUSECon), I guess it's not working in liberty, though.
@kwwii do you also have the one for liberty available?

Yes, I have one for liberty ready, just need to push the changes to github


Auto updates for Gitea

I would like to integrate an auto-updater for Gitea. This will only work for our prebuilt binaries and our Docker container of course, for everything else we are out of control and the admin is responsible for the update on his own.
The functionality should be added via an build flag so that the regular builds by admins don't get this functionality.
Options
I can think about various options how we can handle this functionality. Below is a list of the options i though about:

Provide a app.ini or CLI flag to opt-out from the update process, update the prebuilt binaries and docker containers automatically and do a graceful restart, optionally send a notification to the admins that an update have been applied
Provide a app.ini or CLI flag to opt-out from the update process, add a page to the admin view that shows the latest available version and add a button to trigger the upgrade and graceful restart, optionally send a notification to the admins that there is a new version available

Tools
A pretty mature library is already out there in the wild, I would suggest to use https://github.com/inconshreveable/go-update for this. For the hosting of the updates we got the option to use our CDN based https://dl.gitea.io page or the service https://equinox.io/ offered by @inconshreveable.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Why not add a setting to app.ini? That way you don't have to recompile the binary when you decide to turn on auto updates.

this auto update will be for all installation options or only install by binary?

Why not add a setting to app.ini? That way you don't have to recompile the binary when you decide to turn on auto updates.

Because the functionality will be only available for our pre-compiled binaries and our docker image. Everything else can be built totally different and is not in our control. On top of the build flag there will be a setting to opt-out from this process.

this auto update will be for all installation options or only install by binary?

We can provide it only for our prebuilt binaries, you never know which build tags and so on another install got.

@tboerger Fair point.
I prefer a third option: same behaviour as option 2 but with an option to automatically update when there's a security/critical (non breaking) update.

We should probably start with a update-button in admin-view, that gives us basic functions like "Check version against server" (.sig-files as well :wink:) and "Update". At a later stage we can add auto-checking and auto-updating, since most likely people will not want to auto-update.
In any case, Auto-Update should be opt-in 😒

What happens to the setcap permissions which I use to bind to port 80. When the binary is replaced, these needs to be set again, which needs root.

What happens to the setcap permissions which I use to bind to port 80. When the binary is replaced, these needs to be set again, which needs root.

That's something that needs to be tested, but AFAIK it doesn't replace the entire binary, it's doing a binary diff and merge.

So let's implment #1101 at first and move this to 1.x.x

I think notifications solve a lot of this...
Updating is pretty easy, but I currently have no idea if there is a new version of gitea unless I go and check myself.

There is a RSS feed for blog.gitea.io

I have written a python script to update gitea (but you may need to change the script for your system):
Blog Post: http://blog.m5e.de/gitea/update/upgrade/bash/script/2018/11/26/gitea-auto-update-script.html
GitHub Repo: https://github.com/CMiksche/gitea-auto-update
Maybe a solution until the direct go implementation is finally here - sadly it's nearly two years since this issue was created ...

I could try to implement it with https://github.com/rhysd/go-github-selfupdate

@sapk no, please don't... A github specific updater built into the binary won't be merged since it will anyway break after a migration to selfhosting.
A selfupdating application isn't that easy, and useful for the prebuilt binaries only. Beside that there are other things that also got to be integrated like optin or optout...

@tboerger It support enterprise version so it support custom url. I could try if it already work with gitea or if we need to fork/PR to be compatible.

Here's a script and setup notes on how I configure Gitea to auto-update on Ubuntu 18.04 for a binary install:
https://gist.github.com/4oo4/a53affc5e977bfacfbfa2aed0172ed13

I would recommended to use @CMiksche python script for updating
https://github.com/CMiksche/gitea-auto-update

I'm not really involved into Gitea anymore, so I'm closing this issue. If there ist still interest please open a new issue and maybe link to this one for initial discussion. I want to get my issues cleaned up.


Split canvas color from theme

Description

As discussed in #2074 this PR split canvas color from the theme. Some type of data looks better with black background (for example multichannel confocal data).
I need to use the light theme because part of QWidgets after applying the napari style are illegible.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

I'm adding this to 0.4.4 if it's ok that we spend a little time thinking about this. One thing I'd like to think about is us adding a small Canvas object, so we could do viewer.canvas.color = ... and viewer.canvas.size ... etc. One question though is what we'll do when we have multiple canvases, should we then have a list there etc?

I'm adding this to 0.4.4 if it's ok that we spend a little time thinking about this. One thing I'd like to think about is us adding a small Canvas object, so we could do viewer.canvas.color = ... and viewer.canvas.size ... etc. One question though is what we'll do when we have multiple canvases, should we then have a list there etc?

I'm adding this to 0.4.4 if it's ok that we spend a little time thinking about this.

I'm ok with this.

One question though is what we'll do when we have multiple canvases, should we then have a list there etc?

I think that in the case of multiple canvases it will be one of the smallest changes. But maybe it is a good point to start a discussion.

I'm adding this to 0.4.4 if it's ok that we spend a little time thinking about this.

I'm ok with this.

One question though is what we'll do when we have multiple canvases, should we then have a list there etc?

I think that in the case of multiple canvases it will be one of the smallest changes. But maybe it is a good point to start a discussion.

I certainly like the ability to override the theme canvas (as needed by @Czaki), but I'm not so sure I agree that it needed to be completely unsettable in the theme. Would there be a way to allow both while still satisfying your use case @Czaki?

yeah, it would be great if we could do this without adding viewer.canvas_color, which I don't think we'll want in long term. I'm going to bump this to 0.4.5 as it probably needs more discussion.

I certainly like the ability to override the theme canvas (as needed by @Czaki), but I'm not so sure I agree that it needed to be completely unsettable in the theme. Would there be a way to allow both while still satisfying your use case @Czaki?

yeah, it would be great if we could do this without adding viewer.canvas_color, which I don't think we'll want in long term. I'm going to bump this to 0.4.5 as it probably needs more discussion.

yeah, it would be great if we could do this without adding viewer.canvas_color, which I don't think we'll want in long term. I'm going to bump this to 0.4.5 as it probably needs more discussion.

So could we also bump #2074 functions by one version? Also #2140 will not be solved fast.
I strongly prefer to have option to set background to black for confocal data even with light theme.

yeah, it would be great if we could do this without adding viewer.canvas_color, which I don't think we'll want in long term. I'm going to bump this to 0.4.5 as it probably needs more discussion.

So could we also bump #2074 functions by one version? Also #2140 will not be solved fast.
I strongly prefer to have option to set background to black for confocal data even with light theme.

I strongly prefer to have option to set background to black for confocal data even with light theme.

this part is great.  I too would like the possibility of overriding the theme.  I'd just like us to be able to do it as an override ... not just to discontinue support for theme canvas colors altogether

I strongly prefer to have option to set background to black for confocal data even with light theme.

this part is great.  I too would like the possibility of overriding the theme.  I'd just like us to be able to do it as an override ... not just to discontinue support for theme canvas colors altogether

this part is great. I too would like the possibility of overriding the theme. I'd just like us to be able to do it as an override ... not just to discontinue support for theme canvas colors altogether

But this force to manually overwrite after every theme is toggled.

this part is great. I too would like the possibility of overriding the theme. I'd just like us to be able to do it as an override ... not just to discontinue support for theme canvas colors altogether

But this force to manually overwrite after every theme is toggled.

But this force to manually overwrite after every theme is toggled.

does it? You don't think we can come up with any way to default to the theme color, but once an override has been provided, use it?
i feel like we can probably come up with something ... such as viewer._canvas_override or something like that.

But this force to manually overwrite after every theme is toggled.

does it? You don't think we can come up with any way to default to the theme color, but once an override has been provided, use it?
i feel like we can probably come up with something ... such as viewer._canvas_override or something like that.

viewer._canvas_override

I could implement something like this, but I prefer to make it public attribute
From user interface it may be a list of basic colors in view menu?

viewer._canvas_override

I could implement something like this, but I prefer to make it public attribute
From user interface it may be a list of basic colors in view menu?

So could we also bump #2074 functions by one version? Also #2140 will not be solved fast.

Those PRs are already set for 0.4.6, so should be fine to leave (normal policy would have been two releases so for 0.4.5 for something changed in 0.4.3 but you made them three when added which I think was fine). We can resolve this during next release though.

I could implement something like this, but I prefer to make it public attribute

I don't want to add a public attribute that we know we will change, especially when it seems like there are deeper issues at play like #2140.

So could we also bump #2074 functions by one version? Also #2140 will not be solved fast.

Those PRs are already set for 0.4.6, so should be fine to leave (normal policy would have been two releases so for 0.4.5 for something changed in 0.4.3 but you made them three when added which I think was fine). We can resolve this during next release though.

I could implement something like this, but I prefer to make it public attribute

I don't want to add a public attribute that we know we will change, especially when it seems like there are deeper issues at play like #2140.


incorrect time axis (x axis), inverted y axis and overlapping y axis labels for plotSpikeHist

X axis sometimes malfunctions, for example when tstop is set to 'odd' numbers
Y axis is inverted on some set ups but not others
Y axis labels [Avg cell firing rate (Hz)] tend to overlap when overlay=False. Suggestion: plot a single y axis label regardless of the number of spike histograms plotted.

fixed by commit: fb875a47e72690ad7a2f03093ac5794f825e1526


Fit image to screen

JB (ento) suggested that it would be easier to run QC if the image is completely visible without having to scroll.

Implemented in c1278cd42b544015d7a4257ee215780c2a7a3c00


Add differentiable coverage probability regularizer

Resolve https://github.com/probabilists/lampe/issues/14

@francois-rozet please have a look at this one :)
I added all the functionalities expected in this PR, however, I can imagine you would see some parts implemented/organized differently so I keep it as a draft. Maybe we should arrange a call to discuss it?
As already discussed, the new dependency torchsort is slightly problematic to install. To develop the PR I prepared a conda environment.yml file, but eventually, this has to be handled in setup.py. This, however, goes beyond my expertise, and I hope you can give me a hand here :)

Hello @macio232, I am looking at this right now. I read the paper more carefully to understand the method.
Is it expected that the formula written in the docstrings does not correspond to Eq. (12) in your paper? I also don't understand where the $\max$ and $j$ are coming from.

In addition, I have an idea to drop the need for the sort. The rank $\alpha(p_\phi, \theta_i, x_i)$ is computed as an expectation of differentiable step functions. The index of $\alpha(p_\phi, \theta_i, x_i)$ in the batch is computed with a sort, but such index can be seen as a rank as well. Basically,
$$\text{index}(\alpha(p_\phi, \theta_i, x_i)) = \sum_j 1[\alpha(p_\phi, \theta_j, x_j) < \alpha(p_\phi, \theta_i, x_i)]$$
This can be computed very efficiently in the same way as you estimate $\alpha(p_\phi, \theta_i, x_i)$, hence without a sort. What do you think?

I just pused a commit that moves inference components into different files, which should make it easier to read/add/maintain code. I think you can move your two losses into a new file (e.g. diffcal.py).

Is it expected that the formula written in the docstrings does not correspond to Eq. (12) in your paper?

It depends on your preference :) What I put in the docstring is supposed to describe what is the idea behind the method (corresponding to Eg. (7) in the paper), while Eq. (12) precisely describes how this idea is implemented. I can modify docstrings so that they match Eq. (12) but this requires introducing additional symbols, and probably some explanation. Do you prefer the short but more abstract formulation, or the very precise but long?

I also don't understand where the $\max$ and $j$ are coming from.

$\max$ - at some point I realized that the $\sup$ in Eq. (10) could be relaxed with $\max$ instead of $\textrm{mean}$ and when I was preparing the PR I wanted to introduce this update. But later I decided that what is implemented should match what is described in the paper and was used for experiments. I just updated the docstrings, now there is $\textrm{mean}$ both in text and code
$j$ - $j$s are the $i$s from Eq. (7) to which I refer above. An arbitrary index to show that error is calculated over multiple credibility levels. Once I have your decision in 1. I will improve the notation.

In addition, could we drop the need for the sort?

This is actually mentioned in Section 3.2. Did you try this or just went for the sort?

Short: I tried, didn't work well.
Long: Please see openreview for the discussion.
Even longer: Summary of this post.

Also, did you try with a soft step function (e.g. sigmoid) instead of the STE?

Not in the full experiments, but as a PoC and it didn't work well. But I can imagine that under certain circumstances it could work. In fact, a recent arXiv preprint does exactly this if I understood correctly.

Anyway, if you want to keep the sort as in your paper, what I propose is to only import torchsort in the losses and refer to their repository for installation. Like this torchsort would not be a dependency of LAMPE.

Sound good. Where would you see the information about the additional requirement (torchsort) places? Docstrings? README in the repo?
Another direction is to try to replace torchsort with diffsort which is easier to setup. But this is a method based on sorting networks which means it is slower. And I have no idea about the "quality" of the gradients it gives. At some point, I will try to evaluate it empirically.

Summary

As you see, the idea of using calibration (conservativennes) error as a regularizer can be implemented in many ways. The idea of this PR is to implement what I described in the paper. I hope to see people exploring the alternatives and sharing them in the library. However, there is a question about how would you like to maintain it?
a) As a single loss class that is parametrized to handle all the versions?
b) Separate class for every version?
Let me discuss briefly version a) on the example of "sorting-based" vs "direct". Once we go for direct, there I the question of levels at which the loss should be computed. I see at least four options immediately (and the combinations of them):

Fixed number of levels, linspace over (0,1) interval
Fixed number of levels, samples from U(0,1)
User-specified levels, potentially different at every iteration (passed to forward)
If we have a single class for sorting-based and direct, these arguments have to be there but completely ignored if the user chooses to use sorting-based.

Do you prefer the short but more abstract formulation, or the very precise but long?

As you prefer. The docstring can be as long (see NRE) or short (see FMPE) as you want, it is just a means to give some context. By the way, with the new file organization, you can have a long explanation in the module docstring and a short one in the classes docstring (see NRE). Do as you think is better.

Where would you see the information about the additional requirement (torchsort) places? Docstrings?

Preferably in the module docstring. You can even write a little "installation" section like
Installation
------------

blabla `torchsort` blabla

.. code-block:: bash

    $ pip install torchsort

The idea of this PR is to implement what I described in the paper.

I agree, this is probably most sensible way. Discussion about improvements can be come later.

However, there is a question about how would you like to maintain it?
a) As a single loss class that is parametrized to handle all the versions?
b) Separate class for every version?

It depends on the differences I guess. If a flag that switches between two behaviors is enough, I guess the same class is fine. If the code is completely different, I would say two classes. However, don't make your class significantly more complex to be "future proof". Let's go for something simple for now.

Btw, do you have an idea how to call the two loss classes?

Maybe DCP for differentiable coverage probability?

@francois-rozet I applied all the modifications that you suggested.

I tired building the documentation locally to check if it renders correctly, but I get the following error message

❯ sphinx-build . html
Running Sphinx v7.2.6

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/sphinx/config.py", line 358, in eval_config_file
    exec(code, namespace)  # NoQA: S102
    ^^^^^^^^^^^^^^^^^^^^^
  File "<...>/lampe/docs/conf.py", line 6, in <module>
    import lampe
ModuleNotFoundError: No module named 'lampe'

despite being in an environment where lampe is installed in dev mode. Test run without any problems in the same environment.
2. Tutorials
a) Would you like to see tutorials in the same or separate PR?
b) They would be a 1 to 1 copy of the NRE/NPE tutorials. Should I copy all the step-by-step descriptions or just copy the code and refer the reader to the original tutorial?

I tired building the documentation locally to check if it renders correctly, but I get the following error message

Did you install the docs dependencies? Your env has Spinx 7.2.6 which is not what we use currently.
pip install -r docs/requirements.txt

Also what is the version of python in your env? I usually stick to 3.9, because they are still issues with 3.11.

Would you like to see tutorials in the same or separate PR?

In this PR.

They would be a 1 to 1 copy of the NRE/NPE tutorials. Should I copy all the step-by-step descriptions or just copy the code and refer the reader to the original tutorial?

I think a single tutorial (either NRE or NPE + DCP) is enough. For the explanations, the level of the FMPE tutorial should be enough.

By the way, for the tests, I think it will be necessary to skip testing DCP stuff if torchsort is not installed.

Did you install the docs dependencies?
I thought so but that was not the case. Now works fine.

By the way, for the tests, I think it will be necessary to skip testing DCP stuff if torchsort is not installed.
Indeed. The tests don't use backprop so we could fall back to torch's default sorting. What do you think?

The tests should try to back-prop through the loss. I think using pytest.mark.skipif would be more appropriate.

P.S. I will review next week.

Long week it has been :) Do you want me to prepare the notebook(s) before your review?

Ah sorry @macio232, my comment was not clear, I was waiting for you to finish the PR before I would review it. Do you want me to do a first pass before you add tests and tutorials?

Hello @macio232, I looked at your PR and it seems good to me. Thank you for including the installation instructions.
I have rebased the PR to the master branch. Some tests were failing and I fixed them, but there is also a bug on the master branch due to the release of NumPy 2.0... I'll fix that bug then merge your PR.

I tried the DCP losses by replacing the normal losses (e.g. NPELoss) with the DCP ones (e.g. DCPNPELoss) and they seem to work as expected :+1: They are obviously more expensive, but that is not really surprising.
I will merge this PR now.


kernel.root_dir -> kernel.project_dir

https://symfony.com/blog/new-in-symfony-3-3-a-simpler-way-to-get-the-project-root-directory

I think you missed something with the path. If you replace kernel.root_dir with kernel.project_dir, you have to remove the "/../" part :

kernel.root_dir => /path/of/your/project/src
kernel.project_dir => /path/of/your/project

@hermann8u correct :+1:  Thanks for the tip. Fixed


Report remaining disk space as the last CI step

It would be nice if CI reported the remaining disk space when the build finished. But that's not a blocker for this PR.
On Linux and macOS, that's df -h. Not sure about Windows though. There aren't any GitHub actions for it either.
Originally posted by @teor2345 in https://github.com/ZcashFoundation/zebra/issues/1726#issuecomment-779428007

Let's make this medium priority for now, but if #1726 happens again and we run out of disk space, let's put it as a high priority in the next sprint.

I haven't seen this issue while working on the pipelines, If this ever happens again then we reopen this ticket


Refactor handleSimpleNode

Issue

No explicit issue. After implementing NodeProtocolMode, handleSimpleNode needed to be refactored.

Mock protocols json topology format has been changed

checklist

[x] This PR contains all the work required to resolve the linked issue.

[ ] This PR results in breaking changes to upstream dependencies.

[x] The work contained has sufficient documentation to describe what it does and how to do it.

[x] The work has sufficient tests and/or testing.

[x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[x] I have added the appropriate labels to this PR.

bors r+


Error while getting .editorconfig file

Description
I found this message in /admin/notices
Error while getting .editorconfig file: normalization error: insert_final_newline=off is not an acceptable value. strconv.ParseBool: parsing "off": invalid syntax
Nothing founded in gitea.log.
Gitea Version
1.17.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
2.25.1
Operating System
Ubuntu 20.04.4
How are you running Gitea?
Downloaded gitea-1.17.0-linux-amd64
Database
PostgreSQL

It should be true, false or unset. Best course of action is to fix the .editorconfig file. I guess it's good to see such errors somewhere instead of silently ignoring them, so I'd say it's working as intended.

Is this an gitea internal error? Error from the update mirros task?

It's reported by "editorconfig.Parse", which is called by SetEditorconfigIfExists when you browses the repo commits.
The problem is that you have invalid syntax in you .editorconfig

It's reported by "editorconfig.Parse", which is called by SetEditorconfigIfExists when you browses the repo commits.
The problem is that you have invalid syntax in you .editorconfig

I found this: https://github.com/go-gitea/gitea/blob/main/.editorconfig
But in my gitea setup I can't find any .editorconfig.

Its in your repository. Its a user file, committed by some user into your repository.

Its in your repository. Its a user file, committed by some user into your repository.

Ach o.k. That must be one of the mirrors. In this case I can't fix it.

So maybe the proposal could be: "Make Gitea not report user's editorconfig syntax error as repository notice"

We should probably treat values with such errors the same as unset. Maybe also show it in the repo/file view, but I think it's generall unnecessary.

Well, we can ignore the error, but you won't receive the editoconfig anymore then. As these are "hard" errors, https://github.com/editorconfig/editorconfig-core-go/blob/560dd96cabfee7b13fc1e3a3cbcb23c2fcf7258b/definition.go#L53 and will just return nil as editorconfig, this library doesn't seem to have any option to change/disable this behavior either :/

Best course of action would probably be to make editorconfig-core-go treat directive parsing errors the same as when the directive is absent. Could also have a editorconfig.ParseGraceful for that behaviour. Maybe @greut has an opinion.

it should be easy to handle either on/off. Are those part of the spec? A graceful parsing is probably much more work...

No, the spec only indicates true, false and unset as valid values. It does suggest graceful parsing, though:

EditorConfig plugins shall ignore unrecognized keys and invalid/unsupported values for those keys.

So while I think supporting boolean alias (yes, no, true, false, on, off) is probably fine, I think ultimately, invalid values should generally just be ignored instead of raising errors.

@silverwind agreed.

Hmm, logging these parser "warnings" might be hard to consume. How about adding a warnings slice to a parse result, e.g.?
type Editorconfig struct {
  Root        bool
  Definitions []*Definition
  config      *Config
  warnings    []string
}

Fatal errors should still return err of course.

Is this still a problem?

Yes, https://github.com/go-gitea/gitea/pull/21257 got stalled. I think it's the right solution to parse graceful and display errors. Ideally the admin page could also show the affected repo, or the admin notice could also be removed entirely.

Should this be "fixed" with 1.19.1? Cause

Not yet. It's only for 1.20


Remove the, strictly unnecessary, closure and variable shadowing from createObjectURL

Note that this particular helper function is, with the exception of the GENERIC default viewer and the (unsupported) SVG-backend, mostly unused at this point in time. Hence we should be able to clean-up this helper function slightly.
Also, fixes a small inconsistency in the SVGGraphics initialization in the viewer, by passing in the disableCreateObjectURL compatibility-option. Given that the SVG-backend isn't officially supported/recommended this shouldn't have been an issue, but given that I spotted this it can't hurt to fix it.

/botio test

/botio-linux preview

Looks good!


Update imdb extension

Description

Allows people who are conscious of certain content to go straight to the Parents Guide section of a film/game/show. A timesaver for many families with young children.
Opens the following template literal in the browser https://www.imdb.com/title/${imdbID}/parentalguide
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Looks good! @mil3na @owain-williams

🎉 🎉 🎉
Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@owain-williams). Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Thanks, GitHub <-> Raycast accounts linked


Metadata selection

Cross depends on https://github.com/uktrade/data-hub-korben/pull/3

Current coverage is 52.83% (diff: 50.00%)

Merging #13 into master will decrease coverage by 40.53%

@@             master        #13   diff @@
==========================================
  Files            24         25     +1
  Lines           859        865     +6
  Methods           0          0
  Messages          0          0
  Branches         34         35     +1
==========================================
- Hits            802        457   -345
- Misses           48        408   +360
+ Partials          9          0     -9

Powered by Codecov. Last update 89d5bfa...d2afd2e


Support Django model objects in IntelliSense

This case is similar to #1072
Environment data

VS Code version: 1.25.1
Extension version (available under the Extensions sidebar): 2018.7.1
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Anaconda Python 3.6.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): Conda
Relevant/affected Python packages and their versions: Django 2.0.6

Actual behavior
Intellisense/pylint do not offer autocompletion for a member variable inherited from a base class and shows it as a problem: E1101:Class 'Question' has no 'objects' member
The code runs exactly as intended without errors.
I am actually following the Django tutorial from the official site.
Expected  behavior
The object's member should be shown in intellisense and it shouldn't log it as a problem
Steps to reproduce:
It happens when following the tutorial from djangoproject.org:
https://docs.djangoproject.com/en/2.0/intro/tutorial03/
in section: Write views that actually do something:
from django.http import HttpResponse
from .models import Question

def index(request):
    latest_question_list = Question.objects.order_by('-pub_date')[:5]
    output = ', '.join([q.question_text for q in latest_question_list])
    return HttpResponse(output)

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Everything runs ok. there is actually nothing in output.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
System check identified no issues (0 silenced).
July 28, 2018 - 10:47:36
Django version 2.0.6, using settings 'mysite.settings'
Starting development server at http://<IP_ADDRESS>:8000/
Quit the server with CTRL-BREAK.
[28/Jul/2018 10:47:43] "GET /polls/ HTTP/1.1" 200 11

Output from 'Problems'
{
	"resource": "/c:/Users/Ramon Leon/Documents/DjangoProjects/mysite/polls/views.py",
	"owner": "python",
	"code": "E1101",
	"severity": 8,
	"message": "E1101:Class 'Question' has no 'objects' member",
	"source": "pylint",
	"startLineNumber": 9,
	"startColumn": 28,
	"endLineNumber": 9,
	"endColumn": 28
}

That's because Django's objects() method is magical and not discoverable from code analysis. IOW this requires special Django code that both Jedi, Pylint, and our language server do not have. I have made this a feature request, though, for our language server to add support.

This would be great for us Django users, but I can see how Django's various kinds of magic make analysis difficult. Instead of special-casing Django in the LS, is it possible for users of magic-dependent frameworks to provide explicit hint data to the analyzer?

@yozlet good point! I'm sure the language server team will handle it as generically as possible, with the Language Server Protocol and niceties like the DocumentSelector I think they will be able to handle 'special cases' like this.


[otbn] create generic ECC lib

Currently we only have ECDSA for the p256. We have to modify this algorithm such that other curves are supported by making the domain parameters modifiable
Work in implementing P384 is tracked in https://github.com/lowRISC/opentitan/issues/2982

@felixmiller, @jadephilipoom: This issue is kind of ancient, but I'm not sure of the current status. Have we done everything that we wanted to do? Do we plan to? :-)

I think @felixmiller has something in the works?

Yes, I am currently working on this

Yes, I am currently working on this

Is there an update on this one @felixmiller?

What's the status on this one?

This is actually something I am still working on. I think though that we don't need to track it here, since it is on the list of algorithms.

Sounds good, let me close this then.


msglist: Follow web's change making dark mode's --color-text-default opaque

Fixes: #953

Before
After

Thanks for the fix! Looks good; merging.
I think this had been awaiting my review, but it didn't have the label so I skipped past looking at it. Fixed now.

Ah indeed. Thanks for catching it!


Fix bot being stuck & add delay between hacks

Fixes bot being stuck by adding a check to the loop, and adds a delay between bot restarts.

Also, this is unrelated, but if you find OCR unreliable, you could use my php API instead, although you do need a chrome extension to bypass Access-Control-Allow-Origin on s0urce.io
Example of a call to my Php API
(Currently returning "ping")

From playing with this for quite a bit, the hackDelay var can probably be reduced to about 5seconds safely, 15 seconds is way too much.

This looks good to me, but can you extract out the maximum hack fails to it's own variable?  Maybe maxHackFails?  Just to keep with the theme of being configurable.
In regards to the hack delay, 15 is fine with me, and I'd even been fine with 10.  I'd just rather err on the side of caution and leave it to the player to go crazy if they want.

Sure.
I kinda ctrl+c'ed that from my code so I forgot that other people would use it

LGTM! Thanks! :shipit:


chore(prismic): add documents related to prismic module

Document the usage of regsiterPrismicRoute .
Document the usage of rewrites on registerRouteableType .
Document the usage of path on registerRouteableType with and without trailing slash.

Shouldn't it target main instead?

Shouldn't it target main instead?

I could yea, but then I will need to split this in two parts, for the migration guide?

Closed in favour of https://github.com/front-commerce/developers.front-commerce.com/pull/357


Some travis updates

Pull Request Test Coverage Report for Build 645

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.246%

Totals

Change from base Build 640:
0.0%

Covered Lines:
6629

Relevant Lines:
7840

💛  - Coveralls


branch protection enhancements

add support for signed commits
add support for required number of reviews

ping :)

ping again, on this and many of the other open PRs


Code cleanup and performance improvements

Use the spack binary cache to download common packages recompiled
Consolidate some installation code to common files
Move paths added to the beginning for priority
Upgrade GCC to a version commonly used in the spack binary cache, and enable a unit test to insure it's installed

General comment, can you squash/clean up commits?


Call for contributors

Hey @mbogh, how about adding more maintainers to the project? You've collected nearly 200 stars, now would be a great time to add more people to ensure it's development doesn't stale. Maybe @farzadshbfn, @ggrana or @Jachobsen are interested?
Would love to see this lib being actively maintained!

@sebastianludwig I'm open to that, I know I have neglected this project for a while now. But have been super busy at my fulltime job 😸
So are anyone up for the "challenge"?

Well, that's awesome ✌🏼

Is that an "I am" @farzadshbfn? :-)

🤔... you're right it's not obvious...


Update documentation to use Docker Compose V2

Description
The older docker-compose command has stopped receiving updates, it's now recommended to use the included docker compose commands instead:

From July 2023 Compose V1 stopped receiving updates. It's also no longer available in new releases of Docker Desktop.
Compose V2 is included with all currently supported versions of Docker Desktop. For more information, see Migrate to Compose V2.

There are some of changes to flags and stuff, but 99% of users won't have any trouble since they mostly want to up, pull, logs, etc.
Gitea Version
1.20.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
Docker
Database
None

Closed by https://gitea.com/gitea/docs/pulls/43


[Swift APIView] how to handle extensions

Currently, extension blocks from the source code appear in the APIView. The "extension Foo" line is not commentable, and how to represent this is tricky. There's not a good way to create a deterministic ID for the block itself.
For example:

class MyClass { }

// A bunch of other code here...

extension myClass {
  public myNewMethod()
}

Clicking "MyClass" will take you to the class definition, but there's no way to link to the extension block.
One idea would be to essentially "collect" all of the extensions and stuff them in as though they were in the class block. That could be difficult and not work for all cases.

cc/ @jimchou-dev

Error for duplicate definition id

Repo: https://github.com/Azure/communication-ui-library-ios (reproduced in commit 6afcfcfac25acdc1776f7dee877e152f9373422f)
Scenario
2 subclass both implementing from DrawerContainerViewController with different type, each have an extension on UITableViewDataSource, UITableViewDelegate

AudioDevicesListViewController: DrawerContainerViewController
ParticipantsListViewController: DrawerContainerViewController

Original
class SomeClass {
}

extension SomeClass {
  func doSomething() -> String {
    return "Something"
  }
}

Option 1
We would simply collect the extensions within SomeClass and render them as such, even if the syntax isn't technically valid.
class SomeClass {
  extension SomeClass {
    func doSomething() -> String
  }
}

Option 2
Collect the methods/properties defined in the extension and display them as though they were properties of the original class definition. This does lose the context that the method actual came from an extension.
class SomeClass {
  func doSomething() -> String
}

After discussion, the way forward will be to render extensions as follows:

extensions of an "owned" type (defined by the package) will appear right after the type they extend
extensions of foundation types (not defined in the package) will appear at the end of the APIView.
if there are multiple extensions that resolve to the same definitionId, they will be logically merged together so that APIView will render them as a single extension block.


Design a Professional Resume Layout

Create a visually appealing and professional resume layout that is easy to read and navigate for potential employers.

choosing a clear and easy-to-read font;
utilizing white space effectively;
maintaining a consistent style throughout the document.

I don't no what to discuss, so I added it just to pass the test.


Code vulnerable to out of bounds read

The length based for-loops on the packet parsing seems to be unbounded in relation to the malloc of the structures. This may result in heap based overfows on malformed packets. Please include checks to ensure a malformed packets to not result in writing outside the malloc-ed memory allocated for each field, as this may result in remote code execution. Please see https://en.m.wikipedia.org/wiki/Heap_overflow for info on how a heap based overflow can lead to rce.

Thank you.
This is corrected by #3


Unwanted debug prints in console

Hi, with new 0.12.1 release I see messages on console like below when I start my application. As far as I remember, there were no with 0.11. It is not critical, but a bit nasty
I0802 05:08:16.217477358   23373 ev_epoll_linux.c:84]        epoll engine will be using signal: 36
D0802 05:08:16.217850760   23373 ev_posix.c:106]             Using polling engine: epoll

Those logging statements are coming from within the GRPC C code. The GRPC ruby gem loads the C code, and supports ruby's logger with GRPC.logger. However, log messages within the C code does not use the same logging mechanism as the ruby code. I am unaware of how (or if) we can direct those logging statements elsewhere.

@timanovsky The 0.20.0 release uses grpc 1.0 and it looks to me that the polling library chosen is no longer being printed. Can you verify and close this issue? Thanks!

ok, will check
Best regards,
Alexey Timanovsky.
On 29 August 2016 at 17:59, Mike Moore<EMAIL_ADDRESS>wrote:

@timanovsky https://github.com/timanovsky The 0.20.0 release uses grpc
1.0 and it looks to me that the polling library chosen is no longer being
printed. Can you verify and close this issue? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/814#issuecomment-243149986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK0FkBm3hzdYrUTNu5ZXfLuIXglg-bEks5qkvPVgaJpZM4JaQFt
.


Improved docs

Codecov Report

Merging #11 into master will increase coverage by 0.84%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #11      +/-   ##
========================================
+ Coverage   99.15%   100%   +0.84%
========================================
  Files           4      4
  Lines         118    119       +1
  Branches        6      6
========================================
+ Hits          117    119       +2
+ Partials        1      0       -1

Impacted Files
Coverage Δ

src/lib/ValidationChain.ts
100% <100%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2615d...edb2acc. Read the comment docs.


Support for distributing dynamic library

@nurmohammed840 would love more info on this request if you have the time to share more :)

I came here because the thing I'm working on includes both a CLI (in a foo-cli crate) and a C API (in a foo-c-api crate).
@ashleygwilliams when distributing a C API you'll normally want to include a couple things:

Header file (can be considered a static file in your repo for all intents and purposes)
Dynamic library (i.e. use the cdylib crate type to generate libfoo.so or libfoo.dll)
Static library (i.e. use the staticlib crate type to generate libfoo.a or libfoo.lib)

I would love to use cargo dist to distribute a static library as well: https://github.com/penberg/limbo/issues/162

We're in the process of shipping this! It should be in the next release.

As of PR #1214, we'll support static libraries too.

Hey @mistydemeo! I see install-libraries in https://opensource.axo.dev/cargo-dist/book/reference/config.html?highlight=staticlib#install-libraries. However, I don't think it's available in 0.19.0 -- a documentation bug?

Ah yes, documentation bug -- it's slated for 0.20.0, but it is largely implemented already.
The current work can be found in this prerelease, and should works as documented:
https://github.com/axodotdev/cargo-dist/releases/tag/v0.20.0-prerelease.3

Before we ship the proper release it we need some clarification on what installers you'd like to be using, on which platforms, and if there's any specific platform-specific behaviour you expect/require. I think this might have gotten discussed in some other places but it would be good to write them down somewhere.
Current behaviour is:

the tarball packs all the files flat and together
the homebrew installer unpacks each kind of file to the appropriate package manager bin/lib dirs
the shell/powershell installers dump the files flat into the same dir on PATH

this is presumably undesirable and should get adjusted to some more appropriate per-platform/configurable behaviour, but unclear which knobs/defaults we want

??? with the msi installer unclear it even knows about the files

I've corrected the minimum version in the docs; sorry for the confusion!

Hey @Gankra! I am just using the shell installer:
https://github.com/penberg/limbo/blob/main/Cargo.toml
I will try out the pre-release, thanks!

I don't see cargo dist plan pick up the static library, is that expected?
penberg@vonneumann limbo % cargo dist plan
announcing v0.0.1
  limbo 0.0.1
    source.tar.gz
      [checksum] source.tar.gz.sha256
    limbo-installer.sh
    limbo-aarch64-apple-darwin-update
    limbo-aarch64-apple-darwin.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-aarch64-apple-darwin.tar.xz.sha256
    limbo-x86_64-apple-darwin-update
    limbo-x86_64-apple-darwin.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-apple-darwin.tar.xz.sha256
    limbo-x86_64-pc-windows-msvc-update
    limbo-x86_64-pc-windows-msvc.zip
      [bin] limbo.exe
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-pc-windows-msvc.zip.sha256
    limbo-x86_64-unknown-linux-gnu-update
    limbo-x86_64-unknown-linux-gnu.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-unknown-linux-gnu.tar.xz.sha256

Did you enable both the new package-libraries and install-libraries options?

@mistydemeo Oh, first of all, I was still running 0.19.0. I did not realize cargo dist init downgraded the version for me. 🙈
But now with the following options in Cargo.toml:
[workspace.metadata.dist]
cargo-dist-version = "0.20.0-prerelease.3"
ci = "github"
package-libraries = ["staticlib"]
installers = ["shell"]
install-libraries = ["staticlib"]
targets = ["aarch64-apple-darwin", "x86_64-apple-darwin", "x86_64-unknown-linux-gnu", "x86_64-pc-windows-msvc"]
pr-run-mode = "plan"
install-path = "~/.limbo"
install-updater = true
dist = false

I see the following cargo dist plan failure:
penberg@vonneumann limbo % cargo dist --version
cargo-dist 0.20.0-prerelease.3
penberg@vonneumann limbo % cargo dist plan
  × Malformed metadata.dist in /Users/penberg/src/penberg/limbo/Cargo.toml
  ╰─▶ staticlib is not a recognized type of library
  help: you can find a reference for the configuration schema at https://opensource.axo.dev/cargo-dist/book/
        reference/config.html

@penberg ah so in the cargo-dist config we actually explicitly call these "cstaticlib"
rust has this very confusing naming scheme where they did "staticlib (c) and rlib (rust)" and "cdylib (c) and dylib (rust)"
we're currently opting to normalize on a single naming scheme that's less ambiguous

I'll get the docs fixed - we considered both names, but settled on cstaticlib for consistency. Even though it's not the name Rust uses, we felt it was clearer when we're dealing with packaging non-Rust languages.

I now switched to cstaticlib, but cargo dist plan still doesn't seem to see the static library:
penberg@vonneumann limbo % cargo dist plan
announcing v0.0.1
  limbo 0.0.1
    source.tar.gz
      [checksum] source.tar.gz.sha256
    limbo-installer.sh
    limbo-aarch64-apple-darwin-update
    limbo-aarch64-apple-darwin.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-aarch64-apple-darwin.tar.xz.sha256
    limbo-x86_64-apple-darwin-update
    limbo-x86_64-apple-darwin.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-apple-darwin.tar.xz.sha256
    limbo-x86_64-pc-windows-msvc-update
    limbo-x86_64-pc-windows-msvc.zip
      [bin] limbo.exe
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-pc-windows-msvc.zip.sha256
    limbo-x86_64-unknown-linux-gnu-update
    limbo-x86_64-unknown-linux-gnu.tar.xz
      [bin] limbo
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo-x86_64-unknown-linux-gnu.tar.xz.sha256

You can see the Cargo.toml configuration here:
# Config for 'cargo dist'
[workspace.metadata.dist]
# The preferred cargo-dist version to use in CI (Cargo.toml SemVer syntax)
cargo-dist-version = "0.20.0-prerelease.3"
# CI backends to support
ci = "github"
# Which kinds of built libraries to include in the final archives
package-libraries = "cstaticlib"
# The installers to generate for each app
installers = ["shell"]
# Which kinds of packaged libraries to install
install-libraries = "cstaticlib"
# Target platforms to build apps for (Rust target-triple syntax)
targets = ["aarch64-apple-darwin", "x86_64-apple-darwin", "x86_64-unknown-linux-gnu", "x86_64-pc-windows-msvc"]
# Publish jobs to run in CI
pr-run-mode = "plan"
# Path that installers should place binaries in
install-path = "~/.limbo"
# Whether to install an updater program
install-updater = true
# Whether to consider the binaries in a package for distribution (defaults true)
dist = false

If you need a reproducer, I have one in my branch: https://github.com/penberg/limbo/tree/cargo-dist-staticlib

It looks like that plan's for the limbo crate, which only contains a bin - the cstaticlib is defined in the separate limbo_sqlite3 crate, which isn't in that plan.
It does look like you've got a distinct version set for sqlite3_limbo, so plan isn't picking it when trying to pick what to build. You've also got dist = false, which is influencing the set of packages being picked. Try setting sqlite3/Cargo.toml's version to the same as the root Cargo.toml, and setting dist = true in the root Cargo.toml.

This:
diff --git a/sqlite3/Cargo.toml b/sqlite3/Cargo.toml
index 1ea36f3..84bfe9f 100644
--- a/sqlite3/Cargo.toml
+++ b/sqlite3/Cargo.toml
@@ -2,12 +2,15 @@

 [package]
 name = "limbo_sqlite3"
-version = "0.0.0"
+version.workspace = true
 authors.workspace = true
 edition.workspace = true
 license.workspace = true
 repository.workspace = true

+[package.metadata.dist]
+dist = true
+
 [lib]
 crate-type = ["cdylib", "staticlib"]
 doc = false

Fixes it:
  limbo_sqlite3 0.0.1
    source.tar.gz
      [checksum] source.tar.gz.sha256
    limbo_sqlite3-installer.sh
    limbo_sqlite3-aarch64-apple-darwin-update
    limbo_sqlite3-aarch64-apple-darwin.tar.xz
      [cstaticlib] liblimbo_sqlite3.a
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo_sqlite3-aarch64-apple-darwin.tar.xz.sha256
    limbo_sqlite3-x86_64-apple-darwin-update
    limbo_sqlite3-x86_64-apple-darwin.tar.xz
      [cstaticlib] liblimbo_sqlite3.a
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo_sqlite3-x86_64-apple-darwin.tar.xz.sha256
    limbo_sqlite3-x86_64-pc-windows-msvc-update
    limbo_sqlite3-x86_64-pc-windows-msvc.zip
      [cstaticlib] limbo_sqlite3.lib
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo_sqlite3-x86_64-pc-windows-msvc.zip.sha256
    limbo_sqlite3-x86_64-unknown-linux-gnu-update
    limbo_sqlite3-x86_64-unknown-linux-gnu.tar.xz
      [cstaticlib] liblimbo_sqlite3.a
      [misc] CHANGELOG.md, LICENSE.md, README.md
      [checksum] limbo_sqlite3-x86_64-unknown-linux-gnu.tar.xz.sha256

Thanks a bunch, @mistydemeo!

 How're you feeling about it now that it's set up?
What are your plans for this? What platforms and installers are you thinking of distributing for?

Love it! I will distribute the static library as part of the next release for Linux, macOS, and Windows. I am only planning to use the installer script for now. Btw, I think eventually having support for pkg-config would be pretty cool too.

Good call on pkg-config; filed an issue. #1251.

This release is out now, so I'm closing this issue now! We can track future needs in other issues.


Fix broken build on enrichments

The order of the last few merges ended up breaking the build. In the process of resolving this, I discovered that RSpec 3.3 also breaks the build, but I think that will have to wait for @no-reply to look at.
There's a remaining outstanding issue where we're seeing the following error:
undefined method `type' for .focus:Sass::Selector::Class (NoMethodError)

...which was first discovered by @markbreedlove.

Closing; see PR #169 instead.


Relayout JSRT headers to top-level \include folder

Currently JSRT headers are in .\lib\jsrt. Move them to a top-level folder to make it easier for JSRT users.

I'm the only one who complaint about this, so I'm okay without it :).


Plug-in startup failure

Which OS are you using?
Windows
Expected Behaviour
open vscode,Plugins run properly.
Actual Behaviour
...
I also see the following error:
[2023-03-03 09:34:16] |   ERROR   |         Git        | fatal: not a git repository (or any of the parent directories): .git

Reproduction steps

Go to 'open vscode'
See error '...'

Additional Notes
No response
Log
STARTUP
[2023-03-03 09:33:53] |   DEBUG   |     Filesystem     | Created directory at "/C:/Users/zengyq/AppData/Roaming/Code/User/globalStorage/sumneko.lua/addonManager"
[2023-03-03 09:34:16] |   ERROR   |         Git        | Cloning into 'C:/Users/zengyq/AppData/Roaming/Code/User/globalStorage/sumneko.lua/addonManager'...
fatal: unable to access 'https://github.com/LuaLS/LLS-Addons.git/': Failed to connect to github.com port 443: Timed out
[2023-03-03 09:34:16] |   ERROR   |         Git        | fatal: not a git repository (or any of the parent directories): .git

Please see https://github.com/LuaLS/vscode-lua/issues/102


[BENCH] Benchmark Bron-Kerbosch Algorithm

Benchmark Bron-Kerbosch
The goal of this issues is to add a benchmark for the Bron-Kerbosch algorithm. The algorithm implementation is located under include/graaflib/algorithm/clique_detection/bron_kerbosch.h. Benchmarks are vital to our library and allow us to measure the impact of future performance improvements.
We use the Google benchmark framework. For inspiration, please take a look at the existing benchmarks in /perf.
The benchmark should be added under /perf in a directory which resembles the file structure of the original algorithm. i.e. if the algorithm is implemented in include/graaflib/algorithm/coloring/greedy_graph_coloring.h then the benchmark should be added to perf/graaflib/algorithm/coloring/greedy_graph_coloring_benchmark.cpp.
The benchmark should measure the runtime performance of the algorithm for increasing input sizes.
Running Benchmarks
If you IDE has the necessary integrations for it, all benchmarks can be run in the IDE from the perf/graaflib/benchmark.cpp file.
Otherwise, we can run the benchmarks from the command line:
# run all benchmarks
cd build/perf && ./Graaf_perf

To run an individual benchmark:
./Graaf_perf --benchmark_filter=YOUR_BENCHMARK_NAME

For more options, pass the --help flag.
Definition of Done

[ ] A benchmark is added for the algorithm
[ ] Benchmark results (copy past of the output is fine) is added to the PR

Hey @bobluppes, can I work on this, even thought I have active example the issue(example section)? :)

Hey @bobluppes, can I work on this, even thought I have active issue(example section)? :)

Hi @Hromz, of course! Seeing the number of algorithms we currently have there should be no shortage of benchmarking tickets ;)
Assigning this to you!

Hey @bobluppes! Please check PR #157.


[Android] Push notification no longer displays conversation title

Problem
As of this week, we no longer display the push notification conversation titles. This is a regression likely coming from this notification cache PR.

Solution
This is blocking my critical VIP-VSB issue so I'm going to handle it.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0128383058c64efb20
Upwork Job ID:<PHONE_NUMBER>408024576
Last Price Increase: 2024-02-13

Notifications working?

AdHoc build: ✅
Local prod build: ❌

Push Data:
{
  "reportID": 74984251,
  "reportActionID": "1418134007167197202",
  "shouldScrollToLastUnread": true,
  "title": "Hari Seldon",
  "type": "reportComment",
  "onyxData": [
    {
      "onyxMethod": "merge",
      "value": {
        "lastVisibleActionCreated": "2024-02-13 16:42:02.560",
        "maxSequenceNumber": 506,
        "lastMessageText": "asd",
        "reportID": "74984251",
        "lastActorAccountID": 8879888
      },
      "key": "report_74984251"
    },
    {
      "shouldNotify": true,
      "onyxMethod": "merge",
      "value": {
        "1418134007167197202": {
          "sequenceNumber": 506,
          "created": "2024-02-13 16:42:02.560",
          "reportActionTimestamp":<PHONE_NUMBER>560,
          "automatic": false,
          "shouldShow": true,
          "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/04bb9a8b30a0fe1783343ca005d096c578dff6c6_128.jpeg",
          "message": [
            {
              "isDeletedParentAction": false,
              "html": "asd",
              "isEdited": false,
              "reactions": [],
              "text": "asd",
              "whisperedTo": [],
              "type": "COMMENT"
            }
          ],
          "previousReportActionID": "3051314194010923703",
          "actorAccountID": 8879888,
          "whisperedToAccountIDs": [],
          "isAttachment": false,
          "reportActionID": "1418134007167197202",
          "person": [
            {
              "style": "strong",
              "text": "Hari Seldon",
              "type": "TEXT"
            }
          ],
          "lastModified": "2024-02-13 16:42:02.560",
          "originalMessage": {
            "html": "asd",
            "lastModified": "2024-02-13 16:42:02.560"
          },
          "timestamp":<PHONE_NUMBER>,
          "actionName": "ADDCOMMENT"
        }
      },
      "key": "reportActions_74984251"
    }
  ]
}

Unable to reproduce now for rooms and threads, using the latest build. Closing


Adding device specific haptic constants for Samsung devices.

These constants should bring better alignment with views rotary experience
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

Failing with
com.google.android.horologist.compose.rotaryinput.HapticsTest > testGalaxyWatch FAILED
    com.google.common.truth.ComparisonFailureWithFacts at HapticsTest.kt:131

com.google.android.horologist.compose.rotaryinput.HapticsTest > testGalaxyWatchClassic FAILED
    com.google.common.truth.ComparisonFailureWithFacts at HapticsTest.kt:119


Automate helm chart publish

In what area(s)?

/area test-and-release

Describe the feature
Automate helm chart publish in release process.

Publish the chart to helmhub

Should we close this bug since we do not want to use ACR anymore?

Yes, this and the PR #1672  can be closed. Work is tracked with https://github.com/dapr/dapr/issues/1676


Move optional features to extensions

This PR is https://github.com/TuringLang/AdvancedMH.jl/pull/81 for AdvancedHMC.

I noticed that the error hint won't work as desired since DiffEqIntegrator will hit step(::AbstractLeapFrog, ...) in integrator.jl, so no error will be thrown. One could e.g. change the type structure to ensure that the default step is not hit by DiffEqIntegrator + keep the error hint or we could e.g. check in the default step function if the first argument is a DiffEqIntegrator, and in this case throw a more informative error. It feels a bit "nicer" to not add a special case to the default step but rather make sure it's never hit, but it seems that would also require more changes.

Test failures are due to a hiccup and some deprecations in the SciML ecosystem. Guess they'll be fixed within the next hours/day.

A few final comments:

I also bumped the Julia compat to 1.6 and added tests for it. The latest release are only compatible with Julia >= 1.6 anyway since, e.g., LogDensityProblems 2 only supports Julia >= 1.6.
I solved the error hint issue (comment above) by defining step in the package only for Union{Leapfrog{T},JitteredLeapfrog{FT,T},TemperedLeapfrog{FT,T}} instead of AbstractLeapfrog.

Are you fine with these changes @torfjelde? Or would you prefer something else?

Are you fine with these changes @torfjelde? Or would you prefer something else?

I'm happy with it, but I would like @xukai92 to chime in as he might have some code that depends on this/know of cases where this would be okay.
Otherwise, I'm very happy with the changes:)


CCF - Keycloak IDP Integration - FE

Below are the task completed
1 ) Login with Keycloak
2 ) Logout with Keycloak
3 ) User creation for both Microsoft and Direct user
4 ) Get User Profile for both cases
In Progress :
Connect to Cloud

Below are the task complete
1 ) Login  with Keycloak
2 ) Logout  with Keycloak
3 ) User creation for both Microsoft and Direct user
4 ) Get User Profile for both cases
In Progress :
Connect to Cloud

dev completed now


queue is not FIFO, but LIFO actually..

Version of go-workers
v0.0.0-20180112190529-dbf81d0b75bb
Details

line.86 in workers.fetcher.go
line.81 in workers.enqueue.go

My concern
I don't know the spec of Sidekiq, but I suspect we should use lpush instead of rpush to be FIFO.
What do you think Mr. @jrallison ?
It looks Sidekiq is actually FIFO  https://github.com/mperham/sidekiq/issues/3420 .

I heard from my co-worker that
fork project of this one has fixed the issue I've mentioned at
https://github.com/digitalocean/go-workers2/pull/5 .


Add stdint compatibility shim for Windows

For Issue #2570
All feedback is welcome. I'm still new to cython development, so please let me know if there is anything I can do better.

Thanks for your first pull request.
But did you verify that the code snippet really gets copied into the generated C file? The docs would suggest that it doesn't.
http://docs.cython.org/en/latest/src/userguide/external_C_code.html#including-verbatim-c-code
Also, in this case, we actually want to avoid that stdint.h gets included on Windows at all, because it simply doesn't exist there for the named C compiler versions. But just a bit further down in the file, the code triggers an include of exactly that file:
https://github.com/cython/cython/blob/2e9c43bdb0206b61aaa2d7e869668750a0201471/Cython/Includes/libc/stdint.pxd#L13
Finally, there are tests for using the declarations of libc.stdint which are currently disabled to avoid test failures on Windows. It is the interest of this change to make exactly this usage work.
$ fgrep stdint tests/compile/*.pyx
tests/compile/libc_all.pyx:#cimport libc.stdint # XXX MSVC
tests/compile/libc_all.pyx:#from libc cimport stdint # XXX MSVC
tests/compile/libc_all.pyx:#from libc.stdint cimport * # XXX MSVC

Thank you for your guidance with this. I appreciate the willingness to help me understand. I'll give it another go.

Is this still needed?


Improving the Accuracy of Duplicate Bug Report Detection using Textual Similarity Measures

By: Alina Lazar, Sarah Ritchey, Bonita Sharif
Department of Computer Science and Information Systems
Youngstown State University
Youngstown, Ohio USA 44555
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Paper Src: http://dl.acm.org/citation.cfm?id=2597088
Data Src:
3 Bug report Datasets

Eclipse 2008
Open Office
Mozilla

Duplicate of #160, but being used as example issue at stage 4a


Severe Main Thread Bottleneck

llama-cpp-python observes a severe bottleneck on the main python thread not otherwise present in llama.cpp
Running a server with llama.cpp directly using
./server -ngl 999 -m models/Meta-Llama-3-8B-Instruct.Q8_0.gguf --port 12345 -c 8192

The typical response speed is 70 t/s
Meanwhile, running a server with llama-cpp-python using
python -m llama_cpp.server --model models/Meta-Llama-3-8B-Instruct.Q8_0.gguf --n_ctx 8192 --n_gpu_layers 999 --port 12345

Results in a mere 35 t/s
This also applies to fatter models. FP16 Llama 3 is 35 t/s in llama.cpp while hitting only 24 t/s in llama-cpp-python. The backend thread block time appears to be consistently very long, resulting in a universal massive performance penalty.
In htop it can be observed that the llama-cpp-python server is completely pegging the main python process, while the GPU remains mostly idle. This is further confirmed by directly reading the kernel driver's GPU busy from
/sys/class/drm/card1/device/gpu_busy_percent

Which reads 99% for llama.cpp and only 55% for llama-cpp-python
Setup is a 7900 XTX GPU with a 7900X CPU @ 6 GHz with all the C libs compiled locally.
Possibly related to https://github.com/abetlen/llama-cpp-python/discussions/1376, at least part of the severe slowdown may derive from the grammar based on their numbers.
Potential duplicate of https://github.com/abetlen/llama-cpp-python/issues/1447, but the numbers presented there are extremely different from my own and without more information I believe there may be different issues at play there.

@Beinsezii thanks for reporting this, I'll take a look, to confirm this is when calling without any grammar constraint correct?
I'll start to look into this but the best way to debug in the past has been via py-spy with the --native flag to get a broad idea of where the thread is spending most of it's time outside of llama.cpp and then using line_profiler to narrow down the exact lines that are causing the issue. Usually it's been an unnecessary dynamic memory allocation that we can usually pre-allocate at the Llama instance level or something like that.

I modified the minimal repro from the grammar discussion and found even without any grammar files loaded, I peak at around 70% GPU busy percent.
from llama_cpp.llama import Llama

def formatMessages(messages):
    prompt = ""
    lastRole = "system"

    for message in messages:
        prompt += message["role"] + ":\n"
        if message["role"] != lastRole:
            prompt += "\n"
        prompt += message["content"] + "\n"
        lastRole = message["role"]

    prompt += "assistant:\n"

    return prompt

llama_model = "/home/beinsezii/Python/llmodels/Meta-Llama-3-8B-Instruct.Q8_0.gguf"

llm = Llama(llama_model, n_ctx=8162, n_gpu_layers=999)

system_prompt = """You are a skilled writing assistant.
Write a story based on the user's prompt
Always output your answer as JSON
"""

messages = [
    {"role": "system", "content": system_prompt},
    {"role": "user", "content": "a story about bees"},
]

# Only 70% GPU
response = llm(
    formatMessages(messages),
    max_tokens=1024,
    repeat_penalty=1.2,
    temperature=1.0,
    top_k=1000,
)

# # Also 70% GPU
# response = llm.create_chat_completion(
#     messages=messages,
#     temperature=0.7,
# )

# # Down to 30% GPU
# response = llm.create_chat_completion(
#     messages=messages,
#     response_format={
#         "type": "json_object",
#     },
#     temperature=0.7,
# )
#

Interestingly when I use the native minimal web interface for llama.cpp's server binary, I'm down to about 70% busy as well. Connecting to that exact same server instance with something like SillyTavern and I can use the full ≈99%. Same with the llama-bench binary. Might be a coincidence but interesting that it's capped at about the same GPU busy %


add install test

basics are simple. just delete the config map entry before travis jspm install

that wouldn't help against a mistake like https://github.com/SpoonX/aurelia-authentication/commit/1b288214359140c882124ceb9927d335d62406d7 . need to think of something else. the original issue made here https://github.com/SpoonX/aurelia-authentication/commit/7de0aa23843e87c2fa639abae22cb161c3f705c6 when setting npm default might not be able to test again anways

thinking about it, unit tests would have picked up my error. so, we just need all those


Fail2ban Filter

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I have followed the guidance on Failed Access Logging. And add
LOG_FAILED_LOGIN_MESSAGE="Failed login for %u"
into .env
I tried several regex but nothing worked.
Anyone can help with setting up the required regex/config to get it working.
Many thanks
Kind Regards
Exact BookStack Version
v23.08
Log Content
[Fri Sep 01 12:33:04.054291 2023] [php:notice] [pid 445356] [client x.x.x.x:58222] Failed login for<EMAIL_ADDRESS>referer: https://bookstack.domain.com/login
[Fri Sep 01 12:33:29.970870 2023] [php:notice] [pid 445358] [client x.x.x.x:60366] Failed login for<EMAIL_ADDRESS>referer: https://boockstack.domain.com/login
PHP Version
8.1.22
Hosting Environment
Debian Bullseye

Hi @wforumw, might be worth reading through #2440.

@wforumw Can you post the fail2ban config files you've got so far? So I can try to see what might not be working.


Updated README.md for labgraph folder;

Description
The installation for labgraph was wrong on the README.md file in the labgraph folder.
Fixes #(issue)
Type of change
Changed from pip install labgraph
To pip install labgraph==2.0.0
Please delete options that are not relevant.

[ ] This change requires a documentation update

Feature/Issue validation/testing
Please describe the tests [UT/IT] that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Unit Test / Integration Test (UT/IT) execution results

Logs

Checklist:

[ ] Have you added tests that prove your fix is effective or that this feature works?
[ ] New and existing unit tests pass locally with these changes?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Is the following an intended change: extensions/graphviz_support/graphviz_support/tests/output/test.svg ?

Hi, the test.svg file must have been unintentionally pushed, it shouldn't be part of the changes, thank you.


WIP Fixes #4091

@rossabaker @yanns  this is still WIP. But I wanted to know if I am on the right track. I have ported 3 files to ce3 - AsyncHttp4sServlet, BlockingHttp4sServlet and Http4sServlet. Would request you to review these 3 files especially the Blocker changes.

@rossabaker @yanns  this is still WIP. But I wanted to know if I am on the right track. I have ported 3 files to ce3 - AsyncHttp4sServlet, BlockingHttp4sServlet and Http4sServlet. Would request you to review these 3 files especially the Blocker changes.


Issue with defvar-local

My previous installation of Merlin worked perfectly, but this time I was trying to install it (with opam) on my OS X El Capitan Version 10.11.6 with GNU Emacs 22.1.1 and when opening emacs I got an error message from merlin.el and merlin-cap.el that defvar-local is not defined. I changed all those functions to defvar, and I don't have any error message anymore.

Yes, we don't try to be compatible with older version of Emacs. Other features might fail.
Try adding this to merlin.el:
(unless (fboundp 'defvar-local)
  (defmacro defvar-local (var val &optional docstring)
    `(progn (defvar ,var ,val ,docstring)
            (make-variable-buffer-local (quote ,var)))))

If it fixes your problem, I might include this has a compatibility stub in later versions.


[Bug]: Widget inside container widgets are added in a different alignment when there is a space in canvas(towards bottom)

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Add container widget
scroll the canvas, so that container widget is not completely visible in canvas
Add any widget inside the container widget
Observe there is alignment issue while adding widget inside container

Environment
Release
Version
Cloud

@somangshu drag drop issue, can you take a look. Priority is high according to me, because user may not be able to identify why this is happening.

Assigning this to @marks0351 , as he is already working on overhauling some DnD logic, that fixes this and few other DnD related issues.


Merge serilog pr

@TimHess almost all of the code we used is dependent on Serilog.Core or DynamicLogger - so ended up renaming to DynamicSerilogCore and adding some tests for coverage. If there is appetite to support for framework I don't see any code moving out of here - since our common abstractions are already either in the serilog or dynamic logger assemblies.