How do I set "data-xxx" attributes on widgets?

I'd like to set a data attribute on widgets, as per https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes
I've tried using create_element('div', {'data-my-prop': 'my value'}, ...) but something in Flexx seems to strip them out.
Any clues?

I wonder whether the way the attribute is set works:
https://github.com/flexxui/flexx/blob/69b85b308b505a8621305458a5094f2a6addd720/flexx/ui/_widget.py#L502
Could be that node.setAttribute is needed.


[bug] left navbar should be static just like the Shippable UI

https://github.com/Shippable/pm/issues/10059

verified on rc


hyper 0.13 support (std futures)

Nb. hyper 0.13 is now out.

I've started flailing at this until the compiler is happy. "cargo build" now succeeds locally with upgraded Rust, tokio, and hyper. "cargo build --features test" doesn't succeed yet, much less an actual "cargo test" run.

Most of the tests now compile and pass. I'm having trouble concatenating a body stream. In particular, this src/chunker.rs code:
    use futures::stream::StreamExt;

    ...

    type BodyStream = Box<dyn Stream<Item = Result<Vec<u8>, ()>> + Send + Sync>;

    // A smaller-than-chunk-size write shouldn't be flushed on write, and there's currently no Drop
    // implementation to do it either.
    #[test]
    fn small_no_flush() {
        let (mut w, body): (_, BodyStream) = BodyWriter::with_chunk_size(4);
        assert_eq!(w.write(b"1").unwrap(), 1);
        w.truncate();
        drop(w);
        assert_eq!(b"", &body.concat().wait().unwrap()[..]);
    }

fails to compile:
error: the `concat` method cannot be invoked on a trait object
   --> src/chunker.rs:131:31
    |
131 |         assert_eq!(b"", &body.concat().wait().unwrap()[..]);
    |                               ^^^^^^
    |
    = note: another candidate was found in the following trait, perhaps add a `use` for it:
            `use futures_util::stream::stream::StreamExt;`

futures 0.3.1 StreamExt::concat
futures 0.1.29 Stream::concat2 (which worked)
Stream (and thus StreamExt) should be implemented here both by the trait object and by its outer Box. It's like it's trying to call concat on the trait object, when I want to call it on the outer box.  I blame jet lag.

There's a https://docs.rs/hyper/0.13.1/hyper/body/fn.to_bytes.html function which might work here.

Hmm, that does work, if I alter the body stream to use Bytes as the data type and BoxedError as the error type so I can convert it to a HttpBody. Still curious why I can't get concat to work like before.
Progress. Gotta get ready for work now though.

Stream (and thus StreamExt) should be implemented here both by the trait object and by its outer Box.

Ahh, turns out it isn't implemented by its outer box because a dyn Stream is not Unpin. It is implemented by a Pin<Box<...>> so I think I just have to use Pin<_>::from(...) on the box to get something I can call these methods on.
I'm glad to have figured this out because there are other methods on StreamExt with the same problem.

Patch below with an unsuccessful attempt to reintroduce InnerBody.
innerbody-attempt.patch.txt
and a key error:
error[E0599]: no method named `poll_next` found for type `std::pin::Pin<std::boxed::Box<dyn futures_core::stream::Stream<Item = std::result::Result<D, E>> + std::marker::Send + std::marker::Sync>>` in the current scope
   --> src/serving.rs:226:39
    |
226 |                 Pin::new_unchecked(b).poll_next(ctx)
    |                                       ^^^^^^^^^ method not found in `std::pin::Pin<std::boxed::Box<dyn futures_core::stream::Stream<Item = std::result::Result<D, E>> + std::marker::Send + std::marker::Sync>>`

Somehow flatten() is able to work with a Pin<Box<dyn Stream<...> + ...>. But I can't call .poll_next() on one. Not sure how to reconcile that.

Hmm, a variation of my code will compile and work:
enum InnerBody<D, E> {
    Once(Option<D>),
    B(Pin<Box<dyn Stream<Item = Result<D, E>> + Sync + Send>>),
}

impl<D, E> Stream for InnerBody<D, E> where D: Unpin
{
    type Item = Result<D, E>;
    fn poll_next(self: Pin<&mut Self>, ctx: &mut futures::task::Context) -> std::task::Poll<Option<Result<D, E>>> {
        match self.get_mut() {
            InnerBody::Once(ref mut o) => std::task::Poll::Ready(o.take().map(|d| Ok(d))),
            InnerBody::B(b) => {
                b.as_mut().poll_next(ctx)
            },
        }
    }
}

it requires the chunk type be Unpin. I think that won't be a problem for callers. I could use self.get_unchecked_mut() to avoid that but I don't understand pinning well enough (yet) to know if that's sound.

I think Unpin is just fine. Actually, using Bytes would probably have been good enough. Sorry I can't meaningfully review your changes otherwise, the whole pinning thing kind of eludes me..
On the topic of benchmarks, you might want to be aware of two issues with tokio::fs:

it limits the buffer size to 16 KB
it's much more slow than in tokio 0.1 right now

For more details, see the linked issues in https://github.com/stephank/hyper-staticfile/issues/24.

I managed to convince myself the unsafe is sound anyway—it's pretty close to the example in the std::pin docs.
Thanks for the pointer to that issue. Since http-serve calls std::io::File methods directly, the buffer size thing isn't a problem, but the contact switches might be relevant.

Published http-serve 0.2.0 based on hyper 0.13.x and friends.


Remove the material design "bloop" from file viewer items

Clicking on the file viewer items doesn't do anything, yet it causes a huge material design "bloop" to occur. It's jarring, especially when nothing else happens.
We should additionally stop this from happening when one of the icons or the menu is clicked.

is this related/duplicate of https://github.com/dandi/dandiarchive/issues/780 since I am not 100% certain I know what the "bloop" is? ;)

I thought that "file viewer" means the new icon to view file, but now I'm not sure. And don't know how to recreate the problem

Note the effect that happens when the file is clicked (the "bloop" :slightly_smiling_face: ).
@waxlamp are you saying the effect should be disabled for files + folders, or just files? It doesn't seem out of place for it to occur when clicking on folders, since that actually performs an action.

IMHO just "doing nothing" is a waste of the UX space -- why not to implement "view" action for files, as suggested/discussed in https://github.com/dandi/dandiarchive/issues/780#issuecomment-885061015  which would be just providing download links but with correct mime types (I guess) for those which we know so browser would open them "natively" (e.g.  a json file within https://gui-staging.dandiarchive.org/#/dandiset/000018/draft/files?location=sub-emmet%2Fses-20180508%2Fanat%2F folder) instead of offering to download.  Or this is not possible?

Sorry for not being clear in my original text; see Mike's comment for what I meant.
I personally don't like the bloop on any of the file viewer items at all, mainly because the file viewer items are not material design buttons. I would like to hear from @jtomeck to either validate or contradict my feeling on this.
@yarik, this is a totally separate issue from the fact that currently nothing happens on click--let's continue the discussion in that issue. Even if we decided something should happen on click, I am very skeptical that the "bloop" should be there alongside it.

I personally don't like the bloop on any of the file viewer items at all, mainly because the file viewer items are not material design buttons. I would like to hear from @jtomeck to either validate or contradict my feeling on this.

I honestly have no strong opinions on the click effect. I don't think I'd think anything was out of place if I had clicked and that happened. I think in calling attention to it in the screencap you inadvertently emphasized it :P. I will say that Vuetify puts that effect on many things, not just buttons. Clickable list items, tabs, menu items. So, I don't think users will bat an eye at it.

Thanks Jared! Ok, let's not worry about the bloop--closing this issue.


Update text (**) in Canadian paragraph 2.1.2

sentence is:
The Joint-Venture fishery
has 100% observer coverage on their processing vessels, which in **2017 made up 6.5% of the
Canadian catch.

This was done a few days ago.. Make sure you're merged

I'm up to date and still see it, maybe it's one of those weird things b/c
I'm caught up to everyone but I see the change on your repo and not
locally.  I'll try merging you again.
On Fri, Feb 8, 2019 at 8:43 AM Chris Grandin<EMAIL_ADDRESS>wrote:

This was done a few days ago.. Make sure you're merged
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/548#issuecomment-461866101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHk_-qjn8dIdkAmoBGGCh6IFPTA5cImnks5vLalCgaJpZM4awdxY
.

--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>

nevermind!  I'm looking at an old version of the draft just now - darn...
On Fri, Feb 8, 2019 at 8:45 AM Aaron Berger - NOAA Federal <
<EMAIL_ADDRESS>wrote:

I'm up to date and still see it, maybe it's one of those weird things b/c
I'm caught up to everyone but I see the change on your repo and not
locally.  I'll try merging you again.
On Fri, Feb 8, 2019 at 8:43 AM Chris Grandin<EMAIL_ADDRESS>wrote:

This was done a few days ago.. Make sure you're merged
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/548#issuecomment-461866101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHk_-qjn8dIdkAmoBGGCh6IFPTA5cImnks5vLalCgaJpZM4awdxY
.

--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>
--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>

silly me


Whats llm observability blog

I believe you are missing the bottom left item here

I believe you are missing the bottom left item here
Maybe "Small text records"

thanks for noticing! Made the following changes:


feat(doc): network architecture

Release Note
feat(doc): network architecture

@oscerd @lburgazzoli wdyt?

Always good to provide more information. I think we should have some kind of best practices collection for camel-k, like tuning and this kind of information. +1. Thanks.


File not generated in webpack with postcss

I have posted a question in stack overflow: https://stackoverflow.com/questions/46865384/postcss-with-webpack
Need your help in finding out what the problem is. Thanks in advance.

{
  test: /\.pcss$/,
  exclude: /node_modules/,
  use: [
    {  loader: 'style-loader' },
    {
      loader: 'css-loader',
      options: {  importLoaders: 1 }
     },
     {  loader: 'postcss-loader' }
  ]
}

 module.exports = {
   plugins: [
    require('precss'),
    require('postcss-simple-vars'),
    require('autoprefixer')
   ]
}


SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'luv_games_categories.PRIMARY'

the error occurs when installing ph7cms in step 4/8
The installation is manual, I downloaded the software and the database was created manually, I have already verified it and it is correct, but it does not allow me to advance from this point.
I tried to do a clean installation 3 times from 2 different hosts thinking that it was the one that had been hired, but the result is the same.
I have been two days and I can not locate the error, if someone can support me.
Thanks
Screenshots / Screencasts

Thank you for reporting this. I will publish a patch in a few hours 😉

Thanks for your comment. could you let me know when the patch is ready

@lual712003 So far, I wasn't able to reproduce your issue.

Do you mind trying again against a fresh new database?
And also with the latest version from the master branch of the GitHub repo.

I am getting the same error regardless trying endless times on mamp / xammp. However, when trying to install using the GitHub files the installation doesn't work either because it needs certain files that are not included on the GitHub version.
My question is,
Where can i download the older version of ph7cms?

I had the same issue. It is that the installer is not installing all the databases. You get about seven installed, I believe it's because you're still using width constraints on Integer type, i.e blah int(10). Can't have the ten part. MySQL??? If you have the problem, just go into myadmin and install everything manually. Look under the project files _install/data/sql/... to get all the databases.

Thanks for the comment but how do i install everything manually?
An example would do
Thanks

Go into your phpmyadmin. You should be able to find it in your cpanel (shared hosting) or login to your mysql console if running on your localhost machine. Look under this repo for the project files  _install/data/sql/[something].sql. Just grab all that code. At the top of the file you'll see @username = 'blahOrSomething'. Change the string portion accordingly for all those @somethings. Most show up in the 'ph7_settings' table so you could just do a search and replace.
Sorry doing this by memory LOL.
Then load that into your database: For phpmyadmin select your database on the right and go to SQL tab and paste that code into the box. On you localhost machine from console(terminal) type : mysql -u [yourusername] -p [yourdatabase] < '/path/to/your/file.sql., On XAMP you might need to do a web search. I haven't used a factory web server in ages.
If you already tried installing you have to delete a file. _contstants.php under your web root and still have your _install file, then go back to where you left off in the install process and finish.
Hope that helps. This is a alright little project but requires a good bit of know how to get working. But can be done.
John - trigsie dot com

Do you mind trying again against a fresh new database?
And also with the latest version from the master branch of the GitHub repo.

thanks to all.
I try different solutions, but without good results.
Digging through the community, I found a comment on the version16.3.2 build, i foud.
and the problem was dissapeared.
thanks for the support


Cisco Version Header string contains characters

that json encoding escapes on and renders incorrectly.
This removes those characters and allows correct encoding.
Signed-off-by: Ethan Kaley<EMAIL_ADDRESS>

@keedya this is a fix from the issue you and @king-jam identified weeks back.

:+1: was tested against a Cisco switch

looks good. Thanks @nucklehead


doc demo: spanish locale doesn't work

Setting locale="es" inside a development example (e.g. light/dev/example-usage.vue) works as expected.
When selecting ES inside the demo the English translation is displayed.

Solved by: 51cab7b9448d25183bddf0b9e09df037f73c8f66
Was probably caused by the @vue-js-cron/core version set inside yarn.lock


[TS migration] Migrate 'TagPicker' component to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31955
Tests

Login into app
Click FAB icon
Select Money Request
Select an amount and go Next
Select a Workspace as a user where to Request money and click Next
Click on Show more
Select Tag
Search for a tag
Verify that Search is working
Select a Tag
Verify that page is working properly and you can request a money

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Login into app
Click FAB icon
Select Money Request
Select an amount and go Next
Select a Workspace as a user where to Request money and click Next
Click on Show more
Select Tag
Search for a tag
Verify that Search is working
Select a Tag
Verify that page is working properly and you can request a money

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@aimane-chnaif conficts resolved

@flodnv comments resolved

@flodnv all fixed 😄

@flodnv I resolved your comments , please take another look when have time 😄

Hi , I will be ooo next week , will take care of that PR when will come back

Hi @flodnv can you recheck this issue?

I did after your ping 2 weeks ago, there's still this to fix above: https://github.com/Expensify/App/pull/36580#discussion_r1525013995

oh sorry I missed it

@flodnv now all its fixed, when you have time you can recheck 😄

Checks are passing.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Console spam

On a server this mod is constantly spamming the console with lines of the form:
List: [BlockPos{x=-32, y=57, z=6}, BlockPos{x=12, y=57, z=-103}, BlockPos{x=-12, y=57, z=5}]
Comp: {linkedPos:[{X:-32,Y:57,Z:6},{X:12,Y:57,Z:-103},{X:-12,Y:57,Z:5}]}
This looks like debugging to me, and it's renders the console hard to use.
Thanks.
Pongo

This looks to have been fixed in the source but not released (at least not for forge/1.20.1). A release would make me happy :)
Pongo

Hey, it was removed for 1.20.4 because that's the current version. Other 1.20.x versions are outdated because 1.20.4 is usually the more recent version of Minecraft.
But I will take a look at it.

Thank you


Rest image

Fixes #17

seems this pr has changes to other activities also, can you update to reflect just the intro to multipart/mime on the rest?


[SPARK-6469] The YARN driver in yarn-client mode will not use the local directories configured for YARN

Clarify the local directories usage in YARN

I don't know if this is normal that all commits show up in the PR, I'm not yet familiar with this tool... Anyway, only the last one is relevant for this PR, and that's what can be seen in the "Files changed" tab.

Test build #29079 has started for   PR 5165 at commit eaaf519.

This patch merges cleanly.

Test build #29082 has started for   PR 5165 at commit 6912b90.

This patch merges cleanly.

Test build #29079 has finished for   PR 5165 at commit eaaf519.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29079/
Test FAILed.

Test build #29082 has finished for   PR 5165 at commit 6912b90.

This patch passes all tests.

This patch merges cleanly.

This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29082/
Test PASSed.

Thanks for providing the pull request. The text here looks good.  I'm +1.  I'll let @srowen finish his review.

Mind changing the title to reflect that this is a documentation fix?

Sure, is the new title ok?

New title looks great to me

LGTM merging this into master thanks.


Turnip generator

Adds a generator for fabrication steps in Turnip.  Pretty much copies the existing cucumber generator wholesale.
The generator supports a single flag for overriding the Turnip step directory.
I had to make a minor, temporary, change to Fabrication::Cucumber::StepFabricator#from_table to accomodate Turnip.  Turnip does not currently support rows_hash (vertical tables) so I added a respond_to? check to fall back on just table.hashes (horizontal tables).  I already have the change for Turnip ready to go to add rows_hash to its table object so this can be nuked once that's pulled into master.  Maybe we leave it in so the contract on the passed in table is weaker (only requires #hashes is defined but will work with #rows_hash if available)?
At this point Fabrication::Cucumber::StepFabricator is actually probably not a very accurate name since it really seems like it supports any framework using Gherkin (Cucumber, Turnip, Spinach, etc) but I did not rename it.

Fabrication has a cucumber test suite that exercises those steps. Can you add similar tests to exercise the turnip code?

Sure, I can do that.  I wasn't sure if you wanted to add Turnip as a dev requirement though.

Yeah, that's fine.
-- Paul
On Friday, November 18, 2011 at 10:13 AM, Brian McManus wrote:

Sure, I can do that. I wasn't sure if you wanted to add Turnip as a dev requirement though.

Reply to this email directly or view it on GitHub:
https://github.com/paulelliott/fabrication/pull/72#issuecomment-2790176

Got the turnip dependency added and running.  Currently having one problem though.  For things to work now you have to run bundle exec rake instead of simply rake.
My best guess as to why is because I needed to point bundler to Turnip's git repo for things to work for now.  I had to do that in the Gemfile instead of the gemspec.  I'm not sure if that's the reason but it's the only thing I can think of.
If you just try to run rake it bombs with:
/Users/bmcmanus/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require': no such file to load -- turnip (LoadError)

Why do you have to point to the git repo for turnip? It should be able to work with the latest released version.
-- Paul
On Friday, November 18, 2011 at 2:03 PM, Brian McManus wrote:

Got the turnip dependency added and running. Currently having one problem though. For things to work now you have to run bundle exec rake instead of simply rake.
My best guess as to why is because I needed to point bundler to Turnip's git repo for things to work for now. I had to do that in the Gemfile instead of the gemspec. I'm not sure if that's the reason but it's the only thing I can think of.
If you just try to run rake it bombs with:
/Users/bmcmanus/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:55:in `require': no such file to load -- turnip (LoadError)

Reply to this email directly or view it on GitHub:
https://github.com/paulelliott/fabrication/pull/72#issuecomment-2792886

Temporary issue.  Don't accept the pull request with it like that.  Using features of Turnip master that aren't in the latest published gem.

Just waiting on Jonas to publish the next version.  Not sure when that will be yet.

I think this is ready to go now.  Latest turnip release (0.3) has everything I was waiting on.  Cleaned up this patch to work with latest turnip version and removed the hack where I had to point at the git repo because the changes I needed were not in a released gem yet.

Just merged these changes into master. Thanks!


Update to sdk

This was simple mechanical changes - the provider functionality is completely untouched, except for 1 simple function replacement due to it being deprecated
I used the guide https://www.terraform.io/docs/extend/plugin-sdk.html to run the migration. I needed to upgrade to the minimum of 0.12.7 of Terraform before starting the migration
The migration check then gave me the following output
$ tf-sdk-migrator check
Checking Go runtime version ...
Go version 1.13.9: OK.
Checking whether provider uses Go modules...
Go modules in use: OK.
Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated...
Checking version of github.com/hashicorp/terraform used in provider...
Terraform version 0.12.7: OK.
Checking whether provider uses deprecated SDK packages or identifiers...
No imports of deprecated SDK packages or identifiers: OK.

All constraints satisfied. Provider can be migrated to the new SDK.

I was then able to run the actual migrate command
$ tf-sdk-migrator migrate
Checking Go runtime version ...
Go version 1.13.9: OK.
Checking whether provider uses Go modules...
Go modules in use: OK.
Checking version of github.com/hashicorp/terraform-plugin-sdk to determine if provider was already migrated...
Checking version of github.com/hashicorp/terraform used in provider...
Terraform version 0.12.7: OK.
Checking whether provider uses deprecated SDK packages or identifiers...
No imports of deprecated SDK packages or identifiers: OK.

All constraints satisfied. Provider can be migrated to the new SDK.

Rewriting provider go.mod file...
Rewriting SDK package imports...
Running `go mod tidy`...
Success! Provider is migrated to github.com/hashicorp/terraform-plugin-sdk v1.7.0.

It looks like this provider vendors dependencies. Don't forget to run `go mod vendor`.
Make sure to review all changes and run all tests.

Thanks for preparing this PR, according to Aivan internal roadmap we will have a green light to migrate to the SDK after merging this PR https://github.com/aiven/terraform-provider-aiven/pull/171, and it is blocked at the moment by some issues on Aiven API side.
Otherwise LGTM, I will ping you/test and review again when the blocker is off the tables.
A bit of a background, many Aiven customers are big enterprises, and we know that it will take time for them to upgrade their Terraform => 0.12.X. Therefore we have a minimum list of features that have to be supported for 0.11.X TF clients, including https://github.com/aiven/terraform-provider-aiven/pull/171.

Converted to draft while it waits for the PR #171

Hi @mteiste / @ivan-savciuc
Just circling back on this now that #171 has been merged and a new release has gone out
Paul

Hi @stack72, can you please update this PR with the latest master? We can move forward with the SDK update.

Hi @ivan-savciuc
Rebased and updated as requested
Paul

Hi @ivan-savciuc
Just checking in :D
Paul

Hi Paul,
Sorry for the delay.
I was on vacation, and also we have been finalizing our new major release strategy for Terraform. Running some final tests, and will come back to soon.
Ivan

Hi Paul,
Sorry for the delay.
I was on vacation, and also we have been finalizing our new major release strategy for Terraform. Running some final tests, and will come back to soon.
Ivan

No worries at all :) I am just checking in. BTW, can I email you direct about the provider? Would be interested in telling you what I am doing with it
Thanks
Paul

Of course, my email<EMAIL_ADDRESS>Ivan


Support instrumentation of express when using ESModules

[x] This only affects the JavaScript OpenTelemetry library

As explained in the docs there is experimental support for projects that use ES Modules as well as a sample app with a http server. This all works great until Node 18.
Using express instead of http doesn't work though. I found a WIP to make express work (stale PR) but it doesn't seem to be completed:
It moans about the module loading order, even though in the sample app @opentelemetry/instrumentation-express is clearly loaded before express.
❯ yarn start-express
yarn run v1.22.21
$ node<EMAIL_ADDRESS>./build/express.js
(node:48798) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
@opentelemetry/api: Registered a global for diag v1.7.0.
@opentelemetry/api: Registered a global for trace v1.7.0.
@opentelemetry/api: Registered a global for context v1.7.0.
@opentelemetry/api: Registered a global for propagation v1.7.0.
@opentelemetry/instrumentation-express Module express has been loaded before @opentelemetry/instrumentation-express so it might not work, please initialize it before requiring express
Applying patch for<EMAIL_ADDRESS>hello!
No modules instrumentation has been defined for<EMAIL_ADDRESS>nothing will be patched
Now listening on: http://<IP_ADDRESS>:3000/

Are there plans in place to support express using esm?
Likely related:

https://github.com/open-telemetry/opentelemetry-js/pull/2846
https://github.com/open-telemetry/opentelemetry-js/issues/4392
https://github.com/open-telemetry/opentelemetry-js/issues/4437
https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1942

Duplicate of https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1849

🎉 I found a working solution here! My project is using esm and I switched my runtime from node to jiti and NOW EVERYTHING JUST WORKS!!!!!!
If we are living in a simulation then this is a complete cheat code 🥷🏼


chore: add version flag to readme file [FTL-9110]

:tada: This PR is included in version 1.63.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


KNX Lights does not work after exception in logs

Home Assistant release with the issue:

Last working Home Assistant release (if known):
Unsure, but might be around 80.0
Operating environment (Hass.io/Docker/Windows/etc.):
Hassbian on RPI3

Component/platform:
https://www.home-assistant.io/components/light.knx/

Description of problem:
The KNX lights stops to work. I assume the error below is related to the lights stop working.
Switching lights on/off does not send any KNX packet- Whole component crashed?
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
knx:
    config_file: "/home/homeassistant/.homeassistant/knx.yaml"
    fire_event: True
    fire_event_filter: ["*/*/*", "0/*/*"]
    state_updater: True

Traceback (if applicable):
Dec 18 06:14:55 hassbian hass[376]: #033[31m2018-12-18 06:14:55 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved#033[0m
Dec 18 06:14:55 hassbian hass[376]: Traceback (most recent call last):
Dec 18 06:14:55 hassbian hass[376]:   File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
Dec 18 06:14:55 hassbian hass[376]:     result = coro.send(None)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/core/telegram_queue.py", line 67, in run
Dec 18 06:14:55 hassbian hass[376]:     await self.process_telegram(telegram)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/core/telegram_queue.py", line 95, in process_telegram
Dec 18 06:14:55 hassbian hass[376]:     await self.process_telegram_incoming(telegram)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/core/telegram_queue.py", line 120, in process_telegram_incoming
Dec 18 06:14:55 hassbian hass[376]:     await device.process(telegram)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/devices/device.py", line 73, in process
Dec 18 06:14:55 hassbian hass[376]:     await self.process_group_write(telegram)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/devices/light.py", line 173, in process_group_write
Dec 18 06:14:55 hassbian hass[376]:     await self.switch.process(telegram)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/devices/remote_value.py", line 79, in process
Dec 18 06:14:55 hassbian hass[376]:     await self.after_update_cb()
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/xknx/devices/device.py", line 33, in after_update
Dec 18 06:14:55 hassbian hass[376]:     await device_updated_cb(self)
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/climate/knx.py", line 135, in after_update_callback
Dec 18 06:14:55 hassbian hass[376]:     await self.async_update_ha_state()
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity.py", line 232, in async_update_ha_state
Dec 18 06:14:55 hassbian hass[376]:     state = self.state
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/climate/__init__.py", line 207, in state
Dec 18 06:14:55 hassbian hass[376]:     if self.current_operation:
Dec 18 06:14:55 hassbian hass[376]:   File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/climate/knx.py", line 198, in current_operation
Dec 18 06:14:55 hassbian hass[376]:     if self.device.supports_operation_mode:
Dec 18 06:14:55 hassbian hass[376]: AttributeError: 'Light' object has no attribute 'supports_operation_mode'#033[0m

Additional information:

@perara : that sounds strange. It looks like a configuration issue. Internally it parses a telegram and delivers this to a light device. But for whatever reason it afterwards calls some climate component.


Add LICENSE

Hi there,
thanks for this awesome library!
Would it be possible to add an Apache V2 or MIT LICENSE?

Oops! Added


(DO NOT MERGE) Change order in which field writers are looked up, fix #361

For one-to-one and one-to-many relationships the writer is looked up
by using findIterableWriter, which will return setter of matching type,
event if there is a setter for scalar matching by field name.
This commit changes the writer lookup to getRelationalWriter and handles
the iterable/scalar cases.

Description

Related Issue
#361
Motivation and Context

How Has This Been Tested?
All tests pass, only change in org.neo4j.ogm.domain.filesystem.Folder was needed - I think the mapping was wrong there in the first place  -
The state of Folder after this line
https://github.com/neo4j/neo4j-ogm/blob/ddb6db5cba707eced487614630b6bf0ad3bc60b0/core/src/test/java/org/neo4j/ogm/persistence/model/DegenerateEntityModelTests.java#L76
is wrong.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Merged to 2.1.x.


CI broken with "An unknown exception has occurred"

Describe the bug
Our CI job does not work anymore with an error which does not help us to find the problem.
"An unknown exception has occurred"
Expected behavior
Throws an error which is understandable and points to the problem or work again.
Device info (if applicable):

OS: Docker node:18
<EMAIL_ADDRESS>
Additional context
The CI Job before with<EMAIL_ADDRESS>had no problems.
WORKING<EMAIL_ADDRESS>$ swa deploy --deployment-token $DEPLOYMENT_TOKEN --env=production ./dist |& tee deploy.log
Welcome to Azure Static Web Apps CLI (1.1.4)
Deploying front-end files from folder:
  /builds/************/dist
Consider providing api-language and version using --api-language and --api-version flags,
    otherwise default values apiLanguage: node and apiVersion: 16 will apply
Deploying to environment: production
Found configuration file:
  /builds/************/static/staticwebapp.config.json
Deploying project to Azure Static Web Apps...
Could not find StaticSitesClient local binary
- Downloading<EMAIL_ADDRESS>[swa] ✔ Downloading<EMAIL_ADDRESS>- Preparing deployment. Please wait...
✔ Project deployed to https://************.azurestaticapps.net/ 🚀
$ cat deploy.log | grep -q "Project deployed to"
Cleaning up project directory and file based variables
00:04
Job succeeded

FAILED<EMAIL_ADDRESS>$ swa deploy --deployment-token $DEPLOYMENT_TOKEN --env=production ./dist |& tee deploy.log
Welcome to Azure Static Web Apps CLI (1.1.5)
Deploying front-end files from folder:
  /builds/************/dist
Consider providing api-language and version using --api-language and --api-version flags,
    otherwise default values apiLanguage: node and apiVersion: 16 will apply
Deploying to environment: production
Found configuration file:
  /builds/************/static/staticwebapp.config.json
Deploying project to Azure Static Web Apps...
Could not find StaticSitesClient local binary
- Downloading<EMAIL_ADDRESS>[swa] ✔ Downloading<EMAIL_ADDRESS>- Preparing deployment. Please wait...
(node:[32](https://************/-/jobs/32489#L32)) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
✖ An unknown exception has occurred
$ cat deploy.log | grep -q "Project deployed to"
Cleaning up project directory and file based variables
ERROR: Job failed: exit code 1

We have fixed the version Azure Static Web Apps CLI to 1.1.4 and the job runs again:
$ swa deploy --deployment-token $DEPLOYMENT_TOKEN --env=production ./dist |& tee deploy.log
Welcome to Azure Static Web Apps CLI (1.1.4)
Deploying front-end files from folder:
  /builds/***********/dist
Consider providing api-language and version using --api-language and --api-version flags,
    otherwise default values apiLanguage: node and apiVersion: 16 will apply
Deploying to environment: production
Found configuration file:
  /builds/***********/static/staticwebapp.config.json
Deploying project to Azure Static Web Apps...
Could not find StaticSitesClient local binary
- Downloading<EMAIL_ADDRESS>[swa] ✔ Downloading<EMAIL_ADDRESS>- Preparing deployment. Please wait...
✔ Project deployed to https://***********.azurestaticapps.net/ 🚀
$ cat deploy.log | grep -q "Project deployed to"
Cleaning up project directory and file based variables
Job succeeded


Tag new release

Could you please tag a new releas? it seems the last commit has support for the new interface but the tagged one is still on: "http-interop/http-middleware": "^0.2.0"

Just tagged 0.3.0 and it should appear on Packagist soon. Thanks for the reminder!


Add setup-depends

This is needed for cabal new-build and should also help for the normal builds if the deps are not already installed.
It is only supported by cabal ≥ 1.24 but the section will be ignored by older versions (although there is a warning) so adding it shouldn’t break the build for anyone.

Thanks! I suppose it's getting time for anew release.


chore: Improve supply chain security for WASM binary

Addresses #17
Overview
This PR refactors the build and deployment pipeline with the aim of mitigating supply chain security concerns relating the the version control / review-ability of the WASM binary.
Motivation
In the current build and deployment pipeline, the SWC source code and compiled WASM are both committed. The release workflow implicitly trusts the WASM binary, without verifying that it is the output of the SWC source code. The compiled WASM code is difficult to review or verify, particularly without re-building from source, which would be somewhat redundant.
As such, a malicious but trusted maintainer (vis a vis the recent XZ exploit) could commit arbitrary WASM code during SWC version upgrades. The malicious WASM can inject arbitrary code into the compiled output, which cannot be detected automatically.
In part because amaro will be / is included as a component of the NodeJS project, the impact of a malicious WASM binary making it into amaro could be wide reaching and severe. This would likely make it a high value target for future social engineering exploits similar to XZ.
Existing Build / Release Workflow
flowchart TD
    A[Copy SWC Source into Repo] -->|commit changes| B
    B[Build WASM Binary] -->|commit changes| C
    C[Raise PR] -->|merge PR| D
    D[Bundle Code] --> E
    E[Release to NPM]

Proposed Solution
Since neither the WASM binary, nor the SWC source code are "owned" by this repo, they do not necessarily need to be version controlled in this repo. This is especially true of the WASM binary, which should be treated as a build output, not as version controlled code. The upstream SWC source code does need to be version controlled, but not necessarily in this repo.
The proposed solution comes in two independent parts.
1. Use submodules for SWC code
flowchart TD
    A[Copy SWC Source into Repo] -->|commit changes| B
    A2[Checkout Upstream SWC Tag] -->|commit changes| B
    B[Build WASM Binary] -->|commit changes| C
    C[Raise PR] -->|merge PR| D
    D[Bundle Code] --> E
    E[Release to NPM]

style A fill:#f99

style A2 fill:#9f9

Instead of copying the SWC code into the repo and version controlling it, we can use git submodules. This somewhat simplifies our update script, and ensures that the SWC code used to compile the binary can't deviate from that in the upstream SWC repo. In my view, this doesn't have a huge impact on supply chain security, and it does have some tradeoffs (discussed below).
2. Build from source when publishing
flowchart TD
    A[Copy SWC Source into Repo] -->|commit changes| B
    B[Build WASM Binary] -->|commit changes| C
    C[Raise PR] -->|merge PR| D
    C[Raise PR] -->|merge PR| A3
    A3[Build WASM from Source] --> D
    D[Bundle Code] --> E
    E[Release to NPM]

style B fill:#f99

style A3 fill:#9f9

Instead of committing the built WASM binary to the repo, it can be built from source when publishing. This means that the built WASM code doesn't need to be verified or reviewed (beyond running automated tests against it). This essentially makes it impossible to publish a modified WASM binary, without changes to the publish workflow, which would hopefully be picked up on review.
1 + 2
Overall, the changes would be something like this:
flowchart TD
    A[Copy SWC Source into Repo] -->|commit changes| B
    B[Build WASM Binary] -->|commit changes| C
    A2[Checkout Upstream SWC Tag] -->|commit changes| C
    C[Raise PR] -->|merge PR| D
    C[Raise PR] -->|merge PR| A3
    A3[Build WASM from Source] --> D
    D[Bundle Code] --> E
    E[Release to NPM]

style A fill:#f99
style B fill:#f99

style A2 fill:#9f9
style A3 fill:#9f9

And the final workflow would look like this:
flowchart TD
    A2[Checkout Upstream SWC Tag] -->|commit changes| C
    C[Raise PR] -->|merge PR| A3
    A3[Build WASM from Source] --> D
    D[Bundle Code] --> E
    E[Release to NPM]

Tradeoffs
Use of submodules
In the current iteration of this PR, we switched from committing SWC source code directly to the repo to using submodules. This has some implications which in aggregate are not overall clear cut good or bad.
One possible issue is on the impact to reviewing upstream SWC code changes. Currently, changes can be easily reviewed in version upgrades, as they are visible in the PR. Using submodules, the changes are still visible (at least in GitHub), but because git doesn't support "narrow clones", the submodule approach means we will see all SWC changes in upgrade PRs (not just those affecting the binding_typescript_wasm crate). This means reviewers need to know which parts of the diff can be safely ignored.
On the other hand, if we commit the parts of SWC we want to the repo, this leaves the door open for subtle modifications to the SWC code, which may be missed on review. Arguably, this is also true of the upstream SWC repo, but when using submodules we benefit from a double review (once in the upstream SWC repo and once in Amaro).
Another impact of using submodules is that we cannot easily "hotfix" SWC. I don't believe hotfixing SWC code in Amaro would (almost) ever be desirable, as they would not benefit from the review of the SWC maintainers, and may be implicitly trusted by reviewers in Amaro. None the less, this is a limitation of submodules which would need to be accepted.

I'd love some feedback on this, but please note the changes are currently only partly tested due to the limitations of my ✈ WiFi.

Can you rebase please, it seems like there are a lot of conflicts

now that versions update are automated by bots, how can someone commit untrusted code? also we use cargo install --locked with cargo-deny

now that versions update are automated by bots, how can someone commit untrusted code? also we use cargo install --locked and checked with cargo-deny

Not 100% sure I follow, sorry! Are you talking about the upstream nodejs:main branch?
If so, I see that there is a GitHub actions workflow to generate a PR to update SWC and the WASM binary. I think this is preferable to manually updating SWC, but I feel that we can do better.
With the proposed changes (this PR), a malicious change would need to be committed as Rust source code to SWC, pass review from the SWC maintainers, and then pass a second review in Amaro, before finally being published.
Currently, since use of the current GHA workflow is not (automatically) enforced, someone could simply raise an update PR manually and include a malicious binary. Hopefully this would be spotted and rejected, but it could be missed.

We have created a standard docker image where we build the wasm and monitor changes with cargo deny.
I think this is enough for our used case since swc also tests for supply chain attacks


Gradle plugin support for adding flutter as subproject to another Android app

This fixes #19818 by ensuring that VM snapshot is copied from artifacts before gradle merges assets.

This should also fix #18101.

@liyuqian What's the reason for the revert? I'm running again in #19818 on current master

@passsy I didn't revert the change here. It's probably a Github revert message bug in https://github.com/flutter/flutter/pull/22872

I confirmed that the relevant change is still in the tip-of-tree flutter/flutter.

I can also confirm that I have the current master and still running into the issue #19818

@passsy @filipproch Are you sure you're seeing the same exact issue? Are you're following the same exact steps outlined in #19818, adding fabric.io, etc?

@sbaranov the error message is the same, the difference is whether I have apply fabric plugin or not. If I comment out the apply, the app launches. I can try to collect more info.

Yeah, we'd need a small example that reproduces the problem for us since we don't know what other things might still be affecting this. For example, are you seeing this problem if you follow the Add-to-App tutorial from scratch, and then only add fabric.io plugin?

Issue still exists in latest master (Flutter (Channel master, v1.2.1-pre.179)


layout_config and layout_strategy being ignored

probably similar to #88, it seems layout_config and layout_strategy are being ignored as well. However, as opposed to path_display in #88, they do inherit the default config – the issue is that you cannot change the frecency picker's config to anything else than the default config.

extensions = {
	frecency = {
		layout_strategy = "bottom_pane",
		layout_config = {
			horizontal = {
				width = 0.4,
			},
		},
	},
},

Same as #88. Fixed.


Design Issue: Web pages look empty with materialize

I noticed that whenever I use materialize my web pages look like they're empty no matter what I do and particularly on desktop. On mobile it looks fine most times but on desktop it almost always looks empty
I really like materialize and want to keep using it and I am wondering if we can change up the design of it to address this problem to make it even better.
I don't know if the color scheme makes it look empty or the container method centers it in too much but I have noticed that it is a problem. Even when I fill the page as much as I can it looks empty.
I have tried the same content with other frameworks and the page looked like it was full enough. With Materialize it looks like its shiny and wacky and I put no effort into it. Even the materialize site looks like its empty even though there is a lot of things in there. I really don't know what it is that makes this happen.
I'm wondering if anyone else knows the problem or how it can be fixed.
Cheers!

Bro, can you post your codepen ?


Add Storage::range_keys and Storage::range_values

This is a first non-breaking change for https://github.com/CosmWasm/cosmwasm/issues/1498

Thanks! Let me rebase this to 1.3 then.


Can't load more than 30 people

When I join any level with more than 30 people, it just doesn't display them

have you tried doing the Packet Limit test in settings? after doing it try reconnecting to the server and see if the issue is resolved.

Yes, I tried. Sadly didn't help...

It's fixed now


Brand image in dark mode

Tested versions

System information

Issue description
Bad branding image in dark mode

Steps to reproduce

Minimal reproduction project (MRP)

It also appears that the font is missing. Perhaps it should be converted to paths, instead?

It also appears that the font is missing. Perhaps it should be converted to paths, instead?

As I understand from commits, font is a part of image

Not sure they will use that image, there are a few different versions of it. :)

Not sure they will use that image, there are a few different versions of it.  Thoughts?

Not sure they will use that image, there are a few different versions of it. :)

Think the white in the first logo is unnecessary

Not sure they will use that image, there are a few different versions of it. :)

I prefer this way. The text is legible both with and without the white outline. But I do believe it's nice to have for other people who use dark mode.

There's some discussion going in #18 about changing the font to pre-redesign Roboto.

There's some discussion going in #18 about changing the font to pre-redesign Roboto.

We have brand kit now

I fixed the temp logo at for the moment. There is a brand kit though, so we'll likely do another pass.


Question on APIS

Hi , I was going through API documentation and postman collection. I only find GET APIs for FHIr resources here.
So does this mean Other CRUD APIs are not supported or are they just missing in postman collection

Hi @vasanthkumar97 -

only find GET APIs for FHIr resources here.
So does this mean Other CRUD APIs are not supported or are they just missing in postman collection

All of the various CRUD APIs are supported (POST for create, PUT for update, DELETE, PATCH, etc).
You are correct that the Postman collection is missing examples of those.  I think adding examples of "update" and "delete" to the Postman collection is a good idea.


Cannot find module is-core-module\index.js While processing metro-react-native-babel-preset

Description
When I execute npx react-native run-android, I get the following error message. To isolate the issue, I tried creating a brand new testing app. This occurs on MS Windows 10 with an Android Emulator and an Android physical device. This problem does NOT occur on macOS with an iOS simulator.
error: index.js: [BABEL] C:\react\Casual_Job\test\index.js: Cannot find module 'C:\react\Casual_Job\test\node_modules\is-core-module\index.js' (While processing: "C:\\react\\Casual_Job\\test\\node_modules\\metro-react-native-babel-preset\\src\\index.js")

React Native Version
0.71.8
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
Memory: 15.82 GB / 31.90 GB
Binaries:
Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
Watchman: 20220614.153706.0 - C:\ProgramData\chocolatey\bin\watchman.EXE
SDKs:
Android SDK: Not Found
Windows SDK:
AllowAllTrustedApps: Disabled
Versions: 10.0.17763.0, 10.0.19041.0
IDEs:
Android Studio: AI-212.5712.43.2112.8512546
Visual Studio: Not Found
Languages:
Java: 11.0.15 - C:\Program Files\Common Files\Oracle\Java\javapath\javac.EXE
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.8 => 0.71.8
react-native-windows: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native init test
cd test
npx react-native run-android

Snack, code example, screenshot, or link to a repository
N/A

The problem was fixed by downgrading Node.js from version 18.16.0 to 18.15.0.

The problem was fixed by executing the following.
npm start -- --reset-cache
rd %localappdata%\Temp\metro-cache /s /q & del %localappdata%\Temp\haste-map* & npm cache clean --force & cd android & gradlew clean & cd .. & rd .\android\build /q /s
rd /q /s C:\Users\Bilal\AppData\Roaming\npm-cache                 ### replace Bilal with your user name
rd /q /s node_modules & del package-lock.json & del yarn.lock
npm install

@Bilal-Abdeen is this happening consistently on every new Windows project?

@cortinico I have tried it around 10 times. I think it happened around 90% (if 100%) of the time. However, I discovered that only clearing the cache npm start -- --reset-cache "might" be enough to fix it. If not, I am almost certain the following would be enough to fix it (rather than the 6 statements I mentioned in my previous comment above.)
npm start -- --reset-cache
rd /q /s node_modules
npm install

More importantly, it seems that the 3 statements above are required after the installation of some libraries. To make it easier for me, I made a batch file for them! I am not sure if only npm start -- --reset-cache would be enough, but I got furious and tired of trying. So, I did not try npm start -- --reset-cache enough times to conclude if it is good enough!


[Question] Data consistency during automated cluster upgrades?

Howdy!
I'm running a few small test-clusters on bare metal to try out kubespray.
During automated kubernetes cluster upgrades, nodes are drained, upgraded, sometimes rebooted, and then uncordoned in pretty quick fashion, which usually means any active replicas on the node in question are marked as Failed in longhorn.
This is obviously not really a problem in testing, but in a production environment where low downtime and data consistency are important, potential data loss if all replicas fail out during upgrades is obviously not ideal.
Is there a way to integrate ansible and longhorn, to allow kubespray to wait for volumes to become Healthy before continuing with a cluster upgrade?
Does Rancher handle in-cluster Longhorn better during cluster upgrades, and would that thus be a better option than kubespray?

There are 2 parts we need to consider in order to maintain the data consistency during the upgrade:

The node the workloads and the volume engine resides on. In this part, the volume engine (it's a process in pod instance-manager-e-xxxxxx) will be restarted along with the workload itself. Hence the data won't be modified in this part. As long as the filesystem is ext4 and this recommended setting is applied, the volume can be reused immediately after the node upgrade.
The nodes that the volume replicas (it's a process in pod instance-manager-r-xxxxxx and it's used to handle data r/w) reside on are upgraded. In this part, all replicas of a volume cannot be shutted down simultaneously. Otherwise, the volume has nowhere to write data then leads to data loss. I think maybe we can use PDB to slow down the node upgrade that contain replicas. But since Longhorn needs some time to recover the volume replica (processes) after the node upgrade and the pod instance-manager-r-xxxxxx reboots, we may need to find a way to control the node upgrade interval so that all replicas can be recovered before the next node upgrade starts.

In general, we need more check and investigation part before providing the formal solution/answer.

Our community member has found a way to coordinate the behavior of drain with Longhorn and Kubernetes, https://github.com/longhorn/longhorn/issues/1631 . We will incorporate that in v1.1.0.


Need to add table and markup text in a same PDF page.

Hi ralf,
Thanks for your pdfbox-layout liabrary.
I need a help, like i want to add table using Boxable in my pdf and some text formatting by using pdfbox-layout, but i am not able to use PDContentStream object on same page which is created by Documnet() constructor. even i saved the pdf file and re read the page and insert table in blank area which created by VerticalSpacer() constructor. but table is not create in that area instead of that it prints on next page.
Please help me on the same.

If you read into other postings on this page you will find, that a free version of iText is favoured instead of redesigning pdfbox-layout.
There is little chance that you will get help or a corrected/enhanced pdfbox-layout file ...
My workaround regarding tables was a column layout with frames and fixes widths of the text elements.
Maybe this can help you ...

Hi @arnthom ! Could you give me a simple example of your workaround? That might help me with dividing the page other then equal width of 50% for each column.

Let's try ...
Here I have a table with 4 columns, the first one is larger than the others.
As you see in writeTable(), you may have to define more columns tha you use, so they will not interfere with the other columns ...
If you set x columns, they will have idetical withs. You can set the width of a column to be larger, so the text will wrap at the column width as you defined it. You may have to set more columns to shift the column to the correct place.
So in your case, you may use three columns and set the width of the first one to 66% of the page width. Then you populate the first and the third comumn with text.
You may experience a "column shift" when a page break occurs. I hope I have set a workaround to that in my approach ...
Good luck!
// Definition of columns
private final String[] texts = new String[] { "", "", "", "", "", };

// Definition of Page
protected float myPageWidth  = new PDPage(PDRectangle.A4).getMediaBox().getWidth();
protected float myPageHeight = new PDPage(PDRectangle.A4).getMediaBox().getHeight();
protected float maxDocWidth = myPageWidth - 100;

private void write() throws IOException {
	add("text col 1", "text col 2", "test col 3", "nothing");
	writeTable()
}

private void add(String toAdd0, String toAdd1, String toAdd2, String toAdd3) {
	texts[0] = texts[0] + toAdd0 + "\n";
	texts[1] = texts[1] + toAdd1 + "\n";
	texts[2] = texts[2] + toAdd2 + "\n";
	texts[3] = texts[3] + toAdd3 + "\n";
}

public void writeTable() throws IOException {
	String[] text = { texts[0], "", texts[1], texts[2], texts[3], "", };
	float[] widths = { maxDocWidth/3, 1, maxDocWidth/4, maxDocWidth/4, maxDocWidth/4, 1, };
	Alignment[] alignments = { Alignment.Left, Alignment.Left, Alignment.Left, Alignment.Right, Alignment.Right, Alignment.Right, };
	writeTable(text, widths, alignments, Color.LIGHT_GRAY, true);
}

public void writeTable(String[] texts, float[] widths, Alignment[] alignments, Color bgColor, boolean border) throws IOException {
	if (texts.length != alignments.length || texts.length != widths.length) {
		throw new Exception("wrong Definition of table: Lenght texts=" + texts.length + " alignments=" + alignments.length + " widths=" + widths.length );
	}
	pArray = new ParagraphExt[texts.length];
	ColumnLayout col = new ColumnLayout(texts.length, 5);
	col.setRemoveLeadingEmptyVerticalSpace(false);
	doc.add(col);
	for (int i = 0; i < texts.length; i++) {
		pArray[i] = getParagraph(alignments[i], widths[i]);
		if (i == 0) {
			try {
  				addMarkup(pArray[i], texts[i]);
			} catch (NoSuchMethodError e) {
				// color does noct work on Java 1.7,
				String text = texts[i].replaceAll("\\{color:#((0)*|(f)*)\\}", "");
   				addMarkup(pArray[i], text);
			}
			FrameExt frame = new FrameExt(pArray[i], new Float(maxDocWidth), null);
			if (border) {
				frame.setShape(new Rect());
				frame.setBorder(Color.BLACK, new Stroke(0.5F));
				frame.setPadding(5, 5, 0, 10);
   				if (bgColor != null) {
   					frame.setBackgroundColor(bgColor);
   				}
			}
			if (border) {
				doc.add(frame);
   			} else {
   				doc.add(pArray[i]);
   			}
		} else {
			addMarkup(pArray[i], texts[i]);
			doc.add(pArray[i]);
		}
		// reset text element
		texts[i] = "";
		if (i < texts.length - 1) {
			doc.add(ColumnLayout.NEWCOLUMN);
		}
	}
	doc.add(new VerticalLayout());
}
    /**
     * ParagraphExt does not split on page break and tries to put the whoöle table on one page
     */
    public class ParagraphExt extends Paragraph {

    	private float neededVerticalSpace;

    	/**    	 */
    	public ParagraphExt() {
    		super();
    	}

    	public void setNeededVerticalSpace(float f) {
    		neededVerticalSpace = f;
    	}

    	// @Override
    	/* (non-Javadoc)
    	 * @see rst.pdfbox.layout.elements.Paragraph#divide(float, float)
    	 */
    	public Divided divide(float remainingHeight, float nextPageHeight) throws IOException {

    		if (neededVerticalSpace > 0) {
        		if (neededVerticalSpace > remainingHeight && neededVerticalSpace <= nextPageHeight) {
        			return new Divided(new VerticalSpacer(remainingHeight), this);
        		}
    		} else {
        		if (getHeight() > remainingHeight && getHeight() <= nextPageHeight) {
        			return new Divided(new VerticalSpacer(remainingHeight), this);
        		}
    		}
    		return super.divide(remainingHeight, nextPageHeight);
    	}
    }
    protected ParagraphExt getParagraph(Alignment alignment, float maxWidth) {
    	ParagraphExt p = getParagraph(alignment);
    	p.setMaxWidth(maxWidth);
    	return p;
    }
    protected ParagraphExt getParagraph(Alignment alignment) {
    	ParagraphExt p = new ParagraphExt();
    	p.setAlignment(alignment);
    	p.setMaxWidth(maxDocWidth);
    	return p;
    }

Alright, thanks!

Just a note on this issue -- I ran into this and was able to use the supplied interfaces in pdfbox-layout (see ImageElement as one example) to draw a boxable table "in-flow" with Paragraphs, ImageElements etc.
Create a class to allow pdfbox-layout to draw the table.
public class TableElement implements Element, Drawable, Dividable, WidthRespecting {

...Implement draw which gives you the object boxable needs:

@Override
    public void draw(PDDocument pdDocument, PDPageContentStream pdPageContentStream, Position position, DrawListener drawListener) throws IOException {

        //todo - add real draw class
        drawTable(pdPageContentStream, pdDocument, position);

        if (drawListener != null) {
            drawListener.drawn(this, position, this.getWidth(), this.getHeight());
        }

    }

    private void drawTable(PDPageContentStream cos, PDDocument doc, Position position) {

        PDFont fontPlain = PDType1Font.HELVETICA;
        PDPage page = doc.getPage(doc.getNumberOfPages()-1);

//do your boxable stuff here and set things like height and width to fulfill interface methods
        BaseTable table = new BaseTable(yPosition, yStartNewPage,
                bottomMargin, tableWidth, margin, doc, page, true, drawContent);

--Scott

@si2-scotth Hello, I've been trying to add a table as an element in the in PDF but I'm unable to. Do you have any example/blog. I need to see your TableElement class and method where you used the above feature. Please help if possible.
Thanks.

@si2-scotth
thanks for the idea. I'm now able to add a table into my pdf. the problem is that after the table is added, I cannot add anything else below it until next page. Can you help me with that?


ghcWithHoogle: fix for ghcjs

@peti haskell.packages.ghcjs.ghcWithHoogle failed because the following line:
  for docdir in ${ghc.doc}/${docLibGlob}/*; do

failed because doc is not an attribute of ghc when ghc is substituted for ghcjs.
Since this problem also exists on 16.09 it would be great if this patch can be cherry-picked on release-16.09.

@peti thanks for the merge! Can we get the fix on 16.09 to please?


Specifying --profile and --release when running cargo rustc doesn't work anymore

Problem
This used to work:
cargo rustc --lib --profile test --release
Now it doesn't:
$ cargo rustc --lib --profile test --release
error: Conflicting usage of --profile and --release

How am I supposed to compile unit tests in release mode through cargo rustc now? I can use --tests, but that will also compile integration tests (which I don't want), and --test $crate_name doesn't work.
Steps

cargo new --lib foobar
cd foobar
cargo rustc --lib --profile test --release

Notes
Version which worked: cargo 1.39.0-nightly (3596cb86b 2019-09-19) (and all of the previous versions)
Version which doesn't work: cargo 1.40.0-nightly (8b0561d68 2019-09-30)
This is a regression from stable to nightly.

cc @da-x

@koute - sorry for the regression. Queued up a fix.

Thanks!
It's nice to see that cargo's handling of profiles is getting cleaned up. However, this definitely needs a deprecation warning so that whoever depends on the current behavior could migrate, and it'd also be great if we made sure that there is no loss of functionality (e.g. the case where I want to compile only the unit tests in release mode, which as far as I can see after your changes becomes impossible?).

@koute. Yes, this was discussed when implementing the PR for the RFC. We may need to gather up these use cases and have special flags for them, or do something else.


Allow toggle ArgoCD sync for enterprise-contract and rekor

Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

@redhat-appstudio/enterprise-contract ptal

Also #434 is of note here. The change in here will require a change in the Tekton pipeline

Also #434 is of note here. The change in here will require a change in the Tekton pipeline

I think this comment was meant to be written in https://github.com/redhat-appstudio/infra-deployments/pull/430.

/retest

/retest

I can't find PipelineRun objects in the must-gather, but based on the chains-controller logs the PipelineRun which we expect to finish within 180 seconds finishes in 201 seconds (2022-06-09T11:11:46.161Z till 2022-06-09T11:15:07.612Z)


soft link does not get correct ownership

When a symlink is created (for example, when using home_dir with :install), the owner is not set on the symlink even when owner is specified.

+1
How to resolve this?


browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); is not working on firefox browser

hi all, can any one help me how to archive this.
when we click on FlyoutAnchor its open the menu items, we need to close that menu items (manually we can close by clicking on parent (FlyoutAnchor) control ), but focus is not coming to FlyoutAnchor because menu items are overlaps the FlyoutAnchor control.
we tried with pressing the escape button by the help of below code, but this code not working on firefox browser (open issue).
browser.actions().sendKeys(protractor.Key.ESCAPE).perform();
can any one help me how to archive this.

Hi @IgorSasovets  Similar issue like mouse move to particulre element is not working on firefox.
browser.actions().mouseMove(element);
can you suggest how to achieve this with out using helpers lib

I tried to do this but didn't find any possible solution. Similar problems I had with mouseDown, mouseUp, dragAndDrop and right click methods. That's why I decided to create custom implementation of Action class functions.

ok @IgorSasovets , how to use this custom implementation of action class for mouseMove to element (we need to move to the element not with coordinates)

If you want to perform DnD action than just take a look at examples. In other case, you can create simple workaround like this:
const location = await tgtElement.getLocation();
await browser.executeScript(helper.mouseMove, {x: Math.floor(location.x), y: Math.floor(location.y)})

Hi @IgorSasovets  i tired your helper to mouse move but looks like it doesn't work in chrome / fireforx also, or may i used the wrong approach, can you please help me house archive this challenge.
i need to add title for the page, it a <span inside the <p tag, i used below element finder to get that span,
this.pageTitleId = element.all(by.css('#WACViewPanel_EditingElement .NormalTextRun')).get(0);

then i used this line of code for sendKeys
browser.actions().mouseMove(this.pageTitleId).sendKeys('Test Hello').perform();
its working fine in the chrome browser. not working in the firefox browser.
then i used ur helper like below but iam getting the error at sendkeys.
var location = this.pageTitleId.getLocation();
browser.executeScript(helper.mouseMove, {x: Math.floor(this.pageTitleId.x), y: Math.floor(this.pageTitleId.y)})
or
browser.executeScript(helper.mouseMove,{ x: 441, y: 192});
getting the below error
Failed: unknown error: cannot focus element
(Session info: chrome=65.0.3325.181)
(Driver info: chromedriver=2.37.544315 (730aa6a5fdba159ac9f4c1e8cbc59bf1b5ce12b7),platform=Windows NT 10.0.16299 x86_64)
firefox
Failed: Element  is not reachable by keyboard

https://github.com/angular/protractor/issues/4757#issuecomment-378381829
Excelente, it was very useful for me.

In firefox browser ,  await browser.actions().sendKeys(protractor.Key.ENTER).perform(); is not working . Is there any way it can work ?


Force mvn to use en_US locale for tests

This would make some float tests fail because of the decimal separator
Fixes: #1969

Thanks!


Not an issue but more a request, is it possible to only select left or right

is it possible to only select left or right and not top, bottom en corners?

@mchendriks
I am currently working on a project where I need this behaviour as well (specify exactly which resize points to be drawn for a specific element).
Thus, I've implemented the feature myself:

you can already use my forked version
maybe my pull request will be merged here too

Enjoy ;)


zh-trans / docs/reference/setup tools/kubeadm/kubeadm config.md

/hold for testing

/hold

@tengqm this is a test PR for demoing the mixed content issue.
Closing it is now.


Source map not correctly generated

#8624 implemented automatic source map detection. Currently, wrong source map is generated. To reproduce, set "rust-analyzer.debug.sourceFileMap" to "auto", then start a debug session with debug lens. Then observe the debug configuration in the debug output pane. You should see the following configuration:
"sourceFileMap": {
  "/rustc/undefined/": "……"
}

Notice the “/rustc/undefined/” path in the configuration. It is an invalid path.

@EFanZh I can't test it right now, but can you give #9882 a try?

Hi @lnicol, I have tested your change, it does seem to work, thanks!


python 2 raise_from behaves incorrectly

On Python 2, raise_from does not "raise from", it just raises. Hence, raise_from is not very useful and is quite confusing as it does not make Python 2 and 3 behave similarly.
I made something that worked better based on six's existing methods:
def raisefrom(exc_type, message, exc):
    if sys.version_info[:2] >= (3, 2):
        six.raise_from(exc_type(message), exc)
    else:
        six.reraise(exc_type, '%s - %s' % (message, exc), sys.exc_info()[2])

We can't really change the behavior of raise_from now, though maybe a new function would be okay. Only question is what to name it. :)

That is indeed a tricky question. Did you come up with a name or were you waiting for me to suggest one?
Whatever it is named will cause confusion because of the similarity of purpose, so I suggest raisefrom (no underscore) with good documentation to explain the difference possibly with a view to deprecating raise_from in the long term.

No, I don't have any great ideas off the top of my head. One aspect of your suggested implementation is that it only works within an except block. That needs to be clear to users.

I think better not to call existing functions which may change but implement fresh like this:
if sys.version_info[:2] == (3, 2):
    exec_("""def raisefrom(exc_type, message, from_value):
    value = exc_type(message)
    try:
        if from_value is None:
            raise value
        raise value from from_value
    finally:
        exc_type = None
""")
elif sys.version_info[:2] > (3, 2):
    exec_("""def raisefrom(exc_type, message, from_value):
    value = exc_type(message)
    try:
        raise value from from_value
    finally:
        exc_type = None
""")
else:
    exec_("""def raisefrom(exc_type, message, from_value):
    try:
        raise exc_type, '%s - %s' % (message, from_value), sys.exc_info()[2]
    finally:
        exc_type = None
""")

@benjaminp I have made a PR for the new function: https://github.com/benjaminp/six/pull/217


Fix wrong classname in "Word Count" exercise

I think we are using the wrong class name in the unit tests. it should be WordCount, not Phrase.

In the test file, there is require_relative 'word_count' line
The name of the class in the test is: WordCountTest

So there is no reference to Phrase in any place

Though you would be correct to associate the patterns, this is indeed
correct.  But, we could bring it up in
exercism/problem-specifications
where this exercise name and file name are determined.
However, there is nothing so far that states "The exercise title and the
code solution must match directly in name".
And so this is OK, and as designed.

Also, there is a reference to Phrase when the tests first start, via
the exception that is raised.  Also, congratulations on learning that
the test class does not have to exactly match a class that exists in the
code being tested, as you have noted.
This is a practice exercise, and so learning from the tests as much as
from the exercise itself is a good thing.
This could be mentioned in the Instructions as a learning point, maybe.
I don't know.
With it matching, though, it does make it simpler to make the generators
work.  So it might be worthwhile bring up in the "canonical" repository,
mentioned in my prior message.

Thanks, @kotp 👍🏼

No, thank you @AngelGallegosE .  I hope to see you around again!  Thank you for the work. As an aside, though this was a simple patch, it might be helpful to raise an issue before the work is done to find out if it is something that needs to be addressed.
That said, it is good practice doing the patch in itself.  So really nothing lost.  And now we also have a reference for if this comes up in another exercise and a change is thought needed.  (We might later decide that it makes sense to make the change, then we could re-open this and apply it, after all!)


Add 'gray' US english spelling to TerminalColor

As per https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#naming

Prefer US English spellings. For example, 'colorize', not 'colourise', and 'canceled', not 'cancelled'.

Any reason not to just swap gray for grey? It doesn't look like this would be an internal breaking change.

We could just do the full swap, this was meant to be the simplest change to get 'gray', the full swap would touch a lot more files, I can do that if you would prefer!

We could just do the full swap, this was meant to be the simplest change to get 'gray', the full swap would touch a lot more files, I can do that if you would prefer!

Yeah, I would prefer a straight up find & replace. Thanks!

Closing due to preference of these two spellings is more ambiguous than initially thought.


[resign] fix app entitlements extraction

Fix the way app entitlements are extracted (see https://github.com/fastlane/fastlane/pull/18713)
Homogenise sed invocations (following https://github.com/fastlane/fastlane/pull/17075)

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass → N/A
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid → N/A
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary. → N/A

Motivation and Context
https://github.com/fastlane/fastlane/pull/18713 allowed resign --use-app-entitlements to handle entitlements that were ignored before.
Due to the very long time this PR (and its ancestors) took before being accepted, one of the initial changes seems to have been lost in the multiple merge attempts.
This leads to an issue when using --use-app-entitlements to resign an app having iCloud capability.
This fix resolves this remaining issue related in #18713.
Description
The way resign.sh extracts app entitlements have always been faulty (headers are not removed as expected due to sed limitations), but this went unnoticed as plutil is permissive enough to ignore them subsequently.
However, these unexpected headers break a new entitlement patching method introduced by #18713.
As sed cannot handle the single-line-mode regular expression used to extract entitlements, this change removes newlines before calling it (entitlements being made of basic XML elements, newlines can be safely removed).
Also, this change homogenizes sed calls and follows #17075 by adding the full path of the system sed command to all sed invocations.
resign is the ugly duckling of Fastlane, it is based on a decade-old shell script and comes with no automated tests.
Though, resigning with these changes have been tested by myself and @csc-EricWu (see https://github.com/fastlane/fastlane/pull/18713#issuecomment-854966645).

@joshdholtz, this very simple PR fixes an issue introduced by #18713, may you have a quick look at it?

You’re welcome. Thanks a lot for this express validation!


GZip and GUnzip could have options to not delete the original file, and/or to rename the output file

Would require changes to the underlying FileUtilities methods to add parameters.

The majority of the work seems to be in GZip.java and GUnzip.java, which need to have a lot more command-line processing for this. Just begging for more work in the Options class to support it.


SBE_NOEXCEPT

Currently C++11 generated code every header has the following
#if __cplusplus >= 201103L
define SBE_CONSTEXPR constexpr
define SBE_NOEXCEPT noexcept
#else
define SBE_CONSTEXPR
define SBE_NOEXCEPT
#endif
Is there a way to disable SBE_NOEXCEPT during generation in case we want exceptions thrown for bad corrupt messages sent ?
Thanks
Sam

The issue here is when bad/corrupt data is parsed by SBE generated method in the header and it is declared with noexcept and throws exception that causes the app to terminate (throwing exception violates noexcept and calls std::terminate)
We want to be able to catch exceptions for bad data rather than terminate the app. Hence need the ability to optionally remove SBE_NOEXCEPT during generation.

Could you please show generated method with noexcept which throws exception?

Here is an example from one of our developers for the following schema snippet
<enum name="PriceType" encodingType="uInt8NULL">
        <validValue name="Limit" description="Limit">1</validValue>
        <validValue name="Market" description="Market">2</validValue>
        <validValue name="Default" description="Default">10</validValue>
</enum>

<sbe:message name="OrderSpecSubmitRequest" id="1004">

</sbe:message>
static PriceType::Value get(const std::uint8_t value)
{
switch (value)
{
case 1: return Limit;
case 2: return Market;
case 10: return Default;
case 255: return NULL_VALUE;
}
throw std::runtime_error("unknown value for enum PriceType [E103]");
}
SBE_NODISCARD PriceType::Value price_type() const SBE_NOEXCEPT
{
std::uint8_t val;
std::memcpy(&val, m_buffer + m_offset + 32, sizeof(std::uint8_t));
return PriceType::get((val));
}

Apologies. It turns out the above code was generated with 1.14.1 jar.
This is now fixed when generated with latest <IP_ADDRESS> jar.
Thanks for your patience.


update go.mod and import paths

After changing the name of the repo from openssl-fips to simply openssl we must also update the go.mod file and import paths to ensure everything continues to build correctly.

@derekparker I think it still makes sende to merge this PR. #72 targets the wip combined branch, this PR targets master.


2020 ChatOps User Survey Results

Question 2

Question 3

Question 4

Question 5

Question 6

Other responses:

Busy with other priorities

We use a Matrix based chat platform which I don't think StackStorm supports. We also have limited resources to devote just to implement chatops

Not convinced ChatOps in general is a good operational model

We are using Microsoft Teams. And we have a barrier of house rule about security. When we use chatbot, we have to break the barrier.

Terrible chat tools.

Question 7
What chat application/s do you use that are not supported?
Microsoft Teams
Question 8

Question 9

Question 10

Other responses:

Operation

Change control ; Information Access for field crews

Helpdesk

Trigger custom application workflows on demand that can reduce toil

Company-wide incident management, and intra-team assistance.

Question 11

Other responses:

Comunication by StackStorm

Disabled pending an access control solution.

Mainly reporting triggered actions into Slack, quasi-logging style.

Notifications

Inquiries and responding via slack

Working on integrating our own BotKit framework so we can utilize Slack forms with action-aliases.

Question 12

Other responses:

Provide simplistic access to items in 3rd party APIs - eg. who is oncall in PD

OpsGenie notifications / stage database refresh and app restart

Start video meetings, create documents from a template, page teams by name, manage alias notifications (on/off)

Allow tier 1 support to run an Ops process (an ansible playbook) that updates config at a customer location.

Question 13

Question 14

Question 15
Summary: Slack and Microsoft Teams

Question 16

Other responses:

More straightforward/easier MSTeams

If not RBAC, at least some kind of manual user whitelist

Interactive aliases

Utilize / (slash) commands in slack rather than though hubot

Better chatops support for Webex Teams, EWC released to the wild and a key to support the installation

Better control over output (paging, maximum message size, text formatting respected for paged output.)

MS Teams

Permitting and restricting different aliases per Slack channel (may get this with better RBAC integration)

Question 17

Question 18
What does StackStorm get right with its existing ChatOps implementation?

Slack integration and configuration
User-defined ChatOps is useful
It's easy to write and run action aliases
ChatOps and workflow notifications are nice
ChatOps just works
Modularity
Notifications and customization of action aliases
Chat provider agnostic
The ability to interact with ChatOps in the middle of a workflow and respond via ChatOps
Action aliases make it easy to be DRY

Question 19
What does StackStorm get wrong with its ChatOps implementation?

No RBAC for ChatOps
Inquiries are difficult, and interactivity is limited
Microsoft Teams configuration is difficult and integration is not good
Third party plugins are sometimes unmaintained or unresponsive, which makes it difficult to get pull requests merged to fix bugs in hubot-stackstorm.
ChatOps should be written in Python
Action alias formatting isn't simple and robust
Lack of two-way communication with the user (trying to remember formatting is difficult for some users)

Question 20
Is there anything we should do to make it easier to use ChatOps with StackStorm?

Support RBAC in ChatOps, or a simple "user whitelist" access control at a bare minimum
Improve quality and quantity of examples and documentation; possibly a beginner's guide
Rewrite ChatOps in Python
Better Microsoft Teams integration
Better support for interactivity, including inquiries
Better Webex Teams support
Auto-parse actions so any action can be used without special config
Allow for inquiries to be sent to users to gather the information [note: I believe this refers to when ChatOps users don't know a full command, so ChatOps should query for the missing commands]

Question 21
Is there anything we absolutely should NOT do regarding ChatOps in StackStorm?

Inquiries are complex

Don't drop support for ChatOps! This is a main driver of ST2 within an organization

Do not use BotFramework for anything else. Microsoft Teams is bad enough.

Question 22
Would you be willing to help us refactor, redesign, develop, or test new ChatOps features?
Summary: Mostly yes.
Question 23
Would you be willing to have a deeper discussion with us about your ChatOps use case/s?
Summary: Half yes, half no.

Based on users feedback we know that people really want the StackStorm ChatOps RBAC.
There is more new data that was interesting to find:

ChatOps is known to be used in relatively small groups. However data reported that ChatOps is starting to be adopted in 1K or bigger orgs. I mean this is happening. Previously almost everyone from the bigger corps I've talked with told "It's a toy, it doesn't work" about it. With improvements like better Security, RBAC, channel restrictions and more we could make the adoption easier for the bigger players to use StackStorm ChatOps. This could be a new driving factor getting the corp support.
There is still a huge number of people/orgs "Who never tried ChatOps". That's promising as new potential group to explore.
NLP idea didn't find good support. I guess It's hard to reliase NLP chatops benefits in infra/operations context where clear command instructions are essential.
Microsoft Teams is more important than we think. There were a lot of pain points on this side with the  st2chatops due to technical reasons. Wondering how that could be improved.
Surprisingly, ChatOps sometimes could be the main driver for using ST2 as a platform. Digging deeper into Analytics, - chatops was the major traffic source for docs.stackstorm.com for many years. It's a shame we couldn't use that properly during some past years.
I also noticed that really good number of people are happy to help us moving the ChatOps story forward: refactor, redesign, develop, test. This is very inspiring and I hope we could engage chatops advocates from StackStorm Community more.

@StackStorm/maintainers @StackStorm/contributors  What are other's observations based on this this Survey? Please share.


The integration fails to setup if soundbar is offline

Hey there,
Just wanted to flag an issue with the integration. If the soundbar is offline when Home Assistant is restarted the integration fails to set up. It’s a bit of a pain because we have to manually restart Home Assistant or the integration to get things back up and running.
It’d be cool if the integration could just mark the soundbar as ‘unavailable’ and keep going, checking now and then to see if the soundbar’s back online.
I’ve attached the error message from the log below. Hope this helps!
Cheers!
2024-03-05 05:56:46.507 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry samsung_soundbar for samsung_soundbar
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/samsung_soundbar/__init__.py", line 50, in async_setup_entry
await soundbar_device.update()
File "/config/custom_components/samsung_soundbar/api_extension/SoundbarDevice.py", line 49, in update
await self._update_soundmode()
File "/config/custom_components/samsung_soundbar/api_extension/SoundbarDevice.py", line 69, in _update_soundmode
await self.update_execution_data(["/sec/networkaudio/soundmode"])
File "/config/custom_components/samsung_soundbar/api_extension/SoundbarDevice.py", line 363, in update_execution_data
return await self.device.command("main", "execute", "execute", argument)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pysmartthings/device.py", line 842, in command
response = await self._api.post_device_command(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pysmartthings/api.py", line 147, in post_device_command
return await self.post(API_DEVICE_COMMAND.format(device_id=device_id), data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pysmartthings/api.py", line 395, in post
return await self.request("post", self._api_base + resource, data=data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/pysmartthings/api.py", line 376, in request
resp.raise_for_status()
File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1060, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 409, message='Conflict', url=URL('https://api.smartthings.com/v1/devices/0f97098c-9bc0-9006-8519-30d00620b51f/commands')

Hi @diegocjorge,
Im currently on vacation but will take a look at it as soon as I am back and have some free time.
The issue definitely makes sense, and I think that I also saw that in my end.
There are a few things that I wanna check, especially whether the 409 while fetching the "extra" capabilities is due to the soundbar being offline :)

Hi @diegocjorge
I suspect your issue to be similar to #13, as having the soundbar disconnected from wifi / completly powered off (plugged out) will probably look the same for the SmartThings Api.
I added the ConfigEntryNotReady exception in the setup process to let HomeAssistant start a retry process. I still have to test it out tho.

Cool, thanks!


Use default K8s version supported by AKS for cloud CI

This will fix the AKS CI failure caused by the Sonobuoy version increase
See https://jenkins.antrea-ci.rocks/view/cloud/job/cloud-antrea-aks-conformance-net-policy/80/console

@lzhecheng I don't know if jq is already available on the Jenkins worker. Could you install it otherwise?

Codecov Report

Merging #1701 (b73a5a1) into master (9d3d10b) will decrease coverage by 22.85%.
The diff coverage is 37.07%.

@@             Coverage Diff             @@
##           master    #1701       +/-   ##
===========================================
- Coverage   63.31%   40.46%   -22.86%
===========================================
  Files         170      107       -63
  Lines       14250    13322      -928
===========================================
- Hits         9023     5391     -3632
- Misses       4292     7452     +3160
+ Partials      935      479      -456

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.46% <37.07%> (-0.81%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

pkg/agent/agent.go
12.20% <0.00%> (-36.51%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/agent/cniserver/interface_configuration_linux.go
5.79% <0.00%> (-14.44%)
:arrow_down:

pkg/agent/cniserver/pod_configuration.go
34.52% <0.00%> (-19.24%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
32.57% <0.00%> (-13.90%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-82.70%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/querier/querier.go
66.66% <0.00%> (-21.50%)
:arrow_down:

... and 165 more

Thanks @Dyanngg. I triggered a build and if it passes I'll merge the PR.

/skip-all

Jenkins job for AKS succeeded, ignoring Kind failure


fqdn: Add configurable response delay to DNSProxy

We've seen instances where the propagation of IPs from DNS responses
into the datapath is slower than the subsequent connection. This can
cause races with the CT table. Unfortunately, we have also seen cases
where delaying the response until after the data has been plumbed
results in the opposite problem: the DNS response is considered lost and
the app retries, causing repeat failures and more load.
While not ideal in the least, allowing for a tunable response delay
allows us to tweak this behaviour to some extent, minimizing the
disruption of either extreme.

This change is

test-me-please

test-me-please

Coverage increased (+0.02%) to 44.304% when pulling<PHONE_NUMBER>f33c9973380987577e471f99ea104d on raybejjani:fqdn-delayed-response into 74b517bcc20fb71a0978cbe14824f3fdfe02793a on cilium:master.

@raybejjani Can this be closed?

Closing, this was resolved by #9208


jedis support R/W Splitting?

I fould jedis connect to redis-cluster just by master server,it doesnot support R/W Splitting? why? Do u plan to add this feature in future?

Welcome to open source world!
If some of features are not implemented, there could be various reasons,

author's intention : You can ask the reasons to not adding the feature. But you should ask it from mailing list so other contributors can discuss the benefit. Please refer https://github.com/xetorthio/jedis/blob/master/CONTRIBUTING.md for more details.

author doesn't have time to implement : It's time to be a contributor!
You can request author to implement it, but I don't recommend you to just wait and get.
Because most OSPs don't get supported by companies which means author maintains the project using his/her leisure time.

We don't have the time to look into #988 which should be resolved before splitting R/W. Personally I don't like accessing slaves because Redis Cluster doesn't do failover slave nodes, but if someone implements it, I'm happy to support it.


WIP: fix mouse visual mode selection issues

Viusual mouse selection mode doesn't work properly on master, the initial click doesn't appear where it's supposed to.
This patch fixes that.

I gave this a go. This only has any effect with mouseSelectionStartVisualMode, right? I wonder, wouldn't it make sense to allow expanding an (existing) visual selection without this setting enabled?

Yes, the changes here are only for that setting. Yeah, I think it could be the default, it's probably behind a flag because it's pretty broken.

@justinmk Could we leverage nvim API to expand selection of visual mode with mouse? I'm thinking of entering visual mode with v and then clicking somewhere. I'm not aware of a click event with line/column in Vscode API though.

Related https://github.com/vscode-neovim/vscode-neovim/pull/1043.