Ensure unbind action is always available on request

Caching is still left in place to defer the overhead to a potentially asynchronous load operation. But as we've found, there's a chance UnbindAllBindables can be called while a load is also running, and in such cases we want to be assured that the unbind action still runs.
master:

Method
Mean
Error
StdDev
Median
Gen 0
Allocated

TestBaseline
0.0018 ns
0.0073 ns
0.0061 ns
0.0000 ns
-
-

TestCompositeDrawable
2,075.5773 ns
21.8103 ns
17.0280 ns
2,075.6587 ns
0.1450
1,680 B

TestContainer
2,243.6053 ns
23.6792 ns
20.9910 ns
2,245.7282 ns
0.1488
1,752 B

TestTypeNestedComposite
2,412.0879 ns
20.9093 ns
19.5586 ns
2,417.2321 ns
0.1450
1,680 B

this PR:

Method
Mean
Error
StdDev
Gen 0
Allocated

TestBaseline
0.0000 ns
0.0000 ns
0.0000 ns
-
-

TestCompositeDrawable
2,107.0397 ns
30.1856 ns
28.2356 ns
0.1488
1,712 B

TestContainer
2,320.3007 ns
16.9093 ns
13.2017 ns
0.1526
1,784 B

TestTypeNestedComposite
2,422.2889 ns
12.8755 ns
10.7516 ns
0.1488
1,712 B

The extra allocation overhead comes from the Action<object> inside the getUnbindAction implementation, but I don't think it's too important. Performance different is small enough to be within error margins.

With my commit above:
Before:

Method
Mean
Error
StdDev
Gen 0
Allocated

TestBaseline
0.0000 ns
0.0000 ns
0.0000 ns
-
-

TestCompositeDrawable
2,718.5841 ns
16.9034 ns
15.8115 ns
0.0191
1,744 B

TestContainer
3,020.8970 ns
33.6598 ns
31.4854 ns
0.0191
1,816 B

TestTypeNestedComposite
3,111.6984 ns
30.8866 ns
27.3802 ns
0.0191
1,744 B

After:

Method
Mean
Error
StdDev
Gen 0
Allocated

TestBaseline
0.0000 ns
0.0000 ns
0.0000 ns
-
-

TestCompositeDrawable
2,684.0064 ns
11.7135 ns
10.3837 ns
0.0191
1,680 B

TestContainer
2,950.6035 ns
14.5887 ns
12.9325 ns
0.0191
1,752 B

TestTypeNestedComposite
3,166.6835 ns
22.7095 ns
21.2425 ns
0.0191
1,680 B

I honestly don't know whether optimising this has been worth it at all, given the number of issues and time investment in fixing those issues as a result. So if this doesn't work then I propose we revert to the known "working" version.

The original optimisation was due to a considerable overhead in actual game runtime, so I would argue it is worth it.


[Android] Use templated reads and writes

Problem

Android read/writes don't support nullable/optional.

Change overview

Use templated reads and writes. Read callback/write parameters can be annotated as @Nullable or return an Optional (in practice this is not generated yet).
Add helper if_in_global_responses, which allows us to reuse basic type read callback classes (e.g. CHIPBooleanAttributeCallback), while generating a custom callback class for types that are not covered by the global responses.
The cluster interaction tool will not work on invocation for nullable/optional reads and writes, but this PR is already big so would prefer to fix this in a separate PR.

Testing

Manually tested with TestCluster.

fast track: platform specific change created by platform owner.
@austinh0 - merge conflicts


os: Should UserHomeDir match UserCacheDir?

os.UserHomeDir will be new in Go 1.12, added in https://golang.org/cl/139418 with the signature func UserHomeDir() string.  The existing function UserCacheDir has the signature func UserCacheDir() (string, error).  Should we change UserHomeDir to return an error as UserCacheDir does?

My vote is yes. Originally UserCacheDir returned a string but an empty string could lead to bugs that are hard to track down. I'm happy to send a CL if that's what we'd like to do.

I think an error makes its use kinda tedious.
I'd prefer to just return "/" if the env is unset and let things fail with a permission error later.
But I don't object if everybody else prefers an error.

One benefit of not returning an error: that allows for flag definitions to easily default to a location relative to $HOME:
var configPath = flag.String("config",
  filepath.Join(os.UserHomeDir(), ".config", "i3"),
  "path to write configuration file to")

Of course, the above expression is not portable and should probably be replaced by os.UserConfigDir, which should respect $XDG_CONFIG_DIR on Linux? :)
Aside from that, I agree with @bradfitz in that $HOME is so rarely unset that not caring much about that case is an okay trade-off, and users who work in such strange environments will easily be able to make the connection between the error and the lack of a $HOME variable.
What about returning "$HOME is unset"? That way, the error message would be “plumbed through”.

What about returning "$HOME is unset"? That way, the error message would be “plumbed through”.
At that point we should just return an error in my opinion.

That said, I don't know enough about the circumstances of when $HOME would not be set (and whether this is a valid error condition). My vote was for API consistency going forward.

Discussed with @bradfitz and @andybons. The missing error was mainly for convenience but hopefully the work on error handling will address that instead of losing the ability in the API to tell whether it succeeded.


OS X 10.10 Yosemite dark menu bar

Please support the dark menubar on OS X 10.10 Yosemite.

Any idea when that next release will be? I am also on 1.5.4. Maybe a nightly build or alpha that has it?


Server Crash after a tournament starts

Hi! I hope you are well, I have a problem with the plugin, I use the latest version of the plugin and paper 1.20.1, the mysql does not work, it throws errors in the console and after starting a tournament or sometimes after finishing the server crashes and he falls.

I noticed a similar behaviour after a manually ran competition on last version, with the following error (Server seems to time out, but see that part of the timeout yourself):
[21:13:42] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-193 (MC: 1.20.1) --- [21:13:42] [Paper Watchdog Thread/ERROR]: The server has not responded for 10 seconds! Creating thread dump [21:13:42] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:42] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!): [21:13:42] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:42] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread [21:13:42] [Paper Watchdog Thread/ERROR]:     PID: 41 | Suspended: false | Native: false | State: RUNNABLE [21:13:42] [Paper Watchdog Thread/ERROR]:     Stack: [21:13:42] [Paper Watchdog Thread/ERROR]:         java.base@17.0.9/java.lang.String.substring(String.java:2682) [21:13:42] [Paper Watchdog Thread/ERROR]:         org.bukkit.configuration.MemorySection.get(MemorySection.java:271) [21:13:42] [Paper Watchdog Thread/ERROR]:         org.bukkit.configuration.MemorySection.getBoolean(MemorySection.java:376) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.doingExperimentalFeatures(MainConfig.java:234) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.databaseEnabled(MainConfig.java:45) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.handleRewards(Competition.java:699) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.end(Competition.java:113) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.processCompetitionSecond(Competition.java:155) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.decreaseTime(Competition.java:209) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.access$000(Competition.java:28) [21:13:42] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition$2.run(Competition.java:136) [21:13:42] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) [21:13:42] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) [21:13:42] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer$$Lambda$4673/0x00007f38e4a33b68.run(Unknown Source) [21:13:42] [Paper Watchdog Thread/ERROR]:         java.base@17.0.9/java.lang.Thread.run(Thread.java:840) [21:13:42] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:42] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH --- [21:13:42] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:47] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-193 (MC: 1.20.1) --- [21:13:47] [Paper Watchdog Thread/ERROR]: The server has not responded for 15 seconds! Creating thread dump [21:13:47] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:47] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!): [21:13:47] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:47] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread [21:13:47] [Paper Watchdog Thread/ERROR]:     PID: 41 | Suspended: false | Native: false | State: RUNNABLE [21:13:47] [Paper Watchdog Thread/ERROR]:     Stack: [21:13:47] [Paper Watchdog Thread/ERROR]:         java.base@17.0.9/java.lang.String.substring(String.java:2682) [21:13:47] [Paper Watchdog Thread/ERROR]:         org.bukkit.configuration.MemorySection.get(MemorySection.java:271) [21:13:47] [Paper Watchdog Thread/ERROR]:         org.bukkit.configuration.MemorySection.getBoolean(MemorySection.java:376) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.doingExperimentalFeatures(MainConfig.java:234) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.databaseEnabled(MainConfig.java:45) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.handleRewards(Competition.java:699) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.end(Competition.java:113) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.processCompetitionSecond(Competition.java:155) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.decreaseTime(Competition.java:209) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.access$000(Competition.java:28) [21:13:47] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition$2.run(Competition.java:136) [21:13:47] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) [21:13:47] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) [21:13:47] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer$$Lambda$4673/0x00007f38e4a33b68.run(Unknown Source) [21:13:47] [Paper Watchdog Thread/ERROR]:         java.base@17.0.9/java.lang.Thread.run(Thread.java:840) [21:13:47] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:47] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH --- [21:13:47] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:48] [Async Chat Thread - #4/INFO]: -=Citybuild=-Diamond-Enderknight_23: und was bekomme ich jetzt? [21:13:52] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-193 (MC: 1.20.1) --- [21:13:52] [Paper Watchdog Thread/ERROR]: The server has not responded for 20 seconds! Creating thread dump [21:13:52] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:52] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!): [21:13:52] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:52] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread [21:13:52] [Paper Watchdog Thread/ERROR]:     PID: 41 | Suspended: false | Native: false | State: RUNNABLE [21:13:52] [Paper Watchdog Thread/ERROR]:     Stack: [21:13:52] [Paper Watchdog Thread/ERROR]:         org.bukkit.configuration.MemorySection.getBoolean(MemorySection.java:376) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.doingExperimentalFeatures(MainConfig.java:234) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.config.MainConfig.databaseEnabled(MainConfig.java:45) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.handleRewards(Competition.java:699) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.end(Competition.java:113) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.processCompetitionSecond(Competition.java:155) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.decreaseTime(Competition.java:209) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition.access$000(Competition.java:28) [21:13:52] [Paper Watchdog Thread/ERROR]:         even-more-fish-<IP_ADDRESS>.jar//com.oheers.fish.competition.Competition$2.run(Competition.java:136) [21:13:52] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) [21:13:52] [Paper Watchdog Thread/ERROR]:         org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) [21:13:52] [Paper Watchdog Thread/ERROR]:         net.minecraft.server.MinecraftServer$$Lambda$4673/0x00007f38e4a33b68.run(Unknown Source) [21:13:52] [Paper Watchdog Thread/ERROR]:         java.base@17.0.9/java.lang.Thread.run(Thread.java:840) [21:13:52] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:52] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH --- [21:13:52] [Paper Watchdog Thread/ERROR]: ------------------------------ [21:13:57] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-193 (MC: 1.20.1) --- [21:13:57] [Paper Watchdog Thread/ERROR]: The server has not responded for 25 seconds!  Creating thread dump

Hi there, incredibly sorry about the delay. Over the next two weeks when I'll have a bit of free time I'm going to try and collate togerther the biggest bugs with the plugin and get the plugin back into a working state. I've been very busy with studies and am aware EMF has been put onto the backburner massively which has been less than ideal for a lot of servers and many more players. I'm going to post a spigot update of where the current codebase of the plugin's at since there's been some work done by some really great contributors but hasn't been posted to the official spigot site yet - whichever bugs still exist on that version I'll try to tackle.

I noticed a similar behaviour after a manually ran competition on last version, with the following error (Server seems to time out, but see that part of the timeout yourself): https://pastebin.com/Q2eYABDC

Hey there, do you happen to have a thread dump from when this occurs? or a spark report?


Why do you monitor val_activation_46_mae in the training?

Dear @hamidriasat,
Many thanks for this great project and for the Keras.io tutorial.
Why did you monitor the val_activation_46_mae [1] instead of val_activation_53_mae?
In the paper, I read:

Therefore, given a input image, our predict module produces seven saliency maps in the training process.
Although every saliency map is upsampled to the same size with the input image, the last one has
the highest accuracy and hence is taken as the final output of the predict module.
This output is passed to the refinement module.

Would it be better to monitor val_activation_53_mae or val_activation_53_loss?
Also, why not the val_loss?
Thank you once again.
D
[1]
From https://github.com/hamidriasat/BASNet/blob/basnet_keras/basnet_training.ipynb
checkpoint_callback = keras.callbacks.ModelCheckpoint(
    filepath=WEIGHTS_PATH,
    **monitor=f'val_{basnet_model.output_names[0]}_mae',**
    mode='min',
    save_weights_only=True,
    save_best_only=True,
    verbose=1
)

Dear @murdav
Thanks for appreciating my work.
Regarding monitoring val_activation_46_mae. Kindly understand the model has two parts prediction part and refinement part. Above you are giving paper reference to the prediction part but comparing it to the final model output which is coming from the refinement part.  In my implementation of prediction module all auxiliary outputs are maintained in reverse order (Implementation requirement). Starting from the last output to first output of the prediction module. And then later this first output (which is last output of prediction module if you look at the architecture diagram) is passed to refinement module and when final model is created by combining both then at first place I placed refinement module output as described in the paper. So the order is correct.
Regarding your second concern why not val_loss. In paper, they did not use a validation set at all. So using it and then which function should be used to monitor is my personal choice. In the paper after training they evaluated results against multiple loss functions and one of them was Mean absolute error. I used it here so I do not have to measure validation accuracy separately.
Hope this will help to understand :smiley:, feel free to ask anything if still not clear.

@hamidriasat, thank you for your prompt and precise answer. I really appreciate it.
D


[chart/redis-ha][REQUEST] Seprate StatefulSets for redis and sentinel

Number of redis servers is not related to sentinel servers, we can have 2 or 4 redis servers (e.g. on large deployments we want to run only 1 slave, not 2).
Also it's better to not tie redis-servers to sentinel. A cluster with 3 redis servers and 3 sentinel servers, can tolerate losing 2 redis servers, but cannot continue to work with only 1 sentinel.
So I suggest splitting the current StatefulSet into two.

I wish I could remember why the original creator of this chart did that, I think it was based on an original implementation.
I think I need more input from others on this, because whilst this isn't incorrect. What's the disadvantage to having an even number of sentinels to Redis instances?
Assuming quorum can be attained.

I would suggest that Kyle Kingsbury's (Aphyr) article had something to do with it. Have a look at the section titled "Redis Strategies".  Jepsen: Redis
I don't have a source to quote here, but recall that in the past Redis' author was advising against colocating Redis and Sentinel. Now that setup is part of official documentation. Sentinel Docs
I think both modes are possible if Sentinel is separated out of StatefulSet, if you want them colocated just set affinity and anti-affinity so that Sentinels land on the same nodes as Redis but repel each other.

@tahajahangir @silvpol I feel like at this stage then, based purely on how the maintainers recommend configuration. It would be better to stick with the model we have.
Unless there are some clear disadvantages to doing so, I don't see a clear benefit to managing this. It forces people to be more cluster aware if we change this because they have to make sure affinities aren't in some way preventing scheduling on their cluster which even in the chart could be a ballache.
Whereas current implementation has a Sentinel per instance, which for MOST cases (3) is exactly what is recommended by Redis.
The only disadvantage as mentioned by the OP is if we lose a node, we lose Redis and Sentinel but would this not be the case if we had 2 separate statefulsets anyway? I'm happy to hear arguments against this by the way. I've been so OOTL with Redis recently, I'm happy to have my mind changed.

The main reason for me is 1) large deployments 2) more reasonable structure

With a 70GB Redis instance (which requires even more RAM because of replication/bgsave), 2 redis instances is enought for HA, and having a third instance requires notable resources.

By default, these are two separate services (in the microservice/12factor terminology). And by default each microservice should be a seprate workload (deployment/statefullset). We should have a reason for merging these two services into one statefullset.

@tahajahangir

At this instance size I can see why would you want that
True that they are separate microservices, but they are not really independent. Did you check Aphyr's article I mentioned? The recommendation is to align topologies to avoid edge cases. When two containers are in same pod the communication is down to kernel moving memory around, with separation you can end up with sentinel that can't talk to redis despite both being reachable independently. In the interest of transparency, Antirez (Redis' author) replied to the test, please check it out.

I'm not fundamentally against making the change, but I think it's likely to introduce new failure modes and would involve significant chart refactoring. Alternative approach would be to add ability to remove sentinel from the set to that you can plug in your own setup.

I think for the time being, I'll keep this in the backlog for now and consider this during AFTER another refactor.
Right now, I'm more concerned that this chart isn't robust enough for all scenarios and also maybe overcomplicated to a fault.
I just need to find time for a major refactor.

Housekeeping and closing this. Coming back, I don't think we'll action this for now. Welcome submissions with ways to implement this appropriately but its just not something I'm going to be doing and more specifically, doesn't seem to be the right direction for the chart.


KAFKA-5873: add materialized overloads to StreamsBuilder

Add overloads for table and globalTable that use Materialized

@guozhangwang, @bbejeck, @mjsax

@guozhangwang

The latest update LGTM, assuming we are keeping the addStateStore and addGlobalStore in StreamsBuilder. We are currently pondering on whether to still keep them in KIP-182, so a follow-up PR may be coming.

merged to trunk


How to add chartmuseum as an App Repository in Kubeapps

Hi,
I am very amazed with the chartmuseum. May I know if there is a way to add chartmuseum as an App Repository in Kubeapps. This can help me manage and deploy my helm releases  in a very nice way.

@nagarjunac thanks!
I assume you are talking about running your own Monocular instance? If so you can check out the configuration instructions here: https://github.com/kubernetes-helm/monocular/blob/master/deployment/monocular/README.md#configuring-chart-repositories
cc @prydonius

thanks @jdolitsky. @nagarjunac if you're talking about the new Kubeapps dashboard, you should be able to add your ChartMuseum repo as any other Helm Chart repository in the configuration page (see https://github.com/kubeapps/kubeapps/blob/master/docs/dashboard.md#add-more-chart-repositories). It's the same name/URL you'd enter with helm repo add.

@prydonius I think I have tried it the same way, but my charts were not visible under charts page. I will try one more time and let you know if it works.

thanks @jdolitsky .

closing since question for the KubeApps team

@nagarjunac did this work for you in the end?

adding the chartmuseum repository from UI fails for me :/ monocular-fail

@hayderimran7 what do you get with
curl -v http://chartmuseum.local.com/index.yaml

?

@jdolitsky
curl -v http://<REDACTED>.com/index.yaml
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <REDACTED>.com (<IP_ADDRESS>) port 80 (#0)
> GET /index.yaml HTTP/1.1
> Host: <REDACTED>.com
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: application/x-yaml
< X-Request-Id: 1821cab0-1a72-4beb-a945-c2bc285975d1
< Date: Mon, 09 Apr 2018 22:01:36 GMT
< Content-Length: 1353
<
apiVersion: v1
entries:
  mysql:
  - apiVersion: v1
    created: 2018-04-05T19:43:32Z
    description: A Helm chart for Kubernetes
    digest: e85152ac6ae89f53341507ac8669db98dc083f797dc5fed8039f6f8bdc9f8dcd
    name: mysql
    urls:
    - charts/mysql-0.1.0.tgz
    version: 0.1.0
  stem-mysql-local:
  - apiVersion: v1
    created: 2018-04-09T19:23:54Z
    description: A test specfic MySQL Helm chart using in dev (local) and regression
      environments
    digest: 4010b3dca5db1e12928d0259a8ebcd749c91cf064f8b135d1509de8fe4c1b3a4
    name: stem-mysql-local
    urls:
    - charts/stem-mysql-local-1.0.0+2-bfad995.tgz

@hayderimran7 that repo looks healthy, I would open/check for an issue in the monocular queue: https://github.com/kubernetes-helm/monocular/issues
Maybe javascript debug console will tell you more

@jdolitsky thanks for the help - yep looks like an angularJS error to me monocular-error

@hayderimran7 can you open an issue in the Monocular repo @jdolitsky linked to. It would also be helpful if you could screenshot the Network tab of the chrome inspection pane to see the response from the failing request. Cheers!


Version scheme incorrectly using "beta"

Please drop the beta suffix from future tagging. The use of the "beta" label in the tag here is not denoting the status of a specific version, it is being used to denote the overall status of the project. This is evidenced by the fact that the next version after v0.22.0beta or similar is never v0.22.0, but always another bump like v0.23.0beta. In other words these are not beta cuts of a specific tag that isn't marked yet, they are the release of that tag—with "beta" tacked on the end so people don't take the project too seriously.
Following either 0ver or semver specs as you prefer is fine, but the current scheme is weird and obnoxious for packagers. The leading zero already suggests the project is in a development mode where breaking changes can happen in any/all releases. Given the volume of uptake already in the wild the "don't use this as your daily driver" ship has sailed.

fair point, I don't see many reasons to keep the beta in anymore anyways tbh

Of course I could but that would confuse end user ... for example I packaged this for official Arch Linux repositories and if I'd removed the beta from the string we'd have had people wondering where I got the official release when the upstream project tag is different. As a general rule confusing people and generally doing different things than upstream marks is a not a great plan. Upstream projects doing things in a standardized way (like semver or 0ver or whatever) is the right way to make this easy on everybody.

fair enough


control flipping forward or backward

"Hi, I've encountered an issue while using this. Since I need to create PageCurlConfig before creating PageCurlState, how can I control flipping forward or backward using PageCurlState in the onCustomTap? I tried using stateOf along with LaunchedEffect to trigger the offset change in onCustomTap, but it causes recomposition. Do you have any suggestions?"

Hey 👋
Actually I do not understand why I have merged PageCurlConfig into PageCurlState 🤷
As for (todays) me they could be independent and thus you may create a state before config to perform your custom logic in onCustomTap. I have split them in PR #19, so the new usage would be:
val state = rememberPageCurlState()
val config = rememberPageCurlConfig(
    onCustomTap = { size, position ->
        // You may access `state` here to flip forward / backward
    }
)

PageCurl(
    count = ...,
    state = state,
    config = config,
) { index ->
    ...
}

Will it solve your case?

Sure, that would be a perfect solution. Thank you for your help.

Awesome, thanks for confirming.
It should be a part of the 1.4.0 release.


Removes other filters

This script removes other filters that have been implemented before this script is run.

This is categorically untrue. Here are the API commands the script runs:
gapi.client.analytics.management.accounts.list() - lists the accounts the user has access to
gapi.client.analytics.management.webproperties.list() - lists the properties the user has access to
gapi.client.analytics.management.profiles.list() - lists the profiles the user has access to
gapi.client.analytics.management.filters.list() - lists the filters that have been created
gapi.client.analytics.management.filters.update() - updates one of the filters the script creates, if an updated version is available
gapi.client.analytics.management.filters.insert() - creates a new filter
gapi.client.analytics.management.profileFilterLinks.list() - lists the filter-profile links that exist
gapi.client.analytics.management.profileFilterLinks.insert() - creates a new filter-profile link
As you can see, not one of these has the power to delete anything.
If you really believe this to be the case, please do a screencast or show me the code that is at fault here.
Simo

I'm not able to reproduce this when running an update of the filters. It can surely be a human error (me) in relation to this issue. I will return to this matter if I'm able to reproduce it.

Thanks, please keep me updated if you come across problems or errors.
Simo

On 30 Jul 2015, at 12:08, alexander<EMAIL_ADDRESS>wrote:
I'm not able to reproduce this when running an update of the filters. It can surely be a human error (me) in relation to this issue. I will return to this matter if I'm able to reproduce it.
—
Reply to this email directly or view it on GitHub.


Adding something to the index page.

There is only the hi and the "OwO"s  in the index page,
I think this is too empty.
Tasks:

[ ] Design the page
Have the top bar that show the logo
Have the Login/Register button
Have the People tab
Have the contact
[ ] Start building the layout in

[ ] Add some images to the

[ ] Add some text (Loren Iplsm)
[ ] Decorate

Design Done!


Chant suggestions are showing empty boxes

On the chant create page sidebar, suggestions based on the previous chant are currently not working because of our recent changes on production that stop our requests to Cantus Index.
We should either hide these suggestion boxes or display a message that says this tool is currently unavailable until we restore our communications with Cantus Index.

This is almost certainly related to us turning off requests to CI.


coffee script support

Would be cool to have coffee script support built-in!
As a proof of concept i did a very simple PR.
https://github.com/meteorhacks/meteor-down/pull/10
Thank you

Merged

:8ball:


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1908

Questions ?
Please refer to the Backport tool documentation


Added Search Functionality in Homepage

Added Search Functionality in Homepage which lets you to find the text you want.Below I am attaching the video for demonstration. and Before and After screenshots for references.
This fixes the issue : #9
Video:
https://github.com/user-attachments/assets/5896b723-30f3-45d3-b962-a40a3066cf94

Screenshot Before:

Screenshots after Fix :

@anuragverma108 Thank you for the opportunity. I have fixed the issue. Please review this PR.

Unfortunately, due to a wrong PR that got merged, the website's structure became disorganized. We had to revert to the old code. Kindly pull the latest changes and create a new PR for your issue, as your current PR shows conflicts. I apologize for the inconvenience and appreciate your understanding. Looking forward to your new PR soon. Thank you! 😊


add xeinsum, an einsum for xmap (& jnp.einsum easter egg)

We upgraded jnp.einsum to work with xmap's named axes, lowering to pdot!
There's still a lot more to do, including:

handling more than two operands
handling more positional axis cases
maybe de-duplicating some positional axis logic with the rest of jnp.einsum
lots more tests
checks once we have avals-with-names
docs!

But already this is a convenient wrapper around pdot.
Because this is a strict generalization of the existing einsum API, and in particular a generalization of the axis specification string language, we don't need a new user-facing API function: we can just extend jnp.einsum to handle mapped axes! For now, this path is like an undocumented easter egg in jnp.einsum, but it may already be useful for those playing with xmap.
Co-authored w/ @apaszke.

Yes: support for more than two operands, for one!
This is just a first cut. We should look at using opt_einsum for supporting multiple operands, and more generally look at merging/de-duplicating with jnp.einsum itself.
In short, we plan to do that, we just want to get something in first.

Yes: support for more than two operands, for one!
This is just a first cut. We should look at using opt_einsum for supporting multiple operands, and more generally look at merging/de-duplicating with jnp.einsum itself.
In short, we plan to do that, we just want to get something in first.


Class room videos issue

This is Raman, i am devops student, from fast four days, i am unable to download class videos to my local(laptop), there is no space issue, i have a space in my system, maybe you required my mail-id to verify permissions, this is my mail-id<EMAIL_ADDRESS>

i am trying to download from this location https://drive.google.com/drive/folders/1Ch97BoitfVUfJsz0XR0xeGikaXZEbwmR

Sir this is no the place for administrative issues. Write to quality<EMAIL_ADDRESS>


Issue with NMON Visualiser

Hi,
I am using the new version of NMON Visualiser. Tool is excellent!! But manytime it get hang during parsing the loaded file and we have to cancel the load of nmon files.
Please correct this bug.
Thanks
Sushil Potdar

Are you processing a large number of files or is each file very large? You may just be running out of memory.
Start the tool from the command line with something like java -Xmx2048M -jar NMONVisuazlizer_xxx.jar.  You can see how much memory is being used by going to the Help Menu and selecting Java Info - the last line will show total heap usage.

Thanks hunter!!!
On Jun 24, 2015 6:41 PM, "Hunter Presnall"<EMAIL_ADDRESS>wrote:

Are you processing a large number of files or is each file very large? You
may just be running out of memory.
Start the tool from the command line with something like java -Xmx2048M
-jar NMONVisuazlizer_xxx.jar.  You
can see how much memory is being used by going to the Help Menu and
selecting Java Info - the last line will show total heap usage.
—
Reply to this email directly or view it on GitHub
https://github.com/nmonvisualizer/nmonvisualizer/issues/24#issuecomment-114863286
.


GO Linter fails: Can't run linter goanalysis_metalinter

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I am not able to get the validations for GO to work, although golangci-lint runs locally without problems.
# no issues
lint:
	@echo -e "\n$(YELLOW)Running the linters$(NC)"
	goimports -w ./
	brew install golangci-lint
	golangci-lint run

SUPER_LINTER_VERSION=slim-v5.7.2
lint:
	@echo -e "\n$(YELLOW)Running the linters$(NC)"
	docker pull ghcr.io/super-linter/super-linter:$(SUPER_LINTER_VERSION)
	docker run \
	  -e ACTIONS_RUNNER_DEBUG=false \
	  -e DEFAULT_BRANCH=main \
	  -e LOG_LEVEL=DEBUG \
	  -e RUN_LOCAL=true \
	  -e VALIDATE_ALL_CODEBASE=false \
	  -e VALIDATE_GO=true \
	  -v $(PWD):/tmp/lint \
	  ghcr.io/super-linter/super-linter:$(SUPER_LINTER_VERSION)

for main.go  I'm running local super-linter:
// Package main
package main

import (
	"fmt"

	"github.com/alecthomas/kong"
	"github.com/gin-gonic/gin"
	"github.com/rs/zerolog/log"
)

// CLI https://github.com/alecthomas/kong
type CLI struct {
	Port              int  `env:"PORT"`
	PretifyJSONOutput bool `env:"INDENT_JSON_OUTPUT"`
	Version           string
}

var cli = &CLI{}

var version = "development"

func main() {
	fmt.Println("Hello, World!")
	log.Info().Msg("Starting application")
	_ = kong.Parse(cli)
	log.Info().Msgf("listening on port :%v", cli.Port)
	gin.SetMode(gin.ReleaseMode)
	cli.Version = version
	_ = gin.Default()
}

This constantly generates a very strange error, which varies in the package
------
level=warning msg="[runner] Can't run linter goanalysis_metalinter: inspect: failed to load package embed: could not load export data: no export data for \"fmt\""
level=error msg="Running error: 1 error occurred:
        * can't run linter goanalysis_metalinter: inspect: failed to load package embed: could not load export data: no export data for \"embed\"

"
------

I tried to run it on different architectures. The name of the package is often changed, probably depending on how the linter takes it. My go.mod has GO version v1.21.
I'm not able to identify where the bug came from, but I find it strange that the golangci-lint run always ran without problems locally and as a GitHub action.
output.log
Expected Behavior
linter pass, or help identify issue
Super-Linter version
v5.7.2

Relevant log output
see output.log

Steps To Reproduce

Run my Makefile against main.go, which I supplied.

Anything else?
No response

Hi @kuritka !
We just released v6. Can you try with that? Thanks!

Also, your golint-ci invocation is different from the one that super-linter uses. Can you try running golint-ci locally with the same command? Thanks!

@ferrarimarco
I think it doesn't copy files into workspace.
2024-01-31 18:16:34 [WARN]   No files were found in the GITHUB_WORKSPACE:[/tmp/lint] to lint!
2024-01-31 18:16:39 [NOTICE]   All files and directories linted successfully

SUPER_LINTER_VERSION=slim-v6.0.0
lint:
	@echo -e "\n$(YELLOW)Running the linters$(NC)"
	docker pull ghcr.io/super-linter/super-linter:$(SUPER_LINTER_VERSION)
	docker run \
	  -e ACTIONS_RUNNER_DEBUG=false \
	  -e DEFAULT_BRANCH=main \
	  -e LOG_LEVEL=NOTICE\
	  -e RUN_LOCAL=true \
	  -e VALIDATE_ALL_CODEBASE=false \
	  -e VALIDATE_GO=true \
	  -v $(PWD):/tmp/lint \
	  ghcr.io/super-linter/super-linter:$(SUPER_LINTER_VERSION)

Here is what I'm running locally:
❯ golangci-lint --version
golangci-lint has version v1.51.2 built from (unknown, mod sum: "h1:yIcsT1X9ZYHdSpeWXRT1ORC/FPGSqDHbHsu9uk4FK7M=") on (unknown)

# ./.golangci.yml  is copied from super-linter
golangci-lint run --fast -c ./.golangci.yml

What is your current working directory (the value of PWD)?

/Users/<user>/GolandProjects/github.com/<owner>/<test_project>

Are you running this on an ARM-based Mac by any chance? I'm not sure how compatible that would be because we don't publish an arm64 image. Anyway, it looks like the mounted directory is either empty, or it doesn't contain any .go files.
I think the command you're running might not be mounting what you expect. To check this, I would try opening a shell in the super-linter container by adding the --entrypoint /bin/bash option to the docker run command, and then checking if the content of /tmp/lint is what you expect. It should match with /Users/<user>/GolandProjects/github.com/<owner>/<test_project>.

No, they're just files I deleted to keep the binary to a minimum.

I think,  I'm pretty sure, that the problem is that if you want to lint GO, you have to have the downloaded files including all dependencies. That means including libraries etc. That's why it is necessary  to call go mod tidy before calling golangci-lint.

Hi @kuritka ! I was able to reproduce the issue with the example you provided. I added it as a (failing, for now) test case. That's the first step into finding a solution :)

By the way, running go mod tidy will also generate a go.mod file, or add any missing modules to the go.mod file. That would require modifying the source code, and it's something that super-linter currently tries to avoid.
If you're trying to lint a Go module (i.e. you have a go.mod file), you should set VALIDATE_GO=false, and set VALIDATE_GO_MODULES=true (the default for all VALIDATE_XXXX is true).
Can you try that?


CL2: Add isFatal param to WaitForPods and enable failing measurements

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR introduces a set of commits that enable measurements to fail during their Execute method. Errors that are returned during a measurement's Execute method are passed up the stack to the simple test executor, which then passes them through a function called isErrsCritical. This function can control if the entire test should bail, based on the criticalness of the errors passed to it. Right now, it's a no-op:
https://github.com/kubernetes/perf-tests/blob/e7bdd15c9122e55d7dc267768190addc8fdf7b9e/clusterloader2/pkg/test/simple_test_executor.go#L386-L389
This PR modifies the function to check if any of the errors in the given list are fatal. A measurement can mark an error as fatal if it returns an error wrapped by a newly added FatalError type.
This PR also modifies the WaitForPods measurement to utilize this functionality. A new param named isFatal can control if a test should bail if the WaitForPods measurement is unable to successfully determine that a set of required pods are running and ready. This can be helpful for tests that require some infrastructure within the cluster to run. For example:
name: is-fatal-test
namespace:
  number: 1
tuningSets:
- name: Uniform1qps
  qpsLoad:
    qps: 1
steps:
- name: Create test pod
  phases:
  - namespaceRange:
      min: 1
      max: 1
    replicasPerNamespace: 1
    tuningSet: Uniform1qps
    objectBundle:
    - basename: my-test-pod
      objectTemplatePath: ./my-test-pod.yaml
- name: Wait for test pod
  measurements:
  - Identifier: WaitForRunningPods
    Method: WaitForRunningPods
    Params:
      labelSelector: name=my-test-pod
      desiredPodCount: 1
      timeout: 60s
      isFatal: true
- name: Sleep
  measurements:
  - Identifier: Sleep
    Method: Sleep
    Params:
      duration: 10s

In this config, the Sleep measurement will only be executed if the test pod has been successfully deployed.

cc: @marseel

/ok-to-test

/retest

Gentle ping @mborsz and @wojtek-t. Do you mind taking a look when you have a moment? :pray:

Thanks for the review @marseel! I just pushed some changes addressing your feedback.

Thanks!
/lgtm
/approve


Support for am/pm

Since I'm in the US, I find it a bit hard to wrap my head around the 24-hour clock.  Would you be willing to support inputs like
:EVENT 1:00pm-1:30pm eventname?

you literally have to add 12 hours if it is pm. should not be that hard...

I implemented this feature. Any of 1:00 pm, 1:00 PM, 1:00 p.m., 1:00 P.M. and without spaces are supported.

Thank you so much!


Remove device from Tailnet

Right now when you delete the service, it will leave behind a device in your Tailnet that has to be manually removed.
This can technically be automated using the Tailscale API.

You can also use ephemeral nodes when you create auth keys.  Nodes are automatically pruned from your Tailnet after some period of inactivity.

You can also use ephemeral nodes when you create auth keys. Nodes are automatically pruned from your Tailnet after some period of inactivity.

Problem with this is that I want to retain the service's IP address

You can also use ephemeral nodes when you create auth keys. Nodes are automatically pruned from your Tailnet after some period of inactivity.

Problem with this is that I want to retain the service's IP address

I'm relatively new to Tailscale as a product offering, how do you persist the IP address between different deployments? This is one of my concerns, albeit less so as we're using external-dns to sync ts-* services to our DNS provider.

You can also use ephemeral nodes when you create auth keys. Nodes are automatically pruned from your Tailnet after some period of inactivity.

Problem with this is that I want to retain the service's IP address

I'm relatively new to Tailscale as a product offering, how do you persist the IP address between different deployments? This is one of my concerns, albeit less so as we're using external-dns to sync ts-* services to our DNS provider.

Tailscaled stores it's state (including the machinekey / Tailnet device registration) in a Kubernetes secret.

I feel like deleting the service should trigger deleting + cleaning up the host on your tailnet. If people want explicit ips to be set on their LBs, they should have to set that via an annotation, or they should do it like metal LB does it with a spec.loadBalancerIP field. If this design sounds good, I don't mind implementing it when I have some time.

I feel like deleting the service should trigger deleting + cleaning up the host on your tailnet. If people want explicit ips to be set on their LBs, they should have to set that via an annotation, or they should do it like metal LB does it with a spec.loadBalancerIP field. If this design sounds good, I don't mind implementing it when I have some time.

This is the same thing I've got in mind. Although I don't know if it's possible to set your own loadBalancerIP.


update on backstage ldap auth plugin

Hi,
We are looking for a ldap auth plugin for authorisation in our backstage app. Can you please let us know if this is ready to use.

Hi @ind07g5q 👋
We're still doing some minor chores on it then we'll release it, probably in the upcoming week or the next.


Interpolation error

When I tried to test the program with test_custom.sh I get this error:
Namespace(batch_size=64, beta1=0.9, beta2=0.99, cuda=True, data_dir='data', data_root='data/frame_seq', dataset='custom', depth=3, exp_name='CAIN_fin', fix_loaded=False, img_fmt='jpg', log_dir='logs', log_iter=20, loss='1*L1', lpips=False, lr=0.0001, max_epoch=200, mode='test', model='cain', n_resblocks=12, num_frames=3, num_gpu=1, num_workers=5, random_seed=12345, resume=True, resume_exp=None, start_epoch=0, test_batch_size=8, test_mode='hard', up_mode='shuffle', use_tensorboard=False, val_batch_size=4, viz=False)
Building model: CAIN
of parameters: 42780432
Evaluating for epoch = 175
[0] images ready to be loaded
0it [00:00, ?it/s]
Traceback (most recent call last):
File "generate.py", line 124, in
main(args)
File "generate.py", line 120, in main
test(args, args.start_epoch)
File "generate.py", line 108, in test
print('im_processed: {:d}/{:d} {:.3f}s   \r'.format(i + 1, len(test_loader), time.time() - t))
UnboundLocalError: local variable 'i' referenced before assignment
I have all the packages installed with their respective versions.

Hi,
It seems like you are not loading any frames for interpolation.
Please make sure to change the --data_root to point to the directory containing the frames that you want to interpolate, and choose the correct --img_fmt (image format, possibly jpg or png).


Some meshes are corrupted if exported as part of a complex scene

Describe the bug
When exporting a complex scene, some of the objects/meshes in the scene may become corrupted when the scene is re-imported.
To Reproduce
Steps to reproduce the behavior:

Download Blender 2.91.0 (Steam version)
Install version 1.5.8 of glTF-Blender-IO
Download the Class room demo project: https://download.blender.org/demo/test/classroom.zip
Open the project in Blender
Remove all scenes from the project except for "_mainScene" (to prevent #639)
Export as glb with the default export settings
Open a new empty project and import the glb file

Expected behavior
The scene should have been the same after the import, however some of the meshes are corrupted (primarily the chairs).
This is the original scene: https://pragma-engine.com/share/blender_2020-12-07_15-15-26.png
This is the scene after importing the glb file: https://pragma-engine.com/share/blender_2020-12-07_15-16-14.png
The legs of the chairs have turned into circles.
However, if you remove all of the objects in the original project except for some of the chairs, then export the scene as glb and re-import it, the chairs will be correct:
https://pragma-engine.com/share/blender_2020-12-07_15-15-14.png
https://pragma-engine.com/share/blender_2020-12-07_15-33-16.png
.blend file/ .gltf
Class room demo: https://download.blender.org/demo/test/classroom.zip
Class room demo with just the chairs (does not include assets, i.e. above file is also required): https://pragma-engine.com/share/classroom_chairs.blend
Version

OS: Windows 10 x64
Blender Version 2.91.0
glTF-Blender-IO version: 1.5.8

Confirmed.
Need more investigation, but maybe a duplicate of #1049

Seems to be fixed by #1378

Fixed by 69746b2b31eeee080d5dfd3c74f1e02742795ed2


Build does not work

Hey,
I just tried cloning + building with build.sh, but get an error at
Cloning into 'llvm/tools/clang/tools/extra/clang-tidy/misra'...
warning: Could not find remote branch  to clone.
fatal: Remote branch  not found in upstream origin

Any suggestions?

build.sh is written to be used by Travis.
If you still what to use it, do it like this: TRAVIS_BRANCH=master ./build.sh
All of this is not yet very user friendly. I am open for contributions. :)


MongoDB doesn't work as it should

Hey, MongoDB works differently than other databases, and whenever I want to use a cluster with a URI it simply won't work. Would you please add URI support instead of just an address?

Hi,
I tripped over this too at first but lucko has correctly provided mongodb_connection_URI which gets passed directly into the MongoDB driver.
However, I only discovered that after seeing this open issue and going through the code to see if I could create a PR for it 😅
@lucko I'd recommend adding a section to the documentation, or maybe even just improve the readme description above connection to clarify the uri option is there. As it is very easy to scroll past as surrounding config options are sql-specific.

Add connection URI option for mariadb/mysql would be awesome, the console spams like crazy because luckperms is not using ssl or whatever

The SSL problem could be solved following This here


[GitHub] Add repository main programming language badge

Hello,
Opening an issue beforehand before diving into any implementation, as suggested by the guidelines.
I believe that there is no badge to display the main programming language of a repository. This could be a useful addition!
A Github API endpoint is available to retrieve the list of all languages used in the repository, alongside the number of bytes of code written in each language.
Does this seem like a desirable new badge?
Cheers,
Pyves

Nice idea! Though one thought I have is, is this something that is likely to change once a repository is created? We could avoid making an API call to Github by constructing the badge like this:
https://img.shields.io/badge/language-javascript-blue.svg

I would say it depends on the repository. Some might be on the tipping edge between two languages, some specific repositories might drift over time (for instance this one has progressively moved towards assembly). I guess it would be useful to have the choice to use a slightly more elaborate version that also includes the percentage for that top language?

Hi, do you meant like that?

Yes, something like that. I'll attempt an implementation and see how things turn out.

How about this?

I like this new version, best we've got so far!

Would you like to submit a PR?

@ritwickdey yes, I'm making progress on this piece of work.


Updated README.md

What do these changes do?
Updated and modified the README.md file
Related issue number
#1012

Closes #xxxx
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

Merged it. Thanks for taking time to optimize fury doc @vidhijain27


Add Parser Strategy Tests

Add Tests for classes extending from ParserStrategy
Also fixes the bug where an error showed when no output was shown when an Asset with no remarks was appended
#162

Codecov Report

Merging #309 (5d6cf42) into master (8a7079a) will increase coverage by 6.70%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
+ Coverage     69.50%   76.20%   +6.70%
- Complexity      597      651      +54
============================================
  Files            98       98
  Lines          2223     2227       +4
  Branches        181      181
============================================
+ Hits           1545     1697     +152
+ Misses          590      442     -148
  Partials         88       88

Impacted Files
Coverage Δ

...ava/donnafin/logic/parser/AppendCommandParser.java
92.59% <100.00%> (+92.59%)
:arrow_up:

...rc/main/java/donnafin/logic/parser/ParserUtil.java
84.37% <0.00%> (+2.08%)
:arrow_up:

.../java/donnafin/logic/parser/AddressBookParser.java
46.15% <0.00%> (+7.69%)
:arrow_up:

...java/donnafin/logic/commands/ContactTabParser.java
66.66% <0.00%> (+16.66%)
:arrow_up:

...n/java/donnafin/logic/parser/ClientViewParser.java
82.35% <0.00%> (+41.17%)
:arrow_up:

...ava/donnafin/logic/parser/DeleteCommandParser.java
100.00% <0.00%> (+41.66%)
:arrow_up:

...main/java/donnafin/logic/commands/EditCommand.java
68.75% <0.00%> (+62.50%)
:arrow_up:

...ava/donnafin/logic/parser/RemoveCommandParser.java
68.18% <0.00%> (+68.18%)
:arrow_up:

.../java/donnafin/logic/parser/ViewCommandParser.java
83.33% <0.00%> (+83.33%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7079a...5d6cf42. Read the comment docs.

@mrmrinal you'd still need to merge master tho


Should debug rendering be made a general thing, not part of schelling-org simOptions?

Seems like it might be generally useful to pipe in separately

Or maybe just even piping in the full options object to the renderer


Feature request : Make the startDate/nextDate of a job available to a job.

We are planning to use Chronos at our organization but see some gaps in what we want and what is available in Chronos today. While the title of this issue is to address a feature we need immediately, I will list down all that we are looking for.
Our use-case requires us to run jobs on all dates that satisfies the schedule of ScheduledJob. In other words, we don't want to skip date just because it is in the past. This is because the dates are used to pull slices of data from systems onto Hadoop. In the current form of Chronos, we can't enable/configure this to be so. This would also require the startDate/newDate/intendedRunDate of a job to be available as metadata to jobs (env var?). We could start off by making the startDate available as an environment variable to jobs. This seems possible in MesosTaskBuilder as the startDate is embedded in the taskId.
In general, it would be great if we could structure the code in a way so that the job scheduling mechanism can be extended easily. What are your thoughts?

Fixed by #629


Add character count for start line number and end line number

@K-LV @KeniMorri checkout the merge and let me know what you think.

I've read it, seems alright


Add Foreman to LF-Edge lanscape

Add logo and metadata for Foreman

https://landscape.cncf.io/logos/foreman.svg
Full entry to leverage for PR (website, Crunchbase) = https://landscape.cncf.io/format=card-mode&grouping=no&selected=foreman


Getting started typo

Instead of "but that's expect!"  should be "but that's expected!"

fix going out


test issue

Test 😉

Deploy preview for Yoshi is ready! https://wix-yoshi-1200.surge.sh/yoshi

Deploy preview for Yoshi ready!
https://wix-yoshi-1200.surge.sh/yoshi


Load custom CSS last to facilitate overrides

Description
The HTML5 chapterHead template currently inserts the custom CSS file reference specified via args.css before the contents of the custom header file specified via args.hdf.
This means that if the header file (or any of the 3 preceding* template calls) is used to insert references to external CSS stylesheets for frameworks like Bootstrap, the framework styles take precedence over any equivalent rules in the user's custom stylesheet.
This PR adjusts the order to ensure that custom stylesheets can be used to override any references included in the custom header file without resorting to increased selector specificity or !important hacks in the custom CSS.
* Related question
If I'm reading the code right, in addition to the processHDF template that inserts the contents of the custom header file specified via args.hdf, there are 4 additional named templates that are all empty by default, but can be customized to insert content into the <head> element of the generated HTML files for each topic:

copyright
gen-user-head
gen-user-scripts
gen-user-styles

The same redundant approach appears to be used for running headers and footers that are inserted into the HTML <body> element:

an empty gen-user-header template, followed by the processHDR template that inserts the contents of the custom header file specified via args.hdr
an empty gen-user-footer template, followed by the processFTR template that inserts the contents of the custom footer file specified via args.ftr

@robander I assume the empty templates preceded the ability to insert content via external files and are retained for backwards compatibility, but is there any advantage to customizing these empty templates over the use of external args.* files?

😞 Looks like the integration tests are failing here.
Might need help fixing those if my change requires modifications to the tests.

@robander Fixed the integration tests with afad60422a7fd419e7193a8e74c7db0dc0935148, they now pass.

if you've decided to go with gen-user-styles to put in one or more CSS links, those would previously override commonltr.css but after this move, the common one would win, right?

Yes, there's apparently no way to move just the custom CSS file call, as generateCssLinks includes both common & custom CSS.
Wondering if we should formally deprecate those old gen-user-* things? 🤔


Update dependency versions with Ballerina Update 3 release

Description:
$subject
Relatable Issues
#128

Closing this issue as it has been fixes with #132


guides for remix, nuxt & vue

Added guides for the following:

Keel + Remix
Keel + Nuxt
Keel + Vue

Let's pop these under guides not misc and give them the titles of "Keel with Next" etc in the navigation

Let's pop these under guides not misc and give them the titles of "Keel with Next" etc in the navigation

Done!

Closing in favor of #92


Add support for HHVM in Travis

I've just authorized HHVM build to fail on travis because I can't check for the moment why the build fail. We need to make the whole build pass (and remove fail authorization from .travis-ci.yml).

Hey.
There has not been a major request for this feature. Also, larger projects are dropping the support for hhvm. If you do not mind, I'll close this issue. Feel free to reopen it if you want.


ARIA-399: Sample Dockerfile and docker-compose.yaml file that installs/runs ARIA

Can one of the admins verify this patch?

Thank you for this contribution. In my opinion it would be better to share these files on the wiki. This is not a TOSCA example, so it definitely doesn't belong in our examples dir. And I think generally it's more about how to package/deploy ARIA, which should be part of the instructions on the wiki.

Tal,
Appreciate your valuable feedback.
Would creating a docker-examples similar to tosca-examples at https://cwiki.apache.org/confluence/display/ARIATOSCA/TOSCA+Examples work?


feat(menu-surface): New Menu, and Menu Surface

WIP

[ ] Update documentation
[ ] Add unit tests
[ ] Include breaking change notes (if any)

Closes #1235

This PR has been a pain..looking forward to completing it..


Add localization example

Closes https://github.com/emilk/egui/issues/136
[x] I have followed the instructions in the PR template

Related:

https://github.com/emilk/egui/issues/136
https://github.com/emilk/egui/discussions/1751
https://github.com/fewensa/egui-i18n/pull/1

This just an example to show my idea, From the previous communication records, it seems that there is no clear support plan for multiple languages. If you think this solution is feasible, please let me know, I will migrate all the code bases of egui-i18n to egui and provide a deeper integration. @emilk
more examples:

classic
fluent

egui_i18n looks great! But unfortunately including this example would introduce a circular dependency, where when we make a breaking change to egui, we'd have to first update egui-i18n to fix the breakage and then update the example with the new version before we could have a successful CI.
Including egui-i18n in egui would of course fix it, but I think it works great as a third party crate, and it would be a lot of extra code to maintain. Instead you should add it to https://github.com/emilk/egui/wiki/3rd-party-egui-crates so people can find it!
I also suggest adding a bit more to the readme, right now it looks very empty, and also add a license, so people can legally use it.


[Backport 2.x] Re-enable detekt (#796)

Cherry picked from commit 0e55d38cbaa372265e444ca9107b6519b8b75c44
Description
Bumped version of io.gitlab.arturbosch.detekt:detekt-gradle-plugin to 1.23.0
Issues Resolved
None
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xluo-aws Can you review the PR?


⚠ AGEG website (prod) has degraded performance

In 31adade, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2031 ms

Resolved: AGEG website (prod) performance has improved in fda24a2.


Feature/update datatable error handling

A more general solution to include DataTable errors in report.

Coverage decreased (-0.2%) to 81.751% when pulling dc025f2e0ada01b32cd9cf47cf77f1e89cb1433c on feature/update-datatable-error-handling into 9833660f99a1b12af1fa33c652a6bc9b48b0f15c on master.

👍


bankruptcy: Allow users to mark all messages as read.

https://chat.zulip.org/#narrow/stream/feedback/topic/clearing.20notifications
Testing Plan:
Send a bunch of messages to different streams and log into another account.
Screenshots:

merged, after making sure this closed the original issue (actually, there were several basically duplicate issues this fixed).  Thanks @hackerkid!


emit export declarations for system modules as a part of 'execute' me…

…thod. fixes #4162. New output is aligned with what Babel will emit in the similar case

pinging @mhegazy

Lgtm. Once you checkin I will rebase my changes of your changes


feat(sma): implement v2 GET /health/{services} API

separate controller layer and application layer
the application layer logic is similar to v1
update health status to boolean true to string healthy
update HealthResponse in SwaggerDoc

Signed-off-by: Chris Hung<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?

Issue Number: fix #3418
What is the new behavior?
$ curl http://localhost:48090/api/v2/health/edgex-core-data,edgex-core-metadata
{"apiVersion":"v2","statusCode":200,"health":{"edgex-core-data":"healthy","edgex-core-metadata":"healthy"}}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
There's no mock for RegistryClient, do we need to create on for testing ?
@lenny-intel @cloudxxx8

Codecov Report

Merging #3420 (3129bae) into master (576eddb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3420   +/-   ##
=======================================
  Coverage   40.70%   40.70%
=======================================
  Files         192      192
  Lines       15901    15901
=======================================
  Hits         6473     6473
  Misses       9002     9002
  Partials      426      426

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576eddb...3129bae. Read the comment docs.

There's no mock for RegistryClient, do we need to create on for testing ?

@hahattan Yes, I think we should be creating mocks for any interface we create so unit tests can take advantage.

PR for registry Client interface mock: https://github.com/edgexfoundry/go-mod-registry/pull/73


fork to GitHub action

separate the auto-update from the data, i.e. by creating a GitHub action for autoupdate (name like jenkins-update-action) that will be run inside our actions.

This repo is discontinued, not doing anything anymore.


Handle categories

categories contains the categories as Category objects
category_ids holds an array of ids for update
@myhalard

:shipit:


_3mux: 0.3.0 -> 1.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/3mux/versions.
meta.description for _3mux is: "Terminal multiplexer inspired by i3"
meta.homepage for _3mux is: "https://github.com/aaronjanse/3mux"
meta.changelog for _3mux is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.0.1 with grep in /nix/store/3lpzhy0xfh99yp0mpzihfmqn5g1in4n9-3mux-1.0.1

directory tree listing: https://gist.github.com/bf80ac3eb444522bcdcc84643faa2b63

du listing: https://gist.github.com/8765e33ea29102b2b560f911281b8fb9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
_3mux

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3lpzhy0xfh99yp0mpzihfmqn5g1in4n9-3mux-1.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A _3mux https://github.com/r-ryantm/nixpkgs/archive/cfebaccae86c214d587e75f06a68aaf3ec944e17.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3lpzhy0xfh99yp0mpzihfmqn5g1in4n9-3mux-1.0.1
ls -la /nix/store/3lpzhy0xfh99yp0mpzihfmqn5g1in4n9-3mux-1.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

_3mux

Maintainer pings
cc @aaronjanse @filalex77 @kalbasit for testing.

(author of 3mux here) 1.0.1 is a pre-release. I'll tag a new release (with bug fixes) soon as a stable release. I recommend that Nixpkgs waits till then before updating 3mux :-)


Update ru.coffee

Some translations for russian lang

Hi @stillru . Thanks for the translations! So we can merge this in, can you sign the CLA?

Hi @stillru . Thanks for the translations! So we can merge this in, can you sign the CLA?

Closed as CLA not signed. Feel free to reopen it.


ANC PostPartum - Specialty Care - HIV [6h]

Issue
If a patient was diagnosed with HIV during their pregnancy, the specialty care review activity will populate in the activity tray.
This activity allows the nurses to check in with the patient to ensure they that they are set-up with continuous care now that their pregnancy is over.

If they are not already enrolled in a program we will refer them to ARV services.
Related Issues

#368
#369
#370

To Do

Style screens per design

@jeanette-pelizzon
There're gaps at requirements here, because HIV diagnosed patient may not have a treatment plan.
For example, if patient was referred to HIV program, they might have got treatmet but we do not know what it is.
Another case is where patient is supposed to be prescribed with medicine, was not (for whatever reason), as we provide this option.

I think as a work around we have "Given medication by PMTCT" as the treatment plan if they were given medication by PMTCT that wasn't one that we list in outside care ?

@anvm updated the screen designs for specialty care review. I updated the main issue to reflect the changes. The flow stays the same, screen design changes. Hopefull this simplifies things!

@jeanette-pelizzon  @adamhstewart
Since there are 2 options for referrals, we'll have to make it multiple referral form, similar to what we're doing at https://github.com/TIP-Global-Health/eheza-app/pull/414.
This is complex develpment. We could save some time if we did not have the Why not part.
So, the question is whether or not that data is really needed.

@anvmn got an answer for this. We really just need to ensure they are enrolled in a program and if not refer them to the appropriate program. The treatment plan stuff is not important (at this time). Updated main issue and design.

@jeanette-pelizzon

If a patient was diagnosed with HIV during their pregnancy

We're talking here only of case where HIV dignosis was made during current pregnancy?
No need to send to ARV when patient is know to be positive, or got Discordant Partnership diagnosis?

Got an answer. Refer all -  known positive, new positive, discordant- to ARV services. // @anvmn

https://nutrition-ihangane.pantheonsite.io/
QA Review
Checked and approved:

When patient was diagnosed with HIV during pregnancy, in the postpartum encounter the Specialty care icon displays and makes sure they are enrolled in ARV services.

If the answer is NO under the Specialty care, then patient is referred to ARV services.


Several unintended dependencies in 2.5

Describe the bug
Presumably foundation, extensions, and tools, should not depend on examples, but they do:
Tools\ControllerMappingTool\ControllerMappingTool.unity depends on Examples/StandardAssets/Prefabs/SceneDescriptionPanelRev.prefab, but package dependency is missing.
Extensions\Samples~\HandPhysicsService\HandPhysicsServiceExample.unity, that depends on Examples/StandardAssets/Prefabs/SceneDescriptionPanelRev.prefab, but package dependency is missing.
Foundation\SDK\Features\UX\Interactable\Materials\MRTKStandardUnityUI.mat, that depends on Examples/Experimental/Dwell/Circle.png, but package dependency is missing.
... and about 250 others like this.
Expected behavior
Packages should declare their dependencies for any assets within the package.  In this case, I don't think they are intended, so assets should be moved to the appropriate place.
Your setup (please complete the following information)

Unity Version: 2019.4 LTS
MRTK Version: 2.5

Thank you for filing this! I will investigate and update asap.

FWIW, the tool I have to detect these issues (sorry I can't contribute it) isn't too different from what you already have in the MRTK dependency window.  It just goes through every package & asset, finds all it's dependencies by guid, and then checks that those dependencies are reflected either directly or indirectly in the packages dependencies.
It may be worth investing in similar tooling.  It only took me an afternoon to make, and has saved me countless times (my project is like 30 packages, so it's impossible to manage manually).

The result of this work will be a new step in the pr validation pipeline to help ensure that incorrect cross package dependencies are not introduced,


Controllers do not recover after token deletion

Description
When deleting a serviceaccount token for a controller, the connectivity to the APIServer will be lost by getting "Unauthorized" responses. The controller do not recover and require a restart.
As an example take the service-catalog-controller-manager. It has a serviceaccount referenced in the deployment definition and with that a volume mount of the related secret gets generated in the pod spec like:
  - name: service-catalog-controller-manager-token-4949r
    secret:
      defaultMode: 420
      secretName: service-catalog-controller-manager-token-4949r

Deleting that concrete secret will result into a non-working controller indicated by logs like "1 controller.go:368] error getting the cluster info configmap: "Unauthorized"". A new secret with a new ID gets immediately generated but the pod stays unhealthy. Only a manual restart of the pod recovers the situation.

Expected result

Actual result

Steps to reproduce

Troubleshooting

There is no trivial solution to the problem. I guess the controller could be improved to include the connectivitiy to the apiserver into the overall health check for the controller so that kubernetes can detect the situation and fix by an automated restart.

Please see the insights in this comment: https://github.tools.sap/kyma/backlog/issues/1971#issuecomment-424889
and take them into consideration when planning the recovery process - removing a k8s Secret which comes from TokenController equals invalidation of the token by k8s design (see docs). The secret is then recreated and serviceAccount is also updated with secret reference, but all deployments which use those serviceAccount won't be automatically restarted.

@ksputo : can the ticket be assigned to you?

Reconciler has moved to the new architecture, this issue will not be worked on.


Add checks for trailing zero bytes in capabilities

https://github.com/iotaledger/iota.go/pull/593

Closed by https://github.com/iotaledger/iota-sdk/pull/1551


modify transform op output variable name to avoid mindir conversion bug

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

[x] You have read the Contributing Guidelines on pull requests
[x] Your code builds clean without any errors or warnings
[x] You are using approved terminology
[x] You have added unit tests

Motivation
Problem:
ms.export interface loads the variable names in network to build the mindir files. Therefore, the change (x -> tout) of the input variable name of backbone will cause bugs while using convert_lite tool to convert mindir files for lite inference.
Solution:
Keep the input variable name of backbone as x to ensure backward compatibility. The models trained before can be converted to mindir files without additional modification on variable name mapping while using convert_lite tool.

so the the branch tout = x has bug only ?
As far as I know, yes. Need to further test SVTR mindir conversion.


Indenting code mjml in Sublime text?

Hi!
Reindent code mjml not working - http://prntscr.com/e5mief
I have package for sublime mjml-syntax
Thanks!

Hi, as this issue belongs to the Sublime package, I moved it there: https://github.com/mjmlio/mjml-syntax/issues/6


Force application redirect after completion

Because the pages were stored in the browser history the users could
still use the browser back button.
This was designed to set the application processed page to expire and
force a reload/redirect if trying to view in the same browser session.

Looks wholesome :custard:


FEATURE REQUEST ... button "close" should NOT close ScreenToGif

When you press "Record" and then rethink something and want to go back to "main screen" - you often press "Close" button at top-right. And it should return you to the previous window, whatever the window it was. It works like this literally everywhere.
Here is another action - it closes ScreenToGif at all:

IMO, it has to do the same as "left arrow" button - just "go back".
//////////
The same annoying behavior is in the editor. When you click on top-right "close" button - it will close the entire ScreenToGif. But it should close only the editor.
I think everyone record their first (or maybe 2nd or 3rd) gif by wrong way. And after they made some mistakes in the recorded gif - they want to close the editor and re-record it again - and every time they should launch ScreenToGif again and again.
Please, fix this "close button" behavior. It should close only that window, to which it belongs.
Thanks.

I agree with the first part of your request, the close button won't close the app anymore when opened from the Startup window (I removed the back button, now there's only the close button).
I don't agree with the second part, the editor should close if the close button is pressed. The editor is capable of doing the same thing that the Startup window does.
But, (with the next release) the app will provide a tray icon that will stay visible even if the last window gets closed (optional), capable of launching the recorders/editor/options via keyboard shortcuts or via a context menu.
TL;DR: Close button of the recorders will return to the Startup window.

@NickeManarin
awesome! "Hide to tray" decision - is the great one!


Update cache-howto-common-cache-patterns.md

freshness update

Hi @Rick-Anderson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (riande). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Destination and Source Callback-Delays are not shown

Checklist

[X] I've read the contribution guidelines.
[X] I've confirmed the issue is certainly related to this repository. If not, please consider to make a new issue in https://github.com/tier4/caret/issues

Description
read_arch.get_path('<target_path>').verify() returns True, so Caret_analysze confirmed that it should understand the whole path.
In my scenario it doesnt show the whole path.
How it is:

How it should be like:

Here you can find my setup (notebook, architecturefile and trace data): https://ufile.io/p5ua9ble

@Tobias-Pe Thank you for repoting the issue.
Unfortunately I cannot download setup files you uploaded to ufile site. Could you attach the zip file directly to this thread ?

issue.zip ah didnt know i can just paste it here ^^

@nabetetsu

@Tobias-Pe Sorry for the delay in my response.
Thanks to the data you gave us, we now know where the problem lies.
The issue is handled on this PR: https://github.com/tier4/CARET_analyze/pull/293

@Tobias-Pe
Hi.
The PRs for the changes have been merged, so if you update the repository and run the following zip file, it should draw the figure you are looking for.
issue_resolved.zip
The meaning of the following codes in the zip file can be found on this page.
camera_to_motor.include_first_callback = True
camera_to_motor.include_last_callback = True

@Tobias-Pe
Just a gentle reminder.

Great! I can confirm that it works now 🎉

In this scenario it still works the same:


No possibility to see original link of artifacts

I uploaded several artifacts to the databus and at least for one artifact, I forgot what URL I used to submit data to the databus.
When hovering download button of artifact, I only can see the internal link which is handled by the databus itself, but not the link behind which points to the original source.
Could not find it anywhere.
This would be a nice feature!
Example:
https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore/v6
Hovering download button of "data" artifact points to https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore/v6/modex_tech_wind_turbine_onshore_type=data.csv
But I want an information about original source which would point to the OEP.

Hi @henhuy,
we did the URL masking to 1. track downloads, 2. have canoncial URIs for files and 3. to implement ACL / permissions later.
We will eventually include it in the UI to view the link, but I guess this will a later version, e.g. 2.3+
At the moment, you can get the download url via:
curl https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore/v6/modex_tech_wind_turbine_onshore_type=data.csv

resulting in:
Temporary Redirect. Redirecting to https://openenergy-platform.org/api/v0/schema/model_draft/tables/modex_tech_wind_turbine_onshore/rows?form=csv&where=version=v6

alternatively, you can use the web developer tool in the browser:

@kurzum  test how the 2.1.0 version actually implements it.

UI masking is still a thing in 2.1.0, but tracking (i.e. counts) is not explicitly done in the Databus. This can be done via access logs though.
The full metadata document of a Databus Version can be accessed via SPARQL query or by curling for any other format than HTML
e.g.
curl -H "Accept: application/ld+json"  https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore/v6

The returned JSONLD will contain the downloadURLs.
Alternatively, a SPARQL query against https://energy.databus.dbpedia.org/sparql can do the trick:
PREFIX rdfs:   <http://www.w3.org/2000/01/rdf-schema#>
PREFIX rdf:    <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX dcat:   <http://www.w3.org/ns/dcat#>
PREFIX dct:    <http://purl.org/dc/terms/>
PREFIX dcv: <http://dataid.dbpedia.org/ns/cv#>
PREFIX dataid: <http://dataid.dbpedia.org/ns/core#>

SELECT ?file  ?downloadURL WHERE
{
	GRAPH ?g
	{
		?dataset dataid:artifact <https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore> .
		{ ?distribution <http://purl.org/dc/terms/hasVersion> 'v6' . }
		?dataset dcat:distribution ?distribution .
		?distribution dataid:file ?file .
                ?distribution dcat:downloadURL ?downloadURL .
	}
}

I took the query from the "Query" tab of the file browser on the version page (https://energy.databus.dbpedia.org/felixmaur/modex/modex_tech_wind_turbine_onshore/v6) and modified it to include the download URL.
If this turns out to be a very frequent user activity, we can consider adding this to the GUI at a later stage.


fix: image upload: hide --image-alias, add --rename

--image-alias if set, renames the uploaded images before upload, so it is confusing for the user that no image alias is set
This PR hides the --image-alias flag in the help text, and introduces --rename flag. Both of these flags are handled the same in the actual implementation of the command, so there is no change for existing automation that uses ionosctl

#411


WLED Device cant be choosen as device

Describe the bug
WLED Device cant be choosen as device.
Versions:

WLED Adapter version: 0.7.2
smartcontrol Adapter version: 2.0.1
JS-Controller version: 5.0.16
Node version: v18.17.1
Operating system: Ubuntu LTS

Object Browser:

smartcontrol:

This adapter has been moved to iobroker-community-adapters. DO NOT OPEN ANY NEW ISSUES HERE as they will not be processed.
This adapter is now maintained at
https://github.com/iobroker-community-adapters/ioBroker.smartcontrol
Please open issues at this repository if you encounter any problem.


Fixes type for $ReadOnlyArray

fixes: #3448

Can you rebase and re-record the type-at-pos test? Sorry that the Travis tests were broken for so long, they should be passing now.


Handle missing socket when warning about OpenSSL version

What was the end-user problem that led to this PR?
Stubbing Rubygems requests with WebMock was causing undefined method 'io' for nil:NilClass errors when using Bundler 1.16.0.pre.1
What was your diagnosis of the problem?
My diagnosis was that the new warning text about old OpenSSL versions didn't consider the case that a connection might not have an @socket variable set.
What is your fix for the problem, implemented in this PR?
Guard against this by returning early in that case.
Why did you choose this fix out of the possible options?
I chose this fix because it works, and because Net::HTTP itself has some guards in it around nil values for @socket (example). This isn't my area, though, so it could be that a fix is needed in WebMock, not here...

good catch!
@bundlerbot r+


Add missing props in Button.md

There is missing prop upperCase.
Also, I added disabled button example and defaultProps.

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   79.44%   79.44%
=======================================
  Files          16       16
  Lines         715      715
  Branches       99       99
=======================================
  Hits          568      568
  Misses        147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59a619...7528b7d. Read the comment docs.


Smoke: Notebooks moves focus in and out of output

1) VSCode Smoke Tests (Web)
       VSCode Smoke Tests (Web)
         Notebooks
           moves focus in and out of output:
     Error: Timeout: is active element 'webview, .webview' after 20 seconds.
      at /Users/runner/work/1/s/test/automation/out/code.js:182:23
      at Generator.next (<anonymous>)
      at fulfilled (/Users/runner/work/1/s/test/automation/out/code.js:9:58)

https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=81426&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=1fbbf8a8-a0a4-519f-def5-b5fd8ca21811&l=107

I have run it many times and haven't been able to repro it yet


Support site-relative links

AB#386097

Can you add a test for this?

Thanks for adding the tests... looks like a build step failed tho.

Thanks for adding the tests... looks like a build step failed tho.

Hey no problem @lamebrain , fixing up a few things in the tests. Should be good to go shortly.


Default value for placeholder

Hi,
is it possible to set a default value for a specific placeholder-key and use this in all strings?
I am asking because we are currently building a white label feature for our product.
In this feature the user can replace the product name with it´s own name.
So if i have strings like:
"Welcome to {{product_name}}",
"Thanks for using {{product_name}}"
It would be nice if i could set the value of product_name globally.
Hope this makes sense.
Kind regards
André

No, this is not possible at the moment. Feel free to make PR adding such a base default parameters integration.
In your case, you could try to make solution with a generated translation map also.

Did this get anywhere? I need this :D


Hook into events

Hey there,
I'm currently running into a few use cases where it'd be super helpful to have one or both of the following features:

Some way to run a callback after a successful image upload. $('.editor').on('imageUploadSuccess', callback); or something along those lines would be useful.
A way to modify the data argument passed into $.ajax uploading/deleting an image using server-side scripts. This makes it difficult to use this plugin on Rails projects using CSRF tokens, as there's no way to pass them along with the request without actually modifying the plugin.

Is there any workaround to accomplish either of these things with the current version? If not, is this something that others would find useful enough to include in future versions?
Thanks in advance, and great work on this plugin!

Right now it's not possible, but you're right, it would be useful. You can submit a PR, if you've already added it into your project.


RecoveryServicesBackup API version change

As mentioned in https://azure.microsoft.com/en-us/updates/recovery-services-rest-api-version-deprecation-notice/ older API versions than 2019-05-13 are being deprecated.
As a possible result, I have previously working code that is now reporting the error:
msrestazure.azure_exceptions.CloudError: Azure Error: BMSUserErrorInvalidAPIVersionMABProtectedItemsList
Message: Invalid API version for GetBackupProtectedItems.
Please user api version 2019-05-13 or higher.

Updating the instation of the RecoveryServicesBackupClient by using a specific API version as below does not seem to work. New client is instantiated as below:
credentials = ServicePrincipalCredentials(client_id=str(rh.client_id), secret=str(rh.secret), tenant=rh.tenant_id)

    return RecoveryServicesBackupClient(credentials, sub_id, api_version="2019-05-13")

Is this possibly due to the API version being fixed, for example in https://github.com/Azure/azure-sdk-for-python/blob/466b0ba028fab8f14a4bbe2e7cc0cb639fd014d6/sdk/recoveryservices/azure-mgmt-recoveryservicesbackup/azure/mgmt/recoveryservicesbackup/operations/protected_items_operations.py#L36 ?

@Webspider: Unfortunately, the python SDK is not routing to the latest API. We are in the process of publishing the latest python SDK which routes to this. May I know if you are protecting MAB items? If you are not retrieving MAB (Azure Backup agent - protecting files and folders), you can edit your code to include backupManagementType filter and it should work.

@pvrk at this point we're protecting Azure VMs (IaaSVM) only.
Please explain about backupManagementType filter, where should it be applied?
simplfied version of used code is:
credentials = ServicePrincipalCredentials(client_id=str(rh.client_id), secret=str(rh.secret), tenant=rh.tenant_id)
backup_client =RecoveryServicesBackupClient(credentials, sub_id, api_version="2019-05-13")

pil = backup_client.backup_protected_items.list(vault_name=this_vault.arm__vault_name,
                                                            resource_group_name=this_vault.arm__rg_name)

for pi in pil:
  do_magic_stuff_for(pi)

By passing as a filter "vm_filter = "backupManagementType eq 'AzureIaaSVM'"
Can you please try this?

filter_string = _get_filter_string({
'backupManagementType': 'AzureIaasVM'})

Hi!
Confirming that the following call fixes the issue for us:
pil = bu_client.backup_protected_items.list(vault_name=this_vault_name,
                                                           resource_group_name=this_vault_rg,
                                                           filter="backupManagementType eq 'AzureIaaSVM'")

We have released the latest python version which fixes this error. With this, you should be able to use this without the above filter.
https://pypi.org/project/azure-mgmt-recoveryservicesbackup/0.5.0/

Closing this issue. Please feel free to re-open if this doesn't fix the problem.


Error when importing withStyles when migrating from version 4 to 5

I've been modifyng my codebase to get the latest version but when I changes the import statement for the withStyles module I'm having an error

[ x ] The issue is present in the latest release.
[ x ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

My project is not working due to that import error
Expected Behavior 🤔
Importing the withStyles Module

Steps to Reproduce 🕹
I've been trying to import the module withStyles as
import { withStyles } from '@mui/styles';

Steps:

upgrade version from 4 to 5
import the withStyles module
run the project

Context 🔦
I'm building a desktop aplication with electron.js
Your Environment 🌎
Windows 10

This is the error that I'm getting:

The issue was thatI had installed @material-ui/styles/
I fixed it by removing it.


Addresses #5090 extending new NodeRequireFunction interface for specialized constructor signatures

Addresses #5090 extending new NodeRequireFunction interface for specialized constructor signatures

@jedmao could you review this PR?

Looks good except for changing the indentation. Preserve tabs and squash your commits and I'll give it a thumbs up.
See https://github.com/borisyankov/DefinitelyTyped/blob/master/github-electron/.editorconfig and the discussion at https://github.com/borisyankov/DefinitelyTyped/issues/4211
Also, you can download an EditorConfig plugin for a supported editor to take care of this for you automatically upon opening a file.

OK, I tabified and squashed.  I'm not sure I did it right (that was all new to me).

Merge conflicts. You need to rebase on master. Also, you might want to use the word fixes, resolves or closes instead of "addresses" in your original comment to this PR, because it will automatically close the associated issue. See https://help.github.com/articles/closing-issues-via-commit-messages/

Can you please elaborate on how I rebase on master?  Thanks.  I made this branch just for this fix and I made no other changes since to my master.

$ git checkout master
$ git pull upstream master
$ git checkout 5090
$ git rebase master
$ git merge-tool
$ git rebase --continue
$ git push origin 5090:5090 --force

http://www.git-scm.com/book/en/v2/Git-Branching-Rebasing

Better?

That fixes the merge conflicts, but your commits are no longer squashed? When you're done, there should be only one commit left and you shouldn't have other GitHub users' commits in there. See http://davidwalsh.name/squash-commits-git

Ugh!  OK, originally I had made these changes in my own master and then branched just for this PR.  I figured it would get cleaned up eventually once merged.  Now I know.  I threw out the old commits and resquashed and I think everything is right now.

@Gitgiddy I feel like I haven't used the merge command in years. I'm pretty much always rebasing my changes on top of master or some feature branch. Thanks for pushing through this! :+1: from me.

@vvakame :+1:

@jedmao thanks!
@Gitgiddy thanks mate!


Redis cluster

Is it possible to use this operator to create a dragonfly cluster in cluster mode?

Hey @XLordalX, This is not supported in the current mode yet but once Dragonfly fully starts supporting cluster mode (which is currently in works), we can start the operator part to add a setting and to run it.

Hey, are there any update on this?

Couldn't one perfectly seed in the configuration needed --cluster_mode=emulated or --cluster_mode=yes when deploying the instance. Through the args one can set?


yolov4demo defining the object to be detected

Thanks for this work!
Where is the object class to be detected defined (out of 80 classes) in yolov4demo.py? The class 'car' is defined somewhere I believe so where to change that?

Hi, @ogencoglu!
The class car is defined in row 67 (  if box[-1] == 2 ).


Make experimental component icons consistent

Related issue
Fixes #2883
Overview
Inline buttons are being used across several components so the CSS can be reused.
Icons need to be consistently sized.
Link to preview
https://inlinebutton-icon.netlify.app/
Reason

Required across all v3 components with an inline button

Work carried out

[x] Refactor code
[x] Update icons
[x] Fix separator

Affected components

DatePickerE
NumberInputE
SelectE
TextInputE

Updates deployed https://inlinebutton-icon.netlify.app/?path=/story/select-experimental--default

👍 Perfect, thanks!


Feature | Add more formatting options to the Editor

Where ?

User signs in
User clicks on write
User starts typing, selects a text

What ?
At the moment, there are limited formatting options. (see screenshot)
Expectation
Add more standard formatting options

code
Numbered List / Unordered List / Tasklist

Screenshot

Hi @aadeshkulkarni Can you assign this ?

Sure, done


Add d(days) h(hours) m(minutes) s(seconds) to countdowns

Currently looks like this which isn't so clear:

Adding the extra info helps:

@Chwy5 to confirm whether we need to display seconds

@Chwy5  is this absolutely needed for V2 launch?

pushing to post v2....
Should Be worked post