Unable to deploy common partition

Environment

Application Services Version: 3.24.0'
BIG-IP <IP_ADDRESS> Build 0.0.8 Point Release 5

Summary
When submitting the /Common/Shared declaration with a single pool containing x amount of nodes (serverAddresses) it fails with status 422 and message "Cannot read property 'forEach' of undefined",
This is done as an attempt to try and mitigate: https://github.com/F5Networks/f5-appsvcs-extension/issues/340
I have removed everything in /Common/Shared prior to submitting this declaration, and that went OK, so there are no references from the old bigip gui conf that we are running in parallel (I have also checked bigip.conf files).
All nodes (including pool members) in this f5 device lives in Common (including those that lives in manually managed "f5 gui partitions").
Edit: after some more tests and removing lots of the nodes (in the real example I have 180+ nodes but I removed many of them to make the example clearer). Anyway, when I removed the majority of the nodes and only included a few ones (and then only nodes that are not referenced by another as3 declaration (we have 1), then I received the following error instead: "response": "01020066:3: The requested Node (/Common/<IP_ADDRESS>%100) already exists in partition Common.",
So I think this one is related to the previous issue I have placed https://github.com/F5Networks/f5-appsvcs-extension/issues/340. Would be great if this would be fixed at the same time (and if so, do you have any estimate when the previous issue might be fixed? :) )
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
  "class": "AS3",
  "action": "deploy",
  "persist": true,
  "declaration": {
    "class": "ADC",
    "updateMode": "selective",
    "id": "5aa57f66-1b9b-4c16-ac7c-bf629f557d70",
    "schemaVersion": "3.24.0",
    "Common": {
      "class": "Tenant",
      "enable": true,
      "Shared": {
        "class": "Application",
        "template": "shared",
        "enable": true,
        "all_nodes_pool": {
          "class": "Pool",
          "loadBalancingMode": "round-robin",
          "serviceDownAction": "none",
          "members": [
            {
              "servicePort": 54322,
              "serverAddresses": [
                "<IP_ADDRESS>%100",
                "<IP_ADDRESS>",
                "<IP_ADDRESS>%2",
                "<IP_ADDRESS>",
                "<IP_ADDRESS>%2"
              ],
              "priorityGroup": 0,
              "shareNodes": true
            }
          ]
        }
      }
    }
  }
}

Observe the following error response:

results: [
  {
     "message": "Cannot read property 'forEach' of undefined",
     "host": "localhost",
     "tenant": "Common",
     "code": 422
  },
  {
     "message": "Cannot read property 'forEach' of undefined",
     "host": "localhost",
     "tenant": "Common",
     "code": 422
  }
]

Expected Behavior
The /Common/Shared partition to deploy successfully.
Actual Behavior
The declaration fails to deploy.

Following your steps for reproduction I was unable to reproduce the issue. I get the following response to your declaration:
    "results": [
        {
            "code": 200,
            "message": "success",
            "lineCount": 24,
            "host": "localhost",
            "tenant": "Common",
            "runTime": 4470
        },
        {
            "code": 200,
            "message": "no change",
            "host": "localhost",
            "tenant": "Common",
            "runTime": 3324
        }
    ],

I suspect you are getting an error because of existing BIG-IP configuration. Can you provide the tmsh configuration of any relevant nodes already on the device?

Following your steps for reproduction I was unable to reproduce the issue. I get the following response to your declaration:
    "results": [
        {
            "code": 200,
            "message": "success",
            "lineCount": 24,
            "host": "localhost",
            "tenant": "Common",
            "runTime": 4470
        },
        {
            "code": 200,
            "message": "no change",
            "host": "localhost",
            "tenant": "Common",
            "runTime": 3324
        }
    ],

I suspect you are getting an error because of existing BIG-IP configuration. Can you provide the tmsh configuration of any relevant nodes already on the device?

I did some further more extensive checks and I have verified that this happens when there's a node (in Common) belonging to an existing "bigip gui created" pool.
This in in other words similar to: https://github.com/F5Networks/f5-appsvcs-extension/issues/340 with the difference that this log message is the result of some kind of internal error rather than a logical error.
To reproduce the error:

Create a pool in the GUI with a pool inside common
Create an as3 declaration with shareNodes: true and use the same ip address as the one you created in the GUI.
See error: "message": "Cannot read property 'forEach' of undefined"

I did some further more extensive checks and I have verified that this happens when there's a node (in Common) belonging to an existing "bigip gui created" pool.
This in in other words similar to: https://github.com/F5Networks/f5-appsvcs-extension/issues/340 with the difference that this log message is the result of some kind of internal error rather than a logical error.
To reproduce the error:

Create a pool in the GUI with a pool inside common
Create an as3 declaration with shareNodes: true and use the same ip address as the one you created in the GUI.
See error: "message": "Cannot read property 'forEach' of undefined"

I was able to reproduce and confirm the bug. I have added it to our internal product backlog as AUTOTOOL-2136. Thank you for reporting the issue.

I was able to reproduce and confirm the bug. I have added it to our internal product backlog as AUTOTOOL-2136. Thank you for reporting the issue.

It looks like this was resolved while fixing a similar bug. The fix should be available in the 3.27.0 release.

This issue was resolved in the 3.27.0 release.

@jainvijay1 it is recommended to deploy in an application tenant. Please review the best practices document https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/userguide/best-practices.html#keep-the-number-of-applications-in-one-tenant-to-a-minimum

Agreed, But we have deployed our application in Common Partition only. Is there any way i can use AS3 for automation?

@jainvijay1 recommend deploying those application to an application partition and avoid common. Use Common for policies, profiles, common nodes etc. AS3 tenants can reference these /Common objects. Here is an example https://support.f5.com/csp/article/K41856551

@jainvijay1 recommend deploying those application to an application partition and avoid common. Use Common for policies, profiles, common nodes etc. AS3 tenants can reference these /Common objects. Here is an example https://support.f5.com/csp/article/K41856551

Thanks. I'm able to deploy the Virtual Server with using /Common objects and it's working as expected. Actual problem is when I deployed the VS one time it's works but when try to create second VS it overwrite the first created one. Not sure why this is happening? Please advise.


Improve IdentityConversion check

Resolves an issue found while testing Error Prone Support against Checkstyle (currently testing on this branch).
Suggested commit message:
Improve `IdentityConversion` check (#407)

If the result of an explicit boxing operation is immediately
dereferenced, then the explicit conversion operation is not redundant.

Hmm, is this an improvement or a bug fix?

Label-wise: bug fix :+1:
Suggested commit wise: would leave as-is.

Ah yes I only meant label-wise 😄. Nice.


Update tests for undefined, null and empty values

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   97.69%   97.69%
=======================================
  Files          13       13
  Lines         217      217
=======================================
  Hits          212      212
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177c548...a1d393b. Read the comment docs.

I think it is better to add  a test of undefined in required.spec.js.

Hi, is there anything wrong with the commit?
If there is I appreciate your feedback.

No, it's all right. Thanks!


Support OAS3 in validateSwagger task

https://github.com/int128/gradle-swagger-generator-plugin/issues/86

any chance this can be merged in? would be great to have validation for OAS3

any chance this can be merged in? would be great to have validation for OAS3

any chance this can be merged in? would be great to have validation for OAS3

It's ready for review @int128

any chance this can be merged in? would be great to have validation for OAS3

It's ready for review @int128

Thank you for your contribution!

Thank you for your contribution!


Page not found link to  https://www.le.ac.uk/

In learn-c.org
https://github.com/ronreiter/interactive-tutorials/blob/master/tutorials/learn-c.org/en/Arrays and Pointers.md
You may go through Pointers and Arrays for a further detailed discussion on this topic.
Not found external link to Pointers and Arrays https://www.le.ac.uk/users/rjm1/cotter/page_59.htm

This was fixed.


feat: ban-user command

created a command npm run ban-user to ban a specific user "theoretically" permanently

Change Type

[x] New feature (non-breaking change which adds functionality)

Testing

controllo da diverse browser con diversi IP se l'utente è stato bannato e che non può inviare piu messaggi

NOTE: When the account is banned, if I restart the server I can log back in but the moment I write a message and send it, it kicks me out and doesn't send the message
Checklist

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] I have commented in any complex areas of my code
[x] I have made pertinent documentation changes
[x] My changes do not introduce new warnings
[x] I have written tests demonstrating that my changes are effective or that my feature works
[x] Local unit tests pass with my changes
[x] Any changes dependent on mine have been merged and published in downstream modules.

why not also allow a user input for the duration?

Why not also allow a user input for the duration?

Because I can't find a way to specify the time

Why not also allow a user input for the duration?

Because I can't find a way to specify the time

 const errorMessage = {
    type: 'concurrent',
    violation_count: 20,
    user_id: user._id,
    prev_count: 0,
    duration: 1000 * 60 * 60 * 24 * 7,
  };

  await banViolation(req, res, errorMessage);

You're specifying the duration here, I believe.

Why not also allow a user input for the duration?

Because I can't find a way to specify the time

 const errorMessage = {
    type: 'concurrent',
    violation_count: 20,
    user_id: user._id,
    prev_count: 0,
    duration: 1000 * 60 * 60 * 24 * 7,
  };

  await banViolation(req, res, errorMessage);

You're specifying the duration here, I believe.

Yeah, but I'm perma banning, that 'duration' doesn't work or it is being ignored by something else.

please remove changes to package-lock.json
Bumping dependencies should be in a standalone PR

Sorry, I had added everything and hadn't noticed.


Support arbitrary SAR anamorphic video

This adds an aspect ratio input parameter
to the Rust and C APIs, computes the render
size by upscaling one dimension, and codes
it in-bitstream, as well as in Y4M output.
The default aspect ratio is parsed from
Y4M input, or set to 1:1 if absent.
Note that neither aomdec nor dav1d will propagate the bitstream render size to the Y4M files they output.
It doesn't seem to be honored by ffmpeg with aomdec either, but it might be with dav1d (haven't tested it myself, but the code seems present). Reconstruction output is affected as well.
I think we can close #2504 with this, as it implements everything that should be needed for decoders/players to correctly output/display the encoded video.

Coverage increased (+0.07%) to 83.047% when pulling 45ce98cbaf505f3cc2304c0650f8656bb652705a on rzumer:aspect-ratio into fe87644812b2c8b5edb9cdf7dc4c39aafe2c647d on xiph:master.

Needs a revision to propagate SAR rather than DAR. Please hold...

Thinking more about this, shouldn't it be per-frame?

I think we can leave that as future work.

I moved the parameters to FrameInvariants where they should be. I first thought you were suggesting to make aspect ratio variable per-frame via the API.

@rzumer I was indeed saying it should be per-frame in the API. Aspect ratio may change midstream, and should be supported either via frame properties, or via encoder-reconfig, I believe.

Then as mentioned earlier I prefer it to be left as future work considering how rare of a use case it is.

Maybe this should instead set frame_size_override_flag to 1 on inter frames and take the frame and render dimension values from one of the frames they reference in the ref_frame_idx[] array (The frame_size_with_refs() function defined in Section 5.9.7).
That way you'll save 4 bytes per frame header used to code the same render dimension values.

@jamrial That works as long as frame size is static. We can probably assume it is for now though.

Afailk, it can also work for non static frame sizes by ensuring a given inter frame references a frame with the exact same values it would otherwise write. If none of the seven potential reference frames share the exact same values, then they are explicitly written instead.

I see, I'll look into adding that but I also don't think it's a blocker for merging.

If you'd rather not bother looking at the values for each of the seven reference frame since for now the sizes are fixed, then it's a matter of setting frame_size_override_flag to 1 and implementing frame_size_with_refs() as a single bit found_ref to signal that the first reference frame should be used by the decoder to infer this frame's dimensions.

After looking into it I don't think this frame_size_override has the same effect as overriding the render_size. Seems to me that frame size is related to the number of luma samples, while render size signals players to rescale the frame when displaying it. Unless this part of the spec is inconsistently written and poorly defined, and the aomdec behavior matches what you're implying, I'd keep the current implementation.

No, it doesn't have the same effect. frame_size_override_flag means that either frame dimensions, render dimensions, or both, may be coded in the frame or should be inferred from a reference frame. For this specific case, frame dimensions and render dimensions will be constant for the entire video sequence, so setting both frame_size_override_flag and render_and_frame_size_different to 1 and then taking the first reference frame's dimensions is the same as signaling only render_and_frame_size_different and coding the render dimensions in the frame, except it doesn't use four bytes for it.
See the code below
diff --git a/src/header.rs b/src/header.rs
index 194c0510..7c66fe98 100644
--- a/src/header.rs
+++ b/src/header.rs
@@ -538,7 +538,14 @@ impl<W: io::Write> UncompressedHeader for BitWriter<W, BigEndian> {
       //self.write(frame_id_len, fi.current_frame_id);
     }

-    let mut frame_size_override_flag = false;
+    let render_and_frame_size_different = fi.render_width != fi.width as u32
+      || fi.render_height != fi.height as u32;
+
+    // This assumes frame dimensions are the same as sequence header dimensions,
+    // and that only render dimensions may be different but nonetheless constant
+    // for the entire video sequence
+    let mut frame_size_override_flag = render_and_frame_size_different && !fi.intra_only
+      && !fi.error_resilient;
     if fi.frame_type == FrameType::SWITCH {
       frame_size_override_flag = true;
     } else if fi.sequence.reduced_still_picture_hdr {
@@ -606,8 +613,6 @@ impl<W: io::Write> UncompressedHeader for BitWriter<W, BigEndian> {
       if fi.sequence.enable_superres {
         unimplemented!();
       }
-      let render_and_frame_size_different = fi.render_width != fi.width as u32
-        || fi.render_height != fi.height as u32;
       self.write_bit(render_and_frame_size_different)?;
       if render_and_frame_size_different {
         self.write(16, fi.render_width - 1);
@@ -640,7 +645,11 @@ impl<W: io::Write> UncompressedHeader for BitWriter<W, BigEndian> {
       }

       if !fi.error_resilient && frame_size_override_flag {
-        unimplemented!();
+        //TODO: check reference frames to compare frame dimensions
+        self.write_bit(true)?; // found_ref[0]
+        if fi.sequence.enable_superres {
+          unimplemented!();
+        }
       } else {
         if frame_size_override_flag {
           self.write_frame_size_override(fi);
@@ -648,9 +657,6 @@ impl<W: io::Write> UncompressedHeader for BitWriter<W, BigEndian> {
         if fi.sequence.enable_superres {
           unimplemented!();
         }
-        let render_and_frame_size_different = fi.render_width
-          != fi.width as u32
-          || fi.render_height != fi.height as u32;
         self.write_bit(render_and_frame_size_different)?;
         if render_and_frame_size_different {
           self.write(16, fi.render_width - 1);

I mean, I'm fine with this change but it seems like it should be separate from this PR.

Sure, i can send a PR for it after this one is merged.
Also, here's a complex sample where frame dimensions vary between frames (But render dimensions are constant), and uses the frame_size_with_refs() logic to avoid coding the values in the bitstream when a reference frame shares the same values, if you're curious.
https://code.videolan.org/videolan/dav1d/uploads/e41cf2423c6ae93e2a0a4fc9ae543730/resize.ivf

Then as mentioned earlier I prefer it to be left as future work considering how rare of a use case it is, unless there is already a framework for setting parameters frame by frame (I can't see anything in the api/config module).

I think it should be doable with an encoder reconfig API, so doing it eoncig level should be OK, I suppose. Color properties are done this way too.


Time synchronization inside LCOW UVM

Currently LCOW UVM doesn't run any time synchronization service which causes a small amount of time lag after running the UVM for a long time (~10 days).
This change updates OpenGCS to start chronyd daemon as soon as gcs is started. It also adds a new annotation which can be used to disable this service inside the UVM.

Do not merge this before we make the required changes to use the updated LCOW drop.

Do not merge this before we make the required changes to use the updated LCOW drop.

In the future I think we can use a draft PR for cases like this.

I wonder if there's any way we could run chronyd as a privileged infra container, and avoid needing to do this extra work in the gcs?


[HxSideBar] Menus only opening, not closing?

Hi just got the HxSideBar menu to work (thanks @hakenr), but for some reason the multi level menus only opens but can't be closed?
There is no error message in the console. You simply cannot collapse the menus.

Never mind, had two Bootstrap references. Removed one and now it works. Geez.

Hello,
I'm not sure what you mean by "multi-level menus" - only one level of expansion is supported.
For supported behavior, check out the demos here: https://havit.blazor.eu/components/HxSidebar. The entire demo site uses an HxSidebar as well.
If you have only one level of expansion and still can't collapse it, please send us a repro code so we can investigate further. Note that if you expand another node, previously expanded nodes won't collapse automatically unless you set MultipleItemsExpansion="false".

Never mind, had two Bootstrap references. Removed one and now it works. Geez.

Thanks for confirmation. Enjoy our components.

Thanks again @hakenr for your quick reply. It's good to know that there is someone out there that can help out. Much appreciated, and it makes me much more comfortable using this component set (great set by the way).


Update scodec-bits to 1.1.17

Updates org.scodec:scodec-bits from 1.1.16 to 1.1.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scodec", artifactId = "scodec-bits" } ]

labels: library-update, semver-patch

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           46        46
=========================================
  Hits            46        46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e18e82...17c1b8e. Read the comment docs.


Ashish main

Adding the official influxdb support.
Used docker-compose run time
Updated Readme Files

@codervinod / @AnmolVirdi For conflict resolution, which approach is here, as I have not modified the conflicted file.
Should i take my changes or take the main branch changes ?


Design on cluster API integration with cluster registry

One of the ideas here is that we want to have an option during cluster creation (in the api or in the deployment tool) to register the cluster with any registry endpoint.

/assign karan

/kind feature

This issue was moved to kubernetes-sigs/cluster-api#57


cypress: add x86_64-darwin support

And reuse the hash name, instead of mixing checksum and sha256.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This looks to be exactly what I need.
How long does it generally take for these PRs to get approved?


Misspelling errors

This is not a misspelling. This is a MATLAB warning in eigs. It is present in R2016b, but was removed in a refactor in a later release, so it's absent in R2022b.


[Misc]Suppress irrelevant exception stack trace information when CUDA…

FIX #11437

Thanks!

/rerun

Could you help me check how to fix the failed checks? This is my first time submitting a PR  @robertgshaw2-neuralmagic


Redundant coordinate when finish polygon with double click

Double Click in leaflet will (of course) always fire the regular click twice.
When double clicking to finish a polygon, these are the events firing in order:
Current behavior:

click (creates vertex)
click (creates vertex)
double click (finishes shape).

This behavior means we have two vertexes on the same coordinates - one is redundant.

b) is kind of hacky while a) needs debounce / delay in the click handler. I might go with a), and devs who want to enable finishOnDoubleClick have to live with the delay for the clicks.
I'd like feedback from users on this one.

Hello,
I agree with B being a little hacky but delay with clicks would be awful with solution A.
So i would go with B anyway and remove the last created vertex on double click.
You must keep good performances you got so far.

thanks for the feedback. I can definitely understand that. 🤔  it's a tough one. I have to think a bit more about the solution before implementing it.

Currently, i just snap. I draw three point polygon but when I export it as geojson it has four points (first and last are duplicate)

@leekosal that's the geojson spec
http://geojson.org/geojson-spec.html#linestring
It's not the issue discussed here.

i see. thanks 👍

I tried double click, but it doesn't work. I set up a demo: http://jsfiddle.net/LnzN2/1225/. Could we solve it with right click button (so there is no problem with clicking and adding vertex?

@themre finishOnDouble click generally works: http://jsfiddle.net/LnzN2/1226/
The problem in your fiddle is, that the Toolbar doesn't accept the same options as the API.
So you can't pass "finishOnDoubleClick" to it. The relevant issue is #117. Could you add your need in there so we can discuss solutions?

Could we provide option finishOn as name of the event? because then someone could decide to handle closing polygon on different events. like finishOn: 'contextmenu'. this line https://github.com/codeofsumit/leaflet.pm/blob/develop/src/js/Draw/L.PM.Draw.Line.js#L51 would be changed to something like:
if(this.options.finishOn) {
      this._map.on(this.options.finishOn, this._finishShape, this);
 }

this is a sample, how it would work with right click. i can create PR if you would like. I noticed in leaflet docs this event is fired on long press on devices, so this is also covered.

that's a neat idea. Please do a PR, I'll review next week 👍

could you take a look at PR if there is something else i'm missing?

The double click little bug is still happening, unfortunately. Sometimes (not always), double click will add two points which are exactly the same. This causes turf to think there's a self-intersection problem with the layer.
I worked around it by closing the polygon if the the new vertex is exactly the same as the previous vertex (in addition to closing the polygon if you clicked the first one). This seems to solve the issue.

Unfortunately the double click bug is still happening and I'm not sure how to work around it. Unfortunately the second click generates a new vertex at a slightly different location than the original one. Sometimes this causes a self-intersect issue.
I'm tempted to ignore the last vertex when the user double clicks but that is a far from ideal solution. Anyone managed to work around this?


onError method

Hi, Need a help with on error method. There is a error string from render method, where we can see video recording error. But I need somth like onError method which calls once where error trigreend, because I need state change, when error. SetState on render method is not acorrect in React.


Examples for denormalizing multi-file CLDF datasets

See https://github.com/cldf/pycldf/issues/82#issuecomment-488645237

This is dealt with in most examples. The long-to-wide issue cannot be addressed generically, because there is no general rule on datasets having just one datapoint per language/parameter (many have not e.g. PHOIBLE, APiCS, many Wordlists).


Where's the source to the Demo GIF?

finally getting some time for this. give me a day or two.

@lelandrichardson No pressure :)

@fatuhoku I've updated the repo to use the new Animated API. The big catch is that it requires >=0.8.0, and as a result, I've upped the npm version number to 2.0.
I've included a full working example project in the repo, and will update the appetize link to an rnplay.org link as soon as rnplay.org supports 0.8.0
Cheers!


Improvement on Yield Farm page

Hi,
1- I think when an user don't have the asset or both assets on balance, the message instead of (Add liquidity and earn income) should be something like (You need x asset to add liquidity to this pool)
2- If the user do not have the asset to add liquidity, the Deposit button should be inactive.

Would be nice, however each balance check make request to the node which slows down page from showing full info (you may already notice that there is some time when pools are not interactable/dimmed for some time).
So i'm against adding these additional calls until (and if) "multicalls" are implemented to the dapp.


Bug in knapsack jython file

https://github.com/pushkar/ABAGAIL/blob/master/jython/knapsack.py
Somehow the GA and MIMIC functions get scores that exceed the knapsack volume. This shouldn't happen if we have the correct checks in place, right?

Nevermind, I found out that this isn't the metric that we're evaluating it on


FLUID 5935: Update the TextToSpeech component docs

This addresses two issues in our documentation about the TextToSpeech component:

the current version of the component expects the speech options to be configured as part of the component model, while the current version of the documentation specifies configuring it as part of the top-level options block

per the errata at https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi-errata.html, voiceURI is no longer used by the SpeechSynthesisUtterance interface; instead, the voice attribute can be passed a SpeechSynthesisVoice object to configure the voice synth to be used, typically after retrieving it via the getVoices() method or similar.

Longer term we may want to refactor this component design - under the current implementation configuring the voice synthesizer requires storing the SpeechSynthesisVoice object on the model, and I'm not certain without further experimentation if this is a copy-safe operation (that is, does the voice attribute expect and validate for a SpeechSynthesisVoice object, or will any POJO with the correct attributes suffice). However, this PR brings the documentation in line with our own implementation and the current API.

Tapping @jobara who I talked about this issue with this morning.

@jobara - I think I hit all the points of feedback on this.

Do you think this one is good to go in, @jobara?

@waharnum I'm noticing that the padding around the "note" in the tables has a large gap at the bottom but is right up against the text at the top. Do you thin we should balance out that spacing in the table?

merged at cbfe7f487943c1f49078cd6a81437ffa755c1a9d


HDFS-17237. Remove IPCLoggerChannelMetrics when the logger is closed

Description of PR
When an IPCLoggerChannel is created (which is used to read from and write to the Journal nodes) it also creates a metrics object. When the namenodes failover, the IPC loggers are all closed and reopened in read mode on the new SBNN or the read mode is closed on the SBNN and re-opened in write mode. The closing frees the resources and discards the original IPCLoggerChannel object and causes a new one to be created by the caller.
If a Journal node was down and added back to the cluster with the same hostname, but a different IP, when the failover happens, you end up with 4 metrics objects for the JNs:

For for each of the original 3 IPs
One for the new IP

The old stale metric will remain forever and will no longer be updated, leading to confusing results in any tools that use the metrics for monitoring.
This change, ensures we un-register the metrics when the logger channel is closed and a new metrics object gets created when the new channel is created.
For info, the logger metrics look like:
{
   "name" : "Hadoop:service=NameNode,name=IPCLoggerChannel-<IP_ADDRESS>-8485",
    "modelerType" : "IPCLoggerChannel-<IP_ADDRESS>-8485",
    "tag.Context" : "dfs",
    "tag.IsOutOfSync" : "false",
    "tag.Hostname" : "957e3e66f10b",
    "QueuedEditsSize" : 0,
    "LagTimeMillis" : 0,
    "CurrentLagTxns" : 0
  }

Note the name includes the IP, rather than the hostname.
How was this patch tested?
I have added a small test to prove this, but also reproduced the original issue on a docker cluster and validated it is resolved with this change in place.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m  5s

trunk passed

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

-1 :x:
javadoc
1m  5s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 12s

trunk passed

+1 :green_heart:
shadedclient
34m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 9 unchanged - 3 fixed = 9 total (was 12)

+1 :green_heart:
mvnsite
1m 12s

the patch passed

-1 :x:
javadoc
0m 51s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
34m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
209m 29s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

356m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6217/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6217

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 30c2cb3a0a2f 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2766261e79ac836adfcdd2c19c67d5bf79f45cd0

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6217/1/testReport/

Max. process+thread count
3555 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6217/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LGTM. +1 binding. Thanks for fixing this Stephen.

Merged to trunk. Thanks for the review @arp7


should we concatenate addresses and pubkeys?

the UI can concatenate addresses and pubkeys for a friendlier and less cluttered UI.
though, bech32 prefixes have made our address a bit more readable - they are still for computers (let's be honest).
i'd like to propose that we concatenate addresses and pubkeys - the tooltip could display the full address. see below.
this will result in a more readable, less overwhelming, cleaner UI. 🥇
cosmosvalpub12ztjt9nfj20cxw4w4fdg5g0lak83mc23csqzgx
cosmosvalpub...qzgx

cosmosaccaddr1qk2q3l28t6qhzyc7psdffsdf832ep8uwdaer
cosmosaccaddr...daer

I vote yes. We probably need to show some letters in the beginning and some in the end.

are you proposing the following? not sure if i agree. would like others to weigh in. we have these nifty bech32 prefixes which might be "enough".
cosmosvalpub12zt...qzgx
cosmosaccaddr1qk2...daer

Yes this is what I mean. Just for a sense of security.

Do you mean "elide" instead of "concatenate"?

update from SDK (can't find the issue):
cosmosval12zt...qzgx
cosmos1qk2...daer

or
cosmosval...qzgx
cosmos...daer

Do you mean "elide" instead of "concatenate"?

hard to say.

Hö? They renamed cosmosaccaddr to cosmos?

i believe so - @jackzampolin can you link the ticket? i'm sorry, i can't find it 😞

Do you mean this PR?  https://github.com/cosmos/cosmos-sdk/pull/2103

This proposal is about abbreviating addresses.  Concatenate means to link together in a series or chain.

Sounds good to me.

@jbibla https://github.com/cosmos/cosmos-sdk/pull/2103 🙇

add copying #1174

I'm not fully understanding what are we suppose to implement here and what are the functionalities of this component. Does it just need a tooltip ?


Reorganise to facilitate shared code and assets

Implement ideas for #3 and #6

@FokkeZB I left some comments, thanks!

Closing for now, since it was based on the old module structure. I'd be very happy to see a new PR which incorporates with the current structure. Thank you Fokke!


TreeDiagram doesn't place blocks with no bottom level children

Obvious in hindsight

Fixed with rework of TreeDiagram.auto_layout()


Problem with $ npm install

Hi guys this is my problem :
USER@USER-PC MINGW64 ~/angular-phonecat (master)
$ npm install

<EMAIL_ADDRESS>postinstall C:\Users\USER\angular-phonecat
bower install

bower angular#1.5.x          ENOTFOUND Request to https://registry.bower.io/pack                                                                                ages/angular failed: getaddrinfo ENOTFOUND registry.bower.io registry.bower.io:4                                                                                43
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\ch                                                                                okidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@                                                                                1.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}                                                                                )
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\                                                                                node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v6.11.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: bower install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'bower install'                                                                                .
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-phonecat pack                                                                                age,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     bower install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-phonecat
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-phonecat
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\USER\angular-phonecat\npm-debug.log
I hope you know what that is :) Thank you :)

It says that it couldn't find https://registry.bower.io/packages/angular, but it clearly exists. It could be a temporary issue or configurtion issues on your local environment (e.g. some DNS or proxy issue).
Unfortunately, there is not much we can do, I'm afraid 😞


NATIVE-9: Track webview errors

Probably someone needs to take a look at the iOS podfiles :thinking:


Disable statsd, emf and collectd tests since they arent supported by CCWA yet

Description of the issue
Tests currently fail in private repo workflow E2E tests.
Description of changes
Disable them temporarily. We have backlog items to work on them and need to reenable this after.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.

Nit: Please add a comment @TODO in the code with something like add back once we support these metricss


🐛 [firebase_messaging] ios build error: expected a type  - (void)applicationReceivedRemoteMessage:(FIRMessagingRemoteMessage *)remoteMessage

Bug report
ios Build does not succeed. This is the long stack of error I get
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Warning
──────────────────────────────────────────────────────────────────────────────
Your Flutter application is created using an older version of the Android
embedding. It's being deprecated in favor of Android embedding v2. Follow the
steps at

https://flutter.dev/go/android-project-migration

to migrate your project.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Launching lib/env/main_stg.dart on iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: 5Q27WKL54G
Running pod install...
Running Xcode build...
Xcode build done.                                           16.5s
Failed to build iOS app
Error output from Xcode build:
↳
    2021-02-27 01:50:37.064 xcodebuild[10192:7417260]  DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-17705/DTDeviceKitBase/DTDKRemoteDeviceData.m:371
    Details:  (null) deviceType from af503aa13ce4f08052e5c61ceb0c846bd3944e56 was NULL when -platform called.
    Object:   <DTDKMobileDeviceToken: 0x7f8710bbf980>
    Method:   -platform
    Thread:   <NSThread: 0x7f870d9aee40>{number = 3, name = (null)}
    Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
    ** BUILD FAILED **

Xcode's output:
↳
    warning: The Legacy Build System will be removed in a future release. You can configure the selected build system and this deprecation message in File > Workspace Settings.
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/nfc_in_flutter-2.0.5/ios/Classes/NfcInFlutterPlugin.m:567:77: warning: implicit conversion loses integer precision: 'const NSUInteger' (aka 'const unsigned long') to 'int' [-Wshorten-64-to-32]
                                            @"maxSize": [NSNumber numberWithInt:capacity],
                                                        ~                       ^~~~~~~~
    1 warning generated.
    === BUILD TARGET FirebaseCoreDiagnostics OF PROJECT Pods WITH CONFIGURATION Debug-stg ===
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_nfc_reader-0.1.0/ios/Classes/SwiftFlutterNfcReaderPlugin.swift:42:17: warning: variable 'alertController' was never mutated; consider changing to 'let' constant
                var alertController = UIAlertController(title: nil, message: "IOS does not support NFC tag writing", preferredStyle: .alert)
                ~~~ ^
                let
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_nfc_reader-0.1.0/ios/Classes/SwiftFlutterNfcReaderPlugin.swift:102:13: warning: variable 'urlString' was written to, but never read
            var urlString = ""
                ^
    === BUILD TARGET FirebaseCoreDiagnostics OF PROJECT Pods WITH CONFIGURATION Debug-stg ===
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_nfc_reader-0.1.0/ios/Classes/FlutterNfcReaderPlugin.m:6:4: warning: 'SwiftFlutterNfcReaderPlugin' is only available on iOS 11.0 or newer [-Wunguarded-availability-new]
      [SwiftFlutterNfcReaderPlugin registerWithRegistrar:registrar];
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_nfc_reader-0.1.0/ios/Classes/FlutterNfcReaderPlugin.m:2:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/build/ios/Debug-stg-iphoneos/flutter_nfc_reader/flutter_nfc_reader.framework/Headers/flutter_nfc_reader-Swift.h:215:12: note: 'SwiftFlutterNfcReaderPlugin' has been marked as being introduced in iOS 11.0 here, but the deployment target is iOS 8.0.0
    @interface SwiftFlutterNfcReaderPlugin : NSObject <FlutterPlugin>
               ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_nfc_reader-0.1.0/ios/Classes/FlutterNfcReaderPlugin.m:6:4: note: enclose 'SwiftFlutterNfcReaderPlugin' in an @available check to silence this warning
      [SwiftFlutterNfcReaderPlugin registerWithRegistrar:registrar];
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    === BUILD TARGET firebase_crashlytics OF PROJECT Pods WITH CONFIGURATION Debug-stg ===
    While building module 'FirebaseMessaging' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:78:
    In file included from <module-includes>:1:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:34:38: warning: 'UNMutableNotificationContent' is only available on iOS 10.0 or newer [-Wunguarded-availability]
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
                                         ^
    In module 'UserNotifications' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:19:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationContent.h:63:12: note: 'UNMutableNotificationContent' has been marked as being introduced in iOS 10.0 here, but the deployment target is iOS 8.0.0
    @interface UNMutableNotificationContent : UNNotificationContent
               ^
    While building module 'FirebaseMessaging' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:78:
    In file included from <module-includes>:1:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:34:1: note: annotate 'populateNotificationContent:withContentHandler:' with an availability attribute to silence this warning
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
    ^
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:35:47: warning: 'UNNotificationContent' is only available on iOS 10.0 or newer [-Wunguarded-availability]
                     withContentHandler:(void (^)(UNNotificationContent *_Nonnull))contentHandler;
                                                  ^
    In module 'UserNotifications' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:19:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationContent.h:16:12: note: 'UNNotificationContent' has been marked as being introduced in iOS 10.0 here, but the deployment target is iOS 8.0.0
    @interface UNNotificationContent : NSObject <NSCopying, NSMutableCopying, NSSecureCoding>
               ^
    While building module 'FirebaseMessaging' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:78:
    In file included from <module-includes>:1:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/FirebaseMessaging/FirebaseMessaging-umbrella.h:13:
    In file included from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FirebaseMessaging.h:18:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseMessaging/FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessagingExtensionHelper.h:34:1: note: annotate 'populateNotificationContent:withContentHandler:' with an availability attribute to silence this warning
    - (void)populateNotificationContent:(UNMutableNotificationContent *)content
    ^
    2 warnings generated.
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:195:43: error: expected a type
    - (void)applicationReceivedRemoteMessage:(FIRMessagingRemoteMessage *)remoteMessage {
                                              ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:302:53: error: nullability specifier 'nonnull' conflicts with existing specifier 'nullable'
        didReceiveRegistrationToken:(nonnull NSString *)fcmToken {
                                                        ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:307:24: error: expected a type
        didReceiveMessage:(FIRMessagingRemoteMessage *)remoteMessage {
                           ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:141:30: error: property 'shouldEstablishDirectChannel' not found on object of type 'FIRMessaging *'
        [FIRMessaging messaging].shouldEstablishDirectChannel = true;
                                 ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:160:21: warning: 'FIRInstanceID' is deprecated: FIRInstanceID is deprecated, please use FIRInstallations for installation identifier handling and use FIRMessaging for FCM registration token handling. [-Wdeprecated-declarations]
        [[FIRInstanceID instanceID]
                        ^
    In module 'FirebaseInstanceID' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:74:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseInstanceID/Firebase/InstanceID/Public/FIRInstanceID.h:190:1: note: 'FIRInstanceID' has been explicitly marked deprecated here
    __deprecated_msg("FIRInstanceID is deprecated, please use FIRInstallations for installation "
    ^
    In module 'UIKit' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/firebase_messaging/firebase_messaging-prefix.pch:2:
    In module 'Foundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIKit.h:8:
    In module 'CoreFoundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
    In module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:16:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/usr/include/sys/cdefs.h:200:48: note: expanded from macro '__deprecated_msg'
            #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                          ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:161:33: warning: 'FIRInstanceIDResult' is deprecated: FIRInstanceIDResult is deprecated, please use FIRInstallations for app instance identifier handling and use FIRMessaging for FCM registration token handling. [-Wdeprecated-declarations]
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
                                    ^
    In module 'FirebaseInstanceID' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:74:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseInstanceID/Firebase/InstanceID/Public/FIRInstanceID.h:153:1: note: 'FIRInstanceIDResult' has been explicitly marked deprecated here
    __deprecated_msg("FIRInstanceIDResult is deprecated, please use FIRInstallations "
    ^
    In module 'UIKit' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/firebase_messaging/firebase_messaging-prefix.pch:2:
    In module 'Foundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIKit.h:8:
    In module 'CoreFoundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
    In module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:16:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/usr/include/sys/cdefs.h:200:48: note: expanded from macro '__deprecated_msg'
            #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                          ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:161:9: warning: 'instanceIDWithHandler:' is deprecated: Use `Installations.installationID(completion:)` to get the app instance identifier instead. Use `Messaging.token(completion:)` to get FCM registration token instead. [-Wdeprecated-declarations]
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
            ^
    In module 'FirebaseInstanceID' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:74:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseInstanceID/Firebase/InstanceID/Public/FIRInstanceID.h:215:5: note: 'instanceIDWithHandler:' has been explicitly marked deprecated here
        __deprecated_msg("Use `Installations.installationID(completion:)` to get the app instance "
        ^
    In module 'UIKit' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/firebase_messaging/firebase_messaging-prefix.pch:2:
    In module 'Foundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIKit.h:8:
    In module 'CoreFoundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
    In module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:16:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/usr/include/sys/cdefs.h:200:48: note: expanded from macro '__deprecated_msg'
            #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                          ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:171:21: warning: 'FIRInstanceID' is deprecated: FIRInstanceID is deprecated, please use FIRInstallations for installation identifier handling and use FIRMessaging for FCM registration token handling. [-Wdeprecated-declarations]
        [[FIRInstanceID instanceID] deleteIDWithHandler:^void(NSError *_Nullable error) {
                        ^
    In module 'FirebaseInstanceID' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:74:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseInstanceID/Firebase/InstanceID/Public/FIRInstanceID.h:190:1: note: 'FIRInstanceID' has been explicitly marked deprecated here
    __deprecated_msg("FIRInstanceID is deprecated, please use FIRInstallations for installation "
    ^
    In module 'UIKit' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/firebase_messaging/firebase_messaging-prefix.pch:2:
    In module 'Foundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIKit.h:8:
    In module 'CoreFoundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
    In module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:16:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/usr/include/sys/cdefs.h:200:48: note: expanded from macro '__deprecated_msg'
            #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                          ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:171:33: warning: 'deleteIDWithHandler:' is deprecated: Use `Installations.delete(completion:)` instead. Also check `Messaging.deleteData(completion:)`if you want to delete FCM registration token. [-Wdeprecated-declarations]
        [[FIRInstanceID instanceID] deleteIDWithHandler:^void(NSError *_Nullable error) {
                                    ^
    In module 'FirebaseInstanceID' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h:74:
    /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/FirebaseInstanceID/Firebase/InstanceID/Public/FIRInstanceID.h:321:33: note: 'deleteIDWithHandler:' has been explicitly marked deprecated here
                                    __deprecated_msg("Use `Installations.delete(completion:)` instead. "
                                    ^
    In module 'UIKit' imported from /Users/andresnaranjo/Projects/flutter-app/flutter_app/ios/Pods/Target Support Files/firebase_messaging/firebase_messaging-prefix.pch:2:
    In module 'Foundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIKit.h:8:
    In module 'CoreFoundation' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
    In module 'Darwin' imported from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:16:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk/usr/include/sys/cdefs.h:200:48: note: expanded from macro '__deprecated_msg'
            #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                          ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:196:52: error: property 'appData' not found on object of type '__strong id'
      [self didReceiveRemoteNotification:remoteMessage.appData];
                                                       ^
    /Users/andresnaranjo/Development/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.16/ios/Classes/FLTFirebaseMessagingPlugin.m:308:63: error: property 'appData' not found on object of type '__strong id'
      [_channel invokeMethod:@"onMessage" arguments:remoteMessage.appData];
                                                                  ^
    7 warnings and 6 errors generated.

Could not build the precompiled application for the device.

Error launching application on iPhone.

Steps to reproduce
Steps to reproduce the behavior:

flutter pub get
flutter run --flavor stg

Expected behavior

flutter pub get
flutter run --flavor stg
ios build is successful

Additional context
This project was developed with an older version of flutter, and xcode. If I run the app on an Android device, it runs perfectly.
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.4, on macOS 11.0.1 20B50 darwin-x64, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.53.1)
[✓] Connected device (3 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.4
Flutter SDK 1.22.4
gospace_flutter_app 1.2.0

dependencies:
- amazon_cognito_identity_dart 0.0.22 [crypto http]
- autocomplete_textfield 1.7.3 [flutter]
- built_collection 4.3.2 [collection quiver]
- built_value 7.1.0 [built_collection collection fixnum quiver]
- cupertino_icons 0.1.3
- dart_jts 0.0.5+2 [intl hex collection]
- dartz 0.8.9
- data_connection_checker 0.3.4
- equatable 1.2.6 [collection meta]
- firebase_crashlytics 0.1.4+1 [flutter stack_trace]
- firebase_messaging 6.0.16 [meta platform flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_bloc 3.2.0 [flutter bloc provider]
- flutter_nfc_reader 0.1.0 [flutter]
- flutter_redux 0.6.0 [meta redux flutter]
- flutter_slidable 0.5.7 [flutter]
- get_it 4.0.4 [async meta]
- graphql_flutter 3.0.1 [graphql flutter meta path path_provider rxdart connectivity]
- hive 1.4.4+1 [meta crypto]
- hive_flutter 0.3.1 [flutter hive path_provider path]
- http 0.12.2 [http_parser path pedantic]
- intro_slider 2.3.4 [flutter]
- nfc_in_flutter 2.0.5 [flutter]
- overlay_support 1.0.5 [flutter async]
- page_transition 1.1.7+6 [flutter]
- path_provider 1.6.27 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- random_color 1.0.5 [flutter]
- shared_preferences 0.5.12+4 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web shared_preferences_windows]
- sqflite 1.3.1+2 [flutter sqflite_common path]
- toast 0.1.5 [flutter]
- yaml 2.2.1 [charcode collection string_scanner source_span]

dev dependencies:
- build_runner 1.10.0 [args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style glob graphs http_multi_server io js logging meta mime path pedantic pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- built_value_generator 7.1.0 [analyzer build build_config built_collection built_value source_gen quiver]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- hive_generator 0.7.3 [build source_gen hive analyzer dartx]
- mockito 4.1.1 [collection matcher meta test_api]

transitive dependencies:
- _fe_analyzer_shared 7.0.0 [meta]
- analyzer 0.39.17 [_fe_analyzer_shared args charcode cli_util collection convert crypto glob html meta package_config path pub_semver source_span watcher yaml]
- args 1.5.2
- async 2.5.0-nullsafety.1 [collection]
- bloc 3.0.0 [meta rxdart]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- build 1.3.0 [analyzer async convert crypto logging meta path glob]
- build_config 0.4.2 [checked_yaml json_annotation meta path pubspec_parse yaml]
- build_daemon 2.1.4 [built_collection built_value http_multi_server logging pedantic path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 1.3.11 [analyzer build crypto graphs logging path package_config pub_semver]
- build_runner_core 5.2.0 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pedantic pool timing watcher yaml]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- checked_yaml 1.0.4 [json_annotation source_span yaml]
- cli_util 0.2.0 [path]
- clock 1.1.0-nullsafety.1
- code_builder 3.6.0 [built_collection built_value collection matcher meta]
- collection 1.15.0-nullsafety.3
- connectivity 0.4.9+5 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- connectivity_for_web 0.3.1+4 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.1.0+7 [flutter]
- connectivity_platform_interface 1.0.6 [flutter meta plugin_platform_interface]
- convert 2.1.1 [charcode typed_data]
- crypto 2.1.3 [collection convert typed_data]
- csslib 0.16.2 [source_span]
- dart_style 1.3.6 [analyzer args path source_span]
- dartx 0.5.0 [collection path crypto characters time meta]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- fixnum 0.10.11
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- glob 1.2.0 [async collection node_io path pedantic string_scanner]
- gql 0.12.4 [source_span meta collection]
- graphql 3.0.2 [meta http mime path http_parser uuid_enhanced gql rxdart websocket quiver]
- graphs 0.2.0
- hex 0.1.2
- html 0.14.0+4 [csslib source_span]
- http_multi_server 2.2.0 [async]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- intl 0.16.1 [path]
- io 0.3.5 [meta path string_scanner]
- js 0.6.2
- json_annotation 3.1.1
- logging 0.11.4
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- nested 0.0.4 [flutter]
- node_interop 1.1.1 [js]
- node_io 1.1.1 [node_interop path]
- package_config 1.9.3 [path charcode]
- path 1.8.0-nullsafety.1
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+8 [flutter]
- path_provider_platform_interface 1.0.4 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+3 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.8.0+1
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- pool 1.4.0 [async stack_trace]
- process 3.0.13 [file intl meta path platform]
- provider 4.0.5+1 [flutter nested collection]
- pub_semver 1.4.4 [collection]
- pubspec_parse 0.1.8 [checked_yaml json_annotation pub_semver yaml]
- quiver 2.0.5 [matcher meta]
- redux 4.0.0+3
- rxdart 0.23.1
- shared_preferences_linux 0.0.2+4 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 0.0.1+11 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 1.0.4 [meta flutter]
- shared_preferences_web 0.1.2+7 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 0.0.2+3 [shared_preferences_platform_interface flutter file meta path path_provider_platform_interface path_provider_windows]
- shelf 0.7.9 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 0.2.4+1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 0.9.7+1 [analyzer async build dart_style glob meta path pedantic source_span]
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- stream_transform 1.2.0
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- synchronized 2.2.0
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- time 1.4.0
- timing 0.1.1+3 [json_annotation]
- typed_data 1.3.0-nullsafety.3 [collection]
- uuid_enhanced 3.0.2 [crypto convert collection]
- vector_math 2.1.0-nullsafety.3
- watcher 0.9.7+15 [async path pedantic]
- web_socket_channel 1.1.0 [async crypto stream_channel]
- websocket 0.0.5
- win32 1.7.4+1 [ffi]
- xdg_directories 0.1.0 [path process flutter]

Hi @Andranjo97
Could you please run these commands in your iOS directory to make sure this isn't just a cache issue?
rm -rf Pods
rm -rf Podfile.lock
rm -rf ~/.pub-cache/hosted/pub.dartlang.org/
pod cache clean --all
flutter clean
flutter pub get
pod repo update

Thank you


Replace nodes table w node cards

Description
Replace nodes table w node cards
No filter applied:

Dedicated Nodes:

GPU Nodes

Changes

Redesign Node finder
Add guard in NodeDetailsCard to check for node type
Add price, rented, rentable, speed CPU version & memory type chips & uptime
Edit node details,
Update GridNode type in grid proxy
Update nodeInitializer
Remove unreserve from ReserveBtnAction
Remove table chip info as most chips has tooltips now
Reposition CPU tooltip so the linear progress could take the full width
Add tooltips for all chips except for GPU
Edit formatResourceSize so it would return rounded values if speed is true

Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2057
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2427
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2285
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1931
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2055

Documentation PR
For UI changes, please provide the documentation PR on info_grid
Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[ ] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

Please resolve conflicts
Please add reverse/unreserve action like here https://staging.dashboard.dev.grid.tf/#/deploy/node-finder/?dedicated=true

Please resolve conflicts
Please add reverse/unreserve action like here https://staging.dashboard.dev.grid.tf/#/deploy/node-finder/?dedicated=true

All done.


Edit Cart

longclaw version: 0.1.1
Django version: 1.10.7
Python version: 2.7.1

Description
I noticed using the longclaw_demo that you cannot edit the number of product items in cart, or remove/delete product items from cart. Please add these features.

Could this issue be closed?

@DanAtShenTech yes I think you are right.
Part of the request is related to longclaw_demo so I have opened an issue specifically for that here: https://github.com/JamesRamm/longclaw_demo/issues/13
If any further edit capabilities are required it can be addressed in separate issues


Cut release v0.11.3

Cutting a release for a regression I introduced in #1013
PRs in this release:

selections fix follow up (#1019)
Neaten up stdlib code (#1017)

Ooooh we need an uppercase C to have the release build going instead of regular debug, pretty buried at https://github.com/KittyCAD/modeling-app/blob/main/.github/workflows/ci.yml#L16

Ah thanks!

Windows looks good, tested:

auth
open file
edit file
create file, sketch, extrude


Modularize core Bazel dependencies

Dependencies of the Bazel project itself should be added into the Bazel Central Registry:

[x] bazel_skylib
[ ] bazel_skydoc
[ ] com_google_protobuf
[x] platforms
[ ] rules_cc
[ ] rules_java
[ ] rules_proto
[ ] rules_pkg
[ ] rules_python
[ ] rules_nodejs
[ ] rules_sass
[ ] java_tools
[ ] grpc
[ ] upb
[ ] cares
[x] zlib

Blockers:

[ ] bazelbuild/rules_cc#91
[ ] https://github.com/bazelbuild/stardoc/issues/109

Notes:

Currently we are writing MODULE.bazel files for those project and checking them in the BCR, that is fine because Bzlmod don't read MODULE.bazel from the source archive. But ideally they should be upstreamed.

Blocker for this issue: rules_cc don't have official releases, therefore we cannot check in a specific version.
https://github.com/bazelbuild/rules_cc/issues/91

stardoc also hasn't have new releases for a while and Bazel is using a commit that is newer than its latest release.

Can't we just download any commit from github as a zip? Like https://github.com/bazelbuild/rules_cc/archive/6c5c8e9b41e6427033dd011f8ce52a1f2532abdc.zip, and then just make it version "0.0.0-20210924-6c5c8e9b" or something

We can certainly do that as a workaround, but ideally projects rules_cc should have official releases.

another way to go about this is to have source.json support git commits too; so instead of specifying an archive from a URL, you could alternatively specify a git repo and a commit/tag.

We can certainly do that as a workaround, but ideally projects rules_cc should have official releases.
Agreed.

another way to go about this is to have source.json support git commits too; so instead of specifying an archive from a URL, you could alternatively specify a git repo and a commit/tag.

But you still need a fake comparable version for that right?

In generally, I would like people to check in well-tested release versions of their project in to BCR, instead of a random commit.

But you still need a fake comparable version for that right?

Yeah, the only difference is that a URL like GitHub's to download an arbitrary commit as a zip isn't always available (for example, for your company's own git repos).

In generally, I would like people to check in well-tested release versions of their project in to BCR, instead of a random commit.

That's fair -- I think we should make more effort to push projects such as rules_cc to make a release then (potentially doing it ourselves). I just don't want us to be stuck in a limbo where rules_cc is reluctant to make a release, so we're just blocked on them and not making progress.

I just don't want us to be stuck in a limbo where rules_cc is reluctant to make a release, so we're just blocked on them and not making progress.

Oh, of course, making a new release shouldn't be too hard (hopefully) and we have many other dependencies to check in.

Dependencies of the Bazel project itself should be added into the Bazel Central Registry

Wait, is this registry for Bazel's use or the community? If zlib goes here, does that mean other C++ libraries can be contributed by users? You'll have hundreds of "modules" here very quickly.

This is for use by the community. Other C++ libraries can indeed be contributed by users.

You'll have hundreds of "modules" here very quickly.

Scalability has always been a concern of mine, but similar projects (notably Homebrew, and to some extent Debian) have functioned well with this pattern, so I think we should be able to manage.

only difference is that a URL like GitHub's to download an arbitrary commit as a zip isn't always available

there is another difference which is that integrity hashes of github's archive downloads are not stable. They sometimes rollout upgrades to their frontend nodes where the tar or zip command run and those have small variation. The registry should probably strongly advise and/or enforce only release/ URLs are used, where the integrity matches what the rule maintainer uploaded

there is another difference which is that integrity hashes of github's archive downloads are not stable. They sometimes rollout upgrades to their frontend nodes where the tar or zip command run and those have small variation.

That's a good point. To mitigate this, we also mirror all archive URLs to a GCS bucket.
See https://buildkite.com/bazel/bcr-postsubmit/builds/7#eb1a86ce-5b1a-461c-9f87-cf2f1b20a78c

oh this is a place to automate the mirroring of new releases, that's a great improvement. of course if GitHub changes, you'll have one correct mirror and one incorrect one.


Add shell completion

Hello
This PR adds completion subcommand to generate shell (bash/zsh/fish) completion script.
This subcommand is provided by cobra. cobra adds completion subcommand by default from v1.2.0.

Thank you for your contribution.
I merged your pull request.


Require semicolon or newline before method body

The compiler currently does not require a clear delimiter between the head and body of a method.
For example, def foo : Int32 1 end is valid syntax.
There are some oddities: def foo 1 end is not valid, but def foo() 1 end is.
Some typos can cause surprising behaviour. The following code is valid:
def foo : Array (String)
  [1]
end

The return type restriction is Array. (String) is parsed as the first expression in the method body.
A variation of that appears in #6191:
def foo(x : String) : Tuple (String, String) # Syntax error: unterminated parenthesized expression
  {x, x}
end

I think requiring an explicit delimiter could improve the last examples because they would lead to (meaningful) syntax errors.
This comment form @FnControlOption in https://github.com/crystal-lang/crystal/pull/11854#issuecomment-1518168910 makes a concrete suggestion:

def f(x) puts x end is both valid Ruby and Crystal, and requiring a semicolon in this case seems unnecessarily restrictive. I think a semicolon/newline should only be required if the method header (a) has both no parameters and no parentheses; or (b) has anything after the parentheses (i.e. an explicit return type and/or any generic type parameters).

I'm not sure about (a). A def without parenthesis cannot have parameters, so this case should be pretty unambiguous.

Yeah, it's probably better to be strict about parameterless defs, even though it's technically unambiguous in Crystal.

Actually, the formatter already takes care of removing the potential ambiguous syntax.
The first example from the OP formats like this:
def foo : Array
  (String)
  [1]
end

So the alternative is definitely considered ill-formed. But it's actually unambiguous and maybe it's fine to keep accepting it as valid code?
If you want your code to be formatted in a sane way, you should use the formatter anyway =)

I believe this is related!
def foo : Int32
	switch = true
    if switch 0 else 0 end # Syntax error: Error: unexpected token: "else"
end
puts foo

The above doesn't compile but with an inserted ';', it prints 10.
def foo : Int32
	switch = true
    if switch ; 0 else 0 end # works
end
puts foo

@stefandd switch 10 is interpreted as a function call with args, and else appears out of nowhere (syntax error). Adding the semicolon tells crystal to not look for args, and it parses correctly.


Add a worker cron that scales the dynos

This adds a job that runs every 10 seconds and checks the size of the compile queue and the number of workers running in Heroku.
We use hardcoded queue sizes to determine the number of workers we need, with a minimum of 25 workers. These numbers are arbitrary as we don't have any queue metrics to determine our normal operation.
< 25 = 25 workers
25 - 50 = 50 workers
51 - 75 = 75 workers
,> 75 = 100 workers
When scaling down, we scale down with a 10% reduction each in the number of workers as to not to overwhelm anything.
Add HEROKU_API_TOKEN to the app configuration.

Closing as we're not using this for now


[BUGFIX] Avoid integer overflow when calculating sound length

Linked Issues
Fixes https://github.com/FunkinCrew/Funkin/issues/3070 (who the heck would play a 25+ minute long song anyway?)
Description

[!IMPORTANT]
This will also require bumping Funkin's hmm OpenFL commit hash to work

This is basically commit 7a2f328 cherry-picked from upstream, details on what this exactly fixes are better explained by the commit's description. But it would be ideal to upgrade Funkin's OpenFL instead, I think.

Since dev-funkin has more recent commits than develop it already has that fix, so would it rather be better to close this PR?

I'll be closing this as the issue seems to have been fixed on 0.5.0


HatefulMemesScenario get_instances returning error

Calling get_instances for HatefulMemesScenario is getting me the following:
Exception: Failed with exit code 8: wget 'https://huggingface.co/datasets/neuralcatcher/hateful_memes/resolve/main/img/23058.png?download=true' -O output/benchmarks/downloaded/hatefulmemes/img/23058.png.tmp
Specifically, the traceback is:

line 66 in common/general.py, in shell: raise Exception(f"Failed with exit code {exit_code}: {cmd}")
line 94 in common/general.py, in ensure_file_downloaded: shell([downloader_executable, source_url, "-O", tmp_path])

Could you provide the complete error logs, including the exception message itself?
cc @teetone

OK, I can replicate this locally. There is indeed a row for image 23058.png which is missing from this Hugging Face mirror.
@teetone How are you running this in production? Are you using the canonical version of the dataset instead?


Other F-gas species

In my agage-air-archive repository, I would like to be able to convert a few extra scales for some of the HFCs and HCFCs that were measured on the EMPA setup. I've ended up changing the default scales in that repository to avoid having to do that, but in the long run it would be good to get the air archive on the same set of standard scales as the in situ/continuous AGAGE measurements. This would be the easiest way to do it, repository-wise.
The scale conversions in question are:

METAS-2017 <-> Empa-2013 for HCFC-133a and HCFC-132b
SIO-14 <-> Empa-2005 for HFC-227ea and HFC-245fa
SIO-14 <-> Empa-2009 for HFC-236fa
SIO-14 <-> Empa-2003 for HFC-365mfc

Do these scale conversions exist? and how easy is it for them to be implemented into this repository (looks quite straightforward...)

Can you ask Angelina, Joe, Dickon or Kieran about this?


NSPanel setting temperature

How can I control thermostat. ClimateEntity is not active.

sonoff-70c6783a988ca74a2de359fb85a3227a-Bad-b401bebe2b84e33d5763650329a605d0.json (1).txt

It's because of the new update from HA; you need to roll it back and skip it

which version?

Or will there be an update coming out next? Can you change something?

Rollback to core_2024.1.2

Bekomme Error
WARNING (MainThread) [homeassistant.helpers.entity] Entity sonoff.sonoff_100162ee34 (<class 'custom_components.sonoff.climate.XClimateNS'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <ClimateEntityFeature: 0>, please create a bug report at /api/sonoff/ and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

Perhaps this is somehow related
HVAC_MODE_HEAT was used from localtuya, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please create a bug report at https://github.com/rospogrigio/localtuya/issues
HVAC_MODE_OFF was used from localtuya, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please create a bug report at https://github.com/rospogrigio/localtuya/issues
SUPPORT_TARGET_TEMPERATURE was used from spaclient, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please create a bug report at https://github.com/plmilord/Hass.io-custom-component-spaclient/issues
HVAC_MODE_HEAT was used from spaclient, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please create a bug report at https://github.com/plmilord/Hass.io-custom-component-spaclient/issues
HVAC_MODE_OFF was used from spaclient, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please create a bug report at https://github.com/plmilord/Hass.io-custom-component-spaclient/issues

This is the default behaviour. You need to activate it


Namespace all classes and/or modules defined.

Namespace all classes and/or modules defined in your gem to avoid name collision with the application using the gem.
Check out http://www.sitepoint.com/creating-your-first-gem/.

Modules and classes namespaced.


lnd seems to hang at the TLS generation step

Here is what I see in the logs :
2017-12-25 06:51:43.003 [INF] LTND: Version 0.3.0-alpha
2017-12-25 06:51:43.047 [INF] CHDB: Checking for schema update: latest_version=0, db_version=0
2017-12-25 06:51:43.075 [INF] RPCS: Generating TLS certificates...
Nothing happens after that. As far as I can tell there was no error showing up anywhere (including when running lnd with -d trace). It just waits forever.
I found there's a "gencerts" utility in my gocode/bin directory, tried to generate a TLS certificate pair and move it to .lnd/tls.cert and .lnd/tls.key and it works :
2017-12-25 06:54:33.228 [INF] LTND: Version 0.3.0-alpha
2017-12-25 06:54:33.230 [INF] CHDB: Checking for schema update: latest_version=0, db_version=0
2017-12-25 06:54:33.500 [INF] RPCS: password gRPC proxy started at localhost:8080
2017-12-25 06:54:33.501 [INF] RPCS: password RPC server listening on <IP_ADDRESS>:10009
2017-12-25 06:54:33.501 [INF] LTND: Waiting for wallet encryption password. Use lncli create to create wallet, or lncli unlock to unlock already created wallet.
Built following the installations instructions on this architecture :
Linux DiskStation 3.2.40 #5967 Fri Nov 3 17:20:31 CST 2017 armv7l GNU/Linux

If you're running on a constrained platform, then cert generation may take a bit of time.
Can you give a bit more details w.r.t your hardware specs?

The machine is a Diskstation DS213j, the specs are as follow :

But the thing is, when I use the gencerts command line utility, it generates the certificates in 2-3 seconds. And it seems those certs are usable by lnd, if I generate them myself lnd seems to load normally past the point where certs are  initially created.

We've switched to ecc certs by default (in #776) , so the start up time of a fresh installation has been drastically reduced.


Add ability to sort exports and include/exclude metadata from them.

This branch relies on the feature/sorted-and-no-metadata-exports branch in frodo-lib.

Merged into Rockcarver's version


IASP definition being inserted in place of library in downloadMemberContentWithDates()

I defined the IASP name of our system on my connection and it now appears in the create or replace alias SQL command instead of the library.
If I remove the IASP value from the connection setting, shut VS Code, open VS Code, connect to my server, open a member, I still see the IASP reference in the create alias command.
I have yet to verify if this occurred in prior release.

Code for IBM I version 1.5.24
QCCSID: 37
Features:

git: true
grep: true
tn5250: false
setccsid: true
GENCMDXML.PGM: true
QZDFMDB2.PGM: true
iconv: true
attr: true

SQL enabled: true
Source dates enabled: true

Variants
{
  "american": "%23@$",
  "local": "%23@$"
}

Errors:
CREATE OR REPLACE ALIAS ILEDITOR.WIASP_VSCODE_RPGLINT for "WIASP"."VSCODE"("RPGLINT")
{
    "code": 2,
    "signal": null,
    "stdout": "DB2>\n  ?>\n\n **** CLI ERROR *****\n         SQLSTATE: 01522\nNATIVE ERROR CODE: 403\nAlias WIASP_VSCODE_RPGLINT in ILEDITOR created but table or view not found.",
    "stderr": ""
}

/home/PGMT: LC_ALL=EN_US.UTF-8 system "call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')"
SELECT LENGTH(srcdta) as LENGTH FROM ILEDITOR.WIASP_VSCODE_RPGLINT limit 1
{
    "code": 4,
    "signal": null,
    "stdout": "DB2>\n  ?>\n\n **** CLI ERROR *****\n         SQLSTATE: 42704\nNATIVE ERROR CODE: -204\nVSCODE in WIASP type *FILE not found.",
    "stderr": ""
}

This can be treated as a lower PTY for me as I will be out of the office for a week.
Thanks.

Happening here: https://github.com/halcyon-tech/vscode-rpgle/blob/83773b479ad2bba25f5dca80534417106f9b4c1b/server/src/server.ts#L121
We are taking account of the ASP in the URI. Working on it now.

@m-tyler I know you won't be back next week, but 0.15.5 is out which should resolve this issue. Thanks!

I had a little time this early am, I upgraded to 0.15.5 and tested again with positive results.  Thanks!

@m-tyler nice! I love early morning fixes. Have a great week whatever you get up to.

Hi,
I just updated to 0.15.9 and now I see this in the log.  I was looking over the log I only see WIASP being used for the library for the RPGLINT member.  I don't recall if the RPGLINT member was formatted like this in 0.15.5.
CREATE OR REPLACE ALIAS ILEDITOR.WIASP_VSCODE_RPGLINT for "WIASP"."VSCODE"("RPGLINT")
{
    "code": 2,
    "signal": null,
    "stdout": "DB2>\n  ?>\n\n **** CLI ERROR *****\n         SQLSTATE: 01522\nNATIVE ERROR CODE: 403\nAlias WIASP_VSCODE_RPGLINT in ILEDITOR created but table or view not found.",
    "stderr": ""
}

@m-tyler this is possibly a new bug. Would you mind raising this bug?

I created issue #167.


Support Default Tolerations, Affinity, Scheduler and NodeSelector

TL;DR
Consume flyteplugins change to support default tolerations, affinity, scheduler and nodeselector
Type

[ ] Bug Fix
[X] Feature
[ ] Plugin

Are all requirements met?

[X] Code completed
[X] Smoke tested
[X] Unit tests added
[X] Code documentation added
[X] Any pending items have an associated Issue

Tracking Issue
https://github.com/lyft/flyte/issues439

build has failed?

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.


Consider syntactic sugar for vector placment

It might be useful if vector's execution policy constructor used the policy's underlying allocator as the vector's allocator when it makes sense to do so.
For example, this syntax:
vector<int, my_allocator> data(par.on(exec), 100);

Could be made equivalent to this syntax:
auto policy = par.on(exec);
vector<int, my_allocator> data(policy, 100, exec.allocator<int>());

In cases where my_allocator is constructible from policy.executor().allocator<int>(). In other cases, the vector's allocator would just be default constructed as usual.
This sort of syntax would make it convenient to construct a vector with affinity to a particular GPU fairly easily:
vector<int, device_allocator<int>> data(par.on(device(1)), 100);

We might also consider a basic_vector<T, ExecutionPolicy> type for embedding a default execution policy to use instead of seq for vector methods overloads without an ExecutionPolicy parameter.


Build failed using Expo Js (example repo included)

Hey!
I followed the installation procedures and my package built correctly on Android, but failed on iOS, I'm including a example repo which you can see the error.
The problem is related with the package failing to find <React/RCTAnimationType.h> inside RCTConvert.h because the file RCTConvert itself was included as "RCTConvert" instead of <React/RCTConvert>
I searched for a long time trying to fix this, but couldn't make it, I would appreciate if someone could take a look into this!
The example repo which shows the failing build is: https://github.com/luisguilhermemsalmeida/expo-one-signal

Same boat here...  And to get here I had to steal the .framework from another repo.
It looks like the IOS side is a bit flaky. 40 opened issues is usually a pretty telling tell. And It doesn't look like they are addressing them either. (yours sat for a month...)
I'll prob just let expo handle my ios notifications instead.
Please let me know if you get it to work.

Hey @luisguilhermemsalmeida:
So not sure i recommend this, cause it a bit hacky.. usually when you are having to go through all this trouble your best choice it to move to another repo..
Here is how I made it work:
1.- npm instal and link. (link not cocoa, even though its against expo recommendations)
2.- Follow installation steps from the repo
4.- Let it run (its going to fail)
5.- An RCTConvert file is going to complain that its missing Yoga. Locate the folder containing RCTConvert and keep it in an open finder window.
6.- In native_modules, or in react, look the Yoga.h file, it lives in a Yoga folder containing 5 other support files. copy it.
7.- Paste it where RCT convert lives.
8.- Run it, it's still going to fail. missing some files that it wants to import.
9.- Look for the issue, remove React/ from the import line code. run it again. (will fail again)
10.- It's going to be the same issue, in a diferent import, so do the same.
11.- And again... be patient, it will happen 5-6 times. After that, it should build, link.. work.
12.- :)
The Android install is a lot better.
I hope that helps.

@fozzarelo I couldn't make it work, But I'm going to try your solution, thanks! I'm thinking about letting Expo handle iOS push notifications too.

I have the same error here, I use expokit, any other solution ?

@luisguilhermemsalmeida I am closing this issue due to inactivity - please feel free to respond if you are still encountering this issue and I would be happy to reopen and investigate.


TeX Suite v1.0.2 keeps crashing on Nova 9.3

Ever since I upgraded Nova 9.1 to 9.3 and TeX Suite from 0.5.1 to 1.0.2, TeX Suite has been crashing when I enabled it. The only error showing up is:
Extension Service Quit Unexpectedly

An issue with one or more extensions caused the service to terminate. As a result, all extensions will need to reload.

The following extensions were executing when the crash occurred:
• TeX Suite (org.flyx.tex)

Is this related to this issue?

No, the linked issue crashes Nova itself and doesn't occur for me anymore since I implemented a workaround. Your issue is something different. Could you please give the following info:

Whether each of latexmk, context, texlab and digestif is available on your login shell, and if so their versions.

Version of macOS.

Steps to reproduce the error (an important info is whether you need to have any workspace with .tex files open or not).

Check whether the crash occurs with LaTeX, ConTeXt or both disabled in your workspace settings. If the extension crashes immediately after loading a workspace with .tex files, you can disable these options by putting the following into .nova/Configuration.json:
{
"org.flyx.tex.context.enable" : false,
"org.flyx.tex.latex.enable" : false
}

I just updated to Nova 9.3 and I see that the language server isn't working anymore, but I'm not seeing a crash. This might be a Nova issue. did you have 1.0.2 running under Nova 9.1 before you updated?
^(It might be a few days before I can look at this in detail. The Panic folks must be optimistic by not only releasing on a Friday, but also right before easter weekend…)

Had a look at this and found a bug in the JS code. Please update to 1.0.3 and report back if you see this problem still happening. If it does, please give the information requested in my previous comment, since I cannot reproduce this.

Closing due to lack of feedback, assuming this is fixed since I can't reproduce.


Enhancement: Lazy Property Handler

Describe the enhancement
From the docs around property handlers, you have this example:

What would be incredible is for RepoDB in the background to hold the backing string on the POCO on retrieval. Only when the property is first accessed, is the property handler run (i.e deserialized). In this way you defer the cost of the property handler for when it is first used, and thereafter the object is set.

Hmmm, interesting proposal. Definitely, it will improve the perf specially if property handler is doing an extensive operation. We will look how this is possible with the existing implementation we had, most likely not due to PH dependency to the connection.


CentOS zpool is located in /usr/sbin/zpool

[root@mad system]# whereis zpool
zpool: /usr/sbin/zpool /usr/share/man/man8/zpool.8.gz
[root@mad system]# cat /etc/redhat-release
CentOS Linux release 7.5.1804 (Core)
[root@mad system]# rpm -qf /usr/sbin/zpool
zfs-0.7.12-1.el7_5.x86_64

Thanks. I'm on Arch, but it looks like I also have /usr/sbin/zpool. Do you want to send a PR to change the path?

Done