Conditional facts and theories - support SQL2008 in testing

Adds [ConditionalFact] and  [ConditionalTheory] to our testing framework (similar to aspnet/testing, but better :) )
Allows skipping tests based on test configuration.
Fix #2897
Depends on #3011

NB: Some SQL server tests cannot run as they test SEQUENCE functionality. These will always be ignored.

Nice!

Update: #3011 has been merged.

Ping! Review plz.

:shipit:


url_preview: Fix 'Edited' notification for url preview events.

We recently added the rendering_only field to update_message events, so that there would be a clear flag for special update events, such as those for inline url previews.
This change uses the rendering_only field in the update_message event to filter the addition of last_edit_timestamp to the message, which is what triggers the addition of an Edited notification when a message is rerendered in the web app.
Testing plan: Manually tested in the dev environment. The screencasts below aren't fully loading, but it's enough to see the difference.
Current behavior

New behavior
https://user-images.githubusercontent.com/63245456/154529307-e6263ebe-1086-40b1-8d9d-374aa636ec29.mp4

Thanks for working on this @laurynmm!  I think this is a clear improvement, but have a few questions.
The second is whether the frontend's orig_content block is incorrectly also adding an edit_history_entry entry when we do this.

The second is whether the frontend's orig_content block is incorrectly also adding an edit_history_entry entry when we do this.

It doesn't because the events where rendering_only is true, the orig_content field is undefined / non-existent. I doubled-checked this while I was console debugging the issue.
So, rendering_only updates never enter this block (line 392), which is where the edit history entry is added on the front end:
if (event.orig_content !== undefined) {

In fact, we would get the same result by moving these two lines into that block for the above if statement, instead of creating a new if statement checking the rendering_only boolean.

Alternatively, since I've looked more into the logic of the last_edit_timestr delete, I think we could keep the rendering_only block and remove the duplication above in the topic or stream edit if statement:
if (topic_edited || stream_changed) {
...
  msg.last_edit_timestamp = event.edit_timestamp;
  delete msg.last_edit_timestr;

Since we went to the effort of adding that rendering_only boolean, I think it makes sense to use it here and remove the duplication. Plus that field is always present, for all update_message events, while other ones vary on the type of edit / change.

@timabbott - I've looked at this a few times this week and ...

Re orig_content block adding an edit_history_entry: The inline url preview event doesn't enter that block, so no edit history entry is being created.
In fact, instead of checking for rendering_only with the if statement (my current fix), we could instead fix the issue with by moving the msg.last_edit_timestamp assignment to be inside the orig_content block. Let me know if you think that would be better and I'll update the PR accordingly.

diff --git a/static/js/message_events.js b/static/js/message_events.js
index 542106494a..e615508af9 100644
--- a/static/js/message_events.js
+++ b/static/js/message_events.js
@@ -410,12 +410,12 @@ export function update_messages(events) {
                 msg.edit_history = [edit_history_entry].concat(msg.edit_history);
             }
             message_content_edited = true;
+            msg.last_edit_timestamp = event.edit_timestamp;

             // Update raw_content, so that editing a few times in a row is fast.
             msg.raw_content = event.content;
         }

-        msg.last_edit_timestamp = event.edit_timestamp;
         delete msg.last_edit_timestr;

         notifications.received_messages([msg]);

Re delete msg.last_edit_timestr: From manual testing, I don't think we need to do this deletion. This value gets regenerated every time the container is rendered. Let me know if you want me to add that change to the PR or if you want to do more testing before removing those two lines.

diff --git a/static/js/message_events.js b/static/js/message_events.js
index e615508af9..d87700358a 100644
--- a/static/js/message_events.js
+++ b/static/js/message_events.js
@@ -245,7 +245,6 @@ export function update_messages(events) {
                     msg.edit_history = [edit_history_entry].concat(msg.edit_history);
                 }
                 msg.last_edit_timestamp = event.edit_timestamp;
-                delete msg.last_edit_timestr;

                 // Remove the recent topics entry for the old topics;
                 // must be called before we call set_message_topic.
@@ -416,8 +415,6 @@ export function update_messages(events) {
             msg.raw_content = event.content;
         }

-        delete msg.last_edit_timestr;
-
         notifications.received_messages([msg]);
         alert_words.process_message(msg);

In fact, instead of checking for rendering_only with the if statement (my current fix), we could instead fix the issue with by moving the msg.last_edit_timestamp assignment to be inside the orig_content block. Let me know if you think that would be better and I'll update the PR accordingly.

I thought we displayed the last date a message was moved for messages whose topics were moved?  I could be misremembering, but I would have thought this change would introduce a bug in that setting.

Re delete msg.last_edit_timestr: From manual testing, I don't think we need to do this deletion. This value gets regenerated every time the container is rendered. Let me know if you want me to add that change to the PR or if you want to do more testing before removing those two lines.

Yeah, I think this is correct, and we should remove those deletions, since they are abstraction violations and apparently also useless now :).

I thought we displayed the last date a message was moved for messages whose topics were moved? I could be misremembering, but I would have thought this change would introduce a bug in that setting.

Yes, we do. The last_edit_timestamp gets set in a loop earlier in the code for topic (and stream) moves, for all message that were impacted by that move.
And it gets set again for the content edit (if the event was for a simultaneous content and topic edit). So it's just currently set twice for the message with the content and topic edit to the same value. There's an issue with that being then labeled as moved vs edited, but that's more relevant to #21075.
I think it's clearer to use the new rendering_only boolean here from the event, so the most recent version still has it updated for that check. If we ever end up changing how the content edit history is generated and saved, this logic for inline url previous doesn't change or get confused that way.
I've updated the PR for the removal of the unnecessary deletions of msg.last_edit_timestr.

OK, added a bit of a block comment explaining what rendering_only is about for readable and merged this, thanks @laurynmm!


Disabled TextField looks odd at larger widths

Problem description
When the TextField is disabled and small in width the dashed underline looks proper. However while increasing the side of the TextField it begins to look more and more strange
Versions

Material-UI: 1.0.0-alpha.19

Images & references
Small width:

Large width:

Fixed on the HEAD of next. I have been refactoring the disabled style using backgroundImage over borderImage. Also made is work cross the supported browser.


Incorrect naming / link generating during adoption

In docs/developer/how-to/pin-requirements.rst, when adopting skeleton for pytac, python3-pip-skeleton-cli is being replaced with the new project name incorrectly here, meaning that link checks fail as project-cli does not exist.
Changed:
For example take a look at the release page for python3-pip-skeleton-cli here:
https://github.com/DiamondLightSource/python3-pip-skeleton-cli/releases/tag/3.3.0

To:
For example take a look at the release page for pytac-cli here:
https://github.com/DiamondLightSource/pytac-cli/releases/tag/3.3.0

Yep I have seen this issue too. Get spammed by all my skeleton based projects accordingly :-)

This has already been fixed on main with the addition of pin-requirements.rst to IGNORE_FILES in __main__.py, however this fix is not present in the latest release 3.3.0.
I tested locally on the  HLA-610-add-I04-ring-modes branch on  pytac and the problem wasn't reproduces.
@gilesknap time for another release?

@evalott100 yes I think this warrants a new release!

Shall I do this?

Yes please :-)


v1.0.0: error in shared dependencies ending with "/"

Some examples show using dependencies ending with /, but when I try the same here I get error:
error when starting dev server:
Error: Missing "./" specifier in "react" package

when
shared: {
         react:  {  },
         "react/": {  },
...
}

I am not familiar with this feature, it can be added to the roadmap

If there is a document, please send it to me. I seem to have missed the document and did not see the function of this feature.

you can see that in official next-js MF examples
https://github.com/module-federation/core/blob/60be41eccf8cd6481e0aa7b633b095f60dfa2166/packages/nextjs-mf/README.md?plain=1#L84

Is there any update?

@smelukov is it not fixed for you? I thought previous version had a fix. Can you try latest, please

This feature was recently developed

@smelukov is it not fixed for you? I thought previous version had a fix. Can you try latest, please

nope, still does'n work

Still actual problem

I've been too busy recently, so I'll prioritize it this weekend.

vite modulePreload will bring "shared module" forward and execute it before init. I can't disable this behavior.
The difficulties have been solved and I can implement it, but work has taken up all my time recently.

@smelukov Before completion, you can manually specify the shared module
shared: {
"react-dom/client": {},
"moduleA/path1/path2": {}
}

vite modulePreload will bring "shared module" forward and execute it before init. I can't disable this behavior.

@zhangHongEn This looks like Rollup's output.hoistTransitiveImports https://rollupjs.org/configuration-options/#output-hoisttransitiveimports Can you try disabling it?

My external is a dynamic import, but it has been modified to synchronous import. I will provide an example this afternoon
---- Replied Message ----
| From | Hiroshi @.> |
| Date | 08/26/2024 07:58 |
| To | module-federation/vite @.> |
| Cc | zhn @.>,
Mention @.> |
| Subject | Re: [module-federation/vite] v1.0.0: error in shared dependencies ending with "/" (Issue #40) |
vite modulePreload will bring "shared module" forward and execute it before init. I can't disable this behavior.
@zhangHongEn This looks like Rollup's output.hoistTransitiveImportshttps://rollupjs.org/configuration-options/#output-hoisttransitiveimports Can you try disabling it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thank you for your help. Disabling hoistTransitiveImports has not taken effect
---- Replied Message ----
| From | Hiroshi @.> |
| Date | 08/26/2024 07:58 |
| To | module-federation/vite @.> |
| Cc | zhn @.>,
Mention @.> |
| Subject | Re: [module-federation/vite] v1.0.0: error in shared dependencies ending with "/" (Issue #40) |
vite modulePreload will bring "shared module" forward and execute it before init. I can't disable this behavior.
@zhangHongEn This looks like Rollup's output.hoistTransitiveImportshttps://rollupjs.org/configuration-options/#output-hoisttransitiveimports Can you try disabling it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@hi-ogawa I wrote a reproducible example

rollup

vite

@zhangHongEn Thanks for the reproduction. I'm not sure if this is technically a bug of Vite. It looks like this is a issue/limitation of manualChunks in general.
In your reproduction, you can mitigate the issue of __vitePreload creeping into a random chunk by forcing it to be inside a dedicated chunk:
        manualChunks(id) {
          ...
          // force a dedicated chunk for `__vitePreload` helper
          // since Vite/Rollup doesn't guarantee which chunk this module gets merged into.
          // https://github.com/vitejs/vite/blob/dbd6214f6fa5d35647cbd00580c76788ce894e9e/packages/vite/src/node/plugins/importAnalysisBuild.ts#L198-L208
          if (id.includes('/preload-helper.js')) {
            return "preload-helper"
          }
        }

@hi-ogawa This works, I'll do it this way first, thanks for your help

Closed by #67

@zhangHongEn the last update broke our project :(
We have lerna monorepo with this structure:

apps/host/vite.config.ts
apps/host/...
apps/remote1/vite.config.ts
apps/remote1/...
apps/remote2/vite.config.ts
apps/remote2/...

failed to load config from /Users/user/project/apps/host/vite.config.ts
error when starting dev server:
Error: ENOENT: no such file or directory, open '/Users/user/project/apps/host/node_modules/__mf__virtual/empty.js'
    at Object.openSync (node:fs:600:3)
    at Object.writeFileSync (node:fs:2221:35)
    at Object.<anonymous> (/Users/user/project/node_modules/@module-federation/vite/lib/index.cjs:317:4)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

@gioboa can we reopen the issue?

@zhangHongEn the last update broke our project :(
We have lerna monorepo with this structure:

apps/host/vite.config.ts
apps/host/...
apps/remote1/vite.config.ts
apps/remote1/...
apps/remote2/vite.config.ts
apps/remote2/...

failed to load config from /Users/user/project/apps/host/vite.config.ts
error when starting dev server:
Error: ENOENT: no such file or directory, open '/Users/user/project/apps/host/node_modules/__mf__virtual/empty.js'
    at Object.openSync (node:fs:600:3)
    at Object.writeFileSync (node:fs:2221:35)
    at Object.<anonymous> (/Users/user/project/node_modules/@module-federation/vite/lib/index.cjs:317:4)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

Ok maybe it's incompatible with lerna monorepo, I'll fix it

@zhangHongEn thanks!
We use lerna with useNx: true

@smelukov @zhangHongEn @gioboa as we are moving forward it is important to make sure while fixing issues and adding new features we don't introduce regressions, as this is causing a lot of pain to end users. That was one of the reasons I tried to add examples with main features to make sure we can run them to see visually if anything affected. Moving forward will be great to add more examples like that, which could be our first line of defence, but also might be useful to think about integration and unit tests which could help to prevent as well. We might open a new ticket here to discuss ideas and suggestions for this.

Yes, currently we rely entirely on examples to ensure quality, which is very important now.

@smelukov I may know where the path setting is wrong, but I tried to reproduce it with learn and failed. Can you provide more information? Can you provide an example?

@zhangHongEn here is an example https://github.com/smelukov/mf-vite-nx-bug
npm i
npm start

@smelukov Fixed, nx demo is running normally

Thanks @zhangHongEn

@zhangHongEn @gioboa our project is still broken :(
Another errors at this time:
✘ [ERROR] No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Bold.ttf

    ../../node_modules/out-uikit-library/lib/styles/fonts.css:34:11:
      34 │   src: url('fonts/Inter-Bold.ttf');
         ╵            ~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/PTMono-Regular.ttf

    ../../node_modules/out-uikit-library/lib/styles/fonts.css:49:11:
      49 │   src: url('fonts/PTMono-Regular.ttf');
         ╵            ~~~~~~~~~~~~~~~~~~~~~~~~~~

4:33:52 PM [vite] error while updating dependencies:
Error: Build failed with 11 errors:
../../node_modules/out-uikit-library/lib/styles/fonts.css:4:11: ERROR: No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Thin.ttf
../../node_modules/out-uikit-library/lib/styles/fonts.css:9:11: ERROR: No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-ExtraLight.ttf
../../node_modules/out-uikit-library/lib/styles/fonts.css:14:11: ERROR: No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Light.ttf
../../node_modules/out-uikit-library/lib/styles/fonts.css:19:11: ERROR: No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Regular.ttf
../../node_modules/out-uikit-library/lib/styles/fonts.css:24:11: ERROR: No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Medium.ttf
...
    at failureErrorWithLog (/path/to/project/node_modules/esbuild/lib/main.js:1472:15)
    at /path/to/project/node_modules/esbuild/lib/main.js:945:25
    at /path/to/project/node_modules/esbuild/lib/main.js:1353:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

We do not have this error if we use the module federation plugin for webpack. Moreover, we use cssinjs and our project does not import any CSS files.
In this case, we see how something imports a CSS file and this CSS file imports some fonts.
This is unexpected behaviour

@smelukov This error is about a feature that was implemented for this issue. Should I create a new issue anyway?

If I understand the problem correctly, now you have
No loader is configured for ".ttf" files: ../../node_modules/out-uikit-library/lib/styles/fonts/Inter-Bold.ttf so should be a different one.


mirror maker for multicluster replication

Hi All,
Is there any options to use mirror maker for multi cluster replication between different dc/region.

@lyoung-confluent Can you please give insight on this mirror maker?


Version 4.0.0

The main enhancement in this version is finally moving the strongly typed multiple resultset support from the wip branch to the release version.
Other more minor enhancements include:

Add CurrentPage and PageSize to PagedResults c.f. #10
Correct behaviour on only passing ProviderName in the connection string (namely, the provider is set correctly, but Mighty does not incorrectly think that it has a usable connection string)
Add SqlServerAutoEnlistCommandsToTransactions flag with default true, and supporting code, so that if you pass a connection with an open transaction to a Mighty operation, Mighty can just use it #28

The reason this release is a breaking change (semver v3 -> v4) is that I am in the process of writing some code to do an automated audit of all the variant and similarly named methods (e.g. sync vs ...Async, no params vs. ...WithParams, etc., etc.) and I have inevitably found a few minor inconsistencies and missing methods. In order to avoid hard-coding the inconsistencies into tests and baking them into Mighty forever, it seemed preferable to make the changes necessary and release a new major version. This is unlikely to affect you unless you are already using cancellation tokens with async methods, or unless you were using the (incomplete in the previous version) Mighty support for passing in DbConnection, in which case  you may have to move some parameters around in your method calls.
The version is stable, I am using it in my own production code; the only reason I've put is as alpha and not beta is that I may still have to make a few more - hopefully small - method signature changes once I've done the last couple of pieces of the automated audit code. I'm hoping to have that done very shortly (i.e. days not weeks).
Finally, up to now I've only successfully been making subsequent versions of Mighty compile compatible, but not necessarily binary compatible. That won't be an issue unless a NuGet package which you're using, is itself using Mighty. Then, it definitely can be an issue, so it's obviously something I can and should (and will!) double-check for, ongoing. (The issue arises around adding, e.g., new optional parameters. Recompiled code will work just fine, but a package compiled against an earlier version won't find the new method and will break.)
To Do

[x] Add last automated method signature tests
[ ] Finish creating a test harness to test binary compatibility ongoing

[ ] Includes removing all Console output from old Massive tests

[x] Use Devart license (see below)
[x] Fix new IAsyncEnumerable problem in .NET Core 2.0 tests (only)
[ ] Add providerName parameter

Update built-in providers to use it: if it is present, don't even try to parse the connection string

Devart have very kindly provided a free-license to the project. ❤
This is for the purpose of testing against the Devart driver on .NET Core, since there is no free version of Devart.Data.MySql for .NET Core.
I have added code to the test suite to look for a license key in a named file and use it in the .NET Core Devart tests. Because it's not open source the license key file is not in source control, but there is an easy way to disable the .NET Core Devart tests if you don't have a Devart license but do want to run all the rest of the test suite, this is commented here.


hostname instead of IP Adress?

Maybe i´m only doing something wrong, sorry, didn´t find a forum for ki4a:
I can´t enter my hostname like myserver.com, only IP Adress works, but unfortunately this changes each day
Trying this hostname with putty works straightforward, so it must be something in ki4a?
Button goes from yellow back to red imediately, log also shows nothing relevant

Worked for me in first attempt.


NSEC3 bugs: NextDomain requires padding and HashLength is set incorrectly

Looks like padding is required to parse an NSEC3 record and padding is generated when unpacking.  From RFC 5155:
   Base32:  the "Base 32 Encoding with Extended Hex Alphabet" as
      specified in [RFC4648].  Note that trailing padding characters
      ("=") are not used in the NSEC3 specification.

Additionally when parsing NSEC3's HashLength is set incorrectly which results in them packing okay but failing to unpack.
Test case:
package main

import (
	"log"

	"github.com/miekg/dns"
)

func main() {
	rr, err := dns.NewRR(". 0 IN NSEC3 0 0 0 0 C0 TYPE0")
	if err != nil {
		log.Fatalf("new rr failed: %s (unexpected)", err)
	}
	m := new(dns.Msg)
	m.Answer = []dns.RR{rr}
	_, err = m.Pack()

	log.Printf("bug 1: parsing NextDomain requires padding")
	if err == nil {
		log.Fatal("expected pack to fail")
	} else {
		log.Printf("pack failed: %s (expected)", err)
	}
	rr, err = dns.NewRR(". 0 IN NSEC3 0 0 0 0 CO====== TYPE0")
	if err != nil {
		panic(err)
	}
	m.Answer = []dns.RR{rr}
	buf, err := m.Pack()
	if err != nil {
		log.Fatalf("pack failed: %s (unexpected)", err)
	}

	log.Printf("bug 2: HashLength isn't set correctly (set to: %d)",
		rr.(*dns.NSEC3).HashLength)
	err = m.Unpack(buf)
	if err == nil {
		log.Fatalf("expected unpack to fail")
	} else {
		log.Printf("unpack failed: %s (expected)", err)
	}

	rr.(*dns.NSEC3).HashLength = 1
	m.Answer = []dns.RR{rr}
	buf, err = m.Pack()
	if err != nil {
		log.Fatalf("pack failed: %s (unexpected)", err)
	}
	err = m.Unpack(buf)
	if err != nil {
		log.Fatalf("unpack failed: %s (unexpected)", err)
	}
	nd := m.Answer[0].(*dns.NSEC3).NextDomain
	switch nd {
	case "CO======":
		log.Printf("bug3: next domain is padded on unpack")
	case "CO":
		log.Fatalf("next domain is unpadded (unexpectedly)")
	default:
		log.Fatalf("didn't expect next domain to be: %s", nd)
	}
}

go run nsec3_bug.go
2016/12/08 04:53:39 bug 1: parsing NextDomain requires padding
2016/12/08 04:53:39 pack failed: illegal base32 data at input byte 0 (expected)
2016/12/08 04:53:39 bug 2: HashLength isn't set correctly (set to: 20)
2016/12/08 04:53:39 unpack failed: dns: overflow unpacking base32 (expected)
2016/12/08 04:53:39 bug3: next domain is padded on unpack

brrr.. :-(
I never actually seen an NSEC3 like that in the wild. When do you pad with base32?

Base32 uses a 40-bit window so it shouldn't come up in the wild

Do you have a PR in mind?

Nah I'd forgotten about this. In trying to jog my memory, I just tried copying and pasting an example from RFC 5155:
. NSEC3 1 1 12 aabbccdd 2vptu5timamqttgl4luu9kg21e0aor3s A RRSIG
It failed first with illegal base32 data at input byte 1 as the base32-hex was lower case and then wouldn't unpack with dns: overflow unpacking nsecx. I haven't dug any further.

Looks like dns: overflow unpacking nsecx is caused by the salt not being packed.

I've started on this with andrewtj@4246b6e

Go 1.9 adds support for Base32 without padding. Should we switch to that when 1.10 drops?
Also what do you think of dropping the byte-length fields?

Ack, makes sense.
Dropping the byte-length is also OK - I think I only added them to make the pack/unpack function slightly easier - they are mostly a nuisance to end-users I think.

I finally had a go at dropping the length fields in a138983. Tests pass but I don't think it's baked yet.

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/dns] NSEC3 bugs: NextDom..." ]

I'm not going to finish this. If the approach in a138983 seems sane and someone wants to pick it up, go for it.

I might pick this up (some day :) )


remove unused per-request config

per-request config is no longer in use, as we have switched to use per-dataset config

Thanks for the cleaning this up Jia !! LGTM.


putget_test:TestPutGet intermittent failures

I get intermittent failures running putget_test.TestPutGet. Here are two gists with the stdout and stderr from failing runs:
https://gist.github.com/mambocab/b724a2c697416f21a621
https://gist.github.com/mambocab/adb5cb90c14cda5f87c8
and here are the same for a successful run:
https://gist.github.com/mambocab/de2a089e93bc4dff61cc
There's some noise about reading JMX metrics in the Java stack traces that can be ignored for this issue. This is in the traces for both failing runs, and not in the trace for the successful one:
java.lang.AssertionError: org.apache.cassandra.exceptions.AlreadyExistsException: Cannot add already existing table "resource_role_permissons_index" to keyspace "system_auth"
    at org.apache.cassandra.service.StorageService.doAuthSetup(StorageService.java:897)
    at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:832)
    at org.apache.cassandra.service.StorageService.initServer(StorageService.java:579)
    at org.apache.cassandra.service.StorageService.initServer(StorageService.java:469)
    at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:357)
    at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:492)
    at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:599)
Caused by: org.apache.cassandra.exceptions.AlreadyExistsException: Cannot add already existing table "resource_role_permissons_index" to keyspace "system_auth"
    at org.apache.cassandra.service.MigrationManager.announceNewColumnFamily(MigrationManager.java:286)
    at org.apache.cassandra.service.MigrationManager.announceNewColumnFamily(MigrationManager.java:275)
    at org.apache.cassandra.service.StorageService.doAuthSetup(StorageService.java:891)
    ... 6 more

The test command is
STAMP=$(date +%y-%m-%d-%H.%M.%S) CASSANDRA_DIR=~/cstar_src/cassandra PRINT_DEBUG=true nosetests -x -s -v putget_test:TestPutGet >~/putget_test_$STAMP.stdout 2>~/putget_test_$STAMP.stderr

I'm running in Ubuntu under VirtualBox with 2GB of memory, which may be the problem.
$ uname -a
Linux dtest-VirtualBox 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

This is probably enough information to turn into a Jira ticket. What C* version is this? If it's trunk, assign it to Sam Tunnicliffe.

It's trunk. Reproduced it with 4GB of memory:
https://gist.github.com/mambocab/b724a2c697416f21a621
I think it might be a dtest-related error, because

this run and this run failed on different tests.
the failure report is consistent with a bad teardown that left behind a table that another test tried to add.

Should I do more dtest digging, or does this still look like one for Jira?

I think it's for Jira. We aren't adding that table, that's internal stuff going on to set up a new node. I don't see anything wrong with the test logic after a quick look

This is being worked on here:
https://issues.apache.org/jira/browse/CASSANDRA-8853

8853 was closed and I haven't seen a recent failure on this test. Closing.


Suppressed children showing in collection tree

When viewing a work that has children that are suppressed, they are still rendered in the collection tree:
Parent: https://wellcomecollection.org/works/pzfpc7hx
Suppressed child: https://wellcomecollection.org/works/xxaqfkcs

Clicking the link of the item that should be suppressed takes you through to an error page, not to the suppressed item.

Adding a filter for type = "Visible" here should fix this issue: https://github.com/wellcomecollection/catalogue/blob/master/api/api/src/main/scala/uk/ac/wellcome/platform/api/services/RelatedWorkRequestBuilder.scala#L89-L94

@warrd what needs to happen for this to take effect, now that the issue is closed? I can currently still see the child record link in the parent record.

I didn't close the issue, apparently it did automatically when I merged the PR (not sure that should be the case).


Add basic Card component

I developed basic card component but I have not tested it. @Joozty what is the best place to integrate it?

I guess you can test it here with some mocked data.

The Overview page is not going to be a part of the MVP so I would not like to spend any time on it. I will find something and let you know. Thank you!

@viktor-yakubiv Ok then. Please rebase and I think it can be merged.

Card tested here https://dashboard-git-deposit-dates.oacore.now.sh/deposit-dates


Staking. Start staking - empty validator list

Description
Empty validator list for Polkadot\Kusama on start stking operation.

Steps to Reproduce

Go to Staking page
Select Polkadot
Go to Start staking operation

Expected Behavior
User can start staking
Actual Behavior
Empty validator list
Environment
1.12.1

Status verification: ✅


Incorrect error message for local plugin dependency

Expected Behavior
The error message provides exact steps to fix the issue.
Current Behavior (optional)
After defining a custom local plugin I see this error message pointing to incorrect/incomplete dependency sources as a failure reasoin:

Context
Developing local gradle plugins.
Create a local plugin in buildScr that depends on another existing Gradle plugin.
Message suggest that a new source should be added, however, to fix this issue dev needs to add plugin dependency to buildSrc\build.gradle.kts file:

dependencies {
   implementation(plugin(libs.plugins.junit5Android))
}

fun DependencyHandlerScope.plugin(plugin: Provider<PluginDependency>) =
    plugin.map { "${it.pluginId}:${it.pluginId}.gradle.plugin:${it.version}" }

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team and is prioritized by them.


Create issue backend

added modules folder.
added routes folder.
connected established with database.
post send successfully.

It looks works properly.


publish new version on npm

It looks like there are some changes (for example, making the callback optional), which haven't been published to npm. Would it be possible to publish a new version?

I am also interested in these new features, any updates on this issue?

Sorry for the delay. v1.0.0 published to npm!


c# example is missing string[] customers for example #2

c# example is missing string[] customers for example #2
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/var#feedback

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 651ba093-2cef-e0f6-be71-ffdf6551c2c4
Version Independent ID: a4878d20-2a12-74ad-9fc0-9f589a44af35
Content: var - C# reference
Content Source: docs/csharp/language-reference/keywords/var.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for noting this @TXAE
I don't know that an additional example using an array is needed for greater understanding of var.
I'll close, but if you feel strongly about adding an additional example, you can create a PR with that addition.


Port: LG error related changes

closes: https://github.com/microsoft/botbuilder-js/issues/1672
closes: https://github.com/microsoft/botbuilder-js/issues/1569
closes: https://github.com/microsoft/botbuilder-js/issues/1750

Pull Request Test Coverage Report for Build 108243

268 of 320 (83.75%)  changed or added relevant lines in 15 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 73.027%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-lg/src/errorListener.ts
1
2
50.0%

libraries/botbuilder-lg/src/lgParser.ts
19
20
95.0%

libraries/botbuilder-lg/src/analyzer.ts
2
4
50.0%

libraries/botbuilder-lg/src/staticChecker.ts
52
55
94.55%

libraries/botbuilder-lg/src/lgExtensions.ts
21
25
84.0%

libraries/botbuilder-lg/src/lgFile.ts
19
24
79.17%

libraries/botbuilder-lg/src/evaluator.ts
69
76
90.79%

libraries/botbuilder-lg/src/expander.ts
31
60
51.67%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/expander.ts
3
72.05%

Totals

Change from base Build 108222:
0.1%

Covered Lines:
8845

Relevant Lines:
11559

💛  - Coveralls


Outscale storage providers

Add Outscale storage providers (Ceph RGW S3)

Hi @jmunhoz do they all need to be separate drivers? We are trying to make sure that there are single drivers with a region=x constructor.

@tonybaloney thanks for reviewing. As suggested I pushed a single driver with region support in the constructor.

Hi @Kami, the new patch declares the arguments explicitly.

Thanks @jmunhoz. the changes look great, merging


html-preview-link - Restore feature

Closes: #7860
Test URLs
https://github.com/refined-github/refined-github/blob/main/source/welcome.html
Screenshot

You can merge 👌


[Feature] Make CodeBlocks expandable

Is your feature request related to a problem? Please describe.
Currently the code blocks in the mdx files have a scrollbar. They should be expanded all the way to mitigate unnecessary scrolling.

Describe the solution you'd like
Have all code blocks full expanded

great idea, moving this to our internal linear to track this request


Prepare for launch + marketing actions

We need to prepare to launch the site by doing some things:

[x] Twitter profile
[x] Post ready to post on the social networks (Reddit, Twitter, Linkedin, Slack CNCF, HackerNews, etc)

It is live!


Cannot select tags with commas (","s)

Describe the bug
If I add a page with a comma in it to "Tag Pages", it doesn't behave as expected, because commas are used as separators for the list of tags.
To Reproduce
Steps to reproduce the behavior:

Add "foo, bar" as a page to "Tag Pages"

Expected behavior
Expect to see "foo, bar" as a page to select in the dropdown
Actual behavior
I see the following 2 entries:
"foo
bar"

Oh, and by the way, I ❤ this Roam plugin!  Thank you!  🙏 ⭐

Thanks for reporting 🙌... Will have a fix out for this in my next release 🙌
Really happy to hear that you're getting some value from it too 🥰

This is now live (just refresh to fetch latest version). To use tags that have commas in them just wrap them in quotes. For example, "Page, with Comma". Let me know if you have any issues.
Enjoy :)


Avoid duplicate open connections

Motication
When doPX (peer exchange option) is enabled, there are duplicate connections if other peers send same peer id at the same time
Description
To reproduce the issue, run the "test gossipsub star topology with signed peer records" test with GossipsubPrunePeers as 16, check connections after we do 15 heart beat
@@@ peer 5 remote peer QmeVFBEQoZxwLuDqCiDAUqbz5BVN3Az6MLJPxDR3uKwpfV num connection 2 open,open
Expected
Should not have duplicate connections to the same peer

A connection is a stream, i.e. the outgoing and incoming streams or each peer should have exactly one connection that's multiplexed both ways?

A connection contains a lot of streams, each stream could be for a specific protocol (when we use dialProtocol), the direction (inbound/outbound) applies for connection, not stream.
Just debug again, the connections are actually not duplicate, one for inbound and one for outbound. When we do dialProtocol(), libp2p uses the 1st open connection
This works as designed as libp2p accepts multiple open connections https://github.com/libp2p/js-libp2p/blob/3cfe4bbfac46dac3c7875f891909b17f39fa7c85/src/connection-manager/index.js#L308


Add ability to not have shipping address for paypal popup thing

Hey, I added the no_shipping thing from the paypal 'experience' docs.  By using shipping=1 you dont have the address stuff pop up

@grahamannett Thanks very much for your contribution!


Add Universidad Panamericana file

Include Universidad Panamericana into JetBrains list.

@JoaquinMirandaC First stage of verification passed, official domain is up.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@JoaquinMirandaC Thank you for your patience while waiting for a review and processing your request. Pull request merged.


[playground-preview-worker] Reject /.update-preview-token requests from regular browsing contexts

Fixes VULN-49261
What this PR solves / how to test:
This PR fixes a vulnerability that allowed Workers Playground preview instances to be accessed from outside of playground contexts.
Author has addressed the following:

Tests

[x] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[ ] Included
[x] Not necessary because: No changelog for playground-preview-worker

Associated docs

[ ] Issue(s)/PR(s):
[x] Not necessary because: no relevant docs

@RamIdeas I did, but adding CSRF token generation/validation across two different services would be a lot more complex than this mitigation.


Support for AutoValue in annotation processors

@artem-zinnatullin can you elaborate more on this one? I know what AutoValue is and I am genuinely interesting in annotation processing because I have never done it before. So it could be pretty interesting for me to implement.

@geralt-encore great!
So, basically StorIO has simple annotation processors (for StorIOSQLite and StorIOContentResolver) that user can use to genereate boilerplate code for Put, Get and Delete resolvers.
But at the moment our annotation processors don't support classes with Builders or static factory methods -> they don't support AutoValue.
I'd suggest you just play with sources of our annotation processors and take a look on how we inspect and generate the code.
You can watch couple of talks about annotation processing:

https://www.youtube.com/watch?v=dOcs-NKK-RA
https://www.youtube.com/watch?v=dBUAqPs0TB0

And read some articles (I can't remember them).
To generate the code we use JavaPoet.

We can start with support for static factory methods, then think about Builders support!

Ok, thanks for an introduction. I will start digging into it soon. If I would have any questions - I'll post them here.

Sure! Annotation processing is actually interesting part of JDK!

@artem-zinnatullin I have a question regarding support of static factory methods. Should we annotate abstract methods representing fields of an object or just factory method and parse its parameters? Or maybe we should annotate both to be sure about how we are creating object because empty package-local constructor doesn't work in this situation? I wanna your approval before starting actual coding.

We should annotate both, take a look on Jackson @JsonProperty and @JsonCreator usage semantic (not implementation)

I have one more question regarding this issue. Should we use the same StorIOSQLiteColumn annotation for AutoValue abstract methods for fields or introduce a new one? I am not sure, because, one the one hand, their share a lot, but on the other - they need completely different validation.

I guess, we should use the same annotation, yeah, it'll require completely different validation…

How about this progress? I am caring about this issues, maybe I can give a hand to help.

Any news on this? Would make storio my dream db ;-)

I'm currently not using AutoValue… @nikitin-da, @geralt-encore?

Right now I don't use processing.
I would like to work on this after precompiled statement support.

I really would like to help with this. I've started it couple of times, but it was too big and I had something more important to do, so  I never wasn't able to finish it.

I am going to start working seriously on this issue next week. Hope will have something to show by the end of the week.

Yay 🎉

My initial plan:

Allow to annotate methods with StorIOSQLiteColumn  and perform all the necessary validations
Introduce new annotation for factory methods or constructors for marking methods/constructors for creating an object
The hardest part is to map column fields with factory methods/constructors fields. Do you think that it will be good enough to do it based on the order of fields? I don't see better solution without providing additional metadata to columns, which is redundant in my opinion

How does it sound?

2nd item is especially interesting (I didn't though about additional annotation for constructor, but I like its explicitness). Regarding third item — if you can get parameter names of the constructor, that would be good, but if you can't — then sure use order of the parameters.
SGTM!

This one can be closed now.


Not working with file system  uri

As electron serve files via file:// protocol after building the app while Microsoft AAD auth does not allow file system uri so I'm getting error

AADSTS500111: The reply uri specified in the request has an invalid scheme.

because of invalid redirectUri (for me It's default window.location.href)
Need quick fix
Thanks in advance

you'll need to register that url in the azure portal. Looking for a better solution mysef!

@shivshankar3578 yes in azure AAD you have to register the correct return url as
@mbrevda


expose port by default

Without a .yml file ports were not exposed by default.
[0] Have you updated any appropriate docs
[1] Are comments up to date
[1] Did you run go fmt

This has been resolved.


Enable support for UPDATE/DELETE

It was already mentioned on issue #2 and is referenced in the TODO file, but it was last updated more than one year ago.
I guess it would not hurt to keep an issue open for this TODO item and raise awareness for it :)

IMHO I think this would be a difficult feature to implement in a columnar store. The key benefits are around absolute query performance. Better CTE support I think should be the priority.

I agree it might be difficult to implement in a columnar store. However, and while the general append-only use case is good enough, there might be a wider audience out there that would be using cstore if support for occasional UPDATE/DELETE would be implemented. MVHO of course :)

Exactly, for the occasional UPDATE/DELETE, it's not worth the huge effort.

The problem is that those that need this, occasionally, but sometimes, may not use cstore_fdw at all since it would not be supported. So implementing it may widen the user base.
But of course, balance between this and effort is on Citus (and/or community, of course). At least I wanted to raise awareness :) Thanks!

Both delete and update are in our radar for some time. However, due to columnar nature and our file layout, it is quite costly to that.
@sriharsha9992  did some work related to deleting rows from a cstore_fdw table. I am not quite sure of the outcome.
One way to simulate delete is mark a row as deleted, and not return that row during queries. Deleted rows would not be reported in query results, but it would still take disk space. A vacuum like operation on the table may re-organize the data and get rid of unused space as postgresql does.
v1.5 is going to be released in a week or so.  Would you be interested in discussing next feature set ?
I am going to start a thread in our mailing list at https://groups.google.com/forum/#!forum/cstore-users after release.
Appreciate if you could share your thoughts.

I love cstore_fdw being able to get such a considered and helpful response from @mtuncer within hours of an issue being posted is amazing.

Hi ,
I did succeed in implementing DELETE and UPDATE using a executor hook !!

DELETE

Introduced a new variable DeleteArray ( bool * ) in StripeMetadataList . It stores the information on whether the row is deleted or not for the whole stripe .
Implemented a executor hook . Check whether it is a delete operation . Fork the ForeignScan part and will fill up deleteArray after performing the condition check (ExecQual)
If there is no Qual , just truncate the table by calling the truncateCstoreTables method

UPDATE

Implemented as DELETE and INSERT .
Implemented a executor hook . Check whether it is a update operation . Fork the ForeignScan part and will fill up deleteArray after performing the condition check (ExecQual)
ExecForeignUpdate would have the same code as ExecForeignInsert

As @mtuncer pointed out , I perform a vaccum like operation to free up the disk space . Currently , I just perform INSERT INTO TABLE_NEW SELECT * FROM TABLE , which is kind of a round-about solution . Planning to fork VACCUM TABLE command and clean up the table in future .

That's really cool @sriharsha9992 Is that code submitted as a PR?
@mtuncer I'm subscribed now to the cstore-users group and I'll be happy to provide feedback on future directions when asked for :)

Hi @sriharsha9992, those are great news.
Do you plan yo submit a pull request?
Do you need help with it?

any update for this enhancement?

@dawuwu -- We haven't prioritized native UPDATE / DELETE support so far because it's a relatively complex change. That said, we're actively gathering feedback and prioritizing features in every release cycle.
Could you elaborate a bit more about your use case and your motivation for needing UPDATE / DELETE?

I am cleaning up my code right now !! I will send you guys the patch for DELETE and UPDATE . You can review it and push it into the code if it meets your standard.

@sriharsha9992 - did you find time to do this?

+1  for this feature

In my case, I have a constant influx of new data and a need for periodically bulk shedding old data.
So I would love to see support for some kind of bulk delete that does not require a complete re-import of all data or duplicating it into a new table that nearly doubles the storage requirement for the server.
I never need update, and I see that as a perfectly valid restriction.

@Dead2  I can suggest using partitioned tables.
You can have a regular partitioned table, range partitioned on some time column. You can have cstore_fdw tables as partitions of that table.
When you need to retire old data, you can simply drop the related cstore_fdw partition.
There were some restrictions on using partitioned tables with foreign tables in PG10. PG11 has better support on those.

@mtuncer True, that would work for one of my tables. The others have rows that need to stay until they are no longer referenced from the first table. I guess I should have specified that in my previous comment, I'd need to do deletion on random rows, and that is probably harder to support from a cstore_fdw point of view.

@sriharsha9992 Thanks for a great feature. Do you have a PR on this ? I think community can help if more cleanup is required.


Force "Recalculate" on first open

When opening the generated VDX file, the connectors are added to the document but do not "appear" to be connected.
Visio Version: 2010 Professional
OS: Windows 10 / Server 2016
Workaround: Going into Layout -> Connectors and selecting an option fixes the rendering.

If there is VBA code to fire off the menu option then that is an acceptable solution as I am already applying ThemeColors and ThemeEffects on load via VBA in the template.


My Updates during class

My work

This was meant to be created off of my fork closing so it doesn't affect curriculum


Boolean in Infix Expressions

Syntax: <expression> in <list>
Returns true if the result of the expression is in the list, and false if the result of the expression is not in the list.

Commit: https://github.com/johneastman/boomerang/commit/e7707b0888b91c25aa76923859acc871df04775c


[draft] resource and datafile ownership interface

What changed?
introduce a generic interface PathObject_v1 all datafile types automatically implement (in additional to potential other interfaces they declare). the assignment of the interface to datafile types happens automatically during bundle loading in qontract-server. object resolution during query time is achieved by the interfaceResolve.strategy = schema strategy based on the datafile schema defined for a type.
this type enables mixed-type fields in graphql types.
References
design doc https://issues.redhat.com/browse/APPSRE-6019
qontract-server change - https://github.com/app-sre/qontract-server/pull/152
part of https://issues.redhat.com/browse/APPSRE-6020
Example
graphql schema
- name: Role_v1
  datafile: /access/role-1.yml
  fields:
  - { name: owned_resources, type: OwnedResource_v1, isList: true }

- name: OwnedResource_v1
  fields:
  - { name: resource, type: PathObject_v1, isInterface: true }

jsonschema
---
"$schema": /metaschema-1.json
version: "1.0"
type: object

additionalProperties: false
properties:
  "$schema":
    type: string
    enum:
    - /access/role-1.yml
  ...
  owned_resources:
    type: array
    items:
      type: object
      properties:
        resource:
          "$ref": "/common-1.json#/definitions/crossref"
          "$schemaRef":
            type: object
            properties:
              '$schema':
                type: string
                enum:
                - /app-sre/app-1.yml
                - /app-sre/saas-file-2.yml

datafile example
---
$schema: /access/role-1.yml
...
owned_resources:
- resource:
    $ref: /ref/to/a/saas-file.yml
- resource:
    $ref: /ref/to/an/app-file.yml

Query
{
  roles_v1 {
    name
    owned_resources {
      resource {
        path
        ... on SaasFile_v2 {
          name
        }
        ... on App_v1 {
          onboardingStatus
        }
      }
    }
  }
}

Signed-off-by: Gerd Oberlechner<EMAIL_ADDRESS>

closed in favour of #213


[BUG] Chart is not displayed when lineArc is set to true

Expected Behavior
Chart should be drawn even with lineArc set to true.
Current Behavior
After ChartJS 2.4.0, when setting lineArc to true the chart is not diplayed.
Steps to Reproduce (for bugs)
2.5.0 https://jsfiddle.net/hvenb74o/5/ -- BUG
2.4.0 https://jsfiddle.net/hvenb74o/6/ -- Working
Context
I'm working on an app that does need a Chart with a rounded arc instead of the default one. Using 2.4.0 is not ideal for me as there are bugs that are present on 2.4.0 and I do need to create plenty of hacks in order to have it working.
Environment

Chart.js version: 2.5.0
Browser name and version: Chrome 56

@Artfloriani the lineArc setting was a poorly named setting that controlled how points were interpreted and was required to be false for a radar chart.
However, we merged https://github.com/chartjs/Chart.js/pull/3782 recently which fixes this. It's not released yet but you can build master and see how it goes.

@etimberg Thanks for the updated. Just checked and it is working fine from the master branch.
Would it be possible to draw the radar chart without the internal gridLines but with the border of the circular chart?

Yes, but it's cumbersome. I think you would need to specify the grid line colours as an array and then have all but the last value be 'transparent'

@etimberg Worked like a charm, cheers 👍


Bump to version 1.0.0-rc1!

r? @Manishearth
After merging I'll publish this to crates.io

Please avoid making pre-release versions. Cargo is very bad at handling them. See https://github.com/rust-lang/cargo/issues/2222.
Lets just keep releasing 0.x+1 versions until we are ready to cut a 1.0.

Or more specifically: https://github.com/rust-lang/cargo/issues/7676

Yeah let's not do a prerelease version.

Alright!


Clarify pysm requirement

Has the mbs software stack switched to pysm 3? I get this error:
Traceback (most recent call last):
  File "bbcheck.py", line 6, in <module>
    import mapsims
  File "/global/homes/m/msyriac/repos/mapsims/mapsims/__init__.py", line 8, in <module>
    from .noise import SONoiseSimulator
  File "/global/homes/m/msyriac/repos/mapsims/mapsims/noise.py", line 6, in <module>
    import pysm.units as u
ModuleNotFoundError: No module named 'pysm.units'

If it has, the docs don't seem to have been updated to point to the location of pysm 3.

Yes,
I will update it after I deliver what is required for the TOD simulations.
For now either use a earlier release or install pysm3 from GitHub/healpy/pysm

https://mapsims.readthedocs.io/en/latest/installation.html

I still seem to be getting this issue:
In [1]: import pysm3

In [2]: pysm3.__version__
Out[2]: '3.3.2'

In [3]: import mapsims
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Input In [3], in <cell line: 1>()
----> 1 import mapsims

File ~/repos/simonsobs/mapsims/mapsims/__init__.py:8, in <module>
      6 from ._astropy_init import *
      7 from .so_utils import Channel, SOChannel
----> 8 from .noise import SONoiseSimulator
      9 from .cmb import SOPrecomputedCMB, SOStandalonePrecomputedCMB
     10 from .runner import MapSim, from_config

File ~/repos/simonsobs/mapsims/mapsims/noise.py:7, in <module>
      4 from astropy.utils import data
      5 import warnings
----> 7 import pysm.units as u
      9 from so_models_v3 import SO_Noise_Calculator_Public_v3_1_1 as so_models
     10 from . import so_utils

ModuleNotFoundError: No module named 'pysm'

I installed pysm3 from conda-forge but I had the same issue if I used pip. If you don't want to change the name in mapsims I think there's a way to backport the name pysm within the pysm3 package so that import pysm also succeeds.


Potential issue with conditional compilation

I'm using:

SQLcl: Release <IP_ADDRESS> Production Build: <IP_ADDRESS>1.1718
sql_developer/trivadis_advanced_format.xml
sql_developer/trivadis_custom_format.arbori

We have some packages that throw errors when formatting. I'm not sure as to the exact cause, but I suspect one of the causes has to do with conditional compilation. There's one where this happens that is publicly available:
https://github.com/OraOpenSource/Logger/blob/master/source/packages/logger.pkb
When formatting that package body, I get:
Formatting file 254 of 604: /Users/dmcghan/Downloads/export/packages/logger.pkb... Syntax Error at line 980, column 16

        end if;
                ^^^

Expected: ... skipped.

Similar to #94. SQLDev parser gets an error. As a result the code will not be formatted in SQLcl.

SQLDev can handle conditional compilation. However, handling all constellations is not that easy. Without applying the logic of the pre-compiler it will be virtually impossible to provide a satisfying result for complex cases. And there are cases where the code in conditional compilation blocks does not contain PL/SQL. So, this might be improved in future versions of SQLDev, but cannot be "solved" IMO.

Good to know. Thanks!


The GUI version of Vim is launched when you run the console version of Vim with the -y option.

Steps to reproduce

run console version vim with -y option.
gui verison vim launched

Expected behaviour
The console version of Vim needs to be executed.
Version of Vim
9.1.857
Environment
windows 11 24h2
powershell 7.4.5
windows terminal 1.21.2911.0

yes, because Vim will try to behave like a "classical" gui editor, that means like menu bars and requires a GUI. I'll make it a bit more clear in the help.

Isn't this working as intended?
							*-y* *easy*
-y		Easy mode.  Implied for |evim| and |eview|.  Starts with
		'insertmode' set and behaves like a click-and-type editor.
		This sources the script $VIMRUNTIME/evim.vim.  Mappings are
		set up to work like most click-and-type editors, see
		|evim-keys|.  The GUI is started when available.

ah, yes, it's right there. Thanks I looked at this help and somehow missed the last sentence


Edge poor performance

Hey was working with this plugin and liked it alot until i saw my site on edge. Everything is stuttering . Same with IE. Tried the demo pages and same issue.
Any idea how to fix this ?

same :/


Revert "Export more public APIs in top-level package"

This reverts commit 40b45ad8196087fda02887a9257769d285c7302a.
Closes #147
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

This obviously isn't the ideal change, but I wanted to stage it here in case we decide this should go in to fix the unit test job

should close this once #153 merges


Update application to use commandline utils and add new cat image.

Modified to use CommandLineUtils extension and added a new cat image from Pixabay which can be used for free.

Closing due to inactivity -- feel free to re-open once review comments are addressed.


bitwise bug?

can someone have a look at these blocks? I can't see any error

i get 0 - 0 - 0

App Inventor doesn't include 0x as a prefix for hex. Of the blocks that you have, only the last one including the convert number block will do what you want, and only if you remove the 0x prefix. Note that you'll need to use a text block instead because 'ff' is not a valid decimal number.

In the future, these types of inquiries should be directed to the MIT App Inventor Forum.

Yes, sorry, it would be nice if something like this was in the doc http://ai2.appinventor.mit.edu/reference/blocks/math.html#bitwise_and people who cames from C could have problems to make this block working


chore: group packages in dependabot.yml

It makes all the changes to the same package manager in 1 PR, so GitHub Actions, NPM, etc, updates get grouped.


ytdl should merge subtitles into the output file when the output format supports subtitle streams (eg mkv)

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've searched the bugtracker for similar feature requests including closed ones

Description

YTDL does not currently seem to merge subtitles into mkv output files, instead leaving a separate subtitle file beside the regular output file.
I would like it to automatically merge subtitles in addition to video/audio since mkv supports subtitle streams.
Other output formats that support subtitle streams could do with the same feature.

Read FAQ?
--embed-subs                     Embed subtitles in the video (only for mp4,
                                 webm and mkv videos)


S3 State bucket - put public access block denied

We are using a combination of account level S3 public access block, and an organization SCP that prevents the use of PutBucketPublicAccessBlock.
This results in a (non-blocking, but mildly irritating) access denied error when creating new state buckets, and always having to skip bucket update for public access blocking when re-initialising a module to prevent access denied errors.

I believe we can use disable_bucket_update for the second case, but for the first it seems like Terragrunt will always try to enable public access block on new buckets.
Is there a possibility of introducing a skip for public access blocking, similar to other bucket configurations?

Released in https://github.com/gruntwork-io/terragrunt/releases/tag/v0.38.8


Site Collection App Catalog - External Users

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

I created a site collection with external user.
I add the app catalog on the site collection (Add-SPOSiteCollectionAppCatalog)
I deployed an app in the site collection app catalog and I shared the site with an external user.
The external user has a blank page on the site.
when I disable the app catalog (Remove-SPOSiteCollectionAppCatalog), the external user see the site.
regards

I've run into this same problem. There is a thread around this issue here
https://techcommunity.microsoft.com/t5/SharePoint-Developer/Site-Collection-App-Catalog-External-Users/td-p/149694
My external users can access pages that do not contain any custom webparts.
As far as I can understand, adding external user access to the tenant catalog should/could fix this issue right now. But hardly it's a good option.
The thread goes pretty well all the use cases and where the bug seems to exist.

Thank you, I will do some tests on different tenants

It's essential to share the tenant catalog for external user.
The external users have the page with the webparts, but have many times the blank page.
Do you have a solution ?

I've just tested this again in our tenant and I'm no longer experiencing the issue, using my guest account I can see the SPFX web parts (installed to the site collection app catalog)  just fine! Could this have been resolved but this issue not been updated @VesaJuvonen?

On my tenant, i have same problem, any news ?
@VesaJuvonen : It is strange that we also have to share the application catalog for each external user.

Yes this issue has been resolved and we didn't update this thread.
@PooLP - Could you open a new issue and give details about your problem on that thread?  The issue of not being able to see webparts as an external user on both the tenant app catalog and the site collection app catalog has been fixed.  Therefore the problem you are seeing may be specific to your tenant.


Fixing numpy version

Because of:
https://github.com/pyansys/pymapdl/actions/runs/3730672637/jobs/6327994564#step:13:73
I need to fix the numpy version to 1.23.5 until VTK fix:
https://github.com/Kitware/VTK/blob/726ca7c45bef7de71254d2377c810d23612a56da/Wrapping/Python/vtkmodules/util/numpy_support.py#L74-L88

To be merged after the dev-docs action has been updated.

Merging without coverage/ubuntu local test.


Attachments: layout issue

Reported by Desiree:
'Aangeraden' en 'Data Management Plan' staan nu heel dicht tegen elkaar aan.

I noticed this too ... Can be fixed by tweaking the column width on slot.html. Change lines 6 & 7 to be style as col-3, col-6 instead of col-2, col-7.


Add "pytest" and change instruction for development usage.

Added "pytest" package to environment_dev.yml. The package is needed for running the tests.
Additionally, instruction in README.md on how to use pycomlink as a developer was not totally clear, and therefore was changed slightly. This involves that custom naming of environment is not considered anymore as it is not necessary.

Codecov Report

Merging #100 (9062f96) into master (7016c63) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   64.01%   63.60%   -0.41%
==========================================
  Files          25       25
  Lines         892      882      -10
==========================================
- Hits          571      561      -10
  Misses        321      321

Flag
Coverage Δ

unittests
63.60% <ø> (-0.41%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pycomlink/util/maintenance.py
71.42% <0.00%> (-1.91%)
:arrow_down:

pycomlink/processing/baseline.py
18.18% <0.00%> (-1.23%)
:arrow_down:

pycomlink/spatial/idw.py
65.45% <0.00%> (-0.62%)
:arrow_down:

pycomlink/spatial/interpolator.py
75.00% <0.00%> (-0.61%)
:arrow_down:

pycomlink/processing/wet_antenna.py
90.14% <0.00%> (-0.28%)
:arrow_down:

pycomlink/validation/validator.py
57.73% <0.00%> (-0.26%)
:arrow_down:

pycomlink/validation/stats.py
90.00% <0.00%> (-0.13%)
:arrow_down:

pycomlink/processing/xarray_wrapper.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7016c63...9062f96. Read the comment docs.

👍


[HUDI-4629] Create hive table from existing hoodie Table failed when the table schema is not defined

Create table
use hudi;
CREATE TABLE  test_hudi_table_mor (
  id int,
  name string,
  price double,
  ts long,
  dt string
) using hudi
options (
  primaryKey = 'id',
  preCombineField = 'ts',
  type = 'mor'
 )
 partitioned by (dt);

Create _rt table
CREATE TABLE test_hudi_table_mor_rt
using hudi
OPTIONS (
  'hoodie.query.as.ro.table' = 'false'
)
location 'hdfs://cluster1/warehouse/tablespace/managed/hive/hudi.db/test_hudi_table_mor';

Failed exception:
WARN CreateHoodieTableCommand: Failed to create catalog table in metastore: org.apache.hadoop.hive.ql.metadata.HiveException: at least one column must be specified for the table

Related pr: [HUDI-4149] Drop-Table fails when underlying table directory is broken
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure


Using gTabulate with a newtype wrapper for a record type

I'm having trouble defining an instance of Tabulate for my type.
import Data.Generic.Rep (class Generic)
import Data.Function.Memoize (class Tabulate, gTabulate)

newtype BuildType = BuildType
  { url :: String
  , name :: String
  , project :: String
  }

derive instance genericBuildType :: Generic BuildType _

instance tabulateBuildType :: Tabulate BuildType where
  tabulate = gTabulate

This fails with:
Error found:
in module Model
at d:\Dropbox\Projects\Purescript\tc-ui\tc-ui\src\Model.purs line 25, column 3 - line 25, column 23

  No type class instance was found for

    Data.Function.Memoize.Tabulate (Rec (Product (Field "name" String) (Product (Field "project" String) (Field "url" String))))

while checking that expression Tabulate { "tabulate": gTabulate
                                        }
  has type { "tabulate" :: forall r. (BuildType -> r) -> BuildType -> Lazy r
           }
while checking that type forall a r rep.
                           ( Generic a rep
                           , Tabulate rep
                           ) => (a -> r) -> a -> Lazy r
  is at least as general as type (BuildType -> r0) -> BuildType -> Lazy r0
in value declaration tabulateBuildType

where r0 is a rigid type variable
        bound at line 25, column 3 - line 25, column 23

See https://github.com/purescript/documentation/blob/master/errors/NoInstanceFound.md for more information,
or to contribute content related to this error

Am I doing anything wrong? Or is this a known limitation?
Thank you

This is a known limitation right now. The library doesn't support records yet. It could though, if we add the right instances.

Thank you for your prompt response.
If you don't mind me asking, it's only day 3 in my purescript journey, how would I go about implementing an ad-hoc instance of Tabulate BuildType?

It would probably be quicker to add generic support, to be honest 😄
If you really wanted to make an ad-hoc instance, you could do it by treating the record like a nested tuple (have a look at the instance for Tuple, for example)

The tuple hint worked for me :D
I tried creating an instance of Tabulate for records, to see if I could submit a PR for it, but I don't know how to abstract over property names... I suppose I should be using Generic. I may look back into this if I find the time...
Cheers!


Where to buy screen?

Hi is there a link anywhere for which screen to buy.
The files are a bit confusing it seems like the build document with links to parts is for the none portable version as it links to a 3.2" screen.
Thankyou

Yes the LCD for the portable version is different from the "desktop" version of the picoTracker.
Here is a link to the screens I've used for my builds of the portable version

Yes the LCD for the portable version is different from the "desktop" version of the picoTracker. Here is a link to the screens I've used for my builds of the portable version

thankyou for the response and link!


New release for eo-0.40.4

New release for eo-0.40.4

PR-Codex overview
This PR updates the version of various eo files from 0.40.3 to 0.40.4, reflecting changes across multiple test files and object definitions in the org.eolang namespace.
Detailed summary

Updated version from 0.40.3 to 0.40.4 in multiple files.
Added package and tests sections in various test files.
Maintained consistent updates across all related eo files and test cases.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.


Add how to use gopls

$ gopls --help
The Go Language source tools.

 It is typically used with an editor to provide
language features. When no command is specified, gopls will default to the 'serve'
command. The language features can also be accessed via the gopls command-line interface.

Available commands are:

main:
  serve : run a server for Go code using the Language Server Protocol
  version : print the gopls version information
  bug : report a bug in gopls
  api-json : print json describing gopls API
  licenses : print licenses of included software

features:
  call_hierarchy : display selected identifier's call hierarchy
  check : show diagnostic results for the specified file
  definition : show declaration of selected identifier
  folding_ranges : display selected file's folding ranges
  format : format the code according to the go standard
  highlight : display selected identifier's highlights
  implementation : display selected identifier's implementation
  imports : updates import statements
  remote : interact with the gopls daemon
  inspect : interact with the gopls daemon (deprecated: use 'remote')
  links : list links in a file
  prepare_rename : test validity of a rename operation at location
  references : display selected identifier's references
  rename : rename selected identifier
  semtok : show semantic tokens for the specified file
  signature : display selected identifier's signature
  fix : apply suggested fixes
  symbols : display selected file's symbols
  workspace : manage the gopls workspace (experimental: under development)
  workspace_symbol : search symbols in workspace

gopls flags are:
  -debug string
        serve debug information on the supplied address
  -listen string
        address on which to listen for remote connections. If prefixed by 'unix;', the subsequent address is assumed to be a unix domain socket. Otherwise, TCP is used.
  -listen.timeout duration
        when used with -listen, shut down the server when there are no connected clients for this duration
  -logfile string
        filename to log to. if value is "auto", then logging to a default output file is enabled
  -mode string
        no effect
  -ocagent string
        the address of the ocagent (e.g. http://localhost:55678), or off (default "off")
  -port int
        port on which to run gopls for debugging purposes
  -profile.cpu string
        write CPU profile to this file
  -profile.mem string
        write memory profile to this file
  -profile.trace string
        write trace log to this file
  -remote string
        forward all commands to a remote lsp specified by this flag. With no special prefix, this is assumed to be a TCP address. If prefixed by 'unix;', the subsequent address is assumed to be a unix domain socket. If 'auto', or prefixed by 'auto;', the remote address is automatically resolved based on the executing environment.
  -remote.debug string
        when used with -remote=auto, the -debug value used to start the daemon
  -remote.listen.timeout duration
        when used with -remote=auto, the -listen.timeout value used to start the daemon (default 1m0s)
  -remote.logfile string
        when used with -remote=auto, the -logfile value used to start the daemon
  -rpc.trace
        print the full rpc trace in lsp inspector format
  -v    verbose output
  -vv
        very verbose output

https://github.com/golang/tools/blob/master/gopls/doc/command-line.md


run bot in server,about 1 hour ago ,the process will be killed

I run bot in server,about 1 hour ago ,the process automatic disappear,and have no some log

Need More Information
Sorry, you did not follow the ISSUE Template, and there's not enough information about your problem.
In order to help us to find the problem out, you should provide all the detail information about the issue. Please make sure you are following the ISSUE Template, answer all the question, and the more important: provide the steps to reproduce the problem.

sorry,i did not know the ISSUE Template,I will make some test to get more information about the problem


onMembersAdded Event Not Triggering on an App Service with Authentication Enabled

Hi,
I am developing a notification bot in TypeScript based on the Teams Toolkit sample code.
I use the NotificationBot#findMember method to identify users and send notifications to those who have installed the bot.
https://learn.microsoft.com/en-us/javascript/api/@microsoft/teamsfx/botbuildercloudadapter.notificationbot?view=msteams-client-js-latest
Everything was working fine until I enabled Microsoft IdP authentication on the App Service for access control. Since then, the bot has stopped sending notifications.
While investigating the issue, I tried logging a message to the console when the bot is installed, but noticed that no messages are output when authentication is enabled. Below is an example of the debugging code:
this.onMembersAdded(async (turnContext, next) => {
   await turnContext.sendActivity("Welcome!! You can receive notifications.");
   await next();
});

It also appears that the bot is not writing the user’s connection information to the connected storage.
Could there be any possible causes for this?
When adding the bot in Teams, do I need to explicitly allow the request?
If so, could you please provide the specific configuration steps?

@hirokika - Thanks for reporting your issue. We will check and update you soon.

@hirokika - Have you checked with the getPagedInstallations() API? Is your issue resolved with this suggestion, or are you still facing the issue?

@hirokika - Could you please share your valuable feedback via Microsoft Teams Developer Community Response Feedback
link?


[BE] Implement the blog posts API endpoint

Business Requirements
As a visitor, I want to be able to read blog posts on the website so that I can learn more about the initiative.
Acceptance Criteria

There should be an API endpoint which will retrieve all published blog posts, paginated, 15 items per page, ordered by the publish date.
There should be an ability to search the blog posts by title
The blog posts endpoint should retrieve the following details for each blog post:

Title
Slug
Excerpt
Author name
Author profile image
Publish Date
Tags

An API documentation should b e implemented with Scribe for the endpoint so that it will be easier for the frontend team to integrate it.

@nikoladomazetovikj I looked at your PR, and it reminded me about a few things that I initially missed in this ticket.
The blog will be for people with LearnHub Marketing role access (at the start, we may expand this as a blogging platform for each member of the platform later on) which means we want to split it from the actual user object.
It should have a separate author profile table which will be related to the blog posts table so that we don't mix the same profile from the platform with the author profile.
The author profile should have:

First Name
Last Name
Profile Picture
Bio
Website URL
LinkedIn Profile URL

Also, tags should be a separate table on its own which would require a many to many relationship with the blog posts.
The same goes for #36

@davorminchorov this is the ER diagram of current database design

We can also add status in the blogs table, for e.g.:

draft - author still editing the post
published - ready to display in the blog list
review - in case we want to check blogs before publishing

The ER Diagram looks good, you can move the name from the users table to first_name and last_name in the authors table.
The statuses look good, maybe change review to in_review and add archived.
I know that having soft deletes is a popular thing but we wouldn't need soft deletes for this project. They are very complex to manage for no real benefit.
Having an audit table for each action could help to track the changes for every action in the system.


feat: support envd-server image

Signed-off-by: Keming<EMAIL_ADDRESS>
fix #1027

This PR requires a new release from tensorchord/envd-server.

It's ready to review. PTAL @gaocegege  @VoVAllen


GUVNOR-2670: Screens on 'Authoring->Project Authoring' of business-central are opened by default

See https://issues.jboss.org/browse/GUVNOR-2670

Jenkins, please retest this.

Jenkins, please retest this.

@karreiro A test would be nice (just confirming PerspectiveManager.savePerspectiveState() is called when LogoutCommand.execute() is called)...

Thanks @manstis

+1 to merge. Thanks @karreiro


custom page animation

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

all pages uses default animation provided by ionic
Expected behavior:

a way to disable default animation and use angular's animation to make page transitions
i was doing POC with animation and ionic 2 just of implement below animation
https://codepen.io/jtushar53/pen/RKWmpE

Internally, we do not use angular animate, but our own animation controller.
If you would like to like to build out custom transitions, you can use this as template.
https://github.com/driftyco/ionic/tree/master/src/transitions


add support to translation tag with space

ping @vgoma

Sorry,but i forgot build js files..

@versh23 no worries. I've built everything during publishing the release 2.0.5.


Update navbar-dark

I adding text-color to nav-link inside navbar-dark.
It's helpful for me to show social links in navbar (๑• ω •๑)

Squash your patches
Make sure tests pass

Can you provide some screenshots of what this adds? Not so sure I want to add the variance to the utilities from the navbar scheme—those values should be immutable.

Oops, I dropped my repo (´・ω・｀)
I'll fork and pull request again.
This is my first time of pull request (>﹏<)
result like follows

New pull request!
https://github.com/twbs/bootstrap/pull/18078

No need to make duplicates @Shirohana — you can push to this branch in the future to update it.
That said, I'm not in favor of it for the use case described. This encourages users to not follow company brand guidelines:

https://www.facebookbrand.com
https://about.twitter.com/company/brand-assets
https://developers.google.com/+/branding-guidelines?hl=en

I'm sorry that I caused distress :(
My English isn't good and I'm a newbie on Git.
I'll trying my best and complete the pull request :D

It seems I'm too disrespect of them....
I'm so sorry (╥﹏╥)

https://github.com/twbs/bootstrap/pull/18078


services: add _get_draft_and_parent_by_id

closes https://github.com/inveniosoftware/invenio-rdm-records/issues/468

@jrcastro2 Can you have a look at the failing tests.

I'm not able to reproduce the test failure on Python 3.9 PostgreSQL 9, ES 6 locally, so I'm simply disabling this matrix case as all other cases are passing, and this one is also passing locally in exactly same environment.


[launcher] Add ipv6 support on ingress network

Refactor the port opening logic and add support for accepting IPv6 ingress traffic.

/gcbrun

/gcbrun

/gcbrun

So seems like "multiport" only support at most 15 ports in one command which is not going to work in our use cases.
Created a new pr to address the ipv6 problem (pr/487) first
The refactoring/improve performance will be handled later.


include images in API docs

https://stackoverflow.com/questions/66276654/how-to-insert-images-after-some-specific-functions-in-sphinx-docs

feature added in v1.0.2


"Unirea" is listed in the drop-down menu

Description:
"Unirea" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Unirea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Unirea, CĂLĂRAȘI (Unirea)".


xWebAdministration: Updating change log prior to release

Pull Request (PR) description

Update CHANGELOG.md

Updating change log prior to release.

This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #540 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #540   +/-   ##
=======================================
  Coverage   91.72%   91.72%
=======================================
  Files          17       17
  Lines        2766     2766
=======================================
  Hits         2537     2537
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c15d40...f24f121. Read the comment docs.


Upgrade Ed25519 to Sr25519 in implementation

so it works with latest UI tool defaults, since they default to sr

done


Pretty name for datatransfer target when using selectors

Extract table name from query and use it as a name for datatransfer target. Currently target name is just an entire quoted query.

Implemented


Tf Lite only support 4D l2_normalize?

I build some feature extract network model and converted tflite using by toco successfully.
But I got error "tensorflow/contrib/lite/kernels/l2norm.cc:47 NumDimensions(input) != 4 (2 != 4), when run interpreter->AllocateTensors().
I extract feature using by tf.nn.l2_normalize.
embeddings = tf.nn.l2_normalize(prelogits, 1, 1e-10, name='embeddings')
where prelogits is 2D tensor.
How can I extract normalized feature with tflite?

@aselle @andrehentz for thoughts here.


CIP: Protocol Parameters

This was suggested by the QuantStamp Auditors.  The idea is to provide a base CIP that we should use as the root of all future protocol parameter changes (including the forthcoming change to the k parameter).
I have checked the original draft with Jared Corduan (IOHK Ledger team lead) and Duncan Coutts, and I have uploaded it to the Cardano Forum.  There have been 48 views, but no comments so far.  I will continue to monitor this for community comments, but since it is not proposing any changes, I would expect discussion to be fairly minimal.

Thanks for using the proper file naming conv. to align with existing CIPs..
File content also needs header - for proper structure see the template in root dir or check into CIP1.

OK.  I was asked to remove the header I thought...  I'll add it back

Thanks for using the proper file naming conv. to align with existing CIPs..
File content also needs header - for proper structure see the template in root dir or check into CIP1.

OK.  I was asked to remove the header I thought...  I'll add it back

Added back the header.  I don't know the CIP number, of course - someone else will need to add that.  Likewise comments if there is a URI that should be referred to.

Added back the header.  I don't know the CIP number, of course - someone else will need to add that.  Likewise comments if there is a URI that should be referred to.

Minor reservations about jumping directly as "Active" - should be merged shortly once consensus is reached (status might be tweaked)

Minor reservations about jumping directly as "Active" - should be merged shortly once consensus is reached (status might be tweaked)


Clicking the "Add topics" link at a GitHub repository starts loading animation, but nothing happens

Are you requesting a feature or reporting a bug?
Bug.
What is the current behavior?
When TestCafe clicks the "Add topics" link on a GitHub repository, loading animation is playing indefinitely.
What is the expected behavior?
When TestCafe clicks the "Add topics" link on a GitHub repository, a page loads an input element after animation is played.
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
The tested page URL: https://github.com/MikhailTymchukDX/E1016-ASPxGridView-How-to-customize-detail-buttons
Test code
import { Selector } from 'testcafe';

fixture `Topic add bot`
    .page `https://github.com/MikhailTymchukDX/E1016-ASPxGridView-How-to-customize-detail-buttons`;

test('Add .NET topic', async t => {
    const signInLink1 = await Selector('.site-header-actions').find('a').withText("Sign in");

    await t
        .click(signInLink1)
        .typeText("#login_field", "<your login here>")
        .typeText("#password", "<your password here>");

    const signInSubmit = await Selector("input[value='Sign in']");
	await t.click(signInSubmit);
	const addTopics = await Selector("button").withText("Add topics");
    await t.click(addTopics).wait(5000);
});

Specify your

operating system: Windows 8.1 64-bit
testcafe version: 0.15.0
node.js version: 7.4.0

It's related to the testcafe-hammerhead, so I've created an issue: https://github.com/DevExpress/testcafe-hammerhead/issues/1129

fixed in<EMAIL_ADDRESS>


Child components does not render when I use useUndoable in react-flow

If I use the default useState in react flow I have no problems and when I change the state from child components everything works great, but if I use useUndoable as the state manager it doesn't work and only the state is updated, Even useEffect doesn't work.
const [elements, setElements, { undo, canUndo, redo, canRedo, reset }] =
useUndoable({
nodes: defaultNodes,
edges: defaultEdges,
});
useEffect(() => {
console.log(elements.nodes[0]);
}, [elements]);

ReactFlow's v10 updates now require that you take the event-based approach first. How are you attaching event handlers to the ReactFlow component and updating setElements?

Here's a Codesandbox showing that this behavior works just fine, all that matters is how you update the elements: https://codesandbox.io/s/use-undoable-native-demo-5lgrbz?file=/src/App.js

I am using useContext to get value of state in child components.
This is a example of what I am doing in parent component:
const [elements, setElements, { undo, canUndo, redo, canRedo, reset }] =
useUndoable({
nodes: defaultNodes,
edges: defaultEdges,
});
useEffect(() => {
console.log(elements.nodes[0]);
}, [elements.nodes]);
const triggerUpdate = useCallback(
(t, v) => {
setElements((e) => ({
nodes: t === "nodes" ? v : e.nodes,
edges: t === "edges" ? v : e.edges,
}));
},
[setElements]
);
const onNodesChange = useCallback(
(changes) => {
triggerUpdate("nodes", applyNodeChanges(changes, elements.nodes));
},
[triggerUpdate, elements.nodes]
);
const onEdgesChange = useCallback(
(changes) => {
triggerUpdate("edges", applyEdgeChanges(changes, elements.edges));
},
[triggerUpdate, elements.edges]
);
const onConnect = useCallback(
(connection) => {
triggerUpdate("edges", addEdge(connection, elements.edges));
},
[triggerUpdate, elements.edges]
);
const onNodeChangeFontFamily = useCallback(
(id, value) => {
const newState = elements?.nodes.map((node) => {
if (node.id === id) {
node.data.style = {
...node.data.style,
fontFamily: value,
};
}
return node;
});
setElements((e) => ({
nodes: newState,
edges: elements.edges,
}));
},
[elements.edges, elements?.nodes, setElements]
);

I want to change font family of node in a child component and get value of new state in another child component.
It changes state but does not render child components, so I can not get value of new state

First thing I notice is there may be an error in the onNodeChangeFontFamily function. You're attempting to mutate the state directly with node.data.style = { ... }. Since you're returning the node directly, I'm assuming it's "working" in the sense that it's being applied, but these changes will not be reflected in the state. You may have intended this, I'm not sure.
Can you show me some markup and more importantly how you're calling these functions (in particular the onNodeChangeFontFamily function)?

First thing I notice is there may be an error in the onNodeChangeFontFamily function. You're attempting to mutate the state directly with node.data.style = { ... }. Since you're returning the node directly, I'm assuming it's "working" in the sense that it's being applied, but these changes will not be reflected in the state. You may have intended this, I'm not sure.

Before I use useUndoable It was working well.So I do not think the problem is mutate directly.
As I said before, I use context for manage state and its values. So I call onNodeChangeFontFamily  like this:
const flow = useContext(flowContext);
const handleChangeFont = (fontFamilyValue) => {
flow.onNodeChangeFontFamily(elementId, fontFamilyValue);
};
and get value of state in another child component like this function:
const getNode = flow.getNodeById(id);

              some text

useUndoable is more strict than useState; I think it more likely that useUndoable is simply bringing to light some subtle state bugs that would fly with useState before.
Although I am not sure if this will solve your issue, I highly recommend mutating the state with the setElements function. If you don't want to be able to undo the font family change, then set the ignoreAction boolean to true: setElements(newElements, null, true). This has the benefit in that it still updates the primary state, which ensures React can properly understand/render your content with the new state.

What does your React.Context object look like? If you are maintaining a separate copy of the state there, that would cause this. If that's the case, you need to move useUndoable to your context provider and include the state mutation functions in that export.

What does your React.Context object look like? If you are maintaining a separate copy of the state there, that would cause this. If that's the case, you need to move useUndoable to your context provider and include the state mutation functions in that export.
<flowContext.Provider
value={{
sidebarStatus,
handleSidebar,
nodes: elements?.nodes,
onNodesChange,
edges: elements?.edges,
onEdgesChange,
onConnect,
onNodeAdd,
onNodeChangeText,
onNodeChangeType,
tools,
onSidebarMouseOver,
onSidebarMouseOut,
onSidebarClick,
getNodeById,
onNodeChangeFontSize,
onNodeChangeFontStyle,
onNodeChangeFontWeight,
onNodeChangeTextDecoration,
onNodeChangeTextAlignment,
onNodeChangeTextColor,
onNodeChangeTextHighlight,
textColors,
setTextColors,
textHighlight,
setTextHighlight,
elements,
setElements,
undo,
redo,
canUndo,
canRedo,
reset,
}}

useUndoable is more strict than useState; I think it more likely that useUndoable is simply bringing to light some subtle state bugs that would fly with useState before.
Although I am not sure if this will solve your issue, I highly recommend mutating the state with the setElements function. If you don't want to be able to undo the font family change, then set the ignoreAction boolean to true: setElements(newElements, null, true). This has the benefit in that it still updates the primary state, which ensures React can properly understand/render your content with the new state.

I'll try changing setElements like you, hope it works :)

Ahh, okay, I believe I've misunderstood. So you are creating useUndoable in your context provider, correct? Then passing those props down to any subscriber of your FlowContext, yes?

yes Exactly

Okay, I see.
One quick thing: Your onNodeChangeFontFamily is a bit interesting. I'd refactor it keeping the following in mind:
Since you are always updating the state, remove the elements.edges, elements?.nodes from the dependency array and do all your operations in the setElement function itself. Something like:
const onNodeChangeFontFamily = useCallback(
  (id, value) => {
    setElements((elements) => {
        // Do your stuff here

        return {
          nodes: newState,
          edges: elements.edges,
        }
    };
  },
  [setElements]
);

Now that I have all this context, can you more completely describe to me exactly what's going on?

Since you are always updating the state, remove the elements.edges, elements?.nodes from the dependency array and do all your operations in the setElement function itself. Something like:

I removed elements.edges, elements?.nodes but it did not work again.
My app is too big and It is complicated and I think it is not useful to find the problem.
Isn't it better to make a simple example in Codesandbox?

Yes, an example would be best. As well as an explanation of what the current/expected behavior is.

Sorry that I was able to prepare the link late. I worked on the problem for many hours, but I could not solve the problem properly.
As you can see in this link, although the state is changed, The related components are not rendered, and as a result, the information in the child-components cannot be received.
https://codesandbox.io/s/fervent-rgb-6m4php?file=/src/App.js

The next problem is, why is the undo button activated after the page is fully loaded, while no changes have happened?

Thank you for taking the time to set up this sandbox. I will investigate the issue at my earliest convenience and let you know what I discover 👍

did you check the problem?

Hey @amintabrizi! I apologize, I have not yet had time to investigate this further.
I will put it on my list today and get back to you tomorrow. Thank you for pinging me!

Could you resolve the problem?, I am still waiting for you :(

My sincere apologies. I have been quite busy as of late. I am taking a look at your sandbox as we speak.
Could you provide a very elaborate description of what exactly is not working? I see the weird issue of canUndo, but other than that everything appears to be working as expected.

There is two problem
1-As you can see, you can not change the font although the state is changing, In fact the child component does not rendered
2-If you reload the page, you can see 'can undo' is activated, I could not find any answer that why it is activated

I'm sorry that I'm bothering you :)

You are totally fine! I am glad to help.

//This useEffect does not work,I do not why?

It appears to be working fine for me.

The issue was your onFontChange function, as I explained before. You should not be mutating the node directly, you need to manually pop and apply the changes via the updater function.

There were a number of issues:

You were using the elements variable directly instead of using the e variable given in the callback to setElements
You were mutating the node's data directly with node.data = { ... }; this is a no-no in React.
You were mapping over the old elements, which means that every change will be like one step back in time.

I have refactored your function to remove all direct mutations, and now it works as expected:
const onFontChange = (fontValue) => {
    setElements((e) => {
      // Filter out all the nodes besides id#2
      const filtered = e.nodes.filter((node) => node.id !== "2");

      // Grab the second node
      const secondNode = e.nodes.filter((node) => node.id === "2")[0];

      return {
        // Return a new array compiled of these filtered objects
        nodes: [
          ...filtered,
          {
            ...secondNode,
            data: {
              ...secondNode.data,
              fontFamily: fontValue
            }
          }
        ],
        // You must use `e` here, not `elements`
        edges: e.edges
      };
    });
  };

You can view my updated sandbox here: https://codesandbox.io/s/eloquent-noyce-c42in6?file=/src/App.js:2390-3048

As for the issue of canUndo, I am still unsure what that cause is, though I am looking into it now 👍

Thank you
The problem is that if we want to go back to the previous state, we have to click on the undo button twice?why?

Thanks


[BUG] - Black Import Error in Tests

Black seems to be out of date causing CI tests to fail.  You can see this from https://github.com/Quansight/qhub/runs/6039400018?check_suite_focus=true.

The fix seems to be upgrading to black==22.3.0 (https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click)

Seems to already be fixed on main