Dev UI shows popup with warnings

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[X] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?
When launching the UI through the devcontainer a popup with warnings is displayed. The warnings are concerning two external libraries, autolinker and argo-ui. Autolinker is missing source maps and argo-ui is not importing things correctly.
Expected behavior would be to not have a popup with warnings
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
make start UI=true

Logs from the workflow controller
Contents of the popup displayed to the user

Compiled with problems:
×
WARNING in ./node_modules/argo-ui/src/components/index.ts 4:0-66
export 'PageContextProps' (reexported as 'PageContextProps') was not found in './page/page' (possible exports: Page, PageContext)
WARNING in ./node_modules/argo-ui/src/components/index.ts 7:0-76
export 'DropDownMenuProps' (reexported as 'DropDownMenuProps') was not found in './dropdown-menu' (possible exports: DropDownMenu)
WARNING in ./node_modules/argo-ui/src/components/index.ts 7:0-76
export 'MenuItem' (reexported as 'MenuItem') was not found in './dropdown-menu' (possible exports: DropDownMenu)
WARNING in ./node_modules/argo-ui/src/components/index.ts 9:0-71
export 'TopBarProps' (reexported as 'TopBarProps') was not found in './top-bar/top-bar' (possible exports: TopBar)
WARNING in ./node_modules/argo-ui/src/components/index.ts 9:0-71
export 'Toolbar' (reexported as 'Toolbar') was not found in './top-bar/top-bar' (possible exports: TopBar)
WARNING in ./node_modules/argo-ui/src/components/index.ts 9:0-71
export 'TopBarFilter' (reexported as 'TopBarFilter') was not found in './top-bar/top-bar' (possible exports: TopBar)
WARNING in ./node_modules/argo-ui/src/components/index.ts 10:0-40
export 'Tab' (reexported as 'Tab') was not found in './tabs/tabs' (possible exports: Tabs)
WARNING in ./node_modules/argo-ui/src/components/index.ts 18:0-68
export 'SelectOption' (reexported as 'SelectOption') was not found in './select/select' (possible exports: Select)
WARNING in ./node_modules/argo-ui/src/components/index.ts 18:0-68
export 'SelectProps' (reexported as 'SelectProps') was not found in './select/select' (possible exports: Select)
WARNING in ./node_modules/autolinker/dist/es2015/anchor-tag-builder.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/anchor-tag-builder.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/anchor-tag-builder.ts'
WARNING in ./node_modules/autolinker/dist/es2015/autolinker.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/autolinker.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/autolinker.ts'
WARNING in ./node_modules/autolinker/dist/es2015/html-tag.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/html-tag.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/html-tag.ts'
WARNING in ./node_modules/autolinker/dist/es2015/htmlParser/parse-html.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/htmlParser/parse-html.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/htmlParser/parse-html.ts'
WARNING in ./node_modules/autolinker/dist/es2015/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/index.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/index.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/email-match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/email-match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/email-match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/hashtag-match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/hashtag-match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/hashtag-match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/index.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/index.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/mention-match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/mention-match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/mention-match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/phone-match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/phone-match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/phone-match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/match/url-match.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/url-match.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/match/url-match.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/email-matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/email-matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/email-matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/hashtag-matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/hashtag-matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/hashtag-matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/index.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/index.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/mention-matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/mention-matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/mention-matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/phone-matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/phone-matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/phone-matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/tld-regex.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/tld-regex.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/tld-regex.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/url-match-validator.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/url-match-validator.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/url-match-validator.ts'
WARNING in ./node_modules/autolinker/dist/es2015/matcher/url-matcher.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/url-matcher.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/matcher/url-matcher.ts'
WARNING in ./node_modules/autolinker/dist/es2015/regex-lib.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/regex-lib.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/regex-lib.ts'
WARNING in ./node_modules/autolinker/dist/es2015/truncate/truncate-end.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-end.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-end.ts'
WARNING in ./node_modules/autolinker/dist/es2015/truncate/truncate-middle.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-middle.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-middle.ts'
WARNING in ./node_modules/autolinker/dist/es2015/truncate/truncate-smart.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-smart.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/truncate/truncate-smart.ts'
WARNING in ./node_modules/autolinker/dist/es2015/utils.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/utils.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/utils.ts'
WARNING in ./node_modules/autolinker/dist/es2015/version.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/version.ts' file: Error: ENOENT: no such file or directory, open '/home/vscode/go/src/github.com/argoproj/argo-workflows/ui/node_modules/autolinker/src/version.ts'

Logs from in your workflow's wait container
N/A

The warnings are concerning two external libraries, autolinker and argo-ui.

Yea they're both warnings you can ignore. There's also SCSS warnings on deprecated syntax in the Foundation UI library. All of them are from deps so we can't really fix them.
I didn't want to add an ignore in the webpack config though as they can become errors and so we should be mindful of them, particularly when doing dep upgrades or changing config. For instance, https://github.com/argoproj/argo-workflows/pull/12516#issuecomment-1925427733 has a test error due to this. #12516 also removes the autolinker dep.

argo-ui is not importing things correctly.

Yea IIRC it was written before import type existed and is on an older version of TS, Webpack, etc

https://github.com/argoproj/argo-ui/pull/509 unblocked https://github.com/argoproj/argo-ui/pull/552 which unblocked #12516 and now the popup warnings have been resolved plus several others!


Update cache.py

Fix a potential issue with property maxsize being None

Coverage remained the same at 100.0% when pulling 54f6bc1d63f520f6b143257299d5ed1063bb8dd2 on AllinolCP:patch-1 into 797952bffb35d75c86f0bdf04d78adffd3d34430 on dgilland:master.

Thanks for the fix! Very appreciated! 👍

These changes are in 0.13.0: https://pypi.org/project/cacheout/0.13.0/


Acme-challenge 404

It looked like  #138 would have fixed this issue but it's still a problem for me.  The challenge file is created but if I attempt to go to that link Wordpress gives me a 404.  I've tried changing the vhost.d/default.conf mentioned in #138 but still get the same error.
Companion logs:
Sleep for 3600s 2017/02/12 06:20:41 Generated '/app/letsencrypt_service_data' from 3 containers 2017/02/12 06:20:41 Running '/app/update_certs' 2017/02/12 06:20:41 Watching docker events Reloading nginx proxy... 2017/02/12 06:20:41 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/update_certs'       h2017/02/12 06:20:41 Contents of /etc/nginx/conf.d/default.conf did not change. Skipping notification ''       ;2017/02/12 06:20:41 [notice] 33#33: signal process started Creating/renewal  www.truckenmiller.com certificates... ( www.truckenmiller.com) 2017-02-12 06:20:41,475:INFO:simp_le:1211: Generating new account key 2017-02-12 06:20:41,847:INFO:requests.packages.urllib3.connectionpool:756: Starting new HTTPS connection (1): acme-v01.api.letsencrypt.org 2017-02-12 06:20:42,572:INFO:requests.packages.urllib3.connectionpool:756: Starting new HTTPS connection (1): letsencrypt.org 2017-02-12 06:20:43,600:INFO:requests.packages.urllib3.connectionpool:207: Starting new HTTP connection (1): www.truckenmiller.com 2017-02-12 06:20:43,928:WARNING:simp_le:1303: www.truckenmiller.com was not successfully self-verified. CA is likely to fail as well! 2017-02-12 06:20:44,431:INFO:simp_le:1313: Generating new certificate private key 2017-02-12 06:20:53,367:ERROR:simp_le:1271: CA marked some of the authorizations as invalid, which likely means it could not access http://example.com/.well-known/acme-challenge/X. Did you set correct path in -d example.com:path or --default_root? Is there a warning log entry about unsuccessful self-verification? Are all your domains accessible from the internet? Failing authorizations: https://acme-v01.api.letsencrypt.org/acme/authz/NrV0M16U-98YVOTTZ-eOdOdZ1P88tNIgRehOgRfrBbo Challenge validation has failed, see error log.
docker-compose:
proxy:
image: jwilder/nginx-proxy:latest
restart: always
ports:
- "80:80"
- "443:443"
volumes:
- /var/run/docker.sock:/tmp/docker.sock:ro
- /home/vagrant/vhost.d:/etc/nginx/vhost.d
- /home/vagrant/certs:/etc/nginx/certs:ro
- /home/vagrant/nginx/html:/usr/share/nginx/html
proxy-companion:
image: jrcs/letsencrypt-nginx-proxy-companion:v1.4
restart: always
volumes:
- /home/vagrant/certs:/etc/nginx/certs:rw
- /var/run/docker.sock:/var/run/docker.sock:ro
volumes_from:
- proxy

I was editing the wrong file in vhost.d. There was a file named "default"  that I edited but once I made changes to the file named "www.truckenmiller.com"  I was able to access the challenge file.  However,  the CA is still saying it is invalid
Here are the logs from the companion container:
Reloading nginx proxy...
2017/02/12 21:21:12 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/update_certs'
h2017/02/12 21:21:12 Contents of /etc/nginx/conf.d/default.conf did not change. Skipping notification ''
;2017/02/12 21:21:12 [notice] 33#33: signal process started
Creating/renewal  www.truckenmiller.com certificates... ( www.truckenmiller.com)
2017-02-12 21:21:12,588:INFO:simp_le:1211: Generating new account key
2017-02-12 21:21:12,961:INFO:requests.packages.urllib3.connectionpool:756: Starting new HTTPS connection (1): acme-v01.api.letsencrypt.org
2017-02-12 21:21:13,933:INFO:requests.packages.urllib3.connectionpool:756: Starting new HTTPS connection (1): letsencrypt.org
2017-02-12 21:21:14,828:INFO:requests.packages.urllib3.connectionpool:207: Starting new HTTP connection (1): www.truckenmiller.com
2017-02-12 21:21:14,852:INFO:simp_le:1305: www.truckenmiller.com was successfully self-verified
2017-02-12 21:21:14,982:INFO:simp_le:1313: Generating new certificate private key
2017-02-12 21:21:23,708:ERROR:simp_le:1271: CA marked some of the authorizations as invalid, which likely means it could not access http://example.com
Challenge validation has failed, see error log.

It turns out my site wasn't accessible externally which I find is really helpful if you want Let's Encrypt to work.


Problem converting YOLO weights

Hi,
Im having issues converting the YOLO weights. After downloading the model Im getting this error.
python convert.py
Traceback (most recent call last):
File "convert.py", line 4, in <module>
    from yolo.yolov3.models import YoloV3, YoloV3Tiny
    ModuleNotFoundError: No module named 'yolo.yolov3'

That's because you are running the convert.py program from the folder where it is saved, not from the root directory. Remove the "yolo." from "yolo.yolov3.models" and it will work.


Cannot read property 'readCapacityUnits' of undefined

https://github.com/eladb/cdk-watchful/blob/f43380c2e871ffd4e55a2cdce190a23d4c6de0aa/lib/dynamodb.ts#L52
Throwing "Cannot read property 'readCapacityUnits' of undefined"

Also having this same issue.

Also having this same issue.

If you are Amazonian, this might help
https://code.amazon.com/packages/ImageMetadataLambda/blobs/mainline/--/src/lib/resources/dynamodb-alarms.ts

The problem for me was that my billing mode for my table was set to
  billingMode: BillingMode.PAY_PER_REQUEST,

If you set it to BillingMode.PROVISIONED then this works.
You can also turn on auto scaling with this:
myTable.autoScaleReadCapacity({ minCapacity: 50, maxCapacity: 100 });


Show follower id in follower list

WHAT is this pull request doing?
Now when we have ids on followers we should display it in the follower list.
HOW can this pull request be tested?
Run a cluster and look in the follower list.

Hm, Id or ID?


🐞 - Unable to provide NG_VALIDATORS when component extends AbstractTuiControl

Which @taiga-ui/* package(s) are the source of the bug?
cdk
Please provide a link to a minimal reproduction of the bug
No response
Is this issue blocking you?
Non-Blocking
Description
Since AbstractTuiControl uses CVA approach when you set valueAccessor in the constructor we face the problem of providing NG_VALIDATORS because it provokes circular dependency injection. It's understandable why this is so but have you considered some variants to deal with this situation?
Here's an example of what I'm talking about https://blog.angular-university.io/angular-custom-form-controls/
the section about How to implement nested form groups (an address nested form)
Angular version
14.2.7
Taiga UI version
3.2.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

You want the same component to provide NG_VALIDATOR and be AbstractTuiControl? We typically go around that by adding a directive with the same selector, it's also an interesting way to split codebase :) Would that work for you? I'm closing this issue because there's nothing we can do in Taiga UI, since CONTROL_VALUE_ACCESSOR is not enough and we need actual NgControl in our components. But feel free to continue discussing workarounds here.

we might actually be able to use a directive, worth a try

no, we're not 🙂
I'll provide you with an example later, maybe we'll figure out how to implement it in Taiga (and does it worth it)


[EN] Feedback for: /tools/polymer-starter-kit/index.html

if the bootstrap style sheet links in starter kit index,
the drawer will hold the tall class and it doesn't collapse.

Please file this issue in the Polymer Start Kit repo
https://github.com/polymerelements/polymer-starter-kit


refactor State to be non-static (and thus thread safe)

refactor State to be non-static
add State as member data on JsHint
refactor classes instantiated by JsHint.lint() to include State

Coverage decreased (-0.1%) to 90.275% when pulling 2aa3fb37f9ee366b6def9b188a7339758023b1ac on eagle-io:threadsafe-regex into 53e037031d1934ac5bda622603743f340bb7f2fe on jshaptic:master.


Update opencv 2.4 constants to 3.0

Merging, however this brought an interesting issue to light since you said that the computer-vision project would not compile on your system with the 2.4 constants (which are supposed to be removed from the 3.0 API), however both the current master and your fork compile on the warg server. This means that potentially there might be code that compiles on the server that will not on systems in a similar situation as yours. We may need to look into why this is the case, since I believe you said that you had installed opencv 3.0 in the same way that we did on the server.


[metadata]: GodotEngine.GodotEngine version 3.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @og-mrk,

This PR's version number "3.0" has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 4.2.2, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 880)


Allow space theme values to be defined as an object.

This may already be possible - so please let me know if it's not actually an issue.
At the moment, we can define the most theme values as objects as opposed to arrays, such as fontSizes:
const theme = {
    fontSizes: {
        body: 12,
        largeHeading: 22
    }
}

This is super useful for allowing changes to be made in the future without having to go and update every array index.
However, if you try to do this with space, and pass it to a component margin or padding, it's not recognised and no padding is applied. E.g.
const themes = {
    space: {
        small: 4,
        large: 16
    }
}

<Box px="small" mb="large">Example</Box>

Is there a reason for this? I'm getting lost in other packages, and sub-packages so can't work out why this functionality is different from the other keys.

I think you might need to explicitely add the the unit (4px, 16px, ..)

Yeah I agree, it's a neat little trick but a bit unpredictable. I think over here is where the values are transformed: https://github.com/jxnblk/styled-system/blob/master/src/styles.js#L21.. And spacing is handled even differently: https://github.com/jxnblk/styled-system/blob/master/src/space.js#L40-L51

Interesting!
I can't tell from glancing at the code why explicit units are only required when using an object as opposed to an array..?

I can't tell exactly either but I think it would be better if it the unit was always required, for example when configuring breakpoints I have to think about whether the unit is px, em, or rems..

This would need to be address in styled-system. If you haven't already, can you open an issue in that repo to discuss?


Improve timestamp logs as human readable format.

Feature request related to a problem
After we deployed the ESO in my k8s-cluster, we generated the logs. we found the timestamp logs of ESO are not in proper format /cluttered. They are not in human-readable format.
Example: {"level":"error","ts":1692291266.732894,"msg":"Reconciler error","controller":"externalsecret","controllerGroup":"external-secrets.io","controllerKind":"ExternalSecret","ExternalSecret":{"name":"apikey-mongo-secret","namespace":"apollosec"}
Describe the solution you'd like
We want timestamp logs of the ESO to be in proper format.
Example: Mon Oct  9 17:37:48 IST 2023 or 2023-09-28T19:29:32Z
Describe alternatives you've considered
No
Additional context
Please, allow us to change the format of timestamp logs.
Example: we can change the squid proxy logs, https://serverfault.com/questions/996364/how-to-add-date-and-time-to-squid-log
So like that, we want access to change the format of the logs.

There's a zap-time-encoding flag that allows you to specify the: Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Does that work for you?

I agree with @raju2128 about the readability, but more importantly, our log stack has severe problems with the way timestamps are logged.
We write all logs from all ESO components to one datastream in Elastic. That means that they are stored in the same index and that the format of fields must be fixed.
However, where most components log the timestamp to field ts, the format is sometimes epoch+micros and sometimes ISO format date+time. Also, one component logs the timestamp in field time.
We are not yet running the latest version, but I understand from the fact that this issue is still open, that things haven't changed here.

Component
Field name
Example value

external-secrets
ts
1703520109.1180224

external-secrets-cert-controller
ts
1703520109.1180224

external-secrets-operator-catalog
time
"2023-12-25T16:00:39Z"Note: no JSON formatting here

external-secrets-operator-controller-manager
ts
"2023-12-25T16:00:39Z"

external-secrets-webhook
ts
1703520109.1180224

@moolen where can I set that zap-time-encoding flag?

Maybe @moolen 's remark is referring to https://github.com/external-secrets/external-secrets/pull/1808
It seems that this is not implemented for all components? Also, ideally you will have the same log format in all components, with just one setting. Plus, this does not deal with the non-JSON layout, with timestamp in a different field, of the operator-catalog.

In the meantime I found that the operator-catalog and operator-controller-manager components are part of Openshift OLM instead of ESO.
Also, setting extraArgs.zap-time-encoding=iso8601 for all 3 components indeed makes the timestamp in ISO format and thus equal to the timestamp in those OLM components, resolving the problem in Elastic datastreams.
Leaves one or two things to be sorted out:

Document this feature
Optional: add a specific parameter in the Helm chart for this feature


[Client Emitters] Client emitters should provide custom configuration options for tspconfig

Clear and concise description of the problem
We found intellisense in VSC does not load anything useful for tspconfig under options of "@azure-tools/typespec-" for client code generation.  See screenshots below.  The expectation is there should be a list of parameters required to be customized under the option.  However, to get intellisense support, it requires client emitters provide custom configuration options following this Emitters | TypeSpec.   The required options under different language refer to the sample file
Csharp

Python

Java

TS/JavaScript

Go

Checklist

[x] Follow our Code of Conduct
[x] Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
[x] Read the docs.
[x] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

@josefree Does this occur even when the client emitters are actually installed? Note that the client emitters are not included in the package.json in the azure-rest-api-specs repo.  The standard mechanism for this is for libraries to provide config schema,  without these libraries installed, it would mean that we would need some other mechanism for looking up config schema.

@markcowl hi Mark, you are right.  I didn't install the client emitter libraires.  Now I installed the following libraries:

"dependencies": {
"@azure-tools/typespec-client-generator-core": "^0.48.1",
"@azure-tools/typespec-csharp": "^0.2.0-beta.20241113.1",
"@azure-tools/typespec-go": "^0.3.2",
"@azure-tools/typespec-java": "^0.24.0",
"@azure-tools/typespec-python": "^0.36.3",
"@azure-tools/typespec-ts": "^0.34.0"
}

After installation, there are still some gaps.
For .NET - list only 1 parameter

For Java - seems to be fine. Further requirement - can necessary parameters be highlighted or list at the top? currently it is listed in alphabetical order

For JavaScript - Comparing with the sample file, "package-dir" "package-name" are not in the list. Further requirement - can necessary parameters be highlighted or list at the top? currently it is listed in alphabetical order. And comparing with other language, only JavaScript is using cameral case for parameter names, can be updated for consistency?

For Go - Comparing with the sample file, seems a lot missing

For Python - Comparing with the sample file, seems a lot missing


Add example Dockerfile

This is an example Dockerfile that I've used to deploy my own mirror. I reckon others would find it useful as well.
Related: https://github.com/postui/esm.sh/issues/73

@mashaal thanks, lgtm!


Update tegra-storage-layout-base_%.bbappend to use correct pathing

The bbappend is looking for the xml in an incorrect location. This file is present at ${D}${datadir}/l4t-storage-layout/${PARTITION_LAYOUT_TEMPLATE} and ${D}${datadir}/l4t-storage-layout/${PARTITION_LAYOUT_EXTERNAL}

@TheYoctoJester chances you can take a quick look at this? Appreciate it

Hi @rishabnayak,
I already had a peek, but a few question:

how does this relate to https://github.com/mendersoftware/meta-mender-community/pull/424? Any overlap or conflict possibly?
does it unconditionally apply to all machines? Or is it maybe JP6 only?
the commit is not signed, please do so in order to merge it.

Greetz,
Josef

Signed off! I don't believe this is related to #424.
This does apply to all machines on scarthgap since the meta-tegra sources use l4t-storage-layout instead of tegraflash.

Rishab


Revert "Bring back Multiple Hadoop cluster (Robin) changes and fix Lo…"

This reverts commit dd075323c69addd9bdb178e2d1b8de999a91f028.

Pull Request Test Coverage Report for Build 5436

43 of 127 (33.86%)  changed or added relevant lines in 11 files are covered.
14 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.5%) to 41.843%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

az-hdfs-viewer/src/main/java/azkaban/viewer/hdfs/AzkabanSequenceFileReader.java
0
1
0.0%

azkaban-common/src/main/java/azkaban/jobExecutor/JavaProcessJob.java
1
2
50.0%

azkaban-common/src/main/java/azkaban/jobtype/JobTypePluginSet.java
3
4
75.0%

az-hadoop-jobtype-plugin/src/main/java/azkaban/jobtype/HadoopProxy.java
0
4
0.0%

az-hdfs-viewer/src/main/java/azkaban/viewer/hdfs/HdfsBrowserServlet.java
0
9
0.0%

az-reportal/src/main/java/azkaban/viewer/reportal/ReportalServlet.java
0
9
0.0%

azkaban-common/src/main/java/azkaban/jobtype/JobTypeManager.java
37
50
74.0%

az-hadoop-jobtype-plugin/src/main/java/azkaban/jobtype/HadoopJobUtils.java
0
17
0.0%

azkaban-hadoop-security-plugin/src/main/java/azkaban/security/HadoopSecurityManager_H_2_0.java
0
29
0.0%

Files with Coverage Reduction
New Missed Lines
%

az-hdfs-viewer/src/main/java/azkaban/viewer/hdfs/HdfsBrowserServlet.java
1
0%

azkaban-common/src/main/java/azkaban/user/UserUtils.java
1
74.19%

az-reportal/src/main/java/azkaban/viewer/reportal/ReportalServlet.java
1
0%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
2
52.58%

azkaban-common/src/main/java/azkaban/jobtype/JobTypeManagerException.java
2
0%

azkaban-hadoop-security-plugin/src/main/java/azkaban/security/HadoopSecurityManager_H_2_0.java
2
0%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
5
77.1%

Totals

Change from base Build 5435:
-0.5%

Covered Lines:
13948

Relevant Lines:
33334

💛  - Coveralls


Remove 'managed' property from AvSet.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

https://github.com/Azure/azure-sdk-for-net/pull/3252

No modification for Python

 https://github.com/Azure/azure-sdk-for-ruby/pull/789

 https://github.com/Azure/azure-sdk-for-node/pull/2180


Some sensors are unavailable

Some sensors are unavailable.
Ariston genus one with bch.

Due to war in my country I do not plan to invest my time in this for now

Stay safe!

  Some sensors are unavailable. Ariston genus one with bch.

Happy to help from here, but you need to describe a little bit more your problem. I'm using the integration with no problems at all, and it's code hasn't change since December 2021. So maybe your problem is only on your side or maybe caused by a disruption in the Ariston servers.
Try to check restarting your server and also checking the webpage/app of Ariston.

Hi! Thanks for your support! I'm currently investigating by adding sensor by sensor in ariston.yaml file. So far I found that:
sensor.ariston_dhw_time_program
is causing this error:
<custom_components.ariston.ariston.AristonHandler object at 0x7faee9f6a0> _get_dhw Problem reading data: HTTPSConnectionPool(host='www.ariston-net.remotethermo.com', port=443): Read timed out. (read timeout=10.0)
ch_fixed_temperature:
is causing this error:
<custom_components.ariston.ariston.AristonHandler object at 0x7f9d6cb880> Unsupported sensors detected: {'ch_fixed_temperature'}, disable corresponding binary_sensors/sensors/switches in the configuration

First of all have in mind what the documentation says:
https://github.com/chomupashchuk/ariston-remotethermo-home-assistant-v2#selectors
-> Some parameters are not supported on all models
And then look for them in the ariston web page, if the web page do not show this information it will likely not be available. Also instead of trying to have them all, only retrive what you like to display or interact with

sensor.ariston_dhw_time_program
is causing this error:
<custom_components.ariston.ariston.AristonHandler object at 0x7faee9f6a0> _get_dhw Problem reading data: HTTPSConnectionPool(host='www.ariston-net.remotethermo.com', port=443): Read timed out. (read timeout=10.0)
I didn't foung this one on the listed sensors

ch_fixed_temperature:
is causing this error:
<custom_components.ariston.ariston.AristonHandler object at 0x7f9d6cb880> Unsupported sensors detected: {'ch_fixed_temperature'}, disable corresponding binary_sensors/sensors/switches in the configuration
Looks like it is unsupported by your system.

These sensors were available on my system. My motherboard was replaced and now I have this problem.
ch_fixed_temperature used to work on my system as well.

dhw_time_program - I have programs schedules for DHW set. But this is not so important, it is just for viewing. The problem is that ch_fixed_temperature is not available, I think ariston might remove those settings. Not sure yet. I used this option quite a lot.

Looks like it was removed...

Looks like it was removed...

Somehow moved I will say, for me stays on 'position'. Looks like its a change for your type of boiler from Ariston:

You could try to change the menu value just for your installation by changing the line 380 of the file ariston.py that will be located on your config directory config/custom_components/ariston/ariston.py:
from
_ARISTON_CH_FIXED_TEMP = "U6_3_0_1"
to
_ARISTON_CH_FIXED_TEMP = "U6_3_0_0"

Thanks. I think this is not this parameter. I'm talking about heating curve shift which can be moved from -7C to +7C.

Thanks. I think this is not this parameter. I'm talking about heating curve shift which can be moved from -7C to +7C.

In my installation the parameter "U6_3_0_1" showed on the menu does what you said, moving from -7C to +7C. But I have the menu elements 1,3 & 5 and you 0, 2 & 4, that seems to have different values. I don't have any documentation from Ariston on those items.
If you don't have it on the Ariston Web page menu, or has a different function, seems like you are not going to have it using this integration (as it only takes the value from the web) :( .

Looks like it is fixed now. I suppose ariston made some changes. I have now option 6 3 0 1 and it works in range from -7 to 7. Maybe motherboard replacemnt affected it, not sure. Anyway, thanks a lot for your support.


New version: Microsoft.OneDrive version 24.221.1103.0003

Created by 🥟 Dumplings in workflow run #9908.

Log
Updated: 24.216.1027.0003 → 24.221.1103.0003
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@stephengillie Need manual validation


Add ability for one boss to summon multiple minions

like a super strong zombie with its smaller zombie minions and a little side dish of skeleton escorts, or an enderman assassin who spawns with both endermite and silverfish underlings. Is pretty cool, is all.

This is a pretty sweet idea. I will look into this after I update the mod to 1.14. I am currently working through Prefab since that is my largest mod.

Update: This is being worked on with my next big update.
This is being done for 1.12.

Forgot to close this.
This was done back in July with the 1.2 release.


Allow Arbitrary additions to ModuleData

Foundry VTT Version
v9, v10
Related Poblem
The addition of an api property in a module's ModuleData for saving related functions seems to become more commonplace (DevMode is a good example). It'd be a very handy addition to allow the types to accomodate for this.
Desired Solution
We could possibly use declaration merging, similar to the FlagConfig, which would enable convenient IntelliSense usage.
Alternative
No response
Additional Context
No response

I've got something cooking on this, so I'm going to take it up. Will publish a draft PR shortly with what I have because it's late af here. Not happy with some bits but it's a matter of picking which poison I like.


Option to change server port

Is there an option to change the server port? I can't find the doc for it.
I already have stuff running on 3000, 3300, 8080, 8000, 8888, 8088. :)
Thank you

--port 9999
-p 9999
Arguments work

@Extarys When you execute dizqueTV from the command-line, you can change the port.  Here's an example using the Windows executable:
dizquetv-win-x64.exe --port 5115 --database D:\dizquetv.dizquetv
Does this answer your question?  Also, feel free to post support questions in the dizqueTV Discord "general-support" channel or a channel custom to your platform.

:facepalm: Why I didn't think of that.... ARGH
Thank you VERY much! Very excited to try this with Jellyfin! <3


start adding par_iter

@lolpro11 thank you, a 30% time reduction with two lines of codes is a very nice improvement.
@TeXitoi thank you for this parallelization ;)

par_iter is not well optimized, sure it can be improved.

I agree 100%, but it's a start


Try to fixed the CI error caused by the old openai cassettes

Description

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make unit-testing and make integration-testing successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.45%. Comparing base (34830a7) to head (78d6bdf).
Report is 1484 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1820       +/-   ##
===========================================
- Coverage   80.33%   66.45%   -13.89%
===========================================
  Files          95      125       +30
  Lines        6602     9023     +2421
===========================================
+ Hits         5304     5996      +692
- Misses       1298     3027     +1729

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks!


Error seeds

yuran@REANIMATOR c:\OpenServer\domains\bbbb
$ php artisan migrate:refresh --seed
Migration table not found.
Migration table created successfully.
Migrated: 2014_09_01_014904_create_images_table
Migrated: 2014_10_11_015137_create_addresses_table
Migrated: 2014_10_12_000000_create_users_table
Migrated: 2014_10_12_000001_create_readers_table
Migrated: 2014_10_12_100000_create_password_resets_table
Migrated: 2016_10_01_014152_create_categories_table
Migrated: 2016_10_01_014203_create_keywords_table
Migrated: 2016_10_01_014543_create_articles_table
Migrated: 2016_10_01_014930_create_comments_table
Migrated: 2016_10_01_014944_create_pages_table
Migrated: 2016_10_01_014952_create_assets_table
Migrated: 2016_10_01_015118_create_email_logs_table
Migrated: 2016_10_03_014544_create_article_image_table
Migrated: 2016_10_03_190244_create_article_keyword_table
Migrated: 2016_12_24_171919_entrust_setup_tables
[BadMethodCallException]
This cache store does not support tagging.
Tables "users", "role_user", "permission_role", "permissions" and some others - empty.
Probably because of this error:
[BadMethodCallException]
This cache store does not support tagging.

In your .env file change the CACHE_DRIVER to array like below:
CACHE_DRIVER=array

[BadMethodCallException]
This cache store does not support tagging.
In my .env file I tried so:CACHE_DRIVER=array
also try so: CACHE_DRIVER=file
The error still persists:
$ php artisan migrate:refresh --seed
Migration table not found.
Migration table created successfully.
Migrated: 2014_09_01_014904_create_images_table
Migrated: 2014_10_11_015137_create_addresses_table
Migrated: 2014_10_12_000000_create_users_table
Migrated: 2014_10_12_000001_create_readers_table
Migrated: 2014_10_12_100000_create_password_resets_table
Migrated: 2016_10_01_014152_create_categories_table
Migrated: 2016_10_01_014203_create_keywords_table
Migrated: 2016_10_01_014543_create_articles_table
Migrated: 2016_10_01_014930_create_comments_table
Migrated: 2016_10_01_014944_create_pages_table
Migrated: 2016_10_01_014952_create_assets_table
Migrated: 2016_10_01_015118_create_email_logs_table
Migrated: 2016_10_03_014544_create_article_image_table
Migrated: 2016_10_03_190244_create_article_keyword_table
Migrated: 2016_12_24_171919_entrust_setup_tables
Migrated: 2017_01_05_183023_create_jobs_table
[BadMethodCallException]
This cache store does not support tagging.


Update index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @nandakishore26587, thank you for the PR! However, I have to close it as it does not conform with our Style Guide.
Feel free to open a new one. Happy coding!


using latest version of minimap2 with pbmm2

Operating system
Linux
Package name
pbmm2
Conda environment
N/A
Describe the bug
Minimap2 has come up with major updates in recet times. However, it seems that pbmm2 still uses an older version of minimap2. How can we go ahead to use the latest version of minimap2 along with its wrapper pbmm2?
Error message
N/A
To Reproduce
N/A
Expected behavior
N/A

We are targeting a mm2 update this year. It has to be done in coordination with downstream retrainings, like DeepVariant, to ensure a smooth end to end experience. I'll close this issue as it's already scheduled internally.


[Alarms & Timers] New UI

Discussion here: http://forum.espruino.com/conversations/375582/, PR opened for a feedback :-)

In this PR the default Alarms & Timers app has been heavily improved:

Simpler main menu
New labels for alarms and timer (with localized days of week)
New "Repeat Alarm" menu with shortcuts (Once, Workdays, Weekends, Every Day, Custom)
New icons
Cleaner code

This PR also introduce the new time_utils module. Some functions have been moved from sched to it. This PR also update the dependent app.
The PR is 90% complete. Now I need to update the README and add some screenshots to the metadata.json.
You can try it in advance from by App Loader: https://alessandrococco.github.io/BangleApps/ (you need to install the Alarms & Timers app and the Scheduler library).

Looks great to me! Let me know when you're happy to merge :)

Done! 🎉

Great - thanks for all your work on this!


delimited sets not aggergating with meta-ordered values

Delimited set variables are aggregating with their index in numeric order rather than the order indicated by the meta. This appears to be a (problem-)correction of alpha-numeric sorting that results from the index initially being of type object.

Resolved by #306.


Trying to create service for the ingress rule with existing rule.

Rancher versions:
rancher/server or rancher/rancher: v2.0.3
rancher/agent or rancher/rancher-agent: N/A
Steps to Reproduce:

Create a workload(nginx) with a cluster ip port mapping (80 -> 80) and Rancher will create a service with the same name as the workload.
Create the ingress with the service(not workload) which created in step 1.

Results:
See the logs in Rancher container, it will be like this
2018/06/25 16:17:42 [INFO] Creating NodePort service nginx for ingress default/test, port 80
2018/06/25 16:17:42 [ERROR] IngressController default/test [ingressWorkloadController] failed with : services "nginx" already exists
2018/06/25 16:17:58 [INFO] Creating NodePort service nginx for ingress default/test, port 80
2018/06/25 16:17:58 [ERROR] IngressController default/test [ingressWorkloadController] failed with : services "nginx" already exists
2018/06/25 16:18:07 [INFO] Creating NodePort service nginx for ingress default/test, port 80
2018/06/25 16:18:07 [ERROR] IngressController default/test [ingressWorkloadController] failed with : services "nginx" already exists
2018/06/25 16:18:30 [INFO] Creating NodePort service nginx for ingress default/test, port 80
2018/06/25 16:18:30 [ERROR] IngressController default/test [ingressWorkloadController] failed with : services "nginx" already exists

Master 6/29/18
Reproduced in 2.0.3. Ran scenario in new master build. Service creation is not seen.


WIP input view component DS-13

Initial interface for an input component.
Would love your thoughts on:

making the FormField component usage transparent to the consumer (don't want them to have to explicitly use it especially as not using it means you can't see the error message)
making type required and not providing a default value of text (want people to think about what inputs they are creating more (eg email, search, number etc) and not just make everything a text field
not validating type (although there are only c. 20 so I could still do this)

making the FormField component usage transparent to the consumer (don't want them to have to explicitly use it especially as not using it means you can't see the error message)

Not sure if you managed to dig out my original experiment but I ended up doing pretty much the same thing https://github.com/citizensadvice/design-system/pull/594/files#diff-2ef4cdb27ad70e8c2ea7a8d5e692f658b6161bc411862b7c0a646acc248b8581 so that pattern makes sense to me. It should be there if you need it, but otherwise transparent to the consumer.
The other thing I tried in there which might still be useful is the BaseInputComponent. Which helped with the fact that input and textarea are basically the same.

No idea on JS though

I was about to ask "What JS??" and then realised it's the storybook docs 😆. It all looks right to me!


Add v6.0 Package Badges to H1 & Lower

Indicates the subscription plan required for a given feature.

This PR primarily adds plan and deployment badges to most product documentation pages, and secondarily applies various cleanup efforts and link fixes for consistency and clarity. This is a large PR which will likely be easier to review using the preview link above. Badge reviews need to be comprehensive to ensure content accuracy.
Notes:

The About section of the product documentation is out of scope for this PR since that section of docs is being reviewed/updated through other PRs.
MD-formatted files that need plan or deployment badges must first be converted to RST. This work is being done in a separate PR.

@esethna - Do you have an example page where you're seeing broken badge links?

@cwarnermm http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/5039/messaging/about-teams-channels-messages.html

@cwarnermm badge links are leading to https://mattermost.com/deploy which doesn't exist it seems

@esethna - AHA! Apologies for initially mis-understanding your question. Yes - all badge links will take users to brand new web pages on the mm.com site that aren't yet live. That's why all badge links don't actually appear to be working.

Mattermost Administration > Cloud Admin > Workplace Administration > Data Retention is missing the "Enterprise" tag

Mattermost Administration > Cloud Admin > Workplace Set Up and Configuration > AD/LDAP Groups is missing the "Enterprise" tag

Thanks, @wiersgallak! The latest preview is building now and will have a timestamp of today when available.

http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/5039/onboard/advanced-permissions.html#read-only-channels  - this is available in Professional as well as Enterprise

http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/5039/manage/mmctl-command-line-tool.html#mmctl-group - This should be Enterprise not all Plans.

http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/5039/manage/mmctl-command-line-tool.html#mmctl-saml This should be "Professional & Enterprise" not "All Plans"


Upgrade steps?

What are the appropriate upgrade steps?
I have a site using what looks like v1.2. is the only way to upgrade to manually checkout each version and diff the config along the way?

If you are running abridge as a submodule then you can update it:
git submodule update --init --recursive
git submodule update --remote --merge

You should diff the config for the changes, which is exactly what I do when I update.
Check config.toml as well as the overrides in the copy to root sass folder:
https://github.com/Jieiku/abridge/blob/master/config.toml
https://github.com/Jieiku/abridge/tree/master/COPY-TO-ROOT-SASS
The abridge.css demo using abridge as a demo, and I recently update it to latest here:
https://github.com/Jieiku/abridge.css/commit/6cbf633b49e0938e2c15be123c026dfd025c31ab

You should diff the config for the changes, which is exactly what I do when I update. Check config.toml as well as the overrides in the copy to root sass folder:
https://github.com/Jieiku/abridge/blob/master/config.toml
https://github.com/Jieiku/abridge/tree/master/COPY-TO-ROOT-SASS

That is what I thought, thank you!


Some time is not available.

Hi @stas-demydiuk !
In the domoticz log communication is visible.
However the switches do not work.
The domoticz Ewpesmart Air Conditionets hardware turn off.
Thereafter.
The domoticz Ewpesmart Air Conditionets hardware turn on.
All functions work.
It takes a few hours.
Does not respond.
And then if again. I turn it off. I turn it on. All functions work.

Hi,
Domoticz plugin works until reboot. When rebooted I start javascript with forever or npm but Domoticz plugin does not work anymore. What I need to do is to remove plugin from Domoticz and add it again. Then it works until next reboot. I suppose there are problems with communication between MQQT server and Domoticz plugin.

@vapor11 could you please check if Domoticz with plugin starts after npm script

@Macelek please reopen the issue if it is still valid


add support for simple srs

bbox in simple coordinates and srs = "simple".  Similar to image coordinates, but yscale is +

done


Improve GitLab CI

A couple of improvements:

Don't run for pull requests (that doesn't work anyway)
Name the master branch executable according to the branch hash to avoid it being deleted when another pipeline is running simultaneously
Import the benchmark results back to GitHub, see https://github.com/masterleinad/ArborX/runs/743442620?check_suite_focus=true.

This relies on the changes in https://github.com/masterleinad/gitlab-mirror-and-ci-action/tree/get_final_artifacts. I would update master if we find this acceptable as is.

I cleaned this up.

Hmm, so if you remove [pull] from it, the Gitlab CI check does not show in the pull request itself, and one has to go to your repo or Gitlab.

Hmm, so if you remove [pull] from it, the Gitlab CI check does not show in the pull request itself, and one has to go to your repo or Gitlab.

Which is the same as before, isn't it? The check in the pull request never printed anything useful.

This looks fine. Does it work?

The output is in https://github.com/masterleinad/ArborX/runs/751597373?check_suite_focus=true.

Which is the same as before, isn't it? The check in the pull request never printed anything useful.

The difference is that we saw GitLab CI check ran, and could get a pipeline id from it. This is not to say that you should change it back, just pointing this out.

The difference is that we saw GitLab CI check ran, and could get a pipeline id from it

AFAIK, you could only get a valid pipeline id from the check in the branch in the fork but not from the check in the pull request.


[DOCFIX] Update checkstyle pr build check

update the check-docs as well

alluxio-bot, merge this please


Packs bounce buffers for highly partitioned shuffles

Signed-off-by: Alessandro Bellina<EMAIL_ADDRESS>I affectionately refer to this as the "delivery truck packing" PR.
Before this change:

Given a set of requests for a peer, we'd get a bounce buffer and put a single batch in this bounce buffer for the transmission. A process which we'd have to repeat per batch (contig buffer). This means if we have small batches, we run out of bounce buffers quickly, synchronize many times, and we call into the transport many times. This is akin to us getting many delivery orders, finding a big truck, and sending the truck many times round trip with a single package.

After this change:

We use the WindowedBlockIterator to copy into and out of a bounce buffer, packing the bounce buffer with many batches in the highly partitioned case. This means we reduce the calls to the transport, synchronize less (at the bounce buffer granularity), and we send bigger buffers that the transport can more efficiently transmit. This is akin to us getting that big delivery truck, but packing it fully with as many packages as they would fit, and sending it far less times in the highly contended highway.

A big change is how tags work in this PR. Since a send/recv can have many batches, only the tag for the first batch is taken into account. This is a convention that the server and client follow.

@jlowe ok I am not sure I have feedback I haven't addressed. I had a couple of cases where I had a comment back to you, but the rest was fairly straightforward changes I implemented + a couple of follow up issues. Thanks again for the thorough review.

build

I have leftover work on this code around error handling. @jlowe and I agree we can do in a separate PR. I am working on that PR while this review continues.

build


unc0ver 3.5.6 cannot be opened in iOS 12.4 on iphone 6s / iphone 8

Describe the bug
unc0ver app will exit/terminate immediately after launch.
After pressing on the app icon, the background of the UI would show up for less than a second. The app would be closed before any other elements show up.
After the app is closed, double tap home button to the App Switcher view, App Switcher shows the background image of the unc0ver app but with no other UI elements.
unc0ver was installed via the latest cydia impactor.
No pending iOS update was in the storage.
App was verified in Settings before opened.
Device (please complete the following information):

iOS Version: 12.4
iOS Device: iPhone 6s, iPhone 8
unc0ver Version: 3.5.6

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
No error log showed up during using the cydia impactor or opening up the app.
PS:
iOS 12.4 on iPhone 6s was already JB,
iOS 12.4 on iPhone 8 was not JB yet.

I have this issue too, but with Undecimus v3.5.2 too, especially after upgrading Cydia Installer, mobile substrate and everything in "changes" cydia tab. Now my jailbreak is non-functional...

Fixed. You have to install using Tweakbox or even better - www.unc0ver.dev via ota method.
Alternatively, wait for updated Impactor.


Add more tests

There are still some functions not covered by tests.

We should also have coverage reports and browser tests.


Can you please tag a new release?

Builds break all the time because dep automatically selects the release from 2016.

Done! https://github.com/Unknwon/com/releases

Thank you!


TOC: section tile with formatting

When a section title has some code formatting the tile is truncated.
for example a markdown cell containing
# Group `photon_data`

will result in a TOC showing only "Group"

We remove children here:
  var make_link = function (h) {
    var a = $("<a/>");
    a.attr("href", '#' + h.attr('id'));
    // get the text *excluding* the link text, whatever it may be
    var hclone = h.clone();
    hclone.children().remove(); // <- here...
    a.text(hclone.text());
    return a;
  };

I've no clue why this in the code (is there an anchor?). @tritemio Could you try that in your local installation if that works as you want it?

It seems that an anchor is automatically build from titles and inserted. The .remove() removes this anchor (an the linked text which is a carriage return). But so doing removes all children, including all html formatting. In my attempts
hclone.children().last().remove();
which only removes the last child seems to work. Can you check from your side?

What you propose works for me. Want to do a PR?

@jfbercher nevermind, thought you were the original poster... PR incoming... :-)

No problem.


Investigate failing tests that use Roslyn

The tests that compile code are failing on machines with both VS 2015 and VS 2017. They were disabled in 33bf2453f39f8328ef9f0c64ca4f547b0f2e4ee4, but we should investigate the issue and re-enable them. The issue may also go away when we stop using the 4.4.0 contracts.

Any workaround I can use for now?

Test on a machine with only VS 2017. 😄 I also had a hunch that upgrading the test projects to net46 might fix the issue.

It seems there's other issues when upgrading tests to net46 (I also changed all #if NET452 in the test folder to #if NET46). I'll leave the error message here for reference:
Test 'M:Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.SqlOperation_required_args' failed:
	Could not load file or assembly 'System.Reflection.Metadata, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
	System.IO.FileLoadException: Could not load file or assembly 'System.Reflection.Metadata, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
	File name: 'System.Reflection.Metadata, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
	at Microsoft.CodeAnalysis.MetadataReference.CreateFromFile(String path, MetadataReferenceProperties properties, DocumentationProvider documentation)
	at Microsoft.EntityFrameworkCore.Relational.Design.Specification.Tests.TestUtilities.BuildReference.ByName(String name, Boolean copyLocal)
	at Microsoft.EntityFrameworkCore.Relational.Design.Specification.Tests.TestUtilities.BuildSource..ctor()
	C:\Repos\EntityFramework\test\Microsoft.EntityFrameworkCore.Design.Tests\Migrations\Design\CSharpMigrationOperationGeneratorTest.cs(1982,0): at Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.Test[T](T operation, String expectedCode, Action`1 assert)
	C:\Repos\EntityFramework\test\Microsoft.EntityFrameworkCore.Design.Tests\Migrations\Design\CSharpMigrationOperationGeneratorTest.cs(1934,0): at Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.SqlOperation_required_args()

I'll uninstall VS 2015 and hope for the best.

So far this didn't work:

Uninstalling VS 2015
Reinstalling VS 2017
Changing binding redirect to newVersion=<IP_ADDRESS> in C:\Users\{user}\AppData\Local\Microsoft\VisualStudio\{version}\devenv.exe.config and C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe.config

Might be able to add some binding redirects to the test projects (xUnit.net picks them up even though tests are DLLs)

I just:

Installed a fresh Windows 10 copy
Installed VS 2017
Installed TestDriven.Net
Ran the SqlOperation_required_args test

I got:
------ Test started: Assembly: Microsoft.EntityFrameworkCore.Design.Tests.dll ------

Test 'Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.SqlOperation_required_args' failed:
	System.IO.FileLoadException : Could not load file or assembly 'System.Collections.Immutable, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
	at Microsoft.EntityFrameworkCore.Relational.Design.Specification.Tests.TestUtilities.BuildReference.ByName(String name, Boolean copyLocal)
	at Microsoft.EntityFrameworkCore.Relational.Design.Specification.Tests.TestUtilities.BuildSource..ctor()
	D:\Repos\EntityFramework\test\Microsoft.EntityFrameworkCore.Design.Tests\Migrations\Design\CSharpMigrationOperationGeneratorTest.cs(1951,0): at Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.Test[T](T operation, String expectedCode, Action`1 assert)
	D:\Repos\EntityFramework\test\Microsoft.EntityFrameworkCore.Design.Tests\Migrations\Design\CSharpMigrationOperationGeneratorTest.cs(1934,0): at Microsoft.EntityFrameworkCore.Design.Tests.Migrations.Design.CSharpMigrationOperationGeneratorTest.SqlOperation_required_args()

0 passed, 1 failed, 0 skipped, took 2.53 seconds (xUnit.net 2.2.0 build 3545).

I'm going to take a look at fixing this because it's blocking me :(

That one can be fixed with a binding redirect to the right version.

I'll look into this issue next. There are a lot of pieces in play here. It's not going to be fun getting to the bottom of it.

It's working now with a binding redirect to <IP_ADDRESS> (and not <IP_ADDRESS>, which still breaks!). This is the App.config file I had to put at the root of the test project folder:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <runtime>
    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" culture="neutral"/>
        <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>"/>
      </dependentAssembly>
    </assemblyBinding>
  </runtime>
</configuration>

Should I do this for every test project with this problem and send a PR enabling tests, or do you want to look for a better solution?

For me, that only fixed the problem on VS2017-only machines. I'll keep looking for a full fix. But at least you can run them locally now. I have a branch with the updated test too.

Thanks :D
On Wed, Mar 1, 2017, 20:06 Brice Lambson<EMAIL_ADDRESS>wrote:

For me, that only fixed the problem on VS2017-only machines. I'll keep
looking for a full fix. But at least you can run them locally now. I have a
branch with the updated test too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/EntityFramework/issues/7620#issuecomment-283550560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9Io95_5RkxQtvo4aqcOFyjQ3FNY5ks5rhkBOgaJpZM4MCLIO
.

Got to the bottom of it. Binding redirects aren't generated for DLLs. I'll have a fix out soon.


show whole variable declaration

Hello,
is it possible to show the whole variable declaration within the tooltip instead of just the first line?
Example:

Depends on https://github.com/Microsoft/tolerant-php-parser/issues/138
cc @roblourens

What's the expected result? I don't think we should show everything passed to array. TS shows the variable name with type annotation.

@roblourens Here's a nice example from Go:

I remember that being able to see the struct contents was a very highly requested feature in Go

Is that from a sourcegraph extension to the LSP?

No, it just uses 3 hover contents: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textDocument_hover


Cannot make changes to Notification summary

Hi team,
I have been trying to make changes to the notification summary referring the below blog:
https://techcommunity.microsoft.com/t5/iis-support-blog/how-to-change-notification-text-when-bot-sends-an-adaptive-card/ba-p/1945008
but the changes are not reflecting.
Can you please look into it?

Hi @riddhichaplot ,
We won't support for customization of the Company Communicator app. Please proceed on your own.

Hi @riddhichaplot,
We are closing the issue request as we don't provide support for customization.
However, we have noted down your suggestion for the modification related to the Adaptive card and will be adding it to our backlog for internal review and future releases.
Also, please do reach out to us if you face any issues with the functionality or deployment of the Company Communicator.


Add Guzzle 7.0 support

@Elendev I confirmed this works by publishing after I upgraded to guzzle 7

Hi @tm1000, thank you for your PR!
I just realized GH Actions weren't executing on pull requests, I changed a setting on the workflow and added the pull_request trigger. Can you update your

Hi again @tm1000, I released the 0.2.2 with Guzzle 7 support.
Thanks for the contribution!
Cheers


Where can i find documentation for historical versions?

I want to use Chart.js in IE9 but now it only supports IE 11+.
I remembered that the old versions (i.e. 2.5.0) supports IE 9+, but the links always pointed to the latest documentation. So where can I find documentation for historical versions?
I searched the issues but did not get an answer. Thanks.

I think you would have to look in the source history or on archive.org. As far as I know, we don't publish docs for old versions

@fengzhenqiong old docs are hosted on chartjs.org. For example, v2.7.0 docs are available at https://www.chartjs.org/docs/2.7.0/

However, there is no selector between versions. @benmccann not sure how hard that is to add on a static site using github pages.

Ah. They don't go back before 2.6.0 though, so it probably won't help for 2.5.0

https://web.archive.org/web/20170119203850/http://www.chartjs.org/docs/


Remove netci.groovy now that we have azure devops ci

cc: @ahsonkhan @chcosta

@dotnet-bot test ci please

I guess once this is merged, the jobs shouldn't appear in consequent PRs?

Where's the CI job Gen CI(dotnet-ci) - master/netci.groovy coming from?

From my @dotnet-bot test ci please comment. But it failed as expected since it didn't find the file.


Insufficient material rule

Moving towards #63

Current coverage is 60.67%

Merging #82 into master will decrease coverage by -1.80% as of 41d8606

@@            master     #82   diff @@
======================================
  Files           49      50     +1
  Stmts          946     974    +28
  Branches       159     165     +6
  Methods          0       0
======================================
  Hit            591     591
  Partial         33      33
- Missed         322     350    +28

Review entire Coverage Diff as of 41d8606

Powered by Codecov. Updated on successful CI builds.


Tweak issues labels

Some of our issue labels could be a bit clearer.
ACs

[ ] The definition for impact/high is revised to clarify when it should be applied to an enhancement.
[ ] Clarify impact/low and impact/medium as it relates to enhancements
[ ] type/frontend and type/ux are combined.
[ ] Validate if there's a need for feedback-required/core-team and feedback-required/author.
[ ] Current impact/high issues are reassess.
[ ] Consider renaming effort label to complexity.
[ ] Update existing tag repos accordingly.

Notes
Consider creating or updating label sync script. @chillu had magical script to do that somewhere.
The impact descriptions for enhancements need to be tweaked:
https://docs.silverstripe.org/en/4/contributing/code/#labels
Guy Sartorelli, talking about the impact labels:

For low and medium, they're entirely bug-focused. Following these descriptions strictly, there is no way to put these labels on an enhancement.For high, "clear benefit" is too vague, and the word "typically" should be removed entirely."
(we should) Describe what kind of enhancement is a "low" or "medium" impact, the same way "high" impact has some indication of the value it would provide.e.g. for low, it could be something like "an enhancement that supports an edge case or is otherwise applicable to a low percentage of users, or which is unlikely to significantly improve the developer or user experience"
The word "significantly" there may not be appropriate, depending on the descriptions for high and medium
I think the key parts are that the description should talk about how many people are likely to benefit, as well as how beneficial it is likely to be (i.e. many people may use the new feature, but would maybe not much care if it wasn't there)

@chillu had magical script to do that somewhere.

Hmm, probably still on github.com/silverstripeltd? Look for "github" or "label" in the repo name?

It's a Cow feature:
https://github.com/silverstripe/cow/blob/master/src/Commands/GitHub/SyncLabels.php

Cheers for linking the SyncLabels command.
However I think we'll need a new script since as we're combining type/frontend and type/ux, also maybetype/docs and type/userhelp, and a few other things that require a bit of finesse
I've just done a bit of looking at the github API and the following endpoints will be helpful, along with an explanation of what they'll be used for
List labels
There's a bunch of straggler labels are the place like 'affects/mobile' and 'dependencies' that should just be deleted, though first we need to identify what repos have what labels
https://docs.github.com/en/rest/issues/labels#list-labels-for-a-repository
Delete labels
There's a bunch of labels we'll want to delete such as affects/v3
https://docs.github.com/en/rest/issues/labels#delete-a-label
Add label to issue
Will be required when combining labels, as some issues will be missing the label that we're removing as part of the combine labels operation
https://docs.github.com/en/rest/issues/labels#add-labels-to-an-issue
Edit existing labels
Use this to change effort/* labels to difficulty/* or complexity/* or experience-required/* since effort/* isn't supposed to be 'estimated work', it's the technical complexity e.g. effort/easy = Someone with limited Silverstripe CMS experience could resolve https://docs.silverstripe.org/en/4/contributing/code/#labels
https://docs.github.com/en/rest/issues/labels#update-a-label

Using this for analysis https://github.com/emteknetnz/issue-relabeller
Count of labels available to put on issues on all the silverstripe + symbiote repos
    [type/bug] => 94
    [type/enhancement] => 94
    [impact/critical] => 93
    [impact/medium] => 93
    [impact/low] => 93
    [impact/high] => 93
    [effort/medium] => 93
    [affects/v4] => 93
    [effort/hard] => 93
    [effort/easy] => 93
    [change/patch] => 93
    [change/minor] => 93
    [change/major] => 93
    [type/docs] => 91
    [feedback-required/author] => 91
    [feedback-required/core-team] => 90
    [rfc/accepted] => 90
    [rfc/draft] => 90
    [type/UX] => 90
    [affects/v3] => 90
    [type/userhelp] => 89
    [type/frontend] => 89
    [affects/v5] => 77
    [dependencies] => 28
    [Epic] => 15
    [good first issue] => 11
    [javascript] => 10
    [wontfix] => 10
    [invalid] => 9
    [question] => 9
    [duplicate] => 9
    [enhancement] => 8
    [help wanted] => 8
    [bug] => 8
    [documentation] => 6
    [affects/mobile] => 3
    [blocker] => 2
    [WIP] => 1
    [feature] => 1
    [discussion] => 1
    [v4] => 1
    [required-for-merge] => 1
    [post-release] => 1
    [api] => 1
    [hacktoberfest-accepted] => 1

Just thinking a bit more on this. I think the change/major or a similar tag should remain, so that we can tag things that will require breaking changes to implement and later filter by that tag when we want to do some work on the major.

I think change/major is redundant as it's a double-up with affects/v5
On the change/* topic, I don't think we need change/minor or change/patch simply because what branch we target depends on what APIs are changed by the implementation more than anything.  If it's a functional change without an API change then we'd just ask at peer review time to target the pull request at the next minor

affects/v5 implies it will definitely be included in the next major, as opposed to being work that cannot be done without breaking changes that might not be in the next major.

affects/v5 should be a milestone (5), not a label, it implies something else than a semver major change

I'm not sure about merging type/frontend and type/ux into one... UX is wider than just what's in the browser. Could be probably covered by something else, but something like type/ux-ui could work?
Re change/* and affects/*.. using the target branches to identify PRs might help, but if you want to tag an issue there's no PR at that point. Plus we would need to be creating new affects/6, affects/7 etc as we go with major versions. So perhaps something like affects/next-major.. not literally, but something that won't need to be updated and retagged if it doesn't make it to 5 kind of thing.

I think the affects/vx labels are intended to be used on bugs more so than features - so if a bug only affects v4 and not v5 we can make decisions about whether to fix it or close it based on whether the affected version(s) are still supported.

Maybe just get rid of the type/frontend tags entirely if we don't want it merged with type/ui?  I think the label has no value:

It seems like it was an attempt at categorizing bug types, though we only made one category? There is there no type/backend label, which I think is good because I see little value in categorization.
Often bugs that result in a broken front end are a result of something broken in the backend, and at triage time it's not clear where the problem is originating from
It's pretty much impossible to make a front-end enhancement without a correspondingly large amount of backend code to support it.

Possibly change change/major to type/api-change?

Possibly change/major could become type/api-change?

I'd be concerned about what people generally understand under the term API. For us it's the public interface/contract of the code, for some other people it might be API as in how the BE talks to the FE.
(I know I'm not offering a better alternative, so I'll keep it to a minimum.)

I think it's okay if the average developer doesn't understand the label - it's for us a lot more than it is for them. Plus we have docs that explain what all of the labels mean if they're really interested.

My updated recommendations are:
a) Rename the effort/* labels to complexity/*
b) Rename change/major to type/api-change
c) Delete the following labels:

change/patch
change/minor
feedback-required/author
feedback-required/core-team
affects/v3
type/frontend
All the various labels below DELETE LABELS BELOW THIS LINE in the comment above

Here's an example of the type/frontend label - just about all the issues already have the type/ux label on them
https://github.com/silverstripe/silverstripe-admin/issues?page=2&q=is%3Aopen+is%3Aissue+label%3Atype%2Ffrontend
@silverstripe/core-team let me know if you're OK with my recommendations

I'm generally happy with Steve's recommendation here. I would rather have a small number of tags we used consistently well rather than a larger number that we use in weird ways.
The type/frontend is mainly used to tell our front end team (which currently doesn't have any staff :cry:) that this issue is of concern to them. Fully appreciate that UX and frontend are not the same thing, but they've historically been handled by the same people. I don't see us having two dedicated teams, one for frontend and one for UX, any time soon.

Thanks for the feedback all, I'll go ahead and implement as I've recommended

I've run the script and updated all labels on ~109 repos, as defined here for the accoutns 'silverstripe', 'symbiote', and type 'regular', 'tooling'
One small change I made was using type/api-break instead of type/api-change just to clarify it that this shouldn't include API additions, which is technically a change.
The script I wrote makes the reballeling process very easy, so if there's any further changes we'd like to make it will be easy.

as defined here

Is the https://github.com/silverstripe/supported-modules list less correct? (if so we should looks at updating it or archiving that repo but that's a whole other discussion)

I think supported-modules is correct, the list I'm using is expanded on that list though and includes things like silverstripe/MinkFacebookWebDriver

@silverstripe/core-team I've created a PR with recommended definition changes to the issue labels.
Other than the stuff that needs to happen (updating effort/* to complexity/*), the main difference is clarifying that:

impact/high only affects "major usage flow"
impact/medium basically means "workaround available" for "major usage flow" and "it's broken" for "less common usage flow"

It's a judgement call as to what constitutes a "major usage flow", though optional modules such as tagfield wouldn't qualify. In practice this means that for a lot of modules the max impact that an issue could get would be "impact/medium"
For the CMS Squad this would essentially prioritize a lot of issues of modules, which is largely the intent as this would basically raise the bar of what is considered 'impact/high'.  The intent is to makes it easier to work out what to work on next
This isn't to say we'd never look at impact/medium, though we'd be more reliant on clean and easy to merge community pull-requests.
I can see this proposal being contentious, so I'd be interested in your feedback on this


What to do with not existing properties in docs but existing in JSON schema?

There are some properties mentioned in JSON schema but missing from docs:

props
children
flat
stylingModule
postCommand
destination
tsPropsDeclaration
memo
separateIndex
reactNative

What I have to do with them? Remove?

Hi!
The JSON schema was used in older versions of Agrippa, up to v1.4, while the docs refer to Agrippa v2.0 (and will be updated whenever Agrippa is).
I highly recommend updating to Agrippa 2.0; if you can't, I can try to search for an old version of the docs (that were hosted here, on a GitHub Wiki) that might be helpful to you.
Thanks for reaching out


rbd: metadata "list" function

Light refactoring of the locations of some of the prior image metadata functions.
Add ListMetadata implementing rbd_metadata_list. The names a bit wonky (see commit msg) but I think its fine. Let me know if you think its confusing and we can discuss alternatives.
Checklist

[x] Added tests for features and functional changes
[x] Public functions and types are documented
[x] Standard formatting is applied to Go code

It appears that this weeks release of ceph nautilus is now breaking the cephfs admin test suite. Please bear with me as I investigate these failures.

@Mergifyio rebase

@mergifyio refresh

@Mergifyio rebase


Can't access the web UI

Hi,
I cloned the repo and just run the compose command:
docker-compose -f ngc.yaml up -d
Then, when trying to access the web UI via the address <IP_ADDRESS>:3000 I get the following error, which I retrieved using docker logs -f open5gs-and-ueransim_webui_1:
ubuntu@gateway:~/openverso-images/docs/open5gs-and-ueransim$ docker logs -f open5gs-and-ueransim_webui_1
> Ready on http://<IP_ADDRESS>:3000
Unhandled rejection MongoError: Unsupported OP_QUERY command: listIndexes. The client driver may require an upgrade. For more details see https://dochub.mongodb.org/core/legacy-opcode-removal
    at Function.MongoError.create (/opt/open5gs-webui/node_modules/mongoose/node_modules/mongodb-core/lib/error.js:31:11)
    at queryCallback (/opt/open5gs-webui/node_modules/mongoose/node_modules/mongodb-core/lib/cursor.js:212:36)
    at /opt/open5gs-webui/node_modules/mongoose/node_modules/mongodb-core/lib/connection/pool.js:469:18
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

Try to update the version (2.3.2 -> 2.6.4) used in the docker-compose and tell us if that fixes your problem.
BR,
Álvaro


design: Action Menu Scalability Issues...

The current action menu design isn't going to scale...

It works ok for the current pallet of built-in actions but even just watching the //build VA presentations we had to add 6 or 7 custom actions for performing graph manipulations.  What happens when my project needs 4 - 5 action libraries that add 5 - 10 new actions each?  We could end up needing to show 30 - 40 actions on the custom actions menu.
Toolbox management is a fundamental issue that all visual programming tools have to deal with. The issue is you tend to pull tools into your project in suites but your actual project may only ever use 4 - 5 controls from a given suite. Take a look at Telerik's Silverlight Library. A single library adds over 100 new controls of which you may use 10.
Looking at our UX I've been trying to figure out where we could expose a proper toolbox and I believe it's in the right pane where the property editor is.  If we look at the current UX we can end up highlighting 2 nodes in blue when you click an insert point. One represents the node represented by the property inspector and the second represents the insertion point:

My thought is we could trim down the action menu that gets displayed to be a simple list of most commonly or recently used actions. A "more" link at the bottom would dismiss the menu and then cause a toolbox panel to be displayed in the right hand pane.  This works UX wise because we would just keep the current insertion point highlighted in blue.  But now we could surface a search box and accordion for browsing actions by category. We could also support the pinning of actions to either the top of the toolbox pane or popup menu.

@carlosscastro and I have kicked around some ideas for how to use machine learning to essentially learn the 1 - 3 actions that most commonly follow a given sequence of actions. This isn't any different then learning the words to "auto suggest" in a messaging app.  Just replace the words with actions.

This is a great point.... - I'll add this to our list to look into.

Closing because it's old

@vivekkshankar I know you worked on this as well - do we have the most recent work in the build right now?


Color picker for tags & highlights

Is your feature request related to a problem? Please describe.
I am a very visual and color orientated person, and only having yellow as an option makes it difficult for me.
Describe the solution you'd like
I would love to have some sort of color picker under the highlight menu. Another possibility would be marking text or a tag and then right-click to have a context-menu.
Describe alternatives you've considered
none so far
Additional context

(From AppFlowy)

Thanks for the suggestion! A color picker for tags and highlights is a great idea, and I'll work on implementing it as soon as possible. However, we are currently focusing on the mobile app before adding any major features to the desktop version. Thank you for your understanding. I hope you'll continue to enjoy Beaver Notes as much as we do.

Hi there, Version 3.6.0 is right around the corner. As you can see, we’ve implemented colors for highlighters. However, we decided against implementing colors for tags, as it would require rewriting a core part of the application, which could potentially cause issues with existing labels. I hope the highlighter feature is helpful. I’m sorry we couldn’t fully resolve your issue. I’ll make sure to add highlighter colors to the mobile app as well. Thanks again for opening this issue, and I hope you enjoy using Beaver Notes!


Two phone buttons to choose from (not sim1 and sim2)

I downloaded the dialer app. And there is something that is wrong in my opinion. When I choose a number that I want to dial I have to choose between an orange and blue dial button at the bottom of the screen. These are not the sim1 and sim2 buttons. Should there be two buttons? If yes, what is the difference? By the way I have a OnePlus 8t smartphone with last software update (Oxygen 13. 0). Jacob.

what blue and orange? It should be the 2 SIMs.

Hi, thanks for your message. I sent you two screenshots. In the first screenshot you see sim1 and sim2 before choosing/entering a phone number. Sim1 is chosen. After choosing/entering a phone number I get the screen on the second screenshot with the blue and orange icon. The effect of both buttons is making a sim1 call. So why is there a blue and orange icon? Should they be there on that place? Jacob.
Verzonden met Proton Mail mobiel
-------- Oorspronkelijk bericht --------
Op 11 mrt. 2023 10:53, schreef Tibor Kaputa :

what blue and orange? It should be the 2 SIMs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I dont see any screenshots

No screenshots? I attached two files. I will attached once again.
Verzonden met Proton Mail mobiel
-------- Oorspronkelijk bericht --------
Op 11 mrt. 2023 12:50, schreef Tibor Kaputa :
I dont see any screenshots
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.￼Message ID: @.>
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "[https://github.com](https://github.com/SimpleMobileTools/simplemobiletools.github.io/issues/4#issuecomment-1464894339", "url": "[https://github.com](https://github.com/SimpleMobileTools/simplemobiletools.github.io/issues/4#issuecomment-1464894339", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

I wil try it once again with inline screenshots
[Screenshot_2023-03-11-11-11-05-15_765f8dabff0c1b40e2676405b965e035_1.jpg]
[Screenshot_2023-03-11-11-11-33-56_c31b32364ce19ca8fcd150a417ecce58.jpg]e screenshots
Verzonden met Proton Mail beveiligde e-mail.
------- Original Message -------
Op zaterdag 11 maart 2023 om 12:50 schreef Tibor Kaputa @.***>:

I dont see any screenshots
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

There are no screenshots.. Log into github and add them manually, you are replying somehow through emails that doesnt work well.

that orange and blue are 2 separate apps, you can pick which one you want to use for calling


Math-Magician Setup

In this project, I was able to:

Use the correct Gitflow principles.
Use linters.
Set up React app.

@MarkYegon7 You fixed the License link after submitting the project for review. Please make sure not to push anything after submitting a project for code review. Please go for another review, Your project will be approved.


tvdb lookup errors #2

using version 1.2.502 still getting tvdb lookup errors from
https://github.com/Flexget/Flexget/issues/995
Thanks
tv_shows        Downloading: iZombie S02E17 HDTV x264-LOL
2016-04-05 22:20 INFO     transmission  tv_shows        "iZombie S02E17 HDTV x264-LOL" torrent added to transmission
2016-04-05 22:20 ERROR    lazy_lookup   tv_shows        Unhandled error in lazy lookup plugin
2016-04-05 22:20 CRITICAL manager       tv_shows        An unexpected crash has occurred. Writing crash report to /home/pi/.flexget/crash_report.2<IP_ADDRESS>048994498.log. Please verify you are running the latest version of flexget by using "flexget -V" from CLI or by using version_checker plugin at http://flexget.com/wiki/Plugins/version_checker. You are currently using version 1.2.502
2016-04-05 22:21 ERROR    lazy_lookup   tv_shows        Unhandled error in lazy lookup plugin
2016-04-05 22:21 CRITICAL manager       tv_shows        An unexpected crash has occurred. Writing crash report to /home/pi/.flexget/crash_report.2<IP_ADDRESS>101550430.log. Please verify you are running the latest version of flexget by using "flexget -V" from CLI or by using version_checker plugin at http://flexget.com/wiki/Plugins/version_checker. You are currently using version 1.2.502
2016-04-05 22:21 ERROR    lazy_lookup   tv_shows        Unhandled error in lazy lookup plugin
2016-04-05 22:21 CRITICAL manager       tv_shows        An unexpected crash has occurred. Writing crash report to /home/pi/.flexget/crash_report.2<IP_ADDRESS>114190784.log. Please verify you are running the latest version of flexget by using "flexget -V" from CLI or by using version_checker plugin at http://flexget.com/wiki/Plugins/version_checker. You are currently using version 1.2.502
2016-04-05 22:21 ERROR    lazy_lookup   tv_shows        Unhandled error in lazy lookup plugin
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/lazy_dict.py", line 36, in __getitem__
    func(self.store)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/metainfo/thetvdb_lookup.py", line 117, in lazy_series_poster_lookup
    return self.series_lookup(entry, self.series_poster_map)
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/database.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/metainfo/thetvdb_lookup.py", line 103, in series_lookup
    session=session
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/database.py", line 27, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/api_tvdb.py", line 426, in lookup_series
    _update_search_strings(series, search=name)
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/database.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/sqlalchemy_utils.py", line 137, in __exit__
    self.commit()
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 801, in commit
    self.transaction.commit()
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 392, in commit
    self._prepare_impl()
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 372, in _prepare_impl
    self.session.flush()
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2019, in flush
    self._flush(objects)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2137, in _flush
    transaction.rollback(_capture_exception=True)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2101, in _flush
    flush_context.execute()
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/unitofwork.py", line 373, in execute
    rec.execute(self)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/unitofwork.py", line 532, in execute
    uow
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/persistence.py", line 174, in save_obj
    mapper, table, insert)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/persistence.py", line 800, in _emit_insert_statements
    execute(statement, params)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 914, in execute
    return meth(self, multiparams, params)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/elements.py", line 323, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1010, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1146, in _execute_context
    context)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1341, in _handle_dbapi_exception
    exc_info
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/compat.py", line 200, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1139, in _execute_context
    context)
  File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/default.py", line 450, in do_execute
    cursor.execute(statement, parameters)
OperationalError: (sqlite3.OperationalError) database is locked [SQL: u'INSERT INTO tvdb_search_results (search, series_id) VALUES (?, ?)'] [parameters: (u'izombie (2015)', 281470)]

I think this was fixed on 1.2.503. It was for me anyway.

@chewy74 please verify

The issue seems to be resolved after 1.2.503
Thanks