🐛 Fix DockerMachine delete for first control plane

Signed-off-by: Chuck Ha<EMAIL_ADDRESS>What this PR does / why we need it: This PR allows the deletion of the final/first control plane
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #109
Special notes for your reviewer:
Release note:
NONE

hmm I see what I've done and this is not right. Updating.

@detiber updated. Much cleaner.


Can't install games from Epic, claims Launcher is not installed

Description
Trying to install games from Epic Games Store doesn't work
Steps to reproduce
Find game from Epic Games library, click install, profit?
Screenshots

My software setup is about as scuffed as it gets, since I had to change multiple HDDs without doing a proper reinstall of anything and just hoping everything works; but I was hoping to learn where the extension checks for the Launcher's install and if I can amend it somehow

Reinstall Epic client. Epic plugin uses registry keys created by EGS setup to detect where the client is installed.
https://github.com/JosefNemec/PlayniteExtensions/blob/master/source/Libraries/EpicLibrary/EpicLauncher.cs#L42


Failure to Build a particular version (2.5.0-rc3)

Hi,
I am trying to build version 2.5.0-rc3 and Docker file looks like this
FROM tensorflow/tensorflow:devel
RUN git clone https://github.com/google/mediapipe.git /mediapipe_src
RUN git -C /tensorflow_src checkout refs/tags/v2.5.0-rc3 -b v2.5.0-rc3
COPY entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]

And added the following line in entrypoint.sh
sed -i '/":tvos_arm64": COMMON_SRCS + MACH_SRCS + MACH_ARM_SRCS,/a ":emscripten_wasm": COMMON_SRCS + EMSCRIPTEN_SRCS,' /tensorflow_src/third_party/cpuinfo/BUILD.bazel

But I am getting this error:
ERROR: Analysis of target '//:tflite' failed; build aborted: /root/.cache/bazel/_bazel_root/00533da95dbcbd49bca844bdfd8d02a4/external/XNNPACK/BUILD.bazel:4433:26: Configurable attribute "deps" doesn't match this configuration (would a default condition help?).
Conditions checked:
 @XNNPACK//:linux_k8
 @XNNPACK//:linux_arm
 @XNNPACK//:linux_armeabi
 @XNNPACK//:linux_armhf
 @XNNPACK//:linux_armv7a
 @XNNPACK//:linux_aarch64
 @XNNPACK//:macos_x86_64
 @XNNPACK//:macos_arm64
 @XNNPACK//:windows_x86_64_clang
 @XNNPACK//:windows_x86_64_mingw
 @XNNPACK//:windows_x86_64_msys
 @XNNPACK//:windows_x86_64
 @XNNPACK//:android_armv7
 @XNNPACK//:android_arm64
 @XNNPACK//:android_x86
 @XNNPACK//:android_x86_64
 @XNNPACK//:ios_armv7
 @XNNPACK//:ios_arm64
 @XNNPACK//:ios_arm64e
 @XNNPACK//:ios_x86
 @XNNPACK//:ios_x86_64
 @XNNPACK//:watchos_armv7k
 @XNNPACK//:watchos_arm64_32
 @XNNPACK//:watchos_x86
 @XNNPACK//:watchos_x86_64
 @XNNPACK//:tvos_arm64
 @XNNPACK//:tvos_x86_64
 @XNNPACK//:emscripten_wasm
 @XNNPACK//:emscripten_wasmsimd
INFO: Elapsed time: 73.625s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (74 packages loaded, 1523 targets configured)
    Fetching @nodejs_linux_amd64; fetching 12s
    Fetching @emscripten_npm_linux; Restarting. 10s
    Fetching ...8d02a4/external/nodejs_linux_amd64/bin/nodejs; Extracting /root/.cache/bazel/_bazel_root/00533da95dbcbd49bca844bdfd8d02a4/external/nodejs_linux_amd64/bin/nodejs/temp1554428458845878867/node-v12.13.0-linux-x64.tar.xz 9s
error Command failed with exit code 1.

Can you please let me know what I am missing here?
Thanks,
Dipankar.

Thanks for your help. Using the local emscripten toolchain worked. Closing the ticket.


fix  UV__UNUSED usage

The usage of UV__UNUSED inside src/win/thread.c is wrong.
Macro definition:
https://github.com/libuv/libuv/blob/07955ed3737cc59bc4d586b34222669ca87de755/include/uv/tree.h#L31
So it resolves to something like:
void uv_cond_destroy(uv_cond_t* cond) {
    __attribute__((unused))(cond);
}

This declares a new variable of implicit type int. But cond already exists and has a different type.
I've also removed the function declarations of the functions that were removed in 13e8b15eb7e73ed624e88033950e691745a90c6a

This is being addressed in #1882 which I'll probably merge tomorrow.


Add non-empty validation for users

What this PR does / why we need it:
Added validation for input usernames list to be removed from a project.
The action should require at least one user to be removed.
Which issue(s) this PR fixes:
Fixes #FLPATH-333
Change type

[ ] New feature
[x] Bug fix
[x] Unit tests
[ ] Integration tests
[ ] CI
[ ] Documentation
[ ] Auto-generated SDK code

Impacted services

[x] Workflow Service
[ ] Notification Service

Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

@pkliczewski @gciavarrini this test assures the @Validated annotation is used in ProjectController and hibernate-validator enforces the validation of the incoming request parameters.


Consider allowing running of programatic tasks via Node API

Description
Currently, the signature of a task in lint staged is —
(filenames: string[]) => string | string[] | Promise<string | string[]>

where it always expects a shell command as output that it runs via execa. However, consider adding support for promise returning functions instead. E.g.
import { doFoo } from 'package-foo';

export default {
   '**/*.js': async (filenames) => {
      console.log('Start a task')
      await doFoo(filenames);
      console.log('End a task)
  }
}

Advantages —

In a few cases avoid shell execution cost all together (this can be in seconds in large projects using yarn)
Allow for more flexibility in what's executed inside the task fn — including logging / telemetry etc

Given lint-staged is used in steps like pre-commit that need to be lightning quick, saving on shell invocation / yarn invocations costs can be significant. I understand there is value in the declarative nature of the current config — but optimizing for latency in ms is an important goal for something that runs in the critical path of dev workflow.
If this is allowed, the signature would become —
(filenames: string[]) => string | string[] | Promise<string | string[]> | Promise<void>

Where Promise<void> can indicate a freeform task.
Is this something that sounds interesting to you? Do you see any challenges with this?

I really like it! Do you want to create a PR for that? @iiroj wdyt?

Is the functionality essentially the same as creating a separate Node.js script file, and having that be the linter? What benefit is there for defining it directly in the config?
It sounds doable, but is a separate pipeline to the existing thing being based on spawning processes with execa.

This might be a good use of node:worker_threads so that we can run them in parallel and capture console output similar to execa.

Since we execute the current "function config" functions before running actual tasks and also validate the output to be string | string[], the only way to handle this in a backwards-compatible way would be to return more functions:
// lint-staged.config.js
export default {
  "*.js": (stagedFiles) => {
    return () => lintJsFiles(stagedFiles)
  }
}

the syntax of the returned functions could be:
type TaskFunction = (stagedMatchedFiles: string[]) => Promise<void>

but since they're returned from inside a config function, one could of course handle the matched filenames in there as well.
what do you think?


Missing comments in managed file : file managed by puppet

Hi,
just playing a bit with your module which is great.
I like when a module manage a file it add a comment in top of it with something like :
# file managed by puppet
This doesn't cost much, but I think in some cases can be helpfull.
What do you think ?

Good idea ... can you submit a PR for this?

I open a PR hope this will be fine let me know.

Thanks!


laravel won't pull files from files from vendor folder

as the title say laravel won't  pull files I'm calling from vendor
for example

<script src="vendor/jasekz/laradrop/js/enyo.dropzone.js"></script>
<script src="vendor/jasekz/laradrop/js/laradrop.js"></script>

It says it cannot find them
EDIT: Found the problem but cannot find solution.  artisan vendor:publish does not copy the public file to assets

Hi Marko,
Can you verify that your assets directory has the proper permissions for Laravel artisan to write the files to?


add reentrancy tests for reference implementation

Codecov Report
Base: 99.90% // Head: 98.94% // Decreases project coverage by -0.96% :warning:

Coverage data is based on head (8d675e5) compared to base (49ca7c6).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.2     #746      +/-   ##
==========================================
- Coverage   99.90%   98.94%   -0.97%
==========================================
  Files          48       46       -2
  Lines        2210     2189      -21
  Branches      342      360      +18
==========================================
- Hits         2208     2166      -42
  Misses          1        1
- Partials        1       22      +21

Flag
Coverage Δ

production
99.80% <100.00%> (-0.20%)
:arrow_down:

reference
98.20% <85.71%> (-1.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/Seaport.sol
100.00% <ø> (ø)

contracts/conduit/ConduitController.sol
100.00% <ø> (ø)

contracts/lib/Assertions.sol
100.00% <ø> (ø)

contracts/lib/Consideration.sol
100.00% <ø> (ø)

contracts/lib/CounterManager.sol
100.00% <ø> (ø)

contracts/lib/CriteriaResolution.sol
100.00% <ø> (ø)

contracts/lib/Executor.sol
100.00% <ø> (ø)

contracts/lib/GettersAndDerivers.sol
94.44% <ø> (-5.56%)
:arrow_down:

contracts/lib/LowLevelHelpers.sol
100.00% <ø> (ø)

contracts/lib/OrderCombiner.sol
100.00% <ø> (ø)

... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add TrenchR

Insert URLs to the project here:
https://github.com/trenchproject/TrenchR

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@juniperlsimonis @ajijohn


example_inference.ipynb not working

Hi
I get some problem about your code especially cddd_server.py
when i run example_inference.ipynb, it cause ConnectionError like this
ConnectionError: HTTPConnectionPool(host='ec2-18-157-240-87.eu-central-1.compute.amazonaws.com', port=8892): Max retries exceeded with url: /cddd_to_smiles/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7ff999ca6668>: Failed to establish a new connection: [Errno 110] Connection timed out',))
I'm waiting for your help.
Thanks :)

This error occurs when the CDDD server crashes (ec2-18-157-240-87.eu-central-1.compute.amazonaws.com). We recommend moving to hosting your own deployment of the CDDD server and the img2mol server if you want to query larger datasets.
This deployment is a demo server and not necessarily hardened for production.


Edit docs for config templating

Should we change the tutorial to use only the templating for config? I only added it as an alternative for now, but I believe it is more ergonomic to use templating instead of writing from stdout.


Support language specific /$/content/get

API-Change Notes

existing To retrieve full homepage dataset :

https://odysee.com/$/api/content/v2/get

new To retrieve a specific homepage :

https://odysee.com/$/api/content/v2/get?hp=xx

where xx = en, fr, es, etc...

The return object will still include the keys for all available homepages, but the values for unwanted homepages will be set to null.
The full key set will allow clients to generate drop-down lists without needing a different API.

Review Notes

Expand...

  Closes #2388

Test using kp.odysee.tv.  There is a CORS problem, but most likely not affecting the API.
Not familiar with portals' behavior to detect unintended breakage -- do take a look.  But I don't think it will be broken.
What other scenarios to double-confirm besides these:

Incognito
Setting saved to non-English
Browser default is non-English

Thanks KP, this will definitely help load times.
I think the caveat for this was portals and banners - if a specific homepage didn't have one, it would fall back to English. Can we make sure that's taken into account if possible, and if not, maybe we can adjust the logic on homepage side to pull from English if it doesn't exist.

Yup, I "covered" that scenario by relying on the fact that Odysee always have the full en data to begin with, just that it could be stale from browser caching.  So, the current version will always have something as a portal fallback.
Backup plan is to support multiple langs like ?hp=en,ru, which would also help other apps from having to make 2 calls.

But I removed it thinking that (1) if the language owner didn't bother to define a localized portal, it wouldn't matter if the English fallback is a stale one, and (2) the stale issue would go away once we have a proper "new version available" nudge implemented.
Can put this back in if needed.  Thoughts?

So we're doing a double call with lang + en if there's no portal? That's fine for now, eventually i think the homepage should just return en version if none is available.

Nope, no double calls for Odysee.  The caveat scenario is covered.

The homepage is already baked into the code, so fetching ru that has no portal will always have an en data to fallback with.
Recap: we still fetch despite having the data baked-in to solve the caching problem and also to get latest Announcements.
The ?hp=en,ru (single call) suggestion is only needed if we want to avoid using a stale en as a fallback, which I don't think we need to.

I mentioned double-call just for other apps like Roku, if they happen to be doing the en-fallback too.

ah okay, forgot it's also baked into the app. We probably also want to avoid baking in all that data across all languages in the future.


Please, don't use dynamic require imports

Instead of such syntax:
const partOfLibName = 'part1';
const myLib = require(partOfLibName + 'LibName');

Please, use such one:
cosnt myLib1 = require('part1LibName');
cosnt myLib2 = require('part2LibName');

// and later
let res;
if (/* some condition here */) {
  res = myLib1.method();
} else {
    res = myLib2.method();
}

Or with dynamic imports:
cosnt myLib1 = import('part1LibName');
cosnt myLib2 = import('part2LibName');

// and later
let res;
if (/* some condition here */) {
  myLib1.then(res => {
    // user res here
  });
} else {
  myLib2.then(res => {
    // user res here
  });
}

Also you can use the new JavaScript native dynamic import with await, something like this:
let module = await import('/modules/my-module.js');
This can be written inside an if statement.

Hey @Razzwan, I'm assuming you're referring to these two usages:
https://github.com/dOrgTech/DAOcreator/blob/09db2fdb239c69f8c12ad58fd0a84c3789335484/packages/lib/src/dependency/arc/src/migrate-dao.js#L703
and
https://github.com/dOrgTech/DAOcreator/blob/09db2fdb239c69f8c12ad58fd0a84c3789335484/packages/lib/src/dependency/arc/src/utils.js#L21-L28
Both of these source files come from this repo: https://github.com/daostack/migration
They're copied into the DAOcreator here: https://github.com/dOrgTech/DAOcreator/blob/master/packages/lib/scripts/prepArc.js
The reason this manual copying is done is to:

reducing ABI bloat
removing needless dependencies that cause build problems

If you'd like this code changed, I'd suggest making an issue here: https://github.com/daostack/migration

ok. will try to update migration https://github.com/daostack/migration/issues/373


Optimise e2e run

Problem
We have finite amount of runners and intermediate results are often wanted before a PR is ready for merging. Currently all PRs get e2e tests run and this creates a lot of throwaway e2e results which may or may not get to start or complete before a new push.
Summary of changes

Skip e2e test when PR is in draft mode
Run e2e when PR status changes from draft to ready for review (change this to having its trigger in below PR and update results of build and test)
Abstract e2e test in a Separate workflow and call it from the main workflow for the e2e test
Add a label, if that label is present run e2e test in draft
Auto add a label(approve to ci) so that all the external contributors PR , e2e run in draft

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Auto add a label(approve to ci) so that all the external contributors PR , e2e run in draft

Such things should be documented somewhere.

Auto add a label(approve to ci) so that all the external contributors PR , e2e run in draft

Such things should be documented somewhere.

@arssher sure. We will document this.

@bayandin: I have pushed all the changes.


Working with analytics-next and chrome extensions

I'm trying to figure out the best technique to run analytics-next on a chrome extension and feel like I've hit a wall or at least have some conflicting thoughts.
For context the extension I'm working on adds content to web pages.
My understanding, or at least the suggested way to do things, was to put everything into a background page to avoid messing with webpages analytics and other runtime JS. This makes a lot of sense to me and I tried to do this using Manifest V3 by adding this to our brackground script and running analytic events from there.
That's when this gets weird. For some reason the code is run and the track event is run with no fuss, but then nothing happens. The promise never completes and is stuck in a pending state. There is no error, there is no follow up promise, it just doesn't do anything.
I then can run it in the content script, from the person's browser on a webpage, and it works fine. This feels off to me, but I'm unsure if that's just my own hangup.
I wish i could give you any logs, but nothing happens! Here are the relevant code snippets:
// background/analytics.ts

import { AnalyticsBrowser } from "@segment/analytics-next";

const analytics = AnalyticsBrowser.load({ writeKey: "my key here"});

export async function trackEvent(data: any): Promise<any> {
  const { eventName, properties } = data.data;

  await analytics.track(eventName, properties);
}

// background.js
import { trackEvent } from "./background/analytics"

chrome.runtime.onMessage.addListener((message, sender, callback) => {
  const { name, data } = message;

  if (name === "trackEvent") {
    trackEvent(data);
  }
});

This get's called in the content side of things with:
chrome.runtime.sendMessage({
  name: "trackEvent",
  data: { property: "goes here" }
});

Can you please share a full list of all the destinations you've configured with that write key?

Please discard my comment above, it is not relevant.
Here's the unfortunate problem - Analytics library currently does not support service worker environment, which is exactly what Chrome extension's background pages are.
There are some things only present in a "Window" environment that Analytics references therefore it doesn't work there.
If you absolutely must have the tracking in the background page, you can use the Segment's HTTP API directly like so:
const track = async (event: string, properties: Record<string, unknown>) =>
  fetch('https://api.segment.io/v1/t', {
    method: 'POST',
    body: JSON.stringify({
      event,
      properties,
      messageId: '<UUID>',
      sentAt: new Date().toISOString(),
      timestamp: new Date().toISOString(),
      type: 'track',
      userId: '<USER_ID>',
      writeKey: '<WRITE_KEY>'
    })
  })

Although be warned of the troubles with using the method I suggested - it is wild waters. You'll have to manually augment user id, timestamps, message id etc.

@zikaari Thank you for your quick response.
I don't know that I must do anything in this situation, but more wanted to see if what I was doing was even possible. It felt like I was doing something wrong since it gave no indication that nothing was wrong except that nothing was being tracked.
While I think it'd be nice to send events via the service worker, is it possible to warn people if they try?


supplement testcase for TBinaryProtocolTest(Java)

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

This case has been incorporated into 2191.


Enumerate layers of product

Web form
|
|
API
|
|
Library
Need to fill out description, user/client, use cases

Roadmap

Prototype example application
Talk about splitting reorganizing the project (April)
pdftk wrapper library
redeployable Flask app
Example application that is deployed
SaaS of the thing
PDF --> Web form app (currently undefined)


Build automation

[x] Branch structure

[x] Protect main branch from pushed
[x] Create beta branch protected from pushes
[x] Create dev branch

[ ] Release automation

[ ] Implement automatical version bumping if possible
[ ] Implement automatic release creation

[x] Build version

[x] Build macos applications

[x] amd64
[x] arm64

[x] Build windows applications

[x] amd64
[x] arm64

[x] Build linux applications

[x]  amd64
[x] arm64

GOOS and GOARCH supported values

Job to build versions for different platforms

Thinking about removing release automation for now as "releasing" the app in a bundle state isn't really feasible right now.

Code signing for windows: https://stackoverflow.com/a/51717702

Planning to use Goreleaser with Gon


AMBARI-25487.Change authentication method from get to post

What changes were proposed in this pull request?
Change auth method from GET to POST
How was this patch tested?
manually
Please review Ambari Contributing Guide before opening a pull request.

Closed, as pushing this changes would lead to broken authorization without BE changes


External httpClient support

Adds the support to make a Device with a customized http.Client:
dev, err := goonvif.NewDevice(goonvif.DeviceParams{
	Xaddr: "<IP_ADDRESS>:1899",
	Login: "username",
	Password: "password",
	HttpClient: &http.Client{Timeout: 1 * time.Second},
})

thanks!


Voice API - Calls and Callouts

This PR omits any SVAML related code. SVAML will be implemented within DEVEXP-306

This PR is redundant. There is already PR open for the whole Voice domain.


Compilation errors when using tsc

When importing individual classes like this:
import { Ellipse as Ellipse,
    Rectangle as Rectangle,
    Color as Color } from "../node_modules/@adobexd/typings/types/scenegraph";

and compiling using tsc, the compiler throws the following errors:

306     public constructor(fileOrDataURI: string | uxp.storage.File);
                                                   ~~~

node_modules/@adobexd/typings/types/scenegraph.d.ts:341:74 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

341     public constructor(x: number, y: number, blur: number, color: Color, visible: boolean = true)
                                                                             ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@adobexd/typings/types/scenegraph.d.ts:413:31 - error TS2304: Cannot find name 'SceneNodeList'.

413     public readonly children: SceneNodeList;

importing using require works, but doing so means you can't use the types as intended in your code:
const {Rectangle, Ellipse, Color} = require('scenegraph');

Here is an example project: https://github.com/mattThousand/typings
please let me know if I can provide additional information or help out in any way

@mattThousand
First, I have fixed a few bugs regarding the typings. Could you please try it with npm i https://github.com/AdobeXD/typings/tarball/pklaschka-patch-typescript-errors?
Secondly, you need to import directly from scenegraph (not from ../node_modules/@adobexd/typings/types/scenegraph). Then, you can specify how that gets resolved in your tsconfig.json. For example, you could use something like this:
{
  "compilerOptions": {
    "target": "es6",
    "module": "commonjs",
    "baseUrl": ".",
    "paths": {
      "scenegraph": ["./node_modules/@adobexd/typings/types/scenegraph"],
      "application": ["./node_modules/@adobexd/typings/types/application"],
      "commands": ["./node_modules/@adobexd/typings/types/commands"],
      "uxp": ["./node_modules/@adobexd/typings/types/uxp"],
      "os": ["./node_modules/@adobexd/typings/types/os"]
    },

    "typeRoots": ["@types","./node_modules/@adobexd/"]
  }
}

Your package.json should then look something like this:
{
  "name": "xd-typescript-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "build": "tsc -p ."
  },
  "devDependencies": {
    "@adobexd/typings": "https://github.com/AdobeXD/typings/tarball/pklaschka-patch-typescript-errors"
  }
}

Your .ts file something like this:
import {Rectangle, SceneNode} from "scenegraph";
import application = require("application");
import uxp = require('uxp');

function test() {
  // do stuff
}

module.exports.commands = {test: test};

@pklaschka that's perfect - thank you!


VoicePipelineAgent.aclose does not stop the agent correctly

await agent.aclose() should be tearing down the agent. However, users are reporting that it's not working as intended.

@davidzhao if you could provide some guidance about the internals, I would be interested in creating the PR on this because I've been looking into to this issue since a while.

@beydogan, that'd be awesome. I'd love to help if you are interested in tackling this.
Basically when the agent shuts down, it needs to terminate any async tasks that might be running, stop pushing frames to the published tracks, and stop any processing of incoming audio bits. Let me know if there are specific questions, you can find me in our Slack community

@davidzhao if you could provide some guidance about the internals, I would be interested in creating the PR on this because I've been looking into to this issue since a while.

hi, @beydogan great to hear this,  I've blocked by this issue for a while, thanks for your support!

@davidzhao @beydogan Hi, sorry but is there any progress for this issue?


Persistent hex mode in structure editor (or keyboard shortcut)

From what I gather, every time one opens the structure/enum editor the values appear in base ten and the user needs to manually open the configuration menu and click to switch to hexadecimal mode.
Given than in the decompiler the autogenerated members appear as some hex offset this adds some friction while filling out big structures.
It would be lovely to persistently save the current hex mode toggle globally across structure editor instances, maybe even adding a key-binding to quickly toggle it without using the mouse.
--
Maybe some of these features already exist and I'm just very bad at finding them, please let me know.
Thanks for the great program.

I believe this is a bug.  (Although maybe it was intentional, since it could allow the user to have a global setting that they can change for an individual editor, without affecting all editors.)
You can turn on the hex option via the Tool Options under Edit -> Tool Options... Then Options -> Editors -> Structure Editor -> Show Numbers in Hex.    Setting the value here will apply to all editors and will get persisted, assuming you shutdown Ghidra normally.

You should be able to set a keybinding on that menu action by hovering the mouse over it and pressing F4.

Oh, boy. I think I need to take another good look at the manual. Thanks for the heads up.

I'll close this for now, as I think it is working as we originally intended.

Fair, hopefully other people searching for this will arrive here.


Don't error out when Zig compiler is missing when targeted shared library exists

Duplicate of #427.


Modify mod_access and mod_key_log.

Codecov Report

Merging #404 into develop will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
+ Coverage    52.96%   52.97%   +0.01%
===========================================
  Files          245      245
  Lines        23126    23127       +1
===========================================
+ Hits         12248    12252       +4
+ Misses        9460     9456       -4
- Partials      1418     1419       +1

Impacted Files
Coverage Δ

bfe_modules/mod_access/mod_access.go
0.00% <0.00%> (ø)

bfe_modules/mod_access/conf_mod_access.go
28.43% <100.00%> (+0.70%)
:arrow_up:

bfe_balance/bal_gslb/sub_cluster.go
48.14% <0.00%> (-7.41%)
:arrow_down:

bfe_spdy/frame_write.go
49.49% <0.00%> (-1.02%)
:arrow_down:

bfe_spdy/frame_read.go
57.35% <0.00%> (-0.76%)
:arrow_down:

bfe_spdy/server_conn.go
78.98% <0.00%> (+0.44%)
:arrow_up:

bfe_http2/writesched.go
80.91% <0.00%> (+1.52%)
:arrow_up:

bfe_websocket/server_conn.go
76.51% <0.00%> (+3.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d4f1d...9ff0f18. Read the comment docs.


Read a single Item from an Order

As a user
I need to read any given item in an order
So that I can read full order detail
Details and Assumptions

return detail information on the order item

Acceptance Criteria
Given a order and items in the order
When the caller calls GET /order/<order_id>/item/<item_id>
Then the response is a 201
And response json contains detail on the item

Closed by #22


MultiDict.values - incorrect implementation in python 3

https://github.com/bottlepy/bottle/blob/9fb3b05846b33e508545a26e424785e151d02323/bottle.py#L2112
Assuming MultiDict supports dict protocol (which docstring suggests it does - ".., but behaves exactly like a normal dict.."), .values implementation is not correct. The returned object should be a view which, among other things, supports len. See https://docs.python.org/3/library/stdtypes.html?#dict-views

So we basically need to implement a view-wrapper that applies a function to each value, but otherwise behaves like a view? There is nothing like this in the stdlib I think.

WebOb gets it wrong as well btw: https://github.com/Pylons/webob/blob/master/src/webob/multidict.py#L318
This project does it correctly afaict: https://github.com/aio-libs/multidict/blob/master/multidict/_multidict_py.py
Another option would be to simply not support dict protocol. From my personal perspective MultiDict has a pretty narrow use case, namely to support FormsDict. And to handle web forms one doesn't need the whole richness of the dict. Would make the implementation much simpler. But that's my two cents.


updated for app proxy screenshot and steps

Learn Build status updates of commit 4d1db12:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/saas-apps/ms-confluence-jira-plugin-adminguide.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dhivyagana
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@jeevansd
PRMerger will accept sign-off from the listed author, @dhivyagana, only.
However, if you are a Microsoft employee authorized to update this content, you can send a request to<EMAIL_ADDRESS>for this PR to be merged. Include your role and an explanation of why the PR should be merged without approval from the listed author.

#sign-off


Literals union

The ability to specify literals union:
const coercePost = coercer.infer(($) => ({
  title: String,
  text: String,
  status: $.Union("draft", "published", "archived"),
}));

Unless one of the union members matches the value, use the very first one ("draft" in the example).

Resolved by https://github.com/kossnocorp/ofcoerce/commit/4a4db6c9ec5bb3d0fafae288a1e7208867cc1a5b and shipped with<EMAIL_ADDRESS>


Pype: changelog.md is outdated

changelog.md inside Pype repository is outdated, freezed on 2.3.0. We should either remove it or keep it up-to-date.

I started using github changelog generator now, which is generated with each release, so this should be implicitly fixed by that.


Stellar Staging - Rename wallet allows for duplicate wallet names

Repro steps

Rename a wallet to daily while already having a daily wallet

Expected Result
Same name validation as in import/create wallet, no duplicate ( also ensure space trimming doesn't allow this to be bypassed )
Actual Result

System Info

Prio critical as this has the unintended consequence of not allowing the user access to their wallet anymore since it keeps opening the wrong one.

downgraded to major as it's possible to rename all wallets until duplicates are gone again


Add Consolation, an in-game debug console

This is a self-contained script that adds an in-game console displaying output from Debug.Log. It's particularly useful when distributing beta builds and getting console logs from players who run into exceptions.

Thanks for the PR, looks like a neat little script. I've actually never heard of Application.logMessageReceived so that may come in handy even outside of this component.
Thanks for the contribution!

i have modified console window for unity too .
https://github.com/cartzhang/UnityConsoleWindow
Would you please to put it in your awesome-unity.
thank you very much.


Adaptively set ticker period for monitored cmd

What does this do / why do we need it?
The previous implementation had a worst case where a command could run
for nearly double the length of the specified timeout.
What should your reviewer look out for in this PR?
Are the bounds I set sane? Do they even matter that much?

probably gonna be better just to get rid of these


Performance

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
No response
Actual Behavior
It takes up to 5 seconds to load which slows the site
Expected Behavior
Is it possible to get it to 2 seconds or less
Additional Context
Hi, I am using Monaco editor for a project however it takes quite a while to load. In my code, I even define the language which when I looked should improve the loading time however it still hasn't improved. Is there anything else that is possible to do so that the performance improves? Maybe some settings in JSON or in the editor itself. I couldn't find any relevant reference to it.

Can you try to figure out if there is anything that does not need to be loaded in your case?

Then maybe just my configuration is wrong. How can I test if everything I am using is required and if not then disable it to use just the bare minimum for it to make it work and perform better?

Monaco-editor/esm/vs gets loaded in the webpack other than that it's a bunch of different scripts


set the dep as the project app before running hooks

Seeing the app that is about to be compiled as the project app before running compile hooks allows for simpler configs and providers that work the same at the top level and when part of dependencies.
Specifically I discovered this issue when using rebar3 to build rebar3 and erlydtl provider hook failing to work on relx.

Any risk that this also confuses some hooks or providers when they end up operating on a dep as if it were a top-level app (and try to do something fancy, assuming higher precedence or trying to find deps otherwise), or do you believe things to be generally safe there as long as our existing API is being used?

Hm, so no, but I just thought of another way this might be doable that I'm going to try. So don't merge this yet.

I forgot that deps have their own state records which have dir set to their directory. Meaning that can be used instead of depending on project_apps. This is what the port_compiler plugin does.
That may be cleaner. I'm modifying the PR now.

Updated. The escriptize provider is more of a special case, would be odd to want that to run as a hook on a dependency anyway... But technically it'll work if they set escript_main_app.


Specify Basic auth scheme so non-preemptive auth works

@dconcha @RobertoRL This change fixes the problem in my testing.

lgtm


type definitions from plugin /www folders not copied to .tmp for aot builds

Short description of the problem:
Type definition files from plugin /www folders are not copied to the /.tmp folder for Aot production builds. They work fine in dev builds.
What behavior are you expecting?
Production builds should see side-by-side type definitions in plugin /www folders.
Steps to reproduce:

Install a cordova plugin with a side-by-side type definition *.d.ts file like cordova-plugin-ms-adal.
Reference a global from the plugin type definition (e.g. Microsoft.ADAL... above).
Run a dev build and see everything work fine.
Run a prod build and see the errors thrown by the AoT compiler about "cannot find namespace xxx" and such (e.g. "Cannot find namespace Microsoft..." in the above example).

// put this in device ready or somewhere - dev works fine, but aot won't see `Microsoft` defined
let authContext = new Microsoft.ADAL.AuthenticationContext('https://login.windows.net/common');

Which @ionic/app-scripts version are you using?
I tried 0.0.39 and the latest 0.0.46
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Just wanted to add that my workaround is to manually copy the .d.ts files to the project folder.
Often, plugin type definitions aren't distributed side-by-side with the plugins, so people use ones from DefinitelyTyped (or the @types npm mirror). That puts them in locations that the ionic prod build will handle correctly. However, those aren't always up-to-date (the DT definition for the Microsoft ADAL plugin mentioned above is waaay out of date). Since typescript itself sees side-by-side plugin definitions just fine - and, by extension, so does the ionic dev build - the ngc copy process needs to be updated to support them.

@rob3c,
Sorry, we recommend using @types or npm to manage this. Worst case, if that doesn't work, you could add an entry to the copy.config and let the copy task handle it for you.
Please let me know if that will work for you.
Thanks,
Dan

@danbucholtz Copying the files over myself isn't the issue (there are plenty of ways for me to manually do that). Such a manual process is exactly what I'm trying to avoid, especially when it makes sense for ionic to take care of it as part of cordova plugin support.
I created this issue because it seems appropriate for ionic to support libraries that actually go to the trouble of distributing their own type definitions in their npm package alongside their code. Since ionic is built on cordova, it seemed reasonable that ionic should support the /www distribution folder convention for plugin assets, including type definitions for its contents.
I'm not sure what you mean by letting npm manage this, since the plugins I'm talking about are already installed via npm. Also, @types on npm is just an auto-generated mirror of the DefinitelyTyped repo, which is really a hack to provide type definitions for those libraries that don't already distribute type definitions along with their js files. It's much better when libraries distribute their own definition files to help keep things in sync. Why discourage plugin writers from distributing their own definitions?

If there are definitions in the npm package, say... @angular/core or ionic-angular for example, they'll be resolved and everything will work happily.
We don't actually use the .tmp folder anymore, so it is a non-issue either way. Everything should just work.
Thanks,
Dan

Sounds good! I've had to switch away from ionic temporarily, so I missed that welcome change to the build process. I look forward to diving back in in the next few weeks.


chore: update Mathlib for leanprover/lean4#2825

Changes to how abstraction works, so has affected the clean% test which cares about these details.

bors d+


Responsive Pagination

Looking at the UI Bootstrap, there's a way to resize the pagination using "max-size" and I don't see anything like this in your code.
I've played with a few things and have even been able to get the number of results per page to change, but the paging remains the same.
Is there a simple way of resizing the pagination based on the width of the window?
As an example: http://demo.sodhanalibrary.com/angular-bootstrap/responsive-pagination.html
Or even: https://codyhouse.co/demo/pagination/index.html#0
Otherwise, I am very happy to have this simple util available for use. Thank you!

Hi,
No, this module does not include such functionality. However, you could implement this yourself without too much trouble I think. I've never done anything like this but perhaps it will work:
You can use the max-size attribute to set how many pages to display. In your controller you can query the width of the viewport and then use some algorithm to decide how many pages should be displayed at a given width, and update the value of max-size accordingly.


Merge Test_New into Test

Follow-up of #8968
Pull Request Description
Merges the temporary Test_New library into Test. This is the last PR in the series of PRs that refactor all the stdlib tests to the builder API.
Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Does this do anything else other than:

rm -rf Test
mv Test_New Test
rename imports of Standard.Test_New into Standard.Test

If nothing non-trivial other than that, then it looks good :)

@radeusgd No, it doesn't do anything else. Just some marginal typo fixes after merges. Otherwise, it is this simple.

I was hoping to use the last PR to through-fully review the testing API. However everyone else seems to be fine with the current state, so let's accept it...


1.16 support?

Does this plugin work on 1.16.x?

It should.  I'm working on a major overhaul to add support for additional border shapes and integration with other plugins on my fork.  I also set up a discord server for it: https://discord.gg/ePNBgMG

You should be aware that on many of the 1.16.1 ports i have test , trim does not work on spigot or paper .
https://github.com/PryPurity/WorldBorder/issues/8

You should be aware that on many of the 1.16.1 ports i have test , trim does not work on spigot or paper .
PryPurity#8

How about 1.15?

Yes , 1.15.2 is fully functional , you just need to know that if you are doing a fill or a trim some plugins can open chunks and stop a trim from completing . I use it for maintenance , to set borders ,  generate the map and trim . You may need to disable dymap to get a well groomed world and then enable dynmap to render your worlds

Brett , I checked the flyout areas after a trim with the standalone editor Amulet https://github.com/Amulet-Team/Amulet-Map-Editor/releases . Trim does not work on 1.16.1

I explained over there how it works at least in my code. It's possible something has changed with his fork that broke it; whatever the case, I no longer support the plugin, I just wanted to step in and explain how it (hopefully still) works.

Pry misunderstood he closed the issue .

Brett , Maybe you can update your readme and main page , to send people to Docwhomc's Discord to get those people working together for updates

It's my understanding there are 2-3 forks different people are working on. I don't want to show favoritism for any one in particular, nor do I want to have to keep track of an ongoing list of forks people are working on. After a while, if maybe one fork has shown itself to have more activity and stayed active, I might update the readme to point to it.


Cannot connect to Twitch, retrying ...

Once I open the miner, it logs
Cannot connect to Twitch, retrying in ...

And does nothing.
See full log with max verbosity: log.txt
I'm using WIndows version.

What I am missing?
Thank you in advance.

This happens to me when I quickly restart multiple times. Just wait a bit, restart and it should work.

Hi
I left it open overnight and all messages that I see in the end of the log are
10:41:00: DEBUG: Websocket[0] sent: {'type': 'PING'}
10:41:00: DEBUG: Websocket[0] received: WSMessage(type=<WSMsgType.TEXT: 1>, data='{ "type": "PONG" }\r\n\r\n', extra='')
10:42:52: Cannot connect to Twitch, retrying in 180 seconds...
10:44:00: DEBUG: Websocket[0] sent: {'type': 'PING'}
10:44:00: DEBUG: Websocket[0] received: WSMessage(type=<WSMsgType.TEXT: 1>, data='{ "type": "PONG" }\r\n\r\n', extra='')
10:45:58: Cannot connect to Twitch, retrying in 180 seconds...

Is it ok?

Hi I left it open overnight and all messages that I see in the end of the log are
10:41:00: DEBUG: Websocket[0] sent: {'type': 'PING'}
10:41:00: DEBUG: Websocket[0] received: WSMessage(type=<WSMsgType.TEXT: 1>, data='{ "type": "PONG" }\r\n\r\n', extra='')
10:42:52: Cannot connect to Twitch, retrying in 180 seconds...
10:44:00: DEBUG: Websocket[0] sent: {'type': 'PING'}
10:44:00: DEBUG: Websocket[0] received: WSMessage(type=<WSMsgType.TEXT: 1>, data='{ "type": "PONG" }\r\n\r\n', extra='')
10:45:58: Cannot connect to Twitch, retrying in 180 seconds...

Is it ok?

The metric for ok is does it farm. From what you sent, it looks like twitch or your internet was down for a bit.

I run into this where if I don't touch it, it will says "Twitch is down..." for hours, but if I exit and start over it will work again.

My connection is glitch sometimes - I have packet loss bursts, but 99% of time everything is fine.
Could be a firewall issue? I think I completely disabled it on my PC as well as AV.

Thanks for the log! I'll take a look at it once I find a bit of time.


Chore: make client tools singleton

Description of your changes
This PR refactor how CLI retrieve all kinds of client of CUE or Kubernetes. (e.g. controller-runtime client, client-go client). Make all client to be singleton so that:

They are only initialized once in the whole CLI lifecycle.
We don't need to pass common.Args objects all through the functions calls. If you need one kind of client, you don't need to bring the whole Args struct into process.
Make it configurable to specify which command to use which client.

Add singleton helper https://github.com/kubevela/kubevela/pull/5977/files#diff-db7939e1cd0344b595e71373d36a074f90ecd706fb27d9443f1cb4f3d6ec6efe
Pre-define a group of client which is widely used in CLI. Initialize them depending on which command is executing. https://github.com/kubevela/kubevela/pull/5977/files#diff-08f4fad8dbec5f55d0ca1d8994031837740adc8d52318a88704a8d0e5bda1db6 https://github.com/kubevela/kubevela/pull/5977/files#diff-004b35966c6dda784fba0fe64ddc863a10d0bab72fbedf97929daebc8d18d93dR62-R68

This is a re-work of #5158

🤖 Generated by Copilot at f8bd103
Summary
🔧🚀🧹

Refactored the codebase to remove the dependency on the common.Args struct and simplify the creation and access of the Kubernetes config and client. Introduced the common.Config() and common.DynamicClient() functions and singleton variables to achieve this goal. Updated the tests and other packages accordingly. Also refactored some other packages to improve readability and modularity.

common package changed
Simpler clients and configs
Spring cleaning the code

Fixes #
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Does it solve #5158?

Does it solve #5158?

Yes

/retest-failed


Rename tests directory to test for glance and cinder operators

In glance and cinder operators we recently merged [1][2] and normalized the project layout with what's described in [3].
This patch aligns install_yaml to reflect the recent changes in the operator.
[1] https://github.com/openstack-k8s-operators/glance-operator/pull/301
[2] https://github.com/openstack-k8s-operators/cinder-operator/pull/256
[3] https://github.com/golang-standards/project-layout

/lgtm
I thought to use tests as the common directory name, because it's more commonly used in oko repos, but I agree it may be better to follow the guideline document so I'm ok with that PR once these files gibi pointed are removed.

recheck


Investigate Crunchy on AWS

Out of scope.  Some work happening in https://github.com/bcgov/quickstart-aws-containers.


(WIP)(Don't Merge)(PUP-3632) Update paths and defaults for the unified agent layout

This commit updates Puppet's confdir and vardir to adhere to the
all in one agent layout. Unit and acceptance tests have also been
updated to reflect these changes.

@haus mentioned that we will also need to figure out how we want to deal with Puppet's logdir and rundir, which with the way they are configured now will become: /opt/puppetlabs/agent/run and /opt/puppetlabs/agent/log by default. These aren't the correct directories according to the layout, but it seems that the default has always been wrong, and we just override them by default in puppet.conf. Do we want to keep doing this or make the defaults sane?

These aren't the correct directories according to the AIO layout, but it seems that the default has always been wrong, and we just override them in puppet.conf. For example, right now Puppet's default rundir is /var/lib/puppet/run, but we change that to /var/run/puppet in puppet.conf.
Do we want to keep doing this or make the defaults sane?

Ah good catch @whopper. Let's make the defaults sane. Now is the perfect time.

@kylog right on - will do and update PR!

CLA signed by all contributors.

Update: currently this PR makes the following path changes for Unix:
confdir: /etc/puppet becomes /etc/puppetlabs/agent
vardir: /var/lib/puppet becomes /opt/puppetlabs/agent/cache
rundir: /var/lib/puppet/run becomes /var/lib/puppetlabs/agent/run
logdir: var/lib/puppet/log becomes /var/log/puppetlabs/agent
The only change I'm not totally sure about is the rundir, as it wasn't specified in the list of new AIO paths. Does /var/lib/puppetlabs/agent/run seem right?
Also, I'm currently trying to figure out how to make install.rb create the correct directories so acceptance  passes. Does anyone have any advice on that?

/var/lib/puppetlabs/agent doesn't seem right. It should be /var/run/puppetlabs/agent.
For install.rb, you can throw flags like --configdir, --mandir, --bindir. Logdir won't be created on install.

As an update: I've still got some acceptance failures that I'm trying to work through on this.

Haus suggested we may want to update the puppet.confs we ship by removing each of them in ext and just symlinking them from a single empty puppet.conf in conf, since the default paths should now be sane. Should this new puppet.conf just be an empty file, or have any documentation?

@whopper when discussing this, it seemed arduous without an automated solution, so leaving it empty initially was the proposal.

General update: in this PR's current state, I've got all of the acceptance tests passing! \o/. The only weirdness is the bit about creating the new var and conf dirs in install.rb, which I tried removing. That caused immediate failures due to the directories not existing:
Test Case setup/git/pre-suite/020_PuppetUserAndGroup.rb reported: #
<Beaker::Host::CommandFailure: Host 'gluak8yaywikjh6.delivery.puppetlabs.net' exited with 1 running:
puppet resource user puppet ensure=present
...
Error: Could not run: Got 3 failure(s) while initializing: File[/opt/puppetlabs/agent/cache]: change from
absent to directory failed: Cannot create /opt/puppetlabs/agent/cache; parent directory
/opt/puppetlabs/agent does not exist; File[/var/log/puppetlabs/agent]: change from absent to directory
failed: Cannot create /var/log/puppetlabs/agent; parent directory /var/log/puppetlabs does not exist;
File[/var/run/puppetlabs/agent]: change from absent to directory failed: Cannot create
/var/run/puppetlabs/agent; parent directory /var/run/puppetlabs does not exist>

@haus and I discussed a possible solution for this, which is to add additional, configurable settings for vardir, rundir and logdir into install.rb. I've updated the PR with this implementation, and am running tests again to verify all is still well.

I'm sure this has been discussed, but I'm curious why vardir isn't in /var anymore? I assume puppet has been doing the wrong thing for a long time now. But that raises a second question of whether we should continue calling it vardir?

I'm sure this has been discussed, but I'm curious why vardir isn't in /var anymore?

IIRC @stahnma said that many people want an enterprise app nicely segregated into /opt (which might be symlinked to /var on some systems).

But that raises a second question of whether we should continue calling it vardir?

Hmm, interesting. "cachedir" ? Naming is fun!

As per a quick discussion with haus, I've moved rundir to /var/run/puppetlabs for now.

This may need a rebase after the rspec 3 changes.

@nwolfe: @kylog said he mentioned this to you; it sounds like your PR needs to be based on this branch?

Rebased on the rspec changes from yesterday. I'm in class all day today, but I'll try to make sure everything is good to go with this.

Will this break our current acceptance pipeline?

@kylog I ran acceptance against this in Linux and Windows and everything was passing, but that was before the last few changes, so I will definitely run again tomorrow. (Unless you meant break it in a different way?)

@whopper thanks! Was that a test against packages or against source?
It may be that it won't pass with current packages (which would be fine) and that this can only be merged when we have AIO pipelines as the definitive CI pipeline - that's basically the issue I was trying to explore.
/cc @haus

@kylog aha! Yeah, passing with source. Unless the packaging has been updated it will definitely fail, since the source is only passing with all of the changes to `install.rb that specifically update the paths.

@haus I went ahead and put back vardir, rundir and logdir into our new default puppet.conf to match how we were doing it before. You're right though.. depending on a conf file for the master to work seems a bit goofy.


Revert "cherry-pick #9570 Restrict tigera-operator secret access to namespace only, retain get/…"

Reverts projectcalico/calico#9643

/sem-approve


How to remove the .html suffix?

I see that the URL for the case is https://just-the-docs.com/docs/search, ends with "/search/", but when I place the same file in my repo, it ends with "/search.html".
How can I remove the .html suffix to make it the same as the case? I've been studying it for half a day and still can't figure it out!

Hi @abcpeak, thanks for asking. It sounds like you're looking for the permalink: pretty Jekyll option, which you can add to your _config.yml.
(alternatively, you can set the permalink individually on each page)
Let me know if that doesn't solve your problem!


use_frameworks support

Hi there react-native community! Greetings from App Center (again :slightly_smiling_face:).
We have a question concerning "Better support for use_frameworks!" in your 0.61 release. Does that include our case or still not quite?
We have a dynamic AppCenter framework linked to the static AppCenterReactNative one, and based on my latest tests, it still doesn't work with use_frameworks!. Here for example one of our customer's issue.
I was having the impression that it is partially fixed in your new release, is that so? We haven't found any more documentation on this. Thanks!
React Native version: 0.61-rc3
Steps To Reproduce
Here

Hey @annakocheshkova, I'm not familiar with your use case.
Can you help us understand what's not working?

@jtreanor could you help with this?

Yes, use_frameworks! should be working in the latest 0.61 RC. I can take a closer look to see if I can figure why this isn't working in your case.

Hey there, thanks for the quick response!
Basically one of our customers wrote in saying that he read about "Better use_frameworks! support" in 0.61 version and he tried that with our module but it didn't work. I can confirm it's true.
The reason is that we have 3 sets of plugins:

Plugins for each module (appcenter, appcenter-analytics, appcenter-crashes etc.)
Shared plugin (AppCenterReactNativeShared) referenced from each of those ^
And native iOS framework named AppCenter referenced from AppCenterReactNativeShared.

As seen from the original customer's issue, react-native doesn't see the latter framework because it's not a conventional static framework, so react-native tries to search for AppCenter headers used in AppCenterReactNativeShared, but searches them in appcenter folder and fails.
This is the structure:

From your description, I'm not sure this is related to the CocoaPods use_frameworks! option, but perhaps I am mistaken. The improvements in 0.61 are purely concerned with supporting integrating React Native via CocoaPods with use_frameworks! enabled.

Well I narrowed it down to this because it works fine without use_frameworks!.
Not sure if that is entirely the case, but one of the reasons at least.
The gist of the issue is that Xcode somehow ignores the case and looks for AppCenter headers inside appcenter folder at the moment of build.
This is either Xcode/Cocoapods issue, or something in react-native doesn't allow to search inside a dynamic framework target. Not even sure where to dig.
What led me to my assumptions is this:

Not sure if this will be any help at all or not, but I recently tried to use Expo's unimodules in a 0.60.5 project and discovered that using both the use_unimodules! and the use_native_modules! (autolinking) declarations prevented my pods from being properly included in my project.

Hello, I am in the same predicament of @annakocheshkova, I have the same conclusions, I really do not know where to start digging, if you have any idea I am all ears

bump


Forbid variable assignment in function call

While reviewing some code, and with the help of @Blacksmoke16, I learned that it is possible to assign a local variable in a function call, like so:
def foo(param1, bar = true, baz = false)
  # Some logic
end

def some_other_foo(param1)
  # `baz` is local to this function
  # but ends up passed as `bar` inside `foo`
  foo(param1, baz = true)
end

some_other_foo("value")

In my opinion, this is a potential footgun, and should result in a compiler error.
The confusion between param = value (for function declaration) and param: value (for function calls) is easy to make, especially when coming from/switching with other languages, such as Python. The reason why I'm mentioning that is that it happened to an experienced Crystal programmer.

My 2 cents is I think this is somewhat unlikely to be changed, but maybe a "no assignment in call" rule would be a possibility for ameba.

This syntax is necessary for very basic things like the getter macro:
class Foo
  # this is how the macro call really looks like, even though
  # most of the time `getter` is never used with parentheses
  getter(x = 1)
end

Unfortunately this also means Ameba shouldn't detect this, as it takes a semantic pass to determine whether getter is a macro or def cell.
Instead, when there are multiple optional parameters, personally I'd make all of them named:
def foo(*, bar = true, baz = false)
end

foo(baz = true)       # not allowed
foo(baz: true)        # okay
foo(baz: baz = true) # okay
foo(bar: baz = true) # okay

This syntax is necessary for very basic things like the getter macro
...

Crap, I didn't think of that. Is it possible to get that at the compiler level then?
Maybe at least a warning that is triggered when the local variable has the name of one of the function parameters, but doesn't match it position-wise:
def foo(bar = true, baz = false)
end

foo(bar = false) # no warning
foo(baz = true)  # compiler warning

Instead, when there are multiple optional parameters, personally I'd make all of them named:

That's what we will use in the future, I guess.

This seems like a perfect feature for a linter. The linter needs access to the semantic stage, so ameba currently cannot implement that. But it could be a future expansion (if not for ameba, then as a separate tool). Semantic linting is certainly useful in general.

Don't think there's really anything actionable here anymore. I'd maybe open an issue in the Ameba repo, as this could be a good candidate for that when/if it gets semantic linting capabilities.


mud-theme-white not working

Bug type
Component
Component name
No response
What happened?
<MudGrid class="gap-4 mud-theme-dark">
    <MudItem Class="py-8  mud-theme-white" />
    <MudItem Class="py-8  mud-theme-secondary" />
    <MudItem Class="py-8  mud-theme-primary"/>
</MudGrid>

If you use mud-theme-white as a class you don't get white background as aspected... any other color is respected..
Expected behavior
White background when using mud-theme-white
Reproduction link
https://try.mudblazor.com/snippet/QkQwFOlIBtPDBqIR
Reproduction steps

...
Relevant log output
No response
Version (bug)
6.0.17
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Do we have mud-theme-white? I think not.

Closing since mud-theme-white never existed at first place.


Create a simple show and hid password feature using HTML, CSS & Javascript

@sachin-duhan26 Same for this issue too kindly add the event specific labels

Completed above task @sachin-duhan26


cxxrtl RFE: enhance cxxrtl_object with additional type flags

Right now, cxxrtl_object only contains type (value, wire, memory), width, depth, and value.
The comments in the source already say: "More description fields will be added in the future, b...", but I want to make this more concrete: I'd like to see a flag that indicates that a wire is driven by a FF (IOW, an is_ff_cell), by a sync cell (is_sync_ff_cell), whether or not it's an internal port, what kind of port type etc.
The immediate use case I'm thinking about is a poor man's version of Siloti, where you'd only dump the values of FFs to a waveform, and figure all the other combinational values by loading these values back into the FFs and executing a simulation step().

The immediate use case I'm thinking about is a poor man's version of Siloti, where you'd only dump the values of FFs to a waveform, and figure all the other combinational values by loading these values back into the FFs and executing a simulation step().

Everything you need to do that is already provided. The subset of simulation state you're looking for is just the state stored in objects with type CXXRTL_WIRE. Note that it wouldn't be enough to add a single flag per cxxrtl_object anyway: CXXRTL is a coarse grain simulator and you can drive a wire partially with FF outputs and partially with comb outputs, for example.
Note that multiple CXXRTL_WIRE debug objects can refer to the same underlying wire<N> object in case there are wire aliases. You'll need to deduplicate them by the curr pointer. This could be done within CXXRTL itself, I'll look into it soon.


[Bug]: The game's performance can be significantly affected when the Ageing mode lists contain too many entries.

General Info

[ ] I am running a modpack
[ ] I can reproduce this issue consistently in single-player
[ ] I can reproduce this issue consistently in multi-player
[X] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
[ ] I am crashing and can provide my crash report(s)
[ ] I am using the latest version of the mod

Forge version
Any supported version of this mod
Minecraft version
Any supported version of this mod
Mod version
Any supported version of this mod
Java version
Any supported version of this mod
Issue Description
Title. To be specific: https://github.com/Mrbysco/AgeingSpawners/blob/1.19.x/src/main/java/com/mrbysco/ageingspawners/util/AgeingHelper.java#L11
Possible solution: Pre-initialize and cache the result
A long time ago I was working on a modpack. When I added a lot of entries to this mod's config file, the game became laggy because of the spawners.
I haven't reported the problem since, and only recalled it when I recently solved this performance problem (and improved by 100+ fps) at Embeddium Extras
Additional Information
No response

some details


who are the 1% people that will be affected by the Third party cookie breakage

We need to understand if your organization users/project users will be affected by this phasing out. What the 1% users are exactly who will be affected by this.

Hi @anjumtadmod1 — thanks for your question.

What the 1% users are exactly who will be affected by this.

The 1% deprecation described in Preparing for the end of third-party cookies refers to 1% of all Chrome Stable clients, where a "client" is a Chrome installation on a device. Each individual user data directory constitutes a distinct client.
The 1% will be randomly selected from all Chrome Stable clients globally, using the Chrome Variations mechanism.

To add to @samdutton's response; please note that if you're organization's users are on managed instances of Chrome, the administrator can opt users out of the 1% experiment by following instructions here.

Thank you for your response on this @krgovind @samdutton


Add remark to ControllerBase.File methods regarding stream disposal

Fixes https://github.com/aspnet/AspNetCore.Docs/issues/14585
Add a Stream disposal remark to each File method which accepts a Stream parameter. See https://github.com/aspnet/AspNetCore.Docs/issues/14585#issuecomment-535225187. The remarks will become visible on the API ref page.
/cc: @davidfowl

note: I grepped through ControllerBase and these 8 places are the only ones that take a stream. Controller doesn't have any additional methods like this so it looks like that covers it.

Looks good, thanks for including it 👍

@scottaddie could you try rebasing on master? There's a couple of build fixes that should resolve the error you're seeing.

@pranavkm Looks like we're good to go.

Thanks @scottaddie


[BUG] Standard User cannot import existing AKS cluster using terraform/rancher cli but works in UI

Rancher Server Setup

Rancher version: 2.6.9
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): AKS

Information about the Cluster

Kubernetes version: 1.23.8
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Imported/AKS

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Standard-user (Global role name: user)

Describe the bug

Cannot import existing AKS cluster into rancher using "Standard-User" global role using terraform provider or via rancher cli. However import is possible via web UI.
To Reproduce

Provision AKS cluster
Create local user in rancher with "standard user" global permission
Import the cluster via terraform or using cli

Result
│ Error: Bad response statusCode [401]. Status [401 Unauthorized]. Body: [baseType=error, code=Unauthorized, message=admission webhook "rancher.cattle.io" denied the request: Azure does not have opinion for this non AAD user. If you are an AAD user, please set Extra:oid parameter for impersonated user in the kubeconfig] from [https://rancher/v3/clusters]
Expected Result

Cluster should be imported into rancher
Screenshots

Additional context

Issue with fleet workspace name. Exisisting clusters should be imported without fleet_workspace_name
   name                  = var.cluster_name
   description           = "Imported cluster"
   enable_network_policy = true # Enable network Isolation between projects
   #fleet_workspace_name  = var.fleet_ws_name
   labels                = var.cluster_labels
   aks_config_v2 {
     cloud_credential_id = rancher2_cloud_credential.azure.id


bug: cannot drop database in influxdb 0.9

I'm running Influxdb from a docker ubuntu 14.04
If I try to delete the existing db 'mydb' from web admin I receive the success message: 'Successfully removed database: mydb' but the command SHOW DATABASES return a list containng 'mydb'.
When I try to delete the db from the shell this is the result:
root@19cc64b376f5:/# /opt/influxdb/influx -username 'root' -password 'root'
Connected to http://localhost:8086 version FIXME
InfluxDB shell 0.9.0
> DROP DATABASE mydb
ERR: remove /data: device or resource busy
Warning: It is possible this error is due to not setting a database.
Please set a database with the command "use <database>".
> use mydb
Using database mydb
> DROP DATABASE mydb
ERR: remove /data: device or resource busy
> USE test-db
Using database test-db
> DROP DATABASE mydb
ERR: remove /data: device or resource busy
> SHOW DATABASES
name: databases
---------------
name
dev-statistics
test-db
mydb
testdb

Regards
Gianluca

@rucka can you reproduce this error in 0.9.2?

Hi Michael,
yes I tried both 0.9 and in <IP_ADDRESS>.

On 29 Jul 2015, at 19:29, Michael Desa<EMAIL_ADDRESS>wrote:
@rucka https://github.com/rucka can you reproduce this error in 0.9.2?
—
Reply to this email directly or view it on GitHub https://github.com/influxdb/influxdb/issues/3496#issuecomment-126028672.

@rucka the error strongly implies that the mount point is unavailable or otherwise locked up.
Could there be a docker conflict preventing access to the /data directory? What are the results of ls -l for the /data directory?

Confirmed... Evidently if the DB has a non alpha-numeric character in it, influx will not drop the DB.  Attempts to escape it with , or enclose in single quotes fail as well.  This is not a docker install, VM w/ Influx.  *(Nightly build - 8/17)
Observe:

create database deleteme
drop database deleteme
drop database o3b-noc
ERR: error parsing query: found -, expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 18
Warning: It is possible this error is due to not setting a database.
Please set a database with the command "use ".
drop database o3b-noc
ERR: error parsing query: found , expected SELECT, DELETE, SHOW, CREATE, DROP, GRANT, REVOKE, ALTER, SET at line 1, char 18
Warning: It is possible this error is due to not setting a database.
Please set a database with the command "use ".

@kvesterling this behavior is expect. To create a database named o3b-noc it must be double-quoted (e.g. create database "o3b-noc"). See the documentation on identifiers

@rucka did you ever figure out if it was a mount point issue or not?

Seems to be a system-level issue, not one with InfluxDB. Closing.


Allows use of flow name instead of id in SDK

Describe your changes and why you are making these changes
This PR allows users to identify flows using the name instead of just an ID.
Related issue number (if any)
ENG 1738
Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

cc @vsreekanti For API changes


Only Compact works, Data Passing not working

I have the following controller.
This doesn't works.
$careers = Career::first();
return view("site::pages/careers/careers", careers);
(In Laravel, it working cool as expected. Not working on Laravel Modules)
This works:
$careers = Career::first();
return view("site::pages/careers/careers", compact('careers'));

Hi,
This isn't related to the package. Please refer to the php/laravel docs.

I'm sorry that. It works on core laravel. Not working only on your package. 👎

This package does not change how php works.

I use compact all the times in modules: https://github.com/AsgardCms/Platform/blob/3.0/Modules/Page/Http/Controllers/Admin/PageController.php#L62


Show "transparent background" texture in TextureEditorPlugin only behind actual texture

In addition, I added a border rectangle, which makes TextureEditorPlugin look better. Without borders it looks like it was shown in https://github.com/godotengine/godot-proposals/issues/11380
Preview for different themes:

Default theme
Light
Solarized Dark
Solarized Light
Black OLED
passivestar minimal theme

Tested also on tablet (relative small screen with highdpi) and smartphone (small screen with highdpi), looks good in all cases.
Closes https://github.com/godotengine/godot-proposals/issues/11380

Unfortunately I don't understand how to get this work properly :(
Using AspectRatioContainer is definitely not the right way to go. It worked only because textures I used had equal sides.

Unfortunately I don't understand how to get this work properly :( Using AspectRatioContainer is definitely not the right way to go. It worked only because textures I used had equal sides.

Looking at what you've already done it should pretty much work fine, you'd just need to update AspectRatioContainer.ratio accordingly at the beginning, and on Resource.changed signal for the texture being shown. Something like:
void TexturePreview::_update_centering_container_ratio() {
	centering_container->set_ratio(texture_display->get_texture()->get_size().get_aspect());
}

TexturePreview::TexturePreview(Ref<Texture2D> p_texture, bool p_show_metadata) {
	(...)
	_update_centering_container_ratio();
	p_texture->connect_changed(callable_mp(this, &TexturePreview::_update_centering_container_ratio));

@kleonc thank you!
But I this (setting ratio - but dividing width/height manualy) is what I tried to do after discovering I screwed up. Sorry I didn't fully describe the problem. The problem is that after setting proper ratio I get strange artifacts with ckeckerboard "background" - it is show outside texture of TextureRect.
I'll try again using get_aspect() directly.

Ok, now I love how it looks (again).
Ready for review (I hope) 🎉

TexturePreview is also used in Camera3DEditorPlugin and SubViewportPreviewEditorPlugin.

So this PR will also improve SubViewportPreviewEditorPlugin when transparent_bg is enabled:

before
after


Initial check-in of the migration notes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Isabelle Plante seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(fixer): add Prettier fixer (using Prettier-ESLint CLI) + docs

I did a PR to Prettier-ESLint (merged as v4) that made it exact mirror of the original Prettier CLI, so here i just use it for better integration.
If someone don't want it he can just use g:ale_javascript_prettier_executable = 'prettier' and it will use the original one.
Docs added too, adapted from ESLint fixer.

I just realised this is using prettier-eslint. We should use prettier instead, and then you can combine that with eslnit --fix yourself, if you want.

I like the idea of using prettier-eslint instead of just prettier.

Add both.

I have merged this via the command line now, and I've split it up into fixers for both prettier and prettier eslint, with separate registry entries and options.

Not make any sense. Because they are basically the same thing. One just have more better behaving which should be recommended to be used.

There are two, so you can use either. They have different paths in node_modules.


Multiple incorrect key bindings in VIM mode of the Editor

There are multiple incorrect key bindings in VIM mode that is not default to VIM keybindings.
The major one are

C-d is delete char (should be scroll down)
C-v is scroll down (should be visual block)
C-f is move cursor right (should be scroll forward)
C-b is move cursor left (should be scroll backward)

I noticed that all keys are the key that prefixed with Ctrl key, there might be issue regarding this.

Also, visual mode (activated with v) is exited when an arrow key is pressed.

Also C-a selects all text (it should increment a number). I am assuming that the functionality exists, but it is overridden because C-x is implemented and it properly decrements a number.


Websocket Article

Do we plan to explore further the idea of supporting a similar horizontal scaling for multiple Micronaut server instances for websocket? I think we mentioned this before, but not sure if we have a plan for it.

I think I will bring this up after the article is published.


Modify GitHub Workflows

simplify workflow name.
add trigger on workflow dispatch and simplify other triggers.
bump all actions to use latest version.
change output document name to proposal-ta.pdf.
add deploy badge in the README.md.

@LordRonz pls review and remove build-latex-document status check and branch to be up to date requirements


Link wren_test on MAC failed

$ cd wren-main/projects/make.mac/
$ make clean
$ make
...
Linking wren_test
ld: warning: ignoring file ../../lib/libwren.a, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x21 0x3C 0x61 0x72 0x63 0x68 0x3E 0x0A 0x2F 0x20 0x20 0x20 0x20 0x20 0x20 0x20 )
Undefined symbols for architecture x86_64:
"_wrenAbortFiber", referenced from:
_runtimeError in error.o
_badClassAllocate in foreign_class.o
...
$ uname -a
Darwin HSQdeMBP13L.local 20.6.0 Darwin Kernel Version 20.6.0: Wed Jan 12 22:22:42 PST 2022; root:xnu-7195.141.19~2/RELEASE_X86_64 x86_64
$ gcc -v
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Solved. It's caused by binutils.
The answer of A3F.


Add locale install in BEFORE_SCRIPT

Seems en_US.UTF-8 is also missing in the moveit2 docker image, as the warning shown in the CI report of moveit2. In order to suppress the locale missing warning, it is necessary to add locale installation commands - BEFORE_SCRIPT="sudo apt-get -qq install -y locales; sudo locale-gen en_US.UTF-8" when using moveit_ci.

Close this PR to open a new PR against upstream repository.


vyper: 0.3.0 -> 0.3.1

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 154444 run on x86_64-darwin 1

1 package failed to build:

python310Packages.vyper

1 package built:

vyper (python39Packages.vyper)

Now it won't build on x86_64-linux: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.vyper.x86_64-linux

BTW, the OfBorg builds in CI showed it already here.


Retry on failed deploy and destroy

Use Case
Because of the AWS Lambda resource that is configured in the VPC, it sometimes happens that the terraform apply and destroy commands fail. It would be nice if the vast-cloud command had some retry logic to be more robust to these failures.
Feature Description
Retry when terraform deploy/destroy fails because of the Lambda resource and apply "appropriate" wait time, but not in other failure scenarios.
Anything else?
No response

I'm closing this as stale; our experiment of using GitHub Issues has never really picked up, and our plans for this have changed since.


Amazon Managed Grafana support in Pulumi

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
Amazon GA'd Managed Grafana in the second half of 2021 - https://aws.amazon.com/grafana/
It would be great to add support for creating Managed Grafana workspaces with setup (e.g. option to add data sources, creating roles and policies, attaching appropriate policies to query data from different datasources etc) with Pulumi.
Pulumi currently supports creating Amazon Managed Prometheus workspaces, it would be great to close the loop on telemetry aspect of things by supporting Grafana as well!
Affected area/feature
E2E change?

This should be addressed as part of https://github.com/pulumi/pulumi-aws/issues/1865


python311Packages.zeroc-ice: <IP_ADDRESS> -> 3.7.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.zeroc-ice is: Comprehensive RPC framework with support for Python, C++, .NET, Java, JavaScript and more.
meta.homepage for python311Packages.zeroc-ice is: https://zeroc.com/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.7.10 with grep in /nix/store/h34hl8lgwbd8y91zqi15salxk0fw701q-python3.11-zeroc-ice-3.7.10
found 3.7.10 in filename of file in /nix/store/h34hl8lgwbd8y91zqi15salxk0fw701q-python3.11-zeroc-ice-3.7.10

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.zeroc-ice
python311Packages.zeroc-ice

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h34hl8lgwbd8y91zqi15salxk0fw701q-python3.11-zeroc-ice-3.7.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.zeroc-ice https://github.com/r-ryantm/nixpkgs/archive/a91e39c68fb02b23bf5d41070f2607ffbd50131f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a91e39c68fb02b23bf5d41070f2607ffbd50131f#python311Packages.zeroc-ice

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h34hl8lgwbd8y91zqi15salxk0fw701q-python3.11-zeroc-ice-3.7.10
ls -la /nix/store/h34hl8lgwbd8y91zqi15salxk0fw701q-python3.11-zeroc-ice-3.7.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.zeroc-ice
python311Packages.zeroc-ice

Maintainer pings
cc @abbradar for testing.

Merge conflict, please open a new PR.


Merge the classes

Right now the message classes are very much unorganised and duplicated classes it can be merged into one base class and sub classes can be inherited from it

I couldn't agree more, I also believe more could be added to this project


Feature Request: Add Testimonials Section

Description:
We need to create a new section on our website for user testimonials. This section will showcase feedback and reviews from our users, highlighting their experiences and the value they’ve gained from CodeHarborHub.
Tasks

[ ] Create a design for the Testimonials section that fits with the overall site theme.
[ ] Include space for user photos, names, and their testimonial text.
[ ] Implement the designed section on the homepage.
[ ] Ensure the section is responsive and looks good on all devices.
[ ] Test the section across different browsers and devices.
[ ] Ensure all functionalities are working correctly.

hi @Ajay-Dhangar i'd love to work on the frontend part of this

@Ajay-Dhangar I would like to work on this issue. Can you please assign it to me.


Search endpoint changed

Hello,
Search now returns 404, watching other fellow scrapers, it seems that that endpoint got changed to the GraphQL version too.

Hi, @codilau.
Thanks for issue. Endpoint updated in v0.4.0. User API not changed.
You can upgrade as:
pip install twscrape --upgrade


Install-Media folders on /Volumes

This a tricky one.
On error, sometimes the script leaves on /Volumes "Install-media" empty folders causing subsequent installs to fail.
I accidentally created an apfs volume instead of Journaling one and createinstallmedia prompts me right away that the installation could not continue because of wrong disk format.
It happens that this situation leaved an empty install-media folder in /Volumes
On next try your script was trying to write in the same volume "Install-Media" instead of "Install-Media 2" and I get the error again.
There's no possible way to make it work unless you manually delete the folders.
Possible fix, create something to unmount and delete all Install-media folders before

286 / 5 000
Résultats de traduction
Résultat de traduction
It's been working like this for 6 years and no one including me complains about anything
Use the program the right way
you open issues for things that don't really exist because since the ventura support everything works perfectly confirmed by several testers


[Event Request] page 501 "Available - Purchase Lines" - OnAfterOpenPage - Change Parameter ReservationEntry to "var"

We need to set some additional filters on ReservationEntry so please change it to "var".
OLD CODE:
[IntegrationEvent(false, false)]
local procedure OnAfterOpenPage(var PurchaseLine: Record "Purchase Line"; ReservationEntry: Record "Reservation Entry"; var ReservMgt: Codeunit "Reservation Management"; var ReservEngineMgt: Codeunit "Reservation Engine Mgt."; var CaptionText: Text)
begin
end;

NEW CODE:
[IntegrationEvent(false, false)]
local procedure OnAfterOpenPage(var PurchaseLine: Record "Purchase Line"; var ReservationEntry: Record "Reservation Entry"; var ReservMgt: Codeunit "Reservation Management"; var ReservEngineMgt: Codeunit "Reservation Engine Mgt."; var CaptionText: Text)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[BUG] Can't create reports

Describe the bug
Hi everyone!
I am facing problems with creating reports. Logs say that i have permissions errors, but it happens even with all_access role mapped, which makes no sense.
We use oidc to access dashboards.
This is the role for regular users:
{
  "osd-reader": {
    "reserved": false,
    "hidden": false,
    "cluster_permissions": [
      "cluster:admin/opensearch/observability/get",
      "cluster:admin/opendistro/reports/definition/list",
      "indices:data/read/mget*",
      "cluster:admin/opensearch/ql/datasources/read",
      "indices:data/write/bulk",
      "cluster:admin/opendistro/reports/menu/download",
      "cluster:admin/opendistro/reports/instance/list",
      "cluster:admin/opendistro/reports/definition/create",
      "cluster:admin/opendistro/reports/definition/update",
      "cluster:admin/opendistro/reports/definition/on_demand",
      "cluster:admin/opendistro/reports/definition/get",
      "cluster:admin/opendistro/reports/instance/get",
      "cluster:admin/opendistro/reports/definition/delete"
    ],
    "index_permissions": [
      {
        "index_patterns": [
          ".kibana_*"
        ],
        "dls": "",
        "fls": [],
        "masked_fields": [],
        "allowed_actions": [
          "write",
          "read",
          "indices:admin/create"
        ]
      },
      {
        "index_patterns": [
          "*"
        ],
        "dls": "",
        "fls": [],
        "masked_fields": [],
        "allowed_actions": [
          "read",
          "search",
          "get",
          "indices:admin/create"
        ]
      }
    ],
    "tenant_permissions": [],
    "static": false
  }
}

and it's rolemapping:
{
  "osd-reader": {
    "hosts": [],
    "users": [
      "osd-reader"
    ],
    "reserved": false,
    "hidden": false,
    "backend_roles": [
      "osd-reader"
    ],
    "and_backend_roles": []
  }
}

When i go to the saved searches, then to Reporting and there Generate CSV i get Insufficient permissions error in UI and that log on a master node:
[2024-05-06T08:58:18,251][INFO ][o.o.s.p.SecurityIndexAccessEvaluator] [master-1] No indices:admin/create permission for user roles roles=[
  osd-reader
    ipatterns=[
        indexPattern=.kibana_*
          dlsQuery=
          fls=[]
          perms=[indices:admin/mapping/put, indices:admin/resolve/index, indices:data/write*, indices:admin/create, indices:admin/mappings/fields/get*, indices:data/read*],
        indexPattern=*
          dlsQuery=
          fls=[]
          perms=[indices:data/read/msearch*, indices:data/read/get*, indices:admin/resolve/index, indices:data/read/search*, indices:data/read/suggest*, indices:data/read/mget*, indices:admin/create, indices:admin/mappings/fields/get*, indices:data/read*]]
    clusterPerms=[cluster:admin/opendistro/reports/definition/create, cluster:admin/opensearch/observability/get, cluster:admin/opensearch/ql/datasources/read, cluster:admin/opendistro/reports/definition/list, indices:data/read/mget*, cluster:admin/opendistro/reports/instance/list, cluster:admin/opendistro/reports/definition/on_demand, cluster:admin/opendistro/reports/definition/update, cluster:admin/opendistro/reports/definition/delete, cluster:admin/opendistro/reports/menu/download, cluster:admin/opendistro/reports/definition/get, indices:data/write/bulk, cluster:admin/opendistro/reports/instance/get]] to System Indices .opendistro-reports-instances
[2024-05-06T08:58:18,253][WARN ][o.o.r.a.PluginBaseAction ] [master-1] reports:OpenSearchStatusException: message:no permissions for [] and User [name=max, backend_roles=[osd-reader], requestedTenant=null]

The same happens with the all_access role, we just map it with our backend_role for admins:
  "all_access": {
    "hosts": [],
    "users": [
      "admin"
    ],
    "reserved": false,
    "hidden": false,
    "backend_roles": [
      "osd-admin"
    ],
    "and_backend_roles": []
  }

The error:
[2024-05-06T09:09:39,849][INFO ][o.o.s.p.SecurityIndexAccessEvaluator] [master-1] No indices:admin/create permission for user roles roles=[
  all_access
    ipatterns=[
        indexPattern=*
          dlsQuery=null
          fls=[]
          perms=[*]]
    clusterPerms=*,
  osd-reader
    ipatterns=[
        indexPattern=.kibana_*
          dlsQuery=
          fls=[]
          perms=[indices:admin/mapping/put, indices:admin/resolve/index, indices:data/write*, indices:admin/create, indices:admin/mappings/fields/get*, indices:data/read*],
        indexPattern=*
          dlsQuery=
          fls=[]
          perms=[indices:data/read/msearch*, indices:data/read/get*, indices:admin/resolve/index, indices:data/read/search*, indices:data/read/suggest*, indices:data/read/mget*, indices:admin/create, indices:admin/mappings/fields/get*, indices:data/read*]]
    clusterPerms=[cluster:admin/opendistro/reports/definition/create, cluster:admin/opensearch/observability/get, cluster:admin/opensearch/ql/datasources/read, cluster:admin/opendistro/reports/definition/list, indices:data/read/mget*, cluster:admin/opendistro/reports/instance/list, cluster:admin/opendistro/reports/definition/on_demand, cluster:admin/opendistro/reports/definition/update, cluster:admin/opendistro/reports/definition/delete, cluster:admin/opendistro/reports/menu/download, cluster:admin/opendistro/reports/definition/get, indices:data/write/bulk, cluster:admin/opendistro/reports/instance/get]] to System Indices .opendistro-reports-instances
[2024-05-06T09:09:39,850][WARN ][o.o.r.a.PluginBaseAction ] [master-1] reports:OpenSearchStatusException: message:no permissions for [] and User [name=max, backend_roles=[osd-admin, osd-reader], requestedTenant=null]

Parts with No indices:admin/create permission and no permissions for [] completely baffle me.

indices:admin/create is present everywhere but not considered?
How come that there is an empty tuple ([]) with permissions?

You can see the same behaviour when you go to Reporting directly from the left panel and click refresh.
Related component
Plugins
To Reproduce
There are two ways:

Go to 'Discover -> Open -> some saved search -> Reporting'
Click on 'Generate CSV'
See error

Go to 'Reporting'
Click on 'Refresh'
See error

Expected behavior
Reports are generated and downloaded.
Additional Details
Plugins
opensearch-alerting                  <IP_ADDRESS>
opensearch-anomaly-detection         <IP_ADDRESS>
opensearch-asynchronous-search       <IP_ADDRESS>
opensearch-cross-cluster-replication <IP_ADDRESS>
opensearch-custom-codecs             <IP_ADDRESS>
opensearch-flow-framework            <IP_ADDRESS>
opensearch-geospatial                <IP_ADDRESS>
opensearch-index-management          <IP_ADDRESS>
opensearch-job-scheduler             <IP_ADDRESS>
opensearch-knn                       <IP_ADDRESS>
opensearch-ml                        <IP_ADDRESS>
opensearch-neural-search             <IP_ADDRESS>
opensearch-notifications             <IP_ADDRESS>
opensearch-notifications-core        <IP_ADDRESS>
opensearch-observability             <IP_ADDRESS>
opensearch-performance-analyzer      <IP_ADDRESS>
opensearch-reports-scheduler         <IP_ADDRESS>
opensearch-security                  <IP_ADDRESS>
opensearch-security-analytics        <IP_ADDRESS>
opensearch-skills                    <IP_ADDRESS>
opensearch-sql                       <IP_ADDRESS>

Host/Environment:

Docker image: opensearchproject/opensearch:2.12.0
OS: Ubuntu 20.04.6 LTS

This may not be a bug, try asking on the public slack @maxemontio?
Catch All Triage - 1 2 3 4 5 6

@dblock we're have the same issue in 2.14.0 and this is definitely the bug. Could you please advise what's minimum permission required for "Generate CSV"?


druid

What's the relationship between Druid and caravel?
I'm trying to learn Druid. So I want to know what can I do with druid and caravel?
Thanks a lot.

What about reading the documentation? :)

Yeah that's a really vague question that would require writing a long essay to answer.
The short answer is Caravel allow you to query and consume data out of [amongst other things] Druid.
Please RTFM and ask more specific questions.


feat: added option to reset everything in cache

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: