Passing mutable data between isolates fails

Sending a MethodCall object to SendPort.send(Object? message) now fails for me. Googling brought up:
https://github.com/dart-lang/sdk/issues/50594
i.e. sending HashMaps between Isolates now fails, which is ironic because I get the MethodCall object from the system!  Let me explain...
When I return data from native code in our Flutter plugin, I have the option to send data to the UI isolate or to my background isolate (for compute-intensive, Dart-based processing). The background isolate then, typically, sends its output to the UI isolate.
I set up background processing by calling:
MethodChannel.setMethodCallHandler((MethodCall call) async ...
so the handler receives a MethodCall object (from the system) but its ‘arguments’ field is of a type (HashMap), which is no longer permissible for passing to another isolate (because it's mutable). We forward the MethodCall object from the background isolate to the UI isolate, using SendPort.send(Object? message) but that now fails, of course.
This problem was solved by converting the ‘arguments’ field HashMap to a JSON String (and appending other parameters, as needed), passing the String to SendPort.send(Object? message) and parsing the JSON in the UI isolate, processing that, from a performance point of view, I would much rather not have to do, of course.

Thanks for the report @JeffreyLawson
Can you please provide flutter doctor -v and a complete minimal reproducible code sample that shows the behavior ?


Add VV Checks

This wallet is Jack Butcher, the creator of VV Checks and Opepen. Can we add this collection?
bc1p8syvw72h69sw00cp083vu5kdpa6k54z3fapmn654vqsda7j5qpysrsh0ue
Proof: https://t.co/CN6OcDs9UV

Hi

Hi there.

please open a pull request with the metadata jsons in /ordinals-collections/collections/name-of-your-collection/meta.json and inscriptions.json . thank you

close issue. reason: @tallrooster needs to open a pull request, see comment above


Don't rebuild the API info for each snippet in docs

This speeds up the load time of docs pages with a lot of snippets. I used this page for testing: https://arcade.makecode.com/concepts/star-field
On my local machine it took ~6 seconds to fire the onLoad event before my changes and ~3.7 seconds after my changes.
We could improve this even more by using the same API info that the editor stores in the indexed db, but I didn't think it was worth duplicating all of that code in the embed frame. I might try to refactor it out later.

Ah, I didn't know it applied to all snippets. I'll remove the comment

Actually, with that in mind, we probably don't even need the map unless you want to future proof it in case someone adds single-snippet dependencies, right? The snippets should have the same deps always, so it just needs the one pxtc.ApisInfo

Yeah, I'll leave it as is for future-proofing


[Vue warn]: Invalid prop: custom validator check failed for prop "widget".

Bug Report

Package versions:
devexteme version: 18.2.6
devextreme-vue version: 18.2.6

Steps to reproduce:
Use  dx-toolbar-item in dx-popup
Set  widget="dxDropDownMenu"
Example:
dx-toolbar-item
widget="dxDropDownMenu"
:options="actionOptions"
location="before"
dx-toolbar-item

Current behavior:

Error message in console : Invalid prop: custom validator check failed for prop "widget".
Expected behavior:

Not error message in console
Screenshots:

@smallkite hi,
dxDropDownMenu is not a valid value for the widget option.
You can see all the accepted values here.
We're going to introduce the dxDropDownButton widget in the upcoming v19.1 It should be possible to use it as a toolbar item


Error when Migrate Tables - Production Server

Laravel Version: 5.5
PHP Version: 7.1.3
Database Driver & Version: MariaDB 14

Description:
Error running php artisan migrate:
In 2017_12_17_222406_create_sessions_table.php line 35:

  Cannot declare class CreateSessionsTable, because the name is already in use

Steps To Reproduce:
At local environment it does not happens, but in server it is showing this error. I check the CreateSessionsTable file I noticed it does not have a namespace, would that be the issue? Or I am doing something else (that I am not aware of) wrong?
Thanks!

@evertramos Laravel session driver class names in same class name so you can not create a class with the same name you can create migration in a different name to fix this issue

This repo is for bug tracking. Use the forums or slack channel for solving your issue

Do you have another migration that provides the class CreateSessionsTable?

@sisve I do not have another classname called CreateSessionsTable... In my local computer works just fine, when deploy to server I got this error...In local machine php version 7.2, main difference.

@Dylan-DPC It seems a bug, that´s why I posted here.

@pavinthan I am not trying to create this table, in fact I have a couple migrations file, which has nothing to do with this name neither sessions... this error occurs when deploy (php artisan migrate) the app in server.

@evertramos please try composer dump-auto and use this https://larachat.slack.com

@pavinthan thanks for your reply! I did a lot of tests and found my mistake...
I am making a docker environment for Laravel to comply with the Nginx Webproxy and in some of the script files I probably ran (by mistake) php artisan session:table and as it was on script it ran more than one time.
Thanks for your attention.

I had the same error message. This fixed it for me:

Go to "/database/migrations/"
Delete all files in the folder.
Do your "php artisan" actions (ex. "php artisan session:table").
Run your "php artisan migrate".


Forget PMA password & id

Hey, i have some troblem. I forget the password for login to PMA. Is that possible for me reset my pma password?
Thanks

Having trouble with auth in phpmyadmin. tried using the user/pass from wp-config.php and from .my.cnf, neither works. Is there a way to reset?

Guys please use community forums, a lot of people receive these Github bug notifications.

how about root db access - for schema - dbs including sqllitedb - etc.


How to copy file after Jigsaw built is complete?

I'm using the Github Pages deployment strategy from Jigsaw's documentation
As I'm using an apex domain (martinbetz.eu) and no subdomain (githubpages.martinbetz.eu), I need to have a CNAME in my build_production folder or I would get git issues when pushing (I'm not doing pull requests for the static site)
That's why I want to copy it from my source or root Jigsaw folder after the page was built with npm run production
I tried to add mix.copy('CNAME', 'build_production/CNAME'); to the webpack.mix.js, but that does not work
When I change the copy directory to something else (say: mix.copy('CNAME', 'test/CNAME');, it works
This might mean that the building process comes after Webpacks build script

How can I copy the CNAME safely after Jigsaw's built is done?

You can try using Jigsaw's build event listeners. If you have a file called CNAME in your project root, you can use the following lines of code in your bootstrap.php file:
$events->afterBuild(function ($jigsaw) {
    if($jigsaw->getEnvironment() === 'production') {
        $jigsaw->writeOutputFile('CNAME', $jigsaw->getFilesystem()->get('CNAME'));
    }
});

Yes, that's solves it.

🤦🏼♂ Or even simpler: Just copy CNAME to source/CNAME and let the build system do the heavy-lifting…


Failure to run tests on fresh checkout

I'm submitting a ...
[ ] bug report
[ ] feature request
[ x] question about the decisions made in the repository

Do you want to request a feature or report a bug?
no

What is the current behavior?
After checking out ng2-admin I attempt
npm test
And after building I get an error
05 08 2017 13:52:33.509:INFO [karma]: Karma v1.4.1 server started at http://<IP_ADDRESS>:9876/
05 08 2017 13:52:33.511:INFO [launcher]: Launching browser Chrome with unlimited concurrency
05 08 2017 13:52:33.610:INFO [launcher]: Starting browser Chrome
05 08 2017 13:52:35.609:INFO [Chrome 59.0.3071 (Linux 0.0.0)]: Connected on socket UzLq5pZArtAD3c3wAAAA with id 94099801
Chrome 59.0.3071 (Linux 0.0.0): Executed 0 of 0 ERROR (0.033 secs / 0 secs)
npm ERR! Test failed.  See above for more details.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

checkout code
run npm test

What is the expected behavior?

test should complete

What is the motivation / use case for changing the behavior?

to get the tests to work

Please tell us about your environment:
Ubuntu 16.01.
node v8.2.1
npm 5.3.0

Angular version: 4.1.3
Browser: Chrome 59.0.3071.115 (Official Build) (64-bit)

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Hope you resolved it, closing due to inactivity, please let us know if this is still a question.


Add dependabot config and update CI jobs

add dependabot config
update actions and use git hashes instead of tags as best practices

@jhillyerd please take a look when you have some free time, thanks in advance

Looks good, if this works well, we should add to the main inbucket repo as well, I've lost track of the number of times my releases have blown up due to old CI configs. :)

Looks good, if this works well, we should add to the main inbucket repo as well, I've lost track of the number of times my releases have blown up due to old CI configs. :)

Will do that 🙂


Polyfill fetch and AbortController

Added conditional polyfilling for fetch and AbortController to allow for abortable fetches.

 Polyfill abortable fetches


Reopen in Container says "\my\path\Dockerfile" does not exist

Does this issue occur when all extensions are disabled?: YES

VS Code Version: 1.66.2
OS Version: Windows 11 build 22610.1
WSL2 running Ubuntu 22.04
Docker: running docker in WSL (not Windows), version: Docker version 20.10.14, build a224086

Steps to Reproduce:

Open WSL2 terminal.
cd to project that has a Dockerfile that has worked for weeks as a container for the project.
Type code ..
When VSC opens, choose Reopen in Container.
-> VSC responds with this error:
"\home\me\code\project\Dockerfile" does not exist.

I've worked in this project for weeks without a problem, and this morning it is giving this error.  Interestingly, I notice the path separators in the error are Windows-style rather than linux-style.  Could something have changed to make VSC use the wrong path separators?
Incidentally this same project opens fine in a container on native linux installation (i.e. not WSL but actual Linux box) running Ubuntu 22.04 (same as WSL2).

This has happened to me twice dev containers leaves me in a scary state. I have to use a recovery container and push to a remove.
I can't copy and paste the error, because the 'retry' modal is blocking the UI.


Windows 11 22H2 not working

It doesn't work in this version. Is there another alternative method that I can do?

it worked for me.

Please specify which issue you have

win11 build 22621  , status : STATUS_IMAGE_CERT_REVOKED

Windows 11 Build 22621 Has revoked the certificate on the Intel Driver. You have to replace the vuln driver.

my build is 22621 and it worked for me. but I disable two things.

my build is 22621 and it worked for me. but I disable two things.

What did you disable?

@AhmedZero How to do ,please

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\CI\Config\VulnerableDriverBlocklistEnable
2.
Core Isolation
https://support.content.office.net/en-us/media/c6329cf1-09c5-4e16-25a3-625d79ac70b8.png

@AhmedZero How to do ,please

Is it worked for you or you don't test yet?

@AhmedZero How to do ,please

Is it worked for you or you don't test yet?

not tested yet

Is it worked? Because it worked for me 😄. I feel my PC is special case 😁.

It can be used

Is it worked? Because it worked for me 😄. I feel my PC is special case 😁.

It can be used

can someone confirm this

ok tested, kdmapper can work on windows 11 through turning off vulnerable drivers blocklist. HOWEVER, doing this stops any good games from loader, so a pointless fix

Is it worked? Because it worked for me 😄. I feel my PC is special case 😁.

its worked for me , thanks bro  , my build : 22621.2134


applet.interface.freq_counter: implement basic frequency counter

As discussed in #glasgow, this PR will implement a basic frequency counter, based on a ripple counter, paired with using the Glasgow's clock as a time reference.
This commit is work-in-progress:

Create FrequencytCounterInterface class
Convert input signal conditioning into generic gateware
Add clk_count command line argument, or possibly real-time duration
Clean up output

NOTE: This PR differs from #216 - that is providing more complex (but still basic) signal analysis, while this provides a pure frequency counter.

re aliasing:
With a ~44.1kHz input, we'll typically see one of the following two outputs over a 131072 clock period (@48MHz = 2.73ms).
1 LSB = ~366.211Hz.
edge_count=120
signal_freq=43945.312

edge_count=121
signal_freq=44311.523

re aliasing:

The ripple counter's length is essentially unlimited, right? (Limited only by FPGA size.) So you can make something obscenely large, like a 32 bit counter, and run it for a second or even several seconds. That's like averaging you suggested on IRC but with less work.

Yes, correct. I'm planning to make the sample period configurable at runtime, but with a default of 1-2 seconds to help improve this.


add commands to schedule charging

Add unimplemented features to tesla-control:
tesla-control charging-schedule [minutes after midnight]
activates daily scheduling at given time.
tesla-control charging-schedule-cancel
cancels the schedule - side effect: charging starts right away, when charger is connected.

Thanks!


Is there any option to replace unknown words using alignments of the attention mechanism

Hi, I have used OpenNMT-py and they have replace unk option that can replace unk words with words have highest attention weight (http://opennmt.net/OpenNMT/translation/unknowns/). Does fairseq have any option like that ?

Use --print-alignment (to give alignment scores) and --replace-unk (uses the alignment scores to replace the '' token). if your unk format differs change it in data/dictionary.py before preprocessing

When i used replace-unk option with fairseq-generate, it gave me this error

Traceback (most recent call last):
File "/usr/local/bin/fairseq-generate", line 11, in
load_entry_point('fairseq', 'console_scripts', 'fairseq-generate')()
File "/content/fairseq/fairseq_cli/generate.py", line 188, in cli_main
main(args)
File "/content/fairseq/fairseq_cli/generate.py", line 23, in main
'--replace-unk requires a raw text dataset (--raw-text)'
AssertionError: --replace-unk requires a raw text dataset (--raw-text)

Does i miss something ?

Use interactivate.py it does not run this check.

so it can't use with fairseq-generate ?

Yes

I use replace unk with interactive. It runs without error but it seem doesn't replace  with "Quang" (name)

Though I don't get unk in my output without/with giving the flags , even when one of the token is

Since I used de-en model output sentence is in English.
@myleott

@lengockyquang  @gvskalyan  did you find a solution to this?  I would also like my transformer output to NOT show  and replace it with the source token.

also interested.

Yes

Shouldn't --replace-unk be removed from fairseq-generate since it cannot be used? Is there another use case I am missing?

Use --print-alignment (to give alignment scores) and --replace-unk (uses the alignment scores to replace the '' token). if your unk format differs change it in data/dictionary.py before preprocessing

thanks

unk

I have a solution that replaces all the special characters and names to <unk>, then the model would learn to predict unk we just need one script to replace it by order maybe


Create add-to-app embedding integration test

There are already some in https://github.com/flutter/flutter/issues/24117
Ideally move to engine PRs

A partial easy work around as Jenn suggested could just be to transmit the bytes as a plugin if we can't figure out something more direct.

I think this was commented in the wrong issue.

Is this new integration test enough to cover this issue?
https://github.com/flutter/flutter/pull/39945


Support stable Rust

This doesn't make an example work, but the crate itself does compile.

tokio 0.2.0-alpha now uses beta  https://github.com/tokio-rs/tokio/commit/f48980ae525566c190c3cf6ba064a43c0e8c5507
Also tokio was recently updated to 0.2.0-alpha.6 and futures-core-preview to 0.3.0-alpha.19

Thanks for the help. This got resolved in #6.


Disabling Heartbeats

Currently trying to disable heartbeats in my ASP.NET Core 3.1 web application with the following code in my startup:
var aiOptions = new ApplicationInsightsServiceOptions
{
    EnableHeartbeat = false,
    EnableAppServicesHeartbeatTelemetryModule = false
};

serviceCollection.AddApplicationInsightsTelemetry(aiOptions);

var config = new TelemetryConfiguration(key);
var diagnosticsTelemetryModule = new DiagnosticsTelemetryModule();
diagnosticsTelemetryModule.IsHeartbeatEnabled = false;
diagnosticsTelemetryModule.Initialize(config);

From what I can tell after reading the documentation the top half of the code (adding application insights telemetry) should have been enough. This didn't work which lead to me google further into the issue which someone had suggested initializing the diagnostics module (although I'm not sure how that works since we aren't actually doing anything with the module after instantiation).
After doing this I now get this error message every time it tries to do the heartbeat in my traces :

AI (Internal): [Microsoft-ApplicationInsights-Core] [msg=Log Error];[msg=Heartbeat pulse being sent without valid instance of HeartbeatProvider as its state]

Is there some simple setting I've missed in my startup?
Version Info
SDK Version : 2.12.0
.NET Version :	Core 3.1
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) : Manual
OS : Windows
Hosting Info (IIS/Azure WebApps/ etc) : IIS

@tommy-ly The top half should be enough to disable heartbeats. I validated that it works. (i.e i can disable heartbeats)
Following is my full ConfigureService method in a .net core 3.1 app.
// This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddControllers();
            var aiOptions = new ApplicationInsightsServiceOptions();
            aiOptions.EnableHeartbeat = false;
            aiOptions.InstrumentationKey = "cijokey";
            services.AddApplicationInsightsTelemetry(aiOptions);
        }

Please share the exact snippet you are using and we can investigate further. Doing new DiagnosticsTelemetryModule(); is NOT needed and wont have the effect you desire.

Closing as correct solution is provided. Please reopen if there is a repro where the above is not working and we'll investigate.

Hi experts,
I encountered the same issues:

AI (Internal): [Microsoft-ApplicationInsights-Core] [msg=Log Error];[msg=Heartbeat pulse being sent without valid instance of HeartbeatProvider as its state]

and attached my AppInsights config below. Just wondering did I misused any config here? Thanks.
public static void AddAppInsightServices(this IServiceCollection services, IConfiguration configuration)
{
    services.AddSingleton<ITelemetryInitializer, UserInfoTelemetryInitializer>();
    services.AddSingleton<ITelemetryInitializer, FabricTelemetryInitializer>();
    services.AddSingleton<ITelemetryModule, EventSourceTelemetryModule>();
    services.ConfigureTelemetryModule<EventSourceTelemetryModule>((module, options) =>
    {
        module.Sources.Add(new EventSourceListeningRequest { Name = "XXX" });
    });
    var aiOptions = new ApplicationInsightsServiceOptions
    {
        EnableHeartbeat = false,
        InstrumentationKey = configuration["APPINSIGHTS_INSTRUMENTATIONKEY"]
    };
    services.AddApplicationInsightsTelemetry(aiOptions);
}

And my project config is shown below:
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
  <TargetFramework>net472</TargetFramework>
  <Platforms>AnyCPU;x64</Platforms>
  <RuntimeIdentifier>win7-x64</RuntimeIdentifier>
</PropertyGroup>

<ItemGroup>
  <PackageReference Include="Microsoft.ApplicationInsights" Version="2.11.0" />
  <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.8.2" />
  <PackageReference Include="Microsoft.ApplicationInsights.EventSourceListener" Version="2.11.0" />
  <PackageReference Include="Microsoft.ApplicationInsights.ServiceFabric" Version="2.3.1" />
  <PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
  <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" />
  <PackageReference Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.11.0" />
  <PackageReference Include="Microsoft.IdentityModel.Protocols" Version="5.4.0" />
  <PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="5.4.0" />
  <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
  <PackageReference Include="System.Net.Http" Version="4.3.4" />
  <PackageReference Include="Microsoft.AspNetCore" Version="2.2.0" />
  <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.2.0" />
  <PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="4.0.0" />
  <PackageReference Include="Microsoft.AspNetCore.Authentication.Cookies" Version="2.2.0" />
  <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.2.0" />
</ItemGroup>

@Nortown Nothing wrong in your code. There is a bug in the product which cases the Error log to be fired. The hearbeat is disabled, but the error log is produced every heart beat interval.
Reopening this issue and adding a fix for the same.

Closing. Will be available in 2.14


Inline code disappear

Hi, the theme looks really nice but the inline code didn't work and disappeared from html file.

I experienced same thing.
in the assets/js/002.js file line 17, you can see the following code:
		// IF YOU USE MARKDOWN AND YOU HAVE BEEN GETTING ONE ADDITIONAL LINE IN YOUR TAG CODE
		// UNCOMMENT THE SECTION BELOW

		/* MARKDOWN SECTION /**/

		select_f.splice(-1, 1);

		/* END OF SECTION*/

you can comment it
//		select_f.splice(-1, 1);

or like this:
		select_f.splice(0, -1);

In addition, you have to put below code:
		if (select_f.length === 1)
			continue;

like this:
...
	for (field in fields) {
		var num = 0;
		var select = fields[field].innerText;
		var select_f = select.split(/\n/);
		if (select_f.length === 1) // add this
			continue; // add this
		var tab = document.createElement("table");

		// IF YOU USE MARKDOWN AND YOU HAVE BEEN GETTING ONE ADDITIONAL LINE IN YOUR TAG CODE
		// UNCOMMENT THE SECTION BELOW

		/* MARKDOWN SECTION /**/
...

It is because number() makes the code into a form of code with number of line of the code. So you have to ignore it when code with one line.

I had the same issue and was going to open a separate issue, but then saw this.
This fixed it perfectly, Thanks! ✌😸


Allow testing another TypeScript version

I recently thought about this, and not sure if this is something we want. But I can assume that some people want to know if the type definitions work for TypeScript >=3.1.0 for instance.
I think it would be possible if we dynamically installed TypeScript depending on engines.typescript or something in package.json.
One thing to figure out though is that we need two private methods from within TypeScript which aren't exposed. I worked around this by shipping TypeScript myself with two extra manually added lines. So if we want to do this, we need to find a way to dynamically add them. Don't think it's impossible, just makes it a bit harder.
Don't think it would be a good idea to ship this library with 10 TypeScript versions 😂.

Which two private methods do you need?
I think it’d be a better idea to file a feature request on the TypeScript repository, rather than maintaining your own fork.

Definitely would like to see this feature, this is one of the main things we're looking to test. Would it also take into account typeVersions? Ideally, we would write a single test file, and verify that it worked for all of our supported versions of TS, including older type definitions if we needed to.

The idea would be to be able to set typescript: '>=3.2' and then it will test it for versions 3.2, 3.3, 3.4, 3.5, 3.6 and 3.7.

While I don't need this personally, I can see how it can be useful for some projects. However, I don't think you should bundle TypeScript versions. The default should also stay, that tsd always uses the latest minor version of TypeScript (non-bundled).

Yes, while bundling is the easiest solution, I don't want to do it either so I will explore the dynamic path.
I agree that the default should always be the latest minor version, 3.7 at the moment.

Couldn't you release all minor TypeScript-versions  as separate patched packages?
Something like @tsd/TestableTypeScript3.3 etc.
Then users could decide to install those they want to test against and provide them in a config file - tsd itself could always have the latest version as a dependency and use that per default.

What about @tsd/typescript‑3.3, or even @tsd/plugin‑typescript‑3.3?

Although releasing a custom typescript version might be a good idea, I don't think I would be able to keep up with releasing patches etc.
That path would be easier to do though then dynamically downloading a certain version, inserting code dynamically and running the tests... Although the latter would be much more maintainable from my side.

@ SamVerschueren would it help if I scripted a CI pipeline that would auto-release those packages using github actions or travis?
Would only require maintaining some .patch files (and those probably wouldn't change very often), as any other solution probably would, too :)

How is this done in tslint? I saw they can check against multiple typescript versions.
I'm also not going to use this feature in near future, but see this as very interesting and helpful, especially in a long run.

@SamVerschueren I was a little bored and followed up on my idea of automating this - take a look over here: https://github.com/phryneas/testable-ts/commit/6baa0ef9493e4f8ee5578f12f9081cd65639af50/checks?check_suite_id=373940820
Essentially, the repo has a github action that adds the isTypeIdenticalTo: isTypeIdenticalTo line to checker and renames the package to @testable-ts/v3.7 etc. for all recent versions from 2.5 to 3.7.
I explicitly chose the path of multiple versions as package names, as this will make it easier to install multiple of those in parallel - the npm: syntax is not available in all package managers afaik.
The whole thing is pretty low-maintenance - running ./makeVersion.sh 3.7.4 generates a patch for version 3.7.4 and spews out the lines that should be added to default.nix.
I'd be happy to maintain that repo to contain at least one version of every minor, which should be enough for testing.
The only thing I haven't done yet is actually publishing those packages to npm, currently they are only available as Artifact download from the github action.
Would love to hear your feedback (and if you need any additional methods exposed) before I take that step :)

Okay, now they're already published as -alpha.0 versions. I played around a little more and ended up with #62

Could you make the TypeScript version tsd uses pluggable? So like add a new CLI option --ts that allows the user to pass a path to their typescript install or something more dynamic (and probably similar to what you have proposed) would be if they specified a version number and tsd would fetch that version of typescript when executed (could use caching for subsequent runs).

This feature would extremely useful, especially given that TypeScritp drop breaking changes in minor releases, which makes it hard to be sure that a feature works well in different versions.

@SamVerschueren I've just found this package, and by its description, it looks like it could help with this issue, what do you think?
https://www.npmjs.com/package/byots

We're looking at the space for how we can validate our types across the Ember ecosystem, and while I'd prefer to use tsd, this issue is basically a hard blocker for us: one of our core constraints is that we need to be able to test published types against different versions of TS, so that we can maintain Ember's strong backwards-compatibility guarantees. I have bandwidth and can help dig in if there's interest in changing this!
Related: https://github.com/microsoft/dtslint/issues/284#issuecomment-627623063

Hi @chriskrycho, may I suggest you take a look at the expect-type package? I am personally planning to move from tsd to it.

That was super helpful, and we’re currently going exactly that way. It works extremely well. Thanks!

@delvedor It doesn't expose the isTypeIdenticalTo internals which we need.
@phryneas Your project looks very nice. I have a good idea on how we could set this up to allow us to spawn multiple tsd processes in parallel for different TS versions. Would you be interested in continueing the project and maybe automate it even more so that on every TS release, we also do a new patch release?

@SamVerschueren I've added version for 3.8.3 and 3.9.5. I wouldn't automate it much further as the autogenerated patches might not always be perfect going in the future if something is renamed.
But I've adjusted the script a little and now it comes down to me just running
./makeVersion.sh 3.8.3
./makeVersion.sh 3.9.5

and then sight-checking & committing the generated files. I think that's pretty effective ^^

Thanks to the work of @phryneas I am already able to do something like this.

In my type definition, I used the nullish coalescing operator which was introduced in<EMAIL_ADDRESS>The older versions report issues on that, which is pretty slick!
It still need some more work though. Let's say it still in proof-of-concept phase :).

I would love it if one could specify to use the TS version installed outside of tsd if one has such a one.
Then one could run tsd as part of something like: https://github.com/sindresorhus/type-fest/blob/951a21130bfbd3b605a0b28f9677fe1874653b5b/.github/workflows/main.yml#L23-L42
Would it maybe be possible to use import-local or something similar to achieve that?

@voxpelli the problem is that tsd requires a patched TS version...

@SamVerschueren did you ever upload that proof of concept to a feature branch or anything? I'd like to flesh it out and update it with @tsd/typescript.

@voxpelli the problem is that tsd requires a patched TS version...

FI: I created a hybrid solution unleashed-typescript for my vitest plugin, not ideal but it avoids maintaining a custom version of TS and it allows to have a version of TS synchronized with your environment. I think it's possible to modify it a bit to make several patched versions of TS cohabit, a kind of package manager dedicated to TS.


[dashboard edit] Sort by menu for adding chart need some consistency

Screenshot

Description
Need some consistency of the sort by menu for dashboard edit:
1, Format consistency: for example "Sort by Name" should be " Sort by name"
2, 'Vis' should be 'Viz'

@jinghua-qa Hi, I'd like to work on this issue, can you please assign this to me?


The meaning of "difficult_direct_answer"

Hi. I am wondering what the meaning of difficult_direct_answer in the json file is. I found that the evaluation code skipped examples whose difficult_direct_answer is False for the multiple choice setting, but it was never mentioned in the paper.

difficult_direct_answer means that there could be many ways to answer a question when not given choices (e.g. we can see significant diversity in the list of direct_answers already gathered). And so, it might not be correct to compute direct answer accuracy with our metric on these questions. Instead, we exclude them from evaluation in the direct answer setting.

Well, in line 14-15 of eval_predictions.py, the examples with difficult_direct_answer being True are excluded in the multiple choice setting instead of the direct answer setting, it that correct?
if multiple_choice:
    dataset = {k:v for k,v in dataset.items() if v['difficult_direct_answer'] is False}

difficult_direct_answer means that there could be many ways to answer a question when not given choices (e.g. we can see significant diversity in the list of direct_answers already gathered). And so, it might not be correct to compute direct answer accuracy with our metric on these questions. Instead, we exclude them from evaluation in the direct answer setting.

@apoorvkh Well, in line 14-15 of eval_predictions.py, the examples with difficult_direct_answer being True are excluded in the multiple choice setting instead of the direct answer setting, it that correct?
if multiple_choice:
    dataset = {k:v for k,v in dataset.items() if v['difficult_direct_answer'] is False}

Ah, looks like this file was out of date. Thanks for catching that, I’ve corrected it now.


20160621 add dynamo db stub

Really great that you included tests for the stub. Thanks!

Do you want me to push this out as an official release to maven central? Otherwise I'll probably procrastinate that. :-)


Update TileDB-VCF to 0.34.2

I recommend monitoring the builds post-merge to ensure that new binaries are uploaded. We are short on space on anaconda.org, so the uploads will fail if there isn't sufficient storage (https://github.com/TileDB-Inc/tiledb-vcf-feedstock/pull/136#issuecomment-2296962325).

I confirmed that the 0.34.2 conda binaries were uploaded


[near-operations-file] Import of main types sometimes added to queries where it isn't needed

Relates to #2137
This problem seems to be back in 1.8.1, or at least something related.
query {
  user {
    ...UserFragment
  }
}

Results in the Types import being added, even though it isn't used.
query {
  user {
    id
    ...UserFragment
  }
}

Also adds the Types import, but uses it.
This is problematic when typescript is configured to error on unused imports.

Would love to see this solved, as we cannot use this preset with noUnusedLocals: true in tsconfig.json. Removing preResolveTypes: true also works.
Workaround I landed on (inspired by OP) is to duplicate a field from the fragment that uses Types (something optional, meaning Types.Maybe is used).

It's a bit tricky because it effects other use-cases. We are trying to find the actual specific use-cases that causes that.
@SimenB @mvestergaard can you please share a reproduction?

This was "fixed" for us by #4194 injecting usage of Types.Exact

This resurfaced for us, btw. Weære back to adding dummy queries to work around it. I'll try to put together a reproduction

@SimenB sure, waiting for a reproduction. Thanks!

@dotansimha https://github.com/SimenB/codegen-extra-imports

@dotansimha reopen this, or should I file a new issue?

@dotansimha reopen this, or should I file a new issue?

New issue :)

#5094


[Bug] Tensor parallel hangs with LlaVA 34B

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug

I am using the LlaVA 34B model to generate captions for a large image dataset. I am running the pipeline with tp=8 on 8xV100 GPUs. It runs normally for some time, but nearly always hangs after certain number of batches (e.g., 1k~5k batches). nvidia-smi shows one GPU has 0% utilization.
Reproduction
pipe = pipeline('liuhaotian/llava-v1.6-34b', backend_config=TurbomindEngineConfig(tp=8))  response = pipe(input_batches)
Environment
sys.platform: linux
Python: 3.9.19 (main, May  6 2024, 19:43:03) [GCC 11.2.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1,2,3,4,5,6,7: Tesla V100-SXM2-32GB
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.1, V12.1.105
GCC: gcc (Debian 10.2.1-6) 10.2.1 20210110
PyTorch: 2.2.2+cu121
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 12.1
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.9.2
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=12.1, CUDNN_VERSION=8.9.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,

TorchVision: 0.17.2+cu121
LMDeploy: 0.5.1+124067b
transformers: 4.42.3
gradio: Not Found
fastapi: 0.111.0
pydantic: 2.8.2
triton: 2.2.0
NVIDIA Topology:
        GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    GPU6    GPU7    mlx5_0  mlx5_1  mlx5_2  CPU Affinity    NUMA Affinity
GPU0     X      NV1     NV2     NV1     SYS     SYS     SYS     NV2     PIX     PIX     SYS     0-23,48-71      0
GPU1    NV1      X      NV1     NV2     SYS     SYS     NV2     SYS     PIX     PIX     SYS     0-23,48-71      0
GPU2    NV2     NV1      X      NV2     SYS     NV1     SYS     SYS     NODE    NODE    SYS     0-23,48-71      0
GPU3    NV1     NV2     NV2      X      NV1     SYS     SYS     SYS     NODE    NODE    SYS     0-23,48-71      0
GPU4    SYS     SYS     SYS     NV1      X      NV2     NV2     NV1     SYS     SYS     PIX     24-47,72-95     1
GPU5    SYS     SYS     NV1     SYS     NV2      X      NV1     NV2     SYS     SYS     PIX     24-47,72-95     1
GPU6    SYS     NV2     SYS     SYS     NV2     NV1      X      NV1     SYS     SYS     NODE    24-47,72-95     1
GPU7    NV2     SYS     SYS     SYS     NV1     NV2     NV1      X      SYS     SYS     NODE    24-47,72-95     1
mlx5_0  PIX     PIX     NODE    NODE    SYS     SYS     SYS     SYS      X      PIX     SYS
mlx5_1  PIX     PIX     NODE    NODE    SYS     SYS     SYS     SYS     PIX      X      SYS
mlx5_2  SYS     SYS     SYS     SYS     PIX     PIX     NODE    NODE    SYS     SYS      X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

Error traceback
No response

We need more information.
Can you try something like this:
# since the vision model use pytorch, this env variable may help check is the error is happend in pytorch
export CUDA_LAUNCH_BLOCKING=1

# open lmdeploy info log, and when the program hands, please provide the log information.
pipe = pipeline('liuhaotian/llava-v1.6-34b', backend_config=TurbomindEngineConfig(tp=8), log_level='INFO')
response = pipe(input_batches)


Fix url not defined error and enabled virtualkey by default

Fix url not defined error in quit game,
Enable experimentalVK by default because it should works fine with all platforms to allow users to input by keyboard/virtual keyboard

As discussed via Discord, the changes have been integrated via other commits


Update user.js

TRR mode removals: https://bugzilla.mozilla.org/1552438
0105b (twice): disable-pref before url-clearing-pref
1405: you had the [-] url after the pref line

disable-pref before url-clearing-pref: ahh OK, I just always put these things in alphabetical order. I don't think it makes a difference - the prefs.js is also ordered alphabetically


where does blazor stand with web components?

reference : https://www.youtube.com/watch?v=7CUO7PyD5zA
web components aim to standardize the UI for web irrespective of how we do web development I just want to know whether brazor will be in sync to that so we can take advantage of that standardized web components and widges at one place, instead of being over whelmed by a lot of ways to build ui widgets.

However Blazor components are not themselves WebComponents, just like React components aren't WebComponents, and Angular components aren't WebComponents, and Vue components aren't WebComponents. The reason for this is that each framework provides its own distinct features and benefits.

Angular Elements are web components., and the reason they are part of Angular is that web components are part of the HTML standard and therefore recognized by the browser without help from any framework.
I don't see how parts of the HTML standard can be ignored by Blazor.

I too am interested in a feature similar to Angular Elements that would allow Blazor components to be 'compiled' in some way into native Web Components which can be easily shared amongst different projects that use different technologies for UI development. My company is only just now moving towards standardising to Angular as our UI but if Blazor could be used in parallel then we could switch to that without conflicting with other teams.

@SteveSandersonMS is there any support planned within Blazor for web components (both consuming and creating a web component in Blazor)? With the direction that React and Angular are going, Blazor will need to support the web component standard if it's to be a viable SPA alternative.

Looking more into web assembly, the problem seems to be that the current
spec has no provision for DOM access other than interacting with JavaScript.
Such a direct DOM API seems to be planned for a future version of the spec.
On Tue, Dec 25, 2018, 21:36 Nick Randolph<EMAIL_ADDRESS>wrote:

@SteveSandersonMS https://github.com/SteveSandersonMS is there any
support planned within Blazor for web components (both consuming and
creating a web component in Blazor)? With the direction that React and
Angular are going, Blazor will need to support the web component standard
if it's to be a viable SPA alternative.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Blazor/issues/828#issuecomment-449891060, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAoAqg_VHsYoWWYJA_FG7gY0Xy0YxeDmks5u8uCtgaJpZM4T8hWM
.

Maybe use Worker DOM as described at https://github.com/ampproject/worker-dom. Some maybe interesting techniques are described at https://www.loxodrome.io/post/easier-web-workers/. I could imagine caching Blazor WASM in worker and using something like COMLink to offload things (jointly with webcomponents) could become interesting.


Invalid sidebar.js created if outputDir has trailing slash

Describe the bug
I'm trying out the sidebar.js slice that's generated, but was hitting a problem when I try to use it.
[ERROR] Error: Invalid sidebar file at "sidebars.js".
These sidebar document ids do not exist:
- api//create-host-and-get-enrollment-code
- api//defined-networking-api
- api//delete-host

Available document ids are:
- api/create-host-and-get-enrollment-code
- api/defined-networking-api
- api/delete-host

Eventually I figured out this was because I had set outputDir in the docusaurus-plugin-openapi-docs options to docs/api/.
Expected behavior
I think the trailing slash could be stripped when generating sidebar entries, or an error could be thrown if a slash is detected.
Current behavior
Duplicate slashes are used in sidebar.js, which causes problems.
Steps to reproduce
Add a trailing slash to outputDir in a demo.

Available to test in canary release 0.0.0-558


Support for search of datasets published before a certain date (support for Citation Service)

As part of the evolving data citation concept and the support to access the subset of data, which were available at the time of data analysis, the data reference recommendation includes the information on latest dataset version or download date,
The recommendation for this information on the DOI landing pages, e.g. http://doi.org/10.22033/ESGF/CMIP6.2450 is:

Version YYYYMMDD
Please use the latest dataset version or if not available the latest data download date as version in your data citation.

This is currently supported by CoG in the further search option
To search All Versions with date constraints
A similar support for data published before a certain date is required according to the citation concept.

Metagrid does support date constraints in the search. If you go to 'Additional Properties' section, you'll see a 'Version Date Range' field which allows you to constrain the publish date. Maybe we can further highlight this in the guided tour so users can be more easily aware that it's there.


Make sure Google can see lazy-loaded content

I tried to run a test for my website as suggested in this link: https://developers.google.com/search/docs/guides/lazy-loading
by using a puppeteer script but the test results are: "Lazy images loaded correctly: Failed".
I then ran the test for the 2 demos provided in the docs, concerning the responsive images lazyload (srcset & with picture tag) https://www.andreaverlicchi.eu/lazyload/demos/with_srcset_lazy_sizes.html and the result was once again "Lazy images loaded correctly: Failed".
However, running the same test for the normal img demo (no srcset, no picture) the result was "passed".
Any idea what is wrong?

Hi @DimLeon,
I'm sorry that I'm so late in replying but I've been very busy in the latest days.
That's a good point, and a good question, thank you for asking it.
I didn't get what is the "normal img demo" that is correctly working, but I'll do some tests myself using puppeteer too. I'll keep you updated.

Hey @DimLeon,
I don't understand why, I did the following to test the "simple" demo...
node lazyimages_without_scroll_events.js -h --url https://www.andreaverlicchi.eu/lazyload/demos/simple.html

...and the results from puppeteer, which FAILED, says:
"If there are more images in the screenshot below, the page is using scroll events to lazy load images. Instead, consider using another approach like IntersectionObserver."
My objections:

the version of LazyLoad used on that page already uses IntersectionObserver
to check if the browser is a bot, I check the user agent for "googlebot" or "bingbot" which work in the real world but won't work using puppeteer

I copied the way of detecting a bot from LazySizes, which is the first script that the Google Developers page advices. :)
So help me out here, I don't understand what to do next to fix this issue.

I'm experiencing the same issues. I have ordinary img with data-src and elements with data-bg. Page doesn't pass Puppeteer tests.
i've tried:

v8.17.0 (it won't pass of course, but I tried)
v10.19.1
v8.17.0 / v10.19.1 conditional load
v10.19.1 with a polyfill suggested at Puppeteer output page.

It never passes🤷♂

Setting small dimensions (400 x 300) in that puppeteer script, I have yet to find a lazyload example (this or other libraries/script) that passes.
Medium articles pass -- however Medium articles also appear fine with javascript disabled entirely...
testing:
https://rawgit.com/GoogleChromeLabs/puppeteer-examples/master/html/lazyload.html
fails with the small viewport
which makes me wonder if the script is a good example;
puppeteer is creating a page and taking a screenshot of it in it's entirety - that function appears to not be  firing intersectionObserver (https://github.com/GoogleChromeLabs/puppeteer-examples/blob/59355609ecb3c2e396a289b28f34d5116fc89b8e/lazyimages_without_scroll_events.js#L131) ???
I think using a placeholder - actually having a src - is key to making everyone happy.
besides, not having a src isn't great for accessibility

Would you try with version 11.0.0?

Would you try with version 11.0.0?

I just tried this version and I fetched as Google my site. Only the first image shows.. but additionally Google ends up failing to even run masonry, so it's as if it runs into some error.
I'm also using srcset.  If I take out the data-src and data-srcset from my images, fetch as google loads fine and masonry runs ok.
I'm not sure what could be the issue. Does the LazyLoad() have to be run after document.ready() ? Or can it be called anywhere? I called it in right after loading the script..

Yes, DOM needs to be ready.
To be sure of that, you can put the script that create the instance of lazyLoad at the end of the <body> tag, just before it’s closing tag.
From the recently updated README (that I invite you to read and give feedback), especially the “Getting started” section:

Be sure that DOM is ready when you instantiate LazyLoad. If you can't be sure, or other content may arrive in a later time via AJAX, you'll need to call lazyLoadInstance.update(); to make LazyLoad check the DOM again.

Hope this helps!

Is there any case that JS might be disabled in the Chrome run by Puppeteer?

It runs @verlok as far i can see -- with the exception of when a screenshot is taken.
it's easy to replicate with chrome dev tools.

get a page with images loaded late (the puppeteer example works)
open dev tools
change the device to something small, like mobile
ensure caching is disabled and reload the page
without scrolling, print the page

the print preview is missing all the images which haven't been scrolled to; they don't show as they don't have a src set;

Thank you @dan-ding for your explanation, but that’s not the case because the LazyLoad script reads the user agent string and, if found to be a Bot like Google Bot or Bing Bot or others, triggers the loadAll() method immediately. So when a browser is visiting the page behaves differently from when it’s a search engine crawler.

Ya -- just trying to help(?) some understand what the puppet is doing.
I'm not a fan of the ua sniffing, however i'm not raising an issue with it.

I'm not a fan of the ua sniffing

Me neither, but I didn’t find another way to do that.
If anyone have any suggestions, you’re welcome.

This is the code LazyLoad uses to detect whether or not the browser is a bot.
export const runningOnBrowser = typeof window !== "undefined";

export const isBot =
	(runningOnBrowser && !("onscroll" in window)) ||
	(typeof navigator !== "undefined" &&
		/(gle|ing|ro)bot|crawl|spider/i.test(navigator.userAgent));

First of all, it checks if we're running on a browser, then if the browser has the onscroll function in the window object, and at last it tries to do "ua sniffing" to check if it's a crawler.
In my previous comment, I tested that code in the browser console and as you can see, if window.onscroll is falsy, isBot becomes true
Also other lazyload libraries use this same technique, so I guess this is working, but:

I cannot test this using Puppeteer
I'm not sure Puppeteer has the window.onscroll function empty, or if its user agent contains the google bot user agent.

Can you help me out with this?

@verlok i wanted to avoid the question of the UA as I understand why you put it in. It wasn't meant to be a complaint.
I have only one possible idea, but haven't tested it yet, so it may be useless...
Also -- the example puppeteer script does not set the UA to googlebot without modification.
I'll write up some better tests (since that example doesn't use the lazyload we care about ;) and get back to you

Thank you 🙏🏼

Google scrolls down just like any other browser. I am using another Jquery script that does not do any UA testing and Fetch as google was loading every image fully.
At least for Google, and probably major Bots, it is not necessary to check. In fact, Google will visit the website with multiple user agents, without announcing itself as Googlebot, just to make sure you're not cloaking your site or serving something that is different only to bots.
I should've tested this plugin better, but now the good fetch as Google tool that fetched the first 10,000pixels has been taken offline, and it's impossible to test lazy image loading any more, because the new tool only shows the first image. Very sad Google has chosen to do this.

Thank you for your contribution @otterslide. I really don’t know how to test this as Google.
Just to make it clearer, LazyLoad first checks if the onscroll event is present in the window object (if it isn’t, it’s likely to be a crawler), then checks if the user agent matches any bot using a regular expression (just in case). If one of the previous, load all images immediately.

Using the old Fetch as Google tool, this script was only loading the first
image for me, which was very odd. The new  fetch as google tool does not
scroll down at all so I cannot test any lazy loading scripts any longer.
I'd encourage everyone to click the feedback button in the webmaster fetch
as google tool and complain that the screenshot is too small.
Having said that, it is said that Googlebot uses Chrome 41. I tested your
demo page with Chrome 41 and it pre-loads all images right off the start,
so probably Chrome 41 doesn't have scroll events.
Unfortunately, I am finding that scroll event scripts are being deferred by
ad loading. The scripts initialize, but Google DFP ads somehow block the
entire script from loading anything until the ads are completely loaded.
Maybe they block the scroll event, not sure..  With IntersectionObserver I
am finding that this doesn't happen, and loading is quite a bit faster. I
also can use polyfill and even on Chrome 41 the images can be lazy loaded.
As you probably know, intersection observer runs in a separate thread as
well, which should be better for performance. I didn't want to open another
issue for this, let me know if I should, I'd be interested in your input on
the possibility of other scripts interfering with the lazy load script. I
only noticed recently because some ads were taking very long to load. It
would take a good 5-10seconds to start loading any image.
Thanks.
On Sun, Apr 7, 2019 at 12:51 PM Andrea Verlicchi<EMAIL_ADDRESS>wrote:

Thank you for your contribution @otterslide
https://github.com/otterslide. I really don’t know how to test this as
Google.
Just to make it clearer, LazyLoad first checks if the onscroll event is
present in the window object (if it isn’t, it’s likely to be a crawler),
then checks if the user agent matches any bot using a regular expression
(just in case). If one of the previous, load all images immediately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/verlok/lazyload/issues/277#issuecomment-480609353,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALHDl_EbEtXuwnnFZNZFIwsxFfQZsvbPks5veiISgaJpZM4Yyqxi
.

I believe I solved this issue tonight, it finally dawned upon me...
            new LazyLoad({
                elements_selector: '.lazy'
            })
            $('img').one('error', function(err) {
                $(this).remove()
            }).one('load', function() {
                $(this).addClass('show')
                $(this).attr('draggable', 'false')
                $(this).attr('src', $(this).attr('data-src'))
                $(this).removeAttr('data-src')
            })

@knoxcard thanks for trying comment.
It just seems to add two event listeners to each image,

the error handler removes the img element which causes the error,
the load handler loads the image in the data-src by setting it in the src

What does this kind of code solve?

Some conclusions i came up to:
I used the google's search console and made some url inspection for my website. (the old 'fetch as google').
Unfortunately, my lazy images are not shown in the screenshot preview.
However, when i made a google search of a random url of my website and clicked "view cached", the lazy images in the cached preview of that page were displayed properly. The cached page -as far as i know- is a snapshot of the page by googlebot and the content in that snapshot is the crawlable content by google.
In relevance to the above, some 'seo-related best practices' advise developers using image lazy-loading techniques to add a  tag including the .
Any thoughts on this or if this is indeed a good practice would be more than helpful.

@verlok - html standards require <img> tags to have a src attribute.

Some idea to check if user is a bot and load all images:
Very powerfull but heavy:
https://github.com/JefferyHus/es6-crawler-detect#readme
https://github.com/gorangajic/isbot
A faster version:
https://github.com/mahovich/isbot-fast

@verlok As stated in the PR for the puppeteer script (https://github.com/GoogleChromeLabs/puppeteer-examples/pull/30) that is referenced on the google docs, adding the UA to the script makes it work.
Even though, the results should always be interpreted by a human, since I used that for testing the site I'm working on right now, and the test "failed", but the images were almost exactly the same, with the exception that the images at the far bottom had a different opacity, which, in my case, means that they were the last ones to be scrolled and that their 1sec opacity animation was just finishing. Of course the script would not know that, but since those were the only pixels which had a variation, I can take that result as a good one nonetheless.
I'll ask our client if we can upload those images to better exemplify it, since it might be somewhat confusing haha.

Also, since adding the UA to that script made it work, I guess that the onscroll event and window object exists on that puppeteer script, which might not be exactly the same as when the googlebot crawls the site.
Also, the script supposedly should tell whether or not a lazyload approach uses scroll events or Intersection Observer API, but I'm guessing it's not working as expected, since this solution uses the IO API.
For the time being, I wouldn't worry too much about this.

Here's the picture of how it ended up

The script returned a Failed result, since there are lots of pixels highlighted in the diff, but I consider it a pass.

Thank you all!


[fix] Client key config not working + clone

Hi,
I just found out that I did introduce a little bit of a logic flaw in pr #4, which completely negated the entire merge.
This PR actually fixes that logic error, as well as implementing Clone for WebOsClientConfig and making the data in that struct public, so a crate like confy can be used to automatically load the configuration.

Thanks for the fix!


Linter for error message strings

Problem
We currently don't have a linter that checks for the guidelines in https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Error strings should not be capitalized
Error string should not end with punctuation

This leads to iteration cycles on nits in PR reviews.
Proposal
We should investigate if there exists a linter that can enforce these checks. If there is, we should enable it to remove nits in PR reviews.

revive#error-strings seems well suited for this.

It only works for trailing punctuation in error strings not capitalization of the first character: https://github.com/mgechev/revive/issues/733
Also it only works in error strings not panic strings.

It only works for trailing punctuation in error strings not capitalization of the first character: mgechev/revive#733
Also it only works in error strings not panic strings.

revive's string literal analysis could be applied to any parameter of any function. Please check the documentation


Pre-trained model

Hi!

Hi, I do not plan on uploading weights.

There is a model.model file in your repository.

Do I have to create a model of my own if I am using a personalized dataset.
How do I create the file (I mean, train the embeddings)

I am relatively new to the d-vector ecosystem here. Been only working with the i-vectors.


[msal-node] Add Auth Code with PKCE sample for msal-node

This PR adds an extended Authorization Code flow sample that shows how PKCE should be used with MSAL Node's public APIs.
For clarity, the sample does not implement PKCE code generation logic, that is left to the client developer.
The scope of this sample is limited to showing how one would add their PKCE codes to an authorization request made through MSAL Node.

Coverage remained the same at 83.384% when pulling 2546e2ae9ad4681e1f2789f7c231619e5b70a389 on node-pkce-sample into da2fda9c751b9d121ae16ea8a80e295162668cea on dev.


Issue 196 Merge Chevrons in README md

This pull request removes merge chevrons from the README.md and fixes the README.md to what was intended.   No code this pull request.

Thanks for catching this @larrydiamond


Proposal for static rewrite feature

Hi,
i want to discuss how we could implement a solution for the following feature:
If i deploy a single page application (like vue, react, etc) I want to redirect all non php routes routes to a single index.html page.
E.g. if the single page application generates a path /entity/$id/blah it should be mapped to /index.html internally to deliver the single page application. The single page application will then take care the path and route to the corresponding sub page within the single page application.
Currently the only way (known to me) to implement this is in Openswoole is:

Deliver index.html via http_index_files (will work for paths like / or /entity but not work for /entity/$id/blah)

Implement a custom 404 Handler in PHP which will deliver the index.html if path could not be found

A more elegant solution would be:

Possibility to define path prefixes that should be mapped to PHP, all other requests go to static handler (basically the opposite of static_handler_locations). This way i could for example only map /api to PHP space.

Some kind of "catch all" mechanic which allows me to map files to a single index.html internally. This could be done with internal url rewrites (i think it's too complex) or a custom configuration option, or perhaps a static file override for 404 error pages (but this might cause confusion, because it should be also configurable if the server should deliver a 200 or 404 in this case).

What do you think? Or am I missing something here?
Thank you for your time,
Julian

We think this should be implemented at the application layer.
You should be very easily to implement the following logics within the on('request') callback:

If the URL is not prefixed with /api, then $response->sendfile(__DIR__ . '/index.html')
Otherwise, go to the api application


[BUG]: Custom type is set to ZodAny when creating zod schema

What version of drizzle-orm are you using?
^0.26.1
What version of drizzle-kit are you using?
^0.18.1
Describe the Bug
I need to use custom type, to support nanoid, its just a simple postgres varchar data type with fixed length.
import { customType } from 'drizzle-orm/pg-core';

export const nanoid = customType<{ data: string; notNull: true }>({
  dataType: () => 'varchar(12)',
});

Lets assume this is my database table definition
import { pgTable, varchar } from 'drizzle-orm/pg-core';

import { nanoid } from './types/nanoid';

export const positions = pgTable('positions', {
  id: nanoid('id').primaryKey(),
  title: varchar('title').notNull(),
});

When I'm creating a zod schema from my positions table I can see, that id was set to ZodAny.
// const CreatePositionSchema: ZodObject<{
//   id: ZodAny;
//   title: ZodString;
// }, UnknownKeysParam, ZodTypeAny, {
//   title: string;
//   id?: any;
// }, {
//   title: string;
//   id?: any;
// }>
const CreatePositionSchema = createInsertSchema(positions);

I believe i can workaround this with refining the id field, but i don't feel that i need to explicitly set the type again for schema.
const CreatePositionSchema = createInsertSchema(positions, {
  id: (schema) => schema.id.pipe(z.string()),
});

Expected behavior
id is parsed as string to zod schema.
Environment & setup
No response

I've also tried to dig into createInsertSchema code and noticed that if the column is instance of DriverAny, then it's instantly set to z.any(). Can i rely on some properties from those classes to build different zod type or it requires some bigger refactoring?

check this out - https://discord.com/channels/1043890932593987624/1114275121851535431

@dankochetov That's exactly what I was looking for. Thanks! Should it be included in the documentation too?

@dankochetov Thanks for reply. Again this is not very convenient way to always specify the zod type. From DX side - i believe this should be done by create*Schema helper.

this actually forbids me from using drizzle

Could customType's param maybe leverage an optional schema or validation property?

@AndriiSherman I have implemented customNumberType<>(), customStringType<>() and customDateType<>() which mirror customType<>() but utilise additional ColumnDataTypes.
Specifically, I have added 'customNumber' | 'customString' | 'customDate' to ColumnDataType:
https://github.com/drizzle-team/drizzle-orm/blob/15ff6b49bff580b8f07077a044be4cb52ec17183/drizzle-orm/src/column-builder.ts#L9-L18
These ColumnDataTypes are then picked up in drizzle-zod to build the correct types in the Zod schema.
Let me know what you think of the approach. I have done a limited implementation for MySQL to suit immediate needs but from what I can see it would extend to the other drivers relatively easily. Happy to work on a PR and/or share my current patches.


tests/default_typeclass.x: remove spaces around as-pattern

I'm getting the following error when trying to run the tests with GHC 9.0.1:
ghc -Wall -fwarn-incomplete-uni-patterns -fno-warn-missing-signatures -fno-warn-unused-imports -fno-warn-tabs -Werror -package array -package bytestring  default_typeclass.n.hs -o default_typeclass.n.bin
[1 of 1] Compiling Main             ( default_typeclass.n.hs, default_typeclass.n.o )

default_typeclass.x:136:7: error:
    Found a binding for the ‘@’ operator in a pattern position.
    Perhaps you meant an as-pattern, which must not be surrounded by whitespace
    Possibly caused by a missing 'do'?
    |
136 |     s @ AlexState { alex_errs = errs } <- get
    |       ^
make: *** [Makefile:72: default_typeclass.n.bin] Error 1
/build/alex-3.2.6/dist/build/alex/alex  -g default_typeclass.x -o default_typeclass.g.hs
ghc -Wall -fwarn-incomplete-uni-patterns -fno-warn-missing-signatures -fno-warn-unused-imports -fno-warn-tabs -Werror -package array -package bytestring  default_typeclass.g.hs -o default_typeclass.g.bin
[1 of 1] Compiling Main             ( default_typeclass.g.hs, default_typeclass.g.o )

default_typeclass.x:136:7: error:
    Found a binding for the ‘@’ operator in a pattern position.
    Perhaps you meant an as-pattern, which must not be surrounded by whitespace
    Possibly caused by a missing 'do'?
    |
136 |     s @ AlexState { alex_errs = errs } <- get
    |       ^

Confirmed that the tests run successfully with this patch applied on GHC 9.0.1.

Thanks! :)

My pleasure!


Develop GUI for editing Role-Task-Priorities

The former Plan Designer offered some GUI for defining roles and their required capabilities for an agent to take over the role. Furthermore, the priorities of different roles to take over a certain task could also be defined in some GUI.
@ajahl would like to implement some more intelligent RoleAssignment for ALICA, so maybe you should ask him, how to implement this feature.

I talked to Alex: For the minimal working version we intend to create a simple table view including three columns: role, task, priority. Furthermore, we need an add and remove button to create new roles. The view will be very similar to the TaskRepositoryTab.
Note, that if you create a new role, it is inserted several times with another task each for each row. The Priority column is the only one editable.

Alex is only assigned to this ticket, because it has something to do with his thesis. @Schmidt1987 @MarcTellLindner  Feel free to assign yourself and implement this issue.

I want to implement it

you forgot to say please :)


test(api): unbreak tests

fixes #455

@ya7ya @angyangie This is mostly me cleaning up some crufty old code, but could I get y'all to take a quick look at the new stream.test.js and see if it seems like a reasonable way to do tests for this server? We're probably going to have to write a lot of these so I wanna make sure everyone's sold on the format 😃 https://github.com/livepeer/livepeerjs/blob/00a2c786ab0af55d4af732fa385ba6391555d430/packages/api/src/controllers/stream.test.js


fix(behavior_path_planner): getAvoidanceDebugMsgArray caused crash

this is due to the assignment to pointer without guards in the function
Signed-off-by: Muhammad Zulfaqar Azmi<EMAIL_ADDRESS>Description
The new getAvoidanceDebugMsgArray caused the behavior_planning container to crash.
This is caused by the lack of nullptr check during the clock assigment.
https://user-images.githubusercontent.com/93502286/165691762-eb062fb7-fad8-4467-851d-babe7d723002.mp4
How to review

place the ego vehicle start.
place the ego vehicle so that it run the lane change.
success if behavior planning container doesn't crash.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Result after the pointer check is added.
https://user-images.githubusercontent.com/93502286/165692560-9b117e19-1207-4db0-8d08-9d6bfcfbf4e1.mp4


Add category meta data to each token so that the user can view the loss of each category they define

Please refer to CONTRIBUTING.md for detailed instructions.
Summary

PR Checklist

[x] My PR is less than 500 lines of code
[x] I have added sufficient comment as docstrings in my code
[x] I have made corresponding changes to the documentation

[ ] I have written unit-tests to test all of my code

LGTM! Shall we also update the decode_hdf5.py to reflect the change?

Great idea I will do this


please don't trace Actuator endpoints in Spring Boot 2.0

please don't trace Actuator endpoints in Spring Boot 2.0. Right now, with M5 and Finchley and Spring Cloud Sleuth, it's tracing the /application/refresh endpint in Sleuth.

Fixed in https://github.com/spring-cloud/spring-cloud-sleuth/commit/11bd578738aaf510a76f6b5e78bf78f76741c16f

should this be updated to ignore /actuator/* as well?

Might want to ignore the root Actuator endpoint as well /actuator

care for a PR? ;)

After upgrading to spring-boot 2.0.2 and spring-cloud Finchley.RC2 I still see actuator health endpoint traces being sent to Zipkin. Could it be because we run the actuator end points on the same port and under the application context root (so something like /player-service/actuator/health)?
This is a snippet from the application.yml:
server:
  port: 8704
  servlet:
    context-path: /player-service

management:
  endpoints:
    enabled-by-default: false
  endpoint:
    health:
      enabled: true

Yeah, this is a very simple way of excluding actuator endpoints by just excluding whatever is there in /actuator/.*. There's an open issue for 2.1.0 to make it include context path.

Yeah, this is a very simple way of excluding actuator endpoints by just excluding whatever is there in /actuator/.*. There's an open issue for 2.1.0 to make it include context path.

Can you provide an example? I include 2.16-RELEASE and set my config properties to:
"management.endpoints.web-org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointProperties": {
"prefix": "management.endpoints.web",
"properties": {
"pathMapping": {},
"exposure": {
"include": [
"*"
],
"exclude": [
"/actuator/.*"
]
},
"basePath": "/actuator"
}
}

but httptrace continues to trace calls to the /actuator endpoints.

I don't understand what this means

but httptrace continues to trace calls to the /actuator endpoints.


JupyterLab does not show the plots. Is there any other extension we need to install for this to work on JupyterLab?

ehh, thanks for your feedback @ahmedahmedov and sorry for my late reply, I was not active in the past few months.
It is my bad, I will modify it a bit. Could you please try to add %matplotlib notebook in the same cell where you plot the figure, something like, and this also requires to have matplotlib installed:
%matplotlib notebook

from roughviz.charts import Bar

data = {
    "labels": ["North", "South", "East", "West"],
    "values": [10, 5, 8, 3]
}

bar = Bar(data=data, title="Regions", title_fontsize=3)
bar.set_xlabel("Region", fontsize=2)
bar.set_ylabel("Number", fontsize=2)

bar.show()

I will dig it a bit deeper to find an optimal way to tackle it.


Any chance to enhance sonarr-update-tba.bash if not running Sonarr in a container?

I'm new to Sonarr and have been running into some series with "TBA" titles and saw a post from you mentioning this script.  Unfortunately, I do not run Sonarr inside a container but locally on a Mac.  Wandering if you would be willing to remove the Docker dependency.  Perhaps if the .env file contained containers=("localhost") , you can set containerIp=<IP_ADDRESS> , remove the Docker prefix from the find commands done < <(find "${i}" -type f -name "* TBA *" and change the Sonarr config to $HOME/.config/Sonarr/config.xml?
Thanks

Yes, I can add this to my roadmap. I have a similar concept in another script that is not yet published as it's still in alpha testing, but I can port the idea over to the TBA script. The next two weeks are busy for me, but if I can't get it done immediately, I should have it done probably before the end of this month. I'll update when I push the commit.

Thanks. Much appreciated

Noticed you are performing 2 "finds" 1 for TBA and another for TBD .. You can combine them into 1 via -name "*TBA*" -or -name "*TBD*" or -regex ".*TB[AD].*"

Thanks for the regex tip, I'm moderately comfortable with regex, except for whatever engine find seems to use.
Sorry for the delay, it's been a busy month. I did some preliminary testing and as far as I can tell by taking a host-based Sonarr instance, I think the commit I'm about to push should add functionality for your situation. Let me know if it doesn't and I'll troubleshoot further.

No problem, I'd be happy to test it out.

Looks good reading the config files.  I don't have tba files to continue the test but assume at this point all necessary info has already assigned.  One point was it was informing me of an update, so proceeded with ./sonarr-update-tba --update which didn't seem to work.  Noticed on the case statement that it was checking for "-u"|"--Update", while the --help mentioned "-u"|"--update".
Thanks again for making the localhost change -Richard

Not sure how that capital letter made it in there, but thanks for letting me know, I'll fix that right now.
You're welcome. Just let me know if it doesn't work and I'll see what I can do about fixing it.


GetControllerState() broken only when new input system "takes over"

While I love what the new input system does for abstraction, modularity, and a bunch of other things, I do feel strongly that you should still be able to get inputs directly for certain situations. But that's being discussed in other threads.
I've written a class that reads input from the openvr API class, for my plugin where users need to get our code running straight out of the box regardless of their existing input settings (and ideally, regardless of whether they're using the old or new SteamVR plugin version). I've pasted the full class at the bottom, but the key part is:
if (system != null && system.GetControllerState(deviceindex, ref state, (uint)System.Runtime.InteropServices.Marshal.SizeOf(typeof(VRControllerState_t))))
        {
            ulong trigger = state.ulButtonPressed & (1UL << ((int)ButtonToCheck));
            if(trigger > 0L)
            {
                print(ButtonToCheck + " on " + Hand + " controller is down.");
            }
        }

(state is a VRControllerState_t, ButtonToCheck is of type EVRButtonID, and Hand is is a custom enum that's set to Left or Right)
If I load a new scene with this attached to a GameObject, pulling the trigger prints a message to indicate it's working as expected.
However, if in a scene where the new input system gets loaded (indicated by several console messages about loading the action file) then it no longer works. Specifically, the GetControllerState() fills the state with empty values.
More interestingly, though, is that if you go back to the first scene that worked last time and run it, it will no longer work. But then if you restart Unity and try again, it will work.
Ideally, I need a way to get GetControllerState() working, as the new binding system is not a good option for me - the only way I can think of to make it work "out of the box" is to add actions at runtime to the bindings I want (which I couldn't figure out how to do yet but I guess is possible) but that would also make it complicated to support users using the old version of your plugin.
But if that's not possible, I need a way to stop GetControllerState() from failing silently. My plugin doesn't reference anything that would cause the action system to get loaded, but a user might, and then they'd have no idea why their controls stop working. Is there a way to detect if the new action system has "taken over" so I can alert the user to set up a binding, or at least tell them where to look for a solution?
My full code below:
public class ForceControllerCheckSlim : MonoBehaviour
{
    public EVRButtonId ButtonToCheck = EVRButtonId.k_EButton_SteamVR_Trigger;
    public ControllerHand Hand = ControllerHand.Right;

    CVRSystem system = OpenVR.System;

    private uint deviceindex
    {
        get
        {
            ETrackedControllerRole role = Hand == ControllerHand.Left ? ETrackedControllerRole.LeftHand : ETrackedControllerRole.RightHand;
            return system.GetTrackedDeviceIndexForControllerRole(role);
        }
    }

    VRControllerState_t state = new VRControllerState_t();

    void Update()
    {
        if (system != null && system.GetControllerState(deviceindex, ref state, (uint)System.Runtime.InteropServices.Marshal.SizeOf(typeof(VRControllerState_t))))
        {
            ulong trigger = state.ulButtonPressed & (1UL << ((int)ButtonToCheck));
            if(trigger > 0L)
            {
                print(ButtonToCheck + " on " + Hand + " controller is down.");
            }
        }
    }
}

public enum ControllerHand
{
    Left,
    Right
}

Same problems here..
https://github.com/ViveSoftware/ViveInputUtility-Unity/issues/54
https://github.com/ValveSoftware/steamvr_unity_plugin/issues/128
Strongly suggest that letting GetControllerState and GetActionData both work at the same time.

Same issue here.. why is this update so confusing!!!

As for the Input System supporting both the new style and old style of input that would be a feature request for the OpenVR repo here: https://github.com/ValveSoftware/openvr/issues
One of the issues I'm seeing here is that you want to have a plugin that is able to carry existing actions into imported projects. I've added some basic support to this in one of the recent betas, you're welcome to take a look at that if you're still interested. It's under the SteamVR Input window -> Advanced Settings -> Create Partial Binding. This is in the beta version 2.2b1 of the plugin here: https://github.com/ValveSoftware/steamvr_unity_plugin/releases/tag/2.2b1

Hello @zite, in case it's not obvious, feel free to give me a ping or otherwise indicate that an issue report belongs in a different issue tracker and I can transfer them for you.

Ah yeah, I'll ping your name in the future, thanks!


Configure parallel integration tests

Description

This PR configures resource acceptance tests to run parallel to reduce the overall test duration.
Checklist

[x] added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

https://github.com/anexia-it/terraform-provider-anxcloud/actions/runs/2696666896 is probably unrelated, but I want to take a closer look before merging.

Let's call on monday re this PR

https://github.com/anexia-it/terraform-provider-anxcloud/actions/runs/2696666896 is probably unrelated, but I want to take a closer look before merging.

Couldn't reproduce this behavior. Doesn't seem to be an issue with our provider.


FUNCTION FOR PREFILLING THE EDIT GOAL MODAL

[ ] User should be able to see details of the goal he clicked already prefilled on the edit modal pop-up.

Testing link:
https://goals.zuri.chat/
Click on the edit goal modal button to view the already prefilled form modal by props from the redux store.


Update fixture tests to latest version

What is wrong?
The transaction tests in the JSON fixture tests have been updated to include versions that can be run against each set of fork rules.
How can it be fixed
Update the fixtures submodule to this commit:
https://github.com/ethereum/tests/commit/47b09f42c0681548a00da5ab1c98808b368af49a
Update the tests in tests/json-fixtures/test_transactions.py to configure the proper VM and run the tests against all of the VMs.  The state tests can serve as an example of how to implement this structure.

This was long done


tape.batch_jacobian gives different results if changing parallel_iterations

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 x64
TensorFlow installed from (source or binary): binary (pip install)
TensorFlow version (use command below): 2.4.1
Python version: 3.8.5
Bazel version (if compiling from source): -
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: -
GPU model and memory: -

Describe the current behavior
Using batch_jacobian with different values for parallel_iterations leads to differences in the output and the computational speed above the expected numerical errors.
Describe the expected behavior
Using tape.batch_jacobian should result in mostly the same outputs independent of parallel_iterations.
In my custom Code (which I did not provide) I encountered differences in calculation speed from 500 us for parallel_iterations = 3 up to 238 ms for parallel_iterations=8 without any pattern that could be related to the parallel_iterations.
I was able to reproduce this behaviour with a simplified version using tf.einsum as a function which provides a jacobian.
The error becomes zero when parallel_iterations >=16.
Standalone code to reproduce the issue
import tensorflow as tf
data = tf.random.normal((32, 16, 16))

def func(r):
    return tf.einsum("bij, bij -> bi", r, r)

@tf.function
def func_grad(r, p_it = 2):
    with tf.GradientTape() as tape:
        tape.watch(r)
        out = func(r)
    return tape.batch_jacobian(out, r, unconnected_gradients="zero", parallel_iterations=p_it)

def func_grad_no_parallel(r, p_it = 2):
    with tf.GradientTape(persistent=True) as tape:
        tape.watch(r)
        out = func(r)
    return tape.batch_jacobian(out, r, experimental_use_pfor=False)

def error_analysis(y_true, y_second):
    rmse = tf.sqrt(tf.reduce_mean(tf.square(y_true - y_second)))
    max_err = tf.reduce_max(y_true - y_second)
    print(f"RMSE: {rmse} \t MAX: {max_err}")

grad_out = func_grad_no_parallel(data)
for x in range(2, 24):
    print(f"Parallel iterations: {x}")
    jacobian_out = func_grad(data, p_it=x)
    error_analysis(grad_out, jacobian_out)
    %timeit func_grad(data, p_it = x)
    print('-----------------------------------')

Parallel iterations: 8
RMSE: 0.5038933157920837 	 MAX: 7.24960470199585
1000 loops, best of 5: 667 µs per loop
-----------------------------------
Parallel iterations: 9
RMSE: 0.3786795139312744 	 MAX: 7.24960470199585
1000 loops, best of 5: 1.13 ms per loop
-----------------------------------
Parallel iterations: 16
RMSE: 0.5038933157920837 	 MAX: 7.24960470199585
1000 loops, best of 5: 645 µs per loop
-----------------------------------
Parallel iterations: 17
RMSE: 0.0 	 MAX: 0.0
1000 loops, best of 5: 1.03 ms per loop
-----------------------------------

Other info / logs
I was comparing the computation of the jacobian with a persisent GradientTape and looping over the last dimension of my data to get the individual gradients. Without using the parallel_iterations the loop over gradients and the jacobian are identical, but computing the jacobian is up to 4x times slower. When using parallel_iterations it can get more than twice as fast but comes with large errors/differences to the gradient loop method.
I added some simplified version of this approach to the end of the gist as well. This is not directly related to the bug but I thought, that using the Jacobian would be more efficient than unstacking and looping over the Tensor.

import tensorflow as tf
data = tf.random.normal((32, 16, 3))

def func(r):
    r_mat = r[:, :, tf.newaxis, :] - r[:, tf.newaxis, :, :]
    return tf.einsum("bijk, bijk -> bi", r_mat, r_mat)

@tf.function
def func_grad_no_parallel(r):
    with tf.GradientTape(persistent=True) as tape:
        tape.watch(r)
        out = func(r)
    return tape.batch_jacobian(out, r, experimental_use_pfor=False)

@tf.function
def test_grad(r):
    with tf.GradientTape(persistent=True) as tape:
        tape.watch(r)
        out = func(r)
        out = tf.unstack(out, axis=1)
    deriv = []
    for frame in out:
        deriv.append(tape.gradient(frame, r))
    return tf.stack(deriv, axis=1)

tf.reduce_sum(func_grad_no_parallel(data) - test_grad(data))  # they are equal (without parallel_iterations)

%timeit func_grad_no_parallel(data)  # for this simplified version is still slower
%timeit test_grad(data)

You can find a GIST here

Was able to reproduce the issue with TF v2.3, TF v2.4 and TF-nightly. Please find the gist of it here. Thanks!

Thank you for the report. Looks like a capturing issue, where the gradient of the placeholder in the while_loop isn't recorded properly as being associated with the external tensor being captured. So tape.gradient returns None and the wrapper code crashes, or with unconnected_gradients="zero" it returns an incorrect result. The cases where the result is correct correspond to vectorized_map not using a while_loop.
I'll see if I can reproduce it with just a regular while_loop capturing a watched tensor.

Looks like this is actually because the tape needs persistent=True, since vectorized_map calls the function that computes gradients twice. I'll add an explicit error message, but in the meantime I'd use GradientTape(persistent=True) in your code for batch_jacobian(..., parallel_iterations=...). Sorry you ran into this.

Thanks a lot! Adding persistent=True solved all the issues I had.


request for JuggernautV9

Request to add https://huggingface.co/RunDiffusion/Juggernaut-XL-v9
Thanks

Sure!
Added in:
https://github.com/fofr/cog-comfyui/commit/67526c0a444d76037323328e0b3397b50f9411d1


feat(SNW-127): Change background color of components

Fields to manipulate background_color, title_color and body_color
These fields were added to all the components on the DynamicPageCreator collection, they are not required, if a color is not assigned it will render the default color on the site.


feat(GRO-1602): Progressive onboarding for alerts

Closes GRO-1602
https://user-images.githubusercontent.com/112297/227029456-4afe12f9-cb0c-410d-9753-935bcb3d2b7f.mov

Going to move this under it's own feature flag for two reasons:

I need to address the pointer center tracking on left/right positioned tooltips
We're going to be re-organizing the menus which will require some subsequent updates


Available points aren't updated to actually available points

Description
With the new version (8.5.8) the points accumulated over time while the page is open are not updated. Only re-loading the page displays the correct amount of points.
Console Errors
none
System (please complete the following information):

ESGST Version: Extension v8.5.8
Browser + Version: Chrome Version 77.0.3865.120 (Official Build) (64-Bit)

I'm almost positive this is the same issue as #1496.


Update Core.less and reset.less

(i've no idea how this got attached to "give dismisskeys a default", i apologize...)
Description
This PR focuses on changes on core.less and reset.less to make styling easier across the project, particularly around button elements.  The PR is actually a cherry-pick from the last commit on #3868, a commit that I wish I could benefit from right now rather than waiting on that one.
Currently, if you use a button in HB it gets styled like this, without any additional input from you:

All well and good when our site only has a few actual button elements, but a pain in the arse to unset all those properties if you want to use buttons in, say, a toolbar.
This PR changes the default styling of buttons so that they basically lose their user-agent properties, but otherwise leaves them stripped bare.  The current green default button is then assigned the mixin .colorButton() and given the same parameter.  So when you actually want that style of button, you can ask for it.
Publish button, without using the mixin:

(obviously the mixin will be used here, this is just for an example).
QA Instructions, Screenshots, Recordings
Check that any place you expect a button to be it is still styled as you remember it.

but a pain in the arse to unset all those properties if you want to use buttons in, say, a toolbar

.toolbar button { all: unset; } or .toolbar button { all: default; }


What happened to this page?

The page does not cover what it says in the title, and has not been updated since 2017. There seems to be no documentation on how to configure Exchange on-premises so that Teams can access a user's calendar.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20c0a619-c505-73a3-d815-58b384dc9a61
Version Independent ID: 78b91880-6d1e-a9dc-6099-7a0a15b96a4a
Content: Configure an Exchange hybrid organization - Microsoft Teams
Content Source: Teams/Exchange-hybrid-organization.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@Air-Git  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @Air-Git, thank you for your feedback and help us to improve docs.microsoft.com.
For information about how to configure Exchange on-premises so that Teams can access a user's calendar, please check the following article:
https://docs.microsoft.com/en-us/microsoftteams/exchange-teams-interact
If you're having trouble getting it to work, check out the following article:
https://techcommunity.microsoft.com/t5/exchange-team-blog/configuring-teams-calendar-access-for-exchange-on-premises/ba-p/1484009

Thanks. The How Exchange and Teams Interact document does not cover what's required. But the Exchange team blog published on 23 June covers the gaps. That's the only document I've found that describes accurately what you need to do to integrate the Teams calendar with Exchange on-premises.

@Air-Git, in summary, you need:

Exchange Hybrid (AAD Connect + HCW)
Mailbox located on Exchange 2016 CU3 or later

There are features that require additional steps:

Calendar delegation
M365 groups sync

I don't think this is strictly true. You need OAuth authentication between the Azure AD service principles and the on-premises Exchange and Skype for Business services. And you need inbound access to the Autodiscover and EWS services. Using the HCW is one way to get OAuth, but in fact for a long time the HCW failed to do this and you had to do it manually. If you do it via the HCW, you also get various services like the migration proxy, which obviously you don't need to get access to the calendar. Also, the HCW method only works if you choose the full classic hybrid. Teams cannot access the Exchange on-premises calendar if you use the Modern Hybrid approach, with the Hybrid agent, because this has no inbound access to the mailbox servers.

Hi @Air-Git,
It´s recommended that you configure OAuth using the HCW as the other article states:
"providing Exchange Server 2016 (Cumulative Update 3), or later, is running on-premises with OAuth configured (preferably via the Exchange Hybrid Configuration Wizard) as described in Configure OAuth authentication between Exchange and Exchange Online organizations"
Autodiscover and EWS services are a requirement in hybrid environments, for example, to have free/busy working or multi-search: https://docs.microsoft.com/exchange/hybrid-deployment-prerequisites
Group writeback is not a requirement for Teams access to the Exchange calendar.
In summary, to configure Teams calendar access for exchange on-premises "following best practices" you need:

Exchange Hybrid (https://docs.microsoft.com/exchange/hybrid-deployment-prerequisites, https://docs.microsoft.com/exchange/exchange-hybrid)
Mailbox located on Exchange 2016 CU3 or later

This reference to needing a hybrid is misleading and not accurate. There are five types of hybrid. Only one of the five will enable Teams calendar access to Exchange 2016 on-premises mailboxes.
The solution is that you need the features associated with a Full Classic Hybrid. This is not because you need the hybrid, but because that particular hybrid model uses the same features:

OAuth authentication relationship
AAD Connect Exchange hybrid option
Public access to EWS and Autodiscover
Mailboxes on Exchange Server 2016.

The Exchange Team Blog that you referenced is the only Microsoft document I've found that describes this accurately.

@Air-Git, yes, to configure OAuth you need to select a full hybrid option (Classic or Modern). We recommend that you configure it using the HCW, but configuring it manually is supported sure.

But Modern Full does not have the inbound access to Autodiscover and EWS. That's why I think the reference to Hybrid is a bit of a red herring. Only the Classic Full hybrid has those features. And you don't even need the hybrid. You just need similar configurations.
The Teams document hints at this, when it says that only the Classic Full Hybrid will provide access to the Teams calendar. Unfortunately, although it says you need EWS and Autodiscover, it does not explicitly say you need external/public/internet access to them. Many people have EWS and Autodiscover, but internally and not externally.

Modern full hybrid doesn't require autodiscover and EWS. You can have them or not. (Yes,  they are one of the reasons to use modern hybrid, avoid expose them to Internet)


Change to return array when converting an array

#12
:)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

That's merged, polished, and backported now.