👎Horizontal Scrollbar

I'm submitting a ...  (check one with "x")
[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
I don't understand why when I resize my table add  big scrollbar horizontal. Here you can see  gif...
I tried to recalculate() table whe resizing this event is fired but nothing change to my table:
@HostListener('window:resize')
  onResize() {
    this.table.recalculate()
  }

Expected behavior
I need my DOCUMENT column to have whole space  in the middle and when resize stop at [minWidht] PS:status column need to be as in GIF at the end like my GIF, this is OK
Reproduction of the problem
GIF

CODE

<ngx-datatable
      #myTable
      class='material expandable'
      [columnMode]="'force'"
      [rowHeight]="50"
      [scrollbarV]="50"
      [rows]='rows'
      (page)="onPage($event)">
      <!-- Row Detail Template -->
      <ngx-datatable-row-detail ....>

      <!-- Column Templates -->
      <ngx-datatable-column
                            [width]="70"
                            [resizeable]="false"
                            [sortable]="false"
                            [draggable]="false"
                            [canAutoResize]="false">...</ngx-datatable-column>

      <ngx-datatable-column name="Document (QrCode)"
                            [resizeable]="false"
                            [sortable]="false"
                            [draggable]="false"
                            [minWidth]="300" >...</ngx-datatable-column>
      <ngx-datatable-column name="Status"
                            [width]="90"
                            [resizeable]="false"
                            [sortable]="false"
                            [draggable]="false"
                            [canAutoResize]="false">...</ngx-datatable-column>
    </ngx-datatable>

What is the motivation / use case for changing the behavior?
only when resize because when I refresh page my resize are correct ! not when onResize

Table version:
"^5.0.0"

Angular version: 2.0.x
2.4.4

Browser:
chrome (last) and firefoy (last)

Language:
TypeScript

PS: Potential solution:

I juste checked width of <datatable-scroller> never changed when resize, so when I arrive on my page the width is correct but when resize window: width of this component is never updated. So I tried to ovveride this css to width:100% and it works, any idea?:

datatable-scroller{
  width:100% !important;
}

Had the same issue, and your workaround seems to work!
Thank you

Side note: That will only work if you don't have horz scrolling at all. So ideas it could be:

Scrollbar width calc? See: https://github.com/swimlane/ngx-datatable/blob/master/src/utils/scrollbar-width.ts
Column width calc - https://github.com/swimlane/ngx-datatable/blob/master/src/utils/column.ts#L46
Width distribution calc - https://github.com/swimlane/ngx-datatable/blob/master/src/utils/math.ts#L100

I think the problem is with the [scrollWidth]="columnGroupWidths.total" input of datatable-scroller. columnGroupWidths.total gets set when the columns of datatable-body are set, but isn't recalculated when calling this.table.recalculate().

@amcdnl I noticed, that it mostly happens for us when the app is initially loaded and I think it has something to do with the browser scrollbar. Something like this:

App gets loaded with a empty datatable (because the data is loaded from the server). The page is shorter than the browser height.
Data arrives and when setting the collumns, columnGroupWidths.total is calculated.
Angular renders the rows, which makes the page longer than the browser height -> browser shows a scrollbar, which decreases the page/datatable width -> columnGroupWidths.total is now wrong and datatable-scroller shows a scrollbar.

It also happens with a left sidebar, which has a css transition on the width to scroll in from the side. I tried to fix that by calling this.table.recalculate() after the transition ends, but as described in my previous comment, this doesn't recalculate columnGroupWidths.total.

I also have this useless scrollbar event when my content fit the size of the container. I also had to use the workaround:
.datatable-scroll { 	width: 100% !important; }

@amcdnl Here is a plunkr demo: http://plnkr.co/edit/rE92NBDkqxzComDLnaj6?p=info
On hover the datatable has a transition on width which makes it smaller. Also there is a transitionEnd event listener which calls recalculate() on the datatable, but has no effect. I would expect recalculate() to adjust the datatable to the new width.
To make it better visible, I added a border and overflow visible to ngx-datatable and a background-color to datatable-scroller.

this issue sucks, it is driving me mad

Guys, I found a workaround. It´s not pretty, but works.
The problem is that resizing the window makes the datable recalculate and then the datatable-scroll gets smaler then the datatable-row.
The idea to fix is when resizing the screen we copy the size of the row to the scroll. I had to use a setTimeout because the resizing of the row occurs after the resize of the window event.
Add this:
@ViewChild('datatable') datatable: DatatableComponent;
@HostListener('window:resize')
onResize() {
if (this.datatable) {
setTimeout(() => {
this.datatable.element.querySelector('.datatable-scroll').setAttribute('style', 'width:' + this.datatable.element.querySelector('.datatable-body-row').clientWidth + 'px');
}, 10);
}
}
}

+1

I was having the same issue. Bizarrely it didn't occur the same way over all browsers, for example Chrome in the mobile view didn't display the misbehavior. In any case, I was able to fix it by doing exactly what some workarounds here suggest; I added the following to the stylesheet for the affected component:
.datatable-scroll{
  width:100% !important;
}

I was having the same issue. Bizarrely it didn't occur the same way over all browsers, for example Chrome in the mobile view didn't display the misbehavior. In any case, I was able to fix it by doing exactly what some workarounds here suggest; I added the following to the stylesheet for the affected component:
.datatable-scroll{
  width:100% !important;
}

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

not stale.

not stale.

not stale.


Missing Fluid Texture with tinker Contruct

Hello, just realized that all molten ore textures (iron, copper gold and tin) are missing when Tinker construct is installed.
The tinker mod don't add any alternative molten ores for thos fluids.
Texture are missing on tank, crucible, bucket and JEI recipes but work when placed on world.
I haven't seen any missing texture report on logs.

Thank you for your bug report, I'll look into it.

Thank you :)

I've been unable to reproduce this issue with only Crossroads and Tinker's installed

Could you attach a full modlist? Simply sending me a startup log from the pack this happened in will have a modlist inside it.

Closed due to inactivity and inability to reproduce


Add awesome code review list

This list should help you to make awesome codereview (not depending on programming language).

Please read the contributing guidelines and the awesome manifest.

Thanks, but there's almost no content there. It's called "awesome" for a reason. Good lists takes a lot of work. Ping me here in a few months and I'll reopen and reconsider.


SIGABRT on tf.image.encode_png with empty tensor

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): gLinux (like Debian)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): tf-nightly-2.0-preview==2.0.0.dev20190807
TensorFlow version (use command below): v1.12.1-8193-ge7d48dc 2.0.0-dev20190807
Python version: 3.6.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: None

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
Calling tf.image.encode_png kills the process with SIGABRT if you pass
a tensor that has no elements.
Describe the expected behavior
It should never SIGABRT.
Code to reproduce the issue
import tensorflow as tf

image = tf.cast(tf.tile([[[0, 0, 0]]], [0, 0, 1]), tf.uint8)
# Or: = tf.cast(tf.reshape([], [0, 0, 3]))
try:
  tf.print(image)
  tf.print(tf.shape(image))
  tf.image.encode_png(image)
finally:
  print("We never get here!")

$ TF_CPP_MIN_LOG_LEVEL=1 python test.py
[]
[0 0 3]
2019-08-07 16:32:12.864303: F tensorflow/core/lib/png/png_io.cc:347] 'image' Must be non NULL
Aborted
$ echo $?
134

Other info / logs
This also affects tf.summary.image.

Issue replicating with tf-nightly-2.0-preview, please find the gist of colab.Thanks

Beginner here. Would like to work on this issue. Any leads?

@Soniyanayak51 check tensorflow/core/kernels/encode_png_op.cc, in Compute, just before the png::WriteImageToBuffer gets called, image.flat<..>.data() should be checked. It currently returns nullptr which then causes the abort.

Thanks for the reply. On it

@oanush: Not sure what you mean. Your Colab is not publicly visible, and
I can reproduce this in a fresh virtualenv:
$ cd "$(mktemp -d)"
$ virtualenv -q -p python3.6 ./ve
$ . ./ve/bin/activate
(ve) $ pip install -q tf-nightly-2.0-preview==2.0.0.dev20190807
(ve) $ python
Python 3.6.7 (default, Oct 21 2018, 08:08:16)
[GCC 8.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
>>> tf.__version__
'2.0.0-dev20190807'
>>> image = tf.cast(tf.tile([[[0, 0, 0]]], [0, 0, 1]), tf.uint8)
>>> tf.print(image)
[]
>>> tf.print(tf.shape(image))
[0 0 3]
>>> tf.image.encode_png(image)
2019-08-08 10:28:38.860641: F tensorflow/core/lib/png/png_io.cc:347] 'image' Must be non NULL
Aborted
(ve) $ echo $?
134

@mihaimaruseac
Sorry, I am stuck with running tests here. Any leads on how to test code easily before raising a PR?

I would build a pip package, install it in a virtualenv and test with the code to reproduce posted at the beginning of the issue.
See https://www.tensorflow.org/install/source for how to build the pip package.
Then, if that works, we can continue making this either a Python integration test or converting it to a C++ test.

Added a PR #33220 for the fix. /cc @mihaimaruseac please take a look.

Was able to reproduce the issue with TF v2.1 and TF-nightly i.e. v2.2.0-dev20200327. Session crashes in both the cases. Please find the attached gist. Thanks!

@amahendrakar there is no attached gist

@mihaimaruseac,
TF 2.1 - https://colab.research.google.com/gist/amahendrakar/855918e07fcb96fe091964a7b0c543be/2-1-template.ipynb
TF-nightly - https://colab.research.google.com/gist/amahendrakar/343256a8d0c24e08a95b050b90bc5942/tf-nightly.ipynb#scrollTo=ieAW-NK5iqpf
Here are the direct links. Could you please check if these work? Thanks!

Was able to reproduce the issue with TF v2.3 and TF-nightly

@wchargin I tried to reproduce the issue in TF 2.5 and the session is not crashing  but facing different error. Please check the gist here.Thanks!


ubuntu 16.04 freetype/build/autofit.lo' failed

Hi! i`ve followed instructions here (Documentation/VeloView_Developer_Guide.md) and got this after 'make'.
> `
> Library configuration:
>   external zlib: yes (pkg-config)
>   bzip2:         yes (autoconf test)
>   libpng:        yes (pkg-config)
>   harfbuzz:      yes (pkg-config)
>
> [ 23%] Performing build step for 'freetype'
> `

then after a while .. an error
/home/aprentis/build/common-superbuild/freetype/src/src/autofit/rules.mk:74: recipe for target '/home/aprentis/build/common-superbuild/freetype/build/autofit.lo' failed make[3]: *** [/home/aprentis/build/common-superbuild/freetype/build/autofit.lo] Error 1
What`s wrong? Any suggesions?

Hello,
This issue occurs when the SuperBuild Qt is used.  You should try to select the "USE_SYSTEM_qt5" option. We are aware of this issue and it should be fixed soon.
Regards,
Pierre Guilbert


Python function app linked with Azure Storage Blob continues to process deleted blobs

Package Name: azure.storage.blob
Package Version: 12.19.1
Operating System: Linux
Python Version: 3.11.8

Describe the bug
I'm encountering a discrepancy with my Python-based function app, which uses the azure.storage.blob package. Even after blobs are deleted and replaced successfully within Azure Blob Storage, the function app, when triggered automatically, does not recognize these changes. Instead, it continues to process the outdated, deleted blobs. Looking for help to understand and resolve this discrepancy.
To Reproduce
Steps to reproduce the behavior:

Upload a '.ctl' file to a blob within Azure Blob Storage.
Function app triggers and processes files, but encounters an error due to a typo in the uploaded files.
Employ the delete_blob() function to delete all related blobs.
Upload corrected files to the same blob.
The function app is triggered again by redropping the '.ctl' file, but reproduces the same error as if the files were never corrected.

(However, when running the function app locally - without the trigger, the updated files are processed correctly.)
Expected behavior
After removing and replacing the blobs using the delete_blob() function and uploading corrected files, I expected the Function App to process the new files and not continue using the old, deleted blobs.
Additional context
My initial assumption was that perhaps I was deleting the blobs incorrectly. In an attempt to remedy this issue, I incorporated the delete_snapshots parameter in the delete_blob function and tried to include various blob types such as 'deleted', 'versions', 'snapshots' in list_blobs() function. But, these attempts did not appear to make any difference as the Function App continues to process the old blob versions when triggered automatically. Moreover, when the code is executed locally (not through the function app), the problem doesn't occur because it doesn't detect any of the old files. Assistance on this matter would be much appreciated.
Code
def delete_blobs_in_directory(connection_string, container_name, directory_prefix):
    try:
        blob_service_client = BlobServiceClient.from_connection_string(
            connection_string
        )

        container_client = blob_service_client.get_container_client(container_name)

        blob_list = container_client.list_blobs(
            name_starts_with=directory_prefix,
            include=["deleted", "versions"],
        )

        for blob in blob_list:
            print(f"Deleting blob: {blob.name}")
            blob_client = blob_service_client.get_blob_client(container_name, blob.name)
            blob_client.delete_blob(delete_snapshots="include")

        print(f"Deletion complete for directory: {directory_prefix}")

    except Exception as e:
        print(f"Error: {e}")

Hi, I am actually experiencing the same:
Where the function-app, triggered by a BlobTrigger, reads a different (older) version of the content in blobstorage, compared to when executing the same code locally...
Not sure if this is part of the deletion function / execution, or a blobstorage issue, or some automagical cahching happens?

Hi @soniamuthi, we probably need a little more information to help here:

Do you have any of these features enabled on your Storage account: Hierarchical Namespace (HNS), Blob Soft-Delete (this is enabled by default), Blob Versioning, or use any snapshots?
Can you share an example of what your function app is doing specifically? Doesn't have to be your app code directly, just what basic operations you are performing.

Overall, your delete code seems fine, and a delete operation is atomic so if successful, the Blob should be deleted. You should not need anything to do with snapshots, versions, deleted unless you are using the features I mentioned above. In fact, when you include deleted in your call to list_blobs, you will get soft-deleted blobs if that feature is enabled which may not be what you want.


Celeste: make Rinkeby testing flow easier for users

Allow Garden users to test the whole dispute flow.

@fabriziovigevani will contact the test users to ask them if they can unstake from Celeste on Rinkeby so we can control the outcomes in future user testings.

Already asked a few and we now have 12 keepers. The other addresses activated could find them in the typeform list so i guess it's most of keepers directly requesting through Discord.
CurlyBracket made a good point when i requested him to deactivate his HNY, he pointed out what if another garden would also like to test asynchronously (that's their case for BrightDAO) and couldn't give him a better answer but to have a synchronous party like we did the other time for Celeste. Otherwise it's going to be difficult to ensure activated keepers that are online will be selected. We could also ask keepers that are testing the whole flow of gardens that when they are done, they deactivate their HNY.

Already asked a few and we now have 12 keepers. The other addresses activated could find them in the typeform list so i guess it's most of keepers directly requesting through Discord.
CurlyBracket made a good point when i requested him to deactivate his HNY, he pointed out what if another garden would also like to test asynchronously (that's their case for BrightDAO) and couldn't give him a good answer. We ended agreeing that we could have a synchronous party like we did the other time for Celeste. Otherwise it's going to be difficult to ensure activated keepers that are online will be selected. We could also ask keepers that are testing the whole flow of gardens that when they are done, they deactivate their HNY.

Thanks @fabriziovigevani
Having a synchronous party when a potential new Garden would like to test the whole flow sounds like a good option.


[26.x]WFLY-15525 JBeret: Make it possible to limit number of records retrieved via a JDBC store

Issues: https://issues.redhat.com/browse/WFLY-15525, https://issues.redhat.com/browse/WFLY-16040, https://issues.redhat.com/browse/WFLY-16066, https://issues.redhat.com/browse/WFLY-15565, https://issues.redhat.com/browse/WFLY-15728
Upstream: #14952
Based on the branch for #15278 just to avoid a later merge conflict.

@chengfang Please review


Virtual Fields (aka; Calculated Fields)

Virtual field allow adding a field to the GraphQL end point, as well as the Admin UI, which are not backed by a direct database field, but instead are calculated at request time based on either the result of the other requested fields, related fields, or external data.
Examples of virtual fields:

_label; a human readable short summary of an item
approvedPosts; A shorthand for:query {
  User {
    approvedPosts: _postsMeta(where: { status: 'Approved' }) {
      count
    }
  }
}

Could be implemented as a new Field Type:
import { Virtual, Integer } from '@keystone-alpha/fields';

keystone.createList('User', {
  fields: {
    approvedPosts: {
      // Use Integer's views, outputType etc.
      // But override all the functionality with the `Virtual` type.
      type: { ...Integer, Virtual },
      // Specify any data required to calculate this field.
      // Will be mixed into the graphQL query for getting this item's data.
      queryFragment: `
        _postsMeta(where: { status: 'Approved' }) {
          count
        }
      `,
      resolver: item => item._postsMeta.count,
    }
  }
});

Or, could be more explicit in setting views/outputType so it becomes the Virtual field's responsibility to take those options and mix them into the type correctly.
import { Virtual, Integer } from '@keystone-alpha/fields';

keystone.createList('User', {
  fields: {
    approvedPosts: {
      type: Virtual,
      views: Integer.views,
      outputType: Integer.outputType,
      // Specify any data required to calculate this field.
      // Will be mixed into the graphQL query for getting this item's data.
      queryFragment: `
        _postsMeta(where: { status: 'Approved' }) {
          count
        }
      `,
      resolver: item => item._postsMeta.count,
    }
  }
});

To describe a nested object type, may need to also allow overwriting getGqlAuxTypes().
Notes

To ensure the correct typing information for the GraphQL API, and also for the display aspect, we need to allow setting the GraphQL return type.
The field would be displayed in the AdminUI's list & details views

This display info is specified like any other field type; via views on the type (but set by options).

The field would not be displayed in the AdminUI's edit views
The field would show up in the GraphQL API's queries

The output type would be specified as an option.

The field would not be available as input to the GraphQL API's mutations

Todo

[ ] Implement #220: Optimize database queries to only pull out fields actually requested
[ ] Implement query dependencies (#1116 Enable _label field to specify its GraphQL dependencies)
[ ] Fix #487: encodeSortBy not working with non-virtual fields

Another approach for this would be to use read-only lists backed by DB views. This doesn't help at all for the _label use case but might be a much better solution in some cases.
A fairly trivial example:
keystone.createList('User', {
  fields: {
    name: { type: Text },
    dob: { type: Date },
    virtuals: { type: Relationship, ref: 'UserVirtual', many: false }
  }
});

// This is backed by a view, created by the app developer, that contains the required fields
keystone.createList('UserVirtual', {
  options: { isReadOnly: true },
  fields: {
    daysTillBirthday: { type: Integer },
    postCount: { type: Integer },
    quoteOfTheDay: { type: String }
  }
});

Callers can then query the calculated values by joining through to them in graphQL:
query {
  User {
    name
    virtuals: { daysTillBirthday }
}

And the underlying view can contain whatever kind of logic the DB supports including things like materialised views, when available.
Pros:

Should work on most (almost all) DBs (inc. Mongo which has views since v3.4)
Doesn't resolve/calculate the virtual fields unless they (any of them) are accessed
The "virtual" values are available at a DB level so can be reused in related systems (eg. BI dashboards, etc.)

Cons:

Requires DB support (although support is very common)
Requires the dev to create the underlying views manually (and keep the KS list definition in sync)
Requires "read-only" lists which we don't currently have (but should be pretty trivial to implement?)
As is, if any field on the related list is accessed it will cause all fields to be calculated (until we address #220)

This is kind of solution is complementary to other approaches. You could use a related, read-only list and the Virtual field type from Jess' example on the same list.

No reason these can't both be types 🎉

Yeah, at the extremes they solve very different problems -- for things like _label (#1116) you really want a Virtual type. On the other handhand, if you have a set of reporting views that power you BI dashboard or something, being able to access that data via it's relationship with the operational data can be very useful.
There are also a lot of use cases in the middle ground where either approach could be used; a set of "calculated" fields that can pull in data from elsewhere in the system and perform sophisticated transformation on it.
I've separate this "read-only list" solution (#1133) so as not to side-track this issue.

Any update on this?

This will enable lot more solutions to be built on Keystone. Any progress on this


Controls arrangement in interactive window options is unexpected on VS 2015

The "Use inline prompts" checkbox is not a valid option on VS 2015, so it's hidden.  So the page looks like this:

This page has been redesigned since this issue.


LayoutLMv3 has to depend on Detectron2?

I am using LayoutLMv3.
If I am not interested in the layout/object detection task, but only form recogniser and document classification tasks, could I be spared for the Detectron2 installation? It's hard to install on a VM without direct public internet connection and this installation will add unnecessary burden to our pipeline that's running everyday.

Hi, thanks for your question!
The current version of the unilm/layoutlmv3 implementation uses Detectron2 in the following two aspects:

To load images in datasets (e.g., FUNSD, CORD).
You can avoid installing Detectron2 (reference) by modifying the following codes
https://github.com/microsoft/unilm/blob/ca82fd4e5c7b0e4594eee33f8dd08388183787cd/layoutlmv3/layoutlmft/data/image_utils.py#L9-L10
https://github.com/microsoft/unilm/blob/ca82fd4e5c7b0e4594eee33f8dd08388183787cd/layoutlmv3/layoutlmft/data/image_utils.py#L21-L27
tofrom PIL import Image
def load_image(image_path):
    image = Image.open(image_path).convert("RGB")
    w, h = image.size
    return image, (w, h)

To support detection tasks.
The current version of the unilm/layoutlmv3 implementation has set detection=False, which does not use detection components. Removing all codes related to detection in modeling_layoutlmv3.py will also work. For example, @NielsRogge has removed is_detection logic in this PR.

@HYPJUDY
Your answer is really helpful! That's what I was looking for. Two follow-up questions:

After removal of this dependency, would it affect the accuracy of different tasks (form/receipt understanding, image classification, DocVQA)? If it is, do you have a metrics about how much accuracy will differ from the one on paper?

By reading the paper, my understanding is that adding Detectron2 is only to finetune and compare with other models on PubLayNet dataset, not a fundamental part of this layoutlmv3 for other tasks, right?

Thanks for your help!

I'm glad it helped.

The two snippet of codes should be equivalent, so switching from one to the other will not affect accuracy. I haven't verified this conclusion experimentally, but @NielsRogge's experimental results (e.g., FUNSD) support this conclusion.
You are right.

That's great to know. Also appreciate your insightful research work, which is the key enabler of our project. Thank you!

My pleasure : ) Good luck with your project!


Add ZodObject partial and required benchmarks

Add benchmark for ZodObject partial and required. Also adds a GitHub Actions workflow for running benchmarks against current master and PR HEAD so we can compare when looking at PRs.

Benchmarks take a looooong time, so I didn't want to merge this without a 👍 from you @colinhacks. Seems handy, but we could also just use a single 1x1 matrix instead of the 1x2 to reduce CI minute "spend".


Use web3 wallet private key as signature for document signing

Use web3 wallet private key as signature for document signing.

This would be done like a dApp. It would require a smart contract (maybe FVM or Stellar or Ethereum) that would allow the signer to sign the PDF that is already stored on IPFS.


https://developer.mozilla.org/zh-CN/docs/Web/API/HTMLElement/offsetParent

Request type
Translation Error
Details
Chinese Edition

English Edition

According to the official English document, if there is no positioned element, offsetParent is the nearest table, table cell or body, but the Chinese version is translated as the root element, the root element is html instead of body, is this translation wrong?

Yes, the translation is wrong. I jst tested this and rewrote the english version of the page to make it a bit clearer:
https://wiki.developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent


Feature/improve viz card

These changes improve the grid of My CW visualizations to enlarge the cards, add action buttons and make the graphs interactive. I've also created an embed page to visualize the graphs.
Besides that, I did a refactor on the ButtonGroup component to make it more flexible.

All the code is looking and working really fine 👍
The only thing that I would change is regarding the right padding on the line charts.
Because recharts adds a margin on the left of the line charts, to give space to the axis ticks, the chart gets to close of the right border of the card. Maybe we could add some right padding to the cards when displaying a line chart?

thanks for the work, Jorge, and thanks for the review, Javi! =) Merging.


Version 2 Design Considerations

Following the presentation and discussion at / after ISMIR2014, a variety of ideas have been flying around regarding next steps and possible improvements to JAMS:

"Group-by-task" versus "explicit typing", or somewhere in between
Namespaces for interpreting the meaning of observations
"One general type with conditional validation" versus "Many specific types with singular validation"
How, if at all, should this interface with linked data?
How, if at all, should this be influenced / consistent with the MPEG-7 specification?
What is the value / goal of readability in the raw JSON?
JAMS Quick Look: "Text editors" versus "specialized tools"

These are the high-level ones, and I'd like this issue to simply sponge topics for posterity; each individual topic should probably be broken out as separate conversations.

Now would probably be a good time to circle back on this thread, since the pandas branch is nearly stable.

"Group-by-task" versus "explicit typing", or somewhere in between
Namespaces for interpreting the meaning of observations

I think the latter (namespaces) now solves the former (grouping).  We now have a single flat annotation list at the top level, no grouping, but each annotation specifies its namespace.  The query engine makes it possible to slice out annotations by "type", essentially creating groupings on the fly.

"One general type with conditional validation" versus "Many specific types with singular validation"

Validation is now a two-stage process.  The JAMS schema specifies a single annotation type, and does not interpret the values.  Namespace schemas provide the validation functionality within an annotation.
As a concrete example, all annotations are now arrays of (time, duration, value, confidence), and this is enforced by the JAMS schema.  The JAMS schema also requires that time and duration be sane (non-negative numbers), but provides no checks for value or confidence, which is the job of the namespace validator.

How, if at all, should this interface with linked data?

I think the identifiers sandbox in the metadata does a sufficient job of this, without getting bogged down in the details or providing explicit hooks for every possible linkage.
There might be some opportunities for expanding namespaces in this direction.  I'm thinking specifically for tag vocabularies, it might be useful to have a way of linking/aligning across different namespaces.

How, if at all, should this be influenced / consistent with the MPEG-7 specification?

Anyone more familiar with mpeg-7 want to chime in?

What is the value / goal of readability in the raw JSON?

It's nice to have, but shouldn't be our main requirement.  FWIW, I find https://github.com/marl/jams/blob/pandas/datasets/SMC_MIREX/SMC_001.jams to be totally readable, if a bit more verbose than the original lab file(s).

JAMS Quick Look: "Text editors" versus "specialized tools"

There are loads of json editors out there, and some even accept schema!  Check out http://jeremydorn.com/json-editor/ (https://github.com/jdorn/json-editor)  I bet it wouldn't be hard to fork that one to do dynamic namespace validation as well.


Convert (most) logging statements to use pre-defined logging targets

In #1469 we've introduced a set of pre-defined logging targets, to make log filtering more stable and useful. (PR)
While a good start, there's still plenty of code that could use going though it and adjusting target:s.

Thx for the reminder, totally forgot about that in client-ng :see_no_evil:


How I stop console logging when foreign object redendering is true

How I stop console logging when foreign object redendering is true
I have set logging as false and foreign object redendering as true in config
But It logs messages in console related to foreign object rendering.
How do I prevent it
Specifications:

html2canvas version tested with: "^1.0.0-rc.3",
Browser & version: All
Operating system:MacOS

This is duplicate of issue #1874.

@FineStrokes  Okay, I would suggest you to take this JS and use it as a script in your angular project. then u will be able to edit it and comment the console. fixed for me.


Make use of the common spelling of heterogeneous/homogeneous.

This switches all the "heterogenous" to "heterogeneous", and
all the "homogenous" to "homogeneous" the latter versions
being the more prevalent and common spellings

Codecov Report

Merging #3012 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   85.69%   85.69%
=======================================
  Files         327      327
  Lines       68788    68788
  Branches     7798     7798
=======================================
  Hits        58947    58947
  Misses       8596     8596
  Partials     1245     1245


Update README.adoc

@objectiser could you please review?

Please squash commits before merging.

Squashed and merged.


Fixing JSON errors in README.md

Running gulp bundle will not run, if these errors not fixed.

@shytikov Thank you for contributing this pull request! We're truly excited and honored to have you as a member of our community. We look forward to working together with you to further build the Aurelia platform.
We noticed that you haven't yet signed our CLA. We would appreciate it if you would consider doing that for us. Before signing, please take a few minutes to read our contributing guidelines. These guidelines will help get you up to speed on how our community likes to operate and how the pull request process works. Once you have read that, assuming you are in agreement, simply sign our online CLA.
After you've signed, please ping this issue to let us know and we'll get your improvements merged in.
Thank you again!
The Aurelia Team

Closing this since we re-orgnaized readme to point to official docs.


reproduction: function from JS being passed to native and called in worklet

Main reproduction can be observed here:
https://github.com/margelo/react-native-worklets-core/blob/b65e07e5a5c51fc1b428755a39bd5f40d7d2121a/example/src/App.tsx#L18-L34
I wasn't able to reproduce the exact same error with pure JSI.
So I brought in our HybridObject and JSIConverter class and tried to reduce it to the minimal code needed to reproduce.
This is the error I am getting when calling callJSCallback:

It seems to me that the problem here is that you are passing a Javascript function to a jsi::HostObject and then try to call directly it from another thread on a secondary JS runtime. This will not work, since a Javascript value must be created, used and deallocated on the same thread and in the same runtime.
The way RNWKC solves this is to take the text generated by the Babel plugin representing the function and create a new function when installing the function in another thread. Just using / passing the function object itself will never work (until Hermes or JSC creates a specific API for doing so).
In the example you are doing the following:

Create a new jsi::HostObject testObject
Pass it a regular javascript function object while being on the default JS runtime/thread
Call that same Javascript Function from another thread on another JS runtime (runOnWorklet)

This is not currently possible or legal in any available Javascript engine.
To solve this use case you need to handle the initial function as a worklet - ie. make sure the Babel transpiler can convert it to a worklet (remember - a worklet is a key/value based textual representation of a JS function. In addition the HybridObject classes would need to be able to understand that the function you pass is a worklet (it does not know about this now) and handle it using RNWKC on the C++ side.
Again, let's try to describe the use case for passing the function like you do - and then see if we can come up with a solution.


License

Please consider adding a license information to the repository.
P.S. The visualization tool is really great!

https://github.com/jakebian/hera/blob/master/LICENSE


Scala compilation with sbt/zinc

Gradle currently supports Scala compilation with the typesafe/zinc-compiler, which is in maintenance mode.
However, new development is now ongoing under sbt/zinc. It would be great if the scala-plugin could support this new initiative that is actively further developing Scala compilation.

sbt/zinc includes much improved incremental compilation:
This depends on some factors such as how your classes are organized, but you can see 3x ~ 40x improvements. The reason for the speedup is because it compiles fewer source files than before by untangling the classes from source files. In the example adding a method to scala/scala’s Platform class, sbt 0.13’s name hashing used to compile 72 sources, but the new Zinc compiles 6 sources.
https://developer.lightbend.com/blog/2017-04-18-sbt-1-0-roadmap-and-beta1/#zinc-1-class-based-name-hashing
Also, my understanding is that there is/will be a supported Java API.

Maybe this should be put in it's own ticket, and probably thought of already, but I just wanted to say that it would be absolutely brilliant if this also utilised the new worker api for parallelism within the same project!

I checked if I could do a quick update to sbt/zinc and run it through our test pipeline. Unfortunately the API seems to be quite different compared to typesafe/zinc. So it is not only a matter of changing the namespace.
If anyone here is more familiar with sbt/zinc and would be willing to provide a PR, I will happily review and merge it.
The integration is encapsulated in ZincScalaCompiler.java and ZincScalaCompilerFactory.java. Ideally we would only need to adjust these two classes.

I'm pretty short on time unfortunately, but can perhaps point to a some place that could be of use if anyone else would like to give it a shot.
As @ijuma hinted, there appears to be a task to provide a proper Java API through https://github.com/sbt/zinc/issues/300. The ticket also points Pants' implementation for Scala compilation with zinc, which could perhaps be of help.

A blog discussing the impressive performance improvement in the new release: http://scala-lang.org/blog/2017/11/03/zinc-blog-1.0.html

I'm just using sbt/zinc in my build.gradle like this
zinc "org.scala-sbt:zinc_2.12:1.0.3"

And I got
> Task :compileScala
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc_2.12/1.0.3/8ab1630f052b87799fcb3e18d148326d53609a19/zinc_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-core_2.12/1.0.3/91bd6057c43e8bae3361a831e7a5d91a69982911/zinc-core_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-core_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-apiinfo_2.12/1.0.3/5a9b2965adaf30671b8ca02d1878f1b98b8b50bb/zinc-apiinfo_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-apiinfo_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/compiler-interface/1.0.3/36f8626a127d80a0776de7702b39654dcc9711f/compiler-interface-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:compiler-interface:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-classfile_2.12/1.0.3/1a826de7140b5fab4db4d259ef37c9954aca82d1/zinc-classfile_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-classfile_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-classpath_2.12/1.0.3/2a712827ca8a1e161e30bb82846a80b9ccbacece/zinc-classpath_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-classpath_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-persist_2.12/1.0.3/76e3669952f9708f930ac0a429699c4340b72e72/zinc-persist_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-persist_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-compile-core_2.12/1.0.3/4281ebb6af340a2e12c5f6dbd613abde2d4507b8/zinc-compile-core_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-compile-core_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/zinc-ivy-integration_2.12/1.0.3/fdeb03f818d9c58ced1630548673e721ab81f4d1/zinc-ivy-integration_2.12-1.0.3.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:zinc-ivy-integration_2.12:1.0.3
Errors occurred while build effective model from /Users/zhazhang/.gradle/caches/modules-2/files-2.1/org.scala-sbt/librarymanagement-core_2.12/1.0.0/b586d6d3ae551d5576402654b39011ed842a4d0e/librarymanagement-core_2.12-1.0.0.pom:
    'repositories.repository.id' must be unique: bintraysbtmavenreleases -> https://dl.bintray.com/sbt/maven-releases/ vs https://dl.bintray.com/sbt/maven-releases/ in org.scala-sbt:librarymanagement-core_2.12:1.0.0

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileScala'.
> com/typesafe/zinc/Setup

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s
3 actionable tasks: 3 executed

Is there any work around? thanks.

@yawaramin Can you try setting moduleType = ModuleType.REQUIRES_JAVA_8 in https://github.com/gradle/gradle/blob/0bc46b683cff3f4700544a548a1a9c8746ee3ddb/subprojects/language-scala/language-scala.gradle.kts#L17-L20
That should do the trick.

@wolfs thank you, that worked! Now on to the next error :-)

@big-guy I have submitted https://github.com/gradle/gradle/pull/8485 that upgrades zinc compiler to version 1.2.5 It has been used in our organization internally since Gradle 4.9 without any issues. The incremental compile times decreased significantly.

I got an error when disabling incremental compilation by force = true
Process 'command '/home/klass/.sdkman/candidates/java/8.0.191-oracle/bin/java'' finished with non-zero exit value 1

@big-guy @wolfs is there any chance that this will make it into 5.5?
Just ran into an issue with Zinc 0.3.15 from Gradle 5.4.1 today with Scala 2.11.12, that doesn't happen without zinc 0.3.15.

@snazy Have a look at Bloop, a Scala build server made by the official Scala Center. It integrates with Gradle and could solve your issue. :smiley: "Gradle uses a three years old version of Zinc" is even an pro-bloop argument used in its documentation.

@TheElectronWill hi, Bloop has been brought up before, see above comments :-)

@TheElectronWill I took a look at bloop and the concept is promising. However, there are a bunch of issues with bloop that makes it super difficult to use. bloop doesn't support builds against multiple JDK versions (say: different source sets / artifacts built against Java 8 and/or 11 or 12 or ...). So you'd have to manually write a bunch of Gradle code to support that.
It is by far not really integrated into Gradle (yet). So developers have to use both Gradle (to get the bloop configuration) and bloop on the command line to compile it.
It also requires a manual setup of Bloop, which can be quite error prone, especially if you're dealing with different versions/projects and want to keep stuff separate.
I haven't tried bloop via Gradle in IntelliJ...
At least for my use case, because of these issues, bloop is not an option. When bloop is tightly integrated into Gradle, so it is a seamless "developer experience" - i.e. a simple ./gradlew build just works with bloop without additional configuration, it's fine. I suspect that's all "just work", but I also suspect that it's a lot of work. There are a lot of things that you can do in Gradle, which aren't quite yet possible with bloop.
However, (incremental) Scala compilation in Gradle is not in the best shape, so getting this one in for Gradle 5.5 would be a huge improvement. Looking at the most recent version of bloop, I doubt, that a viable bloop integration can be available for maybe Gradle 5.5 or 5.6.

@snazy No, 5.5 is in the final stages of release and only regression fixes are allowed.  We're trying to upgrade the version of Zinc we integrate with for 5.6 or the next release.

bloop doesn't support builds against multiple JDK versions (say: different source sets / artifacts built against Java 8 and/or 11 or 12 or ...)

What kind of support are you thinking about? Bloop allows build targets to tweak java options and java home, so it should be possible to do that. Feel free to drop by our Gitter channel to continue this discussion (I don't want to spam this thread 😛 ) https://gitter.im/scalacenter/bloop

So developers have to use both Gradle (to get the bloop configuration) and bloop on the command line to compile it. It also requires a manual setup of Bloop, which can be quite error prone, especially if you're dealing with different versions/projects and want to keep stuff separate.

Yes, at the moment these two steps need to be run independently. That would be solved by a built-in integration. However if you're intending to use bloop in your gradle build via Metals, note that Metals will have its in next version an "Import from Gradle" command that will automatically import your build.

This is part of 6.x nightly -> https://github.com/gradle/gradle/pull/9573

@rpalcolea I see. It doesn't seem to be all that stable (regardless of Scala). I guess I'll wait for the RC.

Upgraded to 6.0-rc1 and was able to compile a project on WSL but not on native Windows.
First I got access denied on some JNI file:
C:\Users\eyal\repos\java-scala-gradle-project>gradlew.bat build

> Task :common:compileScala
## Exception when compiling 3 sources to C:\Users\eyal\repos\java-scala-gradle-project\common\build\classes\scala\main
java.lang.UnsatisfiedLinkError: Failed to create temporary file for /com/sun/jna/win32-x86-64/jnidispatch.dll library: Access is denied
com.sun.jna.Native.loadNativeDispatchLibraryFromClasspath(Native.java:962)
com.sun.jna.Native.loadNativeDispatchLibrary(Native.java:922)
com.sun.jna.Native.<clinit>(Native.java:190)
com.sun.jna.platform.win32.Kernel32.<clinit>(Kernel32.java:42)
sbt.internal.io.WinMilli$.getHandle(Milli.scala:264)
sbt.internal.io.WinMilli$.getModifiedTimeNative(Milli.scala:289)
sbt.internal.io.WinMilli$.getModifiedTimeNative(Milli.scala:260)
sbt.internal.io.MilliNative.getModifiedTime(Milli.scala:61)
sbt.internal.io.Milli$.getModifiedTime(Milli.scala:360)
sbt.io.IO$.$anonfun$getModifiedTimeOrZero$1(IO.scala:1373)
scala.runtime.java8.JFunction0$mcJ$sp.apply(JFunction0$mcJ$sp.java:12)
sbt.internal.io.Retry$.liftedTree2$1(Retry.scala:38)
sbt.internal.io.Retry$.impl$1(Retry.scala:38)
sbt.internal.io.Retry$.apply(Retry.scala:52)
sbt.internal.io.Retry$.apply(Retry.scala:24)
sbt.io.IO$.getModifiedTimeOrZero(IO.scala:1373)
sbt.internal.inc.caching.ClasspathCache$.fromCacheOrHash$1(ClasspathCache.scala:44)
sbt.internal.inc.caching.ClasspathCache$.$anonfun$hashClasspath$1(ClasspathCache.scala:53)
scala.collection.parallel.mutable.ParArray$Map.leaf(ParArray.scala:656)
scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:49)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:63)
scala.collection.parallel.Task.tryLeaf(Tasks.scala:52)
scala.collection.parallel.Task.tryLeaf$(Tasks.scala:46)
scala.collection.parallel.mutable.ParArray$Map.tryLeaf(ParArray.scala:647)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal(Tasks.scala:156)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal$(Tasks.scala:153)
scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.internal(Tasks.scala:436)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:146)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:145)
scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:436)
java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

> Task :common:compileScala FAILED
== Build Time Summary ==
??????????????????????????????????????? 100% :common:compileScala (0:29.314)

== BUILD FAILED ==

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':common:compileScala'.
> Failed to create temporary file for /com/sun/jna/win32-x86-64/jnidispatch.dll library: Access is denied

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0-rc-1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 34s
1 actionable task: 1 executed

And on subsequent build I got Kernel32 initialization error:
C:\Users\eyal\repos\java-scala-gradle-project>gradlew.bat build

> Task :common:compileScala FAILED
## Exception when compiling 3 sources to C:\Users\eyal\repos\java-scala-gradle-project\common\build\classes\scala\main
java.lang.NoClassDefFoundError: Could not initialize class com.sun.jna.platform.win32.Kernel32
sbt.internal.io.WinMilli$.getHandle(Milli.scala:264)
sbt.internal.io.WinMilli$.getModifiedTimeNative(Milli.scala:289)
sbt.internal.io.WinMilli$.getModifiedTimeNative(Milli.scala:260)
sbt.internal.io.MilliNative.getModifiedTime(Milli.scala:61)
sbt.internal.io.Milli$.getModifiedTime(Milli.scala:360)
sbt.io.IO$.$anonfun$getModifiedTimeOrZero$1(IO.scala:1373)
scala.runtime.java8.JFunction0$mcJ$sp.apply(JFunction0$mcJ$sp.java:12)
sbt.internal.io.Retry$.liftedTree2$1(Retry.scala:38)
sbt.internal.io.Retry$.impl$1(Retry.scala:38)
sbt.internal.io.Retry$.apply(Retry.scala:52)
sbt.internal.io.Retry$.apply(Retry.scala:24)
sbt.io.IO$.getModifiedTimeOrZero(IO.scala:1373)
sbt.internal.inc.caching.ClasspathCache$.fromCacheOrHash$1(ClasspathCache.scala:44)
sbt.internal.inc.caching.ClasspathCache$.$anonfun$hashClasspath$1(ClasspathCache.scala:53)
scala.collection.parallel.mutable.ParArray$Map.leaf(ParArray.scala:656)
scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:49)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:63)
scala.collection.parallel.Task.tryLeaf(Tasks.scala:52)
scala.collection.parallel.Task.tryLeaf$(Tasks.scala:46)
scala.collection.parallel.mutable.ParArray$Map.tryLeaf(ParArray.scala:647)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal(Tasks.scala:156)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.internal$(Tasks.scala:153)
scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.internal(Tasks.scala:436)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:146)
scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:145)
scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:436)
java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

== Build Time Summary ==
??????????????????????????????????????? 100% :common:compileScala (0:02.490)

== BUILD FAILED ==

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':common:compileScala'.
> Could not initialize class com.sun.jna.platform.win32.Kernel32

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0-rc-1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5s
1 actionable task: 1 executed

Full version info:
C:\Users\eyal\repos\java-scala-gradle-project>gradlew.bat --version

------------------------------------------------------------
Gradle 6.0-rc-1
------------------------------------------------------------

Build time:   2019-10-18 19:24:16 UTC
Revision:     5ed5fea1446b3300afa321c661d6e865ab3157a1

Kotlin:       1.3.50
Groovy:       2.5.8
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          1.8.0_144 (Oracle Corporation 25.144-b01)
OS:           Windows 10 10.0 amd64

Also, 2.13 compilation fails on WSL with a pretty straightforward exception:
eyal@eyal:~/eyal/repos/java-scala-gradle-project$ ./gradlew build
> Task :common:compileScala FAILED
== Build Time Summary ==
99% :common:compileScala (0:00.174)

== BUILD FAILED ==

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':common:compileScala'.
> The version of 'scala-library' was changed while using the default Zinc version. Version 2.13.0 is not compatible with org.scala-sbt:zinc_2.12:1.3.0

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.0-rc-1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 1s
1 actionable task: 1 executed

Version info:
eyal@eyal:~/eyal/repos/java-scala-gradle-project$ ./gradlew --version

------------------------------------------------------------
Gradle 6.0-rc-1
------------------------------------------------------------

Build time:   2019-10-18 19:24:16 UTC
Revision:     5ed5fea1446b3300afa321c661d6e865ab3157a1

Kotlin:       1.3.50
Groovy:       2.5.8
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          1.8.0_161 (Oracle Corporation 25.161-b12)
OS:           Linux 4.4.0-18362-Microsoft amd64


Setup React, Redux, Router, Linters

Create React App.
Install React Redux, Redux Logger and React Router.

Hi @aeh1707 ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To Highlight 💯

Install all dependencies ✔
Install linters as well.  ✔

Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Ignores player spawn events if they are already consumed

Simply return from the listener if it's cancelled.

I'm all for this code, but It doesn't appear as if this class (PlayerRespawnEvent) is cancelable (Implement Cancellable): https://github.com/Bukkit/Bukkit/blob/master/src/main/java/org/bukkit/event/player/PlayerRespawnEvent.java
Feel free to reopen if im' wrong, but it, for obvious reasons, does not even compile.

 Oh well. Guess it's back to plan B for my users.

Multiverse handles the Spawn event with LOW priority, This means a plugin can be set to lower than it, or higher, to either let us, or override us.


use a single, small image for all smoke test containers

Our smoke tests currently use two images: gliderlabs/alpine and aanand/docker-dnsutils. The former is tiny. The latter is huge. There is reason for having the latter, but I don't remember what it is. @inercia do you? Is there any way we can either a) change the tests to just use the former, or b) build a derived image off gliderlabs/alpine that has what we need?

I remember the reason for having the dnsutils, but not the alpine...

well, we use alpine because it is small. What's the reason for dnsutils?

Here's one reason...
$ ./280_with_or_without_dns_test.sh
With or without DNS test
680b980a679bacec00622c75670742b8fd2f013e40414c10d44b9209b2a9d8ae
907333a83c04154c689dd352835b07ebfdc2f8544768cb621f23f6c00671f1c7
577927d034c452c5ae1a3a407f40eda0fc0bd2002d07c901acd5856a516d71a7
test #6 "exec_on <IP_ADDRESS> 286b53e7d443a23ce311889fe27d2a09cf932080c0ce936aa2b6408f75de8a82 getent hosts <IP_ADDRESS> | tr -s ' '" failed:
	expected "<IP_ADDRESS> seetwo.weave.local"
	got "<IP_ADDRESS> seetwo.weave.local seetwo.weave.local"
test #8 "exec_on <IP_ADDRESS> 60df56344c189fef4dde9b7b84669ae875ba6ca452d4b6035c825f9946bd5386 getent hosts <IP_ADDRESS> | tr -s ' '" failed:
	expected "<IP_ADDRESS> seetwo.weave.local"
	got "<IP_ADDRESS> seetwo.weave.local seetwo.weave.local"
2 of 8 tests failed in 48.236s.

The dnsutils is basically a ubuntu with dig and nslookup. I guess alpine has those tools too, so I don't know why this image was introduced...

Here's another...
$ ./635_proxy_dns_unqualified_test.sh
Resolve unqualified names
4480a0f67489b3790410d24dacd2eceacc6c440b7d1b9a0c978a17c02ece8cb0
c50bffa454cd848200f13bc7679029b9593d89c5e2cc3b6ab1ceb9ca743f3b17
f5a17567a35cbb17f96e68c66f7f5a740e69d4527e24660b83dfad52043373d9
6d6cd06bb5bcaa2945692af68d7f1f0ad9debfd5d0e9573fc171ee073b30a087
d1b98d98165f5606de451b9e4c8c952d09e083bd70523eb7ff0772343b4c68ae
test #1 "proxy exec_on <IP_ADDRESS> c2 getent hosts seeone | tr -s ' '" failed:
	expected "<IP_ADDRESS> seeone.weave.local"
	got nothing
test #2 "proxy exec_on <IP_ADDRESS> c3 getent hosts seeone | tr -s ' '" failed:
	expected "<IP_ADDRESS> seeone.weave.local"
	got nothing
test #3 "proxy exec_on <IP_ADDRESS> 6b299b6a52543bdad0c96b5be0272d02afa98688e3e696a797a35aae6d533909 getent hosts seeone | tr -s ' '" failed:
	expected "<IP_ADDRESS> seeone.weave.local"
	got nothing
3 of 3 tests failed in 12.580s.

Both of these look like bugs in the alpine name resolution. The first one would be relatively easy to paper over, even in a portable way, in the tests. The second one is more tricky.

Another one...
$ ./200_dns_test.sh
Resolve names on a single host
9eb0ff6f3281cf845734beba36f77218ce9f6adae7f2bd3287d840c112262ca6
b73fb2005c295751235b7ed708ad082090e0a90b1fe63a93a624ebf8e8c5a873
e42cba2cb1f379b11971d3d47527c107d1eb55df48f890fbcba54d4e1bf8fa32
test #2 "exec_on <IP_ADDRESS> c1 getent hosts <IP_ADDRESS> | tr -s ' '" failed:
	expected "<IP_ADDRESS> seetwo.weave.local"
	got "<IP_ADDRESS> seetwo.weave.local seetwo.weave.local"
test #3 "exec_on <IP_ADDRESS> c1 dig MX seetwo.weave.local | grep -q 'status: NXDOMAIN'" failed:
	program terminated with code 1 instead of 0
2 of 3 tests failed in 12.394s.

That's just a missing dig.

Another one...
$ ./290_dns_fallback_test.sh
Resolve a non-weave address
4d7c9e80fd3e322ddbfd0d21c6d38dac830f12793cd9acc5d011ba4c921e4e61
0f1debb4c25ccbe2e4d437abf403471e182ff6e4bac7d43e245d786a409773bf
test #1 "exec_on <IP_ADDRESS> c1 host -t mx weave.works | grep google" failed:
	program terminated with code 1 instead of 0
1 of 2 tests failed in 9.065s.

which is due to missing host.

So it seems there are many commands missing and probably some things broken in the resolution library... what should we do then?

Previous discussion here: https://github.com/weaveworks/weave/pull/345

The broken unqualified name resolution is due to a bug in musl :(

One way around that might be to change our dns to resolve unqualified names in the weavedns domain. Good idea or bad?

That would rather defeat the purpose of the test, which is supposed to check that weave configures resolv.conf correctly s.t. unqualified names get resolved as intended. We can't really test that with a broken resolver.

missing host

We used to use dig here, so could revert to that.

We can't really test that with a broken resolver.

Which means we can't use images derived from musl. Anything else is going to be huge in comparison. Yes, we could find something smaller than aanand/dnsutil, but not by orders of magnitude.
-> wontfix.


[C++] Compiling failed on Mac M1

Describe the bug, including details regarding any error messages, version, and platform.
I am getting the following error while compiling Arrow C++.
8 warnings generated.
[537/632] Linking CXX executable debug/arrow-utility-test
FAILED: debug/arrow-utility-test
: && /Users/vibhatha/tools/arrow/lint/clang+llvm-14.0.0-x86_64-apple-darwin/bin/clang++ -fno-aligned-new  -Qunused-arguments -fcolor-diagnostics -ggdb -O0  -Wall -Wextra -Wdocumentation -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Werror -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -g -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk -mmacosx-version-min=12.0 -Wl,-search_paths_first -Wl,-headerpad_max_install_names -L/opt/homebrew/opt/bison/lib src/arrow/util/CMakeFiles/arrow-utility-test.dir/align_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/atfork_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/byte_size_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/cache_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/checked_cast_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/compression_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/decimal_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/formatting_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/key_value_metadata_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/hashing_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/int_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/io_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/iterator_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/logging_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/queue_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/range_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/reflection_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/small_vector_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/stl_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/string_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/tdigest_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/test_common.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/time_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/tracing_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/trie_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/uri_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/utf8_util_test.cc.o src/arrow/util/CMakeFiles/arrow-utility-test.dir/value_parsing_test.cc.o -o debug/arrow-utility-test  -Wl,-rpath,/Users/vibhatha/github/fork/arrow/cpp/build/debug -Wl,-rpath,/opt/homebrew/lib  debug/libarrow_testing.1100.0.0.dylib  debug/libarrow.1100.0.0.dylib<EMAIL_ADDRESS><EMAIL_ADDRESS>/opt/homebrew/lib/libbrotlienc.dylib  /opt/homebrew/lib/libbrotlidec.dylib  /opt/homebrew/lib/libbrotlicommon.dylib  /opt/homebrew/lib/libaws-cpp-sdk-config.dylib  /opt/homebrew/lib/libaws-cpp-sdk-transfer.dylib  /opt/homebrew/lib/libaws-cpp-sdk-identity-management.dylib  /opt/homebrew/lib/libaws-cpp-sdk-cognito-identity.dylib  /opt/homebrew/lib/libaws-cpp-sdk-sts.dylib  /opt/homebrew/lib/libaws-cpp-sdk-s3.dylib  /opt/homebrew/lib/libaws-cpp-sdk-core.dylib  utf8proc_ep-install/lib/libutf8proc.a  /opt/homebrew/lib/libre<IP_ADDRESS>.dylib  googletest_ep-prefix/lib/libgtest_maind.dylib  googletest_ep-prefix/lib/libgtestd.dylib  googletest_ep-prefix/lib/libgmockd.dylib<EMAIL_ADDRESS>/opt/homebrew/lib/libaws-crt-cpp.dylib  /opt/homebrew/lib/libaws-c-mqtt.1.0.0.dylib  /opt/homebrew/lib/libaws-c-event-stream.1.0.0.dylib  /opt/homebrew/lib/libaws-c-s<IP_ADDRESS>.dylib  /opt/homebrew/lib/libaws-c-auth.1.0.0.dylib  /opt/homebrew/lib/libaws-c-http.1.0.0.dylib  /opt/homebrew/lib/libaws-c-io.1.0.0.dylib  /opt/homebrew/lib/libaws-c-compression.1.0.0.dylib  /opt/homebrew/lib/libaws-c-cal.1.0.0.dylib  -framework Security  /opt/homebrew/lib/libaws-c-sdkutils.1.0.0.dylib  /opt/homebrew/lib/libaws-checksums.1.0.0.dylib  /opt/homebrew/lib/libaws-c-common.1.0.0.dylib  -pthread  -lpthread  -framework CoreFoundation && :
Undefined symbols for architecture arm64:
  "__ZNSt3__18to_charsEPcS0_d", referenced from:
      __ZN5arrow8internal7ToCharsIdJEEENSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEET_DpOT0_ in string_test.cc.o
  "__ZNSt3__18to_charsEPcS0_f", referenced from:
      __ZN5arrow8internal7ToCharsIfJEEENSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEET_DpOT0_ in string_test.cc.o
ld: symbol(s) not found for architecture arm64
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
[546/632] Building CXX object src/parquet/CMakeFiles/parquet-arrow-test.dir/arrow/arrow_reader_writer_test.cc.o
ninja: build stopped: subcommand failed.

I encounter this issue on Mac M1 while using the clang-14.
Component(s)
C++

Given that few standard libraries seem to support std::to_chars for floating-point types, we should probably revert its usage from the Arrow codebase.
@bkietz Thoughts?

Also please note that, the issue occurs when using the following clang version.
clang version 14.0.0 (https://github.com/tru/llvm-release-build fc075d7c96fe7c992dde351695a5d25fe084794a)

But when using clang Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5) the issue didn't occur. Previously in my path, CLANG_TOOLS has been included and its clang and clang++ was used in compiling. That could have been the reason why I got the issue.
But, please note that I have been using this setting for a while and didn't encountered the reported issue until now.

I've crawled through the history of libc++' charconv header and I can't find an explanation for this. I do think that floating point to_chars might need to wait a while, but perhaps we could let this issue accumulate a few more reports before reverting

I have a similar error (not quite the same) on a Mac M2. I'm new to pyarrow, and especially to C++ builds. I was trying to build using ninja-debug-python preset:
> cmake --build .
[304/631] Linking CXX shared library debug/libarrow.1200.0.0.dylib
ld: warning: -pie being ignored. It is only used when linking a main executable
[307/631] Linking CXX shared library debug/libarrow_testing.1200.0.0.dylib
ld: warning: -pie being ignored. It is only used when linking a main executable
[353/631] Linking CXX executable debug/arrow-array-test
FAILED: debug/arrow-array-test
: && /Users/jbennet/mambaforge/envs/pyarrow-dev/bin/arm64-apple-darwin20.0.0-clang++ -fno-aligned-new -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem /Users/jbennet/mambaforge/envs/pyarrow-dev/include -Qunused-arguments -fcolor-diagnostics  -Wall -Wextra -Wdocumentation -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -g -Werror -O0 -ggdb -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,/Users/jbennet/mambaforge/envs/pyarrow-dev/lib -L/Users/jbennet/mambaforge/envs/pyarrow-dev/lib src/arrow/CMakeFiles/arrow-array-test.dir/array/array_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_binary_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_dict_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_list_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_run_end_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_struct_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_union_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_view_test.cc.o -o debug/arrow-array-test  -Wl,-rpath,/Users/jbennet/src/arrow/cpp/build/debug/ -Wl,-rpath,/Users/jbennet/mambaforge/envs/pyarrow-dev/lib  debug/libarrow_testing.1200.0.0.dylib  debug/libarrow.1200.0.0.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libbrotlienc.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libbrotlidec.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libbrotlicommon.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/liborc.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libprotobuf.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libutf8proc.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libre<IP_ADDRESS>.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libgtest_main.1.12.1.dylib  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libgmock.1.12.1.dylib  jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a  mimalloc_ep/src/mimalloc_ep/lib/mimalloc-2.0/libmimalloc-debug.a  /Users/jbennet/mambaforge/envs/pyarrow-dev/lib/libgtest.1.12.1.dylib && :
Undefined symbols for architecture arm64:
  "testing::Matcher<std::__1::basic_string_view<char, std::__1::char_traits<char> > const&>::Matcher(char const*)", referenced from:
      testing::Matcher<std::__1::basic_string_view<char, std::__1::char_traits<char> > const&> testing::internal::MatcherCastImpl<std::__1::basic_string_view<char, std::__1::char_traits<char> > const&, char const*>::CastImpl<true>(char const* const&, std::__1::integral_constant<bool, true>, std::__1::integral_constant<bool, true>) in array_test.cc.o
      testing::Matcher<std::__1::basic_string_view<char, std::__1::char_traits<char> > const&> testing::internal::MatcherCastImpl<std::__1::basic_string_view<char, std::__1::char_traits<char> > const&, char const*>::CastImpl<true>(char const* const&, std::__1::integral_constant<bool, true>, std::__1::integral_constant<bool, true>) in array_binary_test.cc.o
ld: symbol(s) not found for architecture arm64
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
[366/631] Building CXX object src/arrow/compute/kernels/CMakeFiles/arrow-compute-scalar-math-test.dir/scalar_arithmetic_test.cc.o
ninja: build stopped: subcommand failed.

How do I fix this?

Nevermind; problem solved by using the -DGTest_SOURCE="BUNDLED" flag, suggested here:
https://github.com/apache/arrow/issues/14917

Duplicate of https://github.com/apache/arrow/issues/14917


Disable editing but enable right/left view buttons

Feature request:  Disable editing of the text field, while still enabling buttons added to a left/right view.  For example (based on the sample code provided), I can do this:
var body: some View {
        FloatingLabelTextField($password, placeholder: "Password", editingChanged: { (isChanged) in

        }) {

        }
        .isSecureTextEntry(!self.isPasswordShow)
            .leftView({ // Add left view.
                Image("password")
            })
            .rightView({ // Add right view.
                Button(action: {
                    withAnimation {
                        self.isPasswordShow.toggle()
                    }

                }) {
                    Image(self.isPasswordShow ? "eye_close" : "eye_show")
                }
            })
            .frame(height: 70)
            .padding()
    }

However, if I want the text field itself to be read-only and i set disabled(true), that also disables the Button in rightView.  I'd like to be able to still toggle the visibility of the field while disabling the ability to edit.

Hello, @TheGeekPharaoh
Thank You for this point. I have added two new properties for this so please update the library.
.allowsHitTesting(true) // Whether this view participates in hit test operations.
.disabled(false) // Whether users can interact with this.


Flask: speed up launching CLI scripts

Originally on 2013-04-09
CLI commands in the next branch are slow to launch.  Would be nice to speed the launch up.  Here is comparison with the master branch:
$ workon invenio-master

$ time sudo -u www-data /opt/invenio/bin/bibindex --help >& /dev/null

Best of three calls:

real    0m0.567s
user    0m0.468s
sys     0m0.068s

$ workon invenio-next

Best of three calls:

$ time sudo -u www-data /opt/invenio/bin/bibindex --help >& /dev/null

real    0m2.606s
user    0m2.348s
sys     0m0.212s

Note that inveniomanage speed seems good, so hopefully this ticket will get solved automatically when flaskshell technique will get deprecated and when every module will use inveniomanage.

Solved by using Flask-CLI in Invenio>=3.0.0a1.


raspberry pi gst-launch-1.0 option misspell

Description of changes:
Option periodicity-idr doen't work for me and periodicty-idr worked.
Actually I'm not sure about it whether it is misspell or problem of my running environment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
ps. I don't expect this to be merged like #98
But just want to point out options and help other people as possible I can!
Thank you for keep this library.

This has been fixed by new releases


Supported argocd versions are unclear

Describe the bug
The operator installs a default version of argocd. It is not clear from the documentation if it is possible to also deploy other argocd versions with a given operator version. The argocd CRD has a version field, but the documentation is rudimentary.
Expected behavior
Clear documentation on which versions can be deployed with a given operator version (e.g. operator release 0.12.0, supports all argocd versions 0.12.X).
Additional context
There is a bugfix in a argocd minor release which I would like to deploy using the argocd-operator. Also the argocd-operator release cycle is much slower than the argocd release cycle and I would like to have an up-to-date argocd installation.

Hi @bo0ts, yes, you can deploy other Argo CD versions by using  .spec.image & .spec.version fields ArgoCD CR
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: <your-argocd-instance>
spec:
  image: quay.io/argoproj/argocd
  version: v2.12.3

The supported versions are
Operator 0.12.0 -> Argo CD 2.12.x
Operator 0.11.0 -> Argo CD 2.11.x

We are in the process of updating our documentation and automating our release process. We are hopeful that things will be better in the future.

Do you know if Renovate supports updating the .spec.version field?

I got it to work by writing a custom manager in Renovate.


Downloading stash for Standard, details logged to DebugInfo.log,

Whats up I can't open my shop

The new version of Procurement is out, which fixes this issue: https://github.com/Stickymaddness/Procurement/releases/tag/1.9.6
Unfortunately until GGG decide to support the dev community, these type of issues will continue to happen as it is out of our hands. http://i.imgur.com/yrPtajM.jpg


KeysetPaginator more test

KeysetPaginator more test.

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues
-

Merged. Thanks!


Snow validator

Relevant is only https://github.com/w3f/1k-validators-be/blob/master/helmfile.d/config/polkadot/otv-backend-prod.yaml.gotmpl and that one only contains the stash address once... I think that stash address was recently changed and a 1kv admin would need to clean up/merge the old entry.
Originally posted by @Nexus2k in https://github.com/w3f/1k-validators-be/issues/1874#issuecomment-1177171858

Moved to correct repo. @wpank FYI

Err, sorry what's this issue about?


Fix typo in reference to camel-quartz2.jar

camel-quarz2.jar -> camel-quartz2.jar

Thanks :-) I'm merging it :-)

Thanks for your contribution. The PR has been merged :-) Can you close the PR?


Change .json to .prbm

Fix a typo in the docs, must have changed at some point.
Didn't touch any of the other configs because I didn't test them.

Thanks, but that's not a typo =)
The docs represent bluemap version 3.20 as that is still the latest recommended release ^^
If you have prbm files then you are using 4.x -> a snapshot version of bluemap. As soon as there is a recommended release with the new prbm-files, i'll update the wiki.
Closing this PR, as there is a lot more on the wiki that needs to be changed for the next update than just this =)


Move processing and processed from media context state to a MediaProvider ref

Move processing and processed from media context state to a ref scoped to uploadVideoPoster.
This is a simple cleanup that was recommended by Dima in #1729 and prevents unnecessary re-renders.

Discarding, as the 'processing' var is useful in global state for #969.


mps device

(venv) F:\talker\liveportrait_talker-main>python inference.py --config_path config.yaml --source_path "F:\talker\liveportrait_talker-main\Face\1.png" --audio_path "F:\talker\liveportrait_talker-main\Audio\2.wav" --save_path "F:\talker\liveportrait_talker-main\Audio"
Config File is loaded succesfully!
Traceback (most recent call last):
File "F:\talker\liveportrait_talker-main\inference.py", line 78, in
main(args)
File "F:\talker\liveportrait_talker-main\inference.py", line 23, in main
preprocess = Preprocess(device=cfg.device,
File "F:\talker\liveportrait_talker-main\src\modules\preprocess.py", line 28, in init
self.sd_prep = SadTalkerPreprocess(device=device,
File "F:\talker\liveportrait_talker-main\src\utils\preprocess\sadtalker_preprocess.py", line 20, in init
self.detector = init_alignment_model('awing_fan', device=device, model_rootpath=model_path)
File "F:\talker\liveportrait_talker-main\src\utils\preprocess\helper.py", line 149, in init_alignment_model
model = model.to(device)
File "F:\talker\liveportrait_talker-main\venv\lib\site-packages\torch\nn\modules\module.py", line 1173, in to
return self._apply(convert)
File "F:\talker\liveportrait_talker-main\venv\lib\site-packages\torch\nn\modules\module.py", line 779, in _apply
module._apply(fn)
File "F:\talker\liveportrait_talker-main\venv\lib\site-packages\torch\nn\modules\module.py", line 779, in _apply
module._apply(fn)
File "F:\talker\liveportrait_talker-main\venv\lib\site-packages\torch\nn\modules\module.py", line 804, in _apply
param_applied = fn(param)
File "F:\talker\liveportrait_talker-main\venv\lib\site-packages\torch\nn\modules\module.py", line 1159, in convert
return t.to(
RuntimeError: PyTorch is not linked with support for mps devices
(venv) F:\talker\liveportrait_talker-main>

You need to change device type from config file (inference.device). If you are using gpu you have to set device as cuda, if not you have to set as cpu. In default, i set as mps which is for macbook.

Microsoft Windows [Version 10.0.19045.5011]
(c) Microsoft Corporation. All rights reserved.
F:\talker\liveportrait_talker-main>venv\scripts\activate
(venv) F:\talker\liveportrait_talker-main>python inference.py --config_path config.yaml --source_path "F:\talker\liveportrait_talker-main\Face\1.png" --audio_path "F:\talker\liveportrait_talker-main\Audio\2.wav" --save_path "F:\talker\liveportrait_talker-main\Audio\1.mp4"
Config File is loaded succesfully!
F:\talker\liveportrait_talker-main\venv\lib\site-packages\torchvision\models_utils.py:208: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and may be removed in the future, please use 'weights' instead.
warnings.warn(
F:\talker\liveportrait_talker-main\venv\lib\site-packages\torchvision\models_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passing weights=None.
warnings.warn(msg)
Pipeline Objects are initialized!
LLVM ERROR: Symbol not found: __svml_cosf8_ha
(venv) F:\talker\liveportrait_talker-main>

Hi, I haven't seen this issue before. I checked library versions too, everything is seen okay and works fine. You can try this solution.

https://youtu.be/6aS-Ui37o-o   lol u did models changes after i made video

there also two payyaml versions in requirements cause error

Wow, thanks for yout support. I haven't seen this video sorry 😄. I also realized that head pose is not working in your video, I updated the pipeline. I guess I solved the issus.

i  am trying to make gradio of it i am not good at it but somehow i manage to make things work

Gradio is on my pipeline too, but I don't know when can I complete it because of my work.


Split traits.rs into submodules

The traits.rs grew a lot and became quite messy. It should be split into multiple submodules, each one containing somewhat related traits (e.g., vertices, edges, neighbors, properties, ...).

Done in #24


Is this project still alive?

I noticed that the last commit is from June 10th 2021.

Yes. We've just used it as part of this week's Spring Boot 2.6 release, for example.


Is there an official Docker image for this project?

Couldn't find any. I can create a PR for this if you wish to support it.

A Docker image will be available starting from the next release.

Docker images are now available since v0.7.0. Take a look at the README.


Restart always for all containers

Currently, only redis is set to restart: always. Adding this to the other containers will help the service to be robust in case the host machine reboots.

I added this in the docker-compose file

Seems this was reverted in the new release.


Making quantum_info and the states

Summary
Fixes #1196
Fixes #1194
Details and comments

@chriseclectic this is ready to start. I will slowly go through and move qi over.

Should we make the states a subpackage for organization, and the inside have

states.py for functions that return common states like basis states, random states etc
measures.py for all the measures/quantities like fidelity, purity, entropy, entanglement etc
operations.py for things like partial trace, projector, outer, vectorize etc
and then use the states.__init__.py to import all the functions we want exposed in qi.states

I don't think there will be enough measures lets just keep it states and operations.

@chriseclectic should be done.

I can't officially review but I Approve if someone can merge this

See a relevant pull request from qiskit-aer:
https://github.ibm.com/IBMQuantum/qiskit-aer/pull/88
This pull request contains a file named qstructs.py, with stuff that can be imported to Terra:
https://github.ibm.com/YAELBH/qiskit-aer/blob/1ef4042275eb63154ae4a7642346dc97b34e42a4/test/terra/validate_against_density_matrix_simulator/qstructs.py


National Sustainable Development Goals Logo

come across an interesting Sustainable Goal logo for Rwanda Indicators for the Sustainable Development Goals platform, it would best to have a similar logo design for the Vanuatu NSDP open platform.
here is a link below;
https://sustainabledevelopment-rwanda.github.io/

@jah-ky That seems like a good idea to me.

@jah-ky I think the first step would be to locate a good version for the flag. For example is this one OK? https://en.wikipedia.org/wiki/Flag_of_Vanuatu

@jyaruel will be working on producing the logo (which will combine the VNSO, NSDP, and Vanuatu flag) and the Vanuatu image (which will replace the SDG wheel on the homepage).

@Vanuatu-National-Statistics-Office/nsdp-platform-team I know the logo is still being edited, but just a note that the current version has a lot of space above and below the logo that could maybe be removed.


peatanktest

Have you finish it or just a test?  Please add some description about your work.

My works:
1 add pea_tank.cpp and pea_tank.h in src/battle_game/core/units which is designed to shoot in 4 directions simutaneously with each bullet dealing half damage
2 add speedbullet:(defined in src/battle_game/core/units) which is designed to increase its speed after some certain number of updates(my solution to issue#296)
These works are NOT TESTED.( I spent about half a week searching on Google/Stack Overflow and asking TAs/classmates/in the WeChat Group but still cannot get my Visual Studio generating battle.exe correctly, so I cannot do the test temporarily.I'll try to work on it in the remaining days but please grade it if I cannot get Visual Studio work before the deadline.)

plz fix your bugs first

plz fix your bugs first

It seems they're fixed now. Sorry about that since my VSCode seemed to be not working well (and both me and TA & classmates & Google I sought for help couldn't really fix) and it may not build successfully even when there was no bugs at all (and GitHub ran the version of code successfully)

Don't submit your .obsidian folder, just delete it from ur code-repo

'.obsidian' deleted and 'count' variable renamed as 'count_'


Run and Debug does not run debugger

Type: Bug

Behaviour
Expected vs. Actual
When updating my Python extension plugin to v2022.10.0 or later, I am not longer able to debug Python tests. The debugger tool bar quickly appears (2 secs or so) and goes away. I have had to downgraded my Python extension to v2022.8.1 in order to continue my work.
Steps to reproduce:

Navigate to Extensions in the left sidebar
Search for Python and install Python version v2022.10.0 or later
Create a simple pytest application and attempt to run it.
Click the Run and Debug icon in the left sidebar and run your test
The debug icon should appear briefly and disapear with running your tests.

Here is a snippet of the content within my .vscode file
{
"version": "0.2.0",
"configurations": [
{
"name": "Python: Pytest",
"type": "python",
"request": "launch",
"module": "pytest",
"args": ["-sv", "test/unit/filename.py"],
"console": "integratedTerminal"
}
]
}

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.6.5
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Unknown
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

Multiroot scenario, following user settings may not apply:

languageServer: "Pylance"

linting
• flake8Args: "<placeholder>"

formatting
• provider: "black"

testing
• pytestArgs: "<placeholder>"
• pytestEnabled: true

Extension version: 2022.8.1
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:05:37.721Z)
OS version: Darwin x64 19.6.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
32.00GB (0.11GB free)

Process Argv
-psn_0_57358 --crash-reporter-id ee72e66b-41d2-4695-9e5c-3705f6ff8321

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
fc301958:30573243

@jonepl Python 3.6 is no longer supported. It has been out of service on python.org since 1st Jan 2022. IF you need to continue to use Python 3.6, please pin the extension to version 2022.8.*. Otherwise, I recommend to update your python. version.


feat: support gov v1 proposals

Description
This PR aims at updating the codebase in order to properlty support x/gov new v1 proposal types and inner workings.

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #610 (24b5eaa) into cosmos/v0.47.x (a724b93) will increase coverage by 0.93%.
The diff coverage is 42.85%.

:exclamation: Current head 24b5eaa differs from pull request most recent head 62c8f22. Consider uploading reports for the commit 62c8f22 to get more accurate results

@@                Coverage Diff                 @@
##           cosmos/v0.47.x     #610      +/-   ##
==================================================
+ Coverage           54.96%   55.90%   +0.93%
==================================================
  Files                  19       20       +1
  Lines                1479     1431      -48
==================================================
- Hits                  813      800      -13
+ Misses                565      536      -29
+ Partials              101       95       -6

Nice! I also updated hasura metadata and added entry inside CHANGELOG.md, thanks @RiccardoM !


Generalized definition of a Determinant

Shows how to solve for a determinant in any matrix of size n by n.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@Domin-Sweet Thanks for your contribution. Since there are multiple style issues with this I'm going to go ahead and close it.


pilot: update discovery cache flag to camel case

when I learned the code, I found the istio flag using Camel-Case. I searched for the discovery_cache in the entire istio repository. I didn't reference it elsewhere. maybe we can update this flag to make it consistent with other flags. thanks

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @zjj2wry. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test

@zjj2wry: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo-envoyv2-v1alpha3
/test istio-unit-tests

@zjj2wry: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zjj2wry: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
/test e2e-bookInfo-envoyv2-v1alpha3

@zjj2wry: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
4b9e7cd67959b9a77c3e800e15ce069c44d9df1d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.