Fixed code file header comments

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   77.11%   77.11%
=======================================
  Files         114      114
  Lines        3019     3019
  Branches      345      345
=======================================
  Hits         2328     2328
  Misses        633      633
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bd029...3708578. Read the comment docs.


Message field needs a lot of work

I love IGDM but it's not my one and only because the message field is a COMPLETE FAIL. For these reasons:

If I paste a lot of text, which makes the messages text box resize, after I send it will not resize back.
For some super odd reason text replacement and spell check do not work in the messages field.

Please please please fix these two bugs, they are killing the app.

Not rempxetly simular.

@tsegreto  for bug 1, does it revert back to the normal size after you start typing again? I can reproduce what you're saying, but for me it goes back to regular size as soon as I start typing, so it's not a big issuee...
for bug 2, i can't simulate. What OS are you in? macOS?

Hi @someone857 - simply set up keyboard replacements on macOS and try to use them. It doesn't work. There is no spell check either.


[Feature Request] Refactor New/Edit product code

There is a lot of complexity and duplication between New and Edit product in both app.py and the create/edit modals. Would be nice to do a full refactor to get both this and #4 resolved.

[ ] Create "Product" class with all the necessary information
[ ] Refactor the DB handling code within Create and Edit

[ ] Move Create and Edit closer together within the code?

[ ] See what can be done about #4

Feature Request has been moved to the new repo. Closing.


Set up Hacktoberfest 2023 infrastructure

What kind of changes does this PR include?

Something else!

Description
This PR updates our hacktoberfest document for 2023, and adds a new warning in the pull request template to remind folks to ask for the hacktoberfest-accepted label!
Also, I've set up the basic Hindi infrastructure so beginners don't get lost while trying to add a page.

I get Chris' concern about Hindi. It's also worth calling out that we're also emphasizing reviews as an easy way to get started and learn the ropes, and there won't be any PRs yet!
What if we just merge Hindi infrastructure separately, to at least make it easy for PRs to start, and we can do that NOW, and post in i18n channel and see whether we can get some interest before Hacktoberfest starts?
As for the copy editing, I'll wait until Yan has gone through all the existing suggestions so I can look at it as a clean slate.

One thing I’m unsure of is adding the Hindi infrastructure. It would be the first time we’ve done this without Getting Started & UI translated, so visitors would be able to switch to Hindi and not see any changes really. Maybe that’s still worth it though.

For context, what made me decide to set it up myself was that the add-language command doesn't work without you installing a few babel additional packages & also, not having a page initially would cause a rendering error before. I prefer if we set it up beforehand than to have multiple contributors potentially doing that for us and causing all sorts of conflicts


ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

Traing kitti data, when i modify the config file from single car-task to all classes(car\pedestrian\cyclist)task, error occures.
The information is here:

Traceback (most recent call last):
File "train.py", line 118, in
main()
File "train.py", line 115, in main
train_detector(model, datasets, cfg, distributed=distributed, validate=args.validate, logger=logger,)
File "/home/l4/wangmeng/SE-SSD/det3d/torchie/apis/train_sessd.py", line 321, in train_detector
trainer.load_checkpoint_from_scratch(cfg.load_from)
File "/home/l4/wangmeng/SE-SSD/det3d/torchie/trainer/trainer_sessd.py", line 216, in load_checkpoint_from_scratch
self.optimizer.load_state_dict(checkpoint_0["optimizer"])
File "/home/l4/anaconda3/envs/SE-SSD/lib/python3.7/site-packages/torch/optim/optimizer.py", line 123, in load_state_dict
raise ValueError("loaded state dict contains a parameter group "
ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

Dose anyone know the problem?

@MengWangTHU We have not train all classes before.... your bug seems show the loaded checkpoint mismatch with your network structure.


Add hints for most of the advanced challenge.

Add hints for most of the advanced challenges.

Thanks for providing hints and fixing various issues!


pn.widgets not working in a list

Hi, I'm trying out the hvplot .interactive.  I got TypeError: 'RadioButtonGroup' object is not callable for the following code, I think it's because I can't write my xaxis in a list.  It works if I change  .groupby(['origin', xaxis]) to  .groupby(xaxis), but it'd be nice if pn.widgets can work in a list.  I'd really appreciate some help. Thanks!
from bokeh.sampledata.autompg import autompg_clean as df
import hvplot.pandas
import panel as pn
import holoviews as hv
hv.extension('bokeh')
idf = df.interactive()
cylinders = pn.widgets.IntSlider(start=4, end=8, step=2)
mfr = pn.widgets.ToggleGroup(options=['ford', 'chevrolet', 'plymouth', 'honda', 'sbaru', 'volkswagen'],
                             value=['ford', 'chevrolet', 'plymouth', 'honda', 'sbaru', 'volkswagen'])
xaxis = pn.widgets.RadioButtonGroup(name='X axis', options=['mpg', 'yr'])
yaxis = pn.widgets.RadioButtonGroup(name='Y axis', options=['hp', 'weight'])

ipipeline = (
    idf[
        (idf.cyl == cylinders) &
        (idf.mfr.isin(mfr))
    ]
    .groupby(['origin', xaxis])[yaxis].mean()
    .to_frame()
    .reset_index()
)

Traceback
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/var/folders/n9/dr352bs550nck1fg2mz9vpn80000gn/T/ipykernel_46537/1739249479.py in <module>
     12
     13 ipipeline = (
---> 14     idf[
     15         (idf.cyl == cylinders) &
     16         (idf.mfr.isin(mfr))

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/hvplot/interactive.py in __call__(self, *args, **kwargs)
    185                                        accessor=True)
    186             kwargs = dict(self._inherit_kwargs, **kwargs)
--> 187             clone = self._clone(method(*args, **kwargs), plot=self._method == 'plot')
    188         finally:
    189             self._method = None

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/hvplot/interactive.py in _clone(self, transform, plot, loc, center, dmap, **kwargs)
    114         depth = self._depth+1
    115         kwargs = dict(self._inherit_kwargs, **dict(self._kwargs, **kwargs))
--> 116         return type(self)(self._obj, transform, plot, depth,
    117                           loc, center, dmap, **kwargs)
    118

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/hvplot/interactive.py in __init__(self, obj, transform, plot, depth, loc, center, dmap, inherit_kwargs, max_rows, **kwargs)
     84         self._kwargs = kwargs
     85         ds = hv.Dataset(self._obj)
---> 86         self._current = self._transform.apply(ds, keep_index=True, compute=False)
     87         self._init = True
     88

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/holoviews/util/transform.py in apply(self, dataset, flat, expanded, ranges, all_values, keep_index, compute, strict)
    736             drange = ranges.get(eldim, {})
    737             drange = drange.get('combined', drange)
--> 738             data = self._apply_fn(dataset, data, fn, fn_name, args,
    739                                   kwargs, accessor, drange)
    740         drop_index = keep_index_for_compute and not keep_index

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/holoviews/util/transform.py in _apply_fn(self, dataset, data, fn, fn_name, args, kwargs, accessor, drange)
    634                         data = method(*args, **kwargs)
    635                     else:
--> 636                         raise e
    637         else:
    638             data = fn(*args, **kwargs)

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/holoviews/util/transform.py in _apply_fn(self, dataset, data, fn, fn_name, args, kwargs, accessor, drange)
    628             else:
    629                 try:
--> 630                     data = method(*args, **kwargs)
    631                 except Exception as e:
    632                     if 'axis' in kwargs:

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/frame.py in groupby(self, by, axis, level, as_index, sort, group_keys, squeeze, observed, dropna)
   7624         # error: Argument "squeeze" to "DataFrameGroupBy" has incompatible type
   7625         # "Union[bool, NoDefault]"; expected "bool"
-> 7626         return DataFrameGroupBy(
   7627             obj=self,
   7628             keys=by,

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/groupby/groupby.py in __init__(self, obj, keys, axis, level, grouper, exclusions, selection, as_index, sort, group_keys, squeeze, observed, mutated, dropna)
    886             from pandas.core.groupby.grouper import get_grouper
    887
--> 888             grouper, exclusions, obj = get_grouper(
    889                 obj,
    890                 keys,

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/groupby/grouper.py in get_grouper(obj, key, axis, level, sort, observed, mutated, validate, dropna)
    875         # allow us to passing the actual Grouping as the gpr
    876         ping = (
--> 877             Grouping(
    878                 group_axis,
    879                 gpr,

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/groupby/grouper.py in __init__(self, index, grouper, obj, level, sort, observed, in_axis, dropna)
    533                 raise ValueError(f"Grouper for '{t}' not 1-dimensional")
    534
--> 535             self.grouping_vector = index.map(self.grouping_vector)
    536
    537             if not (

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/indexes/base.py in map(self, mapper, na_action)
   5505         from pandas.core.indexes.multi import MultiIndex
   5506
-> 5507         new_values = self._map_values(mapper, na_action=na_action)
   5508
   5509         attributes = self._get_attributes_dict()

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/core/base.py in _map_values(self, mapper, na_action)
    868
    869         # mapper is a function
--> 870         new_values = map_f(values, mapper)
    871
    872         return new_values

/opt/anaconda3/envs/p39/lib/python3.9/site-packages/pandas/_libs/lib.pyx in pandas._libs.lib.map_infer()

TypeError: 'RadioButtonGroup' object is not callable

Hi @sophiamyang .

Could you update the code example to make it runnable. Right now imports are missing.
Could you take a screen shot of error? It can sometimes help understand the context of the problem and provide more assurance that there is a real, reproducible problem.

Thanks.

Thanks @MarcSkovMadsen, I updated the code example and added the error message.

So I have made a somewhat working example of this problem as far as I can see (correct me if I'm wrong).
The example

The code
import holoviews as hv
import hvplot.pandas  # noqa
import panel as pn
from bokeh.sampledata.autompg import autompg_clean as df

hv.extension("bokeh")

idf = df.interactive()
cylinders = pn.widgets.IntSlider(start=4, end=8, step=2)
mfr = pn.widgets.ToggleGroup(
    options=["ford", "chevrolet", "plymouth", "honda", "sbaru", "volkswagen"],
    value=["ford", "chevrolet", "plymouth", "honda", "sbaru", "volkswagen"],
)
xaxis = pn.widgets.RadioButtonGroup(name="X axis", options=["mpg", "yr"])
yaxis = pn.widgets.RadioButtonGroup(name="Y axis", options=["hp", "weight"])

ipipeline = (
    idf[(idf.cyl == cylinders) & (idf.mfr.isin(mfr))]
    .groupby(["origin", xaxis])[yaxis]
    .mean()
    .to_frame()
    .sort_values(xaxis)
    .reset_index()
)

pn.Column(ipipeline.hvplot(x=xaxis, y=yaxis), ipipeline.output(), sizing_mode="stretch_both").servable()

https://user-images.githubusercontent.com/19758978/149665536-ae418884-985d-40b9-83ec-f59ab7521b7e.mp4
Changes
I have made two changes in the code base to get this example to work.
Change 1
The first is in hvplot:
https://github.com/holoviz/hvplot/blob/25f3285c8ac315e96929b57504e4674d40b947b5/hvplot/interactive.py#L22
Where I added this line afterwards:
op_args = np.atleast_1d(op_args).ravel().tolist()

This is done to flatten the arguments and therefore recognize the xaxis as a widget when inside a list in groupby.
Change 2
The second change is done in Holoviews:
https://github.com/holoviz/holoviews/blob/cc6b27f01710402fdfee2aeef1507425ca78c91f/holoviews/util/transform.py#L579-L606
Where I have added this to the if statement for argument and keyword arguments , respectively:
elif isinstance(arg, Iterable):
    arg = [resolve_dependent_value(a) for a in arg]

elif isinstance(v, Iterable):
    v = [resolve_dependent_value(a) for a in v]

Both is done to convert the widget into an actual value. Iterable is imported with from collections.abc import Iterable
Problems
There is some problems I have noticed:

The plot is not updating when changing the cylinder slider, but it updates the DataFrame.
I can't disable "volkswagen" in the ToggleGroup.
I tried adding by=origin to ipipeline.hvplot with no success.

The reason why is the plot is not updating when I change the cylinder slider is that both it and the mfr toggle group have no name. This means that if I change the order of them in the ipipeline it is the toggle group which becomes unresponsive. If I give one of the widget a name both of them will work. This should be fixed upstream in holoviews to avoid it overwriting widgets with no (or the same name).

Thanks so much @Hoxbro. Why is this only a problem in the notebook?

Thanks so much @Hoxbro!

No problem, glad I could help - so you're able to share with the world how awesome the holoviz stack is.

For the last of the problems about how I can't disable "volkswagen". It is because a HSpacer is blocking it and if i add pn.extension(sizing_mode="stretch_width")  I'm able to click on it.


picke_files can't get path property in web mode

import flet
from flet import (
  Page,
  ElevatedButton,
  FilePicker,
  FilePickerResultEvent
)
def main(page: Page):
  def select_file(e: FilePickerResultEvent):
     print(e.files)

  pfd = FilePicker(on_result=select_file)
  page.overlay.append( pfd)
  page.add(
      ElevatedButton(text='pick file', on_click=lambda _: pfd.pick_files()),
  )

flet.app(target=main,port=80)

In flet-app mode，it‘ running with no problem
 [FilePickerFile(name='msedgedriver.exe', path='D:\\system\\flet\\msedgedriver.exe', size=15517120)]
but in web-browser it can not get the path property
 [FilePickerFile(name='msedgedriver.exe', path=None, size=15517120)]

Maybe add bytes property to FilePickerFile is a good solution, Because the underearth lib used is file_picker, see also https://github.com/miguelpruivo/flutter_file_picker#load-result-and-file-details.
Now I have some code as follows, the open text file on web is not support currently.
  def read_file_content(file_picker_file: FilePickerFile):
    # https://flet.dev/docs/controls/filepicker#result
    # path - full path to a file. Works for desktop and mobile only. None on web.
    # TODO: support web, add bytes property to FilePickerFile
    # see also https://github.com/miguelpruivo/flutter_file_picker#load-result-and-file-details
    if file_picker_file.path is None:
      alert_dialog = AlertDialog(title=Text("Not supported on web currently, please paste the content manually"))
      page.dialog = alert_dialog
      alert_dialog.open = True
      page.update()
      return
    with open(file_picker_file.path, "r") as f:
      return f.read()

  def on_file_pick_result(e: FilePickerResultEvent):
    global current_file_mode
    choosed_file: FilePickerFile = e.files[0] if e.files else None
    txt_content = txt_content1 if current_file_mode == File_MODE.FILE1 else txt_content2
    if choosed_file:
      txt_content.value = read_file_content(choosed_file)
    page.update()

I am reading the code, and I tried to add bytes to FilePickerFile. However, I have some problems with transferring bytes data from dart to python using JSON.
@FeodorFitsner Could you help me or give me some advices.
The current wip is on here.

I am reading the code, and I tried to add bytes to FilePickerFile. However, I have some problems with transferring bytes data from dart to python using JSON.
@FeodorFitsner Could you help me or give me some advices.
The current wip is on here.

I have tested my forked file_picker_bytes branch, it's worked as expected.


6177 sleep

Allow flush/compact to be called without a sleep following them.

You'll definitely at least need to squash and merge. Can you possibly run some tests that use these methods on every version >= 2.0 and let me know that they work?


chore(vote): add know votes to vote packet handler

Purpose
As marking votes as know for peers is not sufficient (cache sizes 100k) and checking in verified/unverified queues also (invalid votes is not in either of them). I have introduced additional cache that show performance improvements.
Checking in verified/unverified queues seems to be also quite slow.
TLDR:

processing function speed up 973 [us] -> 500 [us] = 48% !!!!
amplifying level of IN:OUT packets 4.29 -> 1.45 = 66% !!!!

BEFORE:
IN:
[VotePacket -> total_count: 27371, total_size: 6351761 [B], avg_size: 232 [B], processing_duration: 26654686 [us], avg processing_duration: 973 [us], tp_wait_duration:<PHONE_NUMBER>395 [us], avg tp_wait_duration: 92691806 [us]]

OUT
[VotePacket -> total_count: 117504, total_size: 27265706 [B], avg_size: 232 [B], processing_duration: 0 [us], avg processing_duration: 0 [us], tp_wait_duration: 0 [us], avg tp_wait_duration: 0 [us]]

AFTER:
IN:
[VotePacket -> total_count: 51853, total_size: 12031326 [B], avg_size: 232 [B], processing_duration: 25934699 [us], avg processing_duration: 500 [us], tp_wait_duration:<PHONE_NUMBER>7492 [us], avg tp_wait_duration: 225881101 [us]]

OUT
[VotePacket -> total_count: 75288, total_size: 17469704 [B], avg_size: 232 [B], processing_duration: 0 [us], avg processing_duration: 0 [us], tp_wait_duration: 0 [us], avg tp_wait_duration: 0 [us]]

prnet cleaned-up successfully


s3cmd cleanup

@svengabr
Will you delete this branch https://github.com/corona-warn-app/cwa-website/tree/remove-delete-from-s3-bucket, now that the issue is resolved?


How to use mojo playground to run this model?

 How did you manage to run this project in the mojo playground?
Thanks!

Upload stories15M.bin to playground
Upload tokenizer.bin
Upload read directory
Create a notebook
Copy paste llama2.mojo content to code section 1 for example
Add code section 2 and put this call to it main()
Execute both code sections one by one


Feature: Semantic search

Used clip embedding to implement Semantic search

Thank you for your contribution. Very cool feature! It works, but I found a couple of user experience issues.

Album Things uses the search to find the associated photos. Not sure why, but this pr affects the current implementation. This should be changed to just show the images of the Album Thing.
The search times out when scanning, probably because CPU is already utilized heavily. We could use the other search function while it's scanning.
I think the similarity_factor should be higher, to get less false positives.

Because this is a very performance hungry feature, it would be great if you could enable / disable it in the settings via the UI. Some people want to run LibrePhotos on a Raspberry Pi in the future 😅 The similarity factor could also be a setting.

Thank you @derneuere for you feedback. I have made some additional enhancements so that it's easier to use Semantic Search  on low powered devices or opt-out based on users' preference.

Added a settings in the Settings area for user to enable/disable Semantic Search. Default setting is Disabled since semantic search is for use in high end devices only (at least >4 cores 8GB Ram)
Initial clip embedding calculations is done after the setting is first enabled. Leading to faster migrations on upgrade.
Clip Embedding is now calculated in Batches of 64 Rows, gaining performance boost of >100% compared to calculating clip embeddings for just 1 image per batch

I found two edge cases which don't work correctly. Otherwise, it works really well and as one would expect. Awesome work 👍

Thanks @derneuere , I have fixed those two edge cases


WebGL Rendering fails for a High BVAL Diffusion image

000009.dcm.zip
I have no idea why this is failing in WebGL, but it works fine on the canvas renderer.
I get:
WebGL: INVALID_OPERATION: texImage2D: type UNSIGNED_BYTE but ArrayBufferView not Uint8Array
[.Offscreen-For-WebGL-0x7fbf90cd3200]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering

I've run into a similar issue with some secondary capture images that we generated - the bits allocated was 16 bit but the max pixel value was below 255.  In https://github.com/cornerstonejs/cornerstone/blob/master/src/webgl/renderer.js there is the following code:
 if (image.maxPixelValue > 255) {     datatype += '16';   } else {     datatype += '8';   }
So - WebGL assumes that it's an 8 bit array - but the pixels are stored in a 16 bit array. I'm not sure what the right fix would be:

If you know that the data only has an 8 bit range - maybe for memory's sake the data should be copied to an 8 bit array early in the data parsing pipeline.
Or - getImageDataType() needs to look at the DICOM bits allocated instead of max pixel size.

Not sure which is better.

Fixed by @Zaid-Safadi  in #253


Dashboard Certificate Installation  Screen Persists after Adding and Trusting Certificate

I am trying to set up Flynn for the first time, and upon first loading the dashboard, I saw this screen:
Install CA certificate to continue.
I followed the instructions to install and trust the certificate, but each time I load the screen, I am directed back to this screen -- if I click on any of the menu options (backup, status, providers, etc.) it only shows this certificate screen.
I also noticed that the Certificate instructions do not completely load in Firefox, but they do load in Google Chrome.
So, ultimately, I cannot use the dashboard.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Please re-release since adding arm64 support

ARM64 was added here:
https://github.com/sysdiglabs/kube-psp-advisor/commit/4114e4a042f4f93a0d3ea6a54a836ed3557e428b
but there hasn't been a release since then, thus it's still listed as unavailable in krew search.

Workaround for now is
KREW_ARCH=amd64 kubectl krew install advise-psp

@mstemm can someone from the open source team help here to create another release ?

Yes, let me ask about that tomorrow.

I created a tag v3.0.0 and a release from that tag, but it looks like the release process is more than making a github release. @Kaizhe can you explain how to make a release?

Making a release should be good, then it's going to automatically trigger new build in the krew plugin.

Hmm, why the binary is not generated ?

How about we discuss in the kubernetes slack?

@Kaizhe and I debugged, I also needed to update the go version for the github workflow to 1.16. I see the release now:
kubectl krew info advise-psp
NAME: advise-psp
INDEX: default
URI: https://github.com/sysdiglabs/kube-psp-advisor/releases/download/v3.0.1/kube-psp-advisor_v3.0.1_darwin_amd64.tar.gz
SHA256: 3752234c16cac7ad602f4462c0d47ed208b019ddc8a25fb13779bbd3ea9ab531
VERSION: v3.0.1
HOMEPAGE: https://github.com/sysdiglabs/kube-psp-advisor
DESCRIPTION:
Suggests PSPs based on the required capabilities of the currently running
workloads or a given manifest.


New cluster using Talos is not progressing beyond Machines in Provisioning stage.

What happened:
[A clear and concise description of what the bug is.]
The cluster is not coming up, Harvester Loadbalancer is not created, machines never leave provisioning state.
The machines is provisioned in harvester, gets IP from my network. I can attach a console to them. Though its Talos so its not much you get in return.
 The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler" controller="taloscontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="TalosControlPlane" TalosControlPlane="cluster-capi-mgmt-p-01/capi-mgmt-p-01" namespace="cluster-capi-mgmt-p-01" name="capi-mgmt-p-01" reconcileID="b0b79408-8a41-43df-91ef-07fe7d36fa7c"
E0606 19:58:08.739746       1 controller.go:329] "Reconciler error" err="at least one machine should be provided" controller="taloscontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="TalosControlPlane" TalosControlPlane="cluster-capi-mgmt-p-01/capi-mgmt-p-01" namespace="cluster-capi-mgmt-p-01" name="capi-mgmt-p-01" reconcileID="b0b79408-8a41-43df-91ef-07fe7d36fa7c"
I0606 19:58:08.749008       1 taloscontrolplane_controller.go:189] "reconcile TalosControlPlane" controller="taloscontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="TalosControlPlane" TalosControlPlane="cluster-capi-mgmt-p-01/capi-mgmt-p-01" namespace="cluster-capi-mgmt-p-01" name="capi-mgmt-p-01" reconcileID="c37dc309-f8fb-42c7-a375-5faceb9019b9" cluster="capi-mgmt-p-01"
I0606 19:58:09.190175       1 scale.go:33] "controllers/TalosControlPlane: scaling up control plane" Desired=3 Existing=1
I0606 19:58:09.213294       1 taloscontrolplane_controller.go:152] "controllers/TalosControlPlane: attempting to set control plane status"
I0606 19:58:09.220900       1 taloscontrolplane_controller.go:564] "controllers/TalosControlPlane: failed to get kubeconfig for the cluster" error="failed to create cluster accessor: error creating client for remote cluster \"cluster-capi-mgmt-p-01/capi-mgmt-p-01\": error getting rest mapping: failed to get API group resources: unable to retrieve the complete list of server APIs: v1: Get \"https://<IP_ADDRESS>:6443/api/v1?timeout=10s\": tls: failed to verify certificate: x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, ::1, <IP_ADDRESS>, <IP_ADDRESS>, not <IP_ADDRESS>"

cabpt-talos-bootstrap(I dont know if this is relevant):
I0606 19:58:09.206570       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.224117       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.243118       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.280372       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.341804       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-df9f2: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.352557       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-df9f2: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.439369       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-df9f2: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.480714       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-df9f2: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.539945       1 talosconfig_controller.go:186] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-df9f2: Waiting for OwnerRef on the talosconfig"
I0606 19:58:09.548156       1 secrets.go:174] "controllers/TalosConfig: handling bootstrap data for " owner="capi-mgmt-p-01-n48cx"
I0606 19:58:09.717884       1 secrets.go:174] "controllers/TalosConfig: handling bootstrap data for " owner="capi-mgmt-p-01-n48cx"
I0606 19:58:09.720944       1 secrets.go:174] "controllers/TalosConfig: handling bootstrap data for " owner="capi-mgmt-p-01-7shhp"
I0606 19:58:09.756344       1 talosconfig_controller.go:223] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4/owner-name=capi-mgmt-p-01-n48cx: ignoring an already ready config"
I0606 19:58:09.765995       1 secrets.go:243] "controllers/TalosConfig/cabpt-controller/namespace=cluster-capi-mgmt-p-01/talosconfig=capi-mgmt-p-01-npzm4/owner-name=capi-mgmt-p-01-n48cx: updating talosconfig" endpoints=null secret="capi-mgmt-p-01-talosconfig"

What did you expect to happen:
I expected that the caph provider created the LB and proceeded on creating the cluster.
How to reproduce it:
I added the providers for talos (boostrap and controlplane) and ofcourse the harvester provider.
Added 4 files + the harvester secret with the following configuration:
cluster.yaml:
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: capi-mgmt-p-01
  namespace: cluster-capi-mgmt-p-01
spec:
  clusterNetwork:
    pods:
      cidrBlocks:
        - <IP_ADDRESS>/20
    services:
      cidrBlocks:
        - <IP_ADDRESS>/20
    serviceDomain: cluster.local
  controlPlaneRef:
    apiVersion: controlplane.cluster.x-k8s.io/v1alpha3
    kind: TalosControlPlane
    name: capi-mgmt-p-01
  infrastructureRef:
    apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
    kind: HarvesterCluster
    name: capi-mgmt-p-01

harvester-cluster.yaml:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
kind: HarvesterCluster
metadata:
  name: capi-mgmt-p-01
  namespace: cluster-capi-mgmt-p-01
spec:
  targetNamespace: cluster-capi-mgmt-p-01
  loadBalancerConfig:
    ipamType: pool
    ipPoolRef: k8s-api
  server: https://<IP_ADDRESS>
  identitySecret:
    name: trollit-harvester-secret
    namespace: cluster-capi-mgmt-p-01

harvester-machinetemplate.yaml:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
kind: HarvesterMachineTemplate
metadata:
  name: capi-mgmt-p-01
  namespace: cluster-capi-mgmt-p-01
spec:
  template:
    spec:
      cpu: 2
      memory: 8Gi
      sshUser: ubuntu
      sshKeyPair: default/david
      networks:
      -  cluster-capi-mgmt-p-01/capi-mgmt-network
      volumes:
      - volumeType: image
        imageName: harvester-public/talos-1.7.4-metalqemu
        volumeSize: 50Gi
        bootOrder: 0

controlplane.yaml:
apiVersion: controlplane.cluster.x-k8s.io/v1alpha3
kind: TalosControlPlane
metadata:
  name: capi-mgmt-p-01
  namespace: cluster-capi-mgmt-p-01
spec:
  version: "v1.30.0"
  replicas: 3
  infrastructureTemplate:
    apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
    kind: HarvesterMachineTemplate
    name: capi-mgmt-p-01
  controlPlaneConfig:
    controlplane:
      generateType: controlplane
      talosVersion: v1.7.4
      configPatches:
        - op: add
          path: /cluster/network
          value:
            cni:
              name: none

        - op: add
          path: /cluster/proxy
          value:
            disabled: true

        - op: add
          path: /cluster/network/podSubnets
          value:
            - <IP_ADDRESS>/20

        - op: add
          path: /cluster/network/serviceSubnets
          value:
            - <IP_ADDRESS>/20

        - op: add
          path: /machine/kubelet/extraArgs
          value:
            cloud-provider: external

        - op: add
          path: /machine/kubelet/nodeIP
          value:
            validSubnets:
              - <IP_ADDRESS>/24

        - op: add
          path: /cluster/discovery
          value:
            enabled: false

        - op: add
          path: /machine/features/kubePrism
          value:
            enabled: true

        - op: add
          path: /cluster/apiServer/certSANs
          value:
            - <IP_ADDRESS>

        - op: add
          path: /cluster/apiServer/extraArgs
          value:
            anonymous-auth: true

Anything else you would like to add:
I have tried to switch the Loadbalancer config from dhcp to ipPoolRef, and set a pre-configured ippool this also did not work. I think its related to that the LB is never provisioned in the first place.
[Miscellaneous information that will assist in solving the issue.]
Environment:

talos controlplane provider version: 0.5.5
talos bootstrap provider version: 0.6.4
harvester cluster api provider: 0.1.2
harvester version installed on my HP server: 1.3.0
OS (e.g. from /etc/os-release):

So after looking around and thinking a bit I see that our CAPHV is waiting for providerID to be set

I see that you are in your examples including the CPI as a DaemonSet that means that will not be setting the provideID on TalOS since it needs to be bootstraped before the DaemonSet would be started and the CPI setting providerID?
https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/main/templates/cluster-template-kubeadm.yaml#L190
IMHO the controller should be able to get the HarvesterMachine into a state so that the Machine object would phase into Provisioned so that other controllers whether it be Talos' or any else will function with it which is the normal ?

Hi @dhaugli,
which version of the rke2 controlplane and bootstrap provider are you using?

Hi @dhaugli, which version of the rke2 controlplane and bootstrap provider are you using?

We are using Talos bootstrap and Talos controlplane provider in this case.

I have followed the example now from templates, but still it dosent work, and I think I know why. Beacause the caph controller dosent propagate the IP address of the machines into the machine object like:
status:
  addresses:
  - address: <IP>
    type: ExternalIP
  - address: <IP>
    type: ExternalIP
  - address: <DNS NAME OF MACHINE>
    type: InternalDNS

For reference, Vsphere capi controller does this, without this the TalosBoot controller can't see the ip and can't continue the bootstrap process. But my machines does get IP in my network and the qemu agent does report this through harvester.

I found the issue with the CAPH controller, from the principles from Cluster API on how the bootstrap should work:

CAPH controller does not set the machine as ready in the infrastructure provider (even though its running just fine as a VM in Harvester), because CAPH controller is waiting for Provider Id, and the LB is never created (because of this) and with Talos this will just make the nodes end up waiting forever in the bootstrap process, and will not progress.
My friend Endre just made a fix in our own image, and now this works. He attached the fix to this issue.


Feature/search/CLK32-903-SearchScreen

Prerequisite

[x] Self-review :monocle_face:
[x] No Crashes ☠

Root cause

Ui Screen Home
-Ui Screen Search

Solution

update UI Search Screen
Link sence

Impact

Home
Search

Screenshots (Optional)

Dark

Light

          1 Warning

:warning:
Big PR

[ ] I understand that "Search.Placehodel".localized : "General.Search" is now existed in Localized service

[ ] I understand that "Search.Title.Error" is now existed in Localized service

[ ] I understand that "Search.GroupChat" is now existed in Localized service

[ ] I understand that "Search.Message" is now existed in Localized service

[ ] I understand that "Search.People" is now existed in Localized service

  Generated by :no_entry_sign: Danger


Fix dereferencing nullptr

Dereferencing nullptr node causes crash on osx’s clang.

Good point. Thank you.


return chunk meta with MaxInt64 if chunk is opened.

Signed-off-by: Bartek Plotka<EMAIL_ADDRESS>

Obiously more testing and ensuring it does not break other things is required!


Clear all entries from the database

As a user, I want to be able to clear all entries from the database, providing me with a convenient method to reset or empty the database when necessary.

Already implemented under AB3 framework


Failed: memory not established (Azure Cognitive Search)

I have a freshly deployed application where I used the Deploy to Azure button and specified AzureCognitiveSearch as the memoryStore. However, when I try to upload .pdf or .txt files I get "Failed: memory not established".
In addition

looking in the resource group there is no 'Azure Cognitive Search' resource present. My assumption is that specifying it and not having a place to provide a link to an existing resource means the deployment should have created the resource.
the main.bicep file does indicate that ACS should be deployed:

resource azureCognitiveSearch 'Microsoft.Search/searchServices@2022-09-01' = if (memoryStore == 'AzureCognitiveSearch') {
  name: 'acs-${uniqueName}'
  location: location
  sku: {
    name: 'basic'
  }
  properties: {
    replicaCount: 1
    partitionCount: 1
  }
}

and there were no deployment errors reported

To Reproduce
Steps to reproduce the behavior:

Deploy new instance
Specify memoryStore=AzureCognitiveSearch
Drop .pdf file on the page
See error

Expected behavior
I expect the files to be uploaded and embedded into ACS.
Screenshots

Platform

OS: Windows
IDE: NA
Language: NA
Source: right here

Additional context
Add any other context about the problem here.

Hi @seajhawk, thank you for reporting this, we'll investigate this issue and get back to you.

Correction - I do see that ACS was created (acs-copichat-[uniquename])

I've got it working now. I needed to deploy text-embedding-ada-002 in my Azure OpenAI resource.
I missed that requirement in the readme.md because I clicked the "Deploying Chat Copilot" link above the requirement so I could deploy to Azure.
It might help others if you mention the Deployed Models requirements in the readme.md prior to the instructions to deploy to Azure, or to include those requirements on the deploy to Azure page.

Glad to see this is resolved. We'll update the README to make this clearer, thanks!

Yes, you have to put the name of the EmbeddingModel when you run the configure.ps1 script. Make sure that it's the name that you gave it in the Azure AI Studio.

Yes, you have to put the name of the EmbeddingModel when you run the configure.ps1 script. Make sure that it's the name that you gave it in the Azure AI Studio.

I appreciate the help, but to be clear for any who read this in the future, I didn't run the configure.ps1. I Deployed to Azure using the instructions at https://github.com/microsoft/chat-copilot/blob/main/scripts/deploy/README.md, and I used the Deploy to Azure button.


fixes reading position in history on internal links

Closes: #676
optimized this PR https://github.com/d-i-t-a/R2D2BC/pull/677

@gotson please review this PR and let me know if this solves your issue as well. the reason for this is, there is a scenario where if we just remove the check like in your PR, we will have double entries in history, for example, you select a chapter from TOC, and you don't scroll or page but click a link within that chapter, you will see 2 entries for progression 0 on that chapter. which would mean the user has to go back twice

@aferditamuriqi this seem to fix the original issue, so you can close #677


Update article to use Import-AzureKeyVaultCertificate

There's no need to load the cert and save it into Key Vault using Set-AzureKeyVaultSecret, you can use Import-AzureKeyVaultCertificate directly. Works fine.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ac102a5-e9ad-0046-f217-446f1ad263c5
Version Independent ID: a47523e2-0c30-dee4-0037-5f58836fa37f
Content: Add an HTTPS endpoint to a Service Fabric app in Azure
Content Source: articles/service-fabric/service-fabric-tutorial-dotnet-app-enable-https-endpoint.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Thanks for the feedback! We are currently investigating and will update you shortly.

Couldn't you also load it at runtime with the APIs?

I am attempting this with a cert in the Keyvault.
Can you please explain what steps I can leave out.
I have left out all the ps scripts and can get it to run locally but not remote.
Adjusted the ps script to go to vault but not sure that is needed? Surely on kestrel setup it gets cert and loads it?
Any example using KV greatly appreciated.

Here is an example of our code, it worked great.
protected override IEnumerable<ServiceInstanceListener> CreateServiceInstanceListeners()
        {
            ConfigurationPackage configurationPackage = Context.CodePackageActivationContext.GetConfigurationPackageObject("Config");
            UnityConfig.ServiceTypeName = Context.ServiceTypeName;
            UnityConfig.MicrosoftAppId = configurationPackage.Settings.Sections["Bot"].Parameters["MicrosoftAppId"].Value;
            var keyVault = ProxServiceDirectory.GetService<IKeyVault>(ProxServiceDirectory.KeyVaultConnector);
            UnityConfig.MicrosoftAppPassword = keyVault.GetSecretAsync("ProxBotAppPassword").Result;

            X509Certificate2 cert = GetCertificateFromKeyVault();

            return new ServiceInstanceListener[]
            {
                new ServiceInstanceListener(serviceContext =>
                    new KestrelCommunicationListener(serviceContext, "EndpointHttps", (url, listener) =>
                    {
                        ServiceEventSource.Current.ServiceMessage(serviceContext, $"Starting WebListener on {url}");
                        return new WebHostBuilder()
                                .UseKestrel(opt =>
                                {
                                    int port = serviceContext.CodePackageActivationContext.GetEndpoint("EndpointHttps").Port;
                                    opt.Listen(IPAddress.IPv6Any, port, listenOptions =>
                                    {
                                        listenOptions.UseHttps(cert);
                                        listenOptions.NoDelay = true;
                                    });
                                })
                                .ConfigureAppConfiguration((builderContext, config) =>
                                {
                                    config.AddJsonFile("appsettings.json", optional: false, reloadOnChange: true);
                                })
                                .ConfigureServices(
                                    services => services
                                        .AddSingleton<HttpClient>(new HttpClient())
                                        .AddSingleton<FabricClient>(new FabricClient())
                                        .AddSingleton<StatelessServiceContext>(serviceContext))
                                .UseContentRoot(Directory.GetCurrentDirectory())
                                .UseStartup<Startup>()
                                .UseServiceFabricIntegration(listener, ServiceFabricIntegrationOptions.None)
                                .UseUrls(url)
                                .Build();
                    }))
            };
        }

        private X509Certificate2 GetCertificateFromKeyVault()
        {
            ConfigurationPackage configurationPackage = Context.CodePackageActivationContext.GetConfigurationPackageObject("Config");
            var keyVault = ProxServiceDirectory.GetService<IKeyVault>(ProxServiceDirectory.KeyVaultConnector);
            var secret = keyVault.GetSecretAsync(configurationPackage.Settings.Sections["SSLConfig"].Parameters["SSLAPICert"].Value).Result;
            var bytes = Convert.FromBase64String(secret);
            X509Certificate2Collection certificateCollection = new X509Certificate2Collection();
            certificateCollection.Import(bytes, "", X509KeyStorageFlags.PersistKeySet);
            return certificateCollection[0];
        }
    }

thanks for prompt reply. I have similar working locally. Could not get remote version working.....so I started to wonder if I needed the SetCertAccess.ps1 scriptt
so to be clear you have not needed to use any of the PS scripts?

The only local cert I needed was the KV cert which I uploaded to the SF cluster and made available to the role. I used no PowerShell scripts for any of this, only native SF code and KV APIs.

Thank you for taking the time to share your product and documentation feedback with us. Your input is valued because it helps us create the right documentation for our customers.
Due to the volume of issues in our queue, our policy is to close issues that have been inactive for the last 90 days. We hope to continue hearing from you.
Thank you.
#please-close


pinot-quickstart companion container for thirdeye

Expands upon @fx19880617 pinot-thirdeye docker images to enable fully functional startup of ThirdEye as single companion container. The image supports dashboarding, live anomaly detection, and optional data ingestion from pinot. We integrate a dedicated H2 database instance and both, a thirdeye-dashboard process and a thirdeye-controller process. Furthermore, we support multiple startup modes:

default - ThirdEye with repo default configs
ephemeral - ThirdEye with mock data generated on the fly (pinot not required)
pinot-quickstart - ThirdEye with auto-ingestion from pinot-quickstart

Docker image build: docker/images/pinot-thirdeye/docker-build.sh
Docker container launch: docker run --network=pinot-demo --name thirdeye -p 1426:1426 -p 1427:1427 -d thirdeye:latest pinot-quickstart

Codecov Report

Merging #5125 into master will increase coverage by 8.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5125      +/-   ##
============================================
+ Coverage     49.29%   57.52%   +8.22%
  Complexity       12       12
============================================
  Files          1183     1183
  Lines         62377    62369       -8
  Branches       9139     9136       -3
============================================
+ Hits          30748    35877    +5129
+ Misses        29196    23848    -5348
- Partials       2433     2644     +211

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/apache/pinot/spi/data/TimeFieldSpec.java
92.59% <0%> (-1.24%)
0% <0%> (ø)

...pql/parsers/PinotQuery2BrokerRequestConverter.java
88.07% <0%> (+0.45%)
0% <0%> (ø)
:arrow_down:

...ment/creator/impl/SegmentColumnarIndexCreator.java
88.25% <0%> (+0.75%)
0% <0%> (ø)
:arrow_down:

.../helix/core/realtime/SegmentCompletionManager.java
70.63% <0%> (+0.85%)
0% <0%> (ø)
:arrow_down:

.../FixedByteSingleColumnSingleValueReaderWriter.java
98.94% <0%> (+1.05%)
0% <0%> (ø)
:arrow_down:

...t/common/response/broker/BrokerResponseNative.java
90.52% <0%> (+1.05%)
0% <0%> (ø)
:arrow_down:

...not/broker/broker/helix/ClusterChangeMediator.java
74.72% <0%> (+1.09%)
0% <0%> (ø)
:arrow_down:

...e/io/writer/impl/MutableOffHeapByteArrayStore.java
85.71% <0%> (+1.09%)
0% <0%> (ø)
:arrow_down:

.../pinot/broker/broker/helix/HelixBrokerStarter.java
71.97% <0%> (+1.27%)
0% <0%> (ø)
:arrow_down:

...g/apache/pinot/common/request/InstanceRequest.java
28.83% <0%> (+1.37%)
0% <0%> (ø)
:arrow_down:

... and 298 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91850cd...a48149d. Read the comment docs.


bitwarden-desktop: rename from bitwarden; misc cleanup

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CI wants us to move this to pkgs/by-name since it's arguably a new package. I leave it up to you whether we ignore that.

Are you okay with moving bitwarden-cli as well?

Sure.


feat(ci): add tests to circle ci

Fix #98

Deploy preview for spb-frontend processing.
Built with commit fa6e4eaa935383731cf5d4c8d87d82743903440a
https://app.netlify.com/sites/spb-frontend/deploys/5be8e0f10097d4179870b816


Confirming that #32 was fixed in an earlier commit

Issue #32 was actually fixed in commit e732820d060a836ac3eded65c0df4449f72954b1


Fixes repo update to also point to zenhack

The startme script pointed to a different repo than the Dockerfile. Because of this, ACMEv2 support was removed on each run unless refresh was disabled.
This resolves that issue.

Please hold off on merging... resolving errors with building Docker image.

Just an update (also tagging dokku/dokku-letsencrypt#183)
This pull request can now be merged. It fixes a simple oversight and fixes Dockerfile build process.
Another pull request will need to be created (I will do this asap) against dokku/dokku-letsencrypt to resolve a few issues with using this updated Docker image.

The change is pushed. I still need to do testing so don't merge yet. I'll post on all pull requests when ready.
Note that documentation points to dokku/letsencrypt-simp_le so I'm going to use that name in the other pull requests too. This docker image will need to built with that tag and the old one at dokkupaas/letsencrypt-simp_le should be deprecated in some way. If you disagree let me know and I can point everything to dokkupaas/letsencrypt-simp_le instead.

If it passes review, you can merge this. I have tested it extensively on my end.


User/Employees Suddenly Not Working

[1] pry(main)> ::SugarCRM.connect('[siteurl]', '[user]', '[pass]')
=> SugarCRM::Namespace0
[2] pry(main)> ::SugarCRM::User.first
NameError: uninitialized constant SugarCRM::User
from /usr/local/bundle/bundler/gems/sugarcrm-360060139b13/lib/sugarcrm/module_methods.rb:88:in `const_missing'

::SugarCRM.connection.get_entry("Users", 1) fails too.
So far all other modules seem to work fine. I've attempted rolling back code each release for a month, all exhibit the same issue.
Trying to hunt down why, started 6 days ago, fairly sporadic, I'm tempted to chalk this up to something SugarOnDemand is doing but figured I'd mention it here in case anyone else is experiencing issues (though it starting on a day that I had released software I had suspected a Gem conflict...).
Modules are missing from the modules list -- logged in as an admin.

Known problem with 7.x:
https://web.sugarcrm.com/support/issues/357e6957-f0c0-6886-5dcc-57d85eec993c
Awaiting fix, may provide a workaround here if they don't fix it soon...

Thanks for the update!

I just ended up shimming the API call here:
https://github.com/chicks/sugarcrm/blob/master/lib/sugarcrm/connection/api/get_available_modules.rb
    mods = send!(:get_available_modules, json)["modules"]
    mods += %w(Employees Users)
    modules = []

It's terrible but I think preforms as a decent shim. Still no word on a fix from Sugar though.

Cool - sometimes the old tricks are the best tricks :)


assign-peer-reviews crashes when assigning students to issue

The assignees=reviewers assignment causes a crash.

Probably caused by this:
https://github.com/slarse/repomate/blob/8ba89aaa5e7961610bb9d2dad8838b24f7224084/repomate/github_api.py#L415-L420
in combination with this:
https://github.com/slarse/repomate/blob/8ba89aaa5e7961610bb9d2dad8838b24f7224084/repomate/github_api.py#L388-L394
The repo is added to the team after the yield, so when the reviewers are assigned to the issue, they don't actually have read access to it. Oops.


Recognizing activity realtime

Can you please share the pretrained model and testing code? Im having hard time while trying to extracting the rgb frames and compute optical flow for activity recognition... Thank you

Did anyone try to download the pretrained models from google drives? Because they are corrupted.


JFR Image Size: Support reading plugin manifest files for plugins in ClassPath

JFR Packaging POM currently prepares a Jenkinsfile Runner bundle (appassembler ZIP) where plugins are included into the bundle. They are available in the classpath, but JFR Plugin Manager cannot recognize the plugins because of the missing plugin Manifest resources. After that, API like PluginManager#getPlugin(String) do not work properly and cause random issues in plugins. It would be nice to have a way to read proper manifests of plugins included into classpath.
This is a second stage of #389 which makes JFR to consume the file. This is also an obstacle I referenced in #368 from @PierreBtz
Acceptance Criteria

Jenkinsfile Runner's Plugin Manager implementation is updated to support reading the manifest file generated in #389. The Plugin Manager reads the Manifest file on the JFR startup and initializes the loaded plugin list accordingly (passed by option or a specific resource location)

Taking JENKINS-48885, it might make sense to implement this code in a library or the Jenkins Core  so that both Jenkinsfile Runner and Jenkins Test Harness can use the same codebase.

Initialization happens before --plugins argument is processed. It will also help to discover conflicts between plugins in the classpath and what is supplied by the plugins file
Vanilla and App packaging in this repository are updated to use the plugin manifest file
There is test coverage which verifies that the desired plugins were loaded by Jenkinsfile Runner

Notes
Depends on #389

https://github.com/oleg-nenashev/lib-bom-jep309/pull/1 as a foundation lib


getEventStream throws "Bad callback given: undefined"

Using any of the spark.getEventStream examples from the docs, e.g.
spark.getEventStream(false, 'mine', function(data) {
  console.log("Event: " + data);
});

results in this error:
"Error: Bad callback given: undefined
    at request (chrome-extension://fbpknjbdgcpahjemekijemfgpckpiopg/lib/spark.min.js:1:22758)
    at SparkApi.getEventStream (chrome-extension://fbpknjbdgcpahjemekijemfgpckpiopg/lib/spark.min.js:1:6656)
    at Spark.getEventStream (chrome-extension://fbpknjbdgcpahjemekijemfgpckpiopg/lib/spark.min.js:1:20977)
    at <anonymous>:2:7
    at Object.InjectedScript._evaluateOn (<anonymous>:762:137)
    at Object.InjectedScript._evaluateAndWrap (<anonymous>:695:34)
    at Object.InjectedScript.evaluate (<anonymous>:609:21)"

This spark instance is logged in and has an access token.
Edit: using device.subscribe has the same error.
The error comes from SparkApi.prototype.getEventStream not passing the callback to request, which then throws.

+1

+1 - events are unusable from JS at this point?

+1

This has been deployed to npm, bower, and CDNs.

Thanks, Doc!
On Mon Feb 02 2015 at 7:14:24 PM Zachary Crockett<EMAIL_ADDRESS>wrote:

This has been deployed to npm, bower, and CDNs.
—
Reply to this email directly or view it on GitHub
https://github.com/spark/sparkjs/issues/39#issuecomment-72566968.

Still no dice on this -- both the current version from the CDN and the distro I built from head (which actually differs than the distro that's currently checked in) both throw the same error for getEventStream:
spark.login( { username: user, password: pass }, function() {
        spark.getEventStream( false, 'mine', function( data ) {
        console.log( "Event: " + data );
    } );
} )

Uncaught TypeError: undefined is not a function @spark.min.js:1
Spark._createStreamProcessor.Processor.watch @spark.min.js:1
Spark.getEventStreamarrow2.html:103 (anonymous function) @spark.min.js:1
Spark.emitAndCallback @spark.min.js:1
(anonymous function) @spark.min.js:1
on_end @spark.min.js:1
on_state_change @spark.min.js:1

I get the same error when I call device.subscribe() as shown in the docs.
> device
Device {_spark: Spark, attributes: Object, id: "54ff6a066667515117431567", name: "matrix", lastApp: null…}
> device.getVariable("read_adc").then(function(data) { console.log(data.result) })
Promise {_handler: Pending, then: function, catch: function, _beget: function, spread: function…}
564
> device.subscribe("adc", function(data) { console.log(data) })
spark.min.js:1 Uncaught TypeError: undefined is not a function
Spark._createStreamProcessor.Processor.watch spark.min.js:1
Spark.getEventStream spark.min.js:1
Device.subscribe

As others have mentioned, and as documented in #49, this is still an issue.

if anyone has specific steps to reproduce, that would be fabulous!

Literally any of the examples in the docs crashes in the browser.

This is with a copy of spark.js downloaded from CDN just now, running latest Chrome.


[FEAT] Search/filter by badge

Is your feature request related to a problem? Please describe.
I recently started using Pulsar after spending a while away after Atom was sunset. Most of the packages I had installed for Atom continue to work, which is great, but after looking around at the packages I have found that some of my previously installed are badged with "Outdated" or "Broken" or whatever. I also see that there are some packages that have been explicitly "Made for Pulsar". As it is, I don't see a way to only view "Outdated", "Broken" or "Made for Pulsar" packages. Sorry if this is in fact possible, but I looked on the site, on the API, and glanced at some docs without seeing how.
Describe the solution you'd like
Being able to list only by badge would help me audit my installed packages, and discover new ones. Eg:

Only "outdated" to see which of my packages may need to be updated manually
Only "broken" to see which of my packages may be silently malfunctioning
Only "Made for Pulsar" to see some of the new energy in the Pulsar community

Thank you!

Thanks a ton for contributing!
This is a great suggestion to consider, although I'd like to just quickly clarify that while we can and should add these flags to the search, this will not effect search of installed packages in Pulsar, that behavior will need to additionally be added within settings-view.
But otherwise, I think it's a great idea to be able to filter packages based on flag status. Being able to filter based on "Made for Pulsar" is more than trivial, although filtering based on "Outdated" and "Broken" may be more difficult. What I may look at doing, even if just temporarily is adding two new filtering mechanisms.

creation: Which could allow options of pulsar or atom which could return listings of packages that were originally published for Atom, or obviously the ones originally published for Pulsar. (Which should accomplish filtering the "Made for Pulsar" badge.)
badge: At first this may just be a boolean option that allows discovery of a package containing any badge, this would return any package that contains "Broken", "Outdated" or any other badges, besides "Bundled" or "Made for Pulsar" (As those badges are added during delivery time, rather than baked into the package data). Then if I am eventually able to find a way to filter by a specific badge, we can expand this same query parameter from a simple boolean to supporting a string allowing specification of the badge type to filter by.

I think this is the most realistic approach, but what do you think?


Replacing items in a list

Describe the bug
I am using the Q# environment. I am trying to replace an element in a array with another element. Specifically a qubit for another qubit.
To Reproduce
Steps to reproduce the behavior:

Open .qs file
Create a set of qubits
try accessing the qubits by using brackets s.t. qubits[i] = x
Error: Invalid symbol declaration. Expecting either a single symbol or a symbol tuple

Expected behavior
I expected to replace the qubit.
Screenshots
If applicable, add screenshots to help explain your problem.
System information
Windows, Python 3.7.7 64bit, VSCode
Additional context
Add any other context about the problem here.

Thanks for your question, @mridulsar! Like all other data types in Q#, arrays are immutable values; that in particular means that you cannot change a single element in an array to have a different value. Rather, you can use update-and-reassign statements together with the w/ operator to achieve the same effect in an immutable fashion.
For example:
mutable xs = [0, 1, 2];
set xs w/= 1 <- 10;
Message($"{xs}"); // prints [0, 10, 2]

As with other update-and-reassign statements, w/= is equivalent to a set statement and a use of the w/ operator, so that the above could also be written more explicitly as:
mutable xs = [0, 1, 2];
set xs = xs w/ 1 <- 10;
Message($"{xs}"); // prints [0, 10, 2]

For more details, I suggest checking out the following blog posts:

https://devblogs.microsoft.com/qsharp/qsharp-06-language-features-and-more/#mutability
https://dev.to/crazy4pi314/an-array-of-facts-on-arrays-in-q-50m2

If you have more questions, we're happy to help. I'd also suggest that https://quantumcomputing.stackexchange.com/ is a great resource for asking questions about developing quantum applications with Q#.

This helps me quite a bit! Thank you!

No worries, @mridulsar, happy to help!


fftw3:  no such file or directory

I have install the FFTW3 but when I run python setup.py build_ext
the error show with
lq@lq-virtual-machine:~/下载/lear-gist-python-master$ python setup.py build_ext -I /usr/local/include -L /usr/local/lib
running build_ext
building 'gist' extension
gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/lq/anaconda2/lib/python2.7/site-packages/numpy/core/include -I/usr/local/include -I/home/lq/anaconda2/include/python2.7 -c lear_gist-1.2/gist.c -o build/temp.linux-x86_64-2.7/lear_gist-1.2/gist.o -DUSE_GIST -DSTANDALONE_GIST
lear_gist-1.2/gist.c:14:19: fatal error: fftw3.h: 没有那个文件或目录
compilation terminated.
error: command 'gcc' failed with exit status 1
the chinesemeans : no such file or directory

It seems FFTW is not installed at /usr/local/include and /usr/local/lib.
Please check fftw3.h exists in /usr/local/include and libfftw3f.a exists in /usr/local/lib.
ls /usr/local/include/fftw3.h
ls /usr/local/lib/libfftw3f.a

Alternatively, you can specify the installation path of FFTW by setting --prefix option to ./configure at building it.
For example,
 ./configure --enable-single --enable-shared --prefix=$HOME/local

then FFTW will be installed in ~/local like ~/local/include/fftw3.h and ~/local/lib/libfftw3f.a.
After that, you can build lear-gist-python by
$ python setup.py build_ext -I $HOME/local/include -L $HOME/local/lib

I updated README during writing this answer, so please check it too.
Thank you.


[Minor] Run-on in copy text

VSCode Version: 2213894ea0415ee8c85c5eea0d0ff81ecc191529
OS Version: macOS

This copy is a run-on, because it's two complete sentences joined by a comma. Instead, it should be:

No results found. Run a previous search again:

Repro steps:

Load a fresh VSCode window with no extensions.
Create a file with the following contents:const varThatIsReferenced = 0;
console.log(varThatIsReferenced);

varThatDoesNotExist;

Right click on varThatIsReferenced and choose "Find All References".
Right click on varThatDoesNotExist and choose "Find All References".
See the grammar error in the screenshot above.

Where is this from? I don't think this is even from vscode

I'm so sorry. I should have provided more detail. I mistakenly assumed that it this would be trivial to look up in a message property or translations file. I've updated the OP.

It's from code that isn't in the main repo, so I didn't know where to search.

I would like to give it a try.

fyi - sources can be found here: https://github.com/microsoft/vscode-references-view

Yep, here's the line: https://github.com/microsoft/vscode-references-view/blob/4d22ba8ee293caf7882882281b4002da57b52f8a/src/extension.ts#L37


1541: Add back the username is taken error message in the registration form

Pre-Flight checklist

[x] Testing

[x] Changes have been manually tested

What are the relevant tickets?
https://github.com/mitodl/mitxonline/issues/1541
What's this PR do?
Brings back the react component to display error messages from the serializer for the username field in the registration form.
How should this be manually tested?
Begin the registration process.  When asked to enter a username, enter a username that matches an existing user.  Submit the form and verify that an error message is shown indicating you need to pick another username.

@collinpreston there are tests failing


Does nv-wavenet support higher mu_quantization value?

The default mu_quantization value is 256, and I think higher value of mu_quantization may produce better quality audio.
I did these modifications to test mu_quantization value of 512:

modify values of mu_quantization, n_in_channels, n_out_channels in config.json to 512;
modify value of const int A in wavenet_infer.cu to 512, and re-build the project;
modify the 256 value in inference.py to 512.

But after training the model and inferencing, the produced audio files contain no sound.
Did I miss anything else to modify, or nv-wavenet doesn't support other mu_quantization value?

@nanma did you resolve your issue?

@gsoul No, I didn't further study this issue.


Review export quality of the new images and see if they can be bumped higher

Check if a vector format gives a better display with a reasonable file size.


Missing roberta-base-vocab.json

The package is missing the vocabulary for roberta-base in<EMAIL_ADDRESS>Without it, tokenizer.Pretrained.RobertaBase() throws a FileNotFound Error. There aren't any other vocab.json files in model either, so it's possible this issue happens with other pretrained tokenizers.
Thanks for writing such a cool package!

@johntrob14 ,
Thanks for the report. I've just tagged a new version v0.2.1 with some fixes  including loading pretrained Roberta model.
There's no need such vocab file as you mentioned "roberta-base-vocab.json", but  just use pretrained.FromFile(" PATH_TO_FILE tokenizer.json") with your own tokenizer.json or you can download and cache it directly from Hugggingface model hub. Please, see the example below:
package main

import (
	"fmt"
	"log"

	"github.com/sugarme/tokenizer"
	"github.com/sugarme/tokenizer/pretrained"
)

func main() {
	configFile, err := tokenizer.CachedPath("roberta-base", "tokenizer.json")
	if err != nil {
		panic(err)
	}

	tk, err := pretrained.FromFile(configFile)
	if err != nil {
		panic(err)
	}

	sentence := `The Gophers craft code using [MASK] language.`
	en, err := tk.EncodeSingle(sentence, true)
	if err != nil {
		log.Fatal(err)
	}

	fmt.Printf("%-10s: %q\n", "Tokens", en.Tokens)
	fmt.Printf("%-10s: %v\n", "Ids", en.Ids)
	fmt.Printf("%-10s: %v\n", "Offsets", en.Offsets)
}

// Output:
// Tokens    : ["<s>" "The" "ĠG" "ophers" "Ġcraft" "Ġcode" "Ġusing" "Ġ[" "MAS" "K" "]" "Ġlanguage" "." "</s>"]
// Ids       : [0<PHONE_NUMBER>2 6306 3260<PHONE_NUMBER>4<PHONE_NUMBER> 4 2]
// Offsets   : [[0 0] [0 3] [4 5] [5 11] [12 17] [18 22] [23 28] [29 30] [30 33] [33 34] [34 35] [36 44] [44 45] [0 0]]

I close this issue for now. If you have other feel free to reopen with a simple example to reproduce the issue.
Thanks.

I see that FromFile is fixed - I'll be using that, thank you!
If this is the intended way to access it, why is there a RobertaBase() function at all? That function still doesn't work without adding the vocab file.


Add new regions (eu-north-1, us-gov-east-1, us-gov-west-1)

Issue #, if available:
N/A
Description of changes:
Add new resource specs for Stockholm region (eu-north-1) and both GovClouds! (us-gov-west-1 and us-gov-east-1).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   83.98%   83.98%
=======================================
  Files         111      111
  Lines        5871     5871
  Branches     1330     1330
=======================================
  Hits         4931     4931
  Misses        618      618
  Partials      322      322

Impacted Files
Coverage Δ

src/cfnlint/maintenance.py
37.7% <ø> (ø)
:arrow_up:

src/cfnlint/helpers.py
84.92% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dc3eb...10d7b01. Read the comment docs.


Build failure in Windows (MinGW-W64) due to missing <sys/sysctl.h>

Chipmunk 7.0.0 fails to build in Windows.
The compiler used was MinGW-W64, and the reason appears to be a missing <sys/sysctl.h> include in src/cpHastySpace.c:
[ 20%] Building C object src/CMakeFiles/chipmunk.dir/cpHastySpace.c.obj
C:\Devel\build\Chipmunk-7.0.0\src\cpHastySpace.c:9:24: fatal error: sys/sysctl.h: No such file or directory
 #include <sys/sysctl.h>
                        ^
compilation terminated.
src\CMakeFiles\chipmunk.dir\build.make:342: recipe for target 'src/CMakeFiles/chipmunk.dir/cpHastySpace.c.obj' failed
mingw32-make[2]: *** [src/CMakeFiles/chipmunk.dir/cpHastySpace.c.obj] Error 1
CMakeFiles\Makefile2:76: recipe for target 'src/CMakeFiles/chipmunk.dir/all' failed
mingw32-make[1]: *** [src/CMakeFiles/chipmunk.dir/all] Error 2
makefile:116: recipe for target 'all' failed
mingw32-make: *** [all] Error 2

I was able to work around this issue temporarily by adding the following around the <sys/sysctl.h> include in src/cpHastySpace.c:
#ifndef _WIN32
#include <sys/sysctl.h>
#endif /* not _WIN32 */

I also had to link with a threading library, which I did this way (in src/CMakeLists.txt):
# near the top
find_package(Threads)

# ...
# after the add_library() line:
target_link_libraries(chipmunk ${CMAKE_THREAD_LIBS_INIT})

# ...
# similar for `chipmunk_static`:
target_link_libraries(chipmunk_static ${CMAKE_THREAD_LIBS_INIT})

Adding the threading library additions to src/CMakeLists.txt given breaks configuration on Mac OS X. You need to put those inside platform specific blocks:
if(WIN32)
  ...
endif(WIN32)

They break on MSVC too. So:
if(WIN32 && !MSVC)
  ...
endif(WIN32 && !MSVC)

Apparently, this is also broken in some older versions of FreeBSD (u_int is apparently not present).
I find it odd that this would break on OS X, though; I thought cmake would handle that.

I'm also trying to resolve this more generically, instead of on a per-platform basis, at least in the code.
Someone in the FreeBSD bug report has suggested including <unistd.h> instead of <sys/sysctl.h>, and working in terms of that. @ezavada, could you perhaps check if his <unistd.h> solution (see the attached file) works in OS X? I don't have access to that operating system, myself.

Sorry, I wasn't clear about the Mac OS X problem. The #include <sys/sysctl.h> works fine. The problem on the Mac in the find_package(Threads) and target_link_libraries(chipmunk ${CMAKE_THREAD_LIBS_INIT}).
That said, #include <unistd.h> doesn't give the results you want:
[  3%] Building C object src/CMakeFiles/chipmunk_static.dir/cpHastySpace.c.o
/Users/ezavada/work/pdg/deps/chipmunk/src/cpHastySpace.c:323:3: warning: implicit declaration of function 'sysctlbyname' is invalid in C99
       [-Wimplicit-function-declaration]
             sysctlbyname("hw.ncpu", &threads, &size, NULL, 0);

This is with
Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin14.1.0

@ezavada: I know you meant the threading thing. And it's not just a replacement of the include; again, see the attached file in the previously-linked reply in the FreeBSD issue.

I had this problem compiling for Android. The following change to the includes in cpHastySpace should fix for all platforms:
//#include <sys/param.h >
//#include <sys/sysctl.h>
#ifdef APPLE
#include <sys/sysctl.h>
#else
#include <sys/sysconf.h>
#endif

@slembcke : we over at msys2 have a fix for this
https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-chipmunk/001-build-fix.patch
would you consider merging this patch :)
Many thanks
Martell

As @fuguelike  said, <sys/sysctl.h> is not present on Android. However, Android has <linux/sysctl.h>.


Ability to disable console tips

Hello, big fan of this plugin. But is there a way to configure disabling the "tips" that are logged out into the console? I currently have a lot of output on page load, but would like to have control of reducing this.
This is a fresh page load:

(Yeah I agree this "Orbit" library is really noisy)

Thank you @kchung 👌


fix(adapter-d1): Correctly treat CURRENT_TIMESTAMP result as date

Value inserted by DEFAULT CURRENT_TIMESTAMP on sqlite is not an iso
string, but rather 'YY-MM-DD HH:MM:SS' string.
Fix prisma/team-orm#1057

CodSpeed Performance Report
Merging #23649 will degrade performances by 21.93%
Comparing fix/d1-default-date (499b7e5) with main (dfac408)
Summary
❌ 1 regressions ✅ 2 untouched benchmarks

⚠ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown
Benchmark	main fix/d1-default-date	Change
❌	client generation 100 models with relations	30.7 s	39.3 s	-21.93%

This doesn't seem accurate at all.


Reconcile entity registration

Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes https://github.com/stacklok/minder/issues/3268
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Calling the method via the CLI. (note: please ignore the "nil" as it was part of the print testing)
For simplicity of the testing, I added this as an additional operation as part of the "register" flow. I'm mentioning this in case the screenshot seems confusing at first.

Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

coverage: 53.19% (+0.07%) from 53.12%
when pulling 58bd3b5a7b195154332d2d350100f4ad276454f1 on reconcile-entity-registration
into bb173c2970bcc315139440cf6c2e28459fff3a2c on main.

coverage: 53.311% (+0.09%) from 53.226%
when pulling 703a1e7598f3d0b1016e81a2471806a8fe8fe7ab on reconcile-entity-registration
into cb2e85011c43fd938dc48e129cd0f193477174ce on main.

coverage: 53.321% (+0.1%) from 53.226%
when pulling 703a1e7598f3d0b1016e81a2471806a8fe8fe7ab on reconcile-entity-registration
into cb2e85011c43fd938dc48e129cd0f193477174ce on main.

coverage: 53.453% (+0.2%) from 53.226%
when pulling 74bb67b235e975acb05b8a7274f77a7cb85dca53 on reconcile-entity-registration
into cb2e85011c43fd938dc48e129cd0f193477174ce on main.

coverage: 53.468% (+0.2%) from 53.226%
when pulling 64a7505241f4769c45c38d7adf1b452792e13854 on reconcile-entity-registration
into cb2e85011c43fd938dc48e129cd0f193477174ce on main.

coverage: 53.464% (+0.2%) from 53.226%
when pulling 271269f2b073ef7daf7af16505494c434646c6f4 on reconcile-entity-registration
into cb2e85011c43fd938dc48e129cd0f193477174ce on main.


videojs.extends was renamed to videojs.extend

See: videojs/video.js@61a00db7

This has been done manually.

Thank you for the PR :+1:

Done manually? Fah, I put a lot of work into that PR! Found and deleted that S all by myself.


node: Allow plugins to print their own help messages

Relates to #241

Old, if remains, please re-open


Font Style

I'm new on the world of Flutter, but I'm a quick learner. Everything that I was looking for were easy to found and implement. But now I'm needing a way to implement a Blueetooth Printer for my purpose, and I'm founding a lack of that on the Flutter world. After trying everything, the only package that worked so far for me was this one. The only problem is that the fonts are are not smooth for my readers to read.
So, is there a way of changing the font style? Like bold or the shape itself? That's the only package that worked with my printer (MTP-3), and the package is so nice to use. The only thing that is not helping me out is the font styling (and the spacing too, but I kind worked it out with a little bit of boilerplate but ok... xD).
I'll keep searching for ways to solve my problem and I'll be glad to post the answer here to help out anyone else with the same issue.
I'll apreciate any help. Even a little path to head on. Thank you!

Can you change the font style now? i also need it :+1:  :dancers:

Can you change the font style now? i also need it 👍 👯

Nah! I ended up using another package that's not perfect too but the font style is so not bad.
But I don't believe they updated it and if they did, I would surely come back to this package.

Can you change the font style now? i also need it 👍 👯

Nah! I ended up using another package that's not perfect too but the font style is so not bad.
But I don't believe they updated it and if they did, I would surely come back to this package.

Could you tell wich package are you using please?

This thread has been closed since there has not been any recent activity. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.


support source maps by default

I'd prefer cheap-module-eval-source-map, want to switch to that?

Source map option changed via f47c88e10b17381400559a0827401df9d211b837, but thanks.


Fix (some) issues with compositional grounder- support entity branch and ignore named entities

This PR addresses some issues with the SRL compositional grounder. Some of which had been fixed/discussed earlier, but there was no PR since other issues are still in progress.

Adds support for the ENTITY branch
Stops compositional grounder from grounding named entities
Adds DebugGroundingExporter to aid debugging the grounder
Adds (IN PROGRESS) code in SRLCompositionalGrounder for trying to deduplicate tuples (e.g. when the same grounding is found for both THEME and PROCESS) -- This can easily be removed for now if it's too messy!

@BeckySharp and @kwalcock can you take a look at these changes? A lot of them are things Becky and I added to help with my debugging the compositional grounder back in the day, and they didn't end up getting merged into master.
I need them to help me continue working on the collocations with the compositional grounder.

@BeckySharp and @kwalcock can you take a look at these changes? A lot of them are things Becky and I added to help with my debugging the compositional grounder back in the day, and they didn't end up getting merged into master.
I need them to help me continue working on the collocations with the compositional grounder.

FYI receipt acknowledged.

FYI receipt acknowledged.

i think so -- and we should think carefully about what's in the entity
branch of the ont, and what we think a given extraction/component of an
extraction should ground to (or if it even should ground)
On Mon, Jan 11, 2021 at 10:56 AM zupon<EMAIL_ADDRESS>wrote:

External Email
@zupon commented on this pull request.
In
src/main/scala/org/clulab/wm/eidos/groundings/grounders/SRLCompositionalGrounder.scala
https://github.com/clulab/eidos/pull/937#discussion_r555234868:

override def groundEidosMention(mention: EidosMention, topN: Option[Int] = None, threshold: Option[Float] = None): Seq[OntologyGrounding] = {
// Do nothing to non-groundable mentions
if (!EidosOntologyGrounder.groundableType(mention))
Seq(newOntologyGrounding())

// Do nothing to named entities
if (mention.odinMention.entities.get.toSet.intersect(STOP_NER).nonEmpty) {

The mentions I saw were typically things like Addis Ababa, South Sudan,
and Minister Hailemariam. For the first two, it makes sense to just skip
the whole thing, but what about people with titles (or locations such as Somali
region)? Should we keep the more generic word and only skip the ner
piece? Or will that cause problems?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#discussion_r555234868, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCPDVGTA2GQRPNMZII3SZM3TDANCNFSM4VZR3OBQ
.

i think so -- and we should think carefully about what's in the entity
branch of the ont, and what we think a given extraction/component of an
extraction should ground to (or if it even should ground)
On Mon, Jan 11, 2021 at 10:56 AM zupon<EMAIL_ADDRESS>wrote:

External Email
@zupon commented on this pull request.
In
src/main/scala/org/clulab/wm/eidos/groundings/grounders/SRLCompositionalGrounder.scala
https://github.com/clulab/eidos/pull/937#discussion_r555234868:

override def groundEidosMention(mention: EidosMention, topN: Option[Int] = None, threshold: Option[Float] = None): Seq[OntologyGrounding] = {
// Do nothing to non-groundable mentions
if (!EidosOntologyGrounder.groundableType(mention))
Seq(newOntologyGrounding())

// Do nothing to named entities
if (mention.odinMention.entities.get.toSet.intersect(STOP_NER).nonEmpty) {

The mentions I saw were typically things like Addis Ababa, South Sudan,
and Minister Hailemariam. For the first two, it makes sense to just skip
the whole thing, but what about people with titles (or locations such as Somali
region)? Should we keep the more generic word and only skip the ner
piece? Or will that cause problems?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#discussion_r555234868, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCPDVGTA2GQRPNMZII3SZM3TDANCNFSM4VZR3OBQ
.

Good point -- so FastNLPWithSemanticRoles I think does semantic roles diff
than cluprocessor, so we should extend Cluprocessor instead, and not have a
cluproc?
On Mon, Jan 11, 2021 at 12:04 PM Keith Alcock<EMAIL_ADDRESS>wrote:

External Email
@kwalcock commented on this pull request.
In
eidoscommon/src/main/scala/org/clulab/wm/eidoscommon/EidosProcessor.scala
https://github.com/clulab/eidos/pull/937#discussion_r555273430:

@@ -109,6 +113,32 @@ class EidosPortugueseProcessor(val language: String, cutoff: Int) extends Portug
def getTagSet: TagSet = tagSet
}

+class EidosCluProcessor(val language: String, cutoff: Int) extends FastNLPProcessorWithSemanticRoles

with EidosProcessor with SentencesExtractor with LanguageSpecific {
lazy val eidosTokenizer: EidosTokenizer = new EidosTokenizer(localTokenizer, cutoff)
override lazy val tokenizer = new EidosTokenizer(localTokenizer, cutoff)
val tagSet = new EnglishTagSet()
val cluproc = new CluProcessor()

IntelliJ's "Find Usages" is apparently blind to it. Perhaps the use is
outside its field of vision. The FastNLPProcessorWithSemanticRoles has a
CluProcessor itself, so I think one can do a
val cluproc = this.cluProcessor
or just use cluProcessor instead of cluproc. The things are fairly large
and take time to load.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#discussion_r555273430, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCKBIN2OHF7H64CW2XTSZNDUTANCNFSM4VZR3OBQ
.

Good point -- so FastNLPWithSemanticRoles I think does semantic roles diff
than cluprocessor, so we should extend Cluprocessor instead, and not have a
cluproc?
On Mon, Jan 11, 2021 at 12:04 PM Keith Alcock<EMAIL_ADDRESS>wrote:

External Email
@kwalcock commented on this pull request.
In
eidoscommon/src/main/scala/org/clulab/wm/eidoscommon/EidosProcessor.scala
https://github.com/clulab/eidos/pull/937#discussion_r555273430:

@@ -109,6 +113,32 @@ class EidosPortugueseProcessor(val language: String, cutoff: Int) extends Portug
def getTagSet: TagSet = tagSet
}

+class EidosCluProcessor(val language: String, cutoff: Int) extends FastNLPProcessorWithSemanticRoles

with EidosProcessor with SentencesExtractor with LanguageSpecific {
lazy val eidosTokenizer: EidosTokenizer = new EidosTokenizer(localTokenizer, cutoff)
override lazy val tokenizer = new EidosTokenizer(localTokenizer, cutoff)
val tagSet = new EnglishTagSet()
val cluproc = new CluProcessor()

IntelliJ's "Find Usages" is apparently blind to it. Perhaps the use is
outside its field of vision. The FastNLPProcessorWithSemanticRoles has a
CluProcessor itself, so I think one can do a
val cluproc = this.cluProcessor
or just use cluProcessor instead of cluproc. The things are fairly large
and take time to load.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#discussion_r555273430, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCKBIN2OHF7H64CW2XTSZNDUTANCNFSM4VZR3OBQ
.

IDK which processor is better to use, but the EidosCluProcessor already has access to a CluProcessor via the FastNLPProcessorWithSemanticRoles from which it inherits.  If the inheritance changes it may have to organize its own CluProcessor, unless it happens to be a CluProcessor itself.  It's a very minor detail, but one in master, so I have to be a little careful, especially given memory issues and slow startup time.

IDK which processor is better to use, but the EidosCluProcessor already has access to a CluProcessor via the FastNLPProcessorWithSemanticRoles from which it inherits.  If the inheritance changes it may have to organize its own CluProcessor, unless it happens to be a CluProcessor itself.  It's a very minor detail, but one in master, so I have to be a little careful, especially given memory issues and slow startup time.

FastNLPWithSemanticRoles uses the same SRL system as CluProcessor.

FastNLPWithSemanticRoles uses the same SRL system as CluProcessor.

Although, if this EidosCluProcessor is only used in special cases and not the default configuration, then I should not worry so much.

Although, if this EidosCluProcessor is only used in special cases and not the default configuration, then I should not worry so much.

FastNLPWithSemanticRoles uses the same SRL system as CluProcessor.

I thought you only added the expanded to CluProcessor?
and @kwalcock I don't have strong feelings, i like not having extra processors for sure!  We need access to the semantic roles used by the SRL grounder, no more no less, and we need it to be compatible with the EidosProcessor "framework", otherwise, however we can do it with minimal memory usage is ideal!

FastNLPWithSemanticRoles uses the same SRL system as CluProcessor.

I thought you only added the expanded to CluProcessor?
and @kwalcock I don't have strong feelings, i like not having extra processors for sure!  We need access to the semantic roles used by the SRL grounder, no more no less, and we need it to be compatible with the EidosProcessor "framework", otherwise, however we can do it with minimal memory usage is ideal!

They should use the same code.

They should use the same code.

I removed the in-progress and unused code I was working on in SRLCompositionalGrounder, since it's not my focus right now and keeping it all there makes it pretty ugly.
@kwalcock is there anything else I should change before this can be merged?

I removed the in-progress and unused code I was working on in SRLCompositionalGrounder, since it's not my focus right now and keeping it all there makes it pretty ugly.
@kwalcock is there anything else I should change before this can be merged?

LGTM.  Thanks.  Shall I go ahead and press the merge button?

LGTM.  Thanks.  Shall I go ahead and press the merge button?

good with me!
On Thu, Jan 14, 2021 at 8:18 AM Keith Alcock<EMAIL_ADDRESS>wrote:

External Email
LGTM. Thanks. Shall I go ahead and press the merge button?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#issuecomment-760262695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCK67UBGHGYJLX7HQEDSZ4DLTANCNFSM4VZR3OBQ
.

good with me!
On Thu, Jan 14, 2021 at 8:18 AM Keith Alcock<EMAIL_ADDRESS>wrote:

External Email
LGTM. Thanks. Shall I go ahead and press the merge button?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/937#issuecomment-760262695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCK67UBGHGYJLX7HQEDSZ4DLTANCNFSM4VZR3OBQ
.

Huzzah! Thank you both!

Huzzah! Thank you both!


Add go setup to release creation job

Summary

I'm not entirely sure how this workflow was working before, but we need more control over the version of Go that we are using. I've added a step to install Go 1.16.
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have reviewed the styleguide for guidance on my code quality.

Our other workflows in github-config only set up Go during the unit/integration tests. What part of the release creation step needs a specific Go version?

You can see that we've been unable to cut a release since we stopped using io/ioutil: https://github.com/paketo-buildpacks/packit/actions/workflows/create-release.yml. The codebase now requires you to use Go 1.16, but that doesn't seem to be what is installed on the action runners and so the compilation fails.


Revert PRs #1094 and #1107.

Description
Reverting PRs https://github.com/opensearch-project/alerting-dashboards-plugin/pull/1094 and https://github.com/opensearch-project/alerting-dashboards-plugin/pull/1107 for 2.17.1 patch.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The acknowledge_alerts_modal_spec cypress tests have been failing for a week now, and are unrelated to the changes in this PR. Will investigate those separately.

Closing in favor of https://github.com/opensearch-project/alerting-dashboards-plugin/pull/1111


added PotterAPI

🎯 Title and Issue Number

PotterAPI is a Harry Potter API developed with Express.js and available in multiple languages.
This API stores information and images of books, characters, and spells.
Closes #198

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @DonaldReddy, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

/gssoc24

@DonaldReddy Please mention more about the use case of this API, like where it can be used.

@DonaldReddy ,I wanted to reach out and let you know that we have decided to close your pull request.🙇
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Retrain Model & Serv it

Dear Forum Users,
i was creating a Model with retrain.py on Ubuntu 18.04 in a virtual Machine on my Server (https://www.tensorflow.org/hub/tutorials/image_retraining)
Tensorflow is installed via pip installtion. I'm only using CPU.
after testing it with the python label_image.py it works everthing fine and the detection works great!
so i try'd to serve my own model with the tensorflow-serving (https://github.com/tensorflow/serving.git).
on the github serving-example the execution of the model "half_plus_two" works also pretty well and i was able to connect via the RESTful API.
then i try'd to host my own model (out of the /tmp folder from the retrain.py)
i copy'd/renamed the files from the /tmp folders to the structure of the "half plus two" model, like in the example
"/saved_model_half_plus_two_cpu/" and "/half_plus_two/".
when i try to start the serving via the following cmd:
docker run -t --rm -p 8561:8561
-v "$TESTDATA/saved_model_half_plus_two_cpu:/models/half_plus_two"
-e MODEL_NAME=half_plus_two
tensorflow/serving &
the application says: "No versions of servable half_plus_two found under base path /models/half_plus_two"
could anyone help?
thank you and regards

This issue is more suitable on TensorFlow Serving repo. Please post it on tensorflow/serving from here. Thanks!


use "var" for variable declaration.

Latest SonarCloud finding discovered 159 places where the new "var" declaration could be used. Goal is to upgrade all those places.

The commit have resolved all but one of the findings. The last finding could not be replaced, since it is a String array, where a replacement would lead to a compilation error. Closing ticket.

The usage of var causes problems with JavaDoc, and as it is not having any actual value to replace the Object declarations with var's, it has been reverted.


WIP: Test temperature based recon

@pgrete is this something that can be generalized to also support (in principle) well-balanced reconstruction?

Yes, I think it'd be great if we generalize our reconstruction approaches.
Not sure this is the right PR for this though.
The quick test failed to fix the behavior I'm seeing, so I need to think more about what/how to go about it.


Register this package

This issue will be fixed by https://github.com/JuliaRegistries/General/pull/99519.


Euclidean algorithms (Basic and Extended) in Java

🚀 Feature
Implementation of euclidean algorithm in Java
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
It is an interesting algorithm to learn and implement  Which will help us understand the greatest common divisor and very helpful for the beginners
Please assign me this issue in Java under Dwoc @shraddhavp @HarshCasper

Kindly Assign me this issue under Dwoc

Kindly Assign me this issue under Dwoc

#1991

#1991

#1991 I have worked on the issue please review @shraddhavp (DWOC)

#1991 I have worked on the issue please review @shraddhavp (DWOC)

I have worked on the issue under DWOC please review @shraddhavp

I have worked on the issue under DWOC please review @shraddhavp


fix program tests

Since you updated the way the program decides which tokens go to which buckets, the tests concerning how the bucket states update are now broken. If possible, refactor those tests to match the current program logic. If not, you may have to remove them :'(

fixed


Is NATS Extension of NAS_201 bench

I was working with NAS_201 bench earlier and now am shifting to NATS bench. I have the following doubts:

Will the index of architecture obtained with NAS_201 and NATS bench same for a given arch?  Because when using both NAS_201 is giving 12804 index while NATS bench is returning -1. Also the index of NAS_201 provides different config arch when used as index in NATS.
While obtaining weights I am getting an empty return when using the NAS_201 index.

Following is my implementation. I am using benchmark file with sss.
api = create(d, 'sss', fast_mode=False, verbose=True)
index = api.query_index_by_arch(convert_naslib_to_str(best_arch))
config = api.get_net_config(index, 'cifar10')
best_arch = get_cell_based_tiny_net(config)
logger.info("Queried results ({}): {}".format(metric, best_arch))
params = api.get_net_param(index, 'cifar10', None)
best_arch.load_state_dict(next(iter(params.values())))

The network parameters are contained in full archive files (please follow the instructions at https://github.com/D-X-Y/NATS-Bench#preparation-and-download). Note that those files are pretty large.

Thanks for the response. It is working.


Documention of article IDs for reference training

I replaced

<biblScope type="pp"> the full range of pages

by

<biblScope type="pp"> the full range of pages or the article ID

Coverage remained the same at 39.099% when pulling bf6d0d6cfab20aa987ca71ab3d1988e6f0580e2b on michamos:document-article-IDs into 073114f3b529afde4d9ec67dd58b41e53dd945b2 on kermitt2:master.

many thanks !