KAFKA-18058: Share group state record pruning impl.

What

In this PR, we've added a class ShareCoordinatorOffsetsManager, which tracks the last redundant offset for each share group state topic partition. We have also added a periodic timer job in ShareCoordinatorService which queries for the redundant offset at regular intervals and if a valid value is found, issues the deleteRecords call to the ReplicaManager via the PartitionWriter. In this way the size of the partitions is kept manageable.
Introduced new config share.coordinator.state.topic.prune.interval.ms (default 5 mins).

Why

Currently, the SharePartition invokes the DefaultStatePersister to write data into the internal share group topic __share_group_state. This topic is not eligible for compaction.
If the kafka cluster is run for a long period of time, the topic partitions in __share_group_state will be populated with gigantic amount of records.
In the above scenario if a broker/cluster restarts, all the records will need to be replayed on the leader ShareCoordinatorShard resulting in extensive latency during startup.
One observation is that the records follow a periodic snapshot approach. A snapshot record gets created and then a few incremental updates and after a threshold number,  a snapshot again for each share partition key.
This implies that older records become redundant after a while since they've been superseded by new snapshots. This provides us an opportunity to relieve some pressure from the partitions.

Testing

Added appropriate tests for CoordinatorPartitionWriter, ShareCoordinatorOffsetsManager, ShareCoordinatorService and ShareCoordinatorShard.
Extensive manul testing

Sample o/p
Broker logs
[2024-11-29 15:21:38,289] INFO [UnifiedLog partition=__share_group_state-3, dir=/tmp/kraft-combined-logs] Incremented log start offset to 10 due to client delete records request (kafka.log.UnifiedLog)

Records before prune
{"key":{"version":0,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":0,"stateEpoch":0,"leaderEpoch":0,"startOffset":5,"stateBatches":[{"firstOffset":5,"lastOffset":6,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":0,"leaderEpoch":0,"startOffset":7,"stateBatches":[{"firstOffset":7,"lastOffset":8,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":0,"leaderEpoch":0,"startOffset":9,"stateBatches":[{"firstOffset":9,"lastOffset":9,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":0,"leaderEpoch":0,"startOffset":10,"stateBatches":[{"firstOffset":10,"lastOffset":11,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":0,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":1,"stateEpoch":0,"leaderEpoch":0,"startOffset":12,"stateBatches":[{"firstOffset":12,"lastOffset":14,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":1,"leaderEpoch":0,"startOffset":15,"stateBatches":[{"firstOffset":15,"lastOffset":16,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":1,"leaderEpoch":0,"startOffset":17,"stateBatches":[{"firstOffset":17,"lastOffset":19,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":0,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":2,"stateEpoch":0,"leaderEpoch":0,"startOffset":20,"stateBatches":[{"firstOffset":20,"lastOffset":21,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":2,"leaderEpoch":0,"startOffset":22,"stateBatches":[{"firstOffset":22,"lastOffset":27,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":1,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":1,"data":{"snapshotEpoch":2,"leaderEpoch":0,"startOffset":28,"stateBatches":[{"firstOffset":28,"lastOffset":28,"deliveryState":2,"deliveryCount":1}]}}}{"key":{"version":0,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":3,"stateEpoch":0,"leaderEpoch":0,"startOffset":29,"stateBatches":[{"firstOffset":29,"lastOffset":29,"deliveryState":2,"deliveryCount":1}]}}}

Records after prune
{"key":{"version":0,"data":{"groupId":"gs1","topicId":"o_eD4bB7RNauIV7oPkNRCA","partition":0}},"value":{"version":0,"data":{"snapshotEpoch":3,"stateEpoch":0,"leaderEpoch":0,"startOffset":29,"stateBatches":[{"firstOffset":29,"lastOffset":29,"deliveryState":2,"deliveryCount":1}]}}}

@smjn Please resolve the conflicts.

@smjn Please resolve the conflicts.

@AndrewJSchofield done

@smjn : Thanks for the PR. Made a pass of non-testing files. Added a few comments.

@junrao : Thanks for the review.  Incorporated comments, posted response to a some questions

@smjn : Thanks for the updated PR. Made a pass of all files. A few more comments.

@junrao Thanks again for the review, incorporated all comments.

@smjn : Thanks for the updated PR. A few more comments.

@junrao Thanks for the review, incorporated few changes. Replied to some suggestions.

@smjn : Thanks for the updated PR. Just one more comment.

@junrao Thanks for the review, incorporated change

@junrao No. All good to me. Thanks!

@junrao Thanks for the review. I'll take another look this evening and merge once I'm happy.

A handful of final review comments. I've been running with the pruning enabled and it's happily deleting records as intended.

@AndrewJSchofield Thanks for the review, incorporated comments.


Update OutlierDataCheck to use Woodwork's implementation of outlier detection

https://github.com/alteryx/woodwork/pull/1048 has been merged, so once Woodwork gets a release out, we should update EvalML to use Woodwork's outlier detection implementation :)

@angela97lin Woodwork v0.5.1 was release with outlier detection

https://github.com/alteryx/woodwork/releases/tag/v0.5.1


getting an error when using vagrant for standalone

Attached here is the screenshot of the error i got after i did vagrant up

It would be great if you can help me with this. Thanks a lot


Fetch models for China AI PC Dev Kit users

The models are inaccessible from huggingface.co in China, we need to solve this issue.

Please check if we can switch the domain from https://huggingface.co to https://hf-mirror.com/ for Chinese users.
See if we can load https://modelscope.cn/ via fetch API.

How can we detect if the user is coming from China on the Web?

The https://ipinfo.io/ need to pay for the API access
The Google Maps Geocoding API requires user's permissions for accessing Geolocation API at first

@NingW101

The models are inaccessible from huggingface.co in China, we need to solve this issue.

Please check if we can switch the domain from https://huggingface.co to https://hf-mirror.com/ for Chinese users.
See if we can load https://modelscope.cn/ via fetch API.

Both hf-mirror and modelScope restrict the cross-domain access, fetching resource directly is not available. So the solution is to require users to manually download model files and upload through the load models locally button in UI


Handling Disposition for parts with type text

Hi,
plain-text attachments are defined as type text in mails, which leads to the issue that in your lib I will only get the last item with type TEXT in bodies['text'].
In case of an txt-file you will see the return-parameters of imap_fetchstructure set like this:

  ["type"] => int(0)
  ["ifdisposition"] => int(1)
  ["disposition"] => string(10) "attachment"

That means, this part is an attachment not the text-body-part.
When your Message-Class runs through the parts you will only get the last part with type text in bodies['text'].
You should use the ifdisposition-flag.
I helped myself by changing the first if in fetchStructure of Message.php from

   if ($structure->type == self::TYPE_TEXT) {

to

    if ($structure->type == self::TYPE_TEXT && !$structure->ifdisposition) {

and than just added the TYPE_TEXT-Handling in your attachment-part:

       switch($structure->type) {
           case self::TYPE_TEXT:
               $type = "Text";
               break;

Only parts with not disposition and type text will go into bodies['text'] and the other parts will now end in the attachments. This is just my workaround and will not handle multiple non-attachment text-parts.
The right way would be to first test for the disposition flag and then handle dispositions of type "attachment" as attachment and dispositions of type "inline" or parts without disposition as bodies-parts.
To go deeper into this, there are more disposition-types:
http://www.iana.org/assignments/cont-disp/cont-disp.xhtml
Cheers,
Matthias

Hello,
can you send me example message? I'm colleting different message types to improve this lib.
It will be done for 3 weeks.

Hi,
I sent some examples to the address from your git-account.


"scripts"

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Operating System and Version: [e.g. Ubuntu Linux 18.04]
Browser [e.g. Firefox, Safari] (if applicable):

Additional context
Add any other context about the problem here.

hello, I have a problem about how to preprocess the five distinct domain datasets. when i preprocess the CDCP, there is always debug  called  "Mean of empty slice"

I really thank for you research on argument structure extraction using contextual information. It is very useful. I want to a five preprocessed data if you are willing. Thank you so much.


Add CHANGELOG.md

👋 ,
When I got the PR for Gutentag from @depfu, I noticed that they couldn't find the CHANGELOG. So I figured it might be nice to have one file in place to have that, so tools & humans alike can pick it up (I tend to go through Changelogs often to get a feel how involved an upgrade is and what new features I'll be able to use)
Hope this makes sense to you as well :)

Changelogs are an invaluable resource.  I use them often, and Depfu makes their utility 💯 .

Agreed on all counts 👍


Publish version including miniz_oxide update

Currently image has duplicate dependencies of both miniz_oxide 0.3 and 0.4 due to the png and the tiff crates. It appears it was updated in 4424245d09dac4be32e9c19690fcfe3cc1fbdfcc but this isn't included in the latest release. Can a new release be made with this commit?

Hmm, looking at a linked comment it says miniz_oxide 0.4 isn't compatible with Rust 1.3.4. Is that still the case?

I'm not aware of functional changes of 0.4 compared to 0.3. The main reason for 0.4 in the first place was inclusion into the Rust compiler architecture, and subsequent releases to detect the compiler version to restore compatibility with 1.34.2 again. That being said, it likely does duplicate some amount of code which might cause slight bloat. It's not critical enough to warrant an immediate release but a backport PR would be fine.

Hi there,
I noticed this issue has been quiet for a bit, but it was mentioned in this PR as something that was getting closer. Are there any updates here by chance?

I think it is probably time to go ahead and make publish a new release

I think it is probably time to go ahead and publish a new release

Any update? Thanks.


alerta-housekeeping.js:  "exception: $multiply only supports numeric types, not String"

When I run alerta-housekeeping.js, I get the error below:
assert: command failed: {
	"errmsg" : "exception: $multiply only supports numeric types, not String",
	"code" : 16555,
	"ok" : 0,
	"$gleStats" : {
		"lastOpTime" : Timestamp(1462910955, 2),
		"electionId" : ObjectId("571ea881985b45c7dabb06ec")
	}
}

I'm a mongodb newbie.  Did timeout somehow get created in mongodb as a string?  Any idea how I can recover from this?
Thanks!

I would just delete all the existing alerts with a string timeout...
$ mongo
> use monitoring
> db.alerts.remove({timeout: {$type: "string"}})

And then update your Alerta installation to get the latest version that now prevents strings from being accepted as timeout values.

I'm getting this error trying to remove the existing alerts:
mongos> db.alerts.remove({timeout: {$type: "string"}})
WriteResult({
	"nRemoved" : 0,
	"writeError" : {
		"code" : 2,
		"errmsg" : "$type has to be a number"
	}
})

what version of mongodb is this?

mongo --version
MongoDB shell version: 2.6.4

That version of mongodb doesn't support "aliases" for types ...
https://docs.mongodb.com/v2.6/reference/operator/query/type/#available-types
They were introduced with version 3.2 I think ...
https://docs.mongodb.com/v3.2/reference/operator/query/type/#available-types
So try this instead...
$ mongo
> use monitoring
> db.alerts.remove({timeout: {$type: 2}})

That worked!  Thanks. (Now to upgrade Alerta...)

Great.


chore: use cz-git commitizen adapter

General

✏ Mark the necessary items without changing the structure of the PR template.

[x] Pull request template structure not broken

Type

ℹ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

[x] My code follows the style guidelines of this project
[x] Is the code format correct
[x] Is the git submission information standard?
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

背景
Hi 我是cz-git的作者，偶然之间查看项目，虽然有引入 commitizen 但未使用，我觉得我的cz-git应该可以很大帮助使用 commitizen CLI 的使用者。当然这也是我第一次给完整系统提供解决方案 PR 。如果有其他需求点可以和我说。

github: https://github.com/Zhengqbbb/cz-git
website: https://cz-git.qbenben.com/
中文文档： https://cz-git.qbenben.com/zh/

友好型： 支持搜索和选择在命令行中，减少拼写错误
高度自定义：提供全套的自定义，让 CLI 行为更符合习惯操作
与 commitlint 配合：获取 commitlint 相关配置，给予命令行提示信息
轻量级：正如你所见，整体依赖都下降了许多，czg(1.3 MB) 和 cz-git(1.5 MB) 都是独立零依赖

Demo:

功能点:

利用 git status 获取匹配缓存区的文件路径，自动置顶对应的文件匹配范围(scope)

对于一些常见的commit message 可以使用alais进行定义 yarn commit:<alias name>，如果修改文档错别字，更新依赖等等

支持！！


jax.experimental.host_callback API docs are empty

These aren't getting built properly for some reason:
https://jax.readthedocs.io/en/latest/jax.experimental.host_callback.html

The problem was a missing package dependency. I have fixed this particular problem in #3033.
I am going to try to consolidate our dependencies in one place (#3034)


README on Docker Hub is dependent upon last version built

Currently 4.1.11 is shown as the latest release in the README contents @ https://hub.docker.com/r/graylog/graylog and https://hub.docker.com/r/graylog/graylog-enterprise/ since it was built after 4.2.6.  This will eventually get sorted out when a 4.3.0 or 4.2.6 lands, but in the meantime a user looking at Docker Hub might get a bit confused.
edit:  Hm, now both show 4.2.5.  Manual correction?  Either way, this isn't a big deal but might be worth keeping in mind w/ the release process.

Yeah, I fixed it. It's just because I ran the 4.1 release after I did the 4.2 release. I guess Docker Hub pulls the README from whatever latest branch gets commits?


Support ANSI Hyperlinks in output

It would be handy if there were support in spectre.console to output ANSI hyperlinks (clickable links) in the terminals that support this feature.
While there are currently only a handful of terminals that currently support this.
Current state of support (per 2020-05-31) can be seen here: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
From my own testing, I have found that GNOME Terminal supports these links, and partially Windows Terminal (mainly only that it won't choke when ANSI hyperlinks are used).

@AdmiringWorm Absolutely. Need to do a little research on my own and think about how this could be implemented, but a great idea!

@AdmiringWorm I've done some thinking and going to add support for this tonight.

@AdmiringWorm This has been merged and will be available in 0.21.0. If you want to play with this feature now, you can always use the preview package 😊

Will do, thank you for adding the support :smile_cat:


[feat]: Embassy-SDK new-service MVP

Prerequisites

[X] I have searched for existing issues that already suggest this feature.

Describe the Feature Request
MVP for the SDK to create a service is to pull hello-world and guide the dev to edit that service directly with their own package info
Describe the Use Case
Begin streamlining dev
Describe Preferred Solution
No response
Describe Alternatives
No response
Anything else?
No response

i think embassy-sdk create or embassy-sdk new would be better

Just a placeholder for clarity.  I like create


Fancyzones loses changes after reboot

Microsoft PowerToys version
0.61.1
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
Apply layout to various monitors.
Reboot computer > layouts need to be reapplied
PowerToysReport_2022-08-17-15-35-26.zip
.
✔ Expected Behavior
Fancyzones settings don't need to be reapplied after each reboot.
❌ Actual Behavior
Need to reapply layout after each computer reboot.
Other Software
No response

I don't think a restart is even necessary. Open the editor once, close it, open the editor, close it, and so on. Test it out. The FancyZones change every time you do this. There are already tickets open for this.

Is this issue still repro?
/needinfo


[Explorer] New Search Approach to Tackle Disambiguation

Switches the search algorithm from relying on guess-work to being under the control of the user. The user types in a term and matching results across different categories are suggested.
Creates a Search Results box to hold this info.
The user can navigate around this search box by pressing the up/down keys or tab key to move across different results matching the term.

Demo:
https://user-images.githubusercontent.com/11377188/186748653-74038654-6f04-4603-8f06-62c4cba78856.mp4

Overall looking good @Andrew47
Could we round the highlighted state corners?
Figma: https://www.figma.com/file/Z5KaPvgurJJ9d4sZQTYBPT/01-UI-Components-%3A-Explorer?node-id=78%3A2396

On mobile i would recommend lowering down the font size a notch or two so the search suggestions fits in a single line vs wrapping into multiple lines.


sish: init at 1.1.5

Motivation for this change
HTTP(S)/WS(S)/TCP Tunnels to localhost
https://github.com/antoniomika/sish
Related to #81418
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119988 run on x86_64-linux 1

1 package built:

sish


OpenShift Infrastructure chart

Added OpenShift Infrastructure perspective to overview. This moves the infrastructure data, from the "All" perspective, to its own chart. This new perspective mimics the supplementary view.
https://issues.redhat.com/browse/COST-1491
New "OpenShift infrastructure" perspective

New "All OpenShift" perspective

Old "All" perspective

Codecov Report

Merging #1983 (88d998a) into master (0dfa968) will decrease coverage by 0.25%.
The diff coverage is 54.05%.

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   71.22%   70.97%   -0.26%
==========================================
  Files         372      378       +6
  Lines        6829     6938     +109
  Branches     1464     1491      +27
==========================================
+ Hits         4864     4924      +60
- Misses       1941     1987      +46
- Partials       24       27       +3

Impacted Files
Coverage Δ

...ponents/charts/dailyTrendChart/dailyTrendChart.tsx
8.33% <0.00%> (-0.30%)
:arrow_down:

.../views/overview/components/dashboardWidgetBase.tsx
38.07% <0.00%> (-0.33%)
:arrow_down:

src/store/dashboard/common/dashboardCommon.ts
100.00% <ø> (ø)

...tore/dashboard/ocpDashboard/ocpDashboardWidgets.ts
100.00% <ø> (ø)

...ntaryDashboard/ocpSupplementaryDashboardWidgets.ts
100.00% <ø> (ø)

...tureDashboard/ocpInfrastructureDashboardActions.ts
32.00% <32.00%> (ø)

...ctureDashboard/ocpInfrastructureDashboardCommon.ts
42.30% <42.30%> (ø)

...reDashboard/ocpInfrastructureDashboardSelectors.ts
50.00% <50.00%> (ø)

src/components/charts/trendChart/trendChart.tsx
81.57% <60.00%> (-0.99%)
:arrow_down:

...tureDashboard/ocpInfrastructureDashboardReducer.ts
83.33% <83.33%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfa968...88d998a. Read the comment docs.


Parse HTML tag in questionnair text

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
#968
Description
Clear and concise code change description.

Parse the html tag in questionnaire text
Add a small 5dp padding between questionnaire prefix text and item text.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Bug fix
Screenshots (if applicable)

Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@jingtang10 I am not sure about how does codecov report error. And it reports the DatabaseImpl.kt file which I haven't touched. Could you give me some instruction on this?

@jingtang10 I am not sure about how does codecov report error. And it reports the DatabaseImpl.kt file which I haven't touched. Could you give me some instruction on this?

I think the coverage report of DatabaseImpl.kt has always been a bit flakey...

@jingtang10
I think the two ways you suggested don't differs much.
I changed those properties to localizedTextSpanned and localizedPrefixSpanned.


Added Notes app in dart

If anything is wrong please tell me. I am a beginner.

Great work @aakashpsindhi

@viralvaghela  in flutter folder its not showing my name on notes app why?


CacheManager.destroy() fails due to DESTROY_IN_PROGRESS

CacheManager.destroy method fails if the reconnect happens during the destroy call after PREPARE_FOR_DESTROY is done leading to refetch of the entity invoking validate call.

https://github.com/ehcache/ehcache3/pull/2540


Kata files need cleanup

Unfortunately, it's kind of just the way they came, but many have shoddy grammar and are somewhat difficult to parse.

Moving to new repo


Investigate if FHIR library can request users to enter screen lock challenge

Describe the issue to be researched
Include any background information and available resources.
This PR introduced sqlcipher to encrypt FHIR resources database. To further secure devices using apps built upon FHIR SDK, we should

[P0] at least require the user to setup a lock screen.
[P1] on request, the user must enter a screen lock challenge before they can access the encryption key.

Describe the goal of the research
What's the desired outcome of this task? What artifacts should be produced?
Enumerate ways to request users to enter screen lock challenge before using our app / database encryption key.
Describe the methodology
Where can more information be found? Who should the assignee approach to ask questions? How can a decision be made?
TBD
Would you like to work on the issue?
Yes

please also see #76 - can you merge these two issues?

Thanks Jing. Didn't know there is already an existing issue. I have closed this and assigned #76 to myself.


fix: fix copy bug and only show menu when logged in

Description
fix ZEN-394

check CI

Think only fails because I changed the env variable.


ArrayIndexOutOfBoundsException when socket.connect(address, connectTimeout)

java.lang.ArrayIndexOutOfBoundsException: length=4; index=1153466837
at java.util.HashMap.put(HashMap.java:407)
at android.content.Context$1.isNetworkDenied(Context.java:3233)
at java.net.Socket.connect(Socket.java:867)
at com.squareup.okhttp.internal.Platform$Android.connectSocket(SourceFile:190)
at com.squareup.okhttp.internal.http.SocketConnector.connectRawSocket(SourceFile:160)
at com.squareup.okhttp.internal.http.SocketConnector.connectCleartext(SourceFile:67)
at com.squareup.okhttp.Connection.connect(SourceFile:152)
at com.squareup.okhttp.Connection.connectAndSetOwner(SourceFile:185)
at com.squareup.okhttp.OkHttpClient$1.connectAndSetOwner(SourceFile:128)
at com.squareup.okhttp.internal.http.HttpEngine.nextConnection(SourceFile:341)
at com.squareup.okhttp.internal.http.HttpEngine.connect(SourceFile:330)
at com.squareup.okhttp.internal.http.HttpEngine.sendRequest(SourceFile:248)
at com.squareup.okhttp.Call.getResponse(SourceFile:273)
at com.squareup.okhttp.Call$ApplicationInterceptorChain.proceed(SourceFile:230)
at com.squareup.okhttp.Call.getResponseWithInterceptorChain(SourceFile:201)
at com.squareup.okhttp.Call.access$100(SourceFile:36)
at com.squareup.okhttp.Call$AsyncCall.execute(SourceFile:164)
at com.squareup.okhttp.internal.NamedRunnable.run(SourceFile:33)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:848)

okhttp version : 2.4.0

FYI @nfuller, this looks like a bug in AOSP. Nothing to do in OkHttp.

@JackCho That stack trace suggests an OEM-specific modification. I can't find any branch where these lines match up with source:
at android.content.Context$1.isNetworkDenied(Context.java:3233)
at java.net.Socket.connect(Socket.java:867)
Can you tell me what device and android release this is?
It would help me be sure I haven't missed somethign and I may be able to get in contact with the OEM to let them know / warn them if I can get the details.

@nfuller this bug happens on  Xiaomi,Meizu devices and on android releases of 4.4.4, 4.1.1, 4.2.1.
After we switch our http client to okhttp, the bug just shows up.
This link is from fabric : http://crashes.to/s/1b42e16d2ea

@JackCho Thanks for the link and details. I will try to pass this on to the OEM. In the meantime I'm guessing that the code is not properly synchronized around a data structure that was added to Context. The only thing I can think of for these existing devices would be to add some synchronization further up the stack. e.g. com.squareup.okhttp.internal.Platform$Android.connectSocket to try to limit the number of OkHttp threads passing through that code.
Here's why I'm pointing fingers. Looking for that Context line number in 4.4.4:
https://android.googlesource.com/platform/frameworks/base/+/android-4.4.4_r1.0.1/core/java/android/content/Context.java
https://android.googlesource.com/platform/frameworks/base/+/android-4.4.4_r2.0.1/core/java/android/content/Context.java
I'm just back from 2-weeks vacation and looking through a mountain of email. I've seen from the summary that SocketConnector has been deleted (https://github.com/square/okhttp/pull/1782), but I don't know the details. I'm currently assuming that wouldn't affect this but I could be wrong.


iot-gate-imx8: Add new device type

Change-type: patch
Signed-off-by: Vicentiu Galanopulo<EMAIL_ADDRESS>

Hi @nghiant2710 this device will need base image as per https://www.flowdock.com/app/rulemotion/resin-devices/threads/4yl7mS1D5eV8Hlg3mRZXLZb-tFR - if doesn't have already.


Fix #533 using a callback

Hey, closing this since I'm not sure how the callback is being passed through. Will certainly use it as a baseline when we actually look at #533. Thanks for raising it!


Behavior Definition

Pull Request #2021

new is_active method added in https://github.com/larshp/abapGit/pull/2017, guess it is also needed as part of this PR

Also please open a PR to https://github.com/abapGit-tests/BDEF with a simple example of the serialized object

closing it for now and recreate later with cleaner version

Coding will be adapted accordingly in a seperate PR. Therefore I close this one.


New version: DaemonMode v0.1.1

Registering package: DaemonMode
Repository: https://github.com/dmolina/DaemonMode.jl
Created by: @dmolina
Version: v0.1.1
Commit: 43ff5a7c4eacf7f50fc1936ae6af822b37c0dd9a
Reviewed by: @dmolina
Reference: https://github.com/dmolina/DaemonMode.jl/issues/11
Release notes:

Add parameter print_stack to server, that allows serve to indicate the complete stack when there is an error.

By default it shares the environment in expr, and not in files. It can be changed as a parameter in server.

Better behaviour when the client close the communication

Fix error with include in the script.

Solving a unexpected error in the test.


[V0.9.x] Transactionless migrations for PostgreSql

There are some actions in PostgreSQL that cannot be run in transactions.
For instance a:
ALTER TYPE image_type ADD VALUE IF NOT EXISTS 'gif'
That will cause the following error when running db-migrate up:
[ERROR] error: ALTER TYPE ... ADD cannot run inside a transaction block
There are other migration libraries that support non-transnational migrations. Now there is a Posgresql migration for node that supports this: node-pg-migrate
As there is no way to set attributes for migrations, I have added to the filename a prefix 'NO-TRANS' to be able to determine if needs to be run within or without transaction.
I have also added some functionality and tests to enable this by adding the argument --transactionless to the db-migrate create.
Currently I am using 0.9 as is the version in npm. If you need me to do the same in master / 0.10 please let me know.
Thank you,
Francisco

Btw, if you decide to merge the request, it should be mentioned in the documentation that this will only support single-line commands to the database. As it is outside a transaction is not safe to have multiple queries, plus, PostgreSQL will not allow multi line queries for those DDL updates.

Hey thanks for your contribution!
I hope I will have some time tomorrow to review your PR.

Hey,
sry that this took so long. Unfortunately this wont be merged. The reason for this is that you added a feature to the 0.9.x track. This is not allowed, you can also read about semver versioning yourself for more of a reason though.
Additionally you duplicated a feature that already exists in the 0.10.x branch and named it differently, this is also something that would not being merged. See https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L622-L623
And lastly it would not have been merged b/c of this:
https://github.com/db-migrate/node-db-migrate/pull/441/files#diff-2db7be3a75a6bd5ced8a2bced19e7a87R19
There are multiple things wrong with this. First of all: When doing code style fixes: Always separate them from features. Second, yes I know yet there are no code styles in the project defined, which is something that needs to be added, but please just don't apply your code styles.
Again, thank you for your contribution, it is very much appreciated, also it is not being merged. If you want to use the latest features like the 'non-transactional' one, you're free to use the latest 0.10.x version, which is quite stable right now anyway though. It is just about some doc and test work that is left though.

Hi thanks for the reply,
No worries, and sorry about the formatting of that file, the IDE autoformated the file and I did not realize that time.
I used this branch and not 0.10.x as 0.9 is the one used in npm.
Good work and I'll take a look to 0.10.x when released. In the mean time I'll keep using my fork for my projects.
Thanks again!


Windows batch for Java. Closes #62.

Bare-bones Windows batch file for the Java example.

@maltzj : How does this look?


Reset the package boilerplate and README

#1  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GoodM4ven and the rest of your teammates on  Graphite


gpt_bigcode: added internal_bucketing support

What does this PR do?

Added internal_bucketing support for starcoder/srcoderbase models (bigcode_gpt architecture)
Test updated

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

Some testing results
Without KV-cache padding
python run_generation.py \
    --model_name_or_path bigcode/starcoderbase-3b \
    --use_hpu_graphs \
    --use_kv_cache \
    --batch_size 42 \
    --max_new_tokens 1024 \
    --do_sample\
    --bf16 \
    --use_flash_attention

Results:
Stats:
--------------------------------------------------------------------------------------------------------------
Throughput (including tokenization) = 4250.208022062189 tokens/second
Number of HPU graphs                = 17
Memory allocated                    = 14.8 GB
Max memory allocated                = 94.33 GB
Total memory available              = 94.62 GB
Graph compilation duration          = 82.15613932400447 seconds
--------------------------------------------------------------------------------------------------------------

With KV-cache padding
python run_generation.py \
    --model_name_or_path bigcode/starcoderbase-3b \
    --use_hpu_graphs \
    --use_kv_cache \
    --batch_size 42 \
    --max_new_tokens 1024 \
    --do_sample\
    --bf16 \
    --use_flash_attention \
    --bucket_internal \
    --bucket_size 128

result
Stats:
-------------------------------------------------------------------------------------------------------------
Throughput (including tokenization) = 5327.50960677104 tokens/second
Number of HPU graphs                = 17
Memory allocated                    = 8.32 GB
Max memory allocated                = 93.91 GB
Total memory available              = 94.62 GB
Graph compilation duration          = 29.821909683996637 seconds
-------------------------------------------------------------------------------------------------------------

@mgonchar can you re-base your code to the main

@yafshar rebased
updated results after rebase:
no KV-cache padding
python run_generation.py \
    --model_name_or_path bigcode/starcoderbase-3b \
    --use_hpu_graphs \
    --use_kv_cache \
    --batch_size 42 \
    --max_new_tokens 1024 \
    --do_sample\
    --bf16 \
    --use_flash_attention

Stats:
--------------------------------------------------------------------------------------------------------------
Throughput (including tokenization) = 4520.776452353651 tokens/second
Number of HPU graphs                = 17
Memory allocated                    = 14.8 GB
Max memory allocated                = 94.33 GB
Total memory available              = 94.62 GB
Graph compilation duration          = 86.4366191369918 seconds
--------------------------------------------------------------------------------------------------------------
```

with KV-cache padding

```
python run_generation.py \
    --model_name_or_path bigcode/starcoderbase-3b \
    --use_hpu_graphs \
    --use_kv_cache \
    --batch_size 42 \
    --max_new_tokens 1024 \
    --do_sample\
    --bf16 \
    --use_flash_attention \
    --bucket_internal \
    --bucket_size 128

Stats:
--------------------------------------------------------------------------------------------------------------
Throughput (including tokenization) = 5753.247987598512 tokens/second
Number of HPU graphs                = 17
Memory allocated                    = 8.32 GB
Max memory allocated                = 93.91 GB
Total memory available              = 94.62 GB
Graph compilation duration          = 28.145060317998286 seconds
--------------------------------------------------------------------------------------------------------------
```

@imangohari1 can you provide the CI test that has to be done for this PR?

@imangohari1 can you provide the CI test that has to be done for this PR?

Please run the transformer and fast tests to begin with. Capture the outputs and share them (internally).
make test_installs
GAUDI2_CI=1 RUN_SLOW=1 python -m pytest tests/transformers/tests/models/ -s -v
GAUDI2_CI=1 RUN_SLOW=1  python -m pytest tests/test_gaudi_configuration.py tests/test_trainer_distributed.py tests/test_trainer.py tests/test_trainer_seq2seq.py -s -v

@regisss @yafshar @imangohari1 can you please have a look?

@mgonchar thanks for the update. I will update here shortly

@mgonchar would you please rebase this PR. Please ping me as soon as done. I am actively working to wrap up this PR

@jiminha regarding your request

can you also provide accuracy result before/after this fix?

Which script do you want me to run? I checked generation myself and they are close and still meaningful, but I can run some scripts if you know such.

can you also run one of training case with starcoder and make sure it doesn't break anything.

Can you point to some particular script or test?

@jiminha regarding your request

can you also provide accuracy result before/after this fix?

Which script do you want me to run? I checked generation myself and they are close and still meaningful, but I can run some scripts if you know such.

If you have tested and checked the string generated is right, that should be good enough.

can you also run one of training case with starcoder and make sure it doesn't break anything.

Can you point to some particular script or test?

I see one example here : https://habanalabs.sharepoint.com/:x:/r/sites/ApplicationEngineering/Shared Documents/Customers Internal/Huggingface/OH_reviwer_1_18.xlsx?d=w5ca22148d71a4772a38f5ca25f49c070&csf=1&web=1&e=AtiF6b

@jiminha I looked into training scripts and I don't see any logic for KV-cache management (past_key_values in OH terms) inside GaudiTrainer, also currently bucket_internal is a feature implemented on level of generate interface, which is inference-only (here)

@jiminha I looked into training scripts and I don't see any logic for KV-cache management (past_key_values in OH terms) inside GaudiTrainer, also currently bucket_internal is a feature implemented on level of generate interface, which is inference-only (see here)

Thanks for confirming.  Just wanted to make sure no breakage on the existing test-cases.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jiminha I rebased and retested my change. ruff doesn't show any issues with formatting locally, hope it will pass CI now

@mgonchar There is a merge conflict to solve it seems

@regisss  rebased and retested, also checked style


[LW-19] Some fixes regarding pure logging

Initial purpose of this issue was to remove some boilerplate, but now I realize that I don't see a nice way to do that. After some discussion with @ChShersh we decided that it would be better to remain things as they are.
As result of this issue I removed redundant constraint in dispatchEvents, that's it :/

Okay, it's ready to be merged

Previously you said it's optional
https://serokell.slack.com/archives/log-warper/p1489572191719322
But okay, I will

Well, I expected it to be more complicated than a simple git revert. I think it doesn't make sense to use git revert in feature branch (assuming you are the only one who is working there), because you can simply remove that commit and force push as long as there are no merge commits in between.

I didn't want comments here to vanish )  But it's not worth it I guess

AFAIK, comments don't vanish. I don't fully understand how all this pull requests machinery works though.

Really, still here they are


Propagating back changes made in devtools to the code editor

Hey, maybe this is the wrong place for this kind of functionality. I wonder if it's possible to use amok to "hot reload" code in my editor that were made in the devtools.
I found this tool that allows that for css http://livestyle.io/
I guess if there is such a ting it would need to respect source maps, but this would be actually a pretty neat feature :-)

Adding the source folder to the workspace should allow bi-directional updates. Chrome Developer Tools will reload files as they change from the disk. And your editor may reload files as chrome persists them to disk (depends on the editor, you may just be prompted to reload).
Amok might have to deal with source map urls, which it does not currently. I'll look into that but for vanilla scripts it works.


Added missing setter to plugin name to directly use the SetupTriggerConfig

The SetupTriggerConfig cannot be used directly because the PluginName has no setter. Also inherit the class brings no possibility to override the property with a setter, therefore all SetupTriggers need an explicit config implementation which leads to a lot of boilerplate. Other plugins like the ProductAssignment or RecipeAssignment are providing this.

I totally agree, but this would be breaking. Every config overriding the plugin name, would have a compiler error for missing setter.

I totally agree, but this would be breaking. Every config overriding the plugin name, would have a compiler error for missing setter.

You are right, this was my fault! It doesn't make me happy, but I think the only way to integrate this is moving it to the next major. So I changed the target branch and added a redirected property to my base class
    public override string PluginName => OverridePluginName;

    //ToDo: Removed when solved in MORYX-Factory
    [DataMember, PluginNameSelector(typeof(ISetupTrigger))]
    public string OverridePluginName { get; set; }


Add Workflow.newWorkflowQueue method and ZWorkflowQueue wrapper

Changes being made
Add ZWorkflow.newWorkflowQueue method and ZWorkflowQueue wrapper for WorkflowQueue
Additional context
/addresses #88

@grouzen, if there is any Javadoc for the Java Queue, could you copy it into our wrapper as well?
Otherwise LGTM! The only thing nice to have is usage examples. I haven't found them yet in Java SDK samples 🤔

@grouzen, if there is any Javadoc for the Java Queue, could you copy it into our wrapper as well? Otherwise LGTM! The only thing nice to have is usage examples. I haven't found them yet in Java SDK samples 🤔

Sure, I'll copy the docs for the methods.
That was my main struggle - no examples and docs about WorkflowQueue. I've managed to find some info on the community forum. I'll add maybe some test cases along with examples.

Codecov Report

Merging #127 (c3c7f4b) into main (669309f) will decrease coverage by 1.38%.
Report is 3 commits behind head on main.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   38.56%   37.19%   -1.38%
==========================================
  Files         115      127      +12
  Lines        4055     4850     +795
==========================================
+ Hits         1564     1804     +240
- Misses       2491     3046     +555

Files
Coverage Δ

...c/main/scala/zio/temporal/workflow/ZWorkflow.scala
39.26% <100.00%> (-3.24%)
:arrow_down:

...n/scala/zio/temporal/workflow/ZWorkflowQueue.scala
0.00% <0.00%> (ø)

... and 39 files with indirect coverage changes

@grouzen I'm going to merge it into the new release. Feel free to add tests and examples in a new PR!


Support wifi heartbeats originating from indoor wifi hotspots

Provides support for the ingestion, processing & rewarding of wifi heartbeats
Linked proto pr: https://github.com/helium/proto/pull/365

Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs, and the wifi contents into wifi.rs module

to clarify, heartbeats broken up into 3 modules.  cbrs_heartbeats, wifi_heartbeats and then a shared module heartbeats_util.  I do like the approach of adding a heartbeats directory which then containts cbrs_heartbeats, wifi_heartbeats and then a mod.util and will change to that

Renaming heartbeats to heartbeats_util and wifi_heartbeats seems like a pretty drastic and non-idiomatic change. If you'd like to split that file up, I recommend creating a heartbeats directory, putting the "util" contents into the mod.rs, and the wifi contents into wifi.rs module

to clarify, heartbeats was broken up into 3 modules. cbrs_heartbeats, wifi_heartbeats and then a shared module heartbeats_util. I do like the approach of adding a heartbeats directory which then containts cbrs, wifi and then a mod.util and will change to that

Personally I would just name them cbrs.rs and wifi.rs, it's implied they're related to heartbeats by being in the heartbeats directory


Set a ProjectAnalyzer when solving for dep status

Fixes #384 which was introduced when we bumped gps to v0.16.
Adds integration test for dep status
Fixes problem with test harness where the test would pass when one of the commands fails. Which found some other tests that were actually failing, so I fixed those too. This is in this PR because without it, the "failing" test I added for status incorrectly passes. 😄

Let me know if this needs to be split into 2 PRs.

iz good, thank you - yeah, i only noticed the missing analyzer last night, too. (indicative of how much we've neglected dep status in our testing, and general development, thus far)


input lcd status issue

It appears that an input which is on when a reset is generated  does not get displayed on the lcd  when the boot process has completed .The input must change state for the lcd to sync to the input status.

Moved to https://github.com/OXRS-IO/OXRS-IO-LCD-ESP32-LIB/issues/32


Investigate LiteralPath for - File name with Wildcards in Open-ExcelP…

…ackage #1209

Not going to merge. This "breaks" Import-Excel da*.xlsx. Most likely all functions using Test-Path, those functions would need to handle both Path and LiteralPath to get it right.


Add gosimple?

Would gosimple be a candidate for inclusion in gometalinter? It's a golint derivative that focuses on code simplifications instead of a style guide. The README contains an exhaustive list of checks it performs.

@dominikh I already tried it last night and it found a couple of issues in my code already so Thanks!
I was going to try to work on a PR for gometalinter with it, I suspect that would be the fastest way for it to get integrated?
If you would do it that would be great (since it's your tool), but if you don't have the time I'll give it a try.

I can absolutely write the PR, but I wanted to get approval before sending a PR, so it wouldn't look too pushy.

Oops: 91a0b0721f2fb518b84b02b0958d5a2044c2dbc9 – I guess my tool already made the rounds :)

👍


Review the code for exceptions

https://julien.danjou.info/python-exceptions-guide/

According to that guide, dowml should systematically catch any exception coming from a library it uses and turn them into its own exceptions using
    raise MyOwnException(...) from ex

Should we systematically catch any exception coming from ibm-watson-machine-learning and re-raise our own without even thinking about it? Considering that dowml would have nothing to add to the original exception, and given how much work this entails, I really don't think there is any benefit in this.  This may change in the future, of course...
The example of Tooz is interesting... Indeed, when implementing some code that uses different libraries to do similar work depending on some conditions, it makes perfect sense that the user's code should not have to care about what exactly these conditions were, and what library was used underneath.


transform_xy method on the Geom trait

Applies an XY coordinate transform callback to all coordinates in a copy of input geometry
Wraps the GEOSGeom_transformXY_r function
The trampoline functions for storing a rust closure and passing that as the userdata to the c function is inspired by:
https://adventures.michaelfbryan.com/posts/rust-closures-in-ffi/

CI fails thanks to geo-types, yeay.
I'm really starting to get very annoyed when crates make minor releases while changing minimum supported rust version...
Sorry for the rant and thanks a lot for your PR!


V2 manifest save tarsum

Stores checksum in a separate file to avoid modifying the existing json file.  Storing this file allows for subsequent calls to create the manifest to use the cached value, avoiding unnecessary checksum calculations.  The checksum should not need to be recalculated if it was calculated on commit.
Depends on #10322

If this is correct, than I believe this can wait for 1.5.1.

@vbatts given the manifest json is already being altered, would you still oppose overwriting the layer json file for this change?  This is what my original commit did and given compatibility with tools relying on it for detached signature is already broken, seems pointless to introduce another file.

Updated to include fix for #10432. This will now ignore the value in the img.Checksum since it may differ from the checksum produced by the diffdriver for the registry.
@vbatts ignore my previous comment, separating out the checksum into a different file is necessary to fix an issue with computing the tarsum on import/pull/load before it is ever extracted.

much better ;)

What about deleting the Checksum field on the image now that it's not used?

The Checksum field is not new to this release.  If we want to get rid of it I would prefer it in a separate change to keep this one focused on push tarsum.

LGTM

@icecrime updated error message

@crosbymichael added a commit from @jlhawn to remove the now unused Checksum field.  He was able to confirm it is not needed anywhere else.

Thanks!
LGTM

@dmcgowan are there any issues that this fixes around performance or something?

Retroactively fixes problems created by #10432 and fixes #10269
The #10269 issue is currently in 1.5.1 but I think it would be good to fix for 1.5.0 since it will now effect images built by 1.5.0.

@dmcgowan please add the Fixes #xxxxx to your pr descriptions so they are alto closed on merge

@crosbymichael done

ping @tiborvass @jfrazelle

LGTM

LGTM!
Handing off to @tiborvass to let him finish his own tests and merge when appropriate.

LGTM


Use chromium instead of google-chrome

Swap out google chrome for chromium.
This seems to solve our current crashes that we are experiencing.
We've had publishing e2e test failures since the evening of Friday 7th.
Our tests seemed to be failing with
Selenium::WebDriver::Error::UnknownError:
             unknown error: Chrome failed to start: exited abnormally
             (unknown error: DevToolsActivePort file doesn't exist)
             (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

We don't have a good explanation for why this happened, but we have been bitten by chrome and chromedriver being out of sync in the past. At any rate, replacing chrome with chromium seems to solve the issue for now.
Trello

@barrucadu agreed - this is, to my mind, a stop gap to at least have the e2e tests working again. I've put a bunch of notes on the trello card as follows:

write up another card to upgrade the e2e tests to use webdrivers instead of chromedriver-helper. There were a whole heap of errors and deprecation warnings when I tried, but we should get this done.

Potentially another card to investigate further using gecko instead.....

And another card to create a base image that we know works. If push comes to shove and we have a breakage in the future, we can fall back to a known working image until we can fix what's broken. That way we might be able to avoid

I'm not against pinning our versions - I do think it needs a bit of thought though since it means we need to set up some process to occasionally update them.


Merge pull request #1 from 24io/main

Merge pull request #10 from AnnaValentinaHirsch/main

This pull request needs a better name, maybe something like "fix type hints to match older python version". Maybe even state the version that we require for google colab/code spaces/etc.


add trackpad pinch

[x ] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
I'm always frustrated when I try to "pinch" on my trackpad, and it does nothing on the android screen.
Describe the solution you'd like
I want to be able to pinch on the macbook trackpad, and it respect that on the device.
Describe alternatives you've considered
ctrl+mouse works, but requires using the keyboard...

Probably requires to use SDL_MultiGestureEvent.
I never used pinch-to-zoom on my touchpad, and apparently it does nothing special on my laptop, so I could not test.


[Doc] Update CHANGELOG

In this PR, the CHANGELOG is updated.

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

@L-jasmine Could you please help review this PR? Thanks a lot!

@L-jasmine Thanks for the review!


Ssl error on www.

Fixed it! This just needed to be set up as Github recommends - point a cname to veryhappythings.github.io and they do the rest. I wasn't sure if this would work as the domain name is different to my user account, but it worked fine.


What structure matcher algorithm is used for the challenge set?

Hi, thank you for this amazing work!
Just curious, what structure matcher algorithm is used for the challenge set?

Hi,
Thank you for asking this question. For the challenge set, we use the Pymatgen StructureMatcher class to establish if two structures are a match. We use a fractional length tolerance of 0.2, a site tolerance of 0.3 Angstroms, and an angle tolerance of 5 degrees, which are the default values in Pymatgen. Both structures are reduced to primitive cells before matching, and are scaled to equivalent volume.
Regards,
Luis


Support qemu-user emulation for real i586, i686, and x86_64 CPUs

I'd like to be able to, optionally,

test x86 on qemu-user,
specify a particular cpu.

Currently, just because cross is able to cross-compile for i586 and i686 but the tests are run on a x86_64 CPU. That is, if the software targeting i586 uses an instruction that is not available in that architecture, but is available on x86_64, it can pass the tests, but fail in the real world.

Sounds good to me, let me know if you need help implementing!

This is now possible since we allow the CROSS_TARGET_${TARGET}_RUNNER environment variable, the target.(...).runner TOML config option, and also ensure the any Cargo-specific environment variables are passed to the container. This is documented now on the wiki.
For example, the following will run all binaries for aarch64-unknown-linux-gnu on the Cortex-A72:
$ export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_RUNNER="qemu-aarch64 -cpu cortex-a72"
$ cross run --target aarch64-unknown-linux-gnu


Update manage-license-requests.md

Updated latest content date to 6/7/2021

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@cmcatee-MSFT Please merge this PR. Thanks


Get-DbaRunningJob - add StartDate property

Purpose
The way Get-DbaRunningJob is called does not provide an easy method for running a query, without adding in making a connection and all that stuff. Made more sense to simply add a parameter and query execution to Get-DbaAgentJob itself.
The parameter -IncludeExecution is used by Get-DbaRunningJob to include the StartDate property in the output. Adding it via the parameter ensures it not a breaking change.
Screenshots

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[x] New feature (non-breaking change, adds functionality, fixes #1917 )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

Learning

Those failing yet unrelated tests are ridiculous and unrelenting. I've reran that job like 8 times, wth.

Oh! Four files did change. OKay, that makes more sense. The changes are causing test failures.

Forgot copy/paste of the default properties ended up changing. Do you enabled property alias is required by the copy command.
Which really that copy command should be using a native property and not depend on an alias set in another command :shrug:.

Looks good to me! Nice approach.


mesh cli, setup does not install all dependencies

Summary
problem: when using CLI, the setup doesnt install every packages.
Module not found: Can't resolve '@harmoniclabs/pair'
  24 | var bigint_utils_1 = require("@harmoniclabs/bigint-utils");
  25 | var plutus_data_1 = require("@harmoniclabs/plutus-data");
> 26 | var pair_1 = require("@harmoniclabs/pair");
     | ^
  27 | var UPLCTermTag_1 = require("../UPLCTerm/UPLCTermTag.js");
  28 | var Constr_1 = require("../UPLCTerms/Constr.js");
  29 | var Case_1 = require("../UPLCTerms/Case.js");

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./src/pages/_app.tsx

the template is working fine, as manually clone this repo, npm install and npm run dev will work.
Steps to reproduce the bug

from terminal, do npx meshjs test-app, choose nextjs
then start npm run dev

you will see error about hlab/pair not found, and indeed from node_modules the package was not installed

then do npm install
then start npm run dev again

you will see the everything running fine.
Actual Result
error hlab/pair is not found, after doing npx meshjs test-app
Expected Result
from terminal, do npx meshjs test-app should set everything up ready for development.
CLI script can be found here scripts/mesh-cli/src/index.ts

I can reproduce this with yarn package manager.  A quick fix is maybe enforcing npm as default?

Just FYI @jinglescode @HinsonSIDAN , yarn doesn’t install peer dependencies. But you can try to reinstall hlab packages with install-peerdeps tool

Just FYI @jinglescode @HinsonSIDAN , yarn doesn’t install peer dependencies. But you can try to reinstall hlab packages with install-peerdeps tool

currently, have hardcoded to use npm
do you think can improve this script to support yarn?


[Task]: Reclicking on modal icon when modal opened, makes it disappear

Task description
Modals use a custom action so they close when you click outside them. However if you click on the same icon that opened the modal, the modal automatically reopens. Example: network status or profile at the bottom.
Requirements
TBD
Acceptance criteria
Clicking on an icon that opens a modal, let's the modal disappear when the modal is already opened and the user clicks on the icon again.
Creation checklist

[ ] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Closing as this was fixed in #2809


Not generating unions with multiple media types

There seems to be an issue generating union types when multiple media types exist that alter the requirements for the request body.
Example path with multiple media types (right from the swagger requestBody docs):
Given the following schema:
paths:
  /pets:
    post:
      summary: Add a new pet
      requestBody:
        content:
          "application/json":
            schema:
              $ref: '#/components/schemas/Cat'
          "application/foo.bar+json":
            schema:
              $ref: '#/components/schemas/Dog'

Only one output method will be generated, it seems to either be application/json or index 0, I'm not entirely sure.
Is there any way I can get this to generate a union type rather than always generating from schemas/Cat? It seems like the swagger specification should allow for multiple media types for a single endpoint.

The requestBody is more flexible in that it lets you consume different media types, such as JSON, XML, form data, plain text, and others, and use different schemas for different media types. requestBody consists of the content object, an optional Markdown-formatted description, and an optional required flag (false by default). content lists the media types consumed by the operation (such as application/json) and specifies the schema for each media type

Also experiencing this issue, but when different response types are specified.


Feeds

Hello,
There is a menu option "Show Feed Entries" leading to a page that is supposed to list feed subscription. Sadly I didn't fing any option to subscribe to a feed.

EDIT: well, my bad, there is a subscribe option, but I can't make it work.
To do that, I go to a atom feed, for instance gemini://hashtagueule.fr/atom.xml, I ignore the warning that Lagrange cannot open XML content, and then I click on subscribe in the menu. But when I go to the subscription side bar and click refresh, nothing happens.

Sorry, Lagrange only supports Gemini style feeds at the moment. From the Help:

Lagrange does not support RSS or Atom, only Gemini feeds. A Gemini feed is simply a regular 'text/gemini' page that contains one or more links whose labels are formatted in a particular way.

Also, note that bookmarks and subscriptions are closely tied, so any bookmark can be turned into a subscription via the context menu in the Bookmarks list.
The latest version also supports subscribing to new headings that appear on a Gemini page.
There is an issue about support for Atom feeds. I suggest further discussion about RSS/Atom should continue there.

Oh ok, sorry, I didn't know about that. This is interresting.


[enhancement] Update devDependency nyc from v13.3.0 to v14.1.1

PR checklist

[x] New feature, bugfix, or enhancement

Overview of change:
There is a vulnerability in handlebars for v13 of nyc, update to the latest version to avoid it.
Is there anything you'd like reviewers to focus on?
New coverage summary:
Statements   : 46.31% ( 5007/10812 )
Branches     : 39.94% ( 2664/6670 )
Functions    : 45.46% ( 881/1938 )
Lines        : 46.22% ( 4445/9617 )

Current coverage summary:
Statements   : 37.08% ( 4245/11449 )
Branches     : 24.12% ( 1646/6823 )
Functions    : 33.96% ( 868/2556 )
Lines        : 36.78% ( 3756/10212 )

CHANGELOG.md entry:
[enhancement] Update devDependency nyc from v13.3.0 to v14.1.1

Raised an issue over at nyc -- https://github.com/istanbuljs/nyc/issues/1111

The istanbul team was very helpful and now we have improved coverage, this is ready to go.

Try merging master now that #4731 is in to fix the testNext build

Try merging master now that #4731 is in to fix the testNext build

The test is passing now.


chore: replace nose with pytest

too bad the CI is still not happy but it's probably not related directly to this PR

I am aware of this but I want to keep PR on a single subject, to make it easier to track. It will take few more PRs until we can make it green.


add function getSn for ble protocol

Change-Id: I10ce369ce380b8e3188c54ac642c294c660231e7

Add the function getSn for BLE protocol.
#591
Checklist

[x] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added

Is getSn a standard function?

Is getSn a standard function?

Yes, it's designed in the BLE protocol, but not implemented.


ASN.1 decoder/encoder

Hi,
It would be very useful to have Abstract Syntax Notation 1 decoder/encoder library/module.
None exists.
This would help to write a lot of low level stuff (SNMP stack ?, MIB parser).

There is no reason that this should be a part of the standard library.

https://github.com/alex/rust-asn1

Closing in favor of https://github.com/alex/rust-asn1.


Appstudio update test-component-pac-ceen

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-ceen-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
21 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
34 seconds
sanity-inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
35 seconds
sbom-json-check

✅ Succeeded
20 seconds
sanity-optional-label-check

✅ Succeeded
18 seconds
sanity-label-check

✅ Succeeded
14 seconds
show-summary

Pipelines as Code CI/test-component-pac-ceen-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
21 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
34 seconds
sanity-inspect-image

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
35 seconds
sbom-json-check

✅ Succeeded
18 seconds
sanity-label-check

✅ Succeeded
20 seconds
sanity-optional-label-check

✅ Succeeded
14 seconds
show-summary

Pipelines as Code CI/test-component-pac-ceen-on-pull-request has successfully validated your commit.


Provide folder structure/workflow for Angular wrappers of UI plugins

I can't find anywhere how should the plugin be structured and what should be the workflow when the plugin as an android code - for example the GridView or DropDown plugins.

You could find more information on how to build angular wrappers here.
However, it would be a good improvement to include the steps in the plugin seed itself.

@elena-p , yes, I'm well aware of how wrappers should be built 😉  I'm more talking about to have in the seed a predefined structure where those wrappers should be put. Also I think best would be to have the postclone script automate this: so ask the user if their plugin will have angular wrappers, if Yes then:

Add a dummy wrapper in the predefined folder
Add angular compiler dependencies with their correct versions to the package.json file
Add angular compiler scripts to packages.json and include them in the build script
Automatically add the angular demo w/o prompting the user

Also it would be good if we can return and execute this part in the later stages so in case I start a plugin w/o angular wrappers I can later return and run some scripts that performs the above mentioned steps.

I'd also like to add that the docs (https://docs.nativescript.org/angular/plugins/angular-plugin) do not mention the angular compiler at all, which results in many plugins not being compatible with AOT, for example: https://github.com/Akylas/nativescript-material-components/pull/36
I've added a similar issue a while back: https://github.com/NativeScript/nativescript-plugin-seed/issues/126


missing dist folder

While evaluating this tool for integration, we found that you're missing the /dist folder as of 2.1.2. This makes your react solution unusable. Are you no longer supporting react?

Hi @TanyaStere42, thanks for this report. We do still support React. We're investigating this as a matter of urgency and will post a resolution soon.

Hi @TanyaStere42 please will you check version 2.1.6 and let me know if its working for you? Thanks.

Think we're good now 👍

Awesome, thanks for letting us know.


#37: 3rd-party vulnerabilities fixes

@rultor merge

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)


[ADN] For some videos : "No Videos Format Found"

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.07.15. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2017.07.15

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Description of your issue, suggested solution and other information
So, as I say in the title of this issue, some videos have an error when we try to get them.
Some other series than the one in he screenshot have the same problem.
Is it possible to solve this "bug" ?
Thank you!

Do not post screenshots of verbose logs; only plain text is acceptable.

I change the screen and put plain text, is it possible to re open it ?


Setting vectors to values of wrong sizes permitted in cmdstan generated quantities block

Summary:
In the generated quantities block of cmdstan (using cmdstanr) I am able to set vectors of one size to vectors of another size without apparent complaint from the sampler.
Description:
If I declare a vector in generated quantities of one size, I am able to set it to the value of another vector of a different size
Reproducible Steps:
library(cmdstanr)

model_code <- "functions {

  vector make_vector(int n) {
    vector[n] out;
    for(i in 1:n) {
      out[i] = i;
    }
    return(out);
  }

}

data {
  int shorter_n;
  int longer_n;
}

generated quantities {
  vector[shorter_n] test_set_vec;

  test_set_vec = make_vector(longer_n);

}"

dat <- list(longer_n = 10, shorter_n = 5)

cmdstan_file <- write_stan_file(model_code)

cmdstan_version <- cmdstan_model(cmdstan_file)

output_dir <- file.path(tempdir(), "cmstan_test")

dir.create(output_dir)

cmdstan_version$sample(dat, fixed_param = T, output_dir = output_dir)

cmdstan_fit <- read_cmdstan_csv(list.files(output_dir, full.names = T))

head(cmdstan_fit)

Current Output:
The current output looks like this:
> head(posterior::as_draws_matrix(cmdstan_fit$post_warmup_draws))
# A draws_matrix: 6 draws, and 5 variables
    variable
draw test_set_vec[1] test_set_vec[2] test_set_vec[3] test_set_vec[4] test_set_vec[5]
   1               1               2               3               4               5
   2               1               2               3               4               5
   3               1               2               3               4               5
   4               1               2               3               4               5
   5               1               2               3               4               5
   6               1               2               3               4               5

Expected Output:
Expect the sampler to fail with a dimension mismatch error
Additional Information:
This seems to work correctly on with
> rstan::stan_version()
[1] "2.19.1"

Current Version:
> cmdstanr::cmdstan_version()
[1] "2.24.1"
> sessionInfo()
R version 4.0.2 (2020-06-22)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.5 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/openblas/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/libopenblasp-r0.2.20.so

locale:
 [1] LC_CTYPE=C.UTF-8       LC_NUMERIC=C           LC_TIME=C.UTF-8        LC_COLLATE=C.UTF-8
 [5] LC_MONETARY=C.UTF-8    LC_MESSAGES=C.UTF-8    LC_PAPER=C.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C           LC_TELEPHONE=C         LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices datasets  utils     methods   base

other attached packages:
[1] rstan_2.19.3       ggplot2_3.2.1      StanHeaders_2.19.2 cmdstanr_0.1.3

loaded via a namespace (and not attached):
 [1] pkgload_1.0.2         dse_2020.2-1          jsonlite_1.6          setRNG_2013.9-1       assertthat_0.2.0
 [6] posterior_0.1.2       stats4_4.0.2          renv_0.9.3            remotes_2.1.1         sessioninfo_1.1.1
[11] pillar_1.4.3          backports_1.1.3       glue_1.3.0            digest_0.6.18         checkmate_1.9.1
[16] GPArotation_2014.11-1 colorspace_1.3-2      pkgconfig_2.0.2       devtools_2.2.2        tframe_2015.12-1.1
[21] recast_2.0.0          logger_0.1            purrr_0.3.3           scales_1.0.0          processx_3.4.2
[26] tibble_3.0.3          usethis_1.6.1         ellipsis_0.3.0        withr_2.1.2           EvalEst_2015.4-2
[31] lazyeval_0.2.1        tfplot_2015.12-1      cli_2.0.1             magrittr_1.5          crayon_1.3.4
[36] memoise_1.1.0         ps_1.3.0              fs_1.3.1              fansi_0.4.0           pkgbuild_1.0.3
[41] tools_4.0.2           loo_2.1.0             prettyunits_1.0.2     lifecycle_0.2.0       matrixStats_0.54.0
[46] tsfa_2014.10-1        munsell_0.5.0         callr_3.4.2           compiler_4.0.2        rlang_0.4.7
[51] grid_4.0.2            rstudioapi_0.10       testthat_2.3.2        gtable_0.2.0          inline_0.3.15
[56] abind_1.4-5           R6_2.4.1              gridExtra_2.3         dplyr_0.8.3           rprojroot_1.3-2
[61] desc_1.2.0            parallel_4.0.2        Rcpp_1.0.3            vctrs_0.3.2           tidyselect_0.2.5

Seems like @adamhaber opened this issue so i will close this one!


Custom connector handing changed in April update?

I have written two custom connectors, which are deployed in my C:\Users\chris\Documents\Microsoft Power BI Desktop\Custom Connectors directory.  They are .mez files.
In previous versions of the desktop, these connectors would show up under Online Services (the category I chose) when I used the Get Data command.  They no longer appear, even though Custom Data Connectors remains selected in Options..Preview Features.
Any idea what changed?  This is critical, as I have a product and users relying on this functionality.

Hi Chris,
Could you try going into your Documents folder and either moving everything in "Microsoft Power BI Desktop" to "Power BI Desktop" (if the folder already exists), or just renaming "Microsoft Power BI Desktop" to "Power BI Desktop" if the folder doesn't exist?

There was also a change made such that if the .mez file contains multiple .m or .pq files, it will not load. (Files ending in .query.pq do not count for this purpose.)

@CurtHagenlocher that is unfortunate.  In VS2017 you get Intellisense if the file extension is .m or .pq, but you lose it if the file extension is .pqm as in the TripPin sample (https://github.com/Microsoft/DataConnectors/tree/master/samples/TripPin/7-AdvancedSchema).
It's much better from a code-writing/debugging perspective to use/edit .m files.  If you follow the sample guidance and modularize your connector ala TripPin, you're in for some ugly code wrangling with .pqm files.
@cpopell I'll have to let you know about the directory name change but first I have some refactoring to do on my connectors because they no longer work and my customers who are relying on them are about to start asking me why.

@cpopell My connectors are visible again after refactoring and renaming the directory.
I know connectors are technically in preview, but is there some way you can announce these breaking changes before they are deployed to production? A post on GitHub would be fine.
Also, it looks like connectors in the cloud service are unaffected.  I'm really thankful for that, since virtually all of my customers are running there.

Is there a recommended way for installers to support both pre-April and post-April releases? Or just copy the custom connectors to both folders?

FWIW, all the connectors that I've created are working without any issues on all available versions of the Power BI Desktop that support Custom Connectors.

We will be adding the ability to configure the custom connector directory in PBI Desktop, similar to what we now support in the Personal Gateway. However, going forward the recommended default directory will be:
[Documents]\Power BI Desktop\Custom Connectors


version increment

Please increment version. Thanks!

Hi!
Bower install is wrong... :(
Please increment version in bower.json.
#bower install --save cookieconsent2
bower cookieconsent2#*      not-cached git://github.com/silktide/cookieconsent2.git#*
bower cookieconsent2#*         resolve git://github.com/silktide/cookieconsent2.git#*
bower cookieconsent2#*        download https://github.com/silktide/cookieconsent2/archive/1.0.10.tar.gz
bower cookieconsent2#*         extract archive.tar.gz
bower cookieconsent2#*        mismatch Version declared in the json (1.0.9) is different than the resolved one (1.0.10)
bower cookieconsent2#*        resolved git://github.com/silktide/cookieconsent2.git#1.0.10
bower cookieconsent2#~1.0.10   install cookieconsent2#1.0.10

Error: mismatch Version declared in the json (1.0.9) is different than the resolved one (1.0.10)
Unfortunately this file: /cookieconsent.js not contain new location..
/cookieconsent.js contain: var THEME_BUCKET_PATH = '//s3.amazonaws.com/cc.silktide.com/';
/build/cookieconsent.min.js is OK but /cookieconsent.js is not!
Thanks!


unable to add Notifier in preset Alerts

Hi guys
I'm unable to set a Notifier in the preset Alerts.
I added a Notifier, I can create a new alert and add this Notifier there, and it works.
I want to add my Notifier to the preset Alerts - no way to do it.

Useful
Info

Versions
Rancher v2.4.5 UI: v2.4.28

Route
undefined

ALso, when I'm cloning preset Alert, it's also impossible to define a Notifier

Ok, I got it.   Notifiers are set for Alert GROUP, not for rules.   Case dismissed.


Fixed typographical error, changed appeareance to appearance in README.

@cemolcay, I've corrected a typographical error in the documentation of the MaterialCardView project. You should be able to merge this pull request automatically. However, if this was intentional or if you enjoy living in linguistic squalor, please let me know and create an issue on my home repository.

thanks :+1:


Postman Callback Url has been changed

Hi,
Postman has changed callback url. Please update documentation. New link is => https://www.getpostman.com/oauth2/callback

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ebb27a5-41cc-b64f-de68-2f0df6b02f8d
Version Independent ID: 31de5338-ace5-b8c4-88e8-54863428fc61
Content: Authentication in web APIs with Azure Active Directory B2C in ASP.NET Core
Content Source: aspnetcore/security/authentication/azure-ad-b2c-webapi.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @CamSoper
Microsoft Alias: casoper

Sooooo is this need an update or not?

Moved to #16186


How to set c++ version for cotire generation of PCH?

the cppformat formatting library uses clang's __has_feature to determine what functionality to expose:
https://github.com/fmtlib/fmt/search?utf8=✓&q=FMT_HAS_FEATURE&type=Code
http://clang.llvm.org/docs/LanguageExtensions.html
This causes me to end up with undefined references when linking:
How do you set/check compiler flags used while generating the PCH?
I have: set (CMAKE_CXX_STANDARD 14) as the second line in my CMakeLists.txt right after cmake_minimum_required(VERSION 3.2)
Thank you.

maybe nevermind.


Make action fully equivalent to the okteto build command

Resolves https://github.com/okteto/app/issues/6884
In order to make the action fully equivalent to the okteto build command here are the following changes:

recover at entrypoint.sh the inputs documented at action.yml: tag,path and buildargs
remove unused global from both entrypoint.sh and action.yml. Users can push to global registry by specific tag.
include additional options no-cache, cache-from, export-cache, secret to be able to used them at the action
review Readme and add more examples of use

Tests done
Used repository https://github.com/okteto/go-getting-started and https://github.com/okteto/movies-with-helm to have both monorepo and single repo
As entrypoint.sh is a script, locally simulating the input from the action with running the script with arguments

Build single service not included at Okteto Manifest  ./entrypoint.sh "myapp:dev" "Dockerfile" "."
Build single service included at Okteto Manifest  ./entrypoint.sh "" "" "myapp"
Build all services included at Okteto Manifest  ./entrypoint.sh "" "" ""

Maybe we should include an action test for a Dockerfile in okteto/okteto repo


Py w3c update

Updates to correctly send W3C capabilities to Sauce Labs in the Python case

@nikolay-advolodkin this PR looks good, and the codacy issues that are left can be ignored/disabled. I just can't seem to do that?


Bot Refresh token overrides some of the configurations in botConfig.json

When the bot refreshes its access token the object that it is writing back to the file will erase the clientId, target, and Secret
const authProvider = new RefreshingAuthProvider(         {             clientId,             clientSecret,             onRefresh: async newTokenData => await fs.writeFile(tokenLocation, JSON.stringify({...tokenData, ...newTokenData, target: TARGET}, null, 4, 'UTF-8'))         },         tokenData     );

Fixed in update 0.0.2


docs: VS code debugging config & MRE

Vs Code debug config

As proposed by @erezrokah
https://github.com/MentalGear/netlify-dev_debug_vs-code/pull/1#issuecomment-846510622

Sorry for the force push @MentalGear, I though the missing status checks are because you were missing a rebase, but it's because of https://github.com/netlify/cli/blob/a2e10672b4695cd69d430e0a263d7c3e1d0175b5/.github/workflows/main.yml#L11

Thanks for the review. I added to your comments above and updated the guide with the dependency note as well as a more straightforward numbered instruction.

I have spawn out the Debugging part into its own page and added the discussed changes. @erezrokah.

Sorry for the very late follow up @MentalGear. I was finally able to dig more into this.
I think I was able to further reduce the launch configurations size and also avoid the usage of an extension.
Also, now VSCode will wait for the server to be up before launching the browser.
I didn't have any issues with source maps not loading with my Create React App project, so I'd assume their project specific and would want to avoid adding them in the default configuration.
If that's not the case can you please  guide how to reproduce that issue?
I've pushed my changes in https://github.com/netlify/cli/pull/2440/commits/adfe78f4da253acd77a7ba2aa6e72006fe32fbfa
See https://deploy-preview-2440--cli.netlify.app/vscode


Added new stickless 14 button display option

Changes:
Added a new stickless 14 button layout to resemble my Fightingbox Flatbox Ultra layout.
Without input history:

With input history:

Issues:

Currently in the web configurator, under Configuration => Display Configuration, when setting either of the button layouts to "Custom", "Stickless 14" does not appear under the drop down menu of the "Custom Button Layout Params".
My device is unsupported and the layout is not that common. There are other devices with similar layouts such as the Chocobox Beastbox and the TSR:ACT HyperCube but they are also not supported and don't have a screen.

Questions:

My device is unsupported so I know its config file will never be on the official repo, and a compatible config file is not that accessible. Is there a place where I can upload my uf2 file for the device for more people to see? For now I'm looking into uploading it to github as a release on my fork.

Hi @jnkhac ,
Are you the original creator of the Flatbox Ultra?

@TheTrainGoes I am not the original creator. I just own one.

@jnkhac I have been on the fence about this one (not your code).
  If so can you toss me a DM to chat?

@TheTrainGoes Yes I'm in the discord. I've sent you a DM.


Preview videos don't render correctly in Chrome, Firefox

Hi,
Screenshots are not showing.

Unfortunately they only display correctly in Safari for now – I'm trying to figure out if there's a way to get video files in the repo to show up in README on Firefox and Chrome, too.
GitHub only seems to embed their player for videos hosted on user-images.githubusercontent.com, e.g.:
https://user-images.githubusercontent.com/212465/184840861-8ac4f456-4066-4872-9be5-47b365e8f549.mov

can be converted to gif


feat: cdh,hdp,apache version adaptation

apache,cdh,hdp version adaptation

EN title "Version adaptation" -> "Version Adaptation"
duplicate sidebar subtitle sequence number


Use chunks of triples to compute Pedersen hash

Besides generating an ML file with Pedersen hash parameters, we also generate a table of curve values for chunks of triples. The size of the chunk is given by Chunked_triples.Chunk.size.
With a chunk size of 3, hashing takes about half the time. Generating the table takes a small number of  seconds; increasing the size increases the generation time. The serialized version of the table is large, about 70 Mb, perhaps a consideration.
The code was tested by building and running all unit tests, and for every hash computed, it was computed using the existing method and the chunked method, and comparing the results.
There are conversions between triple chunks and integers, there's a unit test that exhaustively checks the range of possible integers.

Is chunk size == window size in Zcash’ jargon?

I don't think they're related. Not sure.

I also don't think they're related. Confusingly, they are also not related to what the Zcash specification refers to as "chunks" (which affect the definition of the hash; they're not just an optimization as these chunks are).

Chunks is just something I made up, nothing to do with Zcash.


I noticed a few golangci-lint errors

Dear maintainer,
I noticed a few errors reported by golangci by looking at your code.
http.go:45:31: G402: TLS MinVersion too low. (gosec)
	transport.TLSClientConfig = &tls.Config{}
	                            ^
main.go:330:2: unhandled-error: Unhandled error in call to function bufio.Writer.Flush (revive)
	d.out.Flush()
	^
scroll.go:18:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
func (d *dumper) scroll(ctx context.Context, scrollers []func(context.Context) error) error {
      ^

Feel free to consider them or not

Dear reviewer,
I've fixed the 2 revive warnings, but not the gosec one as it is wrong (empty TLS MinVersion defaults to 1.2 with Go > 1.18 which is fine)


[WIP] feat: group main help message to put important commands to the top

Groups root help message to include important commands at the top

@grafvonb how is it going with this? When you are ready for a review, please remove the WIP label and title description. Thanks!

@grafvonb how is it going with this? When you are ready for a review, please remove the WIP label and title description. Thanks!

Hi, I'm still working on so the WIP label is right. I hope I will get it ready in the following days and than I will change the label as requested.

@lance Hi, I found some time today to continue working on the feature. As you know for the implementation I use the code from kn as a basis and have discovered two problems today, so the ticket is back in WIP status.
The first problem is rather small, it's about the wording. kn uses the word 'options' as a replacement for 'flags'. Should we also use 'options' for func?
The second is about listing help for the global flags (options) like '--help', '--namespace' etc.
kn uses a command kn options for this ("The following options can be passed to any command:"), otherwise only a static hint is displayed. How do we deal with this?

@lance Maybe to keep it simple I will implement exactly the same help behaviour as current one (cobra's help standard), means:

changing all current wording "inherited" form the kn implementation from options to flags,
expand help templates code to be able to list global flags as current implementation does.
What do you think?
PS. As I written above, an alternative for point 2 would be a new command that lists the global flags on demand (aka kn style)

@lance Maybe to keep it simple I will implement exactly the same help behaviour as current one (cobra's help standard), means:

changing all current wording "inherited" form the kn implementation from options to flags,

I think this is probably the best course of action for now.

expand help templates code to be able to list global flags as current implementation does.

This should be pretty straightforward, right?

What do you think?
PS. As I written above, an alternative for point 2 would be a new command that lists the global flags on demand (aka kn style)

I think it's odd, I suppose. I am not sure how intuitive func options or func flags would be for a user vs. simply func <cmd> --help. Frankly, I've been using kn for a while now and did not know about the options command. In any case, we really only have --help and --verbose, I think. Perhaps --path.
My preference is to expand the templates code as you suggest.

@lance The feature is actually ready, as discussed I changed the labels to flags and replaced options command by global flags template. However after docs generation I found two another problems:

in the generated Synopsis section for all commands there is no [flags] suffix. I will have to change the implementation to achieve that,
it is an observation, the generated docs uses options instead of flags. I suppose that was the reason why kn help implementation changes the wording. We have no possibility to change this behaviour as it is hard coded in docs package of Cobra:

func printOptions(buf *bytes.Buffer, cmd *cobra.Command, name string) error {
	flags := cmd.NonInheritedFlags()
	flags.SetOutput(buf)
	if flags.HasAvailableFlags() {
		buf.WriteString("### Options\n\n```\n")
		flags.PrintDefaults()
		buf.WriteString("```\n\n")
	}

	parentFlags := cmd.InheritedFlags()
	parentFlags.SetOutput(buf)
	if parentFlags.HasAvailableFlags() {
		buf.WriteString("### Options inherited from parent commands\n\n```\n")
		parentFlags.PrintDefaults()
		buf.WriteString("```\n\n")
	}
	return nil
}

It would be good to have a consistent wording in the func help and docs, however it is not critical to me.

@grafvonb I see what you mean. I agree that consistent wording is important, but I don't want to hold up this PR on that issue. The other issue you note

in the generated Synopsis section for all commands there is no [flags] suffix. I will have to change the implementation to achieve that

seems also to be a minor thing to me. It's the difference between the string func build and func build [flags] as even in the existing generated documentation, the flags themselves are not enumerated here but rather in the Options section. I think it's OK to go with both of these as is for now, and open two new issues to address them. @zroubalik @matejvasek @lkingland @salaboy wdyt?

Agree 👍

/lgtm

@grafvonb are you ready for this to merge?

@lance I just fixed a problem where the docs for the root command was not generated correctly. The problem was that we were using placeholders in the "long" help message, which was not supported by the kn version. I also moved the help messages back to the main command, because storing them in the templates breaks the coherence. Now the help is displayed correctly and the docs are fine too. I think I am done with the problem.

/lgtm
Thanks @grafvonb for the contribution!

/unhold


valid command word in wrong window/tab shows appropriate error message

Fixes #150
Currently, a valid command word in wrong window/tab throws an "unknown command" error. Which is not true.
Thus, if user uses client window commands in home window, an appropriate message is shown and vice versa.
The same logic is applied to tabs as contacts tab accepts only edit. while assets, liabilities, policies tab accept only append and remove on top of those inherited from client parser. notes tab will not accept additional commands.
Note that this PR will likely impact @mrmrinal incoming tests.

I noticed that there's a NotesTabParser. Given that we are not implementing a CLI for Notes we should remove it.

Codecov Report

Merging #306 (b491be2) into master (29bf8eb) will increase coverage by 0.02%.
The diff coverage is 30.00%.

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
+ Coverage     70.00%   70.02%   +0.02%
- Complexity      590      596       +6
============================================
  Files            98       98
  Lines          2170     2195      +25
  Branches        177      180       +3
============================================
+ Hits           1519     1537      +18
- Misses          566      572       +6
- Partials         85       86       +1

Impacted Files
Coverage Δ

...java/donnafin/logic/commands/ContactTabParser.java
50.00% <0.00%> (-10.00%)
:arrow_down:

...main/java/donnafin/logic/commands/EditCommand.java
6.25% <ø> (+6.25%)
:arrow_up:

...n/java/donnafin/logic/commands/NotesTabParser.java
0.00% <0.00%> (ø)

.../java/donnafin/logic/parser/AddressBookParser.java
38.46% <0.00%> (-7.00%)
:arrow_down:

...in/java/donnafin/logic/parser/AssetsTabParser.java
0.00% <0.00%> (ø)

...va/donnafin/logic/parser/LiabilitiesTabParser.java
0.00% <0.00%> (ø)

...in/java/donnafin/logic/parser/PolicyTabParser.java
0.00% <0.00%> (ø)

src/main/java/donnafin/commons/core/Messages.java
66.66% <100.00%> (+16.66%)
:arrow_up:

...n/java/donnafin/logic/parser/ClientViewParser.java
41.17% <100.00%> (+3.67%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bf8eb...b491be2. Read the comment docs.

I noticed that there's a NotesTabParser. Given that we are not implementing a CLI for Notes we should remove it.

our discussion for reference: We should still have it even if there is no logic in it. ClientViewParser is a an abstract class, and we still need a concrete implementation for to handle commands in the notes tab.
I see you've already done it anw 👍

wowie


[top/chip] Rename chip-level tops

This renames all target specific toplevels such that they are prefixed with chip_* instead of top_*.
This is done to distinguish the target-specific chiplevel wrappers from the actual functional toplevel, which contains all the IPs, crossbar, etc.
Note that another option would have been to rename top_<name> -> <name>, but we refrained from doing so as this would change the definition of what we have so far referred to as top_<name>, and would have a more profound impact on tooling scripts, generated headers and packages that use the name top_<name> inline (e.g. hierarchical paths) or as part of the file name.
This is dependent on #5793, so only the last commit is actually relevant.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Let me know what you think.
We can still go the other route and rename the top_<earlgrey> -> <earlgrey> - however I do think that the top_* -> chip_* renaming has less overall impact (also in terms of how we have so far referred to "the toplevel", as it does not change its definition).

I don't have strong feelings about this naming. Honestly, I think it might be better to rename the other stuff that we're clashing with (so that a "top" is actually a top-level), but if that's going to be difficult then this seems like a reasonable way to go.

Another option we previously discussed in #295 was to use base_earlgrey for the functional top and top_earlgrey for the real, target-specific top. But I see that this could cause a lot more work with the scripts. And to be honest, I don't really mind. The proposed chip/top naming sounds very reasonable to me. That's how we used to do it at ETH as well.

I don't have strong feelings about this naming. Honestly, I think it might be better to rename the other stuff that we're clashing with (so that a "top" is actually a top-level), but if that's going to be difficult then this seems like a reasonable way to go.

this is my sentiment as well.  So this LGTM.


Update getting started guide

Fails

:no_entry_sign:
PR Title 'Update getting started guide': subject may not be empty, type may not be empty

Warnings

:warning:
:exclamation: Please include a description of your PR changes.

:warning:
Commit Message 'Update getting started guide': subject may not be empty, type may not be empty

Pull request should have a description of the underlying changes.

Pull request title should follow Conventional commits.

  Generated by :no_entry_sign: dangerJS against 1d7f18309201dfd70fc5cb0c3fef134009a94f89