On manually deleting the selected option the initial value is still submitted.

Hi Team
When a user has selected an option from the autocomplete, if they press the delete key until the input field is blank and then submit the form, the initial value is submitted, as opposed to a blank field.

Yeah, this is a legit issue with the way the autocomplete works currently. Because it uses a select element underneath, unless that select element has a default option which doesn't pass validation, the user will always submit whatever is default. You need to add custom validation to prevent this.
I've marked this as a bug as we should find a better way to communicate or work around this behaviour.

Also worth noting that this also applies when entering gibberish into the field, basically anything that doesn't match an option results in the previously selected option being submitted.

My expectation is that whatever's entered in the field be submitted.
Where it's progressively enhanced from a select, this should be blank or an option - as we shouldn't allow users to leave text in the field that isn't an option.
Where it's an enhanced text box, we should leave whatever they type and submit it.

This is a legitimate bug that needs fixing but it's also related to the wider discussion here: https://github.com/alphagov/accessible-autocomplete/issues/260

I wonder if it would be hard to make the autocomplete swap out the select for an input when it initialises - ie don't use selects under the hood after initialisation - that way whatever the input visually contains is what gets submitted.


Download event for downloading manifest or design type

Notes for Reviewers
Adding download event with description when downloading K8 Manifest or Meshery Design.

This PR fixes #

Signed commits

[ ] Yes, I signed my commits.

@leecalcote, The test is failing cause we are not checking the error when creating event. But i don't think we need to since the error won't affect the main logic of handlers.

Include an error handler error code specific to events.


Add metadata to patch commits

Add metadata to the commit and don't comment patches by default.
Update help message.
Requires: https://github.com/packit-service/packit/pull/875

tried on rpm, worked well

Thanks for trying that!


REQ framework ignores snippets in paths

This is a pretty advanced bug, unless you have knowledge of our REQ/validator framework.
Basically, it appears that we skip over validators if the function argument was provided via Django using urls.py to pull a parameter out of the URL path with a regex check.
More details here: https://chat.zulip.org/#narrow/stream/3-backend/topic/types/near/907156

@andersk @timabbott Bumping this, just in case any of the recent changes have addressed this (or in case we should do it now while we're focused on this code).


Swiper slider does not work in tab

It doesn't work in tabs(tab two).. help me
https://mikij1029.github.io/web/020-navigation.html

@mikij1029 and @nolimits4web have a possible similar issue.
Context:

I have menu that shows simply shows and hides swipers (similar to tabs) with hidden attribute which is equivalent to display: none. What I know is that In my situation is related with autoplay, because if i remove it from the config, everything works fine.
version<EMAIL_ADDRESS>
Reproducible scenario:

toggle second tab before autoplay kicks in (delay).
wait for autoplay to loop 1 slide
toggle back to the first tab
Swiper buttons don't work

Here's a video demoing: https://cl.ly/1c1e2831bb0e
Here's a reproducible example: https://ysoe2.csb.app/
Additional Notes

despite buttons not working, if drag is enabled after a first swiper, the slide comes back to work, and only then the buttons work, so it must be something related with updates and the buttons event listeners.

How i've workaround it:

manually triggering swiper.slideTo(0,0) does the trick, but it has unwanted sideffects:

if autoplay was enabled, it's now disabled because of disableOnInteraction;
i have to manually track current slide of each swiper, so when we get back to a tab, swiper is at the same position.

Hope it helps debugging, and thanks for swiper!
☮

I had the same issue, i fixed it by setting the slides per view to 6 (in my case that is more or less how many slides there will be at the same time) and then overriding it with css setting the width of the slides to "auto", if you won't set the number of slidesPerView then no new slides will be added to create a loop.


Feature request MQTT with user and password

Is it possible to use this with my mqtt broker, that uses a username and a password?

Nevermind I´ve added
"mqtt_user": "User",
"mqtt_password": "Password"

to config.json
and
     protocolVersion: 3,     // ""
     username: config.mqtt_user,
     password: config.mqtt_password

to  node-spc-mqtt.js
and it worked.
maybe you could integrate it, with and witohut password.

I have had the gateway and mqtt add-on in place for a while now.
Tonight I decided to do a security review on all of my apps and services, and configured username and password on MQTT.
Your timing for this post could not have been better. Thanks for coming back and posting your solution!


Duplicate memory affinity domain strict check

It's possible to have multiple memory affinities on the same domain. Relaxing this check causes the system to work just fine.
--- a/kernel/src/acpi.rs
+++ b/kernel/src/acpi.rs
@@ -454,8 +454,8 @@ unsafe fn parse_srat(ptr: PhysAddr) ->                // Log the affinity record
                if (flags & FLAGS_ENABLED) != 0 {
                    {+//+} assert!(memory_affinities.insert(domain, (base, [-size))-]
[-                            .is_none(),-]{+size)).is_none(),+} "Duplicate memory affinity domain");
                    {+memory_affinities.insert(domain, (base, size));+}
                }
            }```

Tested on PowerEdge T640 with Intel Xeon SIlver 4110

I've seen this as well a few years back on some machines I used. The fix isn't exactly trivial so it might take me some time to get to. Without a machine to test on it'll be relatively hard to make sure I fixed correctly. I'll effectively need to support multiple memory ranges per NUMA node, otherwise I'd miss some ranges. This means anywhere I store these ranges (and check them during allocation), I need to support sets of ranges.

Done <3


istio istio-init run first before custom init container

I'm new to istio, Current i have an application need run database migration before it start, so i made a initContainer to do that, but when i enable the istio inject, it keep status init like this
devops-6cb75898c7-9p5tn      0/2     Init:0/2   0          33m
devops-db-69db4fcdc4-nrs9m   2/2     Running    0          69m

When i describe the pod status, i found it run migration task first
Init Containers:
  devops-migration:
...
    State:          Running
    Ready:          False
  istio-init:
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False

So, because I have my own initContainer, that must finish before the normal containers are started, and this container requires network traffic… so it fails because istio-proxy is not yet running…
anyone have some idea to resolve this problem ?

@clguo-tw I am facing exactly the same issue. Any workarounds or fixes for this?


RAINCATCH-118 - details directive

Work on hold - 29.11.2016 change of focus
Due to sudden change of focus in rmad this ticket need to be put back on the backlog.
Current work status:

main part of the ticket fixed
refactored to keep with convention set out in appforms refactor branch
tests are not working, angular namespaces/registering issue

Issue
An error would print in console in mobile client when file icon was tapped.
Solution
Cause of error is here -> raincatcher-demo-mobile/src/app/file/file-list.tpl.html
It was decided that I would implement  {file-detail} directive in file module, this needs to be configurable so client can choose which data to show.
JIRA
https://issues.jboss.org/browse/RAINCATCH-118

@witmicko Couple of comments above. Generally looks good though. It is in keeping with the conventions.

@witmicko Resolved issue and verified. More work and improvements would be done after moving all logic and views into the module itself


JSON and TypeAdapters produce unwanted values or empty list

Hi @hudson-ai!
Concerning the TypeAdapter constrained generation, here are some example of the issue mentioned here:
from guidance import models, capture
from guidance import json as jj
from pydantic import BaseModel, TypeAdapter
import json
from Noema.cfg import *

lm = models.LlamaCpp(
    "../Models/Mistral-NeMo-Minitron-8B-Instruct.Q4_K_M.gguf",
    n_gpu_layers=99,
    n_ctx=512*8,
    echo=False
)

lm.reset()
lm += "Generate a list of 3 integers between 1 and 4: " + capture(G.arrayOf(G.num()), name="generated_object")
print(lm["generated_object"])
# Output: ["1", "2", "3"]

lm.reset()
schema = TypeAdapter(list[int])
lm += "Generate a list of 3 integers between 0 and 4: " + jj(name="generated_object", schema=schema)
print(json.loads(lm["generated_object"]))
# Output: []

lm.reset()
lm += "Créé une liste des différentes étapes décrites ici: Ce matin je suis parti tot, puis j'ai acheté des pommes et enfin je suis allé au restaurant." + capture(G.arrayOf(G.sentence()), name="generated_object")
print(lm["generated_object"])
# Output: ["Ce matin je suis parti tot, puis j'ai acheté des pommes et enfin je suis allé au restaurant."]

lm.reset()
schema = TypeAdapter(list[str])
lm +=  "Créé une liste des différentes étapes décrites ici: Ce matin je suis parti tot, puis j'ai acheté des pommes et enfin je suis allé au restaurant." + jj(name="generated_object", schema=schema)
print(json.loads(lm["generated_object"]))
# Output: []

The file containing custom CFG is here.
This is just a workaround but it helps to produce a non empty list.
Concerning the JSON:
lm.reset()
class Schema(BaseModel):
     weather: str
lm += "What is the weather today? " + jj(name="generated_object", schema=Schema)
print(json.loads(lm["generated_object"]))
# Output using Minitron 8B : {'weather': ', '}
# Output using llama3 instruct: {'weather': ':sunny:'}

I'm not sure to understand what the expected generation is, but it seems that characters from the format are interfering with the generated content.

Hi @AlbanPerli sorry for the late reply here :)
I think that part of what you are encountering here is that lists aren't forced to be non-empty by default (I think your custom grammar definitions enforce a minimum length of one). If you want to enforce this behavior with TypeAdapters, you can use typing.Annotated and annotated_types.MinLen like so:
from typing import Annotated
from annotated_types import MinLen
from pydantic import TypeAdapter

ta = TypeAdapter(Annotated[list[int], MinLen(1)])
ta.json_schema()
# Output: {'items': {'type': 'integer'}, 'minItems': 1, 'type': 'array'}

You can of course get this behavior by just writing the JSON schema directly, or if you're using a pydantic.BaseModel, you can do these annotations a bit more ergonomically with the pydantic.Field descriptor.
If this doesn't address the core issue you're seeing, just let me know and we can figure it out :)

Hi @hudson-ai , my turn to apologize for the response time! :)
The point was indeed the minimum length, I wasn't aware of this parameter for the TypeAdapter.
Thank you!

Ok, good to know that works for you! Let us know if you hit any other unexpected or unintuitive behaviors :)


It should be possible to set the mount propagation modes for containers and volumes

Propagation modes determine how mount and umount events propagate between a mount namespace and its parent. The 'shared' and 'slave' propagation modes are critical to implementing use-cases where a container performs a mount that should be visible to other containers.
Currently the configuration spec lacks any way to specify the propagation mode of a mnt namespace relative to the host's mount namespace, or any indication of what the default propagation mode is.  Perhaps this should be an option you can specify in the 'namespaces' config section.
@mrunalp @rhatdan @rootfs

I agree.  We have talked about two different things here though. One would be to set the default for the daemon so that distributions could choose the default for all containers.  Red Hat Distributions would choose SLAVE as the default, since I believe this would cause the least surprise for administrators.
The second flag would be per container.  (Although some have suggested per volume mount, which I think might be too complicated, for little added value.)

@rhatdan Yeah, my description was a little imprecise.  I think everything on the table is:

Set default propagation mode for every volume of all containers
Set default propagation mode for every volume of a single container
Same as 2 except you can control the propagation mode of each volume's mount point

Completely agree that SLAVE is a reasonable default -- it jives with what the intuitive behavior of volumes should be if someone is unaware of propagation modes.
I really don't think setting a default for all containers is a great idea outside of a distributor making a call on the default policy, in part because I don't think most users are aware enough of this feature to fully reason through all the effects.  From the least-privilege principle, it seems like a bad idea to configure SHARED as a default, for example, but I could easily see someone setting this as a system-wide default in order to get a single container to work.

Yes, it seems like the namespaces list will need an additional parameter. And this parameter needs to be invalid if a "path" is given. Could someone work up a PR against https://github.com/opencontainers/specs/blob/master/config-linux.md#linux-namespaces and spec_linux.go?

@philips This could be a property of the root mount like here https://github.com/opencontainers/runc/pull/77 if we don't see a need per mount.

@mrunalp what's 'root mount' in the context of your comment?

rootfs mount propagation

IMO we need flags for both rootfs and volume propagation flags  to ensure things work as expected. For example, a PRIVATE propagation for rootfs negates SLAVE or SHARED volume. Such surprise should be avoided.

@rootfs Interesting point -- I probably need to do some more detailed experimenting, but I had thought that the if the mountpoint for the container's rootfs was private, that individual mountpoints with other modes (ie, /var/lib/kubelet with mode shared) would be allowed.  Am I missing something?

Currently the way the mount point propogation is being done is to do a make-rprivate, on / on the host, which basically prevents any other propogation on volume mounts from working.  If the make-private happened at the ROOTFS this would work.   I have suggested this change but have not heard back if this fixed the problem that caused @crosbymichael to revert the change in the first place.

That's because the propagation is recursive (MS_REC). So if you make rootfs private, it recursively makes all directories underneath private. Even you flip it to slave or shared, private flag still remains (there is no way you can remove a propagation mode).

Right but rootfs would make mountpoints under /var/lib/docker/... private not everything under /, which is the current behaviour.  If I just did this to /var/lib/docker/...  I could later mount in /var/lib/foobar into a container and changes it propogation mode.

@rootfs

That's because the propagation is recursive (MS_REC). So if you make rootfs private, it recursively makes all directories underneath private. Even you flip it to slave or shared, private flag still remains (there is no way you can remove a propagation mode).

Under the fedora build of docker 1.6, I see both propagation modes from findmnt, but it still works as I expect (slave):
$ docker exec -it 36e findmnt /var/lib/kubelet -o TARGET,PROPAGATION | grep kubelet
/var/lib/kubelet private,slave

So, is that really an issue?

it is probably working for your use case, but it breaks mine. I am more interested in shared, i.e. making container mounted directories also visible on the host.

@rootfs what is your specific use-case?
On Thu, Jul 9, 2015 at 1:12 PM, Huamin Chen<EMAIL_ADDRESS>wrote:

it is probably working for your use case, but it breaks mine. I am more
interested in shared, i.e. making container mounted directories also
visible on the host.
—
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/specs/issues/56#issuecomment-120074844
.

@pmorie
https://github.com/GoogleCloudPlatform/kubernetes/issues/8124#issuecomment-101393415

@mrunalp I see, this makes sense putting a flag on the mounts. Perhaps we just make the rootfs another mount to cleanup the schema. So:
"mounts": [
    {
        "type": "bundle",
        "source": "rootfs",
        "destination": "/",
        "sharing": "slave",
        "options": ""
    },

@philips actually that option goes in the options field as just slave and rslave.

On Thu, Jul 09, 2015 at 11:21:26AM -0700, Brandon Philips wrote:

Perhaps we just make the rootfs another mount to cleanup the schema.

I like this approach better, since it lets us avoid having two
separate structures for root mounts and other mounts (e.g. one handles
read-only explicitly, and another which handles it along with other
things in an options field).  We can always fail out if the user
doesn't specify a root-destination mount.  But note that things may be
a bit trickier on Windows which requires a read/write mount 1 and
may not have a native analog for “root filesystem” 2 (but I'm not
familiar enough with Windows to know what the appropriate destination
path should be).

@crosbymichael Hrm, I thought the options field was in the fstab format and that fstab didn't allow setting propagation modes, is it possibly a gap in the fstab spec?

fstab does not allow  you to specify propagation.

I used rootfsPropagation in spec.Linux https://github.com/rootfs/runc/commit/b68acd7c7b57239186c954437ec864d7d6f24d01

@rootfs I agree we should just add it to the root mount too. @crosbymichael eh?

@rootfs @philips +1, could you open a PR here to add it to the spec?

@mrunalp done, see #70

@rootfs I meant a PR to change spec_linux.go in this repo :)

Is this closable now that #71 has been merged?

Yes, closing based on #71


Change term

Description

Link to Jira

Screenshots

I think this can be closed in favor of #4156.

PR twice, we just need one of them


Stars src availability

Hello All,
I cannot find the src for the 'Stars' custom visual that's available on https://app.powerbi.com/visuals/ .
Am I just missing something simple?
Eric

This visual is developed by someone from the community.
The sources are located in GitHub: https://github.com/tisawyer/Stars-Custom-Visual
You can look here: https://app.powerbi.com/visuals/show/PBI_CV_9053509D_D461_463A_B485_CE9F6AB0F13C
there is a link to the github from there


Decals reset sorting offset after 32 instances

Godot version
4.1.2.stable.official
System information
Windows 10 - 4.1.2.stable.official - Forward+
Issue description
I was making an SMG and while implementing decals for each bullet hole on meshes, I noticed that overlapping bullet holes would glitch because they where all on the same positions and sorting offset.
So I implemented a system where my player would remember each bullet as an Int and set that int as the sorting offset for each bullet hole decal, this way each decal would have a different, rising sorting offset. This fixed my original issue but opened another one that seems unsolvable:
Whenever 32 shots are fired, the next one would "reset" the sorting offset of the decal that was -32 places before to be on top, even though the sorting offset is still set correctly for each one.
I've attached a minimal reproduction project below which shows this issue.
Here's a video also showing the issue:
https://github.com/godotengine/godot/assets/139187233/c092b672-03c2-4c4f-b83d-b6babbefc458
Steps to reproduce

On some mesh, instantiate decals with rising value on the sorting offset for each one
On the 32nd decal, each decal instantiated after it will reset the visibility of the '32 places before' decal to be placed on top

Minimal reproduction project
Decals Issue.zip

Note that for performance reasons, you may want to prevent too many decals from overlapping in general (FPS will drop if the player gets close to overlapping decals). This can be done by discarding the old decal when placing a new decal nearby (or not spawning a new decal in the first place).

Note that for performance reasons, you may want to prevent too many decals from overlapping in general.

I'll probably do this, since overlapping this many bullet holes doesn't look good in the first place, and other games probably do something similar.
I think I'll just remove any decals in contact with the decal that will be placed, that seems like the better solution.
Still wanted to post this in case this is an actual solvable issue in the engine.


Bump mongoose version in order to support mongo 3.0 auth

All tests passing; great work. Thanks @romanmt. Please add yourself into contributors and I'll release. :+1:


Multiple of my newly added GitHub repositories are hanging in state 'Cloning'

Multiple of my newly added GitHub repositories are hanging in state 'Cloning'.
This state was entered 7 hours ago.

Project URL:

https://readthedocs.org/projects/rc3e-client
https://readthedocs.org/projects/rc3e-server
https://readthedocs.org/projects/rc3e-node
https://readthedocs.org/projects/rc3e
https://readthedocs.org/projects/rc2f

Read the Docs username (if applicable): Paebbels

Hi @Paebbels , I'm seeing this also in my internally-hosted RTD server. Repos older than 5 days seem to be OK. Let me know if you want to compare notes offline.

Hello,
the repository is now older than 6 days. I tried a new build run, but it's still cloning. Is there any chance to kill the old tasks?
Regards
Patrick

Not sure why I have access to build these projects :)
But when I do, I get Invalid "requirements_file": path requirements.txt does not exist so perhaps the issue has changed?


[Fix] Fix ssh issue, when the password is not None.

Coverage remained the same at 52.627% when pulling e6d084fb9ee51c9b838344cd7590f2c6dc05371a on yuye/master-issue-fix into 723824d093bdba7a7e6058255099d1d1debd79b0 on master.


Teams bot onMemberAdded messages without actual event

I have a Teams bot added to channel.
Bot is based on Proactive Messaging Bot from Microsoft GitHub.
There is a following peace of code:
this.onMembersAdded(async (context, next) => {
  const membersAdded = context.activity.membersAdded;

  for (let cnt = 0; cnt < membersAdded.length; cnt++) {
    if (membersAdded[cnt].id !== context.activity.recipient.id) {
      const welcomeMessage = `Welcome to the Proactive Bot sample.  Navigate to ${process.env.PROVISIONOUTPUT__BOTOUTPUT__SITEENDPOINT}/api/notify to proactively message everyone who has previously messaged this bot.`;
      await context.sendActivity(welcomeMessage);
    }
  }

  // By calling next() you ensure that the next BotHandler is run.
  await next();
});

Basically, whenever new member is added, there will be a welcome message.
The problem is that sometimes we see in the channel welcome messages without any reason - no new member added.
What could be the reason?

Hello @whyte624 - Thanks for raising your query.
We will look into it and let you know the updates.

@Pawank-MSFT -Could you please help on this issue?

Hi @sayali-MSFT!
I am not very experienced with teams bots. I just followed instructions ho it can be implemented and did it.
I do not think I have a network trace. How can I find it? Or maybe there are other ways to debug the problem?
        this.onMembersAdded(async (context, next) => {
            const membersAdded = context.activity.membersAdded;
            for (let cnt = 0; cnt < membersAdded.length; cnt++) {
                if (membersAdded[cnt].id !== context.activity.recipient.id) {
                    const welcomeMessage = 'Welcome!';
                    await context.sendActivity(welcomeMessage);
                }
            }

            // By calling next() you ensure that the next BotHandler is run.
            await next();
        });

Basically, sometimes without any changes in channel members we receive message 'Welcome!'.
For example few latest messages out of the blue happened (GMT+2):
2023-12-12 16:35
2023-11-30 15:35
2023-11-23 17:35
2023-11-13 18:31
2023-11-7 14:57
2023-10-12 13:24
In fact this bot should not write anything in group channel only in private messages.


apktool is removing -v(number) from some folders in "res" folder

Information

Apktool Version (apktool -version) 2.4.0
Operating System (Mac, Linux, Windows) Windows 10
APK From? (Playstore, ROM, Other) Playstore

Stacktrace/Logcat
PS E:\Apktool> java -jar apktool_2.4.0.jar d  E:\Downloads\BlackVue_v2.94_apkpure.com.apk
I: Using Apktool 2.4.0 on BlackVue_v2.94_apkpure.com.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
S: WARNING: Could not write to (C:\Users\admin\AppData\Local\apktool\framework), using C:\Users\admin\AppData\Local\Temp\ instead...
S: Please be aware this is a volatile directory and frameworks could go missing, please utilize --frame-path if the default storage directory is unavailable
I: Loading resource table from file: C:\Users\admin\AppData\Local\Temp\1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
PS E:\Apktool>

Steps to Reproduce

apktool d

Frameworks
None
APK
https://apkpure.com/blackvue/comb.blackvuec
Description
Why apktool is removing -v(number) from some folders in "res" folder? what is the point?
APK file:

Decompiled APK:

This make me lot difficult to work with unsigned APK since I only copy modified files to unsigned APK to use with VirtualXposed and disabled signature on firmware
Is there a way to prevent it and keep all original?

Unfortunately this is not possible to resolve at present time. See https://github.com/iBotPeaches/Apktool/issues/1761#issuecomment-379309998 for details.

Ok well I found other way to deal with this


Make the Gate Chalice screen distortion follow the new Disable Screen Distortion option

Oh, it's automatically handled by the game. Cool!


export internals for use in async-tar

async-tar is in large part a copy-paste of the internals of this crate. Over time the implementations are drifting apart (for example async-tar apparently supports redox as a target).
this seems a bit daft to me. I wanted to gauge whether there was any appetite for refactoring this crate so that some of the internals could be imported in async-tar instead of being copied.
for example the header.rs implementation is damn near identical (see #254)

Sorry I don't know much about async-tar or the history there. I think it's fine to export more functionality from this crate but I would still want a well-designed API with pieces that are thought through well and make sense. I don't want to "just make everything pub", for example.

Sorry I don't know much about async-tar or the history there. I think it's fine to export more functionality from this crate but I would still want a well-designed API with pieces that are thought through well and make sense. I don't want to "just make everything pub", for example.

I was thinking more along the lines of splitting out some of the types into a separate crate and publishing that, rather than just adding pubs everywhere

Personally I would prefer to not maintain a separate crate for that purpose.

It would be a separate crate in the same repo, as a workspace. But I understand the reservations


OpenCL copy test fails on develop

Description
I haven't looked into what's happening yet, but after  #1407 `opencl/copy_test is failing on develop
Example
./runTests.py ./test/unit/math/opencl/copy_test.cpp

Expected Output
Tests's pass
Fix
Going back to 6455b691681c11e11c3c6ecc6de39a9cf5c3c206 has the tests pass. Let's revert 6723f81778f3ba939a95908c70d1514bfd322713 and then open a revert-revert PR for the fix
Current Version:
v3.0.0

(fyi this happened post-release so it's only on dev)


Don't spam my github feed

I would ask that you keep your marketing messages for vscode releases off my github feed.
I had all notifications ignored for this repo but someone has decided to ignore that and have spammed my feed.

Incorrect, normally these show up if you have notifications turned on for a repo - I turned notifications off on this repo a long time ago and I have never had a notification appear on my feed since then until today.
Something has changed - I don't get notifications on other repos I have starred yet silenced notifications for.
I can evidence this with a simple screenshot of my feed, see the notification today:

; now compare that to a screenshot of my feed that overlaps with your release from 28 days ago:

The previous releases are missing from my feed, but your most recent one is sitting there at the top.

Am I jumping to conclusions that somebody within Github and/or Microsoft decided to ignore notification statuses on purpose in order to further push out a microsoft product? Yes.
Why? Because I see no other releases in my feed from projects I follow yet have silenced notifications for.
I'm tempted to star some other microsoft repos and silence them to see if the same behaviour occurs on them.

I think this answers the question:

But you really need to contact GitHub about this issue because we don't control what appears in your feed.

Nope - it definitely doesn't.
Why didn't I get notifications for this repo in the past? I starred this repo many years ago.
The sooner you accept the fact that someone is playing funny buggers with the notifications coming out of your repository the better.
I've unstarred this now, every time I try to start to like things microsoft are doing I soon end up with a sour taste in my mouth.


Right button on the picture selector does not index correctly

Currently the right button to the picture selector slide will periodically, but not always,  present either the entire collection of pictures, or no pictures.

This is now solved by implementing a number of checkers on the indexed values in the rotating slice function applied on the left right button.


Double Whispers

Some downranks trigger double-whispers, like Shield and Aspekt of the Hawk:

Dupe of #10


Fix18559 1

Supersedes https://github.com/dlang/phobos/pull/6257

@Geod24 note that this doesn't actually fix the entire issue as noted in the OP. NaN and getNaNPayload can probably be safely ignored, I doubt any one uses those. remainder, remquo, is a little more serious. But the most glaring one is the log functions.

@thewilsonator : Thanks for the precision.
For context, I did the renamed because I am subscribed to all dlang repository, and need to quickly sort through my notifications to see what's relevant to my use cases and knowledge, so titles like "Fix18559 1" tend to annoy me :)

Netflix/vectorflow#33 merged, waiting on new tag.

That's a pretty obvious breaking change though :/

That's a pretty obvious breaking change though :/

Yeah, the adaptation is ugly and probably shouldn't be necessary.
float foo(float a, float b);
double foo(double a, double b);
real foo(real a, real b);

alias T = double;
T bar(T x)
{
    pragma(msg, typeof(x * short(1)));
    return foo(x, short(1));
}

double
onlineapp.d(9): Error: `onlineapp.foo` called with argument types `(double, short)` matches both:
onlineapp.d(1):     `onlineapp.foo(float a, float b)`
and:
onlineapp.d(3):     `onlineapp.foo(real a, real b)`

Note that foo(double, double) is not even in the list (apparently depends on lexical order...).
I don't know whether that can/should be handled based on the types alone (a short to double conversion is guaranteed to be loss-less, so ``foo(double, double)should be the obvious overload to be taken), or whether literals (e.g., common0, 1, 0.5`...) can/should be treated specially.


Feature Enhancement - Class-Based Structure and argparse Integration

Summary
Enabling Surveyor usage from both the command line and environments such as Jupyter notebooks with in-script arguments offers greater flexibility and convenience. This pull request aims to refactor Surveyor by introducing a class-based structure and replacing the click library with argparse. This enhancement enhances Surveyor's versatility, empowering users to perform efficient security assessments and promote collaborative, automated analysis workflows.
Benefits

Seamless integration into existing workflows
Automated analysis and customizable assessments
Easier collaboration and streamlined workflow
Increased adoption and user engagement

Changes Made

Introduced a class-based structure for better organization
Replaced the click library with argparse for improved argument handling
Maintained CLI functionality by passing arguments to the new Surveyor class for processing

Checklist

[x] Updated the class-based structure for Surveyor
[x] Replaced click library with argparse
[x] Ensured CLI functionality is maintained
[x] Tested changes in both command line and Jupyter notebook environments
[x] Updated documentation to reflect changes
[ ] Added relevant unit tests for the new class-based structure

Could use some help rewriting the unit tests
Related Issues
Closes #127

This looks great! With these changes it would also be fairly simple to restructure the project into a package that could be published to PyPi. That'd make it easier to use the project in notebooks and other contexts that natively support loading packages from the package index. We'd need to leave surveyor.py in place to avoid breaking compatibility for users that currently check out the repository manually.


Regression tests

Would be nice to have many of the tests also have regression tests like gdsfactory does.

we can move that part to kfactory and kfactory can use it

yeah, absolutely. I was just being cheeky when I added help wanted ^^.
I think it would be great if we can add it, but it's not urgent at all


pythonPackages.pytestflakes: 0.2 -> 1.0.0

cc @domenkozar seems a major update?

The (README)[https://github.com/fschulze/pytest-flakes/blob/master/README.rst] gives the following changes:
1.0.0 - 2015-05-01

    Fix issue #6 - support PEP263 for source file encoding. [The-Compiler (Florian Bruhin), fschulze]
    Clarified license to be MIT like pytest-pep8 from which this is derived. [fschulze]

This seems actually minimal changes, just calling it a stable release (1.x.x) (last release was from 2013)


Deno.emit is not a function

Thank you for creating this!
I run denoflare serve hello-local & the result is
Compiling https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli-webworker/worker.ts into worker contents...
error: Uncaught (in promise) TypeError: Deno.emit is not a function
    const result = await Deno.emit(rootSpecifier, {
                              ^
    at emit (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/emit.ts:3:31)
    at Function.start (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/worker_manager.ts:30:32)
    at createLocalRequestServer (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:122:55)
    at serve (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:155:38)
    at async https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli.ts:16:13

.denoflare
{
  "$schema": "https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/common/config.schema.json",
  "scripts": {
      "hello-local": {
        "path": "index.ts",
        "localPort": 3030
      }
  },
  "profiles": {
      "account1": {
        "accountId": "abc",
        "apiToken": "123"
      }
  }
}

index.ts
export default {
  async fetch(request: Request, env: any) {
      try {
          return new Response('hi')
      } catch (e) {
          return new Response(e.message)
      }
  },
}

deno --version
deno 1.22.0 (release, x86_64-apple-darwin)
v8 <IP_ADDRESS>
typescript 4.6.2

Congratulations, you've updated Deno to their latest cutting edge release!
Deno just removed Deno.emit from the latest version 1.22.0: https://deno.com/blog/v1.22#removal-of-unstable-denoemit-denoformatdiagnostics-and-denoapplysourcemap-apis
They have a new userland replacement module, but it is nowhere near the same functionality.
https://github.com/denoland/deno_emit
I have been filing issues all day : )
I had no idea this was coming, so have been looking at workarounds this morning.  I have enough in there that you can try installing denoflare from the latest commit and it should work on both 1.22 and earlier - but I'd appreciate any bug reports you have on that version too.  Even when the new userland module works, it doesn't seem to typecheck
If all else fails, you can also deno upgrade --version 1.21.3 to downgrade to the prior stable Deno version

Yay! That worked! Thank you! I think you're project is one of the best ever btw! Thank you for integrating Deno & Cloudflare for free!

Nice! Just curious, which did you do? Running latest denoflare or downgrade Deno?
If you get value out this project, consider a supporting donation!

I donated! So I did the downgrade, thank you for that! It initially worked & now it's not working
Chriss-MacBook-Pro-2:align-love chris-carrington$ denoflare serve hello-local
Compiling https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli-webworker/worker.ts into worker contents...
Compiled https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli-webworker/worker.ts into worker contents in 1008ms
runScript: index.ts
Error 'Unable to output during bundling.' contains boxed error of unknown type:
  Error { context: "Unable to output during bundling.", source: load_transformed failed

Caused by:
    0: failed to analyze module
    1: failed to resolve ./soon from file:///Users/chris-carrington/cloud/align-love/index.ts
    2: Cannot resolve "./soon" from "file:///Users/chris-carrington/cloud/align-love/index.ts". }
  Error { context: "load_transformed failed", source: failed to analyze module

Caused by:
    0: failed to resolve ./soon from file:///Users/chris-carrington/cloud/align-love/index.ts
    1: Cannot resolve "./soon" from "file:///Users/chris-carrington/cloud/align-love/index.ts". }
  Error { context: "failed to analyze module", source: failed to resolve ./soon from file:///Users/chris-carrington/cloud/align-love/index.ts

Caused by:
    Cannot resolve "./soon" from "file:///Users/chris-carrington/cloud/align-love/index.ts". }
  Error { context: "failed to resolve ./soon from file:///Users/chris-carrington/cloud/align-love/index.ts", source: Cannot resolve "./soon" from "file:///Users/chris-carrington/cloud/align-love/index.ts". }
  "Cannot resolve \"./soon\" from \"file:///Users/chris-carrington/cloud/align-love/index.ts\"."
error: Uncaught (in promise) Error: Unable to output during bundling.
    const result = await Deno.emit(rootSpecifier, {
                   ^
    at async emit (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/emit.ts:3:20)
    at async computeScriptContents (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:91:26)
    at async runScript (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:130:40)
    at async createLocalRequestServer (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:138:13)
    at async serve (https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli_serve.ts:155:32)
    at async https://raw.githubusercontent.com/skymethod/denoflare/v0.4.5/cli/cli.ts:16:13
Chriss-MacBook-Pro-2:align-love chris-carrington$ deno --version
deno 1.21.3 (release, x86_64-apple-darwin)

thanks for the donation! 🚀🚀🚀
failed to resolve ./soon from file:///Users/chris-carrington/cloud/align-love/index.ts
Make sure you are using deno/esm-style imports: e.g. import { foo } from ./soon.ts, not the node-style import { foo } from ./soon

You're welcome! Thank you so much!


python312Packages.meraki: 1.42.0 -> 1.43.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.meraki is: Provides all current Meraki dashboard API calls to interface with the Cisco Meraki cloud-managed platform
meta.homepage for python312Packages.meraki is: https://github.com/meraki/dashboard-api-python
meta.changelog for python312Packages.meraki is: https://github.com/meraki/dashboard-api-python/releases/tag/1.43.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.43.0 with grep in /nix/store/qa6z89pmb40x97lx0c8iifcrsxysvjxi-python3.12-meraki-1.43.0
found 1.43.0 in filename of file in /nix/store/qa6z89pmb40x97lx0c8iifcrsxysvjxi-python3.12-meraki-1.43.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
meraki-cli
python311Packages.meraki
python312Packages.meraki

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qa6z89pmb40x97lx0c8iifcrsxysvjxi-python3.12-meraki-1.43.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.meraki https://github.com/r-ryantm/nixpkgs/archive/d30108af3aa88164d120be200e09ab0083f5cfea.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d30108af3aa88164d120be200e09ab0083f5cfea#python312Packages.meraki

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qa6z89pmb40x97lx0c8iifcrsxysvjxi-python3.12-meraki-1.43.0
ls -la /nix/store/qa6z89pmb40x97lx0c8iifcrsxysvjxi-python3.12-meraki-1.43.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

meraki-cli
python311Packages.meraki
python312Packages.meraki

Maintainer pings
cc @dylanmtaylor for testing.

Result of nixpkgs-review pr 291685 at d30108af run on aarch64-darwin 1

3 packages built successfully:

meraki-cli
python311Packages.meraki
python312Packages.meraki


Fix an "expected expression" error

In C, a label can only be followed by a statement, not a declaration. An error in app/src/screen.c violated this, and led to a build error with an error message similar to the one below:
  ../app/src/screen.c:821:13: error: expected expression
              bool ok = sc_screen_init_size(screen);
              ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/stdbool.h:15:14: note: expanded from macro 'bool'
  #define bool _Bool
               ^
  ../app/src/screen.c:822:18: error: use of undeclared identifier 'ok'
              if (!ok) {
                   ^
  2 errors generated.

This could be fixed by introducing a new block (or compound statement; as is already being done in the next case). That is a statement.
Fixes #3785.

Confirmed - this fixes #3785

Thank you :+1:
I didn't notice because gcc does not complain.
Merged as 6b769675fa68e60c9765022e43c4d7b1e329353a.
For users: to make ./install_release.sh work, just git pull then retry.


Add Guess My Number Game

Is your feature request related to a problem? Please describe.
[GSSOC'21]
No its not a problem. I tried  to add one small project.
Describe the solution you'd like
I want to add this little game (Guess my number) using basic JavaScript and html, CSS!
Additional context
The game is about to guess the number until user guessed and got it right. It will also keep the highscore of your attempts and game along with it!
Do review this and if you like it give me permission to add this project and assign this issue to me.
@urvashi-code1255 @ridsuteri @Vishal-raj-1 @991rajat

I would like to work on this issue , will you assign me ?


Investigate weird text field scrolling behavior that doesn't match Flutter

The last tap on "SUBMIT" in text_form_field_demo_test.dart doesn't work because the text field scrolls into view after entering "Jane Doe" into it, which takes the "SUBMIT" out of the viewport.

We are now unforked and we run flutter's own tests.


Pass zerolog Fields as Sentry event additional data

Hi!
There is a helper function called Fields in the zerolog library that helps to enrich the log information while keeping the error message unique.
On the other side, the sentry accepts a map as the additional data of an event.
As far as I checked, the extra fields other than zerolog.MessageFieldName and zerolog.ErrorFieldName are ignored. We can set those fields as the keys of Extra property of the sentry event.
I'll try the PR, any suggestion is appreciated!
Thanks

Hi, merged your PR
We can consider adding Option to whitelist extra fields if we don't want to see them all in Sentry
It can be done later i guess


Add validation error in an autoform plugin.

I'm having trouble adding a validation error to a field on submit.  I've tried adding an error in a hook, but it doesn't seem to be having any affect.
if( template.afSlingshot.progress() < 100 ){
  console.log( "progress error", template.data.atts["data-schema-key"] );
  this.validationContext.addInvalidKeys([{
    name: template.data.atts["data-schema-key"],
    value: "uploadInProgress"
  }]);
}

I'm seeing simple schema keys are showing as invalid, but I'm not seeing an error presented to the user on the field.


Allow pip extra args for playbooks

In https://review.openstack.org/229542 OSA allows extra args to be passed to the pip install task in the roles. This may be a pattern which rpc-openstack wishes to apply for its own roles.

This is now needed. Seeing upgrades failing without this.

failed: [dcb7e5c2-block1] => (item=python-novaclient) => {"cmd": "/usr/local/bin/pip install python-novaclient", "failed": true, "item": "python-novaclient"}
msg: stdout: Ignoring indexes: https://pypi.python.org/simple
Collecting python-novaclient
  Downloading http://<IP_ADDRESS>:8181/os-releases/11.2.4/python_novaclient-2.23.2-py2.py3-none-any.whl (290kB)
Requirement already up-to-date: oslo.i18n<1.6.0,>=1.5.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: argparse in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: oslo.serialization<1.5.0,>=1.4.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: requests!=2.4.0,>=2.2.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: pbr!=0.7,<1.0,>=0.6 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: oslo.utils<1.5.0,>=1.4.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: iso8601>=0.1.9 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: python-keystoneclient<1.4.0,>=1.2.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: Babel>=1.3 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: six>=1.9.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: PrettyTable<0.8,>=0.7 in /usr/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: simplejson>=2.2.0 in /usr/local/lib/python2.7/dist-packages (from python-novaclient)
Requirement already up-to-date: msgpack-python>=0.4.0 in /usr/local/lib/python2.7/dist-packages (from oslo.serialization<1.5.0,>=1.4.0->python-novaclient)
Requirement already up-to-date: pytz>=2013.6 in /usr/local/lib/python2.7/dist-packages (from oslo.serialization<1.5.0,>=1.4.0->python-novaclient)
Requirement already up-to-date: pip in /usr/local/lib/python2.7/dist-packages (from pbr!=0.7,<1.0,>=0.6->python-novaclient)
Collecting netaddr<=0.7.13,>=0.7.12 (from oslo.utils<1.5.0,>=1.4.0->python-novaclient)

:stderr:   Could not find a version that satisfies the requirement netaddr<=0.7.13,>=0.7.12 (from oslo.utils<1.5.0,>=1.4.0->python-novaclient) (from versions: 0.7.18)
No matching distribution found for netaddr<=0.7.13,>=0.7.12 (from oslo.utils<1.5.0,>=1.4.0->python-novaclient)

I believe this was fixed with #549


feat: RPC - starknet_getBlockWithTxHashes

Get block information with transaction hashes given the block id

Hey Abdel, can i take this one?

Hey Abdel, can i take this one?

Sure, assigned to you


Rename conpype to pipeline-dsl

This PR changes every occurrence of conpype to pipeline-dsl (or pipeline_dsl where needed).
I didn't change the files concourse/pipeline.py and docs/tech-session.md because I wasn't sure if we still need them.
We already have a story for the new pipeline and the tech-session is already completed and uses internal repos.

The files concourse/pipeline.py and doc/tech-session.md still contain some references to conpype.
Intentionally?

@phil9909 I think we can delete at least the doc/tech-session.md because it has references to internal repos and I think we don't need it anymore. I'm not sure what we should do with the concourse/pipeline.py. At the moment it uses conpye but we already have a story to build a pipeline for pipeline-dsl and maybe we can reuse it and more or less only rename everything in it.
What do you think?

Agree


featherpad: 1.3.0 -> 1.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tsujan/FeatherPad/releases.
meta.description for featherpad is: "Lightweight Qt5 Plain-Text Editor for Linux"
meta.homepage for featherpad is: "https://github.com/tsujan/FeatherPad"
meta.changelog for featherpad is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.1 with grep in /nix/store/4sknbnz93wgbcs7zrw5nc5c3qvyz54nl-featherpad-1.3.1
found 1.3.1 in filename of file in /nix/store/4sknbnz93wgbcs7zrw5nc5c3qvyz54nl-featherpad-1.3.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
featherpad

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4sknbnz93wgbcs7zrw5nc5c3qvyz54nl-featherpad-1.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A featherpad https://github.com/r-ryantm/nixpkgs/archive/5eb0a6c22f495d0e4419fd4e9db89c95c32eeb4b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4sknbnz93wgbcs7zrw5nc5c3qvyz54nl-featherpad-1.3.1
ls -la /nix/store/4sknbnz93wgbcs7zrw5nc5c3qvyz54nl-featherpad-1.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

featherpad

Maintainer pings
cc @flosse for testing.

@ofborg eval

@ofborg eval

Result of nixpkgs-review pr 185224 run on x86_64-linux 1

1 package built:

featherpad

@flosse You could add dbus as an additional dependency for Linux systems. According to the release notes, the new version makes use of it and is more performant


Feature/upload

Queue pending uploads by saving them locally for future processing

Unit tests need updated to reflect new queue/upload flow.

IMO, it's hard to follow the logic of the UploadManager, which is making it difficult to truly review.  The iOS version, SBBUploadManager, is much easier to understand since it has detailed documentation, and specifically deals with all success / http error code responses.  I'd suggest adding detailed comments to your code before I can approve, using iOS as a reference.

The code is a lot easier to follow now, thank you for adding all the documentation and re-organizing so that is more readable.  I still have some issues from my comments, but I was able to understand everything fully.


[C++][Parquet] Fix crashes on invalid input (OSS-Fuzz)

Fix more issues found by OSS-Fuzz.
Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=apitrou) / @pitrou
PRs and other links:

GitHub Pull Request #26
GitHub Pull Request #6848

Note: This issue was originally created as PARQUET-1835. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 6848
https://github.com/apache/arrow/pull/6848


Global Search - Numerical Filter, slider minimum and maximum values are not stable

Describe the bug
The slider filter gets reset when closing then reopening column filter.
Steps to reproduce

I open Global Search
I select datasets of type 'Neuron Density'
I open the 'Neuron Density' column filter, the slider is set to the following extreme values:
minimum: 1900 and maximum to 272400.
I change the maximum using the slider to 99280. The data refreshes correctly in the background.
I close the column filter, then re-open it again. The slider range is still the same. So far so good.
I change the maximum slider value again, now to something higher: 210185. The data refreshes correctly in the background.
I close the column filter, then re-open it again. The maximum value in the slider it now set to: 100000, a value I haven't set.
It appears something worse happens with the minimum value. In that case both the minimum and the maximum get set to 100000 when closing and reopening the column filter.

Expected behaviour: when a user sets the minimum or maximum value using the slider or directly in the corresponding fields, these values should be maintained, unless the user resets search.

Hey team! Please add your planning poker estimate with ZenHub @bogdanromanx @imsdu @samuel-kerrien @smitfire

Please add your planning poker estimate with ZenHub @nicwells


compatibility with dask

Is there any efforts on making keras compatible with dask? Currently dask can not serialize any function that contains a keras model. Dask works fine with Tensorflow.
This has forced me out of keras in favor of building tensorflow.

I hope we'll get an answer soon.. I'm running into the same problem.

I guess this is related to this PR?
https://github.com/keras-team/keras/pull/10483


Update contributors.json

Issue 08

Description

Let's keep contributors.json sorted in ascending order by GitHub user name
just updated in the order


Add a short tutoral about sphinx-intl

I'm new to sphinx-intl, this is how I understood how it works.
I'm open for any suggestions. :)

Related to https://github.com/fortran-lang/fpm-docs/issues/5


can create AppImage

Added feature to also create appimage when building desktop app for dogehouse for linux distros and added the required packages to the README.md file in baklava for building the AppImage.

Should I change something or should I keep it as it is for now?

Should I change something or should I keep it as it is for now?

Yeah, this looks good. I've not got access to my Linux device rn, but I assume you've tested it

Closes #1283

Should I change something or should I keep it as it is for now?

Yeah, this looks good. I've not got access to my Linux device rn, but I assume you've tested it

Yep, I have tested it!

iohook gives an error when trying to run appimage
 load_input_helper [1918]: Using XFree86 keyboard layout.
load_input_helper [1920]: XKB support is required to accurately determine keyboard characters!
/tmp/.mount_DogeHorzX8ro/dogehouse: symbol lookup error: /tmp/.mount_DogeHorzX8ro/resources/app.asar.unpacked/node_modules/iohook/builds/electron-v85-linux-x64/build/Release/uiohook.so: undefined symbol: xkb_x11_get_core_keyboard_device_id

It would be great if someone can help me on this.

iohook gives an error when trying to run appimage
 load_input_helper [1918]: Using XFree86 keyboard layout.
load_input_helper [1920]: XKB support is required to accurately determine keyboard characters!
/tmp/.mount_DogeHorzX8ro/dogehouse: symbol lookup error: /tmp/.mount_DogeHorzX8ro/resources/app.asar.unpacked/node_modules/iohook/builds/electron-v85-linux-x64/build/Release/uiohook.so: undefined symbol: xkb_x11_get_core_keyboard_device_id

It would be great if someone can help me on this.

This is a known issue on Linux (#1112) and occurs on all Linux builds.
We are hoping to fix this soon

@amitojsingh366 maybe a temporary fix where we disable iohooks for linux? most of the keybindings work without is so?

@TheOtterlord i thought of that but it seems impossible as it will be included in the package (electron-builder takes the effort to build the dependencies natively) so we will have to remove it from everything. Also even if it being packaged isn't a problem its not like we can conditionally import it only on mac and windows. and afaik if it gets imported it will ask for keyboard access causing the issue...

Looks fine tho you could add a script for building the AppImage seperately because it won't build like this at least i don't think so.

If we install the required packages which get installed when we do npm install, and then runnpm run compile && electron-builder --linux, it then creates .AppImage and .deb file in the build folder. And this command is already in package.json.

I will fix the conflicts in some time

Ok cool.

And please fix the conflicts quickly before it is merged.

I advise you to copy the package-lock in the current baklava package-lock and then paste it in your file.

Can anyone help me solve the conficts please?
As @yummyweb  said to copy the baklava package-lock, I did that and tweaked package.json for appimage but it still shows conflicts.

whats ur discord? i can help u on discord @genzyy

Can anyone help me solve the conficts please?
As @yummyweb said to copy the baklava package-lock, I did that and tweaked package.json for appimage but it still shows conflicts.

Ahhh conflicts...
@genzyy  Do these steps:

Commit your changes
Make sure you have ben's repo set as a upstream (or any other thing u like) remote origin
git pull -r upstream staging
It will tell you a few file names after that command. Go in those files and fix your conflicts
do git rebase --continue (sometimes needed, sometimes not)
Commit your changes
Push to your fork

Please check this PR#1476.
I made a new pull request so to resolve the conflicts.
If its fine, can I close this PR?

@genzyy if you made new pr ill be closing this


Include missing dependency in TestEnvironment sample code

Summary
The Sample code for using a custom environment in testEnvironment doesn't show where the NodeEnvironment is coming from. This PR includes this missing dependency.
Test plan
Using jest@test with similar sample code resulted in this error message:
ReferenceError: NodeEnvironment is not defined.
Including jest-environment-node@test solved the issue and using a custom environment worked as expected.

Codecov Report

Merging #4908 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4908   +/-   ##
=======================================
  Coverage   59.77%   59.77%
=======================================
  Files         195      195
  Lines        6535     6535
  Branches        4        4
=======================================
  Hits         3906     3906
  Misses       2629     2629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc5b53...9490f3c. Read the comment docs.

Thanks for clarifying the docs


SVG is not being displayed

When I'm trying to show an svg file from a URL, nothing get's displayed and I get this error:
ERROR TypeError: ___WEBPACK_IMPORTED_MODULE_0__.fromUrl(...).then is not a function
Calling fromUrl in the ts file, I get this error
ERROR TypeError: (0 , _sergeymell_nativescript_svg__WEBPACK_IMPORTED_MODULE_1__.fromUrl)(...).then is not a function
when I use .then:
fromUrl(URL).then(res => {       console.log(res);   });
Console logging the fromURL, without the .then, it prints an epmty object {}

Closed via #20


Cleanup unused control blocks

This is part of https://github.com/openscd/open-scd/issues/290#issue-964622251 and deals with the initial request.
It is the second of at least three discrete panels for the Cleanup editor and resolves:

ReportControl with no or invalid datSet
LogControl with no or invalid datSet
GSEControl with no or invalid datSet
SampledValueControl with no or invalid datSet

Bearing in mind that for ReportControl having no or an invalid datSet may be fine in an ICD file or if datasets are dynamically allocated.
What I did:

Add to Cleanup editor a new section: "Control Blocks with a missing or invalid dataset" which covers GSEControl, LogControl, ReportControl and SampledValueControl (why did the standard not make this SVControl?!)
Provide the optional ability to remove SMV/GSE addresses at the same time (as a default).
The goal is that each atomic operation should if possible result in a conforming file that can be validated (?hmmm... there are problems here but this margin is too small to explain them)
Provide the ability to edit ReportControl, SMVControl and GSEControl elements from each list item.
Provide a caution/warning icon if a GSEControl or SampledValueControl is mapped to an address in Communication > ConnectedAP SCL section
Made this editor more responsive for small form factor devices or very large screens using flex.
In particular, flex made it easier to ensure that the rows are the same height - I think this gives the best "organisation" for the different cleanup functions.

Unsolved:

My CSS-fu is weak but is weaker with CSS Grid so we're using flex now. I would prefer the checkbox above the button on small screens but have struggled to make flex do my bidding for all form factors.
I am not sure how to eliminate the scrollbars associated with the filtered-list. They shouldn't be there and yet they are... :question:
I think this is due to a mwc-ripple element (from the Firefox scroll button) but I am not sure how to diagnose further.
I thought about using a WizardCheckBox for the bottom checkbox but initialising to a checked item and the ability to disable it weren't there. Perhaps I just didn't understand them. Things which were @state I thought should be @property. Conscious that I understand almost nothing I did not let this hold me up but I can go back to it on request... :confused:
For removing the relevant sections in the Communication > ConnectedAP section, Figure 22 of IEC 61850-6 Ed 2.1 shows a link between tAddress and tControlBlock. As far as I can tell, this is an error :bug: or at least I can't see where those semantics are defined.

Things I'm still working on:

Tests
Seeing if my flex and CSS have too much cruft
Contemplating form and style :necktie:

As always, any reviews and comments are gratefully accepted.
(FWIW after this the templates section and deal with:

LNodes that are invalid reference
LNodeType, DOType, DAType and EnumType that are not referenced)

I think the scrollbars caused by the ripple is similar to this issue and may be caused by improper semantics or using elements in a way that material-web does not like

Looks promising. Thank you for the contribution. I have only one UI remark: The elements Ropert, GSEControl and SampledValuesControl do look very alike in the list. May the icons we have for those might be usefull? Or having three seperate lists?

Looks promising. Thank you for the contribution. I have only one UI remark: The elements Ropert, GSEControl and SampledValuesControl do look very alike in the list. May the icons we have for those might be usefull? Or having three seperate lists?

Thanks :wink:
I need to let it gestate for a little and then I can make some more improvements.

I recall that you can filter by the control block type in the list because of the marvellous filter and the identity function.
I feel like three (four if we include LogControl) lists is too much here when the function performed is identical.
I'd be happy to add the icons to each element. I think you mean these ones:

I guess another option is to have a set of tick boxes or radio buttons up the top to filter on the control block type?
I'll add the icons first and then let's see what we think. Since in most other places in the UI we expect the user to search with the filter (e.g. in the unreferenced datasets for manufacturer, device type or device name) I think we should reinforce that pattern. It also keeps the UI uncluttered.

I like the fourth point. We have actually a very nice code example with the log how this filtering can be done with CSS. Also, a good learning experience - it was for me !!!

To the SCL related question above:
Be careful as the name tControlBlock is missleading. This is a complex type purely used in the Communication section. You are mixing it with tConntrolWithTriggerOpt and tControl that are complex types used to define commons of control blocks in the IED section

The elements Ropert, GSEControl and SampledValuesControl do look very alike in the list. May the icons we have for those might be usefull? Or having three seperate lists?

I like the fourth point. We have actually a very nice code example with the log how this filtering can be done with CSS. Also, a good learning experience - it was for me !!!

Thanks for your feedback. :+1:
I have mocked up an interface as I think you suggested:

For the icon to exist the checkboxes must return to the right. OK, I'll choose a max-width of about 700px to prevent visual drifting.
I am having a small battle with the CSS to the filtering but I hope to soon be victorious. The purple is selected in the picture above.
I think the existing log interface is a little buggy. Partly because the colours don't change for me in Chrome as I click on the buttons but I can work around that here. More bothersome is that sometimes the "hover shadow" doesn't leave when the mouse cursor goes away from the button. I may try to figure this out.

To the SCL related question above:
Be careful as the name tControlBlock is missleading. This is a complex type purely used in the Communication section. You are mixing it with tConntrolWithTriggerOpt and tControl that are complex types used to define commons of control blocks in the IED section

OK. My line of thought is that following this diagram I expected to find a definition of tAddress which contained or referenced tControlBlock which I think must have tCBName and yet it does not.
Incidentally, on that topic should this function also be removing the items in the red square in the picture below if the tick box at the bottom is checked?

In which case the tick box would say: "Remove dependent elements" or similar. WDYT. Are there other elements we should consider?
I currently think the default action, even in the cleanup should be to result in a conforming file which means if the following reference the control block they should be removed:

tServiceSettings
tReportSettings
tGSESettings
tSMVSettings

Should this also include relevant ExtRef elements in the Inputs section?
Hmm... I think I need to do some refactoring so this won't be ready for code review for a little while yet.

I currently think the default action, even in the cleanup should be to result in a conforming file which means if the following reference the control block they should be removed:

tServiceSettings

tReportSettings

tGSESettings

tSMVSettings

Should this also include relevant ExtRef elements in the Inputs section?

Interestingly, removeReportControlAction in the Wizard reportcontrol.ts does not do any of this either.
Perhaps it doesn't need to? Perhaps "undefined references" should be its own stage of cleanup/validation.
While a file may pass schema validation without this it seems messy to me.

Hi @danyill,
you got it right, we do not check everything when adding, editing and removing things. This is why I am so careful to not call it a system configuration tool. OpenSCD is at this time and stage an incomplete SCL editor. We are heading towards the goal to become a complete SCL editor, which I think can be done in a couple of months. There are two things we decided to do it like that. 1. There are usecase where global validity checks are not needed, or in other works were a pure SCL editor makes sence to have already. 2. I did not have confidence/knowledge at the beginning to do all the needed checks. Those checks I know not need to be installed globally so they are usable by all plugin authors. If you want to see some first things we check globally have a look at Editing, where we check duplicate name attribute within the same parent and for global unique id attributes.
As the plugin author, you can decide how you want to deliver the Cleanup editor. If you want to make it complete from the beginning, I can offer you to add some IEC 61850 requirements on the issues you are working on. For me, it is approvable if you don't violate the schema.
Best regards,
Jakob

Thank you for this feedback.

I have now finished the UI work associated with the feedback above (icons and filters). I hope you like it!

I have refactored each cleanup into a separate file (possibly introducing regressions or cruft particularly for the CSS)

I would be grateful for a quick usability review to see how the filters work/feel with the checklist. The test/testfiles/cleanup.scd should give a flavour. For a more difficult case, I'm using this:
IOP_2019_HV_v9_ed2.1.scd.zip
I think the UI is more interesting and better (but also more complex). The CSS filtering is neat.
I am now too close to it to understand whether it is easy to use or clean or intuitive.

Thank you for this feedback.
1. I have now finished the UI work associated with the feedback above (icons and filters). I hope you like it!

2. I have refactored each cleanup into a separate file (possibly introducing regressions or cruft particularly for the CSS)

3. I would be grateful for a quick usability review to see how the filters work/feel with the checklist (in the particular the check all button). The `test/testfiles/cleanup.scd` should give a flavour. For a more difficult case, I'm using this:
   [IOP_2019_HV_v9_ed2.1.scd.zip](https://github.com/openscd/open-scd/files/8337160/IOP_2019_HV_v9_ed2.1.scd.zip)
   I think the UI is more interesting and better (but also more complex). The CSS filtering is neat.
   I am now too close to it to understand whether it is easy to use or clean or intuitive.

Hi @danyill,
I had a look at the UI and like it a lot. The buttons work very intuitively, and you would get my approval on this already. I had an idea how to solve the discussion with dynamic reporting: why not filter our report control blocks per default. I think this way the tool would signalize that removing those are not very common.
Furthermore, I had a first glimpse at the code and this is looking promising too! Isn't it crazy how performant the CSS filtering works! This stuff is great, unfortunately harder to test as well. We need visual regression test at the end.
What do you think can I start with code review? Or do you want to add/edit/remove something first?

The elements Ropert, GSEControl and SampledValuesControl do look very alike in the list. May the icons we have for those might be usefull? Or having three seperate lists?

I like the fourth point. We have actually a very nice code example with the log how this filtering can be done with CSS. Also, a good learning experience - it was for me !!!

Thanks for your feedback. 👍
I have mocked up an interface as I think you suggested:

1. For the icon to exist the checkboxes must return to the right. OK, I'll choose a max-width of about 700px to prevent visual drifting.

2. I am having a small battle with the CSS to the filtering but I hope to soon be victorious. The purple is selected in the picture above.

3. I think the existing log interface is a little buggy. Partly because the colours don't change for me in Chrome as I click on the buttons but I can work around that here. More bothersome is that _sometimes_ the "hover shadow" doesn't leave when the mouse cursor goes away from the button. I may try to figure this out.

To the SCL related question above:
Be careful as the name tControlBlock is missleading. This is a complex type purely used in the Communication section. You are mixing it with tConntrolWithTriggerOpt and tControl that are complex types used to define commons of control blocks in the IED section

OK. My line of thought is that following this diagram I expected to find a definition of tAddress which contained or referenced tControlBlock which I think must have tCBName and yet it does not.
Incidentally, on that topic should this function also be removing the items in the red square in the picture below if the tick box at the bottom is checked?

In which case the tick box would say: "Remove dependent elements" or similar. WDYT. Are there other elements we should consider?
I currently think the default action, even in the cleanup should be to result in a conforming file which means if the following reference the control block they should be removed:
* `tServiceSettings`

* `tReportSettings`

* `tGSESettings`

* `tSMVSettings`

Should this also include relevant ExtRef elements in the Inputs section?
Hmm... I think I need to do some refactoring so this won't be ready for code review for a little while yet.

For this feature I would should as a minimum consider the followings:

Removing DataSet: nothing as there cannot be any valid ExtRef to a DataSet that is not used by a control block
Removing GOOSE/SMV: as a minimum, remove the GSE and the SMV element in the Communication section.
Removing ReportControl: as a minimum nothing

We do not need to remove anything from the Service section. The settings there tell you what you can and cannot do in the IED the Service section resides in.

A SCT should in addition consider the ReportSettings, LogSettings, GSESettings and SMVSettings. If any of the defined attributes, there is Fix !! which is also the default!! the SCT may not be able to remove those from the SCL file.

I had a look at the UI and like it a lot. The buttons work very intuitively, and you would get my approval on this already. I had an idea how to solve the discussion with dynamic reporting: why not filter our report control blocks per default. I think this way the tool would signalize that removing those are not very common.

Thank you.
That is a good idea :bulb: It shall be as you wish. In fact it already is :fairy_man:

Furthermore, I had a first glimpse at the code and this is looking promising too! Isn't it crazy how performant the CSS filtering works! This stuff is great, unfortunately harder to test as well. We need visual regression test at the end.

It is quite performant although I have to iterate over all items and add them to a class. Hmmm there may be an easier way to do that all in one go?
I think it may be beyond my ability to add visual tests at this time at least as part of this PR.

What do you think can I start with code review? Or do you want to add/edit/remove something first?

I am sorry for the delay :hourglass_flowing_sand:, I am but a :snail: who dreams of being a :rabbit2:
What I want to do:

split apart the cleanup containers in the code (done now)
make the tests separate (done now)
add some tests for this new set of control block cleanup (this weekend)
leave it two days for contemplation

but if you want to review, at any time I will be most pleased :pray: . I think it is now in a half reasonable state...
I've done the first two and pushed them now so at least it is not all horribly munged into one file. I think that will improve review and maintenance.

For this feature I would should as a minimum consider the followings:
Removing DataSet: nothing as there cannot be any valid ExtRef to a DataSet that is not used by a control block
Removing GOOSE/SMV: as a minimum, remove the GSE and the SMV element in the Communication section.
Removing ReportControl: as a minimum nothing

We are in luck, I think that is what I have done :tada:
Incidentally:

I do not know what is happening with tests.
CI on Github sometimes takes more than an hour
The snapshots are also doing something a bit odd, SMV and subscription sld-drawing seem to refresh even though I'm very confident I haven't touched these...

Things not done:

When we have checks on the checklist items, they disappear if we click on the "detail view" icon to take a peek which is not great (and as a user would enrage me :rage:). I played with some localStorage to try and find a workaround but was not successful so far.

I haven't written tests for the "detail view" icon associated with each list item for either the dataset or control block cleaning.

I haven't written tests for the enable and disable of the Remove Address button, I think this is mainly cosmetic.

f

On a global scale, this is the same issue as the performance issues we discuss at the moment. We need to have a closer look, when do we re-render what. As a dirty quick solution, you could use a global variable. An object, probably to save the control block identity as the object key and the selected status as the value of the object.

👍 Thank you for this feedback, I hope to respond and improve over the weekend.

As a dirty quick solution, you could use a global variable. An object, probably to save the control block identity as the object key and the selected status as the value of the object.

I think we'll skip the dirty quick solution for now or address this in a separate issue/PR.


Refactor the negative binomial code

Closes #148
Use the code Yerdos was using in the cellarium-gpt branch here
https://github.com/cellarium-ai/cellarium-ml/blob/fc8a2d079222daee6b7222f952e43c44e66ca931/cellarium/ml/models/cellarium_gpt.py#L27-L81
This should make it easy to have the two models use the same code.

I added a helper mixin to log learning rate here as well

I modified the scvi_pbmc_config.yaml
to get it to run well for me.  It would not run as it was.

I added a demo scvi notebook that shows the UMAPs before and after.
Running this notebook could be a way to benchmark future code changes.
This NB distribution produces these results, which I think are probably the same as before:
Before scVI

After scVI


Update a record log

It is possible to update a record log instead of making a new insert.

Hi! Thanks for getting in touch.
Modifying log data once it was written is not possible. This would contradict the basic concept of logging, where log data is only created but never modified again by the logging system.
But maybe there is another way to achieve what you need to do. What is the use case you would need this for?

Hi, thanks for the reply.
The use case I am looking for is for example when you want to log a procedure that iterates through a dataset, list of files etc., see it as a partial log. This because i've a console that read in ~ real time the data in the table.

Can you post some sample code?


Re-enable hledger packages

As noted on #2024, I've published hledger-lib/hledger/hledger-ui/hledger-web-1.0.1, which allow the newer megaparsec.
As I understand it the "brick-0.11 is out of bounds" message is not a blocker and can be ignored, since brick is not in recent snapshots and I specify it as an extra dep.

@simonmichael I added a stackage upper bound for brick < 0.9 (it would of course be nice if you could use the latest), and disabled hledger-web because I don't see v1.0.1 on hackage for that one. Kindly open another PR for that one once it's published; I would've left this PR open but I wanted to get at least this much building for the next nightly.

Thanks! Doh, I have opened #2026 for hledger-web.

@DanBurton I have released hledger-ui-1.0.2 which uses the latest brick.


CI: unit test panic in master

Build link:  https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/1375/execution/node/58/log/?consoleFull
Notable output:
17:41:33 ... Panic: runtime error: invalid memory address or nil pointer dereference (PC=0xF515CA)
17:41:33
17:41:33 /usr/local/go/src/runtime/panic.go:502
17:41:33   in gopanic
17:41:33 /usr/local/go/src/runtime/panic.go:63
17:41:33   in panicmem
17:41:33 /usr/local/go/src/runtime/signal_unix.go:388
17:41:33   in sigpanic
17:41:33 /go/src/github.com/cilium/cilium/pkg/kvstore/store/store.go:275
17:41:33   in SharedStore.UpdateLocalKey
17:41:33 /go/src/github.com/cilium/cilium/pkg/kvstore/store/store.go:284
17:41:33   in SharedStore.UpdateLocalKeySync
17:41:33 /go/src/github.com/cilium/cilium/pkg/node/local_node.go:76
17:41:33   in NotifyLocalNodeUpdated
17:41:33 daemon.go:1367
17:41:33   in NewDaemon
17:41:33 daemon_test.go:105
17:41:33   in DaemonSuite.SetUpTest
17:41:33 daemon_test.go:159
17:41:33   in DaemonEtcdSuite.SetUpTest
17:41:33 /usr/local/go/src/reflect/value.go:308
17:41:33   in Value.Call
17:41:33 /usr/local/go/src/runtime/asm_amd64.s:2361
17:41:33   in goexit
17:41:33 PANIC: daemon_test.go:157: DaemonEtcdSuite.SetUpTest
17:41:33
17:41:33 START

The commit merged to master which triggered this build is :
https://github.com/cilium/cilium/commit/4a7d484af44b6e68f4e16dd9587704e449d9648c


[SDL 0175] Updating DOP value range for GPS notification

Proposal: Updating DOP value range for GPS notification

This proposal is to update the range and make these fields non mandatory for DOP values in GPS notification for GetVehicleData and OnVehicleData RPCs.

Review: https://github.com/smartdevicelink/sdl_evolution/issues/510
Steering Committee Decision:

The Steering Committee voted to accept this proposal with revisions.  The revision will be to include maxValue as described in this comment from the author.

The proposal .md was updated on July 2, 2018 to include the agreed upon revisions.

This is being added by Ford in this PR: https://github.com/smartdevicelink/sdl_android/pull/712

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal Revise SDL-0175 - Updating DOP value range for GPS notification.  Implementation will need to be revised to remove shifted parameter from  GPSData, mark mandatory=true for parameterslongitudeDegrees and latitudeDegrees, in both mobile api and hmi api, and note that all other GPSData parameters are mandatory=false.

Included with #712


Adding destroyCard() function to swing-card-component

@mashhoodr I hope you're ok to merge this? This is because the other event listeners on swing-stack-component are listening for GUI events and destroyCard() is more like an application related thing that you may or may not want to happen. Hope this makes sense. I have tested and it works for me. No longer getting build up of cards on the stack.

@Sparkomatic I will review this and let you know

@Sparkomatic Im happy with the updated code. Im not sure about the versioning thing - I feel the new version on npm was published by mistake (or I could be wrong). What do you think we should do here?

Whatever the current version is the correct version. Whats the concern?

@gajus there is a mismatch between latest release on Github and NPM -
https://github.com/gajus/swing/releases => shows 4.3
https://www.npmjs.com/package/swing => show 3.1
So the current version is 3.1?

@Sparkomatic merged, deploying to npm now. Thanks for your contribution!


CMake error when using SDK built with -DBUILD_SHARED_LIBS=OFF

Describe the bug
I am getting a CMake error when trying to use the 1.11 line of the SDK. I did not get this error when using both 1.9 and 1.10.
Expected Behavior
Expected behaviour is no CMake error.
Current Behavior
The error appears during CMake configure step:
CMake Error at CMakeLists.txt:5 (add_executable):
  Target "s3sample" links to target "ZLIB::ZLIB" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?

Reproduction Steps
I first stumbled upon the problem on my project that included aws-sdk-cpp, aws-lambda-cpp and several other dependencies, but was also able to reproduce it on the sample program from this Wiki page: https://github.com/aws/aws-sdk-cpp/wiki/Building-the-SDK-from-source-on-EC2
Steps to reproduce:

clone the aws-sdk-cpp repo

git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp.git
cd aws-sdk-cpp
git checkout --recurse-submodules 1.11.138

build and install the SDK

mkdir build-sdk
cd build-sdk
cmake ../aws-sdk-cpp -D BUILD_ONLY=core -D CMAKE_BUILD_TYPE=RelWithDebInfo -D BUILD_SHARED_LIBS=OFF -D CMAKE_INSTALL_PREFIX=~/aws-sdk-1.11.138
make
make install

CMake configure the app

mkdir build
cd build
cmake .. -D CMAKE_BUILD_TYPE=Release -D CMAKE_PREFIX_PATH=~/aws-sdk-1.11.138

Possible Solution
No response
Additional Information/Context
It seems that using static libraries adds linking the ZLIB:ZLIB target, which then cannot be recognised. Please search for ZLIB:ZLIB in the installed lib/cmake/aws-sdk-cpp-core/aws-sdk-cpp-core-targets.cmake file.
AWS CPP SDK version used
1.11.70, 1.11.76, 1.11.138
Compiler and Version used
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Operating System and version
Ubuntu 22.04 running on WSL2

It seems the problem is introduced in commit e3db71c, as I do not get the above error when using 1.11.33 and get it when using 1.11.34.

Do you have zlib installed? You can install this with:
sudo apt install zlib1g-dev

Do you have zlib installed? You can install this with:
sudo apt install zlib1g-dev

Yes, it's installed. But just to confirm:
> sudo apt install zlib1g-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
zlib1g-dev is already the newest version (1:1.2.11.dfsg-2ubuntu9.2).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

I am hitting the same issue on Mac OS X without -DBUILD_SHARED_LIBS=OFF.  When I build it as a standalone project it builds fine.  When I include it as a dependency for another project then I get exactly this error
I'm adding as an external project like so:
ExternalProject_Add(libawscpp-download
    GIT_REPOSITORY    https://github.com/aws/aws-sdk-cpp.git
    GIT_TAG           1.11.157
    LIST_SEPARATOR    "|"
    CMAKE_ARGS       -DBUILD_SHARED_LIBS=OFF
                     -DBUILD_ONLY=kinesis-video-media|kinesis-video-webrtc-storage
    BUILD_ALWAYS      TRUE
    TEST_COMMAND      ""
)

And below is the error:
-- Try finding aws-cpp-sdk-core
-- Found aws-cpp-sdk-core
-- Try finding aws-cpp-sdk-kinesis-video-webrtc-storage
-- Found aws-cpp-sdk-kinesis-video-webrtc-storage
-- Try finding aws-cpp-sdk-kinesis-video-media
-- Found aws-cpp-sdk-kinesis-video-media
-- Configuring done (673.9s)
CMake Error at /usr/local/lib/cmake/aws-cpp-sdk-core/aws-cpp-sdk-core-targets.cmake:61 (set_target_properties):
  The link interface of target "aws-cpp-sdk-core" contains:

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /usr/local/lib/cmake/aws-cpp-sdk-core/aws-cpp-sdk-core-config.cmake:19 (include)
  /usr/local/lib/cmake/AWSSDK/AWSSDKConfig.cmake:310 (find_package)
  tst/CMakeLists.txt:14 (find_package)

-- Generating done (0.1s)

Some other CMake details:
-- TARGET_ARCH not specified; inferring host OS to be platform compilation target
-- Building AWS libraries as static objects
-- Building project version: 1.11.157
-- The CXX compiler identification is AppleClang <IP_ADDRESS>60021
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PythonInterp: /usr/local/bin/python3.9 (found version "3.9.16")
-- Found ZLIB: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libz.tbd (found version "1.2.11")
--   Zlib library: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libz.tbd
-- Encryption: CommonCrypto
-- Http client: Curl
-- Found CURL: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libcurl.tbd (found version "7.79.1")
--   Curl include directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include
--   Curl library: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libcurl.tbd
-- AWS CRT C++ 0.23.0
-- The C compiler identification is AppleClang <IP_ADDRESS>60021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done

I do not hit this issue though if I clone the project by itself and build it.

I don't see ExternalProject_Add anywhere in the CMakeLists.txt file. Are you referencing adding the above call to the docs here: https://github.com/aws/aws-sdk-cpp/blob/53a6699f24ad6a6603074fdb630d3c1dc235d3c1/docs/CMake_External_Project.md?plain=1#L10-L18

Exactly yes I'm following that to include as an external project.

Also I can confirm if I simply call:
  find_package(ZLIB REQUIRED)

Right before the CMakeLists.txt which has the ExternalProject_Add it fixes the issue. It would appear there is a bug in the aws sdk CMakeLists.txt that doesn't properly handle the static link case.

It works for me! Thank you.


Tool isn't used even with tool_choice = required

Hello, I'm unable to get the assistant to use the tools. This is how I've added them,
client.addTool(
  {
    name: 'assistant_api',
    description: 'Ask the Assistant API for a response. This API contains the business logic for the assistant.',
    parameters: {
      type: 'string',
      properties: {
        user_message: {
          type: 'string',
          description:
            'Paraphrased text of the user message that was spoken to you. It does not need to be verbatim but should capture the intent of the user message.',
        },
      },
      required: ['user_message'],
    },
  },
  async ({ user_message }: { [key: string]: any }) => {
    const response = await fetch('http://localhost:3000/webhook', {
      method: 'POST',
      headers: {
        'Content-Type': 'application/json',
      },
      body: JSON.stringify({
        sender: 'openai-user',
        message: user_message,
      }),
    });
    const data = await response.json();

    /* concatenate all bot responses */
    const responseText = data.map((item: { text: string }) => item.text).join(' ');
    setUserMessage(user_message);
    setBotMessage(responseText);
    return { text: responseText };
  }
);

// make tool use mandatory
client.updateSession({ tool_choice: 'required' });

Is there also a reason why the tools property within sessionConfig isn't set? It isn't set even in the openai-realtime-console repo that I'm forking here.
sessionConfig: {
    ...
    "tools": [],
    "tool_choice": "required",
   ...
},
tools: {
    "assistant_api": {
        ...
    }
}

When you add tools with .addTool() it populates a this.tools Object:
https://github.com/openai/openai-realtime-api-beta/blob/d7bf27b842638f01c0d07d517d0d8a1b9ce4b63b/lib/client.js#L239
This is used to populate the tools array (you can also set it manually).
Can you verify the session.update call that your client is sending to the server?

@khorwood-openai I do see this.tools is populated and here's the session.update that's sent to the server,
sent: session.update {
  "event_id": "evt_EdAQeu5VKKfAnQ1xo",
  "type": "session.update",
  "session": {
    "modalities": [
      "text",
      "audio"
    ],
    "instructions": "System settings:\nTool use: enabled.\n\nInstructions:\n- You are an interface for a Chatbot API agent responsible for helping test realtime voice capabilities\n- Please make sure to respond with a helpful voice via audio\n- Be kind, helpful, and curteous\n- It is okay to ask the user questions\n- You MUST use the assistant_api tool every time you respond. Use the result of the tool as a guide for your next response\n- Be open to exploration and conversation\n- Remember: this is just for fun and testing!\n\nPersonality:\n- Be upbeat and genuine\n- Try speaking quickly as if excited\n",
    "voice": "alloy",
    "input_audio_format": "pcm16",
    "output_audio_format": "pcm16",
    "input_audio_transcription": {
      "model": "whisper-1"
    },
    "turn_detection": null,
    "tools": [
      {
        "type": "function",
        "name": "assistant_api",
        "description": "Ask the Assistant API for a response. This API contains the business logic for the assistant.",
        "parameters": {
          "type": "string",
          "properties": {
            "user_message": {
              "type": "string",
              "description": "Paraphrased text of the user message that was spoken to you. It does not need to be verbatim but should capture the intent of the user message."
            }
          },
          "required": [
            "user_message"
          ]
        }
      }
    ],
    "tool_choice": "required",
    "temperature": 0.8,
    "max_response_output_tokens": 4096
  }
}

I found the issue, I used parameters.type as "string" instead of an object. Changing it to object I can see the function calls happens, thanks!
    parameters: {
      type: 'string',
      properties: {
        user_message: {


Type 'SignalClient' does not conform to protocol 'WebSocketDelegate'

Hi! I load your project and made something for my server. When I copy/past files WebRTCClient, WebRTC-Bridging-Header, SignalClient, RTCStates, RTCSessionDescription+JSON, RTCIceCandidate+JSON to my project. I have some problems - in SignalClient file
"Type 'SignalClient' does not conform to protocol 'WebSocketDelegate'"
http://joxi.ru/BA0Leg0HJw1zXA
Xcode want to add only
func websocketDidReceiveData(socket: WebSocketClient, data: Data)
But all protocol methods are implemented.
Can you help me please?

Hi, Which version of Starscream are you using? I tested my code and it looks fine with Starscream 3.0.5. Can you try to re-test?

I comment func websocketDidReceiveData(socket: WebSocketClient, data: Data)
in WebSocketDelegate. your project work normal. is this important func?

I don't use websocketDidReceiveData in my demo so you can safely comment it out
By the way, which version of Xcode are you using?

I tested it and I don't get any crash when I don't give permission to use the microphone. I'm sorry but as this project is a demo project it may not be covering all the edge cases properly. I suggest to get support from WebRTC library or Apple forums depending on the crash location.


String print functions are not safe

Neither dSprintf nor dVsprintf pass through the buffer length to the underlying libc function. This essentially means a carefully constructed string passed though to either function can cause a buffer overflow.
In addition dSprintf doesn't call va_end to end the va_list, which depending on the underlying implementation may be bad.
For reference, the offending lines in winStrings.cc are:
bufferSize;
S32 len = vsprintf(buffer, format, args);

and
bufferSize;
S32 len = vsprintf(buffer, format, (char*)arglist);

Similar code is present for unix and osx platforms.

@camporter: That branch looks like a tremendous amount of work just to let it grow stale.  I would love to see you pick it back up and finish it. Let me know if I can help.

Sorry. I am new to github, I didn't realize I had to close it. If you have
quick tip on how to, that would be great, else i will find out.
Thanks for notifying.


Fix botbuilder-dotnet/issues/644 - Choice override on ConfirmPrompt

Make parity with js!
https://github.com/Microsoft/botbuilder-dotnet/issues/644

Build break is due to a failed Translation test, unrelated to this code. All tests for this pass.


Added type annotations

Hi!
This PR solves Missing Type Annotations #7
Please let me know if you have any comments.
I tested with Adafruit Feather RP2040 and the ST7789 display.
Thank you!

Hi @tekktrik ,
Thank you for the comments!
I will have a look to the adafruit_display_text topic. :)
Thank you!


iOS NFC demo compile fails  if not on Simulator

If your issue is for a particular feature (e.g. Camera, Connectivity, Biometric etc), please prefix the issue title with the feature in square brackets, e.g. "[Camera] Crash when image is captured"
Compile error of NFC demo on iOS - not on Simulator
Compiling the NFC demo on iOS Device 64 Development or Application Store, an error occurred.
It builds fine on iOS Simulator
Error messages
[DCC Error] E2597 Id: file not found: /System/Library/Frameworks/CoreNFC.framework/CoreNFC
Please indicate
Delphi Version: 10.4.2
Platform(s) that the issue occurs on (i.e. iOS, Android etc):
iOS
Steps To Reproduce

Load the NFC demo
Select iOS Device 64 bit
Select Application Store of Development
Build all.

You need to import the CoreNFC framework into the iOS SDK, in the Delphi SDK Manager. Please refer to this article