Issues on an armv7 board (RPi)

(I did follow the instructions to generate a debug log, but the output file is mostly empty)
I'm trying to use aurutils to build packages in a chroot on a Raspberry Pi 4, but I encounter a few issues. This is the command line I've been using and its output:
$ aur sync --no-view --no-confirm --chroot --database=aurto aurutils
==> Using [aurto] repository
  -> aurutils: (none) -> 2.3.3-1
==> Retrieving package files
From https://aur.archlinux.org/aurutils
 = [up to date]      master     -> origin/master
install: creating directory '/var/lib/aurbuild/armv7l'
==> Creating install root at /var/lib/aurbuild/armv7l/root
==> Installing packages to /var/lib/aurbuild/armv7l/root
:: Synchronizing package databases...
error: failed retrieving file 'core.db' from mirror.archlinuxarm.org : The requested URL returned error: 404
error: failed to update core (failed to retrieve some files)
error: failed retrieving file 'extra.db' from mirror.archlinuxarm.org : The requested URL returned error: 404
error: failed to update extra (failed to retrieve some files)
error: failed retrieving file 'community.db' from mirror.archlinuxarm.org : The requested URL returned error: 404
error: failed to update community (failed to retrieve some files)
error: failed retrieving file 'multilib.db' from mirror.archlinuxarm.org : The requested URL returned error: 404
error: failed to update multilib (failed to retrieve some files)
 aurto                                                                                1024.0   B  0.00   B/s 00:00 [##########################################################################] 100%
error: failed to synchronize all databases
==> ERROR: Failed to install packages to new root
==> ERROR: Failed to install all packages

I've dug a little bit a this is what I've noticed:

$arch in the mirrorlist seems to be populated with the output of uname -m which, on such a board, gives armv7l - the ArchlinuxARM repository doesn't have that variant though. The Architecture option of my pacman.conf reads armv7h, which does exist on the official mirrors.
Pacman tries to fetch multilib, which doesn't exist on ARM.

Passing --pacman-conf=/etc/pacman.conf does work fine - it solves both the $arch and fetching the multilib repo.
I can't figure which pacman.conf does aurutils uses by default. pacconf gives the correct outputs for both the Architecture field and the multilib (or rather, its absence) repo. Is this the expected behaviour having to pass a pacman.conf?

Please try with the master branch, aur-build/aur-chroot does not use multilib by default there (see https://github.com/AladW/aurutils/pull/655).
uname isn't used for anything but the directory name of chroots (and an i686 hack in aur-sync). aur-chroot does use pacman-extra.conf by default, shipped with devtools, but aur-build/aur-sync use pacman-aur.conf which you have to create by yourself.

Ha that seems to be going much more smoothly using master indeed! Thanks for the quick solution. I'll keep an eye on the 3.0.0 release.


HEADER_SIZE = 80 is stringent at my case

Hello Mr Wolph,
The default 80 bytes, i.e. 80 characters were quite stringent for me in my use case as I had some stl parts with more characters. Would you consider increasing it to 256? I think it would not affect the speed adversely too much.
Cheers
Lazlo

Hi Lazlo,
Do you mean the 80 character header limit for binary files? That's not a performance decision but it's how the standard appears to be defined: https://en.wikipedia.org/wiki/STL_(file_format)#Binary_STL
With the binary format it has to be a fixed amount of characters since the file will be read incorrectly otherwise.
Cheers

Monkeypatching it is fairly easy btw:
from stl import stl
stl.HEADER_SIZE = 256

But your files will be incompatible with most (all?) STL libraries

Ahh ok, I did not know that has to be fixed at binary stls.
But what I wrote still applies to ASCII stls (my use case) and the end of the part name might be stripped off (if the name is longer than 80 - len('solid ') characters).
I need to think about it more after work but i would still suggest some modification at the beginning of the _ascii_reader method that it recovers part names which are more than 74 chars long.
Obviously I monkeypatched it for my use case just as you wrote but others might also have long part names but not willing take some effort to check what is going on.

That's a fair point indeed. The only problem is that not every stream is seekable which makes this a little tricky... I'll have to see if there's a safe solution :)


Display filters in popover menus

Instead of showing filters in a sidebar, where they can get a little long and hard to scroll, let's collapse them into expandable flyout/popover/dropdown/whatever menus, search engine style. This way, users who need to use the filters will have easy access to the relevant filters, but users who just want to get right into the results don't need to bother with them at all.

Other notes:

When/if we have more filter groups than the five shown here, we’ll want to hide the least useful ones under a “More…” mechanism. (See earlier mockups, but we can deal with this later as/when we add filters.)
Can we make filters contextual, depending on the dataset returned? (Maybe as a v2)
Would it help to show number of results for each filter, or does that just add extra noise?
When a list of filters has more than 10 options, we should provide a search and attempt to show the most relevant or useful filters in a separate section at the top of the page (see #9)

Filters with visual design applied:

I've currently hidden the filters because they're a bit of a mess but we'll need to add them back. I can help with the visual design side of things but I'd love some help with the JS/functionality side of things!

Added a functional pass in feature/filter-view, doesn't completely match styles yet (though will look to @sarahmonster to finish the visual side)

I've gone for a slightly unconventional approach but it makes building the link much easier and keeps to minimal javascript.

Hi Brian,
Many thanks for building this so quick - looks good.  I've swapped the test site (https://design.opentexts.world/) to your branch to see it in action.
Do you think it would be possible to tweak this further to allow mutiple facet values to be selected: e.g. Danish or French, rather than just a single facet value? (e.g. http://yonik.com/multi-select-faceting/).
And sorry for the question - it's just not a feature I've used before: what does the addTag and addExclude do which you've added in app/Controllers/Search.php?
Thanks again - much appreciated,
Stuart

Hey Stuart,
This should definitely be possible functionally - it might require some changes to the design from @sarahmonster though, my thoughts:

The "All libraries/languages" button would have distinct interactions as it's the only one that would have to clear any other ticks, it might need to stand out visually
Would we want to have select all/clear all style functionality to make it easier to get to the filter you want?
Is it maybe preferable to move towards an "Apply" button for the filter? It would be quite frustrating to have to pick a language, wait for reload, pick a language until you get the selection you want.

It's possible given all this we'd rather make multi-facet filtering a separate issue and merge this in as a first pass?
And no worries about the question, the addTag and excludeTag are actually doing what's described in the first part ("1. User selects “Blue”) of http://yonik.com/multi-select-faceting/ - we tag the language filter and exclude it from the language facet - otherwise the counts calculated for that facet will be the counts with that filter applied (i.e. for any language other than the one you selected the count is 0 because you've filtered them all out). Just in case we decide to show the total results in the dropdown.

Oh and quick pass on Sarah's note:

When/if we have more filter groups than the five shown here, we’ll want to hide the least useful ones under a “More…” mechanism. (See earlier mockups, but we can deal with this later as/when we add filters.)

Make sense 😄

Can we make filters contextual, depending on the dataset returned? (Maybe as a v2)

What we already had excluded filters with 0 results, that's def worth keeping - I think some of this merges with point 4 (and issue #9)?

Would it help to show number of results for each filter, or does that just add extra noise?

I had a look both with and without when mocking it here, what do you think about doing approximate numbers? Some results already are up to 2,000,000+ at which point the detail loses meaning - so maybe a (2M), (200k), (2k), (200), (2) style badge avoids it being too noisy whilst giving some context about what you can expect when you click on it?

When a list of filters has more than 10 options, we should provide a search and attempt to show the most relevant or useful filters in a separate section at the top of the page (see #9)

Sounds good, lets tackle under #9 - I'm imagining picking out most relevant by percentage of overall results included - say if something like 20% of results match this filter then it's a featured/useful/most relevant filter? but we can discuss under that issue 😁

The "All libraries/languages" button would have distinct interactions as it's the only one that would have to clear any other ticks, it might need to stand out visually

My suspicion is that we should be okay with styling that matches the other filters, but I can put this on my list of "things we can get a check on during testing". (Filters, generally speaking, would be super helpful to test, since there's lots going on with them.)

Would we want to have select all/clear all style functionality to make it easier to get to the filter you want?

Select all: no! If there are cases where we think users would want to "select all", we're better off giving them a single option in the list ("All languages" or "Any time" for instance) and then clearing any other selected filters when the "All [x]" filter option is selected. This way, it becomes just another option in the list, with slightly adjusted behaviour (that matches users' expectations for how such an option would function).
Clear all: let's table this for now, and maybe consider it as an enhancement under #9 (or another follow-on issue) if needed. My first instinct here was "yes! I forgot that!" but then I looked more closely and, for most cases, the "All [x]" option again effectively acts as a "Clear all" function. I think it's possible that we'd need this in the future for specific filters, but I think we'd be best to evaluate the need on a case-by-case basis (and once we've had an opportunity to test the filters a bit more, since we'll be able to tell if it feels like a functionality that's missing.)

Is it maybe preferable to move towards an "Apply" button for the filter? It would be quite frustrating to have to pick a language, wait for reload, pick a language until you get the selection you want.

So! The ideal UX here is probably that selecting a filter would automatically filter the result set shown without a page reload, so the result is more instantaneous. However, I realise that we may be limited here by the technical constraints of the current stack, so we may need to compromise, at least for a first iteration.
If the page needs to reload every time a filter is selected, I do think we'll need an apply button—you're right that the opposite would be a very poor experience.
Here are some updated mockups, showing multiple selections at a time:

Handling searching and other additional functionality as an add-on enhancement (ie, under #9 or a separate issue) sounds like a sensible approach to me. There's a lot of moving pieces with filters and I imagine it'll take a bit of back & forth to get them just right!
I'm a little uncertain myself about showing the number of results in the filters (it may introduce quite a lot of noise, and we want to be sure the signal:noise ratio is optimal) but that may be worth A/B testing to get a sense for how it might work once we have the basic filters built out. Sounds like it might be worth addressing as a follow-up issue once we have the core functionality worked out, and then we can try it to see if it adds value.

Thanks - great discussions!  A few comments from me based on general library search system and facets:

I think numbers are helpful.  For example without them, I have no idea if I will get 2 results or 2million.  This also helps from an 'aerial view' type of approach.  I do a broad search, see the aerial view (e.g. how many results I will get by going down different routes) and then refine my search.  The facets can also help from a sereditptity point of view "Oh, I didn't realise you had ten thousand books in Arabic!".

Clear filter hopefully might be reasonably easy, as it just means dropping that query parameter altogether

Select all - as you say, this is the default option anyway, and is functionally the same as 'clear'.

Thanks!
Stuart

All makes sense, I think Sarah's suggestion of looking over this when iterating makes the most sense but I guess to quickly clarify my concern with what we have just now there are two states that mean the exact same thing.

However the functionality available is very different between them - I think Library is the sort of awkward example where given the option to multi-filter you might be more likely to want to exclude one library than only include one, the steps for which are then to re-tick every library because it's in the first state. That's where the select all and clear all suggestions come from - if you want everything but one so we can keep an eye out for that.
I agree with Stuart on the counts, I've not been interacting with the system much but I do find the ballpark count useful for knowing whether there might be something interesting under a particular filter. I've been doing a similar thing but for Latvian rather than Arabic as my partner is Latvian and it piqued my curiousity. :smile: but I do like a good A/B test.

Just pushed a new one on feature/filter-view - should add support for multiple filters. At this point happy to pass to @sarahmonster to make it stylish 😄


Refactor Docs::Generator source link generation

This refactors how the docs generator generates source links to hosted git providers. All configuration is done via ProjectInfo which is already responsible for name and version properties.
The default behaviour is still to extract the remote tracking branch from the current git checkout and derive the URL pattern from there if it is a known git provider. But there is now also an option --source_url_pattern to configure the URL pattern explicitly, which can be used to point source links to providers not covered by the automatic recognition and also works outside a git repository. --source-refname accompanies that use case and is used to configure the refname in source URL links.
Changes to the generated HTML output are minimal and shouldn't have a perceivable effect. The only visual difference is that the locations in a type's locations list are now ordered. Internal data-id values have changed because they are no longer based on the repository but the configured name.

Can't the project_name and the repository_name be different?
I would expect the former to don't have crystal- -crystal or .cr while the second one does. Does this PR play nice with that?

My idea was that project_name replaces repository_name. I don't hink it makes much sense to have the latter. It was my understanding that it only existed because no alternative was available. Now we have project_name to identify the project, which is much better than the repository name. Shards are identified by name, not by repo.
We could add properties repository_url and homepage_url, though. They could be used to provide links to those relevant locations. I've planned this as one of the following steps, but don't think it's super important because most shards already include these links in the readme.

I have some concerns regarding adding git.sr.ht as a known git provider. Is stated to be in alpha stage in their own site. I would rather leave that out of the PR. That's my only concern.
@RX14 I'm not sure if you aim to review this as per @straight-shoota request.

Would be nice to know what changed since my last review :/

Nothing has changed. I just fixed merge conflicts in project_info.cr and man/crystal.1 due to #9074. It was apply both changes every time.

@bcardiff I don't think sr.ht is a problem. IMO having as much source code providers available as possible is a good thing. I addded all that I have at least some knowledge of how their URLs work.

me too, sr.ht isn't going anywhere


Carry 15457: systemctl enable and start docker

Carry of 15457; fixes the indentation, caused by mixed tabs/spaces.
closes #15457
fixes #15456

ping @moxiegirl

ping @thaJeztah

Oh, sorry, this one slipped my attention. I'll have a look when I'm home; tbh I carried, just to fix the indentation (that's what the previous PR stalled on ;-))

Ping @thaJeztah!

I'll close this one for now; docs need more checks for systemd related changes and I needed to do some testing :)


Update jsonpatch.md

just a typo i guess.

Isn't this the JSONPatch:
  {
    "op": "move",
    "from": "/orders/1",
    "path": "/orders/0"
  }

The current description looks correct. Why do you think this needs to be changed?

Closing this in favor of the other PR.


Possible fix for Issue #156

Possible fix for the field access issues in #156.
Not sure if this resolves everything but it should help.
Should merge after #192 to avoid conflicting

I am all in favor of incremental progress, so whenever you feel we can cover one more case and add one more test let's merge it and move forward from it.
Code looks good. I think following yours and other patches we should probably do a release soon, switching to JavaParser 3.2.0 in the meantime.
Thanks again!

@ftomassetti Yes it's been a while since the last release. Moving to 3.2.0 had no effects on the codebase so all that's left is to release :)


Stuck at introspect

Hello,upon importing graphQL into Unity,i got error regarding this line

" await request.SendWebRequest(); " in HttpHandler.cs
It was UnityWebRequestAsyncOperation doesn't have await.So i change the line to make it have like so
"await  request.SendWebRequest(); " => " await Task.Run(()=>request.SendWebRequest()); "
And the error stop

After that,i check out the demo,hitting the introspect link on both pokemon and user.Both get stuck on " API is being introspect, please wait"
I even test it on a working project link and the bug remain
What should I do ?

Default UnityWebRequest does not implement GetAwaiter()
You need an extension for that. You can try
public class UnityWebRequestAwaiter : INotifyCompletion
{
	private UnityWebRequestAsyncOperation asyncOp;
	private Action continuation;

	public UnityWebRequestAwaiter(UnityWebRequestAsyncOperation asyncOp)
	{
		this.asyncOp = asyncOp;
		asyncOp.completed += OnRequestCompleted;
	}

	public bool IsCompleted { get { return asyncOp.isDone; } }

	public void GetResult() { }

	public void OnCompleted(Action continuation)
	{
		this.continuation = continuation;
	}

	private void OnRequestCompleted(AsyncOperation obj)
	{
		continuation();
	}
}

public static class ExtensionMethods
{
	public static UnityWebRequestAwaiter GetAwaiter(this UnityWebRequestAsyncOperation asyncOp)
	{
		return new UnityWebRequestAwaiter(asyncOp);
	}
}


RFC: React Client side suspense

Summary

Currently, enable suspense when createClient, then urql consider this ssr suspense, all useQuery will use suspense by default.
The checking logic is
const isSuspense = (client: Client, context?: Partial<OperationContext>) =>  client.suspense && (!context || context.suspense !== false);

But, suspense is really useful in client when building complex sap,
e.g. build a form builder need to pulling all schemas first, better to wait metadata is readly, otherwise the form will get alot rerender, and is hard to do it right, with an outside component handle the suspense, the build process can be sync.
Proposed Solution

Currently, the useQuery accept context, allowed opt-out suspense by providing a immutable context, have to write like
useQuery(gql``,  {context: useMemo({ suspense: true },[])})

useQuery should support suspense like react-query,
// react query
useQuery(queryKey, queryFn, { suspense: true })

// urql
useQuery(gql``,  { suspense: true })

Requirements

opt-in suspense

Hiya :wave: Thanks for submitting this, however for now I'm closing this. The primary reason is that it's not a complete proposal that focuses on a single goal, but seems more to be a question towards the semantics of suspense in urql.
We shipped major improvements to our React bindings with the help of the React team and as a consequence suspense is much more reliable in the newer versions. However, we recommend to either embrace client-side suspense or not, meaning we wouldn't recommend to selectively turn suspense on or off. Instead, enabling suspense on the client-side should apply its semantics across an app and not selectively. It is possible however to then turn suspense off selectively, kind of with the method you suggested, instead that the flag would be suspense: false, however your examples don't quite semantically match up with our API.
So, generally, suspense is opt-in globally by design.


Check for large or repeated relevance and warn of performance problems

Sometimes users build forms with repeated or long complex logic that will cause stack overflows downstream. The form that triggered this request had this 1300 character relevance repeated 2x and the inverse repeated 5x.

${B1_1StoveType}=23 or ${B1_1StoveType}=9 or ${B1_1StoveType}=10 or ${B1_1StoveType}=11 or ${B1_1StoveType}=12 or ${B1_1StoveType}=13 or ${B1_1StoveType}=14 or ${B1_1StoveType}=15 or ${B1_1StoveType}=16 or ${B1_1StoveType}=17 or ${B1_1StoveType}=18 or ${B1_1StoveType}=19 or ${B1_1StoveType}=20 or ${B1_1StoveType}=21 or ${B1_1StoveType}=22 or ${B1_2StoveType}=23 or ${B1_2StoveType}=9 or ${B1_2StoveType}=10 or ${B1_2StoveType}=11 or ${B1_2StoveType}=12 or ${B1_2StoveType}=13 or ${B1_2StoveType}=14 or ${B1_2StoveType}=15 or ${B1_2StoveType}=16 or ${B1_2StoveType}=17 or ${B1_2StoveType}=18 or ${B1_2StoveType}=19 or ${B1_2StoveType}=20 or ${B1_2StoveType}=21 or ${B1_2StoveType}=22 or ${B1_3StoveType}=23 or ${B1_3StoveType}=9 or ${B1_3StoveType}=10 or ${B1_3StoveType}=11 or ${B1_3StoveType}=12 or ${B1_3StoveType}=13 or ${B1_3StoveType}=14 or ${B1_3StoveType}=15 or ${B1_3StoveType}=16 or ${B1_3StoveType}=17 or ${B1_3StoveType}=18 or ${B1_3StoveType}=19 or ${B1_3StoveType}=20 or ${B1_3StoveType}=21 or ${B1_3StoveType}=22 or ${B1_4StoveType}=23 or ${B1_4StoveType}=9 or ${B1_4StoveType}=10 or ${B1_4StoveType}=11 or ${B1_4StoveType}=12 or ${B1_4StoveType}=13 or ${B1_4StoveType}=14 or ${B1_4StoveType}=15 or ${B1_4StoveType}=16 or ${B1_4StoveType}=17 or ${B1_4StoveType}=18 or ${B1_4StoveType}=19 or ${B1_4StoveType}=20 or ${B1_4StoveType}=21 or ${B1_4StoveType}=22

These kinds of relevancies create a ton of objects in JavaRosa's form parsing and on Android 4.4, where garbage collection is terrible, you get a stack overflow.
It'd be nice if pyxforms warned users about long logical expressions or suggested storing repeated logic in a calculate and referring to that calculate.

Need help figuring what would be an intuitive test to check for a complex logical expression.
specifically what would be the threshhold  after which a relevance will be termed as complex.

I can't immediately think of a good way of doing this. One naive idea is to warn if you have 10 or or more variables in a relevance/constraint. What do you think, @lognaturel.

So i have divided the action items for this issue into 2 as shown below:

[x] Suggest storing repeated logic in a calculate
[ ] Checking for complex logic and warning users on the same

I will be shelving implementation for the second, to allow for discussions on how to best handle it.

The linked PR #322 was closed with this comment from Hélène:

I think if we want to consider something of this nature we should take a step back and discuss a game plan. I think the complex check is likely useful and the duplicate one is likely best to avoid. In fact, JavaRosa/Collect already optimizes away those duplicates so they would not affect Collect performance.

@yanokwa is expression complexity still a stackoverflow issue for Collect? If not then are there metrics / tests from Collect around what the supported upper limit for expression complexity is? Something we can statically analyse like x number of function calls, y number of operators, z number xpaths, etc?
@MartijnR would you have any of the above performance concerns or info for Enketo?

I'd rather close this issue. I think it's going to be rare that users come up with these kinds of expressions. If they do and have problems with them, they can ask for support. Devices have a lot more RAM than they did in 2017 so I think it's pretty unlikely.
I also think generally there'll be an easy way to rewrite such expressions (e.g. (8 > ${B1_1StoveType} and ${B1_1StoveType} < 24) or (8 > ${B1_2StoveType} and ${B1_2StoveType} < 24) or (8 > ${B1_3StoveType} and ${B1_3StoveType} < 24) or (8 > ${B1_4StoveType} and ${B1_4StoveType} < 24))


llvmPackages_latest: 14 -> 15

Description of changes
Follow up to #194634 that targets staging and bumps llvmPackages_latest.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@vcunat Can we have a separate Hyrda jobset for this PR?

I don't think there should be as many rebuilds, since mesa now points to llvmPackages_15 in staging. Could you push the commit again?

Oh, I didn't notice my subscription here was because of a mention.
This doesn't cause that many rebuilds, but it's based on some staging commit for which we don't have binaries, so the jobset would be rebuilding everything (most likely).  What about basing this on current staging-next?  For example, this particular commit and eval as comparison base: https://hydra.nixos.org/eval/1789916#tabs-inputs

Now mesa is using llvmPackages_15 in nixpkgs master already.

OfBorg still showed around 4.7k rebuilds (total summed over all platforms).
Anyway, for fixing regressions I rebased on an OK master commit and here's Hydra's comparison: https://hydra.nixos.org/eval/1790712?compare=1790698  (*-linux only, at least for now)

It looks like a lot of the failures are coming from libclc; looks like some kind of LLVM version mismatch. I can take a look later today.
@vcunat is it okay if I hack on stuff on this branch for now? Not sure if the Hydra jobset was a one-off thing or if it'll trigger on updates to this PR.

Yes, I meant for this branch to keep getting fixes on top, and Hydra picking them up.

Current status: 35 new failures.

Pretty much all of these (excluding timeouts) look like they're coming from swift which looks like its failing because of compiler lints (unused variables). It doesn't look like the lint in question is new to LLVM 15 so I'm not totally sure why we're only seeing this error now; will investigate.

@vcunat still waiting on Hydra to confirm but I think all the new failures caused by this PR have been resolved.
How should we proceed from here? Should we have Hydra test *-darwin next or is it time to rebase and merge into staging, etc.

OK, jobset reevaluated with full platform list.

@rrbutani may I push a fix for "swift-corelibs-libdispatch" on *-linux to your branch?

@yu-re-ka Yes, definitely; thank you!
I'm sorry I haven't had time to work on this recently; please feel free to make any changes you feel are appropriate.

Latest run: https://hydra.nixos.org/eval/1792520?compare=1792488#tabs-now-fail
It looks like all of the remaining (38) failures can be traced back to:

swiftPackages.XCTest on aarch64-darwin (seems to have timed out but there's no log output..)
swiftPackages.swift-unwrapped on x86_64-darwin: log here, missing intrinsics for __builtin_elementwise_add_sat/__builtin_elementwise_sub_sat

Latest run: https://hydra.nixos.org/eval/1792520?compare=1792488#tabs-now-fail
It looks like all of the remaining (38) failures can be traced back to:

swiftPackages.XCTest on aarch64-darwin (seems to have timed out but there's no log output..)

edit: when building locally this (or swift anyways) does fail to build

swiftPackages.swift-unwrapped on x86_64-darwin: log here, missing intrinsics for __builtin_elementwise_add_sat/__builtin_elementwise_sub_sat

Is there an upstream issue on those missing intrinsics? We can keep LLVM14 for them I guess.

Is there an upstream issue on those missing intrinsics? We can keep LLVM14 for them I guess.

I'm not sure the intrinsics are actually missing from LLVM15 or anything (still appear to be there in source, etc). I don't have a good understanding of how the swift build process works (the error messages actually do reference clang-14 but it's not obvious to me how/where that's coming from) and I've been dragging my feet on digging deeper.
I'll take another look tonight though.

the error messages actually do reference clang-14 but it's not obvious to me how/where that's coming from

swift seems to build its own llvm/clang from the apple's llvm fork?

@rrbutani I suggest cutting off here and get this PR into staging so we can have this in NixOS 23.05.

At this point I suggest pinning swift to LLVM 14

This should target staging I think?

Apologies for the delay; I'm okay with pinning Swift to LLVM14 and moving on.

@gloaming @K900 There are changes to libclc (moved to within llvmPackages) and spirv-llvm-translator (misc fixes) within; can y'all verify that these are okay?

FYI, swift on nixpkgs master is now broken for *-linux since glibc upgrade.

Unfortunately the primary consumer of libclc in Mesa is Intel and I don't have the hardware to test it on, but as long as it builds, it should be fine.

I could test Intel (Tiger Lake) if it doesn't need restart of X and someone tells me what to test.

Basically anything involving OpenCL compute. Raytracing would also be nice but you don't have that.

Swift pinned to LLVM14, testing the OpenCL stuff and merging into staging if it's okay with everyone?

We decided to wait probably past 23.05 for this PR, it could be eventually backported if we justify security benefits or important fixes.

Assuming #229852 goes through I'll update this PR to bump the now pinned LLVM version in all the packages that successfully built with llvmPackages_latest = llvmPackages_15.
There are also a few extant changes to the LLVM package sets on this branch that we do actually want (and that should be applied to LLVM 16).

After this is merged, is it planned to bump llvmPackages from 11 to 15 on Linux?

By the way, the title is no longer accurate: llvmPackages_latest is already at 16.

The jobsets is still present and not disabled in Hydra

OK, thanks.  I cleaned that up now.  (disabled + hidden;  hydra doesn't really do deletions)


Modeler get's unuseable...

... after touching the attached file
simple-expressions.dmn.txt
Rename it to .dmn before. Every time you open the modeler, he reads it again and ends with an error message.
Where can I cleanup the recent files?

I'm running the modeler on windows 10.

Seems like something got awry in the error handling in the latest modeler. We'll investigate this.
Regarding your diagram: It contains the old (and wrong) DMN 1.1 namespace URI:
http://www.omg.org/spec/DMN/20151101/dmn11.xsd

The correct one should be
http://www.omg.org/spec/DMN/20151101/dmn.xsd

Released in v1.16.x.

Shouldn't we offer correcting the namespace as we do in the case of BPMN?
There's another support case regarding this issue: https://app.camunda.com/jira/browse/SUPPORT-4944

Support case closed with the workaround provided.


Boxplot: Whisker with value 0 will not be displayed

Hi.
I think I found a bug.
If the lowWhisker value is 0, it won't be displayed. The same works with the highWhisker. I tested it in our project within an issue:
dzhw/metadatamanagement#410
And I tested it in the live Demo:
http://plnkr.co/edit/7VHjgy?p=preview
Set a whisker_low value to 0 and you will see the result.
Bests.

Thanks, one way to work around this is to add some small epsilon to the values, like .00001 or 1e-5, I think..

Thanks for your fast reaction and help. That should works, but it should be only a temporary work around. We are working with scientific metadata and we have to display the correct and not modified data from our mongodb.
Do you will fix it?

I found this bug in the core: https://github.com/novus/nvd3/blob/v1.8.3/src/models/boxPlot.js#L110
Should be smth like:
if (f(d) >= 0) {

otherwise, zero value is ignored..


Leethub not working when submitting same question with new approach solution in Leetcode

Please review previous closed issues before filling out a new one! Duplicate issues will be closed without comment.
Describe the bug
When I solved previously solve problem in leetcode with new approach, it is not pushing the code to github repository.
Expected behavior
Newly written code must be pushed in github after getting accepted in leetcode.
Screenshots
this solution is accepted but not pushed in github...

Additional context
had solved this question with 2nd approach and while submitting it isn't pushing in githbub. If I remember correctly, this used to push 2nd approach solution also in github in the past.

hmm. this seems strange. I haven't been able to reproduce this error. Can you provide console log outputs when u hit submit on the same problem? Make sure you use LeetHub v.1.1.12.

I am solving new problems and LeetHub is unable to show anything in GitHub :(


Generate trait stub

Fixed "Fill class has_children".
IMHO ready for merge. If not, please, merge others PRs, that ready.


Changing security group on existing Ingress does not get applied to ENIs

If I change the security group assigned to a given ALB (via the ingress manifest annotation), the ALB correctly detects the new SG, but the ENIs attached to the EKS nodes don't deterministically detect the new SG.
The only way I've been able to force the ENIs to pickup the new SGs is by manually updating them in the console.

Hi, it's the designed behavior.

When the alb.ingress.kubernetes.io/security-groups absent, we will do two thing:

create one security group for LB.
attach the securityGroup created to worker node ENIs dynamically.

When the alb.ingress.kubernetes.io/security-groups presents, we will only do one thing:

attach the specified security group(s) to LB only.

We don't want to manage the security groups on worker nodes when alb.ingress.kubernetes.io/security-groups presents, since user is supposed to manage all security group related settings if they use it(and dynamically discovering ENI security groups is super inefficient).

Hi, it's the designed behavior.

When the alb.ingress.kubernetes.io/security-groups absent, we will do two thing:

create one security group for LB.
attach the securityGroup created to worker node ENIs dynamically.

When the alb.ingress.kubernetes.io/security-groups presents, we will only do one thing:

attach the specified security group(s) to LB only.

We don't want to manage the security groups on worker nodes when alb.ingress.kubernetes.io/security-groups presents, since user is supposed to manage all security group related settings if they use it(and dynamically discovering ENI security groups is super inefficient).

Hi @M00nF1sh ,
In one hand, we want to keep the dynamic creation of the Security group by the ALB ingress (create one security group for LB and attach the securityGroup created to worker node ENIs dynamically)
In the other hand, we want to add additional custom generic security groups that has been created manually (like to support github webhooks) to the alb. those custom generic security groups are also attached to other ELBs/instances and maintained in one place.
Any chance to add additional annotation like alb.ingress.kubernetes.io/security-groups-unmanaged: sg_github_webhook so with this annotation we will be able to keep the behavior of dynamic creation of the SG:

create one security group for LB.
attach the securityGroup created to worker node ENIs dynamically.
and
we will be able to add additional custom generic security groups to the ALB
attach the specified security group(s) to LB only.

so in the end we will get the result of 2 SGs attached to the ALB:
1 dynamic SG managed by the alb ingress
1 custom SG


how to test one image and get the people number?

The reasonable assumption is that you have a minimum of two images from a scene for testing. Maybe, the first image can be used to compute the affine parameters from the guiding network, while the second image can be used to get the crowd count. In your case of one image, you can try to use the same image for both operations.

where is the trained model?    tks

There are currently no plans to release the models. But that said, you should be able to train the models by following the README file.

Closing the issue due to no activity. Please re-open the issue if it is necessary.


Changes for Windows Server 2022

Hang on, maybe update
https://github.com/hic-infra/hic-tre-packer-images/blob/af48321568ead1314c8c8eeab054beef39e2e94e/templates/windows.pkr.hcl#L21
to 2022, or remove the year so it doesn't need to be changed in future


mpmath.svd_r has significant numerical precision losses when handling highly ill-conditioned matrices, regardless of precision specified

Ask:
Could someone please improve the numerical stability of mpmath's svd_r to be closer to that of Matlab's svd function?
Background:
I'm trying to replicate code originally written in Matlab in Python with mpmath. The code creates continuation matrices as described in the following paper (https://arxiv.org/pdf/2010.03901). Theses matrices are found, in part, by solving a least squares optimization problem via taking the SVD of a highly ill-conditioned Vandermonde matrix. To mitigate loss of accuracy, the Matlab code carries out these calculations using symbolic matrices right up until its time to take the SVD, at which point everything is converted to 256 digits of precision using Matlab's vpa functionality and the SVD is then taken. When calculating the Frobenius norm of A-USVt to find the residual, Matlab returns ~10^-134. When this Matlab code is replicated in Python with mpmath (and the matrix being fed into SVD_r is verified to be exactly equal in both the Matlab and Python codes), the residual comes out to ~10^-13, indicating significant loss of precision during SVD_r. Notably, this residual does not change over a wide range of mpmath.dps values tested, which ranged from 32-1024 digits.
Matlab code:
num_original_points = 6;
num_continuation_points = 27;
num_zero_points = 12;
num_extra_points = 27;
oversampling_factor = 20;
modes_to_reduce = 0;
num_digits = 256;

fprintf( '------------------------------------------------------------\n' );
fprintf( '%d POINT CONTINUATION\n\n', num_original_points );
start_time = tic;

fprintf( 'Setting up... '); tic;

digits(num_digits);

% the total number of points in the coarse domain
coarse_N = num_original_points + num_continuation_points + ...
    num_zero_points + num_extra_points;

% the bandwidth
bandwidth = floor(coarse_N/2)-modes_to_reduce;

% the total number of oversampled points in the sampled interval
num_oversampled_original = oversampling_factor*(num_original_points-1) + 1;

% the total number of oversampled points in the zero interval
num_oversampled_zero = oversampling_factor*(num_zero_points-1) + 1;

% the total number of points in the oversampled domain
oversampled_N = coarse_N*oversampling_factor;

% the coarse grid for the long interval [0,1)
coarse_full_grid = sym( (0:coarse_N-1).' )/coarse_N;

% the coarse grid for the sampled interval
coarse_short_grid = sym( (0:num_original_points-1).' )/coarse_N ;

% the fine grid for the sampled interval
fine_short_grid = sym( (0:num_oversampled_original-1).' )/oversampled_N;

% the 'midpoint' where zeroing starts
midpoint = (num_original_points + num_continuation_points)/coarse_N;

% the fine grid for the zero interval
fine_zero_grid = sym( oversampled_N*midpoint + ...
    (0:num_oversampled_zero-1).' )/oversampled_N;

% the Fourier modes
k  = (-bandwidth:bandwidth).';

% the number of Fourier modes
num_modes = 2*bandwidth+1;

fprintf( 'Done. (%1.3fs)\n', toc );

%% generate the polynomial basis

fprintf( 'Generating polynomial basis... '); tic;

% these variables will hold the polynomial basis on the coarse and fine
% grids respectively
coarse_p  = sym( zeros(num_original_points,num_original_points) );
fine_p    = sym( zeros(num_oversampled_original,num_original_points) );

% generate monomials
for d = 0:num_original_points-1
    coarse_p(:,d+1)  = coarse_short_grid.^d;
    fine_p(:,d+1)    = fine_short_grid.^d;
end

% use QR to construct coarse basis
[coarse_Q,coarse_R] = qr(coarse_p);

% use R to construct fine basis
%fine_Q = fine_p*inv(coarse_R);
fine_Q = fine_p/coarse_R;

fprintf( 'Done. (%1.3fs)\n', toc );

%% generate the continuations

fprintf( 'Generating reconstruction matrices... '); tic;

% generate reconstruction matrix on fine mesh
% Ensure grids and Fourier modes are evaluated at high precision
fine_short_grid = vpa(fine_short_grid);
fine_zero_grid = vpa(fine_zero_grid);
k = vpa(k);

% Generate reconstruction matrix on fine mesh with vpa precision
A1 = [vpa(cos(2 * vpa(pi) * fine_short_grid * k.')); ...
      vpa(cos(2 * vpa(pi) * fine_zero_grid * k.'))];
A2 = [vpa(sin(2 * vpa(pi) * fine_short_grid * k.')); ...
      vpa(sin(2 * vpa(pi) * fine_zero_grid * k.'))];
A = [A1, A2]; % A is now a high-precision symbolic matrix (vpa)

coarse_full_grid = vpa(coarse_full_grid);
% generate reconstruction matrix on total coarse mesh
C1 = vpa( cos( 2*vpa(pi)*coarse_full_grid*k.' ) );
C2 = vpa( sin( 2*vpa(pi)*coarse_full_grid*k.' ) );
C  = [C1, C2];

fprintf( 'Done. (%1.3fs)\n', toc );

fprintf( 'Performing SVD... '); tic;

% invert the SVD
[U, S, V] = svd(A);

residual = norm(A - U * S * V', 'fro')

Python replication code:
import mpmath as mp
import sympy as sp
import numpy as np
import matplotlib.pyplot as plt
import time
from mpmath import nstr

tic = time.perf_counter()
#Set d
d = 6 #number of grid points

#Set constants
num_digits = 256
n_over = 20
C = 27
Z = 12
E = 27
modes_to_reduce = 0

#the total number of points in the coarse domain
coarse_N = d+C+Z+E

#the bandwidth
bandwidth = coarse_N // 2 - modes_to_reduce

#the total number of oversampled points in the sampled interval
num_oversampled_original = n_over*(d-1)+1

#the total number of oversampled points in the zero interval
num_oversampled_zero = n_over*(Z-1)+1

#the total number of points in the oversampled domain
oversampled_N = coarse_N*n_over

#the coarse grid for the long interval [0,1)
coarse_full_grid = sp.Array(range(coarse_N))/coarse_N

#the coarse grid for the sampled interval
coarse_short_grid = sp.Array(range(d))/coarse_N

#the fine grid for the sampled interval
fine_short_grid = sp.Array(range(num_oversampled_original))/oversampled_N

# The fine grid for the zero interval
fine_zero_grid = sp.Array([(sp.Integer(x) + sp.Integer(d + C) * sp.Integer(n_over)) / sp.Integer(oversampled_N) for x in range(num_oversampled_zero)])

# The Fourier modes
k = sp.Matrix([x - bandwidth for x in range(2 * bandwidth + 1)]).transpose()

#the number of Fourier modes
num_modes = 2*bandwidth+1

# Generate the polynomial basis for the coarse and fine grids
#these variables will hold the polynomial basis on the coarse and fine grids respectively
coarse_p = sp.Matrix([[coarse_short_grid[i]**j for j in range(d)] for i in range(d)])
fine_p = sp.Matrix([[fine_short_grid[i]**j for j in range(d)] for i in range(num_oversampled_original)])

# use QR to construct coarse basis
coarse_Q,coarse_R = coarse_p.QRdecomposition()

#use R to construct fine basis
fine_Q_sym = fine_p*coarse_R.inv()

# Evaluate fine_Q_sym to num_digits
fine_Q = mp.matrix(fine_Q_sym.evalf(num_digits).tolist())

## generate the continuations
# Generate the reconstruction matrix on fine mesh
product = sp.Matrix.vstack(sp.Matrix(fine_short_grid), sp.Matrix(fine_zero_grid)) * k  # Perform the matrix product once
A1 = product.applyfunc(lambda x: sp.cos(2 * sp.pi * x))  # Apply cos element-wise
A2 = product.applyfunc(lambda x: sp.sin(2 * sp.pi * x))  # Apply sin element-wise
A_p_sym = A1.row_join(A2)  # Join the matrices

# Generate the reconstruction matrix on total coarse mesh
product = sp.Matrix(coarse_full_grid) * k  # Perform the matrix product once
C1 = product.applyfunc(lambda x: sp.cos(2 * sp.pi * x))  # Apply cos element-wise
C2 = product.applyfunc(lambda x: sp.sin(2 * sp.pi * x))  # Apply sin element-wise
C_m_sym = C1.row_join(C2)  # Join the matrices

# Evaluate A_p_sym and C_m_sym to num_digits precision
mp.dps = num_digits

# Convert A_p_sym and C_m_sym to mpmath matrices with precision
A_p = mp.matrix(A_p_sym.evalf(num_digits).tolist())
C_m = mp.matrix(C_m_sym.evalf(num_digits).tolist())

print('Calculating SVD')
U,S,V = mp.svd_r(A_p)
print('SVD Calculated')

from mpmath import mp, sqrt, fsum

# Calculate the Frobenius norm manually
residual_matrix = A_p - U * mp.diag(S) * V

# Compute the Frobenius norm as sqrt of sum of squares of all entries
residual = sqrt(fsum(residual_matrix[i, j]**2 for i in range(residual_matrix.rows) for j in range(residual_matrix.cols)))

print("Residual:", mp.nstr(residual, mp.dps))

In your Python code, you have
import mpmath as mp

and
mp.dps = num_digits

which means you are setting dps on the wrong object.  You need to set mpmath.mp.dps; see https://github.com/mpmath/mpmath/issues/657
FYI: Because this is a common problem, in mpmath 1.4.0, attempting to set mpmath.dps will result in an exception being raised:
In [1]: import mpmath

In [2]: mpmath.__version__
Out[2]: '1.4.0a2'

In [3]: mpmath.dps = 100
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[3], line 1
----> 1 mpmath.dps = 100

File ~/py3.12.4/lib/python3.12/site-packages/mpmath/__init__.py:449, in _MPMathModule._helper(self, prop, *args)
    448 def _helper(self, *args, prop=''):
--> 449     raise AttributeError("cannot set '{name}' on 'mpmath'. Did you mean to "
    450                          "set '{name}' on 'mpmath.mp'?".format(name=prop))

AttributeError: cannot set 'dps' on 'mpmath'. Did you mean to set 'dps' on 'mpmath.mp'?

Thanks for pointing that out! After making the change, the code works as expected.


Update readme

Pull Request Test Coverage Report for Build 471974397

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.681%

Totals

Change from base Build 471654430:
0.0%

Covered Lines:
89

Relevant Lines:
94

💛  - Coveralls

Pull Request Test Coverage Report for Build 471974397

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.681%

Totals

Change from base Build 471654430:
0.0%

Covered Lines:
89

Relevant Lines:
94

💛  - Coveralls


Face api gives an error when there are too many photos

Hello. When the face api has too many photos (eg 5000 photos), wait for a few minutes and then gives an error. I share the demo address. You can review js file
When the photo is not much (for example, 300 photos) works properly. It only gives an error when there is too many photos.
I am new in the use of this library. I would be glad if you explain in detail. Thanks

I already know that this is the problem. Can you share a sample code about how to divide the photos?


Tweak to gene description filters

Approved

Looks fine.

Coverage remained the same at 79.713% when pulling 2b5cfdd545b8e80acbfee299b92f53282d4c4e80 on khowe:master into 3dc173f1a5c3f777f1754525229012c2f622b41b on Ensembl:master.


uninstall program

Empire Version
wmic no work in shell
`
shell wmic product get name
shell wmic product where name="Microsoft Security Client" call uninstall /nointeractive
shell cmd /k wmic product where name="Microsoft Security Client" call uninstall /nointeractive
`

What do you mean "wmic no work in shell". Are you able to execute other shell commands? What OS and version of Empire? Please give more information than that.
Thanks.

@legendary77 When submitting issues please follow the template and provide more detail so that we can adequately diagnose the issue.


Feed iterator enters an infinite loop after a physical partition split has occurred

Describe the bug
When I run a targeted multi-partition query with a partition key that includes the first level of subpartitioning, the FeedIterator<T>.ReadNextAsync method never completes after a physical partition split has occurred. The iterator enters an infinite loop reading partition key ranges and the application eventually runs out of memory.
To Reproduce
I wrote a console application to reproduce the issue. Please download the solution, open the Program.cs file and specify a connection string to an Azure Cosmos DB for NoSQL account. The application will create a new database with one container and one physical partition. It will then upsert about 20 GB of data and attempt to read the first 10 documents from two logical partitions. At this point there should be two physical partitions. You can run the application multiple times. It will not upsert data if the container already exists.
The data consists of 40,000 documents (articles) with the following properties:

Id : string
CustomerId : Guid
SectionId : Guid
Content : string

There are two customers. Each customer has 20,000 articles organized in 2,000 sections (10 articles per section).
The container uses a hierarchical partition key /customerId, /sectionId, so there are 4,000 hierarchical logical partitions with 10 documents.
Finally, the application will execute a query SELECT * FROM c OFFSET 0 LIMIT 10, using the customer ID as the partition key in the request options. When a response is returned, it displays the number of documents and the total request charge.
Expected behavior
The FeedIterator<T>.ReadNextAsync method returns a response with the first 10 documents.
Actual behavior
The FeedIterator<T>.ReadNextAsync method never completes and the application eventually runs out of memory.
Environment summary
SDK Version: 3.38.1 (version 3.37.1 has the same issue)
OS Version: Windows 11 Enterprise (10.0.22631 Build 22631)
Additional context
You can examine the trace and the diagnostic string from another incident. It happens in both Direct and Gateway mode.

This is a known issue with the hierarchical pk feature. There is a temporary fix that should solve the issue for now until a version of the SDK is released with the fix.
Rather than having the PK included in the query request options, filtering on top level hierarchical Pks should be done through where clauses.
CURRENT QUERY THAT HANGS:
var queryDefinition = new QueryDefinition(
    $"SELECT * FROM c ");

var partitionKey = new PartitionKeyBuilder().Add(topLevelPkValue).Build();
var requestOptions = new QueryRequestOptions();

requestOptions.PartitionKey = pk;

List<JObject> results = new List<JObject>();
using var iterator = container.GetItemQueryIterator<JObject>(queryDefinition, requestOptions: requestOptions);

while (iterator.HasMoreResults)
{
    var response = await iterator.ReadNextAsync();
}

FIX:
var queryDefinition = new QueryDefinition(
    $"SELECT * FROM c "
    + $"WHERE c.topLevelPkValue = @pk1")
     .WithParameter("@pk1", topLevelPkValue);

using var iterator = container.GetItemQueryIterator<JObject>(queryDefinition);

while (iterator.HasMoreResults)
{
    var response = await iterator.ReadNextAsync();
}

Would've been lovely to be able to see a known issue such as this one in the known issues list.


nixos/tests: add installer-ng

Things done

It is similar to the nixosTests.installer but with system.rebuild.enableNg = true.
I am not sure if this is a good idea, maybe it will add too much load to the test suite? Anyway, no tests here are channel blockers yet, so maybe it is fine?

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg tests installer-ng.simple installer-ng.switchToFlake

nixpkgs-reviewd workflow started

Extra args: -p nixosTests.installer-ng.simple -p nixosTests.installer-ng.switchToFlake
Free space: true
Who asked: lucasew

TARGETS

x86_64-linux: true
x86_64-darwin: false
aarch64-darwin: false

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12447824722

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366862

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/5025


08 resampling steps and minor 07 update

@asteiker I also re-created the tutorial template for tutorial 8: https://github.com/NASA-Openscapes/2021-Cloud-Hackathon/blob/main/tutorials-templates/08_On-Prem_Cloud.ipynb


High CPU Usage when running the script

I wanted to try out this tool on Safari just to see how it works, however as these screenshots show, the script itself is using a lot more CPU power (and logically battery) than Safari does (and yes I know Safari probably already does AppNap). The first image is with the script running, second without. Also it tends to crash Safari once I kill the script.

Thanks for spotting that! I forgot the sleep statement after all the refactoring. It's fixed now.


Refactor SubjectMethodGenerator into strategies

// todo needs refactoring into different strategies, interface
public class SubjectMethodGenerator {

This has begun. Will complete as time permits.
See:
#72


Small UI bug when setting up price/amount/total in the Exchange view

OS: Ubuntu 18.04 with HyperDex .deb installer
When setting up a trade, the Total doesn't update if I first set the Amount and then the Price

HyperDEX 0.1.0-alpha.1
Electron 2.0.0
linux 4.15.0-20-generic
Locale: it

Thanks for reporting. Confirmed.

@sindresorhus Is this resolved? It works for me in master.

@lukechilds The issue is still reproducible in master. If you set Amount and then Price, it updates the Amount field instead of Total.

I'm still not seeing it:

@lukechilds Set Amount to 10 and Price to 100 and you'll see it.

Ah yes, confirmed 👍

It's because total is mutated in handlePriceChange, and afterwards handleTotalChange is called with the old value. Ideally you'd only mutate the state in one place when handling events to avoid side effects like these.
I'll create a PR with a fix.


Error after Installation of RP2040-FreeRTOS

Thanks for this FreeRTOS bundle on the Pi Pico. I am trying to run it on the VS IDE and have 1 error in the build so far as below - copied from the o/p terminal:
[main] Building folder: RP2040-FreeRTOS-main
[main] Configuring project: RP2040-FreeRTOS-main
[proc] Executing command: "C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\cmake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE "-DCMAKE_C_COMPILER:FILEPATH=C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\gcc-arm-none-eabi\bin\arm-none-eabi-gcc.exe" "-DCMAKE_CXX_COMPILER:FILEPATH=C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\gcc-arm-none-eabi\bin\arm-none-eabi-g++.exe" -SC:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main -Bc:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main/build -G "NMake Makefiles"
[cmake] Not searching for unused variables given on the command line.
[cmake] PICO_SDK_PATH is C:/Users/bvu3kor/Documents/Pico-v1.5.1/pico-sdk
[cmake] PICO platform is rp2040.
[cmake] CMake Error at CMakeLists.txt:56 (project):
[cmake]   Running
[cmake]
[cmake]    'nmake' '-?'
[cmake]
[cmake]   failed with:
[cmake]
[cmake]    The system cannot find the file specified
[cmake]
[cmake]
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "C:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main/build/CMakeFiles/CMakeOutput.log".
[proc] The command: "C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\cmake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE "-DCMAKE_C_COMPILER:FILEPATH=C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\gcc-arm-none-eabi\bin\arm-none-eabi-gcc.exe" "-DCMAKE_CXX_COMPILER:FILEPATH=C:\Program Files\Raspberry Pi\Pico SDK v1.5.1\gcc-arm-none-eabi\bin\arm-none-eabi-g++.exe" -SC:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main -Bc:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main/build -G "NMake Makefiles" exited with code: 1
From the Problems terminal o/p as below the project() command in the main CMakeLists.txt file fails as below :
CMake Error at CMakeLists.txt:56 (project):Running
'nmake' '-?'
failed with:
The system cannot find the file specified
line 56 from the file here for reference
Name the project
project(${PROJECT_NAME}
LANGUAGES C CXX ASM
DESCRIPTION "FreeRTOS-based RP2040 applications"
)
Kindly help to overcome this error. Thanks Benjamin

Difficult to say. The code builds on Linux, but you're using Windows, or Visual Studio, which I haven't ever used to build the project.
Line 56 of the project-level CMakeLists.txt file is actually ${FREERTOS_SRC_DIRECTORY}/event_groups.c. It's the first FreeRTOS file in the list, which makes me wonder if you haven't installed the repo's FreeRTOS submodule with git submodule update --init --recursive called from within the project directory. VS may not have done that for you.
Have you looked at C:/Users/bvu3kor/Documents/Pico-v1.5.1/RP2040-FreeRTOS-main/build/CMakeFiles/CMakeOutput.log? Does it give any extra info?

Closed after four months.


Update Travis References

Pull Request Template
Updating references of travis-ci.org to travis-ci.com
Description
On June 30, travis-ci.org will shut off. The new url will be travis-ci.com. I've done the migration to the new url already. This pr updates any references to travis-ci.org to travis-ci.com
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added reviewers to the PR.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@cfrazier91 @denver1117 it looks like the spark 2.4 build has been failing for a while. i attempted to fix it here but couldn't make any progress.


NR-67849 Always show install now CTA

https://issues.newrelic.com/browse/NR-67849

Since quickstarts should always have data sources, closing and ticket blocked until discussion with Becky


build-resources.yaml has image registry name reversed

https://github.com/redhat-developer-demos/tekton-tutorial/blob/master/pipelines/build-resources.yaml#L24
The minikube registry should be the default instead of the openshift one

Fixes via 45d705c


[Docs] Removed the dummy argument nonsense from 'alternatives.md'

After a discussion with James I realized there is a much nicer way of getting fix :: (* -> *) -> * from ifix :: ((K -> *) -> k -> *) -> k -> *.

Made the links relative and added the proposed sentence about Spines..


Waiting for Queue to Connect

So I'm trying to use node-resque to send a request inside a Lambda function (I don't know if the Lambda part is relevant).  I have these statements:
await queue.connect();
await queue.enqueue(queue, job, args);
I get to enqueue line 50 where it tries to add to the 'queues' object, and it fails because the connection isn't established yet.  The queue.connect() isn't returning a promise, so that await queue.connect() doesn't hold execution until it's connected.  I checked this in the debugger, and the
To check what was wrong with the connection, I put a check on queue.queues(), and the problem went away because queues() took enough time that the connection finished before it was done.  What's the right way to make sure that a connection is established before going on with further operations?

Can you please share code that reproduces this?  A failing test would be best!
await queue.connect() should block until the connection is established.  Can you share a stack trace or more details about the error message?

'use strict';
const expect = require('chai').expect;
const NodeResque = require('node-resque');
const connectionDetails = {
    pkg: 'ioredis',
    host: '<IP_ADDRESS>',
    port: 6379,
    namespace: 'resque'
};

describe('Connection Will Not Wait', async () => {
    const queue = new NodeResque.Queue({
        connection: connectionDetails
    });
    queue.on('error', (error) => {console.log('error', error);});
    await queue.connect();
    expect(queue.connection.connected).to.be.true;
});

queue.connect() returns connection.connect(), which doesn't have a return statement, so I don't see how it'll block.  Am I missing something?

great point @samguyjones! It looks like the connect() method(s) were only blocking in the case where you passed in an already connected redis object.
Can you try out https://github.com/taskrabbit/node-resque/pull/295 and let me know if that fixes your issue?

(closing in favor of https://github.com/taskrabbit/node-resque/pull/295)


Allow additional entrypoints to be specified

When a package doesn’t have package.json exports or exposes a wildcard in its exports, it would be nice to allow the user to manually specify an entrypoint to check. On the website, this could be done interactively; in the CLI, a new option will be needed. This would effectively eliminate the “Wildcard subpaths cannot yet be analyzed by this tool” problem kind.

What if, for wildcards, we use globby to detect what js files exist that match those globs, and then check to see if there are correspending d.ts files, resolveable via exports.types or typesVersions or whatever?

Yeah, there’s some logic in TS Server like this for path completions. Could be a good option.


Support for FLAC in ISO-BMFF

Shaka-player on Chrome enables playback of encrypted FLAC in ISO-BMFF, will that also be a feature of shaka-player-embedded when it's out of beta?

It is probably supported now, you just need to enable the codec from FFmpeg using the --codecs flag to ./configure.  We limit the default codecs to H.264 and AAC by default since (a) those are the only ones we've tested hardware decode on and (b) they are the most common and reduces binary size.  But you can enable any codec FFmpeg supports and there's a good chance it will work:
./configure --codecs h264,flac ...

Encryption support should only depend on the container, and we support encrypted MP4, so again it should work.  Does it work for you?  Can you provide any example content?

Excellent! I haven't tried it out, but I can provide example content within a day or two.

@TheModMaker I sent you an email with some example content.

Just an update as I've started testing a bit. Playback of FLAC in ISO-BMFF does work according to the pointers given by @TheModMaker above. I haven't tested with protected content yet, though.


Preview 1 and basic authentication in browser

In previous version (alpha), when basic authentication was in use, the browser prompt for credentials for inital connection (OPTIONS).
Now it is not prompting because of transport upgrade. Is there any way to put authorization header into initial GET negotiation connection?

WebSockets and EventSource provide very limited authentication capabilities (neither supports Basic Authentication uniformly, nor do they allow Authorization headers). Also, since SignalR uses multiple requests, authenticating the negotiation is insufficient, all requests need to be authenticated.
You can do authentication via the Query String across all transports. We have APIs in the client for this and a sample describing how to use JWT Bearer Token authentication here: https://github.com/aspnet/SignalR/tree/dev/samples/JwtSample
As with all authentication mechanisms, this is only secure when done over an HTTPS connection.

I know it is not possible for web sockets itself, I was hoped it can be on negotiation level. But I think now this negotiation is gone.

Negotiation isn't used when you explicitly choose WebSockets. Also, it is not sufficient to authentication on Negotiation only, so even if we authenticated the Negotiate request, the WebSocket request would be rejected unless it also carried authentication data.

Ok, I can workaround this (for testing) by manually put url to browser. After that all is working, and web socket is authenticated.


Violation if a team delete fullstop role in its team account

There should be a violation, if a team delete the fullstop role in its account. Currently we are getting only Exception because assume role fails.

:+1:
@Gregsen @harti2006 what did you think about that?

@Gregsen @harti2006 news here?

When we cannot connect to an account, can we be sure, that it's because of a deleted role? Is there some way to differentiate?

@Gregsen Yes, we are getting a specific Exception

seeing the Exceptions popping up on our monitor will create enough attention. In that cases we will fix this stuff asap.
Creating a violation for the respective account does maybe not show, how urgent this problem is.

@mawenzel I will close this issue, right now is already solved via a process. If this happens again, you can reopen it and we will create also a violation.


How to train invariable input shape CNN?

I define a CNN network that can process invariable input images, but can't find an example to learn how to train it. All I found is a MutableModule find in example/rcnn,it rebind the module when the shape changed.But after I implement the DataIter of my dataset, it seems that it failed to update the params, the accuracy didn't increase after several epochs. Any one can give an example?

When rebind the module, make sure arg_params and aux_params are passed to new module.

@solin319  I add some code, but nothing change.
        if shape_changed:
            #logging.info('shape chanege')
            cur_arg_params, cur_aux_params = self._curr_module.get_params()
            module = Module(self._symbol, self._data_names, self._label_names,
                            logger=self.logger, context=self._context,
                            work_load_list=self._work_load_list,
                            fixed_param_names=self._fixed_param_names)
            module.bind(data_batch.provide_data, data_batch.provide_label, self._curr_module.for_training,
                        self._curr_module.inputs_need_grad, force_rebind=False,
                        shared_module=self._curr_module)
            module.set_params(cur_arg_params, cur_aux_params)

            self._curr_module = module

you can find  module.py here

Hi @chenbiaolong are you still facing the same issue? Currently we have a tutorial using CNN for text classification.

@lanking520  the main  framework we use to train models is Tensorflow now.In last year we use tensorflow train invariable images and inference using MXNet. Thank you for your tutorial~ we'll learn from it when we need.

Thanks you for your feedback, we will keep the community a better place as best as we can do. Please let us you if you or your team would like to use MXNet anytime in the future. @nswamy can you add this with label Question, Example and possibly close this?

This issue is not solved, so it won't be closed. We can take this as a feature request for a tutorial.

@lanking520  @marcoabreu We found MXNet is convenient in c++ deployment,especially when we want to improve our throughputs. The C++ API is much friendly than tensorflow(collect the tensorflow c++ header and build the libtensorflow_cc.so is not an easy job ...). So we are glad to see more best practices provided by the community.

Assuming you're asking about variable batch sizes for the input, you should take a look at Module.reshape for this. Some related discussion can be found at https://github.com/apache/incubator-mxnet/issues/2294. And based on the unit-test, an example of its usage would be:
x = mx.sym.Variable('x')
y = mx.sym.FullyConnected(x, num_hidden=4)

exe = y.simple_bind(mx.cpu(), x=(5,4))
exe.arg_arrays[0][:] = 1
exe.arg_arrays[1][:] = mx.nd.ones((4,4))
exe.arg_arrays[2][:] = 0

new_exe = exe.reshape(x=(3,4))
new_exe.forward(is_train=False)

new_exe.outputs[0].asnumpy()

Also note that with Gluon, you can call Blocks with different sized batches without having to manage reshapes, etc.

Module API had been updated to support variable shape training, c.f. https://github.com/apache/incubator-mxnet/pull/6805 before this issue.
MutableModule from rcnn example was introduced before the previous PR to avoid breaking module API. It was unfortunate that the example was not updated timely since the PR. But if still interested, check out https://github.com/apache/incubator-mxnet/blob/master/example/rcnn/train.py#L117.
As for a special tutorial on variable shape training, you don't need one. Use module.fit or Gluon just as if it was fixed shape will work.

@ijkguo could we close out this issue?

I think the feature request for a tutorial (to train variable input shape CNN) mentioned by @marcoabreu is no longer necessary.
Training a variable input shape CNN is no different from a fixed shape one - use module.fit or Gluon as if input shape is fixed.


configure user.name, user.email before initial git commit (#179)

Avoid potential failure on initial git commit:
Prompt user for necessary git config values and
provide private key identity names/emails
as suggestions for convenience.

If this is a way to implement this, I would look into adding tests as well.

This looks pretty good, thank you!
If you could add some tests that would be very nice.

@marthjod If you could rebase real quick, we can merge this. Thanks for your effort!

Done. I could also squash commits for a more concise history if you want.

Awesome, thank you very much!


[11.x] Fixes old() function param & return type

Fix param & returntype to match actual values, see: https://github.com/laravel/framework/blob/923ee74bff9aeb16919f7bfbc14cde9091b4949b/src/Illuminate/Http/Concerns/InteractsWithFlashData.php

What's your suggestion: update the docblock in the InteractsWithFlashData.php-trait as well (add integer as an option)?
btw: just noticed that the old()-method in the trait will return the session-data $this->session()->getOldInput($key, $default) which has a mixed return type... so both docblocks seems to be out-of-date

If $default is mixed, then the return will be mixed.
Any Stringable or Htmlable could be used as a default value. Also floats, booleans, or basically any value that can be echo'ed.
I actually don't see how a Model instance, as currently is proposed, would be helpful as a default value. But nonetheless, maybe someone uses it like that.
I don't see a reason to change these type hints when $default can accept anything.

Looks as if I opened a can of worms here: I think mixed is too wide for this parameter and/or the return type. I could argue that the old()-method in the InteractsWithFlashData has incorrect docblocks then, but that's another story.
Thanks for your input!

Looking at InteractsWithFlashData I never knew about passing a model as $default and getting the $key as an attribute, that is interesting...
But yes, I would say it seems to have incorrect docblocks. Maybe that could be fixed.


Registry

I'd like to use a private registry in the playground (with multiple instances). How can I create one?

Yo should be able to follow https://docs.docker.com/registry/deploying/ in PWD without any problems.

I suppose that I can't use a local registry. Am I right?

what do you mean by a local registry?. An internal registry you have in your company?. Or just spawn a local registry in the playground to push images in there?

https://docs.docker.com/registry/deploying/#run-a-local-registry

Yes, you can do that. I already mentioned that here: https://github.com/play-with-docker/play-with-docker/issues/245#issuecomment-370244237

I'd like to run multiple instances (machines). I assume that I have to run a registry on one instance and make it accessible from the other instances. That's why I suppose that I need to run an externally-accessible registry:

These examples assume the following:
Your registry URL is https://myregistry.domain.com/.
Your DNS, routing, and firewall settings allow access to the registry’s host on port 443.
You have already obtained a certificate from a certificate authority (CA).

In case of PWD, I run the registry for example on an instance with IP <IP_ADDRESS> and like to access the registry on another instance with IP <IP_ADDRESS>. What URL and certificates should I use? <IP_ADDRESS> and a self signed certificate?

That's why I suppose that I need to run an externally-accessible registry:

not really because the PWD instances live in the same private network. So it's not necessary to configure the registry as external.
BTW, have you seen this? https://training.play-with-docker.com/linux-registry-part1/
and this? https://training.play-with-docker.com/linux-registry-part2/

No, I haven't seen that yet, but I'll have a look at. Thanks.
I tried to run a local registry on node1. I added its IP <IP_ADDRESS> to /etc/docker/daemon.json (like described in Deploy a plain HTTP registry)
$ cat /etc/docker/daemon.json
{
    "experimental": true,
    "debug": true,
    "log-level": "info",
    "insecure-registries": ["<IP_ADDRESS>", "<IP_ADDRESS>"],
    "hosts": ["unix:///var/run/docker.sock", "tcp://<IP_ADDRESS>:2375"],
    "tls": false,
    "tlscacert": "",
    "tlscert": "",
    "tlskey": ""
}

Then I ran the registry and added an image (like described in Copy an image from Docker Hub to your registry):
[node1] (local<EMAIL_ADDRESS>~
$ docker run -d -p 5000:5000 --restart=always --name registry registry:2
3685de2db57d377dc15b6adf12383ecf49d4942d170101ff4fb56099b91d55a1
[node1] (local<EMAIL_ADDRESS>~
$ docker pull ubuntu:16.04
16.04: Pulling from library/ubuntu
Digest: sha256:e27e9d7f7f28d67aa9e2d7540bdc2b33254b452ee8e60f388875e5b7d9b2b696
Status: Image is up to date for ubuntu:16.04
[node1] (local<EMAIL_ADDRESS>~
$ docker tag ubuntu:16.04 localhost:5000/my-ubuntu
[node1] (local<EMAIL_ADDRESS>~
$ docker push localhost:5000/my-ubuntu
The push refers to repository [localhost:5000/my-ubuntu]
6f4ce6b88849: Pushed
92914665e7f6: Pushed
c98ef191df4b: Pushed
9c7183e0ea88: Pushed
ff986b10a018: Pushed
latest: digest: sha256:7c308c8feb40a2a04a6ef158295727b6163da8708e8f6125ab9571557e857b29 size: 1357

Then I added the IP of the registry <IP_ADDRESS> to /etc/docker/daemon.json on node2 and tried to pull the image from the registry:
[node2] (local<EMAIL_ADDRESS>~
$ docker pull <IP_ADDRESS>:5000/my-ubuntu
Using default tag: latest
Error response from daemon: Get https://<IP_ADDRESS>:5000/v2/: http: server gave HTTP response to HTTPS client

Why does it complain?

Do I need to restart the docker service (like described in Part 1 - Running a Registry Container in Linux) although they modify /etc/docker/docker instead of /etc/docker/daemon.json?
service docker restart

How can I restart the docker service in PWD? Is that even possible?

Yes. You can kill it with pkill -9 -f docker and start it again with dockerd > /docker.log &

Restarting docker didn't help. I edited /etc/docker/daemon.json on both nodes and restarted docker as you described. Then I ran the the same commands as before, but I still get
[node2] (local<EMAIL_ADDRESS>~
$ docker pull <IP_ADDRESS>:5000/my-ubuntu
Using default tag: latest
Error response from daemon: Get https://<IP_ADDRESS>:5000/v2/: http: server gave HTTP response to HTTPS client

If you run docker info in node2 can you see the IP I'm insecure registries? Also, try adding the port <IP_ADDRESS>:5000 to the insecure registry flag in the daemon.json file

You're right. I had to add the port. Thanks for your help :1st_place_medal:


feat: make konnect entities spec.konnect.authRef immutable only when entity is already programmed

What this PR does / why we need it:
This PR makes it possible to fix a broken authRef instead of requiring users to delete the object and recreate it with a fixed authRef.
This change makes the authRef mutable when

entity does not have a Programmed condition with status set to True
entity does not have a APIAuthValid condition with status set to True

Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect significant changes

As we've already got the test suite added by Mattia, could we cover the added validations in it? I've created an issue to cover all existing CEL rules in this repo: #29.

Added those in c180eb4e8ca4559820f0f37549db61fe1a7c782c
PTAL


Cannot config exception_handler property for commands

Why do you need this feature?

We need to customize exception_handler of command.
Is your feature request related to a problem? Please describe.

Cannot config exception_handler property like this
g.custom_command('validate', 'validate_arm_template', exception_handler=handle_template_based_exception)

Describe the solution you'd like

Describe alternatives you've considered

Additional context

https://github.com/Azure/autorest.az/issues/789

find the solution here https://github.com/Azure/autorest.az/issues/789#issuecomment-809187026

merged


[Design] Set up gradient scale for brand colours

Closing as all work has been completed for this epic!


[ACQ] Erreur de pays

Url : https://briss.botalista.community/#/acquisition/edit/
Username : maccagni
Description : Setting IPEN with 'NZ' does not find New Zealand in the country list (and even scrolling with 'N' does not find this country).
I have also noticed that errors often occur where Sri-Lanka is assigned (e.g., with collections in Tenerife instead of Spain; or Syria instead of Switzerland) despite being the wrong nation.

I just want to ckeck data this week, but the bug is fixed


Preserve whitespace before and after cursor on auto-trim

Change the behavior on auto-trim (only) so that whitespace before and after the cursor is preserved. Any spaces, tabs and/or newlines adjacent to the cursor are preserved, even if they would normally be affected by the trimming of multiple newlines. If a selection is active, whitespace before, within and after the selection is preserved.

This is not quite ready yet, since currently it doesn't trim any trailing whitespace in the portion before the cursor or any leading whitespace in the portion after the cursor.

Thanks for hopping on this! I haven't had bandwidth to dive into this in a while, but I was having trouble finding a solution that could handle both ignoring the currently line (or only processing the current line) while still respecting all the multi-line trims.
This was complicated more by trying to preserve multiple selection sets, which other software (like vscode) don't need to deal with as they only trim the current line, and don't have any feature set around trimming multiple lines.
Let me know when you feel it's ready!

OK, the immediate problem described above is fixed.
For now, I just capture and preserve any whitespace (including multiline whitespace!) immediately before and immediately after the cursor or selection.  If you think it should only preserve the current line, that would be reasonably easy to change.
There may still be some tricky issues that I'm not sure how to best solve. For example, I'm pretty sure that leaving the cursor in the middle of a code block's "```" start tag will cause code block preservation to break.
What do you think? If you'd like to hold off on this until the plugin gets a unit test suite, I couldn't argue against that...

(Just to clarify, I probably can't/shouldn't volunteer to add unit tests myself in the short term.)

@velebit I'm also seeing the issue of bad code fence detection if the cursor is in the middle of the backtick block. It'd be nice to find a solve for this, but I've hit a wall on the best way around this.
Seems like the best way to go would be to find a way to detect whether the cursor(s) are inside a code fence (including the backticks), and if so to move them to the nearest inside/outside – but I'm not really sure how to execute this 🙃
I've made a branch in this repo (feature/preserve-whitespace-before-and-after-cursor) combines the current dev branch with your PR.
Any thoughts or input would be appreciated!


Currency icon - Kazakhstan tenge

Describe the requested icon
Currency icon - Kazakhstan tenge
Screenshots

Additional context
Wikipedia.

Added currency-kzt in v1.4.0!


Added session based authorization to API.

Authentication performed via login API in login.py checks credentials against htpasswd DB
and return a session cookie.
Session cookie is managed via flask session interface in session.py. Sessions are stored
on Redis with fixed expiration.
Added 2 new API /login and /logout


Maintain valid absolute links to tree objects when rewriting them

What happened:
When converting GitHub document links to absolute for indexing, we always assume blobs but in practice a link can have a tree object as destination, turning it to invalid one when it is necessary to serialize the absolute link in the document.
What you expected to happen:
Maintain valid absolute links.
Test with:

charts
example

@swilen-iwanow Can you check if this is still an issue and eventually close?

@swilen-iwanow Can you check if this is still an issue and eventually close?

Yes it is :D


Docker run fails

Runing with custom docker-compose or command here same problem:
Configuration file: none
            Source: /srv/jekyll
       Destination: /srv/jekyll/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.223 seconds.
jekyll 3.2.1 | Error:  �q��
sh: can't kill pid 35: No such process

This issue should be filed upstream at https://github.com/jekyll/jekyll/issues/new, Jekyll is Core software.


Update Wormhole Path Colors for Reduced and VOC

Replaced the reduced and verge of collapse path colors to make it clearer.
Here is a before and after:
Before

After

@DanSylvest any comments/issues?

Looks good. Let's try it :)

Updated PR merging main. Can try again now.

It'll be available on our test server soon:


Adjustment of footer on about us page

Description
adjusting the footer on about us page in the same way it is on home page
Mocks

Acceptance Criteria
Update [Required]

[ ] should look same as home page

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

i am going to do it


What will be the examples of props : dropdown-options

Please provide an example of dropdown-options props.
I have tried different options but cannot find proper solution.
Thank you

@subhra-sekhar I have updated the codepen with an example, also will add the same here.
<vue3-q-tel-input
  v-model:tel="tel"
  :dropdown-options="{ disable: true }"
/>

You can find the options in the quasar select component.

Closing this issue due to inactivity.

Thank you.


Fix MedicalWindow GUI

Currently, Medical Window will not have the scroll if the text is too long.
For now unlikely to be an issue unless user puts 10000 medical status
Will rebuild the GUI for it in 1.4

@random689 do we need to fix this?


postgres 9.3 can't work

Affected module
Does it impact the UI, backend or Ingestion Framework?
yes
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Screenshots or steps to reproduce
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 1165, in _run_raw_task
    self._prepare_and_execute_task_with_callbacks(context, task)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 1283, in _prepare_and_execute_task_with_callbacks
    result = self._execute_task(context, task_copy)
  File "/usr/local/lib/python3.9/site-packages/airflow/models/taskinstance.py", line 1313, in _execute_task
    result = task_copy.execute(context=context)
  File "/usr/local/lib/python3.9/site-packages/airflow/operators/python.py", line 150, in execute
    return_value = self.execute_callable()
  File "/usr/local/lib/python3.9/site-packages/airflow/operators/python.py", line 161, in execute_callable
    return self.python_callable(*self.op_args, **self.op_kwargs)
  File "/usr/local/lib/python3.9/site-packages/openmetadata/workflows/ingestion/common.py", line 114, in metadata_ingestion_workflow
    workflow.execute()
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/workflow.py", line 161, in execute
    for record in self.source.next_record():
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/topology_runner.py", line 104, in next_record
    yield from self.process_nodes(get_topology_root(self.topology))
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/topology_runner.py", line 89, in process_nodes
    yield from self.process_nodes(child_nodes)
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/topology_runner.py", line 89, in process_nodes
    yield from self.process_nodes(child_nodes)
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/topology_runner.py", line 89, in process_nodes
    yield from self.process_nodes(child_nodes)
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/api/topology_runner.py", line 67, in process_nodes
    for element in node_producer() or []:
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/source/database/common_db_source.py", line 210, in get_tables_name_and_type
    if self.is_partition(
  File "/usr/local/lib/python3.9/site-packages/metadata/ingestion/source/database/postgres.py", line 87, in is_partition
    cur.execute(
psycopg2.errors.UndefinedColumn: column "relispartition" does not exist
LINE 2:                 SELECT relispartition as is_partition

Version:

OS: ubuntu
OpenMetadata version: 0.11.5

Additional context
Add any other context about the problem here.

hi @lialzm, after reviewing this issue, we noticed that the postgres version you are sharing is not supported anymore (https://www.postgresql.org/support/versioning/). Therefore, we are not going to add compatibility here, sorry about that.
Thanks


Unable to retrieve hidden_states

I converted a locally saved T5 checkpoint to ONNX using FastT5:
>>> from fastT5 import export_and_get_onnx_model
>>> from transformers import AutoTokenizer

>>> model_checkpoint = "path/to/checkpoint"
>>> model = export_and_get_onnx_model(model_name)

I tested it for inference:
>>> tokenizer = AutoTokenizer.from_pretrained(model_name)

>>> token = tokenizer(input_terms, max_length=512 * 2, padding=True, truncation=True, return_tensors='pt')

>>> out = model.generate(input_ids=token['input_ids'].to('cpu'),
                            attention_mask=token['attention_mask'].to('cpu'),
                            return_dict_in_generate=True,
                            max_length=512 * 2,
                            num_beams=1,
                            output_scores=True,
                            output_hidden_states=True)

>>> out.encoder_hidden_states
>>> out.decoder_hidden_states
(None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
 None,
...

>>> out
GreedySearchEncoderDecoderOutput(sequences=tensor([[  0, 119, 114, 102, 108, 111, 108, 125, 120, 112, 100, 101,  35,  53, ...
...
), , encoder_attentions=None, encoder_hidden_states=None, decoder_attentions=None, cross_attentions=None, decoder_hidden_states=(None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None, None))

The hidden states are all None.
Is there any way that I can retrieve the hidden states for both encoder and decoder?

@Ki6an I also tried  by adding "output_hidden_states" = True in the onnx model's config. Also made sure this argument is added in model.generate() call, but still no luck. Any idea how I can retrieve the encoder/decoder hidden states?

sorry for the late reply,
you can get  the hidden states  of the encoder easily just by sending in the input_ids and attention mask to the encoder as shown below
...
model = export_and_get_onnx_model(model_name)
encoder = model.encoder

hidden_state = encoder(input_ids, attention_mask)

but for the decoder, you need to make lots of changes. you can start by making changes here
https://github.com/Ki6an/fastT5/blob/20441b33394e71f7612f39f228ecbe1925cd10ae/fastT5/onnx_models_structure.py#L52-L62
decoder_output[0] is the last_hidden_state
make it return that value as well
     return (
         decoder_output[0],
         self.lm_head(decoder_output[0] * (self.config.d_model ** -0.5)),
         decoder_output[1],
     )

also, do the same changes for the decoder.
then, retrieve those values from ort session  here and here
finally, pass those values
https://github.com/Ki6an/fastT5/blob/20441b33394e71f7612f39f228ecbe1925cd10ae/fastT5/onnx_models.py#L199
as decoder_hidden_states=