copyright notice/disclaimer at the top of every source code file

By @mkuzak
I'm in favor of getting rid of those, since they are not required. Unless someone thinks we need it.
comments
By @sverhoeven
If the source code file is or can be distributed alone then the notice should be there.
If the source code file is always distributed with a LICENSE file, etc. then the notice can be removed.
@LourensVeen what do you think?

By @jiskattema
if i remember correctly, they are not (legally) necessary
How about only leaving them in if the license is not our preferred license, and redistribution is likely?

By @mkuzak
I agree with @sverhoeven on that, if the files are likely to be distributed separately they should have notice on top, otherwise not.

By @LourensVeen
It's not legally necessary. When you create a work you get to own the copyright, whether you put any notices on it or not (according to the Berne convention, which almost all nations are signatory to). If you don't have a statement in every file and somehow a file gets separated from the rest, then whoever gets it would not know that it's licensed, and therefore should not distribute it. If they can somehow ascertain that it's ASLv2, then they can safely distribute it, as long as they put the license notice back in, since the license requires that.
Of course, having such a notice prevents a lot of hassle in such a case, but I agree that in practice this probably doesn't happen often, and especially in short files it's not nice to have such a big block of text repeated everywhere.
Both the FSF and the ASF recommend putting a rather lengthy notice into every file, with a restatement of the warranty disclaimer. I've never heard of anyone suing anyone over a warranty issue with free software however, and I can't imagine a judge ruling that we're responsible for warranty on a free-of-cost piece of software licensed under a license that explicitly disclaims warranty, just because it wasn't restated in every single file. (If someone pays us to develop software for them, then we will probably be required to provide warranty regardless of what the license says, but that's a separate issue.)
Perhaps we can use a shortened version, something like this:
Copyright 2014, 2016 Netherlands eScience Center.
Licensed under the Apache License, version 2.0. See LICENSING for details.
The LICENSING file could then contain the longer statement, together with the actual license text, or something more complicated if the program consists of multiple modules with different licenses.
Anyone wanting to reuse a single file from our program would then be responsible for doing so according to the license, e.g. by having their own LICENSING file that explains that we own that particular file and contains the license, or by adding the longer statement to the file, or in some other way that the license we used allows.
Since there is at least a statement of who owns the copyright, if someone happens to come across a single file, they at least know that it's copyrighted (and can't claim they thought it was public domain) and they can contact us if there's any doubt as to what happened and what they are and aren't allowed to do.

By @larsmans
Agree with @LourensVeen on including that short notice. Program modules get copied around when users want only part of the functionality.

By @mkuzak
What will we do in case of files with external contributions. We'd have to ask people to transfer their copyrights to NLeSC. We should have some standard form for that too

By @LourensVeen
Not necessarily, the copyright could be shared. The contributors do have to explicitly contribute under Apache 2.0, but the license already contains language that says that all contributions are considered to be under Apache 2.0 as well.
Of course, this will make it more difficult to relicense the code, because all contributors have to give permission. This is more of a governance matter than a licensing matter though.

What to do in case of existing code with existing copyright lines? Do we need to add our own line? Depending on the software license of the existing code?
(This is not a hypothetical situation, I am adapting code licensed under BSD clause 2 at the moment.)

Ah, good question. If you're modifying an existing file with an existing license, then there should only be an additional copyright line I'd say, but with the original copyright statement. So we'll use the existing license for our additions. I've added a note to #82.

OK, here is my BIG problem with copyright lines (and version info too!) in every file.
When a new version of the project is issued, then every file in the project is changed if the copyright year (or from .. to years) is being kept up to date. This makes change tracking a nightmare.
About once a year I get updates sources for one project which has about 250 files in it and I cannot see what functionality has changed without a great deal of effort! Usually it is one or two files whose constant values have changed (I know, changing constants - yeah!).
It the copyright notice really worth all that hassle?

As long as only the copyright lines are changed in the commit and the commit has the appropriate message, I don't see an issue there.

Yes, one work around is to change the copyright/version info for all files in one commit (with the appropriate commit message) and make functional changes in a separate commit (or commits). But isn't it easier to just not have license and version info in there in the first place?

I don't believe this is a workaround. Those should not be in the single commit in the first place. Functional changes should not be mixed with copyright/version info update.

Agreed!

This is an old issue and the discussion has gone stale -- closing this issue, please reopen it if relevant.


Stipple.render() not working as expected for Dict{String, Vector{Any}}

Stipple v0.27.2 Stipple.render() does not work as expected for Dict{String, Vector{Any}} and Vector{Dict{Any,  Any}}. For the first it produces a double layer of keys, for the latter, an empty Dict. Can anyone help?
v0.27.2
julia> dict_of_vectors = Dict("hello" => [1,2,3,4], "world" =>["five", "six"])
Dict{String, Vector} with 2 entries:
  "hello" => [1, 2, 3, 4]
  "world" => ["five", "six"]

julia> Stipple.render(dict_of_vectors)
OrderedDict{Symbol, Pair{String, Vector}} with 2 entries:
  :hello => "hello"=>[1, 2, 3, 4]
  :world => "world"=>["five", "six"]

julia> vector_of_dicts = [Dict("hello" => 1, "world" => 2)]
1-element Vector{Dict{String, Int64}}:
 Dict("hello" => 1, "world" => 2)

julia> Stipple.render(vector_of_dicts)
OrderedDict{Union{}, Any}()

v0.27.1
julia> dict_of_vectors = Dict("hello" => [1,2,3,4], "world" =>["five", "six"])
Dict{String, Vector} with 2 entries:
  "hello" => [1, 2, 3, 4]
  "world" => ["five", "six"]

julia> Stipple.render(dict_of_vectors)
Dict{String, Vector} with 2 entries:
  "hello" => [1, 2, 3, 4]
  "world" => ["five", "six"]

julia> vector_of_dicts = [Dict("hello" => 1, "world" => 2)]
1-element Vector{Dict{String, Int64}}:
 Dict("hello" => 1, "world" => 2)

julia> Stipple.render(vector_of_dicts)
1-element Vector{Dict{String, Int64}}:
 Dict("hello" => 1, "world" => 2)

Found the bug, fixing now!

New version is out, thanks for reporting


Question about binary masks

A great work!
Is the binary mask （GT）used for training and validation 0/255 or 0/1?

255 自己opencv一下就知道了

It is 255


Why disabling score fusion get even better results?

My understanding is that enabling score fusion will use the external classification score, which should lead to better results.
However, when I disabling the score fusion, i.e.,:
# when using external scores, our model is generating "proposals"
# multiclass_nms: False,
# ext_score_file: ./data/thumos/annotations/thumos14_cls_scores.pkl,
# comment out L47-48 and uncomment L50 to disable score fusion
multiclass_nms: True,

The eval result is:
|tIoU = 0.30: mAP = 81.87 (%)
|tIoU = 0.40: mAP = 77.58 (%)
|tIoU = 0.50: mAP = 71.65 (%)
|tIoU = 0.60: mAP = 57.75 (%)
|tIoU = 0.70: mAP = 43.07 (%)
Avearge mAP: 66.38 (%)

While when enabling the score fusion, i.e.,:
# when using external scores, our model is generating "proposals"
multiclass_nms: False,
ext_score_file: ./data/thumos/annotations/thumos14_cls_scores.pkl,
# comment out L47-48 and uncomment L50 to disable score fusion
# multiclass_nms: True,

I got a worse result:
|tIoU = 0.30: mAP = 74.82 (%)
|tIoU = 0.40: mAP = 71.34 (%)
|tIoU = 0.50: mAP = 65.70 (%)
|tIoU = 0.60: mAP = 55.28 (%)
|tIoU = 0.70: mAP = 41.97 (%)
Avearge mAP: 61.82 (%)

BTW, I did NOT retrain the model after revising the yaml because I think this should only do with the testing.

I guess a major performance drop may come from the duplicate action part, i.e., Diving and Cliff Diving as in #10. When we disable the score fusion, we can provide predictions for both Diving and Cliff Diving. But when we enable the score fusion, one category may be supressed.

@tzzcl According to #10, if we disable the score fusion, actionformer can not predict Cliff_Diving at all as it never saw an training sample from this category.
I still don't get the reason why fusion with external score will get worse result. And if it's true, why even bothering ourselves with the external score?

When I refer to #10, I mean that there exists multiple labels for the same action. ActionFormer cannot handle this situation previously, but we fix that issue in a commit. Thus, when we disable the score fusion, ActionFormer can predict multiple action labels with same interval. When we enable the score fusion, we may can not do this part.

I see. It's great to get rid of the external scores.
Thanks.


OpenGov. Delegations. Your delegation info

Account and tracks for singleshard
View delegations button for multishard

Modal with list of accounts, vote power and tracks

Status verification: ✅


All Optional Object Interface Converts to any

I couldn't find a relevant issue, but this does seem rather fundamental and against the principle of:

Statically identify constructs that are likely to be errors.

TypeScript Version:
1.8.7
Code
interface Optional {
    foo?: string;
}

function foo(o: Optional): void {}

foo('bar'); // should throw
foo(1); // should throw
foo({ bar: 'baz' }); // should (and does) throw

Expected behavior:
Expected behaviour is that you should be able to type guard against other non-objects and only accept Objects with no properties or declared properties.
Actual behavior:
Passing anything other than an object literal that contains extra properties is acceptable.

https://github.com/Microsoft/TypeScript/pull/3842 seems relevant

We talked about this briefly and think the idea in #3842 is worth trying out. I ported the PR forward but the code was written incorrectly around this specific case:
interface NotAllOptional {
  x: string;
}
interface AllOptional {
 y?: number;
}
type mixed= NotAllOptional & AllOptional;
let z: mixed = { x: 'ok' };

The code I had failed because we check intersection assignability by seeing if the source is assignable to each constituent in sequence; the first type succeeds and the second type fails (even though it shouldn't). A more complex check is needed here but I don't have time to implement it right now.
If someone wants to figure it out and send an updated PR that we could try against our internal suite of partner code, that'd be great. No guarantees it's going to be worth taking a breaking change over, but seeing what kind of issues (and non-issues) it finds might help us down the path to a more complete solution if needed.

I'm a bit confused, you just said that when you check assignability in an intersection you check the assignability of the source to both constituents, but if I have something like that:
interface A { a: string }
interface B { b: string }

const test: A & B
test = {a: 'a', b: 'b'}

It works fine (as expected) even though test isn't assignable to either A or B?

What's the status on this? In this something we can reasonably expect to be part of the 2.0 release?
I've been continously porting my app to Typescript over the past month or two and this is the one feature I desperately miss, as I'm using a lot of weak-typed objects to represent the state of a React component or for DTOs.

What's the status on this? In this something we can reasonably expect to be part of the 2.0 release?

The labels indicate that it a potentially good idea (Suggestion), but that the TypeScript team have limited resources and do not feel it is important enough to address (Accepting PRs) and are currently leaving it up to the community to address (Milestone = Community).

I believe this is a bigger issue because of TypeScript named parameters.
class Foo {
bar({a = <string|undefined>void 0, b = <number|undefined>void 0} = {}) {
// Do something
}
}
let foo = new Foo();
/*
This explicitly violates the method signature,
which states that it only takes optional named parameters
"a" and "b".
*/
foo.bar("hello");
The named parameters feature for methods and functions is broken until the type system can support it.

Is this issue solved by the new object type?

Is this issue solved by the new object type?

No. a type with only optional properties is treated as {} from assignment-compatibility perspective, i.e. you can pass in almost any thing to it.

This is kind of a big deal when using the "optional options" pattern:
interface IOptions {
  upsert?: boolean;
  debug?: boolean;
}

function questionableBehaviour(id: string, options?: IOptions, callback?: Function) {
  // code
}

questionableBehaviour('testId', 'invalid string', (err) => console.log(err));

This IMHO should definitely not compile.

Any chance the TS team could revisit addressing this? I feel that the introduction of Partial<T> has increased the surface of this problem. It's an extremely convenient operator that you don't really realize can be a footgun until you get errors in production ( :raising_hand: ).
To add one more 'wat' to the OP, this is the case that keeps biting us in our codebases:
foo({ bar: 'baz' }); // should (and does) throw
const wat = { bar: 'baz' };
foo(wat); // doesn't :(

@mhegazy Would the ability to extend the object type address this issue?
interface Optional extends object {
    foo?: string;
}

function foo(o: Optional): void {}

foo('bar'); // should throw, because 'bar' does not extend object
foo(1); // should throw, because 1 does not extend object
foo({ bar: 'baz' }); // should (and does) throw

@mhegazy Would the ability to extend the object type address this issue?

not sure i see how this helps. @RyanCavanaugh has a description of the approach we would like to try.

@mhegazy If I understand the issue right, you can get safety with an intersection type today. I believe supporting extend object will make this easier. That way it's not a breaking change (as @RyanCavanaugh's approach seems to be):
type A = object & { foo?: number }

let a: A = {}
let b: A = { foo: 1 }
let c: A = { bar: 1 }         // error
let d: A = { foo: 1, bar: 2 } // error
let e: A = 1                  // error

http://www.typescriptlang.org/play/index.html#src=type a %3D object %26 { foo%3F%3A number }

let a%3A a %3D {}
let b%3A a %3D { foo%3A 1 }
let c%3A a %3D { bar%3A 1 }         %2F%2F error
let d%3A a %3D { foo%3A 1%2C bar%3A 2 } %2F%2F error
let e%3A a %3D 1                  %2F%2F error

Excluding the primitives and incorrect object literals is nice but doesn't go far enough to be "solved" IMO. You can still e.g. use a class constructor when you meant to use a class instance.

e.g. use a class constructor when you meant to use a class instance.

Does that happen for anything other than the pathological case of an empty class? Supporting extends object seems like a cheaper way to the cover a lot of cases.

I just asked a related question on SO and was directed to this thread. Here is an example where the object & intersection doesn't solve the problem:
type Right = { right?: boolean } & object
type Wrong = { wrong: {fail: number} }

function returnWrongX(p: Right, callback: (param: Right) => Right) {
    return callback(p).right
}
// throws a runtime error
returnWrongX({}, (param: Wrong) => param.wrong.fail ? {} : {})

@bijoutrouvaille I see what you mean, in that the typing is more fragile than it should be. On the last line you're explicitly broadening param's type to Wrong, which compiles.
If you don't type param on the last line and let TS infer it as Right, then you get a compile time error as expected.

If the fix breaks some corner cases, can we still have the fix under a new compiler flag?
Example, strictNullChecks, it found tones of things that were missed before this strict check was available. Can we have the same here. Please ...

As usual, @RyanCavanaugh is right :) A few cases that compile, but shouldn't:
type A = object & { foo?: number }

let a: A = {}
let b: A = [1]
let c: A = new class { bar = 42 }
let d: A = () => 'foo'

And a few more:
let e: A = null;
let f: A = /foo/;
let g: A = class A { };

It has to at least work somewhat correctly for it to be considered @3n-mb.

It would be nice if you could specify that the object have at least one of the optional members.  This way if you specify something that doesn't match at least one of the expected properties, it will get caught at compile time.

It would be nice if you could specify that the object have at least one of the optional members.

That can already be modelled by an intersection type:
type AtLeastOne = { foo: string; bar?: string } | { foo?: string; bar: string};
const a: AtLeastOne = { foo: 'bar' }; // ok
const b: AtLeastOne = { bar: 'baz' }; // ok
const c: AtLeastOne = {}; // error on `c`

While it can be be done with an intersection, it quickly becomes unwieldy for something even relatively small  like a mailing address.

While it can be be done with an intersection, it quickly becomes unwieldy for something even relatively small like a mailing address.

Even so, I suspect that would be a different request than what this issue is about.


download new code

Checklist

[x] documentation is added or updated
[x] tests are added or updated

ok


Enable wifi hub feature on the Cisco router connected under Powerline

Moved from https://github.com/130s/hut_10sqft/issues/190

Meanwhile, can its wifi routing feature on so that other devices can connect to LAN via its antenna?

Routing is provided at the upstream, so this wifi hub can really function as a hub.
Is disabling dhcp enough?

I'm afraid that once dhcp is disabled and disconnect from its wifi, there might be no way to re-connect to this re-purposed cisco over ip network as ip routing is impossible (my LAN and cisco's LAN are in different segment).

That has not been an issue for months.


Numerator/denominator not being reduced to lowest common denominator

I hope I explained that correctly.
If I use ExposureTime.numerator and ExposureTime.denominator it seems (in some cases) that the numbers aren't reduced to the lowest common values.
i.e. 10/2000s instead of 1/200s
I haven't had a chance to dig into the code fully but if I find out something I'll comment here.
Thanks.

I'm not sure this is a thing because I see a similar 10/2000 on other EXIF systems. I was able to apply a workaround right before displaying the code (outside of the EXIF library) to update the displayed number if it was showing a 10 numerator.


create partition err: create gamma table has err:[4294967294]

I creat table when I use
"curl -XPOST -H "content-type:application/json" -d '{
"db": true,
"method": 0,
"columns": {
"imageurl": {
"type": "keyword"
},
"boundingbox": {
"type": "keyword"
},
"label": {
"type": "keyword"
}
},
"feature": {
"type": "vector",
"filed": "imageurl",
"model_id": "resnet",
"dimension": 2048
}
}' http://<IP_ADDRESS>:4101/test/test/_create "
It got "{"code": 550, "msg": "create partition err: create gamma table has err:[4294967294] "}"
I find when I change the dimension ,it meets the problem . If I use 512 as the dimension,it successed.
why?
Look forward to your reply.
Thank you ~

Please provide the gamma.log content.

INFO 2019-11-01 10:51:07,914 profile.cc:42 Profile created success!
INFO 2019-11-01 10:51:07,914 gamma_engine.cc:164 GammaEngine setup successed!
INFO 2019-11-01 10:51:07,914 gamma_api.cc:315 Engine init successed!
INFO 2019-11-01 10:51:07,914 vector_manager.cc:86 ivfpq parameters: metric_type=0, nprobe=10, ncentroids=256, nsubvector=32, nbits_per_idx=8
ERROR 2019-11-01 10:51:07,914 memory_raw_vector.cc:34 vector memory alloc err , max_doc_size_ [10000000], dimension_ [2048]
ERROR 2019-11-01 10:51:07,914 vector_manager.cc:112 Raw vector feature init error, code [2]!
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [_id], type [4], index [0]
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [_source], type [4], index [0]
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [version], type [1], index [0]
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [slot], type [0], index [0]
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [label], type [4], index [0]
INFO 2019-11-01 10:51:07,914 profile.cc:204 Add field name [imageurl], type [4], index [0]
INFO 2019-11-01 10:51:07,915 profile.cc:204 Add field name [boundingbox], type [4], index [0]
INFO 2019-11-01 10:51:07,915 profile.cc:228 Create table 20 success!
ERROR 2019-11-01 10:51:07,915 gamma_engine.cc:395 Cannot create table!
INFO 2019-11-01 10:51:07,967 profile.cc:42 Profile created success!
INFO 2019-11-01 10:51:07,967 gamma_engine.cc:164 GammaEngine setup successed!
INFO 2019-11-01 10:51:07,967 gamma_api.cc:315 Engine init successed!
INFO 2019-11-01 10:51:07,967 vector_manager.cc:86 ivfpq parameters: metric_type=0, nprobe=10, ncentroids=256, nsubvector=32, nbits_per_idx=8
ERROR 2019-11-01 10:51:07,967 memory_raw_vector.cc:34 vector memory alloc err , max_doc_size [10000000], dimension [2048]
ERROR 2019-11-01 10:51:07,967 vector_manager.cc:112 Raw vector feature init error, code [2]!
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [_id], type [4], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [_source], type [4], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [_version], type [1], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [_slot], type [0], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [boundingbox], type [4], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [label], type [4], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:204 Add field name [imageurl], type [4], index [0]
INFO 2019-11-01 10:51:07,967 profile.cc:228 Create table 21 success!
ERROR 2019-11-01 10:51:07,967 gamma_engine.cc:395 Cannot create table!
@wxingda
I am  not familiar with go and distributed system.
Look forward to your reply.
Thank you ~

single mode @wxingda

sorry， it is our mistake
the default engine has 10 000 000 document , but you create 2048 , means 2048*40000000 bytes need , your memory not enough。next version we will fixed it.
now you have two way to fix it .

open file vearch/plugin/src/main.py in line 272

"engine": {"name": "gamma", "metric_type": method},

to
"engine": {"name": "gamma", "metric_type": method , "max_size":100000},

ERROR 2019-11-01 10:51:07,967 memory_raw_vector.cc:34 vector memory alloc err , max_doc_size [10000000], dimension [2048]
This is out of memory error，10 millions is too big to your system. Two solutions:

You can reduce the max_size parameter when creating the table. reference: https://vearch.readthedocs.io/en/latest/use_op/op_space.html#create-space

Please pull the latest code(v0.2) from github, and use Mmap store type which can store raw vector to disk

if you want use resnet model or alexnet model , please remenber change these:
1、update vgg16 to resnet or alexnet in the dict image_config dict in the file plugin/src/config.py
2、add self.load_model() in the init method of BaseModel and change the dimision to right num(alexnet=256, resnet=2048) in plugin/src/image_retrieval/image_extract/resnet.py or alexnet.py.Or you just need pull the newest code!
What's more, if you want change params (eg the num of ps and max_size of docs) when creating table, you  can use this API.
https://github.com/vearch/vearch/blob/master/docs/APILowLevel.md
There are some demos for creating tabel in this file.
https://github.com/vearch/vearch/blob/master/test/test_vearch.py
Last at all , thanks for your issue, if you have any questions, please contact us in time and we will answer them for you as soon as possible！

thank you very much  ~  @ansjsun @qiutianme @gDreamcatcher @wxingda
I will try it again . I learn a lot from you. thank you again.


Feat/vist cpc 807 add start and endtime for visit

JIRA: link to jira ticket
Context:
What is the ticket about and why are we doing this change.
Does this PR change the .vscode folder in petclinic-frontend?:
If the PR changes the .vscode folder, explain why in detail because it should not.
Be sure to include cgerard321 as a reviewer.
Reviewers need to check for any changes to the
.vscode folder and add a comment about it to their review comments.
Changes
What are the various changes and what other modules do those changes affect.
This can be bullet point or sentence format.
Before and After UI (Required for UI-impacting PRs)
If this is a change to the UI, include before and after screenshots to show the differences.
If this is a new UI feature, include screenshots to show reviewers what it looks like.
Dev notes (Optional)
Specific technical changes that should be noted
Linked pull requests (Optional)
Pull request links

Added a vistStartDate and a visitEndDate

You did not fill up the pull request "form" :

You can find all the information you need in your Jira ticket.

Naming convention for the PR needs to be : feat/(VIST-CPC-807): Add Start And Endtime For Visit

It seems you have touched .vscode folder:

Maybe it is better to add Christine as reviewer, just to make sure everything is correct.
In the visits-service, I see that you mostly renaming fields (Date -> StartDate). However, a lot of other services and configuration files are involved in your PR, but they seem to be the same as before changing? Do you know what happened to these files?


Tweaking a plot

I am posting examples of how to tweak a plot for future reference. When I find time I will set up a docs PR including what I posted in #40 and #42 (unless a more convenient way to achieve theses things is implemented).
Simple baseline plot
using AbstractPlotting, CairoMakie, MakieLayout, AlgebraOfGraphics

N = 500
x = rand(N)
df = DataFrame(x = x, y = x .+ randn(N))

cols = style(:x, :y)
scat = spec(Scatter)
pipeline = cols * scat
aog_simple = data(df) * pipeline

aog_simple |> draw

scene, layout = MakieLayout.layoutscene()

AlgebraOfGraphics.layoutplot!(scene, layout, aog_simple)

Adjusting color and transparency
grd_lay = layout.content[1].content # get the `GridLayout`
lax = grd_lay.content[1].content # get the `LAxis`
lax.scene.plots[1].color[] = (:red, 0.5)

It might be useful to explicitly show how you get the LAxis in docs - from there, any manipulation becomes trivial.

I edited the code to make to make this more explicit.
I also just found out that one can do spec(Scatter, alpha=0.2), which is nice.

also for future reference, instead of
grd_lay = layout.content[1].content # get the `GridLayout`
lax = grd_lay.content[1].content # get the `LAxis`

you can now do
grd_lay = contents(layout)[1]
lax = contents(grd_lay)[1]

Closed by #155


How to write the label file?

Hi,
I couldn't figure out from the Readme.md and
https://github.com/zalandoresearch/disentangling_conditional_gans/blob/03d5101ba63ed223d310e42584545bb1d53077e0/dataset.py#L89
about how the label file should be written as. From reading the paper, I understand that your Disentangling Conditional GAN perfoms color regression rather than categorical classification.
From https://github.com/zalandoresearch/disentangling_conditional_gans/blob/03d5101ba63ed223d310e42584545bb1d53077e0/dataset_tool.py#L636, I figure that labels is a pickle dump of a dictionary. Are the keys of this dictionary names of the images and values of this dictionary numpy arrays of RGB values?

Yes, in the paper, we perform color regression. The dictionary structure is as you have described, the keys are the file name of an image, and the values are the average RGB color of the associated object in the image. I will create an updated branch soon with an example toy dataset, I hope it will be clearer for you as well.

Could you comment on the timeline for this toy implementation?


Addition Apple M1 Pro Issues

Describe the bug
It appears that this library has some additional issues when running on a machined powered by Apple M1 Pro.
modelline
ends up being 'Apple M1 Pro' on a new Mac Book Pro,  which never contains an @.. this means the result of  modelline.split('@') will be null, causing https://github.com/sebhildebrandt/systeminformation/blob/57c7d9af587435a3c626817be7e27617f451e397/lib/cpu.js#L612 to fail with when attempting to index into null.
Machine Details:
Environment (please complete the following information):

Node 14.17.5

@stefanpenner ... hmmm interesting, as my main machine is a Apple M1 Pro machine ... I cannot reproduce the error:
In file cpu.js
const modelline = util.getValue(lines, 'machdep.cpu.brand_string');

indeed returns Apple M1 Pro
and the next line
const modellineParts = modelline.split('@');

retuns [ 'Apple M1 Pro' ]
so the next 2 following lines are also fine:
result.brand = modellineParts[0].trim();
const speed = modellineParts[1] ? modellineParts[1].trim() : '0';

The array has only the length of 0 but this is covered by checking if modellineParts[1] exists ...
With the current version I get the following result:
{
  manufacturer: 'Apple',
  brand: 'M1 Pro',
  vendor: 'Apple',
  family: '458787763',
  model: '',
  stepping: '4',
  revision: '',
  voltage: '',
  speed: 2.4,
  speedMin: 2.4,
  speedMax: 2.4,
  governor: '',
  cores: 10,
  physicalCores: 10,
  processors: 1,
  socket: 'SOC',
  flags: '',
  virtualization: false,
  cache: { l1d: 131072, l1i: 65536, l2: 4194304, l3: null },
  efficiencyCores: 2,
  performanceCores: 8
}

Did I miss something? I do not see anything failing. Maybe I understood your message ...

@stefanpenner ... as I cannot reproduce this on any of my M1 machines I will close this for now (see explanation above). If you still see problems, please reopen this issue and provide a little more error messages and information. Thank you so much.

@stefanpenner sure. Whenever you have more info, feel free to reopen this issue. I am highly interested in fixing issues and make this library as stable as possible. Best regards.

While testing the issue that @stefanpenner found I was able to reproduce this error.

Looking at where the error is thrown I see:
// ...
const modelline = util.getValue(lines, 'machdep.cpu.brand_string');
result.brand = modelline.split('@')[0].trim();
result.speed = modelline.split('@')[1].trim();
// ...

Which  as modelline for an M1 is Apple M1 Pro that second split will not work. This is fixed in newer versions as we were on v4.21.2 (https://github.com/sebhildebrandt/systeminformation/blob/v4.21.2/lib/cpu.js#L415-L417)

Thanks, @thoov clearly, I got myself turned around thinking i was fully upgraded when I wasn't. My bad.


Add Label Schema Support

Adds basic calls for label schema support in label endpoints.

Thanks Pablo!
On Tue, May 31, 2022, 8:15 AM PJEstrada @.***> wrote:

Merged #27 https://github.com/diffgram/python-sdk/pull/27 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/diffgram/python-sdk/pull/27#event-6710562770, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEJ6DJFME66G6OYLZ3SSRVLVMYUIVANCNFSM5XN4B2AA
.
You are receiving this because your review was requested.Message ID:
@.***>


chore(deps): update common-dev-assets digest to d354121

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
a043dc4 -> d354121

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline


[BugFix] Fix key index out of bound in schema of _do_merge_horizontally.

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #13935
Problem Summary(Required) ：

potential array index out of bound. should be an iota array of sort key indexes, not sort key indexes directly.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_be_unittest

starrocks_fe_unittest

run starrocks_admit_test


applicationinsights update

Hi! I was wondering if if you got working applicationinsights v3 or what would be the migration guide (might be this one https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-nodejs-migrate?tabs=cleaninstall?) to make it work with this implementation.
Thanks!

Hi! No I haven't revisited this in a while so not tried to migrate yet. I vaguely remember when setting up the template that the various App Insights libraries were in a bit of flux, with the client instrumentation libraries being "behind" the server instrumentation libraries and it was a bit confusing as to what was the "recommended" setup for a Node app.
I do remember trying to add the Open Telemetry packages and having some success, but can't remember what it was exactly that made me switch back to the v2 packages. I have just found an old stash from the time and have committed it on this branch if you want to take a look at it. I haven't tested it out since I worked on it in February, but thought it may be useful even if you can at least see what i was trying to do to initialise the Azure Monitor on the server.
The doc you have linked to looks like it may be a good starting point for migrating the server instrumentation, but it doesn't look super clear to me - I think I'd just have to try it out, but also following the getting started docs and configuration docs.
Having a quick look now it seems the client libraries are catching up with the server so I probably need to come back and update this template soon.
Sorry that's not much practical help. Good luck!


Intellisense suggests imported names which should be considered an implementation detail

PEP-8 mentions

Imported names should always be considered an implementation detail

When I have
# b.py
import c

x = 1

and I create
# a.py
import b
b. # intellisense shows c and x, but c should be considered an implementation detail

I don't actually mind that c is shown, because I expect that some code doesn't consider imports an implementation detail, e.g. __init__.py, but I think it would be more useful if all the imported names were at the bottom of the list.
Perhaps the order could be something like this:

Everything in __all__
All non imported names
All imported names

Even better would be if the names intellisense thinks might be private are greyed slightly (It could be a good way to solve https://github.com/microsoft/python-language-server/issues/619)
Pylance version: Pylance language server 2021.9.3 (pyright d2771b18)
OS version: WIndows 10
Python version: 3.8.10

The Intellisense mechanism in pylance does enforce this convention for "py.typed" libraries and for type stubs. In these cases, it does not offer these imported symbols as completion suggestions unless they are included in __all__ or use a redundant aliased form of import (e.g. from x import y as y) as documented in PEP 484. For more details about which library symbols are considered private by pylance, please refer to this documentation.
While PEP 8 does suggest that imported names should be considered an implementation detail, we've found that most libraries (especially those that are not "py.typed") do not follow this convention. If we were to enforce this convention more generally, I can assure you that we'd receive a deluge of bug reports from unhappy pylance users!

Ok, thanks for the link, I was not aware of "py.typed". I've added it to my package but it doesn't seem to help, I assume that's because it only works inter-package, my use case is two modules in the same package.
Given that most libraries don't follow that convention, would it be fine to just make imported names a lower priority in the list of suggestions?

Yes, "py.typed" applies only to packages installed within your Python environment.
We will discuss your suggestion, but my educated guess is that most pylance users will not want us to deprioritize these symbols in the suggestion list. We might be able to validate (or refute) that hypothesis through an experiment using telemetry-based feedback.
It's unfortunate that Python doesn't have an export keyword or some other way of specifying explicitly which symbols are intended to be exported. Other languages like TypeScript have this support.

Regardless of the prioritization, I think it would make sense to also consider user-code with py.typed to be py.typed like we do libraries; that's how I thought it was already. Otherwise, one editing a py.typed library won't know that they are writing code that is mistakenly incompatible with importers.

@erictraut It would be nice if there were an option where users could specify packages for which Pylance's default "export inference" rules could be overridden. This is because your reasoning here is still true even of library authors who include py.typed:

While PEP 8 does suggest that imported names should be considered an implementation detail, we've found that most libraries (especially those that are not "py.typed") do not follow this convention. If we were to enforce this convention more generally, I can assure you that we'd receive a deluge of bug reports from unhappy pylance users!

This is probably because PEP 561 (which defines py.typed and is the official reference for how to package type information) says nothing about __all__ or privacy. So for many it is a complete surprise that Pylance modulates privacy rules based on the presence of py.typed.
As a result, there are nicely-typed libraries out there for which Pylance hides almost all of the public interface from autocomplete.

We do enforce this for type stubs and py.typed libraries, the practice of reexporting imported symbols is too common in most Python code for us to enforce this.

@judej @erictraut coming back to this, I'm finding my team is doing things like this
from x import thing as _thing

Is that the Pylance recommended workaround?
Is it really a problem to put the imported names at the bottom of the intellisense list? Even if it's just for py.typed projects?

I'm new to python, and it would be very useful to be able to filter out these implementation details from Intellisense autocomplete, even if it's a setting I have to opt into. Such as it is I'm resorting to what seems like a step backwards in code quality.
I would like to know what is preferred, because I tend to make a lot of modules with just a few or even just one method being intentionally exported, and I just dislike all of the clutter that comes with seeing everything that has been declared in the auto completion list.


Dbeaver began to make a slow opening on Citrix machines

Description
Dbeaver began to make a slow opening on Citrix machines
DBeaver Version
24.0.3
Operating System
windows 10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Please describe your issue in more details? How slow is it? Do you have some editor open on start?

I will wait new version of Dbeaver and will try thanks
10 May 2024 Cum 17:44 tarihinde ShadelessFox @.***>
şunu yazdı:

Unfortunately, we don't have Citrix machines to reproduce this issue. Can
you please record a thread dump to see what's happening behind the scenes?
You can find instructions here:
https://github.com/dbeaver/dbeaver/wiki/Making-a-thread-dump.
By the way, are you a paid customer? The issue might be related to DBeaver
having a hard time accessing our license server to validate your license.
—
Reply to this email directly, view it on GitHub
https://github.com/dbeaver/dbeaver/issues/30091#issuecomment-2104737557,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIECORZSFLMHYGVDQUZZU63ZBTMNDAVCNFSM6AAAAABHO6U5CCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUG4ZTONJVG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


NameError: name 'TextGenerationModel' is not defined

As I'm presently creating a workshop for the Google Developer Group (GDG), I'm facing a few challenges. Specifically, I'm having trouble executing this particular notebook: language/intro_palm_api.ipynb.
Despite having installed google-cloud-aiplatform, I'm attempting to run the following
import pandas as pd
import seaborn as sns
from IPython.display import Markdown, display
from sklearn.metrics.pairwise import cosine_similarity
from vertexai.preview.language_models import (ChatModel, InputOutputTextPair,
                                              TextEmbeddingModel,
                                              TextGenerationModel)

generation_model = TextGenerationModel.from_pretrained("text-bison@001")

Unfortunately, I encounter the subsequent error:
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Cell In[3], line 1
----> 1 generation_model = TextGenerationModel.from_pretrained("text-bison@001")

NameError: name 'TextGenerationModel' is not defined

Could you provide some guidance on how to rectify this issue?

It appears that the recent upgrade to version 1.27.0 of the google-cloud-aiplatform library may be the root of our current issue, as I haven't encountered this problem with version 1.26.0. To circumvent such complications in the future, I propose that we establish a requirements.txt file. This approach would help to ensure we're all working with the same, consistent set of library versions.

I've pinpointed the source of the issue. Initially, I attempted to authenticate using my user account, which had the necessary permissions. Nevertheless, it appears the library demands the use of a service account. The moment I switched from the user account to the service account, everything started working as expected.


Cargo 0.21.0 Hanging while compiling without RUST_LOG=debug

On Freebsd 12.0 whenever attempting to cargo build or cargo run a semi brand-new cargo new test --bin project, the compilation will hang seemingly indefinitely (10+ minutes).
I did notice, however, if Cargo.lock and the target/ directory were both deleted while RUST_LOG=debug then the package would compile. If, however, either target/ or Cargo.lock were in the path, cargo would hang indefinitely.
Whenever attempting to build or run, I would get output like this:
ian@home ~/D/torrential> cargo build -v
   Compiling torrential v0.1.0 (file:///usr/home/ian/Development/torrential)
     Running `rustc --crate-name torrential src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=b0bc5ad4bb1a8134 -C extra-filename=-b0bc5ad4bb1a8134 --out-dir /usr/home/ian/Development/torrential/target/debug/deps -L dependency=/usr/home/ian/Development/torrential/target/debug/deps`

which is where it would hang.
If attempting to build with RUST_LOG=debug, it would hang around:
Stability interner: #3
Layout interner: #41
INFO:rustc_metadata::cstore: topological ordering: [CrateNum(2), CrateNum(5), CrateNum(4), CrateNum(7), CrateNum(8), CrateNum(11), CrateNum(6), CrateNum(10), CrateNum(3), CrateNum(9), CrateNum(1)]
INFO:rustc_metadata::cstore: topological ordering: [CrateNum(2), CrateNum(5), CrateNum(4), CrateNum(7), CrateNum(8), CrateNum(11), CrateNum(6), CrateNum(10), CrateNum(3), CrateNum(9), CrateNum(1)]
INFO:rustc_metadata::cstore: topological ordering: [CrateNum(2), CrateNum(5), CrateNum(4), CrateNum(7), CrateNum(8), CrateNum(11), CrateNum(6), CrateNum(10), CrateNum(3), CrateNum(9), CrateNum(1)]

I'm using cargo 0.21.0 (5b4b8b2ae 2017-08-12)
If any other questions are needing to be answered to shed some light, just let me know and I'd be happy to supply further info!
Thanks!

Rust on FreeBSD 12 has some libc-related problems, which is probably what's going on here. There are rust-builds being posted in rust-lang/rust#42681, maybe you could try building cargo with those and then try compiling your crate. We are probably out of luck with debugging Cargo as long as Rust itself is unstable on FreeBSD 12.

rust-lang/rust#44433 is probably what's going on here.

@lukaslueg I don't doubt these in the slightest, but the most confusing part to me was this: why would the project compile whenever I removed the Cargo.lock? Whenever I looked at the Cargo.lock file, it seemed very innocuous and nothing arch specific, compiler hints, &c.
Even with RUST_LOG=debug, the compiler could hang, so the title of this issue may not necessarily best reflect what was happening.

Different code paths may or may not get exposed to what is essentially undefined behavior. One can be happy to get a crash right away in such situations.
My point being that there is little use to actually debug this situation in Cargo, as long as the implementation of stdlib can't be trusted. I'm afraid we have to wait for rust-lang/rust#44433 and rust-lang/rust#42681 to settle.

@lukaslueg Ahh, that makes sense. Guess it's back to ubuntu for me for the foreseeable future.

Closing as it sounds like this isn't Cargo-related


Crash on timeout

I've noticed several restarts on one particular server in the farm, which coincidentally has rather high I/O load. I've learned that my initial idea of 500ms timeout was too optimistic. Still, it seems that dynomite just crashes if that timeout is reached, so maybe someone can investigate what's going on. v0.6.5 talking to Redis on localhost.
[2018-02-28 10:35:44.532] client_unref_internal_try_put:94 <CONN_CLIENT 0x55bb28277f40 -1 from '<IP_ADDRESS>:33012'> unref owner <POOL 0x55bb281db0f0 'dyn_o_mite'>
[2018-02-28 10:36:37.802] core_timeout:478 <REQ 0x55bb282e3980 1681593:0::0 REQ_REDIS_HMSET, len:544> on <CONN_SERVER 0x55bb281dbed0 11 to '<IP_ADDRESS>:6378:1'> timedout, timeout was 500
[2018-02-28 10:36:37.803] server_close:269 close <CONN_SERVER 0x55bb281dbed0 11 to '<IP_ADDRESS>:6378:1'> Dropped 39 outqueue & 0 inqueue requests
[2018-02-28 10:36:37.803] event_del_conn:234 epoll ctl on e 9 sd 11 failed: No such file or directory
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] dnode_rsp_send_next:459 OOM to obtain an mbuf for encryption!
[2018-02-28 10:36:37.803] client_unref_internal_try_put:94 <CONN_CLIENT 0x55bb283b5210 -1 from '<IP_ADDRESS>:33022'> unref owner <POOL 0x55bb281db0f0 'dyn_o_mite'>
[2018-02-28 10:36:37.824] dn_stacktrace:326 [0] /lib/x86_64-linux-gnu/libpthread.so.0(+0x110c0) [0x7f83d3dfe0c0]
??:0
[2018-02-28 10:36:37.985] dn_stacktrace:326 [1] dynomite(rsp_send_next+0x4a) [0x55bb276dd25a]
??:0
[2018-02-28 10:36:37.988] dn_stacktrace:326 [2] dynomite(+0x18064) [0x55bb276d5064]
??:0
[2018-02-28 10:36:37.991] dn_stacktrace:326 [3] dynomite(msg_send+0x3d) [0x55bb276dc5bd]
??:0
[2018-02-28 10:36:37.993] dn_stacktrace:326 [4] dynomite(core_core+0x58) [0x55bb276d37c8]
??:0
[2018-02-28 10:36:37.996] dn_stacktrace:326 [5] dynomite(event_wait+0xf5) [0x55bb276f25a5]
??:0
[2018-02-28 10:36:37.998] dn_stacktrace:326 [6] dynomite(core_loop+0xff) [0x55bb276d40ef]
??:0
[2018-02-28 10:36:38.000] dn_stacktrace:326 [7] dynomite(main+0x6e0) [0x55bb276cd470]
??:0
[2018-02-28 10:36:38.001] dn_stacktrace:326 [8] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7f83d376a2b1]
??:0
[2018-02-28 10:36:38.003] dn_stacktrace:326 [9] dynomite(_start+0x2a) [0x55bb276cd88a]
??:0
[2018-02-28 10:36:38.013] signal_handler:132 signal 11 (SIGSEGV) received, core dumping

Can you give it a try with the latest version v0.6.7? This most probably has been resolved by https://github.com/Netflix/dynomite/pull/562

Hello @ipapapa and thanks for fixing the bug!
Unfortunately, dynomite has an important role right now, so I can't easily test, atm. But, might be able to do it in the future, if I do, I'll let you know the results.

One more thing, I'm already running v0.6.7 and have been for some months. I don't see that PR #562 is included in that version, being commited only some weeks ago? I suppose you will release new version with the fix?

OK, with v0.6.8 released, I will now test for this bug again and report back. Stay tuned...

23 dynomite instances,running for more than a week and not a single crash.
I consider this case closed, good job @shailesh33!


Smart Button "Run Workflow" does not show in Unified Client

I'm using the latest version of the smart button solution but smart buttons will not show in the unified client even though I've deleted the display rules from the command. Any suggestions on how to resolve this?
Thanks a lot!

Have you followed the steps on https://www.develop1.net/public/post/2018/04/06/Adding-Ribbon-Workbench-SmartButtons-to-the-Unified-Client


fix: updating github.com/containers/image to 5.32.2 to resolve OCPTOOLS-462, OCPTOOLS-463

updating github.com/containers/image to 5.32.2 from 5.29.2 to resolve CVE-2024-3727 in OCPTOOLS-462 and OCPTOOLS-463

/lgtm


[dart2js] issue with global inference and labels

(original issue at https://github.com/flutter/flutter/issues/96394)
Global type inference in dart2js seems to create invalid control flow conclusions in programs using labels. Here is a very simple example showing this problem:
helper(num c) => c * -1;

void main() {
  num a = 3;

  label:
  {
    break label;
  }

  print(a * -1);
  print(helper(a));
  return;
}

Locally this example fails unless you disable global type inference. The code fails with the following error:
/usr/local/google/home/sigmund/dart/git_all/sdk/sdk/lib/_internal/js_runtime/lib/preambles/d8.js:263: TypeError: c.$mul is not a function
          throw e;
          ^
TypeError: c.$mul is not a function
    at Object.helper (/tmp/out.js:2142:16)
    at main (/tmp/out.js:2147:17)
    at action (sdk/lib/_internal/js_runtime/lib/preambles/d8.js:275:31)
    at eventLoop (sdk/lib/_internal/js_runtime/lib/preambles/d8.js:258:9)
    at self.dartMainRunner (sdk/lib/_internal/js_runtime/lib/preambles/d8.js:276:5)
    at /tmp/out.js:2525:7
    at /tmp/out.js:2510:7
    at dartProgram (/tmp/out.js:2521:5)
    at /tmp/out.js:2529:3

Thanks, this is really helpful. I haven't spent much time looking at how global type inference handles simple control flow constructs (as opposed to things like function calls), so this gives me a place to start.

I was having some trouble debugging this - I couldn't observe us visiting the calls to print or helper. Turns out it's because we weren't visiting them at all during inference! The culprit is here: https://github.com/dart-lang/sdk/blob/ab84be0a888480ff4d05833fbbcfc3d99709968a/pkg/compiler/lib/src/inferrer/builder_kernel.dart#L478
Here is the definition of aborts: https://github.com/dart-lang/sdk/blob/ab84be0a888480ff4d05833fbbcfc3d99709968a/pkg/compiler/lib/src/inferrer/builder_kernel.dart#L2332-L2334
When we visit the labeled block, we hit the break statement and set seenBreakOrContinue, as expected. (If there were code after the break, this would save us from having to visit it since the break aborts the block.) The problem is, when we leave the block, seenBreakOrContinue is still set, so we abort inferring the rest of the body of main as well.
At the moment, we only remember that at least one break/continue was seen; we don't record where they occur or where they jump to. Two solutions I can think of:

Delete the first line of code above and don't stop inferring the rest of a block when _state.aborts is set. (Perhaps we can still abort the inference if seenReturnOrThrow is set.) This does mean that we may perform some unnecessary inference.
Handle this similar to try/catch. The present situation is similar to assuming that no exception is ever caught. Instead, we can treat a labeled statement like a try, a break like an exception, and consider the "exception" caught if the break matches the label.

Option 2 doesn't seem too bad to implement and a lot of the scaffolding is already in place, so I'm going to try and move forward with that.


Flutter - Android Studio - Cocoapods not installed error

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Run Android Studio project
Actual results
Hi all,
I keep getting the following error in Android studio while building a flutter project. I'm working on a mac...
Any help would be much appreciated...
**Launching lib/main.dart on iPhone 14 in debug mode...
Warning: CocoaPods not installed. Skipping pod install.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.**

**CocoaPods not installed or not in valid state.
Error launching application on iPhone 14.**

I Tried
sudo gem uninstall cocoapods && sudo gem install cocoapods'

I ran flutter doctor and get the following message...
Flutter (Channel stable, 3.13.1, on macOS 13.5 22G74 darwin-x64, locale
en-GB)
Android toolchain - develop for Android devices (Android SDK version 34.0.0)
Xcode - develop for iOS and macOS (Xcode 14.3.1)
CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin
code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install see
https://guides.cocoapods.org/using/getting-started.html#installation for
instructions.
Chrome - develop for the web
Android Studio (version 2022.3)
VS Code (version 1.81.1)
Connected device (3 available)
Network resources

Doctor found issues in 1 category.

Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output

<!-- Paste your output here -->

Hi @Superuser77SU
Have you tried restarting Android Studio and then retrying? Please check answers from this SO thread to see if there is any solution fit to yours.

Highjacking this bug. I have quiet often randomly the same error CocoaPods not installed or not in valid state. when I try to run my Flutter app as MacOS App. I always have to restart Android Studio. This is anoying as hell. Please fix this. I have this error since at least 6 month (always with the latest version)

@rekire Could you share the output of flutter doctor -v? We need more detailed information to reproduce and verify the issue. Thanks!

Right now I do not have the problem, but here is my current output:
[✓] Flutter (Channel stable, 3.13.4, on macOS 13.5.2 22G91 darwin-arm64, locale de-DE)
    • Flutter version 3.13.4 on channel stable at /Users/rekire/dev/flutter
    • Upstream repository<EMAIL_ADDRESS>    • FLUTTER_GIT_URL =<EMAIL_ADDRESS>    • Framework revision 367f9ea16b (vor 9 Tagen), 2023-09-12 23:27:53 -0500
    • Engine revision 9064459a8b
    • Dart version 3.1.2
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/rekire/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/rekire/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/rekire/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.5.2 22G91 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 116.0.5845.187

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I will rerun it the next time it happens, but I guess the result should be the same,

I had similar trouble running flutter doctor -v and installing cocoapods using sudo gem install cocoapods.

I solved it using these steps:

Install Ruby with Homebrew: Start by installing Ruby using Homebrew. Run brew install ruby in your terminal.

Update Your PATH: Add the newly installed Ruby to your system's PATH so that it's recognized. Run export PATH="/usr/local/opt/ruby/bin:$PATH".

Install CocoaPods: Now, you should be able to install CocoaPods successfully with sudo gem install cocoapods.

Link CocoaPods (if needed): In some cases, you might need to link CocoaPods with Homebrew. You can do this by running either brew link cocoapods or brew link --overwrite cocoapods.

Re-run flutter doctor -v: Finally, re-run flutter doctor -v in your terminal to make sure everything is working correctly.


feat: rules are exported

Description
We have a custom set of requirements, but many of the already implemented rules are already super helpful.
Sadly the rules are not exported, so one would have to either copy them or implement them on your own.
Use Case
We have a custom set of rules that apply within our company. So we want to build a custom internal rule pack, combined of custom rules and already existing ones.
Proposed Solution
Export the rules, or make them available in a separate package.
Other information
Currently using the newly release v2 compatible version
Acknowledge

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

From what I understand you would like to

Create your own NagPack on an as needed basis without the need for rebuilding the package
Pull from the existing rules and apply them to the NagPack
Create your own rules and apply them to the NagPack

Is that correct?
The drawback with this approach is that unless you build your own package, it would be difficult to scale this across multiple applications without re-implementing the rule additions on each application (though it could be as simple as a copy and paste of the class)
That being said, it could be a good opportunity to move the rule creation helper methods to a package with the rules.

Yes that is correct.
Also the plan is not to have it per application, but we use a shared cdk lib within the company that takes care of the checks, so we only implement it in one place.
I found another variant to achieve something similar:
I'm adding eg the NagPack provided by cdk-nag, but also add an aspect to add suppressions for rules that are not important / relevant for my organization. With that all new rules added would be auto enabled, which can be good to increase coverage, but of course also lead to new rules added that should have been hidden for my org.


Pending Tests Integration for CI/CD

Tests for the different code blocks are backlogged.
completing the tests for the code block and then going forward into development.
All tests would be added to a single PR #41
Test coverage Tracker
Pages Directory

[x]  HomePage.dart
[x]  BlogPage.dart

Components Directory

[x]  Button.dart
[x] LightBox.dart
[x] MenuBar.dart
[x] NameIconWidget.dart
[x] SideBar.dart

Components/paint directory

[ ]  ButtonAnimation.dart
[ ] CircleMatrix.dart
[ ] Techlines.dart

Components/blogPage/ directory

[ ] FeaturedPostTileComponents.dart
[ ] TopicsTileComponents.dart

Going forward with normal dev.... repoing the issue later..../since no major issue found/.


How to navigate to specific page when accept interaction happened and app closed/terminated state

I have designed an application and when the notification by FCM reaches the mobile, the mobile rings. For the Accept event, I wrote my own custom code and when the application is open in the background or open, it shows the correct interaction, but when the application is closed, when I click on the Accept button, the app runs from the beginning and none of the tasks I want to do. It doesn't happen

I have same problem

I have same problem

I have designed an application and when the notification by FCM reaches the mobile, the mobile rings. For the Accept event, I wrote my own custom code and when the application is open in the background or open, it shows the correct interaction, but when the application is closed, when I click on the Accept button, the app runs from the beginning and none of the tasks I want to do. It doesn't happen

Got any solution ?

same issue

Are you guys get any solution?


numpy in1d

Any chance of numpy in1d being supported?

Upvote for this one: I also typically only use the two arg version.

@CJ-Wright I implemented a in1d version (or exactly the opposite).
https://stackoverflow.com/a/53083946/4045774

xref: https://github.com/numba/numba/issues/4074 tracking NumPy function support.


Resolves issue #147 At-will spells not appearing in Spellcasting text

This resolves #147.
I've updated isSpellcaster(), isInnateSpellcaster(), isWarlock() and hasAtWillSpells() to all reference item.data.data.preparation.mode instead of item.data.preparation.mode.
The first three methods do not appear to be used anywhere, but I wanted to update the methods anyway as item.data.preparation will always be null.

It looks like those all got factored out when I created CastingPreper and unified the spellcasting feature handling. I've removed them. I'm somewhat unsure if I should leave hasAtWillSpells where it is, or move it to CastingPreper. I guess I'l leave it for now.


Existing docs for python examples w reflection do not work

What version of gRPC and what language are you using?
grpcio==1.49.1

What operating system (Linux, Windows,...) and version?
Ubuntu 22.04 LTS

What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.10.4

What did you do?
# instructions: https://grpc.io/docs/languages/python/quickstart/
git clone -b v1.48.1 --depth 1 --shallow-submodules https://github.com/grpc/grpc
cd grpc/examples/python/helloworld

# Requirements instructions: https://github.com/grpc/grpc/blob/master/doc/python/server_reflection.md
pip install grpcio-reflection

python greeter_server_with_reflection.py

What did you expect to see?
The server would work and produce a Traceback.
What did you see instead?
Traceback (most recent call last):
  File "/home/user/grpc_project/greeter_server_with_reflection.py", line 21, in <module>
    import helloworld_pb2
  File "/home/user/grpc_project/helloworld_pb2.py", line 35, in <module>
    _descriptor.FieldDescriptor(
  File "/home/joaquin/.pyenv/versions/greeter-3.10.4/lib/python3.10/site-packages/google/protobuf/descriptor.py", line 560, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

Anything else we should know about your project / environment?
There needs to be instructions that install the compatible versions of modules that work with existing code, and existing code needs to be brought up to date to work with current vresions of modules.  Need to know the correct version of grpcio-reflection to use.

Yup. This is a docs bug. The latest release of grpc is compatible with protobuf 4.X and the generated code on the 1.49.x branch is only protobuf 4.X compatible.
Please try cloning with -b v1.49.1 instead of -b v1.49.1

The site has been updated, so this should no longer be an issue.


Voice Chat Glitch

I've been using Comfy for about a month and recently it's been doing this with the voice chat avatars when the category is collapsed:

The avatars also push off the channel bar and disappear when there are more than 6 people in the call instead of making a new line like normal Discord does.

The same thing happens if you create a private channel

like the little avatars to show who has access to the channel

Looks like I can't reproduce your issue 🤔 Is it some themes/plugins/custom css interfering ?

Doesn't look like it, I don't have custom css and I turned all my plugins and themes off and still got this:

I also checked to see if it was my theme settings and/or that I was using an older version of the theme by downloading it and trying it and I still got the issue on a fresh downloaded version:

I ended by removing all masks in Discord and from what I experienced, there's no issues for now so this should be fixed ig

Yep, looks like it's fixed! Thank you!


Prevent the removal of variables

When the editor is in the lockText mode it should not be possible to completely remove a variable.

I believe this is supported, closing.


Infer QueryBuilderType for any method returning QueryBuilder: revive with cache

Attempt to resolve https://github.com/phpstan/phpstan-doctrine/issues/517 by visiting each method only once.

Thank you.


DataConnector does NOT work in the Service

Following the instructions everything seemed to be fine. My Power BI API Connector shows up in the personal gateway, the personal mode is online and data source credentials were accepted. However, updates always fail: "This feature is not supported. Make sure you are running the latest gateway version."
Well, my version is May 2018.

Hi Frank-  I ran into a similar issue today.  I found that only "Import" mode is supported currently for the gateway.  I'm not sure if that's the same issue you're running into, but thought I would pass that along.
"When running in Personal mode, the gateway can be used to support scheduled data refresh for sources that use an Import mode. Note that Direct Query sources require the use of an Enterprise Gateway, which will be supported in a subsequent release."
from:
https://github.com/Microsoft/DataConnectors/blob/master/docs/m-extensions.md#data-source-kind
Hope that helps!

Okay, the June 2018 update fixed it.


Expose models to import

Could you please expose the Command (and any other publicly-usable model) to import? I wouldn't mind something like this:
import * as cp from 'commandpost';

setupOneCmd(): cp.Command {
  // make and return a cp.Command
}

Thanks!

sorry for late response.
I just released v1.2.0. please check it.


Add validation of existence for a resource provided in feedback

The provided feedback should contain only entities existing in the available bases, including those that were newly proposed by the user.
It is unrealistic to check this before the algorithm run, but when an entity in the feedback has no presence in the KBs when met during the algortihm run, this should be at least reported.

Ready for disambiguations (we ask for entity into database), not available for classifications, relations


CAT:PHSH vs CAT:PHISH

While I was inspecting some headers I found there was one header with CAT:PHISH opposed to the CAT:PHSH stated here in the documentation.
Are both valid or is only CAT:PHISH valid?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e47e11dd-53ab-5f62-ac6c-59dbc00eed0d
Version Independent ID: 362ad038-3b64-f342-2f8e-111635c4337d
Content: Anti-spam message headers
Content Source: microsoft-365/security/office-365-security/anti-spam-message-headers.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@Mr-Pingu  - Thank you for submitting feedback.
I will get this issue over to the Microsoft 365 writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hello, @Mr-Pingu Thank you for your query here. Please note there are many headers not listed in this document and they are internal and only used by Microsoft anti-spam team for diagnostic purposes.
This was also addressed in another same query. Please see https://github.com/MicrosoftDocs/microsoft-365-docs/issues/486#issuecomment-540828898
Thanks.
@mypil FYI Please.


[Feature][UI] Custom timezone

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

Add the timezone selete on the right header, when user change timezone info, call the updateUser interface to update.

DAG scheduler time optimization.

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

In my personal opinion, the time zone should be placed in the user's drop-down menu. After clicking, it will jump to a time zone page. There are the currently selected time zone and the editing time zone. Later, the time of all 24 time zones can be listed, which is convenient for users to view. .

Thanks.

Thanks.

Thanks.

Thanks. I'll deal with this later.

Thanks. I'll deal with this later.

@songjianet Thanks, and you can put some good ideas into it if you want.

 What kind of effect does the page after pulling down and expanding here show?

Here you can drop down to select a different time zone, the time zone list can refer to the time zone list of DAG;


Added javadocs to csv processor & codec, added README to csv processor

Signed-off-by: Finn Roblin<EMAIL_ADDRESS>Description
Add documentation for csv-processor and csv codec plugins — updated S3 Source README with information about csv codec, added README to csv-processor, added javadocs to classes.
Issues Resolved
Resolves #1619
Check List

[X] New functionality includes testing.
[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1658 (d84b060) into main (78ee8ad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1658   +/-   ##
=========================================
  Coverage     93.75%   93.75%
  Complexity     1272     1272
=========================================
  Files           167      167
  Lines          3652     3652
  Branches        292      292
=========================================
  Hits           3424     3424
  Misses          159      159
  Partials         69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Get wrong channel on DMX receive mode

Hello Matthias,
thanks for that great library working very good for me but i have one small thing.
I have written an small code to create an multifunctional DMX Box.
I opened an task in mikrocontroller.net because sometime the channel 13 instead of channel 12 which is defined get been readed.  https://www.mikrocontroller.net/topic/476080#5877510
There it seems that nobody can help me with this issue.
The constant flickering is removed by changing the LED libary to WS2801.
Hope you can help me.
Thanks a lot

The problem with WS2801 aka NeoPixels is that you need a very specific timing to send information to the LEDs. These libraries often disable interrupts while sending. Especially when there are many LEDs on one line this interferes with the timing needed for DMX.
Please have a look into the example https://github.com/mathertel/DMXSerial/tree/master/examples/DmxSerialNeoPixels that is using the new probe mode. Here the whole DMX is received, the DMX receiving is stopped and the WS2801 data is sent out. Then listening for DMX data is restarted. You may miss a DMX sequence but it will not be corrupted.
Another option that may work is to use hardware DMA based sending of the WS2801 data that seems to be  possible with processors supporting DMA like megaavr 4809 (Arduino Every board).


How to decrease the size of the built android apk?

Hi baldurk ，i built the v1.5 android apk with my macbook, the org.renderdoc.renderdoccmd.arm32.apk i built is about 80M, and i can't use this apk to inject to any game on my android phone, i am not sure if it's the size that is too large for injection. So how i can make it as small as your release version, it's only 5.5M。

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


React 0.13.x support?

Does formsy-react have a specific dependancy on React 0.14 features, or would it be possible to loosen this to allow formsy-react to be used with React 0.13 if the parent app calls for it?
There are quite a number of 3rd party libs / apps that haven't caught up yet, meaning this can't be used with them (or rather only at version 0.14.1).

formsy-react v0.15 and up rely on React 0.14 parent context types. You can make 0.17 work on 0.13.x if you replace {this.props.children} in main.js render() with  {this.traverseChildrenAndRegisterInputs(this.props.children)}
then replace all references to this.context.formsy.**methodname** in Mixin.js with this.props._**methodname**

@arush - thanks. @christianalfoni - would you be happy to release 0.14.2 if I submit this as a PR against 0.14.1?


'Functional' object has no attribute 'fit_generator'

Hi,
After I upgrade keras to keras 3, I notice that the attribute "fit_generator" has been removed (I can't find it in any file in keras3 with grep) which doesn't been mentioned in release announcement or this issue. I'm wondering if it will be brought back in future or not.
Thanks.

So after I read through keras 3 API documentation, I found a new class keras.utils.PyDataset replaced the old class keras.utils.Sequence, and it can be used in attribute fit directly.


Generic

Site-wide, non-page-specific issues

Generally the idea of an epic is for specific functionally that is too big to be one issue. It gets broken down into issues/tasks. The navbar would just be a stand alone issue otherwise this epic would never get closed.


Conflicting versions of the Apache HTTP Client

The main pom.xml file has both the deprecated Apache HTTP Client:

commons-httpclient
commons-httpclient
3.1

and the new one:

org.apache.httpcomponents
httpclient
4.5.1

While I agree having different dependencies like this is not desired, is there a particular error or confusion that comes out of them both being present? (that helps prioritize fixes)

@mmcgowan some libraries that Druid depends on still depend on the old http client, hence why we need to include it.

@xvrl which libraries?

@mmcgowan for what it's worth commons-httpclient and org.apache.httpcomponents are essentially two distinct libraries. They should not be conflicting in any way. Are you having any actual issues from depending on both?
@fjy currently the hadoop jars depend on the old commons-httpclient, but maybe we can remove that dependency explicitly unless we overrode the version for some other reason

Hi @drcrallen, @xvrl,
I see.
I've built a Druid metrics to Datadog Druid extension. It depends on Dropwizard metrics, which uses org.apache.httpcomponents:httpclient:4.3.5.
I'm currently on Druid 0.8.1. I had issues with this version. But since the two dependencies are different, it looks like this should be able to work with Druid 0.8.2.
Michael

@mmcgowan you mentioned that you have build a Datadog Druid extension.
This sounds very interesting. I searched for it but couldn't find anything.
Can you tell me anything about it? Is it open-source?
thanks
Sascha

FYI, I did a lot of dependency resolution to get 0.9.0 to work with some of our extensions. The results can be found here: https://github.com/druid-io/druid/pull/2596
This might affect how this extension manages exclusions. Hopefully the information in the PR (and expanded documentation in the PR) helps.


Odd data being recieved

I'm using ModSim as a Modbus RTU server. For some reason, extra bytes are received:

Black background = received by Modsim
White background = transmitted by Modsim
After a valid Modbus message is received ([000][001][003][000][000][000][051][005][223][000]
there is sometimes junk data that causes timeout:
[064][032[064]064]....etc.
Any thoughts?
Thanks!

Please see the parallel issue thread, where we currently are trying tosolve a very similar problem. There are 00 bytes observed before and after the message proper, exactly as you do. The original poster had Modsim employed as well, whereas @KevinDesbonnets has a real server connected.

Fixed this issue - wiring was inverted and the serial constructor was called with 'invert=true'. Obviously something weird in the serial port implementation for inversion.

Wonderful! I love issues disappearing! 🤣


Transaction list loading when creating new profile

When creating a new profile and entering the app, the transaction list loads forever

Looks like it is fixed in master


Allow for 'dry running' commands

Before committing to a change (pun absolutely intended), it is sometimes useful to validate that the changes that were made actually came out sensibly in practise.
I would like to see a configuration/environment option to commands like turbolift commit and turbolift create-prs (i.e. any write-like commands) to run them in a dry run mode. For example, the dry run commit could be a report of each git diff, and for create-prs it might be a summary of the git diff against the latest default branch.

I think I would prefer an 'end to end' dry run, rather than the step-by-step 'dry run and confirm' workflow of the previous version. This could be personal preference though, so perhaps we start there (the presence of some envar, off by default, that asks for confirmation when 'write' changes happen) and iterate upon that, re-using the functionality?

Sure, I guess it's pretty doable to collate that and emit it at the end. I'd definitely suggest doing this as a flag (like --dry-run) rather than an env var, for ease of discovery.
Maybe the thing that I was thinking of (and which the bash version did) would be better described as a --review mode. I get the distinction now!


[17.12] Remove filewatcher / fix build

Signed-off-by: Daniel Nephin<EMAIL_ADDRESS>(cherry picked from commit c0588a9c8feecf197da1478d91e8f10d26261847)
Signed-off-by: Daniel Nephin<EMAIL_ADDRESS>

17.12 reached EOL


Adding support for accounts in more countries

Adding support for accounts in more countries
Adding support for more languages
Currently we allow authentication with a set of incomplete languages
https://github.com/i2Echo/mi_iot_token/blob/b64c8dd54b3c9734795e59b9a9c049661ab89b13/lib/src/api.dart#L9
Let's add more to the list to cover most or all.
Supported mi country names can be found in the app under

Profile -> Settings -> Region

Then it needed to get converted to 2 letters, we can use one of the following sites:
https://www.iban.com/country-codes
https://www.nationsonline.org/oneworld/country_code_list.htm
https://www.datahub.io/core/country-list

Maybe we can ask for chatgpt easily. ^^

Didn't test the new version yet but I saw that you have implemented it 😄.
Thanks, will close this issue now.


Better filesGlob in tsconfig

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Atom-typscript is slow

What is the new behavior (if this is a feature change)?
Atom-typescript is a little bit faster (or at least I think it is)

Other information:
From @basarat himself:

the filesGlob should be "!node_modules/**", instead of "!node_modules/**/*.ts", Same for other excludes :rose: That should fix it for you :rocket:

More info is available on the atom-typescript faq

I don't know why 3 commits appeared. Can someone tell me why?
I merged from upstream, edited the files and committed! Should I have rebased?

thanks


How can I disable spellchecker?

How can I disable spellchecker?
Thanks.

This is not currently possible, but maybe we should create an option for it.


proposal: encoding/json supports Marshaler/Unmarshaler interfaces with a context.Context

Proposing to pass a context.Context as an argument to new json.MarshalerXXX and json.UnmarshalerXXX interfaces:
MarshalJSONXXXX(ctx context.Context) ([]byte, error)
The interface specifies a MarshalJsonXXX method that takes a context.Context argument. With a context.Context, custom marshalers can access the context and determine how to marshal the objects at run-time.
Use cases:
Many REST APIs include meta-data that controls which attributes should be included and omitted in the HTTP response body. These controls can be static, meaning the serialization behavior is specified at design time and does not change at runtime. For example, some attributes may be declared as read-only, read-write, read-on-create, write-only, create-only or no-access. A write-only property would be sent by a client in the POST request, and it would not be serialized in the response.
In other cases, the serialization behavior is dynamic and determined at runtime, based on some contextual information. For example, the OData $select operator is used by clients to specify which attributes should be returned in the response body, and other attributes are supposed to be omitted, which is useful for IoT and mobile applications. As another example, regulations and security policies may specify that some attributes must be masked or anonymized. The data masking and anonymization behavior may depend on the data sensitivity level, the role of the user accessing the data, and other runtime attributes. Specific examples of sensitive data are credit card numbers, IP addresses, serial numbers, and Personally-Identifiable Information. Furthermore, in a SaaS environment, the same API may be used by multiple end-users, and each end-user has the ability to assign a sensitivity level to various attributes.
Solutions with existing go runtime:
There are multiple approaches to solve these use cases. For static use cases, one approach is to create separate Go structs for each desired serialization output (HTTP request, HTTP response, data serialization to back-end services, etc). It is also possible to create multiple REST paths, each path providing different levels of access to the data, and assigning authorization rules, but this is still fairly static and must be determined at build time. For dynamic use cases, there is a combinatorial effect, so it's not practical to create separate go structs for each possible combination. Other serialization approaches include the use of reflection, manipulating JSON documents with map[string]interface{}, or creating an enhanced implementation of encoding/json that provides support for more customization.

I dislike the way context.Context is being used here. Most marshaling options are not request scoped, and they never leave the client in this case. Can you provide an example of how using your proposed interface solves your problem?

Cancelation makes the most sense when the operation is potentially blocking. Most Marshal and Unmarshal operations are entirely in-memory operations (it's possible that they make some blocking calls, but that is very rare). Adding a Context is a tax that everyone has to pay, and it's not a benefit most people will get.
#20280 suggested adding Context to io.Reader and friends. Those methods actually do block and make more sense to take in a context. However, many people are (understandably) opposed to complicating the API when the context is not always useful.

@as :  a HTTP handler in a go program marshals a JSON document in response to an HTTP request. To give two examples: 1) the JSON document contains some attributes that are localized (i18n); 2) some attributes need to be masked either entirely or partially, due to some per-user data masking policy. The context carries the i18n accepted language and the user information from which data masking policy is derived. There are of course multiple ways to solve this, but we found other methods required a significant amount of glue code.

Contexts are not for per-operation options. It's for timeouts and more global things like authorization credentials, not fine-grained per-call options. We pulled sql.TxOption out of context before Go 1.9 for the same reason. Think about "would this be appropriate to set and force into all operations during a given client RPC", even nested operations calling into unrelated different APIs in back ends (to gather information for the response). Unfortunately I don't know of a good post explaining this nuance with context.
More generally, the json package is almost completely done. If you need significantly extended semantics (and it seems you do), then it would be fine to copy the current one and make your own modifications, creating a new package customized to your use case.


issue 87: ensure WORKDIR exists

Building on https://github.com/openshift/imagebuilder/pull/50 this PR also ensures that the WORKDIR exists when specified.

/approve
@nalind PTAL

@TomSweeneyRedHat PTAL

@smarterclayton had a comment in #50 and that code is included in this PR.  That should be addressed and I'd feel more comfortable holding this one until @nalind gets back.  It LGTM otherwise though.


src/cli.ts is pretty boilerplate. Can we remove them?

Removing them, but adding it in a build pipeline so each package still have its own cli.

Made irrelevant by #34


Default a folder module file to index.ts w/ ES6 modules?

Hi,
Is it possible to default the file that TypeScript looks for in a folder to index.ts?
e.g.
import { Bar, Baz } from '../Foo/';

where '../Foo/' contains an index.ts that looks like:
export { Bar } from './bar';
export { Baz } from './baz';

Something similar to this: https://nodejs.org/api/modules.html#modules_folders_as_modules
Any thoughts on making something like this available?
Thanks.

This should be covered by #2338. should be available soon. so stay tuned.

awesome, thanks @mhegazy.


Updating controls to exclude checks against template DB's and to incl…

…ude the postgres user as a default authorized user.

Updated 3x controls to reflect that change - I agree, should be a better long-term solution.


I don't understand ?

Is there a way to generate svg and send it or i can only  use it inside html when i try to use it outside of html says document not found (i want to run it on the server convert the data to png and send it to the frontend(flutter)) if there is  a way could you please help me thanks.

Hi @sertacyigitcanhalici ,
We are moving this repo to https://github.com/AstroDraw/AstroChart.
All the issues will be handled there.
As I said by email, this library just works inside a browser, at least for now.
Since this is not an issue related to the library, and more related to how to render an html in the server side, I'll ask you to post it on StackOverflow. Probably there will be people that can help you with that question.
If you have any issue related to the project, feel free to open a new issue on the new repo.

Sure thanks for letting me know
On Wed, 3 Mar 2021, 02:34 Arthur Fücher<EMAIL_ADDRESS>wrote:

Closed #34 https://github.com/Kibo/AstroChart/issues/34.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kibo/AstroChart/issues/34#event-4398638800, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARW3UVB3LQGKN52E2ASLTCLTBVYWTANCNFSM4YGL52OQ
.


fix: tf.contrib.slim.nets.vgg will not work

init.py of slim module don't import nets module. so
tf.contrib.slim.nets.vgg
will not work. change to this:
import tensorflow.contrib.slim.nets as nets
vgg = nets.vgg

another way of correcting this is change init.py. but change documentation is the easy way.

Can one of the admins verify this patch?


Get form data in handleSubmit

Hi, Can anyone help me?
I want to write a handleSubmit in SimpleForm. How to get form data in handleSubmit.
I can not find any example for this.
<SimpleForm handleSubmit={(data)=>{
            console.log(data);
        }}>
// Form fields
</SimpleForm>

Hi, and thanks for your question. As explained in the admin-on-rest contributing guide, the right place to ask a "How To" question, get usage advice, or troubleshoot your own code, is StackOverFlow.
This makes your question easy to find by the core team, and the developer community. Unlike Github, StackOverFlow has great SEO, gamification, voting, and reputation. That's why we chose it, and decided to keep GitHub issues only for bugs and feature requests.
So I'm closing this issue, and inviting you to ask your question at:
http://stackoverflow.com/questions/tagged/admin-on-rest
And once you get a response, please continue to hang out on the admin-on-rest channel in StackOverflow. That way, you can help newcomers and share your expertise!

Ok, I asked in StackOverflow.
https://stackoverflow.com/questions/49790675/get-form-data-in-handlesubmit


Rename USE_NOPAM as USE_PAM

This is addressing a minor annoyance of mine.
I had a conversation with @metalefty a while ago about avoiding double negatives where possible (i.e. replace if (!no_daemon) with if (daemon)) to improve readability for developers whose first language isn't English.
This PR replaces #ifdef USE_NOPAM with #ifdef USE_PAM in the xrdp daemon code. I have to say that even as a native English speaker I find this one needs a couple of tries to parse in my head.

Thank you for the good catch.


ModelChoiceField does not render as a dropdown

I would be cool if the ModelChoiceField rendered as semantic-ui dropdown (like choices) instead of a standard select field.

Good idea! I'll get this in tonight, it requires some slight modification render_choicefield function.

Added!

Awesome!  Thanks so much.  I will check it out in the morning.


numpy.take and duplicate indices

Hi,
First of all, thanks for making autograd! It's been extremely useful.
I noticed though that np.take produces the wrong result if the index array contains duplicate values.  For example,
quick_grad_check(lambda x: np.sum(x[[0,0]]), np.array([1.]))
fails with:
AssertionError: Check failed! nd=2.0, ad=1.0
You can fix it by changing a line in primitive_sum_arrays (in numpy_extra.py) from
new_array[array.idx] += array.val
to:
numpy.add.at(new_array, array.idx, array.val).  I'm not sure if this error occurs elsewhere, but it seems to at least fix the problem in all of the cases that I've tried.

Thanks for the bug report and the fix!


Allow specifying schema in redshift methods

Going forward we want to store data from different teams/sources in different schemas on redshift. See https://clever.atlassian.net/browse/INFRA-667 for more details
Tested: Unit tests.

Suggest updating "running" section in README

lgtm

Updated README. Merging after tests pass.


Migrating JS Atomic Components to Preact

Preact is the perfect library for what we want to accomplish. It has a great API, documentation, and community support. It's also just 3kb. I'm going to be migrating https://github.com/cfpb/AtomicComponent to use Preact. The CF4 components will need to be migrated as well.
Notes

I do have some concerns surrounding event delegation but those are far outweighed by the benefits of using Preact.

Preact supports modern browsers and IE9+:

We are baking in the loss of support for IE8 JS further with this. I would like to know more about how that decision was made and why, since it impacts many key applications on cf.gov.

@cfarm, we don't support IE8 with JS. We haven't in a very long time.

Yes, I realize that. It's something I only just learned at the last regroup, though. So I would like more insight into when and how that came to be - it wasn't something I was aware of before I joined platform team, nor were my teammates aware of it. Is there documentation on when and why the support was dropped?

It has always been the policy that once the browser support reached a certain level that we dropped support for it. The flapjack team just made the determination to drop JS support based on the level of users and MS dropping security updates for the browser.

@cfarm that's on us for not making sure it was outside the original team and for not documenting it for the future. Do you think we should document it here or in the Development repo? I can take a stab at documenting it tomorrow, though the when details are a bit foggy at this point.

@jimmynotjim yeah I was just chatting with @sebworks about this. Development repo seems like the place for it - specifically:

adding a note to the IE8 bullet that JS is not supported https://github.com/cfpb/development/blob/master/browser-checklist.md
and maybe https://github.com/cfpb/development/blob/master/javascript.md

</derail> continue thread topic as originally planned :bowing_woman:

@sebworks let's chat about preact next week, I like it and have used it, but this seems like a fairly big decision we should probably hash out a bit more amongst the group

Just came across this issue and I want to echo @wpears's comment. This is a decision that should be made at the team level. Preact is certainly interesting technology, but this would incur some new technical debt that should be considered. Hold off on implementing until this has been discussed more widely.

Discussion was helpful, yet unsure on future direction.


After 60 scan, Bar code scan working stop

When i start scan bar code it is working perfectly, but when i scan 60 bar code after it stop working.
after that i have to kill app and restart app again.

provide more info please @deepikajainvoloansys

Closing as duplicate of https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/370


Redux Essentials, Part 3, Incorrect Image

What docs page needs to be fixed?

Redux Essentials
Part 3: Basic Data Flow

What is the problem?
In the section entitled Showing the Post List, the image which should show a successful render of the posts list, instead shows an image of what I believe to be the completed application. The image shows a list of notifications, a navbar with posts, users, and notifications buttons, and a refresh notifications button to the right of the navbar.
What should be changed to fix the problem?
I took a picture of my screen upon successfully rendering the posts list. This picture could be used in place of the current one to show what a user's screen should look like at this point in the tutorial.

Thank you for your time!

Whoops, I completely messed that one up :)
Could you go ahead and file a PR to replace that?  Crop your screenshot to the same size and shape as the existing one (I think it's like 800x???).

Thanks for the quick response, Mark! I just submitted the PR to fix the image problem.


Put messages on the queue as strings not bytes

Changes
The message put on the queue is a string not a bytes object
How to test
Test it's not broken
Who can test
Anyone but @warrenbailey

:-1: unit test failure


Renaming record fields

It would be nice to have a convenient way to rename record fields in recordOf and classOf, preferably without having to specify every field three times. This should be possible if the structural generics were made a little more clever, though I'd like to be able to apply the renaming to the serializer in the type of the field itself.
Algorithmic renaming, like converting to camelCase, would also be nice to have.
Perhaps a rename combinator would be useful?

The combinator to rename fields of the representational type when decoding to the domain type should roughly be:
function renameFrom<
    T extends { [K: string]: any },
    S extends { [K: string]: any },
    OldKeys extends keyof S
>(schema: Schema<T, S>, mapping: { [K in OldKeys]: string }): Schema<???, S> {
    return { ... };
}

??? should be T, except for each K in keyof T, we replace the key/value pair with (typeof mapping)[K]: T[K] if it's in OldKeys, or K: T[K] otherwise.