Cartographer is not using the odometry input

Hello, I've been using google cartographer for a couple of months, and it's been great, the only issue I have is with very regular hallways (classic slam issue), so I've been trying to add odometry to the node to achieve better results, but I've not been succesful so far, maybe you could help me tune it correctly. My sensor is a URG-04LX_UG01 ( http://www.hokuyo-aut.jp/02sensor/07scanner/download/pdf/URG-04LX_UG01_spec_en.pdf ), im not using an IMU.
This is the best result I have had in the trouble area (by the way, everywhere else it works great), the red line is the odometry published by the rosaria node on the topic odom:

Here is the repo, with the launch files, configuration files and URDF:
https://github.com/NIN11/cartographer_ros
My two bag files, one for each launch file I added:
https://drive.google.com/file/d/0B8ONeY2eleY3dl92b3MyM3lQa0E/view?usp=sharing
https://drive.google.com/file/d/0B8ONeY2eleY3Y3MxUTc1RUlRTGM/view?usp=sharing
Any help would be greatly appreciated, and if you could tell me how to increase the rate at which the /map topic is published that would be great.

rosbag info tells me that your bags only contain /odom, /slam_out, and /tf topics. There is no laser scan in there.

This was quite challenging and showed week points in Cartographer. As usual, my changes are in a branch in my fork. The final map I got is below. I only looked at one of the bags you provided. The commandline I used isroslaunch cartographer_ros replay_sin_mapa.launch bag_filename:=$HOME/Downloads/filtered_sin_mapa.bag.

Your sensor data is not great: Looking at your bag using rqt_bag shows sometimes 0.5 seconds between laser scans and odometry is similarly unreliable. Are you using a USB hub in between your sensors and your logging computer or something else that could introduce delays?
You seem to be using calibrate_time for the URG node. I have had bad experiences with this setting - laser scan (non monotonous laser time stamps and jitter).
 Generally it is best for SLAM with odometry to drive your path in each direction to make this bias observable.
Loop closing is challenging: Cartographer finds lots of wrong constraints with really high score in the similar looking corridors. Also, your bag contains very little overlap (only the last few seconds are overlapping with the first few seconds), so Cartographer finds little correct loop closing constraints. So loop closure is really fickly on this dataset and easily messes everything up. Cartographer should probably not accept constraints that can be arbitrarily shifted along a line without the score changing, but for now it does. You can help it by providing more overlapping data - for example by driving the same trajectory backwards again. This should also help with odometry biases.
Loop closing is further made more difficult by two rooms that are very similar being right next to each other (see red circles). It would have helped to explore the right most room more to get more data that discriminates it. This is also a week point of Cartographer: very similar looking rooms close to each other are matched and are hard to identify as outliers. The more overlapping data you collect, the more evidence you provide the algorithm to give up such a bad constraint though.

Hello again, and thank you. I'm seriously impressed, this is an amazing improvement, I wasn't expecting such a huge change in the output.
I'll be using Google Cartographer as one of the nodes of my undergraduate thesis project, and with these changes I'll be able to do a lot more tests in this type of environments. I'll be sure to thank you in my thesis, you're a life saver.
Thank you so much for your help. I really appreciate it.

Hello SirVer! I have met the same problem,when I compile your fork,there is an error:
CMake Error at cartographer_ros/cartographer_ros_msgs/CMakeLists.txt:26 (google_initialize_cartographer_project):
Unknown CMake command "google_initialize_cartographer_project"
Can you tell me how to solve it，Please？

@caoxiongkun that forks is 4 old, that is ancient in Cartographer's time :-) You should rebase these commits from SirVer's fork (it's just a couple of config file tweaks) on top of the current master.


bot offline no command response

so i installed the bot made the options.ini updated the dependencies
i added the token but wen i run the runbot.bat this is all that happens
[INFO] launcher: Checking for python 3.5+
[INFO] launcher: Checking console encoding
[INFO] launcher: Setting console encoding to UTF-8
[INFO] launcher: Ensuring we're in the right folder
[INFO] launcher: Adding local bins/ folder to path
[INFO] launcher: Checks passed.
[INFO] launcher: Moving old musicbot log
[ERROR] launcher: Syntax error (this is a bug, not your fault)
Traceback (most recent call last):
File "run.py", line 344, in main
from musicbot import MusicBot
File "C:\Users\Gebruiker\Downloads\MusicBot-master\MusicBot-master\musicbot_init_.py", line 6, in
from discord.ext.commands.bot import get_variable
File "C:\Users\Gebruiker\AppData\Local\Programs\Python\Python36-32\lib\site-packages\discord_init.py", line 20, in
from .client import Client, AppInfo, ChannelPermissions
File "C:\Users\Gebruiker\AppData\Local\Programs\Python\Python36-32\lib\site-packages\discord\client.py", line 42, in
from .voice_client import VoiceClient
File "C:\Users\Gebruiker\AppData\Local\Programs\Python\Python36-32\lib\site-packages\discord\voice_client.py", line 64, in
from . import utils, opus
File "C:\Users\Gebruiker\AppData\Local\Programs\Python\Python36-32\lib\site-packages\discord\opus.py", line 126
$ef is_loaded():
^
SyntaxError: invalid syntax
[INFO] launcher: All done.
C:\Users\Gebruiker\Downloads\MusicBot-master\MusicBot-master>
after this the bot is still offline and will not reponde to any commands
what to do?

Follow the installation guides in https://github.com/Just-Some-Bots/MusicBot/wiki. We don't support those that download the ZIP file - which is the incorrect method of installing the bot.


Execute method on a given script via ScriptManager.

Resolves #609

SonarQube analysis reported 5 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L647: Memory leak: value
 ScriptManager.cpp#L651: Memory leak: value
 ScriptManager.cpp#L655: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L669: The function 'GetScripts' is never used.


Allow global CA to be written directly via an API (IDFGH-8122)

In a very low memory environment with a non-trivial number of certificates, it is much more memory efficient to construct the global CA chain directly. This global chain of trust can then be used from both the HTTPS and MQTTS transports.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jacob Repp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

Hi, @jrepp Thanks for your contribution.
IIUC, I see that you want to set the global ca chain directly instead of calling the esp_tls_set_global_ca_store API to parse and add each certificate to the global ca chain.  Do you plan to provide the cert chain directly from the flash?
Can you please mention the numbers about heap saved with this alternate approach for your case?

With this approach I see the following things.

The cert chain shall not be parsed till the time when it is actually used for the TLS handshake.

In your PR, I see that you have added the respective API only in esp_tls_mbedtls.h and not in esp_tls.h. The API needs to be in esp_tls.h as well to be able to be used by the application.

Thank you for looking at this change. I appreciate your time.
Yes, we provision the .der format certificates to the device flash, at startup the certificates are built into a chain and set as the global CA chain. This is mostly a memory savings trick as we have very little memory at runtime for application functionality.
The drawback of the existing esp_crt_bundle functionality is that you lose the ability to side-load certificates and they bloat the executable flash which is a problem when doing multi-partition OTA (cert bundle size x #OTA partitions)
It might be interesting to look at improving the esp_crt_bundle mechanism to initialize a cert partition but that would be a much more invasive change.

In your PR, I see that you have added the respective API only in esp_tls_mbedtls.h and not in esp_tls.h. The API needs to be in esp_tls.h as well to be able to be used by the application.

I will make this change.

In your PR, I see that you have added the respective API only in esp_tls_mbedtls.h and not in esp_tls.h. The API needs to be in esp_tls.h as well to be able to be used by the application.

I will make this change.

In investigating this change it appears you are requesting this functionality be made to work across other TLS implementations (adding the API to esp_tls.h). However, it is too low-level and specific to mbedtls for that to be practical. The esp_crt functionality also has this limitation.

Regarding memory utilization - there are two main savings:

Storage memory of PEM
Parse memory of PEM

This approach allows the user to choose their own format for certificates, for example, DER format certificates.
At rest, this is a savings of >2x (from 2021 bytes to 889 bytes in an example GSR certificate). At runtime, there is a non-trivial amount of memory that is used to parse the PEM certificates which may not be available to the application.

Yes, we provision the .der format certificates to the device flash, at startup the certificates are built into a chain and set as the global CA chain. This is mostly a memory savings trick as we have very little memory at runtime for application functionality.

Do you mean that the certificates are parsed at the start of the code, if they are done so then I think the API esp_tls_set_global_ca_store does the same. It parses the certificate and loads it into the global ca chain. So if it is called on startup then the memory required for parsing would be one time and once it is freed internally, only the heap consumed by CA chain shall be remaining. What difference does your PR add in this case?
I had thought that you have parsed the certificate before startup and generated mbedtls_x509_crt kind of structure and have stored it directly on flash.

The drawback of the existing esp_crt_bundle functionality is that you lose the ability to side-load certificates and they bloat the executable flash which is a problem when doing multi-partition OTA (cert bundle size x #OTA partitions)

I think if you use default certificate bundle that includes a large number of CA certificates, then it increases the size by a larger extent.
However, if you use only the most common certs then the size of the bundle is reduced. Moreover, if you give you a custom list of certificates to be made into a bundle then the size depends on the number of certificates that you are providing. Have you tried that ?

In investigating this change it appears you are requesting this functionality be made to work across other TLS implementations (adding the API to esp_tls.h). However, it is too low-level and specific to mbedtls for that to be practical. The esp_crt functionality also has this limitation.

What I had meant was , esp_tls_mbedtls.h is a private header. Even if you add any API's in that file, the application won't be able to use it. You need to have respective entry in esp_tls.h as well. It is okay if it is not supported for wolfSSL stack, it can just be marked as not supported.

This approach allows the user to choose their own format for certificates, for example, DER format certificates.
At rest, this is a savings of >2x (from 2021 bytes to 889 bytes in an example GSR certificate). At runtime, there is a non-trivial amount of memory that is used to parse the PEM certificates which may not be available to the application.

Ohh, okay I think this is a different question. I dont know why you are not using the same API for DER encoded certificates as well? I think the API mbedtls_x509_crt_parse which has been internally used in the esp_tls_set_global_ca_store can be used to parse both PEM and DER encoded certificates. (reference

I think based on your feedback we should abandon this PR. Thanks for your time and the pointers.
Perhaps there are changes in the latest stable that need to be investigated or some misuse of APIs. This change would just be a workaround for some other underlying problems. I'll keep the change on the local branch to keep the firmware of the devices working until there is time to investigate further or migrate off of these APIs to something else.

I think based on your feedback we should abandon this PR. Thanks for your time and the pointers.

@jrepp  Please feel free reopen the PR if you still think that this change fixes your issue and current IDF behaviour does not utilise your resources efficiently. Actually, I thought a discussion about requirements and possible solutions should happen so that we would reach to a best-case solution that solves all your problems and without adding any additional complexity to IDF.

Sure I appreciate that. After discussing it I don't think it's a good change. It's a kludge. It's working around issues in the underlying system that perhaps there are other (better?) workarounds.
Storing certificates on a global and hiding the parse and memory allocation is not a clean design. Adding an override on that (this PR) and giving access to that global is not making it better, it's making it worse. It's fine on a local build as a workaround but not a good PR.
IMO a better design would be to have a container abstraction for certs that the user controls and is passed into the communication librararies as a dependent api. This way you can avoid the hidden global state management and interlocking inconsistent behavior and cert chain control of the https and mqtts libraries.
An inversion of control would allow deferred loading of elements in the cert chain instead of commiting heap. In fact mbedtls supports just this style of working internally but it's not exposed in the IDF.
There are probably plenty of reasons it's not implemented this way as it's complicated to support all these libraries and optional things glued together. E.g I have no idea how wolfSSL works.
Requirements:

one cert chain for all TLS connections
user controlled memory, ideally a cert checking callback to avoid commiting heap to all certs
container for certs that supports storage in its own partition to avoid bloating the application partitions
tool to prepare and load certs to partition

Ideally the cert validation is implemented with callbacks and the reference implementation reads from the cert partition without requiring all of the certs to reside in dram.


Issue

When trying to create the template i get this error message:
Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '58dccf9e-3eaf-4533-a9b6-1e5a1845d036'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 21., job 'Phase_1', step ''.)Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '58dccf9e-3eaf-4533-a9b6-1e5a1845d036'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 21., job 'Phase_1', step ''.)
but the project is created anyway
AB#3916

Kindly Install the required extensions manually from the marketplace and try to provision the project.
Refer to #626 for more info


Allow install of paragonie/random_compat 9.99.100

Description
Allow installation of paragonie/random_compat version 9.99.100 to avoid downgrades to version 2.x when upgrading a project to PHP 8.
Motivation and context
paragonie/random_compat 9.99.99 is not compatible with PHP 8, but 9.99.100 is, see v9.99.99...v9.99.100#diff-d2ab9925ca
How has this been tested?
composer require 'ramsey/uuid:^3.8' with PHP 8 installs paragonie/random_compat in the wrong version (2.0.19 instead of 9.99.99)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I have run composer run-script test locally, and there were no failures or errors.

Thank you for contributing! 🎉

@ramsey Thanks for merging this. After a quick update with ramsey/uuid:3.x-dev, Composer is happy again!
Since in my case it's actually a sub-dependency, would a 3.9.4 release be possible so it can be picked up by Composer automatically?

I am so sorry it took me so long to tag a 3.9.4 release. I thought I had already done so but then came across this during some recent clean up and found that it was still outstanding. I'm so sorry! 😳


Autoplay

Brief description of changes:

Created boolean scene.animation.autoplay, false by default
Added CLI option --animation-autoplay
When scene.animation.autoplay is true, files with animations will automatically start their animation.

So, if I get this right, it means that autoplay will automatically play a file on load. Eg, when changing file, it will start playing the animation. Is that correct @technologeli ?
Wdyt @Meakk ?

Looks like the correct approach to me. 👍
I don't know if it's possible to cover that with a test, any input @mwestphal ?

Definitely possible! Animation is already tested with an interaction test. Just removing the interaction with the same test should provide the same output.

@technologeli let me know if you need help with adding an test.

Adding a simple application test with --animation-autoplay option should be enough, right @mwestphal?
@technologeli see https://github.com/f3d-app/f3d/blob/f037d908c081cc2960999f7c53eaf86f89950816/application/testing/CMakeLists.txt#L140C37-L140C37
Adding a new line like:
f3d_test(NAME TestGLTFReaderWithAnimationAutoplay DATA BoxAnimated.gltf ARGS --geometry-only --animation-autoplay DEFAULT_LIGHTS)

Then you should be able to run ctest -R TestGLTFReaderWithAnimationAutoplay -VV to get the baseline file to copy to testing/baselines.
When the test pass, you can push the test and the coverage CI job should be happy.

Thank you for the pointers, I had a test written but was unsure of how to get it passing while using ctest.

I had a test written but was unsure of how to get it passing while using ctest.

ctest -R Autoplay :)

Thanks a lot for your contribution! Do not hesitate to reach out if you need any help fixing another issue!


feat(pointcloud_preprocessor): add crop box filter feature to handle multiple cropboxes and specific frame inputs

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
Add new crop box feature to

handle multiple cropboxes
enable to  choose cropbox frame

Purpose
Currently in some settings, we use crop box filter muiltiple times to filter vehicle body and mirror reflections. Fro example:

This will increase computation burden due to

publishing unnecessary pointcloud
multiple times inspection for each point

So I think its better to assign cropbox parameter at once and do not duplicate crop box filter subsequently.
The other suggestion is;
Since current crop box filter is processed in input_frame and crop box is often given in base_link or map frame, we can not filter other frame pointclouds.
Possible approaches

add new node to handle multiple cropboxes
add cropbox frame parameters to control in which coordinate the input pointclouds should be filtered.

Definition of done
Merge each feature PR

How does this perform against cascaded crop box filters?
If I understand correctly, this feature would do the same than cascaded filters, but without the intra process communication (which is supposedly fast). Is intra process delay that big?

@VRichardJP

Is intra process delay that big?

Hmm, It seems not so much(~10ms).
In some projects, we confront of CPU resources problems so that it cause unintended system behavior.
So I wanted to

reduce unnecessary communication
reduce process delay by doing same filtering and coordinate transformation


libharu: 2.4.0 -> 2.4.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libharu/libharu/releases.
meta.description for libharu is: "Cross platform, open source library for generating PDF files"
meta.homepage for libharu is: "http://libharu.org/"
meta.changelog for libharu is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.1 with grep in /nix/store/n0flxgj3917hknq9m2rqy9cwq6640x20-libharu-2.4.1
found 2.4.1 in filename of file in /nix/store/n0flxgj3917hknq9m2rqy9cwq6640x20-libharu-2.4.1

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

19 package rebuild(s)

First fifty rebuilds by attrpath
blender
blender-hip
emboss
fileshelter
gawk-with-extensions
gawkextlib.haru
hyp2mat
libharu
openems
python310Packages.bpycv
python310Packages.python-csxcad
python310Packages.python-openems
python39Packages.bpycv
python39Packages.python-csxcad
python39Packages.python-openems
saga
wt
wt3
wt4

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n0flxgj3917hknq9m2rqy9cwq6640x20-libharu-2.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libharu https://github.com/r-ryantm/nixpkgs/archive/f3d1810789201b868e1710745c34675742bc4f02.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n0flxgj3917hknq9m2rqy9cwq6640x20-libharu-2.4.1
ls -la /nix/store/n0flxgj3917hknq9m2rqy9cwq6640x20-libharu-2.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @MarcWeber for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libharu/libharu/releases.
meta.description for libharu is: "Cross platform, open source library for generating PDF files"
meta.homepage for libharu is: "http://libharu.org/"
meta.changelog for libharu is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.2 with grep in /nix/store/9xz773f4xm8lx90wd4gdagpcvgngsjia-libharu-2.4.2
found 2.4.2 in filename of file in /nix/store/9xz773f4xm8lx90wd4gdagpcvgngsjia-libharu-2.4.2

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

19 package rebuild(s)

First fifty rebuilds by attrpath
blender
blender-hip
emboss
fileshelter
gawk-with-extensions
gawkextlib.haru
hyp2mat
libharu
openems
python310Packages.bpycv
python310Packages.python-csxcad
python310Packages.python-openems
python39Packages.bpycv
python39Packages.python-csxcad
python39Packages.python-openems
saga
wt
wt3
wt4

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9xz773f4xm8lx90wd4gdagpcvgngsjia-libharu-2.4.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libharu https://github.com/r-ryantm/nixpkgs/archive/93636d56c508fbe655a35286f08df42c5b0f6d91.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9xz773f4xm8lx90wd4gdagpcvgngsjia-libharu-2.4.2
ls -la /nix/store/9xz773f4xm8lx90wd4gdagpcvgngsjia-libharu-2.4.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

fileshelter
gawk-with-extensions
gawkextlib.haru
saga
wt
wt3

12 packages built:

blender
blender-hip
emboss
hyp2mat
libharu
openems
python310Packages.bpycv
python310Packages.python-csxcad
python310Packages.python-openems
python39Packages.bpycv
python39Packages.python-csxcad
python39Packages.python-openems

Maintainer pings
cc @MarcWeber for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/libharu/libharu/releases.
meta.description for libharu is: "Cross platform, open source library for generating PDF files"
meta.homepage for libharu is: "http://libharu.org/"
meta.changelog for libharu is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.3 with grep in /nix/store/6ccdmbdhzjw4djavjxdwqdak02s5ba5i-libharu-2.4.3
found 2.4.3 in filename of file in /nix/store/6ccdmbdhzjw4djavjxdwqdak02s5ba5i-libharu-2.4.3

Rebuild report (if merged into master) (click to expand)

19 total rebuild path(s)

19 package rebuild(s)

First fifty rebuilds by attrpath
blender
blender-hip
emboss
fileshelter
gawk-with-extensions
gawkextlib.haru
hyp2mat
libharu
openems
python310Packages.bpycv
python310Packages.python-csxcad
python310Packages.python-openems
python39Packages.bpycv
python39Packages.python-csxcad
python39Packages.python-openems
saga
wt
wt3
wt4

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6ccdmbdhzjw4djavjxdwqdak02s5ba5i-libharu-2.4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libharu https://github.com/r-ryantm/nixpkgs/archive/5f201380a4a7f419f90047f47add50a3764b6bd8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6ccdmbdhzjw4djavjxdwqdak02s5ba5i-libharu-2.4.3
ls -la /nix/store/6ccdmbdhzjw4djavjxdwqdak02s5ba5i-libharu-2.4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

fileshelter
gawk-with-extensions
gawkextlib.haru
saga
wt
wt3

12 packages built:

blender
blender-hip
emboss
hyp2mat
libharu
openems
python310Packages.bpycv
python310Packages.python-csxcad
python310Packages.python-openems
python39Packages.bpycv
python39Packages.python-csxcad
python39Packages.python-openems

Maintainer pings
cc @MarcWeber for testing.

duplicate with #196599
not sure which one to close :)


rfc: content block prompt template

Looks good.
How should ImagePromptTemplate ideally be related to ContentBlockPromptTemplate?
The example in the screenshot is helpful to understand a use-case we're enabling (e.g., a test with both text + image blocks in one message or any other illustrative examples).


Request: Microphone support for Teo

The microphone is needed to start this game, many thanks for any support.

Thank you for your patience.  Are you able to build from the source?  I've just implemented a feature that let you select a .WAV file that is sent to the virtual machine's PCM-sampling register.  The virtual machine will think the audio is given to the microphone input.  If you are using CUI, the command is LOADWAV (or SENDWAV is alias).  If you are using GUI, select "Audio"->"Select WAV File for PCM Sampling in the VM".
I hope it starts Teo.

Thank you for your patience. Are you able to build from the source? I've just implemented a feature that let you select a .WAV file that is sent to the virtual machine's PCM-sampling register. The virtual machine will think the audio is given to the microphone input. If you are using CUI, the command is LOADWAV (or SENDWAV is alias). If you are using GUI, select "Audio"->"Select WAV File for PCM Sampling in the VM".
I hope it starts Teo.

I'm on Windows 7, can you give me the commands for building Tsugaru and I will try it right away.

For Windows Visual C++, please follow the steps below.
git clone https://github.com/captainys/TOWNSEMU.git
cd .\TOWNSEMU\gui\src
git clone https://github.com/captainys/public.git
cd ..
mkdir build
cd build
cmake ../src
cmake --build . --config Release --parallel

cmake ../src
CMake Error: The source "C:/Users/study/fm/TOWNSEMU/src/CMakeLists.txt" does not
 match the source "C:/Users/study/fm/TOWNSEMU/gui/src/CMakeLists.txt" used to ge
nerate cache.  Re-run cmake with a different source directory.

C:\Users\study\fm\TOWNSEMU\gui>cmake ../src
-- Building for: NMake Makefiles
CMake Error at CMakeLists.txt:2 (project):
  Running

   'nmake' '-?'

  failed with:

   The system cannot find the file specified

CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

This is a bit of a headache and I have no idea what i'm doing so I'm just going to wait for the next public release.

For Windows Visual C++, please follow the steps below. It will build both GUI and CUI executables.
git clone https://github.com/captainys/TOWNSEMU.git cd .\TOWNSEMU\gui\src git clone https://github.com/captainys/public.git cd .. mkdir build cd build cmake ../src cmake --build . --config Release --parallel

Ok I got it compiled but it doesn't seem to work when I pick my .wav file

After picking .wav file:

Teo - Mou Hitotsu no Chikyuu (Japan) (Version 1.0)
Teo - Mou Hitotsu no Chikyuu (Japan) (Version 2.0)
Same thing

Can you try High-Fidelity Mode?

Can you try High-Fidelity Mode?

No difference, same thing happens.

Can you try High-Fidelity Mode?

Testing Teo again after a long time, well it seems like Teo - Mou Hitotsu no Chikyuu (Japan) (Version 1.0) now gets into the Setup and you can actually install the game so there is some microphone emulation active now I think, but after Setup is finished the game still crashes when you try to start the game.
Meanwhile Teo - Mou Hitotsu no Chikyuu (Japan) (Version 2.0) doesn't even get into the setup


Request for Creator / Sponsor Names in Tooltips

Nudge people to contribute a bit.

Also, request to have anyone on this list automatically made leader in groups.
Take whatever code you want from Groupie / GogoLoot / GDKPd. This is a very light-weight check on GUIDs.

Do you want an icon?

https://github.com/Gogo1951/Groupie/blob/main/Core.lua#L1993 -- tooltips
https://github.com/Gogo1951/Groupie/blob/28d2259b7f759a9b0e2f17584a4a02533ff24573/Globals.lua#L841 -- player data

I don't find value in adding this for 2 people.

request to have anyone on this list automatically made leader in groups.

Is something I'm partially working on, but clustering foundation isn't setup for that at all so it's a fair bit of work.


[BUG] no output in docker logs

have to apply this workaround:
https://stackoverflow.com/a/59582063
    environment:
      - PYTHONUNBUFFERED=1

fixed


Replace json-schema-to-typescript with openapi-typescript

The majority of this libraries types are codegen'd from shipengine-json-schema, and shipengine-json-schema is codegen'd from your openapi definitions. The problem is that the shipengine-json-schema is outdated and the openapi definitions are not.
I think it would make sense to use types derived from openapi directly and eliminate the dependency chain to ultimately keep this library in sync with your api. My primary concern is that the shipengine-json-schema is missing terms_of_trade_code while the openapi definitions are not, so I need I need to submit a pr for two separate packages just to get a property added that the api already supports.

closing because https://github.com/ShipEngine/shipengine-js/issues/236


We don't have a dataset

Connected on Linkedin with Javier Perez (CTO @ Fourvenues), Alejandro Joshua (Software Developer @ Fourvenues), and Pedro Perez (Founder Guru It!) to propose a partnership where we develop the system for their applications.

I found a rich dataset with 15k examples. It is divided into 5 csv files, which makes the dataset richer. Also, there is a test dataset with which we can test the different models.


Error when installing

when installing, i have errors:
Exception: Traceback (most recent call last):   File "/usr/lib/python3/dist-packages/pip/_internal/cli/base_command.py", line 143, in main     status = self.run(options, args)   File "/usr/lib/python3/dist-packages/pip/_internal/commands/install.py", line 338, in run     resolver.resolve(requirement_set)   File "/usr/lib/python3/dist-packages/pip/_internal/resolve.py", line 102, in resolve     self._resolve_one(requirement_set, req)   File "/usr/lib/python3/dist-packages/pip/_internal/resolve.py", line 261, in _resolve_one     check_dist_requires_python(dist)   File "/usr/lib/python3/dist-packages/pip/_internal/utils/packaging.py", line 55, in check_dist_requires_python     if not check_requires_python(requires_python):   File "/usr/lib/python3/dist-packages/pip/_internal/utils/packaging.py", line 33, in check_requires_python     return python_version in requires_python_specifier   File "/usr/share/python-wheels/packaging-19.0-py2.py3-none-any.whl/packaging/specifiers.py", line 676, in __contains__     return self.contains(item)   File "/usr/share/python-wheels/packaging-19.0-py2.py3-none-any.whl/packaging/specifiers.py", line 681, in contains     item = parse(item)   File "/usr/share/python-wheels/packaging-19.0-py2.py3-none-any.whl/packaging/version.py", line 28, in parse     return Version(version)   File "/usr/share/python-wheels/packaging-19.0-py2.py3-none-any.whl/packaging/version.py", line 219, in __init__     match = self._regex.search(version) TypeError: expected string or bytes-like object

What was your setup?

I tried an installation on a raspberry pi 4 today and it worked without issues

all okey with this error. If install on clear system
But now new error whith: scipy
Getting requirements to build wheel ... error
ERROR: Command errored out with exit status 1:
command: /usr/bin/python3 /tmp/tmpx0x_fz0j_in_process.py get_requires_for_build_wheel /tmp/tmpxkfdwmvg
cwd: /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a
Complete output (66 lines):
The Meson build system
Version: 0.63.3
Source dir: /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a
Build dir: /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-sgxfozxu/build
Build type: native build
Project name: SciPy
Project version: 1.9.2
C compiler for the host machine: cc (gcc 10.2.1 "cc (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110")
C linker for the host machine: cc ld.bfd 2.35.2
C++ compiler for the host machine: c++ (gcc 10.2.1 "c++ (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110")
C++ linker for the host machine: c++ ld.bfd 2.35.2
Host machine cpu family: arm
Host machine cpu: armv7l
Compiler for C supports arguments -Wno-unused-but-set-variable: YES
Compiler for C supports arguments -Wno-unused-but-set-variable: YES (cached)
Compiler for C supports arguments -Wno-unused-function: YES
Compiler for C supports arguments -Wno-conversion: YES
Compiler for C supports arguments -Wno-misleading-indentation: YES
Compiler for C supports arguments -Wno-incompatible-pointer-types: YES
Library m found: YES
../../meson.build:49:0: ERROR: Unknown compiler(s): [['gfortran'], ['flang'], ['nvfortran'], ['pgfortran'], ['ifort'], ['g95']]
The following exception(s) were encountered:
Running gfortran --version gave "[Errno 2] No such file or directory: 'gfortran'"
Running gfortran -V gave "[Errno 2] No such file or directory: 'gfortran'"
Running flang --version gave "[Errno 2] No such file or directory: 'flang'"
Running flang -V gave "[Errno 2] No such file or directory: 'flang'"
Running nvfortran --version gave "[Errno 2] No such file or directory: 'nvfortran'"
Running nvfortran -V gave "[Errno 2] No such file or directory: 'nvfortran'"
Running pgfortran --version gave "[Errno 2] No such file or directory: 'pgfortran'"
Running pgfortran -V gave "[Errno 2] No such file or directory: 'pgfortran'"
Running ifort --version gave "[Errno 2] No such file or directory: 'ifort'"
Running ifort -V gave "[Errno 2] No such file or directory: 'ifort'"
Running g95 --version gave "[Errno 2] No such file or directory: 'g95'"
Running g95 -V gave "[Errno 2] No such file or directory: 'g95'"
A full log can be found at /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-sgxfozxu/build/meson-logs/meson-log.txt

meson setup --native-file=/tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-native-file.ini -Ddebug=false -Doptimization=2 --prefix=/usr /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a /tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-sgxfozxu/build
Traceback (most recent call last):
File "/tmp/tmpx0x_fz0j_in_process.py", line 280, in
main()
File "/tmp/tmpx0x_fz0j_in_process.py", line 263, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/tmp/tmpx0x_fz0j_in_process.py", line 114, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 969, in get_requires_for_build_wheel
with _project(config_settings) as project:
File "/usr/lib/python3.9/contextlib.py", line 117, in enter
return next(self.gen)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 948, in _project
with Project.with_temp_working_dir(
File "/usr/lib/python3.9/contextlib.py", line 117, in enter
return next(self.gen)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 777, in with_temp_working_dir
yield cls(source_dir, tmpdir, build_dir)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 682, in init
self._configure(reconfigure=bool(build_dir) and not native_file_mismatch)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 713, in _configure
self._meson(
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 696, in _meson
return self._proc('meson', *args)
File "/tmp/pip-build-env-rjrjbi6z/overlay/lib/python3.9/site-packages/mesonpy/init.py", line 691, in _proc
subprocess.check_call(list(args))
File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['meson', 'setup', '--native-file=/tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-native-file.ini', '-Ddebug=false', '-Doptimization=2', '--prefix=/usr', '/tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a', '/tmp/pip-install-qhi_xi7r/scipy_bf2d1b141ddb490d908fef08a4ed965a/.mesonpy-sgxfozxu/build']' returned non-zero exit status 1.

WARNING: Discarding https://files.pythonhosted.org/packages/17/07/68df07679ec4a4a24bff00147a14908aa73e9e8912d142886e8d0e1e3d64/scipy-1.9.2.tar.gz#sha256=99e7720caefb8bca6ebf05c7d96078ed202881f61e0c68bd9e0f3e8097d6f794 (from https://pypi.org/simple/scipy/) (requires-python:>=3.8). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmpx0x_fz0j_in_process.py get_requires_for_build_wheel /tmp/tmpxkfdwmvg Check the logs for full command output.

I had the same issue on a pi2. It seems to be an issue with pip on python, doing a "pip install --upgrade pip" seemed to solve that issue.

Thanks a lot for your contribution!
Should we try to add a pip install --upgrade pip?
I will try an installation on a fresh Pi4 tomorrow.

I get,
`Collecting scipy
Downloading scipy-1.9.3.tar.gz (42.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 42.1/42.1 MB 1.0 MB/s eta 0:00:00
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [66 lines of output]
The Meson build system
Version: 0.63.3
Source dir: /tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427
Build dir: /tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-9wyqcigi/build
Build type: native build
Project name: SciPy
Project version: 1.9.3
C compiler for the host machine: cc (gcc 10.2.1 "cc (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110")
C linker for the host machine: cc ld.bfd 2.35.2
C++ compiler for the host machine: c++ (gcc 10.2.1 "c++ (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110")
C++ linker for the host machine: c++ ld.bfd 2.35.2
Host machine cpu family: arm
Host machine cpu: armv7l
Compiler for C supports arguments -Wno-unused-but-set-variable: YES
Compiler for C supports arguments -Wno-unused-but-set-variable: YES (cached)
Compiler for C supports arguments -Wno-unused-function: YES
Compiler for C supports arguments -Wno-conversion: YES
Compiler for C supports arguments -Wno-misleading-indentation: YES
Compiler for C supports arguments -Wno-incompatible-pointer-types: YES
Library m found: YES
  ../../meson.build:57:0: ERROR: Unknown compiler(s): [['gfortran'], ['flang'], ['nvfortran'], ['pgfortran'], ['ifort'], ['g95']]
  The following exception(s) were encountered:
  Running `gfortran --version` gave "[Errno 2] No such file or directory: 'gfortran'"
  Running `gfortran -V` gave "[Errno 2] No such file or directory: 'gfortran'"
  Running `flang --version` gave "[Errno 2] No such file or directory: 'flang'"
  Running `flang -V` gave "[Errno 2] No such file or directory: 'flang'"
  Running `nvfortran --version` gave "[Errno 2] No such file or directory: 'nvfortran'"
  Running `nvfortran -V` gave "[Errno 2] No such file or directory: 'nvfortran'"
  Running `pgfortran --version` gave "[Errno 2] No such file or directory: 'pgfortran'"
  Running `pgfortran -V` gave "[Errno 2] No such file or directory: 'pgfortran'"
  Running `ifort --version` gave "[Errno 2] No such file or directory: 'ifort'"
  Running `ifort -V` gave "[Errno 2] No such file or directory: 'ifort'"
  Running `g95 --version` gave "[Errno 2] No such file or directory: 'g95'"
  Running `g95 -V` gave "[Errno 2] No such file or directory: 'g95'"

  A full log can be found at /tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-9wyqcigi/build/meson-logs/meson-log.txt
  + meson setup --native-file=/tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-native-file.ini -Ddebug=false -Doptimization=2 --prefix=/usr /tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427 /tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-9wyqcigi/build
  Traceback (most recent call last):
    File "/home/pi/.local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
      main()
    File "/home/pi/.local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/pi/.local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 118, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 969, in get_requires_for_build_wheel
      with _project(config_settings) as project:
    File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
      return next(self.gen)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 948, in _project
      with Project.with_temp_working_dir(
    File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
      return next(self.gen)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 777, in with_temp_working_dir
      yield cls(source_dir, tmpdir, build_dir)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 682, in __init__
      self._configure(reconfigure=bool(build_dir) and not native_file_mismatch)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 713, in _configure
      self._meson(
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 696, in _meson
      return self._proc('meson', *args)
    File "/tmp/pip-build-env-vjjt7qjq/overlay/lib/python3.9/site-packages/mesonpy/__init__.py", line 691, in _proc
      subprocess.check_call(list(args))
    File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['meson', 'setup', '--native-file=/tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-native-file.ini', '-Ddebug=false', '-Doptimization=2', '--prefix=/usr', '/tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427', '/tmp/pip-install-og2x598p/scipy_0d02b7e64dbb47d09c11e978183d9427/.mesonpy-9wyqcigi/build']' returned non-zero exit status 1.
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.`
So once the script is finished I might see if I need to add Gfortran.

Well, it is still refusing to compile SciPy. I think its down to the use of Meson and that is kind of causing lots to break. I did find some chatter about it and I get a feeling it is a typical Linux thing of blaming the user for not having these things ready and not knowing the middle name of the person who soldered the chip in place. I think 1.8.2 installs on your script but it is a pain that insists on trying, 1.9.3, 1.9.2, 1.9.1, 1.9.0 each one of them taking 5mins to realise this.

I was able to reproduce that on a Pi4.
"sudo apt install gfortran libopenblas-dev liblapack-dev"
Seems to be needed before one is able to install the latest scipy (1.9.3) version
I will add that to the install script

I added the packages in the install.sh. This time the installation run without errors


Async stack trace mapping for no warnings in the console

For posterity: The problems with performance were alleviated with caching - the other option to mapStackTract. This change is only to avoid chrome warning of synchronous XHR.


Feature: Implement Google Oauth login

Date: 02/12/2024

Developer Name: Utkarsh Bansal

Issue Ticket Number

Closes #2216

Description

If the person is a developer they have to login via GitHub but a non developer should be able to login by their Google Account.
Documentation Updated?

[x] Yes
[ ] No

Under Feature Flag

[x] Yes
[ ] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[x] Yes
[ ] No

Screenshots

Screenshot 1

https://github.com/user-attachments/assets/50253c75-4e41-4aa7-aa78-16ef4096d3a6

Test Coverage

Screenshot 1

Additional Notes

Need to generate oauth credentials for staging as well as prod from google cloud console.
Design doc
API contract PR

@listiclehub1 can you please add the design doc here ?

@Achintya-Chatterjee I have added the design doc in the additional notes section.

@listiclehub1 also you have to change the API contract

@Achintya-Chatterjee I didn’t find an explicit API contract for the existing GitHub OAuth flow in the codebase.
Could you clarify whether any updates or changes to the current GitHub OAuth flow are required as well.

Can you add a small video how this google login work

Please update the description appropriately


[OR 3.7 Snapshot 20221108] Upload local media files to WM Commonms not working/stalls

Continuing from https://github.com/OpenRefine/OpenRefine/issues/5418, I've adapted my OR 3.7 snapshot project to include uploads from local files (instead of URLs):

I build my OR schema

, and when I try to upload to Commons, all seems OK, without error messages

So I press the "Upload edits" button, and the upload to Commons seems to begin...

but nothing happens, no files actually uploaded... seems to stall for ever...
I check the console: error messages

================================
13:42:01.709 [..mWikibaseEditsOperation] Performing edits (31ms)
13:42:01.709 [..ting.EditBatchProcessor] Requesting documents (0ms)
Exception in thread "Thread-3" java.lang.NullPointerException
at org.wikidata.wdtk.wikibaseapi.MediaInfoIdQueryAction.getMediaInfoIds(MediaInfoIdQueryAction.java:68)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataFetcher.getMediaInfoIdsByFileName(WikibaseDataFetcher.java:377)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataFetcher.getMediaInfoIdsByFileName(WikibaseDataFetcher.java:337)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataFetcher.getMediaInfoIdByFileName(WikibaseDataFetcher.java:309)
at org.openrefine.wikibase.editing.MediaFileUtils$MediaUploadResponse.getMid(MediaFileUtils.java:283)
at org.openrefine.wikibase.updates.MediaInfoEdit.uploadNewFile(MediaInfoEdit.java:251)
at org.openrefine.wikibase.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:167)
at org.openrefine.wikibase.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:262)
at java.base/java.lang.Thread.run(Unknown Source)

Interesting, this seems to indicate that no filename was returned by the MediaWiki API after file upload, but without marking the upload as failed. I am not sure in which circumstances this can happen, but at least we could anticipate this case and log the JSON response in those cases.

I just downloaded & installed the new snapshot release (dd 20221110) and this bug seems to have (partially) disappeared:
** When uploadig media from an URL (such as http://resolver.kb.nl/resolve?urn=urn:gvn:KONB16:533939704&role=page&count=3&size=large),

the file is correctly uploaded to Commons, see the result at https://commons.wikimedia.org/wiki/File:De_Haven_van_Amsterdam_-Nederlandsche_havengezichten_enz.-KONB16-533939704-_Prent_3_van_18.jpg
** When uploading a file from local media, the upload still seems to stall

with the same error message as yesterday

I might have cheered too early: I just tried uploading another file from URL (http://resolver.kb.nl/resolve?urn=urn:gvn:KONB16:533939704&role=page&count=4&size=large), but now I get the same stalling and error console messages as when uploading from local media files

My proposed fix will not let them be uploaded but at least the console will display a more helpful error message and the upload will not be stalled by these failures.


Feat allow users to specify component revision name

Signed-off-by: LeoLiuYan<EMAIL_ADDRESS>
What this PR does / why we need it:
We should allow users to specify component revision name, and the component revision may be created by users before.
Which issue(s) this PR fixes:
1884

Fixes #
Special notes for your reviewer:

lgtm


Add a CONTRIBUTING file

This pull request adds a GitHub-supported contributing guidelines file with hints and directions for project-related communication, patch submission, and contribution licensing.
@goneall, per your comment on the default branch in spdx/tools#4, we will want to update CONTRIBUTING to request topic branches off of master, rather than develop, after you merge.

Uh, oh. Looks like Hubot nuked my branch.

Merged in contributing file.
Thanks for writing this up!
Gary


Updated counters

Updated counters to show the fact that Lesion soft counters Finka.
#80

Thank you very much for the contribution @AustinGallippo


add 32-bit tests; return errors in case of string-to-int overflows

Codecov Report

Merging #276 (436237b) into main (3d54961) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

:exclamation: Current head 436237b differs from pull request most recent head 6b16047. Consider uploading reports for the commit 6b16047 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   85.64%   85.61%   -0.04%
==========================================
  Files          93       93
  Lines        9640     9640
==========================================
- Hits         8256     8253       -3
- Misses       1092     1094       +2
- Partials      292      293       +1

Impacted Files
Coverage Δ

pkg/base/response.go
100.00% <100.00%> (ø)

pkg/formats/av1.go
100.00% <100.00%> (ø)

pkg/formats/generic.go
75.51% <100.00%> (ø)

pkg/formats/h264.go
72.13% <100.00%> (ø)

pkg/formats/h265.go
92.59% <100.00%> (-3.71%)
:arrow_down:

pkg/formats/lpcm.go
100.00% <100.00%> (ø)

pkg/formats/mpeg4_audio_generic.go
94.95% <100.00%> (ø)

pkg/formats/mpeg4_audio_latm.go
87.36% <100.00%> (ø)

pkg/formats/mpeg4_video_es.go
100.00% <100.00%> (ø)

pkg/formats/opus.go
98.18% <100.00%> (ø)

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Group all images into a separate folder, as well as sounds.

Create 2 folders for sound and images, fill them and change appropriate code.

Add shop and hospital menus with minimal interior design in it.


[Testing] Stop installing InSpec in the pipeline

InSpec is now using the InSpec container directly so we no longer need
to install it as part of the pipeline

AllSpark is failing. But that's expected until we fix that container.


Translation of index.md into Portuguese

Exactly what is said in the title: translation of index.md into Portuguese. The only addendum is that Portuguese is pt-BR, but I think my language cousins will not be so disturbed when reading what I wrote ;-)

Duplicated. See https://github.com/tiangolo/fastapi/pull/1300. We are tracking the pages using https://github.com/tiangolo/fastapi/issues/1211.

Thanks for your contribution! As this was already covered by #1300 I'll close this one. But thanks for you effort! :cake:


Exit with an error if using --test on binary without unit tests compiled

This makes it clearer that tests=yes should be used at compile-time. Previously, the engine would run as if the argument wasn't passed, which can be confusing.
I've tested behavior with and without tests and it works as expected – --test is blocked, --testsomething or -test are not.
Preview
$ bin/godot.linuxbsd.editor.x86_64 --test
ERROR: `--test` was specified on the command line, but this Godot binary was compiled without support for unit tests. Aborting.
To be able to run unit tests, use the `tests=yes` SCons option when compiling Godot.

   at: test_entrypoint (main/main.cpp:852)

I guess let's stick to the original commit if the other approach doesn't seem to work. It's less code too.

I guess let's stick to the original commit if the other approach doesn't seem to work. It's less code too.

Done; I've removed the second commit.

Thanks!


Add newline character detection to Autodetect.

Discovered while looking into an issue in ImportLayoutStyle#orderImports that replaced CRLF prefixes with LF.
The orderImports method always uses LF characters in the import prefixes, which creates large diffs in CRLF repos.
It'd be helpful to know which new character is used in a project for things like TabsAndIndentsVisitor, ImportLayoutStyle, Space, etc.

@traceyyoshima Can you list some examples here of CRLF repos?

KualiCo/rice is an old repo, but has been a great source of view formatting results. It uses a lot of CRLF.
Currently, most of the OrderImport results on Netflix/Priam are due to CRLF.


Add additional argument for generating msgstr in order to create *.po files

See also https://github.com/yahoo/babel-plugin-react-intl/issues/31#issuecomment-255516499

Would you mind providing more details about your translation workflow?
To be honest I could not figure out why skipping the 'pot' step. 🤔

Well, I'm sure you know a *.pot file is just a *.po file with translations missing- they're the same format, one is just a template. I'm not advocating only doing the *.po step, but I would like to generate both a *.pot template and a ready-to-go translation file for the default language the app is built in, using the defaultMessage feature of react-intl. Mainly because I can then pipe that into other tools to generate merged translation files for the default language that aren't spread out through defaultMessage attributes in your app. Maybe it's a rare case but that's why I avoided disturbing the default behaviour. Others could concievably have different app source directories with different languages built into them as the default language which this would assist with too.

Just a reminder that there is already a built in algorithm working internally of react-intl. It will automatically fallback to defaultMessage if the message id is not matched in your translation files. (Maybe not the only solution.)
Anyway, thanks for sharing the process of your project, and I am okay to merge this PR if it is ready. :)

Yeah, so many options aren't there! Ready to merge if you're happy to have these features in the core project (:

Yeah, so many options aren't there! Well I'm ready if you are and you're
happy for this feature to be part of the core (:
On Mon, Oct 24, 2016 at 8:41 PM Michael Hsu<EMAIL_ADDRESS>wrote:

Just a reminder that there is already a built in algorithm
https://github.com/yahoo/react-intl/wiki/API#message-formatting-fallbacks
working internally of react-intl. It will automatically fallback to
defaultMessage if the message id is not matched in your translation
files. (Maybe not the only solution.)
Anyway, thanks for sharing the process of your project, and I am okay to
merge this PR if it is ready. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/evenchange4/react-intl-po/pull/45#issuecomment-255706894,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAatJHRech5KhDm4ne6oVHBVjARNFpQ4ks5q3ItOgaJpZM4Kdzab
.


Authenticate with Google through the browser instead of a webview

According to Google, webview Oauth support will end on April 20th of this year: https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html
I was wondering if there are plans to adjust this flow by then?

Also wondering if the Android SDK will support the new Google Oauth. Need to plan development and currently seeking other options.

Also wondering if the Android SDK will support the new Google Oauth. Need to plan development and currently seeking other options.

@Gear61 @interactivematt, we are currently in the process of updating both of our mobile SDK's to use Google's new auth mechanics.  We will be pushing the updates as soon as they are tested, but we do plan to have everything up and ready to go in time for the cutover.

This is supported as of version 4.0.1. Please be mindful of the new instructions for setup at the bottom of the README, you will need Google API access. Let us know if you encounter any issues or have any questions.


update design

Update design

I don't know...
It's closer to the original design.
The readability of the text towards the right is very much dependent on the width of the screen, which makes the experience less consistent. Also, I think the text could be bigger.

I don't know... It's closer to the original design. The readability of the text towards the right is very much dependent on the width of the screen, which makes the experience less consistent. Also, I think the text could be bigger.

The text can be larger, that's not an issue :)


How to draw the smear effect

Thanks for sharing the codes. Just wonder how to draw the smear effect as Figure 1 show in the papers?

Hello!
Figures (b) and (c) here were generated by plotting the BEV features generated by CaDDN. That would be batch_dict["spatial_features"] stored in the batch dict. Figure (c) should be able to be plot easily, but Figure (b) was done manually setting the depth distributions to ones here rather than using the estimated values.

Thanks, that helps a lot.

Thanks for your help on the previous issue.
I drew the smear effect image. I found that the BEV heatmap's coordination was not in conformity with the raw image. The final result was correct. I found there is exist a horizontal flip in the BEV heatmap.

I rotated the BEV heatmap's angle to consistency with the raw image. There exists a horizontal flip in the BEV heatmap.

Hi @rockywind,
Yes this is expected. This has to do with the difference between the LiDAR and camera reference frame, which are rotated and pointed in a different direction relative to one another. In order to visualize you need to perform this rotations + flip, but the transformation is still correct in the underlying code.

Thanks, that helps a lot. @codyreading


Update marathon

Signed-off-by: Emile Vauge<EMAIL_ADDRESS>

this should be fine with a rebase... LGTM


Update prompt message on service/resource deletion

Change resources to components
Environment

Walrus version: v0.4.0-rc3

Verified in main


Having tabs with splits makes focus stop working as expected

Since the purpose of this script is to navigate "visually" as I understand it (a concept which I find more intuitive than the default behavior), I'd expect that no matter where I am in one container, switching left or right would switch left or right visually. Instead, when there's horizontal splits it moves to the left tab:
https://u.teknik.io/3A7lj.mp4

i hope most of these issues will get fixed in the new update.


actions-rs actions are unmaintained

All GitHub actions in the actions-rs org are archived and unmaintained. We should stop using them.

Uses of actions-rs/cargo  look like they would be trivial to replace with just calling cargo with uses
I'm not familiar enought with toolchain to say if just using rustup is a decent replacement?

I'm not familiar enought with toolchain to say if just using rustup is a decent replacement?

Looks like plain rustup would work. We may still want to add something like https://github.com/Swatinem/rust-cache but as far as I can tell this is a separate thing: current actions don't do caching either.

There's also https://github.com/dtolnay/rust-toolchain which is gained popularity.

Yes, I considered a couple of alternatives but at least so far I've not found much reason to not just "do it manually" and avoid the dependency.


Update beacon tools container with v2 image

Dependency on solving this issue first: https://github.com/EGA-archive/beacon2-ri-tools-v2/issues/17

Solved in commit e3484e1


[ZF3] [WIP] Service Manager Cleanup

Here's my made-up roadmap for ZF3's ServiceManager:

[x] Removal of aliases
[x] Compatibility layer for ZF2 ServiceManager aliases (for those who really really need them ?!)
[x] Removal of canonical names
[x] Compatibility layer for ZF2 ServiceManager canonical names
[x] Removal of retrieveFromPeeringManagerFirst support (no polyfill/not used in the framework itself)
[x] Removal of peering service managers as a native functionality
[x] Compatibility layer for ZF2 ServiceManager peering service managers
[x] Change of interfaces to remove the $cName and $rName differentiation. Now $rName === $cName
[x] Implement passing service options to the locator during lookups (currently completely broken, and broken also in mutable options interface)
[ ] Test cases for the introduced compatibility layer
[ ] Performance tests
[ ] Code cleanup (currently just a PoC)
[ ] Tests green on components depending on Zend\ServiceManager

See the changes in the tests for a good overview of what I broke.

ServiceManager v3 development is done in SM repository

ServiceManager v3 development is done in SM repository

Can you provide the link to the PR which handles the issues described in this PR? Thanks.

To all who disregard BC:
What is the value to author a framework which will not get market acceptance? If you hit the users, they will hit you more. You can only scratch them, they can kill you.
Switching a version number, even if it is a major one, is not enough justification to let any single user down.
And for what reasons would you scratch them? Code gets cleaner? What do you mean? Who cares? But in particular: Do you mean, cleaner means classes have less member functions? If it is only that, buying a bigger monitor would be more appropriate than dropping functionality. Just an example.
My perception currently is, that Zend Framework is a sinking ship. One important reason is, that BC breaks are introduced, just because someone LIKES somewhat better. Hey, who cares what you like?
Open source. as any other business, is a business. If you don't have a business case for what you like, forget it or like it at home.
Please keep in mind, that businesses learn to rely on open source. Please consider, that any change requires people to define a business case to justify why to follow that change. Please deliver enough and sufficient information for those people.
It may be ugly, but it works ok and we achieve our goals, it's perfect. That is business.
OT: I do not like this kind of monster PRs.

ZF is a tool, not a product. Don't get too attached to the tool.
You are worried about market share when you are selling a product, otherwise this is "just" OSS work, and I personally only do OSS work when it is for making something better, not necessarily popular. I also say "just", but it is my passion, pride and primary source of self-improvement.
So yes, my personal work on free and open source software will keep going this way: if a BC break improves the quality, performance and reliability (reduced defect ratio), then it will be worth the effort.
If you disagree with my work, that's fine, but I really only do it to improve the final result, do not assume malice.

@Ocramius: I appreciate your work and deeply respect your knowledge and problem solving strategies. You are also an excellent teacher. I follow your publications for a long time. I got lots of insights regarding PHP by studying your work. I come from c++ and it was your work and the work of very few others which provided me a fast track to learn about the more interesting parts of PHP.
I apologize for the tone of my statement. Don't take that personally, please. I was on my tiny pull request for the service manager. I fixed a bug. Your immediate reaction: Why not kick out the whole feature. Not nice. Then I was asked to split an ultra-tiny change into pieces. And please remember the detail of your review (redundant $config, really?). Then I came here, found this mammoth PR which currently affects 106 files or so and the task list still has open points. - This just to explain why I was not in the best mood.
Again, sorry.
A framework - open source or not - is a platform people are invited to build upon. Building on third party requires an investment.  To invest is a matter of trust. Trust is a matter of usability, stability, reliability, sustainability, supportability, performance. Very similar to product quality requirements.
People who use ZF did invest. IMHO saving this invest and - in the best case - paying interest on that invest is important and the key to acceptance and success. A framework that nobody uses has no value, even if it is pretty well designed (because nobody is there to benefit from the excellent design).
Maybe this is a PHP specific thing, that BC is considered to be not very important. In c++ boost for
example, this is seen and handled completely different. boost libraries are developed and maintained with BC as an ultra-important aspect (because they object to break customer code). When libraries get old and concepts do not hold any longer, they are replaced by new components and new concepts.
I know you are involved in BetterReflection as an example. Why not introduce a BetterServices approach, separate from the core ZF? This could kick everything, could rethink DI for example, could rethink Symfony and Zend services handling and ... IMHO, this would be cleaner, would promote your approach to make things better and would guard the customers. And even people who fix a bug in the core.


IA-2507: HOTFIX prevent multiple clicks on button

Save button is not disabled properly for form version creation. This can lead to multiple versions with the same id in DB
Related JIRA tickets : IA-2507
Self proofreading checklist

[X] Did I use eslint and black formatters
[X] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

Disable save button if isLoading  is true
Disable API call if isLoading is true

How to test

Go to Forms
Pick a form
Download the xlsx file (can't be done without some friction from inside docker)
Create a new version
click save: The save button should be disabled until the modal closes

Print screen / video
https://github.com/BLSQ/iaso/assets/38907762/9d3e60ef-23f7-4c97-8ffe-b44c74026979
Notes
This branch can has been forked from v1.217 so it can be deployed as hotfix (if there was no other hotfix in the meantime)

https://github.com/BLSQ/iaso/actions/runs/6707651927


Ensure serial break event is generated in the correct place in the serial byte stream (IDFGH-4088)

Currently the UART_BREAK event generated upon detection of a serial break is delivered asynchronously to the bytes received by the UART. An event containing bytes received following a serial break is sent prior to the event for the corresponding break. If the serial break is used as a frame delimiter, as it is in many protocols, this makes determining where to delineate frames challenging.
This patch was proposed by @negativekelvin in #4537, and ensures UART_BREAK events are delivered in the correct place in the stream.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

@Alvin1Zhang Any chance of getting this reviewed and merged any time soon, we are also wanting this fix to be merged ?

Bump, this is important

Any update on why this has not been approved and merged yet ?

how is this not resolved yet?

@negativekelvin is this PR still relevant with the latest v5 changes ?

Hi @acf-bwl @moefear85
Sorry this has sat around for an extraordinary long time without further feedback.
Currently we hit regression on some of our UART driver unit tests with this change. I'll update this PR as soon as they are resolved.

ok thx for acknowledging the issue, it helps to know I'm not doing something wrong (or atleast not simultaneously).

This PR didn't pass CI with RS-485 test case...
A alternative solution for this issue is very simple: read byte by byte from UART instead of reading 120 bytes when its FIFO is full.
BREAK can happen any time.... just make sure that IDF driver always gets every single byte from UART and copy it to its internal RingBuffer. Doing so, when BREAK happens, the RingBuffer would be already complete and it will be possible to catch the BREAK event and then process the data already copied.
In order to read byte by byte, just initialize the UART IDF Driver and then execute uart_set_rx_full_threshold(uart_port_t uart_num, int threshold), with correct uart_num and threshold = 1.

As far as I extensively experimented, "hardware" RS-485 is broken anyways. I only got it working for multi-drop by implementing collision detection/avoidance in software. RS-232 is far more basic and important, because RS-485 is build on RS-232, meaning if uart breaks aren't correctly detected in RS-232, then neither are they in RS-485, so that's broken too!
Besides, reading byte by byte is not a solution, especially not at 2Mbps.  It's supposed to be a professional-grade product. Anyways I moved on a long time ago and will unsubscribe here. Plz don't mention me.

Tested on IDF 5.1.4 and it fixes an issue I was seeing where the bytes send before a BREAK were lost (until more data was sent later).

Tested this on v5.3.1 and it receives LIN frames successful.


Support with Sentry's /ember file?

There is this page https://sentry.io/for/ember/ which suggests you use

does this plugin play nicely with the /ember/raven.min.js ? or are these two separate implementations?
Also see https://docs.sentry.io/clients/javascript/integrations/ember/

those are two separate things. if you use this addon here it will automatically inject raven.min.js into your build pipeline.


Inform the user about the required fields when creating a project

To create a project you need to enter the project name otherwise nothing happens when you press save. When creating a team,  a message is printed telling the user to enter team name. It will be nice to have something similar for the project.


something doesn't work in Go 1.6 that worked in Go 1.5

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.6 v 1.5

What operating system and processor architecture are you using (go env)?

linux/amd64

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Switched from go 1.5 to 1.6

What did you expect to see?

Things to keep working ...

What did you see instead?

This is an issue that seems to involved Go, Haproxy, and Docker. I don't know for sure that http/2 is the reason, but it's my only suspect. We have an http server built with Go running in a docker container on an AWS ubuntu machine. If the server is built with Go 1.5, everything is fine. With 1.6, we get a 503 error code from haproxy. If the httpchk is disabled, everything starts working again. If haproxy is bypassed (by using the docker-machine ip), the server is working fine regardless of version. I tried disabling http/2 using GODEBUG env variables but that made no difference. We do have some servers built with 1.6 behind haproxy working but they are not inside Docker containers.
So, this appears to be an environment-specific issue triggered by go 1.6 but I can't say for sure it has anything to do with http/2. I only suspect it because it was introduced in go 1.6.
Some details that might matter: Haproxy is listening on port 80 and forwarding to the go server on its own ip listening on ":80".

If you disabled HTTP/2 and it still broken, why do you suspect HTTP/2?
What do haproxy's logs say?

I suspect it for little more than I can find absolutely nothing else to suspect. Going through what else has changed in Go 1.6, it's the only item that seems relevant.
Here are some logs from haproxy:
Apr 14 14:44:41 localhost haproxy[14618]: <IP_ADDRESS>:58730 [14/Apr/2016:14:44:41.297] IN-HTTP HTTP-OUT/ 0/-1/-1/-1/0 503 212 - - SCDN 0/0/0/0/0 0/0 {} "GET /status HTTP/1.1"
When I got those two logs, the web server wasn't actually running. After launching it, there are no more haproxy logs produced.
I stopped that container and launched one that was identical except in which version of Go was used to build. And here's the log message I get then:
Apr 14 14:51:17 localhost haproxy[14618]: <IP_ADDRESS>:58838 [14/Apr/2016:14:51:15.201] IN-HTTP HTTP-OUT/SYNC_PID1 2592/0/0/8/2600 200 379 - - --VN 1/1/0/1/0 0/0 {} "GET /status HTTP/1.1"

In Go 1.6, we reject HTTP/1.1 invalid requests without Host headers, per the spec.
See 6e11f45ebdbc7b0ee1367c80ea0a0c0ec52d6db5 and #11206 and #13624
Does haproxy send such bogus requests? Take a tcpdump on either side and see what you see haproxy sending on the wire?

That's it! Looks like our httpchk line should have had a host all along but Go was just ignoring the requirement until 1.6. Go's bug fix just exposed out haproxy bug. We're fixed. Thank you!

Is this a bug in haproxy or a bug in your haproxy config?
I don't know haproxy. Can you paste here the before & after configs?

The bug is in our config:
The old one:
option httpchk HEAD /status HTTP/1.1\r\nHost: \ ^
The new one:
option httpchk HEAD /status HTTP/1.1\r\nHost: localhost
"localhost" doesn't even seem necessary. It looks like any string at all can be there and it works fine. Our systems team is going to look into that part tho, and make sure this doesn't introduce any unexpected side effects.

Hah: HAProxy documents this,
https://cbonte.github.io/haproxy-dconv/configuration-1.5.html#4-option httpchk
But it's pretty trashy how it overloads the <version> field:
option httpchk <method> <uri> <version>

<method>  is the optional HTTP method used with the requests. When not set,
          the "OPTIONS" method is used, as it generally requires low server
          processing and is easy to filter out from the logs. Any method
          may be used, though it is not recommended to invent non-standard
          ones.

<uri>     is the URI referenced in the HTTP requests. It defaults to " / "
          which is accessible by default on almost any server, but may be
          changed to any other URI. Query strings are permitted.

<version> is the optional HTTP version string. It defaults to "HTTP/1.0"
          but some servers might behave incorrectly in HTTP 1.0, so turning
          it to HTTP/1.1 may sometimes help. Note that the Host field is
          mandatory in HTTP/1.1, and as a trick, it is possible to pass it
          after "\r\n" following the version string.

HAProxy should just add the Host header automatically for HTTP/1.1, really. Or if it wants to provide a mechanism for additional headers, it should be part of the httpchk syntax, not tacking it onto <version>
But whatever. Wrong bug tracker for that.


RequestAborted cancellation tokens not triggered for Kestrel

Example:
public class Startup
{
        static int count = 0;
        public void Configure(IApplicationBuilder app)
        {
            app.Run(async context =>
            {
                int requestId = count++;
                Console.WriteLine("Received request {0}", requestId);
                context.RequestAborted.Register(() =>
                {
                    Console.WriteLine("Cancellation token fired for request Id : {0}", requestId);
                });

                await context.Response.WriteAsync("Hello world" + requestId.ToString());
                await System.Threading.Tasks.Task.Delay(10 * 1000);
                await context.Response.WriteAsync("Finished writing" + requestId.ToString());
            });
        }
}

Host this application using Kestrel and make a request from IE or Chrome. Hit escape to notice that cancellation tokens are not triggered.

@halter73

@muratg Do we want this for beta7?

@halter73 can you check with @lodejard?

@halter73 @lodejard @DamianEdwards needed in RC1?

@muratg no, can be punted to post-RC

Fixed by https://github.com/aspnet/KestrelHttpServer/pull/325
Likely to be improved by https://github.com/aspnet/KestrelHttpServer/pull/408


docs: explain test_group > input_series, interval

It was a challenge to understand how unit testing works for a newcomer. Especially how the time series is simulated in the test. Added a brief explanation that stresses the relationship between a time interval and series input.

It feels like we should do better than adding comments. What would you think about adding a proper section in the file with some text?

I was following the existing style of the doc, more or less. Not sure what a "proper section" means in the current context.
The page is quite terse https://www.prometheus.io/docs/prometheus/latest/configuration/unit_testing_rules/ the explanations are mostly in the comments.

We discussed this during our bug scrub. We agree that just adding a short example here doesn't really help. A fully fledged tutorial on prometheus.io would be good, but also note that a web search for "prometheus unit test rules" easily points to https://www.robustperception.io/unit-testing-rules-with-prometheus/ and other helpful articles.


New icon too similar to sublime

The current icon on mac uses same colors as the sublime and has a very similar shape.
IMHO this is wrong because our icon would make our users think of Sublime.
fyi @egamma @bpasero

Sublime's new logo:

New logo looks equally similar. Also users are used to the old sublime logo and at least my brain works by first recognizing colors and only later shapes, that's why I easily confuse these two now.

Valid concern, but I don't see any "fix" for this.

@chrisdias fix is to use different colors or a different icon imho

With regards to the shape, we tested these icons quite extensively (with well over 100 people) and there was no indication that the shape of our new icon would be confused with the shape of the Sublime icon. Nobody suggested that they would confuse Sublime and VS Code, even those participants who use Sublime.

@stevencl this is not about the shape but the orange foreground color for the logo and the dark background color being almost the same colors as Sublime.

@isidorn mentioned the shape being similar so I just wanted to point out that during our studies we did not get that feedback. I understand that the colours are similar but I do not have any feedback on that.

Perhaps related to some thoughts here  #issuecomment-325998918 ?

MAKE VSCode BLUE AGAIN

We are using green for Insiders, orange for Stable, please see: https://github.com/Microsoft/vscode/issues/6607#issuecomment-334600845

@stevencl do many of those users you tested with regularly use both text editors or have them both installed on their computer? The icons really are very similar imho. Folded ribbon, with sharp angles, almost exactly the same colour....

Please consider reverting the icon to blue. It's very confusing on Linux too. Both tools I love suddenly decided to have similar icons.
Where can I find the old blue icon? I'll try overwriting Code's icon in my linux dev machine.

One more blue icon?! Aru ya kiddin'?! Orange was really nice. Sublime text icon is different from vs code. But if vs code and visual studio are opened at the same time, now they are EXACTLY SAME ICONS!


only print 1 for once

go version go1.10.3 darwin/amd64
M:ggo bmixo$ go run c.go
1
^Csignal: interrupt
only got once 1 printed until this proccess kill by system
did i did something wrong,why the "1" cannot print all along.
i simply  code like this:
package main

import (
	"fmt"
	"time"
)

func main() {

	go func() {
		for {
			fmt.Println("1")
			time.Sleep(1 * time.Second)
		}
	}()
	for {

		go func() {

			defer fmt.Println("menory full")
			for {
				time.Sleep(1 * time.Second)
			}

		}()
	}

}

log:
Sampling process 12894 for 3 seconds with 1 millisecond of run time between samples
Couldn't find _sigtramp symbol in expected dylibs
Sampling completed, processing symbols...
Analysis of sampling c (pid 12894) every 1 millisecond
Process:         c [12894]
Path:            /private/var/folders/qr/dz3qm1wx4dzb78yg5j12m5940000gn/T/go-build741984086/b001/exe/c
Load Address:    0x1000000
Identifier:      c
Version:         ???
Code Type:       X86-64
Parent Process:  go [12878]

Date/Time:       2018-06-30 19:48:50.819 +0800
Launch Time:     2018-06-30 19:48:27.225 +0800
OS Version:      Mac OS X 10.13.5 (17F77)
Report Version:  7
Analysis Tool:   /usr/bin/sample

Physical footprint:         23.0G
Physical footprint (peak):  23.0G
----

It is not a right place to ask for a programming advice, better ask in golang nuts forums.
...go/src/m1 % go run -race inf.go
1
1
race: limit on 8128 simultaneously alive goroutines is exceeded, dying
exit status 66

thanks ,i will ask on golang forums.

@Bmixo It normally would but you exceed the number of goroutines that can be alive at that moment. As you on one side (upper goroutine) printing 1 with a second delay, your for loop spawns new goroutines ceaselessly.


.save() does not save identifiers

Hi,
I am experimenting with doing automatic translations on some VTT files and I noticed when I save out the file, it does save the identifier lines in the new file. Even if I do not change the file at all they are not present in the saved file.
I will take a look and see if I can fix it and let you know.
C

Hi @KingWalrus, apologies for the late reply. Just released 0.4.1 that will save cue identifiers. Thanks!


React application renders twice per page load after applying SC2020-003-435698 fixes

Description
After applying the required changes for SC2020-003-435698 to our integrated mode JSS 13 application, the application appears to be being rendered twice server-side then twice client-side.
To check what's going on:

I've added console.log('MyApp->server->renderView'); to renderView in server/server.js
I've added the following log statements to render in src/RouteHandler.js:

console.log('MyApp->RouteHandler->render');
console.log('IS_SERVER:', isServer());

With the changes applied, I get the following log output in the server logs for each page load:
MyApp->server-renderView
MyApp->RouteHandler->render
IS_SERVER: true
MyApp->server-renderView
MyApp->RouteHandler->render
IS_SERVER: true

And the following in the browser console for each page load:
MyApp->RouteHandler->render
IS_SERVER: false
MyApp->RouteHandler->render
IS_SERVER: false

Expected behavior
The application should be rendered once per page load.
With the changes reverted, I get the following log output in the server logs for each page load:
MyApp->server-renderView
MyApp->RouteHandler->render
IS_SERVER: true

And the following in the browser console for each page load:
MyApp->RouteHandler->render
IS_SERVER: false

Steps To Reproduce

Create a default sample react app using jss create some-app react
Add the log statements above.
Follow the required steps to deploy it to Sitecore for integrated mode usage.
Load the app in the browser.
Check the log files to see how many times the application is rendered.

Possible Fix
Not sure, but reverting the changes fixes the problem.
Your Environment

Sitecore Version: 9.3.0
JSS Version: 13.2.2
Browser Name and version: Chrome 85.0.4183.121
Operating System and version (desktop or mobile): Windows 10 Pro
Link to your project (if available): Internal client project, unable to share.

Screenshots

@jimmah The client-side 2X render call is expected due to a change in ssrRenderComplete. React should handle this efficiently.

However we are unable to replicate the 2X call to renderView on JSS 13 w/ integrated mode. It's very odd that these changes would have any effect there, since this method is invoked external to the application itself. I'd recommend adding some additional debug information to your log statements in renderView to determine the source. The path argument perhaps?

Hi @nickwesselman, thanks for investigating.
Logging the path has indeed pointed at the issue -- it's actually the 404 in the console in the screenshot I attached that is causing the second render call. That's a bug in one of our components we've already got on the list to fix. As long as the 2x client-side render is expected, we can close this then.
Apologies for the time waster and thanks for your help!


SRE Testing: CEP78 Minting - ApiError::EarlyEndOfStream [17]

Observation:
Assuming the recent condor-rc3 commit was supposed to get cep working

successful installation of contract

minting with mint_call wasm V2

put-transaction session through Lane 3 - Large
execution_error: "ApiError::EarlyEndOfStream [17]"
"execution_result": {
"Version2": {
"initiator": {
"PublicKey": "010f4e780413b30a973bc2c6181959695af55edc6e5eebe7bbc11bb0148c335b80"
},
"error_message": "ApiError::EarlyEndOfStream [17]",
"limit": "100000000000",
"consumed": "411881110",
"cost": "100000000000",
"payment": [],
"transfers": [],
"size_estimate": 36772,
"effects": [

Slack Discussion: https://casper-labs-team.slack.com/archives/C01ULKL8G8J/p1719470146551339

closing in favor of ticket in cep-78 repo
https://github.com/casper-ecosystem/cep-78-enhanced-nft/issues/277


Overriding default variables

Hi,
I noticed I couldn't override the default $body-font-family variable using @import 'variables' due to a File to import not found error.
Instead of doing @import 'variables' as described in the current Readme, I simply imported the variables file via @import '~vuetify-scss/settings/variables'; which works perfectly.
Just posting in case anyone else ran into this problem.

you have to create your own variables file to use for overriding.

you have to create your own variables file to use for overriding.

Yes, I do this in my styles/main.scss. Not much other more than overriding default fonts and some other things will be here.

I'm sorry I should make the documentation more clear. Like @rogerriche said, the @import 'variables'; reference in the readme refers to your own variables file. The one in the vuetify-scss settings folder declares variables with the ! default' flag so they can be overridden by your own variables file. Perhaps in the future I can include a template variables file you can copy over or something but until then you need to just make your own and override the variables you wish to change.
I hope that clears things up. If you have any more problems just let me know.
Thanks! 😁


[Bug] MudSelectExtended - When using tab key in search box the component is throwing exception.

Using tab key from the search box below

Error in console log

Did you add script described at installation section in Readme?

Ah sorry, my bad. A colleague of mine integrated this into our projects so I assumed it was added throughout our web projects correctly. Thanks for the response.


Request: Support for rolling back

Having the possibility to resume operation at a previous block could be a great feature (for testing mostly).
Ex:

You generate few blocks to achieve a given state s0
You run 1 test specific to that state
you rollback to s0
You run another test
and ...

Yes we plan to do that

#21

closed as duplicate


Added Example 30

This example demonstrates how to import and perform inference using a model which has been trained in a hardware-aware fashion using an external library (i.e., not the AIHWKIT).
The external model is in the form of a standard pytorch model with hardware-aware trained weights. Input and output bounds, in addition to output scales are not defined. The example demonstrates how to set these using input range calibration and determine the model accuracy at different evaluation (drift) times.

Note: Before this is merged, the checkpoint file resnet9s.th needs to be uploaded to the tutorial COS and downloaded in the example using wget or a python-equivalent library.


[Driver][NFC] Define sanitizer mapping <kind, name, file> in one place

Lower maintenance cost for explicit mapping between sanitizer enum and string values.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - a56a28d62b157422891ef69b2d70443b5168ac03

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - a56a28d62b157422891ef69b2d70443b5168ac03

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 67e7c37bfe38a8cd4beb19f11af032af934a901f

Build failed
Swift Test OS X Platform
Git Sha - a56a28d62b157422891ef69b2d70443b5168ac03

Linux build fails with the following. Don't think that this is caused by this PR.
16:15:31 Compiling libc.c
16:15:31 Compiling Swift Module 'PackageDescription4' (11 sources)
16:15:31 Linking clibc
16:15:31 Compiling Swift Module 'SPMLibc' (1 sources)
16:15:31 <unknown>:0: warning: missing submodule 'clibc'
16:15:31
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swiftpm/Sources/SPMLibc/libc.swift:17:19: error: no such module 'clibc'
16:15:31 @_exported import clibc
16:15:31                   ^
16:15:31 --- bootstrap: error: build failed with exit status 1

There are (4) mapping operations:

option string -> enum (option parsing)
enum -> name string
enum -> file string
set -> concatenated string (I added this one in my last PR)

So we need to generate 4 different things from the *.def file:

llvm::StringSwitch
2,3) C++ switch
some array/container we can iterate (ideally the enum itself and "all-values" array are directly derived from enum

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - ce65e56b58a8444f78d5869a87ae52a9d703152a

Build failed
Swift Test Linux Platform
Git Sha - ce65e56b58a8444f78d5869a87ae52a9d703152a


fix(ci): Updates for ESLint v9

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.25%. Comparing base (128c875) to head (c36c537).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   98.26%   98.25%   -0.01%
==========================================
  Files           7        7
  Lines        1439     1431       -8
  Branches       54       54
==========================================
- Hits         1414     1406       -8
  Misses         25       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.