Add Bluetooth FW blobs for following CYW20829

Origin
The FW blobs come from the Infineon BLE stack integration package available on GitHub.
Type

[ ] Precompiled library
[x] Firmware image

Module
https://github.com/zephyrproject-rtos/hal_infineon
Purpose
The blobs provide firmware for the BLE controller subsystem of the CYW20829 device series. The firmware is used to bring up the subsystem hardware and run the controller.
Pull Request
https://github.com/zephyrproject-rtos/hal_infineon/pull/15/
Dependencies
None
License
Infineon/Cypress EULA: https://github.com/zephyrproject-rtos/hal_infineon/blob/master/zephyr/blobs/license.txt

Voted in Zephyr TSC 05 June 2024 and approved: https://docs.google.com/document/d/10V00WHKIJIL6DJrKDTimIIeHotD24t0nqf4ESg6fOO4/edit?pli=1

Add Bluetooth FW blobs for following CYW20829
https://github.com/zephyrproject-rtos/zephyr/issues/73180
Update to hal_infineon with binary blob for bluetooth fw
Ian Fyall raises a motion to approve this binary blob for inclusion. David Leach seconds. No objection, MOTION PASSES.


Compatability with Kgar's Tidy 5e Sheets

LazyMoney doesn't work with Kgar's Tidy 5e Sheets (which as I understood will continue on instead of regular Tidy 5e Sheets). This module is still in alpha.

Can confirm its not working on the latest version. Seems that the built in lazy money has also been removed from the new iteration of tidy sheet as of right now so all we have is the standalone module.

Update on this: p4535992 is looking into an approach that may work more universally, regardless of the sheet.

Note for myself:
If you wanted to add an event handler each time the Handlebar's render lifecycle occurs, here's a pattern of removing / re-adding on the tidy5e-sheet.renderActorSheet hook:
Hooks.on(`tidy5e-sheet.renderActorSheet`, () => {
  function myNamedFunctionToHandleTheEvent(event) {
    event.stopPropagation();
    console.log("Stopped the click event! Time to do something else...");
  }

  const element = document.querySelector(".some-selector-here");

  // This Hook triggers whenever a Handlebars application would normally trigger.
  // Meanwhile, Svelte does not remove and re-add controls.
  // We're looking at the same svelte controls as before.
  // So, to ensure we're not stacking events every time there's a render,
  // remove the event listener each time before reapplying it,
  // even if it's not actually applied yet.
  element?.removeEventListener(
    "click",
    myNamedFunctionToHandleTheEvent,
    // This options object should match the one subscribing.
    {
      capture: true,
    }
  );

  // Add the event listener
  element?.addEventListener(
    "click",
    myNamedFunctionToHandleTheEvent,
    // `capture` ensures that this listener triggers before the svelte binding
    {
      capture: true,
    }
  );
});

@p4535992, Enso did some testing for me, and after some discussion, here's an updated example to use:
// Make sure the function is outside of the Hook handling callback function.
// The function needs to stay the same and not be regenerated somehow.
function myNamedFunctionToHandleTheEvent(event) {
  event.stopPropagation();
  console.log("Stopped the click event! Time to do something else...");
}

Hooks.on(`tidy5e-sheet.renderActorSheet`, () => {
  const element = document.querySelector(".some-selector-here");

  // This Hook triggers whenever a Handlebars application would normally trigger.
  // Meanwhile, Svelte does not remove and re-add controls.
  // We're looking at the same svelte controls as before.
  // So, to ensure we're not stacking events every time there's a render,
  // remove the event listener each time before reapplying it,
  // even if it's not actually applied yet.
  element?.removeEventListener(
    "click",
    myNamedFunctionToHandleTheEvent,
    // This options object should match the one subscribing.
    {
      capture: true,
    }
  );

  // Add the event listener
  element?.addEventListener(
    "click",
    myNamedFunctionToHandleTheEvent,
    // `capture` ensures that this listener triggers before the svelte binding
    {
      capture: true,
    }
  );
});


Add email input validation to column tpl

Questions
Answers

Description?
Like #45 and #64

Type?
improvement

BC breaks?
no

Deprecations?
no

Thanks @davidglezz


ovpn-agent support?

I would first like to say that this project is amazing and ik its still under-dev,
but when I use ovpnagent with ovpn-dco i get:
Tue Nov 15 21:00:48 2022 HTTP request received from NAMED_PIPE
HTTP Request
method=POST
uri=/tun-open
version=1/1
[0] Host=\\.\pipe\ovpnagent
[1] Content-Type=application/json
[2] Content-Length=81
[3] Accept=*/*

Tue Nov 15 21:00:48 2022 TUN SETUP
TAP ADAPTERS:
guid='{ID}' index=85 name='Local Area Connection 2'
Open TAP device "Local Area Connection 2" PATH="\\?\ROOT#NET#0002#{ID}\ovpn-dco" SUCCEEDED
Tue Nov 15 21:00:48 2022 TUN CONFIRM
Tue Nov 15 21:00:49 2022 connection from C:\Path\to\Client.exe
Tue Nov 15 21:00:49 2022 HTTP request received from NAMED_PIPE
HTTP Request
method=POST
uri=/tun-setup
version=1/1
[0] Host=\\.\pipe\ovpnagent
[1] Content-Type=application/json
[2] Content-Length=809
[3] Accept=*/*

Tue Nov 15 21:00:49 2022 EXCEPTION
Destroyed previous TAP instance due to exception
json_parse: int adapter_index is missing
Tue Nov 15 21:00:51 2022 connection from C:\Path\to\Client.exe
Tue Nov 15 21:00:51 2022 HTTP request received from NAMED_PIPE
HTTP Request
method=POST
uri=/tun-open
...

But works Perfectly Fine without ovpn-agent, but my Client has to have admin privilages...

Oops Its fixed, I had an older commit.

Glad it works.

Hey, Any update on Singed Drivers?

@OPstriker What do you mean? You can get the latest version from here . You can also install openvpn-gui client built from the latest master branch, it will install the latest driver.

The test device I'm using to run the adapter has to have secure boot turned off which causes some issues during boot which I'm not sure why. So, I was wondering if signed drivers are available.

The test device I'm using to run the adapter has to have secure boot turned off which causes some issues during boot which I'm not sure why. So, I was wondering if signed drivers are available.

The drivers from the links I've posted above are signed.

Oh!, Might be something on my end.


[Bug]: Filtering does not work correctly within HA mobile app

Requirements

[X] I checked the troubleshooting section in the README to verify that I have the latest TrashCard version.
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
First of all, thanks for implementing #393.
I today gave it a try and observed, that on my mobile devices (iOS and/or android) the filtering is somewhat different from the desktop/browser. It seems, as far as i can reproduce it, that location filtering does not get involved on the mobile devices (or filtering at all).
Result on desktop:

Result on mobile:

i configured here a dayahead of 30 days just to find out which entries aren't filtered. The entries which are not "full day" (7:00 to 7:00) are the ones where i filtered location.
Oddly enough, even if a configure the "full day only" option, these events also aren't filtered out.
Oddly#2: Looking at it as i'm writing, i also observe a time difference of one day im some (not all!) entries. Have look at "Gelber Sack" as of 10/28, which ist shown as 10/27 in the mobile app (10/28 is the correct date). Also hold for "Restmülltone" 11/05, where 11/06 is on desktop (and which is right). I am not sure if the wrong dates also come from the TrashCard integration for visualisation.
Expected Behavior
No response
Steps To Reproduce
event_grouping: false
drop_todayevents_from: '10:00:00'
next_days: 30
pattern:

icon: mdi:biohazard
color: purple
type: organic
pattern: Schadstoff
label: Schadstoffmobil
pattern_exact: false
icon: mdi:newspaper
color: green
type: paper
pattern: Papiertonne
pattern_exact: false
icon: mdi:recycle-variant
color: amber
type: recycle
pattern: Sack
pattern_exact: false
icon: mdi:trash-can-outline
color: grey
type: waste
pattern: Restmüll
pattern_exact: false
icon: mdi:dump-truck
color: purple
type: others
alignment_style: left
items_per_row: 1
refresh_rate: 60
with_label: true
type: custom:trash-card
entities:
calendar.own_house
filter_events: true
only_all_day_events: true
location: höchsten

Context
No response
Environment
- Browser: Brave 1.68.134, Edge 129.0.2792.89
- HA Version: 2024.7.3
- TrashCard: 2.4.2
- iOS App: 2024.9.4 (2024.905)
- Adroid App: 2024.9.4-full

Debug data
No response
Anything else?
No response

event_grouping: false
drop_todayevents_from: '10:00:00'
next_days: 30
pattern:
  - icon: mdi:biohazard
    color: purple
    type: organic
    pattern: Schadstoff
    label: Schadstoffmobil
    pattern_exact: false
  - icon: mdi:newspaper
    color: green
    type: paper
    pattern: Papiertonne
    pattern_exact: false
  - icon: mdi:recycle-variant
    color: amber
    type: recycle
    pattern: Sack
    pattern_exact: false
  - icon: mdi:trash-can-outline
    color: grey
    type: waste
    pattern: Restmüll
    pattern_exact: false
  - icon: mdi:dump-truck
    color: purple
    type: others
alignment_style: left
items_per_row: 1
refresh_rate: 60
with_label: true
type: custom:trash-card
entities:
  - calendar.own_house
filter_events: true
only_all_day_events: true
location: höchsten

I am using the mobile apps with different users. When using these users on the desktop, the behaviour is still correct in desktop. When using the desktop users on the mobile, the error still occours. So it has nothing to do with users.

When using a browser on the mobile, the behaviour is fine (as on desktop), so is has something to do with the HA app itself.

Dates, when using browser on mobile device, are also correctly presented.

I just observed - both on the desktop and on the Android mobile apps - that the date filter behaves somehow strange. I have set next_days: 1 and would expect that only events for tomorrow are displayed. However,, the card displays events also for the day after tomorrow (at least, as there are no events more days in the future).
Maybe that is a similar problem?

Might be. Maybe correspondents to the day-calculation-glitch i observed (day from calender is presented one day too early in result list, so 5th nov is presented as 4th nov). Not always, though. Currently everthing seems to be ok (maybo mobile apps got some updates, didnt check).


Purge cloudflare cache for collective pages on certain actions

Resolve https://github.com/opencollective/opencollective/issues/1870

Coverage increased (+0.7%) to 67.371% when pulling acaf86c689cfb92830161905369ec1c7a7fe1ebb on feat/cloudflare-cache-purge into b5b07c7b9da0b79d5bafaaa41469c8aab0f6a051 on master.

Looks good, let's try on staging before merging.

Tests on staging went well. Also added the configuration to prod.
:warning: Cloudflare doesn't allow to generate multiple API KEYs, so the key is shared between staging and production.


More verbose exception handler

Fixes #9
If you think this is the right approach.

I'm specifically not doing toString, but instead sending it as an object. This way when your log transport is ELK, Datadog, or any other smart logging system, the object will be parsed and becomes searchable.
The default nest logger isn't that good, try using Winston with it as I mentioned in the issue you've opened (also added a link to a package).


WithAppOnly implementation

fixes #63
CC @jmprieur @darrelmiller

@baywet : I don't think you need the GraphServiceClientFactory class any longer.

@jmprieur thanks! good catch, I had missed it. #75


Document focus suggest details with ctrl+alt+space

This change allows the current ctrl + alt + space shortcut perform the following action:

When shortcut is pressed, document focus moves to the suggest details widget. This allows it to be used by screen readers.
When arrow keys are used within the suggest widget, while details is focused, the focus indicator is removed from details, and removes the details state.
When ctrl + alt + space is pressed when in suggest, but details is not shown, opens details

This changes the behavior in the following way:

When moving between different items in the list, Details state is removed. This is because the details focus indicator now follows page focus. The details state allows keyboard users to navigate within long documentation using page up and page down. The user will need to re-enter the details state each time. Ie. it is not sticky.

This makes the following additional changes:

move operations performed on the details dom to methods in suggestWidgetDetails.ts.
adds a case statement for handling operations on state exit. Some operations could be moved here to remove duplication.
adds button semantics to the close button

A followup to this behavior to make the suggest details widget more accessible would be to upgrade it to a modal dialog when ctrl+alt+space is pressed, allowing visual keyboard users to tab-focus to links within the markdown documentation

@meganrogge @jrieken thanks in advance for taking a look.

Thanks very much for working on this. I will test it tomorrow.
Have you tried out the new Accessible View feature @jjaeggli? I wonder if we should also use that for the details so that SR users can inspect it char by char.
Example:
With screen reader mode on, trigger a hover and focus it. Use alt+f2 to inspect it in the accessible view. We could add support for that here too.

@jjaeggli I'm using a laptop atm in insiders, so have configured a different key binding for accessibility help and it's working for me. Can you run Developer: Toggle Keyboard Shortcuts Troubleshooting to see what's happening?

ctrl+space still doesn't work for me to trigger inline suggest and thus I cannot test this change, so will have to leave it with @jrieken, but your explanation of the change above makes sense to me

Is there any progress here?
@jrieken could you please take a look at this

ctrl+space still doesn't work for me to trigger inline suggest and thus I cannot test this change

@meganrogge This is not about inline suggest but about normal completions which do trigger via ctrl+space unless macOS took that to switch keyboard layouts. Uncheck those

When ctrl + alt + space is pressed when in suggest, but details is not shown, opens details

That was the part that was senstive to timing because details show via RAF and therefore focus cannot be set immediately but only once the details have been rendered


Add animation css prop for IonContent

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #19957
What is the new behavior?

Added animation prop for the styles of IonContent element

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Thanks for the PR! We appreciate the work you put into this.
As I mentioned in https://github.com/ionic-team/ionic/issues/19957 we are going to be rolling out a broader animation solution in the next major release of Ionic Framework. I am going to close this PR as the new animation solution should cover this use case. Thanks!

@liamdebeasi exist any Roadmap to see when we're going to have that new version? Thanks mate!


Use explicit type in joint_state_broadcaster test

This use of auto is causing a static assert on RHEL. Explicitly specifying the type seems to resolve the failure and allow the test to be compiled.
Example failure: https://build.ros2.org/view/Gbin_rhel_el864/job/Gbin_rhel_el864__joint_state_broadcaster__rhel_8_x86_64__binary/325/console
This bug is blocking ros2_controllers builds on RHEL for all of Galactic, Humble, and Rolling.

DEBUG: /usr/bin/c++ -DDEFAULT_RMW_IMPLEMENTATION=rmw_cyclonedds_cpp -DRCUTILS_ENABLE_FAULT_INJECTION -I/opt/ros/galactic/src/gmock_vendor/include -I/opt/ros/galactic/src/gtest_vendor/include -I/builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/include -isystem /opt/ros/galactic/include -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wall -Wextra -std=gnu++17 -MD -MT CMakeFiles/test_joint_state_broadcaster.dir/test/test_joint_state_broadcaster.cpp.o -MF CMakeFiles/test_joint_state_broadcaster.dir/test/test_joint_state_broadcaster.cpp.o.d -o CMakeFiles/test_joint_state_broadcaster.dir/test/test_joint_state_broadcaster.cpp.o -c /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp
DEBUG: In file included from /usr/include/c++/8/vector:64,
DEBUG:                  from /usr/include/c++/8/functional:62,
DEBUG:                  from /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:17:
DEBUG: /usr/include/c++/8/bits/stl_vector.h: In instantiation of 'class std::vector<const char* const, std::allocator<const char* const> >':
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h:3147:26:   required from 'class testing::internal::ElementsAreArrayMatcher<const char* const>'
DEBUG: /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:701:5:   required from here
DEBUG: /usr/include/c++/8/bits/stl_vector.h:351:21: error: static assertion failed: std::vector must have a non-const, non-volatile value_type
DEBUG:        static_assert(is_same<typename remove_cv<_Tp>::type, _Tp>::value,
DEBUG:                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DEBUG: In file included from /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-spec-builders.h:75,
DEBUG:                  from /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-generated-function-mockers.h:47,
DEBUG:                  from /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-function-mocker.h:39,
DEBUG:                  from /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock.h:61,
DEBUG:                  from /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:23:
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h: In instantiation of 'testing::internal::ElementsAreArrayMatcher<T> testing::ElementsAreArray(std::initializer_list<_Tp>) [with T = const char* const]':
DEBUG: /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:701:5:   required from here
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h:3533:47: error: could not convert 'testing::ElementsAreArray(Iter, Iter) [with Iter = const char* const*; typename std::iterator_traits<_Iterator>::value_type = const char*](xs.std::initializer_list<const char* const>::end())' from 'ElementsAreArrayMatcher<const char*>' to 'ElementsAreArrayMatcher<const char* const>'
DEBUG:    return ElementsAreArray(xs.begin(), xs.end());
DEBUG:                                                ^
DEBUG: In file included from /usr/include/c++/8/ext/alloc_traits.h:36,
DEBUG:                  from /usr/include/c++/8/bits/basic_string.h:40,
DEBUG:                  from /usr/include/c++/8/string:52,
DEBUG:                  from /usr/include/c++/8/stdexcept:39,
DEBUG:                  from /usr/include/c++/8/array:39,
DEBUG:                  from /usr/include/c++/8/tuple:39,
DEBUG:                  from /usr/include/c++/8/functional:54,
DEBUG:                  from /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:17:
DEBUG: /usr/include/c++/8/bits/alloc_traits.h: In instantiation of 'static void std::allocator_traits<std::allocator<_CharT> >::deallocate(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, std::allocator_traits<std::allocator<_CharT> >::pointer, std::allocator_traits<std::allocator<_CharT> >::size_type) [with _Tp = const char* const; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<const char* const>; std::allocator_traits<std::allocator<_CharT> >::pointer = const char* const*; std::allocator_traits<std::allocator<_CharT> >::size_type = long unsigned int]':
DEBUG: /usr/include/c++/8/bits/stl_vector.h:304:19:   required from 'void std::_Vector_base<_Tp, _Alloc>::_M_deallocate(std::_Vector_base<_Tp, _Alloc>::pointer, std::size_t) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>; std::_Vector_base<_Tp, _Alloc>::pointer = const char* const*; std::size_t = long unsigned int]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:285:2:   required from 'std::_Vector_base<_Tp, _Alloc>::~_Vector_base() [with _Tp = const char* const; _Alloc = std::allocator<const char* const>]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:570:7:   required from 'std::vector<_Tp, _Alloc>::~vector() [with _Tp = const char* const; _Alloc = std::allocator<const char* const>]'
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h:3131:7:   required from here
DEBUG: /usr/include/c++/8/bits/alloc_traits.h:462:13: error: 'using allocator_type = class std::allocator<const char* const>' {aka 'class std::allocator<const char* const>'} has no member named 'deallocate'; did you mean 'allocator'?
DEBUG:        { __a.deallocate(__p, __n); }
DEBUG:          ~~~~^~~~~~~~~~
DEBUG:          allocator
DEBUG: /usr/include/c++/8/bits/alloc_traits.h: In instantiation of 'static _Tp* std::allocator_traits<std::allocator<_CharT> >::allocate(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, std::allocator_traits<std::allocator<_CharT> >::size_type) [with _Tp = const char* const; std::allocator_traits<std::allocator<_CharT> >::pointer = const char* const*; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<const char* const>; std::allocator_traits<std::allocator<_CharT> >::size_type = long unsigned int]':
DEBUG: /usr/include/c++/8/bits/stl_vector.h:296:33:   required from 'std::_Vector_base<_Tp, _Alloc>::pointer std::_Vector_base<_Tp, _Alloc>::_M_allocate(std::size_t) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>; std::_Vector_base<_Tp, _Alloc>::pointer = const char* const*; std::size_t = long unsigned int]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:311:33:   required from 'void std::_Vector_base<_Tp, _Alloc>::_M_create_storage(std::size_t) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>; std::size_t = long unsigned int]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:260:9:   required from 'std::_Vector_base<_Tp, _Alloc>::_Vector_base(std::size_t, const allocator_type&) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>; std::size_t = long unsigned int; std::_Vector_base<_Tp, _Alloc>::allocator_type = std::allocator<const char* const>]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:460:61:   required from 'std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>]'
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h:3131:7:   required from 'testing::internal::PredicateFormatterFromMatcher<M> testing::internal::MakePredicateFormatterFromMatcher(M) [with M = testing::internal::ElementsAreArrayMatcher<const char* const>]'
DEBUG: /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:701:5:   required from here
DEBUG: /usr/include/c++/8/bits/alloc_traits.h:436:20: error: 'using allocator_type = class std::allocator<const char* const>' {aka 'class std::allocator<const char* const>'} has no member named 'allocate'; did you mean 'allocator'?
DEBUG:        { return __a.allocate(__n); }
DEBUG:                 ~~~~^~~~~~~~
DEBUG:                 allocator
DEBUG: In file included from /usr/include/c++/8/vector:62,
DEBUG:                  from /usr/include/c++/8/functional:62,
DEBUG:                  from /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:17:
DEBUG: /usr/include/c++/8/bits/stl_construct.h: In instantiation of 'void std::_Construct(_T1*, _Args&& ...) [with _T1 = const char* const; _Args = {const char* const&}]':
DEBUG: /usr/include/c++/8/bits/stl_uninitialized.h:83:18:   required from 'static _ForwardIterator std::__uninitialized_copy<_TrivialValueTypes>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const char* const*, std::vector<const char* const, std::allocator<const char* const> > >; _ForwardIterator = const char* const*; bool _TrivialValueTypes = false]'
DEBUG: /usr/include/c++/8/bits/stl_uninitialized.h:134:15:   required from '_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = __gnu_cxx::__normal_iterator<const char* const*, std::vector<const char* const, std::allocator<const char* const> > >; _ForwardIterator = const char* const*]'
DEBUG: /usr/include/c++/8/bits/stl_uninitialized.h:289:37:   required from '_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = __gnu_cxx::__normal_iterator<const char* const*, std::vector<const char* const, std::allocator<const char* const> > >; _ForwardIterator = const char* const*; _Tp = const char* const]'
DEBUG: /usr/include/c++/8/bits/stl_vector.h:463:31:   required from 'std::vector<_Tp, _Alloc>::vector(const std::vector<_Tp, _Alloc>&) [with _Tp = const char* const; _Alloc = std::allocator<const char* const>]'
DEBUG: /opt/ros/galactic/src/gmock_vendor/include/gmock/gmock-matchers.h:3131:7:   required from 'testing::internal::PredicateFormatterFromMatcher<M> testing::internal::MakePredicateFormatterFromMatcher(M) [with M = testing::internal::ElementsAreArrayMatcher<const char* const>]'
DEBUG: /builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/test/test_joint_state_broadcaster.cpp:701:5:   required from here
DEBUG: /usr/include/c++/8/bits/stl_construct.h:75:13: error: invalid static_cast from type 'const char* const*' to type 'void*'
DEBUG:      { ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...); }
DEBUG:              ^~~~~~~~~~~~~~~~~~~~~~~
DEBUG: make[2]: Leaving directory '/builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/obj-x86_64-redhat-linux-gnu'
DEBUG: make[1]: Leaving directory '/builddir/build/BUILD/ros-galactic-joint-state-broadcaster-1.4.0/obj-x86_64-redhat-linux-gnu'
DEBUG: make[2]: *** [CMakeFiles/test_joint_state_broadcaster.dir/build.make:79: CMakeFiles/test_joint_state_broadcaster.dir/test/test_joint_state_broadcaster.cpp.o] Error 1
DEBUG: make[1]: *** [CMakeFiles/Makefile2:236: CMakeFiles/test_joint_state_broadcaster.dir/all] Error 2
DEBUG: make: *** [Makefile:149: all] Error 2

@cottsay would you like a new release with this? the new versions for Humble and Rolling were merged into rosdistro yesterday

would you like a new release with this?

It's been broken for a long time. I don't think it's worth a release on its own, so as long as you're making consistent releases among all of the distros, I think it can wait until the next train.
Thanks!


[Bug]: Drawer is not actually a drawer

Reproduction
https://codesandbox.io/p/devbox/shadcn-vue-drawerdemo-725z9h
Describe the bug
The Drawer component isn't really a drawer. It's a mobile dialog replacement. This is confusing when the developer is trying to find a typical drawer that opens from the left or right, assumes the shadcn-vue has that functionality for its Drawer component (because why wouldn't it?), do a ton of research into the vendor child components just to realize it's a pop-up-from-bottom only drawer. At the very least, we should add more details to the Drawer doc to say that this is purely a dialog alternative for mobile.
System Info
System:
    OS: macOS 14.6.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 4.95 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
    pnpm: 9.10.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 129.0.6668.59
    Chrome Canary: 122.0.6180.0
    Safari: 17.6
  npmPackages:
    @vueuse/core: ^10.11.1 => 10.11.1
    radix-vue: ^1.9.4 => 1.9.4
    vue: ^3.4.27 => 3.4.37

Contributes

[X] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

I think what you're searching for is the Sheet component?

We are following the component design (and it's naming) as the main Shadcn UI repo. Thus closing this as not


Connectivity plugin not detecting wi-fi state

System info
Issue occurs on: Android / rarely iOS
Plugin name: connectivity_plus
Plugin version: 1.0.3 and master
Flutter doctor output:
[√] Flutter (Channel unknown, 2.0.3, on Microsoft Windows [Version 10.0.19042.1052], locale en-US)
    • Flutter version 2.0.3 at C:\Users\User\fvm\versions\2.0.3
    • Framework revision 4d7946a68d (3 months ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at D:\Dev\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = D:\Dev\SDK
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at D:\Programs\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[√] Connected device (3 available)
    • POCO F1 (mobile) • a89301e2 • android-arm64  • Android 9 (API 28)
    • Chrome (web)     • chrome   • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)       • edge     • web-javascript • Microsoft Edge 91.0.864.41

• No issues found!

Steps to Reproduce

Open example from this repository
Run
Turn all internet off
State on screen is none
Turn on mobile data
State on the screen is mobile
Turn data off
State on the screen none
Turn wi-fi on
State on the screen none (didn't change)

Logs
No need, no logs.
Analyze:
flutter analyze
Analyzing connectivity_plus...
No issues found! (ran in 2.9s)

flutter doctor -v
[√] Flutter (Channel unknown, 2.0.3, on Microsoft Windows [Version 10.0.19042.1052], locale en-US)
    • Flutter version 2.0.3 at C:\Users\User\fvm\versions\2.0.3
    • Framework revision 4d7946a68d (3 months ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at D:\Dev\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = D:\Dev\SDK
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at D:\Programs\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[√] Connected device (3 available)
    • POCO F1 (mobile) • a89301e2 • android-arm64  • Android 9 (API 28)
    • Chrome (web)     • chrome   • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)       • edge     • web-javascript • Microsoft Edge 91.0.864.41

• No issues found!

Devices that have that problem: iPhone 11 (iOS 14.4.2), Mi 9T pro (miui 12.0.2), Poco F1 (AOSiP 9 from March 5, 2020).


feat: add vscode configurations

Summary of PR
Adding a base config for repos. Note there are many other extensions we recommend. None of the following has been implemented. For examples:
Gurmukhi Utils

"kavod-io.vscode-jest-test-adapter" for testing

Website

"graphql.vscode-graphql" idk what for -- didn't use this myself yet, but I would imagine it ties in with gatsby

Docs

"yzhang.markdown-all-in-one" to create the table of contents in markdown
"davidanson.vscode-markdownlint" formatter / linter, this one has config given below, which can be added to settings.json as well
"bierner.markdown-emoji" to show emojis supported by github in markdown preview of vscode
"bierner.markdown-preview-github-styles" to make vs codes preview match more closely with github's preview

Format/Lint rules for markdown:
"markdownlint.config": {
  "default": true,
  "heading-increment": true,
  "heading-style": { "style": "atx" },
  "no-missing-space-atx": true,
  "no-multiple-space-atx": true,
  "heading-start-left": true,
  "no-emphasis-as-heading": false,
  "hr-style": { "style": "---" },
  "ul-style": { "style": "dash" },
  "list-indent": true,
  "blanks-around-lists": true,
  "fenced-code-language": true,
  "code-block-style": { "style": "fenced" },
  "code-fence-style": { "style": "backtick" },
  "no-space-in-code": true,
  "no-multiple-space-blockquote": true,
  "no-space-in-emphasis": true,
  "no-reversed-links": true,
  "no-space-in-links": true,
  "no-empty-links": true,
  "no-inline-html": {
    "allowed_elements": ["a", "code", "image", "img"]
  },
  "single-trailing-newline": true
},

Personal
And then there are some extension I use personally which may or may not be helpful to our team:

"xabikos.javascriptsnippets" for adding code snippets really quickly (e.g. clg<tab> expands to console.log(<cursor>))
"yo1dog.cursor-align" for making pretty code blocks (e.g. contributing.md)

Tests for unexpected behavior

none_whatsoever

Time spent on PR
10 minutes
Reviewers
@Harjot1Singh

Could you please redo the PR?

Looks like you already did here https://github.com/shabados/actions/commit/937ddba70b7aa3071351152e7b1bda7bf5e0bb02
Do you want to include any of the extensions/settings mentioned in OP?

I've committed the extensions directly to main.


How to specify examples?

For use with fastify-swagger, I'd like to be able to add examples at the property level and at the schema level.
From reading the code, it seems like this library just pipes the output from https://github.com/StefanTerdell/zod-to-json-schema, but that library only concerns itself with json schema, not OpenAPI, so it wouldn't even be in scope for that library to emit examples.
So how would I go about adding example property/schema here? if it's not possible, what needs to be changed/added?
Thanks

It depends on this I guess
https://github.com/colinhacks/zod/pull/2549

As an update: colinhacks rejected the PR and is working on a RFC to solve the metadata issue.


render view broken in saved HTML scene

When saving a scene as html (such as in our demo here), the render view is broken and gives the following error in the console:
Uncaught TypeError: Cannot read properties of undefined (reading 'toFixed')
from this line:
const c = "azimuth: " + this.scene.renderAzimuth.toFixed(0) + " elevation: " + this.scene.renderElevation.toFixed(0);
@cdrake , were there any changes to the scene format related to the render view?
All other non-render views work as they should.

@hanayik -  There were no changes to scene data format.  The scene data is now accessed through the document instance. INITIAL_SCENE_DATA was added to populate the scene data.


Added "Scroll-to-Top" Button to new VigyBag Website

Fixes Issue
Issue closes #1540
Changes proposed
Hey @codervivek5  I have added the scroll to top button the website

Implemented a GoToTop component using React and styled-components.
Added a button that appears when the user scrolls down isVisible state.
Background color in base #16a34a | On Hover #005a01
Added a smooth hover effect and smooth animation

Screenshots
https://github.com/codervivek5/VigyBag/assets/101971980/7a7befce-3272-4b92-bab9-d88649737faf
Note to reviewers

Summary by CodeRabbit

New Features

Introduced a "Go to Top" button that allows users to easily scroll back to the top of the page. The button appears based on the user's scroll position and features a smooth scrolling animation.

Dependencies

Added styled-components to the project dependencies for styling the new "Go to Top" button component.

debug this code ... vercel deployment failed so if I merged your PR then the change will not reflected kindly solve these
Error:
[03:47:27.916] Running build in Washington, D.C., USA (East) – iad1
[03:47:29.526] Cloning github.com/codervivek5/VigyBag (Branch: main, Commit: 0a27834)
[03:47:35.586] Cloning completed: 6.058s
[03:47:36.242] Restored build cache
[03:47:36.387] Running "vercel build"
[03:47:37.496] Vercel CLI 34.2.8
[03:47:39.209] Installing dependencies...
[03:47:42.952]
[03:47:42.953] up to date in 2s
[03:47:42.954]
[03:47:42.954] 126 packages are looking for funding
[03:47:42.954]   run npm fund for details
[03:47:42.985] Detected package-lock.json generated by npm 7+
[03:47:42.986] Running "npm run build"
[03:47:43.580]
[03:47:43.580] ><EMAIL_ADDRESS>build
[03:47:43.581] > vite build
[03:47:43.581]
[03:47:44.498] vite v5.3.2 building for production...
[03:47:44.612] transforming...
[03:47:48.650] ✓ 72 modules transformed.
[03:47:48.656] x Build failed in 4.10s
[03:47:48.661] error during build:
[03:47:48.661] [vite]: Rollup failed to resolve import "styled-components" from "/vercel/path0/src/components/gototop.jsx".
[03:47:48.662] This is most likely unintended because it can break your application at runtime.
[03:47:48.662] If you do want to externalize this module explicitly add it to
[03:47:48.662] build.rollupOptions.external
[03:47:48.662]     at viteWarn (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-C1-ZB6nQ.js:65876:17)
[03:47:48.662]     at onwarn (file:///vercel/path0/node_modules/@vitejs/plugin-react/dist/index.mjs:266:9)
[03:47:48.662]     at onRollupWarning (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-C1-ZB6nQ.js:65909:5)
[03:47:48.662]     at onwarn (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-C1-ZB6nQ.js:65571:7)
[03:47:48.662]     at file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:18514:13
[03:47:48.662]     at Object.logger [as onLog] (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:20162:9)
[03:47:48.662]     at ModuleLoader.handleInvalidResolvedId (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:19104:26)
[03:47:48.662]     at file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:19062:26
[03:47:48.696] Error: Command "npm run build" exited with 1
[03:47:49.535]

check this GPT responce:
https://chatgpt.com/share/5fd11907-26cf-4d10-9da8-6220ad837ed2

do not build the project this process internally work only check the dependency issues

Done @codervivek5, thanks for letting me know!

Is this design responsive?

Is this design responsive?

Yes @codervivek5
https://github.com/codervivek5/VigyBag/assets/101971980/6ea9cc2e-1cbe-4d43-93fe-d166718eb340


Filter out duplicate trusted task records

This filters out all duplicate trusted task records based on their reference. Previously we would de-duplicate only if the records were adjacent.
Reference: https://issues.redhat.com/browse/EC-1015

Previously we would de-duplicate only if the records were adjacent.

This was very much intentional: https://issues.redhat.com/browse/HACBS-2394

It seems that the schema check in ec-policies needs to change to allow duplicate entries then.
I'm not sure that build-definitions can produce equal digests for two builds, the git references should be different and the images should have different digests as they differ in annotations and in the config/created.

It seems that the schema check in ec-policies needs to change to allow duplicate entries then.
:+1:

I'm not sure that build-definitions can produce equal digests for two builds, the git references should be different and the images should have different digests as they differ in annotations and in the config/created.

I don't remember exactly the scenario in which this may occur, but it may have something to do with the build scripts taking shortcuts to not rebuild an image bundle.

I don't remember exactly the scenario in which this may occur, but it may have something to do with the build scripts taking shortcuts to not rebuild an image bundle.

Let's not find out, shall we...


Fix Windows and iOS compile CFFI issues

With newest Lime (6.4.0) we were getting some build errors on Windows and iOS. It's probably due to some library that called a Lime system function in a macro when it shouldn't, possibly via OpenFL. Nonetheless Lime can protect against this. I believe this PR will resolve the issues.
Example errors:
  - Running command: haxe Export/windows/cpp/final/haxe/final.hxml -D no_console
 C:/cygwin64/opt/haxe/lib/lime/6,4,0/lime/system/System.hx:713: characters 19-58 : Class<lime._backend.native.NativeCFFI> has no field lime_system_get_device_model
 C:/cygwin64/opt/haxe/lib/lime/6,4,0/lime/system/System.hx:744: characters 20-60 : Class<lime._backend.native.NativeCFFI> has no field lime_system_get_device_vendor
 C:/cygwin64/opt/haxe/lib/lime/6,4,0/lime/system/System.hx:841: characters 22-63 : Class<lime._backend.native.NativeCFFI> has no field lime_system_get_platform_label
 C:/cygwin64/opt/haxe/lib/lime/6,4,0/lime/system/System.hx:905: characters 23-66 : Class<lime._backend.native.NativeCFFI> has no field lime_system_get_platform_version

Seems to be related to:

http://community.openfl.org/t/cffi-errors-with-macro/10563
http://community.openfl.org/t/error-float-of-string-windows-target/10189/11

Looks good, thanks! :smile:


Require native component: "React NativeUnityView" was not found in the UIManager

facing same issued today, after the importing unity iOS build to the project, followed the processes in the Xcode, build succeed in the physical phone.
But when the apps show the UnityView page, this error shown up

same issue for me

For my case: I fix it by install this package again by npm. I am not sure how it happens. But I solve this issue twice with this method, of course pods will need to reinstall and update as well.


feat: animate when switching between pages

Please do tell what kind of animation you are planning to implement. Animation should be short and simple

@ashuvssut I like to solve this issue

Please do tell what kind of animation you are going to implement

What kind of animation have you thought to implement?

Will update before I start, looking into few options. I'll go through the website and try to provide a suitable animation for it.

I can see some flickering issue in header when navigating, I'll try to fix that as well

Can you fix that first? It would be nice if you could open up a issue and its separate PR that fixes it.
That fix will be merged first

@ashuvssut planning to implement linear animation since it will be more simpler. Adding two gifs for refer top to down and left to right animations, Hava a look and let me know your suggestions. And I was using framer

Lets go with the first one (top to bottom animation).


Add unit test to confirm the generation of the event site

Adds unit-test for confirmation whether the event site is being generated or not. In the past, there have been any instances where the tests pass successfully but the app generator stuck in the middle while generating the event site. This test aims to ensure that the whole event site is being generated.
I will be adding more unit tests. This was a major critical test so added it first.
@aayusharora @mariobehling Please review. Thanks! :)

Codecov Report

Merging #1039 into development will increase coverage by 34.29%.
The diff coverage is 60%.

@@               Coverage Diff                @@
##           development    #1039       +/-   ##
================================================
+ Coverage        32.28%   66.57%   +34.29%
================================================
  Files                7        7
  Lines             1112     1116        +4
  Branches           172      174        +2
================================================
+ Hits               359      743      +384
+ Misses             753      373      -380

Impacted Files
Coverage Δ

src/backend/buildlogger.js
84.61% <60%> (+51.28%)
:white_check_mark:

src/backend/fold.js
84.94% <ø> (+23.46%)
:white_check_mark:

src/backend/mailer.js
65.33% <ø> (+36%)
:white_check_mark:

src/backend/dist.js
46.4% <ø> (+39.54%)
:white_check_mark:

src/backend/generator.js
70.9% <ø> (+55.73%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed24563...62c675f. Read the comment docs.

Thanks @Princu7


Add SilenceProvider.cs useful for WasapiLoopbackCapture

Add SilenceProvider.cs useful for WasapiLoopbackCapture when we want the silence also to be captured.
You may begin with:
using NAudio;
using NAudio.Wave;

class SilenceProvider : IWaveProvider
    {
        public SilenceProvider(WaveFormat wf) { this.WaveFormat = wf; }

        public int Read(byte[] buffer, int offset, int count)
        {
            buffer.Initialize();
            return count;
        }

        public WaveFormat WaveFormat { get; private set; }
    }

good idea, have added one in


rTorrent output plugin

This is a WIP branch of an rTorrent output plugin.
Example config:
rtorrent:
  uri: 'scgi://localhost:5000'
  directory: '/path/default_dest/'
  custom1: '/path/{{ series_name }}'

RScully,
I was also working on a RTorrent Plugin. See pull request https://github.com/Flexget/Flexget/pull/495
Perhaps we should work on it together?

So is it working yet.

The plugin works, but does not yet start torrents automatically. It isn't that this functionality is difficult, I just want to make sure it is implemented the correct way so I've been putting it off. It is the very next thing on my todo list.
@stevezau kind of a weird coincidence that the day I decide to finally write this (after months of putting it off) is the same time someone else does too; if only I had put it off for another week I probably wouldn't have had to write this at all. But, it's a little late for me to throw in the towel now. Feel free to take a look at my code and add your input, I'd love the collaboration!

@RSully Yeah it is, i saw you mention it on the IRC channel but you had left before I could let you know i was working on one as well.
anyway, no point working on two different code bases, lets discuss on the IRC channel and merge?

@RSully FYI: Currently http(s) and a local socket are not supported. I suggest you support both of these as SCGI insecure compare to http/local.
Pyrobase appears to support both http(s) and local socket in the master branch on github https://github.com/pyroscope/pyrobase/tree/master/src/pyrobase/io
For some reason pypi for pyrocore is not up-to-date. I created a ticket here https://github.com/pyroscope/pyrobase/issues/2

@RSully check my latest commit. Still needs to be refined but it's functional

Woah, lots of changes in 1 commit. Will take a bit to fully absorb.
I did go ahead and revert a couple things though; specifically you reverted from using the new RPC commands to the old ones, and stuff like directory vs path seem weird and add complexity. Hope that is alright!
This latest commit is untested, and I am a little confused about error handling with your new classes. I'll be on IRC for a while and will try to figure it out tonight.

@gazpachoking code is ready for review..
I can't change WIP title as it's owned by @RSully

Lot to review, especially since I don't know anything about rtorrent. Cursory glance seems good though. @RSully @stevezau If you guys both think it's ready I'll merge.

@gazpachoking im happy for it to be merged

@stevezau @RSully Does this allow functionality such as Deluge's movedone?

@cvium possibly, what the use case and ill let you know to do it?

@stevezau Right now I have 2 tasks. One downloads and lets Deluge know where to place finished downloads (eg. move to /some/staging/area/{{series_name}}) via movedone setting.

What has kept me from using rTorrent is that it lacks the movedone option.

rTorrent can move completed stuff though. I think we just need to set correct options somehow. This PR is looking quite awesome, rarely I have seen such well written and tested PRs :)

You can emulate movedone by setting a custom field and then a completion handler in rtorrent's config to move the file and change the directory.

I'm well aware that rTorrent is very complex and offers a huge variety of customizations, but I'm much too lazy to read up on it. I just want something simple to set up :stuck_out_tongue:

@cvium rTorrent can auto move on complete via the rtorrent config.. take a look at http://flexget.com/wiki/Cookbook/rTorrent
You can do something similar with this plugin.
tasks:
TV:
accept_all: yes
rtorrent:
uri: scgi://localhost:5000
start: yes
path: /downloads/tv
TV-MOVE:
from_rtorrent:
uri: scgi://localhost:5000
path: /data/incoming/tv
regexp:
accept_excluding:
- complete
from: custom1
rtorrent:
action: update
uri: scgi://localhost:5000
path: /data/TVShows
custom1: complete

@paranoidi lol... using mock to write the tests was actually pretty cool.. i plan on using it alot more.. starting on the new ui next.

@stevezau Is it possible to implement magnets? I know the ruTorrent supports them.

@stevezau @RSully I've been toying around with rTorrent this afternoon and it doesn't seem to be working properly in 0.9.4/0.13.4.
It gives the error Command on torrent creation failed: Junk at end of input. whenever the field custom1 (and any other field I guess) contains whitespace eg.:
rtorrent:
      uri: scgi://localhost:5000
      start: yes
      path: '/downloads/'
      custom1: '/staging/tv/{{ tvdb_series_name }}'

where tvdb_series_name is some tv show name containing whitespace.

@cvium i don't think magnets will work at this stage.. To be honest i know nothing about magnets but i think it's fairly easy to support..
can you create a ticket for your issue with the plugin and magnet support?
let me know the ticket urls

@cvium a quick test shows the same error on mine, i think i have to escape spaces.. will fix this and create another pull request.

@cvium I believe i've fixed the issue.. It's waiting to be merged from pull request https://github.com/Flexget/Flexget/pull/519

@stevezau I have created a ticket http://flexget.com/ticket/3014.

@cvium ok sure, I've never used magnets before so i'll have to have a look.. Fairly sure i can just copy how the other plugins do it.
Also i've created a page on the wiki with info on this plugin http://flexget.com/wiki/Plugins/rtorrent


Update name of CI cluster

This change makes CI run in the newly provisioned charts-testing-1 cluster while we investigate issues with service tokens that blocked the previous one from being able to run tests.

/lgtm


go get error

C:\devtools\java>go get -u github.com/ServiceComb/go-chassis
github.com/ServiceComb/go-chassis/core/lager
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:11:2: log redeclared as imported package name
previous declaration at C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:4:2
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:54:2: undefined: "github.com/ServiceComb/paas-lager".Println
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:75:2: undefined: stlager
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:82:12: undefined: stlager
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:97:3: undefined: "github.com/ServiceComb/paas-lager".Println
C:\cs2mw\workspace\go\src\github.com\ServiceComb\go-chassis\core\lager\lager.go:100:3: undefined: "github.com/ServiceComb/paas-lager".Printf

Sorry we didn't support go get
http://go-chassis.readthedocs.io/en/latest/getstarted/install.html

thx，it's ok according to docs above.


Support big-endian/vendor RISC-V target triplets.

Hi Guys,
Recently, we get the GNU binutils patches, which were implemented by Marcus Comstedt, to support the RISC-V big endian targets [1].  In these patches, we need to support new target names for big endian.  For example, riscv[32|64]be-unknown-elf.  And we also need to add a new file format, elf[32|64]-bigriscv, when using objdump -h.
Besides, I had heard that Jeremy Bennett from Embecosm also have a vendor specific toolchain proposal [2].  He would like to use the vendor field of the target triplet for the vendor specific tools, so we can use the vendor name instead of the unknown for the original riscv[32|64]-unknown-elf.  For example, riscv[32|64]-sifive-elf.
Therefore, there are four issues here,

Is the target riscv[32|64]be-unknown-elf for big endain good to you?
Should we need to add the riscv[32|64]le-unknown-elf for the original little endian toolchain?
How to deal with the original riscv[32|64]-unknown-elf, just keep them as little endian?
How about the riscv[32|64]-sifive-elf?

If the answers to the above four questions are all yes, then we will have the following target triples in the future,
riscv32-unknown-elf, riscv32le-unknown-elf, riscv32be-unknown-elf,
riscv32-vendor-elf, riscv32le-vendor-elf, riscv32be-vendor-elf,
riscv64-unknown-elf, riscv64le-unknown-elf, riscv64be-unknown-elf,
riscv64-vendor-elf, riscv64le-vendor-elf, riscv64be-vendor-elf,...
However, I can not find any spec that had mentioned the target triplets, so we probably need to add them somewhere in the future.
Thanks
Nelson
[1]  https://sourceware.org/pipermail/binutils/2020-December/114632.html
[2]  https://docs.google.com/document/d/1CgjH2xyC7jmJh-lNAyozbv_OSeK0mBH5D3oJrgGdI7Y/edit

I don't think that we need riscv32le- tuples, and should just assume that riscv32 is always little endian.
Note that riscv- is allowed, but not recommended and not supported.
Presumably the -vendor- is a variable where vendor can be any organization name.  I don't think it should be necessary for companies to request permission to use it.  Or that we need to track the names being used in the psABI.
The binutils deadline for the next release is roughly Jan 8, so we need a decision soon if this will be included in the next binutils release, which in turn is necessary if we want this in the next gcc release.  Otherwise, the gcc support will have to wait a year.
I don't know if there is LLVM big-endian support or patches.
There is one itneresting issue with relocations here.  Big-endian RISC-V has little-endian code.  So data relocations will be big or little endian depending on the object file format, but code relocations will always be little endian.  So this is effectively a change to how relocations are defined, and we may need to start making a distinction between which relocs are data relocs and which ones are code relocs.  Currently there is no overlap.  But Huawei has proposed a 48-bit l.li instruction that has 16 bits of opcode and a 32-bit immediate.  It would make sense to use R_RISCV_32 for the immediate, but that won't work for a big-endian target.  So we would need a new reloc which is like R_RISCV_32 but is always little-endian for use in code.
Otherwise, I don't see any issues with adding big-endian support.

As far as I know, there's no Big-Endian LLVM support, or pending patches.
I also don't feel the need to track the list of vendors. The clang driver will parse unhandled vendors into -unknown- anyway, iirc. This is simpler in the driver, but if you use a custom vendor to enable specific incompatible functionality, you will run into problems as mainline clang won't know about that.
I do think that riscv32- and riscv64- should default to little-endian, and riscv32be- and riscv64be- should denote big endian.
Separating code and data relocations makes sense to me if it's needed for big-endian platforms.

As far as I know, there's no Big-Endian LLVM support, or pending patches.
I also don't feel the need to track the list of vendors. The clang driver will parse unhandled vendors into -unknown- anyway, iirc. This is simpler in the driver, but if you use a custom vendor to enable specific incompatible functionality, you will run into problems as mainline clang won't know about that.
I do think that riscv32- and riscv64- should default to little-endian, and riscv32be- and riscv64be- should denote big endian.
Separating code and data relocations makes sense to me if it's needed for big-endian platforms.

I would prefer decoupling vendor filed in target triple and vendor specific extension, extension should always control by -march string otherwise we would result bunch of option and hard to track version.

I would prefer decoupling vendor filed in target triple and vendor specific extension, extension should always control by -march string otherwise we would result bunch of option and hard to track version.

@kito-cheng Yeah, I'm just saying where someone might run into issues if they do decide to do vendor-specific behaviour.

@kito-cheng Yeah, I'm just saying where someone might run into issues if they do decide to do vendor-specific behaviour.

@lenary Oh, sorry for confusion, my reply is not kind of debating or against your comment, just your reply remind me I should have to post my opinion here, I only take that privately with Nelson :P

@lenary Oh, sorry for confusion, my reply is not kind of debating or against your comment, just your reply remind me I should have to post my opinion here, I only take that privately with Nelson :P

Let's fiercely agree with each other :)

Let's fiercely agree with each other :)

Kito send a patch to config-patches for the riscv*be tuples and it was accepted and merged yesterday.  So it is now in upstream config.sub and config.guess which are used by the GNU toolchain.

Kito send a patch to config-patches for the riscv*be tuples and it was accepted and merged yesterday.  So it is now in upstream config.sub and config.guess which are used by the GNU toolchain.

I guess we should document triple name issue on https://github.com/riscv/riscv-toolchain-conventions rather than here, so I gonna close this issue.
And created an issue for relocation behavior for big-endian.
https://github.com/riscv/riscv-elf-psabi-doc/issues/176