Extract examples from other books.

Description of changes:
This PR adds support for extracting examples from 3 book in addition to The Rust Reference: The Rustonomicon, The Unstable Rust, and Rust by Example. With this PR, the number of examples we run jumps to 700 with 98 failing.
Resolved issues:
Resolves #385
Call-outs:

Several example configurations pass --cbmc-args --unwind 0 to RMC (see #419).
Testing:

How is this change tested?

The dashboard program now extracts, runs, and displays the results of examples from the 3 books.

Is this a refactor change?

To some degree. Several files were moved/renamed to account for the additional books.

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Vague idea: If the timeout bug were fixed, could we (instead of having fragile props files) just have a sequence of possible flags to try? (e.g. try default, then try unwind 5, etc...)
Basically, trading away a little runtime for something that'd hopefully be more maintainable in the future. Just a thought.

That's a good idea. Most examples pass with an unwind value less than 5. So, it will help us reduce the number of props files. Though, we will still need them for outliers. I will run your idea by Adrian next week.


The robot goes in the opposite direction of the target

I am using the below message to send the goal to the robot. The robot can travel to the correct latitude position but opposite longitude position. For example, the goal is at the top left of the robot. The robot will travel to the top right. If the goal is at the top right of the robot. Then the robot will travel to the top left. Any possible solutions? Thank you!
{
"op": "publish",
"topic": "/gps_goal_fix",
"msg": {
"status": {
"status": 2,
"service": 0
},
"altitude": -0.03936214196751092,
"longitude": 8.9002013431619637,
"position_covariance": [741985448272.8313, -1628874706.209279, -437539014936.25494, -1628874706.2092788, 3575855.5841113734, 960525891.8060722, -437539014936.25494, 960525891.8060722,<PHONE_NUMBER>71.58453],
"header": {
"stamp": {
"secs": 681,
"nsecs": 683000000
},
"frame_id": "wheel_base_link",
"seq": 6813
},
"latitude": 49.90000046264395,
"position_covariance_type": 3
}
}

I have the exact same issue.


There is no way to add a shutdown hook

This issue was originally filed by<EMAIL_ADDRESS>
Java got addShutdownHook, Ruby got at_exit, Python got an atexit module, and Node got process.on('SIGTERM', ...).
Dart doesn't seem to offer anything comparable.
Relevant SO thread:
http://stackoverflow.com/questions/11001071/shutdown-hook-in-dart

This could be solved by an exit-callback for the current isolate: #21999

We now have addOnExitListener
https://api.dartlang.org/stable/2.0.0/dart-isolate/Isolate/addOnExitListener.html


gr.Video() cannot work on studios

If using filepath, the studio can go online without error, but the video cannot display, like below:

If using url, the studio cannot go online by runtime error (ssl error, even if I upload video onto modelscope hostname, it still reports www.modelscope.com did not pass the ssl security check 🤣)
Thanks for your error report and we appreciate it a lot.
Checklist

I have searched the tutorial on modelscope  doc-site
I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Your Environments (required)

OS: uname -a
CPU: lscpu
Commit id (e.g. a3ffc7d8)
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Please @ corresponding people according to your problem:
Model related:  @tastelikefeet
Model hub related: @liuyhwangyh @tastelikefeet @wangxingjun778
Dataset releated: @wangxingjun778
Finetune related: @tastelikefeet  @Jintao-Huang
Pipeline related: @tastelikefeet @wangxingjun778
Contribute your model: @yingdachen

We will resolve the SSL error next week. In the meantime, you might try using the image of version ModelScope 1.17.1, which typically does not encounter SSL errors.
The 'video cannot display' issue is related to the sensitive content check, which may take anywhere from a few seconds to several minutes, particularly for longer videos.

We will resolve the SSL error next week. In the meantime, you might try using the image of version ModelScope 1.17.1, which typically does not encounter SSL errors.
The 'video cannot display' issue is related to the sensitive content check, which may take anywhere from a few seconds to several minutes, particularly for longer videos.

No SSL error does not mean the gr.Video can work well:


Support ALB Authentication with OIDC

Is your proposal related to a problem?
I'm deploying Kafka UI on AWS ECS Fargate and exposing it via ALB. AWS ALBs have a way of performing authentication using AWS Cognito or 3rd party OpenID Connect. This way the access tokens are never sent to user browser, and only exchanged between the ALB and the Application. ALB uses a bunch of X-AMZN-OIDC-* headers to pass authentication information to the application, that the application would have to understand.
Describe the solution you'd like
We'd like to be able to configure SSO with Active AD on ALB level, and then have Kafka UI make sense of the tokens ALB sends.
Describe alternatives you've considered
For now we have two options:

Enable the ALB Authentication and leave Kafka UI unauthenticated - whoever passes the ALB, can access all functionality in Kafka UI. This would work for now, until Kafka UI provides more fine-grained RBAC.
Pass-through on ALB, and use SSO integration with Azure AD directly on Kafka UI.

Additional context

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/listener-authenticate-users.html
https://github.com/raiffeisenbankinternational/aws-albheaders-authentication - I think this may come handy to implement Spring Boot configuration for it.

Hey, thanks for reaching out.
We'll consider implementing ALB headers support after we're with #753.
SSO guide, if you haven't seen one yet.
Stay tuned!

Hey @mkielar, just wanted to share what worked for me. if you only care about authentication without RBAC, you can implement this directly on ALB + OIDC listener and limit on your IDP which groups or users would have access without kafka-ui being aware of it.

@wanisfahmyDE I know it would, I'm currently using the solution as you described and it works great :).
What I'm hoping from this ticket, however, is to be able for Kafka UI to make sense of the X-AMZN-OIDC-* headers that ALB passes upstream and implement actual RBAC based on this. Currently I can either grant or deny access to Kafka UI by adding/removing people to AD Groups. What I'd like to do is have several groups in my AD, and depending on the group give people access to read / write data in the topics or even modify / delete topics, etc. Full RBAC.

@Haarolean, I've seen https://github.com/provectus/kafka-ui/issues/753 is done for some time now. Are there any plans for this one to get get some traction?

@mkielar thanks for the reminder, I'll add this to the RBAC board.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2022-11-09T18:34:51+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio_release-1.16
ac7b75365773b51d5cde06c855335e365d87d073
link
unknown
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck


Download old files failed

I'm trying to download an audio file of July 2017 from a channel but I got this error:
400 File download has failed or was cancelled

when i called getFile size and expectedSize is 0
I worked with TdLib v1.7.0 and I checked with official client and this file exists and downloaded correctly

You seems to use inputFileRemote. This is a description of the class:
A file defined by its remote ID. The remote ID is guaranteed to be usable only if the corresponding file is still accessible to the user and known to TDLib. For example, if the file is from a message, then the message must be not deleted and accessible to the user. If the file database is disabled, then the corresponding object with the file must be preloaded by the application

You seems to use inputFileRemote. This is a description of the class:
A file defined by its remote ID. The remote ID is guaranteed to be usable only if the corresponding file is still accessible to the user and known to TDLib. For example, if the file is from a message, then the message must be not deleted and accessible to the user. If the file database is disabled, then the corresponding object with the file must be preloaded by the application

@levlam oh! thank you

@levlam oh! thank you


Add patch to fix touchpad lagging issue

This patch is for fix the Window Precision Touchpad lagging issue.  Port from https://chromium-review.googlesource.com/c/chromium/src/+/867070. Chromium will fix at M66.
https://github.com/electron/electron/issues/8960

Hi guys, PTAL. I also want to know it is possible to port the patch to <IP_ADDRESS> (which vscode is using) in this repo. Thank you.

@chaopeng For 1.7.x you can create a pull request against the electron-1-7-x branch. /cc @ckerr

Hi @zcbenz, may I know which other branches electron current working on? so I can add the fix.

@chaopeng The only other branch needs the update is electron-1-8-x, thanks for backporting the patch.

Backport to electron-2-0-x: #472


Fixed a broken feed lexicon link

I noticed the link to documentation for feed.getFeedSkeleton has changed.

I too think you should fix that link, but it looks like the same fix as #78.

Forgot to check existing PRS, eg #78


Sunstone: No way for update VM configuration if it have restricted vector atributes.

Bug Report
Version of OpenNebula

[ ] 5.2.2
[ ] 5.4.0
[ ] 5.4.1
[ ] 5.4.2
[ ] 5.4.3
[ ] 5.4.4
[ ] 5.4.5
[X] 5.4.6
[ ] 5.4.7
[ ] Development build

Component

[ ] Authorization (LDAP, x509 certs...)
[ ] Command Line Interface (CLI)
[ ] Contextualization
[ ] Documentation
[ ] Federation and HA
[ ] Host, Clusters and Monitorization
[ ] KVM
[ ] Networking
[ ] Orchestration (OpenNebula Flow)
[ ] Packages
[ ] Scheduler
[ ] Storage & Images
[X] Sunstone
[ ] Upgrades
[ ] User, Groups, VDCs and ACL
[ ] vCenter

Description
If you have VM_RESTRICTED_ATTR with some variables inside vector attributes it can refuse you for changing another allowed parameters.
How to reproduce
Let's say you want to refuse users for change graphic console options, but allow changes on input methods.

Define in oned.conf:

VM_RESTRICTED_ATTR = "GRAPHICS/LISTEN"
VM_RESTRICTED_ATTR = "GRAPHICS/PASSWD"
VM_RESTRICTED_ATTR = "GRAPHICS/PORT"
VM_RESTRICTED_ATTR = "GRAPHICS/TYPE"

Restart opennebula service
Create new VM from template with enabled graphic console
Open sunstone and go to the any VM as user
On "Conf" tab click "Update configuration button"
Go to the "Input/Output" tab
Try to add tablet pointer device

Actual Behavior
You will see this error:
[one.vm.updateconf] User [356] : Template includes a restricted attribute LISTEN.

Expected Behavior
Sunstone should allow for change INPUT parameters because they are allowed.
Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Same problem with RAW parameter if VM have seted RAW parameter which restricted by VM_RESTRICTED_ATTR in oned.conf
You will recive error even you try to update any other parameter.

Same in CLI
updateconf sends all the conf attributes and the core interprets that everything has changed


Orhanoguz

Yes
El vie, 21 de jun de 2024, 7:51 p. m., Orhanoguz3567 <
@.***> escribió:

—
Reply to this email directly, view it on GitHub
https://github.com/FrederikBolding/chainlist/issues/180, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHWYOEFZMDR4MQRS4AJ3R4TZITRCJAVCNFSM6AAAAABJXBHLZOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3DONBYGEZDONI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[windows] Add docker binaries to system/user PATH

I would like to be able to use the docker CLI from my existing console windows (e.g. ConEmu + msys2) but the path to the docker binaries is not added to the system or user PATH.

+1

Thanks for the issue!


feat(EU): New KIA models

Not everything is implemented, yet. Only the most important attributes from the vehicle status request are integrated.

I can't figure out how to post the review from mobile app.
Only thought is maybe renaming the ccs variable in vehicle to support multiple regions? I doubt other regions will call it that but still have versions.   Thoughts on making it more universal?

Only thought is maybe renaming the ccs variable in vehicle to support multiple regions? I doubt other regions will call it that but still have versions. Thoughts on making it more universal?

I think we can still refactor it, if it is the case. For me it looks a bit like a universal attribute but I might be wrong.

Each region is totally different. Ev9s haven't had issues so far for other regions as an example.

I did see in older logs that the attribut Ccuccs2protocolsupport is set to 0 and in my sniffed code it is set to 1. So my interpretation was, that ccs2 was disabled in the past and now - in some newer cars - it is enabled. I think other region might also have to switch sooner or later to the ccs2 protocol. Interestingly, this attribut is also used in the header of other type of calls (vehicles, register, ...).
But it is only an interpretation which might be completely wrong. The attribut could also mean Combined Charging System (CCS) but then why would it be included in all calls?

Interesting. So far I haven't seen this value in any other regions.  I have seen a version flag though.   Not sure why each region is so different.  Stamps also don't exist in ca and USA. They do exist in Australia though.

Austria is following EU style, right? Similar to IN and CN.

Yes.

I head to add the attribute Ccuccs2protocolsupport to the header. The value is taken from the result of the vehicle call. It would be good if somebody could test it for the old cars in EU.

I have a 2024 Kona and just tried this PR using a small test script, I do see a lot more data now being returned, including a lot of driving statistics, great work!

I have a 2024 Kona and just tried this PR using a small test script, I do see a lot more data now being returned, including a lot of driving statistics, great work!

Thanks! I mapped some additional attributes and documented the still missing ones.

I tried to map some more values. Now it shows 43 entitys for EV9.

All are integrated now. Thanks for your help.

I tried to map some more values. Now it shows 43 entitys for EV9.

All are integrated now. Thanks for your help.

Some fixes for previous mapping. I also mapped is_locked to driver door lock. Would be nice to get sniffing of the open lock and setting of the limits.
0001-Fix-value-states-for-added-attributes.patch

I added the proposed changes and also changed the is_locked. All door are checked and only if all four are closed then I set the attribute to True.

I added the proposed changes and also changed the is_locked. All door are checked and only if all four are closed then I set the attribute to True.

Btw there is Lock status that is inverse its different from open. Property is Cabin.Door.Row1.Driver.Lock its 1 when its open and 0 when its locked.

Thank you for this! I am going to merge and release this.  Another PR can be done for the other work that is on the go. This will help test the current progress out in a wider audience.

With the pre release 2.19.0 I do see much more data, but KONA AC Charging Limit and KONA DC Charging Limit but show a slider with 80, but in the app I see 100, also the UI is strange

I don't have FrontLeftWindow and FrontRightWindow in HA, only the door, for the back I do see the door and window status

See https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/pull/483 for the window status


Improve build UX for official release tarball - don't ask users to supply url/sha

When I download a release tarball for .NET 8 from the VMR (dotnet/dotnet) repository, I would like to be able to build it without providing additional information.
This came up in https://github.com/dotnet/source-build/issues/3265:

Modified build.sh to take in a url and sha for the source to use by sourcelink. If not provided require the build is executing in a git context and read the values from it.

An official release tarball doesn't have a git context. It is produced from the ofificial VMR repo and has the same SHA as a the official tag/release. For this tarball, there is only one correct set of values for URL/SHA. Any other value (URL or SHA) will (silently?) produce wrong results for anyone building .NET.
It would be great if everyone consuming the tarball didn't have to figure out what the URL and SHA need to be.

@mmitche, @mthalman, @premun, @tkapin - @omajid  provided this reference link as a reference for how other projects handle specifying revision info - https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control

In case it wasn't clear, https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control (in particular, the Multiple Sources Example) is about how Fedora suggests to the Fedora packagers how to package projects where projects are pulled down from GitHub (or another forge, like GitLab). Both commits and tags can be used to specify what to pull down. Multiple source artifacts (eg, source tarball and auxillary metadata file) are supported, but it's a little bit more painful to consume.

Proposal

When building from a context of a git repo, its remote + current revision is used (so the same as it is now). No override is possible unfortunately (we cannot override this for sourcelink yet).
When building outside of a context of a git repo, information must be provided to build.sh.

Remote URI (via --source-repository) and SHA of a commit in that remote (--source-version)
Alternatively, a git tag could be provided via --source-tag (e.g. v8.0.100-preview.3.23178.7)
Alternatively, a metadata file could be provided via --source-metadata), see below

Release metadata file
Every release on the https://github.com/dotnet/dotnet repo will then (apart from the default tarball) contain a new metadata file named release.json. The contents of the file might grow over time with more useful information but the bare minimum it would contain now would be these fields:
{
    "sourceRepository": "https://github.com/dotnet/dotnet",
    "sourceVersion": "6d6f38c2d65c50dfc31dcdadfef1ba24ed4efc45"
}

Other possible fields might contain the release name, channel, version, prerelease flag etc.
Release description
The release on the https://github.com/dotnet/dotnet repo itself could have a body populated with instructions on building the repo. I imagine something simple like this:
curl -Lo dotnet-sdk-source-v8.0.100-preview.3.23178.7.tar.gz https://github.com/dotnet/dotnet/archive/refs/tags/v8.0.100-preview.3.23178.7.tar.gz
tar zxf dotnet-sdk-source-v8.0.100-preview.3.23178.7.tar.gz && rm -f dotnet-sdk-source-v8.0.100-preview.3.23178.7.tar.gz
(cd dotnet-8.0.100-preview.3.23178.7 && ./build.sh --source-tag v8.0.100-preview.3.23178.7)

We could also have another set of instructions for downloading both the tarball and the metadata file separately and running build.sh --source-metadata release.json.
Alternatives for build.sh
When the metadata file is provided to the build.sh script, it will use the remote & SHA from there.
When a git tag is provided, it will pull the metadata file from a release associated with the tag (e.g. https://github.com/dotnet/dotnet/releases/tag/v8.0.100-preview.3.23178.7/release.json).
Questions

Format of the file - MSBuild .props or .json? Or both?
I guess when we arrive at a point when can pass these properties to sourcelink (if ever), MSBuild might be okay. On the other hand, we're putting a JSON in the release announcement already so that's something our partners use?
How would this file be parsed? I understand we can only expect bash (no MSBuild, no jq..). I see cases where we grep .props files already for instance.
Would we document this file somewhere? In the main README? Or is there a suitable source-build .md?

cc @MichaelSimons @mthalman @omajid @tkapin @mmitche

Sorry about the dely in replying:

@omajid would it be useful for usability if the GitHub release itself would have a markdown body with copyable instructions including the SHA and the URI?

I am not currently using the data in the release. My current approach (which, to be fair, is changing as the release tarball feature changes) is just looking for the for a specific release at a sepcific computed location.

E.g. you either download both the tar.gz or the release metadata file (this would work programmatically), or you could navigate to the release page and copy out the full build command which would have the URI and the SHA.

If we need the release metadata, having it at a well known location for every release (eg, something like https://github.com/dotnet/dotnet/releases/download/${sdk_or_runtime_version}/metadata) would be easiest for me.

From the discussion, I didn't quite understand whether the flow you're doing and that requires you to input these values is a manual dev one or an official pull of the release for package repository purposes.

For my .NET packages for Fedora, I use a script called update-release.  That eventually downloads (and preps, if needed) the source tarball. I would like to extend this to include the metadata file, so if the file is at a well-known path, my script should be able to handle too.
(The Fedora update-to-new-.NET-release is a manual process that a dev runs, and then pushes the result to Fedora's package-build-scripts repository)

Secondly, were you using the pack-sources.sh script before for your manual dev workflow and we've removed it from you?

I wasn't using it really. I used it for a single preview release for .NET 8 (when it was the recommended way to generate the tarball) and have now stopped using it completely.
Your proposal sounds good to me.
One caveat though:

When a git tag is provided, it will pull the metadata file from a release associated with the tag (e.g. https://github.com/dotnet/dotnet/releases/tag/v8.0.100-preview.3.23178.7/release.json).

Our builds are offline, so build.sh won't be able to talk to github.com. So I suppose that means we have to use the metadata file directly, which should be okay.

How would this file be parsed? I understand we can only expect bash (no MSBuild, no jq..). I see cases where we grep .props files already for instance.

When we are building the SDK, we know we have another .NET SDK available. Could we write a .NET script to parse the file and run it using that already-existing SDK?

One caveat though
Our builds are offline, so build.sh won't be able to talk to github.com. So I suppose that means we have to use the metadata file directly, which should be okay.

Yeah, I see this is a suitable alternative for someone with different restrictions. But I am also open to not having it..

We'd need to get the SHA in there somehow (e.g. in some file) and read that, but we don't know the SHA until after we make the actual commit.

Sourcelink needs a SHA to get the source files. This SHA doesn't need to be the SHA of the tag exactly. So when you tag a release, you can first make a commit that adds the SHA for sourcelink in a file, and then tag that commit. That should work.

Sourcelink needs a SHA to get the source files. This SHA doesn't need to be the SHA of the tag exactly. So when you tag a release, you can first make a commit that adds the SHA for sourcelink in a file, and then tag that commit. That should work.

Yeah, that occurred to me but I don't think we want that really. The whole point of the VMR is to have a single commit that identifies everything that's needed for the whole SDK. Doesn't seem right to get a second commit involved? Additionally, it's quite nice for us to have commits of the VMR associated 1:1 with installer it synced from.
I think we also want to make sure people can set whatever information - e.g. they make their own custom build of .NET somewhere in private with some very minimal internal changes but then you'd want to be able to point this to the public dotnet/dotnet repo for anyone using this .NET in public.

I think it would be nice if the tarball would just work, which is why I wanted to mention it as an option.

Additionally, it's quite nice for us to have commits of the VMR associated 1:1 with installer it synced from.

I don't know what this means.

I think we also want to make sure people can set whatever information

We're not precluding that.

I think it would be nice if the tarball would just work, which is why I wanted to mention it as an option.

Thanks, it's appreciated!
 I am just not sure whether we'd want to always add an extra commit to each we make in the VMR.

to always add an extra commit to each we make in the VMR.

to each release tag.

to always add an extra commit to each we make in the VMR.

for each release tag.

It is not ideal IMO that the sourcelink info would be off on all commits besides the release commit.  Even if you make an extra commit for each commit, you'd have to build off of the sha update commits in order for the sourcelink info to be correct.

It is not ideal IMO that the sourcelink info would be off on all commits besides the release commit. Even if you make an extra commit for each commit, you'd have to build off of the sha update commits in order for the sourcelink info to be correct.

That's not what I meant.
I meant for the sourcelink info to only be present on the release commits.

That's not what I meant.
I meant for the sourcelink info to only be present on the release (that is: tagged) commits.

I see, so to build any non-tagged commits, you would have to specify the sourcelink parameters otherwise the info would exist and would be detected when no sourcelink parameters are specified.

Yes, the non-tagged commits wouldn't have a sourcelink info file.
If they have a .git folder, they can can still get the info from it.

@tmds we have discussed this at length and finalized on following:

We won't go the way of adding additional commits. We don't like several things about it:

Some commits will behave differently then others - some will have the metadata and some not, which might cause confusion. Some commits will still require additional info.
The VMR commit won't be self contained anymore as the second one will be referenced via source link.
The commit on the release tag will differ from the one we release through the Microsoft build.
It seems like we could easily make a mistake when branching or when adding hotfixes and MSRC fixes that would end up targeting a wrong commit if the information in the branch wouldn't get updated. This seems like a maintenance burden on the process.

We have decided that the current approach of appending a metadata file on the release, or the alternative of having to have to provide the metadata is not a big burden because it only applies on non-git flows which are usually done by distro maintainers who already usually have the URL/SHA at hand and it seems it's not a big deal to require them to supply this.

Does this make sense or are there some points we missed where this new flow is problematic and not acceptable?

@premun I wanted to raise it as an option as I think it was assumed to be not possible prematurely.
When you've considered the different alternatives, and you concluded another option is preferable, that is fine with me.

Gotcha, thanks!


Skeleton.template

Change filename setup.cfg in line#6 to setup.py
pyscaffold/src/pyscaffold/templates/skeleton.template

Hi @atarla, thanks a lot for reporting this. I fixed it.


Ruby version

Hello, you do not use the most recent ruby version. Do you plan on upgrading Malstrom ?

@Lodags good question. Currently the Ruby version utilized is 2.1.4. It is on my short list of things to fix to get up to the latest version though.

Thank you for your answer ! I am currently testing threat intelligence softwares, and it seems that a lot are not up-to-date :'(

This has been addressed. Malstrom now operates at version 2.4.2


introduce a metrics.toml configuration file

We probably want to support a ~/.metrics.toml file to load configuration for the user.
Builds on: #2

currently claimed by @Llandy3d via Zulip
just tossing this here in case anyone missed that message :smile:


gets stuck in state idle

Im trying to cast a youtube video and the state gets stuck in idle. The youtube app does load on the chromecast though, the video just doesnt seem to play no matter how long I let it idle.

https://github.com/xat/castnow/issues/126

And also #108


Avoid NullPointerException when customChange has no "class" attribute

Environment
Liquibase Version: all
Liquibase Integration & Version: all
Liquibase Extension(s) & Version: all
Database Vendor & Version: all
Operating System Type & Version: all
Pull Request Type

[x] Bug fix (non-breaking change which fixes an issue.)
[ ] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
If a customChange node is missing the "class" attribute (either by typo, or mis-indentation) a NullPointerException is thrown:
Caused by: java.lang.NullPointerException
    at java.lang.Class.forName0(Native Method) ~[?:?]
    at java.lang.Class.forName(Class.java:398) ~[?:?]
    at liquibase.change.custom.CustomChangeWrapper.customLoadLogic(CustomChangeWrapper.java:335) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.change.AbstractChange.load(AbstractChange.java:719) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.change.custom.CustomChangeWrapper.load(CustomChangeWrapper.java:312) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.ChangeSet.toChange(ChangeSet.java:480) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.ChangeSet.handleChildNode(ChangeSet.java:413) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.ChangeSet.handleChildNode(ChangeSet.java:409) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.ChangeSet.load(ChangeSet.java:337) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.DatabaseChangeLog.createChangeSet(DatabaseChangeLog.java:606) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.DatabaseChangeLog.handleChildNode(DatabaseChangeLog.java:336) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.changelog.DatabaseChangeLog.load(DatabaseChangeLog.java:305) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]
    at liquibase.parser.core.yaml.YamlChangeLogParser.parse(YamlChangeLogParser.java:77) ~[usafe-cli-1.0.1-SNAPSHOT-all.jar:?]

Steps To Reproduce
Create a customChange node with no class attribute, and you will see this exception.
Actual Behavior
Check description.
Expected/Desired Behavior
A nicer exception should appear with a better error message.
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Added Test Harness Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

Dev Handoff Notes (Internal Use)
Links

Fixed Issue: Stand alone PR
Test Results: https://github.com/liquibase/liquibase/pull/1648/checks

Testing

Steps to Reproduce: See above (use yaml format)
Guidance:

Impact: Just adds a check for a missing argument

Dev Verification
Code review and ensured new automated test is good
Manual Tests
Verify update shows correct error message when class attribute is not specified.

create a changelog with customChange changeset, but do not specify class attribute

liquibase --log-level INFO update --changelog-file changelog.yaml

Custom change node has no 'class' attribute! error message is shown

Verify update is successful when class attribute is specified.

specify 'class' attribute in your changelog

liquibase update --changelog-file changelog.yaml

update is successful

┆Issue is synchronized with this Jira Bug by Unito

Thanks @danielthegray for fixing this issue.  Always appreciated when our core team helps fix issues.

Thanks @danielthegray for fixing this issue.  Always appreciated when our core team helps fix issues.

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.10.x@46fc9ce). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 32c3961 differs from pull request most recent head c95798b. Consider uploading reports for the commit c95798b to get more accurate results

@@            Coverage Diff            @@
##             3.10.x    #1648   +/-   ##
=========================================
  Coverage          ?   48.66%
  Complexity        ?     7478
=========================================
  Files             ?      727
  Lines             ?    35662
  Branches          ?     6568
=========================================
  Hits              ?    17356
  Misses            ?    15917
  Partials          ?     2389

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fc9ce...c95798b. Read the comment docs.

Liquibase version [Core: //improve-missing-class-name-custom-change-error/1452/fc0771/2022-02-09 21:38+0000, Pro: master/591/f653ec/2022-02-09T18:09:13Z] #1452
Verify update shows correct error message when class attribute is not specified. PASS
Unexpected error running Liquibase: Error parsing changelog.yaml

liquibase.exception.CommandExecutionException: liquibase.exception.LiquibaseException: Unexpected error running Liquibase: Custom change node has no 'class' attribute!

Verify update is successful when class attribute is specified. PASS


Setup web share API

Closes #18

@DesignrKnight
All looking good except for one thing. For the badges which don't have a description, alter the share text so that, users dont see at undefined  when they try to share those badges.

All badges now have a Description, merging the PR now :rocket:


Search results, categories empty, apps present on beta.flathub.org missing from main site

Hello all,
I don't know how it's possible that I'm the first one to notice it, but here goes!
I originally went looking for the Flathub page for com.simplenote.Simplenote, and when it said "App Not Found" but found it in the Wayback Machine's recent capture history I thought "Impossible!" and started digging.
I'm aware of #319 (now). However, as an end-user, the "Status" link in the footer was the first place I checked to see if Flathub was "OK," and an SSL error there was not encouraging.
A random selection of links from the flathub.org main page that presently don't work, or don't return any results:

https://flathub.org/apps/category/Development
https://flathub.org/apps/search/simplenote
https://flathub.org/apps/details/org.gnome.SoundRecorder
https://flathub.org/apps/details/de.haeckerfelix.Shortwave (although still present in the googlecache and on beta.flatpak.org)

With a quick spot-check, I confirmed that the three apps listed above are all accessible from beta.flathub.org, so I assume this problem is related only to the main web site. That also means that if anyone comes here looking for a solution, you have a workaround: add beta. to the URL after the https:// and you will see the details page for your chosen app.
Thought you'd like to know. Thanks for doing what you do!

Ah, disregard. :man_facepalming:
It was literally fixed while I was creating the issue.
Cheers, everyone!


No app.js in the build directory

I built the react-redux example by running npm run build -- --app react-redux, then started the server as the instructions state by running http-server -s -p 9000. I then proceeded to open localhost:9000 in my browser where I was greeted with this error in the developer tools console: Failed to load resource: the server responded with a status of 404 (Not Found) ... http://localhost:9000/build/app.js. My guess is that the build tool created a file called router5-react-redux-example.js which should have actually been called app.js. Could you fix this?

Fixed it. Use npm start (npm start -- --app <app-name>) and navigate to http://localhost:8080.


🍱 Adds KPN

Source: https://static.kpn.com/ssi/svg/kpn-logo.svg

Is there a cropped version with only the icon available for this? Thanks in advance!


Optimistic locking occasionally conflicts with auto-save on structured questions

When users are answering structured questions, the autosave sometimes occurs at the same time they hit the save button manually. This is more likely that in text editing. It can give a confusing message, see below:

How should we resolve it? Remove autosave from radio/checkboxes or write in logic to ignore if user is the same?

This is linked to #2520 Address the two together

Closing as duplicate of #2520


Installation problem on a windows machine

Hi,
I have a windows machine with Python 3.6.5, I tried the command: pip install scikit-hubness
and I got this message:
Collecting scikit-hubness
Could not find a version that satisfies the requirement scikit-hubness (from versions: )
No matching distribution found for scikit-hubness
Any suggestions?
Thanks,
Ivan

I decided to try a manual installation. So, I downloaded the package and run command: python setup.py install
It seems that the process went well. But, I got these warning messages which I don't know if they compromised the installation:
File "build\bdist.win-amd64\egg\skhubness\reduction\dis_sim.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
byte-compiling build\bdist.win-amd64\egg\skhubness\reduction\local_scaling.py to local_scaling.cpython-36.pyc
File "build\bdist.win-amd64\egg\skhubness\reduction\local_scaling.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
byte-compiling build\bdist.win-amd64\egg\skhubness\reduction\mutual_proximity.py to mutual_proximity.cpython-36.pyc
File "build\bdist.win-amd64\egg\skhubness\reduction\mutual_proximity.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
byte-compiling build\bdist.win-amd64\egg\skhubness\reduction\shared_neighbors.py to shared_neighbors.cpython-36.pyc
File "build\bdist.win-amd64\egg\skhubness\reduction\shared_neighbors.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
Extracting scikit_hubness-0.21.3-py3.6.egg to c:\temp\python\python3.6.5\lib\site-packages
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\analysis\estimation.py", line 15
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\neighbors\hnsw.py", line 5
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\neighbors\lof.py", line 7
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\neighbors\lsh.py", line 5
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\neighbors\nng.py", line 5
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\neighbors\random_projection_trees.py", line 6
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\reduction\dis_sim.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\reduction\local_scaling.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\reduction\mutual_proximity.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined
File "c:\temp\python\python3.6.5\lib\site-packages\scikit_hubness-0.21.3-py3.6.egg\skhubness\reduction\shared_neighbors.py", line 4
from future import annotations
SyntaxError: future feature annotations is not defined

scikit-hubness requires Python>=3.7, which introduced from __future__ import annotation.
Is creating a virtual environment or conda environment with python3.7 an option for you?

Thanks for the information. I will keep this in mind. Unfortunately, it won't possible for me to develop code on Python 3.7 as we are still using Python 3.6.5

It shouldn't be too hard to make a 3.6 compatible fork though. Just delete all the imports highlighted in your error message above, and remove the annotations that point to the class itself, e.g. def fit(self, X, y=None) -> HNSW would become def fit(self, X, y=None): and so on.
This does not change functionality, but only loses convenient typing hints in IDEs.

Many thanks for sharing these tips. I will give it a try and let you know

I gave a try. I made a change in the setup.py, so the installation makes use of scikit-learn 0.24.2. The compilation seemed to work well. However, when I tried this command:
from skhubness.data import load_dexter
gave the following error message:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness_init_.py", line 8, in
from . import analysis
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness\analysis_init_.py", line 7, in
from .estimation import Hubness, VALID_HUBNESS_MEASURES
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness\analysis\estimation.py", line 26, in
from skhubness.neighbors import NearestNeighbors
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness\neighbors_init_.py", line 8, in
from .ball_tree import BallTree
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness\neighbors\ball_tree.py", line 3, in
from sklearn.neighbors.ball_tree import
ModuleNotFoundError: No module named 'sklearn.neighbors.ball_tree'
To correct this issue, I did the following:

uninstall hubness package
edit ball_tree.py file and replace "from sklearn.neighbors.ball_tree" by "from sklearn.neighbors._ball_tree"
re-install hubness package
edit base.py file to replace "from sklearn.neighbors.base" by "from sklearn.neighbors._base" & "from sklearn.neighbors.ball_tree" by "from sklearn.neighbors._ball_tree"

Now, I am getting this error message -  I reported this error to scikit-learn package:
File "C:\Users\IMarroquin\Downloads\Important_Python_Libraries_VisualBuildTools\scikit-hubness-master\skhubness\neighbors\base.py", line 29, in
from sklearn.neighbors._base import UnsupervisedMixin, SupervisedFloatMixin

Unfortunately, you cannot easily upgrade scikit-learn, as scikit-hubness is currently tightly bound to some of its internals. For new scikit-learn version, we essentially need to rewrite our tool from scratch (see the paper for some more details on that).


Customize monitoringURL prefix for Stackdriver metrics

Adding capability to customise metric prefix in stackdriver surfacer.
See discussion - https://github.com/cloudprober/cloudprober/issues/261

@manugarg Please review the PR for issue 261

Thanks for the contribution, @kushal288!


Update linters

Update ruff to v0.1.1
add new pre-commit-hooks hooks, purpose self-explanatory from the names
add badges to README

@juraskov you are the expert now, please review. :pray:


zdns does not build on darwin

Currently zdns does not build on darwin (go1.17.6):
$: git reset --hard HEAD
HEAD is now at 7430d80 Added zdns paper ref to readme (#313)
$: go build
# github.com/zmap/zdns/pkg/zdns
./zdns.go:191:3: undefined: ulimit_check
./zdns.go:193:3: undefined: ulimit_check
$:

The issue is pkg/zdns/ulimit_check_linux.go's filename. The file name suffix _linux appears to be overriding the build constraint directives in the file that specify it is also applicable for darwin, so go build is ignoring this file. The secondary file, ulimit_check.go has a no darwin directive, thus zdns won't build. If you rename the file to literally anything else, it works.
PR coming shortly.

Addressed in PR #317


Trial Sentry Spike Protection

Background

Sentry has a spike protection feature. We have reviewed the feature before and decided not to use it.
However due to growth in use we want to revisit this feature.
Approach

Collate some stats on BAU operation without spike monitoring
Turn of spike protection on 15th March
Monitor dropped errors/transactions
Monitor if spike protection is triggered
Write up a summary

Questions / Assumptions

Do users notice any issues?
Is this feature too disruptive?
What is the impact on dropped errors/transactions

Acceptance Criteria

[ ] We understand the impact this feature has on BAU operation

Reference
How to write good user stories

Will be ready 15th March

protection enabled

Monitoring performance.

Have a set of baseline metrics to compare usage.

Trial completed. We have decided to enable protection. ADR updated.


Verson 1909 required?!

Why is this now a requirement? Our company machines use a standard Windows 10 LTSC build running on version 1809 and we can't go any higher than that. ( I know, I'm the IT guy) I used window walker every day on my company workstation. Now I can't because the new "Power Toys Run" feature which has window walker built in requires 1909? Please remove this requirement or separate window walker back out into it's own module please.

we are working on working downlevel for Run to work on 1803 for 0.19.

min version is 1903 currently for hte new PTs

To move forward and support older versions for most things, we need a stable version of WinUI 3.  Right now, there are a few known limitations that make it not a viable for a production use like this

Is this still in the works? Are plans in place to get this to work with 1809 LTSC? I would really like to use this function again.

PT Run can actually work now on 1809 but none of setting work is done nor will be transferred over to older system.  We need WinUI 3 in a stable preview state before we can take a dependency on it.

is there a way i can enable PT Run on 1809?

willing to bet if you just directly ran the EXE it would work.  It is a scenario we aren't proactively testing for however and when PT Run did come into existence, for a while, it did have a 1903 dependency.  There still may be code that does a API check inside it.


[ALLUXIO-2416] Split UnderFileSystem.exists into isFile and isDirectory

At present, implementations of the UFS.exists check for the existence of both a file and a directory. This is inefficient as Alluxio knows if the path is a file or a directory. This fix removes the exists call from the UFS API and adds isDirectory as a public API. All uses of exists are replaced with isFile or isDirectory.
https://alluxio.atlassian.net/browse/ALLUXIO-2416

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12225/
Test PASSed.

@calvinjia @gpang Please take a look. Thanks!.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12260/
Test FAILed.

@calvinjia Thanks for the review!. I intentionally addressed only some of the comments.

I agree that in the present form 'exists' makes a lot sense (wherever isFile || isDirectory is called). As per the new UFS API design, I'll try to eliminate isDirectory. As this is the first PR in a sequence directed towards branch ufs-inter, I purposely eliminated exists.
As for the optimizations, while I agree that those will benefit in the present form, later refactor might make them unnecessary.

I would like to address these 2 things when I merge ufs-inter with master. Let me know if you disagree.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12261/
Test PASSed.

Merged build finished. Test PASSed.

@madanadit Got it, we can revisit this when the entire refactor as gone through.

LGTM

@gpang

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12274/
Test PASSed.

@gpang Can you merge?. Thanks!.


audience/resource for token acquisition

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
Trying to figure how to acquire a token for AppConfiguration API and coming up short.
The API documentation is talking about requesting a resource and even though AuthenticationParameters has a field for it I get the error:

AADSTS901002: The 'resource' request parameter is not supported.

I tried using scopes for it, but it's not clear to me how to correctly setup *.azconfig.io as a scope - AppConfiguration is not listed as an API I can request permissions for.

scope will be something like https://{myconfig}.azconfig.io/.default
in your resource map you'll do [ 'https://{myconfig}.azconfig.io/', [ 'https://{myconfig}.azconfig.io/.default' ]],

@ranjanmicrosoft  that's what I thought, but then my other problem:
ServerError: invalid_client: AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in the requested permissions in the client's application registration. Client app ID: 7e327720-2c2b-4516-a52b-d255e3834907(avs-capman-dev). Resource value from request: https://*.azconfig.io. Resource app ID: 35ffadb3-7fc1-497e-b61b-381d28e744cc. List of valid resources from app registration: 00000003-0000-0000-c000-000000000000.

How do I add the *.azconfig.io URI to my app definition? It has to be registered somewhere because the manifest takes a GUID, not the URI:
	"requiredResourceAccess": [
		{
			"resourceAppId": "00000003-0000-0000-c000-000000000000",
			"resourceAccess": [
				{
					"id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",
					"type": "Scope"
				}
			]
		}
	],
	"samlMetad

Closing this as it looks like it's being handled in https://github.com/Azure/AppConfiguration/issues/338.


{Core} Change resource group preparer in testsdk

Description

Modify resource group preparer, replace the default value of location with the value of
'AZURE_CLI_TEST_DEV_RESOURCE_GROUP_LOCATION', so that we can leverage the preparer of testsdk to automatically create and delete resource groups at the specified location (rather than hardcoded default location) when performing live tests.
Would like to know if there are other ways to change the default value of location in the preparer.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Hi @FumingZhang, you could just pass location with expected value to override default one.
https://github.com/Azure/azure-cli/blob/5cf2ac3683ea1cb6103607106c06d6938bc0f61d/src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_account_scenarios.py#L1306

I don't agree with this PR. location in constructor is override by environment variable even I set it. I am astonished. https://en.wikipedia.org/wiki/Principle_of_least_astonishment

echo @qwordy. Just though about that with your change, all resource group locations will be changed even developers set specific location value in their test cases. Such change will also cause test failures because some tests only can be run in target region.

I don't agree with this PR. location in constructor is override by environment variable even I set it. I am astonished. https://en.wikipedia.org/wiki/Principle_of_least_astonishment

The premise of the location being overridden is that you manually set the environment variable 'AZURE_CLI_TEST_DEV_RESOURCE_GROUP_LOCATION', otherwise nothing will change.

My requirement is to run test cases in all locations where services are available for testing. As far as I know, there is currently no way to change the location value of the preparer used by the test case when testing through azdev. If there is a way to change the value of location when calling the test case, I would be happy to withdraw this pr.

Hi, any update?

@FumingZhang You can fork Azure CLI and customize it.

#18068
I have just filled another PR, and in that one, I create a custom preparer and replace the ResourceGroupPreparer provided by testsdk with it. Is this an acceptable way?

@FumingZhang This is a promising approach.

Found a workaround, closing this pr.


Add menu items for extra information like Call for Papers, Copyright, License, etc

Add extras from Event Model to the 3 dot menu items and show detail dialog on opening them
Would you like to work on the issue?
No
To be implemented after #1680

Hey, what all extra features you want in 3 dot menu? And the menu should be there in the home page only?

Call for Papers, Copyright, License, and other information from the Event model. And yes, home page should be the only one containing the items.

So it has to be static. Right?

@charul97 Yes, check the event response at : https://github.com/fossasia/open-event/wiki/[Nextgen]-Open-Event-Universal-Format-Specification

Okay, I want to try it out.

Alright, go ahead.
On Friday, July 7, 2017, charul97<EMAIL_ADDRESS>wrote:

Okay, I want to try it out.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-android/issues/1709#issuecomment-313492163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGQtlo47Wm1id1QYwrBQPEKIpXBMUdRCks5sLTIegaJpZM4N6Qpn
.

--
Best,
Harshit Dwivedi

I have created the menu in the ActionBar with all the 6 items in it- CallForPapers, Copyright, etc in it. But I am unable to identify that what all things we have to show in each item corresponding to the JSON format that you provided.

We have Event Model containing all of this information, please check the properties in it

Hello sir, i would like to work on this issue. Could you please let me know about the event model, the link you sent above was for event object.

@AkshayCHD The model is a Java class itself. It contains reference to several the same parameters as defined in the JSON format
You'd find the Java POJOs in the codebase itself, nevertheless, this is the class for Event model
https://github.com/fossasia/open-event-android/blob/development/android/app/src/main/java/org/fossasia/openevent/data/Event.java

Got it sir, just one more question, Do I have to open a separate activity when for example Copyright option is clicked, displaying the copyright information. And what is the exact list of items that i have to put in the menu.

No need to call me sir :smile:
You can display the Copyright info in a dialog only as a dedicated activity for that may be overkill.
As this issue is not a small one, you can start by creating a child issue and work on it and submit PR, and then move forward with another part of it :+1:

Sir, I have added the copyright to the overflow menu and added the functionality to it when it is clicked.
so creating the child issue means that i have to create a separate issue for work till now or should i send the PR with the the tag of this issue only, with commit message describing work that i have done till now.

Please create separate issue for Copyright item
This issue will be mentioned there but only closed when all items are added :smile:

Sir i have sent the pull request if you could review it

@iamareebjamal Sir now should i create a new child issue for call for speakers,

Sure @AkshayCHD

@iamareebjamal @heysadboy Is this issue still open? Can I work on it

Yes @codesun

@iamareebjamal @heysadboy What are the menu items that need to be added,
I added Call for paper, licence, Code of Conduct.. anything else is remaining?
And tell me how to display that data ?

That is good enough. Show these in a Dialog

@iamareebjamal do I need to create the classes for the response also?as they are not present
and
For example I would click on Call For Speakers and when no data is fetch the app would crash, shall this code be put in the try catch block ?

@iamareebjamal I am also looking up the response(as mentioned in the thread above) but I see no fields with call for paper and licence, etc?
From where do I have to get the data?

Event class has some fields as far as I can remember. The other fields were removed in the translation to JSONAPI format. Please correspond to the https://open-event-api.herokuapp.com/ for the location of fields in new API
When no data is fetched, the menu item itself should not be shown, or it can be displayed that there is no current information about these items, The same case which would be true if the fields were null in the API. Trivial :)

@iamareebjamal What shall be the layouts for the above 3?

@iamareebjamal I have seen that we have a copyright menu that displays the licence and licence url. Then why do we need to create another Licence menu? Is it needed

Well as the issue described, we have to implement anything what API provides and which is not implemented. So if the license is implemented, leave it. Note that copyright showing license for FOSSASIA event is different than API providing a license interface. We have to be in sync with the API
This is what the issue is for
The layout will be a simple dialog showing the text

@iamareebjamal check ur gitter :) thanks a lot


#360 - 0-bootstrap/1-org readme changes

see #360 clean org deployment testing

no merge conflicts with the following 3 - but I will wait to merge to avoid (3 git merge cycles in the following 3) - only 1 merge here instead
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/386
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/385
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/384


⚠ ClamAV has degraded performance

In 8afebff, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 422e12f.


JSON Schema here to help

Discussed in https://github.com/ehn-dcc-development/ehn-dcc-schema/discussions/95

Originally posted by Relequestual June  5, 2021
Hello!
Ben Hutton here from the JSON Schema team.
A link to this repo came across my desk.
Please let us know if we can be of any help or assistance. We are on hand.
If you would like to schedule a call, that's also possible.
Great to see you're using the latest draft of JSON Schema. We worked hard to make it happen.

Hi everybody,
I need some help for this issue,
I use windows 10 an Visual Studio Code.
When I try a make I obtain
Checking JSON formatting...
DCC.Core.Types.schema.json DCC.Core.Types.schema.json.tmp differ: byte 2, line 1
Please reformat DCC.Core.Types.schema.json
DCC.schema.json DCC.schema.json.tmp differ: byte 2, line 1
Please reformat DCC.schema.json
DCC.Types.schema.json DCC.Types.schema.json.tmp differ: byte 2, line 1
Please reformat DCC.Types.schema.json
DCC.ValueSets.schema.json DCC.ValueSets.schema.json.tmp differ: byte 2, line 1
and so on....
And at the end
Please reformat valuesets/vaccine-prophylaxis.json
./node_modules/.bin/ajv -c ajv-formats --spec=draft2020 --strict=false test -s DCC.combined-schema.json -d "examples/vaccination/*.json" --valid
error:  C:\Users\patri\Documents\ehn-dcc-schema-release-1.3.0 (1)\ehn-dcc-schema-release-1.3.0\DCC.combined-schema.json: Unexpected end of JSON input
make: *** [Makefile:23: test] Error 2
Any idea


uploadSingleDoc.js variables not importing

Well, the variables do import, it's just all of their values are blank. When the method calls session.getCookie(), the global variables in that method are blank, too.
Interestingly, they are not blank lower in the stack at uploadDocs.js. Weird!

Due to multi-threading, Gemini says worker threads work in separate environments and may have different instances of some variables than the main thread, which is why the values were blanked.
Solution: pass the values into workerData from uploadDocs()


Use with express - which is ES5

I'm trying to figure out if this is usable during this weird interim time when ES5 and ES6 have to co-exist.
I may have made some mistaken assumptions in my explanation below...
html-express-js seems to require ES6 - i.e. "import" - this is also what its docs show, and require('html-express-js') doesn't work
express seems to be ES5 - all its documentation shows 'require', even if express will work as a module many other things around it that I'm using won't (yet), so my "Main.js" is ES5 and uses require.
This doesn't need to be a problem - as could probably use what I believe are called "ES5 dynamic imports"
const htmlExpress = import('html-express-js')

except html-express-js exports both default and named functions, and I don't think its possible to see them via dynamic imports.
Maybe this is obvious to others, but I can't figure out the trick to get this to work in ES5 so maybe an addition to the README.md would be useful if I'm missing something.

Hey @mitra42, I'm having a little trouble understanding what the issue is, which may be specific to your project. Is it possible for you to give me an example set of code so that I can reproduce what you're seeing?

I get the following errror
import htmlExpress, { staticIndexHandler } from 'html-express-js'; // Note this is a module
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1088:15)
    at Module._compile (node:internal/modules/cjs/loader:1123:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.12.1

That import line appears in my Main.js, which is run as
node Main.js

So Main.js isn't a module and therefore cannot use import it has to use require
In particular it loads express via
const express = require('express');

@markcellus also stuck in a dilemma here, I am working on a project that uses CommonJS modules, the one that exports things like:
const myFeature = function() {
  return 'sample';
};

module.exports = {
  myFeature: myFeature,
}

In this type of project the only way to import things is through require keyword, an example would be:
const express = require('express');

When using html-express-js however, importing via require is not possible because the html-express-js is only exposing functionality through ES6 export syntax. An example of this is the one in src/index.js in this repo:
https://github.com/markcellus/html-express-js/blob/015f3cc42479966ccd96f1dfad167cc3af133070/src/index.js#L103-L123
Also in package.json type explicitly set to type: module.
Currently for us to use html-express-js in our project is to convert our project to use modules which will require us to re-write the entire codebase to support ES6 import syntax which I did in my previous projects but not everyone are willing to dedicate such time and energy in order to use a library.
Most library often support both CommonJS and ES6 import syntax, one such library is short-unique-id. This particular library uses esbuild to build for both CommonJS and ES6 as seen in their build script. We can support both CommonJS and ES6 using the same technique. Not sure if I will have time to make PR, once I have finished the thing I'm working on maybe I could help. Ping me if you would like help regarding this.
TL;DR
CommonJS projects cannot use html-express-js because html-express-js strictly builds using ES6 modules:

❌ Cannot do const htmlExpress = require('html-express-js'); because html-express-js does not support CommonJS exports
❌ Cannot do import htmlExpress, { staticIndexHandler } from 'html-express-js'; because our projects cannot use ES6 import syntax

Workaround using dynamic import
@mitra42 hi, we can use the following workaround at the moment while CommonJS modules are not yet supported. This is how I use html-express-js in our codebase:
// index.js

require('dotenv').config();
const { resolve } = require('node:path');
const express = require('express');
const app = express();
const serverless = require('serverless-http');
const cors = require('cors');

(async () => {
  app.use(express.urlencoded({ extended: true }));
  app.use(express.json({ type: 'application/json', limit: '400mb' }));
  app.use(express.static('public'));
  // use dynamic import to import html-express-js
  const htmlExpressPkg = await import('html-express-js');
  // desctructure the imported package, we assign htmlExpress alias to default
  const { default: htmlExpress, staticIndexHandler } = htmlExpressPkg;
  /**
   * Configure html-express-js as the rendering engine.
   * Templates will be in the local directory ./public
   */
  app.engine('js', htmlExpress());
  app.set('view engine', 'js');
  app.set('views', `${__dirname}/public`);

  app.get('/', (_, res) => {
    res.send('Hello world');
  });

  const listener = app.listen(process.env.PORT, function() {
    console.log(`App is listening on port ${listener.address().port}`);
  });
})();

module.exports.handler = serverless(app);

The code above uses dynamic import and destructures the imported package to properly assign name to default export. This requires to wrap our code inside an Immediately invoked async function expression so we can use await keyword on import statement. Similar example is showcased on the documentation about dynamic import on MDN. I have not encountered any issues with this setup at the moment.


Remove the Initial trait

The Initial trait was unnecessary complexity. Instead of requiring it, the library now does not make any assumptions about the initial state of the settings. Instead, parse and try_parse take a self parameter that represents the initial state. The easiest way to do this is still via Default (i.e. Settings::default().parse(...)), but that is not necessary.  Leaving this as a draft because I just wrote this very quickly had should look this over one more time later.

needs to be rebased :)

Done!


Add OpenAPI spec to build output

Currently, it's only possible to use the provided cli or by running the function to get the openapi document.
It would be great, if you could provide a MsBuild target/task as part of the nuget package which generates the specification during build.
Maybe an option in csproj <GenerateOpenApi>true|false</GenerateOpenApi> could to be added to opt-in or opt-out.
Are there any plans in this direction?

As the PR, #489, has been merged, you can generate the OpenAPI doc on-the-fly, within the GitHub Actions workflow.


bower.json: main: select2.css => core.scss

Per bower/bower.json-spec#43 :

Use source files with module exports and imports over pre-built distribution files.

Also, the example in that PR includes /sass/motion.scss in and excludes /dist/movement.css & /dist/movement.min.css from its main.

@kevin-brown Ping.
If reassurance is needed, see also: https://github.com/zurb/foundation/pull/6525, https://github.com/zurb/foundation-apps/pull/607, https://github.com/twbs/bootstrap/pull/16359, https://github.com/Semantic-Org/Semantic-UI/pull/2244

@cvrebert So the idea now is that those using bower downstream have to manually compile the files?
Actually, now that I think of it this shouldn't be an issue either way - as bower still clones the full repo anyway.


Loading Spinner Isn't Animated

(on Mac)
Example: clicking "Refresh" on the Databases page in the server dashboard. Loading spinner is static and doesn't have any animation:

In April (and before), we saw the spinner animate:

Reassigning for load balancing in shiproom


Provide API for Coordinates and Coordinate Groups

NetBox version
v4.1.1-dev
Topology Views version
v4.1
Feature type
Change to existing functionality
Proposed functionality
Provide API functionality like requested here https://github.com/netbox-community/netbox-topology-views/discussions/569
Use case
Coordinates and Coordinate Groups would be accessible via API.
External dependencies
No response

@dreng sorry, I have not been available. That's insane, thanks a lot for implementing this feature!


bypass hubploy image building

GitHub Actions failing b/c we're bypassing image building (https://github.com/escience-pangeo/dssg-jhub/runs/694409160?check_suite_focus=true). Should be fixed once https://github.com/yuvipanda/hubploy/pull/75 is merged

For now, must deploy changes with helm locally:
git checkout staging
git pull
unset AWS_DEFAULT_PROFILE
hubploy deploy dssg2020 hub staging


Update ubiquiti-unifi.md

Minor typo correction.  Changed "forwarder" to "forwarded"

Hi @FlyingBlueMonkey - Thanks for flagging this typo! Autogenerated content can't be manually edited, but the content owner has been notified for awareness.
@cwatson-cat - FYI

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Prompt tinkering

I changed the prompt to

be as close as possible to the author unit suggestion on the Miro board
reliably output a consistent JSON format

I have tested it. It looks good to me but I can give no guarantees. If you find the JSON output format to not be consistent, we may have to make the prompt even more precise.

I suggest a couple of changes:

adding the key "type" to each exercise type in order to parse it more easily in the conversion
changing the temperature to 0.2 or 0.3 to generate different exercises for the same prompt (there is gonna be a regenerate button in the frontend)
I would keep the exercises simple for now and generate a list of exercises if we want more than one and move subtasks to the next iteration because the conversion expects the normal exercise data model and not the exercise group data model

I suggest a couple of changes:
* adding the key "type" to each exercise type in order to parse it more easily in the conversion

* changing the temperature to 0.2 or 0.3 to generate different exercises for the same prompt (there is gonna be a regenerate button in the frontend)

* I would like to keep the exercises simple for now and generate a list of exercises if we want more than one and move subtasks to the next iteration because the conversion expects the normal exercise data model and not the exercise group data model. If we want to keep subtasks in the first iteration, I would want the output format to be the same for 0,1 or more than 2 subtasks. Parsing of the output becomes very tedious otherwise.

Thanks for your input.

I assumed the client would know what exercise type it has requested and could use that information for the conversion.
That is a valid point that I am aware of but thought can wait for the moment. If it still leads to good output we can change the temperature, yes. Should the quality suffer from a higher temperature, then I would prefer not having a regenerate button.
I tried to follow the requirement as I understood it from the Miro board. We can discuss simplifications. An option is also to initially limit the available options on frontend side, for example no subtasks.

I am not sure currently if the requested JSON output format decreases the quality of generated exercises. If it does, I would like to try first generating plain text exercises with the prompts as on the Miro board and then with a second prompt ask to convert it into the desired JSON format.

Merging this now for two reasons:

It seems to not have uploaded the Docker image yet because I created the PR before bumping the version. Putting it into the merge queue should change that.
What is currently on the main branch without these changes is not useful for anyone to work with.

If you have feedback, we can make changes in a new branch.

I made some changes in order to simplify the conversion to editor format. Furthermore I removed the plain text response and went back to output only JSON because the parsing step failed multiple times for me and outputting only JSON performed more consistently. Specifically, it outputs a task in plain text, but fails to add the JSON part and then the service outputs an error.

Specifically, it outputs a task in plain text, but fails to add the JSON part and then the service outputs an error.

Was that after increasing the temperature or already before?
I was fighting with that exact issue for some time but thought to have found a prompt that worked.

Specifically, it outputs a task in plain text, but fails to add the JSON part and then the service outputs an error.

Was that after increasing the temperature or already before?
I was fighting with that exact issue for some time but thought to have found a prompt that worked.

It was unfortunately even before increasing the temperature. Simple regeneration with 0.0 temperature failed for me, especially when only one subtask was supposed to be generated. That is why I removed it.


Work on v5.21.0

[x] Combine "Calls"

[x] Remove "Call"
[x] Put "Call with message" into "Favourite call"
[x] Add prompt to each action ("Save", "Cancel", "Send to all")

Release in ce4aa479


Integration of the docker role

installs docker on the gem-master via dochang's docker role on ansible-galaxy. Pulls his repo and checksout [here] (https://github.com/gemini-project/ansible-role-docker/commit/6fbe4eaeb1684ed3671cf1a2e7b37ad3eaefc71a) to avoid adding regex_escape in the [next commit] (https://github.com/gemini-project/ansible-role-docker/commit/6b8a1c6e1f8de4b70439872385d17b5133ebbe28)
This is one ugly recommendation, will be submitting another PR that installs docker by leveraging [contrib/ansible/roles/docker] (https://github.com/kubernetes/contrib/tree/master/ansible/roles/docker)

Closing because https://github.com/gemini-project/gemini-ansible/pull/64 is a better implementation


Network state unknown - Error

I am trying to run the example but receive the following error when I run yarn deploy.
yarn deploy
yarn run v1.9.4
$ truffle deploy --network loom_dapp_chain
Using network 'loom_dapp_chain'.

Running migration: 1_initial_migration.js
  Deploying Migrations...
Error encountered, bailing. Network state unknown. Review successful transactions manually.
Network Error
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I am running the loom node on the same machine the output of which is
I[08-04|23:43:11.543] Using simple log event dispatcher
I[08-04|23:43:11.567] Deployed contract                            vm=plugin location=coin:1.0.0 name=coin address=default:0xe288d6eec7150D6a22FDE33F0AA2d81E06591C4d
Init DPOS Params &dpos.DPOSInitRequest{Params:(*dpos.Params)(0xc420b7e6f0), Validators:[]*types.Validator{(*types.Validator)(0xc420b8da20)}}
I[08-04|23:43:11.567] Deployed contract                            vm=plugin location=dpos:1.0.0 name=dpos address=default:0x01D10029c253fA02D76188b84b5846ab3D19510D

I have tried this both on linux and OSX with exactly the same results. Please advise
Thnx

Hey @moringaman this error generally happens when the truffle isn't capable of reach the address defined on the truffle.js configuration. If you're using the default configuration should be <IP_ADDRESS>:46658. Could you please check if after run the ./loom program if the port is available. You can check running lsof -i -n -P | grep -i 46658, if the host and port are returned then you can please run curl localhost:46658/rpc to check if you can reach the Loomchain.

Hi @eduardonunesp Thanks for the response to this one, I have run the checks you have suggested and am not getting the loom rpc service listening on port 46658. Have followed the instructions to the letter althought they do seem very concise.
One thins I would say is that the instructions for setting up and running loom on a linux (deb) based system given on this url: https://loomx.io/developers/docs/en/prereqs-ubuntu.html are a lot different to the ones at this ur:l https://loomx.io/developers/docs/en/basic-install-linux.html.
I am still a little unsure however what the full procedure for installing and running a local loom node are?
P.S I've tried this on Arch, Lubuntu and OSX with the same results

@moringaman thanks for the report, could you please inform what is the current version used? ./loom version

@eduardonunesp The version is 1.0.0+b330

No loom.yaml, does that get created with ./loom init ?

Nope, but you can try to create a file loom.yaml on the same directory and try to set the config RPCProxyPort: 46658 and make sure that config on truffle-dappchain-example  uses the port 46658 too

I created a loom.yaml file in the same directory as the loom binary and checked truffle.js which is referencing port 46658 but I'm still getting the same result. Can you confirm what I should expect to see in the console when I run ./loom run?

I just tested here, with the latest truffle-dappchain-example and loom  build 330, and you should see something like:
$ yarn deploy:reset
Using network 'loom_dapp_chain'.

Running migration: 1_initial_migration.js
  Replacing Migrations...
  ... 0x02666a3bea90d1c4fd6420cc548c3654b1f871355326b1e8c72be1cda4665e4a
  Migrations: 0x6d002528e54a421f5e7375690e5fb74b75add0d8
Saving successful migration to network...
  ... 0x0653423baa7994fe3a5eb6712382f3a783478180488f2b83359627900297436b
Saving artifacts...
Running migration: 2_simple_store.js
  Replacing SimpleStore...
  ... 0x87cefb629176a846122eed354522f003b4d865e3e3274be880a47abb7265213f
  SimpleStore: 0x1a31b9b9d281d49001fe7f3f638000a739afc9c3
Saving successful migration to network...
  ... 0x7ddd8df83539848f21df3908fc4e24a630b53a82235b8a31ad9e03c8bc99c36d
Saving artifacts...

Also testing
yarn test
yarn run v1.7.0
$ truffle test --network loom_dapp_chain
Using network 'loom_dapp_chain'.

  Contract: SimpleStore
    ✓ Should have an address for SimpleStore
    ✓ Should set a value (1019ms)

  2 passing (5s)

Running on macOS 10.13.6
Go version go1.10.2 darwin/amd64
Node verison  v10.7.0

And when you execute ./loom run? what do you see in the console?

Humm, interesting, maybe there's some issue when you try to map to localhost (<IP_ADDRESS>)

I have tried this on a number of systems (3) to be exact by following the online guide without any success so maybe the guide is missing a few steps. I am able to run a geth node locally mapping to localhost <IP_ADDRESS> without any problems.
Also why is there no mention of the docker image in the docks and do you know whether it's being maintained as I can see that it's running loom build 1.0.0+b349 which is ahead of the one in the example?

oh the docker image is probably to new, you likely want to run build 330

So theoretically one could just copy the build 330 binary into the docker container and run it?
Also for use with the truffle-dappchain-example it is necessary to expose all the websocket ports in the run command i.e.
docker run -p 46656:46656 -p 46657:46657 -p 46658:46658 -p 9999:9999 loomnetwork/loom

This example is update with latest loom SDK

Tested recently and Loom SDK with Docker and just works, I'll close this issue due to the inactivity also


Is there a C + + sample? of winui3

Hey @liangboIcyice! No, we don't provide cpp samples at the moment and are mostly focused on c# samples. However, feel free to contribute to this repo by adding cpp snippets if you want! We would definitely welcome your help.

嘿@liangboIcyice！不，我们目前不提供 cpp 示例，主要关注 c# 示例。但是，如果您愿意，可以通过添加 cpp 片段来随时为这个 repo 做出贡献！我们绝对欢迎您的帮助。
ok，  I want to know how to use XAML designer for visual UI design of C + + program?Xaml designer will greatly increase efficiency

@gregwoo-microsoft
ok， I want to know how to use XAML designer for visual UI design of C + + program?Xaml designer will greatly increase efficiency


fix: k9s on darwin with xdg disabled

k9s expects configuration files on OS X to live in ~/Library/Application Support/k9s instead of ~/.config.k9s. This commit handles the case where the module is built for a darwin system with xdg disabled.
See: https://github.com/catppuccin/nix/issues/310

I ran into a similar issue with lazygit (see #312 ). Would it be easier to maintain this flake if there were an assertion ensuring XDG is enabled rather than sprinkling in darwin checks?

This worked for me as expected on Darwin both with and without xdg.


 What other docs changes need dropped from this commit? I fear some content cannot be simply dropped because the language won't make sense.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

2m 32s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1880

Optional Tests

uname
Linux<PHONE_NUMBER>de 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b67f896954

Max. process+thread count
49 (vs. ulimit of 12500)

modules
C: . U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
branch-2 passed

+1 :green_heart:
mvnsite
16m 53s
branch-2 passed

+0 :ok:
refguide
6m 53s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
mvnsite
12m 18s
the patch passed

-0 :warning:
whitespace
0m  0s
The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+0 :ok:
refguide
7m  7s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

54m 32s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1880

Optional Tests
dupname asflicense refguide mvnsite

uname
Linux 3d5884f49987 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / b67f896954

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/artifact/yetus-general-check/output/branch-site/book.html

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/artifact/yetus-general-check/output/whitespace-eol.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
89 (vs. ulimit of 12500)

modules
C: . U: .

 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
branch-2 passed

+1 :green_heart:
mvnsite
16m 48s
branch-2 passed

+0 :ok:
refguide
6m 40s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  7s
the patch passed

+1 :green_heart:
mvnsite
12m  3s
the patch passed

-0 :warning:
whitespace
0m  0s
The patch has 51 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+0 :ok:
refguide
7m  0s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

51m 49s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1880

Optional Tests
dupname asflicense refguide mvnsite

uname
Linux 0bdf544bb157 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 035ea516e9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/artifact/yetus-general-check/output/branch-site/book.html

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/artifact/yetus-general-check/output/whitespace-eol.txt

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
89 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1880/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Huggingface Datasets do not match website datasets

My submission got flagged for missing entries. Turns out those entries are not in the HF version of zeroscrolls. To reproduce:
dataset = load_dataset("tau/zero_scrolls", task, split="test")
for d in dataset:
     if d['problem_id'] =="crs_R46013":
          print('contains') # will never print.  ```

Hi,
Actually this entry does exist in the GovReport test set in HF.
The id is "crs_R46013" and pid is "crs_R46013_0".


Refactor BBM logic into context processor

Each of these request.get_host in the template is a call to the get_host() method on a WSGIRequest. It's hard to tell because in the template syntax we can call a method without the parentheses.
This probably isn't a massive performance problem but it's unnecessary. It's better to group this logic together so that we only run it once in the context processor. This also means we can test it easily.

nice, context processor FTW ! 👍🏼🍰🍰


Feature request: Usage with Router

Greetings, thanks for writing up this great library.
There is currently an issue where wrappers are hard-coded. To be truly headless, users should be able to change the wrapper tag to something else. E.g, <Link> component for each page button instead of <span>.
Potential solution is to add custom renderer function for more flexibility.
Thanks.

Agreed - this would be a nice touch - similar to the way in which Radix UI offers an asChild prop - which we use extensively.

For example...
https://github.com/infonomic/react-headless-pagination/blob/feat/radix-primitive-version/src/Pagination/Pagination.tsx
We use Radix UI, and so aren't afraid of the Radix primitive dependency, but you might want to do something a little different.
Radix is nice, because by inheriting from their primitive, you can simply add the asChild prop - and then whatever you place as a chidren inside the PrevPage, NextPage PageButton components - will render instead - merging all props.
In this case we're using our components with Remix, and so you might consider a 'stateless' version, where the component simply re-renders via a server-side render request (and loader), and so all that happens is that the URL updates with a new pageNumber in the query string.
I've only lightly tested this with your current StoryBook setup, and it's not complete yet - but we may create a fuller implementation along these lines.
Hope this helps.

This would be perfect


Print given matrix into Spiral form

Description
Print given matrix into Spiral form
Fixes #2240
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update
[x] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Ayush7614  @Amit366  please review my PR
under HCsSOC 21
language: C
test case added in code file

@ravikr126  i did this PR for HCSSoc , not LGM soc. please change the label


Typo fixed

changed $fase to $false

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access-servers/Set-OwaVirtualDirectory.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Apoc70 - thanks for catch and fix! Much appreciated.


[Feature][Core] Auto Rotating the OMR sheet

We want to be able to identify and correct rotation of input images
Some ideas

Firstly, we can take expected page orientation(portrait/landscape) from user.
For a start, check for height-width ratio and always rotate clockwise (ignore wrongly rotated images, will be separated later).
Try both clockwise and anti-clockwise corrections and the one with the "more correct" histogram will be considered.

Acceptance criterion:

The code should run for rotated versions of all sample images in the repo.
Proper logging of rotations should be done to make debugging easier

Example real user validation: https://discord.com/channels/590134763784896514/590134763784896520/908620446201696316
Note: this issue is marked with the hacktoberfest label. Follow #hacktoberfest-discussions on Discord for further details .

I would like to work on this issues please assign it to me

Hi @aksha123-git , no problem! please go through the code once and discuss an approach for this on discord. Once we have a clarity on how to move forward I'll assign it to you. fyi there is one more person who has approached me to work on this. So better to start a discussion soon.

@aksha123-git let me know if there are any updates or any help needed :)

@Gauravmauryaios you can discuss your approach with me on discord before getting assigned :)

Pasting approaches from the code comment here:
        """
        TODO later Autorotate:
            - Rotate 90 : check page width:height, CW/ACW?
                - do CW, then pass to 180 check.
            - Rotate 180 :
                - check markers centroid (OMR specific, paper warping may be imperfect.)
                - OCR check
            - Check column fields like roll field after morphing should be 'vertical' (based on col_orient)
        """

@Udayraj123  sure

Adding an approach for OMR sheets containing a "direction indicator" marker -

We can create a pre-processor that auto-rotates the image based on the presence of a marker in a given position (it will hit and try the rotations in the order - top, bottom, left, right
ref: https://products.aspose.app/omr/create-answer-sheet

Changing difficulty from Medium to Hard considering the scope of the problem is now more generic and an abstract solution is possible from the current dev branch.


Readme examples

Adds examples, colab link to README

@rynmurdock Best to squash and merge to remove the extra commit noise