roachprod wipe local fails

roachprod create local, roachprod start local all worked fine. After that I attempted a wipe, which resulted in.
local: wiping 4/4
0: Process exited with status 1: zsh:1: no matches found: /home/arjun/local/1/certs*

1: Process exited with status 1: zsh:1: no matches found: /home/arjun/local/2/certs*

2: Process exited with status 1: zsh:1: no matches found: /home/arjun/local/3/certs*

3: Process exited with status 1: zsh:1: no matches found: /home/arjun/local/4/certs*

roachprod destroy gives the same error message.

Doesn't happen for me. Perhaps there is something different with zsh (I use bash).

We should probably always use Bash.

@arjunravinarayan Just curious, but will using an ssh forced command do the job?
In your ~/.ssh/authorized_keys, if you prefix your local identity's entry like so, does the command work?
command="/bin/bash -c '$SSH_ORIGINAL_COMMAND'" ssh-rsa YOUR-KEY-DATA

Otherwise, we can take every use of ssh.Session.CombinedOutput() and related functions to wrap the invocation in a /bin-bash -c setup.
Also, how many Roachers use shells other than bash?  Thoughts?

I use zsh as well. The problem is a difference in expansion behaviour between the two shells.
			cmd = fmt.Sprintf(`rm -fr ${HOME}/local/%d/{certs*,data,logs} ;`, c.Nodes[i])

Could we just change this line to rm -fr ${HOME}/local/%d/* instead?

IIRC there might be things we don't want to delete in ~/local/x/, like a cockroach binary.

IIRC there might be things we don't want to delete in ~/local/x/, like a cockroach binary.

That's correct. We could certainly manually perform the brace expansion.

I'll tweak the code to expand the braces.


Slack Invite Bot Not Working

Slack is failing to send our veterans an automatic email.
Code:
https://github.com/OperationCode/operationcode/blob/master/app/controllers/veterans_controller.rb

Hi @davidmolina, I just looked into this and it seems like the code is working in development mode (at least, the job is queuing correctly).  Is there anything from the Sidekiq log or application log when someone tries to do this on the production site?

Not sure.
Don't have the user/pass. Can we check in Heroku?

On Nov 28, 2015, at 5:50 PM, Nell Shamrell-Harrington<EMAIL_ADDRESS>wrote:
Hi @davidmolina, I just looked into this and it seems like the code is working in development mode (at least, the job is queuing correctly). Is there anything from the Sidekiq log or application log when someone tries to do this on the production site?
—
Reply to this email directly or view it on GitHub.

That is a good question.  Let me do some research.

Got another note this week (Twitter). A veteran didn't get an auto-invite to Slack.

On Nov 30, 2015, at 9:22 AM, Nell Shamrell-Harrington<EMAIL_ADDRESS>wrote:
That is a good question. Let me do some research.
—
Reply to this email directly or view it on GitHub.


Build fails due to robot UNKNOWN ARG ERROR

Describe the bug
On the most recent build attempt (sudo make all_release), this error appears during running the update query for subq patterns:
#echo "Running update query for subq patterns..."
robot --catalog catalog-v001.xml query --input tmp/phenio-full.owl --format 'owl' --update tmp/subq_update.sparql --temporary-file 'true' annotate --ontology-iri http://purl.obolibrary.org/obo/phenio/phenio-full.owl annotate -V http://purl.obolibrary.org/obo/phenio/releases/2024-02-29/phenio-full.owl --annotation owl:versionInfo 2024-02-29 --output phenio-full.owl
UNKNOWN ARG ERROR unknown command or option: --temporary-file
For details see: http://robot.obolibrary.org/errors#unknown-arg-error

To Reproduce
Run robot update with --temporary-file 'true' annotate argument.
Expected behavior
This error should not appear - or at least it hasn't previously.
ODK is the most recent version (latest, or v1.4.3)

I think the build was just running with the wrong ODK image due to running sudo make all_release instead of sudo sh run.sh make all_release. Will close if that was the issue.

I suspect the JRE error was due to interacting with a corrupt temp file - clearing out the tmp dir AND the .tdb AND all previously created artifacts appears to solve the issue.


Xiaomi mi max 3 default keyboard ignores TextInputAction on TextField

Xiaomi mi max 3 default keyboard always shows DONE button on keyboard, ignoring TextInputAction on TextField.
This happens only with default keyboard, if I switch to google keyboard then it works correctly.
My code:
          TextField(
            textInputAction: TextInputAction.search, // also tried newline
            autofocus: this.widget.autofocus,
            onSubmitted: _submit,
            keyboardType: TextInputType.multiline,
            maxLines: null,
            textCapitalization: TextCapitalization.sentences,
            style: TextStyle(
                color: Theme.of(context).textTheme.body1.color,
                fontSize: Consts.CHAT_TEXT_SIZE),
            controller: _textEditingController,
            decoration: InputDecoration.collapsed(
              hintText: this.widget.placeholder ??
                  AppLocalizations.of(context).sendMessage,
              hintStyle: TextStyle(color: CustomColors.fadedColor),
            ),
            focusNode: _focusNode,
          ),

Flutter doctor -v, connected device is the one with this issue
[✓] Flutter (Channel dev, v1.3.10, on Mac OS X 10.14.3 18D42, locale ru-RU)
    • Flutter version 1.3.10 at /Users/admin/dev/Flutter/flutter
    • Framework revision 4feefa3c9a (2 weeks ago), 2019-03-14 10:21:03 -0400
    • Engine revision 8b1a299ed5
    • Dart version 2.2.1 (build 2.2.1-dev.1.0 674fd0e060)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/admin/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.32.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.24.0

[✓] Connected device (1 available)
    • MI MAX 3 • ee87cc95 • android-arm64 • Android 9 (API 28)

• No issues found!

CC @GaryQian

Do you know if this is only with a Xiaomi mi max 3? I don't have that specific device to test on, but if it repros on any other Xiaomi (or other OEMs) devices, it would help a lot to fix this.

@GaryQian, https://play.google.com/store/apps/details?id=com.facemoji.lite.xiaomi.gp&rdid=com.facemoji.lite.xiaomi.gp - this keyboard app causes this issue. I've reproduced this bug on lg g6 with this keyboard. Non-flutter apps (telegram, for example) correctly show newline button where needed with this keyboard

Hi @Uzere
Are you still experiencing this issue on latest stable?
if yes, Can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample.
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


mempool: use fifo behaviour for threads using addtx

Change the behaviour for multiple concurrent threads using addTx/addTxs: provide simple fifo behaviour.
The first change also refactors the addTxs implementation to simplify it by removing unused features.
This uses MVars for the fifo behaviour, and depends on some MVar fixes in io-classes: https://github.com/input-output-hk/io-sim/pull/70 specifically the change for MVar being injective. We need that to provide the MonadMVar (WithEarlyExit m) instance, which is necessary to add MonadMVar into IOLike.
Still TODO:

The io-classes PR needs merging, and the various consensus/network packages will need updating to the new version (just bumping version bounds as far as I have found so far).
There is a test for the existing complicated behaviour (batch, non-blocking) of implTryAddTxs which no longer makes sense. What this test is testing for will need to be rethought.

Superseded by https://github.com/input-output-hk/ouroboros-consensus/pull/49


Standalone deploy binary/image

Changes

The utility (socat/tar) image is now built in GH Action and stored in GH image registry. Previously it was build completely ad-hoc and stored in some quay.io repository.

The utility image contains new tiny standalone deploy binary. This binary is used in deploy task instead of full-fat func binary. The binary is smaller and breaks cyclical dependency where func CLI references image with func CLI itself.

PTAL @lkingland @matzew @gauron99

For some reason Rust Buildpack build is failing, I believe that's not related to this PR.

@ReToCode would you please override the failing tests. The rust buildpack is now failing for some reason but I am pretty sure it's not related to changes in this PR.
/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"
/override "E2E Test (rust) (pull_request)"

/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"

/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"
/override "E2E Test (rust) (pull_request)"

/override "E2E Test (rust)"
/override "On Cluster RT Test (ubuntu-latest, pack)"


services/xrefs: properly filter ref/call edge variants [phab:D2159]

Created by schroederc at 2018-01-31 23:06:44:

zarko accepted this revision at 2018-01-31 23:08:29

schroederc closed via commit 3968afc5a83ceefefc752585c5681dbe63cd800e at 2018-01-31 23:15:03


go-mode: init at 20150817

Can you please rebase onto something futher than
6a192b4e986993dbae88fa0cffcd4074e5d563a6 and then add a proper
description there?

@oxij rebased onto master and added a description

Thank you!
:+1:

@oxij would you like to merge this, or are we waiting for something else?

I would, but I don't have the right.
/cc @jagajaga @ttuegel


ArgumentError: wrong number of arguments (given 3, expected 1..2) with rails 6

Hello,
There's an error when used with rails 6
Error:
ActiveSupport::Cache::DalliStore::active_support caching#test_0005_handle nil options without LocalCache:
ArgumentError: wrong number of arguments (given 3, expected 1..2)

.
.

Error:
ActiveSupport::Cache::DalliStore::active_support caching#test_0004_handle nil options with LocalCache:
ArgumentError: wrong number of arguments (given 3, expected 1..2)

rails test <<PKGBUILDDIR>>/test/test_active_support.rb:27
.
Finished in 60.624597s, 2.9691 runs/s, 243.5480 assertions/s.
180 runs, 14765 assertions, 0 failures, 2 errors, 0 skips
rake aborted!

You can find the full log here
https://people.debian.org/~praveen/rails6-meta-build/buildlogs/ruby-dalli.log

Fixed.


Input element changes not reflected

It seems that changes to input elements that are bound to a variable don't cause a change anymore.
This can be observed in the introduction example.
Changing the dropdown on the "Eviction counts in San Francisco by Year" graph from "Bar" to "Line" does not re-render the graph with the changed variable value anymore.
This used to work.

Hmm, yes, this must have broken recently. Will investigate.

Forgot to handle cache invalidation when I did up https://github.com/irydium/irydium/pull/222

Thanks for the bug report @badboy!

Thanks! It's working again


Using different view widgets

Hi! How to use different Views in one table?
In the example below, in Student name column, i want to use TextView, but in Score and Comment i want to use EditText. how to realize this?

Hi @ddk9499 , you can achieve that by creating a different ViewHolder for each type of cell (StudentNameViewHolder w/ TextView, ScoreViewHolder w/ EditText and CommentViewHolder w/ EditText), see #41 for the answer. Hope it helps.


FixBlogLinks: updates to 15 articles

Updated blog links in 15 articles per mseng User Story 1443043.
Contributes to #9807.

@mairaw  - Hi, Maira. I've got another 15 files ready to review. Please let me know if anything should be changed before we are able to merge. Thanks for your help!


Add dev nice-to-haves to install-pip-dependencies

See also https://github.com/illinois-ceesd/emirge/issues/47 - worth to add ipython still?

IPython is on the larger side, and I don't use it much. Someone who uses it should speak for it. @lukeolson?


【0.11.0 “list”渲染性能问题】

iOS版本 WeexSDK 升级到 0.11.0 后 list 的渲染速度明显变慢了1-3秒（之前版本主要是能看到cell一个一个出现的问题）

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


Add manual trigger for building the perfetto UI without releasing it

@jfaltermeier Good point! I just tested it here and it does indeed create a zip within a zip, I'll fix it.

I think it looks good now. I diffed the contents of the Zip with the last release and the only difference was the additional README. So when we remove the additional PR triggers again we may merge this imo.


chore(deps): update dependency typescript to v3.3.4000

This PR contains the following updates:

Package
Type
Update
Change
References

typescript
devDependencies
patch
3.3.3333 -> 3.3.4000
homepage, source

Release Notes

Microsoft/TypeScript
v3.3.4000
Compare Source
This fix is identical to release 3.3.3333, but omits a non-essential artifact that was previously published to npm which impacted builds using Jenkins.

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Enabled.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.68.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


remove top_annotation_height argument for Heatmaps

Hello, first thanks for using ComplexHeatmap!
I recently updated the ComplexHeatmap package and I slightly changed arguments for some functions. One of the removed argument is top_annotation_height in Heatmap() function, and now the height of the annotations is only controlled in HeatmapAnnotation() function. I noticed some of your functions still use top_annotation_height argument and it will break the checking or building of your package in the future.
I made small changes to your package, basically to make it consistent with the new version of ComplexHeatmap. You can merge it if you find it useful.
Cheers,
Zuguang

Hi Zuguang,
Thank you for the patch. This should fix Bioconductor build results.
-Anand.


Layer Attention instead of Channel Attention?

Why did you choose Layer Attention instead of normal Channel Attention?
Task-interactive features are concatenated after N consecutive Conv layers, then using Channel Attention could further separate each channels to specific task, instead of Layer Attention, which also conduct separation on channel dim, but can only separate in group of 6?

The tasks of object classification and localization have different targets, and thus focus on different types of features (e.g. different levels or receptive fields). The N interactive layers in T-head have different effective receptive fields, which allow them to capture multiple levels of semantics. The layer attention is designed to make full use of this rich information by computing more meaningful features from those layers.

The tasks of object classification and localization have different targets, and thus focus on different types of features (e.g. different levels or receptive fields). The N interactive layers in T-head have different effective receptive fields, which allow them to capture multiple levels of semantics. The layer attention is designed to make full use of this rich information by computing more meaningful features from those layers.

I understand the intuition of Layer Attention. However, Layer Attention is just a special type of Channel Attention. And Channel Attention can also capture multi-level semantic features no? :thinking:

@fcjian hello can we discuss about this when you have free time?

@iumyx2612 The typical channel-wise attention is applied on a single layer. I hold the view that conducting channel-wise attention on multi-layers can be seen as the combination of the typical channel-wise attention and layer attention. So It can also capture multi-level semantic features but requires more parameters and FLOPs.

@iumyx2612 The typical channel-wise attention is applied on a single layer. We hold the view that conducting channel-wise attention on multi-layers can be seen as the combination of the typical channel-wise attention and layer attention. So It can also capture multi-level semantic features but requires more parameters and FLOPs.

Thank you very much, understood


Remove server reference from readme

The Testserver https://sci.abaplint.app is no longer available, so its reference should be removed.
Closes #1575

thanks


Multiarch build server docker images

Hi @6543,
thanks for working on this!
I also can't reproduce this locally using make cross-compile-server. I can however reproduce it using the following Dockerfile:
FROM techknowlogick/xgo:go-1.17.x

WORKDIR /src
COPY . .

RUN apt update
RUN apt install -y tree
RUN PLATFORMS="linux|amd64;linux|arm64" TAGS="bindata sqlite sqlite_unlock_notify" make cross-compile-server

->  #821


Improve Esc key behavior on search bar

This implements the following improvements for Esc key behavior on some elements of the search bar:
Search bar
Goal: don't close filter drawer when pressing Esc in the search bar, just unfocus the search bar.
Use case intention: ability to quickly abort the search (e.g. to use global keybindings again such as "N" for a new todo) without affecting the filter drawer.
Old behavior

filter drawer open + search bar focused
Esc key pressed
filter drawer closed, search bar unfocused

New behavior

filter drawer open + search bar focused
Esc key pressed
search bar unfocused, filter drawer stays open

"Add as todo" button
Goal: don't close filter drawer on Esc when "Add as todo" is focused, also return focus to search bar on Esc key press.
Use case intention: quicker way to decide against "Add as todo" while highlighted without affecting the filter drawer as an alternative to Shift+Tab.
Old behavior

filter drawer open + search bar focused
Tab key pressed
"Add as todo" focused
Esc key pressed
filter drawer closed, "Add as todo" stays focused

New behavior

filter drawer open + search bar focused
Tab key pressed
"Add as todo" focused
Esc key pressed
Focus shifted from "Add as todo" back to search bar, filter drawer stays open

There currently is one minor cosmetic issue that I haven't figured out yet how to address: when using Esc to unfocus the search bar, the "Add as todo" button will stay visible but using the mouse to click somewhere else to unfocus the search bar instead, will also hide the "Add as todo" as well.
How can I additionally hide "Add as todo" on Esc key press in the search bar?


ts : convert debug.js to typescript

This pull request converts web/src/debug.js to typescript
In making that possible,I added interface Collisions  in function check_duplicate_ids to specify the strict parameter types to define the types of the collisions parameter of check_duplicate_ids  which is an object and   also add the required return types to all the functions

Self-review checklist

[X] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[X] Explains differences from previous plans (e.g., issue description).
[X] Highlights technical choices and bugs encountered.
[X] Calls out remaining decisions and concerns.
[X] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[X] Each commit is a coherent idea.
[X] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[X] Corner cases, error conditions, and easily imagined bugs.

No, don’t change the existing “collisions” to “collision”. It should be singular when it’s one object, plural when it’s an array or a count. The existing code is right. Just your new interface should be singular.

No, don’t change the existing “collisions” to “collision”. It should be singular when it’s one object, plural when it’s an array or a count. The existing code is right. Just your new interface should be singular.

Ive fixed it Im now working on fixing the node test fails

@andersk I have made the required changes

Merged, after rewriting the commit message. Thanks for the work on this @nzaih1999; please apply the lessons from the feedback here to any of your other TypeScript PRs, as this required a lot of review round trips for a fairly small change.

Thanks for the merge. I'll be working on perfecting the remaining PR's to reduce double checking.


Would it be helpful if the commit hash (short) is added along with the url and name of the project?

          Would it be helpful if the commit hash (short) is added along with the url and name of the project?

Solana
forked-from-repo: "name:projectname,url=https://github.com/solana-labs/solana,chash=4e5edd8a461dfa2304d721ebd378ae82b0abb856"

Or we can add branch name or release tag, instead of commit hash.
Originally posted by @mryalamanchi in https://github.com/neodyme-labs/solana-security-txt/issues/7#issuecomment-1100156895

forked-from-repo: "name:projectname,url=https://github.com/solana-labs/solana,chash=4e5edd8a461dfa2304d721ebd378ae82b0abb856"

          Would it be helpful if the commit hash (short) is added along with the url and name of the project?

Solana
forked-from-repo: "name:projectname,url=https://github.com/solana-labs/solana,chash=4e5edd8a461dfa2304d721ebd378ae82b0abb856"

Or we can add branch name or release tag, instead of commit hash.
Originally posted by @mryalamanchi in #7 (comment)

Haha

Haha

kire khar ti kade nnan


fix behaviour when simple product has no parent id

What it does and why:
When deciding whether to run pipeline stages, check the product type rather than whether parent_id exists. This means that when there are simple products without a parent_id, the conversion will work as expected - running both the top level product transformations as well as the variant level transformations.
The idea is that the behaviour should stay the same for the normal case (where configurable products always have no parent_id and simple products always have a parent_id that corresponds to an existing configurable product). However, in the case where there are simple products with no parent_id, we should return a sane CSV that can be imported to the Transporter app.
Checklist:

[x] Testing & QA: Passes tests and linting.
[x] :tophat:: I have manually tested these changes.

Related issues:
Closes:
https://github.com/Shopify/shopify_transporter/issues/100

Fixed Ziyan's complaint above. Have crosschecked behaviour with master's in a number of cases to make sure the output matches what is expected.

I've 🎩  the pr for both pairs of child/parent products and simple products without parent. Works perfectly!


Metadata export - change dataset time to center time

Just change dataset time to a single timestamp - center_time

@ashoka1234 please rebase this branch against master

@ashoka1234  don't bother with this I'll just cherry-pick this commit into master


Remove me from team.yml

I removed David Paz and Santiago entries.
I moved Miguel and Manuel Carmona into Data Retrieval team.
I added Ricardo into Product team

Can you ptal @marnovo ? thanks

Superseded by https://github.com/src-d/landing/pull/140


How to set window size

Is your feature request related to a problem? Please describe.
When client receiving a large messages, it report:
Incoming frame of size 96014 exceeds local window size of 65535.
The (un-acked, future) window size would be 4194304 which is not exceeded.
This would usually cause a disconnection, but allowing it due tobroken HTTP2 implementations in the wild.
See (for example) https://github.com/netty/netty/issues/6520

Describe the solution you'd like
Make window size configurable like this
Additional context
language: php
grpc version: 1.27

Yash, it doesn't look like we have a way to set the initial HTTP/2 window size.  Go obviously has this, but maybe check with Java too and decide if this is something that we should support across languages.

@ejona86 @dfawley Thoughts on this?

I thought y'all already had a knob, because I remember discussing with Craig how the knob interacted with BDP estimation. It looks like GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES may tune the window size?
Although changing the window size doesn't seem like it would fix the error reported, as the race is possible any time the size changes. GRPC_ARG_HTTP2_BDP_PROBE would avoid the issue, but I would not recommend that at all.
Since that issue in the message text is from 2017, I wouldn't expect people to hit it today. @NicoChenyt, do you know the grpc server language and version? Are there any proxies being used? I am suspicious there is a newcomer to the HTTP/2 world that has a bug.

Haha! GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES (iirc) does not work as expected with BDP enabled (which is the default). I assumed that the want was to control the initial window size even when bdp is enabled.
Also, BDP is enabled in gRPC Core by default, and has been our recommendation for quite some time now  :D

In Go the window size can be set explicitly, which overrides our BDP estimation.  We don't recommend this option for most users for that reason.

GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES (iirc) does not work as expected with BDP enabled (which is the default)

What do you mean "as expected"? How does it behave and what would be expected?
I thought it set the initial window size, and then BDP could increase the window size further.

@NicoChenyt, do you know the grpc server language and version? Are there any proxies being used? I am suspicious there is a newcomer to the HTTP/2 world that has a bug.

@ejona86  PHP 7.x + Swoole 4.4.17 ,  no proxy

@NicoChenyt, just for sanity, can you confirm that grpc-java is version than 1.4+ (which wouldn't have the bug).
If it is a direct connection between grpc-php and grpc-java, then a bug has cropped up. That said, I'm suspicious as to why we haven't heard more reports about such an issue.

Incoming frame of size 96014 exceeds local window size of 65535.

This is weird. How is the window 64k. @yashykt, will C reduce its window size over time?

@dfawley @ejona86 Sorry for the confusion here.
I said GRPC_ARG_HTTP2_STREAM_LOOKAHEAD_BYTES does not work as expected since the value provided is quickly overwritten by the value calculated by BDP, and hence we see the number 4194304 in the log message. Just from that number being present, I am assuming that bdp ping has been enabled.
@NicoChenyt , can you confirm what kind of gRPC server we are using here? @ejona86's last message seems to suggest that grpc java is being used here.

This is weird. How is the window 64k. @yashykt, will C reduce its window size over time?
@ejona86 , why do you think that C has reduced the window size here? I believe what is happening here is that the php client has not yet received the ack for the initial window size of 4MB. Consequently, the acked window size (default of 64k) is smaller than the window size of 4MB which the client has advertised.

@NicoChenyt This would also mean that being able to configure the window size is not going to help avoid the log message that you are seeing. (Note that even though the message is being logged out the php client would still have accepted the message.)

I believe what is happening here is that the php client has not yet received the ack for the initial window size of 4MB

Ah, no SETTINGs ack would bring in the default 64k for INITIAL_WINDOW_SIZE. That seems fair, since nothing else is using 64k.

Sorry, it's my mistake.
@yashykt   we use swoole + php as gRPC server.
I set 'http_compression' as false in swoole. And when I set it as true it works well

@NicoChenyt I would caution you that simply enabling compression is not going to fix the issue at hand here. The actual issue is that the server is potentially reordering frames such that it uses the new window size before sending the settings ack frame.

This should be raised as an issue with the swoole implementation. Is this https://github.com/swoole/grpc what you are referring to?

If latency is bigger and the payload is larger, setting initial window size larger can lower the request time significantly.  That is what helped us when we had let's say 15 seconds timeout on whole request, and the destination server was in another continent, and payload was large.  The 64k window size caused the request to take like 60 seconds and more,  decreasing it was like few seconds (1GB ethernet link and send 20 MB for 60 seconds is insane)

If latency is bigger and the payload is larger, setting initial window size larger can lower the request time significantly.  That is what helped us when we had let's say 15 seconds timeout on whole request, and the destination server was in another continent, and payload was large.  The 64k window size caused the request to take like 60 seconds and more,  decreasing it was like few seconds (1GB ethernet link and send 20 MB for 60 seconds is insane)


Request following correction to clarify the difference between [End of service] and [End of support]

[Enter feedback here]
We would like to request following correction in document (A) and (B)to clarify the difference between [End of service] and [End of support] and the corresponding versions of each.
(A) https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/fin-ops/get-started/one-version#what-does-end-of-service-mean
(B) https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/migration-upgrade/versions-update-policy
Request for (A)
Please change [What does end of service mean?] section as follows. And add [What does end of support mean?] section as like follows.
What does end of service mean?
Microsoft won't provide any fixes to issues on versions that have reached their end of service(Version N-2 or older than Version N-2).
If you encounter an issue on a version that has reached its end of service, you must update to the latest update and then report the issue if it persists.
(Version that are being serviced)
Version N is the latest version
Version N-1 is one version older than N
End of service date of each version.
https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/fin-ops/get-started/public-preview-releases#targeted-release-schedule-dates-subject-to-change
What does end of support mean?
Microsoft will investigate or troubleshoot any issue that you encounter on a version that complies with one version update policy(which is Version N-3 or newer than Version N-3 ).
And Microsoft will not investigate or troubleshoot any issue that you encounter on a version that does not comply with one version update policy(which is Version N-4 or older than Version N-4 ).
(Example)
Version N-2: MS will investigate or trouble shoot
Version N-3: MS will investigate or trouble shoot
Version N-4: MS won’t investigate or trouble shoot
Request for (B)
Please remove this sentence [Microsoft also won't investigate or troubleshoot any issue that you encounter on a version that is older than three service updates.], because document (A) also has this sentence. Maintaining both documents is not efficient.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23fde63f-0f6f-b1a0-50c8-e1bf5f6a48c4
Version Independent ID: 59a1f734-87cb-f34c-afd5-9f14de877584
Content: One Version service updates FAQ - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/fin-ops/get-started/one-version.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

@YujiImaoka, thank you for your feedback.  I'll have our PMs take a look at this.


Update pom.xml

Update identity-api-server version.
Related PR

https://github.com/wso2/identity-api-server/pull/410

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3591763844

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3591763844
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3591763844

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3591763844
Status: success


UI Clipping when Uploading files to Mega Mess.

There is a clipping going on when I upload lots of files. Essentially, I can't give title & description for it.

@dagweg  Thanks for taking a look at. The thing is since the foundation of the ui is from shadcn , most of modal based ui do have a an overflow-hidden so that you wont get to see the thing when it goes out of the min-height, you can propose your own solution and i am happy to go through your changes


add tendermint gentx

Please make sure your node is up and running. Join Discord for help: https://discord.gg/QeJWCrE.


srrg2_proslam vs srrg_proslam speed

I see big difference in speed comparing srrg2_proslam and srrg_proslam - 40fps vs 60fps. Is that expected? Both were compiled without -march=native.

Hello!
Yes this is expected. The first version of srrg_proslam was designed in a end-to-end fashion and, hence, the implementation was overfitted to the VO problem. In this case, instead, the huge gain in flexibility requires is paid with a code overhead, which impacts on the fps (still above real-time).


Chat - +Emoji reaction button is not responding after creating thread to message - iOS

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
Send a message
Add an emoji reaction to the message
Press "Reply in thread" on the message
Go back
Long press/right-click the emoji reaction

Expected Result:
Emoji reaction picker should appear
Actual Result:
Button is not responding
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/8d2f84be-3fbc-4b62-b731-ffc1382273bb
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Reassigning another bug team member, I'm going OOO until Monday, July 10, and will take it back if it's still open by my return date.
Required action from the 🐛 team: I've run out of time and haven't tested this one yet. This needs testing to confirm if it's a bug and then assign the applicable labels. Thank you!

Hahahahaha I'm also OoO for the week (back July 10) so re-assigning this in the meantime 😂

I'm not able to reproduce this. Just tried on iOS and long-pressing the emoji reaction worked fine after creating the thread.

I appreciate your help!


131 palindrome partitioning golang

Files added -> 131-[Palindrome Partitioning]
language -> golang
Submission detail -> https://leetcode.com/submissions/detail/698121279/

Thanks, @GokhanCagritekin!


Unit testing example/functionality

Providing an example on how to unit test a bot would be useful. It might involve exposing some way to mock ApplicationContext.
So far, the only way to achieve testing is to define an inner function for every command and have that contain most of the functionality

Unit testing a Discord bot is something I tried time and time again. It always ended up in the realization that mocking the Discord API is an uphill battle.
I now believe that the approach you mention (inner function) in the only real working approach. Would you still want to have an example for that?

I think it could be useful - especially in terms of any calls to the methods of the context.
My main qualm is that having an inner function often isn't amazing for readability. One solution might be to conditionally expose the transformed function in the Command struct when #[cfg(test)] is enabled


(wixtoolset) Fix validation issues

Description

This PR fixes multiple invalid URLs in the nuspec, as mentioned in the valdation report
Motivation and Context

Validation should be expedited, because v3.14.0 is actually a security related release.
How Has this Been Tested?

N/A
Screenshot (if appropriate, usually isn't needed):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[ ] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review

@felfert thank you very much for fixing this up!

@gep13, @AdmiringWorm : What I don't understand:
At https://community.chocolatey.org/packages/wixtoolset/3.14.0#versionhistory i see a second validation error with the very same issues (as of today, 14:52 UTC)?!
Is this some upload/caching problem?


Fix latency spike during connection failures

Fix latency spike during connection failures
The issue was when a connection is not there, because a peer node is
down, we were queuing up the messages till they would timeout and fail
eventually. This would lead to higher overall average latency and much
higher 99th latencies. The solution is to not queue up messages and fail
the requests till there is a good connection

Drop the messages and respond with error immediately when a
connection is not available
Do the same when the connection is in a connecting state
Split the dnode_peer_conn into 2 functions to get the peer server
and then to get a connection to it
Mark the node as down after some failure attempts. Implement exponential backoff upto 10 secs to reconnect to peer

tests are failing :)


jruby support

is there a plan for jruby compatibility ?

It's not something I've thought about. I'm certainly not opposed to supporting jruby, but since I've never used it I'm not sure what would be involved.
Does it fail under jruby?

yeah, the requirement is ruby >= 2.0, i tried to run the test from the master branch and most of them fail. I used jruby 1.7.19 and <IP_ADDRESS>

Are most of the issues related to the Ruby 2.0 hash syntax?

jruby <IP_ADDRESS> is 2.2 compatible, so it shouldn't be that. http://jruby.org/2015/07/22/jruby-9-0-0-0.html

It might be wise to add jruby and rbx to the Travis build matrix but mark them as failable (that is, don't worry if it fails under them) to help move this forward


Update stable

Codecov Report

Merging #99 into stable will decrease coverage by 1.99%.
The diff coverage is 66.31%.

@@            Coverage Diff             @@
##           stable      #99      +/-   ##
==========================================
- Coverage   75.00%   73.00%   -2.00%
==========================================
  Files           8        9       +1
  Lines         312      363      +51
==========================================
+ Hits          234      265      +31
- Misses         63       79      +16
- Partials       15       19       +4

Impacted Files
Coverage Δ

conf/configuration.go
81.13% <0.00%> (ø)

server/server.go
100.00% <ø> (+20.58%)
:arrow_up:

content-service.go
44.08% <32.00%> (-4.45%)
:arrow_down:

content/content.go
84.84% <79.10%> (-5.26%)
:arrow_down:

content/errors.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc07ba...453d1b7. Read the comment docs.


Add a --json flag to version command

The current Prisma version command is supposed to be read by humans:
$ npx prisma version
@prisma/cli          : 2.0.0-beta.1
Current platform     : debian-openssl-1.1.x
Query Engine         : prisma 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at<EMAIL_ADDRESS>Introspection Engine : introspection-core 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at<EMAIL_ADDRESS>
There should be an additional --json flag, which returns the information above but as valid json:
$ npx prisma version --json
{
  "@prisma/cli": "2.0.0-beta.1",
  "current-platform": "debian-openssl-1.1.x",
  "query-engine": "prisma 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at /app/node_modules/@prisma/cli/query-engine-debian-openssl-1.1.x)",
  "migration-engine": "migration-engine-cli 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at /app/node_modules/@prisma/cli/migration-engine-debian-openssl-1.1.x)",
  "introspection-engine": "introspection-core 2accb9c7eacdc984874eaeb63377fe705dfd3203 (at /app/node_modules/@prisma/cli/introspection-engine-debian-openssl-1.1.x)"
}

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of @prisma/cli.
You can try it out with npm i -g @prisma/cli@alpha.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!


Fix TravisCI configuration

Fix the script chmod permissions that are not applicable when script is inline in .travis.yml.

Oops. Wrong base branch.


Make Bugzilla changes to support switching doc bugs to GitHub

Acceptance criteria

Bugzilla is no longer accepting new issues in the "Developer Documentation" product, and refers people to the GitHub repo.

Tasks

[ ] Submit an issue to BMO to request turning off new bug submission.
[ ] Create a PR for BMO to turn off new bug submission.
[ ] Verify that the change is live.

Submitted bug 1506723. Emma Humphries opened bug 1506725 for what to do with form.doc.


Feature Request: Capability to use .zip files as .yml file store.

Idea
Currently, the Unicorn Rainbow Filesystem Provider uses the windows file system to store files.
It would be great, if the provider could also read and write .yml files from/to .zip files.
User Story
I'd like use .zip files to store Unicorn serialized .yml files on production systems.

All Unicorn Configurations can choose whether to read their content from a .zip file or directly from the file system.
Any Unicorn Configuration that uses a zip file storage is read-only (by default).
Reserializing the content tree does not affect the .yml files in the .zip package.
Any Unicorn Configurations which store items in a physical folder can still be serialized as .yml.
This is helpful for content migration.

Concept
In a few words:

If you don't find a .yml file physically, look out for a .zip File containing that .yml file.

or

mount .yml files into tree as usual
mount .yml files contained in .zip files virtually into the tree.

f.e. if an item is serialized under C:\Projects\myproject\Unicorn\Feature\ModuleA\SomeLong\PathsWithin\ThatModule\MyItem.yml
then it's .yml contents can also be stored in Entry SomeLong\PathsWithin\ThatModule\MyItem.yml of a file named C:\Projects\myproject\Unicorn\Feature\ModuleA.zip.
Read only?
It would be ok if the .zip file storage is read-only, since we're mostly having issues with long paths on production systems where we just sync items into the database, not vice-versa. And if we re-sync from prod it's ok to use a pure .yml store.
Performance Impact
It also seems ok to me, that .zip file store could be a bit slower than direct file access, since it needs to read the .zip file and decompress the files. But that can be done with memory efficient "in-memory" Streams using the System.IO.Compression namespace offered by .NET Framework.
In the end, it might turn out faster to read a single file from a storage into memory and then process it in-memory, than querying the filesystem for thousands of small .yml files.
Related Issues
issue #27: long paths would be solved for most situations too.

While it probably will not be .zip files, I am actually currently working on a form of big-file implementation. Will also benefit Azure deployments immensely, to deal with a very few big files rather than 1000s of individual small files.

Nice to hear that some improvements are going to happen.
The advantage of using zip over "just inventing of another package binary format" is significant.
I've seen quite some products out in wild that use that kind of .zip file "magic" to save disk space and keep file handling easy. The Zip format itself offers a great way to create file bundles; you also can turn compression to "none", to save any CPU time "wasted" for compression, so there should not be much performance overhead left than "content dictionary management" (which you have to do anyway).
Another advantage is, that there are a lot of standard OS tools that can view and pack .zip files. So it's easy to handle, easy to bundle and offers you flexibility on how to bundle your features.
Direct serialization into .zip files isn't really the goal, because .yml file structure can be turned into .zip files in many other ways.
But directly injecting (read-only) .yml files stored in zip files into unicorn's file system provider is definitely a thing that could come in handy for solution deployments and content migration.
So far I've seen, Unicorn is using "some kind of tree structure" for files, so it should be easy to tweak the part that reads the .yml files to look out for "virtual .yml files" that may exist in .zip files.
Maybe I can invest some time to clone and try a proof-of-concept implementation myself.

It's important to keep in mind here; the concepts currently being worked on would be to allow some form of "redistribution" of the file assets related to a configuration. Something like verb=Deploy or so.
At the very core and foundation of Rainbow sits the original premise. The premise, the entire toolset is built upon. And that is, the change in Sitecore's original serialization format to the line-based YAML-like syntax which allows for easy tool-less merging, and git auto-merging.
Changing this into a native .zip format just isn't going to happen. Not as it's default file store. That would have to live in a fork of your own if that's what you're after. It would completely shift the foundation of what Rainbow is and wants to achieve.

I am also trying to pursue the same solution as proposed by @rbruelisauer - we have tons of tiny yaml files and theirs deployment on our production via MsDeploy takes up to an hour (looks like that's a problem of NTFS volume, mounted via NFS file storage, because sometimes it is rocket fast, especially on lower environments, where we have much faster deployment cadence).
So, it would be nice addition to put a zip file instead of unpacking tons of files and make Unicorn read from zip directly (mount it as FS and do regular import operations), while keeping regular serialization to separate files in order to  keep easy tool-less merging, and git auto-merging.

There are two things I am currently considering.

The ability to "bundle" a configuration or predicate into 1 yml file. The idea being, you do ?verb=Bundle and Unicorn will run through configurations and generate 1 big yaml file per configuration which can then be consumed at an upstream environment. These bundles would be read-only.

And the obvious one with the introduction of protobuf in 10.1; the ability to generate protobuf files based off Unicorn configurations. These would (obviously) again be read-only - but it would effectively completely remove the need to have Unicorn on anything other than the dev environment and Sync would no longer be required at all.

As for the specific question of zipping/unzipping, it might already be doable if you use the built-in powershell commandlets.

I like idea of big yaml read-only yaml file for better portability between versions.
Thanks for an idea about built-in powershell, but we are not exposing it to outside world; and still this will be the same time issues, but on the moment, when Unicorn is executed (unpacking time will be added before Unicorn execution and I suppose that they will be roughly the same)

If anyone is feeling adventurous, both the "big yaml" and "zipped yaml" could and should be implemented entirely by creating a new Rainbow.Storage.SerializationFileSystemDataStore. It's the one gateway between filesystem storage and the rest of the system.
For read-only, methods such as Save, MoveOrRenameItem can be ignored.

Finally, once again, consider the PowerShell commandlets. You could generate Sitecore packages at an earlier stage in your deployment process and send those upstream. PowerShell would not be needed to be active upstream, only in your dev environments.
https://github.com/SitecoreUnicorn/Unicorn/blob/master/src/Unicorn/PowerShell/NewUnicornItemSourceCommand.cs


"Search in" selector on Search page not user friendly

This "Search in..." selector functions in unintuitive way - I have looked at it many times and had no idea that selecting a community in it, gets it reloaded with different content to present next and next layers of structure in it !
First improvement would be to introduce a 2x spaces padding in front of every next level of hierarchy.
Better yet to have some filterable hierarchical selector, eg, :
https://www.jqueryscript.net/demo/Filterable-Tree-View-Plugin-with-jQuery-Tree-Filter/

The original idea was to show the scope as another facet, but search was one of the first features implemented for dspace 7 and at the time it wasn't easy to support that behavior on the rest side. Perhaps we can reevaluate that?

More context: https://wiki.lyrasis.org/display/DSPACE/Search+Mockup#SearchMockup-Scopeisjustanotherfacet/filter

I've flagged this as a usability issue for now.
I'm not against the idea of a scope facet, but that may not be an easy fix (as it requires REST updates as well)
Another possible solution here might be to simply find a way to better represent communities vs collections in that dropdown (whether via an icon or a different style or similar), or see if there's a way to implement a collapsible/expandable dropdown.  I agree though that it's not self-explanatory that to search within a known Collection you may need to first select its parent Community, at which point the collections of that community load into the dropdown, and the known Collection would appear.


Error if no openvex output

The Issue
The action raises an error in the event that Trivy does not find fixable vulnerabilities and Copa does not generate the Openvex output.
How to Reproduce
Test the patch action with the image docker.io/library/python:3.11.7-slim-bookworm, in this case the Copa Action fails with the following error:
chmod: cannot access './data/docker.io-library-python-3.11.7-slim-bookworm-openvex-report.json': No such file or directory
Error: Process completed with exit code 1.

related #499 to handle this on copa level too


Provide service-monitor and application-model, try 2

Reverts vespa-engine/vespa#3818

The first commit is a revert-revert of PR 3615.
The second adds fat jars to base installation.

FYI @gjoranv who approved the original PR.
@aressem has last touched the code this PR adds in the last commit.

👍

🤞


Add task to compile JSPs at build time

It should be possible to compile JSPs at build time so it isn't done at runtime on first request.

released in ci.ant 1.3


Use the new localization headers from WDL

TODO: Updating WDL pulls in HiDPI v2 support in WndSizer. There are still issues with that in SWS, so this pull request should not be merged until HiDPI v2 is fixed.

REAPER's language pack source code has been open sourced in WDL!
This commit replaces the old copies of localize.h and localize-import.h in favor of the latest version from WDL.
I haven't touched BuildLangpack.cpp because it diverges from WDL's original build_sample_langpack.cpp (for adding SWS-specific features).

:x: Build sws 290-master failed (commit https://github.com/reaper-oss/sws/commit/719d576c6e by @cfillion)

:white_check_mark: Build sws 292-master completed (commit https://github.com/reaper-oss/sws/commit/d4905c32d2 by @cfillion)

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=aarch64

build/sws-<IP_ADDRESS>-Linux-aarch64-wdl-localize-d4905c32.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x64

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-wdl-localize-d4905c32.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=x86_64

build/sws-<IP_ADDRESS>-Linux-x86_64-wdl-localize-d4905c32.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=armv7l

build/sws-<IP_ADDRESS>-Linux-armv7l-wdl-localize-d4905c32.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x86

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-wdl-localize-d4905c32.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=i686

build/sws-<IP_ADDRESS>-Linux-i686-wdl-localize-d4905c32.tar.xz


LINK-397 | Performance optimization

Description
Gzip JS files and serve them gzipped
Add script to analyze bundle size
Use React lazy load to reduce single file sizes
Replace sanitize-html with dompurify to decrease bundle size
Preload fonts
Compress landing page background image
Closes
LINK-397

I think this was already included in my review here:
https://github.com/City-of-Helsinki/linkedcomponents-ui/pull/43

This PR is already merged in #43


Save form state + misc changes

Draft PR for #7

Implemented form state for all form fields. When submitting form through "Create your CV" button, it logs the object representation to the browser console.
Also various bug fixes and smaller improvement to form handling (fixed lots of errors appearing in console due to invalid element nesting).


PE module: is_pe depends on PE Machine type being known, but there are additional types

The is_pe logic depends on the value at the machine type location in the PE header being in the list of machine types defined in the PE module. So if there is a PE with a machine type that isn't yet in YARA, YARA will incorrectly fail to detect the file as a PE.
This was mentioned in #231, and there are still other machine types that are not yet listed in the PE machine types enum (working on a PR).
The Microsoft documentation seems to be incomplete or out-of-date, and has at least two places in the docs with slightly different lists. Whether this field is technically required and exhaustive by the PE spec, there are new machine types that have been added or discovered, e.g. CHPEv2 (0x3a64)
I tested this by modifying a PE machine type field to the CHPEv2 machine which is not currently in the enum of machine types in yara.
The PE module fails to detect the file as a PE.
Expected: pe.is_pe evaluates to true on characteristics other than PE machine type; if the value found at the machine type location of the PE is not in the enum, but other conditions match a PE, then is_pe should evaluate to true.

I've done the same test with different results. I took a PE file and modified the machine type field and the module pe.is_pe field keeps being true. By reviewing the code I don't see that this field depends on the machine type.

Ah, I apologize - the issue exists in v4.1.3 but not the latest version
Best,


Add basic stripe information querying to the platform service

There is a need to query very basic information about the stripe from a common service.

Closed.  Provides not value at the moment.  May revisit at a later point.


Support the wirering of closures instead classes?

I'm not sure if this fits into the project's scope and if it's generally possible:
Instead of wiring classes, I like to wire/bind closures. This offers to provide the interface design within the constructor or even plain functions, without the knowledge of the implementation.
It is very lightweight.

Could you maybe provide an example with a use-case?

Yes, of course.
So, instead of using dependency Objects I like to define function pointers:
class Test(calcWorldPos: (Int, Int) => (Double, Double)) {
  val pos = calcWorldPos(10,200)
}

Hey @staeff777 !
Do you want to achieve something like this?
class Test(calcWorldPos: (Int, Int) => (Double, Double)) {
  val pos = calcWorldPos(10, 200)
}

object PosConversion {
  def screenToWorldPos(x: Int, y: Int): (Double, Double) = (0.0, 0.0)
}

val t = new Test(PosConversion.screenToWorldPos)

//this must be in scope in order to be considered as dependency to be used when wiring
val f: (Int, Int) => (Double, Double) = PosConversion.screenToWorldPos

val tWired = wire[Test]
tWired.pos mustBe (0.0, 0.0)

This looks good. I tried the code, changed tWired to a lazy val, the compiler / macro sais "Error:(16, 24) Found multiple values of type [(Int, Int) => (Double, Double)]: [List(get$$instance$$f, f)]
lazy val tWired = wire[Test]"
Maybe the overhead due to the in-scope requirement, makes this example not quite useful. (This might change, if wiring in combination with other dependency objects wants to be achieved.)
Its a general decision if one wants to give up the readability for convenience.

This error sounds like you had two objects of the same type in scope. Are
you shure that you have only added the 'lazy' word to the above example and
not accidently doubled a line or something?
Pozdrawiam,
Paweł Panasewicz
mail<EMAIL_ADDRESS>tel.: +48 516144229
wiadomość wysłana z telefonu
On 12 Apr 2017 22:48, "Stefan Kaufmann"<EMAIL_ADDRESS>wrote:
This looks good. I tried the code, changed tWired to a lazy val, the
compiler / macro sais "Error:(16, 24) Found multiple values of type [(Int,
Int) => (Double, Double)]: [List(get$$instance$$f, f)]
lazy val tWired = wire[Test]"
Maybe the overhead due to the in-scope requirement, makes this example not
quite useful. (This might change, if wiring in combination with other
dependency objects wants to be achieved.)
Its a general decision if one wants to give up the readability for
convenience.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/adamw/macwire/issues/118#issuecomment-293703043, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC1RuGZ2kVOBP9ihOUhe1JnAfs996hBMks5rvTiqgaJpZM4M5Q25
.

@staeff777 the error looks a bit suspicious ... could you paste an entire failing test which would demonstrate it?

You are right. It is working. I tried it in a Intellij Scala Workbook first. That was the problem.
it is also working with:
  def f = PosConversion.screenToWorldPos _


Support for Firebase Cloud Messaging in FlutterFire

Tracking issue.

iOS is done, Android is still in progress @goderbauer is owning.

MVP is done.  Just adding docs.

The plugin is ready for early adopters. It's live on pub https://pub.dartlang.org/packages/firebase_messaging.

@sethladd
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1013. Any further collaboration will be done there.


cmd/go: Go modules initialised by go1.21.1 cannot be built using go1.20.8

What version of Go are you using (go version)?

$ go version 1.21.1

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/enwei.soh/Library/Caches/go-build'
GOENV='/Users/enwei.soh/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/enwei.soh/gopath/pkg/mod'
GONOPROXY='none'
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/enwei.soh/gopath'
GOPRIVATE=''
GOPROXY='proxy.golang.org,direct'
GOROOT='/opt/homebrew/Cellar/go/1.21.1/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.21.1/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.1'
GCCGO='gccgo'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/40/90j35z011n14czs8pbg736rr0000gn/T/go-build3498449936=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

We are attempting to make builds for both current and previous Go language versions (1.21 and 1.20). However, this does not work for Go modules initialised by go1.21.1, or any go directive set to 1.21.1 in the go.mod file, as go1.20.8 does not recognise the go directive with a X.Y.Z format.

Run go mod init in an empty folder
add a dummy main file (e.g. https://go.dev/play/p/UPxh4-pRY1V)
Run GOTOOLCHAIN=go1.20.8 go build main.go

What did you expect to see?
main binary created.
What did you see instead?
go: errors parsing go.mod:
/Users/enwei.soh/gopath/src/testgo21/go.mod:3: invalid go version '1.21.1': must match format 1.23

This is working as designed.
To select the minimum go version using Go 1.21 or higher, you can use go get<EMAIL_ADDRESS>or similar.

Thanks for the response!
Just to clarify does that mean that moving forward:

If I want to build for the latest and previous go versions (e.g. go1.22 and go1.21), my Go modules will need to enforce a maximum go directive of the previous go version go1.21
Extending from the above point, my Go modules cannot use other modules as dependencies if they declare the go directive to be higher than the previous go version  go1.21 (as per discussion in #62409 )

Is this understanding correct?


Add number of units to the delay node (rate)

Add possibility to set the value for the rate unit.
Backward compatible, if the new nbRateUnits is not set, default to 1.
This way we can delay messages to 1 msg per X seconds/minutes/hours days instead of always 1.
Useful when interacting with API that has an uncommon rate limiting like 1req per 2 seconds.

Coverage increased (+0.002%) to 88.297% when pulling f8ff9b806af9c02ddb9c0bde64ae065ba8b43d32 on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

Coverage decreased (-0.1%) to 88.161% when pulling f8ff9b806af9c02ddb9c0bde64ae065ba8b43d32 on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

Is it really that hard to do the maths to translate 1 msg per two seconds into 30 msgs per minute ? (or 0.5 msg per second ?)

Darn, I should have checked the code better.
Well put this PR more as usability because for the code, yes, there is no difference. But semantically, when I read 30 msg per minute rate, I understand there could be 30 msg in the first second then the 31 is blocked for 59 secs.
@dceejay

When set to rate limit messages, they are spread across the configured time period. It can
also be set to discard any intermediate messages that arrive.

To me this wasn't clear ... then yeah, clearly more a usability PR than a feature PR

and I'm not actually against it - just testing the need.

For our Coursera course, the assignment requires a message rate to be reduced to 1 message every 5 seconds. A sufficient number of learners struggled with how to configure the Delay node (12/minute) that we had to provide hints in the assignment text.
So whilst the functionality is there, the UI could make it easier.

I would say this PR give more granularity to the settings of the delay.
For now, you couldn't set 1 msg per 7 seconds.

@dceejay I missed your question about the label.
If nbRateUnit > 1
limit X msg/X(s|m|h|d)
else
limit X msg/(s|m|h|d)

would certainly make 1 per 7 secs easier.

do you have a screen clip of how the new control looks, (and the label).
thanks

@dceejay Sure.
Editor

Node

can you shrink the actual units select width so the right side lines up  a bit more with the others ?(even though they don;t line up either :-)

@dceejay
Editor

Timed

Topic

Normal

Coverage increased (+0.002%) to 88.297% when pulling a429897d5da89b17ac82d8b9b6dd999fe1a84746 on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

@knolleary could second(s) be a good compromise ?

That would be acceptable to merge... but I reserve the right to do it properly later ;)

@knolleary I'm going to do it right, please don't accept the PR yet.

Coverage increased (+0.002%) to 88.297% when pulling 21de99f6223acb81c18427b350cf9fa36e6c5b93 on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

@knolleary here you go, dynamic pluralisation compatible with i18n

Coverage increased (+0.002%) to 88.297% when pulling c4cc00d6d4aeffa44c9c6bb1f0152547baa007ae on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

Coverage increased (+0.002%) to 88.297% when pulling c4cc00d6d4aeffa44c9c6bb1f0152547baa007ae on Belphemur:delay-rate-nb-units into e4c951984a45b33ffa65e1246efdab47066882b6 on node-red:master.

@Belphemur Hi ... if I now just try to deploy a standard 5 sec delay I get

I guess because nbrateUnits isn't set by default ???


find elements not working for iOS platform it wait for 40 sec

[debug] [XCUITestDriver@1a9e (5f06c4da)] Calling AppiumDriver.findElements() with args: ["xpath","//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]","5f06c4da-6fc1-486b-b694-909b33b49e47"]
[AppiumDriver@1acc] Plugins which can handle cmd 'findElements': element-wait
[AppiumDriver@1acc] Plugin element-wait is now handling cmd 'findElements'
[AppiumDriver@1acc] Executing default handling behavior for command 'findElements'
[debug] [XCUITestDriver@1a9e (5f06c4da)] Executing command 'findElements'
[debug] [XCUITestDriver@1a9e (5f06c4da)] Valid locator strategies for this request: xpath, id, name, class name, -ios predicate string, -ios class chain, accessibility id, css selector
[debug] [XCUITestDriver@1a9e (5f06c4da)] Waiting up to 40000 ms for condition
[debug] [XCUITestDriver@1a9e (5f06c4da)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@1a9e (5f06c4da)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/BF10DD05-C5BF-413B-8889-FF84AB42A317/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@1a9e (5f06c4da)] Got response with status 200: {"value":[],"sessionId":"BF10DD05-C5BF-413B-8889-FF84AB42A317"}
[debug] [XCUITestDriver@1a9e (5f06c4da)] Waited for 547 ms so far
[debug] [XCUITestDriver@1a9e (5f06c4da)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@1a9e (5f06c4da)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/BF10DD05-C5BF-413B-8889-FF84AB42A317/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@1a9e (5f06c4da)] Got response with status 200: {"value":[],"sessionId":"BF10DD05-C5BF-413B-8889-FF84AB42A317"}
[debug] [XCUITestDriver@1a9e (5f06c4da)] Waited for 1592 ms so far
Appium v - 2.0.0-beta.65<EMAIL_ADDRESS><EMAIL_ADDRESS>

What is the error? Please give full logs

when we are using iOS predicate & iOS class chain locator to find element or find elements then wait plugin is not working @saikrishna321

Same error after updating to new version - Appium v - 2.0.0-beta.66<EMAIL_ADDRESS><EMAIL_ADDRESS>[debug] [XCUITestDriver@9d70 (f47cc5ae)] Calling AppiumDriver.findElement() with args: ["xpath","//XCUIElementTypeButton[contains(@name,'Don') and contains(@name,'Allow')]","f47cc5ae-d8d0-46f6-ab22-74b6f4a51965"]
[AppiumDriver@85a4] Plugins which can handle cmd 'findElement': element-wait
[AppiumDriver@85a4] Plugin element-wait is now handling cmd 'findElement'
[wait-plugin] Timeout properties set for session f47cc5ae-d8d0-46f6-ab22-74b6f4a51965 is {"timeout":10000,"intervalBetweenAttempts":500,"overrideTimeout":false} ms
Session INfor XCUITest
[AppiumDriver@85a4] Command 'findElement' was not handled by the following behaviours or plugins, even though they were registered to handle it: ["default"]. The command was handled by these: ["element-wait"].
[debug] [XCUITestDriver@9d70 (f47cc5ae)] Encountered internal error running command: TypeError: Cannot read properties of undefined (reading 'jwproxy')
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at sessionInfo (/Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/element.js:141:52)
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at /Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/element.js:33:36
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at Generator.next ()
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at /Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/element.js:8:71
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at new Promise ()
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at __awaiter (/Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/element.js:4:12)
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at find (/Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/element.js:22:12)
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at WaitCommandPlugin. (/Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/plugin.js:36:38)
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at Generator.next ()
[debug] [XCUITestDriver@9d70 (f47cc5ae)]     at /Users/sushilpawar/.appium/node_modules/appium-wait-plugin/lib/plugin.js:8:71

Hi @saikrishna321
Sorry for the delay ..
While using find elements in framework again it find elements till 40 seconds
[HTTP] {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Calling AppiumDriver.findElements() with args: ["xpath","//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]","2b09d1e1-1b3f-42d3-bc5f-8e20909aac16"]
[AppiumDriver@2b6d] Plugins which can handle cmd 'findElements': element-wait
[AppiumDriver@2b6d] Plugin element-wait is now handling cmd 'findElements'
[AppiumDriver@2b6d] Executing default handling behavior for command 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Executing command 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Valid locator strategies for this request: xpath, id, name, class name, -ios predicate string, -ios class chain, accessibility id, css selector
[debug] [XCUITestDriver@d475 (2b09d1e1)] Waiting up to 40000 ms for condition
[debug] [XCUITestDriver@d475 (2b09d1e1)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Got response with status 200: {"value":[],"sessionId":"89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Waited for 470 ms so far
[debug] [XCUITestDriver@d475 (2b09d1e1)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Got response with status 200: {"value":[],"sessionId":"89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Waited for 1403 ms so far
[debug] [XCUITestDriver@d475 (2b09d1e1)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Got response with status 200: {"value":[],"sessionId":"89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Waited for 2356 ms so far
[debug] [XCUITestDriver@d475 (2b09d1e1)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Got response with status 200: {"value":[],"sessionId":"89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4"}
[debug] [XCUITestDriver@d475 (2b09d1e1)] Waited for 3144 ms so far
[debug] [XCUITestDriver@d475 (2b09d1e1)] Matched '/elements' to command name 'findElements'
[debug] [XCUITestDriver@d475 (2b09d1e1)] Proxying [POST /elements] to [POST http://<IP_ADDRESS>:8100/session/89AAE85B-1E15-43F3-A1FA-48B6E31BC8E4/elements] with body: {"using":"xpath","value":"//XCUIElementTypeButton[contains(@name,'Heart') and contains(@name,'selected')]"}
Appium v - 2.0.0-beta.66<EMAIL_ADDRESS><EMAIL_ADDRESS>

@sushilpawar12 This is not full logs. Please provide full server logs as gist

Hi @saikrishna321
sorry for the delay . In logger file you can find text - "Please check below logs for reference" where below logs will be helpfull.
op.txt

@sushilpawar12 hard to read these logs. Please provide as gist


ci(gh-actions): add stale PR workflow

:tada: This PR is included in version 3.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Separate disk related functions in CClaimTrieDb

This is a rebased and squashed version of @bvbfan 's CClaimTrieDb commits which separates disk related function from the claimtrie into its own class (from https://github.com/lbryio/lbrycrd/pull/160)
I removed here commits which renamed CClaimTrieCache and nCurrentHeight, as well as the new management of CClaimTrieNode, they will be put into seperate PR's.
This PR is not downgrade compatible (once you upgrade to this commit, you will not be able to downgrade to previous versions without wiping your claim database) and should be accompanied by a version bump.

Is there some stopper to merge my changes on master? I plan to rebase my last changes for wed meet.

Is there some stopper to merge my changes on master? I plan to rebase my last changes for wed meet.

This is under review.  Feel free to rebase, but it won't be merged (i.e. don't merge it) until review is complete.

There is no problem to be reviewed but let be conceptional rather than a silly comments. I mean when you know better way to do it, describe it how to do.

There is no problem to be reviewed but let be conceptional rather than a silly comments. I mean when you know better way to do it, describe it how to do.

There is no problem to be reviewed but let be conceptional rather than a silly comments. I mean when you know better way to do it, describe it how to do.

There is no problem to be reviewed but let be conceptional rather than a silly comments. I mean when you know better way to do it, describe it how to do.

What silly comment(s)?  I'm mostly asking questions on or pointing out things I don't know, or don't look right to me.  As you said, if this has already been reviewed despite my concerns, it'll be merged anyway.
I'm only reviewing it because I care about this code and wonder about future maintenance.  This work was not assigned to me, so I don't know a better way to do all of it (and haven't thought about it as much as you and/or @kaykurokawa).  If you've exhausted all alternative implementations and arrived here, it'll be merged and this is all disregarded anyway.  Since I don't know, I've added my 2 cents.  I don't know if that provides any value though.  2 "lbrynaut tokens" worth of input may not be worth much :-)

There is no problem to be reviewed but let be conceptional rather than a silly comments. I mean when you know better way to do it, describe it how to do.

What silly comment(s)?  I'm mostly asking questions on or pointing out things I don't know, or don't look right to me.  As you said, if this has already been reviewed despite my concerns, it'll be merged anyway.
I'm only reviewing it because I care about this code and wonder about future maintenance.  This work was not assigned to me, so I don't know a better way to do all of it (and haven't thought about it as much as you and/or @kaykurokawa).  If you've exhausted all alternative implementations and arrived here, it'll be merged and this is all disregarded anyway.  Since I don't know, I've added my 2 cents.  I don't know if that provides any value though.  2 "lbrynaut tokens" worth of input may not be worth much :-)

Only for clarification -> "Including a cpp file from another means incorrect/bad organization. That is what I meant by broken."  This not broke anything and it's not forbidden or anything else.

Only for clarification -> "Including a cpp file from another means incorrect/bad organization. That is what I meant by broken."  This not broke anything and it's not forbidden or anything else.

Of course it's not forbidden, but that doesn't mean that it's common or required either.  In fact, it would be a first for this entire code base, which is why it stands out.

There is not problem to be implemented in other way, but i'm against pattern to described to be bad by default. About me, only better pattern can make other to be marked as bad.

There is not problem to be implemented in other way, but i'm against pattern to described to be bad by default. About me, only better pattern can make other to be marked as bad.

Ok.  I don't agree though.  Most times I've seen cpp files included from others was due to bad organization and/or laziness.  Similar to "goto" statements.  There's nothing wrong with them, and often you can achieve a lot using them.  But I think they are also bad organizationally.  What I mean by organization in this sense affects readability and comprehension.  There are many ways to implement things that hide other issues (such as linker problems, or basic error checking), but that doesn't mean they're all 'good' to use, even if allowed.  In most cases, a slight re-organization can improve readability/flow, which also helps comprehension, which leads to better maintenance, etc.
We may not agree on style, and I'm ok with that.  But since we're both working on this code and this is not a common use for the project, I hesitate to introduce it just because we can.  My opinion on introducing this is "it's broken", meaning it absolutely should not be introduced.  But like I said, my token input may be worthless ;-)

As i say before this is not a regular cpp file, it's like a template implementation file, since i'm not prefer to separate cpp and impl files i've made a trick to combine them.

I think the linker problem where we have to include "claimtriedb.cpp" in claimtrie.cpp is just an unfortunate problem when working with template classes in C++. In one of my past project we put implementations in the header file to get around this. I believe you can also use forward declaration (not sure if that is the right term , see last solution here: http://www.cs.technion.ac.il/users/yechiel/c++-faq/separate-template-class-defn-from-decl.html ) but that looks like the worst solution in this case due to the number of functions and possible types.
So I think in this case, the solution chosen here seems fine given that the other two solutions are equally bad.
The point regarding the new hashing features @lbrynaut brought up is good. Maybe it was a bad idea to change the original simple hashing function (where each type was assigned a unique letter) to this one , considering that we could have avoided a database migration and the code would have been simpler. This is not @bvbvfan 's fault , I said that it would be OK to do this but in hindsight this was not the best idea (I can take responsibility and fix this ).

I can propose a fix that will not introduce migration nor cpp include. It can be done by template implicit instantiation of every function like this:
template<> inline char hashType<std::string, CClaimTrieNode>() {     return 'n'; } template CClaimTrieDb::getQueueRow<std::string, CClaimTrieNode>(); // explicit instantiation
This can be done in claimtrie.db so it will not needed to be include anywhere, when we add new type new explicit instantiation should be provided. I can do that on master and make a new RR if it accept by all of us.

I think the above new solution looks good to me

So I think in this case, the solution chosen here seems fine given that the other two solutions are equally bad.

I'm aware of the issue, but if we really have to go this route, I think it should be made clear in a more standard way.  For example, under the include dir having an impl directory with the implementation defined in .ipp files makes it clear what's going on at least.  It's true it's more or less the same thing, but projects like boost chose to do it that way, and a lot of projects have followed with good reason (a de facto standard).
That said, I still don't like the idea of needing these methods in the first place and would prefer to see the solution that does not require the new types at all nor the DB migration.  @kaykurokawa The one way migration makes me nervous because usually migrations are done for underlying reasons other than a migration for the sake of it.  Second, if the migration simplified the code or allowed us to eliminate unnecessary code, I'd be all on board -- but instead this is the opposite, taking on responsibility for more untested code that adds complexity.  If you see the need to go this route, let me know what's on your mind (I still think I'm missing some background on this).  Otherwise, I want to avoid all unnecessary code to avoid the future maintenance costs.

There is no migrations or cpp/ipp include, see better. The worst case to me is separate directory with ipp files in.

I can propose a fix that will not introduce migration nor cpp include. It can be done by template implicit instantiation of every function like this:

I'd like to review this solution as a PR.

I push it in this branch, now it's able for review.

@bvbfan I discussed this briefly with @kaykurokawa and here is where I'm at with it:

This is hard to review because of all of the unnecessary style changes (as mentioned earlier, if this comes from clang-format, save formatting for a separate commit/PR, otherwise, this would benefit from reverting those).
I think this an over-engineered solution for the issue at hand, and I'm of the opinion that this is the kind of project that requires minimalistic changes in preference to large sweeping ones to accomplish a particular goal.  I'm assuming that you and @kaykurokawa had agreed on some scope of this work, so while it may exactly address what he had in mind, it's not for me to decide.
I see no urgency in merging this for any reason (functionally, etc).  While a re-organization would be nice, I don't see this as positively better than existing.  There's some benefit to breaking up the code into separate files, and some benefit to templatizing some common functionality, but as-is, this PR doesn't strike me as code we need or want to merge right now.
Instead of going around @kaykurokawa and re-defining the task or asking you to start over and simplify the scope, I'm noting that right now I'm focused on the normalization fork and the upstream code changes, so I'm punting on this and will revisit later if @kaykurokawa requests it -- otherwise, it's in his hands at the moment.

If anyone else thinks this work is urgently needed and @kaykurokawa is unable to add the required input, let me know and I'll re-prioritize.

For me, existing code base is redundant and it contains duplicate code fragments, RR-s, not only this, solve issues, later ones memory leaks. So after all it's not an over-engineering at all, furthermore it simplifies all logic.

Rebase to master, @kaykurokawa if you have a comments or advice please share them otherwise it ready to go in.

Hey, this seems to have some problem syncing, seems to be a new problem that was not present in previous iterations of this PR.
After CClaimTrie::WriteToDisk() is called to write buffers to disk ..
this problem occurs:
2018-08-18 22:25:59 incrementBlock: nCurrentHeight (before increment): 33913
2018-08-18 22:25:59 ERROR: ConnectBlock() : the merkle root of the claim trie does not match (actual=0000000000000000000000000000000000000000000000000000000000000001 vs block=c4827743b4a73ca1b35275805f0564b1fe6d294ea316199173d9039f41fa3f40)
2018-08-18 22:25:59 Misbehaving: <IP_ADDRESS>:9246 (0 -> 100) BAN THRESHOLD EXCEEDE
It seems like the merkle root of the claim trie gets calculated the same as an empty trie after CClaimTrie::WriteToDisk() is called.

You tests with some mock data, unit tests pass when i test them, maybe we should update them.

Can you provide steps to reproduce?

So i found what you mean i think, so
call WriteToDisk()
then not call ReadFromDisk
lead to not finding claims
I'll investigate if mean that.

I found the problem
`diff --git a/src/claimtrie.cpp b/src/claimtrie.cpp
index e6d7250f..305455c2 100644
--- a/src/claimtrie.cpp
+++ b/src/claimtrie.cpp
@@ -630,7 +630,8 @@ bool CClaimTrie::WriteToDisk()
uint32_t num_claims = pNode ? pNode->claims.size() : 0;
LogPrintf("%s: Writing %s to disk with %d claims\n", func, itcache->first, num_claims);
if (pNode) {

       db.updateQueueRow(itcache->first, *pNode);

       CClaimTrieNode copy(*pNode);

       db.updateQueueRow(itcache->first, copy);

} else {
CClaimTrieNode emptyNode;
db.updateQueueRow(itcache->first, emptyNode);`
void CClaimTrieDb::updateQueueRow makes a swap on IN parameter (i don't want to change this behavior but it's not used on node) witch cause root to became empty, so with patch above issue is fixed and ready for land.

Fix clang issue.

Rebase to resolve conflicts.

@lbrynaut has requested that we hold on this until his upstream merge changes come in.


Try to coerce deps names for non-identifier keys

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md
[x] update .d.ts typings

@lundibundi now we have spinalToCamel in metautil 3.5.17

@tshemsedinov updated.

Landed in https://github.com/metarhia/impress/commit/5bed24a956f75c046a696890a1e11659c960a1bc


Line parameters have no effect

Configured with:
line = {
        line = "-",
        line_start = "+",
        line_end = "+",
        title_left = "[",
        title_right = "]",
},

Executing :CBllline and/or :CBccline still creates line like this:
-- ── Yes, just like this one ────────────────────────────────────────────────────

Interestingly, borders{} works as expected and :CBclbox correctly uses chosen set of characters.

Thank you, I'll look into it!

The problem is in your config: replace line = { with lines = { :)

Same problem at the Readme too line = ... whereas it should be line(s) = ... .
Side Note: Ahh... it got Me headaches xD

Oh god, sorry about that :sweat:, README and doc fixed, thanks!


Introduce logic to initialize NodeTemplate in worker resource

How to categorize this PR?

/area TODO
/kind TODO
What this PR does / why we need it:
This PR enhances the logic to deal with the problem described in this PR. Now before initializing the nodeTemplate from cloudprofile, the gardenlet will look for it in the worker resource spec for the respective worker pool . If not found then only it'll move to cloudprofile.
Which issue(s) this PR fixes:
Fixes #4948
Special notes for your reviewer:
The logic deals with cases where unsuccessful reconciliations were happening . However the 2 possible cases on which it'll still throw the error are :

The cloudprofile doesn't have the machine info when the shoot was created (since no worker resource with nodeTemplate exists)
Reconciliation of old shoots will be unsuccessful if cloudprofile doesn't have machine info , because for old shoots even the worker resource won't have the nodeTemplate

The alternate method of making nodeTemplate=nil wouldn't suffice imo because then CA will have to keep a catalogue of machine info and catalogues are what we are trying to remove by scale-from-zero.
Release note:

Node resource capacity (cpu, gpu, memory) are now filled in the `extensionsv1alpha1.Worker` resource under `spec.pools[].nodeTemplate.capacity` from the `CloudProfile` for the corresponding machine type. These resources will be carried to the `MachineClass` and will later be used by cluster-autoscaler for scale-from-zero.

/invite @AxiomSamarth


Write a C++ program to print fibonacci series without recursion

Description
Write a C++ program to print fibonacci series without recursion
Input  : 5
Output : 0 1 1 2 3

How to contribute

Save the solution in PrintFibonacciSeriesWithoutRecursion.cpp file
Add PrintFibonacciSeriesWithoutRecursion.cpp file in print-fibonacci-series-without-recursion folder

!assign

!assign

Hey @Mohitt0, this issue is already assigned to @YaSh8202 !!!
Please choose another issue.
Thanks for your interest in contributing to this project.


Ovn k kind updates

This PR works to close #703
It fixes the makefile target make clusters using=ovn and then ensures we use the work upstream in ovn-k. This cannot be merged until https://github.com/ovn-org/ovn-kubernetes/pull/2747 goes in
Depends on https://github.com/ovn-org/ovn-kubernetes/pull/2747

Still waiting on https://github.com/ovn-org/ovn-kubernetes/pull/2747 to merge :(

Note: I still need to update the git submodule to point to upstream ovn-k rather than the submariner fork here.

Note: I still need to update the git submodule to point to upstream ovn-k rather than the submariner fork here.

If we can use upstream ovn-k directly now, do we still need a submodule?

Well we still need to source the ovn-k kind script @skitt, what's the "most official" way to do that? It's either a submodule or download the script manually every time we need it.

++ I agree will implement this here,  thanks!

Huh @skitt That breaks things because now we go and call ./clusters.sh before populating the SETTINGS var  :( .
We have a bit of a circular dependency going on here, why can't we just move
ifneq (,$(filter ovn,$(_using)))
SETTINGS ?= $(DAPPER_SOURCE)/.shipyard.e2e.ovn.yml
else
SETTINGS ?= $(DAPPER_SOURCE)/.shipyard.e2e.yml
endif

to makefile.inc, since that's where we actually call the clusters script?

The [Deploy (ovn)] Job will fail until the dependent PR merges

Dependent OVN-K PR has merged!

So in the OVN test the cluster now deploys successfully, however the connectivity tests still fail, this should be fixed by https://github.com/submariner-io/submariner/pull/1689

I see the dependent PR is merged. Do we expect make deploy using=ovn to work at this point? It seems to be consistently failing.
I see you mention this getting make clusters using=ovn working. We could add a test for that here if you think that would be helpful: https://github.com/submariner-io/shipyard/blob/devel/.github/workflows/scripts.yml#L19

So I believe the deployment is coming up correctly @dfarrell07 However the connection test is failing
Max attempts reached, failed to run 'test_connection netshoot-664cc4c98b-56nb8 <IP_ADDRESS>'!

This test will not pass until https://github.com/submariner-io/submariner/pull/1689 has merged.

I see you mention this getting make clusters using=ovn working. We could add a test for that here if you think that would be helpful: https://github.com/submariner-io/shipyard/blob/devel/.github/workflows/scripts.yml#L19

100% I'll look at making a test for that, verifying that the actual CNI in use is OVN-L not weave

This test will not pass until https://github.com/submariner-io/submariner/pull/1689 has merged.

Okay thanks for clarifying, I marked this PR as dependent on that one for clarity, hope that's right.

So @dfarrell07 sorry let me try and clarify...It's a bit of a circular dependency here, we actually need this PR to land before https://github.com/submariner-io/submariner/pull/1689 because it allows the submariner+ovn-K kind setup to come up with new OVN-K images, those of which are required for https://github.com/submariner-io/submariner/pull/1689's CI to pass

Okay thanks for clarifying, so it seems like we need to have both ready to merge before merging either.

Okay thanks for clarifying! So it seems like we need to have both ready to merge before merging either?

For CI to be green everywhere yes.... however I think the only reason CI is even passing now with OVN is because it's running at an old/fixed ovn-k version so it's kind of like a false positive since on real OCP+ovn-k clusters it won't work.
I don't know what the protocol is in the submariner community is on this but I'd rather see this get merged first to ensure that CI looks good on https://github.com/submariner-io/submariner/pull/1689.  Maybe we make the OVN job not required until 1689 lands to allow this to go in first, or something along those lines?

Further proof of the above issue -> https://github.com/submariner-io/submariner/pull/1689#issuecomment-1090887976

@astoycos Okay that makes sense, agreed. Let's get this in and let the CI correctly fail, make the OVN jobs not-required.
@tpantelis That's possible with the GitHub required job config knobs, right? Basically the params to the job count as part of the job name we can filter on?
@mkolesnik Please re-review :pray:

IMHO we should make this not-required here and the main repo, merge, and then review/merge the fix in the main repo. Need help from an Owner.
Thanks @astoycos! :partying_face:


Bins should be left installed to bin, not to "Server"

Fine to let them overlap, that's what they do on Linux - it works by design. A bit surprised it works fine the way it is right now, actually - I guess that means my fix to not require the containing directory to be named bin worked :D but it makes it harder to use - for instance, CMake won't be able to find osvr_json_to_c

Moved binaries from "Server" to "bin" - https://github.com/OSVR/OSVR-win-installer/commit/118611a134a4dc6b5ff09d7b03fbb333756ffdd5