Error while creating build definition: The pipeline is not valid.

Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '584bcff2-3353-4f11-872b-6ba01267a972'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 6., job 'Phase_1', step ''.) Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '584bcff2-3353-4f11-872b-6ba01267a972'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 6., job 'Phase_1', step ''.)
Tailwind Traders DevOps Project
AB#3941

@bharath199406 If you are running Demo Generator on a brand new organization, please enable the Third-party application access via OAuth under  Organization Setting >> Policies

Run the demo generator again and try to install the extension needed by the template.
Thanks


doc: fix skeleton text

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests
[ ] Other

Why is it needed?
Skeleton currently has the text from separator.
Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

I have read the CLA Document and I hereby sign the CLA

recheck

Awesome stuff thomas :) . Merging.

Oh yes thanks @thomaspeissl 🫶


Issues with non-lua operators on properties of objects

Operators such as '+=', '++', etc... can be broken easily right now.
Example 1:
declare function foo(): number;
declare const a: number[];
a[foo()]++;

=>
a[(foo())+1] = (a[(foo())+1]+1);

Here foo() will be called multiple times, producing possibly different values each time or having other undesired side-effects.
Example 2:
declare function bar(): number[];
let f = bar()[0]++;

=>
local f = (function()
    local __originalValuebar()[(0)+1]0 = bar()[(0)+1];
    bar()[(0)+1] = (bar()[(0)+1]+1);
    return __originalValuebar()[(0)+1]0
end
)();

This one won't even compile in lua.
These kinds of issues could be solved by detecting if the value being operated on is a property and caching the object and index parts before performing the operation. This could be wrapped in specialized polyfill functions like the ternary operator is:
function __TS__PropertyPostInc(o, i)
    local original = o[i]
    o[i] = o[i] + 1
    return original
end

--Example 1
__TS__PropertyPostInc(a, foo())

--Example 2
local f = __TS__PropertyPostInc(bar(), 0)

Looks like a tricky issue indeed. We would have to polyfill all(?) unary and binary assignment operators to have this work properly? I feel like it might be nicer to find an inline solution if possible, but I will have to think about this for a bit.

Yes, all of them would have to be covered. Using polyfills is more efficient however, since the inline solution requires generating a temp lambda every time (at least for expressions).

Of course, to be clear, it is possible to do this inline as well (just less efficient). I definitely can understand the desire to avoid excessive polyfills.
(function(o, i) local original = o[i]; o[i] = original + 1; return original)(a, foo())

local f = (function(o, i) local original = o[i]; o[i] = original + 1; return original)(bar(), 0)

why do you need that extra function call? couldnt we just use:
a[foo()]++;

local ___propertyIndex1 = foo(); a[___propertyIndex1 ] = a[___propertyIndex1 1] + 1;

and to make let f = bar()[0]++; work extend it further:
local ___propertyIndex1 =0;
local ___temp1 = bar();
___temp1 [___propertyIndex1 ] = ___temp1 [___propertyIndex1] + 1;

But thats pretty ugly so it might be petter to polyfill.
In either case we should probably add a compile time warning about shorthand assignements/operators affecting performance.

You're right, the first example doesn't require a function. The second example currently compiles to a function to allow it to be evaluated as an expression (to avoid issues in different scenarios: see #162 discussion). I assume it would be best to keep it that way.

Well, poylfilling is fine wiht me than, at least for now. If we can think of a better/faster inline solution we can still add it later. Maybe we can check if there is a function call inside the shorthand operation and only polyfill in that case....
But we should defintly add a warning because a polyfilll will make a simple increment pretty expensive.

A function call check wouldn't work in all cases is setters/getters are implemented via metatables as proposed in #206 - there'd be no way to know if a simple property access was actually calling a function or not.
I wouldn't argue against a warning, although it would be good to be able to disable it (maybe via a decorator?).

I think using polyfills would probably be 'easiest' for now. Better than having incorrect behavior for sure. (ignoring the debate that using a function that modifies state as index is probably a terrible name)

ignoring the debate that using a function that modifies state as index is probably a terrible name

Oh, it's definitely terrible. But I've seen it in enough code to know it should probably be accounted for.
I suggest using an inline solution for statements and a polyfill for expressions. That would be most efficient for each scenario without breaking things. I suspect using these operators as expressions is far less common so that would limit the polyfill usage a lot.


[ISSUE #2447] Extra 'consumeMessage return null' logs

What is the purpose of the change
issue #2447
Brief changelog
Modify consumeMessage return null... log output
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.02%) to 51.579% when pulling 16490b88e6e8c917269a043c58b1e306abd6682b on Popo-lth:issues/2447 into c286600ca14a4b45eaf12ae76184165b9aee791a on apache:develop.

Codecov Report

Merging #2448 (16490b8) into develop (c286600) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2448      +/-   ##
=============================================
+ Coverage      45.75%   45.79%   +0.03%
- Complexity      4298     4302       +4
=============================================
  Files            547      547
  Lines          36009    36009
  Branches        4772     4772
=============================================
+ Hits           16477    16491      +14
+ Misses         17471    17463       -8
+ Partials        2061     2055       -6

Impacted Files
Coverage Δ
Complexity Δ

...pl/consumer/ConsumeMessageConcurrentlyService.java
43.68% <100.00%> (ø)
10.00 <0.00> (ø)

...ain/java/org/apache/rocketmq/test/util/MQWait.java
48.64% <0.00%> (-5.41%)
3.00% <0.00%> (-1.00%)

...nt/impl/consumer/ConsumeMessageOrderlyService.java
38.98% <0.00%> (-3.62%)
16.00% <0.00%> (ø%)

...he/rocketmq/client/impl/consumer/ProcessQueue.java
58.60% <0.00%> (-1.40%)
31.00% <0.00%> (-1.00%)

.../rocketmq/client/impl/consumer/PullAPIWrapper.java
50.42% <0.00%> (-0.86%)
12.00% <0.00%> (-1.00%)

...a/org/apache/rocketmq/store/StoreStatsService.java
28.85% <0.00%> (-0.66%)
25.00% <0.00%> (-1.00%)

...ain/java/org/apache/rocketmq/store/MappedFile.java
50.18% <0.00%> (-0.37%)
50.00% <0.00%> (-1.00%)

...org/apache/rocketmq/store/DefaultMessageStore.java
55.39% <0.00%> (-0.30%)
106.00% <0.00%> (-1.00%)

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (ø)
30.00% <0.00%> (ø%)

...n/java/org/apache/rocketmq/store/ha/HAService.java
67.88% <0.00%> (+0.33%)
18.00% <0.00%> (ø%)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c286600...16490b8. Read the comment docs.


[MCLEAN-116] Use default Log interface

Following this checklist to help us incorporate your
contribution quickly and easily:

[x] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without
pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [MCLEAN-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MCLEAN-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
[x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[ ] In any other case, please file an Apache Individual Contributor License Agreement.

Provided commit message for squashing
[MCLEAN-116] Use default Log interface
Submitted by: Matthias Bünger

The logging interface of the Cleaner class was not able to log exceptions in a suitable way.
So it was replaced by the default logging interface provided by the AbstractMojo class.

As the AbstractMojo always returns a log instance (therefore never null) the null checks were removed and the same Systemlogger was used in the tests.

As changes are more than 20 lines I will file the icla later the day.

Additional note aside the commit message: Spotless reformatted a lot in the Cleaner file


Ops: design and implement an improved container management and CI/CD system

Task Description
The easiest way for us to get a foot in the door w CICD and container management with Coinstac's unique requirements is to have an EC2 instance that manages it itself via compose.
Task Notes

create a v large EC2 instance

500gb, 8ish cores, 32gb of ram (maybe more?)
if theres a ec2 image with docker already ready to go, otherwise id say latest debian/ubuntu is fine

we need to decide where this will be managed, the Trends cloud (us) or Yurij (GSU), costs probably differ significantly

Hey @rssk! I'm starting to position myself to work on this task. Any updates I should be aware of?
I'm thinking of exercising a mini best practice software development lifecycle as I work through this task.  Besides informing and quality checking my plans, it will also help teach others how our system works.

As I architect, I'll make some of the necessary technical decisions like any subtleties around how the containers will be managed and the hardware requirements above. I can also include some total cost analysis between alternative architectures like deciding where to host the services.

Yeah definitely, my first stab at it was to have coinstac manage the
containers like has via the docker daemon on a ‘hosting’ ec2 , which is
basic but has the advantage of requiring no code or maybe very minimal code
changes. However i am open to other management solutions, the issue is due
to the connectivity or really the data sharing/volume mounting needed
between the pipeline and the container it interacts with, this could be
reasonably complicated
On Thu, Jun 23, 2022 at 4:35 PM Paul Prae @.***> wrote:

As I architect, I'll make some of the necessary technical decisions like
any subtleties around how the containers will be managed and the hardware
requirements above. I can also include some total cost analysis between
alternative architectures like deciding where to host the services.
—
Reply to this email directly, view it on GitHub
https://github.com/trendscenter/coinstac/issues/1329#issuecomment-1164849623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIVUTKKRAPFHHXCMHQD7YDVQTDC3ANCNFSM5WFKUHTQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Pain points I'd like to address as I explore a few architectural options here:

Decouple our containerized services from the rest of the application (what I see as the main task).
Decouple storage. I need to learn a little more about how each of the these containerized services work, but I'm hoping with little changes I can make the underlying storage more elastic. If this sounds like a big ask, know I don't think it is if we find it useful.
Benchmark costs between our options. Not just between onprem and cloud, but comparing multiple hybrid and cloud architectures. I expect there'll be two or three good options I'll come up with we can compare.
Explore managed cloud services that can help us reduce technical debt and empower our developers to be more productive. This is where we'll need to look at our budget and perform a total cost of ownership: https://aws.amazon.com/blogs/publicsector/cloud-economics-value-tco-assessment/

Related tasks from our Product Roadmap:

https://github.com/trendscenter/coinstac-planning-and-architecture/issues/9
https://github.com/trendscenter/coinstac-planning-and-architecture/issues/7
https://github.com/trendscenter/coinstac-planning-and-architecture/issues/3
https://github.com/trendscenter/coinstac-planning-and-architecture/issues/2

CI server would be a good place to find inspiration. Could even clone it.

Don't over-engineer, but also keep in mind long-term thinking regarding our technical debt and the ease of developing on the platform.

Mission bullet points -

have a solution that allows automated CI deployment
containerized applications for said deployment
the ability for the a containerized application (coinstac-server) to pull, launch, inspect, stop, share data (currently over a
volume) and communicate (over WS)
with computation containers it launches
wishlist - the ability to shell in and inspect running services

@rssk If I find that decoupling storage and/or making it elastic is afforable and straight-forward to implement, do you see benefits to that as a feature? Like with developer time, troubleshooting, extensibility, and scalability.

This video describes an architecture that has several patterns/components relevant here: https://youtu.be/nhqcecpi47s

I'm thinking I'll come up with a phased architecture approach. For example, we could start out with computations running in the same server as the backend services. Then we can plan to decouple them on separate servers as long as we can solve for networking communications between the containers in that state.
This will allow us to address the unique needs of computations versus our middleware. For example, the computations may benefit from elastic storage while they may not be necessary for our backend services. Similarly, computations may need GPU support but that may not be necessary for our backend services.
Overall for the system, decoupling patterns like this will make the system more reliable (like resilient to failures) and take less of ITs time to update and maintain. We can address microservice issues in a more targeted manner, simplifying troubleshooting and reducing downtime.

What microservices do we have in total running on the server in the current architecture?

MongoDB
MQTT
nginx
Node.js
NPM
Docker
GraphQL

Custom Node.js packages:

coinstac-api-server: GraphQL and MongoDB server. This is the backend API for the front-end clients.
coinstac-server: The "pipeline" server. Runs remote pipelines and sends results to the api-server. This middleware between the backend API and the pipelines that run computations. It manages backend data processing.
coinstac-ui: A webpack server used in our build step to bundle web assets.

.

What services does @rssk want running on our container server?
From the set of services we want running on the container server, which ones are already containerized?
From the set of services we want running on the container server, which ones should be run in containers?
What unique requirements do each of these containers have?
What is the difference between what the backend API services will need versus the containerized computations?

Next Steps: I need to spend more time gathering requirements to make sure I design and build the best solution. I'm going to continue requirements analyis while also exploring potential solutions. As I look at reference architectures, I typically have more questions.

@Nonzzo Do you know of any good architectures we could reference here?

Requirements Analysis with @dylanmartin (context from the front-end UI container implementation):

As a user, I can't run singularity containers on windows.
I can't hit a button on the UI and have the pipeline manager work in all the same environments as the UI. It is coupled to the environment the main process is instantiated in, but it doesn't have to be.
The pipeline manager is unnecessarily restricted by the UI package that is written in Electron.
We may not be following good patterns for leveraging Electron's renderer and main processes.
When running on the client, the UI should be more separated the pipeline manager. If the UI is launched in one environment, the pipeline manager is also launched. It needs to be installed in a separate containerized environment. Then communicate via web sockets or whatever.
We need a better separation of infrastructure and application code. In some ways, they need to be seprate architectures that interface well. There is software architecture and there is systems architecture and they are different.

The overall goal of mine is to decouple the backend packages from the front end packages and then decouple the pipeline manager from the rest of the backend packages. Following that, I want to write infrastructure as code to deploy the system to multiple servers (like with pipeline manager service running on one server and the other backed services running on another server and no UI running). Finally, this same code can be used to deploy the environment to dev, QAT, and prod or whatever.

These are two types of elastic storage I’m considering for the pipeline manager server:

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AmazonEBS.html
https://aws.amazon.com/efs/

Here is the actual feature for dynamically increasing volume size: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/requesting-ebs-volume-modifications.html
Events to hook up to: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AmazonEBS.html#volume-modification-events

Requirements analysis with @pixelsaurus:

A service to act as like a router that allows you to choose what remote node to communicate with. Then we could have a some function call to compile a list of also available remote nodes available on AWS. Then an admin account could choose which node per consortium. There can be many nodes with varying capabilities we can choose from. This would allow for us to meet custom requirements by consortia.
The trouble with pipeline there are many nuanced configurations for each computation. The manager is very much a server-side service. There are parts of the manager that only ever run when installed on the client machine and some parts that only ever run when in a server environment. Should this be two separate packages? Seems could have more of a separation of concerns.
Could consortium and pipeline be the same thing from the UI perspective? Users don't necessarily care about the pipeline, they want to run computations.
We have hardly touched CI/CD so starting pretty fresh there. Once we have these service nodes, it would be good to have each computation run on its own elastic node. CI/CD would be a part of deploying the computations to the nodes.

It would be good to diagram all of the different ways we configure this system.

Note to self: leverage on-prem when we can: https://trendscenter.github.io/wiki/

CircleCI's heavy Terraform integration is promising:

CircleCI is a continuous integration and delivery (CI/CD) platform for automating software builds, tests, and deployments. The CI/CD paradigm establishes version control repositories as the source of truth for your deployments. It also helps teams quickly ship new features and fixes by defining pipelines that help ensure the stability and resilience of your services through testing and automation. You can build deployment pipelines of varying complexity to satisfy your organization’s requirements for production deployments.
Using Terraform to manage your infrastructure as code enables the benefits of the CI/CD workflow for infrastructure deployments. Since your infrastructure is codified, your team can collaborate and review it and deploy it using automated pipelines instead of manual orchestration. To automate Terraform operations in a remote environment, you need to configure remote state storage so Terraform can access and manage your project's state across runs.

https://learn.hashicorp.com/tutorials/terraform/circle-ci

Similarly, with Github:

GitHub Actions add continuous integration to GitHub repositories to automate your software builds, tests, and deployments. Automating Terraform with CI/CD enforces configuration best practices, promotes collaboration and automates the Terraform workflow.

HashiCorp's "Setup Terraform" GitHub Action sets up and configures the Terraform CLI in your Github Actions workflow. This allows most Terraform commands to work exactly like they do on your local command line.
https://learn.hashicorp.com/tutorials/terraform/github-actions

General use case we'll be leverage Terraform for: https://www.terraform.io/use-cases/integrate-with-existing-workflows

Is this a direction we should be going?
https://www.youtube.com/watch?v=qhKbgvDNodI

is this a direction we should be looking for creating the EC@ instaance to manage the CI/CD pipeline?
https://www.youtube.com/watch?v=qhKbgvDNodI

we could add security scanning of the docker image to mitigate vulnerabilities and also do continuous monitoring

Packer sounds like a great tool to leverage:
https://learn.hashicorp.com/tutorials/terraform/packer

That continuous monitoring capability is pretty attractive @Nonzzo! Thanks for sharing.

I think the main use cases for CircleCI lie in "Creation" with heavy Github integration and then "Orchestration" integrating Terraforma and Packer. All of these are glued together with the underlying AWS infrastructure that we can also leverage.

Tutorial with a reference architecture that covers some of our use cases and preferred tooling: https://annalach.gitbook.io/aws-terraform-workshops/

One goal I have is to find an existing solution, like in AWS Marketplace, that is what we need and is already setup with one-click deployment. The problem with AWS Marketplace is that it is all CloudFormation. Terraform has modules we could leverage (this came up with good search results "terraform circleci AWS ec2 docker module").

Started a prioritization discussion in Slack:
[Dylan Martin]
The current pain point I'm dealing with is the coupling of services. I don't know if we're encountering any roadblocks that would be solved with automated deployment at the moment.
[Ross]
I think these [high-level goals] are actually more or less in order for me, besides the iac stuff being coupled w the deployments
i think that, while the decoupling of packages might feel more immediate to the devs working on them, the prod/etc setups are a house of cards and needs to be changed asap

There are two web socket servers listening inside each computation container. This means the Python process never exits until the process is done. If we want to run something more complex inside of that.

An advantage of IaC in the deployment context is it can codify all of the kinds of deployments we have. We could have a repo of deployment packages we can run for different use cases.

I'm currently migrating the plan laid out in this task to our wiki: https://github.com/trendscenter/coinstac/wiki/DevOps-Milestone-Planning.
Following that, I will break out the sub-tasks into Issues as necessary and tag them in the DevOps Milestone.

@spanta28 This is what I suggest we focus on after documentation is in a really good spot.

Need to simplify what to do and get it done. Focus on things like Dockerization and scripting. Deployment and reliability and ease of maintenance are much more important than scaling and modernization.
Try to put more of what we have into production, like the compose we have for CI. A good principle could be to get more hands off on the prod env and make that more automated.
Managed MongoDB would be an easier win.
AWS-ify compose.

KISS this stuff and keep it within the real constraints of our system and team.


Deprecate binary encoding outside VDS

Henning should look at this - can we switch to using protobuf serialization?

Yes, we can add a new map entry and let the backend handle both.
If we are quick and enable protobuf now, we can drop the old one at 8.

I don't think we need a major version change to do that?

Currently we require you have a recent MAJOR version in order to do rolling upgrade to next MAJOR.
We do not have any such requirement/procedure/enforcement for minor upgrades. We should have that as that would make it a lot easier to maintain our code base.

Good point, how about https://github.com/vespa-engine/frontpage/pull/232
Though we already say that if you don't want to maybe lose your data you need to upgrade content nodes through every minor so I'm not sure this makes any difference in practice.

@geirst @vekterli FYI

How about changing the content node data compatibility to 2 months as well?
Requiring everyone to goo through every minor seems a bit unrealistic.


added configuration options for issue #585 (kill menu, client name in title)

Please see comments in issue #585

Looks great! Thanks!

@joewing Can you make a new release with this commit? It's been a while since previous one :) Thanks!

Sure! I'll try to push out a release today.


vitess/Makefile 136: sed of OSX doesn't support '--in-place -r'

under OSX,  '--in-place -r' should be '-i -E' ,  or use gnu-sed
$ brew install gnu-sed
$ export PATH="/usr/local/opt/gnu-sed/libexec/gnubin:$PATH"
or just use basic regexp with escape('-i' is fine, OSX and Linux all support it).

Thanks for the suggestion!


os/mac/keg_relocate: add fallback to default Perl version when using tab

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

While this should never be necessary for per-OS bottles, this could be useful for :all bottles where the OS it was built on could use a Perl version that doesn't exist on all macOS versions.

Review period skipped due to critical label.


Fix#696 - #696 Add configuration option to use plain() by default

setPlainByDefault(true|false)

Anybody with "write acsess", can you merge this pull request ?

Would you mind squashing all these commits into one before this gets merged?

@daviesgeek done, sry for the delay

Sorry, one more picky thing. Can you please cleanup the commit messages before I merge this, then I'll get it merged in!

@Nihaux come back and make it happen dude. Thanks!

@daviesgeek done

Need this! When will this PR be merged? @daviesgeek

@Nihaux Thanks for this. I hope this gets into release and pushed into bower soon, Currently I am directly pointing to master so that I can use this feature in my project.


somatic_variant_filtration needs to run ebfilter even if only dkfz_bias_filter would be needed

Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
N/A
Describe alternatives you've considered
N/A
Additional context
Internal ticket #161

@ericblanc20 could you write terse description of the first two points above


Add use_string_in_part_of_directives

I hereby propose we add use_string_in_part_of_directives.

The rule is part of Effective Dart.
The language team is considering banning the old syntax in a future version of Dart.

As part of core? recommended?

I propose for core.

yes, I vote core. If we could do it for free we'd probably eliminate non-string directives at the language level.

Approved for core.


Company Communicator V4.0 Deployment issue

Receiving the following error during V4.0 deployment in Prod
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"message":"There was a conflict. Conflict with existing ScmType: ExternalGit"},{"message":"There was a conflict. Conflict with existing ScmType: ExternalGit"}]}

Hi @EYSue ,
Could you please share the logs or the screenshot of the custom deployment progress to confirm which resources got failed.
If the resources failed is of type Microsoft.Web/sites/sourcecontrols, please refer the resolution steps mentioned in the troubleshooting guide #1.

Hi
Letting you know I am getting assistance on this issue from Erin Carter via our Account Manager, Scott Johnson.
Regards
Sue
From: v-royavinash @.>
Sent: Wednesday, March 2, 2022 4:45 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Susan McInulty @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator V4.0 Deployment issue (Issue #656)
Hi @EYSuehttps://github.com/EYSue ,
Could you please share the logs or the screenshot of the custom deployment progress to confirm which resources got failed.
If the resources failed is of type Microsoft.Web/sites/sourcecontrols, please refer the resolution steps mentioned in the troubleshooting guidehttps://github.com/OfficeDev/microsoft-teams-apps-company-communicator/wiki/Troubleshooting #1https://github.com/OfficeDev/microsoft-teams-apps-company-communicator/pull/1.
—
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/656#issuecomment-1056202165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AV477NADX3CB3T7CLOFBG7DU53W5FANCNFSM5PUYLMUQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>This e-mail and any attachment are confidential and contain proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. If you are not the intended recipient, please notify the author immediately by telephone or by replying to this e-mail, and then delete all copies of the e-mail on your system. If you are not the intended recipient, you must not use, disclose, distribute, copy, print or rely on this e- mail. Whilst we have taken reasonable precautions to ensure that this e-mail and any attachment has been checked for viruses, we cannot guarantee that they are virus free and we cannot accept liability for any damage sustained as a result of software viruses.  EY refers to the global organization, and may refer to one or more, of the member firms of Ernst & Young Global Limited, each of which is a separate legal entity. Ernst & Young Global Limited, a UK company limited by guarantee, does not provide services to clients. EY Global Services Limited is a company registered in England and Wales with registered number 5483856. Its registered office is at 6 More London Place, London, United Kingdom, SE1 2DA. EY Global Services Limited's business is confined to the supply of services to member firms of Ernst & Young Global Limited and related entities

Hi @EYSue ,
Could you please confirm if the issue is resolved?

Hi @EYSue ,
Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses.
Hence we are closing the issue.
You may also always open a new issue or respond here if something does come back up.
Thank you!


support meta name="go-import" to detect repository

follow on #119
Before
% ghq get golang.org/x/crypto
     clone https://golang.org/x/crypto -> /Users/Songmu/dev/src/golang.org/x/crypto
       git ls-remote https://golang.org/x/crypto
        hg identify https://golang.org/x/crypto
       svn info https://golang.org/x/crypto
     error Could not find version control system: https://golang.org/x/crypto

After
$ ghq get golang.org/x/crypto
     clone https://golang.org/x/crypto -> /Users/Songmu/dev/src/golang.org/x/crypto
       git ls-remote https://golang.org/x/crypto
       git clone https://go.googlesource.com/crypto /Users/Songmu/dev/src/golang.org/x/crypto
Cloning into '/Users/Songmu/dev/src/golang.org/x/crypto'...
remote: Total 5013 (delta 2982), reused 5013 (delta 2982)
Receiving objects: 100% (5013/5013), 4.76 MiB | 7.54 MiB/s, done.
Resolving deltas: 100% (2982/2982), done.

Since this "meta go-import" is a Go-specific specification, there is a concern about being tightly coupled to it.
However, since go get will no longer clone the source in GOPATH after go1.13, it is inconvenient for those who used ghq to access sources, so I make ghq to be possible to clone it.
I want to merge it because it is useful for Go programmers.


fixing dt time calculation

I believe the dt calculation is wrong in the code.
The fractions need be divided by 4 and the two bits for IRIG removed. This is not well documented in the phantom documentation but I checked the time from trigger using the phantom PCC software
Frame 0:

Frame 299:

base code:

new code:

Here is the new dt calculation
for i in eachindex(dt)
     fracstart = read(f, UInt32)/4/2^30
     secstart = read(f, UInt32)
     dt[i] =
          (secstart - cine.TriggerTime.seconds) +
          ((fracstart - cine.TriggerTime.fractions/4/2^30) )
end

Good catch! I’ll take a look at this tomorrow. All my recordings are less
than a second, which is probably why I didn’t run into this bug.
On Wed, May 22, 2024 at 10:47 PM mgalenb @.***> wrote:

I believe the dt calculation is wrong in the code.
The fractions need be divided by 4 and the two bits for IRIG removed. This
is not well documented in the phantom documentation but I checked the time
from trigger using the phantom PCC software
Frame 0:
Screenshot.2024-05-22.at.9.23.30.PM.png (view on web)
https://github.com/stillyslalom/CineFiles.jl/assets/6004917/8bcb7e45-53de-4f57-9efe-da9416d1b620
Frame 299:
Screenshot.2024-05-22.at.9.24.56.PM.png (view on web)
https://github.com/stillyslalom/CineFiles.jl/assets/6004917/5efb1bcd-b918-4eb8-a9e2-32ef7976aeef
base code:
Screenshot.2024-05-22.at.9.18.30.PM.png (view on web)
https://github.com/stillyslalom/CineFiles.jl/assets/6004917/e96e01ef-c734-415b-920c-fe499987d5ec
new code:
Screenshot.2024-05-22.at.9.06.07.PM.png (view on web)
https://github.com/stillyslalom/CineFiles.jl/assets/6004917/942eca48-71b1-4855-b3d2-f4a61fbf4be2
Here is the new dt calculation
for i in eachindex(dt)
fracstart = read(f, UInt32)/4/2^30
secstart = read(f, UInt32)
dt[i] =
(secstart - cine.TriggerTime.seconds) +
((fracstart - cine.TriggerTime.fractions/4/2^30) )end

You can view, comment on, or merge this pull request online at:
https://github.com/stillyslalom/CineFiles.jl/pull/11
Commit Summary

da04410
https://github.com/stillyslalom/CineFiles.jl/pull/11/commits/da04410ec5356da9a6f58fc2df0f954fe5346869
fix dt time calculation

File Changes
(1 file https://github.com/stillyslalom/CineFiles.jl/pull/11/files)

M src/CineFiles.jl
https://github.com/stillyslalom/CineFiles.jl/pull/11/files#diff-cf7d09012d90192dde109fa21544ca0efc4ca270eb772194e50f771d4531ff0c
(4)

Patch Links:

https://github.com/stillyslalom/CineFiles.jl/pull/11.patch
https://github.com/stillyslalom/CineFiles.jl/pull/11.diff

—
Reply to this email directly, view it on GitHub
https://github.com/stillyslalom/CineFiles.jl/pull/11, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABA73GFFCDI2ZUBWHWXMQRLZDVYFZAVCNFSM6AAAAABIE3RZL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTCOJTGE4DKMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Can you produce a sample cine file (minimum resolution, minimum number of frames) that gives incorrect timestamps and add it to test/data/? You're welcome to add a corresponding test, otherwise I'll take care of it.

I added a dt_test.cine to /test/data. I havent written a test before however so not sure how to do that?

actually, the original code is correct also..... maybe there is something about the other cine file I was using....looking into it

also it now occurs to me that
1/4/(2^30) = 1/(2^32)
lol sorry for the spam
let me try to reproduce the issue using a older cine file version....

ok I figured it out. it had to do with subtracting fracstart and TriggerTime.fractions which are UInt32. this produced another UInt32 which would not have the correct fraction (see 3 column plot on left). the bottom plot shows cf.header.dt

the solution is to convert them to float64 (by dividing by 2^32) and then subtracting (see plot on the right)
these plots are made with the test/data/dt_test.cine file


*: Add runbook for KubePersistentVolumeInodesFillingUp

This is a newly added alert[1] and very similar to
existing KubePersistentVolumeFillingUp but for inodes.
[1] https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/761
Signed-off-by: Arunprasad Rajkumar<EMAIL_ADDRESS>

/lgtm

Hello, I just wanted to notify you that this alert will fire up needlessly in the event where the backing PVC can provide inodes dynamicaly and its metrics show 0 instead of an actual value because of that feature. Such an example would be when using Ceph CSI plugin for CephFS PVCs.
I don't know if that's possible to ignore some types of volumes based on capabilities but you're the experts :)

@Bengrunt thanks for the report! yes we're already been notified about this issue and working with the storage team to understand what can be done.


✨ Add website reference to README

Summary
This PR updates the README file at the root of the repo to include a pointer to the website.
Related issue(s)
Fixes #

/cc @KPRoche
/cc @clubanderson

/lgtm

/approve


Make test pass by ...

... forcing everything that comes out of event.sprintf to be in UTF-8, when this is fix in logstash-core this changes can be removed.

@ph would you be so nice to review this? thanks a lot for your time.

per discussion in elastic/logstash#3718 the encode calls are not necessary, only the # encoding: utf-8 is missing at the top of alter_spec.rb plus the elastic/logstash#3718 fix.

@colinsurprenant I clean up all non necessary encoding and left a warning with the workaround to make this happy, until there is a new release of logstash-core, makes sense to merge and release a new versio n of this plugin?

LGTM
@purbon Can you rebase and merge this ? It make my mass update fails for this plugin. Thank you

on it, merging it right now.


Resolve iOS issues

https://github.com/theglus/Home-Assistant-Config/blob/0c0d9e2109baa1b1f8fca5599987589800776ea4/includes/extra_module_url.yaml#L1-L18
Requirements

[x] Add HACs resources as extra JS modules
[x] Link to ../includes/extra_module_url

This release changes the way browser_mod functions are called from the frontend when you want something to happen only on the current device.
Instead of doing
tap_action:
action: call-service
service: browser_mod.toast
service_data:
message: Hello, world!
deviceID: this
you now need to do
tap_action:
action: fire-dom-event
browser_mod:
command: toast
message: Hello, world!
YOU ONLY NEED TO CHANGE THIS IF YOU HAD
deviceID: this
OR
deviceID:

this

IN YOUR SERVICE CALL BEFORE
This may be a bit tedious to change, but it'll be worth it in the end, as this will allow for adding new cool functionality in the future.
Also, this change will make sure that browser_mod does not break Home Assistant 2021.3.0 (sic!).
There's also a new service for calling multiple services after each other, and one to put delays in between them.
** It's worth taking the time to re-read the readme**
Oh! And browser_mod devices now correspond to Home Assistant Devices. That's very cool!
For developers of lovelace plugins
This change makes use of the fire-dom-event tap action.
It's actually been in the code for almost a year, but has never been used (yet).
If your lovelace plugin does not support this, they will not work for direct triggering of browser_mod functions.
Calling a service as before still works, though, it's just the deviceID: this that's gone.
See: https://github.com/home-assistant/frontend/blob/8d13745c6b822a76f6724e32c2b10bf57ae645e7/src/panels/lovelace/common/handle-action.ts#L137

@crixle Informed me It’s a known error with the flip animation, the dev says it’s something he can’t fix for iOS. Issue can be resolved by removing the animation completely.


Ultimate Vocal Removal error

Last Error Received:
Process: Ensemble Mode
If this error persists, please contact the developers with the error details.
Raw Error Details:
AttributeError: "'SeperateMDX' object has no attribute 'trim'"
Traceback Error: "
File "UVR.py", line 6576, in process_start
File "separate.py", line 819, in seperate
File "separate.py", line 1212, in process_secondary_model
File "separate.py", line 475, in seperate
File "separate.py", line 518, in demix
"
Error Time Stamp [2023-09-27 20:12:34]
Full Application Settings:
vr_model: Choose Model
aggression_setting: 5
window_size: 320
mdx_segment_size: 384
batch_size: Default
crop_size: 256
is_tta: True
is_output_image: False
is_post_process: True
is_high_end_process: True
post_process_threshold: 0.1
vr_voc_inst_secondary_model: VR Arc: 1_HP-UVR
vr_other_secondary_model: MDX-Net: kuielab_a_other
vr_bass_secondary_model: MDX-Net: kuielab_a_bass
vr_drums_secondary_model: Demucs: v4 | htdemucs
vr_is_secondary_model_activate: True
vr_voc_inst_secondary_model_scale: 0.9
vr_other_secondary_model_scale: 0.7
vr_bass_secondary_model_scale: 0.5
vr_drums_secondary_model_scale: 0.5
demucs_model: Choose Model
segment: Default
overlap: 0.75
overlap_mdx: 0.75
overlap_mdx23: 6
shifts: 1
chunks_demucs: Auto
margin_demucs: 44100
is_chunk_demucs: False
is_chunk_mdxnet: False
is_primary_stem_only_Demucs: False
is_secondary_stem_only_Demucs: False
is_split_mode: True
is_demucs_combine_stems: False
is_mdx23_combine_stems: False
demucs_voc_inst_secondary_model: MDX-Net: MDX23C_D1581.ckpt
demucs_other_secondary_model: Demucs: v4 | htdemucs
demucs_bass_secondary_model: MDX-Net: kuielab_a_bass
demucs_drums_secondary_model: Demucs: v4 | hdemucs_mmi
demucs_is_secondary_model_activate: True
demucs_voc_inst_secondary_model_scale: 0.9
demucs_other_secondary_model_scale: 0.7
demucs_bass_secondary_model_scale: 0.5
demucs_drums_secondary_model_scale: 0.5
demucs_pre_proc_model: MDX-Net: UVR-MDX-NET Inst HQ 3
is_demucs_pre_proc_model_activate: True
is_demucs_pre_proc_model_inst_mix: False
mdx_net_model: Choose Model
chunks: Auto
margin: 44100
compensate: Auto
denoise_option: Denoise Model
is_match_frequency_pitch: True
phase_option: Automatic
phase_shifts: None
is_save_align: False
is_match_silence: True
is_spec_match: False
is_mdx_c_seg_def: True
is_invert_spec: True
is_deverb_vocals: False
deverb_vocal_opt: Main Vocals Only
voc_split_save_opt: Lead Only
is_mixer_mode: False
mdx_batch_size: Default
mdx_voc_inst_secondary_model: MDX-Net: UVR-MDX-NET_Main_438
mdx_other_secondary_model: Demucs: v4 | htdemucs_6s
mdx_bass_secondary_model: MDX-Net: kuielab_a_bass
mdx_drums_secondary_model: Demucs: v4 | htdemucs_ft
mdx_is_secondary_model_activate: True
mdx_voc_inst_secondary_model_scale: 0.9
mdx_other_secondary_model_scale: 0.7
mdx_bass_secondary_model_scale: 0.5
mdx_drums_secondary_model_scale: 0.5
is_save_all_outputs_ensemble: True
is_append_ensemble_name: True
chosen_audio_tool: Manual Ensemble
choose_algorithm: Min Spec
time_stretch_rate: 2.0
pitch_rate: 2.0
is_time_correction: True
is_gpu_conversion: True
is_primary_stem_only: False
is_secondary_stem_only: False
is_testing_audio: False
is_auto_update_model_params: True
is_add_model_name: False
is_accept_any_input: True
is_task_complete: True
is_normalization: False
is_wav_ensemble: False
is_create_model_folder: False
mp3_bit_set: 320k
semitone_shift: 0
save_format: WAV
wav_type_set: 32-bit Float
help_hints_var: True
set_vocal_splitter: No Model Selected
is_set_vocal_splitter: False
is_save_inst_set_vocal_splitter: False
model_sample_mode: False
model_sample_mode_duration: 30
demucs_stems: All Stems
mdx_stems: All Stems

I found the bug. A new patch will be available within the next few hours to address this bug and a few others that were reported to me. Thank you!

Thanks, I'll keep an eye on the links page for when it goes up, I'm anxious
to see if this will work.
Any tips on a mostly instrumental stems track downmix I want to make? I'd
like to split up a stereo source into multiple instrumental tracks (no
vocals) for remixing purposes.
I really don't know what I'm doing but trying alot of experimentation. I
have no idea which models would be best for this.
Also.. I played with some of the overlap and N_FFT scale (model defaults)
and what used to take an average of.. 10-15 mins per 3 minute song is now
taking up to 7-8 hours?! I'd like to go back, but really want the most
quality I can possibly have.
Lastly, I noticed it took some stereo-sounding keyboards in my song and
made them mono.. is there any trick to preserve the stereo imagery.. or is
this just the way it is for now w/ AI?
Thanks for all your time and help friend!! AI track separation is exciting!
:)
P.S. I heard George Martin's son Giles used an AI "de-mix" software to take
mono (or was it stereo 2-track?) mixes of old Beatles songs, somehow
extracted multitrack stems, then remixed the songs as if there was perfect
separation of each instrument.. guitar, piano, drums, vocals? Pretty
impressive. I'd imagine it was something much more powerful than UVR? 🤣
Here's a bit of that:
https://www.musicradar.com/news/the-beatles-revolver-stereo-remix-ai-tech
https://www.abbeyroad.com/de-mix
https://youtu.be/KsYxTuX5wC4
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Thu, Sep 28, 2023 at 8:18 PM Anjok07 @.***> wrote:

I found the bug. A new patch will be available within the next few hours
to address this bug and a few others that were reported to me. Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/Anjok07/ultimatevocalremovergui/issues/825#issuecomment-1740254723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A52UCVTJ5PGDIRL5TT5K4KDX4Y4XZANCNFSM6AAAAAA5KJHJZE
.
You are receiving this because you authored the thread.Message ID:
@.***>

This has been fixed. Please download the latest patch. Thank you!

Awesome, thanks for the update!
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Fri, Sep 29, 2023 at 3:02 AM Anjok07 @.***> wrote:

Closed #825
https://github.com/Anjok07/ultimatevocalremovergui/issues/825 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Anjok07/ultimatevocalremovergui/issues/825#event-10509454303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A52UCVRKODZM3XHOLAHW6XLX42MD3ANCNFSM6AAAAAA5KJHJZE
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


chore: implement KvBackend trait for MetaPeerClient (wip)

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr intended to implement KvBackend trait for MetaPeerClient and move existing methods impl such as range, batch_get into trait impl. (as mentioned in https://github.com/GreptimeTeam/greptimedb/pull/3075)
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change

impl TxnService for MetaPeerClient (txn default unimplemented
impl KvBackend for MetaPeerClient: (copied over batch_get, and range)

How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[ ]  This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

better start new pr from main


pythonPackages.mesa: init at 0.8.6

Motivation for this change
mesa is a Python 3+ library for creating multi-agent simulations.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I disabled the tests for the examples directory (but it feels a bit to hacky, to be honest).

@GrahamcOfBorg build python3.pkgs.mesa

do you mind rebasing this on top of master... I seem to be building things that I shouldn't when I review...
git pull -r origin master
git push --force .. ..

Yes, sure. :slightly_smiling_face:

figured it out, pyside is importing the mesa package, before it was getting it from the pkgs package scope, but now it's finding in python packages.
$ rg "mesa "
pyside/default.nix
1:{ lib, fetchurl, cmake, buildPythonPackage, pysideGeneratorrunner, pysideShiboken, qt4, mesa }:
18:  buildInputs = [ mesa ];

do you mind adding doing:
  pyside = callPackage ../development/python-modules/pyside {
    inherit (pkgs) mesa;
  };

to top-level/python-modules.nix and naming it: pythonPackages.pyside: inherit mesa from pkgs

nix-review is happy for me, macos 10.13.

@dpaetzel can you address the changes requested from @jonringer? Looks good for me to merge then :-)

I finally got to address the pyside request. Sorry it took so long.

@GrahamcOfBorg build python3Packages.mesa

Oh, I probably should exclude mesa from python38Packages then?

No, python38Packages.pytest is broken on master, so I'm disregarding it for now

it was fixed in staging, just hasn't made it's way to master yet

I was wondering why the closure was so huge, i managed to shave off 57MB #71553

Ah, that clarifies it. Nice work on the closure size!

ofborg finally built everything :), merging.
Thanks for sticking through all the pain

Nice! Thank you, reviewers :slightly_smiling_face:


Problem with rtkit daemon

Describe the bug
Problem with rtkit daemon, which is why a sound does not work in kde5 (plasma)
Steps To Reproduce
I don't know, I didn't touch any special settings
I recently added a few settings, after which I noticed that there was a problem:
boot.kernelModules = ["nf_conntrack_pptp"];
networking.firewall.connectionTrackingModules = [ "pptp" ];

But then I removed these settings and rebuild nixos
Additional context
× rtkit-daemon.service - RealtimeKit Scheduling Policy Service
     Loaded: loaded (/etc/systemd/system/rtkit-daemon.service; linked; vendor preset: enabled)
     Active: failed (Result: exit-code) since Tue 2022-06-07 22:34:29 EET; 6s ago
    Process: 14261 ExecStart=/nix/store/kf5m1bsgi1npscwvk1mbcmmdg2mz9fhp-rtkit-0.13/libexec/rtkit-daemon (code=exited, status=1/FAILURE)
   Main PID: 14261 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 2ms

июн 07 22:34:29 nixos rtkit-daemon[14261]: Successfully dropped privileges.
июн 07 22:34:29 nixos rtkit-daemon[14261]: Successfully limited resources.
июн 07 22:34:29 nixos systemd[1]: rtkit-daemon.service: Main process exited, code=exited, status=1/FAILURE
июн 07 22:34:29 nixos rtkit-daemon[14261]: pthread_create failed: Resource temporarily unavailable
июн 07 22:34:29 nixos rtkit-daemon[14261]: Demoting known real-time threads.
июн 07 22:34:29 nixos systemd[1]: rtkit-daemon.service: Failed with result 'exit-code'.
июн 07 22:34:29 nixos rtkit-daemon[14261]: Demoted 0 threads.
июн 07 22:34:29 nixos systemd[1]: rtkit-daemon.service: Start request repeated too quickly.
июн 07 22:34:29 nixos systemd[1]: rtkit-daemon.service: Failed with result 'exit-code'.
июн 07 22:34:29 nixos systemd[1]: Failed to start RealtimeKit Scheduling Policy Service.

Notify maintainers
This package has no maintainers.
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.43, NixOS, 22.05 (Quokka), 22.05.379.08950a6e29c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"nixos-unstable, nixos-22.05"`
 - channels(lev): `"home-manager-22.05.tar.gz"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Hmm, the sound works some time after logging in, although rtkit-daemon doesn't work, I thought it was because of this

Everything works on the old configuration, how can I compare configurations?

Everything works on the old configuration, how can I compare configurations?

Take a look at https://gitlab.com/khumba/nvd for that.
You are using security.rtkit.enable = true; in your config ? Also, you are using Pulseaudio or Pipewire?

Take a look at https://gitlab.com/khumba/nvd for that.
OK, thanks, I'll take a look
You are using security.rtkit.enable = true; in your config ? Also, you are using Pulseaudio or Pipewire?
I use pulseaudio:
sound.enable = true;
hardware.pulseaudio.enable = true;

No, the problem has not disappeared on the old configuration, sometimes when loading rtkit-daemon it works fine, and sometimes it does not work

No, strange, but it stopped working again, the service sometimes just stops working for no reason, and then the sound falls off

It looks like this: https://bugs.launchpad.net/ubuntu/+source/rtkit/+bug/1871543

Same problem here. I'm on nixpgs cc4bb87f5457ba06  (above 22.11)

This issue occurred to me after upgrading from 23.11 to 24.05.  Another, similar machine doesn't exhibit this issue. The major difference between these two machines is that the one with the issue hasn't been rebooted after the upgrade.
I'll update this comment once the machine with the issue has been rebooted.


[Android] Keyboard pushes content on screen

While using an Android device, the user notices that the keyboard pushes content on screen, when pulled up.

ready for retest.

Verified.


Migrate from pip to rye

https://lucumr.pocoo.org/2024/8/21/harvest-season/
In my experience, rye is a killer developer experience. It makes Python tooling more like the Rust ecosystem. Switching over to rye will help include the next generation of Python developers to be included into projects like this one.

is it opt-in ? Like can project relying on pip will continue to work ?

Rye publishes to the same package index as pip. In fact, it uses all Python distribution and packaging standards, it just surfaces them behind a unified (arguably , saner) CLI.
So, even if this project uses Rye, other projects will still be able to use pip.


⚠ Hartman Foundation has degraded performance

In e920ae2, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 3301 ms

Resolved: Hartman Foundation performance has improved in 6c00c87.

Resolved: Hartman Foundation performance has improved in 6c00c87.


Accept international phone numbers

Problem statement
ReportStream does not accept international phone numbers.  A patient phone number that does not comply with the 10 digit format is blanked out and the phone is not sent downstream to STLTs.
What you need to know
Example warning message:
Invalid phone number '+4915112950000' for 'patientPhone' ('patient_phone_number'). Reformat to a 10-digit phone number (e.g.<PHONE_NUMBER>).
Acceptance criteria

[ ] International phone numbers are accepted and sent to STLTs

We currently have the libphonenumber library in the application, which comes from Google. This should be able to handle international phone numbers. We should use the library to verify that it is a valid phone number, and if it is, then we can accept it. If it is NOT a North American phone number (therefore Canada, Mexico, or US), we should not fill in PID.13.6 and PID.13.7, but instead just fill in PID.13.1 and PID.13.12. We SHOULD always fill in PID.13.4, which is country code.
Country codes can be found here: https://countrycode.org/

@MauriceReeves-usds approved and merged the branch.

The implementation of parsePhoneNumber (phone validation) is very strict.  It validates the real existing (valid) phone number.  If the number is not a real/valid number, it throws an exception and failed the validation.  This causes the integration test to fail because the integration test realizes on Fake Data Generator to generate phone numbers for testing.  Therefore, many generated phone numbers are invalid/real numbers being used by phone companies.

Note from Slack:
OTT SATHNGAM  9:29 AM
Good morning, Mo.  In regarding to the ticket 3869 - Accept international phone numbers.  How can I obtain the error or warning messages that Jim Duff saw when the PR merged last time?  I think and if we are going to incorporate the PR to the prob, I will have to fix those code that prompted those errors and warnings as well, correct?
Maurice Reeves  9:41 AM
good morning Ott. you won't see those errors normally, and you can't really fix them all. the better logic is to try and parse the international phone number, and if it succeeds, fill out those additional fields, but if it does not parse correctly, just pass through what we were given
9:41
we don't want it to fail


BranchPolicyException breaking change approval labels

This is a minor swizzle to our labeling design. Please

change the Versioning-Approved-NotReleased to Versioning-Approved-BranchPolicyException
add a BreakingChange-Approved-BranchPolicyException label

"NotReleased" is a bit too bland and nondescriptive. These are exceptions to the branch policy and we should make the label communicate that clearly.

[ ] Pull Request 542484: Add BranchPolicyException to breaking changes approval labels
[ ] Update labels on the specs repos
[ ] Update the docs


Unable to discern MBps limits

Hi there! It appears as though these D/E (Intel) v4 themed IAAS VMs have additional local SSD capacity and changes to throughput logic. This could be a really good thing but this documentation doesn't explain that with certainty.
For Dds_v4, there are 3 values provided with 2 labels. Can those 3 values be more clearly identified? For example, D16ds_v4 lists 77000/485(200) and is labelled "Max cached and temp storage throughput: IOPS/MBps". Your label suggests either 2 or 4 values
[Max cached throughput in IOPS/MBps]
[Max temp storage throughput in IOPS/MBps]
But I've been given 3 values. Are the IOPS restrictions the same regardless and MBps vary between temp storage and caching? Is cached MBps the 2nd or 3rd value?
Also, is the cache size the same as the Temp storage size? That value isn't provided for most VM documents but would be very helpful in understanding. For v3 and earlier SKUs, enabling disk caching reduced available MBps throughput, which was/is bad.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a43e5b4-7893-dcd7-839f-e394912d1bd9
Version Independent ID: 560d2e4a-6a12-48ac-dff7-44f036450250
Content: Ddv4 and Ddsv4-series - Azure Virtual Machines - Azure Virtual Machines
Content Source: articles/virtual-machines/ddv4-ddsv4-series.md
Service: virtual-machines
GitHub Login: @brbell
Microsoft Alias: brbell

@ntachandley
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

We have updated the table, it was missing the label and it should be "Max cached and temp storage throughput: IOPS/MBps (cache size in GiB)". The information has been updated.

Interesting, this reads as though cached read events have higher caps than a similarly configured DSv2, effectively being the first "HT" SKU with equal or better IO consideration than vCore-based (see DSv2) SKUs. Is that consistent with plan?

#please-close


Add option to connect to plex server over https

Solves https://github.com/music-assistant/hass-music-assistant/issues/1968
Manual configuration is needed for https/ssl to work, since it is still hardcoded to use http for plex gdm discovery.

@micha91 and/or @jozefKruszynski I leave this one for you to review as you have more insight about Plex.
To me the Plex setup is getting rather daunting with all these options now

Can you have a look at the linting errors please ?

Can you have a look at the linting errors please ?

I have fixed the trailing whitespaces, but I do not understand the import sorting rules. Where can I move "import requests"?

Can you have a look at the linting errors please ?

I have fixed the trailing whitespaces, but I do not understand the import sorting rules. Where can I move "import requests"?

Let the linters do that for you:
in your development venv do "pip install -e ".[test]" to install all test/lint requirements. After that you can do "pre-commit install" to install the git hooks to run the linters

Thank you, I think I have fixed the linting issues now.


Dependecies cleanup

I moved dependencies from root to packages and added missing one.
Also i18n and store are removed from core package.

I need to work a bit more on it...

Is it yes? :D


Only register top-level namespaces while we bootstrap authorization for sub-spacing

Right now, nothing prevents me from registering /jhiemstra as a namespace and someone else from registering /jhiemstra/foo as a namespace. Eventually we should make sure this kind of sub-spacing is authorized by the entity that owns /jhiemstra.
For now, while we bootstrap up to that kind of authorization, we should at least enforce that if /jhiemstra is already registered, /jhiemstra/foo is restricted. Likewise, if /jhiemstra/foo is already registered, we should restrict registration of the parent space /jhiemstra.

Closed by PR #460


Feature: Make KV store optional

The KV store backend is only required when policy enforcement is enabled. Make KV store backend optional wen policy enforcement is disabled.

Fixed in commit 05dd96f426a0561987a02f446fb4e61902b494ef


Implement allowBackgroundLocationUpdates iOS setting

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
:arrow_heading_down: What is the current behavior?
Currently geolocator sets allowBackgroundLocationUpdates equal to true by default when the UIBackgroundModes contains location value inside the app's Info.plist, which leads to Geolocator.getPositionStream receiving background geolocations even if you don't need them
:new: What is the new behavior (if this is a feature change)?
User can disable background geolocations updates even if their app contains location value inside the UIBackgroundModes key
:boom: Does this PR introduce a breaking change?
No, allowBackgroundLocationUpdates is set to true by default
:bug: Recommendations for testing
Can be tested on iOS devices and simulators

Add location value to the UIBackgroundModes Info.plist key
Request position stream with getPositionStream with locationSettings equal to:

AppleSettings(
  allowBackgroundLocationUpdates: false
)

Send app to the background
Check that there is no background geolocation indicator visible in status bar

:thinking: Checklist before submitting

[x] I made sure all projects build.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I followed the style guide lines (code style guide).
[x] I updated the relevant documentation.
[x] I rebased onto current master.

I think it should be in readme file. I implemented the background location updates in one of my app. In the recent updates it stopped working with the following code
Geolocator.getPositionStream(
          locationSettings: LocationSettings(
              accuracy: LocationAccuracy.bestForNavigation,
          )
      )

I have ignored the rest of the params for testing purpose.
When I replaced the location settings with Apple Setting for iOS as suggested above, background location updates are working.
AppleSettings(
            accuracy: LocationAccuracy.bestForNavigation,
            allowBackgroundLocationUpdates: true,
            showBackgroundLocationIndicator: true,
            activityType: ActivityType.automotiveNavigation
        );

I have followed all the steps like allowing location updates in background mode, always location permission.

hey, @Faiizii, what's your geolocator_apple version? (you can find it in the pubspec.lock)
Also, do you use the getCurrentPosition somewhere in your code? If yes, then it might be related to this issue: https://github.com/Baseflow/flutter-geolocator/pull/1169

geolocator_apple is 2.2.3. No, I've just used the getPositionStream to get continuous updates.

Hi @landyrev,
Reading the original comment from @Faiizii, it seems that the only problem is that the documentation doesn't explain to use the AppleSettings and specifically set the allowBackgroundLocationUpdates parameter to true if you'd want to enable background support for iOS.
He originally used the LocationSettings object which is mentioned in the documentation but doesn't turn on support for background services (as this is Apple specific).

@mvanbeusekom, ah, right. We set allowBackgroundLocationUpdates equal to true only when you use AppleSettings.
Yeah, fair enough, I'll draft a PR


fix activity overview statistics

There are a few problems with the stat calculation system:

When there are weeks with e.g. VoD views but no live views, painting them both in one graph breaks it
stats are not reliably sorted
some weeks appear duplicated.

Worst case, it looks like this:

This PR makes sure, weeks with gaps between stats are filled with 0 stats, additionally,the MAX/SUM behaviour is fixed (currently the VoD view count incorrectly uses MAX instead of SUM)
Result:

Also, I noticed a strange gap at the end of live statistics locally

That's probably because your db dump doesn't contain live views from later than week 48.
github.com/jinzhu/now looks fun! Also it's written by the same dude who made gorm :tada:

I also added test automation to gh actions here


Update README.md

I added the hyperlink.
The link I put I like how it is explained, it is not too long and it is quite easy to understand.
I have more interesting links but they are longer.
You can tell me if you like it or prefer another one!
Also, I added it at the beginning of the README but under the first title, I do not know if you prefer above the title or under.
I hope you like it.
Thank you so much for letting me work with you!
Have a nice day/night.

Thank you so much!! Could you put the label Hacktoberfest or hacktoberfest-accepted? Thank you!


Slow tuning (device is reinitialized when it shouldn't be)

Changing frequency (when doing frequency hopping / sweeping spectrum) is extremely slow. The problem is that device is always reinitialized when changing frequency to a new one if freq. difference is >= rate / 2 (see here: https://github.com/pothosware/SoapySDRPlay/blob/master/Streaming.cpp#L416).
But this condition is wrong, according to PDF at http://www.sdrplay.com/docs/Mirics_SDR_API_Specification.pdf, device needs to be reinitialized only when a frequency band edge is crossed (see frequency allocation table at the end of the PDF). There is no need for freqDiff < rate / 2.0 condition.

@xmikos aye, I think this was mostly in response to the earlier SDRPlay libraries where it was a bit less stable and this was a solution -- I'll investigate patching this to only occur at the band edges as suggested -- thanks!

I also think current implementation will fail if you change frequency to less than rate / 2 (so reinitialization will not be triggered), but still cross the frequency band edge. So it is not only enhancement, but also bug. But I am not 100% sure, couldn't test it right now...

@gedger 's fix takes care of this nicely; thanks!


Documentation suddenly missing

Somehow, suddenly the documentation links don't work anymore: https://raw.githubusercontent.com/tovic/text-editor/v2.8.5/text-editor/ui
I'm currently actively developing on a project using the text editor, and no I'm pretty stuck, having to implement some custom modals and markdown extensions... Could you please fix the documentation?

Download the version 2.8.5 release then read it offline.

https://cdn.statically.io/gh/taufik-nurrohman/text-editor/v2.8.5/index.html


IDEA: F0 web browser

dear Esteban,
I have an idea to make an app that uses the wifi dev board to connect to wifi and a server to surf the FLIP-net (a server that stores a bunch of FLIP-sites made especialy for the flipper zero) and open/use FLIP-sites to: play games, read, and even check/send E-mails to other flipper zeros. I also hope to allow people to contribute their sites and ideas for development. if you have any questions or concerns about this concept, please respond to this post.
cheers,
Elio Anon
P.S. your Gameboy tools are SOOO COOl!

I think it's a great idea as a project, but it might be too extensive and could work better as an independent project.
I believe it would be highly beneficial as long as the functionalities of Flipper Zero can be accessed through the web (IR, SubGhz, NRF, etc.).
Perhaps it could also be maintained as a service in F0 (similar to storage or Bluetooth) so that Wi-Fi communication can be utilized from any application.
For now, I'll close the topic because I think it's a project that doesn't align with MALVEKE's target.
Best regards!

Ok. I’ll do some research
On Tue, Jan 2, 2024 at 8:40 PM Esteban Fuentealba @.***>
wrote:

I think it's a great idea as a project, but it might be too extensive and
could work better as an independent project.
I believe it would be highly beneficial as long as the functionalities of
Flipper Zero can be accessed through the web (IR, SubGhz, NRF, etc.).
Perhaps it could also be maintained as a service in F0 (similar to storage
or Bluetooth) so that Wi-Fi communication can be utilized from any
application.
For now, I'll close the topic because I think it's a project that doesn't
align with MALVEKE's target.
Best regards!
—
Reply to this email directly, view it on GitHub
https://github.com/EstebanFuentealba/MALVEKE-Flipper-Zero/issues/10#issuecomment-1874464607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7PB7RHQVPV2IODA7TQWP5TYMRPEDAVCNFSM6AAAAABBHWAISCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGQ3DINRQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Are you able to select which lights on the bridge you want to control with this?

Maybe this is part of the setup process but are you able to select certain lights on the bridge and leave others out?

You can change the light order in the config: https://github.com/sinedied/dmx-hue#setting-lights-order but I don't think you can currently disable lights to be mapped automatically.

Have you found a current work around on the automatic mapping?

You can select which lights to include as part of the setup process.
I don't understand @sinedied 's comment. According to git blame it's been a feature since the initial commit 6 years ago:
https://github.com/sinedied/dmx-hue/blame/e1dd3ab9629f86cee68947b4cf18dee6341d1102/index.js#L207-L214

@rjmunro You're right, it's been a while since I worked on this so my memory was failing 😅
If you run dmx-hue setup you can select which light are enabled.


Any tips for how to generate a minimap client-side?

I've been trying to add a minimap to the game for the past few days. My current setup is as follows:

Individual blocks within a chunk are represented as single colors.
While loading a chunk, it gets the topmost color for a column (x,z pair). These colors are provided at build time.
AWorldMap class has two dictionaries, one for the height of a column and one for the color of a column.
After loading the chunk, it updates the color in the WorldMap class for the x,z pair
A MinimapRender class gets the current chunk and steps back 5 chunks and forward 5 chunks for both x and z

Is this...a reasonable way to do it?
The problems I'm running into are:

The player position as displayed on the minimap is wrong. I think my code for finding the current position of the player within the chunk is wrong?
The center position on the minimap is wrong
I think the chunk images need to be rotated? That's what it looks like, but I don't understand why.

Here's a more visual explanation. You can click on it to make the image bigger

This is what the code for actually drawing the chunk images looks like:
if (!this.position) {
  return;
}
this.ctx.fillStyle = "#ccc";
this.ctx.clearRect(0, 0, this.ctx.canvas.width, this.ctx.canvas.height);

const noa = this.loader.noa;
const {
  _renderPosition: renderPosition,
  position,
} = noa.entities.getPositionData(noa.playerEntity);

const cs = 32.0;

const globalX = position[0]; //renderPosition[0] + noa.worldOriginOffset[0];
const globalY = position[1]; //renderPosition[1] + noa.worldOriginOffset[1];
const globalZ = position[2]; //renderPosition[2] + noa.worldOriginOffset[2];

const currentChunkZ = globalZ / cs;
const currentChunkX = globalX / cs;

this.minChunkX = Math.floor(currentChunkX - MinimapRender.squareLength);
this.minChunkZ = Math.floor(currentChunkZ - MinimapRender.squareLength);
this.maxChunkX = Math.ceil(currentChunkX + MinimapRender.squareLength);
this.maxChunkZ = Math.ceil(currentChunkZ + MinimapRender.squareLength);

const translateX = ((globalX % cs) + cs) % cs;
const translateZ = ((globalZ % cs) + cs) % cs;

const { minChunkX, maxChunkX, minChunkZ, maxChunkZ } = this;

let chunkXOffset = -1;
let chunkZOffset = -1;

const drawXOffset = 0;
const drawYOffset = 0;

for (let chunkX = minChunkX; chunkX < maxChunkX; chunkX++) {
  chunkXOffset++;
  chunkZOffset = -1;

  for (let chunkZ = minChunkZ; chunkZ < maxChunkZ; chunkZ++) {
    chunkZOffset++;

    const imageData = this.worldMap.imageAt(
      Math.round(chunkX),
      Math.round(chunkZ)
    );

    if (!imageData) {
      continue;
    }

    let x = chunkXOffset * imageData.width - drawXOffset;
    let y = chunkZOffset * imageData.height - drawYOffset;

    this.ctx.putImageData(imageData, x, y);

    if (
      Math.floor(currentChunkZ) === Math.floor(chunkX) &&
      Math.floor(currentChunkZ) === Math.floor(chunkZ)
    ) {
      this.ctx.fillStyle = "pink";
      this.ctx.strokeStyle = "red";
      const r = 4;
      this.ctx.beginPath();
      this.ctx.arc(x, y, r, 0, 359);
      this.ctx.font = "10px Arial";
      this.ctx.strokeText(
        `${Math.floor(globalX)},${Math.floor(globalY)},${Math.floor(
          globalZ
        )}`,
        x,
        y
      );
      this.ctx.fill();
      this.ctx.closePath();
    }

  }

}

this.ctx.canvas.style["transform"] = `translateX(${
  (MINIMAP_SIZE - MINIMAP_WIDTH) / -2
}px) translateX(${
  (MINIMAP_SIZE - MINIMAP_HEIGHT) / -2
}px) translateX(-${translateX}px) translateY(-${translateZ}px)`;

The pink dot / text is just for debugging

This is a cool idea! The noa-related code (e.g. how you're getting the player position) looks right to me. It's a bit hard to grok the rest, but I'm guessing there's just a math bug somewhere in those offsets and modulos. (and maybe the fact that in Canvas the Y coord runs from top to bottom?)
That said:
      Math.floor(currentChunkZ) === Math.floor(chunkX) &&
      //                     ^ X?
      Math.floor(currentChunkZ) === Math.floor(chunkZ)

Thanks for taking a look – it was a few math things.
Plus, the axis was wrong for getting the colors. I was setting all the x to z and all the z to x.
Framerate is a little too low now on Safari though and I optimized a lot of this code already.
This is what it looks like now. I'm still going to add a few things (location name) and a full-screen map when you press M, but I'm happy with it so far. I'd rather a more Fortnite/World of Warcraft-style map design than a pixel art map design....but that seems much more time consuming to code

It'd be slightly better if I fix the occasional missing frame at the bottom but that's a thing I can fix later

Hey, this looks really cool. Are you constructing the whole image each tick? The low-hanging fruit optimization would be for each chunk to render its own 32x32 image, cached and only periodically recreated, and the main loop would just take those N images and composite them to the right place on the canvas. This would also make it relatively easy to make the map rotate with the player if you want (just rotate them before drawing them into the canvas). Anyway cool stuff!

Thanks.
Yeah, on Firefox & Chrome it:

Creates 32x32 ImageBitmap objects for each x, z pair after the chunk is
loaded and keeps it in a Map. If an ImageBitmap already exists for a new
chunk with overlapping x,z, it compares the tallest one for each xz and
does some blending stuff (heights are stored in an array)
Draws just the ImageBitmap objects. Saves the ImageBitmap it drew in an
array (which is pre-allocated). If it already drew the same ImageBitmap in
the same spot, it skips drawing. It only calls clearRect when min/max chunk
changes
finds any players in a chunk and draws their arrows onto a second canvas
layered on top. The lower canvas has alpha disabled
It uses a CSS transform to move the canvases without it feeling choppy as
you move to different chunks. This uses the JS StyleSheet object instead of
inline styles, so that it doesn’t write to the DOM during render

On Safari, it’s pretty much the same except there’s no ImageBitmap support.
It just uses the ImageData object directly, but draws it twice - once at
the smaller size and again to scale it correctly. I tried using Image with
blobs but it didn’t make much of a difference
Theoretically, I could move all of this except the transform part to an
OffscreenCanvas in a web worker but that won’t help Safari.
From profiling, it looks like three issues:

memory usage overall (the images are not that big, I think this is more
generally an issue right now in the game)
Paint time can take max of 30ms, but almost all were like 0.0002ms
terrainMesher stuff is most of the time lost

On Wed, Jun 24, 2020 at 1:16 AM Andy Hall<EMAIL_ADDRESS>wrote:

Hey, this looks really cool. Are you constructing the whole image each
tick? The low-hanging fruit optimization would be for each chunk to render
its own 32x32 image, cached and only periodically recreated, and the main
loop would just take those N images and composite them to the right place
on the canvas. This would also make it relatively easy to make the map
rotate with the player if you want (just rotate them before drawing them
into the canvas). Anyway cool stuff!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/andyhall/noa/issues/117#issuecomment-648671018, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNGS5F2L77JILEZ3QZBN3RYGY6RANCNFSM4OEJ3CKA
.


deanon libcontrol

Not really building without plan9-extensions but this is a step.
Signed-off-by: Ronald G. Minnich<EMAIL_ADDRESS>

LGTM


Request: combined sin/cos function

Bonjour. Would you be interested in creating an approximated function that would calculate both sine and cosine, and which would be faster than individual calls to both? Many SIMD implementations like vectorclass and avxmathfun have such function, although their performance is still slower than computing both sin and cos with SIMD-math-prims. I was wondering if extra performance could be squeezed out. Thanks!

Thanks for the feature request!
However, I don't really have time to wok on this for now. Have you tried to simply e.g., compute sine and deduce cosine via the formula cos(x) = sqrt(1 - sin²(x)) when x is in an appropriate interval? Appart from that, I have no idea how to do this and have a significant performance gain in SIMD-math-prims.
I believe that vectorclass and avxmathfun may be able to gain some performance since this enable them to save the computation of a division (which is needed to move the input to a normalized interval close to 0). SIMD-math-prims do not do this, since it assumes the input is already normalized.

I admit, I have not tried obtaining it using the identity. I will try and let you know if it's faster than computing the other of sin/cos approximation. Square root is fairly fast, and the argument can be calculated with a single FMA instruction. The sign is a bit more of an issue. Assuming [-pi,pi], the sign for sine may simply be the sign(theta) which should be fast, but for cosine I'm not seeing an easy way other than two if/blend.


Unable to send performance data to Sentry

Summary

I'm following the documentation and I'm not able to send performance data to Sentry.io. This doesn't happen with other features like messages or events. In order to reproduce the error, I created a hello world app with a basic integration of Sentry.
Steps To Reproduce

Here you have the code https://go.dev/play/p/A9scQPjpE0r?v=goprev
package main

import (
	"fmt"
	"net/http"

	"github.com/getsentry/sentry-go"
	sentryecho "github.com/getsentry/sentry-go/echo"
	"github.com/labstack/echo/v4"
	"github.com/labstack/echo/v4/middleware"
)

func main() {

	// To initialize Sentry's handler, you need to initialize Sentry itself beforehand
	if err := sentry.Init(sentry.ClientOptions{
		Dsn: "mysecretkey",
		// Set TracesSampleRate to 1.0 to capture 100%
		// of transactions for performance monitoring.
		// We recommend adjusting this value in production,
		TracesSampleRate: 1.0,
		Debug:            true,
		Environment:      "localhost",
		Release:          "v1.0",
		EnableTracing:    true,
	}); err != nil {
		fmt.Printf("Sentry initialization failed: %v\n", err)
	}

	// Then create your app
	app := echo.New()

	app.Use(middleware.Logger())
	app.Use(middleware.Recover())

	// Once it's done, you can attach the handler as one of your middleware
	app.Use(sentryecho.New(sentryecho.Options{}))

	app.GET("/", func(c echo.Context) error {
		return c.String(http.StatusOK, "Hello, World!")
	})
	app.Logger.Fatal(app.Start(":1323"))
}

Expected Behavior

I'm expecting to see metrics.

Sentry

Using hosted Sentry in sentry.io? yes
Using your own Sentry installation? Version:
Anything particular to your environment that could be related to this issue?

Additional context

Can you add Debug: true to sentry.Init and share the output please?

The Debug: true is already in the sentry.Init. The output is this:
$ go run main.go
[Sentry] 2023/05/24 10:30:03 Integration installed: ContextifyFrames
[Sentry] 2023/05/24 10:30:03 Integration installed: Environment
[Sentry] 2023/05/24 10:30:03 Integration installed: Modules
[Sentry] 2023/05/24 10:30:03 Integration installed: IgnoreErrors

   ____    __
  / __/___/ /  ___
 / _// __/ _ \/ _ \
/___/\__/_//_/\___/ v4.10.2
High performance, minimalist Go web framework
https://echo.labstack.com
____________________________________O/_______
                                    O\
⇨ http server started on [::]:1323
{"time":"2023-05-24T10:30:06.926478793-03:00","id":"","remote_ip":"<IP_ADDRESS>","host":"localhost:1323","method":"GET","uri":"/","user_agent":"curl/7.81.0","status":200,"error":"","latency":22970,"latency_human":"22.97µs","bytes_in":0,"bytes_out":13}

The curl command that I'm using is curl -IL -XGET localhost:1323/ and that's the only log that I get no matter how many times I run it.

Sorry, I missed this. Our echo integration does not create performance data by default. You could implement a custom middleware that does this as we do for net/http https://github.com/getsentry/sentry-go/blob/master/http/sentryhttp.go#L81-L112.

same applies to gin-gonic it seems.. perhaps worth of documenting or making common function to all?

added gin https://github.com/getsentry/sentry-go/pull/644
at least for me it works, but not sure is everything like should

Would be lovely if you could add some docs. Just spend like too much time trying to figure out why it's not working...

Which part of the docs made you believe we do create transactions for echo automatically?

No part. The fact that I came from JS/Python and it worked out of the box.

Sorry, I missed this. Our echo integration does not create performance data by default. You could implement a custom middleware that does this as we do for net/http https://github.com/getsentry/sentry-go/blob/master/http/sentryhttp.go#L81-L112.

can you add this information to your web site docs, please? I was searching for a long time for the solution. thanks.


Tried to register two views with same name AndroidCheckBox

Hi, I am trying to use the checkbox library along with a react-native checkbox.
the version in my package.json is:
"@react-native-community/checkbox": "^0.4.2"
required a help resolve it in android build.

Same issue for me in 0.5.2
"@react-native-community/checkbox": "^0.5.2
"react-native": "^0.60.6"

Hi, same issue
"@react-native-community/checkbox": "^0.5.5",
"react-native": "^0.63.3",

I was getting same error.

Update to "@react-native-community/checkbox": "^0.5.6" and it is solved now.
Also be sure you are importing from "@react-native-community/checkbox". I was importing from react-native on the screen with the error.

getting the same error:
  "dependencies": {
    "@react-native-community/checkbox": "^0.5.9",
    "react": "17.0.2",
    "react-native": "^0.66.4",
    "react-native-windows": "^0.66.6"
  },

try gradlew clean & reset cache dude, i try it & error was clear

cd android && ./gradlew clean
npm start --reset-cache
npm run android


Suggestion: Add option to choose NPCs using NPC ID

Hi,
Currently if you want to see the monster hp percentage of a specific NPC it will show it on all NPCs with that name (for example if you want to see it on a specific type of goblin but not all goblins). It would be nice if we could also choose the NPC using their ID so we can be more specific. (similar to how you can highlight NPCs by ID in the Better NPC Highlight plugin)

It's possible to add, but i don't know where to find the time to add this as it's quite a bit of work

It's been on my want to add list for a while now.

Add please :)

It's possible to add, but i don't know where to find the time to add this as it's quite a bit of work

Apologize for old post bump, but this never seemed to be added, so i'll try to add this sooner or later.


Include heap dumps in logs downloaded from PT Presto containers

Replaces https://github.com/prestosql/presto/pull/5554


post json error

hi,all:
I want use StringEntry to post json to remote server,but the charles catch json is not legal json

my code is:

I also do this,no problem.You can change "application/json" into "application/json;charset=UTF-8"
good luck

How do you indicate, that the JSON "is not legal" ? Give us more info please.


The Sketchfab Plugin is not working on Cinema 4D R25 - Maybe because of Apple M1Pro Chip?

Hallo Friends,
I tried a few hours to install the sketchfab plugin in Cinema 4D R25 but it is not showing up in the Extensions window. I am useing a Apple Macbook Pro with an M1Pro Chip, is this the reason why it is not working?
Thanks for help!

Finally I found the issue, the plugin did not show up because it did not had full permissions.


Mypy doesn't detect GenericModel errors

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.9.1
            pydantic compiled: True
                 install path: [path-to-the-env]/lib/python3.8/site-packages/pydantic
               python version: 3.8.10 (default, May 23 2022, 08:05:03)  [GCC 11.2.0]
                     platform: Linux-5.15.0-40-generic-x86_64-with-glibc2.35
     optional deps. installed: ['typing-extensions']

I would expect the following example to fail on mypy check, but it doesn't:
from typing import TypeVar, Generic

from pydantic import BaseModel
from pydantic.generics import GenericModel

class BaseClass(BaseModel):
    x: int = 1

T = TypeVar("T", bound=BaseClass)

class GenericClass(GenericModel, Generic[T]):
    item: T

class ChildClass(BaseClass):
    y: int = 2

test1 = GenericClass[ChildClass](item=ChildClass())  # this passes as expected
test2 = GenericClass[ChildClass](item="test")  # this passes, but it shouldn't

If I try to reproduce the same example using dataclasses, I get the mypy error I expect:
from dataclasses import dataclass
from typing import TypeVar, Generic

@dataclass
class BaseClass:
    x: int = 1

T = TypeVar("T", bound=BaseClass)

@dataclass
class GenericClass(Generic[T]):
    item: T

@dataclass
class ChildClass(BaseClass):
    y: int = 2

test1 = GenericClass[ChildClass](item=ChildClass())  # this passes as expected
test2 = GenericClass[ChildClass](item="test")  # error: Argument "item" to "GenericClass" has incompatible type "str"; expected "ChildClass"

Ah, same here, missing init_typed in mypy.ini config. Thanks for the hint!


Adding the UI to list and create / update projects.

I intentionally did not handle pagination. I think we need a project wide solution. Although it will only probably be used by projects and runs right now. 🤷  @agoldis let me know what you wanna do with pagination.
So net new stuff is.
Project list page is actually not garbage. (I can say this cause I made it originally.) Its just missing pagination.
Projects can be added.
Projects can be deleted. (and cleaned up including runs and instances) It would be nice to have it clean up S3 aswell
Projects can be updated. (disabled in the UI until there is more project data to update)
Project list page UI has a new look.
Project edit page has been added.

That's amazing @jhicken. Looks like that is something we can release, I will review by the eo weekend. Thanks for your amazing work!

For pagination - I think the current implementation is on overkill, simple offset based pagination would be more than enough. I started to change it as part of auto-refresh task, but never had time to complete.

@agoldis Do the docker image: agoldis/sorry-cypress-dashboard:latest has this feature?

@gmkumar08 sure!


man ECDSA_sign(3): fix wrong variable names

the parameters in the function definitions use siglen not sig_len, this fixes the doc text.

Checklist

[x] documentation is added or updated

This pull request is ready to merge

Merged to all the active branches. Thank you for your contribution.


Express middleware starts heap profiling but does not stop it

if, for instance, in a testsuite, app() entry point is called once for each testcase, a new express is provisioned (correctly), and middleware/handlers attempt to register each time.
but the pyroscope middleware is not idempotent -- if heap profiling is already on, it'll attempt to enable it again and crash. better to either register a shutdown hook, or to not attempt to enable heap profiling a second time if called twice in same nodejs runtime.

Thanks @shaleynikov. One more test to add, if you wouldn't mind:
        const app = express();
        app.use(expressMiddleware());
        const app2 = express();
        app2.use(expressMiddleware());

@lizthegrey added!


Loads all output images into image editor when internal rendering

Here's a bit more robust solution.  All output files (except custom multilayers, since they don't work right) are added to a list that the engine will comb through after rendering.  All the file names in that list will be loaded into the image editor.  That list is then scrubbed whenever the next render starts, so it won't waste time trying to load images that have already been done or don't exist anymore.

Ok I think you're on the right track.  HOWEVER I would put the output files in the rpass in export_display as they're not really scene settings.

and it's simpler ;)

3rd time's the charm?

Hey man, programming is an iterative process.

Deleted that chunk you caught.

Think I found a glitch so I might have jumped the gun on this one.  Please don't merge yet.

Now I got it......cross fingers


Make Services state-less

Currently, the services carry a lot of state
Similar to the control plane, we should be able to abstract away the state into some shared kv-store, so that individual services can be horizontally scalable in the future!

heh, I kind of snuck it in 😉 the kvstore in llama-index is super handy for this

This is technically not need. Why?

A task cannot be assigned to more than one replica of an agent service
Therefore, the states for tasks will not collide if horizontally scaled