bug: lazy.nvim installs missing plugin and update lazy-lock.json

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.10.0-dev-92672a1
Operating system/version
Linux <IP_ADDRESS>-microsoft-standard-WSL2
Describe the bug
If there are plugins that have been registered but not yet installed, lazy.nvim will automatically install them at startup.
This feature is useful, but it updates lazy-lock.json.
To revert to the version specified in lazy-lock.json,

Undo changes of lazy-lock.json
Restart neovim
Call :Lazy restore

This requires three steps.
If possible, I would like the automatic installation to refer to lazy-lock.json and install that version.
I searched issues and found one, #739.
utiyre wants it too.
But you said that's already the current behaviour.
I think that is not correct.
Please check it out.
Steps To Reproduce

Add spec for a plugin.
Install it (:Lazy install)
Read lazy-lock.json and remember the commit for that plugin
Push new commit for that plugin.
Remove that plugin from Lazy.vim plugin dir.
Restart Neovim.
(lazy.nvim install it automatically)
lazy-lock.json updated and new commit is installed.

Expected Behavior

lazy-lock.json has no update in step 7
The plugin with the commit remembered in step 3 is installed

Repro
No response

it does already use the lock file for automatically installing missing plugins.
Not when you do :Lazy install

I do have same/similar issue. I'm running Lazy restore, in post-merge and post-checkout githook (in headless mode). I do like automation, I have git pull in crontab:
nvim --headless "+Lazy! restore" +qa

I'm expecting lazy-lock.json to be opened only for read, however it's regenerated and I have dirty stash when I'm login into machine with this cronjob.
Should I use different command to restore plugins with pined version's?

I noticed this too, either auto-installing or manually cleaning plugins seems to regenerate lazy-lock.json with the currently installed revisions, causing unintended modifications when syncing the lockfile between machines.
Steps to reproduce:

Install plugins on machine A.
Copy the lockfile to machine B and install the plugins there too using :Lazy restore.
Make a change on machine A (either remove a plugin, or add a new one), and also update one other plugin so the revision changes.
Sync the lockfile again to machine B.
If you added a plugin, run Neovim with Lazy's auto-installation being enabled, and observe the revision of the updated plugin in the lockfile being reverted to the old one.
Or if you removed a plugin, run :Lazy clean on machine B, and observe the same behaviour..

https://github.com/folke/lazy.nvim/issues/739 and https://github.com/folke/lazy.nvim/issues/1514 seem related, but based on the responses here and those other issues I'm not sure if this behaviour is indeed intentional and syncing lockfiles like this just isn't supported.
I do use Git to sync the lockfile so I at least notice when it gets unintentionally modified, but it would be nice if this would be handled more robustly.


version: update to 2.3.36

Update version to 2.3.36
Signed-off-by: Haojian Zhuang<EMAIL_ADDRESS>

There is a bug repair patch that relies on the latest code of sm2 async alg , plz wait for a moment, thank you!


Integrating library for performing server to server API calls to Stripe

We should research a good way to calling the Stripe API. It would be basically using cURL for this.
Here are some candidates to consider:

Kitura-Request
Using URLSession

The latter would be to use URLSession, since it minimizes the dependency of another library to use.

Will use URLSession for this


Coordinate changed ENA runs with AE links for EmbryonicHindlimb dataset

Description of the task:
A dataset was archived to AE and ENA; When we first archived it to ENA, fastq files could not be pushed due to the runs only accepting 2 files instead of 3.
Semi-recently, we started replacing these files with fastq files; the process required runs to be deleted, and therefore we need to update the runs in AE to reflect the new run accessions.
This cannot be done manually as the project is public in AE, so we need to speak with the AE team and provide them with the necessary information to make this change.
Acceptance criteria for the task:

[x] Generate a mapping
[x] Communicate with AE and pass the mapping
[ ] The change has gone through

I have communicated with arrayexpress, asking them to change the runs for this dataset
I have passed a small mapping:
{
  "cell_suspension_7": {
    "old": "ERR3895585",
    "new": "ERR9960009"
  },
  "cell_suspension_6": {
    "old": "ERR3895586",
    "new": "ERR9960008"
  },
  "cell_suspension_3": {
    "old": "ERR3895587",
    "new": "ERR9960011"
  },
  "cell_suspension_4": {
    "old": "ERR3895588",
    "new": "ERR9960010"
  },
  "cell_suspension_2": {
    "old": "ERR3895589",
    "new": "ERR9960014"
  },
  "cell_suspension_5": {
    "old": "ERR3895590",
    "new": "ERR9960013"
  },
  "cell_suspension_1": {
    "old": "ERR3928890",
    "new": "ERR9960012"
  }
}

AE has confirmed that they made the change and it will be available tomorrow to check

AE has confirmed that they made the change and it will be available tomorrow to check


Disable logging test

The logging tests currently flake ~1 out 100 runs. The issue is that the client-side logging filter is have trouble closing the send message pipe. Without the send message pipe being closed, half-close on the client side is not logged and the overall promise does not complete either.

Adding a "release blocker" label since we don't want the flake in the release branch (which is going to be cut soon).


Hotfix

resolves issue where the entities are tied to non line items.

Codecov Report

Merging #9 into master will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   81.44%   82.00%   +0.55%
==========================================
  Files           7        7
  Lines         194      200       +6
  Branches       31       33       +2
==========================================
+ Hits          158      164       +6
  Misses         29       29
  Partials        7        7

Flag
Coverage Δ

#javascript
82.00% <100.00%> (+0.55%)
:arrow_up:

Impacted Files
Coverage Δ

src/lambda.js
92.00% <100.00%> (+0.45%)
:arrow_up:

test/data.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb02911...b7f9500. Read the comment docs.


Invalid option in build() call: "watch"

package.json:
  "@badeball/cypress-cucumber-preprocessor": "^15.1.2",
    "@bahmutov/cypress-esbuild-preprocessor": "^2.1.5",
    "cypress": "^12.3.0",

using cypress.config.js (not .ts):
const { defineConfig } = require("cypress");

module.exports = defineConfig({

  e2e: {
    baseUrl: 'http://localhost:4200',
    specPattern: "**/*.feature",

  async setupNodeEvents(on, config) {
  const createEsbuildPlugin = require('@badeball/cypress-cucumber-preprocessor/esbuild').createEsbuildPlugin
  const createBundler = require('@bahmutov/cypress-esbuild-preprocessor')

  await require('@badeball/cypress-cucumber-preprocessor').addCucumberPreprocessorPlugin(on, config)

  on('file:preprocessor',   createBundler({
    plugins: [createEsbuildPlugin(config)],
  }));

  return config;
}

  },
});

Now when I run cypress test runner, all tests are there. But when I click on ANY test, I have immediately this error:
Error: Build failed with 1 error:
C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:255:12: ERROR: Invalid option in build() call: "watch"
    at failureErrorWithLog (C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:1636:15)
    at C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:953:16
    at responseCallbacks.<computed> (C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:697:9)
    at handleIncomingPacket (C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:752:9)
    at Socket.readFromStdout (C:\Users\JS\Desktop\test\node_modules\esbuild\lib\main.js:673:7)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

I can't run any test with the latest cucumber preprocessor and latest cypress. Before (with version 11.5 cucumber and v.10 cypress i had no isssues at all).
Also I can't find any normal documentation how to configure the latest cucumber preprocessor with the latest cypress in config. JS file.

I can’t reproduce the issue with the information you’re providing. Also there are plenty of working examples here: https://github.com/badeball/cypress-cucumber-preprocessor/tree/master/examples.

strange, maybe then some issue with esbuild on my side. I now tried to replace it with browserify and works well.

I have the exact same issue. Running same config as OP and same version of the plugins.

I had the same issue. @l0gicgate great catch! seems like locking esbuild to version 0.16.5 solves the issue.

esbuild seems to have introduced backward incompatibility changes with version 0.17.0.
See changelog: https://github.com/evanw/esbuild/releases/tag/v0.17.0
For now, locking your version any version below 0.17.0 seems to fix the issue.

This can be tracked at https://github.com/bahmutov/cypress-esbuild-preprocessor/issues/229 and @l0gicgate's workaround (https://github.com/badeball/cypress-cucumber-preprocessor/issues/929#issuecomment-1399654455) can be used for now.

@bahmutov/cypress-esbuild-preprocessor appears to have been updated and pinning esbuild should no longer be necessary-


theme component in ubuntu.

as mentioned in the Readme file : ~/Library/Application Support/Mailspring/packages/THEME_NAME
where i can find the component directory in ubuntu.
I am not able to find it here.

Check in ~/.config/Mailspring/packages/

For snap installation, I found that in /home/snap/mailspring/common/packages/THEME_NAME


On reset button click, have the side menus expand.

Right now, you can click on the side menu buttons and the menu will minimize. Make sure all the menus are expanded when the reset button is clicked.


Please adhere to semantic versioning

Commit 68f56730a92decb8f196d7b15470483071f48060 removed a public method "setDefaultLanguage" that was even listed in the projects documentation. Removing this is an incompatible change. Users do not expect a BC-breaking change when you only increase the patch-part of the version number.
According to semantic versioning this should have resulted in an increase of the major-part of the version number. Would you please be so kind to adhere to this standard in the future?

@Sander-Toonen , thanks for reporting, somehow i missed this. been almost 3 years now, 😂

closing issue now


How to animate marker from one position to another

First of all great work!
Is it possible to have controller.animateMarkerTo(oldCoordinates, newCoordinates,) where by the marker will be animated while moving from the old position to the new position instead of controller.addMarker() then controller.removeMarker() repeatedly without animation. A feature like this will be very useful, especially for real-time tracking.

yeah, i will create new api to provide this feature
sorry for that

Thanks


Make NetPortableProfileTable thread-safe and test

Fixes:

https://github.com/NuGet/Home/issues/778
NuGet/Home#2464

Add on top of @hickford's good work with https://github.com/NuGet/NuGet2/pull/46.
/cc @emgarten @hickford

Hi @joelverhagen, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:cool: :shipit:


Fix Pub/Sub Tests

Fixes pub/sub tests to repair the build.

The build still seems to be broken. I guess we have multiple issues with it.

We are waiting until morning. Spring-cloud-build upgraded Spring Boot and then rolled back; it appears Travis has a maven cache.

Yup, it might be easiest to just merge #2256 in and then fix the build issues after.

Yup, it might be easiest to just merge #2256 in and then fix the build issues after.

Sure, just merged.

Closing in favor of #2264.


[5.0][stdlib] _StringObject: Use a full 8-bit discriminator on 32-bit platforms

#20561 gave us plenty of extra inhabitants in the variant enum, so we can get rid of the 7-bit hack.
It’d also be possible now to increase small string capacity to a spacious 11 bytes; however this needs a full overhaul of the 32-bit String representation, so it needs a little bit more time in the oven.
Cherry picked from #20643, reviewed by @milseman
rdar://problem/44232093

Note: This is an ABI-breaking change on 32-bit platforms.

@swift-ci test

As czar I am technically a branch manager; but I do not feel qualified to give positive approval for changes to the branch. czar is strictly a defensive role.

That's fine! This can wait until @airspeedswift gets back -- I just wanted it up and ready.


PureConfig updates

This PR updates docker-compose as per the changes in https://github.com/apache/incubator-openwhisk/pull/3617

@markusthoemmes , @cbickel I'm asking for your help with this review since you've worked on the PR in the upstream. Thanks in advance !

@dgrove-oss thanks a lot for reviewing !


⚠ Turnos 24x7 has degraded performance

In ad8d898, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 966 ms

Resolved: Turnos 24x7 performance has improved in ecfbf5b.


Kernel does not give any output, asyncio NotImplementedError, Kernel died

I tried to installed akernel with JupyterLab 3.1.18 and Python 3.9.4 on Windows 10
pip install akernel[react]
akernel install react
jupyter lab build

Its possible to select akernel for a Notebook. However, the notebook does not produce any output for my cells:

It has never been tested, and I don't have a Windows machine.
Thank you for the clarification.


HHH-18617 Fetching unowned side of bidirectional OneToOne mappings including tenant identifier triggers EntityFilteredException

https://hibernate.atlassian.net/browse/HHH-18617
Backport of https://hibernate.atlassian.net/browse/HHH-18617

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

That simple, huh?


Add span::ssize(), ssize(span), size(span)

See p1227, Signed ssize() functions, unsigned size() functions.

gsl-lite currently sort-of backports  C++17's size() and data(). It also defines ssize() for span<>, but it does not yet implement a fully general ssize() as proposed for C++20.


[WIP][SPARK-37404][PYTHON][ML] Inline type hints for pyspark.ml.evaluation.py

What changes were proposed in this pull request?

This PR migrates type pyspark.ml.evaluation annotations from stub file to inline type hints.
Why are the changes needed?

Part of ongoing migration of type hints.
Does this PR introduce any user-facing change?

No,
How was this patch tested?

Existing tests.

This currently blocked by SPARK-37415 and SPARK-37416, as we need MLReadable types to be runtime generic (already tested if these three integrate together).

Merged into master.


B 18885 sit delivery miles calculation int

Agility ticket
Summary
We want to calculate and store the delivery miles value between the following for SIT service items:
On creation:
Destination SIT: distance between shipment destination address & service item destination address
Origin SIT: distance between shipment pickup address & service item pickup address
On update:
Destination SIT: distance between shipment destination address & service item ORIGINAL destination address
Origin SIT: distance between shipment pickup address & service item ORIGINAL pickup address
The service item does not have the original_address saved until the TOO approves it, so on creation it will always be 1 mile since the shipment destination/pickup address is the same as the service item’s.
Where calculations are done for:
Origin Creation: calculateSITDeliveryMiles
Origin Update: TOO approval of service item: updateServiceItem
Origin Update: prime edits pickup address: UpdateOriginSITServiceItemSITDeliveryMiles
Destination Creation: calculateSITDeliveryMiles
Destination Update: TOO approval of of service item: updateServiceItem
Destination Update: prime makes address update request, TOO rejects/approves: UpdateDestinationSITServiceItemsSITDeliveryMiles
To test:
See the document I attached to the story as a guide.

Keep track of your zip codes as you go, especially the starting pickup and destination zips.
On a shipment, request origin SIT.
Verify that SITDeliveryMiles is 1 for origin service items.
Approve as the TOO and check that the SITDeliveryMiles makes sense. It will likely still be 1.
Edit the shipment pickup address as the prime. I recommend looking at the functions for each situation and attaching a breakpoint to make sure the zips compared make sense.
On any shipment, doesn't have to be the same one, request destination SIT.
Verify that SITDeliveryMiles is 1 for destination service items.
Approve as the TOO and check that the SITDeliveryMiles makes sense.
As the prime, request an address change that does not trigger TOO approval (less than 50 miles) via the "Update Shipment Destination Address" button.
Verify that the SITDeliveryMiles calculation makes sense and the database value is updated to match the calculation, calc done in UpdateDestinationSITServiceItemsSITDeliveryMiles function.
As the prime, request an address change that triggers TOO approval via the "Update Shipment Destination Address" button.
As the TOO, reject it. Verify that the SITDeliveryMiles is the same as it was before rejecting the address update.
As the prime, request an address change that triggers TOO approval via the "Update Shipment Destination Address" button.
As the TOO, approve it. Verify that the SITDeliveryMiles calculation makes sense for the provided zips and the database value is updated the match the calculation.

For destination address changes that don't trigger TOO approval, you can use the BILWEI move and change destination address zip from 94535 to 94533, and should see 6. You can change it to 94534 and should see 8 miles.
For destination address changes that require TOO approval, the SITDeliveryMiles should be the same as the distance shown to the TOO when they have to approve it. As soon as the TOO approves the address change, the database should update.
Spoke with Danny and he clarified that SITDeliveryMiles should only be calculated for origin DOPSIT and DOSFSC and destination DDDSIT and DDSFSC. That update has been made.

Showed Danny both origin and destination SIT delivery calculation examples and he is good with them all, with the exception of maybe needing to use zip5 rather than zip3 for some zip calculations. Getting further clarification on that.

Dre found the fix for this - we were using a mocked DTOD service rather than using the actual DTOD service. Turned that flag off so we should be getting accurate calculations for zips that use DTOD rather than Rand McNally.

Updated the document I made that is attached to the story, which should make testing this fairly straight forward.

@cameroncaci need your approval of the requested changes then I'm good to go!


Ensure that the HTML at endpoints is clear

Right now if someone doesn't know how to use polymath, and someone says "My endpoint is at https://polymath.komoroske.com", the default thing to do is visit it. But right now you get a confusing form without explanation about what to do. In reality very very few people will interact with an endpoint directly, and this (accidental) first interaction is a point of friction for people new to polymath.
We should clean up the HTML from those endpoints to maximize clarity for users to find themselves there.

I have a crazy idea. I am going to build a tiny web app that acts as a simple endpoint client. And we serve it as the default HTML.

Yeah I love that. As in, it serves the content from #41.
One downside is that the host then has to implicitly allow access to their OPENAI_API_KEY (or I guess it could open a little dialog that says "Paste your Openai_key here, it won't be transmitted except to OpenAI's servers')


TS types are wrong for

Description
_contentContainerStyle requires data and renderItem properties, when it should only require style props
CodeSandbox/Snack link
none
Steps to reproduce
<FlatList
  data={data}
  renderItem={renderItem}
  _contentContainerStyle={{ pb: '8' }} // TS ERROR
  // ...

### NativeBase Version

^3.3.7

### Platform

- [ ] Android
- [ ] CRA
- [X] Expo
- [X] iOS
- [ ] Next

### Other Platform

TypeScript

### Additional Information

_No response_

Looks like there's a PR to fix it that hasn't been merged: https://github.com/GeekyAnts/NativeBase/pull/4642

@garrett-gottlieb Thanks for working on this. We've fixed this issue in version 3.3.9.


Deep Learning: Train a LSTM to generate hand writing

Reference Paper:
Generating Sequences With Recurrent Neural Networks
Reference Code:
Repo
Instructions:

Please use Google Colab as a platform to train the model
Using TensorFlow is preferred

Hi there Sir,
Can you assign me this issue ??
I would like to proceed with the working

Hi there Sir,
Can you assign me this issue ??
I would like to proceed with the working

Hi there Sir,
Can you assign me this issue ??
I would like to proceed with the working

It's almost a week. @TanweerulHaque  what's your update on this?

Hi there Sir,
Can you assign me this issue ??
I would like to proceed with the working

It's almost a week. @TanweerulHaque  what's your update on this?

Hi there @smaranjitghose This LSTM paper was a bit difficult to comprehend. However, I have started with the coding part. I'll just be needing a couple of days more. Thank you.

Hi there @smaranjitghose This LSTM paper was a bit difficult to comprehend. However, I have started with the coding part. I'll just be needing a couple of days more. Thank you.

No worries @TanweerulHaque. Just give us some updates every two days. consult with @vidhi-mody if required

No worries @TanweerulHaque. Just give us some updates every two days. consult with @vidhi-mody if required


Gst.Message and Gst.Internal.MessageData

It should be possible to get a MessageData struct from a Gst.Message object.
Currently the best solution I can find looks like this, which has a few issues.
[StructLayout(LayoutKind.Explicit)]
public struct MessageData
{
    [FieldOffset(64)]
    public global::Gst.MessageType Type;
    [FieldOffset(72)]
    public ulong Timestamp;
    [FieldOffset(80)]
    public IntPtr Src;
    [FieldOffset(88)]
    public uint Seqnum;
}

var data = Marshal.PtrToStructure<MessageData>(msg.Handle.DangerousGetHandle());

DangerousGetHandle should not be required.

Using the generated Gst.Internal.MessageData raises the following errors, which is why I defined my own.
a. Overlapping offsets in MutexData

System.TypeLoadException: 'Could not load type 'GLib.Internal.MutexData' from assembly 'GLib-2.0, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' because it contains an object field at offset 0 that is incorrectly aligned or overlapped by a non-object field.'

b. Failure to marshal delegates in MiniObjectData

System.Runtime.InteropServices.MarshalDirectiveException: 'Cannot marshal 'return value': Returned SafeHandles cannot be abstract.'

See https://github.com/gircore/gir.core/issues/966#issuecomment-1794065205 for an example use case.

Potentially duplicate of #782?


how to change visual rating

Describe your problem here.
I made an issue (enhancement) #8782 for visual ratings
@ShadowMario said "You can mess with rating in lua now"
how would I use the new function, do I have to reinstall the source or uh... do other stuff?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No, just modded in the "example_mods" folder

For once the wiki has something for this...
Check this for more info.

That's not what they asked for

sick

That's not what they asked for
setProperty('ratingsData[0].image', 'image') --change "Sick" image

Read the commit changes for more info

where are the commit chnages

In commits lol

In commits lol

where is that

okay setProperty('ratingsData[0].image', 'image') --change "Sick" image dosen't work uh... Do I need to download something?????????????????

That's not what they asked for
setProperty('ratingsData[0].image', 'image') --change "Sick" image

Read the commit changes for more info

I thought this was only possible in source 0-0

That's not what they asked for
setProperty('ratingsData[0].image', 'image') --change "Sick" image

Read the commit changes for more info

I thought this was only possible in source 0-0

pretty sure shadow mario added it recently


feat: Add plugin from ref

Closes #7368, closes #6615

@edgarrmondragon Do you mind taking a look at why these new tests might be failing if you have some free time? They fail intermittently locally as well, where the cli_runner result stdout and stderr are empty strings. Ideally would like to revert https://github.com/meltano/meltano/pull/7907/commits/60192add6a1707c26276fe412a78a8360df90636, which I pushed since that assertion also seemed indeterministic (exit code of 1 or 2 between runs).

@edgarrmondragon Do you mind taking a look at why these new tests might be failing if you have some free time? They fail intermittently locally as well, where the cli_runner result stdout and stderr are empty strings. Ideally would like to revert 60192ad, which I pushed since that assertion also seemed indeterministic (exit code of 1 or 2 between runs).

@ReubenFrankel Without diving much deeper, is it possible that something is persisted between tests and that's causing the flakiness?
Since we randomize the order of tests, we have run into that problem and the workaround is to make certain tests run in a set order:
https://github.com/meltano/meltano/blob/b2cd4f7860edffac37047ed477a40478b76e596a/tests/meltano/cli/test_add.py#L32

@edgarrmondragon Alright thanks, I'll take a look. :slightly_smiling_face:

@edgarrmondragon I think this is ready for review now (pending docs changes once behaviour is finalised), whenever you have some time. :slightly_smiling_face:

Since discovery functionality has been removed for upcoming v3 release, REQUEST_TIMEOUT_SECONDS constant is no longer available after merging. Instead I just replaced it with a hard-coded value of 10 seconds - is there something else common I can use here?
https://github.com/meltano/meltano/pull/7907/commits/661030273e9a5a1ca42d50e630e0a5fea9989917#diff-3916f7d151c1573e41e141d322bb79fe11845771f00335727d7f19715ecb8b49L41

@edgarrmondragon I didn't really think about that - I agree it would be easier just to re-run the same command, but does that not go against the principles of meltano add? Thinking about plugins added from the Hub (non-custom): these come with a .lock file after meltano add, and thenmeltano lock --update to update. I suppose this use-case is a bit different because we are dealing with  custom plugins, where the plugin definition is only in the meltano.yml (i.e. no .lock file)...
I think that it might be confusing for users if --from-ref was to bypass the
Extractor 'tap-spotify' already exists in your Meltano project

behaviour, where all other ways of using meltano add do not.
That being said, I don't really have any immediate ideas, but it would be great to update a custom plugin in this way. What do you think?

Also, if .lock files are required as of Meltano v3, does this feature work then? Or is that only enforced for non-custom plugins?

Or is that only enforced for non-custom plugins?

That's correct

That being said, I don't really have any immediate ideas, but it would be great to update a custom plugin in this way. What do you think?

@ReubenFrankel do you mean meltano lock --update? Then, --from-ref would need to add a lockfile instead of inlining the plugin definition, and the plugin entry in meltano.yml would have to store the --from-ref value so meltano lock --update behaves consistently. Wdyt?

@edgarrmondragon I was referring to the concept of updating custom plugins only, but I guess it could work with meltano lock... Though, I was under the impression that .lock files were reserved for plugins coming from the Hub only - we would have to add an optional ref property for plugins in the meltano.yml like you say.

@edgarrmondragon I was referring to the concept of updating custom plugins only, but I guess it could work with meltano lock... Though, I was under the impression that .lock files were reserved for plugins coming from the Hub only - we would have to add an optional ref property for plugins in the meltano.yml like you say. I don't know if that is too much of a change to warrant adding this feature though?

@ReubenFrankel yeah, I think there's 3 types of plugins with different expectations and flows:

100% custom plugins: the user is not currently interested in publishing it to the Hub. Updates to settings, etc. are done manually in meltano.yml
Hub plugins: these are Hub (Meltano's or a private one) plugins that the user can and want to be updated from upstream definitions.
Ref plugins (this PR): users want to test a plugin definition they're in the process of adding to the Hub, and they want to update the local definition after changes are made to the upstream plugin, e.g. after PR feedback in the Hub. With the current state of the feature, they'd need to do manual changes to meltano.yml to get those changes.

Do you think the last one above makes sense, or perhaps I'm missing something?
cc @pnadolny13 in case you have thoughts on this feature

@ReubenFrankel @edgarrmondragon I'm trying to catch up on this feature. Is my understanding right that its basically taking a meltano.yml from the tap repo and merging it into your main meltano project? Makes sense to me. I'm not sure what the normal workflow is for other users but I generally dont consider the meltano.yml in my tap repo as the source of truth (maybe thats the wrong way to think 😭 ).

maybe helps move towards a model where the plugin definition lives in the source repository - similar to how dbt Hub works IIRC (if that's something you guys are interested in)

The only challenge with having the plugin definition live in the repo is that its formatting and content are based on what the hub needs so if that changes over time we'd need to update every plugin repo to implement it. I've been thinking more along the lines of a scraping the SDK --about settings and generating a hub definition from that, so the tap is decoupled from the hub syntax.

With the current state of the feature, they'd need to do manual changes to meltano.yml to get those changes.

Or meltano remove, then meltano add --from-ref again. Otherwise, I think you covered it. Is there an argument for meltano add --force here though?

Is my understanding right that its basically taking a meltano.yml from the tap repo and merging it into your main meltano project?

@pnadolny13 rather it takes a YAML file in the format the hub expects for a plugin.

I've been thinking more along the lines of a scraping the SDK --about settings and generating a hub definition from that, so the tap is decoupled from the hub syntax.

I think this feature could be downstream from that:

Scrape a Hub definition from the JSON output of --about and save as my_plugin.yml
Add it to a project with meltano add extractor my-plugin --from-ref ./my_plugin.yml to test the definition with Meltano

Or meltano remove, then meltano add --from-ref again. Otherwise, I think you covered it.

Thanks @ReubenFrankel!

Is there an argument for meltano add --force here though?

Maybe 🤔. If it doesn't blow the scope of this PR, perhaps --force could tell Meltano to replace the plugin if it exists.

Scrape a Hub definition from the JSON output of --about and save as my_plugin.yml

Maybe an SDK enhancement to add --format yaml? Of course, that would require plugin to update its project SDK version (or built with the SDK to begin with).

perhaps --force could tell Meltano to replace the plugin if it exists.

I think this is my preferred approach. I'm imagining --force just adds a plugin regardless of it already exists in the project or not, meaning that for existing plugins the meltano.yml entry is replaced - for non-custom plugins, the .lock file would also be regenerated. I guess you could think of this like the behaviour you would expect from running meltano remove into meltano add. That feels like a separate PR though?

I think this is my preferred approach. I'm imagining --force just adds a plugin regardless of it already exists in the project or not, meaning that for existing plugins the meltano.yml entry is replaced - for non-custom plugins, the .lock file would also be regenerated. I guess you could think of this like the behaviour you would expect from running meltano remove into meltano add. That feels like a separate PR though?

@ReubenFrankel Yeah, let's create a separate issue for meltano add ... --force and document for this feature how to re-add a ref plugin.

@ReubenFrankel Pending docs but the behavior here lgtm!

@edgarrmondragon Awesome! Thanks for your feedback as always. :smile:


UX Researcher: Creating Interview Script - Batch 1: Roles and Team Needs

I am going to modify my base interview questions and scope them down to create an interview script for the interviews with our primary users: Jeremy and Allen.
This portion of the interview script will focus on user roles and team needs. #294
Feature: Create interview script for user interviews with Jeremy and Allen
  As a UX researcher
  I want to create an interview script from my list of interview questions crafted for the CMS UX that is catered to the role of the specific interviewee around understanding their team roles and needs
  So that I can make sure to ask the interviewee specific questions that will be relevant to their role and their team

 Scenario: Craft interview script for Jeremy
    Given that Jeremy will be the main user entering in marketing content into our CMS
     When I go to craft his interview script centered around his role and this team needs
     Then I will able to ask Jeremy the questions that will allow me to gather data to understand the marketing team structure
      And his role
      And the roles present on the team
      And the ways roles report to and interact with each other
      And the type of work that each role does
      And the way the team communicates with each other
      And the teams' needs / expectations from using a CMS

Scenario: Craft interview script for Allen
    Given that Allen will be the main user entering in ID content into our CMS
     When I go to craft his interview script centered around his role and this team needs
     Then I will able to ask Allen the questions that will allow me to gather data to understand the ID team structure
      And his role
      And the roles present on the team
      And the ways roles report to and interact with each other
      And the type of work that each role does
      And the way the team communicates with each other
      And the teams' needs / expectations from using a CMS

Research Interview Script

[ ] Create interview script for Allen around understanding roles and team needs
[ ] Create interview script for Jeremy around understanding roles and team needs

User roles + team mgt (#294)
(Approval) workflows (#296)
Content creation (#301)
Editing content (#295)

Content types (understanding/navigating to content types) (#297)
Alerts + notifications (#300)
First time experience on the CMS (#341)
Searching for content (#299)

@ineedsubstance @joshkimmell @poofichu @Snugug @scottnath @SirSpidey
Rewrote this story as well and scoped it to a research topic and added it to that specific epic. Let me know your thoughts and if this story makes sense.
If you review this one and #397 they are very similar - except this one is centered around the interview script I will be using in my interview.

@mkiang3051 - I think this is good and clear. I would suggest adding this as a blocker to #397 as this needs to be done first before the actual interview.

@ineedsubstance Thanks for reviewing! And good suggestion. I'll add the blocker marker.

As @ineedsubstance stated, this is a blocker for #397

Link to interview script on Box: https://ibm.box.com/s/3qcrna0siatds3c9lme34ebm6k1i1yad

This is done.


Feature/mst storage

What is this pull request?
This pr provides effective implementation of storage to multi-signature propagator.
Why do you implement it? Why do we need this pull request?
For multi-signature propagation required save a state of current and other peers for effective sharing. This pr provides storage for those states and availability to make diffs and merges on them.
Additional

Implementation is thread-safe
Used NVI idiom for interface of storage
Common use cases covered by tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/mst-trunk@deeb0d6). Click here to learn what that means.
The diff coverage is 34.24%.

@@                 Coverage Diff                  @@
##             feature/mst-trunk     #599   +/-   ##
====================================================
  Coverage                     ?   44.61%
====================================================
  Files                        ?      280
  Lines                        ?    11398
  Branches                     ?     6049
====================================================
  Hits                         ?     5085
  Misses                       ?      755
  Partials                     ?     5558

Impacted Files
Coverage Δ

...had/multi_sig_transactions/storage/mst_storage.hpp
0% <ø> (ø)

...odule/irohad/multi_sig_transactions/state_test.cpp
3.12% <ø> (ø)

...rohad/multi_sig_transactions/storage/mst_state.hpp
83.33% <ø> (ø)

...ule/irohad/multi_sig_transactions/storage_test.cpp
24% <24%> (ø)

...sig_transactions/storage/impl/mst_storage_impl.cpp
25% <25%> (ø)

...ulti_sig_transactions/storage/mst_storage_impl.hpp
33.33% <33.33%> (ø)

...ulti_sig_transactions/storage/impl/mst_storage.cpp
36.36% <36.36%> (ø)

...irohad/multi_sig_transactions/mst_test_helpers.hpp
64.28% <64.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deeb0d6...e2c7f17. Read the comment docs.


CBiRRT fails unit tests on Travis

All of our calls to CBiRRT fail with this error message:
Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/home/travis/workspace/src/prpy/tests/planning/methods/PlanToEndEffectorPose.py", line 42, in test_PlanToEndEffectorPose_StartInCollision_Throws
    self.planner.PlanToEndEffectorPose(self.robot, goal_ik)
  File "/home/travis/workspace/src/prpy/src/prpy/planning/base.py", line 153, in __call__
    return call_planner()
  File "/home/travis/workspace/src/prpy/src/prpy/planning/base.py", line 133, in call_planner
    *args, **kw_args)
  File "/home/travis/workspace/src/prpy/src/prpy/planning/cbirrt.py", line 89, in PlanToEndEffectorPose
    return self.Plan(robot, tsr_chains=[tsr_chain], **kw_args)
  File "/home/travis/workspace/src/prpy/src/prpy/planning/cbirrt.py", line 194, in Plan
    self.env.LoadProblem(self.problem, robot.GetName())
openrave_exception: openrave (Assert): [/usr/include/boost/smart_ptr/shared_ptr.hpp:653] -> typename boost::detail::sp_member_access<T>::type boost::shared_ptr<T>::operator->() const [with T = OpenRAVE::IkSolverBase; typename boost::detail::sp_member_access<T>::type = OpenRAVE::IkSolverBase*], expr: px != 0

I don't think I've ever seen this error message before. @cdellin, any ideas?

Hmm, I expect this is happening here [0]. Was GeneralIK built and available as an OpenRAVE plugin on the machine where the test was run?
[0] https://github.com/personalrobotics/comps/blob/master/cbirrt2/cbirrtproblem.cpp#L111

That was going to be my suggestion too. Spot on @cdellin.

Good call @cdellin and @siddhss5. CBiRRT did not <run_depend> on GeneralIK, so it was never being built. I fixed this in https://github.com/personalrobotics/comps/commit/b1763f9155b47758c27474d48148098e1ab81a08.


DateTime in Indonesian/Jakarta timezone not displaying correctly for Jan 1, 1964

I'm not sure where this exactly goes, but the docs seem to indicate that DateTime is a dart:core feature.
In the Flutter DatePicker widget, we make use of the DateTime API to get the dates for the calendar widget population. It seems to work in all other timezones, except for Indonesia/Jakarta (GMT+7), for a very particular date (Jan 1, 1964). A reproducible sample is to set the native device/platform's timezone to Indonesia/Jakarta, and then:
void main() {
  print(DateTime(1964, 1)); // 1963-12-31 23:30:00.000
}

Basically, instead of yielding 1964-01-01 00:00:00.000, it results in a time 30 minutes prior.
Related Flutter issue: https://github.com/flutter/flutter/issues/74303

According to the time zone data they changed from GMT+7:30 to GMT+7 on that particular date. That's why it is 30m off.
/cc @lrhn to confirm.

According to the time zone data they changed from GMT+7:30 to GMT+7 on that particular date. That's why it is 30m off.
/cc @lrhn to confirm.

That could very well be the reason, yes.
If they changed their time zone from GMT+7:30 to GMT+7 at the end of 1963-12-31(GMT+7.30), then the moment 1964-01-01T00:00:00 in GMT+7.30 is also 1963-12-31T23:30:00 in GMT+7.
I do think it's a little weird that we don't simply choose 1964-01-01T00:00:00 GMT+7 as the local time (which is half an hour later). I don't actually know how we create local-time dates, it's based on the time zone information provided by the underlying platform.

That could very well be the reason, yes.
If they changed their time zone from GMT+7:30 to GMT+7 at the end of 1963-12-31(GMT+7.30), then the moment 1964-01-01T00:00:00 in GMT+7.30 is also 1963-12-31T23:30:00 in GMT+7.
I do think it's a little weird that we don't simply choose 1964-01-01T00:00:00 GMT+7 as the local time (which is half an hour later). I don't actually know how we create local-time dates, it's based on the time zone information provided by the underlying platform.

Would it be possible to change it to choose 1964-01-01T00:00:00 GMT+7 over 1963-12-31T23:30:00 in GMT+7?

Would it be possible to change it to choose 1964-01-01T00:00:00 GMT+7 over 1963-12-31T23:30:00 in GMT+7?

We are trying to match the JavaScript Date constructor behavior here, so it's not clear how much we can afford to deviate.
It's probably possible to do something different (although I can't guarantee that there won't be some time zone transition which makes it completely undecidable what to do). Maybe can do binary search for a time where the time-zone offset precisely matches the millisecond difference from UTC time.
It would probably add some overhead to every other DateTime construction, though.

We are trying to match the JavaScript Date constructor behavior here, so it's not clear how much we can afford to deviate.
It's probably possible to do something different (although I can't guarantee that there won't be some time zone transition which makes it completely undecidable what to do). Maybe can do binary search for a time where the time-zone offset precisely matches the millisecond difference from UTC time.
It would probably add some overhead to every other DateTime construction, though.

I have changed the computation to work better with non-1-hour offsets. It should be part of the next Dart stable release, and is already on the dev channel.

No further plans here.


can you please update this article to the latest version of MSAL.NET

good day.. can you please update this article to the latest version of MSAL.NET.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2333c6b-140e-6cc8-91ad-00e47935bc6b
Version Independent ID: 738f87e1-d839-62f7-0c5c-6562b39e8d1c
Content: Azure AD v2.0 UWP getting started
Content Source: articles/active-directory/develop/tutorial-v2-windows-uwp.md
Service: active-directory
GitHub Login: @andretms
Microsoft Alias: andret

@kalyanimath
Thanks for your feedback! We will investigate and update as appropriate.

@MarileeTurscak-MSFT - Hello. Can you please reassign this to @jmprieur? He's our PM owner for MSAL.NET and I've sent him email about this issue. Thank you.

Hello @kalyanimath - Our PM, @jmprieur , has updated the docs to align with the latest MSAL.NET release. These updates are now live. Thank you.

Updated content is now live. #please-close

@kalyanimath We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


ModuleNotFoundError: No module named 'dlio_benchmark'

Installing this for the first time so forgive my ignorance here.
I'm deploying to physical Ubuntu 22.04.3 LTS hosts with python 3.10.12
From a clean install I'm running the following steps:
git clone https://github.com/argonne-lcf/dlio_benchmark
cd dlio_benchmark/
python3 -m pip install .
dlio_benchmark ++workload.workflow.generate_data=True

However, the invoking dlio_benchmark delivers a traceback:
apatt@server-12:~/github/dlio_benchmark$ dlio_benchmark ++workload.workflow.generate_data=True
Traceback (most recent call last):
  File "/home/apatt/.local/bin/dlio_benchmark", line 5, in <module>
    from dlio_benchmark import main
ModuleNotFoundError: No module named 'dlio_benchmark'

Poking around Google (and even some hunting through the forrest of ChatGPT responses) did not yield any solid leads.
Not sure where to go from here. Before I go mucking about with .pth files and the like just want to know if I'm overlooking something simple.

@jedimt
for debugging purposes, can u give output for the following
which python3
python3 --version
python3 -m pip --version
which dlio_benchmark
echo $PYTHON_PATH
and
 python3 -c "import site; print(site.USER_SITE)"

@jedimt Is this still an issue?

Closing due to no activity. Please create a new issue if this is still an issue.


Path to improving extstore's defaults

Extstore shouldn't be compile gated anymore. This would simplify the code by cutting out ifdef's. There're a few things holding me back..

[x] A performance comparison, since it adds some branches to hot paths. (this can be made neutral via changes to the way add_iov() is used)
Note: changes staged in next fix this! lots of branches removed from the hot paths.
[ ] A better answer to the memory allocation hurdles.

To the second point: TL;DR: small normal items and small item HDR's take up space in the same slab classes/LRU's. Small items can't/won't be flushed to disk. This has some side effects:

workloads with mixed small/large items, with zero-expiry, will end up with low/no memory for larger items, causing aggressive flushing in extstore.
unexpiring small items can cause HDR's to be evicted when there's plenty of extstore disk space free.
The RAM-cache of large objects will shrink over time, increasing disk pressure for writes and reads.

These are non-obvious to a user and may be surprising. Hopefully this issue can be a discussion but I won't be surprised if it's just me talking to myself for a month again :)
Ideas:

Raise aggressiveness of disk flushing... People often run extstore with almost no RAM cache regardless.
Add a slab-balancer-algorithm cap for small vs large items. Default in the range of 50-90% small?
Find some way of separating the HDR's into a different LRU? We've already used up the possible four, but HOT|WARM could repurpose here.
Use LRU crawler to sort or prioritize HDR vs non-HDR objects.
The above options could be used to prioritize HDR objects when extstore has a lot of empty space. We should allow memory space to small items if extstore is like 90% full anyway.
Any other ideas? :(

Most of these requires making a decision on the importance of a small item vs a HDR item, which is impossible to do generically. For extstore's case the "most generic" we can go is ensuring some space is reserved for large objects so the system doesn't thrash; with perhaps an option allowing for "prioritize using memory to fill extstore" vs "treat all objects equally".
The fewer options/twiddles and better defaults the.. better.

Honestly after the performance fixes I'd rather just build it in by default by leave it marked experimental. Then we can incrementally improve the memory situation.

note to self: check if it would be crazy for the extstore code to issue flushes inline with the eviction code, or wake and temporarily block on the bg thread where possible.
the code is mainly tuned to "never degrade set performance" but the flush performance is generally a write to RAM anyway, so it might make a better default to at least try so long as the performance drop isn't huge.
On a quick look it might not be too bad...

The storage bg thread just loops through the slab classes and if too few free chunks exist, flushes until we're back above threshhold. It calls storage_write()
storage_write() pulls the tail item, checks if it's valid to throw out (not a HDR item, age is above item_age, etc), then alloc's a HDR item and chucks it.
normal set-with-eviction has a retry loop built in because when I re-wrote the LRU there was no longer a way of directly reusing freed memory. There is a mechanism for that now (LRU_PULL_ITEM_RETURN) which can be expanded a bit.
Caveat: storage_write() fails while the write buffer is full and flushing to disk. For a while I had multiple write buffers but the code was awful and buggy. Might need to either revisit this or figure out how to at least have two write buffers so they can be swapped.

So on the cost of slightly increasing the inline set latency we could have the BG thread try to maintain some free space, but bottoming out just force-flushes and directly reclaims memory.
This would alleviate a lot of the holes in the flushing algorithm that currently require careful tuning.

Lets put this together for a potential general simplification:

hoist the page mover logic slightly: for each chunk to be tested, move function must be called with a free chunk to swap one piece of memory into if necessary.
caller page mover thread uses item_allocish() to get the free memory. Manages if necessary: retries if chunk was within page to move, retries or sleeps if tail locked, etc.
page mover function uses this free memory to swap an item if necessary, removing the _nomem case entirely.

next:

main item_allocish() logic can flush to extstore directly if necessary.
beware of causing a looped alloc!
extstore needs multiple (at least two) wbuf's per bucket so one can be flushed to disk while another is written to.
main allocish() flushing directly covers sets as well.

then for the automove algorithm:

The only goal of the mover algorithm now is to keep the global memory pool above a desired threshold. Currently it tries to maintain the global pool + a free chunk ratio per slab class.
If it is below the threshold, pick the highest non-HDR slab class with the most memory allocated and move a page.
This may still need a special case for the highest slab class (chunked items): need enough memory to hold at least two items of -I size.
Most of the free chunk balancing code can be deleted.
BG extstore flush thread removed?

Pros:

Re-arranges the "RAM buffer" used to avoid early evictions from free slab memory chunks across N classes to the size of the extstore write buffer.
Removes the ramp-up time necessary from the background thread. (going from idle to full throttle needs a few seconds of RAM buffer)
The time to swap and flush an extstore write buffer is dependent on the speed of the storage device vs various background threads which may be asleep.
Can maybe remove the storage flush thread entirely.

Cons:

Is still, at a high level, just moving the RAM buffers around. Fast enough bursts of writes will cause evictions unless wbuf is properly sized. Sizing wbuf requires a restart!
Set time will increase, as a lot more work will be guaranteed to be done inline with sets vs currently done on BG threads.
Might have to use a wide lock while writing to a particular write buffer, else ensure items are aligned to 8 bytes within the wbuf?

The set latency could be amortized slightly by having the lru_maintainer_thread() attempt to keep a couple chunks free per high slab class. Rather than have an entire thread for the extstore flushing still.
Notes:

any remote chance wbufs could be replace with bipbuffers? I assume finding an item stored in a bipbuffer would be nontrivial.
this might make a further change to separate HDR memory from main memory cleaner.

Feel like there's still a super corner case: All memory full, burst of writes bottoms out the spare pool buffer, then extstore needs some memory to allocate headers from.
Solution is more complicated though; maybe two spare page pools. Or, past the minimum spare pool, only small/HDR objects can cause memory to pull from the global pool. That should work actually. Else there's no point to flush-on-evict without some kind of spare memory for HDR objects.

Thought/refinement... if there's a clean way to decide during a SET on a high slab class that memory is low, it could evict->flush instead of pull from slabber. That avoids pushing on the global page pool and combined with the recent slab mover changes could work pretty well.
it might even be possible to do a decent pass at this with a single extstore write buffer; if the buffer is flushing to disk fall back to slab allocator temporarily. Then multiple write buffers fixes that/etc.
Still a series of not super quick changes. I'd first go for fixing the nomem case by having the mover require a free chunk passed into it. That's one of the last really dumb corner cases I've left in the system.

More thoughts:

Since extstore headers are marked by ITEM_HDR bit and only allocated in specific places, I could use a different or novel memory allocator for them.
A lot of the SET reliability problems could be amortized by allowing sets to queue when memory fills.

To explain: If a user tries to throw the same 1mb item into cache from 1,000 clients at the same time, we need 1 gigabyte of memory for all of the data uploads, then they just get rejected one by one after the first one succeeds.
Thus, if we bottom out of memory or otherwise cap "in-flight memory buffers", the sets can be thrown into a side queue (using the same queue system we use for extstore/proxy). As memory frees we pull from that set queue and read data from sockets/etc.
With this we can reliably accept sets by blocking them until resources become available, but not hang the worker threads so they're free to handles reads or process/queue other writes.

Note:
re-summarize the top post and delete comments. Since posting this some stuff was fixed (flush aggressiveness).
Current thinking:
First step: rewire page-mover to avoid nomem case by only moving forward with free memory chunk already in hand.

also make global page pool freeratio runtime tunable

Second step: when global pool is too low, broadcast to workers to switch to immediately pushing to extstore on all high class allocations.

balancer handles moving memory back to global pool by taking from the "most pages used" high slab class. That then re-distributes to low classes.
requires double extstore write buffers so one can be flushing while we write to another.
removes extstore flush thread to free us from all of its timing/polling/throughput weirdness.

Third step: reduce extstore item_hdr memory overhead from 12 bytes to 8 (tracked in another issue)

requires a handful of internal changes

Fourth step: dedicated slabber and LRU's for item header memory.

During above cleanups the slabber is cleaned of globals and turned into an object.
If extstore is enabled we create a dedicated slabber for item headers, with the max class size being very low so classes are very close together and memory overhead is very low.
make global page pool be external to the slabber (some tertiary service) (or something like this)
allow balancing pages of memory between the slabber instances, with % caps. IE: up to 90% in small item memory and then evict from those LRU's instead.
runtime tunables for the % split.

This would hopefully be minimal tunables and solve the issue of being unable to flush tiny items to extstore because they co-exist with item headers.


Adding Vision via Magic Item

Goggles of Night grant darkvision 60' if you don't have it or extend your darkvision to 120' if you do. Is it possible to detect this with vision 5e?

Add an active effect to this item:
system.attributes.senses.darkvision | Add | 60
I think the goggles in the 5e magic items compendium should already be set up like this.

That worked! The item in the SRD does not have that active effect.


ThriftConnectionPoolProvider.getConnection(ThriftServerInfo thriftServerInfo) should always throw exception

 /** {@inheritDoc} */     @Override     public TTransport getConnection(ThriftServerInfo thriftServerInfo){         try {             return connections.borrowObject(thriftServerInfo);         } catch (Exception e) {             logger.error("fail to get connection for {}", thriftServerInfo, e);             throw new RuntimeException(e);         }     }
Exception e in catch block is a checked exception and most likely to be TTransportException, we should rethrow it and dealing with it in ThriftClientImpl(remove TServerInfo with connection problem in ThriftConnectionPoolProvider and try to return valid connection from other TServerInfo),i will fork your code and try to fix as i wrote above.

You're right. welcome to pr.


Empty README in ATS attachments

@zwartd I have removed the README.md in ATS/howtos/attachments/getting-started/ (in this commit), because it was breaking our build. Any reason why that file was there? Just giving you a headsup, if it isn't a problem, I'll close the issue.

@JelteMX  ow sorry, it is a standard file created when i create a folder must have forgotten to remove it. It is not a problem, thanks for the heads up!


Can't select higher quality than 720p on some videos

Example video that triggers the issue: https://www.youtube.com/watch?v=OXR6g0Qwkqc
With YouTube Center (DEV edition v533) enabled:

After disabling YouTube Center:

You probably have dash playback disabled.

No, I have it enabled. It works on other videos.
On Sat, Oct 24, 2015 at 7:06 PM, LazyBoot<EMAIL_ADDRESS>wrote:

You probably have dash playback disabled.
—
Reply to this email directly or view it on GitHub
https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150834451
.

Maybe the video was just encoded at 720?
On Sat, Oct 24, 2015 at 1:18 PM, Romain Dal Maso<EMAIL_ADDRESS>wrote:

No, I have it enabled. It works on other videos.
On Sat, Oct 24, 2015 at 7:06 PM, LazyBoot<EMAIL_ADDRESS>wrote:

You probably have dash playback disabled.
—
Reply to this email directly or view it on GitHub
<
https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150834451
.

—
Reply to this email directly or view it on GitHub
https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150835029
.

Can you see the images in my original message? The video has 1080p60
available after disabling YTC. It may be DASH-related, but it's not because
I disabled it, it works fine on other videos.
On Sat, Oct 24, 2015 at 7:27 PM, Pontiac76<EMAIL_ADDRESS>wrote:

Maybe the video was just encoded at 720?
On Sat, Oct 24, 2015 at 1:18 PM, Romain Dal Maso<EMAIL_ADDRESS>
wrote:

No, I have it enabled. It works on other videos.
On Sat, Oct 24, 2015 at 7:06 PM, LazyBoot<EMAIL_ADDRESS>wrote:

You probably have dash playback disabled.
—
Reply to this email directly or view it on GitHub
<

https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150834451

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150835029
.

—
Reply to this email directly or view it on GitHub
https://github.com/YePpHa/YouTubeCenter/issues/2088#issuecomment-150835843
.

I reported this issue a while ago https://github.com/YePpHa/YouTubeCenter/issues/2079

Thanks, @Primeey. Closing issue as it is a duplicate of #2079.


[Template] template for GreptimeDB

What this PR solves / how to test
a new template for GreptimeDB
Author has addressed the following

Tests

[ ] TODO (before merge)
[ ] Included
[x] Not necessary because:

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[ ] Included
[x] Not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
[x] Not necessary because:

Thanks for the PR! Unfortunately moving forward we've removed the top-level /templates folder from this repo, and so I'm going to close this PR


Don't show signed addon warning if we're not signing (bug 1135926)

Fixes bug 1135926

@kmaglione, @clouserw r?

I'd much rather this be a validator flag to skip the tests rather than a filter in Olympia. But I guess since it's only temporary, it's not a big deal.
r+wc


Proposal

I looked at some of the previous projects and saw that they had question header. We can remove these headers if we want it to look more like Tiff's example repo.  I believe Fatime is working on Q1,2.
Also as I do this, I am not sure that a new branch is being created so we should double check that i think?

I thought we decided that I will be going to work on adding Usage, Dependencies, License, References sections in the readme.md, but I can work on Q-1,2 in addition to those.

No worries Fatime, I can work on q1 and 2 when I get home

On Nov 20, 2020, at 2:55 PM, Fatime Selimi<EMAIL_ADDRESS>wrote:

I thought we decided that I will be going to work on adding Usage, Dependencies, License, References sections in the readme.md, but I can work on Q-1,2 in addition to those.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sounds good @nphaterp, thanks!

Ok I added responses for Q1 and Q2.  I also followed up on the changes that Tanmay suggested

LGTM!

Already included relevant sections and details in the Readme.md. Hence, closing the PR.


Add PID and port parsing to OSX

This commit changes 2 things for OSX ('darwin'):

Make netstat output the PID with the -v argument (and parse the
PID in lib/parsers)
Make lib/utils.parseAddress handle OSX addresses (which have the
strange format ip.addr.port, e.g. <IP_ADDRESS>.22)

Additionally, this commit fixes a bug when setting the "limit" option:
The filters.limit function was not being passed a "stop()" function,
which caused it to throw an error when trying to call stop() after
the limit was reached.
Also, because module.exports was reassigned in lib/netstat.js:25, the
exports at the bottom were not being exported. The fix is to assign
them to module.exports.

Thanks for the submission! Everything looks good; nice catch on the module.exports issue.

Released in v1.2.0

Thanks for the quick merge!


⚠ Bofrost.at has degraded performance

In 7c97111, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1108 ms

Resolved: Bofrost.at performance has improved in 779fb21.


API instead of using config file

Is it possible to use environment variables or an API instead of a configuration file for passing the account key and the remote and local.

good suggestion. usually, sas token is recommended, rather than the key. currently, it is not supported through environment variables as the tool is primarily designed for multiple storage accounts; multiple correspondence between remote and local. feel free to suggest any idea on the signature you expect.


ch13 Improve proxy w/YARP

added with https://github.com/dabedin/Practical-Microservices-with-Dapr-and-.NET-Second-Edition/commit/fd20ce5772446917a4842406c4bc947edd063bf8

To change in ch13


Confirming Phone number throws an an error

When I attempt to confirm a phone number change with a verification code using
await _userManager.ConfirmPhoneNumberAsync(user, code)
I receive the following error:
NullReferenceException: Object reference not set to an instance of an object.
Amazon.AspNetCore.Identity.Cognito.CognitoUserStore<TUser>.VerifyUserAttributeAsync(TUser user, string attributeName, string code, CancellationToken cancellationToken)
Client.WebApp.Controllers.AccountController.Confirm(Confirm model) in AccountController.cs
+
                        result = await _userManager.ConfirmPhoneNumberAsync(user, model.Code).ConfigureAwait(false);
Microsoft.AspNetCore.Mvc.Internal.ActionMethodExecutor+TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, object controller, object[] arguments)
System.Threading.Tasks.ValueTask<TResult>.get_Result()
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeActionMethodAsync()
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeNextActionFilterAsync()
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
NToastNotify.NtoastNotifyAjaxToastsMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
Microsoft.AspNetCore.Builder.UseMiddlewareExtensions+<>c__DisplayClass5_1+<<UseMiddlewareInterface>b__1>d.MoveNext()
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

The user manager, user and code are all valid and it appears its blowing up trying to verify the phone attribute, but that exists too in my user below:

FYI, the call ConfirmEmailAsync also produces the same error

Also I need a way to resend the phone and email change confirmation codes like you did with the ResendSignupConfirmationCodeAsync option.  If I try to call the  SendEmailConfirmationTokenAsync or SendPhoneConfirmationTokenAsync, they throw the and error:
NullReferenceException: Object reference not set to an instance of an object.
Amazon.AspNetCore.Identity.Cognito.CognitoUserStore<TUser>.GetUserAttributeVerificationCodeAsync(TUser user, string attributeName, CancellationToken cancellationToken)
Wamba.Client.WebApp.Controllers.AccountController.Login(Login model) in AccountController.cs
+
                        var result2 = await _userManager.SendEmailConfirmationTokenAsync(user).ConfigureAwait(false);
Microsoft.AspNetCore.Mvc.Internal.ActionMethodExecutor+TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, object controller, object[] arguments)
System.Threading.Tasks.ValueTask<TResult>.get_Result()

You are using the correct API, but your CognitoUser instance probably does not have a session token object populated.
This Cognito api can only be called with a Cognito logged-in user.
Try setting up the token on the user (by signing in, or retrieving the token on the context).
H.

I am signed in, I used the _signInManager.PasswordSignInAsync method and its not populating the session of the cognito user.  If I retrieve the user, right after the call above and check the cognitoUser. SessionTokens, its null.  Im I not doing something correct?  When you say retrieving the token on the context, Im not sure what you mean

You don't need to retrieve it, you can use the same instance as it gets updated.

You can get the access token of the currently signed in user by calling HttpContext.GetTokenAsync("access_token")

Maybe I am misunderstanding the process of logging in.
I use _signInManager.PasswordSignInAsync, its gives me a SUCCEEDED response.
How do I retrieve the CognitoUser immediately after that which has a session object populated?
When I am on other pages, I have been using:
     `var user = await _userManager.GetUserAsync(User).ConfigureAwait(false);`

where User is the HttpContextUser value.  From what I am feeling in my code, this is not the correct method.  IS there a difference between a user being signed in and authenticated.
I think I am misunderstanding the flow of the login and how to easily retrieve the cognito user properly.

There is an overload on PasswordSignInAsync that allows you to sign in with a CognitoUser object. this object will get tokens populated once signed in.
Example:
var user = await _userManager.FindByIdAsync(Input.UserName);
 var result = await _signInManager.PasswordSignInAsync(user, Input.Password, Input.RememberMe, false);

Ok I was able to login a user in with a populated session as you stated above, but here is my dilemma.  I then move to the profile page after logging in, HOW do I get that same user back with a populated session so I can call _userManager.ConfirmPhoneNumberAsync(user, code).  I have to have a session in place on the CognitoUser for this to happen but if I call var user = await _userManager.GetUserAsync(User), I get back a user without a session.  Now you say call the HttpContextObject to retrieve the tokens, but how to I populate the CognitoUser with those.  I can get them from HttpContext.GetTokenAsync("access_token") but that does me no good as I need them to be populated in the CognitoUser before I pass it to several procedures that require a logged in user.

Hi @jlwhitfill,
I know have a better grasp of your issue. I am thinking of a change that would automatically populate the tokens if you are on a different webpage than the initial one.
This is a difference due to the nature of Cognito vs SQL Server. SQL Server has the tokens in the table, so each time you query FindById() for instance you get a set of tokens if availables.
I will let you know how my testing goes.
H.

Right as the original base Identity works differently than Cognito.   Your change would be perfect and Im glad you understand, I was starting to pull my hair out as I need that session available on most pages either for congito functions for to retrieve the access token for my Lambda function calls.  Can you make it populate the tokens anytime I do ANY find by?  e.g. FindByEmail, FindById, etc?

Yes that's what I plan to do

https://github.com/aws/aws-aspnet-cognito-identity-provider/pull/64

Thanks Ill wait for the approval, merge and subsequent build

Hi,
<IP_ADDRESS> Should fix the issue.
https://www.nuget.org/packages/Amazon.AspNetCore.Identity.Cognito/<IP_ADDRESS>


Stream::print might only partially write to the stream

Problem
Since Stream::print uses Stream::write, it might only partially write to the stream and there's no good way to know if it was only partially written.
Solution

Print returns number of bytes written
Print uses writeExact instead

Context
Stream::write returns number of bytes written, Stream::writeExact might call Stream::write many times and returns a boolean on whether writing was successful.

I'm thinking solution 2., but do we want print to return a boolean?
If no how will we know if there was an error?
If yes what do we do in more complex printing like Stream::printf?


Update Kubernetes tests to properly handle endpoints not existing

In #1295 I introduced a temporary work around, this issue is for removing that and cleaning up the tests that break.
The code that originally causes the issue is this:
func (c clientMock) GetEndpoints(namespace, name string) (*v1.Endpoints, bool, error) {
	if c.apiEndpointsError != nil {
		return &v1.Endpoints{}, false, c.apiEndpointsError
	}

	for _, endpoints := range c.endpoints {
		if endpoints.Namespace == namespace && endpoints.Name == name {
			return endpoints, true, nil
		}
	}

	return &v1.Endpoints{}, true, nil
}

The final return has true as the second value being returned even if no endpoints for the service were found. This means the tests never hit the code path for !exists here: https://github.com/containous/traefik/blob/master/provider/kubernetes.go#L240
Instead what happens is all the tests that don't specify endpoints go through and hit the code path for len(endpoints.Subsets) == 0.
We need to update the mock GetEndpoints function to return false for the second return value when no endpoints are found, fix all the tests that break, and then ensure that there is a test that tests the current code path being used.
Here are the tests that fail when the GetEndpoints function returns correctly: TestHostlessIngress, TestLoadMultipleNamespacedIngresses, TestLoadNamespacedIngresses, TestGetPassHostHeader, TestOnlyReferencesServicesFromOwnNamespace, TestLoadIngresses
Related to this is defining and possibly changing what happens when endpoints are not found. Currently when a service is not found the referencing frontend is removed. However if no endpoints are found we still keep the frontend. Should we be removing the frontend if no endpoints are found?

Superb issue description, appreciated!

Looks like #1462 is now covering the endpoints-not-found case.


feat: add .rename method

Closes #10

:tada: This PR is included in version 0.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update license file: year and owner

TODO
Update the license file. See year and owner - https://github.com/snowdrop/java-buildpack-client/blob/main/LICENSE#L189

Done


Bug: get_template_tcb() highlight not showing

The server sends a list of ranges to be highlighted as part of the response. Highlighting of the ranges is broken.
vscode:

ng.nvim

Not sure how valuable this could be (given this is a rarely used command). Will table this for now.


[Bug]: Cannot assign to read only property 'performance' of object '[object global]' on Node 20

Version
29.7.0
Steps to reproduce

Setup Node 20
Create test
Use jest.useFakeTimers
Run the test

Expected behavior
Jest runs the test and mock the timers and I can set my own time
Actual behavior
Test fails with
TypeError: Cannot assign to read only property 'performance' of object '[object global]'
jest.useFakeTimers().setSystemTime(new Date('2022-06-06'));
    ^

Additional context
On Node 18 is OK, upgrading to Node 20 causes issues both locally and on CI
Related to: https://github.com/facebook/react-native/issues/35701
Environment
System:
    OS: macOS 14.0
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 20.10.0 - /private/var/folders/_3/ggprgl2s3dg02ll3pgymf2280000gn/T/xfs-bffabcd0/node
    Yarn: 4.0.1 - /private/var/folders/_3/ggprgl2s3dg02ll3pgymf2280000gn/T/xfs-bffabcd0/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  npmPackages:
    jest: ^29.7.0 => 29.7.0

That's a link to this very issue.
But again, please put together a reproduction. "+1" doesn't really help us

Sorry my mistake. I have updated the link.

I have created a reproducible repo here: https://github.com/satazor/jest-issue-14741. The issue only happens in Jest v28 and not in the latest v29.

v28 is unsupported


Enforce stack manipulation

Many operations could benefit from automatic stack parameters and outputs handling. It makes their implementation more declarative and much shorter, and reduces chances to make a mistake.
Furthermore, this PR updates golden tests to work with starknet contracts. Running is out of question for now, but we do check them against golden files and check that they compile.

Looks good to me


refactor: use action/reducer for static content

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Backups that fail to upload to object storage are marked as 'Completed'

A user reported that a backup had a phase of Completed but the target object storage bucket was empty. Upon investigation, Ark was getting access denied errors when connecting to the bucket, so it couldn't upload. We set the backup phase to Completed before uploading (see https://github.com/heptio/ark/blob/master/pkg/controller/backup_controller.go#L359). We should probably check for errors uploading, and change it to Failed if there are any.
Note that the phase should be Completed before json-encoding it for upload, so that the JSON in object storage (if it uploads successfully) has the right phase.

@nrb this would be a good one to tackle if you have bandwidth! I can provide more context if needed.

@nrb & I figured this out. It turns out that with Google's go API for cloud storage, writes are async, and the only correct way to check for a write failure is to call Close() on the Writer and check the error it returns. @nrb is working on a fix with updated unit tests.

(We were deferring the Close() call and ignoring the error)


DEV: Remove hardcoded Ruby GC tweaks

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

While working on a minimal repro to fill the issue, found it was already reported at
https://bugs.ruby-lang.org/issues/19284

@xfalcox I guess this was resolved upstream? Good to close?

@xfalcox I guess this was resolved upstream? Good to close?

Upstream learned to ignore when the values are invalid.


release body after send changed body to downstream failed

Fix #1520 request failed

@spencergibb  Yes, I add two tests only for line coverage, now i add a test for body release.
	@Test
	public void modifyRequestBodyRelease() {
		for (int i = 0; i < 10; i++) {
			testClient.post().uri("/post").header("Host", "www.modifyrequestbodyssltimeout.org")
					.header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_XML_VALUE)
					.body(BodyInserters.fromValue("request")).exchange().expectStatus()
					.isEqualTo(HttpStatus.INTERNAL_SERVER_ERROR);
			long usedDirectMemory = PlatformDependent.usedDirectMemory();
			Assert.assertTrue(usedDirectMemory < 2 * 10 * 10 * 1024 * 1024);
		}
	}

@spencergibb  I found that it work fine with jdk10

So I commented out the fix
if (outputMessage.isCached()) {
    return outputMessage.getBody().map(DataBufferUtils::release)
        .then(Mono.error(throwable));
}

and the tests still pass.
The tests should fail without the fix.

@spencergibb  I found that it work fine with jdk10

@spencergibb I have changed code, why the label still is waiting for feedback?

Cherry-picked to 2.2.x and merged forward to master via e0a78c81f1a6a89488467102120535a2b6358ced


Select arrow doesn't hide the content when direction is different

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue

Reduced test cases
The page and Bootstrap are LTR and the select field is RTL:
<!doctype html>

    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>Bootstrap demo</title>
    <link<EMAIL_ADDRESS>rel="stylesheet" integrity="sha384-rbsA2VBKQhggwzxH7pPCaAqO46MgnOM80zW1RWuH61DGLwZJEdK2Kadq2F9CUG65" crossorigin="anonymous">

Bootstrap LTR

      Select menu LTR
      <select class="form-select" id="exampleSelect">
        <option selected>Open this select menu</option>
        <option value="1">One</option>
        <option value="2">Two</option>
        <option value="3">Three</option>
      </select>

      Select menu RTL
      <select class="form-select" id="exampleSelect2">
        <option selected>Open this select menu</option>
        <option value="1">One</option>
        <option value="2">Two</option>
        <option value="3">Three</option>
      </select>

The page and Bootstrap are RTL and the select field is LTR:
<!doctype html>

    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>Bootstrap demo</title>
    <link rel="stylesheet"<EMAIL_ADDRESS>integrity="sha256-+bNAolFvt6YB2LgXdEQJhKQUw4T0XbrBxLf0lH4NYDo=" crossorigin="anonymous">

Bootstrap RTL

      Select menu RTL
      <select class="form-select" id="exampleSelect">
        <option selected>Open this select menu</option>
        <option value="1">One</option>
        <option value="2">Two</option>
        <option value="3">Three</option>
      </select>

      Select menu LTR
      <select class="form-select" id="exampleSelect2">
        <option selected>Open this select menu</option>
        <option value="1">One</option>
        <option value="2">Two</option>
        <option value="3">Three</option>
      </select>

What operating system(s) are you seeing the problem on?
Linux
What browser(s) are you seeing the problem on?
Firefox
What version of Bootstrap are you using?
5.2.3

Hey @MauricioFauth
In order to make it work in RTL you also need to include bootstrap.rtl.min.css instead of bootstrap.min.css (see Getting started > RTL > Required HTML)
Here is a CodePen showing that the rendering is OK in RTL as well.
I'm closing it for now. Don't hesitate to add comments if my answer doesn't cover what was reported in the issue.

This is the expected result for v5 since RTL and LTR are different builds. They aren't meant to be used at the same time, even though it's possible with some edge cases. It's not a good idea since it requires to load both builds, final CSS gets really heavy.
V6 should allow us to drop RTLCSS and use logical properties, which would solve the kind of issues you're facing.

Thank you, @ffoodd and @julien-deramond.
Makes sense. This edge case is not worth the trade-off as this can be fixed with custom CSS.
You can close this issue.


Asking for feature

Could this bot work as a relay bot between twitch and beam? As i am streaming over both, it would be great for me.

In its current state it can only connect to one service at a time, so it could not act as a relay.


Failing Unit Test on macOS 10.14+

Several unit tests from test_recommender.py and test_audio_functionality.py are failing due to #2835.
#2898 is working on fixing it, but it's not ready yet. Until it is ready we should temporarily skip these unit tests.

@TobyRoseman Can we close this?

@srikris - I don't think we should close this yet; the issue has not been fixed in master yet.
When #2909 is merged, let's close this issue and open up a new P1 issue to re-enable 10.13 in GitLab.


[Drone 0.5] Drone is not overriding the image CMD with the commands in the build

Using the following build file, drone is executing the default image command which is set to CMD ["mvn"] instead of running the commands specified.
pipeline:
  build:
    image: library/maven:3-jdk-8
    commands:
     - mvn clean install

per issue template please use https://gitter.im/drone/drone for questions

one is executing the default image command which is set to CMD ["mvn"]

this is an incorrect assessment of the problem. Drone always, without exception, overrides the entrypoint and command for build containers.
please see the following sectino of the documentation:
http://readme.drone.io/0.5/usage/overview/#commands:68f80267fa3a50980dbb745a782b8dca
you will see that drone converts your build to a shell script which gets executed as the entrypoint and command:
#!/bin/sh
set -e

mvn clean install

I'm therefore not sure what issue you are experiencing, but the assessment that drone is using the default cmd is incorrect. If I use this yaml on the latest version of drone ...
pipeline:
  build:
    image: maven:3-jdk-8
    commands:
     - mvn -version

I see the following passing build results with commands executed as expected:

I therefore cannot verify or reproduce the claim that drone is using the default CMD value and have to close the issue. If you continue to experience problems please use the gitter channel to triage and open an issue once others have been able to confirm the problem. Thanks!


Disable remote controller on non-pod controllers and while in a vehicle

Makes sure the remote controller cannot be used on anything else besides pods
Disable using this in vehicles a.k.a
Fixes #1287

Why change this? All I can see this doing is breaking the ability to use this on seats.

Makes sure the remote controller cannot be used on anything else besides pods

Why?

Also, this is the wrong way to achieve what you want to achieve.
Design an interface and have the pod controller implement it.
In the remote controller, check if that interface is present instead of checking for specific classes.
This way the system stays extensible.

@TomyLobo
Are you talking about a module. What is this interface you speak of ?
Yes, when it is used on something besides a pod controller it will generate Lua error. As @Mista-Tea stated, in his case the field containing the method was not available "HasPly" and therefore some client tried to link the remote controller to something else. It is defined here and as I can guess for all pod controllers.
https://github.com/wiremod/wire/blob/master/lua/entities/gmod_wire_pod.lua#L188-L190

I'm not talking about a module.
I'm talking about a clean interface that separates concerns between the pod controller and the remote control.
Think about your TV's remote control. It doesn't tell your TV to tune to frequency X and start scanning the screen with what it receives there. It simply tells your TV "switch channel up" and things like that.


Color scheme change on the basis of firefox theme.

like when the firefox theme is set to light the cascade theme would be light and when the firefox theme would be dark the cascade theme would be dark

Hey @Rajbir98 there is a way to do this.
In your userChrome.css, comment out the following lines.
 :root {

    /* main window colour – toolbar & window background */
    --window-colour:    #1E2021;

    /* accent colour – active tab, button hover, ... */
    --secondary-colour: #191B1C;

    /* text and highlight colour */
    --inverted-colour:  #FAFAFC;

}

This will make the theme take on the colors of your current theme. Any theme works (even this), so you can browse addons.mozilla.org for something you like.
For more info, consult the README.

whenever I set my theme to light cascade should enable its light version
and whenever I switch the theme to dark cascade should enable its dark version

As per v2.7.6 the userChrome now contains prefers colour scheme media queries which should result in the behaviour described above. c:


x/tools/gopls: version created by didChange ignored?

What version of Go are you using (go version)?

$ go version
go version devel +3f21c2381d Thu Nov 14 01:57:00 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20191113232020-e2727e816f5a
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.8-0.20191113232020-e2727e816f5a

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build713590986=/tmp/go-build -gno-record-gcc-switches"

What did you do?
govim has a test that verifies suggested fixes. The following file is opened in Vim:
package main

var x int

func main() {
	x = x
}

Because of a slight vagary of the test setup, the following sequence of events occurs with exactly the file contents above:

didOpen with version 1
didChange with version 2
didChange with version 3

At this point therefore the current version of main.go is 3.
Then we trigger the code action:
&protocol.CodeActionParams{
    TextDocument: protocol.TextDocumentIdentifier{URI:"file:///tmp/go-test-script071826122/script-suggested_fixes/main.go"},
    Range:        protocol.Range{
        Start: protocol.Position{Line:5, Character:1},
        End:   protocol.Position{Line:5, Character:1},
    },
    Context: protocol.CodeActionContext{
        Diagnostics: {
            {
                Range: protocol.Range{
                    Start: protocol.Position{Line:5, Character:1},
                    End:   protocol.Position{Line:5, Character:1},
                },
                Severity:           2,
                Code:               nil,
                Source:             "assign",
                Message:            "self-assignment of x to x",
                Tags:               {1},
                RelatedInformation: nil,
            },
        },
        Only: {"quickfix"},
    },
    WorkDoneProgressParams: protocol.WorkDoneProgressParams{},
    PartialResultParams:    protocol.PartialResultParams{},
}

This gives us the following response:
[]protocol.CodeAction{
    {
        Title:       "Remove",
        Kind:        "quickfix",
        Diagnostics: {
            {
                Range: protocol.Range{
                    Start: protocol.Position{Line:5, Character:1},
                    End:   protocol.Position{Line:5, Character:1},
                },
                Severity:           2,
                Code:               nil,
                Source:             "assign",
                Message:            "self-assignment of x to x",
                Tags:               {1},
                RelatedInformation: nil,
            },
        },
        IsPreferred: false,
        Edit:        &protocol.WorkspaceEdit{
            Changes:         (*map[string][]protocol.TextEdit)(nil),
            DocumentChanges: {
                {
                    TextDocument: protocol.VersionedTextDocumentIdentifier{
                        Version:                1,
                        TextDocumentIdentifier: protocol.TextDocumentIdentifier{URI:"file:///tmp/go-test-script875975760/script-suggested_fixes/main.go"},
                    },
                    Edits: {
                        {
                            Range: protocol.Range{
                                Start: protocol.Position{Line:5, Character:1},
                                End:   protocol.Position{Line:5, Character:6},
                            },
                            NewText: "",
                        },
                    },
                },
            },
        },
        Command: (*protocol.Command)(nil),
    },
}

Notice however the version of the document change for main.go is version 1, not version 3.
What did you expect to see?
Version 3 in the document changes for main.go
What did you see instead?
Version 1.
Possibly related to #35114
gopls log file: fail.log

cc @stamblerre @ianthehat

Closing for the same reasons described in https://github.com/golang/go/issues/35114#issuecomment-562964388


Compiler binary should report its version

Usually anything will report a version string when you call it with --version command-line option. neat seems to be using --version for something else already. At least it should print its version in the usage screen.

Done:
Neat Compiler v0.7.0
Documentation: https://neat-lang.github.io/
Usage: neat [options] FILE.nt


java.lang.NullPointerException: Cannot invoke "sun.awt.shell.Win32ShellFolder2.getChildByPath(String)" because "" is null

Please describe what you did before the error occurred.
IMPORTANT! If the error occurs with a specific APK file please attach or provide link to apk file!

Jadx version: 1.4.2
Java version: <IP_ADDRESS>
Java VM: Oracle Corporation OpenJDK 64-Bit Server VM
Platform: Windows 10 (10.0 amd64)
Max heap size: 5248 MB

java.lang.NullPointerException: Cannot invoke "sun.awt.shell.Win32ShellFolder2.getChildByPath(String)" because "<local1>" is null
	at java.desktop/sun.awt.shell.Win32ShellFolderManager2.getPersonal(Unknown Source)
	at java.desktop/sun.awt.shell.Win32ShellFolderManager2.get(Unknown Source)
	at java.desktop/sun.awt.shell.ShellFolder.get(Unknown Source)
	at java.desktop/javax.swing.filechooser.FileSystemView.getDefaultDirectory(Unknown Source)
	at java.desktop/javax.swing.JFileChooser.setCurrentDirectory(Unknown Source)
	at java.desktop/javax.swing.JFileChooser.<init>(Unknown Source)
	at java.desktop/javax.swing.JFileChooser.<init>(Unknown Source)
	at jadx.gui.ui.dialog.FileDialog$FileChooser.<init>(FileDialog.java:155)
	at jadx.gui.ui.dialog.FileDialog$FileChooser.<init>(FileDialog.java:155)
	at jadx.gui.ui.dialog.FileDialog.buildFileChooser(FileDialog.java:137)
	at jadx.gui.ui.dialog.FileDialog.show(FileDialog.java:73)
	at jadx.gui.ui.MainWindow.openFileOrProject(MainWindow.java:295)
	at jadx.gui.ui.MainWindow.processCommandLineArgs(MainWindow.java:252)
	at jadx.gui.ui.MainWindow.init(MainWindow.java:247)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

I commit a workaround for this issue, hope it will help. Please check latest unstable build.
Maybe this fix will also resolve #1552 because it occurs in the same method.


chore: ofNat lemmas for Complex.normSq and abs

Having _ofNat lemmas is important for confluence given that for both normSq and abs, the _ofReal lemma is @[simp] and so is ofReal_ofNat. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for the AtLeastTwo case here.

bors r+

bors r-
bors d+

bors r+
Sorry for causing bors to repeatedly retry. I thought it was safe to r+ before CI passed because I assumed bors would cancel if CI failed.


Strange behaviour of the "Got it!"-Button

Hi everybody,
I have a problem with the mentioned button. What do I have to change, if I do not want to enlarge the text in the button, when I hover with the mouse over it? It just looks terrible, when the text enlarges, because the whole window enlarges too.
Everything is just fine, when I configure the Cookie Consent here -> https://www.osano.com/cookieconsent/download/ -> Open Source Edition -> Start Coding. But when I copy the code into my html, the behaviour of the button is like described above.
I spent lots of hours doing changes in the cookieconsent.min.css. But I was not successful. Please help me soon! :-)
Sebastian

Hi Sebastian,
this does sound like another CSS file is overwriting the default styling of the Cookie Consent CSS as this is not expected behavior (at least not that I know of). I guess something like "a:hover" or "a[role=button]:hover" with a transform property. You could check the source of the rule for the button using your browser's DevTools.
Best,
Manuel

Hi Manuel,
thank you so much for your reply!
You were right, my own CSS overwrites the default styling. Please have a look at the attached photos. I tried to put a div-container around the cookie consent, but unfortunately it does not work. There is still the same problem, that the "normal" behaviour of "a" is used for the cookie consent. At the moment for testing it enlarges a lot with 200 %.
Thank you very much for your assistance! 🙂
Best regards,
Sebastian
Am 6. März 2020 11:37:48 MEZ schrieb "Manuel Häußermann"<EMAIL_ADDRESS>
Hi Sebastian,
this does sound like another CSS file is overwriting the default
styling of the Cookie Consent CSS as this is not expected behavior (at
least not that I know of). I guess something like "a:hover" or
"a[role=button]:hover" with a transform property. You could check the
source of the rule for the button using your browser's DevTools.
Best,
Manuel
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/osano/cookieconsent/issues/692#issuecomment-595708012

I'm not quite sure why you would want your links to double in size while hovering, but I guess a fix is to use !important with selector being something like .cc-compliance a:hover. Another thing: You should use SSL as default in 2020.