[bug]: Running Img2img with Display In-Progress Images: Accurate causes it to fail

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
8GB
What happened?
When using the webinterface and running any image through Img2img I initially caught 3 errors:
Traceback (most recent call last):
  File "/mnt/Toshiba/GitHub/invokeAI/backend/invoke_ai_web_server.py", line 1367, in get_image_path_from_url
    if "init-images" in url:
TypeError: argument of type 'Image' is not iterable

Traceback (most recent call last):
  File "/mnt/Toshiba/GitHub/invokeAI/backend/invoke_ai_web_server.py", line 1212, in
parameters_to_generated_image_metadata
    rfc_dict["orig_hash"] = calculate_init_img_hash(
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/invoke/args.py", line 1182, in calculate_init_img_hash
    if image_string.startswith(prefix):
AttributeError: 'NoneType' object has no attribute 'startswith'

Traceback (most recent call last):
  File "/mnt/Toshiba/GitHub/invokeAI/backend/invoke_ai_web_server.py", line 1104, in generate_images
    self.generate.prompt2image(
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/generate.py", line 486, in prompt2image
    results = generator.generate(
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/invoke/generator/base.py", line 93, in generate
    image = make_image(x_T)
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/invoke/generator/img2img.py", line 52, in make_image
    samples = sampler.decode(
  File "/home/xpsyc/micromamba/envs/invokeai/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/models/diffusion/ksampler.py", line 129, in decode
    samples,_ = self.sample(
  File "/home/xpsyc/micromamba/envs/invokeai/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/models/diffusion/ksampler.py", line 214, in sample
    K.sampling.__dict__[f'sample_{self.schedule}'](
  File "/home/xpsyc/micromamba/envs/invokeai/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/home/xpsyc/micromamba/envs/invokeai/lib/python3.9/site-packages/k_diffusion/sampling.py", line 273, in sample_lms
    callback({'x': x, 'i': i, 'sigma': sigmas[i], 'sigma_hat': sigmas[i], 'denoised': denoised})
  File "/mnt/Toshiba/GitHub/invokeAI/ldm/models/diffusion/ksampler.py", line 182, in route_callback
    img_callback(k_callback_values['x'],k_callback_values['i'])
  File "/mnt/Toshiba/GitHub/invokeAI/backend/invoke_ai_web_server.py", line 868, in image_progress
    command = parameters_to_command(generation_parameters)
  File "/mnt/Toshiba/GitHub/invokeAI/backend/modules/parameters.py", line 43, in parameters_to_command
    if "init_img" in params and len(params["init_img"]) > 0:
TypeError: object of type 'Image' has no len()

Switching Display In-Progress Images to Fast fixed it.
Screenshots
No response
Additional context
No response
Contact Details
@Xpsychonauticon#1297

I also experienced this issue with the exact same console output.

Windows 11
Cuda
12GB VRAM

At first I thought img2img didn't work at all so I search issues and found this.
Turned off Display In-Progress Images: Accurate and now it works. (Fast and None both work)
Additionally this is the output in the web UI (which matches with the console output):
2023-03-30T13:11:54+0200: Server error: argument of type 'Image' is not iterable
2023-03-30T13:11:54+0200: Server error: 'NoneType' object has no attribute 'startswith'
2023-03-30T13:11:54+0200: Server error: object of type 'Image' has no len()

I also experienced this issue with the exact same console output.

Windows 11
Cuda
12GB VRAM

At first I thought img2img didn't work at all so I search issues and found this. Turned off Display In-Progress Images: Accurate and now it works. (Fast and None both work) Additionally this is the output in the web UI (which matches with the console output):
2023-03-30T13:11:54+0200: Server error: argument of type 'Image' is not iterable
2023-03-30T13:11:54+0200: Server error: 'NoneType' object has no attribute 'startswith'
2023-03-30T13:11:54+0200: Server error: object of type 'Image' has no len()

I can't believe that this actually fixed it


The method setPlaybackRate leads to stone distortion？

this.wavesurfer.setPlaybackRate(2.0)

The correct issue descriptions should be "Method setPlaybackRate leads to sound distortion with WebAudio backend".
This is because this happens when wavesurfer backend is WebAudio and not when MediaElement. I was playing a regular 3-minute MP3 file. Using latest Chrome (v 73) and Firefox (66), Windows 10.
WebAudio is the default backend. I also sadly need to use it for 2 reasons:

With MediaElement the browser essentially downloads the audio file twice (unless I supply peaks array) - one is streamed for user playback, the other is for Wavesurfer to generate peaks to show the waveform. I mostly serve user uploaded files on my website so I can't use the wavesurfer.js to generate the peaks beforehand. I know that it's possible to generate peaks on the server as well but it's currently more trouble than it's worth.
When I exported peaks using the exportPCM method and used MediaElement backend, the audio and peaks were slightly off :(

But it would be great to have setPlaybackRate work with Webaudio backend as well.
And by the way another bad part of backend WebAudio is that browsers don't cache the file :( And the file needs to be fully downloaded before playback unless using those peaks, which don't work correctly for me anyways. So it seems like a bad default.


Implement a project generator

Tasks:

[x] https://github.com/Clariteia/minos/issues/28
[x] https://github.com/Clariteia/minos/issues/29
[x] https://github.com/Clariteia/minos/issues/34
[x]  https://github.com/Clariteia/minos/issues/19
[x] https://github.com/Clariteia/minos/issues/20
[x] https://github.com/Clariteia/minos/issues/21
[ ] https://github.com/Clariteia/minos/issues/22
[x] https://github.com/Clariteia/minos/issues/23
[x] https://github.com/Clariteia/minos/issues/24
[ ] https://github.com/Clariteia/minos/issues/26

Closing this issue as it's an aggregation of another ones


[JAV-166]注册微服务读取paths配置信息

Coverage increased (+0.04%) to 85.385% when pulling cfaca99b2f3c273da841beb7c21119b547b5d5cc on liubao68:microservice_meta into b8cc8b8346b977ca16eb27385ce8b33173b2ae81 on ServiceComb:master.

this should based on #122
basePath in microservice.yaml should support relative path
in #122, urlPrefix saved in system properties before serviceRegistry init

Coverage increased (+0.2%) to 85.547% when pulling fd688ff6fc30a07b283d42329d9a46b6550c2df9 on liubao68:microservice_meta into b8cc8b8346b977ca16eb27385ce8b33173b2ae81 on ServiceComb:master.


macOS support

There is any reason why there is no target for macOS? I add one myself and seems to build without issues so far.

Don't think there's any good reason. Why don't you shoot a PR here? Seems straightforward.

Should work ok now, I'll publish a new release soon.


Import error in Jinja 2.10.x/2.11.x

Jinja 2.10.x installs the latest update of Markupsafe 2.1.0 released yesterday, which resolves in an ImportError.
This seems to be caused by the removal of soft_unicode from markupsafe in that version.

How to replicate:
In a terminal:
$ pip install Jinja2~=2.10.3 # same result with 2.11.x
$ python -c "import jinja2"

Traceback:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/nathan/Project/jinja-bug/venv/lib/python3.8/site-packages/jinja2/__init__.py", line 33, in <module>
    from jinja2.environment import Environment, Template
  File "/home/nathan/Project/jinja-bug/venv/lib/python3.8/site-packages/jinja2/environment.py", line 15, in <module>
    from jinja2 import nodes
  File "/home/nathan/Project/jinja-bug/venv/lib/python3.8/site-packages/jinja2/nodes.py", line 19, in <module>
    from jinja2.utils import Markup
  File "/home/nathan/Project/jinja-bug/venv/lib/python3.8/site-packages/jinja2/utils.py", line 642, in <module>
    from markupsafe import Markup, escape, soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/nathan/Project/jinja-bug/venv/lib/python3.8/site-packages/markupsafe/__init__.py)

Note:
Installing the last MarkupSafe version before 2.1.0 fixes this issue:
$ pip install MarkupSafe~=2.0.0
$ pip install Jinja2~=2.10.3
$ python -c "import jinja2"  # works

Environment:

Python version: 3.8.10
Jinja version: 2.10.x / 2.11.x

Duplicate of #1585
You are using an unsupported version of Jinja, please update to the latest version if possible. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

Sorry... it's not clear from the comments - is this fix (to replace 'soft_unicode' with 'soft_str') coming? How soon?


Calculator for checking  Points lie inside/outside/on of quadratic curve

Issue Id you have worked upon -
Fixed #147
Briefly explain your program logic -
In this calculator I used 'useState hook to set the state' and created empty arrays for all the cases that are OnTheCurve , InsideTheCurve , OutsideTheCurve and after implementing the logic i pushed the points in their respective arrays
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @Satvik-Garg on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.


Ecto 2.1

Support for Ecto 2.1

Coverage increased (+1.8%) to 85.366% when pulling 07caef9f9975641fbf296b4bc8d8ce99a759b870 on mbenatti:ecto-2.1 into 7e97991adac4b6351b09a30b6da79849b926ab0d on michalmuskala:ecto-2.

Thanks for this! I should be able to take a look at it later today.

Can you also try updating all of the dependencies to the latest version (specifically the mongodb package for 0.3)?

The tests are also failing because Ecto 2.1 dropped support for Elixir 1.2. Would you be able to update the travis file and mix.exs to show that?

Thanks for the start here. I am closing this because I manually fixed the conflicts and will soon push the changes to the ecto-2.1 branch.

Thanks @ankhers
I'm short on time this week to get attention to this project


Text Highlight(Search)

Functionality to search for a particular text in the entire pdf.
Pull Request Template
script name -
What have you Changed
what you changed in the codebase.write here
Issue no.(must) -
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS

I have made changes

@DrakeEntity Please review it once.

why do we need to use the search function on pdf only? we are creating a common JSON book format. That function should apply to json_book. @codePerfectPlus


CI action uses Node.js 18

Hi. Thanks for amazing tool for Browserslist ecosystem. I as Browserslist author like it a lot.
But I have some strange issue with it. In our case CI action uses Node.js 18 and CI fails (since we have engine: { node: ">=20" }.
But looks like you are using Node.js 20.
Our config:
name: Update target browsers
on:
  schedule:
    - cron: "0 2 1 * *"
permissions:
  contents: write
  pull-requests: write
jobs:
  update-browserslist-database:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout repository
        uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Configure git
        run: |
          git config --global user.email<EMAIL_ADDRESS>          git config --global user.name "GitHub Action"
      - name: Check Browserslist database
        uses: c2corg/browserslist-update-action@v2
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          branch: browserslist-update
          base_branch: master
          commit_message: Update Browserslist DB
          title: Update Browserslist DB

The log:
Run c2corg/browserslist-update-action@v2
Check if there is a branch and a matching PR already existing for caniuse db update
/usr/bin/git rev-parse --abbrev-ref HEAD
master
Create new branch browserslist-update
/usr/bin/git checkout -b browserslist-update
Switched to a new branch 'browserslist-update'
/usr/local/bin/npx update-browserslist-db@latest
npm warn exec The following package was not found and will be installed<EMAIL_ADDRESS>Latest version:     1.0.30001639
Installed versions: 1.0.30001614, 1.0.30001625, 1.0.30001629
Removing old caniuse-lite from lock file
Installing new caniuse-lite version
$ yarn add -W caniuse-lite
error: The engine "node" is incompatible with this module. Expected version ">=20". Got "18.20.3"

Maybe Node.js 20 version was not released? Or maybe you forget to update v2 tag to v2.4.0?

Hi. And sorry for not having answered to you, I completely forgot 🫣
This is quite old now, and indeed, v2 was positionned on v2.4.0, so as far as I remember, I could not explain your case.
Have you been able to rsolve it since? Or maybe due to the lack of answer you switched to something else? Let me know if I can be of any help.

Thanks for the feedback, and, again, apologies for the time needed to answer.


If Tweets do not have geo-location info, show them from the location of the user account on the map (if account has location info)

In the search on the map, currently only tweets with some kind of geolocation info are displayed. If there is not geo info, they are not displayed. A way to increase the number of tweets showing up: If Tweets do not have geo-location info, show them from the location of the user account on the map. Prerequisite is of course, that the account has location info of some sort.

@Orbiter, currently there is no location info in the user field in the search result. At the moment I can think of 2 way to proceed with this:

Check for place_name. If has place_name, request to the loklak API to convert place_name to lat, lng
From user screen_name, get location of the user

I'm guessing that loklak API already storea lat,lng related to place name so the first option can be easily implemented from the server, however, it's not an absolute solution since place_name field is empty quite often. The second option might requires more scrapings.
The last option is call directly to twitter API to get/guess the location of a user: https://dev.twitter.com/rest/reference/get/users/show

The server already should compute location positions from the place_name, if this does not happen it's a bug.
Getting the user information with location info is a matter of adding user information to loklak_server at all. Therefore this is related to https://github.com/loklak/loklak_server/issues/64
I am actually working on this right now. I had some successfull testing using the twitter4j api to get user information. Right now I am creating the infrastructure to store the user data.
Therefore, please consider that you may get location information soon attached to the user field or using the account.json servlet.

Please implement the reading of locations from the server. You can call
http://localhost:9000/api/account.json?screen_name=<screen_name> and then you get a user object which has a location_mark and location_point attribute attached, containing the location as [lon, lat] values. Please use the location_mark value.

Done with #378


Configure React proxy

Proxy must be configured to serve the following endpoints:
location /accounts/ {
        proxy_pass https://testinterview.smartlis.com/accounts/;
        proxy_buffering off;
        proxy_http_version 1.1;
        proxy_ssl_server_name on;

 }

location /api/ {
        proxy_pass https://testinterview.smartlis.com/api/;
        proxy_buffering off;
        proxy_http_version 1.1;
        proxy_ssl_server_name on;

 }

/reopen


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210323213358010 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210323213358010 to main with localized lcls

Pull Request Test Coverage Report for Build 681041933

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 43.27%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 680592937:
-0.001%

Covered Lines:
25462

Relevant Lines:
53684

💛  - Coveralls


urls::url::set_path produces incorrect result.

  urls::url url;
  url.set_path("/");
  CHECK_EQ(url.buffer(), "/");
  // ERROR: CHECK_EQ( url.buffer(), "/" ) is NOT correct!
  // values : CHECK_EQ( /./, / )
  url.normalize();
  CHECK_EQ(url.buffer(), "/");
  // PASS!

I thought this was fixed. Have you tried the tip of develop ?

I tried to pull the develop branch and the issue persists.
-- Downloading https://api.github.com/repos/boostorg/url/git/refs/heads/develop -> boostorg-url-develop.version...
-- Downloading https://github.com/boostorg/url/archive/f8022af5f02b26655004666727b25b591809ce74.tar.gz -> boostorg-url-f8022af5f02b26655004666727b25b591809ce74.tar.gz...
-- Extracting source ~/vcpkg/downloads/boostorg-url-f8022af5f02b26655004666727b25b591809ce74.tar.gz

Yes I can reproduce these issues, thanks for the concise report!


Bump required clap version to 2.33.0 in Cargo.toml

Cargo.toml currently specifies a minimum clap version of 2.31.2. However, this is an old
version from March 2018 that cargo-tarpaulin 0.10.0 does not actually compile against.
This is because of a macro issue for Rust 2018 in Clap 2.31.2, where the arg_enum macro
emits a call to the _clap_count_args macro expecting it to be in scope. Since tarpaulin
does not use clap::macros::_clap_count_args this is not true, and compilation fails. You can
observe this by making a new crate which depends on cargo-tarpaulin 0.10.0, or by
updating Cargo.toml to specify "=2.31.2" instead of "2.31.2"
This was fixed in this Dec 2018 commit to clap: https://github.com/clap-rs/clap/commit/cfbcb93f94fe8402054945e946bd51ed10b57326#diff-e1576943a5907b15388ab726037ebdb3 which is
included in 2.33.0
Having the old version in Cargo.toml  breaks using cargo-tarpaulin as a library, as in the
runtime_macros crate, which I was attempting to upgrade to the newest version of
tarpaulin, as in this case the Cargo.toml version is consulted. It has not caused any
issues for using it as a binary as in this case Cargo.lock is consulted which already
lists 2.33.0.
This commit updates the version in Cargo.toml to match the version that tarpaulin
is actually built against and compatible with.

And the compile output that occurs using 0.10.0 as a library without this change:
Compiling cargo-tarpaulin v0.10.0
error: cannot find macro `_clap_count_exprs` in this scope
  --> /home/e/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-tarpaulin-0.10.0/src/config/types.rs:7:1
   |
7  | / arg_enum! {
8  | |     #[derive(Debug, Copy, Clone, PartialEq, Eq, Ord, PartialOrd)]
9  | |     pub enum RunType {
10 | |         Tests,
...  |
14 | |     }
15 | | }
   | |_^
   |
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error: cannot find macro `_clap_count_exprs` in this scope
  --> /home/e/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-tarpaulin-0.10.0/src/config/types.rs:17:1
   |
17 | / arg_enum! {
18 | |     #[derive(Debug)]
19 | |     pub enum OutputFile {
20 | |         Json,
...  |
25 | |     }
26 | | }
   | |_^
   |
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error[E0308]: mismatched types
  --> /home/e/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-tarpaulin-0.10.0/src/config/types.rs:7:1
   |
7  | / arg_enum! {
8  | |     #[derive(Debug, Copy, Clone, PartialEq, Eq, Ord, PartialOrd)]
9  | |     pub enum RunType {
10 | |         Tests,
...  |
14 | |     }
15 | | }
   | | ^
   | | |
   | |_expected `_clap_count_exprs ! ($ (stringify ! ($ v)), +)`, found `4usize`
   |   expected `[&'static str; _]` because of return type
   |
   = note: expected type `[&'static str; _]`
              found type `[&'static str; 4]`
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error[E0308]: mismatched types
  --> /home/e/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-tarpaulin-0.10.0/src/config/types.rs:17:1
   |
17 | / arg_enum! {
18 | |     #[derive(Debug)]
19 | |     pub enum OutputFile {
20 | |         Json,
...  |
25 | |     }
26 | | }
   | | ^
   | | |
   | |_expected `_clap_count_exprs ! ($ (stringify ! ($ v)), +)`, found `5usize`
   |   expected `[&'static str; _]` because of return type
   |
   = note: expected type `[&'static str; _]`
              found type `[&'static str; 5]`
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)


Fix Boolean options can't have parameters error

This error was introduced as part of
9cf42462c029e038e09efc961736946be8bfcb9b, since the forceUpdateLock
option being used in the reboot command contains a parameter
property despite being declared a boolean.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Oops, sorry for that.
BTW, @jviotti, looks like you might have compiled with an older coffee-script? Otherwise I don't see why sync.js should change.

Oh, true. I'll create another PR re-building the CoffeeScript with the latest version.


Manage maven jib plugin

TL;DR
Manage maven jib plugin.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Although it works, a plugin should be managed with pined version.

Integration test is flaky JavaExamplesIT.testDynamicFibonacciWorkflow:68 » Timeout Timeout waiting for r...


[new product] opentofu

relates to https://github.com/opentofu/opentofu/issues/1099

release policy discussion, https://github.com/opentofu/opentofu/blob/main/TSC_SUMMARY.md#2024-01-22-async

looks like just need a rerun for the build failure?

Just looked at the build logs, the error is:
10:35:53 PM: /opt/buildhome/.rvm/rubies/ruby-3.1.4/lib/ruby/3.1.0/psych.rb:455:in `parse": (products/opentofu.md): did not find expected key while parsing a block mapping at line 2 column 1 (Psych::SyntaxError)

Any more work needs to be done for this PR? Thanks!

I made some slight changes to use OpenTofu instead of Opentofu. Rest


[big number] set start_y_axis_at_zero default to false

To stick with the previous behavior and get the trend line to show the
trend by default.
@kristw @williaster

Hmm, @kristw and @conglei and I discussed this because some users were upset about changing their old charts.
I think we aligned on starting at 0 as still being the best default, so I think we don't want to push this. We thought a better solution for keeping current users happy would be migrating existing slices to have the default, so that they don't change, but then all future charts will require consciously changing it to not start at 0. krist/conglei any other thoughts?

Codecov Report

Merging #5651 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5651   +/-   ##
======================================
  Coverage    63.5%   63.5%
======================================
  Files         360     360
  Lines       22888   22888
  Branches     2549    2549
======================================
  Hits        14534   14534
  Misses       8339    8339
  Partials       15      15

Impacted Files
Coverage Δ

superset/assets/src/explore/controls.jsx
45.92% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff5686...8983201. Read the comment docs.

@williaster Actually only one person has that feedback. No other complaints since.

👍 even more support for not making this change?

Just thought things looked very very flat after this change, I helped a user mass-update their charts to show some trends as they used to. I think that the Y axis being relatively short makes things look even flatter. Personally I'm thinking of this much like a spark line.
I'll rally with the majority though.

We thought a better solution for keeping current users happy would be migrating existing slices to have the default, so that they don't change, but then all future charts will require consciously changing it to not start at 0. krist/conglei any other thoughts?

I do like this option: keeping the current users consistent experience while all future charts will have default to start at 0.   But to do this, we seems to have to do a data migration?


How to add line breaks instead of paragraphs while entering return?

This is not a bug report, but a question. When someone hits return, it creates a new paragraph. When the user hits Ctrl+Enter, it creates a line break. Is there any option, which will help it to create new line (
) instead of a paragraph (
)?

You can't actually, sorry :/

Too bad, makes it impossible to use this editor with existing HTML code that has
 tags, editing those breaks things.

+1

Hello everbody:
any updates on this? Is it possible to do it with the actual version?
Thanks.

if anyone's still interested in this above, one way to simulate a line break in the editor is to change
.wrapAll('
')
to
.wrapAll('
')
So now every time a user presses enter or return, the paragraph has a zero margin and padding.

This will create  instead of  tags:
   var input = document.getElementById("your_trumbowyg_id");     input.addEventListener("keypress", function(event) {         if (event.keyCode === 13) {             event.preventDefault()             document.execCommand('insertLineBreak')         }     });

document.execCommand()

The support is pretty good for this but its obsolete. Might be good to use something different/recent for this. (sorry not being an ###)

The problem with my code is also that when you are at the very bottom of the editor and press enter, the scrollbar does not scroll down.

The problem with my code is also that when you are at the very bottom of the editor and press enter, the scrollbar does not scroll down.
After hours of trial and error without success, I felt forced to switch to another editor where everything works out of the box.

To solve this problem :
var input = document.getElementById("publication_description");
input.addEventListener("keypress", function(event) {
if (event.keyCode === 13) {
event.preventDefault()
document.execCommand('insertLineBreak');
document.execCommand('insertText', '');
}
});

The problem with my code is also that when you are at the very bottom of the editor and press enter, the scrollbar does not scroll down.
After hours of trial and error without success, I felt forced to switch to another editor where everything works out of the box.

To solve this problem :
var input = document.getElementById("publication_description");
input.addEventListener("keypress", function(event) {
if (event.keyCode === 13) {
event.preventDefault()
document.execCommand('insertLineBreak');
document.execCommand('insertText', '');
}
});

I would love to have this option as well - why? I often type bullet lists and want to force a line-break inside the bullet and not create a new bullet paragraph. So Trumbowyg would need to distinguish between normale "Enter" press and e.g. "Shift-Enter" which then would insert a  and not a .

Item1 kjdfglkjdfg
asfdasdfsadfasdf

Item 2l sdlfgjk dslfgj dsfg
Second line

Item 3
Second line

@Alex-D Any chance to implement this?


Might be a bug when calculating precision

In methods precision(link), the indices returned by _setup_metric is the indices of top k labels, with scores sorted ascendingly. But when calculating precision@k, we want to use cumsum when scores in eval_flags are sorted descendingly. The same is to psprecision since it uses precision as a subroutine.
I just add change indices to indices[:, ::-1] in _get_top_k. Guess it is just a workaround.

@Odaimoko Thank you for pointing this out. Please let us know if the issue has been resolved.


Issues with compiling the evaluation step in the vertex ai custom pipeline

Hi guys!
In my custom pipeline with xgboost model I get an error which is not clear in the logs.
This is the pipeline:
@dsl.pipeline(name="faye-pipe",
description="A basic pipeline with ti components",
              pipeline_root='gs://faye-test-bucket/faye-pipeline')

def ti_pipeline():
    data_preparation = preprocessing_step()
    train = xgboost_train_model(
        data_preparation.outputs["dataset_features"],
        data_preparation.outputs["dataset_target"],
    )
    evaluation = eval_model(
        train_dataset=data_preparation.outputs["dataset_features"],
        target_dataset=data_preparation.outputs["dataset_target"],
        xgb_model=train.outputs["model"],
    )

compiler.Compiler().compile(
  pipeline_func=ti_pipeline,
  package_path="faye_pipe.json"
)

The first two steps, the preprocessing step and the training step succeed. When i add print statements in the evaluation steps, all print statements come out successfully, meaning that the code works fine. However, it fails in evaluation step with the following logs which I do not understand in order to troubleshoot:
[KFP Executor 2023-02-24 10:56:07,971 INFO]: Loading KFP component "eval_model" from /tmp/tmp.F2eTpAh65Z/ephemeral_component.py (directory "/tmp/tmp.F2eTpAh65Z" and module name "ephemeral_component")
And also this one:
Tearing down training program.
Could you please assist?
Thanks a lot

Unfortunately, I'm not familiar with the library you are using and can't guess what's happening with the snippet you provided. It would be great if you have something more concrete for us to run.

@trivialfis Hello! I think the problem is related to the region selected... i used us-central1 and the metrics could not be compiled... if i remove the metrics, it works... so i need to switch to europe.

Good to know!


[GSoC 2019] Upload not performed

Latest branch as of now.
Steps to reproduce:

Upload a picture
After the license step, the app suddenly closes, unexpectedly
Pictures is not uploaded, as seen at https://commons.wikimedia.org/wiki/Special:Contributions/Aroravanshika or equivalent

Hey @nicolas-raoul this issue is fixed in the commit https://github.com/vanshikaarora/apps-android-commons/commit/e8db428b56406ab2df00f837c81308fe0df12fb1 . Please check if it works for you :)


fail build on hyprland-git 0.40

fail build on hyprland-git 0.40

[v] version returned: Hyprland, built from branch main at commit cddeec47a1fc0e70d8598fd10c29cd0e9489999f dirty (keybinds: make the keybind manager check for session lock (5894)).
Date: Mon May 6 02:28:14 2024
Tag: v0.40.0-11-gcddeec47, commits: 4617
flags: (if any)
[v] parsed commit cddeec47a1fc0e70d8598fd10c29cd0e9489999f at branch main on Mon May 6 02:28:14 2024, commits 4617
✔ adding a new plugin repository from https://github.com/dawsers/hyprscroller
MAKE SURE that you trust the authors. DO NOT install random plugins without verifying the code and author.
Are you sure? [Y/n] y
→ Cloning https://github.com/dawsers/hyprscroller
✔ cloned
✔ found hyprpm manifest
✔ parsed manifest, found 1 plugins:
→ hyprscroller by dawser version
✔ Hyprland headers OK
→ Building hyprscroller
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━  3 / 5  Building plugin(s)[v] shell returned:  -> cd /tmp/hyprpm/local && PKG_CONFIG_PATH="/home/local/.local/share/hyprpm/headersRoot/share/pkgconfig" make release
cmake -B ./Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=
-- The CXX compiler identification is GNU 13.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.1.1")
-- Checking for modules 'hyprland;pixman-1;libdrm'
--   Found hyprland, version 0.39.1
--   Found pixman-1, version 0.43.4
--   Found libdrm, version 2.4.120
-- Configuring done (0.2s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/hyprpm/local/Release
cmake --build ./Release -j
make[1]: Entering directory '/tmp/hyprpm/local/Release'
[ 25%] Building CXX object CMakeFiles/hyprscroller.dir/src/main.cpp.o
[ 50%] Building CXX object CMakeFiles/hyprscroller.dir/src/dispatchers.cpp.o
[ 75%] Building CXX object CMakeFiles/hyprscroller.dir/src/scroller.cpp.o
In file included from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/desktop/../includes.hpp:52,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/desktop/../defines.hpp:1,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/desktop/Window.hpp:3,
from /tmp/hyprpm/local/src/scroller.cpp:3:
/home/local/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland/wlr/types/wlr_layer_shell_v1.h:16:10: fatal error: wlr-layer-shell-unstable-v1-protocol.h: No such file or directory
16 | #include "wlr-layer-shell-unstable-v1-protocol.h"
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/hyprscroller.dir/build.make:104: CMakeFiles/hyprscroller.dir/src/scroller.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/includes.hpp:52,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/defines.hpp:1,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/Compositor.hpp:7,
from /tmp/hyprpm/local/src/dispatchers.cpp:1:
/home/local/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland/wlr/types/wlr_layer_shell_v1.h:16:10: fatal error: wlr-layer-shell-unstable-v1-protocol.h: No such file or directory
16 | #include "wlr-layer-shell-unstable-v1-protocol.h"
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/hyprscroller.dir/build.make:90: CMakeFiles/hyprscroller.dir/src/dispatchers.cpp.o] Error 1
In file included from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../debug/../includes.hpp:52,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/config/../debug/Log.hpp:7,
from /home/local/.local/share/hyprpm/headersRoot/include/hyprland/src/config/ConfigManager.hpp:6,
from /tmp/hyprpm/local/src/main.cpp:1:
/home/local/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland/wlr/types/wlr_layer_shell_v1.h:16:10: fatal error: wlr-layer-shell-unstable-v1-protocol.h: No such file or directory
16 | #include "wlr-layer-shell-unstable-v1-protocol.h"
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/hyprscroller.dir/build.make:76: CMakeFiles/hyprscroller.dir/src/main.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:83: CMakeFiles/hyprscroller.dir/all] Error 2
make[1]: *** [Makefile:91: all] Error 2
make[1]: Leaving directory '/tmp/hyprpm/local/Release'
make: *** [Makefile:13: release] Error 2
✖ Plugin hyprscroller failed to build.
This likely means that the plugin is either outdated, not yet available for your version, or broken.
If you are on -git, update first.
Try re-running with -v to see more verbose output.

I don't support hyprland-git. If you are on Arch, please try hyprland, currently at version 0.39.1. If you need version 0.40, I am sure Arch will update to it in the next few days. I will add support to it then.

I don't support hyprland-git. If you are on Arch, please try hyprland, currently at version 0.39.1. If you need version 0.40, I am sure Arch will update to it in the next few days. I will add support to it then.

i see


Allows support to Laravel 5.1

Provides support Laravel 5.1

:+1: looking forward to get this package in stable version

Soon, I'll just do some testing ;)

@lucasmichot  version 2.0.13 released

Thanks @andersao !

Thanks!


New Contribution

Contributor: [contributor information - Optional]
SSH Public key: "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAICIa2FjfRgSkPIDNnl/cOwaiYGld5phjKdjfT0IjLZnX
"- Required]
Attestation: [any form of attestation for contribution (e.g., signature) - Optional]

hello


[Feature] Add the ability to add data views (ex index pattern)

When setting up a new instance, needed to create data views (ex index pattern)
https://www.elastic.co/guide/en/kibana/current/data-views-api.html

this can be very usefull, an exemple of the resource declaration that can be implemented
resource "elasticstack_kibana_dataview" "mydataview" {
  name           = "log"
  pattern = "log-*"
  timeFieldName = "@timestamp"
}

This is something we would like to have as well, however if this is implemented we would need the ability to configure the dataview(s) to be shared across all spaces, specifically in 1 or shared across multiple.

This would be very useful for us. (Enterprise customer on ECK)

As an Enterprise customer I am also looking for this

Any update on this? I see it was added to the 0.8 milestone but the project is now on 0.10.

My poor man's workaround to this (and dashboards)
The form data is an index-pattern, exported via Kibana's saved objects UI. Would love a native resource though!
resource "terraform_data" "object" {
  triggers_replace = filesha1(var.object_path)
  provisioner "local-exec" {
    command = join(" ", [
      "curl --fail -X POST --insecure",
      "--user '${var.kibana_user}:${var.kibana_password}'",
      "--header 'kbn-xsrf: true'",
      "--form<EMAIL_ADDRESS>      "${var.kibana_url}/api/saved_objects/_import?overwrite=true",
    ])
  }
}

Elastic query alerting rule definition require dataView ID as an argument. Without data source for dataView we need to hardocde UUID.
Having dataView resource or at least dataView data source be super helpful.


Sass (indented) support

HI zaydek,
Any idea how to get this to support .sass (indented) synxtax? It's just scss traditional syntax right now.
Happy to work on it with you

Hi Robert, thanks for the interest. It's not something I'm particularly interested in supporting but I can give you a high-level idea of what's probably needed if you're inclined.
In theory you need to modify syntaxes/sass-template.json so that "include": "source.css.scss" points to "source.css.sass" instead. Note that this assumes VS Code has built-in support for Sass syntax highlighting, not just SCSS.
You should be able to pretty much just clone this repo, change that one line of code and check to see that it works locally. If that works, publishing to the VS Code marketplace is pretty easy too and happens pretty quickly.
If you have any problems just let me know.

Hi zaydek,
Yep I solved with. source.sass is provided I think by the indented sass project.
I can give you the code if you want to publish it - I'm just using it locally.

That's great! I wasn't sure if sass would just work. I'm not currently using my own extension right now so I don't feel a great sense of urgency to develop on it, but you're more than welcome to publish your extension to the VS Code marketplace.


Add helper functions - JS

Here is a shortlist of helpful functionality that have been with simulation tests that are worth having for sandbox testing:

[ ] did tx succeed?
[ ] what's the error
[ ] what's the log
[ ] logs_contain value (suggestion)
[ ] unwrap json ability
[ ] unwrap borsh ability

A user mentioned some test helpers they'd like to see, most are covered above, but I'll list them here for completeness:

~Check that transactions revert for the correct reason~ (covered by "what's the error")
~Verify that events were emitted with the right values~ (covered by "what's the log" and "logs_contain value")
Track balance changes elegantly
Handle very large numbers
~Simulate the passing of time~ (on the roadmap generally)


Should we memoize #OmniAuth::Strategy#credentials?

Expected Behavior
#credentials to be called once per callback request.
Actual Behavior
#credentials is called twice per callback request.
Question
Is there any reason OmniAuth::Strategy#credentials is not memoized given that OmniAuth::Strategy#auth_hash always invokes it twice in a row:
# OmniAuth::Strategy#auth_hash
hash.credentials = credentials if credentials

This results in all providers' credentials block to be evaluated twice per callback request.
I'm happy to open a fix for this if maintainers are open to it. Thoughts? @BobbyMcWho

I'm open to a PR, I'm not intimate with that section of code in particular


Node version bump

Hey, first thanks for the project, you provided. It's really cool !
I just wanted to mention, that maybe it might be a good idea to bump the node version of the tsconfig file. Currently, node 20 is already released whereas the project uses the config for node14, which might be suboptimal.

Had a look myself and it turned out to be more involving because with Node18 the aws-sdk is no longer available in the Lambda runtime enviroment, so you need to include it yourself (or switch to the V3 SDK which is even more involving).
Had an attempt but then ran into this issue https://github.com/npm/cli/issues/4783 when building the React App.

Updated to Node 16 for now

Thank you for the very helpful sample.
Node.js 16 has been deprecated, are there any plans to update it?
https://docs.aws.amazon.com/ja_jp/lambda/latest/dg/lambda-runtimes.html

Plans yes, but we didn't get to it yet. If you want to send a PR don't hold back :)

FYI, for anyone looking to deploy these as Lambda's with Node20.x you can already do this with a minor tweak.
To make this work src/lambda-edge/shared/shared.tsrequired 2 changes:
#13import SSM = require("@aws-sdk/client-ssm");
#183const getPathParams = await ssm.getParametersByPathCommand(pathParams).promise();
Then by packaging the provided existing function typescript code with esbuilder with the following tsconfig.json settings:
"compilerOptions": {         "allowSyntheticDefaultImports": true,         "lib": ["ES2022"],         "module": "ES2022",         "moduleResolution": "node",         "target": "ES2022"       },
We also now have this packaged for deployment within terraform automation pipelines using this terraform provider: https://registry.terraform.io/providers/jSherz/node-lambda-packager/latest
And the module var set to:
args = [
    "--bundle",
    "--external:@aws-sdk*",
    "--external:axios",
    "--external:cookie",
    "--external:jsonwebtoken",
    "--external:jwks-rsa",
    "--external:./error-page/template.html",
    "--minify",
    "--platform=node",
    "--sourcemap",
    "--target=es2022",
    "--sourcemap=inline",
  ]

We are only using the following: check-headers, http-headers, parse-auth, refresh-auth, sign-out functions.
So far this is in initial testing and validations, but this does appear to fully functional and stable.

Upgraded to Node v20!
https://github.com/aws-samples/cloudfront-authorization-at-edge/releases/tag/v2.2.1


bump up version of falcosidekick chart for updating falcosidekick-ui image version

Signed-off-by: Issif issif_github@gadz.org<!--  Thanks for sending a pull request!  Here are some tips for you:

If this is your first time, please read our contributor guidelines in the CONTRIBUTING.md of the main Falco repository.
Please label this pull request according to what type of issue you are addressing.
If the PR is unfinished while opening it specify a wip in the title before the actual title, for example, "wip: my awesome feature"
-->

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:
update charts for using v1.0.1 version for falcosidekick-ui
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from issif after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hey @Issif
could you rebase, please?
Once done, I'm ready to approve :)

@Issif: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hey @Issif
could you rebase, please?
Once done, I'm ready to approve :)

done, but the linting is still KO, it's because I tried to update both charts with one PR 😓

Hey @Issif
could you rebase, please?
Once done, I'm ready to approve :)

done, but the linting is still KO, it's because I tried to update both charts with one PR

As discussed we have to split this PR into two, since the dependency must be already present when bumping the dependant.

Hey @Issif
could you rebase, please?
Once done, I'm ready to approve :)

done, but the linting is still KO, it's because I tried to update both charts with one PR

As discussed privately we have to split this PR into two, since the dependency must be already present when bumping the dependant.

I need to find time for, but I'll do it for sure. Thanks.


ci: add python 3.9 builds #731

Description
As mentioned in #731,

Added py39 to envlist in tox.ini
Added Programming Language :: Python :: 3.9 classifier to classifiers in pyproject.toml
Added 3.9 to the build.yml file inside the .github/workflows folder

Checklist

[ ] Created tests which fail without the change (if possible)
[ ] All tests passing
[ ] Added a changelog entry (Not sure whether a new entry is needed or not.)
[ ] Extended the README / documentation, if necessary

Did I jump on it too quickly? Maybe I need to wait for setup-python to add Python 3.9. Current version 3.9.0-rc.2 won't work I suppose.

Hi @PrayagS !
Yes, I'd rather wait until the new Python version is released and added to GH action.
Also, there are people who intended to work on this issue as well - It would be nice if you would communicate working on this issue with them in #731 before jumping in :) I hope it can help us to avoid duplicate work among different contributors

Gotcha @Stranger6667. And sorry for jumping right away.

Looks like now it is possible to use range for versions:
actions/setup-python#usage
https://github.com/actions/setup-python/issues/20
https://github.com/actions/setup-python/issues/124
So  '3.9-dev - 3.9.X'  should start picking release version once it is available 🤔

So thanks to @svtkachenko, the 3.9 build job is working but during its execution, the test suite is throwing a AssertionError in test/cli/test_cassettes.py.
https://github.com/schemathesis/schemathesis/blob/512dff47bed6b3cee76d868f0d91b51cebe68159/test/cli/test_cassettes.py#L169

Cool! I will take a look :)

Hi! The problem was here - #788
I fixed the problem and took your commits into a separate pull request (#790). Now it is merged :) Thank you very much for working on this

Thanks @Stranger6667. It was nice working on this and once again, sorry for jumping on the issue straight up. I'll make sure to communicate properly now onwards.


GUID output with braces

The statement "netsh http add sslcert ...
appid=00000000-0000-0000-0000-000000000000" is wrong, since the braces
are missing. The test was also buggy.

Tested - looks good - merged


OpenID4VP and MDOC CBOR pending tasks

[ ] ./openid4vp/vp.py:9:        # TODO: what if the credential is not a JWT?
[ ] ./openid4vp/vp.py:21:        # TODO - automatic detection of the credential

check the entire redirect_endpoint, in particular where the VpToken object is instantited and the its VPs.
For the MDOC CBOR implementation please refer to pyMDOC-CBOR

@PascalDR please add a single unit test with a mdoc cbor presentation (vp) where the detect of the credential type is covered


Question about Setup/Config

Forgive me if the answer to this is obvious. I have the plugin installed in Flow. And I have regjump.exe located at C:\Users\Sean\Documents\Software\Regjump and have added that same string to my Path variable. I can navigate to a key via Flow, but neither enter or ctrl+enter is opening RegEdit. Am I missing something?

Hi, forgive me for the late response.
I have just tested with a fresh install inside Windows Sandbox and it works fine... so you have probably made a configuration mistake somewhere.
If you open a terminal and run regjump, does it work?


[Feature Request] Add beginner level quizes seperate quiz page

🚀 Feature Request
Is your feature request related to a problem? Please describe.
Add beginner level quizes seperate quiz page
Describe the solution you'd like
Add beginner level quizes seperate quiz page
Describe alternatives you've considered
Add beginner level quizes seperate quiz page ### Additional context
Add any other context or screenshots about the feature request here.

Would you like to work on this feature?

[x] Yes
[ ] No

Please don't create spam. We need only four issues open, not a large number. If you want to work on more issues, you can try other open source projects. A large number of issues in a single project can create problems for you and for us.


Added AllowNDIStreaming parameter to Set/New-CsTeamsMeetingPolicy

https://github.com/MicrosoftDocs/office-docs-powershell/issues/5652
If you try to run this parameter you get "You are not permitted to invoke Set-CsTeamsMeetingPolicy with the following parameters: AllowNDIStreaming".
The same for New-CsTeamsMeetingPolicy.

Docs Build status updates of commit 2be0a4e:
:clock10: Full build: the average full build time is 17 min(s) 55 sec(s), this is based on the last 1000 build(s) for this repository.


Regression test for /sync returning 404 for redactions

Lots more detail in the code, but this is a regression test for https://github.com/matrix-org/synapse/issues/12864: Synapse would return a 404 from /sync if given a since token which pointed to a redaction of an unknown event.

@kegsay would you mind taking another look at this, particularly to check you agree with https://github.com/matrix-org/complement/commit/ed0c3a7255c848d69b039270a176e5e39c6d36fe?

(thanks for the excellent review comments btw)


Documentation

Hi, I just saw this from HN, but can't comment there because the thread is too old (23 days).
This gem looks very very cool.  When I saw that you were handling API versions, I expected a simple DSL around feature toggles for semantic API versions....  but this is a middleware for business logic transformations.
Some ideas for your docs:

The usage docs start great, but then I'm lost when I hit this line: migrate if: -> data { data in type: 'user' } do |data|.  You might want to provide a sample of what the input is.  A request object?  Vanilla hash from the controller?  response body?  Is the 'user' some meta programming on the ActiveModel type?  After reading further, I think the controller is returning render json: {type: 'user', first_name: 'Jane', last_name: 'Doe', ... },  but I'm not sure to be honest.

You might want to record a screencast going through all of this very slowly.  This gem has a lot to it, so a full lesson might be helpful to walk people through it slowly.

Just some thoughts!  :)

Thanks for the feedback. You're correct that this is for applying transformations on business logic.
In the case of the migrate method, data is whatever you provide to migrate! within a request or response migration. It could be a hash (parsed JSON payload), an HTML string, an XML string, etc. — it's entirely dependent on input.
And the data in type: 'user' line is using pattern matching to match against the input data. The lambda will return true if data matches the pattern, i.e. it's a hash containing a key type with value 'user'.
I'll spend some time and update the docs soon.


Keep documentation for old versions

Keep documentation for old versions

Which parts did you find missing in the doc for older versions? I would gladly add it again marking them with the version numbers.

I'm sorry, I was sure I found a parameter not working after an update but I was wrong.


Error: The operation couldn’t be completed. (PHPhotosErrorDomain error -1.) iOS

Bug
Error: The operation couldn’t be completed. (PHPhotosErrorDomain error -1.)     at Object.fn [as saveToCameraRoll] (NativeModules.js:99)     at Function.save (CameraRoll.js:163)     at Function.saveToCameraRoll (CameraRoll.js:169)     at _callee2$ (VM5 index.bundle:209)     at tryCatch (runtime.js:45)     at Generator.invoke [as _invoke] (runtime.js:274)     at Generator.prototype.<computed> [as next] (runtime.js:97)     at tryCatch (runtime.js:45)     at invoke (runtime.js:135)     at runtime.js:170
Environment info
react-native info output:
System:
    OS: macOS 10.15.3
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 60.19 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.14.0 - /var/folders/7n/tg8wdbns7yvg3wqwnh_mzmp40000gn/T/yarn--1585096434645-0.8370493466760465/node
    Yarn: 1.22.1 - /var/folders/7n/tg8wdbns7yvg3wqwnh_mzmp40000gn/T/yarn--1585096434645-0.8370493466760465/yarn
    npm: 6.13.7 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
    Xcode: 11.2.1/11B53 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5

Library version: 1.4.0
Steps To Reproduce

I am just calling the CameraRoll.saveToCameraRoll with the remote url
...

Describe what you expected to happen:

I expected the video to be saved in the photos
I even tried it on the latest version and its still the same

Reproducible sample code
CameraRoll.saveToCameraRoll(url, 'video')
        .then(response => {
          console.log('***RES**');
          console.log(response);
          console.log('***RES**');
          this.setState({isDownloading: false});
          this.refs.completionToast.show('Download completed!');
        })
        .catch(error => {
          console.log('*****');
          console.log(error);
          console.log('*****');
          this.setState({isDownloading: false});
          this.refs.completionToast.show(
            'There was a problem downloading the video, please try again later',
          );
        });

Did you have all the nessesary permissions in the Podfile and in your Info.plist?
I had that error a few times ago and i think i remeber that it was a permission problem

same problem

same error

I solved it by roll back to version 1.4.0.
yarn upgrade<EMAIL_ADDRESS>

I solved it by roll back to version 1.4.0.
yarn upgrade<EMAIL_ADDRESS>
thanks it's work

Hello, I set the version to 1.4.0 according to your solution, but it still cannot be used after testing. My react-native version is 0.62.0. What was your successful react-native version?

Hello, I set the version to 1.4.0 according to your solution, but it still cannot be used after testing. My react-native version is 0.62.0. What was your successful react-native version?

"react-native":"0.61.4"

I solved it by roll back to version 1.4.0.
yarn upgrade<EMAIL_ADDRESS>
This solve this issue for me on:

"react-native": "0.60.6"

Though this was also necessary: https://github.com/react-native-community/react-native-cameraroll/issues/147#issuecomment-602512409

I was having this issue in 1.5.2 -- downgrading to 1.4.0 by itself worked for me!

The same issue on 1.5.2, downgraded to 1.4.0.

This issue still persists. The only way to solve it, is to downgrade to 1.4.0.

Closing as duplicate of #143

Does anyone have time to help and make a PR with a fix for this issue? There appears to be a solution at #159 (comment) . I'm happy to review and merge a well tested PR. Cheers

Does anyone have time to help and make a PR with a fix for this issue? There appears to be a solution at #159 (comment) . I'm happy to review and merge a well tested PR. Cheers

I just opened a new PR #172  with the fixes! Works perfectly for me!

:tada: This issue has been resolved in version 1.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@bartolkaruza Still happen to me
"@react-native-community/cameraroll": "^4.0.0",

still happen to me. "@react-native-community/cameraroll": "^4.0.0",

still happen to me. "@react-native-community/cameraroll": "^4.0.0"

still happen to me. "@react-native-community/cameraroll": "^4.0.0"

I'm also seeing the same issue.
I'm on react-native 0.63.2 and react-native-cameraroll 4.0.0 I tried a couple of things like downgrading 3 versions or so of react-native-cameraroll. I also tried on react-native 0.61.5 and react-native-cameraroll 4.0.0.
I don't think I tried 1.4 though so I will try that now, and report back.

I got it working also using react-native 0.63.2, react-native-cameraroll 1.4.0 and rn-fetch-blob 0.12.0
Here is a sample code:
const handleDownloadVideo = async () => {
    const ext = getExtFromUrl(video);

    try {
      const file = await RNFetchBlob.config({
        fileCache: true,
        appendExt: ext,
      }).fetch('GET', video, {type: 'video'});
      const path = file.path();

      await CameraRoll.saveToCameraRoll(path, 'video');

      file.flush();
    } catch (error) {
      console.log(error);
    }
  };

Hi same issue for me
Any update?


Discussion about PostLexer API

This is a greatly simplified version of what I want to do:
from lark import Lark, Token

class SimplePostLex:
    def process(self, stream):
        for t in stream:
            return Token.new_borrow_position('B', t.value, t)
    @property
    def always_accept(self):
        return 'A',
p = Lark("""
start: B
A: "A"
%declare B
""", parser='lalr', postlex=SimplePostLex())
p.parse('A')

This does not work since the lexer does not accept A-Tokens, even though I told him to do so. It works if I include an A Token somewhere in the grammar.

Ideally there would be a cleaner way to do this, but it works:
from lark import Lark, Token

class SimplePostLex:
    def process(self, stream):
        for t in stream:
            yield Token.new_borrow_pos('B', t.value, t)

    @property
    def always_accept(self):
        return 'A',

p = Lark("""
start: B
A: "A"
_unused: A
%declare B
""", parser='lalr', postlex=SimplePostLex(), start=["start", "_unused"])

print(p.parse('A', 'start'))

prints:
Tree(start, [Token(B, 'A')])

The _unused trick is necessary because Lark throws away terminals that aren't used by any of the rules, and using %declare A collides with the existing definition. I could fix the latter, but as you can see, there's a workaround anyway.

I have an idea: Have one more %command, maybe %always or %accept that takes a list of tokens that are always matched. This would also get rid of the requirement for always_accept in a PostLexer and PostLexer could be an actual function instead of a class-instance. (btw. I would be nice to have an ABC for PostLexer so you don't have to guess how the class has to look like.)

PostLexer could be an actual function instead of a class-instance

That's a decent idea.
I don't really like the always_accepts feature that much. It's lazy design, that I hacked in by the way.
One alternative would be to let the postlexer to change the ignore list at run-time. Then it could just add NL whenever paren_level > 0 and remove it when it's 0. It would be more flexible. But is there any use for it, other than for indentation? If not, than maybe it's an overkill; over-engineering.
Anyway, I'll give it some thought.

I don't like always_accept as a feature of the PostLexer either. That is simply not the place it belongs. (It changes the behavior of the Lexer even though it is supposed to happen afterwards).
I am not sure if I like the idea of being able to edit the ignore list:

First of all, it doesn't actually fix this problem.
Secondly, it forces the 'user' to micromanage the lexer and introduces a lot of potentially bugs for the 'user' to watch out for. (adding unnecessary things to ignore, forgetting to remove them, adding them to early/late...)

I don't like always_accept as a feature of the PostLexer either. That is simply not the place it belongs

While it's a "feature" of the lexer, there is no reason for it to exist without a postlexer. It's only the fact that the postlexer manipulates the tokens (which already requires it to micromanage and risk bugs) that makes it necessary.

Fixed in #708


Release 0.1.6

@JuliaRegistrator register(branch=release)

Error while trying to register: Changing package repo URL not allowed, please submit a pull request with the URL change to the target registry and retry.

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/15663
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.6 -m "<description of version>" 8e79919e497acb86c3d654d17740eb4b6badbdb8
git push origin v0.1.6


[BUG] photos fails to upload

ICO files aren't photo stupid
2023-10-18 19:36:48,711 - INFO - unzipper - asyncio_0 -
7-Zip [64] 17.04 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
p7zip Version 17.04 (locale=C.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64)

Scanning the drive for archives:
1 file, 460958 bytes (451 KiB)

Extracting archive: /app/Downloaded/854158484/archive_from_854158484.zip
--
Path = /app/Downloaded/854158484/archive_from_854158484.zip
Type = zip
Physical Size = 460958

Everything is Ok

Folders: 3
Files: 10
Size:       520548
Compressed: 460958
2023-10-18 19:36:50,003 - INFO - unzipper - MainThread - ext_a|854158484|854158484|False
2023-10-18 19:36:50,004 - INFO - unzipper - MainThread - ext_a paths : ['/app/Downloaded/854158484/extracted/copilot_icons/ico/Copilot 2023.ico', '/app/Downloaded/854158484/extracted/copilot_icons/ico/Copilot blue.ico', '/app/Downloaded/854158484/extracted/copilot_icons/ico/Copilot green.ico', '/app/Downloaded/854158484/extracted/copilot_icons/ico/Copilot purple.ico', '/app/Downloaded/854158484/extracted/copilot_icons/ico/Copilot red.ico', '/app/Downloaded/854158484/extracted/copilot_icons/png/Microsoft_Copilot_2023.png', '/app/Downloaded/854158484/extracted/copilot_icons/png/Microsoft_Copilot_Blue.png', '/app/Downloaded/854158484/extracted/copilot_icons/png/Microsoft_Copilot_Green.png', '/app/Downloaded/854158484/extracted/copilot_icons/png/Microsoft_Copilot_Purple.png', '/app/Downloaded/854158484/extracted/copilot_icons/png/Microsoft_Copilot_Red.png']
2023-10-18 19:36:50,476 - ERROR - unzipper - MainThread - Telegram says: [400 PHOTO_EXT_INVALID] - The photo extension is invalid (caused by "messages.SendMedia")

regular photos like PNG also gets errors
2023-10-18 19:37:53,082 - ERROR - unzipper - MainThread - Telegram says: [400 PHOTO_SAVE_FILE_INVALID] - The photo you tried to send cannot be saved by Telegram (caused by "messages.SendMedia")

idk why (skill issue probably)

closed in 09da4b87bba6e0a8481873d219b94c735a8cabf7


Consider switching default Kafka version to at least 2.1

The default Kafka version was set to 1.0 via #1787. This was a huge improvement over the previous default and the hope was that proper api versions support would be supported some time later.
2.5 years have passed and the default remains 1.0 if I understand correctly (please correct me if this is wrong).
I am working on a KIP to remove older protocol versions in Apache Kafka 4.0 and the proposed baseline is Apache Kafka 2.1:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+API+versions+in+Kafka+4.0
The KIP is still under discussion (i.e. it hasn't been approved yet), but I wanted to:

Give an early heads up to this project since it would impact your users with the current default
Get your input on whether bumping the default Kafka version in the near term is something you would consider

Thanks!

@ijuma thanks for getting in touch and the great writeup of the KIP and 2.1 sounds like a good baseline. Bumping the default KafkaVersion isn't a problem at all, but as you note our protocol version implementations aren't in sync with the Java client anyway
I'd suggest we sync this up with bumping Sarama to a 2.x and we can work on ensuring that we have implemented all of the protocol baselines to match the Java client at 2.1 (V7 MetadataRequest etc.) and to match what an ApiVersionRequest to a Kafka 2.1 broker returns

@dnwe that sounds great if the project has the cycles to update all of the protocol baselines as well.

Hi @dnwe. Is Sarama 2.x on the horizon or would it be better to do something more incremental in the meantime to avoid a situation where Sarama users with reasonable recent clients break by default with Apache Kafka 4.0?

@ijuma whilst on holiday I spent a bit of time looking into the minimum we'd need to do in order to meet this i.e., if we change the default baked version to sarama.V<IP_ADDRESS> then a) what default request versions do we support, but are not sending correctly atm and b) what protocol versions are not even implemented that need implementing so this is WIP

Awesome to see the progress @dnwe!

@dnwe not yet, I'll let you know once that exists.

Experimenting with 4.0 in the FV under this draft PR: https://github.com/IBM/sarama/pull/3045

@ijuma ok so everything looks good when doing the FV runs against Kafka 4.0 https://github.com/IBM/sarama/pull/3045 so from a producer + consumer perspective we're up-to-scratch
I think our FV test coverage on the admin client is much poorer by comparison, but I'll try and bolster that up to give us further confidence there before 4.0 final release
We'll probably use this milestone as a good point to put v1 of Sarama into maintenance mode and spinoff a /v2 branch where we can more freely make some major changes such as finally landing support for KIP-429 (incremental coop balance) in the consumer, drop the manual protocol configuration (sarama.Version) and actually use the ApiVersionsResponse values, rework the admin client so it doesn't expose protocol internals, rework the producer, etc. etc.

Sounds good.
Replacing the manual protocol configuration with API versions would be a huge win. My experience is that a significant number or users (including users of beats and other software that uses Sarama) never changes sarama.Version and hence ends up using older protocol versions for no good reason. A secondary negative side effect is that client software name & version aren't sent to the server and hence users find it harder to manage old client versions and making sure they get upgraded.

A secondary negative side effect is that client software name & version aren't sent to the server and hence users find it harder to manage old client versions and making sure they get upgraded.

One quick note on this, I think there's a quick fix for this that can be done in the existing branch:
https://github.com/IBM/sarama/pull/2028#discussion_r723795460


Dialog util

Added dialog util that can be used to easily show dialogs related to the bootstrap check.
Added a simple logging class that still needs the LogLevel connected and set from the Gandalf installer.
Added the ability to set the package name from the Gandalf installer

Does this PR aim to completely resolve #6?

I would say yes, but as you can see in the code I changed it a bit from my original requirement of it being dumb. Seemed like a better interaction to have it save the user responses and react to clicks.

Approved


[FEATURE] Tooltip on control buttons

It would be nice if we can pass custom tooltip to control buttons.

How would you like to pass a tooltip to the controls? I think we will not add this but we might find a way how we can pass a component/ref/whatever to the buttons.

How would you like to pass a tooltip to the controls? I think we will not add this but we might find a way how we can pass a component/ref/whatever to the buttons.

Passing component will be good idea, as we can send customized component for tooltip but we should also able to handle onhover event for that.

Hey @nileshlande12
I thought about it and we will not add such a feature. The controls are very simple to re-implement. There are a lot of different ways of how you could add functionality like tooltips. I think it's better to create your own controls if you need special features.


Shift peek for test failures to appear on the line where the test failure occurred

I guess this is more of a feature request too: would it be possible to display the “peek” panel at the failed line too?

Here’s how another plugin I’ve used shows failures:

I’ve not really worked on VS Code extensions before, but if you can point me where to start, I could take a stab at that.
Originally posted by @macbookandrew in https://github.com/chiefmyron/phpunit-test-workbench/issues/26#issuecomment-2093140495

Awesome — thanks!!
I’m seeing it show up on the wrong line though, I think because it’s using the last line of the stacktrace rather than the last line of code in my actual app:

this looks like something specific to the 10.x release of Laravel, which is why I missed it. Essentially, the Illuminate\Foundation\Testing\TestCase class is extending the runTest() method of the base PHPUnit TestCase class, and so the failure is bubbled up through that class. This method is not extended in the v11.x branch, or v9.x and earlier branches - it is specific only to v10.x.

oh, interesting…that makes sense. We’ll be upgrading this specific app soon.


undefined reference to `swr_alloc'

When I update the verison of astiav to v0.25.0,this error is happening.
# command-line-arguments
E:\Develop\go-1.22.8\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1
E:/Develop/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Ethan\AppData\Local\Temp\go-link-3035650647\000076.o: in function `_cgo_b8a024951563_Cfunc_swr_alloc':
/tmp/go-build/cgo-gcc-prolog:53:(.text+0x6e): undefined reference to `swr_alloc'
E:/Develop/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Ethan\AppData\Local\Temp\go-link-3035650647\000076.o: in function `_cgo_b8a024951563_Cfunc_swr_convert_frame':
/tmp/go-build/cgo-gcc-prolog:74:(.text+0xd0): undefined reference to `swr_convert_frame'
E:/Develop/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Ethan\AppData\Local\Temp\go-link-3035650647\000076.o: in function `_cgo_b8a024951563_Cfunc_swr_free':
/tmp/go-build/cgo-gcc-prolog:89:(.text+0x114): undefined reference to `swr_free'
E:/Develop/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\Ethan\AppData\Local\Temp\go-link-3035650647\000076.o: in function `_cgo_b8a024951563_Cfunc_swr_get_delay':
/tmp/go-build/cgo-gcc-prolog:105:(.text+0x14f): undefined reference to `swr_get_delay'
collect2.exe: error: ld returned 1 exit status

But when I add  //#cgo pkg-config: libswresample to software_resample_context.go,this error is gone.
Does my ffmpeg lib env have problem?
This is the version info of ffmpeg.

I found that there is no libswresample in astiav.go.
package astiav

//#cgo pkg-config: libavcodec libavdevice libavfilter libavformat libswscale libavutil
import "C"

OK,I'sure that it's just because of the above,can u add libswresample in astiav.go

Damn you're right, I don't know how I missed that 😱
I've added in master and I've created a new v0.28.0 tag 👍

Yes,it works.

Damn you're right, I don't know how I missed that 😱
I've added in master and I've created a new v0.28.0 tag 👍
Can you confirm this is working properly now?


Support envoy api V2

The issue to support envoy api V2
From envoy api v1.13.0, v1 envoy api(s) are no longer supported.
Currently demo apps in the repositry are based on envoy api V1.

i'm working on v2 support

v2.0.0 released - PR #5


Python 3.6.3 - 'str' object has no attribute 'change_state'

Class
def get_urls(self):
    urlpatterns = [
        url(r'^pending', self.pending, name='pending'),
    ]
    return urlpatterns

@transition(field='status', source=['*'], target='pending')
def pending(cls):

Returning:
'str' object has no attribute 'change_state'
.pyenv/versions/3.6.3/envs/DS012x669/src/django-fsm/django_fsm/init.py in _change_state
return fsm_meta.field.change_state(instance, func, *args, **kwargs)

Looks like you don't understand how Django and django-material works. I would recommend to start with django tutorial first and learn more about MVT. Next you can read django-material docs.


Better debugging support for runtime safety errors

Is your feature request related to a problem? Please describe.
I'm facing errors like the following, and finding it challenging to trace back to the code or object that has the safety issue.
Failed to initialize: Uncaught RuntimeError: unreachable
(anonymous )
logError
imports.wbg._wbg_error_19172d49b5d0849d
$flutter_rust_bridge::misc::web_utils::js_console_error::h4664335edd9b6c51
$flutter_rust_bridge::third_party::wasm_bindgen::worker_pool::WorkerPool: :new:: ({closure)}::hfe803290904c45e9
$<dyn core::ops:: function::FnMut<(A,)>+0utput = R as wasm_bindgen:: closure: :WasmClosure>:: describe:: invoke: :h2a0ebdf1693839bd
_wbg_adapter_36
real

rust_lib.js:581 panicked at /Users/aran/.cargo/registry/src/index.crates.io-6f17d22bba15001f/flutter_rust_bridge-2.0.0-dev.32/src/rust_auto_opaque/dart2rust.rs:17:14:
Fail to borrow object. Please ensure the object is not borrowed mutably elsewhere at the same time, which violates Rust's rules.: TryLockError(())

Stack:

Error
    at http://localhost:8000/pkg/rust_lib.js:587:21
    at logError (http://localhost:8000/pkg/rust_lib.js:243:18)
    at imports.wbg.__wbg_new_abda76e883ba8a5f (http://localhost:8000/pkg/rust_lib.js:586:66)
    at rust_lib.wasm.console_error_panic_hook::Error::new::h554cb2a05d32379c (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[16816]:0x5f0f27)
    at rust_lib.wasm.console_error_panic_hook::hook_impl::h87698accfb0c2024 (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[3295]:0x3ad8de)
    at rust_lib.wasm.console_error_panic_hook::hook::hb18f4458ce62f773 (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[23782]:0x666ec1)
    at rust_lib.wasm.core::ops::function::Fn::call::h2b792758c46c363c (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[20699]:0x63a376)
    at rust_lib.wasm.<alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h9a6abdb0a2af1e06 (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[16668]:0x5edbe6)
    at rust_lib.wasm.flutter_rust_bridge::misc::panic_backtrace::PanicBacktrace::setup::{{closure}}::hcb77c123d39213d4 (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[4536]:0x4149b6)
    at rust_lib.wasm.<alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h9a6abdb0a2af1e06 (http://localhost:8000/pkg/rust_lib_bg.wasm:wasm-function[16668]:0x5edbe6)

    Uncaught (in promise) RuntimeError: unreachable
    at rust_lib.wasm.panic_abort::__rust_start_panic::abort::h304c545e427f7c64 (rust_lib_bg.wasm:0x6916a9)
    at rust_lib.wasm.__rust_start_panic (rust_lib_bg.wasm:0x683c9c)
    at rust_lib.wasm.rust_panic (rust_lib_bg.wasm:0x2dda77)
    at rust_lib.wasm.std::panicking::rust_panic_with_hook::hff999e7138f45af6 (rust_lib_bg.wasm:0x126be0)
    at rust_lib.wasm.std::panicking::begin_panic_handler::{{closure}}::h057cbdabc2d6ab77 (rust_lib_bg.wasm:0x39d7c4)
    at rust_lib.wasm.std::sys_common::backtrace::__rust_end_short_backtrace::h620ef835227fa895 (rust_lib_bg.wasm:0x689c6f)
    at rust_lib.wasm.rust_begin_unwind (rust_lib_bg.wasm:0x4f682e)
    at rust_lib.wasm.core::panicking::panic_fmt::hf5e89e7ab20f07e3 (rust_lib_bg.wasm:0x56d7e4)
    at rust_lib.wasm.core::result::unwrap_failed::hdcfce5d5a8ef304b (rust_lib_bg.wasm:0x3bf0dd)
    at rust_lib.wasm.core::result::Result<T,E>::expect::h21c3e34f0339f62a (rust_lib_bg.wasm:0x506b70)

Describe the solution you'd like
Somehow, we need a way to increase the probability of statically catching these issues, a bit clearer guidelines on how to avoid them, and more runtime support to help find what callsites are responsible for issues. On static analysis, I'm not sure if there's a team around the dart analyzer, but maybe there's a collaboration possible around getting a linear type checker into it.
In particular there's this warning in the docs:

As expected, the MyNonEncodableType, &MyNonEncodableType, &mut MyNonEncodableType means the standard Rust ownership things - owned, borrowed, mutable borrowed. For example, in normal Rust, we cannot mutably borrow the same object twice at the same time. When doing so for RustAutoOpaque objects, you will receive a runtime error.

In short, just write normal Rust code, and you are safe. Anything that violates Rust's model or safety will be caught and provide a runtime error, instead of the dangerous undefined behavior.

The issue I think I'm running into is in writing Dart code that uses that normal Rust code, figuring out what's safe or not. I'm not 100% sure, but it seems possible to have working Dart code (that freely stores and copies some data) get turned unsafe for example by changing the Rust side of a type from a translated struct to a RustAutoOpaque.
Describe alternatives you've considered
N/A

Firstly, I guess it would be great if we show stack traces (for both Dart and Rust) when that panic happens. Indeed for native code it works great; IIRC it is the limitation of Web that makes panic handling not very elegant.
Btw, IIRC the panic may report full Rust stack trace. Could you please try to enable full stacktrace and see whether that provides you more info?

On static analysis, I'm not sure if there's a team around the dart analyzer, but maybe there's a collaboration possible around getting a linear type checker into it.

Possibly related: https://github.com/fzyzcjy/flutter_rust_bridge/issues/1641 (cc @Desdaemon).
Possibly related for overall issue: https://github.com/fzyzcjy/flutter_rust_bridge/issues/1883 (It's on my radar but has not have enough time to think about it deeply)

In lieu of a static solution which might take some time to develop (personally I'm also very interested in this area), being able to expand the stack trace back to the offending code should be a halfway decent solution. I don't know how to do this off the top of my head, but it might require some cooperation from flutter_rust_bridge as well.

@fzyzcjy I'm not sure how to get more info. I saw in the docs the link to https://stackoverflow.com/questions/69593235/how-to-get-panic-information-i-e-stack-trace-with-catch-unwind, but it looks like this is implemented directly already.
I have an unchanged init.rs:
#[flutter_rust_bridge::frb(init)]
pub fn init_app() {
    // Default utilities - feel free to customize
    flutter_rust_bridge::setup_default_user_utils();
}

In main.dart, I call await RustLib.init(); very early in initialization. I enabled the "log" feature to confirm this init_app is being called.

More broadly, I think what I maybe actually want is a supported way to avoid the runtime safety errors in the first place. Any chance there are flags I can use, or FRB APIs that I can avoid, so there are no possible runtime borrow checker issues?

I'm not sure how to get more info.

Firstly cc @Desdaemon - who implemented the whole web part from scratch, and IIRC he has mentioned some limitations of web panics (do they still hold today / is there any workarounds?).

so there are no possible runtime borrow checker issues?

If you always use &SomeType and avoid &mut SomeType, I guess this will never happen: Fail to borrow object. Please ensure the object is not borrowed mutably elsewhere at the same time, which violates Rust's rules.

That's helpful (And also challenging, because I am keeping mutable data in Rust.) Before, I had RustOpaque<std::sync::Mutex> everywhere, so I manually called my own .lock(), and didn't have this issue somehow. This doesn't work anymore because of the trait bound std::sync::Mutex<MyData>: MoiArcValue is not satisfied.
For the static analysis, I inquired with the dart team: https://github.com/dart-lang/language/issues/3778.

Two additional notes:

I noticed the backtrace feature and explicitly enabled it, but didn't see an effect.

I confirmed the connection to &mut and specifically the combination of `&mut with an async method.

Does something like this make sense?  I invoke a Dart command on it like await modifyContentsOfStorage(dartStorage.rustStorage);. At some point, this acquires the RwLock. But other awaitables might run, like await readContentsOfStorage(dartStorage.rustStorage). If FRB's lock acquisition runtimes aren't tight, and an awaitable might yield while holding a lock, I see the error.
I changed my &mut methods to frb(sync), and no longer see the borrow-related panics. But unfortunately that breaks the workaround for #1910. I'll file a separate issue.

I'm not sure how relevant this is to your situation, but FRB uses try_read and try_write which are the weakest assumptions possible about whether it is possible to acquire a lock.
While try_write fails even if there is a single other active borrower (high contention) it's the only acquisition mode that makes sense for both async and sync functions. If you need reliable lock acquisition, you might want to use RustOpaque<RwLock<_>> and manually acquire the lock yourself, at the cost of some ergonomics.

Is it possible to still use RustOpaque<RwLock<_>>? I get errors about conflicting implementations when trying to use tokio::sync::RwLock.
error[E0119]: conflicting implementations of trait `MoiArcValue` for type `tokio::sync::RwLock<simple::OpaqueData>`
   --> src/frb_generated.rs:205:1
    |
204 |   flutter_rust_bridge::frb_generated_moi_arc_impl_value!(RwLock<OpaqueData>);
    |   -------------------------------------------------------------------------- first implementation here
205 | / flutter_rust_bridge::frb_generated_moi_arc_impl_value!(
206 | |     flutter_rust_bridge::for_generated::rust_async::RwLock<OpaqueData>
207 | | );
    | |_^ conflicting implementation for `tokio::sync::RwLock<simple::OpaqueData>`
    |
    = note: this error originates in the macro `flutter_rust_bridge::frb_generated_moi_arc_impl_value` (in Nightly builds, run with -Z macro-backtrace for more info)

Oh yeah I did have this issue before, I think it's that once you use one type as an auto-opaque type you can't also use it inside RustOpaque anymore. cc @fzyzcjy

This doesn't work anymore because of the trait bound std::sync::Mutex: MoiArcValue is not satisfied.

IIRC try tokio's Mutex.

Does something like this make sense?  I invoke a Dart command on it like await modifyContentsOfStorage(dartStorage.rustStorage);. At some point, this acquires the RwLock. But other awaitables might run, like await readContentsOfStorage(dartStorage.rustStorage). If FRB's lock acquisition runtimes aren't tight, and an awaitable might yield while holding a lock, I see the error.

That looks pretty reasonable (and we need to find out a solution)

I think it's that once you use one type as an auto-opaque type you can't also use it inside RustOpaque anymore. cc @fzyzcjy

This looks like a bug. A workaround is to avoid such scenario (e.g. always use auto or non-auto; or add a wrapper type struct B(A); to differentiate both cases). But feel free to PR for it!

To support it, I am not sure what is the best semantics: A naive solution will introduce two exactly same named dart types, causing a lot of conflicts.

Spitballing a little, maybe FRB could generate more than one dart package to allow these conflicts to be resolved. mymodule/synchronized/mytype.dart and mymodule/mytype.dart


Give Option to use Tmux

User should have an option to use tmux send-keys ... to send command to screen for all local aliases.

I implemented this a while back with the @T feature (details in README).


Adding LogSettings to store the log levels

Using ScriptableObject to store list of log levels
REQUIRES: #1791
Only changes in ca86505b860c8e27352d4d4702dcfd570b53d2ff need to be reviewed for this PR

The 2 code smells:
Field 'LogLevelWindow.settings' is never assigned to, and will always have its default value null
the field is changed by Unity's SerializedProperty
Rename class 'LogSettingsGUI' to match pascal case naming rules, consider using 'LogSettingsGui'
following Unity's naming "GUI"

Merged in https://github.com/vis2k/Mirror/pull/1863


[tests-only][full-ci]Added documentation to run tika service related tests

Description
This PR adds documentation to run tika related tests on ocis on how to configure and run the tests.
Related Issue:
https://github.com/owncloud/ocis/issues/7235

Issue with sonarcloud: https://github.com/owncloud/ocis/issues/7301


Options: Distinguish between user-set value and default.

It would be very useful to distinguish between options that have been explicitly set by a user and options with default values. For example, Firefox's about:config prints all user-set options bold:

This distinction is useful so that we can offer a save button in mitmweb, that saves all user-set options into a config file on disk.
Steps:

[ ] See how we can distinguish default from user-set options. Is it just enough to compare .default to .value or something like this?
[ ] Indicate state in mitmproxy
[ ] Indicate state in mitmweb
[ ] Offer save button?

This is already done in mitmproxy. User set options are shown in a different color

I'm working on the mitmweb part, basically just compare .default and .value, maybe adding some judgement about the special cases.


Implement http static relay interface

I've merged the relay branch into master. So far, the raw-version is leading.

I close this issue, because a basic module is implemented. A new issue should be created for more detailed bugs and changes.


On Board Hints

Initial implementation of on-board hints and tree markup to indicate hints. Duplicate/empty submissions blocked. Allow longer guesses.

Whoops, let me close this and add another missing change


Rpi4b support

Going to close this since it's been in the dev branch for a while, https://github.com/Ivan-Velickovic/microkit/commit/ab62a44a2560c150a77b5c25bb8d6acbe1bcbd8e.


Can specify multiple LDAP servers

The Kx LDAP library allows you to pass in a list of LDAP servers to initialise against. I believe this is done for redundancy - e.g. passing in a list of (bad server address; good server address) still works.
The TorQ wrapper doesn't currently support passing multiple servers in, as it constructs the address by joining schema - host - port. Since there's a chance people may use different combinations of schemas and ports, I thought it best to do away with these variables and require the user to provide .ldap.servers - a list of schema://server:port, which gets passed through to the underlying LDAP library.

Thanks @jonathonmcmurray 😃 I think it needs someone from DI to hit the big merge button.


hack: include verify scripts based on cluster-api-provider-docker

xref https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/issues/2
TODO send PR for test-infra.
/priority important-soon
/kind feature
/assign @chuckha

test-infra PR is here:
https://github.com/kubernetes/test-infra/pull/13208

perfect, this is the same as docker stuff
/approve
/lgtm


[FLINK-6562] Support implicit table references for nested fields in SQL.

Thanks for the PR @haohui. Looks good to me.
I'll replace the test and extend CompositeAccessTest before merging.


Remove ontap and storage MiqShortcuts

Storage pages are currently shown as start page options even if the role has no permissions.

This removes the seed entries for these shortcuts.
Related to
https://bugzilla.redhat.com/show_bug.cgi?id=1450012

@Fryguy here's some more ontap stuff to delete. I wasn't sure about the last one (storage_manager_show_list) but it's always filtered in the UI. Also not sure about the best way to handle existing data, do we add code to filter?

These are already included in #15153 (See https://github.com/ManageIQ/manageiq/pull/15153/files#diff-edeefd781c4cac40883f0d5ff7269cc7L167).  Do you need them in separately in this PR for backporting purposes, or can I just close this one?  I am not planning to backport #15153 .

@Fryguy Hmm, I think I need to backport this, but I'll resubmit for the specific branch if necessary.


Updated the triggerpath from ..pipelineTemplates/module.*  to pipelineTemplates/jobs.*

Description
There seems to be no files with the /module.* pattern in the pipelineTemplates folder, based on the history it looks like this is the old names of the YML templates currently in the folder. So I guess the trigger path should also be changed to reflect this??
Changing this would start triggering all pipelines when the templates are changed (this currently doesn't happen, at least in my ADO pipelines).
Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change
Please delete options that are not relevant.

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (readme)
[x] I did format my code

Yes. It does honor these wildcards. Just tested it. When changing any of the templates, the module pipeline is triggered. It means all module pipelines will trigger when any of the templates are updated. Is that the original goal of having this trigger?

It is. It is the only way we can make sure the pipelines still work as intended. It would be better if there would be a way to be more ... specific - for example only run the Static Tests in case their template changed - but unfortunatelty it's all or nothing.


Amazing Bug (mod compatibility)

hello. i just updated the mod from 1.4.5 to 1.5.6, and world started to lag as makes it unplayable from lag
it happens only Multi Mine mod from atomicstryker is installed, and when dig your under (mine) (don't release the left click).
can you help it please? it doesn't happen in v1.4.5. using forge 2308. thank you.

Could you please describe the problem, I installed Multi Mine and my frames are the same, I tried mining under myself and around but nothing happened

hello. i tried it with vanilla now, and reproduced. this is what i did:
used forge 2308, latest multimine and stats keeper.
created a new world, options: enabled cheats, enabled bonus chest
i took the pickaxe from the bonus chest, started to dig my under directly down with my pickaxe.
i did never release the left click, then it started to lag after 15 blocks approximately.
you can see that sometimes you can't see block breaking process or you don't get the dropped blocks.
and you can also try /forge tps to see tps rate.

i can record a video if you want to see also.

I was able to reproduce it... its weird, I'll see what I can do

thank you.

could you try this, it isn't happening to me anymore but try it and we'll see https://www.dropbox.com/s/7y2p83rhqtnenjr/Ingotter-1.5.7.jar?dl=0

ingotter? :D ... trying

no it doesn't work, bug is still happening.

could you try this version on <IP_ADDRESS>9 of forge because I think its something with forge, https://www.dropbox.com/s/2aqkbfry8njhd1v/StatsKeeper-1.5.7.jar?dl=0

Can i do it with forge 2310?

sure just make sure its latest

no, it didn't work on forge 2310.

I don't know whats happening anymore but try to download this file now https://www.dropbox.com/s/7pwhojbp4stri53/Stats Keeper-1.5.7.jar?dl=0 I tried it on 2310 on 1.11.2 mc version and it works without any lag in dev workspace and in normal environment.

no, it still happens. i think @atomicstryker should help us.
my style to reproduce the bug:

install stats keeper that you linked and latest multimine on curseforge
forge 2310, arguments: -Xmx6G -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -XX:-UseAdaptiveSizePolicy -Xmn128M
open the game, create a new world that cheats and bonus chest enabled
get the wooden pickaxe from the chest (wood pickaxe is better to reproduce the bug)
start to dig your under till bug happens.
i can record a video if you want. i reproduced it many times.

I tried to reproduce it once more but failed to get any lag. This is the video if you want to see if I did something wrong https://puu.sh/w6U9u/d296ceb374.mp4

okay i will record a video tomorrow just like yours. really, thanks so much for dealing with it.

was the issue fixed?

oh, sorry; let me record a video then upload. (incoming in 10 mins approximately)

here it is:
https://www.youtube.com/watch?v=gCTrx9TZcTM
it still happens, used forge 2315

Just so i understand correctly, if you release left click at any time it doesn't happen? Or it only happens if you mine 30+ blocks without letting go?

yes? i did it in the video, i released left click, i stop mining, then started again and happened again, much faster than the first time i start.

see 1:33 in the video.

@AtomicStryker its a really weird bug I don't know how our mods connect to make that kind of issue because I don't mess with left click

haha. yes it's very weird, stats keeper just keeps hunger&saturation, and multi mine just keeps the block break process.
but, it doesn't happen in Stats Keeper 1.4.5.

it could be the Watch thing I added for the config file. I'll disable it and post the link.

o_O Here let me link you the 2 critical files for Multi Mine
https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/blob/1.11.2/MultiMine/src/main/java/atomicstryker/multimine/client/MultiMineClient.java
https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/blob/1.11.2/MultiMine/src/main/java/atomicstryker/multimine/common/MultiMineServer.java
Essentially, i coremod PlayerControllerMP which holds the float value of how much the block being mined is broken and add callback functionality. The client sends "mining progress" packets to the server, which keeps a map of partially mined blocks and re-distributes them to all players. If a player stops mining a block, the vanilla behaviour is to snap back to 0 progress, however Multi Mine keeps the obtained progress, and if a player hits the same block again, uses the mentioned callback to substitute the "fresh" mining progress with the previous, partially completed value.

which one should i do? both? i'm trying it on singleplayer.

Hmm weird, I disabled WatchService (I use this for when you edit config file in game it automatically syncs with game, something like the config gui but for the file itself) and tried it myself, got the pickaxe from the chest and mined until it broke without any lag. Could be WatchService's fault than but I don't see why.

i still am using 1.4.5. why did u add that feature? it was working fine already

its useful if you want to edit config file instead of going in mod options and editing it in GUI when the game is running

Could you just confirm to its not happening with the newest file

Newest file? I already used newest file in the video

this one: https://www.dropbox.com/s/w3z0laeoh79f491/Stats Keeper-1.5.7.jar?dl=0

uhm yes, it's not happening, i think.

great I'll release an update with configurable setting for that config watcher

uhm, please do it for 1.12 :D

I'll slowly start updating to 1.12 but will take some time if a lot has changed

okay. get luck with. @AtomicStryker you too :D


On smaller screens modal is not centerend anymore

[ ] I have searched the Issues to see if this bug has already been reported
[x] I have tested the latest version

Steps to reproduce

Create a modal
Open it
Resize window

Current behavior
On smaller screens modal is not centerend anymore
Expected behavior
Modal should be centered
Context

@SutuSebastian any updates on this ?


Add a feature flag to hide the Notifications tab on the settings page

Overview
Notifications will not be complete for the initial OS Hub launch. Add a configure_webhooks waffle switch and use the value to conditionally hide the "Notifications" tab  on the user settings page.

OAR considering not doing this in favor of text updates to indicate status of feature.

Removed from PB to pursue #2143


How is redis-port install?

How is redis-port install? I can't find install doc.

no need to install, it' s in codis/bin/codis-proxy after sucessful building.