[HOLD for payment 2023-10-24] [$250] Additional Details - Duplicate offline indicator in Enable Payment Page.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.81-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697012903021189
Action Performed:

Login with any account
Go to Enable Payment page (/enable-payments).
Go offline
Observer the offline indicator.

Expected Result:
Offline indicator shouldn't duplicate
Actual Result:
Duplicate offline indicator is duplicate
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/93399543/4d09bff0-73b4-47d1-b5e8-0e8ebe05cbc0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93399543/45be9791-cc75-4abc-9227-0e2d2d40a4a4

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014c703cecba895920
Upwork Job ID:<PHONE_NUMBER>448759296
Last Price Increase: 2023-10-12
Automatic offers:

akinwale | Reviewer | 27183809
hungvu193 | Contributor | 27183810
hungvu193 | Reporter | 27183812

Proposal
Please re-state the problem that we are trying to solve in this issue.
Offline Indicator is duplicate at Enable Payment page when offline.
What is the root cause of that problem?
We're using ScreenWrapper to wrap our logic of EnablePaymentPage here, however inside AdditionalDetailsStep we also have the OfflineIndicator which caused this issue:
https://github.com/Expensify/App/blob/771b8c58e9faaa863a483aa8c2bf8bbf38b5f72b/src/pages/EnablePayments/EnablePaymentsPage.js#L49-L51
https://github.com/Expensify/App/blob/771b8c58e9faaa863a483aa8c2bf8bbf38b5f72b/src/pages/EnablePayments/AdditionalDetailsStep.js#L246
What changes do you think we should make in order to solve the problem?
Since ScreenWrapper already had the OfflineIndicator itself. We can remove OfflineIndicator inside AdditionalDetailsStep.
Deep diving, AdditionalDetailsStep have another view with ScreenWrapper here:
https://github.com/Expensify/App/blob/771b8c58e9faaa863a483aa8c2bf8bbf38b5f72b/src/pages/EnablePayments/AdditionalDetailsStep.js#L148-L151
We should add shouldShowOfflineIndicator={false} to this ScreenWrapper, or replace it with View to avoid duplicate OfflineIndicator.
Also inside OnfidoStep, we have FullPageOfflineBlockingView, so when we render the OnfidoStep we will have both FullPageOfflineBlockingView and OfflineIndicator at the bottom:
https://github.com/Expensify/App/blob/771b8c58e9faaa863a483aa8c2bf8bbf38b5f72b/src/pages/EnablePayments/OnfidoStep.js#L64-L66
we should avoid that by adding props shouldShowOfflineIndicator to our ScreenWrapper of EnablePaymentsPage component with the condition that only show the OfflineIndicator when offline and the currentStep is not Onfido.
What alternative solutions did you explore? (Optional)
N/A

decreasing the price as its minor issue

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0176028098f8a29acb

@laurenreidexpensify I will be unavailable next week. Therefore, I am unassigning myself from the issue. Please feel free to assign it to another C+.

@hungvu193's proposal correctly identifies the root cause and the suggested solution is comprehensive enough with attention to detail. I recommend moving forward with this.
🎀 👀 🎀 C+ reviewed.

Thanks, the proposal makes sense to me 👍

Payment Summary

@akinwale - C+ $250 + 50% urgency bonus -  payment issued in Upwork
@hungvu193 - Bug Report $50 - payment issued in Upwork
@hungvu193 - Issue Fix $250 + 50% urgency bonus - payment issued in Upwork

@akinwale bump for checklist so we can close this one out. Thanks

@akinwale bump for checklist so we can close this one out. Thanks

Will get to it in a few hours.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. This particular case was missed when the Additional Details page was added.

[x]  [@akinwale] Determine if we should create a regression test for this bug.
[x]  [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Launch Expensify
Navigate to the Enable Payment page (/enable-payments).
Turn off the network connection on the device to go offline.
Scroll to the bottom of the page (on smaller screens).
Verify that only one "network offline" message is visible.

Do we agree 👍 or 👎?

@laurenreidexpensify Done!


Query: null semantics should apply to GreaterThanOrEqual, LessThanOrEqual, not only strict equality

This currently manifests in our translation of string.Contains:
SELECT [c].[FirstName]
FROM [FunkyCustomers] AS [c]
WHERE CHARINDEX(NULL, [c].[FirstName]) <= 0

we should be applying null semantics here instead:
SELECT [c].[FirstName]
FROM [FunkyCustomers] AS [c]
WHERE CHARINDEX(NULL, [c].[FirstName]) <= 0 OR CHARINDEX(NULL, [c].[FirstName]) IS NULL

@maumar and @divega should sync up on this.

@maumar - Do you want to look at this in 5.0?

not sure if I should do this, since 3-value logic for those operators is not as straightforward as I initially thought.

Maybe we can look at it as a strech/investigation

If it is complicated then we can defer. Just wanted to bring this up if we are already fixing this.


Unable to launch ubuntu 20.4 on macbook air M1

After setting up everything like istructions on https://mac.getutm.app/gallery/ubuntu-20-04 indicate, upon trying to launch the virtual machine i receive this error: "This version of macOS does not support GPU acceleration. Please change the VM configuration or upgrade macOS."
I watched different videos and followed them step by step where this wasn't an issue. I tried to look for gpu acceleration topics without finding success for this issue, and can't seem anywhere in the vm setting that allows me to unbox gpu acceleration.
Any ideas?

Updating os solved the issue


Please include a license for this project

Hello, please include a license for this project so others can copy, modify, distribute, etc... your code.
I am wanting to use this for a project, but without a license, it's difficult to know what might come of me if I use it 😆
Thanks much!
This website is in English, but it should help with selecting an appropriate license: https://choosealicense.com/

You can use this code if you follow MIT license.
Thank you.

Thank you!


refactor(cartrade): dockerize catrade and fabric validator

Cartrade example will be setup in docker-compose, updated the readme with new instructions.
Fabric validator runs in container as well.
Removed obsolete scripts, changed them where needed.
Build artifacts are not put directly in root dist/ dir anymore (it's still used by apps not dockerized yet, though, but will be changed in future commits).
Validator configuration is made cartrade-specific, this will be done in the same way for other sample apps in future commits.
Some setup changes were necessary in other samples as well, all should work like before.
Added small patch in fabric-all-in-one to support cartrade scenario (endorsment from peer from single org).
Updated indy clientbase base image because it didn't work with ppa:deadsnakes anymore.

Closes: #1805
Signed-off-by: Michal Bajer<EMAIL_ADDRESS>TODO (in future PR)

Clean exports from @hyperledger/cactus-cmd-socket-server (will not use this long fragile path in the future)

Depends on #1800

@izuru0 @takeutak @petermetz - Please review


return row position uipickerview

how I can know that the position uipickerview is selected?

@javmorales you can use the selectionChangedHandler to determine what is selected before doneHandler or cancelHandler  are called.

No response, closing.


Reading ABINIT WFK files

I have @lcgarman working on this but I figured that it would be best to generate an issue for this on Github as a test.

Capability added!


What version of GTSAM is being used?

Seems like gtsam 4.2a9 is being used, I don't see discreteDistributions in 4.1.0(python version) which is a stable release. I think this should be mentioned as a footnote in readme?

Correct, it's 4.2a9. I am hoping to release 4.2 soon so that will become the new stable.


Update version to v0.4.6 and Fix unsupported method and types of next.js examples

What this PR does / why we need it?

update yorkie-js-sdk's version to v0.4.6 and fix unsupported methods and types with brand new grammar.
add eslint options to auto-fix lint issues when it's built.

Any background context you want to provide?
What are the relevant tickets?
Fixes #620
Feature #557
Checklist

[x] Added relevant tests or not required
[x] Didn't break anything

I'm working on adding few more features, just stopped it and proceeded upstream.

@banma1234 Please check the below comment. #620 (comment)

@hackerwins fixed it. feel sorry for not checking the details. 😢


The kabanero-pipelines directory should have a readme describing the pipelines in it

The repo should have s readme that can be linked from the architecture document.  But it needs to describe what is in this repo,  what pipelines,  the pipelines should probably have a layout for different level pipelines.

Updated the readme to describe what the pipeline do and how to run them.


BoxedWrapper fails for opaque record types

While testing out the 0.5.0-preview.1 release with Pinta, I noticed that value.GetBoxed(Gdk.FileList.GetGType()) is now throwing an exception.
Adding the following code to the OpaqueTypedRecordTest reproduces the same error:
    [TestMethod]
    public void SupportsWrapHandle()
    {
        var recordTester = OpaqueTypedRecordTester.New();

        var wrapped = (OpaqueTypedRecordTester) GObject.Internal.BoxedWrapper.WrapHandle(
                handle: recordTester.Handle.DangerousGetHandle(),
                ownsHandle: false,
                gtype: OpaqueTypedRecordTester.GetGType()
        );

        wrapped.Handle.Should().Be(recordTester.Handle);
    }

Error message:
System.Exception: Type GirTest.OpaqueTypedRecordTester does not define an IntPtr constructor. This could mean improperly defined bindings

It looks like the reflection is failing because opaque records no longer have the constructor signature it's looking for?

Thank you for the report. This should be kept in mind for all kinds of boxed records (opaque / not opaque)


fix: update README.md

Signed-off-by: WindSpiritSR<EMAIL_ADDRESS>

@WindSpiritSR you should talk about how to use this SDK specifically, not general information about Casdoor.


Update README.md - grammar mistake corrected

grammar mistake corrected

grammar mistake corrected
Signed-off-by: Midhun Biju<EMAIL_ADDRESS>


When can chromedp support audio recording?

What did you expect to see?
When can chromedp support audio recording?
What did you see instead?
After video recording via chromedp, after synthesizing video via ffmpeg, no sound was found

After video recording via chromedp, after synthesizing video via ffmpeg, no sound was found

If you mean #1283, that's because Page.screencastFrame only gives  you image data. And what you have done is converting the images into a video with ffmpeg. There is not audio data at all.
As far as I know, CDP does not support audio recording. Please read through the CDP doc to understand what can you do with CDP.


-h, --help generate trailing spaces

Rust Version
rustc 1.21.0 (3b72af97e 2017-10-09)
Affected Version of clap
clap 2.27.1
Expected Behavior Summary
The help info should not contain unexpected trailing spaces for any lines of text.
Actual Behavior Summary
Some text ends with spaces, especially after the flag names.
Steps to Reproduce the issue
program --help or program -h.
Sample Code
extern crate clap;
use clap::{App, Arg};

fn main() {
    let _ = App::new("clap-space")
        .arg(Arg::with_name("a").long("flag-a").help("The first flag."))
        .arg(Arg::with_name("b").long("flag-b").help("The second flag."))
        .print_long_help();
}

Debug output
DEBUG:clap:Parser::propagate_settings: self=clap-space, g_settings=AppFlags(
    NEEDS_LONG_HELP | NEEDS_LONG_VERSION | NEEDS_SC_HELP | UTF8_NONE | COLOR_AUTO
)
DEBUG:clap:Parser::create_help_and_version;
DEBUG:clap:Parser::create_help_and_version: Building --help
DEBUG:clap:Parser::create_help_and_version: Building --version
DEBUG:clap:Parser::propagate_settings: self=clap-space, g_settings=AppFlags(
    NEEDS_LONG_HELP | NEEDS_LONG_VERSION | NEEDS_SC_HELP | UTF8_NONE | COLOR_AUTO
)
DEBUG:clap:Parser::create_help_and_version;
DEBUG:clap:Help::write_app_help;
DEBUG:clap:Help::write_parser_help;
DEBUG:clap:Help::write_parser_help;
DEBUG:clap:Parser::color;
DEBUG:clap:Parser::color: Color setting...Auto
DEBUG:clap:is_a_tty: stderr=false
DEBUG:clap:Help::new;
DEBUG:clap:Help::write_help;
DEBUG:clap:Help::write_default_help;
DEBUG:clap:Help::write_bin_name;
DEBUG:clap:Help::write_version;
DEBUG:clap:usage::create_usage_no_title;
DEBUG:clap:usage::get_required_usage_from: reqs=[], extra=None
DEBUG:clap:usage::get_required_usage_from: after init desc_reqs=[]
DEBUG:clap:usage::get_required_usage_from: no more children
DEBUG:clap:usage::get_required_usage_from: final desc_reqs=[]
DEBUG:clap:usage::get_required_usage_from: args_in_groups=[]
DEBUG:clap:usage::needs_flags_tag;
DEBUG:clap:usage::needs_flags_tag:iter: f=a;
DEBUG:clap:Parser::groups_for_arg: name=a
DEBUG:clap:Parser::groups_for_arg: No groups defined
DEBUG:clap:usage::needs_flags_tag:iter: [FLAGS] required
DEBUG:clap:usage::create_help_usage: usage=clap-space [FLAGS]
DEBUG:clap:Help::write_all_args;
DEBUG:clap:Help::write_args;
DEBUG:clap:Help::write_args: Current Longest...2
DEBUG:clap:Help::write_args: New Longest...8
DEBUG:clap:Help::write_args: Current Longest...8
DEBUG:clap:Help::write_args: New Longest...8
DEBUG:clap:Help::write_args: Current Longest...8
DEBUG:clap:Help::write_args: New Longest...8
DEBUG:clap:Help::write_args: Current Longest...8
DEBUG:clap:Help::write_args: New Longest...9
DEBUG:clap:Help::write_arg;
DEBUG:clap:Help::short;
DEBUG:clap:Help::long;
DEBUG:clap:Help::val: arg=--flag-a
DEBUG:clap:Help::spec_vals: a=--flag-a
DEBUG:clap:Help::val: Has switch...Yes
DEBUG:clap:Help::val: force_next_line...false
DEBUG:clap:Help::val: nlh...false
DEBUG:clap:Help::val: taken...21
DEBUG:clap:Help::val: help_width > (width - taken)...15 > (120 - 21)
DEBUG:clap:Help::val: longest...9
DEBUG:clap:Help::val: next_line...No
DEBUG:clap:write_spaces!: num=5
DEBUG:clap:Help::help;
DEBUG:clap:Help::help: Next Line...true
DEBUG:clap:Help::help: Too long...No
DEBUG:clap:Help::write_arg;
DEBUG:clap:Help::short;
DEBUG:clap:Help::long;
DEBUG:clap:Help::val: arg=--flag-b
DEBUG:clap:Help::spec_vals: a=--flag-b
DEBUG:clap:Help::val: Has switch...Yes
DEBUG:clap:Help::val: force_next_line...false
DEBUG:clap:Help::val: nlh...false
DEBUG:clap:Help::val: taken...21
DEBUG:clap:Help::val: help_width > (width - taken)...16 > (120 - 21)
DEBUG:clap:Help::val: longest...9
DEBUG:clap:Help::val: next_line...No
DEBUG:clap:write_spaces!: num=5
DEBUG:clap:Help::help;
DEBUG:clap:Help::help: Next Line...true
DEBUG:clap:Help::help: Too long...No
DEBUG:clap:Help::write_arg;
DEBUG:clap:Help::short;
DEBUG:clap:Help::long;
DEBUG:clap:Help::val: arg=--help
DEBUG:clap:Help::spec_vals: a=--help
DEBUG:clap:Help::val: Has switch...Yes
DEBUG:clap:Help::val: force_next_line...false
DEBUG:clap:Help::val: nlh...false
DEBUG:clap:Help::val: taken...21
DEBUG:clap:Help::val: help_width > (width - taken)...23 > (120 - 21)
DEBUG:clap:Help::val: longest...9
DEBUG:clap:Help::val: next_line...No
DEBUG:clap:write_spaces!: num=7
DEBUG:clap:Help::help;
DEBUG:clap:Help::help: Next Line...true
DEBUG:clap:Help::help: Too long...No
DEBUG:clap:Help::write_arg;
DEBUG:clap:Help::short;
DEBUG:clap:Help::long;
DEBUG:clap:Help::val: arg=--version
DEBUG:clap:Help::spec_vals: a=--version
DEBUG:clap:Help::val: Has switch...Yes
DEBUG:clap:Help::val: force_next_line...false
DEBUG:clap:Help::val: nlh...false
DEBUG:clap:Help::val: taken...21
DEBUG:clap:Help::val: help_width > (width - taken)...26 > (120 - 21)
DEBUG:clap:Help::val: longest...9
DEBUG:clap:Help::val: next_line...No
DEBUG:clap:write_spaces!: num=4
DEBUG:clap:Help::help;
DEBUG:clap:Help::help: Next Line...true
DEBUG:clap:Help::help: Too long...No
clap-space

USAGE:
    clap-space [FLAGS]

FLAGS:
        --flag-a
            The first flag.

        --flag-b
            The second flag.

    -h, --help
            Prints help information

    -V, --version
            Prints version information

This is partly an implementation issue that doesn't have a good work around. The help generation is segmented off where each "section" is written in isolation. Without greater coupling (or a larger refactor), the section that writes the spaces between the flags/values and the actual help line can't look ahead to see if there is actually anything that requires those spaces.
For the long_help it might be possible to look ahead since there is no possible way they'd need those spaces, but I'd have to dig deeper.
I agree it'd be better to have them gone, but is there an issue that these spaces are causing other than some additional bytes written to stdout?

Thanks for the details. No serious issue here. :)


Provide guidance on DNS transition

Need to provide support for transitioning DNS for current cloud.gov tenants when moving to GovCloud
Where DNS is currently hosted
DNS Managed by us

update entry in Route 53 to point to new ELB
aws does not support DNSSec (?)

Self-Managed DNS

update dns to point to ELB
[ ] Identify which tenants are managing DNS vs those managed by Route 53
[ ] Create appropriate documentation for each
[ ] Impact of creating and destroying ELBs in Terraform

/cc https://github.com/18F/cg-product/issues/224

For systems where 18F managed DNS:
Currently 18F's DNS is hosted in two places:

The legacy 18F enterprise AWS account, which hosts discovery.gsa.gov.
analytics.usa.gov. openopps.digitalgov.gov. open.foia.gov. https.cio.gov. open.fec.gov. calc.gsa.gov. my.usa.gov. 18f.gov. pulse.cio.gov. beta.fec.gov. sbst.gov. collegescorecard.ed.gov. regulations.atf.gov. gsaforecast.gsa.gov. cld.epa.gov.
The new TTS prod AWS account, which hosts everything else, and is managed via Terraform configured from GitHub here: https://github.com/18F/dns

As we migrate systems to new cloud.gov, we should migrate the DNS as well. In the case of domains delegated to us, we should work with the agencies to change their NS records to point to new versions set up through https://github.com/18F/dns

/cc https://github.com/18F/dns/issues/2

There is also a wrinkle around shared domains (such as *.18f.gov), since they can't span both environments. Seems like they will need to have DNS records for each of the subdomains during the transition.
Also also, for apps with custom domains, we should probably wait on https://github.com/18F/cg-product/issues/499 so that we don't need to change the internal domain twice.

@jezhumble et al - Would https://github.com/18F/dns be usable for partner apps as well, like analytics.usa.gov or https.cio.gov?

Yes, absolutely.

/cc https://github.com/18F/dns/issues/17

@afeld is there any reason you can think of to not close this issue?

Nope!


Get-DLPDetailReport EndDate parameter does not include results from that day

The StartDate and EndDate parameters behave differently with this cmdlet. The StartDate parameter includes all results on or after the specified date, however the EndDate parameter only includes results before that date, not on it. This leads to missing data in the specified range as data from the EndDate is excluded.
Example: If the StartDate is 01/01/2022 (MM/DD/YYYY) and the EndDate is 01/03/2022, the results returned will be from January 1st - 2nd, and do not include results from January 3rd. If you change the EndDate to 01/04/2022, the results returned will be from January 1st - 3rd.

After reading through some other closed comments, it appears this is not the place to submit bugs, so I'm closing this and will open a support request.

@SimpleInfoSec, could we be dealing with a UTC thinghere? Many of the date-related parameter descriptions in cloud-based cmdlets contain this information:

To specify a date/time value for this parameter, use either of the following options:

Specify the date/time value in UTC: For example, "2021-05-06 14:30:00z".
Specify the date/time value as a formula that converts the date/time in your local time zone to UTC: For example, (Get-Date "5/6/2021 9:30 AM").ToUniversalTime(). For more information, see Get-Date.

Does this affect the results?


Started adding appleseed.python tests

Rescued from an old branch.

assertTrue? Shouldn't it be some kind of equality check rather?

Fixed and rebased.

In the other libraries (appleseed.foundation, appleseed.renderer, etc.) unit tests are placed inside a meta/tests/ directory. I suggest doing the same here.

I think that the usual practice when adding unit tests to python modules is test/
The tests are now part of the package and users can run them.
I think it's easier if running the tests is similar to other common python modules.


(MAINT) Bump puppet-agent to 6e35df8 and puppet submodule

This commit bumps our puppet-agent dependency for CI to 6e35df8 and our
puppet submodule dependency to 2ec5b3d.
Along with the bump, three changes to tests were necessary in order for
existing tests to continue passing:

Updated master_spec.rb Puppet version from 4.3.2 to 4.4.0.

Updated PuppetCatalog schema used for tests to tolerate existence of
the new 'catalog_format' key in the catalog response format.

Update class_info_tests to look for simple types for Hash and Array
instead of composite types like Hash[Scalar, Data, 0, default].  This
change was expected per the resolution of PUP-5861.

Ping @cprice404 and @KevinCorcoran for review.
Updating puppet-server#master branch to the latest passing puppet-agent off of the puppet#stable branch.  CI is currently failing because the build for our previous pinned puppet-agent version no longer exists on the builds server.
I figured I'd target puppet#stable instead of master for the updated pin since that's closer to what we're intending to release our next Puppet Server version off of.

:+1: looks good to me.

I think we're gonna need to merge this down to stable as well.  Probably wait until @nathanielksmith's #928 lands.


rep migration

Clubhouse Story
Clubhouse Story
Submitter checklist

[X] Test covering functionality added/fixed in
Check the linked story includes the following:

[X] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass
[ ] Post merge, story marked complete

Should be good now!


What does --suppress-sizes do?

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
El Capitan 10.11.6

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:
angular-cli: 1.0.0-beta.11-webpack.2
node: 6.4.0
os: darwin x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.
ng build --suppress-sizes=true

Mention any other details that might be useful.

The resulting build from 'ng build --prod' produces unknown provider errors for me. 'ng build' as is works but the resulting main.bundle.js is 3mb in size. Trying to reduce this size so saw --suppress-sizes option but this option doesn't seem to make a difference in the size of main.bundle.js.

That's an unsupported option that still appears listed in some placed. https://github.com/angular/angular-cli/issues/1807 is tracking the cleaning of these unsupported commands.


pkgsCross.{armv7l-hf,aarch64}-multiplatform.glibc fails to build

To Reproduce
Steps to reproduce the behavior:

nix-build -A pkgsCross.aarch64-multiplatform.glibc
nix-build -A pkgsCross.aarch64-multiplatform.glibc

Expected behavior
The package to successfully build
Additional context
aarch64-unknown-linux-gnu-gcc ../sysdeps/aarch64/start.S -c     -I../include -I/build/build/csu  -I/build/build  -I../sysdeps/unix/sysv/linux/aarch64  -I../sysdeps/aarch64/nptl  -I../sysdeps/unix/sysv/linux/generic  -I../sysdeps/unix/sysv/linux/wordsize-64  -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux  -I../sysdeps/nptl  -I../sysdeps/pthread  -I../sysdeps/gnu  -I../sysdeps/unix/inet  -I../sysdeps/unix/sysv  -I../sysdeps/unix  -I../sysdeps/posix  -I../sysdeps/aarch64/fpu  -I../sysdeps/aarch64/multiarch  -I../sysdeps/aarch64  -I../sysdeps/wordsize-64  -I../sysdeps/ieee754/ldbl-128  -I../sysdeps/ieee754/dbl-64/wordsize-64  -I../sysdeps/ieee754/dbl-64  -I../sysdeps/ieee754/flt-32  -I../sysdeps/aarch64/soft-fp  -I../sysdeps/ieee754  -I../sysdeps/generic  -I.. -I../libio -I. -nostdinc -isystem /nix/store/a2rl0q0ixh6qkdpx9hgy885ijgf27mjz-aarch64-unknown-linux-gnu-stage-static-gcc-debug-9.2.0/lib/gcc/aarch64-unknown-linux-gnu/9.2.0/include -isystem /nix/store/a2rl0q0ixh6qkdpx9hgy885ijgf27mjz-aarch64-unknown-linux-gnu-stage-static-gcc-debug-9.2.0/lib/gcc/aarch64-unknown-linux-gnu/9.2.0/include-fixed -isystem /nix/store/spyz3qksgicas1hnfdfflijq5kg6qlid-linux-headers-4.19.16/include  -D_LIBC_REENTRANT -include /build/build/libc-modules.h -DMODULE_NAME=libc -include ../include/libc-symbols.h  -DPIC     -DTOP_NAMESPACE=glibc -DASSEMBLER  -I/build/build/csu/. -g -Werror=undef -Wa,--noexecstack   -o /build/build/csu/start.o -MD -MP -MF /build/build/csu/start.o.dt -MT /build/build/csu/start.o
In file included from <command-line>:
./../include/libc-symbols.h:471:26: error: '__EI___errno_location' specifies less restrictive attributes than its target '__errno_location': 'const', 'nothrow' [-Werror=missing-attributes]
  471 |   extern __typeof (name) __EI_##name \
      |                          ^~~~~
./../include/libc-symbols.h:475:29: note: in expansion of macro '__hidden_ver1'
  475 | #  define hidden_def(name)  __hidden_ver1(__GI_##name, name, name);
      |                             ^~~~~~~~~~~~~
./../include/libc-symbols.h:539:32: note: in expansion of macro 'hidden_def'
  539 | # define libc_hidden_def(name) hidden_def (name)
      |                                ^~~~~~~~~~
errno-loc.c:28:1: note: in expansion of macro 'libc_hidden_def'
   28 | libc_hidden_def (__errno_location)
      | ^~~~~~~~~~~~~~~
errno-loc.c:24:1: note: '__EI___errno_location' target declared here
   24 | __errno_location (void)
      | ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [../o-iterator.mk:9: /build/build/csu/errno-loc.os] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/glibc-2.27/csu'
make[1]: *** [Makefile:215: csu/subdir_lib] Error 2
make[1]: Leaving directory '/build/glibc-2.27'
make: *** [Makefile:9: all] Error 2
builder for '/nix/store/lqjkj6dc17xbvaclamd12b454q6iimnl-glibc-2.27-aarch64-unknown-linux-gnu.drv' failed with exit code 2
cannot build derivation '/nix/store/840ds4ny81z9sfycr5yypmkq597fh0ps-glibc-2.27-aarch64-unknown-linux-gnu.drv': 1 dependencies couldn't be built
error: build of '/nix/store/840ds4ny81z9sfycr5yypmkq597fh0ps-glibc-2.27-aarch64-unknown-linux-gnu.drv' failed

Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.6, NixOS, 20.03.git.76e5ae7ebae (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.2`
 - channels(root): `"nixpkgs-19.03.172866.4649b6ef4b5"`
 - channels(flokli): `"nixpkgs-20.03pre204199.3140fa89c51"`
 - nixpkgs: `/home/flokli/.nix-defexpr/channels/nixpkgs`

Seems to be caused by 8f729c0070ec3f78edadeaebcbd110257fe4577e, at least it seems to have worked with the commit before that.
cc @globin

PR: https://github.com/NixOS/nixpkgs/pull/68029

So it seems as this is a new compiler-flag introduced in GCC9. Currently checking if it's possible to build those packages locally with another -Wno-error (if that's true, I'd file a PR against staging).

See also https://github.com/NixOS/nixpkgs/pull/76972 and https://github.com/NixOS/nixpkgs/pull/76880

Thanks a lot for the note! I basically tried the same what you did and it seems to work, so at least it's tested twice now :sweat_smile:

fixed by #76972.


Make the usage non-global

Is it possible to make this tool work it it is not  globally installed?
I would just want to install it as a local dev-dependency. My first test didn't succeed.

Currently, it works like a global stand-alone tool. We will be looking into it and making it works as a local dev-dependency recently.


Create and apply verification classes for admin and project manager

Right now, we have single RoleVerification and ProjectRoleVerification classes. However, most often we have to use the RoleVerification like this:
fastapi.Depends(
            auth_injectables.RoleVerification(
                required_role=users_model.Role.ADMIN
            )
        )

and the ProjectRoleVerificationlike this:
fastapi.Depends(
            auth_injectables.ProjectRoleVerification(
                required_role=ProjectUserRole.MANAGER
            )
        )

This approach has the disadvantage that we always have to import the user and project users model, needed to provide the required_role argument. Here I would suggest to create two new injectables AdminRoleVerification and ManagerProjectRoleVerification that simply use the abstract RoleVerification and ProjectRoleVerification with the predefined role (both injectables should still have an optional field verify: bool = true).

Sounds good, but it may be worth looking into https://github.com/DSD-DBS/capella-collab-manager/issues/71 directly.


Add mcmc to R package

Hi,
I've been trying to follow your instructions for adding mcmc to an R package to use the samplers you've written.
I already have a package that uses Eigen and CppAD to generate loglikes and gradients. I can't get mcmc to play with that package.
So to see where I was going wrong I'vee tried starting a new package, that just uses Rcpp, I followed your instructions of using the header only version and adding the following at the stop of my cpp file:
#define MCMC_USE_RCPP_EIGEN
#include "mcmc.hpp"
When I try to build a it I get the following error:
#error MCMClib: you must enable the armadillo  or eigen wrappers
When I add #define MCMC_ENABLE_EIGEN_WRAPPERS
I get the following error:
#error Eigen must be version 3.4.0 or above
Anyway, any help would be greatly appreciated as I'm very keen to use your samplers, rather than having to write them out myself.
Kind regards,
Skip.

The error arises because RcppEigen has not updated the base version of Eigen for a few years now (though not due to laziness on Dirk's part, rather the package maintainers ran into issues when doing so), and the latest version of my library requires Eigen >= v3.4.0. I'll update my documentation to remove RcppEigen as an option.

For any one playing along, I downloaded https://gitlab.com/libeigen/eigen/-/releases/3.4.0 and added the Eigen folder to
inst/include/ in my R package and then used:
#define MCMC_ENABLE_EIGEN_WRAPPERS
#include "mcmc.hpp"
To include the mcmc code
My makevars file has the following:
PKG_CPPFLAGS =  -I../inst/include/ to point to these headers


Recognize context manager contextlib.suppress as a hidden try/except

Environment data

Language Server version: v2020.10.1
OS and version: Windows10 Pro v1903
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.4 (default, Aug  9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)] :: Anaconda, Inc. on win32

Expected behaviour
Pylance should recognize the context manager contextlib.suppress as a hidden try/except
Actual behaviour
Code appearing after a with suppress(exception): block will be marked as unreachable.
Code Snippet / Additional information

from contextlib import suppress

test = 'test'

def testfunction():
    with suppress(IndexError):
        return test[10]
    print("Did reach this code")
    return 't'

testfunction()

Running this as a script will print "Did reach this code" but Pylance will mark lines 9 and 10 as unreachable.

This appears to be a duplicate of #494

Yep.


add configurable keyboard shortcut to perform various action

such a greta extension but why no keyboard shortcut?Please add option to assign keyboard shortcut !!

I would love to see keyboard shortcuts too, because of the chrome v78 release removing "close other tabs" in the tab context menu, it looks like this could be a good replacement however some keyboard shortcuts would be an nice improvement.

me too


Panic when injecting arguments.parameters in a DAG if the value comes from an expression

Summary
What happened/what you expected to happen?
I'm learning about workflows' conditionals and it should be possibile to inject an input conditionally; however if I use valueFrom.expression in the arguments.parameters of the template argo panics with argo lint and argo submit
What executor are you using?
Emissary
Diagnostics
Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: output-parameter-env-diff-
spec:
  serviceAccountName: argo-workflow   # has the proper role
  entrypoint: env-diff
  templates:
  - name: env-diff
    dag:
      tasks:
        - name: get-env
          template: alpine-get-env
        - name: diff-env
          dependencies: [get-env]
          template: perform-diff
          arguments:
            parameters:
              - name: workdir
                value: "{{tasks.get-env.outputs.parameters.first_workdir}}"
        # - name: responseok          # Working, let's step up the game!
        #   template: response-true
        #   dependencies: ["diff-env"]
        #   arguments:
        #     parameters:
        #       - name: verdict
        #         value: "SAME!"
        #   when: >-                                                      # Govaluate: https://github.com/Knetic/govaluate  !!!
        #     "{{ tasks.diff-env.outputs.result }}" =~ "no differences"

        - name: conditional-value-response
          template: response
          dependencies: ["diff-env"]
          arguments:
            parameters:
              - name: verdict
                valueFrom:
                  # Expression syntax: https://github.com/antonmedv/expr/blob/master/docs/Language-Definition.md
                  # expression: "tasks.diff-env.outputs.result =~ 'no differences' ? 'ok': 'ko'"    # this panics
                  expression: "tasks.diff-env.outputs.result contains 'no differences' ? 'ok': 'ko'"    # this panics as well
                # value: "{{ tasks.diff-env.outputs.result }}"    # this works, of course

  - name: alpine-get-env
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["echo $PWD > /tmp/workdir.txt"]
    outputs:
      parameters:
      - name: first_workdir
        valueFrom:
          path: /tmp/workdir.txt

  - name: perform-diff
    inputs:
      parameters:
      - name: workdir
    script:
      image: nextcloud:latest
      command: [bash]
      source: |
        echo "workdir={{ inputs.parameters.workdir }} and here_workdir=$PWD"
        [[ "{{ inputs.parameters.workdir }}" == "$PWD" ]] && \
        echo no differences between {{ inputs.parameters.workdir }} and $PWD || \
        echo "here_workdir ($PWD) differs from remote ({{ inputs.parameters.workdir }})"

  - name: response
    inputs:
      parameters:
        - name: verdict
    script:
      image: busybox:latest
      command: [sh]
      source:
        echo "{{ inputs.parameters.verdict }}"

The workflow is pretty simple: the first step uses a container to output the value of the $PWD variable;
the second steps uses another container and echoes a sentence based on the fact that the working directory is the same as the one in the first container.
What I want is echo 'ok' in a third container if the workdirs match, 'ko' otherwise.
So the value of the 'verdict' input should be injected in the third step conditionally.
Whenever I run argo lint, and of course argo submit, I get:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1d0d59e]

goroutine 1 [running]:
github.com/argoproj/argo-workflows/v3/workflow/validate.validateDAGTaskArgumentDependency(0xc000203a40, 0x1, 0x4, 0x0, 0x0, 0x0, 0xc000b80320, 0x2, 0x2, 0x0, ...)
        /home/runner/work/argo-workflows/argo-workflows/workflow/validate/validate.go:1322 +0x11e
github.com/argoproj/argo-workflows/v3/workflow/validate.(*templateValidationCtx).validateDAG(0xc000aad840, 0xc000a35230, 0xc000aad8c0, 0xc000b06000, 0xc000a554f8, 0x0)
        /home/runner/work/argo-workflows/argo-workflows/workflow/validate/validate.go:1301 +0x134c
github.com/argoproj/argo-workflows/v3/workflow/validate.(*templateValidationCtx).validateTemplate(0xc000aad840, 0xc000a598c0, 0xc000aad8c0, 0x382ef08, 0xc000a35110, 0xc000a598c0, 0x0)
        /home/runner/work/argo-workflows/argo-workflows/workflow/validate/validate.go:396 +0xb75
github.com/argoproj/argo-workflows/v3/workflow/validate.(*templateValidationCtx).validateTemplateHolder(0xc000aad840, 0x3856080, 0xc000209d40, 0xc000a9f238, 0x382ef08, 0xc000a35110, 0x0, 0x0, 0xc00077c000)
        /home/runner/work/argo-workflows/argo-workflows/workflow/validate/validate.go:480 +0x15f
github.com/argoproj/argo-workflows/v3/workflow/validate.ValidateWorkflow(0x3816b20, 0xc000a2b890, 0x3816b00, 0xc000a2b8b0, 0xc000500400, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/runner/work/argo-workflows/argo-workflows/workflow/validate/validate.go:205 +0x12fc
github.com/argoproj/argo-workflows/v3/server/workflow.(*workflowServer).CreateWorkflow(0xc0004ca3c0, 0x386f390, 0xc0004ca390, 0xc00013f800, 0x0, 0x7fea1a8776f0, 0x40)
        /home/runner/work/argo-workflows/argo-workflows/server/workflow/workflow_server.go:65 +0x2c5
github.com/argoproj/argo-workflows/v3/pkg/apiclient.(*argoKubeWorkflowServiceClient).CreateWorkflow(0xc000aa68b0, 0x386f390, 0xc0004ca390, 0xc00013f800, 0x0, 0x0, 0x0, 0x58, 0x28bd720, 0x1)
        /home/runner/work/argo-workflows/argo-workflows/pkg/apiclient/argo-kube-workflow-service-client.go:20 +0x51
github.com/argoproj/argo-workflows/v3/pkg/apiclient.(*errorTranslatingWorkflowServiceClient).CreateWorkflow(0xc000aa68c0, 0x386f390, 0xc0004ca390, 0xc00013f800, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/runner/work/argo-workflows/argo-workflows/pkg/apiclient/error-translating-workflow-service-client.go:20 +0x69
github.com/argoproj/argo-workflows/v3/cmd/argo/commands.submitWorkflows(0x386f390, 0xc0004ca390, 0x389aeb8, 0xc000aa68c0, 0xc00050c6a0, 0x19, 0xc000101c00, 0x1, 0x1, 0xc000aa28c0, ...)
        /home/runner/work/argo-workflows/argo-workflows/cmd/argo/commands/submit.go:222 +0x30b
github.com/argoproj/argo-workflows/v3/cmd/argo/commands.submitWorkflowsFromFile(0x386f390, 0xc0004ca390, 0x389aeb8, 0xc000aa68c0, 0xc00050c6a0, 0x19, 0xc000520110, 0x1, 0x1, 0xc000aa28c0, ...)
        /home/runner/work/argo-workflows/argo-workflows/cmd/argo/commands/submit.go:122 +0x296
github.com/argoproj/argo-workflows/v3/cmd/argo/commands.NewSubmitCommand.func1(0xc000ab8000, 0xc000520110, 0x1, 0x1)
        /home/runner/work/argo-workflows/argo-workflows/cmd/argo/commands/submit.go:86 +0x2c5
github.com/spf13/cobra.(*Command).execute(0xc000ab8000, 0xc0005200d0, 0x1, 0x1, 0xc000ab8000, 0xc0005200d0)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.2.1/command.go:860 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xc0009c8a00, 0xc000094778, 0xc000a9ff78, 0x406365)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.2.1/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.2.1/command.go:902
main.main()
        /home/runner/work/argo-workflows/argo-workflows/cmd/argo/main.go:14 +0x2b

I'm running Garuda Linux:
Linux garanto 5.16.10-zen1-1-zen #1 ZEN SMP PREEMPT Wed, 16 Feb 2022 19:35:21 +0000 x86_64 GNU/Linux

# kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:25:17Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:19:12Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}

# argo version
argo: v3.2.7
  BuildDate: 2022-01-28T02:12:09Z
  GitCommit: bdc14b0d2e50b6d3b30f7b6ffbfd8ceae3214413
  GitTreeState: clean
  GitTag: v3.2.7
  GoVersion: go1.16.13
  Compiler: gc
  Platform: linux/amd64

# Logs from the workflow controller: no logs since the workflow can't be submitted

# If the workflow's pods have not been created, you can skip the rest of the diagnostics.
# The workflow's pods that are problematic: # skipped
# Logs from in your workflow's wait container, something like: # skipped

Thank you,
Antonio

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

I'm afraid you cannot use valueFrom in this context. Try using expression tag template instead:
          arguments:
            parameters:
              - name: verdict
                value:
                  expression: "{{=tasks.diff-env.outputs.result contains 'no differences' ? 'ok': 'ko'}"

I'm afraid you cannot use valueFrom in this context. Try using expression tag template instead:
          arguments:
            parameters:
              - name: verdict
                value:
                  expression: "{{=tasks.diff-env.outputs.result contains 'no differences' ? 'ok': 'ko'}"

This way It doesn't panic, but the string is neither ok or ko. The last container echoes nothing.
Also, reading the documentation for the parameters field under DAGtemplate - DAG Task - arguments - parameters I understand that value only accepts a string as a value and expression is only to be under the valueFrom key.
Also expressions should follow the expr syntax but if I replace =~ with contains it panics again.
As far as I've understood the =~ operator is used in conditionals under the when key.
But maybe I'm doing something wrong.

Sorry - wrong syntax:
          arguments:
            parameters:
              - name: verdict
                value: "{{=tasks.diff-env.outputs.result contains 'no differences' ? 'ok': 'ko'}"

ok,
value: "{{= 1 == 1 ? 'ok': 'ko' }"

this works.
I tried to play with it a little bit and I finally found the correct syntax: "{{=tasks['diff-env'].outputs.result contains 'no differences' ? 'ok': 'ko'}}".
Documentation was actually clear about this:
Note that any hyphenated parameter names or step names will cause a parsing error. You can reference them by indexing into the parameter or step map, e.g. inputs.parameters['my-param'] or steps['my-step'].outputs.result.

However I think it's worth investigating why using arguments.parameters[*].valueFrom.expression causes a panic (see the link to the docs). It should be legal but most importantly it causes a panic instead of returning a more descriptive error.
Thank you so much @alexec for your help :)

However I think it's worth investigating why using arguments.parameters[*].valueFrom.expression causes a panic (see the link to the docs). It should be legal but most importantly it causes a panic instead of returning a more descriptive error.

Yes. We should not panic. I think this is fixed by this commit:
https://github.com/argoproj/argo-workflows/commit/e2e046f6fded6581f153598100d3ccf9bb661912
So no action needed.

However I think it's worth investigating why using arguments.parameters[*].valueFrom.expression causes a panic (see the link to the docs). It should be legal but most importantly it causes a panic instead of returning a more descriptive error.

Yes. We should not panic. I think this is fixed by this commit:
e2e046f
So no action needed.

ok, wonderful. Thanks!
Maybe just the docs? I mean, I didn't understand if it's correct what I understood from the docs, which is 'expression' is a key of 'valueFrom'. My understanding is that It panics because such key is not expected there at all.


waveterm: init v0.7.6

Description of changes
This commit adds a new package: Waveterm with version 0.7.6. This also addresses the issue (package request) #280566
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@JohnRTitor It's the very first one

You need to actually modify https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix
See https://github.com/NixOS/nixpkgs/commit/76a55aafc1bf1b1cce70749a99ac173ae745ffd4 as an example commit

Thank you @Marin-Kitagawa ! You beat me to it 🥇 .
I tried cloning your repo and testing the package on my Mac with:
nix-build -A waveterm

But it couldn't found waveterm... How would I go about testing if this derivation works?

From within the repo
cd ./pkgs/applications/terminal-emulators/waveterm
nix-build default.nix

or
cd ./pkgs/applications/terminal-emulators/waveterm
nix-build -E 'with import <nixpkgs> {}; callPackage ./default.nix {}'

Tried on my M1 Mac and it fails... Here's the complete log:
this derivation will be built:
  /nix/store/8hbgzijgag9yws96hign55h59qgynl6l-waveterm-0.7.6.drv
building '/nix/store/8hbgzijgag9yws96hign55h59qgynl6l-waveterm-0.7.6.drv'...
Running phase: unpackPhase

7-Zip (z) 23.01 (arm64) : Copyright (c) 1999-2023 Igor Pavlov : 2023-06-20
 64-bit arm_v:8 locale=en_US.UTF-8 Threads:8 OPEN_MAX:1048576, ASM

Scanning the drive for archives:
1 file, 235140532 bytes (225 MiB)

Extracting archive: /nix/store/kvsb4dri9x3b8vrmrkd680nzgbm0ma8i-Wave-darwin-universal-0.7.6.dmg

4.apfs
WARNINGS:
There are data after the end of archive

--
Path = /nix/store/kvsb4dri9x3b8vrmrkd680nzgbm0ma8i-Wave-darwin-universal-0.7.6.dmg
Type = Dmg
Physical Size = 235140532
Method = Copy Zero2 ZLIB CRC
Blocks = 649
----
Path = 4.apfs
Size = 815717376
Packed Size = 235093621
Comment = disk image (Apple_APFS : 4)
Method = Copy Zero2 ZLIB CRC
--
Path = 4.apfs
Type = APFS
WARNINGS:
There are data after the end of archive
Physical Size = 815714304
Tail Size = 3072
Name = Wave 0.7.6-universal.apfs
ID = 9755c9ad66a643fba6ac7e965d8ac7b5
Cluster Size = 4096
Created = 2024-06-15 00:31:58.750708096
Modified = 2024-06-15 00:32:05.018548805
Comment =
{
block_size: 4096
fs_index: 0
volume_name: Wave 0.7.6-universal
vol_uuid: 7df71ec31cc34922b74b896cd720229e
incompatible_features: CASE_INSENSITIVE
fs_alloc_count: 159677
num_files: 117
num_directories: 159
num_symlinks: 15
num_other_fsobjects: 0
Num_Attr_Streams: 331
num_snapshots: 0
total_blocks_alloced: 162313
total_blocks_freed: 2688
unmounted: 2024-06-15 00:32:05.018549680
last_modified: 2024-06-15 00:32:05.016064388
formatted_by: newfs_apfs (2<IP_ADDRESS>.1)
  timestamp: 2024-06-15 00:31:58.750708096
  last_xid: 2
modified_by[0]: apfs_kext (2<IP_ADDRESS>.1)
  timestamp: 2024-06-15 00:32:05.018548805
  last_xid: 9

}

Everything is Ok

Archives with Warnings: 1

Warnings: 1
Folders: 159
Files: 117
Alternate Streams: 331
Alternate Streams Size: 676552
Size:       652740992
Compressed: 235140532
chmod: cannot access 'Waveterm.app': No such file or directory
error: builder for '/nix/store/8hbgzijgag9yws96hign55h59qgynl6l-waveterm-0.7.6.drv' failed with exit code 1;
       last 10 log lines:
       > Archives with Warnings: 1
       >
       > Warnings: 1
       > Folders: 159
       > Files: 117
       > Alternate Streams: 331
       > Alternate Streams Size: 676552
       > Size:       652740992
       > Compressed: 235140532
       > chmod: cannot access 'Waveterm.app': No such file or directory
       For full logs, run 'nix log /nix/store/8hbgzijgag9yws96hign55h59qgynl6l-waveterm-0.7.6.drv'.

I found the problem! Turns out you need to change the sourceRoot attribute to Wave.app. Now it unpacks and installs correctly. The only problem I have now is that when I try to run the program from result/Applications it says it's corrupted...

This happened to me before when I tried packaging Wave. I couldn't find other way that worked excepto for making the derivation impure and unpacking it like this:
unpackPhase = ''
          runHook preUnpack

          # Since the .dmg is using APFS we can't use undmg.
          # I also tried to use _7zz but it corrupts the .app.
          /usr/bin/hdiutil attach $src
          cp -r "/Volumes/Wave ${version}-universal/Wave.app" .
          /usr/bin/hdiutil detach "/Volumes/Wave ${version}-universal"

          runHook postUnpack
        '';

After this changes I can successfully run the app from finder in the result/Applications folder after building the derivation.

Is hdiutil available on nixpkgs? CC @DontEatOreo if there are any other solution

Is hdiutil available on nixpkgs?

Sadly no...
I'm not sure how this should be fixed. A workaround is to right-click and click open; then you will be allowed to actually open the program

(macOS moment...)

I saw the project is open source and it's written in Go, shouldn't we at least try to build it from source for Linux?

I saw the project is open source and it's written in Go, shouldn't we at least try to build it from source for Linux?

I was doing just that but Marin beat me to the PR! My current progress is this, the linux config is obtained from this thread I just merged it with the MacOS that worked for me.
(package.nix)
{
  lib,
  fetchurl,
  stdenvNoCC,
  fetchYarnDeps,
  mkYarnPackage,
  makeWrapper,
  copyDesktopItems,
  fetchFromGitHub,
  buildGoModule,
  breakpointHook,
  electron-bin,
  makeDesktopItem,
}: let
  pname = "waveterm";
  info = lib.importJSON ./info.json;
  genMeta = tag-version: {
    changelog = "https://github.com/wavetermdev/waveterm/releases/tag/v${tag-version}";
    description = "An Open-Source, AI-Native, Terminal Built for Seamless Workflows";
    homepage = "https://github.com/wavetermdev/wavetermn";
    license = lib.licenses.asl20;
    mainProgram = pname;
    platforms = lib.platforms.unix;
  };

  darwin = let
    version = info.darwin.version;
  in
    stdenvNoCC.mkDerivation (
      finalAttrs: {
        inherit pname version;
        meta = genMeta version;

        src = fetchurl {
          inherit (info.darwin) hash;
          url = "https://dl.waveterm.dev/releases/Wave-darwin-universal-${version}.dmg";
        };

        sourceRoot = ".";

        unpackPhase = ''
          runHook preUnpack

          # Since the .dmg is using APFS we can't use undmg.
          # I also tried to use _7zz but it corrupts the .app.
          /usr/bin/hdiutil attach $src
          cp -r "/Volumes/Wave ${version}-universal/Wave.app" .
          /usr/bin/hdiutil detach "/Volumes/Wave ${version}-universal"

          runHook postUnpack
        '';

        installPhase = ''
          runHook preInstall

          mkdir -p $out/Applications
          cp -r *.app $out/Applications
          chmod +x $out/Applications/*.app

          runHook postInstall
        '';
      }
    );

  linux = let
    version = info.linux.version;
    src = fetchFromGitHub {
      owner = "wavetermdev";
      repo = pname;
      rev = "v${version}";
      sha256 = info.linux.hash;
    };
    wavesrv = buildGoModule {
      inherit version src;
      preBuild = ''
        # go: 'go mod vendor' cannot be run in workspace mode. Run 'go work vendor' to vendor the workspace or set 'GOWORK=off' to exit workspace mode.
        # https://github.com/NixOS/nixpkgs/issues/203039
        export GOWORK="off";
      '';
      pname = "${pname}-wavesrv";
      modRoot = "./wavesrv";
      vendorHash = "";
      doCheck = false; # Currently fails at comp_test.go:91: comp-fail: ls f[*] + [foo bar] => [ls foo\ bar [*]] expected[ls 'foo bar' [*]]
    };
    waveshell = buildGoModule {
      inherit version src;
      preBuild = ''
        # go: 'go mod vendor' cannot be run in workspace mode. Run 'go work vendor' to vendor the workspace or set 'GOWORK=off' to exit workspace mode.
        # https://github.com/NixOS/nixpkgs/issues/203039
        export GOWORK="off";
      '';
      pname = "${pname}-waveshell";
      modRoot = "./waveshell";
      vendorHash = "";
    };
    electron = electron-bin;
  in
    mkYarnPackage rec {
      inherit pname src version;
      meta = genMeta version;

      packageJSON = "${src}/package.json";

      env.ELECTRON_SKIP_BINARY_DOWNLOAD = "1";

      offlineCache = fetchYarnDeps {
        yarnLock = "${src}/yarn.lock";
        hash = "";
      };

      nativeBuildInputs = [
        makeWrapper
        copyDesktopItems
        breakpointHook
      ];

      buildPhase = ''
        runHook preBuild

        pushd deps/${pname}
        node_modules/.bin/webpack --env prod
        popd

        runHook postBuild
      '';

      postBuild = ''
        pushd deps/${pname}

        mkdir ./bin
        cp ${wavesrv}/bin/cmd ./bin/wavesrv.amd64
        mkdir ./bin/mshell
        cp ${waveshell}/bin/waveshell ./bin/mshell/mshell-v0.6-linux.amd64

        yarn --offline run electron-builder \
          --dir \
          -l \
          -p never \
          -c electron-builder.config.js \
          -c.electronDist=${electron}/libexec/electron \
          -c.electronVersion=${electron.version}

        popd
      '';

      installPhase = ''
        runHook preInstall

        # resources
        mkdir -p "$out/share/lib/${pname}"
        cp -r ./deps/${pname}/make/*-unpacked/{locales,resources{,.pak}} "$out/share/lib/${pname}"

        # icons
        #install -Dm644 ./deps/${pname}/static/Icon.png $out/share/icons/hicolor/1024x1024/apps/${pname}.png

        # executable wrapper
        makeWrapper '${electron}/bin/electron' "$out/bin/${pname}" \
          --add-flags "$out/share/lib/${pname}/resources/app.asar" \
          --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}" \
          --inherit-argv0

        runHook postInstall
      '';
      # Do not attempt generating a tarball for contents again.
      # note: `doDist = false;` does not work.
      distPhase = "true";

      desktopItems = [
        (makeDesktopItem {
          name = pname;
          exec = pname;
          icon = pname;
          desktopName = "Wave Terminal";
          genericName = "waveterm";
          comment = meta.description;
          categories = ["System"];
          startupWMClass = pname;
        })
      ];
    };
in
  if stdenvNoCC.isDarwin
  then darwin
  else linux

(info.json)
{
  "linux": {
    "hash": "sha256-cHjBH6oijoAhdk2Ty1sl2GFXUUhfoToTuDUl5VuwKWU=",
    "version": "0.7.6"
  },
  "darwin": {
    "hash": "sha256-b75eQnUteQ767+crVe+gWfBf7PrrEjoNFVTx8s/jTXM=",
    "version": "0.7.6"
  }
}

I don't have a linux! So I can't really test it out, but accroding to the original author it works, just needs to setup the hashes!

That's, if you can conquer scripthaus

I'm not sure how this should be fixed. A workaround is to right-click and click open; then you will be allowed to actually open the program

Can confirm, this opens the application successfully!

That's, if you can conquer scripthaus

hahahaha I tried, but in the end followed the same route ErngWong took, translating the commands in scripthaus to  the native nix building blocks .

Can't we just do if stdenvNoCC.isDarwin then info.darwin.version else info.linux.version for meta? So it becomes
meta = {
  changelog = "https://github.com/wavetermdev/waveterm/releases/tag/v${
    if stdenvNoCC.isDarwin then info.darwin.version else info.linux.version
  }";
  description = "An Open-Source, AI-Native, Terminal Built for Seamless Workflows";
  homepage = "https://github.com/wavetermdev/wavetermn";
  license = lib.licenses.asl20;
  mainProgram = pname;
  platforms = lib.platforms.unix;
};

Can't we just do if stdenvNoCC.isDarwin then info.darwin.version else info.linux.version for meta? So it becomes

I'm on board with this change, don't really have any complaints about it.

Seems like the failing check is because

Look like v0.8 just got released https://waveterm.hashnode.dev/introducing-the-new-wave-terminal-v08


Add support for Redis 7's sharded pubsub commands

As I understand, there is no difference between the MESSAGEs sent to subscribers from PUBLISH or SPUBLISH commands. Both generate this response:
1) MESSAGE
2) <channel_name>
3) <message_data>

So if you use hiredis to SUBSCRIBE and also SSUBSCRIBE to channel "foo", when messages arrive it will be impossible to tell if it came from the sharded or the regular channel.

As I understand, there is no difference between the MESSAGEs sent to subscribers from PUBLISH or SPUBLISH commands.

Ah, you are right! That's an interesting twist..

There are ongoing discussions regarding this problem in https://github.com/redis/redis/issues/10748

Oh boy. Well, in the meantime, the official C library does not support the official API.


Page Plugin added

Verified changes on studio based for added plugin @webriq-pagebuilder/sanity-plugin-webriq-page on my local development setup.
Kindly publish this plugin to resolve studio branch deploy error and that we can test it on a studio preview URL as well. Thanks!


[Question]: Refresh logs me out. Is it expected?

What is your question?
When I refresh the page, I'm logged out. Is it a expected behavior or a bug?
More Details
When I refresh the page, I'm logged out. Then I have to enter my username and password again.
What is the main subject of your question?
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yeah, from what I've seen it's by design -- you can get around this by running it with npm run backend:dev

Does this disable the authentication completely? I'm expecting the login status to be saved for a while (like x days) as like the "remember me" option for other websites.

No, you still need to log in -- feel free to try this.


GPU task hangs the window for 5-60 seconds

Issue Type: Bug

Use the editor
Scroll the window
Type some stuff

Expected results: The editor should remain responsive
Observed results: The editor hangs for anywhere from 5-60 seconds.  The window cannot be resized.  This occurs regardless of where in the editor I am, and occurs both in the text editor, and within this "Issue Reporter" window.
The program is not using a high amount of CPU, and the system is not heavily loaded.  The system has plenty of RAM.  Extensions are disabled.
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

Memory (System)
15.93GB (9.26GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe --disable-extensions .

Screen Reader
no

VM
0%

Extensions disabled

@xobs does it reproduce if you run "code --disable-gpu" from the command line?

it happens to me when scrolling the terminal, hangs for a very long time! without any extensions :-/


[PDI - 6936] - Return Response Headers in HTTP POST/REST client Steps

Unit Tests for the Return Response Headers in HTTP POST/REST Client Steps fix.
many methods were added to the HTTP,HTTPOST and REST classes to make them more easily tested,
theses methods are them overrided in the respective tests to send the placeholders and injections required for testing
also added the responseHeaderFieldName to the saveLoadTests.

@pamval please review

@tgf, please review. this pull request is a review of #2006, adding unit tests.
I think I spotted some check-style violations in the new test classes, but am not sure.

@eliofreitas
I need you to please squash the commits before a full review; reach out if you need help with that
there is some inconsistent indentation and not just in the test classes, be sure to review that

@tgf squashed and updated

@eliofreitas thanks, please review checkstyle

@eliofreitas ping me when checkstyle is done

@tgf Checkstyle Done

@eliofreitas made some comments, please review
otherwise looks ok;

@tgf Updated

@eliofreitas see many gratuitous style changes in the last update, mostly spaces in array brackets;
see the comments and try to understand everything you're doing

@tgf updated

@tgf updated

@eliofreitas
sorry for taking so long to get back

avoid gratuitous style changes, they make this harder to review. if you must change indentation at least make it consistent
please drop the .gitignore changes for now
make sure new variables added are in camelCase, especially the ones i explicitly asked to be changed while changing method signatures in the last review
reach out about you last change to the variable replacement blocks in meta. they're not wrong but don't understand why you did that

@tgf updated

http://wingman.pentaho.com:8080/job/wingman/46/

http://<IP_ADDRESS>:8080/job/wingman-ant-cmd/18/

http://<IP_ADDRESS>:8080/job/wingman/53/


can't update covenant

Try to update our gardens covenant on staging the vote passes but the transaction continues to fail, I have tried increasing the gas amounts several times - here is some more data
the vote - https://gardens-staging.1hive.org/#/xdai/garden/0x16388d99199a74810fc572049b3d4d657e7d5deb/vote/5
the failed transaction - https://dashboard.tenderly.co/tx/xdai/0x4d8153d146b743c8f8a94d2f82937e0fceae2590dec1441683c8fb4595e40811
the script ran via EVM crispr v0.3.3 -
connect 0x16388D99199A74810fc572049b3d4D657e7D5deB disputable-voting.open @context:updating covenant
exec agreement.open changeSetting 0x44e4fcfed14e1285c9e0f6eae77d5fdd0f196f85 false "Giveth Community Covenant" 0x516d506e5a37534b374a7966476b71686e414a3877415076655773337a6568774c754c4459755931444e42477341

intial discussions point to the problem that AppFeesCashier is set to true even when you specify it as false via the script.
discussion on discord - https://discord.com/channels/698287700834517064/754870015357878304/930893379003383818

Fix with https://github.com/1Hive/gardens-ui/pull/805


skill: Add reasoning skill about siblings

This skill was inspired by one of the tests included in mt-bench. It
included some questions that the model answered incorrectly. When
given the same question manually, I got the following answer:

Q: David has three sisters. Each of them has one brother. How many
brothers does David have?
A: David has three sisters, and each of them has one brother, so it
must be the same brother in all cases. Therefore, David has 1 brother.

After a lab generate, lab train, and lab convert, I got a better
answer some of the time.

A: David having three sisters, each of them having one brother,
implies that David is their one brother. Therefore, David has no
brothers.

Or a correct but awkwardly phrased answer:

A: Based on the information provided, if each of David's three
sisters also has one brother, then that brother is David himself.
Therefore, David has no brothers since he is his own brother.

but sometimes still an incorrect answer:

A: David has three sisters, each of whom states that she has one
brother. This implies that David is indeed her brother, so David
has one brother.

A: David having three sisters, each of their statement confirms that
David is their brother. Therefore, David would have one brother, which
is himself, as stated in the question.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:
https://forms.gle/V7SrPPMZDo6iGDYu8


Navigation Guides -- make an Index Page for Guides and change the Quickstart to something so the navigation doesn't duplicate

The quickstart is currently the index page for the guides so when you select another guide, the top bar navigation is highlighted.
Fix the navigation so this doesn't happen or change the quickstart to a separate directory or make it an intro or something.

dublicated by #140

duplicate #140


Set message_visibility_limit to 10000 for Limited

[X] Set message_visibility_limit to 10000 for Limited

[x] Frontend for showing message history limit reached

[x] Backend for showing message history limit reached

@showell I have added tests for the backend.

To test the frontend, open shell ./manage.py shell in vagrant
from zerver.lib.message import update_first_visible_message_id
realm = get_realm("zulip")
realm.message_visibility_limit = 300 # How many messages should be shown to users
update_first_visible_message_id(realm)

Now open zulip realm and test the frontend.

I have only included the necessary CSS. There can be a separate PR for improving the message CSS.

@hackerkid what's the status of this PR?

@timabbott Its ready for a review.

I posted a few comments on the first couple commits (covering the logic).  @showell have you looked at the verify() tests for this yet?  It seems like there are a lot of them, and I wasn't sure if they've been looked at yet, or not.

I merged the first commit, after fixing the fact it incorrectly had a migration from the 4th commit, and pushed back to this PR.

@hackerkid I reviewed the second commit carefully.

One thing I discovered was that dbc412b8eb35ee09f7aca5cd46894ccae72afc04 needed to be done (I discovered this because one of your found_oldest values was wrong when I read the tests, but then the tests didn't fail after I fixed it).
For the bug we discussed in https://github.com/zulip/zulip/pull/10439#discussion_r224860898 is still present, I tagged the two tests that have the wrong result for this case.  We should open a follow-up issue for resolving that issue (or at least put it in a TODO list) for now.

So I merged that commit as 553c50ebfbcbfc1db45045e2160efdb9f6fbfc9c
I haven't re-reviewed the rest.

@timabbott I have rebased this. Can you take a look?
For testing do something like this and open the browser.
In [1]: from zerver.lib.message import update_first_visible_message_id

In [2]: realm = get_realm("zulip")

In [3]: realm.message_visibility_limit = 20

In [4]: realm.save()

In [5]: update_first_visible_message_id(realm)

I merged the first commit, after some small tweaks to comments and commit message.  Looking at the UI one now.

On a more substantive level, I didn't get my head completely around what happens when you have two simultaneous searches going on that were in the same direction.  If search A and search B both flip the same boolean, it seems like when the first search completes, that will unflip the boolean and make it appear for all purposes that both searches have finished.  Am I misunderstanding  that?

It's also not completely clear to me why fetch_status even needs to know about history_limited.  I don't have any strong objections to it being there, since FetchStatus is a super light class, and we certainly do similar things in other parts of the codebase (basically encapsulate one place where you can find state).  But do we actually need to persist it?
I kinda thought the path here would be that the server basically gives you the illusion that there are no more messages in a backfill once you hit the limit (even though you could go back further if you had a paid plan).  And then you don't need any special machinery on the JS side, except for messaging (but that could just be immediately looking at the boolean, no need to have it influence the message loading state).
I could be simply overlooking something here, so take it with a grain of salt.

Awesome, thanks for the comments!  I'm happy to just skip the "Just pass the data object" commit; I felt a lot more strongly about that before the deduplication work. The other approach would be to just add a comment noting that data is the API result from get_messages with a link.
I think persisting history_limited makes sense, at least for home_msg_list, for situations where you un-narrow; and I think we'll want it in a future world where we start caching in-memory MessageList objects even after you leave a given narrow.  The only thing we do with it on the JS side is let the user know they're missing out on some information with their search, but I think that is useful for helping people in the organization know that they should be campaigning to buy a paid plan.

On a more substantive level, I didn't get my head completely around what happens when you have two simultaneous searches going on that were in the same direction. If search A and search B both flip the same boolean, it seems like when the first search completes, that will unflip the boolean and make it appear for all purposes that both searches have finished. Am I misunderstanding that?

I don't believe doing two simultaneous searches in the same direction is possible with our current message_fetch architecture, at least with the same message list; if I'm not mistaken, the fetch_status logic prevents (e.g.) the on-scroll handler from trying to start a new message_fetch query in that direction in between the start and end events.

I dropped the commit that Steve wasn't a fan of, removed some now-duplicated calls to notifications.hide_or_show_history_limit_message in the last commit, edited the error message text a bit, and merged as the series ending with e5b3d39ce908a073ec2108d498a143364b37f3b4.  Huge thanks for doing this @hackerkid, and thanks for the thoughtful review @showell!
@rishig you should check out the UX for this to make sure you're happy with the wording and styling.


Update hongkong.py (Correct the day of The second day following the Chinese Mid-Autumn Festival )

Hi just found that 2022-09-12 is hong kong public holiday which call The second day following the Chinese Mid-Autumn Festival. But the script not show it is holiday.
I edited the file which can show me the right thing. Hope this can help.

Hi @poshingchu thank you very much for your contribution.
Unfortunately, tests are still failing, due to a misformatted line.
In order to ensure code is correctly formatted and passing all tests, you should run
tox
just before committing your work, and then add + commit all the relevant changes applied by tox (in case of any).
Available for further clarifications, thx!

#779 sorts this out.. I merged it, so this is not required anymore.. thx! 👍


Node process still running after shutdown while VSC tries to update uninstalls node

Does this issue occur when all extensions are disabled?: Unknown, might try to reproduce next udpate
Extensions used: nodemon, quokka, ESLint, prettier, vim, EJS language support

VS Code Version: 1.65.0
OS Version: windows 10

If you leave a node process running when you close VSC and VSC tries to update it will error partway through update leaving VSC uninstalled.
Steps to Reproduce: This has occurred a couple times now so not guaranteed reproducible as it depends on update

run some node process
vsc wants to update on restart
close vsc without ending node process
vsc automatically updates and fails

run some node process

How are you running the node process? In the integrated terminal?

vsc automatically updates and fails

What error are you seeing exactly? A screenshot would help.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Control code cell visibility and behavior with tags and metadata

Currently, all code cells that are parsed by MyST will include their input and outputs together.
Outputs can be inserted into the page via the {embed} directive, which allows you to remove the input, output, or include both.
However it's not possible to modify the behavior of the code cell itself, which makes it clunky if you want the code cell to exist on the same page where you want to embed its output.
It would be helpful if there were a way to control the visibility of the cell input and cell output from within a code cell.
How MyST-NB handles this
MyST NB accomplishes this by using Cell Metadata tags, with tags like the following:

remove-cell
remove-input
remove-output
hide-input (hides behind a toggle)
hide-output
skip-execution
raises-exception (to prevent errors from stopping the build process)

This was partially implemented here:
https://github.com/executablebooks/mystmd/pull/407
But I believe is undocumented on our side. I think at this stage, only the remove-cell/input/output is respected (no toggles). The tags are listed here:
https://github.com/executablebooks/mystmd/blob/main/packages/myst-common/src/types.ts#L34
There was an initial PR on this in the theme over here:

https://github.com/executablebooks/myst-theme/pull/129
Related issue: https://github.com/executablebooks/myst-theme/issues/50

We got the first part merged, but not the theme as there were changes to thebe that we needed to consider.

Ah nice - I've added a PR to document some of this here:
#1110
Agreed that there's still functionality that needs to be added, so we can use this to flesh out the behavior.

Sorry to bother you, but it seems remove-cell/input/output tags are not respected for PDF output for native jupyter code cells. From looking at https://github.com/executablebooks/mystmd/pull/407 it seems like it should work just as it does in Jupyter Book. It seems like #407 was merged at 1.0.2. I'm on 1.2.0. I'm not sure why its not working.

I am running into a similar issue (v1.2.3), where remove-input works, but hide-input does not. Not sure if this is not implemented yet, but interestingly, it throws a warning when you pass both tags.

@drewlio this should have been fixed in 1.3.3. Would you be able to check that for me? :)

I am running into a similar issue (v1.2.3), where remove-input works, but hide-input does not. Not sure if this is not implemented yet, but interestingly, it throws a warning when you pass both tags.

@agahkarakuzu could you possibly provide a reproducer?

@agoose77 I'll soon test this, sorry for the late reply!

@agoose77 versions are the following:
[2024-09-10 01:55:19,833: WARNING/ForkPoolWorker-7] ✓ Node.js is installed: v22.6.0
[2024-09-10 01:55:20,836: WARNING/ForkPoolWorker-7] ✓ mystmd is installed: v1.3.8

1. Hide input issue still persists.
For example, the first code block of this notebook of this myst article has the hide-input set true, yet the code cell is still visible with no toggle option.
2. Interactive figure outputs are generated, but not embedded
This 3D interactive plot was generated during myst build (with execute), but does not show up in the myst article.
3. Default article-theme dark?
I used to build articles with light-theme, but now by default it is dark, how can I set this back to light?

hide-input is a really nice option that I would love to have.


Look at getting lagoon-cli into homebrew

It would be good to have this in homebrew once binaries are released

to get started, we can set up as a tap
https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap


contrib: add support for Mac OS X hdiutil

Allow users to create a config-drive on Mac OS X.

LGTM


[bug] 0.1.2 breaks rendering on chrome mobile ios

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.1.2
wagmi Version
idk
Current Behavior
chrome mobile on ios shows the desktop UI on [0.1.2]. it was working fine before.
Expected Behavior
show mobile UI
Steps To Reproduce
use rainbowkit on ios chrome mobile app - see example link below
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://spinamp-git-rainbowbugdemo-noizd.vercel.app/connect
Anything else?
No response

wanted to follow up that this is also on the latest version 0.2.1. Sort of a really big issue that I can't use this at all on any browser besides safari on my iPhone. Besides re-writing the entire modal, cannot find a fix and it's very hard to debug in Chrome because Apple does not allow you to see the console from your computer while testing for Chrome using any typical tools I would use (direct connection, browser stack, etc.)

@musnit @sashadev-sky thanks for the issue description here!
I'm not currently seeing this in Chrome on iOS for either:

rainbowkit.com
https://rainbowkit-example.vercel.app/ (deployed w/ every new change to main, so this is technically ahead of the latest release. Source is in the /packages/example folder)

This leads to me to believe it might be something to do when your custom connect button implementation. Can you think of anything in your application that may be causing this?
As of writing this, we're on 0.2.2. Can you try upgrading and see if this resolves your issue? Or could you provide code for a minimal reproducible example ?

We can close this

Fixed in https://github.com/rainbow-me/rainbowkit/pull/434 for reference


Support Next.js 13?

Hi there, thanks for next-images! 🙌
Now that Next.js 13 is officially released, would you consider supporting this new version?
(maybe also version 11 and 12 as mentioned in the issues below)

#87
#73

Or is the recommendation now to switch to next/image as mentioned here:

#85

Currently next/image has bugs with:

dealing with CDN: https://github.com/vercel/next.js/issues/33488 which makes the change less attractive to someone using CDN for image hosting.
would not support expo
would not support legacy react apps
--
Possibly changes needed to get next-images to work are not such a large lift (current code is like 20 lines) and probably not much is needed to make it work in later versions of next.
Only problem I've encountered so far with next-images is with dynamicAssetPrefix (if I turn this off my previous set up does work). So I say we at least dig in to find out what exactly are the problems with next-images that make it not work in version 12/13 (by the way my next-images config works fine in v12.2.x but not 12.3.4) so I doubt that version 11 is actually not working unless for some edge case that I didn't try.


After update, all my camera feeds disappeared.

I have go2rtc running in a docker on unraid.  I have home assistant running as a VM on the same unraid server.  I have been using go2rtc  to stream my cctv cameras to my HA dashbaord (via webrtc).  After updating go2rtc this morning, all of my stream are not working and giving me an error "mse: stream not found".  Any suggestions as to where to start.

Old WebRTC integration doesn't support new go2rtc version


Data missing when using CassandraIO.Read

Bug
Data at the beginning or end of the token ring is never retrieved, due to a bad TokenRange request.
This bug was introduced by BEAM-9008, in this commit
A basic reproduction case & workarounds are available here:
Github/beam-cassandraio-bug
Description
When using {}CassandraIO{}, a list of token ranges is requested to C* nodes in order to create splits in those ranges.
A split will be represented as a RingRange resulting in a request to C* in the form of
TOKEN(partition_key) \>= range_start AND TOKEN(partition_key) < range_end
The token ring goes from Long.MIN_VALUE to Long.MAX_VALUE (so -2xxx to 2xxx), a range may contains the "join point" and be represented by [2xx, -2xxx].
In this case (Aka TokenRange isWrapping), old implementation used to send 2 different requests:

TOKEN(partition_key) >= range_start (To get result up to the end of the ring, i.e. Long.MAX_VALUE)
TOKEN(partition_key) < range_end (To get result from the beginning end of the ring, i.e. Long.MIN_VALUE)

Now, this behavior is not implemented anymore and token ranges are all called the same way, even in the wrapping case.
It results in a request like :
TOKEN(partition_key) >= 2XXX AND TOKEN(partition_key) < -2xxx
This gives 0 results, and some data is never retrieved.

WorkArounds

Downgrade to 2.33.0
Use customer TokenRanges & readAll implementation

Imported from Jira BEAM-14558. Original Jira may contain additional context.
Reported by: croquette.

Hey @damccorm,
Thanks for migrating the ticket.
In the README, it is written to create issues on JIRA, is there any changes ?

Whoops, thanks for calling that out. I updated a bunch of docs but missed that one - new issues should now be filed in the GitHub issues tab.
I put up #21718 to fix the Readme

@vmarquez any thoughts?

@pabloem this has been introduced in 2.34.0 so it is not new, but I do think you should be aware of it, in case someone has a quick fix or a rollback we can include in the next release

@kennknowles @damccorm My sincere apologies that this slipped in.  Unfortunately, the test cases didn't catch it, I didn't catch it with my local test cluster, and for our large workloads at work we use readAll for efficiency reasons.  To fix this issue,  I think we can add in two queries similar to how it was before we added in readAll.
https://github.com/apache/beam/pull/21786
is one possible solution, but I wanted more input here so I left it as WIP.


Change import paths for react-native 0.40

The import paths currently look like this:
#import <React/RCTLog.h>`

For react-native 0.39.x and newer it should look like this:
#import "RCTLog.h"

Generally problem not only in repo, but also in React Native itself, as I can see in RCTBridge it still some links to React/*

I would change the title of this issue to react-native 0.40 it's the version where this is really a problem.

Yeah, very true, as for myself I found solution to add this task to package and run after installing dependencies ( I really tied to 0.4 ) probably will be useful for someone
"compat": "[ ! -L node_modules/react-native/React/React ] && cd node_modules/react-native/React && find ./ -type l | xargs rm &&  ln -s Base React && ln -s Base/* ./$1"

These are the needed fixes, I tried adding them manually to my RN 0.40.0 project and it worked. l've requested the author create a pull request

I updated the pull request with recommendations from<EMAIL_ADDRESS>Could some one review/commit this?
https://github.com/johanneslumpe/react-native-fs/pull/242

do we need to do cocoapod for RNFS for RN 0.41.2
???

Thanks @benvium for merging.
@jjhesk not sure what you mean. It seems like the install instructions reference a local directory for cocoapods.
Closing this issue since it was addressed in #242


will it support log4net?

I use log4net in my project, so I wonder if Foundatio.Loggging will have a log4net appder?

Currently we only have one written for nlog (as that's what we use for our projects internally).  We'd be willing to accept a pull request for this.  I'm going to close this but we would be more than happy to accept a pr for this.
Here is a link to our nlog target: https://github.com/exceptionless/Foundatio/tree/master/src/Foundatio.Logging.NLog


Add Binary Trees / Red-black trees

seem like pretty standard data structures that this package should include - any reason against including them?

The package already includes 2-3 trees; these are the basis for SortedDict, SortedMultiDict, and SortedSet.  AFAIK, red-black trees are functionally equivalent to 2-3 trees but may offer a slight performance boost.  If you would like to try to implement red-black trees, then you could experiment to see if they are any better than 2-3 trees.
In my opinion, a preferable option, if you have the time, is to implement cache-oblivious B-trees (see the SIAM J. Comput, Bender et al).  My limited performance study on my Julia 2-3 trees seems to indicate that the biggest performance problem is caused by cache misses.  I have a long-term plan to implement the Bender et al technique myself, but I won't get to it in the near future.

ah I see it now - may be good to mention that it's included in the package in the docs.
Also I may give implementing the cache-oblivious trees a shot.
Regardless, I think this can be closed since I originally couldn't find any sort of tree implementation in this package.


Drop broken SupportNoneCgroupDriver support

Proposed Changes
Drop broken SupportNoneCgroupDriver support
Types of Changes
rootless
Verification
Run k3s rootless
Linked Issues
#3596
User-Facing Change

Rootless support now requires delegated cgroup v2 support.

Further Comments

Codecov Report

Merging #4065 (669d76e) into master (28be0de) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #4065   +/-   ##
=======================================
  Coverage   11.71%   11.72%
=======================================
  Files         133      133
  Lines        9013     9009    -4
=======================================
  Hits         1056     1056
+ Misses       7731     7727    -4
  Partials      226      226

Flag
Coverage Δ

inttests
0.68% <0.00%> (+<0.01%)
:arrow_up:

unittests
11.36% <0.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/daemons/agent/agent_linux.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28be0de...669d76e. Read the comment docs.


No module named 'binance.websockets'

Hi, first of all thank you very much for your work!
I have tried to set up the bot, I installed everything and modified the settings in the console but I get this error when I try to run the bot:
root@vultr:~/Binance-News-Sentiment-Bot# python3 -m news-analysis
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/root/Binance-News-Sentiment-Bot/news-analysis.py", line 34, in
from binance.websockets import BinanceSocketManager
ModuleNotFoundError: No module named 'binance.websockets'
sWhat do you suggest I do? Thanks in advance

I'm having the same issue.

Same here, the same issue , and 5 days ago it worked, but now ModuleNotFound

conda list | grep binance
packages in environment at /home/stepain/miniconda3/envs/binancebot:
python-binance            0.7.10                   pypi_0    pypi
python news-analysis.py
Press Ctrl-Q to stop the script
Bitcoin Price Weekly Update: 3rd May – 9th May 2021
WallStreetBets launches blockchain-powered app to decentralize indices
Visa Sees Bitcoin as Digital Gold | This Week in Crypto – May 3, 2021
.......
pip install python-binance --upgrade
conda list | grep binance
packages in environment at /home/stepain/miniconda3/envs/binancebot:
python-binance            1.0.4                    pypi_0    pypi
python news-analysis.py
Traceback (most recent call last):
File "news-analysis.py", line 36, in
from binance.websockets import BinanceSocketManager
ModuleNotFoundError: No module named 'binance.websockets'
i hope it helps.

https://github.com/sammchardy/python-binance/issues/170
seems like its inoperational

Hello there,
Is it possible this is related to python-binance package upgrade over 1.0.0+
I'm referring to this in their description:
https://github.com/sammchardy/python-binance#upgrading-to-v100

Yes, I'm currently running 0.7.1 and that's why I haven't been able to replicate the issue. 0.7.1 needs to be installed on your machine in order for this script to work. I will upgrade to 1.0.0 once that version is more stable :)


fix: empty resources in stack will generate panic

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):
apply and preview cmd

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
support empty resource in stack in some circumstances

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 8 (25.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.326%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/kusionctl/cmd/apply/options.go
1
4
25.0%

pkg/kusionctl/cmd/preview/options.go
1
4
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4571

Relevant Lines:
6320

💛  - Coveralls


Anyone using R2018a?

Is anyone using aa with R2018a?
We're currently using R2016b, but need to upgrade to use our cluster.
Cheers,
Mike

Yes, I am using it on both the Cambridge and the London clusters.
Vale,
Auer, Tibor ('99 Ph)