HBASE-25703 Support conditional update in MultiRowMutationEndpoint

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
5m 50s
master passed

+1 :green_heart:
checkstyle
1m 53s
master passed

+1 :green_heart:
spotbugs
7m 17s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
5m 48s
the patch passed

+1 :green_heart:
cc
5m 48s
the patch passed

+1 :green_heart:
javac
5m 48s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 238 unchanged - 1 fixed = 238 total (was 239)

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m  3s
the patch passed

+1 :green_heart:
spotbugs
8m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

77m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 75a28855b282 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 25s
master passed

+1 :green_heart:
compile
2m 40s
master passed

+1 :green_heart:
shadedjars
7m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
shadedjars
7m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 18s
hbase-client in the patch passed.

+1 :green_heart:
unit
139m 13s
hbase-server in the patch passed.

177m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6c710f30f6f5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/testReport/

Max. process+thread count
4064 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
2m 15s
master passed

+1 :green_heart:
shadedjars
7m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
2m 14s
the patch passed

+1 :green_heart:
javac
2m 14s
the patch passed

+1 :green_heart:
shadedjars
7m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-client in the patch passed.

-1 :x:
unit
155m  1s
hbase-server in the patch failed.

191m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 24619a82115c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/testReport/

Max. process+thread count
4287 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
compile
5m 44s
master passed

+1 :green_heart:
checkstyle
1m 50s
master passed

+1 :green_heart:
spotbugs
7m  2s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
5m 44s
the patch passed

+1 :green_heart:
cc
5m 44s
the patch passed

+1 :green_heart:
javac
5m 44s
the patch passed

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 238 unchanged - 1 fixed = 238 total (was 239)

+1 :green_heart:
checkstyle
1m  9s
The patch passed checkstyle in hbase-server

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 28s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m  9s
the patch passed

+1 :green_heart:
spotbugs
8m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

70m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 01229457e548 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
2m 41s
master passed

+1 :green_heart:
shadedjars
7m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

+1 :green_heart:
javac
2m 40s
the patch passed

+1 :green_heart:
shadedjars
7m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 16s
hbase-client in the patch passed.

+1 :green_heart:
unit
139m 17s
hbase-server in the patch passed.

176m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c80cb01fe8e5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/testReport/

Max. process+thread count
3897 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
2m 13s
master passed

+1 :green_heart:
shadedjars
7m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 16s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
2m 14s
the patch passed

+1 :green_heart:
javac
2m 14s
the patch passed

+1 :green_heart:
shadedjars
7m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
153m 58s
hbase-server in the patch passed.

189m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3098

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 16741807dcea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6a8998b29c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/testReport/

Max. process+thread count
4328 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3098/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Enable RackAware feature

Hi there, thanks for the contribution, looks good!
One small thing I need to ask before I merge this, can you commit another change to the inventory/static file and also set the rack in there to the default? (rack=/default-rack). This file acts as both an example and a default and I doubt many will change this setting if they don't need to (so best to use this default everywhere).
Thanks again!

Hi, i've just commit as you suggested.
Happy to contribute :)


Need a method to reload the tokenizers

Hi,
We need a method to reload the tokenizer, with the new set of values. So, that I can change the values in the client side itself.
Thanks,
Raghu

Just update the select options with javascript


Newsletter 12: Add Canon Collision

https://github.com/rust-gamedev/rust-gamedev.github.io/issues/201
Hope you dont mind me rewriting history a little, seems like it was missed that this is actually a different project :)

Merged, thanks for the PR! :)


Confusing licensing around Phone System and Calling Plans

This page says "Phone System and Calling Plans can be purchased with Skype for Business Online Plan 2 to enable voice calling features," but others suggest that Phone System & Calling plan can not be added to Office 365 / Microsoft 365 Business plans (and instead require enterprise plans). Can you please clarify?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 390e7a34-ce99-5641-3007-9ab2afd3b2b8
Version Independent ID: 5e2a796d-6377-a40b-7dbe-c75d40f73ab1
Content: Office 365 Premium, Office 365 ProPlus, or Skype for Business Online Plan 2
Content Source: Skype/SfbOnline/skype-for-business-and-microsoft-teams-add-on-licensing/license-options-based-on-your-plan/office-365-premium-pro-plus-or-business-online-plan.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@semenko - Thank you for submitting this feedback.
This is a good catch on how to make the article clearer and what needs adjustment so this article and the other article you reference don't cause confusion.
I was able to get this into the backlog for the Skype team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hi @semenko , it was updated. If you have Skype for Business Online Standalone Plan 2 you should move to different business plan. You can move to E3 and use add-ons but your best option would be move to E5.
Thank you for your feedback!


Cannot remove X-Forwarded-For

Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?

[ ] Yes
[X] No

What did you do?
Given the following service and middleware, Traefik automatically adds some headers that cannot be removed as seen on the documentation.
I need to remove the X-Forwarded-For, X-Forwarded-Host and X-Forwarded-Proto to mimic NGINX's behavior. Unfortunately the X-Forwarded-For header cannot be removed.
The configuration I'm using should do the following:
What did you expect to see?
dvitali@ded1:nginx/sites-enabled $ nc -l <IP_ADDRESS> 8078
GET /v2/ HTTP/1.0
Host: <IP_ADDRESS>:8078
Connection: close
User-Agent: docker/18.09.9 go/go1.11.13 git-commit/039a7df9ba kernel/4.14.141-boot2docker os/linux arch/amd64 UpstreamClient(Docker-Client/19.03.2 \(darwin\))
Accept-Encoding: gzip

What did you see instead?
 This header is set up by low level goland libraries, traefik relies upon, so there is no obvious/easy way of changing that. Can you explain your use case so I could understand better why this is a problem?

OVH's Private Registry behaves unexpectedly when that header is set, because they do reverse-proxy (and SSL termination) with NGINX. Using NGINX instead of Traefik solves the issue, but we don't want to do that 🤷♂

THe X-Forwarded header can be removed by using: https://docs.traefik.io/v2.1/routing/entrypoints/#forwarded-header

@ldez,
This issue is not about X-Forwarded that you mentioned in your comment it's about  X-Forwarded-For header, note the trailing -For.
Here is what article you linked gives us:

Note, this does NOT mention  X-Forwarded-For header, it also does NOT mentione removal or deletions of headers.
Could you please clarify?

I wrote X-Forwarded to speak about X-Forwarded-* headers.
X-Forwarded-* are:
https://github.com/containous/traefik/blob/125470f1106373ff42cf03ae28467055a8186de5/pkg/middlewares/forwardedheaders/forwarded_header.go#L12-L38

@ldez so how does one remove X-Forwarded-For header?

This remove the X-Forwarded-* headers from the client request, but it's doesn't remove X-Forwarded-* from Traefik.
So yes, it's not possible to remove completely those headers
Like you said:

This header is set up by low level golang libraries, traefik relies upon, so there is no obvious/easy way of changing that.

Should we reopen the issue then? I'm exactly interested in removing those headers from Traefik

I think that an HTTP Proxy should always add X-Forwarded-* headers, but may be you should use a TCP Proxy instead?

If you're forwarding the traffic and want to make it transparent (therefore use only the Host header), you should be able to do so. NGINX seems to forward the X-Forwarded-For header when reverse proxying.
My problem was caused by a request coming to Traefik, which was forwarded (with X-Forwarded-For) headers to an NGINX which in turn forwards it to an internal service. Unfortunately NGINX wasn't forwarding the request properly when the X-Forwarded-For header was set. Since this NGINX proxy was not in my control, my only alternative was to use another reverse proxy between Traefik and NGINX.
If you look closely the X-Forwarded-For headers in the issue description, you can clearly see that they're meaningless. X-Forwarded-For refers to an internal IP used by traefik, therefore the NGINX server will try to match that to propagate the request, and will eventually fail / set it to the reverse proxy request.
The specific use case is:
Traefik -> NGINX -> Harbor
Both Harbor and NGINX are controlled by OVH (it's their managed Docker Registry)


ingest segment firehose ut

that exposes the issue causing https://github.com/druid-io/druid/issues/1785
Note: this can only be merged when java-utils 0.27.4 is released with https://github.com/metamx/java-util/pull/32 merged.
Bug is caused because QueryableIndexStorageAdapter.makeCursor(..) returns a Sequence which assumes that caller will go to next Cursor only after reading the previous cursor fully. This assumption allows the implementation to reuse some of the objects and be faster. Also, I confirmed with @cheddar, by design, it is expected for ConcatSequence go to to next sequence only after reading previous sequence fully.
Fixes https://github.com/druid-io/druid/issues/1785

smoosh formats change over time, can the UT create the index files at run time?

@drcrallen ok will create the segment on each test run, had created and stored the segment for UT to be faster (in general though, druid code would stay backward compatible with existing segments)

@drcrallen updated to create test segment used on each run

:+1:

:+1:


BAU: Breaking down work

This is a cut down version of the longer blogpost: https://blog.probablyfine.co.uk/2024/09/27/why-breaking-down-work-is-important.html

I have folded in your suggestions @sarahseewhy @louzoid-gds - the post is linked from the side nav next to pair programming, and also within the continuous delivery content as a one-liner with the link.


Want to add Square Root Decomposition Method to Algo section

Hi @ericklarac,
Can we add Mo's Algo and Square root Decomposition method to the Repo?
Let me know if we have the possibility?

@hardik-dadhich feel free to add it.

I would like to work on this, since it doesn't seem to have been implemented yet. I hope that is alright.


Anonymous configuration does not accept consumer username.

Summary
According to https://github.com/Kong/kong/pull/4972 the anonymous configuration field should accept both a consumer ID and a consumer username, yet it throws a schema error when trying to use a username.
Steps To Reproduce

Setup an authentication plugin
Do the following curl call:

curl -i -X PATCH \
   --url http://kong:8001/plugins/<auth-plugin-id>\
   --data "config.anonymous=<anonymous-username>"

response body:
{
   "message":"schema violation (config.anonymous: expected a valid UUID)",
   "name":"schema violation",
   "fields":{
      "config":{
         "anonymous":"expected a valid UUID"
      }
   },
   "code":2
}

Additional Details & Logs

Kong version: 2.0.0
Using Kong Docker container
Configuration:

{"plugins":{"enabled_in_cluster":["jsonrpc-request-transformer","jwt","acl","request-termination","jwt-crafter","account-swap","basic-auth"],"available_on_server":{"correlation-id":true,"pre-function":true,"cors":true,"ldap-auth":true,"loggly":true,"hmac-auth":true,"zipkin":true,"request-size-limiting":true,"azure-functions":true,"jwt-crafter":true,"request-transformer":true,"oauth2":true,"response-transformer":true,"ip-restriction":true,"statsd":true,"jwt":true,"proxy-cache":true,"basic-auth":true,"key-auth":true,"jsonrpc-request-transformer":true,"http-log":true,"account-swap":true,"datadog":true,"tcp-log":true,"post-function":true,"prometheus":true,"acl":true,"syslog":true,"file-log":true,"session":true,"udp-log":true,"response-ratelimiting":true,"aws-lambda":true,"bot-detection":true,"rate-limiting":true,"request-termination":true}},"tagline":"Welcome to kong","configuration":{"plugins":["bundled","jsonrpc-request-transformer","jwt-crafter","account-swap"],"admin_listen":["<IP_ADDRESS>:8001"],"proxy_access_log":"\/dev\/stdout","prefix":"\/usr\/local\/kong","nginx_conf":"\/usr\/local\/kong\/nginx.conf","cassandra_username":"kong","nginx_events_directives":[{"value":"auto","name":"worker_connections"},{"value":"on","name":"multi_accept"}],"dns_resolver":{},"nginx_upstream_keepalive_requests":"100","nginx_http_upstream_directives":[{"value":"100","name":"keepalive_requests"},{"value":"60s","name":"keepalive_timeout"},{"value":"60","name":"keepalive"}],"nginx_main_daemon":"off","stream_proxy_ssl_enabled":false,"nginx_acc_logs":"\/usr\/local\/kong\/logs\/access.log","pg_semaphore_timeout":60000,"proxy_listen":["<IP_ADDRESS>:8000 reuseport backlog=16384","<IP_ADDRESS>:8443 http2 ssl reuseport backlog=16384"],"client_ssl_cert_default":"\/usr\/local\/kong\/ssl\/kong-default.crt","go_pluginserver_exe":"\/usr\/local\/bin\/go-pluginserver","dns_no_sync":false,"db_update_propagation":0,"stream_listen":["off"],"nginx_err_logs":"\/usr\/local\/kong\/logs\/error.log","cassandra_port":9042,"headers":["server_tokens","latency_tokens"],"nginx_http_client_max_body_size":"0","status_listen":["off"],"dns_stale_ttl":4,"cluster_control_plane":"<IP_ADDRESS>:8005","nginx_http_ssl_prefer_server_ciphers":"off","pg_database":"kong","lua_package_cpath":"","admin_acc_logs":"\/usr\/local\/kong\/logs\/admin_access.log","cassandra_refresh_frequency":60,"nginx_pid":"\/usr\/local\/kong\/pids\/nginx.pid","nginx_main_worker_rlimit_nofile":"auto","admin_access_log":"\/dev\/stdout","proxy_listeners":[{"listener":"<IP_ADDRESS>:8000 reuseport backlog=16384","proxy_protocol":false,"reuseport":true,"deferred":false,"ssl":false,"ip":"<IP_ADDRESS>","backlog=16384":true,"http2":false,"port":8000,"bind":false},{"listener":"<IP_ADDRESS>:8443 ssl http2 reuseport backlog=16384","proxy_protocol":false,"reuseport":true,"deferred":false,"ssl":true,"ip":"<IP_ADDRESS>","backlog=16384":true,"http2":true,"port":8443,"bind":false}],"db_cache_warmup_entities":["services","plugins"],"enabled_headers":{"latency_tokens":true,"X-Kong-Response-Latency":true,"Server":true,"X-Kong-Admin-Latency":true,"X-Kong-Upstream-Status":false,"Via":true,"X-Kong-Proxy-Latency":true,"server_tokens":true,"X-Kong-Upstream-Latency":true},"nginx_http_ssl_protocols":"TLSv1.2 TLSv1.3","db_cache_ttl":0,"nginx_events_multi_accept":"on","admin_ssl_cert_default":"\/usr\/local\/kong\/ssl\/admin-kong-default.crt","pg_ssl":false,"status_access_log":"off","cluster_listeners":[{"listener":"<IP_ADDRESS>:8005","proxy_protocol":false,"reuseport":false,"backlog=%d+":false,"deferred":false,"ssl":false,"ip":"<IP_ADDRESS>","port":8005,"http2":false,"bind":false}],"kong_env":"\/usr\/local\/kong\/.kong_env","cassandra_schema_consensus_timeout":10000,"log_level":"notice","admin_ssl_cert_key_default":"\/usr\/local\/kong\/ssl\/admin-kong-default.key","real_ip_recursive":"off","proxy_error_log":"\/dev\/stderr","ssl_cipher_suite":"intermediate","router_consistency":"strict","pg_port":5432,"cassandra_keyspace":"kong","ssl_cert_default":"\/usr\/local\/kong\/ssl\/kong-default.crt","nginx_http_ssl_session_timeout":"1d","error_default_type":"text\/plain","role":"traditional","admin_ssl_enabled":false,"trusted_ips":{},"loaded_plugins":{"session":true,"pre-function":true,"cors":true,"ldap-auth":true,"loggly":true,"hmac-auth":true,"zipkin":true,"request-size-limiting":true,"azure-functions":true,"jwt-crafter":true,"request-transformer":true,"oauth2":true,"response-transformer":true,"syslog":true,"statsd":true,"jwt":true,"proxy-cache":true,"basic-auth":true,"key-auth":true,"jsonrpc-request-transformer":true,"http-log":true,"account-swap":true,"datadog":true,"tcp-log":true,"post-function":true,"correlation-id":true,"acl":true,"rate-limiting":true,"bot-detection":true,"ip-restriction":true,"udp-log":true,"response-ratelimiting":true,"aws-lambda":true,"file-log":true,"prometheus":true,"request-termination":true},"nginx_supstream_directives":{},"ssl_cert_key":"\/usr\/local\/kong\/ssl\/kong-default.key","pg_user":"kong","pg_password":"******","cassandra_data_centers":["dc1:2","dc2:3"],"nginx_admin_directives":{},"nginx_upstream_keepalive_timeout":"60s","nginx_http_directives":[{"value":"0","name":"client_max_body_size"},{"value":"off","name":"ssl_prefer_server_ciphers"},{"value":"8k","name":"client_body_buffer_size"},{"value":"TLSv1.2 TLSv1.3","name":"ssl_protocols"},{"value":"on","name":"ssl_session_tickets"},{"value":"1d","name":"ssl_session_timeout"},{"value":"prometheus_metrics 5m","name":"lua_shared_dict"}],"pg_host":"db-kong","nginx_kong_stream_conf":"\/usr\/local\/kong\/nginx-kong-stream.conf","ssl_cert_key_default":"\/usr\/local\/kong\/ssl\/kong-default.key","go_plugins_dir":"off","cluster_listen":["<IP_ADDRESS>:8005"],"dns_order":["LAST","SRV","A","CNAME"],"dns_error_ttl":1,"nginx_sproxy_directives":{},"nginx_http_upstream_keepalive_timeout":"60s","pg_timeout":5000,"nginx_http_upstream_keepalive_requests":"100","database":"postgres","nginx_upstream_keepalive":"60","nginx_worker_processes":"auto","nginx_http_status_directives":{},"lua_package_path":".\/?.lua;.\/?\/init.lua;","router_update_frequency":1,"upstream_keepalive":60,"pg_max_concurrent_queries":0,"proxy_ssl_enabled":true,"nginx_http_upstream_keepalive":"60","lua_socket_pool_size":30,"db_resurrect_ttl":30,"mem_cache_size":"128m","cassandra_consistency":"ONE","client_max_body_size":"0","admin_error_log":"\/dev\/stderr","pg_ssl_verify":false,"dns_not_found_ttl":30,"nginx_http_ssl_session_tickets":"on","ssl_ciphers":"ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384","client_ssl":false,"cassandra_repl_strategy":"SimpleStrategy","status_error_log":"logs\/status_error.log","ssl_cert_csr_default":"\/usr\/local\/kong\/ssl\/kong-default.csr","nginx_status_directives":{},"nginx_stream_directives":[{"value":"stream_prometheus_metrics 5m","name":"lua_shared_dict"}],"nginx_kong_conf":"\/usr\/local\/kong\/nginx-kong.conf","real_ip_header":"X-Real-IP","dns_hostsfile":"\/etc\/hosts","admin_listeners":[{"listener":"<IP_ADDRESS>:8001","proxy_protocol":false,"reuseport":false,"backlog=%d+":false,"deferred":false,"ssl":false,"ip":"<IP_ADDRESS>","port":8001,"http2":false,"bind":false}],"nginx_main_worker_processes":"auto","ssl_cert":"\/usr\/local\/kong\/ssl\/kong-default.crt","nginx_proxy_real_ip_recursive":"off","nginx_events_worker_connections":"auto","cassandra_ssl_verify":false,"cassandra_timeout":5000,"cassandra_repl_factor":1,"db_update_frequency":5,"nginx_optimizations":true,"client_ssl_cert_key_default":"\/usr\/local\/kong\/ssl\/kong-default.key","nginx_daemon":"off","anonymous_reports":true,"nginx_main_directives":[{"value":"off","name":"daemon"},{"value":"auto","name":"worker_rlimit_nofile"},{"value":"auto","name":"worker_processes"}],"status_listeners":{},"cassandra_ssl":false,"cassandra_contact_points":["db-kong"],"client_body_buffer_size":"8k","nginx_proxy_real_ip_header":"X-Real-IP","stream_listeners":{},"nginx_http_client_body_buffer_size":"8k","cassandra_lb_policy":"RequestRoundRobin","nginx_upstream_directives":[{"value":"100","name":"keepalive_requests"},{"value":"60s","name":"keepalive_timeout"},{"value":"60","name":"keepalive"}],"nginx_proxy_directives":[{"value":"X-Real-IP","name":"real_ip_header"},{"value":"off","name":"real_ip_recursive"}],"lua_ssl_verify_depth":1},"version":"2.0.0","node_id":"449e05d9-2db4-4f7c-b9ff-30a643e979ec","lua_version":"LuaJIT 2.1.0-beta3","prng_seeds":{"pid: 95":422622718018,"pid: 94":234101252511,"pid: 96":616530252242,"pid: 97":120601629351,"pid: 1":224156182989},"timers":{"pending":7,"running":0},"hostname":"39ec5d65eafc"}

This is the Kong-only version of https://github.com/hbagdi/deck/issues/69#issuecomment-584134737.

I've reproduced this and have a fix. Working through tests and will open up a PR.

Looking forward to the PR & thank you for the incredibly quick responses!

@hbagdi should this be fixed in Docker container kong:latest? That image is two days old, like your commit.
For later reference I talk about digest: df5f1753c7b94726eb81979b87fe6eec1ffbfe57691f37d6b05e04e12095865f

should this be fixed in Docker container kong:latest?

No. That image is not updated with any commits in this repo.

I don't understand, Do you mean branch?
That is the Kong container and this is the Kong repository. What else should be in there?

The kong Docker repository only contains tagged images of Kong versions that are released for public use.
Please wait until the above PR is merged in and for Kong 2.0.2.
Thank you for your continued patience.

I see, no problem, thanks for all your effort and speedy replies!

@hbagdi can we get this fix back port to 1.4/1.5?
would be good to use validation controller with stable branch
and 1.5 is broken, previous consumerRef no longer work after migrate from 1.4
it always require UUID

Please upgrade to Kong 2.0. It doesn't contain many breaking changes. If you are using Kong Ingress Controller, then you won't see any breaking  changes at all for most deployments.

@hbagdi thank you for addressing this issue! We are using Kong v1.5.1. with Ingress Controller v0.7.x and we see the same issue, but we can not upgrade to 2.x yet. Is it possible to back port this fix to 1.5.x?


Raise some kind of error on reserved repository names

setup = ROM.setup(database: 'mysql2://<connection details>')
setup.database.use_logger(LOGGER)

This blows up with the following error:
/Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/adapter.rb:97:in `block in []': undefined method `to_sym' for nil:NilClass (NoMethodError)
        from /Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/adapter.rb:97:in `each'
        from /Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/adapter.rb:97:in `detect'
        from /Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/adapter.rb:97:in `[]'
        from /Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/config.rb:39:in `build'
        from /Users/kwando/projects/gems/test-rom/vendor/bundle/ruby/2.2.0/gems/rom-0.5.0/lib/rom/global.rb:37:in `setup'
        from sms_test.rb:9:in `<main>'

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

This is a nasty gotcha where config-parsing class thinks "database" key means it's a hash coming from a database.yml file. This needs to be improved so that a user gets a nice error message that "database" is a reserved key.

@solnic: Please correct me if I'm wrong.
ROM::Config is being moved to rom-rails as part of rom-rb/rom-rails#16, so ROM will only support the following two formats:
ROM.setup(database: 'mysql2://foo')
ROM.setup(database: {uri: 'mysql2://foo', options: {foo: 'bar'}})

:database will not be a reserved key after the change.

@aflatter add ROM.setup('mysql://foo') to the list and then I can say "yes, correct" :)

This is now fixed along with a new syntax:
# this will work
setup = ROM.setup(database: [:sql, 'mysql2://localhost'])


Support query conditions that compare an attribute to null.

SC-24795
This PR adds new APIs to QueryCondition:
public static QueryCondition CreateIsNull(Context ctx, string attribute_name);
public static QueryCondition CreateIsNotNull(Context ctx, string attribute_name);

that allow creating query conditions that compare whether a nullable attribute is null or not.
As for the naming, another idea is CreateEqualsNull or CreateNotEqualsNull but it's longer and x is null is valid C# since quite some time.

I added tests. Let's see what CI thinks.


Fortune Teller Using Python

I have made a Fortune Teller using Python. That will ask the user for a question and will give an answer.

@prathmesh-Chaudhari05 I'm getting the following error -

Can you share the output of the program?

Can I make a new PR with this program...!! @tasnimzotder


[Change request] To redesign the "Newest" section on the Main Page.

As a user I want to see the last published materials cards in the "Newest" section so that I can learn the newest information.
Acceptance Criteria:

The field is divided into four parts with names: “Думки експертів”, “Переклади”, “Медитека”, “Відео”. They are clickable.

When the user clicks on the name of each part and a line with an arrow, the Materials page will be opened with the materials sorted by this filter.

Every part contains four latest loaded material cards.

Material cards will move from the left side to the right side when new materials are published. It works for all parts of the "Newest" section.

Material page should be opened by clicking on the material card.

Material cards are described in #229.

Reason for Change:
Receiving changes from the client`s side. It was approved on the 29th of March.
The design of the "Newest" section is available on Figma mock-up by the link.
Change request to US #12, to CR #224.

BA check 19/07/21
Not accepted.
"Відео", “Думки експертів”, “Переклади” parts don’t contain four latest loaded material cards.


Bump cf and bosh-init versions

Older versions of bosh-init no longer works on azure

We no longer use this script; and have instead moved over to the jumpbox-boshrelease.  Have you tried that?  It has a CI pipeline feeding it the very freshest of cf-cli and (soon) bosh-init.

Yes I use that bosh release.  This one is for "I don't even have a bosh on this cloud yet and would like to install it, vault, concourse, etc"

Fair enough


Warning with vue/compat: ATTR_ENUMERATED_COERCION

Steps to reproduce
Using 3.0.0-beta.1 version while migrating a Vue 2 project to Vue 3 I get ATTR_ENUMERATED_COERCION warning.
Expected behaviour
No warning should show up.
On file Multiselect.vue line 54 there is an attribute spellcheck="false" that might be what's causing the issue
Actual behaviour
A warning ATTR_ENUMERATED_COERCION shows up

@mattelen i'm getting this in v3.0.0-beta.2.. Is it fixed?

Even though compatConfig is set, warning still shows up.

Exactly. @mattelen please review https://github.com/shentao/vue-multiselect/pull/1708

I am also seeing this and I believe the fix in #1708 should do the trick. Thanks!

Just to add the version for anyone reading this thread - it is fixed in v3.0.0-beta.3


Services Not Being Discovered on Android 14?

I have an app that needs to discover a zeroconf service and it's working fine on Android 13 devices but on Android 14 it seems like no services ever get resolved. I do not personally own an Android 14 device and it doesn't seem possible to get this working in an android emulator so I unfortunately don't have any more details. Hopefully someone else can either confirm this library isn't working on android 14 or that it does.

Can confirm the same behaviour for me.
Totally fine on Android 13 handset, not fine on Android 14 handset

It's working for me on Android 14, I ultimately had to add usesCleartextTraffic to the manifest


go.mod: use go 1.22.0

#947 needed a go version update in the go.mod which dependabot didn't change.
After I added the change myself, I remembered it needs changes in more places.
Instead of polluting the dependabot PR with all this, let's do the change separately so it's more visible and I'll have dependabot rebase the PR after it's merged.

Ok, updating golanglint-ci worked.    Better get fixing.

Hold off on merging, please.  I'm discussing the rng seed with @mvo5.

This breaks image builder which uses downstream Go Toolbox from UBI which sitting at 1.21.13 at the moment. I do not think this hard dependency can be updated to 1.22 or even 1.23 for tools yet:
https://github.com/osbuild/image-builder/pull/1363

Do you know if the next release of the UBI Go Toolbox will be 1.22?  Afaik, 9.5 will ship with Go 1.22.  And osbuild-composer in 9.5 will still be using 1.21 anyway, since the version for that is already frozen.

I do not know. But we are unable to upgrade images in image builder until it happens. From prior history, 1.21.13 was released 2024-08-06 but updated in UBI 2024-10-03. That is 2 months lag, I suggest to hold on these upgrades in the library by pinning those dependencies which require new version of Go. Unfortunately, Go tools themselves does not have any features for that, what we did in the past was simply reinstalling particular versions after full update:
# update to latest and greatest
go get -u ./...

# pin specific libs
go get -u<EMAIL_ADDRESS>
# and modify the go.mod back to a reasonable version
go mod tidy

Something like that.


Switch annotations from @ApiStatus.Internal to @ApiStatus.Experimental for utility classes.

@ApiStatus.Experimental implies that the class is usable, but is expected to change often and break code.
This annotation in my opinion fits utility classes better than the current @ApiStatus.Internal which implies that the class is used only for internal code and shouldn't be used as a public API, but in my opinion, the utility classes affected are okay to be included as apart of the API.

I am personally not convinced. As those methods are unlikely to ever be considered "stable"


Create a new config option to allow only Admins to create new subs

This PR adds a new config option in config.yaml to allow only Admins to create new subs.

Defaults to False.
When enabled, it both hides the "Create a Sub" sidebar button from non-admin users, and also throws an error if they try to submit the CreateSub form.

Those changes should all be pushed now @Polsaker! Thanks :)


Upgrade to Electron 1.6.1

Chrome 56
Node 7.4.0

See https://github.com/electron/electron/releases/tag/v1.6.1.
Closes #92

Fantastic! Thank you again 👍 :1st_place_medal:


Issues with migration after install

Hello!
I installed netbox-documents v0.6.4 in my Netbox 3.6 Installation (its that old because i need some plugins which havent been officially supported in newer versions like this one) and im getting this error:
django.db.migrations.exceptions.NodeNotFoundError: Migration netbox_documents.0006_vmdocument dependencies reference nonexistent parent node ('extras', '0106_bookmark_user_cascade_deletion')
All i do is to execute python3 manage.py migrate after i installed everything and added it to the configuration.py. Could somebody please tell me what i need to do?
Thanks!

You need a more up to date version of netbox, or an older version of the plugin. The error indicates a dependency on a migration that's part of core netbox but that is not present in your instance.

As mentioned in the other issue i wasnt aware of that since i installed the plugin version for 3.6 and because its not mentioned with v4 i didn know it should work with v4. Im trying a newer version now...

👀

Version 0.7.0 of the plugin is released to be compatible with Netbox 4.0+


[stable/nginx-ingress] Fix broken link in README

What this PR does
Fix a broken link in README.
Checklist

[x] DCO signed
[x] Title of the PR starts with chart name (e.g. [stable/chart])

Thanks for the PR! Despite the fact that this is just a documentation change you still have to bump the version of the chart, otherwise lint/test will fail.
/ok-to-test

/retest

/ok-to-test

/lgtm


Are negative units allowed?

Is there any sense to allowing negative units, e.g. definitions of the following form:
negawatt :: Unit DEnergy
negawatt = prefix (-1) (mega watt)

I don't believe there is. I am contemplating a change that would make it less fully supported, and I'm wondering if perhaps it should be banned outright as unexpected and a potential trap.
AFAICS, the NIST Guide doesn't have anything to say about this. The UCUM disallows it, see http://unitsofmeasure.org/ucum.html#section-Syntax-Rules.

To be clear, this is fully supported right now with no problems that I can see. It does exactly what you would expect it to do, provided you would expect it to do something.

As far as I am concerned dropping support for negative units is not a problem, so don't let them hold you back!
As for banning them outright I don't know if I feel it is necessary, unless they are otherwise less fully supported (e.g. by your contemplated change).

On 16 apr 2015, at 04:44, Douglas McClean<EMAIL_ADDRESS>wrote:
Is there any sense to allowing negative units, e.g. definitions of the following form:
negawatt :: Unit DEnergy
negawatt = prefix (-1) (mega watt)
I don't believe there is. I am contemplating a change that would make it less fully supported, and I'm wondering if perhaps it should be banned outright as unexpected and a potential trap.
AFAICS, the NIST Guide doesn't have anything to say about this. The UCUM disallows it, see http://unitsofmeasure.org/ucum.html#section-Syntax-Rules.
—
Reply to this email directly or view it on GitHub.

Came back to look at this after realizing (in another thread) that, while negative units are merely head-scratching, zero units are pretty awful.
It turns out we can't really ban them, because we don't have enough context in prefix :: Num a => a -> Unit d a -> Unit d a to discriminate based on the sign of the supplied coefficient.
Adding an Eq context (which would be enough for either purpose, because signum is in Num) isn't desirable because we'd lose the ability to operate with certain useful abstract number types.
Going to add a stern warning against using zero to the documentation, and a note that using negative values may be unexpected by others.


enable bfloat16 for cpu

if there's no cuda. disable custom kernels
What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@jianan-gu

@Narsil could you please help review the PR? I run the TGI in cpu only platform, and fix some issues


feedback for scpub3 standalone HTML

This is the file I am commenting on:
scpub3.zip
and this is the relevant config file:
https://github.com/suttacentral/sc-data/blob/master/sc_bilara_data/_publication/en/sujato/editions/mn/mn-en-sujato_scpub3-ed6-html_2022-02-10.json
What I'll try to do is look at all the issues I come across and specify them with reference to the original spec where relevant.
foreword
ok! Except we have

<article

It should be

<article

Validate the HTML! I ran
tidy --doctype html5 --output-html 1 --tidy-mark 0 --quiet 1 --output-encoding utf8 -w 0 --show-warnings 0 -m scpub3.html

This created the following file, which I will use from now on.
scpub3-tidy.zip
introduction
ok!
missing things
Front matter is incomplete, see spec here:
"frontmatter": [
        "titlepage",
        "copyright",
         "./matter/epigraph.html",
        "toc",
        "./matter/foreword.html",
        "./matter/preface.html",
        "./matter/introduction.html",
        "./matter/acknowledgements.html",
        "blurbs"
      ]

If any of these are underspecified in the project issues, let me know. I will review the issues to make sure they are all complete.
html bugs
At mn12:50.7 there is an unclosed blockquote. In fact the verse is missing an entire segment, mn12:50.10
see source file here:
https://github.com/suttacentral/sc-data/blob/master/sc_bilara_data/html/pli/ms/sutta/mn/mn12_html.json
There's also content missing a little above that, at mn12:50.2
Actually when I look, there is missing content all over the place. Clearly there's some major bug in getting the text into the file.
Here's the first sutta, with the HTML standalone next to the same sutta as it appears on our site. After the first couple of paragraphs, all the remaining visible text is missing.

The text is also disordered. Here you can see highlighted the last line of the Sutta.

But then it jumps back to earlier, and the
 is closed improperly.
Okay, so there's a bunch of bugs here, I won't keep reporting them all!
reference markup
All the references should be  tags including the segment numbers (in case we want to link to or from them.)
In addition, we should supply all of them with a ref class so that we can style them together if we need to.
Currently we have:
BJ 10.2PTS-VP-PLI 1.1

It should be:
BJ 10.2PTS-VP-PLI 1.1

TBH I get queasy when I see HTML with double-quotes. We store all our HTML inside JSON so we use single quotes by default. Obviously it isn't a critical issue here, but I would be happier if all quotes were 'single'.
space bugs
Another problem here, is that the sentences don't always have a space at the end.
in the forest by day.But in the last month of summer

As far as I know, the bilara text you are consuming should be normalized, so that every segment ends in a space, except when the last character is em-dash.
On the website the same sentence is fine:
https://suttacentral.net/mn12/en/sujato
in the forest by day. But in the last month of summer

no html entities
&

Don’t let any of our transformers change anything in the content. Everything remains the same Unicode entity all the way through. When encoding and re-encoding back and forth there are always bugs, and there is no need for it. Just force everything to use Unicode all the time.
Same thing applies, even more so, in LaTeX. There are a couple of control characters that need to be escaped, but basically everything should be unicode all the time.
file name
Make sure the outputted file has the correctly defined name. scpub3.html is ambiguous. Use the same name as the JSON config file:
mn-en-sujato_scpub3-ed6-html_2022-02-10.html

We must always keep an unambiguous, one-to-one relation between the config and the produced file. As the config says, so the file is produced.

Also, we need to supply structural markup for the whole thing:

…

…

…

See the demo page for this.
https://github.com/suttacentral/suttacentral/issues/2365

The links are not formed properly, once again this is defined in the demo:
We also have reference links. Let's make them work!
href="/dn ---> href="#dn
href="/ ---> href="https://suttacentral.net/

Now all the internal links will work in the file, the external links will point to SC.

CSS needs to be added:
https://github.com/suttacentral/suttacentral/issues/2412

I have tested the text content in scpub3 according to the latest version sent. Here's the source file I used:
scpub3.zip
To compare, I extracted the contents of mn using bilara i/o:
./sheet_export.py mn mn.tsv

I copied out the translation column, removed the column header, and removed * markdown.
Next I opened scpub3.html in a browser, copied it and pasted as plain text. Now I have two plain text files.
Then I removed all new lines and spaces.
tr -d '\n' < mn-st.txt > mn-st2.txt
tr -d ' ' < mn-st2.txt > mn-st3.txt

Then I divided it into lines of exactly 100 characters:
sed -i mn-io3.txt -e "s/.\{100\}/&\n/g"

And opened both files in Meld. They're identical!
So i can confirm that in the case of scpub3 there is no text loss.


Error in console and DIAL freezes if to set cursor in prompt description

Create new prompt
Set cursor in description field -> Edit prompt window is closed and error in console appears

Fixed along with #696


port chromeos touchpad driver on crouton

I'm trying to use hugegreenbug's method(https://github.com/hugegreenbug/xf86-input-cmt) to install chromeos touchpad driver
how do I figure out which "50-touchpad-cmt-xxx.conf" to put in /usr/share/X11//xorg.conf.d?
These are the confs in the "xf86-input-cmt" folder, I don't know which one to choose
20-mouse.conf
50-touchpad-cmt-kaen.conf
50-touchpad-cmt-pit.conf
20-touchscreen.conf
50-touchpad-cmt-leon.conf
50-touchpad-cmt-puppy.conf
50-touchpad-cmt-aebl.conf
50-touchpad-cmt-link.conf
50-touchpad-cmt-spring.conf
50-touchpad-cmt-alex.conf
50-touchpad-cmt-lumpy.conf
50-touchpad-cmt-stout.conf
50-touchpad-cmt-butterfly.conf
50-touchpad-cmt-mario.conf
50-touchpad-cmt-wolf.conf
50-touchpad-cmt-daisy.conf
50-touchpad-cmt-parrot.conf
50-touchpad-cmt-zgb.conf
50-touchpad-cmt-elan.conf
50-touchpad-cmt-peppy.conf
50-touchpad-cmt-falco.conf
50-touchpad-cmt-pi.conf
I'm running ubuntu 14.04+xfce on a dell 13 chromebook(i3)
xinput list: (I believe ID8 is my touchpad)
� Virtual core pointer                    	id=2	[master pointer  (3)]
�   ��� Virtual core XTEST pointer              	id=4	[slave  pointer  (2)]
�   ��� SYNA0000:00 06CB:7AB3                   	id=8	[slave  pointer  (2)]
� Virtual core keyboard                   	id=3	[master keyboard (2)]
��� Virtual core XTEST keyboard             	id=5	[slave  keyboard (3)]
��� Power Button                            	id=6	[slave  keyboard (3)]
��� Power Button                            	id=7	[slave  keyboard (3)]
��� AT Translated Set 2 keyboard            	id=9	[slave  keyboard (3)]

@xz15,
We can find a "codename" of own chromebooks from chroot, something like:
 croutonversion | grep 'host:' | awk '{print $7}'
And known codenames are listed here:
https://www.chromium.org/chromium-os/developer-information-for-chrome-os-devices
Then you could pull your suitable conf from that directory. However, if the proper configuration file for your exact model did not exist there, you might need to try some similar configurations though...
Regards.

Thanks! looks like I have to configure the driver myself, do you know where I could find a list of explanation for the cmt driver properties?

@xz15,
If your machine was "lulu", the file is here?:
https://chromium.googlesource.com/chromiumos/platform/xorg-conf/+/master/50-touchpad-cmt-lulu.conf
Regards.

Yes, I found it, thanks. What I did was using his ppa to install xf86-input-cmt, and somehow lulu was not included in xf86-input-cmt.
There's one problem though, the "smooth scrolling" or "coasting" is disabled, so the scrolling stops as soon as my fingers leave the touchpad, do you know which properties/option is related to this?

@xz15,
Unfortunately no... Since all of my chromebooks doesn't need such driver.

There's one problem though, the "smooth scrolling" or "coasting" is disabled, so the scrolling stops as soon as my fingers leave the touchpad, do you know which properties/option is related to this?

I think you should better to contact to developer of the codes, at least I can't help you (maybe your issue can be related to its code)...
Regards.


allow set custom css class for tooltip & file input fix for dynamic loaded html

Fix for dynamic file inputs for eg. when loading html in angular view. To initialize file input:

Materialize.fileInput('#customFileInputControl');

Fix for customizing tooltip. Now you can change tooltip style by providing javascript 'customCSS' parameter or html attribute 'customcss'

$(document).ready(function(){
                $('.tooltipped').tooltip({delay: 50, customCSS: "rounded"});
              });

or
Hover me!

+1 for dynamic css classes on tooltips

Please make your pull requests targeted to fixing a single problem or feature. Touching multiple components that are unrelated makes merging hard.


Pinned Files Icon Does Not Show

Description
When pinned to the Windows task bar, the space is blank. The icon is there, but there is no icon shown.
Steps To Reproduce

Install the Files app.
Pen the Files app.
Right click to pin it to the taskbar.
Close the Files app and look at the taskbar icon disappear location.
Click on the blank taskbar location to open the files app.

Requirements
Fix icon that does not show on the windows taskbar.
Files Version
<IP_ADDRESS>
Windows Version
Windows 10 Home Single Language 22H2 (19045.4894)
Log File
debug.log

Thanks for the report, Files doesn't control the icon on the taskbar, please try restart your PC

Does restarting Windows help?


Use .env file to define postgres url

The goal is to use an .env file to define the postgresurl in the docker-compose.py. This requires a change in the billtitles Dockerfile, to accept the variables that are passed.
My initial attempt to do this, in the envfile branch (d59180c8b0d) has this error when I run docker-compose up:
 connection to server at "localhost", port 5432 failed: Connection refused
        Is the server running on that host and accepting TCP/IP connections?

Working with PR #20


Setting resolution for push and pull streaming using WebRTC is not working ,Android

html code
<script type="text/javascript">
        $(function() {
            let sdk = null;

            const startPublish = async function() {
                const videoElement = $('#rtc_media_player')[0];

                try {
                    const stream = await navigator.mediaDevices.getUserMedia({
                        video: {
                            width: { ideal: 3840 }, // 4K
                            height: { ideal:  2160}, // 4K
                            frameRate: { ideal: 60, max: 120 } //
                        },
                        audio: true //
                    });

                    if (sdk) {
                        sdk.close();
                    }

                    sdk = new SrsRtcPublisherAsync();
                    videoElement.srcObject = stream;
                    sdk.stream = stream;

                    const url = "webrtc://xxxxxx";
                    await sdk.publish(url);
                    console.log("success！");
                    alert("success");
                } catch (error) {
                    console.error("failed :", error);
                    alert("failed : " + error.message);
                    if (sdk) sdk.close();
                }
            };

            $("#btn_publish").click(startPublish);
        });
    </script>

srs.sdk.js code
self.constraints = {
        audio: true,
        video: {
            width: {ideal: 3840},
            height: { ideal: 2160 },
            frameRate: { ideal: 60, max: 120 }
            // facingMode: 'environment'
        }
    };

But the actual recording is 720 * 1280  should i  need to configure any additional information

try to set sdk.constraints instead of the sdk.stream before sdk.publish.
And use MediaDevices.getSupportedConstraints to get a list of available constraints.

try to set sdk.constraints instead of the sdk.stream before sdk.publish. And use MediaDevices.getSupportedConstraints to get a list of available constraints.

Still can't do it  ,still 720*1280
`

The phone itself supports 4K, and I can obtain the resolution of the camera, but I cannot achieve 4K playback during recording


[SPARK-18045][SQL][TESTS] Move HiveDataFrameAnalyticsSuite to package sql

What changes were proposed in this pull request?
The testsuite HiveDataFrameAnalyticsSuite has nothing to do with HIVE, we should move it to package sql.
The original test cases in that suite are splited into two existing testsuites: DataFrameAggregateSuite tests for the functions and SQLQuerySuiteSQLQueryTestSuite tests for the SQL statements.
How was this patch tested?
Modified SQLQuerySuite in package sql.
Add query file for SQLQueryTestSuite.

Test build #67332 has started for PR 15582 at commit 1c5277d.

Test build #67332 has finished for PR 15582 at commit 1c5277d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67332/
Test PASSed.

Test build #67403 has started for PR 15582 at commit 5acbd6c.

Test build #67404 has started for PR 15582 at commit 3066efc.

@rxin I've moved the testcases added in this PR to an query file test, do we need to move other test cases for ROLLUP/CUBE/GROUPING-SETS too? Currently in SQLQuerySuite we have the following:
test("rollup")
test("grouping sets when aggregate functions containing groupBy columns")
test("cube")
test("grouping sets")
test("grouping and grouping_id")
test("grouping and grouping_id in having")
test("grouping and grouping_id in sort")

It'd be great to move those as well!

Test build #67404 has finished for PR 15582 at commit 3066efc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67404/
Test PASSed.

Test build #67403 has finished for PR 15582 at commit 5acbd6c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67403/
Test PASSed.

I'm going to merge this first. Please submit a follow-up pr to move other ones.

(Actually I'm on an airplane and the internet is not good enough to merge patches).

cc @cloud-fan can you merge this?

Merging to master. Thanks! Ping me for the follow-up.


Address deprecations from persistence lib

A backwards-compatibility layer has been added to persistence to help
consumers move to the new namespacing. It is based on class aliases,
which means the type declaration changes should not be a BC-break: types
are the same.
See doctrine/persistence#71
This means:

using the new namespaces
adding autoload calls for new types to types that may be extended and
use persistence types in type declarations of non-constructor methods,
so that signature compatibility is recognized by old versions of php.
Luckily, none of those were found in this package.
More details on this at
https://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf

I don't understand the Composer failure for the prefer-lowest build :thinking:

I understand now, I added it to require when there was already a requirement in the require-dev section. This looks wrong to me, by the way, since there are references to the persistence lib in src. Should I move it to the require section. Or is it there because it is considered a dependency only when using an optional feature? Since there is already a requirement for doctrine/orm this looks unlikely.

No indeed, not sure why this one is in require-dev

Ok, let me move it.

@theofidry PTAL

Thank you @greg0ire


completed Task -5 (List files)

Issue: #6
Successfully executed commands
https://drive.google.com/file/d/1IXccBRgO5sk8YWLp-hxGIUuS-lLKFFF-/view?usp=sharing

Hey @Aditya-Pachauri
Thanks for opening this PR 🚀. Mentor will review your pull request soon and till then, keep contributing and stay calm.
Thanks for contributing in OpenCode'24 ✨✨!

Hey @Aditya-Pachauri
Your PR has been merged 🥳🥳 and you have earned 10 points.
Thanks for contributing in OpenCode'24 ✨✨


Fix download links

Switches to S3 so downloads trigger. Fixes #189.

This PR also updates how the deps target HEAD on the branch (should use master now).

Coverage remained the same at 91.295% when pulling c6fbdace3c1a1f08c566016f08028bc8daeeee95 on fix-download-links into 3b39f7261e51a152115ee816354420a2ad9531ca on master.


The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   79.14%   79.15%
=======================================
  Files          73       73
  Lines        6253     6255    +2
=======================================
+ Hits         4949     4951    +2
  Misses       1304     1304

Impacted Files
Coverage Δ

wasmi_v1/src/engine/func_builder/visit.rs
87.50% <33.33%> (ø)

wasmi_v1/tests/e2e/v1/func.rs
100.00% <0.00%> (ø)

wasmi_v1/src/func/into_func.rs
91.11% <0.00%> (+0.20%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix both acceptance test failures

What changes were proposed in this pull request?
Combine #527 and #530 to get a clean acceptance test run.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2983
https://issues.apache.org/jira/browse/HDDS-2977
How was this patch tested?
Acceptance test runs for each of the individual issues.  Now trying to get a combined run.

With 527 merged this is no longer needed.


No need to install cuda driver?

I see faster whisper is depend on cudnn and cublas, should I need to install cuda:
https://developer.download.nvidia.com/compute/cuda/12.1.0/local_installers/cuda_12.1.0_531.14_windows.exe

I see faster whisper is depend on cudnn and cublas, should I need to install cuda: https://developer.download.nvidia.com/compute/cuda/12.1.0/local_installers/cuda_12.1.0_531.14_windows.exe

yes


Usage of 'White Cube' logo

I would like to link my Python project on my website via a button containing a modified version of the  'White Cube' logo:

Am I allowed to use it?

@padix-key Please, feel free!


Update all dependency versions

Coverage remained the same at 100.0% when pulling 3561e4aefce9b5e0de58f42953227d56a5abde5f on dependency-update into 28bb9bba9e9e302a6e967dbeb5c911fe76930310 on master.

@rultor merge

@rultor merge

@valery1707 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@valery1707 Done! FYI, the full log is here (took me 2min)


Factor in elevation to astronomy times

Use the elevation of the user to adjust the rise/set times.

This will not work because the elevation around the user (up to the horizon) is likely to be similar to that of the user - therefore sun times will not change. This only applies if the user's elevation is significantly different from their surroundings and that height difference is known. Therefore without a DEM it is likely not feasible.


Failed to install fts in 2017-latest-ubuntu

Running docker on Windows machine and used " docker pull mcr.microsoft.com/mssql/server:2017-latest-ubuntu" to get the image. then
tried to install fts on the container (https://docs.microsoft.com/en-us/sql/linux/sql-server-linux-setup-full-text-search?view=sql-server-2017)
root@7ab599da0d97:/# apt-get install -y mssql-server-fts
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package mssql-server-fts
Is this document dated? or linux docker is not working?

Hi,
You need to import the public repository GPG keys and register the Microsoft Ubuntu repository first. Try this.
apt-get install -y curl

curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add -
curl https://packages.microsoft.com/config/ubuntu/16.04/mssql-server-2017.list | tee /etc/apt/sources.list.d/mssql-server.list

apt-get update
apt-get install -y mssql-server-fts

it works. Thanks!

does anyone have updated steps for 2019? i've been at it for 4 hours and I am dying.

does anyone have updated steps for 2019? i've been at it for 4 hours and I am dying. trying to install sql server 2019 in a docker container running on a mac. need full text indexing.

curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add -
curl https://packages.microsoft.com/config/ubuntu/20.04/mssql-server-2019.list | tee /etc/apt/sources.list.d/mssql-server.list

apt-get update
apt-get install -y mssql-server-fts

cd ~/Downloads
wget http://archive.ubuntu.com/ubuntu/pool/main/g/glibc/multiarch-support_2.27-3ubuntu1_amd64.deb
sudo apt-get install ./multiarch-support_2.27-3ubuntu1_amd64.deb


[ip] add IPv4 address definitions

This commit adds IPv4 address definitions in OpenThread:

Adds public otIp4Address & the core Ip4::Address types.
Adds APIs/methods to convert IPv4 address to/from string.
Updates the Ip6::Address::FromString() to use the IPv4
FromString() for the case where the IPv6 address contains
an embedded IPv4 address.
Updates unit test to cover behavior of newly added methods.

@abtink , I'm wondering if IPv4 addresses should even be exposed via the API. Thread is fundamentally an IPv6 network. Even if the DNS Client is synthesizing IPv6 addresses from IPv4 addresses, the application should just see the synthesized IPv6 address.
Do you have a use case in mind?

@abtink , I'm wondering if IPv4 addresses should even be exposed via the API. Thread is fundamentally an IPv6 network. Even if the DNS Client is synthesizing IPv6 addresses from IPv4 addresses, the application should just see the synthesized IPv6 address.
Do you have a use case in mind?

I had some ideas about how/where to use this:

In the case where we handle the translation in DNS client itself, we can consider to report the original IPv4 address along with the synthesized IPv6 address to the user (considering this for logging/testing).
We may consider exposing the v4 to v6 synthesis logic as a public OT API to user.

This can be used for cases where the user may already know the IPv4 address (somehow) and just wants to translate it.

Was also considering adding support and exposing API in DNS client to query for A records directly.

In the case where we handle the translation in DNS client itself, we can consider to report the original IPv4 address along with the synthesized IPv6 address to the user (considering this for logging/testing).

I think logging the synthesized IPv6 address is sufficient, since it directly embeds the IPv4 address.

We may consider exposing the v4 to v6 synthesis logic as a public OT API to user.

This can be used for cases where the user may already know the IPv4 address (somehow) and just wants to translate it.

I think we should discourage IP address referral where possible.

Was also considering adding support and exposing API in DNS client to query for A records directly.

I think it would be useful to have an API that can enable/disable DNS64/NAT64. For example, a client may want to disable NAT64 to ensure that it does not unintentionally communicate with cloud/off-network services. I'm not sure I see the need for allowing the client to query A records directly yet. I think we should discourage IPv4 wherever possible.

@jwhui sounds good to me. Will remove the public otIp4Address definition and just keep the interval.


Update conversationalagentsession_createaudiodeviceinputnode_13488490…

…01.md
test

@MancunianBandit : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add two tests from freakattack.com

I found two test servers provided by freakattack.com mentioned here:
https://freakattack.com/clienttest.html
"Here are some additional tool for developers debugging their
applications. You can try our low-level state-machine tests by loading
this page and this page. (If either connection succeeds, your software
is vulnerable.)"
It's worth adding these to https bundle?

There's already an SSLLab version of FREAK protection. How are these different?


Option to exclude creation of istio-namespace

Describe the feature request
I would like the option to opt-out of the creation of the namespace for example:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
spec:
  defaultNamespace: disabled

Currently I have a setup that generates the namespace beforehand and stores it as a state.
If for some reason I want to add additional labels or prehaps remove istio it will disrupt the correct state of the namespace.
Describe alternatives you've considered
Additional context

We should just create the namespace if it doesn't exist, and otherwise do not touch it

If the namespace is created previously we will no longer tamper with it. Thanks for the suggestion!


Client source IP

I have an app that requires the original client IP, but with Rio the source IP is a local address in the 10.x.x.x range.
There is some documentation from Kubernetes on this topic: https://kubernetes.io/docs/tutorials/services/source-ip/
I'm not sure which of these applies here, but this would be nice to have as an option. For HTTP applications, setting the X-Forwarded-For header would be sufficient.

Let us think about this. It will be nice if we can configure that on top of Rio.

I took a look at k8s documentation about preserving client-ip. Since we are exposing gateway in service loadbalancer, by default it is obscuring  client-ip.
@jgillich You can try this patch to see if that works.
kubectl patch svc gateway-proxy-v2 -n rio-system -p '{"spec":{"externalTrafficPolicy":"Local"}}'
In future we can make this configurable in Rio.

externalTrafficPolicy: local requires that the target pod be on the same node as the request came in to, so if you're going to do that you probably need to be doing global scheduling so that every node has a Potts for the service.

I only run a single node, but that change doesn't make any difference for me, I'm still getting a local IP.

@jgillich Were you able to resolve this requirement. I am hitting a block myself ...

@jgillich @cosmo83 have you figured it out, running into the same problem
@StrongMonkey is making it configurable in rio still on the roadmap?

I was able to get x-forwarded-for header by setting the following after rio install:

gateway-proxy Service - set externalTrafficPolicy: Local in the spec
gateway-proxy Deployment - annotate with config.linkerd.io/skip-inbound-ports: 8080,8443

I guess both the CNI forwarding and the linkerd sidecar try to NAT the source IP before Gloo sees it. It would be really good to have Rio set both of these at the beginning, rather than modify after installation.


Map size can't be 0. Most likely layout has not yet been occurred.

Occassionally I get this error:

But this does not happen always.

@jaysson Could you provide an example? My guess is it's some sort of race condition.
Is it possible it possible that your trying to set the original region of the app with fetched data.
A simple fix would be to make sure you have those coordinates before rendering the map.

Yes, I am fetching the user location and animating the map to that region.
<MapView
                    style={ styles.map }
                    initialRegion={{
                        latitude: 12.97162345,
                        longitude: 77.59462345,
                        latitudeDelta: 0.0461,
                        longitudeDelta: 0.02105
                    }}
                    ref={(gMap) => this.googleMap = gMap}
                ><MapView.Marker draggable coordinate={this.state.coordinates} onDragEnd={this.markerDragged}/>

In constructor:
navigator.geolocation.getCurrentPosition(
            (position) => {
                Geocoder.geocodePosition({lat: position.coords.latitude, lng: position.coords.longitude}).then((results)=> {
                    let result = results[0];
                    Address.saveFromMap(result);
                    this.setState({
                        addressText: result.formattedAddress,
                        address: result
                    })
                });
                this.setState({
                    coordinates: {
                        latitude: position.coords.latitude, longitude: position.coords.longitude
                    }
                });
                this.googleMap.animateToRegion({
                    latitude: position.coords.latitude,
                    longitude: position.coords.longitude,
                    latitudeDelta: 0.02305,
                    longitudeDelta: 0.01075
                })
            },
            (error) => alert(error),
            {timeout: 60000, maximumAge: 10000}
        );

+1

@jaysson have you solved this. I have same issue..!

For now I m setting the width & height.
< MapView style={{width: Dimensions.get('window').width, height: Dimensions.get('window').height}}>

This only requires if I've MapView in the route navigation directly. If I render it on any event, it is not required. So, I think we need either the render the map delayed or keep the dimensions as above. flex:1 is not working, though.

I have this issue in #842

Just submitted a PR at Java Code level to fix this type of crashes from happening.
https://github.com/airbnb/react-native-maps/pull/1521
In my use case, it's not practical to set width and height in the very beginning. So I have to make the fix in Java Code level.
Any feedbacks are welcome. Hope this would make this ancient issue be closed soon. :)

I still have that error
bugsnag_error_stacktrace_com.google.maps.api.android.lib6.common.apiexception.c_event_5e3ace9f0055f097f4f80000.txt
Any way to fix it from RN side?

@mattshen Try using "onMapReady" method from here. @vvscode this could help you too.
https://github.com/react-native-community/react-native-maps/blob/master/docs/mapview.md
I'm using it and it's working for me.

Try with position : 'absolute' in your style. It solved my problem

I have the same issue today, this fix was:
style={{ width: '100%', height: '100%' }}

So, this is still a problem. I'm getting an exception here
https://github.com/react-native-maps/react-native-maps/blob/ae09e685228f3bf5ac0a48c220ab64806f470d15/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java#L752-L753
In my case the problem arises if I disable animations in react-navigation, so I ended up adding a little timer before navigating. Anyone came up with a non shitty solution? At least a way of wrapping the main component. I tried using getDerivedStateFromError but it seems is a native crash.
The best solution to me would be to just skip calling moveCamera if width or height are zero. But I don't know enough about this code base or the libraries to be sure if that's a good idea.

Setting map width and height to screen width and height AND doing map initialization (fetching data for markers, etc.) in onLayout() worked for me.
            <MapView style={styles.map}                 onLayout={onMapReady}             ...>
const onMapReady = async () => {
        if (mapInitialized) {
            return;
        }

        // initialize map data here

        setMapInitialized(true);
    };

const styles = StyleSheet.create({
    map: {
        position: "absolute",
        width: Dimensions.get("window").width,
        height: Dimensions.get("window").height,
        flex: 1,
    },
});


cannot connect to eventhub

Hi!
I'd like to connect to one of my eventhubs like this:
const EventHubClient = require('azure-event-hubs').Client

// copied from azure portal
const connectionString = 'Endpoint=sb://XXX.servicebus.windows.net/;SharedAccessKeyName=XXX;SharedAccessKey=XXX=;EntityPath=test'

const client = EventHubClient.fromConnectionString(connectionString)

client.open()
  .then(() => {
    console.log('connected')
  })
  .catch(err => {
    console.error('failed', err)
  })

However, nothing happens (nothing gets printed on console) and process waits forever.
Am I missing something?

This looks correct. Maybe try and remove the EntityPath section of the connection string and add its value (test) as a second argument of the `EventHubClient.fromConnectionString() call? that's another way of instantiating the client. Not convinced it could make a difference, unless we have a bug...
The other thing I could think of would be: either a mismatch between your hub configuration and your connection string (did you build it yourself or did you copy/paste it from the portal?) or maybe a firewall issue (requires port 5671 to be open since it's using the AMQP protocol over TLS)

Got it 😱My messy company network blocked the port.
Everything is working fine! Sorry for wasting your time!

Thanks for reporting. no problem!!

[0x1dee368]:ERROR[-2] AMQP header mismatch: 'AMQP\x02\x01\x00\x00
i am getting this error while run the sender


Call to undefined function mock()

Describe your bug
Simply using mock() function (like this) throws an error Call to undefined function mock(). Using the class works though as in $mock = \Mockery::mock( Bootstrap::class );.
Steps to Reproduce
Just use mock() function
Expected behavior
Should not throw error.
Screenshots, screen recording, code snippet

Environment info
Windows 11 Pro on WSL2
PHP 7.4.x and/or 8.0.x
Composer version 2.0.14 2021-05-21 17:03:37
PHPStorm 2022.2.1 - although doesn't matter because even in just the WSL terminal, it's the same
Please confirm that you have searched existing issues in this repo.
Yes

Hmmm, could be because the underlying test case (if integration tests are in question) doesn't have this method exposed. I'll need to check, and add it as a helper if not used 👍🏼

Oh, I just noticed that you need to install the pest-plugin-mock, and I haven't tested this package with the mock package.
I think that you can add this:
<?php

use Mockery;
use Mockery\MockInterface;

function mock(string $classname): MockInterface
{
	return Mockery::mock($classname);
}

inside the Helpers.php file, and you should be able to use the mock() to use mockery.

Found it... seems just calling Mockery::globalHelpers(); works. Added it to _manually_load_plugin() function like so:
function _manually_load_plugin() {

    Mockery::globalHelpers();// <- added
    require dirname( __FILE__, 2 ) . '/main-plugin.php';
}


Support ESLint junit reports

Hey, this is a great action I started using with our ESLint workflow!
I notice that it creates annotations, but they don't show up in the PR, looks like the file, line & col values don't get parsed correctly.
Here's an example junit report ESLint generates:
<?xml version="1.0" encoding="utf-8"?>
<testsuites>
<testsuite package="org.eslint" time="0" tests="1" errors="1" name="/home/runner/work/ecom-storefront/ecom-storefront/cypress/plugins/s3-email-client/s3-utils.ts">
<testcase time="0" name="org.eslint.@typescript-eslint/dot-notation" classname="/home/runner/work/ecom-storefront/ecom-storefront/cypress/plugins/s3-email-client/s3-utils"><failure message="["Bucket"] is better written in dot notation."><![CDATA[line 7[6](https://github.com/granodigital/ecom-storefront/actions/runs/7671315746/job/20909395839#step:15:7), col 28, Error - ["Bucket"] is better written in dot notation. (@typescript-eslint/dot-notation)]]></failure></testcase>
</testsuite>
</testsuites>

And here's the annotation I get now:

Note the missing file extension and line/col information.

Unfortunately there is no real consistent approach how those are provided in exports.
We have some different approaches in the action which tries to identify file and line number, however these are unfortunately not perfect.

@mikepenz Yeah, it's unfortunate. Perhaps there could be an option similar to VS Code's problem matchers? https://code.visualstudio.com/docs/editor/tasks#_defining-a-problem-matcher
That way you could add support manually and perhaps add presets/docs for common ones?

Meanwhile if someone else needs this, here's a small script I asked ChatGPT to write to process the ESLint junit reports so that they work better with this action:
#!/usr/bin/env node
import { readFile, writeFile } from 'node:fs/promises';
import { Parser, Builder } from 'xml2js';

const filePath = process.argv[2];

const data = await readFile(filePath, 'utf8');
const parser = new Parser();
const builder = new Builder();

const xmlData = await parser.parseStringPromise(data);

for (const testsuite of xmlData.testsuites.testsuite) {
	testsuite.$.file = testsuite.$.name;
	testsuite.$.name = undefined;
	for (const testcase of testsuite.testcase) {
		if (testcase.failure) {
			testcase.$.name = testcase.$.name.replaceAll('org.eslint.', '');
			testcase.$.classname = undefined;
			const failureData = testcase.failure[0];
			const lineMatch = failureData._.match(/line (\d+)/);
			if (lineMatch) failureData.$.line = lineMatch[1];
		}
	}
}
const output = builder.buildObject(xmlData);
console.log(output);
await writeFile(filePath, output, 'utf8');

Example:
		...
      - name: Retrieve Changed Files
        id: files
        uses<EMAIL_ADDRESS>      - name: Lint
        run: npm run lint -- ${{ steps.files.outputs.added_modified }}
      - name: Process ESLint Report
        run: ./scripts/process-eslint-junit.mjs junit/eslint.xml
        if: always()
      - name: Publish Report
        uses: mikepenz/action-junit-report@v4
        if: always()
        with:
          report_paths: junit/*.xml
          check_title_template: '{{TEST_NAME}}'
          annotate_only: true
          annotations_limit: 50
          detailed_summary: true

P.S. Would be nice to support warning level annotations also. :)

@mikepenz Any opinions on this? I was thinking about it a bit more and I thought maybe instead of simple regex there could be an option to pass XPath queries for the different things you want to parse and we could document some as examples e.g. replace(//failure/text(), '.*line (\d+).*', '$1') gets the line number from the ESLint report.

Great work 👏


Wrong position in iphone but proper in android.

1.This is happening only in ios. Tried with iphone 6, 7plus and X..Same issue on all devices.
2.When I rotate, text is not shown and I think it's moving towards left and cutting at edges(Tested in 6 and 7 plus real devices).

This is related to #25


Multiple selection of project remains disabled.

Have View, Edit, Delete and Advance roles still multiple selection remains disabled.

It also requires any one of these role to delete multiple projects.[when user is not a project manager]


Support for GetHeaderLine from web-ifc

Hello.
The current version of the web-ifc-three is using the latest version of the web-ifc(0.0.39), but when this version was updated on the web-ifc-three, the new method GetHeaderLine from web-ifc was not propagated in the wb-ifc-three Handlers and BaseDefenitions.
This function needs to be inserted in:

web-ifc-three/src/IFC/BaseDefinitions.ts - class WebIfcAPI
web-ifc-three/src/IFC/web-workers/BaseDefinitions.ts - enum WorkerAction
web-ifc-three/src/IFC/web-workers/handlers/WebIfcHandler.ts - class WebIfcHandler

I am currently trying to use the GetHeaderLine with<EMAIL_ADDRESS>like this:
viewer.IFC.loader.ifcManager.ifcAPI.GetHeaderLine(ifcModel.modelID, FILE_NAME)
As the ifcAPI type (WebIfcAPI and WebIfcHandler) does not contain the GetHeaderLine, I am not able to use it. Even if I ignore the typing I am also not able to use it, because enum WorkerAction does not contain the GetHeaderLine.
Do you know when this fix will be introduced?
Thank you.

Fixed on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>🙌


Add Azure Blob Storage as a media option

This is a Draft PR while I test out the configuration and button up settings.
I'm not sure if this is something you'd want to include, but I'm using Azure to host all my infrastructure and I've previously used django-storages[azure] to host media in Azure Blob Storage, I believe this will work without much extra effort (haha famous last words). More updates and "ready for review" will come after some testing.

Yup, I'd like to have this support! Just leave a comment when you're ready for review.

I was looking into this as well, so allow me to chime in regarding two possible modes of operation:

You store the meda inside a storage account container and proxy the requests through the Takahe front-end
You can store the media inside the $web container and just redirect (or rewrite URLs) to have the browser fetch them directly from storage (and you can have that mapped to your own domain). This avoids the need for public blob access policies, since $web is public by default, and if you are using a domain-centric CDN, you can have that cover both your container and your public site.

I had a look at the azure storage provider and it seems to only support both modes of operation, but I have never actually used it - I just thought it would be a good idea to point out the differences and explain that it would be more "natural" to use the $web container and allow for a custom domain to be mapped (like media.instance.domain instead of the default Azure ones).

@rcarmo thanks! I got this working in https://github.com/bookwyrm-social/bookwyrm and am trying to apply that here but I've gotten stymied a few times because I've just switched to an m1 mac and the loss of arm64 docker builds locally is slowing my work down (though I should really just set up a true local dev env). I think it's fine to set the base URL for the assets to be the azure blob URL, at least as a first run, the django storage provider for azure also supports custom URL settings, so those will hopefully be easy to set as well (though my blob storage container is just bare azure blob url so I'll have to set that up to test it!)

I gave up on Docker Desktop a long while ago... I just use Parallels with an Ubuntu ARM VM and either set DOCKER_HOST on the local CLI (which you can get as a standalone binary) or VSCode remote to it -- it is way faster, although you do need to get used to your working source tree being "remote" (which has never been a real issue for me).
Anyway, I will be migrating my instance to Azure soon (famous last words), will eventually have time to test this.

Awesome, I'm using Colima locally and it's fine for arm but it's an M1 Air so not much power. I got my local non-docker dev setup yesterday before I went out to play some board games. Can now repro my auth issue locally and just need to tweak it to figure out why it's not using the creds correctly!

I no longer run takahe.