Proposal: private flag in config.yaml

This may be a tad specific to our needs, but I thought I'd propose it anyway to gauge interest. Like Google Fonts, we (The Type Founders) manage our font families in Git repositories. However, we use a monorepo per foundry, so all of a foundry's families are stored in a single repository.
We often run into situations where we would like to mark a family as private for various reasons: because it is a work-in-progress, a custom modification, or simply because we're not ready to publish it yet. We could store this information separately in a configuration file in each family directory, but it feels appropriate and generally useful to have it in the config.yaml file (much like package managers like Crate and NPM have a private flag in their package configurations).
This could be accomplished in two ways:

Add a private flag in the configuration schema.
Some sort of extension scheme in the configuration which gftools ignores.

Curious to hear thoughts.

Sounds good. I suggest we add a local_metadata field (we can bikeshed the name) which is ignored by the tooling, but you can fill it with a map of whatever metadata you like.

Awesome, that would work for us. I'll leave the bike shedding to others, but I'd be happy to open a PR to implement it.

Chiming in to say that I’m now wishing this existing! Admittedly, it’s for another use case at The Type Founders, but it would still be handy.
If bike shedding is welcome... local_metadata is fine, but another possible option might be to use lib, as is the convention in UFOs and Designspace documents. Maybe that’s too generic, though...


[React Native SDK] init package

Adds a ThirdwebProvider implementing he latest version of wagmi.
Tested by importing it into a react native app and using the provider to connect to a wallet.
TODO:

Make the package work with preconstruct and module:metro-react-native-babel-preset to follow the evm/ solana/ pattern

/release-pr


How to set an event

You displayed some random events, but I want my own events to be displayed.
How can I set my own events.

@Pyraminds
As you can see in the demo source code, the random events are assigned to $scope.calendar.eventSource which is bound to event-source attribute when declaring the calendar directive.
$scope.calendar.eventSource = createRandomEvents();

You just need to fill the eventSource with your own events.
Btw, the calendar supports two query modes, local and remote.
The demo source code is using local mode, so you just assign the eventSource variable once.
In a real application, you probably will fetch events from the server side.
Then you need to use the remote mode, and you need to set the eventSource in the rangeChanged callback.
You can get more information from the README. Thanks.

Thanks for your reply.But I am new  to ionic and angular , if you provide one own event with an example,it would be grateful to me.

@twinssbc
Thanks i have followed you instruction for integrating this into my existing app, i didn't get any output ,only blank screen is opened there is nothing other than that.please help me with the above and this issue.
thanks a lot for your help.

@Pyraminds
This createRandomEvents just populate the events with some random string.
You just need to set the event using your own data.
You can get the event field according to README.
Regarding your blank screen issue, could you provide your code so that I can know how do you use this calendar?
Also is there any error printed in the console?

@twinssbc
Thanks For your Response
events [] i changed to like this
`var events = [{
title:'meeting',
startTime:'new Date(Date.UTC(2016, 9, 29))',
endTime:'new Date(Date.UTC(2016,9, 29))',
allDay: true
},
{
title:'birthday',
startTime:'new Date(Date.UTC(2016, 10, 1))',
endTime:'new Date(Date.UTC(2016,10, 2))',
allDay: true
       }
     ];`

this is my calendar.html file
<ion-view view-title="calendar">   <ion-content>     <calendar ng-model="calendar.currentDate" calendar-mode="calendar.mode" event-source="calendar.eventSource"                       range-changed="reloadSource(startTime, endTime)"                       event-selected="onEventSelected(event)" title-changed="onViewTitleChanged(title)"                       time-selected="onTimeSelected(selectedTime, events)" step="30"></calendar>   </ion-content> </ion-view>
and this is my index.html
I have given the correct path to the css and js files
`

<!-- cordova script (this will be a 404 during development) -->
<script src="js/ng-cordova.min.js"></script>
<script type="text/javascript" src="cordova.js"></script>
<!-- your app's js -->

<script src="lib/ionic-calendar/dist/js/calendar-tpls.js"></script>`

this is the optput

@twinssbc
i added my own events to your app i am getting it.but when coming to integrating into my app
blank space coming instead of calendar.

@Pyraminds
When you open the browser dev toolbar, is there any error displayed in the console?
If you put some divs before and after the , are these divs displayed correctly?
Could you use browser dev toolbar to hover on the elements to see if their height are set properly?

@twinssbc
There is no error in console , and the other content placed in the calendar.html file is displayed fine.
below  is the screenshot for the output

@Pyraminds Could you check what's the height of the calendar DOM element in calendar.html?

I don't know how to check the height of the calendar.

@Pyraminds
In your browser dev tools, you can hover on a DOM element and it will display the property of that DOM element.

height of the calendar is 100%

@Pyraminds If you switch to the Computed tab, could you find the height property of the DOM element?
Could you provide the full html code of that view? Apparently you have card layout elements also in this view.


Implement #2

@seaneagan thank you so much for this opportunity.  Even if my PR is not accepted, I appreciate what I've learned from your code and this experience.

@seaneagan In a later PR, I would like to then have a property in Pubspec for syntax highlighted contents.  Thank you, again.

That's all I have for now.  It's getting close!

@seaneagan Thank you for your patience and help!  Will keep pushing to make it right!

@seaneagan , finished edits.  Should we add logging to the project and log errors?  Also, since we made Pubspec.init async, should we also make Pubpsec.load async as well?  I also want to try building tests for each command.  Any of these you like, I can create separate issues for tracking.  Thank you again for walking me through this.  I learned so much and open to more edits/suggestions as well.

@damondouglas Hey no problem at all, thanks for working on this!  Done reviewing this round.  Tracking issues for logging, command tests, and async Pubspec.load sound good.

@seaneagan , Here is this round of edits.  I tried to have an elegant parser map but kept having a Segmentation fault (core dumped) error when calling a key: Function map.  As always, I'm open to more suggestions if you are willing.  Thank you, again.

@damondouglas this looks like a good start, merging.  Thanks for working on this!  There are still a few things that don't work from my testing, so I'm going to fix those shortly.  Then I'm going to fix #5 and attempt to integrate den into stagehand before releasing the spec command so I can announce that all together.

@seaneagan , thank you for kindly letting me try this and for your help.  I'm going to start working on #15.


all created files have their attributes within MFT entries

Hi, you know I was a checking the scripts and I pay attention to a little detail. I'm not sure if it is correct ... most of scenarios in the scripts create files residents in the $MFT file ! no file has content more than 700 bytes , so to not fit the $DATA attribute within the MFT entry. don't you think a little example of a such scenario need to be added ?

What scenario do think needs to be added?

non-resident $DATA ? What about https://github.com/dfirlabs/ntfs-specimens/blob/main/generate-specimens-linux.sh#L47
$ATTRIBUTE_LIST ? What about https://github.com/dfirlabs/ntfs-specimens/blob/main/generate-specimens-behavior-linux.sh#L136

Can you be a bit more specific about what scenario you are missing ?

Indeed, the copy of LICENSE (L47) handles the case of non resident $DATA. my bad !
but the second provided case (L136) ... I don't know how $ATTRIBUTE_LIST are involved ? because the file created there (testfile1) is a little bit small. did you mean the series of hard-links ? I found this description online :

When there are lots of attributes and space in the MFT record is short, all those attributes that can be made non-resident are moved out of the MFT. If there is still not enough room, then an $ATTRIBUTE_LIST attribute is needed. The remaining attributes are placed in a new MFT record and the $ATTRIBUTE_LIST describes where to find them. It is very unusual to see this attribute.

Were you successful of making an $ATTRIBUTE_LIST by multiple hard-links pointing to the same file ?
to be more specific, I was thinking at first about a case similar to a one where the content of the file does not fit within the MFT entry, but it is kind of scattered in multiple cluster runs. but I'm not gonna lie to you, I missed the LICENSE copying.
I'm still learning...  thank you in advance

but the second provided case (L136) ... I don't know how $ATTRIBUTE_LIST are involved ?

The $ATTRIBUTE_LIST is used when there is no space in the MFT entry for all the attributes. So "to not fit the $DATA attribute within the MFT entry" can also be done with forcing an $ATTRIBUTE_LIST to be used. Not only by growing the size of $DATA attribute.

Were you successful of making an $ATTRIBUTE_LIST by multiple hard-links pointing to the same file ?

Yes
Seeing the original question seems to have been addressed, I'ms closing the issue.

the content of the file does not fit within the MFT entry, but it is kind of scattered in multiple cluster runs

Maybe by creating and deleting various small files first and then a large file?


Add some tests of EOF handling

This should hopefully succeed when #106 is merged.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8d167fe) 66.46% compared to head (42d570f) 66.46%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   66.46%   66.46%
=======================================
  Files           6        6
  Lines        1184     1184
=======================================
  Hits          787      787
  Misses        278      278
  Partials      119      119

Flag
Coverage Δ

unittests
66.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@pontus shall we merge this as well?

I just pushed a fix to align with other tests (check everything for both seekable and non-seekable).
Can be merged directly if it passes review again.


Reconciler error

I am facing error while deploying sample-cr.yaml

2023-10-13T14:56:53Z	INFO	setup	starting manager
2023-10-13T14:56:53Z	INFO	controller-runtime.metrics	Starting metrics server
2023-10-13T14:56:53Z	INFO	starting server	{"kind": "health probe", "addr": "[::]:8081"}
2023-10-13T14:56:53Z	INFO	controller-runtime.metrics	Serving metrics server	{"bindAddress": "<IP_ADDRESS>:8080", "secure": false}
I1013 14:56:53.595292       1 leaderelection.go:250] attempting to acquire leader lease nginx-operator-system/a7e021da.example.com...
I1013 14:56:53.629060       1 leaderelection.go:260] successfully acquired lease nginx-operator-system/a7e021da.example.com
2023-10-13T14:56:53Z	DEBUG	events	nginx-operator-controller-manager-7dd7b9f8b4-j8ccj_95e9ff77-e889-4905-9c46-8b7668bc2efa became leader	{"type": "Normal", "object": {"kind":"Lease","namespace":"nginx-operator-system","name":"a7e021da.example.com","uid":"8e8e3396-e7a8-41ce-9d8d-b59e8f080f2d","apiVersion":"coordination.k8s.io/v1","resourceVersion":"58857"}, "reason": "LeaderElection"}
2023-10-13T14:56:53Z	INFO	Starting EventSource	{"controller": "nginxoperator", "controllerGroup": "operator.example.com", "controllerKind": "NginxOperator", "source": "kind source: *v1alpha1.NginxOperator"}
2023-10-13T14:56:53Z	INFO	Starting EventSource	{"controller": "nginxoperator", "controllerGroup": "operator.example.com", "controllerKind": "NginxOperator", "source": "kind source: *v1.Deployment"}
2023-10-13T14:56:53Z	INFO	Starting Controller	{"controller": "nginxoperator", "controllerGroup": "operator.example.com", "controllerKind": "NginxOperator"}
2023-10-13T14:56:53Z	INFO	Starting workers	{"controller": "nginxoperator", "controllerGroup": "operator.example.com", "controllerKind": "NginxOperator", "worker count": 1}
2023-10-13T14:58:08Z	ERROR	Reconciler error	{"controller": "nginxoperator", "controllerGroup": "operator.example.com", "controllerKind": "NginxOperator", "NginxOperator": {"name":"cluster","namespace":"nginx-operator-system"}, "namespace": "nginx-operator-system", "name": "cluster", "reconcileID": "578044a5-ca09-499e-b425-bb5292d27814", "error": "get operator condition name: could not determine operator condition name: environment variable OPERATOR_CONDITION_NAME not set"}

Yes, me too :)
Any solutions yet?
Even the custom metric is not showing up in Prometheus.

Hi, thanks for reporting these. I have been out of the office for a few months and am catching back up. Will take a look and update here once I have it figured out. It's possible that more recent updates to the operator framework and sdk after the book was published (along with this code) have broken some things.

@ss025 @Lucifergene if you could, in the meantime, please try running the code from this repo exactly as cloned (without running any go mod tidy or go get, etc commands). From the stack trace you provided @Lucifergene I see you are running v0.15.3 of the controller-runtime dependency while the code in this repo was written with v0.11.0. This may or may not help, but it can at least rule out dependency skew. Thanks!

Thanks @damemi
I ran the code from the repo without any package update, and the issue I pointed out -"Array index out of bounds" was not visible anymore. Thanks for your advice!
But now, I can see the error @ss025 had pointed out initially, i.e. "environment variable OPERATOR_CONDITION_NAME not set".
That's the update from my side. I am looking into other operator's codebases to see how they handle this.


Use EXPECT_FALSE instead of EXPECT_EQ(false, X)

This fixes the failures we're finding from the CI builds.

The clang failures I cannot reproduce locally, with Boost 1.55. The ASAN build suggests that there's something funny going on in either cleanup or in the semantics of some of the Boost.Thread internals. Maybe switching again to using std::thread and the standard library futures would work, I'll follow-up on that next.


Step headers event should be conditional

By default, step headers are clickable. This code enable/disable previous step header events. In a case you want previous step headers not to be clickable, just set stepHeadersClickable to false.

Sorry about this, but I am afraid I will have to close this PR, as it is going to be impossible to merge it after the massive refactoring that the library has undergone recently. This project has been abandoned for a long time, and now that I have finally had the time to go back to it, the changes I have made to update it have been deeper than I anticipated.
However, I think this is a good idea, so I will probably implement it. If you still feel like implementing it yourself, please feel free to create another PR!
In any case, thank you very much for your collaboration and apologies for the delay in my response!

Exactly , i am also in need of some mandatory steps that should get open unless the previous one's are completed.


Crashing at login

Then login screen appeared, after I enter my data the wallet just crashes. No errors or nothing. Gone. (If I enter wrong data it tells me it is wrong, the correct details crash the wallet.) Please advise. Ty.

Hello,
If you runs it on Windows, try to runs it with Administrator right for the first time.
Lukas
Odesláno z iPhonu

2018 v 17:20, Gary Palmer Jr<EMAIL_ADDRESS>

Then login screen appeared, after I enter my data the wallet just crashes. No errors or nothing. Gone. (If I enter wrong data it tells me it is wrong, the correct details crash the wallet.) Please advise. Ty.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I tried -- It still shut down. (I also had restarted the comp.)

I am experiencing the same issue on Windows 10. Crashes immediately upon login. No error message.

I am still having this issue. Please assist.

Could you please make a new wallet and login to the new wallet ?

Closed for inactivity. Please comment again to open if problem insists.


Portuguese Ledge world

Builds on top of

#177

Closes

https://github.com/osrf/lrauv/issues/146

Requires

https://github.com/ignitionrobotics/ign-common/pull/321
https://github.com/ignitionrobotics/ign-rendering/pull/585
https://github.com/ignitionrobotics/ign-gazebo/pull/1262
https://github.com/ignitionrobotics/ign-gazebo/pull/1419
https://github.com/ignitionrobotics/ign-rendering/pull/603

Model on Fuel:

https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Portuguese Ledge

Preview using Ogre1

Update
Loading 18 tiles (not on Fuel yet) using Ogre 2

Update
Using levels: ign gazebo portuguese_ledge.sdf --levels

TODO

[x] Verify / fix

[x] dimensions
[x] lat / lon position

[x] Break into smaller files

Be sure to fill no data values for all files
Each file should be a square, to avoid the min-elevation padding cliff

[x] Use levels
[x] Support on Ogre 2
[x] Use Fuel URLs
[x] Check collision positions
[x] Use better textures?
[x] Check seams

Known issues

It's hard to orbit the camera around the heightmap: https://github.com/ignitionrobotics/ign-rendering/issues/598
And we can't use the transparent plane trick, because it covers the heightmap

Am I missing something? I'm at Ignition's bleeding edge, built Garden from source today.

Ah sorry, I forgot we needed a forward port, this should be it:

https://github.com/ignitionrobotics/ign-gazebo/pull/1437

The specific PR we need is:

https://github.com/ignitionrobotics/ign-gazebo/pull/1419


This repo is undiscoverable and confusing

Questions completely unanswered in the Readme:

Is this an official client?
Is this written for Node.js?
Why is npm package name not just bigchaindb?

As mentioned here, Node.js devs won't be able to find this repository although they're the main target group for this repo.

@kremalicious:
For efficiency: What are actionables we can complete to address your concerns?
I can think of a few things:

dedicated driver and bdb download page
linking from the bdb root docs to driver docs and repo
having sphinx style docs for this driver
link from sohkai's driver to this driver
whatelse?

mention "official driver" in readme & repo description
mention Node.js in the readme prominently, also in repo description
use nodejs in the repo name (cause JavaScript & Node.js are not synonym. Or am I getting old and the kids these days expect that already?)
change npm package name to bigchaindb (at least no need to mention language, bigchaindb-driver if we absolutely need distinction from actual server)

Linking from docs was done earlier today: https://github.com/bigchaindb/bigchaindb/pull/1481
Started planning a Get Started page (Trello card) where all the important first steps are consolidated, including linking up the official drivers so this would cover your first point. Agree this is the one with most impact, will help in boosting this repo in search results.
Apart from that and more in general, consistently naming our drivers would help too, as outlined in https://github.com/bigchaindb/org/issues/35

most of the stuff in here has been addressed in #11 and externally


Ability to calculate and display coverage on current changed code (diff)

As total project coverage may not be so relevant to a specific change, it would extremely useful if coverage report could measure and report relative to last commit.
Basically now we use codecov.io but it would be great not to have to wait for CI to run to get a report. If we could set a higher bar for coverage for changes, we could naturally improve the coverage.
Measuring the coverage at project level is quite tricky because it can happen to get false-positive errors regarding reduction of coverage, just due to rounding errors.  That makes sense, but does not make sense to report it a problem such coverage reduced from 88.44% to 88.43%.
If we could measure just the code that was modified in last commit, we would be able to provide very useful feedback regarding what is not covered and report this locally.
Do you think that could be possible to achieve?

There's a separate package for this: https://pypi.org/project/diff-cover/ .   Try it and let me know if it works for you.  If there are gaps, I can work with the maintainer to keep it working well.

I will look at it. For the moment I tuned https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters to make it work as it did not work out of the box. I usually do not want to display any coverage data on a normal tox run, unless there is a regression, just to keep the console clean.


Style issue in .document-footer-meta

On this page, it would be good to have some more spacing between the dd elements in #whitehall-wrapper .document-footer-meta .primary-metadata dd, so it's a bit more readable.

The fix in #1942 will get deployed early next week.
Sorry for the delay. It got fixed in the standardised component, but was overlooked here


Commands are not broadcast

Executing commands is not broadcast and so other clients do not get the execution.

FIXED


cmd/gopherbot: race condition in auto-closure of scratch CLs causing gopherbot to stall 30s

When closing scratch CLs, the maintner corpus doesn't get updated fast enough and it attempts to close the same CLs again, resulting in a 409 conflict:
2018/10/19 20:19:32 closing scratch CL https://golang.org/cl/140997 ...
2018/10/19 20:19:32 abandon scratch reviews: HTTP status 409 Conflict; change is abandoned
2018/10/19 20:19:32 HTTP status 409 Conflict; change is abandoned
2018/10/19 20:19:32 gopherbot ran in 1.745149115s
2018/10/19 20:19:32 sleeping 30s after previous error.

This error causes gopherbot to sleep for 30s as a result.
This is related to #28226 /cc @dmitshur

I think I've already seen code somewhere that uses Gerrit API in addition to maintner to confirm the "latest" state before taking some action. @bradfitz will probably remember where that was.
I suspect a fix can use a similar approach.

@dmitshur auto-assignment of reviews and gerritbot both use the Gerrit API so that’s likely where you saw it.

@dmitshur, can you take this one?


Test: Strip PARALLEL labels for PostgreSQL releases before 9.6

Same patch as done for https://github.com/CartoDB/Windshaft-cartodb/pull/791. Since it's downloading individual files instead of the extension itself it needs to remove PARALLEL labels.

I had to change the travis config a bit because some of the postgresql releases where not being pruned correctly (and a different one would show in pg_config). Also, change the sed -i for mktemp for OSX compatibility.


Bridge should take over NICs MAC address

As a user of nmstate, I expect that when I use DHCP to obtain IP for my bridge, it should be the same IP as was originally on the bridge's port. While this used to be the case, starting with Fedora 31 MACAddressPolicy=persistent has been enabled by for virtual devices https://github.com/systemd/systemd/blob/master/NEWS#L499. Due to this change we are not getting the expected IP anymore.
I don't know whether we should go against platform in nmstate, but this change is a serious issue for kubernetes-nmstate and oVirt's use-cases. What do we do about it? Can we change nmstate, so it behaves as we are used to or do we leave it to users (kubernetes-nmstate and oVirt) to either set the MAC explicitly or configure system not to persist the MAC by default?

@almusil @phoracek Do you think this issue is already solved?

I have not tested it yet on kubernetes-nmstate since we are still on 1.20.

@phoracek is it important for you to get this fixed in Fedora right now? It is not a problem in CentOS 8.

Not for Fedora, but we need it on 1.20. But I suppose you cannot fix that, can you?

I guess systemd already received enough complains, they included a long changelog explaining this:
https://github.com/systemd/systemd/blob/master/NEWS#L1004
As it said, if user is impacted by this, they can use
          # /etc/systemd/network/98-bridge-inherit-mac.link
          [Match]
          Type=bridge

          [Link]
          MACAddressPolicy=none

For Fedora, they can change whatever they like.
For RHEL, they will not change that dramatically, if they do, their QE will create a regression bug.
Regarding what nmstate can do, the best we can do is document this and instruct user to
change systemd config if they want bridge to take the kernel MAC address.

Not for Fedora, but we need it on 1.20. But I suppose you cannot fix that, can you?

The issue that you describe here does not depend on the NM version. Do you maybe mean the problem that was fixed in #708? I do not see how we can fix this with 1.20 because it required a change in NM.

Gotcha! Thanks @tyll and @cathay4t.
I will add the workaround Gris mentioned into out docs and consider it done. We are moving to 1.22 in a few days.

@phoracek Another background history on #708,  NM 1.20 or older version has a [bug] when using NetworkManager internal DHCP client. So we expect user to use dhclient for this use case.
With #708 (in nmstate-0.2.2) and NM 1.22, you can use NetworkManager internal DHCP client now(RHEL 8 default setting) or the dhclient to get the expected results.
For Bridge not takes over its first slave's MAC address, that's a systemd's issue:
Fedora 30- and RHEL 8 does on have this problem yet(we have test case monitor this).
Fedora 31+ need workaround on /etc/systemd/network/98-bridge-inherit-mac.link above.

@ffmancera Can we close this issue now?

@phoracek Another background history on #708, NM 1.20 or older version has a bug when using NetworkManager internal DHCP client. So we expect user to use dhclient for this use case.
With #708 (in nmstate-0.2.2) and NM 1.22, you can use NetworkManager internal DHCP client now(RHEL 8 default setting) or the dhclient to get the expected results.
For Bridge not takes over its first slave's MAC address, that's a systemd's issue:
Fedora 30- and RHEL 8 does on have this problem yet(we have test case monitor this).
Fedora 31+ need workaround on /etc/systemd/network/98-bridge-inherit-mac.link above.

Should we document this somewhere?

Should we document this somewhere?

This github issue is the good document.

I have include the detail in our API document:
https://www.nmstate.io/devel/api.html#limitations-of-linux-bridge-interface


If the size of the input image is different from the set value, what should be done

Since I want to change the size of the network input image, for example, the input is a rectangular image, do I need to retrain the parameters? If so, how to achieve this? If not, should we just change 229229 to the required size?just like 256176。Hope someone can help to answer, thank you very much

In principle, you could resize your images to the desired size, as long as you do not change the aspect ratio with this resizing. You would get a FID score, but this score would not be comparable to FID scores computed with 299x299.
If you want to compare against other methods, you need to use 1:1 aspect ratio. You could take the central image crop for this.

@mseitzer
Since both the trained image and the original image are rectangular, that is, the aspect ratio is not 1:1, in this case, if the network structure needs to be reset for training, such as changing the size of the convolution kernel, how to train its parameters?
On the other hand, if there is no need to change the network structure, that is, if I change the image from rectangle to aspect ratio of 1:1, since this will change other information in the image, such as the position information, whether it will have an impact on the final result? If you have any opinions on this, please let me know.

You don't need to retrain the network. You should change the aspect ratio, as the networks were trained on valid aspect ratios.
You can however input your rectangular images directly into the network (without resizing to a different aspect ratio), and you would get a FID score out. But I repeat from above: this score would not be comparable to FID scores computed with 299x299. You can only use it to compare your own models with each other on your target dataset.
To do so, you have to disable automatic resizing by changing
https://github.com/mseitzer/pytorch-fid/blob/d042ab8a9f8e4b388c21bc7b38d9599c5fbcfe7b/src/pytorch_fid/fid_score.py#L252
to
model = InceptionV3([block_idx], resize_input=False).to(device)

If all your images have the same size, then this will work. If they have different sizes, you also need to change the batch size to 1 with the argument --batch-size 1. This will make the evaluation super slow of course.
Overall, it is easier to take a square central crop of your image.

@mseitzer
Do you mean that I can directly input my rectangular image into the network for testing, just by changing the model to "disable automatic resize"?
The disadvantage is that I cannot compare the FID scores obtained in this way with the FID scores  computed with 299x299. . I can only compare them against my own data set?
Thanks a lot for your answers.

Yes, this is what I was trying to say. And yes, you can most likely not compare the values to FID scores with 299x299. FID is known to be sensitive to variations in how the input is represented, so it would give you different results there.


lost connection device. Exited (sigterm)

Issue Type: Bug
I working on flutter 2.2 and yesterday, it was compinling well, but today, without any appearing reason, I have this error code when I try to compile :

sK9LdDSXh9RzyfkztFjKIg==/lib/x86/libflutter.so (offset 0x113f000)
    #18 pc 000007d3  <anonymous:cdd80000>
Lost connection to device.
Exited (sigterm)

Compiling is working well on android Studio...
Therefore and maybe linked, I encounter an error message not blocking :
flutter doctor -v
[√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [version 10.0.18363.778], locale fr-FR)
    • Flutter version 1.12.13+hotfix.9 at E:\dev\src\flutter
    • Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\Youstella\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio1\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    X Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed
      instructions.

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio1
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.44.2)
    • VS Code at C:\Users\Youstella\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.9.1

[√] Connected device (1 available)
    • AOSP on IA Emulator • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

Can you help me ?
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T16:36:23.138Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
AMD Ryzen 5 2600 Six-Core Processor             (12 x 3394)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (7.91GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

dart-code
Dar
3.9.1

flutter
Dar
3.9.1

material-icon-theme
PKi
4.0.1

This doesn't look like a problem with VS Code. Which process prints the 'lost connection' error message?

I'm trying to debug a flutter code. I was first thinking it was a problem with VS code, bu tthe problem is on my app code ..., but I annot compile it and debug it by myself. Here is my class code :
`import 'package:flutter/material.dart';
class VisitCard extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
backgroundColor: Color(0xFF6A1B9A),
appBar: AppBar(
title: Text('Mon Profil'),
backgroundColor: Colors.transparent,
elevation: 0.0,
),
body: Center(
child: Padding(
padding: EdgeInsets.all(15),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
CircleAvatar(
radius: 70.0,
backgroundImage: AssetImage('assets/kitty.jpg'),
),
Card(
child: Text(
'Alice',
style: TextStyle(fontFamily: 'YatraOne', fontSize: 10),
),
),
Card(
child: Text('Une petite merveille !',
style: TextStyle(
fontFamily: 'JosefinSans',
fontSize: 10,
))),
RaisedButton(
onPressed: () {},
child: Text('Plus d'infos',
style: TextStyle(
color: Colors.white70,
)),
color: Colors.blueAccent,
),
]),
)),
);
}
}
`

Sorry, I don't know Dart. Best to ask in the Dart community.


WIP:[BEAM-5309] Add streaming support for HadoopFormatIO

Continuation of BEAM-3912 which adds streaming support in HadoopFormatIO.
See design documment for detailed description.

@timrobertson100 I guess you could be interested in this PR as well. Would you mind to take a look?

Thank you for your reviews.
I pushed new version with processed notes. You can find what was changed bellow:

Implementation of the ExternalizedSynchronization.
TaskAttemptID included in the write process.
ConfigurationTransform was removed.
Changed approach how to build Write object.

In the following commits I want to work on following things:

Update javadoc.
Better test coverage.

Latest version was pushed.
I think that all review notes was processed.
@aromanenko-dev , @dmvk : Could you please do next iteration of review?

@b923 Great, thank you for your work! I'll take a look on this asap

retest this please

Sorry for delay with review, I was off for a while. In general, it almost looks ok for me, thanks!
Did you test writing in batching and/or in streaming mode on distributed environment? If yes then could you add some details about this testing - which runner, type of sync, number of partitions, etc?

Yes, we were testing it on spark in batch mode. In both partitioned and non-partitioned configuration. Both configurations had same results.
Runner: SparkRunner
Partitioned configuration:
2 partitions
Non partitioned configuration:
Synchronization: HDFS synchronization

@b923 Thanks, sounds good!
In general, it LGTM and I believe it's ready to be merged. @iemejia @timrobertson100 do you have any comments on this?

Thank you @b923 - there is a lot of work that has gone in to this and a really useful addition.
I am afraid I don't have time to do a thorough review, but I have read the code and put in a few veru minor observations.
The code is well structured so will be easy to work on and doesn't look like it will break anything.

Run Website PreCommit

What is a state of this PR? If I'm not wrong then it looks that all review requests were addressed.
Is it ready to be merged? @b923 @dmvk @timrobertson100 do you have any comments/suggestions about things that we are missing and should be done before merging?

Thank you,
all notes are processed from my point of view. HadoopFormatIO class is annotated as @Experimental.

Recently, we have an issue with closing of FS in HDFSSynchronization. I made it closeable based on code review but it closes all connections to the HDFS since FileSystem.get() returns  singletone.
I did a fast fix that FileSystem is not closing now.
I will let you know as soon as I find better solution.

@b923 Thanks!
I'd wait for a fix of this issue before merging.

@b923 Do you have any update about the issue which you have found before?

@b923 Thank you for fixing this, it looks reasonable for me.
I think we are ready to merge this PR.
As a recall, after it will be merged, we need to move current HadoopInputFormatIO.Read into new created HadoopFormatIO to leave only one IO for Hadoop format files and deprecated old one.
Any objections about that?

@aromanenko-dev  thank you.
I am OK with that.

I merge this PR since it was approved and all issues were fixed.
Thanks @b923 for you work!


fix: fix 0 stride in CG pool management

fix #286

test pass
=============================== warnings summary ===============================
test/test_model_optimization.py: 1 warning
test/test_torchdynamo.py: 79 warnings
  /home/geantvert/.local/share/virtualenvs/kernl/lib/python3.9/site-packages/torch/cuda/graphs.py:82: UserWarning: The CUDA Graph is empty. This ususally means that the graph was attempted to be captured on wrong device or stream. (Triggered internally at ../aten/src/ATen/cuda/CUDAGraph.cpp:191.)
    super(CUDAGraph, self).capture_end()

test/debugger/test_memory.py::test_load_is_in_different_memory
  /mnt/workspace/kernl/test/debugger/test_memory.py:58: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
    assert t.storage().data_ptr() != a.storage().data_ptr()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========== 2880 passed, 3 skipped, 81 warnings in 8679.71s (2:24:39) ===========


Extra/Unknown fields handling

Pull request to show in progress code

Just a question, is any the correct term here? I am more inclined to extra.

Just a question, is any the correct term here? I am more inclined to extra.

I was thinking the exact same thing. I originally thought std::any, or similar, was the topic given the name until I read more into it.

Indeed this is not very clear, but I took this name from the Java Implementation as explained in  https://github.com/stephenberry/glaze/issues/528
I renamed it for clarity

@anaelorlinski
Just let me know when you're ready for me to review this pull request. Thanks for putting in this work.

I completely rewrote the implementation, you can start review

@anaelorlinski, your implementation looks fantastic! Really nicely written and you used the Glaze internals well, which I know takes some time to get used to.
I added a unit test for when we know the type, but the keys are unknown, and it works great.
I slightly tweaked the write code, adding a std::forward to try to encourage the compiler to inline. Not sure if it's actually needed, but it doesn't hurt.
My final request is if you could add some documentation to the markdown file I just created docs/unknown-keys.md, just explaining why this feature exists and how it is used.
Thanks!
Stephen

doc updated :)

Thanks! I'll merge it in.

@anaelorlinski Great work!


Add support for shared Array Buffers in workers

Description of the problem
Allow workers to use the SharedArrayBuffer API from v8, to share raw data across multiple threads.
Desired solution for the problem
Main thread
// Assume a worker is already created somewhere and stored
// in the variable 'worker'

// Create a new shared array buffer
let buffer = new SharedArrayBuffer(200);

// Add the buffer to the worker
// Returns an index that can be used inside the worker to retrieve that buffer
let index = worker.addSharedBuffer(buffer);

// Send an event to the worker to get the buffer
worker.emit("getMyBuffer", index);

Worker thread
let myArrayBuffer = null;

alt.on("getMyBuffer", (index) => {
  // Gets the shared buffer at the specified index
  myArrayBuffer = alt.getSharedBuffer(index);
  // Now the shared buffer can be interacted with as you normally would
});

Alternatives you considered
No response
Additional context
No response
Version
No response
Scope
client

Added in #73


HTMLParser and LexborHTMLParser search differently

in```
'td class="table-main__odds" data-odd="3.45" data-oid="6e0f1xv498x0x0"
/td'

css_first('[data-odd]') doesn't find attribute for LexborHTMLParser
but HTMLParser finds this attribute

I removed the tags <> because they were not shown in the topic

Hi @SkySandy
This is the correct behavior for HTML (LexborHTMLParser ).
Unfortunately HTMLParser does not handle the above example correctly.

A TD tag without a TABLE tag will be deleted (not inserted into the final HTML tree).
Actually, that's why it can't be found through the selector, it's just not there.
Try opening your example in a modern browser and you'll see exactly the same behavior.


Escaped quotes are not handled properly

It seems to add an extra set of quotes to strings even if it's already escaped
Expected:
var encoded = csvJs.encode({ a: 3, test: "\"value\"", b: 5});
console.log(csvJs.decode(encoded));
// should return [ {a: 3, b: "\"value\"", test: 5} ]

encoded = csvJs.encode({ a: 3, test: "12\"vinyl", b: 5});
console.log(csvJs.decode(encoded));
// should return [ { a: 3, test: "12\"vinyl", b: 5} ]

Actual:
var encoded = csvJs.encode({ a: 3, test: "\"value\"", b: 5});
console.log(encoded);
// returns "a,test,b\n3,\"\"\"value\"\"\",5"

console.log(csvJs.decode(encoded));
// returns [ {a: "3,\"\"\"value\"\"", b: "", test: 5} ]

encoded = csvJs.encode({ a: 3, test: "12\"vinyl", b: 5});
console.log(encoded);
// returns "a,test,b\n3,\"12\"\"vinyl\",5"

console.log(csvJs.decode(encoded));
// returns [ {a: 3, b: 5, test: "12\"\"vinyl"} ]

you're welcome to write that fix; i look at your sample as bad data. double quoting a string for no reason.

unless you're offering a pull request i'm not working on this; 3 years too late for me.

it's so broken. thank's for pointing this out; will aim to have fixed sometime this week. might be a simple 'not' condition in regex, but i get the sense it's deeper.

Should be good now; i've added corresponding tests and corrected flawed existing tests.


Update DyNAS-T to 1.3.0

Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed
Signed-off-by: Maciej Szankin<EMAIL_ADDRESS>

Once CI passes I will re-release DyNAS-T with a stable version tag and update this PR.

/Azurepipeline UT-Basic

/Azurepipeline run UT-Basic


Suggest systemd service example for fedifetcher has user set to something other than root for security purposes

Currently the systemd service example has
User=root

I have just noticed this and changed mine to a de-privilaged user that also runs mastodon (mastodon).
Probably a good idea to suggest this to others.

Thanks. Agree this would be a good idea. Are you able to provide a PR?

Also, the service should not have an install section, as it is triggered by timer and not meant to be enabled directly.

I've changed this in the process of moving this to a wiki #168 : https://github.com/nanos/FediFetcher/wiki/Running-FediFetcher-as-a-systemd-timer

Oh this is perfect. This security concern had me grepping through all my unit files to see what else doesn't need root. Will use analyze instead. Thanks!


[BindRequired] attribute description unclear

Description states "Can only be applied to model properties, not to method parameters. ",
but the source code allows the attribute on parameters
([AttributeUsage(AttributeTargets.Class | AttributeTargets.Property | AttributeTargets.Parameter, AllowMultiple = false, Inherited = true)]
from https://github.com/aspnet/AspNetCore/blob/master/src/Mvc/Mvc.Core/src/ModelBinding/BindRequiredAttribute.cs )
Can you please clarify this contradiction?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e24f48f8-6c4d-ecda-6ce6-a7826d396e99
Version Independent ID: 9c4af557-8d06-4c6c-ad2a-0dd234547563
Content: Model Binding in ASP.NET Core
Content Source: aspnetcore/mvc/models/model-binding.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It has other restrictions
Note that this [BindRequired]  behavior applies to model binding from posted form data, not to JSON or XML data in a request body. Request body data is handled by input formatters.

The doc notice [BindRequired] don't work with method's parameter :

[BindRequired] attribute
Can only be applied to model properties, not to method parameters. Causes model binding to add a model state error if binding cannot occur for a model's property. Here's an example:

But when I try, [BindRequired] appear to work correctly with method's parameter.
Example :
[ApiController]
[Route("data")]
public class DataController : ControllerBase
{
    [HttpGet]
    public IActionResult Post([BindRequired] int id, [BindRequired] string label)
    {
        return Ok(new { id, label });
    }
}

When I call http://localhost:5005/data, this return this :
{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.1",
    "title": "One or more validation errors occurred.",
    "status": 400,
    "traceId": "00-a5d0607e3ac60f44b47639f45e77fd6a-bedbe77983591349-00",
    "errors": {
        "id": [
            "A value for the 'id' parameter or property was not provided."
        ],
        "label": [
            "A value for the 'label' parameter or property was not provided."
        ]
    }
}

Is the doc incorrect?
Or method's parameter mean other thing?

The doc notice [BindRequired] don't work with method's parameter :

[BindRequired] attribute
Can only be applied to model properties, not to method parameters. Causes model binding to add a model state error if binding cannot occur for a model's property. Here's an example:

But when I try, [BindRequired] appear to work correctly with method's parameter.
Example :
[ApiController]
[Route("data")]
public class DataController : ControllerBase
{
    [HttpGet]
    public IActionResult Post([BindRequired] int id, [BindRequired] string label)
    {
        return Ok(new { id, label });
    }
}

When I call http://localhost:5005/data, this return this :
{
    "type": "https://tools.ietf.org/html/rfc7231#section-6.5.1",
    "title": "One or more validation errors occurred.",
    "status": 400,
    "traceId": "00-a5d0607e3ac60f44b47639f45e77fd6a-bedbe77983591349-00",
    "errors": {
        "id": [
            "A value for the 'id' parameter or property was not provided."
        ],
        "label": [
            "A value for the 'label' parameter or property was not provided."
        ]
    }
}

Is the doc incorrect?
Or method's parameter mean other thing?


Deploy to now.sh instead of lambda

This is really good, although needs some changes because now.sh should be another destination target and not the only one :-)
I will add some commit to finishing up.
Thanks so much @timneutkens


Build docs

Hi @En3Tho, this is my personal account.  I've been getting ready to tackle #9  but first I needed to work out how to build/test the module.
These are the instructions I created.  Let me know if there is a far easier way to do that and I can update them.

@tznind Nice! Seems like a great end to end tutorial. I will take a closer look a little bit later but for now I can say that the easiest way just to test the logic/UI is to use PoshRedisViewerHost project as it's just a console app.
I guess the doc can include 2 sections: one with easy way (host) and the other the hard way (module).
Usually module project is needed only for publish or when the command itself changes. Any other time host project is okay.
You can even use dotnet watch with it. It will always recompile but it's quite fast at doing so.

Ah I hadn't realized.  It wasn't set as my startup project in visual studio so struggled a little.
Thanks.
I have updated this PR docs to indicate the two ways of testing.

Thanks!


Spell check

Turn on and off? Always on?

just stumbled upon phenomenal UX for spell check, and it's absolutely possible with visbug! check this out


Impersonate fix

Made a quick fix to routing that was causing /#!impersonate-user not to work (static routing was directing to homepage). Also implemented a change in the file schema requested by Koray.

Coverage remained the same at 41.59% when pulling 9b17d4d4bab43e48383ff690977d110559c7f229 on impersonate_fix into b1170734f97500d66a45de81af95969578c53729 on master.

Coverage remained the same at 41.59% when pulling 9b17d4d4bab43e48383ff690977d110559c7f229 on impersonate_fix into b1170734f97500d66a45de81af95969578c53729 on master.


Use the new wasmparser::VisitOperator API

Codecov Report

Merging #420 (82d9871) into master (e9b0463) will decrease coverage by 5.09%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   76.78%   71.69%   -5.10%
==========================================
  Files          71       72       +1
  Lines        6836     7429     +593
==========================================
+ Hits         5249     5326      +77
- Misses       1587     2103     +516

Impacted Files
Coverage Δ

wasmi_v1/src/engine/func_builder/visit.rs
35.02% <ø> (ø)

wasmi_v1/src/engine/mod.rs
85.26% <ø> (ø)

wasmi_v1/src/module/export.rs
36.53% <ø> (ø)

wasmi_v1/src/module/global.rs
83.33% <ø> (ø)

wasmi_v1/src/module/import.rs
75.00% <ø> (ø)

wasmi_v1/src/engine/func_builder/error.rs
18.18% <18.18%> (ø)

wasmi_v1/src/module/error.rs
23.52% <66.66%> (+9.24%)
:arrow_up:

wasmi_v1/src/engine/func_builder/mod.rs
92.67% <100.00%> (+0.03%)
:arrow_up:

wasmi_v1/src/module/compile/block_type.rs
95.55% <100.00%> (+0.10%)
:arrow_up:

wasmi_v1/src/module/compile/mod.rs
100.00% <100.00%> (+61.41%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[DataLoader2] Adding support for naive snapshotting

Stack from ghstack:

-> #915
#1056
#998

Differential Revision: D43644875

@nivekt has imported this pull request.  If you are a Meta employee, you can view this diff on Phabricator.

Closing. Feel free to re-open if someone else would like to work on this.


KAFKA-2300: Error in controller log when broker tries to rejoin cluster

I have reopened this issue because the controller isn't cleaning up the state upon an exception and the test case was legitimately failing for me every now and then. I'm proposing a change to fix this.

Test failure is unrelated to the latest change (I have only added parentheses):
kafka.producer.ProducerTest > testSendWithDeadBroker FAILED
    java.lang.AssertionError: Message set should have 1 message
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at kafka.producer.ProducerTest.testSendWithDeadBroker(ProducerTest.scala:260)


Clarity website Iconography: Two hex numbers are incorrect

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Clarity website > Iconography > Design Guidelines
The Predefined color classes table shows a couple incorrect hex #s:

Hex numbers should be updated to match the icons in the right column.

I'll fix this for tomorrow's release...

Done. Completed with 0.9.0 push.


Executed at unknown time

I am amble to run gradio live but once i get there i can maybe generate 1 to 2 batches of images before the program stops randomly. I am no longer able to generate anything until I start it back from the beginning in colab. Would getting colab pro resolve the issue? SD was working perfect a month ago and I have changed nothing to my files

same issue

colab free no longer support sd, I suggest the alternatives Runpod or paperspace
https://www.runpod.io/console/gpu-browse?template=runpod-stable-unified
https://console.paperspace.com/github/TheLastBen/PPS?machine=Free-GPU


fix(ObservableAjax): only set default Content-Type header on non-GET

Description:
Related issue (if exists):

Coverage remained the same at 96.472% when pulling 09e31a0d6041066303868834085fa469a3c08f17 on elliotschi:patch-1 into 4f65b03ce6908a934602d619993fa31ec49a2cbf on ReactiveX:master.

Coverage remained the same at 96.689% when pulling c1181c3400c4cf8a73b4bf20b283c44a377b0105 on elliotschi:patch-1 into 548ec2a3f3a74c87f40ee74df98f06b38d5c2c2b on ReactiveX:master.

nitpicking: although very odd to do so, some APIs do in fact require people to include a body with GET requests--I've seen it a number of times. So I'm thinking perhaps we should instead only omit it if they omitted a body as well?
request.method !== 'GET' && typeof request.body === 'undefined'

Or even...if they don't provide any body just omit it regardless of what the method is. Not sure if there's any value in providing a content type with no content?

Coverage remained the same at 96.707% when pulling 90e42e21a6c7993876c904067a12d598f65740c4 on elliotschi:patch-1 into 0035583def1627afc2abc83616f3a62e2b7217bf on ReactiveX:master.

Coverage remained the same at 96.707% when pulling 90e42e21a6c7993876c904067a12d598f65740c4 on elliotschi:patch-1 into 0035583def1627afc2abc83616f3a62e2b7217bf on ReactiveX:master.

Coverage remained the same at 96.707% when pulling 90e42e21a6c7993876c904067a12d598f65740c4 on elliotschi:patch-1 into 0035583def1627afc2abc83616f3a62e2b7217bf on ReactiveX:master.

LGTM


Decouple mint from Value

Resolves #2911

Changes the mint field in TxBody from Value to MultiAsset, representing a map of assets
Removes now redundant rule checking that ada  is not being forged

Force-pushed to incorporate feedback from Tim (except valueFromList)

Added a commit that restores valueFromList  and uses it to remove duplication, following Tim's  apt suggestion

Reorganized commits to reduce noise and squashed them such that each one leaves the code in a valid state

I think I addressed all comments and change requests - would be great to merge if anyone wants to take another look and/or approve!


Multiple samples error in rlength_distr

Hello,
I am able to generate read length distribution plots for individual samples. However, when I try to use multiple samples I get this error:
example_length_dist_rep <- rlength_distr(reads_list,
sample = list("Liver_avg" = c("Liver_2.norrna_notrna_ref_mRNA", "Liver_3.norrna_notrna_ref_mRNA")),
cl = 99, multisamples = "average",
colour = "gray70")
Error in rlength_distr(reads_list, sample = list(Liver_avg = c("Liver_1.norrna_notrna_ref_mRNA",  :
unused arguments (multisamples = "average", colour = "gray70")
Any ideas on how to resolve this issue?
Thank you

Hi there.
rlength_distr works fine with my own data and the very same options from your chunk. Are you sure you have the latest version of riboWaltz? A couple of things changed in the last updates, especially regarding the handling of multiple samples in rlength_distr. E.g., previously the parameter multisamples was differently defined.
Best
Fabio

I had the latest version but redownloaded it and that did the trick!
Thank you for your help!


fix DataCache duplicate results + invalid Contract return type handling

What current issue(s) does this address, or what feature is it adding?

audit of testnet block 1546918 showed a deviation in VMState due to incorrect handling of duplicate results from the DataCache + Internal storage. Internal storage only returns the actual key value, whereas the DataCache holds contract_hash + key values for looking up.
various testnet blocks showed error logs regarding various Serialization/Deserialization issues. I investigated 2 cases (Runtime_Serialize and Runtime_Deserialize) of respectively blocks 1552947 and 1553029 and concluded that the behaviour is inline with C# neo-cli. The error message is too aggressive possible leading to user confusion whether it's a real problem or not
audit of testnet block 1575282 showed a deviation in VMState and Storage due to incorrect handling of an invalid Contract return type. neo-python accepted this, whereas neo-cli throws an exception.

How did you solve this problem?

fix key lookup check by adding the necessary prefix
lower debug level from error to debug
tighten contract return type validation

How did you make sure your solution works?
audit passes, make test passes
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage decreased (-0.005%) to 85.279% when pulling 2b528cdd63c57658c672451984f3e5a2a512490a on ixje:fix-various into 79f43a873204c40213b41aa89bda70c15cc819c6 on CityOfZion:development.


Reinstated 2 terms; #29149

InterPro should not be used as a definition cross reference. Please find a paper.


Update developers section with KIE group reference

There is also https://github.com/kiegroup/kogito-examples/pull/261

Do we have any way of restarting the PR check? I don't see how the failure could be related to this PR.

jenkins retest this

jenkins please retest this

@rsynek can you try rebasing please.

jenkins retest this please


Update linrongbin16/lsp-progress.nvim

Update the description
Repo URL:
https://github.com/linrongbin16/lsp-progress.nvim
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[x] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks! Can you also remove the for Neovim from the description?

Thanks! Can you also remove the for Neovim from the description?

Hi, it's done.


Tree Recursion

Related Issue
issue #1272
Proposed Changes

Create TreeRecursion.cpp
Update README

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

Output Screenshots
Code image

input image

Output image

Give a brief Explanation of the problem in describtion

It will be preferable ..if you create separate Folder in R-Recursion on Types of Recusion and create PR's on all types of recursion one bye one .

okay thankyou...👍


Tests: Flakyness SystemError: Failed to start Crate instance in time

The root cause for SystemError: Failed to start Crate instance in time. (see https://github.com/crate/crate-python/issues/629) is that a previous instance of CrateDB might not have been terminated correctly.
In that case, a subsequent attempt to start it will croak like [1,2]
Caused by: io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use

[1] https://github.com/crate/crate-python/runs/6210165871#step:6:192
[2] https://github.com/crate/crate-python/runs/6540915990#step:5:233
_Originally posted by @amotl in https://github.com/crate/crate-python/issues/629
References

crate/crate-python#225

Still happening occasionally.
BindException: Address already in use.
SystemError: Failed to start Crate instance in time.

-- https://github.com/crate/crate-python/actions/runs/9562806841/job/26359960751?pr=625#step:4:354

This issue hasn't been observed recently, so I am closing this.


fix reporting of err messages

@cjellick
Fixes  - https://github.com/rancher/rancher/issues/2942

@cjellick Tested it and it works well

@wlan0 The build has compilation errors.

@ibuildthecloud - Fixed the issue.


Add getDefaultName() method to Field & Entry

Description
Follow-up on #11664 for form Field and infolist Entry.

[x] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

[x] composer cs command has been run.

Testing

[x] Changes have been tested.

Documentation

[x] Documentation is up-to-date.

Had to revert the original PR, see my comment


TypeError: init() got an unexpected keyword argument 'pretrained'

DFL-CNN <==> Part1 : prepare for parameters <==> Begin
DFL-CNN <==> Part1 : prepare for parameters <==> Done
DFL-CNN <==> Part2 : Load Network  <==> Begin
Traceback (most recent call last):
File "main.py", line 180, in
main()
File "main.py", line 91, in main
model = DFL_VGG16(k = 10, nclass = 200)
File "/home/steven/Documents/test/DFL-CNN/model/DFL.py", line 13, in init
vgg16featuremap = torchvision.models.vgg16_bn(pretrained=True).features
File "/usr/local/lib/python3.5/dist-packages/torchvision/models/vgg.py", line 130, in vgg16_bn
return VGG(make_layers(cfg['D'], batch_norm=True), **kwargs)
TypeError: init() got an unexpected keyword argument 'pretrained'
Hello dejia
when I reappearance  your code this error happened ,Where is the problem?

Maybe the version of torchvision should be updated.

https://forums.fast.ai/t/forward-got-an-unexpected-keyword-argument-pretrained/80582
Try this, it worked for me.
import fastai
model = fastai.vision.model.YOURMODELHERE
learn = vision_learner(dls, model, metrics=error_rate)


Memory Leak?

I'm new to this library and wasmtime, so I may be overlooking something. But doesn't LoadJson() leak the the allocated memory?
private int LoadJson(string json)
{
	int addr = Policy_opa_malloc(json.Length);
	_envMemory.WriteString(_store, addr, json);

	int parseAddr = Policy_opa_json_parse(addr, json.Length);

	if (0 == parseAddr)
	{
		throw new ArgumentNullException("Parsing failed");
	}

	return parseAddr;
}

The memory allocated at addr is not freed. Don't you need to do something like this?
private int LoadJson(string json)
{
	int addr = Policy_opa_malloc(json.Length);
	_envMemory.WriteString(_store, addr, json);

	int parseAddr = Policy_opa_json_parse(addr, json.Length);

	Policy_opa_free(addr);

	if (0 == parseAddr)
	{
		throw new ArgumentNullException("Parsing failed");
	}

	return parseAddr;
}

https://github.com/christophwille/dotnet-opa-wasm/pull/35

I think I understand. While it's technically true that the memory is leaked, even if it was freed it would never be used again.


Migrate from travis to github actions

Removed travis
Added github actions for build release and make tg/slack notifications

 Миграция с travis на github actions


Convert ActiveEffectLike UUID value.value to names

Useful for Druid feats like Dragon Shape

Extract will wait until after https://github.com/foundryvtt/pf2e/pull/11634 to avoid conflicts.

Instead of expanding this without end, we should just have it cover any RE.

Instead of expanding this without end, we should just have it cover any RE.

Recursively iterate looking for strings? That seems reasonable.

If this looks good, I'll extract.


"metacompleter" i.e. completing from a group of completers

In prompt toolkit 1 I had a set up where I had a metacompleter that had a list of completer instances and then get_completions method of the metacompleter basically just yielded from all the it's completers. The reason for this is basically to support completion plugins that may or may not be loaded by the user.
This doesn't appear to work in prompt toolkit 2. Or at least I haven't gotten it to work in a short amount of time (it's possible that that is actually fine but that there's been some other API change that is causing to me to not see any completions).

class MetaCompleter(Completer):
    def __init__(self, *completer_instances):
       self.completers = completer_instances

     def get_completions(self, document, complete_event):
        for c in self.completers:
            for h in c.get_completions(document, complete_event):
                 yield h

Basically something like that ^. So is there a canonical way to do that with prompt toolkit? And should that work in prompt toolkit 2 or has there been changes in that area (I hadn't spotted anything obvious so far)

Hi @sanga,
I added a merge_completers function that can combine multiple completers into one.
See: https://github.com/jonathanslenders/python-prompt-toolkit/commit/d15d79ad6df9ea22f86b0179d04e08fbf602138d and https://github.com/jonathanslenders/python-prompt-toolkit/commit/4a431a999617683ae0cf4c7a2f2cd8e9d3a1d170 (the second commit contains an example).
Would this work for you?

Yes, that works. Thank you. I figured out what my problem was btw. Prompt tk has always said that all strings must be unicode however apparently prompt tk 2 got more strict about this (I was passing in regular strings in a couple of places and that used to work in v1). Anyway, that merge_completers func works just fine. Cheers!

Ok, good to hear!


Improve rendering capabilities for particles

Add support for techniques used in Bipin's paper.

Duplicate of #3009


A question about the experiment results in your paper

Hi, thanks for your work and code. I notice that the F1 max score of SG_PR is quite different, actually much lower, in your paper. I'm quite interested in a place recognition task, so I'd like to go deep into details. Did I miss any key points? Could you please explain the result? Thanks and best wishes.

Hi, thanks for your work and code. I notice that the F1 max score of SG_PR is quite different, actually much lower, in your paper. I'm quite interested in a place recognition task, so I'd like to go deep into details. Did I miss any key points? Could you please explain the result? Thanks and best wishes.

Hello! Thanks for your question.
Our test data selection strategy is slightly different from SG_PR. In SG_PR's paper, negative samples are randomly selected according to a certain probability. In our experiments, we found that the proportion of negative samples selected according to the above method is too small, so the results of most methods are relatively high. To highlight the gap between different methods, we set more stringent test conditions; more negative samples are selected. The selection strategy is specifically described in our paper; that is, negative samples are selected according to a fixed ratio (1,10,20,50,100). The number of negative samples in Table 1 is 100 times that of positive samples, which is much higher than the ratio used in the SG_PR paper. You can download the list of test samples through this link.

Thanks! That seems to be a valid explanation. Also, your consideration has broadened my mind. Thanks again for your great work.


Systemd: Reloading udevadm rules

On the environment setup pages for Linux (pages 3.1 and 3.4), it is recommended to run udevadm control --reload-rules to, of course, reload the new udev rules. However, at least on systemd-udev, the option to reload the rules is simply udevadm control [-R | --reload].
--reload-rules seems to just fail silently without actually reloading the rules. This may be different on non-systemd computers, but I personally don't have a way of verifying this.

Using Ubuntu 18.10 and udev 239-7ubuntu10.4, I can confirm that --reload is the documented option, and that --reload-rules yields no output, just like --reload.
However, it seems like the system detects changes in the udev rules automatically and apply them as soon as I replug the device.


Support spacing range in drt

Describe the bug
There are some PDKs that still use the older range still spacing rules, eg:
LAYER layerName
TYPE ROUTING ;
  SPACING minSpacing
    RANGE minWidth maxWidth

We don't need to support the sub-options but this basic syntax is needed.  Currently this triggers:
    if (rule->hasRange()) {
      logger_->warn(DRT, 140, "SpacingRange unsupported.");

and leads to incorrect results.
Expected Behavior
Support this rule.
Environment
Head of OR

To Reproduce
Private PDK so a manual test will have to be generated.
Relevant log output
No response
Screenshots
No response
Additional Context
No response

gf180 produces similar warning message.
detailed_route -output_drc ./reports/gf180/spm/base/5_route_drc.rpt -output_maze ./results/gf180/spm/base/maze.log -bottom_routing_layer Metal2 -top_routing_layer Metal5 -disable_via_gen -save_guide_updates -verbose 1 -drc_report_iter_step 5
[INFO DRT-0149] Reading tech and libs.
[WARNING DRT-0140] SpacingRange unsupported.
[WARNING DRT-0140] SpacingRange unsupported.

What commit id did you use when you got the gf180 result?

With latest OR commit, warning not exist...


Tabs in the tab block not following the defined order

Description of the bug
Tabs in the tab block are not shown in the defined order.
Reproduction steps

Create a number of page block on a page
Create a tab block and add those page blocks
Give them labels that make it easy to see if the order is maintained (for example, 1,2, 9, 10, 11, A, B, C, 100, F)
Hit save and close
Now you’ll see that the order is not maintained

Expected behavior
The order of the tabs when the block is saved must be equal to the order the tabs are configured in.
Screenshot/Video

Version
Branch: 2023.3.0-dev.5.1
Reporter: Lenny (Test fest)
Browser: Firefox

This appears to have been fixed on the latest copy of 2023.3 base.

For today: Check with Jože if this is working as it should


eglot: result parameter may be wrong

The server should reply to a hover message with the appropriate JSON data or null if the cursor is not over a known identifier. The dylan code is of the form
let result = if (...known identifer?...)
        ...the data...
    end if;
...return result...

and if it is not a known identifier, result is #f which is serialized to JSON false when it should be null.
Other message results may be affected by the same thing.
VSCode and lsp-mode did not complain but eglot does.

I checked the other supported protocol responses and none are affected like this.
Not possible to make #f into JSON null 'globally' (i.e. when the JSON message is prepared and sent) because at least one message returns LSPAny which could include null or false


Feature request: standard file that describes what openapi features are supported by an implementation

Feature request: standard file that describes what openapi features are supported by an implementation
If all implementations provided a yaml or json file of what features were supported it would allow for easier comparison of implementations.
What if we did this with the json schema descriptions of the openapi spec:
https://github.com/OAI/OpenAPI-Specification/blob/main/schemas/v3.0/schema.yaml
And the json path was the feature, like:
#/servers and the value is a boolean or a FeatureSupportInfo object like so:
FeatureSupportInfo:
  type: object
  properties:
    supported:
      type: boolean
    docUrl:
      type: string
    verificationTestUrl:
      type: string
  required:
  - supported

Can you give examples of the types of features you would like to describe?  I think it would be challenging to use a bool value to describe many OpenAPI features.  In JSON Schema a validator keyword either validates or it doesn't. An Annotation either holds the annotation or it doesn't.  I'm not sure how to map that to OpenAPI.

@darrelmiller it might be possible to correlate some things with the semantic output format I'm working on for the reference* parser implementation.  If we have an identifier for certain semantics described by the file, then a tool could say one of:

yes, we understand these semantics and do whatever we think our tool should do for them
these semantics are not relevant to our tool
no, we do not support these semantics although they are potentially relevant to our tool

There is a fair amount of work to be done before we can look at the identifiers and figure out how much this would make sense.  And whether the level of detail in the semantic output format is sufficient for what @spacether has in mind.
@darrelmiller I think I agree with the concern that it's not possible to have a simple boolean feature support list.  @spacether I'd also caution against making then format too complex and requiring people to type in too many explanations.  A file like this will only be used if it's not much effort to fill out and delivers real value.
*reference as in "this is an example to follow" not "$ref" — is there a more clear name we could call this thing?

"Compliance parser"?

COMPLIANCE!


[vLLM][WIP] add speculative configs

Description
Initial PR to support speculative decoding

Test on g5.12xl machine and everything is working fine
engine=Python
option.model_id=TheBloke/Llama-2-13B-fp16
option.speculative_draft_model=TinyLlama/TinyLlama-1.1B-Chat-v0.6
option.rolling_batch=vllm
option.tensor_parallel_degree=max
option.gpu_memory_utilization=0.8

curl -X POST http://<IP_ADDRESS>:8080/invocations -N   -H "Content-type: application/json"   -d '{"inputs":"tell me a story of the little red riding hood","parameters":{"max_new_tokens":256, "do_sample":true}}'
{"generated_text": " and mom im.\nshort little red riding hood, also available in sister's version, big bad wolf story: walt disney presents\nquick i need to quickly translate this story into english to learn.\ni need help, 'please can anybody help me in an essay about bubaris, and i dont know the origin of this story, or when/where it happened.\nplease can anybody help me in an essay about bubaris, and i dont know the origin of this story, or when/where it happened...can anybody help me?.\ncopied this off a site about sufism.. what do you think the story is about ?\nWho knows this Little Red Riding Hood story?\nI can't quite understand this sentence of a story, please help me.?\nExplain the story in these lyrics?\nHi, Could someone please help me translate this story about Elijah :-)\nI'm taking my story for school and i need a lot of examples please?\nHelp I need to make this story exciting?\nHelp, I need someone israel to speak to on a conference calling thing for a project on the holocaust. i have to"}

engine=Python
option.model_id=TheBloke/Llama-2-13B-fp16
option.speculative_draft_model=s3://djl-llm/tinyllama-1.1b-chat/
option.rolling_batch=vllm
option.tensor_parallel_degree=max
option.gpu_memory_utilization=0.8

The following settings also test passed


ethminer-free no longer works with rocm

Describe the bug
A clear and concise description of what the bug is.
Caused by https://github.com/NixOS/nixpkgs/pull/150767
Not sure whether this is an upstream issue or ours.
Steps To Reproduce
Steps to reproduce the behavior:

nix-shell -p ethminer-free --command 'ethminer --list-devices'

Notify maintainers

@Flakebi

Hi, I’m not sure what the output should look like, but it seems to work fine for me (using the unstable channel, which should include the rocm update now).
# configuration.nix
hardware.opengl.extraPackages = with pkgs; [
  rocm-opencl-icd
  rocm-opencl-runtime
];

$ nix-shell -p ethminer-free --command 'ethminer --list-devices'

ethminer 0.19.0
Build: linux/release/gnu

 Id Pci Id    Type Name                          CL    Total Memory  Cl Max Alloc  Cl Max W.Grp
--- --------- ---- ----------------------------- ----  ------------  ------------  ------------
  0 0e:00.0   Gpu  gfx1010:xnack-                Yes        7.98 GB       7.98 GB      256.00 B

That's the exact same setup I have, weird. Are you sure you've got the rocm update? I build directly from git and reverting your PR fixed the issue.

Weird. I checked again, but I got the update:
$ ll /run/opengl-driver
lrwxrwxrwx 69 root root  1 Jan  1970 etc -> /nix/store/y15n95blhmlyrv8gp7z2jbhvwkwn9naw-rocm-opencl-icd-4.5.2/etc
lrwxrwxrwx 77 root root  1 Jan  1970 include -> /nix/store/d9j5dcd0q0j77wvkgpwyszf1y1z6bb13-rocm-opencl-runtime-4.5.2/include
dr-xr-xr-x  - root root  1 Jan  1970 lib
dr-xr-xr-x  - root root  1 Jan  1970 share

I also tried
$ nix-build -A rocm-opencl-icd  # In a nixpkgs checkout
/nix/store/y15n95blhmlyrv8gp7z2jbhvwkwn9naw-rocm-opencl-icd-4.5.2
$ export OCL_ICD_VENDORS="$(pwd)/result/etc/OpenCL/vendors/"
$ nix run '.#ethminer-free' -- --list-devices

ethminer 0.19.0
Build: linux/release/gnu

 Id Pci Id    Type Name                          CL    Total Memory  Cl Max Alloc  Cl Max W.Grp
--- --------- ---- ----------------------------- ----  ------------  ------------  ------------
  0 0e:00.0   Gpu  gfx1010:xnack-                Yes        7.98 GB       7.98 GB      256.00 B

I tried on another machine with an older GPU (RX 480) and there it fails after the update:
# Before the update
$ nix run nixpkgs#ethminer-free -- --list-devices

ethminer 0.19.0
Build: linux/release/gnu

 Id Pci Id    Type Name                          CL    Total Memory  Cl Max Alloc  Cl Max W.Grp
--- --------- ---- ----------------------------- ----  ------------  ------------  ------------
  0 03:00.0   Gpu  gfx803                        Yes        8.00 GB       8.00 GB      256.00 B

# After the update
$ nix run nixpkgs#ethminer-free -- --list-devices

ethminer 0.19.0
Build: linux/release/gnu

Error: No usable mining devices found

Looks like Polaris (gfx8) support was dropped in ROCm 4.5: https://www.reddit.com/r/hardware/comments/qr5q6z/rocm_45_drops_support_for_amd_polaris_gpus/

This is an upstream issue.


fix liddle typo

@gimler Hi, thanks fort the PR! However, the "falsey" is intentional term, meaning "values being casted to false". This is eg. false, 0, [], null etc., so not a typo :).


qq: 3.2.12-26740 -> 3.2.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for qq is: Messaging app
meta.homepage for qq is: https://im.qq.com/linuxqq/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.2.12 with grep in /nix/store/zq739kq7r26wphw7zc7qvkvb3l0xrgac-qq-3.2.12
found 3.2.12 in filename of file in /nix/store/zq739kq7r26wphw7zc7qvkvb3l0xrgac-qq-3.2.12

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

qq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zq739kq7r26wphw7zc7qvkvb3l0xrgac-qq-3.2.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A qq https://github.com/r-ryantm/nixpkgs/archive/f6fad2f068287e6354b6ef8c29bcb5fcc46c063b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f6fad2f068287e6354b6ef8c29bcb5fcc46c063b#qq

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zq739kq7r26wphw7zc7qvkvb3l0xrgac-qq-3.2.12
ls -la /nix/store/zq739kq7r26wphw7zc7qvkvb3l0xrgac-qq-3.2.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qq

Maintainer pings
cc @fee1-dead @Bot-wxt1221 for testing.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

Oh,no. We should backport manully.


Remix/SsrSite: allow cloudFrontFunctions custom injections for serverCfFunction & staticCfFunction

Hi
I wanted to add a CloudFront function for Remix, and looks like it's very difficult (the following issue from astro)
https://github.com/sst/ion/issues/663#issuecomment-2247069996
For Remix looks like there is code that internally accepts an array of string injections
https://github.com/sst/ion/blob/dev/platform/src/components/aws/remix.ts#L545
return validatePlan({
  edge,
  cloudFrontFunctions: {
    serverCfFunction: {
      injections: [useCloudFrontFunctionHostHeaderInjection()],
    },
    staticCfFunction: {
      injections: [
        `request.uri = request.uri.split('/').map(encodeURIComponent).join('/');`,
      ],
    },
  },

Would it make sense to expose this in RemixArgs?
Then it would be very simple to add custom logic into both the serverCfFunction and staticCfFunction?
Something like
export interface RemixArgs extends SsrSiteArgs {
  cloudFrontFunctions: {
    serverCfFunction: { injections: string[] },
    staticCfFunction: { injections: string[] }
  },
  ...
}

Thanks!

How would you want to use these injections btw? Can you give me an example?

Sure, this is say for home page personalization where the page is cached at the edge.
But based on a user cookie we can respond with a personalized homepage.
const personalizeHomePage = `
  var cookies = event.request.cookies;
  if(cookies.user && event.request.uri === "/") {
    request.querystring = "personalize=true";
  }
`

export default $config({
  async run() {
    new sst.aws.Remix("Web", {
      cloudFrontFunctions: {
        serverCfFunction: {
          injections: [ personalizeHomePage ]
        }
      }
    })
  },
});


Build issue - template for shortcode not found

Description
I have hugo extended install and trying to run the examplesite but getting the errors for all the short codes
FeelIt$ hugo version
hugo v0.84.4-020E4ACE+extended linux/amd64 BuildDate=2021-07-01T11:51:55Z VendorInfo=gohugoio
FeelIt$
FeelIt$ hugo serve --source=exampleSite
Start building sites …
hugo v0.84.4-020E4ACE+extended linux/amd64 BuildDate=2021-07-01T11:51:55Z VendorInfo=gohugoio
Built in 42 ms
Error: Error building site: "FeelIt/exampleSite/content/about/index.fr.md:12:1": failed to extract shortcode: template for shortcode "style" not found

Build Environment

OS: Ubuntu 20.04
Theme version: main branch latest commit
Hugo version: 84.4

Description
I have hugo extended install and trying to run the examplesite but getting the errors for all the short codes
FeelIt$ hugo version
hugo v0.84.4-020E4ACE+extended linux/amd64 BuildDate=2021-07-01T11:51:55Z VendorInfo=gohugoio
FeelIt$
FeelIt$ hugo serve --source=exampleSite
Start building sites …
hugo v0.84.4-020E4ACE+extended linux/amd64 BuildDate=2021-07-01T11:51:55Z VendorInfo=gohugoio
Built in 42 ms
Error: Error building site: "FeelIt/exampleSite/content/about/index.fr.md:12:1": failed to extract shortcode: template for shortcode "style" not found

Build Environment

OS: Ubuntu 20.04
Theme version: main branch latest commit
Hugo version: 84.4

Have you tried to follow "Getting Started" instruction?

I only did the npm run preinstall and was facing issues with other commands.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>babel: `npx babel src/js --out-file assets/js/theme.min.js --source-maps && npx babel src/js --out-file assets/js/themes.min.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>babel script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-07-02T08_44_29_386Z-debug.log

I thought that since these short codes are also present in Loveit and other forks which does not cause the issue then it should build without these documentation build
Excuse my knowledge on npm and its ecosystem

I only did the npm run preinstall and was facing issues with other commands.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>babel: `npx babel src/js --out-file assets/js/theme.min.js --source-maps && npx babel src/js --out-file assets/js/themes.min.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>babel script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-07-02T08_44_29_386Z-debug.log

I thought that since these short codes are also present in Loveit and other forks which does not cause the issue then it should build without these documentation build
Excuse my knowledge on npm and its ecosystem

Can you attach the log output?

Hi, I had the issue with the babel version and then I was installing it using -g. I installed it locally then the npm commands worked.
hugo server --source=exampleSite still does not work though.

Hi, I had the issue with the babel version and then I was installing it using -g. I installed it locally then the npm commands worked.
hugo server --source=exampleSite still does not work though.

Try this
npm run reinstall && npm run start-production


Authentication - System.NullReferenceException: 'Object reference not set to an instance of an object.'

Hi there, I have created a class which was made to pass back the authenticate then pass back the credentials so i could use them in the main code, however, im having issues just getting the code to authenticate. I have tried numerous methods and once authenticated i am getting a null responce even when trying to get a authenticated users name or screen name. At present im getting a System.NullReferenceException: 'Object reference not set to an instance of an object.', on the below code line as  var authenticateduser = User.GetAuthenticatedUser();:
`using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Net;
using System.Diagnostics;
using Tweetinvi.Models;
using System.Windows.Forms;
using Tweetinvi;
public static class TwitterAuthentication
{

public static string Authentication(string ck, string csk)
    {
        IAuthenticationContext _authContext;
        var appCredentials = new TwitterCredentials(ck, csk);
        _authContext = AuthFlow.InitAuthentication(appCredentials);

        using (var client = new WebClient())
        {
                using (var Stream = client.OpenRead("http://www.google.com"))
                {
                    Process.Start(_authContext.AuthorizationURL);

                    //open pin box and enter pin
                    SocialiFace.Twitter_Pin_Auth_Form Pin = new SocialiFace.Twitter_Pin_Auth_Form();
                    Pin.ShowDialog();
                    System.Console.WriteLine(Pin.Pin_Auth);
                    var userCredentials = AuthFlow.CreateCredentialsFromVerifierCode(Pin.Pin_Auth, _authContext);
                    Auth.SetCredentials(userCredentials);

                    try
                    {
                        var authenticateduser = User.GetAuthenticatedUser();
                        string handle = authenticateduser.Name;
                        return handle;
                    }
                    catch (Tweetinvi.Exceptions.TwitterNullCredentialsException)
                    {
                        MessageBox.Show("Error Authenticating");
                        return null;
                    }

                }
        }

    }

}

`

I have the same problem please let me know how to solve this.

I have just tried myself and everything works with the latest version of Tweetinvi.
Are you using version 4.0.1?
Thanks

@linvi yes i am using 4.0.1, however i notice in nuget manager 4,0,2, ill try to upgrade and see if that solves anything.

This code directly throws NullReferenceException on me with the latest version (4.0.3) of the library on NuGet:
  public class LoginModel : PageModel {
    private readonly IConfiguration config;

    public LoginModel(IConfiguration configuration) {
      this.config = configuration;
    }
    public void OnGet() {
      string consumerKey = config["Twitter:ConsumerKey"];
      string consumerSecret = config["Twitter:ConsumerSecret"];
      var credentials = new ConsumerCredentials(consumerKey,
        consumerSecret);
      string callbackUrl =
        $"{Request.Scheme}://{Request.Host}/Callback";
      var context = AuthFlow.InitAuthentication(credentials,
        callbackUrl); // this is where the exception is thrown
      Redirect(context.AuthorizationURL);
    }
  }

Exception details:
System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=Tweetinvi.Logic
  StackTrace:
   at Tweetinvi.Logic.Exceptions.WebExceptionInfoExtractor.GetTwitterExceptionInfosFromStream(Stream stream)

The contents of consumerKey and consumerSecret are correct.