webhook hangs at webserver "Received an unrecognised webhook"

Hello
hope I'm not overseeing something.
I setup the gateway without docker. After starting it, I'm getting a warning - which might be the problem - but I'm not sure:
2021-10-28 20:17:48.577.000      WARN   [bridge]                [-] POST http://<IP_ADDRESS>:8008/_matrix/client/r0/register (AS) HTTP 400 Error: "{\"errcode\":\"M_USER_IN_USE\",\"error\":\"User ID already taken.\"}"
I also took a look at the homeserver.log, unfortunately there's just the same error. So I'm unsure whether this is critical.
Webhook creation worked fine in Matrix, but if I want to send some test messages, e.g.
 curl -X POST <IP_ADDRESS>:8020/hook/xxxxx -H "Content-Type: application/json" -d '{"Test":"test"}'

I'm seeing this output and the hook is not being passed to the room:
2021-10-28 20:25:20.570.000      WARN   [webhook-srv]           Received an unrecognised webhook:
{
 Test: 'test'
}

Would be nice if you have some idea about that.
Thanks!

Here's a simple plugin that will format the above content into a Matrix message.
You can modify the username, icon, and text fields however you like. I don't have any documentation for the plugin API yet, but if you need help changing anything, feel free to ask.
import { assertType } from 'typescript-is';
import { PluginBase, WebhookMessage } from '../../src/pluginApi/v2';
import * as f from '../../src/formatting/formatting';

interface EmbyWebhook {
  movie: string;
  year: string;
  library: string;
};

export const format = 'emby';

export default class EmbyPlugin extends PluginBase {
  async init(): Promise<void> { }

  async transform(body: unknown): Promise<WebhookMessage | undefined> {
    const emby = assertType<EmbyWebhook>(body);
    return {
      username: 'Emby',
      icon: {
        url: 'https://emby.media/notificationicon.png'
      },
      text: f.fmt(
        'Movie ',
        f.quote(emby.movie),
        ' (',
        emby.year,
        ') added to library: ',
        emby.library
      ),
    };
  }
}

thank you very much!!!
I'll try it out asap

humm I think I'm currently a little slow. Would you mind taking a look here, as it is probably not an issue about your gateway.
just if you don't mind and have some minutes!
https://emby.media/community/index.php?/topic/86453-flexible-customisable-webhooks-with-emby-scripter-x/&tab=comments#comment-1071582

I forgot to mention, but you should postfix the webhook URL with the name of the plugin (in this cas,e emby). For example, if your webhook looks like this:
https://webhook.example.com/hook/bt05xpx7splnmw9t192rf5j3zx3i6jc6jnbvhrij
Then you should postfix it with /emby like  so:
https://webhook.example.com/hook/bt05xpx7splnmw9t192rf5j3zx3i6jc6jnbvhrij/emby
The webhook should also be dropped into your plugin directory. Any name is fine, as long as it ends with .ts.
If the plugin has loaded successfully, you will see the following message on startup:
2021-10-30 20:13:29.645  DEBUG [webhook-srv] Loading plugin emby.ts from <plugin hash>.js

thank you very much for taking the time troubleshoot my problem.
The things you suggested were unfortunately already true.
Here is a full output of the gateway log:
2021-10-31 17:34:35.500.000      INFO   [webhook-srv]           Matrix bridge running on <IP_ADDRESS>:8023
2021-10-31 17:34:35.528.000      WARN   [bridge]                [-] POST http://<IP_ADDRESS>:8008/_matrix/client/r0/register (AS) HTTP 400 Error: "{\"errcode\":\"M_USER_IN_USE\",\"error\":\"User ID already taken.\"}"
2021-10-31 17:34:35.602.000      INFO   [webhook-srv]           Loaded plugins: emby
2021-10-31 17:34:35.605.000      INFO   [webhook-srv]           Web server running on <IP_ADDRESS>:8020
2021-10-31 17:35:01.737.000      WARN   [bridge]                [-] POST http://<IP_ADDRESS>:8008/_matrix/client/r0/register (AS) HTTP 400 Error: "{\"errcode\":\"M_USER_IN_USE\",\"error\":\"User ID already taken.\"}"
2021-10-31 17:35:02.199.000      ERROR  [webhook-srv]           Failed to handle webhook invocation:
 Error  Cannot read properties of undefined (reading 'formatPlain')
error stack:
• formatting.ts:26 toPlain
    src/formatting/formatting.ts:26:24

• formatting.ts:231 formatPlain
    src/formatting/formatting.ts:231:23

• formatting.ts:26 toPlain
    src/formatting/formatting.ts:26:25

• formatting.ts:36 formatPlain
    src/formatting/formatting.ts:36:30

• formatting.ts:26 toPlain
    src/formatting/formatting.ts:26:25

• MatrixBridge.ts:53 <anonymous>
    src/bridge/MatrixBridge.ts:53:19

• MatrixBridge.js:27 <anonymous>
    src/bridge/MatrixBridge.js:27:71

This is the test curl I'm using:
curl -X POST <IP_ADDRESS>:8020/hook/xxxxx/emby -H "Content-Type: application/json" -d '{"movie":"Testfilm","year":"1999","library":"aktuelle Filme"}'

You're welcome! Unfortunately I can't reproduce the issue locally, but I suspect that something is going wrong with reading the webhook POST content, because it does try to format the data.
Could you modify the plugin like so, and let me know what it logs?
import { assertType } from 'typescript-is';
import { PluginBase, WebhookMessage } from '../../src/pluginApi/v2';
import * as f from '../../src/formatting/formatting';
import logger from '../../src/util/logger';

interface EmbyWebhook {
  movie: string;
  year: string;
  library: string;
}

export const format = 'emby';

export default class EmbyPlugin extends PluginBase {
  async init(): Promise<void> {}

  async transform(body: unknown): Promise<WebhookMessage | undefined> {
    logger.info('Request body: ', body);
    const emby = assertType<EmbyWebhook>(body);
    return {
      username: 'Emby',
      icon: {
        url: 'https://emby.media/notificationicon.png',
      },
      text: f.fmt(
        'Movie ',
        f.quote(emby.movie),
        ' (',
        emby.year,
        ') added to library: ',
        emby.library,
      ),
    };
  }
}

@horstepipe I've created a emby.ts plugin:
import { is } from 'typescript-is';
import { PluginBase, WebhookMessage } from '../../src/pluginApi/v2';
import {
    a,
    strong,
    fmt,
} from '../../src/formatting/formatting';

type movie = {
    movie: string;
    year: string;
    imdb: string;
    library: string;
};
type series = {
    series: string;
    imdb: string;
    library: string;
};
type season = {
    season: string;
    series: string;
    imdb: string;
};

export const format = 'emby';

export default class EmbyPlugin extends PluginBase {
  // This function will be executed once, on startup.
  async init(): Promise<void> {
    this.logger.info('emby plugin starting up');
  }

  // This function will be executed every time a webhook with a matching
  // format is posted. It should either return a `WebhookMessage`, if the
  // webhook is to be executed, or `undefined`, if the webhook is to be
  // rejected.
  async transform(body: unknown): Promise<WebhookMessage | undefined> {
    // You can make use of 'typescript-is' to perform runtime type checks on
    // input data. This makes it easy to reject invalid webhooks.
    if (is<movie>(body)) {
        var link = 'https://www.imdb.com/title/' + body.imdb;
        var titel = body.movie + ' (' + body.year + ')';
        return {
            // username: 'Emby Bot',
            text: fmt(
                'The Movie ',
                strong(a(link,titel)),
                ' was added to the ',
                body.library,
                ' library',
            ),
          };
    }
    if (is<series>(body)) {
        var link = 'https://www.imdb.com/title/' + body.imdb;
        return {
            // username: 'Emby Bot',
            text: fmt(
                'The Series ',
                strong(a(link,body.series)),
                ' was added to the ',
                body.library,
                ' library',
            ),
          };
    }
    if ((is<season>(body) {
        var link = 'https://www.imdb.com/title/' + body.imdb;
        return {
            // username: 'Emby Bot',
            text: fmt(
                'Season ',
                body.season,
                ' was added to ',
                strong(a(link,body.series)),
            ),
          };

    } else {
        this.logger.warn('Invalid webhook');
        this.logger.warn(body);
        return undefined;
    }
  }
}

webhook.sh shell script for sending webhooks:
#!/bin/bash

# Variables
imdb_pattern='^tt[0-9]*$'
webhook_url='https://webhook.domain.com/hook/pvp***f53'

webhook() {
    curl -X POST "$webhook_url/emby" -H "Content-Type: application/json" -d "$1"
}

if [[ $1 == Movie ]] && [[ "$4" =~ $imdb_pattern ]]; then
    # Check if item.type is Movie and item.meta.imdb is set
    webhook "{\"movie\":\"$2\",\"year\":\"$3\",\"imdb\":\"$4\",\"library\":\"$5\"}"
elif [[ $1 == Series ]] && [[ "$3" =~ $imdb_pattern ]]; then
    # Check if item.type is Series and item.meta.imdb is set
    webhook "{\"series\":\"$2\",\"imdb\":\"$3\",\"library\":\"$4\"}"
elif [[ $1 == Season ]] && [[ "$4" =~ $imdb_pattern ]]; then
    # Check if item.type is Season and item.meta.imdb is set
    webhook "{\"season\":\"$2\",\"series\":\"$3\",\"imdb\":\"$4\"}"
fi

example parameters:
bash webhook.sh "Movie" "Django Unchained" "2012" "tt1853728" "My Movies"
bash webhook.sh "Series" "Squid Game" "tt10919420" "My Series"
bash webhook.sh "Season" "1" "Squid Game" "tt10919420"

give example messages:

@geluk any advices for my emby.ts plugin?

@Dual-0 Once the next version of the webhook gateway comes out, there will be a few more formatting functions to further simplify the text formatting that you're doing here, but other than that I don't have any significant feedback. What you're showing here is exactly what I hoped people would be able to do, which is to create their own plugins tailored to their own use cases, so I'm happy to see that it's working.
There's one thing I'll clarify; you can either use type or interface for your type definitions. For the purposes of making webhook plugins, there are no real differences between these two, so use whatever you like. It is conventional to use uppercase names for types to distinguish them from variables, but as long as you can read the code, that doesn't really matter here.
Lastly, I'd be interested in hearing about your experiences writing the plugin. Did you run into any issues? Was there anything in the process that's unclear or could be made more ergonomic? If you have any feedback here, I'll use that to improve the process for future users.

thank you very much dual-o for sharing!
Unfortunately, i'm still getting the same error.
I guess I need to try the docker installation as it is more up to date than the normal installation.

@horstepipe The Docker version has a :dev tag which tracks the latest development version. I don't currently have a way of automatically distributing the latest version of the normal version, but I've uploaded a recent build here: http://geluk.io/public/dl/webhook-gateway-b2f5eda.tar.gz

@horstepipe: I use it without docker. just the "latest" tagged release + node + pgsql.
my systemd file:
[Unit]
Description=matrix-webhook-gateway daemon
PartOf=matrix-synapse.service
Requires=matrix-synapse.service
After=matrix-synapse.service

[Service]
Type=simple
WorkingDirectory= /opt/webhook-gateway
ExecStart=node entry.js -c "/opt/webhook-gateway/gateway-config.yaml" -a "/etc/matrix-synapse/appservices/appservice-webhook-gateway.yaml"
RestartSec=20
Restart=always

[Install]
WantedBy=matrix-synapse.service

@horstepipe: I use it without docker. just the "latest" tagged release + node + pgsql. my systemd file:
[Unit]
Description=matrix-webhook-gateway daemon
PartOf=matrix-synapse.service
Requires=matrix-synapse.service
After=matrix-synapse.service

[Service]
Type=simple
WorkingDirectory= /opt/webhook-gateway
ExecStart=node entry.js -c "/opt/webhook-gateway/gateway-config.yaml" -a "/etc/matrix-synapse/appservices/appservice-webhook-gateway.yaml"
RestartSec=20
Restart=always

[Install]
WantedBy=matrix-synapse.service

thanks.
okay if it also works via non docker for you, something else seems to go wrong here. I'll reinstall and reconfigure the whole thing and see if this helps.

which node version are you running?
I do 16.13.0

another thing, from your config it looks like the webhook is on an external server? Here it is the same server. Is there anything which could be problematic about that?

okay forget it.
IT IS WORKING NOW, yeha! :-)
I deleted the __cache and __workdir directories at the plugins folders, now it works as intended.
Thank you very very much to you guys for helping me setting this up!


end of life for v6

Description

To be merged after December 9th.
closes: #XXXX
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

I think we can simplify the memo e2e logic now
https://github.com/cosmos/ibc-go/blob/6f2493fb5449443ffe14286b37d2105c3075deda/e2e/testvalues/values.go#L75

I removed the code related to check the version for this: https://github.com/cosmos/ibc-go/pull/5341/commits/2a366d01c59614c6b8623d22b57c69d98406a537


Is there way to resize boxes?

Hi,
Is there way to resize boxes?
BTW great job!

Thank you. All of them or a particular box in mind?

Hi, Drag&drop box,
Thanks

Added.. Try to use cX & cY parameters.
    Dim FilePaths As String
    FilePaths = gDll.DLL.ShowDialogForFile("No multiple files allowed", False, CX:=820, CY:=364)

Thanks!


docs building points to wrong local URL

https://github.com/keptn/lifecycle-toolkit/blob/main/docs/content/en/contribute/docs/local-building/index.md states that docs are available on http://localhost:1314/docs-dev - they're not. They're available on http://localhost:1314.
The index.md needs to be updated to remove that /docs-dev.

Thanks for the PR. Closing as this is now resolved and merged.


Notify the user when not calling super

As I've been playing around with the Polymer 2.0 preview, something has thrown me off multiple times. I forgot to call super.ready() in the ready callback, and I think I did the same in the connectedCallback. In each case I had no idea what has happening, and it took a while to figure it out. Is there any way to indicate to the user when they have not called super?

Definitely needs to be added to the linter tool. Closing this issue as a duplicate of #4412.


Semantic Segmentation Lane Markings not Showing Up

Issue Description
I recently started working with Beamng.tech and BeamNGpy for an academic demonstration with behavior cloning and autonomous vehicles. I started to implement the Camera sensor and was wondering if it's possible to extract lane markings from the semantic segmentation output. I noticed that lane annotation colors are present in the JSON file (e.g., SOLID_LINE, etc), but I can't seem to get them to appear on the output of the Camera sensor.
It appears, however, that lane markings are visible in the demonstration in the README. I'm not sure if this is due to a setting or parameter I'm missing. I'd appreciate any help in getting the lane markings to appear as it'll help in training my model on a simplified view of the world for testing purposes.

Versions
Beamng.tech: 0.31
BeamNGpy: 1.28
OS: Windows 10 Enterprise

@prestonbarnett I am also interested in this issue.

@aivora-beamng I also have the problem that procedurally generated roads show up just black. Lane marking also shows up just black (or they do not show up at all). See picture:

Could it be that the material I use is not valid?
FYI: I create roads using the track_editor_C_center material and the lane markings using: line_yellow, line_dashed_short_yellow, line_white, and line_dashed_short
See picture:

@aivora-beamng Is it possible that Roads objects do not have a way to set the ObjectAnnotation field that one can see from the World Editor? Sadly, I cannot find any existing level where this attribute is set.

Quick update: I patched prefab.json and hardcoded the STREET annotation to all the (Decal) Roads. I can see in the World editor that the label/annotation is the correct one (the color is RED); unfortunately, the annotation and instance cameras always produce the wrong image (see post above).

If I put a vehicle in front of the camera I got the following result:

The road is still Black, but the vehicle is visible.

Since we at it, running the code https://github.com/BeamNG/BeamNGpy/blob/master/examples/annotation_bounding_boxes.ipynb produces the expected result  (cannot say anything about the lane markings, tho)

I executed the same code on the Italy map using scenario.add_vehicle(ego, pos=(91, 53, 39), rot_quat=(0.0173, -0.0019, -0.6354, 0.7720)) to place the vehicle. The grey area that corresponds to the asphalt is there, but no lane marking. See picture.

One confusing thing is that the World editor says that none of the corresponding roads have any annotation attached to it...

@aivora-beamng A quick update. I tried the code using the template_tech level (with and without road_insible and after removing the annoying grass field). I changed the zorder and also manually set the annotations in the world editor, but the result is now that instead of an all green image (like the one above) I got an all black image.

Hi @alessiogambi, sorry for the confusion, the template_tech level is not the .tech level which is designed to work with the .tech tools. It is called Tech Ground (tech_ground), and it will be included as part of the 0.32 BeamNG.tech release. I tested it with the new Road Architect tool designed to create roads, and the annotations are behaving as expected, including the lane markings (we fixed this one for the upcoming release).

Sorry for the troubles caused, I think it will be best to wait for the release happening soon.

Hi @prestonbarnett, the lane markings are now available in BeamNG.tech 0.32 and BeamNGpy v1.29.
@alessiogambi Try to use the new Tech Ground level released with BeamNG.tech 0.32 today, the annotations should be working much better than on smallgrid.

@aivora-beamng As far as I can see, the annotations are working now. (see pictures below).
Note: I updated the tech_ground level because the material I needed (from the west_coast) where missing.

If is issue is resolved, we can close this ticket. Thank you for the feedback @alessiogambi @prestonbarnett


Restrict migrations to running only on master

So, exact bug reproduction scenario is thw following:

some time-consuming ddl-changing migration is added in production (e. g. changing space format on an empty space)
admin triggers migrator.up on a replica node (let's call is coordinator)
coordinator triggers migrations on all replicaset leaders (including  leader of its own replicaset)
all leaders apply migrations and respond 'ok' to coordinator
space format change is sent to coordinator from its leader via replication channel, and it takes considerable time to apply, so coordinator's actual ddl remains unchanged for some time
upon receiving 'ok's from all leaders, coordinator triggers config.patch_clusterwide with supposedly new ddl schema, which it collects from local spaces
BUT since schema is not yet changed on coordinator itself (since coordinator is async lagging replica), it tries to apply "old" ddl, and fails total operation with smth like CheckSchemaError: Incompatible schema: spaces["somespace"] //format/3 (expected table, got nil)

Just checking of box.info.ro is okay? Should this behaviour work under an option or by default?

Proposed fix (in linked PR) is that coordinator should fetch ddl schema from a master, instead of colleting it locally.


ReferenceError: Can't find variable: exports - karma

I'm getting this error when I am running my tests.  I am using [angular2-seed] (https://github.com/mgechev/angular2-seed).
When running npm test I was initially getting: 404: /base/angular2-toaster/angular2-toaster.js
That issue was easily fixed by adding 'node_modules/angular2-toaster/angular2-toaster.js' to my karma.conf.js file.
After adding that, I began getting the error ReferenceError: Can't find variable: exports

Are you loading `'node_modules/traceur/bin/traceur-runtime.js', // Required by PhantomJS2, otherwise it shouts ReferenceError: Can't find variable: require' before attempting to load angular2-toaster?  Also, are you mapping it at all in your systemjs configuration?

Yes I am doing both of those... my suspicion is that maybe my mapping is wrong. I'll play around with that some more.

here is my System.config in my test.main.js
System.config({
  baseURL: '/base/',
  defaultJSExtensions: true,
  paths: {
    'angular2/*': 'node_modules/angular2/*.js',
    'rxjs/*': 'node_modules/rxjs/*.js'
  },
  map: {
    'angular2-toaster': 'node_modules/angular2-toaster'
  }
});

That looks right doesn't it?

Yes, the mapping looks correct.
In hindsight, I do remember having a lot of issues implementing the karma test runner.  Note that the https://github.com/Stabzs/Angular2-Toaster/blob/master/karma-test-shim.js used is a bit different from what is used in the seed.  If you follow it, something like
Promise.all([
    System.import('angular2/src/platform/browser/browser_adapter'),
    System.import('angular2/platform/testing/browser'),
    System.import('angular2/testing')
    System.import('angular2-toaster')
]).

might be necessary.

I haven't verified loading order yet.  Your suspicion sounds reasonable though. I'll take a look into that.

If there's anything I can do to help track it down, please feel free to let me know :)

@Stabzs I got things working.... not super happy about what I ended up with, tho, I will post again tonight with more details

to get my tests running, I had to add
{ pattern: 'node_modules/angular2-toaster/angular2-toaster.js', included: false },
{ pattern: 'node_modules/angular2-toaster/lib/*.js', included: false },

to the files section of my karma configuration file.
Then, in test-main.js I had to modify System.config to add path for angular2-toastr and map it.
System.config({
  baseURL: '/base/',
  defaultJSExtensions: true,
  paths: {
    'angular2/*': 'node_modules/angular2/*.js',
    'rxjs/*': 'node_modules/rxjs/*.js',
    'angular2-toaster/*': 'node_modules/angular2-toaster/lib/*.js'
  },
  map: {
    'angular2-toaster': 'node_modules/angular2-toaster'
  }
});

Then in the same file, I had to import it using System.import
Promise.all([
  System.import('angular2/src/platform/browser/browser_adapter'),
  System.import('angular2/platform/testing/browser'),
  System.import('angular2/testing'),
  System.import('angular2-toaster/angular2-toaster')
])

Thanks for the details and perseverance on this issue.
I'm not certain if there's a better way to structure this or if the library could make this type of testing easier. I'm open to suggestions but I'll be closing the issue for now since I don't think it's necessarily something the library is doing incorrectly.


Extend command "cf login" with  "--origin"

Please provide details on the following items. Failure to do so may result in deletion of your feature request.
The UAA allows the login with multiple origins (e.g. uaa, ldap, someSamlProvider, someOidcProvider). The command "cf auth" already provides the parameter "--origin" with which the user can specify it for login. However, this parameter is missing for command "cf login".
What's the user value of this feature request?
The only way to login with an origin (that is not the UAA default) is currently:

cf api ...
cf auth --origin uaa user password
cf target ...
This means that three commands instead of one command are necessary. Further, the user needs to enter the password unprotected to the console.

Who is the functionality for?
Everybody who uses multiple origins for login to the UAA.
How often will this functionality be used by the user?
Every time a user does a login.
Who else is affected by the change?
No breaking change.
Is your feature request related to a problem? Please describe.
Yes, the user in annoyed to type his password unprotected to the console. Further, it is not acceptable for users from my point of view with regards to security.
Describe the solution you'd like
Extend command "cf login" with  "--origin"
Describe alternatives you've considered
Command "cf auth" with "--origin" that has severe shortcomings as mentioned above.

See related: https://github.com/cloudfoundry/cli/issues/1272


License File missing

Hi @zeke, it would be great if you could add the LICENSE file with the correct copyright for ISC license (the ISC license is mentioned in the README).
It would make it simpler for other developers to use/extend your library in a proper way.

Thanks, @devenbansod. Pull requests welcome!

Hi @zeke I could do it, but I would surely prefer you add it with your correct copyright mentions.
You can take a look here on how to simply add the LICENSE (or LICENSE.txt) file to the repository.

I change the license to MIT, add a LICENSE fiel and published a new major version to reflect the change of license.
❯ np major
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies
 ✔ Running tests
 ✔ Bumping version
 ✔ Publishing package
 ✔ Pushing tags

 lets-get-meta 2.0.0 published 🎉

Thanks a lot @zeke . I just made a PR at #3 to fix the LICENSE name in README too.


Add support for running a single LSP server that has multi-workspace support

When Swift 5.7 is released it will include a version of SourceKit-LSP which include multi-workspace support. This will allow us to run a single server and add and remove workspace folders to it when they are added/removed to the VSCode workspace. This is an alternative to what we have now where the server is restarted every time we focus on a new workspace folder.
This PR keeps the original restart solution as it is needed for Swift 5.6 and earlier, but will use the single server solution if the version of Swift is 5.7 or later.

@swift-server-bot test this please


Adds VectorValueExt

Signed-off-by: Breezewish<EMAIL_ADDRESS>
What have you changed? (mandatory)
VectorValueExt provides a generic way to push values into a VectorValue.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
No.

No need any more because https://github.com/tikv/tikv/pull/4533 is merged.


Text selection issue

I have a problem with selections in CodeMirror textarea.
When I press Ctrl+A (basically select all operation) on CodeMirror textarea, it selects text with the spaces. These spaces creating according to longest line in textarea. If you didn't understand what I mean, here is the picture:
What it looks like

It shouldn't include these parts

So it has to be a thing similar to this

I was thinking to change CodeMirror to somethink else but I thinked I must create a issue before it.

That's just how CodeMirror (and many other text editors) draw the selection. There are no spaces, it just indicates that the selection continues on the next line that way. This isn't going to change.

Is there no way to change this with manupilating CSS or Javascript? Because a library named Monaco Editor can do what I want bu I still want to use it with CodeMirror.

You could hide the editor's own selection with .CodeMirror-selected { background: none !important }, and use the mark-selection addon to give the selected text a class that you can style yourself.

Works like a charm! Thank you.


Workaround for build problems with npm run

Had 3 problems running npm run dev/hot/watch/prod on my local machine, using:
node 8.11.2
npm 6.0.1

Missing webpack-cli
After installing webpack-cli, was not able to build due to error  TypeError: dep.getResourceIdentifier is not a function.
After downgrading webpack, got this error: vue-loader v15 requires VueLoaderPlugin in webpack config

Don't know if this is the correct aproach, but I tested and the initial project is working correctly. Got on a rabbit hole chase trying to figure this out.
Seems like some compatibility problems between new version of webpack and laravel mix, and also some problems with vue-loader with webpack as well.
Here's the issues where I found the solutions:
https://github.com/webpack/webpack/issues/6675
https://github.com/rails/webpacker/issues/1453
Now to the how to:

Install webpack-cli
npm install webpack-cli -D
Downgrade webpack
npm install<EMAIL_ADDRESS>-D
Install downgraded version of vue loader
npm install<EMAIL_ADDRESS>After that I deleted node_modules folder and cleared the cache with
npm cache clean --force
run npm install
try running npm run dev.

Thanks, worked perfectly using yarn to install the dependencies, after that used npm to run the build scripts without problem!


Fix kenlm github path

Old github path is no more valid. Use another one.
Signed-off-by: Viraj Karandikar<EMAIL_ADDRESS>

duplicate of https://github.com/NVIDIA/OpenSeq2Seq/pull/544
closing.

other MR merged for fixing same issue. closing.


tripleee: Blacklist contactforhelp.com

tripleee requests blacklist of domains:

contactforhelp.com

It will be easier to re-blacklist this via chat than it would be to fix the conflict.


Sequential call causes wrong .js path

Actual Behavior
We see calls to the .js files being requested on sub directories and api endpoints. When using a browser, this doesn't seem to happen, bot search engines or other bots can cause this.
Expected Behavior
The .js files exist on the root, so should always be called on root.
Steps to Reproduce the Bug
Steps to reproduce the behavior:

Checkout intershop-pwa
Build the site with docker with the default ICM_BASE_URL
Open the site via localhost, e.g. http://localhost:4300
Open one of the demo pages, e.g. http://localhost:4300/Acer/Acer-ICONIA-W500P-%2B-Keydock-sku10957684-catComputers.897.897_Acer?view=grid
Hit refresh several times. The log in the console should be 'normal' and contain .js files like
GET /main.0e80287f29ca0cba7f99.js 200 330820 - 3.958 ms
Next use a tool like siege to call the same URL.
 We'll have a look

@jometzner Let me have a look at this, as this correlates with a feature we need for our project.
@127001 Thanks for showcasing siege, I did not know this tool before. Really neat 👍

@dhhyi sure go ahead. Thanks for letting us know.

@127001 #629 can be used as a work-around, but if you can, wait for #630 which I will continue when I have time 😉

Thanks!


[fpga] ChipWhisperer CW310 follow-up tasks

#6614 adds initial support for the ChipWhisperer CW310 board with Xilinx Kintex 7 XC7K410T FPGA. When doing the PR and during the review process, a couple of follow-up items got identified:
Tooling:

~[ ] Investigate adding support for SPI Flashing over SAM3X/U to sw/host/spiflash, see https://github.com/lowRISC/opentitan/pull/6614#discussion_r637067566~ This could theoretically be done but we dropped support for NexysVideo and kept using cw310_loader.py for the ChipWhisperer boards. In the meantime, opentitantool is used for bootstrapping FPGA. Once opentitantool has the ability to also prep VMEM images for bootstrapping in DV sim, spiflash might get removed. See https://github.com/lowRISC/opentitan/pull/12821#issuecomment-1135453310
~[ ] Investigate adding support for bitstream flashing over SAM3X/U to opentitan-pgm-fpga~ This could theoretically be done by leveraging the FTDI MPSEE interface emulation of the SAM3X/U. However, there are some restrictions on what FPGA pins can be made available to the FTDI MPSEE interface by default. Some of them can be dynamically switched through Python. See https://github.com/lowRISC/opentitan/pull/12633#discussion_r879539230 for details. In the end, we didn't have a strong need for this so far and kept using cw310_loader.py instead. In the meantime, we dropped support for NexysVideo and opentitan-pgm-fpga got removed with #12821.
[x] Investigate reducing additional Python dependencies such as numpy, scipy introduced through the ChipWhisperer Python API, see https://github.com/lowRISC/opentitan/pull/6614#issuecomment-844323063 , see #12832
[x] Investigate installing the ChipWhisperer Python API not in editable mode
[x] #8739

Hardware:

[x] Enable SCA support: need to feed target clock, high-precision trigger signal and UART to the scope board via 20-pin ChipWhisperer connector, see #7513
[x] Disable the use of hw/top_earlgrey/util/top_earlgrey_reduce.py. See lowRISC/OpenTitan#7369
[x] Decide on the future of NexysVideo support.
~[ ] Enable support for the smaller ChipWhisperer CW310 board with Xilinx Kintex 7 XC7K160T FPGA?~ We are not going to do this for now as it's not clear whether supporting yet another, non-complete FPGA configuration is really worth the effort. We keep supporting the CW305 as we already have quite a few boards of that sort and there is a benefit in terms of noise for power SCA.

On reducing numpy and scipy:
I think numpy gets used for some binary list conversion in the CW310 board interface would be the only hit. SciPy should be avoidable. It's listed as a dependency for ChipWhisperer as it will break some of the SCA algorithms, which for most users is important. Longer-term we could add a separate 'chipwhisperer-api' or similar module release which is built from the same code-base but removes the dependency, or if the CW310 API is stable the relevant files could be moved to OT (we have the copyright so this can be done cleanly w/o messing up the copyright notices).

Closing, as all tasks have been completed.


Update Jenkinsfile

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Hi @hubchai , please do not open a Pull Request on someone else repository without filling properly an issue explaining the problem you want to solve and a discussion.
I'm closing this PR as it does not have any change (empty commit) and it sounds like a mistake (did you intend to open a PR on your own repository?).

sorry it was by mistake
On Fri, Feb 23, 2024 at 2:10 PM Damien Duportal @.***>
wrote:

Hi @hubchai https://github.com/hubchai , please do not open a Pull
Request on someone else repository without filling properly an issue
explaining the problem you want to solve and a discussion.
I'm closing this PR as it does not have any change (empty commit) and it
sounds like a mistake (did you intend to open a PR on your own repository?).
—
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/docker/pull/1832#issuecomment-1960926917,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7EVD4KPYYHWG4IWTWSHHE3YVBIZJAVCNFSM6AAAAABDWB57PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQHEZDMOJRG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Memory integrity

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9f784502-84dc-1122-eab4-1eeeb08da046
Version Independent ID: 21f210a7-4c38-8f62-0226-121562617fef
Content: Memory integrity - Windows security
Content Source: windows/security/threat-protection/device-guard/memory-integrity.md
Product: m365-security
Technology: mde
GitHub Login: @levinec
Microsoft Alias: ellevin

@jordanclic . No description of the issue.

Hi @jordanclic, can you please describe the issue that you are facing with the document. Please note that the issues section of the repository is intended for corrections in technical documentation.

@jordanclic We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific content change you can suggest to improve the docs. Thank you.


Can't create ProjectMembership

Hello, I'm having trouble project membership in selected project.
My code
ProjectMembership newmem = new ProjectMembership
{
User = new IdentifiableName { Name = "Marcin Sporysz"},
Roles = new List { new MembershipRole { Id = 7 } },
Project = new IdentifiableName { Id = 788 },
};
manager.CreateObject(newmem, "pt1");
I'm getting an exception

Redmine.Net.Api.RedmineException: CreateObject has invalid or missing attribute parameters: Base can not be empty (i'm translating this message, so english version may not be exact)

Can you please assist me?

Hello,
You should use user id and not user name
ProjectMembership newmem = new ProjectMembership
{
User = new IdentifiableName { Id =  <the id of "Marcin Sporysz">},
....

Oh, that did the trick. Thank you!

you are welcome.


add a templating mechanism

add a templating mechanism, to support some variables, and lower the input requirement :
actually, you need to provide an HttpRequest Object.

already implemented with JEXL HttpRequestMapper


Regions and languages as maps

What do you think?
The ergonomics of using this through toObject isn't particularly different in the frontend; on the backend it's a bit nicer.
The other thing that I have in mind is that I'm not sure what we'll do with this once we do translations, but I don't know what we're doing the other way either... We can cross that bridge when we get there.

Okay, I've no clue what those type signatures are in typescript... Maybe some frontend person wants to have a look.

It is a bit ugly to get a non-deterministic wire format, but it is indeed shorter code on the backend side. I'm indifferent... you can decide :)

I would probably favour the other one; but I'm pretty indifferent. Let's see what frontend people think!

I don't think this will make much of a difference for frontend. The type of languagesMap and regionsMap still seems to be an array of tuples instead of a map/dictionary so we still have to convert it to a map object. (Luckily this is cached with react-query so it's only done once per user session).
I don't mind this to be merged, but I don't think it's what @darrenvong meant with his comment.

@thdk I believe if you change the service function getLanguages to not call toObject(), you will be able to use it like a map with get etc.

Yeah, this only changed how we destructure things in the reduce which is no better than what we had for the frontend.
I was thinking the languages and languagesLookup object/map can be returned directly from the backend rather than having to build it on the frontend... will this be possible now with this map type?

We can’t return a bidirectional map through protobuf. We could do a map, but underneath it’s the same thing, and since we’re using AsObject, this is basically adding nothing.
I propose we close this and go with what’s in the main PR.

On 1 Jun 2021, at 18:48, Darren Vong @.***> wrote:

Yeah, this only changed how we destructure things in the reduce which is no better than what we had for the frontend.
I was thinking the languages and languagesLookup object/map can be returned directly from the backend rather than having to build it on the frontend... will this be possible now with this map type?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Why don't we not use toObject?

Why don't we not use toObject?

I don't mind if we did. Let me update this PR to do that and see how it looks.

Actually, I spoke too soon. I don't think there's a way to grab the map as a dictionary even if not using AsObject

What about this? https://github.com/protocolbuffers/protobuf/blob/bd42fcc7a3e04504df895ce2fd0782c0e84b68a5/js/map.js#L391

Yeah the jsonb.Map thing looks promising, then all we need is the backend to do the reverse map computation and return that as a separate map object?

We can't have the backend return both the forward and the backward map. It's better to return pairs and reconstruct in the frontend.

Just posting in case you weren't aware but I also saw that instead of toObject(), we can call getRegionsMap() and getLanguagesMap() that returns an object of that jrcp.Map type.
But if backend only returns a single map, we still need to loop each item to create the reverse/lookup map.

I just had a quick play around with the language map thing, for some reason the getOptionLabel doesn't work and using the map crashes the app when you go straight to /user/edit since it doesn't create the jsonb.Map object consistently for some very strange reasons. Maybe this is not worth it if we have to re-map things on the frontend...

We can't have the backend return both the forward and the backward map. It's better to return pairs and reconstruct in the frontend.

Why's that? Is it a protobuf limitation or are you just trying to avoid doing extra computation on the backend?

We can't have the backend return both the forward and the backward map. It's better to return pairs and reconstruct in the frontend.

Why's that? Is it a protobuf limitation or are you just trying to avoid doing extra computation on the backend?

It is just very silly to send the same thing twice over the network.

We can't have the backend return both the forward and the backward map. It's better to return pairs and reconstruct in the frontend.

Why's that? Is it a protobuf limitation or are you just trying to avoid doing extra computation on the backend?

It is just very silly to send the same data twice over the network.

Ok that's a fair point. Still, this feels unsatisfactory as we have to build this up again twice in the frontend. Maybe if we restructure the json/object returned to be more like {"abk": "Abkhazian, ...} etc, then at least the frontend only has to do the work once to build the reverse map. But maybe that should be resolved in a separate issue...

I just had a quick play around with the language map thing, for some reason the getOptionLabel doesn't work and using the map crashes the app

@darrenvong can you push your code, I want to try

Lol shouldn't have deleted the code... but I think I managed to stitch back together what I had so maybe you'll find something I overlooked 🤷
Only did it for languages but should be enough to figure out why this wouldn't work...

Maybe if we restructure the json/object returned to be more like {"abk": "Abkhazian", ...} etc

After more thoughts, never mind, as I'm not sure this is possible since the data is semi dynamic? If we do this, we'd basically have to write all the languages field in the proto contract? That sounds like a terrible idea to me just as I suggested sending the map over twice as we're now duplicating the data in the proto and the resource file. I guess this kind of "JavaScript optimal" structure is not really feasible with a statically typed schema and perhaps what we got is the best at the moment.

@lucaslcode Pushed the code. Feel free to take a look when you have some time. CI failed because I changed the languages hook but the preview built fine so at least you can see the user profile is completely f**ked since I added "English" to the test user because:

it doesn't create the jsonb.Map object consistently for some very strange reasons.

Figured it out. Maps are not json serializable, so it was being stored as an empty object in the query cache.
The last commit seems to be all working - however persistence is commented out. I'm sure there's a way to add custom serialization for a Map.

Ahh nice find! I think we'd have to create a custom persistor on top of the default one for this to work probably

Are we happy to close this?

Yeah maybe make a low priority issue out of this, as a custom persistor will need a bit of work (probably not too difficult, but not exactly trivial either) and there are probably more important issues to work on first... 😅


[AIRFLOW-2407] import logging for line 70 of qubole_sensor.py

flake8 testing of https://github.com/apache/incubator-airflow on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./airflow/contrib/sensors/qubole_sensor.py:68:13: F821 undefined name 'logging'
            logging.exception(e)
            ^

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
See above.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
This PR fixes flake8 tests that are currently failing.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[X] Passes git diff upstream/master -u -- "*.py" | python3 -m flake8 --diff

Please don't import logging, but use this.log.

LOL...  this is an undefined name...
flake8 testing of https://github.com/apache/incubator-airflow on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./airflow/contrib/sensors/qubole_sensor.py:62:9: F821 undefined name 'this'
        this.log.info('Poking: %s', self.data)
        ^
./airflow/contrib/sensors/qubole_sensor.py:68:13: F821 undefined name 'logging'
            logging.exception(e)
            ^
./airflow/contrib/sensors/qubole_sensor.py:71:9: F821 undefined name 'this'
        this.log.info('Status of this Poke: %s', status)
        ^

Codecov Report

Merging #3297 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   75.87%   75.89%   +0.02%
==========================================
  Files         197      197
  Lines       14706    14706
==========================================
+ Hits        11158    11161       +3
+ Misses       3548     3545       -3

Impacted Files
Coverage Δ

airflow/jobs.py
82.83% <0%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ab796...f30a654. Read the comment docs.

@cclauss Please can you create a single Pull Request for [AIRFLOW-2407] JIRA instead of separate PR as below:
https://github.com/apache/incubator-airflow/pull/3293
https://github.com/apache/incubator-airflow/pull/3294
https://github.com/apache/incubator-airflow/pull/3296
https://github.com/apache/incubator-airflow/pull/3297
https://github.com/apache/incubator-airflow/pull/3298
https://github.com/apache/incubator-airflow/pull/3299
?

https://github.com/apache/incubator-airflow/pull/3294#issuecomment-386159118

Closed in favor of #3307


WIP: [LEVWEB-792] Use Oracle as the source database

This is probably a more typical use-case and allows us to side-step what
appears to be a bug in the MySQL support.
The downside is that the Oracle image is ugly and listens on it's port
before it is actually ready to accept connections, requiring us to sleep
for a certain time to allow for this.

This still needs testing which is why it's just a WIP. - I ran out of time last night.
I'm not sure it's a good idea because of the need to sleep.

I'm not to fussed about what the source database as it is SymmetricDS responsibility to support them. We really just need to prove the concept.
Arguably, we should have multiple docker-compose to demonstrate each case but it increases the maintenance burden.

Another option would be to use a 'nice' source database in the docker-compose and a more typical database in the k8s configuration we intend to add.

I'm gonna close this now because it's great and all but it's not in line with how we want to present the example setup.


Unfortunately, this only works for the basic es5 function syntax. It would be nice, if it worked for the es6 fat arrow function syntax as well.
// ES5 (settings work)
var multiplyES5 = function(x, y) {
  return x * y;
};

// ES6 (settings don't work)
const multiplyES6 = (x, y) => { return x * y };

Closing this in favor of https://github.com/microsoft/TypeScript/issues/25207
It's not possible for us to fix this reliably on the VS Code side. We really need TS to bring support for this


".got" linker section emitted in debug mode despite disabling dynamic linking/PIE

I'm getting this error "  = note: rust-lld: error: no memory region specified for section '.got'" which is unexpected because my target does not support the .got section at all. It is allowed in the linker script just to trigger a compiler error. This was working as of the .29 release, but is now broken with .33. With .29 I had the error with LTO code when using release mode, but with .33 that error went away. This .got error only occurs with debug builds.
The target file I'm using:
{
  "arch": "x86",
  "cpu": "i486",
  "data-layout": "e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128",
  "dynamic-linking": false,
  "executables": true,
  "has-elf-tls": false,
  "has-rpath": false,
  "is-builtin": false,
  "linker": "rust-lld",
  "linker-flavor": "ld.lld",
  "linker-is-gnu": false,
  "llvm-target": "i486-unknown-none",
  "max-atomic-width": 64,
  "os": "neutron",
  "position-independent-executables": false,
  "target-c-int-width": "32",
  "target-endian": "little",
  "target-family": "unix",
  "target-pointer-width": "32",
  "vendor": "qtum",
  "features": "-mmx,-sse,+soft-float",
  "panic-strategy": "abort"
}

The linker script:
ENTRY(__start)

EXTERN(__sheap)
EXTERN(__start)

MEMORY
{
    CODEMEM : ORIGIN = 0x10000, LENGTH = 63K
    CODEMEMAUX1 : ORIGIN = 0x20000, LENGTH = 63K
    CODEMEMAUX2 : ORIGIN = 0x30000, LENGTH = 63K
    CODEMEMAUX3 : ORIGIN = 0x40000, LENGTH = 63K
    CODEMEMAUX4 : ORIGIN = 0x50000, LENGTH = 63K
    CODEMEMAUX5 : ORIGIN = 0x60000, LENGTH = 63K
    CODEMEMAUX6 : ORIGIN = 0x70000, LENGTH = 63K
    CODEMEMAUX7 : ORIGIN = 0x80000, LENGTH = 63K
    DATAMEM : ORIGIN = 0x80020000, LENGTH = 63K
}
/* # Sections */
SECTIONS
{
  /* ### .text */
  .text :
  {
    *(__start_text);
    *(.text .text.*);
    *(.rodata .rodata.*);
  } > CODEMEM
  /* # aux code sections */
  .textaux1 :
  {
    *(.textaux1 .textaux1.*);
  } > CODEMEMAUX1
  .textaux2 :
  {
    *(.textaux2 .textaux2.*);
  } > CODEMEMAUX2
  .textaux3 :
  {
    *(.textaux3 .textaux3.*);
  } > CODEMEMAUX3
  .textaux4 :
  {
    *(.textaux4 .textaux4.*);
  } > CODEMEMAUX4
  .textaux5 :
  {
    *(.textaux5 .textaux5.*);
  } > CODEMEMAUX5
  .textaux6 :
  {
    *(.textaux6 .textaux6.*);
  } > CODEMEMAUX6
  .textaux7 :
  {
    *(.textaux7 .textaux7.*);
  } > CODEMEMAUX7

  /* ## Sections in RAM */
  /* ### .data */
  .data : ALIGN(4)
  {
    . = ALIGN(4);
    __sdata = .;
    *(.data .data.*);
    . = ALIGN(4); /* 4-byte align the end (VMA) of this section */
    __edata = .;
  } > DATAMEM AT > CODEMEM

  /* LMA of .data */
  __sidata = LOADADDR(.data);

  /* ### .bss */
  .bss : ALIGN(4)
  {
    . = ALIGN(4);
    __sbss = .;
    *(.bss .bss.*);
    . = ALIGN(4); /* 4-byte align the end (VMA) of this section */
    __ebss = .;
  } > DATAMEM

  /* ### .uninit */
  .uninit (NOLOAD) : ALIGN(4)
  {
    . = ALIGN(4);
    *(.uninit .uninit.*);
    . = ALIGN(4);
  } > DATAMEM

  /* Place the heap right after `.uninit` */
  . = ALIGN(4);
  __sheap = .;

  /* ## .got */
  /* Dynamic relocations are unsupported. This section is only used to detect relocatable code in
     the input files and raise an error if relocatable code is found */
  .got  :
  {
    KEEP(*(.got .got.*));
  }

  /* ## Discarded sections */
  /DISCARD/ :
  {
    /* Unused exception related info that only wastes space */
    *(.ARM.exidx);
    *(.ARM.exidx.*);
    *(.ARM.extab.*);
    *(.debug*);
    *(.comment*);
    *(.eh_frame*);

  }
}
/*
ASSERT(SIZEOF(.got) == 0, "
ERROR(cortex-m-rt): .got section detected in the input object files
Dynamic relocations are not supported. If you are linking to C code compiled using
the 'cc' crate then modify your build script to compile the C code _without_
the -fPIC flag. See the documentation of the `cc::Build.pic` method for details.");
*/

And the .cargo/config file:
[target.i686-neutron]
rustflags = [
  "-C", "link-arg=-Tlink.x",
  "-C", "relocation-model=static"
]
[target.i486-neutron]
rustflags = [
  "-C", "link-arg=-Tlink.x",
  "-C", "relocation-model=static"
]
runner = "neutron-testbench"

[build]
target = "i486-neutron"

I'm building it using cargo xbuild --target i486-neutron.json --verbose
I have a few other targeted crates that I'm using, as well as some common ones like serde, alloc, etc

I think this is a bug of rust itself. Have you tried building this with cargo's built-in -Zbuild-std=core,alloc flag instead of cargo-xbuild? You probably need to add a dependency on rlibc and an extern crate rlibc statement when trying this to resolve memset etc.
If the problem still occurs with -Zbuild-std, we know that it's not a problem in cargo-xbuild. In that case, we should report it in the rust-lang/rust repository directly.

It seems to slightly be a bug in cargo-xbuild. Specifically, the .cargo/config Rust flags aren't used for building the core etc crate. The target file is however used, so the solution I found is to add "relocation-model": "static" to the target file

Ah yeah, we deliberately set a RUSTFLAGS environment variable to override any rustflags keys in .cargo/config files: https://github.com/rust-osdev/cargo-xbuild/blob/a779803ab1062ce3e3f864f242b6c45aa02a0332/src/sysroot.rs#L93
Apart from passing -Cembed-bitcode=yes, the reason for this is that most of the time you don't want to apply your rustflags to the sysroot build. For example, you probably don't want that the sysroot crates are built with "-C", "link-arg=-Tlink.x" in your case.
So setting it in the target file is currently the only option I think. I would also recommend trying the -Zbuild-std flag, which builds the sysroot crates as normal dependencies and thus shouldn't have this problem.


Sync item pickup

Optionally, when one player picks up an item in the world, it should be removed for other players

As of 9a853363a27535df335e32a37397b999a2cccd75 this is synchronized both during play and when joining late. However, inventory items are not showing up in client's inventory after pickup.

As of e23ea43a67fcf767659999bc7a61ec061b5d1f68 items are showing in the client's inventory.


feat: Added parsing of JSDoc @description tags

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[x] Test
[x] Docs
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Description:
Adds support for the @description tag so that you can provide longer descriptions for API endpoints while summarizing with the @summary tag. Adapted one of the tests to have a simple verification and ran a global-replace of summary or description => summary which resulted in quite a diff.
Offtopic: A big thanks to everyone contributing here by the way, we're using express-jsdoc-swagger to generate OpenAPI specs that a Node process writes to a file that in turn Redocly uses to display it within a documentation portal 🙌 Like the way it's made to be a good fit for REST APIs while still adhering to the JSDoc standards

@all-contributors please add @dahlmo for code


App NOT working on Redmi Note 3

Before proceeding further , I would like to share my phone's features :-
Model No. - Redmi Note 3
Android version - 6.0.1 MMB29M
MIUI version - MIUI Global 8.1 | Stable 8.1.10 (MHOMIDI)
The problem I'm facing -> I have installed the OpenEvent App but it's not working. Whenever I try to open the app, a message saying that the "Unfortunately, OpenEvent app has stopped" pops out. You can check the bug report right out !

Yeah since the latest pull, the app has stopped working on mi3 too.

Model - Mi4i
Android - 5.0.2
App is crashing.

Model - Moto G4+
Android - 7.0.0
App is crashing.

Moto G4 Plus
6.0.1
Working fine
On Jan 7, 2017 12:06 PM, "Arpit Aggarwal"<EMAIL_ADDRESS>wrote:

Model - Moto G4+
Android - 7.0.0
App is crashing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/open-event-android/issues/963#issuecomment-271066879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQdmZAgn_y3fBw-S19JMHBS44VLt6Wg_ks5rPzJtgaJpZM4LcbXS
.

@mananwason any updates? Its still not working.

@arp95 I have identified the issue but there are some other issues as well in the repo. I'll create fixes for  everything asap.

Has Been Fixed in #986


Support for exporting to YAML

Feature Request
In #136 there was the feature request to support YAML as input. As explained there, this doesn't need to be built in, one can just parse the YAML and then pass it in. That's fine.
For our use case we need to also write to YAML. We were expecting that yaml.dump(model.dict()) would work, but for our case where we have custom types it doesn't (see https://github.com/gammapy/gammapy/pull/2621#discussion_r351905842). What does work is this:
yaml.dump(yaml.safe_load(self.json())

This triggers our custom JSON serialisers, and then because I think JSON is a subset of YAML, this works. I guess this would also work and be a bit cleaner:
yaml.dump(json.load(self.json())

Is there an option, or would it make sense to add it, to have custom serialisers triggered already in dict()?
https://pydantic-docs.helpmanual.io/usage/exporting_models/#modeldict
Then this would work yaml.dump(model.dict(serialise=True))
Alternatively, if yaml.dump(json.load(self.json()) is the way to do it: how about a small pydantic docs addition explaining how to work with YAML or other formats, by re-using the dict / json interface?
If you make a suggestion where to put it I could send a PR.

As discussed on #951 and as a solution to #317, dict() is going to get a simplify kwarg which will produce a simplified dict suitable for this application.
I'm going to work on it soon.


CalicoNode as RouteReflector do not keep the originary "Next Hop" when it forward BGP routes to an Edge Router

Calico Node working as a Router Reflector announce the Cluster routes as his own, that is, it does not use the parameter "next hop keep" from Bird that maintains the "Next Hop" of the routes received from the Nodes.
In my scenario I have 3 Nodes and the Master Node has Calico as RouteReflector and it share the Pods' routes with an edge BGP Router. So the Pods can be accessed from outside.
However, the Router Reflector sends all routes from the Pod Subnets to the Edge Router with the RouteReflector's IP address in the "Next Hop" field. In this way, all traffic coming from outside is transferred only to the Calico RouterReflector, when in fact it could forward directly to the Nodes.
Sugestion to implement
(WARNING: this not work!! Its a sugestion for a new feature)
Inserting "next hop keep" in Bird Template file by a configurable field in BGPpeer, like this:
# calicoctl get bgppeer my-global-peer -o yaml
apiVersion: projectcalico.org/v3
kind: BGPPeer
metadata:
  name: my-global-peer
spec:
  asNumber: 65000
  nodeSelector: route-reflector == "true"
  peerIP: <IP_ADDRESS>
  nextHopKeep: true

Resulting:
# cat /etc/calico/confd/config/bird.cfg
...
# For peer /host/NodeMaster/peer_v4/<IP_ADDRESS>
protocol bgp Node_10_79_63_42 from bgp_template {
  neighbor <IP_ADDRESS> as 65000;
  next hop keep;
}

Yes, that sounds like a bug if you can't peer an external peer with one of our RRs.

Hi @fasaxc , I can peer an external peer. The problem is that RR sends routes to the peer with its own IP address, not with Nodes IP address, it do not keep originary Nodes IP address...

So, the process should be like this:

Nodes send their routes to the RR.
The RR sends them to the Edge Router with the original IP of the Nodes (keeping the next hop).

So the Edge Router will route the traffic directly to the Nodes, without going through the RR.

Yes, that sounds like a bug if you can't peer an external peer with one of our RRs.

Hey there @fasaxc !
Actually what is desired was exposed in great details on this comment:
https://github.com/projectcalico/confd/pull/257#issuecomment-567058423
Which in turn became this issue:
https://github.com/projectcalico/confd/issues/308
Which (sadface) is still open.
I'd say you could close this as a duplicate, but that issue is created under 'projectcalico/confd', which feels kinda random for me (sorry if I'm dumb and don't understand calico's project dynamics!)
Maybe move it to here and drop this one?

projectcalico/confd#257 (comment)

These Issue is closed, but it was reopened in https://github.com/projectcalico/node/issues/279

confd is the project that contains our BGP templates.  That's because we have a customised confd that uses our datamodel and the easiest way to test it is to use our real templates.


feat: fix doc

@ConfigurationProperties(prefix = "spring.redis.redisson")
public class RedissonProperties {
...
}

due to RedissonProperties prefix is spring.redis.redisson, so the redis level is parent of redisson
but in README they are in same level.

Thanks for contribution!


fix heap-buffer-overflow

fix heap-buffer-overflow in https://github.com/redis/hiredis/issues/956

Hi,
I'm going through PRs in preparation for a new release.  I see what you're fixing here, but can you provide an example format string where we would currently read past the end of the buffer?
I thing a regression test may be worthwhile.

I ran the fuzzing tests described in the issue to be able to propose a testcase.
I have pinpointed the problem to the format specifier parser and will push an alternative fix for this, together with the testcases.

Closing in favor of #1097.  Thanks for finding and reporting the issue though!

I contest closing this.  Incrementing a zero terminated string twice, without checking that there is indeed a zero in between increments, is dangerous.  One should always check for zeroes, even if one strongly believes that the string is correctly constructed.

I am a professional programmer and I approve of this message.

@kristjanvalur I see your point.  It certainly doesn't hurt anything to apply both fixes.


Forge coverage doesn't recognize require with custom error branches

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (6179312 2024-06-10T00:18:46.177980000Z)
What command(s) is the bug in?
forge coverage  --ir-minimum
Operating System
macOS (Apple Silicon)
Describe the bug
Solidity 0.8.26 introduce a new overload require(bool, Error) that allows usage of require functions with custom errors. This feature is available in the via-ir pipeline only.
Forge coverage doesn't recognize the require branches when using with custom error.

I have the same problem while running forge doc.

FYI: by looking at this commit, the legacy pipeline is allowed in the current setup -> https://github.com/ethereum/solidity/commit/06c27a5e06683a23e31413215e6561d33acf32ea

this was fixed with https://github.com/foundry-rs/foundry/issues/4294 and will be followed up as branch coverage in https://github.com/foundry-rs/foundry/issues/8423


srb init crashes with Segmentation Fault

Input
Gemfile https://gist.github.com/50d2d950fe01d4fdbda6d068703e75e7 (with the fix for warnings and finding the executable)
Observed output
See full logs: https://gist.github.com/dorianmariefr/c414a7c2d48671be12fbf0fe6769882b
Expected behavior
Initializes all the correct files

Added a puts debugging, and I get:
puts "CONSTANT #{constant.inspect} CONST_GET NAME #{name.inspect}"

(other constants)
...
CONSTANT InheritedResources CONST_GET NAME "BaseHelper"

Also removed bootsnap and it didn't fix it

Oops, duplicate of #3984


marin3r-operator for lifecycle management

Create an operator to deploy marin3r and all its required resources to easy what is now a complex installation procedure. The end goal is to deploy marin3r using OLM.

Operator with basic install capabilities added in #8


Where should we stream FST to disk directly?

Description
Most of the use cases with FST seems to be writing the FST eventually to a DataOutput (is it IndexOutput?). In that case we are currently writing the FST to an on heap DataOutput (previously BytesStore and now ReadWriteDataOutput) and then save it to the on disk.
With #12624 it's possible to write the FST to an on disk DataOutput. So maybe let first compile a list of places which can be migrated to the new way?
Note: With the new way, there is a catch: We can't write the metadata in the same DataOutput as the main FST body, it has to be written separately.

A point for reference, Tantivy saves the metadata to the end of file, and it will first jump to the end to know the size and starting node. But we couldn't do it as one file might contain multiple FST

A candidate could be the FSTTermsWriter, which can help building FSTPostingsFormat with much less heap size.

I just briefly looked at the code, but it seems FSTTermsWriter will write the field metadata (number of terms, term freq, doc freq, etc), FST metadata, and FST main body for each of the field into a single IndexOutput.
As we can't write the FST main body into the same IndexOutput as the FST metadata, there are 2 possibilities:

To make the behavior same as before, we need to write the FST into a temporary IndexOutput (createTempOutput()?), then write it again to out. This means the behavior is exactly the same as before and no other code change required, but it would be slower (>x2 slower?), since we need to write the FST twice.
Or we could write the FST main body into a separate IndexOutput, and metadata on another IndexOutput. This would require propagation changes.

I realized FSTPostingsFormat is an experimental one, which is only being used in 5 places! Those Lucene9xPostingsFormat seem to be active ones, which in turn use Lucene90BlockTreeTermsWriter.

Put the first PR for FSTPostingsFormat: https://github.com/apache/lucene/pull/12980


Support static website commands for attached storage accounts

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!


Start adding support for different email libraries

@iaguirre88 Do we need to also add something to the Changelog section as part of this change?
In addition, the README section seems to need some words to mention this is the way to use the library with Bamboo. Maybe we can add it as part of this PR?

I was expecting to update the CHANGELOG file as part of the release. My idea was to add something like this:
## [0.7.0] - XXXX-XX-XX

### Additions

*  Provide callback when ErrorHandler is already in use ([#69])

### Breaking changes
* Now you should set the email delivery library you want to use. We currently
  support Bamboo or Swoosh.

  In case you want to keep using Bamboo you should change
  `BoomNotifier.MailNotifier` to `BoomNotifier.MailNotifier.Bamboo`.

    ```elixir
      use BoomNotifier,
          notifier: BoomNotifier.MailNotifier.Bamboo,
          options: [
            mailer: YourApp.Mailer,
            ...
          ]
    ```

    In case you want to start using Swoosh you should change
    `BoomNotifier.MailNotifier` to `BoomNotifier.MailNotifier.Swoosh`.
    ```elixir
      use BoomNotifier,
          notifier: BoomNotifier.MailNotifier.Swoosh,
          options: [
            mailer: YourApp.Mailer,
            ...
          ]
    ```


Changes In Hello Microverse Project Markup and Styling

The following changes were made:

Add index.html file
Add styles.css file
Add descriptive readme file

@christianbiring1 I included the LICENSE.md file in the main repository. According to a link suggested to me by the previous reviewer, I should include the license information either in the README or have a LICENSE.md file in the repo. I went with the latter.


fixed "for" directive documentation

This PR is addressing the behavior described in #151.
The former version of for directive example usage ended in:
genqlient.graphql:<line>: for is only applicable to operations and arguments

I have:

[x] Written a clear PR title and description (above)
[x] Signed the Khan Academy CLA
[x] Added tests covering my changes, if applicable
[x] Included a link to the issue fixed, if applicable
[x] Included documentation, for new features
[x] Added an entry to the changelog

Thanks!

Oh, great catch, thanks.


[RMC] Updates user agents

Removes the old user agents and adds some newer user agents based on @danielpclark's suggestions in one of the issues threads.
I went to the following link supplied by @danielpclark in Issue #70
http://ua.theafh.net/ and added the user agents that were desktop agents.

Failure reason: mime-types-data-3.2016.0521 requires ruby version >= 2.0, which is incompatible

I was hoping this would help me with the 999 issue after using a few different proxy services from my localhost, but alas, it did not make a difference.


[servicer] /mempool/* offline mode protection

This PR adds offline mode protection for /mempool/* endpoints.

Pull Request Test Coverage Report for Build 404

8 of 9 (88.89%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 70.949%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/router.go
0
1
0.0%

Totals

Change from base Build 397:
0.09%

Covered Lines:
1458

Relevant Lines:
2055

💛  - Coveralls


Connection rate limits exceeded, contact your app developer or<EMAIL_ADDRESS>

I have requested SendAndConfirmTransaction for 100 times and reported the following error
         _, err = confirm.SendAndConfirmTransaction(
		context.TODO(),
		this.getRpcClient(),
		this.wsClient,
		tx,
	)
	if err != nil {
		panic(err)
	}

panic: (*jsonrpc.RPCError)(0x140001a1800)({
 Code: (int) 429,
 Message: (string) (len=83) "Connection rate limits exceeded, contact your app developer or<EMAIL_ADDRESS> Data: (interface {}) <nil>
})

When I cut it down to 50 times, there's no problem
I want to know what the rpc limit is. Can I use higher concurrency?

This is dependent on your RPC provider and really related to this library at all

For production apps, you should use a dedicated (paid) RPC node (and avoid the public solana RPC).

is there any way to respect the rate limiting of the provider anyway?


Export to Excel

It would be great to be able to export the database to Excel. I know last year, GW used a custom break based on some formula involving speaks, opp_strength, etc.
I think I wrote code to do that some time ago, but it would require that there be changes to the views as well, adding a new screen for exporting to Excel. I also wrote functions to export the rooms and judges along with the teams.
My apologies to Ben, but I haven't really been keeping up with the changes he's been making, and I'm not sure whether the changes which I forked off (from nearly a year ago) are still compatible. If I were sure of that, I'd just up and do it.

Duplicate of https://github.com/jolynch/mit-tab/issues/30


[UI] Adapter migration to MUI v5

Notes for Reviewers

This PR migrates adapter page components to MUI v5 using sistent theme and styling

Signed commits

[x] Yes, I signed my commits.

@SAHU-01 eslite issues....


small input size

I am trying to independently replicate the LPIPS metric in Keras, initially focusing on uncalibrated VGG. Following the README I was getting the test_network.py working, but am a little confused by the three example images ex_ref.png, ex_p0.png, and ex_p1.png and how they are processed.
Each of these images are 64x64, and in test_network.py they are passed to the vgg network without scaling. But the native input size of VGG is 224x224 and the pytorch models documentation clearly states that input sizes are expected to that size (or larger):

All pre-trained models expect input images normalized in the same way, i.e. mini-batches of 3-channel RGB images of shape (3 x H x W), where H and W are expected to be at least 224.

Notably, when provided with 224x224 inputs, the layer sizes are:

(64, 224, 224)
(128, 112, 112)
(256, 56, 56)
(512, 28, 28)
(512, 14, 14)

However when they left at 64x64 without scaling, the layer sizes are smaller at each stage:

(64, 64, 64)
(128, 32, 32)
(256, 16, 16)
(512, 8, 8)
(512, 4, 4)

I'm not familiar with pytorch internals and so it's not clear to me how to interpret this behaviour in porting this to Keras. So my questions are:

Are these smaller inputs in fact valid ways of using these pre-trained VGG weights?
Could the LPIPS metric alternatively be implemented by always scaling inputs to the expected WxH sizes?

Convolutional layers can take on any size spatial input. The sizes of the feature maps will simply be scaled appropriately. You can pass any spatial size input to the metric.*
*above 16x16, so that the conv5 layer will at least be 1x1. I wouldn't recommend using anything below 64x64 though


Add check to confirm that role "Tenant Creator" is assigned to the selected user

In the section called "Assign the TenantCreator application role to a user in your Azure Active Directory tenant" I recommend adding a 7th Step to confirm that the portal now shows the added user to have "TenantCreator" role assigned to it.
I initially skipped this section because I saw my user account was already added to the App, but it ONLY had "Default Access" role so tenant creation failed.  I just think you need to make it super clear that user needs to check in the Portal UI that the TenantCreator role is assigned to the user.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eab4b2c4-29d9-d759-066f-f7cf633260ca
Version Independent ID: 05c8b237-2c9e-6453-9cbf-9c7a3b7f8b07
Content: Create a tenant in Windows Virtual Desktop (preview)  - Azure
Content Source: articles/virtual-desktop/tenant-setup-azure-active-directory.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@julesman101 Thanks for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

Additional screenshots added since the time this issue was filed. Should mitigate this concern going forward.
#please-close


fix: Remove the MPI constructor which may be misused

This patch removes the MPI constructor which may be used to construct invalid MPIs. It also adjusts the From<u8> implementation to use a safe variant.
Fixes: https://github.com/rpgp/rpgp/issues/401

Adding for clarity (we just discussed this privately):
impl From<&[u8]> for Mpi is not currently used in rPGP at all, in hko-s:rfc9580-encrypt.
So changing that to use the safe variant only impacts external users - who should probably never want the unchecked transformation.


Adding Go 1.9 to Travis-CI since it has been officially released

Hiya I'd be happy to merge, but can you clean up this PR? It's got multiple diffs on it.

Sure. I'll squash the commits


Support FC 24

Prerequisites

[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request
This autobuyer will support FC 24?
Describe the Use Case
Autobuyer Fc 24
Describe Preferred Solution
No response
Describe Alternatives
No response
Additional Information
No response

I don't think so ?


Add hover pop-up for remote connections

I noticed that the Hover feature(the bubble that shows the documentation of the object hovered on) does not work when using remote connections. It would be nice to have the bubble pop up when remoting to another machine.
This post on Stack shows how it currently works: https://stackoverflow.com/questions/70277022/vs-code-hover-does-not-show-on-remote-connections

It is supported - if you aren't seeing it, there might be an extension that you need to install onto the remote machine, like the python extension for example


cwltool: 3.1.20211104071347 -> 3.1.20211107152837

Motivation for this change
https://github.com/common-workflow-language/cwltool/releases/tag/3.1.20211107152837
Fix build (https://hydra.nixos.org/build/164061238)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 154781 run on x86_64-linux 1

1 package built:

cwltool

failing on arm-darwin

failing on arm-darwin

Sorry, I can't help with with darwin as I don't have access to that particular hardware. cwltool failed on aarch64-linux and x86_64-darwin. Thus, I guess that the issue is along the build chain for aarch64-darwin.


#1122 remove semicolon when query ends with semicolon

Description
When creating a data source with Hive as the source, an error occurs when the query ends with ";".
so remove semicolon when query ends with semicolon
Related Issue :
#1122
How Has This Been Tested?

Create DataSource with Hive or Create DataSet with Hive
select query tab
input simple query ends with ';'
ex) select * from default sales limit 10;
query executed without error.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Additional Context

run build
deploy to 3

@deidera08
기존 validation 절차가 변경되면서 후속 Flow에 줄 영향에 대해 좀더 기술적인 확인이 필요합니다.
우선 PR은 Close 하도록 하겠습니다.


adding jmh

@AbhinabKanrar I assume that the second one is the right one

@pivovarit
Yes, 1976 is the one


[WIP] Remap keycodes to previous map

The remote many of our presenters use sends PageUP/DOWN keycodes instead
of left/right like I thought. This restores prior behaviour and is
needed when using the standard Logitech remote.
TRAINTECH-1570 #resolved #time 30m

I think I will solve this a different way, so don't merge this yet.


bug: automated update schedule not finding new assets

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

📝 Description
Automated updates on macOS are not finding newer assets when available
🪜 Steps To Reproduce
See system logs
Gitify Version
5.15.0
Operating System
macOS
GitHub Account
GitHub Cloud
📸 Screenshots
No response

Upstream fix raised: https://github.com/electron/update.electronjs.org/pull/169


Template changes

Only template changes.

Hi, merged thanks. It looks closer to the django2 admin now. It somehow does not look good with suit now though. I see that it's not easy to maintain them both in the same template with a lot of {% if suit %} around. If you could give it a review it would be awesome, but I start to think that it would be better to have a sub application admin_report.suit that overrides the whole template when in INSTALLED_APPS. Maybe I'll do it myself sooner or later, but any help in that direction would be appreciated.

Actually I don't know anything about suit and just made it as close to
admin template as possible.
On Thu, 14 Nov, 2019, 15:33 Marco<EMAIL_ADDRESS>wrote:

Hi, merged thanks. It looks closer to the django2 admin now. It somehow
does not look good with suit now though. I see that it's not easy to
maintain them both in the same template with a lot of {% if suit %}
around. If you could give it a review it would be awesome, but I start to
think that it would be better to have a sub application admin_report.suit
that overrides the whole template when in INSTALLED_APPS. Maybe I'll do
it myself sooner or later, but any help in that direction would be
appreciated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/simplyopen-it/django-admin-reports/pull/26?email_source=notifications&email_token=AIQA4RU2EQMBNAKDZCKXZNTQTUPATA5CNFSM4JLHNPLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEBJA4Y#issuecomment-553816179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIQA4RUM4OGNRPYXXWBLCJDQTUPATANCNFSM4JLHNPLA
.


add THR_MDL_FAC parameter handling to FMU

Was unable to push directly to PX4/pr-mixerEnhancements.
I thought this used to work:
git push --set-upstream px4 pr-mixerEnhancements
remote: Permission to PX4/Firmware.git denied to kd0aij.
fatal: unable to access 'https://github.com/PX4/Firmware.git/': The requested URL returned error: 403

@kd0aij Permissions setup fail. It's fixed.


Ball Trail

We should have a very light trail on the ball, just so it's a bit easier to dictate it's direction. Might end up looking bad, so don't worry too much about it.

This already exists, just wasn't working.


Update README.md

Coverage remained the same at 100.0% when pulling 5a1e74957aac9a65058a805289a453a9cf74f4fb on iliyaZelenko:patch-1 into<PHONE_NUMBER>f7e221a06877b1722519f2a2443adc on charliekassel:master.


Coregistration documentation fixes

There were many already outdated examples in the coregistration section. This fixes them.

Damnit... I mixed the history of this PR and #88!

Nothing that some force-pushing can't fix!

I'll merge this  since it doesn't conflict with the main branch nor any other active project.


Pluggable storage architecture

It seems like it would be useful to support various backup formats and Target systems:
Backup formats:

binary data (currently implemented): small size. Fast. But hard to recover if tools are lost or there are serious bugs in the serialization format
Json (see implementation by getdreams): potentially large overhead. But easier to understand for humans. Hard to represent binary data gracefully. Base64 is possible but huge. Maybe a good option for strings or json topics.
Encryption (See #30)
Compression (See #29)

Target storage systems:

local disk (currently implemented)
Cloud storage (S3, Azure Blobs, ...) #26
On premises object storage (glusterfs, ...)

I am not sure which part should be covered by Kafka Backup and which should be handled by the underlying system. But this gets interesting as soon as we want to stream data from and to object storage where we do not have the easy possibility to manipulate data locally.
In terms of implementation I imagine a pluggable storage layer consisting of storage sinks that are agnostic to the data format and accept a stream of data to be written to or read from. And on top of it a layer of Transformation Middleware that can apply transformation to the data (E.g. compression, encryption, etc)
But as this is a backup tool I would like to be very cautious about too many features to reduce the probability of serious bugs and would like to keep it as simple as possible.
Feel free to share your comments!

Cloud storage seems to be the next logical step for this project.
Is anybody currently working on it? I might take a look into it.

Currently nobody is working on anything at this project. But if you want to contribute that would be awesome :)


AssertionError: CocoDataset: Annotation ids are not unique!

I have met this error and it is weird, I think! Can anyone help me with this :( Thanks in advance!

You have to review the annotations list inside the .json in COCO format that you are referencing in the configuration file. Each annotation inside the annotations list should have an unique id property; the AssertionError you have met indicates that there is at least 1 duplicated id in that annotations list.

Hi @daavoo, thanks for your reply. Actually, I had checked the JSON files before I set the issue. I found them totally normal@ Believe this or not, I did train the model successfully several days ago. But today, I have met this issue (I didn't change anything ). That's tough LOL

Hi @daavoo, thanks for your reply. Actually, I had checked the JSON files before I set the issue. I found them totally normal@ Believe this or not, I did train the model successfully several days ago. But today, I have met this issue (I didn't change anything ). That's tough LOL

Successful training does not mean that the annotation is not correct. This check is added several days ago to prevent the potential error in your annotation file.

Hi @ZwwWayne, many thanks for your help! I'll carefully check the annotation again :+1:

Maybe we could improve the error message to show the id(s) that caused the intersection

How is this problem solved！please

Is there any update on that checking which are repeating? I am facing the same issue after converting the YOLO format files to COCO. I have more than 11k ids and it doesn't make sense to check it manually. @daavoo @hhaAndroid hhAndroid

Is there any update on that, checking which are repeating? I am facing the same issue after converting the YOLO format files to COCO. I have more than 11k ids and it doesn't make sense to check it manually. @daavoo @hhaAndroid

Also, is there a library that you recommend using for converting YOLO to COCO? I am assuming it has to do something with it even though I did not find any.

mine was due to the image names aren't match the 'image_name' in the json file.


Zephyr Benchmarks

Benchmarked Zephyr in both Classification and Summarization tasks

Classification

Ablation study from 2.5% to 100% samples
QLoRA Finetuning
with NEFTune vs without
Tuning only attention modules vs all modules

Summarization

Zero-shot vs few-shot
QLoRA Finetuning
with NEFTune vs without
Tuning only attention modules vs all modules

Looks good @benjaminye !
I am merging this PR! Congrats on your first merge!
Following this merge, can you please update the main README to reflect the addition of Zephyr to the roadmap, and the links to the README and Code folder?


Selecting the license for the project

Background reading. Good reference from above article.
From the above readings it comes down to two options:

GNU General Public License version 3
MIT license

@ovainola and @ahojukka5 any comments?

After reading the links, I think we should go for the MIT licence

It would be good to mention some reasoning behind the opinion.

MIT licence:
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, ...
GNU licence:
The licenses for most software and other practical works are designed to take away your freedom to share and change the works. By contrast, the GNU General Public License is intended to guarantee your freedom to share and change all versions of a program--to make sure it remains free software for all its users. We, the Free Software Foundation, use the GNU General Public License for most of our software; it applies also to any other work released this way by its authors. You can apply it to your programs, too.
When we speak of free software, we are referring to freedom, not price.
I think if anyone wants to create a program from our code (whether it's free or commercial) it only a good thing. GNU licence restricts the commercial side.

I think the most important aspect about choosing a license is how it affects to the willingness to contribute to the project. The pragmatic approach would then be to choose the license which is most widely used, i.e. MIT.

Here is the list of other FEM licenses:
http://en.wikipedia.org/wiki/List_of_finite_element_software_packages

package
license

Agros2D
GNU GPL

CalculiX
GNU GPL

Code Aster
GNU GPL

deal.II
LGPL

DUNE
GPL Version 2

Elmer
GPL

FEBio
Custom

FEniCS Project
LGPL

FreeFem++
GPL

GetFEM++
LGPL

Hermes Project
LGPL

jFEM
GNU GPL

Kratos
BSD licenses

MoFEM JosePH
LGPL

MOOSE
LGPL

OOFEM
GPL Version 2

OpenFOAM
GPL

OpenSees
Non Commercial

Z88/Z88Aurora
Custom

And then other scientific packages:
http://en.wikipedia.org/wiki/SciPy, http://en.wikipedia.org/wiki/NumPy, http://en.wikipedia.org/wiki/Pandas_(software)

package
license

SciPy
BSD-new license

NumPy
BSD-new license

Pandas
three-clause BSD license

And then more statistics:
https://github.com/blog/1964-open-source-license-usage-on-github-com

Rank
License
% of projects

1
MIT
44.69%

2
Other
15.68%

3
GPLv2
12.96%

4
Apache
11.19%

5
GPLv3
8.88%

6
BSD 3-clause
4.53%

7
Unlicense
1.87%

8
BSD 2-clause
1.70%

9
LGPLv3
1.30%

10
AGPLv3
1.05%

And of course we are developing a Julia package: https://github.com/JuliaLang/julia/blob/master/LICENSE.md, which is MIT.

I vote also MIT. Unanimously decided MIT.


Is there a way to use ImGui's Freetype support?

As of imgui-rs 0.7 there isn't an easy way to enable imgui's freetype support
With imgui 1.81 (imgui 0.7 uses 1.80), the freetype integration was simplified. Once imgui-rs is updated to use >=1.81, then this might be fairly easy to do..
What I tried:

Add define for IMGUI_ENABLE_FREETYPE into imgui-sys/build.rs
Include imgui_freetype.cpp into imgui-sys/src/include_all_imgui.cpp (this also required build.include("third-party/imgui"); so imgui_freetype.cpp could find imgui.h)
Add in the appropriate compiler/linker flags for freetype (I'm not sure the best cross-platform approach to this is - maybe good idea to look at the -sys crate for freetype-rs or rust-freetype?)
Add a feature flag to opt into this (there's already an example in build.rs to respect a feature flag in build.rs)

Then in theory that is about it, I think.. however I did all that got some compiler errors from the C++ part along the lines of
.../imgui-rs/imgui-sys/./third-party/cimgui/imgui/misc/freetype/imgui_freetype.cpp:147: undefined reference to `FT_New_Memory_Face'

..which I suspect may be to do with the order everything is getting passed to the compiler, although I didn't look into it closely

Ohh, just realised there is some stuff in cimgui to enable Freetype support, which may help matters,
https://github.com/cimgui/cimgui/blob/ceda975a5b189e140d52aa2699811dbcbc769bb1/CMakeLists.txt#L23

Made a PR with this: #496


Allow use of alias in making DataFrame

Should be able to pass alias to w.df(), and control what the resulting column is called (i.e. called after the alias key, e.g. Gamma, or after the curve mnemonic, e.g. GR).

As long as it's an option, I think that would be great. Right now I am working with wells that have AT90 in the upper section and ILD logs in the reservoir section. Would it merge these two into one RESD curve?

No, it wouldn't do that... alias just chooses the one with the highest priority.
Merging would be cool though!


Cannot delete .asar file while VS Code is open

Hi!
It looks like VS Code opens .asar files to make them browsable in the workspace tree view. That sounds helpful, except it seems like a file handle is kept open at all times, preventing some packaging script of mine from deleting .asar files if I keep VS Code open when running it.
Would it be possible to ensure .asar files are only opened by VS Code if they are being browsed explicitely in the tree view? or maybe avoid keeping the file handle open on them while idling?
I'm running VS Code 0.10.2 on Windows 7 64-bit.
Thanks for a great editor! ♥

@elisee not much we can do here really because Electron decides to treat asar files very special. See https://github.com/atom/electron/issues/1658

Ah. Reading the bug you linked, I wonder if VSCode could maybe require original-fs in the workspace tree code instead of fs so that .asar files aren't treated special? Obviously I have no experience with the actual code so it might not be manageable, but just putting it out there...

Maybe, but it's ugly to force everyone to remember to not use fs module.

Hi Team, I have the same issue with the latest build of vscode. I open my project with vscode, the foo.asar is located in dist. I never intend to open this file in vscode at all. But vscode is able to list its contents. That's why the file cannot be deleted. I'd like to know, if vscode has the possibility not to preview asar file content.

We should try to set the process.noAsar flag early on. This will disable any support to view *.asar files in the explorer but this was also never intended.

Actually we cannot set process.noAsar because that disables loading of any renderer side electron module...

@bpasero This is an annoying problem,every time when I run the build script i have to close vscode first,but my present job require electron,so I have to consider other editor?

I will see if there is a way to prevent the locking from happening.

I opened https://github.com/electron/electron/issues/6251 as related upstream issue.

Pushed a change to treat *.asar as normal files and not directories. It is not 100% possible for us to prevent the locking because it seems a simple fs.stat or fs.readdir on such a file is sufficient to have it locked. But I went through our places of such calls and handle *.asar specially now. Let's see how it goes.
As a consequence you can no longer expand and browse in *.asar files. But that was also never the intent of VS Code to do so in the first place because these files are very special to Electron.

I can no longer open *.asar file within VS Code (which is correct), but I'm still able to open an *.asar from the command line. It shows up as an empty project folder and trying to create a file there run into errors:

@weinand thanks, can you open a separate issue on this? I think the original issue should be verified.

@bpasero I'll create a new issue.
BTW, the *.asar opened from the command line cannot be deleted as long as VS Code is open, so I did verify the original issue.

@weinand good point, though I think that is not a very typical scenario and also not what the users are complaining about.

I'm running 1.5.3 and this issue still remains

@a11smiles what OS are you on? Here is me not being able to reproduce it by opening an Electron app with VS Code on Mac:

Extracted https://github.com/Microsoft/vscode/issues/13076


Bug Fix - Fixed CallKit Outgoing Calls

The original way that outgoing calls were placed was causing issues with CallKit and creating unstable states. This lead to calls not terminating properly and hanging in the background with CallKit.

Thank you!


Fixing bugs

Fixing a few bugs in Shunting yard to get the base code working

Pull Request Test Coverage Report for Build 81

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.892%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shunting-yard-replicator/src/main/java/com/hotels/shunting/yard/replicator/exec/conf/EventReceiverConfiguration.java
0
1
0.0%

shunting-yard-replicator/src/main/java/com/hotels/shunting/yard/replicator/exec/messaging/MessageReaderAdapter.java
0
2
0.0%

Totals

Change from base Build 74:
0.0%

Covered Lines:
1411

Relevant Lines:
1723

💛  - Coveralls


Add B. Yates to interested parties list

This PR
Adds myself (Brandon Yates) as an interested party to OpenFeature.
Notes
I opened this md file in Visual Studio Code and it auto-formatted some whitespace. I can remove those whitespaces if necessary.

Hey @byates-fleetian, please let me know if you have any questions.


Smartico Sensors Integration

Smartico sensor integration guides

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[draft] Structured Service Binding

Use Filip's Service Binding code in https://github.com/google/horologist/pull/1596
Simplifies and improves the was UI talks to a bound service.

Removes explicit createService calls in ViewModels
Scopes the connection to ActivityRetained (basically any view models are open)
avoids dealing with theoretical nulls or .first() calls for getting the service.

TODO

release Horologist and delete BinderConnection.kt

cc @garanj @fstanis