name_entity_recognition

When I run
 python examples/pytorch/name_entity_recognition/main.py
i get the error:
starting build the dataset                                                                                Traceback (most recent call last):                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 391, in <module>                                            runner = Conll()                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 107, in __init__                                            self.build_dataloader()                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 125, in build_dataloader                                    tag_types= self.tag_types,                                                                                File "/home/synthesisproject/anaconda3/envs/vineeth/lib/python3.6/typing.py", line 1231, in __new__                       return _generic_new(cls.__next_in_mro__, cls, *args, **kwds)                                                          File "/home/synthesisproject/anaconda3/envs/vineeth/lib/python3.6/typing.py", line 1186, in _generic_new                  return base_cls.__new__(cls)                                                                                TypeError: Can't instantiate abstract class ConllDataset with abstract methods download

This seems to be a problem with the ConllDataset:
`TypeError                                 Traceback (most recent call last)
 in
----> 1 dataset = ConllDataset()
~/anaconda3/envs/vineeth/lib/python3.6/typing.py in new(cls, *args, **kwds)
1229             raise TypeError("Type Generic cannot be instantiated; "
1230                             "it can be used only as a base class")
-> 1231         return _generic_new(cls.next_in_mro, cls, *args, **kwds)
1232
1233
~/anaconda3/envs/vineeth/lib/python3.6/typing.py in _generic_new(base_cls, cls, *args, **kwds)
1184         if (base_cls.new is object.new and
1185                 cls.init is not object.init):
-> 1186             return base_cls.new(cls)
1187         else:
1188             return base_cls.new(cls, *args, **kwds)
TypeError: Can't instantiate abstract class ConllDataset with abstract methods download`

Thanks for reporting this issue. We will look into this.
Currently, a quick fix is to uncomment L221-L224 in examples/pytorch/name_entity_recognition/conll.py to implement the download() method. But this requires you to make sure that the raw Conll dataset is present, i.e. the conll/raw dir in the NER example directory and the corresponding files are present.
We will be working on a more thorough fix.

@SaizhuoWang Thank you! This function is not being executed. I'm getting the same error as before

Noted. I'll investigate this deeper.

The error is the same as before:
TypeError: Can't instantiate abstract class ConllDataset with abstract methods download                                  home@spatula graph4nlp]$ python examples/pytorch/name_entity_recognition/main.py                  starting build the dataset                                                                                Traceback (most recent call last):                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 384, in <module>                                             runner = Conll()                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 101, in __init__                                            self._build_dataloader()                                                                                File "examples/pytorch/name_entity_recognition/main.py", line 119, in _build_dataloader                                   tag_types=self.tag_types,                                                                                File "/home/synthesisproject/anaconda3/envs/vineeth/lib/python3.6/typing.py", line 1231, in __new__                        return _generic_new(cls.__next_in_mro__, cls, *args, **kwds)                                                           File "/home/synthesisproject/anaconda3/envs/vineeth/lib/python3.6/typing.py", line 1186, in _generic_new                   return base_cls.__new__(cls)                                                                                TypeError: Can't instantiate abstract class ConllDataset with abstract methods download

@SaizhuoWang Hi, I have opened some issues in the gaphnlp_demo repo. Could you please take a look at those as welll?

Hi. I've followed the quick fix mentioned previously and it worked out fine for me. Please make sure the fix are made and try it again, thanks! We will also fix it in the source code in the coming version.


ci: use DerYeger/yarn-setup-action

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Bofrost.be has degraded performance

In dcc690c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1929 ms

Resolved: Bofrost.be performance has improved in c58a599.


[Bug]: Suisse Int'l font family transform issue / special character transform issue

What happened?
In my token.json i have:
      "suisse-intl": {
        "value": "Suisse Int'l",
        "type": "fontFamilies"
      }
    },

Which include special character `
css is like this (as example):
--sdFontFamilySuisseIntl: 'Suisse Int'l';
Which is not valid CSS (it breaks the CSS syntax).
When you have a font name that contains spaces or special characters, you need to wrap it in quotes. replace ' ' with " " or should we try to esacpeing \ the single quote by adding like:
'Suisse Int\'l'
Wrote to Joren on Slack and he confirmed this:
"I think that should be handled by the font family transform, which is the function that introduces the single quotes when a font-family has spaces"
"It should escape any occurences of ' automatically, but we don't have this logic implemented yet,"
"https://github.com/tokens-studio/sd-transforms/blob/main/src/css/transformTypography.ts#L19 this is the function btw that wraps font-families in '' which needs to deal with escaping already existing '  in the font family name"
Reproduction
link to reprod
Expected output
Should probable be esacpeing \ the single quote by adding like:
'Suisse Int\'l'
for this kind of cases (as described above).
Version
@tokens-studio/sd-transforms": "^0.11.6" in React

@jorenbroekema My proposal to resolve the issue would be something like:
function escapeApostrophes(str) {
    return str.replace(/'/g, "\\'");
}

function quoteWrapWhitespacedFont(fontString) {
    let escapedFontString = escapeApostrophes(fontString);
    return hasWhiteSpace(escapedFontString) && !isAlreadyQuoted(escapedFontString) ? `'${escapedFontString}'` : escapedFontString;
}

In this updated version:
escapeApostrophes is a new function that takes a string and replaces every apostrophe with an escaped apostrophe. It uses the replace method with a regular expression /'/g that matches all occurrences of an apostrophe and replaces them with \' (the double backslash is needed because backslash is an escape character in JavaScript strings).
In the quoteWrapWhitespacedFont (exisiting function), the input string is first passed to escapeApostrophes to ensure all apostrophes are properly escaped. Then, the rest of the function proceeds as before, but uses the escaped string for the checks and final return value.
This should resolve the issue with breaking CSS when the string contains apostrophes.
In JavaScript, the backslash itself is an escape character. This means that to represent a single backslash in a JavaScript string, you we to use two backslashes (\) as example above.


Use platform independent line endings in W3CDomTest.

The W3CDomTest simpleConversion test fails on windows since it is using "\n" as the
line ending. Using a platform independent line ending i.e. \r\n on windows
or \n on unix, fixes it.

Thanks for the fix!


add havok to download mode

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.


Implement binary marshaler and unmarshaler for Result object

Can we implement binary marshaler and unmarshaler for Result object?
Sometimes I found some extra efforts where I manually need to convert object into []byte, however the vendor already has the provision to call binary marshaler within itself.
This is very useful when we are passing Result object to any database for storage.

I designed the Result object to be an intermediate working type following a Get() operation. I feel that marshal and unmarshall methods are outside of it's intended purpose.
In Go, it's possible to create custom wrapped types that "inherit" the functionality of another type. I recommend wrapping the gjson.Result type which implements the necessary MarshalBinary/UnmarshalBinary functions.
package main

import (
	"encoding/json"

	"github.com/tidwall/gjson"
)

type Result struct {
	gjson.Result
}

func (res *Result) MarshalBinary() ([]byte, error) {
	return json.Marshal(res.Result)
}
func (res *Result) UnmarshalBinary(data []byte) error {
	return json.Unmarshal(data, &res.Result)
}

func main() {
	json := `{"first": "James", "last": "Murphy"}`
	res := Result{gjson.Get(json, "first")}
	bytes, err := res.MarshalBinary()
	if err != nil {
		panic(err)
	}
	var res2 Result
	if err := res2.UnmarshalBinary(bytes); err != nil {
		panic(err)
	}
	println("equal:", res == res2)

}

but every time I have to use my Result object in the projects.

Adding a binary format to gjson is outside the scope the core library. So the only option is to handle the custom marshaling in your project.

Optionally you could fork the project and add the functionality.

Optionally you could fork the project and add the functionality.

Yah that seems better in my case
Thanks man


Replace anonymous useEffect functions with named functions

For code cleanliness, we can replace all the anonymous functions we pass into our react hooks (such as useEffect) with named functions. This will help with code readability and debugging. See blog post discussing some of the benefits: https://laurenclark.io/posts/named-functions-vs-anonymous-arrow-functions/
Replace:
useEffect(() => {
  ...
}, []);

With:
useEffect(function myFunc() {
  ...
}, []);

There may be an eslint rule we can enable for this.

what's the advantage of named vs anon here? does it help with debugging output or something?

@dsmmcken Yes, this will help with debugging output but also code readability in general. See https://laurenclark.io/posts/named-functions-vs-anonymous-arrow-functions/ for a quick blog post showing the debug output.

Good issue for Tony.


Age limit icons

Do you have an svg icon file?
Please upload this file as an attachment or name the upstream branch containing it.
Is the icon file ready to be added to the library?

It has been trimmed using a minifier like SVGOMG. (Lowest precision without visual degradation)
It has fill-rule of fill="currentColor"
It has no explicit width/height
It has viewbox of viewbox="0 0 24 24"

What is the name of the icon?
nrk-media-agelimit-6
nrk-media-agelimit-9
nrk-media-agelimit-12
nrk-media-agelimit-18
nrk-media-agelimit-A
Additional context
Add any other context or screenshots about the feature request here.

Overlapping points when outlining NRK Sans Variable. Removing them manually.

Guide to how to fix NRK Sans Variable outlines in Figma added to Figma library file.
https://www.figma.com/file/KXGJ6Qcdf8JAyRCoKV55If/NRK-Core-Icons?node-id=2616%3A70

Optimized with SVGOMG and manually cleaned, added currentColor fills.


minor typo on installation?

https://github.com/sftcd/openssl/blob/4ead0b350ef545e8d1079c47d1b016dc948bbd32/esnistuff/building-curl-openssl-with-ech.md?plain=1#L19-L20
i'm afraid that cd openssl is required between those commands.

Hiya,
On 23/05/2023 14:38, ilsubyeega-desu wrote:

i'm afraid that cd openssl is required between those commands.

Thanks. Those build instructions may be a little outdated,
but we will be re-doing the curl integration in the coming
weeks. (Meanwhile if you find stuff that'll make our job
easier, that's great and please let us know!)
Ta,
S.


also what about primary key combinations?

also what about primary key combinations?
Originally posted by @unique1o1 in https://github.com/facebook/ent/issues/695#issuecomment-680705917
Yes I was wondering the same thing. Can you address this  @a8m ?

Hey, please continue the discussion in #695. Thanks 😃


Big dev PR

I have no idea why this is so huge, has something gone wrong?

minor docs improvements


Add web languages (typescript and style languages)

It should be great to define an order to languages, no ?

Sure, but that would require manual sorting :/ CMD+F does the job!


Add year_of_week() function

This function should accept a date return the year corresponding to the ISO week of that date.

Claiming this task

Done. Merged to master.


MinApp option for no minification based on filename

Frequently users have files that are already minified, and to leave these
files unaltered is a common and valid request. An example is in this hack:
http://groups.google.com/group/minify/msg/c6084bf3234af836

I'm imagining a new MinApp option 'noMinPattern' with default:
'@[-\\.]min\\.(?:js|css)$@i'

If preg_match(pattern, basename(file))
   then $spec['minifier'] = ''

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 28 Sep 2009 at 10:20

In R411

Original comment by<EMAIL_ADDRESS>on 9 May 2010 at 4:48

Changed state: Verified


Pylance and type checking for **destructuring at fn call

Environment data

Pylance language server 2022.3.0

OS and version: Ubuntu 20
Python version: 3.10.2

Expected behaviour
m.b. type checking error shouldn't be shown ?
Actual behaviour
Type checking error is shown
Code Snippet / Additional information
just a simple example
from dataclasses import dataclass
import dataclasses as dc
from typing import Iterable, Any

@dataclass
class A:
	valInt: int
	valStr: str
	valList: list
	valDict: dict
	valIterable: Iterable

def main():
	data: dict = {'valInt':1, 'valStr':"value for valStr", 'valList': [1, 2, 3], 'valDict': {}, 'valIterable': {}}
	a: A = A(**data)
	L('asdict:', dc.asdict(a))
	L('astuple:', dc.astuple(a))

when i run this script, it works as expected and with no errors, but the Visual Studio Code shows error in the place where dataclass is initialized from dict (a: A = A(**data)).
So is it expected behaviour or how to bypass cases like that in sources?

Pylance is narrowing the type of data from dict to dict[str, int | str | list[int] | dict[Any, Any]] based on the assigned expression. When you expand this type using the ** operator, it is detecting a type mismatch for the dataclass.
You can provide a more explicit type annotation for data:
data: dict[str, Any] = { ... }

The explicit Any here tells pylance that you don't want it to perform any type narrowing.
You will get better type checking if you don't initialize your dataclass from an unpacked dictionary and instead pass individual arguments. If it is necessary to use a dict here, one option is to define a TypedDict, like this:
class AData(TypedDict):
    valInt: int
    valStr: str
    valList: list
    valDict: dict
    valIterable: Iterable

def main():
    data: AData = {
        "valInt": 1,
        "valStr": "value for valStr",
        "valList": [1, 2, 3],
        "valDict": {},
        "valIterable": {},
    }
    a: A = A(**data)

This approach is more verbose, but it provides for more complete static type checking.

@erictraut well, thanks a lot. i gonna choose the first advice (dict[str, Any]) and will use it everywere latter.
but, IMO, this use-case (with packing in fn call) isn't obvious enought and may be should be described somehow in additional documentation, usage examples etc.


(WIP)Litmusbook to create openebs snapshot and restore the volume

Signed-off-by: gprasath<EMAIL_ADDRESS>
What this PR does / why we need it:

The litmusbook accepts application label and namespace to find out the volume for which the snapshot will be created.
This litmusbook is capable of creating snapshot and restore the volume to the state when the snapshot was created.
The test has been done against percona deployment. Here, we create a database and create a snapshot. Then, remove the database and restore the volume to the earlier state before the snapshot creation.
Modified the variable names in openebs-snapshot-restore funclib utility task file. This util can be used in playbooks where either snapshot creation or volume restore has to be performed.

Sample test run flow:
FAILED - RETRYING: Checking if the application pod is scheduled again (15 retries left).
changed: [<IP_ADDRESS>] => {"attempts": 2, "changed": true, "cmd": "kubectl get pod -n app-percona-ns -l name=percona", "delta": "0:00:00.853669", "end": "2018-10-10 12:14:02.372935", "rc": 0, "start": "2018-10-10 12:14:01.519266", "stderr": "", "stderr_lines": [], "stdout": "NAME                       READY   STATUS    RESTARTS   AGE\npercona-5957995575-tdxnf   1/1     Running   0          39s", "stdout_lines": ["NAME                       READY   STATUS    RESTARTS   AGE", "percona-5957995575-tdxnf   1/1     Running   0          39s"]}

TASK [Obtaining application pod details after restart.] ************************
task path: /percona/functional/snapshot/test.yml:157
changed: [<IP_ADDRESS>] => {"changed": true, "cmd": "kubectl get pods -n app-percona-ns -l name=percona -o custom-columns=:.metadata.name --no-headers", "delta": "0:00:00.872661", "end": "2018-10-10 12:14:03.431048", "rc": 0, "start": "2018-10-10 12:14:02.558387", "stderr": "", "stderr_lines": [], "stdout": "percona-5957995575-tdxnf", "stdout_lines": ["percona-5957995575-tdxnf"]}

TASK [Store new percona pod name in variable.] *********************************
task path: /percona/functional/snapshot/test.yml:165
ok: [<IP_ADDRESS>] => {"ansible_facts": {"pod_name": "percona-5957995575-tdxnf"}, "changed": false}

TASK [Verifying whether the restore operation is successful by validating data.] ***
task path: /percona/functional/snapshot/test.yml:169
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": true, "cmd": "kubectl exec -it percona-5957995575-tdxnf -n app-percona-ns -- mysql -uroot -pk8sDem0 -e \"select * from ttbl;\" tdb", "delta": "0:00:01.083600", "end": "2018-10-10 12:14:04.757169", "failed_when_result": true, "msg": "non-zero return code", "rc": 1, "start": "2018-10-10 12:14:03.673569", "stderr": "Unable to use a TTY - input is not a terminal or the right kind of file\nmysql: [Warning] Using a password on the command line interface can be insecure.\nERROR 1049 (42000): Unknown database 'tdb'\ncommand terminated with exit code 1", "stderr_lines": ["Unable to use a TTY - input is not a terminal or the right kind of file", "mysql: [Warning] Using a password on the command line interface can be insecure.", "ERROR 1049 (42000): Unknown database 'tdb'", "command terminated with exit code 1"], "stdout": "", "stdout_lines": []}

TASK [Test Failed] *************************************************************
task path: /percona/functional/snapshot/test.yml:183
ok: [<IP_ADDRESS>] => {"ansible_facts": {"flag": "Test Failed"}, "changed": false}

TASK [Generate the litmus result CR to reflect EOT (End of Test)] **************
task path: /percona/functional/snapshot/test.yml:191
changed: [<IP_ADDRESS>] => {"changed": true, "checksum": "2b634c3bbf60a867a408e90ae89a5ffc17d0e3b4", "dest": "./litmus-result.yaml", "gid": 0, "group": "root", "md5sum": "3f02e5892f90fe4ed202e7734e488fa2", "mode": "0644", "owner": "root", "size": 430, "src": "/root/.ansible/tmp/ansible-tmp-1539173644.89-169934525365517/source", "state": "file", "uid": 0}

TASK [Apply the litmus result CR] **********************************************
task path: /percona/functional/snapshot/test.yml:202
changed: [<IP_ADDRESS>] => {"changed": true, "cmd": "kubectl apply -f litmus-result.yaml", "delta": "0:00:01.015579", "end": "2018-10-10 12:14:07.828767", "failed_when_result": false, "rc": 0, "start": "2018-10-10 12:14:06.813188", "stderr": "", "stderr_lines": [], "stdout": "litmusresult.litmus.io/openebs-snapshot-restore configured", "stdout_lines": ["litmusresult.litmus.io/openebs-snapshot-restore configured"]}
META: ran handlers
META: ran handlers

PLAY RECAP *********************************************************************


Remove paren from DataArray.from_dict docstring

as per https://github.com/pydata/xarray/issues/6136

Thanks!


rct-vl-first isn't showing on .rct-dateHeader

Any pointers on why .rct-dateHeader does not have .rct-day-0 or .rct-vl-first so i'm unable to style them.

@loaibassam these were removed when Timeline Headers where introduced

Were they replaced with anything else?

DateHeader should do the trick but depends on what you are trying to do

What I'm trying to do is:

weekdays have a grey background colour, which I want to also show on the day in the header.
The border that separate months is darker, i want to also extend that to the day in the header.

you can definitely do that with DateHeader using intervalRenderer where you can use interval to check the dates and accordingly apply some custom styles

Thanks a ton! :)


Fix misspelled filename (bytetypes.go)

Codecov Report

Merging #368 (01d90ad) into main (7065837) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 01d90ad differs from pull request most recent head 07dddbc. Consider uploading reports for the commit 07dddbc to get more accurate results

@@            Coverage Diff            @@
##              main      #368   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          239       239
  Lines        12888     12890    +2
=========================================
+ Hits         12888     12890    +2

Impacted Files
Coverage Δ

pkg/fftypes/bytetypes.go
100.00% <ø> (ø)

internal/blockchain/ethereum/ethereum.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/fabric.go
100.00% <100.00%> (ø)

internal/config/config.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7065837...07dddbc. Read the comment docs.


Consolidate stat and stats tests

For some reason we have both https://github.com/filerjs/filer/blob/master/tests/spec/fs.stats.spec.js and https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js.  We should probably just have https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js, since there is no stats method.
Let's move the stats tests into stat, and make sure we aren't duplicating any tests.

Hi @humphd, I would like to work on this issue.

OK @ApolllonDev, it's yours.


WIP Use cases for drogue cloud

Just a WIP with an idea for some example use cases. Currently only a high level description of each use case, but let's agree on the example use cases to present first. In every case I'd like to add:

An architecture diagram with the high level architecture of the Drogue Cloud deployment and additional services and the different environments where components are deployed
Modelling applications and devices in Drogue Cloud
A description of telemetry flow from device to application and back and the application logic
Describing additional services relevant to the use case like digital twin, edge workload management or firmware updates.

This looks great!
Is the "correct" way to generate the docs by using book.drogue.io and then make local?

@danbev Yes, that's the way. You need to have drogue-cloud and drogue-device (maybe also embassy) checked out in the same parent folder as book.drogue.io.


Include CPU Credit information for T2 instances

T2 instances have a special CPU Credits system which would be nice to include the info for: http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/t2-instances.html
Having this data may also allow us to provide better ECU estimates for these instances? (Related: #146)

Below is my understanding of how to compare between the different instance types within the T2 family, in terms of vCPU.  I don’t know how to compare vCPU to ECU, though, but this is a good start.
t2.nano: 5% vCPU baseline, burstable to 100% vCPU for up to 72 seconds
t2.micro: 10% vCPU baseline, burstable to 100% vCPU for up to 144 seconds
t2.small: 20% vCPU baseline, burstable to 100% vCPU for up to 288 seconds
t2.medium: 40% vCPU over 2 cores baseline, burstable to 200% vCPU for up to 288 seconds
t2.large: 60% vCPU over 2 cores baseline, burstable to 200% vCPU for up to 432 seconds
What do you think, is this a correct way to compare?  How would you present this information succinctly in the table?

My suggested presentation, (ab)using existing column names:

API Name
Compute Units (ECU)
Cores

t2.nano
5% vCPU
1 cores, 72 seconds burst

t2.micro
10% vCPU
1 cores, 144 seconds burst

t2.small
20% vCPU
1 cores, 288 seconds burst

t2.medium
40% vCPU
2 cores, 288 seconds burst

t2.large
60% vCPU
2 cores, 432 seconds burst

This is quite helpful, and I like the notion of measuring full-burst time for multicore t2 instances.
One small correction:  a credit gives a minute at full core use, not a second.

You are right, thanks!  I have amended both of the above comments accordingly.

This data would be great to add but I think we'd want some tooltips on these values explaining what they mean. Examples of tooltips can be seen on some of the existing column headers. Not sure if they'll support longer content well, but its worth looking at.

Based on the T2 section in https://aws.amazon.com/ec2/instance-types/, append to the Compute Units (ECU) tooltip, after a full stop: For T2 instances, the 100% vCPU unit represents a High Frequency Intel Xeon Processors with Turbo up to 3.3GHz..
Based on https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/t2-instances.html#t2-instances-cpu-credits, add a tooltip to Cores: For T2 instances, given that a CPU Credit represents the performance of a full CPU core for one minute, the maximum credit balance is converted to CPU burst minutes per day, simply by dividing it by the number of cores.
I have also edited the above comment, in case anyone uses it for reference (like I do.)
The remaining loose end is, where should the link to http://aws.amazon.com/ec2/instance-types/#burst go, since it is now linked from the word Burstable inside the table cells. It can probably move down to the Why? section, next to the instance type and pricing links.


Adds integration tests using WDS and Puppeteer

GitHub

Closes #7

Changes

Uses WDS and Puppeteer for integration testing
Integrates new set of tests into CI
Adds integration tests for currently present features (REST, request masking)
Adds command line utility to run a focused test using WDS (for debugging)

Roadmap

[x] Remove *.client.tsx modules and use page.evalate() for dispatching requests on the page
[x] *.mocks.ts cannot properly resolve the msw import on the TypeScript side (webpack compilation is valid)
[x] Resolve the spawnServer promise when webpack compilation finishes, not when the server is established (this results into browser window spawning sooner than the test scenario is built, awaiting the compilation)
[x] Configure Puppeteer to launch the browser on local in a head-full mode (on CI it must remain headless)

Test suites

[x] REST method-based handling of requests (GET matches, while POST doesn't)
[x] String / Mask / RegExp request URI matching
[x] All rest utilities (may be used in a single mock definition)
[ ] Assert the responses are real when MSW is disabled

Why WDS?
I've chosen webpack-dev-server (WDS) to grab a client-side example code and run a temporary server with it. This way I can keep isolated examples that also represent test suites. WDS is much more handy than an express server, as it deals with the compilation process automatically. It also accepts a webpack compiler, which I can configure to handle my client-side examples as I wish (for example, by aliasing the imports to msw module to the local built module).
Why Puppeteer?
I've considered the following technologies:

WebdriverIO (Selenium)
Cypress
Puppeteer

WebdriverIO
Felt like it's too low-level and I was writing a ton of boilerplate to get the trivial operations done. From my previous experience with Webdriver on another project I can conclude that it's quite flaky in certain scenarios.
Cypress
I love Cypress. I've been using it for almost all my client-side libraries at this point. I usually build a Storybook and navigate through it with Cypress, which proves to be a great experience.
For MSW, however, Cypress is too much setup for the value. Cypress also requires extra tweaks to support TypeScript in both its configuration and loaded modules, which Jest does in one line of configuration (ts-jest).
Puppeteer
I found Puppeteer being in a middle of Webdriver and Cypress: it ships with a useful high-level API and doesn't require to have any setup at all. It also comes with the built-in res.fromServiceWorker() that determines if a specific response was served by a Service Worker, which is what MSW needs to assert.

Resolve the spawnServer promise when webpack compilation finishes, not when the server is established (this results into browser window spawning sooner than the test scenario is built, awaiting the compilation)

Not going to resolve that, as it seems to create some race conditions and overall works okay with Puppeteer awaiting the build.

Configure Puppeteer to launch the browser on local in a head-full mode (on CI it must remain headless)

Should always run headless.

Assert the responses are real when MSW is disabled

Currently not possible to test reliably due to #58


clarify

closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8924
@dstrome please review thanks

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@dstrome Can you please review and merge? thanks


1.16 support

hello i tried the plugin on a spigot1.16.1 server but it is not working right.
when i type the commands they can autofill but when I hit enter nothiong happens.
but when I instal it in a 1.15 server it works perfectly.

Please upload your latest.log file from the logs folder to something like paste.gg so we can see what's wrong.

If you are using WorldEdit for the wand, ensure you are using their latest that supports 1.16. As for mv, use the latest dev builds http://ci.onarandombox.com/view/Multiverse/. Without any console logs or error message, we can't really diagnose the issue much, so I will be closing it. You can join our discord  https://discord.gg/NZtfKky or create a new issue with more detailed explanation of your issue


Add macOS DS_Store ignore

(Proposing same PR in Meadow.Logging, Meadow.Units, and Meadow.Contracts.)
Might be worth using a more extensive Visual Studio-style .gitignore, but this will prevent any Mac folks from accidentally adding the OS-generated .DS_Store files.
We have something similar in other repos, but I think this single-line version might be sufficient. (It's what they use in most of the .gitignore samples.

Didn't target upstream repo


FIX: Fix slow test

Forgot to add the changes of #1545 so that the text will run the correct command
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


(chores) ci: remove the checkstyle stage

The code is now auto-formatted by default and this prints a lot of bogus output

Context: https://camel.zulipchat.com/#narrow/stream/364655-camel-v4-work-in-progress/topic/Camel.20v4.20.28help.20wanted.29/near/381502661


[Bug fix] Simplify fetching the spot attribute on the list method of machine groups

This PR tackles the bug encountered in inductiva/tasks#39, where the spot attribute was being fetched for MPICluster machines, which it doesn't have.
Correct it, with a quick check.
QA Test:
To validate if this error was fixed, users could launch some MPI machines and do, both:

inductiva machines list in the terminal;
inductiva.machine_groups.list() in Python.

QA Test ✅
Launched with:
import inductiva

mg = inductiva.resources.MPICluster(
    machine_type="c2-standard-16",
    num_machines=3,
    disk_size_gb=70,
)
mg.start()

And obtained the logs:
2024-01-19 14:29:58 INFO Registering machine group configurations:
2024-01-19 14:29:59 INFO > Name: api-h0t2jmab4bkz3tqt3n3d9k16d
2024-01-19 14:29:59 INFO > Machine Type: c2-standard-16
2024-01-19 14:29:59 INFO > Disk size: 70 GB
2024-01-19 14:29:59 INFO > Number of machines: 3
2024-01-19 14:30:00 INFO Estimated cloud cost of the MPI cluster: 2.756 $/h
2024-01-19 14:30:00 INFO Starting machine group. This may take a few minutes.
2024-01-19 14:30:00 INFO Note that stopping this local process will not interrupt the creation of the machine group. Please wait...
2024-01-19 14:30:32 INFO Machine group successfully started in 0:00:32.

The commands inductiva machines list and inductiva.resources.machine_groups.list() yield:
Active machine groups:
                         Name       Machine Type    Elastic       Type   # machines    Disk Size in GB       Spot   Started at (UTC)
api-h0t2jmab4bkz3tqt3n3d9k16d     c2-standard-16      False        mpi            3                 70      False   19 Jan, 14:30:02

Active machine groups:
                         Name       Machine Type    Elastic       Type   # machines    Disk Size in GB       Spot   Started at (UTC)
api-h0t2jmab4bkz3tqt3n3d9k16d     c2-standard-16      False        mpi            3                 70      False   19 Jan, 14:30:02


Sorting Visualizer

👨💻 Changes proposed and Brief Description

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Added the program of sorting visualizer

📷 Screenshots

@AbhineshJha Thanks for your contribution! Excited for more in the future! 🥂


Plates engine dependency injection not working

Hello, i am triying to get plates to work but i am having a bit of troubles. When i implement plates without dependency injection works great. With dependency injection plates output this error:
Catchable Error: Argument 1 passed to App\Controllers\Site::__construct() must be an instance of League\Plates\Engine, none given, called in F:\xampp\htdocs\sistema\vendor\league\route\src\Route.php on line 67 and defined in F:\xampp\htdocs\sistema\app\controllers\Site.php on line 19
My code:
namespace App\Controllers;

use League\Plates\Engine as PlatesEngine;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

class Site
{

    private $templates;
    private $templates2;

    public function __construct(\League\Plates\Engine $templates2)
    {

        $this->templates2 = $templates2;

        // No dependecy injection and working
        $this->templates = new \League\Plates\Engine();
        $this->templates->loadExtension(new \League\Plates\Extension\Asset('app/assets', true));
        $this->templates->addFolder('site', 'app/views/site');
    }

}

Win10 x64, XAMPP, PHP 5.6.21
"league/route": "^2.0",
"league/plates": "^3.1.1",
"zendframework/zend-diactoros": "^1.3",

This is an issue with your dependency injection. You need to configure your DI library to automatically detect and resolve dependencies or you need to configure the Site in your DIC to inject the Engine.

league/route uses league/container under the hood. You should be able to resolve this by either manually registering the Engine class to the container, or by enabling the ReflectionContainer as a delegate (more info here).

@bastienff definitely seems like this is not a Plates issue, can we close this?

Closing this because it is unrelated to the Plates project itself and is a question regarding automatic dependency injection.

Estou com o mesmo problema ao utilizar o plates


Reloaded Pharo.image does not have icons

Reloaded Pharo.image does not have icons. Icons theme is not initialized well.
The old versions of building scripts placed icons into the working directory:
mkdir icon-packs
cd icon-packs
wget http://github.com/pharo-project/pharo-icon-packs/archive/idea11.zip
cd ..

fixed in 95d368fdad0c2fda64ab97af8ef3f5df1d781cee


Implement file-picker UI

We should be able to pass this component a path as the "initial location"

The file picker should be able to show all available partitions of a drive a user could go to.

Closed by https://github.com/resin-io/etcher/pull/2333, https://github.com/resin-io/etcher/pull/2349 and https://github.com/resin-io/etcher/pull/2350

I guess this also connects to #1823 ?  (and #2362 )


market list: dropdown for market count is mis-styled

this style needs to be fixed

should look like

styles are in pagination.styles.less file

This is already fixed.


Compile time check that tests are actually executing workflows

In @dewetblomerus recent examples of anti-patterns and something we've run into while using Pacer, is that sometimes in tests the workflow isn't actually executed and nothing is being asserted on.
We can avoid this anti-pattern by writing this into pacer by making a compile time check that confirms we're always executing the workflow we're testing.

I like this. But I would not spend a ton of time on it.
A compile-time check to see that any other module's public functions were executed during a test is not something I've heard of.
What if Pacer.Workflow.execute was a private function to the workflow? (this would absolutely be a breaking change)
This would force you to provide a public function that calls the workflow, and leaving that untested would be more glaring and obvious.


Is it possible to update multiple .json files using extra-files?

Our team's projects typically have both a package.json (for our javascript, sass elements) and composer.json (for our PHP dependencies) within the root of our projects. We're trying to bump both the main "PHP" project's composer.json as well as a package.json (within our extra-files).

What code you've already tried
Utilized the package.json within the extra files command though extra files only utilize the generic updater but this won't work due to JSON files not allowing comments

Any error messages you're getting
No errors, the package.json is simply ignored.

I tried to do a quick github search but didn't see any projects doing this, which I thought was interesting as I didn't think we were doing anything out of the ordinary.
Any shove in the right direction would be greatly apprecaited

If you're using a manifest config, you can specify a generic JSON file updater: https://github.com/googleapis/release-please/blob/main/schemas/config.json#L123-L141. This was implemented in #1332
Example:
{
  "packages": {
    ".": {
      "extra-files": [
        {
          "type": "json",
          "path": "composer.json",
          "jsonpath": "$.version"
        }
      ]
    }
  }
}

Is there any comprehensive guide about how to setup this in the github action? I find having to ping-pong through the cli and gothub action docs very confusing,  and I don't want to install any CLI just to setup my CI


Text should implement Eq

We were sort of discussing this here at #155
I've finally gotten to writing tests for a project I'm working on right now and comparing the colors styles as well as the text in the text enum would be really handy.

Update: Making structs with Text types is also a bit of a nuisance because they can't implement Debug, which means I end up adding custom to_string() methods for structs with Text fields.

I'm still not sure about the use case there. Since your project is public could you point me to some code that might be improved if that was the case ?

Sure. My project is a terminal game that mimics typeracer.com You can see a short example here if you'd like: https://asciinema.org/a/hEcf1pD2v60wUxiSIHdFWs5zN
Unlike most terminal programs where coloring is an enhancement, the bulk of the game revolves around properly coloring terminal output so the user knows when there's an error.
Most of the logic that makes it happen is in a method here: https://gitlab.com/DarrienG/terminal-typeracer/blob/master/src/game/mod.rs#L103 which while isn't too complicated, it hairy enough that it should definitely have a few tests. It's output ends up being a set of formatted texts.
A few good tests would reassure users and contributors (and myself) that they aren't breaking anything if they mess with the code.
You can compare RGB objects with Termion but I'd rather not lock myself into a backend if I can help it.
Side note: I think PartialEq might be good enough. It's worth noting I'm still pretty new to rust, so I'm not fully aware of all of the differences and intricacies.

Alright I get it now =). I just added PartialEq to Text in master. Let me know if that helps you write your tests.

Thanks so much :)

This works great! Thank you!

We're looking to release the binary on crates.io, but are still reliant on pulling from HEAD for partialEq for tests. Do you think you could make a release for this?

I've made this change available in v0.6.2. Sorry, I should have released this sooner =)

No worries, thanks a bunch!


Use a configuration object when creating terminals via API

In order to avoid issues with parameter order and addition options in the future, factor out the terminal configuration and use that in window.createTerminal (similar to the config object used in setLanguageConfiguration).
Old: createTerminal(name?: string): Terminal
New: createTerminal(configuration: TerminalConfiguration): Terminal
FYI @jrieken

No - we don't go complex first but handle the situation (with an overload) if case it ever arises.

The need has arisen, a shell path will need to be added for this to be useful for a lot of people #10917. See https://github.com/Microsoft/vscode/issues/11214#issuecomment-244157685

Another one #11384

Reverted in https://github.com/Microsoft/vscode/commit/7bd499af9bc2b210b1faa499f9af5ed7cdf1af48


feat: Infer credentials for Provider from JSON/ENV

Goal
When constructing connector field readers should be automatically infered from the provider information. Catalog has all information that we need.
Changes
Any credential registry files moved under credsregistry package.
Select provider from the catalog that matches provider name from ENV or JSON file. Then create list of fields that are required. Example: oauth2 then for sure clientID+clientSecret. If basic auth then username+password.
The field names in JSON(or ENV vars) will be consistent and hence meet expactations when dealing with any connector. (as of now only DynamicsCRM is adapted).
Example DynamicsCRM
	filePath := credsregistry.LoadPath(providers.DynamicsCRM)
	reader := utils.MustCreateProvCredJSON(filePath, true) // all field readers are automatically added

	conn, err := dynamicscrm.NewConnector(
                // construction of oauth token is no longer repetative
		dynamicscrm.WithClient(ctx, http.DefaultClient, getConfig(reader), reader.GetOauthToken()),
		dynamicscrm.WithWorkspace(reader.Get(credsregistry.Fields.Workspace)),
	)

@Cobalt0s  I was waiting on upstream PR https://github.com/amp-labs/openapi/pull/15/files which seems to be closed after @laurenzlong  reviewed this. Can you modify this PR to reflect that as well? Feel free to ping me on slack after you modify the PR.

I will remove myself from this reviewer list. You can add me back after modification.

@jlimatampersand, I replaced a todo with a comment. See commit: https://github.com/amp-labs/connectors/pull/668/commits/c6ef634660eff80533dda819ee77bc59feb6b245
I think when this change will happen a person removing ExplicitWorkspaceRequired will end up reading of what is needed from that part of code.

#668  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite

Running lint locally and clearing cache by running golangci-lint cache clean still succeeds :man_shrugging:

@jlimatampersand can you please re-review?

Feel free to merge after fixing the line errors.


TEST: limit pypy to 2 verbose runners, fix numpy install

PyPy seems to run 92% of the tests and randomly fail. I cannot reproduce this locally. The circleCI instances are limited to 4GB. This PR

reduces the number of parallel test runs to 2 in the hope that the crashes are due to MemoryError
adds -v to hpoefully output more information about why the crash, and
moves the numpy pip install to the line with the PyPI repo for the numpy wheels, so installating numpy from the wheels not from source

Note the instance seems to have 2 cpus, so limiting the parallel runs to 2 should not slow down the overall runtime of the tests

It passed, so I restarted it. I'll try to do it a few times to see if we can get it to (not) fail reliably.

Currently on the fifth restart without problem, so I'm cautiously optimistic!

Good to go?

Fingers crossed :) Thanks Matti.

Sorry for the frustrations, and thanks for keeping this going


Improve formatting

This PR aims to improve the formatting of the output so that it works with, more or less, any terminal theme. It should resolve the issues reported in tldr-pages/tldr#388. I’ve tested it with several different themes myself. See the attached screenshots.
It also makes the output be closer to that of the Node.js client, i.e. adding the title to the output. Very similar to the changes in tldr-pages/tldr-node-client#39.

Before
Tomorrow Night theme

Solarized Light

Light theme (standard in iTerm 2)

After
Tomorrow Night theme

Solarized Light

Light theme (standard in iTerm 2)

Looks good to me! :+1:

:+1:


Backward compatibility changes to allow the code to still build with UE 5.1

Added some #if's to allow the code to compile in 5.1 (assuming the flow.uplugin target is locally set to 5.1)

will try again


Regression: Log default values

See my comment in pull request #10 :

Instead of commenting out the code, I would like you to make the code use what corresponds to our default values. So, if ShowGazeDot by default is true, replace private Toggle showGazeDot; with private bool showGazeDot = true; and fix the code references accordingly. We still intend LoggingManager to log these values.

This issue was resolved in pull request #14 . 🐭


CI fixes

@ganeshrn it looks like something is wrong with EE and MacOS.

@goneri The macos ci job is flaky and fails intermittently. We can ignore that failure.

@goneri Thanks for working on this.


[auto-sync] 2021-05-30 06:33 UTC

This PR is created via a script automation and CI.
It use the owner account to execute it, please ignore it.

Missing finalized command, whoops


PIP branch not working

Seems to not show on any of the builds

Can you clarify this? Are you seeing an error message? Let me know how I can help further to resolve this issue.

the app-pip branch contains no pip

Look at https://github.com/googlesamples/androidtv-Leanback/pull/66

you can close


Make Tensor.broadcast(toShape:) public

Previously we have Tensor.broadcast(to:) which takes a TensorShape. However, in expressions like x.broadcast(to: y.shape), there's a conversion chain that the compiler isn't yet able to eliminate: Tensor<Int32> -> TensorShape -> Tensor<Int32>, and it requires send/receive. Before guaranteed promotion is possible, we need the tensor-only version of this op.

@swift-ci please test tensorflow

@swift-ci please clean test tensorflow


Size and nature of the dataset.

I have a 25451 images in the train and 2000 images in the test set. The problem I am facing is the train and validation loss is high in every epochs. In my dataset a few images are of plates with two lines. So I would like to get a suggestion about the dataset size and it's nature. TIA

Hi @Sreerag-ibtl,
In my opinion, the number of dataset is small. because i tested this problem, i've solved this problem with  number of large dataset. around 500k images.

Thanks for the reply. I have a fair amount of synthetic images. I tried a different implementation of the CRNN a while ago, with those. But the prediction was not better.


Update minikube to support rancher/kim

The new minikube installs k3s into the default location at /var/lib/rancher/k3s and also uses the bundled containerd.
minikube will still install/run it's own containerd, but it will not be used for anything; just sitting idle.
This should enable work on #155 on macOS.
$ ./kim images
WARN[0000] Cannot find available builder daemon, attempting automatic installation...
INFO[0000] Applying node-role `builder` to `rancher-desktop`
INFO[0000] Asserting namespace `kube-image`
INFO[0000] Asserting TLS secrets
INFO[0000] Asserting service/endpoints
INFO[0000] Installing builder daemon
INFO[0000] Waiting on builder daemon availability...
INFO[0006] Waiting on builder daemon availability...
INFO[0013] Waiting on builder daemon availability...
IMAGE               TAG                 IMAGE ID            SIZE
moby/buildkit       v0.8.1              d877bfa959899       55.2MB
rancher/kim         v0.1.0-alpha.9      4a2d13f1add5c       12.6MB

I've tested that building images works as well.

I assume the diff is then<EMAIL_ADDRESS>
Yes. It is a quick hack; we are going to drop this soon anyways...

I… don't care enough about this code right now to complain :)

What is there to complain about? 👅


[Bug] Internal server error:... (0 , _genMapping.maybeAddMapping) is not a function Plugin: vite:react-babel

What version of vite are you using?
3.2.4
System info and storybook versions
"react": "17.0.2",
"react-dom": "17.0.2",
"@storybook/addon-actions": "^6.5.14",
"@storybook/addon-essentials": "^6.5.14",
"@storybook/addon-interactions": "^6.5.14",
"@storybook/addon-links": "^6.5.14",
"@storybook/addon-react-native-web": "^0.0.19",
"@storybook/builder-vite": "^0.2.5",
"@storybook/react": "^6.5.14",
Describe the Bug
Using Storybook for a UI-Component library as part of a mono-repo, using react-native and react-native-web for cross compatibility:
main.js
module.exports = {
  core: {
    builder: "@storybook/builder-vite",
  },

  stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    {
      name: "@storybook/addon-react-native-web",
      options: {
        modulesToTranspile: ["react-native-reanimated"],
        babelPlugins: ["react-native-reanimated/plugin"],
      },
    },
    "@storybook/addon-actions",
    "@storybook/addon-interactions",
  ],
  framework: "@storybook/react",
  async viteFinal(config) {
    return mergeConfig(config, {
      resolve: {
        extensions: extensions,
        alias: {
          "react-native": "react-native-web",
        },
      },
      optimizeDeps: {
        esbuildOptions: {
          loader: { ".js": "jsx" },
          resolveExtensions: extensions,
        },
      },
    });
  },
};

Was working fine a few weeks ago when I finished off the config, but now I'm trying to launch storybook just in dev mode, and get an error from every stories file in project:
./packages/ui-components/.storybook/decorators.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Alertbox/AlertBox.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Button/Button.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Checkbox/Checkbox.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Card/Card.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/FieldLabel/FieldLable.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Chip/Chip.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Icon/icon.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/ListTable/ListTable.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/PageHero/PageHero.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
./packages/ui-components/src/components/Timeline/Timeline.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function

which from what I can discover is a function that is needed in the generation of the source maps  (0 , _genMapping.maybeAddMapping) is not a function, and bubbles up from a long way down.
16:01:21 [vite] Internal server error: ./packages/ui-components/src/components/Alertbox/AlertBox.stories.tsx: (0 , _genMapping.maybeAddMapping) is not a function
  Plugin: vite:react-babel
  File: ./packages/ui-components/src/components/Alertbox/AlertBox.stories.tsx
      at SourceMap.mark (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/source-map.js:45:37)
      at Buffer._mark (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/buffer.js:185:60)
      at Buffer._append (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/buffer.js:168:12)
      at Buffer.append (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/buffer.js:97:10)
      at Generator._append (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:197:15)
      at Generator.word (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:100:10)
      at Generator.VariableDeclaration (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/generators/statements.js:241:8)
      at Generator.exactSource (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:169:22)
      at Generator.print (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:347:10)
      at Generator.printJoin (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:409:12)
      at Generator.printSequence (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:472:17)
      at Generator.Program (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/generators/base.js:34:8)
      at Generator.exactSource (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:169:22)
      at Generator.print (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:347:10)
      at Generator.File (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/generators/base.js:17:8)
      at Generator.exactSource (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:169:22)
      at Generator.print (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:347:10)
      at Generator.generate (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/printer.js:49:10)
      at Generator.generate (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/index.js:21:18)
      at generate (./node_modules/@vitejs/plugin-react/node_modules/@babel/generator/lib/index.js:84:14)
      at generateCode (./node_modules/@vitejs/plugin-react/node_modules/@babel/core/lib/transformation/file/generate.js:46:39)
      at run (./node_modules/@vitejs/plugin-react/node_modules/@babel/core/lib/transformation/index.js:39:33)
      at run.next (<anonymous>)
      at transform (./node_modules/@vitejs/plugin-react/node_modules/@babel/core/lib/transform.js:22:41)
      at transform.next (<anonymous>)
      at step (./node_modules/gensync/index.js:261:32)
      at ./node_modules/gensync/index.js:273:13
      at async.call.result.err.err (./node_modules/gensync/index.js:223:11)
      at ./node_modules/gensync/index.js:189:28
      at ./node_modules/@vitejs/plugin-react/node_modules/@babel/core/lib/gensync-utils/async.js:72:7
      at ./node_modules/gensync/index.js:113:33
      at step (./node_modules/gensync/index.js:287:14)
      at ./node_modules/gensync/index.js:273:13

There isn't type errors or anything in that story file, it's actually quite simple:
import { ComponentStory, ComponentMeta } from "@storybook/react";
import { Text } from "@kolmeo/ui-core";

import AlertBox from "./";

export default {
  title: "Components/AlertBox",
  component: AlertBox,
} as ComponentMeta<typeof AlertBox>;

const Template: ComponentStory<typeof AlertBox> = (args) => <AlertBox {...args} />;
export const Default = Template.bind({});
Default.args = {
  variant: "warning",
  content: <Text>This is an Alert Box</Text>,
};

I tried adding plugins: [react()] because I thought it needed it based on the vite:react-babel part, but that just threw the error that I'd doubled it up. Do I need to add settings for babel somehow? I thought the point of vite was to get rid of some of that overhead?
We are using react-native for the components, and they transpiling them with react-native-web for browsers and for storybook, which has caused errors in the past but any errors relating to them have been fixed and this remains.
As I said at the top, it is part of a mono-repo, so maybe a dependency could be the issue, but with the error coming from plugin-react is there a way to track down the issue.
Unfortunately I can't create a minimal example as it's tightly linked to corporate code.
Link to Minimal Reproducible Example
No response
Participation

[ ] I am willing to submit a pull request for this issue.

Hm, is it possible that something has been updated since the last time it was working?  What version is @vitejs/plugin-react in your project?
The react vite plugin uses babel for fast-refresh, and in vite 3 (vitejs/plugin-react 2) it also transforms jsx.
When I hit strange errors like this, sometimes re-generating my lockfile resolves conflicts between different versions, which is kind of what this seems like to me.
the other option you could try is to upgrade to storybook 7, which is now in beta.  It automatically uses your vite.config.js, which can make it easier to keep your application and storybook in-sync.

yarn list @vitejs/plugin-react shows<EMAIL_ADDRESS>which would be a sub-dependency because it's not actually in the package.json. Do you think if I added a different version and then did a resolution it would work?
I'm always hesitant to regenerate the lockfile, as there are a few other products in the repo using it, which I don't really interact with so don't know what's going on there.
I was thinking I might just move to Storybook 7, as I won't be needed to deploy it to a production instance for at least 5 months. Then I can share the vite config between SB and another web app that I'll use vite for as well

Yes if you can try out an upgrade to 7.0 I would suggest giving that a try. Let me know if it's still broken afterwards. You could also try regenerating the lockfile to see if it fixes it, and just not check it in. Could help as a troubleshooting step at least.

@IanVS could you suggest the best command to upgrade to a good version of SB7?

Yep, that's the command.

Does somewhere in builder-vite force setting allowSyntheticDefaultImports or esModuleInterop to true regardless of the tsconfig?
That is probably the problem if the project is using Node16 or NodeNext. Those setting must be off on those cases. I'm hitting similar issue.


feat: add WinSeperator highlight group

Fixes #622

@Rishabh672003 Thanks for the report. Could you test this PR on your neovim setup?

Had this issue in v0.10.0-dev-7908dc0d155. Thanks for a hotfix.


does not contain a CMakeLists.txt file

I tried running the example code given in the dev/3.0.0 branch. I was able to run the example on Android and iOS but when I tried building it for Linux I got the following error message:

Launching lib/main.dart on Linux in debug mode...
CMake Error at flutter/generated_plugins.cmake:12 (add_subdirectory):
  The source directory

    /home/m3h3r/noob-stuff/flutter-projects/Flutter-SDK/example/linux/flutter/ephemeral/.plugin_symlinks/agora_rtc_engine/linux

  does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
  CMakeLists.txt:48 (include)

Building Linux application...
Exception: Unable to generate build files

Here is the output of my flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, 1.21.0-1.0.pre, on Linux, locale en_IN)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.46.1)
[✓] Connected device (4 available)

• No issues found!

sorry, we don‘t support Linux now.


rename much-plugin to much-mixin

This is a more straightforward name and uses idiomatic Ruby
terminology. It is easier to explain what it does.

Thanks for that nudge back in the day @pdobb!

Thanks for that nudge back in the day @pdobb!


Player quests data (progress) is not saving after server restart

What is your Quests version / build number (do not say "latest")?
5.0.0-rc.2
Describe the problem and how to replicate it.
Quests log player data is not saving quest progress and is wiping after the server is restarted.
Any console errors to share?
none

If applicable, can you provide an example quest from quests.yml?
N/A

Thanks for the report. An example quest you know had been wiped would also help.

There are no quests being wiped. The quests themselves are fine. Lile I
stated, the player data is being reset. So it is not saving quest progress
for the players.
On Fri, Dec 8, 2023, 6:37 PM PikaMug @.***> wrote:

Thanks for the report. An example quest you know had been wiped would also
help.
—
Reply to this email directly, view it on GitHub
https://github.com/PikaMug/Quests/issues/2170#issuecomment-1848098142,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGA36FZJWQ2PS46VQEOH43YIPFG5AVCNFSM6AAAAABANML43CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYGA4TQMJUGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I mean, a quest that the player had in-progress or completed before their data was reset.

Every single quest gets wiped. but here is one of the 79 quests in the game. All of the quests work. just the player progress is not being saved after server restart
custom10:
name: The Hunters
ask-message: I belong to a group called "the Hunters". You should join us! Talk
to our leader at the Wild Life Preserve to the west.
finish-message: Welcome to the Preserve! We hunt monsters to protect the innocent
creatures of this world!
npc-giver-uuid: 146269aa-42c6-41c4-abb0-83a150f047d8
gui-display:
==: org.bukkit.inventory.ItemStack
v: 3465
type: BOW
stages:
ordered:
'1':
locations-to-reach:
- world -517.0 70.0 -231.0
reach-location-radii:
- 10
reach-location-names:
- Hunting Grounds Tunnel
start-message: You can find the entrence to the preserver at -514 71 -231
complete-message: Well done! Following simple instructions is key to becomeing
a Hunter! Go talk to Hunter Morty
'2':
npc-uuids-to-talk-to:
- 48d82932-560d-4ca2-bbce-f70ed09a5539
complete-message: erase
rewards:
money: 50
planner:
override: false
options:
allow-commands: true
allow-quitting: true
ignore-silk-touch: true
use-parties-plugin: true
share-progress-level: 1
same-quest-only: true
share-distance: 0.0
handle-offline-players: false
ignore-block-replace: true

I'll proceed under the assumption that you have verified the quest was active or completed when the player's wipe occurred.

Yes, please proceed. That is correct. I myself has tested this many times.
Completed several quests only for it to be wiped the next day after I had
to restart the server for a fix (not related to the quests)
On Sat, Dec 9, 2023, 3:13 PM PikaMug @.***> wrote:

I'll proceed under the assumption that you have verified the quest was
active or completed when the player's wipe occurred.
—
Reply to this email directly, view it on GitHub
https://github.com/PikaMug/Quests/issues/2170#issuecomment-1848776891,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGA36CF3VXRTZYR4NXU6DDYITWCNAVCNFSM6AAAAABANML43CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYG43TMOBZGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you so much for any help!
On Sat, Dec 9, 2023, 3:13 PM PikaMug @.***> wrote:

I'll proceed under the assumption that you have verified the quest was
active or completed when the player's wipe occurred.
—
Reply to this email directly, view it on GitHub
https://github.com/PikaMug/Quests/issues/2170#issuecomment-1848776891,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGA36CF3VXRTZYR4NXU6DDYITWCNAVCNFSM6AAAAABANML43CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYG43TMOBZGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I haven't been able to replicate this, but 5.0.0-rc.3 fixes two bugs which could theoretically contribute to this issue. Please upgrade and, if this happens again, simply reply to re-open the issue.


Filter event handler firing twice when clicking icon?

Might be some shenanigans with event capture/bubbling

Resolved by 13206d6675360b9ceabc831d5fa80ad40b6e3fc0
The issue was that the icon was being targeted by the click, rather than the button. I used e.currentTarget to actually target the button with the event handler


Introduce multi-touch drag strategies for DragGestureRecognizer

Fixes #11884
As #38926 pointed out, the current Flutter implementation of multi-finger drag behavior is different from iOS and Android.
This change introduces the MultitouchDragStrategy attribute, which implements the Android behavior and can be controlled through ScrollBehavior, while retaining the ability to extend iOS behavior in the future.

Filed https://github.com/flutter/flutter/issues/139333 to follow up on the migration guide. I should be able to whip that up tomorrow.


K3s documentation update

sudo commands are removed from tutorial
Operator verification added to the page
@lxpollitt

Deploy preview for calico ready!
Built with commit 6511273c8e29a13c5e01ed2c735c1f783d8352b7
https://deploy-preview-3759--calico.netlify.app

Thanks to @bmckercher123 for trying tabs out and give me a feedback, element ids are generated by the plugin in this update.
There is also a new feature that can group tabs together.
You can view linked tabs in action here
Normal tab example :
If you don't provide a name for your tab, plugin will assign randomly generated tab id as its name.
{% tabs %}
<name:Mytab,active:true>
<% Content %>
{% endtabs %}
Linked example
{% tabs %}

Linked tab example:
{% tabs %}
<name:Mytab,tab-linked-groups:1,active:true>
<% First awesome tab 1 %>
<name:Mytab,tab-linked-groups:2,active:true>
<% First awesome tab 2 %>
<name:Mytab,tab-linked-groups:3,active:true>
<% First awesome tab 3 %>
{% endtabs %}

{% tabs %}
<name:Mytab,tab-linked-groups:1,active:true>
<% Second awesome tab 1 %>
<name:Mytab,tab-linked-groups:2,active:true>
<% Second awesome tab 2 %>
<name:Mytab,tab-linked-groups:3,active:true>
<% Second awesome tab 3 %>
{% endtabs %}

{% tabs %}
<name:Mytab,tab-linked-groups:3,active:true>
<% Third awesome tab 1 %>
<name:Mytab,tab-linked-groups:1,active:true>
<% Third awesome tab 2 %>
<name:Mytab,tab-linked-groups:2,active:true>
<% Third awesome tab 3 %>
{% endtabs %}


internal/providers/azure: add support for ssh keys

This PR adds support for fetching the user's ssh key in azure
Not ready for merge yet.

I have to say I'm not super happy about having exec-wrappers around openssl and ssh-keygen and feeding them (plaintext) network input. Is there any reason for not using go crypto&codec primitives from stdlib?

There isn't a strong reason for using exec-wrappers other than this is how the waagent works, and it took me less work to implement it here the same way it works in waagent than to work through how to do this in pure go. I wouldn't be opposed to spending the time on switching over to the golang stdlib, but I can't say how much time it would take me to figure that out.

it took me less work to implement it here the same way it works in waagent than to work through how to do this in pure go

I'm not interested in work being done unless it's being done correctly. Please investigate doing it properly.


Spelling mistake

Hi,
there is a spelling mistake in the following sentence within the M365 section: gorup should be group.
OLD: Note that Members can invite refers to members in Azure AD (as opposed to guests) and not to site or gorup members in Microsoft 365.
NEW: Note that Members can invite refers to members in Azure AD (as opposed to guests) and not to site or group members in Microsoft 365.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6bb31720-7494-ab3f-6a3d-5c395649e75d
Version Independent ID: 81c36ae8-fbaa-c411-4bd2-a4db98e249e1
Content: Microsoft 365 guest sharing settings reference
Content Source: Enterprise/microsoft-365-guest-settings.md
Service: o365-solutions
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@9songs - Thank you for submitting feedback.
PR #591 has been created to fix and close this issue once the PR is merged.
Thank you and we appreciate your contribution to make the docs better!


Decide on DHT implementation

Right now I'm mostly familiar with the Chord implementation, but there are others which could potentially be better suited for the task. I'm going to use a todo list here, but whenever an implementation is decided to be not sufficient, I'll tick it off and post an accompanying reason.

[ ] Chord
[ ] Kademlia
[ ] Pastry
[ ] Tapestry

Kademlia seems unnecessary given that the implementation focuses much on healing the network. This would be great for whenever rapid joins/parts are an expected part of the program/service, but given that I'm wanting to add services and almost never drop them, it seems unnecessary.

Using chord.


PopupBox mouse capture fix

Bug reproducible with the demo. Go on buttons tab. Click on the three dots (options) click on it again. Then you can't click on anything anymore.

:+1:


Go through all spring samples to make sure the resources created by them should add same custom tags

This is Spring sample list.
We should add custom tags by terraform, so we can track how many resources created by spring samples.
Besides, we also should add custom tags when azd template publish.

@fangjian0423  Could you explain more about this?
I remember we have added several tags by using terraform.

I created a work item in ADO.

Spring Cloud Azure 4.x PR https://github.com/Azure-Samples/azure-spring-boot-samples/pull/601

Spring Cloud Azure 6.x PR https://github.com/Azure-Samples/azure-spring-boot-samples/pull/602


Xray Mesos DC/OS

Has anyone already developed a Mesos DC/OS marathon configuration for Xray?

Closing due to inactivity


[HUDI-7190] Fix nested columns vectorized read for spark33+ legacy formats

Change Logs
For Spark3.3+ version, we can do vectorized read for nested columns. However when
spark.sql.parquet.enableNestedColumnVectorizedReader = true and
set spark.sql.parquet.enableVectorizedReader = true is set, hudi will throw the following exception:
Job aborted due to stage failure: Task 0 in stage 28.0 failed 1 times, most recent failure: Lost task 0.0 in stage 28.0 (TID 51) (<IP_ADDRESS> executor driver): java.lang.ClassCastException: org.apache.spark.sql.catalyst.expressions.UnsafeRow cannot be cast to org.apache.spark.sql.vectorized.ColumnarBatch
	at org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.next(DataSourceScanExec.scala:560)
	at org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.next(DataSourceScanExec.scala:549)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.columnartorow_nextBatch_0$(Unknown Source)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
	at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:760)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:364)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:890)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:890)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:365)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:329)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:136)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

Driver stacktrace:
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 28.0 failed 1 times, most recent failure: Lost task 0.0 in stage 28.0 (TID 51) (<IP_ADDRESS> executor driver): java.lang.ClassCastException: org.apache.spark.sql.catalyst.expressions.UnsafeRow cannot be cast to org.apache.spark.sql.vectorized.ColumnarBatch
	at org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.next(DataSourceScanExec.scala:560)
	at org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.next(DataSourceScanExec.scala:549)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.columnartorow_nextBatch_0$(Unknown Source)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
	at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:760)
	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:364)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:890)
	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:890)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:365)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:329)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:136)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

We need to Fix Spark33LegacyHoodieParquetFileFormat/Spark34LegacyHoodieParquetFileFormat/Spark35LegacyHoodieParquetFileFormat  vectorized read nested types
Impact
We can do correct vectorized reading for nested types when using legacy parquet formats.
Risk level (write none, low medium or high below)
LOW
Documentation Update
NONE
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[ ] CI passed

@stream2000 : Just checking if you are still working on the tests ?

Sorry for the late reply, I was busy with other stuff. Will fix the test ASAP.

@hudi-bot run azure

@danny0405 @yihua @xiarixiaoyao Hi, could you help review this pr~


Fix - Implicit memory aliasing in for loop

Added a fix for this issue reported by gosec. This issue occurs when re-using the same address multiple times in a loop.

LGTM!, Did you get chance to test this by updating the secret?

Yes, change in secret leads to pod restarts as it was earlier.


Give Container a GameObjectFactory?

I was experimenting with using containers as layers in my scene and it started to feel like it'd be very nice if Container was also a GameObjectFactory. For example, I found myself writing this sort of code:
    hudLayer = this.add.container().setScrollFactor(0)
    hudLayer.add(this.add.image(0, 0, 'hud-frame').setOrigin(0, 0))

And it would be nicer to to able to write it this way instead (not to mention it avoids adding the object first to the scene and then moving it to the container later):
    hudLayer = this.add.container().setScrollFactor(0)
    hudLayer.add.image(0, 0, 'hud-frame').setOrigin(0, 0)

I looked into using GameObjectCreator functions instead, but many of those function signatures differ from the GameObjectFactory signatures in that they only take configuration objects. Even if I adapted everything to use those, it still wouldn't read as cleanly as it would if Container had a GameObjectFactory like the scene does.

I quite liked this idea, but it's a big change to make this far into Phaser's life, so I'm afraid I'm going to close it off to try and tidy things up around here!


Inbox pending.

Finally i did it.
To be honest, i did not test it with second page, because i have not so much requests :)
I did not succeed to start test because of imageDiff error
Unhandled rejection Error: Could not execute GraphicsMagick/ImageMagick: identify "-ping" "-format" "%wx%h" "/Users/dilame/Projects/instagram-private-api/tests/tmp/downloaded.jpg" this most likely means the gm/convert binaries can't be found
    at ChildProcess.<anonymous> (/Users/dilame/Projects/instagram-private-api/node_modules/image-diff/node_modules/gm/lib/command.js:299:14)
    at emitOne (events.js:96:13)
    at ChildProcess.emit (events.js:188:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:213:12)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

I tried to install graphicsmagick and imagemagick. Did not help. I was forced to use a gag
return Promise.resolve({percentage:0});

to  bypass this error. Are you sure this test is necessary?
And one more question.
Why are you rewrite original instagram responses? This increases the barrier to entry into this lib.
For example,
hash.created = parseInt(json.timestamp / 1000);

why? I spent around 15-20 minutes to figure out what happened, where is timestamp.
This lib have no documentation, and in this case will be better at least not to rewrite original fields, just copy it with more suitable names in your opinion.

Good job man!
Are you sure this test is necessary? YES. Every test is necessary. And more of them better.
Why are you rewrite original instagram responses? For convenience, not all params which coming from instagram make sense, and lot of them has meaning just for app doesn't really make sense have them in API, just like you would not be able to manage backward compatibility, camel case vs underscore case and so on...
@dilame I rely on contributors like you are, because I have no time to maintain library. Otherwise If I have time to improve code, params rewriting would work perfectly.
👍  Thanks.


feat: decouple context data format from variable parsing

related to https://github.com/nikku/lezer-feel/issues/17
[ fyi @nikku ] as discussed, a branch to decouple variable format from the parsing. I also added a test that verifies parsing is still works correctly with another Context class

Cf. https://github.com/nikku/lezer-feel/pull/18/commits/821a7ce56fc864cfe66a98aee63db37ba579c6b6 for a couple of simplifications that I put on top. The API did change slightly, but only slightly.

Even with the fix, it still uses the default VariableContext sometimes. I was not able to find the root-cause just yet. I will look into it further

When no Context was provided, the tests still used the default one. With 48fa4e1, we ensure that the custom context tracker is always used.
We also talked about using the Context class from an instance, without the need of a second parameter. I implemented this with 02fa642

Thanks again for updating this contribution! I decided to merge it without the variable context constructor magic (https://github.com/nikku/lezer-feel/pull/18/commits/02fa642acb532077a36d1caa4d6b2b901b11d8a9). Better to be explicit here.

This is now released with v0.17.0. Thank you for your work on this improvement.


Weird Zeroes

There are some weird zeroes

If you'd randomly select throughout the screen - there are some zeroes on the screen.
These are just beside the CONFIRM button.

Thank you for pointing that out. Actually it's a responsiveness issue. I am trying to fix it for some other screen sizes.

Aah i see, since it's already under-development i am closing the issue then !


Replace system.out.println with InternalLoggerFactory

Motivation:
There are two files that still use system.out.println to log their status
Modification:
Replace system.out.println with a debug function inside an instance of InternalLoggerFactory
Result:
Introduce an instance of InternalLoggerFactory in class AbstractMicrobenchmark.java and AbstractSharedExecutorMicrobenchmark.java

IMHO, it is fully acceptably to use System.out in the benchmarks. Why not?

@asajim compilation error becouse you missed imports.

IMHO, it is fully acceptably to use System.out in the benchmarks. Why not?

@fenik17 I was thinking that logging in any file inside src/main/java  folder should use InternalLogger to ensure that the developer would not missed the logging message since most developer already familiar with the logging class itself. I know that microbench is a benchmark project, but prevention always a good idea, right?

@asajim can you please sigh the ICLA and ping me once done ?
https://netty.io/s/icla

@normanmaurer I've just signed it. Thanks

Squashed and cherry-picked into 4.1 (016629fe3b65b3797e7e9de39a661bac196c41e0)


Add error information to result-index

Do not merge yet! Requires changes to the CodeQL extension first: https://github.com/github/vscode-codeql/pull/1159
cc @rneatherway

Instead of having a single "errors" artifact, we now upload a "<repo.id>-error" artifact for each repository that failed. This is so the VS Code extension can read/display that information 💃🏽 See internal linked issue 🔗
The result index now looks like this:
{
  "successes": [
    {
      "nwo": "dsp-testing/qc-demo-github-certstore",
      "id": "376068344",
      "results_count": 0,
      "bqrs_file_size": 23,
      "sarif_file_size": 759
    }
 ],
  "failures": [
    {
      "nwo": "dsp-testing/qc-demo-github-freno",
      "id": "376065647",
      "error": "Language mismatch: The query targets go, but the repository \"dsp-testing/qc-demo-github-freno\" has no CodeQL database available for that language."
    },
    {
      "nwo": "dsp-testing/qc-demo-github-vulcanizer",
      "id": "376069179",
      "error": "Language mismatch: The query targets go, but the repository \"dsp-testing/qc-demo-github-vulcanizer\" has no CodeQL database available for that language."
    }
  ]
}

Note: we also updated the integration test (i.e. the instructions.json file) to run on a "broken" repo.

Could I get another review? Then I'll revert that temp change for testing 😁

Reverted the revert for now so we can continue to use this branch for testing! cc @aeisenberg


Request: 500 error list panel

Very similar to the "404 or Not Found: " panel I would love to see which files are getting 500 errors the most.

#117 will address this in a nicer way. However, right now you can achieve this by doing this:
# awk '$9~/500/' access.log | goaccess

Some examples here

Closing this. Feel free to reopen it if needed.


from_json declaration order and exceptions

I am running into an issue where if a from_json function I wrote does a conversion that uses another from_json function I wrote, whether or not I can catch exceptions from nlohmann::json depends on the order of the from_json functions.  Repro code below:
#include <exception>
#include <fstream>
#include <iostream>

#include "json.hpp"

struct A {
    int value;
};

struct B {
    A a;
};

void from_json(const nlohmann::json& j, B& b) {
    b.a = j.at("test").get<A>();
}

// If this is moved before the from_json for B, I can catch the exception below
void from_json(const nlohmann::json& j, A& a) {
    a.value = j.at("value").get<int>();
}

int main() {
    try {
        std::ifstream stream("test.json");
        nlohmann::json j;
        stream >> j;
        B b = j;
    } catch (const std::exception& e) {
        std::cerr << "caught exception: " << e.what() << std::endl;
    }
    return 0;
}

My test.json file is below:
{
    "test": {
        "value": "hello"
    }
}

In the above example, the output is:
libc++abi.dylib: terminating with uncaught exception of type std::domain_error: type must be number, but is string
Abort trap: 6

If I switch the order of the from_json functions, the output is as expected:
caught exception: type must be number, but is string

I am pretty new to C++11 and C++ exceptions, so sorry if the reason for this is obvious.
My platform/compiler is OSX 10.11.6 with AppleClang <IP_ADDRESS>00042 and I tested this using json version 2.1.1.

I can confirm you observation, but I also have no idea. Maybe a language lawyer like @gregmarr or @theodelrieu knows more about this.

I'm far away of being a language lawyer, I will take a look, this looks really weird

Well well well, there is something fishy, looks like a dark corner of C++.
I have no idea why, but it seems that during the evaluation of the first from_json method's body, the compiler instantiates a lot of templates, one being the from_json_fn::operator()().
This method has a noexcept(noexcept(to_json(bla, bla))) construct. The thing is, there is no method void to_json(json const& , B&) defined, it is defined later in the translation unit. However, it stills compiles, no idea why.
I printed the value of the noexcept(noexcept()) clause in the definition of nlohmann::detail::from_json_fn::operator()(), and the output is .... true.
That's weird, and if you add the prototype void from_json(json const&, A&); at the top of your test file, the program will not crash.
The quick way of fixing this, is removing the noexcept(noexcept()) everywhere.
I will try to reproduce the problem with less code, and see if someone can explain what really happens.

I posted a question on SO last week.
The answer is not really clear, except if you're fluent in standardese (which I'm not).
I'll try to explain what happens (I may have some details wrong, don't hit me)
When the compiler sees the line b.a = j.at("test").get<A>();, it chooses the fallback overload of nlohmann::detail::from_json_fn::call,
whose body only consists of a static_assert. Note that this overload is marked noexcept.
The main overload could not be chosen, since from_json(json, A) could not be found by the compiler at that point
(it is defined above, but the compiler cannot see it, according to lookup rules)
static_assert doesn't trigger because only prototypes are looked up at this point.
Since from_json_fn::call(json, A) is marked noexcept, j.at("test").get<A>() is noexcept too.
However, the compiler seems to perform another instantiation once from_json(json, A) is defined.
Thus, your code calls the first overload of from_json_fn::call, which calls from_json(json, A).
But, the noexcept-ness remains, and that's why your program crashes. If I understood the SO answer correctly, your code leads to undefined behaviour.
There are 3 things we can do to resolve that issue:

remove every noexcept in the library code
remove the fallback overload of from_json_fn::call
don't touch the code, and add an entry in the documentation

The first solution would make your code work, but it still is undefined behaviour. And people caring about noexcept won't be happy.
The second would make your code fail at compile-time, but the static_assert would disappear, it won't be long before we hear complaints from users.
I think the last one is the only viable solution, you should either declare your prototypes before defining your methods, or put the definition in the correct order.
Hope I was clear enough.

My preference would be for something like this to cause a compiler error or warning, but I don't understand this library or the C++ standard well enough to properly evaluate the options you provided.  Regardless, adding some docs explaining this issue would be great.

@theodelrieu Can we close this?

We should an entry in the documentation about the definition order. Other than that, I don't think we can do anything.

Hm. What would be a proper line to add to the documentation?

Something along those lines:
Be careful with about the definition order of from/to_json. If a type B has a member of type A, you MUST define to_json(A) before to_json(B), look at issue 561 for more details.

Thanks a lot!


Producer: adds withFilter to support scala 2.12 for-comprehensions

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Eoin Coffey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Check & adjust test data for Ensembl/VEP 101

Ensembl and VEP version 101 were released recently. This affected VEP results, so our test data needs to be carefully checked (to verify there were no regressions) and updated.

I have verified that all changes brought about by VEP 101 are adequate. Submitted the PR: https://github.com/EBIvariation/eva-opentargets/pull/147. This change is trivial, and no review is required. Once the build passes, I will merge the PR and close the issue


Speed up Travis CI builds

https://giorgos.sealabs.net/docker-cache-on-travis-and-docker-112.html

this doesn't work.


Spid Quality Assurance - errors in AuthnRequests

Using
python3 src/spid_sp_test/spid_sp_test --metadata-url http://localhost:3000/metadata --authn-url http://localhost:3000/login?entityID=testenv2 --debug ERROR --extra

ERROR:spid_sp_test.authn_request:RelayState is missing - TR pag. 14 or pag. 15
ERROR:spid_sp_test.authn_request:AuthnRequest Signature validation failed
ERROR:spid_sp_test.authn_request:The ForceAuthn attribute must be present because of minimum/SpidL1
ERROR:spid_sp_test.authn_request:The ForceAuthn attribute must be True because of minimum/SpidL1
Spid QA: executed 151 tests, 4 failed.

also related to this
https://github.com/italia/spid-express/issues/32

At this time we have the following result.
Do we have to configure the CI for a private profile (--profile spid-sp-private)
spid_sp_test --metadata-url http://localhost:3000/metadata --extra --debug ERROR --exit-zero

ERROR:spid_sp_test.metadata:SpidSpMetadataCheckExtra.test_contactperson_email: The //ContactPerson/EmailAddress element MUST be present
ERROR:spid_sp_test.metadata:The //ContactPerson/EmailAddress element MUST be present
ERROR:spid_sp_test.metadata:SpidSpMetadataCheckExtra.test_Contacts_PubPriv: ContactPerson MUST be present
ERROR:spid_sp_test.metadata:ContactPerson MUST be present
ERROR:spid_sp_test.metadata:SpidSpMetadataCheckExtra.test_Contacts_PubPriv: Only one ContactPerson element of contactType "other" MUST be present
ERROR:spid_sp_test.metadata:Only one ContactPerson element of contactType "other" MUST be present
ERROR:spid_sp_test.metadata:SpidSpMetadataCheckExtra.test_extensions_public_private: Missing ContactPerson/Extensions/Public, this element MUST be present
Spid QA: executed 88 tests, 4 failed. 0 warnings.
ERROR:spid_sp_test.metadata:Missing ContactPerson/Extensions/Public, this element MUST be present


proposal votes pagination

What does this PR?
Shows the HP of that proposal in the modal header.
Creates a search bar below the modal header to search the particular voter.
Shows the pagination and sorting option below the modal body.
when user reaches to the last page of pagination , it will fetches the next limited records until all the records fetched.
When user searches any voter , if that voter is not present in current list , it will fetch the next record and find that user until all the records fetched.
Steps to reproduce

Click on the "Votes" of any proposal , it will open the modal.
Search any record by typing name of voter in the search bar.If it is present in the current list , it will display that record
otherwise it will fetch the next records until all records been fetched.
User can jump into the last and first page by clicking on the last and first page icon.

Issue number
fixes #1161
Screenshot / Video
https://user-images.githubusercontent.com/106739598/210304914-d79b1361-48d9-434c-abe9-7aedfed992c0.mp4

@MTSaeed I was expecting we will show number of votes on title, not how much HP voted the proposal because that info already visible before modal is opened, so it is not needed to on modal title, instead showing number of votes would be interesting to see. Could we change that?!

@MTSaeed I was expecting we will show number of votes on title, not how much HP voted the proposal because that info already visible before modal is opened, so it is not needed to on modal title, instead showing number of votes would be interesting to see. Could we change that?!

https://user-images.githubusercontent.com/106739598/212839422-4c694e21-c925-41ec-9a63-c495f5d548f9.mp4

@feruzm Please check

@MTSaeed lets add + after vote count, like 1000+, 2000+, 3000+ but when 3198 then there is no + because it is end of list, makes sense? when there is more data available show or add + at the end of numbers on title when all fetched, no need +.

@MTSaeed lets add + after vote count, like 1000+, 2000+, 3000+ but when 3198 then there is no + because it is end of list, makes sense? when there is more data available show or add + at the end of numbers on title when all fetched, no need +.

https://user-images.githubusercontent.com/106739598/213686268-87c9f821-f3c3-4589-a76b-12fa65888534.mp4


Nextcloud permission issue

Hi, after the upgrade i receive the following nginx error:
nginx: [emerg] mkdir() "/var/lib/nginx/tmp/proxy" failed (13: Permission denied)
it seems like the chown in run.sh is wrong but it seems okay because its -R...

+1

It's a known problem and yet I've seen no fix, it happens randomly. The only workaround is to move /var/lib/nginx/tmp/proxy to /tmp/proxy, I'll do that a bit later.

After the update: nginx: [emerg] mkdir() "/var/lib/nginx/tmp/uwsgi" failed (13: Permission denied)

Now ?

nginx: [emerg] mkdir() "/var/lib/nginx/tmp/scgi" failed (13: Permission denied)
After I created the folder "scgi" manually it works!

You can also add  uwsgi_temp_path /tmp/uwsgi 1 2; to /etc/nginx/nginx.conf.
So no more errors after scgi ?

Right, after scgi nginx starts.


updated newPost Responsiveness

Modified Code for clear view of post button in mobile screen as well.

I updated the dialog box for mobile screen after adding tags the dialog box size not increasing and adding a placeholder for tags saying "Add a tag and press 'space' ex(#meme)".
please review the code


Nethandler error when connecting to a modded server without EnderIO

Issue Description:
I have a BungeeCord (Waterfall) setup without any issues at all. There is a SpongeForge lobby server without EnderIO (1.12.2). When EnderIO is on the client, the connection is refused by the client. No problem when connecting on a Vanilla server.
What happens:
The connection is refused by the client.
What you expected to happen:
The client to connect normally even if the server does not have EnderIO
Steps to reproduce:

Setup a modded server without EnderIO and some mods.
Setup a modded client with EnderIO and the others mods.
Try to connect to the server.

Affected Versions (Do not use "latest"):

EnderIO: 5.0.31
EnderCore: 0.5.37
Minecraft: 1.12.2
Forge: <IP_ADDRESS>60
SpongeForge? yes and no. The issue is the same.
Optifine? yes and no. The issue is the same.
Single Player and/or Server? Server

Your most recent log file where the issue was present:
https://gist.github.com/Aang23/0c201507c1c2b9a8e248ff1a2da77546

Ender IO is a client-server mod, it cannot work client-side without its server-side components.

I don't think any of us are expecting it to work, we're just expecting it to connect so that we can then use whatever bungeecord mechanics are setup to pass through to the correct server that has the mod installed.