IE10 renders 'g' elements outside 'svg' tag. Graph bars are not shown then.

Hi,
Bar Graph's are not rendered properly in IE10 because all the 'g' elements which draws the bars are rendered outside 'svg' tag. (I hope this is the cause for this issue. We notice undefined class in 'g' tag class list.)
<svg class="rv-xy-plot__inner" width="300" height="425">
<g class="rv-xy-plot__series rv-xy-plot__series--bar undefined" transform="translate(40,50)">

All other browsers renders 'g' tags inside 'svg' tag. Following is the code I am using. Following is the code I am using to generate the graphs. I have included 'babel-polyfil' as well.
Is there any alternative that I could use to overcome this issue?
IE10 is a mandatory with this application because this runs inside SharePoint and SP set the IE11 to run in IE10 Compatibility Mode.
<XYPlot margin={{bottom: 100, top: 50}} height={425} width= {300} xType={'ordinal'} color="#ff6675">
            <VerticalBarSeries data={data} />
            <XAxis tickLabelAngle={-45}/>
            <YAxis/>
          </XYPlot>

Thanks in advance for reading this.
Regards,
Kasun

I'm a colleague of Kasun's and we've managed to work around this issue by checking if the VerticalBarSeries' type attribute has 'requiresSVG' set to true.
const VerticalBarSeriesFix = (
      <VerticalBarSeries data={data} />
    );
    if (VerticalBarSeriesFix.type.requiresSVG === undefined) {
      VerticalBarSeriesFix.type.requiresSVG = true;
    }

It seems that in IE10 either the parent prototype isn't being inherited correctly, or isn't visible, so when xy-plot in xy-plot.js makes the check for whether the VerticalBarSeries needs svg
line 418 {components.filter(c => c && c.type.requiresSVG)}
requiresSVG returns undefined and it gets rendered outside.
I'm still fairly new to javascript in this kind of depth so I'm not sure of the actual bug. But defining the
  static get requiresSVG() {
    return true;
  }

directly on the implementing classes should fix the issue.


CB-21371 Add the cdpEndpoint parameter

To the config.toml for Jumpgate agent.
The environment variable used CDP_API_ENDPOINT_URL originates from the user data script.

Image has been validated: http://ci-cloudbreak.eng.hortonworks.com/job/api-e2e-imagevalidator-aws/2628/


Add support for Stack

Resolved by https://github.com/gmarpons/asciidoc-hs/commit/f16b872c0bc94f309ea8383f8a79a500fef2a42c


[HybridApp] Improve transitions between Classic <> New Expensify

Problem
The transition between Classic and New Expensify is not the smoothest. Let's apply some design magic and improve the transition to make it look seamless ✨
Solution
Keep riffing on the transition animations between the two pages and smooth the animations out so they look better.
https://github.com/Expensify/App/assets/2838819/1a65e8ae-32f8-4006-bbd6-2cd465d4e3e8
cc @staszekscp

Going to get some help with this one soon

@mateuuszzzzz - Can you comment here so I can assign you? Thanks!

.

This is done!

@mateuuszzzzz is working on this


[Snyk] Upgrade @slack/bolt from 3.17.1 to 3.18.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @slack/bolt from 3.17.1 to 3.18.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 21 days ago, on 2024-04-25.

Release notes

Package name: @slack/bolt

3.18.0 - 2024-04-25What's Changed

Fix #2056 by adding files to app_mention event payload by @ seratch in #2057
Update acknowledging_requests.md by @ technically-tracy in #2086

New Contributors

@ technically-tracy made their first contribution in #2086

Full Changelog: https://github.com/slackapi/bolt-js/compare/<EMAIL_ADDRESS><EMAIL_ADDRESS>

3.17.2-rc.1 - 2024-04-17…nts.

3.17.1 - 2024-01-11What's Changed

chore(3.17.1): Publish v3.17.1 by @ rafael-fecha, including dependency updates to address an Axios security vulnerability in #2029

New Contributors

@ rafael-fecha made their first contribution in #2029

Full Changelog: https://github.com/slackapi/bolt-js/compare/<EMAIL_ADDRESS><EMAIL_ADDRESS>

    from @slack/bolt GitHub release notes

Commit messages

Package name: @slack/bolt

65413b9 Publish 3.18.0 (#2101)
acd3c2a Improve issue templates to ask for more relevant bolt information up front to issue submitters. (#2098)
513d892 Bump @ types/node from 20.12.5 to 20.12.7 (#2093)
0ae48eb Bump @ types/node from 20.12.2 to 20.12.5 (#2088)
a89b756 Add missing comma
b3d1aa5 Apply #2086 to JP version
a52e790 Merge pull request #2086 from technically-tracy/main
34d8997 Update docs/_basic/acknowledging_requests.md
c17ead2 Update acknowledging_requests.md
e5728c0 Bump @ types/node from 20.11.5 to 20.12.2 (#2081)
449eced Fix #2056 by adding files to app_mention payload (#2057)
b413520 Bump actions/checkout from 3 to 4 (#2052)
d2ae07b Bump actions/setup-node from 3 to 4 (#2051)
96d3b4e Bump actions/stale from 4.0.0 to 9.0.0 (#2050)
bf97ace Bump codecov/codecov-action from 3 to 4 (#2053)
b0f6e21 Update dependabot.yml (#2049)
d366ef2 Bump @ types/node from 20.11.2 to 20.11.5 (#2037)
3ddca26 Bump @ types/node from 20.10.6 to 20.11.2 (#2034)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

using 3.19.0, hence closing the PR


PATAND-237 : Update the common survey layout

Objective
Implement the change for the common part : the survey layout
Branches

PAT: development
Axon: development
RS: task/PATAND-237_update_survey_layout
Cortex: development

SCENARIO:
Credentials:

Environment: QA
Org: hybridstudy
Study: QA-Regression
User<EMAIL_ADDRESS>Task: T03 - Boolean

Steps:

open flask/ resumed it
Login if it's not the case
Start the right task
Expected:
The header (title and description with the divider) will fit the zeplin

Part of PATAND-237

Works fine. It took me a few minutes to read what you were doing. If possible, describe what you did (like, in this instance, it would have been easier if you would have written "Updated the divider visibility based on the presence of a title or description" or something that points at what the changes are without having to look at the code first.
We will always look at the code, but if the change is "two lines" it's sometimes hard to tell what those two lines are doing in the context where they are, without having to open the entire project for inspection.


misaligned played waveform

Happens whenever there is a scrollbar.  Likely read if scrollbar is available here & adjust if needed.  It is tricky, IIRC different OS & browsers have different scrollbar widths (& are user-adjustable)?  Not sure if non-native scrollbar is the best.
I don't remember this bug when I first found wavesurfer a few months ago?
Win 7, Chrome & Fx

I'm getting the same problem on Ubuntu chrome and firefox; is it related to #367 ?

Thanks, guys! Should be in order now.


Add JavaScript unit tests for clinvar_export Vue.js app

Is your feature request related to a problem? Please describe.
The front-end code for the clinvar_export app is currently untested.
Describe the solution you'd like
We should add JavaScript based UI tests.
Describe alternatives you've considered
N/A
Additional context
N/A

Resolution Proposal
Add unit tests based on the same libraries as sodar-server/samplesheets.
Affected Components
VarFish server
Affected Modules/Files
varfish/vueapp
Required Architectural Changes
None
Required Database Changes
None
Backport Possible?
Yes
Resolution Sketch
Add front-end tests, use mock API. Server AJAX/REST API is already properly tested.


LUCI seems to not use pub in the latest state

In https://github.com/flutter/flutter/pull/65234, I'm updating cupertino_icons package to 1.0.0 (which is stable on pub https://pub.dev/packages/cupertino_icons/versions/1.0.0) and in https://github.com/flutter/flutter/pull/65087 I'm updating gallery past https://github.com/flutter/gallery/pull/282 which started importing synthetic package locations.
Both work locally on flutter pub get but both fail on LUCI.
cupertino_icon ^1.0.0 doesn't exist in the first case https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8870061933069596256/+/steps/run_test.dart_for_hostonly_devicelab_tests_shard_and_subshard_3_last/0/stdout
and the synthetic package doesn't exist in the second case https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8870127907410516896/+/steps/run_test.dart_for_hostonly_devicelab_tests_shard_and_subshard_3_last/0/stdout
Is there some pub caching going on that we need to clear in tests on LUCI?

@xster I think you mentioned you found the problem, did you ended up fixing the issue?

Triage: we heard this is fixed.


update ojdbc to v23

UCP doesn't work. Test uses old 21 version just for confirmation

@n0tl3ss can this be closed or do we need it for Micronaut Framework 4?


[GLUTEN-1632][CH]Daily Update Clickhouse Version (20231108)

Auto commit by gluten daily build, please check the build status and merge it if it's green.

No siginifiant improvement.
Gluten Perf Test Pass, GlutenWithCHStandard tpch-data-sf100 total time 127857

We need merge due to bug fix in https://github.com/ClickHouse/ClickHouse/pull/56286

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3640_time.csv
log/native_master_11_07_2023_e3eff1d8f_time.csv
difference
percentage

q1
32.81
34.38
1.563
104.76%

q2
24.75
25.03
0.278
101.12%

q3
37.84
38.14
0.306
100.81%

q4
37.85
37.57
-0.277
99.27%

q5
71.09
71.50
0.412
100.58%

q6
6.31
6.26
-0.052
99.17%

q7
82.96
82.22
-0.738
99.11%

q8
85.64
86.95
1.304
101.52%

q9
123.05
119.81
-3.241
97.37%

q10
51.03
51.26
0.237
100.47%

q11
19.71
19.73
0.017
100.08%

q12
26.71
24.39
-2.325
91.30%

q13
49.77
50.30
0.526
101.06%

q14
17.31
17.67
0.359
102.07%

q15
30.37
30.35
-0.020
99.93%

q16
15.61
16.20
0.593
103.80%

q17
100.45
101.51
1.053
101.05%

q18
146.78
148.26
1.479
101.01%

q19
14.86
16.17
1.311
108.82%

q20
30.28
30.31
0.028
100.09%

q21
224.44
224.88
0.440
100.20%

q22
13.19
14.08
0.897
106.81%

total
1242.83
1246.98
4.151
100.33%


initial implementation

a simple implementation of the pinata API that we can use in our local environment to avoid using the real API and being able to use it offline.
It's implemented in to have it simple and with just a couple dependencies.
Also, I don't think we will need to develop on top of it but it's just to have a service running from docker compose in our grants stack local dev env.
check the readme file for more info.

Can you elaborate on the go choice here? Are we planning on using the ipfs go libs more than the hash type? There was probably a discussion that I wasn't part of when i was out sick.

Can you elaborate on the go choice here? Are we planning on using the ipfs go libs more than the hash type? There was probably a discussion that I wasn't part of when i was out sick.

@vacekj  this is just the local service I use in development and since I notice everyone is using the real pinata service for development I decided to share it. I don't think we need to add features, it's just a development service we can use in local.

Are we planning on using the ipfs go libs more than the hash type?
the only sub packages included are go-multicodec and  go-multihash just to have the real CID instead of a simple hash, nothing else from the ipfs library is included. did you want to use more things?

@gravityblast re: first part - sounds good to me.
re: second part - I misread the code - nothing I would like to add personally, @bard asked about "forking the chain"-like funcitonality with real pinata, but personally I don't have a need for that.

@gravityblast re: first part - sounds good to me.
re: second part - I misread the code - nothing I would like to add personally, @bard asked about "forking the chain"-like funcitonality with real pinata, but personally I don't have a need for that.

I was referring to IPFS in general, i.e. wondering if at any point we're going to need IPFS resources outside of what is uploaded as part of a test setup, as it might be the case when trying to reproduce locally a production bug.

this is a good point, there's also the indexer to consider, how does the forking work with eth_getLogs? I would assume that the indexer would get events for the rounds in the forked chain, right?
if that's the case it would make sense to have this service behave the same as the node and "fork" Pinata, but another option could be just having the development environment not fork anything, so a pure offline set up.

I imagine the fork scenario with a different config.

development with one .env for local only services
staging like what we have now, with testnets and staging envs
fork as a mix, running anvil forking in local but using the real pinata to get real data

I don't think we will need a mixed environment but I'm happy to talk about it if you guys have any scenario in mind.

This is a good point, there's also the indexer to consider, how does the forking work with eth_getLogs? I would assume that the indexer would get events for the rounds in the forked chain, right? This means that the IPFS service should also serve those metadata.

yes it will need to get logs from the local chain, and files from past rounds/projects would be available in pinata.

Another option could be just having the development environment not fork anything, so a pure offline set up.

yes this is the current idea, but we can continue thinking about the forking scenario for specific tests we want to reproduce, but not really for development


Multiple samples in one VCF

Hi,
I have two VCFs, one with Lumpy and one with Wham.
In each vcf I have 23 samples. When I merge the two VCF with SURVIVOR, I have an output VCF but there is only one sample.
What is the best way to merge the two VCFs ?
Thanks per advance,
Alexandre

Hi Alexandre,
sorry its not intended like this. So SURVIVOR would need to be run first on the two callers per sample. Then merging the 23 merged vcf files to one.
Thanks
Fritz

Thank You for your answer !!!

This is quite useful information that may be worth including on the wiki for SV newbie like myself.
Thanks for building such a useful tool!!


Get 502 Bad Gateway when AJAX Request

Phalcon version: 1.3.6
Php version : 5.5.19
echo json_encode($users->toArray());

When we return the json format as response to Ajax, it will occur error 502: Bad Gateway.
If we disable the phalcon-debugbar, everything is fine.
I also tested it in phalcon version 2.0.2, but it was fine.

I'v fixed it, you can test again.

Hi, Thank you but unfortunately, it's still not working.
I've found the error occur when it's call the collect function at PhalconDebugbar.php line 698.
When the time collector is loaded, it will throw the error.

Hi,I don't know where to get phalcon 1.3.6, so I test ajax request on Phalcon 1.3.5/PHP5.4/Ubuntu14.04/Nginx  1.8 using  the INVO project.
This is my test code:
class IndexController extends ControllerBase
{
    public function initialize()
    {
        $this->tag->setTitle('Welcome');
        parent::initialize();
    }

    public function indexAction()
    {
        \PhalconDebug::addMeasurePoint('index');
    }

    public function testAction()
    {
        $this->view->disable();
        echo json_encode(['key1'=>1,'key2'=>2]);
    }
}

views/index.volt:
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8">
        {{ get_title() }}
        {{ stylesheet_link('css/bootstrap.min.css') }}
        <meta name="viewport" content="width=device-width, initial-scale=1.0">
        <meta name="description" content="Your invoices">
        <meta name="author" content="Phalcon Team">
    </head>
    <body>
        {{ content() }}
        {{ javascript_include('js/jquery.min.js') }}
        {{ javascript_include('js/bootstrap.min.js') }}
        {{ javascript_include('js/utils.js') }}
        <script type="text/javascript">
				jQuery.post('/index/test',{},function(data){
					console.log(data);
				});
        </script>
    </body>
</html>

It  works ok.
Could you tell me any more infomation about your problem. Linux or Wn? Simple App , Mulit module or Micro App?
I suggest you test on phalcon 1.3..4/1.3.5, because they are offical version.
Also, You can go on debuging into TimeDateCollector::collect method . It's a very simple method, so you can  comment line by line to find out the 'culprit' line.
Thank you for your test, I hope we can fix it togethor.

I am using version 1.3.4, not 1.3.6, sorry for wrong information provided.
my production environment is Centos 6.5 with Nginx 1.6.3.
My Application is separate into 2 modules, which is frontend and backend.
We found the collector have problem only when it counted to 10, so we disabled it temporary as workaround.
foreach ($this->collectors as $name => $collector) {
            if($count!=10) {
                $this->data[$name] = $collector->collect();
            }
            $count++;
}

I had test again, but  it work.
Maybe you could copy a config file to your project directory instead the default config file, like this:
 (new \Snowair\Debugbar\ServiceProvider('../apps/debugbar.php'))->start();

you could disable any unnecessary collectors or disable capture ajax request by edit your config file.


Added sample "jest" tests for counter reducer #509

This PR fills the gap between Angular and React-Redux template by adding test library and sample tests to the second one. #509

@rosieks,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks for the suggestion!
These jest tests are not really equivalent to the karma tests in the Angular project, because the karma ones are testing at a UI level by automating the browser, whereas these jest tests are purely unit tests that don't describe the UI at all.
If we were to add sample tests to the Redux project, I think we'd want to add higher-level UI tests for equivalence. But that would still only be if those tests and its setup/config were all simple enough to be easily understood by a total newcomer.
Is that OK? Do you mind if I close this PR?

That make sense.

Thanks!


When you set LocalCharacterTransparency = 0, The script freaks out and stops working correctly.

When setting LocalCharacterTransparency to zero, First Person will not work. Only Third Person works.

Im trying to make a game called Roblox VRlab, and its not working correctly. If you could add seperate character transparency settings, i could work around the issue. Heres the code.
My script:
--script
Appearance = {
--Transparency of the character when in first person.
LocalCharacterTransparency = 0,
    --If true, arms will be allowed to disconnect.
    --Recommended to be true locally so that the controllers match the hands,
    --and false for other players so that arms appear normal.
    LocalAllowArmDisconnection = true,
    NonLocalAllowArmDisconnection = true,

    --Maximum angle the neck can turn before the torso turns.
    MaxNeckRotation = math.rad(35),
    MaxNeckSeatedRotation = math.rad(60),

    --Maximum angle the neck can tilt before the torso tilts.
    MaxNeckTilt = math.rad(60),

    --Maximum angle the center of the torso can bend.
    MaxTorsoBend = math.rad(10),
},

I'm not sure I understand the issue. The expected behavior is transparency will be 0 when in first person. What do you get instead? Can you post a screenshot?

Instead, i get a third person mode, and able to see the character's hats, but not its body. The point of it is supposed to be kind of like SteamVR's Aperture Hand Lab hands.

Also, it would be handy to have seperate transparency for each object. LowerLeftArm, LowerRightArm, etc. Is this possible?

Also, another example is kind of like Rec-Room, but without the torso part.

Also, how to make it so you can grab a tool, but then when you release it drops?

Nevermind. I added a texture to the character (which was 0) and it fixed. Thanks for helping, though!


Use --no-progress-bar flag to turn off data loading progress bar

Summary: Removes data loading progress bar if --no-progress-bar is set
Reviewed By: jhcross
Differential Revision: D8078630
fbshipit-source-id: 088fa72642a73431815f7652d2f20f464ce94457

abandoned in favor of binarized data loading https://github.com/pytorch/translate/pull/62


[RFC] implements: detect  preview and  deprecated functions

A quick hack to demonstrate how the 'implements' tool can help us manage functions that are deprecated and/or preview. Of main interest is the JSON output which records the functions with the markers in the doc comment.
This can be part of a future toolchain that detects these functions in the code and helps us document what and when deprecation and preview statuses are present.

Thanks, the whole of implements is a tad bit hacky, but that's because it's not essential to go-ceph and it lives in contrib. :-)
Once I prototype a script that consumes the output of this tool for documenting the deprecated/preview APIs and I find it useful I'll move this from draft.

description updated.

There are a vast number of things we can add to this. However, with new contributions to go-ceph it would be better to stop here and begin the process of including the new tools in our CI and contribution process. If during the review process you think would be good to have but are not strictly required for a minimal viable tool, please file new issues and we can get to them one at a time. Thanks!


Echo Trainer: Abbreviations should show up quicker: before next abbrev. starts

In Echo Trainer (beta) mode, there is this feature which looks up and displays common CW abbreviations.
Currently, the meaning/description is shown only after some time after reception. It seems only when the next abbreviation is transmitted by the morserino the lookup of the description is done.
It might be a good idea to already load it after the "OK" is received.

yes! Already implemented it that way now (was different before)


Google Custom Search does not work if not using Instant Search

fbafe58e40b1bd4a2628aef1eb5955ab57dcfaf4 renamed the function in the
scripts file, but did not rename the call sites.
This is a bug fix.
Summary
Google Custom Search integration does not work if Instant Search is not enabled.
Context
In my _config.yml, I had:
google:
  search_engine_id       : "my_id"
  instant_search         : # false (default), true

When I tried to execute a search, I got an error in the Javascript console about executeQuery not being defined.
As part of #1667, a function was renamed in fbafe58e40b1bd4a2628aef1eb5955ab57dcfaf4. However, the two call sites, in _includes/search/search_form.html and _layouts/search.html, were not renamed.

Thanks @efung


Copy & Pasting code must respect new lines

When copying code from the prompt response the new lines should be respected when pasting them into an editor.

Duplicate from #168 ?

Indeed, will remove this one

Same as #168


pull request for e2e test at 01/02/2017 03:45:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Websockets connection drops on Safari/iOS

Describe the bug
The websocket connection is inconsistent on mobile sometimes for Safari/iOS.
To Reproduce
See related issue: https://github.com/HeinrichApfelmus/threepenny-gui/issues/130
Expected behavior
The connection should be resilient and reconnect when dropped.

I’m glad to finally see this issue here.
Any idea for when this will be included in a milestone? It’s seems to be a critical issue.
From my experiments with the examples, most have these issues in Safari/iOS, including the docs site when it comes to the burger menu. It makes deploying reliable Pynecone apps for iOS devices pointless right now. They’re extremely unreliable. Same with browsers like FF right now which are more aggressive with websocket connections.
A large portion of the mobile market for Pynecone apps is inaccessible right now.


respect -H in bash completion

At present, bash completion ignores custom docker daemon settings specified with -H.
This is nasty if you work with swarm and get completions for the local docker instance.
This PR applies any global -H setting from the commandline to docker invocations needed for gathering completions.

@tianon @jfrazelle ping

cool!  LGTM :)

ping @tianon hehe

NICE
LGTM


Failed to initialize connection to Alexa. - Proxy Server could not be initialized.

My problem is that I can't connect to the Alexa app.
[homebridge-alexa-smarthome] Alexa-Remote: Error from retrieving cookies
[2/27/2024, 7:35:47 PM] [homebridge-alexa-smarthome] Failed to initialize connection to Alexa. - Proxy Server could not be initialized. Check Logs.
[2/27/2024, 7:35:47 PM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error, try re-init
[2/27/2024, 7:35:47 PM] [homebridge-alexa-smarthome] Alexa-Remote: No cookie given, generate one
[2/27/2024, 7:35:47 PM] [homebridge-alexa-smarthome] Alexa-Remote: Error from retrieving cookies
[2/27/2024, 7:35:47 PM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error and renew unsuccessful. STOP

{
"devices": [],
"excludeDevices": [],
"auth": {
"refreshInterval": 4,
"proxy": {
"clientHost": "http://<IP_ADDRESS>",
"port": 8581
}
},
"amazonDomain": "amazon.es",
"language": "en-US",
"performance": {
"cacheTTL": 30,
"backgroundRefresh": true
},
"debug": true,
"_bridge": {
"username": "0E:85:83:BE:E6:78",
"port": 7341
},
"platform": "HomebridgeAlexaSmartHome"
}

Plugin Version: v2.1.4
Homebridge Version:  Homebridge v1.7.0
Node.js Version: v20.11.1
Operating System:

macOS Sonoma

For example, if you access homebridge via the url http://my-homebridge-server.local:8581 then clientHost should be my-homebridge-server.local. The port should be a different value from homebridge (not 8581)

IP address works but you need to remove http:// and 8581 is not allowed

Thank you very much, now it works fine


Exclude sudo error message from stdout

When pty is allocated and host name is not set, the error message "sudo: unable to resolve host" is injected into stdout and it brings unexpected behavior.
So exclude this error message from stdout.

Released as v2.44.3.


Python Script to convert Geotiff (satellite images) files to png.

Problem
There is a need to convert geotiff files to png in order to view and analyze the data in a more user-friendly format. Currently, there is no easy way to do this conversion.
Solution
A python script that can convert geotiff files to png would be a useful tool for users who need to work with geospatial data. The script should be able to take a geotiff file as input and generate a png file as output.
Proposed Changes

Develop a python script that can convert geotiff files to png.
The script should take a geotiff file as input and generate a png file as output.
The script should be able to handle multiple geotiff files as input and generate corresponding png files for each.
The script should be able to handle geotiff files of different sizes and resolutions.
The script should be able to handle different color maps and band combinations for the geotiff files.

Additional Notes
It may be necessary to use an external library such as GDAL or rasterio to read and manipulate the geotiff files.
The script should be well-documented and easy to use for users who are not familiar with geospatial data processing.

If this issue is acceptable, please assign me this issue


Adding chainloop

Adding Chainloop attestation process and collecting the build process metadata.

I think we are good to go. All artifacts metadata are successfully sent and stored in Chainloop.
Chainloop Trust Report is available here: https://app.chainloop.dev/attestation/sha256:a53bc5c055f2cdd6514cdf24bbce04c6f511ae3ac1ccfaac1d5582ad24a29a75
Added some screenshots for reference below:


feat(pid_longitudinal_controller)!: add acceleration feedback block

Description
This PR provides an acceleration feedback feature for the pid_longitudinal_controller.
The red allows in the following figure are added by this PR.

Note that the acceleration feedback gain G_a(s) is set as 0 in the default parameters, https://github.com/autowarefoundation/autoware_launch/pull/1105.
Therefore, no behavior is changed by this PR.
With the current construction of the speed controller, it is difficult to achieve both disturbance tolerance and tracking performance when the response delay of the vehicle is large. In order to better ensure this performance, we have added a block that performs feedback control by looking at acceleration information.
This is because acceleration is closer to the input value to the plant than velocity, and the response is about 90 degrees faster.
Related links
launch PR: https://github.com/user-attachments/assets/f2258401-329f-489b-8a5f-580adbb294be
How was this PR tested?
psim and tier4 internal tests
Notes for reviewers
None.
Effects on system behavior
None.

@Motsu-san
Just a notification, We will merge this PR, and then, the twist2accel node and stop_fillter node will be included in the feedback control loop.


"elemental-operator register /run/initramfs/live" broken

Setup:

Rancher Manager running via Docker
Client on KVM (virt-manager)
self-signed certs

Full log (from journalctl -t elemental)
elemental.log

are you sure you embedded the registration configuration file with the appropriate name? In order to execute elemental-operator the iso has to include in its root a file called livecd-cloud-config.yaml otherwise it won't be executed.
@Itxaka probably we could remove this file existance condition, after all elemental-operator will attempt to read all yaml files in the given folder, so even if there are other yaml files around it will attempt to read them.

Well it was mainly done in case the iso is built wrongly somehow, the operator will not launch automatically, so we dont get strange errors.
On @kkaempf logs it shows that it run the stage so the file is correctly set
Jul 22 10:16:59 localhost elemental[1605]: INFO[2022-07-22T10:16:59Z] Applying 'Elemental operator bootstrap' for stage 'network'. Total stages: 1
Jul 22 10:16:59 localhost elemental[1605]: INFO[2022-07-22T10:16:59Z] Processing stage step ''. ( commands: 1, files: 0, ... )

Problem is that becuase we have no streaming logs, the command is retrying and doesnt return, so it looks like its hanging. It could be a tpm error, a network error, a cacert error...and we will never know.
Maybe it wasnt such a good idea to remove the service files...at least we could see the output of the command :/

@kkaempf are you sure you embedded the registration configuration file with the appropriate name? In order to execute elemental-operator the iso has to include in its root a file called livecd-cloud-config.yaml otherwise it won't be executed.

Yes, I checked this. The file is present and has the expected content.

Maybe it wasnt such a good idea to remove the service files...at least we could see the output of the command :/

😞  🤔

Problem is that becuase we have no streaming logs, the command is retrying and doesnt return, so it looks like its hanging. It could be a tpm error, a network error, a cacert error...and we will never know.

Well from the cloud-config execution it shouldn't be hard to log into a file or probably directly to journalctl with something like elemental-operator --debug register /run/initramfs/live | systemd-cat

@kkaempf

image used for the node?
yaml used for the node (bar cert/registration token of course)?

related to this I just opened rancher/elemental#202

Damn with the removal of the unit service file we are hitting again #50 ... 😞 At least my env now seams to be consistently failing with this sort of race condition if a previously installed system was there.

It probably was all caused by the locked-up swtpm state. After unlocking it, everything works now.
Bottom line: We need more exhaustive logging

It probably was all caused by the locked-up swtpm state. After unlocking it, everything works now.

HOW HOOOOOWWWW

🤷🏻♂ 😿


Add Editor layout to Editor Layout

Would you know of a way to add at least another level of Editor Layout to editor layout other than creating a bunch of copy's of the same object?

Actually i think I found it, I'm going to try to add a configuration that will allow you to add levels of copy.

I figured out how to do this with vanilla JS, but I need to figure how to do it with Typescript. So  hopefully by next week I can have this knocked out.

hey did you find a workaround?

hey did you find a workaround?

Yes, while I'm still looking for the way to infinite nested levels... I had to put the project that I was using this on hold.. but you can copy your base config that had the editorJS Layout component. So the editorJSConfig will go into  editorConfig..... I'm trying to figure out how I can nest finitely.
let editorJSConfig = {
add_another_layout_here1: {
},
add_another_layout_here2: {
},
header: {
class: Header,
inlineToolbar: true,
//https://editorjs.io/configuration/#inline-toolbar-order
// tunes: ['anyTuneName']
},
};
let editorConfig = {
oneheader: {
class: EditorJSLayout.LayoutBlockTool,
config: {
EditorJS,
editorJSConfig,  //<---- add a copy of your base config here
enableLayoutEditing: false,
enableLayoutSaving: true,
initialData: {
itemContent: {
1: {
blocks: [{
type: "paragraph",
data: {
text: "Start typing here",
},
}, ]
},
},
layout: {
type: "container",
id: "",
className: "",
style: "",
children: [{
type: "item",
id: "",
className: "",
style: "",
itemContentId: "1",
}, ],
},
},
},
toolbox: {
icon: ``,
title: "1 column",
},
}
};


Unable to restart CHI when changing global configuration stored in the operator

There is no way to apply a configuration change to the CHI if this configuration is in the operator's *.d folders.
CHI itself is not restartable, and the operator won't pick up the change and apply it to the CHIs, even after having been restarted.
operator version is 0.14 using yandex 21.6.5 image.

@marcioapm , could you be more specific, please? What configuration change you can not apply?

@marcioapm , could you be more specific, please? What configuration change you can not apply?

Updated my OP.

@marcioapm , If you modify operator configuration, you can restart operator and it will apply the change.
However, why are you adding a new profile via operator configuration instead of adding it to the CHI itself? CHI has 'profiles' section or you can supply config files directly using 'files' section. See different examples here: https://github.com/Altinity/clickhouse-operator/blob/master/tests/configs/test-016-settings-04.yaml

Got it. Thanks!


Add tags and meta to the models tables

Description:
Adds the tags and meta fields to the models table and bubbles them up to the dim table

thanks, I'd love to see those 2 fields as well

@NiallRees Would you or anyone from brooklyn-data be able to review this soon?

@ahmedrad jumping in for Niall here who has been away for the last few days — I think we're generally in favor of merging this PR, but what has held us back is internal conversations about how to handle schema changes more generally in the package.
By way of explanation, for folks running 1.x and upgrading to a version with this PR they would need some code to be run to add the columns to the source table in order to be able to write into them.  We're considering reworking the table creation steps to avoid managing a complex set of schema migrations not just here, but over time as we continue to add/improve things.
I appreciate your patience while we navigate a way forward here.

@ahmedrad jumping in for Niall here who has been away for the last few days — I think we're generally in favor of merging this PR, but what has held us back is internal conversations about how to handle schema changes more generally in the package.
By way of explanation, for folks running 1.x and upgrading to a version with this PR they would need some code to be run to add the columns to the source table in order to be able to write into them. We're considering reworking the table creation steps to avoid managing a complex set of schema migrations not just here, but over time as we continue to add/improve things.
I appreciate your patience while we navigate a way forward here.

@jaypeedevlin just to add our 2 cents as new users to this package. For us, we use star schema modelling but there's still quite a few differences between our warehouse and the models provided by the package and so we decided to do our own modelling so we can stay consistent across the warehouse. I'm not sure that's something you'd ever be able to get away from. For example using TIMESTAMP_NTZ vs TIMESTAMP_TZ types, prefix vs suffix naming dim_ vs _dim, shortened naming vs not fct_ vs fact_, column naming conventions etc...
it would be pretty difficult to provide high level models that would immediately mesh with any existing data warehouse without any manipulation. I would much rather have access to the entire json blob of high level objects so that I can model however I want to for my needs. For example if I consider dbt to be broken into sources, models, tests, macros, exposures and metrics then for every run I'd want to have a table for each that contains the raw json blob of the object with some associated metadata about the run it was developed in.
That way we'll have all the flexibility we need in extracting and modelling the json objects however we need to and in a way that matches the rest of the warehouse without having to deal with most of the manifest structure. The blobs of the specific objects may change often and we'll have to deal with that but the main objects that dbt consists off shouldn't change all that often even with manifest schema changes and so it'll spare you having to re-work your tables often.
and I'd rather get access to your tables as sources when I install the package, because that's what they essentially are, a source for dbt run data that still needs to be staged and modelled in our warehouse according to our conventions

@ahmedrad PR 188 is now merged which unblocks this PR.  My suggestion to you would be to close and reopen a fresh branch against this, since so much was changed in that PR, but up to you.  I'm going to open a separate issue for the rest of your comment since it's not directly relevant to this PR.

this would be super useful! any idea when this could be merged in?

Hey @ahmedrad - really excited to get this in, do you think you’ll be able to get this rebased?

yup should be able to over the coming week!

hey @NiallRees I opened a new PR all together over here: 212


Add support for annotations on exported clases and functions

Added support for function and class annotations in modules. Currently, annotations may appear before or after the export keyword.
db568689287273b781010d6e3eff2b02c4fdc69b


explain more clearly where to put local.py before running tests

To get the tests to run I created ~/.virtualenvs/dataverse-client-python/src/dataverse/dataverse/settings/local.py but I'm not sure if this is right.
murphy:dataverse-client-python pdurbin$ workon dataverse-client-python
(dataverse-client-python)murphy:dataverse-client-python pdurbin$ cd dataverse/test
(dataverse-client-python)murphy:test pdurbin$ python -m unittest test_dataverse
..Connecting to DVN.
E....
======================================================================
ERROR: setUpClass (test_dataverse.TestDatasetOperations)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_dataverse.py", line 98, in setUpClass
    self.dvc = Connection(TEST_HOST, TEST_TOKEN)
  File "/Users/pdurbin/.virtualenvs/dataverse-client-python/src/dataverse/dataverse/connection.py", line 19, in __init__
    self.connect()
  File "/Users/pdurbin/.virtualenvs/dataverse-client-python/src/dataverse/dataverse/connection.py", line 29, in connect
    raise UnauthorizedError('The credentials provided are invalid.')
UnauthorizedError: The credentials provided are invalid.

----------------------------------------------------------------------
Ran 6 tests in 0.138s

FAILED (errors=1)
(dataverse-client-python)murphy:test pdurbin$ vim ~/.virtualenvs/dataverse-client-python/src/dataverse/dataverse/settings/local.py
(dataverse-client-python)murphy:test pdurbin$ cat ~/.virtualenvs/dataverse-client-python/src/dataverse/dataverse/settings/local.py
TEST_HOST = "apitest.dataverse.org"
TEST_TOKEN = "25fe08c4-c7d6-458a-973c-8c461ab4e0ad"
(dataverse-client-python)murphy:test pdurbin$ python -m unittest test_dataverse
..Connecting to DVN.
Getting Dataverse
Removing any existing datasets.
Dataverse emptied.
.....
----------------------------------------------------------------------
Ran 14 tests in 36.141s

OK (skipped=1)
(dataverse-client-python)murphy:test pdurbin$

To run the tests, you'll want to clone the repo rather than run from the version installed to your virtual env. The readme could specify that.

Ah, that makes sense. I blew away my virtualenv and made a fresh one. Now I think we should have a requirements.txt file with something like this:
lxml==3.4.3
requests==2.6.0
bleach==1.4.1

After running pip install -r requirements.txt I can run the tests like this:
$ cd dataverse/test
$ vim ../settings/local.py
$ export PYTHONPATH="../.."
$ python -m unittest test_dataverse

Please let me know if this is the wrong approach.

That's a fine approach. Because this is intended to be a package, it may be more clear to name the file dev-requirements.txt, since the package requirements are listed in setup.py.

you could run pip install -e . like the readme suggests and not need a requirements.txt file.

you could run pip install -e . and not need a requirements.txt file.

Well, that seems to install everything under "REQUIRES" at https://github.com/IQSS/dataverse-client-python/blob/d6e2199f21cddffac37d94d4e39caeaece70ee7e/setup.py#L6 which is certainly useful ("Successfully installed bleach requests lxml dataverse html5lib six") but I'm also interested in installing everything under "TESTS_REQUIRE" at https://github.com/IQSS/dataverse-client-python/blob/d6e2199f21cddffac37d94d4e39caeaece70ee7e/setup.py#L12 so I can run the tests. Any ideas?

@pdurbin In setup.py you could add
setup(
    name='dataverse',
    # ...
    extras_require={
        "testing": TESTS_REQUIRE,
        "somethingsomething": THAT_OTHER_THING,
    }
# and so on

and then pip install -e ".[testing]"
That type of thing drives me crazy because I can never remember the proper syntax and have to look it up every time. ymmv
also, mind you I am typing this by hand and haven't tested it.

If you've got the repo cloned locally, the TESTS_REQUIRE packages can be installed (and the test suite run) by running:
$ python setup.py test

I haven't tested this locally, so I'm not sure if setup.py is configured for that to work correctly, but that's generally the idea of the tests_require keyword argument in the setup method.


update PROXY_REPO_SHA

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli
If they are not already assigned, you can assign the PR to them by writing /assign @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0e1b56c13b887d3ba4cbc58e39feaedd39a7738e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
0e1b56c13b887d3ba4cbc58e39feaedd39a7738e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0e1b56c13b887d3ba4cbc58e39feaedd39a7738e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

That's missing few updates, see: https://github.com/istio/istio/pull/7922.

/hold


Update GHA CI Java Version

Description

Provide details of the change, and generalize the change in the PR title above.

The Firebase CLI tools require a java version 11+.  The default GHA runner Java version did not meet this standard.
This change adds an extra workflow step to install a JRE of v17.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration Test CI
Desktop CI

Type of Change
Place an x the applicable box:

[ ] Bug fix. Add the issue # below if applicable.
[ ] New feature. A non-breaking change which adds functionality.
[X] Other, such as a build process or documentation change.

Do we also need this for android?

It seems not.  And I would rather not add it for the sake of things considering it might interfere with Gradle.


Shorten management commands in docker 1.13

Hi,
I was tryin out docker 1.13 (and compose v3 too). It's a huuuuge step on the road to production-readiness.
I think it can be a good thing if each management commands gets aliased. I know that docker ps is still supported but one day, it won't be anymore and i'll be forced to type docker container ls which is much longer. I can do personal aliases in my .profile or .bashrc, of course, but this is ugly, and what will occur for production machine without any personnal account ?
For instance, I think that aliases like "ct" for containers and "im" or "img" for images can be great. Like in docker ct ls.
This is just thought/suggestion, a mini-minor improvement but that will make every user save time everyday :)
It4.

The original PR had a number of shortcuts, and we had a pull request to implement these separately (see https://github.com/docker/docker/pull/27468), but decided to hold off adding shortcuts because of various reasons

first and foremost, "no is temporary, yes is forever" (i.e., when in doubt, don't implement, otherwise there's no way back)
basically, there was no consensus yet on the naming of the shorthand commands
shortcuts can be highly personal, and there's quite some people that already have their personalised aliases in place

It's still open for discussion though, so we can consider adding some shortcuts where needed; overall we try to preserve shortcuts for the most frequently used commands, so this should be looked at carefully.

I think what we're talking about here are just aliases, not "shortcut commands" (extra commands at the top level).
Adding aliases isn't going to interfere with any custom aliases that users already have today.
I'd be happy to re-open #27468


Possibility to add video

Hello,
Is this project still active ?
I would like to know if there is a way to add video to the powerpoint ?

@pythonicrubyist ?

@pythonicrubyist Is there a way to add gifs ?

I created a dart port that supports all media types!
https://github.com/rodydavis/flutter_pptx


Build error with latest flutter/agp versions

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.22

Plugin version
1.0.13

Android version
14

iOS version
--

macOS version
--

Xcode version
--

Google Chrome version
--

Android Gradle Plugin
8.4.0

Device information:  irrelevant, as this is a build error
Description
Expected behavior:
Be able to compile an app on Android using this plugin with obfuscation/minification
Current behavior:
Build error during minification:
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in .../build/flutter_inappwebview_android/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class android.window.BackEvent (referenced from: void io.flutter.embedding.android.FlutterActivity.startBackGesture(android.window.BackEvent) and 3 other contexts)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':flutter_inappwebview_android:minifyReleaseWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete

Steps to reproduce

Depend on flutter_inappwebview
Upgrade to latest flutter/AGP/...
Do a release build with minification (e.g. flutter build apk --obfuscate --split-debug-info /tmp/debug-info. Alternatively, skip --obfuscate --split-debug-info ... and set minifyEnabled true in android/app/build.gradle

It would be great if the according PR could be merged quickly, as this currently blocks us (and probably other devs as well) from building releases, and downgrading to an earlier version is quite cumbersome as the API has changed in between.

Any luck pointing your dependency to the pull request? it doesn't work on my side

Ah, good point!
Got it to run with:
dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/holzgeist/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: d89b1d32638b49dfc58c4b7c84153be0c269d057

Ah, good point! Got it to run with:
dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/holzgeist/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: d89b1d32638b49dfc58c4b7c84153be0c269d057

You saved my deploy today. Thank you so much!

Still having an issue even afetr depending on holzgeist repo
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/username/Desktop/projectname/build/app/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class com.google.j2objc.annotations.ReflectionSupport$Level (referenced from: com.google.common.util.concurrent.AbstractFuture)
Missing class com.google.j2objc.annotations.ReflectionSupport (referenced from: com.google.common.util.concurrent.AbstractFuture)
Missing class com.google.j2objc.annotations.RetainedWith (referenced from: com.google.common.collect.ImmutableSet com.google.common.collect.ImmutableMap.entrySet and 3 other contexts)

FAILURE: Build failed with an exception.

Still having an issue even afetr depending on holzgeist repo
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/username/Desktop/projectname/build/app/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class com.google.j2objc.annotations.ReflectionSupport$Level (referenced from: com.google.common.util.concurrent.AbstractFuture)
Missing class com.google.j2objc.annotations.ReflectionSupport (referenced from: com.google.common.util.concurrent.AbstractFuture)
Missing class com.google.j2objc.annotations.RetainedWith (referenced from: com.google.common.collect.ImmutableSet com.google.common.collect.ImmutableMap.entrySet and 3 other contexts)

FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:minifyReleaseWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete

@specOper99  - looks like your issue is not linked to flutter_inappwebview, but that fact that your proguard.pro file is not there.
check if you have the proguard-rules.pro file in your project (android/app/). if not create one and then add the following lines
-ignorewarnings
-keep class * {
public private *;
}

@Yohan-J You have an issue with Proguard but it's a different one. check the actual issue here.

Actual issue is about the R8: Missing class android.window.BackEvent and your issue is R8: Missing class com.google.j2objc.annotations.ReflectionSupport$Level that is from a different thing.

@nayanbabariya  yes, this wasn't my issue, but i was also replying to the comment above mine, stating that his issue was something else.

@Yohan-J Okay. but the mentioned issue is from the flutter_inappwebview plugin.

In my case, it seems the issue was cause by youtube_player_flutter that depends on flutter_inappwebview

the same here

the same here. but, I solved it.
my error code
Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/jeonglockpark/Desktop/work/daopass/daopass/build/flutter_inappwebview_android/outputs/mapping/release/missing_rules.txt.

Add 1
dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/holzgeist/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: d89b1d32638b49dfc58c4b7c84153be0c269d057

Add 2
# Please add these rules to your existing keep rules in order to suppress warnings.
# This is generated automatically by the Android Gradle plugin.
-dontwarn com.google.j2objc.annotations.ReflectionSupport$Level
-dontwarn com.google.j2objc.annotations.ReflectionSupport
-dontwarn com.google.j2objc.annotations.RetainedWith

The build was successful with the two additional methods above. Hopefully the package will be updated normally soon.
Thanks a lot.

Sorry, where am i putting this add, which file, Gradle or proguard?

the same here. but, I solved it.
my error code
Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/jeonglockpark/Desktop/work/daopass/daopass/build/flutter_inappwebview_android/outputs/mapping/release/missing_rules.txt.

Add 1
dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/holzgeist/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: d89b1d32638b49dfc58c4b7c84153be0c269d057

Add 2
# Please add these rules to your existing keep rules in order to suppress warnings.
# This is generated automatically by the Android Gradle plugin.
-dontwarn com.google.j2objc.annotations.ReflectionSupport$Level
-dontwarn com.google.j2objc.annotations.ReflectionSupport
-dontwarn com.google.j2objc.annotations.RetainedWith

The build was successful with the two additional methods above. Hopefully the package will be updated normally soon.
Thanks a lot.

Sorry, where am i putting this add, which file, Gradle or proguard?

The first add goes to your pubspec.yaml file.
Just add that below your dependencies block if you don't have any dependency_overrides yet. This tells the build pipeline to not use the real dependency but instead the one defined as override (a specific commit in a different repo).
The second one is not required in my setup, so you might not need it either. But if you do, this goes to the proguard-rules.pro  file in your project's android/app folder.

Ah, good point! Got it to run with:
dependency_overrides:
  # TODO: Recheck once flutter_inappwebview version >6.0.0 is released
  flutter_inappwebview_android:
    git:
      url: https://github.com/holzgeist/flutter_inappwebview
      path: flutter_inappwebview_android
      ref: d89b1d32638b49dfc58c4b7c84153be0c269d057

After I added dependency_overrides, my apk size increased from 60 Mb to almost 110 Mb!

Noted with thanks, let me do that and build.
On Wed, Jul 3, 2024, 15:59 Sergio Molchanovsky @.***>
wrote:

Ah, good point! Got it to run with:
dependency_overrides:
TODO: Recheck once flutter_inappwebview version >6.0.0 is released
flutter_inappwebview_android:
git:
url: https://github.com/holzgeist/flutter_inappwebview
path: flutter_inappwebview_android
ref: d89b1d32638b49dfc58c4b7c84153be0c269d057
After I added dependency_overrides, my apk size increased from 60 Mb to
almost 110 Mb!

—
Reply to this email directly, view it on GitHub
https://github.com/pichillilorenzo/flutter_inappwebview/issues/2139#issuecomment-2206165151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMS3LJIU4U3FGOGHOXJFWS3ZKP7TBAVCNFSM6AAAAABHV2CYFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGE3DKMJVGE
.
You are receiving this because you commented.Message ID:
@.***>

I'm still sitting on a flutter_inappwebview 5.8, and we managed to remove this R8 error by adding the following line in the beginning of the android/build.gradle script:
project.gradle.startParameter.excludedTaskNames.add(":flutter_inappwebview:minifyReleaseWithR8")

I hope it will help to someone.

I'm still sitting on a flutter_inappwebview 5.8, and we managed to remove this R8 error by adding the following line in the beginning of the android/build.gradle script:
project.gradle.startParameter.excludedTaskNames.add(":flutter_inappwebview:minifyReleaseWithR8")

I hope it will help to someone.

This really helps

We tried @subzero911 's fix (which seems better than referencing a PR branch) but did not work for our app, because when building from clean repo, skipping the minification task caused other tasks to fail because they weren't finding the expected output (the jar file).
This is an evolution of that fix, which properly disables minification instead of skipping the task, and for us it works even when building from scratch.
Add this in the android/build.gradle file:
subprojects {
    afterEvaluate {
        if (it.name == "flutter_inappwebview_android") {
            it.android.buildTypes.release.minifyEnabled = false
        }
    }
}

If your file already has a subprojects / afterEvaluate section you might have to put it in there instead.
Anyway, should the minification be enabled for an open source android library project? I think that generally it shoudn't, because the code would be merged with the whole app's codebase and minification would then run globally.. so a better "official" fix could be to change minifyEnabled to false in this project's build.gradle. @pichillilorenzo what do you think?

I still have this problem and none of solutions provided is working for me.

I encountered evaluation timing issues when configure within the android/build.gradle file. To resolve this, I moved the configuration to the settings.gradle file and used the beforeProject and afterEvaluate hooks. This method worked
include ":app", ":flutter_inappwebview_android"

gradle.beforeProject { project ->
    if (project.name == "flutter_inappwebview_android") {
        project.afterEvaluate {
            if (project.hasProperty("android")) {
                project.android.buildTypes.release.minifyEnabled = false
            }
        }
    }
}

I'm still on version 5.8.0 because of some reasons, tried both methods above from @cc-rock and @HelmiAshraf and none of them worked :(
I can see the minifyEnabled property being set to false, if I println project.android.buildTypes.release.minifyEnabledit shows minifyEnabled as false but the same R8 error keep happening :(
I also added -dontwarn android.window.** to my proguard file and it also did not work :(
Did anyone manage to build in release mode with the version 5.8? Actually, did upgrading to 6.0.0 fixes the issue or not?

I encountered evaluation timing issues when configure within the android/build.gradle file. To resolve this, I moved the configuration to the settings.gradle file and used the beforeProject and afterEvaluate hooks. This method worked
include ":app", ":flutter_inappwebview_android"

gradle.beforeProject { project ->
    if (project.name == "flutter_inappwebview_android") {
        project.afterEvaluate {
            if (project.hasProperty("android")) {
                project.android.buildTypes.release.minifyEnabled = false
            }
        }
    }
}

After I upgrade to Gradle 8.5, this solution works.

I'm still on version 5.8.0 because of some reasons, tried both methods above from @cc-rock and @HelmiAshraf and none of them worked :(
I can see the minifyEnabled property being set to false, if I println project.android.buildTypes.release.minifyEnabledit shows minifyEnabled as false but the same R8 error keep happening :(
I also added -dontwarn android.window.** to my proguard file and it also did not work :(
Did anyone manage to build in release mode with the version 5.8? Actually, did upgrading to 6.0.0 fixes the issue or not?

@edisonlsm I'm using 5.8.0 and I made it work with @HelmiAshraf solution but you need to change "flutter_inappwebview_android" to "flutter_inappwebview" on version "5.xx"

We tried @subzero911 's fix (which seems better than referencing a PR branch) but did not work for our app, because when building from clean repo, skipping the minification task caused other tasks to fail because they weren't finding the expected output (the jar file).
This is an evolution of that fix, which properly disables minification instead of skipping the task, and for us it works even when building from scratch. Add this in the android/build.gradle file:
subprojects {
    afterEvaluate {
        if (it.name == "flutter_inappwebview_android") {
            it.android.buildTypes.release.minifyEnabled = false
        }
    }
}

If your file already has a subprojects / afterEvaluate section you might have to put it in there instead.
Anyway, should the minification be enabled for an open source android library project? I think that generally it shoudn't, because the code would be merged with the whole app's codebase and minification would then run globally.. so a better "official" fix could be to change minifyEnabled to false in this project's build.gradle. @pichillilorenzo what do you think?

Since the branch is no longer available (at least I can't connect to the branch anymore when run pub get), this solution works by far.
My build.gradle is this right now:
allprojects {
    repositories {
        google()
        mavenCentral()
    }
    // --------------------- ADDED HERE ---------------------
    subprojects {
        afterEvaluate {
            if (it.name == "flutter_inappwebview_android") {
                it.android.buildTypes.release.minifyEnabled = false
            }
        }
    }
}

// AND THIS IS THE REST OF MY GRADLE...

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

tasks.register("clean", Delete) {
    delete rootProject.buildDir
}

Another problem, if it is a "problem", the package youtube_player_flutter: ^9.0.0 depends on flutter_inappwebview: ^6.0.0, and I cannot downgrade to inappwebview 5.8.0
Hope this package get and update soon! (8 months since last time to this days)

Thanks bro for the update
On Wed, Sep 11, 2024, 15:42 Juan Manuel Flecha @.***>
wrote:

We tried @subzero911 https://github.com/subzero911 's fix (which seems
better than referencing a PR branch) but did not work for our app, because
when building from clean repo, skipping the minification task caused other
tasks to fail because they weren't finding the expected output (the jar
file).
This is an evolution of that fix, which properly disables minification
instead of skipping the task, and for us it works even when building from
scratch. Add this in the android/build.gradle file:
subprojects {
afterEvaluate {
if (it.name == "flutter_inappwebview_android") {
it.android.buildTypes.release.minifyEnabled = false
}
}
}
If your file already has a subprojects / afterEvaluate section you might
have to put it in there instead.
Anyway, should the minification be enabled for an open source android
library project? I think that generally it shoudn't, because the code would
be merged with the whole app's codebase and minification would then run
globally.. so a better "official" fix could be to change minifyEnabled to
false in this project's build.gradle. @pichillilorenzo
https://github.com/pichillilorenzo what do you think?
Since the branch is no longer available (at least I can't connect to the
branch anymore when run pub get), this solution works by far.
My build.gradle is this right now:
allprojects {
repositories {
google()
mavenCentral()
}
// --------------------- ADDED HERE ---------------------
subprojects {
afterEvaluate {
if (it.name == "flutter_inappwebview_android") {
it.android.buildTypes.release.minifyEnabled = false
}
}
}
}
// AND THIS IS THE REST OF MY GRADLE...
rootProject.buildDir = '../build'
subprojects {
project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
project.evaluationDependsOn(':app')
}
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
Another problem, if it is a "problem", the package youtube_player_flutter:
^9.0.0 depends on flutter_inappwebview: ^6.0.0, and I cannot downgrade to
inappwebview 5.8.0
Hope this package get and update soon! (8 months since last time to this
days)
—
Reply to this email directly, view it on GitHub
https://github.com/pichillilorenzo/flutter_inappwebview/issues/2139#issuecomment-2343712786,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMS3LJJY5VH33W4PZ3ANCNTZWBCERAVCNFSM6AAAAABHV2CYFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBTG4YTENZYGY
.
You are receiving this because you commented.Message ID:
@.***>

Is there any other package because it is still not working, same warning?

For everyone who wants hotfix and waiting for update. You can comment version com.android.application 8+ in android/settings.gradle
plugins {
// id "com.android.application" version "8.1.0" apply false
id "com.android.application" version "7.3.0" apply false
}

Any update?

Fixed in v6.1.1

Anyway, should the minification be enabled for an open source android library project? I think that generally it shoudn't, because the code would be merged with the whole app's codebase and minification would then run globally.. so a better "official" fix could be to change minifyEnabled to false in this project's build.gradle. @pichillilorenzo what do you think?

@cc-rock I think you are right, so the developer should know what to "-keep" inside the proguard-rules.pro file of the his/her App in case the minification is enabled.
Doing so now could be a breaking change, so it could be part of the next major version.

I'm still sitting on a flutter_inappwebview 5.8, and we managed to remove this R8 error by adding the following line in the beginning of the android/build.gradle script:
project.gradle.startParameter.excludedTaskNames.add(":flutter_inappwebview:minifyReleaseWithR8")

I hope it will help to someone.

This really helps

This works with release builds, But I am unable to open browser any idea why.


Code improvements to the @module macro

The goal of this ticket is to make in the@module macro improvements, in line with #87.

Done in the PR #104


feat(chat): update favorite chat keys

It seems ok I didn't find other problem, waiting for @InfamousVague


Need to do verification of Email in Email Setting.

Mail looks like and that allows a person to do any scam/fraud.


New users 5-10 added

I added 5 new names to the user file. More comedians.

I added the users in class. I add the final reviews for Kelly, Ryan, Kevin, and Toby. If anyone has a better or funnier review to leave that might know these characters better, please let me know what to add or change :)


Replace README

Description
Update the README with the project information.

Re-opened in https://github.com/wazuh/wazuh-dashboard/pull/51
See https://github.com/wazuh/wazuh-dashboard/issues/1#issuecomment-1516555068 for details.


inconsistent message on the completed application page

the completed application page explains that you will not get a physical permit, but also asks for the user to display this in their car window. This should be one or the other

Hi @colin2678 I've taken a look and can't see the inconsistency. I might just be missing it. Could you be a bit more specific?

Apologies, I have been away for the past couple of weeks. Please find attached a screen of the inconsistency.

^^ I hope that worked, as images are still blocekd on Github for me :-(

Same as #280 but for PP

I'm closing this issue as the new copy fixes it


Update controllers.rst [ci skip]

Updated the controllers to use the BaseController and added references to the original controller.
Each pull request should address a single issue and have a meaningful title.
Checklist:

[ x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[x ] User guide updated
[x ] Conforms to style guide

Paul, are you saying to remove the namespace and use cause on all of the example controlers in the section?

@InsiteFX Only the use CodeIgniter\BaseController; part should be removed. Please restore the <?php namespace App\Controllers;.


fix: update error message for auth on non null fields

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8863 (82ad1e5) into releaseGQLE2E (6cf30fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           releaseGQLE2E    #8863   +/-   ##
==============================================
  Coverage          55.60%   55.60%
==============================================
  Files                870      870
  Lines              48722    48725    +3
  Branches            9688     9689    +1
==============================================
+ Hits               27090    27094    +4
+ Misses             20755    20754    -1
  Partials             877      877

Impacted Files
Coverage Δ

...l-auth-transformer/src/graphql-auth-transformer.ts
88.46% <100.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf30fd...82ad1e5. Read the comment docs.


Issue with token check in uploadEpochRoot

Concerning this line:
https://github.com/coordinape/coordinape-protocol/blob/62df1c61c97e6c74437838fdda8059b27f171511/contracts/ApeProtocol/ApeDistributor.sol#L62
There are two issues:

This checks the _token argument against ApeVault.vault, which is the address of the underlying Yearn vault. Perhaps it should be one of the following instead:

require(address(ApeVaultWrapperImplementation(_vault).token()) == _token, "Vault cannot supply token");

require(address(ApeVaultWrapperImplementation(_vault).vault().token()) == _token, "Vault cannot supply token");

This check prevents using uploadEpochRoot for the vault's simpleToken. so we'd need to do something like this:

require(
  address(ApeVaultWrapperImplementation(_vault).token()) == _token ||
  address(ApeVaultWrapperImplementation(_vault).simpleToken()) == _token,
  "Vault cannot supply token"
);

thx @teeolendo for finding this


Fix issue 11161

What is the purpose of the change
fix https://github.com/apache/dubbo/issues/11161
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11187 (ff984c8) into 3.1 (6967ab4) will decrease coverage by 4.97%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##                3.1   #11187      +/-   ##
============================================
- Coverage     69.30%   64.32%   -4.98%
+ Complexity      127       14     -113
============================================
  Files          1502     1423      -79
  Lines         79085    59327   -19758
  Branches      13893     8723    -5170
============================================
- Hits          54813    38165   -16648
+ Misses        19496    17100    -2396
+ Partials       4776     4062     -714

Impacted Files
Coverage Δ

.../dubbo/common/serialize/MultipleSerialization.java
0.00% <0.00%> (ø)

...bbo/rpc/protocol/tri/ReflectionPackableMethod.java
81.28% <100.00%> (-1.40%)
:arrow_down:

...common/serialize/DefaultMultipleSerialization.java
100.00% <100.00%> (ø)

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...istrycenter/processor/FindPidWindowsProcessor.java
5.40% <0.00%> (-81.09%)
:arrow_down:

... and 501 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Adding in restify integration, docs, tests more...

Adds in restify, some new tests (would like to move these to a shared util and test in each integration). I've went through as much md files as I could to update fw support, but may have missed a place or two.
Let me know your thoughts!

Appears coveralls isn't yet working. Here's the coverage stats after this PR:
=============================== Coverage summary ===============================
Statements   : 98.21% ( 660/672 )
Branches     : 89.46% ( 297/332 )
Functions    : 100% ( 151/151 )
Lines        : 99.06% ( 631/637 )
================================================================================```

Hey folks, this has been sitting for a few weeks, any thoughts/concerns/comments?

I'll take a look at it soon! Thanks for the reminder.

@joelgriffith Thanks, it looks good at first glance! What were the necessary changes compared to the express version? It might be helpful to point those out in comments in the code, because most of it looks very similar.

@joelgriffith let's get this merged some time soon! I think we're pretty close, so it would be a shame if we dropped it now.

Hi.  Any idea when this PR might get merged?  I understand it's possible to use the express variant with restify, but it would be cleaner to have a restify variant out of the box.  I've pulled down @joelgriffith's fork to try locally (though running into a schema issue, but that's most likely because I'm new to GraphQL).  Thanks.

Hi @jadkap, im happy to see you want to take over this,
if you need any help (running into schema issues for example ;)) feel free to consult on slack (@hagaico)

Haha @DxCx, did I say I wanted to take this over?  I will see, given time constraints.

well @jadkap, you already downloaded it locally to try it off, if you make it work, why not contribute it back ;)
and if you didn't make it work, as i said, you are welcome to reach me for consultant over slack :)

Hey folks, sorry, been tied up as does seem the case.
I'm lost on where this is... I only see a conflict in CHANGELOG.md, I can fix whatever and push?

@joelgriffith , you better hold on for #180 which will be merged any time now,
after you will rebase upon it, your integration code will look much much smaller.

0.5.1 branch is merged :)
@jadkap / @joelgriffith can one of you take over and rebase / align so we can merge?

I'll take a stab at it later today, will push once everything is resolved

great @joelgriffith thanks! 👍

Pushed my rebase and fixes. I'm not able to complete an install or run tests, so I'm not sure what the issue is:
# jgriffith @ jgriffith in ~/Griffin/graphql-server on git:feature/restify-integration|MERGING x [11:46:51] C:1
$ npm i

> undefined postinstall /Users/jgriffith/Griffin/graphql-server
> lerna bootstrap

Lerna v2.0.0-beta.30
Bootstrapping 8 packages
Installing external dependencies
Errored while running BootstrapCommand.execute
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/jgriffith/.nvm/versions/node/v6.9.1/bin/node" "/Users/jgriffith/.nvm/versions/node/v6.9.1/bin/npm" "install" "<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code E404

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/graphql-server-integration-testsuite
npm ERR! 404
npm ERR! 404  'graphql-server-integration-testsuite' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jgriffith/Griffin/graphql-server/packages/graphql-server-restify/npm-debug.log

OK! Types are fixed, as are tests, and README. The interesting thing to note is that restify doesn't support namespacing of the .use API, so you have to verbosely do a .get and a .post for query parsing and json parsing to work. README shows correct usage (and tests do as well).

@helfer please merge #274 which should fix the travis issues,
then merge this upon this should give you a branch that passes tests.

Thanks @joelgriffith for fixing it up, and thanks @DxCx for fixing the travis issues. You guys are awesome!

Thanks all for getting this merged.  I was able to try latest and found a couple of things.  (BTW, the "schema" issue I previously encountered was a symlink/node_modules issue.)  @joelgriffith, if you have time, I'd appreciate your input on https://github.com/apollostack/graphql-server/pull/285.


Putting settings without ImmutableSettings class

Hi!
In my project, I'm using Jest to be able to communicate to Elasticsearch without the need of including Elasticsearch dependencies in my pom. For putting a mapping, creating an index and querying this is working excellent. However, it seems that for putting settings through Jest, using the ImmutableSettings class from the ES libraries is necessary. Is there a way of putting settings without using this class?

Hi @rutgervanwilligen
Sorry for the late reply. I'm not sure what type of settings you want to put, if it is cluster settings then we have io.searchbox.cluster.UpdateSettings and if it is index settings then we have io.searchbox.indices.settingsUpdateSettings both of which takes any object as the payload, so you can just supply the appropriate JSON string (or a map) if you'd like.
Please feel free to re-open this issue if it was not resolved.


Error: Could not load the default credentials shows up randomly once a day

From @darciusal on August 2, 2017 18:58
I have set up a google cloud function to monitor a bucket with frequent file changes.
The function reads files starting with a specific prefix and later generate new files to another bucket base on the files it reads, otherwise it will ignore the file and finish execution.
The function uses service account json to access/write files.
Those files starting with a specific prefix are updated only once a day.
The function is generating the new files properly and information seems correct.
However, by looking at the function logs, I notice that this error
(Error: Could not load the default credentials. Browse to https://developers.google.com/accounts/docs/application-default-credentials for more information....) shows up once or twice a day.
Could it be a bug in the gcloud library?
Copied from original issue: GoogleCloudPlatform/google-cloud-node#2501

From @darciusal on August 2, 2017 22:19
I believe it's triggered by logging-winston which leads to the code here
https://github.com/google/google-auth-library-nodejs/blob/bd13376281a3af6e73fb729ea867950739c3c899/ts/lib/auth/googleauth.ts#208

From @stephenplusplus on August 4, 2017 21:33
@ofrobots any thoughts on this one?

From @darciusal on August 11, 2017 6:25
Hey @ofrobots,
I tried disabling logging-winston, but I was still getting this error.
I also encountered Auth error:Error: read ECONNRESET everyday.
For the function logic part, I have tried my best on making sure it's right. I have shared the function with you internally so you can confirm it as well.
Thanks!

From @ofrobots on August 8, 2017 0:47
Hi @darciusal! A few questions for you: What version of google-cloud/logging-winston are you using on your GCF application? Are there any other google-cloud libraries you are also using? Is there anything else functionally wrong in your function, or do you believe it is just the log messages that are being affected? The 'once or twice' errors you get, are they around a specific time, or at random times during the day.
I am trying to figure out if problem may be related to key expiry or whether it might be related to TCP timeouts in case your function got spun down to very low resources. Responses to the questions above might give me some clues.

From @darciusal on August 14, 2017 21:2
Hi @ofrobots, Thanks for the response!
I have question on what do you mean for the "background work" you mentioned above.
Do you mean some of the business logic code that execute after the callback function is called?
If so, my function won't call the callback function until all logic are finish executing. (Example below)
const workPromise = createPromise();
workPromise.then(() => {...; callback()})

I have also noticed the ECONNRESET error before I used the winston function, so I am not sure if it is caused by the logging library.
Any chance do you think it is similar issue to this?
https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2254
I thought they already changed the default forever agent to false though.

From @ofrobots on August 14, 2017 18:21
Hi. I am pretty sure this issue is due to your Cloud Function getting throttled down to zero during periods of inactivity. Any TCP sockets that are pending at the time this happens will probably timeout/reset and error when the function is resumed on a subsequent request.
There are two different symptoms you reported here:

Error: Could not load the default credentials.: This is reported by the google-auth-library (as you indicated above) which is used internally by both storage and logging. Subsequent requests to authenticate should succeed as the higher level libraries (e.g. logging) retry upon failure. Unless, of course, your function gets throttled again. I have opened https://github.com/google/google-auth-library-nodejs/issues/160 to get the auth-library to internally retry on socket timeout / connection reset.
Auth error:Error: read ECONNRESET: This is coming from the gRPC library which is used by the logging library internally. It suggests the same throttling issue.

Fundamentally this means that, if your function is getting low enough traffic, the background work in your function may get starved due to throttling and as a result you may see those warnings.
One work-around you can try is by adding a delay before you terminate your function:
function eventHandler(event, callback) {
  // Your business logic here.
  // ...

  // delay terminating the function by a bit so that background tasks can drain.
 setTimeout(callback, 2000);
}

I'm going to close, since it appears the issue opener is no longer a registered GitHub member. If anyone else is still experiencing this issue, or I'm overlooking work that needs to be done, please let me know.

@stephenplusplus I'll assume the role of the issue opener :-)
I'm auditing all our triggers using @google-cloud/logging-winston and the log events will seemingly randomly not appear in StackDriver.
Please see this example where the logger's event listener sees the log messages which ought to go to StackDriver (they don't):

...and then a little bit later in StackDriver you'll see the OP's error:

I'll try and put @ofrobots suggestion of a "wait to drain" at the end of each trigger, but this is obviously not a long-term solution.

"winston": "^2.4.2"
"@google-cloud/logging-winston": "^0.9.0",

Hi @opyate. Thanks for the report and the detailed information. Based on the error, it seems that, for whatever reason, the code fails to identify the running environment to be GCF (or rather, GCP in general).  This causes auth to fail with the above error.
To be able to debug this further, I think we need to make a change in dependent module (gcp-metadata) that is currently swallowing unexpected errors instead of bubbling them up. I'm trying to fix this in https://github.com/stephenplusplus/gcp-metadata/pull/57, and once that gets released, it would good if you could try with the updated code. I want to know the precise reason why we were unable to identify your GCF running environment as lacking the metadata service.
I'll ping this thread once the modules have been updated with the necessary fix to debug this further.

@opyate  Looking at the OP, I think the error you're seeing is slightly different. You running into an 'Unexpected error occurred...' which wraps the 'Unable to load application default' error. This is a slightly different path and I believe is a different root cause.
I am going to spin this off into a separate issue.

@ofrobots @stephenplusplus do you perhaps think I have missing log entries in StackDriver because I'm calling the logger in a continuation-local-storage context?
I.e. this portion of code:
return session.runAndReturn(() => {
            session.set('correlation-id', uuidv4())
            logger.info(`[audit pre] ${action}`, Object.assign(payload, {result: 'running...'}))

            return cb(...args).then(() => {
                return logger.info(`[audit] ${action}`, Object.assign(payload, {result: 'success'}))
            }).catch(err => {
                logger.error(`[audit] ${action}`, Object.assign(payload, {result: 'error'}))
                throw err
            })
        })


Detect and prevent synchronous recursion

Silently stop recursion when emitting transformed event. See https://github.com/taataa/tapspace/issues/74#issuecomment-365283418
Consider a situation where transformed from X causes emission of another transformed from Y. No problem. But then consider situation where in addition a transformed from Y causes transformed from X. We have an infinite recursion. Our event emitters form a directed graph and the event waves propagate in depth-first manner. A memoryless depth-first search cannot handle cyclic graphs. The recursion prevention adds memory to the depth-first search.
There is at least two potential downsides in recursion prevention.  Second, it denies intended recursion, where the programmer has implemented a recursion-ending mechanism.

See this article: http://www.eqqon.com/index.php/Preventing_Recursive_Events
It instructs to use a locking mechanism (what I first intended to do) or a Mediator Pattern.

Due to the downsides we won't fix the issue for now. If need for the feature arises, let us reopen the issue.


docs: CONTRIBUTING.md has stale links

Currently the CONTRIBUTING.md file points to the playground.ts file under src/. Just some small housekeeping.

Resolved with https://github.com/colinhacks/zod/pull/1584.


fix: invalid character in header

When I used your module I got this Error:
Invalid character in header content ["Server-Timing"]
I try to fix this error with some regex to remove invalid characters from the header

Codecov Report

Merging #59 (953000a) into main (cc47902) will decrease coverage by 0.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   34.93%   34.11%   -0.83%
==========================================
  Files           8        8
  Lines          83       85       +2
  Branches       11       11
==========================================
  Hits           29       29
- Misses         54       56       +2

Impacted Files
Coverage Δ

src/runtime/index.ts
0.00% <0.00%> (ø)

src/templates/store.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc47902...953000a. Read the comment docs.


feat(root): update syntax and terraform provider for AWS

Please find in the following pull request an update to the Terraform provider to match the requirements of the new WebACL Module. This update ensures compatibility and allows deployment within the same Spacelift stack. Minor syntax issues have been fixed to meet the Terraform lint standards as per our pre-commit configuration. Due to the nature of these changes, I have bumped the module version to 3.0.0.

The PR resolves: https://github.com/mondelez-ctiso/terraform-aws-api-gateway-v1/issues/14


No validation link & endless "Resend Link" spinner when signing up to New Expensify on iOS

Slack thread
Action Performed:

Sign up to New Expensify on iOS (v. <IP_ADDRESS>)
Check email
Click "Resend Link"

Expected Result:
Receive a validation link when signing up or when clicking "Resend Link"
Actual Result:
No validation email and endless spinner when
Example 1<EMAIL_ADDRESS>
Example 2<EMAIL_ADDRESS>
Workaround:
None - Completely prevented from logging in
Platform:

iOS - <IP_ADDRESS>

Early investigation:
@marcaaron noticed User_SignUp is not being called here. We should be calling createAccount()

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Just a thought, but not getting a link when signing up is one thing.
An endless spinner when we press "Resend link" could be a different thing entirely.

Ok so I did some testing here...
Local dev build from main + production API (which all staging & production builds use) on iPhone 8

Had no issues getting a validate email at all.
Pressed "Resend link" twice and did not see an endless spinner either time.
Got the "Link has been re-sent" text that went away after a while in both cases.
New links showed up in my inbox fine.

I have used the same domain to create other accounts.
HOWEVER... I was not able to actually successfully validate my account at all. No matter what I do I keep getting this message 🤔

Is there an issue for that?

Might also be worth noting that I am having the same issue on staging web, but there we don't even show an error ☹

Marc was unable to replicate this and created a separate issue here for the validate link issue https://github.com/Expensify/App/issues/5328#

I was able to make this happen once in my local dev with the IOS simulator..
https://user-images.githubusercontent.com/87341702/134103165-5c219970-5c45-45ca-9c21-1aed049e07c4.mov
My suspicions are that we are trapped re-queuing the request to get a new validation code here:
https://github.com/Expensify/App/blob/986c5213932cf544c2e9c486abf05c43bc1413f9/src/libs/Network.js#L184-L189
because the isQueuePaused wasn't set to false at some point.
This may be consistent with what @marcaaron says in slack thread about not seeing in the logs the request. If we are really trapped in this re-queueing "loop", we are not sending the requests.

this is a guess because I failed to debug properly when the issue happened and I have not been able to reproduce again since then.

Another possible way to get the isQueuePaused set to true without pausing it:
https://github.com/Expensify/App/blob/986c5213932cf544c2e9c486abf05c43bc1413f9/src/libs/API.js#L57-L64
It is very common for paramenters.authToken to be missing, but we normally have it available in authToken (sync from Onyx) and we just set it using that. But if the authToken also wasn't available, we will pause the queue and redirect to the login screen without unpausing it. If you try to create a new account after getting redirected, and click the "Resend link" button, we get stuck in the endless spin.

If this isn't easily reproducible then maybe it's not a blocker? Should we just hold this issue

If this isn't easily reproducible then maybe it's not a blocker? Should we just hold this issue

I agree with that, I haven't been able to reproduce this in a real use case.

Seems like a duplicate of #5233 which has a hold on it. So maybe we should keep the conversation in one place.

yes, looks like a duplicate.

I was able to replicate this again by chance, and now I think I know a little better how to replicate it.
I had a debugger in the function pauseRequestQueue and when logging out, it stopped there:

Looking at the stack, I see that we are calling it from:
https://github.com/Expensify/App/blob/986c5213932cf544c2e9c486abf05c43bc1413f9/src/libs/API.js#L54-L67
To replicate it, I just started logging in, logging out, logging in, etc... until at some point I stop at the debugger. There seem to be some race condition that when we log out, we removing authToken from Onyx just before this request is done:
{
  command: "Get",
  parameters: {
    reportIDList: "13",
    returnValueList: "reportSummaryList"
  }
}

Considering that isQueuePaused lingering with true value after logout is happing by a race condition, this may be more likely to happen in production than what we thought, considering the higher volume of users. On the other hand, I think it is unlikely that a user will try to create a new account after login out so I think this symptom in particular is not high priority, but I'm not sure if the isQueuePaused lingering with a true value after logout could cause other not reported side-effects.
Video of the bug happening after letting the debugger continue:
https://user-images.githubusercontent.com/87341702/134242532-fe7860fc-bd5d-4b5e-8905-5e629ae42c28.mov
My initial thought is that this could be solved by calling unpauseRequestQueue right after this line:
https://github.com/Expensify/App/blob/986c5213932cf544c2e9c486abf05c43bc1413f9/src/libs/API.js#L62