Unable to see Schedule / Calendar button in issue Creation

Hi,
I followed the readme and installed the plugin + cron successfully. I edited my project settings to enable the recurring task module, but i don't see any schedule section in the issue creation form.
I also set the permissions for my role to be able to do the recurring tasks actions.
Do you know what i am missing ?
I'm using the plugin over a french translation version of redmine with these settings :

Environment:
Redmine version                3.3.4.stable
Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux]
Rails version                  <IP_ADDRESS>
Environment                    production
Database adapter               Mysql2
SCM:
Subversion                     1.6.11
Git                            1.7.1
Filesystem
Redmine plugins:
redmine_agile                  1.4.4
redmine_checklists             3.1.10
redmine_messenger              0.9.9
redmine_recurring_tasks        0.2.2
redmine_redsun                 2.1.1

And here is my issue creation page :

Thanks for your time.

And here is my issue creation page :

Did you enable module "Redmine Recurring Tasks" in this project?
Please send screenshot of created task.

Yes I did, but I understant now : it's only visible once the issue is created. You should maybe add that to the readme, that the "Schedul section" is visible on the show/edit page of the issue and not on the new issue form.
Thanks for your super quick answer ! :+1:


Simplify the management of the "waiting for response" state in ExchangeContext

Problem
    CancelResponseTimer();

    // If the context was expecting a response to a previously sent message, this message
    // is implicitly that response.
    SetResponseExpected(false);

Check if we can simplify the management of the "waiting for response" state in ExchangeContext
Proposed Solution
Simplify the management of the "waiting for response" state in ExchangeContext

In particular, can we avoid needing two function calls that have to come together to manage the state properly?

We are cleaning up the pending issue now, I think setting the response expected to false separately after receiving the response make the code easier to understand.
    // Since we got the response, cancel the response timer.
    CancelResponseTimer();

    // If the context was expecting a response to a previously sent message, this message
    // is implicitly that response.
    SetResponseExpected(false);

Close for now and will reopen later if needed.


Fixes issue/527

Version 2.12.1 not including typescript types
Switched extension search in scripts/src-to-dist.cjs to use ".ts" and ".mts" so the types get added to the build.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Nesting of AQL literal does not work

While nesting AQL seems to work and nesting aql literal in aql seems to work, nesting an aql literal inside another aql literal does not work:
const { literal: aqlLiteral } = require('arangojs/aql')

const literal1 = aqlLiteral('myObj')
const literal2 = aqlLiteral(`RETURN ${literal1}`)
const query = aql`
  LET myObj = { test: 'test' }
  ${literal2}
`

Results in the following query:
  LET myObj = { test: 'test' }
  RETURN [object Object]

Yeah, I see what you're saying.  aqlLiteral() isn't the same as the aql template tag.  So the backticks are being evaluated before aqlLiteral is even involved.  My bad.


Global Pending Inductions #247

Fix #247

This is great. I'll do a more full review soon--if not this weekend, then Monday. A few thoughts:

I think most status buttons should be neutral unless it's an actionable status for an induction you are a party to. For example, in the screenshot below, "Complete ceremony" looks like I should be able to take action to complete it...but I'm not a party to that induction so that button should probably look like the other buttons and say "Waiting for ceremony" or something like that.

I have a different entry point to this page in mind. Instead of going to Community and seeing the message there under new members, I envision a link under the Call to Action (or your current invitations, if you have any) saying something like: "View all pending invitations to Eden." But I don't have that well-defined yet. We should prob merge what's here (after my review and changes to buttons) and then I can tweak that. I also see the "N pending invitations" stat on the home page linking here too.

I think most status buttons should be neutral unless it's an actionable status for an induction you are a party to. For example, in the screenshot below, "Complete ceremony" looks like I should be able to take action to complete it...but I'm not a party to that induction so that button should probably look like the other buttons and say "Waiting for ceremony" or something like that.

Nice catch!

I have a different entry point to this page in mind. Instead of going to Community and seeing the message there under new members, I envision a link under the Call to Action (or your current invitations, if you have any) saying something like: "View all pending invitations to Eden." But I don't have that well-defined yet. We should prob merge what's here (after my review and changes to buttons) and then I can tweak that. I also see the "N pending invitations" stat on the home page linking here too.

I like both ideas. Let's merge it for now and iterate on it later.


[Subtask]: Design new send flow as preparation for stardust

Task description
As there will be multiple sending flow for stardust based networks we need to update the sending flow so that the user can easily send IOTA and other assets, while making use of the feature blocks available in the extended output.
Requirements
Design / update design for existing transaction flows:

Send IOTA >= 1Mi
Send IOTA < 1Mi
Add a cancelation date to a transaction
Confirm the storage deposit on a transaction that requires one
Add a public reference to a transaction

Acceptance criteria
Design approved by epic owner / product owner
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Just missing a custom date picker, hopefully we can find one on the internet to make it easy.


make generate

This change pulls in some updates from upstream and generates the manifests and fix linting issues

@philipgough  to build a dynamically linked binary for FIPS compliance, I suggest we do the following

Copy Makefile =>  Makefile.prow and update it with CGO_ENABLED=1 so it builds dynamically linked binary
Change Dockerfile.prow here as

RUN  make -f Makefile.prow thanos-receive-controller

Thoughts?


added mobile-friendly hover states

Description
Added mobile-friendly hover states meaning that the hover states won't "stick" on moblie. Issue described in this csstricks article.
Used ButtonSecondary for the settings link on the site and for the edit button on the landscape cards for consistency.
The idea behind the edit button on the landscape card is because eventually there will also be links to the sites that use that landscape. Otherwise just clicking the card will take you to edit, and the button would be redundant.
I made editing the landscape the default action when clicking the card.

Im not sure about making the whole landscape card clikable. In develop the sites links are there now, so wont it be weird for the whole card to be clickable when there are other clickable things within the card?


Script to automatically send email by fetching address from a txt file

Script that fetches the email address from a .txt file and sends the email to it with the compiled email as an attachment. #385
@mariobehling @mananwason Please review.

@the-dagger We need to have the apk folder as an argument to the script. Please wait for a day before merging yourself.

Oh ok.
But why is that so?
The location for the generated apk is going to be constant and so is the apk name.
So why do we need to pass the folder as an argument?

So the thing is that we want to have as many people as there can be to generate apk's at the same time and you have hardcoded a folder that has been created by one particular string. What I am doing in the script is that I am creating a new folder with the name same as that of the email of the organiser entered on the webpage, now according to your script, it will always get the same apk which was meant for the developer with the email address<EMAIL_ADDRESS>so it' not right, please rectify it, then I'll integrate it in the python script I made

@mananwason Ok, got it. :+1:
Something like this looks good? http://hastebin.com/owaquyuvip.bash

Looks fine @the-dagger


Azure Cache for Redis: Azure AD with Jedis client library

Azure Cache for Redis: Azure AD with Jedis client library
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/src/samples/Azure-Cache-For-Redis/Jedis/Azure-AAD-Authentication-With-Jedis.md
Can Azure China use this function?

@g2vinay could you please follow up with @ArtistLL123


Use system catalogs instead of 'information_schema'

We need to better understand what's going on with the quoting before this can be merged.


Should we use the conda-forge version of Cartopy rather than that on PyPi?

Comment:
Currently, this package follows the PyPi version: https://github.com/conda-forge/cartopy_offlinedata-feedstock/blob/08a2a178fbedd52ab202e7dc6db53d1bcc51be43/recipe/meta.yaml#L10
As the Conda-Forge package may lag behind this at least a few hours, we'd probably want to depend on the Conda-Forge package version? Not sure how we do this.
Pinging @ocefpaf

@willirath, it is normal that we get the source code for PyPI on conda-forge. We could get it from GitHub instead but not from conda-forge itself.

Note that the cartopy recipe itself gets source from PyPI:
https://github.com/conda-forge/cartopy-feedstock/blob/main/recipe/meta.yaml#L8

As the Conda-Forge package may lag behind this at least a few hours, we'd probably want to depend on the Conda-Forge package version? Not sure how we do this.

I'm a maintainer on both this and the cartopy feedstock, so I can just wait until a the cartopy package is ready to merge this.  I don't think there's a good alternative unless we make this part of the main carotpy recipe or have a bot migrator for cartopy (neither if which seems appealing to me).

I'm going to close this because I don't think there's anything to do.


Topic recognition

Improved Unet model that is used to map a mask to skin Lessions in the ISIC dataset
Contains
dataset.py - Function for data loading
modules.py - Improved Unet model
predict.py - Used to use model after training
train.py - Used to train model
Aaron Reynolds
Student ID: 47479049

Files are a bit chaos, but containing all necessary ones. Trained model is included in the repository, which is not allowed as per the spec.

Algorithm solves the problem appropriately. Average Dice Coefficient in testing dataset: 0.88, but no evidence.

Correctly using PyTorch to construct the Improved U-Net models and functions.

Good coding design. Well handwriting code.

Sufficient docstring and comment in the code.

Easy difficulty problem, no higher difficulty marks.

Wrong pull request branch, from local:topic-recognition branch to shakes76:main branch.

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks missing -1
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting minimal -1
No Data leakage
Difficulty: Easy -10
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe OK, missing usage and other info -2
Model/technical explanation, could be better -1
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in InCorrect Branch) -2
Feedback required, remove model files and correct branch and remove gitignore files -2
Request Description OK

No feedback attempt and no feedback marks granted.


[DR] Multiblock allgather

For multiblock simulations, we will need an allgather operation that gathers an array across multiple connected blocks. We can accomplish this through a series of sends and receives based on  the already existing gkyl_multib_comm_conn object. This DR outlines 3 components needed for such an operation

Functions for creating a gkyl_multib_comm_conn with the connections necessary for an allgather
An allgather method which uses the gkyl_multib_comm_conn objects to perform an allgather using sends and receives
Tracing the block topology to find the connected blocks

Prototype work is in the branch: gk-g0-app_blocked_sol_allgather
1 gkyl_multib_comm_conn_new_from_connections
The gkyl_multib_comm_conn_new_send and gkyl_multib_comm_conn_new_recv methods which create a gkyl_multib_comm_conn object with the gkyl_comm_conn's appropriate for a sync between the ghost cells of blocks.
There will be a similar set of two functions gkyl_multib_comm_conn_new_send_from_connections and gkyl_multib_comm_conn_new_recv_from_connections which create a gkyl_multib_comm_conn object with the gkyl_comm_conn's appropriate for an allgather between blocks given a list of the connected block ids.
The signature for the functions is
struct gkyl_multib_comm_conn * gkyl_multib_comm_conn_new_send_from_connections( int block_id, int block_rank,  int nconnected, int* block_list, int dir,  struct gkyl_rect_decomp **decomp)
This signature differs from the gkyl_multib_comm_conn_new_send in that it does not take the number of ghost cells or the gkyl_block_connections,  struct but instead takes the number of connected blocks, a list of connected blocks, and the direction in which they are connected.
Here is how the two functions in multib_comm_conn.c work:
The way it works for a send:

Compute the cross-range which spans the connected blocks
Shift the indices of the source rank's range into the cross-range index space.
Loop over all the other (target) ranks and for each create a gkyl_comm_conn with the {rank = other rank, buid = other rank's bid, range = intersect of the shifted source rank's range and the cross range}
Assemble the connections into a gkyl_multib_comm_conn struct and return it

The way it works for a recv:

Compute the cross-range which spans the connected blocks
Loop over all the other (target) ranks and for each
2.1 Shift the other (target) rank's range into the the cross-range index space
2.2 create a gkyl_comm_conn with the {rank = other rank, bid = other rank's bid, range = intersect of the shifted target rank's range and the cross range}
Assemble the connections into a gkyl_multib_comm_conn struct and return it

The prototype implementation of these functions in branch gk-g0-app_blocked_sol_allgather has been confirmed to work for the 3-block L-shaped domain with various numbers of cuts.
2 The allgather function
The allgather_multib would go in mpi_comm.c where the sync_multib method currently is. We could decide a different location for these later if necessary. The idea for this function is that the mbapp would call allgather_multib with a set of send and receive gkyl_comm_conn_multib objects it created from the functions described in section 1. This call would gather arrays on blocks connected in a particular direction.
The signature is
static int allgather_multib(struct gkyl_comm *comm, int num_local_blocks, int *local_blocks,   struct gkyl_multib_comm_conn **mbcc_send, struct gkyl_multib_comm_conn **mbcc_recv,   struct gkyl_range **local, struct gkyl_range **global,   struct gkyl_array **array_local, struct gkyl_array **array_global)
There would be num_local_blocks of mbcc_send, mbcc_recv, local, global, array_local, and array_global passed to the function.
The function does the following:

Loops over the mbcc_recv objects  (this is a loop over num_local_blocks) and posts a receive for every comm_conn in each of them.
Loops over the mbcc_send objects  (loop over num_local_blocks) and posts a send for every comm_conn in each of them.
Loops over the array_global (loop over num_local_blocks) and completes the send/recv and copies the data from the received buffer into the global array.

Handling many sends/recvs from a rank to itself:  In case where one rank handles a cut of one block and also handles an entire other block, the messages to itself need to be distinguished. If the source and destination ranks for a send are the same, the message is given a tag = 1000*receiver's block id + sender's block id.   If the source and destination ranks for a recv are the same, the message is given the same tag of tag = 1000*receiver's block id + sender's block id. This is the reason that the function takes the    int *local_blocks argument.
The prototype implementation of this function in branch gk-g0-app_blocked_sol_allgather has been confirmed to work for the 3-block L-shaped domain with various  decompositions.
3 Tracing the block_topology
This is the simplest component and is needed to provide an input block list for the functions in section 1. I thought this stage should be separated from the functions in 1 because it can be used for other purposes. If you specify a connection type (either neighbors, all blocks connected, or blocks touching at a corner) and a direction, this function will trace the block topology to give you a list of blocks.
Currently the signature will be
int gkyl_multib_conn_get_connection(gkyl_gyrokinetic_multib_app *mbapp, int bidx, int dir, enum gkyl_conn_id conn_id, int *block_idxs)
Given your block index, direction, and connection type it will trace the block topology and return the number of connected blocks and populate the list block_idxs with the block indices.
The connection types are specified by
enum gkyl_conn_id {   GKYL_CONN_NEIGHBOR = 0, // Adjacent blocks   GKYL_CONN_ALL = 1, // Blocks connected along one direction   GKYL_CONN_CORNER = 2, // Blocks connected by a corner };
and the dir argument is not used for the corner connection type.
This function with type GKYL_CONN_ALL can work for getting all blocks connected along a specific direction and can be used to provide an input block list for gkyl_multib_comm_conn_new_from_connections described in section 1.
The implementation of this function in branch gk-g0-app_blocked_sol_allgather  works for all tests conducted on the 12-block X-point geometry.

Don't break layering in: gkyl_multib_conn_get_connection. Take btopo as an argument rather than mbapp.

Rename _pr and _br to full names in comm_new_from_connections


Updating to Java 11 causes vault to to not find reactor.netty.http.client.HttpClient

Working project with Java 10, tested with 2.0.5.RELEASE, 2.0.6.RELEASE and 2.1.0.M4 with Spring Cloud Finchley.SR1 and Greenwich.M1.  Project works and runs as expected.
Changing only the Java version from 10 to 11 gives the error of
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:303)
	at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:284)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1307)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1153)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:538)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:498)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:848)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:865)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:548)
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:797)
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:421)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:340)
	at org.springframework.boot.builder.SpringApplicationBuilder.run(SpringApplicationBuilder.java:139)
	at org.springframework.cloud.bootstrap.BootstrapApplicationListener.bootstrapServiceContext(BootstrapApplicationListener.java:197)
	at org.springframework.cloud.bootstrap.BootstrapApplicationListener.onApplicationEvent(BootstrapApplicationListener.java:104)
	at org.springframework.cloud.bootstrap.BootstrapApplicationListener.onApplicationEvent(BootstrapApplicationListener.java:70)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:127)
	at org.springframework.boot.context.event.EventPublishingRunListener.environmentPrepared(EventPublishingRunListener.java:75)
	at org.springframework.boot.SpringApplicationRunListeners.environmentPrepared(SpringApplicationRunListeners.java:54)
	at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:371)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:330)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1291)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1279)
	at com.chg.documentservice.DocumentServiceApplication.main(DocumentServiceApplication.java:10)
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration$$EnhancerBySpringCGLIB$$99154ba1]: Constructor threw exception; nested exception is java.lang.NoClassDefFoundError: reactor/netty/http/client/HttpClient
	at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:184)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:117)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:299)
	... 30 common frames omitted
Caused by: java.lang.NoClassDefFoundError: reactor/netty/http/client/HttpClient
	at org.springframework.vault.config.ClientHttpConnectorFactory.create(ClientHttpConnectorFactory.java:54)
	at org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration.createConnector(VaultReactiveBootstrapConfiguration.java:105)
	at org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration.<init>(VaultReactiveBootstrapConfiguration.java:86)
	at org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration$$EnhancerBySpringCGLIB$$99154ba1.<init>(<generated>)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:172)
	... 32 common frames omitted
Caused by: java.lang.ClassNotFoundException: reactor.netty.http.client.HttpClient
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
	... 41 common frames omitted

This is not a Webflux project.  I understand Java 11 removed certain classes from the JDK, but these are not the classes that were removed.

Can you provide a reproducer? VaultReactiveBootstrapConfiguration checks on the presence of Project Reactor and WebFlux. We don't check for the presence of Reactor Netty.
There should be actually no connection between the used Java versions and this issue but rather a connection to your dependencies.

Thanks for the quick reply!  It's a work project, and it has happened on two unrelated projects.  Let me see if I can get a minimal working reproduction.

I have seen this same behavior of building/running under Java 10 and failing when run under Java 11.  Ours is also on "work projects", so I can't share the source.  I was able to get a small repro case that showed our failure was related to integrating with HashiCorp's Vault.   For this we use spring-cloud-starter-vault-config and an internally developed package.   What I can share are some of the filtered console outputs when the app fails to start under Java 11.  None of the output contains references to our internal package's code.  For details, this was built using Oracle Java 10.0.2 and run using Oracle java 11.0.1.  The pom.xml has 3 dependencies; spring-boot-starter-web, spring-cloud-starter-vault-config, and the internally developed package.  And I'm using spring-boot-starter-parent 2.1.0.RC1
2018-10-25 09:06:40.334  INFO 7169 --- [           main] o.s.core.annotation.AnnotationUtils      : Failed to introspect annotations on class org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration: java.lang.IllegalStateException: Could not obtain annotation attribute value for public abstract java.lang.Class[] org.springframework.boot.autoconfigure.condition.ConditionalOnClass.value()
2018-10-25 09:06:40.386  INFO 7169 --- [           main] o.s.core.annotation.AnnotationUtils      : Failed to introspect annotations on class org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration: java.lang.IllegalStateException: Could not obtain annotation attribute value for public abstract java.lang.Class[] org.springframework.boot.autoconfigure.condition.ConditionalOnClass.value()
2018-10-25 09:06:40.479  INFO 7169 --- [           main] o.s.core.annotation.AnnotationUtils      : Failed to introspect annotations on class org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration: java.lang.IllegalStateException: Could not obtain annotation attribute value for public abstract java.lang.Class[] org.springframework.boot.autoconfigure.condition.ConditionalOnClass.value()
2018-10-25 09:06:40.557  INFO 7169 --- [           main] o.s.core.annotation.AnnotationUtils      : Failed to introspect annotations on class org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration: java.lang.IllegalStateException: Could not obtain annotation attribute value for public abstract java.lang.Class[] org.springframework.boot.autoconfigure.condition.ConditionalOnClass.value()
2018-10-25 09:06:40.581 ERROR 7169 --- [           main] o.s.boot.SpringApplication               : Application run failed
java.lang.IllegalStateException: Error processing condition on org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration.reactiveVaultSessionManager
at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:64) ~[spring-boot-autoconfigure-2.1.0.RC1.jar!/:2.1.0.RC1]
Caused by: java.lang.IllegalStateException: Failed to introspect Class [org.springframework.cloud.vault.config.VaultReactiveBootstrapConfiguration] from ClassLoader [org.springframework.boot.loader.LaunchedURLClassLoader@7946e1f4]
at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:680) ~[spring-core-5.1.1.RELEASE.jar!/:5.1.1.RELEASE]
Caused by: java.lang.NoClassDefFoundError: reactor/core/publisher/Mono
at java.base/java.lang.Class.getDeclaredMethods0(Native Method) ~[na:na]
Caused by: java.lang.ClassNotFoundException: reactor.core.publisher.Mono
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471) ~[na:na]

@mdeibler-expe Can you share the reproducer? It would be great to find out what is causing the issue instead of blindly putting a patch on it.

I can share the pom.xml, and the code in the repro package - it's extremely minimal.  What I can't share is the third dependency mentioned above - the internally developed package.  It's not open source...  And without access to our Vault servers, the vault code complains and errors; so running the repro outside is hard.
I fully understand your situation, and want to help (why I'm posting here).  I'm dropping the log level to debug and going through that output this morning to see if anything jumps out.  I'll post what I find.

I can also share the full console output.  Is there a better way to share that, then pasting in 100's of lines here?

After looking through the TRACE level console logs, I don't see anything obvious (to me).  What I see is that normal Spring setup and processing stops fairly early, and the process stops with the INFO/ERROR and Exceptions already listed above.  The build-using-10-run-using-10 trace log contains essentially the same entries (except for the INFOs/ERROR listed above), and then continues for several thousand lines after the build-using-10-run-using-11 trace log.
On the previous comment/entry, I'm guessing that the java command option for debug/tracing is set earlier in the setup process than the application.yml settings are processed and setup.  Another indication that setup and processing fails early and everything afterwards is impacted.
I looked at keys that were not found in both runs ("Could not find key...") and they list the same values until the build-on-10-run-using-11 logs stop.  Similar with "did not find any beans" entries.  The key "spring.cloud.vault.reactive.enabled" was listed as not found more often in the build-on-10-run-using-11 log (even though it appeared in both logs).  I'll look into that next.

I'm fine with a list of dependencies that are prefixed with org. and io. groupId's (mvn dependency:list) No need to get your internal dependency. Please make sure that the internal dependency is free from reactor. and org.springframework packages.

The mvn depdency:list is the same under both 10.0.2 and 11.0.1 - as expected.  Below is the full dependency:list output.  I've left in the lines coming from our internal package; there isn't any IP there.
Note, my current theory is that something is breaking during the Spring setup process and that causes a fall back to unexpected paths (i.e. reactor...), which eventually prevents the run from succeeding.  And logging statements are not showing what's going wrong and, importantly, where.
[INFO] The following files have been resolved:
[INFO]    org.springframework.boot:spring-boot-starter-web:jar:2.1.0.RC1:compile -- module spring.boot.starter.web [auto]
[INFO]    org.springframework.boot:spring-boot-starter:jar:2.1.0.RC1:compile -- module spring.boot.starter [auto]
[INFO]    org.springframework.boot:spring-boot:jar:2.1.0.RC1:compile -- module spring.boot [auto]
[INFO]    org.springframework.boot:spring-boot-autoconfigure:jar:2.1.0.RC1:compile -- module spring.boot.autoconfigure [auto]
[INFO]    org.springframework.boot:spring-boot-starter-logging:jar:2.1.0.RC1:compile -- module spring.boot.starter.logging [auto]
[INFO]    ch.qos.logback:logback-classic:jar:1.2.3:compile -- module logback.classic (auto)
[INFO]    ch.qos.logback:logback-core:jar:1.2.3:compile -- module logback.core (auto)
[INFO]    org.apache.logging.log4j:log4j-to-slf4j:jar:2.11.1:compile -- module org.apache.logging.slf4j [auto]
[INFO]    org.apache.logging.log4j:log4j-api:jar:2.11.1:compile -- module org.apache.logging.log4j
[INFO]    org.slf4j:jul-to-slf4j:jar:1.7.25:compile -- module jul.to.slf4j (auto)
[INFO]    javax.annotation:javax.annotation-api:jar:1.3.2:compile -- module java.annotation [auto]
[INFO]    org.springframework:spring-core:jar:5.1.1.RELEASE:compile -- module spring.core [auto]
[INFO]    org.springframework:spring-jcl:jar:5.1.1.RELEASE:compile -- module spring.jcl [auto]
[INFO]    org.yaml:snakeyaml:jar:1.23:runtime -- module snakeyaml (auto)
[INFO]    org.springframework.boot:spring-boot-starter-json:jar:2.1.0.RC1:compile -- module spring.boot.starter.json [auto]
[INFO]    com.fasterxml.jackson.core:jackson-databind:jar:2.9.7:compile -- module com.fasterxml.jackson.databind [auto]
[INFO]    com.fasterxml.jackson.core:jackson-annotations:jar:2.9.0:compile -- module jackson.annotations (auto)
[INFO]    com.fasterxml.jackson.core:jackson-core:jar:2.9.7:compile -- module com.fasterxml.jackson.core [auto]
[INFO]    com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.9.7:compile -- module com.fasterxml.jackson.datatype.jdk8 [auto]
[INFO]    com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.9.7:compile -- module com.fasterxml.jackson.datatype.jsr310 [auto]
[INFO]    com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.9.7:compile -- module com.fasterxml.jackson.module.paramnames [auto]
[INFO]    org.springframework.boot:spring-boot-starter-tomcat:jar:2.1.0.RC1:compile -- module spring.boot.starter.tomcat [auto]
[INFO]    org.apache.tomcat.embed:tomcat-embed-core:jar:9.0.12:compile -- module tomcat.embed.core (auto)
[INFO]    org.apache.tomcat.embed:tomcat-embed-el:jar:9.0.12:compile -- module tomcat.embed.el (auto)
[INFO]    org.apache.tomcat.embed:tomcat-embed-websocket:jar:9.0.12:compile -- module tomcat.embed.websocket (auto)
[INFO]    org.hibernate.validator:hibernate-validator:jar:6.0.13.Final:compile -- module org.hibernate.validator [auto]
[INFO]    javax.validation:validation-api:jar:2.0.1.Final:compile -- module java.validation [auto]
[INFO]    org.jboss.logging:jboss-logging:jar:3.3.2.Final:compile -- module org.jboss.logging [auto]
[INFO]    com.fasterxml:classmate:jar:1.4.0:compile -- module com.fasterxml.classmate [auto]
[INFO]    org.springframework:spring-web:jar:5.1.1.RELEASE:compile -- module spring.web [auto]
[INFO]    org.springframework:spring-webmvc:jar:5.1.1.RELEASE:compile -- module spring.webmvc [auto]
[INFO]    org.springframework:spring-aop:jar:5.1.1.RELEASE:compile -- module spring.aop [auto]
[INFO]    org.springframework:spring-expression:jar:5.1.1.RELEASE:compile -- module spring.expression [auto]
[INFO]    org.springframework.cloud:spring-cloud-starter-vault-config:jar:2.0.2.RELEASE:compile -- module spring.cloud.starter.vault.config (auto)
[INFO]    org.apache.httpcomponents:httpclient:jar:4.5.6:compile -- module org.apache.httpcomponents.httpclient [auto]
[INFO]    commons-codec:commons-codec:jar:1.11:compile -- module org.apache.commons.codec [auto]
[INFO]    org.apache.httpcomponents:httpcore:jar:4.4.10:compile -- module org.apache.httpcomponents.httpcore [auto]
[INFO]    org.springframework.cloud:spring-cloud-starter:jar:2.0.2.RELEASE:compile -- module spring.cloud.starter (auto)
[INFO]    org.springframework.cloud:spring-cloud-context:jar:2.0.2.RELEASE:compile -- module spring.cloud.context (auto)
[INFO]    org.springframework.security:spring-security-crypto:jar:5.1.1.RELEASE:compile -- module spring.security.crypto [auto]
[INFO]    org.springframework.cloud:spring-cloud-commons:jar:2.0.2.RELEASE:compile -- module spring.cloud.commons (auto)
[INFO]    org.springframework.security:spring-security-rsa:jar:1.0.7.RELEASE:compile -- module spring.security.rsa (auto)
[INFO]    org.bouncycastle:bcpkix-jdk15on:jar:1.60:compile -- module org.bouncycastle.pkix [auto]
[INFO]    org.bouncycastle:bcprov-jdk15on:jar:1.60:compile -- module org.bouncycastle.provider [auto]
[INFO]    org.springframework.cloud:spring-cloud-vault-config:jar:2.0.2.RELEASE:compile -- module spring.cloud.vault.config (auto)
[INFO]    org.springframework.vault:spring-vault-core:jar:2.0.2.RELEASE:compile -- module spring.vault.core [auto]
[INFO]    com.expedia.www.platform:platform-ensconce-spring:jar:1.0.1:compile -- module platform.ensconce.spring (auto)
[INFO]    com.expedia.www.platform:platform-ensconce:jar:1.0.1:compile -- module platform.ensconce (auto)
[INFO]    org.springframework:spring-beans:jar:5.1.1.RELEASE:compile -- module spring.beans [auto]
[INFO]    org.springframework:spring-context:jar:5.1.1.RELEASE:compile -- module spring.context [auto]
[INFO]    org.slf4j:slf4j-api:jar:1.7.25:compile -- module slf4j.api (auto)
[INFO]    org.apache.commons:commons-lang3:jar:3.8.1:compile -- module org.apache.commons.lang3 [auto]
[INFO]    org.apache.maven:maven-artifact:jar:3.3.3:compile -- module maven.artifact (auto)
[INFO]    org.codehaus.plexus:plexus-utils:jar:3.0.20:compile -- module plexus.utils (auto)
[INFO]

Our package/code has no dependency or reference to reactor in it - I did a code scan in our git repo.  The package does depend on springframework code.  Part of what is does is integrate Vault into spring-boot applications, so it has to at some point.  Here is the dependency:tree for our package.
[INFO] - com.expedia.www.platform:platform-ensconce-spring:jar:1.0.1:compile
[INFO]    +- com.expedia.www.platform:platform-ensconce:jar:1.0.1:compile
[INFO]    +- org.springframework:spring-beans:jar:5.1.1.RELEASE:compile
[INFO]    +- org.springframework:spring-context:jar:5.1.1.RELEASE:compile
[INFO]    +- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO]    +- org.apache.commons:commons-lang3:jar:3.8.1:compile
[INFO]    - org.apache.maven:maven-artifact:jar:3.3.3:compile
[INFO]       - org.codehaus.plexus:plexus-utils:jar:3.0.20:compile

Update: The stack trace is different, the originally reported issue is a class-load failure when trying to instantiate the reactive HTTP client. The reproducer (see gist fails in SpringBootCondition.

If I add a reactor dependency to the project's POM, the next error I get is a class not found exception for the netty HttpClient.  Just like the original submitter.  It seems my case hits the reactor issue first, and his doesn't (different dependencies is my guess).

I did have the same issue, which is when I reported this.  I am happy to help solve this

Based on investigation in Spring Boot and Spring Cloud, we found that this issue is caused by how Spring Cloud inspects bootstrap configuration. Here's the ticket to fix the issue in Spring Cloud: https://github.com/spring-cloud/spring-cloud-commons/issues/438

Related pull request: https://github.com/spring-cloud/spring-cloud-commons/pull/444

A quick question...  The issue you opened has been closed when the "#444" PR was merged.  This seems to be the only open issue now.  When and how can we verify that the changes made in that PR have indeed fixed the problem reported here?  I noticed there was a "RC2" release of that project a day prior to the PR got merged, so do we have to wait for the next M/RC release?

There are two pieces to the story:

We added a @ConditionalOnClass on Reactor's HTTP client (that's backported to 2.0.x).
Additionally, Spring Cloud needs to evaluate annotations using ASM instead of reflection.

The ASM change was merged after releasing Spring Cloud M2 so you either upgrade to the latest snapshots or you need to wait for Spring Cloud RC1 (see Spring Cloud Release for release dates).
Closing this ticket as it's resolved now.

With the more aggressive Java release schedule, is there anything you are doing to catch these early on? We rely on the library and cannot update to Java11 yet because of this bug. The fix is much appreciated. But it's hard to believe we're already 2 months in to the Java11 release!

Thanks a lot for bringing up the point of a changed Java release schedule. The new release schedule is a challenge on its own. We have here a project that has a quite long dependency chain:

Spring Framework is required by all Spring projects as a foundation to be released first as it is required to support a new Java release first.
Spring Vault needs to catch up if required.
Since Spring Cloud builds on top of Spring Boot, we need a Spring Boot release that picks up Spring Framework for the new Java release
Spring Cloud is required to ship a release.

Releases tend to happen in somewhat regular intervals of about a month in between. Let me take this issue to our team to see whether we can improve.

Just to close this out...  I can confirm that the use-cases detailed above have been addressed. I was able to do the confirmation by using the Greenwich.BUILD-SNAPSHOT in a dependencyManagement section of our pom.xml, while also removing the version specification for the spring-cloud-starter-vault-config dependency.


[Add-ins] Clean up links to OM docs

Related to https://github.com/OfficeDev/office-js-docs-pr/pull/1456.

Docs Build status updates of commit 93ee4c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/invoke-add-in.md
:white_check_mark:Succeeded

docs/add-ins/activation-rules.md
:white_check_mark:Succeeded

docs/add-ins/add-and-remove-attachments-to-an-item-in-a-compose-form.md
:white_check_mark:Succeeded

docs/add-ins/add-mobile-support.md
:white_check_mark:Succeeded

docs/add-ins/apis.md
:white_check_mark:Succeeded

docs/add-ins/authenticate-a-user-with-an-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/authentication.md
:white_check_mark:Succeeded

docs/add-ins/compare-outlook-add-in-support-in-outlook-for-mac.md
:white_check_mark:Succeeded

docs/add-ins/delegate-access.md
:white_check_mark:Succeeded

docs/add-ins/extract-entity-strings-from-an-item.md
:white_check_mark:Succeeded

docs/add-ins/get-and-set-item-data-in-a-compose-form.md
:white_check_mark:Succeeded

docs/add-ins/get-and-set-recurrence.md
:white_check_mark:Succeeded

docs/add-ins/get-attachments-of-an-outlook-item.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-location-of-an-appointment.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-time-of-an-appointment.md
:white_check_mark:Succeeded

docs/add-ins/get-set-or-add-recipients.md
:white_check_mark:Succeeded

docs/add-ins/inside-the-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/item-data.md
:white_check_mark:Succeeded

docs/add-ins/limits-for-activation-and-javascript-api-for-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/manifests.md
:white_check_mark:Succeeded

docs/add-ins/metadata-for-an-outlook-add-in.md
:white_check_mark:Succeeded

docs/add-ins/outlook-mobile-addins.md
:white_check_mark:Succeeded

docs/add-ins/outlook-on-send-addins.md
:white_check_mark:Succeeded

docs/add-ins/pinnable-taskpane.md
:white_check_mark:Succeeded

docs/add-ins/privacy-and-security.md
:white_check_mark:Succeeded

docs/add-ins/tips-for-handling-date-values-in-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/troubleshoot-outlook-add-in-activation.md
:white_check_mark:Succeeded

docs/add-ins/understanding-outlook-add-in-permissions.md
:white_check_mark:Succeeded

docs/add-ins/use-regular-expressions-to-show-an-outlook-add-in.md
:white_check_mark:Succeeded

docs/add-ins/use-rest-api.md
:white_check_mark:Succeeded

docs/add-ins/validate-an-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/web-services.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix objcImpl SILGen crash with initial value

The initial value expressions of stored properties in objcImpl classes were being incorrectly marked as serializable. As a result, the compiler would crash with a SIL verification failure if one of them called a non-public function or initializer.
Fix this problem by not marking these initial value expression functions as serializable. Code in other modules should not call them anyway, since they think of the class as a pure ObjC class.
Fixes rdar://114874429.

@swift-ci please test

I would need to change the attributes in the test, but otherwise, it should be.


Several Tv Show methods are missing

Wrapper doesn't include following methods:
https://developers.themoviedb.org/3/tv/get-tv-airing-today
https://developers.themoviedb.org/3/tv/get-tv-on-the-air

They are in fact. Use GetTvShowListAsync with OnTheAir or AiringToday.

I didn't realize that methods, thank you. I thought there are seperate methods for each list, like movie methods: GetMovieUpcomingListAsync, GetMovieNowPlayingListAsync, etc.
For consistency, I think it is a good idea to make an enum for movie methods, too.

We could make a few extension methods for that kind of stuff, although we'll be adding to a very large list of methods. :/


How to set aspect ratio, snapshot, get video info ?

Hi,
can you add some function as set aspect ratio mode (16:9, fit to screen,...), snapshot current video frame and get some information from video as: Resolution, Frame Rate, BitRate ?

I found function to set aspect ratio:
player.API.SetPropertyString("video-aspect", panel1.Width + ":" + panel1.Height);
snapshot to file:
player.API.Command("screenshot-to-file", "C:\1.jpg");
I trying to get snapshot and save it in buffer by this command:
player.API.Command("screenshot");
but I dont know where is data return.
Please help me.

@songoku141 Hi,
How can I set the jpeg quality parameter? I used this command
player.API.Command("screenshot-to-file", "C:\1.jpg", "screenshot-jpeg-quality", "70");
but I got the invalid parameter error.
Thanks

You can try like this:
player.API.SetPropertyLong("screenshot-jpeg-quality", 70);
player.API.Command("screenshot-to-file", "C:\1.jpg");

Thanks,
seem don't have command for screenshot to memory:
https://mpv.io/manual/master/#screenshot
close here.

You can try like this:
player.API.SetPropertyLong("screenshot-jpeg-quality", 70);
player.API.Command("screenshot-to-file", "C:\1.jpg");

@songoku141 Hi,
Thanks for the reply, But when I use this command I get an error:
 player.API.SetPropertyLong("screenshot-webp-quality", 75);
 player.API.Command("screenshot-to-file", $@"d:\{rnd}.webp");

Parameter not found

Thanks,
seem don't have command for screenshot to memory:
https://mpv.io/manual/master/#screenshot
close here.

Hi,
Did you try this command?
"screenshot-raw"
player.API.Command("screenshot-raw");
But I don't know, How to get the output in memory.


Rancher scheduling issue

Rancher versions:
rancher/server: v1.6.15
rancher/agent: v1.2.10
Infrastructure Stack versions:
healthcheck: v0.3.6
ipsec: v0.13.11
network-services: rancher/metadata:v0.10.2, rancher/network-manager:v0.7.20
scheduler:v0.8.3
kubernetes (if applicable): N/A
Docker version: (docker version,docker info preferred)  17.09.1-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)  CentOS Linux 7 (4.15.8)
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO) KVM/Linode
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB) SingleNode Rancher/InternalDB
**Environment Template: (Cattle/Kubernetes/Swarm/Mesos)**Cattle
Steps to Reproduce: Set container sheduling: needs host with label vrrp_1_role: backup AND host must have a container with label traefik_cluster_1=true
Results:
rancher server logs :
constraint result [true] : account id must be 1a5
constraint result [false] : needs host with label vrrp_1_role: backup
constraint result [false] : host must have a container with label traefik_cluster_1=true
constraint result [true] : storage pool for volume 24078 must be one of kind [sim, docker]
candidate result  [false]

Steps to reproduce:

Add host to rancher
Add labels onto host as following :

-- Labels:
--vrrp_1_role=master
--traefik_cluster_1=true
--require container label:
--io.rancher.container.system=
--traefik_cluster=true
--vrrp_1_role=master
3)add traefik stack
4) add label TRAEFIK_CLUSTER_1 = TRUE to traefik stack
5) add keepalived stack
6)add following scheduling rule:
the host MUST have a CONTAINER WITH LABEL of TRAEFIK_CLUSTER_1 = TRUE
Result:
Failed to allocate instance [container:1i24824]: Bad instance [container:1i24824] in state [error]: Allocation failed: host must have a container with label traefik_cluster_1=true, needs host with label vrrp_1_role: backup).
Note:
Though it says that "needs host with label vrrp_1_role: backup" failed it works before i do step 6

keepalived docker-compose:
version: '2'
services:
keepalived-backup:
cap_add:
- NET_ADMIN
image: PRIVATE_DOCKER/keepalived:1.1.0-phoenix11
environment:
KEEPALIVED_AUTOCONF: 'true'
KEEPALIVED_INTERFACE: eth0
KEEPALIVED_PREEEMPT: 'false'
KEEPALIVED_STATE: BACKUP
KEEPALIVED_TRACK_INTERFACE_1: eth0
KEEPALIVED_UNICAST_PEER_0: <IP_ADDRESS>
KEEPALIVED_UNICAST_SRC_IP: <IP_ADDRESS>
KEEPALIVED_VIRTUAL_IPADDRESS_1: '"IP/24 dev eth0"'
KEEPALIVED_VIRTUAL_ROUTER_ID: '2'
network_mode: host
labels:
io.rancher.scheduler.affinity:host_label: vrrp_1_role=backup
io.rancher.scheduler.affinity:container_label: traefik_cluster_1=true
keepalived-master:
cap_add:
- NET_ADMIN
image: PRIVATE_DOCKER/keepalived:1.1.0-phoenix11
environment:
KEEPALIVED_AUTOCONF: 'true'
KEEPALIVED_INTERFACE: eth0
KEEPALIVED_PREEEMPT: 'false'
KEEPALIVED_STATE: MASTER
KEEPALIVED_TRACK_INTERFACE_1: eth0
KEEPALIVED_UNICAST_PEER_0: <IP_ADDRESS>
KEEPALIVED_UNICAST_SRC_IP: <IP_ADDRESS>
KEEPALIVED_VIRTUAL_IPADDRESS_1: '"IP/24 dev eth0"'
KEEPALIVED_VIRTUAL_ROUTER_ID: '2'
network_mode: host
labels:
io.rancher.scheduler.affinity:host_label: vrrp_1_role=master
io.rancher.container.system: ''

Looks like its not a bug but lack of understanding how labels work :/


Items created from templates are on the wrong version number

I am writing some tests around some code that creates new items based on a template.  While doing this I noticed that the fields for the newly created item would only be populated if we called the code twice.  After some experimentation I found that the version of the item we were getting from the database on the first pass was version 2 but the field data was being put into version 1 on the first run.  I have reproduced this with the code below (using NUnit):
        [Test]
        public void FakeDbVersionMisnumber()
        {
            FakeDb = new Db()
            {
                new DbTemplate("ParentTemplate")
                {
                    new DbField("TestField")
                }
            };

            var database = Context.Database;

            TemplateItem parentTemplate = database.Items.GetItem("/sitecore/templates/ParentTemplate");
            Item contentItem = database.Items.GetItem("/sitecore/content");

            contentItem.Editing.BeginEdit();
            var templateBasedItem = ItemManager.CreateItem("TemplateBased", contentItem, parentTemplate.ID);
            contentItem.Editing.EndEdit();

            templateBasedItem.Editing.BeginEdit();
            // Creates the value at version number 1, not version number 2
            templateBasedItem.Fields["TestField"].Value = "TestValue";
            templateBasedItem.Editing.EndEdit();

            var newTest = database.GetItem("/sitecore/content/TemplateBased");

            Assert.AreEqual(1, newTest.Version.Number);  // Fails because the newTest item is returning a version number of 2
            // At this point the TestField value returned is an empty string because version 2 hasn't been set
            Assert.AreEqual("TestValue", newTest.Fields["TestField"].Value); // Fails because it is trying to access a value for version 2 which hasn't been set
        }
    }

Unfortunately I couldn't reproduce that performing the edit a second time fixed the problem.
I was able to reproduce this issue with 0.31.3 and 0.31.4.

Hi @indyK1ng,
The issue you reported is not reproduced on the latest version, could you please upgrade?
BTW, it's very important to dispose the db context properly, so I highly recommend you create and dispose it with using statement.

Oh jeez, I'm sorry about that.  I forgot that I was looking at the second page of releases and thought 0.31.4 was the latest version.  Thank you for catching that.
Also, thank you for your concern about not disposing of the db context.  When reporting the bug I decided not to show the TearDown method where I am disposing of the object.
Thank you again for your help.


Fails to write basic rock paper scissors game

I prompted it to create a CLI based rock paper scissors game, however, it failed to do so. I've heard good things about MetaGPT, is there something I'm doing wrong?
python startup.py "create a CLI based rock paper scissors game"
This is the code output:
## main.py
from game import Game

def main():
    game = Game()
    game.display_instructions()

    while True:
        game.get_user_input()
        game.get_computer_choice()
        game.play_round()
        game.update_score()

        play_again = input("Do you want to play again? (yes/no): ").lower()
        if play_again != "yes":
            break

        # Clear console
        os.system('cls' if os.name == 'nt' else 'clear')

if __name__ == "__main__":
    main()

As you can see, it failes to import os.
I'm using GPT4

We cannot guarantee that the output code will run directly. In most cases, it needs to be modified and debugged.
You can give more specific promt to get better results. For example, create a CLI based rock paper scissors game based on python3.9.7 which can run on macos and no bugs.
There is some work in roadmap to improve the first-run success rate.

Since no further responses are needed, we will close it. Please reopen it if necessary.


Fixed HUD positioning bug and added Japanese language support

The following updates have been made:

🧮 Changed HUD offset calculation
⚙ Added HUD offset config
🇯🇵 Added Japanese language support

Would you like to add new translations from d749125?

Thank you!
I added new translations https://github.com/aMelonRind/Stereopsis/pull/7 .


bugfix: fix sync status on stoping

这个 PR 实现什么功能/修复什么问题:
bugfix: fix sync status on stoping
是否需要 backport 到之前的 release 分支:
release/2.8.0
/area host
/cc @Zexi

/cherrypick release/2.9.0

/cherrypick release/2.8.0

Codecov Report

Merging #748 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #748      +/-   ##
=========================================
+ Coverage    7.35%   7.36%   +0.01%
=========================================
  Files         348     348
  Lines       55836   55839       +3
=========================================
+ Hits         4105    4114       +9
+ Misses      51352   51346       -6
  Partials      379     379

Flag
Coverage Δ

#aFlag
7.36% <0%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/hostman/guestman/qemu-kvm.go
1.69% <0%> (-0.01%)
:arrow_down:

pkg/hostman/guestman/guestman.go
4.13% <0%> (ø)
:arrow_up:

pkg/hostman/guestman/guesttasks.go
0% <0%> (ø)
:arrow_up:

pkg/util/seclib2/seclib.go
91.48% <0%> (-4.26%)
:arrow_down:

pkg/util/rbacutils/rabc.go
73.86% <0%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c3547...f2f46e0. Read the comment docs.

/lgtm
/approve


Figure out how to run unit tests

We could run tests on device with defmt-test. Do we have to split out functionality into separate crates in order to test on host?

Split out utility functions into a hangman_utils crate to allow for host unit testing


Multiple instances of Atom running on OSX

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom opens multiple instances of itself.  It seems to be related to different versions.
Steps to Reproduce

Have atom open.
atom is upgraded without restarting, perhaps?
Use atom command to open a folder.

Expected behavior:
Atom opens a new window within the same instance.
Actual behavior:
Atom opens a new instance of the main application:

Both these versions were running at the same time:

Reproduces how often:
100% under these circumstances.
Versions
See screenshots.

I have also had this problem previously (well, every time I've updated). Generally, after updating, I close everything and most of the time the old version disappears from the menu once I relaunch.

Thanks for taking the time to contribute!
We noticed that this may be a duplicate of https://github.com/atom/atom/issues/9117. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

@rsese Thanks for pointing me at that other issue.  This is indeed a duplicate.
That said, it is a little condescending even in a canned response to point me at github's search box when I already indicated that I checked for duplicates before posting.  The volume of issues open for atom often results in searches returning pages of unrelated issues.

It's mostly for consistency reasons.  More often than not people will check the checkbox without going through all the steps as a "hey look, I filled out the prereqs, now give me more attention" type of thing.  Don't take it negatively - we're aware that there's a ton of issues open, and sometimes the search box isn't that helpful :).


[WIP] Add optimization for TwoLocal synthesis when entanglement='full'

Summary
close # #8294
Update the NLocal class.
Details and comments
When choosing a TwoLocal or RealAmplitude or EfficientSU2 gate with entanglement=full on n-qubits (for VQE ansatz),
for a circuit with a CX sub-circuit, improve the number of CX gates from n*(n-1)/2 CX gates to only n CX gates with a linear connectivity

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 84.007%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
55882

Relevant Lines:
66521

💛  - Coveralls

@Cryoris - thanks for the quick and helpful review. I think this PR is ready to go now.


Make radio button fill same blue color as links

According to some sources, even in HTML5 it's not straightforward to do this.
https://stackoverflow.com/questions/45327086/how-change-the-color-of-the-radio-button
It's not difficult to set up the way the SO answer does, but setting the style so specifically could have unforeseen implications for other radio button displays.

This is not at all important, certainly not worth any extra development attention. Closing the ticket.


Add License

Are these examples published under a certain license, like GPL 3 or MIT?
Maybe you should add a license file.
Is there an attribution required, when embedding Peakfinder?

Thanks for the hint. I just added the MIT license. A special attribution is not required when embedding PeakFinder.


Fix pagination: make previous and next buttons accessible

Related issues
Closes #2008
Description
We currently have an a11y problem in pagination related to WCAG 2.1 Success Criterion 1.3.1 Info and Relationships (Level A) and WCAG 2.1 Success Criterion 1.3.2 Meaningful Sequence (Level A). It stated that all content must be available in text even when the CSS stylesheets are disabled.
If we disabled our stylesheets, the result is:

So:

'Previous' and 'Next' are not displayed at all (please note that it's the case for all examples, not only the current one)

It appears that the < and > are conveying informations so they need to be focusable even when CSS is off.
With this prototype:

Please note that I made the change only on the previous button to show the difference with the next button.
Motivation & Context
Improve a11y of pagination component
Types of change

New feature (non-breaking change which adds functionality)

Live previews

https://deploy-preview-2102--boosted.netlify.app/docs/5.3/components/pagination/#working-with-icons

Checklist
Contribution

[x] I have read the contributing guidelines

Accessibility

[x] My change follows accessibility good practices; I have at least run axe

Design

[x] My change respects the design guidelines defined in Orange Design System
[x] My change is compatible with responsive display

Development

[x] My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

(NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[x] My change introduces changes to the migration guide
(NA) My new component is added in Storybook
[x] My new component is compatible with RTL
[x] Manually run BrowserStack tests
[x] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
[x] Code review
[ ] Design review
[x] A11y review

After the merge

[ ] Manually launch Percy tests

To do after prototype validation

[ ] Make the change everywhere
[ ] Update migration guide

ok, fine

ok, with the "title", i think, it's usable :)

The pagination buttons with the icon only look good.
The space between the buttons is ok for both variants.
For the pagination buttons with the icons and labels, please follow the spacing guide attached. Thanks
Next_Previous_Spacing.zip

All looks good to me.


Google Resource Test Fails

Thanks for sharing the example. Very helpful.  My google authentication succeeds and I was able to retrieve the user info.  However when I try to test google resource it fails with following error.  I tried to set CORS on API Gateway for this resource but still fails with the following error.  Any thoughts on how to resolve it?
XMLHttpRequest cannot load https://xxxxxx.execute-api.ap-south-1.amazonaws.com/demo/google. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access. The response had HTTP status code 403.
Thanks

Can you confirm you redeployed your API after you reset the CORS configuration? Unfortunately I could not replicate the problem.

Actually taking another look, this is not a CORS error. It's related to permissions, I suggest to enable logging in APIGW to understand the issue. Can you double check the Auth IAM role cognito is using has access to the /google path?

IAM role cognito is using has access to goolge path.  I tried to to enable cloudwatch in APIGW but it keeps failing with error " The role ARN does not have required permissions set to API Gateway".  This happens when I try to add the ARN of the following role to the APIGW under setting.  Below are the my role and policy details. What am I missing?

Attached "AmazonAPIGatewayPushToCloudWatchLogs" policy under managed policies of the role under permissions tab.
In policy on the same tab has the following text:
{
"Version": "2012-10-17",
"Statement": [
{
"Action": [
"execute-api:Invoke",
"logs:"
],
"Resource": [
"arn:aws:execute-api:ap-south-1:xxxxx//GET/google",
"arn:aws:execute-api:ap-south-1:xxxxx//POST/google",
"arn:aws:logs:::"
],
"Effect": "Allow"
}
]
}
And the trust policy under trust relationships tab has the following text
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "",
"Effect": "Allow",
"Principal": {
"Service": "apigateway.amazonaws.com",
"Federated": "cognito-identity.amazonaws.com"
},
"Action": [
"sts:AssumeRoleWithWebIdentity",
"sts:AssumeRole"
],
"Condition": {
"StringEquals": {
"cognito-identity.amazonaws.com:aud": "ap-south-1:xxxxxx"
},
"ForAnyValue:StringLike": {
"cognito-identity.amazonaws.com:amr": "authenticated"
}
}
}
]
}

Could you please assist? Thanks

Unfortunately I still cannot replicate, I was presenting on the AWS Dev Day in Melbourne yesterday and confirmed with some other developers it worked fine in their account.
Might be a problem with permissions when the stack was created. Can you confirm it still happens if you delete the stack and create a new one following the instructions? Does the user running the cloudformation commands has permissions to create all resources?

Also create a separate role for the API Gateway logs, here are some instructions https://aws.amazon.com/premiumsupport/knowledge-center/api-gateway-cloudwatch-logs/ and http://docs.aws.amazon.com/apigateway/latest/developerguide/stages.html#how-to-stage-settings-console (Item 6)

Closing this one as I was not able to reproduce


Request returns EOF when using HTTP instead of HTTPS

If elasticsearch service is configured to use https, and http is used in the connection string, requests return EOF

Hi @AlexeyNikipelau
Unfortunately what you get is coming from golang transport due to the fact that you are targeting a closed http port.
I'll try to dig a bit deeper to see if we can improve the reporting of this.

Has this problem been solved？


Only apply deletion one time for unique term update in FrozenBufferedUpdates.applyTermDeletes

Description
For unique field like ES’ uid, there is only one live doc in all flushed segments.
We can early terminate FrozenBufferedUpdates.applyTermDeletes after this live doc deleted.

It is more complex to apply this optimization with soft delete, since we should not skip soft deleted docs if we want apply hard delete on them.

Could Lucene maybe track that a field is actually unique internally and then apply this optimization automatically / always correctly?

@jpountz
Do you have any idea about this?

Since we already have a PerThreadPKLookup, and implemented lookup in it, maybe implement delete one time in it is an option?

BTW, since we applyDeletes before writeTerms, should we skip deleted docs when writing postings(maybe skip storedFields too).

I see this has been discussed in https://issues.apache.org/jira/browse/LUCENE-5693, and  IDVersionPostingsWriter#startDoc implemented it (although it was markd as Won't Fix).


Enhance UI to group --repeat tests into collapsible sections

I often test with --repeat 20 to verify that output is reliable across multiple LLM runs. The resulting table output in the web viewer is hard to navigate due to all the duplicates.
It would be wonderful if I could get an overview of the tests and see at a glance how many times each test PASSED/FAILED out of the 20 runs.
Here is an idea for a simple UI improvement that could work for me:

Description of Test1 - 18 PASS, 2 FAIL
Normal table output goes here for all 20 instances of this test

Description of Test2 - 20 PASS
Normal table output goes here for all 20 instances of this test

One more comment on this, as I've considered parsing the json output and building our own UI to show results.
In the json output, there is currently nothing that you can use to group together different --repeats of the same test. So a good first step would be to add to the json output an identifier that you can use to group all the repeats of the same test.


Correction for raw affiliation CIRAD, UMR G-EAU, EGE Rabat

Correction needed for raw affiliation CIRAD, UMR G-EAU, EGE Rabat
raw_affiliation_name: CIRAD, UMR G-EAU, EGE Rabat
new_rors: 054qz6938;020g0rw41
previous_rors: 054qz6938
works_examples: W2972404247
contact: 63eb34ecf00f4ecf1b60e41d66985cc5:31ea2d32ee1b8da3139f000722cc4a08f93e @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Bump operator-sdk

Idea:
We still on the v0.17.0, sdk already have the v1.0.1. This card is about bumping to the latest release.
This would probably have some conflicts with #430 , so please consider it.

Fixed in https://github.com/shipwright-io/build/pull/462


Let SymbolicOperator coeff be sympy expressions

It would be useful to add sympy symbolic expression compatibility to the FermionicOperator/other operators to allow for cases when the amplitude on the operators is unknown.

This is something we've discussed in the past. Indeed, it would be very interesting and would be very useful. It would make OpenFermion a tool for deriving expressions in very general contexts.
It would be great to have more discussion of what the implementation might look like. I think we'd need to implement in such a fashion that the functionality is entirely optional.

Just wanted to add that it would be great to have this feature added to OpenFermion – can't wait to see #549 merged in :)

#549 was merged!


BPMSPL-151 - Change Impact prediction (preparation work on fully resolving imports in rules files)

This PR updates the EclipseJavaCompiler class to use the newer ECJ Compiler
constructor instead of the deprecated one.
The change is very simple and easy enough to figure out if you look at the deprecated
methods that were being used:

How to use CompilerOptions:
https://github.com/eclipse/eclipse.jdt.core/blob/R4_3_maintenance/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/Compiler.java#L161

How/why to set the CompilerOptions.parseLiteralExpressionsAsConstants field:
https://github.com/eclipse/eclipse.jdt.core/blob/R4_3_maintenance/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java#L495-498

I also included a small change to use the JavaCompilerFactory constructor (in the KieBuilder class),
since the JavaCompilerFactory.getInstance() method has also been deprecated.

For others reading this later: I reverted the KieBuilderImpl change (from JavaCompilerFactory.getInstance() to new JavaCompilerFactory()) after talking to Mario because we were unsure about possible side-effects.
The change is also incidental and not important to me.


Successfully processed but still "Paramater Incorrect Error"

Since psexec is not working for me i did it with nirsofts nircmd tool (actually advancedrun does the same to run as system admin). And the result is :
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -ExecutionPolicy Bypass -File "C:\Users\kali\Desktop\son\WindowsAppsUnfukker.ps1"
Welcome to the amazing WindowsApps Unfukker! Please sit tight!!
Backup of existing permissions...
Successfully processed 0 files; Failed processing 0 files
Saved to C:\Program Files\WindowsApps_20230519_190806.txt
Fixing WindowsApps permissions...
Fixing WindowsApps subfolders inheritance...
Successfully processed 164 files; Failed processing 0 files
Fixing WindowsApps subfolders permissions...
Fixing C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.16.10261.0_x64__8wekyb3d8bbwe
Fixing AppData Packages permissions, this could take a couple minutes...
Successfully processed 7196 files; Failed processing 0 files
processed file: C:\Users\kali\AppData\Local\Packages
Successfully processed 1 files; Failed processing 0 files
Unfukking finished!! (hopefully)"
Why do i still get the paramater inccorrect error when i try to run windows store apps?
Can you please help me with that. I just reverted back to windows 10 from windows 11 and thought it was related to windows 11. But now windows 10 has the same error.

Tried again with paexec and the result is the same. It says successful but  Still having the "Incorrect Parameter" with most of the Windows Store Apps like terminal, nvidia etc.. When i checked my second pc for the permissions. I realized the apps folder itself is owned by TrustedInstaller as expected but the subfolders like terminals etc belong the system. But with this scripts everything becomes owned by TrustedInstaller. Secondly I realized if i run the WindowsApps with the administrations rights they run flawlessly but as normally they always give the error of "Incorrect Parameter" and also other programs also get effected slightly like winrar and iobit uninstaller etc.. They give different errors. I did not mess up witht the ownerships. It just happened while i was on my routine work on windows. What do you think it could be? I am sick and tired of this shitty windows but most of the programs i use for the work only runs on windows.

The script does not alter the ownership of subfolders under WindowsApps. All my subfolders remain owned by SYSTEM after running the script. Can you zip and send me your earliest C:\Program Files\WindowsApps_XXX.txt backup?

Alright. Here you go https://www.upload.ee/files/15249047/WindowsApps_20230519_185656.zip.html. I also tried copying for example terminal folder to desktop and guess what from that folder i tried to run terminal and again it just works flawlessly. Somehow windowsapps folder is messed up and neither your script nor any solutions online have helped me so far. I don't know this happened at windows 11 for me as well and that was the reason i moved back to windows 10.  I literally hate windows.  Microsoft just dumbs down our computers and limits their capabilities but yet money hungry companies and game producers etc still preparing their softwares just on windows. I will donate linux foundation and i also make friends donate them. That's the only thing i can do.

Secondly i also realized since nvidia control center is not working due to that parameter error , i tried to reinstall it and it does not even let me install the new geforce experience or directly the driver itself. I think something really messed up with group policy or user permissions. I don't wanna format and reinstall everything from the beginning. I tried every possible solution online nothing has worked so far. And i got the results for virus scanner now. Some nasty virus or malware there is and let me clear them first.  On macos or on linux you don't even need to install antivirus solutions. (yes there are malwares for them but mostly very sophisticated and target vips etc not us)

I looked at your backup but I don't see anything that stands out. Your problem could be beyond the capabilities of my script. As for Nvidia drivers, maybe you could try this: https://linustechtips.com/topic/1419160-windowsapps-folder-access-denied/#comment-15599650

Alright, good luck!


could not find object: factory

I'm attempting to update the global variable of the target data factory. I have the following row in the config-test.csv:
factory,"mh-test-adf-simpledeployment","$.properties.globalParameters.'environment'.value","test"
When I run the release I get this error:
[error]Could not find object: factory.mh-test-adf-simpledeployment

Can you provide a compressed zip file with this code of ADF? Then I would be able to reproduce the steps.

Is it the ARM template for the target ADF you need?
Sent from ProtonMail Mobile
On Thu, Dec 17, 2020 at 2:33 AM, Kamil Nowinski<EMAIL_ADDRESS>wrote:

Can you provide a compressed zip file with this code of ADF? Then I would be able to reproduce the steps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

No, the source JSON files that you're trying to deploy, located in your repo.

I think I got it figured out. Thanks.


Tags response + command message deletion with trashcan reaction

Closes #745

@ikuyarihS Made fixes for these things.