Stylesheet assets arent loaded from the same source as specified in the --deploy-url

Which @angular/* package(s) are the source of the bug?
Don't known / other
Is this a regression?
No
Description
I'm trying to migrate to esbuild from webpack + custom-webpack on 18.2.
I want to serve index.html from and make http requests to https:/mydomain/ but I want to load scripts/images/styles from //cdn.local/ which all work fine. But for some reason the url-assets in the stylesheets arent loaded from mycdn...
With webpack all style resources was loaded from the same host as the base stylesheet and scripts.. With esbuild this seems broken?
Please provide a link to a minimal reproduction of the bug
https://github.com/stnor/cdn-app
Please provide the exception or error you saw
When using ng build --deploy-url=//cdn.local:4300/
Expected behaviour:
background-image: url(/some/url) should load relative to the deploy url.
Actual:
Using base-href?
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 18.2.9
Node: 20.11.1
Package Manager: yarn 1.22.22
OS: darwin arm64
Angular: 18.2.8
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Package                         Version
@angular-devkit/architect       0.1802.9
@angular-devkit/build-angular   18.2.9
@angular-devkit/core            18.2.9
@angular-devkit/schematics      18.2.9
@angular/cli                    18.2.9
@schematics/angular             18.2.9
rxjs                            7.8.1
typescript                      5.5.4
zone.js                         0.14.10
Anything else?
No response

Instructions are in the README.md in the minimal-reproduction-repo

This is working as intended: only CSS resources with relative paths are managed by the build system. Meaning they are fingerprinted, automatically copied, and prepended with the deploy URL. All absolute paths remain unchanged.
This is also same behaviour of the webpack based builder.

Are you saying a resource in a stylesheet shouldn't be loaded relative to the document location of the stylesheet? In my experience that's not how the web works :) Also the "path" of a resource in the style sheet is a relative url and not an (absolute) path.

./ is considered relative to the stylesheet, whereas / is treated as an absolute path from the document root. Therefore, background-image: url(/some/url) correctly loads from the document root, as it’s specified as an absolute path.
Would you like any further refinements to this version?

Do you have any recommendations to solve my specific use case?

You can use relative paths and let the build system handle the css resources for you. (IE: instead of placing them in the public folder, move next to the .scss file or another diretory that is copied via the "assets" options. These files will than be emitted in the "media" directory.

Component stylesheets are emitted into the JavaScript for a given component and then at runtime Angular inlines the stylesheets as <style> elements. Inline styles resolve URLs based on the document location. This differs from external CSS files where URLs are resolved from the location of the CSS file.
Using a relative path and allowing the build system to manage the files also has caching advantages: https://web.dev/articles/http-cache#versioned-urls

./ is considered relative to the stylesheet, whereas / is treated as an absolute path from the document root. Therefore, background-image: url(/some/url) correctly loads from the document root, as it’s specified as an absolute path.

Thanks for the suggestions. I'll see what I can do.
However, I still do not quite understand why / is treated as an absolute path from the document root.
Shouldn't it be relative to deployUrl regardless let say if the deployUrl is //somehost//foo?

Absolute URLs, those starting with /— as per the URL spec are meant to load from the document root. It seems you're trying to achieve the behavior of relative paths but are currently using absolute paths.

I see now what you're saying @alan-agius4. This is an ancient massive project originally developed in backbonejs then incrementally migrated to angularjs then migrated to angular9 so there are som quirks and legacy handling of stuff.
I'll move the resources out from the assets/public folder and place them with the components. As you point of @clydin, that's great for cache busting as well.
My only problem wuld be locally served webfonts then iirc.


Getting Started Series Redesign

### Tasks
- [ ] https://github.com/hashgraph/hedera-docs/issues/685
- [ ] https://github.com/hashgraph/hedera-docs/issues/682
- [ ] add end-to-end  code for each SDK language to repo

duplicate of #643


Hide/obfuscate sensitive data like passwords copied from clipboard

Description of the new feature/enhancement

When we use a password manager we always use the clipboard to paste passwords in the terminal when doing ssh (password authentication) or running commands as a Privileged User but if we paste the password multiple times the password would be visible
Proposed technical implementation details (optional)

Create a feature to enable users to input a regex pattern so that when text is copied from the clipboard the Windows Terminal replaces that sensitive information with non-word characters (*/#, or even not show anything at all) after paste.
A different way would be an integration with password managers to input data without using the clipboard.

Hmm... ok, so I guess this would work kinda like this...

in a setting, define a regex (or multiple) for suppressed text
on a paste operation, if the regex matches, flag the operation
when the shell tries to output the matching text, suppress it

A few concerns that come to mind:

what if somebody uses this maliciously and tries to suppress all text?
how to handle when the pasted text accidentally matches the regex? Should we always display a little temporary pop-up saying "password suppressed" to make it clear that that happened? Maybe add a "paste anyways" button to that?

Honestly, I see this more as a possible extension that would require access to (1) pasted text and (2) output text. I'm going to mark it up as that.


Explicit warning about approximation of geography

Distinguish between aggregations of different estimates
Provide warning about how PUMAs might include geographies not represented in estimates
"Geographies are not strictly comparable"

(@amirapu, @kerrygathers please advise on solidifying this issue - thank you).

Resolved!


Authentication updates

Updated authentication response to include refresh token expiration and Ford consumer ID.
Updated user-agent to latest value
Updated documentation

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Set ANDROID_SDK_ROOT in addition to ANDROID_HOME on macOS

Description
ANDROID_HOME is deprecated in favor of ANDROID_SDK_ROOT: https://developer.android.com/studio/command-line/variables
Area for Triage:
Android
Question, Bug, or Feature?:
Feature
Virtual environments affected

[x] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
ANDROID_SDK_ROOT is set to the same value as ANDROID_HOME.
Actual behavior
Only ANDROID_HOME is set.

@jhasse does it make sense to add this variable to Windows images too? Looks like currently it exists only on Ubuntu

Yes, I think so.

Hello, pull requests were merged. Changes will be added in the next images rollout.

Hello, changes were added to images. If you have any concerns feel free to reopen the issue.


Themekit Deploy --files allow expressions

Within my build process I have a "Sync" Gulp Task which runs the ThemeKit Deploy Command. However, I don't want to sync everything - the clients we work with often switch out assets, e.g. their logo (as Shopify doesn't support SVGs in Sections).
To get around this, we use the --files option, however it doesn't accept expressions on literal paths. As an example:
'./assets/*.js' is seen as the literal path, and it doesn't seem to try and evaluate it.

Themekit already does this. You can simply use theme deploy /.assets/\*.js you can always find more info on commands by running theme deploy --help


tpl/transform: Add template func for TOML/JSON/YAML docs examples conversion

Usage:
{{ "title = \"Hello World\"" | transform.Serlify "json" | safeHTML }}

Fixes #4389
/cc @regisphilibert

Serlify?  Where did you come up with that?  😆

Serlify? Where did you come up with that?

Here.

Seriously, I welcome better suggestions (however I suspect this will be a classic. So TOML, JSON etc. are data serialization formats ... serlify). But this func is kind of a special purpose "Hugo docs func",  but I guess others will pick up on it ...

@regisphilibert I will merge this into master some time during this weekend. It should work, but I want to test it a little. There may be some date issues that could be improved. Not sure.

Sure I'll try it once it's on master and will go back to the hugoDocs repo to add the toggling config shortcode issue where we'll talk more about front end.
Thanks a ton! You were super fast with this.

Thanks a ton! You were super fast with this.

Yes, I have been annoyed by the "example situation" for a long time -- and if someone wants to do something about it, I will try to keep that momentum going ...

How about serialize, or remarshal (there's even a GitHub repo named that, that does exactly this - TOML/YAML/JSON conversion)?

How about serialize, or remarshal

"remarshal" I kind of like, but ...

I like that it ends with ...fy. Reminds of jsonify.

My take is that in jsonify, removing "ify", the "json" part makes sense, and similarly "markdown" + "ify" = markdownify. The same logic doesn't work here.. "serl" doesn't mean anything. If sticking to "-ify" is the aim, then may be.. serialify.
But then the question is.. is this process technically serialization/marshalling?
JSON, or TOML, or YAML, each of those is already marshalled, or converted from raw data into some sort of format, a spec, an object.
If we are converting among these formats, something like remarshall, reformat, transform (though, the library is also called the same) sounds more correct.

Or if the package name will always be present:
{`{{ "title = \"Hello World\"" | transform.to "json" | safeHTML }}`, "{\n   \"title\": \"Hello World\"\n}\n"},

@vassudanagunta thanks, but it needs to be one method so it can be (easy to) dynamically invoked.

And the winner is @kaushalmodi
{{ "title = \"Hello World\"" | transform.Remarshal "json" | safeHTML }}


Adds replyEmbed and sendEmbed, messageCommands, made it install (postinstall tsc), and fixed various bugs.

Currently still testing some things (just got an unrelated issue that I'm looking into pertaining to Commands.set/Commands.setGuildCommand) but to my understanding this should be mostly done.

Hey for the main field of package.json I left it look to for index.js because of how releasing it works. look at/run this to get a idea what i mean

i'll implement a fix for the package.json that allows both git and npm installations, I've also decided that the json.forEach bug is probably not being fixed in this pr as its just a rate-limiting issue as far as I can tell

uh https://github.com/jdadonut/periljs/blob/main/package.dist.json#L5

it seems i moved the typescript package declaration and forgot everything else, I'll push the fix in like 2 seconds.

that should do it


v4.0.1 fails with TypeError: Cannot read properties of undefined (reading 'toString')

Describe The Bug:
v4.0.1 gives a TypeError, plugin fails to run. Reverting to v4.0.0 resolves.
To Reproduce:
Update a working v4.0.0 to v4.0.1
Logs:
1/5/2024, 11:46:46 AM Weather Bridge starting
1/5/2024, 11:46:50 AM Weather Bridge Loaded plugin 'homebridge-weatherflow-tempest'
1/5/2024, 11:46:50 AM Weather Bridge Loading 1 platforms...
1/5/2024, 11:46:50 AM Weather Bridge WeatherFlow Tempest Platform Finished initializing platform: WeatherFlow Tempest Platform
1/5/2024, 11:46:50 AM Weather Bridge WARNING unhandled rejection: TypeError: Cannot read properties of undefined (reading 'toString')

Plugin Config:
{
    "name": "WeatherFlow Tempest Platform",
    "local_api": true,
    "units": "Standard",
    "sensors": [
        {
            "name": "Temperature",
            "sensor_type": "Temperature Sensor",
            "temperature_properties": {
                "value_key": "air_temperature"
            }
        },
        {
            "name": "Relative Humidity",
            "sensor_type": "Humidity Sensor",
            "humidity_properties": {
                "value_key": "relative_humidity"
            }
        },
        {
            "name": "Light Level",
            "sensor_type": "Light Sensor",
            "light_properties": {
                "value_key": "brightness"
            }
        },
        {
            "name": "Wind Speed",
            "sensor_type": "Fan",
            "fan_properties": {
                "value_key": "wind_avg"
            }
        }
    ],
    "platform": "WeatherFlowTempest"
}

Environment:

Plugin Version: 4.0.1
Homebridge Version: 1.6.0
Node.js Version: 16.20.2
NPM Version: 8.19.4
Operating System: Linux hoobs 5.10.103-v7l+ #1529 SMP Tue Mar 8 12:24:00 GMT 2022 armv7l GNU/Linux

Note in your environment that your OS is HOOBS while all of my testing has been done on Homebridge. Also note that you are behind in versions from a Homebridge perspective. Latest are:

Installed 4.0.1 on "vanilla" homebridge and got a little better info from the log entry.
[1/5/2024, 12:09:08 PM] TypeError: Cannot read properties of undefined (reading 'toString')
    at new WeatherFlowTempestPlatform (/usr/local/lib/node_modules/homebridge-weatherflow-tempest/src/platform.ts:80:69)
    at /usr/local/lib/node_modules/homebridge/src/server.ts:474:40
    at Array.forEach (<anonymous>)
    at Server.loadPlatforms (/usr/local/lib/node_modules/homebridge/src/server.ts:401:27)
    at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:176:29)

I see the issue. My config file has an entry for "station_id" and there is no issue. Once I delete I see the same error as you have.
I sometimes use local API and sometimes remote API and why I have this entry. Should have tested with no entry in the case of someone installing and going directly with the local API.

Thanks @jlg89 for pointing out the issues with a clean install. I have an update on my system but making sure that all of the scenarios with new and upgrade are covered before I post.

I guess a workaround would be to put the station_id in the config.

Confirmed. Adding station_id to the config eliminates the error, so that's the issue.

I have it figured out and tested. Just need to post for review.

Thanks @DMBlakeley looking forward to the PR.

@chasenicholl, I have submitted the PR for 4.0.2. This version:

When using HTTP API, checks that token and station_id are present and have valid characteristics.
When Local API is used, token and station_id are not required and are not validated.
User is able to switch between HTTP API to Local API and back to HTTP API without the need to re-enter token and station_id as these are retained in the config.sys file.

I have tried numerous combination of valid and invalid token and station_id in my testing. Believe this is now addressed.

Thanks for the feedback @jlg89 and thanks for the patch @DMBlakeley
v4.0.2 has just been released to the public.


Fix input warning and dropdown

Codecov Report

Merging #438 (187b278) into develop (a80b891) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 187b278 differs from pull request most recent head bf01c45. Consider uploading reports for the commit bf01c45 to get more accurate results

@@           Coverage Diff            @@
##           develop     #438   +/-   ##
========================================
  Coverage    76.09%   76.09%
========================================
  Files           81       81
  Lines         3037     3037
  Branches       469      469
========================================
  Hits          2311     2311
  Misses         726      726

Flag
Coverage Δ

batch-submitter
59.51% <ø> (ø)

contracts
86.05% <ø> (ø)

core-utils
68.16% <ø> (ø)

data-transport-layer
37.68% <ø> (ø)

message-relayer
72.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80b891...bf01c45. Read the comment docs.


Add date select to "Explore" tab

Closes #129. This adds a date selector to tab Explore, taking advantage of some initial refactoring where we export the employees for all dates instead of jus the latest.
This modifies the import to generate modified CSVs for all dates on import.  This now saves each dates employees within a folder of the form YYYY-MM-DD.  As a touch-up, instead of parsing and modifying the date, this converts it once to a relatively parseable format (YYYY-MM-DD) an uses that for all subsequent usages.  Processing all the dates every time we call the script takes a second or two, so I removed the option for a particular date, and removed commander, which we used to declaratively provide that option.
Calls to setState that result from fetches have been grouped using Promise.all to wait for all to complete.
This also adds labels and gives each select on explore that all three input selectors are easier to view and understand. Since the clearable attribute was required for the new date select, I also added it to the Attribute select.  I noticed the searchable attribute to prevent users from auto-
completing, and also added it to the two-element Atribute dropdown.

@mshenfield could you update the readme to reflect the lack of need for file input. After that 👍 .. looks great!


Support mutually-recursive groups of size greater than 2

We currently have mu2 to support pairs of mutually recursive types, but no real way to handle the general case. A simple solution might be to just add combinators for a few more group sizes:
val mu3 : ('a t -> 'b t -> 'c t -> ('a t * 'b t * 'c t as 'res)) -> 'res
val mu4 : ('a t -> 'b t -> 'c t -> 'd t -> ('a t * 'b t * 'c t * 'd t as 'res)) -> 'res
(* etc. *)

... or perhaps there is a generic solution via Oleg.

Actually from my experiments mu2 supports more than pairs of mutually recursive types, it supports all possible recursive types as long as you can build them all from 2 of them.
Example:
type a2 = { fa1 : b2 option; fa2 : c2 option }
and b2 = { fb1 : c2 option; fb2 : d2 option }
and c2 = { fc1 : a2 option; fc2 : d2 option }
and d2 = { fd1 : a2 option; fd2 : b2 option; fd3 : c2 option }

open Irmin.Type

let mka2_t b2_t c2_t =
  record "a2" (fun fa1 fa2 -> { fa1; fa2 })
  |+ field "fa1" (option b2_t) (fun t -> t.fa1)
  |+ field "fa2" (option c2_t) (fun t -> t.fa2)
  |> sealr

let mkb2_t c2_t d2_t =
  record "b2" (fun fb1 fb2 -> { fb1; fb2 })
  |+ field "fb1" (option c2_t) (fun t -> t.fb1)
  |+ field "fb2" (option d2_t) (fun t -> t.fb2)
  |> sealr

let mkc2_t a2_t d2_t =
  record "c2" (fun fc1 fc2 -> { fc1; fc2 })
  |+ field "fc1" (option a2_t) (fun t -> t.fc1)
  |+ field "fc2" (option d2_t) (fun t -> t.fc2)
  |> sealr

let mkd2_t a2_t b2_t c2_t =
  record "d2" (fun fd1 fd2 fd3 -> { fd1; fd2; fd3 })
  |+ field "fd1" (option a2_t) (fun t -> t.fd1)
  |+ field "fd2" (option b2_t) (fun t -> t.fd2)
  |+ field "fd3" (option c2_t) (fun t -> t.fd3)
  |> sealr

let b2_t, c2_t =
  mu2 (fun b2 c2 ->
      let a2 = mka2_t b2 c2 in
      let d2 = mkd2_t a2 b2 c2 in
      let c2 = mkc2_t a2 d2 in
      let b2 = mkb2_t c2 d2 in
      (b2, c2))

let a2_t = mka2_t b2_t c2_t

let d2_t = mkd2_t a2_t b2_t c2_t

let () =
  let a = { fa1 = None; fa2 = None } in
  let b = { fb1 = None; fb2 = None } in
  let c = { fc1 = None; fc2 = None } in
  let d = { fd1 = Some a; fd2 = Some b; fd3 = Some c } in
  Format.eprintf<EMAIL_ADDRESS>Repr.(pp d2_t) d

Results in
{"fd1":{},"fd2":{},"fd3":{}}

Maybe we could improve the doc by showing that this is a possibility actually

Indeed, the actual limitations of mu2 are somewhat hard to capture (which is why there's been a TODO in its documentation for a long time). FWIW, I think the actual constraint on groups is something like "the directed graph of type co-dependencies can't contain any complete subgraphs of size greater than 2.".

I agree with the formalised constraint :-)


[1.11] [Localisation Bug] Missing Localisation for the entire mod

Hi McJty,
Quick bug for you regarding 1.11 for TOP, here's the details. . .
Important Information

Minecraft 1.11
Forge <IP_ADDRESS>1
The One Probe 1.3.3

Issue Description
The entire mod is missing localisation. What did you do!
Issue Media

Fixed in 1.3.4


cargo new: option to suppress automatic addition to workspace

Problem
This is similar to but not quite the same as https://github.com/rust-lang/cargo/issues/13985
I'm building a tool which calls cargo new as a subprocess. That tool has a root Cargo.toml which specifies a few workspaces.
When testing the tool I do something like cargo run -- new ../some/path or cargo run -- new path. When I do so, cargo new runs as a subprocess and it indicates that it's adding the new package to the workspace list (even if the folder is outside of the project, i.e. "../"). Because I'm only testing, I want to suppress this behaviour.
Without a means to do this, I have to delete the folder, and edit the root Cargo.toml every time I test.
Proposed Solution
99% of the time it seems correct (and convenient), but I'd like a flag or environment variable to suppress this unexpected automatic behaviour.
Notes
No response

If we're adding relative to current_dir instead of --path, then I'd consider that a bug.
Otherwise, we've previously decided that the command is intended for user interactions and not programmatic use and are unlikely to add features for it.

I'm not sure what the --path argument is, I don't see that in documentation.
Just to clarify, when you say "adding relative to current_dir", do you mean that updating Cargo.toml workspaces when adding outside of the current_dir/project root is a bug?
For example:
$ cargo new project-root
$ cd project-root
$ cargo new some-workspace

Update Cargo.toml:
[workspace]
members = [
    "some-workspace"
]
resolver = "2"

Then do:
$ cargo new ../outside-root
    Creating binary (application) `outside-root` package
      Adding `outside-root` as member of workspace at `/home/USER/project-root`
warning: compiling this new package may not work due to invalid workspace configuration

workspace member `/home/USER/outside-root/Cargo.toml` is not hierarchically below the workspace root `/home/USER/project-root/Cargo.toml`

And now Cargo.toml looks like:
[workspace]
members = [ "../outside-root",
    "some-workspace"
]
resolver = "2"

I understand the decision to prioritize interactive use, but according to what you've said maybe there's a bug here.
Version info
$ cargo -V
cargo 1.81.0 (2dbb1af80 2024-08-20)

Sorry, I meant the positional <path>, not --path (forgot it was positional).
Looks like the code is trying to find the workspace for the manifest but I think we aren't handling ../ correctly in that logic
https://github.com/rust-lang/cargo/blob/b687045b12c31af80219b30e3fc8d51e9f174d8e/src/cargo/ops/cargo_new.rs#L805-L806
We've accepted user input, made it absolute, but never called paths::normalize_path on it.

Posted #14505 with a fix for that situation.

I think https://github.com/rust-lang/cargo/pull/14505 resolves the issue. Thanks @epage.


[Enhancement] doris服务自动拉起脚本支持

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
现在doris服务的自动拉起依赖于Systemd或者Supervisor。是不是可以开发类似于mysqld_safe一样的脚本，来保证服务自动拉起，这样就不依赖于其他组件了__
Solution
开发类似于mysqld_safe一样的脚本
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can use doris manager, which includes auto-pull services and cluster management.


Update copyright notice in LICENSE and README.

Update the LICENSE and README file to reflect that the project IP transfer from Samsung to the JS Foundation has been completed.
JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller<EMAIL_ADDRESS>

LGTM

LGTM


Jupyter default visualization

This changes some defaults so that the visualization processes don't default to writing files to disk.
visualize returns the raw html and jupyter.display will plot the raw html.
Let's talk about these defaults. It's always written a file by default. That has made sense when using scripts, but it seems strange when in a notebook. Any thoughts?

Hello @sauln, Thank you for submitting the Pull Request !

In the file kmapper/jupyter.py, following are the PEP8 issues :

Line 12:1: E302 expected 2 blank lines, found 1
Line 30:5: E303 too many blank lines (2)
Line 35:17: E126 continuation line over-indented for hanging indent

In the file kmapper/kmapper.py, following are the PEP8 issues :

Line 43:101: E501 line too long (109 > 100 characters)
Line 44:101: E501 line too long (130 > 100 characters)
Line 53:101: E501 line too long (404 > 100 characters)
Line 56:101: E501 line too long (666 > 100 characters)
Line 67:101: E501 line too long (114 > 100 characters)
Line 110:17: E722 do not use bare except'
Line 114:9: E722 do not use bare except'
Line 177:101: E501 line too long (119 > 100 characters)
Line 191:101: E501 line too long (136 > 100 characters)
Line 194:101: E501 line too long (153 > 100 characters)
Line 197:101: E501 line too long (112 > 100 characters)
Line 210:101: E501 line too long (151 > 100 characters)
Line 224:101: E501 line too long (111 > 100 characters)
Line 237:101: E501 line too long (153 > 100 characters)
Line 282:101: E501 line too long (119 > 100 characters)
Line 350:101: E501 line too long (129 > 100 characters)
Line 367:101: E501 line too long (111 > 100 characters)
Line 373:9: E303 too many blank lines (2)

In the file setup.py, following are the PEP8 issues :

Line 3:1: E265 block comment should start with '# '
Line 10:101: E501 line too long (175 > 100 characters)
Line 12:101: E501 line too long (204 > 100 characters)
Line 23:9: E121 continuation line under-indented for hanging indent
Line 30:9: E121 continuation line under-indented for hanging indent
Line 45:6: E124 closing bracket does not match visual indentation

Do see the Hitchhiker's guide to code style

This introduces a very strange bug where closing any of the panes will copy the current notebook into the cell.  :|

Codecov Report

Merging #67 into master will decrease coverage by 0.3%.
The diff coverage is 6.52%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   75.36%   75.06%   -0.31%
==========================================
  Files           6        6
  Lines         410      413       +3
  Branches       96       96
==========================================
+ Hits          309      310       +1
- Misses         85       87       +2
  Partials       16       16

Impacted Files
Coverage Δ

kmapper/jupyter.py
0% <0%> (ø)
:arrow_up:

kmapper/kmapper.py
65.53% <6.81%> (+0.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6671eb...ab6b6be. Read the comment docs.

I'm closing this since I royally messed up my commit history and wildly entangled different pull requests. Oops.


Http method invocation may fail silently

In what area(s)?

/area runtime
/area operator

What version of Dapr?

0.4
In some situations if http method invocation fails, err will be nil but the response's status code will != 200.  This case is not inspected.  There should be an error returned.
Related to #1222 - that issue observed a silent failure, but the fix for that one to inspect against a list of verbs.
Steps to Reproduce the Problem
Same as #1222

This should not be inspected. Service invocation should not make decisions on what is a success and what isn't.
Consider the user has App A and App B, and App A knows how to deal with App B's status codes. If Dapr injects behavior as the middleman, it will alter and break the calling appliaction.

this is what the spec says.  Does it need an update? https://github.com/dapr/docs/blob/master/reference/api/service_invocation_api.md

without this some errors will be silently dropped as the title says.  Is there another way to help the user here?

They won't be silently dropped, the response code from the app invoked is set as the status code that's returned.

@LMWF you caught unpredictable behavior in our docs, fixed with https://github.com/dapr/docs/pull/415.
Thanks!
Closing this now.


Getting H3_INTERNAL_ERROR on calling via h3 preference

I am calling NGINX with http3 enabled and cronet is working fine as well as a request client. We are doing a PoC and are trying to use rhttp instead because of its speed. Could you please check if my implementation is wrong?
`
rAuthInvest = await RhttpCompatibleClient.create(
interceptors: [TimeInterceptor()],
settings: ClientSettings(
httpVersionPref: HttpVersionPref.http3,
timeoutSettings: TimeoutSettings(
timeout: Duration(seconds: 30),
connectTimeout: Duration(seconds: 10),
keepAliveTimeout: Duration(seconds: 60),
),
throwOnStatusCode: true,
)
);
Future orderbookHeaders(
{Function(dynamic data)? onSuccess,
Function(dynamic error)? onError,
Map<String, String> headers = const {},
Map requestData = const {}}) async {
try {
  Map<String, String> h = {
  "Content-type": "application/json",
  "Access-Control-Allow-Origin": "*",
  "User-Agent": "Dart/3.4",
  // "Accept-Encoding": ['gzip', 'br'],
  "Authorization": "Bearer ${prefUtils.getAuthtoken()}",
  "session_id": prefUtils.getSsoSessionId(),
  "x-client-id": prefUtils.getclientid(),
};
  var response;
  try {
    response = await HTTP3.rAuthInvest.post(
        Uri.parse("$ordersUrl/txn/orderbook/v1/header"),
        headers: h,
        body: jsonEncode(requestData));
  } catch(e) {
    print(e.toString());
  }
  if (response.statusCode < 400 && onSuccess != null) {
    onSuccess(response.body);
  } else {
    onError!(
      response.bodyMap.containsKey("message")
          ? response.bodyMap["message"]
          : 'Something Went Wrong!',
    );
  }
} catch (error) {
  onError!(error);
}

}
`

any support would be really helpful

I just dug a bit deeper and this line is throwing the error
       final rustResponse = await responseCompleter.future;

H3_INTERNAL_ERROR seems like an error on the Rust side.

is there any way i can look into the RCA on what was wrong from my end? and maybe try to fix it

An option would be to run write the exact request in Rust to check if Rhttp doesn't do anything wrong. If it still occurs, then maybe there is a solution in reqwest or h3 Github repo.

can resolve by this:

https://github.com/hyperium/h3/issues/206?spm=5176.2020520<IP_ADDRESS>ffb43ecFgRJC2

work for me ,you can do it like this:

thanks for the help @denonzhu, i'll try it next week once I resume my work
meanwhile @Tienisto can you please check if we can upgrade the version of reqwest crate? because I can see in their master branch they have removed the grease dependency

Hello @scoobhidu , your screenshot is unfortunately not loading.
Rhttp already uses the latest version (0.12.9) https://github.com/Tienisto/rhttp/blob/main/rhttp%2Frust%2FCargo.toml#L17
I am thinking of adding the workaround by @denonzhu but I am not sure if it has bad side effects or if we should wait if the issue is fixed by h3.

oh sorry @Tienisto, the screenshot was of https://github.com/seanmonstar/reqwest/blob/master/src/async_impl/h3_client/connect.rs
the file does not contain the grease dependency in remote_connect method as highlighted in denonzhu's screenshot

@denonzhu's suggested fix seems to be working as from H3_INTERNAL_ISSUE I have now started getting another issue where I keep getting this

V/reqwest::async_impl::..( 4760): did not find connection ("http", invest.venturasecurities.uat) in pool so connecting...
I/flutter ( 4760): http://invest.venturasecurities.uat/market/v1/mktstatus Time taken: 2
I/flutter ( 4760): [RhttpUnknownException] reqwest::Error { kind: Request, source: "HTTP/3 connecting already in progress for (\"http\", invest.venturasecurities.uat)" }

This keeps happening on a loop with recurrent requests and same error
Can you please help in resolving this?


Door and motion sensors showing on/off states

Is it possible to change the defaults for door sensors to be open/closed and for motion to be "Detected/Clear" or something along these lines?

Yes, Just Paste this into the state template editor and you're all good: Its labelled state and there's a button that looks like this {}
Obviously edit for open/close.
{% if is_state(entity_id, "on") %}
Detected
{% else %}
Clear
{% endif %}


When will the archive of githubarchive:year.2015 upload?

Currently I could only find out archive from 2011 to 2014. It will be great if the archive of 2015 uploaded.

See #129 :)


Balls sample data are not working with napari installed from pip

🐛 Bug Report
It looks like napari.benchmarks are not added to napari sdist and wheel file.
💡 Steps to Reproduce

Create fresh environment
install napari form pip,
Open napari
try to open Balls or Balls (3D) sample

File ~/.pyenv/versions/3.11.5/envs/napari-mouse-control/lib/python3.11/site-packages/npe2/_command_registry.py:34, in CommandHandler.resolve(self=CommandHandler(id='napari.data.balls_3d', functi...apari_builtins._ndims_balls:labeled_particles3d'))
     32     self.function = utils.import_python_name(self.python_name)
     33 except Exception as e:
---> 34     raise RuntimeError(
        self.python_name = 'napari_builtins._ndims_balls:labeled_particles3d'
        self = CommandHandler(id='napari.data.balls_3d', function=None, python_name='napari_builtins._ndims_balls:labeled_particles3d')
     35         f"Failed to import command at {self.python_name!r}: {e}"
     36     ) from e
     38 return self.function

RuntimeError: Failed to import command at 'napari_builtins._ndims_balls:labeled_particles3d': No module named 'napari.benchmarks'

Or download artifact form pypi and see that files are missing.
💡 Expected Behavior
work
🌎 Environment
0.5.2
💡 Additional Context
No response

I just checked 0.5.1 and 0.5.0 and it's the same:
RuntimeError: Failed to import command at 'napari_builtins._ndims_balls:labeled_particles3d': No module named 'napari.benchmarks'


Add default country option and weekStartDay()

Addresses https://github.com/Shopify/web/issues/7245

Add an option to pass country to i18n which will allow to return weekStartDay.
weekStartDay returns a Weekday enum value
It defaults to Sunday

Data is inlined and comes from https://github.com/Shopify/country_db/pull/217 (Source: http://chartsbin.com/view/41671 + Shopifolks)
This addresses an immediate problem we have. We will have to investigate to find a proper solution to keep data in sync with https://github.com/Shopify/country_db/

All in favor of 0.3.0 since we introduce a new function in the API?


Develop REST Api to access device data

Criterias:

Scalable: 0 ..N amout of devices
Reachable over WAN (Internet), nonlocal
CRUD compatible (Create, Read, Update, Delete)
Hosted with DNS

Development started

complete, see http://woobsapi.herokuapp.com/


Only supports PPM file format

PNG? JPEG? Supporting other image formats would be nice and help do things like displaying sample photos in the README.


Vuetify SASS variables don't work and broke styles

I try to use SASS variables. But it don't work and broke styles. I see black borders for inputs. But I didn't add their.
frontend/assets/css/custom/settings.scss:
@use 'vuetify/settings' with (
  $button-height: 50px,
  $messages-font-size: 0.85rem,
  $input-details-font-size: 0.85rem,
  $messages-min-height: 0.9rem,
  $input-details-font-weight: 300,
  $text-field-details-padding-inline: 0px
);

In frontend/nuxt.config.ts:
...
moduleOptions: {
            styles: {
                configFile: 'assets/css/custom/settings.scss',
            },
        },
...

If I remove moduleOptions's content, black borders go away.

vuetify-nuxt-module  version: "0.12.0"

Minimal reproduction example - https://github.com/itelmenko/nuxt-vuetify-with-module-example

Did you tried with @forward instead of @use ?

Yes. https://github.com/itelmenko/nuxt-vuetify-with-module-example/blob/main/assets/css/settings.scss

Can you try following ?
@forward 'vuetify/settings' with (
  $button-height: 50px,
  $messages-font-size: 0.85rem,
  $input-details-font-size: 0.85rem,
  $messages-min-height: 0.9rem,
  $input-details-font-weight: 300,
  $text-field-details-padding-inline: 0px
);
@import 'vuetify';

Hm.... Yes. It works

It seems that defining a config file is fully overriding the vuetify config

@userquin ?

Using the reproduction with Chrome 123 just works (after an inital delay: using @use  instead @forward)

@userquin My example works fine for you without changes?
With
@forward "vuetify/settings" with (
  $button-height: 50px,
  $messages-font-size: 0.85rem,
  $input-details-font-size: 0.85rem,
  $messages-min-height: 0.9rem,
  $input-details-font-weight: 300,
  $text-field-details-padding-inline: 0px
);

Could you attach a screen?

With @use:

With @forward:

Please add @import 'vuetify'; also:
@forward 'vuetify/settings' with (
  $button-height: 50px,
  $messages-font-size: 0.85rem,
  $input-details-font-size: 0.85rem,
  $messages-min-height: 0.9rem,
  $input-details-font-weight: 300,
  $text-field-details-padding-inline: 0px
);
@import 'vuetify';

I'm not a SASS expert, you should try also building the reproduction and run the preview (node .output/server/index.mjs or npx serve .output/public if using nuxt build  or nuxt generate respectively): IIRC some styles are in reverse order and maybe you need to patch the output build.

Yes. I see Select was fixed on last screen. So what is correct way?
@forward 'vuetify/settings' with (
...
);
@import 'vuetify';

?

I'm also encountering difficulties with Sass and the  vuetify-nuxt-module 🙃
Never do this in your vuetfiy Sass file:
@import 'vuetify'

Becuase it imports all of Vuetify's styles into every component, leading to:

Massive CSS Duplication:
Unnecessary styles bloat your CSS bundle, impacting performance.
Style Pollution: Global styles might conflict with your component-specific styles.
Increased Bundle Size: Larger CSS files take longer to load, slowing down your application.

Surely, there must be a better way to handle this.
If anyone has discovered a solution or workaround, I'd greatly appreciate your insights and suggestions!

I created an issue about this with a reproduction repo #212

Yes. I see Select was fixed on last screen. So what is correct way?
@forward 'vuetify/settings' with (
...
);
@import 'vuetify';

?

v0.13.2 fixes this issue, so you just need to use as follows, no additional css imports are required.
//nuxt.config.ts
  vuetify: {
    moduleOptions: {
      styles: {
        configFile: 'assets/scss/settings.scss',
      },
    },
  },

// assets/scss/settings.scss
@forward 'vuetify/settings' with (
 // Buttons
 $button-disabled-opacity: 0.5,
);

Thank you so much! It works excellent!


Biome changer remote doesn't work properly

Version of Advanced Rocketry
1.4.0-82-universal
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
0.2.8-31
Version of Minecraft
1.12.2
ATM3 v5.9.6b modpack
Crash report or log (if applicable)
https://pastebin.com/4s11Yx4L
Description of the problem
Biome changer remote GUI opens only once, further tries throws error in a console.
It happens after "Darklands Forest" biome scan from "Abyssalcraft" mod.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Port to EF Core 6.0

Thanks for the review @smitpatel, will give it a couple more days in case @AndriySvyryd has something to say.

Merged via 716ccbf9f43723acec9bdd5eae4b18796c90f107


build error with cmake on version r19.09

Hi,
I am trying to compile r19.09 from source  with CMake version 3.13.4
I followed the instructions from here and I get the following error.
[100%] Built target evhtp
[ 80%] Performing install step for 'libevhtp'
-- Detecting CXX compile features - done
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.7")
[100%] Built target evhtp
CMake Error at cmake/protobuf.cmake:55 (find_package):
  Could not find a package configuration file provided by "Protobuf" with any
  of the following names:

    ProtobufConfig.cmake
    protobuf-config.cmake

  Add the installation prefix of "Protobuf" to CMAKE_PREFIX_PATH or set
  "Protobuf_DIR" to a directory containing one of the above files.  If
  "Protobuf" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:140 (include)

the same error with the version v1.6.0, but it' ok with the version v1.4.0dev
Please help

Can you provide information about what system you are building on and the cmake and make command you used.

OS is Redhat Enterprise Linux Server release 7.2 (Paladin)
cd the install path of tensorrt-inference-server
make cmake-build
cmake ../build
make trtis
i  tried to compile the master(1.8.0dev),it's ok , but it didn't work with r19.09 and v1.6.0 and the error was  as before

We do not test RHEL builds so it is not surprising it doesn't work. What the build is looking for is the CMake configuration file for protobuf. It could be a couple of things causing that failure. Can you share the full contents of the builddir/protobuf/lib directory and subdirs.
Unfortunately I don't think I can pull the RHEL container for free. Have you tried on the corresponding CentOS? If you see the same failure there we should be able to reproduce.

the directory is as below
trtis-r19.09/cmake-build/protobuf/lib64/
├── cmake
│   └── protobuf
│       ├── protobuf-config.cmake
│       ├── protobuf-config-version.cmake
│       ├── protobuf-module.cmake
│       ├── protobuf-options.cmake
│       ├── protobuf-targets.cmake
│       └── protobuf-targets-noconfig.cmake
├── libprotobuf.a
├── libprotobuf-lite.a
├── libprotoc.a
└── pkgconfig
    ├── protobuf-lite.pc
    └── protobuf.pc

the machine and the os is provided by anothers and no choice for me

The likely problem is here: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/build/CMakeLists.txt#L154
And similar lines like it in the CMakeLists.txt file. The definition of _FINDPACKAGE_PROTOBUF_CONFIG_DIR is here: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/build/CMakeLists.txt#L122
Notice that it expects the config in protobug/lib/cmake/protobuf, but you have lib64. So I think you can just edit that line. It would be great if you could determine the cmake define for detecting RHEL system and issue a PR to fix the _FINDPACKAGE_PROTOBUF_CONFIG_DIR assignment.
You may have similar cases where you need to change lib -> lib64.

Greate! It works!
i had been wondering why it worked with the version 1.8.0dev and did not with r19.09 or v1.6.0
it's different with the CMakeList of both as below
at v1.6.0
$find build -name "*.txt"|xargs grep "_FINDPACKAGE_PROTOBUF_CONFIG_DIR"
build/CMakeLists.txt:  set(_FINDPACKAGE_PROTOBUF_CONFIG_DIR "${CMAKE_CURRENT_BINARY_DIR}/protobuf/cmake")
build/CMakeLists.txt:  set(_FINDPACKAGE_PROTOBUF_CONFIG_DIR "${CMAKE_CURRENT_BINARY_DIR}/protobuf/lib64/cmake/protobuf")
build/CMakeLists.txt:#set(_FINDPACKAGE_PROTOBUF_CONFIG_DIR "${CMAKE_CURRENT_BINARY_DIR}/protobuf/${CMAKE_INSTALL_LIBDIR}/cmake/protobuf")
build/CMakeLists.txt:    -DProtobuf_DIR:PATH=${_FINDPACKAGE_PROTOBUF_CONFIG_DIR}
build/CMakeLists.txt:   ${_FINDPACKAGE_PROTOBUF_CONFIG_DIR})
build/CMakeLists.txt:    -DProtobuf_DIR:PATH=${_FINDPACKAGE_PROTOBUF_CONFIG_DIR}
build/CMakeLists.txt:    -DProtobuf_DIR:PATH=${_FINDPACKAGE_PROTOBUF_CONFIG_DIR}
build/CMakeLists.txt:    -DProtobuf_DIR:PATH=${_FINDPACKAGE_PROTOBUF_CONFIG_DIR}

but at 1.8.0dev, it's empty
$find ../trtis-1.8dev/build -name "*.txt"|xargs grep "_FINDPACKAGE_PROTOBUF_CONFIG_DIR"

but why not both have the similar CMakeList

The dev version was an under-development version so perhaps you just got it at a point when we were making some changes.  Good that you have it working now.


Finish type annotations and PEP-561 compliance

Closes #268

Coverage decreased (-0.5%) to 97.66% when pulling a520d1c36338dae43673deb6b662237766115061 on JWCook:type-hints into df4d83c606dbd3c993ae0d8705dd0d983c5b9f1d on reclosedev:master.


Try launching in external app first

Follows the advice here to try to fix #42.
(The changes are all in maps_launcher.dart, but I also updated the deps, hence the large changeset)

Thank you

@pikaju , can this be merged?

This should also fix https://github.com/pikaju/flutter-maps-launcher/issues/38 and make https://github.com/pikaju/flutter-maps-launcher/pull/39 obsolete.

Hey, I had merge conflicts with the other PRs, but I integrated your idea with the _launchMode function now. Thank you!


Add EMNISTDataModule

What does this PR do?
This is a draft for issue #672. Closes #676.

A summary of changes and modifications :star: :fire: [CLICK TO EXPAND]

File Added:

[x] pl_bolts/datasets/emnist_dataset.py :green_circle:
[x] Contents:

[x] EMNIST_METADATA
[x] EMNIST dataset
[x] BinaryEMNIST dataset Need New PR or add to #672 :warning:

File Added:

[x] pl_bolts/datamodules/emnist_dataset.py :green_circle:
[x] Contents:

[x] EMNISTDataModule
[x] BinaryEMNISTDataModule Need New PR or add to #672 :warning:

Files Modified

Package: pl_bolts

[x] pl_bolts/datasets/__init__.py :green_circle:
[x] pl_bolts/datamodules/__init__.py :green_circle:

Tests:

For datamodules:

[x] tests/datamodules/test_imports.py :green_circle:
[x] tests/datamodules/test_datamodules.py WIP :orange_circle:

Adding BinaryEMNIST and BinaryEMNISTDataModule was logical, looking at how MNIST and BinaryMNIST (dataset and datamodules) were implemented.

source: https://arxiv.org/pdf/1702.05373.pdf [Table-I]

source: https://arxiv.org/pdf/1702.05373.pdf [Table-II]

Fixes #672
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements) #672
[x] Did you read the contributor guideline, Pull Request section? Y :green_circle:
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Y :green_circle:
[x] Did you make sure to update the documentation with your changes? Y :green_circle:
[x] Did you write any new necessary tests? [not needed for typos/docs] Y :green_circle:
[x] Did you verify new and existing tests pass locally with your changes? Y :green_circle:
[x] If you made a notable change (that affects users), did you update the CHANGELOG? Y :green_circle:

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode) DRAFT :orange_circle:

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Hello @sugatoray! Thanks for opening this PR.

 So, should there be a check for these splits, where if the user specifies to use no validation data, then the datamodule must not produce any validation dataset and datamodule?

one way this could be done is by introducing another keyword argument: strict_val_split: bool = False in the __init__ method of EMNISTDataModule and then check if the metadata for that split has validation = False.

@sugatoray Would you mind updating the changelog as well?

@sugatoray Would you mind updating the changelog as well?

@akihironitta Sure. However, am not sure which changelog to update? It will be helpful if you could point me in the right direction. Thank you.

@sugatoray Would you mind updating the changelog as well?

@akihironitta Sure. However, am not sure which changelog to update? It will be helpful if you could point me in the right direction. Thank you.

@sugatoray Thank you for having a look at my comments! The changelog is here :] https://github.com/PyTorchLightning/lightning-bolts/blob/master/CHANGELOG.md

@akihironitta Here is a draft of the changelog. Does it look okay to you?
[unReleased] - 2021-MM-DD
Added

Added EMNISTDataModule, BinaryEMNISTDataModule, EMNIST dataset, BinaryEMNIST dataset and EMNIST_METADATA (#676).

Changed
Deprecated
Removed
Fixed

Fixed the MNIST download giving HTTP 404 with torchvision>=0.9.1 (#674)

Removed momentum updating from val step and add separate val queue (#631)

@sugatoray Could you allow us to edit your PR so that I can directly push some minor fixes/improvements to your branch? https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@sugatoray Could you allow us to edit your PR so that I can directly push some minor fixes/improvements to your branch? https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@akihironitta You have editor access the PR branch now.

Keeping this table handy here (just in case):
"""
    Specs:
        - 6 splits: ``byclass``, ``bymerge``,
                    ``balanced``, ``letters``,
                    ``digits`` and ``mnist``.
        - Table:
          | Split Name   | Classes | No. Training | No. Testing | Validation | Total   |
          |--------------|---------|--------------|-------------|------------|---------|
          | ``byclass``  | 62      | 697,932      | 116,323     | No         | 814,255 |
          | ``bymerge``  | 47      | 697,932      | 116,323     | No         | 814,255 |
          | ``balanced`` | 47      | 112,800      | 18,800      | Yes        | 131,600 |
          | ``digits``   | 10      | 240,000      | 40,000      | Yes        | 280,000 |
          | ``letters``  | 37      | 88,800       | 14,800      | Yes        | 103,600 |
          | ``mnist``    | 10      | 60,000       | 10,000      | Yes        | 70,000  |
          source: https://arxiv.org/pdf/1702.05373.pdf [Table-II]
        - For each split:
          - Each image is (1 x 28 x 28)
"""

@akihironitta I also added the documentation (for sphinx) under docs/source/. The datamodules with :star: were developed under this PR. But other datamodules (with only :green_circle: ) were just added to the documentation.
:question: Perhaps I could open a separate issue to address this update (updating datamodules documentation generation with sphinx)?

[x] File: datamodules_others.rst:

[x] BinaryEMNISTDataModule :green_circle: :star:
[x] BinaryMNISTDataModule :green_circle:
[x] CIFAR10DataModule :green_circle:
[x] CityscapesDataModule :green_circle:
[x] EMNISTDataModule :green_circle: :star:
[x] FashionMNISTDataModule :green_circle:
[x] ImagenetDataModule :green_circle:
[x] KittiDataModule :green_circle:
[x] MNISTDataModule :green_circle:
[x] SSLImagenetDataModule :green_circle:
[x] STL10DataModule :green_circle:

[x] File: datasets_others.rst

@sugatoray Thanks for having a look at my branch (https://github.com/PyTorchLightning/lightning-bolts/tree/feature/672_EMNISTDataModule) and applying changes.

@akihironitta It seems another error is failing the build. Could you please look into it?  Could you please look into it? As I have not made any changes to CIFAR10DataModule, I am not sure what is causing this. :warning:

You're right it seems like the error is unrelated to the change in this PR, so we can just ignore it here for now and fix it in another PR later.

@akihironitta All suggested changes were taken into account. The only one that is still open is about _emnist_split_exists. Please have a look at the code and let me know if you have any other suggestions.

@sugatoray Hi, thanks for having a look again!
@PyTorchLightning/core-bolts Would you mind having a look at the changes?

The failing tests are irrelevant to the change in this PR.
pytest summary at c6adbae
=========================== short test summary info ============================
FAILED tests/callbacks/verification/test_base.py::test_verification_base_get_input_array[device0]
FAILED tests/callbacks/verification/test_batch_gradient.py::test_batch_gradient_verification_pl_module[device0-True]
FAILED tests/callbacks/verification/test_batch_gradient.py::test_batch_gradient_verification_pl_module[device0-False]
FAILED tests/callbacks/verification/test_batch_gradient.py::test_batch_gradient_verification_callback[0]
FAILED tests/models/rl/test_scripts.py::test_cli_run_rl_dqn[ --env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run 1 --warm_start_size 10 --n_steps 2 --batch_size 10]
FAILED tests/models/rl/test_scripts.py::test_cli_run_rl_reinforce[ --env CartPole-v0 --max_steps 10 --fast_dev_run 1 --batch_size 10]
FAILED tests/models/rl/test_scripts.py::test_cli_run_rl_vanilla_policy_gradient[ --env CartPole-v0 --max_steps 10 --fast_dev_run 1 --batch_size 10]
= 7 failed, 288 passed, 23 skipped, 1 xfailed, 532 warnings in 1053.39s (0:17:33) =

@PyTorchLightning/core-bolts Could you have another look?


Any ability to return the tags of a post that was found?

Title says it all. All i need is to get the tags that the post had

I'm pretty sure thats already possible.
You can just do this by .common.tags, which should contain any tags if there were any.


Using the shared object (.so) with Python on Linux

I am trying to use libtemplatematching_ctype.so in a python file but the matcher is not returning any results. I works perfectly with templatematching_ctype.dll but I am not able to run the same code on Linux using the shared object. I would really appreciate your help.

Try this: https://github.com/acai66/opencv_matching/issues/3#issuecomment-2119180289

Thank you this solved my problem!


No autocomplete when typing region keywords

re #39582
Tried to type in /*#region*/ at the beginning of a CSS file but didn't get any auto-complete.

I see it if I trigger suggestions manually. In other languages I see the popup when I type #r. Not sure if I should expect to see it when typing #?

Yes, the idea is that you just need to type '#'. Comments are added by the completion proposal.
I just tested that and it seem to work for me

Quick suggestions are normally turned off inside comments, so that's expected.
That's controlled by the setting
    "editor.quickSuggestions": {
        "other": true,
        "comments": false,
        "strings": false
    }

Closing as what you see is the expected behaviour. Please reopen if you disagree.


More optimizations for estargz

I observe many possible optimization points for estargz lazy pulling, such as:

pull estargz TOCs in parallel;
further investigation / improvements of estargz chunk lazy pulling;
we need to support estargz prioritize files;
convert all estargz TOCs to RAFS v6 bootstrap in advance as bootstrap and ship as a whole;

This should have already fixed by read amplification on master branch.


StrictlySimple option

Clipper had a StrictlySimple option that split polygons that were touching at a vertex. This option was quite useful and I can't find it in Clipper2. Am I missing the option? The case that I care about is the picture on the left in the documentation linked to above where two polygons are touching at a single vertex.

Hi Nathan. Please post these sorts of questions in discussion.
This isn't an issue, just a feature that's no longer present in this release.
And I'm not likely to add this feature back in because it would require a lot more time and effort and code to make the results reliably simple.

@AngusJohnson Thanks for your response.
Regarding posting this in "Discussions", there should be a "Convert to discussion" link in the right margin of this issue. I definitely considered posting it in "Discussions" but I prefer "Issues" in general and couldn't find a clear statement on the repo if you had a preference. An issue template that specifies that your preference is that only bugs should go in "Issues" would have tipped the balance for me. In the future I'll be sure to post only bugs as an Issue.

I now see your position more clearly here, I missed that the first time around.


Removed carla and srunner from requirements

Both carla and srunner have been removed from the requirements.

This change is

Updated the README. This is heavily based on the first part of the leaderboard web. Adding @sergi-e


Update command-line.md

As noticed here, exa is unmaintained, one active maintained fork is eza.
I am not sure if the proposed change of the guide is appropriate. It's a medium blog, which discusses eza itself, as well as the guide for aliases. Feel free to change.

Thanks so much for spotting this and making a PR! Putting it through now.


[BUG]: iOS - Video does not stay paused when app moves from background to foreground

Version
6.8.1
What platforms are you having the problem on?
iOS
System Version
iOS 18.0
On what device are you experiencing the issue?
Real device, Simulator
Architecture
New architecture with interop layer
What happened?
When my app is in the background and current video is paused via native controls, the video does not stay paused and instead resumes playing when the app is foregrounded
What I expected was that when my app is in the background and the current video is paused via native controls, the video should continue to be paused when I foreground the app.
Potential Cause & Fix
I did some digging in order to create a patch for my app, and came across what I believe was the cause, and I did create a fix as well that is working smoothly for me. I've specified more details of the cause and fix in this PR: https://github.com/TheWidlarzGroup/react-native-video/pull/4320
Reproduction Link
No response
Reproduction

Open Video
Pause Video
Background App
Foreground App
Video should automatically start playing on foregrounding

Resolved by the merging of https://github.com/TheWidlarzGroup/react-native-video/pull/4320


keepass 2.46 The icon will return to the default after saving

I see, it happens only to this entry (Origin) or any entry?
Not sure if this is an issue related to the language, but have you tried to change it to english for example?
Have you tried disabling other plugins?
Let me know.

@navossoc Solved, it is the problem of the "OnedriveSync" plug-in, just delete it

Thanks for sharing.


Several server crashes when running tests in parallel

Describe the bug
Several server crashes when running tests in the way below.
How are you accessing AGE (Command line, driver, etc.)?
Accessing AGE through command line.
What data setup do we need to do?
Apache AGE (PG16 branch) with PostgreSQL (REL_16_STABLE).
What is the necessary configuration info needed?
First build:
./configure CFLAGS=" -Og" --enable-tap-tests --enable-debug --enable-cassert

Second build:
./configure CFLAGS=" -Og" --enable-tap-tests --enable-debug

I was able to crash a server by doing the following:
Makefile:
diff --git a/Makefile b/Makefile
index b405ff6..549e05b 100644
--- a/Makefile
+++ b/Makefile
@@ -85,31 +85,7 @@ SQLS := $(addsuffix .sql,$(SQLS))
 DATA_built = $(age_sql)

 # sorted in dependency order
-REGRESS = scan \
-          graphid \
-          agtype \
-          catalog \
-          cypher \
-          expr \
-          cypher_create \
-          cypher_match \
-          cypher_unwind \
-          cypher_set \
-          cypher_remove \
-          cypher_delete \
-          cypher_with \
-          cypher_vle \
-          cypher_union \
-          cypher_call \
-          cypher_merge \
-          age_global_graph \
-          age_load \
-          index \
-          analyze \
-          graph_generation \
-          name_validation \
-          jsonb_operators \
-          drop
+REGRESS=--schedule=schedule

 srcdir=`pwd`

schedule:
test: cypher_match cypher_match cypher_match cypher_match cypher_match cypher_match

Start tests:
for i in `seq 100000`;do echo "ITER $i";make -s installcheck;if coredumpctl;then break;fi; done

Results:
ITER 75
# +++ regress install-check in  +++
# using temp instance on port 61958 with PID 39227
# parallel group (6 tests):  cypher_match cypher_match cypher_match cypher_match cypher_match cypher_match
not ok 1     + cypher_match                             1081 ms
# (test process exited with exit code 2)
not ok 2     + cypher_match                             1035 ms
# (test process exited with exit code 2)
not ok 3     + cypher_match                             1061 ms
# (test process exited with exit code 2)
not ok 4     + cypher_match                             1034 ms
# (test process exited with exit code 2)
not ok 5     + cypher_match                             1036 ms
# (test process exited with exit code 2)
not ok 6     + cypher_match                             1035 ms
# (test process exited with exit code 2)
1..6
# 6 of 6 tests failed.
# The differences that caused some tests to fail can be viewed in the file "/home/egor/work/subtree/age/regress/regression.diffs".
# A copy of the test summary that you see above is saved in the file "/home/egor/work/subtree/age/regress/regression.out".

There were many attempts to run tests in this way, so during the launch process I was able to get several different crashes, presented below:
Backtrace of the crash on the build with --enable-cassert:
bt1_cassert.txt
Bracktrace of the first crash on the build without --enable-cassert:
bt2.txt
Bracktrace of the second crash on the build without --enable-cassert:
bt3.txt
Expected behavior
Expected ERROR to be shown or sql query to be succesfully executed
Best regards,
Egor Chindyaskin
Postgres Professional: http://postgrespro.com/

@saygoodbyye We do not support user modified Makefiles. The Makefile is only for installing AGE and is only intended to test what was just installed.
If you want to run those specific checks in parallel to highlight an issue, please write a separate script to do so.

It seems that the server crashes occur when running tests using a specific Makefile setup and iterating through the tests multiple times. Here's a summary of the issue and the steps leading to the server crashes:
Bug Description:
Several server crashes occur when running tests in a loop with the specified Makefile setup.
Steps to Reproduce:
Modify the Makefile to run tests in a loop multiple times.
Start tests using the modified Makefile.
Iterate through the tests multiple times, possibly hundreds of iterations.
Observe server crashes occurring during the test iterations.
Expected Behavior:
Tests should execute successfully without causing server crashes even when run multiple times in a loop.
Environment:
Apache AGE (PG16 branch) with PostgreSQL (REL_16_STABLE).
Makefile Modification:
REGRESS=--schedule=schedule
Modified Test Execution:
for i in seq 100000; do
echo "ITER $i"
make -s installcheck
if coredumpctl; then
break
fi
done
Actual Outcome:
Server crashes occur during the test iterations, leading to failed tests and potential instability.
Workaround:
Since the issue seems related to running tests repeatedly in a loop, you might consider running the tests individually or in smaller batches to mitigate the likelihood of server crashes until the root cause of the crashes can be identified and resolved. Additionally, analyzing the server logs and core dumps generated during the crashes could provide insights into the underlying cause.

@jrgemignani, I was able to reproduce this bug in a different way using pgreplay utility.
To reproduce bug follow steps:
*** configure and install pgreplay ***
*** then replay attached postmaster.log file***
./pgreplay -j postmaster.log

postmaster.log


Derive Copy, Eq, and Hash for Quaternion.

They were implemented manually.
Eq was implemented in such a way that -q was considered equal to q,
probably because they represent the same rotation. They are, however,
not equal quaternions. Because of this error, the implementation of Hash
was not compatible with the implementation of Eq. This fixes that.
Fixes #583.

Thank you for this PR! I will review it in depth next Saturday.

The CI fails because we actually have a test for q = -q there.
Would you mind:

Adding the method .is_same_rotation_as(other) I mentioned in the issue #583 (the method name can be something else if you think of something better).
Replacing the mq == q check by q.is_same_rotation_as(&mq) in the test that currently fails?

Thanks for reviewing so quickly!
No problem, I'll make those changes tomorrow.

I also noticed that AbsDiffEq, RelativeEq, and UlpsEq were implemented to consider q = -q. I have changed those as well to no longer do that. Should that functionality be restored through some other function? Or another type?

Ah, looks like I should run cargo test --all-features, not just cargo test. /me goes back to fixing more tests.

I'm starting to feel like our mistake in the first place was to not create a wrapper type like struct RotationQuaternion<N>(Unit<Quaternion<N>>) that would indeed assume that its internal q is the same as its -q.
There are at least two other benefits of doing that:

It will be more obvious for newcomers to understand that RotationQuaternion is a rotation represented as a quaternion. (We could also rename the current Rotation type to RotationMatrix to be explicit.)
It will prevent a tricky mistake. Currently if you write -q * v where q is a unit-quaternion and v a vector, it will compile and be equal to q * v which is misleading considering one could expect the result to be -(q * v). With a wrapper type that does not implement Neg, the -q * v expression will simply not compile.

One downside is that this will be a breaking change.
Would you like to make this change @m-ou-se ? Here is a list:

Replace the type UnitQuaternion<N> = Unit<Quaternion<N>> by struct RotationQuaternion<N>(pub Unit<Quaternion<N>>).
Replace UnitQuaternion by RotationQuaternion everywhere.
On all methods of the new RotationQuaternion the self. will have to be replaced by self.0 to account for the struct wrapping.
Add a custom implementation of Hash that returns the same hash for both self.0 and -self.0.
Add a impl From<Unit<Quaternion>> for RotationQuaternion<N>.

We should do something similar for Unit<Complex> but that will be the purpose of another issue.

Yes, that does feel like the best option to avoid a bunch of issues.
I'll work on that change. I'll close this PR and open a new issue to track it.


methioninuria

Add new term:
methioninuria as a child of aminoaciduria MP:0003311 and increased methionine level MP:0030641
DEF: excretion of excessive amounts of methionine in the urine
SYN: increased urinary methionine level
SYN: increased urine methionine level
Annotations from J:175382, J:37, J:349712

Added methioninuria MP:0031637


Make OnUpload able to return a promise

Type of issue

[ ] Bug report
[X] Feature request
[X] Support request

Uploader type

[X] Traditional
[ ] S3
[ ] Azure

Fine Uploader version
{5.13.0}

Dear @rnicholus,
I have faced a case where i need to send a request to the sever once the upload start and wait the server response before the chunks or the file start upload, but seems that onUpload callback doesn't support promise.
So my questions are :
1- is that currently available in another way ?
2- is there any future plan to implement promise in onUpload ?
3- Currently the now function is calling "options.onUpload(id, name);"
so if we need to wait any promise to be resolved we should do it there.
is there any consequence of doing that in now function?
Thanks, appreciate your support!!!

Can you provide more detail? Why do you need to send a request to the server before the upload starts? What is the nature of this request? Can it not be sent in your onSubmit handler?

+1 - In my case, I would need to prompt the user if the file exists, and each file could have a prompt.  Also, with the work around that I provided below, users may complain about additional clicks.  Since the file already exists, there are 4 scenarios that could occur.

User can overwrite the file
User can rename the file automatically, server would append _1 to the name
User can resume the file, maybe because the cache has been removed already and the file on the server is smaller than the uploaded file (clearing history seems to remove it, even if it has not been expired).  Also, it is possible that for whatever reason, one person sees that the file has not been uploaded completely, it has expired, and wants to continue the upload.
User can cancel and rename the file manually.  Event would have to be cancellable.

I have been able to work around this by checking if the file already exists onsubmit through ajax call (because I still want the file to show) and get the server filesize, and display a link for each file that already exists.  I modified the fineuploader with another status of AlreadyExists, and set the status to this so the other events do not trigger on it.
NOTE: javascript is not my area of strength:
`
onSubmitted: function (id, name) {
//Triggered on drag and drop
var file = manualUploader.getFile(id);
                var result = $.ajax({
                    type: "GET",
                    url: '/server/upload/exists?foldername=' + (file.qqPath === undefined ? "" : file.qqPath) + '&filename=' + file.name + "&size=" + manualUploader.getSize(id),
                    async: false,
                    cache: false
                }).responseText;

                var result = jQuery.parseJSON(result);
                var file = $(".qq-file-id-" + id);
                var selector = file.find("#duplicate-selector");
                if (result.success === false) {

                    file.find("#newSizeSelectorValue").val(result.newSize);
                    file.find("#oldSizeSelectorValue").val(result.oldSize);

                    var duplicate = file.find("#duplicate-options");
                    duplicate.click(function () {
                        $("input[name=fileoperations][value=4]").prop('checked', true);
                        $("#fileNamePlaceholder").text(name);

                        var file = $(".qq-file-id-" + id);
                        var oldSize = file.find("#oldSizeSelectorValue").val();
                        var newSize = file.find("#newSizeSelectorValue").val();
                        if (oldSize != "0B (0KB)" && oldSize !== newSize && Number(oldSize.substring(0, oldSize.indexOf("B"))) < Number(newSize.substring(0, newSize.indexOf("B")))) {
                            $("#resumePlaceholder").show();
                            $("#oldSizePlaceholder").text(oldSize);
                            $("#newSizePlaceholder").text(newSize);
                        }
                        else {
                            $("#resumePlaceholder").hide();
                        }

                        $("#duplicateId").val(id);
                        $("#duplicateModal").modal({                    // wire up the actual modal functionality and show the dialog
                            "backdrop": "static",
                            "keyboard": true,
                            "show": true                     // ensure the modal is shown immediately
                        });
                    });

                    selector.show();

                    manualUploader.setStatus(id, qq.status.ALREADYEXISTS);
                }
                else {
                    selector.hide();
                }
            },

`
`
onUpload: function (id, name) {
var file = $(".qq-file-id-" + id);
                var selectorValue = file.find("#duplicateSelectorValue").val();
                if (selectorValue !== "") {
                    manualUploader.setParams({ operation: selectorValue }, id);
                }
                else
                {
                    manualUploader.setParams({ guid: "", operation: "" }, id);
                }

                if(selectorValue === "append")
                {
                    var file = $(".qq-file-id-" + id);
                    var oldSize = file.find("#oldSizeSelectorValue").val();
                    var newSize = file.find("#newSizeSelectorValue").val();
                    manualUploader.updateProgress(id, name, oldSize.substring(0, oldSize.indexOf("B")), newSize.substring(0, newSize.indexOf("B")));
                }
            },

`

I modified the fineuploader with another status of AlreadyExists, and set the status to this so the other events do not trigger on it.

Why not just return a Promise in your onSubmit and reject it if the file already exists?

I want the file to still show in the uploader.  If I am not mistaken, rejecting on the onSubmit removes the file from FineUpload files so it no longer shows.  If it no longer shows, then there is no longer a prompt for the user to be able to handle it within fineuploader.  If there is no prompt, then there is no business login that can be shown to the user.

Dear @rnicholus ,
In my case , i need to send a request to a storage server that will execute the following :
1- create path directory
2- grant user access to the directory
3- send a request to server 'B' using a paid service to log the upload and get a signature
( in case 'B' return a false we need to run another part of business )
4- send the signature back to the client side
5- upload will start if all is ok
I'm not using onSubmit because the process should start when user start the upload not just submit the file to the upload queue.
Thanks.

Dear @rnicholus ,
Another question , is there a way to get the chunk info data in onupload  ?
if not, how to check if file will be upload in chunk, since as i read in the documentation that if file size is less then the chunk size it will not be sent in chunk mode ( which is logic ) .
In our case we need to find out if the file is sent as chunk or as a complete file .
Thanks .

You can determine the file size using the getSize() API method. From there, you can determine if the file is large enough to chunk.
Let's please keep this thread/issue on topic. If there are other questions/concerns, please open up a new issue.

Dear @rnicholus ,
concurrent upload is another reason to have onUpload return promise , since it will be responsible of creating all the need folders and once everything is done upload can start , else the user will need to create lock on server to make sure that only the first arriving request will create the folder.
Using the existence of the folder as a flag to not create one will not be a good idea, since two request could be server at the same time.
Thanks.

the user will need to create lock on server to make sure that only the first arriving request will create the folder

Your server should be able to account for this by tracking appropriate file/folder state in a database, for example.

duplicate of #848


[3.2] [HTML5] Fix mouse_mode and fullscreen detection.

The canvas_id is #-prefixed to work with emscripten as a CSS selector.
When comparing to an event target ID (e.g. when checking if the canvas is fullscreen, or is locking the mouse) we need to skip the first char (the hash).
3.2 version of #45670

Thanks!


How to use New-AzADSpCredential to add certificate credentials

I am using App Registrations to deploy resources and the certificate is expiring. I am trying to write a script to add a new cert to extend the life of this Service Principal but no matter who I login as (myself, a colleague, the Service Principal itself) I get the following error:
New-AzADSpCredential : Insufficient privileges to complete the operation.
At G:\XXX\XXX\XXX\Add-NewDmfCertificate.ps1:496 char:63

... cipalName | New-AzADSpCredential -CertValue $credValue -StartDate $ce ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (:) [New-AzADSpCredential], Exception
FullyQualifiedErrorId : Microsoft.Azure.Commands.ActiveDirectory.NewAzureADSpCredentialCommand

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7077abbf-75d0-bcae-05bb-55be2d870d6f
Version Independent ID: d3cecd43-54f5-637c-5fdd-4fabe7a94e2f
Content: Permissions in Azure Active Directory
Content Source: articles/active-directory/develop/v1-permissions-and-consent.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@henry-padilla Thanks for your feedback! We will investigate and update as appropriate.

As this is a troubleshooting question please submit this at the Q&A Forums, this is most likely an issue with your permissions as your account is not a global admin, your utilizing a service principal by using the client credential flow, or you don't have the right rbac role permissions,
Please post here :
https://docs.microsoft.com/answers/index.html
As this is not within the scope of the github doc issues, I will be closing this issue out now.


Cartesian MotionPlanning and Rviz plugin issue.

Hi,
I was trying to test out this new solver (using the defaults specified in the readme) with MoveIt2 earlier this month, and ran into a couple of issues:

While planning joint_interpolation or sampling based motion (via MTC) works just fine, cartesian planning fails.
While trying to drag the interactive marker (from the MotionPlanning plugin) in Rviz to a different position, the 'Query Goal State' robot would not update.

If I changed back to using the KDL kinematics plugin (just a drop-in replacement in the kinematics.yaml file), both of those issues were resolved. This leads me to believe that there is some integration issue with the pick_ik solver.
Thanks!

Could you share more about your MoveIt environment? Distro, building from source/binaries, etc.
And do you see any errors printed on the terminal?
Lastly, if you check the "use approximate solutions" box in RViz, does pick_ik respond at all to your commands?

ROS Distro: Humble
Building from: source
Platform: Ubuntu 22.04 within Docker
I do not see any errors in the terminal while attempting to drag the interactive marker. If I try to compute a cartesian path using the MotionPlanning plugin, I get the errors below.
[move_group-1] [INFO] [1674783509.010658156] [moveit_move_group_default_capabilities.cartersian_path_service_capability]: Received request to compute Cartesian path
[move_group-1] [INFO] [1674783509.010832794] [moveit_move_group_default_capabilities.cartersian_path_service_capability]: Attempting to follow 1 waypoints for link 'left_m07_eoat_pin_link' using a step of 0.010000 m and jump threshold 0.000000 (in global reference frame)
[move_group-1] [INFO] [1674783509.013171048] [moveit_move_group_default_capabilities.cartersian_path_service_capability]: Computed Cartesian path with 1 points (followed 0.000000% of requested trajectory)

If I check the 'use approximate solution' box in Rviz when not using cartesian control, i can plan/execute to  a random valid goal successfully. But if I check the 'use cartesian path' box and and set the goal pose to something that should be achievable, then it doesn't matter if I have 'use approximate solution' checked or not. It fails to plan.
Something else I discovered. If I have one planning group using the pick_ik solver, and a different planning group using the lma_kinematics solver, both of the solvers fail to do cartesian motion on their respective groups, and their interactive markers cannot be dragged.
However, if I have one planning group using kdl_kinematics, and the other using lma_kinematics, then I can plan cartesian motion successfully using both planning groups, as well as drag their interactive markers.

Something else I discovered. If I have one planning group using the pick_ik solver, and a different planning group using the lma_kinematics solver, both of the solvers fail to do cartesian motion on their respective groups, and their interactive markers cannot be dragged.

It turns out that the PR for MoveIt here addresses the concern in the quote above. Now if I specify one planning group with the pick_ik solver and another with the LMA solver, the LMA solver works as expected (cartesian motion can be planned and the interactive marker moves), hower the pick_ik solver still fails (cartesian motion cannot be planned and the interactive marker does not move).

FWIW, I've also tried the bio_ik plugin, and that seems to work as expected.

Thank you for all the details -- that's very helpful. Will take a look and report back with what I find.

So, I was able to get things running with pick_ik on Humble as is...
https://user-images.githubusercontent.com/4603398/215121786-77b05c33-91f4-4259-89e9-f10b1e22c5c4.mp4
I did have to relax some of the tolerances (position / rotation / cost) and then crank up the minimal displacement cost to try reduce joint flips (I'd rather fail). But it seems like the interface itself is fine; just that the solution rate doesn't seem as good with this solver.
Anyways, you can play around with the parameters live and see the changes live by doing e.g.
ros2 param set /move_group robot_description_kinematics.panda_arm.minimal_displacement_weight 0.005

I'd be curious to see if changing these values can at least get your solves farther along so they don't consistently fail at 0%?

Thanks! I'll try modifying the params a bit and let you know. Did you see any issue with dragging the interactive marker?

New development: Seems like if I set the rotation_scale parameter to 0.0, the solves with pick_ik are very fast and seem consistent for the Cartesian paths. So I think perhaps the rotation cost function might have some issues.
Could you also check this on your end?
Also, the interactive marker works fine for me (with the same caveats with cost functions and tuning values as above).

Oh! I found an issue with the rotation cost, which made things work way better on my end: https://github.com/PickNikRobotics/pick_ik/pull/30
Can you try with this branch?

Still seeing 0% consistently even with the change in that branch.
FWIW, the way I've reproduced the issue is by doing:
# Pull in the latest moveit2 branch
docker pull moveit/moveit2:humble-source

# This allows docker to launch GUIs
xhost +si:localuser:root

# Run the docker container
docker run -d -it --gpus all --env DISPLAY=$DISPLAY --network host --name moveit_testing -v /tmp/.X11-unix:/tmp/.X11-unix moveit/moveit2:humble-source /bin/bash

# Enter the docker container
docker exec -it moveit_testing bash

# Within the container...

# Install the pick-ik plugin and nano
apt update
apt install ros-humble-pick-ik nano

# Navigate to the kinematics.yaml file in the panda moveit config directory and open it with nano
cd ~/ws_moveit/src/moveit_resources/panda_moveit_config/config/
nano kinematics.yaml

# Within the kinematics.yaml file...

# Replace the contents with the example configs shown from the Usage section.
panda_arm:
  kinematics_solver: pick_ik/PickIkPlugin
  kinematics_solver_timeout: 0.05
  kinematics_solver_attempts: 3
  mode: global
  rotation_scale: 0.5
  position_threshold: 0.001
  orientation_threshold: 0.01
  cost_threshold: 0.001
  minimal_displacement_weight: 0.0
  gd_step_size: 0.0001

# Exit the file

# Launch MoveIt with Rviz
cd ~/ws_moveit
source install/setup.bash
ros2 launch moveit_resources_panda_moveit_config demo.launch.py rviz_tutorial:=true

# Add MotionPlanning Rviz plugin and change the group to 'panda_arm'
# Try dragging the marker. It should not work. And cartesian motion also seems to fail to plan.

So I just tried on the Docker container and I can reproduce this issue you pointed out ... but on local builds it's fine. I think perhaps there is some issue in the container preventing this from working correctly, and I know we have a backport to Humble to fix some things...

So on local Humble builds, this works fine?

I was using a local Humble build following [this tutorial[(https://moveit.picknik.ai/humble/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html). Will need to keep digging as to why the other setups seem to break pick_ik.

Let me know if you find anything! Thanks for all your help.

Still no update on the Docker issues, but I found a bug in calculating orientation cost / angle, which https://github.com/PickNikRobotics/pick_ik/pull/31 fixes.

@swiz23 I think there was a recent issue in the moveit2 tutorials that was causing the Docker image to use bad sources. Could you try the latest versions of that image and pick_ik again and let me know how it goes? Thanks!

Hi @sea-bass,
I tried pulling again but still ran into the same issue (cannot drag interactive marker). Note that I also ran into an rviz2 issue where I got a 'black screen'. The solution proposed at https://github.com/ros2/rviz/issues/948#issuecomment-1428979499 for 'rviz2 on humble' fixed that issue. However, the original issue still remains.

Funny enough, there is a PR to address this under review right now!
https://github.com/ros-planning/moveit2_tutorials/pull/644

As I was writing that comment above, I actually thought that maybe someone had already posted an issue about it. But I wasn't sure if that issue would be in moveit2, moveit2_tutorials, or some other moveit related repo, so I figured I'd just comment about it here. Thanks for pointing me to that though!

@sea-bass @swiz23: as an update regarding the Docker issue where moveit/moveit2:humble-source image has rolling installed, it actually appears that the root cause of the issue has been discovered here: https://github.com/ros-planning/moveit2/pull/2035#issuecomment-1480082496
Feel free to keep an eye on that discussion, I'm hoping to resolve this soon. Once we get this sorted out and have all of the moveit 2 humble images fixed, hopefully this will resolve the problems being discussed in this issue as well :crossed_fingers:

@swiz23 the moveit/moveit2:humble-source should be fixed now to have humble installed instead of rolling. Would you mind pulling the latest image and checking if that helps resolve any issues you're facing?

So the humble issue seems to be fixed. But for some reason, I cannot install pick_ik from the apt store by doing 'apt install ros-humble-pick-ik' anymore. So I tried to build from source within the moveit2 humble docker container. This involved first installing 'librange-v3-dev'. However, then I ran into a compilation error towards the end of the build. The error was for every mention of 'lower_bounds'. It seems like the 'rsl' ros2 package has deprecated this function in favor of rsl::gt_eq.
root@re2-pgh-nb-84:~/ws_moveit# colcon build --mixin release --packages-select pick_ik
Starting >>> pick_ik
--- stderr: pick_ik
In file included from /root/ws_moveit/src/pick_ik/src/pick_ik_plugin.cpp:7:
/root/ws_moveit/build/pick_ik/pick_ik_parameters/include/pick_ik_parameters.hpp: In member function ‘rcl_interfaces::msg::SetParametersResult pick_ik::ParamListener::update(const std::vector<rclcpp::Parameter>&)’:
/root/ws_moveit/build/pick_ik/pick_ik_parameters/include/pick_ik_parameters.hpp:196:61: error: ‘auto rsl::lower_bounds(const rclcpp::Parameter&, const T&) [with T = double]’ is deprecated: Replace with rsl::gt_eq [-Werror=deprecated-declarations]
  196 |             if(auto validation_result = lower_bounds<double>(param, 1e-12);
      |                                         ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from /root/ws_moveit/build/pick_ik/pick_ik_parameters/include/pick_ik_parameters.hpp:25,
                 from /root/ws_moveit/src/pick_ik/src/pick_ik_plugin.cpp:7:
/opt/ros/humble/include/rsl/rsl/parameter_validators.hpp:221:59: note: declared here
  221 | [[deprecated("Replace with rsl::gt_eq"), nodiscard]] auto lower_bounds(
      |                                                           ^~~~~~~~~~~~
In file included from /root/ws_moveit/src/pick_ik/src/pick_ik_plugin.cpp:7:
/root/ws_moveit/build/pick_ik/pick_ik_parameters/include/pick_ik_parameters.hpp:203:62: error: ‘auto rsl::lower_bounds(const rclcpp::Parameter&, const T&) [with T = long int]’ is deprecated: Replace with rsl::gt_eq [-Werror=deprecated-declarations]
  203 |             if(auto validation_result = lower_bounds<int64_t>(param, 1);
      |                                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
In file included from /root/ws_moveit/build/pick_ik/pick_ik_parameters/include/pick_ik_parameters.hpp:25,
                 from /root/ws_moveit/src/pick_ik/src/pick_ik_plugin.cpp:7:
/opt/ros/humble/include/rsl/rsl/parameter_validators.hpp:221:59: note: declared here
  221 | [[deprecated("Replace with rsl::gt_eq"), nodiscard]] auto lower_bounds(

Ah yes, we found and have since fixed some conflicts with that RSL package as we are using some of its latest features.
I believe you may have to apt-get remove ros-humble-rsl and pull https://github.com/PickNikRobotics/rsl down from source, then rebuild.

If you look at https://github.com/PickNikRobotics/RSL/commits/main, it seems this commit was made yesterday and the rsl package was released as a debian. This is a breaking change with pick_ik.

Oh, I see -- thank you! I'll have to go fix that, then.

Hang on, pick_ik doesn't use that. This has to do with the parameter validation in generate_parameter_library.
@tylerjw Do you know what needs to be resolved? Is it making sure that older parameter_traits libraries aren't hanging around?

@swiz23 OK so I think I fixed it in https://github.com/PickNikRobotics/pick_ik/pull/37 -- thank you so much for continuing to help us with this. I went through your exact steps but just changed to the branch to this PR.
Could you try the following inside the container, along with your other steps?
cd ~/ws_moveit/src
git clone -b update-rsl-bounds https://github.com/PickNikRobotics/pick_ik.git
cd ..
rosdep install -r --from-paths src --ignore-src --rosdistro $ROS_DISTRO -y
colcon build

Hi @sea-bass,
I followed your instructions and cloned your particular branch. I also modified the moveit params as you suggested. Pick Ik now builds successfully. I am also able to drag the interactive marker in Rviz as well as plan/execute cartesian motion using the MotionPlanning plugin.
It's still a bit curious to me as to why I can't install ros-humble-pick-ik from the apt store. It used to be able to work...
In any event, once PR #37 lands, I'll consider this issue closed.

I think there was an issue with the most recent release of MoveIt where some binaries, like pick_ik, didn't make it through.
This is also being looked at, so will be resolved in the near future...

EDIT: Looked into this, seems that this image uses the ros2-testing apt repo (see here), which for some reason doesn't have the ros-humble-pick-ik package... so that's the issue.
If you were using rolling, or the regular (non-testing) apt repos, you would be able to install pick_ik as normal from binaries.
We'll get to resolving this too!


Fix validation generation for crd targets that lack validation

It was not a reasonable assumption that all crd targets would have a validation schema.

Worked in my tests /lgtm


Indicate to use UNC path and FQDN rather than NetBIOS name

The following is one of the steps:

Go to the Actions tab and click New... Ensure that Start a program is selected in the Action field. Enter the NetBIOS path of the shared WindowsDefenderATPOnboardingScript.cmd file.

However, as enterprises start disabling NetBIOS and NTLM, the following may be more precise going forward:

Go to the Actions tab and click New... Ensure that Start a program is selected in the Action field. Enter the UNC path, using the file server's fully qualified domain name (FQDN), of the shared WindowsDefenderATPOnboardingScript.cmd file.

In fact, in environments that have fully or partially disabled NTLM, using what has been called the "NetBIOS name" won't work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 523651c3-a318-2369-6892-d13e04991596
Version Independent ID: 624c5e05-f87d-1bd4-bc87-bd55dcac1d86
Content: Onboard Windows 10 devices to Microsoft Defender for Endpoint via Group Policy
Content Source: microsoft-365/security/defender-endpoint/configure-endpoints-gp.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@loosus Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5796
Once the author approves the PR, the document will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @loosus Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


jogl: refactor

Description of changes
The goal of this PR is to establish a clear patchPhase/buildPhase separation. Also fixes building on darwin.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 287865 run on aarch64-darwin 1

2 packages built:

gephi
jogl


Rendering OpenAI prompts using CSharpMath

Hello,
I am trying to render GPT responses using CSharpMath. It works well when I try using single equations, however, when I feed the following text I get lots of errors.
Thanks in advance for any solution you may suggest.
For two inertial frames, \( S \) and \( S' \), where \( S' \) is moving at a velocity \( v \) relative to \( S \) along the x-axis, the Lorentz transformations are given by:

\[
x' = \gamma (x - vt)
\]
\[
t' = \gamma \left(t - \frac{vx}{c^2}\right)
\]

where:
- \( x \) and \( t \) are the position and time coordinates in frame \( S \).

Minimal example which gives an unexpected error please.

Hope this is descriptive enough:
        var painter = new CSharpMath.SkiaSharp.MathPainter();
        painter.FontSize = 40;
        painter.LaTeX = @"For two inertial frames, \( S \) ";
        painter.Draw(canvas);

That is not a math-mode expression but you are using a MathPainter. You should try a TextPainter.


Bending doesn't work properly

Flexible objects don't work as they intended

You must download all files from another page for this functionality to work properly.


How do we get access to this?

I appreciate that this is in preview and isn't available in tenants everywhere but is there an option to opt in to it? We started a Phish security test and I'd love to use the Advanced option to not have to filter out the incidents\alarms this is producing.
Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 Microsoft will approach the tenants that they want to be part of the preview based on some specific criteria (size, industry, use of specific features, previous support cases, etc.).

@JDFlannery, this is live and available for everyone as of Wednesday July 28.
Feature ID 72207
Thanks for the feedback.
Closing


Vulkan async compute

Is not there a way support vulkan async compute?

doom eternal didn't work. not sure about other games/apps


DataParallel run with Transformers crashes

Describe the bug
When running transformers experiments with knowledge distillation modifier in DataParallel mode and logging enabled (for example wandb), the run crashes in the first iteration with:
Boolean value of Tensor with more than one value is ambiguous

raised here: https://github.com/neuralmagic/sparseml/blob/25116d77c10e30dfabe541881f48c895e9ab2557/src/sparseml/pytorch/utils/logger.py#L573
Tracking the issue leads to model's output in DataParallel mode. Instead of the expected tensor with one value, the loss is a tensor with n_gpu values. In the standard HF transformers pipeline, this loss is averaged a bit later and thus doesn't help with logging that happens in the knowledge distillation modifier class.
Expected behavior
Runs shouldn't crash and the loss value should be handled properly.
To Reproduce
Run any transformers experiment with knowledge distillation in DataParallel mode and logging enabled (for example wandb).

@eldarkurtic we have seen that running with n_gpu > 1 may cause some bugs. We are actively working on that. Could you please share your CLI command (e.g. sparseml.transformers.question_answering ... ), so I can look into the problem in more detail?