Consider using struct as opposed to class

For DateInRegion and Region classes, consider using structs.
From Swift don't do that:
Use classes if you want reference types. Use structs if you want value types. You can add functionality to both (and to enumerations) in Swift. When in doubt, err on the side of value types. If your construct doesn’t have a life cycle, or two constructs with similar values should be considered as the same thing, use a struct.

Okay we can merge this feature into develop

Not quite: develop branch fails to compile with struct in DateInRegionFormatterPort:
		let bundle = NSBundle(forClass: DateInRegion.self)

We can pass another class part of the library if our intent is to get the path inside SwiftDste package itself. Right?

Yep, but this is probably trivial if we adopt NSDateComponentsFormatter?

Could we consider it closed?

I think issues should be closed when the solution branch is merged into the master ;-)

My proposal is to round everything up, do a mutual review of code, test code and docs and start the release process as I described in TEAM.md. Good thinking?

Okay I've missed the point with master branch and gitflow. You are absolutely right.
Today I'll check the code for Swift Guidelines as described in #131.
Would you check toNaturalString() of DateInRegion and toString() of NSTimeInterval so we can add both to the doc and tests? I've just added it recently but all of these commits were made directly on develop (my fault).

Feature branches are handy when multiple people are working on the same code. No big deal (yet) ;-)
I will spend some time this afternoon.

Fixed in v3.0.0


"docker-compose up -d workspace" failed.

Info:

Docker version ($ docker --version): Docker version 17.03.1-ce, build c6d412e
Docker-compose version ($ docker-compose -v): docker-compose version 1.13.0, build 1719ceb
Python version ($ python -V)Python 2.7.10
Laradock commit ($ git rev-parse HEAD): b2ad5f16e8e82fd5f1f9364ba9b26b85df212c7f
System info (Mac, PC, Linux): Mac
System info disto/version: macOS 10.12.4（16E195）

Issue:
What seems to be going wrong?
"docker-compose up -d workspace" failed with "UnicodeDecodeError".
I cleaned up my Docker environment.
Then I tried to install laradock, but it failed.
This is my all log.
project sumi$ docker system prune
WARNING! This will remove:
	- all stopped containers
	- all volumes not used by at least one container
	- all networks not used by at least one container
	- all dangling images
Are you sure you want to continue? [y/N] y
Total reclaimed space: 0 B
project sumi$ git clone https://github.com/Laradock/laradock.git
Cloning into 'laradock'...
remote: Counting objects: 4957, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 4957 (delta 2), reused 0 (delta 0), pack-reused 4944
Receiving objects: 100% (4957/4957), 5.36 MiB | 1.82 MiB/s, done.
Resolving deltas: 100% (2560/2560), done.
project sumi$ cd laradock
laradock sumi$ cp env-example .env
laradock sumi$ docker-compose up -d workspace
Creating network "laradock_default" with the default driver
Creating network "laradock_frontend" with driver "bridge"
Creating network "laradock_backend" with driver "bridge"
Creating volume "laradock_phpmyadmin" with local driver
Creating volume "laradock_rethinkdb" with local driver
Creating volume "laradock_mariadb" with local driver
Creating volume "laradock_elasticsearch-data" with local driver
Creating volume "laradock_postgres" with local driver
Creating volume "laradock_aerospike" with local driver
Creating volume "laradock_redis" with local driver
Creating volume "laradock_minio" with local driver
Creating volume "laradock_caddy" with local driver
Creating volume "laradock_adminer" with local driver
Creating volume "laradock_mysql" with local driver
Creating volume "laradock_neo4j" with local driver
Creating volume "laradock_elasticsearch-plugins" with local driver
Creating volume "laradock_memcached" with local driver
Creating volume "laradock_mssql" with local driver
Creating volume "laradock_percona" with local driver
Creating volume "laradock_mongo" with local driver
Building workspace
Traceback (most recent call last):
  File "docker-compose", line 3, in <module>
  File "compose/cli/main.py", line 68, in main
  File "compose/cli/main.py", line 118, in perform_command
  File "compose/cli/main.py", line 924, in up
  File "compose/project.py", line 400, in up
  File "compose/service.py", line 307, in ensure_image_exists
  File "compose/service.py", line 871, in build
  File "site-packages/docker/api/build.py", line 141, in build
  File "site-packages/docker/utils/build.py", line 12, in tar
  File "site-packages/docker/utils/build.py", line 43, in exclude_paths
  File "posixpath.py", line 73, in join
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 28: ordinal not in range(128)
Failed to execute script docker-compose
laradock sumi$

Expected behavior:
What should be happening instead?
"docker-compose up -d workspace" will finish successfully.

Reproduce:
How might we be able to reproduce the error?
It causes anytime.

I found solution.
My path to laradock contains Unicode chars, like "/User/me/プロジェクト/laradock".
I changed it to "/User/me/Project/laradock", and errors are gone.
I hope that someone will fix this.


Added Charts for All time stats and first/most recent appearance stats

Added new charts to display

All time chart entries and all time weeks on chart

First and most recent appearance on each chart

Pages Affected:
Artist Scorecard
Page Before

Page After

Closes #4

This does not cover number of items on chart or their ratio, per #4
Also need to make a issue listing the inclusion of first and most recent entries table that was added, as is out of scope

This PR is out of date, not gonna update.
Issue made for count of items (songs vs albums)

Looks good


[DO NOT MERGE] Add a benchmark for CircularBuffer setBytes/writeBytes, see #1…

…216.
Motivation:
When calling ByteBuffer setBytes/writeBytes with CircularBuffer we take the slow path. Before we make any changes we want a baseline for current performance.
Modifications:
Adds ByteBuferBenchmark.swift and tests circular_buffer_into_byte_buffer_1kb, circular_buffer_into_byte_buffer_1mb.
Result:
Extra performance tests
Don't merge yet until a baseline test has run.

@swift-nio-bot test perf please

@swift-nio-bot add to whitelist

@swift-nio-bot test perf please

@swift-nio-bot test perf please

@swift-nio-bot test perf please

Lol this made those benchmarks pretty fast. We should follow up by increasing the iteration counts of those tests, probably.

@Lukasa PR is feature complete, please let me know if more changes are required

CC @tanner0101 / @pushkarnk : @richardalow gives everybody some pretty awesome WebSocket perf wins here!

CC @tanner0101 / @pushkarnk : @richardalow gives everybody some pretty awesome WebSocket perf wins here!

Don't get too excited about this - I think the improvement in the benchmark is because of a speedup in the ByteBuffer allocator used in the test. The writeBytes with Repeated was very slow so allowing specialization has sped it up, but I can't detect any other saving.
Anyway, this shows how this PR can help other types significantly.

Hah, yes, good spot!


Issues/#1225 investment costs for technologies

Fixes: #1225

:+1:
Merged this manually to fix the conflict.


storage-nov-release-datalake-12.4.0

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

also need to update cmake-modules/FolderList.cmake and vcpkg related files

/azp run cpp - storage


.stylelintrc rules not applied

I seem to be having a few issues with this package. I am not 100% clear as to where certain rules are getting their fixes from but it seems it keeps ignoring certain things no matter what I change in the .stylelintrc file in the project directory.
Currently these are the contents:
{
    "plugins": [
        "stylelint-scss",
    ],
    "rules": {
        "indentation": "tab",
        "string-quotes": "single",
        "color-no-invalid-hex": true,
        "function-parentheses-space-inside": "always",
        "media-feature-parentheses-space-inside": "always",
        "selector-pseudo-class-parentheses-space-inside": "always",
        "max-empty-lines": 8,
        "scss/at-function-parentheses-space-before": "always"
    }
}

However when I am running the command, I am only seeing indentation fixes getting applied correctly. any rules such as function-parentheses-space-inside don't change the outcome no matter what settings I change.

This is happening for me too. My config file isn't being used. I'm using the VS Code plugin but I've tested this using the CLI as well.

It seems to respect my config when running via CLI. Running 0.4.2

This also happening for me. I have .stylelintrc defined but it seems like it doesn't respect the rules I define. I just format my scss files with vscode. I have "editor.formatOnSave": true on my settings.json


update to lastest nightly

r? @chandraprakash
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @s-brian


Add GC resistant GObject subclasses (Alternative)

Very similar to #106, but uses a separate ToggleRefManager.
Fixed #105.

Thanks, I'll add more tests and end up with a third version that will be a mix of both PR's.

I just reviewed yours and will merge it, thanks.
I'll close the other MRs.


Support for conditional validation by class-validator

Current version of generator allows us to use validation decorators from class-validator. But it seems that conditional validation feature is not supported yet. Also I suppose that these conditions may differ in Create and Update DTOs.
One of the possible solutions is to add a couple of new decorators - @DtoCreateValidateIf(...) and @DtoUpdateValidateIf(...) - which will be transformed to @ValidateIf() decorator in corresponding DTO
This pull request add this functionality

Thanks! I will look into it.

I just released version 1.20.0 including your changes.


Does pouchdb-react-native support additional plugins?

Hi,
My setup requires client authentication on CouchDB side and https.
According to docs pouchdb-react-native contains replication, HTTP and map/reduce plugins only.
In case I need .login plugin to get client authentication - could I :

require it within pouchdb-react-native module (if so
a) which way?
b) is AsyncStorage 6 MB limit already fixed there?)
or
the only way to attach additional plugins it is to proceed with pochdb-core + pouchdb-adapter-asyncstorage?

BTW, it isn't clear from docs which file (I assume in android folder, right?) and which particular part of that file should be modified to fix 6MB limit. Some tiny clarification could be really helpful.
And let me thank you author for the great job on this module, awesome.

'use strict'
import PouchDB from 'pouchdb-react-native‘
PouchDB
.plugin(YourPlugIn)
export default PouchDB

The android fix, is not applied automatically

Thank you. I've attached authentication plugin - it works as expected.
Any clue regarding exact file to apply android fix in, then?

https://codedaily.io/tutorials/4/Increase-Android-AsyncStorage-Size-in-React-Native

Thank you!


Add link to OpenWhisk gh project

:)

Thanks for the PR! And thanks for inadvertently finding a bug in our Travis test logic that causes PR test runs to fail prematurely. That should now be fixed as well.


Move Solid Apps

[ ]  Agree that the target location is the Forum (tentatively discussed need official confirmation) – Action item done by: by May 7, 2021

[ ]  What notice needs to be given – Decided no later than the end of Solid Team Meeting May 12, 2021

[ ]  Notice to the community

[ ] Get approval from the Solid Team

[ ] Actually write and post a note to the community – Determined during the Solid Team Meeting

[ ] Do the transfer of the applications

If this refers to applications that were once in the github.com/solid organization, then this task is complete. Closing for now.


Configuring Conan (or individual) Cataloger Globs

What would you like to be added:
configuring individual catalogers with globs. specifically conan is where this issue came up for building and managing different platforms.
in config we could have.
conan-cataloger:
    globs: ["conan-*.lock"]

Why is this needed:
this is needed because with conan for example there are windows 64, linux 64, and additional possible profiles with windows 64 with varying vs code versions (2013,2015,2017, etc.) so when conan.lock is generated the file will be renamed to be conan-win64.lock or conan-linux64.lock etc.
Additional context:
Current conan cataloger only looks for conan.lock and so with different lock file names for different conan profiles arent being discovered because their filenames have deviated . So adding a glob or convention specific to a project would be necessary to find all the lock files for each profile.

Hi @fi0rini, thanks for the suggestion.  We need to do some more investigation and research around the implications of detaching the set of globs from Syft itself.
For this particular problem with Conan, would it make sense for us to add the -win64.lock, -linux64.lock, etc, to the cataloger itself?

Notes for @anchore/tools: We'll add this to the backlog and do some investigation into Conan's lockfiles and see if we can broaden our matching here.


[PSA] counter size S

For counters that have a number of counters that is an exact power of
2, e.g. 1024, a single type S that is bit<10> is just right for the
'index' parameter to 'count', but it is 1 bit too small for the
'n_counters' parameter of the constructor.  Might be good to have a
separate type for the 'n_counters' paremeter?

Latest PSA draft as of today has changes that address this comment, by always using bit<32> type for n_counters.


Add icon to Post Action Menu component

This is a dupe.  There is currently a non-optimal icon as a placeholder being used.


Cannot restart kernel after kernel dies

Environment data

VS Code version: Version: 1.59.0
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z (1 wk ago)
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 20.6.0

Jupyter Extension version (available under the Extensions sidebar): v2021.8.1195043623

Python Extension version (available under the Extensions sidebar): v2021.8.1105858891

OS (Windows | Mac | Linux distro) and version: MacOS 11.5.1

Python and/or Anaconda version: Python 3.9.5 (also tested with 3.9.6, 3.8.10 and 3.7 - same issue)

Type of virtual environment used (N/A | venv | virtualenv | conda | ...): tested with conda and venv

Jupyter server running: The problem happens both locally and in a remote setup (remote VM)

Expected behaviour
I need to restart my kernel after a pip install.
I need to execute the following code and restart my kernel, without loosing connectivity to it.
import IPython
app = IPython.Application.instance()
app.kernel.do_shutdown(True)

Actual behaviour
After executing the app.kernel.do_shutdown(True) I receive the following message:
Error: Session cannot generate requests
Error: Session cannot generate requests
at w.executeCodeCell (/Users/renatoleite/.vscode/extensions/ms-toolsai.jupyter-2021.8.1195043623/out/client/extension.js:90:325139)
at w.execute (/Users/renatoleite/.vscode/extensions/ms-toolsai.jupyter-2021.8.1195043623/out/client/extension.js:90:324460)
at w.start (/Users/renatoleite/.vscode/extensions/ms-toolsai.jupyter-2021.8.1195043623/out/client/extension.js:90:320276)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async t.CellExecutionQueue.executeQueuedCells (/Users/renatoleite/.vscode/extensions/ms-toolsai.jupyter-2021.8.1195043623/out/client/extension.js:90:334803)
at async t.CellExecutionQueue.start (/Users/renatoleite/.vscode/extensions/ms-toolsai.jupyter-2021.8.1195043623/out/client/extension.js:90:334343)

If I restart the kernel using the "Restart" button from the UI interface, I still receive the same message.
I can only get my environment running again if I select another kernel and then select the original kernel again.
Steps to reproduce:

Create an empty notebook and open in VScode (with the extension enabled).
Enable the kernel
On the first cell type a print('Hello World') to make sure it is working
On the second cell execute the following code:

import IPython
app = IPython.Application.instance()
app.kernel.do_shutdown(True)

Include a new cell with a print('Hello world') to see the error message.

Logs
Please see the attached files.
kernel_restart_OK.txt
cell_exec_FAIL.txt
requirements.txt

Follows a quick video to demonstrate this behavior.
https://user-images.githubusercontent.com/277946/129734512-1d72332a-c926-4e21-b79c-ddf3468af401.mov

Thanks for filling this issue, I'm and to relocate this at my end.

Thank you. Let me know if you need more information.

As a temporary work around, you can close the notebook and re-open it, that will work.
I'll have a fix before the end of this week for you in VS Code Insiders (hope you can use VS Code insiders until this goes into stable)?

That's great! Thank you very much,
Cheers

I'm not sure this is the same problem or not. I get this error when some error happens in my code and instead of reporting the stack trace, the cell finishes successfully. But I'm not able to run any cell afterward and get the message included above.

@momt99
Please could you file a separate issue. looks like you have some code in the cell that's causing the kernel to crash/die.

Closing this issue as this has been fixed, and the fix is now avaialble in the insiders version of the extension (install VS Code insiders to get the insider version of the extesnion).

@DonJayamanne
I had stumbled across the error reported here, so I got the latest version to overcome it.
I'm now using code-insiders 1.61.0-insiders with Jupyter v2021.9.1001208778 on Ubuntu 20.04, and the error Kernel is dead occurs.
Any suggestion on the version to use?
Thank you for the great work!

@IvanPalm
Play could you file a new issues with sample code that causes the kernel to crash. This issue addresses restarting the kernel after it has died.

I just got back to the matter to file the issue but I could not replicate the error.
I tested on Code Insiders 1.61.0-insiders with Jupyter v2021.9.1001216636, v2021.9.1001208778 as well as on Code 1.60.0 with Jupyter v2021.8.2041215044. The outcome is the same I got when I landed to this conversation: Error: Session cannot generate requests. I will file a new issue if/when the error occurs on other codes.

I have the same issue.
If I run the code with Jupyter v2021.8.2041215044,when I run this demo(https://tensorflow.google.cn/text/tutorials/transformer?hl=zh_cn),Error: Session cannot generate requests will rise.
So I use an old version Jupyter, and this issue will disappear

@wang-chbo
Part could you file a separate issue, with the os, python version & other information including  the sample code you have mentioned. Oh yes, please do included the logs as well.

I was able to restart a kernel after it had died. Both from the original repro as well as from a separate one that killed the kernel externally.


Creating accounts on WAX incorrectly throws an error about keys needing to be prefixed with WAX

This isn't happening for me - closing until we can find a way to reproduce


Emergency Phone form field

🐞 Bug Report
Something I'm already in the process of fixing. We don't have the emergencyPhone field present in our manifest form.
I also plan on adjusting the handler Form component to be more reusable.

closed with #457


React UI: insufficient significant digits in Y axis labels over small range

What did you do?
In the PromQL React UI, gave a PromQL expression where the Y values are over a small range, then view as a graph.
To replicate: e.g. foo < 0.10 > 0.096 or foo < 0.11 > 0.096
What did you expect to see?
Each Y-axis label should be distinct, with sufficient significant digits to distinguish them.  e.g.

0.096
0.097
0.098
0.099
0.100
0.101

What did you see instead? Under which circumstances?
In the following graph, the data points range from 0.0965 to 0.0999:

I believe the Y axis label positions actually correspond to 0.0960, 0.0965, 0.0970 ... 0.1000, 0.1005, but all are showing as 0.10.
With values from 0.0965 to 0.11:

In this case I believe the Y axis positions correspond to 0.096, 0.098, 0.100, 0.102, ... 0.110, 0.112; but half of them show as 0.10 and half as 0.11
(Real-world use case which triggered this: alerts set at disks having less than 10% free space, then viewing the graph of the alerting expression when the values are only just dipping below and above 10%)
Workaround
Manually add * 100 (or other scale as required) to the expression you are graphing.

Reference
Possibly relates to old issue #3084
Environment

System information:
Linux 4.15.0-153-generic x86_64

Prometheus version:
prometheus, version 2.28.1 (branch: HEAD, revision: b0944590a1c9a6b35dc5a696869f75f422b107a1)
  build user:       root@2915dd495090
  build date:       20210701-15:20:10
  go version:       go1.16.5
  platform:         linux/amd64

Alertmanager version:
n/a

Prometheus configuration file:
n/a

Alertmanager configuration file:
n/a

Logs:
n/a

cc @juliusv

Hello from the bug scrub: is this relevant for the new library for the UI @juliusv ?

Graphing is the major piece still missing in the new UI, so we'll see :)

Yeah, the new UI is using the same tick formatter as before: https://github.com/prometheus/prometheus/blob/52fe4cc4eeeb98ab15086501412f9daf05835d71/web/ui/mantine-ui/src/pages/query/uPlotChartHelpers.ts#L8-L54
If someone wants to change it, just make sure that the Y-axis label space allocator in https://github.com/prometheus/prometheus/blob/52fe4cc4eeeb98ab15086501412f9daf05835d71/web/ui/mantine-ui/src/pages/query/uPlotChartHelpers.ts#L194-L224 works well enough to allocate enough space for longer tick labels. That part is unfortunately quite hacky with uPlot (as are many things with uPlot, unfortunately), copied from a uPlot demo.


Codeunit 444 "Purchase-Post Prepayments" - CheckOpenPrepaymentLines

Describe the request
    procedure CheckOpenPrepaymentLines(PurchHeader: Record "Purchase Header"; DocumentType: Option) Found: Boolean     var         PurchLine: Record "Purchase Line";     begin         with PurchLine do begin             ApplyFilter(PurchHeader, DocumentType, PurchLine);             if Find('-') then                 repeat                     if not Found then                         Found := PrepmtAmount(PurchLine, DocumentType) <> 0;                     if "Prepmt. Amt. Inv." = 0 then begin                         UpdatePrepmtSetupFields();                         Modify();                     end;                 until Next() = 0;         end;         exit(Found);     end;
Additional context
Could you please add the event OnBefore and OnAfter on Codeunit 444 "Purchase-Post Prepayments"
Internal work item: AB#501338

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 16627.


jwt leeway time added

Leeway time added in Authentication Verticle

Can one of the admins verify this patch?


variable++ appears as unused var

Issue Type: Bug
Steps to reproduce:

declare a variable (let a;)
a++;

Expected: a should be colored as used var
Actual: a is highlighted as unused var
VS Code version: Code 1.25.0 (0f080e5267e829de46638128001aeb7ca2d6d50e, 2018-07-05T13:11:58.697Z)
OS version: Windows_NT x64 10.0.17134
Extensions (23)

Extension
Author (truncated)
Version

ng-template
Ang
0.1.9

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.4.12

githistory
don
0.4.1

gitlens
eam
8.5.0

EditorConfig
Edi
0.12.4

tslint
eg2
1.0.33

vscode-npm-script
eg2
0.3.5

prettier-vscode
esb
1.5.0

angular2-switcher
inf
0.1.9

search-node-modules
jas
1.3.0

angular-essentials
joh
0.3.2

Angular2
joh
6.1.1

node-module-intellisense
lei
1.5.0

code-bitbucket-pipelines
luk
0.4.2

debugger-for-chrome
msj
4.8.0

angular2-inline
nat
0.0.17

title
nil
0.1.0

code-spell-checker
str
1.6.10

vscode-status-bar-format-toggle
tom
1.4.0

nodejs-extension-pack
wad
0.1.9

JavaScriptSnippets
xab
1.7.0

(1 theme extensions excluded)

a is considered unused because it could be removed without changing the program's behavior -- its value is never read.


Update env.d.ts

set START_SSR, START_ISLANDS, START_DEV_OVERLAY to boolean to match runtime
those values were set to string in TS but are booleans in runtime.
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?
Other information

Thanks


Potential Improper Lock

Probably not a large issue since it's an internal class, but I thought I'd bring up
https://github.com/RolandPheasant/DynamicData/blob/master/DynamicData/Cache/Internal/ReaderWriter.cs#L86
Looks improper at a glance to be locking this, and doesn't line up with the rest of the class' locking system.  If it's on purpose, sorry about the bother. 8)

You're right.

I have fixed the locking and deployed a patch to Nuget.
Thanks for point the error our.


Updating an array of sub-documents fails validation if the sub-documents are transformed

Not sure if i'm doing it right, I've noticed the following validation issue which i think isn't accurate.
I have a collection called A where each A document contains a property B (a transformed array of objects). I've decided to transform each B object so that i can extend its behaviour.
If i call A.update(id, {$set: {B:modifiedArray}}), validation fails because validation expects modifiedArray to be an array of POJOs and not Transformed Objects.
The only workaround i've found so far is to specify validate: false. But this is really risky behaviour.
Any ideas? Is it a package limitation or can i do something differently?
Thanks

I think the only other solution is to transform them back. Without seeing an example of how exactly they're transformed I'm not sure. But if they don't match the schema, then they don't pass validation.


Add Resnet 50 INT8 to presubmits

This is adding them to tests, not benchmarks?

Thanks Lei! Updated the PR title.


Pin the versions of Github CI runners

Okay, I've made the PR and commits merge-ready, also added pinned version of the macOS runner (relevant Github docs)


Code coverage report

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@071c28a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #14   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         3
  Lines           ?        32
  Branches        ?         0
========================================
  Hits            ?        32
  Misses          ?         0
  Partials        ?         0

Flag
Coverage Δ

pytest
100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


mermaid diagram is missing when export html

when I export from md to html, mermaid created svg but filter didn't copy it to my directory

You can set the cache to your current directory, see configuration.

when i set this in metadata,
diagram:
  cache: true
  cache-dir: ./

It wrote image to my working dir but filename was different with html's content

Ah, I think I understand now: what you want is probably to use pandoc's --extract-media option.

We ran into this also and our issue was that embedding plantuml in our markdown would show up while previewing using quarto preview, but when doing a full ** quarto render ** to html and then PDF the assets would not be included.
The fix was to add the following to the configuration in the markdown file.
----
format:
  html:
    extract-media: ../_book/architecture/markdown-name_files/mediabag
---

I'm glad that we got it figured out, but is this really supposed to be the default behavior for this extension?


Problem with loading resource with changed 'idParam'

Hi,
I have a problem with loading resource after changing 'idParam'. Code samples:

In ContractController:
`
public function __construct()
{
parent::__construct();
        $this->loadAndAuthorizeResource(['class' => 'App\Models\Contract', 'idParam' => 'id_contract']);

}
`

I have only two methods in this controller (index and show) but no need to add to them code for authorization, 'show' method looks that:

`public function show(Contract $contract)
{
Log::info(METHOD);
    $this->data['contract'] = $contract;

	return view('customer.contract.show', $this->data);
}`

My authority-controller:

`$serializer = new SuperClosure\Serializer;
return [
'initialize' => $serializer->serialize(function ($authority) {

    $user = $authority->getCurrentUser();

    foreach ($user->permissions as $perm) {
        if ($perm->type == 'allow') {
            $authority->allow($perm->action, $perm->resource, function ($self, $contract) {
                #just for test purpose
                dd('am i here?');
                if (isset($contract->account)) {
                    return $self->getCurrentUser()->id == $contract->account->id;
                } else {
                    return true;
                }
            });
        } else {
            $authority->deny($perm->action, $perm->resource);
        }
    }
})

];`
As a result, in 'show' method, proper object is not loaded (no object is loaded to be clear). After changing one method in  authority-controller/src/Efficiently/AuthorityController/ControllerResource.php to
 protected function getIdParam() {     return array_key_exists($this->getIdKey(), $this->params) ? print_r($this->params['id'], true) : ""; }
the object is loaded but it's my poor hack, not solving problem... Of course allowing/denying works great, but I wanted to use closure and check loaded object.
I hope I followed your instructions and it's not just my mistake but deeper problem.
Greetings
Bartek

Hi,
I think I found fix for this.

In Parameters.php, lines 48-54 I think the code:

`
if (is_a($id, 'Illuminate\Database\Eloquent\Model')) {
$id = $id->getKey();

}
if (is_string($id) || is_numeric($id)) {
array_pop($routeParams);
$routeParamsParsed['id'] = $id;

}
`
should be replaced with:
`
if (is_a($id, 'Illuminate\Database\Eloquent\Model')) {
$object = $id;
$id = $id->getKey();
}
if (is_string($id) || is_numeric($id)) {
array_pop($routeParams);
$routeParamsParsed[$object->getKeyName()] = $id;

}
`
That works like charm for me, please let me know if you can change it in your package (is it acceptable and useful change) or is it my misunderstanding of your work.
Greetings
Bartek Maciejewski


Adding MoA module into AgentScope

Description
The project MoA leverages the collective strengths of multiple LLMs to enhance performance, achieving state-of-the-art results.
In this PR, we implement the MoA method and integrates it into AgentScope.
This module could enable us to enhance output quality by using multiple models.
The limitation here is the extra steps will result in a high Time to First Token latency and lots of extra token usage. So be careful.
Checklist
Please check the following items before code is ready to be reviewed.

[x]  Code has passed all tests
[x]  Docstrings have been added/updated in Google Style
[x]  Documentation has been updated
[x]  Code is ready for review

please update the example list in README.md and README_zh.md

Done


Import tensorflow, only when its model is used (and save several hund…

# before
resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
44_322_816
>>> lib = modelkit.ModelLibrary(models=clkit.models, required_models=[])
>>> resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
455_536_640

# after
>>> resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
44_261_376
>>> lib = modelkit.ModelLibrary(models=clkit.models, required_models=[])
>>> resource.getrusage(resource.RUSAGE_SELF).ru_maxrss
157_827_072

Let's open an issue to discuss this improvement and eventually to re-open it :)


Late Stage Reprojection over streaming?

Hi,
I noticed that Planar LSR over streaming is marked as not yet supported in OpenXR 4.26.
After doing a little more research, I see that the HL2 has Depth LSR and Planar LSR (late stage reprojection). I am assuming that Depth LSR is not available over streaming, as only video frames are being sent to the device from the streaming PC.
Is there a timeline for when Planar LSR in streaming will be supported? I seem to be noticing more jittering in holograms with the OpenXR plugin compared to the Windows Mixed Reality plugin.

Hi @xuelongmu, our engineers say they're seeing some jitter as well and will investigate. The OpenXR remoting runtime actually does support depth LSR, so we suspect that the jitter probably isn't LSR-related.

Thanks @sw5813! Looking forward to any updates on this.

I have the same issue also, Windows mixed reality streaming on HL2 is rock solid, open xr on the other hand jitters like crazy.

@shukenmg- are you also using Unreal 4.26? Or are you using the 4.27 preview?

I am using both 4.26 and 4.27 preview 2 & 3
Using the WMR plugin in 4.26 and 4.27 to remote to the HL2 results in
really solid projection with minimal jitter/drift
The WMR plugin in 4.27 preview 3, on the other hand, is very jittery and
drifty.
As for the MS Open XR plugin (this plugin), I experience really bad
jitter/drift on all the above versions, 4.26 and 4.27 Preview 2 & 3.
On Tue, Aug 3, 2021, 23:46 Summer Wu @.***> wrote:

@shukenmg- are you also using Unreal 4.26? Or are you using the 4.27
preview?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/Microsoft-OpenXR-Unreal/issues/19#issuecomment-891956612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEJKSTMWTMD2Y2Z2O6HSJ4DT3AFNDANCNFSM45YQQWSA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Quick update:
The WMR plugin in 4.27 Preview 4 is once again rock steady with minimal drift/jitter.
MS OpenXR (This plugin) is better but still has more jitter/drift than the WMR plugin.

Thanks for the update @shukenmg! Our engineers say this is expected in OpenXR right now because of the stereo layers Epic added in 4.27. We're hoping to get a fix for this from the remoting team in the next two weeks, after which, we will update this plugin. So please keep an eye out for the next release of the Microsoft OpenXR plugin.

@sw5813 Thanks for the updates on this. Would you expect HL2 with OpenXR to be jittery in 4.26 as well? Or is it just a regression in 4.27? Appreciate your help!

Thanks for the update @shukenmg! Our engineers say this is expected in OpenXR right now because of the stereo layers Epic added in 4.27. We're hoping to get a fix for this from the remoting team in the next two weeks, after which, we will update this plugin. So please keep an eye out for the next release of the Microsoft OpenXR plugin.

Ok, thanks for the update!

Fixed in the latest release:
https://github.com/microsoft/Microsoft-OpenXR-Unreal/releases/tag/1.1.5
Marketplace is currently updating

Still getting unstable results with the latest everything.

Fixed in the latest release: https://github.com/microsoft/Microsoft-OpenXR-Unreal/releases/tag/1.1.5
Marketplace is currently updating

This fix works, but I am now experiencing this issue #27


how to parse DictationGrammar for file. like parse_grammar_file(path)

how to parse DictationGrammar for file.
like parse_grammar_file(path)
and how to write Dictation in grammar file?

This is not currently possible because DictationGrammar is an extension to JSGF. Its compiled output changes based on the last matching rule. I will try to come up with a solution for parsing and writing them.


eth and erc20 token withdraw no working

Hello
I have the problem of Ethereum and ERC20 token withdraw parts.
It can't withdraw to select address and all coins move to Hot wallet.
So the coins is "Frozen" state.
How to solve this problem?

Hi @AkashiHidaka,
Sorry, your query is not clear, can you make a video/photo record and put more details?

Yes , I will add print screen image.

I added frontend and backend panel print screen image.
If you want , I can provide credentials and you can check of it.

Ah, it is pending state. Yeah, there was an issue in 1.9 with this.

So it is need update peatio codes to 1-9-stable version?
other part no need update?

Now I using workbench and in there peatio module will change?

I guess updating to 1-9-stable will not solve your problem, because this withdraw was already created with broken version. Let's wait for @mnaichuk comment

I hope quickly solve this problem.
I will wait.
Thanks

Hi @AkashiHidaka
Please check withdraw_coin daemon logs it can be some errors there. And this bug can be related to blockchain. You can reject this withdraw and increase gas_limit/price in currency configs and try again.

How to check the logs data?

docker logs

I can't see of log

docker ps, then find container id for withdraw_coin daemon (first row) and then check logs for this container id

I see this is and it is right?

Please update peatio to 1-9-stable, reject this withdraw and try again.

Yes

Hello
I updated 1-9-stable version and still no working of withdraw part.
I checked log data and it show mysql query and some texts.
In there other things is same and I will attach the withdraw relation part log data.

What is the reason of it?
I updated peatio to 1-9-stable version.


Add license file

I know this is specified in package.json, but having the complete license here would be great!

@sairion mind merging this one too?


feat: Make Calendar::property_value() publicly accessible

There does not seem to be a good reason for making the Calendar::property_value() method private: the accessed property array is public anyway and it is nothing more than a helper. What's more, calendar components have exactly a method of this name (fulfilling a similar purpose) publicly available.
Declare it as public to make it accessible to users, instead of forcing them to copy and paste it.

oh thanks, that seems to have been an oversight.


Hand using Handheld Vive trackers

Hi @zite
I was wondering if you could explain to me how I could use the SteamVR player prefab and have the hands working but using trackers instead of the controllers. I have my trackers set to handheld right hand and handheld left hand, so they do get linked to the LefHand and RightHand game objects but, the Hand script doesn't instantiate the hand models with the poses.
What I am trying to do is to be able to see the hands and then make them blend poses when hovering over objects. I have a custom made controller that also uses trackers but I want players to be able to see their hands as they need to be able to see where to hold the objects with both hands. I would set it up with two holding positions.
I imagine that if it was possible to use trackers as hands and we could blend the grab position on some objects it can be useful on virtual objects that could be moved but don't need to be picked up, like twisting doorknobs to open a door, pushing buttons or pulling levers. The hand would blend to a grab pose and the object would snap to the hand while the hand is inside a trigger, and then when you move the hand out of the trigger the hand would let go of the object and blend back to an idle pose.
Thanks

The Interaction System is really meant to work with the underlying SteamVR Skeleton system which estimates finger positions based on button presses. So this isn't really a supported scenario.
But if you like you could go into Assets/SteamVR/InteractionSystem/Core/Scripts/RenderModel.cs and delete line 68. After that you may need to remove some active and activeBinding checks elsewhere to get the hand to display without the underlying data. Good luck!

No worries, thanks for the clarification :)
On Tue, Feb 19, 2019 at 2:41 PM Keith Bradner<EMAIL_ADDRESS>wrote:

The Interaction System is really meant to work with the underlying SteamVR
Skeleton system which estimates finger positions based on button presses.
So this isn't really a supported scenario.
But if you like you could go into
Assets/SteamVR/InteractionSystem/Core/Scripts/RenderModel.cs and delete
line 68. After that you may need to remove some active and activeBinding
checks elsewhere to get the hand to display without the underlying data.
Good luck!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ValveSoftware/steamvr_unity_plugin/issues/322#issuecomment-464980231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMIhAQ94j9gEc4Ebz_4XzHvPSw9b-d_Oks5vO4CFgaJpZM4a7IL-
.


STORM-2326 Upgrade log4j and slf4j for branch 1.0.x

Compiled and packaged with
mvn clean install -DskipTests=true
cd storm-dist/binary && mvn package

Works fine in both local and deployed mode.

+1 given that you've tested it manually.

+1


Testautomation limitation in AL Langauage

Hi ,
I have a doubt that although i am able to run test automation from windows client why because when i tried to run from webclient then the session is closing, Is there any limitation to AL test automation that we should only use the windows client ?
Please suggest ASAP

I received a reply from the owning team:
Currently we don't support the web DT in the Test A/L language. This is an unfortunate limitation that we need to address in the future releases.

First, check whether the normal web client (create a sales invoice) is working or not.
If it works and still test tool does not work, then there is some problem with the code in the test codeunit.


express passport postgraphql implementation

I was wondering if there is any way implementing passport for postgraphql?

Sure:
[...]
app.use(passport.initialize());
app.use(passport.session());
[...]
app.get('/auth/facebook', passport.authenticate...)
app.get('/auth/facebook/callback', passport.authenticate...)
[...]
app.use(postgraphile(process.env.DATABASE_URL, "app_public", {
  pgSettings: req => ({
    role: 'app_visitor',
    ...(req.user && req.user.id
      ? { "jwt.claims.user_id": String(req.user.id) }
      : null),
  })
}));

[semi-automated message] To keep things manageable I'm going to close this issue as I think it's solved; but if not or you require further help please re-open it.

How would I go about choosing a specific role depending on the user id?

You could do that in the pgSettings function; it has access to the request and is async so it can query the DB, look at the headers/session/etc. e.g.
https://github.com/graphile/starter/blob/6c68770dff0a60cf83822f8a701ecd82b2c44f6e/%40app/server/src/middleware/installPostGraphile.ts#L202

Ah perfect. Thank you for your fast answer. This is very helpful.


Fixed example in readme.md

There are some errors in json example. I fixed them and added some helpful information

Hi there, thanks for your PR I'll give that a merge :)


Possible core bug with payload size due to infinite Error stack trace limit results in 413 err

Hi @benvinegar - I'm wondering if this is an issue with raven or something on my end.
I'm using the standard default Express setup with raven's requestHandler middleware, but for some reason I constantly get<EMAIL_ADDRESS>alert: failed to send exception to sentry: HTTP Error (413): undefined errors.  This is a 413 is Payload Too Large error.
Related to #339 and #58.  Since we set Error.stackTraceLimit = Infinity; at https://github.com/getsentry/raven-node/blob/514159d8b2bf173ed70beafba786a1087c7ceaa5/index.js#L9-L10 does this cause this issue?

@benvinegar just updated the title/message here, sorry for confusion if any, was from a copy paste I was working on

Error.stackTraceLimit = Infinity

Yeah, I don't see that we limit the stack trace elsewhere, so this may be the cause. I know that we have a limit of, say, 50 frames in Raven.js.

Wait, this is raven-python. Did you intend to open on this project?

@benhodgson see https://github.com/getsentry/raven-js/issues/1004


Description of the crash

Description of the crash:
I was just watching the end credits of the game with all mask collected and the game crash on the Deku king scene.
Can you reproduce? If so please list the steps:

[ ] No, I cannot reproduce this crash
[ Y ] Yes, here are the steps to reproduce the crash:

Logs:
2 Ship 2 Harkinian.log
System Information:

OS: Windows 10 pro
GFX Backend: OpenGL
Game Version:<IP_ADDRESS>
Rom Version: any

Hi, this issue was already fixed by #601 and available in the 1.0.1 Rika Bravo release.


Remove extra quote from OS.execute()

I'm not sure why this quote was added (possibly for executables with spaces in them?) but i'v had issue with it so far. For example OS.execute("CMD.exe", ["/C", "cd %TEMP% && dir"], true, output) (taken from the docs) is parsed in cmd as "cd %temp% && dir" with the quotes which makes cmd think that the whole command is a string.
Looks like it was addded at 9e465c9. So @SubSage could elaborate.

See https://github.com/godotengine/godot/pull/26462#discussion_r288068091, without this end quote you'd end up with (spaces added for clarity):
"  "CMD.exe" "/C" "cd %TEMP% && dir"

which is invalid as the first quote is never closed.
Now it should be:
"  "CMD.exe" "/C" "cd %TEMP% && dir"  "

which should be fine a priori.
What exact issue does cmd.exe give you?

For the reference, the enclosing quotes for the full command are necessary, otherwise _wpopen chokes on it. Here's what happens if I remove both the first quote, and the last one as in this PR:
Can't recognize 'CMD.exe" "/C" "cd C:\users\akien\Temp ' as an internal or external command, or batch script.

You can see that it parses "CMD.exe" "/C" "cd C:\users\akien\Temp && dir" as this string: CMD.exe" "/C" "cd C:\users\akien\Temp && dir, and thus CMD.exe" "/C" "cd C:\users\akien\Temp is invalid but && dir works.

OS.execute("CMD.exe", ["/C", "cd %TEMP% && dir"], true, output, true) for example is giving me [The filename, directory name, or volume label syntax is incorrect.]. After monitoring the process it seems to be trying to run: C:\WINDOWS\system32\cmd.exe /c ""CMD.exe" "/c" "cd %TEMP% && dir" 2>&1"

For the reference, the enclosing quotes for the full command are necessary, otherwise _wpopen chokes on it. Here's what happens if I remove both the first quote, and the last one as in this PR:
Can't recognize 'CMD.exe" "/C" "cd C:\users\akien\Temp ' as an internal or external command, or batch script.

You can see that it parses "CMD.exe" "/C" "cd C:\users\akien\Temp && dir" as this string: CMD.exe" "/C" "cd C:\users\akien\Temp && dir, and thus CMD.exe" "/C" "cd C:\users\akien\Temp is invalid but && dir works.

For me, after removing argss = "\"" + p_path + "\""; just the first quote and argss += "\""; seems to do the trick. Now the result is the contents of %temp% folder

Seems like Windows and WINE use different shell expension, but your PR will trigger what I commented in https://github.com/godotengine/godot/pull/33200#issuecomment-548337273 on WINE.

Seems like Windows and WINE use different shell expension, but your PR will trigger what I commented in #33200 (comment) on WINE.

In your example, you have removed both quotes from p_path. In my PR i just removed the quote that encloses the whole stirng and the one that closes it.
Can't recognize 'CMD.exe" "/C" "cd C:\users\akien\Temp ' as an internal or external command, or batch script. This can't be correct with my PR since argss = "\"" + p_path + "\""; this should enclose CMD.exe with quotes and argss += " \"" + E->get() + "\""; should enclose cd C:\users\akien\Temp with quotes. In your example you are missing these.

In your example, you have removed both quotes from p_path. In my PR i just removed the quote that encloses the whole stirng and the one that closes it.

I did not, what I tried is exactly the current state of your PR. It's cmd.exe which removes the first and last quotes.

In your example, you have removed both quotes from p_path. In my PR i just removed the quote that encloses the whole stirng and the one that closes it.

I did not, what I tried is exactly the current state of your PR. It's cmd.exe which removes the first and last quotes.

I see. So then maybe the way shell works changed in later version of windows? I recall this seemed to work. I'm not sure how to procced at this point :/

Also, there are commands that do not work because p_arguments is being enclosed with quotes. start which is used to start applications, for example, is not working. Gives an error '"start"' is not recognized as an internal or external command, operable program or batch file.
which makes sense, if you run "start" from a cmd window it gives you the same error.

@akien-mga , have in mind that even just by removing the last quote it works for me. Maybe by doing that it ignores the first one? Anyway, please check if having just the first quote works for wine (thats how it used to be).

Same issue removing only the end quote:
Can't recognize 'CMD.exe" "/C" "cd C:\users\akien\Temp ' as an internal or external command, or batch script.

and then dir runs in the current directory.

@akien-mga , Sorry i might be completely wrong but in the many years i'v been working with windows i never ever had to add quotes on parameters unless it was a file path (but even the little i have used Linux i never had to use quotes there also?). I'm not sure why arguments are being enclosed with quotes in this case and more importantly, why are they hardcoded into the engine. If someone needs to add quotes to arguments for any reason, they can just add them in their code. I have pushed a commit with all quotes removed from the engine code and changed my GDScript from:
OS.execute("CMD.exe", ["/c", "cd %TEMP% && dir"], true, output, true)
to
OS.execute("CMD.exe", ["/c", '"cd %TEMP% && dir"'], true, output, true)
This might be a breaking change for some, but adding that last quote was a breaking change for me also.

With that last commit, someone can run 'start "" "someprogram.exe"' for example, while before you could not and there was not way around besides touching the source code,

If this works for you and you are willing to merge then i will also change the docs (which BTW do not mention the important part that quotes are being added internally). Sorry, i'm frustrated at this point, i always assume there's a reason things have been coded that way and spend too much time just working around them.

Thank you for the help @akien-mga . Although possibly unrelated, for future reference i ended up using C# Process class to open the process and get the output. I'm not sure if this pull request actually fixes an issue or it was just my misunderstanding so I'm closing it.


Refine examples of Specification > Plans > discover > fmf

Fixes: #2179

The patch is tested via make docs. And the result looks good. Here is a screenshot, @ZelenyMartin, @lukaszachy, @happz, please help to review, thanks!

https://tmt--2182.org.readthedocs.build/en/2182/spec/plans.html#fmf

So for the next time it's not necessary to add screenshots.

Thanks for letting me know this, which is pretty helpful to enhance docs! @psss


encode a URL containing an F-TDS expression: if the string expr{}

Reported by ansley b manke on 2 Nov 2009 21:09 UTC
Server-side computations:
If the URL string contains expr{}which is assumed to be followed by {ferret_commands}, encode the Ferret commands, starting with {} and ending with }
URL is
"http://" + baseURL + "expr" + FerretCommands + "?" + dodsConstraints
Will encode the FerretCommands, glue it back onto the URL up to expr and open that in Ferret.
For now we'll just not do anything with a DODS constraint but it will be easy to add encoding of that if we want to.
In addition, F-TDS stores the variable definition in an attribute called .ferret_definition.  I propose that when getting the attributes of a variable, Ferret check first to see if it has a long_name attribute, and if not, see if it has a ferret_definition and use that for the variable title.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1709

Comment by ansley.b.manke on 2 Nov 2009 21:13 UTC
Adding cc to Roland.

Comment by ansley.b.manke on 2 Nov 2009 21:57 UTC
NOTE:
Encoding /  causes the URL to fail to open, but  leaving it as a / works fine. In the hand-made scheme, entering a variable TITLE
{let/title=NewVar top=T0112AN1[z=0:100@ave]}
encodes with the / intact.

Comment by ansley.b.manke on 2 Nov 2009 22:16 UTC
NOTE:
Trying to do two Ferret commands separated by a semicolon fails.
  {let top=T0112AN1[set var/name=upper100 top}

or

  {let top=T0112AN1[z=0:100@ave](z=0:100@ave];); let bot = T0112AN1[z=500:1500@ave]}

Putting the commands into the Browser as in the hand-made example, these result in an error:
Error in URL
The URL extension did not match any that are known by this server.

Comment by Roland.Schweitzer on 16 Nov 2009 15:20 UTC
Tomcat eats semi-colons and treats them as the end of the URL.  I dug around and found no satisfactory way around this problem.  You can use cr to separate lines in a Ferret expression.
http://ferret.pmel.noaa.gov/thredds/dodsC/NVODS/woa05_monthly/data_ferret.pmel.noaa.gov_thredds_dodsC_data_PMEL_WOA05nc_monthly_t0112an1.nc.jnl_expr_{}{let top=T0112AN1[z=0:100@ave]_cr_let bot =<EMAIL_ADDRESS>I encoded the blanks in this text so the URL work in Trac.  :-)

Comment by ansley.b.manke on 28 Feb 2013 23:07 UTC
Done as part of the first stage of LET/REMOTE additions to Ferret. Found some existing C code for doing the encoding.

Attachment from ansley.b.manke on 2 Nov 2009 21:12 UTC
Here is Rolands email describing constructing the encoded URL by hand using a browser and a Ferret session
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_1709_GIT_981/hand-made-ftds.txt


Error message in FormatError needs to be improved

Tried to convert a string to time:Utc and got the following error:
error {ballerina/time:2}FormatError ("Provided '2022-12-04T17:56:00+0500' is not adhere to the expected format '2007-12-03T10:15:30.00Z'")

The error message is misleading + needs to be refined. Misleading because it gives a sample timestamp as the expected format when it really should be mentioning the exact format the function expects. i.e., mention that a string in the RFC 3339 format is expected.
From a perspective of how the message is phrased, maybe something like the following would be better:
Expected a value conforming to the RFC 3339 format, but found '2022-12-04T17:56:00+0500'

or
'2022-12-04T17:56:00+0500' is not in the RFC 3339 format

As we use the RFC 3339 UTC format, it might mislead the user if only the RFC 3339 format is mentioned. Thus, we changed the error message to Provided '2022-12-04T17:56:00+0500' is not adhere to the expected RFC 3339 format '2007-12-03T10:15:30.00Z' in 453

Didn't get that. What do you mean by RFC 3339 UTC format? :thinking: And still need to fix how the message is phrased (grammar issues).

By RFC 3339 UTC format what I meant was the time expressed with 0 zone offset. For example, even though 2020-12-31T21:07:14-05:00 is in RFC 3339 format, we only accept the one defined in UTC/Zulu/GMT time which is 2021-01-01T02:07:14Z. Let us check the error message again.


Support scala 2.13.0

Applying this PR will:

update to latest scala versions and dependencies
fix almost all deprecation and other warnings
add support for scala 2.13.0

ping @jrudolph

Thanks a lot @Philippus and sorry for keeping it along for so long. Seems I missed it while on vacation and never got down to it.
I had a branch lying around already that I merged (very similar to yours). The extra language feature imports are still useful.


Add spaces to show-invisibles

The show invisibles shows tabs and line endings. Is it possible to add support for displaying spaces as well? Was there a technical reason for not including them? Otherwise, I'd be interested in adding support, if this is something the project would accept.

The show invisibles shows tabs and line endings. Is it possible to add support for displaying spaces as well? Was there a technical reason for not including them?

I am not the author of that plugin, so I can only guess. The only reason I can think of is performance, but we can easily test that.

Otherwise, I'd be interested in adding support, if this is something the project would accept.

If you implement this, we would surely accept it.

@mAAdhaTTah I've already implemented it #876. The main problem was, that a naive implementation would make the space character twice as wide, which looks weird. I solved this by a few simple css position attributes. It would be nice if you could test it. I personally don't use the show-invisibles plugin and don't know what people expect of it.

Will test it this evening. Thanks!

Implemented in #876. I'm closing this issue.


XPRESS interface: SetSolverSpecificParameters can only be called once

What version of OR-Tools and what language are you using?
Version: v9.2 RTE1.1
Language:  Python
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
XPRESS
What operating system (Linux, Windows, ...) and version?
Windows
What did you do?
Steps to reproduce the behavior:
Called solver.SetSpecificSolverParameters multiple times with different control parameters:
solver.SetSolverSpecificParameters("param1 value1 param2 value2")
solver.SetSolverSpecificParameters("param3 value3 param4 value4 param5 value5")
What did you expect to see
All 5 parameters should have been set, that is actually what is logged by OR-Tools
What did you see instead?
In the XPRESS logs, only parameters of last call (ie params 3, 4 & 5) seem to have been set

@pet-mit I could reproduce the bug. I confirm that by default, Reset is called at Solve. More precisely, this is what happens currently

Some parameters are set using SetSolverSpecificParametersAsString
In Solve, Reset is called, erasing the model and its parameters
SetSolverSpecificParametersAsString is called on the new model, but only with the last parameter provided

I confirm that #46 fixes this issue.

After somme digging, I saw that the default implementation in linear_solver.cc is the following:
bool MPSolver::SetSolverSpecificParametersAsString(
    const std::string& parameters) {
  solver_specific_parameter_string_ = parameters;
  return interface_->SetSolverSpecificParametersAsString(parameters);
}

I guess that the "default" expected behaviour is to clear out the old parameters on every new call.
So this is not really a bug, I'm okay with working around it.
I'm closing the issue.


没有适配小白条下边黑边丑

Thanks for the feedback. This request will be implemented in the next version, SubTune 1.3.1.


Revert "Put datadog-rum back with silm version

We've decided not to have Datadog related logic in Widget. So removing all related code.

byebye 🐶


Full folder paths are leaked in metadata if finetune style is used

Reported on 4chan, an anon said their full folder names from their dataset were leaked when using finetune style. They should be normalized to dreambooth style by stripping the path prefix instead.
More details:

I believe it's take the whole key. Normally this would be fine for most users cause they keep their entire data set in one folder so the key just has to be the file name but I hacked the finetune version of the trainer to work similar to dreambooth in that it will read the folder path for repeats.I use finetune because it is capable of using existing latents that I cache to the list and since I training the same dataset multiple times I rather not recalculate latents. This requires me to put the full path of the image as the key since the data loader uses that to find the image location.
The hash method takes into account of the ss_ metadata so my hash is wrong now but the lora file still work.

Okay, maybe it's worth testing just to make sure
And maybe adding regression tests to make double sure, sd-scripts is gaining importance after all

Okay then I guess this can be closed for now


here seems error

const graph = createGraph('./example/entry.js');

To clarify on this issue :
The source is :
src/minipack.js,
line 246 :
const graph = createGraph('./example/entry.js');
should be
const graph = createGraph('../example/entry.js');
cheers

Eactly!


[Bug] Did not receive Forget password link on mail — asking to configure email service

Description - Email is not received and "Configure email service" message is shown on Reset password screen.
Imp : If user signup from google account and then try to login using email/password -- This flow is not possible due to this issue.
Steps to reproduce the behaviour:

Go to Login page and click "Forgot Password"
Navigate to "Reset password" page
Observe "You haven’t setup any email service yet. Please configure your email service to receive a reset link
Configure Email service" is displayed.
Enter the email and click on Reset button
Observe success message is displayed but email is not received.

Environment : Release

@sharat87 This is a configuration related issue. Seems the APPSMITH_MAIL_ENABLED field value is not properly set.

This is because of missing SMTP configuration on the release environment back in May (when the issue was created). We still don't have real-world SMTP configuration on this environment, but we do have a dev configuration. This message doesn't appear today, and the forgot password email does show up in the dev configuration.
Closing as can't reproduce.

Even i have issue with sending email..
Hello,
I have installed a self-hosted appsmith on ubuntu 20.04 Docket compose.
Installation is don't well. Email SMTP configuration done successfully, also getting test mail.
But now i am facing problems that:

not getting password reset links
when register new member than welcome email not recieved.

I have the same problem as  @patelbhavinoutlook .
I click on "reset" password and I don't receive the email.
On the administration screen, the test email works normally.
In the logs I correctly capture the test email, but no log appears when I click on recover password.

Hey @patelbhavinoutlook @hubjsant, sorry you're facing trouble here. Can you share the backend logs from when you're trying to send test email and when doing forgot-password please?
Please not that forgot password functionality will respond success, but won't send an email, if the given email doesn't have an account. So if forgot-password isn't sending an email, consider trying signup instead.


Parse docker auths and use only hostname

Fix: #124
Fix: #131
Signed-off-by: Somtochi Onyekwere<EMAIL_ADDRESS>

Thanks for the follow-up, @SomtochiAma 💯


Wrap user-facing strings for internalization

Description
Updates user-facing strings in the Search Relevance plugin to be consistent with OpenSearch Dashboards guidelines. Strings are now wrapped and compatible with the default message extraction tool.
Issues Resolved
Closes #330
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I have only updated user-facing strings in flyout.tsx as of now. If the format of the FormattedMessage components (specifically the names for the id attribute) is satisfactory, I can proceed with the rest of the files.

Looks good so far! Could we see if we can wrap the entire string in FormattedMessage as per my comment? May be a little more readable. String IDs look good too, @joshuarrrr could you verify if this is a good starting place for wrapping in FormattedMessage?
Thanks for picking this up, this is great!


[updater] the config endpoints was not replaced by target, arch and version

            // replace {{current_version}}, {{target}} and {{arch}} in the provided URL
            // this is useful if we need to query example
            // https://releases.myapp.com/update/{{target}}/{{arch}}/{{current_version}}
            // will be translated into ->
            // https://releases.myapp.com/update/darwin/aarch64/1.0.0
            // The main objective is if the update URL is defined via the Cargo.toml
            // the URL will be generated dynamically
            let url: Url = url
                .to_string()
                .replace("{{current_version}}", &self.current_version.to_string())
                .replace("{{target}}", &self.target)
                .replace("{{arch}}", self.arch)
                .parse()?;

in the updater.rs
the url format {{current_version}} as %7B%7Bcurrent_version%7D%7D, replacement is failed

Yes, I meet the same issue


add mysql requirement for user group adding in vagrant manifest

Is it not already added?
https://github.com/ongr-io/ongr-sandbox/blob/master/vagrant/manifests/default.pp#L27

No, it should look like:
user { "vagrant_user":
    name       => vagrant,
    ensure     => present,
    groups     => ["www-data", "mysql"],
    require     => Class['::mysql::server']
}

I do not understand why vagrant user needs mysql group?

it is required for tests and mysql binlog


Add multi-stage build in Dockerfile

Transfer Maven build into dockerfile with multi-stage build in deployment with Docker.

This is very nice, but I think I have to revert it for now, as the current Docker version in Ubuntu doesn't support these multi-stage buids yet... :(

I just manually updated Docker to the latest version, and this is now working nicely! :)

@tkuhn sorry for the delayed response. The multi-stage build feature removes the dependencies necessary for compiling the server and keeps it in Docker environment. This is a nice feature in production servers. Happy that is working nicely!


updated code

Added a test case if answer doesn't exists

pull request merged, now close the issue :)
follow for more


Extremely slow performance on mounted volumes

I followed the readme instructions and created a PV and PVC. The volume seems to be mouting but not before at least one timeout event.
Once everything is up and running, trying to list the contents of the data directory takes a very long time (in minutes) eventually returning 0 items though I have 1 non-empty blob in my container.
Also, echo "foo" > test.txt in the data directory results in an I/O error after several minutes.
I verified the logs on the node for errors but did not find any. Both the container and the cluster are in the same region and the cache directory is on a ramdisk.
Any ideas/thoughts on what might be going wrong here or any tips on what I could do to investigate this further?

hi @rahulbreddy do you have chance to repro this issue? To narrow down the issue, you could use blobfuse command directly on that agent VM, e.g.
/usr/bin/blobfuse /mntpoint --container-name=nginx --tmp-path=/tmp/blobfuse -o allow_other --file-cache-timeout-in-seconds=120

And then check whethter there is timeout.
Pls make sure your VM and storage account are in the same region.

Hi @andyzhangx I did not get a chance to investigate this further. Given the future direction we were heading towards, it made more sense for us to use the blob SDK/APIs. We can close this issue for now. I will reopen the issue if I get a chance to try this again in the future.


Improve parse error message on incorrect template slot

For a policy permit(principal == ?resource, action, resource) the parse error message is expected a entity uid or template slot, found a ??resource statement. First, it's printing ??resource instead of ?resource (easy fix) and second it's confusing that it expects a templates slot even though it found ?resource. It should clarify that is specifically expects ?principal.

I found the ParseError is happening but the context is lost on me. I see the ? being inserted but can I simply remove that there without breaking other uses? Then I'm not sure how to clarify as described. Maybe this is a little complicated for a first issue.

The parser and following CST to AST conversion is a little convoluted, so perhaps not a first issue.
For the ?, I'm confident that's just a matter of deleting the extra ?.
For the rest of the error text improvement, it will come down to tracking down where the value of T::err_str() is coming from. It looks like there's some type level shenanigans happening there.

@john-h-kastner-aws I believe it is here.

By taking var to string here we can see the mismatch, how to communicate that exactly I'm not sure though.

Resolved by #411


BEWARE: Plugin name clashes!

Adding this plugin to your project by running cordova plugin add cordova-plugin-browsertab might actually install another plugin by the same name: https://github.com/google/cordova-plugin-browsertab
At least it did for me anyway. While not forked from the other project, this one has an almost identical API causing several hours of baffling errors.
To ensure you get this plugin you should add the following to your Cordova config.xml
<plugin name="cordova-plugin-browsertab" spec="https://github.com/Qbix/cordova-plugin-browsertab#master" />

😂 Still a PEBKAC...


Change to prebuilt httpbox

Chatterino now uses a release of a fork of httpbox, so this is no longer needed.


The uncanny Firebase scalability is not working!

Am I doing something wrong?

Here it's fine, it's really scalable.

If you run
``
You'll see it deploy to multiple regions


[$69] Integrate Million.js automatic mode into cal.com

Describe the feature
Get auto mode working in https://github.com/calcom/cal.com
Additional information

[X] Would you be willing to help implement this feature?

/bounty $69

69 -- nice

/attempt #535

@aidenybai i was able to run it for cal.com. how can we validate further ?

@aidenybai Let me try this issue
/attempt
/assign

@yashug
You'd wanna do a build of the repo?

As @yashug has aborted the attempt, I'd love to get to this.
@aidenybai How do you consider this resolved? A PR to cal.com github repo, or attaching a zip here?

As @yashug has aborted the attempt, I'd love to get to this. /attempt #535
@aidenybai How do you consider this resolved? A PR to cal.com github repo, or attaching a zip here?

Options

        Cancel my attempt

A PR to Cal.com would suffice. 😁😁😁😁

So if cal guy merges it, then only it's considered resolved?

@PeerRich Are you guys open to it? Just wanna confirm before putting in the effort.

@PeerRich Are you guys open to it? Just wanna confirm before putting in the effort.

Tagging @zomars from calcom regarding the same.

Tagging @zomars, @PeerRich, @hariombalhara from calcom regarding the same.

Yes, if cal merges, then we will give the bounty @rishi-raj-jain

Yes, if cal merges, then we will give the bounty @rishi-raj-jain

Even I'd commented @aidenybai

/attempt #535

Tagging @zomars, @PeerRich, @hariombalhara from calcom regarding the same.

Tagging @zomars, @PeerRich, @hariombalhara from calcom regarding the same.

@PeerRich Are you guys open to it? Just wanna confirm before putting in the effort.

/attempt #535

/claim #535 via https://github.com/calcom/cal.com/pull/11150

hi @aidenybai, I have integrated million.js into cal.com. But some of the E2E test are failing.
what do you suggest would be right way to deal with this?
can it be resolved by adding // million-ignore to ignore the components involved in those E2E tests?

@tobySolutions this issue should be closed since cal.com has already merged the pr

Hi @PeerRich shall I make a PR for this?

The PR for this was never merged @aidenybai. I'll take it that this issue stays open

/attempt

@aidenybai @PeerRich  is this still open should I work on it.


Add page with view for token

Page is linked from manage page. Flow for viewing a token is then:

Go to /manage to view tokens that you own
Click the card for one of your tokens

Note that this branch is based on the earlier PR so that they can be merged in order.


[JavaScript] 'this', 'super' and 'default' should have 'variable.language' scope

The OceanicNext tmTheme (homepage) colors this, super and default as red and italic using the scope variable.language.
Created from https://github.com/Microsoft/vscode/issues/2684

This issue was moved to Microsoft/TypeScript-TmLanguage#70


Add files via upload

Issue

Closes #issue
Addresses #issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Adds photo of the 28 Grand listing to the repo.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Prototype/POC (not to merge)
[ ] This change is a refactor/addresses technical debt
[ ] This change requires a documentation update
[ ] This change requires a SQL Script

How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have updated the changelog to include a description of my changes
[ ] I have run yarn generate:client if I made backend changes
[ ] I have exported any new pieces in ui-components

I think it's better to just use the images already hosted elsewhere since this is all demo data that we'll have to remove

Should we close this if we're going to use the hosted image?


Application error for underscore.template

Looking for<EMAIL_ADDRESS>Error:
Application error
An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details.

It does find the correct version when entering the package name https://unpkg.com/underscore.template

Thanks for the report @greggb, but unfortunately I'm not able to reproduce. Looks like this was a transient issue.

Ah, thanks for looking!


Project create script

Need a project create script, to:

Apply template as new files
Easily rename core algorithm file

Rename function has been tested.


Adjusting red port pin number for M5Core2 and M5Core

Description

Adjusting red port pin number for M5Core2 and M5Core
Motivation and Context

Adjusting red port pin number for M5Core2 and M5Core

How Has This Been Tested?

Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (work on Unit Tests, has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@jcabad100 you can check now if the configuration is the correct one!


[Guidance] : I need a help for S3 data encryption using AES-CBC encryption

Describe the question
I need a help (one sample code because i didn't found in SDK samples ) to encrypt my data by using AES-CBC encryption and i want to use my keys for data encryption.
I found one example on URL :
https://aws.amazon.com/blogs/developer/amazon-s3-encryption-client-is-now-available-for-c/
but its using KMS method where user can give its keys.
Platform/OS/Hardware/Device
embedded linux

Hi @shiv50084 ,
So I'm not sure what the problem is with using KMS and also only one of the 2 samples there uses it, so not sure what is wrong with the other sample....
I wouldn't want to write code and have that not help you either... So instead I'll say:
if you need more samples you can always take a look at the our tests here for inspiration on how to use the service.
Hope that helps and if not please describe a bit more on what kind of sample you'd want? What is missing from the one you linked?

@KaibaLopez
This is my sample code:-
/**
bool KMSWithEncryptionMaterials(const char* bucket, const char* objectKey,const char *File_name,HeaderValueCollection metadata)
{
ClientConfiguration clientConfig;
// Put an encrypted object to S3
PutObjectRequest putObjectRequest;
String contentType;
String Objkey;
String Region((char *)gstArnPermission.acRegion);
clientConfig.region = Region;
clientConfig.scheme = Scheme::HTTP;
clientConfig.verifySSL = 0;
clientConfig.httpRequestTimeoutMs = 30000;
clientConfig.connectTimeoutMs = 30000;
clientConfig.requestTimeoutMs = 30000;

#if 0  // To Get keys from AWS S3 CPP SDK
Aws::KMS::KMSClient kmsClient(clientConfig);
Aws::KMS::Model::CreateKeyRequest createKeyRequest;
auto createKeyOutcome = kmsClient.CreateKey(createKeyRequest);
if (!createKeyOutcome.IsSuccess())
{
std::cout << "Failed to create KMS master key.\n" << createKeyOutcome.GetError() << std::endl;
return false;
}
const Aws::String& masterKeyId = createKeyOutcome.GetResult().GetKeyMetadata().GetKeyId();
#else  // User given Keys
const Aws::String& masterKeyId= "2659407263E4A797";
#endif /* 0 */
const auto kmsEncryption = MakeShared<Aws::S3Encryption::Materials::KMSWithContextEncryptionMaterials>("s3Encryption",masterKeyId,clientConfig);
Aws::S3Encryption::CryptoConfigurationV2 cryptoConfig(kmsEncryption);

Auth::AWSCredentials credentials(ACCESS_KEY_ID, ACCESS_KEY_ID); // user Account Credentials

S3EncryptionClientV2 s3EncryptionClient(cryptoConfig,credentials,clientConfig);

putObjectRequest.SetMetadata(metadata);
putObjectRequest.SetBucket(bucket);
putObjectRequest.SetKey(Objkey);
const std::shared_ptr<IOStream> input_data =  MakeShared<FStream>("SampleAllocationTag",
                                                   File_name,
                                                   std::ios_base::in | std::ios_base::binary);
putObjectRequest.SetBody(input_data);
putObjectRequest.SetContentType("image/jpeg");

auto putObjectOutcome = s3EncryptionClient.PutObject(putObjectRequest,{});

if (putObjectOutcome.IsSuccess()) {
    std::cout << "Put object with KMSWithContextEncryptionMaterials succeeded" << std::endl;
} else {
    std::cout << "Error while putting object with KMSWithContextEncryptionMaterials \n"
              << putObjectOutcome.GetError() << std::endl;
    return false;
}
return true;

}
When i am running this code on my embedded device.I am getting an error :-
This error coming while i am giving user assigned encryption master key.

Error while putting object with KMSWithContextEncryptionMaterials
HTTP response code: -1
Resolved remote host IP address:
Request ID:
Exception name: GenerateContentEncryptionKeyFailed
Error message: Failed to generate content encryption key(CEK)
0 response headers:

when i running same code with master key generated by AWS SDK C++
I am getting below error.
Failed to create KMS master key.
HTTP response code: -1
Resolved remote host IP address:
Request ID:
Exception name:
Error message: curlCode: 7, Couldn't connect to server
0 response headers:
#############################
and full trace log during this testing you can find in attachment (mainly this log related to user input master key )
aws_sdk_2020-08-20-14.log
Can you please help why this error coming.

Hey @shiv50084 ,
I've tweaked a bit with the sample code you provided and it worked out fine.
The first error tells me that the key you tried to use is not valid and the second error means "Failed to connect to Permission denied” which happens when for any reason curl request is blocked by some firewall or similar thing.
Not sure what your V2 classes changed so I can't say for sure I know the root cause was but I reverted them to the ones the sdk provides, here's what works for me:
#include <stdio.h>
#include <aws/core/Aws.h>

#include <aws/core/client/ClientConfiguration.h>
#include <aws/kms/KMSClient.h>
#include <aws/kms/model/GenerateDataKeyRequest.h>
#include <aws/kms/model/GenerateDataKeyResult.h>

#include <aws/s3/S3Client.h>
#include <aws/s3/model/PutObjectRequest.h>
#include <aws/s3/model/PutObjectResult.h>
#include <aws/s3-encryption/S3EncryptionClient.h>
#include <aws/s3-encryption/materials/SimpleEncryptionMaterials.h>
#include <aws/s3-encryption/materials/KMSEncryptionMaterials.h>

using namespace Aws::Client;
using namespace Aws::S3Encryption::Materials;
using namespace Aws::S3Encryption;
using namespace Aws::KMS;
using namespace Aws::KMS::Model;

bool KMSWithEncryptionMaterials(const char* bucket, const char* objectKey)
{
ClientConfiguration clientConfig("default");
// Put an encrypted object to S3
Aws::S3::Model::PutObjectRequest putObjectRequest;
Aws::String contentType;

#if 1 // To Get keys from AWS S3 CPP SDK
auto kms_client = Aws::MakeShared<KMSClient>("Test KMS client", clientConfig);
GenerateDataKeyRequest request;
Aws::Map<Aws::String, Aws::String> enc_context;
request.SetKeyId("KMSkeyId");
request.SetNumberOfBytes(64);
request.SetEncryptionContext(enc_context);

auto generate_datakey_outcome = kms_client->GenerateDataKey(request);

//auto createKeyOutcome = kms_client->CreateKey(req);
if (!generate_datakey_outcome.IsSuccess())
{
std::cout << "Failed to create KMS master key.\n" << generate_datakey_outcome.GetError().GetMessage() << std::endl;
return false;
}
const Aws::String& masterKeyId = generate_datakey_outcome.GetResult().GetKeyId();
#else // User given Keys
const Aws::String& masterKeyId= "ValidKey";
#endif /* 0 */

auto kmsMaterials = Aws::MakeShared<KMSWithContextEncryptionMaterials>("s3Encryption", masterKeyId);
auto cryptoConfig = CryptoConfiguration(StorageMethod::METADATA, CryptoMode::ENCRYPTION_ONLY);

auto s3encClient = Aws::MakeShared<S3EncryptionClient>("Encryption Client",kmsMaterials,cryptoConfig,clientConfig);

putObjectRequest.SetBucket(bucket);
putObjectRequest.SetKey(objectKey);
const std::shared_ptr<Aws::IOStream> input_data =  Aws::MakeShared<Aws::StringStream>("s3KMSEncriptionTest");
putObjectRequest.SetBody(input_data);
putObjectRequest.SetContentType("image/jpeg");

auto putObjectOutcome = s3encClient->PutObject(putObjectRequest);

if (putObjectOutcome.IsSuccess()) {
    std::cout << "Put object with KMSWithContextEncryptionMaterials succeeded" << std::endl;
} else {
    std::cout << "Error while putting object with KMSWithContextEncryptionMaterials \n"
              << putObjectOutcome.GetError().GetMessage() << std::endl;
    return false;
}
return true;

}

int main(){
    Aws::SDKOptions options;
    Aws::InitAPI(options);
    options.loggingOptions.logLevel = Aws::Utils::Logging::LogLevel::Info;
    if(KMSWithEncryptionMaterials("myBucketName", "myKeyName"))
        std::cout<<"worked"<<std::endl;
    else
    {
        std::cout<<"did not work" << std::endl;
    }
    Aws::ShutdownAPI(options);
}

Hope this helps and let me know if you need something else or if I missed something.


AdminDashboard Repository

Hey!
In your latest release is the Info that the Admin Dahsboard Template will get it's own Repo.
Any Link to that Repo, or any info?
Greetings,
Luis

Any news?

any news?

No

The following is the last revision that has the admin template. https://github.com/MudBlazor/Templates/tree/df29a8de2733229fd6d297750b6bc4e39ee7e25d .
It was commited in Feb 9, 2022.

Thanks!


Intersector.intersectRayBounds can return an intersection outside the bounding box

How to reproduce:
Ray ray = new Ray(new Vector3(5731.2046f, -6039.354f, 11157.498f), new Vector3(-0.62397736f, -0.053491283f, -0.77960944f));
BoundingBox box = new BoundingBox(new Vector3(-3840.0f, -7680.0f, 848.0f), new Vector3(-1920.0f, -5760.0f, 1929.0f));
Vector3 entry = new Vector3();
if (Intersector.intersectRayBounds(ray, box, entry))
    System.out.println(entry); // [-1919.9995, -6695.2637, 1597.9346] (error: -1919.9995 > -1920.0)

Suggested patch (Intersector.intersectRayBounds):
if (hit && intersection != null) {
    intersection.set(ray.direction).scl(lowest).add(ray.origin);
    if (intersection.x < box.min.x)
        intersection.x = box.min.x;
    else if (intersection.x > box.max.x)
        intersection.x = box.max.x;
    if (intersection.y < box.min.y)
        intersection.y = box.min.y;
    else if (intersection.y > box.max.y)
        intersection.y = box.max.y;
    if (intersection.z < box.min.z)
        intersection.z = box.min.z;
    else if (intersection.z > box.max.z)
        intersection.z = box.max.z;
}

Additionally, if the ray origin is inside the box, the code doesn't set the intersection point:
if (v0.x > 0 && v0.y > 0 && v0.z > 0 && v1.x < 0 && v1.y < 0 && v1.z < 0) {
    return true;
}

I think the intersection point should be set to the ray origin in this case, even if it can break existing code... Suggested patch:
if (v0.x > 0 && v0.y > 0 && v0.z > 0 && v1.x < 0 && v1.y < 0 && v1.z < 0) {
    if (intersection != null)
        intersection.set(ray.origin);
    return true;
}

Thanks!

Thanks! Looks like a good addition, would you mind to send a pull request for it?
If there's an intersection and the intersection point is requested then that point should be within the bounds of the bounding box. Clamping the value to avoid small floating point errors sounds like a good way to guarantee that.
If the origin is inside the box then indeed the intersection point should be set as well. Setting it to the origin looks like the most obvious and simple solution for that. In that case the intersection point would be defined as "the point on the ray closest to the origin which is within the specified bounds".
Someone might expect the intersection point to be both on the ray and on the bounding box (each of the six planes) though. Floating point errors are to be expected, but having an intersection point inside the bounding box might not be that obvious. So adding a line to the javadocs might be a good idea.

Pull request sent.
I have added a comment about what is returned by this method, in particular in the case of a ray origin inside the box.
Regarding this part of your comment:

Someone might expect the intersection point to be both on the ray and on the bounding box (each of the six planes) though.

I think this is not the only issue with my fix: the way I'm clamping the intersection point can make it slightly diverge from the ray. I don't think this is problem (at least it is not an issue for me), but I say it explicitly in the javadoc to dissipate any ambiguity or wrong expectation.
Anyway, many thanks for this awesome project and your kind response!

I just realized there is another issue with this method (even with my patch). The following code is wrong:
v0.set(ray.origin).sub(box.min);
v1.set(ray.origin).sub(box.max);
if (v0.x > 0 && v0.y > 0 && v0.z > 0 && v1.x < 0 && v1.y < 0 && v1.z < 0) {
	return true;
}

This is obvious if you set the origin of box to (say) the minimum of the box, but it is also true if it is on any of the six planes of the box: the code tests if the origin is exclusively inside the box (excluding the bounds). The simplest fix is:
if (box.contains(ray.origin)) {
	if (intersection != null) intersection.set(ray.origin);
	return true;
}

I'm preparing a new pull request, but I want first to fix another issue I found with the intersectRayTriangle method (see next issue).


x/tools/cmd/gorename: allow renaming to builtins

What did you do?
While trying to rename a variable (func, etc..) to real the gorename tool panics.
Suppose you have a main.go like this:
package main

import "fmt"

func main() {
	world := "Hello world!"
	fmt.Println(world)
}

And you run gorename -from 'main.go::world' -to real
What did you expect to see?
Expected output:
Renamed 2 occurrences in 1 file in 1 package.
and the main.go file containing:
package main

import "fmt"

func main() {
	real := "Hello world!"
	fmt.Println(real)
}

What did you see instead?
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5eef75]

goroutine 1 [running]:
go/types.(*Package).Scope(...)
        /usr/local/go/src/go/types/package.go:41
golang.org/x/tools/refactor/rename.lexicalLookup(0xc4222d93b0, 0x7ffe2fd24c80, 0x4, 0x6a, 0xc42000f6d0, 0x79aea0, 0xc4222d92c0)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:291 +0x95
golang.org/x/tools/refactor/rename.(*renamer).checkInLexicalScope.func2(0xc42000a840, 0xc4222d93b0, 0x6)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:250 +0xb7
golang.org/x/tools/refactor/rename.forEachLexicalRef.func1(0x7977e0, 0xc42000a840, 0x639a00)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:332 +0x56c
go/ast.inspector.Visit(0xc42247a000, 0x7977e0, 0xc42000a840, 0x0, 0x0)
        /usr/local/go/src/go/ast/walk.go:373 +0x3a
go/ast.Walk(0x7969e0, 0xc42247a000, 0x7977e0, 0xc42000a840)
        /usr/local/go/src/go/ast/walk.go:52 +0x66
go/ast.Walk(0x7969e0, 0xc42247a000, 0x7972a0, 0xc42004e700)
        /usr/local/go/src/go/ast/walk.go:136 +0x1041
go/ast.Walk(0x7969e0, 0xc42247a000, 0x797560, 0xc420044720)
        /usr/local/go/src/go/ast/walk.go:196 +0x1b1c
go/ast.walkStmtList(0x7969e0, 0xc42247a000, 0xc420044730, 0x1, 0x1)
        /usr/local/go/src/go/ast/walk.go:32 +0x81
go/ast.Walk(0x7969e0, 0xc42247a000, 0x797220, 0xc42005f350)
        /usr/local/go/src/go/ast/walk.go:224 +0x1b71
go/ast.Walk(0x7969e0, 0xc42247a000, 0x7976a0, 0xc42005f380)
        /usr/local/go/src/go/ast/walk.go:344 +0xd83
go/ast.walkDeclList(0x7969e0, 0xc42247a000, 0xc42004e740, 0x3, 0x4)
        /usr/local/go/src/go/ast/walk.go:38 +0x81
go/ast.Walk(0x7969e0, 0xc42247a000, 0x797620, 0xc42007c200)
        /usr/local/go/src/go/ast/walk.go:353 +0x266f
go/ast.Inspect(0x797620, 0xc42007c200, 0xc42247a000)
        /usr/local/go/src/go/ast/walk.go:385 +0x4b
golang.org/x/tools/refactor/rename.forEachLexicalRef(0xc4200b00b0, 0x79aea0, 0xc4222d92c0, 0xc4222e9fa0, 0xc42000e301)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:365 +0x18f
golang.org/x/tools/refactor/rename.(*renamer).checkInLexicalScope(0xc42017ea10, 0x79aea0, 0xc4222d92c0, 0xc4200b00b0)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:244 +0xd3
golang.org/x/tools/refactor/rename.(*renamer).checkInPackageBlock(0xc42017ea10, 0x79aea0, 0xc4222d92c0)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:143 +0x5b3
golang.org/x/tools/refactor/rename.(*renamer).check(0xc42017ea10, 0x79aea0, 0xc4222d92c0)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/check.go:38 +0x3c3
golang.org/x/tools/refactor/rename.Main(0x7b1b20, 0x0, 0x0, 0x7ffe2fd24c6e, 0xd, 0x7ffe2fd24c80, 0x4, 0x0, 0x0)
        /home/rndz/golang/src/golang.org/x/tools/refactor/rename/rename.go:347 +0x883
main.main()
        /home/rndz/golang/src/golang.org/x/tools/cmd/gorename/main.go:49 +0x157

System details
go version go1.9.2 linux/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/rndz/golang"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build855039640=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version go1.9.2 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.9.2
uname -sr: Linux 3.16.0-4-amd64
Distributor ID:	Debian
Description:	Debian GNU/Linux 8.9 (jessie)
Release:	8.9
Codename:	jessie
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Debian GLIBC 2.19-18+deb8u10) stable release version 2.19, by Roland McGrath et al.

The crash also seems to occur whenever the new name is a builtin name, e.g. gorename -from 'main.go::world' -to len.

The crash also seems to occur whenever the new name is a builtin name

real is a builtin.
In contrast to renaming to builtins which cause crashes, renaming to keywords is handled gracefully (see isValidIdentifier -> token.Lookup):
$ gorename -from 'main.go:: world' -to else
gorename: -to "else": not a valid identifier

/cc @alandonovan

We can improve gorename by handling rename to builtins the same way as keywords are handled. It should return this error: gorename: -to "len": not a valid identifier

Renames to built-in names should not be handled specially. There are plenty of occasions when you want to re-use a predeclared name, such as a function called print or real, or a method called int or string.
The tool should not crash, of course.

closing as obsoleted by #69360

Thanks @seankhliao. Do beware that many of these gorename issues are in principle applicable to gopls' Rename LSP RPC,  which runs a fork of the same algorithm. That said, I just verified that this particular issue is fixed in gopls, and that the other ones just closed don't really apply to gopls because it has a notion of a workspace.


get main and develop back in sync

we merged https://github.com/clessig/atmorep/pull/37 into the main so to create a tag for the new single field runs. this MR is to put main and develop back in sync

since there are conflicts and both branches are protected I will close the PR and use iluise/head instead.


Fix jenkins

Fixing errors with jenkins server as it cannot find the service file

Hi, @biofotis , is this issue still exist?

I am not sure haven't ran it for a while but it couldn't find the service file until I added this to cmakelists.

Okay, I resolved this issue few weeks ago, just want to make sure everything works well. I'll close it for now. If you found it still cannot find services, please feel free to reopen it. Thank you very much.


Adds Spotify track code

Adds method to display Spotify code for current track and instructions on how to enable it.

@novatorem any thoughts on adding this feature as an option?

@ajmeese7 Same answer as #23


Make the implicit unique constraints on 1:1 relations explicit

Problem
The following Prisma schema:
model A {
  id   Int @id
  b_id Int
  b    B @relation(fields: [b_id], references: [id])
}

model B {
  id Int @id
  as A?
}

doesn't contain an @unique, but if you migrate it, you will have a unique index on b_id so that it's enforced that the relation is really one-to-one and not one-to-many. If you introspect it, it would become explicit in the schema. This is a very old opinionation. Prisma as a whole has evolved towards more explicitness, less "magic" in the schema to better reflect the reality of the database.
This issue is here to propose that we enforce that the backing scalar fields of the relation are covered by a unique constraint, meaning we would validate (and possibly help with autoformatting or code actions) so that the valid schema would be:
model A {
  id   Int @id
  b_id Int @unique
  b    B   @relation(fields: [b_id], references: [id])
}

model B {
  id Int @id
  as A?
}

This works exactly the same if the relation is backed by multiple scalar fields.
Suggested solution

Add a validation with a clear error message explaining that to enforce the one-to-one-ness of the relation, a unique constraint is required on such and such fields, with an example of how it would look like.
Offer a code action to do this automatically in LSP-enabled editors.

This is a breaking change, because existing valid Prisma schemas would not pass validation anymore. It can only be released in a new major version.
Alternatives

Do nothing and keep the current behaviour.
Make explicating the unique constraint part of the reformatting logic

Additional context

Prisma internal document

Client team label as this will trigger work in fixing QE tests.

Note: This is not for implementation, but only consideration what to do about it next.

any solution for this? i don't have much time to wait for prisma4 got released

This only adds a restriction, you can just enforce that manually already - if there a 1:1 relation, make sure there is a @unique constraint.

oh okay, thanks for your reply
On Thu, Jun 16, 2022, 9:00 PM Jan Piotrowski @.***>
wrote:

This only adds a restriction, you can just enforce that manually already -
if there a 1:1 relation, make sure there is a @unique constraint.
—
Reply to this email directly, view it on GitHub
https://github.com/prisma/prisma/issues/10503#issuecomment-1157695830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVOVPFSGWKRSEWUAPQR7OTVPMXOZANCNFSM5JBBJ77Q
.
You are receiving this because you commented.Message ID:
@.***>


Fix links in RBAC default bindings table

An extra line needs to be added to allow the link to be rendered properly.
Also reformatting link line to be better readable.

/sig auth

Preview of the fixed page & section:
https://deploy-preview-29295--kubernetes-io-main-staging.netlify.app/docs/reference/access-authn-authz/rbac/#user-facing-roles
I confirmed this fixes a broken hyperlink in the table with the row starting with admin in https://kubernetes.io/docs/reference/access-authn-authz/rbac/#user-facing-roles (as of 8/9/2021 3:15pm PDT)

/lgtm