semgrep: 1.71.0 -> 1.72.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for semgrep is: Lightweight static analysis for many languages - cli
meta.homepage for semgrep is: https://semgrep.dev/
meta.changelog for semgrep is: https://github.com/semgrep/semgrep/blob/v1.72.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.72.0 with grep in /nix/store/2k7ymld487sfs6kfzlnflcjf9a60xhh8-semgrep-1.72.0
found 1.72.0 in filename of file in /nix/store/2k7ymld487sfs6kfzlnflcjf9a60xhh8-semgrep-1.72.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

semgrep
semgrep-core

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2k7ymld487sfs6kfzlnflcjf9a60xhh8-semgrep-1.72.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A semgrep https://github.com/r-ryantm/nixpkgs/archive/fb331042de467a7d7450f122c221cbcd3d73beac.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fb331042de467a7d7450f122c221cbcd3d73beac#semgrep

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2k7ymld487sfs6kfzlnflcjf9a60xhh8-semgrep-1.72.0
ls -la /nix/store/2k7ymld487sfs6kfzlnflcjf9a60xhh8-semgrep-1.72.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

3 packages built:

semgrep
semgrep-core
semgrep.dist

Maintainer pings
cc @06kellyjac @ambroisie for testing.

Result of nixpkgs-review pr 311256 run on x86_64-linux 1

3 packages built:

semgrep
semgrep-core
semgrep.dist


tf_backend_secondary_region appears to be required even with terraform cloud

Terraform Version & Prov:
AFT Version:
N/A
Terraform Version & Provider Versions
Please provide the outputs of terraform version and terraform providers from within your AFT environment
terraform version
Terraform v1.4.6
on darwin_arm64
+ provider registry.terraform.io/auth0/auth0 v0.48.0
+ provider registry.terraform.io/hashicorp/archive v2.3.0
+ provider registry.terraform.io/hashicorp/aws v4.67.0
+ provider registry.terraform.io/hashicorp/local v2.4.0
+ provider registry.terraform.io/hashicorp/random v3.5.1
+ provider registry.terraform.io/hashicorp/tfe v0.44.1
+ provider registry.terraform.io/hashicorp/time v0.9.1

terraform providers

Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/random] ~> 3.5.1
├── provider[registry.terraform.io/auth0/auth0] ~> 0.48.0
├── provider[registry.terraform.io/hashicorp/tfe] ~> 0.44.0
├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0, < 5.0.0
└── module.aft
    ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0, < 5.0.0
    ├── provider[registry.terraform.io/hashicorp/local]
    ├── module.packaging
    │   └── provider[registry.terraform.io/hashicorp/archive]
    ├── module.aft_code_repositories
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_backend
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    ├── module.aft_feature_options
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    ├── module.aft_account_provisioning_framework
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_customizations
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_iam_roles
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.audit_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.ct_management_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.ct_management_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.log_archive_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.log_archive_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.aft_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   ├── module.aft_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   └── module.audit_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    ├── module.aft_account_request_framework
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/time]
    ├── module.aft_lambda_layer
    │   ├── provider[registry.terraform.io/hashicorp/local]
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
    │   └── provider[registry.terraform.io/hashicorp/random]
    └── module.aft_ssm_parameters
        ├── provider[registry.terraform.io/hashicorp/aws] >= 4.27.0
        └── provider[registry.terraform.io/hashicorp/random]

Bug Description
When I try to run the AFT (Step 5 of the deployment steps), I see an error about configuring Terraform AWS Provider: no valid credential sources for Terraform AWS Provider found.. On deeper investigation, I could create a different error when I set the tf_backend_secondary_region variable. I am using terraform cloud and have the terraform_distribution parameter set as such. I do not understand why this is happening.
To Reproduce
Steps to reproduce the behavior:

Create a new module with the shown main.tf
Run terraform plan
See error

Expected behavior
To be able to run it all to completion.
Related Logs
module.aft.module.aft_account_provisioning_framework.data.aws_iam_policy.AWSLambdaBasicExecutionRole: Refresh complete after 0s [id=arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole]
╷
│ Error: configuring Terraform AWS Provider: no valid credential sources for Terraform AWS Provider found.
│
│ Please see https://registry.terraform.io/providers/hashicorp/aws
│ for more information about providing credentials.
│
│ AWS Error: failed to refresh cached credentials, failed to retrieve credentials, operation error STS: AssumeRoleWithWebIdentity, failed to resolve service endpoint, an AWS region is required, but was not found
│
│
│   with module.aft.provider["registry.terraform.io/hashicorp/aws"].tf_backend_secondary_region,
│   on .terraform/modules/aft/providers.tf line 28, in provider "aws":
│   28: provider "aws" {
│
╵
Operation failed: failed running terraform plan (exit 1)
ERRO[0027] Terraform invocation failed in /Users/aimami/experiments/project_nimbus/Terraform-Core/terraform/TF_account_factory
ERRO[0027] 1 error occurred:

Additional context
Here's my terraform file
module "aft" {
  source  = "aws-ia/control_tower_account_factory/aws"
  version = "1.10.3"
  # Required Vars
  ct_management_account_id    = "xxxxxxxxxxxx"
  log_archive_account_id      = "xxxxxxxxxxxx"
  audit_account_id            = "xxxxxxxxxxxx"
  aft_management_account_id   = "xxxxxxxxxxxx"
  ct_home_region              = "us-east-2"
  # VCS Vars
  vcs_provider                                  = "github"
  account_request_repo_name                     = "AFT-account-request"
  global_customizations_repo_name               = "AFT-global-customizations"
  account_customizations_repo_name              = "AFT-account-customizations"
  account_provisioning_customizations_repo_name = "AFT-account-provisioning-customizations"
  # Terraform Vars
  terraform_org_name = "MyOrg"
  terraform_distribution = "tfc"
}

Thanks for the report @AliSajid. Was this a fresh deployment of AFT? I wasn't able to reproduce your specific failure case, as I was able to deploy an instance of AFT homed in a single region, using Terraform Cloud.
I have however seen your initial error before.

configuring Terraform AWS Provider: no valid credential sources for Terraform AWS Provider found.

There's a potential you need to set an AWS_DEFAULT_REGION for the hashicorp/aws provider to detect. You may try setting that environment variable to see if the provider error clears up.

It is a fresh deployment. I do have the default region set in my config.
In AWS, I also have other regions turned off.

@AliSajid we recommend you to reach out to AWS Premium support to receive further help on troubleshooting the issue in your environment.


Flushing UDFs

Hi
How do you redownload the UDF definitions ? i've recently added 2 UDFs (to assets) but i can't "get them" via powershell
I've
Import-Module -force
Update-Atwsfunctions (static and dynamic)
Update-AtwsDiskCache
but when i $ConfigurationItems = Get-AtwsInstalledProduct -id 29729321
$configuration doesn't include the new UDFs (that are filled in) that i can see via the web interface
Thanks

There is nothing you need to do locally to get new UDFs. The code does not change when you an a new UDF. It is only when you change a field with a picklist (for instance ticket status, issue type, subissue type, account types etc) that you need to update your code. And it is always sufficient to reload the module with the object type that has to be updated in the argumentlist:
Import-Module -force -argumentlist $creds,$apikey,'installedproduct'

As long as the API is working normally you will get any UDFs in the UserDefinedField array. This includes UDFs that are set to inactive in the GUI. As an aside, we actually exploit that to create UDFs that are only available through the API. Inactive UDFs are not displayed in the web GUI.
So I do not know why your new UDFs aren't returned by the API. There should not be anything in the way the module works that could cause this.

Thanks for the response,
Ran the import with the installed product which (I assume) rechecked those entities but still no dice, all the old values show up (and if I edit them in the web the new values show up in PS) but I cannot get the new UDF to show
I’ll get hold of support and see what they say
Regards
Steven Pretlove
Managing Director
<EMAIL_ADDRESS>01908 410041
07595 020702
www.ccsnet.co.uk
Gemini House, Sunrise Parkway, Linford Wood, Milton Keynes, MK14 6LS
Disclaimer: County Consultancy Services Ltd. may monitor email traffic data and also the content of email for the purposes of security and staff training.
This message contains confidential information and is intended only for the reciepient. If you are not the recipient you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. CCS IT Solutions therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission. If verification is required please request a hard-copy version.
Terms and Conditions: All services and quotes that may or may not be contained within this e-mail are bound by our standard terms and conditions the latest version of which can be found on our website.
County Consultancy Services Ltd. (CCS) is a limited company registered in England and Wales 5185670.
Registered office: Gemini House, Sunrise Parkway, Linford Wood, Milton Keynes, MK14 6LS
From: Hugo Klemmestad<EMAIL_ADDRESS>Sent: 09 August 2019 11:49
To: officecenter/Autotask<EMAIL_ADDRESS>Cc: Steven Pretlove | CCS IT Solutions<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [officecenter/Autotask] Flushing UDFs (#48)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe, CCS IT Solutions
There is nothing you need to do locally to get new UDFs. The code does not change when you an a new UDF. It is only when you change a field with a picklist (for instance ticket status, issue type, subissue type, account types etc) that you need to update your code. And it is always sufficient to reload the module with the object type that has to be updated in the argumentlist:
Import-Module -force -argumentlist $creds,$apikey,'installedproduct'
As long as the API is working normally you will get any UDFs in the UserDefinedField array. This includes UDFs that are set to inactive in the GUI. As an aside, we actually exploit that to create UDFs that are only available through the API. Inactive UDFs are not displayed in the web GUI.
So I do not know why your new UDFs aren't returned by the API. There should not be anything in the way the module works that could cause this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_officecenter_Autotask_issues_48-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAMLNOYY2H65Q7CJ2WGC6ZBLQDVDS5A5CNFSM4IKSWRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD36KOGI-23issuecomment-2D519874329&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=W8IHFxUaxbCqk0f-PCI9cZn8196kx6rbpZI3kO27Ff4&m=B123iENOwiUjF7IXJh_dKRgNLsM9ifMhHJ3wQd1BNMc&s=d3LnDKZx6IqvSnAARTM8IOVJzbzZ98pFw9zIdTk2A9Q&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMLNOYZR7ZBTXPYVIJ3HZFDQDVDS5ANCNFSM4IKSWRBQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=W8IHFxUaxbCqk0f-PCI9cZn8196kx6rbpZI3kO27Ff4&m=B123iENOwiUjF7IXJh_dKRgNLsM9ifMhHJ3wQd1BNMc&s=4lU5y1GG-eYq-mP1ep9BxmVH9Olm1-ePfXgN0RF6ldI&e=.

Hi Hugo,
I’m very confused now, this works fine under <IP_ADDRESS> (which we had installed on a old laptop)
So
Import-Module Autotask
#$Credential = Get-Credential
$username =<EMAIL_ADDRESS>$password = convertto-securestring -String '’ -AsPlainText -Force
$Credential = new-object -typename System.Management.Automation.PSCredential `
-argumentlist $username, $password
Connect-AutotaskWebAPI -Credential $Credential
$test = Get-AtwsInstalledProduct -id 29683721
$test.UserDefinedFields
Works  fine and I can see the UDF field and as I change it the new value comes up
Username and password for Autotask
$ATurl = "https://webservices.autotask.net/ATServices/1.6/atws.wsdl" # To use Version 1.6 change to "https://webservices.autotask.net/ATServices/1.6/atws.wsdl"
$ATusername =<EMAIL_ADDRESS>$ATpassword = ConvertTo-SecureString "*" -AsPlainText -Force
$ATcredentials = New-Object System.Management.Automation.PSCredential($ATusername,$ATpassword)
$APIKey = '*********'
Import-Module Autotask -ArgumentList $ATcredentials, $APIKey -verbose -Prefix CCS -force
$test = Get-CCSAtwsInstalledProduct -id 29683721
Returns the values and UDFs (as it was prior to adding the new UDF) if I change values the new values show up and change as you would expect. But I cannot get the new UDF to show up for love nor money.
Regards

That is weird, I must admit. Can you share the name and value of your new UDF? Then I can check if the name or value crashes with something I do in the code, having thought it safe...

Yep the Value is BackupCheck
i'm working with <IP_ADDRESS> ATM and its working absolutely fine, but everytime i try the latest it just doesn't show.

Just to be clear: The name of the UDF is 'BackupCheck'? And possible values are?

Hi,
Yes the name is backup check and the values are 7 digits long (one for each day of the week (SMTWTFS)
0100000 = check backups only on a monday
0111110 = check backups every weekday
1111111 = ever day etc...etc...

I am not able to reproduce the problem with our Autotask database. I added a Configuration Item UDF by name 'BackupCheck'. Get-AtwsInstalledProduct returns an object with all 45 UDFs, including BackupCheck. Changing it works, too. I did not have to change or update the module in any way, UDFs should just work.
Could you Export-CliXML the offending object with both <IP_ADDRESS> and 2.2.1 and attach the .xml files to a post?

Sure is there any specific command i should run i'm just heading out of the office but can check when i return in about an hour

No, just Get-AtwsInstalledProduct -id 29683721 | Export-Clixml object.<IP_ADDRESS>.xml and repeat it with 2.2.1. and upload with a post.
At least I think GitHub allows XML as attachments...

Hi,
It appears that GitHub doesn't support XML as attachments. What is it you're looking for in there? We can just copy/paste that section in as a comment.

How about .zip? I wanted to look at the UserDefinedField array, and that can easily be several hundred lines. CliXML is rather chatty...

Hi Hugo,
I've checked the XML and can confirm that 1.6 returns FAR fewer lines the XMLs are
54KB for 2.2.1
23KB for <IP_ADDRESS>
the XML contains far to much client data to post public but happy to send over to you by other means.
I can confirm the only differences in the commands where that one was under 2.2.1 the other under <IP_ADDRESS>

Let us make doubly sure that the module is not the problem. Add your credentials and apikey to the code below and run it. This uses the same query and credentials agains both version 1.5 and 1.6. Since the result is straight from the API response it should match the SOAP XML response the API is sending. It the objects aren't identical then there is definitely something wrong at the Autotask side.
$Credential = '' # Supply your credentials
$ApiTrackingIdentifier = '' # Supply your API tracking identifier. Both API versions support it.
$id = ? # The ID of your configuration object
$zone = 4 # Your webservices zone. Mine is 4, i.e. https://ww4.autotask.net. If you are in the UK yours is probably the same

$uri15 = 'https://webservices{0}.autotask.net/ATServices/1.5/atws.wsdl' -F $zone
$uri16 = 'https://webservices{0}.autotask.net/ATServices/1.6/atws.wsdl' -F $zone

$Connection15 = New-WebServiceProxy -Uri $uri15 -Namespace Autotask15 -Credential $Credential
$AutotaskIntegrationsValue = New-Object Autotask15.AutotaskIntegrations
$AutotaskIntegrationsValue.IntegrationCode = $ApiTrackingIdentifier
$Connection15.AutotaskIntegrationsValue = $AutotaskIntegrationsValue

$Connection16 = New-WebServiceProxy -Uri $uri16 -Namespace Autotask16 -Credential $Credential
$AutotaskIntegrationsValue = New-Object Autotask16.AutotaskIntegrations
$AutotaskIntegrationsValue.IntegrationCode = $ApiTrackingIdentifier
$Connection16.AutotaskIntegrationsValue = $AutotaskIntegrationsValue

$query = @'
<queryxml><entity>InstalledProduct</entity><query><field>id<expression op="Equals">{0}</expression></field></query></queryxml>
'@ -f $id

$response15 = $Connection15.query($query)
$response16 = $Connection16.query($query)

$configurationItem15 = $response15.EntityResults[0]
$configurationItem16 = $response16.EntityResults[0]

if($configurationItem15.UserDefinedFields.count -ne $configurationItem16.UserDefinedFields.count) {
    Write-Warning ('Woot!API 1.5 returns {0} UDFs while 1.6 returns {1}?!?' -f $configurationItem15.UserDefinedFields.count,$configurationItem16.UserDefinedFields.count)
}

ok so this results in the same for both, but when i return using 2.2.1 i get far more UDFs

there is 23 (with both using this script) 26 when using <IP_ADDRESS> and 77 using 2.2.1

Do you use the same credentials with 2.2.1?

no as i didn't think it supported the API Identifier and if you try and logon with the creds (with a intergration code it throws an error)

Then this could be an authorization issue. They did change the access rights scheme with 1.6.

Fra: CCS-StevenPretlove<EMAIL_ADDRESS>Sendt: Wednesday, August 14, 2019 11:01:45 PM
Til: officecenter/Autotask<EMAIL_ADDRESS>Kopi: Hugo L. Klemmestad<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Emne: Re: [officecenter/Autotask] Flushing UDFs (#48)
no as i didn't think it supported the API Identifier and if you try and logon with the creds (with a intergration code it throws an error)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/officecenter/Autotask/issues/48?email_source=notifications&email_token=ABGWT5UIK2CPG3EH2UQYI3DQERXDTA5CNFSM4IKSWRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KDD6I#issuecomment-521417209, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGWT5SAWREU2Z3YBUL6JKDQERXDTANCNFSM4IKSWRBQ.

The UDFs in question, do they have the Protected property set? As per the API documentation for the new API only security levels:

Access to protected Configuration Item UDFs, which may store sensitive data, is not granted by default. Access is granted separately by resource. Refer to Manage permission to view protected data.

Hit the nail on the head, thank you so much for your time, nothing to do with the module in the end at all please accept my apologises

I appreciate that you took the time to notify me of your issues. I need feedback to keep the module working. I had not noticed this exception to the "access to all data" rule for API users before this. I think you were right to suspect the module. Now we know the real cause and can share that information with other PowerShell users. Thank you for contributing!


adding extraction script for mixture metadata

I added the metadata-extraction script for the mixture set to the new structure.

Yes, just change the excel sheets. This is not the focus of the project. And then send your tests to @soudehMasoudian such that we could actually integrate the tests directly before merging into main.

Can you join the two pull request (unit tests + metadata extraction).

Please move the script to a different folder as suggested in #55 and already implemented in main.

I can't do that while still working on my branch, right? This new folder didn't exist in the main branch when I created mine. Is there a way to change this, should I create a new branch or do I have to move it when it is merged with main? @eriktamsen

You can merge the main branch into your branch, perform all the changes and then merge back. After having merged main into your feature branch, the directory structure should be updated.


Choose the avatar for resume or CV))

Create a creative avatar for future customers.

https://1drv.ms/u/s!Al8ofHfGXC90g95I409_3DZL27T20A


Run valgrind tests on CI if CPU can execute it correctly

For caching we took the CPU model into account, @bhansconnect figured out we can use the same approach to run valgrind without errors.

[ ] Run valgrind tests if CPU is Xeon E5-2673 v4.
[ ] The E5-2673 v3 could work as well, this should be tested.
[ ] Only compile valgrind if we're using a CPU that can run it.
[ ] Skip valgrind tests without errors if we're on a unsupported CPU.
[ ] We used to run cargo test -- --ignored for the valgrind tests. It's better to filter ignored tests on "valgrind"  for clarity.

Valgrind runs in CI now (I think)

It does :)


Update test_psm3_tmy-2017.csv to match current NSRDB

[x] Closes #1005
[x] I am familiar with the contributing guidelines
~Tests added~
~Updates entries to docs/sphinx/source/api.rst for API changes.~
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
~New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.~
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Seeing if Azure likes the update...

Looks like this worked.  Scrolling through the Test_conda_linux checks, the failures are all test_tmy.py::test_read_tmy3_remote.  There was one failure in the MIDC test suite, but I reran the check and it went away.


Select a valid choice error with ModelSelect2MultipleWidget…

I am a little confused about how to test a form using ModelSelect2MultipleWidget. The form looks like thus:
class TestForm(forms.Form):
    users = forms.ModelChoiceField(
        widget=ModelSelect2MultipleWidget(
            model=User,
            queryset=User.objects.all(),
            search_fields=["username__icontains", ],
            attrs={'style': 'min-width:800px'},
        ),
        queryset=User.objects.all(),
        label="Select multiple users",
    )

and the test like so:
    def test_code_add_form(self):
        jdoe = User.objects.create_user(username='JohnDoe',
                                        first_name="John",
                                        last_name="Doe",
<EMAIL_ADDRESS>                                        password='s3kr3t')
        data = {'users': (jdoe.pk, )}
        form = TestForm(data=data)
        self.assertTrue(form.is_valid(), form.errors)

In conjuncture, they gives me:
AssertionError: False is not true :

users

Select a valid choice. That choice is not one of the available choices.

What am I doing wrong?

… widget=ModelSelect2MultipleWidget(…) would make more sense, wouldn't it?

Hi @kierun!
I think I need a little more information to answer you question correctly.
Is TestForm a webtest thing? If so, that can be an issue, because webtest only allows for options in the DOM tree. The whole purpose of the library is to not have them in the DOM tree but to fetch options on demand for better performance.
Cheers
-joe

Is TestForm a webtest thing? If so, that can be an issue, because webtest only allows for options in the DOM tree. The whole purpose of the library is to not have them in the DOM tree but to fetch options on demand for better performance.

No, it is a unit test django.test.TestCase. The code pasted was a toy to re-create the problem which went away when I replaced forms.ModelChoiceField with forms.ModelMultipleChoiceField… And I just noticed that I messed up the answer above. Edited now.
☹ No more coding for me before I get a good night's sleep!

Oh, you passed a tuple. It should just be the PK, eg:
data = {'users': jdoe.pk}

@codingjoe I wanted a multiple select. Thus, the test is correct. It should be a tuple. However, the widget was correct but the form was set up as a ModelChoiceField not a ModelMultipleChoiceField. Hope that clears any confusion. ☺

Ok, does it work with the ModelMultipleChoiceField? Because to be honest, I don't see anything incorrect besides that. It should work. #famousLastWords ;)

ModelMultipleChoiceField does indeed make it work just as expected. ☺


Logging API documentation is very strange

Look at https://googlecloudplatform.github.io/google-cloud-dotnet/docs/Google.Cloud.Logging.V2/api/Google.Cloud.Logging.V2.LoggingServiceV2.LoggingServiceV2Client.html and it has "Log entry resources" as headings everywhere (see the right hand column) for no obvious reason.

That link is for the gRPC client, but the GAPIC client is equally bust: https://googlecloudplatform.github.io/google-cloud-dotnet/docs/Google.Cloud.Logging.V2/api/Google.Cloud.Logging.V2.LoggingServiceV2Client.html
Regenerating it doesn't help either. Still investigating - I suspect there's something in the proto comments that's confusing docfx.

Ah - it's the unfortunate layout of the proto documentation:
https://github.com/googleapis/googleapis/blob/7ccfa2cd4a2737dc828061809d60ee03b23e2b5d/google/logging/v2/logging.proto#L46
I'll see if I can get that subheading removed.

Removed "bug" as it's not a bug in any code here. (It could be argued as a bug in docfx, but not massively.)
Once the proto has been changed, just regenerating should sort this out.

The proto is now fixed - but the config is causing problems for regeneration. This is in hand.

This has been sorted now that it's been regenerated.


Add support for dynamic labels

Use case:
There is not always a 1:1 mapping between the branch name that a PR is backported to, and the label that should be added to the source PR.
Example
For Kibana the label v7.10.0 must be applied before the initial release of 7.10 and the label v7.10.1 should be applied after the release to indicate it needs to go out in 7.10.1. Would be great if the end user didn't have to think about this.

Related to https://github.com/elastic/kibana/issues/127659


Reserving usernames without Merkle Trees

Rationale
Users who have registered specific names on the Rinkeby contract should be able to retain ownership of these names when we move to Görli and mainnet. A Merkle Tree based approach was previously implemented to reserve names.  We propose replacing this with a a simpler model which has lower gas fees and does not require the user to come online at a specific time.
Proposal
Once the contracts are launched on the new network, registrations can only be made from a special address for 48 hours (the reserved registrant). A service that controls this address will automatically register all names that were tagged for migration to the same address that owned them on the previous network. The Farcaster team will determine the set of active usernames to migrate, and the exact process is outside the scope of this ticket.
Contract Modifications
The existing preregister method is modified to stop checking for a merkle proof and will instead check that the msg.sender matches the relayAddress. Unlike the register method, it will not validate usernames (to save gas), will not require a commit (since front-running is not possible) and does not charge for registration.
function preregister(address to, bytes16 username)

Rinkeby to Görli
Since the Hubs are not yet active, this migration will result in a hybrid state where v2 contracts will live side-by-side with v2 data storage layer. Users who are migrating will need to:

Acquire an ID from the Account Registry into the same address as the username
Re-sign and re-upload all of their messages to their v1 Host according to the new v2 file format

Görli to Mainnet
The Hubs will be active during this migration, which will happen in 2023. A new set of "mainnet Hubs" will be spun up along side the Gorli hubs. Tentatively, users will need to:

Claim an account ID on mainnet
Broadcast an off-chain message to mainnet hubs to connect their id and username
Re-sign and re-broadcast all messages from the gorli hubs to the mainnet hubs.

This sounds good to me! One small, clarifying question: we're able to change the pre-registration period from 48 hours to another time period for mainnet if need be, right?

Yes, that's configurable before deploy


Logger

Added a logger rather than print statements. Allows printing to a log file that will be generated after running the titration device.

This PR fixes #51

Can you add a test? Also does will this replace other print statements?

Test has been added

The implementation of this currently, is not necessary.


Updated composer.json

need to support this package in Laravel 6

As I haven't received the changes requested.. this is done now on original repo of mine by myself.
Thanks. Closing this issue.


Result of Expression Evaluation is Unused

Summary
We should detect expression statements that don't mutate the state of the contract and whose result is unused.
Context
Should cover issues like this: https://github.com/tact-lang/tact/issues/6
Examples
fun inc(a: Int): Int { return a + 1; }

self.foo == 3; // Warning: unused boolean expression
inc(a); // Warning: unused return value

Use instead:
fun inc(a: Int): Int { return a + 1; }

self.foo = 3; // OK: Fixed a typo
newValue = inc(a); // OK: Assigned the result
_ = inc(a); // OK: Explicitly suppressed

We should also cover standard library functions, especially for Builder, Cell, and Slice, since a new user might assume they mutate an object in-place (e.g., writing b.storeBool(true) instead of b = b.storeBool(true)).


Default model should be simplified and use the built-in PyTorch transformer layers (though still support structured attention)

Specifically, this: https://pytorch.org/docs/stable/generated/torch.nn.functional.scaled_dot_product_attention.html?highlight=scaled_dot_product_attention#torch.nn.functional.scaled_dot_product_attention


Add isSectionDividerRequired feature support to gnav

Unav has a isSectionDividerRequired feature which gnav needs to support.
Global navigation component will take it in the config and pass it to unav config

Resolves: MWPW-159143
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://unav-divider--milo--adobecom.hlx.page/?martech=off

Qa: https://adobecom.github.io/nav-consumer/navigation.html?navbranch=unav-divider&env=stage&showUnavSectionDivider=true

Validation is done on the below url
https://adobecom.github.io/nav-consumer/navigation.html?navbranch=unav-divider&env=stage&showUnavSectionDivider=true

results are in https://jira.corp.adobe.com/browse/MWPW-159143

Closing this and putting the change in this PR


cmake: Fix how we set include dirs for userspace

To ensure the proper flags are specified to the toolchain, we need to
keep system headers and non-system headers seperate and set the SYSTEM
flag to target_include_directories for system headers.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

Merging #14529 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14529      +/-   ##
==========================================
- Coverage   52.02%   51.99%   -0.04%
==========================================
  Files         309      309
  Lines       45574    45574
  Branches    10555    10555
==========================================
- Hits        23711    23695      -16
- Misses      17057    17069      +12
- Partials     4806     4810       +4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/include/ztest_assert.h
38.88% <0%> (-38.89%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
65.28% <0%> (-7.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d910aa6...d4ab582. Read the comment docs.


process-compose: 0.29.1 -> 0.29.5

Description of changes
Set up new build flags as per the maintainers directions:
https://github.com/F1bonacc1/process-compose/pull/36
AFAICT There is no good way of using fetchFromGitHub and get the proper commit/commit date data.
See: https://github.com/NixOS/nixpkgs/issues/106543
Please enlighten me if it's possible :)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

./result/bin/process-compose version
Process Compose
Version:        v0.29.5
Commit:         eb277ee
Date (UTC):     2023-01-05T23:09:30Z
License:        Apache-2.0

Written by Eugene Berger

AFAICT There is no good way of using fetchFromGitHub and get the proper commit/commit date data.

Maybe try leaveDotGit = true;, see some of the examples.

./result/bin/process-compose version
Process Compose
Version:        v0.29.7
Commit:         f180c8f
Date (UTC):     2023-01-05T23:11:57Z
License:        Apache-2.0

Written by Eugene Berger

Given the severity of the fix of the https://github.com/F1bonacc1/process-compose/issues/38 bug, I propose this gets backported to the latest stable channel.


Error adding worktree

I'm getting an error when I try to add a new worktree.
Git Worktrees: Error: Error: command: 'git -C --path-format=absolute.git rev-parse --is-bare-repository'. error: 'Command failed: git -C --path-format=absolute.git rev-parse --is-bare-repository fatal: cannot change to '--path-format=absolute.git': No such file or directory '

Any idea what's wrong?

Hi @BrianKmdy,
Can you please check your git version? If your git is outdated, please upgrade it to latest.
Please let me know if this was the issue.

Using a newer version of git worked for me, thanks! For reference I was having issues with version 2.30.2 and got it to work with 2.37.2

You are welcome.
Thank you for your reference.


Flutter SigningConfig "release" is missing required property "storeFile"

Have faced this issue multiple times now trying to build APK/App bundle with Flutter, can anyone tell what the issue is? It's saying my key.properties file is missing the store file, however it's definitely there and is 100% the correct path, looks to be either a bug in the error reporting from Flutter or the official guide is incorrect in it's setup
My build gradle:
def keystoreProperties = new Properties()
def keystorePropertiesFile = rootProject.file('key.properties')
if (keystorePropertiesFile.exists()) {
    keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
}

signingConfigs {
   release {
       keyAlias keystoreProperties['keyAlias']
       keyPassword keystoreProperties['keyPassword']
       storeFile keystoreProperties['storeFile'] ? file(keystoreProperties['storeFile']) : null
       storePassword keystoreProperties['storePassword']
   }
}
buildTypes {
   release {
       signingConfig signingConfigs.release
   }
}

My key.properties file(this is at the root of the flutter project):
storePassword=******
keyPassword=******
keyAlias=*****
storeFile=/Users/user/keystore/my_app/*****.jks

Your key.properties file should not be in the flutter root directory! Instead it should be in the android directory of your flutter project.

That code is copy & pasted from the official Flutter guide on releasing an android APK, are you saying they are wrong?

Your key.properties file should not be in the flutter root directory! Instead it should be in the android directory of your flutter project.

Typo error, it's in the android folder


Investigate CGA array attribute support

What are use cases?
Relationship to #123 ?

closing this, a minimal solution needs to be done with #146


Add Control Plane swagger for Microsoft.OpenAI

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[x] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
9/1/2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
9/1/2021
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[x] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hi @xiaomin-ms it's good to fix the warnings for the new api version in https://github.com/Azure/azure-rest-api-specs/pull/14541#issuecomment-848081803

For new services we recommend to utilize RPaaS. Please check out and use resources in the armwiki.

Did you review the new service design with ARM API Review board?
For new RP please schedule meeting with armapireview group with following agenda

Scenario overview (5-10 mins)
API Model (object/resources) (5 mins)
Flow of the scenario through the API (5 mins)

@zhenglaizhang Please help to approve again. Our target date is Nov. 11 so we didn't merge it.

Hi @xiaomin-ms it's good to fix the warnings for the new api version in #14541 (comment)

I fixed as many as I can. But some warning doesn't make sense.

Signedoff with minor comments.


updates needed for RAiDER_tutorial notebook

Each bullet corresponds to a commit

add jupyter libraries to env file for running notebooks
add wand to environment for embedding pdfs in notebook
check for heights in dataframe instead of a class variable that no longer exists
fix bug where delay was trying to load the GPS station coordinates from the (unwritten) output (wet delay) file
change the file extension from .GTiff (or whatever user specifies) to .csv when passing station_file
slant delays only save as .nc or .h5; if file extension is not one of these, change it to .nc

Note that circleci fails for an unrelated reason.
It can't seem to get the statistics from either the lat.rdr or lon.rdr files ... this works locally so i suspect it's related to the paths in the GEOM_DIR variable


Include small text description in Maintenance underneath the main rule

Type of issue

[x] Bug
[ ] New feature
[ ] Improvement

Description

Include small text description in Maintenance underneath the main rule

Code changes checked in.


Add support for src_version_id to bucket copy_key op.

This fixes an issue where copy operations fail when the source object is versioned.

Awesome, thank you!


Remove "x" from connect modal while creating database

@aguillenv so you mean the "x" button should be disabled in this page?

yes!


Typo fix in Azs.Update.Admin.md

OPS Build status updates of commit e6d42d8:
:clock10: Pending: waiting for processors (39 builds ahead of you)
:warning: OPS Build is busy, click here to report any potential performance downgrade issues, or you could view OPS Portal for trend of build queue length.

  This is the expected behavior of the build system.

OPS Build status updates of commit e6d42d8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azurestackps-1.5.0/Azs.Update.Admin/Azs.Update.Admin.md
:white_check_mark:Succeeded
View (azurestackps-1.5.0)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for your contribution!


Missing weapons

Hi, as far as I know there are missing: Aerospray PG, Squeezer Foil (both shooter).
Aerospray PG:
Same stats as Aerospray MG but having burst bombs as sub weapon and booyah bomb as special.
Squeezer Foil:
Same stats as Squeezer but having splat bombs as sub weapon and bubble blower as special.

Neo Splash-O-Matic:
Same stats as Splash-O-Matic but having burst bombs as sub weapon and suction bomb rush special.

theres a lot of things missing


Application should fail gracefully if wrong network is used

As a user, if I accidentally login with the wrong network, I should see a more graceful failure.

Prompting to change network would probably be best response
Alternatively, could show a toast prompting user to change network themselves and then retry

Another idea is that since signatures should be cross-chain by default, maybe there's a way to login user and lookup their mainnet ENS no matter what network they have selected. Ownership of an address on one network is equivalent to ownership of an address on all networks, so maybe this mismatch can be abstracted away for XMPT client purposes.

Great find and awesome submission!

since signatures should be cross-chain by default...

Indeed, as is the XMTP identity key bundle generated from the signature. AFAIK, ENS lookup is the only thing blocking the example app from being used with other networks. Prompting the user to switch to mainnet shouldn't be necessary. (Some indication of current network would be desirable).

Ownership of an address on one network is equivalent to ownership of an address on all networks, so maybe this mismatch can be abstracted away for XMPT client purposes.

It doesn't seem that a consensus has emerged yet whether ENS identities refer specifically to mainnet wallets or to all instances of that address across EVM networks. For example, the Uniswap app will only display an ENS domain when mainnet is selected, otherwise it falls back to displaying the wallet address.

Adding note to consider indicating when the user is on a network that doesn't support ENS, as they will be unable to enter ENS addresses into the address bar.
cc @darickdang

@saulmc there should be no specific reason why the ENS domain shouldn't resolve, regardless of connecting network if the reverse record for the ENS domain points to an identical Ethereum address.
ENS doesn't need to be deployed to an EVM for the ENS domain reverse record address to still work and point to the same address across EVM chains.

@galligan The specific reason why it doesn't resolve currently is that ethers depends on the wallet provider's RPC connection. If the wallet isn't connected to mainnet, then ethers isn't either, and the resolver method won't work.
It's certainly possible to work around this; we would get it for free if we used RainbowKit or ConnectKit.

This came up in our bug bash today as well -- except using Polygon. I majorly agree and would I'd love to try to make this work since messages still send as expected without ENS. Right now it just feels broken.


Expose Kd directly to user

User may not always want to use the DOC method to calculate Kd.

 PAH sensitivity meeting

Should the Kd provided always be Kd(305)? Or should we set Kd and the reference wavelength separately (perhaps with a default of 305nm)?

Should the Kd provided always be Kd(305)? Or should we set Kd and the reference wavelength separately (perhaps with a default of 305nm)?

I decided to expose the reference wavelength, so the user can set either DOC, OR Kd_ref and optionally Kd_wvl, the reference wavelength for Kd_ref (default 305nm).


Solve availability conflict error

What's to be fixed:
When user tries to book two times for the same day, Flex is returning an error.
What's the expected behavior:
It is not supposed to. We implemented a flow with them so that two user can book the same date. In the future, this should only be implemented for private space!
In addition, Flex may have implemented availability on the background.
What happens in reality (screenshot):

Priority (tag accordingly): urgent
Domain (tag accordingly): frontend
Tested on: (platform, OS, browser, version)
Branch: hotfix-resolve-conflict-date (derived from master)
Work on it

Derive the branch from master. Prefix it with hotfix-.
Tag with ongoing and move the card to ongoing.
Fix the issue
Commit your work
Create a PR and ask for validation. Move the card to staged.
Ask for validation.
Close the issue

Validate

Check on mobile and on desktop if the issue have been correctly fixed.
If everything is correct, move the card to accepted column.
If the issue isn't fixed, re-open the comment clearly what the problem is and what is the desired result. Move the card to have issues column.

Please follow https://github.com/Whichost/frontend/wiki/Git-workflow

@Shane-Walsh I updated this issues.

@lcoenen Thanks - I misunderstood the expected behaviour

Everything seems to be in order in the code: the two aliases are correctly defined in src/config.js:
// API supports custom processes to be used in booking process.
// We need to specify it when we are initiating a new order
// (or fetching price information by calling 'initiateSpeculative' endpoint).
//
// In a way, 'processAlias' defines which transaction process (or processes)
// this particular web application is able to handle.
const bookingProcessAliasPrivate = 'preauth-with-nightly-booking/release-1';
const bookingProcessAliasCommon = 'preauth-nightly-common-spaces/release-1';

and dispatched in src/containers/CheckoutPage/CheckoutPage.duck.js:
// ================ Process alias ================ //

const processAliasDecide = (listingType) =>
	listingType == 'common' ?
		config.bookingProcessAliasCommon :
		config.bookingProcessAliasPrivate;

export const initiateOrder = (orderParams, initialMessage, listingType) => (dispatch, getState, sdk) => {
  dispatch(initiateOrderRequest());

	// Transition have to react to the listing type passed downstream from CheckoutPage
  const bodyParams = {
    transition: TRANSITION_REQUEST,
    processAlias: processAliasDecide(listingType),
    params: orderParams,
  };

But yet, the transaction (on staging) is created with preauth-with-nightly-booking (version 5) even though the pub is a Common space.


django1.9 can not work in web browser

version:

python==3.4.2
django==1.9.1
django-rest-swagger==0.3.5
djangorestframework==3.3.2

django 1.8 is working,
but in django 1.9 some error found in web browser(google-chrome):
["Loaded SwaggerUI"]   swagger-ui.min.js:1
["Loaded SwaggerUI"]   swagger-ui.min.js:1
["shebang resource:account"]   swagger-ui.min.js:1
["shebang resource:account"]   swagger-ui.min.js:1

Uncaught TypeError: Cannot read property '$ref' of undefinedSwaggerOperation @ swagger.js:698
SwaggerResource.addOperations @ swagger.js:471
SwaggerResource.addApiDeclaration @ swagger.js:402
obj.on.response @ swagger.js:357
res.response @ swagger.js:1324
EventEmitter.emit @ shred.bundle.js:1391
emit @ shred.bundle.js:1191
(anonymous function) @ shred.bundle.js:1211
setBodyAndFinish @ shred.bundle.js:1815
(anonymous function) @ shred.bundle.js:1832
EventEmitter.emit @ shred.bundle.js:1388
Response.handle @ shred.bundle.js:2716
xhr.onreadystatechange @ shred.bundle.js:2584

there isn't any error warning in console.

I am having this too.  Not sure what changed, though.  The offending block is in the constuctor for SwaggerOperation when parsing the paramters:
    // for 1.1 compatibility
    var type = param.type || param.dataType;
    if(type === 'array') {
      // crash here, since "param.items" doesn't exist
      type = 'array[' + (param.items.$ref ? param.items.$ref : param.items.type) + ']';
    }

@awbacker Do you have any fix?

I just created a pull request with a very simple fix:
https://github.com/marcgibbons/django-rest-swagger/pull/431
;-)


[locale] Georgian - fixed incorrectly used word

@iJaniashvili what do you think of this?

@marwahaha looks good 👍 Thanks @torniker


n must be smaller than the index type max value

Professor, I recently learned to run OKVS in RR22. When I run the function perfPaxosImpl<8>. I use -n 1000000 to try to build an OKVS with n=1000000. But it told me: n must be smaller than the index type max value. How to solve this?

Ok, I should use <64> to run it. But I don't quite understand why? Professor can you explain briefly?

Running time? Use silver... Read the program command line help info.
Okvs with u8? As an optimization you can use a u8 as an index for the okvs. As such, your index can have values between 0 and 255. This works great if you don't exceed this range. However, n=1000000 clearly would require indexing beyond this. u32 should always work. In some cases u16 should work.
Smaller index get better running time due to it taking up less memory and getting better cache utilization.

OK, Professor. But are Silver and OKVS also connected? What I read in the paper is that Silver is the encoding of VOLE. But what I want to run is OKVS. If I run PSI, then I can directly use setMultType(oc::MultType::slv5) to make Silent VOLE use Silver encoding. But I just want to run the encoding and decoding of OKVS, is this also related to Silver? Because I actually just run perfPaxosImpl(cmd), and its total running time is 3.5 seconds. If Silver can also optimize OKVS, then how can I set the encoding of OKVS to Silver, just like setMultType(oc::MultType::slv5).

Silver is not related to okvs. If you want okvs then you can forget about silver. You should use Baxos, not Paxos.

Silver makes the psi faster. Baxos makes the paxos faster. Baxos is paxos with with the binning optimization

But, prof. I also tried running the perfBaxos function, which is supposed to run Baxos. but. It still takes me about 3.3 seconds to complete -n 1000000 encoding and decoding. is this normal? Because the whole PSI doesn't take so long, does it? But this is just a sub-process of PSI.

No, that doesn't seem normal. Hard to say what the problem is...
You can add -v to see if encode or decode is slow.
PS, I'm not a professor ;)

OK, I'll try again with -v. By the way, what should I call you? thanks for your help.

Hello, let me call you Dr. Peter for now. I used -v parameter. Got the following result. Does this show where the problem is?

No ha.  Did you build with debug?

No, I'm not running on a very slow computer. Because I only want to run OKVS, and I have installed libOTE and related dependencies locally. I directly separated the source code part of OKVS from volePSI. That is, OKVS is compiled separately, but I don't think this should have an impact on performance, right?

When you built libOTe was sse enabled? You can see this by calling the libOTe build.py and look for ENABLE_SSE.
Did you build your code in release mode?

我执行了 cmake -DCMAKE_BUILD_TYPE=Release 。 . 然后时间缩短到0.7s，非常感谢。 这与论文中非集群模式下OKVS的效率相当。 集群不起作用？ 我可以在编译 libOTE 时启用 SSE 来启动集群吗？

I executed cmake -DCMAKE_BUILD_TYPE=Release . . Then the time was shortened to 0.7s, thank you very much. This is comparable to the efficiency of OKVS in non-clustering mode in the paper. Is clustering not working? Can I start clustering with enable SSE when compiling libOTE?

Clustering is Baxos.
Sse just makes it faster in general.

OK, thank you very much. Dr. Peter.


[MINOR] De-duplicating Iterator implementations

Change Logs
Consolidating different Iterator implementations
Impact
Reducing amount of code duplication
Risk level (write none, low medium or high below)
No risk
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI is green:

https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=15043&view=results


Add rbac command to kubectl get --help

reference to https://github.com/kubernetes/kubernetes/pull/37366

This change is

@xilabao thanks for the fix. This needs a rebase and then can be merged

@janetkuo rebased

Would you rebase again? GitHub still shows that This branch is out-of-date with the base branch


partly validation is supported

Before that, RadzenStep could not be moved to next if Validation failed. This feature allows to validate only part of model in each step.
Limitations - Model is still validated and if the user moves to the next step, he will see validation messages. It would be nice to improve in the future somehow.

Hi @marekm294,
Thank you for the pull request. Would you mind also contributing a demo that shows how to use this new property?

I try to find time to do that ASAP

I hope something simple as that can be good for now. It can be always improved in the future

Hi @marekm294,
I've just checked the demo however it behaves in the exact same way if the new property is not set. Can you clarify what the purpose of that property is? RadzenSteps renders only the current step at a time so components in other steps that are required do not register for validation at all. Only the components in the current step are validated.

I am closing this request as no further feedback was provided and I couldn't understand the reasoning behind it.


[RS-1446] - Cherry pick delete permission for WAF UI

Description
WAF UI needs permission to delete applicationlayers resources.
This PR cherry picks https://github.com/tigera/operator/pull/2999 to the release-v1.32 branch.
For PR author

[X] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

I'm sorry but I failed delete the branch after merging the pull request.


dont mix tree.get and [...] accessor pattern

At the beginning of the notebook the get pattern is used, while later the brackets notation is used. Do you want to demonstrate that both things are possible?
In my opinion one should stick to one pattern (preferably the bracket notation).

The idea of the notebook is to run with every file that complies with the datamodels/single_pass_weld-1.0.0.schema
Since reference_timestamp and wx_user are optional properties the get pattern is used in these places to avoid running into errors.


Feature test rest client

I felt guilty about not fully testing the rest_client abstraction in #159
Also this testing seems to have exposed a bug in the entity service :-)

This is failing CI tests because it has identified a bug in the entity service. Will merge here and fix upstream


Delphi 10 Seattle - won't compile

[dcc32 Error] dclDelphi4PythonExperts.dpk(30): E1030 Invalid compiler directive: 'LIBSUFFIX'

@Walt1957 the "LIBSUFFIX AUTO" is only available on Delphi 10.4 and greater. Try to remove the following code from the .dpr file:
{$LIBSUFFIX AUTO}
https://docwiki.embarcadero.com/RADStudio/Sydney/en/Compiler_directives_for_libraries_or_shared_objects_(Delphi)

We made this tool backwards compatible to Delphi 10 Seattle. Can you try again, please?

Closed due to inactivity.


Add default timeout to backends / exporters to fail softly

Backends that don't have a proper timeout might wait forever thus clogging the Cloud Run scaling
Proposition:
Add a DEFAULT_TIMEOUT to each backend / exporter and make it configurable in the backend / exporter configs.

I can take in charge this implementation if you want


saucelabs1.0.1

Type: Missing
Summary:
saucelabs1.0.1
Details:
NPM license field is Apache-2.0
GitHub license is Apache-2.0: https://github.com/saucelabs/node-saucelabs/blob/main/LICENSE
Resolution:
Apache-2.0
Affected definitions:

saucelabs 1.0.1

@LandOfBliss This version of the package is under MIT as noted on the bottom of the NPM page: https://www.npmjs.com/package/saucelabs/v/1.0.1#license, and in the GitHub repo page here: https://github.com/saucelabs/node-saucelabs/tree/v1.0.1. License was later changed to Apache-2.0. I would Declare MIT. @capfei what do you think?

@AE49 I agree with MIT.


fix(run_task_threads): Add metric to capture backpressure

In order to debug backpressure being raised from run task in threads, add a new metric which captures the information. This would help triage whether the kafka doomsday alert is going off because of backpressure or not.

Not sure I follow why this is needed for debugging that specific alert. Why do you want the count of message rejected? arroyo.processor.paused.time gives you the time spend in this state, which is what we generally use instead.

Not sure I follow why this is needed for debugging that specific alert.

I was emulating what the run task with multiprocessing does over here. But you are right, I can use the metric you provided to see if the consumer gets paused or not. Will close out this PR.


Make phase info more subtle in the Task Panel

This ticket is more about providing user feedback on the visuals in the Task Panel. Currently the phase information for a task seems to dominate the task itself. When looking at the Task Panel for the first time, users are naturally drawn to the phase arrows and it is not obvious that the phase arrows are describing the status of the task in the row above.
Some helpful tweaks could be to make the font size of the row above the phase info to be larger and bolder in comparison? Perhaps making the arrows narrower and more blank padding on either side so that it looks like its "contained" within the description above?
An alternative visualization of the phases could be in "timeline form"?

Looking forward to discuss more 👍🏼
Edit: Using this document for "wireframes"
https://docs.google.com/presentation/d/1RtM44yDQmMK42UbT7T4KZrKIp74v5zExnSS9HnRzYNU/edit#slide=id.gb80df710a2_0_74

Adding more ideas:
Retain the horizontal chevron for phases

Phase info is "collapsed" by default. Clicking on a row, makes it visible

@codebot thanks for the feedback! 🙇🏼♂

https://user-images.githubusercontent.com/28668944/124895220-f042b680-e00e-11eb-96a9-08ac80397392.mp4
turns out Material UI has a collapsible table

@vallq that looks good

I think we need at least 3 design, for mobile, tablet and desktop respectively.
The collapsible table looks good but how does it work with the detailed panel at the side? They are both activated with a click and they both aim to show additional information, I feel there is a conflict in design.

my initial thoughts would be that clicking on a task row shows both the phase information and the task info rendered in the side. or that is too much?
mobile would definitely have a different design given the space constraints.. maybe a dialog pop-up to replace the detailed panel? or just the task table + phase information
just throwing out ideas~

sorry, I cut out those elements in the screen recording but it's the same as the current task panel in the dashboard! with the task information rendered on the side

@codebot @Yadunund @koonpeng is this something that we want to iterate into the dashboard now? at least for the desktop web design first

Clicking on each entry expands the information for task phases
A separate button opens up the details panel on the right
vs
Clicking on each extry expands both task phase information and the task details on the right panel (which might be a conflict in design)

I have no issues of 1 or 2, I don't think 3 is good as it is a conflict in design. Other than a conflict in design, option 3 also makes for some bad UX.

click task A to open accordion + show on details panel
click task B to open accordion + show on details panel
you want to change the details panel back to task A, clicking on the task actually closes the accordion now.

Personally I would prefer retaining the "click on entry to open panel on right". Then maybe a Details button that will expand the phase info below the entry.
Alternatively, the details panel on the right can display the phase info itself?


bump test containers version

This PR adds a new version of test containers to pom.xml

The tests don't seem to pass?

Yeah, there are a few problems with deprecations, which should be replaced... will take a look on Monday.


Separate platform-specific binaries into their own packages

As a package consumer, I would like to only download the binaries needed in my architecture, so I do not waste time and space downloading references to binaries I will never run.
This feature should not be implemented in a way which causes the end consumer of dopa-cli to handle packages directly.  Something akin to:
<!-- DOPA.Cli.csproj -->
<ItemGroup Condition="$([MSBuild]::IsOsPlatform('OSX'))">
  <PackageReference Include="DOPA.Cli.Darwin" Version="$(Version)" />
</ItemGroup>

<!-- DOPA.Cli.Darwin.csproj -->
<Target Name="DownloadOpa" />
<None Include="$(BaseIntermediateOutputPath)opa/$(OpaVersion/opa_darwin_amd64" Pack="true" PackagePath="build" />

The consuming DOPA.Cli.targets would likely need to only include a single renamed opa binary.. DOPA.Cli.Darwin.targets would need to do something similar, I imagine.

I will drag my feet on this feature, given how it will make releasing more cumbersome, and I haven't even setup auto packaging yet.

Turned out this feature made #1 easier.

To flow targets to consuming projects, will need buildTransitive, not just build.

At this time, I am unaware of a way to make a conditional nuget meta package.  The dependencies are either all included, or not included at all and the consumer needs to choose the platform-specific targets.
Doing this:
<ItemGroup Condition="$([MSBuild]::IsOsPlatform('OSX'))">
  <PackageReference Include="DOPA.Cli.Darwin" Version="$(Version)" />
</ItemGroup>

does work in a project directly.  But, putting it in a project, and then packing that project into a new package will result in only the 1 working dependency being packed. The other conditionals would be excluded.
Given OsxProject and WindowsProject, a new project A could look like this:
  <PackageReference Include="OsxProject" Version="1.0.0" Condition="$([MSBuild]::IsOsPlatform('OSX'))" />
  <PackageReference Include="WindowsProject" Version="1.0.0" Condition="$([MSBuild]::IsOsPlatform('Windows'))" />

And project A would compile, and its tests would pass on either OSX or Windows. Calling dotnet pack from Windows would result in a nuspec, and build files, that list WindowsProject as a <dependency> but not OsxProject.  Removing the conditionals make the nuspec dependency list correct, but as there is no way to specify optional nuget dependencies, they will all be restored - effectively preventing the original goal of this issue: not downloading binaries I won't use.
If the situation changes in the future, I may revisit this.


guestnetworks: check ifname uniqueness across different networks

这个 PR 实现什么功能/修复什么问题:
With PerformChangeIpAddr, it can happen that a guestnetwork from network
A can take a name that was originally allocated by network B

是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @ioito @swordqiu

/lgtm

/lgtm
/approve


playground does not work

I just cloned fresh version and playground does not work: it does not find/compile/place index.js file.
@bampakoa after quick investigation I did not find the place, maybe you have an idea?

It seems that this line causes the problem but I have not find why this is happening.

I think it's something with systemjs

If you use the UMD module, it will create the index.js file inside .playground folder. 😕

fixed


Opt out of PyCell borrow tracking

As suggested in https://github.com/PyO3/pyo3/issues/1068
This exposes an api like this:
#[pyclass]
pub struct Foo {
    #[pyo3(get)]
    field: u32,
}

#[pyclass(mutable)]
pub struct Bar {
    #[pyo3(get, set)]
    field: u32,
}

pub unsafe trait MutablePyClass: PyClass {}

pub struct PyCell<T>;

impl<T> PyCell<T>
where
    T: PyClass,
{
    pub fn borrow(&self) -> PyRef<T>;
}

impl<T> PyCell<T>
where
    T: MutablePyClass,
{
    pub fn borrow_mut(&self) -> PyRefMut<T>;
}

This is done by redirecting the borrow implementations through PyClass, which the PyCell implementation calls internally.
The default implementations for these don't check the borrowflags.
If the user declares #[pyclass(mutable)], then the macro:

replaces PyClasss default impls with impls that actually track the borrowing
implements  MutablePyClass, so that the mutable borrow methods become available.

Short of specialization, I think this is the best way to approach this.
An open question is:

Perhaps this opt-out could be #[pyclass(immutable)] ?
Though TBH I think I prefer immutable-by-default, so perhaps we should have #[pyclass(mutable)] to opt-in to PyCell!

This is a breaking change for a lot of pyclasses, which opt-in to immutable would avoid. However I like Rust's immutable-by-default.

I fully agree that #[pyclass(mutable)] is a desirable end state (and that immutable-by-default is better), however I think we need to phase this in gradually so that users can have time to migrate.
If we keep mutable-by-default for now and introduce #[pyclass(immutable)] then we can add this as an additive feature while we're iterating and improving it. Then eventually we can emit deprecation warning and finally swap over to immutable-by-default.

That is a good idea.

Also, I'd be really curious to find out about performance impact, if any!

From my (naive) test using the above structs, field access from Python is about 2-3% faster.
This is quite hard to test. In a realistic scenario the performance impact of borrow checking is probably vanishingly small compared to everything else. I'm not good at testing - I'm hoping someone else gives it a try.

I just realized we probably also want an api like:
impl<T> PyCell<T>
where
    T: ImmutablePyClass,
{
    pub fn borrow_unguarded(&self) -> &T;
}

So that's yet another new trait...

We could also use Deref for this.

So that's yet another new trait...

We might be able to use a blanket impl of something like impl<T> ImmutablePyClass for T where T: PyClass<BorrowChecker = Immutable>. Maybe similar for MutablePyClass too.
(Where the BorrowChecker trait is the one the abstracts the behaviour above.)

We could also use Deref for this.

I was thinking about making PyCell<Subclass> deref to PyCell<Baseclass>, and a similar set of new deref implementations for native types (e.g. PyBool -> PyInt), so would rather not use deref here.

From my (naive) test using the above structs, field access from Python is about 2-3% faster.
This is quite hard to test. In a realistic scenario the performance impact of borrow checking is probably vanishingly small compared to everything else. I'm not good at testing - I'm hoping someone else gives it a try.

TBH that sounds about right, probably over time we might find things can improve even further. There's also the memory saving where in theory we don't need to make space for the borrow flag on immutable classes.

We might be able to use a blanket impl of something like impl ImmutablePyClass for T where T: PyClass<BorrowChecker =
Immutable>. Maybe similar for MutablePyClass too.

This requires making pyclass generic - not sure if that is desirable.
I've changed it around to be opt-in to immutable:
#[pyclass(immutable)]
pub struct Foo {
    #[pyo3(get)]
    field: u32,
}

Todos:

[ ] Make sure people can't implement immutable + extends/unsendable at the same time
[ ] Docs
[ ] More tests
[ ] A safe method to get &T

Sorry will try to review this tomorrow!

I'd like us to try to aim to avoid using the memory for the BorrowFlag in the immutable case

I think that means PyCellBase has to be generic over mutability, right?
Something like
mod impl_ {
    use core::cell::Cell;
    struct BorrowFlag(usize);

    pub trait Mutability {
        // ...
    }

    pub struct Mutable {
        flag: Cell<BorrowFlag>,
    }
    impl Mutability for Mutable {}

    pub struct Immutable;
    impl Mutability for Immutable {}
}

use impl_::{Immutable, Mutability, Mutable};

#[repr(C)]
pub struct PyCellBase<T, B: Mutability> {
    ob_base: T,
    borrow_flag: B,
}

I've tried to do those things, but I don't understand how to fit everything together.
the part 1 commit works, but is by default mutable.

Thanks, sorry if my idea has turned out to be ill-thought-out. I'll try to find some time to look into this in detail over weekend or end of Monday at the latest.

Thanks, sorry if my idea has turned out to be ill-thought-out. I

I think it can work - it does however infect a lot of other traits which makes the implementation quite tricky.

I'll try to find some time to look into this in detail over weekend or end of Monday at the latest.

Whenever you are ready :)
I just pushed some changes that I think are the correct way to go, but there are some trait bounds that I can't quite figure out at this point.

I'm finally having a play with this branch this morning - not sure how quickly I'll be able to finish it off :)

Ok, I went through a fairly painful rebase and pushed a commit which looks viable. I think we might still want to play around with this a bit before it's merged, however it's definitely unblocked now :)

Ok, I went through a fairly painful rebase and pushed a commit which looks viable. I think we might still want to play around with this a bit before it's merged, however it's definitely unblocked now :)

Thanks 🙏
What else needs doing? I notice it doesn't work on msrv, I'll try to fix that...

Ah, that MSRV failure looks frustrating. I think I might have also broken a doc somewhere along the way looking at the coverage failure.
Given that this rearranges our traits a fair bit, I'm tempted to hold back on this until after 0.16 is cut so that we can play around with it on the development cycle towards 0.17. So no need to rush to get this done ASAP.

Uh...it seems like this is incompatible with Rust 1.48? 😭

Ugh, yes it looks like the older compiler can't handle the complexity of the trait bounds.
I wonder whether some other cleanup and refactoring might unblock this, though it's not obvious what.
Also, given that the traits which seem to be problematic are related to the fact that only mutable classes can be base types in this model, I wonder if we flesh out the rules on how mutability interacts with inheritance if that'll unblock the older compiler.

It works on rust 1.49, which is really frustrating.
Any chance of a msrv bump (or a bumplet) with 0.17? 🥺

You know what the policy is...

Yeah as much as "one more version" feels approachable it would drop support for Debian, which I think would upset a lot of people.

Oh right, Debian will be stuck on 1.48 for at least a year :(

I'm hopeful that if we define the semantics of inheritance in combination with this feature then we might be able to refactor traits enough to avoid whatever feature confuses Rust 1.48.
I think the correct approach would be to go along the lines of #[pyclass(dict)], where the dict slot gets placed in the first child in the inheritance hierarchy which includes the annotation. So in this case, the borrow flag would be placed with the first mutable class, and then that borrow flag is shared between that and all children. (All parents would be immutable and not need to care about the flag.)
I'm happy to try to push a commit to implement that strategy and see if it fixes things?

I'm happy to try to push a commit to implement that strategy and see if it fixes things?

That would be greatly appreciated! I'm actually not at all familiar with how we implement inheritance 😅

Ok, so I think I've managed to push something which works... let's see if the 1.48 tests pass this time 🤞
The commit itself is a bit messy, I tacked a new set of structs and traits alongside the stuff already implemented here so that I could work in pieces rather than break everything and lose myself in a sea of compile errors.
So I don't forget, these are things which should be cleaned up:

[ ] I moved a few associated types from PyClass to PyClassImpl (i.e. make them not public). This was necessary to allow some other trait bounds to be just on PyClassImpl. I think this is fine to do, however we should mention in the CHANGELOG.
[ ] I added a second associated type in PyClassImpl - Mutability and PyClassMutability. It should be possible to just have one.
[ ] Documentation for how the new traits work.
[ ] Documentation for #[pyclass(immutable)] in the guide.
[ ] Might be nice to benchmark / optimise these new code paths.
[ ] Now that it's not actually doing borrow checking in the immutable case, I'd like to propose renaming PyCell<T> to PyClassObject<T>.

Given that this is now a big hefty branch which is getting harder to rebase, I suggest that if CI passes we merge this branch now and then you and I can more easily work on the items above in parallel as we work towards 0.17.

I'm actually not at all familiar with how we implement inheritance 😅

Essentially PyCell<T> where T extends U contains a valid "layout" of U as its first member. The PyClassImpl and PyClassBaseType traits working in tandem then handle the logic of how the PyCell behaves. It's hard, and poorly documented - as part of this work I can reorganise it to make it easier for others to follow.

Oh darn, it now fails later on, but still fails. I'll keep trying...

Hooray, looks like this works! Rust 1.48 definitely doesn't seem to be as comfortable with the trait bounds, but with some effort it compiles.
Are folks ok if I merge this as-is and open a tracking issue with the list of items above for us to complete by 0.17?

Actually looking at this again briefly this morning I'll try to push a cleanup commit first.

Given that this is now a big hefty branch which is getting harder to rebase, I suggest that if CI passes we merge this branch now and then you and I can more easily work on the items above in parallel as we work towards 0.17.

Yes please 🙏  No more resolving merge conflicts.


Update dockerhub org name to aeternity

The builder image is already pushed under the new org.
I also copied the latest and v0.9.0 docker images to the new org.
In scope of https://www.pivotaltracker.com/story/show/155940263

I also copied the latest and v0.9.0 docker images to the new org.

Could you push v0.8.0 too? I saw some Devs still using it.

Could you push v0.8.0 too? I saw some Devs still using it.

Interesting. Pushed.


pixi run confusing error when a command with spaces is passed inside a vector

Problem description
Reproduce:
git clone -b patch-3 https://github.com/traversaro/pixi
cd pixi/examples/ctypes-factorial/
pixi run compile

The resulting error is:
traversaro@IITBMP014LW012:~/pixi/examples/ctypes-factorial$ pixi run compile
✨ Pixi task (default): "gcc -shared -o src/factorial.so src/factorial.c"
Error launching 'gcc -shared -o src/factorial.so src/factorial.c': No such file or directory (os error 2)

The actual problem is that the command with space is contained in a vector instead of being directly assigned to cmd (I created this on purpouse in https://github.com/traversaro/pixi/commit/9a5c2ced077595ee67e9f03cb232fe6b52226458), however it is not obvious to understand this from the error (at least, not to me that I spent some time to understand this in a similar example).

I think you want the same thing as this issue #837

To be honest, I am not sure how to solve, I just spent ~10 minutes tryng to figure out what this error was about, and I thought it was worth reporting it. I guess possible solution are either:

Have a more clear error message
Have compile = {cmd = ["gcc -shared -o src/factorial.so src/factorial.c"]} be equivalent to compile = {cmd = "gcc -shared -o src/factorial.so src/factorial.c"}

I guess from the point of view of this issue, both are solutions are fine.


I run anchor --version with avm install latest and got an error zsh: command not found: anchor

I run avm install latest and then avm use latest and then add $HOME/.avm/bin to PATH and then run anchor --version and  got an error zsh: command not found: anchor, but I can run anchor-0.30.1.

Do you also have $HOME/.cargo/bin in your PATH?

Yes, but there is no anchor in $HOME/.cargo/bin

$HOME/.avm/bin only has anchor-0.30.1.
$HOME/.cargo/bin has rust and cargo related programs and avm

How did you install avm? The default installation should come with both avm and anchor binary in ~/.cargo/bin.

I ran cargo install --git https://github.com/coral-xyz/anchor avm --locked --force and then ran avm install latest to install anchor

Weird. That command should also install the anchor binary because avm has two binaries:
https://github.com/coral-xyz/anchor/blob/c679b2782e55a1c11675fca2aeb692bb0fe7a7ea/avm/Cargo.toml#L6-L12
I've just tried it and it created the anchor binary too, so I'd try running it again.

I reinstalled avm to see if this problem still exists


sitslive.txt

Please Add sitslive.com

@RahulChaudharySitsLive Please provide us with:

the university official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the university
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the students.

@RahulChaudharySitsLive You might miss my previous comment. Please react.

@RahulChaudharySitsLive I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the abovementioned issue. Thank you for the understanding!


[BUGFIX] Rename textrole template

"unknown" hat the second n missing, thanks to @brotkrueml for pointing this out

Merging as non-brainer


x/pkgsite-metrics: build failures on aix and solaris since CL 464635

CL 464635 (attn @julieqiu, @jba) added a dependency on github.com/go-git/go-billy, which seems to rely on the not-quite-portable flock system call. It fails to build on both the aix and the solaris builders:
https://build.golang.org/log/16e55aaaf5cd0530197e39196e8b5574ce26d1d5
aix-ppc64 at fcd0e0963f3bdf289216c1083f1439a71dc571a4 building pkgsite-metrics at 4260eec4c420289d41ba5777be826919d16b4408
…
# github.com/go-git/go-billy/v5/osfs
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:15:14: undefined: unix.Flock
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:22:14: undefined: unix.Flock
?   	golang.org/x/pkgsite-metrics/cmd/worker	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/derrors	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/observe	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/proxy/proxytest	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/testing/testhelper	[no test files]
go version devel fcd0e0963f3bdf289216c1083f1439a71dc571a4 aix/ppc64
Checking go and sh files for license header
go vet -all ./...

# github.com/go-git/go-billy/v5/osfs
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:15:14: undefined: unix.Flock
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:22:14: undefined: unix.Flock
command failed
Installing: github.com/client9/misspell/cmd/misspell
⋯
FAILED; see errors above
--- FAIL: Test (41.70s)
    all_test.go:26: exit status 1
FAIL
FAIL	golang.org/x/pkgsite-metrics	41.754s

https://build.golang.org/log/1cef20b2732f80f0dc5839208b565552e0c9d0ab
solaris-amd64-oraclerel at 01a5a83cfbe594538f6fe9f49bd27d9dc36155a4 building pkgsite-metrics at 4260eec4c420289d41ba5777be826919d16b4408
…
# golang.org/x/pkgsite-metrics/internal/stdlib.test
/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
Undefined			first referenced
 symbol  			    in file
flock                               /opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/go-link-1706862252/go.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
…
FAIL	golang.org/x/pkgsite-metrics/internal/stdlib [build failed]

This can be addressed by either fixing the build on those platforms or, if x/pkgsite-metrics intentionally does not support them, by configuring cmd/coordinator not to test that repo on them.

Fixed in https://go-review.git.corp.google.com/c/pkgsite-metrics/+/465217


Create Ballerina coding convention guide

@sameerajayasoma we currently have a style guideline that only contains the formatting guidelines ...
we aim to develop this guide to have other coding conventions such as naming, error handling, etc (https://github.com/ballerina-platform/ballerina-lang/issues/15222)...
WDYT?


Change Tensorsize of registed buffer in module

Hello,
Is where a way to change the buffer size of a registerd buffer in a module?
Thanks in advance
Michael Sprinzl

Oh thank you Niklas, this really helps. This is cool. Now I can map and change models like a champ.


Make Pie installable from pip and update PyTorch

First commit is about #16 . The only change (available in commit 2) to the code was made to respond to a deprecation on size_average=True, moved to reduction='mean' : https://pytorch.org/docs/stable/nn.html#torch.nn.CrossEntropyLoss
Second commit is reworking the whole structure of script to make it accessible [ #17 ].

All original scripts are accessible using python pie/scripts/name_of_scripts.py . That will make development and research as simple as before. But, if you install from pip, you can access everything using pie [COMMAND]. The CLI was built with Click which I find very efficient for this kind of little things. Old CLI will not require this dependency, they are still using ArgumentParser.

Overall, I think it's a great step into making Pie usable in research pipelines !

Just updated the PR to target /dev instead of master.
You can test this in any virtualenv using pip install https://github.com/PonteIneptique/pie/archive/setup_py.zip

Thanks, I've added some comments. I am a bit busy now to test it (hopefully
next week). I like it overall but there is a bit of code reduplication that
I'd prefer to cut out (basically adding pie to path manually in each script
and the commit_build.py). If you can respond to the comments we can move
the discussion over there.
On Wed, Feb 20, 2019 at 1:32 PM Thibault Clérice<EMAIL_ADDRESS>wrote:

Just updated the PR to target /dev instead of master.
You can test this in any virtualenv using pip install
https://github.com/PonteIneptique/pie/archive/setup_py.zip
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/emanjavacas/pie/pull/19#issuecomment-465555244, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF6Ho43X-fPPkVpJ6CTsWuBxpIjZ4g4Kks5vPUBBgaJpZM4bFGGJ
.

--
Enrique Manjavacas

and thanks for the quick answer.

Updated according to our current discussion. The rest will come with your decision upon commit_build and requirements.txt

I did not make any notice but the PR is done on my end ;)

Hey, I am testing it. Just did pip install https://github.com/PonteIneptique/pie/archive/setup_py.zip which installed fine. I am now trying some of the scripts with pie evaluate, etc... but keep getting:
Traceback (most recent call last):
  File "/home/manjavacas/code/python/test/bin/pie", line 11, in <module>
    load_entry_point('pie==0.2.0a1', 'console_scripts', 'pie')()
  File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/__init__.py", line 487, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2728, in load_entry_point
    return ep.load()
  File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2346, in load
    return self.resolve()
  File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2352, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'pie.scripts'

Could you look into it and perhaps give a MWE? Also it'd be cool to write a help on the available commands if you install through pip: perhaps pie help or just when typing pie. But not sure if that'd be too much work?

You can do pie --help.
For the other issues, it seems weird. I am afk the next 10 days but will
try to have a look
Le jeudi 28 février 2019, Enrique Manjavacas<EMAIL_ADDRESS>a
écrit :

Hey, I am testing it. Just did pip install https://github.com/
PonteIneptique/pie/archive/setup_py.zip which installed fine. I am now
trying some of the scripts with pie evaluate, etc... but keep getting:
Traceback (most recent call last):
File "/home/manjavacas/code/python/test/bin/pie", line 11, in
load_entry_point('pie==0.2.0a1', 'console_scripts', 'pie')()
File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/init.py", line 487, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/init.py", line 2728, in load_entry_point
return ep.load()
File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/init.py", line 2346, in load
return self.resolve()
File "/home/manjavacas/code/python/test/lib/python3.6/site-packages/pkg_resources/init.py", line 2352, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
ModuleNotFoundError: No module named 'pie.scripts'
Could you look into it and perhaps give a MWE? Also it'd be cool to write
a help on the available commands if you install through pip: perhaps pie
help or just when typing pie. But not sure if that'd be too much work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/emanjavacas/pie/pull/19#issuecomment-468407015, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1yZvxgaVRqeRI7XEo-fdivjr94_oYaks5vSC9MgaJpZM4bFGGJ
.

I am unable to replicate your issue right now, before the flight.
My process is :
virtualenv pieenv -p python3.6
source pieenv/bin/activate
pip install https://github.com/PonteIneptique/pie/archive/setup_py.zip
pie --help # Gets the available commands
pie tag ./path/to/model path/to/text.txt

And it just runs. I have tried on two different linux machine but did not try on Mac.

Hi,
sorry it was my bad, python was picking my local version of pie in the
python path. It works now, but I keep getting the warning:
fatal: not a git repository (or any of the parent directories): .git
WARNING:root:
    It seems like you download `pie` instead of git-cloning it or
installing it with pip.
    We won't be able to check compatibility between pretrained models and
`pie` version

although I did pip-installed it. Once that's done we can submit it to pypi.
Thanks for this PR!
On Fri, Mar 1, 2019 at 8:02 AM Thibault Clérice<EMAIL_ADDRESS>wrote:

I am unable to replicate your issue right now, before the flight.
My process is :
virtualenv pieenv -p python3.6source pieenv/bin/activate
pip install https://github.com/PonteIneptique/pie/archive/setup_py.zip
pie --help # Gets the available commands
pie tag ./path/to/model path/to/text.txt
And it just runs. I have tried on two different linux machine but did not
try on Mac.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/emanjavacas/pie/pull/19#issuecomment-468565245, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF6Ho-jnp3jJ5-c4OiLFn13rg98EU70Nks5vSNCAgaJpZM4bFGGJ
.

--
Enrique Manjavacas

This should go away as soon as you'll do python setup.py upload as the upload script will add the current commit sha to the python file. Installing it via archive download cannot do that :)
That's also a reason why I added the a0 at the end of the version, to be sure this would work before releasing a stable 0.2.0.

Referring to this : https://github.com/emanjavacas/pie/blob/96dab614c6d62c9a60ec8209f71b9af4f30d11e5/setup.py#L92-L98
Note that the upload could be tied with Travis which would be quite cool. This is how I did for numerous of my libraries, to avoid duplicating releasing efforts.

merged!

Regarding one of your last comment, updating the Readme for the right
command could be a good idea.
Le ven. 1 mars 2019 à 12:03 PM, Enrique Manjavacas<EMAIL_ADDRESS>a écrit :

merged!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/emanjavacas/pie/pull/19#issuecomment-468628942, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1yZnnkYqXcrAfXgk2jNoqp0CdvnPRzks5vSQjpgaJpZM4bFGGJ
.


Offline #8: git prune-branches

All comments addressed

All comments addressed

Yes, I noticed that 1 SECOND after sending the last round of reviews to you, but that was too late already  :)


Remove-SqlDatabase in internals has better alternatives

Copy-DbaDatabase, Test-DbaLastBackup, Remove-DbaDatabaseSafely should switch to Remove-DbaDatabase.

In reference to Copy-DbaDatabase what portion or action would you replace with the remove command?

Just did a quick text search of remove-database. If copy-dbadatabase has no
references to it my bad, my eyes crossed.
Il 29 nov 2017 2:29 AM, "Shawn Melton"<EMAIL_ADDRESS>ha
scritto:

In reference to Copy-DbaDatabase what portion or action would you replace
with the remove command?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/2742#issuecomment-347722140,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHdB8Ba4DfjF7EIaLMvf_52qv2dQVZHks5s7LNlgaJpZM4QuBS5
.

as it turns out, Copy-DbaDatabase does not has a reference to Remove-Database. Sorry!

it probably does an inadequate .drop() - Remove would fa sho remove.