2.8.1 Jshint

Hi there,
Everything seems to working well with v2.8.1 but if I choose the JSHint option I'm getting this error for the task runner:
cmd.exe /c gulp --tasks-simple
module.js:338
    throw err;
          ^
Error: Cannot find module 'jshint/src/cli'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (D:\Programming\Projects\AspNetMvcBoilerPlate\test\test\node_modules\gulp-jshint\src\extract.js:1:79)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)

It could be related to this:
http://stackoverflow.com/questions/33984558/gulp-error-cannot-find-module-jshint-src-cli

Actually I resolved the error I had to run this command:
npm install jshint gulp-jshint --save-dev

That's weird, it's been working for me. This issue suggests that the JSHint package should be added or you can use the above approach which is a bit manual. I'll do some testing...

Just tried creating a new project on a separate machine and it seems fine. Is there something you are doing that's different?

I just tried it again with a new solution and I get the same problem, what npm version are you using?
I'm using v3.3.10

Just as a side note the the https issue I was getting with firefox is still there, I might open a new ticket for that one

Have you tried three instructions in the ReadMe. Delete the node_modules folder and do a npm clear cache?

I will give that a go, but the when I create a new solution there aren't any node_modules ? or do you mean from my users directory?

The node_modules folder gets created and populated on project creation when VS does a package restore. The trick is to shut down VS, delete this folder and also clear the npm package cache. The whole thing seems a bit flaky and I have seen packages get corrupted sometimes.

Any luck?

I need to test this still

Not sure what to say, I've tried on three machines multiple times and it's been ok. If you do find out what the problem is or if you find a solution, please post it here and I'll update the template.

I think I traced the error down to npm.
If I use npm 2.x then everything is fine
If I use npm 3.x where an error occurs

I also installed NPM 3 on one of the machines I tested on and it worked fine. Did you try downgrading gulp-jshint?

sorry how do u downgrade gulp-jshint? do you have the command handy?

Just lower the version number in package.json.

I'm closing this. Re-open if you find out what the problem was.


Populate the SignedObject with the information about signed image/artifact

The SignedObject object returned when signing and verifying images/artifacts signed with the sign package is currently empty. We should put some information about the signed artifact in that object, so consumers can use it for validation or exposing that information to users.
We can include information such as:

SHA/digest of the signed image/artifact
Link to the signature (.sig) file

Eventually, we might want to include other information as needed.

/assign

@xmudrii do you already had a chance to start working on this? :)

@saschagrunert I'll try to work on it this week.

I'm currently super busy with the university, so I'll unassign myself and someone else can take over.
/unassign

@cpanato do you wanna take this or should I take care of it?

@saschagrunert I can work on that
/assign

@xmudrii no worries!


riscv/bl602: Enable GPIO output

Summary
BL602 GPIO Driver doesn't configure the GPIO Output Enable Register for GPIO Output Pins.
So calling the GPIO Driver bl602_gpiowrite() to set the GPIO Output has no effect.
We fix this by updating the GPIO Output Enable Register for GPIO Output Pins in bl602_configgpio().
More details here
Impact
This fix impacts the pins configured for GPIO Output on BL602.
Previously GPIO Output Pins could not be set to High / Low when we call bl602_gpiowrite().
Now the GPIO Output Pins are set to High / Low correctly when we call bl602_gpiowrite().
Testing
Tested on Pine64 PineCone BL602 board, with the onboard Blue LED.
More details here

Thank you @lupyuen it is a pleasure to see you here! Thanks for your contribution!

Thank you Xiao Xiang, Alan, Brennan and everyone maintaining NuttX... You're awesome! 👍😀


markdown to draft: links, mentions, and strikethrough not preserved (typescript)

hi there,
i noticed that although the standard styles like headings, bold, and italics are supported i am still unable to render mentions, links, or strikethrough properly.
this is the code line i use to extract editor content as markdown (to then store in a DB):

draftToMarkdown(convertToRaw(editorState.getCurrentContent()));

this is the code im using to render it back up as readOnly

const rawData = markdownToDraft(note.note, {
remarkablePreset: 'commonmark',
remarkableOptions: {
enable: {
inline: ['links', 'emphasis'],
core: ['abbr']
}
}
});
const contentState = convertFromRaw(rawData);
const editorState = EditorState.createWithContent(contentState);
...
<Editor editorState={editorState} onChange={() => {}} readOnly={true}/>

i noticed when displaying previously saved strikethrough text, the text was bounded by '~~' , links just appear as normal text, and mentions dont seem to be registered as links to the drafToMarkdown conversion (?)

Hello 🙂
Something like mentions you'd need to define your own rules for, since it isn't supported by markdown normally, which isn't included in your code here.  You can checkout my README, and @danielsnider kindly added some additional information on how one might go about this here - https://github.com/Rosey/markdown-draft-js/issues/116 (he also opened a PR to update the readme but I'm a bit behind on issues right now.)
Something like links: Is the issue that the draft readonly editor isn't including it? It seems you aren't passing in any decorators, which would be required for properly displaying links in a draft editor. (example code - https://github.com/facebook/draft-js/tree/master/examples/draft-0-10-0/link)
Hopefully this is helpful!


Support custom banner logo and doc background

While this asciidoctor backend is designed for Spring, I find it so great that I want to use it for non-Spring projects.
For that, it would be great if the banner-logo and the doc-background could be customized.
While the background is already available in light and dark flavors, this would also be great for custom logos.

Thanks for the suggestions. This is a duplicate of #24.


Make WSL(2) script for CTF box

Done partly with this repository: ubuntu-wsl2-systemd-script. I consider it good enough for now. Closing.


Allow link address to be overridden in createSender()/createReceiver()

Addresses #277 by reordering the policy merge parameters on createSender() and createReceiver(). With this change, it is possible to override the source address to be overridden on createSender() and the target address on createReceiver(). This is relevant for use cases such as AMQP request/response.
The opposite address can already be overridden by other means, so it was not moved.

superseded by #279


[Feature]   create new functions such as current_timestamp, current_date

…amp funcation
like spark and presto
What type of PR is this：

[x] Feature

Which issues of this PR fixes ：

Fixes
https://github.com/StarRocks/starrocks/issues/15382
https://github.com/StarRocks/starrocks/issues/15285
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[ ] 2.2

[FE PR Coverage Check]
:disappointed: fail : 4 / 7 (57.14%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
4
7
57.14%
[4548, 4549, 4552]

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 6 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
6
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
4
75.00%
[4552]

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 7 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
7
85.71%
[4605]

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 7 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
6
7
85.71%
[4605]

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
3
3
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-2.5


fix: fix 4964(Windows drive letter inconsistency)

Signed-off-by: CGQAQ<EMAIL_ADDRESS>
Description
fixed #4964
fixed #4912
This is what main branch code will be like, mixup uppercase and lowercase drive letters

Now it will works perfectly!

What is the purpose of this pull request?

[x] Bug fix

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Ready for review


ISPN-13703 (main) test and fix for clustered DIST_SYNC transactional ca…

…che fails for a non owner node

Integrated into main, thanks @tomdearman !


The commit message prefix does not take effect

:memo:  Brief description

The commit_prefix option is set in the configuration, but it is not displayed in the generated commit message.

:warning: Checklist

[x] Provided a clear and concise description of what the issue is.
[ ] Given a clear and concise description of what is expected.
[ ] Proposed a clear and concise description of any alternative solutions or other features.
[x] Added any other context or screenshots about the feature request.
[ ] Associated pull request has been already created and link was provided.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

Hello. Thank you for reaching out.
This is in fact an expected behaviour since commit_message is evaluated before commit_prefix.
Here is a code handling that https://github.com/devops-infra/action-commit-push/blob/master/entrypoint.sh#L58
I'll add a small explanation to the readme file.

@ChristophShyper
Okay, I understand the cause of the problem, thank you!


[BUTTON IDEA]: Bubble effect button

1. Name of button:
Bubble effect button
2. Description:
After hovering onto button it will change color and small bubbles will come out of it once.
3. Button Type (Animated, Special, etc...):
animated
4. Will you work on it?:
Yes

I want to take this up

I want to take this up

Actually, I created this issue because I want to work on it. Hope you understand.

@ankitaugale23 sorry sure mybad :)

you can work on another issue @Dheerajbana or make one

thanks @isonnymichael  :)

Looks like a good idea @ankitaugale23 you may work on it.

I am taking some time because I have worked in pure CSS and I am a beginner in less. Hope you understand. I will complete my task asap!

@ankitaugale23 it's ok take your time with it. Issues with low priority are not rushed so you can use this to learn Less well!

Thank you so much! one question that I have js included in my button's functionality could you please guide me in which file should I add that. I read the contributing.md file but I still didn't get it. Could you please clear my doubt?

@ankitaugale23 our project is CSS only. Please refrain from using javascript for your button's implementation. What are you using the javascript for?

For the animation to creates the bubble while taking care of mathematical parameters to generate the bubbles. If there is an issue in having JS then I will change the functionality of button a little bit.

@ankitaugale23 yes, please change into pure CSS only

Hi @ankitaugale23 any update on this?

Unassigning this to give other contributors a chance. if you still want to contribute @ankitaugale23 you can submit a PR.

Hi @shahednasser  I would love to work on this

Sure @3stherMueni I'll assign you

am Hi @shahednasser. Am still working on this, am a little slow because I don't have much experience on css but I sill complete it Asap. I hope you understand

Sure @3stherMueni no problem


Move to Egeria 4.1

I do not know why codeQL was enabled - I agree it should not be required - particularly as it is not working :)

After close/open, the codeQL action was kicked off. However it failed.
  [2023-06-07 08:31:23] [autobuild] Execution failed for task ':asset-deploy:compileJava'.
  [2023-06-07 08:31:23] [autobuild] > error: release version 17 not supported

I tried building the PR locally.
One warning
> Task :buildHealth
There were dependency violations. See report at /Users/jonesn/IdeaProjects/egeria-dev-projects/build/reports/dependency-analysis/build-health-report.txt

cat /Users/jonesn/IdeaProjects/egeria-dev-projects/build/reports/dependency-analysis/build-health-report.txt
Advice for :asset-deploy
Unused dependencies which should be removed:
  implementation 'org.odpi.egeria:ocf-metadata-client:4.1'

Advice for :asset-look-up
Unused dependencies which should be removed:
  implementation 'org.odpi.egeria:ocf-metadata-api:4.1'
  implementation 'org.odpi.egeria:ocf-metadata-client:4.1'

Advice for :asset-set-up
Unused dependencies which should be removed:
  implementation 'org.odpi.egeria:asset-consumer-api:4.1'
  implementation 'org.odpi.egeria:asset-manager-api:4.1'
  implementation 'org.odpi.egeria:asset-owner-api:4.1'
  implementation 'org.odpi.egeria:data-manager-api:4.1'
  implementation 'org.odpi.egeria:digital-architecture-api:4.1'
  implementation 'org.odpi.egeria:it-infrastructure-api:4.1'
  implementation 'org.odpi.egeria:ocf-metadata-api:4.1'
  implementation 'org.odpi.egeria:ocf-metadata-client:4.1'
  implementation 'org.odpi.egeria:open-integration-framework:4.1'
  implementation 'org.odpi.egeria:platform-services-api:4.1'

Advice for :egeria-config-utility
Unused dependencies which should be removed:
  implementation 'org.odpi.egeria:audit-log-framework:4.1'

Advice for :egeria-ops-utility
Unused dependencies which should be removed:
  implementation 'org.odpi.egeria:open-connector-framework:4.1'

In core egeria the top level build.gradle sets us up to fail when a dependency violation occurs
This is done by ensuring this is set
 // Dependency checking - see https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin
 dependencyAnalysis {
     issues {
         all {
             onAny {
                 severity('fail')
             }
         }
     }
 }

I appprove the change, but suggest we do

Make the codeQL check optional for now (settings/branch protection rules/main -- remove the codeQL variations) - but at this point only DCO is checked
Make the healthcheck dependency validation mandatory, and correct the reported issues
Fix the codeQL build to do an explicit compile (validate wrapper, and use official gradle action)
Consider adding a regular build script which is similar, but does not run codeQL (there is some duplication, but you could then make the codeQL check optional, and core build mandatory)

Let me know if you need any advice/help with the above.


[stable/prometheus-postgres-exporter] Allow specifying a securityContext

Allow specifying a securityContext
What this PR does / why we need it:
This enables users running under restrictive PodSecurityPolicies to deploy the exporter running as a non-root container.
Which issue this PR fixes
N/A
Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign
/ok-to-test
/lgtm
thanks for contributing!


update dependencies

Purpose

To-do

Content

[ ] I have read and checked the items on the review checklist.

This increases allocation for two jobs: https://buildkite.com/clima/climaatmos-ci/builds/21348#_ Any idea why?


Fix/WebSocket

fixes #623
No need to do remove(self) explicitly, WebSocketServerProtocolHandler removes handlers that are not required for WebSocket connections.
From Netty in Action:
To maximize performance WebSocketServerProtocolHandler will then remove any ChannelHandlers that aren’t required for WebSocket connections.

🚀🚀🚀 Benchmark Results
Concurrency: 256
Requests/sec: 440634.04

So then what are we fixing here?

closing in favor of #649


SidebarNav: example of how to implement progress bar in SidebarNav?

The demo shows progress bars within the sidebar under system utilization. I was wondering how can I embed JSX render for the progress bars similar to the demo? The examples shown in the README shows how to change the element tag, but I was wondering if there was a way to embed a component such as the progress bar?
Warm regards,
Max

You can place any component you want inside the sidebar.


Weapon drop callback + Fix for weapons still dropping

As of making this PR its untested.
This adds a callback for when a gun gets dropped, this is just an implementation of the already existing CodeCallback.
It at the same time fixes https://github.com/R2Northstar/NorthstarMods/issues/613 and is a better #617 , it removed the callback for deleting the dropped gun.

okay so I tested the code callback now and the flag, and both work havent tested in specifically Infection though

Tested on infection with latest northstar version. Can confirm that this works as intended, executions no longer bypass the weapon drop flag.


Can't be opened on mac

Describe the bug
Mac doesn't allow running this app (See the screenshot below)
To Reproduce
Steps to reproduce the behavior:

Download the latest version
Click on the app icon the run it

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

What version of macOS?
11.3.1
What version of Quicksilver?
1.6.1 - Latest

Duplicate: https://github.com/quicksilver/Quicksilver/issues/2555


Where can we find information about the structure of the StereoExpData object?

Hi,
I want to learn about data management in StereoExpData object. Specifically, I am interested in extracting the expression matrix, embedding, DEGs etc. Where can I find this information?
Thanks!

Sorry for not getting back to you sooner.
The format of StereoExpData is similar to AnnData. After finishing several analyses, type the data variable to show the basic information and results of StereoExpData.

Ray


Refactored TypicalIssues and Add Suggestion Tests

Coverage increased (+2.7%) to 79.123% when pulling a519383837e7190fea9277c60bfa0ebabf936cfb on zhengwei143:fix-tests into 953d83245bfcc330c12af4d6013ff9e6dbd655e0 on CS2103-AY1819S1-T12-4:milestone-v1.4.


Net charmrun should round-robin simultaneous connections

Original issue: https://charm.cs.illinois.edu/redmine/issues/707

To avoid connection limits to any one compute node, charmrun should order its connection attempts to spread them across multiple nodes rather than making all connections to a specific destination at once.

Original date: 2015-03-19 20:02:10

With universal ++scalable-start, there's no need for this.

Original date: 2016-09-21 18:33:42

scalable start is the default now


Fix darwin compile/link omissions

This re-adds CFLAGS and LDFLAGS that were removed in https://github.com/10gen/openssl/commit/d3ffd1bcb61c9006de93d21614cac7630e75ca85.
Apple removed openssl headers so we have to explicitly tell the linker where to find them - pkg-config doesn't know (more on this here).

I've been systematically stripping out hard-coded paths when possible so that the library isn't tied to one particular installed path for libraries and headers.  I need to update the README to reflect this change.
To build the library, you must either:

have pkg-config and a valid openssl pkgconfig file and set PKG_CONFIG_PATH to locate it
set CGO_CPPFLAGS, etc. for paths relevant to your build system. For example, for MongoDB Evergreen build hosts, using the MongoDB toolchain provided headers and defaulting to the standard system libraries, see this line

I've tested this with various libraries:

For MacPorts, I use PKG_CONFIG_PATH=/opt/local/lib/pkgconfig/ go test
For Homebrew (more or less, I copied from a quarantined Mac build host rather than actually ran Homebrew), I use PKG_CONFIG_PATH=/usr/local/Cellar/openssl/1.0.1u/lib/pkgconfig/ go test or PKG_CONFIG_PATH=/usr/local/Cellar/openssl/1.0.2l/lib/pkgconfig/ go test
For the system library, I installed the headers from the MongoDB toolchain and installed .pc files to match in /usr/local/lib/pkgconfig.


Makefile: Fail fast in case of errors

The logic was wonky here. Now the recipe fails completely if the generation fails. Otherwise the build would continue and later complain about a missing ctypes_primitives.ml obscuring the initial failure.

Thank you!


Keep z coordinate in tilted ground frame

[added by @kosack:] The reason for this is that Frames should be representations of 3d points, however in the current implementation the TiltedFrame is special as it is a projection, not a representation, and therefore loses information.
WIth this PR, one can go to and from the TiltedFrame without information loss, and the original functionality of it being an X-Y only frame is retained by simply dropping the Z coordinate.

Hi, just checked the code. The only issue I see could be that I define a TiltedGroundFrame at some point with only x and y coordinates. Will neglecting the Z coordinate in the definition throw an error?

@ParsonsRD yes, I added z=0 * u.m where needed.

Just for my understanding, is this so we can drop the requirement for the projection functions and make it behave like the other coordinate transformations?

Not really, projection is different from transforming. This is to ensure that a 3d point in GroundFrame actually stays the same point in TiltedFrame to enable back and forth between the two frames.


Make OPENSSL_sk_push return only 0 or 1

Most of the callers do not actually check for
the special -1 return condition because they do not pass NULL to it. It is also extremely improbable that any code depends on this -1 return value in this condition so it can be safely changed to 0 return.
Checklist

[x] documentation is added or updated

OTC: is this API change ok?

What about OPENSSL_sk_num() ?

I wouldn't change that as it makes sense to distinguish an empty stack from NULL by the return value. IMO that would certainly be an API break as somebody could depend on that -1 return.

OTC: This PR is acceptable for master branch, if it has a CHANGES.md entry.

There are == and > 0 tests is a few places.. (So the == ones are broken currently).

IIUC, the motivation of this PR is to adapt the return values to actual partly wrong use.
I'm a little surprised that no caller code had to be changed.
This seems to imply that for each caller, the result check
either was already flexible enough to cover also the new semantics,
or there was an equality check that was in fact wrong and is now indirectly fixed by adapting the called function.
So shouldn't this PR be considered (also) a bug fix?

There are == and > 0 tests is a few places.. (So the == ones are broken currently).

IIUC, the motivation of this PR is to adapt the return values to actual partly wrong use. I'm a little surprised that no caller code had to be changed. This seems to imply that for each caller, the result check either was already flexible enough to cover also the new semantics, or there was a more strict (equality) check that was in fact wrong and is now indirectly fixed by adapting the called function. So shouldn't this PR be considered (also) a bug fix?

The callers which did not check for >0 return were never calling this with NULL stack. This is not a bug fix.

Merged to the master branch. Thank you for the reviews.


Mongodb for Chat history

Describe the bug
When using mongodb for chat history. Flowise opens multiple connection and does not close them.
Due to this i have hit now 500+ connection limit on mongoDB.
To Reproduce
Steps to reproduce the behavior:

Create any agent with mongodb for memory.
As you use it you will see number of connections increases for every chat but doesn't come down.

Expected behavior
I think the ideal behaviour is open one connection and keep resuing it, or atleast close all opened connection.
Screenshots

https://github.com/FlowiseAI/Flowise/pull/1627.
Creating a singleton class for mondodb instance.


[WIP] Prompt to edit

Tests needed are

[ ] simple prompt happy path

[ ] user accepts new code
[ ] user rejects new code

[ ] jibberish prompt sad path

Oh one last thing "Submitted to Edit AI..." Let's change this to "Submitted to ML-Ephant" maybe?

Oh one last thing "Submitted to Edit AI..." Let's change this to "Submitted to ML-Ephant" maybe?

Maybe not sure, I'm working how confusing that might be to a user opening the app for the first time without knowing the Zoo lore.


Check eldest KID in ComputeKeyDiffs, fix ugly warning messages when eldest key not pgp key

r? @maxtaco
Fixes https://keybase.atlassian.net/browse/CORE-2112 and also fixes https://keybase.atlassian.net/browse/CORE-231

I can't seem to repro the original issue right now. Does this patch fix the warning for you?

To repro original warning, track a new user (with nacl eldest key) twice.
Yes, this fixes that.

Ok, great then!! :+1:


Xcode weirdness when using AudioKit as a framework

Need to get to the bottom of why Xcode is giving a lot of "not found" errors and not doing proper code completion when the framework is used.  Things do compile, but you're coding blind until then.  You have to use the AudioKit xcodeproj to get proper code completion, but this is new as of Xcode 8.2 or so.

I had narrowed this down to the compiled architectures included in the framework. We don't include an armv7s slice in them (mostly because it's obsolete), but apparently Xcode complains if it's not present.
A quick fix is to set your project architectures to exclude armv7s from the "Valid Architectures" setting.

How do you do that?  My valid architecture setting is simply: "$(ARCHS_STANDARD)"

You manually replace it with "arm64 armv7"

Actually, scratch that. Normally $(ARCHS_STANDARD) should expand to just these values anyway. Is it not the case for you?

No, not as far as I can tell.  changing it didn't have an effect on Xcode's confusion over AK classes.

I don't think I have this issue:

This is with the mac os x framework. Build settings are pretty standard using link binary with libraries and embed framework.
I have found that getting a new project started is a mix of trying these things and waving a magic wand, then at some point it starts working.

I also copy the framework to my project folder.

@ryanfrancesconi It's interesting that it worked for you when you copy the framework into the project folder.  I verified that that "fix" works for me too.  Problem is, in the examples, we really want to refer the one framework that lives in the Frameworks folder rather than making copies in each example folder.  So, what's the magic setting that lets Xcode see the framework?  It's not framework search path because that is set correctly as necessary for compilation.

@megastep Here's a hint on the iOS side- if I change the target from being a simulator to being "Generic iOS Device" or my real physical device, then the autocomplete works fine.

So just to summarize: On Mac, you can solve this by copying AudioKit into the project folder. On iOS you can solve this by making the target not the simulator. Neither are solutions, just clues to what has to be done to fix this in a more general way.

One thing though - I'm also having some weird issues starting up a new project. I'll let you know what I figure out. There's definitely some weird stuff going on.

coming from being a java programmer, i still find the sharing of resources between projects and name spaces, unintuitive and weird with xcode/swift/etc

I'll close this for now, not like we're getting anywhere with this.


Publicize app

I think it will soon be time to publicize! :)
Below are my current plans for publicizing the app, please feel free to comment or add new suggestions:

See if we can get featured on the Wikimedia blog and Wikimedia FB page
Contact a few tech blogs and app review websites to see if they are interested in writing about us. Not sure which exact ones - I'm thinking of TechCrunch and lifehack.r, any other suggestions?
Contact Wiki Loves Monuments affiliates to see if they could help; I figure our app would be pretty useful for the WLM participants

Should we draft some sort of summary together that can be used both as a reference for the press and for the IEG report? We could draft it on Metawiki?

That would be great, @tobias47n9e . :) The IEG report isn't due for a while yet (since it hasn't been completed yet, the publicizing is part of the final phase), but it would still be helpful. Plus we could use it for the WMF blog draft with a few tweaks.

Regarding point no. 2, to increase the change of the app getting featured by some websites, the app needs a revamp of the UI. I mainly say this as the initial reaction to an app (and ultimately whether someone will even try the app) is usually based solely on the UI.

@veyndan @tobias47n9e Those would be good changes to make. Do we think they could be doable within the next week or so? If so, I can hold back on the publicizing until they are done.

I could pick atleast one of these tasks. It would be great if we are able to finish these tasks before the publicity begins. Also we could come up with some sort of a press release content so that its easier for the tech blogs to publish about the app.
Moreover i would be happy to publish it on my blogs too. :)

@maskaravivek Fantastic, thanks. :)
I will start a draft of the press release on our wiki so anyone can contribute.

https://github.com/commons-app/apps-android-commons/wiki/Press-release-[Draft]

@misaochan Awesome, I'm a bit busy this week but if I have time I'll try and do a bit of work.

What I'll do is make a PR for each screen as it appears that a few people want to work on the interface. This avoids too many conflicts.

Yup, good idea @veyndan .

Update: I will be aiming to do a beta release next Mon or Tues if possible, and hopefully push to production and complete the publicity draft by the end of next week. Amazing work so far, thanks all! :)
@neslihanturan and @nextLane , would you two like to be added to credits.md? Let me know what your preferred name is if you do.

@neslihanturan and @nextLane , would you two like to be added to credits.md? Let me know what your preferred name is if you do.

Thanks:) Neslihan Turan is okay for me.

v 2.1 is in beta now. :) I'll leave it there til Sunday before putting it into production, and will get the publicity ball rolling after. Would very much appreciate it if folks could test and see if everything is okay.

Update:
I've put up new screenshots in our Google Play page to reflect all the new improvements in the app, and also added one for 7-inch and 10-inch tablets respectively. Will be working on updating the store listing shortly - https://github.com/commons-app/apps-android-commons/wiki/Google-Play-store-listing
I contacted the Wikimedia blog team about the possibility of submitting a blog post for our app, but they haven't gotten back to me, will have to wait and see. Will start looking up other blogs/sites that we can submit our app to.

https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/Newsroom/Suggestions
Though it has Wikipedia in its name, the Signpost often runs stories about Commons.
Topics that will probably interest them:

History of the app, from official to forgotten to revived to official again
Quality stats that go against received ideas

I've updated the Store listing wiki
 with a draft of what I plan to write on the Google Play Store - please feel free to review/comment so I can make the necessary changes before putting it up.
Also, I wonder if we should edit https://en.wikipedia.org/wiki/Wikimedia_Commons to include ourselves in the Utilities section?
Thanks @nicolas-raoul ! Will try there as well. Should I post in Suggestions or just create a proposal directly on their Submissions Desk? The former seems to be for people who want to request an article that they cannot write themselves?

I edited a few minor things on the wiki.
The rule of Wikipedia mainspace is: Never write about yourself. If you are
notable enough, someone will eventually write about you.
I don't know, probably Submissions Desk then :-)
On Wed, Mar 29, 2017 at 6:30 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

I've updated the Store listing wiki
https://github.com/commons-app/apps-android-commons/wiki/Google-Play-store-listing
with a draft of what I plan to write on the Google Play Store - please feel
free to review/comment so I can make the necessary changes before putting
it up.
Also, I wonder if we should edit https://en.wikipedia.org/wiki/
Wikimedia_Commons to include ourselves in the Utilities section?
Thanks @nicolas-raoul https://github.com/nicolas-raoul ! Will try there
as well. Should I post in Suggestions or just create a proposal directly on
their Submissions Desk? The former seems to be for people who want to
request an article that they cannot write themselves?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/420#issuecomment-290035599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBtH7B2C3Dd4eXQtdRPPvPZToZnR4ks5rqiTPgaJpZM4MZJuY
.

Great, thanks! :)

I've just received approval from Ed Erhart of the Wikimedia blog team to submit a draft for our app. :) He suggests using https://blog.wikimedia.org/2016/03/10/new-wikipedia-app-ios/ as a template for language/tone/style. I'll be working on a draft for the blog post here: https://github.com/commons-app/apps-android-commons/wiki/Press-release-[Draft]

Added the template provided by Ed to the draft.
He recommends submitting only 1-2 screenshots, no more. That might be difficult to choose - anyone want to weigh in on which screenshots we want? Bear in mind that this will reflect ALL the changes to the app in the past 6 months.
I'm thinking the Nearby feature and possibly the new title/desc screen which now has Material icons, "Use previous title/desc" option, and license selections. Not sure though.

I've completed the Wikimedia blog post draft at https://github.com/commons-app/apps-android-commons/wiki/Press-release-[Draft] and will be submitting it to the blog team soon. Please let me know if there's anything you think should be changed or reworded. I'd also really like to have input on which title would be best (I suggested a few alternatives), and what image to use as the lead image (will be the image shown on the main blog and at the top of the blog post, cannot be a screenshot).
Thanks!

Title: I prefer the first one with "2.0"
In the new features, I think you should talk about location-based
categories, that's one of the most convenient things ever in my opinion. I
know it was developed a while ago, but still after 1.0, I guess? I don't
remember well.
My suggestion for a lead image: Picture of a random street passer-by using
her/his Android phone to take a picture of something that looks very
important/historical.
We can use that same image as the Play banner instead of the mushrooms, by
the way.
Nearby is a bit sub-par for prime time, I believe. Any volunteer to replace
my horrible CSV-download hack by a query to Wikidata as described at
https://github.com/commons-app/apps-android-commons/issues/289 ? I would do
it but my IDE is totally broken and I somehow did not managed to fix it
last time I tried.
Maybe add a small paragraph about why the app is so much needed? Like, more
and more people have a smartphone but no computer, people don't have time
so better allow them to upload wherever they happen to need to kill time,
fresher images, etc.
On Mon, Apr 3, 2017 at 7:34 PM, Josephine Lim<EMAIL_ADDRESS>wrote:

I've completed the Wikimedia blog post draft at
https://github.com/commons-app/apps-android-commons/wiki/
Press-release-%5BDraft%5D and will be submitting it to the blog team
soon. Please let me know if there's anything you think should be changed or
reworded. I'd also really like to have input on which title would be best
(I suggested a few alternatives), and what image to use as the lead image
(will be the image shown on the main blog and at the top of the blog post,
cannot be a screenshot).
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/420#issuecomment-291106525,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBje_EX7ySXC94faI6Rs-7i5JySFtks5rsMsYgaJpZM4MZJuY
.

@nicolas-raoul I didn't mention location-based category suggestions because those were published in a blog post after my Outreachy internship. But good point - maybe people have forgotten anyway, so we can just include that?
The lead image you suggested sounds good. Will just have to look for one with an open license (I'm guessing any image acceptable for Commons use should be acceptable for the blog picture, we don't need to take it by ourselves?)
The switch to Wikidata would be great if anyone has the time to do it. We can always change our hacakthon project to the map instead, if someone manages to do it before the hackathon.
What issues are you experiencing with your IDE?
Will add the paragraph suggested. I need to figure out a way to do it in a less-promotion-y style though, as required by the blog guidelines (no blatant promotion).

I've updated the draft based on the points made by @nicolas-raoul .

Looks good to me. Is it worth mentioning some community stats? Number of contributors, number of uploads since reviving?

Good point @tobias47n9e , done. The final draft is at https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/Wikimedia_Commons_Android_app:_version_2.0 awaiting Ed's approval.

Even if you don't integrate that in the press release, some elements that you might want to use when talking about the app, they show how much the Android app is needed:

This map that shows how Android is the way to go to reduce Commons' countries gap:

Android is now the most widespread operating system, it made big news 4 days ago when it was announced that Android took over Windows:
http://www.zdnet.com/article/sorry-windows-android-is-now-the-most-popular-end-user-operating-system/

The Wikimedia blog post is out! :) https://blog.wikimedia.org/2017/04/13/commons-android-app-improvements/
Please share and spread the word if you can.

Completed the first round of press notifications - these are for tech blogs that have written about the app before, so it's mostly just a "Hey, this app has been updated" nudge. One of them has gotten back to me so far.
List of blogs notified in this round:

Thenextweb (email)
Engadget (online form)
Gizmodo (online form)
rising.globalvoices.org (online form)
www.addictivetips.com (online form)
theverge.com (email)

For the next round (tech blogs/magazines/etc that have never written about our app before), I'll probably send a more detailed email to them that explains what the app does and why it's useful. I'm guessing this should be written in a style that's halfway between a "pitch" and a "press release"?

The previous round of press notifications did not go terribly well. Only one of them got back to me at all (globalvoices). I admit I was a little surprised, as I wasn't emailing them out of the blue about a brand new app - this is an app that they have actually written about before. Their old articles still exist and still predominate Google search rankings (with links pointing to a nonexistent Google Play store listing :/). But it seems none of them were interested in updating it.
I could possibly stand to improve my pitch, but I also wonder if the lack of 'official' accreditation is part of what's preventing them from taking us seriously. For one thing, I am emailing them with my personal email address (I don't have a @wikimedia email address), so it probably looks less credible.
I wonder if there is any way to get around this and improve for the final notifications round? That will be for blogs/magazines/news sites that haven't written about the app before, so I'm expecting a lower response rate for those.

Did we inquire here yet: https://www.mapbox.com/blog/ ?

@tobias47n9e I could try!


Add explainer on v1 aLINK that it doesn’t accept v2 aLINK tokens

Many users try to deposit v2 aLINK tokens to yaLINK vault; we should have tooltip explaining that these tokens cannot be accepted.

This vault has been deprecated and this issue is no longer relevant


Timeout error trying to use gimbal, PX4

I'm getting a timeout error while trying to run gimbal.py from the examples. I can control the gimbal with QGC so the gimbal is exposed over mavlink. PX4 version is v1.12.
Traceback (most recent call last):
  File "/home/whitney/Documents/Dev/Robot/./gimbal.py", line 89, in <module>
    asyncio.run(run())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/whitney/Documents/Dev/./gimbal.py", line 25, in run
    await drone.gimbal.set_mode(GimbalMode.YAW_FOLLOW)
  File "/home/whitney/.local/lib/python3.10/site-packages/mavsdk/gimbal.py", line 484, in set_mode
    raise GimbalError(result, "set_mode()", gimbal_mode)
mavsdk.gimbal.GimbalError: TIMEOUT: 'Timeout'; origin: set_mode(); params: (<GimbalMode.YAW_FOLLOW: 0>,)

PX4 v1.12 likely does not support gimbal v2 fully yet, so I'm not sure if it'll work out of the box.
Have you set this param to gimbal v2?
https://docs.px4.io/v1.12/en/advanced_config/parameter_reference.html#MNT_MODE_IN

I'm using gimbal protocol v1. I set MNT_MODE_IN to 3 but same result unfortunately

Any chance you could try with a more recent PX4 version? I'm not sure of the state of gimbal back then.

I found the solution. I needed to set MNT_MODE_OUT in addition to MNT_MODE_IN
MNT_MODE_IN 3
MNT_MODE_OUT 1


Hellgrind issues

Hi guys,
I've run an example from the docs page (see below) under the hellgrind tool (it checks for multi-threading related errors) and it gave me plenty of synchronization errors, although rust's plain threads implementation it runs doesn't have the errors.
Generally speaking, the tool is known to produce false positives, but as I mentioned before nothing is shown for the plain threads rust implementation. I've also generated suppression rules from a single run, but they haven't fixed the errors meaning different ones have been reported on another launch.
Could you please have a look? You can see it by yourself just by running valgrind --tool=helgrind on a compiled app. Here's my ouput -- https://gist.github.com/mexus/08e2694758e4b1a2833dcbb415971c0b .
I'm using rustc 1.17.0 and threadpool 1.3.2.
extern crate threadpool;

use threadpool::ThreadPool;
use std::sync::mpsc::channel;

fn main() {
    let n_workers = 4;
    let n_jobs = 8;
    let pool = ThreadPool::new(n_workers);

    let (tx, rx) = channel();
    for _ in 0..n_jobs {
        let tx = tx.clone();
        pool.execute(move || { tx.send(1).unwrap(); });
    }

    let res = rx.iter().take(n_jobs).fold(0, |a, b| a + b);
    assert_eq!(res, 8);
}

Hm, okay, I've found out that the suppressions actually do work and the "problem" lies in rust implementation of some things like condition varialbles.
Sorry for a false positive :)


[Feature]: Select runs by report

Description
first of all, thanks for the great tool; I love using W&B.
Feature:
It would be great if we could filter runs by a linked report. This way, at the end of a larger project, we could select all unused experiments and remove them.
Suggested Solution
Part I: Link the runs to reports
If I know well, the reports are not linked to the runs. I think it would be beneficial if the runs contained links to the reports. Thus the user could jump directly to reports where a specific run appears and gather more contextual information from different reports.
Part II: Filtering by reports
In the run table, it would be great to filter by reports. We should be able to select multiple reports and show only the runs appearing in those.
Alternatives
Part I: Simple flag for the runs
A simplified feature for the described use case could be just to have a single flag stored for the runs, which tells whether the specific run is used in a report or not.
Part II: Simple filtering
In the run table, we should be able to select all the runs that were not used in any reports.
Additional Context
During my research, I came to a use case that might be worth implementing a feature for it. I run many experiments and collect the most insightful ones into reports. However, it is getting tedious to remove the unnecessary ones.

Hi @Peter-Kocsis, happy to see you like W&B! And thanks for sharing this feedback, it's a really interesting feature! As you said this is currently not possible, but I found a workaround to solve this with our Public Api. You can access your report and see which runs are not used and delete them or add a tag to be able to filter in the Workspace and delete from there (to have more control)
import wandb
import wandb.apis.reports as wr

api = wandb.Api()
report = wr.Report.from_url('report_url')

for runset in report.runsets:
  for run in runset.runs:
    if run not in api.runs('entity_name/project_name'):
      #If you prefer to add tags and delete from Workspace
      run.tags.append("Delete")
      run.update()
      #If you want to delete from here
      run.delete()

Would this solution work for you or would you like me to still create a feature request for this? Thanks!

Thanks! This is a great idea; it is a good workaround; I will try it!
Nevertheless, I still think that it can be a useful feature for others as well, so it would be great if you could consider it as a new feature.

Great, thanks for confirming this @Peter-Kocsis! I'll create the new feature request and will share your feedback. Thank you!

Hello,
Thank you for the idea @luisbergua!
Unfortunately, it is not working for me -- It may be because the collapsed panels are not returned?
import wandb
import wandb.apis.reports as wr

api = wandb.Api()
report = wr.Report.from_url('https://wandb.ai/gladia/rae/reports/Experiments-2--VmlldzoxOTA0ODQy')

print(report)
print(f'Runset: {report.runsets}')

for runset in report.runsets:
  for run in runset.runs:
    print(run)
    if run not in api.runs('gladia/rae'):
        print(run)

Outputs:
Report(project='rae', entity='gladia', title='Experiments #2', description='Latent dimensionality influence', width='fixed', blocks=[BlockQuote(text='Collapse each section and subsection after reading it to speed-up the page loading.'), P(), H1(text=['Latent dimensionality influence']), BlockQuote(text='Fix the number of anchors and change the latent dimensionality: we expect a bell behaviour'), P(text=['Indeed, there the bell behavior does appear.']), P(text=['Each combination of autoencoder type (rae, vae, ae) and latent dim has been run with three different seeds.']), H2(text=['RAE']), H2(text=['VAE']), H2(text=['AE']), H2(text=['Comparison'])])
Runset: []

Hi @lucmos, sorry about the delay! This is indeed the case, I just checked on my end and if the section is collapsed, runsets aren't returned. At this moment, the only workaround would be to expand those before executing the code. Please let me know if that would be useful for you!

Hi @luisbergua, thanks for the reply!
Unfortunately that does not really work for me -- I have a project that I want to archive. It contains many runs and reports, and each report is quite big.
My objective is to free space, by removing runs not used by any report.
However, expanding each section in each report in the project manually is a bit too inconvenient (also, big reports crash the browser with all sections expanded, if I remember correctly).
Can it be done programmatically?

I see, thank you so much for explaining this @lucmos! Unfortunately, currently there's no way to expand sections programmatically. I have raised this to our Engineering Team to be able to retrieve blocks under collapsed sections as well so will keep you posted


DoubleFirstAggregatorFactory is not supported during ingestion for rollup

version:0.20

According to the doc,

(Double/Float/Long) First and Last aggregator cannot be used in ingestion spec, and should only be specified as part of queries.

But the web console DOES allow users to configure a metric aggregated as double/float/long first/last.

And from the current implementation of backend services, these aggregation are not supported.
I checked the history of code, and didn't find the reasons why these aggregators are not supported during ingestion for rollup.
Do you have more background information on this problem @gianm ?

@FrankChen021 there's some context in #7599 and #10332
The web console shouldn't offer these as options since they are not yet supported at ingestion time.
cc @vogievetsky

@suneet-s I see. Are there any progress being made on long/double first/last ? If no, I'd like to take the chance to implement it.

According to the doc,

(Double/Float/Long) First and Last aggregator cannot be used in ingestion spec, and should only be specified as part of queries.

But the web console DOES allow users to configure a metric aggregated as double/float/long first/last.

And from the current implementation of backend services, these aggregation are not supported.
I checked the history of code, and didn't find the reasons why these aggregators are not supported during ingestion for rollup.
Do you have more background information on this problem @gianm ?

Thank you for answering my question

@FrankChen021 there's some context in #7599 and #10332
The web console shouldn't offer these as options since they are not yet supported at ingestion time.
cc @vogievetsky

Thank you for answering my question

@suneet-s I see. Are there any progress being made on long/double first/last ? If no, I'd like to take the chance to implement it.

@FrankChen021 I'm not aware of anyone working on these issues. Feel free to pick it up - I reviewed the implementation for StringFirst/Last, and would be happy to review these as well


Chapter 1: Installation Guide, Updates Needed for Linux and all platforms

relevant for: http://ionicframework.com/docs/guide/installation.html
##All Platforms Updates
None of the guides mention any dependencies that cordova has for Ant required to add platforms and run builds.  Cordova installation/download has only npm instructions, and doesn't install ant during that installation.  Ant also requires Java jdk (not jre).
This is probably new to many front-end devs looking to break into the mobile space, and makes things tough.  There's actually a TON of criticism on StackOverflow about the documentation :-1: sadly.
Some notes or even a sub chapter on installing these could be helpful.
##Linux updates
The section that asks you to run ionic platform ios and ionic platform android has a note about windows users not being able to do the ios install.  This implies linux users can do this, but community opinion seems to be this isn't possible.
Note: If you confirm these things, I have forked and am prepared to add the necessary instructions/updates and submit a pull request.

Greetings @H3Chief!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Allow options with the same name and signature

This allows options defined in an interface and in a class to coexist, fixes #19868

@bot-gradle test this

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge


[Question] API change from 1.8.32 to 1.8.33.

Hi,
Before jumping to the question I wanna say that I notice that you introduced the DestinationScopeWithNoDependencies interface and the DependenciesContainerBuilder isn't extending DestinationScope anymore but DestinationScopeWithNoDependencies.
On the documentation page we can find the following information block that says that DependenciesContainerBuilder is also DestinationScope:
dependenciesContainerBuilder lambda is scoped in a DependenciesContainerBuilder which is also a DestinationScope. So, everything we have available [when manually calling a Composable screen](https://composedestinations.rafaelcosta.xyz/destination-arguments/navhost-level-parameters#manually-call-your-screen-composable), you also have here, including a destination with the DestinationSpec that is being navigated to.
This enables you to make decisions here and have dependencies only available to specific destinations or specific navigation graphs or any other case you might have.

Until 1.8.32 we were using dependenciesContainerBuilder to inject a specific Navigation interface per Destination instead of DestinationsNavigator.
The idea is to only provide an interface to the screen that has only the actions that can be called by that specific screen. This also allows having multimodule navigation, since we are injecting all the implementations that know about the Destinations screen.
Let me share an example:
Screen:
@Destination(
    route = "terms"
)
@Composable
internal fun TermsScreen(
    viewModel: TermsViewModel = getViewModel(),
    navigation: TermsNavigation
) {
....
}

Navigation Interface:
public interface TermsNavigation {
    public fun openWebView(url: String,)
    public fun back()
}

Navigation Interface Impl (done on central module):
class TermsNavigationImpl(
    private val navigator: DestinationsNavigator
) : TermsNavigation {

    override fun openWebView(url: String) {
       ....
    }

    override fun back() {
        navigator.popBackStack()
    }
}

Adding to the dependency container:
 dependency(TermsScreenDestination) {
       TermsNavigationImpl(
                navigator = destinationsNavigator
            )
}

Until here everything is fine, problem now is the way we're doing Navigation with results. We also encapsulate the logic for listening to the result and passing back the result to the other screen. This was a great way for us to avoid  to declare the entire Screen manually with all the dependencies arguments. Unfortunately ins't possible anymore, since the new interface doesn't contain the extensions functions resultBackNavigator and resultBackNavigator:
 dependency(SelectDesignScreenDestination) {
      SelectDesignNavigationImpl(
          navigator = defaultNavigator,
          resultNavigator = resultBackNavigator(), // not accessible anymore
          onVoteResultRecipient =  resultBackNavigator() // not accessible anymore
     )
  }

Should the documentation be updated?

There was any problem with the previous approach? This worked super great for us, okay with recomposition, multiple screens, activity recreation etc;

There is any way to achieve something similar without using the manual builder?
Moving the extensions to the DestinationScopeWithNoDependencies also solves it :D

Hi @extmkv !
You are right, I added the DestinationScopeWithNoDependencies because inside the dependencies builder, you can access everything the DestinationScope offers, EXCEPT the dependencies... because this will internally call the lambda you are on, so basically an infinite loop and possibly a stack overflow exception 😋
Now, in doing so, I forgot to change the extension functions 🤦 It honestly did not occur to me that people could be using the dependenciesContainerBuilder for this.
The fix, really is to use DestinationScopeWithNoDependencies in the extension functions... but honestly, I think I'll instead rename the interface with no dependencies to DestinationScope and the other to DestinationScopeWithDependencies.
I need to think about it a little.. anyway, I will fix this and make a new release today.
Really glad you found this 🙏 Thank you for such detailed explanation!

Done! 1.x.36-beta should be up in about 30min or so!

ofc nexus had some issue so I couldn't actually release... but hopefully they'll fix it pretty soon...

It's done :)


Fix template error when /etc/nginx/certs does not exist

Is it possible, that this change broke SSL support completely unless Env.CERT_NAME is set? As far as I understand, this does not work:
	{{ var $vhostCert := "" }}
	{{ if exists "/etc/nginx/certs" }}
		{{ $vhostCert := (closest (dir "/etc/nginx/certs") (printf "%s.crt" $host)) }}
		{{/* vhostCert is actually a filename so remove any suffixes since they are added later */}}
		{{ $vhostCert := replace $vhostCert ".crt" "" -1 }}
		{{ $vhostCert := replace $vhostCert ".key" "" -1 }}
	{{ end }}

I think $vhostCert is always empty after the if block since $vhostCert, my local tests seem to verify that. Or am I totally wrong?

golang playground example regarding variable scope in templates: https://play.golang.org/p/4rFhZkpqvF


Update to latest standard ESLint config

Reviewer:
Updating to the latest Standard config.

Description:

Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Thanks for doing this!!
Everything looks great. The only thing I see is the CI checks seem to have some issue. Could you take a look at that?

@Charlie-belmer CI didn't have the auth keys to clone via ssh:// I assume this is perhaps a recent change that's not been noticed as the dependencies haven't changed for a while. Either way was a little weird; merging as you previously approved and this is just a subtle config change.


correct Go version

I don't know if it's common practice to leave off the 1. on Go versions. I think that using the canonical version number makes this easier to understand.

I don't know if it's common practice to leave off the 1. on Go versions. I think that using the canonical version number makes this easier to understand.

Thank you!
This has already covered in issue no 45 and merged.
https://github.com/Chainflow/cosmos-validator-mission-control/pull/45


Ignore log lines where we have None for required fields

For some reason, sometimes the log lines from Fastly do not include information that logically has to be there. Thus far we've been unable to track down why, and the rate is low enough that ignoring these lines makes the most sense.

Codecov Report

Merging #22 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   27.12%   27.05%   -0.08%
==========================================
  Files          13       13
  Lines         693      695       +2
  Branches       77       78       +1
==========================================
  Hits          188      188
- Misses        503      505       +2
  Partials        2        2

Impacted Files
Coverage Δ

linehaul/syslog/parser.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34000a...5d4d03b. Read the comment docs.


[WORKITEM]: re-enable spaces.test.ts test

Description
It was disabled to unblock CI

https://github.com/river-build/river/pull/481


Question about divRank and fitRank in updateBiasedFitnesses()

As mentioned in the paper "Vidal, T. (2022). Hybrid genetic search for the CVRP: Open-source implementation and SWAP* neighborhood.",  the fitness in HGS is based on objective value and diversity considerations with formula (1).
The diversity is measured as its average broken-pairs distance; We found the calculation of diversity rank in the function updateBiasedFitnesses() is as follows:
double divRank = (double)i / (double)(pop.size() - 1);
while the solution quality is
double fitRank = (double)ranking[i].second / (double)(pop.size() - 1);
Are these two calculations reversed? Maybe it should be:
double divRank = (double)ranking[i].second / (double)(pop.size() - 1);
double fitRank = (double)i / (double)(pop.size() - 1);
since the ranking store the averageBrokenPairsDistance
ranking.push_back({-pop[i]->averageBrokenPairsDistanceClosest(params->nbClose),i});

Remember that i here iterates through the sorted decreasing ranking so it represents the ith largest distance individual. ranking[i].second represents the pos of that same individual in the fitness sorted population.

Thanks a lot, @TheIronBorn for following up and providing a very concise explanation.
The code in the current form is indeed correct: the individuals in  pop are kept sorted by increasing penalized objective, therefore ranking[i].second provides the rank of the considered individual in terms of objective (fitRank). Moreover, since we perform a sort by diversity contribution in ranking, ranking[i] will correspond to the i^th best individual in terms of diversity contribution.

Thanks for your reply~  @vidalt @TheIronBorn


Ieee special values

Adding functions to check if values are special IEEE values (Nan, infinity, denormalized)

@Angelica-Schell there was no review for this PR. Was this meant to be merged?

Oops @rachitnigam I did not mean to merge it, but I think it's fine, as it's not affecting anything else


fix: correct typo in issue template

Corrects a typo in Question issue template

Pull Request Test Coverage Report for Build 834

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.88%

Totals

Change from base Build 833:
0.0%

Covered Lines:
231

Relevant Lines:
233

💛  - Coveralls

Ahh, @kaveet what a catch! Thank you for making the PR, I'll merge in a second 🙂

:tada: This PR is included in version 4.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add option to change the tag position

Added a option to change the tag position of a new tag as default behaviour displays the tag first before search results. Passing :tag-position="bottom" will revert this behaviour and will display search results before the new tag which will allow the user to press enter to select a search result if it already exists.
If it's a completely new option then there will be no search results remaining and so the new tag will be highlighted allowing a user to press enter to add the new tag.
For details please see issue - #443
Let me know if you need me to change anything 👍
Thanks

Looks great! Thank you very much!
I plan on working on the component during the weekend. What I could wish for is a test for this use case.

@shentao I've gone through and added some tests for this. Also, there was failing test due to searches/new tags are changed to lowercase

Great job! Thanks a lot :)
Should be released during the weekend.


python3.pkgs.astropy-extension-helpers: add build and test dependencies

Description of changes
Extracted from https://github.com/NixOS/nixpkgs/pull/245509. When we use build to build packages instead of pip, we need to add pip to the test dependencies when it's needed. We would also like to drop an implicit dependency on wheel and make it explicit.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1054

@ofborg build python310Packages.astropy-extension-helpers


Whitespace transformation

Thanks so much for providing this tool! I've been frustrated at the lack of forthcoming workflows for developing with ESM for the browser. Today I installed zwitterion and I'm having a fantastic developer experience.
But
I rely heavily on returns in my code which normally allows for breakpoint-based debugging, and I can't find a way to avoid zwitterion eating up some of these in transpilation. For example, the following source:
export default function * crawl(node){
  yield node

  if(Array.isArray(node))
    for(const child of node)
      yield * crawl(child)

  else
    for(const subtree of ['instance', 'children'])
      if(node[subtree])
        return yield * crawl(node[subtree])
}

...Is served as follows:

        var process = window.process;
        if (!window.ZWITTERION_SOCKET) {
            window.ZWITTERION_SOCKET = new WebSocket('ws://localhost:5001');
            window.ZWITTERION_SOCKET.addEventListener('message', (message) => {
                window.location.reload();
            });
        }
        export default function* crawl(node) {
    yield node;
    if (Array.isArray(node)) for (const child of node) yield* crawl(child);else for (const subtree of ['instance', 'children']) if (node[subtree]) return yield* crawl(node[subtree]);
}

I believe this is an upstream longstanding bug with TypeScript (https://github.com/Microsoft/TypeScript/issues/843) - is there a way of avoiding TypeScript compilation, or is it essential to import transpilation?

Sorry, coming back to all of this after a long and interesting break. As far as I can remember, TypeScript transpilation is not essential, but I haven't put in the options for other compilation methods. To keep things as simple as possible starting out, I've just used the TypeScript compiler for everything. With recent developments in Babel, notably Babel 7 providing parsing for TypeScript if I'm not mistaken, this could change. It would probably be a good idea to allow options for which compiler to use, Babel, TypeScript, or even other compilers. That's all a bit in the future though. Another solution to your issue could be good sourcemap support, which wouldn't be too difficult to add.


[Feature Request] Current time indicator

I'm building a simple appointment scheduler, and a time indicator much like the one found in Google Calendar would be nice to have. It should be displayed when the calendar is in week or day view.

Yup, makes sense - will add it to the to do list.

The code for this is done and will be in the next release coming shortly.


Do we have stream completion support SSE

It is giving me error: Call to undefined method OpenAI\Resources\Completions::createStreamed()
I have tried this as well but still same error.
BTW: I have managed it with curl with no support of this package.
Please help!

Updated library to latest version solved my problem.
Thanks


Implement stage class with default parameters for width and height.

Default parameters for width and height make the api easier to use for especially new programmers.
I suggest: Always if it makes sense implement default values for parameters.

I support the suggestion. For stage default dimensions, I used 480x360, the dimensions of the Scratch stage.


Replace title on README file

On README.dm file, the point 5 should be Quiz Game instead of Calculator Program.
Repo: https://github.com/diverintech/python-projects/blob/main/README.md

Fixed: https://github.com/diverintech/python-projects/pull/5/commits/18e8063296f16761091fdd1ba904c906302041c3


feat: add go-libp2p in 2022 blog entry

@marten-seemann @MarcoPolo may I get your review, I'll publish this today


Plugin Extension

added a custom VScode theme
added support for SQL datasources (.slsql) with syntax highlighting
added support for SSL datasources (.ssl)
some minor fixes

Hi,
I like the colors!
However, the comments are still terminated at '*/' or do I see it wrong? Also the sql intern highlighting is still broken.
See

vs

Hi Jan, oh, I missed that! Of course, single line comments should be terminated with a semicolon.
I need syntax highlighting for datasources written in SQL, not in SSL. For datasources written in SSL, the SSL language (and .ssl extension) should be used. I know it's very similar to SQL, but still has some differences (e. g. comments and the ":PARAMETERS" keyword) - btw. to name it like SLSQL was your idea! ;-) I'm currently working on extending the starlimsvscode extension with the (long-term) aim that all STARLIMS HTML5 development can be done in VS Code. I'm not sure how to implement the forms designer yet, but one thing at a time! :-)

Completely understood and agreed! I will take a look as soon as I can.


feat(codemagic_app_preview): improve comment

⬇ Builds generated by Codemagic for commit 15c6437e188622c5cf133e6b1ffeefe77fe05eb7 ⬇
This is a custom message.

iOS

Android

macOS

  Download link

  Download link

  Download link

(expires Mon, 30 Oct 2023 09:11:18 GMT)Codemagic build: 6517e5792c784aaf66e564a5; comment generated with Codemagic App Preview


Add Wmts Layers Feature

Possibility to read Capabilities from a Wmts service
Retrieve availables layers
Add Layers to the MapView

I tried using this this map https://services.arcgisonline.com/arcgis/rest/services/World_Imagery/MapServer/WMTS/1.0.0/WMTSCapabilities.xml and past a certain point, I get data not available tiles. I checked the WMTS capabilities document and it seems the min and max zoom are defined. Do you think we can fix this by setting the max zoom or min zoom for the specific WMTS layers or all WMTS layers in that source? What do you think?
It seems we will not be support any other tile sizes such as 512 from this code since the tile size is a constant 256. This map is old and no longer supported but it has tiles of size 512. What do you think? I tried using the it as is and I can only see half the world on the activity WMTSActivity


Various toHTML-when-not-rendered-to-DOM fixes - #2727

Description of the pull request:
This modifies the render browser tests to run toHTML testing before rendering to the DOM to simulate what happens in node. The main reason I did that was to track down the issue in #2727, but it also turned up a handful of other issues with code that expected a DOM environment where it shouldn't.
The issue #2727 is that the updateAttribute handler that is called on render sets up the special styleName and inlineClass properties on the Attribute. If it's never rendered, Attribute.toString won't realize that it's a special directive and render itself as a plain old string attribute. This PR adds a check for style- and class- directives and sets them up to be appropriately toStringed if they've not been rendered.
This also removes the test involving having an array as root data, as that has been deprecated for quite a while and was interfering with the way the test resets data now.
Fixes the following issues:
#2727
Is breaking:
Nope.

Nice one @evs-chris thanks for getting this fixed so quick 👍


Add logging

We need to have some logging output to help see where time is being spent. Add a logger instance to the app.py and log the data frame computations.

partially addressed in #54, but we're not integrating with the bokeh serve logging in a nice way.


Call 'go get' and 'go list' with lists of packages rather than for each package.

Concatenating requests significantly reduces networking overhead.
In my test case, ./manul -Q went down from 2 minutes to 5 seconds.

Thanks for the contribution! It's very nice if it really makes manul much faster. There are few small issues that should be solved and I will merge it gladly.

@culyun thanks, merged!
karma-go was experimental library but now it's library that I use everywhere, because it works fantastic.
Let me explain why with @seletskiy we decided to develop it. For example, you have function calls:
foo() calls bar() (bar can return error)
bar() calls baz() (baz just return value that passed to next func call)
then bar() calls quz() and passes value from baz func
quz() calls xyz() and returns error

as result you want to see full trace back what happened, if you use fmt.Errorf, you will use something like "bar returned error: %s", err, in bar you will write following code: "quz returned error with value %v: %s", bazValue, err) and so on and last function just returns os.ErrNoExist (given filename not found), but as result, you will get following error:
unable to do foo: unable to do bar: unable to do quz with value SomeGeneratedFileName: unable to do xyz: file does not exist

If you will use following code everywhere:
if err != nil {
   return err

as result you will see only
file does not exist

not pretty useful in debugging, huh? No file name, no answer why the program tries to find a file.
but if you will use karma, you can write following code:
package main

import "fmt"
import "github.com/reconquest/karma-go"
import "os"

func foo() error {
	err := bar()
	if err != nil {
		return karma.Format(
			err,
			"unable to do bar",
		)
	}

	return nil
}

func bar() error {
	filename := baz()

	context := karma.Describe("filename", filename)

	err := quz(filename)
	if err != nil {
		return context.Format(err, "unable to do quz")
	}

	return nil
}

func baz() string {
	return "SomeGeneratedFileName"
}

func quz(filename string) error {
	err := xyz(filename)
	if err != nil {
		return karma.Format(
			err,
			"unable to do xyz",
		)
	}

	return nil
}

func xyz(filename string) error {
	// imagine that filename doesn't not exist
	return os.ErrNotExist
}

func main() {
	err := foo()
	if err != nil {
		fmt.Println(err)
	}
}

resulting error will look like:
unable to do bar
└─ unable to do quz
   ├─ unable to do xyz
   │  └─ file does not exist
   │
   └─ filename: SomeGeneratedFileName

The error will be hierarchical and pretty formatted, very useful for human beings.
There are many examples in tests: https://github.com/reconquest/karma-go/blob/master/karma_test.go#L308-L326
Logrus-like libraries also allows to specify key-value, but values will be placed at right of the message, and since they use map[string]interface{}, keys will be random sorted, karma doesn't sort values:
https://github.com/reconquest/karma-go/blob/master/karma_test.go#L369-L389
But on the other hand, karma doesn't say to you how you should format errors, you always can declare your own format (for example, if you want to send data to elasticsearch in json-like parsable format):
https://github.com/reconquest/karma-go/blob/master/karma_test.go#L681-L748
Also imagine, that you have an internal microservice that do some good job and sometimes it returns errors, since JSON is for machines and text format is for humans, karma allows to marshal errors and details to JSON:
https://github.com/reconquest/karma-go/blob/master/karma_test.go#L167-L188
and then after receiving error, you can unmarshal it to karma.Karma and use as before, you can format it as hierarchical or push it as key-value string.

Thanks for the explanation of karma.  But if you're interested in where something (eg. an error) occurred why not just use a combination of runtime.Caller and runtime.FuncForPC?  I think you can recover the stack from this.  Once you've got your backtrace, you can log away to your hearts content.

@culyun because I want to see errors explanations that I can read even if I didn't work on this project for a year:
2018-04-11 16:25:28 [ERROR] uncaught error while serving client request
                           └─ unable to get points from series
                              ├─ unable to execute query
                              │  └─ database returns error while processing query
                              │     ├─ Post http://tsdb:8086/query?[removed]: dial tcp: lookup tsdb on <IP_ADDRESS>:53: no such host
                              │     └─ query: SELECT * [removed]
                              │
                              └─ error_id: eBJjbq7E

@kovetskiy I see your point.  And I like the output very much :-)  I'll have a look at karma while I've bashing out some code.
Thanks again for the great work!!


Say Hi, Class of Fall 2021

If you have completed the getting started assignment, please reply with a link to your github repository.

Hello Professor Crump,
Here is a link to my first repository. Looking forward to the course!
https://github.com/trans-Gaines/7709G.Test

Hi Professor Crump,
Below is the link to my first repository:
https://github.com/AmandaPMurphy/7709GitTest

Hi Prof. Crump,
Here is a link to the repository for this course.
https://github.com/djshives/PSYC7765G

Hi Professor Crump,
Here is a link to my first repository.
https://github.com/TiffanyHanratty/7709GitTest

Hello Professor Matthew Crump,
Here is the link for the first repository ;
https://github.com/alihaydarozgun/7709GitTest

Testing.
https://github.com/ksrm/Stats-7765


infinite loop?

Hi,
I have been using stringtie for the past year with some success to de novo assemble a plant transcriptome. However, lately there is one sample that seems to be running forever. The other samples in the same batch completed with no problems.
I tried to search around for clues but couldnt find any. The mapping rate seems ok, although there were a bit more multi-mappers for this specific sample as compared to other samples. Any ideas how I could resolve this issue?
Thanks.

I guess it is not impossible for the data in that sample to have generated some strange graph configuration that we haven't expected and, as the title suggested, an infinite loop might have been triggered there.. Since we just released the 1.3.2 version today and there were some internal changes that might have affected (prevented) rare situations like these, could you give this new version a try on that sample?
If that doesn't resolve it we would definitely like to take a look at those sample data.  If you run stringtie with a single thread (no -p option) and with the -v option, the program should show at stderr what is the region (bundle location) where it gets stuck -- so then using samtools view -b you could extract the alignments from that region and share it with us to investigate how that happens.

Hi,
Thanks for the reply. I did as you requested and here are the lines from
samtools (there were only few lines):
HWI-ST840:509:HYL5KADXX:1:2204:7129:81085 99 000080F_pilon 205660 50 101M =
205763 203
CGAAAGAGCACCGCACATCACGTGGTGTCTGGTGTGCCCCCAGTGGCCCCTAAAAATTTGAAGGACCGAGTGTCGTCCATGCTCGATTGTATTTATAATTG
@@@@BDDDFHDHFGIDHIDFE@EG
??@FECGEHGFGGGEEEGG=CGIIIEHECHFHHEEEEEBCCCC?;=8<:>8?B?BCCCCCBBCCB>CDEEDEC::C>
AS:i:-5 XN:i:0 XM:i:1 XO:i:0XG:i:0 NM:i:1 MD:Z:62A38 YT:Z:UU NH:i:1
HWI-ST840:509:HYL5KADXX:1:2204:7129:81085 147 000080F_pilon 205763 50
81M1I19M = 205660-203
TCAGGTCTCCAAGGTGAATAGCCTCTGGTCGATAGAACAATGTAGGCAAGGGAAGTCGACAAAATGGATCTGTAACCTCAGAAAAAAAGATTGGCTTTAAG
9DC?BA<:DCDDDCDEDDDDDDDDBBDDFDFDDFHHHHEHEGIIIIGJJJIJJIHGIJIJJJIGGJJIFIIGHIGGEGJJJJJJJJJIHHHDGFFFDD@
@@ AS:i:-14 XN:i:0XM:i:1 XO:i:1 XG:i:1 NM:i:2 MD:Z:69T30 YT:Z:UU NH:i:1
kevin@juggernaut:/fs/durio/wts/02_ALIGNMENT/tophat_out/d1_falcon_pilon_TN1506R0333$
samtools view accepted_hits.bam 000080F_pilon:205660-205862
HWI-ST840:509:HYL5KADXX:1:2204:7129:81085 99 000080F_pilon 205660 50 101M =
205763 203
CGAAAGAGCACCGCACATCACGTGGTGTCTGGTGTGCCCCCAGTGGCCCCTAAAAATTTGAAGGACCGAGTGTCGTCCATGCTCGATTGTATTTATAATTG
@@@@BDDDFHDHFGIDHIDFE@EG
??@FECGEHGFGGGEEEGG=CGIIIEHECHFHHEEEEEBCCCC?;=8<:>8?B?BCCCCCBBCCB>CDEEDEC::C>
AS:i:-5 XN:i:0 XM:i:1 XO:i:0XG:i:0 NM:i:1 MD:Z:62A38 YT:Z:UU NH:i:1
HWI-ST840:509:HYL5KADXX:1:2204:7129:81085 147 000080F_pilon 205763 50
81M1I19M = 205660-203
TCAGGTCTCCAAGGTGAATAGCCTCTGGTCGATAGAACAATGTAGGCAAGGGAAGTCGACAAAATGGATCTGTAACCTCAGAAAAAAAGATTGGCTTTAAG
9DC?BA<:DCDDDCDEDDDDDDDDBBDDFDFDDFHHHHEHEGIIIIGJJJIJJIHGIJIJJJIGGJJIFIIGHIGGEGJJJJJJJJJIHHHDGFFFDD@
@@ AS:i:-14 XN:i:0XM:i:1 XO:i:1 XG:i:1 NM:i:2 MD:Z:69T30 YT:Z:UU NH:i:1
Please let me know if you found out the problem.
Thanks.
Regards,
Kevin
ᐧ
On Wed, Jan 25, 2017 at 10:00 AM, Geo Pertea<EMAIL_ADDRESS>wrote:

I guess it is not impossible for the data in that sample to have generated
some strange graph configuration that we haven't expected and, as the title
suggested, an infinite loop might have been triggered there.. Since we just
released the 1.3.2 version today and there were some internal changes that
might have affected (prevented) rare situations like these, could you
give this new version a try on that sample?
If that doesn't resolve it we would definitely like to take a look at
those sample data. If you run stringtie with a single thread (no -p
option) and with the -v option, the program should show at stderr what is
the region (bundle location) where it gets stuck -- so then using samtools
view -b you could extract the alignments from that region and share it
with us to investigate how that happens.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gpertea/stringtie/issues/91#issuecomment-274998325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMn6uFPQsTzbM0gi45dlPwuDgNxP4vbtks5rVqzPgaJpZM4Ls9Qb
.

That's not a good way to share SAM alignments, some information might get lost when you simply copy and paste text like this in a web post. I meant to get a binary bam file (samtools view -b ...), which also has some header information I might need, after indexing your bam file of course (samtools index) and also please provide me with the stringtie command line you used and possibly the reference annotation that you used (if you did use one in that command line). You should either attach the .bam file and the annotation file to the posts here (which might not work for larger files) or e-mail them to me as attachments (or use a file sharing service if you prefer).  Of course the command line could be posted right here (and it is a good idea to put that and the stringtie version in the first post when you have a bug report).
Also, you haven't answered my other question -- should I assume that this happened with stringtie v1.3.2 version we just released?

Sorry for the confusion. We used v1.3.2 initially and subsequently v1.3.2b which was released two days ago as advised by you.
We are using stringtie with default parameters, the command line is something like this: stringtie .../tophat_dir/accepted_hits.bam -o results.gtf
As we are studying a new species, we do not have reference annotation. I have attached the files here. Please let us know. Thanks very much for your help.
debug.zip

Can you actually reproduce this problem on your side when you run stringtie on this small .bam file you sent me?
Because I can't see any problem here, this is what I get:
$ stringtie -v -o out.gtf debug.bam
Command line was:
../stringtie -v -o out.gtf debug.bam
Default stack size for threads: 8388608
[01/26 10:09:02]>bundle 000080F_pilon:205660-205862(2) (0 guides) loaded, begins processing...
[01/26 10:09:02]^bundle 000080F_pilon:205660-205862(2) done (0 processed potential transcripts).
[01/26 10:09:02] All threads finished.
Total count of aligned fragments: 2
Fragment coverage length: 100.5

What is the output that you get when you run the same command on this small debug.bam file?

Thinking more about this, it's possible that stringtie gets stuck trying to read the next bundle, if there is something strange in that accepted_hits.bam file (corrupted or otherwise unusual). It would be interesting to take a look -- perhaps you could share the whole accepted_hits.bam file in this case. If you cannot put it on a file sharing service drop me an e-mail at<EMAIL_ADDRESS>and I can send instructions for ftp upload to our server here.
You could also try to load that accepted_hits.bam in IGV to visually check if there is anything unusual following this very small region (000080F_pilon:205660-205862).

I am closing this for now for lack of follow up by the OP -- but please,  kevlim83 if you are getting this and still have that issue I'd be glad to re-open the investigation.


datadog version 6: datadog API keys are not being used/are empty.

Issue description
@tazjin, @rvl  I am using
      services.datadog-agent.apiKeyFile = "/run/keys/datadog_api_key";

per https://nixos.org/nixops/manual/#idm140737318276736
(with 29929 being the pid of datadog):
cat /proc/29929/environ:
LANG=en_US.UTF-8INVOCATION_ID=59410c140d3f423b9626325cfc607f8bDD_API_KEY=USER=datadogTZDIR

One of the issues is that without a key set anywhere (there are two places to set a key, IIRC) it shouldn't even start.
Another is that I don't know how to get a key in, since none of the documented methods work for me.
and that clearly doesn't work or there is something which unsets the environment variable immediately after it has been loaded, but in that case I have no way to check whether an API key was actually set correctly, which is also an issue.
Technical details
This applies to master.

I think the core of the issue is that there is no support for NixOps deployment.keys. As a result there is a race condition in making the keys available. What is supposed to happen is that systemd waits for the key file to be present and then it would try to start the datadog-agent. In the current module, not such dependency is defined so that would have to be done by the user.
 {
      datadog-agent = makeService {
        description = "Datadog agent monitor";
        preStart = ''
          chown -R datadog: /etc/datadog-agent
          rm -f /etc/datadog-agent/auth_token
        '';
        script = ''
          export DD_API_KEY=$(head -n 1 ${cfg.apiKeyFile})
          exec ${datadogPkg}/bin/agent start -c /etc/datadog-agent/datadog.yaml
        '';
        serviceConfig.PermissionsStartOnly = true;
      };

Yes that's a gotcha with NixOps deployments.keys in general.
I usually handle it like this:
  deployment.keys."myservice-password" = {
    text = builtins.readFile ../secrets/myservice-password;
    user = "myserviceuser";
    group = "myservicegroup";
    destDir = "/var/lib/keys"; # this will stay after rebooting
  };
  users.users.myserviceuser.extraGroups = ["keys"];
  systemd.services.myservice = {
    after = ["myservice-password-key.service"];
    wants = ["myservice-password-key.service"];
  };

Yes, I just discovered that too :)
IMHO, the datadog service should have an option named use_nixops_deployment_keys and then do the right thing.

The same issue affects all NixOS services which depend on keys being present at start time. There is probably already a ticket open for this feature request.


ISPN-6271 Stream filterKeys reads keys not owned remotely when it

shouldn't

Make sure key filter uses local cache to look up on each node

https://issues.jboss.org/browse/ISPN-6271

Looks good. Pulling ...

Integrated. Thanks @wburns !


pass-task

Patch

Report what was rendered and how long it took using hrtime.
Pass composer-level route with next() if NotFoundError

+1

:+1: