Fill basic info for users auto-created using a reverse proxy

As quoted from https://github.com/gogits/gogs/issues/165 :
Greetings @Unknwon !
I would also be interested in having a way to have a way to fill basic info about the user auto-created by ENABLE_REVERSE_PROXY_AUTO_REGISTRATION.
As said by previous commenters, it could either be passed using http headers, or if available using a configured LDAP provider (this is what others application usually do when applicable)
The use case is simple: I would love to at least have the correct mail for the user so he/she does not have to redefine profile info after initial login. (it is needed for mails to be sent in case of updates and having to redefine it is tedious especially when the info is actually already available somewhere)
The user first name / last name would be a bonus (if possible, but the mail is more important)
I'll be around if you need precisions :)

Thanks your feedback!

Also, it might be a good idea to be able to set a default identification provider for newly created users, in case the user that was auto created comes from an identification provider known to Gogs (a LDAP server, maybe). This way, you would be able to provision automatically all user details
I think the best approach would be, in case a new user unknown to Gogs just authenticated using headers, to search for this user in the configured authentication providers, and if the user is not found fallback to what Gogs already does: create a local user with a randomly generated password and mail.
The bonus point would be a setting to tell gogs if a user can not be found in the authentication backend, to refuse the login, but it's not really necessary in a first iteration

Thanks for your comments!
Just want to point out that the basic rule of this feature is: everything come from header is valid, not check process perform by Gogs. This is my understanding...

We've started to use Gogs for our team's code archive, and this feature would be great! While we could use an LDAP source for the extra user identity data, getting the core fields from headers provided by the Auth proxy would be fine for us (and simpler).

I'd greatly prefer to keep everything inside GOGS; it's nice that accounts are now autocreated but they are indeed missing the name and e-mail fields currently. It would be nice to have a "default provider" for that (i.e. a configured LDAP auth backend), and have it pull the user's data from that backend upon creation.
I think we'll make do for now with an outside script that fills in missing data for e-mails ending in @localhost.

having a setting to define the default created passwords would help
ENABLE_REVERSE_PROXY_AUTO_REGISTRATION_EMAIL = X-Forwarded-Email

or
ENABLE_REVERSE_PROXY_AUTO_REGISTRATION_EMAILNAME = X-Forwarded-User
ENABLE_REVERSE_PROXY_AUTO_REGISTRATION_EMAILDOMAIN = "company.com"


Check the section index on tableView:numberOfRowsInSection: call

The tableView:numberOfRowsInSection: method might be called before the numberOfSections. Thus we should validate the section index to prevent the Index out of range error.
Here is the example that causes a crash:
struct SectionOfCustomData {
    var items: [Item]
}
extension SectionOfCustomData: SectionModelType {
    typealias Item = String

    init(original: SectionOfCustomData, items: [Item]) {
        self = original
        self.items = items
    }
}

class RxTableViewController: UIViewController {

    var tableView: UITableView!
    let disposeBag = DisposeBag()

    let dataSource = RxTableViewSectionedReloadDataSource<SectionOfCustomData>()

    override func viewDidLoad() {
        super.viewDidLoad()

        self.tableView = UITableView(frame: self.view.bounds, style: .plain)
        self.view.addSubview(self.tableView)

        self.tableView.tableFooterView = UIView()
        self.tableView.register(UITableViewCell.self, forCellReuseIdentifier: "Cell")
        self.tableView.rowHeight = UITableViewAutomaticDimension
        self.tableView.estimatedRowHeight = 100

        Observable.just([SectionOfCustomData]()).asDriver(onErrorJustReturn: []).drive(tableView.rx.items(dataSource: self.dataSource))
            .addDisposableTo(disposeBag)
    }
}

please, accept this pull request, i also have the same problem (weird, but real!)

Hi guys,
I'm curious why is this necessary. I'm also using RxDataSources in prod but didn't have any problems.
@hariseldon78 @sgl0v  Is it possible that you are doing something wrong? I have a feeling this would only mask the real problem.

@kzaher It's difficult for me to prepare a minimal project demonstrating the crash, my suspects are about some kind of race condition, the data to be shown in the tableview will be downloaded soon on a background scheduler. Certain is that the "numberofsections" is not called, i guess uikit in some cases presume (wrongly) that there is at least one section.

Hi @hariseldon78 @sgl0v ,
your experience basically means that there is a somewhere a problem with data synchronization.
If that problem is somewhere in this library then we need to find that place and fix it there.
Patching this one method won't do any good since if that problem exists it can also cause wrong number of rows being reported etc ...
I haven't had any issues with latest version in production so it is also possible that @hariseldon78 you are experiencing some local issue.
Try to check if you are updating UI data that table view depends on from background thread. If that is the case, then this is where the error probably lies.
If this is not the case then we need some more info to help us locate the real issue.

@kzaher It is clear from the example I've provided that the issue is not related to updating UI from the background thread. Eventually solved the issue by setting tableFooterView after the UITableView's dataSource. In other case UIKit expects to have at least one section and tableView:numberOfRowsInSection: gets called before the numberOfSections.

Hi @sgl0v ,
Sorry for dismissing your report as error on your part. We get a lot of false reports, so this was occam's razor error.
I've investigated this issue and it looks like UITableView has internal bug. It delays transient state even after delegate is changed.
The real workaround should actually be committed to the main repo.
extension ObservableType {
    func subscribeProxyDataSource<P: DelegateProxyType>(ofObject object: UIView, dataSource: AnyObject, retainDataSource: Bool, binding: @escaping (P, Event<E>) -> Void)
        -> Disposable {
        // this is needed to flush any delayed old state (https://github.com/RxSwiftCommunity/RxDataSources/pull/75)
        object.layoutIfNeeded()
        let proxy = P.proxyForObject(object)
        let disposable = P.installForwardDelegate(dataSource, retainDelegate: retainDataSource, onProxyForObject: object)

object.layoutIfNeeded() solves the problem by flushing old state.
I think it would also be prudent do apply the same fix to the end of subscribeProxyDataSource method to solve the same issue when proxy is being cleared.
        return Disposables.create { [weak object] in
            Disposables.create(subscription, disposable)
            object?.layoutIfNeeded()
        }

Feel free to create this PR to the main repo so we can patch this properly, or I can also do it if you like.

@kzaher As discussed, I've created PR in the RxSwift repo.

@kzaher @sgl0v
I'm having issues with Index out of range in version 1.0.2 when setting
tableView.rowHeight = UITableViewAutomaticDimenssion
tableView.estimatedRowHeight = 60

removing the code above solves this issues.

@yuriferretti Calling tableView.layoutIfNeeded() before binding to the data source prevents this issue.

Hi @kzaher @sgl0v
In v3.1.0  I met the same crash.
func subscribeProxyDataSource<P: DelegateProxyType>(ofObject object: UIView, dataSource: AnyObject, retainDataSource: Bool, binding: @escaping (P, Event<E>) -> Void)
    -> Disposable {
let proxy = P.proxyForObject(object)
let unregisterDelegate = P.installForwardDelegate(dataSource, retainDelegate: retainDataSource, onProxyForObject: object)
 // this is needed to flush any delayed old state (https://github.com/RxSwiftCommunity/RxDataSources/pull/75)
object.layoutIfNeeded()

move object.layoutIfNeeded() to the top of subscribeProxyDataSource  solves the problem.
check the source code on master, I found it changed at commit id: 5d44554, is this a merge mistake ?

@kzaher @sgl0v It seems that in some situations the layoutIfNeeded is called too early. I have a collection view with self-sizing cells (estimatedItemSize != CGSize.zero) and the autolayout engine throws the UIViewAlertForUnsatisfiableConstraints exception on this layoutIfNeeded line lamenting about some mysterious _UITemporaryLayoutWidth constraints. Searching Google and finding just a few results on SO it seems that these temporary constraints are added to the views before the views are added to the superview, at which time it is not expected layoutIfNeeded to be called: doing so causes the unsatisfiable constraints exception.

Hi @mrtj ,
why don't you add view to subviews first and then bind?

Thank you, your suggestion worked. I had a bit complicated code creating these views having no access to viewDidLoad event, and I did not think that I could posticipate the binding. But the old dirty trick of DispatchQueue.main.async worked

Same problem.  Both calling collectionView.layoutIfNeeded and DispatchQueue.main.async seem to fix the issue.
@mrtj Why does DispatchQueue.main.async work?

We are already calling layoutIfNeeded.
extension ObservableType {
            func subscribeProxyDataSource<P: DelegateProxyType>(ofObject object: UIView, dataSource: AnyObject, retainDataSource: Bool, binding: @escaping (P, Event<E>) -> Void)
                -> Disposable {
                let proxy = P.proxyForObject(object)
                let unregisterDelegate = P.installForwardDelegate(dataSource, retainDelegate: retainDataSource, onProxyForObject: object)
                // this is needed to flush any delayed old state (https://github.com/RxSwiftCommunity/RxDataSources/pull/75)
                object.layoutIfNeeded()

I don't think we can call it before because if delegate is nil then UI{Table,Collection}View will crash and we can't do anything about that.
I'm not sure what issues do you have since I don't have any repro code.

@ryanmeisters The Stack Overflow answer linked in my previous post came to the conclusion that these _UITemporaryLayoutWidth related warnings are present if someone (in this case RxCocoa in the bind method) calls layoutIfNeeded before the table/collection view is added to the view hierarchy. So the simplest solution is to ensure that the table/collection view is added to its superview before calling bind. Unfortunately I could not do so because I do not have complete control over the lifecycle of the view, so as a "dirty hack" I opted for dispatch async to give some time to the code that creates the view and later adds it to the hierarchy to complete its job.

This problem seems to have come up again with Xcode11 beta.   We see warnings like UITableView was told to layout its visible cells and other contents without being in the view hierarchy (the table view or one of its superviews has not been added to a window).  This is on a tableviewcontroller from a storyboard in viewDidLoad.  The table should be be in the view hierarchy at that point yet the errors are appearing.
It's not clear to me if there is a bug in UIKIt or if this approach in RxCocoa is no longer valid.

One more thing I ran the example project and it also exhibits this problem when you tap into the "Customization using table view delegate" item

I had a similar problem @SlashDevSlashGnoll

Why it's called "object?.layoutIfNeeded()" on dispose?

@SlashDevSlashGnoll  Me too!

@SlashDevSlashGnoll  me too.

same

same


Can't compile when accessing properties on strings

What's the correct way to access properties on strings? I can't seem to make this work:
let getLength (s: String) : Number =
  s.length
console.log (getLength "hello there")

I get:
Error: Type error: String is not {length: 'bt}
    at /var/abs/local/roy/src/typeinference.js:45:19
    at Object.visitAccess (/var/abs/local/roy/src/typeinference.js:305:17)
    at [object Object].accept (/var/abs/local/roy/src/nodes.js:198:26)
    at /var/abs/local/roy/src/typeinference.js:139:17
    at /var/abs/local/roy/src/typeinference.js:185:24
    at Array.map (native)
    at Function.map (/var/abs/local/roy/node_modules/underscore/underscore.js:100:56)
    at Object.visitFunction (/var/abs/local/roy/src/typeinference.js:184:32)
    at [object Object].accept (/var/abs/local/roy/src/nodes.js:33:26)
    at /var/abs/local/roy/src/typeinference.js:139:17

Using 136665929c9. Thanks.

This is a problem with Roy's type-system but I'm not sure what the best solution is:

I don't think it's wise to encode properties like length in the type-system for the String and Array types. You could just call s.length. But what if a specific engine (or library) provides an extra property we don't know about?
We could provide native JS functions that call these properties without type-safety. You would have to call stringLength s. Would work for extra properties but wouldn't be too nice.

Any other ideas?

I don't think it's wise to encode properties like length in the type-system for the String and Array types.

I agree. I just skimmed through the examples so I am not just what Roy can or can't do. Some thoughts about this issue (I hope not too misleading):
https://gist.github.com/1641425
It would be great to have default modules with the usual suspects for FP (List.map, etc)


How to create a very simple command line

Imagine I have a project called 'tool' and I want to add command line support.
The tool has no subcommands and I just want to be able to call it like
`tool -i path/to/input -o path/to/output -f1 -f2 f3'
I don't want to have something like
`tool command -i path/to/input -o path/to/output -f1 -f2 f3'
How would I do that? As the examples only showed how to do the later version.

You're looking for https://commanddotnet.bilal-fazlani.com/gettingstarted/getting-started-140-default-commands/

Yes, thats it. Thanks for the link.


Better to disable copying of SequentialFile and RandomAccessFile

Not a bug, but a coding style improvement. To prevent anyone from passing
SequentialFile or RandomAccessFile by value to a function incidentally.

What version of the product are you using? On what operating system?

Revision 37. on Ubuntu 10.04 x86-64 with g++ 4.4.3

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 17 Jul 2011 at 3:11
Attachments:

disable_copying.diff

Original comment by<EMAIL_ADDRESS>on 17 Jul 2011 at 5:35

Changed state: Accepted

Original comment by<EMAIL_ADDRESS>on 30 May 2012 at 5:23

Changed state: Started

Original comment by<EMAIL_ADDRESS>on 8 Oct 2012 at 9:23

Changed state: Fixed


Give hog ult negation passive

Created by: MaxwellJung
OW1 roadhog had ult negation passive.

mentioned in merge request ow1_emulator_backup!405

moved from ow1_emulator_backup#639


Show error, when a project as the same name already exit

issue
when creating a project, the same name as the project that already exists, it just overwrites the existing project
what you need to do
show an error if a project already exists and don't execute the command that creates the project(exit)

@saurabhdaware ,
I finished this 😅


the second sliding cell, delelte icon layout problem

I hope to see you solve the problem as soon as possible, thanks


Platform Exception locale = null

🐛 Bug Report
E/flutter (17224): PlatformException(error, locale == null, null)
E/flutter (17224): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:551)
E/flutter (17224): #1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:279)
E/flutter (17224):
E/flutter (17224): #2      Geolocator.placemarkFromCoordinates (package:geolocator/geolocator.dart:228)
Expected behavior
It should be grabbing the locale from my phone if a locale isn't specified.
Reproduction steps
Using placemarkFromCoordinates without passing a locale. Working perfectly if a locale is specified.
Configuration
Version: 1.6.4
Flutter: 0.7.5
Platform:

[ ] :iphone: iOS
[x] :robot: Android

@fawadkhanucp thank you for reporting this bug, we will get to it immediately and send out an update today.

@fawadkhanucp just a quick update, we just release version 1.6.5 which fixes the above issue.
Thanks again for reporting the issue.

looks like the build failed

@fawadkhanucp the code compiles correctly, we do however have some issues with Travis-CI timing out.
So we do need to go and see if we can optimize the build script to prevent these timeouts. For now I restarted the build job and hopefully all will go smooth now.

ah okay. thanks

does someone have to do something for it to get pushed to dart pub?

@fawadkhanucp yes, and I was sure I did yesterday (guess not :-P)

haha. thanks. appreciate all the quick responses.


Client Runs page's node export infinite loop

:nut_and_bolt: Description
Preventing the Client Runs page's node export from going into an infinite loop. To cause the infinite loop when using the node export, a user needs to have nodes with the same name that has uppercase characters. This bug is caused by using the Elasticsearch SearchAfter API with non-matching curser values. When requesting the second page of values the last value from the first page's node name is used in the request. For the node-state index, the node name values are matched as lower-case, but the code was sending the values with uppercase. When this happens, SearchAfter API will return the first page again.
I have not seen that this infinite loop timeout in any way. Therefore a context deadline of one minute was added to prevent this from happening again.
:athletic_shoe: Demo Script / Repro Steps

build components/config-mgmt-service && start_all_services
Create 101 nodes with the same name but different UUIDs for i in {1..101}; do send_chef_run_example; done
Open https://a2-dev.test/client-runs and export the nodes

:chains: Related Resources
https://github.com/chef/automate/issues/747
:white_check_mark: Checklist

[x] Necessary tests added/updated?
[ ] Necessary docs added/updated?
[x] Code actually executed?
[x] Vetting performed (unit tests, lint, etc.)?

I am going to merge this now. I will create a new PR If we decide that we need to change the context.
Thank you all for the reviews.


Unable to connect to the partner center powershell module via secure application method

i am trying to connect to the partner center powershell module v2.0, below are the set of commands which I am using for the connection :
$cred=Get-Credential
$appid=""
$tenant=""
New-PartnerAccessToken -ApplicationId $appid -Credential $cred -Scopes "https://api.partnercenter.microsoft.com/user_impersonation" -ServicePrincipal -Tenant $tenant -UseAuthorizationCode
Below is the error which I receive.

The redirect URI which i have set is https://localhost/
and the article used for reference is https://docs.microsoft.com/en-us/powershell/partnercenter/multi-factor-auth?view=partnercenterps-2.0

@SachinUpreti13 when using the UseAuthorizationCode parameter you will be prompted to authentication interactively using the authorization code flow. The redirect URI value will be generated dynamically. The generation process will attempt to find a port between 8400 and 8999 that is not in use. Once an available port has been found, the redirect URL value will be constructed (e.g. http://localhost:8400). So, it is important that you have configured the redirect URI value for your Azure Active Directory application accordingly.

if we are using our marketplace then how that should be the redirect URL for eg my marketplace address is www.abc.com. Then how should I use it in the application.

@SachinUpreti13 I am not sure that I follow what you are asking. Would it be possible for you to provide an example?

@SachinUpreti13 if you are still having issues please let me know.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
1 minute
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
14 seconds
sanity-inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
43 seconds
clair-scan

✅ Succeeded
26 seconds
sbom-json-check

✅ Succeeded
14 seconds
sanity-label-check

✅ Succeeded
15 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
show-summary


[V] Dashboard page

Figma

[ ] Toasts
[ ] Remember hidden toasts with local storage
[ ] Segment assignments
[ ] Unsubmitted log drafts
[ ] Recently submitted logs
[ ] Connect to backend ... some features may not exist yet (backend#31)

/cib dashboard page

Branch 65-dashboard-page created!


Improve top level README(s).

TODO

Still there are some other things to improve like running the app and other things. Concerning this, other issue might be necessary.


[Feature request] open archives using memory mapped files

I have only briefly looked into internals of this library, but I noticed that in tests Files are created by memory mapping some fixtures from disk. would it be possible to open entire archive like this? cause if I'm correct reading an archive from path loads the entire file into memory. It would greatly decrease disk operations cause most of the time only one file is extracted from a BSA archive at a time.
if you're interested in adding such a feature I'd be happy to give it a go - if it makes sense at all of course

Archives read from a path are memory mapped

oh


Updating view of  Disord and youtube channel link

Description of feature request, idea
Instead of placing link in text
It will be attractive if we pace link in icon
For Discord link place a Discord icon and when we click that it should redirect to Discord group
same for Youtube Link also need a Youtube Icon when we click that it should redirect to Youtube channel

No response

i would like to work on this

Where is this proposed change for?


Catch the minimum_cut NetworkXUnbounded exception and give clear error message

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes #1232.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Since the graph can be very large with double number of nodes(in and out), I think we don't print out the graph for now


Proxy setting for Azure OpenAI

Hello and thanks for the great work so far,
we're running librechat on docker using the provided images.
We've noticed that the rag_api is having issues downloading "/encodings/cl100k_base.tiktoken" from "openaipublic.blob.core.windows.net" because it's not using our proxy server.
After searching for a bit we found out that there's a setting for OpenAI that let's you define a proxy but not for other embeddings.
https://github.com/danny-avila/rag_api/blob/main/config.py#L177-L194
Please add the possibility to configure the Proxy for at least AzureOpenAI as well.
EDIT:
Or is there another way to configure rag_api to use a proxy for loading the embeddings for AzureOpenAI?
If so, please let me know :)
I'm not familiar with Python/Langchain and all this, so I'm a bit confused.
-- End edit
Here's the log from the ragapi container:
LOGFILE rag_api ==================================================================================

USER_AGENT environment variable not set, consider setting it to identify your requests.
2024-11-08 08:50:55,373 - root - INFO - Initialized embeddings of type: <class 'langchain_openai.embeddings.azure.AzureOpenAIEmbeddings'>
/app/store_factory.py:22: LangChainPendingDeprecationWarning: Please use JSONB instead of JSON for metadata. This change will allow for more efficient querying that involves filtering based on metadata.Please note that filtering operators have been changed when using JSOB metadata to be prefixed with a $ sign to avoid name collisions with columns. If you're using an existing database, you will need to create adb migration for your metadata column to be JSONB and update your queries to use the new operators.
  return AsyncPgVector(
2024-11-08 08:50:55,446 - uvicorn.error - INFO - Started server process [1]
2024-11-08 08:50:55,446 - uvicorn.error - INFO - Waiting for application startup.
2024-11-08 08:50:55,446 - uvicorn.error - INFO - Application startup complete.
2024-11-08 08:50:55,446 - uvicorn.error - INFO - Uvicorn running on http://<IP_ADDRESS>:8000/ (Press CTRL+C to quit)
2024-11-08 08:53:36,089 - root - ERROR - HTTPSConnectionPool(host='openaipublic.blob.core.windows.net', port=443): Max retries exceeded with url: /encodings/cl100k_base.tiktoken (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7fd60796abc0>, 'Connection to openaipublic.blob.core.windows.net timed out. (connect timeout=None)'))

@JulianHandrup thanks for bringing this up.
Added relevant env variables here #97


--filter-same-class broken when running in gui

Hi, thank you for your amazing project
I found a bug when using --daemon and --filter-same-class
RUST_BACKTRACE=full hyprswitch --daemon --filter-same-class -v
WARN Daemon not running, starting daemon
INFO Starting gui
INFO Starting daemon
INFO Starting listener on /tmp/hyprswitch.sock
WARN No Icon and no desktop file with icon found for term-dotfiles
thread '<unnamed>' panicked at src/gui.rs:88:111:
Failed to get icon path
stack backtrace:
   0:     0x5cae82a8d259 - <unknown>
   1:     0x5cae82a378d0 - <unknown>
   2:     0x5cae82a6444e - <unknown>
   3:     0x5cae82a8ea5e - <unknown>
   4:     0x5cae82a8e385 - <unknown>
   5:     0x5cae82a8f27e - <unknown>
   6:     0x5cae82a8edc0 - <unknown>
   7:     0x5cae82a8ed16 - <unknown>
   8:     0x5cae82a8ed03 - <unknown>
   9:     0x5cae829d1164 - <unknown>
  10:     0x5cae829d1762 - <unknown>
  11:     0x5cae829e0220 - <unknown>
  12:     0x5cae829f0865 - <unknown>
  13:     0x5cae82a43f2a - <unknown>
  14:     0x70f914540199 - <unknown>
  15:     0x70f91459f3bf - <unknown>
  16:     0x70f91453f712 - g_main_context_iteration
  17:     0x70f914709ed6 - g_application_run
  18:     0x5cae829ebf47 - <unknown>
  19:     0x5cae829eca82 - <unknown>
  20:     0x5cae82a8fef5 - <unknown>
  21:     0x70f9140cc55a - <unknown>
  22:     0x70f914149a3c - <unknown>
  23:                0x0 - <unknown>
[1]    100121 IOT instruction (core dumped)  RUST_BACKTRACE=full hyprswitch --daemon --filter-same-class -v

if this ever happens again it will print out the invalid path instead of just exiting


[TH2-4991] Add ability to create batches with custom book.

Closed because 'batcher batches messages by session group only without looking into the book'


Nit: add punctuation.

Description
Nit: adding punctuation to README.md.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests

Codecov Report

Merging #5 (36ad05f) into main (ebde09e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   91.57%   91.57%
=======================================
  Files           7        7
  Lines         285      285
=======================================
  Hits          261      261
  Misses         18       18
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebde09e...36ad05f. Read the comment docs.


Update Project.toml

Bump patch version for new release

Whoops, didn't see we already did a new release


[NTR]: Peyer's patch T cell

Note - please check that the term does not already exist (check OLS: https://www.ebi.ac.uk/ols/ontologies/cl)
Preferred term label:
Peyer's patch T cell
Synonyms
T cell of Peyer's patch
Definition (free text, please give PubMed ID in format PMID:XXXXXX)
A mature T cell which resides in the Peyer's patch of the small intestine
Parent cell type term (check the hierarchy here https://www.ebi.ac.uk/ols/ontologies/cl):
mature T cell: http://purl.obolibrary.org/obo/CL_0002419
What is the anatomical structure that the cell is a part of? Please check Uberon: https://www.ebi.ac.uk/ols/ontologies/uberon
Peyer's patch: http://purl.obolibrary.org/obo/UBERON_0001211
Your nano-attribution (ORCID)
0000-0003-4183-8865
Any additional notes or concerns
I know there are more specific parent terms for this such as Peyer's patch T cell area http://purl.obolibrary.org/obo/UBERON_0010387 but we want to keep this more generic as to be easier for ontology mapping heirarchy with what users define as their cell types. e.g. Peyer's patch [org part]; T cell [cell type] is more likely

Peyer's patches in humans (and mice) have a mix of CD4+ and CD8+ alpha-beta T cells, as well as gamma-delta T-cells (CD3+/CD4-/CD8-).  I'm not a big fan of a term that simply provides localization for a fairly high level T cell class (mature T cell), when the underlying data driving this term request may actually have much more biologically relevant marker detail about the T cells in question.
So convince me that this term is not too non-specific and that the relevant data cannot simply rely on post-coordination of CL and Uberon terms for annotation.  (Other CL editors can weigh in here too)

Hi @addiehl thanks for the query. We were thinking about this a bit before requesting it. Our reasoning is that for the gut anatomograms we will find multiple cell types but they will be derived from different organism parts. In this case we would use T cell (generic) and its child terms to map to cell type terms for samples derived from the lymph node (we would also have T cell as a child term of org part lymph node). Whereas what we see in datasets are people specifically sampling Peyer's patches for immune and other resident cells to identify their specific roles. We would like to add this term to complement Peyer's patch B cell and Peyer's patch macrophage labels.
I do agree that my addition of mature to the definition could be misleading though - definitely willing to defer on your experience for this!

Given objections, might be better in EFO with same def.

@ngeorgeebi
I'll add this in EFO as agreed, but I have a question, your original request points to the Uberon term for generic Peyer's patch (http://purl.obolibrary.org/obo/UBERON_0001211), but your suggested definition refers to Peyer's patch of the small intestine, which would be http://purl.obolibrary.org/obo/UBERON_0003454. Could you please confirm that you refer to UBERON_0001211? Thanks.

Hi Paola
Sorry I meant to reply immediately. I did a bit of digging with this actually and Peyer’s patches seem to be only located in the small intestine with the majority in the ileum so you are correct actually in that this should be mapped to the more specific term of Peyer’s patch of the small intestine.  I would then change this to refer to  http://purl.obolibrary.org/obo/UBERON_0003454 http://purl.obolibrary.org/obo/UBERON_0003454.
Best
Nancy

On 12 Nov 2020, at 15:12, paolaroncaglia<EMAIL_ADDRESS>wrote:
@ngeorgeebi https://github.com/ngeorgeebi
I'll add this in EFO as agreed, but I have a question, your original request points to the Uberon term for generic Peyer's patch (http://purl.obolibrary.org/obo/UBERON_0001211 http://purl.obolibrary.org/obo/UBERON_0001211), but your suggested definition refers to Peyer's patch of the small intestine, which would be http://purl.obolibrary.org/obo/UBERON_0003454 http://purl.obolibrary.org/obo/UBERON_0003454. Could you please confirm that you refer to UBERON_0001211? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/obophenotype/cell-ontology/issues/795#issuecomment-726139000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO3NYFOQBKFWPPM75UC52TSPP3PNANCNFSM4S4VCP4Q.

Dr. Nancy George
Bioinformatician
Functional Genomics Group
EMBL - European Bioinformatics Institute
Wellcome Trust Genome Campus, Cambridge UK

Thanks @ngeorgeebi . Summing up for self:

[ ] Add EFO:NEW small intestine Peyer's patch T cell
subclass of mature T cell http://purl.obolibrary.org/obo/CL_0002419
part of small intestine Peyer's patch http://purl.obolibrary.org/obo/UBERON_0003454
“A T cell which resides in the Peyer's patch of the small intestine.”
dbxref: http://orcid.org/0000-0003-4183-8865
Synonyms:
T cell of small intestine Peyer's patch
T cell of Peyer's patch of small intestine

Should have logical definition:
EquivalentTo: 'mature T cell' that 'part of' some 'small intestine Peyer's patch'
Seems likely we'll add specific classes for these later. The logical def will make sure they are automatically classified.

@ngeorgeebi
Peyer's patch T cell EFO_0010896


Stampede Stage Requires Charm Check

https://github.com/m-h-c-t/mh-helper-extension/blob/45565c02c70f5591a2cc4cad7635fb1d5b38fe18/src/scripts/main.js#L1492
Currently the only change in stage that can happen is if the Grubling Chow Charm is also armed. So we'll need to add that as a check.

Added DB Cleanup flag because we can go back and update the stage for hunts to better match the reality - "No Stampede" unless it is both a Stampede AND has the correct charm armed.

Bonus points if we want to add the Grubling Bonanza charm which increases AR of a grubling.

I believe the check is correct as-is. If we only set the "Stampede" stage when there is both a stampede and the chow charm armed, then we cannot deduce population differences between "grublings are stampeding" and "grublings are not stampeding"
In other words, I feel it is reasonable that there may be 3 distinct populations:

No Stampede
Stampede
Stampede w/Chow Charm armed

I think we have a couple ways we can bring this forward. Three stages as suggested there is one of them. Another is two stages of Grublings (third stage)/No Grublings (stages one and two) but with stampede status as a hunt_detail.
The first allows for the most people to break down the ARs and DRs into the three stages, of which two might be identical - but this isn't really a problem. The second allows the two stages to be investigated in case there are differences but would require SQL.
I vote for the three stage method.

sounds good:

no stampede
stampede without chow
stampede with chow


I can't see the esp-32 device name in BLE SCAN.

I programmed an ESP32 to be a BLE server using the BLEDevice.h library, in arduino IDE. When using the btferret code, I can scan the ESP32's signal using its MAC address. However, the device's name that I configured in the ESP32's firmware code does not appear in the btferret scan. Interestingly, I can read the device's name if I perform a characteristic read. Has anyone encountered a similar issue or know how to resolve it?
This is a ESP32 firmware code:
    #include <BLEDevice.h>
    #include <BLEUtils.h>
    #include <BLEServer.h>
    #include "heltec.h"

    #define SERVICE_UUID        "4fafc201-1fb5-459e-8fcc-c5c9c331914b"
    #define CHARACTERISTIC_UUID "beb5483e-36e1-4688-b7f5-ea07361b26a8"
    #define DEVICE_NAME "ESP 32 LORA"

    #define servGen "0x1800"
    #define carac "0x2A00"

    void setup() {
    Heltec.begin(true /*DisplayEnable Enable*/, false /*LoRa Disable*/, true /*Serial Enable*/);
    Heltec.display->clear();

    Heltec.display->setFont(ArialMT_Plain_10);
    Heltec.display->setTextAlignment(TEXT_ALIGN_LEFT);
    Heltec.display->drawStringMaxWidth(0, 0,128,"Device name:" + String(DEVICE_NAME));
    Heltec.display->drawStringMaxWidth(0,25,128, "Characteristic UUID: " + String(CHARACTERISTIC_UUID) );

    Heltec.display->display();

     Serial.println("Starting BLE work!");

     BLEDevice::init(DEVICE_NAME);
     BLEServer *pServer = BLEDevice::createServer();
     BLEService *pService = pServer->createService(SERVICE_UUID);
     BLECharacteristic *pCharacteristic = pService->createCharacteristic(
                                         CHARACTERISTIC_UUID,
                                         BLECharacteristic::PROPERTY_READ |
                                         BLECharacteristic::PROPERTY_WRITE
                                       );

     pCharacteristic->setValue("Caract ESP32");
     pService->start();
     // BLEAdvertising *pAdvertising = pServer->getAdvertising();  // this still is working for backward compatibility
     BLEAdvertising *pAdvertising = BLEDevice::getAdvertising();
     pAdvertising->addServiceUUID(SERVICE_UUID);
     pAdvertising->setScanResponse(true);
     BLEDevice::startAdvertising();
     Serial.println("Characteristic defined! Now you can read it in your phone!");
     }

     void loop() {
     // put your main code here, to run repeatedly:
    delay(2000);
     }

And this is the output after to LE scan (esp32 escaned):
   3 FOUND 3C:61:05:2B:BF:92 - Fixed
    Flags = 06
    All 16-byte UUIDs = 4B 91 31 C3 C9 C5 CC 8F 9E 45 B5 1F 01 C2 AF 4F
    Slave Connect Interval Range = 20 00 40 00
    Known device 1001 LE node 1001`

And this is the output after to read the esp32 services (the device name can be readed)
Reading LE services from LE node 1003.....
Characteristics saved to device info
   ctic
   index       LE Characteristics
     0  Service Changed      ? byte Permit 20 i   Handle=0003 UUID=2A05
     1  Device Name          11 byte Permit 02 r   Handle=0016 UUID=2A00
     2  Appearance           2 byte Permit 02 r   Handle=0018 UUID=2A01
     3  2AA6 UUID            1 byte Permit 02 r   Handle=001A UUID=2AA6
     4  BEB5483E36E14688B7F5EA07361B26A8   12 byte Permit 0A rwa Handle=002A
            UUID=BEB5483E36E14688B7F5EA07361B26A8

I appreciate any help, thanks.

The device name can appear in two places:

Advertising data - can be seen by a scan
A characteristic with a UUID of 2A00 - not visible to a scan, only available by reading characteristic.

You have to add the name to the advertising data. I'm not familiar with ESP32 code, but looking at the example I would guess that it is done by something like:
    pAdvertising->addName("Device name");

Thanks. In fact, the device name does not appear in the advertising. The device name is only stored in the UUID characteristic 2A00. I will correct this.


new package Textarea + evergreen-shared-styles

There is no issue for this PR.
This implements Textarea (very similar to TextInput) and a first pass on evergreen-shared-styles.

Missing on documentation website?


fix linter issues to be more in line with java rules

Fixing some linter issues based on the java-sonarcube-default rule set.

@jarlah I was wondering if for the tests we could put the comments in the code in java doc. That way code gets a little cleaner and more readable. :)

You can move comments thats ok. But can you add automated code linting in workflow? If it possible to come to a state when where it breaks it dont show a list of 100 problems ?

You can move comments thats ok. But can you add automated code linting in workflow? If it possible to come to a state when where it breaks it dont show a list of 100 problems ?

I don't know about a way in github to do that. But I'll take a look to find out if it's possible :)

https://www.freecodecamp.org/news/github-super-linter/ this might be an option :)

maybe you can test it out on your own fork. I see it requires a bit of a setup with secrets and stuff

I'll take a look I've never used github actions before. I'm a gitlab person.

Chatgpt or perplexity ftw 🙈

you can do that in different PR if you want. Just mark it ready when you have fixed the linting stuff you seem fitting

might also be overly overkill with github action for linting java code when there is literally almost no code


Missing full path information

The line below is missing the full path information:
Open cspsconfigtool.exe. It's available as a shortcut on the desktop and in the %ProgramData%\home\svsystems\bin folder.
This should be corrected to:
Open cspsconfigtool.exe. It's available as a shortcut on the desktop and in the %ProgramData%\ASR\home\svsystems\bin folder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8860a2d-9dcc-481e-a650-441b9609454f
Version Independent ID: 2f160eea-82f2-1731-a59c-9ade1ca409a4
Content: Prepare source machines to install the Mobility Service through push installation for disaster recovery of VMware VMs and physical servers to Azure
Content Source: articles/site-recovery/vmware-azure-install-mobility-service.md
Service: site-recovery
GitHub Login: @Rajeswari-Mamilla
Microsoft Alias: ramamill

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@corporateg A PR has been susccessfully raised to resolve this. The changes should be live shortly. thanks again for catching this.
Cheers.


[Travis] Fixed Warnings

[warn] on root: deprecated key: "sudo" (The key sudo has no effect anymore.)
[info] on root: the key matrix is an alias for jobs, using jobs

Coverage remained the same at 96.496% when pulling 7ed2a660e903a451039cc8f5a32eca1dcb377e3d on Weirdo914:travis into 4bf336f5091c52ce8142ba87cb52e5ac24404f32 on openwisp:master.

Whoops i didn't realize you already working at it haha


Update commit.py

forkit/commit.py:79: RemovedInDjango18Warning: commit_on_success is deprecated in favor of atomic.

@mzoeller I appreciate the change. Unfortunately we are no longer maintaining this repository. I am going to put the message in the description to denote this.


feat(generative_ai): add code samples for embeddings

Description
Adds code samples for Multimodal Embeddings API (both Guides & API Reference doc trees).
Checklist

[x] I have followed Contributing Guidelines from CONTRIBUTING.MD
[x] Tests pass:   go test -v ./..
[x] Code formatted:   gofmt
[x] Vetting pass:   go vet

Hey @Valeriy-Burlaka -- in the future, would you please break PRs > 500 LoC into multiple PRs? PRs over 500 LoC take quite a bit longer for me to review.

@telpirion , sorry for a big PR! - I thought that it would be more convenient to review all samples for a given API at once, rather than I'd provide them 1 by 1 and fragment the context.
Regarding linking to the [cloud documentation](I would point to the docs page that you found: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/multimodal-embeddings-api#syntax.): it has one major issue - it's a static (markdown) in the documentation, and it seems that it already fall out of date a bit. For example, the parameters.dimension does not have any effect on the generated response, and should be passed as part of PredictionRequest.

@telpirion , @msampathkumar , all issues with the PR should be addressed now. Can you please take a final look? Thanks!

Hi @telpirion  when possible, please re-review this PR. Thanks.


Optimize handleObjects method

It seems we do not need to call getMapping or unmarshalFromJSON for the ObjectDefinition in a loop of relevantNamespaces. Nothing changes in the loop. So move it in the upper level to reduce the cpu and memory consumption.

/assign @mprahl

Nice optimization @clyang82 . Just a minor comment.

This a minor but impactful change--thanks, @clyang82!


 void DB::StorageKafka::threadFunc(): Code: 252, e.displayText() = DB::Exception: Too many partitions for single INSERT block (more than 100).

i am getting this error several times. what could be the main issue and how to fix this isse.

 void DB::StorageKafka::threadFunc(): Code: 252, e.displayText() = DB::Exception: Too many partitions for single INSERT block (more than 100). The limit is controlled by 'max_partitions_per_insert_block' setting. Large number of partitions is a common misconception.

Issue is not related to clickhouse-operator
you have wrong PARTITION BY clause in your tables


Bug: A lot macOS Sonoma glitches

Just launching it - freezes, lags, hovering mouse icon in bar shows spinning/loading mouse cursor and overall launch takes like 5 seconds
After opens in dark mode, it shows in Settings an:  Auto(Dark Mode), clicking selecting Auto twice -  refreshes UI, now it;s in Light mode.
No EQ preset or settings applied after launch. I have to click refresh icon near devices, then sound turns Off and EQ applied.
When any system sound plays: like when you remove some file or notification or anything else, just system - music which played corrupts with crrhchhhhhxxzzzzz sound like so) and also - it replayed sometimes 0.5-1 sec of previous audio played, like in a buffer maybe.. so for example in music playing were words: "LA LA BA BA OO OO", and system sound played at "OO", so I will hear a "LA LA BA BA OO" and corrupting also to)
I believe this app should now use SwiftUI ASAP, bcs some time later this would be unusable for any future macOS versions.
Also, I really hate that when I click "Report Issue" I been redirected to https://eqmac.app/contact?type=bug-report&osVersion=14.2.0&appVersion=1.7.10&driverVersion=2.4.3&uiVersion=4.7.3 but then I just see a https://eqmac.app/account where I have to register? No, please no.

Setup information:

Audio device used for playback: MacBook Pro M1 2021, listening audio from Cog player or just from Safari at Soundcloud.com
Audio transmission interface:  3.5mm Jack
macOS Version: 14.2
eqMac Version 1.7.10
eqMac UI Version 4.7.3

Well, for macOS Sonoma this app fees like a beta

Hello @Volodymyr-13,
I have tried downloading a previous version, specifically App v1.7.10 and Driver v2.4.3 (this the latest) and It works for me. It still gets stuck on some tasks, but at least doesn't close after certain time.
Hope it helps.

Hey @jramosr to be honest I have no idea how this can help :)

I reported a bunch of bugs...
Well, I just also tried a Beta, okay:

1.8.0 found.
Testing. Will report about this later, since I remember last time I installed beta - after some time like 5-30min after - EQ started to play like ZZZZZ ZZZZ ZZZZ CCCCCCC crazy sound if enabled. Restart of device or app helped this but just for some limited time..

Okay, so testing this yesterday and today. All bugs are gone.
New one: after some time like 10-15 of working EQ, then when I remove files - audio interrrruuprrrupupttsss, like so.
This occurs only after some time of using.
So in previous aka stable release version it was like all the time right after I started app, now it's after some time.

Downloaded the app from the homepage thinking it was the latest version. I had been experiencing this weird bug where eqMac couldn't switch to the connected bluetooth headphone. Just downloaded 1.8 from the releases page and the bug is not present anymore.

Now, I didn't user app for a whole day, now just opened it first time, launches quick but music interrupts immediately. Cracking quacking trkkkccc cc c ck kckkrkr  like that.. all the time. Had to shut it down.

I've been experiencing a multitude of problems with 1.8.0 on Sonoma (14.2.1 now).  At the moment it is working, but ...

Switching to Expert EQ kills all sound - but the spectrograph is active.
Switching back to Basic or Advanced EQ restores the sound, but at minimal volume.  I've found that simply clicking on the App volume control for MS Edge (which is playing my music) restores the volume level.
More often than not, after resuming from sleep, no sound is coming out, the App section is unusable and a reboot is required (even after resetting coreaudio).  It's easier at this point for me to simply quit the app to get sound to play as rebooting is too disruptive for me.

Oh yea, the volume jumps differently at launch. Like my system volume was 100%, after launch eq Mac it’s now 80% or any other.

Can anyone confirm which of these issues are still present in 1.8.7? There have been some fixes, but some are still being worked on/are hard to or impossible to reproduce on our devices.

I just tried - looks ok, but I just first time used EQ for the past 3 months or so.. not used it bcs of these glitches.. so quickly looking - ok..


Templating System

I'll be adding Slim & Twig for the templating

@mostertb it's done. Check my PR.

I cant seem to find your PR. Are you sure you opened it on the right project?

@mostertb let us tell no one about what just happened. I've opened the PR on your project :)

Your secret is safe with me ;)

I've updated.


[improve][broker] Improve ManagedCursorContainer if there is only one cursor in ledger

Motivation
A minor improvement for ManagedCursorContainer if there is only one cursor ledger
Modifications
Avoid the heap swap if the heap size equals 1
Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/AnonHxy/pulsar/pull/20

@Jason918 @HQebupt @codelipenghui PTAL

Codecov Report

Merging #18737 (f55d54f) into master (3e18974) will decrease coverage by 8.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18737      +/-   ##
============================================
- Coverage     45.53%   37.05%   -8.49%
+ Complexity    10220     1967    -8253
============================================
  Files           703      209     -494
  Lines         68797    14421   -54376
  Branches       7374     1573    -5801
============================================
- Hits          31329     5343   -25986
+ Misses        33881     8492   -25389
+ Partials       3587      586    -3001

Flag
Coverage Δ

unittests
37.05% <ø> (-8.49%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ookkeeper/mledger/impl/ManagedCursorContainer.java

...apache/bookkeeper/mledger/ManagedLedgerConfig.java

...saction/pendingack/impl/PendingAckHandleState.java

...e/pulsar/proxy/server/ProxyReadTimeoutHandler.java

...on/buffer/impl/InMemTransactionBufferProvider.java

...eper/mledger/util/AbstractCASReferenceCounted.java

...e/pulsar/broker/service/schema/SchemaRegistry.java

...g/apache/pulsar/broker/admin/impl/SourcesBase.java

...aming/FlowOrQpsEquallyDivideBundleSplitOption.java

...org/apache/pulsar/broker/admin/v1/BrokerStats.java

... and 484 more


Body Weight shown in individual Edit screen for exercises corresponds to current weight

The (Body) Weight that is shown in the edit screen for individual sets of exercises is not the latest entry for the weight at the time of the set execution, but rather the most recently added body weight entry.

This is on purpose. The point of recording your body weight on each set is so you can calculate your relative strength when you completed it.

Can you please provide the steps to re-create this bug, and what you expect to see at each point?

My progression of pull ups started with a few sets using an assisted pull up machine, so instead of the weight I actually pulled I inserted the amount of the plates that were subtracted. However that led to negative numbers and in the end screwed with the graphs showing e.g. the relative strength.
So I tried to go back to the individual sets to enter the actual weight [body weight - assistance] I worked with but found that the edit screen showed my current body weight in the field instead of the body weight I had entered when doing the set.

enter a body weight via the tree dots in the search bar
complete a set
enter a new body weight [e.g. a week later]
go to edit screen for set from step 2: body weight shown in field is the one from step 3, not step 1

this is where I encountered the bug
https://github.com/brandonp2412/Flexify/assets/81168204/0fefae22-9b39-432d-8738-c716ef711a5c
but it seems that comes from a problem in the importing from the graph.csv because looking at the db  the body weight is set to 78.2kg on all sets of any exercise

Im afraid I don't understand what is the bug here, perhaps you could try explaining this using a minimal example?


[FEATURE_REQUEST] ENV var with URL instead of mounting a conf.yaml file

Is your feature request related to a problem? If so, please describe.
If you are wanting to deploy this app on hardware that you don't own, it would be awesome to be able to specify a URL that dashy could cURL the conf from an online public source instead of needing to mount the conf file to a local path.
Describe the solution you'd like
Instead of mounting a conf file with docker, setting an ENV variable with the URL would have dashy pull that yaml file and place it in its correct location.
I realize that we could just build a custom dashy image with the custom conf therein, but this is a special use case.
Priority
Medium (Would be very useful)
Is this something you would be keen to implement
No

This is actually already included in #799

This is actually already included in #799

Please forgive me for being dense... but I can't tell how #799 shows me how to use this feature.


[Bug]:

Bug description
tom-select.ts:2244 Uncaught TypeError: Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'.
at J.insertAtCaret (tom-select.ts:2244:10)
at J. (tom-select.ts:1858:9)
at R (utils.ts:87:5)
at J.addItem (tom-select.ts:1829:3)
at J.onOptionSelect (tom-select.ts:838:10)
at HTMLDivElement. (tom-select.ts:297:10)
Expected behavior
new TomSelect('#select-state',{
valueField: 'label',
labelField: 'label',
searchField: ['label','type'],
// fetch remote data
load: function(query, callback) {
var self = this;
if( self.loading > 1 ){
callback();
return;
}
		var url = 'https://whatcms.org/API/List';
		fetch(url)
			.then(response => response.json())
			.then(json => {
				callback(json.result.list);
				self.settings.load = null;
			}).catch(()=>{
				callback();
			});

	},
	// custom rendering function for options
	render: {
		option: function(item, escape) {
			return `

								${ escape(item.label) }

${ escape(item.type.join(', ')) }

`;
		},
                   item: function(item, escape) {
                      console.log(item);
                   }
	},
});

Steps to reproduce

Go to ...
Click on ....
...
X. See error

Additional context

OS: [e.g. iOS, Windows]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Device: [e.g. iPhone6]

your item render doesn't return anything.

^ I think that's the most likely cause of the issue. That said, there's not enough information here to reproduce your problem. If changing your item function doesn't work, please share a self-contained reproduction built on something like https://codepen.io/ or https://jsfiddle.net/. I'm going to close this issue for now, but I'd be happy to reopen it if you can share a better reproduction.


Document "AGRMET GALWEM nominal resolution (km):"

We need to add documentation for "AGRMET GALWEM nominal resolution (km):".

This is addressed by pull request #474

Pull request #474 was merged into support/lisf-557ww-7.3.  I will leave this issue open until the changes migrate into master.

This change has been migrated into master, so I am going to close this issue.


What is a guild token and what is it used for

Title

Guild tokens are used by discord.py to interact with guild level elements


Update schemas.md

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
What is the current behaviour (you can also link to an open issue here)?
What is the new behaviour (if this is a feature change)?
Other information:

Is there an issue with this PR I need to fix?


Fallback-functionality

Any plans to support fallback-functionality? E.g. say I have a TestController and the files testcontroller.es-ES.json, testcontroller.es.json and testcontroller.json. The fallback-functionality would first check the testcontroller.es-ES.json for the key, then the testcontroller.es.json and then testcontroller.json.
Edit: Like explained here

Any plans to support fallback-functionality?
Sure, let me check why this not included, I already support this in some OSS

FYI the fallback is here https://github.com/hishamco/My.Extensions.Localization.Json/blob/master/src/My.Extensions.Localization.Json/JsonStringLocalizer.cs#L119-L140
Are you sure it doesn't work, perhaps I need to add a unit test if it is not included yet

That's really strange, to provide more accurate info:
I have a test.en-US.json, test.en.json and test.json (in the same folder) with the following content:
test.en-US.json
{
  "temp":  "test-en-US"
}

test.en.json
{
  "temp": "test-en",
  "temp2": "test-en"
}

test.json
{
  "temp": "test",
  "temp2": "test",
  "temp3": "test"
}

With an empty Test-class:
public class Test
{
}

And then trying to access the values using IStringLocalizer<Test> _localizer (injected into a controller) and _localizer["temp"] == "test-en-US" (which is correct), but _localizer["temp2"] == "temp2" and _localizer["temp3"] == "temp3".
Do you have an example where the fallback-functionality is used? Maybe I'm missing something.

I know what you mean exactly, let me create a unit test for that

Great, thanks for being so fast to respond!

@thomkle seems the culture fallback works fine with GetAllStrings() but not localizer indexer

@hishamco Ah, I see. I'll follow the status on #26

It's already merged ;) feel free to use and try the latest bits

Ah, great! I'll try out the last change. Could you push a NuGet package for it as well?

@hishamco Seems to be working very well now, thanks!

@hishamco Sorry to nag, but the fallback doesn't seem to work completely. E.g. say I have set the culture "es-ES", but there are no files .es-ES.json, but I have a .json. It will not fall back to values in .json. I also tested this creating unit tests after cloning the repo and it looks that the unit test fails.
Reproduction steps:

Add a Test.json with the content { "Hello": "Hello there" }
In the JsonStringLocalizerTests for the method GetTranslation add the inline data: [InlineData("es-ES", "Hello", "Hello there")]. This will fail, but this kind of fallback should work, right?

I'll be happy to try to solve this my self and create pull requests, but I understand if you're more comfortable with solving things in the project yourself :)

Could you push a NuGet package for it as well?

I'm not sure for now, but may be a pre release version will be fine


update email to reviewers for TMLR

There is a test that check the test of the email, could you update it? https://github.com/openreview/openreview-py/blob/fabianp-patch-1/tests/test_journal.py#L466

@melisabok : the last test failure seems unrelated to this PR, could you kindly check that?

I fixed the tests in master but it seems there is another TMLR test that needs to be updated.


New Prowler Check 7148 by George O. submitted for review

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. This Pull request is called [extra7148] to Check if EFS has backup enabled

I do have a question, what if AWS Backup is doing backups for an EFS instead of the EFS having backups enabled, can that be possible? What would happen to that check if it is possible?

If AWS Backup is doing backups for EFS, The check still reports the same information. I have tested this scenario by creating a backup via AWS Backup, using EFS as the resource. After the Backup was created for that specific File system using AWS Backup, its recognized that the specific File system has a backup policy attached and the same principles apply.

Yes, Thank you. I made an error and submitted a different Custom Check 7149 which is for a different service under the same pull request. I will remove that. Thank you

Hi @w0rmr1d3r I made an error and submitted two different Prowler checks on the same Pull request. Can you kindly roll back the approvals so I can make two separate branches and two new pull requests? One for the EFS Prowler Check and another for the Redshift Prowler Check? Thank you

Okay. I have deleted the 7149 Redshift Check and This Prowler check 7148 is good to go! Thank you!

Good job! Thanks!

Good job! Thanks!

 Much appreciation!


Bug with chart histograms

Some grids include an optional histogram column.  This results in an error:
System.IO.FileNotFoundException: 'Could not load file or assembly 'System.Data.SqlClient, Version=<IP_ADDRESS>
This occurs in the call to GetHistogram which uses the following to return a bitmap.
System.Windows.Forms.DataVisualization.Charting
This occurs when chart.DrawToBitMap is called - seems odd to have this dependency.
DBA Dash now uses Microsoft.Data.SqlClient.  Including System.Data.SqlClient might be a quick fix but ideally this chart component needs to be replaced with something else.

Confirmed that adding System.Data.SqlClient back fixes the issue.  Still need to look to see if there is a good replacement.


Outdated forest area is used for some areas

Describe the bug
I found out that in some areas the forest area is outdated as of at least a year ago. Some users had edited the area to avoid intersecting with major roads, major rivers, lakes, etc., or some new development at the area, or just some tagging mistakes. But on the map the trees still showing as of the outdated information.
Expected behavior
The forest area should be as of the latest version.
Map location
Some locations in my country:
https://streets.gl/#3.43367,101.80705,45.00,0.00,2364.45 (trees on a dam)
https://streets.gl/#4.55965,101.13711,45.00,0.00,1413.74 (trees on lakes and plantation)
https://streets.gl/#3.02755,101.25354,45.00,0.00,1991.06 (mangrove area mistagged as forest, and I have corrected it around a year ago)

Forest areas are rendered using Mapbox vector tiles as a source, so there's nothing I can do right now to fix this. They probably just don't update their data too often.
I'm currently working on building a custom vector tileset using Planetiler. This tileset is going to replace the data pulled from Overpass API and Mapbox.

This is no longer a problem, Mapbox data is no longer used.


[TS migration] Migrate VideoPlayerContexts  component files to TypeScript

Details

This PR migrates VideoPlayerContext to TypeScript.
Fixed Issues

$ https://github.com/Expensify/App/issues/36724
PROPOSAL:
Tests

[x] Upload few videos to one chat
[x] Play and pause one of them
[x] Change volume
[x] Turn off and on volume
[x] Change video speed
[x] Enter full-screen mode and repeat the steps
[x] Move to another video
[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

web_android.webm

iOS: Native

https://github.com/Expensify/App/assets/115273836/68202731-4f65-4931-874f-5b52b34d1163

iOS: mWeb Safari

https://github.com/Expensify/App/assets/115273836/a31708e8-cae0-4f5f-ab37-537ad96303b1

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/115273836/a32263ae-352c-4b8c-8b28-9cf9d9f609d1

MacOS: Desktop

https://github.com/Expensify/App/assets/115273836/99ab2e5b-c3d0-4c01-b647-2462b462fb2d

@eVoloshchak could you take a look? This PR is blocking my further VideoPlayer migration PRs.

@blazejkustra, I agree, verified this is also present on staging, will finish up the checklist shortly

Thank you!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@smelaa you might have to merge the main into your PR 😄

@smelaa, the checks are failing, could you take a look at this please?

somehow, melvin is doing this recently. All tests were passing 🤔

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@hayata-suenaga I am getting a crash when navigating between reports after playing a video, bringing back the optional chaining for stopAsync mitigates this:
https://github.com/Expensify/App/assets/157416545/33e5870e-3bb1-4cf7-808c-8921a2947b0d
I reported this in the open source slack channel but we don't have a issue tracked yet.

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fetchurl: fixup typo on a comment

Description of changes
Further, pass the formatter

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Add the formatting commit to .git-blame-ignore-revs`

Add the formatting commit to .git-blame-ignore-revs

Done!


Disable dropdown dismiss on item click

I want to ask question regarding the library.
Can the library, somehow, disable automatic dismiss menu on menu click?
Thanks!

Hello @YosephHaryanto, so if I understand correctly, there is no possibility to avoid automatic dismissal of the drop down when one of its items is clicked.
In which case would you want that kind of behavior?

did any one found a solution for this issue please?

I found out that you can access tableView inside of dropdown view, I know it's not the best code, but it works and it does not change pods' files.
dropButton.subviews.flatMap({$0.subviews}).compactMap({$0 as? UITableView}).first?.allowsSelection = false
I just accessed to tableView, it's under tableViewContainer and changed value of selection. You might try to play with multiple selection if need.


Keep the extrahead contents from the parent template

Thanks for this project! Very useful.
I have an admin customization which replaces the nav sidebar with a panel with grouped apps (django-fhadmin); the necessary scripts and styles are added to the {% block extrahead %}. The django-admin-action-forms action form template replaces the contents of extrahead instead of adding to them, it would be great if that could be changed.
Thanks!

Thanks for that, it seems like it should be there from the start, I must have missed it.
I will check later today whether it should be at the top or bottom in order to not break any JS scripts for autocomplete, date widgets etc. and test different INSTALLED_APPS order just to make sure. I'll merge later if it works fine, which it most likely will.
Thanks

Thank you! I'd appreciate a release containing this if you find the time, but as a maintainer of numerous projects myself I understand I'm asking a bit much here.

I will make a release today, while testing this and working on #2 I found a few minor edge case bugs that I wanted to fix before.

@matthiask I just released version 1.2.0 which includes this PR.
Thanks again for spotting this.


Problem when exporting MHLO MLIR and lowering it down to bytecode

I'm trying to export a MHLO MLIR file of a model from Tensorflow model zoo and lower it down to bytecode (vmla backend).
I generated the MLIR file of MobileNetv3 following instructions at this link https://google.github.io/iree/developing-iree/e2e-benchmarking using iree/integrations/tensorflow/e2e/keras/applications/applications_test.py.
After this I tried lowering this generated MLIR file to bytecode using iree-translate as follows:
./iree-translate -iree-mlir-to-vm-bytecode-module -iree-hal-target-backends=vmla -iree-flow-dispatch-linalg-on-tensors mobilenet.mlir -o mobilenet_bytecode_module.module
But the conversion fails with error message starting with:
<unknown>:0: error: failed to legalize operation 'hal.interface.binding.subspan' that was explicitly marked illegal
<unknown>:0: note: see current operation: %0 = "hal.interface.binding.subspan"(%c0) {binding = @legacy_io::@arg0} : (index) -> !flow.dispatch.input<1x224x224x3xf32>
<unknown>:0: error: conversion to the VMLA dialect failed

Am I missing any relevant flags to iree-translate or is my way of generating MLIR file itself is wrong?
Thank you.

The Linalg on tensors path is not stable yet. And I think it doesn't work with VMLA.
If you are targeting on VMLA, maybe try this: ./iree-translate -iree-mlir-to-vm-bytecode-module -iree-hal-target-backends=vmla mobilenet.mlir -o mobilenet_bytecode_module.module.

That worked, thank you for the clarification.

The exported MHLO MLIR has loc(#loc<num>) appended to every op and each loc<num> references tensorflow/python/eager/function.py of current environment. Example:
#loc10 = loc(callsite("MobilenetV3small/tf.__operators__.add_97/AddV2@__inference_<lambda>_13622"("/home/python3.8/site-packages/tensorflow/python/keras/engine/functional.py":424:0) at callsite("/home/python3.8/site-packages/tensorflow/python/keras/engine/base_layer.py":1012:0 at callsite("integrations/tensorflow/e2e/keras/applications/applications_test.py":95:0 at callsite("/home/python3.8/site-packages/tensorflow/python/autograph/core/function_wrappers.py":117:0 at callsite("integrations/tensorflow/e2e/keras/applications/applications_test.py":95:0 at callsite("/home/python3.8/site-packages/tensorflow/python/framework/func_graph.py":966:0 at callsite("/home/python3.8/site-packages/tensorflow/python/eager/def_function.py":634:0 at callsite("/home/python3.8/site-packages/tensorflow/python/framework/func_graph.py":990:0 at callsite("/home/python3.8/site-packages/tensorflow/python/eager/function.py":3196:0 at "/home/python3.8/site-packages/tensorflow/python/eager/function.py":3361:0))))))))))

Is there a way to generate MLIR file that doesn't have these hardcoded paths and thus is portable?
Thank you

I personally pass it to iree-opt to re-generate the IR. E.g., ./iree-opt a.mlir > b.mlir.

Any idea @stellaraccident? Is there a flag to disable emitting the locations or enable reproducable builds on the tf-side?

It's akin to debug symbols and shouldn't be hurting anything. There is not a flag to control it, but one can be added: iree-tf-import-main, line 184 is what enables it. Patches welcome.

ah I was looking for that but in the python files - thanks!
Yeah, this should only be an issue if you a) don't want to leak paths from build machines (in which case, the final IREE outputs can be stripped) b) want to be able to perform reproducable builds (for caching intermediate artifacts, etc). But as Stella mentions there should be no change in program behavior from these and no issue with portability.

I tried passing it through iree-opt and that helped. Thanks everyone!


how can i remap /os_cloud_node/lidar_packets into standard sensor_msgs/PointCloud2?

thanks for your sharing. here is the issue, when i tried to test this package with my project, i encountered a problem to change the lidar topic  /os_cloud_node/lidar_packets into  sensor_msgs/PointCloud2. i already tried https://github.com/ouster-lidar/ouster-ros roslaunch ouster_ros replay.launch
bag_file:=
metadata:=
but it didn't successfully replay this bag.
can you help me with this issue.
best regards!

Hi @AcamelQ , Please use the sensor_sync_replay branch of our fork of ouster-ros : https://github.com/ntnu-arl/ouster-ros/tree/dev/sensor_sync_replay


Document extended features of domain administrators

Document all features that are available for users with domain admin role.
Review with @ershovaelena

The document can be found in a local google drive folder.


Store Cow instead of &str

Currently structures store a raw str slice, which makes for poor API ergonomics. By storing a Cow<str>, the struct can outlive the stack data if necessary.
I discovered the downside of the current API, which I queried here: https://users.rust-lang.org/t/binding-does-not-live-long-enough-even-though-its-being-returned/9002
Also, this is a good article on the topic, if you're interested: http://blog.jwilm.io/from-str-to-cow/
Btw, I also snuck in a commit to squash some warnings that were getting annoying!

Coverage remained the same at 100.0% when pulling 72e97f3596592f62dc50b33ca732c25cadd9c294 on petehayes102:master into 9eb00dcb31ff5b58af4f5c2897ca452defd86ad5 on softprops:master.

Cool I've been using Into  interfaces in recent projects. I haven't really dug into Cow but this looks good. Thanks for the patch

No dramas :) It's pretty new to me, too.


Make the SB mirroring pipeline work for 8.0 preview 1

There were a couple of minor things such as it could only push to an already existing branch.
I was able to mirror a dev branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=2112291&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=bf6cf4cf-6432-59cf-d384-6b3bcf32ede2
https://github.com/dotnet/source-build/issues/3194

@premun - Can you clarify the intent with this change?  Your description leads me to think the pipeline was updated to create the branch if it doesn't exist.  I am not spotting the change that fixed this, rather it looks like a better UX was implemented to call out the error.

@MichaelSimons the || echo Branch doesn't exist yet will return 0 and not fail

Oh I get it, the change is hiding the error so that git push will create it.  Thanks for helping me understand.


define-type-sizing() outputs incorrect line-height with rem base-unit

In the html element, rem means relative to browser default font size; em means relative to html's font size.
So, if $base-unit is rem, the define-type-sizing() mixin outputs a line-height in rem, which is relative to the wrong font-size.

This has been fixed in the latest beta.


Create and follow up on maintenance tickets for toilet seats

they don't fit for any of the toilets, and the one upstairs is sliding loose.
Log into property management company website using login info in #captains and create a maintenance ticket, follow up with them, and close it out when done.
Coordinate with @Down2nap who can be in the space during weekdays.

commenting

created ticket.
https://topquality.managego.com/Resident/#/Ticket?sortExp=Modified&sortDir=desc&id=216298

just checked, no response yet.

he responded asking when is good for them to come by and fix it.


Maximum end velocity

is it possible to only have an end position constraint and reach maximum possible velocity at the end?

If your desired maximum velocity is not reachable, it will use the highest possible velocity. So just make sure to set a maximum velocity where you are sure that it is unreachable. Be aware though there was a bug with negative speeds. It should be fixed now, but I didnt had the time to do a release,yet. So better use the main branch for now


Remove redundant routes in overlay for windows nodes

Removing a redundant route added to Windows VMs for dualstackoverlay
Redundant route being removed:
netsh interface ipv4 add route "<overlay-subnet-prefix>" "<interface-name>" "<overlay-subnet-gateway>"
Example:
netsh interface ipv4 add route "<IP_ADDRESS>/16" "vEthernet (Ethernet 2)" "<IP_ADDRESS>"
This route is redundant, because prior to it being added, there is another route added with the same matching-prefix:
Route being added before redundant route:
netsh interface ipv4 add route "<IP_ADDRESS>/16" "vEthernet (Ethernet 2)" "<IP_ADDRESS>"
So the second route is rendered useless, and we don't need it
This was confirmed by @princepereira, so removing the redundant route (both for IPV4 and IPV6)

@princepereira could you review as well please? Thanks! Maybe mention the tests you did with this version of CNI


Help wanted. Unable to play video with my DNS service

I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request

General infomration
I had to travel outside of the UK for 6 month in business. To be able to access the company's VPN ( which is geo-restricted to the UK. The IT dept. installed a Smart DNS service on my laptop. I am able to log in and view my NetFlix list but I am not able to play any video. I am attaching Kodi's log after enabling "debug logging" in Kodi. I searched for the option to enable the verbose logging in the plugin but I couldn't locate it.
Prerequisites

[x] Are you running the latest version?
Yes

Description
[Description of the bug or feature]
Steps to Reproduce

Run the Smart DNS service
Open Kodi -> Netflix addon -> pick any video

Expected behavior: [What you expected to happen]
A video to play.
Actual behavior: [What actually happened]
It tries to connect and play it but eventually nothing happens.
Context (Environment)
Windows 10 x64
Installation

[ ] I installed the plugin via zip from the Releases page
[x] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[x] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Additional informatin on the environment
[Descripe your environment a bit more detailed, are you using LibreElec f.e.]
I am running Kodi Leia 18 Beta 2
I just installed the addon the normal way and the addon downloaded and installed all dependencies
Debug log
[Please include a link to your debug log (use something like http://sprunge.us/) or similar, please do not paste]
https://pastebin.com/raw/JKWbStHE
Other information
[e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, etc.]
Screenshots
[Please add a screenshot if that helps understanding your problem]
[You can erase any parts of this template not applicable to your Issue.]

 Nothing we can do about that. Playing via Netflix Homepage will not work either.

Actually, playing via Netflix Homepage works like a charm. It is just that I have access to my library with me on Kodi and thought it is the better viewing experience.

That's strange. Is there an exception configured for your browser, such that it bypasses the DNS service?
In either case, Netflix is refusing to serve a manifest to you because it detects a proxy/VPN/whatever other stuff they are blocking.

Sorry caphm for asking for help on such a specific situation. I just want you to know that it is okay if you won't offer help with my case. It is just that there is no exception configured for my browser.
I attached the kodi.log file and if you want any further log I can send it right away.
Thanks for the brilliant addon.

Please, just let me know if you can look into it or I should put it to rest for the next 6 months till I am back in the UK.

You can try the beta for 0.14.0 from #519 . This should at least give you a more detailed error message. I suspect there's not much I can do about it though, as Netflix is known to be very strict when it comes to VPNs, Proxys and out-of-the-ordinary DNS setups.


falkon: init at <IP_ADDRESS>

Motivation for this change
Falkon is the new name for qupzilla.
The version here is QupZila 2.1.2 + a few more commits from upstream that turn it into Falkon.
Please note that there is an issue with qtwebengine and nouveau causing it to crash when using nouveau:
https://bugs.launchpad.net/oxide/+bug/1499419 but it works with intel graphics.
This is not falkon/qupzilla related!
Further to #29488, @disassembler
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

falkon-<IP_ADDRESS> doesn't build on nixos-unstable and claims it's need for at least Qt 5.8!. Any known reason for that?

Fixed in 9c9b6874d02.


Suggestion: optimized observable arrays

Knockout had this and it was awesome and useful: http://github.com/SteveSanderson/knockout-projections.
Basically: some operations on arrays are very common (e.g. filtering .filter() or projecting .map()).
Consider how you would display a filtered list in Aurelia today:
@computedFrom(["search", "items[]"])
get filteredItems() { return this.items.filter(x => x.name === this.search); }

This works (except for the array observation, see #194) but any time one item is added, the whole array is filtered and copied again, and then the DOM is entirely rebuilt.
KO.projections has "intelligent" array operations. When an item is added to items a change notification is received by the filtered array. It then looks at the new element and checks if it satisfies the predicate. If no, nothing is done. If yes, it is added to the filtered collection and a change notification is raised.
This means that for stuff like projections or filtering, adding/removing an element is O(1) instead of O(N).

but any time one item is added, the whole array is filtered and copied again, and then the DOM is entirely rebuilt.

I don't think this is a true statement.  Aurelia's binding system attempts to add/move/update the minimum repeated elements when an array is mutated.  It uses the Levenshtein distance algorithm to optimize/minimize the set of "splices" that are applied to the DOM.  Check out the code in the repeat element and the calcSplices method in the array-change-records.js file.

I think actually KO was doing something similar and the statement is you quoted is only partially true.
The part that may not happen is "the DOM is entirely rebuilt".
The rest still holds.
If you have a relatively large array in memory, and a computed property that filters the array. Maybe something like this:
@computedFrom('orders')
get largeOrders() {
  return this.orders.filter(order => order.price > 300);
}

Any time you add an item this.orders.push(new Order()) the following things happen:

The largeOrders value is recomputed, which implies iterating the whole array and copying all items that match the predicate into a new array.
Aurelia needs to compare the new resulting array to the old one, computing the minimum diff, which is not cheap.

Use cases manipulating large arrays benefit greatly from stuff like KO-Projections, because when you add a new order:

only this new order is passed through the predicate.
if it doesn't match nothing more happens, if it does:
the new order is inserted in the alreay existing filtered array
Aurelia would immediately know that the diff is a single insert.

That's still considerably more efficient.

One thing you'll be able to do with the release that dropped this week is create your own collection type that has the logic you've described and plug a strategy into the repeat binding command to teach it how to use your new collection type.  That would make an awesome plugin- aurelia-projections or something.
Want to take a shot a build something like that?  I would be happy to help anywhere I can.

The fact that this is possible is very cool and shows how extensible and well-designed Aurelia is. :+1:
I have no time to take a shot at this at the moment, but I am very happy that the possibility exists and I might do that in the future.

Has anything changed since last comment?


No image for certain players

Hello,
Let me start by saying that I feel bad of having to bother you again.  I really love this program and appreciate hugely what you do for baseball/softball, and for us!
I noticed that for "some" players at bat, the player image and team image is not loaded.  I double checked on our local wbsc site (baseballsoftball.be) and on the overall stats site (wbsc.org) and the pictures are there.  So I am buffled to why some images are not retrieved.
I have this e.g. in game java -jar "C:\OBS_DataDirectory\baseball-streaming-v1.8.1.jar" -m replay -t "C:\OBS_DataDirectory\resources" -s 2024-softball-ladies-d1 -g 133609 -S https://www.baseballsoftball.be/ where (amongst others) the picture of Roxanne Struyf (https://www.wbsc.org/en/player/struyf-roxanne-646956/history) is not loaded.
Other players for that game that are not loaded are "Floortje De Ridder" and "Marijke Neerinckx"
I dived in your code, and I think the problem is related to https://github.com/keero/baseball-streaming/blob/6a0eff16c573e7d9d84a8e907a7b3d95363cdf65/src/main/java/org/sundbybergheat/baseballstreaming/services/FilesService.java#L389 , but I could not put my finger on what exactly is wrong... (because I can't fully understand JAVA 😄)
So if you would have some extra spare time to find out what could be wrong, I would appreciate it a lot!  But it's not thàt important. ;)
Thank you already!

Don't worry about reporting issues. I am happy to receive feedback so i can improve the app. :sunglasses:
This is most likely related to the unability to match the series ID against the category ID for the stats (https://github.com/keero/baseball-streaming/issues/5).

Don't worry about reporting issues. I am happy to receive feedback so i can improve the app. 😎 This is most likely related to the unability to match the series ID against the category ID for the stats (#5).

I confirm. That is the issue.


What about the client side?

How is authentication used from HttpClient?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbf15d8f-56c9-61ea-9801-2d4049400f4a
Version Independent ID: 390671d2-7d1b-48c8-bad4-b967559706af
Content: Understanding HTTP Authentication
Content Source: docs/framework/wcf/feature-details/understanding-http-authentication.md
Product: dotnet-framework
GitHub Login: @Lxiamail
Microsoft Alias: wcfsrvt

Please look up how to do that on a developer forum such as stackoverflow. I'm closing this issue as your question is too broad for this article. Thanks!