development_tools: Make GCC always be the default compiler on Linux

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

For systems like Ubuntu that use hardening-wrapper as the default GCC, DevelopmentTools.default_compiler will assume Clang is the default, causing test failures.
Fix test:
TabTests#test_defaults [$PREFIX/Library/Homebrew/test/test_tab.rb:35]
Closes linuxbrew/brew#69

I'm thinking that default_compiler should be on Linux:
def default_compiler
  return :gcc unless OS.mac?
  …

For historical reasons, :gcc is an alias for :gcc_4_2 and means GCC 4.2 to Homebrew. It should probably be avoided on Linuxbrew. Does :gnu work? I'm not sure that it does. That's what used in compilers.rb find_compiler, but I don't believe it has any meaning outside of that function. :"gcc-5" could work, but it is not correct for the host's compiler, e.g. :"gcc-4.8".

The Circle CI failure is a configuration problem, so merging anyways.
https://circleci.com/gh/Linuxbrew/brew/14
==> brew pull --clean --tap= https://github.com/Linuxbrew/brew/pull/70
==> FAILED
Error: Invalid tap name

I introduced that --tap= bug, and haven't had a chance to fix it. Should be an easy fix.
https://github.com/Linuxbrew/brew/blob/master/Library/Homebrew/dev-cmd/test-bot.rb#L867


Animation panel dropdown is not keyboard accessible

Bug Description
The animation type dropdown is not keyboard-accessible at all. There’s no focus-styling on either the unopened dropdown nor the active option. We need all the same keyboard-functionality as for the “regular” advanced dropdown (space, enter or arrow-down to open dropdown, auto-focus first item when opening, arrow keys to navigate in dropdown, enter/space to select option, esc to close dropdown, and auto-focus dropdown button itself on close).
Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@csossi - there's details in the PR on testing/changes: https://github.com/google/web-stories-wp/issues/5570

After selecting an animation type by keyboard, the cursor (ENTER on selection), my cursor moved to the items below the canvas (Page 1, delete icon, dupe icon, etc.). Shouldn't user stay within the Animation section of the design panel so that they can set duration, delay, etc.)?
https://share.getcloudapp.com/P8umemE7

Thanks for the catch, @csossi - it should now return the focus to the effect dropdown when a keyboard user makes a new effect selection. This mimics the behavior of the font chooser.

@csossi - sorry for the back and forth here with assignment! I initially fixed the focus to return to the select menu when you hit 'enter' as you found didn't work and the reason for sending this back, and then i reviewed Max's PR that builds off of this to keep the dropdown open when new animations are selected to make updating easier on the user. So the only true way a keyboard user will exit this menu is by esc or tab keys, both of which refocus to the animation dropdown closed.

Verified in QA (checking state in 5586)

Works here.

Works here.


This fixes #692. If ratePerSecond is NaN, set errorThenVolume to -1

NetflixOSS » Hystrix » Hystrix-pull-requests #51 SUCCESS
This pull request looks good

Thanks for the contribution, @nilsmagnus !


Add new overwrite paths for the project configuration and container setup

What does this PR do?
First, it renames the file projext.config.js, used to overwrite the projext dependency injection container to projext.setup.js, since it's not a configuration file and the name was needed for the following change:
The file config/project.config.js wasn't "identifying projext enough" and while is still supported, the project configuration will now go to projext.config.js by default.
If you are wondering how the old one is still supported but "the default changed", well, the ConfigurationFile abstract class now supports multiple overwrite files and the project configuration now has 3:

projext.config.js
config/projext.config.js
config/projext.config.js

projext will take that list, in that order, and use the first file it can find.
Finally, this is breaking because the ConfigurationFile overwritePath string property has now been converted into overwritePaths and it's an array.
How should it be tested manually?
yarn test
# or
npm test

Pull Request Test Coverage Report for Build 47

13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 45:
0.0%

Covered Lines:
894

Relevant Lines:
894

💛  - Coveralls


implement preferFloat32 to encode numbers in float32 instead of float64

If the double precision is not required, float32 is more compact than float64.

Codecov Report

Merging #79 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   98.15%   98.16%   +0.01%
==========================================
  Files          15       15
  Lines         919      927       +8
  Branches      187      189       +2
==========================================
+ Hits          902      910       +8
  Misses         17       17

Impacted Files
Coverage Δ

src/Encoder.ts
97.9% <100%> (+0.07%)
:arrow_up:

src/encode.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a1ef5...4cf02b1. Read the comment docs.

This is more of "force" than "prefer". Why not just test whether the value can be losslessly represented as a float32 and use that, otherwise use float64?

@michaelficarra Thanks for your advice. s/prefer/force/ at 91eeb98.

Why not just test whether the value can be losslessly represented as a float32 and use that, otherwise use float64?

I think it should make encoding much slower than the forceFloat32 option because the floating point number is a complex data type that requires much more bit operations.


Unable to Authenticate with HTTPS Grafana host with APIModel()

Slight change from example:
import json

from grafana_api.model import APIModel
from grafana_api.dashboard import Dashboard

model: APIModel = APIModel(
    host="https://www.my-grafana-site.com",
    token="my-api-token"
    )

dashboard: Dashboard = Dashboard(model)
dashboard.get_dashboard_by_uid(uid="abcd-efgh")

And the error is:
Traceback (most recent call last):
  File "test.py", line 14, in <module>
    dashboard.get_dashboard_by_uid(uid="...")
  File "/Users/.../site-packages/grafana_api/dashboard.py", line 133, in get_dashboard_by_uid
    if api_call.get("dashboard") is None:
AttributeError: 'HTTPResponse' object has no attribute 'get'

Do I have to provide a value for ssl_context for HTTPS host? What value would that be? I didn't find any info from docs I'm afraid.

Hi @mikewu-tl, are you using the latest version of the grafana-api-sdk ?

Was the code I provided using Bearer API token correct? Please let me know what I can look into to pull the list of folders.

The way you handled it looks too good for me. Could you please describe the way you created the API token/service account? What access rights did you use? My current guess is that the uid is not matched/correctly passed or there is an issue with the token. Do you use a self-signed certificate for the Grafana instances?
The case you just tried should actually work as expected and is being tested here in an integration test.

For context, I'm trying to programmatically scrape all dashboards from all folders as json, and import them into a newer Grafana host (9.5+).

I've got a similar case to back up the dashboards from one system and move it to another Grafana system.

Hi @mikewu-tl

thanks for looking into this.
No, problem.

After some tinkering I finally found out this:
the Grafana HTTP API and the request library only supports http/1.1, which means, for companies that self host Grafana on public cloud (most commonly behind a load balancer) often has http/2 for the endpoint, which is unsupported. In Python, httpx would be more suitable for this.

Thank you for the update. That explains the case. In general, why should I not support http/2? Feel free to open a feature request!

In addition, community discussion (https://community.grafana.com/t/export-dashboard-for-external-use-via-http-api/50716) indicates that there is no programmatic way to fetch exportable JSON, but only in UI.

I'm currently using the SDK to export dashboards and forward them to another directory inside the same Grafana instance. From my understanding, it should be possible to create the exportable JSON.

I'll close this case and further document the new feature request (HTTP/2 support) inside this #33 issue.

Hi @mikewu-tl, FYI I've implemented HTTP/2 support for the Grafana API SDK.


Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions) (#126934)"

This reverts commit d0d1feb6283f4e812e9784b40409f732a068ff76.

Thanks. I managed to make one and used the revert bot to land here https://github.com/flutter/flutter/pull/126954


⚠ Fortnite has degraded performance

In 8758bc7, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1534 ms

Resolved: Fortnite performance has improved in ed66784.


chore: format/lint

update jest configs
format/lint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
27 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-24.6%) to 69.014%

Files with Coverage Reduction
New Missed Lines
%

src/handlers/committers-group.ts
4
0%

src/handlers/voters-group.ts
4
0%

src/handlers/validate.ts
5
0%

src/handlers/Handler.ts
14
0%

Totals

Change from base Build<PHONE_NUMBER>:
-24.6%

Covered Lines:
87

Relevant Lines:
116

💛  - Coveralls


Update repositories.txt

Hello @andhieSetyabudi. The .git suffix is not necessary. It is fine as it was before so I'll close this pull request.


KeyError always at Chapter 2

Hi.  Just starting out with this and I have been exploring a range of options.  Initially I got the GPT-4-32k error, so I changed all of those to GPT-4.  I am on a well paid GPT account, not a free one.  For some reason, I keep getting this error each time I run the cells and I am not sure what I am doing wrong.
Step Cost (OpenAI): 0.08856
generated plots
Step Cost (OpenAI): 0.0936
selected best plot
Step Cost (OpenAI): 0.07782
plot improved
Step Cost (OpenAI): 0.001497
title generated
Generating storyline with chapters and high-level details...
Step Cost (OpenAI): 0.10764000000000001
Step Cost (OpenAI): 0.14016
storyline generated
Step Cost (OpenAI): 0.14730000000000001
Step Cost (OpenAI): 0.14730000000000001
first chapter written
Writing chapter 2...
KeyError                                  Traceback (most recent call last)
 in <cell line: 5>()
3 num_chapters = 22
4 writing_style = "Clear and easily understandable, hard science fiction. Lots of dialogue."
----> 5 novel, title, chapters, chapter_titles = write_fantasy_novel(prompt, num_chapters, writing_style, claude_true)
6
7 # Replace chapter descriptions with body text in chapter_titles
1 frames
 in write_fantasy_novel(prompt, num_chapters, writing_style, claude_true)
277         print(f"Writing chapter {i+2}...") # + 2 because the first chapter was already added
278
--> 279         chapter = write_chapter(novel, storyline, chapter_titles[i+1])
280         try:
281           if len(str(chapter)) < 100:
 in write_chapter(previous_chapters, plot, chapter_title, claude)
176         response = requests.post(url, headers=headers, json=data)
177
--> 178         print_step_costs_anthropic(prompt, response.json()['completion'])
179
180         return 'Chapter ' + response.json()['completion'].strip().split('```')[0].strip()
KeyError: 'completion'

I was stuck on the same error. I just changed claude=True to claude=False in the write chapter section (assuming you don't have an anthropic API key).


npm start, it can't run normally.

there is an erro when execute "npm start".
Steps to reproduce the behavior:

npm start
then

What version of NodeJS are you using? Does it work with the latest version?

@MoonE

@MoonE
my nodejs version is v12.22.3 and it can work perfectly with ol6.1.1

@MoonE thank you.

Thanks very much for your investigation, @leizhangc. It is fixed in the main branch.


Cannot setup bridge CNI

Describe the bug
We are trying to set up bridge CNI in our environment. We followed docs (https://docs.openshift.com/container-platform/4.13/networking/multiple_networks/configuring-additional-network.html#nw-multus-bridge-object_configuring-additional-network) but 'bridge vlan add vid VLAN_ID dev DEV' doesnt work and return 'RTNETLINK answers: Operation not supported'
Version
4.13.0-0.okd-2023-08-18-135805
How reproducible
Try to run the command on worker node.

Please attach (or upload to the public file sharing service) must-gather archive

https://drive.google.com/file/d/1qMgx71I5jy1O8fUHvPrXiwtmkvdZLtvQ/view?usp=sharing

The error message “RTNETLINK answers: Operation not supported” indicates that the operation you’re trying to perform is not supported by the network stack and this Error can occur due to various reasons, including kernel configuration or missing modules.
Have you checked the gathered logs on it yet ? If not yet, please let me know i can take a look..
Best,
Kerem ÇELİKER
Head of Cloud Architecture
linkedin.com/in/keremceliker/

Feel free to have a look, sure

Hi,
We are not working on FCOS builds of OKD any more. Please see these documents...
https://okd.io/blog/2024/06/01/okd-future-statement
https://okd.io/blog/2024/07/30/okd-pre-release-testing
Please test with the OKD SCOS nightlies and file a new issue as needed.
Many thanks,
Jaime


Use atomic-polyfill instead of std AtomicBool

Use atomic-polyfill's AtomicBool instead of std::sync::atomic::AtomicBool. This enables use for targets which don't have native atomics (ie, Cortex-M0+).

Thanks for the PR!


Package Portable Server for Ubuntu

As a user, I would like to be able to install Portable Server from a Debian package, or from an APT repository.
AC:

Add a build script that produces a Debian package with Portable Server for the architecture you are building on. (64-bit x86 should be supported.)
The package should add a service that could be added to a run-level.
The service should be configurable from files under .
A non-root user should be able to start the server from the command line, without running the system service.

We should probably split this ticket up. The original portable installer didn't support configuring as a service, so I think that should be split into its own ticket.

We could possibly split it.  However, running the already existing server as a service doesn't seem like a large effort to me.  It is also something that would depend on the distribution / OS it's running on, and may not be separable as a general task across platforms.

Would be nice to slightly expand the scope of this issue to include RPM build for centos/rhel.


Add Q and Escape to the default Quit keybindings

Q and Escape should be added to the default keybindings to quit.

@trimental you okay if I just go ahead and add vim-like to the defaults? It's pretty easy for people to override the changes with [keybindings.extra]

@CosmicHorrorDev yep totally happy with that. Would be a pretty useful binding.

Escape along with a whole slew of vim-like bindings are now included in the default bindings


threadbolts.com isn't bypassed

Domain
threadbolts.com
Link
https://threadbolts.com/buy-car-insurance-online-affordable-car-insurance-best-car-insurance/
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Linux
(Optional) Anything else?
Original link: https://defaultfreeshort.in/DSqw
Code of Conduct

[x] I agree to follow this project's Code of Conduct

Fixed, thanks for the report


Generate documentation for the Fortran API

In GitLab by @ksiero on Jun 1, 2020, 13:13

The python part is covered by issue #187 , refocusing this one for Fortran only.

unassigned @ksiero


TASK - E2E Testing Framework for VS Code

Description
Definition and implementation of the testing framework for the VS Code plugin.
Acceptance Criteria

[ ] Testing framework finalized
[ ] Initial testing implemented

Additional Context and Related Items

@michaelkernaghan for context

dupe of #1650


Exclusion Constraint Object Value Display

Problem
Currently we're able to display the selected value in the message, as per the example from the docs:
var constraints = {
  subdomain: {
    exclusion: {
      within: {jp: "Japan", "ch": "China"},
      message: "^We don't support %{value} right now, sorry"
    }
  }
};

validate({subdomain: "jp"}, constraints);
// => {"subdomain": ["We don't support jp right now, sorry"]}

validate({subdomain: "com"}, constraints);
// => undefined

I'm not exactly sure what the purpose of the key/value pair is. I can't seem to find where the Value assigned is used.
Typically, the label presented to the user isn't the value stored, nor the value which is validated. Using a similar example, a dropdown for "country" could look something like:
<select name="country">
  <option value="au">Australia</option>
  <option value="gb">Great Britain</option>
  <option value="nz">New Zealand</option>
  <option value="us">United States</option>
</select>

So when attempting to validate the value, the logical way to fetch the value would be something along the lines of myForm.country.value which would return any of au, gb, nz, us. Using the current validation API, this would mean the constraints would need to look like:
var constraints = {
  country: {
    exclusion: {
      within: {au: "Australia", nz: "New Zealand"},
      message: "^We don't support %{value} right now, sorry"
    }
  }
};

Which, with a selection of "Australia" would result in a message reading "We don't support au right now, sorry". (As opposed to the more user-friendly "We don't support Australia right now, sorry").
Solution?
It doesn't look too difficult to add a %{label}, so the message could be provided as
"^We don't support %{label} right now, sorry", resulting in "We don't support Australia right now, sorry".
(I'm open to it not being %{label}, however it doesn't make sense for it to be key, as it's not the key in the object, the value is. Such confusion! 😕 )

Fixed, thanks!


feat: tested polygon id

I tested sending on-chain verification with Metamask. It works well, sweet.
https://mumbai.polygonscan.com//tx/0x933b87b1596e5f250840cd6a3f65793a2d67e702f98cde3e59eb4bf997ffecce

Found out some development has to be done to build our use case.

here is test app
https://codesandbox.io/s/frontend-claim-an-erc20-zk-airdrop-on-polygon-mumbai-forked-hnsii3?file=/index.js:0-3110


[SuperText] - Added an underline layer (Resolves #1634)

[SuperText] - Added an underline layer (Resolves #1634)

@angelosilvestre I'm gonna merge this so I can release a new version of super_text_layout and use it in super_editor.


How to achieve Multi-line text in a Gantt chart boc

I wish to have multi-line text in the gantt chart to show the name and mobile number in a new line :
I have tried  ,  , /n but could wasn't able to achieve it. Any help on this will be greatly appreciated.
Folllowing is my code :
`gantt
dateFormat  YYYY-MM-DD HH:mm
title Support Schedule
section APAC
. : E1 , 2018-07-11,1m
John  Mobile-9963792226 : E1, 2018-07-11 08:00, 9h
section INDIA
Robert : done,E2, 2018-07-11 11:00,7h
Mike : active,E3, 2018-07-11 14:00,9h
Srinivas : crit,E4, 2018-07-11 11:00,9h
section EURO
Zoran: E5, 2018-07-11 13:00,9h`

Even suggestion https://github.com/knsv/mermaid/issues/199#issuecomment-135757612 does not work on this type of chart. :(


[Bug Report] Configuration Error?

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Dig straight down
Right click 5 times
Craft a Netherite Hoe
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Server Software and Version:

Vendor: Bungeecord
Minecraft Version: 1.8.8
Output of /version command: Command Not Found?

Additional context
Configuration items for just-X-more and Max-players have been reversed

Improperly filled out issue template


[Question] World section of config.

I want people in my Hub world to run /wild and be sent to the smp14 world. I cant seem to get my head around the config. I don't think I've done it right... Could you advise?
Pastebin: https://pastebin.com/zRyXNz6C

https://pastebin.com/ypUSCaBm
i've also tried this

The WorldTo belongs in the same area as the mins and maxs

@Castiella The correct syntax is:
Worlds:
world:
minX: -5000
maxX: 5000
minZ: -5000
maxZ: 5000
InvertY: true
worldA:
WorldTo: worldB
worldB:
minX: -1000
maxX: 1000
minZ: -1000
maxZ: 1000


Proxy the kafka by apisix

Fixes: https://github.com/apache/apisix/issues/10412
Changes:
Add the blog for proxy the Kafka cluster with apisix

Screenshots of the change:

/cc @pottekkat

Thanks for the contribution @yanmxa!

Thanks @yzeng25 !
Done!

@pottekkat PTAL at the contents.


Update technologies in overview page

Fixes

https://issues.redhat.com/browse/RHTAPBUGS-485

Description

Update technologies on overview page.

Type of change

[x] Bugfix

Screen shots / Gifs for design review

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm

/retest

/retest

/retest


log the packet size of dropped packets

Codecov Report

Merging #2273 into master will not change coverage.
The diff coverage is 66.67%.

@@          Coverage Diff           @@
##           master   #2273   +/-   ##
======================================
  Coverage      86%     86%
======================================
  Files         108     108
  Lines        8074    8074
======================================
  Hits         6944    6944
  Misses        852     852
  Partials      278     278

Impacted Files
Coverage Δ

session.go
74.01% <66.67%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d76c5...6309656. Read the comment docs.


Fix server not working when using uws module (for Updates branch)

I've just noticed that uws gives ArrayBuffers on messages - this change should replace the message with a Buffer that shares memory with the old ArrayBuffer.
Should fix server not working with uws, I've not tested it; if not I'll investigate more.

k

Does this work with the UWS module? I need to know before I can merge

It doesn't, gotta debug it more.

Made it work now but had to move the sendPacket function to the PacketHandler due to errors with the old technique. Committing changes now

done, tested with both ws and uws and seems to be working

It does not work (atleast for me.)
I think it'd be best to keep it in GameServer, to avoid errors. Why was it moved to PacketHandler in the first place?

I've broken bots xD

It works now.

I think it'd be best to keep it in GameServer, to avoid errors.

It was kept as a custom function in the ws module. It wasn't even added when you switch to uws before these updates. Barbosik compromised this by moving that function over to GameServer.start.
I forgot that bots don't have socket.send, and tries emitting the close event on FakeSocket (and of course failing).

Why was it moved to PacketHandler in the first place?

The .sendPacket function is there just for checking the websocket state (i.e. if the connection is closed) before actually sending a packet. It feels more suitable for PacketHandler than for GameServer. I also have it set up that way on my multiverse server and does the job fine.

@Luka967 It seems it is having trouble emitting "close". Take a look
I've tried replacing "socket" with various other things for emitting close but nothing seems to be working for it. Do you know why this might be?

Sure, I forgot about minions too lol

@Luka967 Thank you xd

fix red color LB :)

@Jhair2015 megabyte just did in the #446


User Story: Create leaderboard for MetaphorQA (April 26)

We (@nightingal3, @pfliu-nlp, and @neubig) would like to create a leaderboard for the metaphorQA dataset as an example of what leaderboards in.
In order to do this, there are a number of sub-issues:

Make sure that all systems listed as being evaluated on "metaphorqa" actually are evaluated on the same dataset, relying on this separation of dataset and system submission: https://github.com/neulab/ExplainaBoard/issues/141
We need to create a leaderboard solely for metaphorQA based on this: https://github.com/neulab/explainaboard_web/issues/121
The above two are most immediately urgent, but there are also some dataset-specific annotations that we'd like to incorporate into bucketing

Design decisions and questions
For every document in the dataset_metadata collection, we display a leaderboard. (Question: what is the granularity of a single document? It seems like it is subdataset + split? (1 document represents a specific split of a specific subdataset)
There are 2 ways for userd to find the leaderboard:

Click on “Datasets” and search for a specific dataset first. We’ll add a leaderboard link for each dataset row. This should be simple to implement:

Click on “Leaderboards” and select a specific task. Under each task, we’ll display the leaderboard links by their dataset names. This is a little more complex:

I aim to get at least 1. done (if possible 2. also) by Apr. 26.

Yes, that's great. Thanks!

"For every document in the dataset_metadata collection, we display a leaderboard. (Question: what is the granularity of a single document? It seems like it is subdataset + split?""

For single document, yes.
But when it comes to the dataset-based leaderboards, how do we define the granularity of the dataset?

(1) dataset
(2) subdataset
(3) split
I guess it should be (2)?

@pfliu-nlp That's a great question. What about displaying a leaderboard for every "dataset-subdataset" and with the function to filter on "split"?

yeah, have the same idea, let's go with this plan.

I think it needs to be defined on splits. Different splits are different datasets so the scores for the dev split and the test split are not comparable.

Would it be a good idea to use a "tab" that allows users to switch across splits of the same dataset? But it's also fine if we have
a split-based leaderboard.

Yeah, I agree. I think the leaderboard should probably be on the split level. But we can maybe still display all the splits for the same dataset on the same page. We can put a dropdown  so users can choose the split or put them in different tabs.

I like the tabs over splits (and we can also start with just the test split for now if that's easier).

Sounds great, I'll go with the tabs and start with test split.

Basic functionality is working, so I think we can close this? Great job all!


Unfortunately I was not able to reproduce your bug. You said you created a .build-tools.cson and clicked on the "Accept"-Button of the command editor(?). If the issue persists, it would be nice if you could you tell me what happened between creating the file and clicking that button.


re-staging after formatting

It seems that pre-commit doesn't re-stage files that are changed, making auto-fixes and formatting in pre-commit, while not useless, a lot less ergonomic. Could this be handled on the hook's side?

I don't think that's possible because the hook only defines how to run the command and does not control any part of pre-commit or git.
I'll close this issue as it's not actionable via ruff-pre-commit. Happy to re-open if there's new information on this.

I don't think that's possible because the hook only defines how to run the command and does not control any part of pre-commit or git.
I'll close this issue as it's not actionable via ruff-pre-commit. Happy to re-open if there's new information on this.

@dhruvmanila Having something as simple as git add -u && !! (re-stage all modified files that are already staged [i.e. the files changed by pre-commit hook] and re-run the one-before-last command [which will be the original git commit]) would allow a more seamless pre-commit integration, even if it required passing an extra flag to the ruff pre-commit hook in the .pre-commit-config.yaml and so wasn't enabled by default.
Having worked in the JS ecosystem, it feels very 'mundane' to have to manually do this when the pre-commit hook can quite easily handle this for the developer (as it does in the JS ecosystem).

@dhruvmanila Having something as simple as git add -u && !! (re-stage all modified files that are already staged [i.e. the files changed by pre-commit hook] and re-run the one-before-last command [which will be the original git commit]) would allow a more seamless pre-commit integration, even if it required passing an extra flag to the ruff pre-commit hook in the .pre-commit-config.yaml and so wasn't enabled by default.

I'm not sure if I'd want to include additional commands (other than ruff) in the pre-commit hooks although other people on the team might have different opinion. There would be no way to not do that if one wishes to do so. Everyone would by default be opted-in to this feature. There's also the fact that in CI the pre-commit check should fail but a hook re-stages the changes files and then the command passes, there's no way the PR author will know about that.

Having worked in the JS ecosystem, it feels very 'mundane' to have to manually do this when the pre-commit hook can quite easily handle this for the developer (as it does in the JS ecosystem).

Can you please elaborate on what happens in the JS ecosystem? I'm not aware of it as I haven't worked that much in the ecosystem.

There would be no way to not do that if one wishes to do so. Everyone would by default be opted-in to this feature.

Is it not possible to add 'CLI' arguments to the pre-commit hook, like you have with the ruff check and ruff format commands? If it is, then you can have a --restage-and-commit flag, or akin, that's disabled by default but users can optionally enable.

There's also the fact that in CI the pre-commit check should fail but a hook re-stages the changes files and then the command passes

The re-staging and committing will only happen if all of the linting issues have been resolved automatically. If there's issues that can't be automatically resolved, then the hook errors and doesn't re-stage/commit.

Can you please elaborate on what happens in the JS ecosystem? I'm not aware of it as I haven't worked that much in the ecosystem.

The JS ecosystem largely uses husky for hook generation (equivalent of python's pre-commit), with lint-staged as the linter/formatter. When you go to commit a file, husky runs its pre-commit hook which is typically configured to trigger lint-staged.
The difference to Python is that when lint-staged runs, it applies any auto-fixable solutions and if there's not any issues that it can't automatically fix it will re-stage & commit the result for the developer.
This means the JS workflow for solely auto-fixable linting issues is "commit a file", whereas the Python workflow (with Ruff) is "commit a file" -> "see that linting failed" -> "run linting manually" -> "see it's passing (because everything got auto-fixed)" -> "re-stage files" -> "commit again". The Python workflow is far more verbose, imo unnecessarily.


[HOLD for payment 2023-10-25] [ECard Transactions] Update MoneyReportView UI

Design Doc Section
https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.814c36x8plt
Overview

Goal:
Update our Money Report Headers to separate out Company and Out-Of-Pocket spend.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3
Upwork Job ID:<PHONE_NUMBER>181034496
Last Price Increase: 2023-10-04

I think this is the last one I need to do for the core UI, will try to get a PR up in the morning to wrap the major FE up

@grgia Do we need a regression test here? I'm not sure what would be the test steps from the user/qa perspective to reproduce this

@s77rt remind me - are you paid via Newdot or Upwork?

@lschurr Upwork

Great! Are you able to apply here @s77rt? https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3

@lschurr Applied! Thanks!

Offer sent @s77rt!

Accepted!

Great! Paid. Closing.


HDFS-16422. Fix thread safety of EC decoding during concurrent preads

Reading data on an erasure-coded file with missing replicas(internal block of block group) will cause online reconstruction: read dataUnits part of data and decode them into the target missing data. Each DFSStripedInputStream object has a RawErasureDecoder object, and when we doing pread concurrently, RawErasureDecoder.decode will be invoked concurrently too. RawErasureDecoder.decode is not thread safe, as a result of that we get wrong data from pread occasionally.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 30s

trunk passed

+1 :green_heart:
compile
6m 16s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
5m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
2m 22s

trunk passed

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m  6s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 57s

trunk passed

+1 :green_heart:
shadedclient
25m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 13s

the patch passed

+1 :green_heart:
compile
6m  2s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
6m  2s

the patch passed

+1 :green_heart:
compile
5m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
5m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20)

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 55s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 25s

the patch passed

+1 :green_heart:
shadedclient
26m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 21s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
370m  9s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

515m  4s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 48fa7b8498b2 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8f520294bab3908b894e33a8be3a1758875c8c64

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/1/testReport/

Max. process+thread count
2292 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m  6s

trunk passed

+1 :green_heart:
compile
7m 50s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
7m 28s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 29s

trunk passed

+1 :green_heart:
mvnsite
2m 55s

trunk passed

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 57s

trunk passed

+1 :green_heart:
shadedclient
30m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s

the patch passed

+1 :green_heart:
compile
7m 22s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
7m 22s

the patch passed

+1 :green_heart:
compile
7m 17s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
7m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 13s

the patch passed

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
1m 51s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 19s

the patch passed

+1 :green_heart:
shadedclient
26m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 18s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
357m 56s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

522m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux a757016a11d7 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 83e837b7b96f1ffe70e70202757f41994cb0d7af

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/2/testReport/

Max. process+thread count
2337 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@sodonnel Do you have time to take a look on this pr? Thanks a lot.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 26s

trunk passed

+1 :green_heart:
compile
29m  2s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
24m 17s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 15s

trunk passed

+1 :green_heart:
mvnsite
5m  2s

trunk passed

+1 :green_heart:
javadoc
3m 40s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
9m 58s

trunk passed

+1 :green_heart:
shadedclient
27m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s

the patch passed

+1 :green_heart:
compile
28m  9s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
28m  9s

the patch passed

+1 :green_heart:
compile
24m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
24m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 19s

the patch passed

+1 :green_heart:
mvnsite
4m 59s

the patch passed

+1 :green_heart:
javadoc
3m 34s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 42s

the patch passed

+1 :green_heart:
shadedclient
28m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 19s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
427m 12s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 56s

The patch does not generate ASF License warnings.

712m 26s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 986cf68ad1a4 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65aedd2011d7efcd004ce8e1f127347f749d4d1c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/3/testReport/

Max. process+thread count
3143 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
4m  7s

Maven dependency ordering for branch

-1 :x:
mvninstall
9m  1s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
42m 48s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
31m 57s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
6m 53s

trunk passed

+1 :green_heart:
mvnsite
6m 21s

trunk passed

+1 :green_heart:
javadoc
4m 43s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
5m 11s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
11m 30s

trunk passed

+1 :green_heart:
shadedclient
33m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 44s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 38s

the patch passed

+1 :green_heart:
compile
36m 41s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
36m 41s

the patch passed

+1 :green_heart:
compile
32m  2s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
32m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
5m 32s

the patch passed

+1 :green_heart:
mvnsite
6m 14s

the patch passed

+1 :green_heart:
javadoc
4m 57s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
5m 17s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
11m 44s

the patch passed

+1 :green_heart:
shadedclient
29m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m  5s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
396m 17s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 36s

The patch does not generate ASF License warnings.

713m 52s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithShortCircuitRead

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4d4102f442eb 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4045218c3bd358d948df5aca0b4cea4433ea6975

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/4/testReport/

Max. process+thread count
2084 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 55s

Maven dependency ordering for branch

-1 :x:
mvninstall
25m 15s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
16m 23s
/branch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in trunk failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
13m 17s
/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
checkstyle
3m 34s

trunk passed

+1 :green_heart:
mvnsite
3m 47s

trunk passed

+1 :green_heart:
javadoc
2m 39s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m 18s

trunk passed

+1 :green_heart:
shadedclient
25m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s

the patch passed

-1 :x:
compile
17m  4s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
17m  4s
/patch-compile-root-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
14m 37s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
14m 37s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 12s

the patch passed

+1 :green_heart:
mvnsite
4m 29s

the patch passed

+1 :green_heart:
javadoc
2m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 17s

the patch passed

+1 :green_heart:
shadedclient
30m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 31s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
339m 22s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

569m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 118b1b802433 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a1b714577ccdd7473a17205ccf6665d91344f797

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/5/testReport/

Max. process+thread count
2958 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@whbing Did you encounter this problem?

Thanks for your review. @jojochuang
Yes, the test will run many loops to meet the race condition of thread safety, which makes it heavy. And it is weird it fails the unrelated tests also. I have removed the test. Thanks a lot.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m  3s

trunk passed

+1 :green_heart:
compile
24m 20s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

+1 :green_heart:
shadedclient
25m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
23m 38s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 38s

the patch passed

+1 :green_heart:
compile
20m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 37s

the patch passed

+1 :green_heart:
shadedclient
25m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 26s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

210m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3881

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c3a2da298996 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7f72a4cdd5753645a11054db09657938f0ed19ce

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/7/testReport/

Max. process+thread count
1252 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3881/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for the fix. Should we also make the encoder thread safe?
https://github.com/apache/hadoop/blob/7f72a4cdd5753645a11054db09657938f0ed19ce/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/RawErasureEncoder.java#L40-L41

Not sure.... there's a reentrant lock inside AbstractNativeRawEncoder but it's the read lock that's held, not write lock, to improve concurrency (HADOOP-15499 I suppose data race problem is considered?


fix(xquery): fix issue 446 (x:pending may crash on XQuery)

Fixes #446
I don't know exactly where the bug is. (I've never understood the original compiler code.)
This pull request simplifies the compiled query and eliminates the last parameter of x:invoke-compiled-current-scenario-or-expect template. As a result, the bug gets fixed.
Example of compiled query
Before this fix, the inner scenario in tutorial/under-the-hood/compilation-variables-scope.xspec was compiled into this hard-to-manage nested query (edited for readability):
...
let $x:result := my:square($impl:param-d47e1)
return
    (
        rep:report-sequence($x:result, 'result'),

        (: invoke each compiled x:expect :)
        let $myv:var-3 := 'var-3-value'
        let $x:tmp := local:scenario1-scenario1-expect1($x:result, $myv:var-1, $myv:var-2, $myv:var-3)
        return
            (
                $x:tmp,
                let $myv:var-4 := 'var-4-value'
                let $x:tmp := local:scenario1-scenario1-expect2($x:result, $myv:var-1, $myv:var-2, $myv:var-3, $myv:var-4)
                return
                    $x:tmp
            )
    )
...

After this fix, the same scenario is compiled into this flattened query (edited for readability):
let $x:result := my:square($impl:param-d47e1)
let $local:actual-result-report := rep:report-sequence($x:result, 'result')

(: invoke each compiled x:expect :)
let $myv:var-3 := 'var-3-value'
let $local:returned-from-scenario1-scenario1-expect1 := local:scenario1-scenario1-expect1($x:result, $myv:var-1, $myv:var-2, $myv:var-3)
let $myv:var-4 := 'var-4-value'
let $local:returned-from-scenario1-scenario1-expect2 := local:scenario1-scenario1-expect2($x:result, $myv:var-1, $myv:var-2, $myv:var-3, $myv:var-4)
return
    (
        $local:actual-result-report,
        $local:returned-from-scenario1-scenario1-expect1,
        $local:returned-from-scenario1-scenario1-expect2
    )

Please see my recent comment in #446 about another instance of the bug. You can decide whether to include that as an additional test.

Thanks for raising it. Added it in dcf038c4fda4961680667d29f16de73af66697ac.


Check: University Apple Developer Account

Hi @cynthiachen28!
When I opened this issue I thought: Maybe it is rather an impediment than product related? What do you think?
If you agree, I would be very happy if you could assign you to the issue and try to solve it!
Regards, Elias

@Interperle: Did the app also run on your apple device? Please confirm or deny and provide a short update. Thanks! :)

@cynthiachen28: Could you please provide an update?

Hi @cynthiachen28!
When I opened this issue I thought: Maybe it is rather an impediment than product related? What do you think?
If you agree, I would be very happy if you could assign you to the issue and try to solve it!
Regards, Elias

For me, it's not an impediment. We only need to make sure whether we could/would get a developer account or not.
I asked help from the AMOS team that how other teams in the previous year acted on the similar situation and whether the AMOS team can offer us an account.
If not, then we can only build the app locally. I think it's understandable.

For me, it's not an impediment. We only need to make sure whether we could/would get a developer account or not.
I asked help from the AMOS team that how other teams in the previous year acted on the similar situation and whether the AMOS team can offer us an account.
If not, then we can only build the app locally. I think it's understandable.

Okay thanks, @cynthiachen28. Then update us as soon as the AMOS team answers :)

Update:
No available account from the AMOS team side and they suggest us to contact RRZE. I send an email today.

Update:
We can deploy the app within our group under RRZE help. They would add us in one group and then we're able to download the app on our Apple device.

Everyone needs to have an AppleID account.


Add common composable of FilterChip

Issue

close #671

Overview (Required)

Added new FilterChipWithDropdownMenu() composable.
Apply the newly created composable to the FilterChip composable below:

FilterDayChip()
FilterCategoryChip()
FilterSessionTypeChip()
FilterLanguageChip()

No changes to UI/UX.

Links

Screenshot

Before
After

I'm sorry but the conflict happens. Sorry for being late the review 🙇


[FlowExporter] Need uniform handling for "External-to-Pod" traffic

Describe the bug
The FlowExporter / FlowAggregator currently don't support "External-to-Pod" traffic, i.e. traffic coming from outside the cluster and targeting a NodePort or LoadBalancer Service.
This is mentioned in the documentation:

Currently, the Flow Exporter feature provides visibility for Pod-to-Pod, Pod-to-Service and Pod-to-External network flows along with the associated statistics such as data throughput (bits per second), packet throughput (packets per second), cumulative byte count and cumulative packet count. Pod-To-Service flow visibility is supported only when Antrea Proxy enabled, which is the case by default starting with Antrea v0.11. In the future, we will enable the support for External-To-Service flows.

However, when looking at NodePort Service traffic, it seems that all cases are not handled uniformly. In some cases, flows are actually exported to the FlowAggregator (with some misleading log messages), while in other cases, flows are not exported. More details below:
Case 1: NodePort with default externalTrafficPolicy
In this case, connections are ignored, thanks to this code: https://github.com/antrea-io/antrea/blob/d6766ccab27e2297298f0e549909d160f92e733c/pkg/agent/flowexporter/connections/conntrack.go#L55-L61
In my opinion, this matches the documented behavior, even though ideally we would support this type of connections
Case 2: NodePort with externalTrafficPolicy=Local
In this case, filtering based on the source IP "fails", and connections are actually exported.
For example, the following may be logged by the FlowAggregator (when using the flow logger sink):
1699997594,1699997598,<IP_ADDRESS>,<IP_ADDRESS>,56171,80,TCP,,,,nginx-hvhjs,default,k8s-node-worker-1,<IP_ADDRESS>,0,,,,,,,,,,,,,

<IP_ADDRESS> is the IP address of my local machine, from which I am accessing the NodePort Service. <IP_ADDRESS> is the IP address of the Pod implementing the Service.
So there is already a discrepancy with case 1. We also see the following warning in the Agent logs:
W1114 21:35:08.430174       1 exporter.go:615] Source IP: <IP_ADDRESS> doesn't exist in PodCIDRs

Case 3: NodePort with Antrea proxyAll enabled
This is similar to case 1, but this time we remove kube-proxy and enable proxyAll in AntreaProxy to handle NodePort traffic.
In this case, the flow is exported:
1699996576,1699996577,<IP_ADDRESS>,<IP_ADDRESS>,55418,80,TCP,,,,nginx-2zskx,default,k8s-node-worker-1,<IP_ADDRESS>,0,,,,,,,,,,,,,

and we see the following logs:
I1114 21:19:37.036002       1 connections.go:128] "Could not retrieve the Service info from antrea-agent-proxier" serviceStr="<IP_ADDRESS>:31749/TCP"
W1114 21:19:37.141838       1 exporter.go:615] Source IP: <IP_ADDRESS> doesn't exist in PodCIDRs

<IP_ADDRESS> is a link-local address used by the proxyAll implementation to redirect traffic from the host network to OVS.
Case 4: NodePort with Pod as source
This is not a common use case by any means, but I thought I would also test this edge case.
The behavior depends on the value of externalTrafficPolicy. When using the default, the connection is treated as "Pod-to-External":
1699999841,1699999844,<IP_ADDRESS>,<IP_ADDRESS>,52136,30415,TCP,toolbox-pr96d,default,k8s-node-worker-1,antrea-agent-xwf6w,kube-system,k8s-node-worker-1,<IP_ADDRESS>,0,,,,,,,,,,,,,

When using externalTrafficPolicy=Local, the connection is actually exported twice:
1700000109,1700000114,<IP_ADDRESS>,<IP_ADDRESS>,37750,80,TCP,toolbox-pr96d,default,k8s-node-worker-1,nginx-hvhjs,default,k8s-node-worker-1,<IP_ADDRESS>,0,,,,,,,,,,,,,
1700000109,1700000114,<IP_ADDRESS>,<IP_ADDRESS>,37750,30415,TCP,toolbox-pr96d,default,k8s-node-worker-1,antrea-agent-xwf6w,kube-system,k8s-node-worker-1,<IP_ADDRESS>,0,,,,,,,,,,,,,

Once as Pod-to-External, and once as a Pod-to-Pod connection.
There is no log message from the FlowExporter in this case.
Note that if we enable proxyAll, results may differ yet again.
Other cases
There are potentially other cases to consider. In particular, I did not test with LoadBalancer Services. I imagine we have very similar issues.
Versions:
ToT version, which includes this PR: https://github.com/antrea-io/antrea/pull/5592
What should we do?
The main issue here IMO is the lack of consistency across all cases, based on whether externalTrafficPolicy is set to Local (which determines whether SNAT is needed) and whether proxyAll is enabled.
We should try to add support for "External-to-Pod" traffic and handle all possible cases consistently. We should include the Service information in the exported flow record, and avoid flooding the logs with warnings.
Because accessing a Service using NodePort or LoadBalancer from a Pod is not common, we don't have to handle this case for now. But ideally, we would handle this case gracefully (e.g., treat it as Pod-to-External, or not export it at all).

cc @yuntanghsu

@antoninbas Any plans to implement this in the foreseeable future?
This feature would be very handy to get complete visibility in the cluster. While inter/intra node traffic is useful, you're pretty blind if you're trying to get a complete picture of the traffic.

@antoninbas Any chance of getting this scheduled for 2.3 or 2.4?

@antoninbas Any chance of getting this scheduled for 2.3 or 2.4?

I find it unlikely. With the lack of active development for Theia, I don't think this is a priority. I have been doing some work on the Flow Aggregator though, so it's not totally impossible.


OCM-9199 | fix: Yaml parsing error

`ginkgo run -focus 67275 tests/e2e
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
Ginkgo CLI Version:
2.14.0
Mismatched package versions found:
2.17.1 used by e2e
Ginkgo will continue to attempt to run but you may see errors (including flag
parsing errors) and should either update your go.mod or your version of the
Ginkgo CLI to match.
To install the matching version of the CLI run
go install github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file.  Alternatively you can use
go run github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file to invoke the matching version of the
Ginkgo CLI.
If you are attempting to test multiple packages that each have a different
version of the Ginkgo library with a single Ginkgo CLI that is currently
unsupported.
Running Suite: ROSA CLI e2e tests suite - /home/psuba/workspace/rosa/tests/e2e
Random Seed:<PHONE_NUMBER>
Will run 1 of 127 specs
•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 127 Specs in 12.129 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 126 Skipped
PASS
Ginkgo ran 1 suite in 13.075907854s
Test Suite Passed`

/needs-ok-to-test

/ok-to-test

/test ?


feat(AlertWebhooks): added Alert-webhooks

PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

LGTM

:tada: This PR is included in version 0.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


UseOnlyDataTable parameter is gone

Hi, I may be missing some new documentation somewhere but the following code no longer works:
 await _context.BulkInsertAsync(myObject, new BulkConfig   {UseOnlyDataTable = true  });
Error: CS0117	'BulkConfig' does not contain a definition for 'UseOnlyDataTable'
We've had this in place for over a year with no issue.
Apologies if there is some release update that I can't seem to find.
jasen

FastMember is removed and now DataTable is used always, so that param was removed.


CI: loosen min scipy requirement.

Otherwise min-requires CI fails

See also #4310.  Didnt dig into test fails there yet though

Ah, sorry I skmmed PR but missed it. closing.

I can't push on #4310 so reopening here to test some things.

I just merged #4310 as it seemed a good step, you can keep iterating here though to fix everything

This now remove meshzoo, I think an alternative would be #4325

Note, I asked there https://github.com/meshpro/meshzoo/issues/93 is the removal of older meshzoo packages was purposefull.

This approach would probably be my preference

I added meshzoo for just a couple examples a while back; It's not that important and can probably be replaced by something else, since all it does is generate a sphere mesh in both examples. I would rather drop that than mess up our numpy deps!

I added meshzoo for just a couple examples a while back; It's not that important and can probably be replaced by something else, since all it does is generate a sphere mesh in both examples. I would rather drop that than mess up our numpy deps!

Yeah we can hardcode a sphere mesh. I'd rather do that than drop the examples entirely. I think my preference here would be dropping meshzoo, but replacing their mesh in the examples with another mesh. We could even use skimage to generate the mesh from a sphere - see https://scikit-image.org/docs/dev/auto_examples/edges/plot_marching_cubes.html.
Maybe longer term we could add a mesh to skimage data - that would be cool cc @jni @grlee77

closed by #4329


Is this up to date with ASP.NET Core 3.0?

It suggests we:

Add a package reference to the Microsoft.AspNetCore.Diagnostics.HealthChecks package. To perform health checks using Entity Framework Core, add a package reference to the Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore package.

But the sample repo's project file does no such thing? There is no Microsoft.AspNetCore.Diagnostics.HealthChecks reference
https://github.com/aspnet/AspNetCore.Docs/blob/f0e7d8e39f902c184da54a04c57f74dcf48162d5/aspnetcore/host-and-deploy/health-checks/samples/3.x/HealthChecksSample/SampleApp.csproj#L8-L13

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c0cbb094-29e9-740a-9fd6-db372641d753
Version Independent ID: 52d8efc9-a336-71d9-6d90-98173cbf6bf4
Content: Health checks in ASP.NET Core
Content Source: aspnetcore/host-and-deploy/health-checks.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Typo ... it should be Microsoft.Extensions.Diagnostics.HealthChecks.
I'll patch it. Thanks for calling it out.

Well .... it was a thing ...
https://www.nuget.org/packages/Microsoft.AspNetCore.Diagnostics.HealthChecks
... possibly 2.x. I'll take a closer look.

So the deal on this one is that the Microsoft.AspNetCore.Diagnostics.HealthChecks package is in the Microsoft.AspNetCore.App package for 2.2, and it references the Microsoft.Extensions.Diagnostics.HealthChecks package. For 2.x, it should say that if the app doesn't use the App package to place a reference to it.
For 3.x, the package is implicit in the framework.
I'll put an update in now to fix it up.

I also noticed the  WriteResponse implementation provided relies on Newtonsoft.Json. Is it appropriate to rewrite this to use System.Text.Json things?

It wasn't according to engineering at the time of the 3.0 update. I'll keep that in mind for the next doc update, which will be for 3.1. I'll put a note now on the sample tracking issue that we're using.

It wasn't according to engineering at the time of the 3.0 update

Ah no, you're quite right. The sample works fine in 3.0 currently, which saves me rewriting it (for the minute at least!).
Thanks for making a note, though!


Unlimited buffers in ffi

This PR aims to fix https://github.com/CosmWasm/go-cosmwasm/issues/59.
On the way, we find and solve other minor issues:

[x] Buffer::read was incorrectly marked safe
[x] Buffer::read confused null and empty buffers
[x] api/memory.go::emptyBuf confused null and empty buffers
[x] Buffers passed to rust methods were allocated just before the call, but never released later.
[x] Removed binary products from repo and added them to gitignore

Done:

[x] Fix cGet

<DB as ReadonlyStorage>::get() now represents empty values as empty vectors, and missing keys as None

[x] Fix cHumanAddress
[x] Fix cCanonicalAddress

Unresolved:

[ ] Catch panics across FFI boundary in both directions (This is UB in all languages)

partly done for cGet, cHumanAddress, and cCanonicalAddress but needs tighter review of all interfaces

[ ] Representing errors around FFI (e.g. the other side panicked and we got no reply)

Representing errors around FFI (e.g. the other side panicked and we got no reply)

We change a lot of traits in cosmwasm 0.8 to enable returning Results. I would just make sure the FFI call returns unique error codes for different conditions (cgo -> rust), and then leave rust behavior as is. This is a TODO to fix up when we update go-cosmwasm to the 0.8-dev version

Looks good. I found one broken test with cargo test. Can you update src/memory.rs:92-97
        let buffer3 = Buffer::from_vec(Vec::new());
        let empty: &[u8] = b"";
        assert_eq!(unsafe { buffer3.read() }, Some(empty));

        let buffer4 = Buffer::with_capacity(7);
        assert_eq!(unsafe { buffer4.read() }, Some(empty));

Added enumeration for status codes returned from Go.
Fixed memory management of vectors passed to go callbacks.
Test fixed. :)

Nice PR.

Looks good

Nice improvements

Thanks you :smile:


General Kanban Project Setup

Description

Space Travelers' Hub Kanban Github Project Link we are working on.
This project involves a total of two teammates/collaborators.

@Titus-Kiplagat
@jkanyi-web

STATUS: APPROVED! 🍾 🎆 🥇
Hi @Titus-Kiplagat @jkanyi-web,
I'm Andres.
You did a great job working on this milestone, your project is complete! 🚀
There is nothing else to say other than... it's time to merge it 🤖
Congratulations! 🎉

Highlights
✅ Great use of GitHub's project features! 🥇
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Bug] when the header is not added to cURL command default must be empty

Steps to reproduce:

Add a cURL by removing a header
Click on the import
and observe

Observation:
It is observed that when the cURL is converted to API by default the header is considered as  "Form URL" even when the data sent is Json and retrieving of data is also not displayed properly. Even on changing the body selection, the data retrieving is. not appropriate
Expectation:
When the header is not specified by the user we have to allow the user to specify and move the data body to align appropriately.
Possibly we can read the data imported to API and specify appropriate data section
Video:

After doing RCA, I have found that this bug is a backend issue.
The issue is with the parsing of the curl input :
file : app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java can be looked for parse function at line number 279 for changes to fix the bug.


Create CMS About Page

This task is to create an About page in the CMS
This page will contain general app information, as well as third-party vendor information for various APIs (i.e. parking, shuttle, etc)
@woznaut sending this your way for review and assistance in creating the necessary copy for the About page

This issue is being closed due to platform migration and may be revisited at a later date.


Does not open due to an error: version `GLIBC_2.33' not found on most recent version of the Linux.

I will fix this issue very soon.
:)

Think I fixed the issue lol. Just need testing on my new Ubuntu virtual machine. :)
I am sorry you were having issues. :(


Wrong 'href' for collection when not using standard ports on dataverse server

I am using an own testing instance of dataverse with 8080 as HTTP port.
Connecting and creation and listing of dataverses works fine.
host = 'my.server.com:8080'
connection = Connection(host, token, use_https=False)
dataverse = connection.get_dataverse('myverse')

However, when creating a new dataset or listing existing datasets I receive the following error:
datasets = dataverse.get_datasets()

InvalidURL: Failed to parse: <IP_ADDRESS>:8080:8080

For some reason the field:
dataverse.collection.get('href')
'https://my.server.com:8080:8080/dvn/api/data-deposit/v1.1/swordv2/collection/dataverse/userverse'

is not set correctly.
Is it possible to make the port another argument in the class Connection?

@chStaiger hi! The easiest solution for you is probably to use the instance of https://demo.dataverse.org which you are very welcome to do.
The bug you found is on the Dataverse server side. I left a todo in the code to not always return https: https://github.com/IQSS/dataverse/blob/v4.8.6/src/main/java/edu/harvard/iq/dataverse/api/datadeposit/UrlManager.java#L185
If you feel like opening a issue at https://github.com/IQSS/dataverse/issues I would appreciate it!

@chStaiger thanks!


Im having some problems with the most famous error..

Describe your problem here.
Im having the same problems as other people that are:
source/psychlua/HScript.hx:291: characters 89-96 : Type not found : TeaCall
now i am on 0.7.2.. what can i do?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Just changed the TeaCall to Tea and it didnt work so i put on TeaCall again... so basiclly no

haxelib set SScript 7.7.0

haxelib set SScript 7.7.0

It did not work, AT FIRST! but then i made more things and it worked... soooo thx!

CASEEEEEEE                       CLOSSSSSSSEEEEEEEEEEEEEEED!


Hacktoberfest welcome

Welcome to everyone who decided to contribute to bitcart during hacktoberfest period or after that.
First, many thanks for your help and support.
How can you help?
There are a lot of ways.
First of all, you can try to use bitcart and find some bugs, open issues about bitcart components in their repositories.
This repository is considered the main one.
Also, you can try to fix issues and add features from issues marked with hacktoberfest label
If you need some help understanding bitcart, join our telegram group.
The roadmap #74 in this repository is also a list of all issues currently opened, check it out first if you want to open some PR's.
Thanks a lot!

Thanks to all the contributors who participated in Hacktoberfest though bitcart!


[FEATURE] Fixes #215. Added display of versioned objects in a bucket.

Do not merge until the backend code for List versions is merged.
Depends on opensds/multi-cloud #853
Added the Object Versioning feature to display object versions in a bucket which fixes #215 . Operations on versions will be supported in the next set of features.

User is now able to see the latest version of the object at the top level with the latest label.
User is now able to see the different versions of the object after expanding the table row.
User is able to perform operations like Download, Delete on the latest version of the object.

Object List with Version

Object List with Expansion to show versions.

Closing after discussion with @kumarashit @nguptaopensds and @rhsakarpos .


Add Chroma datastore support

This adds vector datastore support for Chroma, an open-source embedding database. Resolves #60.
cc @atroyn pls review!

[x] Test this code end-to-end

[x] Make sure it can run with poetry run start!
[x] Write some integration tests

[x] Resolve uncertainties (see TODO(csvoss) in the current PR) about which embeddings function to use. The outer DataStore wrapper provides its own scaffolding for invoking embeddings on each query, because it generates QueryWithEmbedding objects that then get passed to our child class's _query method. However, the Chroma client also accepts an embedding_function.

[x] Pick one of these embedding functions that should be the source-of-truth method that the Chroma datastore implementation handles embeddings
[x] Make sure that embeddings are only handled by that source-of-truth method, and that the code paths do not result in embeddings being created more than once by both methods (which would be more expensive!)

@csvoss lmk when this is shipping, trying to use chroma for a chatgpt plugin template to publish on replit

@Bardia95 this is currently blocked on me, we're refactoring some internal chroma stuff before going ahead
@csvoss, we might want to move this into draft until that lands, expected in the next couple of days

Freshly rebased off main. Marking as draft per the above!

+1 any reason this hasn't been merged?

This should be deprecated in favor of https://github.com/openai/chatgpt-retrieval-plugin/pull/232

Deprecated in favor of https://github.com/openai/chatgpt-retrieval-plugin/pull/232 !


custom:webrtc-camera not available in Dashboards?

webrtc-camera works great in the main lovelace screen but when I try to add it to a custom dashboard in Home Assistant, it complains that "custom:webrtc-camera" is not available.  If I scroll down in the list of available cards, WebRTC does not appear there.

https://github.com/AlexxIT/WebRTC/issues/260


Enable LocalStorage and time-traveling debugger in Electron app

See this repo for an example:
https://github.com/mdgriffith/elm-electron-todomvc/commits/master
I had used the above link as inspiration for this commit introducing LocalStorage in the refactoring branch:
https://github.com/asthenosphere/exosphere/commit/33b8594e87ade76b58eef96c92ae1a4ff2680f96
Might be useful.

This new library might be useful:
https://github.com/billstclair/elm-localstorage

Spent a few hours on this over the weekend. With one caveat the time-traveling debugger 'just works' in Electron if you run elm make with the --debug flag.
The caveat is that you can't view the history in Electron due to some window title error. It does record the history correctly, and you can also export & import history. This is a minor inconvenience, and I decided to move on.
I haven't tried enabling LocalStorage yet.


next things for literature

follow on from
https://github.com/pombase/pombase-chado/issues/67
we could use some of the triage  "classifiers" to sort "reviews" "methods" papers etc.
and make searchable by  the associated  keywords
(we might keep this as an enhancement to specify in the next grant, it's not urgent anyway)

Moving to "future"


⚠ Bofrost.com has degraded performance

In c168165, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 426 ms

Resolved: Bofrost.com performance has improved in bf2d4b2.


[AdaLora] Fix adalora inference issue

Fixes https://github.com/huggingface/peft/issues/571
As stated by @BenjaminBossan the regularization term is only computed in training mode, i.e. when outputs.loss is different than None
Can confirm this snippet that is not working on main
import torch
from peft import AdaLoraConfig, get_peft_model, AutoPeftModelForCausalLM
from transformers import AutoModelForCausalLM

model_id = "facebook/opt-350m"
peft_config = AdaLoraConfig(
    task_type="CAUSAL_LM"
)

model = AutoModelForCausalLM.from_pretrained(model_id)
dummy_input = torch.LongTensor([[1, 2, 3, 4, 5]])

model = get_peft_model(model, peft_config)
model.save_pretrained("test-adalora")

model = AutoPeftModelForCausalLM.from_pretrained("test-adalora")
_ = model(dummy_input)

Now works
Also fixes an issue when creating an adalora model with dropout == 0.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


feature: An option or highlight group to set lualine section (a, b, c) colors

Did you check the docs?

[X] I have read all the solarized-osaka.nvim docs

Is your feature request related to a problem? Please describe.
I like more the older (2nd lualine in screenshot) variant, in which section b has a different color than section c.

Is there a way to customize this via the config/opts for solarized-osaka?
I know there is an issue #12 in which section b was matched to the color of section c. But now the difference between section b and c has disappeared.
Describe the solution you'd like
An option or highlight group, alternatively a tip on how I can achieve this using the available options.
Describe alternatives you've considered

Additional context

My current workaround is to customize the lualine.themes.solarized-osaka theme directly in my lualine.lua configuration:
-- custom solarized-osaka section colors
local colors = require('solarized-osaka.colors').setup({ transform = true })
local custom_theme = require('lualine.themes.solarized-osaka')
custom_theme.normal.b.fg = colors.black
custom_theme.normal.b.bg = colors.fg

the 'b' section was not right. thanks


Some code highlighting support for RFC arguments

Thinking about how arguments could look.
Full markdown is maybe an overstretch, but I think external links or code snippets could be an interesting option
Related to #1

Agree! I think we need

Limited markdown support
Server-side code highlighting

For now it actually works pretty well, let's keep it like this 👍


merging in Friday Jan 19th provincials code

Got odometry working in the provincials branch. Bringing that in to synch up.

merged manually


[Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException

Master https://github.com/apache/pulsar/issues/13918
Motivation & Modification
Makes exceptions on the Transaction client side clearer.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

Sorry, I'm not sure why we need to make the exception MetaStoreHandlerNotReadyException to extend PulsarClientException. Could you add some explanation?

/pulsarbot run-failure-checks

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


Support scheduling at AWS Organizations level

The main use-case is not having to maintain the list of ARNs or Account IDs within my org, and have this dynamically retrieved on each run from organization.list_accounts()
It would be possible to have a config parameter for an IAM Role Name (e.g. "OrgInstanceScheduler") and assuming this set up in all tenant accounts, use the api organization.list_accounts() construct the ARN, assume them, and schedule accordingly.
Ideally do this multi-threaded in all accounts simultaneously.

can this be reopened since v2 was pulled? It would be a highly useful feature.

@rakshb @gockle is this feature working now?
very useful feature...


mkDefined doesn't preserve "simplified" attribute

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock

I realized what's going on here: we shouldn't use mkApplySymbol (and the other mk_) functions in mkDefined, because these calculate new attributes and reset the simplified attribute. Instead, we should take the original attributes and update only the defined field.


Furnace backend

Hi!
JBoss has http://github.com/forge/furnace - addons container based on JBoss Modules (for isolation), and it works great.
Would be cool to see furnace as a backend for pf4j.
WDYT?

Can you give me more details about your idea? What value brings furnace for pf4j and vice versa?

to see furnace as a backend for pf4j

Can you explain me what means furnace as a backend for pf4j?

@bsideup ping


[score] use scoring scale consistent with NCM instead of original npmsearch

scores are out of the original 100 instead of 10.
@tmpvar PTAL

code looks fine. Do we want to change the api as well? https://github.com/nodesource/npmsearch/blob/ncm-score/lib/routes.js#L65
Maybe to avoid breaking backwards compatibility we should populate rating with the 0-10 value and make score the 0-100 value?

@tmpvar - added score to api and to readme, maintaining the rating value as 0-10 value

@tmpvar just realized this never landed - ptal !


[ID] Export information from the ID tool into an excel spreadsheet for maximum compatibility with govt workflows

From Ohio
as a stopgap until new features are in, can we export the info to an Excel Sheet and we can track/modify on our own after?

From OH's latest email:

There is not an ability to export to excel, so even if we were using this tool to find the opportunities we will then have to enter them again in excel to do the other tracking this tool does not do for us on how agencies plan to respond to the opportunity.

A local partner indicated that the ability to export the tables to CSV would be their top priority.

Put the button here:

The download icon is from Bootstrap Icons.
CC @mhuang-usdr


How to prevent or recover from accidental use of pip install?

Please bear with me, I'm new to pipenv so my question might be quite silly.
Once pipenv is installed is there a way to prevent users from accidentally (un)installing packages with "pip install"?
If my understanding is correct "pip install" works at a lower level than pipenv and will therefore bypass the Pipfile and Pipfile.lock. So if someone installs a new package in their local environment using pip this will go unnoticed by our deployment script (which calls pipenv sync) and will cause errors on our server.
Now of course you could say that it's the user's fault for not using the right command. But my team works on a very large number python projects and the migration to pipenv will happen progressively. Inevitably people will mistakenly use pip from time to time.
What would you recommend to either avoid, warn about or recover from bypassing pipenv? Ideally I'd like a way to prevent direct call to "pip install", although should not be the default behaviour. But at the very least I'd like to have a pipenv command to detect discrepancies between installed packages and Pipfile.lock. I can get some of these discrepancies by running "pipenv clean --dry-run" but I can't find a way to detect removed packages still in Pipfile.
My plan would be to add a git hook in my projects to report such discrepancies on commit so there's no way they would propagate from one team member's local environment to the rest of the team or the application server.

How is your production server getting deployed? Install/uninstall packages in local dev and copy them to deploy server? I try to understand why you have to take the packages in local development machine as the final deployed environment.
If so, how about setup CI/CD? In that, you install packages with pipenv in virtualenv and run some tests to make sure your packages are not missing

To recover as you said, pipenv sync can sync the working set to the content of Pipfile.lock. Then you can use Pipenv to install/uninstall packages.
pipenv clean, OTOH, can purge packages not specified in Pipfile.lock.

Thank you both for the replies. Frostming, you're right, pipenv sync && pipenv clean will restore the working set exactly as it is in Pipfile.lock, thanks for the tip.
(@jxltom currently we have requirements.txt in our github repos and we use 'fabric' and git to deploy automatically to the servers and install packages with something like git pull && pip install -U -r requirements.txt. My concern here is that if we start using pipenv, people can still use pip/requirements.txt by mistake and pip doesn't update the lockfiles so we have two disconnected states)
Would it be useful to have a pipenv command to tell the difference between installed packaged and Pipfile.lock?
Here's a simple use case:
virtualenv env
env/bin/pip install pipenv
. env/bin/activate
pipenv install six
pip install ujson
pip uninstall -y six
# (1)
pipenv sync
=> reinstall six but ujson is still there
pipenv clean
=> removes ujson but also pipenv, virtualenv, ...! I believe this is because the virtualenv wasn't created by pipenv?

In (1), I wish I could use a command like this to show differences between Pipfile.lock and the installed packages:
pipenv graph --diff
+ujson==1.35
-six==1.12.0

Would such command be useful?

removes ujson but also pipenv, virtualenv, ...! I believe this is because the virtualenv wasn't created by pipenv?

Yeah, that is a problem. Maybe we should filter out pipenv and dependencies when cleaning.

I wish I could use a command like this to show differences between Pipfile.lock and the installed packages

That's worth considering, I'm +1 on this, except I prefer pipenv sync --dry-run. Would you like to submit a PEEP for it?

A workaround is to comparing pipenv run pip freeze and pipenv lock -r -d but you need to write a simple script for comparing that, and then you could use it in git hooks.

thanks for the issue, the real way to 'recover' is just to re-install with pipenv which will resolve it properly
closing for now, good luck!