Presto CLI improvements to validate the LDAP credentials on login

Hi,
After enabling LDAP auth for Presto, when I pass in options for CLI as follows:
root@dataworker101:~ # presto --server testserver.int.blah.com:8080 --catalog hive --schema dwh
presto:dwh> use scratch; show tables;
Error running command: Error starting query at <blah blah blah>

I am still able to login, however an error is thrown only after we run a query. Observed the same behavior for incorrect password after LDAP is enabled. It would be nice to validate the credentials at login itself instead of validating after running a query.
As quoted by @findepi on Slack:

this is a consequence of the fact that Presto session state is kept on the client side.
There is no “session” on the server. So, CLI isn’t going to the server on startup.
However, I see this as an unexpected behavior, and not necessarily desirable.
We have same behavior in JDBC, where it could be saving some overhead unwanted
in programmatic usage, but CLI should be as user friendly as possible.
Also, CLI does some background queries to fetch table and function information from
the server.

Thanks,
Ravi

duplicate of https://github.com/prestodb/presto/issues/11299


✨  Handle accepting Overvotes

Is there an existing issue for this?

[X] I have searched the existing issues

Suggestion
Overvotes occur when the selection limit is exceed on a contest on a ballot. This is to use extended_data and other tools to handle overvotes.
This will require adding configuration and ensuring that extended_data is already encrypted (#173)
Possible Implementation
No response
Anything else?
No response

@jeffspel_crypto this is the next subset of work


[WIP] New container interface

Draft PR to discuss how the IContainer interface should look like. There is missing code and models and I will fill it in once we decide on this interface.
Things I want to discuss:

[ ] Should WaitStrategy and StartupStrategy be public (in the interface)

if they are not in the interface, they can only be customized by inheriting a new class
if they are in the interface, they can be customized by the builder

[ ] IList or List

Makes no difference to me but arguably should be interface
If it's interface, then there are some methods in List that cannot be used

[ ] IDictionary or Dictionary

Same as List

[ ] Bind class should be an interface as well?
[ ] GetMappedPort.

If exposed port is not mapped, should it throw InvalidOperationException, return null, or throw a different exception?
Method already throws InvalidOperationException if container is not yet started

If there are other things you want to discuss, please bring it up in another comment, and I'll consolidate the results in this top comment.

@HofmeisterAn How about the namespace?
Any suggestions on if we need to change the namespace?
FQNS for this class is now TestContainers.Containers.IContainer and the plan is to follow the origin namespacing for this project.
eg.

Builders
Containers
DockerClient
Images

Common stuff like Exceptions will be in the root namespace, TestContainers

I'll wait till the end of this week, and I'll fill in the other interfaces so that this interface will compile.
@HofmeisterAn @swissarmykirpan

@isen-ng If you need help, let me know.


inheritance mojo pg classes

Summary

Patching for Inheritance of main classes of Mojo::Pg.
And also new attribute $pg->on_connect.
And also eval non-blocking callback wrapper.

Afraid i have to give this a :-1: vote, because the patch lacks focus and does a lot of things i don't like.

Okay, please add possibility of the inheritance by your way.

Perhaps this topic should be discussed on IRC or the mailing-list first.

i had mentioned on http://irclog.perlgeek.de/mojo/2016-06-29#i_12755913

Ok, @kraih, i'll correct the patch on focus inheritance


Fixing the function headers for decorated functions in the docs

@artwr  functools.wraps does preserve headers starting in 3.4, but in the meantime we have to use decorator.decorator
This makes the docs looks much better, especially the operators section.

I do not see the individual operators when I make html in this branch.

Yeah it's broken. Turned out to be much harder than I though. I woke up this morning with an idea on how to monkey patch this.

@artwr this is ugly but it makes the docs pretty...

My eyes....

:+1:, for it is for the common good.


Use only Admin portal of Camaleon with Rails 4 application

Hi,
I have existing rails 4 application. I wanted to use a cms with it.
I have added camaleon gem and followed the steps mentioned in read me. I have noticed that it tries to use my root_url and i have root set already in to my home view. I am able to view my rails view but it breaks some functionality. The reason can be that camaleon is not quering my user model at all as you can see in attached screenshot.

Another issue is that now i am unable to use current_user provided by devise. If i comment the root route in route file then root points to welcome view of camaleon. Although the Admin portal works fine.
Is there any way to use just the admin panel without disturbing the existing views and functionality.

Hi @Bilkhaan,
I fixed the problem, please verify using git version.
Regards,


I am facing the issue of unknown IO Exception while enqueuing the download

I am facing the issue of unknown IO Exception while enqueuing the download
Please help me..

Here is my way of adding dowload to manager.If here is any problem then please help me......

This error is often due to a storage permission.
It will be removed after granting the permission.

Off-topic:
Hey @sahilsingh09092007 , what color scheme and font are you using?


Migrate delete_expired tasks to Django.

The recaptcha changes (in utils.py) here are to deal with issue #644 and keep Travis happy, but aren't really related to this PR, and are also being done separately in PR #645 to unblock other stuff. I'll leave issue #644 open until I really understand what's going on, but I can't see any way it might have been caused by migrating these tasks to Django.


#358 [DOC] Running guide for Mesos and Yarn

Documented about external cluster configuration for running Zeppelin with Mesos
My actual configuration is

export MASTER=mesos://zk://dicc-m001:2181:dicc-m002:2181,dicc-m003:2181/mesos-0.18.1
export SPARK_HOME=/app/spark-1.2.1-bin-2.5.0-cdh5.3.0
export MESOS_NATIVE_LIBRARY=/app/mesos-0.18.1/lib/libmesos.so

@swkimme Please review it. I've tested on my real cluster with those settings.

@swkimme I added a document for yarn for avoiding conflicts while merging it. Check this, please.

Great!
I guess we need to add building option, too. (-Pyarn)

@swkimme -Pyarn is already coverted by #312 which is merged today. This PR includes a documentation only because mesos-support and yarn-support edit same locations of the file of  READEME.md.

Ah, I missed it. then, LGTM!!

@swkimme Thanks.

@swkimme Could you please merge this PR?

I'm merging it.
Definitely this doc will help many!
Thanks for contribution!!


datocms-structured-text-to-html-string:  tags are rendered as

Using the to_html function. If a structured text node includes a \n character it gets rendered it out as <br>
For example
    {
      "type": "heading",
      "level": 1,
      "children": [
        {
          "type": "span",
          "value": "Hello\nworld"
        }
      ]

would result in
hello<br>world
.
Looks like the generated snapshot for testing this is incorrect and has masked a passing result:
https://github.com/datocms/structured-text/blob/main/packages/to-html-string/__tests__/__snapshots__/index.test.tsx.snap#L3

You're right! Fixed in datocms-structured-text-to-html-string v2.0.2


Update BlockUserInfoVisibility doc

@yimingMSFT is there a corresponding change in backend cmdlet code?

@yimingMSFT is there a corresponding change in backend cmdlet code?

Correct. This is backed by a backend change.

@Stacyrch140 I see you merged other PRs. May I ask the process to merge this PR? Seems I do not have permission to merge it.


⚠ Bofrost.at has degraded performance

In 67aa407, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2108 ms

Resolved: Bofrost.at performance has improved in 2d8948e.


Redo Endless Battle Clause with a new specification

Based on discussion in #5453, this change implements the core of the new EBC:

Any Pokémon hit by a foe’s Heal Pulse or Floral Healing becomes stale.
Any Pokémon using (consuming) an acquired Leppa Berry (defined as a Leppa Berry which the Pokemon did not start the battle with, for example, one obtained Fling, Trick, Harvest, Recycle, Bug Bite, Pluck, Pickup etc) becomes stale.
If all Pokémon on the field are stale and at least one team does not have the option of switching to a non-stale Pokémon, with at least one Pokémon on a side's staleness having been inflicted by a Pokémon of the opposing side, the game ends. If only one side started the battle with the rudimentary means to perform Leppa Berry-cycling (defined to be a team containing a Pokémon holding a Leppa Berry and a Pokémon with Recycle/Harvest/Pickup, it loses, otherwise the battle ends in a tie.

The remaining conditions still need to be implemented

Moves selected by Metronome do not affect staleness in any way (ie. acquiring a Leppa Berry through Metronome will not count as having acquired a Leppa Berry for the purposes of staleness tracking when it is later consumed, nor will Heal Pulse via Metronome confer the stale state to a foe Pokémon).
If all Pokémon on the field are forced to use Struggle ineffectively (where the damage from Struggle does not result in their opponent losing HP by the end of the turn) and at least one team does not have the option of switching to Pokémon that could do something other than Struggle ineffectively, the battle ends in a tie.

https://github.com/Zarel/Pokemon-Showdown/issues/5453#issuecomment-488847446 brings up the possibility for several changes to conditions (I've already taken the liberty of deciding that Pickup should be considered in the same class as Harvest).
When the spec is finalized, I also intend to have us host it on https://pokemonshowdown.com/pages/ebc (or similar), instead of having it simply being 'implementation-defined'.

Please see https://github.com/Zarel/Pokemon-Showdown/issues/5453#issuecomment-489184022 regarding the conditions I left out - I don't feel they (or the other cases the new spec misses) justify the code complexity required. If the community doesn't want to wait 1000 turns for their battles to end in ties, /offerdraw from #5454 seems like a good shortcut (or revisiting a battle time limit).

How complicated is the spec? I feel like the best place to host it is a doc comment in rulesets.js. I'd accept it as a .md file in data/ if you wanted someplace better.

I explicitly rejected /offerdraw as a solution for endless battles for one reason: it's only a viable option if both players are capable of playing a game to a close. If one player needs to leave in a shorter timeframe than three hours (previous obligation, etc), the other player is incentivized to reject the draw, and win on grounds other than game skill.

How complicated is the spec? I feel like the best place to host it is a doc comment in rulesets.js. I'd accept it as a .md file in data/ if you wanted someplace better.

The spec is currently just the 3 conditions outlined in the description of this PR. The length/complexity of the spec is not why I don't want it to exclusively in the codebase, the reasons are to (a) accurately list the rules that govern the game that is being played in a human readable way and (b) distinguish between implementation and specification (where an edge case involving endless battles may be the result of a poor specification or a poor implementation of said specification).
TBH, I'd actually like all our rules to be better defined (eg. outline in detail what is meant by 'putting more than one of their opponent's Pokemon to sleep at a time' for Sleep Clause - what does this mean for Effect Spore etc?), EBC is just the the one I happened to focus on now (and which has the potential to be the most hairy, especial with its implementation prior to the commit). Basically, I think its important to have a specification for all rules in English that players can read/understand/shape and then code which attempts to implementation said specification, not the opaque implementation-is-the-specification we have today.

/offerdraw

You're right, its the wrong solution.
Taking a step back about why I even started this quest to change EBC in the first place: I view false positives (prematurely ending battles and declaring a winner) to be considerably worse than allowing for the possibility of endless battles. Especially so if the players getting dinged can't reason about/plan around the circumstances because they don't know how it works (or can't know how it works, because its too complex).
The revised specification aims to be straightforward to understand and implement (especially given I'm deliberately cutting out the Metronome/ineffective Struggle logi), and seems to cut out a lot of false positives (its still too complicated for me to claim that there will never be a false positive, but I imagine any that exist would be fairly niche), however, has the undesirable effect of not covering a lot of the edge cases the original implementation does (https://github.com/Zarel/Pokemon-Showdown/issues/5453#issuecomment-488847446 covers some of them), potentially leaving players to play out 1000 turns fairly mindlessly to end in a tie (against an opponent who might be utilizing his/her timer to the fullest extent possible, potentially maliciously).
Can we do better than 1000 turns?

Why 1000 turns? Can we instead use data from the logs to determine what an appropriate cut off would be to ensure 99% (or whatever arbitrary N you want) will terminate before then? (My gut feeling is that 1000 turns is currently very long tail). The turn limit could even be per generation, to provide more of a buffer for the comparitively longer games in the earlier gens.
I feel it might be worth distinguishing between the limit for ladder vs. tournament play vs. custom play. The metagames in ladder vs. tournament play are already different, I don't see why we couldn't add a clock time deadline on ladder games vs. tournament games (a malicious Leppa abuser might win battles in ladder play simply by players forfeitting after turn 200 because they dont want to waste their day playing out 800 more turns for a tie just to avoid losing 20 rating points, but a player is a tournament is more likely to be willing to stick it out to the end because a single loss could mean elimination).
Actually hammer out a 50 turn rule equivalent, accepting that it will disallow valid battles (which the current EBC before the PR also definitely does, as evidenced by the replays in #5453). Maybe there can be a gating condition involved, maybe not (eg. a Leppa Berry is involved).

This all might benefit from Policy Review.

I do want to merge this and then refine via Policy Review. The impression I get is that the current EBC implementation has a number of bugs introduced by recent refactors.

The main reason I haven't insta-merged is that I get the impression the new clause also has a number of false positives, mainly to do with someone bringing a Leppacycler and accidentally getting the Leppa relocated.

I might be tentatively fine with merging and reacting quickly to bug reports, though. Leppacycling itself is pretty rare.

The impression I get is that the current EBC implementation has a number of bugs introduced by recent refactors.

Almost certainly

The main reason I haven't insta-merged is that I get the impression the new clause also has a number of false positives, mainly to do with someone bringing a Leppacycler and accidentally getting the Leppa relocated.

Can you thing of a concrete scenario I can add as a test case?

I might be tentatively fine with merging and reacting quickly to bug reports, though. Leppacycling itself is pretty rare.

I think this is mergeable and will have strictly less false positives than the current implementation at the cost of making it much easier for malicious players to force their opponents into a decision of 'sit here for 7 hours and mindlessly play out this game to get a tie or forfeit'.

Can you thing of a concrete scenario I can add as a test case?

Not easily. Let's just wait until someone reports an EBC bug. :p

I think this is mergeable and will have strictly less false positives than the current implementation at the cost of making it much easier for malicious players to force their opponents into a decision of 'sit here for 7 hours and mindlessly play out this game to get a tie or forfeit'.

Two and a half hours, actually. I calculated this out when we settled on 1000 turns.

The spec is currently just the 3 conditions outlined in the description of this PR. The length/complexity of the spec is not why I don't want it to exclusively in the codebase, the reasons are to (a) accurately list the rules that govern the game that is being played in a human readable way and (b) distinguish between implementation and specification (where an edge case involving endless battles may be the result of a poor specification or a poor implementation of said specification).
TBH, I'd actually like all our rules to be better defined (eg. outline in detail what is meant by 'putting more than one of their opponent's Pokemon to sleep at a time' for Sleep Clause - what does this mean for Effect Spore etc?), EBC is just the the one I happened to focus on now (and which has the potential to be the most hairy, especial with its implementation prior to the commit). Basically, I think its important to have a specification for all rules in English that players can read/understand/shape and then code which attempts to implementation said specification, not the opaque implementation-is-the-specification we have today.

I still don't understand what this has to do with hosting the spec on the PS CMS instead of in a doc comment or in GitHub?

I don't disagree with any of this, but I still don't understand what this has to do with hosting the spec on the PS CMS instead of in a doc comment or in GitHub?

I suggested PS because it seems the most user friendly place (besides maybe a page on the Smogon dex) for specifications of rules, the same way it explains various mechanics which are also critical for understanding the game. Basically, I don't see why these rules would be treated any different than item/move descriptions (we don't link people to data/moves.js to explain about how particular moves work). A markdown doc in the repo would be 'OK', but it still feels a little too 'behind the scenes' ?

Hm, PSdex is probably the right place, then.
https://github.com/Zarel/Pokemon-Showdown-Dex/tree/master/articles
Which can be accessed in the Dex.


[Question] Similar libraries

Which libraries, including those for other programming languages, have high quality matrices, vectors and quaternion implementations? I'm asking, so that I have other libraries that I can compare gl-matrix to.
The ones I can list off the top of my head are

GLM but its source code is not exactly readable
SharpDX but it is deprecated
Three.js
Sylvester but it has been abandoned

https://github.com/nfrechette/rtm
https://github.com/Unity-Technologies/Unity.Mathematics/
https://github.com/ebassi/graphene


[FEATURE REQ] Support new RateLimiter API in ServiceBusProcessor

Library name
Azure.Messaging.ServiceBus
Please describe the feature.
Microsoft just announced the System.Threading.RateLimiting package for .NET 7, but which is also compatible with netstandard2.0 and net462, so should be usable in the ServiceBus package.
It looks like it could be a useful alternative to the very simplistic MaxConcurrentMessages property on ServiceBusProcessorOptions, allowing more intelligent throttling of messages coming off the bus.
Consumers could implement custom RateLimiter types to throttle based on domain-specific parameters and constraints.
Also, a single RateLimiter instance could be shared between multiple ServiceBusProcessor instances running in a single process.
Internally, the code could be refactored to using ConcurrencyRateLimiter when MaxConcurrentMessages is used, so everything uses RateLimiter to keep things simple.

Hi @markrendle.   Thank you for your suggestion; this is an interesting idea that I think we'd like to explore.

@JoshLove-msft, @tg-msft, @KrzysztofCwalina:  I'd appreciate any thoughts that you may have.

How does a customer observe backpressure?  Are they forced to catch exceptions, spin while limiter.GetAvailablePermits() <= 0, or ...?
FWIW, I've always wanted an abstraction like https://github.com/Azure/azure-sdk/issues/3841#issuecomment-1029433201 which overlaps some of these scenarios.  It'd be interesting to prototype with RateLimiter in a pipeline policy to explore benefits/use cases across the SDK.  I'd also have no problem making use of this in SB if we're already implementing our own less configurable version.

I think a sample showing how to implement a custom rate limiting policy would be great.

After further team discussion, this is not something that we are planning to add currently, as there have been no further requests nor discussion/upvotes on the issue.   We'd be happy to accept a submission for a sample and collaborate on the design for one, should there be an interest in doing so.   I'm going to close this out.


ODK-X Survey: Redesign the delete dialog box

When a returning user clicks on the list of forms created, there is a button that allows the user to either delete or edit an instance. The delete button opens up the dialog box shown in the screen shot below and this doesn't conform to modern design and the ODK-X design Guidelines

Why the dialog box needs to be improved:

There's no hierarchy in the current design for a high risk action such as deleting an instance.
Dialogs help users act on information, so the call to action should be stated clearly.
The design can be updated in line with the ODK-X Design Guidelines

Design Guidelines:
Colours, icons and other user interface elements, all conform to the ODK-X Design Guidelines

I think you should make your issue more descriptive for posterity. See how it is laid out by @maprehensive in #359 and #360.

Take a look at the guidelines for dialogues from Material Design here, and take a cue on what's best for this dialogue.
Also, make one of the buttons less prominent than the other.

@Cveman1 @maprehensive This is the updated dialog based on the feedback I got and the material design system guide you shared.

For the second dialog design, I followed the placement of the text buttons as seen in this  Dialog example shown in Material design 3 Design system
I suggested this because deleting an instance is a high risk action. Placing the cancel button first would allow the users decide if they want to carry out the action or not, which gives the user more control and prevents error.

@juayuohcarineneng19 has submitted a PR for this issue: https://github.com/odk-x/app-designer/pull/212


Body text is not showing completely it's cutting out.

Hi I am having an issue while trying to send an email body text is not showing completely

Hi @tschoffelen can you please assist me on this why my body text is not being shown completely.
Platform: "IOS"

@tschoffelen @danielmark0116
We are facing this very same issue.
This is a text we are using to test:
! " # $ % & ' ( ) * + , - . / 0 1 2 3 4 5 6 7 8 9 : ; < = > ? @ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~

These are the results of our tests:
Without encodeBody, or encodeBody: false

Apple Email
Gmail
Outlook

With encodeBody: true

Apple Email
Gmail
Outlook

In this one, I think spaces ( ) should not be encoded.

Thanks for testing that @jahirfiquitiva!
Ideally, I think we should customise if/how we encode the body based on the email client chosen, and deprecate the encodeBody parameter. I don't have time in the foreseeable future to work on this myself, but would be more than happy to accept a PR of course!

This should not be marked as stale, the issue is still present

Heya @jahirfiquitiva! Happy to accept a PR to fix this, I am not currently using the email composer option of the lib myself, and don't have time to look into it at the moment

@tschoffelen  I don't feel confident in my react-native knowledge as to be able to provide a PR to fix this. But hopefully in the near future.

Spaces could be encoded as "+", I'll check if the clients support that.

Yeah it seems to differ between clients - appreciate it!


Clicking from the Overview to a section, should make the user feel like they expanded the section, rather than navigated to a whole new page.

Discussion https://github.com/roots-id/DoulaID/issues/30

https://github.com/roots-id/DoulaID/issues/30#issuecomment-2566664588


fix(ast)!: align TSImportType with ESTree

Implements https://github.com/typescript-eslint/typescript-eslint/issues/2998
The copy of props feels wrong, but could not get it working otherwise with the box and borrow things 😅
Also I found that TSImportType was missing some entries for visitors and codegen.
In the case of codegen I'm not really understand the need as all the types seems to be dismissed?

The codegen also prints TypeScript AST now https://github.com/oxc-project/oxc/blob/d9cc429d4a23c55330dbee0f7d353a3195737156/crates/oxc_codegen/src/lib.rs#L39


CompletionSuggestion not support auto import from library

This tracker is for issues related to:

Analyzer

I'm making a plugin base on analyzer_plugin  and follow the doc https://github.com/dart-lang/sdk/blob/master/pkg/analyzer_plugin/doc/tutorial/completion.md
The problem is that libraryUri is set and  isNotImported is set to true, but it still has not 'auto import from xxx' in completion. do i miss anything? or how can i do a completion with auto import library, thanks.
  /// This field is omitted if getSuggestions was used rather than
  /// getSuggestions2.
  ///
  /// This field is omitted if this suggestion corresponds to a locally
  /// declared element.
  ///
  /// If this suggestion corresponds to an already imported element, then this
  /// field is the URI of a library that provides this element, not the URI of
  /// the library where the element is declared.
  ///
  /// If this suggestion corresponds to an element from a not yet imported
  /// library, this field is the URI of a library that could be imported to
  /// make this suggestion accessible in the file where completion was
  /// requested, such as package:foo/bar.dart or
  /// file:///home/me/workspace/foo/test/bar_test.dart.
  String? libraryUri;

  /// True if the suggestion is for an element from a not yet imported library.
  /// This field is omitted if the element is declared locally, or is from
  /// library is already imported, so that the suggestion can be inserted as
  /// is, or if getSuggestions was used rather than getSuggestions2.
  bool? isNotImported;

https://github.com/dart-lang/sdk/blob/29c3fea3bf3aee14c22e628748fafbd2c33cc792/pkg/analysis_server/lib/src/lsp/handlers/handler_completion.dart#L458
maybe useNotImportedCompletions is not true at my side, but how can i set it?

@bwilkerson @scheglov ?

https://github.com/dart-lang/sdk/blob/9e53a1679c37e53dace752be12bce1a4f52272b8/pkg/analysis_server/lib/protocol/protocol_generated.dart#L4858
it seems that only analysis_server can use CompletionGetSuggestions2Result(completion.getSuggestions2).
in analyzer_plugin , it still CompletionGetSuggestionsResult.
/// Handle a 'completion.getSuggestions' request.
///
/// Throw a [RequestFailure] if the request could not be handled.
Future<CompletionGetSuggestionsResult> handleCompletionGetSuggestions(
    CompletionGetSuggestionsParams parameters) async {
  return CompletionGetSuggestionsResult(
      -1, -1, const <CompletionSuggestion>[]);
}

so libraryUri is omitted, right?  in this case, then what time could we use this api? thanks for your time.

tl;dr Maybe never.
The analyzer_plugin package is an unsupported prototype of one possible way that we could support plugins for the analyzer. We actively discourage its use. And because it's not supported we don't have any plans to enhance its functionality. We do occasionally improve the code because the analysis server makes use of some of that code, but that only happens when doing so is the most convenient way for us to improve the analysis server.

occasionally
I'm sad to heart that. analyzer_plugin is useful for who want to add custom lints or completions, it provides the possibility. Thank you all the same, please keep this issue open in case any update.

This is fixed by https://github.com/dart-lang/sdk/commit/019fb7a21488f55d616a8d26e921ed2b28750b81 (more info in https://github.com/Dart-Code/Dart-Code/issues/4275 which was the same report).


Make checkstyle fail on info-level findings

[x] Make checkstyle fail on info-level findings
[x] Windows compatible suppression file

This looks perfectly good.


Bluetooth: controller: Fix the slow Enc Setup alternative

Fix the implementation of slow encryption setup design
alternative to send ENC_RSP PDU before sending REJECT_IND
or REJECT_EXT_IND PDU.
Fixes #19917.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@rugeGerritsen Please verify if this PR resolves #19917

@cvinayak. I still see the same issue. The controller is sending the REJECT_EXT_IND in the next connection event after receiving LL_ENC_REQ. I replicated the setup described in https://github.com/zephyrproject-rtos/zephyr/issues/19917. Tested on commit a0e2fc5589820728f2aad428272ad82399fb14e3 using nrf52840_pca10056

@cvinayak Sorry, this is a fix for CONFIG_BT_LL_SW_LEGACY=y, not for CONFIG_BT_LL_SW_SPLIT (which still have few old commits to be ported before I can have this fix in there).

Quickly verified that the fix works for CONFIG_BT_LL_SW_LEGACY.

@thoh-ot can you approve this, split one has been already merged before this one.


ES Lint Errors strict mode not permitted

I get these errors when running npm run lint:
~/dev/react-component-boilerplate $ npm run lint

><EMAIL_ADDRESS>lint /Users/saschwarz/dev/react-component-boilerplate
> eslint . --ext .js --ext .jsx

The react/jsx-quotes rule is deprecated. Please use the jsx-quotes rule instead.

/Users/saschwarz/dev/react-component-boilerplate/demo/index.js
  1:1  error  Strict mode is not permitted  strict

/Users/saschwarz/dev/react-component-boilerplate/lib/deploy_gh_pages.js
  1:1  error  Strict mode is not permitted  strict

/Users/saschwarz/dev/react-component-boilerplate/src/index.js
  1:1  error  Strict mode is not permitted  strict

/Users/saschwarz/dev/react-component-boilerplate/webpack.config.babel.js
  1:1  error  Strict mode is not permitted  strict

✖ 4 problems (4 errors, 0 warnings)

Did you want to update the .eslintrc to specify "strict": 0?
I'm not certain how to resolve: The react/jsx-quotes rule is deprecated. Please use the jsx-quotes rule instead. I couldn't find where that is specified in the branch and jsx-quotes is already specified in the .eslintrc.

react/jsx-quotes was moved to core as jsx-quotes. Are you sure it isn't picking up global ESLint or something? I can't reproduce this locally.
I don't think that "strict": 0 should be needed. These days all files are strict by default (ES6) so I don't use use strict declarations anymore.

Those files do have 'use strict;' on their first line:
https://github.com/survivejs/react-component-boilerplate/blob/master/demo/index.js#L1
https://github.com/survivejs/react-component-boilerplate/blob/master/webpack.config.babel.js#L1

@saschwarz Those are redundant. Fixed. Thanks!


Add LICENSE

First of all, thank you for your great work!
In order to make this project "officially" usable for anyone I would like to suggest adding an open source license to the project.
I would highly appreciate if you could review the suggested license or adjust it to any other license or your choice (see https://choosealicense.com/ for more information). After the LICENSE file is added to the project it will be clear for users and contributors what can be done with the project.
Thank you!

Thanks you @maxwoerner !


fix(nuxt): use buildAssetsDir in nuxt-teleport-island-component

🔗 Linked issue
📚 Description
It's common in some scenarios, for example when multiple projects are running on the same domain, to define a different value for app.buildAssetsDir. When using componentIslands.selectiveClient in development, the nuxt-teleport-island-component uses a hardcoded value (/_nuxt/).
This PR changes the component to use the buildAssetsDir config. If the config is not set, it'll still use /_nuxt/ as before, because that's the default value of the config.

I opened this as a draft for 2 reasons:

Not sure if it's recommended to get buildAssetsDir from nuxtApp.$config
The test test/bundle.test.ts > minimal nuxt application > default server bundle size (inlined vue modules) is failing because the size was increased to 76.2k. Not sure if this is something I need to update or if it gets updated automatically.


[QUESTION] How to import LoggerModule from another module

[x] I've read the docs of nestjs-pino
[x] I've read the docs of pino and pino-http
[ ] I couldn't find the same question about nestjs-pino
[x] This is not a question about how to use this library with pino-transport-name-goes-here

Question
Hello, I am creating a base library for my nestjs services, in which I am creating a LoggerModule that imports the LoggerModule of nestjs-pino, if I use it in the same project it works OK, but if I create it as a library and try to use it From this, it gives me the following error:
Error: Nest could not find Logger element (this provider does not exist in the current context)
my loggerModule:
import { Module } from '@nestjs/common';
import { LoggerModule as LM } from 'nestjs-pino';

@Module({
  imports: [
    LM.forRoot(),
  ],
})
export class LoggerModule { }

Is there a way to externalize the LoggerModule from nestjs-pino?
Please mention other relevant information such as Node.js version and Operating System.
node: v20.10.0

Hello, I've got the idea, but I'm not sure why it doesn't work. Maybe in your reusable module, you could either export a configuration for logger or export a built module like: export const LoggerModule = LM.forRoot(...). Does it make any sense?

It didn't work either :(, I also realized that if I import the LoggerModule (nestjs-pino) and then my library module in which I use the '@nestjs/common' logger, it ignores the pine one and does it with the default from nestjs, any idea why this happens? (in the app code it uses the pine one but in the library code it uses the nest default)

Sorry, but it's hard to debug by github comments. Minimal example should be added to answer you question properly

my-common-library:
import { Module } from '@nestjs/common';
import { HealthModule } from './health';
import { LoggerModule } from 'nestjs-pino';

@Module({
  imports: [
    LoggerModule
      .forRoot
      //my default config for logger
      (),
    HealthModule, //imports health module with a simple /health
  ],
  controllers: [],
  providers: [],
})
export class CommonsModule {}

build and add to another project with npm install ../my-common-library or npm link, and add import CommonsModule:
import { Module } from '@nestjs/common';
import { AppController } from './app.controller';
import { AppService } from './app.service';
import { CommonsModule } from 'my-common-library';

@Module({
  imports: [CommonsModule], //import common module from library
  controllers: [AppController],
  providers: [AppService],
})
export class AppModule {}

I configure the nestjs logger for the app in main.ts:
import { NestFactory } from '@nestjs/core';
import { AppModule } from './app.module';
import { PinoLogger } from 'nestjs-pino';

async function bootstrap() {
  const app = await NestFactory.create(AppModule);
  app.useLogger(app.get(PinoLogger)); // error here
  await app.listen(3000);
}
bootstrap();

If I comment the logger setup line it works and loads the /health module correctly

I also tried to load the LoggerModule directly in the app without going through the library, which works, but the logs that are inside the library are executed with the nest logger and not with pino

I added MyLogger in the library and I am loading it with NestFactory.create(AppModule, { logger: new MyLogger() });, it loads it only in the MyApp files but not in the library files, from what I see it is something of nestjs then or the way I'm adding the library

I did a quick test by uploading the library to npm and adding it to myapp from npm and it works fine, apparently it's something in the way I install it locally for development, thank you very much anyway, I'm closing the issue.

@fneiraj are you using pnpm? I'm having a similar issue and can't figure out why...
I created a new app using the CLI in monorepo mode. pnpm as the installer and following the basic examples I get the following message:
Nest could not find Logger element (this provider does not exist in the current context)


How to load  labeled data?

I have a very large labelled dataset. How do I check the performance of my model on this dataset?

See the various tutorials- Spouses, CDR, and the BRAT tutorial- for some examples of how to load gold data!


Fixed issue 588 with space between # and include preprocessor directive

Fix the regex in extract_from_file function to proper parse
'# include' preprocessor directive.
The problem was mentioned under:
https://github.com/ThrowTheSwitch/Ceedling/issues/588

Hi @mvandervoord ,
If you will have time,  look at my solution proposal, for an issue described in #588 ?
Kind Regards,
Lucas

Thanks, @lukzeg -- it looks perfect to me!


[Improvement] Add Project URL to success deployment notification

Would it be possible to include the Project URL to the successful deployment notification?
Maybe just Slack or HipChat since you may not want to include/show too much for others.

Hmm, the "project" field in the hipchat attribute should already link https://github.com/REBELinBLUE/deployer/blob/master/app/Notifications/Configurable/DeploymentFinished.php#L204-L205 as should the "project" field in the slack attachment https://github.com/REBELinBLUE/deployer/blob/master/app/Notifications/Configurable/DeploymentFinished.php#L109-L113

Sorry, I meant the domain URL you enter when creating/editing the project!

Ah! That makes sense!

Working on it in feature/337 but having problems with hip chat


Add continuous integration on macOS and Ubuntu Linux with Travis CI

Description
Adds continuous integration on macOS and Ubuntu Linux with Travis CI (free SaaS CI for open source like AppVeyor).  Here is my blog post on the subject: https://troylindsayblog.wordpress.com/2017/11/25/powershell-core-on-travis-ci/.  To start using this, @chriswahl will need to:

Sign up with your GitHub account on Travis CI and then authorize builds for the PowerShell-Module repo
Download the Travis Client so that you can encrypt your Slack channel token and update the ./.travis.yml config file to post your build updates (reference: https://docs.travis-ci.com/user/notifications/#Configuring-slack-notifications).
Add Travis CI status checks to your master branch protection

This set of changes also:

Limits publishing the Rubrik module to the PowerShell Gallery and the documentation updates to GitHub to only AppVeyor since this only needs to be performed once
Removes the note from the documentation that the project is not tested for PowerShell Core compatibility
Limits installation of chocolatey to only AppVeyor since it isn't needed on Linux or macOS.
Adds a build badge to README.md that will show up once the Travis CI account is ready

Related Issue
This project only accepts pull requests related to open issues.

If suggesting a new feature or change, please discuss it in an issue first.
If fixing a bug, there should be an issue describing it with steps to reproduce

#143
Motivation and Context
Why is this change required? What problem does it solve?
It adds build testing on additional operating systems.
How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc.

Enabled AppVeyor & Travis CI on my fork.
Screenshots (if appropriate):

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

We are currently re-evaluating our CI/CD pipeline and looking at how we can best implement the changes you proposed and many other changes. As a result of this we will unfortunately not be able to implement the PR you proposed.
Going forward we will be providing feedback in a more timely fashion. Thanks for your contribution @tlindsay42!


Enable multi threads to run iperf with PerfKitBenchmarker

When I follow the guide to run iperf with PerfKitBenchmarker, It only use 1 thread by default, how can I set multi threads ?
./PerfKitBenchmarker/pkb.py --project=xxxxxxxxx --machine_type=n2-standard-64 --benchmarks=iperf  --zone=us-central1-a --os_type=centos8

Have you tried setting the iperf_sending_thread_count flag? The other flags you can set are iperf_runtime_in_seconds, iperf_timeout, iperf_udp_per_stream_bandwidth, iperf_tcp_per_stream_bandwidth and iperf_benchmarks. See iperf_benchmark.py in the linux_benchmarks directory.

Have you tried setting the iperf_sending_thread_count flag? The other flags you can set are iperf_runtime_in_seconds, iperf_timeout, iperf_udp_per_stream_bandwidth, iperf_tcp_per_stream_bandwidth and iperf_benchmarks. See iperf_benchmark.py in the perfkitbenchmarker/linux_benchmarks directory.

Thanks for your help.


Create an Ubuntu/Debian PPA/repo

While it's very easy to get started playing around with vnext in Windows, if you're looking for feedback from other platforms, it really should be easier to install.  Not just for the sake of testing, but to also demonstrate a commitment to making vnext available for all non-Microsoft platforms.
To accomplish this, I think you should set up a PPA for the k runtime so that all of it's system-level dependencies in linux can be satisfied with considerably less effort from curious end users (would be adopters!).
It might just be a matter of creating a package that also adds (or suggests) the repository found here: http://www.mono-project.com/download/#download-lin -- and then installs KVM/KRE.
A significant number of linux users rely on this mechnism to obtain software and have come to expect it from reputable projects.  While vnext is still under development, I think it's important that this distribution mechanism be established while it's still early days.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Made home button in the nav bar responsive

PR Description 📜
Made home button in the nav bar responsive
Fixes #376

Mark the task you have completed ✅

[x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x ] I have performed a self-review of my own code or work.
[x ] I have commented my code, particularly in hard-to-understand areas.
[ x] My changes generates no new warnings.
[x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

@ayush-t02  please review the pull request soon so that i can work with the other pull request in your repo

there is a conflict with index.html, please look into it

also, do not make a PR until the issue is assigned to you.

@ayush-t02 i have made the chagnes please look into it

Add a demo video

Add a demo video

yes

https://github.com/ChromeGaming/Dot-Box/assets/143107589/fa7a24bc-9484-414f-b368-d81c0920e269

what video is this? what have you changed in the website?  add a demo of that

what video is this? what have you changed in the website? add a demo of that

Yes

what video is this? what have you changed in the website? add a demo of that

Yes sorry It was by mistake

https://github.com/ChromeGaming/Dot-Box/assets/143107589/c27c7061-1778-42a4-9833-2726089b0e97
Previously when we press home button its not starting from first so i made the change for that

@ayush-t02 Now You can see the video

I will merge this PR as an exception but do not create a PR till the issue has been assigned to you, assignment takes time. Moreover, dont create PR just for the sake of points as this PR is almost insignificant.


feat: allow special characters (like &, -, −, etc.)

App name can consists of many characters that don't fit into \p{Letter} regexp. For example, the app I currently working on contains &. Like m&ms. Also different type of hyphens are also popular.

clearAppName clears the name from any non-alphanumeric characters for usage in paths and as identifiers.
escapeEntities escapes &<> in names for usage in XML files
isValidAppStoreName is a draft for checking if an app name fits into AppStore rules
--force option to ignore AppStore rules (I find it useful if targeting only GooglePlay)
package.json name converted toLowerCase since only lowercased package names are valid

Yeah... seems like prettier reformatted some lines I didn't touch. 😅

Thanks @ElForastero , just released v3, includes some of your changes.


"_isMounted" is not on latest release (0.2.1)

I came across the same bug that was reported on this issue: https://github.com/leozdgao/react-async-script-loader/issues/7
however, I am not seeing the changes that fix that issue on the release installed on my project (which is 0.2.1 according to its own package.json). If I browse to my_project_dir/node_modules/react-async-script-loader/lib/index.js and search for isMounted string, it finds nothing. I look at the code for the ScriptLoader componentDidMount function and effectively there is no isMounted handling.
Can you confirm this? Is there anything I can do to help you get this released ASAP?
Keep up the good work :)

@andresmatasuarez 0.2.2 Released.

thanks!

Maybe close the issue if it's closed?


support query params syntax for gatsby's IMAGE_CDN

very rough support for newer url syntax of gatsby's IMAGE_CDN ( https://github.com/netlify/pod-ecosystem-frameworks/issues/389 ). New syntax is using query params and this PR in current form is meant to test wether ODB query params stripping and caching will cause problems with the new syntax

Closing this PR, it served it's purpose (produced some Deploy Previews confirming query params problem). Will attempt workaround the problem with redirects ( https://github.com/netlify/pod-ecosystem-frameworks/issues/389#issuecomment-1439887645 )


Max integer used in implementation is incorrect

var MAXINT = Math.pow( 2, 31 ) - 1;

The integer used in the implementation is the max safe FLOAT64 integer.

This was addressed in https://github.com/compute-io/gcd/commit/e475160f77f00e4b6cdc319d2b09296f4480839a.


Set upper and lower limits on the inferred fundamental params

In isochrone.py line 218, the symmetric uncertainty can imply that the object might have a negative mass or is older than the age of the universe. Set ceiling and floor on the isochrone inferences.

Was this fixed by #91?


[FEATURE] Discord Server

I was thinking about a Discord server related to this language for people to discuss things in, I think it would be easier to talk about Nyson's code and syntax in a Discord server then GitHub Discussions. And if you do make a Discord make the link not expire, Thanks.

So we made one I will update it on the docs and on here but the link right now is https://discord.gg/qDznKHuM


Error: 'getPluginsPath' can have side effects [Nim v1.2.0]

Building with Nim version 1.2.0 fails. I think we need to roll back func getPluginPath to a proc due to the strict side effects check. @juancarlospaco, can you take a quick test spin?
Fail
/home/cxwiki/nimwcpkg/nimwc_main.nim(21, 35) Warning: WebP is disabled, no image optimizations possible. [User]
/home/cxwiki/nimwcpkg/nimwc_main.nim(24, 39) Warning: Firejail is disabled, running unsecure. [User]
/home/cxwiki/nimwcpkg/nimwc_main.nim(39, 6) Error: 'getPluginsPath' can have side effects

Code
https://github.com/ThomasTJdev/nim_websitecreator/blob/d22fc86aa934ee3286b8fa5c4c046f3c90fc4bbe/nimwcpkg/nimwc_main.nim#L39-L66

I agree, you are right.


New release process: Automate test & release on github

github related commands

[x] Create tag
[x] Draft release
[x] Upload artifact into the release

release process command

Release mock up:

Create tag

./tbx services github tag create -owner watermint \
                                 -repository toolbox \
                                 -sha-1 $(./tbx version -output json | jq -r 'select(.key == "app.hash") | .version') \
                                 -tag   $(./tbx version -output json | jq -r 'select(.key == "app.version") | .version') \
                                 -message "Release test"

Create release draft

./tbx services github release draft -owner watermint -repository toolbox -tag $(./tbx version -output json | jq -r 'select(.key == "app.name") | .version') -name "Release test" -body-file release_notes.txt

The release, https://github.com/watermint/toolbox/releases/tag/64.4.220 , was successfully published through this command


[ergoCubSN000] Enable the streaming of the IMU mounted on the Strain2

This PR:

Introduces enable the IMU in the FTs currently available in the robot
Clean the outdated inertials config files
Fix the name of the camera joint to be compliant with the urdf model cam_tilt-> camera_tilt

@lrapetti @mebbaid if you agree we can merge it and then open a PR towards robotology/robots-configuration/devel


On Execution of vscode.executeInlayHintProvider comamnd, hints are not getting added/shown in the document

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.83.0
OS Version: Windows 11

Steps to Reproduce:
On Execution of vscode.executeInlayHintProvider comamnd, hints are not getting added/shown in the document. Please note, hints are getting added/shown, when we type any character in the editor.
I need to execute vscode.executeInlayHintProvider built-in command, on some context menu in the editor. (as
I am facing two issues on executing vscode.executeInlayHintProvider comamnd:-

hints are not getting added/shown in the editor even though my custom hint provider (HintsProvider, as shown below) which implements vscode.InlayHintsProvider  is getting called.
my custom hint provider (HintsProvider, as shown below) is getting called on typing in the document. I want this is to be invoked only on execution of command - vscode.executeInlayHintProvider. (this built in command i am executing from onGeneratEvent  as shown below)

Following is the code snippet of custom hint provider :-
export class HintsProvider implements vscode.InlayHintsProvider {
onDidChangeInlayHints?: vscode.Event;
static counter: number = 90;
provideInlayHints(document: vscode.TextDocument, range: vscode.Range, token: vscode.CancellationToken): vscode.ProviderResult<vscode.InlayHint[]> {
var provider = new HintsProvider();
return new Promise<vscode.InlayHint[]> ((resolve,reject) =>{
let ret: Array<vscode.InlayHint> = new Array();
HintsProvider.counter++;
let tempList: Array<vscode.InlayHintLabelPart> = new Array();
let temp: vscode.InlayHintLabelPart = new vscode.InlayHintLabelPart(labelHint${HintsProvider.counter});
temp.tooltip = "hint tooltip";
tempList.push(temp);
let start = range && range.start ? range.start : new vscode.Position(1, 0);
let retValue: vscode.InlayHint = new vscode.InlayHint(start, tempList, vscode.InlayHintKind.Parameter);
let textRange = (range && range.start && range.end) ? range : new vscode.Range(new vscode.Position(1, 1), new vscode.Position(5, 10));
let edit: vscode.TextEdit = new vscode.TextEdit(textRange, "hint text to be inserted");
retValue.textEdits = new Array();
retValue.textEdits.push(edit);
ret.push(retValue);
resolve(ret);
});
}
resolveInlayHint?(hint: vscode.InlayHint, token: vscode.CancellationToken): vscode.ProviderResult<vscode.InlayHint> {
    return new Promise<vscode.InlayHint>((resolve, reject) => {
        resolve(hint);
    })
}

//Following is the code snippet of some function , where i execute command - vscode.executeInlayHintProvider.
private onGeneratEvent = async (event:GenerateNLtoSQLErrorEventParams):Promise =>{
var pos = new vscode.Position(10, 0);
var endPos = new vscode.Position(12, 0);
let range:vscode.Range = new vscode.Range(pos,endPos);
vscode.window.showErrorMessage(event.message);
return vscode.commands.executeCommand("vscode.executeInlayHintProvider",vscode.Uri.parse(event.ownerUri),range).then ( (temp1) =>{
let ret = new Array();
let list = new Array();
let hintLabelPart = new vscode.InlayHintLabelPart(hint1);
hintLabelPart.tooltip = "hint tooltip";
list.push(hintLabelPart);
let inlayHint = new vscode.InlayHint(new vscode.Position(1, 0), list, vscode.InlayHintKind.Parameter);
let edit = new vscode.TextEdit(new vscode.Range(new vscode.Position(1, 1), new vscode.Position(5, 10)), "textTobeInserted");
inlayHint.textEdits = new Array();
inlayHint.textEdits.push(edit);
return inlayHint;
});
}

On Execution of vscode.executeInlayHintProvider comamnd, hints are not getting added/shown in the document.

It's not meant to do that. These commands are to retrieve data but they aren't doing anything in the UI


tests: does the GitHub CI run tests that require a -tags argument?

          But are we sure that the CI is running the added test? How does it know that it needs to add a `-tag` parameter?

Originally posted by @cason in https://github.com/cometbft/cometbft/issues/4104#issuecomment-2361365620
I don't think so. So all tests of packages with files starting with something like:
//go:build bls12381

or any other tag are not executed when we have a PR.

Fortunately, we have few relevant packages that use tags:
$ grep '//go:build' . -R
./crypto/bls12381/key_bls12381.go://go:build bls12381
./crypto/bls12381/key_test.go://go:build bls12381
./crypto/bls12381/key.go://go:build !bls12381
./types/time/now.go://go:build !clock_skew
./types/time/now_skew.go://go:build clock_skew
./test/fuzz/tests/rpc_jsonrpc_server_test.go://go:build gofuzz || go1.20
./test/fuzz/tests/mempool_test.go://go:build gofuzz || go1.20
./test/fuzz/tests/p2p_secretconnection_test.go://go:build gofuzz || go1.20
./test/e2e/generator/generate_test.go://go:build bls12381
./internal/consensus/wal_fuzz.go://go:build gofuzz
./libs/sync/deadlock.go://go:build deadlock
./libs/sync/sync.go://go:build !deadlock
./rpc/jsonrpc/client/integration_test.go://go:build release

@cason - the database backends use tags


Dem insertion list velocity, omega and diameters

Description of the problem

The list insertion method was only allowing the insertion of static particles. Now, every particle can be inserted with a specific transnational and rotational velocity. The diameter of every particles can also be specify.

Description of the solution

7 new parameters.
A new assign_particle_properties_for_list_insertion function has been created.

How Has This Been Tested?

Test will be added if requested.
The bouncing particle was use to test the different parameters, with success.

Documentation

Insertion section.

@voferreira can you also review this? You know this part well

@voferreira can you also review this? You know this part well

@blaisb Sure thing!

@OGaboriault from my perspective this is ready for a merge, just confirm it is and I will merge it

@OGaboriault from my perspective this is ready for a merge, just confirm it is and I will merge it

From mine too 😀

Can be merge after the CI checks.
I have just remove the Assert that check the size of the position lists since they are always resize to the maximum size in the parsing function.


FEATURE: Adding Guest List to Event

Feature Goal
A Guest List could be added during the creation of an Event or after an Event is created.
Guest Model
A Guest List is a list of the model Guest:
{
  "invitationID": "<number>",
  "fullname": "<full name>",
  "email": "<email>",
  "isUnderage": "<0 or 1>",
  "isUnder12": "<0 or 1>",
  "inWeddingParty": "<0 or 1>",
  "weddingPartyPosition": "<one of [0, 1, 2, 3, 4]>",
  "rsvpStatus": "<0 or 1>",
  "rsvpMeal": "meal option"
}

Guest Model Explanation:

invitationID: number assigned to guests to be on the same invitation. (Required)
fullname: How guest is to be addressed on rspv invitation. (Required)
email: required to send RSVP invitation, each invitation requires only 1 guest to provide and email
isUnderage: 0 (default)->above 21, 1->below 21
isUnder12: 0 (default)-> above 12, 1-> below 12
inWeddingParty: 0 (default)->only a guest, 1-> is part of wedding party
weddingPartyPosition:

0 (default) ->only if 'inWeddingParty' is also 0
1->Maid of Honour
2->Best Man
3->Bridesmaid
4->Junior Bridesmaid
5->Ring Bearer
6->Flower Girl
7->Parent

rsvpStatus: 0->not attending, 1->attending, none->No response
rsvpMeal: text of meal option selected if added to the event

Request Format
This Request should be done via an HTTP POST request, with the body as follows:
{
  "eventID": "1",
  "guestList": [
        {
            "invitationID": "1",
            "fullname": "Guest 1",
            "email"<EMAIL_ADDRESS>            "isUnderage": 0,
            "isUnder12": 0,
            "inWeddingParty": 0,
            "weddingPartyPosition": 0,
            "rsvpStatus": "",
            "rsvpMeal": "",
        },
        {
            "invitationID": "1",
            "fullname": "Guest 2",
            "email": "",
            "isUnderage": 0,
            "isUnder12": 0,
            "inWeddingParty": 0,
            "weddingPartyPosition": 0,
            "rsvpStatus": "",
            "rsvpMeal": "",
        },
        {
            "invitationID": "1",
            "fullname": "Guest 3",
            "email": "",
            "isUnderage": 1,
            "isUnder12": 1,
            "inWeddingParty": 1,
            "weddingPartyPosition": 4,
            "rsvpStatus": "",
            "rsvpMeal": "",
        },
        {
            "invitationID": "2",
            "fullname": "Guest 4",
            "email"<EMAIL_ADDRESS>            "isUnderage": 0,
            "isUnder12": 0,
            "inWeddingParty": 1,
            "weddingPartyPosition": 1,
            "rsvpStatus": "",
            "rsvpMeal": "",
        },
        {
            "invitationID": "3",
            "fullname": "Guest 5",
            "email"<EMAIL_ADDRESS>            "isUnderage": 0,
            "isUnder12": 0,
            "inWeddingParty": 1,
            "weddingPartyPosition": 2,
            "rsvpStatus": "",
            "rsvpMeal": "",
        },
    ]
}

incorrect format


Server HTTP523

The server has experienced a power cut and we are working to restore services.

The server has experienced a power cut and we are working to restore services.

The server did not automatically restart after the power cut, which is causing the extended outage. We have seen that other processes running in the same location such as the Minecraft Server have restarted, thus leading us to believe the lack of autostart is the issue. We will be working to rectify the issue.

Expected Revival Time: 10:00 am Friday, Greenwich Mean Time.

The website is back! We apologise for the delay in getting us back up. Enjoy browsing!


Consider migrating optimization for GetObjectNamesForType from Spring.Web.Mvc into Spring.Core

The optimization strategy implemented in https://github.com/spring-projects/spring-net/commit/01d4db4e51903e65dd7926a6a5e6d48747f52366 could conceivably be moved into the core DI container so that all implementations could benefit from it.

I'm doing a rude experiment with closing this, like what stale bot does, but maybe more human as I will probably actually react to feedback. As this issue has been stale for so long, I'll close it. If it's still an issue you would like to pursue, we can definitely reopen.
With limited resources this is just something that we need to do. Thank you for your understanding.


Fail to compile with 2.8.0 from an Elixir project

Newly updated cowboy 2.8.0 fails to compile from an Elixir project with the error:
===> Compiling cowboy
Function: request_process/3
===> Compiling src/cowboy_stream_h.erl failed
src/cowboy_stream_h.erl:none: internal error in sys_core_dsetel;
crash reason: {case_clause,
    {'EXIT',
        {{case_clause,
             #{0 => 1,1 => 1,2 => 1,4 => 1,5 => 1,6 => 1,10 => 0,
               'Reason' => 1}},
         [{sys_core_dsetel,visit,2,[{file,"sys_core_dsetel.erl"},{line,98}]},
          {lists,mapfoldl,3,[{file,"lists.erl"},{line,1354}]},
          {lists,mapfoldl,3,[{file,"lists.erl"},{line,1355}]},
          {sys_core_dsetel,visit,2,[{file,"sys_core_dsetel.erl"},{line,188}]},
          {lists,mapfoldl,3,[{file,"lists.erl"},{line,1354}]},
          {lists,mapfoldl,3,[{file,"lists.erl"},{line,1355}]},
          {sys_core_dsetel,visit,2,[{file,"sys_core_dsetel.erl"},{line,188}]},
          {sys_core_dsetel,visit,2,
              [{file,"sys_core_dsetel.erl"},{line,144}]}]}}}

  in function  compile:'-select_passes/2-anonymous-2-'/3 (compile.erl, line 585)
  in call from compile:'-internal_comp/5-anonymous-1-'/3 (compile.erl, line 349)
  in call from compile:fold_comp/4 (compile.erl, line 376)
  in call from compile:internal_comp/5 (compile.erl, line 360)
  in call from compile:'-do_compile/2-anonymous-0-'/2 (compile.erl, line 177)
  in call from compile:'-do_compile/2-anonymous-1-'/1 (compile.erl, line 190)

The project from which I'm trying to compile is https://github.com/tanguilp/plugoid_demo

My bad, OTP22 is required (wax running on OTP21). Closing.


Fix missing task error on Rails 6.1

Problem
I encountered an error on my application with routes_lazy_routes 0.3.2 and rails <IP_ADDRESS>.

Don't know how to build task 'routes' (See the list of available tasks with rails --tasks)

This is probably due to the removal of  routes rake task at rails 6.1 (https://github.com/rails/rails/commit/e152f83c64596e3c701d1b34175ae0fa8669c983).
Changes
Add if Rake::Task.task_defined?('routes') before calling Rake::Task['routes'].enhance.

@r7kamura Thank you!!


TINKERPOP3-917: Add HadoopGraph.open(String)

https://issues.apache.org/jira/browse/TINKERPOP3-917
Damn simple 3 lines of code addition.
VOTE: +1

VOTE: +1 - easy enough

VOTE: +1


Handle deadlocks in laravel 4.2

Laravel Version: 4.2.22
PHP Version: 5.6
Database Driver & Version: Mariadb galera cluster

Description:
I have run into an scenario where a PDO exception is thrown PDOException: SQLSTATE[HY000]: General error: 1180 Got error 35 "Resource deadlock avoided" during COMMIT
it looks like this has been addressed in laravel 5.1 (https://github.com/laravel/framework/pull/12814/files) however one of my projects is stuck on 4.2 . Is there a fix that I could implement  for this in 4.2 ?  I noticed in 4.2 the retry logic only checks for one string(https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Connection.php#L670)
I have attempted to extend the Connection class using this tutorial http://blog.stidges.com/post/extending-the-connection-class-in-laravel. However whenever the reconnect function is run the new Database connection object that is returned has a null value for the PDO object which causing all further queries to fail. Any idea what could be going on here?
or is there any way these extra strings could be backfilled into 4.2?

Sorry, laravel 4.2 is not supported anymore.


VSCode intercept the ESC key even if it has been rebound with standard X tools

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:55:56.395Z)
OS Version: Linux x64 4.10.9-1-ARCH
Extensions:

Extension
Author
Version

cpptools
ms-vscode
0.10.5

cmake
twxs
0.0.17

cmake-tools
vector-of-bool
0.9.4

vim
vscodevim
0.6.15

Steps to Reproduce:

swap the esc key and capslock key with xmodmap (config file below)

remove Lock = Caps_Lock
keysym Escape = Caps_Lock
keysym Caps_Lock = Escape
add Lock = Caps_Lock

VScode still think the ESC key is the ESC, but corrently intercept caps-lock as ESC key. Making me switch modes with the vim emulation when I'm just toogleling capslock.

I can reproduce/have the same problem. I don't know of any other application that has this effect (even discord, another electron app, works fine).
VSCode version 1.11.2
4.10.9-1-ARCH
I have the vim plugin too but it still happens with it disabled.

Yes, a lot of vim enthusiast swap the ESC and CapsLock (or just make Caps an ESC key). It's how the terminal where Vi was codded had it's layout, and it makes switching mode easier.
Now, for me having Caps an ESC key is muscle-memory, and it's really annoying to have to swap them around back to be able to use VSCode with the Vim plugin.
So, apparently, VSCode does something funny whith how it handle the keyboard, and it shouldn't ^^"

This option also occus if the esc and caps lock keys are swapped using the "gnome-tweak-tool' program.
I can also confirm that the bug is present with 1.11.2

Let's track in #23991


[test-framework] Rationalize and implement GetFortioApp(s) methods.

We have two different overloads, one referencing FortioApps by name, the other one by selectors. We should rationalize this.
Presumably, Fortio Apps will be deployed once and test-framework can hard-write any selectors as necessary: We do not need to expose this to the test authors.
This includes:

[ ]  Deciding on the API shape that is needed.
[ ]  Doing the implementation for the cluster environment.
[ ]  Doing the implementation for the local environment.

@nmittler could you take a look at this when you have time?

I have interest in this. But I'm lack of the background knowledge.
Seems we haven't make use of the Fortio Apps in existing tests for now?
So the task would be deciding how we make use of it, and add test cases accordingly?


[MM-10511] Fix missing users' status indicators on more DM modal

Summary
Fix missing users' status indicators on more DM modal
Ticket Link
Jira ticket: MM-10511
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

@saturninoabril probably you may want to change the base branch to release-5.0 before the merge

Right, done changing base branch to release-5.0

merging to the release branch


[Enhancement]: Making the Page No. Buttons take the user to the top on clicking

Is your enhancement request related to a problem? Please describe.➕
Enhancement:
I would like to make the page number buttons take the user back to the top on clicking so that the user can see all the games present.
Describe the solution you'd like
Solution steps

Edit Javascript/HTML File

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

/assign

Hey @5h0ov !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @5h0ov ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Unable to download content after VSCode update

It seems like a recent VSCode update broke the content downloader of Vua

I'm running on VSCode 1.66.1

This issue is related to https://github.com/microsoft/vscode/issues/147807. I don't know why Microsoft recommended using this extension if it was unmaintained. I'll write a downloader class for this. Thanks for the find.

Should be fixed in fd6b929. Please re-open if the issue persists.
v0.3.3 will contain the fix for this, it has been pushed to the marketplace.

Works, sorry couldn't check before, thanks for the quick fix


xochitl's screen lock can be bypassed

Describe the bug
On v2.0-beta, with the new suspend mechanism it is possible to bypass xochitl's screen lock.
To Reproduce
Launch xochitl from the oxide menu, then unlock and press the power button to suspend. Then press the power button again, you'll find that you're back in xochitl without being locked.
Expected behavior
xochitl should lock
Version Information:

Device: remarkable 1
OS: <IP_ADDRESS>
Version v2.0-beta

I've replicated this on my device running <IP_ADDRESS>. That said, it's not as bad as you think I'm unable to interact with xochitl other than pressing where the unlock buttons would have been. It might actually be a bug with xochtil itself? Can you confirm the behavior I'm seeing @siraben?
Ideally #15 will make this even less of a concern.

Oh, I missed the step of unlocking before suspending. So this is still a concern. I'm not really sure how to trigger xochitl's suspend logic. @ddvk do you have any idea if I can inform xochtil to "lock" itself?

@Eeems agreed, #15 could be implemented to make this a non-issue. Since I think xochitl being locked doesn't make a difference to the files (not encrypted as a result of locking), it's just as secure to implement a passcode UI again.
If that is implemented, exposing an API to it would be useful for custom lockscreens as well.

@Eeems agreed, #15 could be implemented to make this a non-issue. Since I think xochitl being locked doesn't make a difference to the files (not encrypted as a result of locking), it's just as secure to implement a passcode UI again.

Sounds good.

If that is implemented, exposing an API to it would be useful for custom lockscreens as well.

You should put in an enhancement request for that ;)

Fixed by #15

Fixed by #15


Invalid transction link fix

Fixes # 1033
Changes proposed in this PR:

get subgraph nftUpdates query fix

We can also update the text based on the type of update

we can ignore Vercel, just had to switch it to Gatbsy to get a v3 deployment out, and now set it back to Next.js builds.


Suggestions

Add a log file where I can see the IDs and usernames of people who have been banned.
Add custom status feature for bot :)
Add basic commands to see if a person is in the banned database and a /ping command would be great!

Added a ping command in f176b0a59914f9ba5e0b84c73d012d1e18ca7b5c and some more useful logs (to the console)


Fedora Sericea looking to rebase to Fedora 39 in Sericea

Looking for a Fedora 39 version of Sericea, currently the sericea-main -A base Universal Blue sericea image with batteries included is 38. Noticed there is a sericea-nokmods, a base Universal Blue sericea image with no extra kmod or kernel packages that has 38 latest and 39 versions. Do I need to rebase to sericea-nokmods to get to 39?

I wouldn't suggest use of the nokmods images as we are planning to remove them ( see #369 ).
Within a few days I expect our sericea-main:39 to be published which will also have no kmods

Thanks for the info:-)

You should be able to rebase to sericea-main:39 as it's being published already, but the website doesn't seem to show it yet. :+1:
https://github.com/ublue-os/main/pkgs/container/sericea-main/132708635?tag=39

Thank you for your email greatly appreciated:-)
On Sat, Sep 30, 2023 at 12:45 PM bobslept @.***> wrote:

You should be able to rebase to sericea-main:39 as it's being published
already, but the website doesn't seem to show it yet. 👍
https://github.com/ublue-os/main/pkgs/container/sericea-main/132708635?tag=39
—
Reply to this email directly, view it on GitHub
https://github.com/ublue-os/main/issues/370#issuecomment-1741586363, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A3QR2BDSQVXUE4SY65V262TX45MQLANCNFSM6AAAAAA5KJ27HM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Regards
Robbie McGougan
Mob -<PHONE_NUMBER>

I think your question is addressed. Feel free to open if it wasn't, or open a new issue for new questions.

Awesome, thanks for the update!
On Fri, Oct 6, 2023 at 2:26 PM Benjamin Sherman @.***>
wrote:

Closed #370 https://github.com/ublue-os/main/issues/370 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/ublue-os/main/issues/370#event-10569901751, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A3QR2BD43OUHZXQ6FW5NNKTX55M2XAVCNFSM6AAAAAA5KJ27HOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU3DSOJQGE3TKMI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Regards
Robbie McGougan
Mob -<PHONE_NUMBER>


[v9] Fix broken build on CUDA 9.2

type member has been added in CUDA 10.0. Have to use memoryType for CUDA 9.2 (or earlier or HIP).

pfnCI, test this please.

pfnCI, test this please.

pfnCI, test this please.

Jenkins CI test (for commit da65de174afe7ff6fcd6ae0931a15f02badd9f3a, target branch v9) succeeded!

Thanks for catching it @kmaehashi. I forgot we still support CUDA 9.2 in v9...


Add Deterministic WebAssembly Runtime Build for Cere and Cere-Dev in GitHub CI

The primary goal of this task is to implement a deterministic build process for the WebAssembly runtime of both cere and cere-dev, using GitHub's Continuous Integration (CI) pipeline.
By deterministic build, we mean that multiple builds of the same source code will produce an identical output. Additionally, we aim to generate build artifacts during the CI pipeline execution for ease of access and reference.

We need to integrate srtool to build build and push action


Change VideoLAN.VLC version to match control panel.

[x ] Have you signed the Contributor License Agreement?
[ x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ x] Have you validated your manifest locally with winget validate --manifest <path>?
[ x] Have you tested your manifest locally with winget install --manifest <path>?
[ x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I downloaded v<IP_ADDRESS> from their website and installed it, but it appears their built-in Update Check functionality still detects it as latest without upgrading to v<IP_ADDRESS>; So, while winget users who upgrade regularly will have updated software, I would think that a majority of VLC users who are on the msi version are still vulnerable

I don't have a preference either way as to whether it gets changed or not, but I would say that the version is Technically <IP_ADDRESS> and not <IP_ADDRESS>, so for accuracy it may be best to leave the upgrade loop in place until a new stable version is released.

so for accuracy it may be best to leave the upgrade loop in place until a new stable version is released.

I think we are in agreement that leaving the update loop in place is best.

Since the EXE installer has the correct version, could we remove the MSI installer for this version? The next time someone tries to update, the EXE version would be installed and the correct version listed. Are there any other side effects to removing the MSI installer?

What are your thoughts on removing the MSI installer? Would that have unintended consequences? Or should we consider the issue WON'T FIX and wait for a new release?

Since the EXE installer has the correct version, could we remove the MSI installer for this version? The next time someone tries to update, the EXE version would be installed and the correct version listed. Are there any other side effects to removing the MSI installer?

This isn’t accurate. Winget will detect the install technologies are different and show an error that “the technologies are different, so users should uninstall and reinstall” (paraphrasing). The app would still show in upgrade since <IP_ADDRESS> is technically available - just as an EXE instead

What are your thoughts on removing the MSI installer? Would that have unintended consequences? Or should we consider the issue WON'T FIX and wait for a new release?

You’re just trading one error for another; At this point I think we should wait for ARP version range matching in the winget client (1.5 release?) or a new release of VLC

I have added a comment to the installer manifest about this issue. That should prevent someone else from trying to fix the issue again :)


[HOLD] Stop queuing non-retryable requests. Banish shouldRetry.

Details
Holding on:

[ ] https://github.com/Expensify/Expensify/issues/208280
[ ] https://github.com/Expensify/Expensify/issues/208185

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/208281
Tests

Go offline
Add a report comment (retryable)
Navigate to Profile page
Update First name (not yet retryable)
Verify that you are not able to do so and a log appears in the JS console (turn on Verbose)

Go online
Verify that the report comment is added

[ ] Verify that no errors appear in the JS console

PR Review Checklist

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
Same as Tests

[ ] Verify that no errors appear in the JS console

Screenshots
❌

Realizing that an interesting side effect of these changes will be that all things that are currently "retryable" and optimistic will not be optimistic anymore after. 🤔
We would be able to fix that by making those requests have a persist: true, but in the doc we decided this would be a gradual process. Report comments are the only thing that will work with this new system at the moment.
I think we will need to update any write requests in this PR and make sure they are retryable.

Gonna expand on this problem because on further reflection I don't think we can actually get rid of shouldRetry until all optimistic (but not persisted) actions are refactored over to the new API system being proposed in this thread.
We can still kill the "retry counter" logic though for things outside of the Sequential Queue.
Current behavior:

Write request (w/o persist: true) is made while we are offline
It goes into the main queue because we are offline and stays there because it’s “retryable” (actually all requests are retryable unless we specify that they are not)
Come back online and the main queue will process again (basically giving us the same “optimistic” behavior, but without the “persistance” that report comments have)

Gonna make those changes now so I can merge the good parts of this and wrap up the Network Improvements project as the retry logic is holding on the API changes.

Gonna expand on this problem because on further reflection I don't think we can actually get rid of shouldRetry until all optimistic (but not persisted) actions are refactored over to the new API system being proposed in this thread.
We can still kill the "retry counter" logic though for things outside of the Sequential Queue.
Current behavior:

Write request (w/o persist: true) is made while we are offline
It goes into the main queue because we are offline and stays there because it’s “retryable” (actually all requests are retryable unless we specify that they are not)
Come back online and the main queue will process again (basically giving us the same “optimistic” behavior, but without the “persistance” that report comments have)

Gonna make those changes now so I can merge the good parts of this and wrap up the Network Improvements project as the retry logic is holding on the API changes.

@roryabraham adding you here to have a second set of eyes and my rambling comments above might be interesting to you

Bump

What @roryabraham said + also want to quickly document that a consequence of this change is that some quasi-optimistic writes that kind of work offline will be broken by this change in a very minor way and only in the situation where we suddenly go offline or the site is down.
Offline features for these requests will still mostly work while you are offline. We just will stop handling that edge case for all commands (except Report_AddComment since it is in the SequentialQueue). Ultimately, we are going to rip this code out anyway and will be more explicit in the future about which things will be retried and which will not.
This will also free up @madmax330 to focus on the retry changes for the SequentialQueue without having to consider a system where both reads and writes could be retried on failure.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.1.68-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Please ignore these duplicated messages, we only deployed once but the message appears each the iOS deploy fails.

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Module build failed: Unrecognised input when requiring css in Angular JS

After update from 1.3.0 to 1.4.0, I am trying to require css from gentelella/build/css/custom.css in the Angular JS app and getting the following error:
Module build failed: Unrecognised input
...
near lines:
       background: linear-gradient(top, #f7f9fa 0%, #f0f0f0 100%);
       filter: progid: DXImageTransform.Microsoft.gradient( startColorstr='#f7f9fa', endColorstr='#f0f0f0', GradientType=0);
       -ms-box-shadow: 0 1px 2px rgba(0, 0, 0, 0.1) inset;
...

The solution is to quote the value in css as following:
filter: "progid: DXImageTransform.Microsoft.gradient( startColorstr='#f7f9fa', endColorstr='#f0f0f0', GradientType=0)";

Similar issue is discussed here: https://github.com/sass/sass/issues/467
I have no problem to create a Pull request with changes if you think this is a good solution.

let's PR :+1:

Created the PR: https://github.com/puikinsh/gentelella/pull/609

Thank you @okolafa for your contribution ! 👍

PR merged.


#129: Spelling and grammar updates

Minor edits that should not affect functionality to update spelling and grammar.
Signed-off-by: Brandon Forster<EMAIL_ADDRESS>

Whoops, sorry about the line endings. Stand by for update.

Closing, it's easier to do this with a new PR.


platformsh: 4.17.0 -> 5.0.13

Description of changes
Remove the deprecated legacy cli in favor of the new version.
Things done
This script is a copy of the Upsun CLI package which is released under the same repository.
I have modified the binary to use platform instead of upsun

Also is it not possible to be built from source now? I prefer to wait longer to see if there is a solution.

its still complicated build at the moment using docker buildx. If possible I think we should try to have platformsh cli updated because we are migrating new features there

Also why is @shyim removed from maintainers?

Also why is @shyim removed from maintainers?

Sorry, fixed this.

maybe commits can be squashed to platformsh: 4.17.0 -> 5.0.13

Okay

It doesn't build on Hydra now:
https://hydra.nixos.org/eval/1806362?filter=platformsh#tabs-now-fail

@trsteel88 are you fixing it? Otherwise I'll fix it

@trsteel88 are you fixing it? Otherwise I'll fix it

Was just looking at it and it is because the binary is called "platform" rather than "platformsh". I'm not sure what needs to be adjusted to fix this.
Is it line 42 and line 50?

I am creating a PR to fix it

@shyim thanks for sorting that. I am new to nix but wondering how updates get delivered. e.g. 5.0.14 has been released. Does someone have to come into this repository and update the version and hashes on https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/pl/platformsh/package.nix each time a new release comes out?
If that's correct it is very manual - is there a way to automate this?

There's a bot that can detect updates for some kinds of packages and open pull requests: https://github.com/NixOS/nixpkgs/pulls/r-ryantm

The better way would we if we provide a update script, so we can run it also locally 🤔

The bot uses those update scripts, too.

Look like the bot is using https://repology.org/project/platformsh/versions but since the package is not on any distributions (beside nixos) it fails to fetch the latest one?

Yes, repology is used, but if you provide an update script, it should be used instead AFAIK:
https://nix-community.github.io/nixpkgs-update/batch-updates/#batch-updates


No launch.json: cannot find a program to debug

Open a folder with no launch.json
Open a javscript file and hit F5 -> notice the error "cannot find a program to debug"

It is coming from here
This nicely works in stable.
Looking at the vscode side everything seems to behave as before thus assigning this first to you

@isidorn I cannot reproduce with Insiders

Can no longer reproduce as well. Sorry for the false alarm.
Will keep my eyes open in case it happens again


Month name under the dates

Hi, i want to show the month name under the dates. How can i get that?

This can be a bit difficult, but you can try to modify the draw method of JKCalendarView.


Add spells from Xanathar's Guide to Everything

This is one of several issues that should be opened to incorporate expanded offerings from XGE.

I don't believe that the spells from XGE have been released under the OGL. If not, this wouldn't be a legal addition.

You are correct.  Oh well, I'll keep working on it locally and just hold off on merging if/until it comes under OGL.

If that happens, this can be reopened.


Called by a number that didn't belong to us.

Describe the bug
Me and a friend landed on the modded planet affliction and as soon as we finished landing we got called by 2143, this was neither of our numbers, we were the only ones in the private lobby. When we accepted the call, static would play through at regular intervals and if we hung up it eventually call the other person. We could also call the number back and it would accept.
Reproducible Test
We have a theory that this might have been a loot bug but it's mentioned no where in the mod description. Later on a different planet, we found potential evidence for this after my friend died, their body was taken by a loot bug, and then I got called but by a different number than my friends number and I could hear the sound of a loot bug walking and chittering. The one counter to this is that on the previous planet, we were both alive and the first time we got called was just static.
Anything else?
No response

This should have indeed been a hoarding bug with a phone. It's a bit odd if it only played static though, they should be playing their chitter voice lines over the phone. I'll have to keep an eye out for that to fix.
I've added a hint to this being able to happen to the mod features, also you can change the chance of this happening in the config.

Lol it gave us a real spook when it first happened. Also I think the static was caused by the fact that the modded planet has some hoarding bugs that spawn outside as props and do nothing and it was raining during that run.


Is it possible to show a quoted or linked tweet?

I've tried show image 14 and show 14, but the former doesn't work for linked tweets, only linked images, and the latter does nothing.

I have the same question. Help would be appreciated...


NoReverseMatch error

When i create a mouser purchase order in inventree I get this error, but have no idea how to solve this.
'suppliercart' is not a registered namespace inside 'plugin'

Traceback (most recent call last):

File "/root/.local/lib/python3.11/site-packages/django/urls/base.py", line 71, in reverse
extra, resolver = resolver.namespace_dict[ns]
~~~~~~~~~~~~~~~~~~~~~~~^^^^

KeyError: 'suppliercart'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "/home/inventree/InvenTree/plugin/views.py", line 25, in get_plugin_panels
panels += plug.render_panels(self, self.request, ctx)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/home/inventree/InvenTree/plugin/base/integration/mixins.py", line 161, in render_panels
panel['content'] = render_template(self, content_template, ctx)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/home/inventree/InvenTree/plugin/helpers.py", line 243, in render_template
html = tmp.render(context)
^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/backends/django.py", line 61, in render
return self.template.render(context)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/base.py", line 175, in render
return self._render(context)
^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/base.py", line 167, in _render
return self.nodelist.render(context)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/base.py", line 1005, in render
return SafeString("".join([node.render_annotated(context) for node in self]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/base.py", line 1005, in <listcomp>
return SafeString("".join([node.render_annotated(context) for node in self]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/base.py", line 966, in render_annotated
return self.render(context)
^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/template/defaulttags.py", line 471, in render
url = reverse(view_name, args=args, kwargs=kwargs, current_app=current_app)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/root/.local/lib/python3.11/site-packages/django/urls/base.py", line 77, in reverse
raise NoReverseMatch(

django.urls.exceptions.NoReverseMatch: 'suppliercart' is not a registered namespace inside 'plugin'

This issue is solved, the mouser cart is working, but we have an issue with digikey now.
{"ErrorCode" : "invalid_request", "Error" :"Invalid redirection uri https://{url}/plugin/suppliercart/digikeytoken/"}
This probably happens because our inventree instance is not accessible from outside our organization? How can we solve this?

Hi,
Did you set the base URL in the InvenTree settings?

Hi, yes the base url is set in the InvenTree settings
The previous error was on our staging environment of inventree where we test new updates and plugins. Now I am trying on our production environment and I get the same error when I try to request a token

Update:
Now it works, but I get redirected to our inventree home page and the tokens are not set for Digikey

Update:
I made it work now, all default plugin settings were disabled

Good to hear that it works in your environment.

Just a question about part creation, is it possible to create parts with this plugin like kintree does?

No.
We create parts manually using some kind of review process. It is not done that often. So automation is not required in our case.
The plugin can create supplierparts for existing parts if you know the exact SKU of the supplier.

yes, the supplier part creation is very convenient
Thanks for the extra info.

@SergeoLacruz just after my last comment I am trying to add supplier parts from digikey but unfortunately this is not working properly. For mouser parts there is no problem, but i cannot add digikey supplierparts.

Is the token created and valid?
Does the Digikey shopping cart transfer work?
The logs show a green message each time the token is checked and a red one when the token is invalid.
Any error message in the message bar?

How can I check if the token is valid? It is created, so should be valid I guess.
Shopping cart transfer works.
No logs when trying to create supplier part.
No error messages either.

If the shopping cart transfer to Digikey works, the token is valid. You should see in the log
https://api.digikey.com:443 "POST /v1/oauth2/token HTTP/1.1" 200 273
Token refresh SUCCESS

The shows get_digikey_partdata has been called. You should further see
Remaining requests:

This telly you how many requests Digikey still allows you for the actual time period
The message header should be blue and show 200. This is the response status code. If the status code is not 200 the bar
is red and whows an error message e.g. Part not found at Digikey.

Hi @SergeoLacruz
I just tried again to add a supplier part, but now I get this error:

What can be done to fix this?

This is a message caused by Digikey.
Please supply the log for that request.
Where are you located? Which currency did you set?

And where exactly can I find these logs?
Today I got a different error code btw:

I am located in Belgium and the currency of inventree is set to Euro

The InvenTree server creates logs.
The second message is obvious, your Client ID is invalid.

It is weird that the Client ID is invalid since it does work to transfer the cart and create a token.
I asked my colleague for the logs

I tried to reproduce this again to generate new logs and this is what i get:

Try a page reload.

How can we fix the invalid Client ID problem?


deregister providers which are down using the monitoring system

we will go and manually fix our providers if they go offline, rather than de-registering them.