Changelog generator doesn't use commits from recipes that are within recipes

My setup:

cwp-recipe-kitchen-sink

cwp-installer (recipe)

cwp-recipe-cms

cwp-recipe-core

When I generate a changelog I get (for example):
[changelog] Generating changelog content for all releases in this plan
[changelog] Generating changelog for library cwp/cwp-installer (2.0.1 to 2.1.0-rc1)
[changelog] Found changes in 31 modules:
[changelog]  * cwp/cwp-installer from 2.0.1 to 2.1.0-rc1
[changelog]  * cwp/cwp-recipe-core from 2.0.1 to 2.1.0-rc1
[changelog]  * silverstripe/recipe-core from 1.1.1 to 4.2.0
[changelog]  * cwp/cwp-core from 2.0.1 to 2.1.0-rc1
[changelog]  * cwp/cwp-recipe-cms from 2.0.1 to 2.1.0-rc1
[changelog]  * silverstripe/recipe-cms from 1.1.1 to 4.2.0
[changelog]  * cwp/cwp from 2.0.1 to 2.1.0-rc1
[changelog]  * silverstripe/recipe-blog from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/blog from 3.1.0 to 3.2.0
[changelog]  * silverstripe/comments from 3.1.1 to 3.1.2
[changelog]  * silverstripe/recipe-form-building from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/userforms from 5.0.2 to 5.2.0
[changelog]  * silverstripe/recipe-authoring-tools from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/spellcheck from 2.0.2 to 2.1.0
[changelog]  * silverstripe/tagfield from 2.0.0 to 2.1.0
[changelog]  * silverstripe/taxonomy from 2.0.0 to 2.0.1
[changelog]  * silverstripe/recipe-collaboration from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/contentreview from 4.0.1 to 4.1.0
[changelog]  * symbiote/silverstripe-advancedworkflow from 5.0.6 to 5.0.7
[changelog]  * silverstripe/recipe-reporting-tools from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/securityreport from 2.0.0 to 2.0.1
[changelog]  * silverstripe/sitewidecontent-report from 3.0.1 to 3.0.2
[changelog]  * cwp/cwp-recipe-search from 2.0.1 to 2.1.0-rc1
[changelog]  * silverstripe/fulltextsearch from 3.2.0 to 3.3.0
[changelog]  * symbiote/silverstripe-queuedjobs from 4.1.1 to 4.2.2
[changelog]  * silverstripe/recipe-services from 1.0.0 to 1.1.0-rc1
[changelog]  * silverstripe/restfulserver from 2.0.3 to 2.1.0
[changelog]  * tractorcow/silverstripe-fluent from 4.0.2 to 4.1.3
[changelog]  * silverstripe/registry from 2.0.1 to 2.1.0
[changelog]  * cwp/starter-theme from 2.0.0 to 2.0.1

Note the line saying silverstripe/recipe-core from 1.1.1 to 4.2.0 - I'd expect this to include all changes in the recipe-core modules between 1.1.1 and 4.2.0 (1.2.0).
This doesn't include any commits from framework, CMS etc. It's looking at the silverstripe/recipe-cms though.

This could be #87 manifesting itself actually, since it's detecting the core releases as existing tags (which is true) - perhaps not picking up any changes between them.

Just another symptom of "git log is terrible for changelogs". All of these issues should be grouped together and addressed with a new changelog generator.

I think we can fix this somehow, in combination with #87

So this happens when recipes are marked as upgrade-only, e.g. silverstripe/recipe-core. If you remove that config from cwp/cwp-recipe-cms and cwp/cwp-recipe-core for example, they are included in the changelogs.

I've updated the description to add some more information around the expected result.


adversarial_training_FBF.py example Error.

Describe the bug
Runtime error occurred when running examples/adversarial_training_FBF.py.
Adversarial Training FBF - Epochs:   0%|          | 0/30 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "adversarial_training_FBF.py", line 219, in <module>
    trainer.fit_generator(art_datagen, nb_epochs=30)
  File "/opt/conda/lib/python3.8/site-packages/art/defences/trainer/adversarial_trainer_fbf_pytorch.py", line 181, in fit_generator
    _train_loss, _train_acc, _train_n = self._batch_process(x_batch, y_batch, l_r)
  File "/opt/conda/lib/python3.8/site-packages/art/defences/trainer/adversarial_trainer_fbf_pytorch.py", line 214, in _batch_process
    delta_grad = self._classifier.loss_gradient(x_batch + delta, y_batch)
  File "/opt/conda/lib/python3.8/site-packages/art/estimators/classification/pytorch.py", line 834, in loss_gradient
    y_preprocessed = self.reduce_labels(y_preprocessed)
  File "/opt/conda/lib/python3.8/site-packages/art/estimators/classification/pytorch.py", line 275, in reduce_labels
    is_one_hot = torch.equal(y.floor(), y.ceil())
RuntimeError: "floor_cuda" not implemented for 'Long'

The code causing the error was added here: https://github.com/Trusted-AI/adversarial-robustness-toolbox/commit/3f7899593238aa38522c21e77f1dcc76afa3ce0b
Import needed updated as well:
from art.classifiers import PyTorchClassifier
to
from art.estimators.classification import PyTorchClassifier
To Reproduce
Steps to reproduce the behavior:

Run examples/adversarial_training_FBF.py
See error

Expected behavior
Example to complete successfully.
System information (please complete the following information):

OS: Ubuntu 18.04.6 LTS
Python version 3.8
ART version 1.13.0
Pytorch

Hi @tylershumaker Thank you very much for opening this issue!  I have been able to reproduce the import. I'm still working on the RuntimeError. Which version of PyTorch are you using and are you running on GPU?

I have been able to reproduce this issue. we'll fix it with ART 1.13.1.
@tylershumaker Thank you very much for reporting this issue!


Fixing up tests to hopefully pass

@Minishlink This fingers crossed will be the end of testing woes for a bit.
Adds 4 retries per selenium test and updates testing service.

Thanks a lot!


Project page bugs resolved

I have fixed the minor bugs in the project page responsiveness.

this wasn't under JWOC, anyways thanks for merging.


Per Project option to make Flag Description a required field

It should be possible at the project level to define which attributes are required on a feature. Initially, this should only include the description field, but we should build this in such a way that other fields can be marked as required in the future.
Only Project Admins should be able to configure which fields are required in a given project.

@dabeeeenster tell this problem in detailed way.i am ready to work on this issue

Currently when you are creating a Feature Flag the Description is an optional field. See the screenshot.

If I understood @dabeeeenster correctly what we want is a feature flag that can make the description a required/mandatory field on the Project level so that you could have a Project where you always have to provide the description when creating a new feature flag.

Ok thanks @matthewelwell i will do this

@matthewelwell I would like to work on the issue, could you please assign it to me?

@akash19coder great, thanks! I've done that now.


[Editor] "Add Existing Project" button in the launcher

Is your feature request related to a problem? Please describe.
If there is an existing project in another folder except the default project path, one cannot add it. related to #144.
Describe the solution you'd like
Like Unity or any other engine launcher, an "Add project" button to make Prowl to monitor existing projects.

Implemented in development branch


remote_params

Can i know what is the type of return that this function should be ?
'remote_route' => 'tetranz_test_default_countryquery', ?
it should be a query ? or a list ?

It needs to return an array in json. It must have two elements call "id" and "text"
Here's an example controller action.
/**
 * @Route("/country.json", name="country_select")
 */
public function countrySelectAction(Request $request)
{
    $q = $request->get('q');
    $pageLimit = $request->get('page_limit');

    if (!is_numeric($pageLimit) || $pageLimit > 10) {
        $pageLimit = 10;
    }

    /** @var \Doctrine\ORM\EntityManager $em */
    $em = $this->getDoctrine()->getManager();

    $result = $em->createQuery(
        'SELECT c.id, c.name as text FROM AppBundle:Country c
        WHERE lower(c.name) LIKE :q
        ORDER BY c.name')
        ->setParameter('q', '%' . $q . '%')
        ->setMaxResults($pageLimit)
        ->getArrayResult();

    return new JsonResponse($result);
}

You can test that by pointing a browser to:
http://example.com/country.json?q=ne&page_limit=10
That will return countries with "ne" in the name.
I haven't touched this for a long time so last night I reinstalled it following my own instructions. Something that threw me is that there is a new version of Select2.  This bundle only works with version 3.5 from https://github.com/select2/select2/tree/stable/3.5. I will update the documentation.

Thanks for your answer, i hope your bundle becomes more used so that  we can benefit from it.


Tween property implicit type conversion

Addresses #53879
Issue is also about how to make such errors more visible. This just converts types.

This performs type conversion inside Tween::tween_property and PropertyTweener::from if necessary.
These are the same conversion that GdScript applies to typed function arguments and should be the least surprising.
Note: GdScript conversions are not that strict and allow bool -> float among others.
Also added a check if the property exists in the first place.
Conversion happens without DEBUG_ENABLED because Tween-internals rely on matching types.

tween_method() could get a type check/conversion too.

Superseded by #65072.


Ros2 launch generator fix

@ipa-rwu please review
I hope this PR solves #172 #171

Greate! It fixed!


fix(auctions): fix submitAuctionBid api to align with spec

:tada: This PR is included in version 2.4.0-alpha.3 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


use interface to extend test context

https://www.typescriptlang.org/docs/handbook/interfaces.html

I am thinking that it would be better if there was a more explicit item in test-context that can have its own class, instead of being an extension of the VitestContext (as the Vitest people suggest).
https://discord.com/channels/@me/960928001791512576/1119677503573864458

It would be in the beforeEach for the test.
        await addTestContext(context, CommunityTreasury, CCTHelpers);
    });

Restructuring it would make the setup syntax simpler.

For instance, any testing context would have actors.  Which actors?  Depends on the contract and how the developer wants to arrange them.

I think setup() is part of the test-helpers - so not necessarily used in every contract test
On the other hand, it's probably a useful part of the base-class and a good convention for any contract test.


Added action string for comments to log view

What is that used for? Can you add a test for it?

I don't think a test is needed for this.
It fixes a missing string on the log view page. You can see in the attached screenshot, that the review action for one add-on is missing.

I understand ;)
Regarding the test: could you please duplicate one of those and add it after here?

Sorry, I didn't know there are tests for this. I included one.

Excellent, thanks!
I'll merge when the build succeeds (which will be when I figure out why it just fails since today...)

Thanks @wagnerand !


Interaction with features

Hi there, starting a further discussion here.
I'd need to implement basic interaction with features. So in the non-dsl world I'd add a gesture recognizer to the mapview and then I'd usually run something like
// calculate the rect based on tap location
let features = mapView.visibleFeatures(in: rect, styleLayerIdentifiers: tappableLayers)
guard let feature = features.first else {
   selected(nil)
   return
}

// use the feature.attributes to match what I'm looking for
if let placeID = feature.attribute(forKey: "mapItemId") as? String {
  selected(placeID)
}

How are we planning to support interacting with features of the map?
SwiftUI has things like .onTapGesture for views. Is this the path for this dsl too? My first thought would be:
MapView()
  .onTapGesture(layers: ["layerID1", "layerID2"] { features in
    // visibleFeatures runs for [layerID1, layerID2], returning an optional array of visibleFeatures that were tapped
}

Interested in hearing your thoughts - I might be able to work on a PR for this.

Short answer, yes, that’s the general path that I was imagining. I believe it might be possible to improve the safety of the API though.
As you know, everything in MapLibre is “stringly” typed with respect to these sorts of layer references. What I’d like to explore is if we can move this to being a modifier on the layer or something that involves an actual layer reference so we don’t have to tie things together with strings.
I haven’t given this a ton of thought, so counter proposals are definitely welcome.
We should also have a look at MapKit’s latest API to see if we can borrow any ideas. (MapKit is quite a bit different of course so it might not be possible but worth a look. I seem to remember them doing a lot with adding individual features and making them interactive, which is honestly an easier model for most developers to reason about, so it would be great if we could also enable this eventually).

Yes, the non type-safe approach isn't exactly great. I usually at least create myself an emum of strings for layer names to mitigate the issue, but its not a perfect solution.
I hadn't considered attaching the tap gesture to the layer instead of the view. I do like the idea as it would take a lot of the filtering responsibility away from users and removes a number of mistakes developers could make. Two questions/difficulties arise though:

Under the hood i picture this code to be quite complex. For performance reasons we probably still just want to run  visibleFeatures once per tap, and not once per tap per layer. So we would have to maintain our own mapping on which closure is listening for which layer, and return the visible features to the correct closure - sometimes with multiple closures being triggered by one tap.
Some developers may want to make a layer tappable that they did not create themselves - one that is baked into the style.json file. In this case we would still need to provide a string based approach on the MapView level?

MapKit thinks less of gestures, and more in terms of selection. You get a binding of what the user selected. I like that too - it is obviously way more limited though in what you can do with it - at the same time it probably would cover what most devs want to do in a way simpler form. Apple also has a MapReader with a proxy for the more advanced tapping.
struct MarkerSelectionView: View {
    @State private var selectedTag: Int?

    var body: some View {
        Map(selection: $selectedTag) {
            Marker("Empire state building", coordinate: .empireStateBuilding)
                .tint(.orange)
                .tag(1)

            Annotation("Columbia University", coordinate: .columbiaUniversity) {
                ZStack {
                    RoundedRectangle(cornerRadius: 5)
                        .fill(selectedTag == 2 ? .red : .teal)
                    Text("Something")
                        .padding(5)
                }
            }
            .tag(2)
        }
    }
}

Closing this as implemented via #30


add RethinkDB as a plugin

I don't have a tests yet so feedback there would be great as well as any overall feedback.

I haven't used RethinkDB so I can't comment on if this is the right API or info to gather, I'll have to trust you there.
You'll need to manage that r.session properly though. If the session is expensive to setup, you can hold it across Gather calls, but you'll need to make sure it's still alive before using it.

@evanphx I added a defer to close the session after each Gather for now but if it looks to be an issue constantly opening/closing the session with each invocation, I'll adjust.

@evanphx I've updated this PR with some reorg of the plugin, added tests, and squashed + rebased from master.
Any additional feedback?


AWS EKS Addons

Has there been any Pulumi announcement or support for EKS Add-Ons?
https://aws.amazon.com/blogs/containers/introducing-amazon-eks-add-ons/
Pulumi did a brief blog post about it (https://www.pulumi.com/blog/reinvent-2020-eks-announcements/#simplified-install-and-management-for-kubernetes-cni-plugin), but didn't mention if/when Pulumi would add support for it.
The first supported addon sounds like it would make it easier (and possible) to do a full EKS version upgrade using Pulumi without having any manual steps.

These are available in https://www.pulumi.com/registry/packages/aws/api-docs/eks/addon/.


[ALLUXIO-2677] Fix logging style in ConfigurationUtils

https://alluxio.atlassian.net/browse/ALLUXIO-2677

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14415/
Test PASSed.


how to disable x clear icon when editing in NumberbBox

Describe the bug
winui3gallery://item/NumberBox
i do not need this X

Steps to reproduce the bug
No property to disable this
Expected behavior
we could be able to show or hide
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

Convince corporate Microsoft to invest more in WinUI so proposals like this show movement after two years:
https://github.com/microsoft/microsoft-ui-xaml/issues/3158
Or just copy and modify the style to do it yourself like I had to.

Is there any way to remove this X or we still do not have any updates regarding this?

@gabbybilka please

You can use the NumerBoxEx NuGet package that has these DependencyProperties. Check it out.

IsDeleteButtonVisible
NumberHorizontalAlignment

no


[Feature] Add pad name to page meta title.

Meta title is currently "musiqpad - join us!" for all pads.
I suggest to change it to "pad name | musiqpad".

For me it changes depending on pads - be it self-hosted or those using our FE

@Uricorn The page title gets set properly when the room information is loaded from the socket. I do believe that the default should be changed however that is another issue.
In regards to what this actually affects it is mostly search engines and social media sites. These should have been fixed based on the changes that we have made for: #57


Unable to install safeincloud cask

Here is the output. Seems that file is missing on the server.
11:44 $ brew cask install safeincloud --verbose
Warning: The default Caskroom location has moved to /usr/local/Caskroom.

Please migrate your Casks to the new location, or if you would like to keep your
Caskroom at /opt/homebrew-cask/Caskroom, add the following to your HOMEBREW_CASK_OPTS:

  --caskroom=/opt/homebrew-cask/Caskroom

For more details on each of those options, see https://github.com/caskroom/homebrew-cask/issues/21913.
==> Downloading https://www.safe-in-cloud.com/download/SafeInCloud.app.dmg
/usr/bin/curl -fLA Homebrew-cask v0.51+ (Ruby 2.0.0-648) https://www.safe-in-cloud.com/download/SafeInCloud.app.dmg -C 0 -o /Users/sinitsyn/Library/Caches/Homebrew/safeincloud-latest.dmg.incomplete
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (22) The requested URL returned error: 404 Not Found
Error: Download failed on Cask 'safeincloud' with message: Download failed: https://www.safe-in-cloud.com/download/SafeInCloud.app.dmg
The incomplete download is cached at /Users/sinitsyn/Library/Caches/Homebrew/safeincloud-latest.dmg
Error: Kernel.exit

https://github.com/caskroom/homebrew-cask/pull/22366


Escape should exit currently playing game

Hitting escape when running a game should exit the current game and go directly to the last tool. Hitting escape in a tool will do nothing since you can't exit a tool. In order to run a game, hit Ctrl + 1 which is the quick launch for playing a game.

This now works as described but still needs to be documented.


Windows port, (msys2, mingw)

We've landed the official Windows support, based on code from Chrome. Going to close this PR now. Sorry we couldn't get to it sooner!


Glue Catalog Sync Partitions

Is your feature request related to a problem? Please describe.
Updating partitions usually runs over all the partitions including the existing ones already in glue catalog (i.e. MSCK REPAIR TABLE) and wr.catalog.get_partitions which is fairly slow.
Describe the solution you'd like
wr.catalog.sync_partitions(database='...', table='...') that fetch the current partitions and update just the missing partitions.

Hi @luigift
I would like to suggest you two workarounds

Glue Crawler
Partition Projection

Glue Crawler
The crawler will add the partitions in your tables, you just need to choose the type of trigger
https://docs.aws.amazon.com/glue/latest/dg/about-triggers.html
Partition Projection
With Partition Projection you don't need to add partitions to glue table anymore
https://github.com/awslabs/aws-data-wrangler/blob/main/tutorials/017 - Partition Projection.ipynb
https://www.youtube.com/watch?v=iUD5pPpcyZk
https://docs.aws.amazon.com/athena/latest/ug/partition-projection.html


Add support for moshi-kotlin-codegen

We're currently generating code that relies on moshi-kotlin:
https://github.com/Yelp/swagger-gradle-codegen/blob/ed70186739e313de3a51e587d8b29b24da59b879/plugin/src/main/resources/kotlin/tools/GeneratedCodeConverters.kt.mustache#L10-L14
This has the side effect of pulling in the kotlin-reflect dependency that is a pretty big jar.
We should consider moving over to moshi-kotlin-codegen.
Ideally we just need to generate the @JsonClass annotation for our data classes and make sure we provide proper proguard rules for it.

Thanks for the investigation @filipemp
Let's keep it open for now and wait for moshi 1.9.
If you have a branch ready, please send it out as a Draft PR and we can already do a first-pass review


Error loading Model.DesignedDiffs.xafml  after adding Expand.Xaf packages

I already upgraded my project to DevExpress version 22.1.6 but I have an error loading the Model.DesignedDiffs.xafml and model.xafml after adding the following packages (Xpand.Xaf.Modules.Reactive, Xpand.XAF.Modules.JobScheduler.Hangfire and Xpand.XAF.Modules.Blazor) to my MySampleHangfire.Blazor.Server and MySampleHangfire.Module project. See the attached screenshot. I also attach here my sample project.
The error occurred after adding the below code in the constructor of the BlazorModule.cs file.
RequiredModuleTypes.Add(typeof(Xpand.XAF.Modules.Blazor.BlazorModule));
RequiredModuleTypes.Add(typeof(Xpand.XAF.Modules.Reactive.ReactiveModule));
RequiredModuleTypes.Add(typeof(Xpand.XAF.Modules.JobScheduler.Hangfire.JobSchedulerModule));
MySampleHangfire.zip

You can check the link below for the video recording I made to reproduce the issue.
https://supportcenter.devexpress.com/ticket/details/t1126554/how-to-add-model-assembly-job-source
(Filename: ErrorExpandHangFire.mp4)

thnks for the sample, I can repro the issue and will see to it. For now I was able to open ME by installing latest System.Interactive 6.0.1 to the Blazor.Server project and then restart VS.

Thanks, apobekiaris! Please let me know when the fix for this will be available so that I can apply to my project.

apobekiaris i tried to add the System.Interactive 6.0.1 to the Blazor.Server project  but there is an error, See the attached image.

I do not think this error relates to eXpandFramework, it says the dir does not exist, so u probably uninstall DX. YOu can configure these dirs in your VS/Tools/Options/Nuget/Package Sources

Thank you! issue was fixed after configuring the Nuget package sources. Just a follow-up question, how to create the objectspace in my class that has the JobProvider attribute? See the attached recording.  As you can see the value of the Application property is NULL so I was not able to create objectspace. It was NULL because the constructor that has the BlazorApplication parameter was not called.
https://user-images.githubusercontent.com/41627689/201474943-84fbfbca-1396-4aa0-bc97-f517e145bab9.mp4

see the wiki for instructions on how to declare jobs
https://github.com/eXpandFramework/Reactive.XAF/tree/master/src/Modules/JobScheduler.Hangfire#details

apobekiaris,
I have tried the code in your example but where i will get the ServiceProvider in the DailyTask method? See the attached screenshot.  Because when i try to use the ServiceProvider .RunWithStorageAsync is says that
ServiceProvider does n

ot contain a definition for 'RunWithStorageAsync. What is the namespace of the ServiceProvider that you used in the sample code?

the ServiceProvider is the Provider docs are wrong I will update them

Same with this example from here:  https://www.youtube.com/watch?v=0LJ2bM1CfMg  the Application property is NULL so there is no way you can create an objectspace. See the attached video recording.  Even if I changed the property to Provider the value of this property is also NULL.
https://user-images.githubusercontent.com/41627689/201525075-748cf3af-3e59-4b43-808f-4b405ea812b3.mp4

this video uses an old version it is not possible to inject the BlazorApplication, instead there is the IServiceProvider. There are several u can follow or also u can llok at the TestApplication
https://github.com/eXpandFramework/Reactive.XAF/blob/master/src/Tests/JobScheduler.Hangfire/TestJob.cs
https://github.com/eXpandFramework/Reactive.XAF/blob/master/src/Tests/EasyTests/TestApplication/TestApplication.Module.Blazor/JobScheduler/Job.cs

I recommend you either use the distributed symbols to actually debug the package and see what's wrong or another option is to compile the source using the quick  you can read more on how easy it is to own the code at https://github.com/eXpandFramework/eXpand/issues/943
as you can read after u build the source u can simply load the JobScheduler project in your solution or any other package and build. If you set a breakpoint it will break or u can even modify it. Sorry I cannot repeat myself again all the info you need to master this framework is on #943

about 7
public static IObservable<JobState> JobState => JobStateSubject.AsObservable();

thats the declaration of JobState so it is static so feel free to use it any place and remember to dispose it along with the container the same u do with any IDisposabel class or events etc

Where does the data in the Workers tab come from? Or how it was generated? Is there any code that I need to add in order to display the data in the Workers tab?

without a sample and spending time to research why u cannot see the Worker is not possible to answer u. In any case the worker is created at JobSchedulerService.ApplyJobState which is called from the Hangfire filter and since u go into your job I assume it went there. I would check if the worker is on my DB or I would debug the package as I mentioned

the package as all the packages work as is or there will be explicit instructions in the wiki. In this case no instruction so as it is

did you run the TestApplication from the source code? does it work there?

thnks I need time to review the testapplication apparently this is some kind of layout issue, data are there so they should be displayed unless the layout is broken. In the meantime feel free to open ME and play with the layout your self.

And one thing apobekiaris, every time I run my application and there is a job that runs Minutely I always get this error. See the attached screenshot.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Add unmarshallable primitive types

Adds size package for describing request and response body payload sizes

Adds "github.com/docker/go-units" to dependencies

Adds pct package for describing error rates
Adds svctype package for picking between HTTP or gRPC service types
Note that overall, the pct and svctype packages are "dead code" in that the mock service does not respond with errors or support gRPC yet.

/assign @mandarjog

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Tahler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Tahler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tahler: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


chore: bump the version of controller runtime

@azdagron @MarcosDY hey, could i get a review on this?
i try to use import the package github.com/spiffe/spire-controller-manager/api/v1alpha1 and get conflicts due to the mismatching of the version to sigs.k8s.io/controller-runtime
could not import github.com/spiffe/spire-controller-manager/api/v1alpha1 (-: # github.com/spiffe/spire-controller-manager/api/v1alpha1
vendor/github.com/spiffe/spire-controller-manager/api/v1alpha1/controllermanagerconfig_loader.go:48:17: o.Cache.Namespaces undefined (type "sigs.k8s.io/controller-runtime/pkg/cache".Options has no field or method Namespaces)
vendor/github.com/spiffe/spire-controller-manager/api/v1alpha1/controllermanagerconfig_loader.go:49:11: o.Cache.Namespaces undefined (type "sigs.k8s.io/controller-runtime/pkg/cache".Options has no field or method Namespaces)
vendor/github.com/spiffe/spire-controller-manager/api/v1alpha1/controllermanagerconfig_loader.go:52:7: o.MetricsBindAddress undefined (type *manager.Options has no field or method MetricsBindAddress)
vendor/github.com/spiffe/spire-controller-manager/api/v1alpha1/controllermanagerconfig_loader.go:53:5: o.MetricsBindAddress undefined (type *manager.Options has no field or method MetricsBindAddress)) (typecheck)

close this as it is duplicated to https://github.com/spiffe/spire-controller-manager/pull/235


Better implementation of the caching

cache moved from memory to disk using shelve library
caching removed from nodes, now it is external object that can be used to 'fit' the nodes from pre-saved results

Hello @nicl-nno! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file fedot/core/composer/gp_composer/gp_composer.py:

Line 21:121: E501 line too long (121 > 120 characters)

In the file fedot/core/composer/optimisers/regularization.py:

Line 52:32: E713 test for membership should be 'not in'


Automated tests ... toward CI

I have seen that the draft I developed for testing individual diagnostics (tests/test_diagnostics) using synthetic data has already been moved from my original SVN branch to the current refactoring branch.
I am a bit puzzled about that, as the code was not ready yet to be merged.
Thus my question is now
a) who was doing that integration
b) what would be the baseline for the further testing. Should I branch off from the current refactoring backend branch?
This is quite essential if we want to use the testing for continuous integration with services like travis-ci
Best, Alex

According to the svn history, the tests/ directory has been merged to the svn trunk by Martin Evaldsson about 1 year ago.
@ESMValGroup/esmvaltool-coreteam


Error: macro_only.tcl, 5 GPL-0305

here is the lef/def, how can i solve these problems.
Thank you for your kind cooperation
macros.zip

@mgwoo if possible the error should include suggestions to correct because it's a bit esoteric.

Sorry, but this testcase is not appropriate on OpenROAD testcases. If the number of instances or nets are too small, I would prefer to use a simulated annealer to place macros, etc.

If the number of instances or nets are too small, I would prefer to use a simulated annealer or BiCGSTAB QP solver to place macros. The nonlinear placer cannot handle this wedged testcase.

@mgwoo is it possible to detect this behavior and add an error stating this?

@ravi-varadarajan hopefully rtl-mp can handle this case.  Would you verify?

@mgwoo  Mingyu have you set up the test case in some location in UCSD server?

Confirmed that this testcase is working well if you put the following:
global_placement -skip_initial_place

or:
global_placement -bin 4


Implements service tests

Short Description
Implements service tests for services done before service test base was created.
Proposed Changes
Adds service tests for:

AlgorithmService
AlgoRelationTypeService
ProblemTypeService
PublicationService
ImplementationService
SoftwarePlatformService
CloudServiceService
TagService

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@449acdc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   40.32%
  Complexity        ?      206
=========================================
  Files             ?       82
  Lines             ?     1059
  Branches          ?       36
=========================================
  Hits              ?      427
  Misses            ?      617
  Partials          ?       15

Retry DeepCode


isimpson002 cf checks report for CESM2-CAM6 v20230225

The following errors were raised by the cf checks. Some may ignored if the metadata is consistent with the SNAPSI mip tables.

attribute valid_min and valid_max error:
Where valid_min or valid_max are specified, they are in string format (e.g. lat:valid_max = "90.0"). This is consistent with the snapsi tables, but raises a cf error which expects a numerical value:
ERROR: Attribute valid_min of incorrect type (expecting 'Numeric' type, got 'String' type)
Can this error be ignored or does this need amending in tables?
error also found in #35

invalid value for positive attribute
error raised by cfcheck but consistent with snapsi tables:
E.g. variable clt has attribute 'clt:positive = "" ;'
ERROR: (4.3): Invalid value for positive attribute

incorrectly labelled time_bnds
for variables mrso, mrsos:
time has attribute 'time:bounds = "time_bounds"' but variable is called "time_bnds" not "time_bounds"
ERROR: (7.1): bounds attribute referencing non-existent variable time_bounds


Prune unreachable packages from lockfile

In transformers, we have:

tensorflow-text: tensorflow-macos; python_full_version >= '3.13' and platform_machine == 'arm64' and platform_system == 'Darwin'
tensorflow-macos: tensorflow-cpu-aws; (python_full_version < '3.10' and platform_machine == 'aarch64' and platform_system == 'Linux') or (python_full_version >= '3.13' and platform_machine == 'aarch64' and platform_system == 'Linux') or (python_full_version >= '3.13' and platform_machine == 'arm64' and platform_system == 'Linux')
tensorflow-macos: tensorflow-intel; python_full_version >= '3.13' and platform_system == 'Windows'

This means that tensorflow-cpu-aws and tensorflow-intel can never be installed, and we can drop them from the lockfile.

How do these even make it into the graph in the first place? 🤔  Is there any way for us to prevent it?

tl;dr: Not without an extra layer of virtual packages or forking.
Say we have A -> B on linux and B -> C on windows. We first process A with A -> B, and then B with B -> C. At this point, we know that B is linux only, so we could drop the B -> C edge. Later, we process a package D (universally included), with D -> B. Now we would need to add back C since it is included again, but this doesn't work since pubgrub needs all it's incompatibilities to be immutable.
To mitigate this, we would need a virtual package for each platform, treating platforms like extras, so e.g. splitting the real B into B[not(windows)] and B[windows], with A[universal] -> B[not(windows)], B[windows] -> C[...], B[not(windows)] -> B, B[windows] -> B, and all packages without platforms being dummies that only force the same version of a package. Since we need to propagate this information across intermediary dependencies, we would have to create virtual packages for all intermediary dependencies, creating a massive virtual dependency tree.
We could also fork every time we see a platform marker, for the known trade-offs.
Cargo has this problem too.


chore(repo): stop tracking build outputs

@Alberplz if you're willing to consider this PR (and the other pending one as well, BTW) we can work at it again and resolve conflicts after recent changes.

I'm not sure bower would work after this change is merged. I prefer npm but some prefer bower.
Also, I would add a prepublish script to the package.json which calls npm run build

@cmckni3 haven't used bower for some time now, so maybe someone with more up-to-date info can chime in. But as far as usual best practices, you don't store build output/artifacts under source control, just for the fact that whatever tool needs those, there should be some command to recreate them.
So I guess that if bower needs them at some point in build process, there should be a previous build step that recreate those.
BTW @Alberplz we can resolve current conflicts if you plan on merging this PR at some point

@BrainCrumbz I have up-to-date information. I have build many projects using bower.
I agree with not putting the artifacts in the repo. Unfortunately, you have to for it to be compatible with bower. I looked through many large open source projects and they keep the built version of the library in the repo to be compatible with bower.
Take a look at moment, knockout, etc.
It appears most projects are taking a new approach to releasing with bower. Bower depends on tags in git and the main key of bower.json. Some maintainers are adding their dist/build folder to the tagged commit.

I see. Well, I guess this PR should be ignored and closed then.


[GEN] Add cache control to 2D block load/store

@victor-eds
Thanks for the code changes. It looks good to me.
I'd like to pick it and make it a formal code PR.

@chengjunlu is this message https://github.com/intel/intel-xpu-backend-for-triton/pull/1131#issuecomment-2111654539 supposed to be posted in a different pr?


[Feature]Very good project, hope to support more features

For example
memorized pre-selected language options (need to reselect language each time you start the program)
History transcription
Save transcriptions as text
Caption hover window with movable position
Thank you for your work.

any suggestion for this?
https://github.com/botbahlul/pyvosklivesubtitle/releases/download/pyvosklivesubtitle-0.1.0/pyvosklivesubtitle-0.1.0.zip

有什么建议吗？ https://github.com/botbahlul/pyvosklivesubtitle/releases/download/pyvosklivesubtitle-0.1.0/pyvosklivesubtitle-0.1.0.zip
there are some problems. . .

When you run this app for the very first time it may takes some times to download vosk language model, you can check those downloaded models in "/home/username/.cache/vosk" (if you're on Linux) and "C:\Users\Username.cache\vosk" (if you're on Windows).
download those small models manually from https://alphacephei.com/vosk/models then extract them to (if you're on Linux) and "C:\Users\Username.cache\vosk" (if you're on Windows)."/home/username/.cache/vosk"

https://github.com/botbahlul/pyvosklivesubtitle/releases/download/pyvosklivesubtitle-0.1.2/pyvosklivesubtitle-0.1.2.zip

Download those small models manually from https://alphacephei.com/vosk/models then extract them to "/home/username/.cache/vosk" (if you're on Linux) and "C:\Users\Username.cache\vosk" (if you're on Windows).

Don't forget to put those library files (".dll" for windows, "libvosk.so" for linux) altogether in same folder with pyvls executable (pyvls.exe or pyvls)

IT SEEMS THAT YOU'RE TO LAZY TO READ THAT README ON FIRST PAGE OF MY REPO 😁

Trust me, I read your README file carefully and set the correct path. In version 0.1.2, it still gives an error.
![屏幕截图 2023-04-10 184657](https://user-images.githubusercontent.com/52863141/230949837-3e6ead8e-cf60-4438-b23f-1cfe91437cab.

png)

In any case, version 0.0.12 works fine.

@botbahlul
UPDATE:
......I found the problem...The packaged version in Releases can't run normally, but through the pyvosklivesubtitle-main of Clone https://github.com/botbahlul/pyvosklivesubtitle.git, and then run pyvls.pyw, everything works. . .

suggestion:

The subtitle position can be moved, sometimes it is not necessarily watching YouTube.
Can I view previous sentences through the configuration window? The current version seems to disappear in the Audio language window immediately after the sentence is broken.
There are always some sudden freezes and crashes.

Are you using Windows 11?
What is your processor and how many RAM you have?
Compiled binary from Releases page runs fine on my Windows 10 PC (I5-3340M CPU @2.7GHz and 16GB RAM).
I've never tested it yet on any Windows 11.
I'll try to add element to show overall transcriptions on next releases.

Please let me know if you're still get bugs
https://github.com/botbahlul/pyvosklivesubtitle/releases/download/pyvosklivesubtitle-0.1.3/pyvosklivesubtitle-0.1.3.zip


Unable to read file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/settings.json

Type: Bug
Unable to read file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/settings.json
Isn't the user data dir automatically put on the allow list?
I do have NODE_UNC_HOST_ALLOWLIST = DV.LOCAL in env,
[7704:0512/130520.436:INFO:CONSOLE(754)] "Unable to read file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/settings.json' (Unknown (FileSystemError): UNC host 'dv.local' access is not allowed. Please update the 'security.allowedUNCHosts' setting if you want to allow this host.)", source: vscode-file://vscode-app/c:/Users/spek/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js (754)
[7704:0512/130520.447:INFO:CONSOLE(624)] "%cTRACE color: #888 Error while resolving configuration file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/tasks.json': Unable to read file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/tasks.json' (Error: Unable to resolve nonexistent file 'vscode-userdata://dv.local/ROOT/USERS/spek/AppData/Code/User/tasks.json')", source: vscode-file://vscode-app/c:/Users/spek/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js (624)

VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD Ryzen 7 3700X 8-Core Processor              (16 x 3593)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.95GB (22.28GB free)

Process Argv
--verbose --crash-reporter-id 38a08b52-dec2-4734-9f3a-f6654d51d1cd

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

better-cpp-syntax
jef
1.17.2

vscode-dotnet-runtime
ms-
1.6.0

isort
ms-
2022.8.0

python
ms-
2023.8.0

vscode-pylance
ms-
2023.5.20

jupyter
ms-
2023.4.1011241018

jupyter-keymap
ms-
1.1.0

jupyter-renderers
ms-
1.0.15

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.292.0

remote-ssh
ms-
0.102.0

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.0

errorlens
use
3.11.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30610678
282f8724:30602487
pyind779:30671433
89544117:30613380
vscrpc:30673769
pythonsymbol12:30671437
a9j8j154:30646983
showlangstatbar:30737416
vsccsb:30705552
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30731395
pythoncmvfstrcf:30731970
fixhidewlkth:30730051
showsbindicator:30730056

We only fixed this in insiders.
Beginning with VS Code 1.78.1 accessing any UNC path (those that begin with \\) on Windows is blocked to mitigate a security risk that is further explained in this Security Advisory.
Please refer to https://aka.ms/vscode-windows-unc for more information how to make your specific UNC path work again.

We only fixed this in insiders.

Will this be released later?
This is causing lots of trouble..

You can give our preview releases a try from: https://code.visualstudio.com/insiders/

You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I can, but for a lot of others that are less tech savvy this is quite a road block..


Unable to load the Preload.js script.

Bug description
The bundled app cannot load preload.js.
Steps to reproduce
Give your full nativefier command, with the --verbose flag, on a public site:

Run nativefier, even with minimal config (such as only name and URL).
Open DevTools and check out the console.

Expected behavior
No errors
Actual behavior
init.ts:206 Unable to load preload script: /Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js
(anonymous) @ init.ts:206
init.ts:207 Error: Cannot find module 'loglevel'
Require stack:
- /Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js
    at Module._resolveFilename (internal/modules/cjs/loader.js:798)
    at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (reset-search-paths.ts:40)
    at Module._load (internal/modules/cjs/loader.js:691)
    at Module._load (electron/js2c/asar.js:717)
    at Function.Module._load (electron/js2c/asar.js:717)
    at Module.require (internal/modules/cjs/loader.js:853)
    at require (internal/modules/cjs/helpers.js:74)
    at Object.<anonymous> (/Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js:21)
    at Object.<anonymous> (/Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js:68)
    at Module._compile (internal/modules/cjs/loader.js:968)
(anonymous) @ init.ts:207
MwLb-ei-a-s.js?_nc_x=Ij3Wp8lg5Kz:47 ErrorUtils caught an error:

Cannot access 'INJECT_JS_PATH' before initialization

Subsequent errors won't be logged; see https://fburl.com/debugjs.
b @ MwLb-ei-a-s.js?_nc_x=Ij3Wp8lg5Kz:47
/Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js:46 Uncaught ReferenceError: Cannot access 'INJECT_JS_PATH' before initialization
    at injectScripts (/Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js:46)
    at HTMLDocument.<anonymous> (/Users/.../Repositories/AppBundler/Facebook-darwin-x64/Facebook.app/Contents/Resources/app/lib/preload.js:16)

Context

Nativefier: Latest (for example: 8.0.4)
Node.js: Latest (for example: 13.11.0)
Npm: Latest (for example: 6.14.7)
OS: macOS Latest

Please provide the information requested by https://github.com/jiahaog/nativefier/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

I'm having same issue.
Nativefier: 8.0.6
Node.js: v13.12.0 (tried with LTS also)
Npm: 6.14.4
OS: OSX 10.11.6 (15G22010)
Installed everything today, made around 12 different builds error is always happening.
Always the same:

Unable to load preload script: /Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js init.ts:206

init.ts:207 Error: Cannot find module 'loglevel'
Require stack:
- /Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js
    at Module._resolveFilename (internal/modules/cjs/loader.js:798)
    at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (reset-search-paths.ts:40)
    at Module._load (internal/modules/cjs/loader.js:691)
    at Module._load (electron/js2c/asar.js:717)
    at Function.Module._load (electron/js2c/asar.js:717)
    at Module.require (internal/modules/cjs/loader.js:853)
    at require (internal/modules/cjs/helpers.js:74)
    at Object.<anonymous> (/Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js:21)
    at Object.<anonymous> (/Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js:68)
    at Module._compile (internal/modules/cjs/loader.js:968)
(anonymous) @ init.ts:207
/Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js:46 Uncaught ReferenceError: Cannot access 'INJECT_JS_PATH' before initialization
    at injectScripts (/Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js:46)
    at HTMLDocument.<anonymous> (/Users/kiki/APP-darwin-x64/APP.app/Contents/Resources/app/lib/preload.js:16)
[log.txt](https://github.com/jiahaog/nativefier/files/4403774/log.txt)

Same issue here when trying to inject JS

Same issue here when trying to inject JS

I believe I am also having the same issue with nativefier version 8.0.4 on Linux when trying to inject javascript.  A very similar error appears in console, and javascript that worked fine in older versions of nativefier no longer does anything.

This is also affecting me on Linux with 8.0.6. 8.0.5 also suffers from it, though 8.0.0 does not. I'm short on time atm, but I took a quick pass at a diff and no cause jumped out at me, so I've downgraded for now: npm install -g<EMAIL_ADDRESS>Happy to test a fix if one comes along.
Thanks contributors for this indispensable tool! :blue_heart:

This is also affecting me on Linux with 8.0.6. 8.0.5 also suffers from it, though 8.0.0 does not. I'm short on time atm, but I took a quick pass at a diff and no cause jumped out at me, so I've downgraded for now: npm install -g<EMAIL_ADDRESS>Happy to test a fix if one comes along.
Thanks contributors for this indispensable tool!

Can confirm that 8.0.0 allows javascript to be injected without issue.

For those who are new to the nativefier like me, there is an issue with installation of 8.0.0-3. More info on how to fix it here: https://github.com/jiahaog/nativefier/releases .
Also confirming 8.0.0 throws no error.

I went back and forward on this in versions now to test few things.
Its funny what I found out. On 8.0.0 preload is included as well as desired js.
But, I'm new to this and first thing I used is latest 8.0.6 and I had OSX notifications called from webpage threw app, as well as cookies setup (they worked only until app is quieted) . But none of those works on 8.0.0  where preload works and injection...
And it would be really nice to have both :)

It looks like the issue was introduced in 8.0.4.  8.0.3 works for me.  8.0.4 does not.

Created PR which should resolve the issue: https://github.com/jiahaog/nativefier/pull/950

👋 everybody. This is fixed and released in 8.0.7 . Thanks for the chat and ideas!


Added support for debug logging

Just a suggestion to make it a bit easier to debug stuff (leave messages still don't work all the time for me).

Don't necessarily see the point of this - console already provides the info, debug, and error methods, and this pull request dose not implement any of them. Filtering what to log based on a config option is impractical.

Why would that be impractical? That is how a lot of software works. Normal use case is either info or warning and then a debug for well debugging. You don't want to leave debug logging running all the time as (depending on the software ofc) this can cause for a lot of disk usage. The built-in console functions do not have anything to set a log level (as far as I know correct me if I'm wrong).
For example: I have issues with leave messages so I want to know what the bot is doing. Is it reading correctly from factorio (and then not sending?) Or is it not parsing? Or can't it post to Discord. So I want stuff that logs it all but for the normal flow that only wastes disk space.
Me not using console.debug or console.error is from my web dev background, that used to give a lot of problems on IE. I don't really mind using those functions but that is something different from wanting to set the log level.

Normal use case is either info or warning and then a debug for well debugging. You don't want to leave debug logging running all the time as (depending on the software ofc) this can cause for a lot of disk usage.
There's a config toggle on whether or not to send debug messages to the console, see config.logLines. You can use this to debug without the need for an enum.

Me not using console.debug or console.error is from my web dev background, that used to give a lot of problems on IE.
In this case, you could use console.debug for debugging and console.error for warnings/errors. Considering the introduction of the enum, this would be the more sensible option.

My concern is that this pull request adds a lot of unneeded bloat for a config feature that exists already or could simply be altered.

It could be an idea to make every log be able to be set, but except for logLines, which logs all incoming lines to the console, there isn't any other "debug" item to log unless you want to disable all connection logs, which in my opinion are quite important

Normal use case is either info or warning and then a debug for well debugging. You don't want to leave debug logging running all the time as (depending on the software ofc) this can cause for a lot of disk usage.

There's a config toggle on whether or not to send debug messages to the console, see config.logLines. You can use this to debug without the need for an enum.

Me not using console.debug or console.error is from my web dev background, that used to give a lot of problems on IE.

In this case, you could use console.debug for debugging and console.error for warnings/errors. Considering the introduction of the enum, this would be the more sensible option.
My concern is that this pull request adds a lot of unneeded bloat for a config feature that exists already or could simply be altered.

But that config item really logs everything, the nice thing about log levels is that the user can decide how much logging he/she wants. But I agree that you want one of them, not both. I don't mind using the other console functions, doesn't change anything in the output for cli afaik.

It could be an idea to make every log be able to be set, but except for logLines, which logs all incoming lines to the console, there isn't any other "debug" item to log unless you want to disable all connection logs, which in my opinion are quite important

Well other stuff could be discord status checks, the parsing of messages for example. The more features you add the more stuff that (might) break.

Hmm, interesting..


Pictures on profiles not resizing

I've flagged this problem before on Laura's account a few months ago. Pictures on individual profiles are no longer resized and now appear huge below the profile in random sizes, which looks terrible and not at all professional.

.In the next release the profile page will be cleaned up and re-worked a bit.
Maybe you could help make it better by providing useful feedback or creating a short mockup on how you would make those page look good.
I will let you know as soon as I work on the next version user pages (I actually already started to look at the whole user process... ), this is one of the last part in the new version that will need some -consequent- work to look good and actually be nice.
Generally speaking the current UX for registering / login, viewing and updating users account or profile is just horrible (not only the user page) from A-Z - and was aside of the picture issue- pretty much always like that on the new site.
This is exactly why, rather than spending an awful lot of time fixing specifics, this is done directly by (re)using/implementing a proper theme that isn't full of hacks and in many case get back to more basics / standard Drupal functionality, which actually provide better UX and UI.

closing this one as a duplicate of https://github.com/landportal/drupal/issues/88
on the live site I have limited the size on user's page to 220x220 so it look a bit less horrible.
I will be working next week on the user (and organization) part for the new theme.


How to solve this problem

File "D:\work_py\MHFormer-main\demo\lib\hrnet\gen_kpts.py", line 163, in gen_video_kpts
keypoints = keypoints.transpose(1, 0, 2, 3)  # (T, M, N, 2) --> (M, T, N, 2)
ValueError: axes don't match array

@HulahaVla create seperate repo for demo and then place model directory from MHFormer-main inside of there and this will resolve issue. Issue is due to imports not being  recognized.

Hi~Thanks for your interest fou our work.
Following @alecda573  or re-downloading all the repo may resolve the issue.

I am getting the same issue, so i debugged by pdb.
error caused from here
I think you should check out your video path passed into gen_kpts.py

Hi, I think the video should place in demo/video directory. And I tested it and passed.


Revert "feat: add quickreply for mygopen award"

Reverts cofacts/rumors-line-bot#390
Activity ends at 4/12

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 87.593%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1032

Relevant Lines:
1139

💛  - Coveralls


Expose 'buttonClass' input to set custom classes to all buttons

Add buttonClass input to <share-buttons> component: sets custom classes to all buttons
before it was only possible to set custom classes in a single button <share-button>
now it's possible in  <share-buttons>

Improve folder structure

Move static functions to Helper share.helper.ts

Remove duplicate code:

use nFormatter in the pipe from Helper
use error handling function from Helper

Possible TODO: convert ShareArgs and ShareButton class to interfaces (low priority), @tinesoft  what do you think?
I was also trying to make integration possible with external button components like material, I thought about adding a new input to specify the name of the directive that should be added to all buttons, e.g. md-button, but It seems NOT possible to do that dynamically!
if it worth it, we should find a way without using the *ngIf
Cheers!

Coverage decreased (-3.3%) to 92.424% when pulling 24807ab0a9c3145a57839e17d63def1086531710 on dev into 2e0634a48d0948182650317f4425452da224547a on master.

Hi Murhaf,
Thanks for considering my humble opinions for future evolution of the library. I appreciate 👍
A couple of suggestions before i continue, to improve future collaboration and review:

commits: I recommend following  Angular Git Commit Guidelines as i do.
They really improve readability of commits messages, and somehow enforce unit, single-focused commits
commits:  Keep them focused and related (avoid doing anything out of the mentioned scope). Several separate  commits are better/easier to review than one big all-in commit.

Now regarding your questions,

converting ShareArgs and ShareButton to interfaces: given that those are only used internally, it make no much sense to transform them, as final users will not need to extend them.
integration  with external button components:  that could be great.  I suggest delaying the discussion about it until i add tests for current components, as this will certainly trigger huge API refactoring.

Regarding this commit, i will comment on the PR directly (next to related source code changes).
I will post back here, once i'm done. So keep this commit as is for the moment


Cordova Google map not Visible on android Device (Visible on emulator with latest android 7.0)

I am having this issue with maps ,the map is not visible on android emulator 4.x..x, 5.x and 6 versions but is visible on 7, however it is not visible on actual devices (All the versions). Please help, I can see no error in the logs.

https://github.com/mapsplugin/cordova-plugin-googlemaps#version-20-beta

I don't understand what you are trying to say

$> cordova plugin add https://github.com/phonegap-googlemaps-plugin/cordova-plugin-googlemaps --variable API_KEY_FOR_ANDROID="YOUR_ANDROID_API_KEY_IS_HERE" --variable API_KEY_FOR_IOS="YOUR_IOS_API_KEY_IS_HERE"
is this how i should add beta plugin?

The master branch is old. The version2 works on Androind N.
You should use the beta version.

https://github.com/mapsplugin/cordova-plugin-googlemaps/wiki/v2-beta
Please read the How to install the v2 beta? page.

the plugin i am using right now works on latest version and not on older versions. Does v2 work on older version of android like 5.1 and above?

I don't support the master version anymore. It's too old for me.
Some methods and some event names are changed, but others are almost the same.
You can stick on the current version, but you can not support for older version.

i am using the current stable only but can't see map on android device, its working on emulator.

Other issue is that in android (on emulator), it sometimes show current location marker ,but does not show all the time.

@wf9a5m75 hey I'm using ionic 2 so cannot use v2, please help

Sorry, but I'm not familiar with ionic.
But at least the latest version works on the ionic2.

I am Using current master branch and it works fine on ios with map and everything but i am only getting white screen on android devices. Please help with a fix

Other people does not have your issue. I think problem is in your project.
And I already said the master branch will be deprecated soon.
Please use the v2-beta version.

I upgraded to RC1 and maps is still working for me @uditguru

I don't know what was wrong but it is working now
Sent from my iPhone

On 04-Nov-2016, at 8:12 PM, Ariel Gelbard<EMAIL_ADDRESS>wrote:
I upgraded to RC1 and maps is still working for me @uditguru
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Possible Bug: Is transactions not getting reset?

In s_transactions, we have the state being updated with the new transactions, but won't that have us double count in the following timesteps stuff like the number of slashes?

lets discuss

I can also check it out more deeply myself if it is not an obvious reason

Not getting cleared, meant for history of all transactions

Need to check if slashes get double counted, but it might be filtered

Checked a few places, seems to be fine, will close with branch merge


fix: handle fakeQL 424 response code

fakeQL is having stability issues recently and intermittently throws a 424 "db connection failed" error. However, the server response is not following the JSON API spec (no "errors" field) so a workaround is needed in the auto-generated code to handle this.

👍🏻


delete layout and useraccount tables, rename main_router to pride_router

@sureshhewabi - first part of the changes we just discussed:

delete layout table
delete useraccounttable
rename main_router to pride_router
rename main.py to pride.py

main.py will become place for a small amount of code that's shared by all the APIs (PRIDE, PDBdev & xiVIEW data loader)

I don't know why the GH interface isn't letting me assign reviewers, i would if it let me...

@sureshhewabi - actually, i think 'shared.py' might be a better name than 'main.py' for the new file


acl wildcard problem with $ character.

Erlang MQTT Broker 2.2
if i have the following acl
{
    "_id": ObjectID("xxxxxx"),
    "username": "setup",
    "pubsub": [
        "device/60019423a83c/#"
    ]
}

I can't access to subtopic with $ character.
A workaround is specify all subtopic with   $ character.
For example:
{
    "_id": ObjectID("xxxxxx"),
    "username": "setup",
    "pubsub": [
        "device/60019423a83c/$stats/#",
        "device/60019423a83c/$device/#",
        "device/60019423a83c/$mac/#",
        "device/60019423a83c/$name/#",
        "device/60019423a83c/$localip/#",
        "device/60019423a83c/$fw/#",
        "device/60019423a83c/$fw/checksum/#",
        "device/60019423a83c/$implementation/#",
        "device/60019423a83c/+/+/set",
        "device/60019423a83c/$online",
        "device/60019423a83c/$homie",
        "device/60019423a83c/dust/$type",
        "device/60019423a83c/dust/$properties",
        "device/60019423a83c/#"
    ]
}

@taiuti, Has been fixed and released at v2.3.3.
I will close this issue, if there is a problem, will reopen it.


KeyError: 'coarsename'

Thank you for publishing this excellent work~
When I run the python tools/train.py configs/segrefiner/segrefiner_hr.py according to your readme， there is a problem here：
Original Traceback (most recent call last):   File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop     data = fetcher.fetch(index)   File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in fetch     data = [self.dataset[idx] for idx in possibly_batched_index]   File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in <listcomp>     data = [self.dataset[idx] for idx in possibly_batched_index]   File "/mmdetection/SegRefiner-main/mmdet/datasets/hr_collection.py", line 77, in __getitem__     data = self.pipeline(results)   File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/compose.py", line 41, in __call__     data = t(data)   File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/loading.py", line 864, in __call__     results = self.load_coarse_mask(results)   File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/loading.py", line 849, in load_coarse_mask     filename = osp.join(results['img_prefix'], results['img_info']['coarsename']) KeyError: 'coarsename'
How can I get the “coarsename”？

python tools/test.py configs/segrefiner/segrefiner_dis.py checkpoints/segrefiner_hr_latest.pth --out_dir /mmdetection/SegRefiner-main/output/ /opt/conda/envs/segrefiner/lib/python3.8/site-packages/mmcv/__init__.py:20: UserWarning: On January 1, 2023, MMCV will release v2.0.0, in which it will remove components related to the training process and add a data transformation module. In addition, it will rename the package names mmcv to mmcv-lite and mmcv-full to mmcv. See https://github.com/open-mmlab/mmcv/blob/master/docs/en/compatibility.md for more details.   warnings.warn( load checkpoint from local path: checkpoints/segrefiner_hr_latest.pth Traceback (most recent call last):   File "tools/test.py", line 237, in <module>     main()   File "tools/test.py", line 205, in main     model.CLASSES = dataset.CLASSES AttributeError: 'DISDataset' object has no attribute 'CLASSES'

When I TEST using python tools/test.py configs/segrefiner/segrefiner_dis.py checkpoints/segrefiner_hr_latest.pth --out_dir /mmdetection/SegRefiner-main/output/ /opt/conda/envs/segrefiner/lib/python3.8/site-packages/mmcv/__init__.py:20: UserWarning: On January 1, 2023, MMCV will release v2.0.0, in which it will remove components related to the training process and add a data transformation module. In addition, it will rename the package names mmcv to mmcv-lite and mmcv-full to mmcv. See https://github.com/open-mmlab/mmcv/blob/master/docs/en/compatibility.md for more details. warnings.warn( load checkpoint from local path: checkpoints/segrefiner_hr_latest.pth Traceback (most recent call last): File "tools/test.py", line 237, in <module> main() File "tools/test.py", line 205, in main model.CLASSES = dataset.CLASSES AttributeError: 'DISDataset' object has no attribute 'CLASSES'

Thank you for your feedback. I will test it out and fix this bug.

Thank you for publishing this excellent work~ When I run the python tools/train.py configs/segrefiner/segrefiner_hr.py according to your readme， there is a problem here： Original Traceback (most recent call last): File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop data = fetcher.fetch(index) File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in fetch data = [self.dataset[idx] for idx in possibly_batched_index] File "/opt/conda/envs/segrefiner/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in <listcomp> data = [self.dataset[idx] for idx in possibly_batched_index] File "/mmdetection/SegRefiner-main/mmdet/datasets/hr_collection.py", line 77, in __getitem__ data = self.pipeline(results) File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/compose.py", line 41, in __call__ data = t(data) File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/loading.py", line 864, in __call__ results = self.load_coarse_mask(results) File "/mmdetection/SegRefiner-main/mmdet/datasets/pipelines/loading.py", line 849, in load_coarse_mask filename = osp.join(results['img_prefix'], results['img_info']['coarsename']) KeyError: 'coarsename'
How can I get the “coarsename”？

This issue was due to the missing information in the JSON file obtained by the script scripts/gen_coarse_masks_hr.py. It has now been fixed. If you have previously run the script and stored the coarse masks used for training, you can also obtain the correct JSON file by running scripts/get_collect_json.py.

When I TEST using python tools/test.py configs/segrefiner/segrefiner_dis.py checkpoints/segrefiner_hr_latest.pth --out_dir /mmdetection/SegRefiner-main/output/ /opt/conda/envs/segrefiner/lib/python3.8/site-packages/mmcv/__init__.py:20: UserWarning: On January 1, 2023, MMCV will release v2.0.0, in which it will remove components related to the training process and add a data transformation module. In addition, it will rename the package names mmcv to mmcv-lite and mmcv-full to mmcv. See https://github.com/open-mmlab/mmcv/blob/master/docs/en/compatibility.md for more details. warnings.warn( load checkpoint from local path: checkpoints/segrefiner_hr_latest.pth Traceback (most recent call last): File "tools/test.py", line 237, in <module> main() File "tools/test.py", line 205, in main model.CLASSES = dataset.CLASSES AttributeError: 'DISDataset' object has no attribute 'CLASSES'

This is also fixed. Thank you for your feedback!


Tests: test hang forever with seed 781F748CA7E2F130

With seed 781F748CA7E2F130, test hang forever:
mvn test -Dtests.twitter=true -Dtests.config=/path/to/elasticsearch.yml -Dtests.seed=781F748CA7E2F130

I ran a test today on master with the same seed and was not able to reproduce it.


Event propagation cancellation check happens too early?

Problem

I think the check for event propagation cancellation happens too early.  In particular, I think that
        if unsafe { BUBBLE_EVENTS } && !event.cancel_bubble() {
            let mut el = target;
            loop {
                el = match el.parent_element() {

ought to be
        if unsafe { BUBBLE_EVENTS } {
            let mut el = target;
            while !event.cancel_bubble() {
                el = match el.parent_element() {

Steps To Reproduce
Using this simple program:
use yew::prelude::*;
use gloo_console::log;

struct Demo;

pub enum Msg {
  OuterClicked(MouseEvent),
  InnerClicked(MouseEvent)
}

impl Component for Demo {
    type Properties = ();
    type Message = Msg;

    fn create(_ctx: &Context<Self>) -> Self {
        Self
    }

    fn update(&mut self, _ctx: &Context<Self>, msg: Self::Message) -> bool {
        match msg {
            Msg::OuterClicked(_) => {
                log!("Outer clicked");
                false
            }
            Msg::InnerClicked(ev) => {
                ev.stop_propagation();
                log!("Inner clicked");
                false
            }
        }
    }

    fn view(&self, ctx: &Context<Self>) -> Html {
        html!{

                    {"Some text"}

{"And then a nested div"}

        }
    }
}

fn main() {
    ::yew::start_app::<Demo>();
}

Click on "Some text".  Observe it logs "Inner clicked".
Click on "And then a nested div".  Observe it logs both "Inner clicked" and "Outer clicked".
Change yew's code as described at the top.
Now clicking "And then a nested div" logs only "Inner clicked".

Expected behavior
Propagation should be cancelled even if the listener is not attached to the innermost element of the DOM element to which the event was first delivered.
Environment:

Yew version: master
Rust version: 1.56.1
Target, if relevant: wasm32-unknown-emscripten (probably not relevant)
Build tool, if relevant: trunk (proably not relevant)
OS, if relevant: Linux (probably not relevant)
Browser and version, if relevant: Firefox 94.0.2

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[X] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

If you the maintainers like the fix described at the top I can turn this into a pull request.  Or you can do it if you'd rather avoid a roundtrip.  Alternately, if this isn't the right change and you can describe how it's wrong, I can create a PR with the right change instead.

@rjmac

If you the maintainers like the fix described at the top I can turn this into a pull request.

If you the maintainers like the fix described at the top I can turn this into a pull request.

@rjmac Good catch and yes please! :D


golangci-lint fails usually

Proposal
There are several failures produced by timeouts in golangci-lint task:

https://github.com/kedacore/keda/runs/4359169018?check_suite_focus=true
https://github.com/kedacore/keda/runs/4356029088?check_suite_focus=true
https://github.com/kedacore/keda/runs/4354674889?check_suite_focus=true

All of them with similar error:
Run golangci against the code...............................................Failed
- hook id: golangci-lint
- exit code: 4

ERRO Timeout exceeded: try increasing it by passing --timeout option

Maybe the code base is big and we should increase the timeout to avoid the error.
We can re-run failed jobs but for contributors could be confusing and frustrating, specially if they are new and don't know about this :(

Yeah, we should fix that. The current timeout is 5m though. I am gonna try to extend it to 10m.


[tool] XCResult also parses "url" in xcresult bundle

XCResultParser will also parse the "url" and convert them into a more readable string:
From
file:///foo.swift#CharacterRangeLen=0&EndingColumnNumber=82&EndingLineNumber=7&StartingColumnNumber=82&StartingLineNumber=7.
To
file:///foo.swift:7:82

Fixes https://github.com/flutter/flutter/issues/95036
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman Updated per review comments. PTAL


PR#319 Cleanup

Cleans up code from https://github.com/void256/nifty-gui/pull/319
As checked in, mvn clean install fails as the module referenced in the parent pom is incorrect.

Removes Eclipse files
Corrects the name of the soundsystem referenced in the parent pom

Oh, you already beat me to it :)

Hehe ... but only by a couple of seconds :wink: Thanks :smile:

Werid. Mvn clean install didn't fail for me when I ran it. Which module did it fail on?


chore(master): release 3.3.0

:robot: I have created a release beep boop
3.3.0 (2024-08-02)
Miscellaneous Chores

release 3.3.0 (3a37563)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/InformaticsMatters/squonk2-data-manager-ui/releases/tag/3.3.0 :sunflower:


OCM, Object Content Mapping (feature request)

Feature to persist models/pojos to JCR.
Basically, right now we can only map JCR content to models (using Sling models), but there is no way to create JCR content based on our model structure.
Available Solution:
Jackrabbit OCM
Issues with Jackrabbit OCM:

No direct bundle is provided, need to embed and configure multiple jars
Need to work on low-level Node APIs.

It will be a great add on if we can have OCM for AEM/Sling like we have ORM for SQL.
Ongoing thread on the community - https://experienceleaguecommunities.adobe.com/t5/adobe-experience-manager/persisting-sling-model-ocm/qaq-p/301637

Have a look at the stuff that was added in https://issues.apache.org/jira/plugins/servlet/mobile#issue/SLING-8450

Thanks, @henrykuijpers. This looks good to me,


flags: allow to mix --long and --tree

This is a feature that I'd love to have in lsd.
I just recently discovered lsd ~a few weeks ago.
I'm not a Rust developer, this is the first time I do some so feel free to criticize, I just want to suggest the solution.
Refs: #185
Closes: #204

Hmm, looks like clippy is complaining about that code. This should be good.
        let depth = match self.flags.layout {
            Layout::Tree { .. } => self.flags.recursion_depth,
            _ if self.flags.recursive => self.flags.recursion_depth,
            _ => 1,
        };

oh yeah I didn't see your answer, thanks ahah


Add rule to detect <a href> with paths (relative or absolute)

In a Remix app, ideally any intra-app links should be done with <Link to> so as to avoid full-page loads.

@zwily give the remix-react-routes/use-link-for-routes rule a spin in 1.0.4 🥳


Bump fails when run on the very first commit in a repository

If a new repository is based on a template containing a workflow with this action, it may end up being run on the very first commit. However, since that commit is not based on a PR it causes the action to fail. It would be nice if it could instead emit a default version number or at least have the option of doing so. Perhaps it could be configurable: some option that does nothing if unset or emits the specified value if run on the first commit.

The intended behavior of the action is to ignore anything that doesn't look like a pull request merger. Can you provide an example of the error(s) you're seeing in the scenario you described?

I suppose as a general rule it's understandable that no version is assigned without a PR since it would be impossible to know whether it should be a major, minor, or patch bump. However, the original problem still stands: new repositories created from templates that include this action fail on their initial commits when they otherwise would succeed. Perhaps the appropriate behavior under these conditions would be a no-op.

Thanks for linking to an example. This is likely a bug then. The action should effectively be a no-op when not running in the context of a merged pull request.
I will investigate and resolve this over the weekend.


ParameterState: Add ParameterChangedEventArgs to get previous and current value

Description
This change should be cheap, we already always call HasParameterChanged when handler is supplied, and it was already receiving the new value from the ParameterView in the ParameterViewExtensions.HasParameterChanged it was just never returned back before (discarded).
So basically only one null check was added which is cheap and storage of the ParameterChangedEventArgs in local variable.
Changes:
Made MudComponentBase as partial and split to MudComponentBase.RegisterParameter.cs.
To enhance the structure as the number of overloads increases it's better to add the registration overloads to separate partial class, I also added regions. While I typically dislike when people use them, but it's due to reason that they add no value regions like: "private field", "constructor", "static" - those are boilerplate.
In this case, I find their usage justified:

NB! Same was added for ParameterState.cs:

Made ParameterChangedEventArgs optional for anonymous functions or method groups.
While it adds more boilerplate code and overloads we do not break existing code, now we have the flexibility to have method group with the EventArgs or without.

How Has This Been Tested?
Adopted existing unit tests.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

@henon if you want, you can add bUnit test, I didn't test full chain, just on parameterset / parameterstate level.

@henon I added in this PR IParameterState and changed the components to use it.
It would allow us to quickly make this public API. Also it exposes only two functions SetValue and Value, so you don't see all the property / method garbage that you actually shouldn't see / use, it's for internal use inside the ParameterSet.
But let me know if I should revert this last commit.

Great, I am looking forward to adding a bUnit test and yes, I would want to make the minimal API public/protected so that users can use the framework when they derive their components from MudComponentBase

Will expose when we will use it in couple of more components.
Going to wait for your bUnit test and merge.


[AvroToOrc] Fix valiation job

The list of destination formats is not provided from the job props. It is available from the config store.
@abti can you review?

LGTM


Initial Commit For Send-Slack-Message-Webhook

Required items, please complete
Change(s):

Adding Send-Slack-Message-Webhook Playbook

Reason for Change(s):

Adding feature

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @ZLT-ops,  thanks for this contribution!
Is this playbook different then this by allowing the Slack user to interactively response from Slack?
Can you also add screenshot of how the Slack message looks like?
If you want this playbook to be shared in the playbook templates tab, please add also the metadata and screenshots. (the screenshot you shared has an issue in the trigger component)
https://github.com/Azure/Azure-Sentinel/tree/master/docs/New Playbooks Contribution Guide

@anki-narravula Please review playbooks. Thanks.

Only comment is that the card says "close alerts", while you cannot close alerts in Sentinel, you are probably closing the incidents :)

Please change the action titles in the card:

the card says "close alerts", while you cannot close alerts in Sentinel, you are closing the incidents
Please change the term "whitelist" to "allow list" or something similar :)

Please fix the screen shots to show the trigger (currently it shows an "connection" error instead of its title
I added some fixes and metadata so we can show this in playbook templates tab

@ZLT-ops please update the requested changes. thanks!!!

@anki-narravula Please check and approve the requested changes. thanks!!!

@anki-narravula Please check and approve the requested changes. thanks!!!

Any updates on the approvals ? @vmanojreddy @anki-narravula

@anki-narravula Please check and approve the requested changes. thanks!!!

@anki-narravula Please check and approve the requested changes. thanks!!!

@anki-narravula Please check and approve the requested changes. thanks!!!

@anki-narravula : Please check and approve the requested changes. thanks!!!

@anki-narravula :  Please check and approve. thanks!!!


.m3u8-tunneling stopped working.

Edit
After putting up the streams yesterday (below) they're useless today 13 dec.
Maybe there's a connection.  Let's see about tomorrow.
24/12
For the moment this is no longer an issue as they've changed back to the old tunnelling again.
Comment
These:  [http://adryanlist.x10.mx/nescafe.php?cm=3704]
[http://adryanlist.x10.mx/nescafe.php?canal=HistoryLA&cm=3704]
[http://adryanlist.x10.mx/nescafe.php?cm=4043]
[http://adryanlist.x10.mx/nescafe.php?canal=News12Connecticut.stream&cm=4043]
opens in in VLC, and if not; by being forced, but as they produce .m3u8-streams (as you will see   through URL Helper or the like) they would work better through Livestreamer (not as heavy).
The result could look something like: [http://lb.iptvserver.tv:8080/redirect/LiveEdge/News12Connecticut.stream/playlist.m3u8?token=465f4cf7ec9f6a06f1b2fc3e65030cab].
I've tried the possible three (or two) ways and also con-jointed with
--player-continuous- --retry-streams 1 –retry-open 86400, is there anything else ?
[cli][error] Unable to open URL: http://adryanlist.x10.mx/nescafe.php?canal=Hist
oryLA&cm=3704 (403 Client Error: Forbidden)
Similar MRL's like [http://www.jdmsociety.net/ST/4043.m3u8] has produced the wished for
.m3u8-stream, -s  result earlier through Livestreamer.
Have also put this on the ”Testing of .m3u8 streams. #673”-thread

The 403 error usually means that you need to pass a cookie or other request header to make the server believe that you are requesting it through normal means (i.e. a web browser).

The 403 error (Forbidden) is a "permission denied" error usually indicating that you need to pass some additional headers with your request -- possibly a cookie or other request headers.  You can find out exactly which ones if you use Chrome or Firefox F12 Developer tools and then watch the network traffic as the original page loads.  If you can find the m3u8 request in there, you'll also see the headers that are passed along with it -- including cookies.


Fixed the cli to include --skip-cask-deps to skip all casks dependencies

I changed the cli include --skip-cask-deps since the installer have this option to skip all casks dependencies

Needs documentation in the man page. Once you've edited that, run bundle exec rake man, stage the changes to both doc/man_page/brew-cask.1.md and man/man1/brew-cask.1, commit and push.

Merged in a3cbde0bb33e89756bc8e50efac531d3eafa10a3.


Implement request 'get_team'

List team members in organisation X.
Example input: "Who is working in my organisation <name>?"
Request

Associated functional requirement: 3


Un-compatibility with<EMAIL_ADDRESS>

I just try on<EMAIL_ADDRESS>with<EMAIL_ADDRESS>it seem to be un-compatibility.  didn't pass router store to child component.
After downgrade react-router and react-router-dom pacakge version (@^4.3.4) everything working fine again.

I'm trying to fix this issue and PR (If i'm not too busy), looking for any reply.
Originally posted by @genexu in https://github.com/supasate/connected-react-router/pull/273#issuecomment-478523354

When I ran into this, it was because react router and react router dom did not have the exact same version.  Double check you did.

I'm having a similar error. I resolved the You should not use <X> outside a <Router> for <Route>, <Switch>, <Redirect> by changing my imports from react-router-dom to react-router, however I can't figure out how to resolve the error for <Link>s
Versions:
"connected-react-router": "^6.3.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-redux": "^7.0.1",
"react-router": "^5.0.0",
"react-router-dom": "^5.0.0",
"redux": "^4.0.1",

Can you do a yarn why or npm version to check the version of react-router and react-router-dom? Make sure not multiple version is installed.  You can also remove node_modules and reinstall.

They're definitely the same version. Just did a clear out and reinstall of node_modules and am having the same error

I can't fully say what fixed it, but I deleted my package-lock.json and reinstalled (fixed some new bugs that were introduced) but then got this working.

I ran into the same error for <Link>, and what worked for @thehig also worked for me.

i too had to delete package-lock and reinstall to get it to work


fix: Post forking an application without the first page the application ends up having pages with page name as the page id

Description
When you fork a template by selecting pages to fork and if you don't select the first page. The application still ends up having all the pages. Also, the pages which were not selected seem to have the page name as the page id. We see the page not found error on the frontend when the invalid page(the page which has the page name as the page id) ends up being the default page. Also, it looks like it is being set as the default page automatically post forking on the backend.
The response of GET api/v1/applications/new returns the unselected page(Dashboard) in the page list of the application. Also, it is set as the default page and you can also see that the page id is the name of the page. Since it is set as the default page it tries to go to that page id on edit, but the page id is clearly invalid. The core issue is the reference inside the application.pages and application.publishedPages which was not updated based on the pageToImport parameter. Only the pageList in the JSON was updated after filtering.
Fixes #17383
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally
JUnit Tests

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test

/ok-to-test sha=cd67f89

/ok-to-test

/ok-to-test sha=cd67f89

/ok-to-test

why  I can't fork the template into a existing app?  i run appsmith v1.9.6


Web UI/UX improvements

Add favicon.png
Home: Serge svg icon from Discord
Navbar: Colors and svg icons.
Chat: Avatars svg icons, header and input style

@pabl-o-ce Whats the source/license for the llama icon?

@pabl-o-ce Whats the source/license for the llama icon?

Llama by The Icon Z from Noun Project

loading

MD render and copy to clipboard

code block background adapts to themes

Ok I'm reviewing this for real now I promise

I'm currently reviewing it, it's quite a big PR so in the future I think it would be better to break up changes into multiple PRs.
For example for this one you could have broken it up into:

Restyling of the chat bubbles & sidebar
Change in icons
Adding code blocks in answer
Adding copy button to code blocks

They could all have been separate PRs which would have made it easier to get it through the review process, as I can review, approve or request changes on smaller chunks, one at a time :smile:
I also think it's good practice to file an issue before starting a PR (for big changes), that way we can discuss it before you spend too much time working on something where maybe we're not aligned on the requirements.
Otherwise it's a great PR, thanks a lot, especially the code blocks are amazing. I'm taking the liberty to refactor some stuff here and there in the PR and I will merge it when I'm done. Thanks again for the contribution and sorry it's taking so long!

Hi @nsarrazin
Thanks for accepting the PR.
I think it was a inspiration moment in your discord channel and also getting feedback from there (meeting great people in your channel).
Really wanted to help, contribute and just enter in that mode.
I apologize if the PR was all included in one and also without generating a issue as a normal person will do it. Love the idea to have a discord channel for a popular project so people can get related to it. I think that lost me in generating the issue and follow the good practice.
If you need to change something or don't go with the aligned of your idea feel free to change it [my intentions was for help]. All just began when I just wanted to learn svelte with your project as a starting point and also learn to use Llama.cpp with Python. The avatar icons can be very inappropriate or just don't wanted at all.
Thanks for this amazing idea! 🙂

May want to rebase the branch 😁

@nsarrazin @pabl-o-ce Whats the plan with this PR? It would make serge look way better!

Hi @gaby,
Yes I want to keep contributing 🙂
Just waiting to @nsarrazin to finish integrating this PR
I think he is busy of what it told us in chat [I'm just waiting patient]

@pabl-o-ce Can you fix the merge conflicts

@pabl-o-ce any idea?

@gaby and @greenfoo this changes are only on the front-end.. I think is because of the changes on ggml of llama.cpp

test it haha let me refresh my models (in this one I'm using theBloke) https://huggingface.co/TheBloke

@gaby done I remove it a put it like this


Auto disconnect fails after screen lock/unlock

Describe the bug
I am experiencing an issue when I lock the phone screen during an active live session and then unlock it to return to that session.
Steps to reproduce:

Open a live session as a viewer.
Lock the screen.
From another device as the host, close the session.
Unlock the screen.
At this point, the user should be disconnected automatically, but this does not happen despite the on.disconnect listener being implemented, which should trigger navigation.back.

I suspect that onDisconnect is not being called because the app is in a background at that point.
I am looking for any solution that would allow to identify the connection status after coming back to the app so I can take user from that screen.
useEffect(() => {
    const handleDisconnected = () => {
      router.back();
    };

    room.on('disconnected', handleDisconnected);

    return () => {
      room.off('disconnected', handleDisconnected);
    };
  }, [room, router]);

Screenshots

Device Info:

Device: iPhone 15 Pro
OS:  17.5.1

Dependencies Info (please reference your package-lock.json or yarn.lock file):

@livekit/react-native: 2.3.1
livekit-client: 2.0.10 (fetched by @livekit/react-native)
react-native-webrtc: 114.1.6

I would be really grateful for any help regarding this.

I am still having this issue :(


Issue43 multivarapi

@JrtPec  can you check if this solves your remarks?
Mind, the notebooks in this repo should be removed, uses the notebooks in https://github.com/opengridcc/opengrid-demo/tree/master/notebooks

Coverage decreased (-0.3%) to 93.079% when pulling bbfbee4ef672d4f94ec0c6d93f90e05671c13622 on issue43_multivarapi into 51805b0660661d08840b18452245313ca8ebc3d7 on master.


Guide to Project Workflow

Thank you very much for your excellent work, Could you please add the Guide to Project Workflow, Can I add a simple workflow？

Hi, thanks for reaching out! I'm sorry for not seeing your message and getting back to you sooner. We're currently working on making the code easier to run for anyone, so there should be updates regarding this on the main branch shortly and I will let you know once we have updates.
I hope this makes sense and that the code being open can still be of help despite not being straightforward to run out of the box yet.
Best, Lars

Hi, again!
Sorry for not getting back to you sooner—I was sure I had reached back out...
We're not fully there yet, but the dataset and code for training the BC policies are there—and the rest is on the way.
Best, Lars

Thank you very much for your reply