[multikueue] Use batch/Job spec.managedBy field.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Relates to #693
Special notes for your reviewer:
Use spec.managedBy to detect delegatable jobs.
Enable live status updates for batch/Jobs.
No longer keep the multikueue admission check state Pending when the job is running in a worker cluster.
Does this PR introduce a user-facing change?

Use batch/Job `spec.managedBy` field in its multikueue integration.

/assign @mimowo

@alculquicondor @mimowo  @mwielgus
We could keep the old integration approach by putting the spec.managedBy support under kueue featuregate (say MultiKueueBetchJobWithManage) WDYT?

@alculquicondor @mimowo @mwielgus
We could also keep the old integration approach and put the spec.managedBy support under kueue featuregate (say MultiKueueBetchJobWithManage) WDYT?

+1 sounds like a good idea.
It will let users configure kueue according to their k8s configuration. Yet, we will not introduce API configuration which may turn out unnecessary over time.

@trasc Thank you for responding to my questions. It seems that I missed reading codes somehow.
Now, everything is clear. So feel free to close my thread.

@alculquicondor @mimowo @mwielgus
We could also keep the old integration approach and put the spec.managedBy support under kueue featuregate (say MultiKueueBetchJobWithManage) WDYT?

SGTM

I think we should also have defaulting of managedBy field for Jobs, as we do for JobSet. when the feature gate is enabled.
@trasc would you like to extend this PR or follow up?

Foillow-up I think @mbobrovskyi  has some experience around this topic.

/lgtm
/approve

/release-note-edit
MultiKueue: Use batch/Job `spec.managedBy` field


Update RKE Downstream cluster failed: Not a valid ECR registry, requeuing

Rancher Server Setup

Rancher version: 2.6.3,2.6.2

Describe the bug
Enabling private registry should not add ecr_credential_plugin by default
To Reproduce

Install Rancher v2.6.2 or v2.6.3
Deploy an RKE cluster
Enable private registry after deployment and check the registry setting
Cluster manager -> Edit config -> Enable private registry   Cluster manager -> Edit config -> Enable private registry
For testing purpose , set it as registry.hub.docker.com
Apply the spec
Cluster manager -> Edit config _> View as YAML
The private registry adds ecr_credential_plugin even though we didn't specify it

Result
The private registry adds ecr_credential_plugin even though we didn't specify it
Expected Result
The ecr_credential_plugin is not on our registry
Additional context
Troubleshooting steps:
Tried to remove the ecr_credential_plugin , but it came back after reconciliation
Tried with both UI and YAM, but still, ecr_credential_plugin appeared in the private registry
SURE-3873
SURE-3997

The bug is reproduced in v2.6.3
when updating a cluster via Rancher UI, the following values are added in the payload of the PUT request to the endpoint v3/clusters/c-smz6w?_replace=true
rancher_kubernetes_engine_config:
  ...
  private_registries:
    - ecr_credential_plugin: {}
      is_default: true
      url: registry.hub.docker.com

The following is in the response:
rancher_kubernetes_engine_config:
  ...
  private_registries:
    - ecr_credential_plugin:
        type: "/v3/schemas/ecrCredentialPlugin"   <--------- Here the problem is!
      is_default: true
      url: registry.hub.docker.com

Error in Rancher UI
This cluster is currently Provisioning.

Not a valid ECR registry

The bug cannot be reproduced in rancher:v2.6-head e7f03fd
I guess it might be fixed by other changes in the release-v2.6 branch, such as bumping the version of dependencies and packages.
Move it to test.

hmm, I can reproduce this on both 2.6.4-alpha3 and 2.6-head(c682e30).
steps to repro:

provision rke1 cluster (1.22.5)
wait for cluster to come to active state, then edit the cluster

enable and add something to the registry field
edit as yaml, user can see the following:

rancher_kubernetes_engine_config:
  ...
  private_registries:
    - ecr_credential_plugin: {}
      is_default: true
      url: registry.hub.docker.com

save changes to the cluster -- The following is in the response:

rancher_kubernetes_engine_config:
  ...
  private_registries:
    - ecr_credential_plugin:
        type: "/v3/schemas/ecrCredentialPlugin"   <--------- this is the issue
      is_default: true
      url: registry.hub.docker.com

Error in Rancher UI
This cluster is currently Provisioning.

Not a valid ECR registry

cluster is stuck in updating state

tested the following on v2.6-head (3e482df):
(pass == cluster does not fail to update the cluster with anything related to ecr failing to pull/requeuing)

create a new RKE cluster with a private registry  -- pass
create a new RKE cluster without a private registry  -- pass
edit an existing RKE cluster to enable private registry ( target cluster -> Edit Config -> Edit as YAML) -- pass
edit an existing RKE cluster to change the URL of the private registry ( target cluster -> Edit Config -> Edit as YAML) -- pass
edit an existing RKE cluster to disable private registry ( target cluster -> Edit Config -> Edit as YAML) -- pass

found while testing: https://github.com/rancher/rancher/issues/36517

Steps for a workaround:

Wait for the current edit/upgrade to be finished. This can be confirmed by seeing all pods under the namespace cattle-system, ingress-nginx, and kube-system are active and using the image from the private registry.

Meanwhile, the UI should show  the cluster in the Provisioning state with the error message Not a valid ECR registry, as the following screenshot shows

Now we can edit the cluster, choose edit as YAML, and remove ecr_credential_plugin: {} from the entry under private_registries

Click Save to apply the change

The cluster should go to update and become Active shortly

/backport v2.6.3-patch3


Mark v0.1.4 as latest in npm

v0.1.4 is the last known working version; it shuold be tagged as latest so that npm install pjax will fetch that.
npm tag<EMAIL_ADDRESS>latest

Done
That said,
npm WARN tag This command is deprecated. Use `npm dist-tag` instead.


SimpleAPI and SYSTEMTIME identifier Unidentified

First I want to apologize if this is a horrible place to ask this. However I am working with the source code from libE57 and the project compiled up to the Foundation API. I seem to have major difficulties when adding in the Simple API with their instructions. I am getting a lot of identifiers undefined . One of the first ones to show unidentified is "SYSTEMTIME". I am curious if you could give some tips on how to properly add in the Simple API source...

First I want to apologize if this is a horrible place to ask this.

No problem at all.

I am working with the source code from libE57

Are you trying to use the code from this repo (libE57Format) or from the reference implementation on SourceForge (E57RefImpl)?
Either way I haven't looked at the "Simple" files, but if you're using libE57Format and can give more information (what compiler, what OS, the actual errors your getting), I might be able to see if it's something I changed in the API.

I am working with the Foundation API for the E57RefImpl at the moment. I was hoping the Simple API would help solve some of the challenges I was facing. After working with the API, i guess Im looking more for advice on how to pursue the effect I am looking for.
I have 2 E57 files. One is the "Original" file. This contains imagery and colored data and works in all platforms tested (recap, scene, cloudcompare, cyclone, etc.)
Then I have a second file, "Modified" that is exported from CloudCompare. However this file has issues with Intensity scaling as well as the images that are used for bubble views resulting in other platforms being unable to display the bubble views. The only platform that seems to still be able to display bubble views is Cyclone on this file.
So my intention is to create a third file "Frankenstein", that takes whatever changes were applied to "Modified" and inject the corresponding pieces of remaining elements/nodes from "Original" to create a third file that has the modifications but keeps the correct structure and parameters to still display the bubble views properly and display the intensity at a visually appealing scale.
Would you have any thoughts on how to pursue this? In particular, thoughts on how to obtain the imagery data/components from the "Original" file and apply them to "Frankenstein"?

However this file has issues with Intensity scaling as well as the images that are used for bubble views resulting in other platforms being unable to display the bubble views.

Isn't this a bug with CloudCompare's E57 support then? i.e. if it's fixable in CloudCompare would it alleviate the need for your "Frankenstein" workaround?
Just wondering if it makes more sense to try to fix the issue in CloudCompare rather than work around it with an extra tool.

I think a 'clean' solution would be to save all the data / pieces of information that are not managed by CloudCompare as 'meta-data' attached to the loaded cloud(s). Then when the cloud is exported back to E57, process all the pieces of meta-data and write them to the file.
However it might be a huge work, I'm not sure.

@cwzelus If you decide to go with creating your tool, this PR from @ptc-jhoerner might be of interest.
He is bringing the "Simple" API from the old ref implementation to libE57Format.

@cwzelus The "Simple API" has been added this library. That might help your work.
I would still suggest that if CloudCompare is producing E57 files that are not valid or not working in other software, then that should be reported as a CloudCompare issue with a sample file and steps to reproduce so it can be looked at there.
Please feel free to re-open this issue if you want to continue the conversation.


Unwatch when autoresuming

Hey @HackedByChinese ,
We have a use-case that requires a user interrupt to unwatch.
Here is our implementation + specs.
Do you have any interest in accepting this upstream? I'd happily update the docs.
Any more info you need from us?

So this is like a reverse idle?

We're using it for playing notification sounds:

When a notification comes in, we play a sound and start Idle.
If the user gets into IdleStart after 5 minutes, we play a reminder notification.

What the unwatch ability lets us do is upon receiving a user interrupt we can now treat the original notification as "seen" and avoid sending a reminder notification.

I think we sent this PR a little early... We have one more issue to work through that might not be upstream compatible. I'll get back to you.

@HackedByChinese -- This is ready for consideration now.


Write blog post about unconference

repurpose the post from 2017

draft started and open for comment - https://docs.google.com/document/d/1_PGto4BpgB6qOB6b2y1P8ZkFRGa-Zg_iQdQcTDinnXU/edit?usp=sharing

@jcwlib this will need a second set of eyes, as I've added some new material. but good to go from my side.

@jhibbets - I like the new material.  I made some small edits - i've saved as a draft on website and will post next week.


feat: update resources to schema v4.19.0

:tada: This PR is included in version 5.21.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Code Structuring : the contributors made the repo dirty and hard to understand for new contributors! Structure the code in a good manner!

You can work collaboratively with multiple contributors everyone will get PR merged with L3 GSSOC!

I want to work on this issue. Please assign it to me.

I want to work on this issue. Please assign it to me.

work on it! you can always reach out to me for any help!

I want to work on this issue ,please assign it to me @huamanraj

I want to work on this issue ,please assign it to me @huamanraj

you can work collaboratively with @komalverma04

Please assign it to me @huamanraj

I will like to work on this issue, can you please assign this issue to me?


Rotation invariant brief

Added rotation invariance to the BRIEF descriptor. The approach is explained and evaluated in the following my blog post:
https://gilscvblog.wordpress.com/2015/01/02/adding-rotation-invariance-to-the-brief-descriptor/
The descriptor itself is implemented in opencv_contrib (I'll make a separate pull request), in the opencv repository I only added a tutorial.

Hi @GilLevi! Basically you used TABS for indentation and the buildbot cannot handle that. You need to replace each tab by 3 spaces. Then the documentation bot will run just fine!

Thanks, @StevenPuttemans ! I'll fix that.

@GilLevi, since the different solution has already been integrated in Itseez/opencv_contrib#207, I think this PR can be considered obsolete.
I'd suggest to transform this to sample application in xfeatures2d/samples folder or to tutorial (xfeatures2d/tutorials) + sample application (xfeatures2d/samples).


Can i make it with pi pico w board

Is it possible to hook up the modules like RFID sensor CC1101 and oled display with raspberry piko w board and connect ESP 32 as well with wires and program both board separately by using their USB port or we can only use PCB version of this flipper zero

Hi, yes, you can buy the boards separately and it will work. This project just build in one board different development boards. You can find more info on the hackster project.

Ok. But where is the code file

Tou can use Arduino libraries for all the components of the board. I do not provide the code because I just tested all the peripherals but I don't have an application code


NetworkPolicy Evaluation E2E Tests

The PR will add E2E tests for networkpolicyevaluation introduced in #5740 .
This framework design and test example is for discussion before moving on.

Current Design

Adds flag --networkpolicy_evaluation="" or "basic" or "extended" when running e2e tests.

"": evaluation will be skipped
"basic": only a few number of evaluation test cases marked "basic" will be run
"extended": all predefined evaluation test cases marked "basic" and "extended" will be run (perhaps periodically on Github)

For each Antrea Policy test case, if we want to add evaluation test cases, create an npEvaluation matrix initialized with no test. expect with 1) from, 2) to Pods, 3) the expected NetworkPolicy name, 4) and the level of the test case "basic" or "extended"
When executing test cases, go through the evaluation matrix for evaluation tests to run. Use antctl remote access.

Work left

Review every Antrea Policy e2e test cases to add suitable evaluation test cases. Similar to the example given.
Add flags to scripts.

Hi @Dyanngg @tnqn @antoninbas , this is the framework for E2E tests of networkpolicyevaluation, I've included an example in ACNPPriorityOverride. Could you help pre-review the design before I add more test cases based on this? Thanks!

However, I do not understand why we want 2 different levels (basic vs extended). I think that just a boolean toggle would be good enough. We can choose to run e2e policy tests with or without NP evaluation.

The idea was for "basic" tests, we run them triggered by each PR, for "extended" tests, we run them periodically to reduce test workload (since probing antctl for each evaluation adds to the time cost). How does that sound?
For each antreapolicy test, there are ~9*9 possible pairs to evaluate, we could pick one of the directly matched pair for "basic", some others for "extended" (pairs not matching the NP should return empty, other matched pairs should return correct NP etc.)

The idea was for "basic" tests, we run them triggered by each PR, for "extended" tests, we run them periodically to reduce test workload (since probing antctl for each evaluation adds to the time cost). How does that sound?

The problem with periodic tests is that people rarely check them or act on failures.
How much time would it add concretely? I don't think we have to check every single pair for each subtest.

The idea was for "basic" tests, we run them triggered by each PR, for "extended" tests, we run them periodically to reduce test workload (since probing antctl for each evaluation adds to the time cost). How does that sound?

The problem with periodic tests is that people rarely check them or act on failures. How much time would it add concretely? I don't think we have to check every single pair for each subtest.

Sure, I'll first make some must test cases, run them on a binary condition. If they cause too much latency, we can then split them for extended.

Depends on #6218 and #6217

so what was the impact on test runtime?

Compared with other Kind E2E tests, there is no significant impact, within seconds.

/test-e2e


Add CLA completion link in contributing doc

Add the CLA completion link in contributing.md, with others details about complex PR.
I had to complete the CLA and it was difficult to know what the procedure is. On google, you'll find multiple links and posts, all wrong or obsolete : https://www.google.fr/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=CLA+microsoft+github&start=0
The only one good information I found was here : https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md

Hi @AdrienTorris, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, DNFBOT;

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

CONTRIBUTING.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@tdykstra  please review.  Should we link to https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md?

@Rick-Anderson I prefer to leave here the direct link to cla2.dotnetfoundation.org.  The aspnet/home/contributing.md is more about contributing to the product than the docs.

@tdykstra  OK.

@tdykstra  is this ready to merge?


Add new switches

Make it possible to hide the help menu when loading, and also hide the source selection bar.
This already includes the documentation commit from https://github.com/SVT/vivict/pull/6 (e5c5e98b3fbc1befdc1d2e9342f889e50d642393).

I had to think about this, but I think @grusell would approve of the feature. Let's have merged. Thanks

Thanks, much appreciated! It's not enabled by default anyway. I should have maybe explained the use case a little more … when using this to present videos to naive users, you may not want to give away the source file location or allow too much interactivity. There might be other features that could be helpful for actual subjective testing, but with these two options, I could do 99% of what I wanted already.


ActiveMQ classic hosting

Please advice on how to proceed with this PR.
Regards Arno Noordover
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service agree

https://activemq.apache.org/

Any chance we can get this reviewed? Would love to use this ASAP.

From https://github.com/dotnet/aspire/discussions/6694#discussioncomment-11278840 it looks like this should move into the Aspire CommunityToolkit instead

Merged dotnet/aspire main to this branch.
@davidfowl should I try to migrate this to the CommunityToolkit (see https://github.com/dotnet/aspire/discussions/6694#discussioncomment-11278840)?
Do you have any advice for me migrating this to the CommunityToolkit?

https://github.com/CommunityToolkit/Aspire/issues/253?

Moved this to community: https://github.com/CommunityToolkit/Aspire/pull/273
I will close this PR.
Thank you for your feedback.


Declared function is different in output

Hi, today i wrote something like this in TS:
declare function output(message: String): Boolean;

output("fdsa");

then i compiled this into:
--[[ Generated with https://github.com/TypeScriptToLua/TypeScriptToLua ]]
output(nil, "fdsa")

Why is there first parametr to "nil"?
My tsconfig.json:
{
  "compilerOptions": {
      "strict": true,
      "target": "es6",
  },
  "tstl": {
      "luaTarget": "5.2",
      "luaLibImport": "inline",
  }
}

By default, all transpiled functions receive an initial 'context' parameter. This is for compatibility with how Typescript/Javascript work. There's a Wiki page that discusses the issue, although it needs some work: https://github.com/TypeScriptToLua/TypeScriptToLua/wiki/Functions-and-the-`self`-Parameter

/** @noSelfInFile */

This thing above helped 👍. Is there any way to disable it by default because I don't want to write this comment for every function i declare?

Currently, that's the simplest way to do it. Perhaps a tsconfig option to do it project-wide could be added.

Why would you need to add it for every function? @noSelfInFile enables it on all functions in file.

Ok, good. I read that i don't need to add it to every function which is nice. I can write it only once which is nice. Thanks for anything ✌


Remove username from users table

Remove username from users table and just use email for user identification. This is to keep things simple.

If someone wanted to work on this issue, they would need to remove this line
    username CITEXT UNIQUE NOT NULL,

from the users table in config/postgres/initdb/scripts/create-tables.sql, correct?

@ash-tamraz Yes, that is correct.

This change also requires removing all occurrences of the username field and replacing any occurrences with user email as the login handle. There are instances in the files
src/backend/expungeservice/endpoints/users.py
src/backend/expungeservice/endpoints/auth.py
src/backend/expungeservice/crawler/crawler.py
src/backend/expungeservice/crawler/request.py
along with their test cases and the design doc.
As far as I can tell there are currently no endpoint calls in the frontend that would be affected by this change, is that right?

Most applications refer to the variable username even when the value being used is an email address. In our case an email address is a username. Username/password combination is needed to login. I suppose the files could be updated to state it's a user_email, but that doesn't necessarily convey that the variable is actually a username for login. I suppose the context it's being used in would imply that. I guess I'm saying I don't think it's necessary to make those change. What do you think?

That makes sense. Though it seems not ideal to have the two fully redundant fields in endpoint data objects. If they're the same value there should only be one field.
I also realized that the occurrences of username crawler.py and request.py actually refer to the Oregon site's login, so would not be affected by this.

Sounds good!


关于性能问题 about performance

打开界面，关闭后，即使没有在mod，仍然会消耗cpu（即使没有查看）/‘
when open world-preview GUI, and then closed, even mod not in use, it still will use CPU

Thank you for the report!
The issue has been fixed and there will be another update following shortly after the release of MC 1.20.3.
Only the in-game preview was affected, the one in the main menu was unaffected by this bug.

did will update for MC 1.20.1?

Yes, there will be 1.1.4 release for all versions.
On 5 December 2023 13:24:00 CET, HMwancheng @.***> wrote:

did will update for MC 1.20.1?
--
Reply to this email directly or view it on GitHub:
https://github.com/caeruleusDraconis/world-preview/issues/15#issuecomment-1840692497
You are receiving this because you are subscribed to this thread.
Message ID: @.***>


fix panic when log_level >= error

What does this PR do?
Fixes an issue that was making the agent panic when the log_level was >= error and a check was reporting a warning.
The recent refactoring to the logging system implemented the same interface as seelog to act as a drop-in replacement.
We failed to identify some weirdness in the seelog API and changed the behavior of a few methods :
https://github.com/DataDog/datadog-agent/blob/4ab39da9332d4520cbcb7db0e2dd3a610a4c1a88/pkg/util/log/log.go#L321-L345
seelog does not actually return a real error for this methods. Instead it returns the formatted log line encapsulated in an error. The returned value would never be nil.
We were using this behavior in a few places and particularly here :
https://github.com/DataDog/datadog-agent/blob/4ab39da9332d4520cbcb7db0e2dd3a610a4c1a88/pkg/collector/corechecks/checkbase.go#L51-L65
When the log_level was above warning, calling log.Warnf would return nil. This nil would be added to a slice that would later be used by a method and would trigger a panic :
https://github.com/DataDog/datadog-agent/blob/1739a162fbb0340ade38e764abbf635a54833d89/pkg/collector/check/stats.go#L69-L74
[ AGENT ] github.com/DataDog/datadog-agent/pkg/collector/check.(*Stats).Add(0xc4202de1c0, 0x3ce1, 0x0, 0x0, 0xc420a8a800, 0x1, 0x1, 0xc42060a6f0)
[ AGENT ] /go/src/github.com/DataDog/datadog-agent/.omnibus/src/datadog-agent/src/github.com/DataDog/datadog-agent/pkg/collector/check/stats.go:72 +0x204
[ AGENT ] github.com/DataDog/datadog-agent/pkg/collector/runner.addWorkStats(0x1cb91c0, 0xc420256070, 0x3ce1, 0x0, 0x0, 0xc420a8a800, 0x1, 0x1, 0xc42060a6f0)
[ AGENT ] /go/src/github.com/DataDog/datadog-agent/.omnibus/src/datadog-agent/src/github.com/DataDog/datadog-agent/pkg/collector/runner/runner.go:356 +0x10e
[ AGENT ] github.com/DataDog/datadog-agent/pkg/collector/runner.(*Runner).work(0xc420229ef0)
[ AGENT ] /go/src/github.com/DataDog/datadog-agent/.omnibus/src/datadog-agent/src/github.com/DataDog/datadog-agent/pkg/collector/runner/runner.go:301 +0x942
[ AGENT ] created by github.com/DataDog/datadog-agent/pkg/collector/runner.(*Runner).AddWorker
[ AGENT ] /go/src/github.com/DataDog/datadog-agent/.omnibus/src/datadog-agent/src/github.com/DataDog/datadog-agent/pkg/collector/runner/runner.go:100 +0x8a

Let's merge https://github.com/DataDog/datadog-agent/pull/1981 for 6.3.3 then


Resolve publishing of dependencies of Kabanero Operator to OperatorHub

Some of the dependent operators are not published to OperatorHub. We have several options:

Wait for the dependencies to arrive
Embed the dependencies into the Kabanero Operator
Fork and publish the dependencies

Some notes about what I've found so far:

Istio is available on operatorhub.io but not the Open Shift catalog.
knative-serving pre-reqs Istio (but the operator CSV does not require it, which is odd), and it's available only in the Open Shift catalog (which may be why the CSV doesn't require it)
knative-eventing is only available in the Open Shift catalog
openshift-pipelines is only available in the Open Shift catalog

So I guess a summary is all the requirements for Kabanero are in the Open Shift catalog, except that the requirements of the requirements are in the Operatorhub.io catalog.

The immediate plan is to publish into the OpenShift catalog.


allowUpscale documentation

In the docs, allowUpscale is listed under the global configuration settings here: https://github.com/aelvan/Imager-Craft#allowupscale-bool. However, setting this in imager.php under '*' doesn't seem to do anything. However, it does work if you create a transform and pass it as an option like this:
{% set imageSizes = [{ width: 530, allowUpscale: false }] %}.
Am I just misunderstanding the layout of the docs, or are they incorrect?

You can adjust the settings like this:
<?php
/**
 * config/imager.php
 */

  return array(
    'allowUpscale' => false,
  );

Ok, thank you.


New RAID GUARD System

About
This code was created in response to a raid that was done on a server that I am an admin. Over 100 people raided the server, and started sending messages, DMing people. It took us admins at least 30 min to realized that all these people were from all one raid, as we hadn't been pinged, or notified. That's when I came up with this idea of a monitoring system. This system will oversee all incoming members, if that member has an account that is younger than a certain age (1 day default), then they will be added to a database list. If that list reaches a certain amount of people (25 ppl default) within 10 min, then it will send a notification to the modlog. This notification will alert the admin (or a role of your choosing), and ask if they would like to kick/ban all of the RAID members at once. An option has also been  provided to manually reset the raid list. The program will run through the entire list and remove all raiders for good.
Status

[X] Code changes have been tested on an instance of YAGPDB, or there are no code changes
[X] I have read and followed the contribution guide

A few things missing:

Where is the mentioned role to be configured?
Would recommend adding a README.md as documentation, due to your PR being a system of commands, as per our contributing guidelines...
Could you indicate where the configuration areas are pointed out as well as where the code starts? Something like

{{/* Config Area start */}}
[...]
{{/* Actual code - do not touch */}}

This would make it a lot easier for potential users to install and set up.

I have now updated the formatting for the Join command trigger to be more user friendly. As well as I have added a Readme.md


radiobuttons type does not show passed value

When passing data into the form via the value key, the "radiobuttons" type does not show the data.  This does work if you change the type to "radios".
<!DOCTYPE html>

    <meta charset="utf-8" />
    <title>Getting started with JSON Form</title>
    <link rel="stylesheet" type="text/css" href="deps/opt/bootstrap.css" />

Requests and Issues Settings

    <form></form>

As I see it, it's just the class that is missing on the Bootstrap button. I'll issue a fix soon.

Hi @mw777eds
I think this has been fixed by https://github.com/jsonform/jsonform/commit/6ae9ebfc1794a16086d413821f2db93878075f2d
Can you confirm and close the issue if it's good for you ?
Thanks,
BR

Hi @mw777eds
I think this has been fixed by https://github.com/jsonform/jsonform/commit/6ae9ebfc1794a16086d413821f2db93878075f2d
Can you confirm and close the issue if it's good for you ?
Thanks,
BR

Closing as this has been fixed already. Please reopen if you still have the problem


links for localhost 😃

Better have some links in the README

I've prepared a stage to preview changes. Open stage or view logs.


Alert rule group failed to be applied - context deadline exceeded

Describe the bug
After deploying grafana-operator-grafana-deployment with CR alertrulegroup i'm getting following error:
Alert Rule Group failed to be applied for 1 out of 1 instances. Errors:                                                                                │
│       - grafana-operator/grafana-operator-grafana: fetching folder: Get "http://grafana-operator-grafana-service.grafana-operator:3000/api/folders/670f1565-8f76-49f6-b78a-51469d413791": context deadline exceeded
Version
Helm chart version 3.12.2
To Reproduce
Deploy following CRs:
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaFolder
metadata:
  name: erik-folder
spec:
  instanceSelector:
    matchLabels:
      app: grafana-operator-grafana
  permissions: |
    {
      "items": [
        {
          "role": "Admin",
          "permission": 4
        }
      ]
    }

apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaAlertRuleGroup
metadata:
  name: zookeeper-elastic
spec:
  folderRef: erik-folder
  instanceSelector:
    matchLabels:
      app: grafana-operator-grafana
  interval: 1m
  rules:
    - uid: a55303dc-81ba-4d92-8d71-82de4dd6541f
      title: zookeeper-elastic
      condition: A
      data:
        - refId: A
          relativeTimeRange:
            from: 600
            to: 0
          datasourceUid: 51226607-32f3-4822-b9e4-d81ce739e094
          model:
            alias: ""
            bucketAggs:
              - field: '@timestamp'
                id: "2"
                settings:
                  interval: auto
                type: date_histogram
            datasource:
              type: elasticsearch
              uid: 51226607-32f3-4822-b9e4-d81ce739e094
            hide: false
            intervalMs: 1000
            maxDataPoints: 43200
            metrics:
              - id: "1"
                type: count
            query: 'kubernetes.labels.app_kubernetes_io/name: zookeeper'
            refId: A
            timeField: '@timestamp'
      noDataState: NoData
      execErrState: Error
      for: 1m
      annotations: { }
      labels: { }
      isPaused: false`

Expected behavior
Deployed alert in grafana-operator-grafana-deployment
Suspect component/Location where the bug might be occurring
Status in CR grafanaalertrulegroup
Runtime (please complete the following information):
k8s version v1.26.10+rke2r2

This is now fixed in 5.8.1! Feel free to reopen the issue if this still occurs in the newest version


Print error message if an included build fails

Now we print the error output of a Gradle build that was launched via RunBuild instead of just giving the file name.

@armiol, PTAL.


Fix core and memory request MIAA deploy

Fixes #12504. Every item (if specified for memory/core request/limit must be >= 1 for whatever unit. it represents).
Addresses part of #12503; we need to clarify with folks tomorrow if we want to go MB or GB; postgres uses MB, ask from SQL is GB; these need to be rectified. Only changed this for now to ensure consistency between the

Pull Request Test Coverage Report for Build 262208030

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.229%

Totals

Change from base Build 262114351:
0.0%

Covered Lines:
19153

Relevant Lines:
45783

💛  - Coveralls


How to use this as ES5 compatible

Currently I am using the DrawControl class as
const MapboxDraw = require("react-mapbox-gl-draw"); const DrawControl = MapboxDraw.default;
Is this the correct code to use for ES5? Or is there any other approach.
I am making this thing work in IE11 and since it only reads ES5 code, I need to make DrawControl work in ES5.

Correct, with es5 you would use it like you did, or the shorter version const DrawControl = require("react-mapbox-gl-draw").default;
You could also use es6 syntax import DrawControl from 'react-mapbox-gl-draw';, transpile the code to es5 using babel, and it would also work in IE11.
Feel free to ask more questions, or close the issue.

Nope, it doesn't works with using const DrawControl = require("react-mapbox-gl-draw").default;.
It works on Chrome though but on IE11 it still gives me syntax error in the console pointing to the react-mapbox-gl-draw transpiled code.

@Akshay-Choudhary Can you paste the console errors here?

Yes sure.. here it is:
eval("const events = __webpack_require__(1342);\nconst Store = __webpack_require__(1351);\nconst ui = __webpack_require__(1355);\nconst Constants = __webpack_require__(22);\n\nmodule.exports = function(ctx) {\n\n  let controlContainer = null;\n\n  const setup = {\n    onRemove: function() {\n      setup.removeLayers();\n      ctx.store.restoreMapConfig();\n      ctx.ui.removeButtons();\n      ctx.events.removeEventListeners();\n      ctx.map = null;\n      ctx.container = null;\n      ctx.store = null;\n\n      if (controlContainer && controlContainer.parentNode) controlContainer.parentNode.removeChild(controlContainer);\n      controlContainer = null;\n\n      return this;\n    },\n    onAdd: function(map) {\n      ctx.map = map;\n      ctx.events = events(ctx);\n      ctx.ui = ui(ctx);\n      ctx.container = map.getContainer();\n      ctx.store = new Store(ctx);\n\n\n      controlContainer = ctx.ui.addButtons();\n\n      if (ctx.options.boxSelect) {\n        map.boxZoom.disable();\n        // Need to toggle dragPan on and off or else first\n        // dragPan disable attempt in simple_select doesn't work\n        map.dragPan.disable();\n        map.dragPan.enable();\n      }\n\n      let intervalId = null;\n\n      const connect = () => {\n        map.off('load', connect);\n        clearInterval(intervalId);\n        setup.addLayers();\n        ctx.store.storeMapConfig();\n        ctx.events.addEventListeners();\n      };\n\n      if (map.loaded()) {\n        connect();\n      } else {\n        map.on('load', connect);\n        intervalId = setInterval(() => { if (map.loaded()) connect(); }, 16);\n      }\n\n      ctx.events.start();\n      return controlContainer;\n    },\n    addLayers: function() {\n      // drawn features style\n      ctx.map.addSource(Constants.sources.COLD, {\n        data: {\n

I'm guessing this is the compiled code. Could you paste the actual error you're getting? Maybe a screenshot?

Here is the screenshot of error that I see in the console in IE11 and when I click on the error it navigates me to the previous section.

Was this error reproducible for you as well? Or any known solution to this?

I will spawn a windows VM this weekend and try to reproduce. Thanks for your patience.

Hi,
Any luck on this yet?

@Akshay-Choudhary Sorry for the delay. Finally got hold of a Windows computer.
Unfortunately I cannot reproduce your error. I have deployed the example/ folder here: https://test-7860b.firebaseapp.com. Running IE 11.1176 on Windows 10 gives me no error. Can you try with this online version?

I released v1.0.5. Please re-open this issue if the problem is still here.


MVP TODO: Part 2

Description
Activities - Each with its own gameplay loop, in-round progression and roles.

[x] #140
[ ] Farming
[ ] Blacksmithing
[ ] Security
[ ] Adventurers
[ ] Cooking
[ ] Medical
[ ] #180
[ ] Round structure

[ ] Town Portal - Latejoin connection, cryosleep round removal
[ ] "Traitor" gamemode

[ ] Shapeshifter antagonist

[ ] Round end???

Shapeshifter antagonist? There is exist some ref in docs?


dotrade and doexchange queue failure

dotrade and doexchange will likely fail on queue

confirmed doexchange works with queue now


added support for objects to R.filter

Hello,
R.filter also supports objects as their second parameter.
Added definitions and tests, including two 'general' functions to do basic type assertion.
If you prefer them to be just on this test definition, let me know, but I'm pretty sure they will be useful elsewhere.

thanks


Add validation test for etcd node deletion

Issue:

https://github.com/rancher/qa-tasks/issues/660

This PR adds validation test for ETCD node deletion in RKE1/RKE2/K3S clusters.
Also it fixes the logic in isNodeReady function. Previously it was taking cluster ID and only checking for one node to be in Active state and returning from the fuction. Made changes so that it checks for all nodes to be in Active state in a cluster.

Here's the example config for nodesAndRoles used for testing this PR:
provisioningInput:
  nodesAndRoles:
    - etcd: true
      controlplane: false
      worker: false
      quantity: 3
    - etcd: false
      controlplane: true
      worker: false
      quantity: 1
    - etcd: false
      controlplane: false
      worker: true
      quantity: 1
  nodesAndRolesRKE1:
    - etcd: true
      controlplane: false
      worker: false
      quantity: 3
    - etcd: false
      controlplane: true
      worker: false
      quantity: 1
    - etcd: false
      controlplane: false
      worker: true
      quantity: 1
  rke2KubernetesVersion:
    - v1.25.7+rke2r1
  rke1KubernetesVersion:
    - v1.25.6-rancher4-1
  k3sKubernetesVersion:
    - v1.25.7+k3s1

@izaac, I've added the example config with nodesAndRoles in the description which is used to test this PR. Also this tests only embedded k3s etcd as you mentioned.
And yes, etcd node should be etcd only and not combined, otherwise etcd node combined with cp or worker can also get deleted.

Not yet @markusewalker, will let you know once it's done, i'm running some tests locally.

I've updated the PR with changes - It's ready for another review.

@igomez06 done, I've squashed the commits.


CFE computes some function types in field initialization parameters incorrectly

Consider the following program.
class A {
  final Function(Function(int)) foo;
  A(this.foo(Function(int)));
}

When compiled by the CFE it shows the following compile-time error message:
/tmp/asdf.dart:3:10: Error: The type of parameter 'foo', 'dynamic Function(dynamic Function(dynamic))' is not a subtype of the corresponding field's type, 'dynamic Function(dynamic Function(int))'.
Try changing the type of parameter 'foo' to a subtype of 'dynamic Function(dynamic Function(int))'.
  A(this.foo(Function(int)));
         ^
/tmp/asdf.dart:2:33: Context: The field that corresponds to the parameter.
  final Function(Function(int)) foo;

It seems that the type of the formal parameter is incorrectly computed as Function(Function(dynamic)), and the expected type is Function(Function(int)).

The initializing formal parameter gets its type from the old-style function type which is specified "around" the name of the parameter, and old-style function types use a single identifier as the parameter name, assuming the type dynamic, as opposed to new-style function types where the parameter name can be omitted.
class A {
  final Function(Function(int)) foo;
  A(this.foo(Function(int p))); // This should do it.
}

@eernstg Thanks for clarifying that! I assume that we can close the issue now as a non-issue? 🙂

Certainly! And, in passing, noting that the choice to consider a single identifier as a parameter name and not a type is hugely confusing. It keeps tripping up everybody who gets in touch with it. 😄

It keeps tripping up everybody who gets in touch with it. 😄

I guess you can increase the body count with my case 😄


Expand Testing --- Aim for atleast 80% codecov

More tests are needed, especially now since we have the git action to that codecov :)

Alot can be done in the Handlers


updated resusable services list

Added content for Pathfinder SSO

Thanks for the PR @zsamji ! I've added some additions in #114 and we should have this merged and deployed soon.


Send stderr of ping tracker to devnull

Description:
When pinging an inaccessible device, OS errors like
ping: sendto: No route to host

can occur. For a ping tracker this is not an error but rather a normal
situation. Thus, it makes sense to hide the error.
(Experienced on macOS)
Example entry for configuration.yaml (if applicable):
device_tracker:
  - platform: ping
    hosts:
      laptop: <IP_ADDRESS>

Checklist:
If the code communicates with devices, web services, or third-party tools:

[X] Local tests with tox run successfully.

Makes sense. Okay for me!


Add console command

embark console have the same behaviour as embark run and embark build but instead of the UI being the dashboard of embark run, it displays the embark console, so the user can type cmds, interact with deployed contracts, etc.. (just like the console in embark run).

See output when we start the REPL, the contracts are available as well as web3.

That's cool! I think we should still build the assets. At least, looks like what the task Iuri created says. I also added a comment to it. Maybe, instead of creating embark console, we could just improve --nodashboard? As it already has all the wanted behaviours of a run with no dashboard, but is missing a console.

I added the repl to the run with nodashboard option.
Also instead of using this as the context (that is causing problems, reload issues),
I used embark so you can do for example:
embark.SimpleStorage or embark.web3
@iurimatias @jrainville let me know what you prefer about the command definition and if the context is ok for you?

Is doing just SimpleStorage still doable?
Wouldn't context.embark = RunCode.getContext() work?

Sadly: context= RunCode.getContext() didn't work. We can only mutate the context
However, by looking at the doc I saw there is a simpler way of doing it using the option:
useGlobal: true
So, doing SimpleStorage or web3 seems to be working

Nice. Code is good as far as I'm concerned. Just tested and there is a small issue:

Help is a bit shrunk (\n not doing what they should)
Also, profiling doesn't bring back the caret for a new command (though pressing any button does bring it back)

Added a customer writer

profiling doesn't bring back the caret for a new command

That one require further changes on how we process command. I suggest we solve that issue on another PR


Installation config files in the root of system config directory instead of package's name subdirectory

1.9.0 release by default installs two config files: sample and main into root of system's config directory.
For reliable DNS resolving it's recommended to use at least two DNS servers, so user probably will clone sample config to some another(s).
For readability of system's config directory, AFAIR, when package installs more than one config files, they are installed not into top, but into package's subdirectory.
For dnscrypt-proxy and common GNU/Linux the expected path is /etc/dnscrypt-proxy/

Hi,
There is only one configuration file. The .example one is just a template to avoid overwriting an existing configuration file.
The location can always be changed with --sysconfdir=... if you prefer a different one.


Youtube-dl library and ERROR 403: Forbidden when using generated direct link by youtube-dl from different locations

I have a problem with youtube-dl library (https://rg3.github.io/youtube-dl/). I use youtube-dl not for directly downloading videos by this library, instead I first generate link using command like this:
youtube-dl --simulate --dump-json --prefer-ffmpeg -- -CmadmM5cOk
I get needed format link from json answer, I use default format 1280x720 mp4. Links look like this "https://r4---sn-nto52nx-px8e.googlevideo.com/videoplayback?lmt=1432339993780507&ip=x.x.x.x&key=yt6&fexp=9408710%2C9409069%2C9413137%2C9415365%2C9415485%2C9416023%2C9416126%2C941...".
Then I use this link to download video from different PC in different locations. For most links it works ok, but there are some videos, for example https://www.youtube.com/watch?v=-CmadmM5cOk, that I can't download from different server or PC, it returns ERROR 403: Forbidden.
So what I tried so far, I have 2 server and my local PC, all 3 of them are located in different countries, USA, England and Ukraine.
For example, I run youtube-dl and get link on Server 1 in the USA, I get link, I can it download in this Sever 1, but on Server 2 in London and my local PC in Ukraine it returns ERROR 403: Forbidden.
Another example, I generate link on Server 2 in London, I get different link, I can download it on the same server, but when I try on Server 1 or my local PC I get the same ERROR 403: Forbidden. The same when I generate link on local PC and try on servers.
This happens only with only some exact videos, but there are a lot of them. Some of videos that returns 403: https://www.youtube.com/watch?v=09R8_2nJtjg, https://www.youtube.com/watch?v=7PCkvCPvDXk.
Thank you, I appreciate any help!

Final download URLs are only guaranteed to work on the same machine/IP where extracted. More on this.

Thank you! Sorry I didn't find it there.

In addition, you can probably track URLs that won't work from another IP using this approach.

Cookies and user agent there don't play any role as I tried to download video using wget -O file.mp4 "{link}", it worked fine on the same server but didn't work on others. I will code simple relay on the server for downloading using -o - option. Thank you again!

how did u solve this problem . please help me to resolve this isssue

I had made it download from the same server where it makes requests for details


Delete remote assets after cluster destroy

After the user runs lokoctl cluster destroy, lokoctl still keeps the S3 bucket around. Can we get rid of that after the destroy is successful?
If a user reuses the bucket for multiple installations then the state created during one installation in the bucket can interfere with other installation. Since it is not completely cleared some configs stay as it is and create broken clusters.

After the user runs lokoctl cluster destroy, lokoctl still keeps the S3 bucket around. Can we get rid of that after the destroy is successful?

lokoctl does not manage the S3 bucket, so I wouldn't expect it to remove it.

Lokoctl does not do the complete clean up, if not delete the bucket we should remove the key and the entry in dynamodb table?

Lokoctl does not do the complete clean up, if not delete the bucket we should remove the key and the entry in dynamodb table?

I think following what cleanup Terraform is doing is sufficient and we shouldn't extend it in any way. Terraform is an implementation detail from Lokomotive perspective.

Then we need to at least fix the bad UX user has. User only realises that they are using old key when they are in the middle of nodes creation.

Then we need to at least fix the bad UX user has. User only realises that they are using old key when they are in the middle of nodes creation.

Please describe that properly, as it seems as important issue indeed.


Replace WTForms with a more robust technology

Either opt for a completely new form validation technology in the backend or upgrade the version to check if the non-controllable errors vanish.

Can you elaborate on the non-controllable errors?

Digging the old conversation from logs for issue #439

The value of enabled is always true in 'data' if you try to send it through the angular schema reconfigure form. This could potentially a bug in WTForms itself. So, if you do form.is_enabled.data it will always read as true regardless of actual value. This is when you send it through reconfigure form.
To deal with this, there is another property called raw_data which actually deals with values for a processed form. In this case reconfigure form when updated indeed becomes a 'processed form' in that case. And raw_data gives out the correct value which was expected.
But, this raw_data thing doesn't work on normal functions. Like when activating the blueprints just by clicking on activate button and vice versa. It is then expected to make use of 'data' property itself, which provides the expected results.

And this, http://stackoverflow.com/questions/34118160/flask-wtforms-fieldlist-empty-form

Sending an array via json to a StringField results in only the first element being sent, whereas a dict can be sent perfectly fine for the same field type. Using the FieldList to send the array then results in absolutely no value in the python list being received at the backend.


Detect if translation files have changed

Problem

You are working on a branch refactor/api that is unrelated to UI translations
Someone fixed a few lint reports on main
You get notified that you need to update the translations in refactor/api

Why?
Compared to main, refactor/api now has new lint errors. This could be fixed by merging main into refactor/api, but I don't care about translations because I'm working on something completely different.
Proposal
Ninja needs to check if the branch contains updated translation files. Only if there are changes in this branch it makes sense to create a comment.

@niklas.buchfink  also take into consideration the default merge that happens in github actions usually. as i understand the actions run on a simulated merge of the current branch into the basebranch, not on the tip of the branch they are configured on. in this scenario im not sure why there would be lint errors as the main branch merge would have the fixed translation. maybe your action does something not according to the configured merge strategy in github action?

@jan.johannes No merge is really simulated in Ninja. It just checks out the branches, collects all reports and compares if there are new ones in the branch.

Comparing the target to a merge simulation of the head with the head/target seems to make sense.

@jan.johannes I'm currently working on this. Can you elaborate how I can access the default merge. I would like to check this out and compare it with main.

Because of the pull_request_target. Since I can't comment without them, I have to merge them manually. I hope that the GitHub action can do this without a private key.


Request support for Brade MC6 Thermostat (Tuya Version)

Log Message

This error originated from a custom integration.

Logger: custom_components.tuya_local.config_flow
Source: custom_components/tuya_local/config_flow.py:49
Integration: Tuya Local (documentation, issues)
First occurred: 8:59:50 PM (2 occurrences)
Last logged: 8:59:50 PM

Device matches mellerware_citymove_vacuum with quality of 17%. DPS: {"updated_at":<PHONE_NUMBER>.9222121, "1": true, "2": "high", "3": "idle", "16": 250, "17": 761, "18": 820, "19": 280, "20": 500, "23": "f", "24": 230, "25": 55, "26": 105, "29": 728, "33": 0, "40": false, "64": "Cool", "101": "offf", "103": "1"}
Report this to https://github.com/make-all/tuya-local/issues/

Logger: homeassistant.util.async_
Source: util/async_.py:164
First occurred: 8:59:49 PM (1 occurrences)

Last logged: 8:59:49 PM

Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for tuya_local doing blocking calls at custom_components/tuya_local/device.py, line 76: self._api = tinytuya.Device(dev_id, address, local_key)

Information about DPS mappings

{
  "result": {
    "model": "{\"modelId\":\"ej6cns\",\"services\":[{\"actions\":[],\"code\":\"\",\"description\":\"\",\"events\":[],\"name\":\"默认服务\",\"properties\":[{\"abilityId\":1,\"accessMode\":\"rw\",\"code\":\"switch\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_power3\",\"attribute\":\"1024\"},\"name\":\"开关\",\"typeSpec\":{\"type\":\"bool\",\"typeDefaultValue\":false}},{\"abilityId\":2,\"accessMode\":\"rw\",\"code\":\"mode\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_mode\",\"attribute\":\"1152\"},\"name\":\"风速\",\"typeSpec\":{\"range\":[\"low\",\"med\",\"high\",\"auto\"],\"type\":\"enum\",\"typeDefaultValue\":\"low\"}},{\"abilityId\":3,\"accessMode\":\"ro\",\"code\":\"work_state\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-zhuangtai\",\"attribute\":\"1152\"},\"name\":\"工作状态\",\"typeSpec\":{\"range\":[\"cooling\",\"heating\",\"idle\"],\"type\":\"enum\",\"typeDefaultValue\":\"cooling\"}},{\"abilityId\":16,\"accessMode\":\"rw\",\"code\":\"temp_set\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_temp\",\"attribute\":\"1024\"},\"name\":\"设置温度\",\"typeSpec\":{\"max\":990,\"min\":50,\"scale\":1,\"step\":5,\"type\":\"value\",\"typeDefaultValue\":50,\"unit\":\"℃\"}},{\"abilityId\":17,\"accessMode\":\"rw\",\"code\":\"temp_set_f\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_f\",\"attribute\":\"1024\"},\"name\":\"设置温度\",\"typeSpec\":{\"max\":1220,\"min\":410,\"scale\":1,\"step\":10,\"type\":\"value\",\"typeDefaultValue\":410,\"unit\":\"℉\"}},{\"abilityId\":18,\"accessMode\":\"rw\",\"code\":\"upper_temp_f\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_f\",\"attribute\":\"1024\"},\"name\":\"设置温度上限\",\"typeSpec\":{\"max\":1220,\"min\":410,\"scale\":1,\"step\":10,\"type\":\"value\",\"typeDefaultValue\":410,\"unit\":\"℉\"}},{\"abilityId\":19,\"accessMode\":\"rw\",\"code\":\"upper_temp\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_c\",\"attribute\":\"1024\"},\"name\":\"设置温度上限\",\"typeSpec\":{\"max\":500,\"min\":50,\"scale\":1,\"step\":10,\"type\":\"value\",\"typeDefaultValue\":50,\"unit\":\"℃\"}},{\"abilityId\":20,\"accessMode\":\"rw\",\"code\":\"lower_temp_f\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_f\",\"attribute\":\"1024\"},\"name\":\"设置温度下限\",\"typeSpec\":{\"max\":1220,\"min\":410,\"scale\":1,\"step\":10,\"type\":\"value\",\"typeDefaultValue\":410,\"unit\":\"℉\"}},{\"abilityId\":23,\"accessMode\":\"rw\",\"code\":\"temp_unit_convert\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_loop\",\"attribute\":\"1024\"},\"name\":\"温标切换\",\"typeSpec\":{\"range\":[\"c\",\"f\"],\"type\":\"enum\",\"typeDefaultValue\":\"c\"}},{\"abilityId\":24,\"accessMode\":\"ro\",\"code\":\"temp_current\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-wendu\",\"attribute\":\"1024\"},\"name\":\"当前温度\",\"typeSpec\":{\"max\":990,\"min\":0,\"scale\":1,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"℃\"}},{\"abilityId\":25,\"accessMode\":\"ro\",\"code\":\"humidity\",\"description\":\"\",\"name\":\"湿度显示\",\"typeSpec\":{\"max\":100,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"%\"}},{\"abilityId\":26,\"accessMode\":\"rw\",\"code\":\"lower_temp\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_c\",\"attribute\":\"1024\"},\"name\":\"设置温度下限\",\"typeSpec\":{\"max\":550,\"min\":50,\"scale\":1,\"step\":10,\"type\":\"value\",\"typeDefaultValue\":50,\"unit\":\"℃\"}},{\"abilityId\":29,\"accessMode\":\"ro\",\"code\":\"temp_current_f\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_f\",\"attribute\":\"1024\"},\"name\":\"环境温度\",\"typeSpec\":{\"max\":9900,\"min\":0,\"scale\":1,\"step\":5,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"℉\"}},{\"abilityId\":33,\"accessMode\":\"rw\",\"code\":\"holiday_days_set\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-wendu2\",\"attribute\":\"1024\"},\"name\":\"假日\",\"typeSpec\":{\"max\":99,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"day\"}},{\"abilityId\":40,\"accessMode\":\"rw\",\"code\":\"child_lock\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_lock\",\"attribute\":\"1024\"},\"name\":\"按键锁\",\"typeSpec\":{\"type\":\"bool\",\"typeDefaultValue\":false}},{\"abilityId\":64,\"accessMode\":\"rw\",\"code\":\"fan_mode\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-a_mode_fan\",\"attribute\":\"1152\"},\"name\":\"系统工作模式\",\"typeSpec\":{\"range\":[\"Cool\",\"Heat\",\"Vent\",\"Dehumid\",\"Auto\"],\"type\":\"enum\",\"typeDefaultValue\":\"Cool\"}},{\"abilityId\":69,\"accessMode\":\"rw\",\"code\":\"week_program_2\",\"description\":\"周程序2\",\"name\":\"周定时\",\"typeSpec\":{\"maxlen\":128,\"type\":\"raw\"}},{\"abilityId\":101,\"accessMode\":\"rw\",\"code\":\"set_type\",\"description\":\"\",\"name\":\"定时类型\",\"typeSpec\":{\"range\":[\"offf\",\"5_2\",\"7day\",\"24hour\"],\"type\":\"enum\",\"typeDefaultValue\":\"offf\"}},{\"abilityId\":103,\"accessMode\":\"rw\",\"code\":\"switchdiffer\",\"description\":\"\",\"name\":\"温差\",\"typeSpec\":{\"range\":[\"0_5\",\"1\",\"2\",\"3\"],\"type\":\"enum\",\"typeDefaultValue\":\"0_5\"}}]}]}"
  },
  "success": true,
  "t":<PHONE_NUMBER>138,
  "tid": "34fa53245d9c11ee8be412e912b899d8"
}

mode (Based on debug logs this is the mode of heat,cool, etc): 64
Switch: 1
Holiday: 33
Mode (Based on debug logs this is fan speed): 2
Working status: 3
Week Program 2: 69
Schedule type: 101
Switch differ: 103
Keylock: 40
Set temperature (Based on debug logs this is Celsius): 16
Set temperature (Based on debug logs this is Fahrenheit): 17
Set temperature upper limit (Based on debug logs this is Celsius): 19
Set temperature lower limit (Based on debug logs this is Fahrenheit): 20
Temperature format: 23
Room temperature: 24
Humidity display: 25
Set temperature lower limit (Based on debug logs this is Celsius): 26
Room temperature (Based on debug logs this is Fahrenheit): 29
Product ID

"model": "HVAC thermostat ",
"name": " HVAC thermostat ",
"product_id": "jnchsgfzhp5wytun",
"product_name": " HVAC thermostat ",
Information about how the device functions

Manual and DP ID guidance attached.
MC6-WIFI-Thermostat.pdf

I appreciate the help! I also had a question in the mean time... There are a few other functions I am dying to get integrated into Tuya. For example there is a built in climate differential setting in the thermostat, and Tuya has "temp_correction" even as a standard thermostat DP. The manufacturer is kind enough to work with me, but there is a disconnect on what would need to be done to bridge the gap and connect the two (they are saying they can't do anything on their end). I would appreciate any guidance on what would need to be done to open those features up to Tuya. Thanks again!

The switchdiffer setting appears to be what you are talking about, with values of 0.5, 1, 2, 3.  Hysteresis is probably a more accurate description than correction.

Switchdiffer is actually different that is the band of temperature before the fan kicks on (if target is 70 degrees, it will switch fan in at 68). The function I am trying to get is the calibration of the temperature reading that is modifiable (-9 to +9 on the thermostat)

Like I said, calibration is generally only exposed to the end user on devices that have external sensors that will need calibrating.  It is a bit strange that they expose it on the panel, but not in the Tuya protocol, but there is nothing that can be done by this integration to expose things that are not exposed.

Like I said, calibration is generally only exposed to the end user on devices that have external sensors that will need calibrating. It is a bit strange that they expose it on the panel, but not in the Tuya protocol, but there is nothing that can be done by this integration to expose things that are not exposed.

But in theory the manufacturer should be able to expose it to tuya if they want to right?


WebUI Error: File not found (./webui-2-x64.dyn)

deno run --allow-read main.ts
WebUI Error: File not found (./webui-2-x64.dyn) or<EMAIL_ADDRESS>
Where are these published and what is the recommended way to package and deliver these binaries?

The pre-built binaries are in the main library repo here:
https://github.com/webui-dev/webui/releases
Usually, import { webui } from<EMAIL_ADDRESS>should download those pre-built binaries.

I don't see anywhere in the code where it would download the binary...
A couple of points of review also.

Pin your imports to a specific version instead of using the versionless "latest" module, especially for deprecated API's those will just be removed one day and this entire module will stop working for everyone when it does.
https://github.com/webui-dev/deno-webui/blob/main/src/webui.ts#LL13C62

Don't use sync fs apis, put the logic to download the libs and load the window in an async function and only use async / await and async apis.
https://github.com/webui-dev/deno-webui/blob/main/src/webui.ts#L72

In javascript/typescript function names should be camelCased instead of snake_cased.

It looks like there is a line to actually download the file missing from right here:
https://github.com/webui-dev/deno-webui/blob/main/src/webui.ts#L107-L108

Generally speaking, I would not store state in a module but export a class which when instantiated will create the state, or a function which when called will return the state.
https://github.com/webui-dev/deno-webui/blob/main/src/webui.ts#L19-L20

I don't see anywhere in the code where it would download the binary

Sorry, I'm not the original creator of Deno-WebUI, but I guess the binaries are already embedded in the Deno Module. Please correct me if I'm wrong.

Pin your imports to a specific version instead of using the versionless "latest"

I Agree 👍

Don't use sync fs apis

Yes, You are right. That's why the comment says "Todo". We should implement it as soon as possible.

It looks like there is a line to actually download the file

Good point. We should add code there to download the binaries if somehow they are missed.

In javascript/typescript function names should be camelCased instead of snake_cased
I would not store state in a module but export a class

Probably those two implementations should have a different PR, so we discuss it because this is going to change the public APIs, but it's a good idea, and yes, I agree with you we should do this.

They are downloadable through the module import urls but nothing seems to be actually importing them. Deno won't automatically import things, its not quite like nodejs where they all get downloaded at the same time, it will only download what you import and you can only import js/ts files. So for other files such as json or dyn or even text files you have to actually use the fetch api to download the files explicitly or you have to have some other packaging mechanism, such as if you were to first install it onto your machine globally and have these modules know where to find the files via environment variable or something.

Based on what I can tell people are just downloading the files out of band and putting them onto their local file systems at the right local path.
Here is a library some use for this purpose:
<EMAIL_ADDRESS>

I got it, so Deno won't automatically download the complete package like Nodejs. Okay, I will try to implement all your suggestion (without using the plug module) when I have free time. Or, somebody will do it.
PR 1

Pin your imports to a specific version instead of using the versionless "latest"
Don't use sync fs apis
It looks like there is a line to actually download the file

PR 2

In javascript/typescript function names should be camelCased instead of snake_cased
I would not store state in a module but export a class

Many Thanks to @JOTSR. He impliment everything 👍


zero out memory in EmulatedDmaAllocator

Fixes https://github.com/microsoft/openvmm/issues/299

Thanks for your contribution!


Quick fix for substring check

Motivation and Context
Quick fix for substring check to fix #49
Description
Substring check for dataset name dataset traversal now checks for a substring that ends with : which prevents from accidentally including other datasets that have the same name in the start of the datasets name
eg:
MNIST and MNISTLabel
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[ ] Ready for review
[x] Work in progress

How Has This Been Tested?
Put an x in the boxes that apply:

[ ] Current tests cover modifications made
[ ] New tests have been added to the test suite
[ ] Modifications were made to existing tests to support these changes
[ ] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@rlizzo
This is a quick fix for the issue #49. If this solution is good enough, I'll go ahead and add test cases for the same before merging the PR. Just wanted to make sure there are no logical changes on the way that rewrites those functions entirely.

@rlizzo I changed the code so that SEP replaces :. One reason I found not to edit the dataset_record_count_db_key_from_raw_key function is, all of our *_db_key_from_raw_key has a similar structure -> returns the key without any separator. Changing that might bite us back later. What do you say? Anyway, this should fix our current issue.

awesome. this works for me! merging now!


Frequent logouts

CommaFeed has been logging me out quite frequently without me choosing to do so and requires reentering login information. This is happening without any prompt or change on my end and occurs perhaps once every 5 to 7 days.
Also it would be nice if there was a 'remember my information' form on the login page.
Besides that, thanks for CommaFeed, my favorite RSS reader :)

I have increased the delay, I don't remember why but it was set to 2 days.


Fix trace level support.

When trying to update and use this in cri-containerd, I find this error.
This is a bit confusing:

entry.Level is only set when actually outputs log (see here). It's just Level of a particular log entry.
entry.Logger.Level is the thing we should use. Note that we need atomic to avoid race condition. (see here).

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #2111 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
- Coverage   45.29%   45.28%   -0.01%
==========================================
  Files          95       95
  Lines        9461     9463       +2
==========================================
  Hits         4285     4285
- Misses       4464     4466       +2
  Partials      712      712

Flag
Coverage Δ

#linux
50.17% <0%> (-0.02%)
:arrow_down:

#windows
40.18% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

log/context.go
37.5% <0%> (-3.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424c0fb...f2c585a. Read the comment docs.

I'm wondering if we should upstream this.

@stevvooe I really want to actually. :)

LGTM


Launch instructions in the readme are outdated

The readme is outdated. Launching with H2 is reasonable. And that should be the default. And then with a block for production-y (or whatever) launch instructions. Also, mention the DX setup of separate client/server runs. And is 5000 still the default?

Turns out I did this later that year, but didn't close the issue.

Turns out I did this later that year, but didn't close the issue.


importlib-metadata<5.0 added on setup.py

Resolves :

CLICKUP- https://app.clickup.com/t/3mej2mk

[ ] I have added automatic tests where applicable.
[ ] The PR contains a description of what has been changed.
[ ] The description contains manual test instructions.
[ ] The PR contains update to the release notes.
[ ] The PR contains update to the documentation.

This PR has been tested on :

[ ] Windows.
[x] MacOs.
[x] Linux.

Changes

Keep importlib-metadata it low, otherwise python_jsonschema_objects build on python 3.7.12 will not work on maya 2022
Test

Build in python >3.7.7 and test the framework in maya 2022. Run the following import to make sure that no errors appear:
import python_jsonschema_objects as pjo

Please add release notes


MongoClient drop_database() method didn't delete mongoengine Document  _collection property bug!

Hi, i were using mongomock as the pytest database, i used such a fixture to setup and teardown database.
@pytest.yield_fixture(scope='function')
def database(app):
    with app.app_context():
        db.create_connection()

    connection = db.connection
    yield db
    connection.drop_database('test')
    connection.close()

but the  drop_database() method  didn't delete mongoengine Document  _collection property!
here is the source code:
@classmethod
def _get_collection(cls):
    """Returns the collection for the document."""
    # TODO: use new get_collection() with PyMongo3 ?
    if not hasattr(cls, '_collection') or cls._collection is None:
        db = cls._get_db()
        collection_name = cls._get_collection_name()
        # Create collection as a capped collection if specified
        ......
    return cls._collection

However the _collection property didn't free up,so the if condition always True,  hence the get_db() method never got call again!
def get_db(alias=DEFAULT_CONNECTION_NAME, reconnect=False):
    global _dbs
    if reconnect:
        disconnect(alias)

    if alias not in _dbs:
        conn = get_connection(alias)
        conn_settings = _connection_settings[alias]
        db = conn[conn_settings['name']]
        # Authenticate if necessary
        if conn_settings['username'] and conn_settings['password']:
            db.authenticate(conn_settings['username'],
                            conn_settings['password'],
                            source=conn_settings['authentication_source'])
        _dbs[alias] = db
    return _dbs[alias]

Please fix this bug, thanks very much :)

Dropping collections manually as a finalizer should do the trick for now:
    for collection in get_db('mydb')._collections.values():
        collection.drop()

Could pytest-mongodb be of any help for you?

Approach taken in #238 #245 using del removal should rather be changed into proper collections iteration, since what we really have is RuntimeError: dictionary changed size during iteration silenced by exception pass.

Fixed.


Add support for OpenSSL 3.0.x

This is an experiment for adding support for OpenSSL 3. I initially had this working on Linux but I wanted to test it as a PR on all the OSs we normally test with. As I am hacking, I getting builds to pass on my Linux + OpenSSL 3 setup and my macOS + OpenSSL 1.1.1 set up but I have to keep fiddling. Obviously, nothing works here (yet). Hm, this build was all green: https://github.com/apache/commons-crypto/actions/runs/3740952179
Note that when our GH build was using ubuntu-latest, it failed because that uses OpenSSL 3 which we do not support at all.

What's this about, Gary? You can pull yourself, can't you?

Look forward to OpenSSL 3.0+ support being added into Apache Commons Crypto.
OpenSSL 1.1.1 will reach its end of life by Sep/2023.


improve data fetching in remote scenario

see #152
The current approach to load delta is conservative. All visible rows are fetched and displayed per ranking. However, rankings share same data items and part of the items are already visible.
formally
all_data_needed = union(rankings.map((r) => r.order))

missing_data = all_data_needed.without(currently_visible_data)

part of latest release_1 branch


Fix Indonesia reference

getting data for Indonesia
downloading from overpass
waiting 4 seconds
Success, decreasing overpass request gap
done
error! Error: Invalid geojson for boundary: Indonesia

Incredible, the Indonesia relation seems to have lost a lot of tags that usually accompany a relation for a country.  I'm going to accept this, but I worry that having a broad query based on the name tag alone may pick up erroneous relations in the future.

I don't know who support this tags but I think they must return it back. After this you will can return reference to ISO3166-1 back.

Yeah, OSM is a big moving target, so until this becomes an issue it's fine to keep it.  There are already some other funky country tag queries in this repo that use ISO3166-1:alpha2.  :)

Hey, @Solodkiy @evansiroky I have raised an issue at Mapbox asking for a revert of that edit.
Issue: https://github.com/mapbox/mapping/issues/332

Update: The revert has been done and Indonesia now has the data back!


CI: Failed to clone package repo

https://github.com/invenia/PkgTemplates.jl/runs/3100066407?check_suite_focus=true
##[debug]/bin/bash --noprofile --norc -e -o pipefail /Users/runner/work/_temp/d39967ca-a251-47c0-98b0-c27b77f7fb26.sh
    Updating registry at `~/.julia/registries/General`
    Updating git-repo `https://github.com/JuliaRegistries/General.git`
┌ Warning: Some registries failed to update:
│     — /Users/runner/.julia/registries/General — failed to fetch from repo
└ @ Pkg.Types /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1246
     Cloning [78c3b35d-d492-501b-9361-3d52fe80e533] Mocking from https://github.com/invenia/Mocking.jl.git
ERROR: failed to clone from https://github.com/invenia/Mocking.jl.git, error: GitError(Code:ERROR, Class:Net, failed to resolve address for github.com: nodename nor servname provided, or not known)

This looks to me like a random network failure on the hosted runner, especially since it only happened on one job rather than all of them

That makes sense to me. I created this issue to document the occurrence but since it's a one-off issue and there isn't any way to resolve it it may be best to close the issue?

Yeah, this is GH's fault and isn't specific to this repo either.


No instructions for importing a config when doing a fresh install

The instructions don't seem to give instructions for how to do a fresh install using a config (which is the only time I've ever wanted to import a config).
The basic instructions at the top don't apply because there is no "more" in the installer until after you've already installed. There are then instructions on how to import into an existing installation.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 517f011b-d4f4-b1d3-3212-6725204a71e3
Version Independent ID: 77f048ce-d750-9c9d-f33a-5ec4f4a9965a
Content: Import or export installation configurations
Content Source: docs/install/import-export-installation-configurations.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@scott-moxham -- Scott, thank you for your feedback.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

@anandmeg -- Megha, please look into this issue.

@scott-maxham, .vsconfig files can be created from your existing installations or from a working solution.
You can then use an exported vsconfig file that contains the workloads and components to add or you can also just include components directly during the initial installation using the --add parameter for a fresh install. Here are some resources for installation:

Install Visual Studio from a local layout
Use winget to install or modify Visual Studio

Please let us know additional details of your scenario if the above doesn't work. Thanks!

Hi @scott-moxham -  this capability is not documented because we don't have it implemented yet ;)  Others have asked for it too... you can view the request (and upvote it if you want) here on our Developer Community:  Allow import of .vsconfig on initial install

@scott-moxham, closing this issue for now. Please follow the Developer Community: Allow import of .vsconfig on initial install issue for updates. Thanks!


glibc: fix unaligned __tls_get_addr issue

Motivation for this change
See https://bugzilla.redhat.com/show_bug.cgi?id=1440287
Things done

[x] Tested using sandboxing
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s)
[ ] Tested compilation of all pkgs that depend on this change
[x] Tested execution of all binary files (none)
[x] Fits CONTRIBUTING.md.

Merged into staging, thanks!


Migrating from isInitialValid to initialErrors?

Can someone provide an example of how to migrate isInitialValid to initialErrors? I wrote about my current implementation here #1454.
I'm am implementing v2 and getting the deprecation message for isInitialValid. Any specific example on how to convert this would be great.

I'm currently using dirty state to check if form was changed since initialValues.
<Formik {...props}>
  {({ dirty }) => (
    <form>
      <Button isDisabled={!dirty}>Send</Button>
    </form>
  )}
</Formik>

@Kinbaum have you tried valideOnMount ?

@domeknn it works but causes an uncanny behavior. It flicks/blinks the form, quickly updating isValid from true to false.

@VitorLuizC nice catch, didnt saw this! Tried to use validateSync from Yup, but it throws error :/ Even that validateOnMount didnt change isValidating. With dirty also can be problem while you're autofilling form (like getting delivery address from database and put into form). 😢

@VitorLuizC nice catch, didnt saw this! Tried to use validateSync from Yup, but it throws error :/ Even that validateOnMount didnt change isValidating. With dirty also can be problem while you're autofilling form (like getting delivery address from database and put into form). 😢

Yeap, I had to use enableReinitialize and put my initialValues in a useMemo. Seems fixed now, but is a little more boilerplate code than before.
const initialValues = useMemo(
  () => ({
    name: user?.name ?? '',
    email: user?.email ?? '',
    ...
  }),
  [user]
);

<Formik
  enableReinitialize
  initialValues={initialValues}
>
  {
    ({ dirty, isValid }) => (
      <Button isDisabled={dirty && !isValid}>Send</Button>
    )
  }
</Formik>

@VitorLuizC Okay, but what's when in initialValus you got valid object? Button is still disabled ?

Yeap, in my case UX tell us to keep it disabled. Only change it when user change its values

@jaredpalmer
This is the only solution that seems to work for me. Unfortunately, I still have to use the deprecated isInitialValid. validateOnMount works initially when the form mounts, but when I go forward and backward between pages it doesn't reflect the validationSchema for the current page. In order for it to reflect properly, I have to touch a field, then blur off of it.
Working but deprecated
const [ formValues, setFormValues ] = useState(initialValues);
// ... removed extra code for brevity

function nextPage({ values }) {
    setCurrentPage(Math.min(currentPage + 1, children.length - 1));
    setFormValues(values);
}

function previousPage({ values }) {
    setCurrentPage(Math.max(currentPage - 1, 0));
    setFormValues(values);
}

<Formik
    initialValues={ formValues }
    isInitialValid={ () => (schema ? schema.isValidSync(formValues) : true) }
    enableReinitialize={ true }
    validationSchema={ schema }
    onSubmit={ handleSubmit }>

Here is how I am showing / hiding the next button
<Button
    color="primary"
    variant={ !isLastPage && innerProps.isValid ? null : 'hidden' }
    action={ () => nextPage(innerProps) }>
    { activePage.props.nextLabel || 'Next' }
</Button>

Not working
<Formik
    initialValues={ formValues }
    enableReinitialize={ true }
    validateOnMount={ true}
    validationSchema={ schema }
    onSubmit={ handleSubmit }>

I've also tried to check the errors object to see if it's empty in order to toggle the next button.
<Button
    color="primary"
    variant={ !isLastPage && Object.entries(innerProps.errors).length === 0 ? null : 'hidden' }
    action={ () => nextPage(innerProps) }>
    { activePage.props.nextLabel || 'Next' }
</Button>

Works initially, but going forward and back between pages causes the errors object to be behind in state.
So if I:

fill out page 1
go to page 2
go back to page 1
then the errors object will contain errors from page 2, so the next button doesn't show up on page 1.

Like I said, the only thing that I've been able to get working is to do isInitalValid with synchronous schema validation.

The tip from @domeknn solved for me. I'm only using validateOnMount.
<Formik validateOnMount {...props}>
  {({ isValid }) => (
    <form>
      <button disabled={!isValid}>Send</disabled>
    </form>
  )}
</Formik>

I used a combination of dirty and validateOnMount to get around this.


Add error checking/retry for deployment/removal steps

The pipeline may fail due to unforeseen circumstances, usually when a single deployment/removal fails. Stopping the whole pipeline due to a single deployment failure is not desirable as everything needs to be restarted. We need to add an error check + retry for deployment/removal of functions.
Required Changes

Add error check + retry mechanism to function deployment/removal logic

Closing as this has been resolved by #330.


Ryzen dot product performance

First of all, brilliant work on this package. Extremely impressive.
Since you mention in the readme that you were curious about 1 fma Ryzen chips, here's data from a Ryzen 2700X running Julia 1.4.0-rc2.0 on Windows 10 x64 and the latest release (v0.6.21) of the package:
# make sure we get enough samples
julia> BenchmarkTools.DEFAULT_PARAMETERS.samples = 1e12

julia> a = rand(256); b = rand(256);

julia> @btime mydot($a,$b)
  33.098 ns (0 allocations: 0 bytes)
55.14639163783218

julia> @btime mydotavx($a,$b)
  33.802 ns (0 allocations: 0 bytes)
55.14639163783219

julia> @btime myselfdot($a)
  22.066 ns (0 allocations: 0 bytes)
79.1990129346761

julia> @btime myselfdotavx($a)
  22.868 ns (0 allocations: 0 bytes)
79.1990129346761

julia> a = rand(255); b = rand(255);

julia> @btime mydot($a,$b)
  43.749 ns (0 allocations: 0 bytes)
65.04807877890542

julia> @btime mydotavx($a,$b)
  39.274 ns (0 allocations: 0 bytes)
65.04807877890542

julia> @btime myselfdot($a)
  38.608 ns (0 allocations: 0 bytes)
80.52310652021393

julia> @btime myselfdotavx($a)
  32.863 ns (0 allocations: 0 bytes)
80.52310652021396

So, the single load versions are always significantly faster, although the total throughput is always quite low compared to the numbers in your readme, which I assume came from a quad channel Skylake-X system or a comparable Xeon.
Let me know if you'd like any further info, whether the LLVM IR / native assembly, details of the hardware involved or for me to run any further benchmarks!

Thanks, I'll have to update the README. cscherrer posted similar results using his 2950X on Discourse.
On the master branch of LoopVectorization (a few things have improved, but dot product performance should be identical*):
julia> BenchmarkTools.DEFAULT_PARAMETERS.samples = 1e12
1.0e12

julia> a = rand(256); b = rand(256);

julia> @btime mydot($a,$b)
  12.158 ns (0 allocations: 0 bytes)
61.406705504849626

julia> @btime mydotavx($a,$b)
  13.501 ns (0 allocations: 0 bytes)
61.406705504849626

julia> @btime myselfdot($a)
  8.976 ns (0 allocations: 0 bytes)
85.74999141741742

julia> @btime myselfdotavx($a)
  9.435 ns (0 allocations: 0 bytes)
85.74999141741742

julia> a = rand(255); b = rand(255);

julia> @btime mydot($a,$b)
  36.302 ns (0 allocations: 0 bytes)
61.46306840897695

julia> @btime mydotavx($a,$b)
  14.292 ns (0 allocations: 0 bytes)
61.46306840897695

julia> @btime myselfdot($a)
  28.851 ns (0 allocations: 0 bytes)
78.1853694948555

julia> @btime myselfdotavx($a)
  9.828 ns (0 allocations: 0 bytes)
78.18536949485554

julia> versioninfo()
Julia Version 1.5.0-DEV.463
Commit 94b29d5e98* (2020-03-15 19:17 UTC)
Platform Info:
  OS: Linux (x86_64-generic-linux)
  CPU: Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, skylake)

(the chip is quad channel, but all the benchmarks I've included in the docs should fit in cache)
When the length is 256, we see essentially the same pattern: the single load version is about 50% faster.
From Agner Fog's instruction tables (page 100), while Ryzen ymm vfmadd has half the throughput as xmm, it's latency is unchanged.
Additionally, it looks like ymm-memory move instructions also have half throughput (reciprocal throughput of 1 instead of 0.5). So in terms of relative throughput of memory and fma instructions, these Ryzen chips look like they're the same as Haswell or newer Intel chips, while they will do better (have lower) latency * throughput of fma instructions, suggesting they don't need as much unrolling.
Docs contain plots of performance for all lengths from 2 through 256 on my computer:
Stable docs
Latest docs
Contradicting my statement on identical performance, it looks like the latest plots regressed relative to stable. I'll have to look into that.
Regular dot product peaked at under 44 GFLOPS, while the single load versions did at about 60 GFLOPS. A single core of this CPU has a theoretical peak of 131.2 GFLOPS (minus overhead from reducing the accumulation vectors, etc). MKL dgemm regularly exceeded 120 GFLOPS when the memory accesses are all aligned (when the stride is a multiple of 8).
Meaning it never actually hit >50% of the theoretical speed anyway. Even if Ryzen fmas had half the throughput relative to memory ops, would this significantly change the performance characteristics of dot products? I'm not sure.
Given that the relative values seem to be about the same, I don't think there's any reason to model them differently.
Let me know if you think there are any differences I should try to account for.


Special characters in FileName does not throw any error?

If there is any special characters in file name the library does not throw or return any error, it just dies.
For android special characters are: [" * / : < > ? \\ / ]
I don't expect to solve this issue from the library but at least I expect to throw an error with proper message. It took me some considerable amount of time to figure the issue.
Thanks in advance.

Hello @plabon, can you please provide me with the download link & download file name?
I can't reproduce the issue (make the app die), it throws an exception in the native (unclear & unrelated exception),
I tried:

#.pdf -> Threw an exception
k#.pdf -> Downloaded as k.pdf
#k.pdf -> Threw an exception
k#k.pdf -> Downloaded as k.pdf

Note that when it throws an exception the app keeps running without any issues

Can you please try out the prerelease version flutter_file_downloader: ^1.2.0-dev.2
I could not reproduce the issue and force the app to die,
DownloadManager updates the downloaded file path and omits whatever characters after the not-allowed special character
also as I saw while debugging, it throws 2 different exceptions according to the provided special character

SecurityException("Unsupported path<EMAIL_ADDRESS>SecurityException("java.io.IOException: Invalid file path /storage/emulated/0/Download/o/k.pdf")

but in some other cases, it does not through an exception but the file sticks at 0% progress and it's status in the files Queued, also it changes the passed name to omit the special character with all characters after
e.g.: (o#k.pdf) Download manager changes it to be o.pdf
this issues are now solved in the new prerelease, please take sometime to try it on your use case and let me know the results

Hello @plabon,
I will be publishing this fix on production this weekend,
I tested it out and works fine, please if you have any note, suggestions or unexpected behaviors let me know before this weekend to include in the production version.
thanks in advance.

Hey me again. I was looking at the changes. I have couple of observations:

Why the name check part is removed from the getExtension() function? here

Also the getExtension() function logic is not considering the query parms of download url. For example: www.testtest.com/video/name.mp4?accesstoken=asgdgaskgdkhagskdg&userid=khkjhk.tyrb

Hello @plabon
Thank you for opening my eyes on that, I didn't pay attention to the query params bug
Please if you have sometime your contribution is widely welcomed
I will work on it ASAP inshallah
Thank you again

Hello again @plabon,
I have push a new commits to the branch development
please take sometime to view it and your comments are highly appreciated.
thank you for helping in improving this plugin


Again: Missing plugin A_OPUS

Hey there,
newest Mopidy, newest Mopidy-Youtube and newest pafy (0.5.1) - however when i try to play any youtube audio following is in the log file:
2016-06-07 21:26:12,313 WARNING [1226:MainThread] mopidy.audio.actor: Could not find a audio/x-unknown decoder to handle media.
2016-06-07 21:26:12,314 WARNING [1226:MainThread] mopidy.audio.gst: GStreamer warning: No decoder available for type 'audio/x-unknown, codec-id=(string)A_OPUS'.
Any Idea?

Hello friends,
found myself a solution:
http://askubuntu.com/questions/517910/installing-can-i-install-gstreamer-1-4-on-ubuntu-14-04
I got gstreamer 1.2.4 installed, updated to 1.4.3 with the first answer in this post.
Everything works fine now. :)


Console -> All Jobs -> Details does not wrap lines properly

^ commit id isn't wrapped properly and hence cannot be viewed. This happens regardless of screen size.

This is odd. We just talked about making the sidebar more adjustable.
Need to move this issue to dash repo


Worker sending too many connection requests to Node

2021-05-13 05:12:36 ✨ Imported #43 (0x9b37…8c81)
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49952.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49954.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49956.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49958.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49960.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49962.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49964.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49966.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49968.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49970.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49972.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49974.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49976.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49978.
2021-05-13 05:12:37 Accepted a new tcp connection from <IP_ADDRESS>:49980.

When the worker is connected, it is sending too many connections to the node. It can lead to port exhaustion

This should be resolved upstream


Install PhantomJS Ubuntu package on Travis CI.

Hello @ardatan and @Urigo,
could you merge this PR to have a phantomjs package installed on Travis CI?
Travis CI has a custom version in: /usr/local/phantomjs/bin that results in errors running
the tests with ardatan:mocha
More details are here:
https://github.com/Urigo/angular-meteor/pull/1927#issuecomment-399793547
Thanks, Georgy

Checking Travis CI build output, you can see that apt install phantomjs works correctly.
It errors out later.
@ardatan and @Urigo
LGTM?

Could you do this change in this PR, because it is not clear if this fixes the errors certainly (mocha)?
https://github.com/Urigo/angular-meteor/pull/1927

@ardatan sure!


how can i register spring cloud gateway to two seperate eureka server(not a cluster)

spring cloud gateway version: 2.1.0.RELEASE
I have a spring cloud gate way, I want to register it to two seperate eureka server,  one eureka server(A) is a enterprise level service discovery center, one eureka server（B） is just used by my system， there is many other systems which registered on A ,  i register my gateway to A so thease other systems can find my gateway, and they can invoke my system 's service  by A's help.   in the meantime i need register the gateway to B , so that the gateway can route to my system's service.   I have no idea to make it, i need help.

It's not a situation we support currently.


Cleanup Makefile

This PR splits the Makefile into build, iso, run, and test parts and defines variables only where needed.
Part of #32, also fixes #128

merged after rebbase


Lego The Hobbit [PCSE00390]

App summary

App name: Lego The Hobbit
App serial: PCSE00390
App version: 1.0

Vita3K summary

Version: v0.1.5 2683-b3a44b5d
Build number: v0.1.5 2683
Commit hash: https://github.com/vita3k/vita3k/commit/[commit]
CPU backend: Dynarmic

Test environment summary
Tested by: RetroZone (Known As The Retro Zone On YouTube)
OS: Windows 10 Home X64
CPU: Intel Xeon E5 1650 3.20GHZ
GPU: NVIDIA Quadro K2000 2GB
RAM: 24 GB
Issues
Gets InGame, Has Audio Problems And Yellow Sky With Broken Cutseens "Almost The Same With The Other InGame Lego Games"
Screenshots

Gameplay https://youtu.be/4Vsz4T9Vr0M
Log
Recommended labels

https://github.com/Vita3K/compatibility/labels/Ingame -
https://github.com/Vita3K/compatibility/labels/audio bug
https://github.com/Vita3K/compatibility/labels/video player bug

graphic buggy


Issue enabling email for reset/recover password

I was trying to enable email for reset/recover password workflow by adding "EMAIL_ENABLED" environment variable (value: "true"), however received a  "500 Internal Server Error" when hitting https://advocacy-tracker-test.herokuapp.com/auth/password
The server logs show (as if the EMAIL_ENABLED setting is not active although it is set when checking in the console)
2022-05-15T13:17:48.008312+00:00 app[web.1]: D, [2022-05-15T13:17:48.008279 #4] DEBUG -- : [c59ea2db-fe3a-4dc9-b865-4f5c6defcf08] Devise::Mailer#reset_password_instructions: processed outbound mail in 1.7ms
2022-05-15T13:17:48.008579+00:00 app[web.1]: I, [2022-05-15T13:17:48.008539 #4]  INFO -- : [c59ea2db-fe3a-4dc9-b865-4f5c6defcf08] Completed 500 Internal Server Error in 64ms (ActiveRecord: 22.2ms | Allocations: 9576)
2022-05-15T13:17:48.010443+00:00 app[web.1]: F, [2022-05-15T13:17:48.009785 #4] FATAL -- : [c59ea2db-fe3a-4dc9-b865-4f5c6defcf08]
2022-05-15T13:17:48.010444+00:00 app[web.1]: [c59ea2db-fe3a-4dc9-b865-4f5c6defcf08] ActionView::Template::Error (Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true):

Relates to
https://github.com/dumparkltd/marine-defrag-server/commit/59afe5e261c8446f7916407551ac59967222981b

@parndt could you have a look at this also? thanks

@parndt I think I found the issue:
https://github.com/dumparkltd/advocacy-tracker-server/pull/25/commits/9e8fb824f48997b95cca3c5aed19fdb151b7e018

@parndt having fixed the email issue for initiating the recovery, I am now encountering an issue when trying to reset the passord. specifically the server log now states
Can't verify CSRF token authenticity.

I think you may need to have a look after all =)

@parndt nevermind =) I gave it one more try and weirdly it now worked!


Missing parent: GO:0016972 thiol oxidase activity

GO term ID and label for which you request a new superclass
id: GO:0016972
name: thiol oxidase activity
namespace: molecular_function
def: "Catalysis of the reaction: 4 R'C(R)SH + O2 = 2 R'C(R)S-S(R)CR' + 2 H2O2." [RHEA:17357]
synonym: "sulfhydryl oxidase activity" RELATED [EC:<IP_ADDRESS>]
synonym: "thiol:oxygen oxidoreductase activity" RELATED [EC:<IP_ADDRESS>]
xref: EC:<IP_ADDRESS>
xref: MetaCyc:THIOL-OXIDASE-RXN
xref: RHEA:17357
xref: UM-BBD_reactionID:r1293
is_a: GO:0016670 ! oxidoreductase activity, acting on a sulfur group of donors, oxygen as acceptor

New superclass (parent) suggested
Looks like this should have "GO:0015036 disulfide oxidoreductase activity" as an additional parent

Fix definition to match EC and RHEA:
From: 'Catalysis of the reaction: 4 R'C(R)SH + O2 = 2 R'C(R)S-S(R)CR' + 2 H2O2.'
to Catalysis of the reaction: 2 R'C(R)SH + O2 = R'C(R)S-S(R)CR' + 2 H2O2.