Abort commit if files are modified

It was mentioned here that it might be worth while considering if aborting a commit on file modification during a pre-commit hook could be incorporated directly into Komondor.
I had a look into the code to think about how this might be integrated and at once realised there was many different ways to tackle the problem.

Should this applicable to all or specific hook types?
Presumably this should be opt in, if so how is it configured?

There could be another hookOptions type dictionary, this could allow for additional options to be specified
we could check config for additional hook configuration config["\(hook)-option"]

The following demonstrates a possible way to add staged file modification for pre-commit hook only with out any opt in/out.
import Foundation
import PackageConfig
import ShellOut

// To emulate running the command as the script woudl do:
//
// swift run komondor run [hook-name]
//
//
public func runner(logger _: Logger, args: [String]) throws {
    let pkgConfig = getPackageConfig()

    guard let hook = args.first else {
        logger.logError("[Komondor] The runner was called without a hook")
        exit(1)
    }

    guard let config = pkgConfig["komondor"] else {
        logger.logError("[Komondor] Could not find komondor settings inside the Package.swift")
        exit(1)
    }

    guard let hookOptions = config[hook] else {
        logger.logError("[Komondor] Could not find a key for '\(hook)' under the komondor settings'")
        exit(1)
    }

    var commands = [] as [String]
    if let stringOption = hookOptions as? String {
        commands = [stringOption]
    } else if let arrayOptions = hookOptions as? [String] {
        commands = arrayOptions
    }

    logger.debug("Running commands for komondor \(commands.joined())")

    do {
        let hash = try stagedChangesHash()

        try commands.forEach { command in
            print("> \(command)")
            // Simple is fine for now
            print(try shellOut(to: command))
            // Ideal:
            //   Store STDOUT and STDERR, and only show it if it fails
            //   Show a stepper like system of all commands
        }

        if hook == "pre-commit", try stagedChangesHash() != hash {
            print("Staged files modified during \(hook) hook")
            exit(1)
        }
    } catch let error as ShellOutError {
        print(error.message)
        print(error.output)
        exit(error.terminationStatus)
    } catch {
        print(error)
        exit(1)
    }
}

private func stagedChangesHash() throws -> String {
    return try shellOut(to: "git diff --cached --name-only | xargs git diff | md5")
}

I played around a bit with the different options mentioned above but I always felt a little dirty like I was adding something too specific to what is currently a very generic.
Do you have any thoughts on how this might be implemented?

Perhaps starting at the DSL we want and then extrapolating back might be useful here?
#if canImport(PackageConfig)
    import PackageConfig

    let config = PackageConfig([
        "komondor": [
            "pre-push": "swift test",
            "pre-commit": [
                .expectUnchanged([
                   "swift run swiftformat .",
                   "swift run swiftlint autocorrect --path Injectable/",
                 ]),
                "git add .",
            ],
        ],
    ])
#endif

This is all Swift - so I think this could work? A string could always represent a cmd to execute but enums could wrap with a context (like chdir )
Then it's a matter of looping through, seeing if it's a string or a special case?

Much more extensible and flexible 👍 Seems like the way to go!

Okay hit the first roadblock investigating this path.
It seems that you cannot reference the package code from the Package.swift
Which I guess makes sense as the Package.swift defines that package so it is a bit weird to reference it internally.
You can try this to reproduce
// swift-tools-version:4.2

import PackageDescription

let package = Package(
    name: "Komondor",
    products: [
        .executable(name: "komondor", targets: ["Komondor"]),
    ],
    dependencies: [
        // User deps
        .package(url: "https://github.com/orta/PackageConfig.git", from: "0.0.1"),
        .package(url: "https://github.com/JohnSundell/ShellOut.git", from: "2.1.0"),
        // Dev deps
        .package(url: "https://github.com/nicklockwood/SwiftFormat.git", from: "0.35.8"), // dev
        .package(url: "https://github.com/Realm/SwiftLint.git", from: "0.28.1"), // dev
        .package(url: "https://github.com/f-meloni/Rocket", from: "0.1.0"), // dev
    ],
    targets: [
        .target(
            name: "Komondor",
            dependencies: ["PackageConfig", "ShellOut"]
        ),
        .testTarget(
            name: "KomondorTests",
            dependencies: ["Komondor"]
        ),
    ]
)

#if canImport(PackageConfig) && canImport(Komondor)
    import PackageConfig
    import Komondor

    //This is a public function in Komondor
    renderScriptHeader("test")

    let config = PackageConfig([
        "komondor": [
            "pre-push": "swift test",
            "pre-commit": [
                "swift test",
                "swift run swiftFormat .",
                "swift run swiftlint autocorrect --path Sources/",
                "git add .",
            ],
        ],
        "rocket": [
            "after": [
                "push",
            ],
        ],
    ])
#endif

This will produce the following error.
<unknown>:0: error: fatal error encountered during compilation; please file a bug report with your project and the crash log
<unknown>:0: note: Program used external function '_$S8Komondor18renderScriptHeaderyS2SF' which could not be resolved!
0  swift                    0x000000011013e59a PrintStackTraceSignalHandler(void*) + 42
1  swift                    0x000000011013dd4e SignalHandler(int) + 302
2  libsystem_platform.dylib 0x00007fff71eb2b3d _sigtramp + 29
3  libsystem_platform.dylib 0x000000011bcabbc6 _sigtramp +<PHONE_NUMBER>
4  libsystem_c.dylib        0x00007fff71d701c9 abort + 127
5  swift                    0x000000010c3c3a67 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*)::$_1::__invoke(void*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool) + 519
6  swift                    0x00000001100f21c8 llvm::report_fatal_error(llvm::Twine const&, bool) + 280
7  swift                    0x000000010d17fe92 llvm::RuntimeDyld::resolveRelocations() + 3346
8  swift                    0x000000010d16a350 llvm::MCJIT::finalizeObject() + 176
9  swift                    0x000000010c3d0e2b performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 52219
10 swift                    0x000000010c3c0d35 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 7717
11 swift                    0x000000010c366965 main + 1349
12 libdyld.dylib            0x00007fff71cc7ed9 start + 1
Stack dump:
0.	Program arguments: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift -frontend -interpret Package.swift -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -I /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/pm/4_2 -I .build/debug -suppress-warnings -color-diagnostics -module-name Package -lPackageDescription -lPackageConfig

Maybe I am just doing something wrong, but assuming not should we have yet another package that defines KomondorCommands?

Oh yeah, that's a really good point!
I had thought about this for packageconfg  but not tried implementation anything https://github.com/orta/PackageConfig/issues/1
I think that might be really tricky (how would we be sure it was already built and in a linkable state?) to do.
Maybe then it'd just have to be special strings :-/

IMO after seeing what could be possible mixing in "special strings" doesn't seem like a very nice solution, but it might be the only reasonable way.
I did some hacking to see how it might look with an enum to denote command types.  I like it.
I also had a crack at what a more strictly typed config might look like here
Still it is not coming together for me, due to linking issues.  I thought it could be solved by using a seperate package but unfortunately it is still failing to resolve stuff.
<unknown>:0: error: fatal error encountered during compilation; please file a bug report with your project and the crash log
<unknown>:0: note: Program used external function '_$S16KomondorCommands16CommandProvidingMp' which could not be resolved!

It was fun but I have gone past the point of diminishing returns on this one, so I am going to stick with the original  approach for now.
Thanks for your time!


[Issue #10427] Add AvroSchema UUID support fix

Fixes #10427
Motivation
As AVRO support the UUID type (see AVRO spec),  add UUID support for the pulsar AvroSchema.
It also adds the AVRO Decimal logical type (see AVRO spec).
Modifications
Add the logical type conversion to the ReflectData instance when parsing the provided POJO.
Verifying this change
See the provided unit test in pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/AvroSchemaTest.java

Because the issue happens when creating the AVRO schema from a POJO class. Maybe a java annotation on BigDecimal fields could provide the scale ?

Le 30 avr. 2021 à 15:38, Enrico Olivelli @.***> a écrit :

@eolivelli commented on this pull request.
In pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java:

@@ -127,7 +127,12 @@ public static void addLogicalTypeConversions(ReflectData reflectData, boolean js
}
}
reflectData.addLogicalTypeConversion(new Conversions.UUIDConversion());

   reflectData.addLogicalTypeConversion(new Conversions.DecimalConversion());

   reflectData.addLogicalTypeConversion(new Conversions.DecimalConversion() {

       @Override

       public org.apache.avro.Schema getRecommendedSchema() {

           return LogicalTypes.decimal(100,51).addToSchema(org.apache.avro.Schema.create(org.apache.avro.Schema.Type.BYTES));

we already have "isJsr310ConversionEnabled" and "getAlwaysAllowNull"
why don't we store precision and scale the same way ? this way they will be stored in the registry and consumers will use the right version of the schema
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@sijie I believe that now the patch is really good to go.
please take another look when you have time


Copy-DbaDatabase sometimes chooses incorrect path for restore step

Bug Report
I am using Copy-DbaDatabase to migrate several databases from clustered instances of SQL 2008 R2 to SQL 2016. Most of the databases work fine, but there are a few on each instance that fail. The backup step works fine and backs up to the -NetworkShare path I provide. But for a few databases, they do not use the -NetworkShare path for the restore step and seem to use some old path that the original database was restored from on the source instance.
General Troubleshooting steps
Copy-DbaDatabase -Source DCPTSQLC01INT03.decepticons.amsod\EIQ -Destination AP11DBC01N09 -Database CustomerDefault -BackupRestore -NetworkShare \\backupa.gc.local\source11\DCPT -Force
I'm using -Force so I don't have to delete the destination database that I have restored manually in the past in case the command actually completes.
The basic error is:
WARNING: [Invoke-DbaAdvancedRestore][15:18:04] Failed to restore db CustomerDefault, stopping | Exception calling "SqlRestore" with "1" argument(s): "Restore failed for Server 'AP11DBC01N09'. "
Running $error[0] | select * gives me
Type                     Name            Status Notes
----                     ----            ------ -----
Database (BackupRestore) CustomerDefault Failed Failed to restore database
writeErrorStream      : True
PSMessageDetails      :
Exception             : System.Exception: Exception calling "SqlRestore" with "1" argument(s): "Restore failed for Server 'AP11DBC01N09'. " ---> System.Management.Automation.MethodInvocationException: Exception
                        calling "SqlRestore" with "1" argument(s): "Restore failed for Server 'AP11DBC01N09'. " ---> Microsoft.SqlServer.Management.Smo.FailedOperationException: Restore failed for Server
                        'AP11DBC01N09'.  ---> Microsoft.SqlServer.Management.Common.ExecutionFailureException: An exception occurred while executing a Transact-SQL statement or batch. --->
                        System.Data.SqlClient.SqlException: Cannot open backup device 'J:\Microsoft SQL Server\MSSQL10_50.EIQ\MSSQL\Backup\CustomerDefault_EIQRestore'. Operating system error 3(The system cannot
                        find the path specified.).
                        RESTORE DATABASE is terminating abnormally.
                           at Microsoft.SqlServer.Management.Common.ConnectionManager.ExecuteTSql(ExecuteTSqlAction action, Object execObject, DataSet fillDataSet, Boolean catchException)
                           at Microsoft.SqlServer.Management.Common.ServerConnection.ExecuteNonQuery(String sqlCommand, ExecutionTypes executionType, Boolean retry)
                           --- End of inner exception stack trace ---
                           at Microsoft.SqlServer.Management.Common.ServerConnection.ExecuteNonQuery(String sqlCommand, ExecutionTypes executionType, Boolean retry)
                           at Microsoft.SqlServer.Management.Common.ServerConnection.ExecuteNonQuery(StringCollection sqlCommands, ExecutionTypes executionType, Boolean retry)
                           at Microsoft.SqlServer.Management.Smo.BackupRestoreBase.ExecuteSql(Server server, StringCollection queries)
                           at Microsoft.SqlServer.Management.Smo.Restore.SqlRestore(Server srv)
                           --- End of inner exception stack trace ---
                           at Microsoft.SqlServer.Management.Smo.Restore.SqlRestore(Server srv)
                           at CallSite.Target(Closure , CallSite , Object , Object )
                           --- End of inner exception stack trace ---
                           at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
                           at Invoke-DbaAdvancedRestore<End>(Closure , FunctionContext )
                           --- End of inner exception stack trace ---
TargetObject          :
CategoryInfo          : NotSpecified: (:) [Write-Error], Exception
FullyQualifiedErrorId : dbatools_Invoke-DbaAdvancedRestore,Stop-Function
ErrorDetails          : Exception calling "SqlRestore" with "1" argument(s): "Restore failed for Server 'AP11DBC01N09'. "
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at Stop-Function, <No file>: line 193
                        at Invoke-DbaAdvancedRestore<End>, <No file>: line 293
                        at Restore-DbaDatabase<End>, <No file>: line 662
                        at Copy-DbaDatabase<Process>, <No file>: line 1071
                        at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {0, 1}

[X] Verified running the latest release of dbatools?
[X] Verified errors are not related to permissions?
[X] Can duplicate in new/clean PowerShell session (clean = powershell -NoProfile)?

Version Information

Operating System (Name|Version): Windows Server 2012 R2
PowerShell Version: 5.1.14409.1012
SQL Server (Edition|Version): Source: 2008 R2  Destination: 2016

Steps to Reproduce
Run the above Copy-DbaDatabase command on the misbehaving databases and it will fail every time.
dbatoolslog.zip

[X] Attach any screenshots (if possible/allowed)
[X] Attach logs generated by dbatools (Get-DbatoolsLog)
[X] Attach output from PowerShell console (if possible/allowed)

Problem to solve
Copy-DbaDatabase should always use the path given in the -NetworkShare parameter for the restore step.
Additional information
I believe the path in the large error above is a full file path and not a folder path. When I run this command on the other misbehaving databases, I get paths terminating in .bak files. So I believe CustomerDefault_EIQRestore was a filename with no extension and not a folder.

Hi @Bendy22 could you run Get-DbaBackupHistory -LastFull against the database please and let us know the results.
And then Get-DbaBackupHistory -LastFull -IncludeCopyOnly
My guess is that it's getting the path of the real full backup rather than the one that Copy-DbaDatabase is performing.
Tests may not work if there's been another full since the last fail. Don't know if you'd be able to rerun the copy if so?

Hi,
not forgotten, just having trouble reproing which means I'm guessing. Think I know where it's happening, jsut trying come up with a solid solution

Running into this issue again. I will attempt separate backup and restore steps for the databases that suffer from this problem for now. Thanks in advance for your help on getting this fixed.

same problem. Never had any problems with this until I updated DBATools...

Hi, same here.
But it only fails on one database (same) out of seven.
Copy-DbaDatabase -Source $SourceInstance -Destination $DestinationInstance -BackupRestore -NetworkShare $BackupSharedFolderUNC -Database $DB -ReuseSourceFolderStructure  -WithReplace -Force -Verbose:$Verbose
WARNING: [09:25:34][Copy-DbaDatabase] Failure attempting to restore DW_Metadata to GENINGDWHTEST01 | System.Data.SqlClient.SqlError: Cannot open backup device 'C:\Program Files\Microsoft SQL Server\MSSQL11 .MSSQLSERVER\MSSQL\Backup\{D828C1D5-7E1C-454A-A904-03F81736F1C7}1'. Operating system error 2(The system cannot find the file specified.).
Path C:\Program Files\Microsoft SQL Server\MSSQL11  doesn't exist nor on source nor on destination  server.
I can succesfully restore backup files which are left after Copy-DbaDatabase error with
Set-Location $BackupSharedFolderUNC
Get-ChildItem  | Restore-DbaDatabase -SqlInstance $DestinationInstance  -WithReplace -ReuseSourceFolderStructure

Hi, just updated to version 0.9.517 and still get the same error.

that's different ... seems you have backups done by an external party ... unless you have files named Backup{
D828C1D5-7E1C-454A-A904-03F81736F1C7}1

Yeah, we use  MS DPM ...

Yeah "we do have files named like that" or "yeah, we use DPM which doesn't leave files around" ?
Because if the latter is true, you can't use Copy-DbaDatabase if you keep having DPM actively backing up your instances.

I am sorry, but I am no longer have access to the client with this environment where I can re-test.

d'oh! down to @duncfair
thank you both for responding and thanks niph for handling it

Looks like my PR tag didn't make it into this one. This was one of the issues that the the Get-DbaBackuphistory/Backup-DbaDatabase  fixes should fix as it was most likely either:

Picking up a higher LSN backup from another ForkID
Picking up a concurrent 'proper' backup

fantastic news, thank you, @Stuart-Moore! Marking as closed.

Ok, thx for the explanation. I'm not familiar with DPM, don't know how it names backup files nor where it leaves them.  Still, Copy-DbaDatabase works fine for 6 out of 7 DBs,  all of them backed up using DPM.

Thanks for fixing this!

hum, not really.
irregardless of the backup software, the backup history is there. That's why there are ALREADY switches to identify virtual or disk backups.
The "grin" here is that get-dbabackuphistory does play well in most cases, EXCEPT backup forks (because they dirsupt the natural order of lsns, and get-dbabackuphistory follows strictly lsn order).
Main issue of get-dbabackuphistory -Last stands (given forks are allowed in MSSQL, lsn order can't always be trusted). Now, recent commits tame the "error" tring to restrict the set with -LastLsn and/or fetch infos from other sources, but the problem stll stays, albeit in a more "restricted corner".
The problem with Copy-DbaDatabase here is multifold, but basically the root cause is backup-dbadatabase using get-dbadbhistory to get the properties of the backup "just done". If you fall in the "restricted corner", the backup still happens, but the output object comes from a different "line in msdb".
We can tame more doing -DeviceType Disk (at least for the moment since backup-dbadatabase doesn't support anything else) and/or -Since (notloolongago), but the problem with get-dbabackuphistory and forks will still be there, just in more and more restricted corners, without solving the root cause (which would be a PITA, but it's technically solvable)

Hi Chrissy,
I am at another company site working on a project that includes the migration of multiple db’s (It was only supposed to be 2).
Go live is tonight but we have been using the copy-dbafatabase command extensively (and successfully) as recently as 3 days ago. Any updates since then?
Thanks,
Duncan
Best Regards,
Duncan Fairweather
805-907-8869

From: Chrissy LeMaire<EMAIL_ADDRESS>Sent: Thursday, November 15, 2018 5:23 PM
To: sqlcollaborative/dbatools
Cc: duncfair; Mention
Subject: Re: [sqlcollaborative/dbatools] Copy-DbaDatabase sometimes chooses incorrect path for restore step (#3225)
Can you test this again @janeztrhttps://github.com/janeztr , @duncfairhttps://github.com/duncfair or@Bendy22https://github.com/Bendy22 ? We've made a lot of mods since.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/sqlcollaborative/dbatools/issues/3225#issuecomment-439249461, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYZ6N9DKCe9795hF_EmfioDakO4_PFKSks5uvhOZgaJpZM4SDDCq.

awesome, that's great news @duncfair - thank you! No changes since then, looks like stuart's earlier changes worked 🎉

Hi, 0.9.533 update resolved my issue, thx!

fantastic! thanks for the update @janeztr 💯


fix: add tslib dependency to all packages relying on TS import helpers

Some @module-federation/ packages rely on the presence of tslib (due to the importHelpers: true setting in tsconfig.base.json). Due to conflicting versions of tslib in my dependency tree, npm wasn't able to hoist tslib which resulted in tslib being only available in the modules which explicitly are depending on tslib.
--> Adding tslib as dependency to all packages relying on ts import helpers should fix this issue.
An alternative to adding the tslib dependency would be setting the importHelpers flag to false.

Im not a TS pro, but do i even need importHelpers? happy to turn it off or merge this PR :)

I'm not a TS pro as well, but according to the TypeScript docu it would avoid a bit of repetition on the compiled js. On the other hand we have the additional size of the tslib dependency, so I guess at the end of the day is doesn't really matter in my opinion.
My personal two cents: We have a TypeScript repo as well and we ship our JS without the importHelpers and so far nobody complained, so I would also supporting turning the importHelpers off
I would say up to you, happy to change this PR to turn the helpers of if you want to.

yeah lets turn it off rather, tslib causes issues too in some of my internal packages when i hoist modules into the webpack runtime and they execute without tslib chunk ready yet, update the PR and if build passes, ill release tomorrow :) thanks for the quick inspection into it

Thanks for the feedback, just updated the PR and Title. Unfortunately I don't have better proposal for a good title, so feel free to rename it while merging 🙂

Looks like the Netlify Preview is failing because I can't confirm the deployment with my user, I guess that's something you need to retry and confirm :)

Hi @ScriptedAlchemy
just wanted to check whether there is anything open on my end which prevents this PR from merging?
Thanks!

Will merge and release


TableSelection

This PR implements a lazy type for selections/rejections.
Fix #16

Codecov Report

Merging #24 (2656f6b) into master (95ee4f3) will decrease coverage by 2.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   92.30%   89.57%   -2.74%
==========================================
  Files          14       14
  Lines         351      355       +4
==========================================
- Hits          324      318       -6
- Misses         27       37      +10

Impacted Files
Coverage Δ

src/transforms/select.jl
80.95% <0.00%> (-15.28%)
:arrow_down:

src/transforms/quantile.jl
93.33% <0.00%> (-1.12%)
:arrow_down:

src/transforms/scale.jl
92.30% <0.00%> (-1.03%)
:arrow_down:

src/distributions.jl
90.90% <0.00%> (-0.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ee4f3...2656f6b. Read the comment docs.

Another excellent PR 👍🏽


Improve device detection for build.sh

The current detection of devices for build.sh looks to see if there are any serial numbers available though system_profiler SPUSBDataType. This works well enough in our testing system as they are VMWare VMs, but on a real machine there are usually serial number entries for many devices in the tree, including internal USB hubs, keyboards, mice, etc... So the results from that code is either confused or wrong. Additionally the script will try to run Xcode for all of those devices, producing bad results for most of them.
The best way to do this is probably going to be to separate that code into a second script written in Python (that includes plist parsing utilities by default), and then use the system_profiler SPUSBDataType -xml and recursively iterate through the tree to find the proper devices, and then return their serial numbers. We do have some ruby code that already does this in another repository, but would need to bring along the plist module, and that feels a little heavyweight for this purpose.

How about using cfgutil list-devices instead? It can print its output as JSON for easier parsing too: cfgutil --format JSON list-devices
{
  "Command": "list",
  "Output": {
    "0x0BEEFDEADBEEF": {
      "locationID": 123456789,
      "UDID": "deadbeefdeadbeefdeadbeefdeadbeefdeadbeef",
      "ECID": "0x0BEEFDEADBEEF",
      "name": "JP's iPhone",
      "deviceType": "iPhone6,1"
    }
  },
  "Type": "CommandOutput",
  "Devices": [
    "0x0BEEFDEADBEEF"
  ]
}

cfgutil is only present if you have "Automation Tools" from "Apple Configurator 2" installed. Adding a MacAppStore app to the image (or the slightly shady route of copying the binaries from one) seems like a bigger commitment than either dragging along a Ruby library, or just using the build in Python.


Feature: Accounts in Devnet should not need to deploy a contract before they can interact with it.

Feature Request Summary
Once a contract is declared and deployed by a single devnet account, other accounts should be able to interact with that deployed account.
Detailed Description
At the moment once a contract has been declared and deployed by one of the accounts made available on devnet, on switching to a different account  the interact section displays a message that the contract had not been deployed yet, thereby prompting the new address to deploy a new instance of the compiled contract. This is an issues especially during contract testing where its required for multiple account to interact with the contract in order to execute certain functionalities (eg, contract ownership transfer) as at this moment when using Plugin version: v0.2.3 only the single account that deployed the contract has access to interact with the contract.
UI Update's

All contracts deployed by a unique user should be visible regardless of the account used for deployment.
The Interact section should list all deployed contract and buttons to interact with them similar to the way transaction section displays individual transactions.

Desired Behavior

Users should be able to utilize multiple devnet accounts to interact with a contract deployed by single devnet account.

Examples from Other Projects

Remix Deploy & Run plugin [https://remix-ide.readthedocs.io/en/latest/udapp.html]

Screenshot/GIF: [https://i.ibb.co/YQzWPqK/issue.png]

Yes! This would be an excellent feature. We may need to update the planned UI changes to incorporate a clean way to manage "deployed assets". @PaulUXD can you think about this when you have some time?


Requiring schema for Marshaling data 0.8

I am storing returns in redis and loading such data results in an undefined Class error.  Since the schemas are dynamically loaded how can I require the class beforehand so Ruby has the definition of the class loaded and can create an instance of it?
I am using version 0.8.

You're probably better off handling the marshaling to/from hashes or JSON yourself.
Even better is to update to 0.9.x which uses ahead-of-time code generation instead of generating things dynamically at runtime. Even then, I'd still recommend handling marshaling yourself if you're going to persist in redis.

Thanks much!  Done and done.


Fix %name, translation

%name is the name of a variable. It is probably a bug in magento to use a translate block for it in the first place, but the name of the variable must not be changed in a translation string. In the current version of mageplaza/magento-2-finnish-language-pack/fi_FI.csv this is translated as "%name,","%nimi,",module,Magento_GiftCard, which breaks email templates that use {{trans "%name," ...

👍
This is still valid. What I would do, however, is remove all of those lines as there really is no need to translate this variable. But if we need to translate it for some reason (as the github_contribution.csv does not really offer a way to delete lines) you should add all following lines there:
 "%name,","%name,",module,Magento_Company
 "%name,","%name,",module,Magento_Customer
 "%name,","%name,",module,Magento_CustomerBalance
 "%name,","%name,",module,Magento_GiftCard
 "%name,","%name,",module,Magento_GiftCardAccount
 "%name,","%name,",module,Magento_GiftRegistry
 "%name,","%name,",module,Magento_ProductAlert
 "%name,","%name,",module,Magento_Reminder
 "%name,","%name,",module,Magento_Reward
 "%name,","%name,",module,Magento_Rma
 "%name,","%name,",module,Magento_Sales
 "%name,","%name,",module,Magento_SendFriend
 "%name,","%name,",module,Magento_Theme
 "%name,","%name,",module,Magento_User
 "%name,","%name,",theme,frontend\Magento\luma


IE 11 breaking with Version 8.3.0

Describe the bug
Since the minor version bump to 8.3.0 we experience problem sin IE11 with uuid.
Based on the error we get it pinpoints to the code which introduced there.
https://github.com/uuidjs/uuid/pull/479/files#diff-016d740d7835ede8d0af47fe304f7191R16
SCRIPT1006: ')' erwartet (expected)
How to reproduce
Use uuid with IE11.
Expected behavior
It doesn't throw an exception and stops code execution.
Runtime

OS: All
Runtime: IE11

Additional information
Works fine on other browsers.
We currently solved it with downgrading to 8.2.0.
But it took us quite some time to find the problem to be in uuid, as it was just a minor version bump.
Thanks for looking into it.

@KevinGruber this comes unexpected since the browser tests for IE11 did pass for the 8.3.0 release.
How exactly are you using uuid? Can you provide a minimal reproducible example for the error, including the respective module bundlers etc.? This would help a lot in further debugging the issue.

Hi @ctavan,
Of course we are using webpack 4.
In the bundled code it complains about an closing )
And i found it now with a really small repo.
You are using default value in stringify for parameter offset and that is not allowed in ES5 and lower (IE11).
IE11 repo.zip
Should I open a PR?
I could do it tomorrow

Hi @KevinGruber. Thanks for providing further information.
Unfortunately to me this still does not explain the issue. Normally, webpack should pick up the files from dist/esm-browser/ for browser builds, and these files have been transpiled to ES5 in order to work with IE11. Specifically, if you look at<EMAIL_ADDRESS>line 14 you can see that the default parameter statement has been converted into something that IE11 understands.
So my suspicion is that something about the webpack config might be odd. You could try the examples from https://github.com/uuidjs/uuid/tree/master/examples/browser-webpack (just run npm start and open the example.html file with IE11) and compare with your setup or post a complete example which involves your exact build config here.

Hi @ctavan,
i see what is "wrong", you specify browser as module keyword.
which we skip on differential build, because module is only es6 and higher.
then we look at main which includes the node version of your script which breaks.
our mainField order is: legacy, unpkg, browser, main, module for the es5 builds.
I also saw you have browser specified, but I am not familiar with that syntax, are you overriding just certain files?
I will try to change the order for main and module, but I fear it will break other packages.

OK, this explains it.
From your config the relevant mainField values are browser -> main -> module.
This will effectively pick the CommonJS builds from ./dist and the three CommonJS browser overrides that are specified in package.json.
I don't see a reason to specify main before module when using webpack though, because webpack will effectively resolve all imports at build time and bundle everything together, no need to worry about ES6 import syntax ever hitting a browser. I would in fact definitely advise to swap the order, because with the current setup you won't get the benefits of tree shaking that ES modules give you.
All that said you are still revealing a small inconsistency with this package since we did not intend to break compatibility of the CommonJS build for old browsers. I'll look into this but I still see a lot of benefits of switching the mainFields order (in fact I wouldn't even change webpacks defaults unless you absolutely have to, this usually works fine even when bundling for old browsers).

I am trying right now if it still works with the switched order,
We sadly need to change it, as we have internal libraries which we build for es5,es6 and cjs and those are then imported accordingly into our isomorphic application.
Thanks I will close the Ticket than

@KevinGruber one other idea would be to use babel-loader in order to transpile uuid, see https://stackoverflow.com/questions/54043498/how-to-transpile-node-modules-modules-with-babel-loader


[web] use correct flutter commit for web engine tests on LUCI

We are planning to use youngest framework commit older than the engine as we did for cirrus in this script: https://github.com/flutter/engine/blob/master/tools/clone_flutter.sh
The recipe that needs this script is: https://flutter.googlesource.com/recipes/+/refs/heads/master/recipes/engine/web_engine_framework.py

marking as P3 since right now both trees become read at the same time since we are fetching the framework head to the engine repo for testing.
Initial PR is merged: https://github.com/flutter/engine/pull/21532

The recipe side changes are in, I'm closing this issue: https://flutter.googlesource.com/recipes/+/refs/heads/master/recipes/engine/web_engine_framework.py#133


migrate qset regression tests to python

usage is: pytest --pyargs pyth

or just pytest once some aditional cleanup is done


[transaction builder generator] update serde-generate

Motivation

update serde-generate to include many recent improvements
fix (ignored) python test

Test Plan
CI + manually run --ignored tests
Related PRs
https://github.com/novifinancial/serde-reflection/pull/60
https://github.com/novifinancial/serde-reflection/pull/61

release binaries dependency change summary:
target packages:
  M serde-generate 0.14.1 (direct third-party, crates.io)
    * version upgraded from 0.14.0
    * (unchanged features: [none])

@bors-libra land


error in patro 3 2081

This is because of the bug in the date conversion package we're using. I've opened an issue in their repo: https://github.com/opensource-nepal/go-nepali/issues/15


Event listener not catching bot reply messages

I shifted from slackeventsapi to bolt-python and was testing the functions and noticed that in bolt-python the reply messages that were sent by the bot are not being caught by event listener whereas in slackeventsapi, it was.
I want to make a function using the logs I get after storing the messages from the bot.
At first I was thinking that it is not listening to any bot messages but later while testing I found that it was listening to messages of other bots (I know this as I am logging the events in a log file). It is just not listening to it's own reply messages.
Is this made deliberately? And if yes, is there a way to disable it?
The slack_bolt version
slack-bolt==1.4.4
Python runtime version
Python 3.7.4
Steps to reproduce:

Given below is the configuration of the event listener

slack_signing_secret = xxx
slack_bot_token = xxx
app = App(
    token=slack_bot_token,
    signing_secret=slack_signing_secret
)

def run():
    port = xxx
    app.start(port=port, path="/")

@ app.event("message")
def handle_message(body):
    message = body["event"]
    logger(message)
    xxx

Expected result:
The reply messages from the bot are caught by the event listener and logged
Actual result:
The reply messages from the bot are ignored by the event listener

Hi @Shubhanker99, thanks a lot for migrating from the old module to this one!

Is this made deliberately?

Yes, it is. Resulting in an infinite loop by responding to the app's own message events is a common pitfall. Thus, this a bit opinionated framework decided a built-in prevention for it.

And if yes, is there a way to disable it?

As of today, there is no way to disable the middleware that skips the events generated by the bot user itself. However, we've already introduced the option to disable it in Bolt for Java two months ago:

https://github.com/slackapi/java-slack-sdk/pull/690/files
https://slack.dev/java-slack-sdk/guides/bolt-basics#customize-the-built-in-middleware-list

And we are going to apply the same changes to Python and Node SDKs soon. I cannot tell the exact date we'll release a new version including this fix yet but it won't take long (say, a few days).

@seratch Thank you for the reply. Looking forward for the next release date.


NCTL: Update nightly upgrade tests to use common sync check

Changes:

reworked how we were checking nodes in sync to use check_network_sync from the other nightlies
adds checking the reactor state is in either keepup or validate

ticket: https://app.zenhub.com/workspaces/cn-sre-60d363546afb85000e491ff6/issues/gh/casper-network/sre/715

bors r+

bors r+

bors r+


Check flag bridgeAutoInject before requesting bridge injection

In some cases injection timing for the bridge is not good.
For exemple, when using AMD (I know it's written in README file).
Adding a check on a simple flag "bridgeAutoInject", we allow user to disable bridge automatic injection.
So to disable bridge injection, just execute this in the document :
window.PHANTOMJS.bridgeAutoInject = false;

Then to execute the bridge injection, just call for it :
alert('inject');

This change helped me using grunt-mocha with AMD based system, maybe it can help others.

Sorry for the late reply, but could you also add documentation for this option?


Fix tests

The tersts are fixed. Gzip opening now works. There is one failing test because the species field is generated as a single value rather than an array


Integrate new AMD loader into build/serve

Integrates https://github.com/Polymer/tools/tree/master/packages/esm-amd-loader into the tools.
Fixes https://github.com/Polymer/tools/issues/211

@rictic @justinfagnani this is rebased and ready for final review.


Edit content for candidate withdrawal mailer

Context
We need to make sure our emails make sense for continuous applications.
we have an email that gets sent when a candidate withdraws their application themselves.
Changes proposed in this pull request
Changes to this mailer include:

replacing 'dear' with 'hello'
updating the 'still_interested_content' - I've not put this under a feature flag as I don't think it needs it, but perhaps I'm wrong?
updating the candidate_mailer_spec - again not feature flag needed as it's just the 'hello' part

Guidance to review
Could someone make sure the tests are working and check that the 'still_interested_content' looks ok as this renders across multiple emails, but I think it still makes sense if we don't use the continuous application feature flag.
Link to Trello card
https://trello.com/c/fhgm3cLI/475-edit-content-for-email-when-candidate-withdraws-their-own-application
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault

 Edit content for email when candidate withdraws their own application


can not make it working...

Hi, whenever I use the script I have the following error. please advise.
Traceback (most recent call last):   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 604, in <module>     main(sys.argv[1:])   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 601, in main     generate(inputfile,outputfile)   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 574, in generate     g.process();   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 554, in process     self.dbModel.build(self.root)   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 259, in build     t.build(i)   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 151, in build     c.build(i)   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 98, in build     pk = subnode_value(xmlNode,"PK")   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 77, in subnode_value     node = find_subnode_by_name(node,sub_name)   File "./vertabelo-sqlalchemy/vertabelo_sqlalchemy.py", line 73, in find_subnode_by_name     raise Exception("couldn't find tag '%s' in '%s'" % (sub_name, node)) Exception: couldn't find tag 'PK' in '<DOM Element: Column at 0x7fae1bb04908>'

Hi,
Please pull changes from this repo. I've just pushed support for newer version of Vertabelo XML. Please let me know if it works for you.

Hi Rafał,
Sorry about the late reply. It works great now. Thank you so much.
Mingque
On Thursday, March 3, 2016, Rafał Strzaliński<EMAIL_ADDRESS>wrote:

Hi,
Please pull changes from this repo. I've just pushed support for newer
version of Vertabelo XML. Please let me know if it works for you.
—
Reply to this email directly or view it on GitHub
https://github.com/Vertabelo/vertabelo-sqlalchemy/issues/3#issuecomment-191728757
.

I have this problem too.


Replace demo template by Showcase

Thanks to functionality introduced by Storybook, we have now good component development tool and very nice component showcase demonstration. Demo app becomes a bit useless.
@ComFreek Some time ago you proposed to remove app / demo template and keep only library in this repository. I think now we can do it. What do you think?
Planned tasks:

Replace gh-pages demo to Storybook
Remove root app and keep only projects/atft
Modify API Docs: Generate docs for atft library
Adjust pipeline
Update readme

Creation of separate repo with project template => don't think it's really needed, considering standard atft library. Readme sample should be enough.

Good idea!
The only thing I am missing from Storybook is the option to show the corresponding source code. Is this doable somehow?

Replace gh-pages demo to Storybook

I'd still put the deploy storybook into ./storybook on gh-pages and deploy the API documentation to ./ on gh-pages. Since the API documentation still shows the repo README, e.g. click on https://makimenko.github.io/angular-template-for-threejs/.

Creation of separate repo with project template => don't think it's really needed, considering standard atft library. Readme sample should be enough.

Yep + link to storybook.
What about people who just want to download/clone a repo and get instantly running after npm install? I would see how many steps are needed in the new approach. (Particularly, I am myself sometimes like this and skip to the next opensource library if I can't get the first running in <= some minutes -- or at least if I don't get a feel for how many steps are needed.)

show the corresponding source code

will check

I'd still put the deploy storybook into ./storybook

Ok

people who just want to download/clone a repo

Yeah... Then let's keep AppComponent here for time being.


Propagate 'ephemeralDiskDir' from flag

What this PR does / why we need it: Now ephemeralDiskDir is propagated from the flag instead of constant.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): None
Special notes for your reviewer: None
Release note:
Propagate `ephemeralDiskDir` from flag.

Hi @VirrageS
Release note is used for user-facing changes. Correct me if I am wrong but there is no user-facing change.
/test-required

/test all

hey @xpivarc,
so sorry, I didn't know that. Yes, you are correct, there are no user-facing changes. I've just changed release notes to NONE.

/cc @acardace Mind having a look?

/assign @acardace

/ok-to-test


@user mention possible?

Is it possible to get typeahead.js work like a mention on github by just start typing @ symbol?
Thanks!

You can use library like this https://github.com/jakiestfu/Mention.js/ with typeahead dependency.

Is it not for the old Typeahead implementation that was used in old Bootstrap?

Yes, it's for old.


chore: variable 'editor' collides with imported package name

Variable 'editor' collides with imported package name

When changing variables please try to be more verbose rather than making things shorter. edit is not good variable name :)


Linking debug statements should not print for fluid components

https://github.com/terrapower/armi/blob/147008e586ac08c8dec6dc461b000cb3b5cb0d6c/armi/reactor/converters/axialExpansionChanger.py#L527-L548
Relates to #1048.

While you're here, using b.p.flags and c.p.flags isn't all that helpful.... It should be just {b} and {c}.
Also, this should be pulled into a table via from tabulate import tabulate.

This could use more "description" in the "description" above.

Ooh yeah. Good point. My bad!

Are you proposing a one line change? Just open the PR!

Wasn't sure lol. Just wanted to document the idea at the time without getting side tracked and dealing with it right in the moment. It's very low priority relative to other things...

tabulate is such a mess. It's slow to run, annoying to install. I don't want to use it everywhere.

Ooh hot take! Do you have alternatives to tabulate that you prefer?


Updated slingshot critical telemetry message ID name

Summary and Scope
The message id of the slingshot fabric critical telemetry data has been updated to CrayFabricCriticalTelemetry from CrayFabricCritTelemetry.

Also FYI @mjendrysik-hpe @nieuwsma this is a PR to merge changes into the integration/ss_health_topics branch.

@danielvaz46 when did Slingshot roll this change out? what Shasta release?   Is the currently broken in LIME or STRAWBERRY?   We need to make sure we braking a production version.

@danielvaz46 when did Slingshot roll this change out? what Shasta release? Is the currently broken in LIME or STRAWBERRY? We need to make sure we braking a production version.

Hi @nieuwsma,
Sorry for the delayed response.
Slingshot rolled out this change in Slingshot 1.5 released in October.
It is currently broken in LIME

@danielvaz46  is there a JIRA for this change?

@danielvaz46 is there a JIRA for this change?

Yes. https://jira-pro.its.hpecorp.net:8443/browse/CASMSMF-6765

@nieuwsma I have tested out the change on frigg. Below is a screenshot of the data now flowing into kafka.

Do let me know any additional details are required. Otherwise, can we proceed with the merging of this PR.
Thanks

This change has been merged with:
https://github.com/Cray-HPE/hms-hmcollector/pull/36


Guard against racy access to NSError.setUserInfoValueProvider.

This API is documented in its headers to only allow being called once for a particular domain, so we have to make sure our check for an existing provider is synchronized with the setting.
rdar://problem/27541751

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test OS X platform

Thanks to @gparker42 for helping track this down!
@phausler, does this seem like the best fix?

also cc @DougGregor for when he gets back from vacation.

@swift-ci Please smoke test OS X platform

@jrose-apple Just checking to make sure smoke tests were triggering and reporting correctly.

No response from Philippe; how about @parkera?

LGTM

Thanks, Tony!

Good find, @jrose-apple and @gparker42.


Nixpacks Bug Report

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Every docker image built with Nixpacks using my stack (NestJS + MongoDB + Passport) ends up in a SIGILL termination. Don't know if the issue is with Nixpacks itself or the underlying structure (Coolify) orchestrating the build and execution process.
The error presented is this: "Command was killed with SIGILL (Invalid machine instruction): /tmp/yarn--1722899316954-0.961741874653044/node dist/main", witch came from the logs inside the container.
Seems it crashes when i try to authenticate through any sort of strategy available in Passport. I've tried using Api Key auth, JWT bearer auth, and always when i call the auth endpoint it crashes, but only the endpoint witch are guarded and require auth. The rest of the REST API is fine, no other endpoint generates the SIGILL, just the auth endpoints.
Tried executing the same code running on a pm2 instance and everything worked out just fine, the whole authentication process included.
To reproduce

Create app with nest cli
Add api key auth flow
Create endpoints to interact with the authentication
Upload app to git and deploy it using Coolify
Execute said endpoints
Get SIGILL error inside container logs

Expected behavior
Don't present the SIGILL error.
Environment
Coolify v4.0.0-beta.319
Nixpacks v1.24.1
Ubuntu 20.04
Package.json:
{"dependencies": {
"@nestjs/cache-manager": "^2.2.2",
"@nestjs/common": "^10.0.0",
"@nestjs/core": "^10.0.0",
"@nestjs/event-emitter": "^2.0.4",
"@nestjs/passport": "^10.0.3",
"@nestjs/platform-express": "^10.0.0",
"@nestjs/swagger": "^7.4.0",
"@nestjs/throttler": "^6.0.0",
"cache-manager": "^5.7.4",
"class-transformer": "^0.5.1",
"class-validator": "^0.14.1",
"crypto-js": "^4.2.0",
"mongoose": "^8.5.2",
"passport": "^0.7.0",
"passport-headerapikey": "^1.2.2",
"puppeteer": "^22.15.0",
"qrcode": "^1.5.3",
"reflect-metadata": "^0.2.0",
"rxjs": "^7.8.1",
"whatsapp-web.js": "^1.25.0",
"wwebjs-mongo": "^1.1.0"
},
"devDependencies": {
"@dotenvx/dotenvx": "^1.6.4",
"@nestjs/cli": "^10.0.0",
"@nestjs/schematics": "^10.0.0",
"@nestjs/testing": "^10.0.0",
"@types/express": "^4.17.17",
"@types/jest": "^29.5.2",
"@types/node": "^20.3.1",
"@types/qrcode": "^1.5.5",
"@types/supertest": "^6.0.0",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"eslint": "^8.42.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-prettier": "^5.0.0",
"jest": "^29.5.0",
"prettier": "^3.0.0",
"source-map-support": "^0.5.21",
"supertest": "^6.3.3",
"ts-jest": "^29.1.0",
"ts-loader": "^9.4.3",
"ts-node": "^10.9.1",
"tsconfig-paths": "^4.2.0",
"typescript": "^5.1.3"
}}

Solved, it is a bug in dotenvx. I just won't play nice with docker yet. Waiting for updates.

@vitusan do you know where the SIGILL is originating from? dotenvx only calls debug on a SIGILL at the moment. https://github.com/dotenvx/dotenvx/blob/1d005b7d7687bb5c7a85684dc1cca5920e5583ce/src/lib/helpers/executeCommand.js#L8

well, @motdotla, it was running inside a container created with nixpacks, but funny enough, this behavior only happened when inside a container. Running the very same code in bare metal, nothing like this happened. And all it took was a call to an endpoint that handled auth. But the NestJs app was indeed using other variables, and the app seemed to work without any problem. The app would start and run stable. Well, the variables seemed to match the .env declarations, everything checks. So i don't really know where it came from, except when my code tried to access the endpoint containing the said auth variable decrypted with dotenvx, things would break with a SIGILL. Best i can do is upload a sample repo and ask that you try to deploy it with coolify with the same setup.

thanks, keep me posted.


How to load different objects in different environment (used in case of parallel simulation)

I wonder how to load different objects such as different target objects for manipulation in different environment, which is common in other simulator, such as mujoco and isaacgym.  Thanks advance.

Here is how add it: Object_1 = scene.add_entity(gs.morphs.Sphere(pos =(1,1,1)))
Object_2 = scene.add_entity(gs.morphs.Box(pos =(2,2,1)))
Object_3 = scene.add_entity(gs.morphs.Cylinder(pos =(3,3,1)))

Hmm in parallel sim, every env is identical
Indont think mujoco or Isaac support this either

Hmm in parallel sim, every env is identical
Indont think mujoco or Isaac support this either

I do remember isaacgym supports loading different objects in different environments. And there is also a solution in IsaacSim:
https://github.com/isaac-sim/IsaacLab/issues/186


Instructions need clarifications

In "Set up the sample simulator", "click the App Service resource type" there are multiple App Services. User needs to choose the one that starts with Simulator.
It then says "click Configuration" while the link is actually called "Connection".
Under "Register devices" the asset should be bi-directionally registered, however this requires the setup from "Authorize API connection", which is the next article from the navigation, but should be concluded before the actual registration, otherwise the registration fails.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa26d244-ef58-79e5-27a6-f179af283134
Version Independent ID: 0ffcc47d-c378-39a9-3ed4-81eea0096aa2
Content: Installation & setup for Connected Field Service for IoT Hub (Dynamics 365 Field Service)
Content Source: ce/field-service/installation-setup-iothub.md
Service: dynamics-365-customerservice
Technology: field-service
GitHub Login: @FieldServiceDave
Microsoft Alias: daclar

Thank you for sharing this feedback. I started working on Field Service docs a few days ago and do some housekeeping on open issues.
The listed doc issues are addressed in an upcoming publish that is expected to go live next week.
Closing this issue as solved. Please keep your feedback coming!
Thanks,
Michael


Norm universal links mobile

Adding content for universal/app links, and introduction material to put it in context.

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:warning:Warning

Details

msteams-platform/concepts/tabs/tabs-requirements.md
:warning:Warning

Details

msteams-platform/resources/general/general-overview.md
:warning:Warning

Details

msteams-platform/includes/get-started/step1-prepare-for-dev.md
:warning:Warning

Details

msteams-platform/includes/get-started/step1-intro.md
:warning:Warning

Details

msteams-platform/assets/images/go-to-website-icon.png
:white_check_mark:Succeeded

msteams-platform/resources/general/media-formats.md
:white_check_mark:Succeeded

msteams-platform/resources/general/requirements.md
:white_check_mark:Succeeded

msteams-platform/TOC.yml

[Warning] Invalid file link:(~/resources/dev-preview/developer-preview-intro).
[Warning] Invalid file link:(~/concepts/authentication/auth-silent-AAD).
[Warning] Invalid file link:(~/resources/design/framework/search).
[Warning] Invalid file link:(~/resources/resource-overview).
[Warning] Invalid file link:(~/concepts/bots/bots-test).
[Warning] Invalid file link:(~/resources/general/cross-domain).
[Warning] Invalid file link:(~/concepts/activity-feed).
[Warning] Invalid file link:(~/concepts/cards/cards).
[Warning] Invalid file link:(~/concepts/bots/bots-overview).
[Warning] Invalid file link:(~/concepts/tabs/tabs-context).
[Warning] Invalid file link:(~/concepts/tabs/tabs-content).
[Warning] Invalid file link:(~/resources/design/components/color).
[Warning] Invalid file link:(~/scenarios/scenarios).
[Warning] Invalid file link:(~/resources/design/framework/apps).
[Warning] Invalid file link:(~/concepts/outgoingwebhook).
[Warning] Invalid file link:(~/concepts/connectors).
[Warning] Invalid file link:(~/resources/design/resources).
[Warning] Invalid file link:(~/resources/design/framework/submitting).
[Warning] Invalid file link:(~/resources/design/framework/basics).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-conv-proactive).
[Warning] Invalid file link:(~/concepts/tabs/tabs-configuration).
[Warning] Invalid file link:(~/samples/code-samples).
[Warning] Invalid file link:(~/concepts/bots/bots-notifications).
[Warning] Invalid file link:(~/resources/schema/manifest-schema).
[Warning] Invalid file link:(~/concepts/apps/apps-package).
[Warning] Invalid file link:(~/concepts/authentication/auth-tab-AAD).
[Warning] Invalid file link:(~/get-started/get-started-tenant).
[Warning] Invalid file link:(~/resources/design/overview).
[Warning] Invalid file link:(~/concepts/tabs/tabs-requirements).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-conv-personal).
[Warning] Invalid file link:(~/resources/design/framework/tabs).
[Warning] Invalid file link:(~/resources/dev-preview/developer-preview).
[Warning] Invalid file link:(~/resources/design/framework/bots).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-conv-channel).
[Warning] Invalid file link:(~/concepts/authentication/auth-bot-AAD).
[Warning] Invalid file link:(~/concepts/concepts-overview).
[Warning] Invalid file link:(~/resources/general/general-overview).
[Warning] Invalid file link:(~/troubleshoot/faq).
[Warning] Invalid file link:(~/concepts/tabs/tabs-update-remove).
[Warning] Invalid file link:(~/concepts/bots/bots-menus).
[Warning] Invalid file link:(~/concepts/bots/bots-notification-only).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-cards).
[Warning] Invalid file link:(~/get-started/get-started).
[Warning] Invalid file link:(~/concepts/apps/apps-design).
[Warning] Invalid file link:(~/concepts/bots/bots-create).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-message-format).
[Warning] Invalid file link:(~/resources/general/media-formats).
[Warning] Invalid file link:(~/concepts/authentication/auth-configure).
[Warning] Invalid file link:(~/concepts/authentication/auth-flow-bot).
[Warning] Invalid file link:(~/get-started/get-started-nodejs).
[Warning] Invalid file link:(~/resources/design/components/fields).
[Warning] Invalid file link:(~/resources/design/framework/activity-feed).
[Warning] Invalid file link:(~/resources/design/framework/messaging-extensions).
[Warning] Invalid file link:(~/concepts/cards/cards-format).
[Warning] Invalid file link:(~/concepts/bots/bots-with-tabs).
[Warning] Invalid file link:(~/publishing/apps-publish).
[Warning] Invalid file link:(~/concepts/authentication/auth-flow-tab).
[Warning] Invalid file link:(~/resources/dev-preview/developer-preview-features).
[Warning] Invalid file link:(~/concepts/bots/bot-conversations/bots-conversations).
[Warning] Invalid file link:(~/get-started/app-studio-component-library).
[Warning] Invalid file link:(~/resources/general/rate-limit).
[Warning] Invalid file link:(~/resources/design/components/typography).
[Warning] Invalid file link:(~/resources/microsoft-graph).
[Warning] Invalid file link:(~/publishing/office-store-guidance).
[Warning] Invalid file link:(~/concepts/apps/apps-overview).
[Warning] Invalid file link:(~/concepts/deep-links).
[Warning] Invalid file link:(~/resources/design/components/buttons).
[Warning] Invalid file link:(~/concepts/authentication/authentication).
[Warning] Invalid file link:(~/resources/design/components/dialogs).
[Warning] Invalid file link:(~/concepts/cards/cards-reference).
[Warning] Invalid file link:(~/publishing/office-store-checklist).
[Warning] Invalid file link:(~/concepts/cards/cards-actions).
[Warning] Invalid file link:(~/concepts/messaging-extensions).
[Warning] Invalid file link:(~/overview).
[Warning] Invalid file link:(~/resources/design/components/themes).
[Warning] Invalid file link:(~/resources/design/framework/command-box).
[Warning] Invalid file link:(~/resources/general/debug).
[Warning] Invalid file link:(~/whats-new).
[Warning] Invalid file link:(~/get-started/get-started-app-studio).
[Warning] Invalid file link:(~/get-started/get-started-dotnet).
[Warning] Invalid file link:(~/feedback).
[Warning] Invalid file link:(~/troubleshoot/troubleshoot).
[Warning] Invalid file link:(~/get-started/get-started-dotnet-in-azure).
[Warning] Invalid file link:(~/concepts/tabs/tabs-static).
[Warning] Invalid file link:(~/concepts/tabs/tabs-overview).
[Warning] Invalid file link:(~/concepts/apps/apps-upload).
[Warning] Invalid file link:(~/concepts/bots/bots-context).

msteams-platform/concepts/tabs/tabs-requirements.md

Line 21: [Warning] Invalid file link:(~/resources/schema/manifest-schema#validdomains).
Line 23: [Warning] Invalid file link:(~/troubleshoot/troubleshoot).
Line 34: [Warning] Invalid file link:(~/concepts/tabs/tabs-configuration#determine-the-content-to-display-in-the-tab).

msteams-platform/resources/general/general-overview.md

Line 15: [Warning] Invalid file link:(~/resources/general/media-formats).
Line 16: [Warning] Invalid file link:(~/resources/general/cross-domain).
Line 17: [Warning] Invalid file link:(~/resources/general/debug).
Line 18: [Warning] Invalid file link:(~/resources/general/rate-limit).
Line 24: [Warning] Invalid file link:(~/feedback).

msteams-platform/includes/get-started/step1-prepare-for-dev.md

Line 10: [Warning] Invalid file link:(~/get-started/get-started-tenant).
Line 10: [Warning] Invalid file link:(~/get-started/get-started-tenant).
Line 15: [Warning] Invalid file link:(~/get-started/get-started-tenant).
Line 15: [Warning] Invalid file link:(~/get-started/get-started-tenant).

msteams-platform/includes/get-started/step1-intro.md

Line 3: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 3: [Warning] Invalid file link:(~/concepts/apps/apps-overview).
Line 5: [Warning] Invalid file link:(~/get-started/get-started-app-studio).
Line 5: [Warning] Invalid file link:(~/get-started/get-started-app-studio).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


updateTrace does not plot lines with NaNs

Hi,
currently, updateTrace does not plot lines containing NaNs.
Code below produces just one line instead of two:
import numpy as np
from visdom import Visdom
viz = Visdom()
win = viz.line(Y=np.array([1, 2]), X=np.array([1, 2]), opts={'legend': ['a']})
viz.updateTrace(X=np.array([1, 2, 3]), Y=np.array([2, 1, float('nan')]),
                win=win, name='b')

This looks like a bug, indeed. It is presumably related to this functionality: "Trace update data that is all NaN is ignored; this can be used for masking update." Will investigate...

Note: I think you can replace float('nan') by None to "ignore" the point when plotting. Does this solve your issue?

@lvdmaaten Thanks, that works!


Avoid a very unlikely race condition

[x] Double-check the spelling and grammar of all strings, code comments, etc.
[x] Double-check that all code is deterministic that needs to be
[x] Add tests to cover any new or revised logic
[x] Ensure that the test suite passes
[x] Update the project release notes
[x] Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

Did this race condition get triggered?

nope!


Getting Started with Snowflake - Zero to Snowflake - Spelling mistakes

There are spelling mistakes in the lab. (https://quickstarts.snowflake.com/guide/getting_started_with_snowflake/index.html). These are listed below.
Part 2

Snowfflake

Part 4

buttion

Part 5

sset

Part 7

tto

Part 9

Snowfalke
acceess
Orgamization
usaged

Part 10

glick

Part 12

Sighn

Looks like this is a duplicate of #231


build: enable -race for go test

The latest commit disables race detection on arm64 only, as our runners seem not to like it very much.
However, all other platforms would still keep it enabled.


Jekyll Compress Layout not rendering a compressed page

I'm not sure if this is just chalked up to an issue with the particular Liquid renderer used in Pretzel or something else, but using the Jekyll Compress layout (https://github.com/penibelst/jekyll-compress-html) doesn't actually output compressed HTML on build.
Fortunately it does still build, there's just no difference between using the layout and not using the layout.

Thanks for the issue.
After a quick glance at the layout it based solely on Liquid so theoretically it should work.
But I think some adaptation have to be made, because we don't have the same variables than jekyll, like jekyll.environment .


[$500] IOU - Returning to the Workspace selection, another workspace is displayed for a second

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap fab--- Request money--- Distance
Enter start point and finish way point
Tap next
Select the first Worspace
Tap app back button

Expected Result:
The pre-selected first workspace should be selected and displayed on tapping back
Actual Result:
The second workspace is shown as selected for an second and then only pre-selected first workspace selected and displayed on tapping back
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/817d5180-5314-406f-b5bf-8089e684adf8
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015be8f0bebfdc2b11
Upwork Job ID:<PHONE_NUMBER>078821888
Last Price Increase: 2024-01-10

Dupe of https://github.com/Expensify/App/issues/33068


doppelgreener: Watch javacodepoint.com

doppelgreener requests the watch of the watch_keyword javacodepoint.com. See the Metasmoke search here

!!/approve


Multiple instances fight over user_settings.json

Tried to run MDE in multiple instances at the same time and this popped up in one of them:

Does this always happen? I run multiples all the time without issue so I'm looking for any additional details to help find this.

It was the first time I saw this.

I've been thinking about removing the file watcher from the settings file (the others, template, snippets would remain). It results in some unexpected behavior. For example, with two instances open change to show/hide line numbers in one of them. Both change. While it's convienent to have the app update when editing the settings file directly, it's perhaps not done often enough to warrant monitoring for changes.

I can also confirm this issue exists, but I wasn't able to find a consistent repro. I got it when I installed MDE for the first time, opened two instances and probably changed settings in both. As I couldn't repro it afterwards, on a whim I deleted the json file, then started two instances again and managed to reproduce it that time. However, I don't have a concrete set of steps. It does seem to involve opening two instances, then activating the option to load the json file in an external editor (urg, Notepad), making a change in the external editor and saving it. I can't remember now if I then tried changing settings again in the two instances, I did a lot of random clicking trying to get a repro ;)

I think I have a way of fixing this without removing the file watchers. Look for it in the next release.


Create a footer-white-16

One need to make this component using HTML and Tailwind CSS.
Here is a reference to the component.

Please assign me @Rajdip019


Can't paste into EditText when it's empty - OnePlus 6

Library Version:
2.0 -> 3.0.2
Affected Device(s):
OnePlus 6 Android 9
Describe the Bug:
When I long press an empty MaterialDialog input (edittext), the Paste button is not shown.
To Reproduce:
        MaterialDialog(this).show {
            title(R.string.title)
            message(R.string.message)
            input(hintRes = R.string.hint)
            positiveButton(android.R.string.ok)
            negativeButton(android.R.string.cancel)
        }

Try to long press on the EditText to paste something in the clipboard.
This happens only when the text is empty. If a type a char and retry it pops up.
Expected Behavior:
It should popup the Paste option.

Unable to reproduce on my Pixel 3 XL. I suspect this could be an OS issue on OnePlus.

Thanks for the confirmation.
I just tested it on an other device and the problem did not occur.
I have never had this before though.
I will do more tests, and if I come up with something I will create a pull request.
Thanks.

Same issue on OnePlus 5.

Closing since this is out of my control.


Trigger calcUpdate() calls for changes to option labels

Fixes #412
This is a fix for the example form shown in #412
I'm not convinced this is safe or optimal for a few reasons:

there may be other types of choice which are supported by jr:choice-name, but don't use .option-wrapper
I'm not 100% certain how the string passed to calcUpdate() should be calculated, but cutting the form name off the front of the fully-qualified xpath to the model element seems to work (owName.substring( owName.indexOf( '/', 1 ) ))
there may be cases when an <output> can occur within .option-wrapper but outside an option label, in which case calcUpdate() will be triggered needlessly

Perhaps if nothing else, this fix will give a clearer insight into what the bug in #410 really is!

What an issue! :) I responded in #412.


Removed lines that break NIR

Hey Karsten!
I had to remove these 3 lines to be able to run your benchmark experiment on line 10 of nir_benchmark_runs.sh
Are they important? Or are these an artifact of something you were testing?

Thanks for the fixes! Very much appreciated!


Add a combineLatest / zipLatest operator

Should take the latest value from the provided Streams / Publishers.
For publishers in push streams, each one of which may execute asynchronously, only one can push values downstream at a time (so when one publisher is active any additional values to be pushed need to be queued).

ReactiveSeq<Status> service1Health;
ReactiveSeq<Status> service2Health;

service1Health.combineLatest(service2Health)
              .subscribe(this::pushLatestHealth,this::logHealthCheckError);

Moving this to 2.0.0-MI6 as a number of bugs need to be fixed in MI5 as well as some changes to support cyclops 9.0, this is a moderately large feature to implement.


Branch a appointment button

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7ee9ac7). Click here to learn what that means.
The diff coverage is 1.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##             master     #214   +/-   ##
=========================================
  Coverage          ?   50.00%
  Complexity        ?      506
=========================================
  Files             ?      107
  Lines             ?     2488
  Branches          ?      262
=========================================
  Hits              ?     1244
  Misses            ?     1169
  Partials          ?       75

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/person/Person.java
69.49% <0.00%> (ø)

...in/java/seedu/address/ui/AddAppointmentWindow.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/ui/AddPatientWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/DetailDisplay.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

...ava/seedu/address/logic/commands/ClearCommand.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added the support email to the contributing document

Per our meeting I've added the Console Connect support e-mail to the contributing document. if we want to remove it in the context of questions, I'll be happy to adjust it.

Rebased the work to align with current changes and formatting. We should be good for review.

Pulled in the new CI stuff.


Implement Carbon Quiz Models

Sorry about the confusion regarding reviews. Thank you to my teammate Cao Mai for his swift approval on Slack!


Add sparse.linalg.norm

Takeover #3234.

cc @cjnolet

Discussed offline, we will be backporting this to v8.

Jenkins, test this please.

Jenkins CI test (for commit 0f3ad20a379edf8c73b5f2960b2b81e0019ecbf4, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 0f3ad20a379edf8c73b5f2960b2b81e0019ecbf4, target branch master) succeeded!

LGTM!


[Ultimate Dev] Symbology not drawing correctly

https://studio.boardgamearena.com/table?table=499160, move ~6.  MadisonSilver1 has 3 leaves and 2 lightbulbs, which should let them draw a 2 off of symbology, but the dogma doesn't do anything.

            foreach (self::getPlayerResourceCounts($player_id) as $icon => $count) {
                if ($count >= 4) {
                    $num_resources_four_or_more++;
                    $num_resources_three_or_more++;
                    $num_resources_two_or_more++;
                } elseif($count >= 3) {
                    $num_resources_three_or_more++;
                    $num_resources_two_or_more++;
                } elseif($count >= 2) {
                    $num_resources_two_or_more++;
                }
            }

            if ($num_resources_four_or_more >= 4) {
                // "If you have four each of four icons on your board, draw a 4."
                self::executeDraw($player_id, 4);
            } elseif ($num_resources_four_or_more >= 3) {
                // "Otherwise, if you have three each of three icons on your board, draw a 3."
                self::executeDraw($player_id, 3);
            } elseif ($num_resources_four_or_more >= 2) {
                // "Otherwise, if you have two each of two icons on your board, draw a 2."
                self::executeDraw($player_id, 2);
            }

            $num_resources_four_or_more  appears too many times on the bottom elseifs.

The top part can be simplified by making 3 different if's instead of using elseif

The bug was that we were using num_resources_four_or_more in all three spots in the bottom.


fix issues 4611

#4611

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mengmeng.song seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@wenshao 帮忙review一下


Optimization of RF structure for MAGIC+LST1 analysis

we should check different schemes of creating RFs for joint analysis, and comparing their performance with the up-to-date MCs:

M1+LST1, M2+LST1, M1+M2, M1+M2+LST1 (all combinations) - current scheme
M1, M2, LST1 - each telescope separately + common (e.g. stereo) parameters - like CTA scheme
M1+M2+LST1  all in one RF, zeroing the parameters if the telescope does not surviving cleaning - similar to MAGIC scheme
... (any other scheme?)

comparison of g/h separation performance on MC and on data

I put myself but any contributions are very welcome!

Hi, I think I can collaborate in this issue.


chore: test code coverage

Description
Adds a code coverage report during PRs that compares coverage of the PR vs that of the main branch.
Related Issue
Fixes #463

Relates to #
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


How to make new WebSocket?

How to make new WebSocket on "onclose" event?
Thanks a lot.

can you make an example?


Latest change to reactphp/stream broken header parser

Hi,
Please note, that RequestHeaderParser has maxSize around 4096. It does not work with latest react streams as there is a high chance the first buffer would be longer, than 4096 bytes

@nick4fake good catch, would you mind making a PR fixing that?

@WyriHaximus yes, doing that right now. :)

Awesome :+1:

Closed via #88