Create Deterministic forecasts from SingleTimeSeries

I've made this a draft because I haven't fully tested everything but wanted to give you guys a preview.
I implemented the compromise design that we agreed to yesterday.  After doing so, I advise against using this.  I think it will cause us maintenance headaches in the future.  src/deterministic.jl is now kind of a mess.  I think we should do what I originally proposed but will defer to you.

After testing the workflow the following found these problems:

[ ] remove_component! breaks if run after IS.transform_single_time_series!: Here is the stack trace:

[1] _get_time_series_path(::HDF5.HDF5Group, ::Base.UUID) at /Users/jdlara/.julia/dev/InfrastructureSystems/src/hdf5_time_series_storage.jl:404
 [2] (::InfrastructureSystems.var"#94#95"{InfrastructureSystems.Hdf5TimeSeriesStorage,Base.UUID,Base.UUID,String})(::HDF5.HDF5File) at /Users/jdlara/.julia/dev/InfrastructureSystems/src/hdf5_time_series_storage.jl:250
 [3] h5open(::InfrastructureSystems.var"#94#95"{InfrastructureSystems.Hdf5TimeSeriesStorage,Base.UUID,Base.UUID,String}, ::String, ::Vararg{String,N} where N; swmr::Bool) at /Users/jdlara/.julia/packages/HDF5/T1b9x/src/HDF5.jl:696
 [4] h5open at /Users/jdlara/.julia/packages/HDF5/T1b9x/src/HDF5.jl:694 [inlined]
 [5] remove_time_series! at /Users/jdlara/.julia/dev/InfrastructureSystems/src/hdf5_time_series_storage.jl:248 [inlined]
 [6] clear_time_series_storage!(::VariableReserve{ReserveUp}) at /Users/jdlara/.julia/dev/InfrastructureSystems/src/component.jl:625
 [7] prepare_for_removal!(::VariableReserve{ReserveUp}) at /Users/jdlara/.julia/dev/InfrastructureSystems/src/component.jl:478
 [8] _remove_component!(::Type{VariableReserve{ReserveUp}}, ::InfrastructureSystems.Components, ::String) at /Users/jdlara/.julia/dev/InfrastructureSystems/src/components.jl:143
 [9] remove_component! at /Users/jdlara/.julia/dev/InfrastructureSystems/src/components.jl:110 [inlined]
 [10] remove_component! at /Users/jdlara/.julia/dev/InfrastructureSystems/src/system_data.jl:293 [inlined]
 [11] remove_component!(::System, ::VariableReserve{ReserveUp}) at /Users/jdlara/.julia/dev/PowerSystems/src/base.jl:537
 [12] top-level scope at /Users/jdlara/Dropbox/Code/nrel-experiments/data_conversion_test.jl:63
 [13] include_string(::Function, ::Module, ::String, ::String) at ./loading.jl:1091
 [14] invokelatest(::Any, ::Any, ::Vararg{Any,N} where N; kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at ./essentials.jl:710
 [15] invokelatest(::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:709
 [16] inlineeval(::Module, ::String, ::Int64, ::Int64, ::String; softscope::Bool) at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/eval.jl:83
 [17] (::VSCodeServer.var"#43#45"{VSCodeServer.ReplRunCodeRequestParams,String,Int64,Int64,String,Module,Bool})() at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/eval.jl:45
 [18] withpath(::VSCodeServer.var"#43#45"{VSCodeServer.ReplRunCodeRequestParams,String,Int64,Int64,String,Module,Bool}, ::String) at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/repl.jl:118
 [19] (::VSCodeServer.var"#42#44"{VSCodeServer.ReplRunCodeRequestParams,String,Int64,Int64,String,Module,Bool,Bool})() at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/eval.jl:43
 [20] hideprompt(::VSCodeServer.var"#42#44"{VSCodeServer.ReplRunCodeRequestParams,String,Int64,Int64,String,Module,Bool,Bool}) at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/repl.jl:36
 [21] repl_runcode_request(::VSCodeServer.JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint,Base.PipeEndpoint}, ::VSCodeServer.ReplRunCodeRequestParams) at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/eval.jl:23
 [22] dispatch_msg(::VSCodeServer.JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint,Base.PipeEndpoint}, ::VSCodeServer.JSONRPC.MsgDispatcher, ::Dict{String,Any}) at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/JSONRPC/src/typed.jl:66
 [23] macro expansion at /Users/jdlara/.vscode/extensions/julialang.language-julia-1.0.8/scripts/packages/VSCodeServer/src/VSCodeServer.jl:95 [inlined]
 [24] (::VSCodeServer.var"#61#63"{Bool,String})() at ./task.jl:356
in expression starting at /Users/jdlara/Dropbox/Code/nrel-experiments/data_conversion_test.jl:58

For the following tests, I move the call to IS.transform_single_time_series! after the modifications to the system

After testing the workflow the following found these problems:

Thanks.  I fixed it.


snapshot_data cron job seems broken

newest-changes directory is empty..

The saving should happen on line 284 of
/home/maximilianklein/WIGI/gender-index-processing-standalone.py

@hargup newest-changes isn't updated.

OK the issue is that.... I think i broke it. There was an extra unexpected file "longitude.tar.gz" which I created and it was in snapshot_data. The diffing script crashes if it finds unexpect files in the snapshot_data dir. Anyway. There is just one more step to do. Which is to move the nikola build process into the script /home/maximilianklein/Wikidata-Toolkit/wdtk-examples/run_wigi_cron.sh
@vivekiitkgp @hargup can you move the may you build nikola into the end of /home/maximilianklein/Wikidata-Toolkit/wdtk-examples/run_wigi_cron.sh.  @hargup said this is possible now despite previous issues by just invoiking sudo su before building so that nikola has access to the right files.

@vivekiitkgp this was not fixed. there were two issue that I had to solve:

inserting git pull origin master to update the nikola code was failing because it was waiting for input to unlock the ssh key
/var/www/html was still pointing to the manydev/wigi-website/output/ it is now pointing to maximilianklein/wigi-websits/output/

Geez! Thanks for fixing the rest. I had no idea about 1 and I thought I fixed the second. :/


Mower stopped in the middle of tasks

Not sure if related to #88, but it appears the mower just stopped all of a sudden on the latest update. Here is the log, where there appears to be some errors listed. I'm just not sure if they are causing it to stop all of a sudden. The log starts right before the server was started, then the tasks were selected to run.
cassandra.log

2023-10-07 12:15:36 INFO RX:ardumower/Ardumower/stats message:b'{"duration_idle":71359,"duration_charge":2229177,"duration_mow":128485,"duration_mow_invalid":60,"duration_mow_float":9957,"duration_mow_fix":118468,"distance_mow_traveled":33298,"counter_gps_chk_sum_errors":191,"counter_dgps_chk_sum_errors":0,"counter_invalid_recoveries":37,"counter_float_recoveries":334,"counter_gps_jumps":224,"counter_gps_motion_timeout":27,"counter_imu_triggered":1,"counter_sonar_triggered":41,"counter_bumper_triggered":0,"counter_obstacles":245,"time_max_cycle":0.09,"time_max_dpgs_age":4.65,"serial_buffer_size":1024,"free_memory":192459,"reset_cause":5,"temp_min":998,"temp_max":998}'
2023-10-07 12:15:38 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.38,"position":{"x":-14.47,"y":27.3,"delta":3.01,"solution":2,"age":0.45,"accuracy":0.02,"visible_satellites":34,"visible_satellites_dgps":30,"mow_point_index":242},"target":{"x":-14.46,"y":24.34},"job":1,"sensor":0,"amps":1.98,"map_crc":4486467}'
2023-10-07 12:15:44 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.42,"position":{"x":-14.51,"y":27.06,"delta":-1.55,"solution":2,"age":0.38,"accuracy":0.02,"visible_satellites":33,"visible_satellites_dgps":31,"mow_point_index":242},"target":{"x":-14.46,"y":24.34},"job":1,"sensor":0,"amps":1.68,"map_crc":4486467}'
2023-10-07 12:15:50 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.45,"position":{"x":-14.48,"y":25.84,"delta":-1.55,"solution":2,"age":0.34,"accuracy":0.02,"visible_satellites":35,"visible_satellites_dgps":31,"mow_point_index":242},"target":{"x":-14.46,"y":24.34},"job":1,"sensor":0,"amps":1.58,"map_crc":4486467}'
2023-10-07 12:15:56 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.48,"position":{"x":-14.44,"y":25.28,"delta":-1.53,"solution":2,"age":0.4,"accuracy":0.02,"visible_satellites":35,"visible_satellites_dgps":31,"mow_point_index":242},"target":{"x":-14.46,"y":24.34},"job":1,"sensor":0,"amps":1.41,"map_crc":4486467}'
2023-10-07 12:16:26 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.66,"position":{"x":-14.44,"y":24.69,"delta":0,"solution":2,"age":0.55,"accuracy":0.02,"visible_satellites":0,"visible_satellites_dgps":0,"mow_point_index":0},"target":{"x":0,"y":0},"job":0,"sensor":0,"amps":0.01,"map_crc":0}'
2023-10-07 12:16:32 INFO RX:ardumower/Ardumower/state message:b'{"battery_voltage":27.68,"position":{"x":-14.43,"y":24.69,"delta":0,"solution":2,"age":0.6,"accuracy":0.02,"visible_satellites":34,"visible_satellites_dgps":29,"mow_point_index":0},"target":{"x":0,"y":0},"job":0,"sensor":0,"amps":0.02,"map_crc":0}'
2023-10-07 12:16:37 INFO RX:ardumower/Ardumower/stats message:b'{"duration_idle":14,"duration_charge":0,"duration_mow":0,"duration_mow_invalid":0,"duration_mow_float":0,"duration_mow_fix":0,"distance_mow_traveled":0,"counter_gps_chk_sum_errors":1,"counter_dgps_chk_sum_errors":0,"counter_invalid_recoveries":0,"counter_float_recoveries":0,"counter_gps_jumps":1,"counter_gps_motion_timeout":0,"counter_imu_triggered":0,"counter_sonar_triggered":0,"counter_bumper_triggered":0,"counter_obstacles":0,"time_max_cycle":0.02,"time_max_dpgs_age":0,"serial_buffer_size":1024,"free_memory":240499,"reset_cause":4,"temp_min":998,"temp_max":998}'

You have issues in your sunray FW:

normally your state topic are published every 5sec. The last state topic with job mow and next state topic with job idle have time difference of 30sec. -> It means you had a firmware reset

also you can see your firmware reset in stats topic, it changes the value of reset_cause from 5 to 4. I don't know exactly what 4 means, but you can find it out by studying sunray code.

Similar observation with latest 1.0.319 firmware - after a timeout (I added a watchdog to the sunray service) the sunray service gets restarted but remains then in IDLE mode.  Maybe as a workaround Cassandra could restart the MOW operation in case of unexpected IDLE state (and timeout?)


Log key thumbprints less often

We are currently attempting to track changes in the encryption key used by MSAL, since changes in that
key will cause failures when reading that are difficult to detect that may be due to other problems.  To isolate
this, we were logging a hashed, fixed-value encryption every time we wrote an entry.
This was noisy for one of our customers, so we went to turn it down, and looking at the logs it wasn't working properly, because the cipher was being run in CBC mode, meaning that every value was different.
This code corrects that flaw and only logs if it detects that there has been a change in the key.

Can we add a PR description to this? Don't have context for this work

Can we add a PR description to this? Don't have context for this work

done. I put you on this mainly because it's messing very lightly with encryption algorithms, and though there doesn't seem to be a better way to do this given the java SecretKey api, you might know one.  (or know that .equals always works for SecretKey)


feat: add greetings file

Description
This PR adds a greeting.yml file.

Type of PR
[X] ✨ Feature
[] 🐞 Bug fix
[] 📄 Documentation update
[] Others
Related Issue
Closes #3

Hi @CBID2, this greeting GitHub action is nice tho.
I've been analyzing it since I saw it from Eddiehub repo.
Personally, I use the actions/first-interaction@v1, have you tried it before?

No tell me more @geoffreylgv. :)

Hi @CBID2, this greeting GitHub action is nice tho.
I've been analyzing it since I saw it from Eddiehub repo.
Personally, I use the actions/first-interaction@v1, have you tried it before?

No tell me more @geoffreylgv. :)

Alright, It's also simple to use and pr or issue message customization; similar to the one you added

Allow me to suggest something, on the call of the github.actor, if you put the @ it will notice he/her (the actor)
 @${{ github.actor }}

Hey @saragerion. I made the necessary changes

Hey @CBID2,
How's the progress here? Do you need more time or help?

Hey @CBID2,
How's the progress here? Do you need more time or help?

Hey @adiati98. I tried finding the latest version of the greeting in EddieHub's repo to no avail. It's needed in order to solve the security part.

Do you want to keep working on this?

Hey @CBID2,

How's the progress here? Do you need more time or help?

Hey @adiati98. I tried finding the latest version of the greeting in EddieHub's repo to no avail. It's needed in order to solve the security part.

Do you want to keep working on this?

Yes

Hey @CBID2,

How's the progress here? Do you need more time or help?

Hey @adiati98. I tried finding the latest version of the greeting in EddieHub's repo to no avail. It's needed in order to solve the security part.

Do you want to keep working on this?

Yes

Awesome! Please keep us posted. 👍
And do let us know if you can't go further. We can close this and you can always create a new issue and PR once you figure something out. 🙂

@CBID2 I want to inform that as there is no progress for this PR in the last 3 weeks, I'm putting it on draft. Feel free to change the status as "ready for review" once you've resolved it.
However, because it's already open for 4 months, if you haven't resolved it by next week (February 14th), I will close this PR. You can open a new issue and PR in that case if you're still interested. Thank you. 😊
cc: @saragerion


Type checking issue when querying a database: properties field

Report bugs here only for the Node JavaScript library.
If you're having problems using Notion's API, or have any other feedback about the API including feature requests for the JavaScript library, please email support at<EMAIL_ADDRESS>Describe the bug
When querying a database the response types are suggesting that 'properties' does not exist on 'PartialPageObjectResponse'
Property 'properties' does not exist on type 'PageObjectResponse | PartialPageObjectResponse | PartialDatabaseObjectResponse | DatabaseObjectResponse'.
  Property 'properties' does not exist on type 'PartialPageObjectResponse'

 const response = await notionClient.databases.query({
      database_id: databaseId,
      filter: {
        property: marketCode,
        select: {
          equals: market?.toLowerCase(),
        },
      },
    });

    const results = response.results[0]?.properties;

Below is the response when querying the database; you can see properties exist.
{
  object: 'page',
  id: '10...',
  created_time: '2024...',
  last_edited_time: '2024...',
  created_by: { object: 'user', id: '48e6f...' },
  last_edited_by: { object: 'user', id: '48e6...' },
  cover: null,
  icon: null,
  parent: {
    type: 'database_id',
    database_id: '10d...'
  },
  archived: false,
  in_trash: false,
  properties: {
    'Market...': { id: 'BMOO', type: 'select', select: [Object] },
    'Market...': { id: 'G%3DDn', type: 'select', select: [Object] },
    ...
  },
  url: 'https://www.notion.so/...',
  public_url: null
}

Is there a way to handle this, instead of me manually defining the response which seems unnecessary.
To Reproduce
Node version:
Notion JS library version:
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Please include any screenshots that help explain your problem.
Additional context
Add any other context about the problem here.

When querying database using a filter, I receive a "body failed validation" error
APIResponseError: body failed validation. Fix one:
body.filter.or should be defined, instead was `undefined`.
body.filter.and should be defined, instead was `undefined`.
body.filter.title should be defined, instead was `undefined`.
body.filter.rich_text should be defined, instead was `undefined`.
body.filter.number should be defined, instead was `undefined`.
body.filter.checkbox should be defined, instead was `undefined`.
body.filter.select should be defined, instead was `undefined`.
body.filter.multi_select should be defined, instead was `undefined`.
body.filter.status should be defined, instead was `undefined`.
body.filter.date should be defined, instead was `undefined`.
body.filter.people should be defined, instead was `undefined`.
body.filter.files should be defined, instead was `undefined`.
body.filter.url should be defined, instead was `undefined`.
body.filter.email should be defined, instead was `undefined`.
body.filter.phone_number should be defined, instead was `undefined`.
body.filter.relation should be defined, instead was `undefined`.
body.filter.created_by should be defined, instead was `undefined`.
body.filter.created_time should be defined, instead was `undefined`.
body.filter.last_edited_by should be defined, instead was `undefined`.
body.filter.last_edited_time should be defined, instead was `undefined`.
body.filter.formula should be defined, instead was `undefined`.
body.filter.unique_id should be defined, instead was `undefined`.
body.filter.rollup should be defined, instead was `undefined`.
    at async ProjectsList (./src/app/components/ProjectsList.tsx:23:35)
digest: "716658379"

const { results } = await notion.databases.query({
    database_id: databaseId!,
    filter: {
      property: "Tags",
      contains: "AI",
    }
  });
  console.log(results);

Below is the response when querying the database; you can see properties exist.
[
{
  object: 'page',
  id: '039c4ca9-e237-481a-9581-',
  created_time: '2024-10-01T20:21:00.000Z',
  last_edited_time: '2024-10-05T00:35:00.000Z',
  created_by: { object: 'user', id: 'f65771fb-5ea1-4e48-b963-' },
  last_edited_by: { object: 'user', id: 'f65771fb-5ea1-4e48-b963-' },
  cover: null,
  icon: null,
  parent: {
    type: 'database_id',
    database_id: '112794ea-af04-8071-8225-'
  },
  archived: false,
  in_trash: false,
  properties: {
    'Current Versions': [Object],
    'Github Repos': [Object],
    Directory: [Object],
    'Main Run Command': [Object],
    'Short Description': [Object],
    Tags: [Object],
    Name: [Object]
  },
  url: 'https://www.notion.so/....',
  public_url: null
}
]

Node version: 20.17.0
Notion JS library version: v2.2.15
I also have typescript issues when trying to access the custom properties. It seems like the typescript definitions are not accurate when it comes to properties.

See section Type Guards from the README. These narrow types for the use case you show.
TypeScript Playground with an example of safely reading .properties from a query result.


Cosmos partitioning

Fixes #1234
Description
Parity with Dotnet, adding a separate class for supporting Partitioned Containers on Cosmos.
Specific Changes

The new implementation no longer handles database creation. We only handle container creation.
Uses the new @azure/cosmos SDK
Implements partitioning for the user, with the option to pass in a key now gone. We utilize the ID of the item as the partition key.

Also implements these additional changes from the Dotnet PR
Testing
Added new, separate tests.

On a side note: I plan to eventually create a StorageBaseTests class for the JS repo, so we remove a lot of the duplicate code. Wanted to get this out for 4.6, though.

Note: Currently figuring out how to make the tests record.

@christopheranderson Great feedback! I should be able to fix those tomorrow.

Pull Request Test Coverage Report for Build 82544

12 of 69 (17.39%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 86.484%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-azure/src/cosmosDbPartitionedStorage.ts
11
68
16.18%

Totals

Change from base Build 82444:
-0.9%

Covered Lines:
4656

Relevant Lines:
5180

💛  - Coveralls

Please merge when ready.

@cleemullins Will do. Implementing @christopheranderson's recommendations now and will merge once build tests passes.
However, coveralls test coverage won't allow merge. I believe the issue is that most of the tests don't actually run since there's no Storage Emulator. Is that something we can bypass? ...I don't believe any of the JS storage tests actually run the read/write/deletes in the pipeline tests.

@mdrichardson @christopheranderson Let's discuss handling non partitioned etc tomorrow when you get online. I have some specific thoughts here.


[zh] translate blog "Dockershim Deprecation FAQ"

This is a Feature Request
translate  /blog/_posts/2020-12-02-dockershim-faq.md
What would you like to be added
content/zh/blog/_posts/2020-12-02-dockershim-faq.md
/assign
/language zh

/triage accepted


cli improperly sets "code" in "exec" content for blackbox actions

> wsk -v action create bb --docker aa
...
{{"exec":{"kind":"blackbox","code":"","image":"aa"}}

The code property should not be defined. In any case, the controller will ignore it so it's harmless but is confusing, especially when doing this:
>  wsk -v action get bb
Response body received:
{
  "name": "bb",
  "exec": {
    "kind": "blackbox",
    "image": "aa"
  }, ...
}

but the CLI will render the exec as:
ok: got action bb
{
    "name": "bb",
    "exec": {
        "kind": "blackbox",
        "code": "",
        "image": "openwhisk/example"
    }, ...
}

@rabbah - Just confirming.  Upon action creation, when code is empty, should it be removed from the request body?

It could be omitted but this one is harmless on PUT in that the controller ignores it correctly. The confusing one is on the get: the CLI is showing a code property that doesn't actually exist in the schema.

@rabbah, I am able to omit the code field if it is empty. There are several tests that failures that result though. These are related to NodeJS actions being created without and code field. The backend expects at least an empty string for NodeJS action code.

Looks like the failures are due to tests using a js file that has no code in it.

This illustrates the problem with encoding the schema/types in the CLI - they're inconsistent wrt the API and complicate the CLI implementation. The code property exists for nodejs and other runtimes but not docker actions.

I hit this issue as well during sequence cleanup. I'm removing code from the sequence exec. Can we make progress on #1469 which seems to be the fix to this issue?

Fixed by https://github.com/openwhisk/openwhisk/commit/c4064ae0e93dd156682c36632924ae63cf719410.


Fix typographical and grammatical errors and inconsistencies

The initial list of hits was generated with the codespell command
below, and each hit was evaluated and fixed manually while taking
context into consideration.
DIRS="kernel/ frontends/ backends/ passes/ techlibs/""
codespell $DIRS -S *.o -L upto,iff,thru,synopsys,uint

More hits were found by looking through comments and strings manually.

Also, there are a number of typos in ezsat and subcircuit libraries, but I wasn't able to find the upstream source for these. Do you have a repository somewhere I should add a PR against, or should I just fix them here?

Also, there are a number of typos in ezsat and subcircuit libraries, but I wasn't able to find the upstream source for these. Do you have a repository somewhere I should add a PR against, or should I just fix them here?

There is no other repo for those two libraries. This is already upstream. They are just in libs/ because they are written in a manner that resembles a self-contained library.

All fixed.


Fixes issue #1868- implement form validation

Implemented input validation to "Create new Organization" form
🗣 Description

Added "required field" and "error" attribute to the "Organization Name" as well as disabled the "Save" button if there is no input in the field in order to prevent empty inputs from being uploaded into the database.
💭 Motivation and context

Currently, there is no validation in place to verify user inputs are valid and prevent user misuse. Users are able to upload "empty" forms to the database.

Adding form validation protects the database against user misuse and other potential vulnerabilities.

This PR resolves issue #1868.
🧪 Testing

📷 Screenshots (if appropriate)

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Marked OBE - Due to planned redesign in Q2.


How to add a vertices?

Thanks for your work, it's quiet a nice project!
I want to add a new vertices through RESTPP.updata(self, graph, content)
when I type content like:
{'vertices': 'vertices','vertex_type': 'ElecItem', 'vertex_id': '1', 'attributes': {'p': 1}}
cause Error:
RESTPPError: The payload format parsing error, the string type variable is only allowed for attribute value or operator.

I recommend you to read the tigergraph restful api documentation for the exact format this method receives.
update actually calls POST /graph, the payload format looks like this:
{
 "vertices": {
    "User": {
      "id6": {
      }
    }
  },
  "edges": {
    "User":{
      "id1": {
        "Liked": {
          "User": {
            "id6" : {
              "weight" : {
                "value": 5.0
              }
            }
          }
        }
      },
      "id6": {
        "Liked_By": {
          "User": {
            "id1" : {
              "weight" : {
                "value": 1.0
              }
            }
          }
        }
      }
    }
  }
}

I recommend you to read the tigergraph restful api documentation for the exact format this method receives.
update actually calls POST /graph, the payload format looks like this:
{
 "vertices": {
    "User": {
      "id6": {
      }
    }
  },
  "edges": {
    "User":{
      "id1": {
        "Liked": {
          "User": {
            "id6" : {
              "weight" : {
                "value": 5.0
              }
            }
          }
        }
      },
      "id6": {
        "Liked_By": {
          "User": {
            "id1" : {
              "weight" : {
                "value": 1.0
              }
            }
          }
        }
      }
    }
  }
}

ok，thanks

I recommend you to read the tigergraph restful api documentation for the exact format this method receives.
update actually calls POST /graph, the payload format looks like this:
{
 "vertices": {
    "User": {
      "id6": {
      }
    }
  },
  "edges": {
    "User":{
      "id1": {
        "Liked": {
          "User": {
            "id6" : {
              "weight" : {
                "value": 5.0
              }
            }
          }
        }
      },
      "id6": {
        "Liked_By": {
          "User": {
            "id1" : {
              "weight" : {
                "value": 1.0
              }
            }
          }
        }
      }
    }
  }
}

I find a bug in RESTPP.py
def delete_vertices(self, graph, vertex_type, vertex_id=None, **kwargs):
    """
    kwargs:
        filter: attr1>30,attr2<=50,...
        limit: 10
        sort: attr1,-attr2
        timeout: 0 in seconds
    """
    endpoint = "/graph/{0}/vertices/{1}".format(graph, vertex_type)
    if vertex_id:
        endpoint += "/" + vertex_id
    return self._get(endpoint, kwargs)

line 247 must be return self._delete(endpoint, kwargs)

Thanks for reporting this bug! I will fix this problem in next minor release.

I find a bug in RESTPP.py again
def query(self, graph, query_name, **kwargs):         """         run a specific query         """         return self._get("/{0}/{1}".format(graph, query_name), kwargs)
line 301 should be
return self._get("/query/{0}/{1}".format(graph, query_name), kwargs)


pytorch implication version

There is code for the release of the pytorch version. If so, when will it be released? I'm looking forward to it

Thanks for your interests! We will release the pytorch implementation within a month.


stake-pool: Update docs and help messages

Problem
Stake pool docs are out of date.
Solution
Update them!  This mainly adds sections about:

fees
liquid staking
0.001 SOL minimum for validator accounts
Rust docs
easy-add validator

Thanks for updating these docs! The new description of fees in particular is super helpful. A few suggestions/questions for you:
Line 55-60:

When a validator deposits SOL, does the stake pool manager create a stake account for them? And then deposit that into the stake account? (And that’s just seen as the additional risk with stake pools that take SOL deposits vs only taking fully activated stake accounts?)
When a user deposits SOL into a stake pool will it go directly into the reserve account?

Lines 60-62:
“Alternatively, users can deposit a stake account into the pool.  To do this, they must delegate a stake account to the one of the validators in the stake pool. Once it's active, the user can deposit their stake into the pool.”

Is this equivalent to delegating a stake account to a stake pool’s “preferred validator”?
How long does a user need to wait after delegating a stake account before it’s active (and they can deposit their stake into the pool)?

Line 92: can we add a sentence here that reads something like “The user will get back their SOL stake account immediately but note it will take a 1-2 epochs for the stake account to deactivate and for the user to be able to withdraw their SOL”. Feel free to adjust with the correct language.
Line 124-125 this “Maintenance mode. If the pool needs more time to reset fees or otherwise, the manager can temporarily make the pool private” may be misinterpreted as the stake pool manager temporarily taking control of user deposits. Is there another way to describe “making the pool private”? Is it more like a temporary restriction on new deposits?
For lines 280 to 284, this is true in the current reference implementation right? This isn’t a new feature that existing stake pool (running this reference implementation) would need to upgrade to?
Line 428-429: when the validator stake account is removed, the withdraw authority doesn’t change (it still belongs to the delegator), so what specific authority in the stake account belongs to the administrator? Want to update this line “Unlike a normal withdrawal, the validator stake account is totally moved from the stake pool and into a new account belonging to the administrator” to reflect that stake pool managers don’t suddenly just get access to all delegator’s stake accounts.

Thanks for the review!  I've updated the docs to reflect your questions / feedback.  To answer the specific points:

When a validator deposits SOL, does the stake pool manager create a stake account for them?

When adding a validator, the stake pool will do all the work of creating the stake account and adding it

When a user deposits SOL into a stake pool will it go directly into the reserve account?

Yep!

Is this equivalent to delegating a stake account to a stake pool’s “preferred validator”?

Yes, if the stake pool has a preferred validator.  I added something to clarify for that point.

How long does a user need to wait after delegating a stake account before it’s active (and they can deposit their stake into the pool)?

Added language to clarify that, it'll soon be max one epoch once some fixes all roll out.

Line 92: can we add a sentence here that reads something like “The user will get back their SOL stake account immediately but note it will take a 1-2 epochs for the stake account to deactivate and for the user to be able to withdraw their SOL”. Feel free to adjust with the correct language.

Done

Line 124-125 this “Maintenance mode. If the pool needs more time to reset fees or otherwise, the manager can temporarily make the pool private” may be misinterpreted as the stake pool manager temporarily taking control of user deposits. Is there another way to describe “making the pool private”? Is it more like a temporary restriction on new deposits?

Good point, clarified that

For lines 280 to 284, this is true in the current reference implementation right?

Yep, clarified that

Line 428-429: when the validator stake account is removed, the withdraw authority doesn’t change (it still belongs to the delegator), so what specific authority in the stake account belongs to the administrator?

Clarified this too, and the validator stake account effectively gets moved to the staker when it's removed. The old account is no more, and the new one belongs entirely to the staker (both authorities).


Weird problems building async-profiler -g3 on arm64 linux

I'm not sure exactly why, but changing Makefile:13 to use -g3 causes this assignment in flameGraph.cpp
        const char* tail = TREE_TEMPLATE;

to somehow result in tail pointing somewhere in the debug table.  In the debugger, you can print out both TREE_TEMPLATE and tail; the former correctly holds the contents of the html file, while the latter is gibberish.  This of course means that the strstr in printTill returns NULL, and we dump core.
I see this only on arm64 linux (specifically ubuntu 20.04 running in parallels on an M1 mac), not on x64.
Obviously, I was debugging a PR with more changes than just the optimization flags, but I verified the problem with a clean build of current master.

I think I found a way round. Please try if it helps.

It works.  Thanks.


RuntimeException at io.branch.referral.InstallListener.captureInstallReferrer

We use the Branch Cordova SDK v2.6.5 (latest), but are seeing a bunch of native Android crashes in our production app. We haven't been able to reproduce this locally, but we've seen this happen on Android 7.1, 7.0, 6.0 as well as multiple devices such as the Nexus 6P, Galaxy S8, OnePlus3T and more.
Did some digging, and it looks like this is caused by https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/os/Handler.java#200. Thoughts?
Full Stacktrace:
java.lang.RuntimeException:
  at android.os.Handler.<init> (Handler.java:200)
  at android.os.Handler.<init> (Handler.java:114)
  at io.branch.referral.InstallListener.captureInstallReferrer (InstallListener.java:41)
  at io.branch.referral.Branch.registerAppInit (Branch.java:2280)
  at io.branch.referral.Branch.initializeSession (Branch.java:2234)
  at io.branch.referral.Branch.initUserSessionInternal (Branch.java:1238)
  at io.branch.referral.Branch.initSession (Branch.java:895)
  at io.branch.referral.Branch.initSession (Branch.java:969)
  at io.branch.BranchSDK.initSession (BranchSDK.java:234)
  at io.branch.BranchSDK.access$200 (BranchSDK.java:31)
  at io.branch.BranchSDK$RunnableThread.run (BranchSDK.java:1238)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1133)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:607)
  at java.lang.Thread.run (Thread.java:761)

@jonathankau the only I can see  this crash can happen when you call initSession from a non UI thread. You create handler inside thread that has not called Looper.prepare(). So can you please  make sure the initSession is happening on main thread

@jonathankau Where you able to fix the problem by changing to Main thread?

@sojanpr Sorry about that, as I mentioned in the initial issue, we're using a wrapper around the native Android branch SDK through Cordova: https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking#initialize-branch. Thus, we don't have trigger the native Java code ourselves, the plugin does.
We're following the instructions for the Cordova plugin, but it seems to be causing an error in the native code. Mind seeing if you can pull in one of the Cordova plugin authors?

@jonathankau we are taking a  look at the cordova sdk. Will update you soon. Can you please update which version of SDK you are using

@sojanpr We are using the latest version of the Cordova SDK, unless you were asking about the Android SDK? I believe the Android SDK is included as a dependency in the Cordova SDK https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/build.gradle#L11, so we should be using the latest Android SDK as well.

Thanks for that info. We are trying few ways to reproduce it locally. Will keep you posted.

Hello @jonathankau,
We are still unable to reproduce the crash locally, but when investigating the issue, we noticed that we were calling Branch.initSession() from a background thread within the Cordova SDK. This is unneeded because we automatically push the Branch.initSession() to a background thread within our Android SDK. By playing around with this assumption, we were able to crash the app with the Branch SDK.
I have pushed a new version of the Branch Cordova SDK (2.6.6). Can you please update your Branch Cordova SDK to the latest version to see if the crashes stop?
Thanks,

I sent an updated APK to an affected user and that new Cordova commit fixed the issue for them. We'll roll out the change to the rest of our users and see whether the crashes completely disappear. Thanks for the quick turnaround time @ethanneff @sojanpr!

Thanks for the update @jonathankau -- Please get back to us if the crashes don't completely disappear.


build: only include used composable-helpers

This PR configures the add-on ember-composable-helpers to only include a specific set of helpers when the project is built.
According to your HBS files, you only use the helper sort-by:
https://github.com/miragejs/ember-cli-mirage/search?l=handlebars

Is this really needed? composable helpers is a dev dependency meaning it really only applies to the  docs. This change would strip the unused helpers from the docs site, but really has no bearing on any app that includes mirage.

@cah-briangantzler I guess it's not strictly needed, but since it also only affects the docs site, and make the payload a little smaller I'm still going to merge it :)


feat: Add graphql.persisted() utility to create persisted stand-in documents

Related to #77
Related to https://github.com/0no-co/GraphQLSP/pull/240
Related to https://github.com/urql-graphql/urql/pull/3515
Summary
This implements a graphql.persisted() function, as per the RFC in #77.
This accepts a documentId string and returns a value that matches a GraphQL.js DocumentNode shape but contains no definitions. The resulting value contains no reference to the original document, while the return type of graphql.persisted() matches the document’s type that's been passed in.
The returned type is also transformed to a more strict type that clearly indicates that the documentId is present but that no definitions are present.
Set of changes

Add graphql.persisted()
Add TadaPersistedDocumentNode

Merging since I expect this to be somewhat usable before the next release


Rate limiting is applied to sendCertificate

As an AggLayer node, I want to be able to rate limit the submission of certificates on my JSON-RPC API, so that CDKs can't abuse the settlement.
Pending questions and comments
Linked tickets

[x] Update the configuration to handle rate limiting configuration
[x] Define and implement the different response returned by the AggLayer in case of reaching a limit

#222

[ ] Implement the rate limiting logic on both sendTx and sendCertificate RPC

#291
#271

[ ] Add documentation related to the error codes returned by the JSON-RPC api

Acceptance Criteria

[ ] Sending a Certificate to the API increment the counter for one network
[ ] Sending a Certificate while having reach the limit returns an error

Definition of Done

[ ] All acceptance criteria are met.
[ ] Code is reviewed and approved.
[ ] Necessary tests are written and pass.
[ ] Documentation is updated, if applicable.
[ ] Feature is part of a release (created or planned).

Related issues

#213
#219

Based on the meeting of today:
Outcome
We discuss that to be future-proof on how we want to manage the certificates as inputs, we'll have to cover those cases:

Prevent overwriting a certificate that as already started its proving process
Allow replacement of a certificate that is still in pending or InError
Keep processing only one cert at a time
Define a pre-check list that transient certificates should meet to be placed in pending

Prevent overwriting a certificate that as already started its proving process
The problem can appear if a chain resubmit a different certificate at the same height, while the previous one is already in the proving process:

What we explored was defining a new status for the certificate (we currently don't have a name for this status), this status would mean that the certificate as been fetched from the pending pool by the network task, and is in the proving process, thus it can be replaced.

Allow replacement of a certificate that is still in pending or InError
When a certificate is in Pending or InError, it can be replaced by the chain (for any reason).
This is mandatory to avoid having stuck chains.
Basically, if we take the status definition above, we can define this like that:

Define a pre-check list that transient certificates should meet to be placed in pending
In order to pre-check the transient certificates, we need to define what kind of things we need to verify. If the certificate passes the checks, it is place in pending. Any new certificate push as a replacement should be tested again as a new one.
The different checks could be:

Status of pre-existing certificate at same height
Signature checking or consensus hash checking
Shape and correctness of the certificates
Height expectation, it should be gapless and match the rate limiting
LER checking

TODO

[ ] Find a suitable name for the new status
[ ] Define if we need to re-check following certificates in case of one being replaced.
[ ] Explore if we need or should do more checks

Thanks for the writeup @Freyskeyd.
A couple of notes:

As for the name of the new status, these came to my mind: Scheduled, Ready, Started. None of them particularly descriptive so it would require further explanation.
The status diagram suggests a pre-check fail puts the certificate in the InError status. However, I don't think the certificate should be stored in this case. The pre-check also servers as a spam/DoS barrier.

For the record, here's my current idea of how the whole certificate processing pipeline looks like from the point of view of a single certificate, showing which components are responsible for various stages in certificate processing:

Only the happy path is shown above.
Crucially, the network task is able to process other events in spaces where it's shown as idle in the diagram. These include:

Receiving another certificate and performing prechecks on it.
Advancing the current epoch by listening to EpochEnded events.

Currently, the settlement task (notifier) updates the certificate status to Settled while all the other status changes are written by the network task. It would probably be cleaner for the network task to be responsible for all the status updates as hinted in the diagram. Any issues with this you can think of let me know.


patch abnormalities

The problem
while patching and sub classing there seems to be a deviation from the normal unittests behaviour.

scritp.py

def run_something():
    pass

test_script.py

import asynctest
import asyncio
import unittest
import script

class MainTest(asynctest.TestCase):
    def setUp(self):
        pass

    @asynctest.patch("script.run_something")
    async def test_main(self, mock_run):
        script.run_something()
        self.assertEqual(mock_run.call_count, 1)

class MainTest2(MainTest):
    def setUp(self):
        pass

if __name__=="__main__":
    unittest.main()

while running the code with python -m unittest iam gettting the following error
.F
======================================================================
FAIL: test_main (test_script.MainTest2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages/asynctest/case.py", line 297, in run
    self._run_test_method(testMethod)
  File "/home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages/asynctest/case.py", line 354, in _run_test_method
    self.loop.run_until_complete(result)
  File "/home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages/asynctest/case.py", line 224, in wrapper
    return method(*args, **kwargs)
  File "/usr/lib/python3.6/asyncio/base_events.py", line 473, in run_until_complete
    return future.result()
  File "/home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages/asynctest/_awaitable.py", line 21, in wrapper
    return await coroutine(*args, **kwargs)
  File "/home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages/asynctest/mock.py", line 1006, in __next__
    return self.gen.send(None)
  File "/home/jzy/work/asynctest_issue_virtual/scripts/test_script.py", line 13, in test_main
    self.assertEqual(mock_run.call_count, 1)
AssertionError: 2 != 1

----------------------------------------------------------------------
Ran 2 tests in 0.002s

FAILED (failures=1)

But the same code in unittest passes.

test_script.py

import asynctest
import asyncio
import unittest
import script

class MainTest(asynctest.TestCase):
    def setUp(self):
        pass

    @unittest.mock.patch("script.run_something")
    def test_main(self, mock_run):
        script.run_something()
        self.assertEqual(mock_run.call_count, 1)

class MainTest2(MainTest):
    def setUp(self):
        pass

if __name__=="__main__":
    unittest.main()

while running the code with python -m unittest iam gettting the following output
..
----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK

The workaround
Iam able to get around this issue by using the context managers instead of the decorators like
with asynctest.patch("script.run_something") as mock_something:

And the test succeeds
Support information

python version 3.6.7
asynctest version

Name: asynctest
Version: 0.12.4
Summary: Enhance the standard unittest package with features for testing asyncio libraries
Home-page: https://github.com/Martiusweb/asynctest/
Author: Martin Richard
Author-email<EMAIL_ADDRESS>License: Apache 2
Location: /home/jzy/work/asynctest_issue_virtual/lib/python3.6/site-packages

The question

Is this an intended behavior?

Hi,
Thanks for your report.
You're running the same decorated test method twice, and it re-uses the same mock object, which is indeed a bug since unittest issues a new mock object every time.
I'll work on it.

@Martiusweb Thanks for your prompt response.

In fact, this issue raises other problems happening with concurrent executions of patched coroutines.
In particular, since several coroutines instances can live simultaneously, several instances of a patched coroutine will break each other.
The issue is not about re-using the same mock, but using the same patch for each coroutine instance. I'm not sure yet how to solve this: should the patchings be tied to the coroutine instance instead of the coroutine function?
The internal behavior of asynctest will likely change quite a lot, so I think it should not be released in a patch version. I'll merge the deprecation of python 3.4 first.


Test / Error message gives away the solution

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

The test text in the Coding Challenge CSS Grid: Use grid-area Without Creating an Areas Template states the solution.

The proposed change uses a part of the text given in the challenge instructions instead of stating the explicit solution.

It seems the exact changes have already been made on earlier PR #24852 for this article you're editing, sorry about that. 😓 We are still reviewing this earlier PR, but will probably end up merging it soon.
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬

Thank you for the answer, I didn't see the PR. Unfortunately I was not able to find an option to check for open PRs regarding a certain piece of a repo.
May I ask you, how I could best double check next time for open PRs, so that I don't create redundancy?
All the best and have a wonderful weekend!
Leo

@Hahlh The best tool we have right now is still in its infancy, but you can search for filenames and view all the open PRs which make changes to the file(s).  It is located at https://contribute.freecodecamp.org/dashboard.
By entering use-grid-area-without-creating-an-areas-template.english.md into the Search field, you can see all PRs for that file.  Your changes were identical to the earlier PR.

@RandellDawson Thank you, I will build a habit of using that before I submit a PR.
It is surprising that GitHub itself doesn't offer a functionality for this.


Support interrupting long running tasks.

Fix for #141.
If a user hits Ctrl-C the user will have to wait until the step has
completed before the Ctrl-C is processed.  This change processes the
Ctrl-C within a 100ms, and immediately aborts all work.  There is no
cleanup done, and the task running in Azure is not killed.  The following
tasks are now interruptible.

capture image
delete resource group
deploy template
power off

All othere tasks run quickly enough that I did not make them
interruptible.
Small refactoring to the way errors are handled at the end of each step.

LGTM otherwise


References on foreign key just possible with Int64

It seems that using the references syntax for building a schema is just possible when using keys of type Int64 (see Source Code). Is that a limitation of SQLite itself?
What would be the best way to use this functionality when my keys are of type String?

You can use the dedicated foreignKey functions: https://github.com/stephencelis/SQLite.swift/blob/master/Source/Typed/Schema.swift#L378-L409

Closing this out as there are alternative ways of handling this. I'm open to discussion, though!

Thanks. The foreignKey function worked perfectly. :+1:


SequenceLib is slower than python-Levenshtien

I was adapting this code for our private use. I noticed that using
python-Levenshtein package is 100x better than SequenceMatcher ratio.
Levenshtein.ratio(A, B) gets you the same result.
I understand that this library is more for offline benchmarking use, but it doesn't hurt to be faster 😉 .
btw Can you explain the rationale for the custom cost function for substitutions? Any example on how using it changes outcomes of the path taken.

Aha nice.
I was actually originally using the Damerau-Levenshtein code bundled with ERRANT (rdlextra.py) to do the character alignment, but found SequenceMatcher to be a lot faster. If python-Levenshtein is faster still, then that might definitely be something worth upgrading.
As for the rationale behind the custom substitution cost, it's easiest to refer you to the alignment paper, particularly section 3.2 and Table 2.

Thanks for the reference. We noticed the speed improvements you had done that time (thanks).
BTW I have been cleaning up the code to make it easily usable as a library, making it pip installable with python 3 type annotations etc. If you plan to make this a library published to pypi, will give a pull request. Or I would consider publishing as a separate library.
One another side note, want to understand whether homophones can be added as another static rule for subsitutions, as they are among a easy class of errors people make ...
P.S. I think I we can consider moving the Damerau Levenshtein code to cython for speed improvements. But thats a separate task in itself. Realized how slow python is compared to cython in python-Levenshtein.

@chrisjbryant Check out this refactor, https://github.com/sai-prasanna/errant .. Its bit huge, but a basic cleanup and making it pip installable without altering the logic etc .. Yet to test the commands ..

Looks like you've been busy! Would be good to make it pip installable, but I've never done that before so have no experience with it.
It would be good to know whether it produces the same results and whether it's faster when you get a chance to test it. I guess it'll also need a new readme on how to use!

It is pip installable from the repository (not published to pypi, will do that soon). If you are convinced, we can upload to pypi.
Except for m2_to_m2 (which I am debugging now) all scripts are producing same results on spacy 1.9 , but I had set spacy to 2.0 (they use the same flags) but results have some diff in spacy 2.0.
Can you check the quality of results with spacy 2.0, using 1.x is not a option for me atleast right now, and it seems spacy 2.1 will be faster. But if you want 1.x we can try something like pip install errant[spacy1x] to support spacy 1.
The README is updated to include information about pip installation and how to run the cli.

Aha ok.
From memory, I think spacy 2.0 should technically be slightly more accurate than 1.9 (at least in terms of POS tagging and parsing) but I mainly didn't upgrade because it was slower.
Since spacy 2.1 is supposed to be faster, I was intending to revisit the code when that was released. They also finally fixed the coarse POS mapping in 2.1 apparently, so we'll be able to remove the manually defined tagmap and just use the native spacy token.pos_ property instead I think.
I would insist on keeping the 1.9 version for now as that's also the version we'll be using in the BEA2019 shared task. We can still update ERRANT in the future, but it'd be good to keep the 1.9 version available in case people want to evaluate using the official shared task evaluation procedure.

Closing this, as it has been addressed in my pull request.


doesn't respond to mouse clicks

Once I click into widget, the results come up, and I can't make their display go away unless I pick something.
Once I pick something, I can't make the list reappear unless I start deleting the characters of the picked item.

Hi,
Please share more information (Please attach screen record if possible)


[type:build] fix mergeable conditions

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4067 (5b08172) into master (c986aad) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4067      +/-   ##
============================================
- Coverage     70.01%   69.97%   -0.05%
- Complexity     6749     6758       +9
============================================
  Files           935      935
  Lines         25443    25465      +22
  Branches       2290     2290
============================================
+ Hits          17814    17819       +5
- Misses         6232     6248      +16
- Partials       1397     1398       +1

Impacted Files
Coverage Δ

...controller/ShenyuClientHttpRegistryController.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...gin/logging/kafka/collector/KafkaLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...n/logging/pulsar/collector/PulsarLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...in/aliyun/sls/collector/AliyunSlsLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...gging/rocketmq/collector/RocketMQLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...ncent/cls/collector/TencentClsSlsLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...g/clickhouse/collector/ClickHouseLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...ticsearch/collector/ElasticSearchLogCollector.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...ruptor/RegisterClientServerDisruptorPublisher.java
52.94% <0.00%> (-11.77%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
62.66% <0.00%> (-1.34%)
:arrow_down:

... and 33 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Make KHARMA driver use MeshBlockPacks throughout

See #55.  If you get some time & the tests have passed, maybe try this @vedantdhruv96
Several of the MeshDoThing implementations are still loops, we could be faster for small blocks bundling them together.  Also, the second sync could likely be faster for the case that packs are small (usually done on CPUs).
However, those changes carry further risks.  If this both passes all tests & recovers some speed for the KHARMA driver, let's just merge this into stable.

I can confirm that this PR does indeed provide a speedup for the kharma driver - both single meshblock and multiple meshblocks. For a single meshblock, I now see on average 22M ZCPS as compared to ~17M ZCPS earlier. The multi-meshblock case on the other hand experienced a 10x speedup - 10M ZCPS (4 meshblocks for a 288x128x128 torus problem) as compared to 1M ZCPS earlier.
I vote to merge this into stable!

Wild.  There should be some more easy gains to merge to dev soon, then, too.  Let me loosen the restart test and we can merge.


Remove redundant symphonia-mp3 feature

Objective

Fixes https://github.com/bevyengine/bevy/issues/7848.

Solution

remove the symphonia-mp3 feature and add a minimp3 feature instead.

bors r+

FYI @mockersf a nice test of your new CI for features!


recognition of Code Blocks

Hey,
as written on Twitter, thanks alot for that absolutely useful plugin.
I directly downloaded and tried it, there seems on my graph a bit strange behavior. Sometimes the Plugin only display the code copy icon after a manual refresh. If I open a block and go back the Icons are gone again. Also some Code blocks are not found at all.
I captured a small screen rec to better show it:
https://www.loom.com/share/86a8568970974d4abf7385b241488f9b

hi Marco, glad you find the plugin useful! thanks for the screen recording

If I open a block and go back the Icons are gone again.

this is a known issue - please see the README here for workarounds. this happens because the copy code icon is a child of the code block editor, so if you enter edit mode, the code block editor disappears and so does the icon

some Code blocks are not found at all.

i noticed in your screen recording that you had 2 code blocks in a block - the plugin doesn't currently support having multiple code blocks in one block

i'll work on figuring out solutions to these issues 🙂

Thanks,
if it is just 1 per Block it's fine. I can just tidy up my mess and write a new block per code :)
For the dissapearing copy button, understood; Would be great if there maybe a way to auto hook some kind of event to regullary refresh the icon if it is missing again.
Cheers.

both issues should be addressed in v.1.0.1 - please let me know if they have been fixed

i found that installing the plugin via the marketplace displays a cross-origin error. i've attempted to address the error in this pull request

please try re-installing the plugin via the marketplace - it should work normally now

Works great now. thanks !

happy to hear that!


Implemented ServicePrincipal login with certificate

Fixes https://github.com/Azure/ms-rest-azure-js/issues/37, https://github.com/Azure/azure-sdk-for-node/issues/3101

Sorry for all the comments not related to your changes. Should we think about writing some tests about it?


Adding decoded events

Hi, I've been trying to get in touch with @jhuhnke and @desmond-hui through Discord, but doesn't look like the devs come around much. I'd like to contribute instruction decoding libs for our programs, which are not currently published to the Anchor registry.
I see you're consuming some custom sources to classify event types, but that's about as far as I've figured it out.

Hi @dahifi - I apologize for the delay in getting back to you on this.  We would be happy to take a look at incorporating the libs if you are still interested.  We can continue this convo via discord dms.  What is your discord username?

HI!
Blockchain Man#8744
I submitted https://github.com/FlipsideCrypto/sql_models/pull/637 yesterday and just saw this message. If we can get that through first we can talk about our IDLs.


cannot load model

Hi, I receive an error if I load the code manually this way:
args = argparse.Namespace()

# Manually set the arguments
args.min_depth = 1e-3
args.max_depth = 128
args.flip_test = True
args.ckpt_dir = "./checkpoints/kitti.ckpt"
args.vit_model = "google/vit-base-patch16-224"
args.max_depth_eval = 128
args.no_of_classes = 200
args.deconv_kernels = [2, 2, 2]
args.num_filters = [32, 32, 32]
args.num_deconv = 3

DEVICE = torch.device('cuda' if torch.cuda.is_available() else 'cpu')

model = EcoDepth(args=args)
model_weight = torch.load(args.ckpt_dir)['model']
model.load_state_dict(model_weight)
model.to(DEVICE)
model.eval()

when executing this code I receive
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
making attention of type 'vanilla' with 512 in_channels
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
making attention of type 'vanilla' with 512 in_channels

Loading openai/clip-vit-large-patch14 to CLIPTextModel.....

Some weights of the model checkpoint at openai/clip-vit-large-patch14 were not used when initializing CLIPTextModel: ...

- This IS expected if you are initializing CLIPTextModel from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing CLIPTextModel from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).

Loaded openai/clip-vit-large-patch14 to CLIPTextModel.....

ddpm.py: Restored from ../checkpoints/v1-5-pruned-emaonly.ckpt with 0 missing and 2 unexpected keys
Unexpected Keys: ['model_ema.decay', 'model_ema.num_updates']

RuntimeError                              Traceback (most recent call last)
Cell In[27], [line 19](vscode-notebook-cell:?execution_count=27&line=19)
     [17](vscode-notebook-cell:?execution_count=27&line=17) model = EcoDepth(args=args)
     [18](vscode-notebook-cell:?execution_count=27&line=18) model_weight = torch.load(args.ckpt_dir)['model']
---> [19](vscode-notebook-cell:?execution_count=27&line=19) model.load_state_dict(model_weight)
     [20](vscode-notebook-cell:?execution_count=27&line=20) model.to(DEVICE)
     [21](vscode-notebook-cell:?execution_count=27&line=21) model.eval()

File /anaconda/envs/ecodepth/lib/python3.11/site-packages/torch/nn/modules/module.py:2041, in Module.load_state_dict(self, state_dict, strict)

RuntimeError: Error(s) in loading state_dict for EcoDepth:
	size mismatch for encoder.cide_module.embeddings: copying a param with shape torch.Size([100, 768]) from checkpoint, the shape in current model is torch.Size([200, 768]).
	size mismatch for encoder.cide_module.fc.2.weight: copying a param with shape torch.Size([100, 400]) from checkpoint, the shape in current model is torch.Size([200, 400]).
	size mismatch for encoder.cide_module.fc.2.bias: copying a param with shape torch.Size([100]) from checkpoint, the shape in current model is torch.Size([200]).

Have you solved it? I met the same problem.

Hi @BaderTim and @Smarome, you are facing this error since the no_of_classes for nyu.ckpt and kitti.ckpt is 100 and not 200 (for vkitti.ckpt it is 200). If you change the no_of_classes to 100, it should work. Let me know if any other issues arise.


Use angular.extend to update position in scope.

This prevents dereferencing the original position object, which is undesirable
if there are other properties than top, left, width and height on the
position object.
For example if the position object is defined as follows:
$scope.position = {
  top: 0,
  left: 0,
  width: 1,
  height: 1,
  name: "my first widget"
}

Updating the widget would replace the original object, thus losing the name
property. Using angular.extend solves this by just copying all enumerable
properties from the object obtained through Widget.prototype.getPosition to
the original position object and leaves all other properties untouched.

Good point, I'll add another line to preserve support for automated positioning (passing null/no position). Thanks for contributing!

Thanks! Awesome library by the way!


Update client-disconnected.md

Why does the client connect to the Skype for Business API when it first loads?

@jasongre FYI


Integrating C# in clientLib

I have developed a C# version of our clientLib, mainly designed for seamless integration with games of C# and combined with UpGrade.
@mswartzCL  should I create a PR for this and merge it?

Awesome! Yes, go ahead


SQL errors occur sometimes during tests in CI build

Example: https://github.com/GermanZero-de/klimaschutzmonitor/actions/runs/6950366475/job/18910360412
Reason is not clear. Only appears sometimes, other rebuilds of the same code work sometimes.
There seems to be an error when trying to delete a session:
E           KeyError: ('SELECT "auth_user"."id", "auth_user"."password", "auth_user"."last_login", "auth_user"."is_superuser", "auth_user"."username", "auth_user"."first_name", "auth_user"."last_name", "auth_user"."email", "auth_user"."is_staff", "auth_user"."is_active", "auth_user"."date_joined" FROM "auth_user" WHERE "auth_user"."id" = ? LIMIT 21',)
../../../.cache/pypoetry/virtualenvs/cpmonitor-Ujpn4bh--py3.10/lib/python3.10/site-packages/django/db/backends/sqlite3/base.py:324: KeyError

Looks like this has been resolved without us specifically fixing it.


long_description = README.rst + CHANGELOG.txt

Converts README from Markdown to RST, which is better supported by Python tools and PyPI.
Removes the short long_description in setup.py and gets it from README.rst

End result is that the package should have a much more comprehensive description on PyPI at https://pypi.python.org/pypi/teamcity-messages

Interesting idea. Please fix flake8 warning on travis and I'll merge it.

flake8 warnings fixed.


enhance(docs): comparison to real footnotes

Documentation
https://www.markdownguide.org/extended-syntax/#footnotes

Alright, got it working. Patched the package to get rid of id:subId syntax when the footnote is used multiple times ([3.1] → [3]). Also converted from using numbers to using letters because the footnote plugin changes them so the first one seen is 1. That was confusing me, so I switched to letters for the references instead.


Provide a toJson method on receipt and record which is consistent across all SDKs

Problem
Using different SDKs with WalletConnect, it's impossible to provide a consistent JSON representation of a Receipt or Record.
.stringify and .marshal in javascript and golang output differing results.
Solution
Add a toJson method to receipt and record which convert the object to a consistent JSON format (using the JS stringify as a reference) so that all SDKs can generate identical Json.
Alternatives
Let developers write their own equivalence libraries which is likely to go wrong with changes to receipts/records.

Hi @gregscullard and thank you for submitting this issue. I will check it.

Also for TransactionResponse


Is this an AI generated library?

the share number of plugins for basics every editor would need and the long function with very little factorization with in-lining of most prop interfaces. obvious refactoring checkpoints are rare

After looking into it, there seam to be a lot of similarities with AI generated code.

I don't think the code is AI-generated, and the core of Lexical predates all of the more recent LLM-based AI coding models.

plugins for basics every editor would need

I'm not very familiar with the Lexical codebase, but this isn't uncommon in the JS ecosystem - it's why most sites have a large number of npm modules installed.
Implementing most functionality as plugins ensures:

Sufficient extensibility points are available to implement everything. The plugin system is a core feature in the system rather than just a side feature that only third-party things use.
Any functionality can be swapped out with a custom implementation.
"basics every editor would need" really depends on the use case. For example, the comment boxes on Facebook use Lexical even though the only custom formatting are tokens when you mention a person/Page/group, so they don't need any of the code that handles rich text formatting.

The first two reasons are why some other libraries take the same approach, for example the Markdig C# Markdown parser implement every AST node and AST to HTML formatter using a plugin architecture.

No, it's not an AI generated library.

Maybe not fully generated but heavily guided/assisted/aided


A suspicious use of const AtomicBool

Hello,
I noticed you're applying store and load to a constant, and I think you actually want a static item because const  atomics are not global mutable states. However, I'm not familiar with the code base so I might get it wrong.
https://github.com/TimUntersberger/nog/blob/c587c016e7f1225f8422f06d5fd596ba4cd38f21/src/update.rs#L7
By the way, what an interesting project and the great amount of work! I had no idea one can make a window manager for WIndows 10.

The code is still WIP (As you can see with the todo!). It got pushed accidentally, but nice catch with the const!

By the way, what an interesting project and the great amount of work! I had no idea one can make a window manager for WIndows 10.

Thank you!


Configuration system

Build basic configuration system on top of nlohmann JSON library (https://github.com/nlohmann/json.git).

Added nlohmann JSON library (https://github.com/nlohmann/json.git) as submodule.


Fixed relationship time parsing

Lately crunchbase started to return cratead and updated at times not strictly as timestamps but also as date time strings such as 2015-06-30T22:14:29-07:00. This PR fixes this issue.
Example of such a bad format is searching organizations by query "you":
https://api.crunchbase.com/v/2/organizations?query=you&page=1&order=created_at+asc&user_key={your_key}

Thanks, I have already work On Crunchbase Version 3 (crunchbase-ruby-library).


Feature Request: Include support for method calls

I find myself needing this when referencing a Date object. I'd love to be able to get the result of ToShortDateString(). In order to use this for my intended purpose, I need to create a whole new custom object to represent all my values in the template, as opposed to using the objects I already have available.
Thoughts?

Placeholders accept format flags, the same as String.Format. I think
ToShortDateString() is the same as the "d" standard format, eg,
ToString("d") or {key:d} in mustache #.
On Aug 23, 2016 9:03 PM, "Ryan Griffith"<EMAIL_ADDRESS>wrote:

I find myself needing this when referencing a Date object. I'd love to be
able to get the result of ToShortDateString(). In order to use this for my
intended purpose, I need to create a whole new custom object to represent
all my values in the template, as opposed to using the objects I already
have available.
Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jehugaleahsa/mustache-sharp/issues/67, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABTgPiOrufdEsC6G0VbluskN_KJhZLc0ks5qi5hMgaJpZM4Jriit
.

I overlooked this. Perfect, thank you!


[Teradata] Generate SQL Function does not work

Hello, I'm using Dbeaver over Datawarehouse my company .... I realized that the "Generate SQL" function in the contextual menu, does not work ... When I position the mouse pointer on the function, it has turned gray (deactivated).
Thanks.... and good work!

Generate SQL is not available if DBeaver can't detect source table. E.g. in case of custom SQL queries with joins.
If you think it should resolve source table - post debug log (https://github.com/serge-rider/dbeaver/wiki/Log-files)

I think that it should resolve table (the problem happens also in queries that references a single table..)
Here's the log and a bitmap that shows (better of me!) the issue.
Thanks and good work!!

dbeaver-debug.zip

Hi serge, I'll try to post a new log... maybe it's more useful than older.
Thanks!!
Issue#429.zip

What Teradata JDBC driver (exact version) do you use?

Hi Serge,
here the driver version:
Teradata JDBC Driver <IP_ADDRESS>
Thanks

But I alredy tried to change driver version (older or newest), but the issue was still present.

Ticked has no apdates more than a year. Ticket closed.
If issue is still actual for you - feel free to reopen the ticket or create a new one.


fix: shutdown logger after container process exits

Addresses #2313
Container task is not deleted after it exits, leaving the runtime shim and logger open throughout the lifecycle of a container. This can be a problem when there is unprocessed stdout data after a container task finishes and the logger is blocked forever waiting for a newline or EOF.
This PR fixes the issue by piping container output instead of reading directly from stdout and stderr file descriptors. Closing the io pipes upon task exit allows the logger to shutdown gracefully and process leftover data without a newline .

Hi @mharwani, as mentioned here  closing task io.Close() after task exist should close stdio and then logger will receive a EOF

Hi @mharwani, as mentioned here closing task io io.Close() after task exiting should close FIFOs => send EOF to stdio => logger will receive EOF

Hi @fahedouch, I tried closing the task IO upon container exit with task.IO().Close(), but it did not fix the issue. The scanner did not receive EOF. I posted my thoughts here:

From what I understand, when a task is running in detached mode it uses logURI as the task IO, which doesn't have any FIFOs open and does nothing on close.

It looks like the environment setup is failing for some of the checks because curl cannot reach the endpoint https://raw.githubusercontent.com/AkihiroSuda/containerized-systemd/v0.1.1/docker-entrypoint.sh:
SSL: no alternative certificate subject name matches target host name 'raw.githubusercontent.com'
Any ideas?

CI is now green for Linux.
Please try rebasing to make Windows CI green

Windows tests are failing
=== NAME  TestLogs
    container_logs_test.go:42: assertion failed:
        Command:  C:\Windows\system32\config\systemprofile\go\bin\nerdctl.exe --namespace=nerdctl-test logs --since 10s nerdctl-testlogs
        ExitCode: 0
        Stdout:
        Stderr:
        Failures:
        Expected stdout to contain "foo\nbar"
=== CONT  TestLogsWithoutNewlineOrEOF
--- FAIL: TestLogs (4.60s)
=== NAME  TestLogsAfterRestartingContainer

https://cirrus-ci.com/task/4610614887186432?logs=build#L843

@mharwani  PTAL

ping @mharwani

Hey @mharwani
Would you still be interested in carrying this PR through?
If so, could you rebase (a lot has changed) and see about @fahedouch comments?


Notebooks setup left panel

Left-hand panel in UI has changed "Notebook Servers" to "Notebooks"

This change is

/close


Dates include full HH:MM:SS time

The dates look very specific, I think we just need the DD-MM-YYYY piece.

Is your feature request related to a problem? Please describe.
Dates currently display with accuracy down to the millisecond. This is unnecessary information and clutters the UI.
Describe the solution you'd like
Dates should be simplified to DD-MM-YYYY. Additional information, such as the time of the event, could be obtained by opening it.
Describe alternatives you've considered
We could also include the time on the date line or remove the dates altogether, but I think that having only the day, month, and year strikes the best balance of these options.
Additional context
See the screenshot above.

Fixed by #42


introduce tamejs-style asynchronous constructs to avoid callback pyramids

update: Looks like tamejs has changed their syntax a little since July: twait is now called await and mkevent is now called defer. Luckily, they don't appear to have changed any of the semantics, though I haven't looked that hard. Take that into account when checking out tamejs.

(originally from a comment in #1704)

A few months ago, I was checking out tamejs, liked the ideas, and started thinking about how it could be incorporated into coffeescript. For the uninitiated: tamejs basically just takes the JS you write and compiles it to use continuation-passing style. So the output's not so pretty. Anyway, I took a few of the examples from the website, pasted them into a gist, and rewrote them in what I called "imaginary-coffeescript-with-defer". I'll include one gist inline and just link to the other.
Imaginary CoffeeScript
{resolve} = require "dns"

do_one = (host, cb) ->
  (err, ip) <- resolve host, "A", *
  console.log if err then "ERROR! #{err}" else "#{host} -> #{ip}"
  cb() if typeof cb is 'function'

do_all = (hosts) ->
  defer
    for host, i in hosts
      do_one host, null
  return

do_all process.argv[2..]

Original tamejs Example
var dns = require("dns");

function do_one (ev, host) {
  var err, ip;
  twait { dns.resolve (host, "A", mkevent (err, ip));}
  if (err) { console.log ("ERROR! " + err); }
  else { console.log (host + " -> " + ip); }
  ev();
}

function do_all (lst) {
  twait {
    for (var i = 0; i < lst.length; i++) {
      do_one (mkevent (), lst[i]);
    }
  }
}

do_all (process.argv.slice (2));

There's a pretty simple mapping from the added coffeescript constructs to the tamejs additions.

defer block is just one big twait
(arg0, arg1, ..., argN) <- expression:

compile to a twait unless inside a defer
save args for compilation of any bare * (or whatever syntax we pick) inside expression

bare * (or whatever syntax we pick) compiles to mkevent using args from containing <-

Now I'm not sure how appropriate it would be to add to CS because of the possibly irreparably ugly compilation. But I think it's worth a discussion even considering the numerous, extremely lengthy tickets on defer-style constructs. Hell, I think people would sacrifice the readable output for a powerful feature like that. And they would only need to do so when using that feature.
I think it makes a really good use of both <- and defer. That syntax just really seems to fit their proposed functionality.
Pinging list of tamejs contributors: @maxtaco, @malgorithms, @m8apps, @frew

Hasn't this all been done before in #350 ?

Awesome. Looking forward to it. How did @jashkenas feel about the ugliness of the CPS compilation? I believe that was the main argument holding this feature back.

Turn out @maxtaco works right around the corner ... we talked about the ugliness of the CPS transformation, but that wasn't the only thing holding back previous versions of defer ...

It needs to compile into the minimal transformation required to handle the particular defer/await.

It needs to handle defer within a loop, and break/return/continue.

Code that does not use defer should not be affected.

It needs to have syntax for both the sequential and parallel versions of multiple defers.

The implementation can't be so extreme as to balloon the compiler's size, or to make it hard to work on.

... @maxtaco has already solved most of these. The defer/await split allows you to get either sequential or parallel behavior; he has a pretty clean addition to the AST (although it can still use a bit more cleaning up); special values for deferring in loops are only emitted when you actually defer in a loop; and so on.
I think that there's more ground to be covered to boil down the generated code to the minimum amount that we can lexically determine is necessary for the particular "defer" use -- but hopefully y'all (and maybe @gfxmonk as well) can help with that.

/subscribing to this thread

Update: I moved over from master to the "tame" branch in my repo in preparation for the pull request.  I added a fair amount of documentation to TAME.md.  Before I submit, though, I thought we'd get some more experience using it in practice.  We've already found a few a bugs, and maybe a few more will show up.  More to come.

Is that a call to action?  You want us to start testing this?

No, sorry for the confusion, we're testing it in-house!
On Tue, Dec 13, 2011 at 3:00 PM, Jason King <
<EMAIL_ADDRESS>
wrote:

Is that a call to action?  You want us to start testing this?

Reply to this email directly or view it on GitHub:
https://github.com/jashkenas/coffee-script/issues/1710#issuecomment-3128670

Another tweet-sized update, we're dogfooding and finding about a bug a day.  The reg test suite is growing nicely.  The recent bugs have had to do with scoping or autocb.

Closing in favor of #3757.


Missing style class names after being built in NextJS

Environment

npx envinfo --system --binaries --npmPackages styled-components,babel-plugin-styled-components --markdown --clipboard
System:

OS: Linux 5.8 Ubuntu 20.10 (Groovy Gorilla)
CPU: (2) x64 Intel(R) Pentium(R) CPU G630 @ 2.70GHz
Memory: 207.72 MB / 3.74 GB
Container: Yes
Shell: 5.0.17 - /bin/bash

Binaries:

Node: 15.11.0 - ~/.nvm/versions/node/v15.11.0/bin/node
Yarn: 1.22.10 - ~/.nvm/versions/node/v15.11.0/bin/yarn
npm: 7.6.0 - ~/.nvm/versions/node/v15.11.0/bin/npm

npmPackages:

styled-components: ^5.2.1 => 5.2.1

Reproduction
Steps to reproduce

Create a simple App using NextJS
I think this step is what's causing the problem. Create a component that looks like this:

import sc from 'styled-components'

export function Elem(width, content) {
 const elem = sc.div`margin-right:4vw;width:${width};padding:5vw` // a variable is used inside the styling?
 return <elem>Hello world</elem>
}

In pdt/index.js:
import { Elem } from '..path'

export default function Home() {
 return (<div>
  <Elem width="5vw"/>
  <Elem width="15vw"/>
</div>)
}

Run next dev and in another terminal tab next build && next export and serve the out directory in a port
Open the two different ports and compare them
Expected Behavior
Dev and Production (Build) Version should look the same.
Actual Behavior
From some bit of looking around in the browser, styled-components generates a Id for the class as usual but there is no mention of that id in any of the css produced. Hence the class has no styling and the dev and build versions look different

I have tried the website again after losing the variables in the style and it still doesn't generate a style for the class id it generated.

There's no reproduction here for me to look at, however, I'm seeing that you're creating a StyledComponent dynamically inside another component, which is disallowed. You may even get a warning about that (check the console)
Please try StackOverflow for usage questions if you have a bit more code and details to provide. It'd be much faster to get an answer there ❤ Here, you've basically submitted a bug template issue for something that's a usage issue on your end


Correction for raw affiliation UMR MoISA (Montpellier Interdisciplinary centre on Sustainable Agri-food systems), (Univ Montpellier, CIRAD, CIHEAM-IAMM, INRAE, Institut Agro, IRD), Montpellier, France.

Correction needed for raw affiliation UMR MoISA (Montpellier Interdisciplinary centre on Sustainable Agri-food systems), (Univ Montpellier, CIRAD, CIHEAM-IAMM, INRAE, Institut Agro, IRD), Montpellier, France.
raw_affiliation_name: UMR MoISA (Montpellier Interdisciplinary centre on Sustainable Agri-food systems), (Univ Montpellier, CIRAD, CIHEAM-IAMM, INRAE, Institut Agro, IRD), Montpellier, France.
new_rors: 0005r2j17;05kpkpg04;04abkkz03;011xg1225
previous_rors: 0005r2j17;05kpkpg04;04abkkz03
works_examples: W4403305354
contact: fdd1991d9f9c86d8309ecf5235d3b64e:2df8a9719a50fbb693ed6226126d1bde9880 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Shrink the size of sine table

In the file src/trig.c, there is a lookup table for the sine function pre-calculated with fixed-point arithmetic. According to the size command provided by binutils, the lookup table and its related functions (sin, cos, tan) contribute more than 2 KiB to the code size on Aarch64.
$ size .libtwin.a/src/trig.c.o
   text	   data	    bss	    dec	    hex	filename
   2460	      0	      0	   2460	    99c	.libtwin.a/src/trig.c.o

Instead of relying on table lookups, we can perform calculations on the fly and ensure a reasonably fast response time by utilizing a smaller table or a combination of bit operations. Additionally, instead of invoking twin_sin and twin_cos functions, we can use the sincos function to retrieve sine and cosine values simultaneously, reducing the number of function calls.
Reference: 2024 Report

libfixmath implements Q16.16 format fixed point operations in C.
When FIXMATH_FAST_SIN is enabled, its fast implementation for sin operates at 159% the speed of its most accurate version, with a slightly lower accuracy of approximately 2.3%. See fix16_trig.c

The q is a small fixed point number library, and its format is a signed Q16.16. The trigonometric functions, and some others, are implemented internally with CORDIC.


Disallow unknown keys with .strict()

https://zod.dev/?id=strict
If schema(s) are made with strict, it will disallow extra keys in the markdown frontmatter.

Lgtm!
I just merged your PR. Thanks


Update config.ts

Fix the "Edit this page" links on the docs to point to the correct repo.

Thank you @bronze for contributing!

I think the new docs need to be deployed, I'm still seeing this bug, and was about to submit a PR to fix it as well.  :)

But I am seeing the link has been corrected and is working now. Do you see the change if you hard-reload the page @IanVS?

Looks good now, thanks!


[🐛 Bug]: Widget border colors

VSCode Environment
Version: 1.67.2
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:20:57.384Z (1 wk ago)
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.5.0
Marquee Version
v3.1.1653582143
Workspace Type
Local Workspace
What happened?

The widget title divider / border can look more VS Codeish, see the difference between the stateful borders and marquee.
Stateful uses:
border: "var(--vscode-editorGroup-border)"
What is your expected behavior?
No response
Relevant Log Output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Is there an existing issue for this?

[X] I have searched the existing issues

Updated border colors:


add_windows_version_8_1

Hey Gabriel,
I found there are some usage to detect windows version 8.1, which is mapped to 6.3 in the user-agent. Is it ok to add this into OsDetector? Thanks.
Best,
Martin

Yes, you are more than welcome to make a pull request :+1:


open more ipfs.files.add node-only tests to the browser

Several ipfs.files.add tests haven't been tested yet on the browser. Let's change that:

[ ] buffer as tuple
[ ] BIG buffer
[ ] add a nested dir as array
[ ] rely on browserify brfs for file loading in the browser (rather than raw!)

This is done :)


feat: add support for fetching subset of dataset by type

First of all: Sorry for the linting commit!
This PR adds support for allowTypes: [// list of document types] as one strategy to limit which documents to sync to the groq-store. Of course, this has some foot guns since it's easy enough to forget when you're joining references and so on. I didn't get the test to run properly because I wasn't sure how to configure the local dev environment. Hope it isn't too far off the mark!

Interesting. How does groq-js behave when trying to resolve references that does not exist? Does it throw?

I believe it will return null or nothing

I believe it will return null or nothing. Groq.dev doesn't run the newest version of groq-js, but believe it actually should be null?

Correct! It should just return null.

From a developer experience standpoint, I'd love to see warnings when failing to resolve strong references.

Attempted to resolve reference to document , but the document was not found. The document type might not be listed in the allowTypes array.

@judofyr How hard would it be to either make the reference resolving configurable, somehow, or emit an event of some sort?

I'll circle back to this when we have an answer on the reference resolving :)

@kmelve @rexxars should we resurrect this one? 😄

@kmelve I've rebased the PR, squashed commits, updated the PR to work with the latest code on main, and triggered a prerelease that'll let us test this on npm i @sanity/groq-store@add-type-allowlist :)
@judofyr could you check up on @rexxars's question? :relaxed:

@judofyr How hard would it be to either make the reference resolving configurable, somehow, or emit an event of some sort?

It wouldn't be very hard. The dereference logic is implemented in https://github.com/sanity-io/groq-js/blob/707307ba16eee6638f3b1e41d7450a1b89b297e5/src/evaluator/evaluate.ts#L242-L265 and it has access to the context object. We'd probably have to introduce a new method on the evaluate function (i.e. async resolveReference(id)).


New package: TFIDF v0.1.0

Registering package: TFIDF
Repository: https://github.com/LiorSinai/TFIDF.jl
Created by: @LiorSinai
Version: v0.1.0
Commit: 1da84d874dfa0868c466c0418ecd8e13da2b8a4e
Reviewed by: @LiorSinai
Reference: https://github.com/LiorSinai/TFIDF.jl/issues/1#issuecomment-1666541593
Description: A Julia implementation of Term Frequency - Inverse Document Frequency (TF-IDF) method

How about TermFrequencyIDF?

That was a quick reply :) This technique is usually called TFIDF so I would prefer to keep that name. But If I must stick to the guidelines, then I will use TermFrequencyInverseDocumentFrequency.jl

There’s a pretty strong bias against these types of acronyms as package names. In any case, I don’t have merge permissions, so you’d have to go on Slack in three days to find a maintainer to merge it manually. It seems like there’s a temporary absence of maintainers at the moment (due to JuliaCon), so it might take a while. Renaming to TermFrequencyInverseDocumentFrequency.jl might just be the easiest way to go. It’s long, of course, but that’s not really a problem.

Ok, thanks for the advice. I will rename it.

New PR: https://github.com/JuliaRegistries/General/pull/89100


Hide title in sway/window when window title is shown by Sway

While immensely useful, sway/window module can become a visual distraction when title is displayed by Sway and Waybar simultaneously. Consider two examples.

Sway is in stacking mode, title is shown in Waybar only:

Sway is in tabbed mode, title is shown by both applications:

Latter is confusing as information is clearly redundant. Would it be possible to add a check before displaying a title? Something like this:
# Pseudocode
if sway.window.mode() == "tabbed" and sway.window.focused():
    waybar.module['sway/window'].format = ""
else
    waybar.module['sway/window'].format = "{}"

Hi,
With the following config in Sway, you'll avoid to show window title when there is only one windows opened:
default_border none
hide_edge_borders --i3 smart
smart_borders smart

The problem will still be present when more than one window is opened in tabbed mode.

Hi,
With the following config in Sway, you'll avoid to show window title when there is only one windows opened:
default_border none
hide_edge_borders --i3 smart
smart_borders smart

The problem will still be present when more than one window is opened in tabbed mode.

@max-k ,
Thank you for the suggestion, I've already had something similar, albeit without the --i3 flag which is now added :)
Could you explain smart_borders smart? Looking at man 5 sway it can be either "on", "no_gaps" or "off".
@Alexays,
Would you consider adding something like rysolv.com / bugbounty / etc. to Waybar repo?

@max-k ,
Thank you for the suggestion, I've already had something similar, albeit without the --i3 flag which is now added :)
Could you explain smart_borders smart? Looking at man 5 sway it can be either "on", "no_gaps" or "off".
@Alexays,
Would you consider adding something like rysolv.com / bugbounty / etc. to Waybar repo?

@savchenko You're right. I read this in the chapter dedicated to hide_edge_borders parameter.
hide_edge_borders [--i3] none|vertical|horizontal|both|smart|smart_no_gaps

    Hides window borders adjacent to the screen edges. Default is none. The --i3 option enables i3-compatible behavior to hide the title bar on tabbed and stacked containers with one child. The smart|smart_no_gaps options are equivalent to setting smart_borders smart|no_gaps and hide_edge_borders none.

But there is probably a typo here.

@savchenko You're right. I read this in the chapter dedicated to hide_edge_borders parameter.
hide_edge_borders [--i3] none|vertical|horizontal|both|smart|smart_no_gaps

    Hides window borders adjacent to the screen edges. Default is none. The --i3 option enables i3-compatible behavior to hide the title bar on tabbed and stacked containers with one child. The smart|smart_no_gaps options are equivalent to setting smart_borders smart|no_gaps and hide_edge_borders none.

But there is probably a typo here.

@savchenko I double-checked and this combination of parameters is sufficient.
default_border none
hide_edge_borders --i3 smart

No need to use smart_borders at all.

@savchenko I double-checked and this combination of parameters is sufficient.
default_border none
hide_edge_borders --i3 smart

No need to use smart_borders at all.

@max-k ,
Well, hiding the border is a bit brute-force. Here is what works with Sway v1.5:
default_border pixel 2
default_floating_border pixel 2
hide_edge_borders --i3 smart
smart_borders on
smart_gaps on
titlebar_border_thickness 0

@max-k ,
Well, hiding the border is a bit brute-force. Here is what works with Sway v1.5:
default_border pixel 2
default_floating_border pixel 2
hide_edge_borders --i3 smart
smart_borders on
smart_gaps on
titlebar_border_thickness 0


docs: restructured local engine (hostpath, lvm, and zfs)

Hello @avishnu, please review the suggested changes and share your feedback if any, or approve the PR.
If all looks good, please merge the PR by EOB. Thanks!
@balaharish7 @Abhinandan-Purkait

@Abhinandan-Purkait @niladrih this PR has package-lock.json and yarn.lock changes. Though they might have ended up here un-intentionally, wondering if we should consider taking in the changes as they seem to be updating lots of packages IIANW

On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.

You mean both package-lock.json and yarn.lock?

On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.

No we aren't suppose to take that in. It got created because they ran the server locally,


Generating Password

Is there a reason why we can disable some Charakters in the generated Password?

Do you mean this thing in the settings?
This is because some users may not want some characters. So it's up to them what the password generator uses.

Yea I meant this

haha, I don't know whether this works, but on this site it says leaked

It is defintly way faster now like half a second
I checked the Password and It did not show red on the Chart so I am not sure if this works right at all or not

Code seems good, so should work, we will see


Not compatible with webpack bundled main process js

We use webpack to bundle main process js files, the target is set to electron-main.
The aplication throws after start:
TypeError: mod.require is not a function
    at Object.dynamicRequire (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:12699:16)
    at Object.specificInit (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:11068:41)
    at Object.init (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:11417:16)
    at Object.<anonymous> (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:186522:8)
    at Object../src/main-process/init/setupSentry.js (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:186525:30)
    at __webpack_require__ (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:20:30)
    at Object../src/main-process/init/index.js (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:186451:1)
    at __webpack_require__ (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:20:30)
    at Object.<anonymous> (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:187934:1)
    at Object../src/main.js (/home/haiyang/Coding/dichat-phoenix/packages/client/bundle/main/index.js:188160:30)

Can you try this:
https://github.com/getsentry/sentry-electron/issues/92#issuecomment-453534680

Okay, problem solved, thanks!