Theme for Insomnia REST Client

First of all thank you so much for this great project, I try to use nord theme with whichever tool I work with. (VSCode, Notepad++, Hyper.sh, ConEMU)
One missing link in my setup is a theme for Insomnia, which is a brilliant open source rest client.
https://github.com/getinsomnia/insomnia
https://insomnia.rest/
Themes for insomnia used to be premium only, but ever since the developer reached a certain target of monthly recurring revenue, custom themes were made free for all.
I think a nord themed insomnia would be a great addition.

Thanks for your proposal 👍
Sorry for the delay, I've had no free time (job :man_health_worker:, study :book:, life :weight_lifting_man: etc.) to work on my or any other :octocat: OSS project (see Tweets :bird: from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again :green_heart:
I've added it to the backlog and @-mention you as soon as I start working on it so you can track the progress or contribute ideas for this port project.
Please note that it may take some time because there are many other issues over many other port projects with requests and proposals waiting in the queue. I'm currently also very busy on working and prototyping on the nord-docs to finally have a „single source of truth“ for Nord and all related data. Please also take into account that I work as a software developer in the "real world" and I hope you understand that the time to work on my projects may vary depending on my freetime. :octocat:

I think at the very first we need merge the Nord colors into some derivative of this file:
https://github.com/getinsomnia/insomnia/blob/develop/plugins/insomnia-plugin-core-themes/themes/default.js
then glue it together with some descriptors, assemble it somehow and we're done - in theory. I do not feel too comfortable with the first step. In the meanwhile I will try to see whether I can find out something about the assembly of Insomnia plugins.

Reference https://github.com/getinsomnia/insomnia/pull/1047

@xasx Last time I checked Insomnia's documentation and blog color themes were only available with a paid subscription (only 4 base one for free), but this blog post about providing themes for free as of version 6.0 might be good news to implement a Nord theme. Since the app is completely modularized it might be possible to create a custom plugin (like the one you've linked), but I'm currently not sure if this also works fine for themes.

My plan was to clone the insomnia-plugin-core-themes plugin and leave only one theme inside and somehow deploy it into Insomnia. If this works, the remaining theme can be Nord-ed.
Any thoughts?

Find a very rough first version here: https://github.com/xasx/insomnia-plugin-nord-theme
Feel free to file issues, PRs, clone it or whatever.
Probably I need to add a license, do I?
Install instructions for the time being:

clone to insomnia plugins folder
refresh plugins
select Nord theme

Thank You!! 🎉
Minor Feedback, I'd go with a darker color in the top left where it says Insomnia

@subodhpareek18 Your feedback is very much appreciated, just add it to xasx/insomnia-plugin-nord-theme#2
From there I can track the changes to the theme and we keep this issue for just having it at all.

@xasx Great, hanks for your help 👍 , contributions like this are always nice to get things done faster.
Glad to see it gets loaded out-of-the-box™ without the need to do any “hacks“. I'll let you know as soon as I've got time to create the repository (currently totally busy working on Nord Docs) to form this to an official port project.

Thanks @xasx for porting this!


📚 -  Failed to execute 'setEnd' on 'Range': There is no child at offset 33.

What is the affected URL?
https://taiga-ui.dev/directives/dropdown-selection
Description

Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

This probably just needs an additional check + early return at some point.


[ISSUE #6474]Optimize ServiceThread log print

Make sure set the target branch to develop
What is the purpose of the change

fix #6474
Brief changelog

Optimize ServiceThread log print

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6475 (d10f4b5) into develop (8aa7bc0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6475      +/-   ##
=============================================
+ Coverage      43.17%   43.21%   +0.03%
+ Complexity      9010     9007       -3
=============================================
  Files           1106     1106
  Lines          78204    78205       +1
  Branches       10195    10195
=============================================
+ Hits           33766    33793      +27
+ Misses         40197    40172      -25
+ Partials        4241     4240       -1

Impacted Files
Coverage Δ

...java/org/apache/rocketmq/common/ServiceThread.java
81.94% <100.00%> (ø)

... and 22 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


brigade project not associated with a git repository

It looks like the only way currently available is to send the script with the event every time it's emitted (#250 ). Is there any other way, like if VCS repository is empty, fall back to default brigade script which is uploaded when the project is created? Thanks.

Hey, @vincentzhou2013!
Have a look at the Helm values file for Brigade - https://github.com/Azure/brigade/blob/master/charts/brigade-project/values.yaml#L23
There is a defaultScriptName field where you can have your script as Kubernetes ConfigMap:
# OPTIONAL: defaultScriptName is the name of a configmap used as a fallback brigade.js.
# defaultScriptName: default-script-cm

Let us know if you have additional questions!

Thanks! if repository is empty (asked when creating the brigade project),  will it automatically fallback to this default? I don't want it to throw exceptions when repository setting is empty. Thanks.

That's what it sounds like from the documentation.

won't work. the vcs-sidecar always tries to pull source code from the repository specified when the project is created. if no valid repository available, the worker pod just fails (Init:Error) . Even after I disabled the vcs-sidecar by manually editing project secret's vcs-sidercar value to null, brigade-worker (version: 0.17.0) was able to start, but quickly ran into error.
`[brigade:app]   TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or arr  ay-like object.

k8s.js:601 b64dec
./dist/k8s.js:601:19

k8s.js:627 secretToProject
./dist/k8s.js:627:15

k8s.js:124 defaultClient.readNamespacedSecret.catch.then.result
./dist/k8s.js:124:16

[brigade:app] error handler is cleaning up
/home/src/node_modules/bluebird/js/release/async.js:61
fn = function () { throw arg; };
^
TypeError: Cannot read property 'log' of undefined

k8s.js:78 BuildStorage.destroy
./dist/k8s.js:78:21

app.js:65 destroyStorage
./dist/app.js:65:18

app.js:82 EventRegistry.brigadier.events.once
./dist/app.js:82:17

events.js:81 EventRegistry.fire
./dist/events.js:81:14

brigadier.js:34 Object.fire
./dist/brigadier.js:34:20

app.js:185 App.fireError
./dist/app.js:185:19

app.js:103 process.on
./dist/app.js:103:18
`

#272 suggested a solution.

It works with a custom vcs-sidecar ( null git pull ). but even without a repository, a repository name is still needed. null value will trigger above exception.
Suggestion:  "brig project create" should provide a path for projects not having repositories.


windows file upload curl error: 'NoneType' object has no attribute 'file_name'

name: windows file upload curl error: 'NoneType' object has no attribute 'file_name'
about: windows file upload curl error: 'NoneType' object has no attribute 'file_name'
title: ''
labels: bug
assignees: ''

Describe the bug
2024-05-31 13:50:50 pdf-document-layout-analysis  | Page-27
2024-05-31 13:50:50 pdf-document-layout-analysis  | Page-28
2024-05-31 13:50:50 pdf-document-layout-analysis  | Page-29
2024-05-31 13:50:50 pdf-document-layout-analysis  | Page-30
2024-05-31 13:50:50 pdf-document-layout-analysis  | Page-31
2024-05-31 13:50:50 pdf-document-layout-analysis  | 2024-05-31 05:50:50,320 [ERROR] Error
2024-05-31 13:50:50 pdf-document-layout-analysis  | Traceback (most recent call last):
2024-05-31 13:50:50 pdf-document-layout-analysis  |   File "/app/src/app.py", line 24, in run
2024-05-31 13:50:50 pdf-document-layout-analysis  |     return analyze_pdf(file.file.read())
2024-05-31 13:50:50 pdf-document-layout-analysis  |   File "/app/src/analyze_pdf.py", line 55, in analyze_pdf
2024-05-31 13:50:50 pdf-document-layout-analysis  |     pdf_images_list: list[PdfImages] = [PdfImages.from_pdf_path(pdf_path)]
2024-05-31 13:50:50 pdf-document-layout-analysis  |   File "/app/src/PdfImages.py", line 45, in from_pdf_path
2024-05-31 13:50:50 pdf-document-layout-analysis  |     pdf_features.file_name = pdf_name
2024-05-31 13:50:50 pdf-document-layout-analysis  | AttributeError: 'NoneType' object has no attribute 'file_name'
To Reproduce
Steps to reproduce the behavior:

Upload pdf on windows using postman request【curl --location 'localhost:5060'
--form 'file=@"/D:/文件/华信百科/30-中国通服华信设计〔2021〕118号 关于印发《华信咨询设计研究院有限公司青年英才计划实施方案（试行稿）》的通知.pdf"'】
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [Windows 11]

Additional context
Add any other context about the problem here.

@gabriel-piles In Need of a Mentor's Advice

Hello,
This error you are experiencing generally relates to the PDF file - it can be corrupted/broken or there could be a problem with its path. So,

First, please make sure the PDF path is correct.
Then, please ensure there is nothing wrong with the PDF file itself - it is not broken or corrupted.
If the error still persists, please try running the service with another PDF file to see if you experience the same error.

Please inform us about the outcomes!

I've replaced it with another pdf file, but it's still reporting the same error.
Is there any reason why windows file path formats are different from linux?

Hi,
I tested the service on a Windows machine using the "regular.pdf" in test_pdfs directory, and I'm able to get the results without any issues. Can you try running the service as shown in the README, using this command:
curl -X POST -F<EMAIL_ADDRESS>localhost:5060

You might encounter an error like:

Invoke-WebRequest : A parameter cannot be found that matches parameter name 'X'.

If this happens, please use the full path of "curl" as follows:
C:\Windows\System32\curl.exe -X POST -F<EMAIL_ADDRESS>localhost:5060

When I replace the pdf file with test_pdfs/regular.pdf, the request returns correctly, which means there is nothing wrong with my request method or file path. So it's possible that my previous pdf format has something different . Is it possible that there are many different types of pdfs?

Hi,
To resolve the issue, we have updated one of the libraries within our project's requirements. To benefit from it, please pull the changes and run the service again. We believe this update should address the issue you encountered. If, after updating, you still encounter the same issue, please feel free to share the relevant PDF file and we can investigate it further to ensure everything is working as expected.

我没有细看，但会不会是中文路径的问题？尤其是如果作者使用了opencv之类的库，对中文路径是不用好的。


Fix: multiple modals on a single page, resolves #39

A bug in astro-compress (introduced sometime after v1.1.28) incorrectly ships empty script files for the Modal component when running astro build.
In-lining the scripts as Astro recommends with <script is:inline> resolves the empty script tags but still does not handle multiple modals.
This pull request, basically the same as @mciszczon wrote with added abort controllers for the global listeners, makes the script global and switches to a collection of modals. This allows multiple modals on a page and ships less script tags while doing so.
Tested with astro-accessible-starter and the latest version of astro-compress v1.1.42

Thanks mate for actually taking my code and making a PR with it! Been really busy these last weeks 😓


[Question]: Error when accessing the database.

Describe your problem
Sometimes, when I submit a query, the following error occurs:
Traceback (most recent call last):
File "/ragflow/api/apps/conversation_app.py", line 181, in stream
for ans in chat(dia, msg, True, **req):
File "/ragflow/api/db/services/dialog_service.py", line 218, in chat
kbinfos = retr.retrieval(" ".join(questions), embd_mdl, tenant_ids, dialog.kb_ids, 1, dialog.top_n,
File "/ragflow/rag/nlp/search.py", line 304, in retrieval
sres = self.search(req, [index_name(tid) for tid in tenant_ids], kb_ids, embd_mdl, highlight)
File "/ragflow/rag/nlp/search.py", line 102, in search
res = self.dataStore.search(src, highlightFields, filters, matchExprs, orderBy, offset, limit, idx_names, kb_ids)
File "/ragflow/rag/utils/infinity_conn.py", line 300, in search
kb_res = builder.to_pl()
File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 414, in to_pl
return self.query_builder.to_pl()
File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 462, in to_pl
return pl.from_pandas(self.to_df())
File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 455, in to_df
data_dict, data_type_dict = self.to_result()
File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 451, in to_result
return self._table._execute_query(query)
File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 459, in _execute_query
raise InfinityException(res.error_code, res.error_msg)
infinity.common.InfinityException: (3052, 'Trying to match: (sinc^0.0185 ""^0.0046) (user^0.0183 "exploit"^0.0046 "drug"^0.0046 "user"^0.0046) (latest^0.0189 "late"^0.0047 "belat"^0.0047 "up-to-the-minut"^0.0047 "former"^0.0047) (question^0.0185 "doubt"^0.0046 "motion"^0.0046 "wonder"^0.0046
What could be the issue?

Describe your problem
Sometimes, when I submit a query, the following error occurs: _Traceback (most recent call last): File "/ragflow/api/apps/conversation_app.py", line 181, in stream for ans in chat(dia, msg, True, **req): File "/ragflow/api/db/services/dialog_service.py", line 218, in chat kbinfos = retr.retrieval(" ".join(questions), embd_mdl, tenant_ids, dialog.kb_ids, 1, dialog.top_n, File "/ragflow/rag/nlp/search.py", line 304, in retrieval sres = self.search(req, [index_name(tid) for tid in tenant_ids], kb_ids, embd_mdl, highlight) File "/ragflow/rag/nlp/search.py", line 102, in search res = self.dataStore.search(src, highlightFields, filters, matchExprs, orderBy, offset, limit, idx_names, kb_ids) File "/ragflow/rag/utils/infinity_conn.py", line 300, in search kb_res = builder.to_pl() File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 414, in to_pl return self.query_builder.to_pl() File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 462, in to_pl return pl.from_pandas(self.to_df()) File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 455, in to_df data_dict, data_type_dict = self.to_result() File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 451, in to_result return self._table._execute_query(query) File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 459, in _execute_query raise InfinityException(res.error_code, res.error_msg) infinity.common.InfinityException: (3052, 'Trying to match: (sinc^0.0185 ""^0.0046) (user^0.0183 "exploit"^0.0046 "drug"^0.0046 "user"^0.0046) (latest^0.0189 "late"^0.0047 "belat"^0.0047 "up-to-the-minut"^0.0047 "former"^0.0047) (question^0.0185 "doubt"^0.0046 "motion"^0.0046 "wonder"^0.0046...._
What could be the issue?

@Vova-Ponomarenko1 Can you paste the full InfinityException line?

@Vova-Ponomarenko1 Can you paste the full InfinityException line?

Here, I just caught it again, but with different words.
Traceback (most recent call last):   File "/ragflow/api/apps/conversation_app.py", line 181, in stream     for ans in chat(dia, msg, True, **req):   File "/ragflow/api/db/services/dialog_service.py", line 218, in chat     kbinfos = retr.retrieval(" ".join(questions), embd_mdl, tenant_ids, dialog.kb_ids, 1, dialog.top_n,   File "/ragflow/rag/nlp/search.py", line 304, in retrieval     sres = self.search(req, [index_name(tid) for tid in tenant_ids], kb_ids, embd_mdl, highlight)   File "/ragflow/rag/nlp/search.py", line 102, in search     res = self.dataStore.search(src, highlightFields, filters, matchExprs, orderBy, offset, limit, idx_names, kb_ids)   File "/ragflow/rag/utils/infinity_conn.py", line 300, in search     kb_res = builder.to_pl()   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 414, in to_pl     return self.query_builder.to_pl()   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 462, in to_pl     return pl.from_pandas(self.to_df())   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 455, in to_df     data_dict, data_type_dict = self.to_result()   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 451, in to_result     return self._table._execute_query(query)   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 459, in _execute_query     raise InfinityException(res.error_code, res.error_msg) infinity.common.InfinityException: (3052, 'Trying to match: (sinc^0.0540 ""^0.0135) (convers^0.0551 ""^0.0138) (empti^0.0551 ""^0.0138) (ll^0.1339 ""^0.0335) (provid^0.0534 ""^0.0133) (full^0.0540 "broad"^0.0135 "wide"^0.0135 "fulli"^0.0135 "full"^0.0135 "moon"^0.0135 "entir"^0.0135 "wax"^0.0135) (user^0.0534 "exploit"^0.0133 "drug"^0.0133 "user"^0.0133) (question^0.0540 "doubt"^0.0135 "motion"^0.0135 "wonder"^0.0135 "interview"^0.0135 "interrog"^0.0135) (that^0.0530 ""^0.0133) (follow^0.0540 "come"^0.0135 "keep"^0.0135 "up"^0.0135 "trace"^0.0135 "compli"^0.0135 "succeed"^0.0135 "play"^0.0135 "along"^0.0135 "watch"^0.0135 "be"^0.0135 "take"^0.0135 "after"^0.0135 "pursu"^0.0135 "stick"^0.0135 "to"^0.0135 "surveil"^0.0135 "postdat"^0.0135 "adopt"^0.0135) (convers^0.0551 ""^0.0138) (.^0.0789 ""^0.0197) (weather^0.0551 "upwind"^0.0138) (rochest^0.0570 ""^0.0143) (2024-11-29^0.1341 ""^0.0335) "sinc convers"^0.1102 "convers empti"^0.1102 "empti ll"^0.2678 "ll provid"^0.2678 "provid full"^0.1079 "full user"^0.1079 "user question"^0.1079 "question that"^0.1079 "that follow"^0.1079 "follow convers"^0.1102 "convers ."^0.1579 ". weather"^0.1579 "weather rochest"^0.1140 "rochest 2024-11-29"^0.2681 on fields: title_tks^10,title_sm_tks^5,important_kwd^30,important_tks^20,content_ltks^2,content_sm_ltks failed.@src/planner/bound_select_statement.cpp:288')

@Vova-Ponomarenko1 I confirm that this infinity error is caused by  (.^0.0789). I'll investigate why infinity fulltext search doesn't accept this.

@Vova-Ponomarenko1Я підтверджую, що причиною цієї помилки нескінченності є  (.^0.0789). Я досліджу, чому нескінченний повнотекстовий пошук не приймає це.
zhichyu=> SELECT id FROM ragflow_f20be414ae0011ef989ff4a80deb0ad1_f7172f04ae0011efa5b0f4a80deb0ad1 SEARCH MATCH TEXT ('title_tks^10,title_sm_tks^5,important_kwd^30,important_tks^20,content_ltks^2,content_sm_ltks', ' (.^0.0789)');
Trying to match:  (.^0.0789) on fields: title_tks^10,title_sm_tks^5,important_kwd^30,important_tks^20,content_ltks^2,content_sm_ltks failed.@src/planner/bound_select_statement.cpp:288

Ми змінимо генератор запитів RAGFlow, щоб уникнути такого виведення.

Thank you, then I think it’s worth mentioning that I sometimes encountered another error when using words with incorrect structure, such as (^hello) or (hel`lo).
Traceback (most recent call last):   File "/ragflow/api/apps/conversation_app.py", line 181, in stream     for ans in chat(dia, msg, True, **req):   File "/ragflow/api/db/services/dialog_service.py", line 218, in chat     kbinfos = retr.retrieval(" ".join(questions), embd_mdl, tenant_ids, dialog.kb_ids, 1, dialog.top_n,   File "/ragflow/rag/nlp/search.py", line 304, in retrieval     sres = self.search(req, [index_name(tid) for tid in tenant_ids], kb_ids, embd_mdl, highlight)   File "/ragflow/rag/nlp/search.py", line 102, in search     res = self.dataStore.search(src, highlightFields, filters, matchExprs, orderBy, offset, limit, idx_names, kb_ids)   File "/ragflow/rag/utils/infinity_conn.py", line 282, in search     builder = builder.match_dense(   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/table.py", line 344, in match_dense     self.query_builder.match_dense(   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/query_builder.py", line 208, in match_dense     optional_filter = get_search_optional_filter_from_opt_params(knn_params)   File "/ragflow/.venv/lib/python3.10/site-packages/infinity/remote_thrift/utils.py", line 239, in get_search_optional_filter_from_opt_params     optional_filter = traverse_conditions(condition(v))   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/expressions.py", line 4654, in condition     return maybe_parse(  # type: ignore   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/expressions.py", line 4284, in maybe_parse     return sqlglot.parse_one(sql, read=dialect, into=into, **opts)   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/__init__.py", line 148, in parse_one     result = dialect.parse_into(into, sql, **opts)   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/dialects/dialect.py", line 168, in parse_into     return self.parser(**opts).parse_into(expression_type, self.tokenize(sql), sql)   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/dialects/dialect.py", line 177, in tokenize     return self.tokenizer.tokenize(sql)   File "/ragflow/.venv/lib/python3.10/site-packages/sqlglot/tokens.py", line 814, in tokenize     raise ValueError(f"Error tokenizing '{context}'") from e ValueError: Error tokenizing ' OR ("hello"~2)^0.5)^1.0) OR (("2024" OR "2024"))''

RAGFlow need to correct following queries:
(.^0.0789)
2024-11-29^0.1341
""^0.0335
(^hello)
(hel`lo)


docs: Add docs structure recommendations, update style guide

Expand the docs for contributing to Cilium's documentation, by adding new items to the style guide (including common pitfalls to avoid), and by adding a new section with recommendations on the structure of the docs.
Most of the new additions were written by Sarah, I mostly took care of porting them to Cilium's documentation.

@zacharysarah, can you please review when you have a moment?

BTW I also love this.


NodeSelector don't work for cronjobs

I started this helm with added:
nodeSelector:
  kubernetes.io/hostname: hworker3

this deployed owncloud with pods running on this particular node, nodeSelector is added to deployments (and pods) correctly)
but it's not for CronJobs, those were created on different nodes and failed to do anything (because of storage avaiablibity)

Thanks for the report!


Update/rust example hyper v1

Summary
The HTTP crate hyper has had a major version update (from 0.14 to 1.x; more details at https://hyper.rs/guides/1/upgrading/).
In this PR, I've updated the roll_dice Rust example to use the new major version.
Moreover, the opentelemetry packaging has changed (esp. the refractor of the sdk from the core opentelemetry base crate into its own opentelemetry_sdk). I've updated the example accordingly.

🙃 I've tried to fix the commit authorship, signed the EasyCLA, but still ❌

Ergh, sorry for the CLA shenanigans :(
Some possible things to try:

Sign into the cla tool with the email from the original commit, see if it lets you sign that way
...maybe rebasing works? never tried
Close and re-open a new PR using your @ekquasar email for commits

@cartermp thank you - the new PR is https://github.com/open-telemetry/opentelemetry.io/pull/4242
^ EasyCLA passing, linter is not... but that I can certainly figure out.


Formatter: Allow comments between and/or and the right hand side

The following input is stable with black ...
if (
    a
    # own line comment between left hand side and `and`
    and
    # own line comment between `and` and right hand side
    b
):
    pass

... but we move the second own line comment before the and:
if (
    a
    # own line comment between left hand side and `and`
    # own line comment between `and` and right hand side
    and b
):
    pass

The behavior is the same with or, but + works, i.e. other binary expressions work but not boolean expressions.

We may want to generalize the formatting of all BinaryLike nodes to achieve consistent formatting.

I actually prefer our formatting over black's and it preserves the comment ordering. But we should align the comment placement for all binary like expressions.

I agree with Micha that our formatting is more readable at the expense of possibly overriding user intent. I don't see what extra context can be given by having the comment after the operator though.

I guess the challenge with the current formatting is how to handle trailing and comments and preserve order: Playground

And this is another funny one CC: @charliermarsh You best run our formatter on django and take a look at the diff. There are plenty of examples.

I can take it on.

Thank you @charliermarsh
If possible, could we align the comment handling with the binary expression formatting? It's very likely that I have to unify the two implementations and that would be significantly easier if they roughly work the same.

It turns out that the string formatting doesn't overlap with and or formatting. It only affects binary and comparison expressions. That means this is still up for grabs.
Overall, the binary / compare formatting seems very reasonable. Maybe we can mimick that formatting for boolean expressions

@charliermarsh do you plan to work on this next week? If not, @konstin would you be interested in taking a look. It's our biggest difference in Django by now.

@konstin - please go ahead! Haven’t started on it at all.

@konstin sorry for the forth and back. I consider rewriting the boolean expression formatting to use the BinaryLike formatting (the same logic as the binary and compare expressions use) to fix #7004 just once rather than in two places. Maybe... just maybe, it fixes this difference too


Support Redis cluster topology for the Redis scaler

Support Redis cluster topology for the Redis scaler
See discussion for context: https://github.com/kedacore/keda/discussions/872#discussion-5906
Use-Case
Right now, the Redis scaler only supports non-clustered Redis topology. In our stack, however, we use Redis cluster to provide horizontal scalability and HA. Some cloud providers such as AWS and Azure also offer Redis cluster in their offering.
See https://redis.io/topics/cluster-spec and https://redis.io/topics/cluster-tutorial for more info on the Redis cluster topology.
Specification

[ ] Support specifying multiple addresses in the address field of the trigger spec (one for each node).

Since the cluster topology requires the client to be cluster-aware, I don't know if this would be a separate scaler or if it could be integrated with the current Redis scaler with some more fields in the trigger (perhaps topology = normal (default), OR cluster and addresses (if topology is cluster).  In our applications, simply swapping for a cluster-aware client was the only require step in order to support this topology (redis-py-cluster instead of redis-py).

@mboutet are you willing to contribute this feature?

Yes, I could look into it. That would be a great way to start properly leaning Go. I have no definite timeline right now. I will first familiarize myself with the codebase.

@mboutet excellent, great! In that case, I'd recommend you to look at upcoming v2 codebase https://github.com/kedacore/keda/tree/v2

Hi @mboutet any update on this issue?

@turbaszek, I haven't done any work on this yet. I was thinking of waiting for the v2 codebase to be officially released to start working on this. Of course, don't hesitate to start the implementation on this if you want.

Can I give it a try if that's okay?

Yes of course! I haven't done anything on my side.

I did a bit of homework and could think of two approaches to this:

Include a boolean field clusterEnabled and a clusterClient field:

diff --git a/pkg/scalers/redis_scaler.go b/pkg/scalers/redis_scaler.go
index bd9da22..1db3459 100644
--- a/pkg/scalers/redis_scaler.go
+++ b/pkg/scalers/redis_scaler.go
@@ -24,8 +24,10 @@ const (
 )

 type redisScaler struct {
-       metadata *redisMetadata
-       client   *redis.Client
+       metadata       *redisMetadata
+       client         *redis.Client
+       clusterClient  *redis.ClusterClient
+       clusterEnabled bool
 }

Then, based on clusterEnabled field we would know which client to use for redis related operations..

Create separate cluster-aware redis scalers. This would have two implementations for each scaler type.

Would really appreciate any alternatives or suggestions.

Although I'm not a fan of the name I think a flag sounds ok for me, wdyt @zroubalik? What about isClustered or so?
Are you able to contribute this @goku321?

Definitely @tomkerkhove. Will start working on it.

What would the trigger's OpenAPI spec looks like? Right now, the parameters are: address, host, port. For the cluster, they should be addresses, hosts, and ports. Unless address, host, and port are also used when in cluster mode, but it would be an inconsistent naming convention in my opinion. Also, the current redis scalers have the optional databaseIndex which is not supported by the cluster configuration, so there should at least be validation if the same scalers spec are used.
Perhaps having different scalers (from the user's perspective at least) would be better/cleaner so that the trigger specs only contain what's relevant for the normal redis configuration or for the clustered configuration.

I'm not a redis expert so I expected those to be identical, but if it's different than a different scaler feels best indeed

When hosts and ports are given, I'm assuming there will be one to one mapping in the same order. For example: first host inside hosts will be used with the first port inside ports.

This is supported already.


AD Authentication Passthrough

Volkan,
I am building my own sub template of Serene to use for internal applications.
I am trying to implement the AD example. I have it working to the point that when a user logs in the first time that it is passing them through fine and creating their account for them which is great and works well.
My problem is that I want to implement a sign on once and never bother again approach. As in I can retrieve their information fine with UserDefinition, I can also populate personalisation based on that. My sticking point is flagging them as authorised.
If I change AccountPage:Action this:
public ActionResult Login(string activated)
{
ViewBag.Activated = activated;
if (string.IsNullOrEmpty(Request.LogonUserIdentity.Name))
{
ViewBag.HideLeftNavigation = true;
return View(MVC.Views.Membership.Account.AccountLogin);
}
else
{
// Have to allow here setting authentication for Domain Users
// And pass them through to the called page.
}
}
I can trap the user if they are not on the right domain etc. But how can I pass a domain user through. Is there an authenticate call I can use that just accepts a valid username?

Set persistent cookie in AccountPage Login method, with last parameter TRUE. They won't have to login again. If not, you may also set authentication ticket like they logged in already, with WebSecurityHelper.SetAuthenticationTicket

Works perfectly. Guess I was overthinking it.


Java command and version checking

Fixes #43

Look :ok: to me, but I'm wondering if works under Windows.

It's using the same wrapper that we use to launch jetty:
https://github.com/projecthydra/jettywrapper/blob/master/lib/jettywrapper.rb#L410


Fix typo in getting started readme

While reviewing some documentation I noticed a typo which is corrected in this PR.

Thanks for the PR! Somebody else spotted that same typo yesterday and fixed it in https://github.com/thoughtbot/factory_bot/pull/1385, so I am going to close this.

Sounds good, sorry I didn't check issues first 😬


Need help with unit testing generated classes

Hello there!
I'm using your library in my project. Unfortunately, I couldn't find any examples of writing unit tests for classes generated by the useStyles hook (which returns makeStyles function). For example:
const MenuItem: FC<IProps> = ({
  label,
  url,
  iconSrc,
  active = false,
}) => {
  const { classes, cx } = useMenuItemStyles();
  return (
    <a
      href={url}
      target="_blank"
      rel="noreferrer"
      data-testid="menu-item-link"
      className={cx(
        сlasses.link,
        active && сlasses.active
      )}
    >
      {label}
    </a>
  );
};

it.skip("should render anchor with active class if active prop is true", () => {
  expect.hasAssertions();

  const { getByTestId } = render(
    <ThemeProvider theme={LayoutTheme}>
      <CollapsedMenuItem
        label={label}
        url={url}
        iconSrc={iconSrc}
        active={true}
      />
    </ThemeProvider>
  );

  expect(getByTestId("menu-item-link")).toHaveClass("active");
});

This test, or any other similar test, cannot pass because the active class does not exist. Instead, a class with a hash is generated. Is it possible to control or mock this generation process? In the past, MUI had a StylesProvider where you could set the class name generator using the generateClassName prop.
For example:
const generateClassName: StylesOptions['generateClassName'] = (
  rule,
  sheet
): string => `${sheet?.options.classNamePrefix}-${rule.key}`;

export const provideTheme = (ui: ReactElement): ReactElement => {
  return (
    <ThemeProvider theme={theme}>
      <StylesProvider generateClassName={generateClassName}>
        {ui}
      </StylesProvider>
    </ThemeProvider>
  );
};

I couldn't find similar mechanisms in your library.

HI @OlIvAl,
I'll see what I can do but allow me to challange your testing approach.
Why testing for classNames instead of testing for poperties like MUI does?
Because the main strengh of TSS (and Emotion) is to be able to generate the styles dynamically and get rid of
the class witching logic.
const MenuItem: FC<IProps> = ({
  label,
  url,
  iconSrc,
  active = false,
}) => {
  const { classes, cx } = useMenuItemStyles({ active });
  return (
    <a
      href={url}
      target="_blank"
      rel="noreferrer"
      data-testid="menu-item-link"
      className={сlasses.link}
    >
      {label}
    </a>
  );
};

const useMenuItemStyles = makeStyles<{ active: boolean; }>()((theme, { active }) => ({
   link: {
      // generate the style dynamically using active
   }
}));

If I wand to provide a mock I have to be able to generate a fingerprint of the params and the theme state, wich isn't trivial to do safely.

Afterthough:
Under the hood of TSS it's emotion.
Let's see what they have in store.
Can you test with this and tell me if it work for you: https://emotion.sh/docs/testing

Well, I checked and Emotion does snapshot testing. This comes at a cost because you have to maintain your code AND the generated snapshots. I know there's convenience to regenerate the snapshots on almost any test engine, but I'd rather monkey patch the makeStyles method. Does someone know how this could be done or approached?
Regardless of my preference for monkey patching, it would be great to have some examples on the docs for unit testing, or testing in general.
Thanks in advance!


Delete prompt_powerlevel9k_setup

I think this should have been removed as part of https://github.com/sorin-ionescu/prezto/commit/0a07ba27a2f9582a37e7d1a5e08f33c2ad552000.
Currently I'm seeing this warning after updating to master:
Couldn't read file /Users/jeffwidman/.zprezto/modules/prompt/functions/prompt_powerlevel9k_setup containing theme powerlevel9k.

After removing this file, the warning goes away.

@belak thanks for the fast approval.


Fix Register validator e2e test

Description
This PR fixes register validator e2e test. It was failing due to 2 reasons, which are described below.
Misplaced NextValidatorsHash query
Register validator e2e test is flaky, because we are querying for ExtraData and NextValidatorsHash before we make sure that newly registered validator is joined to the consensus protocol.
Proposed solution consists of querying block and check next validators hash only after we make sure that validator is present in new validator set.
Newly registered validator receives 0 for rewards
Another problem why this test was failing was because of new validator's rewards. The validator rewards were 0 even after the validator is registered, and jointed validator set and few epochs are passed. This happened because validator never signed any block, and it was not present in the uptime data. The cause why validator wasn't signing is because FSM calculation was never cancelled on receiving fresh blocks and FSM was working with the 'stale' data.
In other words, this occurred:

Validator joins validator set, FSM is initialized, and the sequence is run for the new height (e.g. 15)
In the meantime, other nodes moved to the new proposal height 16
HasQuorum fn is called for the proposal msg on our new validator and the block number 16 is propagated as a new height. This call returns false because in c.fsm.proposerSnapshot.GetLatestProposer there is a check that compares height from the FSM against received block number which is not the same since FSM is stayed on height 15 and proposal moved on. We can see this in the  validator's log
"get latest proposer not found - height: 16, round: 0, pc height: 15, pc round: 0"
Validator keeps getting new blocks from the syncer which should trigger cancelling the current sequence and starting a new one, but that never happens because of the bug
The check in polybft.go that should write in the syncerBlockCh and cause sequence cancellation is following:

if ev.Source == "syncer" && ev.NewChain[0].Number > p.blockchain.CurrentHeader().Number {
	syncerBlockCh <- struct{}{}
}

The thing here is that syncer will call WriteFullBlock for the newly received block, and first it will write the block in the blockchain and then in the same fn calls b.dispatchEvent(evnt) which results in generating an event about the inserted block. But since the block is already inserted, ev.NewChain[0].Number and p.blockchain.CurrentHeader().Number will be the same.
Proposed solution:
The fix for this issue is also included in this PR and allows sequence cancellation also in the case when the syncer block height is equal to the current height from the blockchain.
The FSM at that moment might be calculating block for the lower or the same height, and it is ok to be interrupted since write from the consensus would not happen cause syncer already took the lock and wrote the block for that height. FSM calculation for the newer block then the saved one, can be interrupted only if e.g. node becomes the validator and the new sequence is called after the syncer wrote the block(with the current height+1), but before the event is handled. In that case the calculation for the new block will be interrupted but also new sequence will be started again.
Additional comments
E2E test is still going to fail occasionally (although more rarely than it is currently) with validators' hash mismatch until #1191 gets merged.
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[ ] I have assigned this PR to myself
[ ] I have added at least 1 reviewer
[ ] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[ ] I have tested this code with the official test suite
[ ] I have tested this code manually

Good catch :fire:
P.s. not able to approve it, because I'm a creator of PR


Update russian translation

Hi Alex,
Thanks for your great work!
I just added some missing translations for the Russian language.

Thanks! :)


[Question] Proxy as container app and logging choices in the scenario

I understand that we are using a container app as a Proxy for load balancing and logging requests between the chat app and AOAI. Could you please share any information about why a Proxy is used as a container app instead of deploying an application gateway? Additionally, why do we choose a container app for logging instead of logging at APIM, considering that APIM's diagnostic logs can be used to aggregate subscription keys for chargeback purposes?
I apologize if I have misunderstood anything. I would greatly appreciate it if you could provide some background on the technology choices made for this scenario.

Hi @scdouble
Thank you for your question.
We started working on this repo a while ago. At that time reporting token usage for streaming requests and load balancing in general was not an option, so that's where the proxy comes in which uses YARP. It is still a valid option because the proxy can be used for much more logging scenario's because it "sees" the requests and responses in detail and investigation of that data is being done after the request is send back to the client, so it has a limited impact on the performance.
The API Management team just released GenAI Gateway features that could be an alternative to the proxy solution. Read this blogpost to find out more:
https://techcommunity.microsoft.com/t5/azure-integration-services-blog/introducing-genai-gateway-capabilities-in-azure-api-management/ba-p/4146525
Application Gateway (or Azure Frontdoor) would typically be in front of API Management, where the API Management instance is internal. This gives you an extra layer of protection (WAF v2. and mTLS).
Hope this gives you insight on the possibilities.

@azureholic Thank you very much for your time and assistance ！！Your help has made a positive impact on my understanding and progress.


feat: 🎸 Add SeriesInstanceUIDs wado query param

Add a way to retrieve a subset of series from a study

Context
This will only open the viewer with one series (one displaySet) loaded, and no
queries made for any other series.
Sometimes you need to only retrieve a subset of series in a study, you can do
that by providing study level wado query parameters in the URL such as
SeriesInstanceUIDs. For example:
http://localhost:3000/viewer?StudyInstanceUIDs=<IP_ADDRESS>.4.1.25403.345050719074.3824.20170125113417.1&SeriesInstanceUIDs=<IP_ADDRESS>.4.1.25403.345050719074.3824.20170125113545.4,<IP_ADDRESS>.4.1.25403.345050719074.3824.20170125113545.5

Changes & Results

Add new query param to filter series
Update retrieve study metadata services

Testing

Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] OS: macOS 14.0 (23A344)]
[x] Node version: 16.20
[x] Browser: Chrome 118.0.5993.88

can we merge the other PR by @rodrigobasilio2022 since he has been working on it for a long time (multi server) and I feel bad if I merge this and he has to rebase and resolves conflicts

can we merge the other PR first by @rodrigobasilio2022 since he has been working on it for a long time (multi server) and I feel bad if I merge this and he has to rebase and resolves conflicts

Np! thanks!

@sedghi now that the multi server implementation is going to change, can we merge this one?

@igoroctaviano Can you update the testing notes? how can i test it

@igoroctaviano Can you update the testing notes? how can i test it

Added! thx.


CLEARTEXT error

Im having an issue where it displays a CLEARTEXT error

Please uninstall app and reinstall latest version, I just updated the apps. Thanks for reporting 👍🏻


Cherry-pick #29877 : Use GetAllByCap to get list of network plugins in docker info

Cherry picking #29877 to 1.13 branch as well.
Swarmkit has enabled the plugin filtering logic based on the drivers
returned in "docker info". Currently info endpoint isnt using the
GetAllByCap, but relies on existing networks to get the plugin names.
This causes a basic issue when it comes to global network plugins which
swarm-mode relies on, wherein swarmkit will not be able to schedule the
network on the worker nodes due to the filtering logic.
In order to break this chicken & egg issue, we must start to use the
GetAllByCap instead of relying on the presence of networks to get the
plugin names.
Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

CI looks to be failing;
13:16:18 --- FAIL: Test (3265.54s)
13:16:18 panic: DockerSwarmSuite.TestSwarmNetworkPlugin test timed out after 5m0s [recovered]
13:16:18 	panic: DockerSwarmSuite.TestSwarmNetworkPlugin test timed out after 5m0s
13:16:18
13:16:18 goroutine 8 [running]:
13:16:18 panic(0x12257a0, 0xc42063e010)
13:16:18 	/usr/local/go/src/runtime/panic.go:500 +0x1a1
13:16:18 testing.tRunner.func1(0xc42007a840)
13:16:18 	/usr/local/go/src/testing/testing.go:579 +0x25d
13:16:18 panic(0x12257a0, 0xc42063e010)
...

@thaJeztah this will be solved by https://github.com/docker/docker/pull/29733 (once it is cherry-picked into 1.13.x branch). cc @cpuguy83 @vieux

LGTM

LGTM


[expect-type] Clarification on toEqualType versus toMatchType

Hello!
Thanks for the explanation in this comment. However, it is still not fully clear to me (probably because I'm not familiar with Jest's toMatchObject either).
Please confirm if my understanding is correct:
let a: A;
let b: B;

// Passes if and only if `A` is identical to `B`
expectTypeOf(a).toEqualTypeOf(b)

// Passes if and only if `A extends B`
// In other words, passes if and only if the assignment `b = a` is valid
expectTypeOf(a).toMatchTypeOf(b)

Is this correct?
Thanks!!

Solved by #31


does it still work?

Hi,
I had a homemade implementation of a similar effect on my website but it stopped working. I looked at your example and it seems like it is not working anymore either.
Any idea what happened/changed?

url()s are not allowed anymore unless they point to data: resource


window.gapi.auth2.getAuthInstance().signIn doesn't send callback in Safari

We embedded Google OAuth button inside iframe. When user loads a page with this iframe, clicks Google button from that iframe, window.gapi.auth2.getAuthInstance().signIn fires and new window appears. User enters email, password and submits form. Window closes but there is no callback to this function.
It only reproduces when main window domain is different to iframe domain!
You can try here - https://sparklejobs.com/localhost-universal/ (Please, click 'Log in/Sign up')
Main window domain - sparklejobs.com
Iframe window with Google button - staging-web.good.co

I just had this happen to me today in Safari for the first time (I just updated my computer to the latest MacOS version 10.15.2 prior to this), and it still works in Chrome.
@OlesZadorozhnyy, why was this issue closed, did login start working for you again?


Add PlayCanvas

https://github.com/playcanvas/awesome-playcanvas#readme
A curated list of tools, tutorials, examples, and much more, for the awesome game development engine PlayCanvas.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.
To verify that you've read all the guidelines, please add comment with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

It would be helpful to read over the pull request requirements again as you have missed several steps.

Hi @caufieldjh - thanks for giving it a look. I did read the steps and I thought I'd fulfilled them all. Can you give me some quick pointers please?

Ahhh yeah, and I'm missing an image for the project. OK, on it....

OK, done. Sorry for the oversights there. Hopefully it's all good now. 😄

unicorn <- except for that of course 🤣

Your entry should be added at the bottom of the appropriate category.

@sindresorhus Done.

Tweet: https://twitter.com/awesome__re/status/1194225059243520000


Fix broken links and add linkcheck jobs

This adds a linkcheck to our pilot hubs documentation. Decide to tackle this quickly before writing some extra docs to make sure that we are tracking broken links.
part of https://github.com/2i2c-org/pilot/issues/76

assuming that the link check build passes, I will merge this one in, since it doesn't change content, only fixes links!


PHP Depricated

Hi! During refreshing the maps (map-poller.php), i get PHP Warnings like this:
PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /usr/share/pear/Console/Getopt.php on line 136
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /opt/librenms/html/plugins/Weathermap/weathermap.php on line 64
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 109
PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /usr/share/pear/Console/Getopt.php on line 136
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /usr/share/pear/Console/Getopt.php on line 154
PHP Deprecated:  Non-static method PEAR::isError() should not be called statically in /opt/librenms/html/plugins/Weathermap/weathermap.php on line 64

Is it to you?

This would require the code to be updated to use the latest network weathermap code which probably isn't going to happen anytime soon.


The target framework version should be .NET7.0 for the generated projects when training on the .NET7.0 project.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-22H2
ML.Net Model Builder 2022: <IP_ADDRESS>0101 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.4.1)
.Net: 7.0
Describe the bug

On which step of the process did you run into an issue:
The target framework version should be .NET7.0 for the generated projects when training on the .NET7.0 project.

Data Source
https://testpass.blob.core.windows.net/test-pass-data/forecasting.csv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window.
Choose the C# Console App (.NET Core7.0) project template.
Add model builder by right click on the project.
Select any scenario.
On Data page, select the data source and complete the training.
On the Consume page, click "Add to solution" button to generate the Console App and Web API projects.
Check the target framework version for the generated projects, you will see that:
a. For Forecasting scenario, the target framework version is NET5.0.
b. For other scenarios, the target framework version is NET6.0.

Expected behavior
The target framework version should be .NET7.0.
Screenshot

Additional context

@luisquintanilla to add details. For generated project templates it's okay that it targets the latest LTS version.

Closing this issue since we expect generated projects to be on the latest long-term support version (LTS).


PLT-1462: Add parser for data constant

Currently the PrettyConst Data instance prints the serialised Data, so I added a corresponding parser.
We should decide on a better syntax for Data, such as the one being used in the existing conformance tests. But before we get there, we still need a parser that matches PrettyConst Data. The debugger, for example, needs to parse the UPLC in order to get SourcePos annotations.

We used to have a typeclass for builtin types that insisted we had both a prettyprinter and a parser, maybe we should bring that back :thinking:


Remove content_id from default field

We are no longer using content_id to map to policies, which makes the content_id redundant in the field definitions.

Thanks for keeping things clean.


Display

Dear all,
Axelle has started to implement the display of <citedRange> for the bibliographical references.
Please, have a look at this display when transforming your XMLs and note in this thread your remarks and suggestions.

Not sure if this is directly related to citedRange, but I just noticed the following the other day. I've rechecked and it still happens. I like the new colours by the way. So, I have the following code, within an <app> element. This is from the file CalE40-Sripundi-Tala2.xml in vengicalukya-epigraphy.
<note>Lakshmana Rao takes Guṇakkenallāta as the name used here, and if this form occurs elsewhere that I am not aware of, then he may be correct. K. A. Nilakanta Sastri and N. Venkataramanayya (in <bibl><ref target="bib:Yazdani1960_01"/><citedRange>476</citedRange></bibl>) mention the form Guṇake-nallāṭa, said to mean “the lover of excellence or virtue,” without citing a source. The spelling is definitely with <foreign>t</foreign> here. In my opinion it is more likely that the text is erroneous, for <foreign>°lleti</foreign>, <foreign>°llākhya-</foreign> or <foreign>°llāṁka-</foreign>.</note>
The transformed HTML has
K. A. Nilakanta Sastri and N. Venkataramanayya (in 476) mention the form Guṇake-nallāṭa,
i.e. only the page number is shown, "(in 476) ", instead of the reference, but more conspicuously, there is no  tag in the HTML, so the text from here to the end of the page is displayed as a hyperlink.
In the same file, other biblio items also seem to be displayed as the contents of citedRange alone, without anything else. Thus, in the epigraphic lemma,
Reported in <bibl><ptr target="bib:ARIE1908-1909"/><citedRange unit="page">10</citedRange><citedRange unit="appendix">A/1908-1909</citedRange><citedRange unit="item">5</citedRange></bibl> with discussion in <bibl><ptr target="bib:ARIE1908-1909"/><citedRange>104, 108-109</citedRange></bibl>.
is displayed as follows:
Reported in 10A/1908-19095 with discussion in 104, 108-109.

I haven't seen the same happening yet on my side.
Here is some feedback of my own, based on the following example:

I would recommend that full titles of periodicals be replaced by journal abbreviations as recorded in the "Journal Abbr" field of the Zotero entries in question. Thus, we could here get VBG for Holle 1880 and TBG for Brandes 1889. It might be nice to allow viewers to see the corresponding ful title with mouse over.
I am not yet sure what is the best solution for displaying items that contain a <citedRange> when they occur, as here, in a <listBibl>, but I tentatively suggest that cases like Holle 1880, Sarkar 1971–1972 and Titii Surti Nastiti 2016 be displayed as follows:
-- Holle, K. F. 1880. “Kawi-oorkonden, no. 2: Transcriptie van koperen platen.” VBG 39. Here, pages 1–2, part I A.
-- Sarkar, Himansu Bhusan. 1971–1972. Corpus of the Inscriptions of Java (Corpus Inscriptionum Javanicarum), up to 928 A. D. Calcutta: K.L. Mukhopadhyay. Here, volume 2, pages 99–101, no. 73.
-- Titi Surti Nastiti. 2016. Perempuan Jawa: kedudukan dan peranannya dalam masyarakat abad VIII-XV. Bandung: Pustaka Jaya. Here, pages 412–413.
-- NB (a) use of "Here, ..." means that all words corresponding to @unit ("pages", "part", etc.) can always be shown with lower-case initial; (b) French-style "n°" should become "no."; (c) we need an en-dash in page ranges (1–2, 99–101  and 412–413 in the above examples)
-- possibly, the indications of <citedRange> could also be displayed in bold, to set them off from the basic bibliographic entry that they follow

I am not familiar with the practice of using "Here" and it strikes me as strange.

@danbalogh there is indeed a bug in the <note> regarding the implementation of the . I am going to handle it. But regarding the rest I have the expected display as well.

I am not familiar with the practice of using "Here" and it strikes me as strange. I would prefer to avoid it and I believe it should not be technically difficult to first generate a string for any and all citedRange items, e.g. "volume 2, pages 99-101", and then to transform only the first letter in that string to uppercase. If this is correct (Axelle?) then there is no technical need for us to use "Here," just because we can then use lowercase throughout the citedRange string.
As for "Number", I would actually prefer the proper Unicode character №.

I am sure I have seen scholars use "where" or even "ubi" in similar contexts, and my "Here, ..." was an attempt to emulate this. I think some transition is needed between the principal bibliographic entry and the contents of <citedRange>, and will be happy to accept better (more commonly recognized) solutions, but I don't agree with having nothing at all.
I have never use № but I am not against using it.

@arlogriffiths - whatever you finally settle on regarding these points will be acceptable to me.
@ajaniak I'm using the transformation at project-documentation/stylesheets/inscriptions/start-edition.xsl. Is there a later version that I should be using? I've just checked and I still get this strange output. If the above is the correct XSL to use, then could you check one of my files in vengicalukya-epigraphy to see if perhaps I'm doing something wrong?
Thus, e.g. in CalE39-Arumbaka-Badapa.xml, from the code

Reported in <bibl><ptr target="bib:ARIE1920-1921"/><citedRange unit="page">17</citedRange><citedRange unit="appendix">A/1920-1921</citedRange><citedRange unit="item">16</citedRange></bibl> with discussion in <bibl><ptr target="bib:ARIE1920-1921"/><citedRange>90-91</citedRange></bibl>. Edited from inked impressions (made by G. Venkoba Rao) and from the original plates by K. V. Lakshmana Rao (<bibl rend="omitname"><ptr target="bib:LakshmanaRao1927-1928_02"/><citedRange unit="page">137-148</citedRange><citedRange unit="item">1</citedRange></bibl>), with translation and facsimile (and photo of the seal). The present edition by Dániel Balogh is based on a collation of Lakshmana Rao's edition with his facsimiles.<note>The facsimiles, as scanned, are illegible in many places. I rely primarily on Lakshmana Rao's readings, and generally mark up unclear only where he did so, assuming that the originals were much better legible. However, he seems not to distinguish unclear readings from restorations in his editions, so it is quite possible that all or most of the "unclear" readings are in fact restorations, and many of the "clear" readings are unclear even in the original. Consulting the printed facsimile may also help.</note>

  <listBibl type="primary">
    <bibl n="KVL"><ptr target="bib:LakshmanaRao1927-1928_02"/><citedRange unit="page">137-148</citedRange><citedRange unit="item">1</citedRange></bibl>

  </listBibl>
  <listBibl type="secondary">
    <bibl><ptr target="bib:ARIE1920-1921"/><citedRange unit="page">17</citedRange><citedRange unit="appendix">A/1920-1921</citedRange><citedRange unit="item">16</citedRange></bibl>
    <bibl><ptr target="bib:ARIE1920-1921"/><citedRange>90-91</citedRange></bibl>
  </listBibl>

I get the following HTML,

Bibliography

Reported in 17A/1920-192116 with discussion in 90-91. Edited from inked impressions (made by G. Venkoba Rao) and from the original plates by K. V. Lakshmana Rao (137-1481), with translation and facsimile (and photo of the seal). The present edition by Dániel Balogh is based on a collation of Lakshmana Rao's edition with his facsimiles.The facsimiles, as scanned, are illegible in many places. I rely primarily on Lakshmana Rao's readings, and generally mark up unclear only where he did so, assuming that the originals were much better legible. However, he seems not to distinguish unclear readings from restorations in his editions, so it is quite possible that all or most of the "unclear" readings are in fact restorations, and many of the "clear" readings are unclear even in the original. Consulting the printed facsimile may also help.

Primary
 137-1481
Secondary
 17A/1920-192116 90-91

Yes, there is 2 two launching files since the bibliographic data when not well formatted refused to rend a html and because of the parameters I can't handle it a more friendly way for now (still trying to figure something that still allows all the content to still perform). If you want the bibliography, you can use the start-edition-with-bibl.xsl.
Sorry I thought you knew.

Thanks, I didn't know, or I may have forgotten. The above problems do not appear with that xsl, but there are some others.
The following code

Reported in <bibl><ptr target="bib:ARIE1920-1921"/><citedRange unit="page">17</citedRange><citedRange unit="appendix">A/1920-1921</citedRange><citedRange unit="item">16</citedRange></bibl> with discussion in <bibl><ptr target="bib:ARIE1920-1921"/><citedRange>90-91</citedRange></bibl>. Edited from inked impressions (made by G. Venkoba Rao) and from the original plates by K. V. Lakshmana Rao (<bibl rend="omitname"><ptr target="bib:LakshmanaRao1927-1928_02"/><citedRange unit="page">137-148</citedRange><citedRange unit="item">1</citedRange></bibl>), with translation and facsimile (and photo of the seal). The present edition by Dániel Balogh is based on a collation of Lakshmana Rao's edition with his facsimiles.<note>The facsimiles, as scanned, are illegible in many places. I rely primarily on Lakshmana Rao's readings, and generally mark up unclear only where he did so, assuming that the originals were much better legible. However, he seems not to distinguish unclear readings from restorations in his editions, so it is quite possible that all or most of the "unclear" readings are in fact restorations, and many of the "clear" readings are unclear even in the original. Consulting the printed facsimile may also help.</note>

  <listBibl type="primary">
    <bibl n="KVL"><ptr target="bib:LakshmanaRao1927-1928_02"/><citedRange unit="page">137-148</citedRange><citedRange unit="item">1</citedRange></bibl>

gives this display:

issues:

what should be an  tag is instead <i> in the HTML
ARIE reference displayed with full title in the text, where it should, I think, just be ARIE 1920-21 etc.
year (1927) bracketed - as per the issue brought up by Arlo, no need for separate attention here
funny placement around the siglum of the primary biblio item

Ah sorry I deleted too much code yesterday while removing the parentheses around date and I only tested it on Manu's.

the  are inherit from Zotero. Why would you expect a html tag to be displayed <i>? The italic isn't applied because of the parent element
You need to declare the @rend at the level of the  element when you don't want the by default displayed from Zotero. In this case, @rend='siglum' if you want to fetched the siglum or @rend='journal' if you want the journal abbreviation display.
The parentheses are still displayed because it is a case with @rend='omitname' and as far as I understood the issue @manufrancis has asked to keep them here and no consensus was reached yet.
caused by the fact I am working currently on the code and it can cause the block to be disturbed the block. It is already resolve.

the  are inherit from Zotero. Why would you expect a html tag to be displayed <i>? The italic isn't applied because of the parent element
I don't expect to display as <i>. Quite the opposite. It is rendered that way by the current xsl, and so it is displayed as  instead of being rendered as italics.
You need to declare the @rend at the level of the  element when you don't want the by default displayed from Zotero. In this case, @rend='siglum' if you want to fetched the siglum or @rend='journal' if you want the journal abbreviation display.
Fine by me if this is how Manu wants this. I thought ARIE items would be displayed as ARIE, but if not, OK. As for @rend='siglum', this is the first I hear about it. If this is something settled (though @rend should not really be used here, for the same reason you discourage it on <citedRange>), then someone please add a comment to the EGD about when and how to use this.

The parentheses are still displayed because it is a case with @rend='omitname' and as far as I understood the issue @manufrancis has asked to keep them here and no consensus was reached yet.
I thought we had consensus: no parentheses anywhere regardless of rend. But do wait for Manu's agreement before changing this.

caused by the fact I am working currently on the code and it can cause the block to be disturbed the block. It is already resolve.
OK, thanks.

the  are inherit from Zotero. Why would you expect a html tag to be displayed <i>? The italic isn't applied because of the parent element
I don't expect to display as <i>. Quite the opposite. It is rendered that way by the current xsl, and so it is displayed as  instead of being rendered as italics.
You need to declare the @rend at the level of the  element when you don't want the by default displayed from Zotero. In this case, @rend='siglum' if you want to fetched the siglum or @rend='journal' if you want the journal abbreviation display.
Fine by me if this is how Manu wants this. I thought ARIE items would be displayed as ARIE, but if not, OK. As for @rend='siglum', this is the first I hear about it. If this is something settled (though @rend should not really be used here, for the same reason you discourage it on <citedRange>), then someone please add a comment to the EGD about when and how to use this.

The parentheses are still displayed because it is a case with @rend='omitname' and as far as I understood the issue @manufrancis has asked to keep them here and no consensus was reached yet.
I thought we had consensus: no parentheses anywhere regardless of rend. But do wait for Manu's agreement before changing this.

caused by the fact I am working currently on the code and it can cause the block to be disturbed the block. It is already resolve.
OK, thanks.

I am not familiar with the practice of using "Here" and it strikes me as strange. I would prefer to avoid it and I believe it should not be technically difficult to first generate a string for any and all citedRange items, e.g. "volume 2, pages 99-101", and then to transform only the first letter in that string to uppercase. If this is correct (Axelle?) then there is no technical need for us to use "Here," just because we can then use lowercase throughout the citedRange string.
As for "Number", I would actually prefer the proper Unicode character №.

I am sure I have seen scholars use "where" or even "ubi" in similar contexts, and my "Here, ..." was an attempt to emulate this. I think some transition is needed between the principal bibliographic entry and the contents of <citedRange>, and will be happy to accept better (more commonly recognized) solutions, but I don't agree with having nothing at all.
I have never use № but I am not against using it.

@ajaniak : I have seen your example in #81. It looks close to acceptable for me. Could you try to apply bold to the <citedRange> and show us in response to the comment what the result looks like?

@danbalogh we have kept the @rend on <bibl>because the EGD has chosen it for omitname; so for consistency sake, we have kept the @rend.
@arlogriffiths is this what you wanted by applying bold on citedRange?

@ajaniak : yes, this is exactly what I had in mind, thanks! to me it looks good, with only one small improvement to be made:

the hyphen in citedRange must be displayed as en-dash

@danbalogh @manufrancis @AnneSchmiedchen : please confirm that you are alright, for the time being, to see the contents of citedRange displayed in this manner, i.e., only in our structured bibliographies.

@arlogriffiths for the en-dash: do I apply it in all the bibliographic data or only in the bibliography part?

all bibliographic data
Le 6 oct. 2020 à 14:16, ajaniak <notifications<EMAIL_ADDRESS>a écrit :
@arlogriffithshttps://github.com/arlogriffiths for the en-dash: do I apply it in all the bibliographic data or only in the bibliography part?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/erc-dharma/project-documentation/issues/82#issuecomment-704228495, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGMAE5JWT3P2QP3SBYWK7TSJMDBNANCNFSM4R7GR54A.

Done (I have pushed so you have all the little stuffs I have just done and will delete the bold if necessary later)

Thanks. Here's another small point to be improved.
If @unit="page" or if no @unit is present (meaning by default that we're dealing with pages as unit), a distinction should be made between behavior of <citedRange> in <listBibl> and in other contexts.
Behavior in <listBibl> is now satisfactory for me, with the bold.
But in other contexts, we do not expect any "page" or "pages" to be inserted in the display. Rather, we wish to see the usual AUTHOR DATE: NUMBER format. Thus, in the following example

we should see "Casparis 1950: 151–160" instead of "Casparis 1950, pages 151–160".
@manufrancis @AnneSchmiedchen @danbalogh : your votes please.

Yes, no "page" or "pages" in these contexts, please.

I agree.

Fine with me.


Fixes for fuzzer bugs.

Initialize full image area with RenderPadding if frame is outside image
Use unaligned store/load in all stages
Only run per-group render pipeline if modular could decode something

Wait, it will cause full-image-padding for each group?

Good point, I changed it to do the full padding only for group 0. PTAL


Disable IconButton ripple effect

How can I disable IconButton ripple effect?

code:
ft.IconButton(icon=ft.icons.ADD, icon_size=20)

Well here is a hacky way I used to fix this.
ft.Container(
   content=ft.Image(
      src="icons/messenger-outline.svg",
      width=22,
      height=22,
      fit=ft.ImageFit.COVER,
      repeat=ft.ImageRepeat.NO_REPEAT
   ),
   on_click= # on click function
)

However it would be great if I can do something like this:
ft.IconButton(
    icon=ft.icons.ADD,
    icon_size=2,
    show_ripple=False, # show ripple effect or no
    padding=0 # remove padding
)

SO thread: https://stackoverflow.com/a/61348072
Link to prop: https://api.flutter.dev/flutter/material/IconButton/highlightColor.html


Update Find Command

Find command should target both modules and person.
The search area should be expanded from just the name to everything.

Updated with the merging of PR #117.


Website redesign

We'd like to do a redesign of eslint.org, with the goals of:

Making the landing page more useful. Some sites we think do this well (@eslint/eslint-team, feel free to add more here):

http://facebook.github.io/react/
http://emberjs.com
http://gruntjs.com/
http://babeljs.io/
https://git-for-windows.github.io/

Ensuring the most recent ESLint version number is featured prominently
Featuring most recent five blog posts
Providing good readability for documentation (typography and styling)
Being responsive

If you have thoughts or suggestions, please feel free to share them here.

Example of a simple inconsistency which pushes me out of the flow a bit each time I learn a new rule:
http://eslint.org/docs/rules/ has rule string as hyperlink text followed by hyphen and rule description in all lowercase, for example:
comma-dangle - disallow or enforce trailing commas
http://eslint.org/docs/rules/comma-dangle heading has rule description in title case followed by rule string in parentheses, for example:
Disallow or Enforce Dangling Commas (comma-dangle)

Small list from me:
https://karma-runner.github.io/0.13/index.html
http://nightwatchjs.org/
https://code.visualstudio.com/
https://atom.io/

UI Design for Landing Page. There will be feature drill-down with illustrations below the scroll. This page (home), has a title Getting Started, so this page acts as a starting point to understand what is ESLint (and Linting), what are the capabilities of it, which companies are using and links to more detailed guides/documentation.
Features:

Everythings is pluggable
Add Rules at Runtime
Every rule is standalone
Rules can be a warning or an error
Test Ready
Your code, your style
Command Line Interface
ES2015 Ready
Open-Source
Javascript and JSX
Extensive Support (Editors, Build Systems, Command Line Tools, Testing and more)

Feel free to give feedback, so I can continue from there.
Headline and copy-texts can change of course, general feel and utility is more important at this stage.

Thanks @omerbalyali, this looks like a good start. Some thoughts (in no particular order, and skipping over any notes on content):

Really love the header
Cool graphic
Perhaps a bit too much purple and too dark at the top? For some reason, I'm thinking that splash area could use a faded-back background graphic rather than just color (maybe because that's what we have now, but I'm not sure).
I like the centrally-located "Get Started" button
Also like the stable version/view on github treatment.

So I think general :+1: on overall direction.
@eslint/eslint-team thoughts?

I know design taste is a very personal thing, but I'm definitely not liking this direction. Very heavy, hard to read mono-sized fonts, dark background, no air, colors that don't play well together, etc.
I do like visual linting representation though. Red -> Green text idea is pretty neat.

@ilyavolodin it sounds like your biggest complain is being too dark (similar to my "too much purple")? I'm not sure the text reads as mono or hard to read to me, are you viewing the image in full size? (It took me a minute to realize I wasn't the first time I viewed the image.)

Agree with "too much purple/too dark" complaints. Rest looks pretty good. Key points got my attention immediately that we want a user looks answers to:

What is this thing?
How do I use it?
What is the current version
Is it pretty/polished?

Thank you Nicholas,
I agree with the need of a background graphic but I didn't think of anything to illustrate so I just leave it with some transparent dotted lines.
@ilyavolodin We are trying to make the ESLint website accessible and easy-to-use for everyone, so it's important to get every feedback to make it so.
For the colors, I'm not sure which direction to go: purple or more blue, or in between (indigo color or gradient as it is now). Blue is more "reliable" color than purple, but purple has some character too. I would choose more blue but I want you to decide.
This one looks more clear and it surely reduced the color load on the eyes:

For the color complaints; we can remove the background and use white background with some illustrations on top of it. I will experiment with it.
@BYK There will be features and installation/usage instructions below, I'm working on it. I will upload a wireframe, so it will be easy to discuss.
Thanks for the feedback.

Aw, I liked the purple header. :) I think the biggest issue is the giant purple splash. If we can lighten that area up, I think the purple header could work.

@omerbalyali Yes, that's what I was getting to. Text is more readable on white background. I don't really mind purple or blue (I'm not in love with the combination of two, I'd rather see a combination of cold and warm color, but that's a personal preference), but I think they should be used as accent colors. Our site is 98% text, and making it easy to read is a key, I think.
@nzakas I was talking about mono-spaced font in the header. I don't mind the font in the body.

@nzakas You mean the top bar or the jumbotron?
@ilyavolodin I agree using warm-cold color combination. I will use orange-red as secondary color.
The important thing about font is, fonts like DIN or Avenir are available in webfont through fonts.com and the service is surely expensive. (30$/m for 1m pageview and 140$/m for 5m pageview, billed once for 3 years. There are monthly and annually payment options and of course it's more.) So I think the best way is using Google Fonts, probably Roboto Sans. But I wanted to show you the DIN option first, I will upload the Roboto version. But this doesn't mean we can't use DIN as a main brand font of choice. I need your opinions on this matter.

@omerbalyali Just to clarify, when you are talking about main brand font, you are mostly talking about logo? The font used in the logo is a bit too heavy for my taste, I would rather see something lighter.

Possible free (and lesser known) alternatives to,
Avenir: https://www.google.com/fonts/specimen/Montserrat
DIN: https://github.com/larsenwork/Gidole
Design (including logo) looks great though!

@jacobp100 Gidole looks great, thanks!

Here's another that I think looks good, and uses some purple, too. :)
https://sumome.com/

And another: http://krakenjs.com/. I think this one does the upper-dark, bottom-light thing really well.

Not sure if this is still being worked on or not, but I'm happy to help with building this when we get closer to a finalized design. Liking the screenshots posted by @omerbalyali :D

Is this project still running? I'm a product designer and I'd love to help out!

@nogaraviv definitely still running and happy you're interested. It's been a while since we did any work surrounding this, what do you think would be the best way to proceed?

Want to hop on a call? We should talk about whether you just want a polished version of what currently exists, or add new content (and if so, what the content will be) as well as style preferences the team has (if any). Some of these things have already briefly been discussed, but since it's been a year there may be more changes, and it'll be good to talk them through.
Also, we should chat about creating some sort of styleguide to follow for future pages, blogs, etc to make it easy to generate assets and keep a consistent style. 👌
I come home from vacation Jan 2, and can talk anytime Jan 3-5 b/w 1-4pm PST.

I can try a short call to get this bootstrapped, I'll email you so we can set up a time.
We definitely want to add new content to the homepage to make it more useful. Right now it's a confusing jumping off point that doesn't provide a lot of useful information for new users.
A style guide would be awesome!

I can try a short call to get this bootstrapped, I'll email you so we can set up a time.
We definitely want to add new content to the homepage to make it more useful. Right now it's a confusing jumping off point that doesn't provide a lot of useful information for new users.
A style guide would be awesome!


Slack Dropzone Plugin

The Slack editor allows file drag and drop (see 1st image below). I have implemented something similar (see 2nd image below) using a combination of Dropzone and Attachments plugin.
Slack editor

My custom editor

The way my custom plugins work:

User drags a file
My Dropzone Plugin listens to drag events and creates a Dropzone Node where the file can be dropped
The Dropzone Node dispatches an INSERT_ATTACHMENT command
My Attachments plugin creates an attachments node when INSERT_ATTACHMENT is dispatched which shows the file previews (shown in the image). This node is appended as the very last child of the root node

Everything works great but this approach introduces behaviours that are unintended:

When a file is attached the placeholder isn't shown when the editor is empty since root has the Attachments node. The expected behaviour is for the placeholder to be shown but I haven't found a good way of achieving this. See image below for reference.
When user "selects all" (using cmd+a) and deletes the Attachments node is also deleted.

Essentially, what I want to achieve is for the Attachments node to be treated as separate from the root children. One approach is to extract the Dropzone functionality from the editor but ideally it is part of the editor state since the shared state simplifies managing the attached files.

When deleting the only paragraph the placeholder isn't shown as the root has the Attachments node. The user would expect a placeholder here though.

One approach is to extract the Dropzone functionality from the editor but ideally it is part of the editor state since the shared state simplifies managing the attached files.

I would advise you to do this outside of the editor if you don't care about the position of this attachment within a document. The tradeoffs of trying to shoehorn this into the editor state model are just not worth it (imo) if all you need is to attach some images to the document.

One approach is to extract the Dropzone functionality from the editor but ideally it is part of the editor state since the shared state simplifies managing the attached files.

I would advise you to do this outside of the editor if you don't care about the position of this attachment within a document. The tradeoffs of trying to shoehorn this into the editor state model are just not worth it (imo) if all you need is to attach some images to the document.

I ended up following your advise. I feel like it is a compromise to keep the Dropzone functionality non-integrated since I have to manage the state for file uploads separately from everything else. It works well though so I'm somewhat satisfied.
Here is what I ended up doing for anyone who wants to implement similar functionality:

A custom DropzonePlugin component that is responsible for: 1) drag / drop event handling; 2) Rendering a DropzoneArea UI; 3) Rendering thumbnail previews of uploaded images.
Object URLs for selected files are stored in Redux state. This allows me to append files from sources other than the Dropzone (e.g. FileUploadButton in the toolbar).

Would appreciate your feedback on this approach @acywatson - for myself and future readers


how to use vhost?

how to use my custom vhost? example hcareweb.dev
is this right?
lt --port 80 --local-host hcareweb.dev --subdomain hcareweb
it is redirecting to localhost im using nginx...

Same problem here

Same here

I think the problem is here https://github.com/localtunnel/localtunnel/blob/master/lib/HeaderHostTransformer.js#L27
The regex need to be case insensitive or 'Host' should be 'host'
I'll make a pull request if I get time.

@hartjo but the problem is not solved at all! why this issue is closed?

@vistiyos i solve the problem by editing the file HeaderHostTransformer.js direct from my composer files as @coldlamper  suggest temporary but it works thats why i close this issue im sorry not to inform you

@hartjo but it's not solved in the repository, so it shouldn't be closed until some PR solves this problem

@vistiyos if thats the case i will reopened it im sorry peace :+1:

fixed in master


Improve name replacement

Example:
func RemoveMe() {}
func RemoveMe2() {}

With genx -fn RemoveMe turns into :
func 2() {}

I've just built a tool to do such jobs with ease: https://github.com/zhiqiangxu/gg


adds .editorconfig file with rules for upsun yaml files

adds .editorconfig file with rules for yaml files in the .upsun directory.
Closes #219

it appears Upsun has a 28 character limit on branch names. when creating the PR, I let github generate the branch name for me which exceeded the 28 character length

https://github.com/platformsh/demo-project/pull/220#issuecomment-2007334390
Fixed in https://github.com/platformsh/demo-project/pull/236


run curls to uniprot in parallel

I was testing #555 and I had to wait too long for this last step. I used 10 processes for now, speed can still be increased in the future if required.
Original pull request by @ninewise on Thu Jan 28 2016 at 10:51.
Merged by @ninewise on Mon Feb 01 2016 at 14:17.

:+1: Looks good, can be merged after 3.1.1 is released.
Original comment by @bmesuere on Thu Jan 28 2016 at 15:47.

3.1.1 is out, you can merge this if you want.
Original comment by @bmesuere on Mon Feb 01 2016 at 13:44.


Wallet is not restoring, giving error - Exception from 'wallet' 'utf-8'

Please help else ill loose almost 150 SIT, i updated it to the latest version and then this started happening, last time also when i updated, i lost 40 SITs
Below are the details
(venv) XXX:~/silicoin$ sit farm summary
Farming status: Not synced or not connected to peers
Total silicoin farmed: 0.0
User transaction fees: 0.0
Block rewards: 0.0
Last height farmed: 0
Local Harvester
0 plots of size: 0.000 MiB
Plot count for all harvesters: 0
Total size of plots: 0.000 MiB
Staking addresses:
Estimated network space: 45.824 PiB
Expected time to win: Never (no plots)
Note: log into your key using 'sit wallet show' to see rewards for each key
(venv) XXX:~/silicoin$ sit wallet show
No online backup file found,
Press S to skip restore from backup
Press F to use your own backup file: F
Please provide the full path to your backup file: /home/mani/.silicoin/mainnet/wallet/db/blockchain_wallet_v1_testnet_395011195.sqlite
Exception from 'wallet' 'utf-8'

Have you tried to restore your wallet from height 0?

i am not sure, i updated silicoin with the bash curl command and this happened, please let me know how can i check the height of the wallet.

You can use "S" to skip restore from backup and re-sync your wallet from height 0.

I skipped and let it sync, it Synced for a while and got  coins in wallet and not its not  syncing. where is my 150 sits which i farmed?


Move comscan ops from routes up to galaxy, then pass groups down via props

Both routes and groups components need access to routes (possibly even activity). Should handle all state updates/mgmt up in galaxy, then trickle down groups data via props to child components.

Done


HLS search: sync action code and application code

Signed-off-by: Bruno Mesnet<EMAIL_ADDRESS>

You have always a " " space to many in your titles. So HLS search: and not HLS search : ...


Add watermark support

As requested in #64.

I don't see a unit test written for it. Can you please also add it so we ensure a bug free implementation?

@adityapatadia added =>

Sorry to ask you again but the test should ideally compare output by library with a reference test image. You can create watermarked image and then compare the image output by this library to the reference image. I know, some unit tests of library are not as rigorous but I will repair them when I get free.
Meanwhile, when we are adding new test I would like them to be good.

Ah, my bad. I thought you were just asking basic exists, doesn'tThrowAnyErrors -test. I'll add them when able =>

Can you fix the failing checks? I would marge after checks pass.

Apparently there's something going on with travis as these passed locally. Have to dig into

Hi, Can you resolve the issues?

Hi, I'm ont sure if I can alter the Travis-configuration. It passes on local though.

It's not travis config issue. The images are not matching.

Any update on this?


Skip subdirectory creation for invalid volume ID

The only reasonable way that the unpublish command can determine whether to keep or delete the subdirectory, if given, is to bake this information into the volume ID, as the original volume context is not passed to volume unpublish calls. For dynamically created volumes, this is always consistent. However, if the end user defines their own volumes, but does not follow the expected volume handle / volume ID form, that information is not available. In this instance, if the user sets the retain-sub-dir value on a manually created volume to 'false', we will error out and refuse to create the volume. If they request that the subdirectory be retained, we will treat the volume as we do a read-only volume, where we will attempt to mount the given subdirectory, but will not do any logic associated with creating or deleting that subdirectory. As with a read-only volume, if that subdirectory does not exist on the cluster, the mount will fail with a reasonable error.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
This PR is based on https://github.com/kubernetes-sigs/azurelustre-csi-driver/pull/155 and will be in draft until that is merged.
Release note:
none

@joe-atzinger Could you take a look at this PR? It's based on https://github.com/kubernetes-sigs/azurelustre-csi-driver/pull/155 so I'm leaving it a draft, but I'd like this to go in as soon as that's done


gusb: 0.3.7 -> 0.3.10

https://github.com/hughsie/libgusb/blob/0.3.10/NEWS#L1-L26

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 170928 run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.discover
libsForQt514.discover

1 package failed to build:

fprintd-tod

77 packages built:

adapta-gtk-theme
chrome-gnome-shell
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cinnamon-session
cinnamon.cinnamon-settings-daemon
colord
colord-gtk
colord-gtk4
darktable
diffoscope
eolie
fprintd
fwupd
gnome-firmware
gnome-multi-writer
gnome.gnome-color-manager
gnome.gnome-control-center
gnome.gnome-disk-utility
gnome.gnome-session
gnome.gnome-settings-daemon
gnome.gnome-settings-daemon338
gnome.gnome-shell
gnome.gnome-software
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.gpaste
gnome.mutter
gnome.mutter338
gnome.simple-scan
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.system-monitor
gusb
libfprint
libfprint-2-tod1-goodix
libfprint-2-tod1-vfs0090
libfprint-tod
libsForQt5.discover
monitor
pantheon.elementary-greeter
pantheon.elementary-gsettings-schemas
pantheon.elementary-session-settings
pantheon.gala
pantheon.switchboard-plug-a11y
pantheon.switchboard-plug-about
pantheon.switchboard-plug-bluetooth
pantheon.switchboard-plug-keyboard
pantheon.switchboard-plug-mouse-touchpad
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.switchboard-plug-security-privacy
pantheon.switchboard-with-plugs
pantheon.wingpanel
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-a11y
pantheon.wingpanel-indicator-bluetooth
pantheon.wingpanel-indicator-datetime
pantheon.wingpanel-indicator-keyboard
pantheon.wingpanel-indicator-network
pantheon.wingpanel-indicator-nightlight
pantheon.wingpanel-indicator-notifications
pantheon.wingpanel-indicator-power
pantheon.wingpanel-indicator-session
pantheon.wingpanel-indicator-sound
pantheon.wingpanel-with-indicators
phoc
phosh
vimix-gtk-themes
weston
westonLite
whitesur-gtk-theme
wingpanel-indicator-ayatana
xdg-desktop-portal-gtk
xiccd

fprintd-tod doesn't build on master either.