Add support for Docker

Add Dockerfile to facilitate running repomix using Docker.
Update README with instructions on how to run the cli using Docker.
Add github-actions workflow for Building, and Publishing the image to Github Container Registry (ghcr.io).

Image will be build on each PR.
Image will only be published when a branch is merged into main, and when a release is tagged.
The image can be tested once a branch is merged by using the ghcr.io/yamadashy/repomix:main tag
The workflow will create semver tags for the Docker image.

Fixes #221
@yamadashy You may have to tweak Package Settings to make the image public. https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility
As a separate PR, we could make this repo a Github Action that people can run on their repos to automatically generate the output using repomix.

I can probably add a stage that runs the image in the workflow to make sure it's working before pushing it to ghcr.io

Hi, @gaby !
Thank you so much for your implementation! I really appreciate your work on this, as I was hoping to make repomix runnable in Docker.
I've made a few adjustments, including tweaking the README and optimizing the image size.

I can probably add a stage that runs the image in the workflow to make sure it's working before pushing it to ghcr.io

That's a great idea! I'd really appreciate it if you could add a stage to the workflow to test the image before pushing it to ghcr.io. That would be a huge help in ensuring the quality of the image.

@yamadashy Instead of adding another stage. I'm running repomix --help at the end which confirms the cli is installed correctly.
See output here: https://github.com/gaby/repomix/actions/runs/12537229763/job/34961107768?pr=1

@gaby
Thank you for your work!
I've separated the operation check part into a separate RUN command since it's okay to split the layers.
I'll proceed with merging this PR. If any additional adjustments are needed, I might reach out to you again, and I appreciate your help in advance.
Thanks again for your work on this!

@yamadashy Sounds good to me, once merge the docker push may fail depending on your settings for Packages, if it does check https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility and then replay the stage.

@yamadashy Add this to the workflow between line 19-21:
permissions:
  contents: read
  packages: write

@gaby
Thank you! I've adjusted the repository settings, but it seems clearer and less risky to define the permissions in the workflow YAML files directly, so I'll go with that approach.

I see the image was posted!
https://github.com/yamadashy/repomix/pkgs/container/repomix

New workflow worked, image was also pushed.

I'll try releasing a version now.


run photutils psf-fitting or aperture photometry on Gaia Stars (for zpt measurement)

Completed during Sprint 1 :  see the PSF model construction example on readthedocs
See do_stellar_photometry in the FitsImage class in fakeplanting.py

Completed during Sprint 1 :  see the PSF model construction example on readthedocs
See do_stellar_photometry in the FitsImage class in fakeplanting.py


Updated published date

Fix https://github.com/google/WebFundamentals/pull/5317#discussion_r153757304

Whoops!
There were 4 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/fundamentals/performance/optimizing-content-efficiency/automating-image-optimization/index.md - No wf_blink_components attribute found. Add if appropriate.
src/content/en/fundamentals/performance/optimizing-content-efficiency/automating-image-optimization/index.md#L453 - Line must be at most 100 characters
src/content/en/fundamentals/performance/optimizing-content-efficiency/automating-image-optimization/index.md#L1635 - Line must be at most 100 characters
src/content/en/fundamentals/performance/optimizing-content-efficiency/automating-image-optimization/index.md#L2026 - Line must be at most 100 characters


Pencil decomposition for the TripolarGrid

This PR introduces pencil decomposition (in x and y) for the tripolar grid, contingent on having a even number of processors in the x-direction.
I need to add a couple of tests (or at least figure out how to test this) before merging

Apparently, using MPI in GitHub actions is trivial, we just need to launch the example with mpiexec(cmd -> ...)


[Drivers] No data point in dashboard with driver 440.33

OpenPAI Environment*:

OpenPAI version: v0.14.0
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): ubuntu16.04
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

I build the driver of 440.33 version based on the driver dockerfile in src/driver/build. But there's no data point for GPU memory or GPU Utilization after upgrading. The logs in job-exporter show as follows:

How to fix this? thanks.

@edenbuaa, Please make sure the driver installed in /var/drivers/nvidia/current  folder. And you can run nvidia-smi after set correct PATH and LD_LIBRARY_PATH env.

@Binyang2014 How to check where the driver installed?

@edenbuaa If you use drivers-one-shot to install driver, the driver will be installed into host. Please go to your worker node and check if /var/drivers/nvidia/current exist. And the nvdia-smi inside it is valid

thanks @Binyang2014 . The  /var/drivers/nvidia/current folder exist in work node. when I execute nvidia-smi , It report the following message:
NVIDIA-SMI couldn't find libnvidia-ml.so library in your system. Please make sure that the NVIDIA Display Driver is properly installed and present in your system.
Please also try adding directory that contains libnvidia-ml.so to your system PATH

I found two 'libnvidia-ml.so' in system:
/var/drivers/nvidia/440.33.01/lib/libnvidia-ml.so
/var/drivers/nvidia/440.33.01/lib64/libnvidia-ml.so
and the PATH doesn't contains the two of them. what we should do next?

Hi @edenbuaa libnvidia-ml.so  should under /var/drivers/nvidia/current/lib and /var/drivers/nvidia/current/lib64. Can you confirm the file exist under these paths? And please make sure following command is work. Otherwise, it's driver install issue.
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/var/drivers/nvidia/current/lib64:/var/drivers/nvidia/current/lib
/var/drivers/nvidia/current/bin/nvidia-smi

@Binyang2014 yes, you are right.
Another error report after export LD_LIBRARY_PATH in job-exporter:

Hi @edenbuaa. After you make sure the /var/drivers/nvidia/current/ point to the correct driver in your worker node. You can restart the job-exporter in the dev-box by running:
python paictl.py service stop -n job-exporter
python paictl.py service start -n job-exporter

It works! thanks @Binyang2014


SummernoteModelAdmin adding a required File field.

When I add the SummernoteModelAdmin to my model it is adding a required 'File' field at the bottom of the admin page. Am I doing something wrong?
Without SummernoteModel Admin:

With SummernoteModelAdmin:

Here is my admin.py:
from django.contrib import admin
from django_summernote.admin import SummernoteModelAdmin
from . import models

class RecipientModelAdmin(SummernoteModelAdmin):
    summernote_fields = ('text',)

admin.site.register(models.Sponsor)
admin.site.register(models.Recipient, RecipientModelAdmin)

And here is my model:
class Recipient(models.Model):
    name = models.CharField(max_length=255)
    image = models.ImageField(upload_to='recipients/')
    text = models.TextField()

    def __str__(self):
        return self.name

Thank you for reporting. I'll check it.

I saw that there is a solution for this in gihub, already. Thank you for that!
Will there be a new version in pypl with that bugfix?

HOTFIX just uploaded. Sorry about that.
https://github.com/summernote/django-summernote/releases/tag/<IP_ADDRESS>


docs: report on storage changes and decisions.

Rendered
Closes #1044

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[ ] Title follows the Conventional Commits spec

I wonder whether in the report we can include a link to the  branch that does migration from v1 to v2 to incentivise users to use it: https://github.com/cometbft/cometbft/blob/migrate_db/cmd/cometbft/commands/migrate_db.go . I am not sure it should be merged into main though.

I wonder whether in the report we can include a link to the branch that does migration from v1 to v2 to incentivise users to use it: https://github.com/cometbft/cometbft/blob/migrate_db/cmd/cometbft/commands/migrate_db.go

I think it should be in the experimental_key_layout docs.

Two more things:

we should say which exact version of Comet did we use (except for Injective results) to get these results. It's v1-alpha.1 or something from main ?
we should add a mention to docs/references/README.md about this new file we're introducing. I did that in 20ec389 hope it's ok.

Two more things:

we should say which exact version of Comet did we use (except for Injective results) to get these results. It's v1-alpha.1 or something from main ?

Done


Questions

Added questions to array w/in index.js to prompt user input

push from branch generate-markdown accidentally combined with pull request for questions branch


⚠ Shadow Does Streams has degraded performance

In 5948501, Shadow Does Streams (https://stream.everythingbagel.me) experienced degraded performance:

HTTP code: 200
Response time: 5950 ms

Resolved: Shadow Does Streams performance has improved in ee74ae9 after 4 minutes.


Add dry-validation as validation layer in forms to separate validation logic from scopes/relation logic in models

nope


Option to disable aliased JS/TS destructured property renaming

As per the version 1.30 release notes:

Renames handle JS/TS destructuring properly
Renames now handle JavaScript and TypeScript destructuring and will introduce an alias if needed

This means that renaming a property will result in the property being aliased by it's old name wherever destructuring assignment has been used. For example:
// before rename
const x = {
    y: 'value'
}
const { y } = x;
console.log(y);

// after rename
const x = {
    z: 'value'
}
const { z: y } = x;
console.log(y);

Previously, the destructed parameter's name would be updated, as well as all of its usages:
// before rename
const x = {
    y: 'value'
}
const { y } = x;
console.log(y);

// after rename
const x = {
    z: 'value'
}
const { z } = x;
console.log(z);

Can you please make this new behaviour optional?

Related: #29026 and possibly #28679

Where I keep running into it is with declaring React Component Props interfaces.
If I rename the variable in the interface, it's usually because I have thought of a more descriptive/better name for it. In that case, I absolutely do want the uses of that prop inside the component to also be updated to the new name, and for external items to pass the data to that component under the new name, as it better documents what the data should be. Right now it's greatly slowing me down any time I try to update the props for a component that I'm still actively developing/getting feedback on/etc.
I'm really glad to see that a per-user setting is being implemented, as I came here today specifically to look at how to turn the behaviour off (after trying it for several weeks and getting more and more frustrated).
I can understand the reasoning behind the change. However in practice over the time I've been using this I haven't come across a single case where this behaviour was actually desired/welcome. I have come across multiple cases on a daily basis where this behaviour was the opposite of what was desired (i.e. the old behaviour was what was needed).

See above comments / linked issues

Is it released already?

@pie6k don't think so, still on 1.29.1 personally.

@jasongerbes

Can you please make this new behaviour optional?

👍  and disabled by default because it's not a meaningful default in many people views. (Yes, I read Ryan's explanation on safety of the current default approach, but I'm still not convinced that safety overweights the pain it comes with. Especially if we think about the likelyhood of the issue caused by an unsafe rename).

@another-guy https://github.com/Microsoft/TypeScript/pull/29593 - this PR was already linked above.

A per-user setting is being implemented at #29593

This is now available in VS Code, thanks to https://github.com/microsoft/vscode/issues/68029.
{
  "javascript.preferences.renameShorthandProperties": false,
  "typescript.preferences.renameShorthandProperties": false
}

@OliverJAsh worth noting that changing that setting will also add aliases to export and import specifiers—it changes more behaviour than it says.

@dsherret Do you mean that will happen if you keep the setting enabled?
Sometimes I want aliasing, sometimes I don't (e.g. imports), so I opened a new issue to suggest that we allow users to control what happens at the time they actually perform the rename: https://github.com/microsoft/vscode/issues/93501

I think this is now called
{
  "javascript.preferences.useAliasesForRenames": false,
  "typescript.preferences.useAliasesForRenames": false
}


preserveWatchOutput: true doesn't work anymore in 3.0.0-rc

Just testing the RC on https://github.com/xtermjs/xterm.js, it has a watch task (yarn watch) which uses concurrently to fire off several tsc tasks, all of which use "preserveWatchOutput": true. With the RC the setting is being ignored and the terminal clearing is happening again.
This is what I see in my terminal after doing the build, notice it's only showing the last start watch at the top of the buffer:

Thanks @sheetalkamat!


prefer_if_null_operators refactoring introduces runtime error

Describe the issue
The refactoring suggested by prefer_if_null_operators might introduce runtime errors.
To Reproduce
Given the Code
bool multiline = true;
int maxLines = 10

int lines = maxLines != null ? maxLines : multiline ? 5 : 1;

The linter will suggest to convert it to
int lines = maxLines ?? multiline ? 5 : 1;

At runtime this will result in type 'int' is not a subtype of type 'bool' error.
Expected behavior
int lines = maxLines ?? (multiline ? 5 : 1);

Thanks for the report @grundid!  I've transferred the issue to the SDK (since that's where quick-fix implementations live).

https://dart-review.googlesource.com/c/sdk/+/239066


Migrating to shared service tests

@ekryski I think your initial $not implementation was correct. There seems to be a difference between MongoDB and NeDB.


Add rubocop gem and config

add rubocop gem to the development dependencies
add default configuration (auto-generated) to keep track of the offences

Please, comment below if you want to add specific style preferences such as line length, method length, etc. After, that we can gradually fix the offences.
Resolves https://github.com/cucumber/cucumber-ruby/issues/1014

it does not look like rubocop runs on travis, I think it should, and also fail the build if there are regressions.
this would mean the rubocop_todo file will need to be updated quite often for PR to be merged.
the alternative, is a dormant rubocop_todo file that will be updated on a voluntary basis.

@mathieujobin I agree I think we should add rubocop to Travis eventually. I didn't add it yet because I think we should agree on some style guidelines. Moreover, there are still some offences not captured by .rubocop_todo.yml and therefore the build will fail at the moment.
My plan is the following:

Get this PR merged with a sensible configuration for rubocop
Fix the remaining offences and add it to Travis
Open a issue labelled "Easy" to fix the remaining offences and gradually empty the .rubocop_todo.yml.

What do you think?

@nodo How do you mean that #1014 is related? If you mean the #1014 can be closed when this PR is merged, then that should be phrased in the description with a keyword for closing issues (for instance "closes #1014"), then Github will do that automatically.

Thanks for the hint @brasmusson  I didn't know that. I have changed the commit message and title of the PR accordingly.

@nodo Unfortunately you edited the PR title, which actually is the least useful place to refer to other issues. In a PR title a issue reference will neither be a clickable link nor will it help with the closing of issues automatically. In the PR description (the top comment, which in the RP end with "Related issues: ...") issue references (with the closing keyword) will be both clickable links and will help the the closing of issues automatically (and in RP comments issue references will be clikcable links, but will never help with the closing of issues).

@brasmusson Thanks for the clarification. I have reverted the title change. However, I did change also the commit message which AFAIU will close automatically the issue. Am I wrong?

Great idea! @nodo could you add something to contributing.md that points people to the TODO file? There's bound to be loads of low-hanging fruit in there for beginners to get stuck in to.

And yes, the issue was automatically closed :0


Implement Html5 safelist

As mentioned in #1767, I think it necessary to add safelist for HTML5 tags.
Now only some tags useful for myself and those mentioned in that issue are implemented in this PR. Please point out more and I will add them.

Could you add the "" tag? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strike


Add support for socket timeouts and some refactoring

This adds supports for authentication timeouts with sockets and moves the non-class bound utility methods into its own library. Closes #19

:shipit:

:shipit:
Good call on the timeouts


Fix to witcher 3 new patch launcher ( only for windows )

The new witcher 3 update add a launcher that broke the old script, I added a loop to wait for the game exe to start and a loop to wait for the game exe to end. I added a new variable GAMEEXE , if left empty the old script logic is used.

I'm not very familiar with Windows/batch/etc and this adds a lot more logic to the script so I don't want to blindly merge it. I don't have this game to test it myself so I hope someone else can review/test this and confirm it works then I'll merge it.

I tested this and it seems to work for Witcher 3.
Do we know if a Linux version isn't needed? Or was it just not added to this PR?


Implement some granular logic to --cache

Allow multiple package specifications for --unused and --cache
Allow --all  for --unused and --cache  [--cache with no parameters defaults to --all]
Allow both --unused and --cache to be specified together (with a package ilst or --all)

Initial PR tests expected to fail with new parameters for clean.  Additional testing added via metaport PR

@IgorTodorovskiIBM  Implemented a --metadata cleanup switch.  Note tests will fail again until corresponding PR in metaport is merged

Tests now passing after metaport PR merged


$scope is used too much in mainController

Currently mainController.js is a big file with lot of business logic and functionality defined in $scope.
From what I learned so far it's better to use controllerAs syntax and reduce the use of $scope. Also business logic should reside in controller.
I think this is a good time to refactor mainController.js to make the codebase better

Do you mean something like this?
`
{{ main.title }}
`
And also, I would suggest using 'this' instead of binding everything to scope all the time.
app.controller('MainCtrl', function () {   this.title = 'Some title'; });
What do you guys think? @Roshanjossey , @glauberramos

@alanjsph, Yes. Did you get it from here ?
I was thinking about extracting directives and controllers out to different files.
Just keeping view in directives and put business logic in controllers.

@Roshanjossey , No I didnt get it from there.
But aren't the directives already in different files? Correct me if I'm wrong.

Yes directives are in multiple files. It'd be good to split controllers too.
I don't really know how it should end up. There are functions to be used by different directives.

ok, @Roshanjossey Let me have a try


refactor: enrich schemas with scoping resource for SAC checks

Description
This PR enriches the datastore schemas with SAC resources or SAC permission checker in order to later be able to move the SAC checks deeper in the code framework.
PR stack:
+- #7466
| +- #7475
| | +- #7479
| | | +- #7480
| | | | +- #7494
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

QQ:  Is it safe to assume we are targeting 4.3 with code cutoff for 4.2 only 2 days away?

QQ: Is it safe to assume we are targeting 4.3 with code cutoff for 4.2 only 2 days away?
The target here is 4.3 . There is no need to rush things for 4.2 cutoff. I'll hold the changes until after the cutoff.


Disable/Remove LGTM.Com Code Analysis from Github

COdeQL has been set up to run code Analysis on any PR merging to Master. LGTM is approaching End of Life. New commits will no longer be analyzed by the end of Nov 2022.

Need Repo ownership previleges to be able to remove lgtm
Steps: https://docs.github.com/en/developers/apps/managing-github-apps/deleting-a-github-app


SSDT-SMBU  Thinkpad_Clickpad Do you need to delete

I am also t450s, and I am also using i3p9 efi. In order to ensure a smoother touchpad, use VoodooRMI.kext to drive it. SMBU and Thinkpad_Clickpad are not loaded in acpi. Now it seems that it is possible to delete both of them?
And ehc is not blocked in acpi, so ehc information can be seen in hackintool--usb info, can ehc be blocked in acpi?

Also, my sd card is not driven. I don’t know why?

I am also t450s, and I am also using i3p9 efi. In order to ensure a smoother touchpad, use VoodooRMI.kext to drive it. SMBU and Thinkpad_Clickpad are not loaded in acpi. Now it seems that it is possible to delete both of them?
And ehc is not blocked in acpi, so ehc information can be seen in hackintool--usb info, can ehc be blocked in acpi?

Also, my sd card is not driven. I don’t know why?

Yes, SMBU and Clickpad patches need to be deleted as they are not working in recent macOS builds. I have already fixed this but haven't committed the changes yet

EHC1 needs to be changed to EH01 in config.plist (I've already done this too but haven't updated the changes yet)

SD card stopped working in the past few updates. I haven't tried to fix it because i don't use it. Also it has a tendency of always staying on even when not in use so i completely disabled it too.

I've done some changes to this EFI but haven't gotten around to committing it yet. I'm also planning on updating to OC 0.6.3 for good Big Sur compatibility on Thursday. I may upload the changes today or tomorrow. I've cleaned up the EFI a lot. Updates comong soon

I am also t450s, and I am also using i3p9 efi. In order to ensure a smoother touchpad, use VoodooRMI.kext to drive it. SMBU and Thinkpad_Clickpad are not loaded in acpi. Now it seems that it is possible to delete both of them?
And ehc is not blocked in acpi, so ehc information can be seen in hackintool--usb info, can ehc be blocked in acpi?

Also, my sd card is not driven. I don’t know why?

I've updated the EFI with OC 0.6.3, deleted the unused SSDTs and patched the EHC1 to EH01. Hackintool still shows EHC1 but if you run ioreg -l -p IOService -w0 | grep -I EHC1 it should return blank as stated here: https://dortania.github.io/OpenCore-Post-Install/usb/system-preparation.html#checking-what-renames-you-need

Thank you very much, you are keeping up to date and fix. These questions are too difficult for me, especially the ssdt in acpi is incomprehensible to me.
I saw that the author of the same model t450 (i7-5600u/hd5500/alc 292) updated his efi，In his config, the network card, sound card, graphics card, usb, etc. are injected, and then there are only a few ssdt in apci.
https://github.com/CLAY-BIOS/Lenovo-ThinkPad-T450s-Big-Sur-OpenCore
Is there any merit in his approach?

Thank you very much, you are keeping up to date and fix. These questions are too difficult for me, especially the ssdt in acpi is incomprehensible to me.
I saw that the author of the same model t450 (i7-5600u/hd5500/alc 292) updated his efi，In his config, the network card, sound card, graphics card, usb, etc. are injected, and then there are only a few ssdt in apci.
https://github.com/CLAY-BIOS/Lenovo-ThinkPad-T450s-Big-Sur-OpenCore
Is there any merit in his approach?

If it works for you then it's ok. I have left most of acpi files because they ensure Maximum compatibility throughout all the T450/T450s models. Also i don't think he has taken into account those with Nvidia GPU and those with dual batteries.
The EFI i use right now is the most stable I've used to this day. The laptop never crashes or fail to wake even after 2 days in sleep (which is honestly more stable than my 2011 MacBook Pro). I can go a whole week without shutting down the laptop (just using sleep) and everything will be fine.
I'll continue cleaning up the ACPI looking for things that aren't necessary.
Also his EFI has way to many drivers under OC/Drivers

Thank you very much, you are keeping up to date and fix. These questions are too difficult for me, especially the ssdt in acpi is incomprehensible to me.
I saw that the author of the same model t450 (i7-5600u/hd5500/alc 292) updated his efi，In his config, the network card, sound card, graphics card, usb, etc. are injected, and then there are only a few ssdt in apci.
https://github.com/CLAY-BIOS/Lenovo-ThinkPad-T450s-Big-Sur-OpenCore
Is there any merit in his approach?

So I've looked at his files properly and it looks like he combined most of the SSDTs into a single one.

Yes, I use this EFI now, it is the most stable, what is normal, very suitable for me, perfect EFI and DW1820A is also very stable, no problems
I heard that the SSDT of each machine is different, even if the configuration of the same machine is different, it will cause acPI changes, I wonder if this statement is correct

I can't do SSDT, I have an idea
Use clover to extract dsdt, open dsdt and open the patch file under apci at the same time, and search for keywords in the patch file in dsdt. If it matches, is it suitable for me?

Yes, I use this EFI now, it is the most stable, what is normal, very suitable for me, perfect EFI and DW1820A is also very stable, no problems
I heard that the SSDT of each machine is different, even if the configuration of the same machine is different, it will cause acPI changes, I wonder if this statement is correct

The statement is true but not for the T450s and T450. They all share the same motherboard with the same chipsets and everything. The only difference is that some models use Elan Trackpad instead of Synaptics.
There's also T450/T450s with 4th gen CPUs (Haswell) instead of 5th gen (Broadwell). The 4th gen models are completely incompatible with this EFI

I can't do SSDT, I have an idea
Use clover to extract dsdt, open dsdt and open the patch file under apci at the same time, and search for keywords in the patch file in dsdt. If it matches, is it suitable for me?

You don't have to do that. T450 &T450S all have the same SSDTs because they don't variations in their BIOS and chipsets. They are all the same except for the 4th gen Haswell models

ok, I am modifying the configuration file and replacing the wireless network card driver. I am using dw1820a, and I am removing the intel network card driver.

After replacing the efi, it feels smoother than before, or is it a problem?
My dw1820a has neither AddProperties nor aspm. It is driven directly. Do I still need to add aspm?
Is your 1820a driven like this? Mine is cn-0vw3t3

After replacing the efi, it feels smoother than before, or is it a problem?
My dw1820a has neither AddProperties nor aspm. It is driven directly. Do I still need to add aspm?
Is your 1820a driven like this? Mine is cn-0vw3t3

Removing the the intel kext will improve boot times as I've stated in the guide. By default my EFI loads the Intel kext because most people have that. But if you replaced the card you should disable it.
Also what do mean by "replacing efi"? Did you use a different efi folder??

Change the driver of wireless network card in config file

Now it seems that there are some problems with sleep, related to usb?

Change the driver of wireless network card in config file

Now it seems that there are some problems with sleep, related to usb?

Do you have a network device connected to your usb ports? Like wifi, bt or ethernet adapter?
Did you turn off "wake on lan" in bios and "wake for network access" in system pref -> Energy?

Change the driver of wireless network card in config file

Now it seems that there are some problems with sleep, related to usb?

Also did you remove any files from ACPI or disabled them in config.plist??
Note that SSDT-PTSWAK, PWRB, ETX3-LedReset and EXT4-WakeScreen are essential for proper sleep and wake. Do not remove or disable them. All the SSDTs that i left in ACPI are important. I've already removed the less important ones.

I haven't changed the settings in acpi. Wake-on-LAN is turned off in the preferences. At the same time, may I turn it off in bios?
I will try to wake up and turn off the bios now, Because we are using a wireless network, the wired network card is not connected to the network cable,The Bluetooth of the wireless network card dw1820a needs usb.

I haven't changed the settings in acpi. Wake-on-LAN is turned off in the preferences. At the same time, may I turn it off in bios?
I will try to wake up and turn off the bios now, Because we are using a wireless network, the wired network card is not connected to the network cable,The Bluetooth of the wireless network card dw1820a needs usb.

Disable wake on lan in bios too. It usually forces the laptop to wake from sleep

Thank you very much for your help. I found that the inability to sleep is related to usb, so I re-customized usb, and found the instructions about usb in the opencore documentation. oc does not recommend using ssdt to customize usb. I disable ssd-xhc and use hackintool Customize the usb and put the exported usbport in the kext directory, and load it in the config.plist at the same time, now the sleep is successful.
When I was customizing the USB, I found that there was a problem with the USB port close to the power supply. Inserting a USB3.0 device can only be powered on without displaying the device. This is also the case when switching to Windows. This port is customized to a USB2.0 port.

Thank you very much for your help. I found that the inability to sleep is related to usb, so I re-customized usb, and found the instructions about usb in the opencore documentation. oc does not recommend using ssdt to customize usb. I disable ssd-xhc and use hackintool Customize the usb and put the exported usbport in the kext directory, and load it in the config.plist at the same time, now the sleep is successful.
When I was customizing the USB, I found that there was a problem with the USB port close to the power supply. Inserting a USB3.0 device can only be powered on without displaying the device. This is also the case when switching to Windows. This port is customized to a USB2.0 port.

Ok, I'll remap the ports and see how it goes.
Also the usb port near the power port seems to be working on usb 3 just fine for me

Thank you very much for your help. I found that the inability to sleep is related to usb, so I re-customized usb, and found the instructions about usb in the opencore documentation. oc does not recommend using ssdt to customize usb. I disable ssd-xhc and use hackintool Customize the usb and put the exported usbport in the kext directory, and load it in the config.plist at the same time, now the sleep is successful.
When I was customizing the USB, I found that there was a problem with the USB port close to the power supply. Inserting a USB3.0 device can only be powered on without displaying the device. This is also the case when switching to Windows. This port is customized to a USB2.0 port.

Also ACPI implementation is the best solution

Thank you very much for your help. I found that the inability to sleep is related to usb, so I re-customized usb, and found the instructions about usb in the opencore documentation. oc does not recommend using ssdt to customize usb. I disable ssd-xhc and use hackintool Customize the usb and put the exported usbport in the kext directory, and load it in the config.plist at the same time, now the sleep is successful.
When I was customizing the USB, I found that there was a problem with the USB port close to the power supply. Inserting a USB3.0 device can only be powered on without displaying the device. This is also the case when switching to Windows. This port is customized to a USB2.0 port.

My ports are basically mapped like yours. But with the extra SSP2 device at the bottom which I suspect is used for USB3 on the port near the power port. Since that port is the 3rd one in the mapping list.

Yes, the USBs near the power port are HSP2 and SSP2. Since my interface does not recognize 3.0 devices, I deleted SSP2.
I put the machine to sleep last night. I just woken up and checked the log. I was woken up almost every hour, but my breathing light flickered normally and the screen didn’t light up.
I don’t know if it’s not normal sleep.
-----log-----
log show --last 16h | grep "Wake reason"
2020-11-18 17:33:31.112170+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 17:33:31.112172+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449884+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449887+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179268+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179270+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937842+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937844+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679418+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679420+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931855+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931857+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367295+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367297+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056242+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056244+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877087+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877089+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909937+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909939+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 03:27:27.295898+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)

Yes, the USBs near the power port are HSP2 and SSP2. Since my interface does not recognize 3.0 devices, I deleted SSP2.
I put the machine to sleep last night. I just woken up and checked the log. I was woken up almost every hour, but my breathing light flickered normally and the screen didn’t light up.
I don’t know if it’s not normal sleep.
-----log-----
log show --last 16h | grep "Wake reason"
2020-11-18 17:33:31.112170+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 17:33:31.112172+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449884+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449887+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179268+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179270+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937842+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937844+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679418+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679420+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931855+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931857+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367295+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367297+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056242+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056244+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877087+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877089+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909937+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909939+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 03:27:27.295898+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)

First disable hibernation completely. It messes with sleep.
Second, i think your Bluetooth on the DW1820 card is causing that. That's the only network related thing that uses your USB (XHCI) interface

How to tdisable hibernation? Do this: sudo pmset -a hibernatemode 0
The only possible problem is the Bluetooth of the DW1820A, because it uses usb, but the usb has been customized, so it should have nothing to do with it.

Yes, the USBs near the power port are HSP2 and SSP2. Since my interface does not recognize 3.0 devices, I deleted SSP2.
I put the machine to sleep last night. I just woken up and checked the log. I was woken up almost every hour, but my breathing light flickered normally and the screen didn’t light up.
I don’t know if it’s not normal sleep.
-----log-----
log show --last 16h | grep "Wake reason"
2020-11-18 17:33:31.112170+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 17:33:31.112172+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449884+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449887+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179268+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179270+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937842+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937844+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679418+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679420+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931855+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931857+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367295+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367297+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056242+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056244+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877087+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877089+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909937+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909939+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 03:27:27.295898+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)

First disable hibernation completely. It messes with sleep.
Second, i think your Bluetooth on the DW1820 card is causing that. That's the only network related thing that uses your USB (XHCI) interface

Your idea is correct. I conducted a test this morning: disable the wireless network card in the BIOS, and do not load the network card and Bluetooth drivers in the config file. I sleep from 9:00 am until 12:30 and I wake it up. No wakeup record was found in the log.
However, I did not disable Bluetooth in the BIOS. It is estimated that it has something to do with the wireless network card. During this period, the battery power is almost not consumed. When you start to sleep, the power is 100% and when you wake up, it is 99%.
Seeing you update Big Sur, is it running smoothly? I have also been notified of the upgrade, but I have not upgraded it yet.

Seeing you update Big Sur, is it running smoothly? I have also been notified of the upgrade, but I have not upgraded it yet

Performance is about the same as Catalina for me but no as good as Mojave on the animations

Yes, the USBs near the power port are HSP2 and SSP2. Since my interface does not recognize 3.0 devices, I deleted SSP2.
I put the machine to sleep last night. I just woken up and checked the log. I was woken up almost every hour, but my breathing light flickered normally and the screen didn’t light up.
I don’t know if it’s not normal sleep.
-----log-----
log show --last 16h | grep "Wake reason"
2020-11-18 17:33:31.112170+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 17:33:31.112172+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449884+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 18:24:32.449887+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179268+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 19:31:07.179270+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937842+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 20:25:53.937844+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679418+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 21:29:01.679420+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931855+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 22:34:21.931857+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367295+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-18 23:27:55.367297+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056242+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 00:25:24.056244+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877087+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 01:33:30.877089+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909937+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 02:25:04.909939+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)
2020-11-19 03:27:27.295898+0800 0x74       Default     0x0                  0      0    kernel: (AppleACPIPlatform) AppleACPIPlatformPower Wake reason: RTC0 IGBE XHCI (Network)

First disable hibernation completely. It messes with sleep.
Second, i think your Bluetooth on the DW1820 card is causing that. That's the only network related thing that uses your USB (XHCI) interface

Your idea is correct. I conducted a test this morning: disable the wireless network card in the BIOS, and do not load the network card and Bluetooth drivers in the config file. I sleep from 9:00 am until 12:00 and I wake it up. No wakeup record was found in the log.
after that, I enabled the wireless network card and found that there were wakeup logs again.
However, I did not disable Bluetooth in the BIOS. It is estimated that it has something to do with the wireless network card. During this period, the battery power is almost not consumed. When you start to sleep, the power is 100% and when you wake up, it is 99%.

Some of the variants of the DW1820A are known to cause issues with sleep. That's why its recommended to use a real Apple Airport card with an adapter so it works perfectly out of the box.

I think I have found a way to solve the sleep wake-up record in the log. It should be a problem with my wireless network card driver.
The previous driver method loaded the driver in config without injecting it, and the wireless network card and Bluetooth worked normally.
Yesterday I changed a driving method, injected DevicePropertites and added pci-aspm-default=0
as follows:

built-in
AQ==
AAPL,slot-name
WLAN
compatible
pci14e4,4331
device_type
Airport Extreme
model
DW1820A (BCM4350) 802.11ac Wireless
name
Airport
pci-aspm-default
0

Through the 12-hour sleep test, there is no wake-up record in the log. I think I solved this problem.
daideMacBook:~ dai$   show --last 12h | grep "Wake reason"
daideMacBook:~ dai$

Merry Christmas


add VirtualMachineInstanceView.statuses property

add the missing VirtualMachineInstanceView.statuses property

Thank you for your return!
As you may have seen, this part of the code is auto-generated. I checked the initial generator configuration file and the correction was made inside, so it's just because we didn't re-generate this file after the spec fix.
In addition, please note that the current ARM API you are using is in preview mode and should change when we will release the final version. I double-checked and the current work-in-progress version has the statuses property.
I merge your pull-request because at short term it's faster than re-generate the file.
Thank you again!


Please document the purpose of each exposed port

https://github.com/GoogleCloudPlatform/opentelemetry-collector-builder-sample/blob/6e32e88a8846c15feeefbbac932f690430f42b55/Dockerfile#L22

I actually got these from the friction log, so we should look more at them (and maybe allow them to be customized?)
4317 - default otlp receiver
55678 - opencensus receiver
55679 - zpages

Can we add this info to the Dockerfile as a comment? I'm not sure if offering customization is worthwhile.


Ignore "API not enabled" errors when listing results.

If the API isn't enabled, then there are no resources of the given type, so
we don't need to surface it as a generic 403 error.
Also updates compute API client to use the same paged-result builder
as _base_client.
Helps with one common case of #311.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Module oracle_sqldba with catcon_pl in an Python 3.6 environment.

Hi,
i seems module oracle_sqldba got a bug, when it is used with catcon_pl in an Python 3.6 environment.
Ist there a required Python3 Version?
One sample Task that will raise the error:
  - name: utltz_upg_check.sql - CDB/SingleInstance     opitzconsulting.ansible_oracle.oracle_sqldba:       catcon_pl: "{{ ora_home.home_path }}/rdbms/admin/utltz_upg_check.sql"       scope: cdb       oracle_home: "{{ ora_home.home_path }}"       oracle_db_name: "{{ ora_instance.SID }}"
We got the following error
TASK [oracle_db_timezone_upgrade : utltz_upg_check.sql - CDB/SingleInstance] ********************************************************************************************** task path: /home/oracle/database_ansible/roles/oracle_db_timezone_upgrade/tasks/timezone_upg.yml:68 The full traceback is: Traceback (most recent call last):   File "/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba", line 107, in <module>     _ansiballz_main()   File "/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba", line 99, in _ansiballz_main     invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)   File "/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba", line 48, in invoke_module     run_name='__main__', alter_sys=True)   File "/usr/lib64/python3.6/runpy.py", line 205, in run_module     return _run_module_code(code, init_globals, run_name, mod_spec)   File "/usr/lib64/python3.6/runpy.py", line 96, in _run_module_code     mod_name, mod_spec, pkg_name, script_name)   File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py", line 445, in <module>   File "/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py", line 432, in main   File "/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py", line 337, in run_catcon_pl TypeError: must be str, not bytes fatal: [somehostname.domain.com]: FAILED! => {     "changed": false,     "module_stderr": "Shared connection to somehostname.domain.com closed.\r\n",     "module_stdout": "Traceback (most recent call last):\r\n  File \"/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba\", line 107, in <module>\r\n    _ansiballz_main()\r\n  File \"/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba\", line 99, in _ansiballz_main\r\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n  File \"/var/tmp/ansible-tmp-1678178858.8904803-2370422-47530891410840/AnsiballZ_oracle_sqldba\", line 48, in invoke_module\r\n    run_name='__main__', alter_sys=True)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 205, in run_module\r\n    return _run_module_code(code, init_globals, run_name, mod_spec)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 96, in _run_module_code\r\n    mod_name, mod_spec, pkg_name, script_name)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 85, in _run_code\r\n    exec(code, run_globals)\r\n  File \"/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py\", line 445, in <module>\r\n  File \"/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py\", line 432, in main\r\n  File \"/tmp/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload_2dg3i_yg/ansible_opitzconsulting.ansible_oracle.oracle_sqldba_payload.zip/ansible/modules/opitzconsulting/ansible_oracle/oracle_sqldba.py\", line 337, in run_catcon_pl\r\nTypeError: must be str, not bytes\r\n",     "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",     "rc": 1 }
When we adjust the code of module oracle_sqldba a bit it worked in our environment (see attached).
We added some decode/encoding stuff.
oracle_sqldba.zip

What OS + Version are you using?

RHEL8 + ansible [core 2.13.3]

Looks like a known bug in ansible-oracle-modules when using Python3.
Maybe similar to #287 and #255

sorry, forget to mention, we are on module version 3.5.1 of opitzconsulting.ansible_oracle


Remove ErrNotFound as possible result when searching for list of objs

Fix #1392
When using Redis DB do not raise error when searching for
multiple objects and none object is found. Just return empty slice.
Applying this patch makes possible to delete DeviceProfile, DeviceService and Addressables when using Redis DB.
Signed-off-by: difince<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (edinburgh@d91bfa6). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             edinburgh    #1409   +/-   ##
============================================
  Coverage             ?   17.02%
============================================
  Files                ?       78
  Lines                ?     8789
  Branches             ?        0
============================================
  Hits                 ?     1496
  Misses               ?     7142
  Partials             ?      151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91bfa6...46eb0e1. Read the comment docs.


Update get-started-core-ediscovery.md

Updated steps as options have changed

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9894

@JohanFreelancer9 Please copy review

Learn Build status updates of commit fbb7609:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/get-started-core-ediscovery.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 5becce3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/get-started-core-ediscovery.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Cool, thanks guys!

@robmazz Please merge this PR. Thanks

@yogkumgit  I think this still needs merged.

@robmazz Gentle reminder.

@yogkumgit Another reminder.

Learn Build status updates of commit b8759fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/get-started-core-ediscovery.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Closing as per the comment in #9894


Invalid css property generated with gridTemplateColumns

Description
When i use the gridTemplateColumns property with the following value: "3"
I expect to have a generated class with: repeat(<value>, minmax(0, 1fr))
but i get 3px instead.
When i change the value for 1fr 1fr 1fr or repeat(3, 1fr), it works as expected
I made a reproduction of the issue here: https://github.com/VincentBee/bug-reproduction/tree/pandacss/grid-column?tab=readme-ov-file#bug-reproduction
Link to Reproduction
https://play.panda-css.com/B1gCpvUP6H
Steps to reproduce

Follow installation guide: https://panda-css.com/docs/installation/vite
Add a grid using this documentation: https://panda-css.com/docs/utilities/flex-and-grid#grid
See the generated property for the div

JS Framework
React (TS)
Panda CSS Version
0.48.0
Browser
Every
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information
No response

Please see the changelog here:
https://github.com/chakra-ui/panda/blob/main/CHANGELOG.md#changed
We'll update the docs shortly


adjust textfield text and placeholder text

are there any x padding to adjust the textfield text and place holder

No, its no different than a standard UITextField in that respect. You would have to use the same tricks used on text fields to accomplish this.


Add playgrounds to Task and Tutorial prerequisites.

This change is

Deploy preview ready!
Built with commit 53b8d8f667707e59f96590c3f91ef8d15ef93d87
https://deploy-preview-4550--kubernetes-io-master-staging.netlify.com

attn: @BenHall @marcosnils

Thank you, LGTM

closes #4252


bug(source): certain properties/options missing after upgrading from v1.5.0 to v1.6.0

Describe the bug
In #13762, we intended to fix a problematic design where WITH (k0 = v0) FORMAT ... ENCODE ... (k1 = v1) shares a single KV map. The PR tries to maintain backward compatible by detecting legacy sources and copying necessary KV pairs from one position to another (see src/meta/src/manager/catalog/mod.rs). However, it seems not working as intended, and certain KV pairs are lost, causing a source to malfunction after upgrade.
Notably, this include schema registry username and password if they were given after WITH before the upgrade.
Error message/log
No response
To Reproduce
Start v1.5.0 server:
git checkout v1.5.0
./risedev configure # enable minio and etcd
vim risedev.yml # uncomment minio, etcd and compactor
./risedev d

Create a table with source (kafka broker at 51349 and http server at 8000):
create table t with (connector = 'kafka', topic = 'test-topic', properties.bootstrap.server = '<IP_ADDRESS>:51349', schema.registry.username = 'foo') format plain encode avro (schema.registry = 'http://<IP_ADDRESS>:8000');

Add logging. Restart v1.5.0 to see username is retained:
vim src/connector/src/schema/schema_registry/client.rs +83 # output client_config.username in Client::new
./risedev k
./risedev d

Upgrade to v1.6.0 and see username is lost:
./risedev k
git stash save 'inspect schema registry username'
git checkout v1.6.0
git stash apply
./risedev d

Expected behavior
Sources created in v1.5.0, even with schema.registry.username specified after WITH, shall still send it when calling schema registry API upgrading to v1.6.x.
How did you deploy RisingWave?
RiseDev
The version of RisingWave
from the v1.5.0 tag to v1.6.0 tag
Additional context
Dummy schema served by http server on 8000: subjects/test-topic-value/versions/latest
{
  "id": 71,
  "subject": "test-topic-value",
  "version": 2,
  "schema": "{\"type\":\"record\",\"name\":\"TestVal\",\"fields\":[{\"name\":\"f1\",\"type\":\"string\"}]}"
}

cc @Rossil2012 @tabVersion

Impact:
Infinite retry loop with the following error:
https://github.com/risingwavelabs/risingwave/blob/v1.6.0/src/stream/src/executor/source/source_executor.rs#L237
Root cause:
The compatibility logic in CatalogManager (src/meta/src/manager/catalog/mod.rs) is not enough. There is another copy of PbStreamSourceInfo stored in FragmentManager which is actually used by SourceExecutorBuilder.
Potential fix (unfortunately we already have 3 different flavors in use):

Similar to sink format encode compatibility logic, avoid mutating stored protobuf but handle it during protobuf decoding.
Similar to time zone expr context compatibility logic, avoid mutating stored protobuf but handle it during FragmentManager::new loading.
Similar to source rate limit or current CatalogManager::init compatibility logic, also mutate stored protobuf of FragmentManager and commit it to meta.


Running nbmake with specific kernel from CLI

Hi,
I've noticed that when running nbmake on a notebook, it'll use the kernelspec that has been saved in the metadata of the notebook. However, I have two kernels for a project that I'm working on - one with Spark installed, one without - so I'd like to be able to specify the kernel I want to use when running nbmake, without having to manually change the metadata of the notebook each time. Is this already possible? If not, can this feature be added?

Hi @lamesjaidler this is not already possible but is a great idea. I May look at this in the next couple of weeks.

Released in 1.1, feedback welcome!
https://github.com/treebeardtech/nbmake#override-notebook-kernels-when-testing

Works perfectly, thanks!


Write Unit Tests for RGBLEDHelper

Description:
Write unit tests for the RGBLEDHelper class to ensure proper functionality of all its methods, including color setting, frequency handling, and turning the LED on/off. Use mocks for the Pwm components to simulate hardware interaction.
Tasks:

Test Initialization:
Verify that RGBLEDHelper correctly initializes Pwm instances for red, green, and blue.

Test setColor Methods:

Test setColor(int[] colors) to ensure it sets the RGB values with default frequency (200 Hz).
Test setColor(int[] colors, int[] frequency) to verify RGB values and corresponding frequencies are set properly.

Test setColorHex Methods:
Test setColorHex(String hex) for correct RGB values from hex and default frequency.
Test setColorHex(String hex, int[] frequency) for correct RGB values and frequencies.

Test Individual Color Setters:
Write tests for setRed, setGreen, and setBlue to validate both color value and frequency setting.

Test ledOff and ledOn:
Ensure ledOff() turns off all RGB components.
Ensure ledOn() sets all RGB values to 100 with default frequency.

Acceptance Criteria:

[ ] Unit tests cover all methods.
[ ] All tests pass with mock Pwm components.
[ ] Log messages are validated for correct execution.

Hello dear @yrlmanoharreddy
I have some question about this issue:

If you want to verify RGBLEDHelper correctly initializes Pwm instances for red, green and blue,  we need to having access to red, green and blue instances of class however we don't have any getter method for this fields. I can get access to this fields through reflection however it is not best way and also I can create getter method for this field. which one do you prefer or is there any other way ?
Same issue for checking log message. I need at least a setter method for logger field in order to check message through mocking logger. Can I add setter method to this class?


Preserve unknown unicode characters when saving

EDITED: I've updated this top comment to contain the most relevant information. This is still present in the most recent VSCode version 1.22.2.
I didn't see an existing one like this so here we are.

VSCode Version: 1.22.2
OS Version: Win10 Enterprise

Steps to Reproduce:

Have a UTF-8 file with unicode U+0091 in it.
Open file in VS code to have it displayed as �
Make change somewhere in file other than the hex 91 character and save file
Open in notepad++ to see the character is now different as the hex in the file for U+0091 has been rewritten as � (0xEFBFBD) from the 0x91 it was previously.

Reproduces without extensions: Yes
Weird_Character.zip
Here is an example that I've encountered with most of the file cut out.
This is what it looks like in both editors prior to making the change:

Here is what it looks like after adding the 4th line of text from VS Code:

As I was guessing, it looks like VS Code is normalizing the encoding of the file to UTF-8 and modifying the underlying hex in the file to the '?' character in "there's". Is this expected behavior to implicitly normalize the underlying file whenever it's saved like this?
I tried the same edit but from notepad++ first and it doesn't seem to normalize the file.

Further investigation and asking around seems to indicate that the quote character is a 1252 encoded character that's being displayed weirdly and then normalized to utf-8 and saved back.

Is it expected that VS Code will normalize your file to whatever encoding it detects the file as? If so, what I'm describing might be expected behavior. I'm coming from notepad++ though which doesn't normalize files by default so it seemed wrong.

@Captainohair I could not reproduce.
Here is what I have tried:
A program that generates such a file:
var fs = require('fs');
fs.writeFileSync('file.txt', 'world <<' + '\u0091' + '>>');

The generated file in a hex viewer:

I then proceed to open the file in VS Code and type "Hello" before "world". I hit save. Here is the file on disk:

Perhaps there is something else specific about your file, that makes VS Code open it with a different encoding than utf8?
@bpasero can help with our settings around encodings

@bpasero can help with our settings around encodings

files.encoding: <the encoding>

Weird_Character.zip
Here is an example that I've encountered with most of the file cut out.
This is what it looks like in both editors prior to making the change:

Here is what it looks like after adding the 4th line of text from VS Code:

As I was guessing, it looks like VS Code is normalizing the encoding of the file to UTF-8 and modifying the underlying hex in the file to the '?' character in "there's". Is this expected behavior to implicitly normalize the underlying file whenever it's saved like this?
I tried the same edit but from notepad++ first and it doesn't seem to normalize the file.

Please fix this critical bug. It can't stay that VS Code is silently changing data.

I haven't seen a response yet. Is this normalization that occurs expected behavior?

I've edited the first comment with the better summary of the issue and that this is still occurring in the most recent version.

@bpasero Any update on this? Is this apparent normalization to the detected encoding expected behavior?

If a file contains a character that is not valid UTF-8, it will end up garbled as described in this issue. The underlying reason for this is that the encoding is set to UTF-8 and we encode the entire file as UTF-8 upon saving. If someone has a better idea what to do here, please comment.

well it is pretty easy imho:
if the file is opened as unicode AND saved as unicode, keep unchanged chunks as-is.
the problem of the current behaviour is that i change something in line 2 and vscode changes the hex somewhere down in line 4327 which i can't recognize.
if a file is opened in non-unicode and saved in unicode, encode it all in unicode as you do now.
another possibility:
open and save the file like now but warn if there are unknown characters that aren't the unicode unknown character, such as the ANSI codes for 'ä', 'ö', 'ü', 'ß'.

Ideally, normalizing behaviors like this would be an option I can opt out of. Maybe I want it to normalize files for something, but then I need to work with files where I need them to remain unchanged except for the exact bits I've directly modified. This is currently the default behavior of Notepad++, it saves only what I've changed in the file.
So, if it would be possible to have two modes, or a mode I could disable. Have it normalize by default to be consistent with existing behavior, but then have an option to turn off the normalization and have VS Code save only the changes to the file that I've made.
I just don't like knowing that my text editor might up and modify other parts of the file on me as @WorldofBay mentions. Whether or not my file is consistent with itself is a problem for me to decide, not my editor. I would like for my editor to have the tools available to make the file consistent with itself if I deem it necessary however.

There is literally nothing I can do from the file service, this needs support from the editor. I am asking the snapshot to return me a value for the contents of the editor (here) and this value will be UTF encoded and already converted. So at that point in time it is too late to fix the conversion.

I think this is a challenging change and not sure worth the efford.

This issue has cut down on my use of VS Code for editing random files, because I can't trust it. As pointed out other editors handle this in a much nicer way. It's even worse if you use autosave by default, as simply opening a file to inspect it can lead to changes in the file without your knowledge.
The display of invalid characters can look however it needs to. Please don't change bytes in the file that I didn't type anything into.

@bpasero Thank you for routing this to the appropriate party. @rebornix, please consider implementing a fix as we have described here. It would make VS Code much more robust and it would feel much more reliable. I agree with @billwert that I just can't trust the editor. As I've mentioned, it probably shouldn't matter most of the time whether your files are normalized or not, but sometimes I absolutely can't have a file get normalized based on what the editor thought it determined the file encoding to be. I do a lot of data transformation tasks and I need to know that what I'm seeing in my editor is exactly what is in the file.

Technically we read the buffer from nodejs and then convert it into js string for later manipulation, in which it's being decoded (by guessing and we think it's UTF8 in this case) and then encoded as UTF16. That's why we see � when it's shown in the editor. When we attempt to save, we are decoding the string with � and then try to encode it with proper encoding for saving the disk. If I understand correctly, it went wrong when we do the encoding conversion from the buffer at the very beginning.
I labelled it as Help wanted as my knowledge of encoding/decoding doesn't give me any hint of how to properly fix this issue and if I can get any help, it would be highly appreciated.

I unfortunately don't have nodejs experience but I will see if I can get more eyes on this who do.

I would say that if the editor fails to decode the file in the chosen encoding, you should a warning about the encoding being wrong. At least if you try to edit it.

In my case, vim finds the right encoding for the file and doesn't garble the characters.
Definitely a bug that should be addressed, no editor should change characters in a file without user consent or a issuing a warning at the very least.

This is a huge pain.  VScode needs to have a dialog warning before saving a file that contains any "�".

Yes i have been bitten by this as well because i used VSCode as merge editor without configuring the encoding options first, creating a ton of work.
In my opinion, a good enough and hopefully much easier solution is to simply warn the user when a file is opened with unknown symbols, telling the user to configure the encoding options correctly and reopen the file (on saving would work as well).
In addition, the auto-detection option could maybe be enabled by default instead of UTF-8 (that option hopefully defaults to UT-8 anyway in most cases without ANSI characters).

The bug didn't seem to be fixed for me.  Today I was editing the pm.lua file in the Lua 5.3.4 test suite (https://www.lua.org/tests/#files).  vscode silently made a number of changes when saving, breaking the tests.  The file was detected as UTF8-encoded.
To reproduce:

download and unarchive https://www.lua.org/tests/lua-5.4.3-tests.tar.gz
open pm.lua and save as pm2.lua
observe the difference between pm.lua and pm2.lua

If I reopen the file pm.lua with windows 1252 encoding explicitly then it appears to behave well.
I've uploaded pm.lua for convenience (as pm.txt because .lua files cannot be uploaded):
pm.txt.
I was using vscode version 1.62.3 on macos.  Here are the details:
Version: 1.62.3 (Universal)
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T07:59:13.865Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0

@arnodel do you have "files.autoGuessEncoding": true set?

@arnodel do you have "files.autoGuessEncoding": true set?

No, thanks for pointing out this setting.  If I turn that setting on, then the file encoding is correctly guessed, therefore there are no silent changes when saving it.
However I don't think the default behaviour should lead to potential file corruption.


Will code work with D1 Mini V2 NodeMcu board?

Hi,
I would like to do this project with the D1 Mini V2 NodeMcu board. Does anyone know if the same code will work on that board?

Hi @DNA99
The code should be compatible as its still based off the ESP8266 chipset. As this board has less pin outs, you would need to put it on some breadboard so you can share the GND and 3v / 5v rails


Search

no search suggestions

no search suggestions

nahh... wont be implementing this 👀
Although maybe recent searches, not sure. but no plans for this.


Unclear if stack templates includes docker-compose files

Description
Portainer provides the ability to define stack templates. From the user documentation it is not clear if this covers docker-compose files, or only the docker stack command.
And if it is required to set up the swarm cluster in swarm more?
I.e. Can Docker Swarm stand alone be used? Any other pre-requisites?
I need to use docker-compose files for several reasons. One is that the mac-address option is not supported in the docker stack command.
The stack entry in the steps below does not show up at all.
Steps to reproduce the issue:
I have the following templates.json file:
[
  {
    "type": "container",
    "title": "Registry",
    "description": "Docker image registry",
    "categories": ["docker"],
    "platform": "linux",
    "logo": "https://cloudinovasi.id/assets/img/logos/registry.png",
    "image": "registry:latest",
    "ports": [
      "5000/tcp"
    ],
    "volumes": ["/var/lib/registry"]
  },
  {
    "type": "stack",
    "title": "Registry",
    "description": "Docker image registry",
    "categories": ["docker"],
    "platform": "linux",
    "logo": "https://cloudinovasi.id/assets/img/logos/registry.png",
    "repository": {
      "url": "https://github.com/portainer/templates",
      "stackfile": "stacks/cockroachdb/docker-stack.yml"
    }
  }
]

Start Portainter
Configure Use custom templates under Settings.
Navigate to App Templates => only the first item is shown

Technical details:

Portainer version: 1.15.2
Target Docker version (the host/cluster you manage):
Platform (windows/linux): Ubuntu, Docker version 17.06.0-ce, build 02c1d87
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):
Target Swarm version (if applicable): Using different endpoints: individual docker engines, and Docker Swarm standalone
Browser: FF 45.4.0

I noticed that in Portainer v1.15.0 I do see both entries.
However, seems that regular docker-compose files cannot be started as a stack.

Hi @bergtwvd
Portainer do not support docker-compose yet. It only support docker stack deploy via the stacks management feature available when connected to a Swarm cluster.
When managing a Docker standalone host, Portainer will only display the templates with the type container in the Apps Templates section. You can access "stack templates" only when connected to a Swarm cluster.
Regarding Portainer v1.15.0, you can indeed see all the entries because this version of Portainer is not able to make the difference between container/stack templates (and cannot deploy stack at all).

From the user documentation it is not clear if this covers docker-compose files, or only the docker stack command.

Could you point me the section of the docs that you find not clear enough?

you are correct,  but I had to find this out by reading the issues on the stack template. Your comments are exactly what is missing now. Maybe just add that to the documentation.
Support for "regular" compose files is a must have for me; but this is requested in several existing  issues already, so I won't open a new one.
I close this one. Thanks.

Again, thanks for your report, I've added a note into the docs: http://portainer.readthedocs.io/en/latest/templates.html#stack-template-definition-format


additional changes

@ShreshthKushwaha - Please find the additional changes. Kindly review and merge. Thanks!

Looks good


MWPW-121136 add georoutingV2

Adds the new georouting modal for adobe.com
Resolves: MWPW-121136
Test URLs:

Before: https://main--milo--adobecom.hlx.page/about/?akamaiLocale=CH

After: https://vhargrave-georouting-v2--milo--adobecom.hlx.page/about/?akamaiLocale=CH

Before: https://main--milo--adobecom.hlx.page/about/?akamaiLocale=DE

After: https://vhargrave-georouting-v2--milo--adobecom.hlx.page/about/?akamaiLocale=DE

Bacom (still using the old georouting so do not expect to see the new modal)

https://main--bacom--adobecom.hlx.page/?akamaiLocale=CH
https://main--bacom--adobecom.hlx.page/?akamaiLocale=CH&milolibs=vhargrave-georouting-v2

Milo Coffee (has georoutingV2 and georoutingV1 activated)

https://main--locale-testing--vhargrave.hlx.page/milo-coffee/subpage/?akamaiLocale=CH
https://main--locale-testing--vhargrave.hlx.page/milo-coffee/subpage/?milolibs=vhargrave-georouting-v2&akamaiLocale=CH

Feedback from the stakeholders:

Text of button and link might not also be fully aligned

It's probably just a config or even content issue, but I saw a placeholder on the milo-coffee page: https://main--locale-testing--vhargrave.hlx.page/milo-coffee/subpage/?milolibs=vhargrave-georouting-v2&akamaiLocale=CH

@vhargrave : there are merge conflicts that need to be addressed.

@vhargrave : there are merge conflicts that need to be addressed.

@honstar merged main - thx!

@chrischrischris I checked the url and its good now with your lana loop branch fix.  I tested your branch as well as Victor's georouting branch you added the test fix too.

Is this correct @vhargrave?
I set my international cookie to ca_fr.  The locale options I'm presented with are Canada or United States. My expectation is that I should be presented with the three Swiss related locales.

Is this correct @vhargrave?
I set my international cookie to ca_fr.  The locale options I'm presented with are Canada or United States. My expectation is that I should be presented with the three Swiss related locales.

@rgclayton yeah it is correct actually - if the locale has been set already in the sessionStorage or as a cookie then the code won't check the akamaiLocale, because it already has a value to work with, which the user will have set that session.

I noticed a small css issue: for countries like Switzerland that has multiple languages, the preselected language (German in this specific case) shows what I believe is a focus outline (see screenshot).

I noticed a small css issue: for countries like Switzerland that has multiple languages, the preselected language (German in this specific case) shows what I believe is a focus outline (see screenshot).

@honstar the question is if it's a CSS issue. By default all modals will focus on an element like a link or button for accessability reasons. I shouldn't get rid of the focus, since it's a default action for all modals and needed for accessability. The next question is therefore if a focus should be styled differently. If it should, I'd argue this is a more general CSS topic to adapt in all modals. Alternatively I could focus on something else after the modal loads, so the focus is not really visible right away, but this is probably not the best experience for blind folks.

Any objections to merging this PR? Is there anything else that needs addressed?

Any objections to merging this PR? Is there anything else that needs addressed?

@rgclayton In my opinion it can be merged, but I've held off because I think @auniverseaway wanted to take a last look at it


Support requesting code suggestions

Hey!
First of all, loving the look of this plugin - I'm actively watching its development. Haven't used it yet as I'll be waiting for the all commits flag; which is more inline with my workflow.
I was wondering if you support / have plans on supporting requesting code suggestions? One of the biggest frustration points for me when reviewing PR's is not having LSP + treesitter support in the GitHub UI, resulting in requested changes with typo's + indentation issues etc. Would love to get your thoughts on this!
Thanks :)

Sorry @ldelossa, should've clarified. It's actually called a suggestion

First of all, loving the look of this plugin - I'm actively watching its development. Haven't used it yet as I'll be waiting for the all commits flag; which is more inline with my workflow.

By this do you mean you're waiting for a tree which shows "all modified files" ?

First of all, loving the look of this plugin - I'm actively watching its development. Haven't used it yet as I'll be waiting for the all commits flag; which is more inline with my workflow.

By this do you mean you're waiting for a tree which shows "all modified files" ?

Yep. In fact, my workflow is a bit of a mix of the two depending on the context/size of the PR. So ideally it's not just a flag, I can select whether to review all modified files or each commit through the UI

Cool suggestions! Let me look into a few things. I need to do a couple other PRs until we get to suggestions (like aggregate file view we mentioned above). I also need to brush up on TS. I dont really know if I can apply TS highlighting to a chunk of arbitrary text inside a buffer? I think I see nvim-notify doing this, but not sure how yet.
In a perfect world, any code blocks in the covo buffer of a threaded message get a nice syntax aware highlighting. And yes, morphing "suggestion" markdown blocks into inline diffs would be pretty sick.

For posting code suggestions, my workflow currently is to open the change that I want to comment on, yank the relevant lines, open a comment thread, then manually type ```suggestion, newline, paste, edit , type the ``` to close out the diff, and post the comment.
It would be neat to have something a bit more integrated like if you edit/delete some lines in the file buffer then open a comment thread, the buffer automatically opens with a ```suggestion ... ``` comment pre-populated.
Extra points would be the inverse workflow - when reading reviews from peers, ability to integrate the suggestions directly back into the local files. I don't know quite how that would look though.


Remove redundant type variables in the guide.

I am reading https://verus-lang.github.io/verus/guide/spec_lib.html and find a TODO is left: TODO: lemma_len_intersect::<A>(...) should not need the ::<A>. I removed those type variables and verus can also work.  It seems that verus has supported type inference.

Hi! Thank you for fix!


OpenID association does not work

Testing the 4.1.0-RC2, I got:
OPENID CLIENT DEMO 2015/09/03 13:32:33,499 ERROR [http-nio-8080-exec-8] org.openid4java.consumer.ConsumerManager - Error encountered during association attempt.
org.openid4java.message.MessageException: 0x100: Invalid Key-Value form, colon missing:
	at org.openid4java.message.ParameterList.createFromKeyValueForm(ParameterList.java:209)
	at org.openid4java.consumer.ConsumerManager.call(ConsumerManager.java:618)
	at org.openid4java.consumer.ConsumerManager.associate(ConsumerManager.java:776)
	at org.openid4java.consumer.ConsumerManager.associate(ConsumerManager.java:658)
	at org.leleuj.MainController.confirm(MainController.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)

The OpenID association does not work, which does not make any issue, except when the user wants to enter his identifier (http://specs.openid.net/auth/2.0/identifier_select).
I suspect some extra lines in the JSP files.

The problem does not occur on my Mac with the RC3-SNAPSHOT. But I think it will happen on Windows.

PR: https://github.com/Jasig/cas/pull/1115
I'll retest everything tomorrow on Windows to ensure the fix works.

Merged via https://github.com/Jasig/cas/pull/1115


Interrupt refactor

This is a big refactoring of the way interrupts are handled. I took some inspiration from @phil-opp, @emk, Redox, (specifically, @ticki) and an inb/outb combo from @thepowersgang. All different bits of their OSes' code and several OSDev/OSDevr tutorials. Whew!
These commits should probably be cleaned up, and this isn't even quite in a final state; I should be using a lazy_static rather than making things Copy, and I would like to move a lot of these home-grown structures to the x86 crate instead. But before I do, I wanted to have written it all myself. Ha!
Thoughts, all?

Awesome work! It seems that you don't use naked functions? Why not?

@ticki @eddyb I should. this code originally landed since before naked functions had existed, but now that they do, i should make use of them.

I've been following along with your development and it's looking great to me! Excited for the upcoming work on the kernel 👍

Merging this for now, because it's still an improvement. I'll open issues for the other stuff.


Kryoserializer error in flow_post_lda.scla

During the flow_post_lda.scala execution this error is thrown:
org.apache.spark.SparkException: Kryo serialization failed: Buffer overflow. Available: 3, required: 8. To avoid this, increase spark.kryoserializer.buffer.max value.        at org.apache.spark.serializer.KryoSerializerInstance.serialize(KryoSerializer.scala:263)        at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:240)        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)        at java.lang.Thread.run(Thread.java:745)

Can't reproduce. Please provide more information to reproduce.


Address formatting issues

Fixes #211   .

There is a conflict between Black and reorder-python-imports starting with Black v24 related to spacing. One wants to insert blank lines and the other wants to remove them; hence the pre-commit workflow will always fail. I recommend we downgrade to Black v23 until this is fixed or there is a workaround. To do that, however, we need to disable the pre-commit autoupdate.

The closest config option I can find is at pre-commit.ci, where it says autoupdate_schedule can be set to 'quarterly':

(optional, default: 'weekly') control when the autoupdate runs, possible values: 'weekly', 'monthly', 'quarterly'.

The codecov/codecov-action GitHub action exits without action when a coverage.xml file is missing. Until we find a way to run the unit test script in the GitHub actions workflow, the entire continuous-integration.yml workflow file is impotent so I removed it for now.


Bug: “Provisioned-managed Utilization by Model Name” chart is showing only one model

Even though multiple models have been deployed, “Provisioned-managed Utilization by Model Name” chart is showing only one model. splitBy configuration is missing for PTU Utilization Metric (by Model Name, Model Version, Model Deployment Name, StreamType, Region).
I request to add splitBy configuration and update the workbook. Thanks.

Hi @UmarMohamedUsman ,
Thanks a lot for your feedback.
Indeed, the "splitBy" dimension configuration was missing.
I fixed it and now it is set properly. (You can use the latest release v1.1)


http to https redirect without adding new entrypoints

hey guys,
is it possible to enforce a http to https redirect with the default two entrypoints?
I've tried to set the following in values.yml
additionalArguments:
  - --entrypoints.web.http.redirections.entrypoint.to=websecure
  - --entrypoints.web.http.redirections.entrypoint.permanent=true

But now if you try to access traefik from outside the cluster via http and :80, it re-directs to the value of websecure, which is :8443. This of course does not work, because the k8s service does the port remapping from :443 to :8443 and itself does not listen on :8443
Is there a special setting in traefik to allow this with the default entrypoints? Otherwise I guess I'll have to remove the securityContext and let traefik directly bind to :80 and :443, but this of course is not super nice.

But is this option valid for Kubernetes Ingress as well as IngressRoutes to basically enable default redirets?

@ekarlso yes

@mmatur I have enabled it but going towards a non-existant route gives a 302 while going towards a Kubernetes Ingress source provided route actually fowards the traffic to the service on plain http.
Both http and https actually work directly towards a given existing service though I would assume that it should have redirected me to https?

@ekarlso Could you please open a discussion on the community forum it will be a best place to discuss about your question.

@mmatur I already did but sadly it seems like a bug or how it works to me?