Support relationships between classes with a common module parent

I came about this problem because I am using Dynamoid in a Rails Engine, and I discovered issues where the relationships between models were not functioning correctly due to the isolate_namespace functionality of engines.
For example, piggybacking off the example in the README, if I had classes like this, but in an engine named MyEngine...
module MyEngine
  class User
    include Dynamoid::Document

    # ...

    has_many :addresses
  end
end

module MyEngine
  class Address
    include Dynamoid::Document

    # ...

    belongs_to :user # Automatically links up with the user model
  end
end

I would get the following in a rails console
> u = MyEngine::User.create!
> address = MyEngine::Address.create(user: u)
> u.addresses.count # gives 0

In other words, the MyEngine::Address ID would not be saved on the MyEngine::User dynamo record.
This is because in this line of code in belongs_to.rb, the MyEngine::Address class would evaluate to :"my_engine/addresses" which of course is incorrect.
My solution is to check if both the target_class and the source_class share the same module_parent, check that that module parent custom to the app, and then use the demodulize functionality to strip the class down to its bare name.

Could you plz add specs for the fixed behaviour?


'' used to escape a '_' in the URL is invalid according to MD051

The '' character used to escape a '_' character in the URL is invalid according to MD051.
Example : [nfs](#module\_nfs) is invalid
But if I try here, it is correctly interpreted: https://spec.commonmark.org/dingus/?text=[nfs](%23module_nfs)
&smart=1
Is this deliberate behaviour?
I'm wondering because this breaks compatibility with terrafom-docs and I'd like to know whether I should ask them to correct this or not :-D

It should be unnecessary to escape the underscore in that scenario, but I need to look at the specifications to see if it's wrong to do so. I notice that the backslash is ignored in your example and by the markdown-it parser. I will look into this more when I'm not on my phone.

It seems to be ignored by the micromark parser as well.

CommonMark explicitly allows backslash escapes in link destinations: https://spec.commonmark.org/0.30/#example-22

Thank you so much for your responsiveness and all your hard work!


Reskin - proposal details

Closes #1566
This PR implements reskin updates which bunch of assumptions on Azorius/Snapshot proposal styling and copy.
Design: https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?type=design&mode=design&t=SelIQoPt9TAZxanI-0
Implemented UI

looks great @mudrila
@xraystyle1980 @nicolaus-sherrill - question for design, are the new radio buttons for 'yes, no, abstain' big enough when translated for mobile?


Unable to create tracer: cannot obtain reporter config from env: cannot parse env var JAEGER_AGENT_PORT

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Here are current deployed traefik args:
spec:
      containers:
      - args:
        - --global.checknewversion
        - --global.sendanonymoususage
        - --entryPoints.metrics.address=:9100/tcp
        - --entryPoints.traefik.address=:9000/tcp
        - --entryPoints.web.address=:8000/tcp
        - --entryPoints.websecure.address=:8443/tcp
        - --api.dashboard=true
        - --ping=true
        - --metrics.prometheus=true
        - --metrics.prometheus.entrypoint=metrics
        - --providers.kubernetescrd
        - --providers.kubernetesingress
        - --log.level=DEBUG
        - --accesslog=true
        - --accesslog.fields.defaultmode=keep
        - --accesslog.fields.headers.defaultmode=drop
        - --tracing.jaeger=true
        - --tracing.jaeger.samplingServerURL=http://jaeger-agent:5778/sampling
        - --tracing.jaeger.localAgentHostPort=jaeger-agent:6831
        image: traefik:2.5.6

As you can see, tracing is enabled using jaeger.
Dashboard:

I'm currently accessing to several exposed services.
Problem is that when I'm trying to get information of tracing into jaeger, it's only showing me one service.
Several entrypoints and routers are well configured.
But anyone of them is listed on jaeger listbox. Obviously, I'm reaching correctly to exposed services.
I've took a look on traefik pod logs:

evel=warning msg="Unable to create tracer: cannot obtain reporter config from env: cannot parse env var JAEGER_AGENT_PORT=udp://<IP_ADDRESS>:5775: strconv.ParseInt: parsing "udp://<IP_ADDRESS>:5775": invalid syntax"

I don't know why this env variable JAEGER_AGENT_PORT is present.
By other hand, ip a port are correct. I mean, jaeger agent service has <IP_ADDRESS> allocated.
What did you see instead?
Tracings are not sent at jaeger.
I've took a look on logs:

level=warning msg="Unable to create tracer: cannot obtain reporter config from env: cannot parse env var JAEGER_AGENT_PORT=udp://<IP_ADDRESS>:5775: strconv.ParseInt: parsing "udp://<IP_ADDRESS>:5775": invalid syntax"

What version of Traefik are you using?
I've installed traefik on kubernetes using helm chart:
NAME           	CHART VERSION	APP VERSION
traefik/traefik	10.9.1       	2.5.6

What is your environment & configuration?
spec:
      containers:
      - args:
        - --global.checknewversion
        - --global.sendanonymoususage
        - --entryPoints.metrics.address=:9100/tcp
        - --entryPoints.traefik.address=:9000/tcp
        - --entryPoints.web.address=:8000/tcp
        - --entryPoints.websecure.address=:8443/tcp
        - --api.dashboard=true
        - --ping=true
        - --metrics.prometheus=true
        - --metrics.prometheus.entrypoint=metrics
        - --providers.kubernetescrd
        - --providers.kubernetesingress
        - --log.level=DEBUG
        - --accesslog=true
        - --accesslog.fields.defaultmode=keep
        - --accesslog.fields.headers.defaultmode=drop
        - --tracing.jaeger=true
        - --tracing.jaeger.samplingServerURL=http://jaeger-agent:5778/sampling
        - --tracing.jaeger.localAgentHostPort=jaeger-agent:6831
        image: traefik:2.5.6

Add more configuration information here.
If applicable, please paste the log output in DEBUG level
time="2022-01-11T22:11:54Z" level=info msg="Configuration loaded from flags."
time="2022-01-11T22:11:54Z" level=info msg="Traefik version 2.5.6 built on 2021-12-22T16:30:52Z"
time="2022-01-11T22:11:54Z" level=debug msg="Static configuration loaded {\"global\":{\"checkNewVersion\":true,\"sendAnonymousUsage\":true},\"serversTransport\":{\"maxIdleConnsPerHost\":200},\"entryPoints\":{\"metrics\":{\"address\":\":9100/tcp\",\"transport\":{\"lifeCycle\":{\"graceTimeOut\":\"10s\"},\"respondingTimeouts\":{\"idleTimeout\":\"3m0s\"}},\"forwardedHeaders\":{},\"http\":{},\"udp\":{\"timeout\":\"3s\"}},\"traefik\":{\"address\":\":9000/tcp\",\"transport\":{\"lifeCycle\":{\"graceTimeOut\":\"10s\"},\"respondingTimeouts\":{\"idleTimeout\":\"3m0s\"}},\"forwardedHeaders\":{},\"http\":{},\"udp\":{\"timeout\":\"3s\"}},\"web\":{\"address\":\":8000/tcp\",\"transport\":{\"lifeCycle\":{\"graceTimeOut\":\"10s\"},\"respondingTimeouts\":{\"idleTimeout\":\"3m0s\"}},\"forwardedHeaders\":{},\"http\":{},\"udp\":{\"timeout\":\"3s\"}},\"websecure\":{\"address\":\":8443/tcp\",\"transport\":{\"lifeCycle\":{\"graceTimeOut\":\"10s\"},\"respondingTimeouts\":{\"idleTimeout\":\"3m0s\"}},\"forwardedHeaders\":{},\"http\":{},\"udp\":{\"timeout\":\"3s\"}}},\"providers\":{\"providersThrottleDuration\":\"2s\",\"kubernetesIngress\":{},\"kubernetesCRD\":{}},\"api\":{\"dashboard\":true},\"metrics\":{\"prometheus\":{\"buckets\":[0.1,0.3,1.2,5],\"addEntryPointsLabels\":true,\"addServicesLabels\":true,\"entryPoint\":\"metrics\"}},\"ping\":{\"entryPoint\":\"traefik\",\"terminatingStatusCode\":503},\"log\":{\"level\":\"DEBUG\",\"format\":\"common\"},\"accessLog\":{\"format\":\"common\",\"filters\":{},\"fields\":{\"defaultMode\":\"keep\",\"headers\":{\"defaultMode\":\"drop\"}}},\"tracing\":{\"serviceName\":\"traefik\",\"jaeger\":{\"samplingServerURL\":\"http://jaeger-agent:5778/sampling\",\"samplingType\":\"const\",\"samplingParam\":1,\"localAgentHostPort\":\"jaeger-agent:6831\",\"propagation\":\"jaeger\",\"traceContextHeaderName\":\"uber-trace-id\",\"disableAttemptReconnecting\":true}},\"pilot\":{\"dashboard\":true}}"
time="2022-01-11T22:11:54Z" level=info msg="Stats collection is enabled."
time="2022-01-11T22:11:54Z" level=info msg="Many thanks for contributing to Traefik's improvement by allowing us to receive anonymous information from your configuration."
time="2022-01-11T22:11:54Z" level=info msg="Help us improve Traefik by leaving this feature on :)"
time="2022-01-11T22:11:54Z" level=info msg="More details on: https://doc.traefik.io/traefik/contributing/data-collection/"
time="2022-01-11T22:11:54Z" level=debug msg="Configured Prometheus metrics" metricsProviderName=prometheus
time="2022-01-11T22:11:54Z" level=warning msg="Unable to create tracer: cannot obtain reporter config from env: cannot parse env var JAEGER_AGENT_PORT=udp://<IP_ADDRESS>:5775: strconv.ParseInt: parsing \"udp://<IP_ADDRESS>:5775\": invalid syntax"
time="2022-01-11T22:11:54Z" level=info msg="Starting provider aggregator.ProviderAggregator {}"
time="2022-01-11T22:11:54Z" level=debug msg="Start TCP Server" entryPointName=websecure
time="2022-01-11T22:11:54Z" level=debug msg="Start TCP Server" entryPointName=web
time="2022-01-11T22:11:54Z" level=debug msg="Start TCP Server" entryPointName=metrics
time="2022-01-11T22:11:54Z" level=info msg="Starting provider *traefik.Provider {}"
time="2022-01-11T22:11:54Z" level=info msg="Starting provider *ingress.Provider {}"
time="2022-01-11T22:11:54Z" level=info msg="ingress label selector is: \"\"" providerName=kubernetes
time="2022-01-11T22:11:54Z" level=info msg="Creating in-cluster Provider client" providerName=kubernetes
time="2022-01-11T22:11:54Z" level=debug msg="Start TCP Server" entryPointName=traefik

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


Fix the files which should be outputted at publish

Codecov Report

Merging #63 (dea92a6) into main (be7ba8f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           29        29
  Lines          195       195
  Branches        40        40
=========================================
  Hits           195       195

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7ba8f...dea92a6. Read the comment docs.


Closes #79 - This adds Sticky Social Bar!

{ No JS whatsoever, CSS only Sticky Social Bar }
Codepen Demo's:

Positioned Left => http://codepen.io/IamManchanda/full/QvbwvZ/
Positioned Right => http://codepen.io/IamManchanda/full/ybNyor/

cc / @canterberrie @kball for review/merge
Poke @rafibomb for yml english :D

I have no idea why github is showing so bad indentation for this ... i have indented properly as far of my best of knowledge

@IamManchanda The indentation issue is probably that your editor is using tabs. Please configure to use spaces, with one tab equal to 2 spaces.

done @kball @canterberrie

Great! Merged!


Add Kubernetes and Docker Swarm support

Support for this is currently a work in progress

Support for Kubernetes is now complete, swarm integration is implemented but yet to be tested.

Initial testing completed, we will continue to address bugs as they appear


a problem

`Traceback (most recent call last):
File "main.py", line 436, in
train(data)
File "main.py", line 326, in train
batch_word, batch_features, batch_wordlen, batch_wordrecover, batch_char, batch_charlen, batch_charrecover, batch_label, mask  = batchify_with_label(instance, data.HP_gpu)
File "main.py", line 234, in batchify_with_label
mask[idx, :seqlen] = torch.Tensor([1]*seqlen)
TypeError: mul() received an invalid combination of arguments - got (list), but expected one of:

(Tensor other)
didn't match because some of the arguments have invalid types: (list)
(float other)
didn't match because some of the arguments have invalid types: (list)`

Sorry, I got the answer, because of the version of pytorch 0.4.


AnimationComponent not work as child of PositionComponent

Description
If use AnimatedComponent as child of PositionComponent - animation not work.
Development environment
Flame version:
develop branch
Flutter doctor:
[✓] Flutter (Channel beta, 1.24.0-10.2.pre, on Mac OS X 10.15.7 19H15 darwin-x64, locale ru)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.1.1)
[✓] Chrome - develop for the web[✓] IntelliJ IDEA Ultimate Edition (version 2020.3)
[✓] VS Code (version 1.51.1)
[✓] Connected device (3 available)

Runtime
This issue is related to running on which platform? (Select all that apply)

[x] Android :android:
[x] iOS :apple:
[x] Web :browser:

Minimal reproducible code (Required for bugs)
import 'dart:ui';

import 'package:flame/components/mixins/has_game_ref.dart';
import 'package:flame/components/position_component.dart';
import 'package:flame/components/sprite_animation_component.dart';
import 'package:flame/extensions/vector2.dart';
import 'package:flame/flame.dart';
import 'package:flame/game.dart';
import 'package:flame/gestures.dart';
import 'package:flame/sprite_animation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart' hide Image;

void main() async {
  WidgetsFlutterBinding.ensureInitialized();

  final Vector2 size = await Flame.util.initialDimensions();
  final game = MyGame(size);
  runApp(
    GameWidget(
      game: game,
    ),
  );
}

class TestComponent extends PositionComponent with HasGameRef<MyGame> {
  TestComponent(Vector2 size) {
    this.size = size;
    debugMode = true;
  }

  void addAnimation(Vector2 position) {
    final size = Vector2(291, 178);

    final animationComponent = SpriteAnimationComponent.fromFrameData(
      size,
      gameRef.images.fromCache('creature.png'),
      SpriteAnimationData.sequenced(
        amount: 18,
        amountPerRow: 10,
        textureSize: size,
        stepTime: 0.15,
        loop: false,
      ),
      removeOnFinish: true,
    );

    animationComponent.position = position;
    animationComponent.position = animationComponent.position - size / 2;
    addChild(animationComponent);
  }
}

class MyGame extends BaseGame with TapDetector {
  late Image chopper;
  late Image creature;
  late SpriteAnimation animation;
  late TestComponent test;

  @override
  Future<void> onLoad() async {
    chopper = await images.load('chopper.png');
    creature = await images.load('creature.png');

    animation = SpriteAnimation.fromFrameData(
      chopper,
      SpriteAnimationData.sequenced(
        amount: 4,
        textureSize: Vector2.all(48),
        stepTime: 0.15,
        loop: true,
      ),
    );

    final spriteSize = Vector2.all(100.0);
    final animationComponent2 = SpriteAnimationComponent(spriteSize, animation);
    animationComponent2.x = size.x / 2 - spriteSize.x;
    animationComponent2.y = spriteSize.y;

    final reversedAnimationComponent = SpriteAnimationComponent(
      spriteSize,
      animation.reversed(),
    );
    reversedAnimationComponent.x = size.x / 2;
    reversedAnimationComponent.y = spriteSize.y;

    test = TestComponent(this.size);

    test.addChild(animationComponent2);
    test.addChild(reversedAnimationComponent);

    add(test);
  }

  @override
  void onTapDown(TapDownDetails evt) {
    test.addAnimation(Vector2(evt.globalPosition.dx, evt.globalPosition.dy));
  }

  MyGame(Vector2 screenSize) {
    size.setFrom(screenSize);
  }
}

Does it work if you send in a Game to addChild?
addChild(animationComponent, gameRef: gameRef);

I used an example from an animation from the docs doc/examples/animations, adding a PositionComponent to it

Does it work if you send in a Game to addChild?
addChild(animationComponent, gameRef: gameRef);

Its not work too

Can you try to add the children to the component after you have added the component to the game and see if that works?

Can you try to add the children to the component after you have added the component to the game and see if that works?

In the top example, on tap it adds an AnimationComponent to an existing component. But that doesn't work either.

@unger1984 it's now fixed on develop, and we'll probably release a new version with it before the weekend is over.

@unger1984 it's now fixed on develop, and we'll probably release a new version with it before the weekend is over.

thx!


Attached: "translated" Add-Migration to VB

Hi bricelam
Follow the VB version of Migrations in zip file:
EF-Migrations-VB.zip
4 files: VBHelper, VBMigrationOperationGenerator, VBMigrationsGenerator and VBSnapshotGenerator.
Some doubts in VBHelper = CSharpHelper
Any "____keyword" in VB like "__arglist" in C#? I dont remember.
In "public virtual string Lambda([NotNull] IReadOnlyList properties)" you are wanting to create a lambda, and if properties.Count > 1 then "new ??? { .... }". I am lost here. Please, can you write the generated lambda code, in C#? My translation:
x => x.prop    /    Function(x) x.prop
x => new {x.prop1, x.prop2}    /   Function(x) New From {x.prop1, x.prop2}
Its correct?
In "public virtual string Literal([NotNull] string value)" you are replacing \r\n? I'm lost again.
In VB dont need @"" \ and etc... In what situation would expect to find a NewLine in a VB String?
In "public virtual string Literal([NotNull] IReadOnlyList values)" you use "new[]". ????? =)
New String()? New From {...}?
Questions:

can you help me to finish VBHelper?
need "translate" others files? maybe "...Commands/Scaffolding/Internal/CSharpUtilites.cs"?
how compile and try this "Install-Package CommandsWithVBMigration"? Compile and send to Nuget?
how tell to Add-Migration use VB version?

Hugs from Brasil

Hey @midnait,
Just to set expectations... one of the reasons that we scoped features (such as VB.NET support) out of our first release is due to time constraints and the need to focus on finishing and stabilizing the features we have. To that end, we aren't going to be able to spend too much time helping others implement these feature either. Don't get me wrong, we're happy to answer a question here and there.
If this is something that you want to contribute to the code base, then contributions are handled via pull requests (rather than attaching code).
~Rowan

Hi @rowanmiller, @bricelam
I can contribute via PR, but first I need understand the code. =)  And this is not "code", but "pieces of generated code". I can spend very time trying understand why AppendLine("new ") or he just say "hey, the generated code will be 'x => x.prop1;', mount in VB now. =)
See, my doubts about "code" are only in 3 lines in Helper. 99% is done. Open PR with 99% done?
Still in my others questions: open PR without test before? missing necessary files?
Hugs

Hey @midnait,
Sorry for any misunderstanding... I wasn't suggesting that you open a Pull Request with your work so far. I was just saying that when you have something working then that is when we would take a detailed look at the code via a PR.
We discussed this today and we aren't really ready to start taking VB.NET support contributions because there is work needed in various other places too in order to have proper support. The biggest area is query, where the VB.NET and C# compilers can result in different expressions and we will need to additional logic to handle LINQ queries from VB.NET. We don't want to start taking migrations contributions and then have a half-finished VB.NET implementation in an RTM release.
Like you also mentioned, there are some sizable design questions around this feature (such as "how does Add-Migration work out which code generator to use").
Given all of this, and the need to focus on critical bugs at this stage in the release, we aren't really going to invest any cycles into the feature (or helping to implement it) at this stage. If you want to keep plugging away at it and coming up with proposals on how to solve some of the design questions, then we'd be happy to look at taking it post-7.0.0.
Sorry that isn't really the response you were after. We are just really having to focus our efforts at the moment to make 7.0.0 as stable as we can.
~Rowan

How can I use these translated migration on my projects? If not possible, Can I create a class lib. on my Project (in C#) just for store migrations? (keeping model and dbcontext on main vb.net Project).
Thanks

@HClausing The C# class library should work just fine. You may need to generate the C# files into your project with the DbContext first, then move them into the class library.

Thanks!

Been trying to do what @HClausing is doing but the migration is not working. A database is created but not with any of my tables in it, just the migrationhistory table.
I got it to work a couple of months ago, but that time I translated the migrations classes to vb.net. Since there was other issues I used another SQLite provider at the time but thought to give it another shot now since it isn't preview anymore.

@cwesterlund , I just call dbContext.Database.Migrate() instead of dbContext.Database.EnsureCreated().
During translation stage, I have used this site to do the jog, and it create sub lambas with Function(b). I have replaced this by Sub(b), and fixed some composite PK's.
Please try again, good luck.
If does not work, let me know, that'll help.

Hi @HClausing, So if I understand you correctly you converted the generated C# classes to VB.NET and stored them in the same project as the DBContext?
That is not the issue, I got that working a couple of months ago. The thing I want to do is use the generated C# classes without converting them to VB.NET. I thought @bricelam suggested that it be put in a separete C# project? But they are not used during the migrate call.
This is my class structure:
App.proj  (main UWP project)
Model.proj (Main vb.net model project with dc and DBContext)
Model_CS.proj (The new C# project where I store the generated migration classes in a sub-folder "Migrations")
Then during start up I call a function in the Model_CS project that calls DBContext.Database.Migrate on the DBContext class in Model.proj.

Hi @cwesterlund.
I'm sorry for misunderstood.
Have you ever tried to move your DbContext for C# Project? I believe this way will work.
Translating your dbcontext to c# is easier than translate the migrations to vb.net.

@cwesterlund Are you missing the following?
contextOptions.UseSqlServer(...)
    .MigrationsAssembly("MyCSharpClassLibrary")

Hi @HClausing and @bricelam
No, i missed that option but it makes no difference, the C# assembly is CASTS_MODEL_CS:
Protected Overrides Sub OnConfiguring(optionsBuilder As DbContextOptionsBuilder)
        optionsBuilder.UseSqlite($"Filename=" & DBManager.DatabaseRelativePath,
             Sub(ob As Infrastructure.SqliteDbContextOptionsBuilder)
                ob.MigrationsAssembly("CASTS_MODEL_CS")
             End Sub)
End Sub

Ok, now it suddenly works. Don't know what I did. I tried to move the DBContext to the C# project but realized that if I did that I would have to move the DAL classes also so I reverted and then it suddenly worked and the migration classes was in use.
Thanks @HClausing and @bricelam


Close eventLogSession and EventLogReader to unlock an etl file

Fix #3979
No tests and documentation required.

@lzybkr Could you please continue the code review?


small edits to the open infrastructure engineer job posting

Thanks @damianavila for launching the job posting! This PR has some small edits.

Thanks for these updates, @colliand!!


fix REPL test when there is a semicolon before a comment

This fixes REPL test when there is a semicolon before a comment. In Julia's REPL, output is suppressed when there is a semicolon before a comment like below:
julia> [1,2,3];  # comment

This behavior was not reflected in Lapidary.jl, so I fixed it.

Current coverage is 77.73%

Merging #32 into master will decrease coverage by -4.98% as of c9750a4

@@            master     #32   diff @@
======================================
  Files           11      11
  Stmts          515     521     +6
  Branches         0       0
  Methods          0       0
======================================
- Hit            426     405    -21
  Partial          0       0
- Missed          89     116    +27

Review entire Coverage Diff as of c9750a4

Powered by Codecov. Updated on successful CI builds.

Thanks, lgtm.


New RWD editor: scripts loaded is making media query test fail

Describe the Issue
Not sure what is happening. But one thing I did notice is that the scripts have had "use strict"; added inside them.

Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/build-a-personal-portfolio-webpage-project/build-a-personal-portfolio-webpage
Your code
Scripts breaking the test
<script type="module"<EMAIL_ADDRESS><script nomodule<EMAIL_ADDRESS>
Expected behavior
For it not to break.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
Forum thread: https://forum.freecodecamp.org/t/personnal-portfolio-media-query-issue/508731

Same here, but use this script:

<script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.5.1/highlight.min.js"></script>
<script>hljs.highlightAll();</script>

Just to clarify - the one media query test on that project is failing for you as well @coxde?

Just to clarify - the one media query test on that project is failing for you as well @coxde?

Yes, after I delete this script, I passed the one media query test.


[common] Enhancements / bug fixes to common library chart

Created this issue as a container issue, to more easily keep track of the things we need/want to fix on the common library chart, but that are not strictly neccessary right away and/or don't really warrant an issue of their own.

[x] {{ template common.whatever . }} pattern is best replaced by {{ include common.whatever . }}, according to official Helm docs
[ ] Helm named templates should all have a docstring (for lack of a better word) that describes what it does and what the expected input is (if applicable)
[x] service.port.targetPort is a string in the provided values.yaml file. Merging in user overrides could cause an error when an integer is given due to conflicting data types.
[x] README.md improvements are required
[x] Add support for hostNetwork
[x] Add support for hostAliases
[x] Add support for daemonset controller (https://github.com/k8s-at-home/charts/pull/178/commits/34df5b8fb599cac7c705efe91e3262f5a035e289)
[x] Add support for specifying and creating chart-specific serviceAccount (https://github.com/k8s-at-home/charts/pull/178/commits/836b5de03ddb5eb300faf460aeb4dc5ce3174bff)

We should target the above for a 1.6.0 release

service.port.targetPort could be a string or a number I wonder how we can make it generic.

service.port.targetPort could be a string or a number I wonder how we can make it generic.
One solution could be to leave it empty in values.yaml, and put in a default value (http?) in the service class .tpl file

One solution could be to leave it empty in values.yaml, and put in a default value (http?) in the service class .tpl file

Done in https://github.com/k8s-at-home/charts/commit/bb98d0cda5b97effa47a0d696832398339e1a40d


web3.storage: don't load large files into memory

Currently the upload tool creates CAR files when uploading to web3.storage. This is required to ensure the same CID is used. The library used to create CAR files loads the whole file into memory. This is usually fine, but will come back to bite us when we start ingesting large video files or something.
I have logged an upstream issue for this, although I expect to have to write the fix myself. https://github.com/photon-storage/go-ipfs-car/issues/6
Also, there seems to be some compression in play, so testing future fixes for this should use random data (like from /dev/urandom) rather than a file full of zeros or something.

The library used to create CAR files loads the whole file into memory

This fixed now, creating CAR files doesn't load files into memory when the file is over 1 GiB in size. That seems like a good default so it's what I have for now.
Unfortunately in practice the file still gets loaded into memory because that's what the w3 CLI does during the upload process. I've filed an issue for that: https://github.com/w3s-project/w3cli/issues/193


feat: port Data.List.Count

[ ] depends on: #1380

This PR/issue depends on:

leanprover-community/mathlib4#1380
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#1380
By Dependent Issues (🤖). Happy coding!

bors merge


Update aws-sdk-cpp version to 1.11.321(from 1.11.169)

AdaptiveRetryStrategy and GetRetryCount() API is not available in version 1.11.169. We need this version upgrade for RetryStrategy support of S3FileSytem.

@majetideepak Can you help approve and merge this PR? Thanks.


kubectl get nodepool -o wide should return if total number of nodeclaims (similar how deployment shows pods, uptodate etc)

Description
What problem are you trying to solve?
Showing a summary of the node claims associated and if they are up to current state or currently in drift state by something like 5/6. Would give an idea if something is happening in the cluster currently.
How important is this feature to you?

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

interested in working on the issue

@tvonhacht-apple We currently have an issue open for the v1 laundry list and how the printcolums should look https://github.com/kubernetes-sigs/karpenter/issues/493. Would you be willing to close this issue and post add you comments on that issue?

thanks added as comment


(Non-breaking) Make constructor optional in a class

So class frame would not be created with a constructor by default.
constructor would be an option in the MemberSelector if the class is concrete, and if there is not already a constructor. (By good fortune, it would be the first option offered (when present).
Parsing would have to be changed so that the constructor may be anywhere, or nowhere.

Absorbed into #984


Improve Sysinfo Front-end

Replace the "alert" prompt on  submit of the sysinfo page with a common used alert area.

Coverage remained the same at 53.3% when pulling 1c8c0756d8fae1a715dfcce2742d7b1e1db4e5f7 on hudson6666:master into e9aa998d5a8c11933ffb36e29add12d7fdc7dd0e on orvice:v3.


Project Naming (plus set correct meta information + contract name + constructor id)

Just so we don't forget it this time around :-)
Once we figure out the official name for the NFT we might also want to rename the contract filename (unless that's the name we roll with).
We might want to get that sorted soon so it's not a last minute change lol

The name in the contract is currently PXLDEV-UKRAINE. Is that ok, or should we change it?

@briangershon So far I've been rolling with Ukraine Donation NFT everywhere in the web client. I guess also given that the project is now quite independent from Pixel Devs except for the wearable part in the roadmap.
But maybe its worth playing around with the naming a bit to make it more interesting.. Quick brainstorm

Fund Ukraine
Support Ukraine
Humanity for Ukraine
Developer DAO for Ukraine
... Ukraine 4 Revolution? 😅

Feel free to come up with more ideas. If we have a few in the mix, we could share them in Discord.
Once we have a final name, perhaps we wanna update

[ ] Contract top comments
[ ] Constructor NAME + SYMBOL
[ ] Perhaps contract filename if we dare? :-)

/// @author Developer DAO
/// @title The Pixel Devs Ukraine Donation smart contract that is compliant to ERC721 standard.
contract PixelDevsUkraineDonation is

constructor() ERC721("PixelDevsUkraineDonation", "PXLDEV-UKRAINE") {

Hey @rasmuscnielsen I think we can run with "Developer DAO for Ukraine" naming.
We can make these changes as part of PR #30 which is wrapping up a bunch of odds'n'ends such as #28 #22 #14.
I'm happy to work on this as part of the effort to update the site based on new FAQ in doc. Or if you have any spare cycles, feel free to run with updating site title or anything there.

@briangershon Yes let's run with that one!
Please feel free to take on as much as you're comfortable with!
And as mentioned on Discord if there are any specific tasks you'd like my help with please feel free to bundle it and ping me. Then I'll try and fit it in before launch date (whenever that is lol).
Thanks for being a champ, Brian!


Color picker displays in background in bootstrap modal and when click on it, modal and colorpicker disappear

The Color picker displays in background in bootstrap modal and when click on it, modal and colorpicker disappear. This is what it looks like: https://s30.postimg.org/xbe7bzqn5/colorpicker_issue.jpg

Sorry, I cannot help you without a working example :
https://github.com/itsjavi/bootstrap-colorpicker/blob/master/CONTRIBUTING.md

Just ran into the same issue.
It's caused by the bootstrap class .dropdown-menu overriding the z-index specified in boostrap-colorpicker.css .colorpicker causing it to have a z-index of 1000 instead of 2500 so it ends up behind the modal. I don't have the time at the moment to create a fiddle but hopefully this helps a bit

Same kind of issue in a modal. colopicker appears at the end of the modal when using container: true or end of body without

Once clicked:

html code

×

Object type to add to graph:
Text type object
Image type object
Web URL type object
Text style:
large
medium
small
Text Color:

Text to display:
Image filename:

 Cancel
  Add


Remove the expanding boxes in the README

This makes the README completely unsearchable in the browser.

I agree, I don't find the folded boxes to be particularly useful. We could provide a table of contents with pointers to various sections already expanded.


API: input_value is ignored and not passed to Chat Input

Describe the bug
When calling API endpoint run/<flow_id> the input_value is suggested by code generator in Langflow UI, however after submitting request to the endpoint the input_value seems to be ignored and not passed into the Chat input node.
Version

Langflow v1.0.0a23

To Reproduce
Steps to reproduce the behavior:

Use template for flow Document Q&A

Go to the API section that will give you example on how to call the API.
Observe that in cURL and Python API examples input_value is suggested to be filled for prompt.

Attempt to call the API with input_value:

Observe that the prompt gets ignored.
Additional context
When using tweak on chat input, the flow behaves correctly:

Hey @radek3911
How are you?
Definitely a bug.
I'll get to it ASAP.
Thanks!


Update QuakeJS or replace with other browser client

QuakeJS is used for the browser client of Quake 3, and has not been updated in some time.  As detailed in https://github.com/inolen/quakejs/issues/44 the Emscripten tooling would need to be updated to recompile with a modern version of Emscripten.  The other alternative would be to integrate a new client into QuakeKube like the client used in planet_quake, however, this is probably also non-trivial and would need a lot of work to adapt to work with QuakeKube (most notably because it relies on SOCKS vs. the websocket proxy used in QuakeKube).
The goal of this would be improve compatibility/performance with browsers (e.g. Firefox doesn't work too well with the older client), and to potentially introduce the ability to use custom games.

+1

"relies on SOCKS" isn't quite  accurate. It will make websocket requests directly to quakejs servers if you want it to. I only use the SOCKS stuff to get the "Multiplayer" menu working with traditional native Q3 servers. It actually works as a SOCKS proxy for your whole computer, OR it also adds a websocket connection on top of the normal TCP way of controlling the proxy to support the web client.
Aside from the Q3 specific network logging the SOCKS proxy is a fully working SOCKS 5 proxy server.
https://github.com/briancullinan/planet_quake/blob/master/code/xquakejs/lib/socks.server.js
I've also considered adding the websocket protocol directly to the engine and not relying on the proxy or the dedicated JS build. This would probably be more similar to how the quakejs server works now. I just found it cringy to compile a "native" server to a non-native architecture like Nodejs. Seemed kind of counter productive since these 2 other (imho better) options became clear.
https://github.com/rohanrhu/cebsocket

Thanks for replying, this is good to know!
I agree completely wrt to the NodeJS version of ioq3ded, it ran so poorly (by like a factor of 20 times or more) which is why I ended up making a websocket -> udp proxy that runs in the backend:
https://github.com/criticalstack/quake-kube/blob/master/internal/quake/client/proxy.go
It ends up allowing using any vanilla implementation of the Quake 3 dedicated server, which is why we are using standard ioquake3 atm for dedicated servers.  The only thing left from QuakeJS being used is the browser client, so do you think it would be as easy as building the planet_quake js target and then passing similar args in this fashion? https://github.com/criticalstack/quake-kube/blob/df74971b73f344a3bed1ac48db33f96338fd8423/public/index.html#L139-L150
Interested to know your thoughts, if we could use planet_quake without much fuss that would be awesome!

Yes, of course. Those arguments are a feature of emscripten. My build still uses emscripten, but someday I hope to move away from it and only implement the OS features Quake 3 refers to in libraries. This is where I am making exceptions for specific configurations, it would be trivial to clean this up and add something for kubernetes use case:
https://github.com/briancullinan/planet_quake/blob/master/code/xquakejs/sys_main.js#L162
I think the easiest thing to do would be to add kubernetes configuration to planet_quake, then combine the features we like. Q3e is being maintained. They have a lot of bug fixes from other engines plus tons of performance enhancements. UrT engine, defrag engine, happy Diesel, and probably a handful more I don't know are all built from Q3e.
I actually started with a plain old UDP proxy, that is hanging around here, suggested by another member:
https://github.com/briancullinan/planet_quake/blob/master/code/xquakejs/bin/proxy-simple.js
But the problem became clear, that proxy would only access 1 or a specific number of endpoints based on some sort of control code. But a general proxy like SOCKS is controllable by the client. But with websockets in-between it's not quite so vulnerable as an open proxy. I could support passwords, and I'm using it over https/was with Google Cloud load balancer.
I needed an excuse to learn to use kubernetes and it might be nice to run these as separate processes.

It would be amazing if there was like a 1 click run button for a few cloud providers that basically does all of this, scaling as needed for each service. If I was to properly split up the Dockerfile in to separate processes based on demand and resources. This is the stack we need for the complete project:


cmd/compile: spurious unused errors for used imports in expected function calls e.g defers and go

What version of Go are you using (go version)?
go version go1.9.2 linux/amd6
Does this issue reproduce with the latest release?
yes
What did you do?
package main

import "fmt" // error: imported and not used: "fmt"

func main() {
	defer func() {
		fmt.Println()
	}
	go func() {
		fmt.Println()
	}
}

What did you expect to see?
./a.go:8:3: expression in defer must be function call
./a.go:11:3: expression in go must be function call

What did you see instead?
./a.go:3:8: imported and not used: "fmt"
./a.go:8:3: expression in defer must be function call
./a.go:11:3: expression in go must be function call

@griesemer I think the case in your comment is acceptable.
After all, deferred function not called is a more serious error than a variable not used.

The root cause for the current behavior is that the check that the defer expression is a function call happens at parse time; and if there are parse errors the compiler stops (and doesn't bother type-checking the code).
In this case it may make sense to move that test to later (out of the parser) for a couple of reasons: 1) it is quite common to make the mistake of forgetting to call the deferred function; and 2) the syntax actually doesn't state that the expression must be a function call, that restriction in made in prose. As a general (but not hard and fast) rule for the parser, syntactic restrictions that are in prose are handled outside the parser.


Task fails with Gradle 7.0.2

Before filing an issue please check the issue is not already addressed by the following:

Github Issues
Changelog

Describe the bug
When running the task with Gradle 7.0.2, an error is thrown:
A problem was found with the configuration of task ':myApp:measureSize' (type 'MeasureAndroidLibrarySizeTask').
  - Type 'com.twilio.apkscale.tasks.MeasureAndroidLibrarySizeTask' property 'ndkVersion$apkscale' is missing an input or output annotation.

    Reason: A property without annotation isn't considered during up-to-date checking.

    Possible solutions:
      1. Add an input or output annotation.
      2. Mark it as @Internal.

    Please refer to https://docs.gradle.org/7.0.2/userguide/validation_problems.html#missing_annotation for more details about this problem.

To Reproduce
Steps to reproduce the behavior:

run gradle myApp:measureSize

Version

Version: 0.1.2
Gradle: 7.0.2
AGP: 7.0.2

Hey @guillaume-tgl
This issue will be resolved once #8 has been merged and released as 0.1.3. I have published 0.1.3-SNAPSHOT that should resolve this issue #9 and #5
You can pull in the 0.1.3-SNAPSHOT by adding the following to your build.gradle.
        maven {
            url 'https://oss.sonatype.org/content/repositories/snapshots/'
            mavenContent {
                snapshotsOnly()
            }
        }

        classpath "com.twilio:apkscale:0.1.3-SNAPSHOT"

Thanks!

Excellent! I'll try the snapshot version and let you know if I have any issue.

Fixed in 0.1.3


Bug: 3d molecule views broken after export

Problem only occurs after resizing window after exporting.
Picture: http://puu.sh/le2Jx/81c2da5766.jpg
Reproducing: Select at least one input set so graph is drawn. Click export. Resize window.
Estimated 2 man-hours.

Fixed with replacing export method.


Growing memory beyond maximum limit does not fail

Given the following module:
(module
  (import "env" "memory" (memory 1 1))
  (func $main (export "main")
    (i32.store (i32.const 0) (grow_memory (i32.const 1)))
  )
)

I expected the following test to fail:
// lucet-runtime-tests/src/memory.rs
#[test]
fn grow_memory_beyond_max_size_hostcall() {
    let module = test_module_wasm("memory", "grow_memory_beyond_max_size.wat")
        .expect("compile and load grow_memory_beyond_max_size.wat");
    let region = TestRegion::create(1, &Limits::default()).expect("region can be created");
    let mut inst = region
        .new_instance(module)
        .expect("instance can be created");

    inst.run("main", &[]).expect("instance runs");
}

However, it completes successfully.
Shouldn't inst.run return LimitsExceeded Error?

Hi @lostman,
This is actually working as expected. The semantics of the Wasm grow_memory instruction are that it returns -1 if it is unable to allocate the requested memory. So, the result of the (grow_memory (i32.const 1)) expression is -1, which then gets stored at linear memory address 0, and then main returns normally.
Other interfaces for changing the heap size, such as Instance::grow_memory() do return a LimitsExceeded error if the request is too large, but we translate that error to a -1 if the call is coming from a grow_memory instruction running in the guest.
I'm going to go ahead and close this issue, but feel free to ask any follow-up questions, and thanks for checking out Lucet :slightly_smiling_face:

@acfoltzer Thank you for clarification. That makes sense.


Removing old Python version checks

Description
Removing Python prior to 3.11, as all the services using this library are using Python 3.11 or later.
(Commit to ensure proper configuration of CI)
Type of change

Bump-up dependent library (no changes in the code)

Testing steps
N/A
Checklist

[ ] pre-commit run -a passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.13%. Comparing base (e78acf5) to head (e4149bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   83.09%   83.13%   +0.03%
==========================================
  Files          30       30
  Lines         923      925       +2
==========================================
+ Hits          767      769       +2
  Misses        156      156

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fava: modernize expression

Motivation for this change
use pytestCheckHook
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The error that occurs in test_cli can also be reproduced by running fava -d. That's something the maintainers should look into.
cc @matthiasbeyer

Would you like to take maintainership of this package? I'm not using it anymore, and I think its better if someone who uses it also maintains it, if possible.

I use hledger.
Maybe @bhipple, the maintainer of beancount, wants to take over?

I haven't used fava yet, but I've been meaning to try it out and can help maintain it.

@bhipple Will you make a PR adding yourself to meta.maintainers?

And remove me in the same commit, with an appropriate commit message (feel free to add a Suggested-By trailer).


.sdkrc to store versions for specific directory

@musketyr commented on Tue Aug 30 2016
I would be great if there is alternative to .nvmrc file in NVM.
Given .sdkrc file in current directory with following content
grails=3.2.0.M2

When I run sdk use
Then grails version 3.2.0.M2 is downloaded if not present yet
And grails version 3.2.0.M2 is used in current shell

@marc0der commented on Wed Aug 31 2016
This is already mostly supported in the sdkman-extensions project by way of the sdk switch command. Feel free to give it a try and/or raise any PRs on this to improve it.

@musketyr commented on Wed Aug 31 2016
this looks it's doing way too much magic and does not work for every candidate supported. I would prefer having separate file. let's keep this option open.

@marc0der commented on Wed Aug 31 2016
For sure, it's not in a great state.
Is that you volunteering to write a new extension? :-)

@marc0der commented on Wed Aug 31 2016
Moving this issue over to the sdkman-extensions project, as this will not be implemented in the CLI.

What is the state on this?
Had the same thought today. Since "[SDKMAN!] was inspired by the very useful RVM and rbenv tools", it seems natural to expect that it would be easy to set up per-project settings.

Feel free to write an extension that will perform the switching. What makes sdkman different from the likes of rvm is that it is completely agnostic of what it's serving so the sdkman core cannot be coupled to one specific technology.

Maybe I misunderstood above discussion; I for one wasn't thinking about coupling to any specific technology. I was thinking, how do I use sdkman to say,

"always use Java 8 for this here project, but Java 10 for that other one"
(useful for development multiple projects, each with different SDK dependencies), or
"install exactly the SDKs this project needs, into the current directory, and then use those"
(useful for CI build environments that don't use Docker or similar).

For the config part, having a file like e.g. a Gemfile in the project repo, let's call it .sdkman, seems prudent. It could look as simple as this:
java 8.0.181-oracle
gradle 4.9

Some command would check the path for such a file, chdir there, install what's needed, and use them. (Arguably, sdk install would be a good choice since that's what other tools use, but would probably break expectations of sdkman users, who are used to sdkman acting user-globally.)
For the "install into the current folder" part, I think temporarily changing SDKMAN_CANDIDATES_DIR should do the job.

Feel free to write an extension that will perform the switching

Fair enough; what's your timeline on that rewrite? Even if I need this enough at some point to sit down and write it, I'd hate to wrestle with Bash only to have the effort evaporate shortly thereafter.

Ohhh, sdk-switch is specific to Gradle! I was mislead by the title and general gist of the issue, my bad.
My feature request/idea/brainstorm stands, though. :)

Closing this in favour of https://github.com/sdkman/sdkman-cli/issues/683


Check/Update cookiecutters

Check to see if we need to make any updates to the cookiecutters to start using the new theme by default in new projects.

This was done with https://github.com/openedx/edx-cookiecutters/pull/305


Android Back Button is not handled properly?

Current Behavior
I am developing a trivia game, I have 3 components, (newGame, Questions, Results ) I don't want the user to go back to the questions from the results page if the no. of questions has been exhausted, however, pressing the back button ( Android Hardware ) is taking him back to the questions. I then tried to handle the hardware back button like so:
componentWillMount() {
      this.props.gameState(true);
      BackHandler.addEventListener('hardwareBackPress', () => {
        if (this.props.gamePlaying) { // Currently set to true. I will set it to false again on NewGame Page.
          this.props.navigation.navigate('NewGame');
        }
      });
    }

However, this is taking the user to the NewGame screen but immediately, it is bouncing back to the results page as it is firing the NAVIGATION/BACK as well immediately in the NewGame page. Which is again taking it back to the results page.
Possible fix?
I want to stop the the back button to fire after I have landed in the NewGame component page. Is there a way to do it?
My Environment

software
version

react-navigation
^1.0.0-beta.11

react-native
0.44.0

node

npm or yarn
yarn

return true; at the end of the handler to prevent the default.

Going to assume the comment left fixed the issue since there wasn't a followup - thanks @dave-irvine!


16-bit bone IDs are needed (3D)

Godot currently supports up to 255 bones (or less, can anybody clarify?)
This is not enough for more dense game characters which tend to use 300-400 bones these days. Can we increase the bone ID size so that Godot can be used for that kind of fidelity?
I know you can live with like 30 bones and be happy, but still...

If you are able to import the model on the upcoming asset import pipeline, the system will split the mesh if it has too many bones.

16-bit bones already exist for gles3. Not in gles2 though.

Where can I have a taste of upcoming pipeline?
Automatic mesh splitting is a good thing. Also can I actually know the bone
limit somehow?
Also what determines the bone count?
On Thu, Mar 28, 2019 at 8:03 PM K. S. Ernest (iFire) Lee <
<EMAIL_ADDRESS>wrote:

16-bit bones already exist for gles3. Not in gles2 though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/27483#issuecomment-477682526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAX0yesI94ql4ogDAzI4Q2QuVb1Z2Y3ks5vbPRsgaJpZM4cPwgE
.

Also I'm interested in both GLES2 and GLES3, as I have low end targets too.
On Thu, Mar 28, 2019 at 9:43 PM Sergey Lapin<EMAIL_ADDRESS>wrote:

Where can I have a taste of upcoming pipeline?
Automatic mesh splitting is a good thing. Also can I actually know the
bone limit somehow?
Also what determines the bone count?
On Thu, Mar 28, 2019 at 8:03 PM K. S. Ernest (iFire) Lee <
<EMAIL_ADDRESS>wrote:

16-bit bones already exist for gles3. Not in gles2 though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/27483#issuecomment-477682526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAX0yesI94ql4ogDAzI4Q2QuVb1Z2Y3ks5vbPRsgaJpZM4cPwgE
.

@slapin I'm guessing that's referring to this pull request.
https://github.com/godotengine/godot/pull/23837

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Cross-Origin Read Blocking

My chrome extension starts throwing the 'Cross-Origin Read Blocking' error recently.
Unfortunately, the 'content_security_policy' option has no effect.
I did also add the domain of the website I am running extension on into the 'Authorised domains
', but it didn't help.
The only way to use the extension is to run chrome without security(--disable-web-security)'.
it is a private extension, so I don't mind running the browser without web security. but wondering why its start happening recently.
Any idea why is that?
Chrome Version: 73.0.3683.75
Windows 10 64
Thanks

I have same problem but no solution. :p

solution: https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

ahh, more restriction :p , thanks for the link.


Module 'ngRaven' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

This is my order of files in karma.conf.js for running karma jasmine uint tests..
files: ['app/bower_components/jquery/dist/jquery.min.js',
'app/bower_components/angular/angular.min.js',
'app/bower_components/raven-js/dist/raven.js',
'app/bower_components/raven-js/plugins/angular.js'
]
Event though I included  'app/bower_components/raven-js/plugins/angular.js' I'm getting the error stating the module 'ngRaven' is not available.

+1

Fixed ..
http://stackoverflow.com/questions/35980078/module-ngraven-not-available

Is there something actionable we can do here? I'm a bit confused. :)

Oh, jk, I read the Stackoverflow. It works with the angular-raven package, but not ours.

Per the current documentation, the sentry angular plugin should now work
https://docs.getsentry.com/hosted/clients/javascript/integrations/angular/

Might be the directory 'dist' missing in 'app/bower_components/raven-js/plugins/angular.js'?
According to docs [https://docs.getsentry.com/hosted/clients/javascript/integrations/angular/#bower] it should be:
<script src="/bower_components/raven-js/dist/plugins/angular.js"></script>

Following the documentation angular can't find the module for me. The stack overflow solution works for me though.

Might be the directory 'dist' missing in 'app/bower_components/raven-js/plugins/angular.js'?

That would definitely do it.
If somebody here could provide me with a concrete example, I'd be glad to dig into this.

@benvinegar https://plnkr.co/edit/S1Dk9t?p=preview this is a simple sample of the error,
Based on https://github.com/getsentry/raven-js/blob/master/docs/integrations/angular.rst
It says:
Note that this CDN build auto-initializes the Angular plugin.
But importing only that as the docs says throws an error, please check the log in the plnkr
[$injector:nomod] Module 'ngRaven' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
Maybe this is just a misinterpretation of the docs?

Any news on this? I think the angular plugin only works for CommonJs, since  this is actually never called when just including the file. Please fix so we can use the plugin

Here is the simplest example following your integration page that does not work: https://plnkr.co/edit/M5nt6Y?p=preview

@RobertBaron @mebibou – in both examples you need to configure Raven before initializing your app. Plugins aren't initialized until Raven.install() is called.
This is in all the documentation examples, for example:
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>
<script src="https://cdn.ravenjs.com/3.6.1/angular/raven.min.js"></script>
<script>Raven.config('https://<key>@app.getsentry.com/<project>').install();</script>

Oh ok this actually goes against the Angular way where we usually do this kind of configuration in a module that would require ngRaven, but doing this way makes it impossible.
I think you should specify this in the documentation as it is not specified at all.

+1

See #413, @benvinegar Is it ready to tackle?

@Sija – given that people keep tripping up on this, I'm fine with merging. Though I'm worried about the case where someone might have declared Raven before Angular. But at least CDN users need to upgrade manually.

Don't forget to add this between Raven.config and .install() as per the doco.
.addPlugin(Raven.Plugins.Angular)

@theatrain besides that you need to  add an override on your package.json if using gulp inject or anything similiar that includes packages onto your html automaticly.
The following bellow was my fix since i use gulp-inject
        "raven-js" : {
            "main": [
                "dist/raven.js",
                "dist/plugins/angular.js"
            ]
        }
    },

I found a good workaround for grunt as well since everything was uglified and minified:
My app.js looked like:
'use strict';

angular
  .module('sraApp', [
    'ngRaven'
  ]);

I made another file called raven.js
// redacted sensitive info
Raven
<EMAIL_ADDRESS>  .addPlugin(Raven.Plugins.Angular)
  .install();

And in the index.html instead of inline scripts:
<!-- build:js(.) scripts/vendor.js -->
<!-- bower:js -->
<script src="bower_components/angular/angular.js"></script>
<script src="bower_components/raven-js/dist/raven.js"></script>
<!-- endbower -->
<!-- Outside of auto-managed bower, but still inside compile -> vender.js -->
<script src="bower_components/raven-js/dist/plugins/angular.js"></script>
<!-- endbuild -->

<!-- build:js({.tmp,app}) scripts/scripts.js -->
<script src="scripts/raven.js"></script>
<script src="scripts/app.js"></script>
<!-- endbuild -->

Now when I grunt build:dist which uglifies/minifies grunt will optimize my script so the plugin can be registered. Doing inline scripts won't cause the optimization so window.angular won't be right for the plugin to autoload itself.
Overall the flow is as follows (documentation is correct)

bring in angular
bring in raven
bring in raven/plugins/angular.js
config/addPlugin/install ngRaven but done properly to take into account uglification/minification

Any update on this? Also got problems here with our karma test suite.

@xeroxoid We also had problems with this during karma tests and were able to get around it.
In our case we were skipping the Raven.config().addPlugin().install() routine in the test environment because we didn't want them to be sent to sentry.
The problem with that is raven-js doesn't do things "the angular way" with modules - and instead only registers the ngRaven module if you called Raven.config() with a DSN.
The addPlugin() method only registers the angular module if the config was setup correctly (eg with a defined DSN url).
To fix this, we made it so that Raven.config().addPlugin().install() is always run even on our test suite, we use our normal DSN url and then use the config.shouldSendCallback method to block sending to sentry in the test environment.
This allows raven-js to properly register the angular module.
Hope that helps!

We're doing the same, but we pass a fake DSN in instead (this is for our dev env). Something like<EMAIL_ADDRESS>works fine (raven appears to do some amount of enforcement on the properties of the URL, so the username must be present along with the path).


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.113

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.113


Provide basic configuration with toml file

For example,

Storage base dir: RaftServerConfigKeys#storageDir
Log size threshold that triggers the snapshot: RaftServerConfigKeys.Snapshot.setAutoTriggerThreshold
Peers information.

I think peers information is another topic more complex. Leave as future work.


Update last line of rules in regards to where to get help

As suggested by S2ymi

Merging based on moderator vote: https://discord.com/channels/920776187884732556/1151465196871753738/1273676901759717438


Added Msn Emojis (Windows Live Messenger)

Added Msn Emojis. (Windows Live Messenger)

Be right back
Cigarette
High 5
Xbox
Turtle
Crossed fingers
Age, sex, location
Handcuffs
Smile
Grin
Suprised
Tongue smile
Wink
Sad
Confused
Disappointed
Crying
Shy
Cool
Angry
Angel
Devil
Don't tell
Teeth
Dull
Sarcastic
Telling secrets
Sick
Don't know
Thinking
Party
Rolling eyes
Drowsy
Coffee
Thumb up
Thumb down
Beer
Cocktail
Girl
Guy
Guy hug
Girl hug
Bat
Cake
Heart
Broken heart
Kiss
Present
Rose
Wilted rose
Camera
Film
Cat
Dog
Phone
Lightbulb
Music note
Sleeping moon
Star
Envelope
Clock
MSN Messenger icon
Snail
Black sheep
Plate
Pizza
Soccer
Car
Airplane
Umbrella
Island with palm tree
Computer
Mobile phone
Storm
Lightning
Money

@tahaipek if you can make the changes @hugovk suggested, I will merge this!

Hey there @tahaipek  , I'm closing this PR for now but feel free to open it back up later on if you'd like if it's still relevant!


Update README.md

Codecov Report

Merging #16 (ea92d38) into main (1c98a8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   44.58%   44.58%
=======================================
  Files          59       59
  Lines        7131     7131
=======================================
  Hits         3179     3179
  Misses       3952     3952

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c98a8d...ea92d38. Read the comment docs.


NPM Install stuck on 0.22.0

I went to upgrade my project to 0.22.0, and it 'froze' on one of the packages. I tried all different things to make sure it wasn't network related. I couldn't pinpoint the issue (none of my troubleshooting worked).
I then put it back on 0.21.0 and it works perfectly.
I completely uninstalled npm and node to do a 100% fresh start:
$ npm -v
3.7.3
$ node -v
v5.9.0

I still have the same issue. It's hard to tell what the exact problem is, because when I run npm install react-native --verbose it cuts off the package name, and also doesn't give any useful info that I can see.
This is where it hangs though:

There is also a few of these sporadically thrown in the output:
retry will retry, error on last attempt: Error: read ECONNRESET

However, I'm not using a proxy (apparently causes that error a lot) and doing npm install when its 0.21.0 works 100% so I don't think it's anything like a service being down or my internet.

Is it possible it's as simple as github having issues that seem to have been solved just? https://twitter.com/githubstatus

This happened about an hour prior to GitHub going down.
Also, I tried again just now, works with old version, new version still hangs.

FYI here's the further discussion on Facebook group with some logs & screenshots https://www.facebook.com/groups/react.native.community/permalink/740000516135529/?comment_id=740072162795031&reply_comment_id=740096302792617&comment_tracking={"tn"%3A"R0"}

same here

Martin Konicek Ah, it might be that --verbose doesn't work on Windows. Could you create a separate GitHub issue for that?
Another thing you can try:
react-native init should create a folder called TestApp. Do the Windows equivalent of these commands:
cd TestApp
rm -rf node_modules
npm install --verbose --save react-native
rm -rf node_modules rm is not windows command ;) something is processing ill give you quick update in some minutes.

If you try again does it get stuck at the same point? Not sure what's wrong.
If you put 0.22.0-rc3 in your package.json and do rm -rf node_modules; npm install does it work? What if you put ``0.22.0-rc` there? Just trying to understand what's happening on your machine. For me it works with 0.22.0 but I'm on Mac OS.

If the above doesn't work you could also try with npm 2, I have:
$ node -v
v4.3.1
$ npm -v
2.14.22

We test with npm 3 on CircleCI (Unix) and my colleague just tried npm 3 on a Mac. We don't have any Windows machines around or automated tests on Windows unfortunately :(

btw im using react-native-cli... what version of it is 0.22.0-rc ?

anyways 0.22.0-rc downloads ok but on react-native init testapp i get only this json in folder.
{"name":"testapp","version":"0.0.1","private":true,"scripts":{"start":"node node_modules/react-native/local-cli/cli.js start"}}

@mkonicek It's broken on OSX for me btw.
$ npm -v
3.7.3
$ node -v
v5.9.0

It also gets stuck at the same spot for me as it does @rpdiss

0.22.0-rc3 appears to be the last working version for me

so what should i do ?:) remember that im using react native cli and w10... i cant install react-native globaly;p

Ok i got temp fix this editted
`%appdata%\Roaming\npm\node_modules\react-native-cli\index.js
line 191  exec('npm install --save<EMAIL_ADDRESS>function(e, stdout, stderr) {
`

0.22.0-rc3 appears to be the last working version for me, everything after has same problem.

This is super useful, thank you @9mm! I'm thinking this could cause it also still not sure why only for some people: https://github.com/facebook/react-native/commit/cafbeb08feb9f7694f45a3f307cb90ce8344c959
@rpdiss You can do the following until we ship a proper fix (hopefully tomorrow):
# The version of react-native-cli doesn't matter
rm -rf TestApp
cd TestApp
in package.json remove react-native from dependencies
rm -rf node_modules
npm install --save<EMAIL_ADDRESS>
This is pretty much exactly what the CLI (react-native init did after you made the change to it).
Does it work for you now?

Can you guys both confirm that 0.22.0-rc3 works for you? If yes I'll release a hotfix, reverting cafbeb0.

Confirm screen :dancers:

Nice!!

Thank you @rpdiss.

but i edited the index.js cuz rm -rf is not windows command @mkonicek

Ah, I think it's rmdir on Windows :)

@rpdiss @9mm I've just published 0.22 reverting cafbeb0. react-native init should work now out of the box (no local changes to CLI needed). Can you verify please?

Works now!

Amazing, thank you!

@rpdiss Are we good to close this one? Thanks for the help debugging!

I'd be curious to know what that was, why it broke.. if you ever come across the answer.

ye im okay even working on device :+1:

cc @bestander, I had to remove the shrinkwrap. Two different people narrowed it down to exactly that same commit that added shrinkwrap (rc4 hanged in npm install, rc3 worked): https://github.com/facebook/react-native/commits/v0.22.2

Thanks so much guys! I'll close this issue. Updated the fb thread.

npm-shrinkwrap was added to the package in case we have a downstream break of dependencies, having all dependencies locked could give some assurance that install will keep working.
I suppose we will have to abandon idea of shipping shrinkwrap, considering all the hiatus it gave us in the recent few releases.
This bug I suppose was caused by some dependency that installs fine on Linux (our CI) but gets stuck on Windows.
npm-shrinkwrap is OS dependent and generates the tree based on what is installed in the system it is generated on.
cc @skevy

Damn. Ok. Thanks @bestander and @mkonicek. It's too bad, but until shrinkwrap's mechanics change some day this the right call. :-/

Thanks to everyone on this thread for narrowing down the issue.


RouterLocation is missing after update ... again!

Describe the bug
Why you still removing files/classes without the deprecation step? This is so unprofessionell!
And what is the docu saying? Nothing...
Expected-behavior
No response
Reproduction
update
System Info
24.5.7

Hi, could you provide more information on the issue? Is this a Hilla Lit project? From which version was the upgrade?

24.5.2 and of course lit.

If not, I suspect the issue could be that the React library and dependencies were installed instead of the Lit ones. Please try if the explicit opt-out would help: https://vaadin.com/docs/latest/upgrading#opting-out-of-react

Idk, I don't wanna make that update again. To many errors...
Maybe the next larger version.


Security issue

[Enter feedback here]
The powershell command ask the user to run powershell -ExecutionPolicy Unrestricted but does not indicate to set it back to its default value

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05581e98-a835-1277-3cef-aea6221d9065
Version Independent ID: e2b54d7d-8f38-5118-ef85-ce9b16da291f
Content: Register new devices yourself - Microsoft Managed Desktop
Content Source: microsoft-365/managed-desktop/get-started/register-devices-self.md
Product: w10
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@FlorentReynal Thank you for your feedback. We have added a note about the same and it can be tracked via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3438
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @FlorentReynal Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


js picker save v.7.0 with dataURI problem

I am trying to integrate with the js picker (v.7.0) to store files in your platform as described in https://dev.onedrive.com/sdk/js-v7/js-picker-save.htm.
As I need to add files to OneDrive for Business/SharePoint accounts, my only option is to provide the sourceURI parameter with the full dataURI of the file.
Now as I am trying to save medium size files of 5MB<25MB, the full content is appended in the query string of the redirectUri (openInNewWindow=true), resulting in a long URL which causes a "Bad Request - Request Too Long" problems once the redirect starts to your servers.
Is there anyway to avoid that the full dataURI is passed via URL but have to use a POST instead?
Also, at the moment the demo page for the picker save (https://dev.onedrive.com/sdk/js-v7/js-picker-save.htm) seems to be broken and a message in console is given "Uncaught Error: [OneDriveSDK Error] please specified one type of resource to save". This is tested in Chrome 56.
Here is my full integration code:
OneDrive.save({                                     action: 'save',                                     clientId: 'my-app-id',                                     openInNewWindow: true,                                     success: function(){console.log("succes");},                                     progress: function(){console.log("progress");},                                     cancel: function(){console.log("cancel");},                                     error: function(){console.log("error");},                                     advanced: {                                         redirectUri: '/onedrive-redirect.html'                                     },                                     fileName: 'myfile.pdf',                                     sourceUri: 'data.......' // full dataURI of the file content                                 });

hi @nerazzurro80 , currently the picker only support dataUri uploading for OneDrive Consumer account. The best approach for save a file in picker is using the sourceInputElementId.

Thanks @daboxu , I have tried that but getting Uncaught Error: [OneDriveSDK Error] please specified one type of resource to save, same error I get by using the demo page (https://dev.onedrive.com/sdk/js-v7/js-picker-save.htm). Is there a fix planned for that?

@nerazzurro80 I have a pending fix for the demo page and you see this issue because SDK didn't find the option attribute 'sourceInputElement' which is uploading local file nor 'sourceUri' which is uploading data uri. Try specify the input element id like OneDrive.save({..., sourceInputElementId: '', ...}). Let me know if it works.

Hi @daboxu, thanks for your reply. I have tried your suggestion and it fixes the demo page.
In our application though, we don't want to manually upload a local file but we have the content of the file (javascript Blob with dataURI) and we need to upload that programmatically.
Setting the value to an input file via javascript is not possible for security reasons as far as I know but an user action to select a file is required.
What would be the best option to post file contents without having the user to browse her drive?

Hi @daboxu, do you have any idea on how we can implement what is described above? Thanks!

hi @nerazzurro80 sorry for late reply, unfortunately the picker SDK does requires user picking up file as required, while we do have Graph SDK which you interact with Microsoft Graph API which doesn't have any user interaction and it talks to OneDrive as well. Probably it will help.

feel free to reopen it if you have any questions


API: switching the Fluid service should be simpler

tinylicious is the recommended developer server and the API requires the usage of the getTinyliciousContainer API call, but using such a dedicated function call means that we  can't easily swap Fluid service making the API brittle and hard to discover.
Suggestion:
Move from something like this:
import { getTinyliciousContainer } from "@fluidframework/get-tinylicious-container";

async function start(): Promise<void> {
    const container = await getTinyliciousContainer(documentId, DiceRollerContainerRuntimeFactory, createNew);
}}

To something more like this:
import { containerRetrieval } from "@fluidframework/get-tinylicious-container";

async function start(): Promise<void> {
    const container = await containerRetrieval(documentId, DiceRollerContainerRuntimeFactory, createNew);
}}

Where both tinylicious and routerlicious exposes the same API to get a container (with potentially optional params or a config call)

I think @SamBroner already satisfied this with #3610


Druid 0.13 ~ 0.18 version roaringbitmap benchmark becomes slow

Affected Version
Druid 0.13.0 ~ Druid 0.18.0
Pull down druid0.13 and druid0.18 version from the community. After compiling, run their respective benchmarks (The command is java -jar benchmarks.jar BitmapIterationBenchmark -p bitmapAlgo = "roaring") on roaringbitmap. It is found that the druid0.13 version can be run within ten minutes. The druid0.18 version requires More than an hour, and the results ran out not as expected. There are two cases of Druid 0.18 version which is much slower than Druid 0.13 version.
The roaring bitmap used by the druid 0.13 version is version 0.5.18, and the roaring bitmap used by the druid 0.18 version is version 0.8.11.
All data below comes from mac, 6 CPUs, 16GB memory.
I have also tried it on a server with 48 CPUs and 250G memory, and the results are similar, indicating that the test results are not related to large machines
Benchmark test results of druid 0.13 version:

Benchmark test results of druid 0.18 version:

The above benchmarks have been tested many times and the results are similar.
Below is my troubleshooting process：
Phenomenon 1: The total time of the benchmark becomes longer
Observed that the execution of the benchmark from 0.15 to 0.16 slowed down (not sure why), running bitmapAlgo = "roaring" -pn = 100 -p prob = 0.1 alone, the benchmark time increased from 40s (0.15) to 6min (0.16)

Phenomenon 2: Average time of two specific cases becomes larger
In the two intersectionAndIter cases (n = 100, prob = 0.1) (n = 100, prob = 0.5) of 0.13 ～ 0.14, the sorce increased obviously, from 300w ～ 500w (0.13) to 100 ～ 200 million (0.14)
case 1(n=100.prob=0.1)

case 2(n=100.prob=0.5)

Although the phenomenon 1 will slow down the benchmark execution, I don't think it will affect the performance. I think what really affects the performance is the sorce value of the two cases in the phenomenon 2, so I will try to analyze the reason why the sorce value of the two cases rises.
From the test data analysis phenomenon 2 reasons for the rise of Sorce:
Based on the Druid 0.13 version code, I replaced the roaring bitmap version, and the test results obtained are recorded as follows:

Observed from the data in the table, after the code change of # 6764 in the community is completed, the sorce of the above two scenes rises significantly.
Analyze the reason for the rise of Sorce from the flame diagram:
Modified the benchmark code to only run the two scenes that are slower in the above figure (prob = 0.1, 0.5), run multiple times in the Druid0.13 and Druid0.14 and grab the flame chart as follows (because the fork of the benchmark is set to 1 , So every time a case is run, a child process is forkd out to run, so the flame graph not only captures the main process, but also captures the child process of the specific scene):
Druid0.13 benchmark main process

Druid0.13 child process: intersectionAndIter when prob = 0.1

Druid0.13 child process: intersectionAndIter when prob = 0.5

Druid0.14 benchmark main process

Druid0.14 child process: intersectionAndIter when prob = 0.1

Druid0.14 child process: intersectionAndIter when prob = 0.5

Druid0.18 child process: intersectionAndIter when prob = 0.1

Druid0.18 child process: intersectionAndIter when prob = 0.5

The above flame chart has been grabbed multiple times, one of which was randomly taken
From the above flame chart, it is observed that different versions of Druid use different Containers to take intersections in roaring bitmap. Druid version 0.13 uses ArrayContainer or bitmapContainer, but Druid 0.14 and later versions use RunContainer (because of the grabbed Both 0.14 and 0.18 flame charts use RunContainer, so it is speculated that the versions from 0.14 to 0.18 are all used RunContainer)
I think that RunContainer's compression efficiency under this benchmark is not good, because looking at the construction code of fake data, I found that the distribution of fake data is very sparse and the values are not continuous.
Code to construct fake data：

Observing the setup code, it is found that the initialized bitmap is very sparse and the values are not continuous. In this scenario, I think RunContainer does not have the high compression efficiency of BitmapContainer and ArrayContainer, which may cause some performance problems.
Conclusion: The code change of # 6764 in the community may be related to the use of RunContainer when the Roaring bitmap benchmark is constructed. It is necessary to further observe the impact of the # 6764 code to analyze,I hope everyone can help to see some of these problems, the above is just my personal analysis

The code change in #6764 aimed to improve the performance of bitmap construction, and it applies run compression as the bitmap is built, but only to containers which are run-compressible. If this results in slower intersections in some cases, this can be fixed in the RoaringBitmap library; some changes were recently made to significantly improve run vs bitmap andCardinality and intersects and these changes are applicable to run vs bitmap and.
Note that #6764 will not have changed any behaviour when the roaring bitmaps have been memory mapped from disk and where run compression has already been applied (immediately before construction), which might explain if no regression has otherwise come to light since the change...


UIM storage

Could there be a way to show contents of the looting bags, seedbox and death storages? Would be really nice for UIM streamers.

Hi there, thanks for the suggestion! What would you think would be a good way of showing these storage boxes? A dedicated tab like the current inventory / equipment / bank one? Or an overview that is visible when hovering over the looting bag / seedbox in the inventory tab? Been considering this for the rune pouch as well, would be nice to find a shared way to make it work for all of these items at once.
For the death storages I see quite a challenge, because there are a few to take into account.. Each container for items requires quite some work to implement with both the Runelite Plugin and Twitch Extension.

Closed due to inactivity, will look at this feature later. For now collection log has priority.


Intercept Ajax

Great wrapper! I switched to using this because of Laravel's data integration.
Just one thing though, I tried intercepting the ajax requests because I want to setup a fullscreen loading component and remove after successful draw.
What I tried so far is to use jQuery
  $.ajaxSetup({
        beforeSend: function (xhr,settings) {
            console.log('beforeSend')
        },
        ajaxComplete: function(xhr, settting){
            console.log('ajaxComplete')
        },
        ajaxError: function(){
            console.log('ajaxError')
        },
        ajaxStart: function(){
            console.log('ajaxStart')
        },
        ajaxStop: function(){
            console.log('ajaxStop')
        },
        ajaxSuccess: function(){
            console.log('ajaxSuccess')
        }

    });

Only the beforeSend event is being triggered. I will appreciate some guidance. Thank you for your wrapper!

@ruelluna I believe it's behaving correctly, as you have described, per documentation here: https://api.jquery.com/jquery.ajaxsetup/
To summarize $.ajaxSetup usage doc basically say that it is to setup defaults for $.ajax method.  No where in the settings document here https://api.jquery.com/jQuery.ajax/ that said it support those other functions.
If you go to the function documentation, example $ .ajaxComplete, it specifically identify itself as a global function that is wired up on the document object, per example on the documentation page.
Personally, I would not use global.  You can use beforeSend to intercept the before ajax and the table reloaded event ajax complete.  Alternatively, you can use the datatables.net native events preXhr and xhr.dt events.

Thanks!


Weird cursor on for Bootstrap theme on ie

Bug description:
Step to produce:

Open the example on Internet Explorer
Type in Bootstrap example input
Click outside
Click on the text that was entered in step 2
Weird cursor happen

Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS
Angular: 1.4.9
UI-Select: 0.17.1

I don't think we can do much about "Weird cursors" might be more of a browser issue.

Hi @user378230 ,
Thank you for your reply. I don't think that related to browser issue. I tested selectize.js (both selectize & bootstrap theme)on internet explorer also but I don't see any weird cursor there
Version of Internet Explorer: 11

Unable to reproduce on IE11, closing.


consider hihat for browser tests

Looks like a better option than smokestack for tdd
https://github.com/Jam3/hihat

Did this.


Evaluation report missing

Hi Thiilina,
Just finished to reproduce the code, and at the end of the evaluation process, I got this error message just after finishing the process and before printing the results. :

I have navigated through the folders created by the code but I can't find the file 'eval_results.txt'. The only thing I have seen is that the code tries to store the report file in a folder called 'insults_evaluation_reports' (note reports is plural), but the system has the folder 'insults_evaluation_report' (in singular) and a subfolder called 'report_0' that is empty as you can see in the attached screenshot. In the 'insults_evaluation_report' folder there is aren't files, only the folder 'report_0'. Any idea where can I find the file?
Thanks!

Continued in https://github.com/ThilinaRajapakse/BERT_binary_text_classification/issues/4.


fix Issue 13009 more

https://issues.dlang.org/show_bug.cgi?id=13009
There was a function declaration order dependent bug in overloadModMatch.

I reopened #5245 onto stable branch.


How to collect the data of unit responses for "measure_or_tuning_fullfield"?

Hi, I want to calculate orientation selectivity index then I need to collect the data of responses by neuron
units to different orientation gratings, so I think I need to use  the class  "measure_or_tuning_fullfield"
belonged to featuremapper.command. I run the syntax "measure_or_tuning_fullfield()" and get a movie
about the orientation tuning of units in the full field for various contrasts, but I am struggling for : how to get the data for that  ? I tried some ways but haven't work it out. Could you help give a hint, please ?

If you're running any command in the notebook and get a figure displayed by HoloViews, you just need to type the same thing but add .data to the end if you want the data.  E.g. if you do tunings = measure_or_tuning_fullfield() then typing tunings will get you a visualization of some sort, and tunings.data will give you whatever is inside.  If you're looking at an element x, x.data will be the underlying data; otherwise it will be some sort of container that you can then look inside to find the data (indexed by various dimensions).  The HoloViews tutorials at holoviews.org explain how to navigate these data structures...

Hi, thanks for your reply. Yes, before you answered it in  #658 , just I still didn't figure it out since I didn't
realize I need to look at the data structures instructed by holoviews.org. Sorry for asking the same question twice !


TCVP-2387 fix mobile layout

Description
This PR includes the following proposed change(s):

TCVP-2387

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Does the change impact or break the Docker build?

[ ] Yes
[ ] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

This shouldn't be a hotfix branch.  hotfix changes are based off of main and are expected to be released prior to the next release.


ecds: fix the clean deletion logic

Commit Message: Ensure extension config is always deleted on the main thread.
Additional Description: There is an implicit data race with the following interleaving:

TLS runOnAllThreads invoked to clear the extension config.
TLS deleted, a post is invoked on all workers to delete its storage.
TLS runOnAllThreads on workers does nothing because of step 2).
TLS runOnAllThreads runs the completion callback on the main thread.
TLS deletion post invoked on some worker, deleting the last instance of the extension config.

The workaround is to prevent 2) from happening while runOnAllThreads is running. This is done by capturing TLS in the completion callback, and explicitly resetting it and the associated filter config in the callback.
Note that we cannot rely on the main_config shared pointer destruction implicitly. It seems the destructor can still execute on a worker, so we explicitly empty the content in the PR. It's not clear to me why some worker has a copy of the function, but it's hard to track down without AnyInvocable or move-only functions.
Risk Level: low
Testing: run the flakey test 10000 times, all pass
Docs Changes: none
Release Notes: none
Platform Specific Features: none
Fixes: https://github.com/envoyproxy/envoy/issues/26254

/retest

I am able to reproduce the race issue with run the flakey test 1000 times. Thanks for fixing the issue.  A few comments:
i) I am thinking if 3) in the description does nothing, then 5) should do nothing as well.  But apparently it is not, why?
ii) Can you run 1000 times test on this file as well which using the dynamic configuration as well: test/integration/listener_extension_discovery_integration_test.cc?

@yanavlasov could you please take a pass on this PR?

@adisuissa Thanks for taking a look. If you look at the definition of runOnAllThreads, it dispatches the completion callback (second lambda) to the main thread dispatcher:
https://github.com/envoyproxy/envoy/blob/main/source/common/thread_local/thread_local_impl.cc#L170
The integration test uses a filter with TLS in its factory. TLS destructor has an assertion that it can only be destroyed on the main thread - so we have the coverage needed to validate that filter config is always deleted on the main.