MGMT-17785 editable label control

Added a custom addLabelControl. Now, when a new label is added, it enters focused and can be edited immediately (tested for Chrome and Firefox).

Blurring out of the field or pressing "Enter" adds the label

Pressing "Escape" discards the label

Changed in the modals where labels can be added (Editing a device and editing the match patterns of a device.)

Updated the PR to simplify the UX as per Nir's review.


Add usgs metdata handling

So you're happy @jeremyh?

Oh wow, with no platform specified at all in that test it's marking it as "ls". I assume we don't want that. It's because the derivate code assumes platform is required.
Do we want to include platform in required fields? Or remove it from the name entirely if not specified?

I believe the way DEA is going is to set multiple platforms for products like wo and fc.
p.platforms == ["landsat5", "landsat7"]

... and the naming conventions convert that into whatever group name fits, like "ls" or "s2".

You're right, that was silly of me. Fixed to include eo:platform.
Not sure about multiple platforms... Stac SPEC says string, not array: https://github.com/radiantearth/stac-spec/blob/master/item-spec/common-metadata.md#instrument

Not sure about multiple platforms... Stac SPEC says string, not array: https://github.com/radiantearth/stac-spec/blob/master/item-spec/common-metadata.md#instrument

Yeah, ODC requires a string too. Some products were reated that are derived from multiple, though, and started comma-separating them. Such as wofs summary.
It's now supported officially in eodatasets, and is converted/sorted etc automatically:
>>> # Set multiple platforms
>>> p.platforms == ["landsat-5", "landsat-7"]

>>> # ... which is still stored as a string:
>>> p.platform
'landsat-5,landsat-7'

>>> # ... `platforms` will always return it as a sequence:
>>> p.platforms
{"landsat-5", "landsat-7"}


Update 01_Extensions.md

adding missing space

I can merge this one, but would prefer that we focus minor documentation alterations in the 3 branch. 3.1 is not going to receive much attention once 3.2 is out.

The branch 3 won't be merged back into 3.2 before release/regular @tractorcow ?

No, but once 3.2 is out (and soon) our attention will be focused on 3.3.

okay, I'll add make changes for 3.2 or later branches then.


[bug] Invoking ERC-20 contract's approve method shows blank transaction window with authConnector (email)

Link to minimal reproducible example
https://stackblitz.com/edit/web3modal-next-template-pxafet?file=app%2Fpage.jsx
Summary
When I invoke the approve method of USDC contract, I got a blank transaction window when I connected with email:

After that I invoke my NFT contract, and it shows transaction details, only the approve of USDC is blank.
It should show the transaction details to approve.
List of related npm package versions
"@tanstack/react-query": "^5.37.1",
"@wagmi/connectors": "^5.0.2",
"@wagmi/core": "^2.10.3",
"@web3modal/wagmi": "4.2.1",
"viem": "^2.11.0",
"wagmi": "^2.9.2"

It is shown in 5.0.4. Though I use Polygon network and it shows ETH instead of Matic:

Is it just converted to ETH, or is it wrong?

Can you update the reproducible example ?
Which wallet are you using ?


Ensure clean build/deploy path

[x] Build all assets, referenced properly, into /dist (fix #28)
[x] Write build/install tasks in DocumentCloud
[x] Write deploy tasks in DocumentCloud

Considering this one done even though #28 is still a problem.


Questions with line breaks are repeated on every keystroke

Describe the problem
I have searched around but did not find the issue, or how to work around it. If I make a question with a line break, the output is not what i would expect
Steps to reproduce the problem
2.6.3 :002 > require 'tty/prompt'
 => true
2.6.3 :003 > TTY::Prompt.new.ask("This value is not set.\nSet a value:")
# Start typing

Actual behaviour
When the user is allowed to start typing on every keystroke the first line is repeated.
Before typing anything:
2.6.3 :004 > TTY::Prompt.new.ask("This value is not set.\nSet a value:")
This value is not set.
Set a value:

One keystroke:
2.6.3 :004 > TTY::Prompt.new.ask("This value is not set.\nSet a value:")
This value is not set.
This value is not set.
Set a value: a

Two
2.6.3 :004 > TTY::Prompt.new.ask("This value is not set.\nSet a value:")
This value is not set.
This value is not set.
This value is not set.
Set a value: aa

Expected behaviour
What did you expect to happen?
The user can type as much as he wants, and the only thing changing is the value after Set a value:
2.6.3 :004 > TTY::Prompt.new.ask("This value is not set.\nSet a value:")
This value is not set.
Set a value: 123456

Describe your environment

OS version: MacOS Mojave 10.14.2
Ruby version: 2.6.3
TTY version: 0.19.0

Also
Thank you so much for this gem, it's amazing

This is actually a bug in tty-reader read_line
require 'tty-prompt'

p = TTY::Prompt.new
p.read_line("one?\ntwo?")

[kschiesser@rubydev ~/code/tty-prompt]$ ruby issue-111.rb
one?
one?
one?
one?
one?
one?
one?
one?
two?aaaaaaa


feat(Makefile): add target for tests with code coverage

[skip ci]
Summary of Changes
NOTE
This PR can't be merged until after deis/docker-go-dev#34. It anticipates a quay.io/deis/go-dev:0.13.0 image.
make test-cover runs the go unit tests while accumulating a coverage.txt file suitable for shipping to https://codecov.io/.
$ make test-cover
docker run --rm -e GO15VENDOREXPERIMENT=1 -v /Users/matt/Projects/src/github.com/deis/builder:/go/src/github.com/deis/builder -w /go/src/github.com/deis/builder quay.io/deis/go-dev:latest test-cover.sh
?   	github.com/deis/builder/pkg	[no test files]
ok  	github.com/deis/builder/pkg/cleaner	5.017s	coverage: 84.6% of statements
?   	github.com/deis/builder/pkg/conf	[no test files]
ok  	github.com/deis/builder/pkg/controller	0.020s	coverage: 27.3% of statements
ok  	github.com/deis/builder/pkg/env	0.009s	coverage: 100.0% of statements
ok  	github.com/deis/builder/pkg/git	0.024s	coverage: 4.9% of statements
ok  	github.com/deis/builder/pkg/gitreceive	0.078s	coverage: 20.4% of statements
ok  	github.com/deis/builder/pkg/healthsrv	0.027s	coverage: 85.5% of statements
?   	github.com/deis/builder/pkg/k8s	[no test files]
ok  	github.com/deis/builder/pkg/sshd	1.699s	coverage: 65.6% of statements
ok  	github.com/deis/builder/pkg/storage	0.016s	coverage: 51.6% of statements
?   	github.com/deis/builder/pkg/sys	[no test files]
?   	github.com/deis/builder	[no test files]
$ ls -alh coverage.txt
-rw-r--r--  1 matt  staff    28K Apr 24 12:31 coverage.txt
$ head coverage.txt

mode: atomic
github.com/deis/builder/pkg/cleaner/cleaner.go:23.74,25.16 2 1
github.com/deis/builder/pkg/cleaner/cleaner.go:28.2,28.6 1 1
github.com/deis/builder/pkg/cleaner/cleaner.go:25.16,27.3 1 0
github.com/deis/builder/pkg/cleaner/cleaner.go:28.6,29.10 1 87915699
github.com/deis/builder/pkg/cleaner/cleaner.go:30.3,31.11 1 87916906
github.com/deis/builder/pkg/cleaner/cleaner.go:34.4,34.31 1 7
github.com/deis/builder/pkg/cleaner/cleaner.go:31.11,32.10 1 87918462
github.com/deis/builder/pkg/cleaner/cleaner.go:34.31,35.32 1 3
...

TODO:

[ ] Integrate with codecov.io and verify GitHub coverage comments are published

Issue(s) that this PR Requires
deis/docker-go-dev#34
Testing Instructions
Please provide a detailed list for how to test the changes in this PR.

Build a local deis/go-dev:latest image from the PR referenced above
Check out this PR and run make test-cover

Anticipated results:

There is a coverage.txt file present containing code analysis data
The coverage.txt file is not in version control or marked as needing to be added

Next steps:

Help me figure out how to upload coverage.txt to codecov.io
Make a bunch of PRs just like this until all deis/* Go projects have code coverage reporting :boom:

Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[X] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[X] Your commits are squashed into logical units of work
[X] Your commits follow the commit style guidelines

AFAICT, this is actually working correctly, but codecov.io has no baseline coverage report against which to compare these results. Chicken-and-egg thing.
One thing I noticed is that if there are no tests in a given go package, it doesn't get included. I think we would prefer for it to show "0% coverage," which might be accomplished by fabricating an entry in coverage.txt.
I'm curious if anyone who has worked with codecov.io has input on this. I'd like to sort it out and do something similar for all Deis Workflow go packages.

[Current coverage][cc-pull] is 37.84%

No coverage report found for master at 0df2ba3.

Powered by Codecov. Last updated by [0df2ba3...7cebd6e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/builder/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/builder/compare/0df2ba3a70cf22c3195af25833a70cfce68fc195...7cebd6e7014716384b22cde4f66af5e1f6306b5e
[cc-pull]: https://codecov.io/gh/deis/builder/pull/314?src=pr

@mboersma I restarted the e2e build. hopefully it passes 😄


feat: ManagedStrings

closes #18

I finally could look a bit into this, sorry for the delay. I'm glad you took the initiative to merge it without me. Thanks again for your work. Everything's fine.

I've been testing it with real use cases for several days without any single problem, I'm confident to launch a 1.0 version soon


Melee attack sounds vs walls/entities can be heard globally

Not had a chance to reproduce this but we had someone on the other side of the map attacking a wall or other entities with a melee weapon, and the sound was full volume globally.

I heard other sounds with the same issue too.

Cant reproduce


Adding TFLite model of American Sign Language

Hi @WGierke adding a tflite for American sign language detection.
Description
The Image Scene Classification model can classify the images based on the american sign language alphabet. The model can handle up-to 29 classes from A to Z and Space, Delete and Nothing as well.
References
[1] Optimization of Transfer Learning for Sign Language Recognition Targeting Mobile Platform, https://arxiv.org/pdf/1805.06618.pdf

Awesome, thanks a lot for the models and your patience! :)

Thanks for the help as well.


Create github action to build AutoCCS and store on DockerHUb

Once #2 is complete I will automate build to run on DockerHub

Closed with PR #9


Add Notepad++ to list of IDEs

Do we have a pointer to the notepad site that mentions they support Raku?

Found https://notepad-plus-plus.org/news/v867-released/, merging.

Thanks!


Hover error after inlay hints

Hello there! I find out that after the inlay hints commit there is an issue with hovering
Before inlay hints

After inlay hints

Is there any new config that I should be using after the changes?
This is my current config

Seems this is something wrong with  gopls. The response:
{
  contents = {
    kind = "markdown",
    value = '{"synopsis":"InjectXraySegment injects the base Segment to be used for the AWS X-Ray Instrumentation.","fullDocumentation":"InjectXraySegment injects the base Segment to be used for the AWS X-Ray Instrumentation.\\n","signature":"func internalmiddlware.InjectXraySegment(serviceName string) func(next http.Handler) http.Handler","singleLine":"func internalmiddlware.InjectXraySegment(serviceName string) func(next http.Handler) http.Handler","symbolName":"middleware.InjectXraySegment","linkPath":"","linkAnchor":"InjectXraySegment"}'
  },
  range = {
    end = {
      character = 44,
      line = 91
    },
    start = {
      character = 27,
      line = 91
    }
  }
}

It is sending list instead of string.
The spec says
interface HoverResult {
	value: string;
}

Ok, it not releated to hintlay, it is Structured setup for hover. Maybe I should revert that specific changes.


Added more constructor types e.g. for float.

Moved bc_init_numbers to the constructors. This is required for the double/float constructor so added it to the others as well for consistency.
Added more constructors for eg float, (u)int32/64_t. Could be done with strings as well but a float takes less space in flash than a string representing the same value.

Hey, I like your fork. I think you just forgot to declare the new constructors in BigNumber.h


Extending Prompt Template Store to Git

Feature request
Hi, thanks for creating such a great tool, I'm using it well at work and for personal use.
But for production use, I need a more tightly managed, revision-controlled Prompt Template Store.
I know that load_prompt already supported, but I wonder if it can be extended to utilize remote store, like github.
For example, if there is GitPromptTemplateStore class like:
from abc import *
class PromptTemplateStore(metaclass=ABCMeta):

     @abstractmethod
        def load(self, path: str) -> BasePromptTemplate:
            pass

class GitPromptTemplateStore(BaseModel):
    @property
    def repository(self) -> str:
        return "git@github.com:some_project/prompt_repo.git"

    @property
    def branch(self) -> str:
        return "main"

    ...

    def load(self, path: str) -> BasePromptTemplate:
        ...
        return {name}_prompt_template # from remote git store (with/without cache)

which can be utilized like:
template_store = GitPromptTemplateStore(...)
prompt = load_prompt_from_store(template_store, path=...)

managing prompt_template would be much easier.
Motivation
For production use, I need a more tightly managed, revision-controlled Prompt Template Store.
I know that load_prompt already supported, but I wonder if it can be extended to utilize remote store, like github.
Your contribution
I have read the CONTRIBUTING.MD, and if this request looks valid, I'd be happy to contribute.

I guess this feature is out of the coverage of the langchain, so I close this issue.


stats: Add 1 day actives and total users to number of users chart.

Adds the three buttons in the upper right:

Caveats:

When you upgrade to 1.9, the two non-middle buttons will return a string of 0s until the daily cron job runs.
Still need to write the user docs for this; 1-day actives and the other two treat deactivated users differently, so it's actually possible to have more 1-day actives than total users, e.g. if everyone is active (in the "logged in to zulip" sense) and then a couple of folks get deactivated (in the "banned" sense).

This looks great; I fixed the JS linter errors and merged.
I do notice one issue this creates, though, which is that now that the bottom graph has a way to see the total users, we should probably make the value section at the bottom update when you hover over things like it does on the top/bar chart?


Upgrade cdb_dataservices_client version to 0.8.0

Please @rafatower / @jgoizueta  could you :+1:?

:+1:


[colorManipulator.js] add warning to decomposeColor

A warning that fires when the color string format is not in one of the expected formats. It doesn't try to stop the code, but at least warns the user that something is off instead of failing silently. Motivated by issue #4841.

@gyfis Thanks for following through so quickly! 👍
I'm wondering about the wording of "Use an RGB color representation instead.", since the function supports every representation except color names and RGB % values. Perhaps just naming the unsupported types instead?
Also, it's a shame to loose 100% test coverage for (AFAIK) the only file that has it, but I'm not sure if there's a practical test for this. @oliviertassinari any ideas?

Coverage decreased (-0.004%) to 60.972%

Not that much.
Are we already testing warnings? I'm not sure. I can't find an trivial solution.

I've looked through the codebase and it seems that warnings are untested (at least I didn't find any warnings in test files), so I assumed that it's ok like that.
You're right that naming the unsupported formats is better, I'll try to change it up.

Are we already testing warnings? I'm not sure.

No, I had checked.

I can't find an trivial solution.

Neither could I, because spying on the console causes other problems. I think it's fine without.

Good work guys 👍


Fix nested types

This PR closes #625 by:

Adding in edgecases for arrays in the 1DeepValues type
Add a TDepth to DeepValues to prevent TypeScript from overflowing memory
Fixing issues with FW adapters not passing TData properly
Fixing an issue where defaultValue would infer the data type incorrectly
Fixing weird plugin typing issues with Vite by sidestepping with as never ( CC @lachlancollins )
Adding tests to validate typing fixes
Adds TS 5.3 and 5.4 to the TSC options, update tsc to run in 5.4 to solve a bug in TS 5.2

Apologies for the big PR, this isn't easily broken up 😓

Codecov Report
Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.84%. Comparing base (6009dce) to head (dae2507).
Report is 7 commits behind head on main.

Files
Patch %
Lines

packages/form-core/src/FieldApi.ts
50.00%
1 Missing :warning:

packages/react-form/src/useField.tsx
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   87.75%   88.84%   +1.09%
==========================================
  Files          30       28       -2
  Lines         792      807      +15
  Branches      179      185       +6
==========================================
+ Hits          695      717      +22
+ Misses         92       83       -9
- Partials        5        7       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Laravel Sail Internal URLs not working 8.2.0

I'm having an issue on 8.2.0 (Maybe related to gotenberg/gotenberg#403?)
Using Laravel + Sail on WSL2
docker-compose.yml
    gotenberg:
        image: gotenberg/gotenberg:8
        extra_hosts:
            - 'host.docker.internal:host-gateway'
        ports:
            - '${FORWARD_GOTENBERG_PORT:-3000}:3000'
        volumes:
            - './public/fonts:/usr/local/share/fonts'
        command:
            - "gotenberg"
            - "--log-level=debug"
        networks:
            - sail

ive made a static page at /sample which literally says just "Hello, World!"
from inside the gotenberg container curl http://laravel.test/sample works fine
I can run the following from inside the laravel app container (not the gotenberg container)
curl \
--request POST http://gotenberg:3000/forms/chromium/convert/url \
--form url=http://laravel.test/sample \
-o my.pdf

it works fine, my.pdf appears in the project root. with the words "Hello, World!" on it.
But from the application when I run (gotenberg/gotenberg-php)
$request = Gotenberg::chromium(config('gotenberg.url'))
                            ->pdf()
                            ->failOnConsoleExceptions()
                            ->outputFilename('my-custom-pdf')
                            ->url('http://laravel.test:80/sample');

        $response = Gotenberg::send($request);

        return $response
            ->withHeader('Content-Type', 'application/pdf')
            ->withHeader('Content-Disposition', 'inline; filename="generated.pdf"');

I keep getting:
ypa-filament-app-gotenberg-1  | {"level":"error","ts":1709274087.9005635,"logger":"api","msg":"convert URL to PDF: conv
ert to PDF: context deadline exceeded","trace":"efa04a81-fb5a-4cfe-abb3-80e0d6e81a00","remote_ip":"<IP_ADDRESS>","host":"
gotenberg:3000","uri":"/forms/chromium/convert/url","method":"POST","path":"/forms/chromium/convert/url","referer":"","
user_agent":"GuzzleHttp/7","status":503,"latency":30000270232,"latency_human":"30.000270232s","bytes_in":316,"bytes_out":19}

P.S. if i call ->html(Stream::string('sample', view('sample')->render())) though it does work. its only url() thats the problem. But if I have any images in the view the same timeout happens. The image urls also are something like 'http://localhost/img/example.jpg' and I don't think the Gotenberg container can resolve localhost so I'm not even sure what the correct implementation is.
Been fighting this all day. Please help 🙏

I've seen suggestions to use ->html(Stream::string($filename, $html)); instead, but theoretically if i use this as an alternative how would Gotenberg even have access to the images? Because it works but images don't render. but then again why would they because "localhost" in <img src="http://localhost/example.jpg"/> would mean localhost on the Gotenberg container and wouldn't resolve to laravel.test

I've set up a completely fresh installation of laravel, with only the following installed

gotenberg
gotenberg/gotenberg-php
symfony/psr-http-message-bridge

https://github.com/wazimshizm/gotenberg-issue-39 and it's the same issue.

No idea on what’s going on here 🤷♂
You may try skipNetworkIdleEvent to improve the rendering time.

@gulien not your fault at all. It's so obvious now. 🤦♂
For anyone else with this problem, it's because Laravel Sail only has one worker by default, which is occupied by the initial request. When gotenberg makes it's request back, it times out. This isn't a problem with queued processes obviously.
Add PHP_CLI_SERVER_WORKERS=2 to your .env file and restart sail.


Merge develop-0.3 to the main branch

Description

In release 0.2, we find that for each scanner, it needs to handle the connection to each report consumer. This makes Narrows very hard to be extended. Thus in release 0.3 we added another component, Exporter, which helps to decouple the scanners and the consumers.
We changed the Kubebench scanner into a DaemonSet,  and the scanning is triggered by Events now: when there is modification on the K8s configuration file, trigger the scanning immediately. This helps to avoid unnecessary scanning and fills the time gap of CronJobs.
We added helm chart for Narrows, so the users need not to download the source code when deploying Narrows.
For image scanner, now Portal will read the report from OpenSearch instread of the CR in the K8s cluster. Also, we removed the CRD, AssessmentReport, because storing reports in etcd is a deprecated way.
We added the e2e test framework, and added many test cases.
Code refactor and bug fixes

Tests
Each commit in the list were tested when they were merged to develop-0.3

Codecov Report

Merging #211 (85046ca) into main (6dd414d) will increase coverage by 12.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #211       +/-   ##
===========================================
+ Coverage   43.62%   56.28%   +12.65%
===========================================
  Files          14       11        -3
  Lines        1318      947      -371
===========================================
- Hits          575      533       -42
+ Misses        702      380      -322
+ Partials       41       34        -7

Flag
Coverage Δ

unittests
56.28% <ø> (+12.65%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...native-security-inspector/src/pkg/exporter/main.go

...ctor/src/pkg/data/consumers/opensearch/exporter.go

...ve-security-inspector/src/pkg/exporter/handlers.go

...pector/src/pkg/data/consumers/opensearch/client.go

...ve-security-inspector/src/pkg/exporter/cmd/main.go
5.26% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat: new Map type

Refactor the Contract Storage page to add info about the new Map type.
Deprecate the LegacyMap type - only add a quick one liner about it.

Hello @enitrat , I would want to work on this issue.

@quentin-abei the book was updated to 2.7, you can start now. Please finish by thursday next week


Fix ledger udev error

Abstract
This PR just makes the check case insensitive.
The error was much more descriptive than the former undefined, but the intended message wasn't being displayed
Testing

Try to access the ledger without proper udev rules

Merging on one review to ensure this is included in v1.3.0 - change is small enough to allow for it.


Drop obsolete security replaces

Our dependency tree pulls in the same or newer versions of /x/crypto
and /x/text, remove the replace directives.
This helps with go install (see
https://github.com/golang/go/issues/44840).
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

Do we know what's going on with the failing unit tests?


MSTEST0002 and AssemblyInitialize/AssemblyCleanup

There is one case where MSTEST0002: Test classes should have valid layout:
[TestClass]
public static class TestSetup
{
    [AssemblyInitialize]
    public static void Initialize(TestContext testContext)
    {
        ...
    }
}

MSTEST0002 is fired because TestSetup class is static.

Oh! Thanks! That's indeed some false-positive.
Could you confirm that in your setup you don't have any test in the same class?

No. This is our actual code with implementation of Initilize method stripped out.

@Evangelink, any ETA on 3.2.1?

@avivanoff we just released 3.2.1!

Verified, the issue is fixed. Thank you.

Awesome! Looking forward for your feedback on V3.3


[Validation Package] Allow validation data to be set directly from an EntityInterface

This PR allows validation data to be set from a DataEntity (or EntityInterface to be precise)....
Usecase = >

Currently

$data = [];
$data[self::ARGS_FULL_NAME] = $this->argument(self::ARGS_FULL_NAME);
$data[self::ARGS_MONIKER] = $this->argument(self::ARGS_MONIKER);
$data[self::ARGS_EMAIL] = $this->argument(self::ARGS_EMAIL);

$transformedData = new SomeDataEntity($data);

$val->setData($transformedData->getFields());

//Do something else with $transformedData

This PR =>

$validator = $validator->withDataEntity($transformedData);

Just sugar syntax, but i have found myself this past hour filling an EntityInterface and passing it to the validator.

Coverage decreased (-4.09%) to 91.039% when pulling fd7cb0f79ccd8a2347475fb690ac8ce16b2f99a4 on adelowo:validation_and_data_entities into f6932881a6504f96efa7721aca60cb37bbc5ff44 on spiral:develop.

I don't get why coverage reduced :1234:

Few comments:

"with" prefix usually used to represent immutable methods, will lead to confusion
I'm not sure if it's a good idea to couple validator (and validator interface) an entity as this is parts of different domain

ValidatesEntity combines them together as implementation, but joining this two abstractions on highest level will create higher coupling.
Another option is too make setData method accept entity directly. Let me think about it till next week.

Alright, but at worse, setData should be able to work with an array or an EntityInterface

Yes it should. http://prntscr.com/f261nc If it's not, you just found a bug :)

Actually, it should be working with ArrayAccess which is implemented by all entities but not in the interface.  I will correct that.

I missed noticing it accepts \ArrayAccess..

Well, EntityInteface is not necessary ArrayAccess so you had a fair point. I created a new branch, let's wait for CI.

https://github.com/spiral/spiral/tree/feature/validate-entity

BTW, there is a slight chance that cache will work as well now, Validator itself caches errors IF data not changed. Regarding #180

Ok, i am just going to pull that branch and test it out

Cool, i included your test as well :)

Closed by #182


[SPARK-24491][Kubernetes] Configuration support for requesting GPUs on k8s

What changes were proposed in this pull request?
Configuration support for generating the GPU requests in the limits section for the executor pods.
How was this patch tested?
The patch has been tested on a local on-premise cluster with mixed nodes (some with GPUs and some without). There are currently no contributed tests for the patch. :(
Legal: I (Alex Miłowski) developed and tested this patch. It is my original work and that I license to the project under the project’s open source license.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

But I am concerned about it setting a precedent for having to change Spark's source code every time you want to request a new resource type. I am very familiar with the space of machine learning accelerators, and trust me, there's a lot of cool new things coming down the pipeline.

@galv this might fall under the more general question of how to give arbitrary configurations to the pod we make in the driver and executors - see https://issues.apache.org/jira/browse/SPARK-24434.

On Fri, Jun 8, 2018 at 10:36 AM, Ilan Filonenko<EMAIL_ADDRESS>wrote:

@ifilonenko requested changes on this pull request.
Thank you for this work. Would be nice to see some integration tests, but
I don't believe GPUs are available in our test cluster. @shaneknapp
https://github.com/shaneknapp to comment?

that is correct -- we currently have no GPUs in the cluster.
that being said, we do have plan to add one or two GPUs in the near future
but they (initially) will be reserved for riselab-specific builds.  the two
big problems that we have when it comes to deploying them are:

8 of the 10 build nodes are blade-style servers (4 servers in a 2u
mount) and don't have physical room.  the only two we have that can
physically house them are the current amp-jenkins-staging-worker nodes, and
they can hold 2 each...  but due to how the power cables plug in on most of
them, we are again limited to a couple of specific GPU types (power cables
on the top of the card vs being on the back).

GPUs are expensive...  :)

i'm more than happy to revisit k8s tests running w/GPUs once we get them
installed in to the workers and figure out our lab's usage stats.

I think we might want to defer this feature until we have figured out SPARK-24434 - as already mentioned, arbitrary resource types could be desired outside of just GPUs. I think once we get a better understanding of what we want to do for SPARK-24434 we could decide on what classes of things we want to make configurable through spark-submit and what should only be configurable in the pod spec. @skonto @liyinan926 for thoughts.

Agreed. We might want to see and wait for the design for SPARK-24434. Seriously we already have a lot of config options for specific things to customize for the pods, and we are running into the problem of config option explosion if we keep adding more.

Can one of the admins verify this patch?

+1 agreed with @liyinan926. Let's be more careful what we add to the configuration options.

Hello all,
I've been thinking about trying to make this more generic given I just ran into a hostPath/volume issue for executors which is similar. I took a look at SPARK-24434 and that seems to be likely the right path. In the end, GPU, volumes, etc. are all just aspects that need to go into the pod description so the scheduler can choose the right node and associate the right resources.
I will try to contribute to SPARK-24434 and this pull request might not be necessary afterwards.

Can one of the admins verify this patch?

Seems from the discussion that SPARK-24434 covers everything here. If that's not the case, just update your branch to reopen the PR.


V2.4.x/dev issue#1963

PR
CheckList（PR Assigners）
确认已完成以下操作：

[ ] 已将分支与当前合入分支同步
[ ] 已在关联 Issue 中补充「功能自测」部分内容
[ ] 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested（需通过测试同学测试） -> done
[ ] 将 PR 添加上 pr/reviewable

CheckList（PR Reviewers）
确认已完成以下操作：

[ ] 检查关联 Issue 「功能自测」部分内容
[ ] 必要时打回 pr/reviewable，要求重新修改
[ ] 及时 Approve

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8e36cae) 74.71% compared to head (8f00024) 74.78%.

:exclamation: Current head 8f00024 differs from pull request most recent head cbe9b34. Consider uploading reports for the commit cbe9b34 to get more accurate results

Files
Patch %
Lines

apps/node_man/serializers/base.py
33.33%
6 Missing :warning:

apps/core/ipchooser/handlers/host_handler.py
90.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff               @@
##           v2.4.4-dev    #2073      +/-   ##
==============================================
+ Coverage       74.71%   74.78%   +0.06%
==============================================
  Files             404      404
  Lines           28259    28298      +39
==============================================
+ Hits            21114    21162      +48
+ Misses           7145     7136       -9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

单测

功能自测
导出三种场景的管控区域:IP
管控区域:IP

管控区域:[IPv4]

管控区域:[IPv6]

消费场景
管控区域:[IPv4]

管控区域:[IPv6]


Soft delete too

Added a spec for location soft delete … it is a bit rough since there is only a grant repo to work with … feel free to refactor it before merging.

Redo


Add MS Thesis to Zotero

This repository's issues are reserved for feature requests, and bug reports, and questions.
I'm submitting a ...

[ ] bug report
[X] feature request
[ ] question

Hi Roberto, Katy and I noticed your MS thesis wasn't in the Zotero, could you add it?
How can this issue be closed?
Can be closed when your MS thesis is added to the Zotero in the theses folder under group-pubs.  Thanks!

I totally forgot about this. Done! Thanks for the reminder.


Mouseover Tooltips, Default Text not working || Misaligned objects

Whenever you mouse over specific areas where tooltips would be shown in previous versions, the tooltips don't show up.
Specifically, when creating a filter, you hover your mouse over .*, Aa, or &0 and nothing appears to help give the difference between the three options.
Default Text as in the text filled when viewing filters. When you create a filter and finish, hit done, move to create another filter or look at another filter, it'll look like it disappears. But it hasn't, it's like it's invisible, until you click on it to edit, then it appears again.
It's not just filters however, it's Ignored Channels, Channel Alias, Channel Prefix, Channel Cmd, Filter Name, Filter Destinations, Filter Sound Notification, Filter Expression. Any textbox that allows for input shares this problem.
Misaligned objects as in there'd be text boxes, text fields, and buttons misaligned such as the Anti Spam Prejudice or the......thing in the Advanced tab. It has a textbox that can be changed by arrow buttons, but has no text field......
No logs to give.

Also, during filters or channels, when you're typing in one field and then swap to another field. For some reason, your text cursor stays at the previous field you were editing, and now there's two text cursors, one at the previous text field and now the new one at the current text field you're editing.

I've temporally removed some featured related to UI after some refactoring and rewriting. I'll add them back in the future.

https://github.com/killjoy1221/TabbyChat-2/commit/5dd9b36604332bfb0ee6694c85ce4d75abe6b718
This should resolve the missing text. I've known about it for a while, but just haven't gotten around to fixing it.


Parallel export (use par comemo)

This PR does the following changes:

Using parallel comemo: we can now use rayon to get "free" parallel PNG and SVG export (brings a nice speedup)
Using Deferred: PDF page deflate is done in parallel
Small changes in some places to use parking_lot (which is already in our tree from comemo) which doesn't have poisoning and therefore doesn't require unwrapping
Moved to a Mutex in a place where a RwLock was used but never read meaning that we had a useless atomic counter

It brings a nice boost in cold and incremental performance basically for free :)

Thank you!


Gamoshi: Add 9MediaOnline bidder adapter alias docs

Type of change

[x] New bidder adapter alias docs

Description of change
Add 9MediaOnline new adaptor alias

contact email of the adapter’s maintainer
[X] official adapter submission

released with 2.30


Add Cache Function for User-Defined Batching

This PR builds on https://github.com/triton-inference-server/backend/pull/75. For custom batching where the user defines additional constraints for the dynamic batcher, this PR allows the user to call two new optional functions that initialize and finalize once. This allows them to create a cached object that can be read for every batch without needing to be re-initialized.
An example use case is where the user needs to read a value from the model config for batching, so they would only want to read it from the config once and save it to use with their custom batch-handling logic. See volume_batching.cc in this PR as an example.
Core: https://github.com/triton-inference-server/core/pull/149
Server: https://github.com/triton-inference-server/server/pull/5204

To try to get this in quickly, I'm going to merge this into the main PR branch. All feedback should have been addressed. :) If anyone has additional feedback, please comment it in the main dyas-custom-batching PR.


How to generate Event Hub SAS token

The current link has only a C# sample, can we add this documentation which has more samples on how to get it?
https://docs.microsoft.com/en-us/rest/api/eventhub/generate-sas-token

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13249027-1524-dd0c-9d83-15a9733a3d19
Version Independent ID: bf8a2d1a-8d9b-228a-6919-16127f315d40
Content: Azure Compute - Linux Diagnostic Extension
Content Source: articles/virtual-machines/extensions/diagnostics-linux.md
Service: virtual-machines-linux
GitHub Login: @abhijeetgaiha
Microsoft Alias: agaiha

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


Moved bounds control out of experimental

Overview

moved files out of experimental
removed experimental part of namespaces

Note: example scene migration in separate PR
Changes

part of #7358

/azp run


Issue #SB-15647 fix: offline desktop app issue

Issue #SB-15647 fix: offline desktop app issue

Already merge this PR as a part of release-2.6.0, hence closing this PR


Update tv.html with reference to issue #227

The cursor now changes to the pointer when you hover above TV shows.
Issue #227 is fixed with this update.
Issue Number
fixes #227
Describe the changes you've made
Changes are made and the cursor now changes to the pointer when you hover above TV shows.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist

[ ] I have added my name in the contributors list at the end of README.md file.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] The title of my pull request is a short description of the requested changes.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

Also, do the changes for the web series and kids page.

Whenever make new PR close old one.


256 OutputMode support prototype

Known issue with gray-scale colors

Relates to #72.

@mephux please take into account that after submitting the review I edited/removed some of my initial comments.

@Jameskmonger all changes made - the only one Im confused on is the escape part. It seems the logic that's already in parseOne works for 256 support.
The only annoying part is 38 is used for FG and 48 for BG and if we use a case for catching 0...256 it will call into that.
Any ideas?

also https://github.com/mephux/komanda-cli/blob/256/komanda/gui.go#L28 usage

The lib i was using for 256 output was github.com/aybabtme/rgbterm. Maybe we should just add helpers to gocui for writing color strings? then we can use:
   ESC[ … 48;2;<r>;<g>;<b> … m Select RGB background color```

and pass in straight r/g/b values vs a converted rgb value.

@jroimartin, Last comment for tonight. I changed my code just to use the 256 terminal code vs. trying to convert RGB to the closest match.
https://github.com/mephux/komanda-cli/blob/256/komanda/color/color.go
Still, have issues with the colors being wrong.. i.e., Red for some reason doesn't want to work.. haha dunno, will continue in the morning. It's getting closer at least.

@jroimartin ok, it's ready to rock&roll - also added a 256 color example. Guess it just comes down to how the mode is set and making the code not so ugly.

Great! I'll give it a look in the next days.

@jroimartin awesome, thanks - small update, fixed the _examples. See https://github.com/mephux/komanda-cli/tree/256 for screenshots of a super colorful gocui app. haha

BTW I love the screenshots of komanda-cli with 256-colors support! :D

@jroimartin thanks
Ok, I fixed everything outside the support for Normal with 256. Maybe I'm missing something but I'm not sure that will be possible?

@mephux 256 with normal support should be possible though.

@libeclipse @jroimartin just added that per the comments above.. it works.. just tested it in my project.

@jroimartin ok, that should be it -- sorry for making this such a pain in the ass. I had to learn all about terminal escaping. lol

Not at all! It's a great PR :)

@jroimartin fixed

Cool! I think we are ready to merge. Can you squash your commits?

@jroimartin sure - one sec

@jroimartin done - thanks!

Perfect! Let me do a couple of style changes (removing some empty lines) and update the AUTHORS file and will merge :)

@jroimartin roger, thanks for the help along the way!

Merged! Thanks a lot for your contribution! :D
BTW I did a couple of style changes and added 8-colors escape sequences to _examples/colors256.go.

@jroimartin no problem! Thanks for accepting it. :)


fix: add custom user agent for amplify client

Issue #, if available:
AWS Amplify Console needs a way to tell how many user's made list calls via amplify cli. So we want to append a custom user agent.
Description of changes:
Add 'amplify-cli' when init amplify console client
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@garyleefight could you please address Ed's feedback so we could get this in?


Update azure-stack-csp-howto-register-tenants.md

Change from : "Azure reports the customer's usage using the customer identity from Partner Central."
to "Azure reports the customer's usage using the customer identity from Partner Center."

@jeanrobertjs : Thanks for your contribution! The author, @sethmanheim, has been notified to review your proposed change.

@jeanrobertjs Thank you for catching that! We'll get it changed right away. Thanks again for the contribution. #sign-off


Mongo db upgrade

Status:

Description :star2:

Fixes #number
TODOs :star:

mongoengine upgrade 0.23.0->0.26.0
pymongo upgrade 3.11.3->4.20


Update convertToUnIndexedMesh and convertToFlatShadedMesh

Both convertToUnIndexedMesh() and convertToFlatShadedMesh() appear to be doing similar things, so I created a private function, _convertToUnIndexedMesh(), to be used by both.
_convertToUnIndexedMesh() has a flag to decide if normals should be flattened, as should be the case for flat shading.
I also added logic to accomodate morph targets, if they're available in the mesh.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Should this have a unit test? Visualization test?

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Should this have a unit test? Visualization test?

Maybe that would be nice to have a visualization test with the alien head and use convertToFlatShadedMesh on all meshes?

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14002/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14002/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14002/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14002/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14002/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14002/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14002/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14002/merge#BCU1XR#0


Update quoting.md

Comment says unquote identifier, but it was quoted in source()
Description & motivation

To-do before merge

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes
[x] No (if you're not sure, it's probably "No")

If yes, please change the base branch of this PR to next

Hmm, I think the docs could be clearer here, but the code snippet is correct. We currently have:
-- here, the identifier should be unquoted
left join {{ source('jaffle_shop', 'customers') }} using (order_id)

I think maybe we want it to read:
-- here, the identifier should be unquoted when it gets compiled to a table name
left join {{ source('jaffle_shop', 'customers') }} using (order_id)

You definitely need to quote 'customers', it's the compiled code that changes :)


Docker 1.6.2 missing from Ubuntu package site

Hit https://get.docker.com docker Release
Hit https://get.docker.com docker/main amd64 Packages
root@ab64cdfc5bf1:/var/cache/debconf# apt-get install lxc-docker=1.6.2
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Version '1.6.2' for 'lxc-docker' was not found

Docker 1.7.0 breaks our deployment process, and now we cannot install the working 1.6.2 version.  So we cannot provision any new machines in this state.
Please do not remove old versions from the package site, they are small and it is really nasty to get rid of them.
I suspect this is because the release.sh script regenerates the Debian mirror metadata files without considering prior releases, only the current one:
https://github.com/docker/docker/blob/master/hack/release.sh#L270

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I think this is a dup of #13191

ping @tianon

Yes, duplicate, sorry.


Add android note

It took awhile to get the examples reviewed, but they came though today. There are three in total but I just linked to one of the smaller ones and the example repo to keep it short.
\cc @timburks and @neozwu

@garrettjonesgoogle I forgot about this one... how's this look?


:sparkles: Add tested COBS implementation

code is tested, but the testing framework is.. not there
:hammer: Decide if the shortcut approach is a good idea.
:mag: Decide if we want to append a 0 to the output. I think splitting the input stream into decodable chunks (packets) is not the job of cobs::encode/cobs::decode.
:mag: Look into a streaming implementation.

@oliverlee I do not intend to merge this, I just want your feedback on how to go from here.

Ideally the test binary should be built with CMake. For now, we can add a post-build statement to Travis so that the test is run, but the return value needs to be non-zero and ideally the test error would be printed so we don't need to re-run the test locally but simply look at the Travis log.
To address the first post:

🔨 Decide if the shortcut approach is a good idea.
I'll have to look at this later.

🔍 Decide if we want to append a 0 to the output. I think splitting the input stream into decodable chunks (packets) is not the job of cobs::encode/cobs::decode.
I think it should. What's the use case for using cobs encode without appending a 0 to the output? A separate packet framing function would need to know that the data is encoded with cobs and then append a 0.

🔍 Look into a streaming implementation.
This algorithm is fairly inexpensive computationally. Would streaming be for extremely large data objects? The largest object we encode (currently) has a maximum size of 700 bytes or so.
It seems this would require most knowledge of how the data is to be streamed and would be tied to an OS for an efficient implementation. I don't see the benefit over copying bytes.

Haven't finished reviewing but added some comments.

A test thing should also be added to travis.

Why did you change from indexes to pointers? I thought the use of indexes was neat as you didn't need to make a copy of the buffer pointer.

@oliverlee change from index to pointers: The compiler will probably keep track of the pointer anyway instead of computing base + offset on every iteation.

Change enum to enum class.

Before merging I removed the unused  header from the first commit and replaced a lingering debug_assert statement with returning a struct in the last commit.


charmc: allow extra options to override standard options

Allows specifying (e.g.) -std=c++14 meaningfully

This PR changes charmc behavior so that arbitrary options passed to charmc take precedence over arguments specified with -cc-option et al, instead of the other way around as it is currently. Would it be possible to append ARG_OPTS_* to OPTS_* after OPTS_EXTRA instead of before it?

This PR changes charmc behavior so that arbitrary options passed to charmc take precedence over arguments specified with -cc-option et al, instead of the other way around as it is currently. Would it be possible to append ARG_OPTS_* to OPTS_* after OPTS_EXTRA instead of before it?

I genuinely don't know which way is better here. Are there any known users of -cc-option etc.?


Fix cocoapods integration

Use a correct file to configure the cocoapods resources integration instead of a relative path.
Fixes https://youtrack.jetbrains.com/issue/CMP-4303
Release Notes
Fixes - Resources

(prerelease fix) Fix cocoapods resources integration which leaded to a lack resources in ios apps

Describe a change for adding it to https://github.com/JetBrains/compose-multiplatform/blob/master/CHANGELOG.md

Please, fix Release Notes

Hello @terrakok!
I'm still having this issue on Kotlin 2.0.20 and CMP 1.7.0-beta02.
When I build Android, everything works as expected. However, iOS does crash due to missing resources.
Uncaught Kotlin exception: org.jetbrains.compose.resources.MissingResourceException: Missing resource with path: ..../drawable/icon.xml

This crash goes away if I close Xcode, run pod install, then open the workspace again (As you mentioned here).
But this solution with pod install isn't consistent, as it gets altered once I open Android Studio and do some operations that require clean and sync tasks.
My resources are in a separate module <root>:presentation:resources, which has composed plugin applied, this module is used inside <root>:app:composeApp, which is my shared module. It's linked to iosApp using CocoaPods (As a dynamic framework, isStatic = false)
I started facing this issue when I upgraded from Kotlin 1.9.24 and CMP 1.6.11. I used to have a script in Build Phase to copy resources, and it worked just fine. But I removed this script as I suppose multimodule support is now available since 2.0, and it became redundant.
Is there something I might have missed during migration?


Letters only doesn't work properly with React 16.

Hi.
Im using ([a-zA-Z\s])+ to get an only letters input mask but only accept one character.

Hi @fdorantesm, I think the mask prop of the MaskedInput component accepts an array of regular expressions that match a single character each, while your regular expression matches any number of characters.
For your use case you could consider passing a mask function instead.
Try with:
<ReactTextMask
  mask={s => Array.from(s).map(() => /[a-z]/i)}
  guide={false}
/>

Notice that we set guide to false so that when a newly added character does not match our regular expression it is not added to the input as an empty placeholder (e.g., _).
Have a look at the docs for more info ;)


How to enable C++ linters?

I'm using all the default settings with the exception of:
let g:ale_ling_on_enter=0

What do I need to enable to catch C++ errors like a missing semi-colon etc.? eg.
int a=5

You need to install a C++ compiler or one of the C++ programs for checking your code. Consult the documentation for each program. There are links to the websites for each in the README.

Also check out the output of :ALEInfo. You may need to change the options for one of the compilers if you are using an older compiler version.


CreateDirectConversationAsync return “Bad format of conversation ID“”

Version
What package version of the SDK are you using.
<IP_ADDRESS>
Describe the bug
Give a clear and concise description of what the bug is.
I want to init conversation with a user via 1:1 chat in MSTeams Channel. I use the below sample to implement this.  But I got the next error. Why this? I got the Bot Channel Account & User Channel Account from "ConversationUpdate".
To Reproduce
Steps to reproduce the behavior:
1.Get access_token.
2. Post the request:https://smba.trafficmanager.net/amer/v3/conversations, with {   "bot": {     "id": {botId},     "name": {botName},   },   "members": [     {       "id": {userId},       "name": {userName},       "aadObjectId": {userAadObjectId}     }   ] }
3. Observe the bug:
Expected behavior
Return the conversation info.
Screenshots

Updates: It's so wired when I try it again with the exactly same request, I got next error not like yesterday:

when I add the tenantId, I got this error:

My botId is 96c84039-7160-48d1-a1cd-809b7e292892. You can use this to find the log. Timestamp: I just tried these two requests in last 10 minutes.

Hi @hulin17
Can you confirm the version you are running? Is it 4.10.3 or 4.13.0 ?

Hi @dmvtech, Confirmed for 4.10.3.  I also used postman to test this. You can check with the screenshots.

Thank you @hulin17. I can reproduce the original error. I'm continuing to troubleshoot.

Apologies for the delay. I am still investigating.

Can we try the latest SDK version, which is 4.17.1?

Closing due to lack of response.

Apologies for the delay. @dmvtech @tracyboehrer. I also used Postman to test this. This is still repro. Do you guys find the root cause of this?

Wow great support there


Cannot load coverage file

Using VS code 1.26 and coverage gutters 2.1.1
Coverage file is not loaded automatically, even though it resides in root and names Icov.info. When I execute preview coverage report - no files are shown.

Not sure if that's important but I'm using C# and generating the icov file using coverlet.

I'm also running into this issue. I use istanbul & nyc so my icov file is in a coverage directory. I've also tried moving it into the root directory and still get the same error.

@sinapis Thanks for submitting an issue. I havent looked lately into the preview report functionality so I will have to take a look at that for the next bugfix release (2.1.2). In the meantime can you install [0] and see if version 2.0.x allows you to still use the preview functionality?
[0] https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

Same here ! How can I help to resolve this ?

for me neither 1.3.0 or 2.0.1 worked.
any suggestions to make this work would be very welcome...

I found that 2.2.0 works fine on Mac, I couldn't get it to pick up the lcov file on Windows. I'm assuming it has something to do with the path to the lcov file.

I'm on windows so we get a consistent behavior

Thanks for the extra info everyone. @nverinaud @sinapis and @mulligan121 and you try a few things for me and paste the resulting logs here?

checkout this repo and open the examples folder in vscode
turn on the coverage watch
open a source file or two from each of the language folders

You should all get something similar to this:
[1537324127343][coverageservice]: INITIALIZING
[1537324133723][coverageservice]: LOADING
[1537324133773][coverageservice]: Loading 5 file(s)
[1537324133857][lcovparser][convertPartialPathsToAbsolute]: Error: Found too many files with partial path __init__.py
[1537324133996][coverageservice]: Caching 13 coverage(s)
[1537324133997][coverageservice]: READY
[1537324139781][coverageservice]: RENDERING
[1537324139783][renderer][section file path]: c:\dev\vscode-coverage-gutters\example\python\python\foobar\tests\foo\a.py
[1537324139784][coverageservice]: READY
[1537324145722][coverageservice]: RENDERING
[1537324145723][coverageservice]: READY
[1537324145785][coverageservice]: RENDERING
[1537324145786][renderer][section file path]: /home/ryan/dev/vscode-coverage-gutters/example/php/src/testCoverage/testMain2/main2.php
[1537324145791][coverageservice]: READY
[1537324155317][coverageservice]: RENDERING
[1537324155317][coverageservice]: READY
[1537324155353][coverageservice]: RENDERING
[1537324155354][renderer][section file path]: c:\dev\vscode-coverage-gutters\example\java\my-app\src\main\java\com\mycompany\app\App.java
[1537324155359][coverageservice]: READY
[1537324158623][coverageservice]: RENDERING
[1537324158624][coverageservice]: READY
[1537324159037][coverageservice]: RENDERING
[1537324159037][renderer][section file path]: /mnt/c/dev/vscode-coverage-gutters/example/node/test-coverage.js
[1537324159051][coverageservice]: READY

Hopefully we can get this worked out!

Same here... on Mac version 1.3.1

@mcauto version 1.3.1 is quite old can you try the latest version (2.2.0)?

@ryanluker
I installed it from vscode marketplace.
Before download

After download

I finally found some free time to debug the issue I was having on my Windows machine. If you have symlinks in any directory when coverage gutters looks for the lcov file it will throw an EPERM error.
glob error Error: EPERM: operation not permitted, scandir `<DIRECTORY>`

This is a really common issue when file crawling on Windows and I've ran into it with multiple node modules in the past. If I have time in the next few days I'll see if I can find a fix for this.

@mcauto I think microsoft keeps old builds of my extension and then gives you the one that best matches your vscode version (2.2.0 requires 1.27.x and up for example). Do you have the latest vscode version?

@ryanluker
My vscode version is 1.19.2
so I updated vscode 1.27.x version.
but occur same error.. could not find a Coverage file.

@mcauto depending on the positioning of the coverage file (needs to be in the folder / workspace you have open) it will cause you to get this error. Can you look at the example project(s) and see if you can get the coverage to be picked up by using their folder structure? https://github.com/ryanluker/vscode-coverage-gutters/tree/master/example

@ryanluker
I want to use coverage-gutters on this project
positioning of coverage file is this project root path.
What should I do? help me..

@mcauto the next release (2.2.1) will have some improvements to the relative path detection and the conversion to absolute paths, once that is out let me know if the issue still exists.
@mulligan121 I am thinking a way to fix this would be to allow a manual coverage file(s) settings.json attribute that people could set instead of the automatic one. I created a new feature ticket here for that #178

Doesn't work at Windows, but works perfectly at Linux-Kubuntu 18.04.
The error is the same, can't load the lcov file.
I guess that it's something with the absolute paths of the lcov file.
Language: C# .Net Core
OS: Windows 10 x64
VSCode : Latest
Testing Framework: coverlet - https://github.com/tonerdo/coverlet
Coverage Gutters: 2.2.1

@ryanluker turns out it was an issue with the generated symlinks with the framework I was using. Windows classifies symlinks as either files, directories, or junctions (unlike unix based systems). The symlinks were being treated as files when they were actually directories, causing the issue with glob. We switched over to junctions instead and coverage gutters works fine on Windows for me now.

@ryanluker all the example projects worked. I use coverlet and dotnet core for this project. I can produce a sample of lcov.info in case that helps.

@tomchavakis yes a sample lcov.info would assist in the debugging thanks.

navigate to the test folder and generate the coverage file
dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:CoverletOutput=./lcov.info Example.csproj
After running again the command it is possible to view the coverage-gutters.

@tomchavakis that will create a single lcov.info for each test project and coverage gutters won't merge it's coverage results (I think it shows the results of the last file it finds) so that needs to be done beforehand with coverlet.
The way this is done is by supplying these arguments: "dotnet-test-explorer.testArguments": "--filter Category!=Integration /p:CollectCoverage=true \"/p:CoverletOutputFormat=\\\"json,lcov\\\"\" /p:CoverletOutput=..\\lcov /p:MergeWith=..\\lcov.json" (yes including all the escaping and extra quotes)
This will create a lcov.json and lcov.info in the root of the workspace and it'll merge the coverage.json each run and then generate a lcov.info based on that merged file. So the endresult is 1 big lcov.info file with coverage from all test projects.
There is still an issue here, because it'll merge with any existing lcov.json file, also one from a previous run. So there's still some work to do at the coverlet plugin. Other issues are that it'll not update the merged file properly when removing tests (it seems only to add coverage and not remove lines that aren't covered anymore) and it'll crash if there isn't a file to merge with (which is troublesome with the first project you'll run tests on).
For now I did 2 things:

Write the merged coverage files not to the root, but to 1 single project directory (although there are more), this fixes the problem with coveragegutters not picking up the file.

"dotnet-test-explorer.testArguments": "--filter Category!=Integration /p:CollectCoverage=true \"/p:CoverletOutputFormat=\\\"json,lcov\\\"\" /p:CoverletOutput=..\\Project\\lcov /p:MergeWith=..\\Project\\lcov.json",

Altered the csproj of one of the testproject (not the actual implementation, that gets build more than once) to include this:

lcov.empty is an empty json file, so that will result in a clean slate each time coveragegutters runs, builds all projects and executes all tests. Coverage won't be updated when executing single tests.
Sorry for a long and maybe difficult to follow answer, but thought I'd share what resulted in a workable solution for me.

@rvanmaanen thank you very much for the detailed answer. It is very useful to merge the lcov from different projects and the explanation was great !!!

I can't produce lcov file, my project is C++ and I use OpenCppCoverage which is able to produce cov.xml only...

@tomchavakis were you able to get the coverage to show after using @rvanmaanen 's detailed example? @Shelim the extension will look for a few default coverage file names and should be able to pick up cov.xml, you can change the names it looks for by setting a different array string here https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L127.

@ryanluker I've already tried that... It would be better if I could specify the path inside project to the directory containing cov.xml ; If this matter, I have multi-root workspace in VS Code

@ryanluker the @rvanmaanen answer was really helpful. When I ran again the coverlet command in order to generate the lcov file I get the coverage display from VS Code. So the issue has been resolved from my end.

@Shelim that makes sense I have a ticket open to track that feature https://github.com/ryanluker/vscode-coverage-gutters/issues/178 already so I will close this ticket in the meantime as most of the other issues have been solved in here.


Use BSON for remote mongo calls

This PR integrates BSON in the AppServiceClient and RemoteMongoCollection classes. By using BSON we remove a lot of string to json parsing. This also cleans up the object store API.

@ironage PTAL. I fixed up the BSON implementation to use unique pointers, and cleaned up the service client implementation a bit as well. call_function has also been exposed.


Check all URLs for validity

After we implement #12, let's make a script that checks all URLs for their validity (we can ping them and they return 200 code).

@blablatdinov maybe you can help?

@yegor256 Yes, gladly. Should script must fail on link invalid?

@blablatdinov yes, if the link is not valid, we should fail

@yegor256 issue may be closed


Doc issues

[x] Semicolon crept into paypal.request.post(...); - https://developer.paypal.com/docs/integration/direct/express-checkout/integration-jsv4/advanced-integration/
[x] data.payment should be actions.payment.get() - https://developer.paypal.com/docs/integration/direct/express-checkout/integration-jsv4/basic-integration/
[x] Need to remove data-version-4 now v4 is ramped to 100%
[x] Remove all references to window.paypalCheckoutReady

pending merge

Merged


Release 3.0.0 alpha.20

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.928%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
2841

Relevant Lines:
3685

💛  - Coveralls


Update index.html.md

Updated grammar.

many travis errors, can you check them out?

not sure how to read the travis issue, seems like a trivial edit


 We should pin each package to current version, available via https://packagemanager.rstudio.com/client/#/repos/1/packages

Closed by https://github.com/2i2c-org/pangeo-hubs/pull/6 :tada:

Hey all - I think this one never got deployed (at least, I see an ❌ in the deployment field)

I need to open an issue about getting the GitHub actions fixed, @choldgraf. Currently this is deployed manually.

Hello! Apologies if this is not the appropriate place for this request (I'm still learning how to use GitHub). I would like to request an update of the VAST package to the latest 3.7.0 version. Please let me know if I should open a new issue for this.

@caitlinkroeger heya! I'll try to get this done over the weekend, and if not by Monday.

Thank you @yuvipanda - I'll keep an eye out for the update!

Hi! Just curious if any progress on updating VAST? Thank you!
On Fri, Jun 11, 2021 at 1:37 PM Yuvi Panda @.***> wrote:

@caitlinkroeger https://github.com/caitlinkroeger heya! I'll try to get
this done over the weekend, and if not by Monday.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/pangeo-hubs/issues/2#issuecomment-859898413,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2H5VBT4GPDXIKQAGJ4KOLTSJXX3ANCNFSM4TDWJUSQ
.

@caitlinkroeger can you check now? Hopefully over the next week or two we'll be able to migrate the farallon hub to our new infrastructure setup (https://github.com/2i2c-org/pilot-hubs/issues/368) that will make these kinda updates faster. Apologies for the delay in this case.

Thank you for working on updating the VAST package! I received the
following warning when I loaded the package:
Warning message:
In checkMatrixPackageVersion() : Package version inconsistency detected.
TMB was built with Matrix version 1.3.4
Current Matrix version is 1.3.2
Please re-install 'TMB' from source using install.packages('TMB', type
= 'source') or ask CRAN for a binary version of 'TMB' matching CRAN's
'Matrix' package
On Tue, Jun 22, 2021 at 11:01 AM Yuvi Panda @.***>
wrote:

@caitlinkroeger https://github.com/caitlinkroeger can you check now?
Hopefully over the next week or two we'll be able to migrate the farallon
hub to our new infrastructure setup (2i2c-org/pilot-hubs#368
https://github.com/2i2c-org/pilot-hubs/issues/368) that will make these
kinda updates faster. Apologies for the delay in this case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/pangeo-hubs/issues/2#issuecomment-866210082,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2H5VD4UYUXGOUEC3OQD7LTUDFX5ANCNFSM4TDWJUSQ
.

@caitlinkroeger I've updated the version of the 'matrix' package too! I've also moved the farallon hub to a different cluster - but nothing should be different from your end! Can you let us know if anything seems off? Thanks

Hello! Thank you for the update! The VAST installation is working well but
I am trying to plot some maps from the model output with code that worked
before the update and I'm getting an error that I need the package
'lwgeom'. Is emailing here okay for such requests or is there a better
place to ask for package installations in the future? Thank you!
On Wed, Jun 23, 2021 at 9:54 AM Yuvi Panda @.***> wrote:

@caitlinkroeger https://github.com/caitlinkroeger I've updated the
version of the 'matrix' package too! I've also moved the farallon hub to a
different cluster - but nothing should be different from your end! Can you
let us know if anything seems off? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/2i2c-org/pangeo-hubs/issues/2#issuecomment-867003292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO2H5VEDQCJYP5A3ZUFNRMTTUIGUTANCNFSM4TDWJUSQ
.

hey @caitlinkroeger - think you could open a new issue about this new package? I think that'll be easier to track than using this issue. You could use this issue template to do so: https://github.com/2i2c-org/pilot/issues/new?labels=enhancement&template=tech-request.md


Fix off-by-one in torch DeepAR

Issue #, if available: Fixes #2616
Description of changes: The RNN in torch DeepAR was getting dynamic features shifted by one as input.

Split prepare_rnn_input out of unroll_lagged_rnn
Add test to verify alignment of RNN inputs (target values vs dynamic features, test is failing prior to fix)
Change is breaking in that previously serialized models will not work as before (network changes)

Todo:

[x] Take the opportunity to improve the code
[x] Test effect of bug/fix (e.g. simple indicator that zeroes-out a series, model should not get it right prior to fix)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

BTW @lostella do you think the same issue also effects the transformer model?  https://github.com/awslabs/gluonts/blob/dev/src/gluonts/mx/model/transformer/_network.py#L172-L178

BTW @lostella do you think the same issue also affects the transformer model? https://github.com/awslabs/gluonts/blob/dev/src/gluonts/mx/model/transformer/_network.py#L172-L178

It's hard to say. The easiest way to verify this, I think, is to set up a small unit test what the input to whatever layer will be: in this case the tensor is split into encoder + decoder input, so one could have a method prepare those two directly and then test that lagged target values, dynamic features, and what not, are aligned as expected.

@lostella one issue i found with the lagged_sequence_values helper is that with multivariate inputs this helper doesn't return the stacked tesnsors... e.g.
# prior_input.shape torch.Size([1, 167, 137])
# input.shape torch.Size([1, 24, 137])

lags = lagged_sequence_values([0, 167], prior_input, input, dim=1)
# lags.shape torch.Size([1, 24, 137, 2])

where i would have expected torch.Size([1, 24, 137*2])


Add Road Type/Info to Garphhopper response

It would be really convenient if Graphhopper provided the road type or the road info as part of the driving instructions. This way it would be possible to display the amount of KM which are highway vs street road for instance, which would definitely allow clients to enhance the user interfaces that use Graphhopper.
The information is already provided in most of the OSM maps and I believe that it is used to calculate the duration of the different segments of the trip, hence it should be quite easy to extend the current graphhopper response for this purpose.
Thanks for your consideration

This is something we also want :)
Kind of duplicate request to #439 - so I would close this if you do think that is the case :)

I do not think that it is the same as #439 since that one only asks about the speed for each segment. This new feature request is about adding the road type information, which is different from the speed.
I do think however that both should be included, therefore I suggest that in order to close either of the requests, it would be better to merge both of them, as well as discussing what other additional information it would be wise to add.

Could you please add the "new feature" label to this issue?
Also, do you have any idea if this is something you might consider to do in the future?
Thanks!

Please see the whole discussion in #439 including my view on how this should be implemented where the requested feature would be only a special case IMO

Indeed it appears that you consider my feature request in your response, therefore I suggest to close this one.
Thanks for your quick response.


Solution - Not an issue with the program

Does anyone have the solution to the chess board puzzle. I cant run the program and have had the chess puzzle forever now and this is the only online resource ive found close to solving it.

I can't run the program either because I don't have a Windows machine any longer.
If I find some time, I'll try to make a command line version of the program and run it on .NET Core and post one of the solutions here (there are multiple solutions).

 If so, I'll close this issue.

In case anyone is interested, here is a link to the repo containing the code used to find and print the above solution. It is a re-working of the DlxLibDemo3 project.
https://github.com/taylorjg/DraughtboardPuzzleConsole


refactor: clean up the public API

These are some refactor commits to clean up the public API ... they are breaking changes.
This PR contains 8 commits, you'll want to review the changes commit by commit.
For the reasoning about the Expr::from to Expr::new change please refer to the last commit message.
I want these commits to be merged as they are, that is I do not want this PR to be squashed. Let me know if that's ok with you, then I can mark the PR as ready.

Nice cleanup. We can enable "rebase and merge" for this commit, so it would not get squashed.

Thanks :) I'd like you to merge all of my recent refactor PRs via rebasing.

Thanks :) I'd like you to merge all of my recent refactor PRs via rebasing.

Just saw this, ignore my question on the other PR!

Thanks :) I'd like you to merge all of my recent refactor PRs via rebasing.

Just saw this, ignore my question on the other PR!


how to do multi-faces tracking

hi, I issued some questions again in  https://blog.csdn.net/renhanchi/article/details/81668987, pls have a look and give some clues, thanks.

@JH-Lam I have responded.


v1.11 backports 2022-01-03

#18279 -- docs: Replace 'micro version' with 'patch version' (@pchaigno)
#18185 -- vendor: Promote controller-tools fork to cilium repo (@christarazi)
#18141 -- Fix helm chart annotations for CRDs installed by Cilium (@joestringer)
#18305 -- daemon: Fix multi-dev XDP check (@brb)
#18296 -- Improvements to excess IP release handshake (@hemanthmalla)

Once this PR is merged, you can update the PR labels via:
$ for pr in 18279 18185 18141 18305 18296; do contrib/backporting/set-labels.py $pr done 1.11; done

or with
$ make add-label branch=v1.11 issues=18279,18185,18141,18305,18296

/test-backport-1.11

Cilium L4LB XDP has been failing constantly which will be fixed by https://github.com/cilium/cilium/pull/18370. Merging.


Add targets to Makefile

This commit adds two additional Makefile targets to Makefile:
cleanup: Since operator-controller is the single point of entry and make run installs Rukpak and Cert-manager, it would be good to have a target that cleans up the cluster of controller and all its dependencies.
run-local: To be able to run the controller locally, it is useful for developments so that we need not always have to build image to test operator. This is similar to make run target in SDK generated projects (https://github.com/operator-framework/operator-sdk/blob/5cbdad9209332043b7c730856b6302edc8996faf/testdata/go/v3/memcached-operator/Makefile#L118)

cc: @dtfranz @tmshort could you please have a look.

@varshaprasad96 I think these changes are really nice, could I ask you to please rebase?

Modified and rebased the PR to address changes according to https://github.com/operator-framework/operator-controller/pull/120#discussion_r1103229092

Rebase needed again

@varshaprasad96 this needs a rebase. Do you plan to continue this work? It's been several months.

This PR has been silent for several months. I'm closing it, but please don't hesitate to re-open, if needed.


Query statement not appearing in span

Hello @justindsmith,
Sorry if this is not the right place for this kind of message.
After https://github.com/justindsmith/opentelemetry-instrumentations-js/pull/21 was merged and I pulled the latest version, I was disheartened to see that query statements were not appearing the spans.
After a couple of hours debugging, I found out that this is because that particular argument query only shows up in Raw type Prisma queries. And that for the regular queries (eg findMany) the arguments passed to the request function are not very helpful...
I spent a bit of time trying to find somewhere to grab the information from, but I was quite out of my depth as a non-Node programmer.
I also noticed that the Prisma project has started incorporating OTel directly into their project: https://github.com/prisma/prisma/tree/main/packages/instrumentation
But it's only in a 'preview' stage and quite useless at the moment.
For example, here is a span from their instrumentation:
{
   traceId: '62d8fa8c6196d98ee05098e643000b85',
   parentId: '5440f7cef2b3f2db',
   name: 'request',
   id: '8cce709152487426',
   kind: 0,
   timestamp:<PHONE_NUMBER>373138,
   duration: 11629,
   attributes: {},
   status: { code: 0 },
   events: [],
   links: []
}

But given the fact that they are building it themselves... it might be better to direct further development effort into their codebase?
I'm still going to use yours for now because as it currently stands it's 100 times more useful.
Regards,
James

Hey @jcmackie, first, yeah, this project started as a temporary instrumentation while Prisma worked on an "official" opentelemetry integration. I've been following this Prisma issue to track their progress: https://github.com/prisma/client-planning/issues/21. As you found out, it's pretty bare bones right now. Once they have better support the plan is to deprecate the opentelemetry-instrumentation-prisma-client in favor of the official one. Good reminder that I should add a note to the plugin readme about this so it's more clear the plans.
For the query of the non-raw calls, I tried the same thing you did early on but didn't find a way to easily get the sql query so I abandoned the effort. Is there a specific thing you're trying to use that query for? In my mind, the sql query generated by the prisma client is effectively a "black box" implementation detail. But I could see value in knowing the effect of different parameters on the query to understand which calls are the most expensive. For example, knowing that you're requesting a limit of 10000 instead of 10 might be useful information to know why something is taking so long.
Instead of using the raw sql as the SemanticAttributes.DB_STATEMENT, what if we just JSON.stringified the parameters passed into the prisma model call and used that output as the statement? Or maybe created some kind of union of the clientMethod and parameters. Something like this:
notes.findMany {
  where: {
    author: "jcmackie"
  },
  take: 1000
}

Would that be helpful?
Let me know if there is a specific use case where knowing the raw sql is the important though.

Hi @justindsmith
Thanks for replying, and sorry for the delay.

Is there a specific thing you're trying to use that query for? In my mind, the sql query generated by the prisma client is effectively a "black box" implementation detail.

That's a good question. I'm tracking down some performance 'issues' in an app that uses Prisma. There were two reasons I wanted to know the actual SQL query(ies) that are being executed:

It would allow me to manually run the query behind an EXPLAIN statement, which in turns provides some valuable insight into performance problems with the query or schema.
It would show subquery/nested query explosions. One of the situations I was tracking, was a case where because of relations between tables shown in the Prisma.schema, it was doing fairly large nested queries. To be honest I could have found this by studying the code and Prisma.schema more closely, but seeing the multiple queries being executed as separate spans would have made it more obvious. But I am honestly not sure if that is the right way to instrument an ORM, because as you say, it should all be an implementation detail. But I have found myself caught out several times by the weird things that ORMs do.

Would that be helpful?

I think it might be helpful for sure. :)

Okay, probably more of an advanced use case, but understanding the Prisma internals to better understand the effects of your usage and areas / queries to optimize does make sense.
Since each call to the model could translate to multiple queries being performed, we'll likely need to track these internal calls as separate spans (as you call out). Let me see if there's another function we could patch which might give us access to the raw query being executed. Since you've peeked more into the Prisma code, if you know where that query is formed / executed and can give me a pointer that would be helpful!

I took a quick look and I'm not sure we can get the raw query like you're looking for using the patching approach this library (opentelemetry-plugin-prisma-client) is using.
The sql generation / execution is happening inside the prisma/prisma-engines package, which is a rust-based, compiled binary. The prisma client operates with a graphql based intermediary that gets sent down into the engine for execution, but no real execution details (like the executed query) are sent back.
The best we could do is attach the graphql representation of the query to the span, which would like like the below, but it's not the sql query that you're looking for. Let me know if you've found anything that contradicts what I've said above though!
query {
  findManyJoke(
    take: 5
    orderBy: [
      {
         createdAt: desc
      }
    ]
    where: {
      jokesterId: "ab7d0823-4861-47fc-8b35-9b8c5d3fde7f"
    }
  ) {
    id
    name
  }
}

Yeah I was worried that something like this might happen. In my quick perusing of the Prisma repositories and the ongoing tracing work, I saw mentions of tracing in the prisma/engines repo: https://github.com/prisma/prisma-engines/pull/3064/files.
I think that what we have so far in this library (opentelemetry-plugin-prisma-client), is enough to help guide me in the performance troubleshooting I need to do. It feels like anything more will be impossible because of the Prisma :)
The only last potential option here... is somehow hooking into the events, the way that the $on function does:
https://www.prisma.io/docs/reference/api-reference/prisma-client-reference#on
Apparently if you turn on query logging you can capture the actual SQL query information before it's logged to standard out: https://www.prisma.io/docs/reference/api-reference/prisma-client-reference#log-levels
I've tested using the $on function to instrument spans... but the duration provided by that function doesn't match what the request() function does. Thoughts?
The next thing I need to do is try and make improvements to the OTel Collector X-ray exporter ;)

Following back up on this. I was able to spend some time looking at the events (thanks for the pointer!), I'm not sure they will give you exactly what you're looking for. While they do report an executed query, because the requests into the engine are executed asynchronously, there is no easy way (that I found) in associating a specific query with a specific request. For example, if I request users.findUnique and notes.findMany back to back, the event system out log out two queries (one for each request) but there is no indication of which is which. I suppose we could assume that the order is the same and pair them that way, but I'm a bit worried that's not always guaranteed to be the case, especially if the engine has to execute multiple queries to join data for a single request (though I'm not 100% sure that actually ever happens?).
At any rate, it seems that we'd have to do the association in the patched code, which could be fragile.

Ah, thanks for thoroughly investigating @justindsmith. I completely agree with your assessment. I think the solution currently offered by this package is probably the best we're going to be able to get until OTel is officially supported by the upstream Prisma libraries.
I'm going to close this issue now, thanks for all your help.

Hey all, I wanted to share that we're shipping Prisma Client tracing soon that will give you more details about execution.
Here's an early sneak peak of what's going out in our 4.2.0 release next Tuesday: https://deploy-preview-3408--prisma2-docs.netlify.app/docs/concepts/components/prisma-client/opentelemetry-tracing. It's already available in the 4.1.0 codebase if you feel like giving it a go today.
I'd love to get your feedback on our design and hit me up if you give tracing a shot in your app!


bump write-fonts to 0.6.1

$ cargo release changes
     Changes for write-fonts from write-fonts-v0.6.0 to 0.6.1
             6e1dfa7 get rid of the const/static because rustc is smarter than I thought
             25dc979 make a simple isclose function that uses a static default FloatComparator
             7a943a5 add a few tests for is_mid_point
             8c75944 check if oncurves can be implied both before and after rounding
             1bb5a33 implement OtRound for kurbo::Vec2
             b7994cc port python's math.isclose so we can match 100% fonttools
             59075aa write midpoint computation more tersely
             89803d0 check that p0,p1,p2 are collinear as well as equidistant before dropping p1
             60cb4f7 add (failing) repro for equidistant-not-collinear on-curve
             38ddfbb Stop spamming writing table

I verified locally that fontc tests continue to pass with this so it's safe to merge. It fixes at least one bug so I bumped patch


Ledger objects should have all necessary fields to identify them

Issue Description
In most cases, the ledger entry ID of an object in the ledger can be (re-)derived from the protocol & the fields of the object as stored. There are some exceptions to this rule, which means that an object is not self-contained and you need additional context or information to calculate the ID for that ledger entry.
This is not ideal; when traversing ledger data it would be nice to be able to tell right away, for example, "whose signer list is this?" without needing to iterate through all the accounts and figure that out. In some cases the additional information you need is the sequence number of a transaction, which would require you to trace back through enough transaction history to find the transaction if you just started with the object as stored.
Missing fields
The exceptions I've found are:

Escrow and PayChannel objects don't have the Sequence of the transaction that created them.

Solution: add a Sequence field (sfSequence, probably) to new PayChannel and Escrow objects.

SignerList objects don't have the AccountID of their owner

Solution: add an Owner field (sfOwner, probably) to new SignerList objects.

Note: These changes affect transaction processing so they must be on an amendment.
Now, this is not super important, and arguably it adds "bloat" to the ledger since the ledger itself is able to carry on just fine without these fields being stored. But it would improve the ability to navigate around, process, and verify the integrity of the ledger. It would also be kind of nice for consistency.

I personally don't think everyone or the majority of people would want to seek this sort of data that you would want to add, this would add unnecessary and unwanted bloat to the ledger. I might be wrong tho.

@mDuo13 I am curious about a use case for this. I'm pretty sure the API does or at least could return the ID of any of these objects, without needing to add more fields. For instance, ledger_data returns the ID of every object in the index field. https://xrpl.org/ledger_data.html


Spam del's

The code turned out to not create many variables, so not that many del's were needed.
My del logic can be simplified to:
Are we in a function end? del all variables that are not needed for the return.
I sprinkled some tiny cleanup thingys too.

DAMN, i pushed wrong (old version) of the code, i remade everything and messed up when uploading.
Closing this, sorry about the useless work :(


arktos-up.sh cluster has pod stuck in creating

Reported by @Hong-Chang
When using arktos-up.sh, all pods are stuck in "ContainerCreating" state.
After some investigation, one possible root cause is the repro machine is using a higher version docker and containerd than the one installed by hack/setup-dev-node.sh. Kubelet log has errors for a pod like this:
E0204 21:10:28.210733   11357 kuberuntime_sandbox.go:86] CreatePodSandbox for pod "k8s-vanilla-pod_default_system(bcafe723-794c-4dc7-abd0-0001f2be0fb7)" failed: rpc error: code = Unknown desc = failed to create containerd task: dial unix ^@/run/containerd/s/9301c059fde7721d97492c847112bf9951745f77ed68c01a2bae81ba9de97f36: connect: connection refused: unknown

The issue is mitigated for now by setting up a clean node using hack/setup-dev-node.sh script, hence using the "right" version of docker and other dependencies.
Need further work to understand the real root cause.

I tried different version of script, and think the issue happens in following script of mine:
echo Setup: Change Containerd
wget -qO- https://github.com/futurewei-cloud/containerd/releases/download/tenant-cni-args/containerd.zip | zcat > /tmp/containerd
chmod +x /tmp/containerd
sudo systemctl stop containerd
sudo mv /usr/bin/containerd /usr/bin/containerd.bak
sudo mv /tmp/containerd /usr/bin/
sudo systemctl restart containerd
sudo systemctl start docker
This is to replace containerd in a certain version. I think couple of month ago when doing arktos-mizar network integration, Hongwei told me the requirement. I’m not sure what’s current status of this requirement. @Hong Wei Chen, do you have any idea on this?


Fix typo

Fix typo

It looks like there's only one commit that isn't already in master here, the "README-native-tunneling.md : Fix typo." commit.  Can you resubmit that separately?  Thanks.


Entering the portal causes Curios API items to disappear

According to your testing, does the issue occur with ONLY Immersive Portals mod?
No
Forge Version
40.1.73
ImmersivePortals Version
1.4.9-rc3-mc1.18.2
Latest Log
https://gist.github.com/Gamephantom/4248142a4d3ba221f93b6c42e20e8955
Crash Report (if applicable)
No response
Steps to Reproduce

Equip an trinket in one of the Curios API Slots
Jump through an portal
Look at the Curios API slots

What You Expected
All trinkets are still there and functional.
What Happened Instead
All trinkets disappered and the effects of the trinkets also disappeared.
Additional Details
After an restart, all Curios API Items are in their slots or if you enter an vanilla portal.
Please Read and Confirm The Following

[X] I have confirmed this bug can be replicated without the use of Optifine.
[X] I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
[X] I have confirmed this does not happen on the fabric version (If it does please report to here instead).
[X] I have confirmed this issue is unique and has not been reported already.

Fixed in the latest version.


hacktoberfest-2022

add this please as this for logistic regression
Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Please explain why you think that this change is needed


Ignore type starting with underscore

Apparently types with underscore in lsp.json are just meant to be extended and not really generated.
There is an equivalent InitializeParams type for the _InitializeParams removed by this change.
Also the removed __ClientInfo_Type_24 is a duplicate of __ClientInfo_Type_13.

just a note to myself for future reference,
the __ClientInfo_Type_24 was not created because the _InitializeParams wasn't generated.


Added forcedZoom to css.

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #4030   👈

This stack of pull requests is managed by Graphite.

I see we merged https://github.com/duckduckgo/Android/pull/4049 and this PR is not blocked anymore.


Make Ranger a python package

As discussed in #20, it would be really practical to have these optimizers in a package.  This PR makes that possible. ranger can be installed and imported in all python projects, no need to copy paste the ranger optimizer anymore. This also allows to give you proper credit where it is used (I'll add it in the requirements in asteroid for example).
I also updated the README with the install and usage instruction.
You can clone the repo, then install it with pip in editable mode (pretty practical for research) or not.
Note : In the __init__.py I imported the three optimizers so that they can be imported from the package directly (from ranger import RangerQH instead of from ranger.rangerqh import RangerQH). Both ranger.py and ranger913A.py had the same name for the class, so I changed the class in ranger913A.py to RangerVA (for versionA).
I'd like to here from you, this would be very practical to have it as a package.

Hi @mpariente,
Thanks a ton for this.  I just responded on the other thread before seeing this linked in.
I'm merging it in now and thanks for fixing the naming collision. :)

It's a pleasure, thanks to you.
Just to be clear, this cannot be installed with pip just yet.
In order to pip install ranger, the package needs to be uploaded to PyPI


Implement trestle split

Issue description / feature objectives
Implement trestle split according to specifications.
Completion Criteria
Complete implementation and testing.
Expected Behavior

Be able to split subcomponent of an OSCAL model including simple JSON object, arrays and objects of type additionalProperties.

First version is done. Let's create bugs and feature requests.


transition: schedules disappear when saving line

How to reproduce:

Create a schedule for a line, choose the number fo vehicles, then generate and save schedule, the number of trips appear correctly
Save the line and reopen it, it shows 0 trips and the schedule don't exist anymore.

Note: does not happen every time, seems to be isolated, but really annoying!

This hasn't happened in ages, it should be fixed now that schedules are better handled


[feat]: the priority of flag param set should be higher than conf.json

Now when config/conf.json is set,  will omit the flag param set. We should make flag param higher priority than conf.json.


Add a way to remove a workspace from a dat

[ ] Need the controls in standard UIs
[ ] "Workspace missing" banner should have a button to just remove the WS record

hmm, There are no workspaces anymore. Is this still valid?

It's not, thanks!


[SUGGESTION] Add Support For a Counter Variable (REPUTATION)

Please add support for a counter variable into the bot's custom syntax.
Specifically, we want to implement system for limiting a user to +rep another user once.
It's a problem in a very large server like ours that we run, do you know if there is any system for that to be implemented?
I think something like a counter would be the only way to measure that, but if there is any other way you can implemenet that Id'e love to hear it. Thanks!

@jonas747 Can be closed as its now doable using db


Revert "[test/Index] Add a test case for cross-language USR generation fix on the clang side"

Reverts apple/swift#30323 test/Index/cross_language.swift is failing in internal bots

@swift-ci Please smoke test


Added Assembly x86 Code

Mera assignment bhi kar de rofl

Chintu wants to know your location :pushpin: :rofl:


Generate the php file to run from console

This step is necessary in order to place it inside /bin dir for those using the library as a composer dependency

https://github.com/nilportugues/php_backslasher/commit/28052ab395df3ec7949257f0131cdf9ce7dac28e