Bundle 3rd part modules in the preload script to allow use when sandboxing is enabled

Is your feature request related to a problem? Please describe.
When sandboxing is enabled, we can't require() an external module in the preload script. The current config bundles up all local files so that we can split our preload source code into multiple files (nice 👍). But it would be awesome if we could also use 3rd party modules such as electron-better-ipc inside our preload script while in sandbox mode.
Describe the solution you'd like
Bundle 3rd party dependencies in the preload script output, similar to how we're bundling our local source code.
Describe alternatives you've considered
Disabling sandboxing is the only solution for now.

Previously it works exacly as you described. But this led to numerous problems (https://github.com/cawa-93/vite-electron-builder/issues/664, https://github.com/cawa-93/vite-electron-builder/issues/655, https://github.com/cawa-93/vite-electron-builder/issues/613), because there are a huge number of packages that he will not be able to fully bundle. Usually these are packages that depend on native APIs directly or transitively.
If it not problem for your case, You can set ssr.noExternal: true. It

Treat all dependencies as noExternal
Throw an error if any Node.js built-ins are imported

Makes sense, thanks for the explanation!


OCPBUGS-31807: Use RotatedSigningCASecret in update only mode

UseSecretUpdateOnly is intended as a short term hack for a very specific use case,
and it works in tandem with a particular carry patch applied to the openshift kube-apiserver.
(https://github.com/openshift/kubernetes/pull/1924)
we will remove this when we migrate all of the affected secret
objects to their intended type: https://issues.redhat.com/browse/API-1800
in short tls secrets used by this operator are reconciled
by multiple controllers (the cert controller run by the operator and the same controller run by the recovery pod) at the same time without any coordination.
the issue is that the secret's crypto material
can be regenerated, which has serious consequences for the platform
as it can break external clients and the cluster itself.
xref: https://github.com/openshift/library-go/pull/1710
xref: https://github.com/openshift/kubernetes/pull/1939

/lgtm

/retest-required

/retest-required


Update tutorial and playground links (#108)

we amended these links already, thanks for your feedback.


executor: add missing mounts when podman is enabled

When podman is enabled, we need to mount some dedicated emptyDir volume into the Executor container so that podman could download and store container images onto these paths.

Rebased and bump executor chart version.
It also bump the requirement in enterprise chart, should I bump the version there as well?

Rebased and bump executor chart version.
It also bump the requirement in enterprise chart, should I bump the version there as well?

I'd just to do the executor for now - otherwise you have to do the release in two parts (the executor first, and then the apps).
If you just bump the executor chart version, the apps will pick up the new executor dependency in the next weekly release.


 options are removed when modal dialog is not shown at first

This is strange....
In order to reproduce the problem, you can use this code:
< div class="modal" >     < select >< option >Hello< /option >< /select > < /div >
The page will be rendered a (you will need to see this in Firebug, because when viewing page source, the code above will be displayed)
< div class="modal" >     < select >< /select > < /div >
If I comment JavaScript instruction that converts the DIV into RModal out, the SELECT option appears. It is strange, isn't it?
If you does not comment the JavaScript out, but change the "display" attribute to "block", so that the dialog appears initially visible, the option is shown too.
Please check it.
EDIT:
When the page loads, and see the source with Firebug, the option is still there, but, when modal is shown, using open() method, all options are gone.
Thanks

Hey there @jaimestuardo, I see that you closed the issue.
Did you find a solution to your problem?


Support audio and document as Album

Description
According to https://core.telegram.org/bots/api#sendmediagroup , telegram accepts four types of InputMedia, however, current bot.SendAlbum only parses Photo and Video.
When sending audios as album you get telebot: album entry #0 is not valid

What is the reason commit https://github.com/tucnak/telebot/commit/206507e3865e9e8cae3e428aaca683d15c64546e being reverted?
Thank you!

I will return it back soon and retest the behavior again.

v2.4


Captive portal

add CaptivePortal to Config Portal

Hi @hmueller01
Thanks for your new PR for Captive-Portal.
As this is Async library, I suggest you change to use ESPAsyncDNSServer.
Check the mods in ESPAsync_WiFiManager to use AsyncDNSServer instead of DNSServer.
Check the changes in Comparing changes
Waiting for you modified PR.
BR,

HI @hmueller01
Please also help add your PRs into sync twin library ESP_WiFiManager_Lite
BR,

Ah, ok. I didn't knew the ESP_WiFiManager_Lite ...
Maybe I change to this, as I have lots of crashes in my code with ESPAsyncWebServer. Too bad that me-no-dev drops support/development of his excellent work.
I used DNSServer as you already included that (I do not know what the dependency was/is). But ok, you are right. I'll change this in the next days.

Ok, I switched to AsyncDNSServer. Sync with non Async project ESP_WiFiManager_Lite follows ...

Merged. Thanks for your contribution. Looking forward to receiving more PRs from you.
Best Regards,

Hi @hmueller01
The new ESPAsync_WiFiManager_Lite releases v1.9.1 has just been published. Your contribution is noted in Contributions and Thanks
Best Regards,

Release v1.9.1

Add Captive Portal using AsyncDNSServer. Check Captive portal #22
Cleanup reset code. Check cleanup reset code #23
Periodical code clean-up


lcpkg not working anymore

Hi there, It seems lcpkg dependenices are deprecated and it's not working anymore.
I use this command to build lcui but it fails with the following error...

I run cmd
I cd in to the lcui source repo root
I run lcpkg install --arch x64

Here is error :
C:\Users\SystemIsCorrupt\Desktop\LCUI-2.2.0>lcpkg install
node:internal/errors:464
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:119:11)
    at Object.resolve (node:path:167:9)
    at LCPkg.resolvePackage (C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\src\index.js:106:25)
    at C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\src\index.js:135:49
    at Array.map (<anonymous>)
    at LCPkg.loadPackages (C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\src\index.js:135:30)
    at run (C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\src\cli-install.js:180:24)
    at Command.<anonymous> (C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\src\cli-install.js:230:5)
    at Command.listener [as _actionHandler] (C:\Users\SystemIsCorrupt\AppData\Roaming\npm\node_modules\lcpkg\node_modules\commander\index.js:426:31) {
  code: 'ERR_INVALID_ARG_TYPE'
}

am I doing something wrong? or is it from the lcpkg?
regards,
Marius

Have you installed vcpkg and added its path to lcpkg's configuration?

@lc-soft I just put vcpkg in c:\ and now it works! thanks for the hint!
is there anyway to get the source of libxml2-lite ?

@lc-soft I just put vcpkg in c:\ and now it works! thanks for the hint!
is there anyway to get the source of libxml2-lite ?
I want to build them using MT

Source:
https://github.com/lc-soft/LCUI/tree/develop/lcpkg/ports/libxml2-lite
It is modified from vcpkg/ports/libxml2:
https://github.com/microsoft/vcpkg/tree/master/ports/libxml2


How can I generate addresses for Copay wallet?

Copay wallet: https://github.com/bitpay/copay - I created a testnet wallet.
I am able to get a xpub address from the wallet, and trying to generate addresses:
from bitmerchant.wallet import Wallet
from bitmerchant.network import BitcoinTestNet
master_wallet = Wallet.deserialize("tpubDCz28JEwZgMKb9tmA...UiFhF", network=BitcoinTestNet)
user_wallet = master_wallet.create_new_address_for_user(0)
payment_address = user_wallet.to_address()
print payment_address

but if I send some testnet bitcoins to that address, Copay does not see any balance change.

OK, I solved the problem using an other library: https://github.com/richardkiss/pycoin/issues/165


Debug JavaScript/Python in Enso Source

Pull Request Description
Extends the TextMate grammar to recognize foreign js and foreign python blocks and colorize them properly. Assigns URI and line numbers to properly match the location of the embedded foreign code blocks. As a result VSCode debugger smoothly steps from Enso to JavaScript or Python code.
Picture

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
style guides.
All code has been tested:

[x] Code was manually tested

The sample script used for testing was:
from Standard.Base import all

invert ~one ~two =
    one-two

foreign js dbg = """
    debugger;
    function fac(n) {
      if (n <= 1) {
        debugger
        return 1;
      } else {
        return n * fac(n - 1);
      }
    }
    let r = fac(5)
    debugger
    return r

foreign python fib a = """
    def fib(x):
        if x <= 2:
            return 1
        else:
            f2 = fib(x-2)
            f1 = fib(x-1)
            return f1+f2

    return fib(a)

main = invert dbg (fib 5)

@ola-lis, can you please release new version enso4vscode-1.33.271.vsix of the Enso extension?


Vmware Horizon Doc Issue

Vmware horizon doc does not include class identifier for key.
current:
vmware_horizon
Should be:
vmware_horizon_view
https://splunk.github.io/splunk-connect-for-syslog/main/sources/vendor/VMWare/horizonview/

:tada: This issue has been resolved in version 2.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Version numbers are inconsistent

I believe this reflects the latest versions, unless I'm not fully up to date:
AU version shows in the plugin listings as 0.39.216 and 1.2.0ff0de9c within the plugin.
VST3 version shows in the plugin listings as 1.2.0 and 1.2.0ff0de9c within the plugin.
Presumably only the "0.39.216" in the AU is incorrect?

Hopefully solved by f2f37d73b040856e91260034a17ef9d221cd8dc5 !


Get lineage API give 404 if one of it's downStream/upStream node is deleted entity

Steps to reproduce:

Ingest sample_data
Delete table raw_product_catalog using delete api
Go to table details page of raw_customer
Check in Network, API /api/v1/lineage/table/name/bigquery_gcp.shopify.raw_customer?upstreamDepth=3&downstreamDepth=3 gives 404

Closing as unable to replicate post re-build


Apply latest Levenshtein optimizations and unrolling

Also it should be possible to cut the computations altogether when length diff is larger thab expected distance for bound version.


MixpanelGroupPrivate.h: compiler issue with include using angles instead of quotes

while compiling the mixpanel code the compiler errors here
https://github.com/mixpanel/mixpanel-iphone/blob/5ddcc639620f296023bed91b11a767ccbda9f3f7/Mixpanel/MixpanelGroupPrivate.h#L8
with:
error: 'MixpanelType.h' file not found with
      <angled> include; use "quotes" instead
#import <MixpanelType.h>
        ^~~~~~~~~~~~~~~~
        "MixpanelType.h"

i can probably set some compiler flags or some local setting to ignore this, but googling directly pointed out that <> usage is reserved for frameworks, and a file import should be done with double quotes '""`.
https://stackoverflow.com/questions/17465902/use-of-external-c-headers-in-objective-c
i did a search over the files for #import < and i think this is the only "wrong" usage of angles.
could you fix this very little issue for next release?

hi @samzilverberg , thanks for raising it. will fix it.

Thanks @samzilverberg , the fix has been merged into master and it will be picked up in the next release


ability to use two or more providers/ urls within the same container

is is possible to use two or more providers/ urls within the same container

I am working on this

https://github.com/hooray4me/ustreamgen/tree/EN-multiple-providers
^ this has the latest instructions.
Watch for the lateest *-dev images. currently:
docker pull ghcr.io/hooray4me/ustreamgen:v1.38-dev
One of the issues I need to solve for is how to merge identical shows/movie title from different providers...
Let me know if you think this is going in the right direction.

yes i forgot to mention this. i have couples of ideas. 1 is if there is 1 or more of the same movie then name add numering to it
like movie name (year)
movie name (year) (1)
movie name (year) (v1)
and so on
u can decide how to go about this
another idea/question i wanted to ask was about proving the files within the workflow to do some custom file naming using tools like filebot, https://github.com/jkwill87/mnamer, FFmpeg, etc.

This becomes a nightmare... because each time it runs, it only copies the files/directories that have changed or are new. and it also removes files/directories if there is no longer a strm file created from the updated m3u from the provider. There would be no way of knowing, on a given run, which of the providers created the movie.

that is sad to hear. so i take it you wont be able to make this happen ?

I think the only way to potentially make this work is to have a separate folder for each provider... like movies1 movies2 etc... then add those individual folders to emby in the same library.

i can work with that but do u think emby will be happy with that? so about the file probing is no go then as well?

I've had a scenario where I added multiple folders to the same library. It should be able to handle that

ok that sounds good if not am fine with adding the individual folders to emby. let me know when u have more info/ test image on this.

I'd be curious, for movies, if it will show the movie twice, or group it into a collection. I have to make some variable changes for that to work. I'll let you know when I have something for you to test.

for same movies there is a plugin that group them
together, i will share it later on

review the updated readme in this dev branch https://github.com/hooray4me/ustreamgen/tree/EN-multiple-providers on how to setup. Use this image: docker pull ghcr.io/hooray4me/ustreamgen:v1.39-dev

ok will do and report back

LMK what you find

cant get this to work, please get on discord whenber u can so we can discuss a little more, thanks.


Provide API to help getting the verification file in tests

Is the feature request related to a problem
I have an API which I am testing and I need to ensure that the data that I send is the same data that I receive. Sometimes it is not practical to have the data embedded in the C# code, instead I want to have it as a separate file. It would be nice if I could use the file which is used for verification before doing the Verify. Currently there is no easy way to get the path to the file which is used by the Verifier.
Describe the solution
Provide an API to get the file path of the file used for verification, e.g. string Verifier.GetVerificationFilePath() or even to read the entire file string Verifier.GetVerificationFileJson(), byte[] Verifier.GetVerificationFileBytes() etc.
Describe alternatives considered
The file path can be hardcoded but it would have to be changed in the test whenever the verifier settings or file location change.
Additional context
-

can you give an example test that uses this theoretical api

bunp


Trade completed message pops up 3x as soon as bot starts up

As soon as the bot has connected to steam it sends me 3x messages saying trade completed, is it counting already completed trades? Have I done something wrong?

Also, what's wrong with my code? The bot doesn't respond at all.
public bool Validate ()
        {
            int OfferedItemAmount = 0;
            foreach (var items in Trade.MyOfferedItems)
            {
                OfferedItemAmount++;
            }

            if (OfferedItemAmount > 0)
            {
                Trade.CancelTrade();
            } else
            {

                Trade.AcceptTrade();
            }

Bump, still having issues. Now it sends 4 messages at startup.

@gaffelosked You probably haven't done anything wrong. I get messages from prior trades as well.
I guess this issue isn't active anymore? So this can probably be closed.


ctrl-a/ctrl-x don't work in vim mode

Check for existing issues

[X] Completed

Describe the feature
In vim, ctrl-a/ctrl-x mean increment/decrement a number under the current cursor.
For increment, -2 becomes -1 becomes 0 becomes 1, becomes 2, etc.
For decrement, 2 becomes 1 becomes 0 becomes -1 becomes -2, etc.
It is not float aware, so 1.1 will change to 2.1 or 1.2 depending on which side you have under your cursor.
If applicable, add mockups / screenshots to help present your vision of the feature
No response

This is fixed in v0.107 (currently in preview)


Warning: characteristic 'Current Temperature':

Hello, thank you for all the effort. I have an issue I cannot seem to sort. I am running on a Raspberry Pi Zero.
The sensor is functional via dht22 command, but the errors in homebridge are still more common than readings. Readings are sucessful every 20-100 trys.
Homebridge version v1.3.4
Any thoughts would be much appreciated.
here is a copy of the diagnoistic log:
[3/25/2021, 8:54:26 PM] Homebridge v1.3.4 (Homebridge 1B9B) is running on port 51843.
[3/25/2021, 8:54:26 PM] [Room] read data from Room : {"firstEntry":0,"lastEntry":268,"usedMemory":268,"refTime":638313503,"initialTime":1616620703,"history":["noValue",{"time":1616620703,"setRefTime":1},{"temp":23.7,"humidity":43.1,"time":1616620703}
[3/25/2021, 8:54:26 PM] [Room] History Loaded from Persistant Storage
[3/25/2021, 8:54:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:54:29 PM] [homebridge-dht] This plugin generated a warning from the characteristic 'Current Temperature': characteristic value expected valid finite number and received "undefined" (undefined). See https://git.io/JtMGR for more info.
[3/25/2021, 8:54:29 PM] [homebridge-dht] Error:
at CurrentTemperature.Characteristic.characteristicWarning (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2038:105)
at CurrentTemperature.Characteristic.validateUserInput (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1931:16)
at CurrentTemperature.Characteristic.setValue (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1298:20)
at TemperatureSensor.Service.setCharacteristic (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Service.ts:459:35)
at DhtAccessory. (/usr/local/lib/node_modules/homebridge-dht/index.js:193:14)
at DhtAccessory. (/usr/local/lib/node_modules/homebridge-dht/index.js:103:9)
[3/25/2021, 8:54:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:55:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:55:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:56:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:56:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:57:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:57:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:58:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:58:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:59:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 8:59:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:00:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:00:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:01:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:01:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:02:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:02:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:03:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:03:56 PM] [Room] DHT Status: 0, Temperature: 24.4°C, Humidity: 33.5%
[3/25/2021, 9:03:56 PM] [Room] **Fakegato-timer: addData  Room { time:<PHONE_NUMBER>, temp: 24.4, humidity: 33.5 }  immediate:  false
[3/25/2021, 9:03:56 PM] [Room] Start Global Fakegato-Timer - 5min
[3/25/2021, 9:04:27 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:04:57 PM] [Room] Error: [Error: failed to read sensor]
[3/25/2021, 9:05:27 PM] [Room] Error: [Error: failed to read sensor]

here is the fix for the characterisitc issue. However, the sensor still reads only sporatiacally.
    this.humidityService
      .getCharacteristic(Characteristic.CurrentRelativeHumidity).updateValue(roundInt(humidity));
    callback(err, roundInt(temperature));
  } else {
    this.log.error("Error:", err);
    **callback(err, 0); //added 0 to complete the callback**

Are you sure your not having a hardware issue with your setup ?  ie device or wiring
In my similar setup ( I have 4 of these running ) I don't have the same issue


Implicit DateIso8601 Converters

Describe the bug
There's a strange developer usability issue with DateTimeIso8601.
In the DateTimeIso8601 class, there's an internal String constructor, we did this likely to keep people from using it. However, passing a string to the ctor is still semantically correct because there's an implicit operator override on DateIso8601 (no time) that converts string -> DateIso8601.
So, I have a datetime value as a string, I try to pass it to:
new DateTimeIso8601("2024-01-01T00:00:00")
This implicitly tries to convert it to a DateIso which fails since it has time values in the string.
To Reproduce
new DateTimeIso8601("2024-01-01T00:00:00")
Expected behavior
Instantiation of a DateTimeIso8601
Screenshots

Version used:

Latest

I can see the value in declarations like this:
DateIso8601 date = "2024-01-16";
This, in particular, is similar to CQL's @2024-01-16 shorthand for Date(2024,01,16) concept.
I think we have two directions we can take:

Implicit string-to-ISO conversions for Date, DateTime, and Time, which requires making the string ctors public to prevent the issue described here
Explicit string-to-ISO conversions and leave the string ctors private
Eliminate this implicit cast

If we go with option 1 or 2, we should fix the body of this operator to use TryParse.  Not sure why we would have two implementations that parse a string.

This "surprise" behaviour that Patrick described is exactly why I am using implicit operators very sparingly, especially on common types like strings. So I am not a fan of 1), and would like to do 3).  In the .NET SDK I would now use the "TryParse" pattern, so IsoDate.TryParse("string") - and not a constructor, since I don't like constructors to throw.

https://github.com/FirelyTeam/firely-cql-sdk/pull/138


Reproduction Rate <How often could you reproduce this issue, how often do you tried?>

Steps to Reproduce

Result
<What is the result of this?>
Expected Result
<What is the expected result?>
Additional Information
<Which version? Which operating system? Any other information?>

Sorry; I accidentally created this issue using the hub tool.


[Automation] Generate Fluent Lite from Swagger devcenter#package-2024-02

[Automation] Generate Fluent Lite from Swagger devcenter#package-2024-02

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-devcenter


[ToB Audit] #7: PyInstaller binaries should be distributed with signatures

Description
The deposit tool is distributed as binary files compiled using PyInstaller, but without any way for users to verify their authenticity.
The deposit tool is compiled to a single binary using PyInstaller to be released on GitHub.
However, there is no way for users to check that these binaries are compiled by someone
from the Ethereum 2.0 development team.
Exploit Scenario
Eve compromises the security of the GitHub account used to upload the deposit binaries and replaces the binaries with backdoored versions. Alice downloads the released binaries and her keys are compromised.
Recommendation
Short term, include signatures to allow users to verify the released binaries. We recommend using gpg with public keys uploaded to public servers.
Long term, review the chain of trust of the precompiled releases used to generate private keys.

I would really prefer signed releases.


Delete appveyor.yml as don't use there.

TICKET submitted, too. https://issues.apache.org/jira/browse/INFRA-19955


On Onchange of the text, getting Cannot read property 'getEditorText'

Hi, I am using Jodit for the html editor. But getting few errors with it.
I am using it with react 16.12
I am importing jodit like
import 'jodit';
import 'jodit/build/jodit.min.css';
import JoditEditor from "jodit-react";
const config = {
readonly: false,
minHeight: 500
};

Any help is appreciated

props does not accept config
this is an internal problem


[Request-For-External] Page 39 "General Journal" - UpdateBalance

Hi, could you please change the local UpdateBalance procedure of page 39 (General Journal) to a global one?
    procedure UpdateBalance()
    begin
        GenJnlManagement.CalcBalance(Rec, xRec, Balance, TotalBalance, ShowBalance, ShowTotalBalance);
        BalanceVisible := ShowBalance;
        TotalBalanceVisible := ShowTotalBalance;
        if ShowTotalBalance then
            NumberOfRecords := Count();
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 45938.


Insert Title Here

Describe the issue in detail here. Attach any relevant screenshots or files. The section below was automatically generated. Remove any information that you do not wish to include in the report.

Debug Data

Property
Value

Name
"Wolfram/Chatbook"

Version
"1.0.1"

EvaluationEnvironment
"Session"

FrontEndVersion
"Desktop: 13.3 for Mac OS X x86 (64-bit) (June 8, 2023)"

KernelVersion
"13.3.0 for Mac OS X x86 (64-bit) (June 8, 2023)"

SystemID
"MacOSX-x86-64"

Notebooks
True

DynamicEvaluation
False

SynchronousEvaluation
False

TaskEvaluation
False

Settings
Inherited

Stack Data
throwFailure
trimURL

Failure Data
<|
  "Evaluation" :> Wolfram`Chatbook`Actions`EvaluateChatInput[CellObject["f755e700-3e65-4770-a094-d8f6d3cc963b", "13e40053-c803-422f-83dd-cbfbf4060e2f"]]
  "Arguments" -> {}
|>

@matusPlch, can you describe any steps that could reproduce this error? Looking at that failure data, it appears that the evaluation cell given to EvaluateChatInput was not a valid chat input cell, since it didn't match any of these definitions:
https://github.com/WolframResearch/Chatbook/blob/ccbf29136063e60e9129869139c61d0165b08ff0/Source/Chatbook/Actions.wl#L291-L316
However, I'm not sure what conditions could have led to that situation.

I believe that this issue should be resolved by the various updates that went towards improving #187.


KAFKA-8465:make sure that the copy of the same topic is evenly distributed across a broker's disk.

Make sure that the copy of the same topic is evenly distributed across a broker's disk.
When some partiton's replication is assigned to a broker, which disks should these copies be placed on the broker? The original strategy is to allocate according to the number of partiitons。This strategy will result in uneven disk allocation for the topic dimension.
In order to solve this problem, we propose an improved strategy: first ensure that the number of partitions of each disk in the topic dimension is even. If the number of partitions of a topic on two disks is equal, then sort according to the total number of partitions on the disk. Select a disk with the least number of partitions to store the current replication.

@stanislavkozlovski @ijuma  @hachikuji  @mjsax   For the copy storage strategy of the partition of each disk in the broker, I made some improvements, so that the disk copy of the topic dimension is uniform, thus avoiding the io hot issue, I hope to get your attention.

Thanks for the PR @lordcheng10! The JIRA ticket has a great description too.
I assume the current behavior was chosen for some reason, although I'm not exactly sure why that is. Perhaps it's to eventually naturally balance out the partitions per disk if a new disk is added to a broker.
To me, it sounds like the behavior you're proposing makes more sense. Users can run a dir reassignment if they are to add a new disk.
I'm wondering:

Should we have a KIP for this? It does change the behavior although I am not sure how much  users depend on it
Should we support both strategies and have them be configurable
Should we extend the tools to support balancing topic partitions across directories? I may be wrong, but I think that users currently have to manually build a JSON mapping of each partition to a log directory. If the goal is to spread them evenly across directories, this can easily be automated by our tools

I think we should probably discuss this behavior change on a KIP, even if we ended not needing to add any new configs to make this strategy exposed to users.
Also cc @junrao @gwenshap @ijuma


[BugFix] GymWrapper does not work with nested observation gym.spaces.Dict #640

Description
Possible bug fix for the issue mentioned in #640 that prevents to use nested gym.spaces.Dict due to naming errors with the "next_" word beginning of observations. This bug fix uses recursive functions to rename observations correctly for gym environments with nested gym.spaces.Dict spaces. Some ideas for tests have been added.
Motivation and Context
Close #640

[x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[x] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

Thanks for this!
The solution looks great!
I'm in the process of refactoring the step logic.
The first step is to remove "next_" from the observation spec and add it in env.step after we call env._step, have a look at this: #661
Next I will refactor that in having the next observation in tensordict["next"] rather than tensordict["next_stuff"].
This is a long process that involves multiple layers of refactoring, I would expect it to land by the end of week / early next week.
Would you be willing to wait until them for me to finish this up?
In the meantime, if you need this feature, you can work from this branch.
Does that sound ok?
Am I missing anything with this refactoring?

Sure, sounds perfectly fine and I don't think you're missing anything there!
Looking forward to seeing your changes, please let me know if I can be of any help :)


Lesson 4 polish

Docs Build status updates of commit 8865ad3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3384547:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch5.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md

Line 31: [Warning] Invalid file link:(~/mrlearning-base-ch1).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 141afb3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Test - Add workflow to build draft binaries (QA)

Step1 of #1380
This is a test to try building draft binaries in order to test epinio upgrade.
I cannot test it without merging the PR.

Codecov Report

Merging #1523 (1cb64bf) into main (6899663) will decrease coverage by 49.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #1523       +/-   ##
==========================================
- Coverage   58.01%   8.75%   -49.27%
==========================================
  Files         167      83       -84
  Lines       12281    8090     -4191
==========================================
- Hits         7125     708     -6417
- Misses       4166    7336     +3170
+ Partials      990      46      -944

Flag
Coverage Δ

acceptance-apps
?

acceptance-cli
?

unittests
8.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

main.go
0.00% <0.00%> (-100.00%)
:arrow_down:

helpers/string.go
0.00% <0.00%> (-100.00%)
:arrow_down:

internal/api/v1/authtoken.go
0.00% <0.00%> (-100.00%)
:arrow_down:

internal/auth/certs.go
0.00% <0.00%> (-85.00%)
:arrow_down:

internal/application/secret.go
0.00% <0.00%> (-80.86%)
:arrow_down:

internal/cli/usercmd/configuration.go
0.00% <0.00%> (-76.67%)
:arrow_down:

internal/cli/usercmd/push.go
1.49% <0.00%> (-76.62%)
:arrow_down:

internal/api/v1/application/stage.go
0.00% <0.00%> (-74.68%)
:arrow_down:

internal/configurations/configurations.go
0.00% <0.00%> (-73.40%)
:arrow_down:

internal/cli/usercmd/namespace.go
1.39% <0.00%> (-71.33%)
:arrow_down:

... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6899663...1cb64bf. Read the comment docs.


URL Parameter

Hey there, one feature I would really like to see from this application is a URL parameter for opening an image URL when the page opens. Something like https://jspaint.app/?imageURL=https://upload.wikimedia.org/wikipedia/commons/thumb/1/11/Test-Logo.svg/783px-Test-Logo.svg.png.
Is this something that you would merge if I made it work and made a PR, or should I just keep the changes private? Or if you wanted to add the feature that would be cool too, but I'm sure you have enough on your plate :)

It already exists! :smiley:
https://jspaint.app/#load:https://upload.wikimedia.org/wikipedia/commons/thumb/1/11/Test-Logo.svg/783px-Test-Logo.svg.png

Perfect, thank you!


Form rendering for Django's new DurationField

It would be nice to come up with a good interface for django's DurationField. I'll try and come up with a PR.

OK, I haven't worked with this field myself so any input is welcome.


Adding ExecutorProvider support while creating BigQueryReadClient

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #2071  ☕
If you write sample code, please follow the samples format.

R: @Neenu1995


Randomness

I want to support randomness at some point, but I don't want to encode randomness into the protocol hierarchy. I suspect I'll just need a generic way of requesting uninitialized memory up to a limit or the size of the given type.

I can derive randomness with something like this:
protocol BinaryInteger {
    static func uninitialized(
        count limit: PartialRangeUpTo<UX>,
        repeating appendix: Bit,
        init delegate: (MutableDataInt<Element.Magnitude>) -> Void
    ) -> Self
}

But I'm not yet convinced it is the function I want.

init(load: DataInt) is similar, but involves unnecessary copying in the arbitrary case.

It's a bit finicky, but the following examples generates the same machine code:

UInt32.random(using:)
UInt32.randomInARoundaboutWay(using:)

Godbolt: https://swift.godbolt.org/z/E6jeoMYbP
extension UInt32 {
    static func random(using randomness: inout SystemRandomNumberGenerator) -> Self {
        randomness.next()
    }
}

extension UInt32 {
    static func randomInARoundaboutWay(using randomness: inout SystemRandomNumberGenerator) -> Self {
        Self.uninitialized(count: ...1) {
            for index in $0.indices {
                $0.initializeElement(at: index, to: randomness.next())
            }
        }
    }

    static func uninitialized(count: PartialRangeThrough<Int>, init: (UnsafeMutableBufferPointer<Self>) -> Void) -> Self {
        var instance = Self()

        Swift.withUnsafeMutablePointer(to: &instance) {
            `init`(UnsafeMutableBufferPointer(start: $0, count: Swift.min(1, count.upperBound)))
        }

        return instance
    }
}

A method like random(maxBitWidth:) might be niche enough that only arbitrary integers find it useful, but the thing that makes me think (#48) might be useful is that random(in: ClosedRange<Self>) always makes sense.

I'm considering the following protocol, plus two random numbers generators. One generator should just wrap Swift.SystemRandomNumberGenerator and one the other should be deterministic and seeded.
public protocol Randomness {

    associatedtype Element: SystemsInteger & UnsignedInteger

    @inlinable mutating func next() -> Element

    @inlinable mutating func fill(_ memory: UnsafeMutableRawBufferPointer)
}

It turns out that PRNGs is the most opinionated subject ever. ChaCha20?

Hm. I now have a method like this, but I'm still not sure when it's best to BinaryInteger or Randomness:
extension BinaryInteger {

    /// Generates random bits through the given `index`.
    ///
    /// Signed integers are extended by the most significant bit wheras unsigned
    /// integer are extended by zero. You may bit cast a different type to adopt
    /// its behavior.
    ///
    ///                ┌──────────┬──────────┬──────────┐
    ///                │ index: 0 │ index: 1 │ index: 2 │
    ///     ┌──────────┼──────────┤──────────┤──────────┤
    ///     │   Signed │ -1 ... 0 │ -2 ... 1 │ -4 ... 3 │
    ///     ├──────────┼──────────┤──────────┤──────────┤
    ///     │ Unsigned │  0 ... 1 │  0 ... 3 │  0 ... 7 │
    ///     └──────────┴──────────┴──────────┴──────────┘
    ///
    /// - Note: The result is always finite.
    ///
    /// - Requires: The request must not exceed the entropy limit.
    ///
    @inlinable public static func random(through index: Shift<Magnitude>, using randomness: inout some Randomness) -> Self
}

My intuition is to extend BinaryInteger when signedness is important or the randomness is measured in bits.

Hm. I wonder if T.random(through:) should be stable w.r.t Element size. In other words, should InfiniInt<U32> and InfiniInt<U64> return the same value, given the same index and fuzzer? It's doable, but it's a bit slower.

Turns out the initial random arbitrary integer implementation was incorrect. I added some tests and noticed that the range was sometimes half of what it should be. It is easily fixed by incrementing the index regardless of signedness.


⚠ Spryr has degraded performance

In 63d6f4d, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 503
Response time: 3149 ms

Resolved: Spryr performance has improved in ca32621 after 7 minutes.


Add codegen field in graph node

Motivation Issue
During autograd, we first generate forward path by concrete execution. We then call GradientPass to generate backward graph. We then prune out the forward graph since it has already been executed and no resources should be allocated as well. However, this approach fails in https://github.com/dmlc/mxnet/blob/master/src/executor/attach_op_execs_pass.cc#L202 . This is because converting BackwardOpExecutor relies on forward node, which has already been deleted.
There are two ways to view this problem:

We should not remove the forward nodes, since some of their states should be preserved (i.e, it's the pass developer's fault).
Generating executors (codes) for one node should not rely on other nodes, since they may be deleted (i.e, it's the mxnet backend developer's fault).

I think both views are somewhat correct, and the problem is there is no clear semantics on what is a valid IR (dataflow graph) that can be accepted. If take LLVM as analogy, LLVM pass does not allow to generate IR that is invalid (based on its definition). Here in NNVM, this part is missing.
Defining Semantics of NNVM IR
The reason is because the node is basically a black box. However, we can still define some high-level semantics of the node. Therefore, I suggest to add a CodeGen field in the Node structure meaning that the node is able to convert to some codes for the backend.
A dataflow graph (NNVM IR) is valid if and only if all the nodes in the graph has defined code generator. The code generator has following interface:
class CodeGen {
 public:
  virtual void FeedInputShapes(const std::vector<TShape>& shapes) = 0;
  virtual void FeedOutputShapes(const std::vector<TShape>& shapes) = 0;
  virtual void FeedInputTypes(const std::vector<int>& types) = 0;
  virtual void Generate(const Node* node) = 0;
};

Here, it relies only on the current node to generate code (or OpExecutor in MXNet's backend). Each pass must generate valid IR. Otherwise, error is raised.
How this decouples forward & backward operators
Based on the above definition, now it is the GradientPass 's responsibility to generate valid IR so that each node has valid CodeGen. The backward node's CodeGen is created in this pass by storing the NodePtr directly to the CodeGen object. This allows succeeding passes to remove any nodes since the required states have been stored. Two op attributes are added to support this:
using FCodeGenCreator = std::function<std::shared_ptr<CodeGen>()>;

using FBackwardCodeGenCreator = std::function<std::shared_ptr<CodeGen>(
    const NodePtr& fwd_node)>;

I have implemented the mechanism in my repo here. This also greatly simplified the attach_op_exec_pass (i.e, the code gen part in MXNet backend). The demo code is here. You can see creating OpExecutor for backward node no longer depends on forward node.
Q: We already have Op pointer. Why another CodeGen field?
A: The Op* field is a static attribute of the node. For example, two conv nodes will share the Op* while they may have different code gen.
If you guys think this is a necessary change. I will keep working on this including:

Replace the NDArrayFunction with CodeGen.
Replace the FCompute with CodeGen.
So everything will become CodeGen.

@tqchen @piiswrong @ZihengJiang

Also mentioned that, @ZihengJiang and I have discussion on another solution: partial execution to solve the forward/backward operator issues. The idea is to keep the whole graph but only execute part of the nodes. However, this seems to require more changes since we need to basically change all passes to avoid allocating resources to those nodes that are not executed.

The forward operator shouldn't have been deleted. If it's deleted there is
no way to recover
Minjie Wang<EMAIL_ADDRESS>周五下午8:10写道：

Also mentioned that, @ZihengJiang https://github.com/ZihengJiang and I
have discussion on another solution: partial execution to solve the
forward/backward operator issues. The idea is to keep the whole graph but
only execute part of the nodes. However, this seems to require more changes
since we need to basically change all passes to avoid allocating resources
to those nodes that are not executed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289184660, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudLdpae9LWFzkal5dmlO1Kusy-cqLks5rpIWbgaJpZM4Mo8WL
.

We think the executor should have no semantics of a neural network (thus the so-called forward/backward concepts). By storing the NodePtr in the CodeGen object, deleting forward node is safe while not violating the IR.

Operator objects can have states. If you delete it  the states will be
permanently lost. There is no way to safely delete it.
Minjie Wang<EMAIL_ADDRESS>周五下午8:14写道：

We think the executor should have no semantics of a neural network (thus
the so-called forward/backward concepts). By storing the NodePtr in the
CodeGen object, deleting forward node is safe while not violating the IR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289184879, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudMoGM0mrQFYVGqUo2T8sV6rzuQhyks5rpIapgaJpZM4Mo8WL
.

You can read my implementation. The forward and backward shared CodeGen operator so even if the forward node is deleted, the OpExecutor can still be created.

The Operator are created from NodeAttrs. If NodeAttrs are kept, they everything can be recovered.

The operator object can have states produced by forward and used by
backward. It can not be recovered from nodeattr
Minjie Wang<EMAIL_ADDRESS>周五下午8:21写道：

The Operator are created from NodeAttrs. If NodeAttrs are kept, they
everything can be recovered.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289185140, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudF02P1dkxxPUblPrADEPcrt9rdvvks5rpIgbgaJpZM4Mo8WL
.

In my view, this should not be allowed. All members in the operator should be constants after Init. Developers should pass these intermediate data through the output and feed it to backward through inputs.

It's has always been supported. We shouldn't break backward compatibility.
Minjie Wang<EMAIL_ADDRESS>周五下午8:28写道：

In my view, this should not be allowed. All members in the operator should
be constants after Init. Developers should pass these intermediate data
through the output and feed it to backward through inputs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289185415, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudMg0XzTf6P4BTrQFg4LN4WeQzIePks5rpInDgaJpZM4Mo8WL
.

Do you have any examples?

Cudnn ops mkl ops custom op pretty much every non trivial op
Minjie Wang<EMAIL_ADDRESS>周五下午8:30写道：

Do you have any examples?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289185523, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudDHsvA2xiFA7QgmeSAxhB1Vce7Q9ks5rpIpBgaJpZM4Mo8WL
.

We've checked the cudnn operators. They are fine since you can still create the operator and only call backward. The only problem it wastes some storage for the forward handle, but it should be fine.

A lot more ops keep private states. Custom op  warpctc torchop caffeop etc
Minjie Wang<EMAIL_ADDRESS>周五下午8:33写道：

We've checked the cudnn operators. They are fine since you can still
create the operator and only call backward. The only problem it wastes some
storage for the forward handle, but it should be fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289185630, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudAODQFsyxp08302zOyEzc63P_ibOks5rpIrvgaJpZM4Mo8WL
.

Actually, if this is really a crucial use case. They should be represented as stateful nodes in the dataflow graph that can have multiple calls and are serialized. Basically, we should have a systematic way to tell the pass developer that "ok, here are some nodes are very dangerous and please do not break their relations". But simply mark them as forward/backward is not a good idea i think.

Also, I think those use cases can still be solved under the above change. When you creating the backward nodes, directly save the forward operator (that has already been executed) in the CodeGen object, so it can be reused later.

It is similar to you want to "generate backward code that based on the forward running states". This concept should be fine.

There is no need for FeedInputShapes etc since they are not sufficient for recovering forward state anyway.
CreateLayer should directly save created operator in NodeAttrs. Maybe a new dmlc::any field or reuse NodeAttrs::parsed.

This is again not clear. I think NodeAttrs are static attributes before compilation. Operator is runtime object after running. They should not be put together.

node is in theory static too. Only graph attributes are dynamic

There are a few problems with the codegen interface:

It is restricted to shape, and type, and may not be future proof on other possible context that you might want to depend on(e,g. layout)
It seems to be coupled with the execution, while the codegen itself is a blackbox.
The stateful interface means it is not thread-safe.

I would try not to introduce the concept to core graph structure, but maybe start by thinking about how states could have been stored without directly think about execution. an anyfield might be useful for such case.

Maybe a clear state sharing mechanism is preferred than the implicit graph deps.  The key issue is that the layer operator with shared state is never able to do autograd(if the state is not recovered).
So I think we should simply mark these stateful operator as they are, and gradually move most operators to stateless(for example, cudnn conv could be stateless)  and only do autograd on stateless ops.

The interface actually does not restrict the information required. Actually, in my implementation, I have a MXNetCodeGen that inhertits from this interface and add more interface: https://github.com/jermainewang/mxnet/blob/master/src/executor/exec_pass.h#L56 . The interface means it is totally fine these FeedXXX is not called. In fact, following interface is what I wrote initially:
class CodeGen {
 public:
  virtual void Generate(const Node* node) = 0;
};

I guess this is the "black-box" you want?

The stateful interface means it is not thread-safe.
What do you mean by thread-safe? During execution or during compilation?

Just chatted with eric, we agree the state sharing interface is required.

The part that confuses me is that CodeGen seems to be a mutable object, in a graph with immutable attributes.

Capturing forward nodeptr in the codegen or some object seems did not solve the problem of the state sharing, unless forward computation also uses a similar mechanism. I think it might be helpful to have a clear specification of shared states.
On the other hand, autograd can already cover most of the ops given that they do not share any states, which should be the case actually for almost all of them. For temporal objects such as resource handle, a thread local workspace or an explicit resource should be likely solve the problem

I see what you mean. Autograd allows compute gradients of symbols together with ndarrays. Unfortunately, symbols usually represent stateful ops (e.g. conv). Another thing is, the Operator interface right now does not allow creating the OpExecutor with only backward node. Therefore, even if they are stateless, the backward OpExecutor cannot be even created (or you still view them as stateful since their  code generation is also shared?).

If operator is stateless, we can simply create a OpExecutor(which is forward) that does the backward computation

@tqchen  What did you mean by " For temporal objects such as resource handle, a thread local workspace or an explicit resource should be likely solve the problem" ?

Just discussed with tianqi offline. Conclusion: we will walkaround this by modifying those legacy operator interface. We need to expose two more interfaces on the legacy Operator:

Whether they are stateless or not?
For stateless operator, how to create the backward OpExecutor given its input and output shape/type (no need for forward node's shape/type)?

For stateful operator, we just ignore them in autograd right now.
@ZihengJiang @piiswrong
If guys think this is a good walkaround right now. I will close this PR and raise another PR to MXNet repo about the change.

operators should be stateful by default. Because users self defined
operators don't have this interface defined
Minjie Wang<EMAIL_ADDRESS>周六上午10:49写道：

Just discussed with tianqi offline. Conclusion: we will walkaround this by
modifying those legacy operator interface. We need to expose two more
interfaces on the legacy Operator:

Whether they are stateless or not?
For stateless operator, how to create the backward OpExecutor given
its input and output shape/type (no need for forward node's shape/type)?

For stateful operator, we just ignore them in autograd right now.
@ZihengJiang https://github.com/ZihengJiang @piiswrong
https://github.com/piiswrong
If guys think this is a good walkaround right now. I will close this PR
and raise another PR to MXNet repo about the change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289227830, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudBzPrUgO3xrrjG1Otb8eQSztGDGFks5rpVOsgaJpZM4Mo8WL
.

Also this is cluttering the interface. Stateless ops should be implemented
with fcompute there is no need to label legacy operators stateless.
eric xie<EMAIL_ADDRESS>周六下午10:15写道：

operators should be stateful by default. Because users self defined
operators don't have this interface defined
Minjie Wang<EMAIL_ADDRESS>周六上午10:49写道：
Just discussed with tianqi offline. Conclusion: we will walkaround this by
modifying those legacy operator interface. We need to expose two more
interfaces on the legacy Operator:

Whether they are stateless or not?
For stateless operator, how to create the backward OpExecutor given
its input and output shape/type (no need for forward node's shape/type)?

For stateful operator, we just ignore them in autograd right now.
@ZihengJiang https://github.com/ZihengJiang @piiswrong
https://github.com/piiswrong
If guys think this is a good walkaround right now. I will close this PR
and raise another PR to MXNet repo about the change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/nnvm/pull/108#issuecomment-289227830, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudBzPrUgO3xrrjG1Otb8eQSztGDGFks5rpVOsgaJpZM4Mo8WL
.

Reopen for discussion. The thing is most current money op are in legacy operator interface. Yes, the interface allows states but in fact most of them are stateless. Currently, we don't have a clean way to specify state sharing. So if we treat them all stateful, autograft will just don't allow them and all the symbol part can not be supported. That's why we need to add two simple interfaces, which by default return stateful so nothing will change. And gradually mark those stateless operators. It will not influence any of the current mechansim and is backward compatible. Is this OK for you?

If operator is stateless, then we can either convert it to fcompute registration or create a new operator for backward so it does not need to refer to forward node in attach op exec pass.


Document start token (---) causes pureyaml to fail

The following correct YAML (run against other yaml parsers) causes pureyaml to file

---
:bucket_name: ZZZZ
:aws_s3_client_options:
  :region: us-east-1
  :access_key_id: XXXX
  :secret_access_key: YYYY

Exception:
Traceback (most recent call last):
  File "/Users/schwa/Projects/punic/punic/carthage_cache.py", line 21, in __init__
    d = pureyaml.load(Path('.carthage_cache.yml').open())
  File "/usr/local/lib/python2.7/site-packages/pureyaml/__init__.py", line 47, in load
    return loads(s.read(), **kwargs)
  File "/usr/local/lib/python2.7/site-packages/pureyaml/__init__.py", line 55, in loads
    return cls(**kwargs).decode(s)
  File "/usr/local/lib/python2.7/site-packages/pureyaml/decoder.py", line 13, in decode
    return self.visit(YAMLParser().parse(s))
  File "/usr/local/lib/python2.7/site-packages/pureyaml/parser.py", line 58, in parse
    return self.parser.parse(data, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/ply/yacc.py", line 331, in parse
    return self.parseopt_notrack(input, lexer, debug, tracking, tokenfunc)
  File "/usr/local/lib/python2.7/site-packages/ply/yacc.py", line 1181, in parseopt_notrack
    tok = call_errorfunc(self.errorfunc, errtoken, self)
  File "/usr/local/lib/python2.7/site-packages/ply/yacc.py", line 193, in call_errorfunc
    r = errorfunc(token)
  File "/usr/local/lib/python2.7/site-packages/pureyaml/parser.py", line 77, in p_error
    raise YAMLSyntaxError(p)
pureyaml.exceptions.YAMLSyntaxError: unexpected: LexToken(DOC_START,u'---',1,0)

'---\n:bucket_name: ZZZZ\n:aws_s3_client_options:\n  :region: us-east-1\n  :access_key_id: XXXX\n  :secret_access_key: YYYY\n\n
^^^^

I'm not a maintainer of this project, but this actually works. You may want to update to the latest version if you haven't already and verify, but for instance:
>>> test = """
... ---
... :bucket_name: ZZZZ
... :aws_s3_client_options:
...   :region: us-east-1
...   :access_key_id: XXXX
...   :secret_access_key: YYYY
... """
>>> pureyaml.loads(test)
WARNING: yacc table file version is out of date
Generating LALR tables
WARNING: 15 shift/reduce conflicts
WARNING: 1 reduce/reduce conflict
WARNING: reduce/reduce conflict in state 30 resolved using rule (scalar -> SCALAR)
WARNING: rejected rule (scalar_group -> SCALAR) in state 30
{':bucket_name': 'ZZZZ', ':aws_s3_client_options': {':region': 'us-east-1', ':access_key_id': 'XXXX', ':secret_access_key': 'YYYY'}}

It looks like somehow you may have an extra character ' in your string proceeding ---


Feedback button does not work on Safari / macOS

The feedback button does not work on Safari / macOS. Nothing happens when I click on the feedback button. It works on Chrome.
Safari Version 14.1.2 (146<IP_ADDRESS>.5)
macOS version 10.14.6 (18G9323)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e8d3d5b8-059a-613d-8666-80438ebd7aa7
Version Independent ID: 6a0f2873-97c3-833c-45e4-340ea96667a0
Content: GDEF — Glyph Definition Table (OpenType 1.8.4) - Typography
Content Source: typographydocs/opentype/spec/gdef.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

@pgundlach : I can't reproduce this issue: the feedback button works for me in Safari on macOS v11.6.

Likely related to #824 - the current macOS 11 works fine here as well.


fix: Do not recover background streaming jobs whose table fragments have been marked as created

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix assertion failure in background ddl test that was found in main-cron job: https://buildkite.com/risingwavelabs/main-cron/builds/1436#018cd00e-4ea4-4b6d-949e-d73a5a4fd08d:

thread '' panicked at src/meta/src/manager/catalog/fragment.rs:588:9:
assertion left == right failed
left: Created
right: Creating

The root cause is that the meta got killed after the streaming job was marked as CREATED but didn't have time to mark the status of catalog. In this case, we don't have to recover its tracking status but to finish the catalog directly.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

The background recovery test pasted.


Support for Guards on Selectors

I am trying to compile the KendoUI v2014.3.1209 LESS files, but I am getting errors because the current version of dotLESS does not support Guards on Selectors. A compile error is thrown when the compiler encounters & when (@icon-positioning = "material") {  in the following example:
   .sprite-hoverable(@row, @column, @size: @grid-size) when not (ispixel(@column)) {
    .sprite-position(@row, @column, @size);

    .k-link:not(.k-state-disabled):hover > &,
    .k-state-hover > &,
    .k-state-hover > * > &,
    .k-button:not(.k-state-disabled):hover &,
    .k-textbox:hover &,
    .k-button:active & {
        .sprite-position(@row + 1, @column, @size);

        & when (@icon-positioning = "material") {
            .sprite-position(@row, @column);
        }
    }
}

Merged in support in the form of PR #393.


Usage of fetch in shopifyApiProxy

Hey there,
I've been browsing through the code of this repo as we are looking to build something similar for our APIs at my current job. While browsing, I stumbled over [this|https://github.com/Shopify/shopify-express/blob/master/routes/shopifyApiProxy.js#L58].
function fetchWithParams(url, fetchOpts, query) {
  const parsedUrl = new URL(url);

  Object.entries(query).forEach(([key, value]) => {
    parsedUrl.searchParams.append(key, value);
  });

  return fetch(parsedUrl.href, fetchOpts);
}

I can't find fetch being imported anywhere and it being a browser API, I would have thought this cannot work in node. Couldn't call fetch in the node REPL either. I'm just curious here, if you've found a way to do straight forward (i.e. no use of http) HTTP requests in node without third-party libraries.
Thanks for the great inspiration.

Thanks for opening this issue, the project was hastily pulled out of a folder in shopify-node-app so we've been dealing with the fallout of that bit by bit as we slowly move towards being out of alpha. Looks like we just didn't move over the fetch polyfill. If you want to use this code verbatim in your own project just yarn add universal-fetch and require('universal-fetch') anywhere in your code.

OK cool, that's what I thought. Thanks.


[Documentation] Clean up and update README, templates & other GitHub markdown docs in the repo

Need to review the following docs, check for content, update as needed keeping in mind the target audience and increased eyeballs on the project:

[ ] README / #307

[ ] Need section (or wiki page) about how to go about updating Substrate

[ ] PR template

[ ] Add item to checklist to increment spec version if needed (i.e. after run time upgrades?)

[ ] Issue template(s)
[ ] Contributing guide
[ ] Code of Conduct
[ ] License
[ ] Anything I forgot
[ ] If we're lacking a document or it belongs elsewhere or something, please file a new issue for it

The Prerequisites section should have headings for Software as well as Hardware.  Under Software, there should be subsections for macOS, Linux, Windows.  For macOS, Homebrew should be listed along with the commands to install jq, etc...

Archive


Is there somewhere a list of available rules?

Hi
Is there somwewhere a list of available rules? From reading a readme I don't see what exactly this tool can help me with.
Thanks

yes!
Also backlink in the subtree split to the main repo, as now its not clear for the users which repo is the main entry point to the ecosystem.
Also linking Rector in the title is a little bit confusing on https://github.com/andreaswolf/fractor/tree/main/packages/typo3-fractor#typo3-fractor--an-enhancement-for-typo3-rector

thank you!


invokeProcessAction does not work in UCI

Error message: "This action is not supported"
Runs fine in legacy web interface, but as soon as I switch to UCI, it stops working.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a261db5-f03e-8100-f9b9-592ba9a34cea
Version Independent ID: 281480d2-01b3-1488-9f00-9e82fd6d93ef
Content: invokeProcessAction (Client API reference) in model-driven apps - PowerApps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/Xrm-Utility/invokeProcessAction.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@bananamufu Thanks for contacting us. We have created a internal work item for the respective dev team. Will update the docs if any when the issue is resolved. Closing the issue.  If you need further help, please reopen the issue or open a new issue.


Which coordinate system is the generated gt in?

Which coordinate system is the generated gt in? I assume it is in the corresponding lidar coordinate system and find that it does not correspond to the point cloud

lidar coordinate

In the issue, it seems like occupancy gt lie in lidar coordinate system.
I am a new comer for OpenOccupancy. I am not sure what causes the outcome between occupancy gt and the point cloud, can you provide a more detailed description for it?


Cylindrical and spherical versions of derived quantities

Following what was done in #689 we need an implementation of the cylindrical and spherical versions of

[ ] TotalVolume
[ ] TotalSurface
[ ] AverageVolume
[ ] AverageSurface

2D axisymmetric
In 2D axisymmetric, the surface element ds is
ds = r dr dtheta or ds = r dz dtheta
In both cases, in fenics integrating a function f is assemble(f * r * ds) where r is the radius.
dV = r dr dtheta dz
Integrating a function f in fenics is therefore assemble(f * r * dx) where r is the radius.
1D spherical
The surface element in 1D spherical is:
dS_r = r^2 sin(theta) dtheta dphi
The integral of f on a spherical surface is therefore
integral(f dS_r) = integral(f r^2 sin(theta) dtheta dphi)
= (phi2 - phi1) * (-cos(theta2) + cos(theta1)) * f r^2
The volume element is
dV = r^2 sin(theta) dr dtheta dphi
the integral of f on a spherical volume is therefore
integral(f dV) = (phi2 - phi1) * (-cos(theta2) + cos(theta1)) * integral(f r^2 dr)
phi is the polar angle and theta is the azimuthal angle

@gabriele-ferrero If you wanna do the TotalVolume and TotalSurface ones I can do the Average ones

@jhdark @gabriele-ferrero I "assigned" you to this issue. Let me know if you need help and if you want to have this in 1.3

@rekomodo is having a go at implementing the remaining classes


Add 1D option to ignore 2D functionality

What we discussed in Slack. Please check if it is necessary to add 1d checks in other parts of the code that I might have missed.

@gregordecristoforo I just made an additional commit now to multiply the array of ones by the free parameter in the blob factories. It is something I need to have a degenerate distribution with value other than 1 (as I can see, there is no other way to do that now)

Seems fine to me, we should also change the test https://github.com/uit-cosmo/2d-propagating-blobs/blob/main/tests/test_analytical.py which isn't adapted to the 1D option yet. I can take a look at that tomorrow.

hmm, why should it be changed? I thought it was a 2d test? I added a new analytical test, which is just this one adapted to 1d.

This test was originally intended as a 1D case. Sorry I missed you already implemented the new test in 1D. Don't mind my previous comment.


Add SearchResultsPage schema

This adds a naive implementation of https://schema.org/SearchResultsPage which
permits us to add basic schema information to finder pages.  Using this approach
also adds other page metadata (contained in the machine_readable_metadata partial).
We're paying more attention to how these are indexed for search because finders
have different requirements for search visibility.  Specialist finders need
to be findable via Google because these search pages are a critical for a subset
of users.
More general search pages have a more nuanced need.  We generally want people
to avoid navigating from Google search to an internal search page unless it
is for a specific reason.
We have already excluded search results page with keywords from being indexed,
and we similarly exclude everything past the first page.  We'll probably iterate
this approach.
https://trello.com/c/OVkRpKDk/735-add-metadata-for-finders
https://trello.com/c/4EAytHVV/747-plan-noindexing-of-finder-pages

That's a really good point, thanks @barrucadu . I'll write something up for that.


1.0.9 - version code in .apk needs updating

Please see here:
https://github.com/ImranR98/Obtainium/issues/1091#issuecomment-1815800125

@DiagonalArg Hi :smile:
I see, yeah I didn't update the version, because it was just a quick desktop version fix and thought it wouldn't be necessary to update the android version which would be triggered by the version update, but i see now that this causes more confusion.
I updated the app now and I'll keep the version up to date from now on :+1:

Much appreciated.  And thank you for all your work.


Some time image is storing on the android gallery and some times the image file size is zero

I can not able see the image which is taken in the android device but some times its stored in the gallery
Bug Information
Version Number of Plugin: 3.0.1
Device Tested On: Motorola Android 6.0
Simulator Tested On:
Version of VS:
Version of Xamarin: 6.3
Versions of other things you are using:
Steps to reproduce the Behavior
Expected Behavior
All the images taken from the app needs to be store in the gallery
Actual Behavior
Some times it stored into the gallery and sometimes image is created but its got damages i can not able to open it again
Code snippet
var file = await CrossMedia.Current.TakePhotoAsync
(new Plugin.Media.Abstractions.StoreCameraMediaOptions
		 {
			 SaveToAlbum = true
		 });
		 if (file == null)
			 return;
		 string path = string.Format("{0} then {1}", file.AlbumPath, file.Path);
				await DisplayAlert("File Location", path, "OK");

Screenshotst

@Padalingam I am not able to reproduce this on my Galaxy S7. How often does this happen?
Is this specific to any one device? Do you see this happening on simulator?

Because we have not received a reply to our request for more information, I am marking this issue as closed. If you are still encountering this issue on the latest version of the plugin, please don’t hesitate to reopen the ticket with the requested information. Thanks!


Consider using amplify_derive library

This will help to have more ideomatic derive macros for Error conversions (instead of raw macros)
https://crates.io/crates/amplify_derive

I'm not a big fan of adding extra dependencies just to save a few lines of code to implement the From trait here and there. Unless there's something particularly broken I'd just keep our custom macros instead.

I'm not a big fan of adding extra dependencies just to save a few lines of code to implement the From trait here and there. Unless there's something particularly broken I'd just keep our custom macros instead.

Ok, agree. While it also gives you ability to simply implement Display for errors with doc comments and many other things, seems like all cases are already covered by the written code, taking into account #36

Ok, agree. While it also gives you ability to simply implement Display for errors with doc comments and many other things, seems like all cases are already covered by the written code, taking into account #36


upgrade keyring to latest version

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

[ ] : This PR has a corresponding issue open in the Repository.
[ ] : Approach is signed off on the issue.

close open to re-trigger pipelines


SenseBox: Sound sensor returns wrong value

Describe the bug
Sound sensor returns simple analog read instead of the sound loudness.
To Reproduce
Create a program as in the screenshot and open the source code view
Expected behavior
Sensor returns the maximum absolute value from one wave period converted to % (0-100)
Screenshots

If applicable, add screenshots to help explain your problem.

Additional context
see implementation for the sound sensor for Calliope

The provided solution is not sufficient:

In general we have decided not to add any more code to NEPODefs.h, desired place for new functions is inline, see #278
The calculation of max in the function reduces the range from the output, 0 (no noise) can never be reached.
-> We want to calculate the peak amplitude and convert it in percent: please improve the function, remove it from NEPODefs.h and create it like in #278 proposed

Moving to helper methods is currently impossible since helper methods for C based robots are not yet implemented

Seems to work fine, constant noise, as well as short loud claps are detected.


onChange event triggers twice during AM/PM switch

https://jsfiddle.net/j2bt1m4a/
Your Environment

flatpickr version used: 4.6.9
Browser name and version: Safari or Google Chrome, recent versions
OS and version: OSX 11.4

Bug happens because we are triggering 'onChange' event twice.

In updateTime method like this:

if (self._input.value !== prevValue) {
  self._debouncedChange();
}

In bindEvents method like this:

if (self.amPM !== undefined) {
  bind(self.amPM, "click", (e) => {
    updateTime(e);
    triggerChange();
  });
}

Probably this PR (#2506) will help.


models.py:232: Create an index for order_by_alphanumeric...

The puzzle 273-b2ae754f from #273 has to be resolved:
https://github.com/fidals/refarm-site/blob/1ca2bc841b8715ecdf2ee765b83722086ab79b81/catalog/models.py#L232-L232
The puzzle was created by Artemiy on 21-Feb-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Django doesn't provide suitable ability to create indexes. So i have to do it myself. I don't want to split this issue on sub-tasks, so i will increase the estimate

@0pdd the puzzle #292 is still not solved.

@0pdd the puzzle #292 is still not solved; solved: #129.


fix(Modal): add aria-live polite

Overview

adding aria-live polite on Modal Container to announce content change inside modal

PR Checklist

[ ] Related to designs: https://www.figma.com/file/DeETaHGvA6uAXDZwGyjCFH/Upgrade-Downgrade-Pause?node-id=125%3A5123
[ ] Related to JIRA ticket: Egg-2626
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

PR Links and Envs
Updated! (will update with link when alpha package is published)

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

🚀 Styleguide deploy preview ready!https://62aa55bde3e65a11c72575de--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.143-alpha.f17cc7.0@codecademy/gamut-labs@32.0.6-alpha.f17cc7.0@codecademy/gamut@48.0.2-alpha.f17cc7.0@codecademy/monaco@0.6.51-alpha.f17cc7.0<EMAIL_ADDRESS>
Sorry for the delay, here is the monolith PR!
One note here, this change is to improve the a11y on our first multi-screen modal (which i don't believe there has been one before). One thing that I wasn't able to update was to bring focus back up to the Close Icon button when the content changes within the modal. I tried a few custom focus tricks but didn't seem to do the job. I think that if we continue to use multi-screen modals, we may need to revisit having the bottom buttons ("confirm" and "cancel") be part of the modal and not sent over as children. @dreamwasp


Provide API for generating Swagger.json without HTTP call

In our CI Server we want to generate always the current SDKs. For this we need to generate the Swagger specifications via command line after we compiled our Web API service (OWIN Windows Service). So basically:

Compile the Web API project
Invoke the compiled Exe with some CLI parameters that trigger the generation
Feed the output JSON into Swagger Codegen to update the SDK Sources
Compile the SDK

For this it would be nice if Swashbuckle could provide some straight forward way to generate the Swagger JSON without the need to actually start the OWIN host. Currently everything seems to be wrapped into the SwaggerDocsHandler which holds the configuration.

This capability makes a ton of sense but is difficult because of the dependency on a fully loaded instance of ApiExplorer, which can't be easily instantiated outside of the full WebAPI stack.
I think some form of in memory server makes the most sense. In the Core-specific project, Swashbuckle.AspNetCore, I plan to implement this behind a simple CLI for generating the Swagger JSON. But, I hadn't planned on doing the same for this project.
However, you could easily implement this yourself with an OWIN TestServer. Here's a simple snippet that I threw together and appears to work well:
using System.Web.Http;
using Microsoft.Owin.Testing;
using Owin;

namespace TestCli
{
    class Program
    {
        static void Main(string[] args)
        {
            var testServer = TestServer.Create(app =>
                {
                    var httpConfiguration = new HttpConfiguration();
                    YourApp.WebApiConfig.Register(httpConfiguration);
                    YourApp.SwaggerConfig.Register(httpConfiguration);

                    app.UseWebApi(httpConfiguration);
                });

            var swaggerResponse = testServer.HttpClient.GetAsync("swagger/docs/v1").Result;
            var swaggerJson = swaggerResponse.Content.ReadAsStringAsync().Result;
        }
    }
}


wip - test

testing...

Codecov Report

Merging #7 (61c2c6c) into main (7ea6811) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   87.64%   87.66%   +0.02%
==========================================
  Files         191      191
  Lines        9261     9261
==========================================
+ Hits         8117     8119       +2
+ Misses        887      885       -2
  Partials      257      257

Impacted Files
Coverage Δ

pkg/activator/net/revision_backends.go
92.41% <0.00%> (+0.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f00179...61c2c6c. Read the comment docs.


after you open a notebook, should be able to scroll it

with the page down or arrow down.

This works for me, what are you seeing?

i have to click on the page to be able to scroll.

wait it's gone.  huh.  oh well.

:grapes:

OK i finally get this one.  you don't have to click.  but the first time you hit page-down (or space bar), then it's ignored.  2nd time you hit the key, then it scrolls.


Appstudio update hacbs-test-project-fgnh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-fgnh-on-pull-request-
creating pipelinerun hacbs-test-project-fgnh-on-pull-request- in namespace rhtap-demo-prjc-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-fgnh-on-pull-request-
creating pipelinerun hacbs-test-project-fgnh-on-pull-request- in namespace rhtap-demo-gnmn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-fgnh-on-pull-request-
creating pipelinerun hacbs-test-project-fgnh-on-pull-request- in namespace rhtap-demo-ftgg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-fgnh-on-pull-request-
creating pipelinerun hacbs-test-project-fgnh-on-pull-request- in namespace rhtap-demo-jjob-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


"Could not load your book" -error

Category
bug
What is the current behavior?
recently my book shows: "Could not load your book. Check your book.json for errors" in the bottom left corner.
the content of book.json hasn't changed before the error occurred and is still:
{
"structure": {
"readme": "README.adoc"
}
}
most things seem to work though. the only thing i notice is that in the editor some pages don't show their preview on the right side but just a blank page...not sure if related though?!
EDIT: even setting its content to { } doesn't get rid of the error.
Additional information

win10
chrome55

This looks like a duplicate of https://github.com/GitbookIO/feedback/issues/411
This should be fixed in the Editor v7.0.10. The Web Editor will be updated during the day.


Adding Favicon Icon

A Favicon icon can be added in the website.

please assign me under gssoc'24 extd and hacktoberfest.
@aslams2020

please assign me with the task @aslams2020


Synchronization specification proposal for multihost tests

Closes #1705

Default value none seems to me too kernel specific and not intuitive in general. For us the each would considered more as a default. I suggest to not have a default value and have the test key mandatory.
Originally posted by @ZelenyMartin in https://github.com/teemtee/tmt/pull/1606#discussion_r1030596637

Default value none seems to me too kernel specific and not intuitive in general. For us the each would considered more as a default. I suggest to not have a default value and have the test key mandatory.
Originally posted by @ZelenyMartin in #1606 (comment)

It depends on a POV. I would vote for something like first or start which would sync a start of a "recipe", the rest would be on the tests as we do in beaker.
Originally posted by @sopos in https://github.com/teemtee/tmt/pull/1606#discussion_r1030635504

In general, wouldn't it be better to use singular name, index?

Yes, It would be better. The current keyword proposal is here: https://github.com/teemtee/tmt/issues/1705#issuecomment-1326348409. I will update the specification when we agree on it.

Per discussion on our meetings, we will close this issue for now.
For test level synchronization, see:
https://tmt.readthedocs.io/en/stable/guide.html#synchronization-libraries,
Currently, there are no plans to tackle this problem on the tmt level.


Make URL regex more generic

This fixes the following limitations in the URL regex

No support for IPv6 and IPv6 hybrid address
No support for single hostnames like 'localhost'
No support for single character network names like in 'a.b'
No support for IPv4 addresses where the last octet was lower than 10
(e.g. <IP_ADDRESS>)
Also removed the (erroneously unquoted) trailing dot for hostnames. It's
handled by the more forgiving regex now.

Thanks @jkreileder! I'll merge it late today and release a new version. Thanks again!

sorry for the delay


No channels on Discord, even after 10 minutes waiting

I joined the Discord server to ask about a problem (can't download any file format of this) but even after 10 minutes there are only the information channels. Is that normal? How to get the other channels?

Did you get a DM from a captcha bot?

No I didn't. But right now (after about 35h) I can see all other channels. Maybe someone did it manually. Thanks!


Feature to include headers in http/https service requests (non-MMS)

What this PR does / why we need it:  Currently there is no header support for inference service uri request. It would be beneficial as authentication for requests may require credentials to be passed into the header.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1351
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/assign @yuzisun

/LGTM

/LGTM

/retest

/test kubeflow-kfserving-presubmit

/test kubeflow-kfserving-presubmit

/LGTM

/approve