Test_window_resize failed with "Expected 0 but got 2"

Describe the bug
The Test_window_resize fails with following message:
Failures:
        From test_window_cmd.vim:
        Found errors in Test_window_resize():
        command line..script BUILDDIR/vim/src/vim/src/testdir/runtest.vim[468]..function RunTheTest[39]..Test_window_resize line 49: Expected 0 but got 2

To Reproduce
0.

Expected behavior
I shouldn't get any error on make test.
Environment (please complete the following information):

Vim version:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jan 01 2021 04:18:18)
Included patches: 1-2257
Compiled by Arch Linux
Huge version without GUI.

Build process is run in a container to which I connected by ssh.
I didn't see that error with 2135 patchlevel.

I think is this line in test_window_cmd.vim
call assert_equal(0, winwidth(other_winnr))

that causes the error. This block
  close

  vsplit
  wincmd l
  let other_winnr = winnr('h')
  call assert_notequal(winnr(), other_winnr)
  exe 'vert ' .. other_winnr .. 'resize -100'
  call assert_equal(0, winwidth(other_winnr))

was introduced in 2244 patchlevel, commit 89015a675990bd7d70e041c5d890edb803b5c6b7.

I think is this line in test_window_cmd.vim
call assert_equal(0, winwidth(other_winnr))

that causes the error. This block
  close

  vsplit
  wincmd l
  let other_winnr = winnr('h')
  call assert_notequal(winnr(), other_winnr)
  exe 'vert ' .. other_winnr .. 'resize -100'
  call assert_equal(0, winwidth(other_winnr))

was introduced in 2244 patchlevel, commit 89015a675990bd7d70e041c5d890edb803b5c6b7.

I seems figured out what is going on. I have
echo $COLUMNS
205

for that particular terminal window in which I ssh'ed to a container. If I change resize -100 part to resize -300 then test would pass.

I seems figured out what is going on. I have
echo $COLUMNS
205

for that particular terminal window in which I ssh'ed to a container. If I change resize -100 part to resize -300 then test would pass.

I guess we should use &columns / 2 instead of the magic number 100.  Or just &columns to be sure.
diff --git a/src/testdir/test_window_cmd.vim b/src/testdir/test_window_cmd.vim
index b0c5a417e..8a9748849 100644
--- a/src/testdir/test_window_cmd.vim
+++ b/src/testdir/test_window_cmd.vim
@@ -1154,7 +1154,7 @@ func Test_window_resize()
   wincmd l
   let other_winnr = winnr('h')
   call assert_notequal(winnr(), other_winnr)
-  exe 'vert ' .. other_winnr .. 'resize -100'
+  exe 'vert ' .. other_winnr .. 'resize -' .. &columns
   call assert_equal(0, winwidth(other_winnr))

   %bwipe!

I guess we should use &columns / 2 instead of the magic number 100.  Or just &columns to be sure.
diff --git a/src/testdir/test_window_cmd.vim b/src/testdir/test_window_cmd.vim
index b0c5a417e..8a9748849 100644
--- a/src/testdir/test_window_cmd.vim
+++ b/src/testdir/test_window_cmd.vim
@@ -1154,7 +1154,7 @@ func Test_window_resize()
   wincmd l
   let other_winnr = winnr('h')
   call assert_notequal(winnr(), other_winnr)
-  exe 'vert ' .. other_winnr .. 'resize -100'
+  exe 'vert ' .. other_winnr .. 'resize -' .. &columns
   call assert_equal(0, winwidth(other_winnr))

   %bwipe!


get_book_crossing crashes

I believe all relevant packages are up to date running on python 3.6.5

TypeError                                 Traceback (most recent call last)
 in ()
29 train_interactions, test_interactions, user_features, item_features, _ = get_book_crossing(user_indicators=False,
30                                                                                item_indicators=True,
---> 31                                                                                cold_start_users=True)
32
33 # Establish baseline metrics with random ranks for warm and cold start users
 in get_book_crossing(min_positive_score, min_interactions_per_book, user_indicators, item_indicators, cold_start_users, cold_start_items)
/usr/local/lib/python3.6/site-packages/sklearn/pipeline.py in fit_transform(self, X, y, **fit_params)
737             delayed(_fit_transform_one)(trans, weight, X, y,
738                                         **fit_params)
--> 739             for name, trans, weight in self._iter())
740
741         if not result:
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/parallel.py in call(self, iterable)
777             # was dispatched. In particular this covers the edge
778             # case of Parallel used with an exhausted iterator.
--> 779             while self.dispatch_one_batch(iterator):
780                 self._iterating = True
781             else:
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/parallel.py in dispatch_one_batch(self, iterator)
623                 return False
624             else:
--> 625                 self._dispatch(tasks)
626                 return True
627
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/parallel.py in _dispatch(self, batch)
586         dispatch_timestamp = time.time()
587         cb = BatchCompletionCallBack(dispatch_timestamp, len(batch), self)
--> 588         job = self._backend.apply_async(batch, callback=cb)
589         self._jobs.append(job)
590
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/_parallel_backends.py in apply_async(self, func, callback)
109     def apply_async(self, func, callback=None):
110         """Schedule a func to be run"""
--> 111         result = ImmediateResult(func)
112         if callback:
113             callback(result)
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/_parallel_backends.py in init(self, batch)
330         # Don't delay the application, to avoid keeping the input
331         # arguments in memory
--> 332         self.results = batch()
333
334     def get(self):
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/parallel.py in call(self)
129
130     def call(self):
--> 131         return [func(*args, **kwargs) for func, args, kwargs in self.items]
132
133     def len(self):
/usr/local/lib/python3.6/site-packages/sklearn/externals/joblib/parallel.py in (.0)
129
130     def call(self):
--> 131         return [func(*args, **kwargs) for func, args, kwargs in self.items]
132
133     def len(self):
/usr/local/lib/python3.6/site-packages/sklearn/pipeline.py in _fit_transform_one(transformer, weight, X, y, **fit_params)
579                        **fit_params):
580     if hasattr(transformer, 'fit_transform'):
--> 581         res = transformer.fit_transform(X, y, **fit_params)
582     else:
583         res = transformer.fit(X, y, **fit_params).transform(X)
/usr/local/lib/python3.6/site-packages/sklearn/pipeline.py in fit_transform(self, X, y, **fit_params)
281         Xt, fit_params = self._fit(X, y, **fit_params)
282         if hasattr(last_step, 'fit_transform'):
--> 283             return last_step.fit_transform(Xt, y, **fit_params)
284         elif last_step is None:
285             return Xt
TypeError: fit_transform() takes 2 positional arguments but 3 were given

Hey @borisrev ! Thanks for reporting. Can you confirm for me which version of scikit-learn you are currently running? I'll try to reproduce on my end.

0.19.1
Thanks for all the great work on tensorrec and your attention on this!

Also thanks for the kind words :)

Hey @borisrev -- I've updated the scikit dependency and hacked around the LabelBinarizer changes in 0.19.1: https://github.com/jfkirk/tensorrec/commit/b6caaca984068a352142d7c14f7c84c22f503a94
This will go out with the next release.
Closing for now -- let me know if you run in to anything else!


Feature Request for adding OpticalDistortion in Post Phase.

Optical distortion is kind of a lens error that can occur when an image is taken from camera. By adding this augmentation this library can also support camera captured images effects.
Below is a sample image with optical distortion added to it

Usually we need lens intrinsic parameters to solve the those error accurately. So at this point , do you have any library in mind that help be helpful in this case?

@shaheryar1  I don't want to diminish any suggestions or ideas, but I think we should distinguish the goals of this project from other image augmentation libraries.  For Augraphy, the intent is to focus on creating synthetic documents that appear to be scanned or faxed (or captured from a camera) for various AI/ML tasks that depend on realistic datasets.
I know you mentioned this is an issue introduced from lens error, so I assume it could potentially translate to scanning a document from a camera phone.  If so, can you provide an example that applies to a document type source that we are trying to reproduce?

@shaheryar1 I think we can close out this issue since we can address this more broadly with the separate issue (#25) being created for supporting Albumentations and Imgaug transformations.

Yeah sure.


Open StreetMap Humanitarian base layer not loading

This base layer was probably not well called or something. When radio is checked, it a black basemap is rendered

Must fix the bug


Add terminator to list of terminal emualtors

I use terminator under X11/Mate for years, and I just tried it under wayland, and it works, no extra options required.
https://terminator-gtk3.readthedocs.io/en/latest/
https://github.com/gnome-terminator/terminator
I used version 2.1.0 from Debian testing running under weston, but probably it works is a bit earlier versions.

@mpsq this one can be closed

Thanks!


Support many-to-many relations better

This is a meta issue to discuss the pattern and use cases for many-to-many relations.
Idea
Approach A. Store array of references in each record
Approach B. Create an intermediate record
Needs
Approach A

Able to query for objects in the array, and return only subset of results.
Able to add / remove objects in the array without fetching the whole array (when it is huge)

Approach A
I have create a Class extends Array, and use it as the following now:
newBook.notes = new Skygear.ReferenceArray(noteObject, 'note/6430a3a6-0882-40dd-8d3a-650c9fa48ed1');
OR
newBook.notes = new Skygear.ReferenceArray([noteObject, 'note/6430a3a6-0882-40dd-8d3a-650c9fa48ed1']);
And it will finally save it as ['note/id1', 'note/id2'] in DB.
Therefore, I can use query.containsValue('notes',noteObject); OR query.containsValue('notes','note/id1'); to filter it.
PS: it need to modify / overwrite in containsValue for supporting pass object as 2nd arg.

##Approach B
I think we can take a reference from Parse.Relation.
It also save an intermediate class dynamically.
Take a look with the following 3 classes in Parse and MongoDB.
_User, _Role, _Join:users:_Role

Referencing similar suggestions at SkygearIO/skygear-SDK-Android#103

Thanks for comments @samuelplaymore ; Feel free to help proposing something (even sending PR 😆 ) or we might discuss these in next product meeting and see if you're interested to participate in.

Moved meta issue to SkygearIO/features#8


Need to fill in categories on beta.uipa.org

As a person making an FOI request, I want to be able to search for contacts/departments by categories relevant to Hawaii.
Please use this document started by Brian:
https://docs.google.com/spreadsheets/d/1Lzx-koaf1M05BUhg0rxB4xo483ImeRjkT_qnaLh6r7M/edit#gid=323480693
Please add them to the following url:
http://beta.uipa.org/uipa-admin/publicbody/publicbodytag/
As a note, there are some already there - we probably need to double check them.

Will make a new task encompassing both beta/prod.


Added instructions for using CLI2.0

Added instructions for  using CLI 2.0 to enable AllowNetworkWatcher

@gartdan,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@gartdan, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@gartdan : Thanks for your contribution to the Azure documentation! The author, @georgewallace, has been notified to review your proposed change.

@gartdan Network Watcher no longer requires registration so steps aren't needed that you for our contribution. #please-close


[SPARK-19084][SQL] Implement expression field

What changes were proposed in this pull request?
This is an implementation of Hive's field.
field(expr, expr1, expr2, ... ) is a variable-length(>=2) function that returns the index of expr in (expr1, expr2, ...) list or 0 if not found.

It takes at least 2 parameters, and all parameters should be subtype of AtomicType or NullType.
It's also acceptable to give parameters of different types. When the parameters have different types, comparing will be done based on type firstly. For example, ''999'' 's type is StringType, while 999's type is IntegerType, so that no further comparison need to be done since they have different types.
If the search expression is NULL, the return value is 0 because NULL fails equality comparison with any value.
To also point out, no implicit cast will be done in this expression.

How was this patch tested?
Unit tests are in ConditionalExpressionSuite & ColumnExpressionSuite.

cc @chenghao-intel @adrian-wang

@gczsjdy can you please add [WIP] in the title, until you feel the code is ready for review.

Since the different data type will be simply ignored, I think we'd better also add the optimization rule in Optimizer.
As well as the python/scala API support, but need to confirm with @rxin, why we don't need the API field.

@chenghao-intel
I think that the optimize rule will fold the parameters that have different types with param0, and then disorganize the parameters' index. Thanks.
@rxin
I have removed the [WIP] mark, this PR is ready now, could you please help me review it? Thanks.

Thanks @viirya for the review and sorry for the late reply.

ping @rxin @gatorsmile @tejasapatil @viirya

ok to test

Test build #71996 has started for PR 16476 at commit 465f7a6.

Test build #71996 has finished for PR 16476 at commit 465f7a6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71996/
Test FAILed.

Test build #72427 has started for PR 16476 at commit f2d16ec.

Test build #72427 has finished for PR 16476 at commit f2d16ec.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72427/
Test FAILed.

Test build #72431 has started for PR 16476 at commit b5deea1.

Test build #72431 has finished for PR 16476 at commit b5deea1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72431/
Test FAILed.

Merged build finished. Test FAILed.

Test build #72489 has started for PR 16476 at commit a8d22e3.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72489/
Test FAILed.

Test build #72505 has started for PR 16476 at commit 66e779e.

Test build #72505 has finished for PR 16476 at commit 66e779e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72505/
Test FAILed.

Test build #72553 has started for PR 16476 at commit d22dbb3.

Test build #72553 has finished for PR 16476 at commit d22dbb3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72553/
Test FAILed.

Merged build finished. Test FAILed.

Test build #72554 has started for PR 16476 at commit c23deb5.

Test build #72554 has finished for PR 16476 at commit c23deb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72554/
Test PASSed.

@gatorsmile  Hi, this patch has passed all tests, is there some code I still need to modify? Thank you for working on this.

Test build #72994 has started for PR 16476 at commit 0665a1d.

Test build #72994 has finished for PR 16476 at commit 0665a1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72994/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan Could you please help me review this PR?

@tejasapatil Sorry to bother, is there still something need to modify?

@gczsjdy : I had one comment in past about genIfElseStructure but after giving more thought, I was not able to think about a better way to do that. I am fine withthe current version of code you have.

@tejasapatil Got it, thanks for your review. :+1:

@gatorsmile Do you think we can merge this PR? Or is there something that need to modify?

It seems MySQL do need all arguments in FIELD have same type(or can be converted to same type): http://www.w3resource.com/mysql/string-functions/mysql-field-function.php
I think this is more reasonable, we don't have to follow hive strictly, can you check more database and see what's the most common way to evalaute FIELD?

@cloud-fan I have checked some other popular RDBMS, such as Oracle, Microsoft SQL Server, PostgreSQL, DB2, SQLite, neither of them support function FIELD.
In my opinion, Hive has an important place in SQL on Big Data area, and many Spark SQL users originally use Hive, so maybe it's more reasonable to follow Hive since other databases currently not support this function.

Test build #74009 has started for PR 16476 at commit dd598a4.

Test build #74009 has finished for PR 16476 at commit dd598a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74009/
Test PASSed.

@gczsjdy I am not sure where you find the definition of Hive's field function. But in this link: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-StringFunctions
Looks like it behaves very similar to MySQL. It doesn't claim that the arguments of different types won't be compared.

@viirya I have tested with Hive 2.1.1, select field(2, '2', 2); will return 2 while it will return 1 in MySQL, I also read Hive's code, where I found it will first compare the data type which is Category in Hive.

I don't think we should follow Hive for everything even for mistakes. I think we should not care about which one is more popular, but which one is more reasonable.

Test build #74639 has started for PR 16476 at commit 4e60b7c.

Test build #74639 has finished for PR 16476 at commit 4e60b7c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait ImplicitCastInputTypesToSameType extends ExpectsInputTypes
case class Field(children: Seq[Expression]) extends Expression

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74639/
Test FAILed.

Test build #74655 has started for PR 16476 at commit fc47e0f.

@cloud-fan I have submitted a new version to support implicit cast.
We determine the implicit cast type in analysis stage, so maybe we won't do eval then, so we can't be 100% intelligent, for example to cast parameters of ("2", 2, "a", "2") to  (2, 2, somewhat, 2).
I made a trade off here to follow the type of the first parameter(the target) in general.
The specific type rules here:

If all the parameters are of the same type, we don't do implicit cast.
If the first parameter is of NumericType, we implicit cast all other parameters to NumericType (only in this way, "2.0" and "2.00" can be treated equal)and do the comparison, those that can't be cast to NumericType will be set to null of DoubleType.
else, we implicit cast all other parameters to StringType, this can always be successful.

Test build #74655 has finished for PR 16476 at commit fc47e0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74655/
Test PASSed.

Test build #75038 has started for PR 16476 at commit 9b4155a.

Test build #75038 has finished for PR 16476 at commit 9b4155a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75038/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan Do you have comment on this version?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@maropu Sure, I will update it this week.

gentle ping @gczsjdy

@HyukjinKwon Done, thanks : )
Ping @maropu

ok to test

Test build #93100 has finished for PR 16476 at commit 4b63e94.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93100/
Test FAILed.

Test build #93594 has started for PR 16476 at commit c75d786.

Test build #93594 has finished for PR 16476 at commit c75d786.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93594/
Test FAILed.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


[Fixes #18679] Ensure that usage of metrics on a template job reports an error

Note that the usage of DataflowMetrics with a template job was throwing an NPE due to the direct access of the jobId parameter.
I also ensured that getting transform step names was accessed via a method instead of reaching into the object directly.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @oleg-semenov @pranavbhandari24
CC: @an2x
This came from a user getting stuck since they were launching a flex template that was creating a classic template which tried to access metrics for a non-existent job and it manifested as an NPE.

LGTM Thanks!


Explain how to compile project that use this repo

As a developer of a project that uses this repo I would like to know how to compile and tests my projects.
I believe compiling is achieved by running make packages and the binary will be at bin/<name-of-project>.
I believe testing should be done by the project own makefile.

All rules in this Makefile are for the CI, not for local compilation/tests. Each project should implement its local testing and compilation rules in its own makefile.
On Mon, 3 Jul 2017 at 12:30, Alberto Cortés <notifications<EMAIL_ADDRESS>wrote:
As a developer of a project that uses this repo I would like to know how to compile and tests my projects.
I believe compiling is achieved by running make packages and the binary will be at bin/.
I believe testing should be done by the project own makefile.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/src-d/ci/issues/30, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQFFw9fLbmhd-uqV2W8PigF4Z6R7MThks5sKMLBgaJpZM4OMHFp.

I think v1 provides enough documentation and examples. At least for basic operations.


Write a C program to add two matrices

Description
Write a C program to add two matrices
Matrix addition is the process of adding two matrices by adding the corresponding elements of the two matrices. Two matrices must have an equal number of rows and columns to be added.
Input  :
1 2 3
4 5 6
7 8 9

1 2 3
4 5 6
7 8 9

Output :
2 4 6
8 10 12
14 16 18

How to contribute

Save the solution in program/AddTwoMatrices.c file
Add AddTwoMatrices.c file in add-two-matrices folder

i am new to open source , can u assign this to me

!assign


Update Debian Version in Dockerfile

This Dockerfile does not work for me on a fresh install because it looks like the buster tag no longer exists and was replaced with bookworm.

Ah, thanks! The Dockerfile wasn't used actively since I migrated away from fly.io, but thanks for fixing it! Let me know if you run into any other problems.


Issue with k8s.io/docs/tasks/configure-pod-container/configure-service-account/: gce <-> kubernetes service account confusion

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
Kubernetes and GCE use the term Service Account. I assumed those are related and a kubernetes service account was or could be linked to a gcloud service account.
Proposed Solution:
Please clarify through a disclaimer that gce service accounts and kubernetes service accounts are in fact unrelated.
Page to Update:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/

/kind feature
/language en

/kind feature
/priority backlog


The following assertion was thrown while finalizing the widget tree: Multiple widgets used the same GlobalKey.

The following assertion was thrown while finalizing the widget tree:
Multiple widgets used the same GlobalKey.
The key [LabeledGlobalKey#7ce47] was used by multiple widgets. The parents of those widgets were different widgets that both had the following description:
HeroControllerScope
A GlobalKey can only be specified on one widget at a time in the widget tree.
When the exception was thrown, this was the stack

when using go_router package

@sami7568
When you file an issue, please try to use new issue template and fill out requested details so that we'll have enough info to work with.
For now, can you provide complete error log in properly formatted text, a minimal reproducible code sample along with flutter doctor -v so that we can verify this issue properly ?


Smart pointer completion

I am unable to get completions for constructs such as:
shared_ptr p;
p->member();
Since I'm using these everywhere, this puts quite severe limitations on the autocompletion.

seems to work for me

I need a better reproduce case, otherwise I will close this bug. Can you be more specific? Thanks


Hot Fix For CI Build

Signed-off-by: GabeFernandez310<EMAIL_ADDRESS>Description
Fixes CI build failure occurring in backport
Issues Resolved
Fixes https://github.com/opensearch-project/sql/pull/1236
https://github.com/opensearch-project/sql/actions/runs/3857798129/jobs/6575599281

Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1241 (864099c) into main (bac9c37) will decrease coverage by 2.36%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1241      +/-   ##
============================================
- Coverage     98.24%   95.88%   -2.37%
- Complexity     3394     3584     +190
============================================
  Files           332      354      +22
  Lines          8399     9516    +1117
  Branches        513      678     +165
============================================
+ Hits           8252     9124     +872
- Misses          142      334     +192
- Partials          5       58      +53

Flag
Coverage Δ

query-workbench
62.76% <ø> (?)

sql-engine
98.34% <100.00%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...pensearch/sql/sql/parser/AstExpressionBuilder.java
100.00% <100.00%> (ø)

...nsearch/sql/sql/parser/AstHavingFilterBuilder.java
100.00% <0.00%> (ø)

workbench/public/components/Main/main.tsx
53.00% <0.00%> (ø)

...ensearch/sql/sql/parser/AstAggregationBuilder.java
100.00% <0.00%> (ø)

...ch/public/components/QueryResults/QueryResults.tsx
61.60% <0.00%> (ø)

...c/main/java/org/opensearch/sql/sql/SQLService.java
100.00% <0.00%> (ø)

.../org/opensearch/sql/sql/parser/AstSortBuilder.java
100.00% <0.00%> (ø)

...ublic/components/QueryResults/QueryResultsBody.tsx
68.32% <0.00%> (ø)

...h/public/components/QueryLanguageSwitch/Switch.tsx
85.71% <0.00%> (ø)

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


odo list --app appName --project projectName confusing components with the same name in different applications

/kind bug

What versions of software are you using?
Operating System: Linux
Output of odo version: 2.0.7
How did you run odo exactly?
Create nodejs devfile component in demo application
$ odo create nodejs nodejs  --context /home/denis/p/test-ws/comp1 --app app --project project-name --starter=nodejs-starter
Devfile Object Validation
 •  Checking devfile existence  ...

 ✓  Checking devfile existence [16368ns]
 •  Creating a devfile component from registry: DefaultDevfileRegistry  ...

 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [20154ns]
Validation
 •  Validating if devfile name is correct  ...

 ✓  Validating if devfile name is correct [16569ns]

Starter Project
 •  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git  ...

 ✓  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [567ms]

Please use `odo push` command to create the component with source deployed

$ odo push
Validation
 ✓  Validating the devfile [41140ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [6s]
 ✓  Waiting for component to start [15ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-project-name.apps-crc.testing/ created

Syncing to component nodejs
 ✓  Checking files for pushing [1ms]
 ✓  Syncing files to the component [527ms]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [4ms]
 ✓  Executing install command "npm install" [4s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

$ odo list --app app --project project-name
Devfile Components:
APP     NAME       PROJECT          TYPE       STATE
app     nodejs     project-name     nodejs     Pushed

$ odo create nodejs nodejs  --context /home/denis/p/test-ws/comp2 --app app1 --project project-name --starter=nodejs-starter
Devfile Object Validation
 •  Checking devfile existence  ...

 ✓  Checking devfile existence [15503ns]
 •  Creating a devfile component from registry: DefaultDevfileRegistry  ...

 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [21721ns]
Validation
 •  Validating if devfile name is correct  ...

 ✓  Validating if devfile name is correct [31685ns]

Starter Project
 •  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git  ...

 ✓  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [517ms]

Please use `odo push` command to create the component with source deployed

odo" push
 ✓  Waiting for component to start [8ms]

Validation
 ✓  Validating the devfile [54309ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [14s]
 ✓  Waiting for component to start [23ms]

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component nodejs
 ✓  Checking file changes for pushing [899428ns]
 ✓  Syncing files to the component [683ms]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [3ms]
 ✓  Executing install command "npm install" [5s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

Actual behavior
odo list does not see app/nodejs component anymore
odo list --app app --project project-name
There are no components deployed.

But list app1/nodejs without issues
odo list --app app1 --project project-name
Devfile Components:
APP      NAME       PROJECT          TYPE       STATE
app1     nodejs     project-name     nodejs     Pushed

Running odo delete for component in app1 below
odo delete nodejs -f --app app1 --project project-name --all
Gathering information for component nodejs
 •  Checking status for component  ...

 ✓  Checking status for component [22ms]

Deleting component nodejs
 •  Deleting Kubernetes resources for component  ...

 ✓  Deleting Kubernetes resources for component [22ms]
 ✓  Successfully deleted component

Deleting local config
 ✓  Successfully deleted env file
 ✓  Successfully deleted devfile.yaml file

leads to deletion both app/nodejs and app1/nodejs components
odo list --app app --project project-name
There are no components deployed.
odo list --app app --project project-name
There are no components deployed.

Expected behavior
odo list --app app1 --project project-name
Devfile Components:
APP      NAME       PROJECT          TYPE       STATE
app1     nodejs     project-name     nodejs     Pushed

odo list --app app --project project-name
Devfile Components:
APP      NAME       PROJECT          TYPE       STATE
app     nodejs     project-name     nodejs     Pushed

odo delete nodejs -f --app app1 --project project-name --all
Gathering information for component nodejs
 •  Checking status for component  ...

 ✓  Checking status for component [22ms]

Deleting component nodejs
 •  Deleting Kubernetes resources for component  ...

 ✓  Deleting Kubernetes resources for component [22ms]
 ✓  Successfully deleted component

Deleting local config
 ✓  Successfully deleted env file
 ✓  Successfully deleted devfile.yaml file

odo list --app app1 --project project-name
There are no components deployed.

odo list --app app --project project-name
Devfile Components:
APP      NAME       PROJECT          TYPE       STATE
app     nodejs     project-name     nodejs     Pushed

Any logs, error output, etc?

This is because both the deployment are called nodejs and thus the second one overwrites the first one. This is related to https://github.com/openshift/odo/issues/4402

We can start renaming all resources to component_name-app_name but since certain resources like service allows maximum of 63 characters, we might need to truncate both and join but even that won't be free of collisions.

We can start renaming all resources to component_name-app_name but since certain resources like service allows maximum of 63 characters, we might need to truncate both and join but even that won't be free of collisions.

@kadel @dgolovin But this approach would break backwards compatibility.

@kadel @dgolovin But this approach would break backwards compatibility.

It can't. It needs to be implemented it in a way that doesn't break existing components.
I can see two options for how to do this.
The first is to stop relying on names altogether and use just label selectors.
The second one is leveraging the fact that each k8s resource created by odo has a label with the odo version that was used to create the resource. We should be able to use it to determine naming convention.
But I would prefer use this opportunity and try get rid of any dependency on object names and use label selectors only

The first is to stop relying on names altogether and use just label selectors.

My concern is that we would need to list the resources first and that can be slower than a get call.

We need to change all get operations to list operations similar to https://github.com/openshift/odo/blob/2c1cef43737b932fdf1b5ea0b85af3415e6b9435/pkg/kclient/pods.go#L195 for

[ ] deployments
[ ] routes
[ ] ingress
[ ] services (will require trimming)
[ ] PVCs

We also need to fix the uni tests which will be broken due to the changes.


[API] use validate tag for vlab version as well

What this PR does / why we need it:
Update vlab api to adopt validate tag. For #921, i will add OrchestratorVersionHint, don't want to have different validate functions for the new field. So I just convert it to use the tag approach as well.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): relates #921
Special notes for your reviewer:
Ready to review
Release note:

This change is

@acs-bot test this please

@acs-bot test this please


Cost functions for Lattice Planner

In your lattice planner module, you are using 6 cost functions to contribute the whole planner cost:
// Costs:
// 1. Cost of missing the objective, e.g., cruise, stop, etc.
// 2.  Cost of logitudinal collision
// 4. Cost of lateral offsets
// 5. Cost of lateral comfort
// 6. Cost of centripetal acceleration
Total cost = weighted sum of the costs above, weight of each cost function is defined manually:
// Lattice Evaluate Parameters
DEFINE_double(weight_lon_objective, 10.0, "Weight of longitudinal travel cost");
DEFINE_double(weight_lon_jerk, 1.0, "Weight of longitudinal jerk cost");
DEFINE_double(weight_lon_collision, 5.0,
"Weight of logitudinal collision cost");
DEFINE_double(weight_lat_offset, 2.0, "Weight of lateral offset cost");
DEFINE_double(weight_lat_comfort, 10.0, "Weight of lateral comfort cost");
DEFINE_double(weight_centripetal_acceleration, 1.5,
"Weight of centripetal acceleration");
My question is that in real world, there are many scenarios. How do you pick up the best weight array?

run apollo sdk in apollo Simulation. traverse all the scenarios as many as possible?
Empiricalism based on large-scale road testing?

If some developers are facing totally different scenarios from yours, how can they set the weights? Do you have any roadmap or insights to develop a learning-based approach to get your cost function more robust?

Currently these parameters are determined empirically, based on our daily urban and highway testing. In future, we expect to develop a more advanced approach that can dynamically determine the weights according to scenarios.

Closing the issue due to no further communication. Please re-open the issue if you have follow up question.


graphite  occasionally return no datapoints

Hi, i got a wierd question, i use "canbon-c-relay + carbon + graphite-web " for data collecting and storing.
I use Seyren to alert when target metric reach to the limit. Seyren checkers occasionally get no data points, so its status turn to Unknow.
The clues as follows:
graphite-web logs that i added :
2017-05-05,17:58:52.949 :: one request:
     targets: [u'asPercent(sumSeries(collectd.MONITOR_SERVER.system.memory.{free,buffered,cached,slab_recl}), sumSeries(collectd.MONITOR_SERVER.system.memory.*))']
     cachedDataNone: Cache Data None
     data: 0

data is 0, it means no data renturn.
Seyren logs:
com.seyren.core.exception.InvalidGraphiteValueException: Could not find a valid datapoint for target: "asPercent(sumSeries(collectd.MONITOR_SERVER.system.memory.{used,slab_unrecl}),8151900160)"
	atcom.seyren.core.service.checker.GraphiteTargetChecker.getLatestValue(GraphiteTargetChecker.java:83)
	atcom.seyren.core.service.checker.GraphiteTargetChecker.check(GraphiteTargetChecker.java:54)
	atcom.seyren.core.service.schedule.CheckRunner.run(CheckRunner.java:65)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Seyren logs also show graphite has not return any datapoint.
But, most of the time, it normally return data.

apache + graphite-web(fnv1a_ch hash)
carbon cache with 3 instances
carbon-c-relay with fnv1a_ch cluster

i think i have fix this issue, the problem is not about graphite, it about collectd.
when i set collectd read thread num larger than configured read plugins num, it will be easily reproduct the problem.
So, i change the num equal to the num of read plugins, then, the problem disappeared


i18n: language switcher

AC:

Add language switcher with flags.
Make it remember the choice across sessions (not cleared by logging out)

@lukaszmaterla

We need to preserve language choice across "sessions"
On Sat, Dec 8, 2018, 09:28 Adam Gajzlerowicz<EMAIL_ADDRESS>wrote:

@lukaszmaterla https://github.com/lukaszmaterla I believe this task is
completed? Is there anything to do here?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CodeForPoznan/pah-fm/issues/62#issuecomment-445442224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGX5szN-8JsaWTpt01lEWVGAUrljnO4dks5u23g3gaJpZM4Yr784
.

Language is currently synced with local storage (completed by @lukaszmaterla)

Perfect, let's close it then
On Sat, Dec 8, 2018, 11:42 Adam Gajzlerowicz<EMAIL_ADDRESS>wrote:

Language is currently synced with local storage (completed by
@lukaszmaterla https://github.com/lukaszmaterla)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CodeForPoznan/pah-fm/issues/62#issuecomment-445449707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGX5szyD-oaxzi2aauaEHGlIrfiH6E8Jks5u25ejgaJpZM4Yr784
.


browser.executeScript timeout Error after Protractor 2.0 update

After we updated to Protractor 2.0, we get an error for our test specs. As our application is available in multiple languages, our test specs are also written for multiple languages. So before the test specs starts, it must know which language is set in the browser.
So we get the locale string during the init protractor step:
browser.localeStringPromise = browser.executeScript('return foo.localeString').then(function (key) {
		localeKey = key;
//...
}

localeKey is global variable, which is asked in the test specs for language identifications.
and our onPrepare function within the protractor.conf.js looks like
onPrepare: function () {
	initProtractor();
	//..
	return browser.localeStringPromise;
}

So the test specs don't run until the locale key promise is resolved.
As I said before we updated protractor, all test specs passes smoothly with chrome. Now during the browser.executeSript step, protractor throw this error in the stacktrace:
	/$SPECPATH/e2e/node_modules/grunt-protractor-runner/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1877
  var result = fn();
               ^
	Error: Wait timed out after 7268ms

Timeout varies on each run.

A few things:

Does your onPrepare call out to browser.get? If not, you might have to use browser.driver.executeScript.

Double check that there is no other change besides upgrading to 2.0. (i.e. does downgrading protractor fix the problem)

I can't really help by looking at just these snippets. Can you post the full (even better is a reduced case) conf/onprepare/spec?

Just as a general comment, it's probably better for you to pass the locale into your test instead of relying on figuring it out in the beginning of the test.

Hi Hankduan,
thanks for the quick response. First of all I solved the problem. It is not the browser.executeScript. When I was snipping the code for you, I found the problem. In onPrepare, we have doLogin() function. Before each testspec, you must login to our webApp. This function returns a Promise, which is true when successfully logged in. It looked like this:

var loginPromise;
function __doLogin(username, pwd, forceLogin) {
if (loginPromise && forceLogin !== true) {
	return loginPromise;
}

if (!username || !pwd) {
	throw 'MISSING_ARGUMENT_EXCEPTION';
}

var loginDeferred = protractor.promise.defer(),
	baseUrl = browser.params.baseUrl,
	loginUrl = require('url').resolve(baseUrl, 'login');

loginPromise = loginDeferred.promise;
browser.driver.get(loginUrl);

loginView.getLoginNameEl().sendKeys(username);
loginView.getPasswordEl().clear();
loginView.getPasswordEl().sendKeys(pwd);
loginView.getSubmitButtonEl().click();

//CRASHING HERE
browser.driver.wait(specificPromiseToWaitFor).then(loginDeferred.resolve);
return loginPromise;

}

So after I set a specific value for the timeout in browser.driver.wait like this:

browser.driver.wait(specificPromiseToWaitFor, 35000).then(loginDeferred.resolve);

the test specs run succesfully (besides the breaking changes with the element locator)
Thanks for your help!
Best Regards


Internal private APIs are now marked as "direct" in iOS 14

https://nshipster.com/direct/
Meaning that most synchronization points, where Earl Grey (and other projects) swizzles so it can monitor the system state, are no longer available for discovery using the ObjC runtime system (reflection), and can no longer be swizzled because the underlying functions are statically called inside the system.
I wanted to start this discussion as early as now, because this will create major issues for this project and should be looked at now.

Thanks a lot for filing this @LeoNatan. I'm doing an audit to find out what methods are no longer supported for Swizzling. Till now I've only had reports of some UITouch methods failing.

Do you know or have the issue# of the touch methods failing?
I am assuming it was referenced in some other issue.

I'm doing some investigation here; it seems UITouch has been changed quite a bit.
KIF is facing the same issue: https://github.com/kif-framework/KIF/issues/1152
Just commenting out setIsTap: and _setIsFirstTouchForView: doesn't fix the issue, taps no longer work.

This seems to be an okay replacement - need more testing tho: (See the PSPDFKit marked part)
@implementation UITouch (GREYAdditions)

- (id)initAtPoint:(CGPoint)point relativeToWindow:(UIWindow *)window {
  GREYThrowOnNilParameter(window);

  point = CGPointAfterRemovingFractionalPixels(point);

  self = [super init];
  if (self) {
    [self setTapCount:1];
    [self setPhase:UITouchPhaseBegan];

    [self setWindow:window];
    [self _setLocationInWindow:point resetPrevious:YES];
    [self setView:[window hitTest:point withEvent:nil]];
    [self setTimestamp:[[NSProcessInfo processInfo] systemUptime]];

    // PSPDFKit: This was changed in iOS 14.
    if ([self respondsToSelector:@selector(_setIsFirstTouchForView:)]) {
        [self setIsTap:YES];
        [self _setIsFirstTouchForView:YES];
    } else {
        [self _setIsTapToClick:YES];

        // We modify the touchFlags ivar struct directly.
        // First entry is _firstTouchForView
        Ivar flagsIvar = class_getInstanceVariable(object_getClass(self), "_touchFlags");
        ptrdiff_t touchFlagsOffset = ivar_getOffset(flagsIvar);
        char *flags = (__bridge void *)self + touchFlagsOffset;
        *flags = *flags | (char)0x01;
    }
  }
  return self;
}

@end

We can track the issue here. Issues seen till now -

recordFailureWithDescription is broken and should be a straight move to XCTIssue.
UITouch issues shown by @steipete. We have fixes for these similar to what you've added.

I'll have 1 / 2 sent to earlgrey2 on Github by EOD.

Curious with what workaround you came up with. Our EarlGrey v1 fork now passes all tests again with above change.

Sorry for the delay here as I was testing this out more.
For recordFailure, the fix is present here - https://github.com/google/EarlGrey/pull/1377
Will send the UITouch fix tomorrow.
We haven't seen any of our swizzling code fail till now, so the private API's we are using seem to be fine with the current beta. However, we would want to move away from the more private classes such as __NSCFLocalDataTask in the future.

In our Detox Sync, we went even more all-in on the __NSCFLocalDataTask tracking because it was more accurate to track network like that. 😣
So far, that API has not been hidden, but some other stuff in the network classes was hidden.

Yes, the current swizzling code seems fine, though if you have any other alternatives in Detox, I'll be really happy to take a look.
BTW, UITouch fixes are here - https://github.com/google/EarlGrey/pull/1378 We are obtaining the struct for the UITouchFlags and then changing the _setIsFirstTouchToView to YES.

Do you plan to backport the UITouch fix to EarlGrey 1 as well @tirodkar ? If not, would you accept a pull request?

Probably a good idea to go over the internal API headers available in EG and see which is relevant and which isn't, to prevent usage of hidden API by people in the future.

@steipete I have tried your fix and hitting this error :
stderr: Vendors/Test/EarlGrey/Src/Additions/UITouch+GREYAdditions.m:45:13: error: no visible @interface for 'UITouch' declares the selector '_setIsTapToClick:'
      [self _setIsTapToClick:YES];
       ~~~~ ^~~~~~~~~~~~~~~~
1 error generated.

I do not see the function setIsTapToClick:YES on the Earlgrey repo either. Is this something custom in your fork of Earlgrey?

@xavierjurado we do not plan to add it or support EarlGrey 1.0 going forward. If you sent a PR, we could take a look at it, but it won't be vetted out from our side.
@LeoNatan Yes, I have a doc I'm working on about the private API's that we use. Some of the chief ones causing concern are the data tracking classes we use - __NSCFLocalDataTask. Happy to get any suggestions from your side on how to track network requests without it.
@ThreeFingerCoder - That code is pushed to the Github Repo here. Where are you building the code from?

@tirodkar Sorry I have a fork of the earlgrey locally, and was testing on it.
#if defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
        [touch _setIsTapToClick:YES];
#endif

This actually solved the issue I had above.

We too are swizzling __NSCFLocalDataTask methods, but mostly public ones, such as resume and suspend. We're also swizzling connection:didFinishLoadingWithError:, which is "public" because it's called by another class, and I don't think their direct implementation survives this barrier. So for now, it's safe.
https://github.com/wix/DetoxSync/blob/master/DetoxSync/DetoxSync/Spies/NSURLSessionTask%2BDTXSpy.m
Otherwise we now swizzle public NSURLSession methods which should be safe:
https://github.com/wix/DetoxSync/blob/master/DetoxSync/DetoxSync/Spies/NSURLSession%2BDTXSpy.m
I took a slightly different approach to swizzling the user's delegate. I subclass the user's class dynamically so that we avoid the issues with analytic and crash handling frameworks (this is a historic issue we had with Earl Grey, which we solved in a PR but there is still potential for issues).
Ideas how to do this can be found here:
https://github.com/wix/DTXObjectiveCHelpers/blob/a05861bfe0a1b227cd6308fd834a7fce532e77e8/DTXSwizzlingHelper.h#L99

@ThreeFingerCoder Yup, just a private header to allow calling the function.


Survivors Ghosts do not have their Character Name

Description
Survivors Ghosts do not share the dead bodies character name, unlike (most) other ghosts.
Reproduction
Roll survivor, die/ghost, have your handle instead of the character name.
Screenshots
N/A
Additional context
May be connected to survivors not having their intended accent traits either?

Roll survivor, die/ghost, have your handle instead of the character name.

happens with roundstart xenos too

also for ghost role larva when you die your name is larva instead of whatever caste you may have evolved to

also for ghost role larva when you die your name is larva instead of whatever caste you may have evolved to

unless you rolled a ghosted xeno


Document --locale compiler option

Our documentation does not list what the allowed values of this option are. It also doesn't show up in tsc --help. We should be able to infer the locale names from the generated directory names from gulp localize.

Also added to the wiki under https://github.com/Microsoft/TypeScript/wiki/Standalone-Server-(tsserver)


feature: more item-related Minecraft improvements

reopened of #28 because of branch change

to-do:

ensure 100% item API coverage. (check all ItemMetas for missing methods.)
? merge AxolotlBucketBuilder#hasVariant into #variant by returning null if !hasVariant. applicable to any #x with a corresponding #hasX.

#hasVariant is just

thoughts on renaming TropicalFishBucketMeta#variant -> #hasVariant? since it's not a plain getter (it's calculated from deviations from the norm of the three pattern and color variables), the modern convention of dropping prefixes from getts and setters doesn't apply here.
it would be a breaking API change for something really fuzzy/subjective, so it's probably not even worth it.

thoughts on renaming TropicalFishBucketMeta#variant -> #hasVariant? since it's not a plain getter (it's calculated from deviations from the norm of the three pattern and color variables), the modern convention of dropping prefixes from getts and setters doesn't apply here.
it would be a breaking API change for something really fuzzy/subjective, so it's probably not even worth it.

I prefer this, package has changed anyway so no point worry about breaking api

I prefer this, package has changed anyway so no point worry about breaking api
the #hasVariant, that is?

deleting this branch/pr and making a new one b/c merging is hard >///< and I'd rather just make new commits lmfao


CAPI - add multiRuleUpdate endpoint

https://app.graphite.dev/github/pr/statsig-io/statsig/23981/CAPI-add-multiRuleUpdate-endpoint#thread-PRRT_kwDOEv8J2s489Wgd
Removed 2 examples for Individual Rule Update as those Responses don't exist anymore

#1574  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danielwest-statsig and the rest of your teammates on  Graphite

🚀 Deployed on https://66442a05a301d9402b7caa4b--cozy-fox-0defec.netlify.app

Merge activity

May 15, 5:29 PM EDT: @danielwest-statsig merged this pull request with Graphite.


feat: Add indicator chaining

Description

Add indicator chaining

Indicators now can be chained with IndicatorChain.

 IndicatorChain.use_quotes(quotes, CandlePart.OPEN).add(get_rsi, 10).add(get_rsi).add(get_alligator, 15).calc()

Checklist

[ ] My code follows the existing style, code structure, and naming taxonomy
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have performed a self-review of my own code and included any verifying manual calculations
[ ] I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage.  New and existing unit tests pass locally and in the build (below) with my changes
[ ] My changes generate no new warnings and running code analysis does not produce any issues
[ ] I have added or run the performance tests that depict optimal execution times
[ ] I have made corresponding changes to the documentation

Problem of Method 1

difficult to handle error
cannot get chaining attribute (e.g. value for whether it's chainable or not)
code looks ugly

deprecated:
def get_gator(quotes: Iterable[AlligatorResult]) -> "GatorResults[GatorResult]"

suspended for now..


electron packager cannot build for windows anymore since upgrading to OSX 10.15

Found an issue or bug with electron-vue? Tell me all about it!
Questions regarding how to use electron or vue are likely to be closed as they are not direct issues with this boilerplate. Please seek solutions from official documentation or their respective communities.
Describe the issue / bug.
#
When trying to package on OSX:
Packaging app for platform mas x64 using electron v4.1.4
Packaging app for platform darwin x64 using electron v4.1.4
Packaging app for platform win32 x64 using electron v4.1.4
Packaging app for platform linux x64 using electron v4.1.4
WARNING: signing is required for mas builds. Provide the osx-sign option, or manually sign the app later.
Unhandled rejection Error: spawn Unknown system error -86
at ChildProcess.spawn (internal/child_process.js:366:11)
at spawn (child_process.js:551:9)
at module.exports (/Users/meow/data/phd/phd_projects/pipeline/code/elephant_client/node_modules/rcedit/lib/rcedit.js:47:15)
at P (/Users/meow/data/phd/phd_projects/pipeline/code/elephant_client/node_modules/electron-packager/node_modules/pify/index.js:32:6)
at new Promise ()
at /Users/meow/data/phd/phd_projects/pipeline/code/elephant_client/node_modules/electron-packager/node_modules/pify/index.js:6:9
at ret (/Users/meow/data/phd/phd_projects/pipeline/code/elephant_client/node_modules/electron-packager/node_modules/pify/index.js:56:76)
at getIconPath.then.icon (/Users/meow/data/phd/phd_projects/pipeline/code/elephant_client/node_modules/electron-packager/win32.js:95:39)
How can I reproduce this problem?
#
upgrade to OSX 10.15 type yarn run build
Tell me about your development environment.

Node version: 10.16.3
NPM version: 6.9.0
vue-cli version: (if necessary)
Operating System: OSX 10.15

If you are looking to suggest an enhancement or feature, then feel free to remove everything above.

As of OSX 10.15, Apple no longer supports 32-bit applications such as Wine, which is used to package apps for Windows.
There is an open issue related to this on the Electron-Builder repo.
After looking for a solution for several days, I tried building it from a Docker image instead on my local machine.  It was my first time to ever use Docker but it was simple to accomplish just by following this documentation from Electron-Builder.


[FEATURE REQ]Cosmos spark - ensure that the user agent header does not only have info about the clusterId but also the workspace when running in DBX

Is your feature request related to a problem? Please describe.
Today the user agent suffix of the Spark Connector has info about the Databricks clusterId - but not the Workspace. When trying to find rgoue Spark jobs consuming RU/s itis hard to identify the offending cluster when there are many workspaces.
Describe the solution you'd like
Add Workspace and clusterId in Databricks to the userAgent suffix.
Describe alternatives you've considered
n/a
Additional context
n/a
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

This has been implemented and recent Spark connector versions have it. (> 4.30.* for sure)


add average/smoothed curves

due to the high frequency oscillation in the line chars when selecting many epochs, it can sometimes be hard to see the overall trend over time.
we could additionally show the average curve or a smoothed curve. maybe the user should be able to switch between smoothes/average and raw data.

Also necessary for detail view.


autocorrect: 2.9.0 -> 2.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for autocorrect is: A linter and formatter for help you improve copywriting, to correct spaces, punctuations between CJK (Chinese, Japanese, Korean)
meta.homepage for autocorrect is: https://huacnlee.github.io/autocorrect
meta.changelog for autocorrect is: https://github.com/huacnlee/autocorrect/releases/tag/v2.9.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.0 with grep in /nix/store/4sl9222q4lkjix6v79m7r4kkn7nk5gdh-autocorrect-2.9.0
found 2.9.0 in filename of file in /nix/store/4sl9222q4lkjix6v79m7r4kkn7nk5gdh-autocorrect-2.9.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
autocorrect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4sl9222q4lkjix6v79m7r4kkn7nk5gdh-autocorrect-2.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A autocorrect https://github.com/r-ryantm/nixpkgs/archive/1ca8a59711ae48e0d7353f60e96732d1b92ac8c1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1ca8a59711ae48e0d7353f60e96732d1b92ac8c1#autocorrect

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4sl9222q4lkjix6v79m7r4kkn7nk5gdh-autocorrect-2.9.0
ls -la /nix/store/4sl9222q4lkjix6v79m7r4kkn7nk5gdh-autocorrect-2.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

autocorrect

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for autocorrect is: A linter and formatter for help you improve copywriting, to correct spaces, punctuations between CJK (Chinese, Japanese, Korean)
meta.homepage for autocorrect is: https://huacnlee.github.io/autocorrect
meta.changelog for autocorrect is: https://github.com/huacnlee/autocorrect/releases/tag/v2.9.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.1 with grep in /nix/store/50s9fl062pzv2wil0gq1dwirb786yb37-autocorrect-2.9.1
found 2.9.1 in filename of file in /nix/store/50s9fl062pzv2wil0gq1dwirb786yb37-autocorrect-2.9.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

autocorrect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/50s9fl062pzv2wil0gq1dwirb786yb37-autocorrect-2.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A autocorrect https://github.com/r-ryantm/nixpkgs/archive/8a3c788bde711683e81dd2e26e7762dba3762299.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8a3c788bde711683e81dd2e26e7762dba3762299#autocorrect

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/50s9fl062pzv2wil0gq1dwirb786yb37-autocorrect-2.9.1
ls -la /nix/store/50s9fl062pzv2wil0gq1dwirb786yb37-autocorrect-2.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

autocorrect

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for autocorrect is: A linter and formatter for help you improve copywriting, to correct spaces, punctuations between CJK (Chinese, Japanese, Korean)
meta.homepage for autocorrect is: https://huacnlee.github.io/autocorrect
meta.changelog for autocorrect is: https://github.com/huacnlee/autocorrect/releases/tag/v2.9.3
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.3 with grep in /nix/store/02rnq8vcawx478bzrp8fr79kjazws50v-autocorrect-2.9.3
found 2.9.3 in filename of file in /nix/store/02rnq8vcawx478bzrp8fr79kjazws50v-autocorrect-2.9.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

autocorrect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/02rnq8vcawx478bzrp8fr79kjazws50v-autocorrect-2.9.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A autocorrect https://github.com/r-ryantm/nixpkgs/archive/0eeb4940c23d99f1d8eebe29b56c9cc514e378f0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0eeb4940c23d99f1d8eebe29b56c9cc514e378f0#autocorrect

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/02rnq8vcawx478bzrp8fr79kjazws50v-autocorrect-2.9.3
ls -la /nix/store/02rnq8vcawx478bzrp8fr79kjazws50v-autocorrect-2.9.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

autocorrect

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for autocorrect is: A linter and formatter for help you improve copywriting, to correct spaces, punctuations between CJK (Chinese, Japanese, Korean)
meta.homepage for autocorrect is: https://huacnlee.github.io/autocorrect
meta.changelog for autocorrect is: https://github.com/huacnlee/autocorrect/releases/tag/v2.10.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.10.0 with grep in /nix/store/78wy1d45gpw9mqw7hjdxqfr9cgjkqz6y-autocorrect-2.10.0
found 2.10.0 in filename of file in /nix/store/78wy1d45gpw9mqw7hjdxqfr9cgjkqz6y-autocorrect-2.10.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

autocorrect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/78wy1d45gpw9mqw7hjdxqfr9cgjkqz6y-autocorrect-2.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A autocorrect https://github.com/r-ryantm/nixpkgs/archive/ef097d88239fbabc056eed2f69754220280527b9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ef097d88239fbabc056eed2f69754220280527b9#autocorrect

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/78wy1d45gpw9mqw7hjdxqfr9cgjkqz6y-autocorrect-2.10.0
ls -la /nix/store/78wy1d45gpw9mqw7hjdxqfr9cgjkqz6y-autocorrect-2.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

autocorrect

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for autocorrect is: Linter and formatter for help you improve copywriting, to correct spaces, punctuations between CJK (Chinese, Japanese, Korean)
meta.homepage for autocorrect is: https://huacnlee.github.io/autocorrect
meta.changelog for autocorrect is: https://github.com/huacnlee/autocorrect/releases/tag/v2.11.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.11.1 with grep in /nix/store/b96vs9s1arfjm8vpcvmbwzpyqyks9bmm-autocorrect-2.11.1
found 2.11.1 in filename of file in /nix/store/b96vs9s1arfjm8vpcvmbwzpyqyks9bmm-autocorrect-2.11.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

autocorrect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b96vs9s1arfjm8vpcvmbwzpyqyks9bmm-autocorrect-2.11.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A autocorrect https://github.com/r-ryantm/nixpkgs/archive/f18149d25164294eda76f75d5cf90388194e3f2a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f18149d25164294eda76f75d5cf90388194e3f2a#autocorrect

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b96vs9s1arfjm8vpcvmbwzpyqyks9bmm-autocorrect-2.11.1
ls -la /nix/store/b96vs9s1arfjm8vpcvmbwzpyqyks9bmm-autocorrect-2.11.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

autocorrect

Maintainer pings

All checks pass.


POC for Portfolio Update

The portfolio needs to be updated to add some advanced features and the latest tech stack. Need to POC for the same. The new tech stack may be somewhere around the following things -

Next.js
Sanity.io as Headless CMS
Tailwind CSS
TypeScript
shadcn UI
MDX for blogs
ES Linting

The most important thing is to figure out how to switch from plain React.js to Next.js in the same repository.


Typo in v.4 Guidelines Ch. 3

This heading in section 3.3.2 has a typo. It reads: "Responsility Attribution"
It should read "Responsibility Attribution"

Thanks for reporting.
fixed with 5139d7d78e0f3183f0f799bd5ffc6dc9e140338a


Bug Block Disappearing

When standing too close to a block while placing it the placed block disappear, tested in the latest df version
Video: https://streamable.com/hdzdo8
Video2: https://streamable.com/thcyem
Video3: https://streamable.com/45xnxd

Thanks for reporting! Could you try 4125eadb1d8a2112712b875d67da78a1a662b1bc and see if it fixes your issue?

yea, now its fixed

Perfect, thanks!


User CRUD API tests

Yay we're almost 10% higher in code coverage!!! :)

Awesome! We're getting there! :) Great job!

@ilanbiala - useful comments as always, thanks for the code review.
Let me know what do you suggest we do about the e-mails - which even if we fix for Travis, chances are high that it won't work on common machines (just as it doesn't work on my own even), without proper setup.

@lirantal What specifically doesn't work locally when you test it?

@ilanbiala the forgot functionality fails due to not being able to send e-mail, so it responds with a 400 error, specifically here: https://github.com/meanjs/mean/blob/master/modules/users/server/controllers/users/users.password.server.controller.js#L87
The tests are written in a way that validates that even after we get a 400 response the database is inspected to confirm there is indeed the reset token etc. When it's failing with that 404, it is failing for not being able to send the email, which if you look at the above controller code then otherwise it just sends the e-mail ok.
I think testing the e-mail being sent is beyond the scope of the tests so I don't want to introduce testing emails sent out.

@lirantal I'm pretty sure it errors because the API keys aren't even set. Have you looked at the error message from it, because Nodemailer doesn't throw an error for not being able to actually send an email, it just follows send and forget if I remember correctly.

Good to know, I'll try it.
If that will work then it means we can also cover both branches in the code (the successful email and the failed one due to bad config)

@ilanbiala even when I comment the options property in test.js config I'm getting the same error.

@lirantal what do you mean comment? You need to provide that is what I'm saying for Nodemailer not to error. What is the specific error you get?

@ilanbiala ok I understand the confusion now.
I don't think we should be making sure that nodemailer is able to send the email because that's beyond the scope of the API tests. If we were able to confirm that everything in the code was tested successfully up until the point where nodemailer fails to send an e-mail because no e-mail settings were configured then this is ok IMO.

@lirantal that's fine, but we can make sure we don't get an error because of Nodemailer, whether it actually sends or not. What is the specific error you see when you assert those 400s?

A little hint for email testing, the following is our implementation. We use sinon to mock the function that actually sends the email and verify a callcount for each recipient. Maybe it's useful to you:
describe('Mailer Controller:', function() {
	beforeEach(function(done) {
		done();
	});

	describe('sendMail()', function() {
		beforeEach(function() {
			transport = {
				name: 'testsend',
				version: '1',
				send: function(data, callback) {
					callback();
				}
			};
			mailer.setTransport(transport);
		});

		it('should be defined', function() {
			mailer.sendMail.should.not.equal(undefined);
		});

		it('should try to send email', function(done) {
			sinon.stub(transport, 'send').yields(null, 'tere tere');

			mailer.sendMail('empty', {
				to<EMAIL_ADDRESS>			}, null, function(err, info) {
				should.not.exist(err);
				transport.send.callCount.should.equal(1);
				info.should.equal('tere tere');
				transport.send.restore();
				done(err);
			});
		});
	});
});

@ilanbiala "Failure sending email" is the exact error that is being returned, specifically here, by this call: https://github.com/meanjs/mean/blob/master/modules/users/server/controllers/users/users.password.server.controller.js#L87
I believe this assertion is just fine because it tests our API and that everything is ok, the other way the if statement can end there is with success.

@lirantal I'm referring to this err variable https://github.com/meanjs/mean/blob/master/modules/users/server/controllers/users/users.password.server.controller.js#L80

@ilanbiala it throws err:
{ [Error: self signed certificate] code: 'DEPTH_ZERO_SELF_SIGNED_CERT' }

@ilanbiala I can workaround the email problem by adding the following options to nodemailer transport:
tls: {
        rejectUnauthorized: false
      }

Do you suggest I add it as the default options in config/env/test.js? Or should I instead inject it to the options variable only for the tests? that's also possible.

@lirantal yeah that sounds fine, unless we can get a free certificate and still keep it secure somehow.

@ilanbiala even though with the tls config it works fine locally on my machine (probably because I have some mail server configured there), on travis it fails due to:
{ [Error: connect ECONNREFUSED]
  code: 'ECONNREFUSED',
  errno: 'ECONNREFUSED',
  syscall: 'connect' }

returned by nodemailer itself.
This goes back to the problem that we can not assure that there is indeed a mail server that will work for nodemailer config to complete our API with 200 successful response. Do you think there's anything else we can try except changing back to asserting 400?

@ilanbiala per my previous comment - I'm going to refactor the tests back to assert for a 400 "failed sending tests" issue as it seems that nodemailer is not environment-agnostic and will require some kind of email environment setup to be able to return 200 for tests. Since it is not the purpose of the test to check an email was sent I don't see it as a problem.
Let me know if you think otherwise or would like to suggest an alternate method for testing this.

@ilanbiala I reverted back the changes so that we still assert a 400 due to unable to reliably being able to test an email sending option end-to-end. Since we worked out all other issues I'll go ahead and merge this PR once the build is complete so we can have a broader safety net of code coverage for tests.

Hi guys I am using MEAN stack in my application with AngularJS as my front-end.....my problem is if i forget the password i were enter the user name and submitted, but i got error like  "Failure sending email" is there any solution to solve this....I'M new to angular... so please help to solve this issue....forgot password page is not working.....thanks...

@Maniselvam006 You probably did not set up your email preferences:
https://github.com/meanjs/mean/blob/master/config/env/development.js#L62
Next time please open an issue, or ask on Gitter. Good luck with meanjs, I hope you will like it !


Some measure of bucketed statistic reliability

When doing bucketing of either words or sentences, some of the buckets may have very few examples included, and thus the estimates of statistics may not be very reliable. It would be nice to have some idea of the reliability of these, either through:

Outputting the number of counts of words/sentences in each bucket
Error bars on the estimates calculated through regular standard deviation, or bootstrapping

Hi, this would be great to have. Any progress on this?

Hi @rohitg1594, thanks! Hopefully this will be done by the end of August. Contributions are also welcome!


bump Go vertion to 1.21

Codecov Report

Merging #122 (94cd7be) into main (055df4f) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   97.26%   97.26%
=======================================
  Files          35       35
  Lines        1315     1315
=======================================
  Hits         1279     1279
  Misses         24       24
  Partials       12       12

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Remove 'rimraf' unused dependency

Apparently it is not being used anywhere in the library.
It can create versioning issues with other packages.
package.json
  "peerDependencies": {
    "@nestjs/common": ">=10.0.0",
    "@nestjs/core": ">=10.0.0",
    "@sentry/hub": "^7.7.0",
    "@sentry/node": "^7.7.0",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",  <- remove
    "rxjs": "^7.2.0"
}

rimraf is actually used in clean script in package.json, but it cannot be used by users of the library, so I updated it and moved it to optionalDependencies in my PR

@bakasmarius Thanks!

Can we get this released?  This bad dependency causes multiple deprecation warnings

I think that you should migrate to the official (in beta, but maintained) Sentry NestJS integration
https://www.npmjs.com/package/@sentry/nestjs


receiving multiple warnings

Running Rspec/ ChefSpec, i'm getting spammed with the following Warning for each example"
WARN: Ohai::Config[:plugin_path] is set. Ohai::Config[:plugin_path] is deprecated and will be removed in future releases of ohai. Use ohai.plugin_path in your configuration file to configure :plugin_path for ohai.
This happens with any cookbook, which depends on the ohai cookbook (directly or down the chain), so it does not 'appear' to be specific to my code.
chefdk- 0.10
ohai cookbook -  2.0.4
Oracle Linux 6.5
chefspec - 4.4.0

I'm also experiencing this. It was a mild annoyance right up until the noise of these warnings for every.single.example caused me to miss legitimate warnings and waste a bunch of time :cold_sweat:
I just played around a bit and discovered that changing Ohai::Config[:plugin_path] to Ohai.config[:plugin_path] in recipes/default.rb makes the warnings go away. I'm not sure if that will have repercussions for older versions of ohai or chef, but it definitely fixes it for whatever versions are in the current chefdk.

I would disagree that this is resolved as it's only fixed for a subset of people using this cookbook.

If you're talking about this change breaking under Chef 11, that looks to be being tracked in #38

@chazzly um, #38 says "Fixed in 4.0" and the 4.0 release says in big letters that it only works in Chef 12 and that we must stay with v3... which has the problem listed above for all pre-Chef12 versions.


fix(layout): backlinks grid triage

Closes https://github.com/jackyzha0/quartz/issues/1454
Closes https://github.com/jackyzha0/quartz/issues/1455

[x] temporary disables overflow list gradients as I work on a permanent fix

[x] fixes backlink list orientation and styling in mobile view

[x] fixes backlink overflow on mobile

Nice job!


VRI sample does not contain PROJ_AGE_1

The VRI sample does not contain PROJ_AGE_1 is this expected?
https://github.com/bcgov/SSGBM-VRI-BEM/blob/a82157709ff4de6bb719fea189a7ed0e2c0e18f7/Python_Scripts/04_Add_LUT_age_classes_to_VRI_with_Consolidated_Cutblocks_VRIxBEM_2020.py#L89

This was my mistake. I supplied you with the wrong file. I will ask Karine to upload the VRI data again.

Added VRI and BEM shapefiles to the shared dropbox folder (VRI_BEM) - The VRI shapefile should address both PROJ_AGE questions. Let us know if you prefer different format for spatial files. I think this is the easiest on our end.


Add support for Kramdown?

I would be fairly easy to add support for Kramdown. Let us know if you are interested in contributing to that.

Fixed


Misc. TF-M+54L support

I intend to make the toup's into fromlist when I have a green CI and review.

reorganizing


compiled ES6 element class constructor called twice in IE11 and Firefox 51

I'm trying to use your plugin to support customElements ES6 definition in an ES5 environment ( such as IE).
My problem is that whenever I add my element object to the dom, his constructor is called a second time ( IE11 and Firefox51)
.babelrc
// include before transform-es2015-classes
{
  "plugins": [
    "transform-custom-element-classes",
    "transform-es2015-classes"
  ]
}

index.html
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <base href="/">
    <title>Test</title>
  </head>
  <body>
    <!-- shim for Reflect support  https://github.com/paulmillr/es6-shim-->
    <script type="text/javascript" src="lib/es6-shim/es6-shim.js"></script>
    <!-- customElements V1 polyfill https://github.com/webcomponents/custom-elements-->
    <script type="text/javascript" src="lib/webcomponents/custom-elements.js"></script>
    <script type="text/javascript" src="test.js"></script>
  </body>
</html>

test.js
var instances = [];
var count = 0;
function alreadyRegistered(instance){
	for(var i =0;i<instances.length;i++){
		if(instances[i] == instance)
			return true;
	}
	return false;
}

class fooElement extends HTMLElement{

	constructor(){
		super();

		if(alreadyRegistered(this) === true){
			console.log("constructor already called");
		}
		instances.push(this);
		this.innerHTML = "count:"+count+";";
		count++;
	}

}

customElements.define("foo-element",fooElement);
var bar = new fooElement();

document.body.appendChild(bar);

console output in IE11 and Firefox 51:
constructor already called

and innerHTML
count:1;

Am I doing something wrong ?

Sounds like it could be a bug in the polyfill.

I thought this was the most appropriate project for this problem.
In the readme, it says that your babel plugin is compatible with IE11 using customElements V1 polyfill.
Could you provide us a setup for full compatibility over the differents broswers ?

It appears that it cames from my customElements polyfill.


Fix Clock App by Setting Default Time to avoid displace random values when clock can't fetch actual time.

Changes made

[X] Set Default fallback locale
[X] Set the default value in the clock digit to prevent random values from showing.
[X] Added correct Clock icon for edge app store

Why
If we didn't set the default value and if the clock can't fetch it for some reason, the screen will display random data.

So, by setting a default value, we can understand  the issue more precisely if anything happens.

SVG Linter issue, I think we can ingore this as SVG is downloaded from the Figma.


Cloud Code doesn't return a proper Parse object

When returning a User object from a query in a cloud code function, these key-value pairs are not present:
__type: "Object"
className: "_User"

whereas they are present when calling the same function from api.parse.com.

Yep, this is a duplicate of #93.  Should be fixed soon.


update network adopt payload

add mode: wifi or mode: ethernet to network api/adopt payload

fixed in #5


Time taken on 8 A100?

Hi,
Great work! I find this eval suite very handy. Just curious, how long would it take to perform the full evaluation for a 7B model with 8A100?

Hi @jzhang38, for mistralai/Mistral-7B-Instruct-v0.2 with vLLM, here is the summary of costing time per task.
4k: 4 mins
8k: 5 mins
16k: 10 mins
32k: 17 mins
64k: 40 mins
128k: 2 hrs

Thanks. That is very helpfu!

Hi,
Can you show your config for a 8B model (e.g. Llama-3-8B-Instruct) with vllm in 8 A100? I used the following config and cost almost 24 hrs for all tasks.
run.sh:
GPUS="8" # GPU size for tensor_parallel.

config_models.sh:
        Llama-3-8B-Instruct)
            MODEL_PATH=$MY_PATH
            MODEL_TEMPLATE_TYPE="meta-chat"
            MODEL_FRAMEWORK="vllm"
            ;;

Also, if I changed GPUS=1, it just used cuda:0 and other GPUS not worked. What if running every single GPU for one single task in the meantime?
For a 70B or 72B model (e.g. Qwen2-72B-Instruct), it cost almost 2 days for a single 128K task. It's quite time consuming!
Can you give some advice for this?
Thanks.


Request: for each option in the settings, show preview of an example of what it handles

Describe the solution you'd like
Some sort of "before" and "after". Maybe like the preview of code formatting.
It can either be via a tooltip, or a part of the UI that changes as you hover over each of them (or when you press on "?" button).
I'm talking about this:

For what product
Android Studio.

@AndroidDeveloperLB I would love to add that and I've though about this many times. I'm keeping this for later, I probably will never have time to implement, but we never know, and again PRs welcomed. Cheers

Request: a save-actions.io website

@dubreuia I'm very confused. Why you say you like it, and say you close it? And why you say you close it, and you don't close it?
And what is this website? I can't even access it...

@dubreuia I'm very confused. Why you say you like it, and say you close it? And why you say you close it, and you don't close it? And what is this website? I can't even access it...

Sorry about the confusion, this issue stays open. I'd also like to make a website, but I haven't bought the domain yet (I'm just making a note to myself).

@dubreuia Oh ok.

Will not do, PRs welcomed

@dubreuia I'm not sure I follow. You say you are not against, but still close it?
:(


Allow null as data in relationship PATCH request

This allows you to remove a to-one relationship by sending null in a PATCH request, as described in the spec.
Request
PATCH {{baseUrl}}/model/:model/relationships/related
{
  "data": null
}

Result
Before
{
    "jsonapi": {
        "version": "1.0"
    },
    "errors": [
        {
            "detail": "Expecting JSON API specification compliance to have been run.",
            "meta": {
                "exception": "LogicException",
                "file": "vendor/laravel-json-api/laravel/src/Http/Requests/ResourceRequest.php",
                "line": 209,
                "trace": []
            },
            "status": "500",
            "title": "Internal Server Error"
        }
    ]
}

After
{
    "jsonapi": {
        "version": "1.0"
    },
    "links": {
        "related": "{{baseUrl}}/model/1/related",
        "self": "{{baseUrl}}/model/1/relationships/related"
    },
    "data": null
}

@JaZo thanks for submitting the PR, can't believe no one has encountered this error before now!


Empty root name

It seems to me that it is perfectly valid to set up vfs using '/' root name:
vfsStream::setup('/');

and, because any leading slash is chopped at line
https://github.com/mikey179/vfsStream/blob/v1.6.4/src/main/php/org/bovigo/vfs/vfsStream.php#L349
the result is that the root name is empty, which is ok.
echo vfsStream::url('/some-root-file.txt');
// prints: vfs:///some-root-file.txt

Yet, because of the $name{0} index at the aforementioned line, it is invalid to actually use an empty string as the setup parameter:
vsfStream::setup( '' );  // will fail

(Well, never mind. Maybe it's actually better not to omit the '/' )


Typings: label's for change to htmlFor

Hi, I have a question.
Of the attributes of the label, the for was changed to htmlFor the same as React. https://github.com/developit/preact/pull/695 (2018.03.04)
However, when defining the type of jsx file, it is changed back to for. https://github.com/developit/preact/commit/f91d5e1a268b31a8c07d6ddc83ac30e83a30bd27#diff-70083611527b9d7d728e1e14dd8f977fR518 (2018.09.02)
How about changing to htmlFor?

Good catch! This is something that got lost when merging the Preact X repo into the public one here.


[ConstraintSolver] Add debug logging of failed constraints while solving

@swift-ci please smoke test

@swift-ci please clean smoke test Linux platform


Check for iframe.src when parsing it for remoteHost

It seems that some blockers and extensions like to maniuplate/delete the src attribute from iframes. Also it might be that you create an iframe without an src (e.g. using srcDoc).
I was experiencing an annoying bug https://github.com/davidjbradshaw/iframe-resizer/issues/721, this fixed it for me.

Is there any progress on this?

Thanks for this. Released as v4.2.2


Combining multiple pull requests

Is it possible to combine the different pull requests that CompatHelper makes for every compat entry to a single pull request?

Duplicate of https://github.com/bcbi/CompatHelper.jl/issues/126


SecDataDir is not working in version 3

I have tried every path with the SecDataDir. Have also tried everything with the permissions but have not been able to get the modsecurity to write to the disk . It just doesn't write to the disk.
It always keeps the collections in memory .
SecDataDir /usr/local/secdatadir/
Have provided secdatadir each and every permission but still have not been able to get the collections written . Can anyone help?

Hi @nasirbas1 ,
It sounds like you're talking about two different things.
SecDataDir is indeed not currently supported in ModSecurity v3.  Moreover, that is not intended to be the log location.
If you're using Parallel logging as your SecAuditLogType, the directory location is specified using SecAuditLogStorageDir.

Hi @martinhsv ,
There were some misnomers in there , have updated the description.
I actually meant the collection persistence only, not the logs . The logs part is working fine
and its correctly writing to the /var/logs/modsec_audit.log. Folder name might have
confused you.
So if SecDataDir is not supported in V3 as of now , is there no way around to persist the collections
to the disk , because with Nginx they vanish every-time a reload of Nginx happens.

@zimmerle @martinhsv  Anything on this?

Hi @nasirbas1,
The Persistent collection on v3 depends on the backend support. By default, the memory back end is selected. It means that the collection indeed vanishes on every restart. You may want to enable the lmdb backend if you want to persist the collections on disk.


OSError: [Errno 7] Argument list too long when invoking javac

Projects with many files can't be scanned due to OS argument list limitations.

closed by 92801ba1c90c04a44893b85cb1ce40a669720d4d


avoid panic if output terminates due to a downstream pipe

It would be clean to support an expected end of output due to a downstream pipe:
$ tail -n 100000 potfile | cut -d: -f2- | pack2 unhex | head
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
[redacted]
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }', src/unhex.rs:15:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

As of 9ba3fbe all errors are reported except if it's due to a broken pipe which are silently dropped.
I'll leave this issue open until someone was able to test it on Windows.

Confirmed to be working on Windows as well, therefore I'm closing this.

Awesome, thanks!


TypeError: request.setMentonalIdsList is not a function

23:05:59 VERB PuppetService messageSend(18131996049@chatroom, Der! I just got online!
Friday.BOT v0.11.11)
23:05:59 VERB ContactSelf name()
23:05:59 VERB ContactSelf name()
23:05:59 INFO IoClient Friday BOT logged in
23:05:59 VERB Io send() without a connected websocket, eventBuffer.length = 1
23:05:59 VERB Room ready()
23:05:59 VERB Puppet roomPayload(24980472405@chatroom)
23:05:59 VERB PuppetService roomRawPayload(24980472405@chatroom)
23:05:59 VERB FlashStore get(24980472405@chatroom)
23:05:59 ERR Config ###########################
23:05:59 ERR Config unhandledRejection: TypeError: request.setMentonalIdsList is not a function
    at PuppetService.messageSendText (file:///home/friday/git/friday/node_modules/wechaty-puppet-service/dist/esm/src/client/puppet-service.js:547:21)
    at WechatifiedRoom.say (file:///home/friday/git/friday/node_modules/wechaty/dist/esm/src/user/room.js:402:47)
    at Wechaty.<anonymous> (file:///home/friday/git/friday/dist/src/friday/setup-finis.js:15:60)
    at Wechaty.emit (events.js:388:22)
    at Wechaty.emit (domain.js:470:12)
    at PuppetService.<anonymous> (file:///home/friday/git/friday/node_modules/wechaty/dist/esm/src/wechaty.js:295:34) [object Promise]

We should be careful when working with gRPC definitions.
Though this name change (setMentonalIdsList -> setMentionalIdsList) will not affect the network communication (thanks gRPC!), however, it still affects our program if the version is a mismatch by mistake.