Hover Button

A button that highlights when the cursor hovers over it.
It has no props. It emits 3 types of events: When the mouse moves onto the button, when it moves off the button, and when the button is clicked.

It has two methods: buttonClick and changeState, which are called when the button is clicked, and when the mouse moves on or off of the mouse, respectively.

The button has no computed properties, and has four data attributes: "hovering", "text", "on_off", and "depressed".

Hey Mark,
Good button but perhaps you should stop calling it demo button, I almost could not find it!
A few points here:

Is there any reason you choose to make a data (on-off) that stores hovering?
Have you consider including a way to disable the button?

Hi both,
I've resolved the issue of the Hover button appearing in the wrong location.
Darren: I stored the on-off data as a way of implementing the background shading change, do you think I could do this more simply?
Could you explain what you mean what you mean by disable the button?

Hi both,
I've resolved the issue of the Hover button appearing in the wrong location.
Darren: I stored the on-off data as a way of implementing the background shading change, do you think I could do this more simply?
Could you explain what you mean what you mean by disable the button?

Hey Mark,
The hovering shading can be implemented as a pure CSS property. For example, in ToggleBasic I have .toggleBasicLabel:hover{
some properties that gets triggered when cursor is on toggleBasicLabel
}
As for the depressed property, you should have a think about the functionality of the button -  Do you want it to be binary like ToggleBasic or just emitting neutral events upon clicking?
In ToggleBasic for example, I have this props that allows us to pass a Boolean that can disable the functionality of the toggle, i.e. the toggle becomes non-reactive, and turns the toggle grey to inform the user. This disable props can be useful in situations like when a vis is playing, we want to prevent the users from changing certain parameters.

Following Darren's comments,
I've re-implemented the shading as a purely CSS property. Since the component is a button, I decided that having an on-off piece of data was pointless, provided I kept the event emitted when the button is clicked. Following this mindset, I took followed the direction Darren took and got rid of the button's "depressed" property.
I've also now added the option for the button to be disabled, as in the basic toggle.

Nice work Mark, quick question on the disabling feature, what should I do to disable the button?

Quick shout on this, @krammyt you are going to need to merge with upstream/dev before you are able to merge this PR, this may also involve you having to make a new PR, tho try to stick with this one if you can (the discussion is good 😄 )

@FreyaXH just choose the diabled tickbox in prop, it should disable the button in the same way as in the basic toggle.
@OneOneFour Noted!

Hey Mark,
Is there any reason you choose to keep "hovering" in data and to emit the hovering events? What are the example situations where we want hovering events to trigger other events?

Hi Darren,
good spot! I'll either get rid of the hovering data or remove the events being emitted, as having both is unnecessary. The idea I have in mind is that before clicking the button, it might be useful that a region relevant to the button being clicked might become highlighted (or something similar).
It has been discussed that RK is coming up with a solution for the slots issue.

@Puredbest it seems not. It's gone now!


Auth story?

It looks like Hecate preserves the OSM distinction between publicly accessible read-only content and auth-required read-write access. I wonder if this makes sense going forward. If a usecase for this service is potentially store internal-use/private data, reads would also need to be protected. It seems like, freed from the constraints of OSM's code, you'd either want to secure everything at the network level, or everything with username/password, but I'm not sure why you'd additional levels of auth/protection for some parts of the service than for others. Maybe it's just a constraint imposed by a desire to still interoperate with JOSM?

@apendleton yup, as you mention above - the auth story has to duplicate that of OSM to enjoy the benefits of using JOSM/iD.

Hecate auth is now fully customizable per the Custom Authentication section of the readme


Merge master branch to prTesting1_201905061018 branch

Docs Build status updates of commit dd00f78:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


compiled Sass adds line numbers before each selector

Hi everyone,
i'm using Brackets (Release 1.1 build 1.1.0-15558) with Brackets SASS (1.0.4-83)
Each Sass file compiled into css looks weird to me,
before each selector a comment + line number + path is added,
How can I change it, so that I wouldn't see these comments in the compiled CSS file?
Sample:
/* line 15, Z:/DESIGN/Roman/mm/website/cf/html/css/style.scss */
.topNav {
font-family: 'Open Sans Condensed', sans-serif;
font-weight: 700;
text-transform: uppercase; }
/* line 16, Z:/DESIGN/Roman/mm/website/cf/html/css/style.scss */
.bottomNav a {
font-family: "Lucida Sans Unicode", "Lucida Grande", sans-serif;
font-weight: 200;
text-transform: uppercase;
color: #fff !important;
font-size: 12px; }
/* line 17, Z:/DESIGN/Roman/mm/website/cf/html/css/style.scss */
.search {
.......
thank you,
Roman

Just create a .brackets.json file at the root of your project with this content:
{
    "sass.options": {
        "sourceComments": false
    }
}

@nicolo-ribaudo, that's what I thought as well but setting the sourceComments option to false in the .brackets.json file doesn't help me. I'm still getting those unhelpful comments with the following .brackets.json configuration:
{
  "sass.enabled": false,
  "path": {
    "sass/style.scss": {
      "sass.enabled": true,
      "sass.options": {
        "outputDir": "..",
        "outputStyle": "nested",
        "sourceMap": false,
        "sourceComments": false
      }
    }
  }
}

(Aside from the fact that this option should be turned off by default anyway.)

I am having the exact same issue. Doesn't seem anything inside the sass.options is being read properly. I can change outputSyle to and it does nothing. You ever figure out what was causing this problem?

Try removing "sourceMap": false, or set it to true.


Add validity checks to the release HT code

The current validity checks run on the flat HT right before VCF export so I'll be working on the code there instead of the release HT code.

Closing, replaced by #478


We should add a description field for each and all URLs in all IDs

Most of customers in my country they want to know each IDs are used by what functions and services. They also want to open minimum URLs and IPs for their network and security. So, we need to identify each IDs what they do.

@Altemir I will pass this feedback to the product teams for their consideration. Thanks for you feedback.


feat(infiniteHits): add previous button

Summary

The InfiniteHits widget is used to display a list of results with a “Show more” button. The user can click on this button to display more results without leaving its current page context.
Each time the user click on the “Show more” button the user will navigate to a new page (provided that the routing option is enabled in InstantSearch).
However, in the case the user navigates directly to a particular page (direct link, previous button, page refresh) then the widget only displays the last result page.
This change add a previous button to the Infinite Hits widget to give the possibility to the user to load the previous result pages.
For implementation details see the full RFC.
Before being mergeable, this change requires an update in https://github.com/algolia/instantsearch-specs to add the new CSS classes:

[x] Merge https://github.com/algolia/instantsearch-specs/pull/101
[x] Publish new InstantSearch.css release: Published in release v7.2.0

Note
This PR was previously merged #3645 but was ultimately reverted #3674.
The reason is that it removed a condition that reseted the widget internal cache when reaching the first page. It was removed since it was conflicting with the new previous button feature.
Sadly, this reset step was essential to reset the widget internal cache on any refinement or query update so we don't append the new results with the ones from the previous search.
This was fixed by re-introducing this code but with a different condition: since we can not rely on the page index anymore we now compare the full search state for any difference, and reset the cache if any difference (except for the page) is found.
While working correctly this fix is not very clean IMHO (it serializes the full state to do the comparison :nauseated_face: ), so if anyone has a better idea I am open to any suggestion :hugs: )
Result

A "with previous button enabled" story has been added for the Instant Hits widget.
https://deploy-preview-3675--instantsearchjs.netlify.com/stories/?path=/story/infinitehits--with-previous-button-enabled
fixes #2835

The latest fix doesn't seem to solve the issue. In the story, the InfiniteHits still don't react to the new query.

Mmm, the version on netlify seems to be an old one and does not contains the last changes.
What can explain that? Is there a way to force a new deployment?

You can re-trigger a deployment with a clear cache in the Netlify interface.

Figured it out: the link in the description was from the old PR, the one with the bug :woman_facepalming:
I updated it to link to the good deployment :innocent:


Remove examples folder

This PR removes the examples folder. This is done because we have made many improvements and additions to our official docs, including to much of the content that was included (or planned for inclusion) here. It also creates a contrib folder for any example contributions that relate to the helm charts but may not make sense to live in our official docs.

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1204218351694990

We should check with @JakeSCahill before merging in case there are any docs that point to the examples.


Add AutoEstimateGas and GasAdjustmentFactor parameters to estimate gas automatically before broadcasting the tx

Summary by CodeRabbit

New Features

Introduced AutoEstimateGas and GasAdjustmentFactor parameters to enhance transaction broadcasting efficiency.
Improved configurability for gas management during transactions.

Bug Fixes

Resolved an issue with default parameters in the GMP configuration.

Documentation

Updated developer documentation to reflect new configuration parameters and their usage.

i suppose this closes #681


Bulk edit of findings do not work if findings mandatory fields are not satisfied

Bug description
And this definitely does not sound like a bad thing, and working by design.
However, that "impact" field being mandatory after the initial data ingestion, whereas many importers do not put anything in it on ingestion is making it just a bad experience and the UI does not even reflect what the problem might be.
Would we eventually want to make "impact" a non-mandatory field? Or put the burden on each parser to put at least some string in it? Should consistency with that field (and surely others) be imposed straight from the import function?
Steps to reproduce
Steps to reproduce the behavior:

Select findings for bulk editing, which have an empty "impact" field
Try to change their status, say "false positive"
Witness nothing changes, and no error message either.

Expected behavior

At least some error message, and not a "successful" message...
or fix the root

Deployment method (select with an X)

[ ] Kubernetes
[x] Docker
[ ] setup.bash / legacy-setup.bash

Hey @madchap what scanner did you use to produce this? The reason I ask is because I tried to replicate this bug using the cobalt parser, but bulk edit worked as intended, even though the cobalt's findings have nothing in their impact field.


Added 2 unit tests for BasicLSTMCell to check ValueError.

Tests that dimension 0 in both(x and m) shape must be equal.
Tests that state_size must be num_units * 2.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please


图像描述在运行作者给的demo时报错

Traceback (most recent call last):
File "D:/softWare/Python/pythonrun/Machine-Learning/dataClass/test.py", line 9, in
data = t.load(opt.caption_data_path)
File "D:\softWare\Python\pytorch\Anaconda3-5\anaconda\lib\site-packages\torch\serialization.py", line 227, in load
f = open(f, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: 'caption.pth'
If you suspect this is an IPython bug, please report it at:
https://github.com/ipython/ipython/issues
or send an email to the mailing list at<EMAIL_ADDRESS>You can print a more detailed traceback right now with "%tb", or use "%debug"
to interactively debug it.
Extra-detailed tracebacks for bug-reporting purposes can be enabled via:
%config Application.verbose_crash=True

应该把caption.pth放在当前的文件夹下，你可以试一下

有问题可以重开issue @tyjwan
谢谢 @ROCKBOOM


fix bfpassword countUppercaseLetters function

Please check this issue and merge it.

Thanks, this was a my mistake :+1:

welcome


refactor: set missing input props

Description:
Set missing input props
Motivation and Context:
We set TextArea name based on field but fail to do so in the Input component.
How Has This Been Tested?
Manually
Types of changes:
Refactor
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 19.707% when pulling ae6c540cdc785056acbbd55818f33057b938d61a on mrfelton:fix/input-name into 7aad1269799edd4366840c8691d3ba664f1888c2 on LN-Zap:next.


Feat/pg name support

The goal of this PR is to extend support for the Postgres name type requested within the issue: https://github.com/sfu-db/connector-x/issues/501. This issue centers around connectorx panicking when interacting with tables containing a name type.
To solve this, I added:
a Name type in the various enums in connectorx/src/sources/postgres/typesystem.rs
a mapping between Name and LargeUtf8 in connectorx/src/transports/postgres_arrow2.rs
added NAME data to scripts/postgres.sql
added a test for NAME compatibility with postgres/polars in connectorx/tests/test_polars.rs

@wangxiaoying hope you're well! Would you mind taking a look at this when you have a chance? Thanks!

Hi @Jordan-M-Young , thanks for the PR. It looks good to me for arrow2/polars.
Could you also add this support for arrow and pandas, basically the transport mapping in connectorx/src/transports/postgres_arrow.rs and connectorx-python/src/pandas/transports/postgres.rs, as well their corresponding tests? (Looks like #475 is using pandas for the result type)
After this we can merge this. Thanks!

Any idea when this will get merged? 😄

Any idea when this will get merged? 😄

Hey @MatsMoll, Things have been busy with my job lately but I should have some time this weekend to finish up the PR!

Hey @wangxiaoying I think my latest commit satisfies your requests above. If so would you mind merging?

Thanks @Jordan-M-Young !

@wangxiaoying Thank you as always! @MatsMoll shouldn't be long before this is released!

Thank you for merging this! Appreciate it @Jordan-M-Young @wangxiaoying


Wyldwood

Added everything for the Wyldwood story.
Changed regex in checks because it wasn't splitting the readme and just skipped all checks. (The .+ wasn't including the carriage return.)
Missing Chinese names for 2 tracks.

Thanks for noticing that the check doesn't handle DOS format. I'll add the names after solving the Wyldwood story.


QA : Add formatter and linter

Need a workflow that ensures every contributor should follow the PEP-8 style guide for python code.
We can use flake8 for linting and Black for formatting source code.
Also this workflow runs on every PR which ensures the code follows  PEP-8 standard or not.

@maneprajakta  @Praful932  I would like to work on this

@Aryamanz29 we already have a workflow for the project. We did not need these additions to it.


[8.x] Add DatabaseRefreshed event to be emitted after database refreshed

This PR adds a new DatabaseRefreshed event that is emitted after either php artisan migrate:fresh or php artisan migrate:refresh is run.
Being able to listen to this event will allow developers to perform secondary actions to their local environment after refreshing, for example clearing stale or invalid cookies or redefining environment variables related to obsolete data.

This is technically a breaking change, if anyone is extending those commands, since now their calls to the parent constructor will be broken.

Doesn't laravel support injecting dependencies as params to handle? That would be a good way around the constructor changes.

@GrahamCampbell Ya that may be an alternative. I was trying to stick to the pattern the other Database events were using.

Right, ok. Don't make any changes. We can wait for Taylor to review this on Monday.

It would be a breaking change even if the dependencies are injected into handle rather than __construct.

@paras-malhotra thats a good point

To make this not breaking you probably need to service locate the dispatcher out of the container. The container is already available to commands as $this->laravel... $this->laravel[Dispatcher::class].

The illuminate/events package will need to be added as a dependency in composer.json of the database component.

@taylorotwell Updated to use the container.

@driesvints Looks like there's a "suggest" in there for that already: https://github.com/illuminate/database/blob/master/composer.json#L41

@hotmeteor perfect 👍


feature/file-view-urls

Purpose

Adds source_url to the extra field of the file metadata.
Addresses #2926
Addons:
[X] GitHub: file external view link built from current metadata
[X] Google Drive: file external view link retrived from Google Drive API
[X] Figshare: file external view link built from current metadata
[X] Dropbox: file share link generate from Dropbox API
[X] Box: file share link generated from Box API
[X] S3: unsupported
[X] Dataverse: unsupported

@chrisseto Refactored source_url to view_url. Let me know if there are any other changes I should make. :octopus:

@caseyrollins Looks good to go, I'll do one last review today and then merge it :+1:


How can I let Fastlane know where to find my iOS and Android screenshots?

I'm generating screenshots using Detox framework for both iOS and Android. I'm trying to submit an app to iOS (first), I have placed the screenshots into the screenshots directory, however Fastlane won't find them (when running upload_to_app_store).
How can I let Fastlane know where to find my iOS and Android screenshots?

You will need to put them in the correct folder structure for the different languages. I recommend downloading them from an existing app, to see the right structure, if possible.


Add payment page

Don't know if your waiting on me for this Pull Request but went through the changes and tested it out and everything looks good on my end!


[AMBARI-25233] : Improve console message for DB consistency check fai…

…lure
What changes were proposed in this pull request?
Improvement in console message for Database consistency check failure with exception message
How was this patch tested?
This patch was tested manually
Backport to branch-2.7 from here

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5116/
Test PASSed.

Hi @virajjasani ,
I didnt understand whats the reason we should print the exception output in console. we can already see why the consistancy check failed looking at the logs.
also can you tell me any one scenario where this exception is thrown

@Akhilsnaik Yes we can check the logs to find the Exception stacktrace. However, this change is just to print the Exception message and not the stacktrace. Also, I encountered exception only when I tried changing runAllDBChecks() for some of our requirements some time back and hence, I realized if we have just message available in console, it might be sometimes more useful.
This is not a critical change but just to improve the readability of console error message.


[Feature Request] "Roll up" artist names to the first artist when there are multiple artists in the track name

Looking forward to v2 and zip support being added (I can help test this feature if you still need it), I have one more request if possible.  My CDG files are named as "artist_name1 (& artist_name2....) - track_name (notes) [vendor_name]", so when there are multiple artists who appear on the track KaraokeEternal lists each combination of names as a separate artist name in the library.  It would be nice to have the option to "roll up" the names so it only shows the tracks in the folder for artist_name1, but still displays the full artist list when you go into the folder.

Hi, sounds like maybe the bit of the artist in parentheses should instead appear as part of the song title? This may be achievable with a custom parser config. v2 has a very different approach to this, so if you're interested in testing, do drop by the #dev channel. Thanks


Fix DS race condition caused by latch removal

Removing the latch from CCActiveState caused a race condition because a Deactivate wasn't waiting for prior Activate calls to complete. Restored the latch. Signed-off-by: The MathWorks, Inc<EMAIL_ADDRESS>

Codecov Report

Merging #632 (06827be) into development (530fd3b) will decrease coverage by 0.34%.
The diff coverage is 73.23%.

@@               Coverage Diff               @@
##           development     #632      +/-   ##
===============================================
- Coverage        90.42%   90.08%   -0.35%
===============================================
  Files              248      228      -20
  Lines            13251    12291     -960
===============================================
- Hits             11982    11072     -910
+ Misses            1269     1219      -50

Impacted Files
Coverage Δ

...eServices/src/manager/states/CCRegisteredState.cpp
100.00% <ø> (+3.33%)
:arrow_up:

...veServices/src/manager/states/CCSatisfiedState.hpp
33.33% <0.00%> (-16.67%)
:arrow_down:

...src/manager/states/ComponentConfigurationState.hpp
100.00% <ø> (ø)

...ativeServices/src/manager/states/CCActiveState.cpp
79.31% <70.49%> (+1.53%)
:arrow_up:

...ervices/src/manager/ComponentConfigurationImpl.cpp
96.27% <100.00%> (-1.66%)
:arrow_down:

...ativeServices/src/manager/states/CCActiveState.hpp
100.00% <100.00%> (ø)

...eServices/src/manager/states/CCRegisteredState.hpp
100.00% <100.00%> (ø)

...veServices/src/manager/states/CCSatisfiedState.cpp
100.00% <100.00%> (ø)

...src/manager/states/CCUnsatisfiedReferenceState.hpp
92.85% <100.00%> (+4.62%)
:arrow_up:

util/include/cppmicroservices/util/BundleObjFile.h
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 116 more


PERF-#5573: Don't trigger axes computation in columnarize function

Signed-off-by: Anatoly Myachev<EMAIL_ADDRESS>
What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #5573
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

@dchigarev @YarShev let's merge it


Looking for a name for a cvar to make system-specific workarounds disableable

We already have one workaround for buggy nvidia driver (see #63), but it would be useful to be able to disable the workaround to check if the bug still occurs or on which hardware/software combination it occurs.
I would like to see other workaround implemented, like:

forcing r_picmip 1 for systems having 2GB or less of RAM. I verified Dæmon running on a system with 2GB of ram (even running the lightweight IceWM desktop on Linux) cannot load plat23 map with full size textures without being killed by the OS to recover from an Out Of Memory error;

forcing r_picmip 1 for systems having less than 512MB of VRAM, I verified systems having 256MB or 384MB of VRAM cannot load plat23 map with full size textures without hanging the whole computer (on Linux).

There may bee other workarounds to implement to make sure players do not end with a game being silently killed by the OS or the hardware going mad in situation we now well know.
But I'm not really happy with the idea of not being able to disable those workarounds, I want to be able to check in the future if a given workaround is still legit or not. A cvar would be very good for such purpose. The idea would be to have a boolean cvar being enabled by default (disabling the cvar would disable the workarounds).
I'm lacking imagination right now, so if you have an idea, please make suggestions!

I say « hardware specific » at first, but the same cvar would cover system specific bugs in general, like the nvidia driver one.

How about useHardwareWorkarounds. Yeah OK an Nvidia driver technically isn't hardware, but close enough.

What prefix to use? and why some cvars use dot.naming.scheme and others use a_prefixedName?

The dot scheme is a new one introduced in Daemon, but of course most of the old ones were never migrated... not convinced it's better as the dot naming is usually longer to type.
Use r_ prefix I guess since all hardware workarounds are related to renderer AFAIK.

something like r_ignore...
r_ignoreMemLimitation
r_ignoreNvidiaFix

Done in #1224.


Updated docs

Looks good to me, thanks.

Those were just comments, you didn't make the changes. I'll just merge this and make the changes on top.


bug: can't handle aggregates within other value operations

What happened?
We're handling certain aggregate functions incorrectly.
If the aggregate is within a separate ValueOp, like the below somecol.sum() / sumcol.sum() then we hit
TypeError: Parameter to MergeFrom() must be instance of same class: expected substrait.ibis.Expression got substrait.ibis.AggregateFunction.

because we're recursing down into the expression, but the AggregateRel needs to be handled outside of the current expression (i'm not exactly sure how at this point)
Here's a failing test case:
def test_value_op_aggregate(compiler):
    t = ibis.table([("a", "float"), ("b", "int32")], name="t")
    expr = t.aggregate(mkt_share=t.a.sum() / t.b.sum())

    result = translate(expr, compiler)

    assert result

What version of ibis-substrait are you using?
2.21.0
What substrait consumer(s) are you using, if any?
No response
Relevant log output
No response

The first part of this to handle is the Value dispatch when either/both of left and right are a reduction e.g. t.a.sum() / 2 or t.a.sum() / t.b.sum()
The topological sort of:
    t = ibis.table([("a", "float"), ("b", "int32")], name="t")
    expr = t.aggregate(mkt_share=t.a.sum() / 2 )

will be something like
table -> literal  ->  col  -> sum  -> divide  ->  alias  ->  aggregate
but we currently fail at divide because we are treating the sum as an input to a "regular" scalar function.
We instead want to translate that into (roughly):
    # The Literal -> Col -> Sum -> Divide should resolve to:
    # project:
    #   common:
    #     emit: ...
    #   input:
    #     aggregate:
    #        input: table
    #        measures: sum
    #   expressions:
    #     scalarFunction:
    #     arguments:
    #       value:
    #         selection:
    #           directReference:
    #             structField
    #               ...
    #       value:
    #         literal:
    #           ...


Dropdown (v2): Swallows space keys after it's been opened

Detailed description

Describe in detail the issue you're having.

I have a dropdown with an item template which adds a search box in the items list. The issue is that when I type something in the search box it gets through the Dropdown.onKeyDown() method first which swallows the spaces.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

Dropdown

What did you expect to happen? What happened instead? What would you like to see changed?

I expect the component to handle spaces only when it needs to open the menu and leave them to propagate otherwise.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

2.45.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM ADDI

Strange, the Dropdown component already only processes spaces if the dropdown is closed and, as far as I can tell, it never explicitly stops propagation (though it does preventDefault, but again, only when the dropdown is closed).
The base dropdown list does have some extra handling for spacebar keydowns on items, but I see that you're using a custom list so that likely doesn't apply.

If the search box is in the list, it also shouldn't hit the Dropdown keydown handler first, since it would have to bubble from the search input ...
A minimal repro would really help debug this one.

Actually I use the default dropdown-list with an item template. Here's a minimal version of what I'm doing and the issue is still there:
https://codesandbox.io/embed/carbon-components-angular-d5xuv

Oh weird ... I also just noticed the dropdown list does a strange double guard ... So this definitely needs some more investigation. I'll have to check what the a11y interaction patterns are, if we don't need to handle space for that we should be fine with just enter ...
As for space triggering a scroll (the usual reason for a preventDefault on space) ...  if we let it bubble to the actual scrolling container we should be able to stop it there, without swallowing it.
Also, I wouldn't rule out extending dropdown-list and applying your customizations to that, depending on what interactions you need to support.

@zvonimirfras what about the v2 branch?

@stanislavgeorgiev We don't automatically backport everything. @youda97 can do it if you need it. 👍

Yes, I need it please. If something is filed against the v2 branch then I'd imagine that's where the fix should land in first as it's a support issue.

Yes, that would make sense...
@youda97 please backport this fix to v2 :)

Thank you :)

done!


Flaky unit test

Describe the bug
Over the past couple of days I've seen frequent failures of this test:
❌ test/enroll_verb_test.dart: A group of tests related to enrollment request expiry A test to verify expired enrollment cannot be approved (failed)
  INFO|2024-02-14 09:49:51.858219|HiveBase|commit_log_5a1fff547b9dafdc95c1938a41e8951bded8a595db3a50ddf0183a67a8a05f6a initialized successfully

  INFO|2024-02-14 09:49:51.859931|HiveBase|5a1fff547b9dafdc95c1938a41e8951bded8a595db3a50ddf0183a67a8a05f6a initialized successfully

  Expected: <true>
    Actual: <false>

  package:matcher                   expect
  test/enroll_verb_test.dart 540:7  main.<fn>.<fn>
SEVERE|2024-02-14 09:49:51.908130|NotificationUtil|exception while storing notification : LateInitializationError: Field '_boxName@833204826' has not been initialized.

Steps to reproduce

First I create a PR
Then automated tests run
And then far too frequently the unit tests are failing

Expected behavior
Unit tests are a reliable indicator of whether new code is good.

This issue has been fixed as part of the commit


Landscape Videos Rotated

It seems all videos that are taken "live" from the library come out in portrait orientation. If a video is taken landscape, it is rotated and sideways for editing and output.

I've solved this issue by adding the following in YPVideoHelper
    func currentVideoOrientation() -> AVCaptureVideoOrientation {
        var orientation: AVCaptureVideoOrientation

        switch UIDevice.current.orientation {
        case .portrait:
            orientation = AVCaptureVideoOrientation.portrait
        case .landscapeRight:
            orientation = AVCaptureVideoOrientation.landscapeLeft
        case .portraitUpsideDown:
            orientation = AVCaptureVideoOrientation.portraitUpsideDown
        default:
            orientation = AVCaptureVideoOrientation.landscapeRight
        }

        return orientation
    }

Add the connection bit.
public func startRecording() {
        let outputPath = "\(NSTemporaryDirectory())output.mov"
        let outputURL = URL(fileURLWithPath: outputPath)
        let fileManager = FileManager.default
        if fileManager.fileExists(atPath: outputPath) {
            do {
                try fileManager.removeItem(atPath: outputPath)
            } catch {
                return
            }
        }

        let connection = videoOutput.connection(with: AVMediaType.video)
        if (connection?.isVideoOrientationSupported)! {
            connection?.videoOrientation = currentVideoOrientation()
        }

        videoOutput.startRecording(to: outputURL, recordingDelegate: self)
    }

    public func stopRecording() {
        videoOutput.stopRecording()
    }

@Appswage  Your fix is in the pipe here: https://github.com/Yummypets/YPImagePicker/pull/163
I want to say your help as been very precious lately.
And as a maintainer, you gotta love the issues that come with a working fix 👍
Feel free to create Pull requests in the future 🎉
Have an awesome day !

@Appswage This is live as of 3.3.0 :) https://github.com/Yummypets/YPImagePicker/releases/tag/3.3.0

@s4cha - Awesome, thanks for being so responsive!

@s4cha - I need to make an update to the above code. I found that if the phone is portrait locked from settings, the video would not be properly oriented if taken in landscape mode. I'd suggest replacing my orientation function with this one which can still detect orientation when portrait locked.  This uses CoreMotion which of course needs to be imported at the top of class. Also add a property called motionManager of type CMMotionManager.
private func checkOrientation(completion: @escaping(_ orientation:AVCaptureVideoOrientation?)->())
 {
     self.motionManager = CMMotionManager()
     self.motionManager.accelerometerUpdateInterval = 0.2

     self.motionManager.startAccelerometerUpdates( to: OperationQueue() ) { data, _ in
         guard data != nil else {completion(nil);return}
         let data = data!

         let orientation = abs(data.acceleration.y) < abs(data.acceleration.x)
             ?   data.acceleration.x > 0 ? AVCaptureVideoOrientation.landscapeLeft      :  AVCaptureVideoOrientation.landscapeRight
             :   data.acceleration.y > 0 ? AVCaptureVideoOrientation.portraitUpsideDown  :   AVCaptureVideoOrientation.portrait

         completion(orientation)
     }
 }

public func startRecording() {
        let outputPath = "\(NSTemporaryDirectory())output.mov"
        let outputURL = URL(fileURLWithPath: outputPath)
        let fileManager = FileManager.default
        if fileManager.fileExists(atPath: outputPath) {
            do {
                try fileManager.removeItem(atPath: outputPath)
            } catch {
                return
            }
        }

        checkOrientation { (orientation) in
            self.motionManager.stopAccelerometerUpdates()
            guard orientation != nil else {print("Orientation Error");return}
            let connection = self.videoOutput.connection(with: AVMediaType.video)
            if (connection?.isVideoOrientationSupported)! {
                connection?.videoOrientation = orientation!
                self.videoOutput.startRecording(to: outputURL, recordingDelegate: self)
            }
        }
    }

@Appswage Your update is on point 👌. This looks like a micro case, but still, nice catch!
I implemented it here with few amends and it works perfectly :
https://github.com/Yummypets/YPImagePicker/commit/bd28c7c068429e90b39f78c4108a38749005063c
This will probably be live later today.
PS: Excuse the delayed response, we won the soccer World Cup so I was away for a while 🇫🇷 🍻 :)
Totally unrelated, I think I saw your profile on the top iOS dev in upwork, congrats!! 👏  Have you used the picker on clients' apps? If so would you be willing to communicate their name in the App Store so we can build a list of Apps that use it ?
Cheers!

This should be ok in 3.4.0 https://github.com/Yummypets/YPImagePicker/releases/tag/3.4.0 :)

Closing this for now, don't hesitate to reopen if needed :)


bench | new-tracing: final minimal config

We need two runs for the final version of the minimal config of the new tracing system, before we can release.

Runs:

2022-08-23-12.42.base2.66e9.k51-5ep-360kTx-4000kU-1000kD-64kbs
2022-08-24-05.25.new-tracing.2301.k51-5ep-360kTx-4000kU-1000kD-64kbs


[bugfix] when all rows of table ar selected with select all, unselect…

…ing one not work. It remove select from all checkbox, but propagate list of selections with all, except this one selected

Why? There is inconsistency in code.

Thanks for the contribution! However, this piece of logic has already been updated many times in the past as really tricky to get right. I won't take the risk to introduce a breaking change given the low test coverage we have. At least, it would be great if you could contribue a failing test case so we can better iterate on the logic.

But in this moment the all elements in table can be unselected, and most of them is given to function onRowSelection as selected.

Sorry, I don't follow. Please provide a failing test case with that, we can move forward, a live reproduction example is less interesting but can help too.

If this information are still unclear could you gave me some tutorial?
I'm sorry. I'm new in JS so I'm not sure how to write test and I try to modify test form
src/Table/MultiSelectTable.spec.js
I can not reproduce exactly this error because I do not understand why accesing header checkbox is different than body checkboxes, but I reproduce some inconsistency in  code.
I add console log to see what happend.
I add function to onRowSelection and then compare results of emmited information and checkbox marking
in my opinion in filing test correct outputs should be [2,3] and [false, false, true, true]
But are [1] and [false, false, false, false]. The response [1] should indicate [false, false, true, false]
`
describe('all_mark_click_check', () => {
it('should select and unselect every checkboxes', () => {
  const rows = [
    'John Smith',
    'Randal White',
    'Christopher Nolan',
  ];

  const selected_rows = {val: 'none'};

  function checked_row(val) {
    selected_rows.val = val;
    console.log(val);
  }

  const wrapper = mountWithContext(
    <MultiSelectTable rows={rows} onRowSelection={checked_row} />
  );

  console.log(wrapper);

  wrapper.find('TableRow').at(1).find('TableRowColumn').at(0).simulate('click');

  assert.deepEqual(getCheckboxStates(wrapper),
    [false, true, false, false],
    'should take the action into account'
  );
  wrapper.find('TableRow').at(1).find('TableRowColumn').at(0).simulate('click');

  assert.deepEqual(selected_rows.val, []);
  assert.deepEqual(getCheckboxStates(wrapper),
    [false, false, false, false],
    'should take the action into account'
  );

  let input = wrapper.find('Checkbox').at(0).find('input');
  input.node.checked = !input.node.checked;
  input.simulate('change');

  assert.deepEqual(getCheckboxStates(wrapper),
    [true, true, true, true],
    'should check all the checkboxes'
  );

  //input = wrapper.find('Checkbox').at(1).find('input');
  //input.node.checked = !input.node.checked;
  //input.simulate('change');

  console.log("a", getCheckboxStates(wrapper));
  wrapper.find('TableRow').at(2).find('TableRowColumn').at(0).simulate('click');
  console.log("a", getCheckboxStates(wrapper));

  //wrapper.find('TableRow').at(1).find('TableRowColumn').at(0).simulate('click');

  assert.deepEqual(selected_rows.val, [1]);
  assert.deepEqual(getCheckboxStates(wrapper),
    [false, false, true, false],
    'should uncheck all the checkboxes'
  );

  wrapper.update();
  assert.deepEqual(getCheckboxStates(wrapper),
    [false, true, false, false],
    'should be invariant to update'
  );
});

});`


cp(v0.36.x): feat: invalidate SSM cache upon AMI deprecation (#7301)

Fixes #N/A
Description
Cherry-picks the changes from #7301
How was this change tested?
make test
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

124 of 153 (81.05%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 78.255%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/fake/ssmapi.go
26
27
96.3%

pkg/controllers/controllers.go
0
2
0.0%

pkg/providers/amifamily/ami.go
15
17
88.24%

pkg/apis/v1/ec2nodeclass.go
15
18
83.33%

pkg/operator/operator.go
0
5
0.0%

pkg/controllers/providers/ssm/invalidation/controller.go
34
40
85.0%

pkg/apis/v1/zz_generated.deepcopy.go
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.02%

Covered Lines:
5758

Relevant Lines:
7358

💛  - Coveralls


Update openblas pin

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seems like r-gsl must be rebuilt first


Create ECR repository for cloud-platform-cli

This is not needed anymore. Added DockerHub credentials "fixed"


NetworkCloud 2023-05-01 Update to kubernetesCluster and Agentpool

NetworkCloud 2023-05-01 Update to kubernetesCluster and Agentpool
This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.


remove advice to change system time

This is terrible advice, and should never have been posted in the first place.

Alas, it's been reverted already. Oh well, Manjaro's a laughingstock again.


Added implementation for issue #25002

Fixes #
Changed error message for get and set accessors having different types. Also adding a related span with further explanations.

You need to run the tests jake runtests-parallel and accept the baseline changes jake baseline-accept

Just FYI, please check the result. When I changed the code so that the result only displayed the getter the unit tests resulted in an error (expected 3 errors, but got 2).
Now the result looks like this and all tests are passing:
test_accessors.ts:2:9 - error TS2380: 'get' and 'set' accessor must have the same type 'number', but this 'get' accessor has the type 'string'.

2     set foo(value: string) { },
          ~~~

  test_accessors.ts:2:9
    2     set foo(value: string) { },
              ~~~
    The respective 'set' accessor has the type 'number'.

test_accessors.ts:3:9 - error TS2380: 'get' and 'set' accessor must have the same type 'string', but this 'get' accessor has the type 'number'.

3     get foo(): number { return 100; }
          ~~~

  test_accessors.ts:3:9
    3     get foo(): number { return 100; }
              ~~~
    The respective 'set' accessor has the type 'string'.

The statement about the 'set' accessor in the first line is wrong. How to proceed?

@DanielRosenwasser can you please review the error message changes..

I removed the newlines, what's next?

@bashdx if you can get the conflicts resolved and the CI green, I think we can merge this

Closing due to lack of activity and outstanding merge conflicts/CI failures.
If anyone's looking at picking this up again, please refer to comments here and on the issue before proceeding - it's not super clear what the best error experience is and it'd be good to establish what a positive outcome looks like first.


Duplicate declaration: Package[wget] is already declared

HI,
I have wget already define in a base common class that is applied to all servers, so when doing "class { 'scaleio::sds_server': }" one gets:
scaleio::sds_server: Duplicate declaration: Package[wget] is already declared
Should such a common base package really be defined as a dependency? I understand why one does it, but unfortunately puppet does not allow several packages to have the same dependency.
(testing on Ubuntu 16.04 from master)

Hi,
The 'wget' package is needed for downloading packages for installation.
And I found that some CentOS systems don't have it by default.
It's strange that only 'wget' package raises an error - it is not only one in the common Package list.

Yes. I did a grep of common puppet modules I use ..

puppetlabs-apt, for example uses wget but does not declare it as a dependency.
Sonar uses whet but includes https://github.com/maestrodev/puppet-wget which provides a puppet interfaces to wget and coudl presumably be included in several packages.

I wonder what the best practise is for avoiding dependency redeclaration errors in puppet?
Perhaps the idea here_ http://stackoverflow.com/questions/26205727/duplicate-declaration-of-same-resource-defined-in-separate-classes#26215336 is a solution,
or just
    package { 'wget': ensure => installed }
}```

Yeah, I found a similar answer - http://stackoverflow.com/questions/15266347/puppet-test-if-a-package-already-defined

I fix this issue in last commit.
Please recheck.

I pulled master, but don't see a fix.

https://github.com/codedellemc/puppet-scaleio/commit/c1327925e52480051a2cb2dc4a0ea414c754976b

Ok, yes I have that in master, but I had been looking for something like "! defined"
Where is ensure_resource defined, because it does not work as expected for me. I still get
Duplicate declaration: Package[wget] is already declared in file /mymodule/manifests/init.pp:110; cannot redeclare at /etc/puppet/environments/production/modules/scaleio/manifests/common_server.pp:12
Ah, it is in puppetlabs-stdlib. It would be useful to explain your fix :-)
So a fix of the fix: if "ensure_resource('package', ['libaio', 'numactl', 'wget'], {'ensure' => 'installed'})" is replaced with "ensure_packages(['libaio', 'numactl', 'wget'], {'ensure' => 'present'})" it works fine (for me).

Is all ok now? :)

there are no changes on master
git log -1
commit c1327925e52480051a2cb2dc4a0ea414c754976b
...
Date:   Fri Nov 18 12:17:29 2016 +0300
use ensure_resource for common resources

This commit changes behavior in 'wget' definition with ensure_resource.
I meant that it should fix your error with re-definition.

It does not, see 4 messages higher. I had expected that you commit another fix this morning, e.g. with ensure_packages

hm, but can you check why ensure_resource doesn't work?


Added React propTypes for mobx containers

The following proptypes have been added:

observableArray
observableMap
observableObject
arrayOrObsArray
objectOrObsObject

Sorry for not finding the time to merge this yet (and making the PR conflict), but awesome idea! Some unit tests and documentation and this is ready to go.


unsupported gpu architecture 'compute_89'

E:\ProgramData\anaconda3\envs\py39sgmse\python.exe E:\000\sgmse-main\train.py --base_dir E:/000/sgmse-main/Data_Librispeech
Set TORCH_CUDA_ARCH_LIST to: 8.9
Traceback (most recent call last):
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\utils\cpp_extension.py", line 2107, in _run_ninja_build
subprocess.run(
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\subprocess.py", line 528, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "E:\000\sgmse-main\train.py", line 14, in
from sgmse.backbones.shared import BackboneRegistry
File "E:\000\sgmse-main\sgmse\backbones_init_.py", line 2, in
from .ncsnpp import NCSNpp
File "E:\000\sgmse-main\sgmse\backbones\ncsnpp.py", line 18, in
from .ncsnpp_utils import layers, layerspp, normalization
File "E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\layerspp.py", line 20, in
from . import up_or_down_sampling
File "E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\up_or_down_sampling.py", line 10, in
from .op import upfirdn2d
File "E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\op_init_.py", line 1, in
from .upfirdn2d import upfirdn2d
File "E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\op\upfirdn2d.py", line 12, in
upfirdn2d_op = load(
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\utils\cpp_extension.py", line 1309, in load
return jit_compile(
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\utils\cpp_extension.py", line 1719, in jit_compile
write_ninja_file_and_build_library(
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\utils\cpp_extension.py", line 1832, in write_ninja_file_and_build_library
run_ninja_build(
File "E:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\utils\cpp_extension.py", line 2123, in run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error building extension 'upfirdn2d': [1/2] C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\bin\nvcc --generate-dependencies-with-compile --dependency-output upfirdn2d_kernel.cuda.o.d -Xcudafe --diag_suppress=dll_interface_conflict_dllexport_assumed -Xcudafe --diag_suppress=dll_interface_conflict_none_assumed -Xcudafe --diag_suppress=field_without_dll_interface -Xcudafe --diag_suppress=base_class_has_different_dll_interface -Xcompiler /EHsc -Xcompiler /wd4068 -Xcompiler /wd4067 -Xcompiler /wd4624 -Xcompiler /wd4190 -Xcompiler /wd4018 -Xcompiler /wd4275 -Xcompiler /wd4267 -Xcompiler /wd4244 -Xcompiler /wd4251 -Xcompiler /wd4819 -Xcompiler /MD -DTORCH_EXTENSION_NAME=upfirdn2d -DTORCH_API_INCLUDE_EXTENSION_H -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\torch\csrc\api\include -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\TH -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\include" -IE:\ProgramData\anaconda3\envs\py39sgmse\Include -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS -D__CUDA_NO_HALF_CONVERSIONS -D__CUDA_NO_BFLOAT16_CONVERSIONS -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_89,code=sm_89 -std=c++17 -c E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\op\upfirdn2d_kernel.cu -o upfirdn2d_kernel.cuda.o
FAILED: upfirdn2d_kernel.cuda.o
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\bin\nvcc --generate-dependencies-with-compile --dependency-output upfirdn2d_kernel.cuda.o.d -Xcudafe --diag_suppress=dll_interface_conflict_dllexport_assumed -Xcudafe --diag_suppress=dll_interface_conflict_none_assumed -Xcudafe --diag_suppress=field_without_dll_interface -Xcudafe --diag_suppress=base_class_has_different_dll_interface -Xcompiler /EHsc -Xcompiler /wd4068 -Xcompiler /wd4067 -Xcompiler /wd4624 -Xcompiler /wd4190 -Xcompiler /wd4018 -Xcompiler /wd4275 -Xcompiler /wd4267 -Xcompiler /wd4244 -Xcompiler /wd4251 -Xcompiler /wd4819 -Xcompiler /MD -DTORCH_EXTENSION_NAME=upfirdn2d -DTORCH_API_INCLUDE_EXTENSION_H -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\torch\csrc\api\include -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\TH -IE:\ProgramData\anaconda3\envs\py39sgmse\lib\site-packages\torch\include\THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\include" -IE:\ProgramData\anaconda3\envs\py39sgmse\Include -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_89,code=sm_89 -std=c++17 -c E:\000\sgmse-main\sgmse\backbones\ncsnpp_utils\op\upfirdn2d_kernel.cu -o upfirdn2d_kernel.cuda.o
ninja: build stopped: subcommand failed.

Can you please try what ChatGPT suggests:
The error you're encountering seems to be related to building a CUDA extension, specifically the upfirdn2d kernel, using the Ninja build system. The error message indicates that the process failed when running the nvcc compiler. Here are a few steps you can take to try and resolve this issue:

CUDA Version Compatibility:
Ensure that the version of CUDA you are using (v12.1) is compatible with the version of PyTorch you have installed and the compute capability of your GPU.

Check CUDA and NVIDIA Driver:

Make sure your NVIDIA driver is up to date.
Verify that your CUDA toolkit is properly installed and the environment variables (e.g., CUDA_HOME, PATH, and LD_LIBRARY_PATH) are correctly set.

Reinstall PyTorch with CUDA support:
If there are compatibility issues, consider reinstalling PyTorch with the appropriate CUDA version. You can find the right command for your setup on the https://pytorch.org/get-started/locally/">PyTorch website.

Install Ninja:
Ensure that Ninja build system is installed and accessible in your PATH. You can install it via Conda:

sh
conda install -c conda-forge ninja

Compile Manually:
Sometimes building the extension manually can provide more diagnostic information. Navigate to the directory containing the upfirdn2d_kernel.cu file and run the nvcc command manually to see if there are more detailed errors.

Modify ARCH_LIST:
ARCH_LIST is set to 8.9 which corresponds to NVIDIA Ada GPUs like the RTX 40 series. If you're using a different GPU, ensure TORCH_CUDA_ARCH_LIST matches your GPU architecture. You can find the appropriate architecture version https://developer.nvidia.com/cuda-gpus">here.

Simplified Compilation Command:
Simplify your nvcc command to isolate issues. For example:

sh
nvcc -arch=sm_89 --expt-relaxed-constexpr -std=c++17 -c -o upfirdn2d_kernel.cuda.o upfirdn2d_kernel.cu

Permissions:
Ensure you have the necessary permissions to read/write in the directories you are working in.

Here's a basic checklist to follow:

Torch Installation: Ensure PyTorch is installed with CUDA support:

sh
conda install pytorch torchvision torchaudio cudatoolkit=12.1 -c pytorch

Verify GPU: Check if PyTorch can access your GPU:

python
import torch
print(torch.cuda.is_available())

Environment Variables:

sh
set TORCH_CUDA_ARCH_LIST=8.9

Ninja Installation: Ensure Ninja is installed:

sh
conda install ninja
Here's an example of checking the CUDA versions and toolchain:
sh
nvcc --version
Verify it matches the expected version and ensure your GPU driver is recent.
Please apply these steps and let me know if the issue persists!


Feature Request: Pull Feats, Traits, Items, and Class abilities from PF1e Content and PF1e Archetypes and Class abilities

Hey,
Great work with this module! Please keep up the hard work, it's really appreciated.
I'm one of the mod authors for the PF1e Content and PF1e Archetypes, I was wondering if it would be possible for your module to attempt to pull and use the items from ours? Obviously naming differs for some statblocks, so it might not be perfect, but PF1e Content has most of the named magic items, wondrous items, all feats and traits, and the Archetypes module has the vast majority of class abilities and archetype features.

Sure, thats possible right now via the custom compendiums one can enter in the sbc settings (pack names can be found via "game.packs").
SBC prioritizes custom compendia when searching for entities and stops when the first match is found. This could be problematic, as there seem to be some duplicates with differing content, at least from the first glance i took.
For example "Aboleth" is included twice in the class abilities, once as an oracle curse and once as an hunter animal focus. SBC has no way to know which one would be the correct one.
I'll test this when i find the time.

For some reason I am unable to get sbc to use the custom compendiums.
I have them entered according to the game.packs, but it isn't finding the items in them.
It was unable to find feats, and items.
With debugging on, I see that Items are being created with id undefined, not sure if that is related.

I'm also having issues getting SBC to recognise those compendia, and compendia of my own. I just tried to import an Evangelist to take advantage of the new prestige class update, and yet SBC is still both creating its own feats and classes despite having correctly configured the compendia to be used:
world.hans-magic-items, world.hans-class-abilities, world.hans-classes, world.hans-mythic-abilities, world.hans-feats, world.hans-common-buffs, world.hans-traits, world.hans-spells,  pf-content.feats,  pf-content.traits,  pf-content.artifacts, pf-content.magicitems, pf-content.wondrous, pf-content.pf-35-content, pf-content.pf-items, pf1e-archetypes.pf-archetypes, pf1e-archetypes.pf-class-abilities, pf1e-archetypes.pf-arch-features, pf1e-archetypes.pf-prestige-classes, pf1e-archetypes.pf-prestige-features
That's what I have in my SBC compendia-adding section, and it confirms they're all correct with no typos.
For an example statblock, try adding the compendia to SBC and then try importing this:
Female rakshasa-spawn tiefling evangelist 10/magus (eldritch archer, fiend flayer, hexcrafter) 4/wizard (spellslinger) 1
N Medium outsider (native)
Init +13; Senses darkvision 60 ft.; Perception +20
Defense
AC 32, touch 18, flat-footed 24 (+14 armor, +6 Dex, +2 dodge)
hp 167 (15 HD; 1d6+14d8+49)
Fort +15, Ref +21, Will +16
Resist cold 5, electricity 5, fire 5
Offense
Speed 30 ft. (20 ft. in armor)
Ranged +5 enhanced revolver +21/+21/+16 (3d4+16 force/×4)
Special Attacks arcane pool (+4, 14 points), hex arcana (distant spellstrike, reach spellstrike, slumber, spell blending [2 spells of lower level]), improved spell combat, spellstrike
Spell-Like Abilities (CL 15th; concentration +18)
   3/day—modify memory (DC 19)
   2/day—locate object
   1/day—imprisonment (DC 22)
Magus (Eldritch Archer, Fiend Flayer, Hexcrafter) Spells Prepared (CL 15th; concentration +23)
   5th—cosmic ray (DC 23), teleport
   4th—arcana theft, black tentacles, dimension door (3)
   3rd—battering blast (DC 21), displacement, fireball (DC 21), gloomblind bolts (DC 21), haste, lightning bolt (DC 21)
   2nd—acid arrow, glitterdust (DC 20), invisibility, kalistocrat's nightmare (DC 20), light prison (DC 20), mirror image, scorching ray
   1st—chill touch (2, DC 19), frostbite (2), grease, shocking grasp (2)
   0 (at will)—arcane mark, detect magic, mage hand, open/close (DC 18), prestidigitation
Wizard (Spellslinger) Spells Prepared (CL 1st; concentration +9)
   1st—invisibility alarm, true strike
   Opposition Schools Divination, Enchantment, Illusion, Necromancy
Statistics
Str 11, Dex 30, Con 16, Int 26, Wis 14, Cha 16
Base Atk +10; CMB +10; CMD 32
Feats Arcane Strike, Deadly Aim, Deific Obedience, Dimensional Agility, Dimensional Assault, Dimensional Dervish, Gunsmithing, Point-Blank Shot, Precise Shot, Rapid Shot, Spell Cartridges
Traits Magical Knack, Reactionary
Skills Acrobatics +13 (+9 to jump), Appraise +16, Bluff +21, Climb +2, Diplomacy +21, Disguise +8, Escape Artist +13, Fly +12, Heal +10, Intimidate +16, Knowledge (arcana) +16, Knowledge (dungeoneering) +13, Knowledge (engineering) +13, Knowledge (geography) +16, Knowledge (history) +21, Knowledge (local) +21, Knowledge (nature) +16, Knowledge (nobility) +26, Knowledge (planes) +26, Knowledge (religion) +14, Linguistics +21, Perception +20, Ride +12, Sense Motive +22, Spellcraft +26, Stealth +12, Survival +6, Swim +2; Racial Modifiers +2 Disguise, +2 Sense Motive
Languages Abyssal, Aquan, Auran, Celestial, Common, Daemonic, Draconic, Dwarven, Elven, Gnome, Goblin, Halfling, Ignan, Infernal, Nagaji, Orc, Samsaran, Sylvan, Tengu, Terran, Undercommon
SQ arcane gun, fighter training, heavy armor, hex (misfortune), hex arcana, hex magus, infernal mortification, knowledge of the lost, knowledge pool, mage bullets, pass for human, ranged spell combat, ranged spellstrike, ranged weapon bond, spiritual form
Combat Gear boots of escape, mirror of guarding reflections, noble's vigilant pillbox; Other Gear celestial plate armor (upgraded), +5 mithral buckler, +5 enhanced revolver, bag of holding i, belt of incredible dexterity +6, cloak of resistance +5, cracked dusty rose prism ioun stone, headband of vast intelligence +6, heavyload belt, necklace of adaptation, ring of arcane mastery, rod of abrupt hexes, magus starting spellbook, wizard starting spellbook, 26,150 gp, 1 cp
Special Abilities
Absolute Solitude (Sp) Once per day, you can cast imprisonment.
Arcane Gun (Su) Imbue two firearms with magic; cast spells thru the firearms.
Arcane Pool +4 (14/day) (Su) Infuse own power into a held weapon, granting enhancement bonus or selected item powers.
Arcane Strike As a swift action, add +1 damage, +1 per 5 caster levels and your weapons are treated as magic for the purpose of overcoming damage reduction.
Darkvision (60 feet) You can see in the dark (black and white only).
Deadly Aim -3/+6 Trade a penalty to ranged attacks for a bonus to ranged damage.
Deific Obedience Purify yourself daily to prove devotion to a deity and gain benefits.
Dimensional Agility May take any additional actions remaining after using dimension door or abundant step
Dimensional Assault May use dimension door or abundant step as part of a charge action
Dimensional Dervish During full-attack action, you may cast dimension door or use abundant step as a swift action
Distant Spellstrike (Su) Ranged spellstrike range increases to maximum range of weapon if greater.
Divination You must spend 2 slots to cast spells from the Divination school.
Enchantment You must spend 2 slots to cast spells from the Enchantment school.
Fighter Training (Ex) Add half your Magus level to your Fighter level for the purpose of feats.
Forgetfulness (Sp) 3/day, stnd action, alter creature's memory as modify memory; 2 uses for 1 hour, 3 uses for 1 day.
Gunsmithing You can use a gunsmithing kit to craft/repair firearms and ammo.
Heavy Armor (Ex) Heavy armor proficiency and no Arcane Failure chance in heavy armor.
Hex Arcana You can substitute Hexes for Magus Arcana.
Hex Magus (Su) You gain access to witch hexes.
Illusion You must spend 2 slots to cast spells from the Illusion school.
Improved Spell Combat (Ex) Use weapon in one hand at -2 & cast a spell with the other. Gain additional +2 circumstance bonus on concentration checks when using spell combat.
Infernal Mortification (Su) As a standard action, increase arcane pool by 1 pt per 2 Con dam (only time can heal).
Knowledge of the Lost (Sp) identify 3/day, locate object 2/day, or crushing despair 1/day
Knowledge Pool (Su) Spend Arcane Pool points to prepare a magus spell that is not in your spellbook for 1 day.
Mage Bullets (Su) Sacrifice a spell to grant an enhancement bonus or special ability to arcane gun.
Misfortune (2 rounds, DC 24) (Su) Foe in 30 ft must take the lower of 2d20 for rolls (Will neg).
Necromancy You must spend 2 slots to cast spells from the Necromancy school.
Pass for Human You can pass for human, and count as a humanoid (human) for all purposes.
Point-Blank Shot +1 to attack and damage rolls with ranged weapons at up to 30 feet.
Precise Shot You don't get -4 to hit when shooting or throwing into melee.
Ranged Spell Combat (Ex) Must use ranged weapon for spell combat.
Ranged Spellstrike (Su) As a full rd action, ranged spells can be combined with ranged attacks.
Ranged Weapon Bond (- custom / magic weapon -) (Ex) Must have bonded object to cast spells, doesn't interfere with somatic components.
Rapid Shot You get an extra attack with ranged weapons. Each attack is at -2.
Reach Spellstrike (Su) Touch spells increase range to close with ranged spellstrike ability.
Slumber (13 rounds, DC 24) (Su) Foe in 30 ft falls asleep for duration, or until damaged or roused by ally (Will neg).
Spell Cartridges With Arcane Strike, you may fire force bullets dealing 1d4 force dam per 5 CL.
Spellstrike (Su) Deliver touch spells as part of a melee attack.
Spiritual Form (Dexterity, Wings, 10 minutes/day) As a standard action, gain telepathy, stat boost, and ability of choice.```

Hanhula, as prestige classes aren't very well supported by the current system, and these are the first pack of them that I am aware of, it's likely sbc hasn't included support for them yet, which is understandable.
However, it would be great for the feats, abilities, and all the items that were in the latest pf-content update to be usable on import.

Far as I'm aware - and Primer's welcome to correct - the custom compendia's meant to just pull in any custom class!

Far as I'm aware - and Primer's welcome to correct - the custom compendia's meant to just pull in any custom class!

Yeah, that is the intention, but it seems it's not implemented all too well :)
I've found multiple issues with that, and one is that prestige classes in specific have an override right now. I'll take a look how i can fix that so this just is used when no entry could be found anywhere.

https://user-images.githubusercontent.com/14833806/115989628-93169780-a5bf-11eb-87d2-e5a2be20de9a.mp4
Prestige Classes can now be parsed from custom compendia in v3.1.1, which should be online tomorrow or so.
Caveats are, that SBC does not support class associations, so if the feature is not listed in the statblock, it will not get parsed.
If the prestige class can't be found in any compendia it will generate a placeholder as before.
I would be happy if you could try this again when its online.

v3.1.1 is now online

Now this is interesting.
Using these as imports:
world.hans-magic-items, world.hans-class-abilities, world.hans-classes, world.hans-mythic-abilities, world.hans-feats, world.hans-common-buffs, world.hans-traits, world.hans-spells, pf-content.pf-feats,  pf-content.pf-traits, pf-content.pf-racial-traits, pf-content.pf-artifacts, pf-content.pf-magicitems, pf-content.pf-wondrous, pf-content.pf-35-content, pf-content.pf-goods-services, pf-content.pf-items, pf-content.pf-special-qualities, pf-content.mythic-adventures, pf-content.horror-adventures, pf1e-archetypes.pf-archetypes, pf1e-archetypes.pf-class-abilities, pf1e-archetypes.pf-arch-features, pf1e-archetypes.pf-prestige-classes, pf1e-archetypes.pf-prestige-features
My above statblock doesn't import Evangelist properly like yours does; it generates a placeholder, but one with an icon.

This was consistent when I tested a few others that had prestige classes as well. Looks like archetypes are being handled properly, but not prestiges.

I can reproduce that and have created a specific issue for that. Thanks for testing again!

Should be fixed in 3.1.2, which is up any minute now. Please feel free to test again.

Should be fixed in 3.1.2, which is up any minute now. Please feel free to test again.

Ah, you're gonna sigh at me. I'm not seeing a fix for #386, unfortunately -- the statblock I posted earlier still fails to grab Evangelist, and her feats don't correctly import as those in pf-content. I tested with all compendia selected and with my world-specific compendia removed.
Also just checked with only pf1e-archetypes.pf-prestige-classes - it works then! Compare: https://i.imgur.com/QVyNWwf.png However: adding pf-content.pf-feats doesn't break the import, but it also doesn't pull anything from the second compendium.

See separate issues: For the functionality i simply missed to remove extra spaces in the input compendia names. It should work in v3.1.3 now.
But, the conversion gets incredibly slow when using all compendia of pf1e-content and pf1e-archetypes


Fix bug introduced in #1788: Don't use the read-only count as local variable

The variable name count is always equivalent to v:count, which is a read-only variable and cannot be assigned to. This spawned a deluge of errors when I updated the plugin. Here's a fix.

Oh thanks.


Improve error message for too few examples provided

If you create a new skill (or modify any of the existing ones) and add less than 5 examples check fails with an error message like this:
$ ilab diff
compositional_skills/writing/freeform/poetry/haiku/qna.yaml
ERROR 2024-04-19 14:24:55,912 generate_data.py:636 Validation error in compositional_skills/writing/freeform/poetry/haiku/qna.yaml on .seed_examples: [ <parsed dict> ] is too short

It is not clear what is too short. It would be helpful to output "list is too short" or "too few examples, you need to provide a minimum of five.".

I improved this message in the taxonomy repo action:
https://github.com/instructlab/taxonomy/blob/c7e15430012d375a4a9a1c0dbf3925e0c68e11b6/.github/scripts/check-yaml.py#L204-L209
I just need to bring this over to the cli command.

Ah perfect, I was wondering where it's from.


Fix/token encoding issues

This should fix issue #38.
Also added changes for the flake8 build:

Added rule E501 to be ignored.
Removed unused import RequestContext.
Added space after comma to comply with PEP rules.

thanks!


Split dev dependencies into tests and docs

I think it may make sense to split off all tests dependencies into its own category now that we have a couple of them
Originally posted by @Averylamp in https://github.com/mosaicml/composer/pull/101#discussion_r761314099

Going to close this for now since I don't think we have a use case for installing dev dependencies separately from test dependencies?


Addition doesn't respect TIS-100's numerical limits

see: related Test cases as pull request
possible fixes:

fix Add operation (and probably Sub as well, not yet proven via test case)
put constraints or overflow mapping in Number

Merged unit tests and added constraints in Number's constructor.

wow, that was quick :-)


Consider excluding all non-project classes from instrumentation

At the moment, by default, the IntelliJ agent instruments all classes loaded into the JVM. In some cases, this causes the generation of an erroneous bytecode and a subsequent verification error (for example in #89).
In new versions of libraries, if the java compiler >= version 11 is used, then the agent will use ConDy and such an error will not happen.
However, for older versions, it is necessary to exclude problematic classes (for example,  android packages excluded implicitly).

Issue in Coverage Agent

The problem is unsolvable in Gradle, because due to inline functions, it is necessary to know the list of classes of all projects and distribute such a list to each of the projects - which violates the Gradle isolation principle.
In this case, each project will depend on all the others to correctly handle calls to inline functions.


WEBUI_MAX_ARG fix

Thank you for fixing the bug. That's actually fixing an overflow crash 👍
All lines are correct, except this one should back to original as Token is not related to call arguments, and it has already a bigger size.
while (token != NULL && token_num < WEBUI_MAX_ARG+1)

For next PRs we should start formatting code using Clang, I will start doing it too.


Update Nuget package to handle Superluminal API 3.0

Hello,
The last version of Superluminal expose an API version 3.0, it is not compatible with the current nuget package.
Regards,

I don't have time currently to work on this, but a PR is welcome, the change should be easy to handle.

I can prepare the PR.
I just wonder what is the good solution, is it okay to make the next version compatible with API 3.0 only?
It means nugget package would fail to load the 2.0 (as it is currently failing to load the 3.0)

Good question. It depends of the changes, I don't how different the API is compared to 2.0:

If the API is very similar or adding a few ones and that we can detect it and adapt to it, it might be better to support both.
Otherwise, we can mention in the readme that the latest version to support 2.0 would be e.g 1.1 and the next one 2.0 would support 3.0 (maybe I should start to use the same numbering to simplify the mapping 😅 )


QMK (Vial) source code pointing to wrong location

Hi @dcpedit
As mentioned, the QMK firmware source code is missing. If you can point me to correct location that would be great. :)

I think I found it, it was on different branch.
https://github.com/vial-kb/vial-qmk/compare/vial...dcpedit:vial-qmk:pillzmod
if that is the case, document (README.md) file need an update :)

Thanks for pointing that out. Readme updated


Add simple function to Run elements

Super simple change that somehow I forgot to add when in #220. This follows the same convention as Bold, LineBreak, etc.

Maybe we should name it Run.createText: string -> View<Run>?


Explorer - Paste clipboard image to file

Description of the new feature / enhancement
If an image is in the clipboard, add a context menu option when inside a folder to "paste clipboard image", which would create a png or jpg (configurable) and paste the file. Name would be "clipboard image 1" etc.
Scenario when this would be used?

Program does not allow saving image, can only copy.
or
Quicker to copy image rather than save to disk.

In either case the current method is to paste the image into a paint program and then save to file.
Supporting information
Explorer replacements such as Directory Opus provide this feature, and it is incredibly handy for moving images around quickly.

/dup https://github.com/microsoft/PowerToys/issues/3098


Typos in docs

Looks like --aad-client-app-id flag to the az openshoft create should be --add-client-app-id flag to the az openshift create

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a75ea4cd-7173-91e7-dbb6-f526337054b2
Version Independent ID: f44e7584-d625-9839-c9ec-e96b3d81ee2f
Content: Azure Active Directory integration for Azure Red Hat OpenShift
Content Source: articles/openshift/howto-aad-app-configuration.md
Service: openshift
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Fixed. Will go live this morning.
Thanks @shanemcd

#please-close


add upload banner to widget

also fix a bug where upload banner didn't show if at the time component was mounted we were already uploading.

I'm hitting an error when updating the storyshots:
Summary of all failing tests
 FAIL  stories/__tests__/Storyshots.test.js (17.715s)
  ● Storyshots › Menubar › Uploading

    TypeError: element.setAttribute is not a function

      at removeClass (node_modules/dom-helpers/class/removeClass.js:8:190)
      at node_modules/react-transition-group/CSSTransition.js:46:38
          at Array.forEach (<anonymous>)
      at removeClass (node_modules/react-transition-group/CSSTransition.js:45:48)
      at CSSTransition.removeClasses (node_modules/react-transition-group/CSSTransition.js:247:18)
      at Object.CSSTransition._this.onEnter (node_modules/react-transition-group/CSSTransition.js:168:13)
      at Transition.performEnter (node_modules/react-transition-group/Transition.js:265:16)
      at Transition.updateStatus (node_modules/react-transition-group/Transition.js:238:14)
      at Transition.componentDidUpdate (node_modules/react-transition-group/Transition.js:202:10)
      at commitLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6435:22)
      at commitAllLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7516:7)
      at HTMLUnknownElement.callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1881:14)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
      at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:157:21)
      at Object.invokeGuardedCallbackDev (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1919:16)
      at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1968:29)
      at commitRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:7655:7)
      at completeRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8624:34)
      at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8568:9)
      at performWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8499:7)
      at performSyncWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8471:3)
      at requestWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8371:5)
      at scheduleWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8248:11)
      at scheduleRootUpdate (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8713:3)
      at updateContainerAtExpirationTime (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8740:10)
      at updateContainer (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:8751:10)
      at create (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9221:5)
      at getRenderedTree (node_modules/@storybook/addon-storyshots/dist/react/renderTree.js:24:14)
      at node_modules/@storybook/addon-storyshots/dist/test-bodies.js:21:18
      at Object.<anonymous> (node_modules/@storybook/addon-storyshots/dist/index.js:121:20)

Any ideas? @keybase/react-hackers

This is ready!

Bump; Will deal with conflict after this is approved.


VTKVolume not working

https://pyviz-dev.github.io/panel/reference/panes/VTKVolume.html#gallery-vtkvolume :
ncaught Error: Model 'panel.models.vtk.VTKVolumePlot' does not exist. This could be due to a widget or a custom model not being registered before first usage.
    at Object.o.Models (VTKVolume.html:4718)
    at Function.e._instantiate_object (VTKVolume.html:4717)
    at Function.e._instantiate_references_json (VTKVolume.html:4717)
    at Function.e.from_json (VTKVolume.html:4717)
    at Object.t.embed_items_notebook (VTKVolume.html:5087)
    at embed_document (VTKVolume.html:2949)
    at VTKVolume.html:2959

Needs to be added to the index.ts in ./models.

I made a PR for this one


Custom PostgreSql port via DB_PORT environment variable

Context of Change
Some database providers allocate different port per client
Type of Change
New feature

Thanks for the contribution! Does it make sense to update the docker-compose.yml file as well?

i don't think we need to change docker-compose.yml because we use a postgre docker container with default port

If we're adding it to the config then we should also plug it into our DB interface in src/db/knex.ts I think

That will happen automatically.
const knexConfig = {
  client: 'pg',
  connection: config.database.connection,
  ...

i don't think we need to change docker-compose.yml because we use a postgre docker container with default port

Well, if you set the port using an ENV var that isn't 5432, then you wouldn't be able to connect to the Postgres Docker container, right?

@hbergren DB_PORT variable is not present in docker-compose.yml so I don't see how we can use a port different of 5432
If we execute docker-compose up command all should works fine even if a different DB_PORT value is set outside the docker-compose.yml

Hi @mouradski , thank you for your contribution.
As @hbergren mentioned, we can run the database container independently using npm run devDbUp.
So the change made in docker-compose.yml for the db service port mapping is necessary.
Nevertheless, there is no need to change the payid service by adding:
# Local DB_PORT environment variable is used if set (default 5432)
- DB_PORT='${DB_PORT:-5432}'

First, I think there is a small typo mistake, for me, it works by removing the quotes: - DB_PORT=${DB_PORT:-5432}
Second, the communication between the PayID and Postgres containers is made via the default bridge network created when we run npm run devEnvUp and this communication uses the internal port 5432.
Inside the container, Postgres will always start on port 5432 and we will probably never need to change that.
Here is an example of what happens if we change the DB_PORT inside the payid container:

So, to summarize, we need to remove the following two lines in the payid service and we should be good to go.
      # Local DB_PORT environment variable is used if set (default 5432)
      - DB_PORT='${DB_PORT:-5432}'

Please let me know if something is unclear.

@hbergren Thank you, it is I who apologize && thank you for your patience :)


MOT17 evaluation get error with no ground truth

When try to evaluation MOT17 dataset with d0d9561a51a1a02da3036835ba6c130225f3ded4, this error occur

--gt_type _val_half
gt_type _val_half
gt_files []
11:48:20 INFO - Found 0 groundtruths and 7 test files.
11:48:20 INFO - Available LAP solvers ['lapsolver', 'lap', 'scipy', 'munkres']
11:48:20 INFO - Default LAP solver 'lapsolver'
11:48:20 INFO - Loading files.
11:48:20 WARNING - No ground truth for MOT17-13-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-09-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-05-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-04-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-02-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-10-FRCNN, skipping.
11:48:20 WARNING - No ground truth for MOT17-11-FRCNN, skipping.
11:48:20 INFO - Running metrics
/home/dhk/.pyenv/versions/3.7.6/envs/.venv/lib/python3.7/site-packages/motmetrics/mot.py:243: FutureWarning: the 'labels' keyword is deprecated, use 'codes' instead
idx = pd.MultiIndex(levels=[[],[]], labels=[[],[]], names=['FrameId','Event'])
/home/dhk/.pyenv/versions/3.7.6/envs/.venv/lib/python3.7/site-packages/motmetrics/metrics.py:302: RuntimeWarning: invalid value encountered in long_scalars
return num_detections / num_objects
/home/dhk/.pyenv/versions/3.7.6/envs/.venv/lib/python3.7/site-packages/motmetrics/metrics.py:298: RuntimeWarning: invalid value encountered in long_scalars
return num_detections / (num_false_positives + num_detections)
/home/dhk/.pyenv/versions/3.7.6/envs/.venv/lib/python3.7/site-packages/motmetrics/metrics.py:294: RuntimeWarning: invalid value encountered in long_scalars
return 1. - (num_misses + num_switches + num_false_positives) / num_objects
/home/dhk/.pyenv/versions/3.7.6/envs/.venv/lib/python3.7/site-packages/motmetrics/metrics.py:290: RuntimeWarning: invalid value encountered in double_scalars
return df.noraw['D'].sum() / num_detections
Rcll Prcn GT   MT   PT   ML   FP   FN  IDs   FM MOTA MOTP num_objects
OVERALL nan% nan%  0 nan% nan% nan% nan% nan% nan% nan% nan%  nan           0
Traceback (most recent call last)
...
IndexError: arrays used as indices must be of integer (or boolean) type

This part is suspicious. https://github.com/xingyizhou/CenterTrack/blob/d0d9561a51a1a02da3036835ba6c130225f3ded4/src/lib/dataset/datasets/mot.py#L93-L96
There may be two solutions. First one is edit mot.py to match data folder structure, specifically, change trainval to train. Second one is change data folder modification script to match mot.py

Thank you for pointing it out! I have fixed it.


Adds new file custom-preload that is loaded in a different order than custom.js before the main.js script is executed

Adds new file custom-preload that is loaded in a different order than custom.js before the main.js script is executed.
Relying on the existing file custom.js has some limitation because it gets loaded after the main.js script is executed. That makes it hard to extend some behaviors like injecting security headers:
example:
      $.ajaxSetup({
        beforeSend: function (xhr) {
          xhr.setRequestHeader(
            "Authorization",
            `Bearer ${connectionDetails.password}`
          );
        },
      });

Here is a demo video demonstrating the new behavior:
https://user-images.githubusercontent.com/1140720/194337949-669faf59-e9f7-4888-9cc9-9be5317bf755.mp4

@lneves12 Thx for opening this. The first thought while reviewing this is about the name you have chosen custom which is a bit too generic I believe. Apart from that, I am trying to understand the issue you are addressing and how you solved it could you expland a bit more. I get your point around loading order, but would need more background and details if possible. Thx again!

Thanks for the quick reply @echarles
I am not sure I understood the custom name comment. I don't think we have the control to change that, because that's the name of the module registered on page.html:
     // error-catching custom.js shim.
      define("custom", function (require, exports, module) {
          try {
              var custom = require('custom/custom');
              console.debug('loaded custom.js');
              return custom;
          } catch (e) {
              console.error("error loading custom.js", e);
              return {};
          }
      })

I am not an expert in require.js though.
To fix this I kinda got inspired on this old PR: https://github.com/jupyter/notebook/pull/1732/files
That PR fixes the same issue on jupter V4, but it seems it never got backported to master.
More about the use case:
In order to use the iframe we need to extend some of the behavior. One of the examples (there are more thing) is to inject a couple of security headers. The problem is that the current custom.js is executed after notebook.load_notebook(common_options.notebook_path);.
Therefore doing things like:
      $.ajaxSetup({
        beforeSend: function (xhr) {
          xhr.setRequestHeader(
            "Authorization",
            `Bearer ${connectionDetails.password}`
          );
        },
      });

will not work, because not all the requests will have the injected token.

Regarding the Linux JS Tests job failure, I am not sure yet what's going on, not sure if it's related.
All the tests are failing with Message:   ReferenceError: Can't find variable: $ so it seems unrelated.
I am trying to run the tests locally, but not luck yet

I am not sure I understood the custom name comment. I don't think we have the control to change that, because that's the name of the module registered on page.html:

You are right, thx for pointing to that content in the html page.

In order to use the iframe we need to extend some of the behavior. One of the examples (there are more thing) is to inject a couple of security headers. The problem is that the current custom.js is executed after notebook.load_notebook(common_options.notebook_path);.

Could it be that other cases do need custom.js to be run after the notebook loading?

Regarding the Linux JS Tests job failure, I am not sure yet what's going on, not sure if it's related. All the tests are failing with Message: ReferenceError: Can't find variable: $ so it seems unrelated.

The CI is not 100% green, but no test is failing with that error. I would say that it is related to these changes.

python3 -m nbclassic.jstest notebook is failing with /usr/bin/python3: No module named nbclassic

You can follow the needed steps to run the tests in

https://github.com/jupyter/nbclassic/blob/3196dc6f8e1be0748662bfef11d397326b7ef0ea/.github/workflows/selenium.yml
https://github.com/jupyter/nbclassic/blob/3196dc6f8e1be0748662bfef11d397326b7ef0ea/.github/workflows/js.yml

Could it be that other cases do need custom.js to be run after the notebook loading?
I would say no, in my opinion if there are cases like that they are probably badly written, because they can write code depending on jupyter triggered events (load, killed, etc).

btw this is how custom.js was being loaded in jupyter V4, it was just never backported to master. At least that's what i understood by reading the git history.   4.4.1 tag code: https://github.com/jupyter/notebook/blob/4.4.1/notebook/static/notebook/js/main.js#L27
The CI is not 100% green, but no test is failing with that error. I would say that it is related to these changes.

You can follow the needed steps to run the tests in

thanks, I will try again to make them run locally

I would say no, in my opinion if there are cases like that they are probably badly written, because they can write code depending on jupyter triggered events (load, killed, etc).

We have just discussed that during the community call and we came to a conclusion that it would be preferable to not merge such change to avoid the risk to break any existing extensions.

btw this is how custom.js was being loaded in jupyter V4, it was just never backported to master. At least that's what i understood by reading the git history. 4.4.1 tag code: https://github.com/jupyter/notebook/blob/4.4.1/notebook/static/notebook/js/main.js#L27

... we did not have that information while discussing during the community meeting. mmh would it be possible to hide that feature behind a flag on the command line. This will complexify quite a lot your PR, but it may be the safest way to move forward. WDYT?

@echarles done! just updated the PR with the new file solution. I also updated the description with a new demo video showing the new file behaviors.
Can you rerun the CI tests again? I don't seem to have permissions to do that.

Those seem to be failing as well in other PR: https://github.com/jupyter/nbclassic/actions/runs/3181760673/jobs/5186881765
There are 2 tests failing though in Selenium Tests only in Macos. I am still investigating why and how they can be related with my changes.
Could they be flaky ? Or my change made them being more flaky?
I will keep investigating, but any insight or help would be very welcoming! I am still very new to this project
Thanks!

Could they be flaky ? Or my change made them being more flaky?

Oh, maybe I have not looked correctly. Indeed, you just need to ensure that there are no regressions. We will work to make the CI 100% green, but for now we have some small failures that we know of. So if you could first double check that no regression is introduced, I can review.

@echarles could you try to rerun the tests? I rebased my branch.

Done

Some tests were failing, so I have rerun the failing ones. They still show issues which I think were not there before, like on https://github.com/jupyter/nbclassic/actions/runs/3206644310/jobs/5260741971, there is
Run python -m nbclassic.jstest notebook

Test group: notebook
Test file: /home/runner/work/nbclassic/nbclassic/nbclassic/tests/notebook/attachments.js
Timeout for http://localhost:8888/a@b/
Is the notebook server running?
FAIL ".CodeMirror-code" still did not exist in [1](https://github.com/jupyter/nbclassic/actions/runs/3206644310/jobs/5260741971#step:9:1)0000ms

@echarles I think I see the same errors happening in last master commit.
jstests -> https://github.com/jupyter/nbclassic/actions/runs/3207336103/jobs/5242111041
selenium -> https://github.com/jupyter/nbclassic/actions/runs/3207336100/jobs/5242110926
=========================== short test summary info ============================
FAILED nbclassic/tests/selenium/test_save_as_notebook.py::test_save_notebook_as
FAILED nbclassic/tests/selenium/test_save_readonly_as.py::test_save_readonly_notebook_as
============ 2 failed, 29 passed, 821 warnings in 312.27s (0:05:12) ============
let me know if I overlooked something

That's true. I'd like first to investigate what is wrong with the regression in main branch. How urgent is this for you?

@echarles it's a blocker for us, so it has some priority. However I guess you will not release a new version until the tests are green.
I would be surprise if this change breaks any test.
How can I help ? I can try to look at the js tests in master, but I haven't been able to run them locally yet, so it's a bit annoying to fix them. I will try again.
The selenium tests seem to be failing only in macos, not sure if I will be able to replicate them. (I have linux)

I am investigating https://github.com/jupyter/nbclassic/pull/156 which is I think the cause of the test regression.

thanks! @echarles
let me know if there is anything I can do to help
I don't mind helping fixing some of the tests and make the main branch green!

https://github.com/jupyter/nbclassic/pull/159 on its way to fix the test in main branch. Once merged, you can rebase your PR.
PS: Sometimes it will be completely green, sometiimes you may have a few failures like 525 passed, 2 failed.

@lneves12 https://github.com/jupyter/nbclassic/pull/159 is merged in master. Can you please rebase this PR?

@echarles nice!
My branch is rebased on top of latest master. You can retry the tests

@echarles thanks for all the help and quick replies!
yeah, that would be very helpful.
One question:  it seems only the notebook version > 6.5.X relies on nbclassic. Do you know if there is an official release of 6.5 happening soon?  or should we build our own docker images depending on the new release of nbclassic using the 6.5 branch? I am still new in the jupyter notebooks ecosystem, so any hint would be very helpful :)
We have been using the official docker hub images: https://hub.docker.com/u/jupyter

@lneves12 nbclassic 0.4.6 is just released with these changes.


Cannot find module angular2-emoji-picker/sheets

Cannot find module angular2-emoji-picker/sheets

Cannot find module angular2-emoji-picker/sheets

Use this instead https://www.npmjs.com/package/ngx-emoji-picker
What's New

Fixed the AOT (Ahead Of Time) Compile error or simply put the ---prod build compile error.
Upgraded the library from a Ng2 project to a Ng7 project.
Upgraded the library RxJs from v5 to v6 to make it support new angular versions.
Now compatible with Ng2 - Ng7 projects and as well as Ionic 3/4.


Update to fix odd IE8 bug with labels and inputs in Reportback fallback.

Fixes #3866
So as it turns out if an <input> sits inside of a <label>, then you don't need a for attribute on the label that allows you to click the label to select the input. It will naturally behave that way. You only need the for attribute to match the id of the input to allow this behavior if the <input> sits outside the <label>.
In modern browsers, if you happen to add a for attribute to the label and an input sits inside of it, it's not a big deal and should still behave the same way; click the label and it selects the input. However, IE8 apparent :hankey: the bed and needs to not have any for attribute in the label if the input sits inside the label.

We also had the same id on the <label> and <input> which was a boo boo, so that wasn't helping things.
Also removed some extraneous commas because my snazzy new IDE was getting mad at them.
@DoSomething/front-end

:boat: :boat: :boat:


Add support for custom animations with ion-slides

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[x] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
For my current project, I'm working with a ion-slides component. The interaction designers have decides that we should have a specific kind of animation for our onboarding slides component. (A combination of fading and panning). Ionic however only supports the standard Swiper.js animations.
Would it be possible to add the possibility to create custom animations for the ion-slides component?

Hello! Thank you for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#305


Particle Crash, I think?

Hello,
We recently added Garden Stuff to our mod pack and a user had an odd issue when braking a spruce log fence with a TCon hatchet.  Looking at the crash I am guessing it is a particle effect that caused it. Was wondering if you might be able to take a look and hopefully point me in the right direction.
Crash Log: http://pastebin.com/K24wt1jr
Issue where user posted: https://github.com/BevoTechPack/BevoTechPack/issues/476
I am not sure if the particles are from your side or TCons, so if I need to speak to them will be happy to do so (if those are the issue).

I think this was fixed a while ago.  If it's not, please re-open the issue.  Thanks.