app_sensors: only stream sensor data if connected

When using LTE, we may start fetching sensor readings before a connection is established with Golioth. Readings can be shown on a local display during this period, but attempting to send to Golioth will fail. This updates the sensor reading streaming, which is just a counter in this case, to only attempt to stream readings to Golioth when connected. This mirrors the behavior of the battery monitor.
(ref for rationale on not blocking until connected: https://github.com/golioth/reference-design-template/pull/72/files#r1489688622)

This was by design as the failure indicates that you do not yet have a connection to Golioth.
With this update, the app will show it is taking sensor readings, but they will not appear at the destination. Do you think an else clause that prints a message about skipping the  push until a connection is available would help with understanding the current state?

I do think it would be useful to have a message saying something like "No connection available, data not sent to Golioth". It's easy to miss the message that says a connection could take awhile and a recurring reminder that there is no connection is very helpful for new folks (and me!) troubleshooting their prototypes.
I'm  fine with updating the battery monitor too. It currently only works  on the aludel-mini which is deprecated so I don't think we need to do a lot of work there until we add aludel-elixir support for reading battery levels.

ack! updated -- example logging:
*** Booting My Application v2.4.0-1010dc0b83df ***
*** Using nRF Connect SDK v2.7.0-5cb85570ca43 ***
*** Using Zephyr OS v3.6.99-100befc70c74 ***
[00:00:00.640,380] <dbg> golioth_rd_template: main: Start Reference Design Template sample
[00:00:00.640,411] <inf> golioth_rd_template: Firmware version: 2.4.0
[00:00:00.647,033] <inf> golioth_rd_template: Modem firmware version: mfw_nrf9160_1.3.6
[00:00:00.647,064] <inf> golioth_rd_template: Connecting to LTE, this may take some time...
[00:00:00.693,054] <dbg> app_sensors: app_sensors_read_and_stream: No connection available, skipping streaming counter: 0
[00:01:00.693,115] <dbg> app_sensors: app_sensors_read_and_stream: No connection available, skipping streaming counter: 1
[00:01:59.535,980] <inf> lte_monitor: Network: Searching
[00:02:00.693,237] <dbg> app_sensors: app_sensors_read_and_stream: No connection available, skipping streaming counter: 2
[00:03:00.693,359] <dbg> app_sensors: app_sensors_read_and_stream: No connection available, skipping streaming counter: 3


Account page form Redesign

Related Issue
#1181 Account page form Redesign
Description
fix spelling flipkart name and FAQ section
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[ ] I have performed a self-review of my code
[ ] I have read and followed the Contribution Guidelines.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:
https://github.com/arghadipmanna101/Flipkart_Clone/assets/76507378/e53a163f-64c8-451f-96dc-c745df8380ab

please reveiw my pr


bring our photos back

merging without waiting for tests, since it's just assets and I'm very late for dinner. :)


Activate Maximal Swift Concurrency Checking

For support Swift 6 we have to activate the swift concurrency checking to maximal.

Does it actually build after the change? 😅


[question] Windows 10 x64 install - cannot connect to webpage

I ran the installation instructions for "Other Methods" and everything seemed to run but I'm getting the following warnings/messages and I'm assuming that is the reson that zwavejs2mqtt is not working.
How do I work around these so that I can get a working install?
$ yarn install
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0s 264ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 553ms
➤ YN0000: ┌ Link step
➤ YN0076: │ fsevents@patch:fsevents@npm%3A2.3.2#~builtin<compat/fsevents>::version=2.3.2&hash=18f3a7 The win32-x64 architecture is incompatible with this module, link skipped.
ncompatible with this module, link skipped.
➤ YN0007: │ core-js@npm:2.6.12 must be built because it never has been before or the last one failed
➤ YN0007: │ docsify@npm:4.12.2 must be built because it never has been before or the last one failed
➤ YN0007: │ core-js@npm:3.21.1 must be built because it never has been before or the last one failed
➤ YN0007: │ leveldown@npm:5.6.0 must be built because it never has been before or the last one failed
➤ YN0007: │ @serialport/bindings-cpp@npm:10.7.0 must be built because it never has been before or the last one failed
➤ YN0007: │ level@npm:5.0.1 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 18s 671ms
➤ YN0000: Done with warnings in 19s 740ms

it's not an error, it's just a warning you can ignore it


Locate the images which shap is not consistent with annotation file

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
Hi, all. I am facing a problem like this:
assert shape[i] >= img.shape[i]
AssertionError
Above all is the error report.  I use my own coco-like dataset to train a Mask-R-CNN model. These datasets can be used in Faseter-R-CNN, but in this model training, it raises the shape of some images in image files are not consistent with annotation file. In Question about pad_shape
#482, @hellock explained that it is due to :
This is most probable that the image shape in annotations is not the same as the actual shape of the loaded image. Some images may be taken by mobile devices and have different orientation. You may have a check.
I checked the code and ran the data impading, sometimes it can read 255 images while my whole images are 267, sometimes only several images can be loaded. There must be one or few images which has the shap problem, but how can I locate and clean them?
Reproduction

What command or script did you run?

A placeholder for the command.
```I am running model training:
%cd {project_name}
!python /home/bys2058/mmdetection/tools/train.py {config_fname}

2. Did you make any modifications on the code or config? Did you understand what you have modified?
I didn't modify anything except for the config file.
3. What dataset did you use?
Custom COCO
**Environment**

sys.platform: linux
Python: 3.7.6 (default, Jan  8 2020, 19:59:22) [GCC 7.3.0]
CUDA available: True
CUDA_HOME: /usr/local/cuda-10.0
NVCC: Cuda compilation tools, release 10.0, V10.0.130
GPU 0: GeForce RTX 2080 SUPER
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.2.0
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v0.18.1 (Git Hash 7de7e5d02bf687f971e7668963649728356e0c20)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CUDA Runtime 10.0
  - NVCC architecture flags: -gencode;arch=compute_35,code=sm_35;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_50,code=compute_50
  - CuDNN 7.6.2
  - Magma 2.5.0
  - Build settings: BLAS=MKL, BUILD_NAMEDTENSOR=OFF, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -fopenmp -DUSE_FBGEMM -DUSE_QNNPACK -O2 -fPIC -Wno-narrowing -Wall -Wextra -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Wno-stringop-overflow, DISABLE_NUMA=1, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=True, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.4.0a0+6b959ee
OpenCV: 4.2.0
MMCV: 0.4.0
MMDetection: 1.1.0+e03c96d
MMDetection Compiler: GCC 7.5
MMDetection CUDA Compiler: 10.0

**Error traceback**
If applicable, paste the error trackback here.

Traceback (most recent call last):
File "/home/bys2058/mmdetection/tools/train.py", line 142, in
main()
File "/home/bys2058/mmdetection/tools/train.py", line 138, in main
worker.py, r = index_queue.get(timeout=MP_STATUS_CHECK_INTERVAL) (120, [196])
self.prepare_train_img(idx): 196
{'id': 5427, 'dataset_id': 13, 'path': '/datasets/300spalling/spalling and exposed reinforcement17.jpg', 'width': 250, 'height': 167, 'file_name': 'spalling and exposed reinforcement17.jpg', 'filename': 'spalling and exposed reinforcement17.jpg'}
meta=meta)
File "/home/bys2058/mmdetection/mmdet/apis/train.py", line 111, in train_detector
ann_info, idx =  196
results['img_prefix'] /home/bys2058/mmdetection/data/coco/300crackspalling-1/
meta=meta)
File "/home/bys2058/mmdetection/mmdet/apis/train.py", line 235, in _non_dist_train
runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/runner.py", line 364, in run
epoch_runner(data_loaders[i], **kwargs)
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/runner.py", line 262, in train
for i, data_batch in enumerate(data_loader):
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 829, in next
return self._process_data(data)
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 859, in _process_data
data.reraise()
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/_utils.py", line 369, in reraise
raise self.exc_type(msg)
AssertionError: Caught AssertionError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 182, in _worker_loop
data = fetcher.fetch(index)
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/bys2058/mmdetection/mmdet/datasets/custom.py", line 136, in getitem
data = self.prepare_train_img(idx)
File "/home/bys2058/mmdetection/mmdet/datasets/custom.py", line 153, in prepare_train_img
return self.pipeline(results)
File "/home/bys2058/mmdetection/mmdet/datasets/pipelines/compose.py", line 24, in call
data = t(data)
File "/home/bys2058/mmdetection/mmdet/datasets/pipelines/transforms.py", line 326, in call
self._pad_masks(results)
File "/home/bys2058/mmdetection/mmdet/datasets/pipelines/transforms.py", line 311, in _pad_masks
for mask in results[key]
File "/home/bys2058/mmdetection/mmdet/datasets/pipelines/transforms.py", line 311, in
for mask in results[key]
File "/home/bys2058/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/image/geometry.py", line 200, in impad
assert shape[i] >= img.shape[i]
AssertionError
A placeholder for trackback.

**Bug fix**
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

You can just write a script to load your images and annotations, and compare the actual image shape with the shape in annotations.

Hi, all. I solved the problem.
There are two issues for my own dataset:

Some images are png instead of jpg or jpeg, so it is necessary to convert them to jpg by revising the json file.
There are few bad images which shape is inconsistent with annotation. Although I compared the original images with the annotation file, it cannot find the bad ones.

I did the following to locate them:
a) First, set shuffle = False (defaulted as True) in builder_loader.py, make sure batch-size = 1.
b) Then, in Runner.py, I added the following lines to track the index of last filed to be processed:
def train(self, data_loader, **kwargs):
for i, data_batch in enumerate(data_loader):    #### for data checking   ####
print("i", i)
The last i is the index of the image which can be processed, but i+1 is the one that cannot be input. Check its name in your whole dataset which was not shuffled, and then clean it.
c) Follow this step b) you can get the bad images out of my own datasets. Fortunately, I just had one bad image.


What should I do if the installation and release prompt timed out?

The docker version is Version: 2.1.0.

The version is too low. Use version 2.4.5. It is recommended to update to tarscloud/framework:v2.4.5.

版本太低了, 用2.4.5版本，建议更新至tarscloud/framework:v2.4.5。


Jf/header component

The component is called <Heading> but it's in a folder named Header. Should the folder name match?

@nathanyoung yup, I renamed it right before I pushed this draft and missed that change. I figured header might be confused with an application header so heading sounded better in the end.

@nathanyoung a follow-up comment on this. I'm feeling like there's a bit of a disconnect in terms of size options vs h levels. In most cases we can get away pretty easily with our custom sizes but in this particular case it seems a bit odd to have to remember that an h1 should be coupled with a size={'2xl'} or something like that.
Let's discuss tomorrow to see if perhaps we can alias some of our sizes into heading size variables that might make more sense for h elements.

I think we should have some default sizes based on the as prop so the consumer only has to type <Heading as="h1">Title</Heading> to automatically get the size we recommend.

@nathanyoung I've added additional webpack config objects so that we can import all our token variables and utilities globally. They are now available across the entire app so you can just use them either in jsx (utilities) or in custom scss files (variables). We should probably document all variables but for the time being if you run a build of palmetto-design-tokens locally you can see what variables and utilities we have available


Cleaned up summary

Small change that only prints errors if they occur, otherwise prints that all tests pass

/lgtm
Nice tweak :)


Unable to download the latest version of NodeCloud

Expected Behavior
Download the latest version of NodeCloud using npm or yarn
Actual Behavior
404 Not Found - GET https://registry.npmjs.org/@nodecloud%2Fcommon - Not found

@rajikaimal have you identified the reason for this issue?

Hi, I'm not actively maintaining this project. However, you can try this project locally with the following steps.
https://github.com/leopardslab/nodecloud#-development-setup


1319

Introduce a naming scheme that can be configured to generate names for Kubernetes objects based on user's choice.

I have made the changes to support multiple naming schemes. For now, we have 2: ClusterRole which is the new naming scheme and UID which is the old one. The default is set to the old one.
I have tried some of the scenarios which include:

Defining no defaultNamingScheme or /cluster namingScheme.
Defining just the defaultNamingScheme.
Defining defaultNamingScheme and overriding it with /cluster naming scheme.
Defining just /cluster naming scheme.
Various clusters having different naming schemes.

I have set the max name limit to 56 which can obviously be modified.
Also, tested cases where namingScheme exceeds this threshold or we pass the wrong scheme name.

I think this looks really good! A couple of minor comments above.
One general quibble: there are a lot of other unrelated commits in this branch, although it looks like most have been reverted. I'd rather have a clean merge of only related commits. Let me know how you want to handle this... one approach would be to make a new branch off of master and cherrypick the related commits into there.

I think this looks really good! A couple of minor comments above.
One general quibble: there are a lot of other unrelated commits in this branch, although it looks like most have been reverted. I'd rather have a clean merge of only related commits. Let me know how you want to handle this... one approach would be to make a new branch off of master and cherrypick the related commits into there.
(I can handle that branch cleanup if you would rather not.)

Umm, my local master branch was messed up with all the crd conversion changes that I was doing and I thought we were going to push those changes. I had to revert all of them on master. When I checked out my new branch off master, it brought along all those commits and some other changes that I hadn't reverted. Let me figure out a way to clean this up and stabilize my master branch and name scheme branch.


Choose between AspectFit and AspectFill

The app always uses AspectFill witch sometimes crops the image.
That would be great to choose  between aspectFit and aspectFill.
https://stackoverflow.com/questions/4895272/difference-between-uiviewcontentmodescaleaspectfit-and-uiviewcontentmodescaletof

Hey @PabloHenri91, thanks for this great idea. The feature is implemented in v2.5.0 👍


Siwe package

Breaking Changes
N/A
Changes

feat:

fix:

Removed unused SIWE code from Scaffold
Moved SIWE code to its own package -> Core/ui/Scaffold/Client
Remove ts-expect-error declarations in Wagmi package
SIWE types were being exported from @web3modal/core which is a sub-dependency, types were moved to the SIWE package

chore:

Associated Issues
closes #...

Thanks @Cali93 ! Haven't tested its bundle size yet, we'll see 👀


[PLC] [Evaluation] Removed the typed CEK machine

This removes the typed CEK machine as per the recent slack discussion.

Ok, I think this is good to go.


Statistics Graph Card Configuration - Entity not listed

Hi, I'm trying to add the temperature sensor to a statistics graph card but am running into a problem where I can't select the data source. HA has pointed me to this link: https://www.home-assistant.io/more-info/statistics/
Is it possible it can be configured to track statistics?

You have posted in the wrong repository. This is the BoM weather integration. Closing.

Hi, I'm aware this is the BoM weather integration repo, thats why I posted it here.
I'm trying to use the air temp sensor on a statistics card.
This sensor:


I update the list in the adapter, which is in the presenter. Bug or feature?

In the presenter, I create a list, receiving data from the interactor, load it into the view through the "setListAdapter" method to add it to the adapter. And so I can update the list in the presenter and pull the "notifyNoteItemList" method from view to update it in the adapter. Is this normal behavior or am I doing something wrong?)
NotesPresenter:
public class NotesPresenter extends MvpPresenter<NotesMvp.view> implements NotesMvp.presenter {

List<Note> noteList;
   ........

    @Override
    public void onCreateView() {
        noteList = interactor.getNoteList();
        Collections.reverse(noteList);
        getViewState().setListAdapter(noteList);
        checkEmptyList();
    }

    @Override
    public void onResultNoteEditor(int result) {
        if (result == RESULT_OK) {
            interactor.getNote(interactor.getCurrentNote(), dataList -> {
                int index = getNoteItemIndex(dataList.get(0).getNoteID());

                switch (interactor.getNoteState()) {
                    case STATE_CREATE:
                        noteList.addAll(dataList);
                        break;
                    case STATE_EDIT:
                        noteList.set(index, dataList.get(0));
                        break;
                    case STATE_DELETE:
                        noteList.remove(index);
                        break;
                }
            });
            getViewState().notifyNoteItemList();
            checkEmptyList();
        }
    }

    private int getNoteItemIndex(int noteID) {
        Log.d("lol", "find note: " + noteID);
        for (int i = 0; i < noteList.size(); i++) {
            Note note = noteList.get(i);
            if (note.getNoteID() == noteID) {
                return i;
            }
        }
        return -1;
    }
}

NotesFragment:
public class NotesFragment extends MvpAppCompatFragment implements NotesMvp.view {

........

    @Override
    public void setListAdapter(List<Note> noteList) {
        this.noteList = noteList;
        Log.d("lol", "LIST SIZE: " + this.noteList.size());
        adapterNote = new NoteAdapter(getActivity(), noteList, presenter);
        recyclerView.setAdapter(adapterNote);
    }

    @Override
    public void notifyNoteItemList() {
        adapterNote.notifyDataSetChanged();
    }

    @Override
    public void onResultNoteEditor(int result) {
        presenter.onResultNoteEditor(result);
    }
........
}

It is important for me to keep the list in the presenter in order to find the desired item or find out the size of the list. Maybe it needs to be done somehow differently.
I would be grateful for your help!

Not sure what you mean by "bug or feature", but if you're asking for some advice on showing a list, here's some.
You'd better avoid using Adapter in Presenter, it's an implementation detail of View and the View should be responsible for updating the adapter. Instead, just store a List in Presenter, and show it on view: viewState.showList(list). You'll have much more simple and testable Presenter. The implementation of View can be something like this:
override fun showList(list: List<MyItem>) {
    adapter.submitList(list)
}

notifyDataSetChanged should happen inside the adapter, you can also use some existing adapter like ListAdapter, or use DiffUtils manually.

I am storing the list list in a presenter and passing it to the view for the adapter. But the bottom line is that I can change the list in the presenter, give the command to the view to notify the adapter, and it will somehow make the changes that were in the list in the presenter. The only time it won't work is if I pass "getViewState.setListAdapter (new ArrayList <> (list))" to the view method. But if I pass the original list, the adapter will listen to it, although the list is in the presenter, although I update the adapter through the view.
I don't understand where the adapter has access to the list in the presenter, how does it catch changes in it? The presenter knows nothing about the adapter, it only passes the list to the view once.
I hope I was able to convey the problem)

Well, you said it yourself, if you pass the original list instance, the adapter will hold on to it. When you make changes in the list, Adapter can see it because you gave it the list. In other words, the list in the adapter and the list in your presenter are the same object, because you pass the same reference. Check out the adapter source code to understand what's happening under the hood.
It's a better practice to pass a copy of the list, this way you can do any changes to your internal list and update adapter only when you want.

Yes, I was already convinced of this)) I decided to continue making changes in the presenter list, there is always access to it, and in the view only notify the adapter about the changes.
I sincerely hope this will not be a clumsy solution to this problem.
Presenter methods:
    @Override
    public void onUpdateNewNotes(List<Note> noteAddedList) {
        for (Note note : noteAddedList) {
                   noteList.add(note);
        }
        getViewState().notifyAddNoteItems(noteAddedList);
    }

    @Override
    public void onUpdateChangeNotes(List<Note> noteChangedList) {
        for (Note note : noteChangedList) {
            noteList.set(note.getOrder(), note);
        }
        getViewState().notifyChangeNoteItems(noteChangedList);
    }

    @Override
    public void onUpdateRemoveNotes(List<Note> noteRemovedList) {
        for (Note note : noteRemovedList) {
             noteList.remove(note.getOrder());
        }
         getViewState().notifyRemoveNoteItems(noteRemovedList);
    }

View methods:
@Override
    public void notifyAddNoteItems(List<Note> noteAddedList) {
        for (Note note : noteAddedList) {
            adapterNote.notifyItemInserted(note.getOrder());
        }
    }

    @Override
    public void notifyChangeNoteItems(List<Note> noteChangedList) {
        for (Note note : noteChangedList) {
            adapterNote.notifyItemChanged(note.getOrder());
        }
    }

    @Override
    public void notifyRemoveNoteItems(List<Note> noteRemovedList) {
        for (Note note : noteRemovedList) {
            adapterNote.notifyItemRemoved(note.getOrder());
        }
    }

In any case, thank you! I thought there was a problem with Moxy, but it looks like I still have a lot to understand in Android.

Instead of writing all these methods manually you can just write single method showList(list) and let DiffUtil do all the work for you. It's better in terms of performance and you write much less code, try it out)

Already applied it in several places and it noticeably reduced my headache with the adapter. Please accept my thanks again!


Add link to patching article in patch API docs

[x] Code is up-to-date with current master
[x] Code is provided under the terms of the Tabris.js license

Thanks for the update. We have merged it into master.


Always display 'create' link for dashboard menu item

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6bafc3d). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage          ?   17.09%
  Complexity        ?      644
=========================================
  Files             ?       56
  Lines             ?     2217
  Branches          ?        0
=========================================
  Hits              ?      379
  Misses            ?     1838
  Partials          ?        0

Impacted Files
Coverage Δ
Complexity Δ

src/Event/Plugin/Menu/View/MenuListener.php
0% <0%> (ø)
60 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bafc3d...430bf38. Read the comment docs.


Error 260 - tmpstrings not found

Hello,
i am trying to use BartyCrouch, but i always get the error 260 while domain is NSCocoaErrorDomain.
I am using this command (all my subfolders like en.lproj with the Localizable.strings files are in the subfolder Localizable. And Beatsnap is the root folder where all code is structures (also subfolders here)
bartycrouch code -p Beatsnap/ -l Beatsnap/Localizable -a -v
and getting this response
Error Domain=NSCocoaErrorDomain Code=260 "The file “Localizable.strings” couldn’t be opened because there is no such file." UserInfo={NSFilePath=Beatsnap//tmpstrings/Localizable.strings, NSUnderlyingError=0x7f92a2600af0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Incrementally updated keys of file 'Beatsnap/Localizable/Base.lproj/Localizable.strings'.
Error Domain=NSCocoaErrorDomain Code=260 "The file “Localizable.strings” couldn’t be opened because there is no such file." UserInfo={NSFilePath=Beatsnap//tmpstrings/Localizable.strings, NSUnderlyingError=0x7f92a251ea10 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Incrementally updated keys of file 'Beatsnap/Localizable/de.lproj/Localizable.strings'.
Error Domain=NSCocoaErrorDomain Code=260 "The file “Localizable.strings” couldn’t be opened because there is no such file." UserInfo={NSFilePath=Beatsnap//tmpstrings/Localizable.strings, NSUnderlyingError=0x7f92a2700ec0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Incrementally updated keys of file 'Beatsnap/Localizable/en.lproj/Localizable.strings'.
BartyCrouch: Successfully updated strings file(s) of Code files.

And even though i added another NSLocalizedString and says "Successfully updated..." the file Beatsnap/Localizable/en.lproj/Localizable.strings is not changed

okay, will close it because its related to the "mm" file. Created another issue

I'm still seeing this error and I'm using 3.2.1. Any workarounds or hints on how to solve it?

@zbrox Can you give more information on your setup? The OPs issue was that his files ended on .mm and after adding support for .mm files himself this was solved for him. Do I understand you correctly that your project has .mm files and that the keys there aren't recognized?
Please provide:

the command you are running (build script content?)
the hierarchy with all relevant files (containing NSLocalizedString, .strings files)

Sorry for the scarce info. Yes, my project includes .mm files and I'm using the latest release available through cocoapods. When running bartycrouch code -p "/path/to/code/directory" -l "/directory/containing/all/Localizables" -a
I get a lot of Error Domain=NSCocoaErrorDomain Code=260 "The file “Localizable.strings” couldn’t be opened because there is no such file." UserInfo={NSFilePath=[path to code]/tmpstrings/Localizable.strings, NSUnderlyingError=0x7f9aa0f0a4a0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}
Then when I check the localizable files, they're empty.

I still can't help you without the hierarchy of the relevant files. Specifically it is important not to point directly to the en.lproj folders but instead to a folder that contains all of those. Also the path needs to be absolute, e.g. start it with "$PROJECT_DIR/path/to/localizables".
Also note that BartyCrouch isn't available via CocoaPods, but I guess you just mixed it up with Homebrew. ;)
If the hints above don't help you, you can also provide a minimum example project so I can analyze it and fix it. For me it still only sounds like the configuration is incorrect though.

Ah, sorry, I don't know where my head is this Monday morning. I meant Homebrew indeed :)
I'll double check if I'm not using the wrong path. Thanks!

I'm using absolute paths and the pointing to a folder with all the .lproj folders which contain the Localizable.strings files. Is this the correct use?

Yeah it should work then. Could you provide a minimum example project? That would really help here. I'm also reopening the issue.

Thanks! I'll try to do this when I have time, hopefully tomorrow.

Ah, one more idea: BartyCrouch writes a temporary file to your Localizables path. Maybe you don't have write access? Usually that shouldn't be the case but I can't come up with something else at the moment.

I think I discovered the problem. I couldn't reproduce it in a sample project until I renamed the project folder to have a space in the folder name.

Oh, if that's the problem, then this must be a duplicate of #12 which was attempted to be fixed via #17. Seems like there's more to it than handled in #17. Let me close this then and open the more descriptive #12 instead.


fix: cat temporary file instead of echoing location.

Location of output temp file is not that useful, but the contents of the file probably are.

Closing this as unnecessary.


Issue with nltk_data

When i try to run chatterbot on the local server it shows this error:
[nltk_data] Error loading stopwords: [nltk_data] Error loading wordnet: [nltk_data] Error loading punkt: [nltk_data] Error loading vader_lexicon
Along with it, it also shows the correct response.

Hi @sanyam8182, have the required NLTK files been downloaded to your local server?

i have downloaded the files in my system but i dont know about the server.

have the required NLTK files been downloaded to your local server?

It means, the chatterbot running machine, in your case your NLTK downloaded machine.

yes i have all the files mentioned in the error

Try to do fallowing steps
>>> import nltk
>>> print(nltk.data.path)

Check the files are copied into specified above directory or not. If files are there then it should work, even after also you are getting same error, try to download all corpus files
$ python3
>>> import nltk
>>> nltk.download('all')

on running the above commands i get this output:
['/Users/yuvikakoul/nltk_data', '/usr/share/nltk_data', '/usr/local/share/nltk_data', '/usr/lib/nltk_data', '/usr/local/lib/nltk_data']
which directory am i supposed to check

your home dir i.e '/Users/yuvikakoul/nltk_data'

it contains all the files, still i'll try downloading all the corpora files

@sanyam8182 Remove the files it contains. They will be re-downloaded (hopefully without errors this time) automatically by ChatterBot.


Question about line of code

Hello,
I noticed a line where the return value isn't captured. I've run small experiments with toy data and it didn't seem to matter.
https://github.com/yanaiela/amnesic_probing/blob/36c2a1d01722b848066bb03d1d99e1fdf79c81e9/amnesic_probing/debias/debias.py#L26
Was the line unnecessary, or should it be:
 w_basis = w_basis * np.sign(w_basis[0][0])  # handle sign ambiguity

Hi,
Scipy’s orth uses SVD, and there is an inherent sign ambiguity associated with SVD, see here. However, since the rowspace is (and the projection onto it) is the same regardless of the sign of its basis vectors, we can safely remove this line from the code.

Thank you!


Server without DTLS

Since M4 it is not possible to create a server without using dtls.
public static void main (String args[]) {
    	LeshanServerBuilder builder = new LeshanServerBuilder();
        builder.disableSecuredEndpoint();
        LeshanServer server = builder.build();
        server.start();
    }

Even if disableSecuredEndpoint is set, I get the following exception
Exception in thread "main" java.lang.IllegalStateException: Supported cipher suites must be set either explicitly or implicitly by means of setting the identity or PSK store
	at org.eclipse.californium.scandium.config.DtlsConnectorConfig$Builder.build(DtlsConnectorConfig.java:872)
	at org.eclipse.leshan.server.californium.LeshanServerBuilder.build(LeshanServerBuilder.java:404)

Fixed in master (commit cd08129dd633d725943bd8e1c4b4d1b515e807d6)


Switch and package configuration variables

Switch and package configuration variables
Switch and package configuration variables are respectively per switch and per package key-values bindings that can be accessed in opam files to configure packages.
Configuration variables come in two flavors, input and output variables (better names ? user and state variables ?). The difference being that input variables can be set by the opam end-user while output variables are usually defined by the result of install processes.
More precisely for package configuration variables:

input variables can be set before package installation to configure the package installation process.

output variables can be declared by the package install to provide information about its installation for other packages to use.

For switch configuration variables:

input variables can be set to globally configure packages that may use the variable.

output variables are variables determined by the switch creation procedure

Note that both input and output variables share the same namespace. It is not possible to declare both an input and output variable with the same name.
Also note that the current value of an input variable says nothing about the current install state of a switch or a package as they may be set by the end-user at any time without further side-effects. (N.B. if we had precise dependency tracking of variables in the opam files we could actually reinstall any package that depends on a variable whenever it is changed, but that may not be desirable either).
Input variable declaration
Switch input variables are defined in the switch's .descr file and package input variables are defined in the package's opam file via the config-input-vars field as follows:
config-input-vars: [ ([IDENT (BOOL | STRING | [ STRING+ ]) STRING])+ ]

That is each input variable needs to define a name, a default value (which can be a variable interpolated string, e.g. in a package it can refer to a switch input variable) and a documentation
string. Example:
config-input-vars: [
  [ "modernity" false "Use CPU extensions (SSE2, AES-NI)." ]
]

Output variables declaration
Output variables are defined in the switch's .descr file and the package's opam files via the config-output-vars variables as follows:
config-output-vars: [ ([IDENT STRING])+ ]

That is each output variable needs to define its name and a documentation string.
For packages, the package must then define the value of each of the declared variables by installing a opam.config file with the package in its lib directory, i.e. $opam/$SWITCH/lib/opam.config.
It is an install error if the package declares an output variables and fails to define it in its opam.config file.
FIXME I know less about the switch install procedure but I guess something similar could be done.
Setting input variables
Input variables can be set by using the following invocations:
opam config var-set $PKG:$VAR $VALUE
opam config var-set $VAR $VALUE

For packages this commands writes the $VAR to $VALUE binding in $opam/$SWITCH/config/$PKG.config file. For switches it does so in the file $opam/$SWITCH/config/global-config.config.  The invocations error if $VAR is not declared in the package's or switch's config-input-vars field.
Input variables can be reset to their default state using:
opam config var-reset $PKG[:$VAR]
opam config var-reset [$VAR]

Invoking this command resets the value of $VAR to the one that is declared in the opam or descr file. If $VAR is unspecified all the input variables are reset. The invocations error if $VAR is not declared in the package or switch's config-input-vars field.
Getting configuration variables
Both input and output configuration variables can be accessed using the following invocation:
opam config var [$PKG:]$VAR

They can also be used in the fields of opam files that support string interpolation to get their value by using $PKG:$VAR and $VAR. The invocations error if $VAR is not in declared in one of the config-*-vars field.

Oops wrong project.


Updates list of countries with converted headers

Trello: https://trello.com/c/ZegaI995
What's changed?
Update the list of countries in the countries_with_content_headers_converted method ready for go live.
The full list is here: https://foreign-travel-spike.herokuapp.com/api/completed_locations.
Why?
More countries have had their headers converted so we are able to point user to more specific content.
Expected changes

Before
After

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

@Rosa-Fox @gclssvglx That sneaky Slovenia! It must have just been converted 😱. It's been added now.

haha I thought it might have been! We can double check them tomorrow before launching too.


Ldap change notifications

Not sure why the commits appear the way they do, but the diff is consistent with the changes

The linter error was caused by having a TODO in the changes. I removed it hoping we find time to revisit the linting rules (active and disabled) in the near future.

Can we rebase and squash so this doesn't show 11 commits?

Commits squashed

Looks like pylint and black are not applying the same standards. I merged in a change master of a file that was formatted by black, and pylint failed the continuation indent.


Compiling on Linux with gcc 7.5.0

URL in "XMP-Toolkit-SDK/tools/cmake/ReadMe.txt" for Linux does not exist
See: https://github.com/adobe/XMP-Toolkit-SDK/issues/7#issue-623873638
Line 79 of "XMP-Toolkit-SDK/build/shared/SharedConfig_Common.cmake"
The command "-dumpversion" does not work correctly with gcc version 7.5.0.
This will lead to errors during the make command
CMake Error at shared/SharedConfig_Common.cmake:94 (if):
  if given arguments:

     "LESS" "413"

 Unknown arguments specified

The output for "-dumpversion" and "--version"
$ gcc -dumpversion
7
$ gcc --version
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Therefore the variable GCC_VERSION_STRING was not set correctly which let to the mentioned error. I had to replace "-dumpversion" using "--version" to make it work.
Line 187 of "XMP-Toolkit-SDK/build/ProductConfig.cmake"
set(XMP_PLATFORM_LINK "-z defs -Xlinker -Bsymbolic -Wl,--no-undefined  ${XMP_EXTRA_LINK_FLAGS} ${XMP_TOOLCHAIN_LINK_FLAGS} -lrt -Wl,--no-as-needed -ldl -lpthread ${XMP_GCC_LIBPATH}/libssp.a")`

In contrast to the description from the "XMP-Toolkit-SDK/build/README.txt" setting the variable "XMP_ENABLE_SECURE_SETTINGS" to "OFF" (Line 37 of "XMP-Toolkit-SDK/build/shared/ToolchainGCC.cmake") does not turn off the linking of the libssp.a which results in the following error.
[ 43%] Linking CXX shared library /adobe_dng_sdk/xmp_sdk/public/libraries/i80386linux_x64/release/libXMPCore.so
g++: error: /user/unicore/i80386linux_x64/compiler/gcc4.8.2/linux3.10_64/lib64/libssp.a: No such file or directory
/adobe_dng_sdk/xmp_sdk/XMPCore/build/gcc/dynamic/i80386linux_64/Release/CMakeFiles/XMPCore.dir/build.make:1583: recipe for target '/adobe_dng_sdk/xmp_sdk/public/libraries/i80386linux_x64/release/libXMPCore.so' failed

I had to modify Line 187 of "XMP-Toolkit-SDK/build/ProductConfig.cmake" to:
set(XMP_PLATFORM_LINK "-z defs -Xlinker -Bsymbolic -Wl,--no-undefined  ${XMP_EXTRA_LINK_FLAGS} ${XMP_TOOLCHAIN_LINK_FLAGS} -lrt -Wl,--no-as-needed -ldl -lpthread")

Line 187 of "XMP-Toolkit-SDK/build/ProductConfig.cmake"
set(XMP_PLATFORM_LINK "-z defs -Xlinker -Bsymbolic -Wl,--no-undefined  ${XMP_EXTRA_LINK_FLAGS} ${XMP_TOOLCHAIN_LINK_FLAGS} -lrt -Wl,--no-as-needed -ldl -lpthread ${XMP_GCC_LIBPATH}/libssp.a")
In contrast to the description from the "XMP-Toolkit-SDK/build/README.txt" setting the variable "XMP_ENABLE_SECURE_SETTINGS" to "OFF" (Line 37 of "XMP-Toolkit-SDK/build/shared/ToolchainGCC.cmake") does not turn off the linking of the libssp.a which results in the following error.
[ 43%] Linking CXX shared library /adobe_dng_sdk/xmp_sdk/public/libraries/i80386linux_x64/release/libXMPCore.so g++: error: /user/unicore/i80386linux_x64/compiler/gcc4.8.2/linux3.10_64/lib64/libssp.a: No such file or directory /adobe_dng_sdk/xmp_sdk/XMPCore/build/gcc/dynamic/i80386linux_64/Release/CMakeFiles/XMPCore.dir/build.make:1583: recipe for target '/adobe_dng_sdk/xmp_sdk/public/libraries/i80386linux_x64/release/libXMPCore.so' failed
I had to modify Line 187 of "XMP-Toolkit-SDK/build/ProductConfig.cmake" to:
set(XMP_PLATFORM_LINK "-z defs -Xlinker -Bsymbolic -Wl,--no-undefined  ${XMP_EXTRA_LINK_FLAGS} ${XMP_TOOLCHAIN_LINK_FLAGS} -lrt -Wl,--no-as-needed -ldl -lpthread")

Nice one thanks for the corrections ... perhaps do a PR so everyone can use it

Thank you very much @ai2ys you really saved my life ! All your suggestions are great. I can build now on Ubuntu 18.04:
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)
cmake version 3.15.5


feat: multi currency support

Description

builds on top of other PR where data fetching is implemented
adds view layer changes required to consume this data
adds settings selection switcher behind flag
swapping is not implemented in this PR - and will be added in another PR

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

wip
Risk

significant - touches pretty much everything.
Testing

full regression test of the app with the flag OFF (default) required
Screenshots (if applicable)
no visual changes should be present

converting to draft until @stackedq is able to look at currency formatting and chart issues
https://discord.com/channels/554694662431178782/984598894883250226

@willyogo definitely, is there any UI design in your mind for number format selection?

@shapeshift/product can we please get some love on the above for @stackedq ?

update on this PR - the currency formatting issue on charts is fixed, and i can't see any chart regressions with this flag on and USD selected, or with the flag off.
@stackedq is going to implement the currency selection in the settings modal, and we can merge this with the flag off, and tackle multi currency trade support in a separate PR, then get the flag on and feature released.

next issue to implement trade support https://github.com/shapeshift/web/issues/1995

@stackedq Some more conflicts after https://github.com/shapeshift/web/pull/2116 has been merged

Fixed the conflicts with my new defi ui stuff, a lot of it isn't needed anymore since we left the amount component do the heavy lifting.
I do have a suggestion on the currency selection, can we not sort the list on selection? I'm fine with it being sorted on mount, but its really weird that it jumps the item to the top when you make a selection.

@reallybeard changed some code to achieve the UX you described, please take a look to see if you're happy with the results.

Given the high risk of this, let's get @shapeshift/operations to test the Fleek branch

Looks good @stackedq working really nice!

going to merge this for the following reasons

architecturally, this was previously discussed and approved by @cjthompson and recently tested and approved by @gomesalexandre and @reallybeard
@shapeshift/operations has signed off on this today
it's behind a flag
this branch is a bastard child


BlockMetadata_TLSF::WriteAllocationInfoToJson

https://github.com/GPUOpen-LibrariesAndSDKs/D3D12MemoryAllocator/blob/e00c4a7c85cf9c28c6f4a6cc75032736f416410f/src/D3D12MemAlloc.cpp#L5033
Why do you cast uint64 to bool?

As far as I remember, this is a trick to make the value count as 0 or 1, so that the argument value is increased by one when m_NullBlock->size is not zero.
Do you observe any problem with this expression? Some error or warning in your compiler?

I hopefully fixed this warning.


Allow named colors

Please allow named colors (maybe as pre-defined constants), at least the basic HTML colors, or https://www.rapidtables.com/web/color/RGB_Color.html,

Some sources to take the colors from (I think the three have the same):

https://upload.wikimedia.org/wikipedia/commons/2/2b/SVG_Recognized_color_keyword_names.svg
https://www.w3schools.com/colors/colors_names.asp
https://www.w3.org/TR/css-color-4/#named-colors

PlantUML supports at least the last two.
We will attach here a dsl file containing all the constants.


feat: add mempool txs to payload

Motivation
Fetching transactions from the mempool during the block building process (engine_GetPayload).
This code can and should be improved in the future, but it sets a basis for block building

Description

Add method build_payload, which fetches transactions from the mempool and adds them to the payload.
Add a way to remove and filter transactions from the mempool
(Misc) Simplify state_trie related  StoreEngine api. The StoreEngine now only creates the trie, leaving block and state root fetching to the Store. This removes duplicated code

LEFTOVER WORK:

Save timestamp when a tx is added to the mempool
process blobs in block building pipeline (we are now ignoring them)

TESTING_STATUS:
The pipeline for block_building tests is  ForkChoiceUpdated -> (SendRawTransaction) -> GetPayload -> NewPayload -> (Fetch blocks/receipts).
Tests are currently failing at NewPayload because of different blob versioned hashes.
Closes None, but is part of #344

Looks good, let me know when the CI is fixed and I'll take another look! @fmoletta

Looks good, let me know when the CI is fixed and I'll take another look! @fmoletta

Should be working now 🚀


change body color for dark theme

This is completely my personal opinion. Current dark theme seems bit dull and eye straining.
Before:

After:

ref #27097

fine suggestion https://webaim.org/resources/contrastchecker/

Closing as the theme is to be replaced soon


Can preprocess_data.py support Huggingface Dataset?

Since there are many datasets in the format of Huggingface datasets, it would be convenient if preprocess_data.py can directly preprocess and tokenize from HF datasets.

The overwhelming majority of HuggingFace datasets are not structured in a way that makes sense for LLM pretraining. Given that, what do you envision this looking like? Specifying a field name and only training on the text in that field?


Next attempt to implement GC

This PR depends on freeze change (#233).
This is the description from the second commit.
This is a much simpler version of GC.
Major differences between this implementation and the previous attempt:

GC is environment-local now (each environment tracks own objects)
GC is only performed once at freeze

However, these options dramatically increase the number of possible
trade-offs in the implementation (if we need to keep GC low overhead),
so I choose to not do GC at all until environment freezes.  More
granular GC can be added later if necessary.
Objects are still reference counted, so additional memory overhead
occurs only if cycles are actually created, and unreachable objects
released when the environment is frozen. Which is an acceptable trade-off
given the typical use case os Starlark: short-lived scripts.
A detailed explanation of how the algorithm works:
Each Environment has an associated Heap object, there's 1-1
mapping between them.
Previously each object was either mutable or immutable (it was
a field in TypedValue). Now there are three kinds of objects:

immutable without links (strings)
immutable with links (tuples)
mutable with links (lists, sets, ...)

Each time Value with links is created, a weak reference is registered
in the lists of known objects.
gc_weak is invoked when too many new objects registered to check
if some weak references can be removed because objects were dropped
by refcounter:
struct Heap {
    known_objects: Vec<ValueWeak>,
}

impl Heap {
    fn register(&mut self, object: ValueWeak) {
        if self.known_objects.len() >= 2 * self.last_weak_gc_survivors {
            self.gc_weak();
        }
        self.known_objects.push(object);
    }

    fn gc_weak(&mut self) {
        self.known_objects.retain(ValueWeak::is_alive);
    }
}

When the environment is frozen, full GC is invoked. GC takes roots from
Environments (global variables, but not variables from the parent
environments or imported variables), traverses the object graph but
only within objects known to the current environment (see above), and
creates a set of alive objects. GC algorithm sketch is:
impl Heap {
    fn gc(&mut self, env: Environment) {
        // take globals from the environment,
        // but not imported and not from parents
        let roots = env.roots();

        let mut alive_objects = HashSet::new();
        let mut queue = roots;
        while let Some(object) = queue.pop() {
            // stop traversing when:
            // * object was not created in this environment
            // * object does not have links (e. g. string)
            if !self.objects.contains(object) {
                continue;
            }

            // mark object as alive
            if !alive_objects.insert(object) {
                // is already marked, skip it
                continue;
            }

            queue.extend(object.get_links());
        }

        for object in self.known_objects {
            if object in alive {
                // keep it
            } else {
                // break cycle
                object.gc();
                remove from self.known_objects
            }
        }
    }
}

Finally when Environment is dropped, for all known objects gc
function is invoked to break links cycles.

Rebase, add more tests, fix a bug.

Sorry I did not got enough time to get to this one, can it be rebased?

It gets better and better with each rebase

This PR is obsolete, closing


Lint against redundant cases

Empty case branches wherever they're not required.

I'm now unclear on what I was getting at with this. A seemingly redundant empty case might be useful for ensuring non-literal TS output. :thinking:


Support for routes relations

Route relations could be supported as multilinestring.
In Postgis terms, it would be equivalent to a ST_LineMerge().

+1

Are there any plans on implementing this feature? Or can we speed this up (for a reasonable price)?

We are not working on this at the moment.
But Imposm is part of our new SOSS License to help fund features like this. We also implement new features on a contract base if you have a fixed deadline. Just send me an email or private message.

https://github.com/omniscale/imposm3/pull/71

See #81


Add possibility to restrict PKCE to s256 method only

Expected Behavior
Add the possibility to restrict PKCE method to s256 only (e.g. for authorization code grant for public clients)
Current Behavior
Currently both PKCE methods (s256 and plain) are active by default (which is fine), but they cannot be configured.
Context
Sometimes (or often?) it is just not required to support the plain method in production. Therefore disabling plain per configuration could force all clients (that may or may not be under your control) to use the s256  method (which is a better protection against eavesdroppers, https://datatracker.ietf.org/doc/html/rfc7636 7.2) and thus decrease the attack surface a little bit.

Thanks for this request @olr101. I agree that plain should be disabled by default in order to comply with secure defaults.
We'll look at adding this enhancement.

We should also consider removing support for plain.

Hi @jgrandja
If it's not assigned to anyone, I would like to work on this one too.

Thanks @gourav. I've scheduled this for 0.3.0. Let's start work on this after 0.2.3 is out.

Now that 0.2.3 is released, may I take this up ?

@gourav Just a heads up that our top priority for 0.3.0 is the reference documentation so the team is focusing on that for the next 8 weeks. This means that new features and enhancements will be very light for 0.3.0.
Having said that, I'm not sure we'll be adding a configuration to disable the plain method.
As stated in 7.2 Protection against Eavesdroppers:

Because of this, "plain" SHOULD NOT be used and exists only for
compatibility with deployed implementations where the request path is
already protected.  The "plain" method SHOULD NOT be used in new
implementations, unless they cannot support "S256" for some technical
reason.

Right now I'm leaning towards removing support for the plain method but I'm still thinking it over.

Hi @jgrandja
Thank you for letting me know your thoughts on this.
If it's open to contributors, I would like to work on documentation as well.

Sure. I can work on https://github.com/spring-projects/spring-authorization-server/issues/642

Closing as duplicate of gh-756


Epitope database query error

Describe the bug
When trying to run the command:
ir.pp.ir_dist(mdata, vdjdb, metric="identity", sequence="aa")
I receive an error showing:
ValueError: No AIRR data found in adata.obsm['airr']. Your AnnData object might be using an outdated schema. Scirpy has updated the format of `adata` in v0.13. AIRR data is now stored as an awkward array in `adata.obsm['airr']`.Please run `ir.io.upgrade_schema(adata) to update your AnnData object to the latest version.

When I try to run the ir.io.upgrade_schema command as suggested, I nonetheless get:
ValueError: Your AnnData object seems already up-to-date with scirpy v0.13, no matter whether I run
ir.io.upgrade_schema(mdata['airr']) or ir.io.upgrade_schema(mdata)
To Reproduce
Very happy to share data if needed for this if I could have an email address I could share a google drive link?
System

Python 3.10
Versions of libraries involved [e.g. AnnData 0.8.0, Scirpy 0.12.0]

scanpy==1.9.3
anndata==0.9.2
scirpy==0.13.0
muon==0.1.5

Please let me know if there is anything else I could provide to help debug/troubleshoot, thank you.

Hi,
I think this might be the same issue as answered here: https://discourse.scverse.org/t/problems-with-querying-reference-databases-or-datasets-for-annotation-of-irs/1564
LMK if this doesn't work for you!

Closing this for now, let me know if this is still an issue!


Tutorials Updating S3 Paths for Bucket noaa-ghcn-pds

Feature or Bugfix

noaa-ghcn-pds bucket has changes partinioning

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: e0d55f89b09cad44a625efec1c7ca7784e6de452
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


JSServe fails to precompile due to missing TLS certs

On systems that require custom TLS certs to access the internet, JSServe fails to precompile. A shell call to deno bundle ... is the culprit. deno apparently doesn't use the system TLS store by default. Setting the environment variable DENO_TLS_CA_STORE=system fixes it (solution found here: https://stackoverflow.com/questions/60522120/setting-up-https-on-deno-with-self-signed-certificate).
It seems like it is probably best practice to use the system TLS store. I'm not sure why deno does not. I'm not familiar enough with deno to know if setting this environment variable is the best way of doing this.

I also don't know why it would need tls anyway, since it shouldn't need to connect to the internet..

I'm pretty sure this was the shell call that failed: https://github.com/SimonDanisch/JSServe.jl/blob/48740b2cd5045c276de9aa461439e7f643f845d0/src/asset-serving/asset.jl#L162. Of course, I'm having a hard time reproducing now. I'll try again tomorrow.


DB2 may not return the column names in SYSCOL.INDEXES

COLNAMES usage is deprecated:
https://www.ibm.com/support/knowledgecenter/SSEPGG_11.5.0/com.ibm.db2.luw.sql.ref.doc/doc/r0001047.html
related to https://github.com/ibmdb/python-ibmdbsa/pull/60

@sasa-tomic can you please rebase and resolve any conflicts. We can merge it.


Part 4 issue SD card not big enough

Because I can't afford anything else I use the standard 4 Gb micro SD that comes with my new 3ds. When I tried to do the emuNAND backup it said it didn't have enough space. What should I do?

Hmm, if u cant delete any other files to gain space, the only thing i can think is buy a 8 gb sd card.

Redo Part 3 with a larger SD


Files not uploading when deploying in us-west-2

Describe the bug
A clear and concise description of what the bug is.
When the solution is deployed to us-west-2 it is impossible to upload new files using the demo UI
To Reproduce
Steps to reproduce the behavior:

Deploy the solution to the us-west-2 region
Click on "new analysis"
Selec a file to upload
Click on "Upload an process"
An error with the legend "Failed to upload and process file. Please try again" will appear and the file wont be uploaded

Expected behavior
The document is uploaded and the document processing pipeline is started
Screenshots

Desktop (please complete the following information):

OS: Mac OS X 15.1.1 (24B91)
Browser Chrome
Version 131.0.6778.205 (Official Build) (arm64)

Additional context
Add any other context about the problem here.
Problem does not happen when deployed to the us-east-1. Problem may be related to the pre-shared URL generated to upload the files to the bucket.

Problem is related https://github.com/boto/boto3/issues/2989. Implementing suggested fix.


Using this can we replace Blazorise with MudBlazor?

Using this can we replace Blazorise with MudBlazor?
how different is this from your new article (https://community.abp.io/posts/customize-abp-blazor-application-ui-with-mudblazor-wscmpu3w)

Using this can we replace Blazorise with MudBlazor?
Most of the UI is created with MudBlazor, instead of Blazorise.
Tenant management and settings pages are not covert in this sample. After customizing them as well, Blazorise can be deleted.

how different is this from your new article (https://community.abp.io/posts/customize-abp-blazor-application-ui-with-mudblazor-wscmpu3w)
Not really. But I sometimes fix and polish this repository, so this repo is more up to date with small changes.


fix(curriculum): clarify instructions with implicit return on JS spreadsheet step34

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54259
There is already a PR submitted by @Supravisor (#54272); my PR modifies english version of instrucions and I added new assert for implicit return check which was missing on Supravisor PR.
Below an image after fix:

I think this is also a great opportunity to be more specific with the other test that requests the .find() callback to use an implicit return below (line 66). Instead of using:

Your callback function should use an implicit return.

It can be more explicit with the following, similar to other tests already in the freeCodeCamp repository:

Your .find() callback should use an implicit return

I think this is also a great opportunity to be more specific with the other test that requests the .find() callback to use an implicit return below (line 66). Instead of using:

Your callback function should use an implicit return.

It can be more explicit with the following, similar to other tests already in the freeCodeCamp repository:

Your .find() callback should use an implicit return

Yep, that’s right! I didn’t see this one at line 66, I agree with you, we can make this hint more explicit

Test 5 and test 9 are using the same regex. The assert message you get when the find callback isn't using an implicit return is.

Your idToText function should return the result of calling the .find() method on your cells array.

Test 5 will always catch an implicit return, and test 9 will never inform the camper about the required explicit return.
We can update test 9 to look for the return keyword, or we can combine the two tests into one. They are both testing for the same thing by having the start of the callback function body bracket in the regex. But test 5 is vague and test 9 is explicit about the return.

Hiya! We merged the other PR to update the instructions, as it was successfully passing and approved.
We'd love to merge yours too! We just need you to fix the conflicts, and address lasjorg's review above. :3

Hiya! We merged the other PR to update the instructions, as it was successfully passing and approved.
We'd love to merge yours too! We just need you to fix the conflicts, and address lasjorg's review above. :3

Hi @naomi-lgbt! Thanks! I've just resolved conflict on merge and applied @lasjorg suggestion, hoping to get correctly what he was saying 😆

@huyenltnguyen
Can you approve this?
Thanks 👍


Improve error handling of classifiers and regressors

Is your feature request related to a problem?
In some cases, error handling is not ideal (see solution for details) in the safeds.ml package.
Desired solution

Validate inputs of a function as the first step
Raise an appropriate exception with an appropriate message if issues are found
Document in the docstring that the exception is raised and under which condition
Test that the correct exception with the correct message is raised

Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)

Example: If non-numerical columns are in a table, an appropriate message should be shown. Users should also be guided towards the OneHotEncoder or LabelEncoder and we should describe when to use which.

:tada: This issue has been resolved in version 0.14.0 :tada:
The release is available on:

v0.14.0
GitHub release

Your semantic-release bot :package::rocket:


Benchmark JVMs for OpenSearch

The JVM we're using is the one that we inherited, but we haven't validated that it's actually the best one to use.
The request is to benchmark different JVM versions with OpenSearch & make a plan to move to the highest-performing one. Please also consider support & terms when making a recommendation. For example, Oracle JDK has short LTS support for free users, longer LTS support for paid users. Adopt has very short support. AWS corretto offers longer support for select versions, etc.
Expected output:  Benchmark information for OpenSearch on different available JVMs (similar to: https://www.optaplanner.org/blog/2021/09/15/HowMuchFasterIsJava17.html)
Once we've done our homework, we can move the project to the best JVM (if necessary).

Benchmarking needs to be done against jdk8, jdk11, jdk16 and jdk17

OpenSearch cluster instances have been launched but there is still an error when performing Mensor testing

Tests have begun and the results are being compiled.  Metrics being recorded are Latency (ms), Throughput (req/s), and Operation Counts.

Interesting findings [1] for Apache Solr deployments (which could be quite relevant to OpenSearch as well), quoting for completeness:

Just switched to @graalvm in our @ApacheSolr deployment (Just the JIT - so drop in JDK replacement) and observed a 15%ish drop in response times.  For basically no effort.

I think benchmarking against GraalVM distributions could be an interesting experiment.
[1] https://twitter.com/karlstoney/status/1456616777325158405

Results for min distribution of OpenSearch 1.2:
Note: arm versions of JVM 14 and 15 are no longer available so I was only able to perform tests for the x64 versions.  The arm test for JVM 11 is still running so that will be updated later.

Java 8: x64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
3.303
3.525
8.175
9.658

distance_amount_agg
2.102
2.344
2.673
31.113

index
1,764.9
2,407
3,243.2
5,989

range
253.2
262.5
272
286.7

autohisto_agg
266.1
275.3
295.4
303.9

date_histogram_agg
245.7
254.7
260.4
265.2

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.012
2.02
2.04

index
42,819.6
44,560.7
51,879.1

range
0.704
0.706
0.711

autohisto_agg
1.506
1.509
1.518

date_histogram_agg
1.506
1.509
1.519

Java 8: arm64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
2.867
3.06
7.386
8.075

distance_amount_agg
2.13
2.3
3.188
10.845

index
1,554.5
2,072.3
2,670.5
4,602.2

range
218
224.2
230.3
235.5

autohisto_agg
177.8
182.5
187.5
202.4

date_histogram_agg
172.9
177.3
182
184.3

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
49,191.9
50,967.1
57,144.2

range
0.704
0.706
0.712

autohisto_agg
1.507
1.511
1.522

date_histogram_agg
1.507
1.511
1.522

Java 14: x64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
3.629
6.877
7.668
36.033

distance_amount_agg
2.173
2.393
2.705
2.953

index
2,182.9
2,844.9
4,093.7
9,802.5

range
293.8
310.5
328.1
356.7

autohisto_agg
317
331.5
343.9
361.3

date_histogram_agg
300.9
317.1
326.1
330.9

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
35,204.8
36,919.6
43,315.3

range
0.704
0.706
0.711

autohisto_agg
1.505
1.508
1.516

date_histogram_agg
1.505
1.508
1.517

Java 15: x64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
5.678
5.97
6.196
6.517

distance_amount_agg
2.084
2.28
2.58
2.803

index
2,094.3
2,795.4
3,908.7
6,981

range
292.9
310.2
328.6
341.5

autohisto_agg
315.7
329.6
345.7
362.6

date_histogram_agg
289.5
308.3
314.8
316.7

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
36,476.6
38,123.5
45,032.4

range
0.704
0.706
0.711

autohisto_agg
1.505
1.508
1.518

date_histogram_agg
1.505
1.508
1.517

Java 17: x64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
3.235
3.422
3.915
4.53

distance_amount_agg
2.141
2.284
2.52
2.834

index
1,968.5
2,564.2
3,554.2
6,373.4

range
246.5
257.1
294.4
316

autohisto_agg
248.5
257.3
264.3
314.7

date_histogram_agg
240
249.8
259.3
299.5

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
38,915.1
40,663.8
46,821.8

range
0.704
0.706
0.712

autohisto_agg
1.506
1.509
1.519

date_histogram_agg
1.506
1.51
1.519

Java 17: arm64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
2.865
3.07
7.315
9.295

distance_amount_agg
2.012
2.165
2.498
2.92

index
1,526.8
2,067
2,741.9
6,001.7

range
354.6
366.6
380.7
393.8

autohisto_agg
208.1
217.4
221.4
247.4

date_histogram_agg
204.7
212.9
224.5
246.4

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
49,203.2
51,354.2
58,656.7

range
0.703
0.705
0.711

autohisto_agg
1.507
1.51
1.521

date_histogram_agg
1.507
1.51
1.521

Java 11: x64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
5.3
5.709
6.087
12.386

distance_amount_agg
2.103
2.258
2.402
2.871

index
2,107.2
2,781.3
3,958.1
7,339

range
281.3
315.8
326.8
329.8

date_histogram_agg
289.7
324.2
335
369.4

autohisto_agg
334
356.3
368.4
372.9

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
36,067.8
37,763.2
43,562

range
0.704
0.706
0.711

date_histogram_agg
1.505
1.508
1.517

autohisto_agg
1.505
1.507
1.515

Java 11: arm64

Latency (ms)

Operation Type
P50
P90
P99
P100

default
2.934
3.111
5.687
9.47

distance_amount_agg
2.298
2.502
2.684
2.961

index
1,377.3
1,889
2,534.4
4,650.5

range
231.6
237.4
241.4
242.5

autohisto_agg
207.2
212.5
219.7
222.1

date_histogram_agg
205.7
211.5
219.8
224.4

Throughput (req/s)

Operation Type
P0
P50
P100

default
3.02
3.03
3.058

distance_amount_agg
2.013
2.02
2.04

index
54,602
57,333.2
64,667.6

range
0.704
0.706
0.712

autohisto_agg
1.507
1.51
1.521

date_histogram_agg
1.507
1.51
1.52

What's the hardware configuration for this test (OS, processor, RAM)?  Can you run the benchmarks across different Operating Systems that may have variations in default glibc installations?

Just want to clarify, by "JVM versions" mentioned in the task description does it refer to finding the best distribution (i.e. Oracle vs Adopt vs Corretto, etc)? The test results posted above are for Java versions, and unless I missed, I don't see the distribution specified.
As for Java versions, I would think the obsolete non-LTS versions (14, 15) would be non starters for a runtime JVM due to the lack of security updates. The same reasoning might apply for Java 8 as well since it will be approaching end-of-life relatively soon and there are two more recent LTS versions now.

What's the hardware configuration for this test (OS, processor, RAM)? Can you run the benchmarks across different Operating Systems that may have variations in default glibc installations?
The OS is Linux.  An m5.xlarge instance is used for x versions and m6g.xlarge is used for arm versions.

Just want to clarify, by "JVM versions" mentioned in the task description does it refer to finding the best distribution (i.e. Oracle vs Adopt vs Corretto, etc)? The test results posted above are for Java versions, and unless I missed, I don't see the distribution specified. As for Java versions, I think the obsolete non-LTS versions (14, 15) would be non starters for a runtime JVM due to the lack of security updates. The same reasoning might apply for Java 8 as well since it will be approaching end-of-life relatively soon and there are two more recent LTS versions now.

Bingo. The output is to choose a jdk distribution based on available data. Performance is one of the data points, and maintenance/patching policy is going to be another big one. I think @CEHENKLE is going to continue that conversation in a new issue in January.

@Cai-Chen I just used the base version found on the Oracle website for each JVM.  The x64 version performs better than arm64 with JDK 17 based on my testing (4.53 vs. 9.295 millisecond latency), so I do not believe that you are missing any special configuration options.

@Cai-Chen I just used the base version found on the Oracle website for each JVM. The x64 version performs better than arm64 with JDK 17 based on my testing (4.53 vs. 9.295 millisecond latency), so I do not believe that you are missing any special configuration options.

Thanks @ryanbogan , thats bad news for me 😢

@Cai-Chen I just used the base version found on the Oracle website for each JVM. The x64 version performs better than arm64 with JDK 17 based on my testing (4.53 vs. 9.295 millisecond latency), so I do not believe that you are missing any special configuration options.

Thanks @ryanbogan , thats bad news for me 😢 BTW, what instance size are you using?

I used m5.xlarge for x64 and m6g.xlarge for arm64 @Cai-Chen

@ryanbogan  whats tasks are pending to prevent closing this issue?

@minalsha I don't think there are any tasks left for this issue


Flash API: new information getter

This is recreation of closed  https://github.com/zephyrproject-rtos/zephyr/pull/36484
First commit in this PR proposes change to flash API that introduces API calls for obtaining information about flash, like size, page count and page information.
This change, contrary to flash_api_pages_layout, is non optional addition and does not allow directly returning objects from drivers, instead allows to query the driver to fill in information.
The addition of API calls:
ssize_t flash_get_page_count(const struct device *dev);
ssize_t flash_get_size(const struct device *dev);
int flash_get_page_info(const struct device *dev, off_t offset, struct flash_page_info *fpi);
allows access to information on flash size and page count, and information on single page.
The commit changes also the flash_parameters structure with addition of flags and max_page_size;
there is one flag defined so far: FPF_NON_UNIFORM_LAYOUT that is set for devices with non-uniform layout and should allow code using the flash device to decide how to work with the device.
The second commit is test of changes.
This is proposed implementation of: https://github.com/zephyrproject-rtos/zephyr/issues/36485
TODO:

[x] test cases;
[ ] apply to all drivers.

@de-nordic, it is not clear what advantages this change brings.
Could you add some figures illustrating:
a. Reduced code size,
b. Faster execution,
c. (If possible) show that it is easier to introduce new drivers.


Fix the local hf pretrained model path

The initial download of the weights of stable-diffusion-v1-4 is going to ~/.cache/huggingface/hub instead of ~/.cache/huggingface/diffusers/.
Tested in Google Colab and Lambda Labs.
We can squash the commits and merge

Hi @anubhavmaity! Thanks a lot for noticing and fixing this! However your PR seems to modify most of the notebook's cells and outputs. Would it be possible for you to submit a version that only updates the cell that needs to change? Otherwise I could try to do it myself :)

Hi @pcuenca, Thank you for the reply. I am trying to do the same after reviewing the diff in ReviewNB. If I am not able to, I will let you know.

@pcuenca created a new PR, please check


New Desktop Project Added - SQL [ Recruitment System ]

Hi
This PR assigned with issue #79
For the new SQL project
Project description in the project README file
I hope this helps other developers
Thanks

Looks good to me @TawfikYasser but Readme.md file should be under SQL not under the project.

Or delete the Readme.md file which is under SQL

Okay File Deleted

@SamarpanCoder2002 When you gonna merge any project don't forget to add levels.

@SamarpanCoder2002 When you gonna merge any project don't forget to add levels.

Ok...I will remember this...


Layernorm: No such file or directory: 'ldconfig'

When run
hidden_states, residual = fused_add_norm_fn(
hidden_states if residual is None else self.drop_path(hidden_states),
self.norm.weight,
self.norm.bias,
residual=residual,
prenorm=True,
residual_in_fp32=self.residual_in_fp32,
eps=self.norm.eps,
)
then go into layernorm.py and run
y, mean, rstd, residual_out = _layer_norm_fwd(
x, weight, bias, eps, residual, residual_dtype=residual_dtype, is_rms_norm=is_rms_norm
)
the function _layer_norm_fwd report the error: [Errno 2] No such file or directory: 'ldconfig'
The full error message is as follows：
[Errno 2] No such file or directory: 'ldconfig'
File "/data2/ZYM/Net/networks/mamba/mamba_ssm/ops/triton/layernorm.py", line 155, in _layer_norm_fwd
_layer_norm_fwd_1pass_kernel[(M,)](
File ""/data2/ZYM/Net/networks/networks/mamba/mamba_ssm/ops/triton/layernorm.py", line 411, in forward
y, mean, rstd, residual_out = _layer_norm_fwd(
File ""/data2/ZYM/Net/networks/networks/mamba/mamba_ssm/ops/triton/layernorm.py", line 478, in rms_norm_fn
return LayerNormFn.apply(x, weight, bias, residual, eps, prenorm, residual_in_fp32, True)
File ""/data2/ZYM/Net/networks/networks/VideoMamba.py", line 85, in forward
hidden_states, residual = fused_add_norm_fn(
File ""/data2/ZYM/Net/networks/networks/VideoMamba.py", line 346, in forward_features
hidden_states, residual = layer(
File ""/data2/ZYM/Net/networks/networks/VideoMamba.py", line 373, in forward
x = self.forward_features(x, inference_params)
File ""/data2/ZYM/Net/networks/train_with_videomamba.py", line 324, in
frame_pred = videomamba_model(frame_input)
FileNotFoundError: [Errno 2] No such file or directory: 'ldconfig'
Has anyone encountered this error?

Hi! It seems to be an error in your train_with_videomamba.py. Please check it.

Thank you for your reply! I can run the same code on other servers, but when I run it on our lab server, I get this error. I guess there might be a problem with the environment, so I want to ask if anyone have encountered the same problem.


Inertia View path might be different

The view path for Inertia pages might be different in some projects. The default path according to the Inertia documentation is ressources/js/Pages. However as a developer I could change it to whatever I like. Even moving the Pages folder to a completely different place.
createInertiaApp({
  resolve: name => require(`./Madness/${name}`),
  // ...
})

Therefore it is not possible for Laravel to check if a component exists.

This will resolve #3 as-well. Inertia can be used with React (JS and TypeScript), Svelte… and relying on a Vue file limits the usefulness of this Package.

Thanks for the PR! This makes a lot of sense but I think we need to update the Readme as well since the description about how the template path gets resolved is also specific to @inertiajs/inertia-vue isn’t it?

The resolving is done by JavaScript. You only have to pass a path "Foo/Bar/Baz" to the render function.
Vue 2, Vue 3, React
createInertiaApp({
  resolve: name => require(`./Pages/${name}`),
  // ...
})

Svelte
createInertiaApp({
  resolve: name => require(`./Pages/${name}.svelte`),
  // ...
})

For the documentation it might be sufficient to give a notice that the examples are based on the default path in Vue. It might be different depending on the project.

I’ll merge this for now and will have a look at the docs separately. Thanks for the contribution!

@ksassnowski Thank you. I proposed changes to the documentation just now ;-)


[SPARK-23654][BUILD] remove jets3t as a dependency of spark

What changes were proposed in this pull request?
Remove jets3t dependency, and bouncy castle which it brings in; update licenses and deps
Note this just takes over https://github.com/apache/spark/pull/21146
How was this patch tested?
Existing tests.

CC @steveloughran

Test build #94632 has started for PR 22081 at commit a222cb8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2090/
Test PASSed.

Test build #94632 has finished for PR 22081 at commit a222cb8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94632/
Test FAILed.

Test build #4243 has started for PR 22081 at commit a222cb8.

Test build #4243 has finished for PR 22081 at commit a222cb8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

I've just pushed up my PR which is ~ in sync with this one; I'll close that one now and this can be the one to use.
Assume: kinesis uses bouncy castle somewhere.  There's some hints in the AWS docs
Encrypt and Decrypt Amazon Kinesis Records Using AWS KMS covers end-to-end encryption of Kinesis records. For this you need the AWS encryption SDK, whose docs say you need bouncy castle.
And it looks like the AWS encryption SDK does explicitly depend on bouncy castle.
Imagine if somehow the removal of bouncy castle as a java crypto provider was stopping that round trip working with some of the encrypt/decrypt not happening. In which case adding bouncy castle should fix things. It worked before because jets3t in spark-core added bouncy castle, and the last bouncy-castle version update made it in sync with kinesis (and broke jets3t, but nobody has noticed...)
But

There's no refs to javax.crypto, the aws crypto libs or calls to the class KinesisEncryptionUtilsreferenced in the blog post in the spark kinesis module (it's not in the latest SDKs either(
There's no build-time dependency on the aws-sdk encryption, which would transitively pull in the bouncy castle stuff.
Looking through the aws-sdk-bundle: no refs to javax.crypto in the kinesis code; encryption refs limited to the PUT request where you can request server-side encryption with a given KMS key.
Nor is there any com.aws.encryptionsdk in that bundle, or shaded bouncy castle (which is good, as otherwise I'd have to deal with the fact that some ASF projects were shipping a shaded version of it unknowingly)

It could just be a strong java crypto provided is needed, and in the absence of the unlimited java crypto JAR in the JDK lib dir (where it's needed for kerberos to work), bouncy-castle needs to be on the CP.
What to do?

you can remove jets3t independent of the bouncy castle changes, because Kinesis isn't going to be using jets3t. The aws-s3 module significantly supercedes the jets3t client's functionality, and is the only one you'd expect the other parts of the AWS SDK to pick up.
the bouncy-castle dependency could be upgraded to a later version in the kinesis module(s) alone, and explicitly added to kinesis-asl.
Someone needs to do some experiments with what happens to the test suite with/without the full JCE and bouncy castle, maybe including more details on whats not matching up in the round trip tests
1 Maybe including some new test which somehow explores what encryption algorithms/keys you get with/without the BC  and JCE-unlimited JARs

Hm, I wonder, does the (newer) Kinesis SDK pull in bouncy castle? that's fine if so, that would make sense. If https://github.com/apache/spark/pull/22099 works, then we'll see if this then passes.
I suppose it's possible it's not actually related, and the Kinesis bit hasn't worked for a while because it's just never changed and so not tested, and needed an SDK update for some other reason. Who knows.

No, the SDKs dont pull in bouncy-castle. Checked via mvnrepo

core sdk pulls in jackson & httpclient; historically v. fussy about httpclient versions
kinesis SDK: adds protobuf-2.6, guava 18.0, others.

I've checked with Shane: the jenkins systems do not have the unlimited javax crypto in, so suspect that bouncy-castle is just needed for testing

I see. I guess I'm trying to figure out whether it's reasonable or not to pull in bouncy castle -- just in the Kinesis module I guess -- on behalf of the user then?
That's the default conservative thing to do, but having just gone through the ECCN process, I realize it's not trivial for us to redistribute bouncy castle. Worth trimming if it's really about all the same to users.

I think it should be stripped; maybe add a note to the docs "you need unlimited JCE for kinesis to work"

Makes sense, but then I wonder how the tests work? we need a test dependency on it?

making a test-time option is a reasonable idea -getting the unlimited JCE on the test machines (they don't right now) would remove the need for this

Test build #94849 has started for PR 22081 at commit d0334c1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2245/
Test PASSed.

Test build #94849 has finished for PR 22081 at commit d0334c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94849/
Test PASSed.

Merged to master

Thanks. Two less JARs on the CP to keep up to date —what more can anyone want?


Initial ansible proof of concept

What this PR does / why we need it:
We have been running smoketests in regions manually. This is error-prone and needs to be automated. As a first step here is the minimum viable Ansible playbook that creates a cluster, waits for it to become healthy via kube api, runs az aro update, then deletes the cluster. This is designed to run Ansible from a container so that users' development hosts don't need to have Ansible installed and will facilitate running smoketests in an automated fashion in the future.
This will allow us to evaluate the following questions:

Do we want an Ansible dependency in our codebase?
What smoke tests do we want? (see https://docs.google.com/document/d/1K9Qffl5CuRr_PpeAKI4ik6Rl4je1p-rdf6_xZXJZzVM)

Test plan for issue:
To test, make sure you've got a valid az login session. This is passed through to the container via your ~/.azure directory.
Then run
$ make smoketest

This will first build the required aro-smoketest container image if it doesn't exist, then it will execute ansible-playbook in the container. By default, the /smoketest files are baked into the container image to ensure when this is automated in the future the ansible playbook is in a known state. To test local changes, use the
$ make smoketest-dev

target; this will mount your /smoketest tree into the container.
To personalize the resulting resource groups, set the CLUSTERPREFIX as desired. For example
$ make smoketest CLUSTERPREFIX=${USER}

The default region used is eastus. Set the REGION parameter to choose a different region:
$ make smoketest REGION=centraluseuap

To choose one or more cluster configurations, set the CLUSTERPATTERN parameter to a wildcard string that matches the cluster scenarios you wish to test:
$ make smoketest CLUSTERPATTERN=smoketest-udr

Currently implemented cluster configurations are:

smoketest-basic: Simplest cluster, nothing fancy
smoketest-private: Simple cluster with apiserver and ingress visibility set to private
smoketest-enc: Encryption-at-host enabled
smoketest-udr: UserDefinedRouting with a blackhole Route Table
smoketest-byok: Disk encryption using bring-your-own-key

Is there any documentation that needs to be updated for this PR?
Yes

How do you know this will function as expected in production?

Looks good, I ran make smoketest and I was getting the following error.
docker run --rm -t -v ${AZURE_CONFIG_DIR:-~/.azure}:/opt/app-root/src/.azure:O aro-smoketest:83860bc -i regions/eastus -l smoketest-basic* -e CLUSTERPREFIX=smoketest  smoketest.yaml
docker: Error response from daemon: invalid mode: O.
See 'docker run --help'.
make: *** [Makefile:304: smoketest] Error 125

I think the error is caused by docker volume mount mode to O which it doesn't support? I thought it was meant for podman overlay.


What does "Seek a functional interface over a mutation-based implementation." mean?

Can we add a link for this to show exactly what this concept means?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b63d2086-c15d-2434-8189-c2acaab237ca
Version Independent ID: 08a7d210-bab0-fdd3-5629-34dcc79172e1
Content: F# style guide
Content Source: docs/fsharp/style-guide/index.md
Product: dotnet-fsharp
GitHub Login: @cartermp
Microsoft Alias: phcart

There's no link that I have on hand (as this isn't some idiom or anything), but I think it is a bit ambiguous as-worded. I made a change in #6450 - does that help?

It helps...  for less savvy programmers, blocks of before and after code examples that demonstrate these guidelines would be very valuable

Perhaps linking to the section in the conventions article that explains this in more detail would help?
https://docs.microsoft.com/en-us/dotnet/fsharp/style-guide/conventions#performance

Yep... that does help
Jeff
On Fri, Jul 13, 2018 at 1:32 PM, Phillip Carter<EMAIL_ADDRESS>wrote:

Perhaps linking to the section in the conventions article that explains
this in more detail would help?
https://docs.microsoft.com/en-us/dotnet/fsharp/style-guide/
conventions#performance
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/6449#issuecomment-404901141, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEy8XFks1OaFt9BkNSicf3deE1RkNTuks5uGNm0gaJpZM4VO-zy
.

Great, thanks. That second does contain an example of this phrase, in addition to other considerations (such as hiding some stuff behind a class).

Link to section with code sample implemented here: #6450
Additionally, the ambiguity was cleared up in the text.


How to set the value directly to a attribute, for example to ahref?

Hello, I am just playing with your template library for the first time.
I noticed a data-link and data-link-wrap options to set a href, but is there also a
way to directly acces the value? For example I would like to keep the existing properties on the a href.

Something like this?

Is it even possible to acces your data value without using the data- attribute?
Thanks in advance!
Regardss, Chris

Hi Chris,
If I understand correctly you would like to set the href value on the a tag without touching the other values. If that is the case you can use data-href on the a tag to set the value of the href to what you want on that and leave your other attributes alone. This should do what you want I believe.
Kind Regards
Paul

Hi Paul,
Thanks for your quick reply! Great work by the way!
I will try data-href tomorrow at work.
Have a nice evening.
Kind Regards,
Chris.
Date: Wed, 29 Apr 2015 10:44:15 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [jquery-template] How to set the value directly to a attribute, for example to ahref? (#68)
Hi Chris,
If I understand correctly you would like to set the href value on the a tag without touching the other values. If that is the case you can use data-href on the a tag to set the value of the href to what you want on that and leave your other attributes alone. This should do what you want I believe.
Kind Regards
Paul
—
Reply to this email directly or view it on GitHub.


Foreach with multiple loop variables doesn't emit skipped indexes

Skipped indexes are missing in VPI AST.
According to [1] skipped index variable should be represented as vpiOperation with vpiOpType = vpiNullOp.
[1]: IEEE Std 1800-2021 "IEEE Standard for SystemVerilog", 37 VPI object model diagrams, 37.73. Do-while, foreach, Detail 2.
Example (https://github.com/zachjs/sv2v/blob/master/test/core/foreach.sv):
module top;
    logic [1:0] foo [4] = {2'b10,2'b01,2'b11,2'b00};
    initial
        foreach (foo [ x ])
            $display(x, foo[x]);

    // from the SystemVerilog-2017 specification
    int A [2][3][4];
    bit [3:0][2:1] B [5:1][4];
    initial begin
        A = 0;
        B = 0;
        foreach( A [ i, j, k ] )
            $display(i, j, k);
        foreach( B [ q, r, , s ] )
            $display(q, r, s);
    end
endmodule

VPI AST fragment for the foreach over B:
\_foreach_stmt: (work@top), line:15:9, endln:15:16
  |vpiParent:
  \_begin: (work@top), line:10:13, endln:17:8
  |vpiFullName:work@top
  |vpiVariables:
  \_ref_var: (work@top.B), line:15:18, endln:15:19
    |vpiParent:
    \_foreach_stmt: (work@top), line:15:9, endln:15:16
    |vpiTypespec:
    \_array_typespec:
    |vpiName:B
<EMAIL_ADDRESS>  |vpiLoopVars:
  \_bit_var: (q), line:15:22, endln:15:23
    |vpiTypespec:
    \_bit_typespec: , line:9:5, endln:9:19
      |vpiRange:
      ...
    |vpiName:q
  |vpiLoopVars:
  \_bit_var: (r), line:15:25, endln:15:26
    |vpiTypespec:
    \_bit_typespec: , line:9:5, endln:9:19
      |vpiRange:
      \_range: , line:9:9, endln:9:14
      ...
    |vpiName:r
  ╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴┨ Missing vpiOperation
  |vpiLoopVars:
  \_bit_var: (s), line:15:30, endln:15:31
    |vpiTypespec:
    \_bit_typespec: , line:9:5, endln:9:19
      |vpiRange:
      ...
    |vpiName:s
...

This is non - synthesizable code. Let's focus on synthesizable code for the Yosys plugin.

Please provide a synthesizable example we can formally verify

This one should be syntesizable:
module top(input clk);
    bit [1:0][3:0] B [3:0][2];
    always @(posedge clk) begin
        foreach(B[q, r, , s]) begin
            B[q][r][0][s] = r;
            B[q][r][1][s] = 0;
        end
    end
endmodule

Relevant fragments of UHDM tree (command: surelog -parse -d uhdm):
...
|vpiStmt:
\_foreach_stmt: (work@top), line:4:9, endln:4:16
  |vpiParent:
  \_begin: (work@top), line:3:27, endln:8:8
  |vpiFullName:work@top
  |vpiVariables:
  \_ref_var: (work@top.B), line:4:17, endln:4:18
    |vpiParent:
    \_foreach_stmt: (work@top), line:4:9, endln:4:16
    |vpiTypespec:
    \_array_typespec:
    |vpiName:B
<EMAIL_ADDRESS>  |vpiLoopVars:
  \_bit_var: (q), line:4:19, endln:4:20
    |vpiTypespec:
    \_bit_typespec: , line:2:5, endln:2:19
      |vpiRange:
      \_range: , line:2:9, endln:2:14
        |vpiLeftRange:
        \_constant: , line:2:10, endln:2:11
          |vpiParent:
          \_range: , line:2:9, endln:2:14
          |vpiDecompile:1
          |vpiSize:64
          |UINT:1
          |vpiConstType:9
        |vpiRightRange:
        \_constant: , line:2:12, endln:2:13
          |vpiParent:
          \_range: , line:2:9, endln:2:14
          |vpiDecompile:0
          |vpiSize:64
          |UINT:0
          |vpiConstType:9
      |vpiRange:
      \_range: , line:2:14, endln:2:19
        |vpiLeftRange:
        \_constant: , line:2:15, endln:2:16
          |vpiParent:
          \_range: , line:2:14, endln:2:19
          |vpiDecompile:3
          |vpiSize:64
          |UINT:3
          |vpiConstType:9
        |vpiRightRange:
        \_constant: , line:2:17, endln:2:18
          |vpiParent:
          \_range: , line:2:14, endln:2:19
          |vpiDecompile:0
          |vpiSize:64
          |UINT:0
          |vpiConstType:9
    |vpiName:q
  |vpiLoopVars:
  \_bit_var: (r), line:4:22, endln:4:23
    |vpiTypespec:
    \_bit_typespec: , line:2:5, endln:2:19
      |vpiRange:
      ...
    |vpiName:r
  ╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴╴┨ Missing vpiLoopVars/vpiOperation
  |vpiLoopVars:
  \_bit_var: (s), line:4:27, endln:4:28
    |vpiTypespec:
    \_bit_typespec: , line:2:5, endln:2:19
      |vpiRange:
      ...
    |vpiName:s
  |vpiStmt:
  ...

By synthesizable, I also mean that we can observe in the synthesis output if we are dealing with the design correctly end-to-end.
The example you provided is not Observable, there is no output, the Synthesis optimizes everything out so no matter how badly we model the design the formal verification or simulation will say "Good job". We need to create designs that are synthesizable and observable. So we don't have false negatives.
The modified design below fits the description above:
module top(input clk, output bit [1:0][3:0] B [3:0][2]);
    always @(posedge clk) begin
        foreach(B[q, r, , s]) begin
            B[q][r][0][s] = r;
            B[q][r][1][s] = 0;
        end
    end
endmodule

That design will generate a netlist that can be simulated of run through formal verification.

Fixed by #3241.
@mglb, please add this testcase to https://github.com/chipsalliance/UHDM-integration-tests/tree/8dc491bb51384418a41a7d2f9c30ac8e576f4619/tests
and make sure we reach formal equivalence with Yosys parser.
module top(input clk, output bit [1:0][3:0] B [3:0][2]);
    always @(posedge clk) begin
        foreach(B[q, r, , s]) begin
            B[q][r][0][s] = r;
            B[q][r][1][s] = 0;
        end
    end
endmodule


chore: add proxy support

This contains initial R&D on adding proxy support in SimpleCacheClient. It adds a proxy-aware credential provider to route gRPC calls through a proxy (currently haproxy on layer 4) to the appropriate Momento endpoints. The proxy endpoints are passed in the constructor to the credential provider and the Momento endpoints are parsed out of the JWT token as before.
An haproxy instance configured to send requests on to the Momento backend is required to successfully run the proxy-example.php example. You can add the below configuration to your haproxy.cfg (after replacing the placeholders with the actual hostnames from your JWT in the server directives) to work with the configuration expected by that script.
frontend control-plane-fe
  bind momento-control:4443
  option tcplog
  mode tcp
  default_backend control-plane-be

backend control-plane-be
  mode tcp
  server server1 [control-plane-hostname-from-JWT]:443

frontend data-plane-fe
  bind momento-cache:4444
  option tcplog
  mode tcp
  default_backend data-plane-fe

backend data-plane-fe
  mode tcp
  server server1 [data-plane-hostname-from-JWT]:443

I'll address all feedback in a followup PR coming up in just a minute.