Can this be used in prodcution

Hi Team,
I've tested this myslef and works great. My question is can I used this native migration method for a migration that I am planning on doing next month. Its a large company merge which involves moving 1500+_ mailboxes. A comment is appreciated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c61c960c-f5c3-76f7-ac18-dfeaf30230e4
Version Independent ID: 3dc607b2-869e-976f-80da-d73cfb1210e5
Content: Cross-tenant mailbox migration - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/cross-tenant-mailbox-migration.md
Product: microsoft-365-enterprise
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@deepthainf Thank you for your feedback. Of course, you can use the native migration method for the large-scale tenant-to-tenant migrations. Note that the Microsoft support team will be available 24/7 in case you have issues in the migration process.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @deepthainf Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


LHN - Tooltip appears for each workspace chat including invited member's workspace chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Device used: Mac 15.0
App Component: Left Hand Navigation (LHN)
Action Performed:

Go to staging.new.expensify.com
Log in with a new account.
Create a workspace, but do not go back to Inbox.
Go to workspace settings > Members.
Invite a few members.
Go back to Inbox.

Expected Result:
There will be only one tooltip for the workspace chat which is the admin's own workspace chat.
Actual Result:
Tooltip appears for each workspace chat including invited member's workspace chat.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/20bb4807-904e-4bb5-b4f1-8b829f7ff819
View all open jobs on GitHub

This is coming from here, I've asked the contributor to take a look.

CP'd PR just got to staging! @ishpaul777 if you have a moment, would you mind testing on staging?

amazing, thanks so much!!

closing as i believe no payment due here


New Line at the end of file (feature)

This pull request adds a new feature that allows user to configure wether they want a newline at the end of the file or not.
The intension behind this feature is to simplify the display of changes and the reduction of merge conflicts caused by some IDE formatting.
It would fix a lot of issues on one of the projects I'm working on also it seems that there is a need for it. #201
This PR is kinda similar to the PR #148 only on the current stage of this branch.
I would love to see this feature. Keep up the great work.
Let me know what you think and greetings.

Thanks @buchtadan. @biesbjerg I would love to see this feature too.

Is there something I can help with to move this PR forward? Thanks!

@buchtadan I see that you released v7.0.2-enhancedFork with your changes. Would it be possible for you to rebase your changes and release a new version targeting @angular/compiler@11 (instead of v10)? Thanks!


[Frontend] Support custom request_id from request

FILL IN THE PR DESCRIPTION HERE:
Currently, request_id is generated in function create_chat_completion, which cannot be controlled by high-level user.
In our scenario, we want to pass the custom request_id into create_chat_completion. Then, we can debug the end-to-end process  using a unique request id.
This PR simply add a field request_id to ChatCompletionRequest with a default random_uuid() value. If the user passes a request_id to the request object, the backend will use it directly. Otherwise, the backend will generate one which is the same as current behavior.
Example w/o request_id:

Example w/ request_id:

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

The PR is ready for review.

Request ID is usually passed to the header(X-Request-Id) for accessibility; otherwise model server admins should (parse and) log the response body, which is a huge burden. OpenAI also returns request id in response header, so how about supporting X-Request-Id header (on both request and response) instead?

@cjackal I can get X-Request-Id from raw_request.headers["x-request-id"]. Does that means that if the X-Request-Id is set, we can set it to response.request_id?

@cjackal I can get X-Request-Id from raw_request.headers["x-request-id"]. Does that means that if the X-Request-Id is set, we can set it to response.id?

I'd suggest to implement it. Like:
AS-IS(v0.6.3.post1): X-Request-Id in request header is not passed back to response header
$ curl -v -X POST http://localhost:8000/v1/chat/completions \
> -d '{"model":"meta-llama/Llama-3.2-1B-Instruct","messages":[{"role":"user","content":"Hi"}]}' \
> -H 'X-Request-Id: aaaa' \
> -H 'Content-Type: Application/json'
*   Trying <IP_ADDRESS>:8000...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> POST /v1/chat/completions HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.68.0
> Accept: */*
> X-Request-Id: aaaa
> Content-Type: application/json
> Content-Length: 88
>
* upload completely sent off: 88 out of 88 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< date: Tue, 22 Oct 2024 15:58:16 GMT
< server: uvicorn
< content-length: 230
< content-type: application/json
...

TO-BE:
$ curl -v -X POST http://localhost:8000/v1/chat/completions \
> -d '{"model":"meta-llama/Llama-3.2-1B-Instruct","messages":[{"role":"user","content":"Hi"}]}' \
> -H 'X-Request-Id: aaaa' \
> -H 'Content-Type: Application/json'
*   Trying <IP_ADDRESS>:8000...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> POST /v1/chat/completions HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.68.0
> Accept: */*
> X-Request-Id: aaaa
> Content-Type: application/json
> Content-Length: 88
>
* upload completely sent off: 88 out of 88 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< date: Tue, 22 Oct 2024 15:58:16 GMT
< server: uvicorn
< content-length: 230
< content-type: application/json
< x-request-id: aaa
...

This is kind of standard approach for server log correlation (production level server usually keep logging incoming/outgoing headers, so no additional cost to pay) and easy to implement (simple middleware on fastapi side).
Of course my feature request is completely orthogonal to this PR; request id in chat completion stream body is independent of the request id in the header.

@cjackal I can get X-Request-Id from raw_request.headers["x-request-id"]. Does that means that if the X-Request-Id is set, we can set it to response.id?

I'd suggest to implement it. Like:
AS-IS(v0.6.3.post1): X-Request-Id in request header is not passed back to response header
$ curl -v -X POST http://localhost:8000/v1/chat/completions \
> -d '{"model":"meta-llama/Llama-3.2-1B-Instruct","messages":[{"role":"user","content":"Hi"}]}' \
> -H 'X-Request-Id: aaaa' \
> -H 'Content-Type: Application/json'
*   Trying <IP_ADDRESS>:8000...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> POST /v1/chat/completions HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.68.0
> Accept: */*
> X-Request-Id: aaaa
> Content-Type: application/json
> Content-Length: 88
>
* upload completely sent off: 88 out of 88 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< date: Tue, 22 Oct 2024 15:58:16 GMT
< server: uvicorn
< content-length: 230
< content-type: application/json
...

TO-BE:
$ curl -v -X POST http://localhost:8000/v1/chat/completions \
> -d '{"model":"meta-llama/Llama-3.2-1B-Instruct","messages":[{"role":"user","content":"Hi"}]}' \
> -H 'X-Request-Id: aaaa' \
> -H 'Content-Type: Application/json'
*   Trying <IP_ADDRESS>:8000...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> POST /v1/chat/completions HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.68.0
> Accept: */*
> X-Request-Id: aaaa
> Content-Type: application/json
> Content-Length: 88
>
* upload completely sent off: 88 out of 88 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< date: Tue, 22 Oct 2024 15:58:16 GMT
< server: uvicorn
< content-length: 230
< content-type: application/json
< x-request-id: aaa
...

This is kind of standard approach for server log correlation (production level server usually keep logging incoming/outgoing headers, so no additional cost to pay) and easy to implement (simple middleware on fastapi side).
Of course my feature request is completely orthogonal to this PR; request id in chat completion stream body is independent of the request id in the header.

Sorry I missed this earlier. Thanks for bringing this up, can you open a new issue for this specifically so we can have a more comprehensive discussion about this?

Sorry I missed this earlier. Thanks for bringing this up, can you open a new issue for this specifically so we can have a more comprehensive discussion about this?

I should say sorry for getting off the PR and spamming notifications; issue and PR for request id header are on the way.


Create and publish a MergedManifest for unified builds

After we're done with https://github.com/dotnet/source-build/issues/4198, we'll have a VerticalManifest published for each leg. We'll need to use all of these manifests to produce a MergedManifest, similarly to how we do it currently in individual repos.
We'll need to have some custom logic for this, as multiple legs might produce duplicate assets https://github.com/dotnet/source-build/issues/4157.

Based on the discussions we had offline, we will implement a task that will be used in two scenarios:

In the join point builds, it will prepare the machine for builds, by downloading necessary assets
In the final join point it will create a merged manifest and download all assets, preparing for artifact publishing (BlobArtifacts and PackageArtifacts)

Based on these requirements, the task will do the following

The input will be the name of the "main" vertical manifest, and the list of all vertical manifests
The task will create a merged manifest by taking all artifacts from the main manifest, and then going through all other manifests and adding artifacts that are not there already
As it's going through these manifests, it will download pipeline artifacts that corelate to the entries it added to the manifest (it will always download the full main vertical, and then, for example, it takes Microsoft.NETCore.App.Crossgen2.linux-x64 from the Ubuntu2204_x64 vertical`)
The final result of this task should be a MergedManifest, and build artifacts that correlate to the entries in it. These artifacts will be used for the join point builds, or we'll publish them as BlobArtifacts and PackageArtifacts which are special artifacts that are used by the Maestro publishing pipeline. The MergedManifest will only be used in the final join point, to produce a final MergedManifest. This manifest will be passed to the PushMetadataToBuildAssetRegistry task to create a bar build

For downloading pipeline artifacts, we have two options:

Figure out which artifacts we want to download for each leg, and download them one by one
Download whole artifact legs, copy what we need, and delete the rest

The main advantage with the first approach is that we'd be downloading less amount of data, we'd be taking just what we need. But this approach also has a fatal flaw, we'd download every file individually so, we'd probably exceed our rate limit, which would cause throttling. Because of this we probably shouldn't use this approach.
The other approach flaw is that we might run out of space, since it requires downloading an artifact zip, and then unzipping it. We'd just save the packages we need, deleting the reset, and could optimize around download order to minimize this risk

The main advantage with the first approach is that we'd be downloading less amount of data, we'd be taking just what we need. But this approach also has a fatal flaw, we'd download every file individually so, we'd probably exceed our rate limit, which would cause throttling. Because of this we probably shouldn't use this approach.

We don't hit this rate limit when doing our BAR publishing today, so it's quite possible we wouldn't hit it.

we're going to pause this work for a bit, and pick it up at a later point

@mmitche in the final pass copying assets to a flat layout is having issues with productVersion.txt files - there is Sdk\9.0.100-rc.1.24414.1\productVersion.txt,  WindowsDesktop\9.0.0-rc.1.24413.5\productVersion.txt, aspnetcore\Runtime\9.0.0-rc.1.24412.15\productVersion.txt
But I see there is also Sdk\9.0.100-rc.1.24414.1\sdk-productVersion.txt,  WindowsDesktop\9.0.0-rc.1.24413.5\windowsdesktop-productVersion.txt, aspnetcore\Runtime\9.0.0-rc.1.24412.15\aspnetcore-productVersion.txt
If we have those files maybe we can just copy the first productVersion.txt? Or the SDK one?

@MichaelSimons I heard there is a limitation on testing the tasks in https://github.com/dotnet/sdk/tree/main/src/SourceBuild/content because of source-build, could you explain why is it a issue? Also is it a good place to test the join verticals functionality in the sdk build as it will be part of the sdk repo now?

The limitation is there is a lack of infrastructure for this.  The tests do not belong in the smoke tests or scenario tests.  We need a new test suite for these types of unit tests - see https://github.com/dotnet/source-build/issues/4244.

Oh jeez...I'm not sure why we produce those files. Let me dig a bit and see whether I can figure it out.

Done with https://github.com/dotnet/sdk/pull/43627


Copy-SqlDatabase.ps1 gives error

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[ ] feature
[X] bug:

System Details

Operating system name and version:
Windows Server 2008R2
Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      4.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.36373
BuildVersion                   6.3.9600.16406
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.2

Output of dbatools version:

Major  Minor  Build  Revision
-----  -----  -----  --------
0      8      947    -1

SQL Server version for source/target
10.0.5829
10.0.5829

Steps to Reproduce
Example:

Run Command:

Copy-SqlDatabase -Source SQLSource -Destination SQLDestination -Databases DBAdmin, DBDiag, DBPurge -BackupRestore -NetworkShare \\SQLDestination \SHARE

Received following error

Attempting to connect to Sql Servers..
Resolving NetBIOS names
Performing SMO version check
Checking to ensure the source isn't the same as the destination
Source and Destination Sql Servers instances are the same. Quitting.
At line:825 char:4
+             throw "Source and Destination Sql Servers instances are the same. Quitting."
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Source and Dest...same. Quitting.:String) [], RuntimeException
    + FullyQualifiedErrorId : Source and Destination Sql Servers instances are the same. Quitting.

Expected Results

Run Command:

Copy-SqlDatabase -Source SQLSource -Destination SQLDestination -Databases DBAdmin, DBDiag, DBPurge -BackupRestore -NetworkShare \\SQLDestination \SHARE```

No Errors :)

Attached screen shots/console output

Use of Start-Transcript can help collection of console output and exceptions
Provide screen shots of the output from your console if available.

Import - Attach dbatools logs

Latest release of dbatools now includes a messaging and logging system. You can find this information via the Get-DbaConfig function. Use of the Set-DbaConfig controls the configuration of the system.
Ensure this returns true: (Get-DbaConfig -Name errorlogenabled).value
Locate the log path for the error logs using this command: (Get-DbaConfig -Name dbatoollogpath).Value
Attach the latest xml and log files found in the path shown.

When testing, I used the Connect-DBASqlServer command, and it appears the code is looking for DomainInstanceName property, which for both servers returns and empty result set, making them return false.
Upgrading the 2014 SMO objects to the latest available  here :  https://www.microsoft.com/en-us/download/details.aspx?id=52676  did the trick.

I kinda recall requiring 2008 R2 minimum and then I second guessed myself. I'll up the requirements in the psm1 and just updated the website.

Well we should not be using an SMO property to determine if the source and dest are the same...obviously reason being it is not dependable. I do believe we have another issue referencing the desire to use this command with two instances on the same host, but this restricts that from happening.

Yep issue that reference this scenario is one @potatoqualitee created #329

We definitely should check to determine if they are the same - I added that check after I demolished a SQL instance during a demo.  The SQL instance was aliased so $source -ne $destination and boom, it dropped all my databases. The demo did not go well 👎 This may be the reason I recall R2 being required. R2 is so very similar, SMO wise, to 2012. Trying to find a way to get its SMO version tho.

Quickest method I see using is parsing the Assembly property from GetType()


RMS Script got stuck and it is showing as already exist

Hi Team,
I am facing an issue when I am running the RMS script that is showing already existing and fetching the logs.
So, I want to check here what can we do here for resolving this issue.
Also, still not able to see the RMS log table in our log analytic workspace in azure.
please suggest.
Attaching the screenshots also.

Hi @shubhamrsharma
Seeing the image shared, the script is working fine, but you don't have records to export, that scripts works only if you are using Sensitivity Labels with protection, in that case you will see this kind of behavior from the script:

Hi @ProfKaz
The script "MPARR-RMSData.ps1" execution is getting exit, we are using Sensitivity Labels with protection, and we do have couple number of records to export.
Can you Please provide the troubleshooting steps.
Including the screenshots of the errors.

Can you please suggest the Version of AIPService PowerShell module used?
currently we have installed <IP_ADDRESS>

Thank you.

Hi @surajpallagatti,
We can easily test if something is not working properly with the script, the script uses this cmdlet:
Get-AipServiceUserLog -Path 'C:\Logs' -FromDate 1/28/2024 -ToDate 1/31/2024 -NumberOfThreads 10
And see if that return something, you can change the path on the query, and then we can continue checking.

Hi @ProfKaz

Is "MPARR-RMSData.ps1" only subjected/Collects data/logs from AIP On-Prem Scanner labelling activity. ?
Or does it collect logs/Activity related to Microsoft Purview labelling activity (Microsoft Purview Information Protection Labelling)? or all labeling activity (AIP & MS Purview information protection)?

Thank You.

Hi @ProfKaz

Is "MPARR-RMSData.ps1" only subjected/Collects data/logs from AIP On-Prem Scanner labelling activity. ?
Or does it collect logs/Activity related to Microsoft Purview labelling activity (Microsoft Purview Information Protection Labelling)? or all labeling activity (AIP & MS Purview information protection)?

Thank You.

Hi @surajpallagatti
MPARR-RMSData script only collect the information about access denied or access granted to protected documents, and some other activities from services running in the background when you apply labels with protection. The details can be found here https://github.com/microsoft/Microsoft-Purview-Advanced-Rich-Reports-MPARR-Collector/blob/main/About MPARR/MPARR_RMSData script.md
The activities related to the scanner are collected through MPARR_Collector and stored in the AuditGeneral_CL table.


[9.4.x] ISPN-9775 - ISPN build for IBM Java ends with error in Ant execution task

Integrated into 9.4.x, thanks @andyuk1986 !


HDDS-6590. Get rid of OZONE_IMAGE env variable from upgrade compose cluster config

What changes were proposed in this pull request?
This change should get upgrade compose cluster config aligned with all other compose cluster configs. e.g. compose/ozone
This also solves a hidden "bug" where it disregards user's environment variable OZONE_RUNNER_VERSION. (Possibly because it was missing from HDDS-6293
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6590
How was this patch tested?

[x] Tested that it now respects my local OZONE_RUNNER_VERSION now, which I have set to dev to use my locally-built arm64 image.

mvn clean install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true
cd hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/compose/upgrade/compose/ha
export OZONE_RUNNER_VERSION=dev
docker-compose up -d --scale datanode=3
# Cluster should now boot up with the `dev` tagged image

/pending


Couchbase Operator Persistent Volumes

When applying according to docs couchbase-operator CR with persistent volumes, it fails to work, because it needs get and watch on persistent volumes. Persistent volumes is a cluster scope object. So this CSV is not working don't know why someone put get and watch for pv in permissions and not in clusterPermissions. Now PV CR fails to spin up cluster as necessary ClusterRole and Binding is not created.
Who provided that CSV ? Redhat included it in Openshift catalog but they as well have an OLM that does not support clusterPermissions

Hi @gacopl thanks for pointing this out, you're right that the Operator will need some clusterPermissions to do that. We'll get this updated soon.


@module-federation/enhanced should have webpack defined as an optional peerDependency

Describe the bug
My understanding is that @module-federation/enhanced can be installed to either import the webpack plugin, the rspack plugin or only the federation runtime functions.
If my understanding is correct, then I believe that the webpack peerDependency should be OPTIONAL?
Thank you,
Patrick
Reproduction
None
Used Package Manager
pnpm
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 14.54 GB / 31.70 GB
  Binaries:
    Node: 21.7.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.4 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Chrome: 124.0.6367.61
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.1

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

Yeah think it can be a peer now

Feel free to send a PR

Closing as it's been fixed in Closing as it's been fixed in https://github.com/module-federation/core/releases/tag/v0.1.11 🙏🏻


adding _index.md for docs/concepts/overview/

Adding the missing _index.md under content/it/docs/concepts/overview/ move the translated pages under the overview section

/assign @mattiaperi

@crixo great to see your first contribution to the Kubernetes web site 🥳 🍾 🎆
/approve
/lgtm


Introduce restoreMTime input

When the restoreMTime input is set to true, the action will restore the modification time of the files.

Related to #2.


[NEW ICON] Lunacy

Skill Name
lunacy
Why?
It's free design app, alternative to Figma. Also popular to web designers.
Reference Image


Replace Gitter chat link with Discord chat

Fixes #613

Pull Request Test Coverage Report for Build 1984

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 67.287%

Totals

Change from base Build 1981:
0.02%

Covered Lines:
6899

Relevant Lines:
9638

💛  - Coveralls


testTicket

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

create the testTicket


Is there any other way to get the dataset?

Thanks for open-sourcing the dataset.
I've tried many times to download the zip from the given link, but the connection keeps dropping.
I'd like to know is there any other way available, like Baiduyun or Aliyun?

Sorry for the inconvenience. Since we do not have Baiduyun and Aliyun accounts, Google Drive is the only way to download it.


redis: general purpose redis plugin

server is exported to the plugin sandbox explicitly.

Thanks, didn't realize that. PR is updated.

No problemo!

It seems specifying db = xx doesn't work for redis plugin itself.


WIP Add amp-mathml shortcode

Resolves #130
This PR adds the amp-html library to render math formulas, and adds a shortcode to use in markdown files.
AMP lib docs: https://amp.dev/documentation/components/amp-mathml/

looks good, however, we need to apply the same fix on the rest of the doc
@cdeleeuwe can you do it or do you need that someone in the team manages it?

@moul sure, I can do that, no problem

@moul done.


Issues about label dimension

Hi, @omoindrot
Thanks for sharing your code! And I am right now crafting a small project using triplet loss.
I've cloned the code, run it, and all fine. But when applying to my code, in a mini-batch context, code went crack at this line. The shapes of tensors were examined and compared to this mnist example. I found  dimension of label is the most possible reason.
Hope you could shed me some light. I am really stucked.... Thanks in advance.
Following is the error message I got:
ValueError: Dimensions must be equal, but are 82398 and 100 for 'Mul' (op: 'Mul') with input shapes: [100,100,100,82398], [100,100,100].

Next the shapes of tensors:
In my code (batch_size is 100, number of classes is 82398):
NFO:tensorflow:pairwise_dist: (100, 100)
INFO:tensorflow:labels: (100, 82398)
INFO:tensorflow:embeddings: (100, 512)
INFO:tensorflow:anchor_p_dist: (100, 100, 1)
INFO:tensorflow:anchor_n_dist: (100, 1, 100)
INFO:tensorflow:indices_equal: (?, ?)
INFO:tensorflow:indices_not_equal: (?, ?)
INFO:tensorflow:i_not_equal_j: (?, ?, 1)
INFO:tensorflow:i_not_equal_k: (?, 1, ?)
INFO:tensorflow:j_not_equal_k: (1, ?, ?)
INFO:tensorflow:label_equal: (100, 100, 82398)
INFO:tensorflow:i_equal_j: (100, 100, 1, 82398)
INFO:tensorflow:i_equal_k: (100, 1, 100, 82398)
INFO:tensorflow:distinct_indices: (?, ?, ?)
INFO:tensorflow:valid_labels: (100, 100, 100, 82398)
INFO:tensorflow:mask: (100, 100, 100, 82398)
INFO:tensorflow:triplet_loss: (100, 100, 100)

In your code:
INFO:tensorflow:pairwise_dist: (?, ?)
INFO:tensorflow:labels: (?,)
INFO:tensorflow:embeddings: (?, 64)
INFO:tensorflow:anchor_p_dist: (?, ?, 1)
INFO:tensorflow:anchor_n_dist: (?, 1, ?)
INFO:tensorflow:indices_equal: (?, ?)
INFO:tensorflow:indices_not_equal: (?, ?)
INFO:tensorflow:i_not_equal_j: (?, ?, 1)
INFO:tensorflow:i_not_equal_k: (?, 1, ?)
INFO:tensorflow:j_not_equal_k: (1, ?, ?)
INFO:tensorflow:label_equal: (?, ?)
INFO:tensorflow:i_equal_j: (?, ?, 1)
INFO:tensorflow:i_equal_k: (?, 1, ?)
INFO:tensorflow:distinct_indices: (?, ?, ?)
INFO:tensorflow:valid_labels: (?, ?, ?)
INFO:tensorflow:mask: (?, ?, ?)
INFO:tensorflow:triplet_loss: (?, ?, ?)

I guess your labels are in one-hot format, with shape (100, 82398).
In my code the labels are in integer format like this:
labels = [1, 9, 3, 2, 4, 5, ...]

Also if you have a high number of classes you need to make sure to have multiple instances of the same class in your batch (otherwise no triplet will be found).

cf. issue #7 for the idea of balanced batches

I guess your labels are in one-hot format, with shape (100, 82398).

Yes, you are right, labels in my code is in one-hot format.

In my code the labels are in integer format like this:
labels = [1, 9, 3, 2, 4, 5, ...]

I get it. :)

Also if you have a high number of classes you need to make sure to have multiple instances of the same class in your batch (otherwise no triplet will be found).
I generated sample list and load them every batch_size line. Thanks for your reminder. :)

cf. issue #7 for the idea of balanced batches

Thanks for your pointer and I will be back once this issue get solved.

@omoindrot , I'd solved this problem in my code and all seems fine right now. Just before one_hot_encoding, the labels vector is in original form, which is required from triplet loss functions.


UI: Add receive view

Refactor: Modify Wallet View to use Navigation Stack
UI: Add send and receive buttons
UI: Add receive View

Very nice!


Delete obsolete  CONTRIBUTING content

This seems like it's still relevant? The triage team still exists and it's doing it's job?

The link failed

The link is still valid. It is only valid for members of the bevyengine organization. GIthub doesn't allow seeing teams for organizations you are not a member of.

It might be a good idea to move the links. These links will be dead (and confusing) to any first-time contributor who (hopefully) reads the CONTRIBUTING.md and tries to use them.
But the links are useful.
So. Is there a sensible place these links could be put, where only the members of the organisation can see them?

Yeah I'm open to rephrasing this in a way that calls out how org members can request team membership without actually linking to the team.

Feel free to PR something if you have the inclination!


sortBy . comparing → sortOn

Evening
I discovered sortOn yesterday and rushed to see if it's in hlint yet. 7e775ed was made 16 hours prior but it doesn't appear to suggest «the Schwartzian transform» itself. I'm not sure if I missed anything but it's added in this PR. Applied to the source of hlint itself as well.

Thanks! Good catch.


esp32_devkitc_wrover board error

I have encountered an issue with the Zephyr ESP32 support page. After following the provided steps esp32_devkitc_wrover and choosing the 'esp32_devkitc_wroover' board, I encountered an 'Invalid Board' error during the build process. It's worth noting that I have successfully built projects with 'nucleo_f446re' and 'esp32' without any issues.
I would appreciate any assistance in resolving this matter and understanding why the 'esp32_devkitc_wroover' option is not appearing as expected.
To Reproduce Steps to reproduce the behavior:
west build -b esp32_devkitc_wrover samples/hello_world -p
Expected behavior Build successfully without errors.
Logs and console output :
xtensa:
esp32
esp32_ethernet_kit
esp32_net
esp32s2_franzininho
esp32s2_saola
esp32s3_devkitm
esp_wrover_kit
heltec_wifi_lora32_v2
intel_adsp_ace15_mtpm
intel_adsp_ace20_lnl
intel_adsp_cavs25
intel_adsp_cavs25_tgph
m5stickc_plus
nxp_adsp_imx8
nxp_adsp_imx8m
nxp_adsp_imx8x
odroid_go
olimex_esp32_evb
qemu_xtensa
xiao_esp32s3
xt-sim
CMake Error at /home/nagendra/zephyrproject/zephyr/cmake/modules/boards.cmake:163 (message):
Invalid BOARD; see above.
Call Stack (most recent call first):
/home/nagendra/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:75 (include)
/home/nagendra/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
CMakeLists.txt:23 (find_package)
-- Configuring incomplete, errors occurred!
FATAL ERROR: command exited with status 1: /usr/bin/cmake -DWEST_PYTHON=/usr/bin/python3 -B/home/nagendra/zephyrproject/zephyr/build -GNinja -DBOARD=esp32_devkitc_wrover -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -S/home/nagendra/zephyrproject/zephyr/share/sysbuild -DAPP_DIR:PATH=/home/nagendra/zephyrproject/zephyr/samples/hello_world
Environment:
OS: ( Ubuntu 22.04.3 LTS )
Toolchain : (Zephyr SDK)

Please use our bug template when reporting bugs. You need to edit this issue to include the information requested in https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/001_bug_report.md
We especially need to know which version of Zephyr, you are using.

@knagendrababu, which Zephyr revision you have been working with?  esp32_devkitc_wrover is available only in v3.5.0 revision. Before that, I think it is just esp32or esp_wrover_kit.

It is 3.4.99
~/zephyrproject/zephyr$ cat VERSION
VERSION_MAJOR = 3
VERSION_MINOR = 4
PATCHLEVEL = 99
VERSION_TWEAK = 0
EXTRAVERSION =

Would you try compiling for board esp_wrover_kit?

Fresh installation working well.
west build -b esp32_devkitc_wrover --sysbuild samples/hello_world
Understand that the esp32_devkitc_wrover board was added in the Zephyr 3.5 version only.
@sylvioalves Thanks for your support

Great it worked. Feel free to ask.


Added two programs on concatenation

I have added two programs on concatenation. Beside this I have also added Observation.txt just for your reference.
Observation.txt

Hi.
Yes, the Java code has a name for reference only. In fact, it does not even have the .java extension. This is done so that it can be displayed on the page. In any case, the site (https://gersonlazaro.com/learn-x-if-you-know-y/) does not show file names, to avoid confusion. Thank you for your observation and for the examples provided.


Move construction of UserNewsResource into separate function

I will fix the failing UI tests on the mm/chipcolor branch


Fix tslint path in package.json

Fix tslint path. Issue in https://github.com/palantir/tslint/issues/1664

Hi @samtux can you confirm this work with the fixed tslint version of master ?


Update readme

Are we also planning to include an 8xv4-128.sh file that repros your performance?

That's a good idea, added it.


Jumper Issue

I Read about there was a fix for jumper and For me it still won’t work please help

You need to install the tweak "ShortcutEnabler" as-well.

Thanks


libspdm_device_send_message_func should be called with the timeout parameter

Some BMC MCTP implementations are atomic, with send and receive as a single "transaction".
libspdm libspdm_register_device_io_func() splits these into two operations, each of which has a timeout parameter.  However, the timeout provided to the send libspdm_device_send_message_func is only the RTT time, whereas the timeout provided to the receive libspdm_device_receive_message_func is the full calculated CT exponent time.
Instead, the full RTT+(ST1 or CTexp) time should be provided to the libspdm_device_send_message_func.  For MCTP implementations which split send and receive, this should have no effect, as sends do not even use timeouts.

libspdm_device_send_message_func can query LIBSPDM_DATA_CAPABILITY_CT_EXPONENT

But that wouldn't actually be correct, because CT_EXPONENT is supposed to only apply to certain transactions, specifically when context->crypto_request true.  But external to libspdm, spdm_context is a (void *) and there is no knowledge of whether the request being sent is a crypto request or not.
When sending messages there is actually no such thing as a timeout - timeouts are only for measuring responses.  But the API for send includes a timeout, presumably to enable just this type of atomic transaction model - except for the fact that the timeout provided to to context->send_message() differ from the timeout provided to context->receive_message()

When sending messages there is actually no such thing as a timeout - timeouts are only for measuring responses.

There are transports where the receiver acknowledges to the sender that it has received the message. For example PCIE non-posted writes. In such a case the sender can enforce a timeout on just sending the message. But RTT isn't the "right" value for that timeout.

But that wouldn't actually be correct, because CT_EXPONENT is supposed to only apply to certain transactions,

Pragmatically speaking if the value of CT is 1 s, can't you use that as a timeout for all messages? Even more pragmatically speaking, can't you use a fixed timeout value regardless of the value of CT? For example, if the value of CT is 10 minutes the BMC probably won't wait 10 minutes for a reply. It'll wait like, 5 seconds at most.
Maybe libspdm_device_send_message_func and libspdm_device_acquire_sender_buffer_func can include a new parameter that specifies the type of message being sent / received. Then the functions can use that information, as well as CT and ST1 and RTT to figure things out if it wants.

@raghuncstate is doing BMC stuff as well. Maybe he can weigh in.

Need to add documentation in libspdm_device_send_message_func that RTT is a worst-case timeout. The implementor of the function is free to reduce the timeout based on transport knowledge / specifications.

LIBSPDM_DATA_CAPABILITY_RTT_US needs to be documented in https://github.com/DMTF/libspdm/blob/main/doc/api/common_api.md.

Looks like it's already there, only it's called LIBSPDM_DATA_CAPABILITY_RTT. Will rename it in the pull request.


feat: external subtitle track & audio track support

feat: expose SubtitleTrack.external & AudioTrack.external
refactor: libmpvPlayer -> NativePlayer & webPlayer -> WebPlayer

Requesting a review.
On web, one can load WebVTT as String directly as-well:
https://github.com/alexmercerind/media_kit/blob/3adca06df1f6dc565ab6e3ba0306441ea4681eb5/media_kit/test/src/player/player_test.dart#L3124-L3375
I felt it is important since loading WebVTT subtitles from other domains is restricted (CORS).
A better approach could've been adding a new factory constructor to SubtitleTrack for loading external subtitle as String to the native backend too. But, in the end we would have to save it to a temporary file & then feed it into libmpv + how many people are going to use it. This would also require a (massive at the moment) of fetching temporary directory (& permissions?) in our Dart-only root media_kit package.

The tests should pass (probably).

On web, one can load WebVTT as String directly as-well:
I felt it is important since loading WebVTT subtitles from other domains is restricted (CORS).

I think it's a bad idea for two reasons:

It's confusing because only implemented on the web…
…since internally it only takes a few lines to create a temporary URL from a raw string, an example in the documentation to web developers is enough

In any case, if you plan to keep support for loading subtitles as raw string, you need to add a mechanism for revoking created urls, otherwise this will cause memory leaks:
final blob = html.Blob([webVTTString]);
final url = html.Url.createObjectUrlFromBlob(blob);
html.Url.revokeObjectUrl(url);


Update / endpoint to 0.4

version should be renamed to api_version
backend_version should be added
title should be added
description should be added
https://open-eo.github.io/openeo-api/apireference/#tag/Capabilities/paths/~1/get

backend_version is tricky, because it must change for every change in the back-end. This could be based on the commit, but our back-end also depends on some key external packages, so not straightforward to track those changes too.

Relevant: https://github.com/Open-EO/openeo-api/issues/195

We should also think about moving the / endpoint to the capabilities service

We should also think about moving the / endpoint to the capabilities service

Yes, this has been implemented in recent updates.
Also, the original comments were already incorporated time ago, closing.


swipout's child view can't response onPress envent in android system

swipout's child view can't response onPress envent in android system,but it's ok in ios

{doSomething}}/> // do not work in android but it's ok in ios

try version 2.1.1 @solitaire12 , if you have any problems, please reopen issue

I just published extension of Swipeout to make it works like Android behavior on Android.
Try this.
https://www.npmjs.com/package/react-native-swipeout-longpressforandroid


⚠ Bofrost.de has degraded performance

In c3eaf9a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1241 ms

Resolved: Bofrost.de performance has improved in 6895579.


Use system reset for MIMXRT1170

Today's MIMXRT1170 debug sequence only intends on supporting the Cortex M7. To simplify that core's support, the PR removes the Cortex M4 from the target. We could later add support for this second core, and the removal commit has notes about how that might work.
The PR updates the reset sequence for the MIMXRT1170. The sequence affects a system reset that passes through the boot ROM. The reset process assumes that the user is resetting into a program available to FlexSPI1.
Similar to #1771, this sequence needs to be aware that the debug port is disabled after a system reset. The first commit suggests a way to re-initialize the debug port, and the last commit puts it to use. This seems to work for my chip, but I'm looking for feedback to know if I did it right.
Closes #1971. I tested against that Rust program using probe-rs run and the VSCode extension. The newly-flashed program runs after programming, and I could place breakpoints in main. Note that I'm testing directly against the main branch. I also flashed simple programs built from NXP's SDK.

Sorry for the ping but I think I'd like to hear @cstrahan's opinion. As I don't have any of these devices, I can only rely on others' words on what's going on here. I otherwise have no objections I think but that means precious little here :)

It might also help if @scalarion, the reporter of #1971, chimed in. We know that Hannes has appropriate hardware. Hannes, could you leave some feedback for us?

It might also help if @scalarion, the reporter of #1971, chimed in. We know that Hannes has appropriate hardware. Hannes, could you leave some feedback for us?

My initial tests were successful, i.e., I could step debug a small led-switching test program.

Can confirm the reset sequence works now on my MIMXRT1170-EVKB
git fetch origin pull/2387/head:MIMXRT1170
git checkout MIMXRT1170
cargo install --path probe-rs --features cli
probe-rs --version: probe-rs 0.23.0 (git commit: v0.22.0-245-g9186dacd)

+1 for this PR, it works on the TI devices that I am working with over in https://github.com/probe-rs/probe-rs/pull/1771

@bugadani sorry, missed the ping -- I've been super busy working on my funemployed -> employed transition.
I don't (yet) have a 1170 so I don't have anything constructive to say, other than: I'm always happy to see (and thankful for) @mciantyre's NXP work, whether here in probe-rs or elsewhere 🙏.


.NET 7: LibraryImportAttribute

From P/Invoke source generation | Microsoft Docs:

.NET 7 introduces a source generator for P/Invokes in C# which recognizes the LibraryImportAttribute.

.NET adoption is all over the place in terms of versions (a lot of people stuck with old Framework versions), but LibraryImportAttribute could reduce the overhead. This could be especially good for a future alternative API that would mirror dss::obj. For the moment we're already faster than the COM implementation in a lot of the API.
.NET 7 is still in the preview stage, so we have time to test before the final release (expected by the end of the year).

Related: https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/

Turns out just using LibraryImport doesn't actually help much for DSS Sharp. The reason is that we already migrated to DSS C-API's GR interface, which API buffers to optimize some operations.
Allowing something like ArrayPool would also be nice but I don't see it fitting in the current ("classic") API.
Source generators still might be useful for our future plans, including the new API. But, since there are thousands of functions in the API, we have to weight the benefits, that is, if the assembly gets too bloated, it will actually be slower. That's another issue though, so closing this for now.
For numeric data DSS Sharp was already quite faster than using the COM DLL (or OpenDSSDirect.DLL) due to the architecture of the official APIs, so this is not really a point of concern.


Segwit support

Work in progress, still needs review, please don't use until this is merged & backend supports it too, you will have a bad time
adds:
support for P2SH|P2WSH segwit scripts
better size estimation
manage address types using wallet chain field in bip32path.
tests cover most of the spend/receive cases, and stuff like paying to bech32 addresses

A new inspection was created.

cancelled travis tests, review pls :)

The inspection completed: 10 new issues, 37 updated code elements

A new inspection was created.

The inspection completed: 9 new issues, 40 updated code elements

A new inspection was created.

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements

A new inspection was created.

The inspection completed: 8 new issues, 40 updated code elements


Add new graphics section for logos and graphics

This is for extending with new logos and graphics. Adds a new page to the build process and adds a "Logos / Graphics" menu item to "Community". This PR is incomplete, and will be updated with logos and other image assets soon.

[x] Add new graphics page to docker build pipeline.
[x] Add meta tags for new page.
[x] Add entries to en.yml for translation.
[ ] Add logo and image assets.

Closing this, a new more complete PR based on this is already being worked on.


Remove unnecessary instruction array from Warrior

Remove unneccesary instruction array from Warrior class - see #41

Seems sensible!


MissingPluginException in Integration Tests

I am trying to write an integration test that ultimately makes a call to TextRecognizer().processImage(inputImage), but it ultimately fails with
MissingPluginException(No implementation found for method vision#startTextRecognizer on channel google_mlkit_text_recognizer)
To Reproduce
Code Sample
Steps to reproduce the behavior:

Run the Integration test
See error

Expected behavior
I expected the integration test to run so that I am able to fully call my function static Future<String> processImage(InputImage inputImage) async {}.
Screenshots
image_utils.dart

Platform (please complete the following information):

OS: Web? (Integration Test)
Device: N/A
OS: N/A
Flutter/Dart Version [e.g. 22] 3.22.1
Plugin version ^0.11.0

This is in our README:

Also, in the pub.dev website:


Support for .Net Core 2.2

In attempt to add CppSharp reference to a .Net Core console project (2.2) the following warning is given:
Warning	NU1701	Package 'CppSharp 0.10.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project

Is this lib compatible with .Net Core (2.2) ?

+1. I also would like to know if this package will support netcore 2.2.

The published packages are not fully compatible with .NET Core yet.
I don't think there's much work left to do here, I did most of the bulk work on the .NET Core port a couple months back, but still there's final work to get things integrated and publishing the packages.


Move methods to obtain qualification translations

A small tweak, cleanup of #128. Methods to obtain qualifications don't need to be nested under radioButtons as they're used outside of the radio buttons e.g. on the show Profession page.

/rebase


feat(htn): Add support for exporting hierarchical problems to HDDL

This PR extends the PDDLWriter to correctly handle hierarchical problem, using the HDDL extension of PDDL.
fix #506

Codecov Report
Attention: Patch coverage is 87.73585% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (b6f716b) to head (574ee43).

Files
Patch %
Lines

unified_planning/io/pddl_writer.py
84.52%
13 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   85.13%   85.17%   +0.04%
==========================================
  Files         201      201
  Lines       26989    27077      +88
==========================================
+ Hits        22977    23064      +87
- Misses       4012     4013       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM!


Optimistion: Stop calling strftime a million times

Its simple really, @Samathy, stop it. You know better.

Fixed in #13


When Duplicate entry of domain curl any domain return 404

Bug description

Inadvertently posted the wrong configuration causing two domain names inside the route, curl any domain will return 404
Expected behavior
return ALLOW_ANY/REGISTRY_ONLY 200/502
Steps to reproduce the bug
publish double gateway + virtualservice
Version (include the output of istioctl version --remote and kubectl version)
1.1.5
How was Istio installed?
helm
Environment where bug was observed (cloud vendor, OS, etc)
aliyun
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Can you provide the Gateway config that is doubled? We had very similar issue in https://github.com/istio/istio/pull/13731 fixed in 1.1.5. Do you see the pilot_total_rejected_configs metric incremented?


Storage layout

Related to https://github.com/dojoengine/dojo/issues/1669.
[Work in progress]
from namehash branch rebased to main to have the dojo::model attribute.

As the storage-layout branch on Dojo repo contains what has been done in this PR, I close it.


"Size" prop is not passed from command bar through from CommandBar to Chakra Modal

It would be helpful for building more complex command/search experiences if we could render a wider CommandBar element. The most obvious solution seems to use the "size" property on Chakra Modal but this isn't passed through from CommandBar.
It's also not possible to alter the size or appearance of the modal itself via style props because CommandBar doesn't accept an "sx" prop and the "container" style part is inside the modal.

Thanks for the feedback @adamstoffel , that shouldn't be to hard to support, I will implement it 👍

This is now available in 0.4.1. You can adjust the command dialog style using the CommandBarContent component.


Still need to import C to consume this package?

Hey there, I'm just learning about cgo from your terrific blog post on the topic.
I'm wondering if this line in the readme is still relevant?


v0.2.5

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@h-vetinari Somehow the bot is not grabbing v0.2.5 even though it's been out for a couple days, so here's an update since I have a different package waiting on this. Side note the badge is showing 0.2.3 even though history shows you've merged in 0.2.4, not sure what gives... Thanks for taking a look!


Prepare for release

We are ready to do another release. Please add here any issues/concerns.
The release need to happen for the SDKs as well and also be reflected on website.

@tsurdilo do you have a date in mind? I'll take some time off to work on the SDK then, so we could have more to offer in this new version.

@ricardozanini was hoping for end of the month if possible. I think for release its enough just to update the Go SDK to the latest version of the json schema. WDYT?

I think it's fine! I'll work on the SDK at the end of this week. We should be fine for the release!

I'd like to propose the release candidate: 1.0.0-rc.1
What do you guys think?

It feels awkward going from 0.1 straight to 1.0. I'm trying to understand why the bump. If it's for marketing, why would now be a good time? Could maybe KubeCon NA on 17 Nov be a good target? We could bump to 0.2 now and assemble a major release until 9 Nov - our last call just before KubeCon. Until then we have two more calls in Sep and two more in Oct according to our current schedule.

On today's community call we discussed options.
Of course, spec is different from software releases.
Generally, version 1.0 often marks the first "complete" set of features that provides a usable version.
Major release numbers are typically bumped when a lot of changes have led to a version that does not provide backwards compatibility.
We have indeed changed enough to say that the major version number should be increased (0->1)
Also, the current status provides a usable set of features, so it can be considered complete enough and out of the draft status.
So, skipping 0.2 and going straight to 1.0 sounds reasonable.
The timing would be best some time before kubecon na, and at best we'd want to use as many channels as possible to announce the 1.0 release, so we can stage release candidates with feature freeze and sufficient time for bugfixing to finish the release some time in October or before Nov 17 latest.
So now, we need a schedule aligned with our community calls :-) any suggestions?


Dartium snaps when used with WebStorm livereload plugin

As soon as I change the HTML in WebStorm Dartium snaps.
This is a simple WebStorm project without any Dart code and not even a pubspec.yaml
Just a directory example1 with index.html and index.css

Chromium	45.0.2454.104 (Developer Build) (64-bit)
Revision	b16942297fc65fd478c6f46afd1c3aaecde77009
OS	Linux
Blink	537.36 (@abaaf1d0b6b6483140b5dca34e80fc259833ddf7)

Do you mean the LiveEdit plugin? That says it's only supported in Chrome, and I suspect that it requires a more recent version of Chrome than Dartium is currently at.

Right "LiveEdit". I haven't seen that information about the Chrome version. If it is not supposed to work then the issue can be closed. I just thought it should not snap.

Request to support LiveEdit in Dartium was closed without a fix (#6035), it is not supported and not planned.

Just to clarify: Actually this was not a request to support LiveEdit. I just tried it and it with Dartium and it made Dartium snap. That is what I think shouldn't happen.
If you don't plan to do anything about it just ignore my comment.
I guess Dartium will be updated to a newer Chrome version eventually anyway.

Ok, let Dart team decide what to do with Dartium crash.

Please re-try with Dart 1.24.2 Stable (Dartium 50).


Matches the Theta interface of the Java implementation

I recently started integrating DataSketches Theta into Apache Impala and need to add matching methods in the Java implementation.
https://github.com/apache/datasketches-java/blob/master/src/main/java/org/apache/datasketches/theta/Union.java

It seems that this change breaks something in Python wrapper.
I never liked this mixed union functionality. In my view it is just unnecessary complexity. That is why I did not implement it in C++.
There is a complication: we have a new implementation of Theta sketch, which was developed as a part of Tuple sketch effort. The goal was to have a common base for both Theta and Tuple sketches. Currently this new Theta sketch implementation is sitting under Tuple sketch as experimental. I think it is time to make the move: replace the existing Theta sketch with this new implementation. I think it would be better to make sure that your integration works with this new version.
Perhaps we could add these update methods to the Theta and Tuple unions, but I still think that they are not necessary.

It seems that this change breaks something in Python wrapper.
I never liked this mixed union functionality. In my view it is just unnecessary complexity. That is why I did not implement it in C++.
There is a complication: we have a new implementation of Theta sketch, which was developed as a part of Tuple sketch effort. The goal was to have a common base for both Theta and Tuple sketches. Currently this new Theta sketch implementation is sitting under Tuple sketch as experimental. I think it is time to make the move: replace the existing Theta sketch with this new implementation. I think it would be better to make sure that your integration works with this new version.
Perhaps we could add these update methods to the Theta and Tuple unions, but I still think that they are not necessary.

It seems that this change breaks something in Python wrapper.
I never liked this mixed union functionality. In my view it is just unnecessary complexity. That is why I did not implement it in C++.
There is a complication: we have a new implementation of Theta sketch, which was developed as a part of Tuple sketch effort. The goal was to have a common base for both Theta and Tuple sketches. Currently this new Theta sketch implementation is sitting under Tuple sketch as experimental. I think it is time to make the move: replace the existing Theta sketch with this new implementation. I think it would be better to make sure that your integration works with this new version.
Perhaps we could add these update methods to the Theta and Tuple unions, but I still think that they are not necessary.

thx reply.
Use udaf function to integrate theta into impala. This function mainly affects the function logic of the merge phase.
I found a solution, but the code doesn't look very elegant, I will test the performance and reply again。
Merge function:
The dst parameter is used to store intermediate results and is initialized in the init phase

use update_theta_sketch and theta_union

void AggregateFunctions::DsThetaMerge(
    FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK(dst->len == sizeof(datasketches::update_theta_sketch)
      or dst->len == sizeof(datasketches::compact_theta_sketch));
  auto src_sketch = datasketches::theta_sketch::deserialize((void*)src.ptr, src.len);
  if (src_sketch->is_empty()) return;

  auto dst_sketch_ptr = reinterpret_cast<datasketches::theta_sketch*>(dst->ptr);

  datasketches::theta_union union_sketch = datasketches::theta_union::builder().build();
  union_sketch.update(*src_sketch);
  union_sketch.update(*dst_sketch_ptr);

  // Note, Union_result may be inconsistent with dst and needs to reallocate space
  const datasketches::compact_theta_sketch union_result = union_sketch.get_result();
  ctx->Reallocate(dst->ptr, sizeof(datasketches::compact_theta_sketch));
  if (LIKELY(dst->ptr != NULL)) {
    memset(dst->ptr, 0, sizeof(datasketches::compact_theta_sketch));
    datasketches::compact_theta_sketch* sketch_ptr =
        reinterpret_cast<datasketches::compact_theta_sketch*>(dst->ptr);
    std::uninitialized_fill_n(sketch_ptr, 1, union_result);
  } else {
    DCHECK(!ctx->impl()->state()->GetQueryStatus().ok());
  }
}

use theta_union(need add new update functionality)

void AggregateFunctions::DsThetaMerge(
    FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));

  // Note, 'src' is a serialized compact_theta_sketch and not a serialized theta_union.
  auto src_sketch =
      datasketches::compact_theta_sketch::deserialize((void*)src.ptr, src.len);

  datasketches::theta_union* dst_union_ptr =
      reinterpret_cast<datasketches::theta_union*>(dst->ptr);

  dst_union_ptr->update(src_sketch);
}

It seems that this change breaks something in Python wrapper.
I never liked this mixed union functionality. In my view it is just unnecessary complexity. That is why I did not implement it in C++.
There is a complication: we have a new implementation of Theta sketch, which was developed as a part of Tuple sketch effort. The goal was to have a common base for both Theta and Tuple sketches. Currently this new Theta sketch implementation is sitting under Tuple sketch as experimental. I think it is time to make the move: replace the existing Theta sketch with this new implementation. I think it would be better to make sure that your integration works with this new version.
Perhaps we could add these update methods to the Theta and Tuple unions, but I still think that they are not necessary.

thx reply.
Use udaf function to integrate theta into impala. This function mainly affects the function logic of the merge phase.
I found a solution, but the code doesn't look very elegant, I will test the performance and reply again。
Merge function:
The dst parameter is used to store intermediate results and is initialized in the init phase

use update_theta_sketch and theta_union

void AggregateFunctions::DsThetaMerge(
    FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK(dst->len == sizeof(datasketches::update_theta_sketch)
      or dst->len == sizeof(datasketches::compact_theta_sketch));
  auto src_sketch = datasketches::theta_sketch::deserialize((void*)src.ptr, src.len);
  if (src_sketch->is_empty()) return;

  auto dst_sketch_ptr = reinterpret_cast<datasketches::theta_sketch*>(dst->ptr);

  datasketches::theta_union union_sketch = datasketches::theta_union::builder().build();
  union_sketch.update(*src_sketch);
  union_sketch.update(*dst_sketch_ptr);

  // Note, Union_result may be inconsistent with dst and needs to reallocate space
  const datasketches::compact_theta_sketch union_result = union_sketch.get_result();
  ctx->Reallocate(dst->ptr, sizeof(datasketches::compact_theta_sketch));
  if (LIKELY(dst->ptr != NULL)) {
    memset(dst->ptr, 0, sizeof(datasketches::compact_theta_sketch));
    datasketches::compact_theta_sketch* sketch_ptr =
        reinterpret_cast<datasketches::compact_theta_sketch*>(dst->ptr);
    std::uninitialized_fill_n(sketch_ptr, 1, union_result);
  } else {
    DCHECK(!ctx->impl()->state()->GetQueryStatus().ok());
  }
}

use theta_union(need add new update functionality)

void AggregateFunctions::DsThetaMerge(
    FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));

  // Note, 'src' is a serialized compact_theta_sketch and not a serialized theta_union.
  auto src_sketch =
      datasketches::compact_theta_sketch::deserialize((void*)src.ptr, src.len);

  datasketches::theta_union* dst_union_ptr =
      reinterpret_cast<datasketches::theta_union*>(dst->ptr);

  dst_union_ptr->update(src_sketch);
}

The reason for submitting this pull is that the intermediate result (dst) can only initialize one type (eg: update_theta_sketch), and theta_union.get_result() returns compact_theta_sketch. This type is inconsistent with the initialization type (update_theta_sketch), and the merge phase needs to reallocate space each time.
Observing that datasketches-hive is implemented with union, which led to the idea of adding a new update function to theta_union and using theta_union to implement the ds_theta_sketch().
https://github.com/apache/datasketches-hive/blob/master/src/main/java/org/apache/datasketches/hive/theta/DataToSketchUDAF.java#L126
https://github.com/apache/datasketches-hive/blob/master/src/main/java/org/apache/datasketches/hive/theta/UnionState.java#L66
The new update function added in theta_union is used in the update phase。
Complete Code:
Note: use update_theta_sketch is similar to this but the merge phase code is different.
// Init phase：Initialize intermediate results (dst) for merge and update phase
void AggregateFunctions::DsThetaInit(FunctionContext* ctx, StringVal* dst) {
  // Allocate space
  AllocBuffer(ctx, dst, sizeof(datasketches::theta_union));
  if (UNLIKELY(dst->is_null)) {
    DCHECK(!ctx->impl()->state()->GetQueryStatus().ok());
    return;
  }
  // Constructs object initialization memor
  datasketches::theta_union* sketch_ptr =  reinterpret_cast<datasketches::theta_union*>(dst->ptr);
  datasketches::theta_union sketch = datasketches::theta_union::builder().build();
  std::uninitialized_fill_n(sketch_ptr, 1, sketch);
}

// Update phase
template <typename T>
void AggregateFunctions::DsThetaUpdate(FunctionContext* ctx, const T& src, StringVal* dst) {
  if (src.is_null) return;
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));
  datasketches::theta_union* sketch_ptr = reinterpret_cast<datasketches::theta_union*>(dst->ptr);
  // need add new update functionality in theta_union
  sketch_ptr->update(src.val);
}

// Serialize phase
StringVal AggregateFunctions::DsThetaSerialize(FunctionContext* ctx, const StringVal& src) {
  DCHECK(!src.is_null);
  DCHECK_EQ(src.len, sizeof(datasketches::theta_union));
  datasketches::theta_union* union_ptr = reinterpret_cast<datasketches::theta_union*>(src.ptr);
  StringVal dst = SerializeDsThetaUnion(ctx, *union_ptr);
  ctx->Free(src.ptr);
  return dst;
}

// Merge phase
void AggregateFunctions::DsThetaMerge(FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));

  // Note, 'src' is a serialized compact_theta_sketch and not a serialized theta_union.
  auto src_sketch =  datasketches::compact_theta_sketch::deserialize((void*)src.ptr, src.len);

  datasketches::theta_union* dst_union_ptr = reinterpret_cast<datasketches::theta_union*>(dst->ptr);

  dst_union_ptr->update(src_sketch);
}

// Finalize phase, return estimate value.
BigIntVal AggregateFunctions::DsThetaFinalize(FunctionContext* ctx, const StringVal& src) {
  DCHECK(!src.is_null);
  DCHECK_EQ(src.len, sizeof(datasketches::theta_union));
  datasketches::theta_union* sketch_ptr = reinterpret_cast<datasketches::theta_union*>(src.ptr);
  auto sketch = sketch_ptr->get_result();
  ctx->Free(src.ptr);
  return sketch.get_estimate();
}

The reason for submitting this pull is that the intermediate result (dst) can only initialize one type (eg: update_theta_sketch), and theta_union.get_result() returns compact_theta_sketch. This type is inconsistent with the initialization type (update_theta_sketch), and the merge phase needs to reallocate space each time.
Observing that datasketches-hive is implemented with union, which led to the idea of adding a new update function to theta_union and using theta_union to implement the ds_theta_sketch().
https://github.com/apache/datasketches-hive/blob/master/src/main/java/org/apache/datasketches/hive/theta/DataToSketchUDAF.java#L126
https://github.com/apache/datasketches-hive/blob/master/src/main/java/org/apache/datasketches/hive/theta/UnionState.java#L66
The new update function added in theta_union is used in the update phase。
Complete Code:
Note: use update_theta_sketch is similar to this but the merge phase code is different.
// Init phase：Initialize intermediate results (dst) for merge and update phase
void AggregateFunctions::DsThetaInit(FunctionContext* ctx, StringVal* dst) {
  // Allocate space
  AllocBuffer(ctx, dst, sizeof(datasketches::theta_union));
  if (UNLIKELY(dst->is_null)) {
    DCHECK(!ctx->impl()->state()->GetQueryStatus().ok());
    return;
  }
  // Constructs object initialization memor
  datasketches::theta_union* sketch_ptr =  reinterpret_cast<datasketches::theta_union*>(dst->ptr);
  datasketches::theta_union sketch = datasketches::theta_union::builder().build();
  std::uninitialized_fill_n(sketch_ptr, 1, sketch);
}

// Update phase
template <typename T>
void AggregateFunctions::DsThetaUpdate(FunctionContext* ctx, const T& src, StringVal* dst) {
  if (src.is_null) return;
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));
  datasketches::theta_union* sketch_ptr = reinterpret_cast<datasketches::theta_union*>(dst->ptr);
  // need add new update functionality in theta_union
  sketch_ptr->update(src.val);
}

// Serialize phase
StringVal AggregateFunctions::DsThetaSerialize(FunctionContext* ctx, const StringVal& src) {
  DCHECK(!src.is_null);
  DCHECK_EQ(src.len, sizeof(datasketches::theta_union));
  datasketches::theta_union* union_ptr = reinterpret_cast<datasketches::theta_union*>(src.ptr);
  StringVal dst = SerializeDsThetaUnion(ctx, *union_ptr);
  ctx->Free(src.ptr);
  return dst;
}

// Merge phase
void AggregateFunctions::DsThetaMerge(FunctionContext* ctx, const StringVal& src, StringVal* dst) {
  DCHECK(!src.is_null);
  DCHECK(!dst->is_null);
  DCHECK_EQ(dst->len, sizeof(datasketches::theta_union));

  // Note, 'src' is a serialized compact_theta_sketch and not a serialized theta_union.
  auto src_sketch =  datasketches::compact_theta_sketch::deserialize((void*)src.ptr, src.len);

  datasketches::theta_union* dst_union_ptr = reinterpret_cast<datasketches::theta_union*>(dst->ptr);

  dst_union_ptr->update(src_sketch);
}

// Finalize phase, return estimate value.
BigIntVal AggregateFunctions::DsThetaFinalize(FunctionContext* ctx, const StringVal& src) {
  DCHECK(!src.is_null);
  DCHECK_EQ(src.len, sizeof(datasketches::theta_union));
  datasketches::theta_union* sketch_ptr = reinterpret_cast<datasketches::theta_union*>(src.ptr);
  auto sketch = sketch_ptr->get_result();
  ctx->Free(src.ptr);
  return sketch.get_estimate();
}

Why do you serialize union? We are removing this functionality from the new version as well as serialization of update sketch. Only compact sketches can be serialized. I am afraid I don't quite get your operation sequence. I would think that in the update phase the state of the aggregation should be update_theta_sketch, which should be converted to a compact_theta_sketch at the end of the phase, serialized and shipped to the merge phase. And the merge phase should only receive compact sketches to union them.

Why do you serialize union? We are removing this functionality from the new version as well as serialization of update sketch. Only compact sketches can be serialized. I am afraid I don't quite get your operation sequence. I would think that in the update phase the state of the aggregation should be update_theta_sketch, which should be converted to a compact_theta_sketch at the end of the phase, serialized and shipped to the merge phase. And the merge phase should only receive compact sketches to union them.

We have just promoted the experimental theta sketch implementation to replace the previous one. This creates a conflict with your proposed changes. Sorry for this confusion. I would suggest closing this request for now. If you really need this mixed union functionality, we can discuss it. However I still believe that we can easily do without. I still don't understand why you gave some examples above that don't show calling these methods.
New implementation allows serializing compact sketches only. I strongly believe that serializing updatable sketches or unions should not be necessary. If you are facing some difficulty in Impala, let us discuss this. I suggest opening an issue for that. We want to help you. Thank you.

Sorry about the delay in responding here. I've been busy with other things.
The serialized union is actually the result of theta_union.get_result().
StringVal SerializeDsThetaUnion(
    FunctionContext* ctx, const datasketches::theta_union& ds_union) {
  std::stringstream serialized_input;
  datasketches::compact_theta_sketch sketch = ds_union.get_result();
  return SerializeDsThetaSketch(ctx, sketch);
}

The problem was resolved using the existing interface and the performance met the requirements.


feat: kpack support

Signed-off-by: Tarun Khandelwal<EMAIL_ADDRESS>Description
Short summary of what is the issue and the solution.
Dependencies

Ex. Other PRs.

Breaking Change

[ ] Yes
[x] No

Testing Notes
What I did:
What did you do to validate this PR?
How you can replicate my testing:
Using the kpack.yaml config file for karina you can deploy kpack with karing -c test/kpack.yaml deploy kpack
Links
Issues links or other related resources

It looks like the images are still using latest ?
2021-04-21 16:01:07 +0000 UTC    1      Normal   Pulling              Pod/test-image-build-1-5wpzl-build-pod    Pulling image   "gcr.io/cf-build-service-public/kpack/build-init:latest"
There is also a missing service account:
2021-04-21 16:00:44 +0000 UTC    1      Warning  FailedCreate       ReplicaSet/kpack-webhook-bf4df8cdc      Error creating: pods   "kpack-webhook-bf4df8cdc-" is forbidden: error looking up service   account kpack/webhook: serviceaccount "webhook" not found |
-- | --

It looks like the images are still using latest ?

Oops, I forgot to update the test, they were using the latest in the defined configuration

There is also a missing service account:

I am not sure... Seeing in the logs it seemed to be created: https://github.com/flanksource/karina/runs/2402084895#step:4:783

Looking at the logs with the new deployment test for webhook and controller the pod seems to be running: https://github.com/flanksource/karina/pull/816/checks?check_run_id=2408734773#step:4:1024


Refactor to separate script/command execution from confgen

Separate the script/command execution to achieve a cleaner definition for what the confgen class is considered for. Additionally it is simple to create a custom executor like the NullExecutor.

Ping @clue

Thank you for the high quality PR, LGTM! :shipit:


Consider using @inlineable / @usableFromInline

The Swift forums have had some threads about performance, especially on cross module things (like Swift’s unpredictable efficiency), and there have been posts from other library authors having had to use some of these to maintain performance (SwiftNIO might have?).
In a few places, the generated code is using small functions to hopefully get code inlined to and the real work done within the runtime support code.  So… should some of our generated code being using these annotations so call sites still get "fast" code even if the generated proto code goes into a different module from the call site?

@inlineable can also expand the API surface significantly if used carelessly.  But it likely could be useful in a number of places.

@tbkka yup.  I just wonder if a lot of your past performance work was based on things being in a single module, so we might have a very different profile using a more recent swift and with some modules in the mix.  ☹


TypeError when using SelfQueryRetriever

Enviorment: DATABRICKS_RUNTIME_VERSION: 10.4
Python 3.8.10
Langchain 0.0.172
I was following along with the basic tutorial here: Self-querying retriever with Chroma and I keep getting TypeError: 'NoneType' object is not callable error.  Also, when I call .get() on the vectorstore, the embeddings field is "None".  Is this related to the error? Any idea what I'm doing wrong here? Many thanks.

---------------------------------------------------------------------------------------------------------------------------------------------
My full code:
from langchain.docstore.document import Document
docs = [
Document(page_content="A bunch of scientists bring back dinosaurs and mayhem breaks loose", metadata={"year": 1993, "rating": 7.7, "genre": "action"}),
Document(page_content="Leo DiCaprio gets lost in a dream within a dream within a dream within a ...", metadata={"year": 2010, "director": "Christopher Nolan", "rating": 8.2}),
Document(page_content="A psychologist / detective gets lost in a series of dreams within dreams within dreams and Inception reused the idea", metadata={"year": 2006, "director": "Satoshi Kon", "rating": 8.6}),
Document(page_content="A bunch of normal-sized women are supremely wholesome and some men pine after them", metadata={"year": 2019, "director": "Greta Gerwig", "rating": 8.3}),
Document(page_content="Toys come alive and have a blast doing so", metadata={"year": 1995, "genre": "animated"}),
Document(page_content="Three men walk into the Zone, three men walk out of the Zone", metadata={"year": 1979, "rating": 9.9, "director": "Andrei Tarkovsky", "genre": "science fiction", "rating": 9.9})
]
embeddings = OpenAIEmbeddings(chunk_size=1)
vectorstore = Chroma.from_documents(
docs, embeddings
)
from langchain.llms import OpenAI
from langchain.retrievers.self_query.base import SelfQueryRetriever
from langchain.chains.query_constructor.base import AttributeInfo
metadata_field_info=[
AttributeInfo(
name="genre",
description="The genre of the movie",
type="string or list[string]",
),
AttributeInfo(
name="year",
description="The year the movie was released",
type="integer",
),
AttributeInfo(
name="director",
description="The name of the movie director",
type="string",
),
AttributeInfo(
name="rating",
description="A 1-10 rating for the movie",
type="float"
),
]
document_content_description = "Brief summary of a movie"
llm = OpenAI(temperature=0)
retriever = SelfQueryRetriever.from_llm(llm, vectorstore, document_content_description, metadata_field_info, verbose=True)
---------------------------------------------------------------------------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
 in
27 document_content_description = "Brief summary of a movie"
28 llm = OpenAI(temperature=0)
---> 29 retriever = SelfQueryRetriever.from_llm(llm, vectorstore, document_content_description, metadata_field_info, verbose=True)
/databricks/python/lib/python3.8/site-packages/langchain/retrievers/self_query/base.py in from_llm(cls, llm, vectorstore, document_contents, metadata_field_info, structured_query_translator, chain_kwargs, enable_limit, **kwargs)
112                 "allowed_operators"
113             ] = structured_query_translator.allowed_operators
--> 114         llm_chain = load_query_constructor_chain(
115             llm,
116             document_contents,
/databricks/python/lib/python3.8/site-packages/langchain/chains/query_constructor/base.py in load_query_constructor_chain(llm, document_contents, attribute_info, examples, allowed_comparators, allowed_operators, enable_limit, **kwargs)
123     **kwargs: Any,
124 ) -> LLMChain:
--> 125     prompt = _get_prompt(
126         document_contents,
127         attribute_info,
/databricks/python/lib/python3.8/site-packages/langchain/chains/query_constructor/base.py in _get_prompt(document_contents, attribute_info, examples, allowed_comparators, allowed_operators, enable_limit)
100         i=len(examples) + 1, content=document_contents, attributes=attribute_str
101     )
--> 102     output_parser = StructuredQueryOutputParser.from_components(
103         allowed_comparators=allowed_comparators, allowed_operators=allowed_operators
104     )
/databricks/python/lib/python3.8/site-packages/langchain/chains/query_constructor/base.py in from_components(cls, allowed_comparators, allowed_operators)
57         allowed_operators: Optional[Sequence[Operator]] = None,
58     ) -> StructuredQueryOutputParser:
---> 59         ast_parser = get_parser(
60             allowed_comparators=allowed_comparators, allowed_operators=allowed_operators
61         )
/databricks/python/lib/python3.8/site-packages/langchain/chains/query_constructor/parser.py in get_parser(allowed_comparators, allowed_operators)
127     allowed_operators: Optional[Sequence[Operator]] = None,
128 ) -> Lark:
--> 129     transformer = QueryTransformer(
130         allowed_comparators=allowed_comparators, allowed_operators=allowed_operators
131     )

I keep getting TypeError: 'NoneType' object is not callable too.
I have updated, installed Lark, but didn't help
tried in different environemnts, but didn't help

@sergeyvi4ev Could you share the full stacktrace ?

@sergeyvi4ev are you running this in a notebook? sometimes installing dependencies in those is tricky

it seems like it's saying the QueryTransformer class is None so then trying to instantiate it fails. which only occurs when Lark import fails. if you just run
from lark import Lark, Transformer, v_args

that doesn't error?

I'm having the same issue. Same error trace. Installed lark and can ran from lark import Lark, Transformer, v_args, but the issue remains

install lark and restart the jupyter notebook kernel solve this issue for me. Thanks for the info!