ICSP Error when adding a server

Hey, when running the docker-machine create command i get a Status 500 from ICSP. Looking at Debug i see the following.
(swarm-node-04) DBG | RestAPICall POST - https://icsp.test.local/rest/os-deployment-servers
(swarm-node-04) DBG | *** url => https://icsp.test.local/rest/os-deployment-servers
(swarm-node-04) DBG | *** method =>
(swarm-node-04) DBG | *** options => {"port":443,"username":"Administrator","password":"password"}
(swarm-node-04) DBG | Headers -> auth -> KkaOdY4fJlX1n21asQk9KiVFEbA3Jkor
(swarm-node-04) DBG |
(swarm-node-04) DBG | Headers -> Content-Type -> application/json; charset=utf-8
(swarm-node-04) DBG |
(swarm-node-04) DBG | Headers -> X-API-Version -> 108
(swarm-node-04) DBG |
(swarm-node-04) DBG | REQ    --> &{Method:POST URL:https://icsp.test.local/rest/os-deployment-servers Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Content-Type:[application/json; charset=utf-8] X-Api-Version:[108] Auth:[KkaOdY4fJlX1n21asQk9KiVFEbA3Jkor]] Body:{Reader:} ContentLength:61 TransferEncoding:[] Close:false Host:icsp.twlon.com Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil>}
(swarm-node-04) DBG |
(swarm-node-04) DBG | RESP   --> &{Status:500 Server Error StatusCode:500 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Cache-Control:[no-cache] Date:[Mon, 22 Aug 2016 15:00:49 GMT] Content-Type:[application/json;charset=UTF-8] Via:[1.1 icsp.test.local] Vary:[Accept-Encoding]] Body:0xc8201ed640 ContentLength:-1 TransferEncoding:[chunked] Close:true Trailer:map[] Request:0xc82014e380 TLS:0xc8203926e0}

i think this is because it is not passing the IP address of the iLO to ICSP. Looking higher up the output i see.
(swarm-node-04) DBG | GetCurrentPowerState() blade -> {ServerHardwarev200:{IntelligentProvisioningVersion:2.20.219 MpHostInfo:0xc8204a1d10 MpState:OK PortMap:0xc8204f7f60 ServerSettings:0xc820510e80 Signature:0xc820510ea0} AssetTag:[Unknown] Category:server-hardware Created:2016-03-15T10:05:25.671Z Description: ETAG:1471803258698 FormFactor:HalfHeight LicensingIntent:OneView LocationURI:/rest/enclosures/09CZ35293RS1 MemoryMb:163840 Model:ProLiant BL460c Gen9 Modified:2016-08-21T18:14:18.698Z MpFirwareVersion:2.40 Dec 02 2015 MpModel:iLO4 Name:C7000-Rack8, bay 5 PartNumber:727021-B21 Position:5 PowerLock:false PowerState:Off ProcessorCoreCount:6 ProcessorCount:2 ProcessorSpeedMhz:1900 ProcessorType:Intel(R) Xeon(R) CPU E5-2609 v3 @ 1.90GHz RefreshState:NotRefreshing RomVersion:I36 12/28/2015 SerialNumber:CZ35210RS3 ServerGroupURI:/rest/enclosure-groups/8aa07098-ece1-4568-ae9a-bbf9fcde48c9 ServerHardwareTypeURI:/rest/server-hardware-types/B40A6425-B4D2-4467-99BB-059263311F2E ServerProfileURI:/rest/server-profiles/eea9e3f9-6821-4f12-8ee5-66ff1eb5f5aa ShortModel:BL460c Gen9 State:ProfileApplied StateReason:NotApplicable Status:OK Type:server-hardware-4 URI:/rest/server-hardware/30373237-3132-5A43-3335-323933525333 UUID:30373237-3132-5A43-3335-323933525333 VirtualSerialNumber:VCGND6V04K VirtualUUID:eea9e3f9-6821-4f12-8ee5-66ff1eb5f5aa MpDnsName: MpIpAddress: Client:%!v(PANIC=runtime error: index out of range)}
The bit of interest there is MpIpAddress: Client:%!v(PANIC=runtime error: index out of range)}.
If it helps i am running OV version  2.00.07-0250853, and ICSP version 7.5.0-0209204, Aug 3, 2015.
Does anybody know why? Is it API versions?

I see this aswell,
my config is:
OV Version:  2.00.07-0250853
ICSP Version: 7.5.1-0243931
docker-machine-driver-oneview version: 0.5.5
docker-machine version: 0.8.1, build 41b3b25

Hey, Trying to reproduce the issue with those versions, to see if it's something obvious.  Just to confirm on the iLo IP, that is something we calculate from the server profile.   I do have some questions on that.

Was the server profile in OneView created for the server before hand or by the driver?
When you navigate to server hardware that was assigned by the server profile, you should find a section called iLO.  Do you see a hostname and IPv4 address listed for the server?
Is the IPv6 field empty with none, or is it populated?

Thanks for the additional information.   Also, if you can share the command line you tried for docker-machine create, that would be good as well.

Hey,

The profile is already defined in OV and the driver is copying and applying it to some hardware (On that point, even though I set the API version as 200 in my environment, it is unable to find a "Server Profile Template". The Profile specified in the command has to be a "Server Profile", maybe related).

Yes i see the hostname and ipv4 address in OV. ipv6 address is none.

I source these variables:

export ONEVIEW_APIVERSION=200

export ONEVIEW_ILO_USER=Administrator
export ONEVIEW_ILO_PASSWORD=password

export ONEVIEW_ICSP_ENDPOINT=https://icsp.test.local
export ONEVIEW_ICSP_USER=Administrator
export ONEVIEW_ICSP_PASSWORD=password
export ONEVIEW_ICSP_DOMAIN=LOCAL

export ONEVIEW_OV_ENDPOINT=https://oneview.test.local
export ONEVIEW_OV_USER=Administrator
export ONEVIEW_OV_PASSWORD=password
export ONEVIEW_OV_DOMAIN=LOCAL

export ONEVIEW_SSLVERIFY=false

and then run this command
docker-machine --debug create \
    --driver oneview \
    --oneview-server-template "machine" \
    --oneview-os-plan "docker_centos" \
    --swarm \
    --swarm-discovery token://0f3c80f666c7a1fc4131e9a1298c5260 \
    swarm-node-04

Thanks a lot for your help :)

Ahh, ok, so here is another possibility for the issue, you should try to define the option:
--oneview-public-connection-name
The value for this should be equal to the value of the name given in the profile for the Connection which will be accessible to the system running docker-machine, so that commands like ssh will work to that particular connection.   This is also the interface that needs to get an automatic DHCP address for the network it comes online for.
I think it's possible that this connection might not exist because the default for the driver is to look for the 2nd interface and try to communicate with it as the public interface.   Do you know if you only have a single interface or connection?

In this case my option would be --oneview-public-connection-name "LR0_A"

Hi,
I noticed that when I do a rest call to /rest/server-hardware/{id} with X-Api-Version:200 I get mpIpAddresses as a array,
the same call uing X-Api-Version:120 I do see mpIpAddress as a string.
Don't know If this has something to do with anything.
enyhow, here's my env
ONEVIEW_APIVERSION=200
ONEVIEW_ICSP_DOMAIN=LOCAL
ONEVIEW_ICSP_ENDPOINT=https://icsp.demo.hp.se
ONEVIEW_ICSP_PASSWORD=password
ONEVIEW_ICSP_USER=docker
ONEVIEW_ILO_DOMAIN=LOCAL
ONEVIEW_ILO_PASSWORD=password
ONEVIEW_ILO_USER=docker
ONEVIEW_OS_PLAN=Docker_OS
ONEVIEW_OV_DOMAIN=LOCAL
ONEVIEW_OV_ENDPOINT=https://oneview110.demo.hp.se
ONEVIEW_OV_PASSWORD=password
ONEVIEW_OV_USER=docker
ONEVIEW_SERVER_TEMPLATE=Docker_Template
ONEVIEW_SSLVERIFY=true

and I ran this command:
docker-machine --debug create --driver oneview --oneview-public-connection-name "PublicNet1" docker-node-01 2>&1 | tee output.txt

Attached you have the complete output.
output.txt
I've also tried with docker-machine-driver-oneview version v0.8.0-rc1 and a build from the current master, no luck with those either....
Cheers

I have just spun up a OneView 2.00.02 environment and tested my configurations and commands against that and it worked. The driver was able to read  Server Profile Templates and the iLO Address. I guess this is because OV 2.00.02 is using API Version 200 where as the OV2.00.07 is using API Version 201 :(

@ollypom awesome cool find, im hoping to be able to repro that this week and see if we can do a fix.

@ollypom I think i found a workaround to the api issue we're having during icsp login.  At least thats whats showing up for me.  I'm wondering if you could give it a try.
I'll work on a fix to avoid having to do this, but here is the workaround:

Login to ICsp as a system admin
Go to Settings, and edit the Security option.
Disable license acknowledgment requirement

Please let me know if that doesn't remove the issue your running into.
Thanks!

@wenlock I don't seem to have that tick box on my ICSP 7.5.0, i will upgrade to 7.5.1 now :(

@ollypom since you mentioned you don't have this dialog, I kept looking...  I think I know have a fix for this issue in https://github.com/HewlettPackard/oneview-golang/pull/75
This problems is caused by an issue with detecting the correct api version to use when connecting to new versions of OneView.  I'm doing some testing on this and will cut pre-release binaries when my test work.  Stay tuned.  Thanks!

@ollypom could you give it another shot with this new binary:
https://github.com/HewlettPackard/docker-machine-oneview/releases/tag/v0.8.1

@wenlock I have just given that new binary a go and it worked :) I was able to deploy from a server profile template and the server was added to ICSP successfully. My versions OV <IP_ADDRESS> and ICSP 7.5.1.
Am i still exporting x-api-version 200 or should i be exporting 201?
Thanks a lot :)

@ollypom sorry for delayed response, yes, you should be able to leave off the export setting for api versions.

v0.8.1 works like a charm, thanks @wenlock


[Bug] Fail to display correctly 3D series

Describe the Bug
The image fails to load correctly using DICOMJSON or drag and drop on both https://viewer.ohif.org or https://viewer-dev.ohif.org
Steps to Reproduce
Load DICOM file on OHIF
The current behavior
The image is shown as several low res miniates

The expected behavior
The image should display correctly

OS
macOS 14.5
Node version
20
Browser
Chrome

Hmmm, this is not about 3D, it is about color, i will look

Could you kindly provide the data if it has been anonymized and you can confirm that there is no patient health information present in any of the headers or embedded within the pixel data?

Sorry for the delay, I'm sending the examples without PHI: Anonymized - 08.zip

We released OHIF 3.9 which address this issue


Cant Build since you changed to clang

Console output:
/Cheat/gamesneeze> ./toolbox.sh -bd
Building cheat...


Custom server down error

Is your suggestion related to a problem? Please describe in detail.
when the server is restarting a generic Cloudflare error is shown witch doesn't explain to the user what is happening
Describe your suggestion
the server shows a custom error message such as offline.html I think this could proboly be done with nginx
Describe alternatives you've considered
I tried using service workers but this doesn't work because Cloudflare
Additional context
like this:

not this:

I don't think we can customize Cloudflare's error messages.
However, we can customize nginx's error messages and I would want to customize those for when you react the internal limit.

You can customize: https://developers.cloudflare.com/support/more-dashboard-apps/cloudflare-custom-pages/configuring-custom-pages-error-and-challenge/

I don't think we can customize Cloudflare's error messages. However, we can customize nginx's error messages and I would want to customize those for when you react the internal limit.

You can customize: https://developers.cloudflare.com/support/more-dashboard-apps/cloudflare-custom-pages/configuring-custom-pages-error-and-challenge/

Does that work with the free tier?

I don't think we can customize Cloudflare's error messages. However, we can customize nginx's error messages and I would want to customize those for when you react the internal limit.

You can customize: https://developers.cloudflare.com/support/more-dashboard-apps/cloudflare-custom-pages/configuring-custom-pages-error-and-challenge/

Does that work with the free tier?

It requires a payed plan:  Pro, Business, or Enterprise.


Colorize kubectl auth commands

Expected Behavior
Correct coloring is applied to:
kubectl auth can-i                      # literal: yes / no
kubectl auth can-i --list               # table
kubectl auth can-i --list --no-headers  # table witout header

kubectl auth whoami          # table
kubectl auth whoami -o yaml  # yaml
kubectl auth whoami -o json  # json

kubectl auth reconcile -f role.yaml  # similar to "kubectl apply" coloring

Sample outputs
kubectl auth can-i
$ kubectl auth can-i get pods
yes

$ kubectl auth can-i delete pods
no

$ kubectl auth can-i --list
Resources                                       Non-Resource URLs   Resource Names   Verbs
*.*                                             []                  []               [*]
                                                [*]                 []               [*]
selfsubjectreviews.authentication.k8s.io        []                  []               [create]
selfsubjectaccessreviews.authorization.k8s.io   []                  []               [create]
selfsubjectrulesreviews.authorization.k8s.io    []                  []               [create]
                                                [/api/*]            []               [get]
                                                [/api]              []               [get]
                                                [/apis/*]           []               [get]
                                                [/apis]             []               [get]
                                                [/healthz]          []               [get]
                                                [/healthz]          []               [get]
                                                [/livez]            []               [get]
                                                [/livez]            []               [get]
                                                [/openapi/*]        []               [get]
                                                [/openapi]          []               [get]
                                                [/readyz]           []               [get]
                                                [/readyz]           []               [get]
                                                [/version/]         []               [get]
                                                [/version/]         []               [get]
                                                [/version]          []               [get]
                                                [/version]          []               [get]

$ kubectl auth can-i --list --no-headers
*.*                                             []             []    [*]
                                                [*]            []    [*]
selfsubjectreviews.authentication.k8s.io        []             []    [create]
selfsubjectaccessreviews.authorization.k8s.io   []             []    [create]
selfsubjectrulesreviews.authorization.k8s.io    []             []    [create]
                                                [/api/*]       []    [get]
                                                [/api]         []    [get]
                                                [/apis/*]      []    [get]
                                                [/apis]        []    [get]
                                                [/healthz]     []    [get]
                                                [/healthz]     []    [get]
                                                [/livez]       []    [get]
                                                [/livez]       []    [get]
                                                [/openapi/*]   []    [get]
                                                [/openapi]     []    [get]
                                                [/readyz]      []    [get]
                                                [/readyz]      []    [get]
                                                [/version/]    []    [get]
                                                [/version/]    []    [get]
                                                [/version]     []    [get]
                                                [/version]     []    [get]

kubectl auth whoami
$ kubectl auth whoami
ATTRIBUTE   VALUE
Username    kalle
Groups      [Everyone DEP_Platform SVC_Kubernetes_clusteradmin system:authenticated]

$ kubectl auth whoami -o yaml
apiVersion: authentication.k8s.io/v1
kind: SelfSubjectReview
metadata:
  creationTimestamp: "2024-03-25T15:38:47Z"
status:
  userInfo:
    groups:
    - Everyone
    - DEP_Platform
    - SVC_Kubernetes_clusteradmin
    - system:authenticated
    username: kalle

$ kubectl auth whoami -o json
{
  "apiVersion": "authentication.k8s.io/v1",
  "kind": "SelfSubjectReview",
  "metadata": {
    "creationTimestamp": "2024-03-25T15:38:47Z"
  },
  "status": {
    "userInfo": {
      "groups": [
        "Everyone",
        "DEP_Platform",
        "SVC_Kubernetes_clusteradmin",
        "system:authenticated"
      ],
      "username": "kalle"
    }
  }
}

kubectl auth reconcile
$ kubectl auth reconcile -f clusterrolebinding.yaml
clusterrolebinding.rbac.authorization.k8s.io/oidc-cluster-admin reconciled

$ kubectl auth reconcile -f clusterrolebinding.yaml --dry-run=client
clusterrolebinding.rbac.authorization.k8s.io/oidc-cluster-admin reconciled (dry run)

$ kubectl auth reconcile -f clusterrolebinding.yaml --dry-run=server
error: --dry-run=server for command reconcile is not supported yet

Current Behavior
Currently everything is just single-colored.
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Operating System: linux
kubectl version: v1.29.3
kubecolor version: v0.2.2

I can pick this up if you want @applejag

I can pick this up if you want @applejag

Sure, go for it! :)
One thing that's special about this one is that it has different coloring rules for subcommands of a subcommand, which is not yet supported in kubecolor.
I'm not 100% sure how this could be done without a bigger refactor, and a bigger refactor is already planned in #113. So the good first issue label may be misplaced here.
Preferably I think this issue should only be done if it can be done with small changes


bug: wagmi-cli generate functions with no argument type

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.3.9
Current Behavior
When running wagmi generate, I get all the function and hooks with no types like:
export function useErc20Allowance(config = {}) {
  return useContractRead({ abi: erc20ABI, functionName: 'allowance', ...config })
}
export function useErc20BalanceOf(config = {}) {
  return useContractRead({ abi: erc20ABI, functionName: 'balanceOf', ...config })
}

with the config file from the docs.
Expected Behavior
the functions argument type should not be config = {} but instead be typed correctly.
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
node: v19.9.0
tsconfig.json:
{
  "compileOnSave": false,
  "compilerOptions": {
    "strict": true,
    "rootDir": ".",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "importHelpers": true,
    "target": "es2015",
    "module": "esnext",
    "lib": ["es2020", "dom"],
    "skipLibCheck": true,
    "skipDefaultLibCheck": true,
}

project is using a monorepo using nx and nextjs apps.

Thanks for reporting. This issue is temporarily closed due to lack of information. Please provide a minimal reproducible example and reopen this issue.

The issue here was that on root folder, I hade a tsconfig.base.josn and other apps in the monorepo were extending it in their own tsconfig.json, I don't know what tsconfig wagmi-cli was using maybe one of from the subfolders, but once I changed tscofig.base.json to tsconfig.json it worked fine.
@tmm sorry I couldn't reproduce this with a minimal example, like I said I was using default config example and it was working fine in a new project, the issue was withing my project setup.


Different Symbols for Numerator and Denominator

I think another option/setting that deserves to be added is the possibility to have different symbols for numerators and denominators.
Such option exists in diffcoeff package and is convenient for some mathematical and physical equations that I use.
For example, the LHS could yield the RHS in the following command:
\pdv[style-inf=\nabla, style-inf-denom=d]{f}{t}= \frac{\nabla f}{d t}

The same thing can be done with diffcoeff package it can be done thanks to:
\diffdef{d2}{
  op-symbol = \nabla,
  op-symbol-alt = d
  }
\begin{equation}
  \diff.d2.{f}{t}
\end{equation}

And it can be kept that by default style-inf is equal to style-inf-denom (or another name) if the latter is not given.

This shouldn't be much of an issue to implement.

Implemented the feature and seems to work fine. Will be uploaded sometime in the future.

Note that \qdv will not be added in the next release.
Still need to do some more testing of the fractional calculus calculator for mixed order. Probably also added some of the other requested features. Update documentation....

Sorry I missed your comment (mail box synchronization issue from my side, oups).
I seems great.
I made a pull request (#5 related to #1).
However, this pull request does not take into account improvements you are showing here ;  and I think it will need a bit of extra work to make compatible (and treat combination cases), but nothing too hard.
Therefore, do not hesitated to give me access to your recent modification (on a separated branch or any other way you see), so I can work on this compatibility.

Hello, I would also be interested in this feature. In the literature, you sometimes encounter derivatives typeset like the following
\frac{\mathrm{d}_s f}{\mathrm{d}}

in order to denote the convective derivative when multiple "species" are found e.g. in a fluid.
Would you consider an update / help with this contribution soon?
Many thanks!

Hello, I would also be interested in this feature. In the literature, you sometimes encounter derivatives typeset like the following
\frac{\mathrm{d}_s f}{\mathrm{d}}

in order to denote the convective derivative when multiple "species" are found e.g. in a fluid. Would you consider an update / help with this contribution soon?
Many thanks!

The code is already in version 2 draft. You can download it and use it in your documents. I haven't written the documentation of the the new features yet, because I thought of a new feature I wanted to implement. But it takes longer than expected. In this version we have
style-inf = d,       % Sets the numerator operator symbol
style-inf-denom = d, % Sets the denominator operator symbol

If you want to create a new derivative you can do
\NewDerivative{\mydv}{d}[style_inf = d_s]
or
\NewDerivative{\mydv}{d_s}[style_inf-denom = d]
If you rather want to edit an existing derivative
\derivset{\odv}[style_inf = d_s]

Thank you both very much for your clarifications, looking forward to v2!


Brazilian numbers not recognized

The brazilians numbers are not recognize, unless a zero is added in the beggining of the input.
In the demo page, if I put the number<PHONE_NUMBER>1 with country as BR, that number is not recognized. But if I add the zero in the beggining, the number is recognized and formatted as expected.

Fixed in the new release


Modif path

TIP for later. Think about my filenames before committing

TIP for later. Think about my filenames before committing


If the selectedIndex is not equal to 0, when entering the app, the circle is still at the 0 position

Hey @paulpaulzhang, please check out version 0.0.2, should be fixed there. Have a wonderful day!


MSI installer should install services with AutoStart instead of on OnDemand

Describe the feature you'd like supported
The ebpf services are installed with start=demand which means if the machine reboots it they don't start back up. I encountered this after installing and rebooting due to a needed update (https://github.com/microsoft/ebpf-for-windows-demo/issues/22#issuecomment-1254266031)
Proposed solution
Switch services to start=auto which mean if machine reboots ebpf starts up. I believe this would be expected behavior in most scenarios.
Additional context
change would be
https://github.com/microsoft/ebpf-for-windows/blob/ecd08ecbb992be596090a473970afcc1eb815576/scripts/install_ebpf.psm1#L63
and maybe modify the install extension in https://github.com/microsoft/ebpf-for-windows/blob/ecd08ecbb992be596090a473970afcc1eb815576/scripts/install_ebpf.psm1#L73

Proposed fix: eBPFSvc takes dependency on eBPFCore. eBPFSvc is marked as trigger start on RPC call. Also the extension drivers should be loaded with an eBPF program is attached with program type implemented by the extension driver. Maybe the registry store can be used for this purpose.


Support named groups like in Python (todo)

\g<name> is not made yet. Other is made!! In pull-req.

@andgineer
now added Substitute for named groups! for usual groups it was $1..$9.
for named, it is $<name>.
it user want, I may do \g<name> later.


Migrate Terminal Panel to ViewPane

This PR refs #89729

Lowercase "hide" on right click? Isn't the terminal check item enough below also?

I don't know how to move it to the viewlet, "workbench.view.experimental.allowMovingToNewContainer": true didn't do it.

I don't know how to move it to the viewlet, "workbench.view.experimental.allowMovingToNewContainer": true didn't do it.

You shall enable canMove on the view while registering.


Test GHA re-approve on triggering test twice

@yash-zededa please approve

When @yash-zededa approves it, @milan-zededa please approve it. That way we can check if tests will be triggered twice


Update CONTRIBUTING.md

Proper markdown formatting

@rpeace42 Roderick, mind to please review?

@brunoborges we intend to display the URL as it is today.  Thank you for the contribution.


Does disabling FSR downscaling also disable Dynamic Resolution

I'm wondering if the disable FSR downscaling mod also disables Dynamic Resolution. It's not very clear from the docs and I don't see any standalone mods to remove Dynamic Resolution. Thanks

Disable Dynamic Resolution was taken off because was causing too many issues for lots of people.
The closest thing we have now is the Disable Quality Reduction mod, which needs more testing. Please try this one and share your findings :D

Is there anywhere else I can get the mod which has been ported to 1.2.0?

The original Disable Quality Reduction mod is part of Chuck's visual patches for 1.1.2:
https://www.reddit.com/user/ChucksFeedAndSeed/comments/13sofgg/totk_v112_visual_patches_chuckpatch_fsr_disable/

Is there anywhere else I can get the mod which has been ported to 1.2.0?

Yes, we've recently updated the archive to feature 1.2.0 mods, most of them so far, at least.
Youll want to enable "Disable Quality Reduction", found in the "graphics" folder.
This patch not only prevents the game from swapping model LODs when slowdowns occur, but also prevents it from reducing the resolution!


Sticky header View observer crash

Hello, i am currently developing a project which uses this awesome library. Actually, i am developing with swift 3, using the xcode betas, and i was able to make it working without any trouble. My project is very close to be completed, but after i ve updated to xcode beta 6, ( and made some changes to library in order to make happy the compiler), my app is crashing every time i try to present the persei table. Through an exception breakpoint, the problem seems to be caused by
public override func didMoveToSuperview() {
        super.didMoveToSuperview()

        if let view = superview as? UIScrollView {
//AddObserver makes the app crash
            view.addObserver(self, forKeyPath: "contentOffset", options: [.initial, .new], context: &ContentOffsetContext)
            view.panGestureRecognizer.addTarget(self, action: #selector(StickyHeaderView.handlePan(_:)))
            view.sendSubview(toBack: self)
        }
    }

Do you have any suggestion in order to make it work again as expected? The persei controller was totally integrated in my app, if i can t find a solution i will have to switch library for a new one and i wanna be sure it will be the last option.
Thanks for your attention, hope all is gonna be solved

Does it happen for Xcode 8 release? Can you reproduce the issue with the example app?

Hello serejahh, i can t reply since i had to remove completely the persei library from my project due to this crash related to the observer. Thanks for reply, best regards!


alpha.cuelang.org: version number missing from docs

What page were you looking at?
https://alpha.cuelang.org/docs/
What version of the site were you looking at?
https://github.com/cue-lang/cuelang.org/commit/eb2ecd699e4451e0284f62764d145abdd14040e2
What did you do?
Visited the above page.
What did you expect?
To see the version of CUE to which the docs apply in the top right hand corner, or similar.
Consider the following (terrible!) sketch:

What did you see instead?
Nothing.

Random thought, but this could be solved by having the version number be "part" of the GitHub icon in some way (would require the icon to be moved to the left of the bunch perhaps)


Method to get current thread color?

Description
It would be good to be able to know the current thread color of a given thread. At the moment it seems the only way to determine the thread color is to change it to a new one so you know what it is.
Also is there a way of changing the colors of specific messages or can it only be applied to the whole thread?

thread = client.fetchThreadInfo(thread_id)[thread_id]
print(thread.color)

Closing, assuming @kapi2289's suggestion solves the issue


Automatically release CI build artifacts

I'd like to automate the release process which is currently being manually done.
https://github.com/flutter-tizen/engine/releases
I'll take a look when I get some time but please feel free to work on this if you're interested. cc @WonyoungChoi

Opps, I missed this issue. If the engine is rebuilt in the release workflow, probably many parts will be duplicated with the build workflow. Therefore, we need to consider re-organizing workflows for using Reusable workflow. https://docs.github.com/en/actions/using-workflows/reusing-workflows.


pkp/pkp-lib#8199 Add Crossref submission ID to the DOI management panel

@ewhanson, this all looks good to me :+1: :-)
It seems we need to display the link (with submission ID) only on success?

Thanks, @bozana! Apologies for the delay. That is correct. The link will only be relevant if it was successfully deposited, so it will show up in the "success message" modal. Is it okay with you if I merge it?

Yes, please go ahead :-) :+1:


Route doesn't allow an array callable (eg.: [$obj, 'method'])

Simple example of this not working:
$test = new Test();
$router = new League\Route\RouteCollection;
$router->addRoute('GET', '/', [$test, 'index']);

$request    = Request::createFromGlobals();
$dispatcher = $router->getDispatcher();

try {
    $response   = $dispatcher->dispatch($request->getMethod(), $request->getPathInfo());
    $response->send();
} catch(Exception $e) {
    echo $e->getMessage();
}

class Test
{
    public function index(Request $req, Response $resp)
    {
        $resp->setContent("Testing");
        return $resp;
    }
}

Errors:
Warning: Illegal offset type in /var/www/source/vendor/league/route/src/RouteCollection.php on line 84

Warning: Illegal offset type in /var/www/source/vendor/league/route/src/RouteCollection.php on line 84

Warning: Illegal offset type in /var/www/source/vendor/league/route/src/Dispatcher.php on line 69

Warning: Illegal offset type in /var/www/source/vendor/league/route/src/Dispatcher.php on line 70

Catchable fatal error: Argument 2 passed to League\Route\Dispatcher::handleFound() must implement interface League\Route\Strategy\StrategyInterface, null given, called in /var/www/source/vendor/league/route/src/Dispatcher.php on line 73 and defined in /var/www/source/vendor/league/route/src/Dispatcher.php on line 85

Doing the following works as expected though:
$router->addRoute('GET', '/', 'test::index');

Both ways are valid callables, so this not working is weird.

Trying to debug this myself locally, in RouteCollection on line 72 I change:
if ($handler instanceof Closure ||
    (is_object($handler) && is_callable($handler))
) {

to
if ($handler instanceof Closure ||
    (is_object($handler) || is_callable($handler))
) {

Fixes the first error, then you get a new set of errors which I didn't get that far with:
Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 189

Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 194

Warning: Illegal offset type in /var/www/source/vendor/league/container/src/Container.php on line 208

Fatal error: Function name must be a string in /var/www/source/vendor/league/container/src/Container.php on line 210

Will have a look at this tomorrow morning and ensure all callables are
accepted
On 7 Sep 2015 22:23, "G4MR"<EMAIL_ADDRESS>wrote:

Trying to debug this myself locally, in RouteCollection on line 72 I
change:
if ($handler instanceof Closure ||
(is_object($handler) && is_callable($handler))
) {
to
if ($handler instanceof Closure ||
(is_object($handler) || is_callable($handler))
) {
Fixes the first error, then you get a new set of errors which I didn't get
that far with:
Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 189
Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 194
Warning: Illegal offset type in /var/www/source/vendor/league/container/src/Container.php on line 208
Fatal error: Function name must be a string in /var/www/source/vendor/league/container/src/Container.php on line 210
—
Reply to this email directly or view it on GitHub
https://github.com/thephpleague/route/issues/61#issuecomment-138379971.

I figured out what's wrong or a solution to my issue:
RouteCollection on line 72 I change:
if ($handler instanceof Closure ||
    (is_object($handler) && is_callable($handler))
) {

to
if ($handler instanceof Closure ||
    (is_object($handler) || is_callable($handler))
) {

And in Strategy/AbstractStrategy.php on line 27 if I changed line 27 from:
            $this->getContainer()->get($controller[0]),

to
            $controller[0],

Everything works as expected.  Both [$test, 'index'] and 'test::index', now I'm assuming this line creates a new object for the controller and then attempts to call it normally so you don't have to forcefully call static on the class method.  I guess a simple solution would be to check if $controller[0] is already an object?
$controller = [
    is_object($controller[0]) ? $controller[0] : $this->getContainer()->get($controller[0]),
    $controller[1]
];

It's not actually a static call but a pointer so that the class can be
resolved via the container, your solution looks to be correct but I need to
be sure it fits all scenarios so I'll put together some test cases tomorrow
and get all of them passing.
On 7 Sep 2015 22:44, "G4MR"<EMAIL_ADDRESS>wrote:

I figured out what's wrong or a solution to my issue:
RouteCollection on line 72 I change:
if ($handler instanceof Closure ||
(is_object($handler) && is_callable($handler))
) {
to
if ($handler instanceof Closure ||
(is_object($handler) || is_callable($handler))
) {
And in Strategy/AbstractStrategy.php on line 27 if I changed line 27 from:
        $this->getContainer()->get($controller[0]),

to
        $controller[0],

Everything works as expected. Both [$test, 'index'] and 'test::index', now
I'm assuming this line creates a new object for the controller and then
attempts to call it normally so you don't have to forcefully call static on
the class method. I guess a simple solution would be to check if
$controller[0] is already an object?
$controller = [
is_object($controller[0]) ? $controller[0] : $this->getContainer()->get($controller[0]),
$controller[1]
];
—
Reply to this email directly or view it on GitHub
https://github.com/thephpleague/route/issues/61#issuecomment-138382747.

Sounds good.

Should be fixed by 6029f146900f76c4dfa53632cdf71615fd720704

Did you forget to update AbstractStrategy.php on Line 27 because I'm still getting:
Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 189

Warning: array_key_exists(): The first argument should be either a string or an integer in /var/www/source/vendor/league/container/src/Container.php on line 194

Warning: Illegal offset type in /var/www/source/vendor/league/container/src/Container.php on line 208

Fatal error: Function name must be a string in /var/www/source/vendor/league/container/src/Container.php on line 210

I played with my solution above checking $controller[0] to see if it was an object already seemed to work locally.

Yep, apologies, I rushed that, will add the check asap

alright

I noticed you've written another version under the develop branch, when is that expected to drop because it has some features that I've wanted like get,post,etc... to shorten the length of the addRoute method (now map in develop)

@G4MR expect a tag over the weekend, however, those convenience methods are already there in version 1

those convenience methods are already there in version 1

I must have overlooked them.

tag/1.2.3

thanks :)

Hello, I use the magic method __invoke to use the instance of the class to group routes
<?php
use League\Route\RouteGroup;

abstract class Router
{
  abstract protected function routes(RouteGroup $group);
  public function __invoke(RouteGroup $group)
  {
    $this->routes($group);
  }
}

class UserRoutes extends Router
{
  protected function routes(RouteGroup $group)
  {
    $group->post("/users", "UserController::index");
  }
}
$router  = new League\Route\Router;
$request = new Request; // Psr\Http\Message\ServerRequestInterface

// Using UserRoutes
$router->group("/api", new UserRoutes());

$response = $router->dispatch($request);


Clustered lighting or 1.55 could be causing higher GPU times on some project examples

Thread: https://forum.playcanvas.com/t/engine-release-v1-55-0/26663/34?u=yaustar

I’ve seen some updates in the examples, some of them are performing extremely bad in my laptop.
For reference, playcanvas 1.55.0, resolution 1080p, CPU i7-9750H and GPU RTX 2080:
Area lights: 750ms each frame (before the update, this example was very fluid)
Post effects: 2100ms (Before the update, this example was very fluid)
Clustered area lights: From 600 to 1300 ms
Clustered lighting: 100ms (So, clustered lighting sometimes works wonderful)
The swimming pool example also performed very bad weeks ago, but I took it as a working in progress. Now that the plan is to more 1.55 from candidate to current in a couple of weeks, I wonder if I’m doing something wrong.
Area lights: 720ms => 220ms
Post effects: 2100ms => 1300ms
Clustered area lights: (600 to 1300ms) => (2600 to 3200ms)
Clustered lighting: 100ms => 250ms

Closing, based on this replay from the original poster:
In our PCs all examples work perfectly, smooth at 60fps. I’m talking about GPU 4.5ms and CPU 1.4ms in the post-effects one. The clustered-area-lights even better, GPU 0.9 ms and CPU 2.1 ms
It looks that only my laptop had the problem.
I didn’t know about it, and I really thought playcanvas was having a really bad time updating to 1.55 . The laptop issue is really something unfortunate.


Add recent API endpoints

Added support and tests for the following API endpoints:

blog: /blocks, /followed_by, /following, /notes, /notifications, /posts/{post_id} (GET request only), /posts/queue/reorder, /posts/queue/shuffle
user: /filtered_content

Also:

Bumped '.travis.yml' Ruby versions to 2.6, 2.7, and 3.0.
Bumped Gem version number to 0.8.6.

Thanks @Snarp, this looks really useful!
Maybe someone like @cyle knows who @tumblr can review/merge/release this?

Thanks for all the work!


Provide full definition spans in C++

C++ has defines/binding edges but no defines edges.

It looks like the /kythe/edge/defines is missing entirely for the function when this happens. Presumably it is in the .h file where the function is declared.

However, if we follow the /kythe/edge/completes edge, and get xrefs for that ticket, we can see that the definition for the function also has the wrong span, consisting of only the binding span, instead of the full defines span.
This doesn't seem to happen for other languages where something is defined and declared separately (I only checked the example of interfaces with java)

C++ does not currently emit "defines" edges which are not "defines/binding".

Apart from being a nice thing to do, is there a direct benefit? Like the serving table containing extra info, or the UI likely being to exploit in some shiny way?
One comes to mind is deriving outlines based on containment of binding anchors (so without using explicit childof relations)?


1141 decision based walker

Description
Create Decision Based Walker
Changes
Created decision based walker
added command line option to use it
Additional notes
cucumber tests have been copied from if.feature
Issue
Resolves #1141

@ms14981 all tests now run against the decision based walker


Update styled-components to 2.2.2

Start seeing this issue in the console when opening the presentation:
Warning: Usage of `context.__styled-components__` as a function is deprecated. It will be replaced with the object on `.context.__styled-components__next__` in a future version.

I checked through the code and didn't find any places where styled-components' context used, so just updated the dependency. Should remove the warning.

I don't see the warning message you mentioned when running the react-presents demo app either locally or on the production build. I assume this is a warning you're seeing in one of your presentation apps then? What are you doing differently to trigger it, I wonder?
I'm reluctant to bump to a new major version for a dependency as that probably should only be done after a major update to this library (which I wasn't planning). It also looks like that deprecation message is still around in styled-components, so if your app was triggering it before it should still- unless the bug was just a transient one on the styled-components side?

I'm using the latest version of styled-components in my project and also react-presents. This message appears only when i'm oppening the presentation. I didn't use styled components contest anywhere in my project. I have also checked react-presents repo for this. Then i checked my yarn.lock file and found that react-presents uses older version. Maybe it somehow overlaps because there are ThemeProviders from different versions active at the same time. So i thought the version update will solve the issue.

Hm. It's possible.
For now you could instruct your project to use the newer styled-components by adding a resolutions section to your package.json. Something like:
"resolutions": {
  "react-presents/styled-components": "2.2.2"
}

This would tell Yarn to just use the newer version, regardless of what react-presents says.

Thanks, it fixed the issue.

Cool 👍


Star imports

https://github.com/bessagroup/rvesimulator/blob/420db1b9b9b6800006a06689cb645cc71873bfe4/src/rvesimulator/additionals/__init__.py#L1
It is better to define the imports instead of using a star import

fixed


COOPR-585 Better Coopr Server memory allocation

Defaulting this is a better solution than detecting if /opt/coopr exists.

:+1:


cool project!

nice to see you are using Capstone in this tool! but the project still has "No description or website provided." ?
keep it up, cheers.

Thanks for the encouragement. I've added a repository description and website.

great, link to your tool from our website now: http://www.capstone-engine.org/showcase.html
cheers.


ci: optimize make generate and update to go 1.19

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/hold


fix: svgs now respond to theme colors when the enhance inputs is on (resolves #266)

[X] This pull request has been linted by running npm run lint without errors
[X] This pull request has been tested by running npm run start and reviewing affected routes
[X] This pull request has been built by running npm run build without errors
[X] This isn't a duplicate of an existing pull request

Description
To resolve #266.
SVGs now respond to theme colors correctly when the enhance inputs is on. This issue is fixed by attaching css with each theme selector rather than a generic selector with a low specificity.
Steps to test

Open UIO and turn on "enhance inputs";
Select a contrast theme;
Check logo, svgs on the header and footer, placeholder svgs on the "views" page;
The color of all of them should respond to the selected theme;
Select a few other themes and check SVGs again.

Expected behavior:
The color of SVGs should respond to the selected theme regardless the "enhance inputs" is turned on or not.

This fix has been included in the pull request #233.


Rails app still can't deploy during assets:precompile

Tried to upgrade to cssbundling-rails 1.3.3 or 1.4.0 which support bun, and deploy to heroku with this buildpack
(Same deal with jsbundling-rails 1.1.2 -> 1.2.2, 1.3.0 due to similar bun support added)
-----> https://github.com/jakeg/heroku-buildpack-bun app detected
#=#=#                                                                         bun was installed successfully to /tmp/build_b164eac6/.heroku/bin/bun
Manually add the directory to ~/.bash_profile (or similar):
  export BUN_INSTALL="/tmp/build_b164eac6/.heroku"
  export PATH=$BUN_INSTALL/bin:$PATH
To get started, run:
  bun --help
Installing dependencies...
[0.04ms] ".env.production"
bun install v1.1.12 (43f0913c)
+<EMAIL_ADDRESS>...
+<EMAIL_ADDRESS>579 packages installed [2.21s]
Blocked 1 postinstall. Run `bun pm untrusted` for details.
-----> Ruby app detected
-----> Installing bundler 2.5.6`
...

-----> Installing node-v20.9.0-linux-x64
-----> Installing yarn-v1.22.19
-----> Detecting rake tasks
-----> Preparing app for Rails asset pipeline
       Running: rake assets:precompile
       I, [2024-06-05T14:06:00.286037 #3047]  INFO -- ddtrace: [ddtrace] DATADOG CONFIGURATION - CORE - {"date":"2024-06-05T14:06:00Z","os_name":"x86_64-pc-linux","version":"1.23.0","lang":"ruby","lang_version":"3.3.2","env":"staging","service":"rake","dd_version":null,"debug":false,"tags":"env:staging","runtime_metrics_enabled":false,"vm":"ruby-3.3.2","health_metrics_enabled":false,"profiling_enabled":false}
       [dotenv] Loaded .env.production
       [dotenv] Loaded .env.staging
       [dotenv] Loaded .env.production
       rake aborted!
       cssbundling-rails: Command install failed, ensure bun is installed
       /tmp/build_b164eac6/vendor/bundle/ruby/3.3.0/gems/cssbundling-rails-1.4.0/lib/tasks/cssbundling/build.rake:6:in `block (2 levels) in <main>'
       /tmp/build_b164eac6/vendor/bundle/ruby/3.3.0/gems/ddtrace-1.23.0/lib/datadog/tracing/contrib/rake/instrumentation.rb:30:in `execute'
       Tasks: TOP => assets:precompile => css:build => css:install

The failing line in cssbundling-rails https://github.com/rails/cssbundling-rails/blob/e650c9ab135504cc2f8b8405c41cdebad5ede66f/lib/tasks/cssbundling/build.rake#L26
I downgraded back to 1.2.0 and removed the buildpack, and my deploys are building again.
Here is our buildpack list now (after removing bun; it had been listed before node's)

@joemsak can you confirm if this is still a bug?

Trying today, will let you know. Thanks!

Hey, no, sorry, it still broke (with the only change being that I upgraded the 2 gems):
Building on the Heroku-22 stack
-----> Deleting 3 files matching .slugignore patterns.
-----> Using buildpacks:
       1. heroku/exec
       2. https://github.com/mojodna/heroku-buildpack-jemalloc.git
       3. heroku/metrics
       4. heroku/nodejs
       5. heroku/ruby
       6. https://github.com/jakeg/heroku-buildpack-bun
-----> Heroku Exec app detected
-----> jemalloc app detected
-----> Vendoring binaries
       Fetching https://github.com/mojodna/heroku-buildpack-jemalloc/releases/download/4.2.1/jemalloc-4.2.1-1.tar.gz
-----> Configuring build environment
-----> Building runtime environment
-----> HerokuRuntimeMetrics app detected
-----> Setting up .profile.d to automatically run metrics agent...
-----> Node.js app detected

-----> Creating runtime environment

       NPM_CONFIG_LOGLEVEL=error
       USE_YARN_CACHE=true
       NODE_VERBOSE=false
       NODE_ENV=production
       NODE_MODULES_CACHE=true

-----> Installing binaries
       engines.node (package.json):   ^22
       engines.npm (package.json):    unspecified (use default)
       engines.yarn (package.json):   unspecified (use default)

       Resolving node version ^22...
       Downloading and installing node 22.4.1...
       Using default npm version: 10.8.1
       Resolving yarn version 1.22.x...
       Downloading and installing yarn (1.22.22)
       Installed yarn 1.22.22

-----> Restoring cache
       - yarn cache

-----> Installing dependencies
       Installing node modules (yarn.lock)
       yarn install v1.22.22
       [1/4] Resolving packages...
       [2/4] Fetching packages...
       [3/4] Linking dependencies...
       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.2.0".
       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning "eslint-config-airbnb ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.2.0".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.0.0".
       warning "eslint-config-react-app > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
       warning "eslint-config-react-app > eslint-plugin-jest ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       [4/4] Building fresh packages...
       Done in 19.34s.

-----> Build
       Running build (yarn)
       yarn run v1.22.22
       $ node esbuild.config.js
       Done in 1.00s.

-----> Pruning devDependencies
       yarn install v1.22.22
       [1/4] Resolving packages...
       [2/4] Fetching packages...
       [3/4] Linking dependencies...
       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.2.0".
       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>       warning "eslint-config-airbnb ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.2.0".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>       warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0".
       warning "eslint-config-react-app ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^8.0.0".
       warning "eslint-config-react-app > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning "eslint-config-react-app > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
       warning "eslint-config-react-app > eslint-plugin-jest ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^7.0.0 || ^8.0.0".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
       warning " ><EMAIL_ADDRESS>has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
       [4/4] Building fresh packages...
       warning Ignored scripts due to flag.
       Done in 2.70s.

-----> Caching build
       - yarn cache

-----> Build succeeded!
 !     Unmet dependencies don't fail yarn install but may cause runtime issues
       https://github.com/npm/npm/issues/7494
-----> Ruby app detected
-----> Installing bundler 2.5.6
-----> Removing BUNDLED WITH version in the Gemfile.lock
-----> Compiling Ruby/Rails
-----> Using Ruby version: ruby-3.3.2
-----> Installing dependencies using bundler 2.5.6
       Running: BUNDLE_WITHOUT='development:test' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       Fetching gem metadata from https://rubygems.org/........
       Fetching gem metadata from https://enterprise.contribsys.com/..
       Fetching cssbundling-rails 1.4.0
       Fetching jsbundling-rails 1.3.0
       Installing cssbundling-rails 1.4.0
       Installing jsbundling-rails 1.3.0
       Bundle complete! 109 Gemfile dependencies, 191 gems now installed.
       Gems in the groups 'development' and 'test' were not installed.
       Bundled gems are installed into `./vendor/bundle`
       1 installed gem you directly depend on is looking for funding.
         Run `bundle fund` for details
       Bundle completed (3.76s)
       Cleaning up the bundler cache.
       Removing bundler (2.5.6)
       Removing cssbundling-rails (1.2.0)
       Removing jsbundling-rails (1.1.2)
-----> Detecting rake tasks
-----> Preparing app for Rails asset pipeline
       Running: rake assets:precompile
       [2024-07-11T18:41:08 (process) #2682][INFO] appsignal: Starting AppSignal 3.10.0 (/tmp/build_66b704f7/bin/rake, Ruby 3.3.2, x86_64-linux)
       rake aborted!
       cssbundling-rails: Command install failed, ensure bun is installed
       /tmp/build_66b704f7/vendor/bundle/ruby/3.3.0/gems/cssbundling-rails-1.4.0/lib/tasks/cssbundling/build.rake:6:in `block (2 levels) in <main>'
       /tmp/build_66b704f7/vendor/bundle/ruby/3.3.0/gems/appsignal-3.10.0/lib/appsignal/integrations/rake.rb:15:in `block in execute'
       /tmp/build_66b704f7/vendor/bundle/ruby/3.3.0/gems/appsignal-3.10.0/lib/appsignal/helpers/instrumentation.rb:705:in `instrument'
       /tmp/build_66b704f7/vendor/bundle/ruby/3.3.0/gems/appsignal-3.10.0/lib/appsignal/integrations/rake.rb:14:in `execute'
       Tasks: TOP => assets:precompile => css:build => css:install
       (See full trace by running task with --trace)

 !
 !     Precompiling assets failed.
 !
 !     Push rejected, failed to compile Ruby app.
 !     Push failed

I see your README says to have a procfile with a bun command (we're deploying a rails application, we only need asset precompilation, not a deployed process) or a package.json script.
// package.json
{
  // ...
  "scripts": {
    "lint": "eslint --fix \"**/*.{js,jsx,ts,tsx}\" --fix-type problem",
    "build:css": "tailwindcss -i ./app/assets/stylesheets/application.tailwind.css -o ./app/assets/builds/tailwind.css",
    "doc": "rails rerdoc && servor doc/",
    "build": "node esbuild.config.js"
  }
}

Should we do something else here? We only need rails assets:precompile to work, nothing else. Am I totally missing something or misunderstanding something?

(We're still using Yarn due to lack of support for Bun on Heroku)

Deploys are working with the bundling gems set back to their older versions, and while the buildpack is still installed on our heroku application.

(We're still using Yarn due to lack of support for Bun on Heroku)

This buildpack gives that (unofficial) support.
It's possible that with this buildpack you no longer need yarn/npm/node at all, as bun is designed as a drop in replacement for node.
I'm afraid I'm not sure how to help with your problem though. I'm going to close this issue for now, but feel free to re-open it if you have anything else which I might be able to help with.

Okay but as I said, I tried this build pack again after you made some updates, and we still did not get bun support on heroku.

Same for us unfortunately.
jsbundling-rails: Command install failed, ensure bun is installed even with the bun buildpack loaded before the ruby buildpack. Something in the pipeline triggers a node install as well, even though it is not needed in this setup.

Are you able to provide a minimal example of this bug, that I can test with?
I'm thinking it might be a matter of some file having nodejs specifically in a bash shebang, which you can override by running bunx --bun [command] instead, similar to if you want to run Vite.

Sure! https://github.com/MSchmidt/railsmeetsbun - you can either clone it and run the heroku specific commands from README or if you have ruby/rails installed, you can create everything yourself. It's basically a blank rails project with no changes at all.
If you do the same with rails new <project_name> -j esbuild  instead of -j bun the deployment works.

I found a workaround. jsbundling-rails is the gem that does call bun as part of assets:precompile and fails. However, since this buildpack is already calling bun run build itself, we don't actually need this step to be part of assets:precompile anymore and can skip it with the SKIP_JS_BUILD ENV variable.
See https://github.com/rails/jsbundling-rails/blob/main/lib/tasks/jsbundling/build.rake

I faced a similar issue while using vite and bun in my Rails app. During the assets:precompile step, Vite couldn't find the Bun executable. I'm using sprockets-rails alongside vite_rails with only this and the heroku/ruby buildpack.
Interestingly, when I added this Bun buildpack to a different project and checked via bash, Bun was available, which made me think the issue wasn't with this buildpack itself but rather with Vite.
What worked for me was overriding the assets:precompile task to run Vite's build command manually. Here's my solution:
# lib/tasks/assets.rake

Rake::Task['assets:precompile'].clear

namespace :assets do
  desc 'Precompile assets with my vite build command'
  task :precompile => :environment do
    puts "Customizing assets:precompile"
    system("./bin/vite build")
  end
end

I found a workaround. jsbundling-rails is the gem that does call bun as part of assets:precompile and fails. However, since this buildpack is already calling bun run build itself, we don't actually need this step to be part of assets:precompile anymore and can skip it with the SKIP_JS_BUILD ENV variable.
See https://github.com/rails/jsbundling-rails/blob/main/lib/tasks/jsbundling/build.rake

This worked for me as well. Putting this bun Buildpack ahead of the ruby one and then setting SKIP_JS_BUILD to true, now it's deploying correctly

I found a workaround. jsbundling-rails is the gem that does call bun as part of assets:precompile and fails. However, since this buildpack is already calling bun run build itself, we don't actually need this step to be part of assets:precompile anymore and can skip it with the SKIP_JS_BUILD ENV variable.
See https://github.com/rails/jsbundling-rails/blob/main/lib/tasks/jsbundling/build.rake

Worked for us too! Thank you. We had to add SKIP_CSS_BUILD since we use css-bundling as well

I'm glad the workaround is already helping people but it's still just a workaround. I'd much prefer if the regular assets:precompile task would work and this buildpack would do nothing on it's own besides providing the bun binary to the Heroku build pipeline. Maybe @colincasey can help?

@MSchmidt since the Ruby buildpack can't find the Bun executable without modifying the PATH, I'm pretty sure all that's missing here is the export of environment variables from this buildpack to the next one.
I've made those modifications in #12 though I haven't tested to confirm they work.

Thanks @colincasey – worked right away! The PR is great but for the use case we have with rails it would be great if the buildpack would not run any commands by itself. Right now with the provided fix, we'd build with bun twice.

@MSchmidt that's a problem that the heroku/nodejs has too. Most of the front-end tooling is concentrated in the JavaScript ecosystem so it's common for other language buildpacks to need the tooling provided by the buildpack but not the specific commands that would be appropriate for a pure Node.js project.
It seems this buildpack does provide similar hooks to opt-in/out of some of these commands here. These are also documented in the README.

I've merged PR https://github.com/jakeg/heroku-buildpack-bun/pull/12 - thanks for the contribution.

I tried to switch back from the PR origin/branch and got this:
https://github.com/jakeg/heroku-buildpack-bun app detected
/tmp/codon/tmp/buildpacks/2fc6a4b5922f99bca53f5009c6c9e7c74eba1cd2/bin/compile: line 43: BUN_VERSION: unbound variable
 !     Push rejected, failed to compile https://github.com/jakeg/heroku-buildpack-bun app.
 !     Push failed

I tried to change back from the PR's origin/branch and I set BUN_VERSION=1.1.30 but this still happened
https://github.com/jakeg/heroku-buildpack-bun app detected
/tmp/codon/tmp/buildpacks/2fc6a4b5922f99bca53f5009c6c9e7c74eba1cd2/bin/compile: line 43: BUN_VERSION: unbound variable
 !     Push rejected, failed to compile https://github.com/jakeg/heroku-buildpack-bun app.
 !     Push failed

Can you try again now @joemsak ?

Working now! Thank you! 🙏🙏🙏


most hyperlinks should open in new tab

Show.razor:
Change this line
returnVal += "<a href='https...


Support manually clearing the conpty buffer

From @Tyriar in microsoft/vscode#75141

This is happening because Terminal: Clear tells the frontend (the thing rendering everything) to clear, but the way that the conpty backend works is it will sometimes reprint what it thinks should be visible. Since it doesn't know about our clear it reprints the unwanted output, this doesn't happen on a regular linux/mac backend that conpty is trying to emulate.

Is there anything that can be done here to tell conpty to not reprint the screen? I suspect python.exe does not enter alt mode so I'm not sure why a reprint is necessary.

Thoughts: new thing to put on the signal pipe? We don't want to introduce too many non-standard VT things to the in/out pipes, so the signal pipe is our "get out of jail free" card.

I don't think this is a good idea for that reason.

Sorry, I think you'll need to be more specific about what this and that reason are.

We don't want to introduce too many non-standard VT things to the in/out pipes

So, okay, if I understand this correctly:
You're asking for us to cut this feature request, because you do not believe that we should add support for it; you do, however, still want it to exist?

I think there's a bug as @zadjii-msft indicated in the linked issue that I want fixed instead of adding non-standard stuff to conpty. Setting a variable and printing it in Python should not redraw the entire screen, see https://github.com/microsoft/vscode/issues/75141#issuecomment-500144248 for context.

Well, I think the bug might be making this issue more apparent, but I don't think fixing the bug mentioned will actually properly resolve this issue. It might temporarily hide the issue, by allowing the cursor to start printing text again at the origin. However, the text wouldn't actually be at the origin in conpty's buffer, and it's entirely possible that another action could cause conpty to need to redraw everything - at which point, all the old text would re-appear, and the new text would suddenly shift to where conpty thinks it is.
For *nix, VSCode's terminal clear works just fine because the pty is just a dumb pipe - when you clear the frontend's buffer, there's nothing on the backend that still thinks that there's any text in the buffer, because there is no buffer.
However, with conpty, because there is an actual buffer on the backend, we can't just clear the frontend like that. The conpty buffer will still think something's there. Since this is a problem unique to conpty & windows, I think it's unfortunately something that needs a unique solution.
I'm half way on board with adding another signal to the signal pipe - that'll clearly work unique to Windows, since it'd introduce another API to our API surface. If we want to avoid adding another signal here, we could maybe add the clear by making conpty resond to something like ^[[3J on the input. However, I know that doing the resize on the input pipe also had some problems with making sure the resize sequence wouldn't be broken up by other input sequences, esp for WSL and docker. Hence the addition of the signal pipe. I think the signal would end up being the safest, most robust solution.
I really want to make sure we avoid API creep on the conpty API though. We need to make sure that this is something that's definitely not accomplish-able by some other means.

@zadjii-msft I get that there will be times when it fails just as it will on nix (eg. running clear in the alt buffer) and I'm fine with the Terminal Clear command not working properly in those cases. Fixing the conpty-specific cases doesn't seem worth it since it can happen off with a native pty too.
Isn't conpty meant to be pretending to be a dumb pipe here in the same way as a native pty? I tried doing that same action to run the current Python file on a mac and it will just print a bunch of characters, CR, LF and use the character attribute escape (CSI m). In a similar way it would be lovely if conpty did not reprint the screen when resized unless something actually changed, ie. a line in the viewport is wrapped or will be wrapped.

 That's the major contention here: there is a 35-year history of win32 console applications that have access to the output buffer.
Any concessions we've made in what ConPTY can do and does do are in the pursuit of the broadest possible compatibility.

Why not to support 2 modes of ConPTY: plain "dumb pipe" and ConPTY with legacy support of 35-year history of win32 console? :)

@MaxRis you might be interested in #1173

it seems that:
clear or cls will clear scroll buffer in PowerShell.
cls will clear scroll buffer in CMD.
but clear OR reset OR CSI sequence not clear scroll buffer in bash.
can we have some workaround to implement buffer clear:
associate  some shortcut keys (or something else) to call  windows clear or cls  to current "tty". (Bypass the current running bash.exe , ssh.exe..),

@yurenchen000 Are you using Cygwin, MSYS, or MinGW bash? If so, what version of the runtime are you using? Certain versions of the Cygwin runtime delete CSIs.
Clearing the buffer works fine from bash, so long as the CSI is not deleted.

@yurenchen000 Are you using Cygwin, MSYS, or MinGW bash? If so, what version of the runtime are you using? Certain versions of the Cygwin runtime delete CSIs.
Clearing the buffer works fine from bash, so long as the CSI is not deleted.

thanks a lot.
seems printf "\e[H\e[2J\e[3J" will clear scroll buffer, in some situations (not all).
I use lots of cli environment:

GNU bash, version 4.4.23(1)-release //from git-bash (msys // not clear scroll buff
GNU bash, version 4.4.23(2)-release (x86_64-pc-msys) //from MSYS2
adb shell
ssh to ubuntu18

can I ignore the CLI environment,
and have a terminal itself's GUI option (mouse right menu or shortcut key) to clear scroll buffer?

Alright, worked on this a bit in dev/migrie/fhl-2021/clear-buffer-action. Small bits of trickiness:

We need to preserve the cursor line. SCREEN_INFORMATION::VtEraseAll is not the thing we'd want to use to do this - that pretty blindly just scrolls away the old buffer contents into scrollback. We could:

Just scroll everything above the cursor out, and leave everything below it. This would be weird for something like vim.
Copy the contents of the cursor row into a temp buffer, scroll everything, then restore that line to the top of the viewport. This would also be weird for something like vim.

I mean, this almost certainly will never do the right thing for a full screen app so we may as well do i. because it's easier now.

[ ] I should revert the changes I made to AdaptDispatch and DispatchCommon. These changes won't be necessary anymore, so better to remove them, and reduce the likelyhood that someone else uses them wrong.
[ ] I should add a new DispatchCommon::s_ClearBuffer method, that PtySignalInputThread::_DoClearBuffer calls.
[ ] That should get plumbed through to something just like SCREEN_INFORMATION::VtEraseAll, but with clearing everything above the cursor, and leaving the cursor on the top row of the viewport.
[ ] Maybe just ignore doing this always when in the alt buffer? Would reduce cases where vim et al. will definitely do the wrong thing.


Set CMS strategy -- where and how will project admins create and edit content?

Ideas to investigate:

WordPress template
Using Github as a super-simple CMS


Try adding macOS to CI

dyld: lazy symbol binding failed: Symbol not found: _curl_multi_poll
  Referenced from: /Users/runner/work/http4s-curl/http4s-curl/curl/target/scala-3.1.3/http4s-curl-test-out
  Expected in: /usr/lib/libcurl.4.dylib

dyld: Symbol not found: _curl_multi_poll
  Referenced from: /Users/runner/work/http4s-curl/http4s-curl/curl/target/scala-3.1.3/http4s-curl-test-out
  Expected in: /usr/lib/libcurl.4.dylib

macOS is not my daily driver. Help wanted! :)

Relevant? https://developer.apple.com/forums/thread/672026

I used "brew install curl" and got a full, working link.
The .yml has a section to install libcur4-openssl-dev on linux
I think it needs a section for macos which does the "brew'ing above.

FYI,
When I clone the repository into a fresh directory, macOS 12.5 M1 and "sbt test"
I get the failure curl_easy_setop: 1 twice, once for get and once for post.
Perhaps http4s does not like the Southern heat?
So, no magical cures to building.
I can try an example program which uses the published
artifacts, either/both macOS (M1)  & Ubuntu 22.04 (X86_64).
If those work, then the Issue of building falls to a (vanishingly) low priority.

That's bizarre.
CURLE_UNSUPPORTED_PROTOCOL (1)

The URL you passed to libcurl used a protocol that this libcurl does not support. The support might be a compile-time option that you did not use, it can be a misspelled protocol string or just a protocol libcurl has no code for.

https://curl.se/libcurl/c/libcurl-errors.html
Let's see what CI things of brew :)

Sadly, the brew install curl results in the same error. Indeed, seems that curl is already installed via brew 😂
Run brew install curl
  brew install curl
  shell: /bin/bash -e {0}
  env:
    PGP_PASSPHRASE:
    SONATYPE_PASSWORD: ***
    SONATYPE_CREDENTIAL_HOST:
    SONATYPE_USERNAME: ***
    PGP_SECRET: ***

    GITHUB_TOKEN: ***
    JAVA_HOME: /Users/runner/hostedtoolcache/Java_jdkfile_jdk/17/x64/Contents/Home

Warning: curl 7.84.0 is already installed and up-to-date.
To reinstall 7.84.0, run:
  brew reinstall curl

I do not understand, if curl was installed, why did your first pass not find the .dynlib?  Arrgh.
So, I suggest a section in the README saying "Artifacts only", so the eager people have
some idea of where the edge of the world is.
So many bugs, so little time.

brew info curl tells me the following:
==> Caveats
curl is keg-only, which means it was not symlinked into /usr/local,
because macOS already provides this software and installing another version in
parallel can cause all kinds of trouble.

If you need to have curl first in your PATH, run:
  echo 'export PATH="/usr/local/opt/curl/bin:$PATH"' >> /Users/armanbilge/.bash_profile

For compilers to find curl you may need to set:
  export LDFLAGS="-L/usr/local/opt/curl/lib"
  export CPPFLAGS="-I/usr/local/opt/curl/include"

For pkg-config to find curl you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/curl/lib/pkgconfig"

Perhaps you have some special configuration on your local?

As per brew instructions
  export LDFLAGS="-L/usr/local/opt/curl/lib"
  export CPPFLAGS="-I/usr/local/opt/curl/include"

Sorry for the misinformation about FLAGS. I did a cut & paste of the
post above it and got it wrong.
I ought to be able to get over this, but it gnaws on me.
I am going to fork this repository and so that I can thrash
on the mac build without sucking up the time of other people.
export LDFLAGS="-L/opt/homebrew/opt/curl/lib"
 export CPPFLAGS="-I/opt/homebrew/opt/curl/include"

CI here is running macOS 11.mumble and my system is at 12.5,
so world apart.

I think there is a life lesson in here somewhere.  So much effort leading to victory where that victory itself
is a failure.
A cleaned up and scalaformat'ed version of this edit to build.sbt gets http4s-curl working on macOS CI
in my fork of this project.  A warning, it is not pretty so people of wisdom or tender sensibilities should
look away now:
ThisBuild / nativeConfig ~= { c => {
    val osName = System.getProperty("os.name")
    val isMacOs = osName.toLowerCase().startsWith("mac os x")
    if (!isMacOs) {
      c // do not change
    } else {
         c.withLinkingOptions(c.linkingOptions ++ Seq(
                            "-L/usr/local/Cellar/curl/7.84.0/lib"))
    }
  }
}

Someone with a better knowledge of sbt, or myself after I have had a rest, could probably
make that less ugly.
The whole curl/7.84.0 business seems incredibly likely to break over time.
At least it works today, which has another 3 minutes to go.
With this & no changes to ci.yml (no additional environment variables), http4s-curl
test links & runs on both GitHub mac-latest (11.mumble) and mac-12 (Monterry-mumble).
That is the victory part which gets to both/all failing with curl_easy_pause: 43 in two places
each: get & post.
At least now we know.  CI is doing its job

Thanks! Actually this is a big help. It seems that there was a change in modern libcurl that is causing the curl_easy_pause: 43 error. Now that we can replicate the issue on both macOS and ubuntu it will hopefully make it easier to solve (or find someone to solve it :)

I was able to get it running on my local macOS with this snippet:
ThisBuild / nativeConfig ~= { c =>
  val osName = Option(System.getProperty("os.name"))
  val isMacOs = osName.exists(_.toLowerCase().contains("mac"))
  if (isMacOs) { // brew-installed curl
    c.withLinkingOptions(c.linkingOptions :+ "-L/usr/local/opt/curl/lib")
  } else c
}

All that's left now is to fix https://github.com/http4s/http4s-curl/issues/6 😂


--removekeywords passed: Keyword data for keywords without warnings or errors is not removed if another keyword in a passed test has a warning

The documentation for --removekeywords mentions "Keywords that contain errors or warnings are not removed except when using the ALL mode." Perhaps there are a couple ways to interpret this? My interpretation (and hope) is that when using --removekeywords passed, that keywords that contain warnings/errors in a passed test case do not have their data removed, but other keywords in that test case that do not contain warnings/errors would still have their data removed. However, this is not the case. If I use --removekeywords passed, a passed test case with at least one warning/error will have no keyword data removed, even if there are some keywords with no warnings/errors.
Changing this behaviour to match my hope/interpretation would be helpful as it would allow me to reduce the size of a log (especially when combining logs), even on a codebase that is a bit overzealous with logging warnings.

The motivation for leaving all keywords if there are warnings is that you often need them to debug the problems. I can understand that in your case that benefit isn't as big as the problems, but in my opinion the current behavior is better in general and changing it would also be backwards incompatible.
Good news is that you can pretty easily create a --pre-rebot-modifier that removes more data than --remove-keywords passed removes.  We could also consider adding a new mode that behaves like you propose, but I don't consider it too high priority. If you'd be interested to provide a PR implementing it and have a good name for the new mode, I'm fine keeping this issue open. Otherwise I believe it's best to close it.


issue push events

18/03/01 13:57:15 WARN TaskSchedulerImpl: Initial job has not accepted any resources; check your cluster UI to ensure that workers are registered and have sufficient resources

update

test, events.


RN-36 Update status bar color

Summary
With this PR the status bar on IOS will change the color to use white if the theme header color is dark or to use black if the header color is light.
Ticket Link
https://mattermost.atlassian.net/browse/RN-36
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Has UI changes

well I can go ahead and take the functions needed from the library, but the library in itself is really small so I  think is safe to leave it


Improvements to no-op subsegment behavior

Description of changes:
This PR includes a few changes involving no-op subsegment behavior to correct regressions:

Add a new shouldPropagate field to subsegments, so that we can distinguish between no-op subsegments that are unsampled and no-op subsegments which are created from context missing exceptions.
In LambdaSegmentContext, fixed the endSubsegment behavior to use the context missing strategy instead of always throwing an exception.
Changed the logging logic for ending no-op subsegments to make debug logs more clear

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #294 (e7eb3d2) into master (5143932) will increase coverage by 0.01%.
The diff coverage is 58.82%.

@@             Coverage Diff              @@
##             master     #294      +/-   ##
============================================
+ Coverage     58.86%   58.88%   +0.01%
- Complexity     1202     1206       +4
============================================
  Files           131      131
  Lines          5056     5073      +17
  Branches        588      591       +3
============================================
+ Hits           2976     2987      +11
- Misses         1807     1812       +5
- Partials        273      274       +1

Impacted Files
Coverage Δ

...va/com/amazonaws/xray/handlers/TracingHandler.java
38.13% <0.00%> (-0.39%)
:arrow_down:

.../main/java/com/amazonaws/xray/AWSXRayRecorder.java
63.74% <0.00%> (ø)

.../amazonaws/xray/contexts/LambdaSegmentContext.java
78.57% <0.00%> (-2.32%)
:arrow_down:

...a/com/amazonaws/xray/entities/DummySubsegment.java
0.00% <0.00%> (ø)

...ray/javax/servlet/AWSXRayServletAsyncListener.java
61.11% <ø> (-7.08%)
:arrow_down:

...onaws/xray/contexts/ThreadLocalSegmentContext.java
77.77% <25.00%> (-3.62%)
:arrow_down:

...va/com/amazonaws/xray/entities/NoOpSubSegment.java
91.66% <71.42%> (-1.93%)
:arrow_down:

...aws/xray/proxies/apache/http/TracedHttpClient.java
40.44% <80.00%> (-0.46%)
:arrow_down:

...mazonaws/xray/interceptors/TracingInterceptor.java
60.00% <100.00%> (+0.88%)
:arrow_up:

...n/java/com/amazonaws/xray/entities/Subsegment.java
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5143932...e7eb3d2. Read the comment docs.

@anuraaga any chance for a second look here and on #293?


slicestable.tsv,genes_new.txt,barcode_level_layer_map.tsv

Dear professor:
The work here is highly valuable. I want to replicate the workflow according to the examples, but I can't find several important files. They are "./data/molecular-atlas-master/data/slicestable.tsv" in Example 1, "./genes_new.txt" in Example 2, and "./data/spatialLIBD/barcode_level_layer_map.tsv" in Example 4.
Could you tell me where I can download them?

Hi,
you can get the files following the instruction:
https://github.com/YangLabHKUST/STitch3D/issues/1
https://github.com/YangLabHKUST/STitch3D/issues/5
https://github.com/YangLabHKUST/STitch3D/issues/23#issuecomment-1987879480

Thank you very much for your assistance.


dulwich: use untracked_files="no" in is_dirty

This will speed up calling is_dirty when untracked_files=False
related to #69

Was this tested with dvc?

Was this tested with dvc?

Not yet, why?

@dtrifiro Well, it is not good if it will break dvc tests 😄 Let's not release this until it is tested.

@dtrifiro Well, it is not good if it will break dvc tests smile Let's not release this until it is tested.

:sweat_smile: indeed, although it does not change existing behaviour. Running tests right now

No tests fail when running locally: Works on my machine®
Currently running some CI tests here with scmrepo@main:
https://github.com/dtrifiro/dvc/actions/runs/2352088728

@pmrowla Could you take a final look as well, please?


csproj in different folder breaks NetCoreBeauty

Let's say I have a project in Source/Hello/World.csproj.
To publish I can do:
dotnet publish Source/Hello -r win-x64 -c Release

Specifying the csproj's folder like that makes NetCoreBeauty not apply it's changes (no errors are written in the console though).
If instead I do:
cd Source/Hello
dotnet publish -r win-x64 -c Release

NetCoreBeauty will work.

fix in v1.1.6, update nuget package to v1.1.6 will fix.


STYLE: Change link colors

Change link colors: current default colors seems to be white, which is not
visible over a white background.

Thanks for the catch and the PR! I've pushed soem changes on the master including your changes, can you confirm it is now appearing? I couldnt spot a white link, but maybe I was looking at the wrong place.
Let me know and I'll close the PR if all ok.

Thanks for the catch and the PR! I've pushed soem changes on the master including your changes, can you confirm it is now appearing? I couldnt spot a white link, but maybe I was looking at the wrong place.
Let me know and I'll close the PR if all ok.

The color of the links has changed and they are now visible. The issue has thus been fixed. Closing the PR.


WLT-MRTK3-Port

The community might find this handy.
https://github.com/Fuzzy-Door-Tech/WLT-MRTK3-Port
We have been using this port for months with MRTK3, Unity 2021 and Unity 2022. It primarily provides support for using AR Foundation's XROrigin and related changes.

Relevant to #317

Please note this issue regarding the AR Pose Driver and the temporary fix
https://github.com/Unity-Technologies/arfoundation-samples/issues/1063#issuecomment-1602161095

As someone new to Unity the steps to install this were not obvious, so I'll share what worked for me:

Add WLT Core to your project via the Mixed Reality Feature Tool.
Download the port linked above and place the files somewhere in your project's Packages folder. For example, I put it under Packages/WorldLockingTools.
Find the com.microsoft.mixedreality.worldlockingtools archive under Packages/MixedReality and open it. Inside this archive you should see another Packages folder.
Copy the archive's Packages folder into the folder containing the port.
Finally, in your project's manifest.json, replace the com.microsoft.mixedreality.worldlockingtools dependency with the path to the port:

"com.fuzzydoortech.worldlockingtools": "file:WorldLockingTools"

And delete the original com.microsoft.mixedreality.worldlockingtools archive.


node-fetch response headers "missing" due to API difference

Unlike with got and request the response object from node-fetch doesn't treat the response headers as a standard object and the API requires a different access mechanism (e.g. resp.headers.get('header-name')) - https://github.com/node-fetch/node-fetch#class-headers; standard property access means do not work.
I ran into this in #7021 because the GitLab API-based badges are using the standard request fetcher while needing to inspect the response headers, unlike other response-header-inspecting badges which utilize a custom request fetcher (e.g. GitHub).
I can see two paths to resolve this, we either allow some more of the underlying http client specifics to bleed through the encapsulation layer to consuming service classes, or, map/convert the response headers within the encapsulation layer similar to how we're encapsulating the mapping/conversion of the http request parameters within the encapsulation layer as well as the returned object property names.
I definitely prefer the latter and will open a PR to that effect, but certainly open to discussion.
cc @chris48s

Sounds like a topic for discussion at tomorrow's meeting (presuming my calendar isn't out of whack again and we are indeed meeting :laughing:)


comments: user reports being shown an “edit” button even though he’s not the user in question

On Twitter, Stuart Robson mentioned being shown an edit button on someone else’s comment: https://twitter.com/sturobson/status/734812595341930503
This was re: Tim Baxter’s CSS article: http://alistapart.com/article/meaningful-css-style-like-you-mean-it
Decided to create an issue when I didn’t see any mention of this in Slack. Disregard if you’re already on it!

Thanks, Caren!
Sent from my iPhone

On May 24, 2016, at 7:01 PM, litherland<EMAIL_ADDRESS>wrote:
On Twitter, Stuart Robson mentioned being shown an edit button on someone else’s comment: https://twitter.com/sturobson/status/734812595341930503
This was re: Tim Baxter’s CSS article: http://alistapart.com/article/meaningful-css-style-like-you-mean-it
Decided to create an issue when I didn’t see any mention of this in Slack. Disregard if you’re already on it!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Sigh, caching really throws a monkey in the wrench of useful features.

On May 24, 2016, at 7:01 PM, litherland<EMAIL_ADDRESS>wrote:
On Twitter, Stuart Robson mentioned being shown an edit button on someone else’s comment: https://twitter.com/sturobson/status/734812595341930503 https://twitter.com/sturobson/status/734812595341930503
This was re: Tim Baxter’s CSS article: http://alistapart.com/article/meaningful-css-style-like-you-mean-it http://alistapart.com/article/meaningful-css-style-like-you-mean-it
Decided to create an issue when I didn’t see any mention of this in Slack. Disregard if you’re already on it!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/alistapart/AListApart/issues/377


Documentation question

Is this the appropriate place to post corrections/issues with the documentation?
In https://mc-stan.org/docs/2_26/stan-users-guide/coding-mrp-in-stan.html#coding-binary-groups
I think the example bits might need a "to_vector" (or something?) around the {epsilon, -epsilon}[sex] term in the vectorized model expression.  Otherwise, at least when I try, I get a compiler error about the types given to "+" when I add the scalar (real) alpha.  Adding to_vector fixes this.

See below
https://github.com/stan-dev/docs

Thanks!  Will raise there.


Mark GroupWidget determined dimensions !important

GroupWidget determined dimensions should take precedence. #593

Yes, I think !important, though generally to be avoided, is the way to go here.

Not sure why the pypy build is suddenly failing, but it can hardly be this change, so I'm merging.

Thanks @jrversteegh !


TypeScript Support

Can you provide a way to use this component within TypeScript.
I tried the same workaround found for the vue-good-table, but this doesn't work for this component:
https://github.com/xaksis/vue-good-table

If anyone is interested, I found an ugly workaround using @ts-ignore on the import:
// @ts-ignore
import VueDragResize from 'vue-drag-resize'

Then I can use it with the vue-component-decorator:
@Component({
	components: {
		VueDragResize,
	}
})

It would be great if it could be used the same way as VGT mentioned above.

Seems this project is dead anyway.


[TE] Show which rule detected the anomaly in RCA page

Closed this PR due to 6 months inactivity. Reopen if needed.


idp_not_found error

django error when retrieving the idp. brings the error idp_not_found.

python-saml needs to know the IdP Entity ID, endpoints and its x509 cert.
Review that you have properly configured that info at the settings


Parameters for filters and sorts in a query

As a future work you pointed Queries will accept parameters.
What I propose is parameter should be declared as Entity to harness DisplayManager composition advantages.
We will have different types of parameters with its drivers for edit and display
i.e.: taxonomyFilter Driver, int Driver those like in orchard one will allow us to configure filters, but if we configure them as client side filter they will be also used for displaying the filter in the client for providing an UI to the user to provide a value for the parameter.
For sorting sth similar would be needed, allowing the user to choose between different sort options.

The solution I implemented is much simpler, it's just a json object to send to the query.

Cool. It sounds like you keep query module simple because other will take the responsability of rendering. Looking forward your demo 😊
I will keep attention on how a dev can override default renderization of a param when it is showed to end user for giving him the opportunity of providing a param value for the query.

You can pass parameters in queries and use them in filters and sort.


filter images by name when loading the image from the openstack api

What this PR does / why we need it:
This change will add the desired image name to the request so the API takes care of filtering.
This will avoid that the controller checks all existing images.
NONE

/lgtm
/approve

/test pull-machine-controller-e2e


Update graphql and graphl-client versions

Changes
Bump graphql and graphql-client versions.
Why
In order to Bump the graphql version to the latest on Jobber, we have to update it at library_version_analysis first since it has a block that does not allow us to go over the version we have today.

cc @naarok

Provided changes suggested by @crpahl are done, I'm good with this.

@naarok Some specs were broken which @daiaventureira as part of this PR. Any concerns with these changes? Also, is there anything else we should test other than running specs?
And to release a new version after this is merged, I'm guessing we still follow this?

To release a new version, update the version number in version.rb, and then run bundle exec rake release, which will create a git tag for the version, push git commits and tags, and push the .gem file to rubygems.org.

@crpahl hmm. This code is actually in an interim state between old way and rewrite. I’m gonna have to think about how to deploy a bit. I’ll make sure that happens tomorrow.
in fact it is probably best for me to take over completing this PR as well. I have time tomorrow for that.

@naarok Okay sounds good. Thanks John!

@daiaventureira @crpahl Happily, the code on master was in better state than I feared (except for those broken specs. Thanks for fixing them @daiaventureira )
As an FYI, those instructions for doing a new release were just from the generated template and not valid for this library as it is not pushed to RubyGems. I've removed them.
A new release requires us to bump the version number in this repo (and update the changelog). A 2nd PR will need to be done in JO to update the library there. I'll do that and pass on to you for review.


Any way to add transparency to geotiff layer

Is there any way to add opacity to the geotiff layer? I tried with this but it's not wprking.
const windSpeedOptions = {
            opacity: 0.5,
        };

see https://github.com/stuartmatthews/leaflet-geotiff/issues/9

How can i change the lat lng to different location it is inbuilt location in austraila


GeoJSON.resetStyle: allow invocation without an argument

When no argument is provided, the style of each of the layers in the
GeoJSON layer is reset.
Fixes #4298

Seems like a nice & simple addition, but your PR is breaking the continuous integration tests. Please check https://travis-ci.org/Leaflet/Leaflet/builds/531842818? and fix accordingly. Looks like it's just eslint complaining about the coding style.

fixed :-)

Hi,
Thank you for your contribution and sorry for the delay before merging this!


[test] enable zoneout lstm test

enable zoneout lstm test
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1775. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


print image 1bit bitmap

hi. can you help me print file image? please.

From my experience EPSON TM88 series requires 8-bit or higher bitmap images. It cannot print 1-bit BMP files. In my app, I collect a signature which is a 1-bit BMP image and have to convert it to 8-bit BMP before printing it.


chore: update building doc

Update building instruction for ubuntu 22.04 and remove it for ubuntu 20.04 as it looks outdated

prnet cleaned-up successfully


Does Buildalyzer supports .net website projects?

Website projects doesn't have .csproj file, how can I build website projects using buildalyzer.
AnalyzerManager analyzerManager = new AnalyzerManager(solutionPath);
var projects = analyzerManager.Projects; //Project count is zero as it is a website project

It will be really great if buildalyzer could support website project as well.

As far as I know, non csproj are not currently supported. It partly depends on how different the project files and MSBuild arguments are as to how easy such support would be. I'm not very familiar with website projects - do those use the new csproj format or the legacy one? Do you know if they're compiled through MSBuild?

ASP.Net website projects don't have any csproj file.
ASP.Net website projects can be compiled using MSBuild having the .sln file path as an argument instead of csproj file path.

I'm going to go ahead and close this as out of scope (at least for the time being). I don't have the bandwidth to support some of the more exotic MSBuild project types if they're not already supported, though I'm happy to add support if someone from the community wants to add it (like we recently had done for .fsproj projects).


hi,Image Recognition service is not available

Steps to Reproduce
hi,please help me.

Image Recognition service is not available in open structure ,I don't know how to configure.

Expected behavior
I think it can be used
Screenshots

Ketcher version
2.6.4
indigo version 1.8.3
Additional context
Because the  Image Recognition service  cannot be used in the standalone version, I converted the remote version, but it still cannot be used

Hi @wojiaoxiaomayun
Yes, the service is currently disabled, but we are planning to enable it again in the remote version in the near future.

Oh,Thanks for you,That's very good. Do you have any plans to start in recent months or this year?