make getrandom behind the wasm feature flag

Greetings, I am attempting to utilize genaric-ec (using cggmp21) by compiling it with the no_std feature and running it in wasm (albeit not in the browser). I initially believed that the compilation would be flawless, however, due to the requirement for getrandom (even without the wasm feature), the compilation fails and complains about the absence of the get random implementation.
Before this change, running cargo b -p generic-ec --no-default-features --target wasm32-unknown-unknown result in the following error:
Compiling getrandom v0.2.12
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
   --> /home/codespace/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.12/src/lib.rs:291:9
    |
291 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
292 | |                         default, you may need to enable the \"js\" feature. \
293 | |                         For more information see: \
294 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
   --> /home/codespace/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.12/src/lib.rs:347:9
    |
347 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`

For more information about this error, try `rustc --explain E0433`.

With this change, running cargo b -p generic-ec --no-default-features --target wasm32-unknown-unknown compiles without issues.

You need to enable wasm feature by using cargo build -p generic-ec --target wasm32-unknown-unknown --features wasm,all-curves command to make it work. We continuously test that it works in GH actions. Or are you saying that enabling wasm feature doesn't work?

You need to enable wasm feature by using cargo build -p generic-ec --target wasm32-unknown-unknown --features wasm,all-curves command to make it work. We continuously test that it works in GH actions. Or are you saying that enabling wasm feature doesn't work?

It works, the only issue is that requires getrandom/js and we are working in a non-browser evn, so no js. Hence, removing the need for getrandom all together, since the rng we are using does not depend on getrandom backend.

Ah I see. In this case, I think that probably wasm feature shouldn't be there at all, the client code should either enable getrandom/js feature or disable getrandom. Could you remove this feature entirely? It'd probably require some other changes to fix CI.

Also, could you set up commit signing on your side? Repo settings will not allow merging any unsigned/unverified code.

Hey @survived is it okay to add Nix & flake devenv files to this repo? It makes development consistent across different machines and easier to set up.

I'll let @maurges decide, he's fan of nix, so he'll probably be reviewing that part :)

The nix shell would only contain cargo+rustc (and libc) though? Or do you want to setup a flake for compiling to wasm as well?

Also Related: https://github.com/dfns/stark-curve/issues/4

The nix shell would only contain cargo+rustc (and libc) though? Or do you want to setup a flake for compiling to wasm as well?

Just the dev shell, no packaging or build using nix are required, so the same tooling and workflow would stay the same, only the initial setup of the repo. Also, I'm using direnv so once you cd dfns/generic-ec it automatically enters the dev shell.

I've pushed most of the updates, I do have one more test to add in the CI to ensure that WASM + no_std works.

@shekohex actually, we've decided that we don't want to have nix file in the repo. I assume, in your workflow you could put nix file to parent dir and it would work fine with direnv?

@shekohex actually, we've decided that we don't want to have nix file in the repo. I assume, in your workflow you could put nix file to parent dir and it would work fine with direnv?

Yeah, that works, no worries. I just did not push any nix related nor direnv files to the repo, so we are good.

stark-curve v0.1.1 is published

Could you please now run the CI?

I don't see a button to run a CI.  Maybe it'll reappear

@shekohex nostd example doesn't build on CI it seems. Do you have access to build logs?

@shekohex nostd example doesn't build on CI it seems. Do you have access to build logs?

It builds! https://github.com/dfns/generic-ec/actions/runs/7855819173/job/21475955726?pr=17
The only issues are clippy and docs are failing since they try to build it in with std enabled. not sure how we can exclude it from clippy, tests and docs?

You should be able to exclude them by adding --exclude cli flag, e.g. we do that here:
https://github.com/dfns/generic-ec/blob/3de295debbe61e2d0f3f4a999372da62968c00e2/.github/workflows/rust.yml#L61-L62

You should be able to exclude them by adding --exclude cli flag, e.g. we do that here:
https://github.com/dfns/generic-ec/blob/3de295debbe61e2d0f3f4a999372da62968c00e2/.github/workflows/rust.yml#L61-L62

Thanks for the tip, I've updated the rust.yml file, and now it should work, could you approve the CI run?

You can try the commands locally as well!

Seems like it requires a workspace flag now

Done!

Let me just check with our security team what's our procedure, they could also want to review PR


[Component] Divider

Meet on monday for reviewing it @JeremiasUX @elisa-hery. See ya!

We reviewed it together, all clear ✅
Next step : talk abut it with other web devs & merge it.


ServerRequest's parsedBody is empty

PHP version: 7.4.16
Description
From the PSR-7:

If the request Content-Type is either application/x-www-form-urlencoded
or multipart/form-data, and the request method is POST, this method MUST
return the contents of $_POST.

Does it apply to the ServerRequest?
How to reproduce
<?php

require 'vendor/autoload.php';

$body = <<<EOF
POST /test HTTP/1.1
Host: localhost
Content-Type: application/x-www-form-urlencoded

id=1&name=test
EOF;

// adapted from GuzzleHttp\Psr7\Message::parseRequest
$data = \GuzzleHttp\Psr7\Message::parseMessage($body);
$matches = [];

if (!preg_match('/^[\S]+\s+([a-zA-Z]+:\/\/|\/).*/', $data['start-line'], $matches)) {
    throw new \InvalidArgumentException('Invalid request string');
}

$parts = explode(' ', $data['start-line'], 3);
$version = isset($parts[2]) ? explode('/', $parts[2])[1] : '1.1';

$request = new \GuzzleHttp\Psr7\ServerRequest(
    $parts[0],
    $matches[1] === '/' ? \GuzzleHttp\Psr7\Message::parseRequestUri($parts[1], $data['headers']) : $parts[1],
    $data['headers'],
    $data['body'],
    $version
);

var_dump($request->getBody()->getContents()); # string(14) "id=1&name=test"
var_dump($request->getParsedBody()); # null

Probably because $data['headers'] is empty?

Likely no:
$data = array(3) {
  'start-line' =>
  string(19) "POST /test HTTP/1.1"
  'headers' =>
  array(2) {
    'Host' =>
    array(1) {
      [0] =>
      string(9) "localhost"
    }
    'Content-Type' =>
    array(1) {
      [0] =>
      string(33) "application/x-www-form-urlencoded"
    }
  }
  'body' =>
  string(14) "id=1&name=test"
}

In any case, it doesn't seem to be any code in the ServerRequest class that would parse the body.

I don't think there's an issue with the ServerRequest, probably it's your code. Debug your code to find the actual problem, and do take your time in resolving the issue.

@divineniiquaye please refer to the How to reproduce. There is only Guzzle code there.

I think this is a feature request, and not a bug? We currently use $_POST to determine the parsed body in the fromGlobals, and do not implement it parseMessage.

It depends on how you want to interpret the PSR-7:
https://github.com/php-fig/http-message/blob/efd67d1dc14a7ef4fc4e518e7dee91c271d524e4/src/ServerRequestInterface.php#L152-L167

Thank you for this issue.
The ServerRequest is a value object and I see that you are not constructing it correctly. See ServerRequest::fromGlobals() as an example.
You need to do withParsedBody().
There is no easy way to fix this and adding method parsing is indeed complex by itself.
I suggest closing this issue.


Put an example of usage with modules syntax

Based on an example of the itty router library I was doing:
const router = OpenAPIRouter();
// ...
const worker: ExportedHandler<Bindings> = { fetch: router.handle };
export default worker;

By doing this, even if the parameters were correct in a request, I was getting always an empty data argument.
I had to check the code of the library and realized that if you do that then the data argument for the handle methods is not the second argument, but the fourth, because the library passes as many arguments as the router.handle function receives, plus the data. It turns out that the fetch function receives not just the Request argument, but two additional ones: an Env and an ExecutionContext.
This works fine:
const router = OpenAPIRouter();
// ...

const worker: ExportedHandler<Bindings> = {
  fetch: (request /*, env, ctx */) => router.handle(request),
};

export default worker;

Thanks!

Hey @gimenete
I've just merged a commit with a new section that cover this use case
Thanks for lettings us know 😃


Flight category "WVFR"?

Not finding any documentation on what flight category "WVFR" means.
context

There's a little bit of detail about it here, although I don't call it out explicitly: https://led-sectional.kyleharmon.com/#software
It's basically something I made up called "windy VFR", which is VFR conditions with winds above the threshold defined in #define WIND_THRESHOLD. I created just to make things a bit more interesting in the summer because my own map is for California, which would be super boring 6 months out of the year.

Gotcha, thanks for clarifying. I saw the code about the wind conditions but didn't make the connection.
Side note, your code worked great on my project and your tutorial was awesome. Thanks so much.


Errors related to UI changes

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
I'm going to make some small changes of the cvat-ui/src module.
Then I want to confirm the my ui changes is running or not.
I have been trying to follow the following guidelines of cvat/ui module.
https://github.com/cvat-ai/cvat/blob/develop/cvat-ui/README.md
But I'm facing the api server health check error when browsing the cvat ui port 3030.
I'm listed some details information with capture.
I would like to know about that what I need to do anything
to start the ui module normally.

Expected Behavior
No response
Possible Solution
No response
Context
No response
Environment
No response

try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer

This download was blocked by Chrome because your file is a dangerous file...

Hello
Please follow this guide https://docs.cvat.ai/docs/contributing/development-environment/. You do not need to run CVAT with docker compose, except for some services like DB and REDIS, but all steps are detailed in the guide above.

@azhavoro
Based on your advice,
I tried again but got the error shown in the attached image.

@azhavoro
I have been trying to follow the guidelines of cvat development environment
that you adviced.
https://docs.cvat.ai/docs/contributing/development-environment/
Every Step is running smoothly but I'm facing the same error with previous
after running the last command (yarn run start:cvat-ui).
Please advice me anything if you have some doubt.
I already confirmed (at attached image) about that
cvat server, redis, open policy agent aslo running.
I don't know what I need to start or run some server or service.


Due to stability issues, changed back to use AgentNoRedefNoRetrans.jar.

Due to stability issues, changed back to use AgentNoRedefNoRetrans.jar.

@jy2697 I merged this PR but I had to revert it because of spec errors this change caused.   If you choose to resubmit these changes, please add evidence that you ran the spec tests in your PR.
 [exec] Failures:
 [exec]
 [exec]   1) CA APM Agent  release should return java command line options for the introscope service
 [exec]      Failure/Error: expect(java_opts).to include("-javaagent:./#{ca_apm_home}/wily/Agent.jar")
 [exec]        expected ["-javaagent:./.ca_apm/wily/AgentNoRedefNoRetrans.jar", "-Dorg.osgi.framework.bootdelegation=com.wily...engard.postofficehub.link.net.DefaultSocketFactory", "-Dcom.wily.introscope.agent.startup.mode=neo"] to include "-javaagent:./.ca_apm/wily/Agent.jar"
 [exec]      # ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:159:in `block (3 levels) in <module:Framework>'
 [exec]
 [exec]   2) CA APM Agent  release should return java command line options for the introscope service and have the agent manager credential if present
 [exec]      Failure/Error: expect(java_opts).to include("-javaagent:./#{ca_apm_home}/wily/Agent.jar")
 [exec]        expected ["-javaagent:./.ca_apm/wily/AgentNoRedefNoRetrans.jar", "-Dorg.osgi.framework.bootdelegation=com.wily...Factory", "-DagentManager.credential=test1234abcdf", "-Dcom.wily.introscope.agent.startup.mode=neo"] to include "-javaagent:./.ca_apm/wily/Agent.jar"
 [exec]      # ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:178:in `block (3 levels) in <module:Framework>'
 [exec]
 [exec] Finished in 4 minutes 20.9 seconds (files took 0.53474 seconds to load)
 [exec] 798 examples, 2 failures
 [exec]
 [exec] Failed examples:
 [exec]
 [exec] rspec ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:151 # CA APM Agent  release should return java command line options for the introscope service
 [exec] rspec ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:170 # CA APM Agent  release should return java command line options for the introscope service and have the agent manager credential if present


backport: fix for host headers

Fixes https://github.com/coreos/bugs/issues/1569.

Verified with the Docker 1.8.3 client.

this is pretty insane, but OK.


LDAP: SERVER_SERVLET_CONTEXT_PATH redirect is not working correctly

Issue submitter TODO list

[X] I've looked up my issue in FAQ
[X] I've searched for an already existing issues here
[X] I've tried running master-labeled docker image and the issue still persists there
[X] I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)
After succesfull athentication redirect to SERVER_SERVLET_CONTEXT_PATH not happens.
Url remains http://url/something/login where SERVER_SERVLET_CONTEXT_PATH is "something"
There is message in debug log
2023-05-17 08:44:04,668 DEBUG [boundedElastic-2] o.s.s.l.a.LdapAuthenticationProvider: Authenticated user
2023-05-17 08:44:04,668 DEBUG [boundedElastic-2] o.s.s.w.s.c.WebSessionServerSecurityContextRepository: Saved SecurityContext 'SecurityContextImpl ........
2023-05-17 08:44:04,668 DEBUG [parallel-1] o.s.s.w.s.DefaultServerRedirectStrategy: Redirecting to ''
2023-05-17 08:44:04,669 DEBUG [parallel-1] o.s.w.s.a.HttpWebHandlerAdapter: [016bb932-129] Completed 302 FOUND

Expected behavior
Correct redirect to SERVER_SERVLET_CONTEXT_PATH path.
Your installation details
Version is 0.7.0 (https://github.com/provectus/kafka-ui/commit/fdd9ad94c11d44259ef26bf4b2dc9a8bd139f607)
Application is running in k8s with my custom manifests.
Steps to reproduce
Run application with these environment variables config:
            - name: SERVER_SERVLET_CONTEXT_PATH
              value: "/something"
            - name: AUTH_TYPE
              value: "LDAP"
            - name: SPRING_LDAP_URLS
              value: "ldap://url:389"
            - name: SPRING_LDAP_USERFILTER_SEARCHBASE
              value: "ou=people,dc=company,dc=com"
            - name: SPRING_LDAP_USERFILTER_SEARCHFILTER
              value: "(&(uid={0})(objectClass=inetOrgPerson))"
            - name: SPRING_LDAP_ADMINUSER
              value: "uid=admin,ou=people,dc=company,dc=com"
            - name: SPRING_LDAP_ADMINPASSWORD
              value: "${ADMIN_LDAP_PASSWORD}"

Screenshots
No response
Logs
No response
Additional context
This config works well in version 0.6.2 but not with 0.7.0.

I am afraid that I could not reproduce this without k8s cluster.
Yes, I could be the environment configuration issue but version 0.6.2 works well.
It seems to me thah application should always respect value of variable SERVER_SERVLET_CONTEXT_PATH so there is should not be such string in log when variable is defined.
2023-05-17 08:44:04,668 DEBUG [parallel-1] o.s.s.w.s.DefaultServerRedirectStrategy: Redirecting to ''

Sometimes redirect is working but I could not find a consistent pattern.

This log message has nothing to do with LDAP. There are two places this code is called from: OidcClientInitiatedServerLogoutSuccessHandler and OAuth2AuthorizationRequestRedirectWebFilter.

Yep, my bad. This could be not connected with auth type at all.

So, issue won't go away after closing it here.
May be there is any guess why is this happening?

@Haarolean can we reopen this issue or move it do discussion?
Maybe someone will find an idea why it could happen. I still find no clue.

@pawellrus - I also am stuck at the exact problem in my k8s setup with LDAP and a custom SERVER_SERVLET_CONTEXT_PATH environment variable. Looks like LDAP authentication succeeds but the redirect renders a blank page. And I also see the same log in kafka-ui POD:
2023-06-21 18:16:43,181 DEBUG [boundedElastic-1] o.s.s.l.a.LdapAuthenticationProvider: Authenticated user
2023-06-21 18:16:43,182 DEBUG [boundedElastic-1] o.s.s.w.s.c.WebSessionServerSecurityContextRepository: Saved SecurityContext 'SecurityContextImpl [Authentication=UsernamePasswordAuthenticationToken [Principal=LdapUserDetailsImpl [Dn=uid=ldapadmin,ou=people,dc=example,dc=com; Username=ldapadmin; Password=[PROTECTED]; Enabled=true; AccountNonExpired=true; CredentialsNonExpired=true; AccountNonLocked=true; Granted Authorities=[]], Credentials=[PROTECTED], Authenticated=true, Details=null, Granted Authorities=[]]]' in WebSession: 'org.springframework.web.server.session.InMemoryWebSessionStore$InMemoryWebSession@39d5b2f3'
2023-06-21 18:16:43,183 DEBUG [parallel-1] o.s.s.w.s.DefaultServerRedirectStrategy: Redirecting to ''

Update - I was able to get pass this issue and could confirm LDAP with custom SERVER_SERVLET_CONTEXT_PATH is working as expected in kubernetes! Here's the configuration that worked for me:
       - name: AUTH_TYPE           value: LDAP         - name: SPRING_LDAP_URLS           value: ldap://openldap:389         - name: SPRING_LDAP_BASE           value: uid={0},ou=people,dc=myorganization,dc=com         - name: SPRING_LDAP_ADMIN_USER           value: cn=admin,dc=myorganization,dc=com         - name: SPRING_LDAP_ADMIN_PASSWORD           value: Chubb.IORocks         - name: SPRING_LDAP_USER-FILTER-SEARCH-BASE           value: ou=people,dc=myorganization,dc=com         - name: SPRING_LDAP_USER-FILTER-SEARCH-FILTER           value: (&(uid={0})(objectClass=inetOrgPerson))


Ollama hangs sometimes if it runs out of VRAM

Hi! I just have been having an issue with models that cause the system to run out of VRAM. It usually does the following:

(attempt to run a model via api, for example Llama2 70b)
ollama-runner tries to load the model into VRAM
ollama-runner runs out of VRAM and the process kills
the API hangs indefinitely until it is killed (via systemctl restart or killing the docker container if applicable)

I don't know why it has to be restarted to process the next request, would it be possible to have a feature where it detects if it runs out of VRAM or crashes and then returns an error via the API and/or auto restarts? This is something I've been running into recently as I only have 24g of VRAM
Much appreciated!

I've found this as well, when making my project https://github.com/iplayfast/OllamaPlayground/tree/main/createnotes#readme
This project really works the ollama system by checking that each model can be loaded, and then asking questions to it.
It gives a timeout when loading the falcon:180b and then after that some models will load and others won't. meditorn ends up heating up my cpu but not much else.

Found my problem (hopefully), I had downloaded falcon:180b as a stress test and forgot about it. 101GB won't load....
After attempting to load it, and timing out, it went on to load some other models, but then died on meditron which is the pattern I've seen before.  The funny thing is that meditron isnt' an especially big model.
attempting to load model falcon:180b
Timed out after 300 seconds for question: are you there
model falcon:180b ------------not loaded------------ in 364.1 seconds
attempting to load model llama2:latest
model llama2:latest loaded in 27.6 seconds
attempting to load model llama2-uncensored:latest
model llama2-uncensored:latest loaded in 23.6 seconds
attempting to load model llava:latest
model llava:latest loaded in 30.6 seconds
attempting to load model magicoder:latest
model magicoder:latest loaded in 28.4 seconds
attempting to load model meditron:latest
Timed out after 300 seconds for question: are you there

I think this is just a case of need better error handling when loading a model.

Could be some kind of a timeout. I have two RTX A6000's in my machine and only one is allocated to Ollama, the other is usually training or finetuning something. When that training is ongoing, the Ollama GPU is slower, so it can also hang on something as small as Mixtral.


How to connect service.js to Redux

import TrackPlayer from 'react-native-track-player'

module.exports = async function () {

  TrackPlayer.addEventListener('remote-play', () => {
    TrackPlayer.play()
  })

  TrackPlayer.addEventListener('remote-pause', () => {
    TrackPlayer.pause()
  });

  TrackPlayer.addEventListener('remote-next', () => {
    TrackPlayer.skipToNext()
  });

  TrackPlayer.addEventListener('remote-previous', () => {
    TrackPlayer.skipToPrevious()
  });

  TrackPlayer.addEventListener('remote-stop', () => {
    TrackPlayer.destroy()
  });

};

Hello, how can i use Redux on this page? I need access notification panel click status. I have play/pause button and controls with redux. i need access notification panel clicks too.

I don't think you can or even if you can, it doesn't make sense. Your app might be in background and the UI is not mounted.
The service should interact with the player directly.
I would be interested the best approach with this, if anyone else has an idea.

I imported my redux store directly on the player service and it worked fine
import TrackPlayer from 'react-native-track-player';

import { store } from '~/store';
import { Creators as PlayerActions } from '~/store/ducks/player';

export default async () => {
  TrackPlayer.addEventListener('remote-play', () => {
    store.dispatch(PlayerActions.play());
  });

  TrackPlayer.addEventListener('remote-pause', () => {
    store.dispatch(PlayerActions.pause());
  });

  TrackPlayer.addEventListener('remote-next', () => {
    store.dispatch(PlayerActions.next());
  });

  TrackPlayer.addEventListener('remote-previous', () => {
    store.dispatch(PlayerActions.prev());
  });

  TrackPlayer.addEventListener('remote-stop', () => {
    store.dispatch(PlayerActions.reset());
  });
};

@b3rkaydem1r close this issue


Make feedback warning more obvious

Minor nit: should we say "To contact your surgery please..." for consistency?

Yes, fixed.


Feat: Add file into Archive

Describe the feature
We can add a button to the file list and include the file in the Archive list.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@ronisarkarexe go ahead ... Also users should be able to see the files in the Archived tab (make a separate pagefor archived)
Also an Unarchive button
On Archive -> File gets removed from main dashboard and saves up in the Archived
On Unarchive -> File comes back to main dashboard
If u face any problem do join the Whatsapp group for asking doubts

@subhadeeproy3902 I am willing to work on this issue!

@subhadeeproy3902 I am getting such kind of error. How can I fix it!


Using schema other than public in PostgreSQL

Thanks so much for your work on this,@myungchoi!!
I was wondering if it's possible to use a schema other than the public schema when using PostgreSQL. The DDL for Postgres seems to put all tables in the default (i.e., public) schema.
For example, if I have my data in a schema called cdm and my vocabularies in a vocab schema, would that work? I don't see any configuration fields or environment variables that would all us to modify the schemas to be use. Do there need to be changes to the Java code to accommodate this?
Again, thank you so much for your work on this, Myung!

You can change the schema name. Currently, both cdm and vocab need to be in the same schema. I have another OMOPonFHIR implementation that I am using as a registry. That has the capability that you want (using cdm from one schema and vocabulary from another schema). I haven't had a chance to apply the changes to this code stack. I will see if I can do. Until then, your vocab needs to be in the same schema. And, the schema name can be specified in the JDBC_URL environment valuable by adding "currentSchema" URL parameter.

Thanks so much for following up, Myung! That all sounds great!
Thanks again for all your work on this, @myungchoi!!!


Analyzer relax upper bound

Please have a look at the individual commit messages for the details.

Doesn't seem to work, Azure still uses PHP 8.0 :-( https://dev.azure.com/oss-review-toolkit/ort/_build/results?buildId=2551&view=logs&j=a3985077-d6e4-50cc-d2e4-6de3ec48d9a5&t=00724c25-30b2-5aa4-698f-0646507c6655&l=1948

While this PR doesn't fully fix the AppVeyor problem, I believe we should still merge it, and maybe again make the Azure Windows build mandatory instead of the AppVeyor one for the time being.

Merging despite the AppVeyor failure, which will be addressed separately.


Icon missing in "Tasks" button

See here:

On the right, there is a small icon in the button, but not on the left.

This has been completely redesigned


Tumbleweed install build failing since Oct 17

Example error: https://g3c.corp.google.com/results/invocations/54ea27e5-1996-4e74-966f-f3f2a2ebeeea/targets/cloud-cpp%2Fgithub%2Fgoogle-cloud-cpp%2Fmaster%2Finstall%2Fopensuse-tumbleweed/log
Step 20/52 : RUN cmake -DBUILD_TESTING=OFF -H. -Bcmake-out
 ---> Running in 13672a8b8f9e
-- The CXX compiler identification is GNU 10.2.1
-- The C compiler identification is GNU 10.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- ccache found: /usr/bin/ccache
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find ProtobufWithTargets (missing: ProtobufWithTargets_FOUND
  ProtobufWithTargets_VERSION)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindProtobufWithTargets.cmake:198 (find_package_handle_standard_args)
  external/googleapis/CMakeLists.txt:106 (find_package)

Tumbleweed is a rolling updated release. It looks like the tumbleweed image was updated 3 days ago. So I think this is likely what caused the problem.
This issue is reproducible locally.

Summary of the problem.
Tumbleweed was recently updated to include gRPC 1.32.0 (grpc.spec file). That package doesn't automatically pull in protobuf-devel, which we need so that we can find_package in our CMake files. If we simply zypper install protobuf-devl in our Dockerfile, our build passes and works. Cool.
However, even though our build passed, we got the following build warnings:
    runtime library [libabsl_status.so] in /usr/lib64 may be hidden by files in:
      /usr/local/lib64
    runtime library [libabsl_str_format_internal.so] in /usr/lib64 may be hidden by files in:
      /usr/local/lib64
    runtime library [libabsl_cord.so] in /usr/lib64 may be hidden by files in:

That looks like an ODR or ABI problem waiting to happen.
The problem here is that the new gRPC 1.32.0 package that opensuse/tumbleweed is using (spec file) is running gRPC's cmake build with -DgRPC_ABSL_PROVIDER=module, which I believe will result in gRPC installing some of Abseil's binary artifacts, like libabsl_str_format_internal.so. I believe that's a bug: gRPC should never install binary artifacts for some other library.
/cc @veblush
The workaround
To work around these problems, https://github.com/googleapis/google-cloud-cpp/pull/5278 will avoid the 1.32.0 gRPC package from opensuse/tumbleweed and instead compile/install gRPC 1.29.1 from source using -DgRPC_ABSL_PROVIDER=package.


[WIP] YoloV5 integration

What does this PR do?
YoloV5 integration - #119
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @aniketmaurya! Thanks for opening this PR.

In the file flash/image/backbones.py:

Line 215:52: W292 no newline at end of file

Do see the Hitchhiker's guide to code style

closing this one since #408 contains support for YoloV5 as well


Faxes are colored again

About the PR
I've noticed that faxes lost their colors (blue for centcomm and black for sindye)
Hope I've done everything correctly
Why / Balance
They had their colors but somehow lost them.
Technical details
Changed layer for fax. Changed sprites for inserting and printing (removed fax from them).
It looked like that color also changes color for paper (it looked strange)
Haven't changed FaxVisualsSystem (cause I don't know how and what I should change, so just decreased Length).
I have removed unique animations when fax gets message (probably I will try to restore them soon)
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog

:cl:

fix: Faxes have their colors again

Could you add some before/after in-game screenshots to your PR description?

Could you add some before/after in-game screenshots to your PR description?

Have added some. Found a bug, will fix it soon


[Bug] Copy Magnet LInk

The copy magnet link is not working, nothing happens when you click on it.
Also, you may already be aware but, the category management option is missing from the context menu and the ETA column is also missing.

@zero77
Nothing happens? You don't even see a notification toast?

Also, you may already be aware but, the category management option is missing from the context menu and the ETA column is also missing.

Category and tags are not supported yet. I'll add ETA column asap I just missed it, there might be other missing columns too :)

Nothing happens? You don't even see a notification toast?

After doing some testing on two qbittorrent alpha installs one is headless and the other not.
I get notifications for both but, only the non headless install will copy the link the other just displays the notification without copying the link.

Category and tags are not supported yet. I'll add ETA column asap I just missed it, there might be other missing columns too :)

Thanks, i didn't know if it was in your to do list or just missed.

I get notifications for both but, only the non headless install will copy the link the other just displays the notification without copying the link

Interesting, let's debug a bit. Please follow these steps and report back the results:

Open Chrome devtools
Refresh the page
In network tab of devtools look for an http request to sync/maindata?rid=0
In the preview panel you should see torrents like a key value object (hashmap)
Open one of its keys (keys are hash) and see if you find magnet_uri field in that object

UI doesn't do anything special for copying magnet URI, I'm suspecting the magnet URI is missing, but the issue might be in the Web API too.

i didn't know if it was in your to do list or just missed.

I'll make an issue and list the roadmap to be more transparent.

I am using Firefox so it is a bit different but, after looking in response under network i can see all the magnet links under the torrents dropdown.

would you share the response of /api/v2/sync/maindata you get with the instance that Magnet URIs broken?

If you mean repeat, the above steps but when visiting the api directly then its the same i can see the magnet links.

@zero77
Can you share the response of that call when you connecting to the headless instance?
Also another thing, try to copy something into clipboard before executing copy magnet links. Then see what's the content of clipboard after execution of command is it the same or empty.
Thanks.

Sorry for the delay, is this what you were referring to.
The magnet link and tracker fields seem to be shrunk automatically but, they are full length.

Ya it seems the response is fine and the bug lies in Web UI. Would you try the scenario that I mentioned earlier and report the result?

try to copy something into clipboard before executing copy magnet links. Then see what's the content of clipboard after execution of command is it the same or empty.

After copying some text from a different application than copying a magnet link the original text was in the clipboard.

After copying some text from a different application than copying a magnet link the original text was in the clipboard.

That worries me. If your clipboard has a value and then you try copying the Magnet URI in web ui and after that you still have the same value in the clipboard that means the browser could not copy the value to the clipboard and it failed.
I will see if I can implement a failure mechanism so if it couldn't complete the operation at least it will display a notification


DefinitelyTyped Package Source

The NuGet search system leaves much to be desired, and it can be fairly hard to find the appropriate definitely typed package for a given JavaScript library.
One solution to this would be having a Package Source hosted by the DefinitelyTyped project which users can add to the Package Source list in visual studio.
Then, when searching for typescript definitions the DefinitelyTyped Package Source can be selected and only the relevant packages will be shown.

A downside to this approach is increased maintenance work, and possibly hosting costs.

@staxmanade


Add 3DGS-CD

Hey, thanks for your contribution. Can you please remove the Twitter handle before I merge. Information should be accessed by everyone. Not everyone has an X account. Thank you!

Done! Thank you!


[VM][Kernel] Differences in benchmarks of dart-dfe vs dart due to different new heap sizing

It actually occurs in multiple benchmarks, for example, in  StringBuffer and RegExp. The apparent difference in performance is due to dart-dfe having new space size of 8Mb vs dart having 32Mb.
It may very well be that 8Mb is more sensible size than 32Mb but in any case some investigation is required to understand what causes different heap growth pattern.

Actually there are also examples to the contrary on StreamSingleSubTest  dart has new space of 2Mb and dart-dfe grows up to 8Mb. Manually adjusting the heap sizes nullifies the difference.


📚 Missing docs files

Description
The project is missing the docs folder, which should contain .rst (reStructuredText) files for documentation. This folder is crucial for generating proper documentation using tools like Sphinx or other documentation generators.
Expected Behavior
The project should have a docs/ directory with the following:

index.rst – The main entry point for the documentation.
Other relevant .rst files (e.g., installation.rst, usage.rst, contributing.rst, etc.) to cover different aspects of the project.
A conf.py file to configure the Sphinx documentation generator, if applicable.

Current Behavior
Currently, there is no docs/ directory in the project repository, making it difficult to generate or view the documentation.
Steps to Reproduce

Clone the project repository.
Navigate through the file structure to check for the presence of a docs/ folder.
Verify the missing .rst files and the configuration for documentation.

Proposed Solution

Add a docs/ folder with at least the basic .rst files:

index.rst
installation.rst
usage.rst
Any other files necessary for comprehensive project documentation.

If using Sphinx, include a conf.py file to manage the documentation settings.

Update the documentation and ensure the README file points to the generated docs.

Impact
The absence of proper documentation makes it difficult for new users to understand the project setup, installation, and usage instructions. This may affect the project's adoption and contribution rate.

Do I really need it for something this litlte ?

Yes, we need documentation in .rst format to support the addition of new features to the package.

Yes, we need documentation in .rst format to support the addition of new features to the package.

why is it better ?

Waiting for explanation

@enzofrnt
It's optional, but for future enhancements and additional settings in the package, it's a good idea to set up ReadTheDocs from the start. This will streamline documentation as the project grows.

Will not be add.


Vehicle recall and faults style fixes

Corrections to terminology and style from the Driver and Vehicle Standards Agency (DVSA). Until recently, I worked at DVSA, and I was involved in setting up this finder during firebreak in April 2015. Renamed the incorrect terms 'baby seats' and 'car seats' to 'child car seats'. Style guide corrections to filter options.

Closing this because https://github.com/alphagov/specialist-publisher/pull/647 was merged.


Check for uniqueness relies on field name "guid"

If I read this right, this check for uniqueness https://github.com/justb3a/processwire-guidgenerator/blob/master/GuidGenerator.module#L105 relies on the assumption, that the field name is always "guid".
Is this the intended behavior or am I wrong here?
Thanks!

Thanks, you're right. It's fixed :)


Merge different PR

:tada: This PR is included in version 3.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow to open the same folder in multiple windows

second window will not open same working folder as first window

VSCode Version: 1.1.1 / also 1.2.0-insider
OS Version: 8.1

Steps to Reproduce:

Open first window and standard working folder.
File -> new window
Second window opens with blank workspace; attempt to select same working folder as first window. Folder does not open in second window.

This is currently by design and was reported already.

I can work-around this by doing subst r: c:\profilefolder\ to open the second window w/ same folder/profile as first, but I don't really understand why this is by design--is there a feature I'm missing?
How can I split the editor and have those windows not be side by side by rather actually take advantage of my screen resolution?  Also, since the profiles themselves are tied to the folder.  So, if you want different settings than default, you essentially have to set up a new profile for each directory the way this is designed now?

We are looking for the same thing.  I'll try your workaround.

In march, @weinand mentioned opening the same folder in multiple windows as a possible solution to https://github.com/Microsoft/vscode/issues/4507 (multiple debuggers in same project). I'm also surprised to hear that not being able to do this is "by design".

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


Remove crypto from client side

Unless, if we tries to access the client side page from http protocol, crypto.randomUUID() isn't available.

I got your idea. but it's not safe to use hardcoded messageId. mesaageId should never be duplicated, in any cases. do we have another random way to generate uuid-like messageId?

Update. it's not limited to be a uuid. any string that not duplicated is acceptable

crypto.randomUUID() is now standard on all modern browsers and JS runtimes. However, because new browser APIs are restricted to secure contexts, this method is only available to pages served locally (localhost or <IP_ADDRESS>) or over HTTPS.
For readers interested in other UUID versions, generating UUIDs on legacy platforms or in non-secure contexts, there is the uuid module. It is well-tested and supported

from Google. that would be a better choice

https://www.npmjs.com/package/uuid
seems to be a replace choice. to strictly avoid duplicated id, we can add timestamp to the uuid string.

https://www.npmjs.com/package/uuid
seems to be a replace choice. to strictly avoid duplicated id, we can add timestamp to the uuid string.

LGTM! I'll do that in a minute. Thanks for your elaboration!

@wtlyu I gone with
crypto.getRandomValues(new Uint8Array(1))[0] + Date.now()

Will it be sufficient?

looks good. do you test it？

Yes it works fine in my env!


Global 'post' and 'product' not kept in sync

Problem
I am using the 'products' shortcode provided by WooCommerce. This executes class-wc-shortcode-products.php's product_loop(). This code sets the $GLOBALS['post'] but not $GLOBALS['product']. Because of this, and other code, the loop of products prints the same product over and over again (to be more specific, name of product is correct but image and price is from the first product).
It seems the code at the bottom of https://timber.github.io/docs/guides/woocommerce/ attempts to resolve but did not work for me.
Solution
Looking into I found this library's WooComerce.php maybe_render_twig_template_part() contains
global $post, $product;

if ( ! $product ) {
	$product = wc_setup_product_data( $post );
}

The above sets the global $product when $product not yet set. This then leads to the global 'product' to always be the first one in a loop. To resolve the condition in the 'if' needs to be changed to:
global $post, $product;

if ( ! $product || $product->get_id() != $post->ID ) {
	$product = wc_setup_product_data( $post );
}

Your library is fantastic! I love using Twig so its a must when doing WooCommerce. Your library makes it so much easier. If you can please resolve the above that would be AWESOME!
Thanks,
David

Hey @dmschlot, thanks for that detailed issue report. And thanks for the kind words! I’m glad you like it. I couldn’t work without it, either 😅.
I was just wondering, did you already check out the newest release candidate for this integration? Because it might be that is already resolved with that. You should be able to get it with
composer require mindkomm/timber-integration-woocommerce:0.6.0-rc.1

Otherwise, I might have to check again.

Hey @dmschlot
Sorry for the delay and thanks for checking it out and digging into the code to find a solution. Your suggestion was a big hint for what was not working.
However, I realized there are various other problems about the $product global. Adding your suggestion would be a band-aid for a couple of these problems, but wouldn’t solve the underyling issue. I think I found a fix for a better $product global handling in https://github.com/mindkomm/timber-integration-woocommerce/commit/e1cc8b2a74dcb5049a787a1ec39ed0dffd7e81d4.
I added the solution as a pre-release in 0.6.1-rc.1, because I want to test it out a bit more myself. I’d be glad if you could check it out.
composer require mindkomm/timber-integration-woocommerce:0.6.1-rc.1

Hi  @gchtr chiming in on this issue as well :-)
I'm facing the same issue as @dmschlot (to me it happens also on normal archive pages, not only with the shortcode)

Closing this. Please use the latest 0.7.1 release.
Please open a new issue if you run into other problems.


[improve][broker] Support cleanup replication cluster and allowed cluster when cluster metadata teardown

Motivation
When executing the delete-cluster-metadata command, it should remove the current cluster from the replication cluster and allowed cluster, otherwise the cluster will still replicate the data to a deleted cluster.
Modifications
Support cleanup replication cluster and allowed cluster when cluster metadata teardown
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (bbc6224) to head (9519f69).
Report is 716 commits behind head on master.

Files with missing lines
Patch %
Lines

...g/apache/pulsar/PulsarClusterMetadataTeardown.java
92.00%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23561      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.75%
- Complexity    32624    34427    +1803
============================================
  Files          1877     1943      +66
  Lines        139502   147083    +7581
  Branches      15299    16214     +915
============================================
+ Hits         102638   109331    +6693
- Misses        28908    29315     +407
- Partials       7956     8437     +481

Flag
Coverage Δ

inttests
27.57% <92.00%> (+2.99%)
:arrow_up:

systests
24.36% <0.00%> (+0.04%)
:arrow_up:

unittests
73.72% <84.00%> (+0.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...g/apache/pulsar/PulsarClusterMetadataTeardown.java
77.51% <92.00%> (+1.76%)
:arrow_up:

... and 660 files with indirect coverage changes


Deferred Reactions

Issue description
Some interactions take longer than the 3s required (occasionally - no rhyme or reason to it)
We should go through all commands and any which interact with the database should be deferre
Code sample
No response
Versions
*
Issue priority
Medium (should be fixed soon)

Should be resolved in #58 as we defer as part of our locking strategy


Can't import the named export 'createElement' from non EcmaScript module (only default export is available)

I am getting the same error.

@shenzheniapps @miteshKCS can you create a minimal reproduction for the same

https://github.com/hc-oss/react-multi-select-component/blob/849e00f084e81e99014d49af666d1f8fd28a00de/package.json#L9
@harshzalavadiya  I think in your last PR you have added this module path  by changing it to a .mjs file
which is probably causing issue.
Can you fix asap , it will be a great help , as it is breaking the applications.
Thanks

Following.

@Aabhash97 @cravi47 I moved the project from babel to tsup, so this is intentional change is there any way I can get a reproduction from anyone since I tried with newer CRA and next and it worked as expected so having any reproduction might be nice, it can be a git repo as well or an package json
meanwhile you can keep using @4.1 that should work just as expected

@harshzalavadiya  Even in older versions, it is throwing same error, Don't wonder why.

please try with latest version that should fix issue.
in essense please update your react-scripts to latest that should've resolved this anyway

@harshzalavadiya  Thanks Buddy👏🏻 You are a hero !!. Appreciate for fixing the problem so quick .


Ubuntu 18.04 build issue with libgtk-3-dev & libssl-dev on D435 libRS 2.14.0

Hi,
I'm seeing the following problems when building librealsense-2.14.0 on a fresh Ubuntu 18 machine:
~/Src/RealSense$ uname -r
4.15.0-29-generic
Errors:
**~/Src/RealSense$ sudo apt install libgtk-3-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
libgtk-3-dev : Depends: libgdk-pixbuf2.0-dev (>= 2.30.0) but it is not going to be installed
Depends: libpango1.0-dev (>= 1.40.5) but it is not going to be installed
Depends: libcairo2-dev (>= 1.14.0) but it is not going to be installed
Depends: libfontconfig1-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.**
And:
~/Src/RealSense$ sudo apt install libssl-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
libssl-dev : Depends: libssl1.1 (= 1.1.0g-2ubuntu4) but 1.1.0g-2ubuntu4.1 is to be installed
Recommends: libssl-doc but it is not going to be installed
Any advice greatly appreciated!! Thanks!

Hello @evercoast-smm ,
It seem that the distribution has some missing/broken packages.
You can run dpkg -l | grep ^..r  to list those, and then use Ubuntu tools to rectify it
sudo apt update --fix-missing and
sudo apt install -f <package_name>

Thank you very much! This resolved the issue!

hi,
i have the same problems.
Can someone help me?
in Nginx machine with ubuntu 18.04 installed
root@vps445139:~# uname -r
4.15.0-46-generic
`
root@vps445139:~# sudo apt install libgtk-3-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
libgtk-3-dev : Depends: libglib2.0-dev (>= 2.49.4) but it is not going to be installed
Depends: libgdk-pixbuf2.0-dev (>= 2.30.0) but it is not going to be installed
Depends: libpango1.0-dev (>= 1.40.5) but it is not going to be installed
Depends: libatk1.0-dev (>= 2.15.1) but it is not going to be installed
Depends: libatk-bridge2.0-dev but it is not going to be installed
Depends: libcairo2-dev (>= 1.14.0) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
`
And:
`root@vps445139:~# sudo apt install libssl-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
libssl-dev : Depends: libssl1.1 (= 1.1.0g-2ubuntu4.3) but 1.1.1a-2+ubuntu16.04.1+deb.sury.org+1 is to be installed
Recommends: libssl-doc but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
`
Thank you so mutch

Hello I just found a way to solve the problem!
fisrt I tryed with:
sudo apt update
sudo apt update --fix-missing

that solved some dependencies, but not all, so I installed aptitude (sudo apt-get install aptitude) and then used it to install the realsense library.
sudo aptitude install <your library>
it suggested one solution, but it didn't work, so I pressed no (n) and suggested another solution, that required to downgrade some packages. And the installation finished successfully. Downgrade packages under your own risk!

Thank you, we're good on this issue. Can close.
Evercoast http://www.evercoast.com  |  Sebastian Marino  |  Co-founder &
CTO
On Fri, Sep 4, 2020 at 6:34 AM juandarango<EMAIL_ADDRESS>wrote:

Hello I just found a way to solve the problem!
fisrt I tryed with:
sudo apt update
sudo apt update --fix-missing
that solved some dependencies, but not all, so I installed aptitude
(sudo apt-get install aptitude) and then used it to install the realsense
library.
sudo aptitude install
it suggested one solution, but it didn't work, so I pressed no (n) and
suggested another solution, that required to downgrade some packages. And
the installation finished successfully. Downgrade packages under your own
risk!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/2134#issuecomment-687066287,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGOGSFVGJ2752J2V5BTG6L3SEC7EPANCNFSM4FLUMKTA
.


Toast is not visible

Toast is not visible when attempted to call the the below function
static func makeToast(message: String) {
        Toast(text: message).show()
 }

as debugged in Toast class it is evident that completion block to hide the toast is executing very fast. please find the below attached screenshot

but i can be able to observe this behaviour only for the first time of app launch

@Coeur could you please check this?

@devxoul may know more.
Since you said:

but i can be able to observe this behaviour only for the first time of app launch

Then try to delay your Toast until after applicationDidFinishLaunching:?

Since there is a Demo app in the project, and that Demo app is not suffering from visibility issues, I'll close this issue.
Feel free to create a reproducible demo in order to re-open the issue.
===>Toast Starts Execution 2024-09-03 11:35:27 +0000 Duration:  2.0
===>Toast Ends Execution 2024-09-03 11:35:29 +0000 Duration:  2.0
===>Toast Starts Execution 2024-09-03 11:35:29 +0000 Duration:  2.0
===>Toast Ends Execution 2024-09-03 11:35:32 +0000 Duration:  2.0
===>Toast Starts Execution 2024-09-03 11:35:32 +0000 Duration:  3.5
===>Toast Ends Execution 2024-09-03 11:35:36 +0000 Duration:  3.5
===>Toast Starts Execution 2024-09-03 11:35:36 +0000 Duration:  5.0
===>Toast Ends Execution 2024-09-03 11:35:42 +0000 Duration:  5.0


Hide irreleveant command line options of lldb-moduleimport-test

@swift-ci test and merge

@swift-ci smoke test

Oh. I didn't realize that that test failure was connected to this change! From the looks of it, module-cache-diagnostics.swift doesn't even run lldb-moduleimport-test — do you understand how they are connected?

Oh I think I misread your comment: They aren't!


PIL-996 Build logic to show/hide UK in country list + UK postcode validation

@javed-iqbal1 you will need to merge latest from main branch.

Can you add a description to the PR please?


Provide better support android for variants

If a dependency is only used by a variant-specific source set (not main, but rather debug, say), then rather than saying "remove this dependency", we should say "change this dependency's configuration from implementation to debugImplementation.

Added a 1.0 milestone. This issue is important enough that I consider it a prereq for 1.0 status.


Make state persist navigation and reload

The app should not clear data (remove cards) upon refresh or navigating to a different page and back.
The state could possibly e saved in local- or sessionStorage or as cookies. We might need to think of serialization to reduce stoarge amounts.
This issue might go hand in hand with #6

We currently reference cards by a numerical ID. I think it's useful here to switch to a string that is more related to the Card's function (maybe: family name + '_' + card name).
Imaging following situation:

User saves a multicall in JSON string format
UI receives card updates (so card indices change in the column)
User tries to display the multicall => error since card indices have changed

What do u think? @lennczar

The problem here is that we store the positions of the cards in the Layout Component. When the user navigates to a different page and back, the Layout component loses its state. This also happens to the global value window.TASKS, which serves as a reference to all Task Components, effectively clearing the entire layout.
What @mohamedalichelbi mentioned might be more relating to #6, saving and loading from save files. For this we should be able to infer the card type from the normalized JSON.

We currently reference cards by a numerical ID. I think it's useful here to switch to a string that is more related to the Card's function (maybe: family name + '_' + card name).
Imaging following situation:

User saves a multicall in JSON string format
UI receives card updates (so card indices change in the column)
User tries to display the multicall => error since card indices have changed

What do u think? @lennczar

@mohamedalichelbi, the numeric IDs you mentioned are simple for internal use of react-beautiful-dnd, our drag and drop library. The don't have any effect on the final export, so unless we have a second export type, there's no need to change it

Current (partial) solution
We currently have a class defined in src/utils/persistent.ts, it stores important near addresses so they will persist page navigation (switching between DAO and APP page), however it will be cleared whenever the user refreshes the page (first problem).
It also does not hold any other important information such as the multicall layout (second problem).
The class does supply a function that will update certain components if the global near addresses are mutated, however it would be nice if this could just be an event / hook / observable. Instead of having a growing list of things to update in this file, the components that should update on "onaddresseschanged" just listen for the event / clink into the hook / observe the observable and update itself if necessary.
What we want
The solution should

[ ] store essential data (addresses & layout)
[ ] persist reload & navigation
[ ] fire an event (or similar) when a value changed

The first two items are addresses in the example code below.
Example code from an old project of mine
Global variable
let cookieFile;
let cookie = {
    set: (name, value) =>
        document.cookie = name + "=" + value,
    get: name => {
        var decodedCookie = decodeURIComponent(document.cookie).split(';');
  	for (let c of decodedCookie)
  	    if (c.trim().split("=")[0] == name)
  	        return c.trim().split("=")[
            return "";
    }
}

When component is mounted (LOAD)
if (!cookieFile && document.cookie != "") {
    cookieFile = {
    	name: cookie.get("initName"),
    	data: cookie.get("grid"),
    	size: JSON.parse(cookie.get("sizing"))
   };
if (cookieFile.data != "[]")
   loadGrid(cookieFile);

Before user leaves the page (SAVE)
A snippet similar to the following can go in src/utils/loader.ts and replace the current beforeunload listener
window.addEventListener('beforeunload', () => {
    cookie.set("grid", p.saveGrid(true));
    cookie.set("initName", initName);
    cookie.set("sizing", JSON.stringify({
        w: p.width,
        h: p.height
    }));
});


viv: elf: regression in viv v1.0.4 against test sample

https://github.com/vivisect/vivisect/issues/443
unfortunately this affects our single ELF test binary so we'll have to disable our viv+ELF tests until viv v1.0.5 is out

revert 56f9e16 when ready


.net standard

Heya,
I was wondering if there were any plans to support newer versions of (1.x) .NET Standard?
<IP_ADDRESS>-beta1 (from NuGet) seems to install into a .netstandard 1.6 project in VS 2017 (with no indicators that there is an issue), but the compat list shows only compatibility to .netstandard 1.1 and I can't use it in my 1.6 project. Are there large differences in the .netstandard versions that would prevent me from compiling it as 1.6?
I am attempting to keep my code light on overhead (for no reason other than I want to) so would like to avoid the .NET Framework if possible. I can use 1.1 or the .NET Framework if I need to, but thought I would ask the question anyway!
Thanks.

Never mind... looks like it is a VS 2017 quirk. When I switch between .netstandard versions it breaks dependencies...


Add an error resource to WASI streams

This commit adds a new error resource to the wasi:io/streams
interface. This error resource is returned as part of
last-operation-failed and serves as a means to discover through other
interfaces more granular type information than a generic string. This
error type has a new function in the filesystem interface, for
example, which enables getting filesystem-related error codes from I/O
performed on filesystem-originating streams. This is plumbed through to
the adapter as well to return more than ERRNO_IO from failed
read/write operations now too.
This is not super fancy just yet but is intended to be a vector through
which future additions can be done. The main thing this enables is to
avoid dropping errors on the floor in the host and enabling the guest to
discover further information about I/O errors on streams.
Closes https://github.com/bytecodealliance/wasmtime/issues/7017

I've attempted to split the commits up here because this needed changes to trappable_error_type to get it to work out well, which was a large crop of changes.


White line appear while 100% in Pie chart on android

Please help me, How to do resolve it ?

+1


merge from arlac77/npm-package-template-esm-only

.travis.yml

chore(travis): (jobs.include)
chore(travis): add 13.0.0 (jobs.include.node_js)
chore(travis): (script)

Coverage remained the same at 71.592% when pulling aca36087c77edf053c6aa2bb60d0e8f0a1a8a62d on npm-template-sync/1 into 7977700e8a59f9481956eeb8937810f8daa1c93f on master.

:tada: This PR is included in version 5.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Questions regarding Wand API

I'm just getting ramped up using GraphicsMagick.net and I was wondering what your gut feeling was on how difficult it would be to add support for a few of the Wand API functions. Specifically, I was considering implementing the AutoOrient function (which I think would be a useful method to expose on the MagickImage class).
There are a lot of gaps in my understanding of GraphicsMagick and this wrapper in particular, so I was wondering whether you thought that would be very difficult for a newcomer to tackle or not. Thanks!

I personally would like to switch to the implementation that I use in Magick.NET. This implementation uses an "old" method to call the GraphicsMagick library. My plan is to copy the Magick.NET source and strip out what is not available in GraphicsMagick. But I need a couple days off to make this possible.

Do you want me to leave this open @petersondrew or can we close it?

It can be closed, I went ahead and ported the auto orient code from the GM command line utility to my code because it ended up being very short and simple. Thanks for the follow-up.


⚠Getting Name error when enables auto upgrade for the 4th account

Update all files to the latest version. (utilities.py)


Adding Tiny Python Projects

Thank you! :cake:
PS: I've edited your commit. Moved link to Manning subsection and added the tagline.


Error when running tensorflow.python.ops.array_ops._constant_if_small

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
2.10.0
Custom Code
Yes
OS Platform and Distribution
Ubuntu 22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Due to empty or negative float inputs.

Standalone code to reproduce the issue
import tensorflow as tf
import os
import numpy as np
from tensorflow.python.ops import array_ops
try:
  arg_0 = -673
  arg_1 = []
  arg_2 = tf.uint64
  arg_3 = -0.5220044599057413
  out = array_ops._constant_if_small(arg_0,arg_1,arg_2,arg_3,)
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-01-21 12:14:09.136217: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-21 12:14:09.235416: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-01-21 12:14:09.678820: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:14:09.678991: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:14:09.678999: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-01-21 12:14:10.159520: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-21 12:14:10.183797: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudnn.so.8'; dlerror: libcudnn.so.8: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 12:14:10.183812: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1934] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2023-01-21 12:14:10.184037: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
Error:<class 'tensorflow.python.framework.ops.EagerTensor'> returned a result with an error set

</details>

@nimashiri,
Have you got the chance to check this comment from the developer where it was suggested the the invalid inputs will leads to the custom error.
The tf.uint64 dtype expects positive input and throws an error otherwise. Kindly find the gist of it here for the both +ve and -ve inputs. Thank you!

@nimashiri this is not a vulnerability, you're receiving a user error. Please consult SECURITY.md before sending new reports as very few of them are really actionable (and they should have been submitted via private channels)


better InformationWriter

Commits 1:
Changed file: pointcept/engines/hooks/misc.py
Aim: Use the new parameter interval to control the print frequency and logger_keys to set the values desired to output.
Actions:

add interval & logger_keys for InformationWriter for better print;
change Lr: {lr:.5f} to Lr: {lr:.5e}

Commit 2:
Changed file: pointcept/engines/hooks/evaluator.py
Aim: Make printed results readable.
Actions:

add print_results function to print and log the results of different classes for SemSegEvaluator.

Commit 3:
Changed file: pointcept/engines/hooks/evaluator.py
Aim: Make printed results readable.
Actions:

add print_results function to print and log the results of different classes for InsSegEvaluator.

Thank @RayYoh, I just began reviewing this PR. I will be merged into our v1.6


Is there a way to control aspect ratio for hvplot?

I thought from https://github.com/ioam/holoviews/issues/30#issuecomment-104613952 that this might work:
import xarray as xr
import hvplot.xarray
url = 'https://rsignell.s3.amazonaws.com/NLCD/nlcd_2011_landcover_2011_edition_2014_10_10.tif'
da = xr.open_rasterio(url, chunks={'x':2056, 'y':2056})

%%opts Image [width=700 height=500 colorbar=True aspect='equal'] (cmap='magma')
da[0, 50000:51000, 80000:81000].hvplot()

but I guess aspect is not a thing.
Is it possible to use Raster with hvplot?
I couldn't figure that out either.   😿

Currently bokeh does not afford us sufficient control over the inner plot dimensions to be able to offer aspect options. There is however a current PR in progress in bokeh that will allow us to take full control over the inner dimensions of a plot and therefore implement reasonable aspect control. I'd suggest checking back once bokeh 1.0 has been released and we've had a chance to expose the appropriate options in holoviews.

Okay, @philippjfr , thanks.   Is there a way to use Raster with hvplot?

@philippjfr Is this the bokeh PR? https://github.com/bokeh/bokeh/pull/8085#issuecomment-427104927

That's the one, it's on hold until bokeh 1.1 unfortunately as it's a huge chunk of work and didn't quite make the cut-off for 1.0, which should happen very soon.

@philippjfr I was also trying to set the aspect of a plot and came across this issue. It seems to me that that problem was fixed on Bokeh's end and that it's available now in version 1.1. So I'm checking back to see if this is implemented on hvplot's end.

It isn't yet but I was planning on spending next weekend on making various updates to hvplot.


Pvp world hop-to option

Since 2 weeks Runelite has deleted the hop-to Quick world hop option to pvp world, and its really affected me, i allways used runelite for its features, and this was one of them.
I used the hop-to option on my ironman to bank faster in a pvp world in Falador, i used it when training construction, and i used it on my main account just for faster hopping when pking.
I do not understand why you removed this option, in my opinion it was one of the best ones, i dont see any downsides to it, becouse a pvp world allways gives a warning before hopping anyways.
Ive talked to many of my friends about this, and they all feel thesame about it, could there be a conversation about it? i would love to see the feature return.
My solution would be to activate the hop-to option again for any world, since there is no downside to it, and will help many players in the game.
Jagex did not put the warning message there for nothing, it should be enough.
I hope there will be more people who feel thesame as me, and together we can get one of the best options back to Runelite, and make my skilling easier again like it was before :)
Thank you

I feel as the quick hop option had no flawls as Jagex put warnings for a reason, pvp world banks that are scattered around when pvming to save time, being able to quick hop makes it much easier, the feature should at least have it polled instead of just changing it without asking the community...
Another short reason, when at rev caves quick hopping to the leader makes it little to no effort when scouting worlds for fights, this has made it much more annoying.

I don't see anything wrong with an option for it if it was off by default. It was mostly to try and stop people doing ffa cox lures.

Those people are still there today, every day getting people, it has nothing to do with the hop-to option, they have been there for years before runelite came out, i still would like to see the option back

I'm confused about your use case, since it doesn't remove it from the ingame world hopper or the side panel world hopper.

I meen, i allways used the hop-to option for everything, it was just way easier. i allways record my screen, and if i open the side panel my recorder stops recording becouse the client size changes, so i have to set it up from the start every time i would do that. I just liked how it was, and it kinda messes with my routine. I understand you do updates for the better, but i just dont understand this one. It doesnt help anyone really, and if they did this for the cox lurers in the video i saw, i know them they have been there for years, and they are still there doing thesame thing, this option did not change anything for them, but it does for pvmers and skillers who use the option every day for convenience.
I feel bad its gone, i guess i will have to get used to it, thanks for your comment tho, i appreciate it.

Wow I noticed that they removed this option, it is a really big shame as this feature was very convenient for me. I don't understand why the would remove it? There was no problems with it for me, i wish they would add it back as it makes hopping worlds when pking with friends so much easier. I would appreciate if they added it back or at least gave me an option to turn it off or on. Maybe i will have to switch to an alternative client like exilent which allows this feature. But im not too sure yet.


Added Suez University Egypt

Official University Website link
Computer Science Page link

@MarcoRizk Pull request merged. Thank you!


feat(ListItem): add shorthand

The List update broke the Introduction page:

There may be other legacy usages as well.  Suggest searching the codebase and updating all usages of List to the v1 API.

It looks like List/List.Item shorthand was removed.
<List>
  <List.Item icon='check mark'>jQuery Free</List.Item>
  <List.Item icon='check mark'>Declarative API</List.Item>
  <List.Item icon='check mark'>Augmentation</List.Item>
  <List.Item icon='check mark'>Shorthand Props</List.Item>
  <List.Item icon='check mark'>Sub Components</List.Item>
  <List.Item icon='check mark'>Auto Controlled State</List.Item>
</List>

I'd maybe update this issue to add List shorthand.

Agreed and done, thanks.

I had a chance to look at the all the possibilities for lists (there are a lot!) and put together some thoughts on this. I'd say this is roughly what we should support via shorthand:
<ElementType>
  {icon || image}
  <List.Content>
    <List.Header />
    <List.Description />
    {content}
  </List.Content>
</ElementType>

Going to post what I found to be the unique variations with the shorthand below each:
// Super basic
<List.Item>1</List.Item>

// Shorthand
<List.Item content='1' />

// Icon + Content (content has header + description)
<List.Item>
  <List.Icon name='map marker' />
  <List.Content>
    <List.Header as='a'>Krowlewskie Jadlo</List.Header>
    <List.Description>An excellent polish restaurant, quick delivery and hearty, filling meals.</List.Description>
  </List.Content>
</List.Item>

// Shorthand
<List.Item
  icon='map marker'
  header={{ as: 'a', content: 'Krowlewskie Jadlo'}}
  description='An excellent...'
/>

// Image + Content (content has header + description)
<List.Item>
  <Image avatar src='http://semantic-ui.com/images/avatar2/small/rachel.png' />
  <List.Content>
    <List.Header as='a'>Rachel</List.Header>
    <List.Description>Last seen watching Arrested Development just now.</List.Description>
  </List.Content>
</List.Item>

// Shorthand
<List.Item
  image={{ avatar: true, src: 'http...' }}
  header={{ as: 'a', content: 'Rachel'}}
  description='Last seen watching...'
/>

// Icon + Content (content just has text)
<List.Item>
  <List.Icon name='users' />
  <List.Content>Semantic UI</List.Content>
</List.Item>

// Shorthand
<List.Item
  icon='users'
  content='Semantic UI'
/>

// Header + naked content, not wrapped in List.Content
<List.Item>
  <List.Header>New York City</List.Header>
  A lovely city
</List.Item>

// Shorthand
<List.Item
  icon='map marker'
  header='New York City'
  content='A lovely city'
/>

// Header + description, not wrapped in List.Content
<List.Item>
  <List.Header as='a'>Header</List.Header>
  <List.Description>
    Click a link in our description.
  </List.Description>
</List.Item>

// Shorthand
<List.Item
  icon='map marker'
  header={{ as: 'a', content: 'Header'}}
  description='Click a link...'
/>

// Multiple "content"s mixed with other data
<List.Item>
  <List.Content floated='right'>
    <Button>Add</Button>
  </List.Content>
  <Image avatar src='http://semantic-ui.com/images/avatar2/small/lena.png' />
  <List.Content>
    Lena
  </List.Content>
</List.Item>

// Shorthand
// Note: I don't think we can handle multiple contents.

// Nested list
<List.Item>

Benefits

  <List.List>
    <List.Item href='#'>Link to somewhere</List.Item>
    <List.Item>Rebates</List.Item>
    <List.Item>Discounts</List.Item>
  </List.List>
</List.Item>
<List.Item>Warranty</List.Item>

// Shorthand
<List.Item
  icon='map marker'
  content={<List /** Shorthand or full JSX for list */ />}
/>

// Content with props
<List.Item>
  <Image avatar src='http://semantic-ui.com/images/wireframe/square-image.png' />
  <List.Content verticalAlign='middle'>
    Middle
  </List.Content>
</List.Item>

// Shorthand
<List.Item
  image={{ avatar: true, src: '...' }}
  content='Middle'
  verticalAlign /** NOTE: This is passed-through to List.Content */
/>

Note that last example where a prop is passed through to List.Content. Our normal pattern/naming are a little conflicting here:

content could be a shorthand prop for List.Content
content could be the contentShorthand that takes the place of children

I think going with the latter makes sense, even though it forces us to pass-through props, because the List.Content may or may not be necessary. This allows a user to just pass header and description as props to the List.Item without needing nested hashes (e.g. content={{header, description}}).

// Shorthand
// Note: I don't think we can handle multiple contents.

Agreed!
Corrections
// Header + naked content, not wrapped in List.Content
<List.Item>
  <List.Header>New York City</List.Header>
  A lovely city
</List.Item>

// Shorthand
<List.Item
- icon='map marker'
  header='New York City'
  content='A lovely city'
/>

// Header + description, not wrapped in List.Content
<List.Item>
  <List.Header as='a'>Header</List.Header>
  <List.Description>
    Click a link in our description.
  </List.Description>
</List.Item>

// Shorthand
<List.Item
- icon='map marker'
  header={{ as: 'a', content: 'Header'}}
  description='Click a link...'
/>

Suggested Updates
// Content with props
<List.Item>
  <Image avatar src='http://semantic-ui.com/images/wireframe/square-image.png' />
  <List.Content verticalAlign='middle'>
    Middle
  </List.Content>
</List.Item>

// Shorthand
<List.Item
  image={{ avatar: true, src: '...' }}
- content='Middle'
- verticalAlign /** NOTE: This is passed-through to List.Content */
+ content={{ verticalAlign: true, content: 'Middle' }}
/>

I know content/content looks a little strange at first, though, each shorthand prop is mapped to a sub component part and the content shorthand prop is always the primary content.  In this case, it is the primary content of the List.Content component part.  We have this also in the Feed:
<Feed.Content content='Hi' />

<Feed
  content='Hi'
/>

I would also note that it is likely a less likely use case to have content={{ content: '', verticalAlign: true }}.  Most the time, there won't be two content terms at play.  When there is, odds are the user will be familiar with the conventions and it shouldn't be too much of a curve ball.
Thoughts?

The double content={{ content: '' }} doesn't bother me as much. It's that the ItemContent isn't always supposed to be there so we can't just call ListContent.create in all contexts. Always having the wrapping content actually causes CSS issues. Therefore, here's what would change from the existing PR I opened #637:
  const iconNode = ListIcon.create(icon)
  const imageNode = Image.create(image)

+ if (_.isPlainObject(content)) {
+   return (
+     <ElementType {...rest} className={classes} {...valueProp}>
+       {iconNode || imageNode}
+       {ListContent.create(content, { header: header, description: description })}
+     </ElementType>
+   )
+ }

  const headerNode = ListHeader.create(header)
  const descriptionNode = ListDescription.create(description)

  if (iconNode || imageNode) {
    return (
      <ElementType {...rest} className={classes} {...valueProp}>
        {iconNode || imageNode}
        {(content || headerNode || descriptionNode) && (
          <ListContent>
            {headerNode}
            {descriptionNode}
            {content}
          </ListContent>
        )}
      </ElementType>
    )
  }

  return (
    <ElementType {...rest} className={classes} {...valueProp}>
      {headerNode}
      {descriptionNode}
      {content}
    </ElementType>
  )
}

Doesn't add that much complexity I guess. Thoughts?

Looks good to me, I think the public API wins out over a little funny business in the code.  Suggest a code comment to clarify why the plain object check.

The thing I don't love about that approach is that it deviates from our current shorthand pattern. In this case, content if content is:

props, it's treated as props to Item.Content (and thus the wrapper around header/description) (makes sense)
element

if icon/image present, it's treated as the content of Item.Content (and a sibling to header/description)
if not icon/image present, it's treated as sibling to header/description

This might be a little more consistent:
  const iconNode = ListIcon.create(icon)
  const imageNode = Image.create(image)

  const headerNode = ListHeader.create(header)
  const descriptionNode = ListDescription.create(description)

  if (iconNode || imageNode || _.isPlainObject(content)) {
    return (
      <ElementType {...rest} className={classes} {...valueProp}>
        {iconNode || imageNode}
-       {(content || headerNode || descriptionNode) && (
-         <ListContent>
-           {headerNode}
-           {descriptionNode}
-           {content}
-         </ListContent>
-       )}
+       {(content || headerNode || descriptionNode) &&
+         ListContent.create(content || '', { header: header, description: description })}
      </ElementType>
    )
  }

  return (
    <ElementType {...rest} className={classes} {...valueProp}>
      {headerNode}
      {descriptionNode}
      {content}
    </ElementType>
  )

Note that it's valid to only pass a header or description so we need a non-nil value for content so that the content gets generated.
But even in that case, if:

props, it's treated as props to Item.Content (and thus the wrapper around header/description) (makes sense)
element

if icon/image present, it's treated as a replacement of Item.Content (and overrides header/description which is fine)
if not icon/image present, it's treated as sibling to header/description

After thinking about it I'd kinda prefer the first one and just comment on the inconsistency/break from pattern.

If you pass content as an element/literal, it's actually treated as the sibling node to header/description (whether wrapped in Item.Content or not).
If you pass content as props, it forces the presence of Item.Content and passes those props to it. If you pass a content prop within that props object, it will be treated as the sibling node to header/description.


New sheet - Dračí doupě ppp 1.6

Changes / Comments
New sheet for czech game Dračí doupě
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

NEW SHEET
for Czech game Dračí Doupě

Hello,
Thank you for merging my sheet.
Its possible to Add Character Sheet into the roll20 list, for using in whole czech comunity?

Hi,
Thank you for merging my sheet.
Its possible to Add Character Sheet into the roll20 list?

Yes, it will be available after the next code deployment scheduled for Tuesday, 24th of November at 8:30 PST (-8 UTC).


Fix pycon lexer not recognised by sybil

On top of #345.
We were not testing the examples under the pycon fences. @gautierronan can we juste use python as proposed in this PR, or should we try an find a workaround to keep pycon?

Well the syntax highlighting is not quite the right one if we don't use pycon. Is it hard to make a workaround?

Well the syntax highlighting is not quite the right one if we don't use pycon. Is it hard to make a workaround?

Right, let me see.

Fixed, it's super simple to add a custom parser to sybil 👍


[not ready?] switch to only storing 32 bits of the 64-bit hashes in the ldict

This does what was proposed in #40 and switches the internal representation of the ldict to 32 bits. The external interface is unchanged, but only the 32 least significant bits of the 64-bit input hash are used.
Running the French address test, peak memory usage is down about 35%, from ~5.5 gigs to ~3.4 over the test run. The number of positives at this loop:
https://github.com/mapbox/carmen/blob/master/lib/phrasematch.js#L54
increased by 3, from 9049 to 9052, so, a tiny fraction of a percent, with no appreciable difference to either compute time or results over this test.
So... I think it works?
cc @mapbox/geocoding-gang

@apendleton showed today that this had n noticeable negative effect on the ldict cache. :+1: let's plan on shipping this when you feel solid about it.


Add a testing section to the documentation

What type of PR is this?
documentation
What this PR does / Why we need it?
Adds a new Testing section

/lgtm


There's no FilterContains in sqla/filters

I'm trying to filter based on a range field.  looking for something like
class FilterContains(BaseSQLAFilter):
    def apply(self, query, value, alias=None):
        return query.filter(self.get_column(alias).contains(value))

    def operation(self):
        return lazy_gettext('contains')

Is there a reason why this doesn't exist?  Performance concerns?  A different way to do this filter using existing filter functions?

from flask_admin.contrib.sqla.filters import BaseSQLAFilter
from sqlalchemy import and_

class FilterRange(BaseSQLAFilter):
    def apply(self, query, value, alias=None):
        column = self.get_column(alias or self.column_name)
        return query.filter(and_(column >= value[0], column <= value[1]))

    def operation(self):
        return lazy_gettext('range')  # Replace with appropriate translation if needed


no retries in get.py Response makes tweet search fail randomly

Twitter sometimes doesnt reply, at least to me...  And twint waits 120 seconds before timing out! That makes long series of different queries take an unnecesary amount of time, for each failed request.
Also as there is no retry in the request, this will return an empty search, when it isnt.
I changed the timeout to 3, and make a retry at least 3 times for a failed request, and now I can get all the tweets I want whenever I want them, in a reasonable amount of time.
Shall I make a pull request?
Thanks.

Twint retries the query a few times before exiting. You can rise config.Retries_count or add sleep calls
A timeout of just 3 sec would not be enough
https://github.com/twintproject/twint/blob/1a60a3b26aebf12aee3e6d54e9479c9e688a6026/twint/run.py#L96-L98
How are your changes different that these? I think that we could add a sleep call and maybe even reduce the timeout value to a smaller one

Hi, I dont really know the twint code yet, since I just found it (thank you all for this great thing), and did a messy workaround to avoid the following situation:
I want to retrieve a Pandas data frame with a set of 5000 twitts containing one simple word.
For that matter I create a config like:
c = Config();  c.Pandas = True;  c,Limit = 5000;  c.Search = "SEARCH";  c.Lang = "en"
This kind of searches always tend to freeze after returning some tweets and raises a Canceled Error:
CancelledError                            Traceback (most recent call last)
~/gits/twint/twint/get.py in Response(session, url, params)
    148         async with session.get(url, ssl=True, params=params, proxy=httpproxy) as response:
--> 149             return await response.text()
    150

So I just catched that exception inside the function, as I dont know where is used, and inserted lines 148 and 149 In a three tries loop. that worked!

I looked I little bit more in the code, and found the source of the problem, and it is that when RequestUrl is called from Feed in run.py there is no exception handling:
https://github.com/twintproject/twint/blob/0f19841b0f2e6456094c6c85b89faf8a0e82f7b1/twint/run.py#L48-L54
Si, I moved all inside the while loop into the try block below, and now whenever the usual exception is raised, is catched by the "except Timeout" block. But that raised a new exception because of asuming that the proxy is set.
https://github.com/twintproject/twint/blob/0f19841b0f2e6456094c6c85b89faf8a0e82f7b1/twint/run.py#L71-L72
Si with a check on the if condition, in case Proxy_host is None, the problem is fixed.
if self.config.Proxy_host != None and self.config.Proxy_host.lower() == "tor":