Add support for multiple modals on top of eachother

Right now we only support one modal at any given time
The API should remain the same, dismissModal should dismiss the topmost modal

@talkol what do you think to add passing props to modal?

@siwymilek that's a good point..
Currently the show modal is a very low level function that takes a controller and displays it. A controller doesn't accept props. It has its own JSX definition where we can pass props directly to its children. But that's not very convenient because this means you need to define JSX on the fly for every new modal you have if they each have different props.
That's actually what happens in https://github.com/wix/react-native-navigation
If you'll look at the docs you'll see that the react-native-navigation does allow you to send props to modals and that's exactly how it's implemented. Just a higher level of abstraction over the low level interface
I'm worried that adding props to the original low level function will complicate it.. what do you think? are you using controllers directly or through navigation?

@talkol I'm sorry but I don't understand what you mean of "using controllers directly or through navigation"

@siwymilek see this:
https://github.com/wix/react-native-controllers#before-you-start
"react-native-controllers is a low-level package with API that wasn't designed to be cross-platform (since it's optimized for native UX). We have another project called react-native-navigation which is a syntactic sugar wrapper around react-native-controllers. It provides the same native goodness with API that is much simpler, cross-platform between iOS and Android, and supports redux!"
I meant if you're using react-native-controllers or the react-native-navigation wrapper

@talkol I use react-native-controllers

@artald added multiple modal support.
Leaving the issue open until we address @siwymilek request for props

@talkol I think we should close this one and open a separate issue for the props. They are not related in any way.

Sure, @artal do you mind closing and opening a new issue?
On Friday, 25 March 2016, Artal Druk<EMAIL_ADDRESS>wrote:

@talkol https://github.com/talkol I think we should close this one and
open a separate issue for the props. They are not related in any way.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/wix/react-native-controllers/issues/26#issuecomment-201191508

np.
Multiple modals closed with ffdcda2.
New issue for passing props to modal is here.

@siwymilek the next release will include support for passing props to modals

@talkol ok, thanks for call :) By the way, could you answer for my last post on [Issue #17]?(https://github.com/wix/react-native-controllers/issues/17#issuecomment-203882824)


⚠ ClamAV has degraded performance

In 5a892b8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 201 ms

Resolved: ClamAV performance has improved in 9fa6571.


[WIP] Support kop for v0 version of SASL_HANDSHAKE

Fixes #667
Motivation
If SaslHandshakeRequest version is v0, a series of SASL client and server tokens corresponding to the mechanism are sent as opaque packets without wrapping the messages with Kafka protocol headers. However, KoP always parses the header before a request is processed.
Modifications
Support sasl/plain tokens are sent without Kafka SaslAuthenticate request/responses and compatible with existing authenticate.

@BewareMyPower This pr is ready for review, PTAL :)


runtime:  pointer assignment in tight loop cause long STW

What version of Go are you using (go version)?

$ go version
go version go1.20.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/zgy/.cache/go-build"
GOENV="/home/zgy/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/zgy/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/zgy/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/home/zgy/00.Tools/stablego/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/zgy/00.Tools/stablego/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.2"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2002358002=/tmp/go-build -gno-record-gcc-switches"

What did you do?
package main

import (
	"runtime"
	"time"
)

var a = [1000]*int{}

func Func1() {
	var b [1000]*int
	for a[0] == nil {
		a = b
	}
}

func main() {
	go Func1()
	ticker := time.NewTicker(time.Second)
	for range ticker.C {
		runtime.GC()
	}
}

Use go build to build this single file program.
And use export GODEBUG=gctrace=1 to enable gctrace.
Then just excute it.

What did you expect to see?
The STW time of GC should in normal range. Maybe microseconds to milliseconds.
What did you see instead?

./main
gc 1 @1.001s 24%: 328+4201+1363 ms clock, 5259+0/0.13/0+21812 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 2 @6.894s 39%: 48+3432+3799 ms clock, 768+0/0.10/0+60788 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 3 @14.173s 41%: 389+838+673 ms clock, 6231+0/0.13/0+10774 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 4 @16.075s 49%: 2399+319+544 ms clock, 38386+0/0.12/0+8716 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 5 @19.339s 38%: 413+7188+725 ms clock, 6621+0/0.10/0+11607 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 6 @27.667s 40%: 15+145+1200 ms clock, 243+0/0.091/0+19212 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)
gc 7 @29.028s 45%: 1281+450+1298 ms clock, 20501+0/0.11/0+20773 ms cpu, 0->0->0 MB, 4 MB goal, 0 MB stacks, 0 MB globals, 16 P (forced)

Actually, The second STW during GC is about one second. I have even observed it will be several minutes.
It seems that this may be related to #36365 . There is a task "Make large pointer-full memmoves/memclrs preemptible" in it. But it seems that it is no more update about it.

I think this is unfortunately just the way things are right now, because runtime all code (including the memmoves) is non-async-preemptible. These memmoves also don't have preemption points themselves. Maybe we could have versions of these memmoves that do have preemption points? That would at least fix this "called in a loop" case, but it wouldn't help with singular long memmoves.
Resolving the relevant task from #36365 would indeed also fix this, and it would be a more general fix.


Generalize gcc/llvm assembly handling

The assembly handling is currently tied to the riscv architecture, but most of the code is generic enough so that it can be extracted into an isolated assembly module.

Wdym assembly handling?

@emilyaherbert do you know why @chriseth reopened this?


UI - Explore - Filters and Search are able to return correct results only for the first 10 assistant entries.

Electron app build wit commit id- 4414471
Steps to reproduce the problem:

Have more than 10 assistant entries so that you have to use the "Load More" to see the full list in Explore view.
Try to use the filters or search (by agent name) to fetch assistants that are not in the first 10 assistant entries.
Search will not return any entries that match the search criteria but are not present in the current assistant list (10 entries).

Using "Load More" results in this issue - https://github.com/gptscript-ai/gptscript/issues/726
When searching for agent names that match the assistant entries that are present after the first 10 entries, we get search results that are invalid.
In this case there is an agent named "echo" which is not in the first 10 entries.

Expected Behavior:
Search and Filters should work on the the entire list of assistants and be able to present up to 10 entries from the search results.

@sangee2004 this should be fixed now.

Tested with latest commit id - c5e7e29371
This issue still exists
In my case i am testing for sangeenewworkspace which is not in the first 10 assistants.
I get an empty result:

When I do "load more", entries presented do not match the agent i am searching for:

@sangee2004 I just pushed a new fix for this. Can you check again?


Errors about DLLs during Automatic1111 Startup

Hello, i'm having trouble running Tensor RT. I installed the extension and clicked "restart UI". and when it restarts, there's errors popping up:
Error 1:

Error 2:

Error 3:

Error 4:

And the log inside the Automatic1111 startup terminal:

I tried to install TensorRT multiple times on clean installs and nothing changes.
Thank you in advance for your assistance

same to me

pip uninstall -y nvidia-cudnn-cu11
fixed it for me


Added resnet_lax.ipynb for resnet_torch.ipynb

Description
Converted resnet_torch.ipynb notebook to resnet_jax.ipynb.
Checklist:

[x]  Converted torch code to jax.
[x]  Verified that it runs on colab.

Potential problems/Important remarks
The best accuracy on the test set is same as the pytorch code.
The notebook is available at https://colab.research.google.com/github/codeboy5/probml-notebooks/blob/add-resnet-jax/notebooks-d2l/resnet_jax.ipynb

Can you please review my code? @murphyk @mjsML @gerdm

Looks great!


ExtensionLoader print exception

Your question
com.alipay.sofa.rpc.ext.ExtensionLoader#readLine
try {
            tmp = ClassUtils.forName(className, false);
        } catch (Throwable e) {
            if (LOGGER.isWarnEnabled()) {
                LOGGER.warn("Extension {} of extensible {} is disabled, cause by: {}",
                    className, interfaceName, ExceptionUtils.toShortString(e, 2));
            }
            return;
        }

Your scenes
describe your use scenes (why need this feature)
Your advice
maybe we don't need to catch Throwable?
or we can print ExceptionUtils.toString(e)?
Environment

SOFARPC version:
JVM version (e.g. java -version):
OS version (e.g. uname -a):
Maven version:
IDE version:

The question is we don't know why user don't import classes.
For example:
Registry has three extensions: zookeeper, dsr, consul
If user want use zookeeper as registry, and did not import dsr.jar and consul.jar, dsr and consul registry extension will disabled, we need ignore it.
But if user did not import zookeeper.jar, zookeeper registry will disabled, too. It's better to throw exception when not found extension ( get registry from RegistryFactory).

Now, these three factory did not throw exception when not found extension:
CompressorFactory, SerializerFactory, ProtocolFactory。

At ExtensionLoader#readLine, we can add extra DEBUG exception stack trace.


Using slice doesn't work properly

What version of Go are you using (go version)?
Both 1.17 and 1.18
Does this issue reproduce with the latest release?
Yes
What did you do?
Using slices in recursion and assigning its values to some value in any struct.
See here: https://go.dev/play/p/iUZ5tF5AUJP
The correct printed value should be
[{[value1 value1 value1 value1 value1 value2 value3]}]

But it is printing
[{[value1 value1 value1 value1 value1 value3 value3]}]

The same thing works fine if we don't use any struct.
See here: https://go.dev/play/p/d3ZLQTDPeoy
In this case the printed value is
[value1 value1 value1 value1 value1 value2 value3]

/priority critical

This is how slices work. Append does not always make a copy, but often appends in place.
See https://go.dev/blog/slices-intro for more background.
This patch fixes your code:
	if len(a) == 7 {
		a2 := make([]string, len(a))
		copy(a2, a)
		res := test{l: a2}


How about updating README to showcase this plugin

I'm about to try this plugin since it was suggested by the IPAdapter author here, and surely I'm not the only one interested in it. However, the README leaves a lot to be desired.
There's no need to convert it to Mozilla Developer Network article either, a few screenshots to showcase the plugin provided nodes would be enough and relatively easy to add. Thanks.

I know there's a note in the readme about doing better documentation. please check the included workflow, that should help a bit

yeah im looking it over wanting this exact kind of idea. More specifically a node that adds upscale image with model and amount. does have that idk. it doesnt tell me and idk if i wanna download this just to have to remove it.


#1415, get exactly value of schema

Fixes #1415 .

Pull Request Test Coverage Report for Build 5660

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.795%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/backend/SchemaIgnoreBackendHandler.java
0
1
0.0%

Totals

Change from base Build 5659:
0.0%

Covered Lines:
8457

Relevant Lines:
12117

💛  - Coveralls


Is there a JSON schema that can help me validate the data model of a PUSH dataset?

I am evaluating PUSH datasets for my customer. I can immediately see that the model specification for PUSH dataset is somewhat different from regular datasets. E.g. No support for calculated columns.
It would be very helpful to have a JSON schema from Microsoft which can help me validate if an existing SSDT model can be used for a PUSH dataset.
If Microsoft can produce a consistent schema , then I can write some simple code like this to perform validatations.
Thanks,
Sau

Thanks for your comment, @sdg002. Looks like this is product feedback or a feature request, rather than documentation feedback – you can submit product feedback or feature ideas by going to https://ideas.powerbi.com. You can also engage with the Power BI engineering team by being active in the Power BI Community, found at https://community.powerbi.com


troubleshooting index #s for activity block functionality

testing/ref branch - will not merge to main

disregard


[DLPack] DLPack doesn't work with int32 on gpu

Reproduce code: https://colab.research.google.com/drive/1kwR_ZVutSot7yA7FqPUvCsKgXcirmNLh?pli=1#scrollTo=UI-LuV7EUick
Error message on my machine:
2020-07-11 14:42:25.598880: E tensorflow/stream_executor/cuda/cuda_driver.cc:1037] failed to enqueue async memcpy from device to host: CUDA_ERROR_INVALID_VALUE: invalid argument; host dst: 0x1abfd2c0; GPU src: 0x1a027e80; size: 12=0xc
2020-07-11 14:42:25.598954: F tensorflow/core/common_runtime/gpu/gpu_util.cc:291] GPU->CPU Memcpy failed

It seems the int32 tensor's data pointer is on cpu instead of being on gpu, althought its device is "gpu". Previously as I know there's special case handling for int32 tensor(https://github.com/tensorflow/tensorflow/issues/34071), not sure whether this is related.
And I just found I used constant_op.constant to test dlpacks, which means now it only test the case on cpu since tf.constant always place data on host memory
Do you have any idea on this issue? @sanjoy @alextp

Looks like .device returns the device of the operation which is not correct for operations with HostMemory outputs, like int32 identity.
We can probably add a method that returns the true devices for a given TFE_TensorHandle (Tensors know how to deallocate themselves so this information is in principle already present), but this is a high impact API change and we need to think this through.
Also, @VoVAllen , what should be the behavior of to_dlpack if it is passed a non-GPU tensor?

CC @jaingaurav

For DLPack, there's a ctx field indicating which device this pointer belongs to.
Two things I think needed:

Be able to get the real device of the pointer

I believe there should be such API in tensorflow now, because operator needs to know the pointer's location for further computation.

Be able to explicitly copy int32 tensor to gpu

Currently our workaround is cast it to uint32 -> copy to gpu ->cast it back to int32

I understand why int32 tensor are on cpu if using tf.constant, but why it needs exception in tf.identity also that still not copying it to gpu?

I believe there should be such API in tensorflow now, because operator needs to know the pointer's location for further computation.

I agree, I have filed a Google-internal bug about this.

but why it needs exception in tf.identity also that still not copying it to gpu?

The int32 Identity kernel explicitly places its input and output on the host, via a HostMemory annotation.

Any updates on this issue?

Internally we decided that this is a documentation bug.  The physical device of a Tensor can be accessed via the backing_device property, not the device property.

Is there any API to get the backing_device I can use to fix the bug in dlpack for now? Currently I use https://github.com/tensorflow/tensorflow/blob/3ace29966b79711b848a76135248c743b2fdeace/tensorflow/c/eager/dlpack.cc#L112, which seems the op device instead of backing_devicce

Just call BackingDeviceName instead of DeviceName


Add CSS File

https://github.com/chryz-hub/chryz-hub.github.io/tree/master/src

@Evavic44 , will start with the work today 👍

Hey @namangupta1399 Can you please wait for @jomefavourite. He'll relate what will be added to the CSS file.
It's just the custom styles and utilities we'll be using through out the site that needs to be added. Thanks

Yes, will start only after the discussion.

Okay, I'll add the css file

I've merged it already!

I've merged it already!

Okay good

Notice I created two CSS files, one id the global styles where we added things to be reused, and the styles CSS file for the general styling

Notice I created two CSS files, one id the global styles where we added things to be reused, and the styles CSS file for the general styling

I don't really know much on this but I know we're are ready to go🚀😅

Nice one @jomefavourite, but I think all CSS files should be in the same folder. For easy organization.

Please let's deliberate on this as fast as we can!

Nice one @jomefavourite, but I think all CSS files should be in the same folder. For easy organization.

Okay it's cool. You can fix that please.

Moved the CSS file. @chryzcodez Please can you review and merge.

I am closing this issue since the CSS files have been added.

I am closing this issue since the CSS files have been added.

The index.html is link to the old location of the moved global.css file. Please could you change it to the link of the new location.

Okay. Will do that. Thanks for pointing that out.

Done. 👍🏾


Wallet dropdown

Conflicts with https://github.com/toniengelhardt/m3tadata/pull/31.
Not finished yet.

This looks good!


DIGITS Tutorial based on this project

Hi, just to let watchers know that I have added a Tutorial on DIGITS for text classification using the model from this project.
See the write-up
I am using CuDNN and an optimized data loader and training time is an order of magnitude faster than the reference implementation. On my system it takes ~15mn to train one epoch of  498400 training samples and 56000 validation samples, with 4 validation sweeps per epoch.

This isn't an issue so I am closing now.

Do you have a public aws ami with digits installed?

Sorry I don't have that. We have a docker image for DIGITS which makes installation very straightforward.
However you need a more recent version of DIGITS than available in the Docker image to run the Text Classification tutorial. @flx42 is it conceivable to publish a Dockerfile to allow users to create images off the latest DIGITS code from Github?

Thank you for implementing this, it works much faster.  Because the input is 1024 characters instead of the 1014 in the original version, should the sizes of the layers be slightly different?  e.g. 341 x 256 after the first TemporalMaxPooling, and so forth.

Oh yes I should have updated this comment. Or perhaps it should be removed since the idea is to have the number of input characters a parameter.
With feature_len=1024 don't we end up with (1024-6-3)/3+1=339 features after the first max pooling operation? So the successive shapes would be:
    -- those shapes are assuming feature_len==1024
    -- 1024 x alphabet_len
    net:add(backend.TemporalConvolution(alphabet_len, 256, 7))
    -- [1024-6=1018] x 256
    net:add(nn.Threshold())
    net:add(nn.TemporalMaxPooling(3, 3))
    -- [(1018-3)/3+1=339] x 256
    net:add(backend.TemporalConvolution(256, 256, 7))
    -- [339-6=333] x 256
    net:add(nn.Threshold())
    net:add(nn.TemporalMaxPooling(3, 3))
    -- [(333-3)/3+1=111] x 256
    net:add(backend.TemporalConvolution(256, 256, 3))
    net:add(nn.Threshold())
    -- [111-2=109] x 256
    net:add(backend.TemporalConvolution(256, 256, 3))
    net:add(nn.Threshold())
    -- [109-2=107] x 256
    net:add(backend.TemporalConvolution(256, 256, 3))
    net:add(nn.Threshold())
    -- [107-2=105] x 256
    net:add(backend.TemporalConvolution(256, 256, 3))
    -- [105-2=105] x 256
    net:add(nn.Threshold())
    net:add(nn.TemporalMaxPooling(3, 3))
    -- [(102-3)/3+1=34] x 256
    net:add(nn.Reshape(8704))

We still end up with 8704 features at the input of the fully-connected layers.

Ah yes, I had forgotten the -6 in the first convolution.  Thanks, this helps a lot. I was making some changes to the network and wanted make sure I was calculating everything correctly.

This is wonderful! I see the pull request is in DIGITS already. If you do not mind, I will probably brag about it on Facebook a bit :P
Thanks for the great contribution!

If you do not mind, I will probably brag about it on Facebook a bit :P

You are most welcome to do so :-)


Support redirects including fragments

https://trello.com/c/RfRbIDB9/694-fix-unpublish-with-fragment-redirect-in-publisher

Ahh this is interesting. I can understand your use case but I think this is going to need a deeper fix than this.
We use this validator in a few places where the schemas define absolute_path in those instances we don't want to accept a fragment.
For redirects we'd want to support what the schemas describe as absolute_fullpath so I think we'd probably want a new validator for that and to test redirect destinations against that instead?

We use this validator in a few places where the schemas define absolute_path in those instances we don't want to accept a fragment.
For redirects we'd want to support what the schemas describe as absolute_fullpath so I think we'd probably want a new validator for that and to test redirect destinations against that instead?

Ok, I'll hopefully have time to look again at this today.

I'm replacing this with https://github.com/alphagov/publishing-api/pull/859


Adjusted github install instructions in README

The setup.py includes the following local pathing reference: kthresher/kthresher.py.
You must change directory into the local repository before running setup.py for the install to complete.

Additional commit to add a man(8) page to the project

Adjustments made per requested standards

lgtm, thanks!


TrackerConfig.json broken by PR that updated linting

https://github.com/quantumjot/BayesianTracker/pull/204 has broken the ability to convert TrackerConfig to json.
Steps to reproduce
import btrack
from btrack import datasets

config_file = btrack.datasets.cell_config()
config = btrack.config.load_config(config_file)
config.json()

Output
The following error is raised:
Traceback (most recent call last):
  File "/Users/paul/git/BayesianTracker/tracker_to_json.py", line 6, in <module>
    config.json()
  File "pydantic/main.py", line 505, in pydantic.main.BaseModel.json
  File "/Users/paul/mambaforge/envs/napari-btrack/lib/python3.9/json/__init__.py", line 234, in dumps
    return cls(
  File "/Users/paul/mambaforge/envs/napari-btrack/lib/python3.9/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/Users/paul/mambaforge/envs/napari-btrack/lib/python3.9/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "pydantic/json.py", line 103, in pydantic.json.custom_pydantic_encoder
  File "pydantic/json.py", line 90, in pydantic.json.pydantic_encoder
TypeError: Object of type 'ndarray' is not JSON serializable

Suggested solution
I've had a quick look into what is causing the error and it's not clear. The PR was so large and may have inadvertently broken other parts of the code. We could revert all the changes in the PR, add a test for converting TrackerConfig to json and writing to file, then start adding back the changes in #204

For a bit more context, the reason this issue wasn't picked up in CI is because the test for exporting a TrackerConfig uses a minimal config that has no MotionModel, HypothesisModel, or ObjectModel.  The error is only raised when pydantic attempts to serialise the numpy arrays in these models. Although it's still not clear why there's an error now but not before.


Roll Engine from d4158760408d to d30471572e4e (1 revision)

https://github.com/flutter/engine/compare/d4158760408d...d30471572e4e
2022-04-22<EMAIL_ADDRESS>Roll Skia from 58d5cbcebfca to 52489092edfa (1 revision) (flutter/engine#32855)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Various BATS fixes to fix CI/CD

Various BATS fixes

All of them are passing: https://buildkite.com/EOSIO/eosio-base-images/builds/216


UWP - Provide a way to display title bar context menu

Proposal: UWP - Provide a way to display title bar context menu
The default title bar has a context menu however a UWP app can't display it programmatically without input injection which requires a restricted capability.
Summary
The default UWP title bar only has the title text and the caption buttons unlike desktop apps and Windows 8.1 apps and this was the style that was adopted for most apps. However now with Windows 11, many apps are starting to adopt a style with the app icon as well as the title text. If you are a desktop app and using the default title bar, you already have the icon but with UWP apps, you need to create a custom extended title bar. One of the main features of the default Win32 title bar is that, when you click on the icon, you get the title bar context menu however this isn't possible with a custom title bar in UWP so now you've inconsistent behavior across Win32 and UWP apps. Input injection can be used for displaying the menu however it requires a restricted capability and for this simple behavior that Win32 apps already have, you shouldn't need it.
Rationale

Making it easier to use the same consistent behavior from Win32 title bar in a custom UWP title bar.

Scope

Capability
Priority

This proposal will allow developers to display the title bar context menu programmatically at a specific position
Must

Important Notes

The default title bar for UWP can be updated with the addition of app icon with the same Win32 behavior so this proposal is only for apps choosing to extend content into title bar and build a custom one.

last time CoreWindow(aka system managed hWnd aka UWP) app model(not ui) got any real improvement was in 2017
it's 2021, when MS finally back into it's senses - new age of windowsappsdk and modern win32   -  it's high time to move on

This is indeed the design decision made for UWP apps, and as such CoreWindow/ApplicationView does not support showing an icon in the TitleBar. We currently have no plans to change that design decision, which also means that we have no plans of adding this feature to CoreWindow/ApplicationView.

This is indeed the design decision made for UWP apps, and as such CoreWindow/ApplicationView does not support showing an icon in the TitleBar. We currently have no plans to change that design decision, which also means that we have no plans of adding this feature to CoreWindow/ApplicationView.

However many of the inbox UWP apps in Windows 11 show an icon in the title bar and since they're custom, they can't replicate the same click behavior that the default Win32 title bar has, creating inconsistency. While these are possibly going to stick with custom title because they have more than the icon, by default it should be consistent.
New Microsoft Store:

New Security dialog:

New Photos app (unreleased):


Allow use of (some) OS libraries

In order to facilitate integration into Linux distributions, it would be preferable to not embed libraries.
This pull request adds a cmake configuration to (not) use bundled libraries:
-DUSE_BUNDLED_LIBRARIES=ON/OFF
FindXXX modules have been split in 3 directories:
OSModules to be used when bundled libraries are deactivated
BundledModules to be used when using bundled libraries
Modules for those that are shared
3 dependencies are still always from the bundle: FBXSDK, PhysX and XShaderCompiler.
Those libraries are not usually part of Linux distributions, so I do not have an immediate solution not to bundle them and still make it easy to compile the project.

Hi, I haven't had a chance to take a proper look over the PR yet, but just a quick note. bsf should look for system libraries by default if bundled ones are not present - is that behavior not working or somehow inadequate, or does your approach provide some extra functionality? I suppose if required we could also force this behaviour to be enabled through a CMake flag (instead of just searching for the files).

The goal would be to ensure that bundled libraries are not used.
In Linux packaging, we try to avoid as much as possible automatic feature detection. The build should fail if prerequisites are not met.
It makes it easier to provide consistent builds.
An other difference is that by using the modules from the OS itself, it will work with libraries installed in non-standard location, or that add cflags etc.
Finally, it enables bundled mode to copy the libraries, and OS mode to just link to them.

The PR needs some more work, as it broke bundled libraries, I am working on it.

I understand the reasoning, I'm just saying bsf already does that. It first calls find_path and find_library on the bundled library locations, and if those aren't found, then it calls those same methods using the default search paths - to me this seems like the same thing you are doing in the non-bundled modules? But I might be missing something.
The only difference is that your approach can be toggled with a cmake flag, but we can extend the existing approach with that as well, with no further changes.


Is the tokenizer.model deterministic?

Hi, I'm developing a tokenizer based on Korean.
Since my project is to develop a language model using SRILM's ngram, the role of tokenizer is very important.
I couldn't experiment because of the large capacity of the corpus, but I want to hear your answer quickly, so I'm leaving an issue.
Is the result of morfessor deterministic? In other words, will the same model be created after repeated learning dozens of times?
If it is non-deterministic, are there any index or methods to measure how different the performance of results(tokenizers) varies?

This wasn't probably quick enough - sorry - but to add some answer:
The training algorithm goes through the input words in a random order, but by using the --randseed option you should be able to get the same output for the same input.
The intrinsic evaluation for different results is the cost (negative log-probability) that is logged during and after training. The lower the better. The correlation to performance in any actual application may be minimal, but at least sometimes better optimization leads to a higher morphological segmentation accuracy.


Adopt pipeline NPM plugin

Description
pipeline-npm-plugin: https://github.com/jenkinsci/pipeline-npm-plugin
Adoption accepted here : https://github.com/jenkinsci/pipeline-npm-plugin/pull/2
FYI @timothydowney

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

[ ] Add a link to the pull request, which enables continous delivery for your plugin or component.
Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory and Jira at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

lgtm -- Thanks @jonesbusy .


How to resize destktop to fit browswer container?

First, this is amazing!!! THANK YOU!!!
Second,
is there a way to set the desktop size?  I'm using https://github.com/mescon/Muximux as a "docker" to get to Myrtille.   However, the desktop is always cut off on the edges as the browers shows scroll bars.
Is it my settings??? or is there a way to make the desktop size fit the browser dimentions?
THANKS AGAIN!
AWESOME!

Hi, thanks for your support! :)
Regarding the remote desktop size, Myrtille does autodetect it from the browser size. The session is not resized dynamically afterward (if you resize the browser after the connection); so make sure to adjust your browser size prior to connect (ie: F11, fullscreen).
You can also define it manually from the URL by setting "width" and "height" into the querystring as described here.
I didn't knew Muximux, it's interesting :)

@cedrozor,
Yeah, I'm testing with Chrome, and if I go into full screen, then it's sized properly, or if I zoom out to 90%, then it fits, but if I launch a browser windows and go to my server, initially the desktop will be cut off vertically and horizontally. I've tested on Firefox as well.  You will see in my screenshot posted below the scroll bars on the x and y axis...they are always there unless i go into full screen, our zoom the browser viewing area to less than 90%. You'll see the bars when the browser in "maximised" and scaled:
See screen shots:
http://imgur.com/0WeLgXs
http://imgur.com/SSJzNAD
I'm testing without using Muximux, so It's not that.

Thanks for the screenshots.
I will investigate that. Maybe I should substract the scrollbars width from the browser size before sending it to the gateway.
I keep you updated.

@cedrozor , Yup, I think that's it.


[BREAKING CHANGE] DefaultLabel shouldn't be shown by default

Hi,
After updating my app to use the actual commit of the package (#75e9242 in the meantime you update the npm package), my customised slider showed two unexpected "floating labels" above the markers, which never were there:
Before:

·
After:

This is definitely a breaking change and it should be documented accordingly, but I think ideal scenario would be just not showing the Label component by default plus the actual option to have it custom via customLabel prop:
showLabels: false,
customLabel: DefaultLabel,

and then in the render:
{showLabels && (
  <Label
     leftDiff={leftDiff}
    oneMarkerValue={this.state.valueOne}
    twoMarkerValue={this.state.valueTwo}
    oneMarkerLeftPosition={positionOne}
    twoMarkerLeftPosition={positionTwo}
    oneMarkerPressed={this.state.onePressed}
    twoMarkerPressed={this.state.twoPressed}
    />
}

So in the meantime, if someone has this same issue, the solution to hide the floating labels is  passing an empty <View /> as the customLabel
<MultiSlider
  customLabel={() => <View />}
>

Please confirm if you agree with this and I can create the PR to fix this before you release the npm module because it will break every app that uses this package.

Yes!
I've already created a commit for this locally,
A new prop called enableLabel.
Will commit this before making a real release, discovered it as well! Thanks for pointing out!


.libspec generated incorrect line info for keyword definition if keyword using nested decorator

I had reported this issue on robotframework-lsp , and the author suggested me to raise an issue here.
https://github.com/robocorp/robotframework-lsp/issues/424#issuecomment-921662166

the language server is mostly a consumer of the .libspec which is generated by robot.libdoc from Robot Framework itself. The .libspec contains the filename/line for each definition, so, the fix here so that the correct filename/line is collected is something that needs to be done in Robot Framework itself.

Issue Description
I has an issue at Go To Definition ..
This is my special case, but I want to ask if Go To Definition works with decorators?
I had modified robotkeyword for my own purpose
def keyword(name=None, tags=(), types=()):

    def _method_wrapper(func):

        def _passargs(self, *args, **kwargs):    <<--  Go To Definition always stuck here
            .. some codes ..
            return func(self, *args, **kwargs)

        _passargs.robot_name = name
        _passargs.robot_tags = tags
        _passargs.robot_types = types

        return pass_argument

    return _method_wrapper

With this change, the Go To Definition always go to the def _passargs .. line instead of real function location.
Is there any chance I can have Go To Definition works fine with this decorators?

Have you tested using functools.wraps?

@pekkaklarck thanks for the hint!
I did try the functools.wraps but it still got the wrong source file location (func.__code__.co_filename).
from functools import wraps

def keyword(name=None, tags=(), types=()):

    def _method_wrapper(func):

        @wraps(func)               <---- with this, the source file still stuck at keyword file.
        def _passargs(self, *args, **kwargs):
            .. some codes ..
            return func(self, *args, **kwargs)

        _passargs.robot_name = name
        _passargs.robot_tags = tags
        _passargs.robot_types = types

        return pass_argument

    return _method_wrapper

After read lots of articles, I realized that functools.wraps won't preserve all the attributes of functions.
Then I use inspect.unwrap to preserve all the attributes before adding more attributes to the func. And it works!!!
import inspect
def keyword(name=None, tags=(), types=()):

    def _method_wrapper(func):

        def _passargs(self, *args, **kwargs):
            .. some codes ..
            return func(self, *args, **kwargs)

        _passargs = inspect.unwrap(func)
        _passargs.__signature__ = inspect.signature(func)
        _passargs.robot_name = name
        _passargs.robot_tags = tags
        _passargs.robot_types = types

        return pass_argument

    return _method_wrapper

Documented this here to help ppl like me who modified the keyword decorator.


[WIP] Setup and structural improvements

This PR is a collection of code improvements related to the setup and organization of the repository. @Slowblitz Feel free to add further improvements :)

I still think that this set of changes would be good to merge at some point as this PR includes

simplification of the version handling
moving tools into the ando package
cleanup of requirements

@SylvainTakerkart What do you think?

yes, I agree! is this ready to be reviewed?

Let me rebase first and see if stuff broke in the meantime ;)

Stuff broke and is fixed again. @SylvainTakerkart feel free to comment.

Pull Request Test Coverage Report for Build 679541355

0 of 210 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-54.8%) to 32.297%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ando/tools/generator/tests/test_AnDOGenerator.py
0
102
0.0%

ando/tools/generator/AnDOGenerator.py
0
108
0.0%

Totals

Change from base Build 679134658:
-54.8%

Covered Lines:
135

Relevant Lines:
418

💛  - Coveralls


Precendence issue with (++)?

If I execute these statements from a single jupyter cell, I get an error:
  switch (s) {
  | Some(X) => "X"
  | Some(O) => "O"
  | None => " "
  };

[@program] let doc_of_grid = (g: grid) => {
  let f = doc_of_square_state;
  Document.s(
    "\n"
    ++ f(g.a)
    ++ "|"
    ++ f(g.b)
    ++ "|"
    ++ f(g.c)
    ++ "\n"
    ++ "-----"
    ++ "\n"
    ++ f(g.d)
    ++ "|"
    ++ f(g.e)
    ++ "|"
    ++ f(g.f)
    ++ "\n"
    ++ "-----"
    ++ "\n"
    ++ f(g.g)
    ++ "|"
    ++ f(g.h)
    ++ "|"
    ++ f(g.i)
  );
};```

```val doc_of_square_state : square_state -> string = <fun>
File "jupyter cell 33", line 11, characters 4-8:
Error: This expression has type string but an expression was expected of type
         ('a -> 'b) ref```

But if I split the statements into two individual cells, and evaluate them separately they work fine.

Rewriting as ```
let doc_of_square_state = (s: square_state) =>
  switch (s) {
  | Some(X) => "X"
  | Some(O) => "O"
  | None => " "
  };

[@program] let doc_of_grid = (g: grid) => {
  let f = doc_of_square_state;
  Document.(Printf.sprintf("\n%s|%s|%s\n-----\n%s|%s|%s\n-----\n%s|%s|%s", f(g.a), f(g.b), f(g.c), f(g.d), f(g.e), f(g.f), f(g.g), f(g.h), f(g.i)));
};

works ok, so I'm wondering if it's something to do with (++)?

Ah yep, here's a more minimal repro:

"hello " ++ "there";```


#61 Fix unexpected indent error

Hi
I fix the problem and also sign  Contributor License Agreement (CLA)

You have deleted README.md by the way, please revert it.

Thanks for pointing out this problem. The fix was submitted with #64 .


Request support for nybro_heater

name: NYBRO heater
products:

id: ahzyjjcfbe1ehrbt
primary_entity:
entity: climate
dps:

id: 1
type: boolean
name: hvac_mode
mapping:

dps_val: false
value: "off"
dps_val: true
value: "heat"

id: 2
name: temperature
type: integer
range:
min: 5
max: 35
id: 3
name: current_temperature
type: integer
id: 4
type: string
name: preset_mode
mapping:

dps_val: low
value: eco
dps_val: high
value: boost
dps_val: af
value: away

id: 12
type: bitfield
name: error
mapping:

dps_val: 0
value: "OK"
secondary_entities:

entity: binary_sensor
name: Heating
category: diagnostic
dps:

id: 101
type: boolean
name: sensor
mapping:

dps_val: on
value: true
icon: "mdi:radiator"
dps_val: off
value: false
icon: "mdi:radiator-disabled"

I have added this device locally to my tuya_local config and tested it since February without any issue.


Hugo doesn't build locally on re-install: Building sites … WARN (date) found no layout file for "HTML" for kind "page"

What version of Hugo are you using (hugo version)?
Hugo Static Site Generator v0.74.3/extended linux/amd64 BuildDate: 2020-07-29T18:11:24Z
I cloned the repo my site lives at on a new machine, and now hugo doesn't build locally. The site is building remotely, however.
When I run hugo locally, I get the following:
$ hugo
Building sites … WARN 2021/04/16 12:17:50 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2021/04/16 12:17:50 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2021/04/16 12:17:50 found no layout file for "HTML" for kind "term": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
... (a bunch more lines like this)

Have I failed to download some package on re-install of hugo?

the theme is git submodule, make sure use –recurse-submodules flag when clone the repo.
or manually init and update submodule after git clone
git submodule init
git submodule update

thanks!

the theme is git submodule, make sure use --recurse-submodules flag when clone the repo.
or manually init and update submodule after git clone
git submodule init
git submodule update


Move save/restore of "show pictures" button state into MessageTopView

This is an attempt to fix #2685.
Saving/restoring the visibility state of the "show pictures" button in MessageContainerView did not work, since restoring happens long before this object is created. This change moves it into MessageTopView.
As a side-effect, if the button was clicked before the save/restore cycle, and thus the network data in the MessageWebView was unblocked, it will now also be unblocked in the new MessageWebView after restoring, like for example after an orientation change. Previously, network data was always initially blocked in MessageWebView (depending just on the setting of "Always show images") until "show pictures" was clicked.

Testing this in combination with PR #2721 led to the last two commits. The first of them is to really unblock network data on restore, if the button was clicked before the save/restore cycle.


Fixed downloadable product issue #5663

Issue Reference
Fixed issue of downloadable product #5663

the issue is fixed -> If the user orders a product with 2 quantities and an invoice is generated only of 1 quantity in that case the remaining downloads should be shown accordingly.
Here is the PR - https://github.com/bagisto/bagisto/pull/5675
So, I m closing this PR


fix(docs): update StyleProperties link and introduction.md

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have added tests (if possible).
[x] I have updated the documentation accordingly.

@BobbieGoede please


Add a notes field

Add a notes field to transfers and/or transactions that does not get uploaded to AE, but may provide more info in Sloth?

@jSylvestre we do have the "Description" field, which is currently unused, or at least very rarely used.

We use it a lot, but I don't think AE has a place for it.
Description = $"Funds Distribution INV {invoice.GetFormattedId()}".SafeTruncate(40)
I don't think we upload this to AE, so we can just keep using it.


catch IOError from socket.sendall

SocketDisconnectedError is a custom exception type to pykafka and thus can never be raised from a call to _socket.sendall. This commit attempts to fix #637 by catching the IOError that can actually come from sendall().
This commit seems to have not actually done anything.

Duplicate of #638


New commit in this repo since pulled to pypi.org

Hello,
I've been trying to use JWTStatelessUserAuthentication as shown in docs and notice it's not present in the authentication.py file installed with djangorestframework-simplejwt 5.1.0.
I notice there was a commit here 18 days ago, and the package on pypi.org is dated March 1, 2020, so the github repo and pypi.org are out of sync.
How can this be resolved?
Thanks,
Paul Sanders

Sorry, for some reason our docs don't update by version, so you're seeing the latest version of our doc. This can be resolved by using the backwards compatible name JWTTokenUserAuthentication. In the future, this name won't be removed so no worries about future updates. https://github.com/jazzband/djangorestframework-simplejwt/blob/3fc9110c7d0e5641b6eccb6dca321f44189bba01/rest_framework_simplejwt/authentication.py#L148

Thanks. I saw that, and have changed the class name in my code, but it's good to know that name won't be removed.


add menu & add ability to remove all dates

add ConfirmButton common component
minor style adjustments
add button to delete all dates
adjust button styling
group actions into menu & restyle add date button
extract day actions into separate component
fix menu popover
bug in lib?
extract query dates hook
group day components
adjust menu styling
fixes DEV-148

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5  👈
#4
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szamanr and the rest of your teammates on  Graphite

Merge activity

Apr 9, 4:13 PM GMT+2: @szamanr started a stack merge that includes this pull request via Graphite.


Quantize the models using GPTQ and Upload in 4-bit precision format to Huggingface

[ ] GPTJ
[ ] BLOOM
[ ] GPT-NeoX
[ ] Pythia Series
[ ] Open-Assistant
[ ] Codegen
[ ] OPT & Galactica
...

Per Int-4 LLaMa is not enough - Int-3 and beyond binning with a bin size of 128 appears to reduce most of the remaining output quality loss of GPTQ for models larger than ~10B while only negligably effecting the memory requirrement.

Thanks for the suggestion @MarkSchmidty . I am opening a separate issue (#12) as this will require new C/CPP kernels to be added as well.
In short Int-4 LLaMa is not enough study assumed that only weight was being quantized, not intermediate representations. We need to either add new kernels or do another study of the performance drop.


WebView2 should cache input state

This change undoes part of #7555.
We can't rely on PointerUpdateKind, because WinRT does not pass all relevant events, and we don't have balanced Pressed/Released button presses. We should ensure that events are balanced by keeping track of what button was pressed, and send that message to Core WebView2.

/azp run


make sure outputs are always valid

Outputs directly referencing resource IDs that are only conditionally
created are not valid. Use the concat * trick to make sure we always
have a valid value for these outputs.

Thanks for making this repo forward compatible!

Thanks! We were running into this problem Monday, when compiling terraform from master. Had set it aside until today to troubleshoot, and now it's fixed! 😁 👍


Sentry should be disabled on non-production build environments

@cswimr make sure you use closing keywords in the future


ValueError: zero-size array to reduction operation maximum which has no identity

import fix_yahoo_finance as yf
data = yf.download("TATAMOTORS", start="2019-03-29", end="2019-04-12")
print(data)
This simple program gives me an error.
Provide the solution as soon as possible
o/p:
[                       0%                       ]
[100%**]  1 of 1 downloaded
Traceback (most recent call last):
File "C:\Users\Sachin\Desktop\dara.py", line 3, in
data = yf.download("TATAMOTORS", start="2019-03-29", end="2019-04-12")
File "C:\Program Files\Python37\lib\site-packages\fix_yahoo_finance_init_.py", line 202, in download
'Close', 'Adj Close', 'Volume']]
File "C:\Program Files\Python37\lib\site-packages\pandas\core\frame.py", line 2934, in getitem
raise_missing=True)
File "C:\Program Files\Python37\lib\site-packages\pandas\core\indexing.py", line 1354, in _convert_to_indexer
return self._get_listlike_indexer(obj, axis, **kwargs)[1]
File "C:\Program Files\Python37\lib\site-packages\pandas\core\indexing.py", line 1142, in _get_listlike_indexer
kind=self.name)
File "C:\Program Files\Python37\lib\site-packages\pandas\core\indexes\multi.py", line 2127, in _convert_listlike_indexer
_, indexer = self.reindex(keyarr, level=level)
File "C:\Program Files\Python37\lib\site-packages\pandas\core\indexes\multi.py", line 2216, in reindex
keep_order=False)
File "C:\Program Files\Python37\lib\site-packages\pandas\core\indexes\base.py", line 3512, in _join_level
ngroups = 1 + new_lev_codes.max()
File "C:\Program Files\Python37\lib\site-packages\numpy\core_methods.py", line 28, in _amax
return umr_maximum(a, axis, None, out, keepdims, initial)
ValueError: zero-size array to reduction operation maximum which has no identity

Experiencing similar problem with recent versions of pandas. Which version of pandas and pandas_datareader are you using?

I'm using pandas with 0.24.2 and pandas_datareader with 0.7.0.
Tell me than the version which is used for fetching data.

I'm facing with same problem.
It was working before. Might be because of yahoo servers.


Expose components and showChangelogModal

Not sure how to document the components.

Doesn't need to be anything fancy, does it? Just the same as the rest of the api docs? A preview would be nice, but that also seems like it'd be a bit of double handling if the docs aren't going to be moved to the main repo

This has been superseded by #1785


Feature doc api

please review

This branch contains old files which replace new ones. It cannot be merged with dev.
PLEASE CHECK your branches and keep them updated.


MAXO:0035119	duplex ultrasound with color flow imaging

MAXO:0035119	duplex ultrasound with color flow imaging
Def: A form of Doppler ultrasound examination that examines blood vessels and blood flow.

added via template. https://docs.google.com/spreadsheets/d/1ZKk3cFQNYAXsNWbpI-ScaIm3OHx2Jtpco3Y1aNX7gZM/edit#gid=0


Crawler.crawl_remote returns incorrect results if index is redirected

The PyPI-compatible server devpi will issue redirects to the lowercased package page if an uppercased package name (e.g. Django) is searched. For example, if the index URL is https://HOST/wyatt/test/+simple/ (with or without trailing slash), pex will query https://HOST/wyatt/test/+simple/Django/ to install requirement Django==1.6.5. devpi will redirect to https://HOST/wyatt/test/+simple/django (without a trailing slash) and the crawler crawls URLs on the index page (presumably because requests follows the redirect), the links in which are relative to the URL without the trailing slash (i.e. are one level shallower with respect to leading .. segments).
In pex.crawler.Crawler.crawl_remote, the links are joined to the original URL and the link object's URL isn't updated to reflect the new canonical URL of the page. This results in incorrect resolution of the relative URLs on the index since the trailing slash is missing.
Pip itself doesn't have this issue with devpi.
Anyway, I think we can work around this on our end by slapping on a trailing slash with NGINX, but I think for the sake of correctness this should be updated in Pex itself. Happy to work on a patch if this is a valid issue.
The pex version this happens in is 1.1.2.

@wyattanderson seems like a valid issue to me. I've heard of at least a couple of instances where folks have gotten hung up on pex + trailing slashes at the end of URLs (e.g. in pants [python-repos] repos configs), so if you see opportunities here to streamline more of the general url handling code - or just want to address this particular issue - go for it!


Mention that Object Rest sometimes also need transform-es2015-parameters

When this page says:

Even if you are using Node 6 or a platform that supports destructuring, transform-es2015-destructuring will currently need to be enabled if using object rest properties.

This is true if you use object rest only with normal variables. But if you try directly with function parameters, it will not transform.
// Will work with transform-es2015-destructuring
let { x, y, ...z } = { x: 1, y: 2, a: 3, b: 4 };

// Won't transform! Needs transform-es2015-parameters + transform-es2015-destructuring.
function foo({ x, y, ...z }) {}

I guess it's a good idea document that case.
Sorry I'm not sending a straight PR… I still have doubts about my English. 😿

If you want to send a PR mentioning transform-es2015-parameters, that'd be great :) Your English is great 👍

Added in https://github.com/babel/babel.github.io/commit/27a010a0efd0be1977e0e2ebe7d3d93e139cc5b0


Bump latest version

Please also refer to the related issue before we submit any Pull Request.
I'll merge it after we have it.

Related issue: https://github.com/wechaty/wechaty-puppet/issues/74


Uploading when not logged in correctly?

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
When running snapshot then frameit then uploading screenshots, I get the follow error...
Complete output when running fastlane, including the stack trace and command used

security: SecKeychainAddInternetPassword : The user name or passphrase you entered is not correct.
Could not store password in keychain
[19:58:33]: Login successful
+--------------------------------------+---------------------------------------------+
|                              deliver 2.107.0 Summary                               |
+--------------------------------------+---------------------------------------------+
| skip_binary_upload                   | true                                        |
| skip_metadata                        | true                                        |
| screenshots_path                     | /Users/jm/Dropbox/Code_ObjC/screenshots/sfc |
| metadata_path                        | ./fastlane/metadata                         |
| platform                             | ios                                         |
| edit_live                            | false                                       |
| use_live_version                     | false                                       |
| skip_screenshots                     | false                                       |
| skip_app_version_update              | false                                       |
| force                                | false                                       |
| overwrite_screenshots                | false                                       |
| submit_for_review                    | false                                       |
| reject_if_possible                   | false                                       |
| automatic_release                    | false                                       |
| phased_release                       | false                                       |
| run_precheck_before_submit           | true                                        |
| precheck_default_rule_level          | warn                                        |
| ignore_language_directory_validation | false                                       |
| precheck_include_in_app_purchases    | true                                        |
+--------------------------------------+---------------------------------------------+
[19:58:35]: Framed screenshots are detected! 🖼 Non-framed screenshot files may be skipped. 🏃
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Air-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Air-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Air-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Air-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (12.9-inch)-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (12.9-inch)-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (12.9-inch)-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (12.9-inch)-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (9.7-inch)-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (9.7-inch)-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (9.7-inch)-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPad Pro (9.7-inch)-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 5s-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 5s-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 5s-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 5s-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8 Plus-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8 Plus-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8 Plus-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8 Plus-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone 8-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone SE-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone SE-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone SE-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone SE-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone X-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone X-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone X-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-GB/iPhone X-sad.png
[19:58:35]: Framed screenshots are detected! 🖼 Non-framed screenshot files may be skipped. 🏃
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Air-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Air-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Air-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Air-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (12.9-inch)-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (12.9-inch)-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (12.9-inch)-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (12.9-inch)-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (9.7-inch)-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (9.7-inch)-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (9.7-inch)-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPad Pro (9.7-inch)-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 5s-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 5s-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 5s-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 5s-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8 Plus-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8 Plus-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8 Plus-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8 Plus-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone 8-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone SE-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone SE-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone SE-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone SE-sad.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone X-happy.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone X-happycalendar.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone X-main.png
[19:58:35]: 🏃 Skipping screenshot file: /Users/jm/Dropbox/Code_ObjC/Screenshots/sfc/en-US/iPhone X-sad.png
[19:58:39]: #<ArgumentError: different prefix: "/" and "fastlane">
[19:58:39]: /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/pathname.rb:520:in relative_path_from' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/html_generator.rb:38:in render_relative_path'
(erb):240:in block (3 levels) in render' (erb):239:in each'
(erb):239:in each_with_index' (erb):239:in block (2 levels) in render'
(erb):233:in each' (erb):233:in block in render'
(erb):157:in each' (erb):157:in render'
/usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/erb.rb:896:in eval' /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/erb.rb:896:in result'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/html_generator.rb:56:in render' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/html_generator.rb:13:in run'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/runner.rb:180:in validate_html' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/runner.rb:117:in upload_metadata'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/deliver/lib/deliver/runner.rb:38:in run' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/actions/upload_to_app_store.rb:16:in run'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:253:in block (2 levels) in execute_action' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in execute_action'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:232:in block in execute_action' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:227:in chdir'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:227:in execute_action' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:157:in trigger_action_by_name'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/fast_file.rb:149:in method_missing' Fastfile:34:in block (2 levels) in parsing_binding'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/lane.rb:33:in call' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:49:in block in execute'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:45:in chdir' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/runner.rb:45:in execute'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/lane_manager.rb:56:in cruise_lane' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/command_line_handler.rb:36:in handle'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/commands_generator.rb:108:in block (2 levels) in run' /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call'
/usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run' /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!' /usr/local/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/commands_generator.rb:333:in run' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/commands_generator.rb:41:in start'
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/fastlane/lib/fastlane/cli_tools_distributor.rb:108:in take_off' /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.107.0/bin/fastlane:23:in <top (required)>'
/usr/local/bin/fastlane:23:in load' /usr/local/bin/fastlane:23:in '
[19:58:39]: Could not render HTML preview. Do you still want to continue?
n
[19:59:00]: Starting with the upload of screenshots...
[✔] Activating languages en-GB, en-US...

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.6

Ruby
2.4.1

Bundler?
false

Git
git version 2.10.1

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.13.6 (17G65)

Ruby Lib Dir
/usr/local/Cellar/ruby/2.4.1_1/lib

OpenSSL Version
OpenSSL 1.0.2l  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode10.app/Contents/Developer/

Xcode Version
10.0

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

before_all do
	ENV["SLACK_URL"] = "https://hooks.slack.com/services/snip" # Webhook 	URL created in Slack
end

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do

    capture_screenshots(
    	workspace: "Sad Face Chart.xcworkspace",
    	scheme: ENV['SCHEME'],
    	output_directory: ENV['SCREENSHOT_PATH'])

    frame_screenshots(white: true, path: ENV['SCREENSHOT_PATH'])

    upload_to_app_store(
    	skip_binary_upload: true,
    	skip_metadata: true,
    	screenshots_path: ENV['SCREENSHOT_PATH'],
    	app_identifier: ENV['BUNDLE_ID'])

    slack(
      message: "Screenshots finished.",
      success: true,
     )

  end
end

`./fastlane/Appfile`
app_identifier(ENV['BUNDLE_ID']) # The bundle identifier of your app

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.107.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.1.0

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.0

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.6.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
1.8.0

unicode-display_width
1.4.0

terminal-table
1.8.0

plist
3.4.0

addressable
2.5.2

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.6.5

tty-cursor
0.6.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.62.0

domain_name
0.5.99999999

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

gh_inspector
1.1.3

mini_magick
4.5.1

multi_json
1.13.1

multi_xml
0.6.0

rubyzip
1.2.2

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.5.0

faraday_middleware
0.12.2

naturally
2.2.0

simctl
1.6.5

emoji_regex
0.1.1

faraday
0.15.3

fastimage
2.1.4

json
2.1.0

bundler
1.16.4

httpclient
2.8.3

jwt
2.1.0

signet
0.10.0

os
1.0.0

memoist
0.16.0

googleauth
0.6.6

mime-types-data
3.2018.0812

mime-types
3.2.2

retriable
3.1.2

declarative-option
0.1.0

declarative
0.0.10

uber
0.1.0

representable
3.0.4

google-api-client
0.23.9

openssl
2.1.1

io-console
0.4.6

generated on: 2018-10-17

Hi @Jules2010, did I understand correctly from your output that you mistyped your Keychain password, which caused the password not being saved in the keychain and then later you get this unrelated error? Or what exactly are the steps to reproduce this?

Possibly duplicate of https://github.com/fastlane/fastlane/issues/13512


bug: Things the placement controller does not do (right)

Describe the bug
In reviewing #1669 I noticed the following problems with the placement controller. Caution: this is based on reviewing the textual description, not the actual code.

An update to a workload object that removes some Placements from the matching set is not handled correctly.
If a workload object is deleted, or changed to remove some Placements from the matching set, while the controller is down this will not be handled correctly.
A Placement update that (a) removes workload objects or clusters from their respective matching sets and (b) happens while the controller is not running, is not handled correctly.
A cluster update that (a) removes Placements from its matching set and (b) happens while the controller is not running, is not handled correctly.
An update to the labels of a Namespace object does not trigger reconsideration of the workload objects in that namespace (even though matching can depend on Namespace labels --- this one is my bad, introduced in #1525).
The placement controller does not react to add/change/delete of clusters.
Nothing ensures that only one worker is working on a given ManifestWork at a time. This is a problem because different concurrent workers are not guaranteed to all be working with the same version of all the relevant objects, so there is no guarantee about what the outcome will be. This controller is full of dead reckoning about what it did in the past, rather than getting that information from the ManifestWork objects themselves.

Steps To Reproduce
Read #1669
Expected Behavior
A design that works in the presence of concurrent activity with failures and retries.
Additional Context
No response

@MikeSpreitzer excellent points.
I think it's important to add test cases that cover all these points.
can you add or reference this issue in #1655?

I opened an issue #1682 and assigned to @ezrasilvera.
After introducing this fix, point (5) should be solved.

@MikeSpreitzer if you agree that 4,5,6 are covered by the linked issues, feel free to remove them from the list in this issue.

@ezrasilvera : since we have taken to referring to the OP's items by number, I am loathe to change the numbers. It looks like we have started on the path of enhancing each item with a reference to the issue that covers it, when there is such an issue.

@ezrasilvera : since we have taken to referring to the OP's items by number, I am loathe to change the numbers. It looks like we have started on the path of enhancing each item with a reference to the issue that covers it, when there is such an issue.

Sounds OK to me.  I like to have focused issues with 1-2 PRs that cover them, rather then a large general issue with many unrelated issues.

Closing this in favor of the various smaller issues now referenced in the (edited) OP.


Floating view ordering not working

Floating views aren't being arranged properly on click(the clicked view should come to the front). Currently nothing happens on click. In addition, all floating views which aren't in the front have mouse motion and mouse clicking ignored.

first part should be fixed, but i wasnt having the mouse motion/mouse click ignored problem.

I'll check again.

The mouse motion/click ignoring was a side effect I think, but there's still an issue. When you drag a floating view which is not at the front, it isn't moved to the front, i.e. you move/resize the floating view, but it still stays behind the other ones.

that should do it. just a bit of reordering.

Fixed.


Storybook >Components>Top Navigation With Search>Small & large mobile view language pop up is not display proper.

Describe the bug
Small & large mobile view language pop up is not display proper.
Search box border issue.
Steps to reproduce bug
1.Go to 'https://react.raaghu.ai/'
2. Components>Top Navigation With Search>Default
3. Click on small mobile and verify language pop up is not display proper.
4. Click on large mobile and verify language pop up is not display proper.
Actual result-
Small & large mobile view language pop up is not display proper.
Screenshots

Expected result-
Small & large mobile view display language popup clear .
Desktop (please complete the following information):
-OS: [Windows 10 Enterprise]
-Browser [ edge]
-Version [ 125.0.2535.92]

Completed -


Attempting to watch missing directory: node_modules/progressbar.js

Build error
Error: Attempting to watch missing directory: node_modules/progressbar.js

This error is caused by this code:
return new Funnel('node_modules/progressbar.js', {
    destDir: 'progressbar.js'
});

Installing progressbar.js in my own project solved this problem for now, but I consider this should be fixed in the addon.

Thanks for catching that! The issue should be resolved by https://github.com/null-null-null/ember-progress-bar/commit/425b3507c392765947c16ff05a805f07f6657685. If you upgrade to v0.0.4, you'll see it working.


Noble stops getting characteristic updates after 30 seconds

Hi Sandeep --
I've run into an issue with Noble on Ubuntu 14.04. After about 30 seconds I can no longer read values or receive notification of value changes (without any obvious error being reported).
Initially I was working with a characteristic that used notify - after 30 seconds I would stop getting new notifications. No such issue occurred if, instead of using Noble, I monitored the characteristic with the Nordic nRF Master Control Panel app on my Android phone.
I then switched to a setup where instead of notifications I just explicitly tried to read the characteristic every second (triggered by a standard node timer) and again the callback that I was passing to the characteristic's read(...) method simply stopped getting called back after things had been running for 30 seconds.
Initially I thought things were stopping working after 30 events (as my remote side was pushing out changes every second) - but it definitely seems to be 30 seconds - if I reduced the duration on my node timer from 1s to 500ms I could read the characteristic 60 times before silence kicked in.
Initially I was using an older version of noble that was still using l2cap-ble.c and I did some debugging with that - after 30 seconds the select call (with its 1s timeout) would just continuously timeout with a result of 0, i.e. there were no obvious errors it just looked like nothing more was coming in on l2capSock.
I then upgraded to Noble 1.2.1 which uses bluetooth-hci-socket - I see the underlying native code has gone through a dramatic update in the process. I haven't tried debugging this yet but I experience the same behavior.
Have you any ideas?

Well that's a coincidence, I just created a issue with exactly the same problem: #268
Also using a Nordic NRF chip as peripheral.

@PimButton - that is a strange coincidence :smile:
If I Google I do find a couple of references (but not the original specification) that point out that the LMP response timeout should be 30 seconds - so that in itself is interesting:

These posts of the TI forum and the FreeBSD list.
The LMP section of the book "Bluetooth 1.1: Connect Without Cables".

It's also covered e.g. here in the Link Manager section of the book "The Handbook of PAN Technologies and Protocols".
Where do you see the message "LMP Response Timeout"? I'm using hcidump to monitor things but don't see anything unusual:
$ hcidump -X
...
> HCI Event: Command Status (0x0f) plen 4
    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

I see the last event shown above, i.e. "Create Connection", as the connection is established and I don't see anything after that, i.e. I don't see anything bad being logged at the 30 second boundary.
I can actually monitor both ends, i.e. the Noble node code running on my Linux box and the nrf51822 (a RedBear BLE Nano) - as I have a serial link open to the BLE Nano.
The BLE Nano is running arduino-BLEPeripheral, another project from Sandeep, and I do not see it reporting any issue at the 30 second boundary, i.e. as far as it's concerned there's no issue. And it does notice the disconnect initiated from my Noble logic long after the 30 seconds are up.
I.e. I can run my Noble logic for e.g. 60 seconds - after 30 seconds it stops being able to read any characteristic - but this does not seem to mean that the connection has been lost at this point - only when I explicitly disconnect in my Noble logic at the end of the 60 seconds (or whatever) does the nrf51822 fire its BLEDisconnected event, i.e. the link must still exist at this point (and not simply have been disconnected at some lower level) for the disconnect on the Noble side and the event on the nrf51822 to line up.
As I said in my initial comment everything also looks good in the Noble native logic, i.e. it's not any obvious error at this level that's stopping data being read - from the point of view of the AF_BLUETOOTH socket everything looks fine but it just stops getting further data after the 30 seconds are up.
So I am not seeing anything like "LMP Response Timeout", i.e. something that shouts that there's a problem (other than the obvious lack of received data).
I have the more detailed data output from hcidump -w hcidump.out but Github won't allow me attach anything other than text files, images, PDFs and Microsoft Office files :disappointed:

@george-hawkins I'm not using the RedBear BLE Nano, I have designed a custom board around the nrf51822 and am using Nordic's soft devices to program the chip directly.
In my case the connection does get disconnected after the 30 seconds, Nordic's on_ble_evt function is called and a BLE_GAP_EVT_DISCONNECTED event is being passed. This event carries a reason for the disconnect which in my case is 0x22. This corresponds to the LMP Response Timeout according to Nordic's documentation: https://devzone.nordicsemi.com/documentation/nrf51/5.2.0/html/a01162.html#ga91c40ef8a7c61f6a3a036eac70956491
I haven't done a lot of logging in my Noble Logic but as far as I can see do Noble and the NRF51822 both agree on the disconnect. I.E. the status of the peripheral in Noble changes to disconnected. If I reconnect the cycle starts again, Noble and the NRF both respond well, but only between the first 30 seconds.
Since @sandeepmistry has written the arduino-BLEPeripheral he must have some experience with the NRF so I hope he can shed some light on the issue. If you want to attach other files, I can recommend PasteBin to paste larger outputs :)

Cool now I'm getting somewhere - I was thinking that our problems were weirdly similar but unconnected as I was seeing no obvious errors at any point.
But I enabled the NRF_51822_DEBUG macro in Sandeep's arduino-BLEPeripheral logic and now I can see that at the 30 second boundary it's hitting the default event case at nRF51822.cpp:807.
I.e. it's getting an event it hasn't been coded to handle. And what is that event? The serial output is:
bleEvt->header.evt_id = 0x39 13

And if I look in ble_gattc.h I can work out that 0x39 is BLE_GATTC_EVT_TIMEOUT.
So I added in the following to see if it would reveal any more information:
  case BLE_GATTC_EVT_TIMEOUT:
      Serial.println(bleEvt->evt.gattc_evt.gatt_status, HEX);
      Serial.println(bleEvt->evt.gattc_evt.error_handle, HEX);
      Serial.println(bleEvt->evt.gattc_evt.params.timeout.src, HEX);
      break;

However all I got was:
status: 0x01
handle: 0x00
src: 0x00

So now my hopes rest with @sandeepmistry :smile:

@george-hawkins an HCI dump would be great (you can paste the output here, or in pastebin, Github gist etc.): sudo hcidump -t -x
Also, what kernel version, BlueZ version and BLE adapter are you using?

@sandeepmistry - thanks as always for your prompt follow ups :smile:
I've put together lots of details in a gist.
I've included output comparing the events my nNRF51822 receives when interacting with Noble and when doing much the same thing using the nRF Master Control Panel.
I've also included version information for my Bluetooth related modules etc. and details about my Bluetooth device, along with hcidump and strace output.
The thing that surprises me most in what I captured is the lack of discovery events for the Noble setup - I've commented on this more in the gist. Maybe characteristics etc. are somehow being cached rather than discovered anew each time?

Not reading the relevant Nordic documentation.
Most importantly, not understanding that the discovery events seen in my nRF51822 console weren't triggered from the Noble side of things, but were responses generated by discovery triggered by the code running on the nRF51822.

I've cleaned up the gist to reflect this - but the important thing is that the nrf51822, on every connection, tries to discover the primary services of the GATT server on the central. See nRF51822.cpp:449:
sd_ble_gattc_primary_services_discover(this->_connectionHandle, 1, NULL);

When the central is my phone (running nRF Master Control Panel) everything works fine and we get a BLE_GATTC_EVT_PRIM_SRVC_DISC_RSP response to our request - this is handled and the code then tries to discover further services and so gets a further BLE_GATTC_EVT_PRIM_SRVC_DISC_RSP telling us there are no more services to be discovered.
When the central is my Ubuntu box running a Noble application this phase fails - we get no response so the discovery times out after 30 seconds and as per the spec "No more attribute protocol requests, commands, indications or notifications shall be sent to the target device on this ATT Bearer."
So apparently my Ubuntu box is expected to be running a GATT server but isn't.
If I comment out the above discovery call in the library logic then everything works fine. I.e. I get no timeout and reads and writes between the two sides proceed without problem past the 30 second  boundary.
This doesn't help @PimButton so much as I don't think he can change the behavior of his peripheral. So the real solution is to find out why my Ubuntu box (and in @PimButton's case his Windows box) isn't running a GATT server (assuming we have the same problem) when it should.
Note: even after I comment out the discovery logic there's still another difference between what's seen when the central is on Android and when it's on Ubuntu - I only see the BLE_GATTS_EVT_SYS_ATTR_MISSING event in the Ubuntu case. I haven't been able to find out much about what this really means. The message sequence is covered here and I can see that @sandeepmistry's code is responding in the right way - but I can't find why the Ubuntu setup would be sending this message and the Android setup not.

Who should be supplying the GATT server? It you're using BlueZ 5.X then it does provide a GATT server - however I killed this in the past as it and Bleno can't work together - see this old comment from Sandeep - has this situation changed?
Anyhow most Ubuntu users will not have the 5.X BlueZ user space stuff - for whatever reason the kernel side of things has been up-to-date since forever but the user space stuff was only changed to 5.X with Wily Werewolf, i.e. the October 2015 release (see this search result for the user space BlueZ version number for each Ubuntu release). It won't be until April 2016 that the first LTS release has it.
So I'm pretty sure the 4.X user space stuff wouldn't include a GATT server?
Out of curiosity I did a little checking as to what actually was discovered by sd_ble_gattc_primary_services_discovered(...) when my Android phone is acting as the central device. Surprise surprise - it was the two services:

Generic Access (0x1800)
Generic Attribute (0x1801)

I've submitted an arduino-BLEPeripheral pull request that fixes the situation in my case where I control both sides.
But from @PimButton's experience it sounds like many or at least some other peripheral devices may have similar issues. So is there an obvious fix if you've got the default, i.e. 4.X, BlueZ user space tools on Ubuntu? And on Windows (as @PimButton is) should the default stack be handling providing the GATT server?
Really this doesn't look like a Noble issue anymore - but I'll keep it open for others to comment.

I noticed in gatt.js:83 that any service you advertise with Bleno will include Generic Access and Generic Attribute automatically (as it should).
So I tried mixing Bleno and Noble in one application to see if I could in effect provide a dummy service that might respond to any sd_ble_gattc_primary_services_discovered(...) request while letting the real Noble logic get on with its work.
But Bleno and Noble don't seem to play well at the same time (and I wouldn't be surprised if I'm misunderstanding how a central side GATT server should be brought into the mix anyway).
In fact after running Bleno logic I found I had to reset my Bluetooth dongle (plug it and out) and reset the corresponding device with hciconfig before I could get my Noble logic working again :disappointed:

OK - I'll stop spamming this issue. Last update for today. So Bleno and Noble can work together fine - I had Bleno in advertising mode while I was trying to do things in Noble and this is what (probably fairly obviously) didn't play nice (and it was when I killed my app while Bleno was still advertising that things seemed to get into the hard-to-recover state described where I couldn't use Noble again until I'd zapped my Bluetooth device).
However even after realizing this I still wasn't able to get things into the state I wanted, i.e. get Bleno to somehow provide the missing GATT server that is causing the peripheral's remote service discovery step to timeout (and so halt communication with my real logic, i.e. the Noble logic).

@george-hawkins awesome debugging so far! I would definitely say you are not spamming :)
Did you take a look at these lines?

https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/gatt.js#L87
https://github.com/sandeepmistry/noble/blob/master/lib/hci-socket/gatt.js#L89

The 2nd linked line should probably reply with an ATT error response instead of ignoring, something like: https://github.com/sandeepmistry/bleno/blob/master/lib/hci-socket/gatt.js#L341
In regards to noble + bleno working together, it might be more straightforward if there was a shared singleton for bluetooth-hci-socket. Although it might be fine with the current setup on linux if the connection complete event treats noble requests as a new connection so it can respond to the central. The one gotcha is if noble stops ignoring the requests, and sends an error response, there is no opportunity for bleno to step in ...

OK - I've submitted pull request #277 against Noble.
My previous pull request (#36) against arduino-BLEPeripheral fixed things for me in the case where I was also responsible for the peripheral logic.
This pull request against Noble fixes the situation where you don't have any control over the peripheral and can't prevent it initiating a service discovery request.
This should hopefully work for situations like @PimButton's case.
My writeup for the pull request is way longer than the actual fix which is really just commit 0223525. There's also a followup commit allowing you to turn off this behavior if really required - 287ffff - but I'd guess there isn't so much point in merging this addition.

As I explained in #268, I screwed up reading the disconnect reason. It turned out it wasn't 0x22 (LMP Response Timeout) but LOCAL_HOST_TERMINATED_CONNECTION (0x16). So it seems the NRF51822 I'm using is initiating the disconnect. So far I have not been able to find out why it drops the connection.
However, according to the Nordic Developer Zone:
0x16 means Local Host Closed Connection (the stack terminated because of something, could be a L2Cap connection parameter update timeout or a pairing failure)
Unfortunately the solution provided in #291 did not work for me. The connection still drops after 30-60 seconds. However, I still think the issues are related. Is it possible that my perhiperhal sends a L2CAp connection parameter update that Noble ignores? In that case a timeout is expected, and the scenario is identical to the problem @george-hawkins solved with his commit. I expect the request to be different however, so instead of denying the request it is still timing out.
Does this make any sense to you? I have done some debugging of my own and captured two Wireshark streams: one between BLE Tool on my iPad & the NRF51822 peripheral and one between Noble & the peripheral. With the iPad application no disconnect happens and the connections stays alive. It seems it responds differently to the L2Cap requests but I'm a little out of my depth with this level of debugging and BLE knowledge. I attached the two captures, hopefully @sandeepmistry can take a look and see what is going on. I used the filter btle.data_header.length > 0 to hide the empty packets.
@george-hawkins I hope you don't mind me continuing here, since I think the issues are still related. If you feel like i'm hijacking your issue please let me know and I'll open a separate one.

@PimButton - if you're using my changes from #291 then it shouldn't just ignore a request, no matter what it is.
If you look at the if statement at gatt.js:86 you'll see there are various debug calls for the various paths.
You might want to see if these calls are outputting anything interesting - you can enable this as outlined here - you just need to set the environment variable DEBUG to att, i.e. the value seen when debug is pulled in at the top of gatt.js, and then run your node program as normal.
Beyond that I'm out of ideas :disappointed:

I'm closing this now that PR #291 from @george-hawkins has been merged.
@PimButton please open a new issue for the issue you are seeing, and we can follow up on the discussion there. I tried to open the .pcapng files you provided in Wireshark 2.0.1 for OS X, but the decoder doesn't seem to work. I can post a screenshot in the new issue.


Django/Vue braces added to request method after logout

Cross-post from https://github.com/axios/axios/issues/1994#issuecomment-464779874 that I thought was an axios issue but a user tried it out with a mock backend server and didn't have a problem.  I'm also posting on https://github.com/Tivix/django-rest-auth/ because I'm not sure if it's a simplejwt issue or a rest-auth issue (or maybe even further down into Django/DRF)
I have a basic user management project that I'm using off of which to scaffold other projects. It is a Vue CLI 3 front end and Django/Django REST Framework/Django REST Auth back end. The project I'm posting here uses sqllite but it can relatively easily be converted to another db.
Here is the link to the full repo for anyone who is willing to download to try to replicate my issue: https://github.com/JVP3122/user-project
I'm having a very strange problem in that when I log out of the site and then try to log back in directly from the same page it seems that axios is adding the payload to the beginning of the request method.
For example, in the images found in the post I put up in Imgur (https://imgur.com/a/bEsx662) the user name is simply "test" with the password "password", and when I try to log back in after logging out the subsequent login attempt is no longer a POST route, but instead a {}POST route. If I try again, the route becomes a {"USERNAME":"TEST","PASSWORD":"PASSWORD"}POST method.
I've tried looking at the config in the axios request interceptor, looking at the dispatch method in the rest_framework source code (checking request details in the dispatch function in , and I can't figure out what is going on or how to solve this. It's a small bug that doesn't take away from the rest of the functionality, but it's a bug nonetheless.
Any help would be appreciated.

I'm pretty confident in saying this doesn't sound like an issue with simplejwt.  Going to close this for now.  If you're eventually certain that I'm wrong, feel free to re-open.


allow template selection for tests with Litmus

Currently when running npm run test / gulp litmus all views are automatically selected for testing. I'd prefer to be able to select one or more views (templates) to test specifically. I imagine we could achieve this with inquirer, similar to the gulp add_module task. I suggest we prompt the user with a list of templates to test and either pre-check all non-underscored views, or no views, or remember the last selection made. So you would get something like:
which templates would you like to submit to Litmus for testing?

[ ] _base-view
[ ] _component-preview
[ ] _guide-viewer
[x] demo_fluid-layout
[x] welcome

I would even argue to always exclude all underscored views (convention) and in that case always use the last selection made.

Fixed with the merge of feat/email-sender to master


[Foundation] Guard Data access to NSData._isCompact under availabilit…

#12601 made it into the swift-4.0-branch but not the later branches.

@swift-ci please smoke test