Fix Jenkins even more

I was blinded by the happiness of seeing green builds and didn't check the logs.

Why did you change build.cmd to build.ps1?

Build cmd calls into ps1 and we are running inside powershell anyway.

This fixes test running, but there is still flakiness.
Interestingly it fails the same way our win7 tests do:
   | [2018-05-25T22:55:52] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Information: Application ready at URL: http://localhost:54999/
   | [2018-05-25T22:55:52] Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.StartupTests Debug: Method: GET, RequestUri: 'http://localhost:54999/HelloWorld', Version: 2.0, Content: <null>, Headers:
   |                                                                                {
   |                                                                                }
   | [2018-05-25T22:55:52] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Information: iisexpress stdout: IncrementMessages called
   | [2018-05-25T22:55:52] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Information: iisexpress stdout: Request started: "GET" http://localhost:54999/HelloWorld
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr: It was not possible to find any compatible framework version
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr: The specified framework 'Microsoft.NETCore.App', version '2.2.0-preview1-26509-06' was not found.
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:   - Check application dependencies and target a framework version installed at:
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:       C:\Program Files\IIS Express\
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:   - Installing .NET Core prerequisites might help resolve this problem:
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:       http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:   - The .NET Core framework and SDK can be installed from:
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Warning: iisexpress stderr:       https://aka.ms/dotnet-download
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IntegrationTesting.IISExpressDeployer Information: iisexpress stdout: Request ended: http://localhost:54999/HelloWorld with HTTP status 500.0
   | [2018-05-25T22:55:53] Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.StartupTests Warning: StatusCode: 500, ReasonPhrase: 'Internal Server Error', Version: 1.1, Content: System.Net.Http.HttpConnection+HttpConnectionResponseContent, Headers:
   |                                                                                {
   |                                                                                Cache-Control: private
   |                                                                                Server: Microsoft-IIS/10.0
   |                                                                                X-SourceFiles: =?UTF-8?B?QzpcVXNlcnNccnVubmVyXEFwcERhdGFcTG9jYWxcVGVtcFxkOTA5MmExNS0yMzhjLTQ4OTktYjY3MS01MmI1ZDRkMGE5YjdcSGVsbG9Xb3JsZA==?=
   |                                                                                X-Powered-By: ASP.NET
   |                                                                                Date: Fri, 25 May 2018 22:55:53 GMT
   |                                                                                Content-Type: text/html; charset=utf-8
   |                                                                                Content-Length: 5821
   |                                                                                }

/cc @Tratcher

Are the jenkins agents accessible for debugging/remoting on?

Error is app is failing to start/exec: E_APPLICATION_ACTIVATION_EXEC_FAILURE. Interesting failure.

It seems like we are passing wrong exe name, it tries to find frameworks in C:\Program Files\IIS Express\

how could that cause a race though?

Doesn't look like a race on Win7, the same tests always fail.

Filed https://github.com/aspnet/IISIntegration/issues/875


fix(build): remove non existent bundle and fix RxJS path

Current build is broken:

This PR fixes it.

It turns out that it's working properly. I should have missed a npm link

:-) it bit me before as well


Provide way to enable anyproxy logging

Just spent ~hours debugging an issue that became immediately clear when silent was set to false for anyproxy.  It would be great if that was either the default (much more verbose logs, of course) or at least configurable.


Avoid throwing exception on invalid or incomplete received presentations

Codecov Report

Merging #359 into master will decrease coverage by 0.02%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   89.24%   89.21%   -0.03%
==========================================
  Files         236      236
  Lines       11187    11203      +16
==========================================
+ Hits         9984     9995      +11
- Misses       1203     1208       +5


using carthage, deployment target is not 8.0(9.3)

using carthage, deployment target is not 8.0(9.3)
I what use it in 8.0+,but get the error:
Module file's minimum deployment target is ios9.3 v9.3
Because deployment target of project is 9.3, not 8.0
Please correct it, thx

Update .podspec to 2.1,  changed deployment target to 8.0

Thanks a lot
And another problem is:
.items is private, not use the items
====================================
Could Hll
黄良亮
☏ (+86)13764557187
✉<EMAIL_ADDRESS><EMAIL_ADDRESS>
在 2016年11月24日，下午6:42，Dmitriy Demchenko<EMAIL_ADDRESS><EMAIL_ADDRESS>写道：
Closed #20 https://github.com/Yalantis/Segmentio/issues/20.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Yalantis/Segmentio/issues/20#event-870915329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuCJhp6Fp_MJddA36kxrs8uCrLLC_Ufks5rBWoGgaJpZM4Kud2t.

====================================
Could Hll
黄良亮
☏ (+86)13764557187
✉<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks a lot
And another problem is:
.items is private, not use the items
====================================
Could Hll
黄良亮
☏ (+86)13764557187
✉<EMAIL_ADDRESS><EMAIL_ADDRESS>
在 2016年11月24日，下午6:42，Dmitriy Demchenko<EMAIL_ADDRESS><EMAIL_ADDRESS>写道：
Closed #20 https://github.com/Yalantis/Segmentio/issues/20.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Yalantis/Segmentio/issues/20#event-870915329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuCJhp6Fp_MJddA36kxrs8uCrLLC_Ufks5rBWoGgaJpZM4Kud2t.


[PTFE-681] Fastapi router routes

Codecov Report

Merging #312 (1396700) into main (ca1b99f) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   89.73%   90.04%   +0.31%
==========================================
  Files          12       13       +1
  Lines         224      231       +7
==========================================
+ Hits          201      208       +7
  Misses         23       23

Flag
Coverage Δ

api
19.91% <100.00%> (+2.50%)
:arrow_up:

unit
81.38% <0.00%> (-2.55%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

runner_manager/main.py
76.47% <100.00%> (+3.13%)
:arrow_up:

runner_manager/routers/webhook.py
100.00% <100.00%> (ø)


Resync duration check?

Was wondering if there might be plans to add a duration check in the resync feature?  So preivously this feature was causing problems for us when the masters were bouncing online/offline very quickly.  That's since been fixed (thank you!) and our tests have stabalized but as additional protection, we would really like to have a configurable period that controls how long the offline-online period is before the resync kicks in.  Especially since this is supposed to address long connection timeout periods.

it is a good proposal!
I implemented a new parameter ~resync_on_reconnect_timeout (default: 0). If it works like you desire I will add a corresponding tag.

This looks like exactly like what we need. Thanks!

it is now in release 0.6.0
regards


Errors when packaged with react, (Cannot find module 'read-pkg')

The simplest packaged command I use does not have a packed react, but as long as the dependencies of react are installed, an error will occur. Errors when packaged with react, (Cannot find module 'read-pkg')
as follows
//package.json

{
  "name": "vkit",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "autoprefixer": "7.1.6",
    "babel-core": "6.26.0",
    "babel-eslint": "7.2.3",
    "babel-jest": "20.0.3",
    "babel-loader": "7.1.2",
    "babel-preset-react-app": "^3.1.1",
    "babel-runtime": "6.26.0",
    "case-sensitive-paths-webpack-plugin": "2.1.1",
    "chalk": "1.1.3",
    "css-loader": "0.28.7",
    "dotenv": "4.0.0",
    "dotenv-expand": "4.2.0",
    "eslint": "4.10.0",
    "eslint-config-react-app": "^2.1.0",
    "eslint-loader": "1.9.0",
    "eslint-plugin-flowtype": "2.39.1",
    "eslint-plugin-import": "2.8.0",
    "eslint-plugin-jsx-a11y": "5.1.1",
    "eslint-plugin-react": "7.4.0",
    "extract-text-webpack-plugin": "3.0.2",
    "file-loader": "1.1.5",
    "fs-extra": "3.0.1",
    "html-webpack-plugin": "2.29.0",
    "jest": "20.0.4",
    "object-assign": "4.1.1",
    "postcss-flexbugs-fixes": "3.2.0",
    "postcss-loader": "2.0.8",
    "promise": "8.0.1",
    "raf": "3.4.0",
    "react": "^16.3.1",
    "react-dev-utils": "^5.0.1",
    "react-dom": "^16.3.1",
    "resolve": "1.6.0",
    "style-loader": "0.19.0",
    "sw-precache-webpack-plugin": "0.11.4",
    "url-loader": "0.6.2",
    "webpack": "3.8.1",
    "webpack-dev-server": "2.9.4",
    "webpack-manifest-plugin": "1.3.2",
    "whatwg-fetch": "2.0.3"
  },
  "scripts": {
    "start": "node scripts/start.js",
    "build": "node scripts/build.js",
    "test": "node scripts/test.js --env=jsdom",
    "ele": "electron main.js",
    "package": "electron-packager . app"
  },
  "devDependencies": {
    "electron": "^1.8.4",
    "electron-packager": "^12.0.0"
  },
  "jest": {
    "collectCoverageFrom": [
      "src/**/*.{js,jsx,mjs}"
    ],
    "setupFiles": [
      "<rootDir>/config/polyfills.js"
    ],
    "testMatch": [
      "<rootDir>/src/**/__tests__/**/*.{js,jsx,mjs}",
      "<rootDir>/src/**/?(*.)(spec|test).{js,jsx,mjs}"
    ],
    "testEnvironment": "node",
    "testURL": "http://localhost",
    "transform": {
      "^.+\\.(js|jsx|mjs)$": "<rootDir>/node_modules/babel-jest",
      "^.+\\.css$": "<rootDir>/config/jest/cssTransform.js",
      "^(?!.*\\.(js|jsx|mjs|css|json)$)": "<rootDir>/config/jest/fileTransform.js"
    },
    "transformIgnorePatterns": [
      "[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$"
    ],
    "moduleNameMapper": {
      "^react-native$": "react-native-web"
    },
    "moduleFileExtensions": [
      "web.js",
      "js",
      "json",
      "web.jsx",
      "jsx",
      "node",
      "mjs"
    ]
  },
  "babel": {
    "presets": [
      "react-app"
    ]
  },
  "eslintConfig": {
    "extends": "react-app"
  }
}

The main.js, render.js, and index.html files are exactly the same as the electron-quick-start project.
When I run npm run package command, the error message is as follows
PS D:\Project\vkit> npm run package

><EMAIL_ADDRESS>package D:\Project\vkit
> electron-packager . app

module.js:540
    throw err;
    ^

Error: Cannot find module 'read-pkg'
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.Module._load (module.js:468:25)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (D:\Project\vkit\node_modules\_read-pkg-up@2.0.0@read-pkg-up\index.js:3:17)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (D:\Project\vkit\node_modules\_get-package-info@1.0.0@get-package-info\lib\index.js:5:17)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>package: `electron-packager . app`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>package script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

But when I remove all dependencies from package.jsonand reinstall the dependencies. it can be packaged again. I'm already dizzy, why the rely's dependencies interfere with electrons, and I'm not actually using react when I'm packing. Thank you
Thank you

Does this directory exist in your development environment?

node_modules_read-pkg-up@2.0.0@read-pkg-up

@MarshallOfSound Yes, it exists

I can't reproduce this on Linux. What do you get when you run npm list galactus?

@malept
PS D:\Project\vkit> npm list galactus
<EMAIL_ADDRESS>D:\Project\vkit
`-- (empty)

Suddenly it was possible to run today. It may be that I restarted windows.
But now there is another problem. The packaging has been running, but it has not been completed. It took more than ten minutes.
PS D:\Project\vkit> npm run package

><EMAIL_ADDRESS>package D:\Project\vkit
> electron-packager . app

Packaging app for platform win32 x64 using electron v1.8.4

@malept @MarshallOfSound
My project is at GitHub

In order to help you with your problem, we're going to need more information about it. In particular, the console output when you first execute SET DEBUG=electron-packager, and then execute npm run package.

@malept I ran this command and nothing was output. However, after restarting windows, it can be packaged once. I hate windows, thank you very much for your help

There's nothing we can do to help if there's not more information given, so I'm going to go and close this issue.

@malept Packaged again and running but not completed, I decided to develop on the virtual machine. I don't know what causes it, node -v8.9.4, windows 10 1709, running on the VM is fine.

Had the same issue when trying to run vue ui.
Solved by manually navigating to the relevant node_modules parent folder and running:
npm install read-pkg

Dunno why windows didn't install it in the first place, but after manually installing it - everything worked fine.


Fixed typo for english translation

Catagories is not part of the oxford english dictionary

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-9369
Please use this issue to track the state of your pull request.

thanks @JoshuaBehrens :+1: :tada: :blue_heart:


IDVA6-1302 - Welsh Translation - Add an authorised person

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1302
Changes:

Updated relevant Welsh language files with Welsh translations

CI: No security warnings found

CI: No security warnings found


how to gui for unity3d in docker?

Thanks to you and others' excellent work, I have got very close to having a GUI launch from inside a docker container but something is missing.
So far I have followed lots of tutorials and examples (gableroux, jessfraz, mviereck and so on) - and I can get many GUIs working from a docker install - but not a standalone unity3d game level
here is what I have done so far:

start xhost
xhost +local:root;
create a display to use
Xvfb :2 -screen 0 1024x768x16
check that the display is running
ps aux | grep X
run my docker session
docker run -it --rm -e DISPLAY=:2
-v /tmp/.X11-unix:/tmp/.X11-unix <docker_imageID> /bin/bash
from inside docker:
root@:/app# ./<my_game>.x86_64

from the traceback you can see it is running but no screen pops up?:
Set current directory to /app
Found path: /app/<my_game>.x86_64
Mono path[0] = '/app/<my_game>_Data/Managed'
Mono config path = '/app/<my_game>_Data/MonoBleedingEdge/etc'
Preloaded 'libgrpc_csharp_ext.x64.so'
Unable to preload the following plugins:
ScreenSelector.so
PlayerPrefs - Creating folder: /root/.config/unity3d/Unity Technologies
PlayerPrefs - Creating folder: /root/.config/unity3d/Unity Technologies/Unity Environment
Logging to /root/.config/unity3d/Unity Technologies/Unity Environment/Player.log
any ideas where I am going wrong?

There seems to be some confusion:

start xhost
xhost +local:root;

This affects your current X $DISPLAY, probably :0. But later your run another X server with display number :2.
Btw., I would prefer the syntax xhost +SI:localuser:root, if needed at all. For this setup you don't need it.

create a display to use
Xvfb :2 -screen 0 1024x768x16

You run an additonal X server Xvfb. Xvfb is invisible; vfb means virtual frame buffer.
Try instead: Xephyr :2 -ac -extension MIT-SHM. Xephyr is a visible nested X server.
Compare: https://github.com/mviereck/x11docker/wiki/Short-setups-to-provide-X-display-to-container#providing-nested-x-server-xephyr

wow - thanks for the speedy response - I'll try that now...

ok - I tried the following:
Displaynumber=1
Xephyr :$Displaynumber -extension MIT-SHM -extension XTEST &
I get the following error:
_XSERVTransSocketUNIXCreateListener: ...SocketCreateListener() failed
_XSERVTransMakeAllCOTSServerListeners: server already running
(EE)
Fatal server error:
(EE) Cannot establish any listening sockets - Make sure an X server isn't already running(EE)
I tried sudo stop lightdm but doesn't seem to stop the x-server?
when I use:
Xephyr -ac -screen 1280x1024 -br -reset -terminate 2> /dev/null :1 &
and run the docker script - it runs but still no popup screen...
docker run --rm
-e DISPLAY=:$Displaynumber
-v /tmp/.X11-unix/X$Displaynumber:/tmp/.X11-unix/X$Displaynumber:rw
--user $(id -u):$(id -g)
--cap-drop=ALL
--security-opt=no-new-privileges
<image_name> ./<my_game>.x86_64

(EE) Cannot establish any listening sockets - Make sure an X server isn't already running(EE)

This error indicates that you already have an X server with display number 1.
Have a look at /tmp/.X11-unix/. Probably there is already a socket X1. Try a free display number.

ok I changed display to 2 - I get a popup window now - great! - but when I run the docker script still no game graphics in window
I use ps aux | grep X to check what display is free
root      1231  0.0  0.1<PHONE_NUMBER>8 tty1     Sl+  22:28   0:01 /usr/lib/xorg/Xorg vt1 -displayfd 3 -auth /run/user/123/gdm/Xauthority -background none -noreset -keeptty -verbose 3
root      1767  1.7  0.2<PHONE_NUMBER>8 tty3     Sl+  22:28   0:25 /usr/lib/xorg/Xorg vt3 -displayfd 3 -auth /run/user/1000/gdm/Xauthority -background none -noreset -keeptty -verbose 3
twyeld    3776  0.0  0.2 1102724 49360 ?       Sl   22:43   0:00 docker run --rm -e DISPLAY=:1 -v /tmp/.X11-unix/X1:/tmp/.X11-unix/X1:rw --user 1000:1000 --cap-drop=ALL --security-opt=no-new-privileges mytest3 ./ban2heliIndAgents.x86_64
twyeld    4092  0.0  0.0  17484   904 pts/1    S+   22:53   0:00 grep --color=auto X

Xephyr does not appear in your ps output. Is it really running?
The docker run command shows DISPLAY=:1, but you said you switched to display number 2.
Please check again.

sorry for confusion - that display listing was taken before I loaded your script.
this is what I get after loading your script:
root      1246  0.6  0.1<PHONE_NUMBER>8 tty1     Sl+  10:49   0:01 /usr/lib/xorg/Xorg vt1 -displayfd 3 -auth /run/user/123/gdm/Xauthority -background none -noreset -keeptty -verbose 3
root      1923  2.8  0.2<PHONE_NUMBER>6 tty3     Sl+  10:50   0:04 /usr/lib/xorg/Xorg vt3 -displayfd 3 -auth /run/user/1000/gdm/Xauthority -background none -noreset -keeptty -verbose 3
twyeld    3103  0.0  0.1<PHONE_NUMBER>2 pts/0    Sl   10:52   0:00 Xephyr :2 -extension MIT-SHM -extension XTEST
twyeld    3170  0.6  0.2 1175944 49324 pts/0   Sl+  10:52   0:00 docker run --rm -e DISPLAY=:2 -v /tmp/.X11-unix/X2:/tmp/.X11-unix/X2:rw --user 1000:1000 --cap-drop=ALL --security-opt=no-new-privileges mytest3 ./ban2heliIndAgents.x86_64
twyeld    3388  0.0  0.0  17484   912 pts/1    S+   10:53   0:00 grep --color=auto X
It is definitely running Xephyr :2
and I get a popup window but still no graphics from the standalone Unity3D game app...

So far the setup should work. Now let's look at the application itself. What output does it give?
Do you have another X application in the image to test? You could install e.g. xterm in the image and try that instead of unity3d.

Thanks mviereck  - I have tried several ways but can't even get a xterm working.
Here is the new dockerfile (whcih includes xterm and my standalone unity3d game):
RUN apt-get update && apt-get install -y xterm
RUN useradd -ms /bin/bash xterm
USER xterm
WORKDIR /home/xterm
COPY standalone /home/app/```

And here is how I build:
```docker build -t xterm .```

and attempt to run - not assigning a display:
```docker run -it --rm -e DISPLAY=${DISPLAY} \
-v /tmp/.X11-unix:/tmp/.X11-unix xterm xterm```

and error:
```No protocol specified
xterm: Xt error: Can't open display: :1```

and attempt to run - assigning display 2:
docker run -it --rm -e DISPLAY=:2 \
```-v /tmp/.X11-unix:/tmp/.X11-unix xterm xterm```

and error:
```xterm: Xt error: Can't open display: :2```

here I am sending you the unity3d standalone app I am trying to launch from
inside a docker container... maybe it helps?
it certainly works in the native linux env
standalone.zip
https://drive.google.com/file/d/1R-j6F9cYZXcQATilYUabkTdfbIjiBjFT/view?usp=drive_web
On Wed, Sep 18, 2019 at 7:05 PM mviereck<EMAIL_ADDRESS>wrote:

So far the setup should work. Now let's look at the application itself.
What output does it give?
Do you have another X application in the image to test? You could install
e.g. xterm in the image and try that instead of unity3d.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mviereck/x11docker/issues/186?email_source=notifications&email_token=AHDK6T3R4YXBK7U6J7SJSSLQKHVORA5CNFSM4IXOTTT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67LZVI#issuecomment-532593877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDK6T3NV6F4EDLMORFBEZLQKHVORANCNFSM4IXOTTTQ
.

Try:
Xephyr :2 -ac -extension MIT_SHM

docker run --rm -e DISPLAY=:2 -v /tmp/.X11-unix:/tmp/.X11-unix xterm xterm

ok - that got me an xterm in xephyr on :2 (after changing MIT_SHM to MIT-SHM)

Good!
Now try to run your unity3d application in that xterm window.

how to check what directory am in ?
xterm doesn't take dir or ls

Yo are probably in an empty directory if you don't get an output.
Try pwd.

it returns: /home/xterm

ok so I cd ../ etc up to app and then launched the game!!! yay!
pretty chugsville though!
clearly only using cpu for rendering - is there anyway to get it to use my nvidia 1050 card?

GPU usage does not work with Xephyr.
Using NVIDIA GPU with containers is more complicated than other GPUs.
Compare:
https://github.com/mviereck/x11docker/wiki/Hardware-acceleration
I suggest to use x11docker for NVIDIA setups: https://github.com/mviereck/x11docker/wiki/NVIDIA-driver-support-for-docker-container

I managed to launch your x11docker session using xterm embedded in xephyr - but i don't think this is what you meant... I could get gpu_glxgears to run at ~2500fps - cool!
not sure how to access x11docker other than through xterm and xephyr...?
is there a more direct method?

I tried
xhost local:root
then:
docker run --rm -e DISPLAY=:2 x11docker
but get error:
kaptain: cannot connect to X server :2
I even tried:
docker run --rm -e DISPLAY=:2 -v /usr/bin/x11docker:/tmp/x11docker x11docker xterm
but same error...

You need to be more clear, in your reports as well as in your attempts to get to run something.

docker run --rm -e DISPLAY=:2 x11docker
but get error:
kaptain: cannot connect to X server :2

That is impossible. x11docker does not use kaptain. You probably tried to run x11docker-gui.
Also, x11docker is not a docker image but a bash script.
Please read the documentation on how to use x11docker:
To run a Docker container on a new X server:
  x11docker IMAGE
  x11docker [OPTIONS] IMAGE [COMMAND]
  x11docker [OPTIONS] -- IMAGE [COMMAND [ARG1 ARG2 ...]]
  x11docker [OPTIONS] -- DOCKER_RUN_OPTIONS -- IMAGE [COMMAND [ARG1 ARG2 ...]]
To run a host application on a new X server:
  x11docker [OPTIONS] --exe COMMAND
  x11docker [OPTIONS] --exe -- COMMAND [ARG1 ARG2 ...]
To run only an empty new X server:
  x11docker [OPTIONS] --xonly

Try:
x11docker --xephyr xterm xterm

ok - I think the confusion comes from me creating docker images with the names x11docker and xterm2 respectively... I should have used different naming...
x11docker --xephyr xterm xterm
gives me a xephyr shell with xterm inside from which i can launch a unity3d game app - but xephyr only supports CPU rendering
can I use something like xorg with --gpu or even --hostdisplay ?

can I use something like xorg with --gpu or even --hostdisplay ?

Yes. Be aware that --gpu with NVIDIA needs some special setup, compare: https://github.com/mviereck/x11docker/wiki/NVIDIA-driver-support-for-docker-container
The wiki article describes three possible setups.
Probably the best choice for you is to create a custom driver base image:
https://github.com/mviereck/x11docker/wiki/NVIDIA-driver-support-for-docker-container#nvidia-driver-base-image
Use this driver base image to create a new image containing xterm and your unity3d game.

I am still a bit confused. Yes, I need to move on to configuring for the nVidia driver but, surely I can get a simple session working using --hostdisplay before that?
Here is s screen grab of the errors I am getting - not sure where I am going wrong...

Please do no provide screenshots but copy the terminal messages und provide them in codeblocks
x11docker shows two warnings that applications may fail with --hostdisplay.
At first it recommends --clipboard, at second it warns about NVIDIA.
Please read the messages and try with --hostdisplay --clipboard.

ok - this time I get the following error:
libGL error: failed to load driver: swrast
X Error of failed request: GLXBadContent```
etc...

This error is probably due to the NVIDIA driver.
As the warning says, --hostdisplay can fail with NVIDIA.
At this point, you can either use another X server option like --xpra, --xephyr or --nxagent, or you set up an NVIDIA driver image and run with --hostdisplay --gpu.

I have successfully installed your "x11docker/nvidia-base" image - how to run it and point it at my basic container with my game app in it?

Build a new image instead of using the old one.  It works!
so sweet to see it working at last - after weeks of bashing away...
thank you so much...

Great! :-)
You're welcome.

normal port expose function doesn't seem to work

You need docker option -p for both containers. This should work:
x11docker --hostdisplay --gpu --env PORT=localhost5005:5005 -- -p 5005:5005 -- <my_image> xterm

Alternatively a setup with docker option --network should be possible, providing the same network namespace to both containers.

I now have a new issue for x11docker/nvidia-base

In general, please open new tickets for new issues.


VersionByNamespaceConvention for major version with 2 or more digits

We want to make a V10.0 API version and we are using VersionByNamespaceConvention configuration. But it looks like that this is not supported (if you skip the date part).
I checked the Pattern used in the VersionByNamespaceConvention and it looks like "10" is matching the second group (month). And therefore it is not seen..
It will work if we use "V___10_0" as namespace; but that will be ugly.
I would prefer an option to configure that you only use major/minor convention..
or maybe a more easy way of fixing would be; first check if it has at least 8digits before date matching will be applied.

Thank you for the fast response and for the suggestion to temporary fix this. I will close this issue, because the fix is coming.


Console task overwrites default rails console task for development stage

Whenever I try to run rails c locally (development env), I receive this error:
$ rails c
Could not find sshkit-interactive-0.2.0 in any of the sources
Run `bundle install` to install missing gems.

The culprit seems to be that you're overwriting the console task and forcing an interactive session. Any idea on how to fix? Removing the gem from the Gemfile fixes the issue, of course.
Running Rails 5. Let me know if you need more info.

Hi,
there is no console task (rails:console) defined by capistrano itself or any plugin I know so this gem shouldn't be overwriting anything.
Have you tried running bundle exec rails c? Maybe this will fix the dependency problem you're experiencing.
sshkit-interactive is definetly a dependency capistrano-rails-console.gemspec and bundler should install it when installing this gem.


Added tabular output capability DAT-7748

Environment
Liquibase Version:
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version:
Database Vendor & Version:
Operating System Type & Version:
Pull Request Type

[ ] Bug fix (non-breaking change which fixes an issue.)
[ ] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
A clear and concise description of the issue being addressed.  Additional guidance here.

Describe the actual problematic behavior.
Ensure private information is redacted.

Steps To Reproduce
List the steps to reproduce the behavior.

Please be precise and ensure private information is redacted
Include things like

Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior
A clear and concise description of what happens in the software before this pull request.

Include console output if relevant
Include log files if available.

Expected/Desired Behavior
A clear and concise description of what happens in the software after this pull request.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
Fast Track PR Acceptance Checklist:

[ ] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Added Test Harness Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

Yes
On Fri, Aug 13, 2021 at 11:15 AM Steven Massaro @.***>
wrote:

@.**** approved this pull request.
In liquibase-core/src/main/java/liquibase/util/TableOutput.java
https://github.com/liquibase/liquibase/pull/2036#discussion_r688576980:

   try {

       formatOutput(table, maxWidths, true, new OutputStreamWriter(System.out));

   } catch (LiquibaseException ioe) {

       throw new RuntimeException(ioe);

   }

   table = new String[][] {{ "id", "First Name", "Last Name", "Age", "Profile" }};

   formatOutput(table, maxWidths, true);

   try {

       table = new String[][] {{ "id", "First Name", "Last Name", "Age", "Profile" }};

       formatOutput(table, maxWidths, true, new OutputStreamWriter(System.out));

   } catch (LiquibaseException ioe) {

       throw new RuntimeException(ioe);

   }

Should this static void main method be removed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/liquibase/liquibase/pull/2036#pullrequestreview-729703295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHAEDD6FKUBB7WRP6ALJPTT4VAJ7ANCNFSM5CDXS4SA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


how to test thunks dispatching other thunks

say i want to assert certain number of actions are being dispatch in the other thunk?
 function fetchPosts(subreddit) {   return dispatch => {     dispatch(requestPosts(subreddit))     return fetch(http://www.reddit.com/r/${subreddit}.json`)
.then(response => response.json())
.then(json => dispatch(receivePosts(subreddit, json)))
}
}
function shouldFetchPosts(state, subreddit) {
const posts = state.postsBySubreddit[subreddit]
if (!posts) {
return true
} else if (posts.isFetching) {
return false
} else {
return posts.didInvalidate
}
}
export function fetchPostsIfNeeded(subreddit) {
// Note that the function also receives getState()
// which lets you choose what to dispatch next.
// This is useful for avoiding a network request if
// a cached value is already available.
return (dispatch, getState) => {
if (shouldFetchPosts(getState(), subreddit)) {
// Dispatch a thunk from thunk!
return dispatch(fetchPosts(subreddit))
} else {
// Let the calling code know there's nothing to wait for.
return Promise.resolve()
}
}
}
`

sorry to bother , i was able to figure it out...
by the way it is as just simple as testing normal thunk.
thanks...

Can you please tell me how you have achieved this??

I'm running into this now, I want to check the parameters passed to thunk action creator called within a thunk action creator. Difficult stuff.

The redux documentation has an example on how to test async dispatches with redux-thunk.
Test: Async Action Creators
(just for reference)

This helped me resolve it:
https://medium.com/@talkol/redux-thunks-dispatching-other-thunks-discussion-and-best-practices-dd6c2b695ecf
The answer is to not dispatch thunks from thunks, but to create helpers to handle common tasks. These can be run inline and just dispatch other actions, which in turn allows you to assert on the dispatched actions.


Please upgrade dependencies

You are using an outdated deprecated version of node-sass which has weird installation errors.
https://github.com/dlmanning/gulp-sass/blob/master/package.json#L25
See "Improved installation errors" starting in v3.5.1 at https://github.com/sass/node-sass/releases

So am I but I'm not sure is related. I filed an issue under node-sass either way.
https://github.com/sass/node-sass/issues/1579

Please search before opening a new issue. Duplicate #504 #501 #499 #497 #493 #491 #489.


Query.first has unexpected behavior

func get(index: Int) -> Row? {
    let query = db["some_table"].limit(1, offset: index);
    return(query.first);
}

get(0) // gets row 0
get(3) // gets row 0

That behavior seems unexpected, it took me a while to figure it out. The problem is that first reruns the query with limit(1) and discards the offset: var generator = limit(1).generate(). Thanks for a great library.

Good catch!


Fixed Advanced Systems dead links

Sorry if I'm doing this wrong, i haven't used GitHub cooperatively before so I'm winging this.
The three Computation Structures currently are dead links, this just updates them to their current position.

Good catch!


Added NetApp export_policy and updated nfs-101 example for sample usage

This PR is in reference to #517 it addresses the missing export_policy block. Documentation has been updated under examples/netapp/101-nfs

Merging to the integration branch


Add tpope/vim-repeat compatibility

Exchange repeats naturally. Can you give more detail about what this is doing?

@tommcdo: I noticed some issues from time to time too. This PR could fix them.
Here's an example:
before
foo
bar

With the surround plugin, type yssb to surround the first lines in parentheses. Pressing . will repeat it to ((foo)). Not press cxx to mark the current line for exchange. Pressing . on the second line should finish the exchange, but it will surround the second line instead:
after
((foo))
(bar)

expected
bar
((foo))

Interesting... I'm curious about what's going on here, but for now I'll merge this in.

Sure. When calling repeat#set(), vim-repeat saves the value of b:changedtick in g:repeat_tick. The next time . is pressed, vim-repeat checks if b:changedtick has incremented since being saved to g:repeat_tick. If it has, then it assumes that no repeatable action has occurred since repeat#set() was called and it repeats what is in g:repeat_sequence, otherwise it uses Vim's . functionality.
The problem addressed in this PR is that if the action before using Exchange was saved in vim-repeat and then Exchange is used for the first half of an exchange, b:changedtick is not incremented so when the user pressed . vim-repeat fires off g:change_sequence instead of letting Vim repeat the Exchange action. Calling repeat#invalidate() resets g:repeat_tick so that vim-repeat knows it should let Vim do its thing instead of using g:repeat_sequence.


Added one issue,60% done - project progress bar still shows 0%

Added one issue,60% done - project progress bar still shows 0%
version 0.10

Hello again,
What I was looking for (and maybe others are too) is specifically how the progress % is determined.
Please correct me if I am wrong but in addition to the explination above I offer this:
It looks like the Progress Bar (lighter color) is estimated by adding the % done for each issue and dividing by the number of issues. Issues that are in Closed status = 100% no matter what the % Done slider inside the Issue shows. This progress bar does not care about estimated time.
The % field is estimated hours total divided by number of open tickets.
See code snippet below for he % complete math.
It would seem the % complete should take into account the Estimated and Spent Hours.
Is that also inherited from Redmine or is it only calculated in your project_decorator.rb?
Thanks again.
Code snippet from  redmine-progressive-projects-list/lib/progressive/project_decorator.rb
Cloned from Version#issues_progress(open)
def issues_progress(open)
@issues_progress ||= {}
@issues_progress[open] ||= begin
progress = 0
if issues.count > 0
ratio = open ? 'done_ratio' : 100
done = issues.sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{estimated_average}) * #{ratio}",
:joins => :status,
:conditions => ["#{IssueStatus.table_name}.is_closed = ?", !open]).to_f
progress = done / (estimated_average * issues.count)
end
progress
end
end

@Saylrman64 as you can see the code for this calculations was cloned from the Redmine core. I believe that code and plugin should share the same behavior. So, if any change to this logic needs any update this update should be added to the Redmine core first.

Thank you @stgeneral
If I wever get time or energy to make the estimation better, I will start with Redmine core.
Thanks again.

@stgeneral can we also show the number of inprogress issues, and resolved issues?

@ahsankhan201 Redmine has two high level statuses: 'open' and 'closed'. Other statuses ('In progress', 'Resolved', etc) are custom and should not be tracked by generic plugin.

@stgeneral  Thanks for your reply. but tell me how can i achive it by customise your plugin.
because i am a layman in redmine development.

@ahsankhan201 you may take a look and customize this lines:

https://github.com/stgeneral/redmine-progressive-projects-list/blob/master/lib/progressive/projects_helper_patch.rb#L29
https://github.com/stgeneral/redmine-progressive-projects-list/blob/master/lib/progressive/projects_helper_patch.rb#L41

@stgeneral Many Many Thanks for your quick response.
I change this line by your given line but it shows this error in logs.
ActionView::Template::Error (undefined local variable or method version' for #<#<Class:0xc1de4ec>:0xc1e4928>):     9:
<%= l(:label_project_plural) %>
     10:     11:
     12: <%= render_project_hierarchy(@projects) %>     13:
     14:     15: <% if User.current.logged? %>   app/helpers/application_helper.rb:286:in block in render_project_nested_lists'

@stgeneral can you help me out to customise these lines. which argument i can add for getting in progress issues.?

@ahsankhan201 I have no plan to add this feature to the plugin. So, you may feel free to update plugin as you like.


Documentation of Standalone and Jakarta EE modes for using Jakarta Data providers

This pull adds documentation of the ways of using Jakarta Data, which can be as Standalone providers, within Jakarta EE products, or both.
It explicitly documents that injection can be accomplished either by custom dependency injection or by CDI and addresses discovery of providers for the latter, giving Jakarta Data providers the flexibility to choose the approach that best suits them without imposing requirements on providers that already have their own dependency injection.

Could you explain when you need to use it?
I mean, CDI has the @Inject that allows it.
There is the CDI Instance to allow and see multiple implementations) where you can see those.
@Inject
@Any
Library repository;

Sorry, but it is still unclear why we need it if a CDI engine can handle that for us.

Sorry, but it is still unclear why we need it if a CDI engine can handle that for us.

@otaviojava you are assuming that all of the Jakarta Data providers want to provide their own CDI extensions, but we have already heard from them that isn't the case. Some want to use their own dependency injection, and mostly others probably don't want to do either, and they shouldn't need to.  This will give the Jakarta EE products a way to bring providers into CDI without the providers needing to have any dependency on CDI, and accommodates custom dependency injection as well.

This is a very difficult balancing act because we have 3 groups with completely different objectives around dependency injection

Existing providers with pre-existing custom dependency injection models that want to keep them
JNoSQL that wants to use its own CDI-based approach
The Jakarta EE platform, which places a great deal of importance on being CDI-centric

The third category above hasn't really had representation in the spec group, but we should not be ignoring it and what the consequences might be if we are deemed inadequate. If we don't do anything at all and leave the spec as is, I find it extremely unlikely that Jakarta EE accepts our specification into a Jakarta EE profile. I really don't want to risk that.
I've tried to put together this compromise as something that all of us will dislike parts of, but that we can hopefully all find workable, because it should leave ways for everyone to achieve their objectives.

It allows Spring and Micronaut to keep their custom dependency injection models. They would need to tolerate the existence of the provider SPI in the spec, but it's their choice whether to tie into it, and they will be able to pass the Standalone TCK (which is how non-EE profiles certify) even if they choose not to provide the SPI, just using java.inject and their custom dependency injection models.

It asks JNoSQL to tie into the provider SPI for CDI integration when running in Jakarta EE profiles, but for Standalone, JNoSQL could do whatever it wants, with its own standalone-mode CDI extension, or whatever it chooses.

For Jakarta EE, it offers a CDI-centric solution in Jakarta EE profiles (that we know some providers will choose not to adopt), while outside of Jakarta EE profiles it neglects to enforce a CDI-centric solution and allows custom dependency injection for Standalone and when running with combinations of Jakarta EE specs that aren't officially declared to be Jakarta EE profiles. There are statements in this pull that Jakarta EE as a whole I'm sure will be unhappy with, but I think we can at least defend it as being necessary for the compromise that needs to be made.

If we all argue for getting everything we want, then we will never reach any agreement as was the case in the previous attempt. I'm hoping we can come to a solution that is at least workable for everyone. Not our favorite solution, but a workable solution, where everyone preserves what is most important to them.

The Jakarta EE platform, which places a great deal of importance on being CDI-centric

Being CDI-centric at the same time that they don't want to use CDI resources such as CDI extension, Instance, and Disposes, this point does not make sense to me.
The method  void repositoryBeanDisposed(Object repository);
CDI provides the Disposes annotation, which you can use as well:
https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#declaring_disposer_method
After reviewing the specifications, creating a Provider for the Repository instance would not align with the single responsibility principle of the specification. Additionally, the current stage of the specification allows for any dependency injection, which CDI can handle on Jakarta EE with resources such as Instance, Dispose annotation, and qualifier.
While a DataProvider may be helpful for those who choose not to use dependency injection, covering this point in the specification may not be necessary.

Being CDI-centric at the same time that they don't want to use CDI resources such as CDI extension, Instance, and Disposes, this point does not make sense to me.

It wouldn't make sense if it were the same group having positions that are in conflict. However, as pointed out there are multiple groups with different objectives here, one wanting to be CDI-centric, another wanting no part whatsoever in CDI. I'm sure that each believes their own position makes sense. Our specification needs to cope with the differing positions and bring everyone together with an agreeable compromise to be successful.

After reviewing the specifications, creating a Provider for the Repository instance would not align with the single responsibility principle

Your argument here doesn't involve a correct understanding of single responsibility principle. Single responsibility does not mean that one module takes responsibility for everything that is needed to achieve the specification. It means that each module should have just one responsibility. If you apply the principle of single responsibility here, one could argue that your idea to have the Jakarta Data provider be responsible for everything - both supplying repositories and also responsible to integrate repositories with CDI - is contradictory to it. A solution where one module, a Jakarta Data provider, only has the responsible of providing repositories, and another module, a component of the Jakarta EE product, only has the responsibility of integrating repositories with CDI, seems a much better fit for the principle of single responsibility.

Another point: could you define "CDI-centric" and why not use CDI spec resources?

I'm sorry to have written things so unclearly as to suggest CDI spec resources would not be used by Jakarta EE products.  Hopefully the corrections I made for preceding review comments have cleared this up.  Jakarta EE products will be providing a CDI extension on behalf of the providers that register with the SPI.  So the CDI spec is being used just as well as in the proposal to make providers supply a CDI extension, except that we get even broader coverage because we can cover additional providers this way and we also get a simplified, superior user experience out of it.
CDI-centric isn't my own term to define, but I think we should be able to satisfy expectations of Jakarta EE with this enough to allow the Jakarta Data spec into a Jakarta EE profile.  We are requiring CDI support to come from the Jakarta EE product, which is the only place where all vendors will happily provide it (all profiles already include CDI).  Standalone providers and running with individual Jakarta EE specs outside of an official profile don't require CDI support, but could opt to do something on their own.  Jakarta EE should be fine with this.

CDI-centric literally meaning the approach is centered around the concept and usage of CDI. To your question, I think you're asking why use "@Inject" and not "https://github.com/resource"?

Yeap, why not use CDI extension, Inject, Dispose of CDI, and create this Provider?

Closing this because the solution from #131 was chosen instead.


❓ [Question] Lowering pass for PyTorch Linear

❓ Question
Hi, I saw that one of the lowering pass TRTorch has is lowering linear to mm + add. I'm wondering what the reason behind this is. Does TensorRT provide better performance with matmul layer + elementwise sum layer than fully connected layer? Or breaking it down help the fusion process in TensorRT?

https://docs.nvidia.com/deeplearning/tensorrt/best-practices/index.html#optimize-layer
It says "A new development is encouraged to use MatrixMultiply in preference to FullyConnected layers for consistency of interface. Matrix multiplication is generally significantly faster in FP16 Tensor Cores compared to FP32."
Fully connected layers are expressed as convolutions. I'm not sure if there would be any perf difference for general layer dimensions that are used in final classification layers.
One reason to do this in TRTorch is that we usually keep our converter library light. Any operations that can be expressed as a composition of existing converters would be done so, unless we know for sure there would be big performance penalty.
So at::linear can be expressed as aten::matmul + aten::add which reuses existing converters. However, we also have aten::linear converter (which uses fullyconnected layer in TRT) which is legacy code and has been implemented much earlier.

Going to move this thread to discussions 😄


About test threshold

Thanks to the authors for their work! May I ask how much you set the threshold in parser.add_argument('--threshold', default=None) during testing to achieve the best result? I changed None to 0.7 finally tested Dice as 0.7732 on LA dataset and it didn't work very well. What is the threshold setting for your experimental testing procedure?

We have discussed this issue in #6. Only binary classification problems have this parameter, and this parameter is printed out during the training process. If you do not have a record, you can set threshold=0.5


Resolves issue #143: Upgrade to python3 with backward compatibility

This PR resolves an issue #143.
Updated all the syntax to support the python3. All test cases were executed and passed successfully

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@fdb-build test this please

Hi @apkar like to understand what is the next action in this PR

Hi @apkar like to understand what is the next action in this PR

This PR is waiting on me for the review. I will look into your PRs this week.

@fdb-build test this please


add new implementation detail

Hi @IWANABETHATGUY. The repo has a complete sketch now and it is ready for contribution now. Do you still want further communication?

Hi @IWANABETHATGUY. The repo has a complete sketch now and it is ready for contribution now. Do you still want further communication?
of course, but we need a way to communicate first


Door related icon

Icon Request

Icon name:  door open, door close, emergency exit
Use case: emergency exit or just exit for site
Screenshots of similar icons:

How about?

Emergency exit probably depends on https://github.com/lucide-icons/lucide/issues/609

nice work!

Any updates?

I had a go at this, but only for the open variant as I quite like your one @karsa-mistmere
The second one I styled off the emergency exit one @WooWan posted with regards to perspective, but I think at small resolutions the first one looks more door-like.


jsdoc package vulnerable to HTML injections

org.webjars.npm_jsdoc package from all versions are vulnerable for HTML injection. It is possible to inject HTML content in the comments before the code being documented. Once code is commented and jsdoc was used to generate HTML website from the sourcefiles, accessing webpage where HTML was injected in comments will show the actual element. This issue allows page modification through the comments and expose the user for different vulnerabilities such as Cross-Site Scripting (XSS).
During our security scan this vulnerability was discovered in jsdoc. Please see through this

Duplicate of https://github.com/jsdoc/jsdoc/issues/1991, which explains why this isn't a "vulnerability" in any meaningful sense.


Wet 464 static site

There is no need to push the static content, as you already did by creating the new branch.


Added fromCompletionStage

Added a fromCompletionStage stage.
A big question around the behaviour here, what happens if the CompletionStage is redeemed with null? Reactive Streams doesn't allow nulls. So, you can either fail with a NullPointerException, or you can have an empty stream that completes without emitting any elements.
The advantage of the latter is that it works nicely with CompletionStage<Void>, which is very commonly used to signal success and nothing else. However, it's inconsitent with the current specified behaviour for flatMapCompletionStage. And I feel like flatMapCompletionStage might be a good idea to have the way it is - when you use flatMapCompletionStage, you typically expect a 1:1 mapping of elements, if we made it just drop nulls, then that would be surprising behaviour, and especially given that it's likely common to want to handle completion signals in some form, the user should convert the nulls to some other non null unit value before returning it from the callback. By not supporting nulls there, we ensure bad/common programming mistakes are caught early. But it would be strange if flatMapCompletionStage failed on nulls, while fromCompletionStage silently dropped them. Maybe we should have a fromCompletionStageNullable or flatMapCompletionStageNullable?
The current specification and TCK require fromCompletionStage to silently drop nulls. I'm not sure that that's the right implementation, but we should discuss this further before merging.

Updated to include fromCompletionStageNullable.


support inference a batch of prompts

from lmdeploy.serve.async_engine import AsyncEngine
engine = AsyncEngine('workspace')
outputs = engine.batch_infer(['test', 'hi'])
print(outputs)

may resolve conflicts


JAVA-539 cse.request.timeout support dynamic refresh

Coverage decreased (-0.004%) to 86.846% when pulling 1676e161554169f5ec6dd6d645bc9696edf78745 on laijianbin:123 into a999de1982f0be20be2de7e4aaefca24c9e24a09 on ServiceComb:master.

Coverage decreased (-0.004%) to 86.846% when pulling 0796fea5b1486fb64c5fa9daff5138300a0e091d on laijianbin:123 into a999de1982f0be20be2de7e4aaefca24c9e24a09 on ServiceComb:master.

Coverage increased (+0.03%) to 86.88% when pulling 0796fea5b1486fb64c5fa9daff5138300a0e091d on laijianbin:123 into a999de1982f0be20be2de7e4aaefca24c9e24a09 on ServiceComb:master.

@laijianbin  There are two PR for the same issue, please close the PR which you don't want us to merge.

no use


Force bind with dsa account or anonymous before a search operation

I force bind with dsa account / anonymous accont before a search operation because I think that the authenticate operation assign the user bind.
if ( $username && $password ){
if ( @ldap_bind($this->_ch, $dn, $password) ){
return true;
}
}

Sorry for getting back to you that late.
Can you explain, what issue you encountered and then tried to solve? The LDAP::search()-method should not be used without a prior bind. Therefore a bind should already have been done and there is no need to bind again.
Thanks for your explanation!

My ACL blocked my wordpress authentification.
I think that the ldapsearch was tried in anonymous and not with the DSA account.

Thanks @kadogo for bringing that to my attention. I solved it in a more general manner by calling the bind right after a successfull authentication.


Pack is huge is size

The pack is huge ins size reduce its size

Pack size is decreased by removing unwanted files


[9.x] Support for enum in DatabaseRule exists

Fix issue #43603

Taylor asked for a proper explanation and tests in https://github.com/laravel/framework/pull/43586 which this PR still doesn't provides. Please resubmit with those.


Workflow Question

Chris, can you sum up the workflow with BRAW Toolbox and FCP?
If there is documentation, please point me to it.
I'm scratching my head right now
Thx

You should have seen some notes in TestFlight that explains how to use it - specifically:

BRAW Toolbox allows you to import Blackmagic RAW directly into Final Cut Pro without transcoding.
You can post any issues and get help and support here: https://github.com/latenitefilms/BRAWToolbox/issues
When you first launch the BRAW Toolbox application, you'll need to press the "Install Motion Template" button, which will install the "BRAW Toolbox" effect into Final Cut Pro. You'll then need to press the "Install Metadata View", which will install the Custom Metadata View. Once this is done you can close the BRAW Toolbox application and launch Final Cut Pro.
During the beta testing stage, you should run the BRAW Toolbox application after each update to see if you need to re-install either the Motion Template or the Metadata View.
From within Final Cut Pro you can access the BRAW Toolbox via the Workflow Extension toolbar icon, or the "Window > Workspaces" menubar item.
In the Workflow Extension, you can import BRAW files and adjust their metadata, prior to importing the files into Final Cut Pro.
Whilst BRAW Toolbox can play back BRAW video files natively, to handle audio, it "extracts" the audio prior to sending to Final Cut Pro. You should press the "Choose Audio Folder" button to select the destination folder for these audio files. Once you've tweaked any metadata settings, you can press the "Prepare BRAW Files" button to extract the audio. Once that's done, you can drag the event icon from the Workflow Extension to your Final Cut Pro Event. This will create a new Event which contains your BRAW clips. The BRAW clips will come across as Synchronised Clips. If you double click on a Synchronised Clip, and click on the video clip, you can adjust all the BRAW metadata parameters within the Video Inspector.
Whilst we recommend always using the Workflow Extension to import BRAW files, you can do it manually by applying the BRAW Toolbox effect to any clip, such as a Generator. You can also access the BRAW Toolbox effect as a "filter" within Apple Motion.

The first public beta also has these notes:

This is the first public beta of BRAW Toolbox. Woohoo!
This build is very much a work-in-progress, and doesn’t contain all our latest code (due to delays and complexity of getting things approved by Apple’s App Review). However, now that the first beta is out, we hope to be able to push out new builds much more quickly in the New Year, as we work towards a public release.
The main area we’d like to test at this point is making sure that all machines can successfully import and playback BRAW files. Currently we’ve been primarily testing on MacBook Pro’s (16-inch, 2021, M1 Max, 64GB RAM) running macOS Monterey and Final Cut Pro 10.6.5. We're particularly interested to see how things work on MacPro's with multiple GPUs.
The Workflow Extension is currently very incomplete. All of the parameters from Color Science Version onwards currently don’t come across to Final Cut Pro. The buttons at the bottom of the parameters also don’t currently do anything. The Toolbox currently doesn’t do anything.
Happy testing!

I'm currently working on the 2nd beta release, and once that's done and out in the wild, I'll add some proper documentation to this repository - hopefully sometime next week.
Any questions let me know!

I'm going to close this issue for now, but yell out if you have any questions or issues!

The documentation has now been updated with Beta 2. Any questions let me know!

👍🏿 Thank you!
On Wed, Jan 4, 2023 at 11:26 PM Chris Hocking @.***>
wrote:

The documentation has now been updated with Beta 2. Any questions let me
know!
—
Reply to this email directly, view it on GitHub
https://github.com/latenitefilms/BRAWToolbox/issues/10#issuecomment-1371868769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL7Z4575YVZ7DUWZJLZPRKLWQZZTRANCNFSM6AAAAAATNH6G74
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Edgar Davis,
Post Production Supervisor


I can't start bot

Please tick all applicable boxes.

[x] I am using Python 3.5.3 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[ ] The latest master version (release-260419)
[x] The latest review version

What type of issue are you creating?

[x] Bug
[ ] Feature request
[ ] Question

Description of issue
I can't start bot
Steps to reproduce

idk

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
PS C:\Users\Komputer123\Desktop\Musicbot\MusicBot> & C:/Users/Komputer123/AppData/Local/Programs/Python/Python39/python.exe c:/Users/Komputer123/Desktop/Musicbot/MusicBot/run.py
[INFO] launcher: Starting sanity checks
[INFO] launcher: Checking for Python 3.5+
[INFO] launcher: Checking console encoding
[INFO] launcher: Setting console encoding to UTF-8
[INFO] launcher: Ensuring we're in the right environment
[INFO] launcher: Adding local bins/ folder to path
[INFO] launcher: Required checks passed.
[INFO] launcher: Optional checks passed.
[INFO] launcher: Moving old musicbot log
Traceback (most recent call last):
File "c:\Users\Komputer123\Desktop\Musicbot\MusicBot\run.py", line 438, in
main()
File "c:\Users\Komputer123\Desktop\Musicbot\MusicBot\run.py", line 347, in main
finalize_logging()
File "c:\Users\Komputer123\Desktop\Musicbot\MusicBot\run.py", line 179, in finalize_logging
dlh.setFormatter(logging.Formatter('.'))
File "C:\Users\Komputer123\AppData\Local\Programs\Python\Python39\lib\logging_init_.py", line 574, in init
self.style.validate()
File "C:\Users\Komputer123\AppData\Local\Programs\Python\Python39\lib\logging_init.py", line 427, in validate
raise ValueError("Invalid format '%s' for '%s' style" % (self._fmt, self.default_format[0]))
ValueError: Invalid format '.' for '%' style
PS C:\Users\Komputer123\Desktop\Musicbot\MusicBot>

Bro, look https://just-some-bots.github.io/MusicBot/using/troubleshooting/

Bro, look https://just-some-bots.github.io/MusicBot/using/troubleshooting/


Use tmux if WM is different than i3.

When we use e.g. ssh connection we don't have i3-wm session manager- in this case we want to use tmux.

This is already done.


change default CMAKE_INSTALL_LIBDIR for sudo make install

Is it possible to change the default CMAKE_INSTALL_LIBDIR from /lib/x86_64-linux-gnu to /lib to make the installation smoother? I am using Ubuntu 14.04 and usr/local/lib/x86_64-linux-gnu does not exist originally therefore it's not in the default LD_LIBRARY_PATH and I had to change it manually. All my other "sudo make install" libraries are in /usr/local/lib.
Thank you so much.

I have so little experience in this - I'm hoping someone else has a good answer / can review that.

Closing pending PR / follow up.


Alphanumeric & Numeric OnScreenKeyBoard Implementation

Features Supported :

Supported Alpha-Numeric KB [Lower Case , Upper Case & symbol KB] & Numeric KB. Default Layout [Alpha numeric-small Case]
Supported Themes : Dark & Light Themes . Default Theme : Dark
Key Navigation & emit keys to RSkInputManager
Supported on x11 & wpe backend

Implementation details:

Separate Full Screen Window used for OSK
Key Position & Next key on Navigation info are generated on the first time of KB Launch
unichar is used to draw Font Icons.
OSk implemented as as singleton class. So at any instance only one OSK will be present
ON closure of OSK, OSK window is completed destructed & created again on Launch
KeyBoard Observer is not fully partially Implemented & SO not Verified

Please also check the below use case
Text Input changing focus to another text input component from editing mode using focus/blur methods.


Updated dependencies to make the utility work as expected

Tested node verion  - v18.20.3
npm version- 10.7.0
OS: Ubuntu 20.04 LTS

closed as updated to newer versions with recent bugfix


Border Patrol needs documentation on public API for sessionx

this is just pure sadness at the moment

#31 closes this


Custom components: add a console for debugging

Just like in the function query editor, we could add a browser console in the bottom right to help debugging custom components.

benchmark:

codesandbox

As per initial investigation done in https://github.com/mui/mui-toolpad/pull/711 looks like it's not a straight forward thing to do.
Seems that, we need to refactor current custom component editor so that the code gets evaluated in an isolated iframe context. Once that's done we should be able to hook into console.* calls and pass them to our Console component.
Let's keep this issue open and decide on a priority among other things for now

I guess we can close this? @Janpot


Diagonals not working

It seems like no matter what the setting is alternating diagonal movements are not working. Every square is just 5 ft.

Yes, that also happens to me.
Is useful to provide more information so we can get help.
In Core settings, square Grid Diagonals, I've selected the Aleternating (1/2/1) option. When I use the default Foundry system (Rule icon - Measure distance), diagonals are accounted correctly following the rule.
When I use Drag Ruler, the options doesn't apply. Diagonals always cost 5 feet.


Update README.md

Updated with ChadGPT.

Thanks! Not sure to understand what's the goal of your GPT? Could you add more details please?

Added thanks


V0.3 UI and commons component tests

Coverage increased (+6.6%) to 73.183% when pulling 47aa323c5da80cb5925e1d29ba843600ab5e377a on V0.3_ui_tests into aa61bc41d38e41ae2cc3fd18006ba81e4f4a43dc on V0.3.

Coverage increased (+6.6%) to 73.183% when pulling a0ad50527c649a00c639222106753faa7d6802ca on V0.3_ui_tests into aa61bc41d38e41ae2cc3fd18006ba81e4f4a43dc on V0.3.


Unnecessary dependency on Flask?

Flask seems to be used only in obsolete/control_center/, which is... unused? Unless you plan to resurrect it in the very near future, I'd suggest to drop the Flask dependency and the move the control_center dir outside the package dir, so that it doesn't get installed onto users' systems.

https://github.com/JonnyKong/ndn-python-repo/commit/6065a8d80b6f42dcc7d009d460b1109d88a412c8: moved the entire obsolete/ outside the package dir.


Add github action to automatically create pdf as pre-release on commits to main

See https://github.com/burgerga/publication-template/releases for result
Uses the published biohackrxiv/bhxiv-gen-pdf docker image, added in https://github.com/biohackrxiv/bhxiv-gen-pdf/issues/39.
@egonw replaces the accidental PR I opened (https://github.com/elixir-europe/intoxicom-workshop-report-template/pull/1)

Thank you @burgerga ! This is fantastic. I noticed that the gen-pdf isn't using the event information described in the markdown for the info on the left side of the generated pdf, which we need to fix. I made an issue for it here https://github.com/biohackrxiv/bhxiv-gen-pdf/issues/44


[#noissue] Fix hystrix api type

Fix Hystrix Method Descriptor

Codecov Report

Merging #5569 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5569      +/-   ##
==========================================
- Coverage   40.77%   40.76%   -0.02%
==========================================
  Files        2844     2844
  Lines       85807    85807
  Branches    11389    11389
==========================================
- Hits        34985    34975      -10
- Misses      47781    47788       +7
- Partials     3041     3044       +3

Impacted Files
Coverage Δ

...criptor/HystrixCommandMetricsMethodDescriptor.java
0% <ø> (ø)
:arrow_up:

...or/HystrixCommandTimeoutTimerMethodDescriptor.java
0% <ø> (ø)
:arrow_up:

...iptor/HystrixCollapserMetricsMethodDescriptor.java
0% <ø> (ø)
:arrow_up:

...ptor/HystrixThreadPoolMetricsMethodDescriptor.java
0% <ø> (ø)
:arrow_up:

...criptor/HystrixCircuitBreakerMethodDescriptor.java
0% <ø> (ø)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (-3.34%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
65% <0%> (-1.43%)
:arrow_down:

...ollector/cluster/zookeeper/ZookeeperJobWorker.java
81.01% <0%> (-1.39%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e9506...8a87855. Read the comment docs.


[BUG] - Start button hidden behind version footer in Server Options selector

Context
In the "Server Options" page, the Start button is currently hidden behind it when we have several options that need the page to be scrollable:
https://github.com/nebari-dev/jhub-apps/assets/33131404/e741646f-eade-492f-8755-2931020640dc
The recording shows the maximum scroll.
I believe the version display footer was styled in https://github.com/nebari-dev/jhub-apps/blob/119128fb8db5cdf3a467ccd05744a6ada395da42/jhub_apps/templates/style.css#L339-L353
Value and/or benefit
Better expereince to start JupyterLab.
Anything else?
I'm using the Quansight Nebari instance.
In case this bug is not relevant here, please feel free to move this to the correct repo.

This page will likely be rewritten in React in the near future. If it is included in the react redesign, we can just wait until that is complete (per Dharhas)

Definitely a result of the recent footer changes. My update caused the footer to span the entire bottom which I believe was originally in the corner. A short term fix might be to disable the footer by setting disable_version: False in the JupyterHub config and/or the nebari config.
And should be able to wait for the rewrite, but if needed we should be able to fix this pretty easily in the current JupyerHub UI.

The above should resolve this issue. This should be ready to close


HA 0.115 beta breaks broadlink: Unable to find service broadlink/send

Home Assistant version
1.115.0b0
SmartIR version
'Latest Stable/RC Version tested'
SmartIR configuration
smartir:
climate:

platform: smartir
name: Dining Room Heat Pump
unique_id: dining_room_heat_pump
device_code: 1120
controller_data: <IP_ADDRESS>
temperature_sensor: sensor.dining_room_temperature
humidity_sensor: sensor.dining_room_humidity

Switch:

platform: broadlink
mac: 'b4:43:0d:f9:34:75'

Describe the bug
The new version of HA moves away from using broadlink/send to using remote.device to send commands.
Debug log

Traceback (most recent call last):
  File "/config/custom_components/smartir/climate.py", line 337, in send_command
    await self._controller.send(
  File "/config/custom_components/smartir/controller.py", line 92, in send
    await self.hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1265, in async_call
    raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service broadlink/send

Additional context
Add any other context about the problem here.

The fix is ready. I guess as HA beta tester you know what to do :)

Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 337, in send_command
await self._controller.send(
File "/config/custom_components/smartir/controller.py", line 92, in send
await self.hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1269, in async_call
processed_data = handler.schema(service_data)
File "/usr/local/lib/python3.8/site-packages/voluptuous/validators.py", line 208, in call
return self._exec((Schema(val) for val in self.validators), v)
File "/usr/local/lib/python3.8/site-packages/voluptuous/validators.py", line 287, in _exec
raise e if self.msg is None else AllInvalid(self.msg, path=path)
File "/usr/local/lib/python3.8/site-packages/voluptuous/validators.py", line 283, in _exec
v = func(v)
File "/usr/local/lib/python3.8/site-packages/voluptuous/schema_builder.py", line 272, in call
return self._compiled([], data)
File "/usr/local/lib/python3.8/site-packages/voluptuous/schema_builder.py", line 817, in validate_callable
return schema(data)
File "/usr/local/lib/python3.8/site-packages/voluptuous/schema_builder.py", line 272, in call
return self._compiled([], data)
File "/usr/local/lib/python3.8/site-packages/voluptuous/schema_builder.py", line 594, in validate_dict
return base_validate(path, iteritems(data), out)
File "/usr/local/lib/python3.8/site-packages/voluptuous/schema_builder.py", line 432, in validate_mapping
raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: not a valid value for dictionary value @ data['entity_id']

Please upgrade smartir from Hacs or RC brunch

yes. im upgrade to 1.13 rc wersion early

yea
controller_data: <IP_ADDRESS>
change to
controller_data: remote.rm_mini_remote

Did you resolve the problem ?

yes

Can confirm rc release works fine.


Add visible reference to GitHub repository

Add a reference to the GitHub repository so that all users can see it directly (maybe with the help of a bottom fixed div) in an unobtrusive way. But don't use the "Fork me on GitHub" banner.

+1, maybe add footer text (copyright, made with <3 by etc. :D) to this fixed div on the bottom of layout and add link to github repo there. Fixed bottom div is great idea because it wont be burried down there under all posts :+1:


feat(tactic/refine_struct): match { .. } in subexpressions

Note: so far, it is not recursive: if you call
refine_struct { field := foo { .. } { .. } }

the inner structures will not be treated like the outer one. It is possible to do but I'm leaving that for future me.


Support PyMongo 3.0+

I apologize if this has been covered already but searching through PRs and closed tickets I could not find any reason why PyMongo is limited to pre-3.0 versions nor can I see any public discussion about why Flask-Pymongo wouldn't be trying to update to use 3.0+ driver versions.

Hi @xealot -- this is something I intend to support as time permits. I cut a new release a few days ago which limited to PyMongo 2.x because there are incompatibilities between 2.x and 3.x, and I haven't had time to sort through it all yet. If you want to put in the legwork, I'll happily accept a pull request, but I haven't had time to think about it myself yet.

Alright, I just wanted to make sure there wasn't already some sort of dialog in place on the 3.x driver line. We will take a look at it and see what's involved.

+1 for 3.0 support. I made a very brief attempt to make Flask-PyMongo work with 3.0 and failed miserably. They really did change a lot of internals.

+1

+1
When using python3, PyMongo2.x will fail due to gevent problems.
But PyMongo-3.0.2 works.

This is fixed in #63

+1


Modify tool tips to provide data related to the org chart they're mousing over

As a user I would like the tool tips to show me more information about anyone I mouse over so it's easier to read data.
Each tool tip should be context sensitive for the org view.

Implemented


Mongodb UTCDateTime is not being saved as expected

Hello. When i want to save and consider only a date, i do something like $myCarbonDate->startOfDate(). Then, i would get something like that "2016-10-10 00:00:00".
When the object is converted to UTCDateTime i don't get the result as the example above. Instead of this, i get something like "2016-10-10 11:57:00". But remember that i forced my carbon object to reset hour minutes and second.
The thing is that UTCDateTime is being created with the current hour minute and second. So when try to filter a query using only date, i never can get the row database. What would i do in this case? What i'm missing? Thanks

Two possible solutions :
As you already mentioned you can use startOfDate method to set time part to 0, this can be done using methods like defining settter mutator on Model for that date fields. how ever i personally recommand a better approach, using whereBetween queries for non-exact dates, this way you can ensure your query always works correct! (consider situations you have databases with already some data without setting every minute and second to 0 or using )

I already use the startOfDate() function to ensure that my date will consider "00:00:00".
Your suggestions would be nice to creation date or timestamp stuff. I'm working with date flight. in a cached form fields. I need to fetch the same result when another user do  exactly the same query. So that i really need more precision. :(

I hope you can fix this using mutators :)

When another user do exactly the same query, I need to fetch the same result.
Redis Cache Can be Also utilized if you have exactly one result for each query ...

@tperrelli is this is not really an issue or bug , would you please close it ?

Using redis will not solve my problem. Another insertion example:
If i insert something like: "2016-10-10 09:10:55" (Notice that this time i passed a date time), the time is completely ignored by UTCDateTime and it sets the current time by default.
In other words 09:10:55 is not being inserted in the databasem only current time.

Soooo this may be really interesting bug :D i'll try to reproduce same situation and stack trace it tonight :)

Did you get that?

Yes, I can confirm this bug.. we even have that issue in our production .. will try to resolve it ASAP dude

OK. Thanks buddy.


where is index.js after eject in version 2.0.2 ?

hi, where is index.js after eject in version 2.0.2 ?
even i create it and then create the index.android.bundle it says Application [name] has not been registered.
failure to call AppRegistry.registerComponent

Yes, this should be included in the eject documentation if it's no longer going to be generated by default.
@EVALIJANI Did you include the appropriate contents in index.js?
This worked for me.
import { AppRegistry } from 'react-native';
import App from './App';
AppRegistry.registerComponent('your_app_name_here', () => App);

Yes, this should be included in the eject documentation if it's no longer going to be generated by default.
@EVALIJANI Did you include the appropriate contents in index.js after creating it in your project root?
This worked for me.
import { AppRegistry } from 'react-native';
import App from './App';
AppRegistry.registerComponent('your_app_name_here', () => App);

no but for me gives this error: failure to call AppRegistry.registerComponent

@EVALIJANI If you have an index.js in your project root and it contains
import { AppRegistry } from 'react-native';
import App from './App';
AppRegistry.registerComponent('your_app_name_here', () => App);

with 'your_app_name_here' changed to your appropriate app name then you should check the solutions in this stack overflow post https://stackoverflow.com/questions/35449248/failure-to-call-appregistry-registercomponent
My guess is that you're not putting the proper app name in. This should match the name you used when ejecting.


feat: added product service and minor changes in model

Created product interface and service and made minor changes to the product model


add e2e tests

Create integration tests for active pages that do not have tests
Add missing tests.

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-0.azurewebsites.net


Options component: Wrap labels of checkbox/radio in

Please wrap the labels of the checkboxes and radio buttons in a span, so it is possible to add specific styling  to them.
https://stackoverflow.com/questions/5688712/is-there-a-css-selector-for-text-nodes

+1 this makes sense, and I think that we can do that change without needing to bump the major version of the component, despite some changes in the markup, because it won't affect existing style rules.


Solidity support revisited revisited

I completely rewrote the Solidity language. It now uses C like as a base because it's less likely to change compared to JS and because JS contains a lot of features which Solidity doesn't.
I also added a few tests.
Example

This closes #1843 and resolves #1404.

@davidmurdoch When will you be tagging a version including solidity.min.js and pushing to unpkg.com?

We have 3 PRs slated for the next release, so whenever those are in, we'll cut the next one.

Cool. I'm just serving a local copy for now. Thanks!


Read action takes too long on a large csv

I have a csv of about 25000 records and a resource that uses this csv. Using Api.read takes a very long time even when reading only the first 5 records.

What is a very long time? I'm on a pretty overpowered machine, but a file w/ 20k records just returned for me in .25s. With that said, I'll make some improvements to how our reading logic works to make it leverage the streaming nature of the file.

After I wrote that I realized that .25s is pretty crazy long time for this to take :) I was just thinking when you said "very long time" that it would be much longer. I'm pushing something to main shortly that improves a fair amount, but likely there are just lots of small optimizations to be made in the way we load the data from the CSV file into their actual resource structs.

Will be looking more into this, as it highlights a few places worth optimizing. I also want to see how much of the slow down is coming from the csv parser vs Ash, but I'd venture a guess that it's mostly loading and validating stored types into memory taking the most time.

I've pushed some non trivial performance improvements up. Give them a try and let me know :)

What is a very long time? I'm on a pretty overpowered machine, but a file w/ 20k records just returned for me in .25s. With that said, I'll make some improvements to how our reading logic works to make it leverage the streaming nature of the file read.

More than a minute I'm afraid. I can share the csv and resource for you to try out.

I've pushed some non trivial performance improvements up. Give main a try and let me know how it goes :)

Let me try the main branch and report back.
Also does ash_csv work with ash_json_api? I got some error while trying to read the resource via an api endpoint

No reason it shouldn't. What's the error?


Ergonomic changes? Or maybe I'm missing something

Really excited about flagsmith. Just getting started with react.
I'm glad there are hooks available but right now I'm finding myself writing a wrapper hook to make it work better in my project. Am I ttly doing this wrong?
As far as I understand I only want to identify the user once, start listening, and subscribe once. Then throughout the app I might grab the value of feature flags.
But right now I've written a hook to ensure things are initialized, and is listening, and then another hook that uses that to just grab a value. Am I missing something?
I would like to just be able to do something like
const myFeature = () => {
  const {value, error} = useFlag('my_flag_name');

  if (error) {
    return <>ERROR: {error.toString()}</>
  }
  if (value == undefined) {
     return <>Loading</>
  }

  // use the value in some part of the component here.
};

Is there a reason that the initialization, subscribing, and identification, and getValue is all together in the same hook?

Hi, thanks for getting in touch, and using the project!
The logic was placed together as it really all serves a single cohesive purpose, so I wanted it modeled as single entity; it's a pattern used in a number of similar hooks (notably the Auth0 React library). Mostly it removes the need for potentially complex interactions between one hook holding the connection and state and a separate one for holding the actual flags - I think that could lead down a path to lower cohesion and higher coupling which is generally worth avoiding.
If you're able to share your code I'd love to take a look.
JC

This is what I have so far.
It's pretty rough. but this is the basic idea.  I might switch out the null values for an isReady flag? or something IDK.
import { createState, useState } from '@hookstate/core';
import { Flagsmith, useFlagsmith } from 'flagsmith-react';
import { useEffect } from 'react';
import { useCurrentOrg } from '../api/orgs';
import { useOwnUser } from '../api/users';
import { topLevelError } from '../errors';

interface FlagResult {
  value: null | string | number | boolean;
  enabled: null | boolean;
}

type FlagsmithIdentified = Omit<
  Flagsmith,
  | 'isIdentified'
  | 'isLoading'
  | 'identify'
  | 'isListening'
  | 'startListening'
  | 'isError'
> & { isReady: boolean };

const identityLock = createState<'waiting' | 'identifying'>('waiting');

export const useFlagsmithIdentified = (): FlagsmithIdentified => {
  const {
    isLoading,
    isError,
    isIdentified,
    identify,
    startListening,
    isListening,
    ...rest
  } = useFlagsmith();

  const { data: user, error: userError } = useOwnUser();
  const { data: org, error: orgError } = useCurrentOrg();
  const identityState = useState(identityLock);

  useEffect(() => {
    if (
      !isLoading &&
      !isIdentified &&
      identityState.value === 'waiting' &&
      user &&
      org
    ) {
      identityState.set('identifying');
      console.log('identifying');
      identify(user.id.value, {
        org: org.name.value,
      }).then(() => {});
    }
  }, [identityState, isIdentified, user, org, isLoading]);

  useEffect(() => {
    if (!isListening) {
      startListening(10_000);
    }
  }, [isIdentified, isListening]);

  if (isError || userError || orgError) {
    console.log('Flagsmith error', isError || userError || orgError);
    topLevelError.set(
      (
        (isError && 'Flagsmith failed to load') ||
        userError ||
        orgError
      ).toString()
    );
    return {
      isReady: false,
      ...rest,
    };
  }

  if (isIdentified && isListening) {
    return {
      isReady: true,
      ...rest,
    };
  }

  return {
    isReady: false,
    ...rest,
  };
};

export const useFlag = (flagName: string): FlagResult => {
  const { subscribe, getValue, hasFeature, isReady } = useFlagsmithIdentified();
  const value = useState<null | string | number | boolean>(null);
  const enabled = useState<null | boolean>(null);

  useEffect(() => {
    if (value.value === null && isReady) {
      value.set(getValue(flagName));
    }

    if (enabled.value === null && isReady) {
      enabled.set(hasFeature(flagName));
    }
  }, [isReady]);

  subscribe(() => {
    value.set(getValue(flagName));
    enabled.set(hasFeature(flagName));
  });

  return { value: value.value, enabled: enabled.value };
};

I can then, in my codebase, simply run
const {enabled: appsEnabled} = useFlag('apps_enabled');

if (appsEnabled === true) {

};

Note: I'm currently refactoring this because it seems to be creating way more than one identification call.
But I see 2 different pieces of the flagship library.

Loading, identifying, resolving errors, creating a subscription to changes, removing subscriptions, removing identity, etc.
Getting the current value / enabled state of flags.

If I were to use the useFlagship() hook all over my codebase I would have to check if it was loaded, had some error, and been identified elsewhere every time I wanted the value of a flag.
So I think the result is that pretty much every user of the library would want to wrap this hook somehow in one place in their codebase to handle the initialization, and then somehow expose the values that come out of it.
Now I agree that using useFlagshipFlag('my_flag_name_here') would introduce coupling between an app and flagship itself. However, that would easily be remediated with a file containing a list of hooks, one for each feature. which would then become useMyFlagNameHereFeature(). Now you aren't coupling, and you are also removing duplication of strings throughout the app.
I guess one argument could be "just use some sort of state management to pass around feature values". At that point however, I'm not sure what this library is providing. Especially when considering that the point of using a ContextProvider is to allow for usage of a context in many places. So if you use a state management library to store the flag data and just use the hook in one place you don't need a context, at which point you might as well just use the base SDK.
Ultimately while I'm coding in my app I want to be able to subscribe to the value / enabled state of a flagship feature in a component without having to worry about whether or not the flagship libraries complex initialization process is complete.
I would think that either the context provider itself (or my own piece of the code) would be responsible for initializing the flagship instance and then provide that as context to the rest of the app. at which point the only thing a hook subscribing to that context would provide is feature flag specific APIs.
One option would be to expose functions / properties on the context provider to allow for initialization and by configuration either

Prevent loading the app until either a cached version of flags is present or the initial server response is received.
Just return null/undefined for all flag values asked for until the initial server response is received.

This could be conceived as something such as
<FlagsmithProvider
  environmentId={FLAGSMITH_ID}
  cacheFlags={true}
  defaultFlags={{
    apps_enabled: { enabled: false },
  }}
  identify={async () => {
    const user = await getUser();
    return identify(user.id, { org: user.org.name });
  }}
  listen={10_000}
  onError={(err) => alert(err.toString())}
>
  {children}
</FlagsmithProvider>

Anyway that's quite a lot. Would love to know your thoughts so far.

@from-nibly It seems sort of redundant to make it into a library (that extends this library only to extend the base flagsmith library)
I'd be curious if @TheMagoo73 has more thoughts as to your ideas because I think that's how this library should work

Hi all, sorry for the lack of input - the 'real world' has been a bit crazy of late!
I'll be honest and say that I created this in a bit of a rush to solve a very specific need on a project I was working on. It was something of a learning exercise (I'm new to React), and was needed yesterday... like so much in life lol.
Right... poor excuses out of the way, let's fix stuff! 😃
I've been thinking about a v2 for a while; the initialisation/identification/subscription process works in our initial use case. We can handle it in the top level component, so children know it's all good to go when they render. However, I've just started a NextJS side project, and I'm running into the same issues you're seeing. Far too much management of what should be going on 'behind the curtain'.
@from-nibly I very much like your idea of having a useFlag() hook, I think it would make the code more usable. And default flags are a must.
I should get some down time this weekend, I'll start bouncing some ideas around... Watch for a V2 branch...

However, I've just started a NextJS side project

👋  I've been working in NextJS for 2.5 years now. I just started writing https://github.com/Flagsmith/flagsmith-php-client/pull/5 and additionally https://github.com/clearlyip/laravel-flagsmith and have run into similar issues on the Frontend as mentioned here.


netgraph, remove hooks

I think we should remove the attach/detach hooks in the code, there doesn't seem to be a valid reason for detaching netgraph (other then a probably very minor performance gain).
When we do, we could trash the following functions, which moves us further to standards:

interface_netgraph_needed
legacy_netgraph_detach
legacy_netgraph_attach

up for debate.

We can gladly strip them. I would wish that we could have a speed measurement though to verify the netgraph impact.
We could also try to improve the situation by making netgraph an on-demand load. I know that the netflow module already does that, MPD5 should be clever enough to do the rest for all multi-point connections. 😊

On 15.09.2016, at 13:58, Ad Schellevis<EMAIL_ADDRESS>wrote:
I think we should remove the attach/detach hooks in the code, there doesn't seem to be a valid reason for detaching netgraph (other then a probably very minor performance gain).
When we do, we could trash the following functions, which moves us further to standards:
interface_netgraph_needed
legacy_netgraph_detach
legacy_netgraph_attach
up for debate.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

as soon as I can find some time, I will a simple test with and without, if the impact is low... strip all :)

I will strip everything from the code tomorrow. This will also remove the infamous ngattach utility and the inherited kernel patch... In theory the same is possible with kldunload as the subsequent kldload will reattach all devices. But if the impact is small this doesn't matter and we end up with the longed-for standard netgraph setup after all. 😊

@fichtner great! thanks

@jschellevis @AdSchellevis -devel has had ngattach completely  removed a while back. I really don't want to bring it back in 17.1 -- do we have numbers to back up the removal?

@fichtner sorry, it has been too busy lately, but I really don't expect we're going to move the hooks back in. I will try to do some measurements before release.

checked today, no noticeable difference.


updates to guide

Validation Status: Successful
JobID: 4e4c86cf-e8b8-4493-b47a-a24b5f83420f

Articles to review
The articles impacted by this PR were staged review at:

http://taco.visualstudio.com/en-us/docs/ios-guide/


Backport fix XSTR-739 to 1.4.4

Fixes https://issues.jenkins-ci.org/browse/JENKINS-21047

http://x-stream.github.io/jira/739/ was fixed in 1.4.6, the current version we're distributing is based on 1.4.7.


farrah/ fix: test

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.443%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
5609

Relevant Lines:
6106

💛  - Coveralls


Now running JavaScript generators for active languages after import

The import function did not update the javascript translation files, this is fixed by this pr.

Thanks!


[SPARK-5649][SQL]  added a rule to check datatypes cast

Throw an exception when datatypes cast is legitimate, this patch info user the cast issue in the sqls.
Before this patch, we only get an attribute unresolved exception which is really hard to understand the problems in users' sql

Test build #26908 has started for   PR 4425 at commit 9fb60ce.

This patch merges cleanly.

Test build #26908 has finished for   PR 4425 at commit 9fb60ce.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26908/
Test FAILed.

Test build #26910 has started for   PR 4425 at commit 172e4dd.

This patch merges cleanly.

Test build #26911 has started for   PR 4425 at commit 97bb90b.

This patch merges cleanly.

Test build #26910 has finished for   PR 4425 at commit 172e4dd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26910/
Test PASSed.

Test build #26911 has finished for   PR 4425 at commit 97bb90b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26911/
Test PASSed.

It should be either a bug of the Analyzer or the bad semantic of the user. As I think all of the children should be resolved before the checking, can you also give an example or unit test that will throw exception?

unit test added

Test build #26917 has started for   PR 4425 at commit bd8d9f8.

This patch merges cleanly.

Test build #26917 has finished for   PR 4425 at commit bd8d9f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26917/
Test PASSed.

we can throw an AnalysisException not treenodeexception after #4439 has in

Test build #27260 has started for   PR 4425 at commit db86dc4.

This patch merges cleanly.

Test build #27260 has finished for   PR 4425 at commit db86dc4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27260/
Test FAILed.

Retest this please

Test build #27266 has started for   PR 4425 at commit db86dc4.

This patch merges cleanly.

Test build #27266 has finished for   PR 4425 at commit db86dc4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27266/
Test FAILed.

retest this please

Test build #27272 has started for   PR 4425 at commit db86dc4.

This patch merges cleanly.

Test build #27272 has finished for   PR 4425 at commit db86dc4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27272/
Test PASSed.

Updated, @marmbrus any comment here?

Thanks for bringing this up!  I rolled the fix into #4558.


Page 53 section 3.7.1 refers to 2.1.3 but this should be 3.1.3

please fix

Thanks, @Faunt0   ! I'll group this with #5 , which mentions the same :)