net: sockets: deadlock when trying to close a listening socket in blocking mode

Describe the bug
If a Thread A is using a blocking socket to listen for incoming connections and another Thread B is calling close() on the same socket in order to stop listening, Thread B will hang forever (or at least until a new connection happens). I am using TLS sockets in that case, but the issue would also applies to regular sockets.
What happens:

Thread A locks the mutex of fdtable[0] (the TLS socket)
Thread A locks the mutex of fdtable[1] (the underlying socket)
Thread A waits on accept_q in zsock_accept_ctx()
Thread B locks the mutex of fdtable[0] and blocks until Thread A returns from accept(), which will not happen unless we get a new connection

I think that there are 2 issues:

The socket blocks on accept_q while holding the socket's mutex. This can probably be solved by a condition variable, as currently done in the RX path which releases the mutex during the wait
Even if we address point 1. we will hit the same issue as #54275 because the mutex of the TLS layer won't be released by the condition variable used in the socket layer

To Reproduce
Here is a small reproducer that can be tested on native_posix:
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(main);

#include <zephyr/kernel.h>
#include <zephyr/net/socket.h>

#define STACK_SIZE		4096
#define THREAD_PRIORITY		5

K_THREAD_STACK_DEFINE(thread_stack_accept, STACK_SIZE);
K_THREAD_STACK_DEFINE(thread_stack_close, STACK_SIZE);

static struct k_thread thread_accept_data;
static struct k_thread thread_close_data;
static int server_fd;

static void th_accept(void *p1, void *p2, void *p3)
{
	const char *const name = p1;
	struct sockaddr_in address;
	int addrlen = sizeof(address);
	int new_socket;
	int err;

	server_fd = socket(AF_INET, SOCK_STREAM, IPPROTO_TLS_1_2);
	if (server_fd < 0) {
		LOG_ERR("Socket creation failed %d %d", server_fd, errno);
		return;
	}

	memset(&address, 0, sizeof(address));
	address.sin_family = AF_INET;
	address.sin_addr.s_addr = INADDR_ANY;
	address.sin_port = htons(8080);

	err = bind(server_fd, (struct sockaddr *)&address, sizeof(address));
	if (err < 0) {
		LOG_ERR("Socket bind failed");
		return;
	}

	err = listen(server_fd, 1);
	if (err < 0) {
		LOG_ERR("Listen failed");
		return;
	}

	LOG_INF("[%s] Before accept", name);
	new_socket = accept(server_fd, (struct sockaddr *)&address, (socklen_t *)&addrlen);
	if (new_socket < 0) {
		LOG_ERR("Accept failed");
		return;
	}
	LOG_INF("[%s] After accept", name);
}

static void th_close(void *p1, void *p2, void *p3)
{
	const char *const name = p1;

	k_msleep(2000);

	LOG_INF("[%s] Before close", name);
	close(server_fd);
	LOG_INF("[%s] After close", name);
}

void main(void)
{
	k_thread_create(&thread_accept_data, thread_stack_accept, STACK_SIZE,
			th_accept, "thread 1", NULL, NULL,
			THREAD_PRIORITY, 0, K_NO_WAIT);
	k_thread_create(&thread_close_data, thread_stack_close, STACK_SIZE,
			th_close, "thread 2", NULL, NULL,
			THREAD_PRIORITY, 0, K_NO_WAIT);

	while (1) {
		k_sleep(K_FOREVER);
	}
}

CONFIG_NETWORKING=y
CONFIG_NET_TCP=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_SOCKOPT_TLS=y
CONFIG_POSIX_MAX_FDS=6

CONFIG_NET_CONFIG_SETTINGS=y
CONFIG_NET_CONFIG_NEED_IPV6=y
CONFIG_NET_CONFIG_MY_IPV6_ADDR="2001:db8::1"
CONFIG_NET_CONFIG_PEER_IPV6_ADDR="2001:db8::2"

CONFIG_MBEDTLS=y
CONFIG_MBEDTLS_BUILTIN=y
CONFIG_MBEDTLS_ENABLE_HEAP=y
CONFIG_MBEDTLS_HEAP_SIZE=60000
CONFIG_MBEDTLS_SSL_MAX_CONTENT_LEN=2048

CONFIG_LOG=y
CONFIG_NET_LOG=y

Here is the output using the latest version of Zephyr:
*** Booting Zephyr OS build zephyr-v3.3.0-4423-g534d6f3b2c38 ***
[00:00:00.000,000] <inf> net_config: Initializing network
[00:00:00.110,000] <inf> net_config: IPv6 address: 2001:db8::1
[00:00:00.110,000] <inf> net_config: IPv6 address: 2001:db8::1
[00:00:00.110,000] <inf> main: [thread 1] Before accept
[00:00:02.120,000] <inf> main: [thread 2] Before close

Expected behavior
I would expect that calling close() on the socket would interrupt the on-going accept(). This case was supported but broke when adding the locking in the socket layer.

Thank you for your quick fix @rlubos
This works using the reproducer, so it looks good.
I will test on the hardware today and report if I see anything else.


Type.ctor in undefined when type is not exported

Bug
Current Behavior
class Foo {}

const FooCtor = getType<Foo>().ctor; // undefined

FooCtor is undefined.
Expected Behavior
Because getType<>() is used on local (even unexported) class, it should have ctor reference.

@iDevelopThings What do you think about it? It was implemented this way but broken by the rework so it's breaking change.
But is it good idea to keep the old behavior? I'm 50:50.
I'd like to keep the same behavior for all the cases, which means: unexported types will never have ctor reference. But it is declared in module scope and you are using it in module scope so I think it should have the ctor. What is right? 😄


While node is adding to Jenkins master , Its not adding to master error coming how can i fix it ?

SO, the solution is to set this option to "Manually trusted key verification strategy". It's an option under "Launch Method" in the node configuration:
Dashboard -> Manage Jenkins -> Manage Nodes -> Gear Symbol in the row of your Slave node

prased sai follow the instructions:

first login into jenkins master as jenkins user.

sudo -i
su  jenkins
cd ~

once the switched to jenkins user please try to login with node credentainls

ssh <nodeusername>@<nodeuserprivateip>

goto manage jenkins-> manage node-> configure the node

once the node configuration is done launch the agent.
Note: Before doing the above configuration

check the user is add in visudo and enable password authentication is yes for both jenkins master and jenkins node

restart the sshd service

please close the issue.

Tnk u


Ignore return type hints for Drupal hooks

  # Ignore certain standards for legacy procedural functions in module, theme, profile and includes.
  # Specifically centered around hook/alters and lack of proper types.
  reportUnmatchedIgnoredErrors: false
  ignoreErrors:
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has no return typehint specified\./'
      path: *.module
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) return type has no value type specified/'
      path: *.module
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has parameter .* no value type specified/'
      path: *.module
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has no return typehint specified\./'
      path: *.theme
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) return type has no value type specified/'
      path: *.theme
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has parameter .* no value type specified/'
      path: *.theme
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has no return typehint specified\./'
      path: *.profile
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) return type has no value type specified/'
      path: *.profile
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has parameter .* no value type specified/'
      path: *.profile
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has no return typehint specified\./'
      path: *.inc
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) return type has no value type specified/'
      path: *.inc
    -
      message: '/^Function [a-zA-Z0-9\\_]+\(\) has parameter .* no value type specified/'
      path: *.inc

I don't know if this extension should be enforcing this across the board. For instance, I care about these things in my custom code. Maybe it should just exclude contrib? Or maybe provide this as an option configuration folks can include to help silence.

Well, generally speaking without this it's incompatible with phpcs, which requires the docblock for hooks/alter implementations to be a single line: Implements hook_*()..

Well, that may be overstating it a bit. I think it just prefers that its the first line. In theory, you could still add params and the rest of the docblock... but generally, IDEs don't do this and most developers don't either as its duplicating the same documentation as the hook/alter.
Regardless, add this as an option would certainly be helpful at the very least. It's really loud for code that is based on different (antiquated) coding standards as a whole.

My take wasn't phpdoc but rather return types and inline parameter types.
function mymodule_commerce_checkout_pane_info_alter(array &$definitions): void {

}

@markcarver can you also post an example of the code? Just so we can document. It's not about coding standards, but the actual code in the parameters and return type.

I think this is a won't fix, works as designed, until example code provided to show it's not about PHPDoc

I'll see if there's a way to ignore return types if it is a Drupal hook implementation.

I think the smart choice is to not ignore the return types on Drupal hook implementations. Drupal hooks are called like this:
        // Allow modules to alter widget actions.
        \Drupal::moduleHandler()->alter('paragraphs_widget_actions', $widget_actions, $context);

And then documented in the modules/contrib/paragraphs/paragraphs.api.php file like this:
/**
 * Alter paragraphs widget.
 *
 * @param array $widget_actions
 *   Array with actions and dropdown widget actions.
 * @param array $context
 *   An associative array containing the following key-value pairs:
 *   - form: The form structure to which widgets are being attached. This may be
 *     a full form structure, or a sub-element of a larger form.
 *   - widget: The widget plugin instance.
 *   - items: The field values, as a
 *     \Drupal\Core\Field\FieldItemListInterface object.
 *   - delta: The order of this item in the array of subelements (0, 1, 2, etc).
 *   - element: A form element array containing basic properties for the widget.
 *   - form_state: The current state of the form.
 *   - paragraphs_entity: the paragraphs entity for this widget. Might be
 *     unsaved, if we have just added a new item to the widget.
 *   - is_translating: Boolean if the widget is translating.
 *   - allow_reference_changes: Boolean if changes to structure are OK.
 */
function hook_paragraphs_widget_actions_alter(array &$widget_actions, array &$context) {
}

If you duplicate and correct the information from the hooks at least phpstan will be able to check the code in the implemented hook. Phpstan does not know anything about the hooks in the api files.

Correct. Properly type hint your hook implementations.

Hm. The Drupal Coding Standards are very specific about that: https://www.drupal.org/docs/develop/standards/api-documentation-and-comment-standards#hookimpl
There is also an issue about this (https://www.drupal.org/project/coding_standards/issues/3056368) where some of the details are explained (e.g. "duplication of documentation").

Nope! You don't need to do it in the phpDoc but with native PHP return type declarations.

I just wanted to clarify for future googlers, this is an example of hook_requirements that passes level 9 phpstan.
/**
 * Implements hook_requirements().
 */
function mymodule_requirements(string $phase): array {
   ...


Increase nginx timeouts

This seems to be necessary when uploading really large layers.

It is annoying that this is not application-specified, I think we have ample evidence by now that one size does not fit all when it comes to timeouts. This is the best way we have now. :+1:


Autocomplete Command Broken

Just built restic from source today. When attempting to generate an autocomplete file, following the documentation, it gives me the following output:
 ./restic autocomplete
unknown command "autocomplete" for "restic"

Right you are, I have submitted a correction for the documentation.

Thanks!


feat: Support scan latest revision for replicationController

In OCP, there is a kind called DeploymentConfig, which manages the replicationController, and as we have revisionHistory for Deployments, similarly there are revision history for Deployment Config as well. Due to which many replication contollers will be present in the cluster. We dont want to scan them as they are not active resource. So as part of this change, I have added following change

consider latest revision scan option to limit scanning of old replication controller
ignore system pods created from deploymentConfig

@deven0t lgtm 🚀


Blog app - Add forms

Blog app - Add forms

In this pull request, the following tasks were implemented:

Created a method called current_user in your ApplicationController to make current user data available to all controllers
Created forms to perform the following functions:
Creates a Post on behalf of the current_user
Create a comment on behalf of the current_user
Allowed Users to add likes to Posts.

Thanks so much for this review


Update README.md

Hi, sorry for the confusion. The excludes inputs currently only available on the main branch. So, instead of reverting the README.md, i'll release the new version of this project soon. Sorry for the inconvenience.

The version 1.0.0 just released, you can use that instead.


URL with port number in terminal opens to wrong port

Issue Type: Bug

Run livereload in a folder
Livereload prints to the terminal:

[I 210104 13:35:24 server:335] Serving on http://<IP_ADDRESS>:35729

Ctrl+click the hyperlink for port 35729
Default browser (in this case, Microsoft Edge Dev) opens a new tab to http://<IP_ADDRESS>:35730

Expected: default browser would open to port 35729, not 35730.
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows_NT x64 10.0.19042
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info

Item
Value

CPUs
AMD Ryzen 5 3600 6-Core Processor               (12 x 3593)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (24.12GB free)

Process Argv
--crash-reporter-id c7f5e4c5-bee4-4bc0-b9c3-50b06aeb2da9

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-20.04

OS
Linux x64 4.19.104-microsoft-standard

CPUs
AMD Ryzen 5 3600 6-Core Processor (12 x 3593)

Memory (System)
25.02GB (24.49GB free)

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

remote-containers
ms-
0.154.1

remote-ssh
ms-
0.62.0

remote-ssh-edit
ms-
0.62.0

remote-wsl
ms-
0.52.0

debugger-for-edge
msj
1.0.15

diff
raf
0.0.1

better-toml
bun
0.3.2

python
ms-
2020.12.424452561

jupyter
ms-
2020.12.414227025

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python763:30178808
python383:30185418
pythonvspyt700:30237718
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30211401
wsl2promptcf:30224613
pythonvsdeb440cf:30237828
unusedprompt:30224610
folderexplorercf:30224615
openfilemenucf:30224648
pythonvsded773:30236629

This might be by working as expected due to WSL port forwarding?

This might be by working as expected due to WSL port forwarding?

We shouldn't actually be doing any port forwarding for WSL.

We shouldn't actually be doing any port forwarding for WSL.

I assume that the open is going through here:
https://github.com/microsoft/vscode/blob/91f00c7c285ecd85a8d86298183180703d719486/src/vs/workbench/electron-sandbox/window.ts#L505-L525
@mjbvz is there a way to not do the resolve external URI for WSL?

I assume that the open is going through here:
https://github.com/microsoft/vscode/blob/91f00c7c285ecd85a8d86298183180703d719486/src/vs/workbench/electron-sandbox/window.ts#L505-L525
@mjbvz is there a way to not do the resolve external URI for WSL?

@alexr00 Could the wsl remote extension implement a ITunnelProvider that either returns undefined or returns the original url?

@alexr00 Could the wsl remote extension implement a ITunnelProvider that either returns undefined or returns the original url?

Huh, nice idea (wish I'd thought of it)! I'll take a look.

Huh, nice idea (wish I'd thought of it)! I'll take a look.

I actually hit this yesterday, links are broken on the WSL terminal 🙁

I actually hit this yesterday, links are broken on the WSL terminal 🙁

Bonus: while testing I found that trying to connect to something that was listening on <IP_ADDRESS>:3000 and running in WSL didn't work. BUT you can connect on localhost. So with the tunnel factory, clicking on <IP_ADDRESS> links in the terminal from WSL will work.

Bonus: while testing I found that trying to connect to something that was listening on <IP_ADDRESS>:3000 and running in WSL didn't work. BUT you can connect on localhost. So with the tunnel factory, clicking on <IP_ADDRESS> links in the terminal from WSL will work.


Issue/599

fixes #599

3 failed tests, all of them suggest that Sut_deltaTime is too low now.

@keremispirli Do you like my new changes better?

Looks like it had to be even lower! :D

Wait, doesn't this also close #30, #561 and #578 ?


Some Check Failed errors in tf.raw_ops.MatrixSetDiagV3

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.15
Custom code
No
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Some Check Failed errors in tf.raw_ops.MatrixSetDiagV3, which causes the program to crash. See the colab link below for details.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/11e72xipp_lz6fHcp7bN2MQy3Kw5KqHpL?usp=sharing

Relevant log output
# Check failed: d < dims() (1 vs. 1)
# Check failed: d < dims() (2 vs. 2)

Hi @xl1043237213 ,
I have replicated the reported behaviour with tf-nightly and attached below is screenshot of same.


Make EditorInterface.get_editor_scale() static

To avoid having to do workarounds like this https://github.com/Zylann/godot_voxel/blob/41e364624fd5b038ad296eefeb7bfddebea9c697/util/godot/editor_scale.cpp#L10
EditorInterface is internally a singleton though, so if it is desired to expose it entirely as a singleton, it could be changed.

if it is desired to expose it entirely as a singleton, it could be changed.

I had to use a similar workaround to pass the EditorInterface.get_base_control() between scripts, to access theming properties. I feel that turning the EditorInterface into a singleton would simplify access a lot.

EditorInterface is internally a singleton though, so if it is desired to expose it entirely as a singleton, it could be changed.

Yes, I think this is the way to go. Ideally, we'd expose some kind of Editor singleton (probably pointing to EditorNode) and pass everything through it. But for now we can just use EditorPlugin and make the get_editor_interface() method static. This will affect user code, and it seems that calling static methods on instances is not currently handled well in GDScript, but that's the case with the current state of the PR as well.

I had to use a similar workaround to pass the EditorInterface.get_base_control() between scripts, to access theming properties. I feel that turning the EditorInterface into a singleton would simplify access a lot.

You don't need to do that, your control already has access to the editor theme as long as it's inside of the tree (and if it's not, then theming doesn't really matter).

This will affect user code, and it seems that calling static methods on instances is not currently handled well in GDScript, but that's the case with the current state of the PR as well.

Calling static methods on instances should work fine. It's the fact that it works fine which can be problematic for some static methods which we don't want to allow calling on instances (typically static methods that return an instance).

Ah, okay then. Even more reason to do it properly and not just for one use case.


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2023-06-22)
Features

better layout (f507c87)
support dynamic window resizing (6a1b5f8)

Bug Fixes

error downloading after switching back from sms (fc1c108)
sms not defined error while closing (e6e9041)
Switching between sms and pwd may trigger loop (7a42a70)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/itsHenry35/ledu/releases/tag/v1.2.0 :sunflower:


also give back registered users total

API must give back the total number of users.

done a long time ago


Should dist and build folders store in repo?

Is it really needed to store it in repo, maybe setup build process on prepublish hook and store dist into gh-pages repo? If you agree I can send PR for it.

This was discussed in #109 as well, and a PR would be useful if you'd like to open one up!

@blackrabbit99 gogogo! Let's see if we can get this sorted before 1.1 :)

@CMTegner  I'm thinking about build on postinstall hook is it ok for you?

@blackrabbit99 don't think that would work since devDependencies are not included by default. Did you mean prepublish?

@CMTegner  yeap, I think prepublish would be enough for simple build using browserify.

Yeah I don't think it makes sense to store dist in source control. It's totally fine (and in fact, highly encouraged) to offer a precompiled version, but that should be done through a proper release strategy such as npm or GitHub releases (or both, which is what I do for babel-standalone). Build artifacts don't belong in source control.

The transpiled source and UMD bundles have been removed from the repo and are only available from the npm package.


[Azure Arc] Update MIAA model to include encryption properties

This PR adds support to manage encryption options to be able to connect with SQL Managed Instance in Azure Arc extension, if server certificates are not installed. As of now, there's no workaround if TLS certificate is not available in client environment.
Reported Issue: https://learn.microsoft.com/en-us/answers/questions/1161292/unable-to-manage-arc-sql-mi-database-from-azure-da
// TODO: Test and validate changes
(waiting for test environment details cc @candiceye)

Please add screenshots of the new UI elements being modified/added

Also could you file an issue in this repo so it can be tracked and linked to? (responding to the original issue would be great)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 32 (0.0%)  changed or added relevant lines in 3 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 42.001%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/arc/src/models/miaaModel.ts
0
2
0.0%

extensions/arc/src/ui/tree/controllerTreeNode.ts
0
5
0.0%

extensions/arc/src/ui/dialogs/connectSqlDialog.ts
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/arc/src/models/miaaModel.ts
1
0%

extensions/notebook/src/dialog/configurePython/configurePathPage.ts
1
57.02%

extensions/arc/src/ui/dialogs/connectSqlDialog.ts
4
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
28599

Relevant Lines:
63237

💛  - Coveralls

Please add screenshots of the new UI elements being modified/added

Added GIF to description

Can you update the gif with the latest changes? Want to see how the dual-toast notifications look, generally we want to avoid spamming too many notifications at once (especially if they're for the same thing)

Can you update the gif with the latest changes? Want to see how the dual-toast notifications look, generally we want to avoid spamming too many notifications at once (especially if they're for the same thing)

Updated


[textDocument/formatting] FormattingOptions turned explicitely optional

Hi!
The whole point of an external formatter is to have an external source of truth that tells you whether your file is formatted correctly, and enforces its formatting if necessary, so a team can agree on a shared formatting independently of their IDE or text editors.
In vim, as opposed to VSCode, the tabulation/space settings are very special. There is no support for project-specific configuration without plugin.
Besides, there are plugins like https://github.com/tpope/vim-sleuth that dynamically changes the tabulation options, adapting itself to the style of the edited file.
Currently, coc.nvim is systematically sending vim-specific tabulation configuration via the "options" fields in "textDocument/formatting" messages. Then, what happens when you edit a wrongly edited files while using vim-sleuth plugin? It keeps the wrong indentation!
I think, some language servers may currently not handle well the absence of these options.
I suggest a clarification in the specification which states that the FormattingOptions parameters for textDocument/formatting are all optional. Make it clear that this field can be empty or omitted entirely.
For more background about the problem, you can refer to these issues that pop up frequently ("formatting does not work") in the vim world:
https://github.com/neoclide/coc-java/issues/132
https://github.com/neoclide/coc-prettier/issues/1#issuecomment-721696534
I suspect the situation may be similar in emacs or other editors.

I just realized that I forgot to add that the changes would also affect rangeFormatting and onTypeFormatting.

I looked into this and it is very hard to change now since it is a breaking change. I can't simply make the fields optional since in the specification right now tabSize and insertSpaces are defined mandatory.
All I can recommend on an implementation side in Vim is to not send the request to a server if the two values are not known and tell the user that these need to be configured (in an VIM specific way).
I will close the issue. Please ping if there is some other solution on how to solve this.

@dbaeumer  Thanks for your answer.
We could create two new fields, with a different name that are optional:

optTabSize,
optInsertSpaces

And deprecate the two old fields tabSize and insertSpaces. We can keep them for a few minor versions and remove them in a new major version of the spec.
The implementation could be so that optTabSize should be considered first if non-null else the old ones.

Besides the fact that the protocol uses semver what should a server do if they are missing. These two values are so fundamental to formatting that I would say if they are not know VIM should sent send. VIM could also use an approach were it infers the settings based on the current file (VS Code does the same if not known)

I don't think this is a protocol issue per se. The servers can just ignore the user's editor settings if they know better, e.g. based on filesystem of project configuration.
As an example, I'm pretty certainly that clangd actually just ignore what the client editor supplies and use what's specified in .clang-format. The java language server could do the same via a setting.

That is true as well.

The Java Language Server uses the Eclipse Formatter standard: https://github.com/redhat-developer/vscode-java/wiki/Formatter-settings
It's an xml file defining the formatting rules.
Currently the server doesn't ignore the rules when fed with the lsp formatting options, contrary to clangd.
This is the server: https://github.com/eclipse/eclipse.jdt.ls
I'll open an issue to ask them if they can ignore the values when a specific formatting file is specified.
Thanks for your inputs.


Implementing a different CRS for each L.TileLayer.WMS instance is confusing or incomplete?

This is in reference to the features introduced in pull request #945
@mourner I'm a little confused on how to properly implement a TileLayer.WMS with a crs that differs from the map's crs. Currently i do have it working but, only with the addition of @mhotby 's modification which he posted to the pull request. Without that, it seems impossible to implement.. Was this not the point of your integration of the crs option in the TileLayer.WMS?
For example If i define two TileLayers as follows:

Open Stree Maps with EPSG:3857
osm = new L.TileLayer('http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png')

and a WMS with EPSG:2263
nycCrs = new L.Proj.CRS("EPSG:2263" etc..)
nycMap = L.tileLayer.wms('http://maps.nyc.gov/geowebcache/service/wms/', {
crs:nycCrs,
tileSize: 512,
etc...}
Define a map with the default, osm compatible crs of EPSG3857:

var map = L.map('map', {
    layers:[osm]}

var baseMaps = {
    "nyc": nycMap,
    "osm": osm};

L.control.layers(baseMaps).addTo(map);

With the configuration above all requests to the nycMap WMS server fail due to incorrect scale and or origin issues.
However If i use the setCrs() method and and 'baselayerchange' event listener suggested by mhotby (modified for my setup):
L.Map.prototype.setCrs = function(newCrs) {
    this.options.crs = newCrs;
}

map.on('baselayerchange', function(layer) {
    if(layer.name == 'osm')
        map.setCrs(L.CRS.EPSG3857);
    else if(layer.name == 'nyc')
        map.setCrs(nycCrs);
    map.setView(map.getCenter(),map.getZoom());
});

Now everything works as expected. I'm just wondering if this is what you intended or if i have missed something in my configuration. Also, if this is the correct way to implement it , why are mhotby 's mods not implemented along with the TileLayer.WMS.options.crs. It seems to be incomplete without them...
Thanks for everything, leaflet is nothing short of awesome!

Hi,
please note that the issue tracker is not intended for support questions, but rather bug reports or discussion for new features.
Having said that, I more or less duplicate my comment in #945:
@arctelix are you trying to mix more than one CRS on the same map? That has been discussed a couple of times, for example see #2553.
My opinion on this is that CRS switching should not be supported by Leaflet core, since I can't see it working in an intuitive way. It could, however, probably quite easily be be supported by a plugin. So far, no one have written such a plugin, as far as I know. @mhotby's code is probably a reasonable start for a plugin.
I was actually a bit surprised to learn about the WMS functionality added by #945, since it seems to add at least partial support for multiple CRS!

@perliedman Thanks for the responce, in both locations ;) I figured nobody would see it in a closed pull request.
That is exactly what confused me... Partial implimentation of a feature.  What other use could there be for permitting each instance of a tile layer to have a unique crs? Thats why i thought it was a bug, not support.


Watch app

Exploring this space a little. Anything valuable we could do? Complication maybe?

Dupe of #190?


Work on supporting foreign calls

Use optimized JuliaInterpreter frames to support foreign calls. Fixes #277 and #224, but breaks eval tests. Open question: should
        analyzer = AbstractAnalyzer(analyzer, concretized, context)

        _, result = analyze_toplevel!(analyzer, src)

use frame.framecode.src instead to be synced with concretized? That change would break even more tests.

It seems our new problem has to do with
            # analysis of `eval` calls are difficult, let's give up it and just evaluate
            # toplevel `eval` calls; they may contain toplevel definitions
            # adapted from
            # - https://github.com/timholy/Revise.jl/blob/266ed68d7dd3bea67c39f96513cda30bbcd7d441/src/lowered.jl#L53
            # - https://github.com/timholy/Revise.jl/blob/266ed68d7dd3bea67c39f96513cda30bbcd7d441/src/lowered.jl#L87-L88
            if begin
                    f === :eval ||
                    (callee_matches(f, Base, :getproperty) && is_quotenode_egal(stmt.args[end], :eval)) ||
                    isa(f, GlobalRef) && f.name === :eval
                end
                # statement `i` may be the equivalent of `f = Core.eval`, so require each
                # stmt that calls `eval` via `f(expr)`
                concretize[edges.succs[i]] .= true
                concretize[i] = true
            end

We probably do not detect one or more of these in the optimized code...

Open question: should
        analyzer = AbstractAnalyzer(analyzer, concretized, context)

        _, result = analyze_toplevel!(analyzer, src)

use frame.framecode.src instead to be synced with concretized?

No, analyze_toplevel analyzes a lowered code that is already partially interpreted.

We probably do not detect one or more of these in the optimized code...

Hm maype this optimization breaks some invariant(s) that our eval handling assumes?
How about separating the :foreigncall handling from JuliaInterpreter.optimize! and probably enforce it within Frame construction (since it seems necessary for successful interpretation, rather than just to be a mere "optimization"), and disable other optimizations?

Codecov Report

Merging #280 (7204e42) into master (b1c5ede) will decrease coverage by 1.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   89.09%   87.51%   -1.59%
==========================================
  Files          10       10
  Lines        2220     2210      -10
==========================================
- Hits         1978     1934      -44
- Misses        242      276      +34

Impacted Files
Coverage Δ

src/toplevel/virtualprocess.jl
97.12% <100.00%> (-0.26%)
:arrow_down:

src/abstractinterpret/abstractanalyzer.jl
76.85% <0.00%> (-5.11%)
:arrow_down:

src/analyzers/jetanalyzer.jl
91.97% <0.00%> (-4.03%)
:arrow_down:

src/JET.jl
70.30% <0.00%> (-1.93%)
:arrow_down:

src/abstractinterpret/typeinfer.jl
92.68% <0.00%> (-1.01%)
:arrow_down:

src/analyzers/optanalyzer.jl
87.36% <0.00%> (-0.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c5ede...7204e42. Read the comment docs.

Open question: should
        analyzer = AbstractAnalyzer(analyzer, concretized, context)

        _, result = analyze_toplevel!(analyzer, src)

use frame.framecode.src instead to be synced with concretized?

No, analyze_toplevel analyzes a lowered code that is already partially interpreted.

OK, but I'm not sure if length(concretized) == length(src) holds before analyze_toplevel!. Will check with an assertion.

Hm maype this optimization breaks some invariant(s) that our eval handling assumes?

Probably.

How about separating the :foreigncall handling from JuliaInterpreter.optimize! and probably enforce it within Frame construction (since it seems necessary for successful interpretation, rather than just to be a mere "optimization"), and disable other optimizations?

Maybe adapting select_direct_requirement! is good enough at the moment?

OK, but I'm not sure if length(concretized) == length(src.code) holds before analyze_toplevel!. Will check with an assertion.

It doesn't.

It doesn't hold. And concretized is accessed in the analyzer phase. This does not feel right.

Ah, I just know that src::CodeInfo is copied upon FrameCode construction. Yes, we need to make src::CodeInfo consistent with concretized even during abstract interpret.
Maybe we can do:

tweak abstract interpret pass so that it can handle :foreigncall expressions that JuliaInterpreter emit
keep using the original src for abstract interpret, with running select_statements twice (dirty)

It doesn't hold. And concretized is accessed in the analyzer phase. This does not feel right.

Ah, I just know that src::CodeInfo is copied upon FrameCode construction. Yes, we need to make src::CodeInfo consistent with concretized even during abstract interpret.
Maybe we can do:
* tweak abstract interpret pass so that it can handle `:foreigncall` expressions that JuliaInterpreter emit

* keep using the original `src` for abstract interpret, with running `select_statements` twice (dirty)

:) This does the trick!

Now I only need some outline where to add which tests?

Anywhere you want. Maybe test_virtualprocess.jl?

Just noticed: we better keep two versions of select_statements around?

How about switching the behaviors by new optimized::Bool flag?

OK, ScanByte is go I hope, now I'll have to look into Convex still failing with
┌ @ C:\Users\Win10\.julia\packages\Convex\uI27T\src\variable.jl:204
│ UndefRefError: access to undefined reference
└───────────────────────────────────────────────────────────────────

Test failure due to
   Evaluated: isempty(ToplevelErrorReport[ActualErrorWrapped(ArgumentError("Package Libdl not found in current path:\n- Run `import Pkg; Pkg.add(\"Libdl\")` to install the Libdl package.\n"),

Hm. Do we need to set this up in CI somehow?

Do we need to set this up in CI somehow?

https://pkgdocs.julialang.org/v1/creating-packages/#Test-specific-dependencies-in-Julia-1.2-and-above

Alright, now #224 and #281 are fixed by #283, but still I'd like to merge some parts of this PR.
How about:

first rebasing this PR against #283
removing changes around letting JuliaInterpreter optimize src::CodeInfo
adding new assertion that makes sure concretize is consistent with src that abstract interpreter works on
keeping test/Project.toml changes
?

Alright, now #224 and #281 are fixed by #283, but still I'd like to merge some parts of this PR. How about:
1. first rebasing this PR against [concretize all top-level code when analyzing a package #283](https://github.com/aviatesk/JET.jl/pull/283)

Done.

2. removing changes around letting JuliaInterpreter optimize `src::CodeInfo`

3. adding new assertion that makes sure `concretize` is consistent with `src` that abstract interpreter works on

This assertion still leads still to test errors?

4. keeping `test/Project.toml` changes

OK.

Could you explain why we need to use optimize option of JuliaInterpreter?

Could you explain why we need to use optimize option of JuliaInterpreter?

We don't need to, it is the default (which is not changeable in the default Frame constructor AFAIU). One of my older patches constructed the Frame therefore by hand using a copy of JuliaInterpreter internal code: https://github.com/aviatesk/JET.jl/pull/280/commits/618b814714bf8697379dd19dc445cecfc8e46af1#diff-a8508c23a55035016aa42d51c599c9ce18ff31cc603ad173d0612849e35e457dL799-L803
It is your decision, which implementation is more future proof.

I'd like to avoid duplicated calculation of select_statements since there is no strong guarantee of correspondance between statements concritized by ConcreteInterpreter and selected statements obtained by the recalculation.

I'd like to avoid duplicated calculation of select_statements since there is no strong guarantee of correspondance between statements concritized by ConcreteInterpreter and selected statements obtained by the recalculation.

Will change and check.

We can also add optimize option to JuliaInterpreter.Frame constructor :)


Instances of the FeatureServices are now used instead of only the names of the FeatureServices.

Describe changes
I have adapted the get_feature_services function so that it returns instances of the FeaturesService class and not just a list of feature service names. In addition, the functions get_online_features and get_historical_features of the integration can now be used with a list of features / feature views as well as with a FeatureService instance.
This brings the implementation of the feast integration closer to the feast API.
I have also set the minimum version of feast to 0.12.0 to ensure that the necessary Pythom API is available from feast.
This PR closes #3180.
Pre-requisites
Please ensure you have done the following:

[X] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Other (add details above)

In addition to the FeatureService, there are other implementations that do not return/use objects, but instead use names. (e.g. zenml.integrations.feast.feature_stores.feast_feature_store.FeastFeatureStore.get_data_sources or zenml.integrations.feast.feature_stores.feast_feature_store.FeastFeatureStore.get_entities). Perhaps this should also be adapted.

I'm not sure how tests should be written here at zenml. In the case of feast integration, you would have to do quite a bit of mocking.

LGTM, assuming tests all pass...

@strickvl When I start the tests locally with the bash script, I get the following error.
RuntimeError: The ZenML database has never been migrated with alembic before. This can happen if you are performing a direct upgrade from a really old version of ZenML. This direct upgrade path is not supported anymore. Please upgrade your ZenML installation first to 0.54.0 or an earlier version and then
to the latest version.

I don't really understand this error.
Since I have not added any new tests and have not found any tests for the feast integration, everything should probably still work.

@aiakide This is probably because the tests are trying to run with an already existing, very old database. Which OS are you running on? There should be a zenml-test directory somewhere (I think ~/.config/zenml-test on linux, ~/Library/Application\ Support/zenml-test on MacOS) which contains this DB. If you just delete that directory, it should hopefully run as expected

@aiakide Is this ready to merge from your side or are you still making changes?

@schustmi Yes, I'm done. Can be merged. 🚀


SQL: ALTER/DROP PROPERTY do not respect backtick quoting

The SQL commands DROP PROPERTY and ALTER PROPERTY do not respect backtick quoting.
Example:
CREATE PROPERTY `tasks`.`my_property`

=> Works fine.
DROP PROPERTY `tasks`.`my_property` // => error: source class `tasks` not found
DROP PROPERTY tasks.`my_property` // => error: property `my_property` not found
// same thing with ALTER PROPERTY

Same thing with CREATE INDEX.

Fixed in develop branch (v 2.2.1)
Thanks
Luigi


Is it possible use just one media query breakpoint change?

in my theme.js:
export const breakpoints = [
  '1000px',
]

my Button.js:
import { space, fontSize } from 'styled-system'

export const Button = styled('button')`
  font-size: 1rem;
  ${fontSize}
`

usecase:
<Button fontSize={['0.7rem', /* Use value (1rem in this case) from Button.js */]}>
  Login
</Button>

I know I can use inherit or so, but I want to be able to change default font-size globally in Button.js.
If I used fontSize={['0.7rem', '1rem']}, and I decided later I want to change default button font size to 1.5rem, I'd have to go through the whole app and replace the second breakpoint value.
Any elegant solution to this?
Thanks in advance

Not sure I 100% understand the question(s) here, but I'll try:

Any number of breakpoints is acceptable & the first value in a props array will mean it's not scoped to a media query
If you're wanting to set something both as a prop and as a default value, you can set defaultProps on the Button component, which would set the value for all Button components


Investigate Font option

Should we allow a user to change font?

Very low priority, might not do

Won't do


Add an option to use 'brand type' on value classes and primitives

To help emulate Kotlin's strong typing, use 'brand typing' to specify primitives and value classes. Otherwise TypeScript doesn't discriminate between UInt and Long
Builtin primitives should be handled
type Byte = number & { __kotlin_byte__ : void};

Value classes too
package my.package

@Serializable
@JvmInline
value class UserCount(private val count: UInt)

Something like this...
type UInt = number & { __kotlin_uint__ : void};

type UserCount = UInt & { __my_package__usercount__ : void};

This has been implemented https://github.com/adamko-dev/kotlinx-serialization-typescript-generator/blob/v0.0.5/docs/value-classes.md#brand-typing, but I haven't used it much so I don't know how useful or accurate it is.
If it needs further work, make a new issue
TODO add it to the README #19


Outlook for Windows: "Resources" behavior in Calendar view

Outlook for Windows: "Resources" behavior in Calendar view
I have a question about the return value of the enhancedLocation.getAsync method.
I have confirmed the following behavior in Outlook for Windows:

The "Rooms" box and the "Resources" box are the same.

(1) When an Equipment or User is specified in the "Resources" box (= "Rooms" box), it will be displayed in the "Required" field.

(2) When a Room or Workspace is specified in the "Rooms" box (= "Resources" box), it will appear in the "Location" field.

(3) When a Room or Workspace is specified in the "Required" box, it will appear in the "Required" and "Location" fields.

(4) Remains in the "Required" field even if removed from the "Location" field.

For each case at this time:

(1) When an Equipment or User is specified in the "Resources" box (= "Rooms" box), it will be displayed in the "Required" field.
(2) When a Room or Workspace is specified in the "Rooms" box (= "Resources" box), it will appear in the "Location" field.
(3) When a Room or Workspace is specified in the "Required" box, it will appear in the "Required" and "Location" fields.

You can get the value with the enhancedLocation.getAsync method.
I think it is incorrect to have type=Room in the return value of the enhancedLocation.getAsync method when specifying equipment or user. Is there an internal reason why equipment and users cannot be retrieved by the requiredAttendees.getAsync method as per the creation screen?

(4) Remains in the "Required" field even if removed from the "Location" field.

You can get the value with the requiredAttendees.getAsync method.
Here is the video reproducing the above. Outlook for Windows: Version 2210 (Build 15726.20174)
https://user-images.githubusercontent.com/58804032/198968663-b9985e68-0706-423b-b8f9-0f693b72685e.mp4

function get() {
  Office.context.mailbox.item.requiredAttendees.getAsync(v => console.log(v));
  Office.context.mailbox.item.enhancedLocation.getAsync(v => console.log(v));
}

{
    "value": [
        {
            "locationIdentifier": {
                "id"<EMAIL_ADDRESS>                "type": "room"
            },
            "displayName": "cequip",
            "emailAddress"<EMAIL_ADDRESS>        }
    ],
    "status": "succeeded"
}

Please let me know about the expected behavior.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8922b63d-51bd-5f4a-0c33-63e9715103c2
Version Independent ID: 9add94e6-3658-b586-4906-3ff07dd10bf7
Content: Get or set the location of an appointment in an add-in - Office Add-ins
Content Source: docs/outlook/get-or-set-the-location-of-an-appointment.md
Product: outlook
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

Hi @clavx,
Thank you for providing details about your test scenarios. The video of the behavior you're getting is much appreciated. I'll look into this further to determine the expected behavior and get back to you.


feat: bump AKS Windows CSE script package to v0.0.47

What type of PR is this?
/kind feature

What this PR does / why we need it:
bump AKS Windows CSE script package to v0.0.47

chore: refine collect-windows-logs.ps1 to enable crt by default #4863
chore: add windowsnodereset.log in loggenerator.ps1 #4869
fix: exclude udp ports on Windows #4886

Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.311%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
2595

Relevant Lines:
3639

💛  - Coveralls

We cannot merge this until partner teams refine their settings. Otherwise, it will fail partner teams' clusters.


Refrencing ashley components causes black screen (update: actually scala flatten and flatmap break it)

Hey! I'm running into an issue where the compiled javascript renders a black screen when I reference any of my ashley components.
You can see this live here (black screen)
https://plutobox.github.io/scala-example-gdx-teavm/breakout/
Here's the change that introduced the problem
https://github.com/plutobox/scala-example-gdx-teavm/pull/2/files
To fix it, you just need to comment out one line, this one
https://github.com/plutobox/scala-example-gdx-teavm/pull/3/files
Then it renders just fine (see blue circle on bottom left of screen)
https://plutobox.github.io/scala-example-gdx-teavm/breakout-f/

Some progress.
This works fine
  override def create(): Unit = {
    (0 to 10).map(x => {
      (0 to x).map(y => {
        y
      })
    })
  }

This both cause black screen of death
  override def create(): Unit = {
    (0 to 10).flatMap(x => {
      (0 to x).map(y => {
        y
      })
    })
  }

  override def create(): Unit = {
    (0 to 10).map(x => {
      (0 to x).map(y => {
        y
      })
    }).flatten
  }

It appears that ashley isnt the culprit. This is a scala related problem in flatten.

I see a blue circle at bottom left using this example https://plutobox.github.io/scala-example-gdx-teavm/breakout/

Are you using v1.0.0-b9 ?
try forcing teavm to 0.10.0-dev-8 and see if it happens there. If still happening I think you will need to create a issue in teavm repo.

I see a blue circle at bottom left using this example https://plutobox.github.io/scala-example-gdx-teavm/breakout/

That's... strange. No circle for me on firefox/chrome, and cache isn't the problem. Checked on my mobile iOS and same result. Upgrading to 0.10.0-dev-8 didn't fix either.
Yeah closing this out, appears to be a teavm problem... or a me problem. Thanks for your eyes on this


qt5: Drop qt-5.9

Motivation for this change
Nothing is depending on the 5.9 branch of Qt anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @ttuegel @bkchr @peterhoeg

5.9 is the latest LTS - I think we should keep carrying it.

I'm for dropping it, but if we keep it, we should update it.

5.9 is the latest LTS - I think we should keep carrying it.

In the past, I have advocated for keeping the latest branch and the latest LTS branch as these are what Qt upstream officially supports. There are other reasons to keep it: some people use Nix for Qt development, for instance. So I would prefer to keep it until a new LTS comes out.

I agree. I didn't think of that 5.9 was an LTS.


Fixed Disk Utilization parameter

Fixes #
Proposed Changes

Hi, this is an update to one of they workbook queries

Hi @gregcoward - Both PRs are not updated and shows conflicts. Would be great if you can sync your branch to make it the same state as master's so that you pick up the new workbook from master. Then you can apply the specific changes covered in the PRs #645 and #644 - thanks.
Please reach out to me at preetikr_at_microsoft_dot_com for discussing the sample data for F5-BigIP. That is not tied to these two PRs.


Icons appears only after resize windows

Hi !
I'm using Semantic-UI with Angular 2.  I need to refresh or resize the windows (in mobile size for example) and icons appear. After that, when i come back to full size is ok.
This problem is not present on all Browser. Only for Chrome and Safari. Work perfectly on Firefox and Opera.
First:

After refresh or resize windows:

Any fiddle with the issue replicated? Could help us get an idea of what exactly is going on.

It seems to be bugged when i put the icon in a h2 tag. The icon is right when i remove  the h2 tag
Working:           Données personnelles

Not working:
                  Données personnelles

@Nexmind Hi, please provide a test case as per our contributing guidelines; you can fork this JSFiddle.

Closing the issue until there’s a test case.


Suggestion : Use SyncTrayzor for a remote Syncthing host

My Syncthing server is far away from desktop, and I'll find it convenient to use SyncTrayzor as a dedicated icon to check that any backup is well synced instead of using web GUI that I have to open and close for obvious reason.

Can you condense your suggestion down into some concrete additions you want to see, and how they'd be implemented?

It would be great to set the GUI listening port not to a localhost but to a remote server.
SyncTrayzor actually requires Syncthing to run on it's host whereas some of us have dedicated server or running pc.
In my case, backup from servers are sync through this software, and I'd like to see the progress from the tray only instead of having to connect to the web GUI adn switching windows.

It would be great to set the GUI listening port not to a localhost but to a remote server.

This cannot happen with the way that SyncTrayzor is architected, please see #591, #528, #143, and others.


🐛 Application crashes on start recording

What were you trying to do?
I simply want to record a video nothing else but the application crashes whenever I trigger the start recording function
Reproduceable Code
/* Camera with Capture button Component */
 <Camera
          ref={CameraRef}
          style={StyleSheet.absoluteFill}
          device={device}
          isActive={isActive}
          preset="medium"
          video={true}
          audio={true}
          orientation="portrait"
          torch={supportsFlash ? flash : "off"}
          enableZoomGesture={true}
          onInitialized={() => setIsCameraInitialized(true)}
        />
<CaptureButton style={styles.captureButton} camera={CameraRef} />

/* Capture Button code */

const CaptureButton = (props) => {
  const { style, camera } = props;

  return (
    <>
      <TouchableOpacity
        style={[
          style,
          {
            width: BTN_SIZE,
            height: BTN_SIZE,
            zIndex: 4,
            alignItems: "center",
            justifyContent: "center",
            backgroundColor: "pink",
          },
        ]}
        onPress={() => {
          camera.current.startRecording({
            onRecordingFinished: (video) => console.log(video),
            onRecordingError: (error) => console.error(error),
          });
          setTimeout(() => {
            camera.current.stopRecording();
          }, 5000);
        }}
      />
    </>
  );

What happened instead?
I made this small code for debugging and testing the video component. After the camera component renders, I press that capture button to run that startrecording function and my application crashes without any error in the console
Relevant log output
No response
Device
Android
VisionCamera Version
2.13.2
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Experiencing this as well from a new build.  No stack trace on the javascript side.

I have the same issue. @mrousavy  please help.

This started to happen to me too after upgrading to RN 0.66. Photos still work but video crashes (based on example)

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.
I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?
Here's an instruction on how you can test that: https://github.com/mrousavy/react-native-vision-camera/pull/1674#issuecomment-1684104217
If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.
Thank you!


only UPDATE event not applied on PostgreSQL

Describe the bug
A clear and concise description of what the bug is.
After 'chameleon start_replica' everything is ok.  show_status tells status = running and consistent = yes.
Every Logs also fine (in ~/.pg_chameleon/logs and $PGDATA/log)
but few data is not same with MySQL data.  When i checked pg_stat_user_tables, All table's n_tup_upd is 0.
So, I find some information on kafka configuration. (Link)
"Check binlog_row_value_options variable, and make sure that value is not set to PARTIAL_JSON, since in such case connector might fail to consume UPDATE events."
Unfortunately, my env binlog_row_value_options is 'PARTIAL_JSON'.  Is that a right guid for this problem?
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
PostgreSQL stat - 0 Update row.

MySQL stat - Update event occur.

Environment(please complete the following information):

OS: [e.g. Devuan GNU/Linux]
MySQL Version[e.g. 5.7.27]
PostgreSQL Version[e.g. 11]
Python Version [e.g. 3.5]
Cloud hosted database [e.g PostgreSQL on AWS RDS and MySQL on Google Cloud]

Additional context
Add any other context about the problem here.

the values in pg_stat_user_tables is just an estimation and definitely not good to determine whether the rows are being replicated or not.

@the4thdoctor
When pg_chameleon init & start replica from 'MySQL Slave' then must disable 'binlog_row_value_options' parameter on MySQL DB.  If not, only 'update' event not replicate to PostgreSQL.


p2p: limit the amount of storage and memory occupied by addresses in peerdb

To limit the number of addresses, two fixed-size tables are maintained (one for "new" addresses, and the other one for "tried" addresses, i.e. the ones that we've connected to at least once). The tables consist of buckets; the index of a bucket and the position inside it is determined based on the hash of the address. So, when an address is added to a table, another one may be removed from it at the same time.
This is similar to what bitcoin-core does in its AddrMan.

So I did the first round, but I'll take another round later.

Squashed and rebased on top of the current master


change title of page and video to Introduction to Kubeflow

This is an effort to fix #2618  The only place the expression "An error occurred." occurs on the page is inside the  tag for the embedded video.
My theory is that either:

Google is attempting to find a better title for this page than a title that is exactly the same as the domain name (the current title) and ended up using the
An error occurred.
 inside the  tag.
There was a transient error when Google crawled the page.

In either case, I think these changes slightly improve the page and should encourage Google to reindex the page.
We should also directly request a re-index from the Google Search Console.
cc: @RFMVasconcelos

/ok-to-test
Thank you! That seems a good guess!

@RFMVasconcelos note @Bobgy's comment above. This is pretty ugly in search results. Would like to move this forward if we can.

Let's hope this fixes it :)


Password strength check

Should check generated password strength and will show weather password is poor, good, strong, very strong.

Hi, I am bit new to Github, but can I take on this issue. Is there anything I should know while I reproduce the environment, or is everything clear in the readme?
Thanks!
Amogh

Yes, you'll find in readme. fork repo and you can contribute in UI folder. also check my new commit, will help to understand the need.

Sounds good!

Do you want to have another button called "Generate Password" so the user can set up all the parameters for generating a password(ex: setting the length, having alphabets, special characters). Then the password strength should update accordingly. Also, do you want me to define the boundaries for what is considered a very strong password or is it as simple as saying for each box the user checks off, that maps to how strong the password is. For example, if the user checks all 4 boxes, its a very strong password, if they check 3, its a strong password, if they select 2, its a good password, etc?
Also, just out of curiosity, does the sending password to email work?

Also, your copy password doesn't work as well

Sure, you can add/configure the UI and backend.


run error: two 'react-native' modules after installing

I install react-native-safe-area-view, but it will causes error, and I don't know how to install this component to my project, and I hope the document can be more specific, cause I don't know exactly how to use it.
Here is what I do:

npm install react-native-safe-area-view --save
run iPhone X simulator
then error occurred

Here is the error:
error: bundling failed: ambiguous resolution: module /Users/dongfanggouwu-xiong/WebstormProjects/untitled/index.js tries to require react-native, but there are several files providing this module. You can delete or fix them:

/Users/dongfanggouwu-xiong/WebstormProjects/untitled/node_modules/react-native-safe-area-view/node_modules/react-native/package.json

/Users/dongfanggouwu-xiong/WebstormProjects/untitled/node_modules/react-native/package.json

what version of react-native-safe-area-view do you have installed? The latest should solve this issue

My react-native version is 0.48, and I don't want to upgrade to the latest version. I've solved this issue by using the new version of react-navigation, cause it contains safe-area-view. thanks

glad it worked out


retry on 'Lost connection' also

Auto retry if 'Lost connection to MySQL server ' as well

4.2 is closed for security fixes only.


typo: Double word "as"

@nschonni : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.


chore: update jshint and move it to an npm script

I think this is worth it because:

jshint is udpated, so we'll get whatever bug fixes there may have been as well as performance improvements
This is now an npm package script instead of part of run-tests.js. Although cutting down on code is nice, this really shines in that it exposes linting to the commandline (so you can lint without re-running tests if you choose), and it lets jshint figure out which files to lint, instead of using common.expand() to expand the * character for Windows
I removed most re-declarations of variables just because I know that's an issue for eslint, and I know we may migrate to use that in the future. This wasn't required by jshint, however
I made linting a bit stricter, and actually caught some confusing parts of the code
Linting now runs after tests. I think this is valuable if you want to first get your code correct, and then afterward fix it for stylistic consistency.

@ariporad rebased this off master

LGTM!


Track rotated

continuing #168
Issue: tests on windows are flaky.
Investigation progress:
on my windows server (which is much strong I think), to reproduce test flakiness, I really have to push it to extreme.

add "polling" print per poll cycle
change poll interval to 1ms
run test with -v option so that it writes all prints to terminal

with above changes, tests are flaky.
When it fails, I couldn't trace back why it failed. all the logic seems fine.
One important find is that with just above changes, I also see flakiness on main branch.
flakiness is gone with just go test but when I do go test -v I do see flakiness.
So maybe when CPU is pushed to extreme on windows, some mishap happens maybe due to how windows operate on files.
So I think having 50ms poll interval and running all tests in parallel is pushing to extreme for github action hosts.
I have modified it to 200ms which the default value for this operator.

https://github.com/open-telemetry/opentelemetry-log-collection/pull/183/checks?check_run_id=2808466320
i tested that configuration on github actions. it failed on windows.

https://github.com/open-telemetry/opentelemetry-log-collection/pull/183/checks?check_run_id=2808466320
i tested that configuration on github actions. it failed on windows.

@rockb1017 What conclusion are you drawing from this?

I naively deleted a blocked of code that seemed to be inefficient and unnecessary.
it was for "copy/trunc" cases and we are having flakiness on "copy/trunc" tests. I added those back and it passed.
Thanks for the discussion we had today. @djaglowski
Could you run a few more times just to be sure ?

100% data ingestion rate.
(i am generating 100,000 + 3 messages per pod and i deployed 3 pod. so total 300,009

@rockb1017 can you please update the PR description, squash the commit into one and add a commit message that fully explains why the changes are made and how they fix the problem.
Thanks for spending time on this for your patience. @djaglowski thanks a lot for your help and for the summary in your approval.

Thanks @rockb1017 and @djaglowski !


Data processing tutorial loads very slowly

The data processing tutorial loads very slowly since #358 due to its sheer size (~3.5MB). We need to truncate its output.

:tada: This issue has been resolved in version 0.15.0 :tada:
The release is available on:

v0.15.0
GitHub release

Your semantic-release bot :package::rocket:


Sched devel

Added possibility to use custom priority in VM scheduling, e.g. given by the FairShare Scheduling service.

Hi
Look great :+1:  I've a question. Right now the objects stored in a Pool are a map indexed by an int
std::map<int, ObjectXML*> , I like the idea of reordering the map using the PRIO field, and inserting the VMs using PRIO. However when 2 VMS have the same priority the insert will fail . Probably we could either use a multimap for PoolXML::objects or just sort the map using an ancillary container like a vector... (I like better the second approach). What do you think? I can take a closer look and come up with a proposal using the SchedulerPolicy class. Just returning the VM/PRIO field will do, in here .
It needs a bit of logic to work on VMs instead of Hosts, but that's the idea.
Make sense?

Hi Ruben,
thanks for your comment.
Up to now we do have a setting which prevents having the same priority value (L133 in https://github.com/indigo-dc/one-fass/blob/master/src/pm/BasicPlugin.cc).
Anyway, it is great if you have suggestions to integrate this functionality in ONE in a more effective way! I will discuss this with Sara and come back to this thread.

Hi Ruben,
indeed we assumed that "whoever" provides the priority values should take care of having them unique. Our modification was the most straightforward we could think about without intruding too much in the ONE code, but clearly it's not very robust. Yes, your ideas make a lot of sense and personally I also prefer the second option. Look forward to have your improved version!

Sara + Valentina
THANKS, I'll work on that. I'll update the issue so we can test it with the fair share scheduler
Cheers

I've just pushed the changes into master.  https://github.com/OpenNebula/one/commit/1f571426ab257ea5993ec8828738e7b60f1049ef
Changes compared to the PR:

The attribute to store the computed VM priority is USER_PRIORITY this variable should be updated through the API (e.g. as in onevm update) (its xpath is /VM/USER_TEMPLATE/USER_PRIORITY).   Note. I'm afraid this requires changes on fass scheduler (How do you update /VM/PRIO, is this a direct DB access?).

The use of  an USER_TEMPLATE  (pretty much as SCHED_RANK...) allows admins to set specific priorities to VM templates without using an external component.

Also, this attribute is set as a restricted, so only users (or processes) with oneadmin rights can modify this field. So fass needs access to a oneadmin capable credential (like the regular one scheduler), I guess this is not a problem.

Although changes could be done more straightforward, I kept the policy class abstraction so this  policy could be potentially combine with others. Priorities are scaled (i.e. priority 1 is always the highest) so the one shown in sched.log is scaled, in this way different policies can be used with a linear combination each computed priority.

USER_PRIORITY supports floats, just in case it is useful in fass.

This is now in master, and will be released in 5.4 (internal testing is undergoing). If you have the opportunity to test it with fass, before the final release (just a week, sorry for that) we could include any bug fix or minor improvement.
Cheers

Hi Ruben,
thanks for your work!
You can go ahead with your tests before 5.4. There are some small things which we need to change in fass and we'll do our best to try out the master before your release. In case you don't hear from us, we did not make it in time. Anyway, there are no problems from our side with your PR! Some comments:

here we have to change the way we write the xml, but it is a minor thing. We do not access the one db, since we do communicate only with your scheduler, via xmlrpc calls.
ok
no problem, fass already knows the oneadmin credentials
just one question: is the rescaling done directly by one?
very good, it is indeed useful!

Thanks again and cheers,
Valentina and Sara

GREAT THANKS!. It is now in master for the 5.4RC.
About 5. Yes the scaling is done by OpenNebula scheduler, so you don't need to do anything in fass. Just note that now in sched.log we print each VM priority in the dispatch list. That priority is scaled and won't be the same as the value of USER_PRIORITY in the Template.

Hi Ruben,
We have tested FASS with ONE 5.4 it and there are no problems.
New version in master: https://github.com/indigo-dc/one-fass works with ONE 5.4, while version v1.1 works with previous versions of ONE.
We close now the pull request and thanks a lot,
Valentina and Sara

Excellent :)  THANKS!


[MI-3626]: Test cases of slash commands for MS Teams plugin

This PR consists of the test cases of basic slash commands in MS Teams.
The slash commands contains:-

Connect and disconnect
Link and unlink channel
Show and Show-links
Promote user
Connect-bot and disconnect-bot

why the base branch is not main.

While working earlier, it was a practice that we won't be merging the changes in the main branch.


"How can I help" page returning error

When clicking the "How can I help" button anywhere on the dreams platform, I'm met with the attached error.
I was expecting to see any dreams which have data entered in the "COCREATION_FIELD". Variable is set to true as per default.
Issue is reproducible by both unregistered guests and authenticated users on both Urban Burn Dreams and Borderland Dreams. Urban burn Dreams is running the latest pushed build from this repository.
The browser error message is the default one:

We're sorry, but something went wrong.
If you are the application owner check the logs for more information.

I tailed the logs in Heroku while sending a get-request and this is the result:
howcanihelp_logs.txt
Specifically this row, followed by the div-class that caused the error:

"2020-03-08T15:18:27.757369+00:00 app[web.1]: ActionView::Template::Error (undefined method `total_pages' for #Camp::ActiveRecord_Relation:0x0000556c625dab00):"

I've looked through "index.html.erb" and cannot really see wrong with the HTML, but I wasn't expecting to either. It's something to do with the database call template. Searching for the keywords in the error did not give me any meaningful results so I'm giving up on trying to solve this myself.

First off, thanks for reporting this! Sorry for the slow response, didn't see this until now for some reason!
I disabled pagination of dreams when we solved the performance issue that forced us to paginate at 48 dreams, so the disabled pagination was messing with the "How can I help" page. I disabled it with the commit mentioned above and pushed the fix to master.


Complete documentation for Grid Structural Selectors

Request type

[ ] New documentation
[*] Correction or update

Page to change
https://developer.mozilla.org/en-US/docs/Web/CSS/Column_combinator
Details

Complete the page for Column Combinator
Add page for nth-col()
Add page for nth-last-col()

https://drafts.csswg.org/selectors-4/#table-pseudos

I've completed the above, they were also mentioned in https://github.com/mdn/sprints/issues/1686
Waiting for compat data to be merged in https://github.com/mdn/browser-compat-data/pull/7511 and this to show up https://github.com/mdn/data/pull/447
cc: @chrisdavidmills


add managedclusteraddon.addon.open-cluster-management.io

closing this PR and open a new one https://github.com/open-cluster-management/api/pull/59

closing and switch to https://github.com/open-cluster-management/api/pull/59


streams: Sort streams by most recent activity.

Hotkey 'y' toggles this feature.
Fixes #10794.

GIFs or Screenshots:

@showell Please review this.


[BUG]: Online Token revalidation fails for shopify app

Online token revalidation does not happen after 24 hours, resulting in hundreds of
HttpResponseError: Received an error response (401 Unauthorized) from Shopify:
"[API] Invalid API key or access token (unrecognized login or wrong password)"

My current bandage fix is to clear out sessions db for the moment being.
Any suggestions?

The issue is narrowed to SessionProvider not added/ and when added, making the app refresh endlessly.

I assume this is because you are sitting on the same page for over 24 hours, then try to perform some requests again.
The session has since expired so it throws a 401 error.
If you leave the app, and then come back to it, it should refresh the token automatically.
So what should happen is, if an expired token is detected on a /api/graphql request then we need to redirect the user to authenticate again. Just not sure if this is something that should happen automatically, or should we catch it on the front end and prompt the user to "refresh" the page.
It could be a little jarring (and the user could potentially lose unsaved work) if the app did an automatic refresh/redirect.
What do you think?

I was able to fix this, the issue is that SessionProvider is commented out and /verify is not implemented.
I have added those components, currently testing to make sure everything is working as usual.
The issue is that even when you come back to the app after 1 or more days, the session is not re-authenticating, isVerified is always false.

Added PR with fix #4

@ozzyonfire

The thing is I removed this because I wasn't happy with the implementation. This was how I achieved it using the old next pages directory.
However, with the new app router, we should be able to do this with server components.
Old way:
The SessionProvider, just made a request everytime the user navigated around your app (or came back to the page after a while) and would check if the session is still valid with an REST request.
If the session was expired, the page would automatically refresh.
New way:
I can basically do everything we need to do in the performChecks function (/lib/shopify-oauth.ts). So my plan would be to make that a server action and then make a new SessionProvider.
We can call that performChecks server action from the new SessionProvider and hopefully everything works. Then we don't have to rely on that /verify api call to work.
I am going to take a look at this today and see what I can do. Your PR will definitely work, it's just not really the way I want this new template to accomplish it.

Agreed, that would be great :)

I just pushed some changes up. Feel free to pull them down and check it out. I still left the old code in tact (I really need to go through and start removing the old stuff).
I made a new method "useSessionCheck" that basically just calls a server action and should have the same effect as the old way of doing things (but just much cleaner and no more /api route to manage.
check out the actions.ts file under the app directory and the new function in /hooks/auth.ts


GraphQL is not getting exposed on a different endpoint

I have tried using
graphql:
servlet:
mapping: /test
enabled: true
corsEnabled: true
GraphQL is not getting exposed on a different endpoint
I did not see any which way where /graphql van be exposed to some other point
Also /graphql is giving 400 bad request, it is only expecting query parameters
Only /graphiql is working which is a html page
How can we expose /graphql or any user defined url as as endpoint with post body?

Just tested again and it does work for me now. Think I forgot to save it or something in the previous test. You only need this part btw:
graphql:
  servlet:
    mapping: /test

Seems to be something with your local config.

It worked for me when giving configurtion
graphql.servlet.mapping=/test
But there is one more issue , I can't use /graphql or /test with POST body, it gives 400 error code
it is only taking query parameters

Sounds like you added yaml style configuration in your properties file before then.
GraphiQL uses POST as well, so it does accept it. Could be a problem with your model or schema. In that case there should be a stack trace. Why don't you start with the working example example-graphql-tools and work from there. Current version is stable and functioning.

@oliemansm
I am talking  about /graphql and not /graphiql . For real use case I will be exposing /graphql and not
/graphiql which is just a UI and can't be shared with consumers in the form of API.
Also example-graphql-tools also follow the same lines

GraphiQL sends POST requests to /graphql. Confirming that it accepts POST requests.

@oliemansm
I beg to differ  /graphqln accepts query parameter
Please find the following snapshot

Well yes, it also accepts GET parameters. That's not the problem you reported though. You reported that it doesn't accept POST requests.

@oliemansm
Yes you can see from the above snapshot same POST request not working..
Also I captured the source code of graphql UI

If you see the snapshot ,there is proper JSON message sent which we never mentioned in GraphQL UI

Set graphiql.endpoint=/test as well. Don't know why, but for some reason it currently needs to be set separately.

Look at all the settings of a successful GraphiQL post and copy that behavior. Investigate online for example at https://graphql.org/learn/. You're basically asking general GraphQL questions now for which there a lot of resources readily available online.

@oliemansm
Thanks for your support
I have got my answer
Following POST body works fine
POST
{"query": "{ findAllBooks { id } } "}

So there is some tweaking happening from grqphqlUI to graphql endpoint

graphql.url = test
in application.properties
helped

same problem - need to fix the documentation
setting url by:
graphql.servlet.mapping=
not working
graphql.url =
works

I reproduce the same issue.
It depends on the spring type
webmvc use graphql.servlet.mapping
webflux use graphql.url
Could be nice to have the same property for both

I reproduce the same issue.
It depends on the spring type
webmvc use graphql.servlet.mapping
webflux use graphql.url
Could be nice to have the same property for both

@ooga you're correct. I think there's an open discussion or issue where I mentioned this too.

@ooga you're correct. I think there's an open discussion or issue where I mentioned this too.


Sample is blank without any errors in expo app

Good day,
The sample on the home page is displaying blank without any errors on expo, what could be the cause
Please enlighten me.
Thanks
Tim

Had the same issue. It seems, that it takes a few seconds (~10) to load the sample book.

Hi @lkathke thanks for your reply. I will try it further, because I waited for over 30 seconds and nothing was displaying. I will wait for at least 5 minutes and see if it shows.
But there should be a way to display an indicator to show the file is loading.
Thanks

hi @timotech! actually in some cases the file is taking longer than usual to load for some reason.. I'll investigate that!

Ok thanks @victorsoares96, I will expect your findings, and probably a way out. Thanks


README

#README
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it
Issue #5:

Use README guide saved in bookmark.


feat: add phalcon 5.4.0 release

update phalcon with release 5.4.0

:tada: This PR is included in version 1.228.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create new repository with Nellie related illustrations?

@ststimac What do you think about having a repository to collect all the Nellie related illustrations?

that'd be awesome.

Uh yes, I love nellie's photobook!
Sent using OWA for iPhone

From: Cătălin Mariș<EMAIL_ADDRESS>Sent: Thursday, July 13, 2017 12:57:10 PM
To: sonarwhal/sonar
Cc: Stephanie Drescher; Mention
Subject: Re: [sonarwhal/sonar] Create new repository with Nellie related illustrations? (#378)
that'd be awesome.
@ststimachttps://github.com/ststimac Any suggestions for the repo name? Nellie's photo-book?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/sonarwhal/sonar/issues/378#issuecomment-315185360, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARPGKz2lgcHx11EnyNV3byp-1nnE7GGtks5sNnaWgaJpZM4OW9fK.

@ststimac Done, https://github.com/sonarwhal/nellie (when with nellie for now because otherwise we needed to use something like nellie-photobook or nellie-s-photobook)
We'll discuss more about it next week.


Exposing env. specified via Now CLI to Docker RUN command

The documentation here says that environment variables specified via Now CLI will be available on RUN and CMD instructions. But in my deployment, it just exposes to CMD instructions. I can't access it from RUN.
Keyword: env, environ, environment, RUN, Docker, Dockerfile
Here is the command I use:
$ now --public -e SECRET_KEY=@linecms-demo-secret-key

Here is RUN command to test on Dockerfile:
RUN sh -c "export"

And this is the output of the command:
> Step 15/19 : RUN sh -c "export"
>  ---> Running in 9be8e9bbcc2d
> export ALLOWED_HOSTS='*'
> export GPG_KEY='<secret>'
> export HOME='/root'
> export HOSTNAME='9be8e9bbcc2d'
> export LANG='C.UTF-8'
> export PATH='/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
> export PROJECT='linecms'
> export PROJECT_DIR='/opt/linecms'
> export PROJECT_SERVER_DIR='/opt/linecms/server'
> export PROJECT_STATIC_DIR='/opt/linecms/static'
> export PWD='/opt/linecms/server'
> export PYTHONUNBUFFERED='1'
> export PYTHON_PIP_VERSION='10.0.1'
> export PYTHON_VERSION='3.6.6'
> export SHLVL='2'
> export STATIC_ROOT='/opt/linecms/static'
> export USE_WHITENOISE='1'
>  ---> 4c1cc9bb3ba8

Thank you very much.

I also have this issue. I think it is the same issue as #522.
I don't believe that now is passing any env to the docker deployment.

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


Improve portability for dev-setup Makefile

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: KozakaiAya sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Azure AD Connect Wizard Screenshots Are Out of Date

The screenshot under Prerequisites is out of date. Please update this and the documentation on how to get here.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d87b17f9-38de-1acf-e18f-96bba2ae77ea
Version Independent ID: 20c9770c-2c11-e172-e66c-76c9632fafce
Content: Azure AD Connect - Update the TLS/SSL certificate for an AD FS farm
Content Source: articles/active-directory/hybrid/how-to-connect-fed-ssl-update.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@aakash-shah Thank you for your feedback . We will investigate and update the thread.

The following issue is being closed due to the age.  If this is still an issue, please re-submit this.  Thank you.
#please-close

The following issue is being closed due to the age. If this is still an issue, please re-submit this. Thank you.
#please-close

Problem has not been resolved - screenshot is still inaccurate.
Please re-open this.


[android/refactor] MusicUtils::musicPlaybackService to non-static mutable property

public final class MusicUtils {
 private static final Logger LOG = Logger.getLogger(MusicUtils.class);
 public static IApolloService musicPlaybackService = null; // <-- this

Having that reference as a mutable static property in MusicUtils keeps causing NPEs.
A refactor needs to be done.

perhaps @votaguz should take a look and think hard how to refactor this so it's robust


fix(1499): Add Typescript defs for public methods

Adds Typescripts defs for public methods. Fixes #1499.

@akki-jat could I get you to double check this will work. I'm a bit green with TS, but I noticed you built the original definitions. Thanks


ScottPlot 4, take text labels into account during renders

Recently the library does not respect the text labels bounding space, so when we call render then the autoscaling might cut off the text labels from the screen.
We could find some solution to address this issue.

Hi @bukkideme, I'm leaving this high priory but marking it defer because I want to prioritize getting high priority ScottPlot 5 issues published before looping back around to this.
In case someone gets to it sooner than me, I think the best solution is to add a "LastRenderedRectangle" property to the Label, then write to it inside the render loop. Perhaps it could be stored in pixel units and coordinate units. Pixel units could be used for mouseover hit detection, and coordinate units could be used for autoscaling.

Actually, that description of the recommended implementation is good enough that I'll probably close this issue for now, and if someone wants to give it a go I'd be happy to review a PR!


excessive extention usage on CA certificates

When GoCA generates a certificate authority (either root or intermediate) the TLS Web Client Authentication and TLS Web Server Authentication extensions are set. CA certificates should be limited to CA activities (Digital Signature, Certificate Sign, CRL Sign).
This behavior can be validated via visual inspection of a certificate with the OpenSSL command: openssl x509 -noout -text -in myca.crt

cert.CreateCACert() appears to be where we setup the usage extensions for CA certificates. Should just be a matter of pruning excessive uses from the ExtKeyUsage and KeyUsage fields.
I want to do some more research to make sure our extension selection meets best practices and to design a test case or two.


Feature/build test

add build test for mros2-mbed.
This workflow was tested by this PR.

Hi @hakuturu583 How do you think about my review comments? IOW, could I fix them myself before merging?

How do you think about my review comments? IOW, could I fix them myself before merging?
Sorry.
I will fix soon.

@takasehideki Thank you for pointed out.
I fixed.


Accessibility feature: Support Esc/Alt-c to abort, Alt-a for Apply and Alt-o for OK

To rely less on mouseclicks:
Alt+<letter, typically the first> is fairly common, and it is supported widely in foobar2000, like file Properties dialogue.
Sure I will - at least for now - have to double click to enter the lyrics editor quickly, but still: when done editing (with keyboard unless it is for syncing), then I would wish for the standard keyboard shortcuts to apply.

Related to #133

Don't know whether to mention it here or in #133 , but:
Ctrl-Enter is foobar2000ish for inserting a linebreak when editing fields.
Slightly odd not to use Alt-Enter, but I guess one needs to adapt to it and don't touch Ctrl-Enter.

Ctrl-Enter is foobar2000ish for inserting a linebreak when editing fields.

Can you give an example of where this is the case? I tried a small handful of text fields that are built into fb2k (IE not provided by 3rd-party components) and none of them appeared to have this behaviour (although admittedly I couldn't find anything that was explicitly a multi-line input field so maybe it's just those?)

Select a file, enter file properties with Alt-Enter.
Double-click any field, say Date - the field name in the left column, not the value column! Or navigate to it and Alt-Enter.
A small window with "Edit value : Date" opens.
Start typing and hit Ctrl-Enter (or Shift-Enter, actually!) for newline. (Not Enter which works like "OK" - and not Alt-Enter, which does nothing.)
The field does not need to be multiline field. That's why I used Date as an example. (Multi-value? Difference will be, if you do this to a multi-value field, there is text "Use ; character to separate multiple values." below the edit window.
That fb2k uses Alt-Enter to open properties explains why it is not used for newline, of course. But now both Alt-Enter, Shift-Enter, Ctrl-Enter and Enter are in use ...


Use the original precision (prior-dotnet-core-3) for double/fload-to-string conversion

PR Summary
Fix #9779
.NET Core changes to return "shortest roundtrippable string" by default for the ToString() method of double and float types. This results in ToString() for double/float values sometimes return a string in 17-digit/9-digit precision format. This PR updated the double/float-to-string conversion in PowerShell to continue using the old precision specifier before the change in .NET Core 3.0.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

@daxian-dbw, your last commit had 14 failures in PowerShell-CI-linux
(These are 5 of the failures)
TabCompletion.Should complete abbreviated cmdlet
Expected exactly 'Import-PowerShellDataFile', but got $null.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: line 16
16:         $res | Should -BeExactly 'Import-PowerShellDataFile'

TabCompletion.Should complete abbreviated function
Expected the actual value to be greater than or equal to 1, but got 0.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1: line 21
21:         $res.Count | Should -BeGreaterOrEqual 1

Temp: drive.TEMP: drive exists
Expected exactly 'Temp', but got $null.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSDrive.Tests.ps1: line 64
64:         $res.Name | Should -BeExactly "Temp"

Get-Command Feature tests.-UseAbbreviationExpansion tests.Can return multiple results relying on auto module loading
Expected a collection with size 2, but got an empty collection.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 39
39:             $results | Should -HaveCount 2

Get-Command Feature tests.-UseAbbreviationExpansion tests.Can return multiple results for cmdlets matching abbreviation
Expected 'Invoke-Command' to be found in collection @(), but it was not found.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 69
69:             $results.Name | Should -Contain "Invoke-Command"

@daxian-dbw, your last commit had 8 failures in PowerShell-CI-macos
(These are 5 of the failures)
Temp: drive.TEMP: drive exists
Expected exactly 'Temp', but got $null.
at <ScriptBlock>, /Users/vsts/agent/2.152.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSDrive.Tests.ps1: line 64
64:         $res.Name | Should -BeExactly "Temp"

Get-Command Feature tests.-UseAbbreviationExpansion tests.Can return multiple results relying on auto module loading
Expected a collection with size 2, but got an empty collection.
at <ScriptBlock>, /Users/vsts/agent/2.152.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 39
39:             $results | Should -HaveCount 2

Get-Command Feature tests.-UseAbbreviationExpansion tests.Can return multiple results for cmdlets matching abbreviation
Expected 'Invoke-Command' to be found in collection @(), but it was not found.
at <ScriptBlock>, /Users/vsts/agent/2.152.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 69
69:             $results.Name | Should -Contain "Invoke-Command"

Get-Command Feature tests.-UseAbbreviationExpansion tests.Will return multiple results for functions matching abbreviation
Expected a collection with size 2, but got an empty collection.
at <ScriptBlock>, /Users/vsts/agent/2.152.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 87
87:                 $results | Should -HaveCount 2

Get-Command Feature tests.-UseAbbreviationExpansion tests.Valid cmdlets works with name i-psdf and module $null
Expected a collection with size 1, but got an empty collection.
at <ScriptBlock>, /Users/vsts/agent/2.152.1/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1: line 62
62:             $results | Should -HaveCount 1

@daxian-dbw, your last commit had 4 failures in PowerShell-CI-linux
DotNetAPI.Should be able to use static .NET classes and get a constant
Expected regular expression '2.718281828459045' to match 2.71828182845905, but it did not match.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Language/Interop/DotNet/DotNetAPI.Tests.ps1: line 9
9: 	[System.Math]::E  | Should -Match $posh_E.ToString()

ParserTests (admin\monad\tests\monad\src\engine\core\ParserTests.cs).Numerical Notations Tests (starting at line 2374 to line 2452).-3.402823E+38 should return -3.4028235E+38, with type [double]
Expected '-3.4028235E+38', but got -3.402823E+38.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1: line 937
937:             ExecuteCommand $Script | Should -Be $ExpectedValue

ParserTests (admin\monad\tests\monad\src\engine\core\ParserTests.cs).Numerical Notations Tests (starting at line 2374 to line 2452).3.402823E+38 should return 3.4028235E+38, with type [double]
Expected '3.4028235E+38', but got 3.402823E+38.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1: line 937
937:             ExecuteCommand $Script | Should -Be $ExpectedValue

Join-String.Should join numeric values Formatted
Expected strings to be the same, but they were different.
Expected length: 16
Actual length:   13
Strings differ at index 3.
Expected: '1.20; 3.40; 5.60'
But was:  '1.2; 3.4; 5.6'
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Join-String.Tests.ps1: line 67
67:         $actual | Should -BeExactly $expected

Enforcing G15 for double type results in a few test failures. Will look into them.

@iSazonov @rjmholt The TryFastTrackPrimitiveTypes method was updated to always honor the format and formatProvider.

Rebased to master to force Windows CI to work properly.

Restarted MacOs Ci.

@iSazonov All CI builds passed. This PR is ready to be merged :)

.NET Core changes to return "shortest roundtrippable string" by default for the ToString() method of double and float types. This results in ToString() for double/float values sometimes return a string in 17-digit/9-digit precision format. This PR updated the double/float-to-string conversion in PowerShell to continue using the old precision specifier before the change in .NET Core 3.0.

Thank you, guys! Appreciate it 🙏 🙏 🙏