Add a Gitter chat badge to README.md

katspaugh/wavesurfer.js now has a Chat Room on Gitter
@thijstriemstra has just created a chat room. You can visit it here: https://gitter.im/katspaugh/wavesurfer.js.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

@katspaugh I'll let you merge this if you think it's ok.

Coverage remained the same at 4.734% when pulling 9280344ef962255378dbd13c12e94e5e19fd2299 on gitter-badger:gitter-badge into 9c822fc4adba99c783d5b305e5df47d456a6d5cc on katspaugh:master.

Thanks, @thijstriemstra!


Exit node IP address not visible in BE when using IPv6

Connected to the Lethernet CA Montreal proxy provider.
Whatsmyip.com show following:
Your Public IPv6 is: 2607:5300:60:120c:0:0:0:1
Your IPv4 is: <IP_ADDRESS>
Your Local IP is: <IP_ADDRESS>
Location: Beauharnois, QC CA
ISP: OVH Hosting Inc.
But the browser extension is showing my local external ip address, the same address as when BE is disconnected. This makes it confusing and made me think BE was disconnected while it actually was connected to the exit node. Everything works but it is a display error. I think it may be related to using IPv6 because the other exit nodes using IPv4 does show exit node IP address in BE.

It looks like I have this problems on other exit nodes too even when they are IPv4 only.
V3.0.0.b2 Arch Linux client. I will try it on windows and see what happens.

The exit node address is not viewed in BE on Windows 10 either.
Does not have to do with ipv6 or ipv4, sorry for that.
Lethean GUI version v3.0.0.b2 54e0b4d
Browser extension 3.0.0
Tested on Lethernet FR (ipv4 only) and Lethernet CA (ipv6 and ipv4).


Use Google TypeScript Style

Searching through the internet I have found quite interesting repository https://github.com/google/gts (Google TypeScript Style), created by Google (WoW), which just add TypeScript style guide, formatter, and linter. It is built on Tslint and prettier. I would remove the necessity of looking for TSlint updates, updating 'stylesheets', everything would be always up to date with Google's standards.
It would also close all my current and future (probably) issues about style conventions.
(although we still can update it's config:
Opinionated, but not to a fault. We recommend you use the default configuration, but if you need to customize compiler or linter config, you can.)
Looking for your feedback bout it :)

Hmm I like this approach. We need to migrate to eslint sooner or later, might as well migrate to this instead.
What would the impact on code be? Are we in line with the "Google style" (can't seem to find documentation on what that is exactly)?

Solved by #1615


 With the debug option set, for me the matched rule that it gets is no_command, which fetches close matches of the comand given. It searches the recently used commands in your history, and executables in the usual executable directories.
The only explanation I have is that you recently used touch, then the first option that it got from your history was touch itself, so it displayed that first. In that case, you should be able to scroll with the arrow keys to get the other commands (including source). If that doesn't work, can you try the same thing again, only with the debug options enabled, and confirm that the same rule (no_command) is being executed?

Seems to be working. Not sure what the issue was before.


correction proposal for issue #908 (sysex event infinite callback loop)

Proposal of correction for Naudio.Midi issue #908 (sysex event infinite callback loop) :

implement a disposeIsRunning instance flag tp avoid re-add the sysex buffer when dispose occur
not firing C# SysexMessageReceived event when a zero length sysex message arrived

Sorry took me a while to get round to this, and thanks for your contribution


my second blog | Donaldhan Blog

https://donaldhan.github.io/tech/2017/10/03/my-second-blog.html
my secong blog write by markdown, power by jekyll in github page

test remark
if( no error...)
test finish....

all right ...
      effect...


Pantry / Gear section perhaps

First item: spice rack

Possible gear:
Non-Stick:
Winco non-stick pan, seen on Brian Lagerstrom's channel, one with the blue handle.
There are also some from Choice: https://www.webstaurantstore.com/choice-10-aluminum-non-stick-fry-pan-with-blue-silicone-handle/407FRYPNS10B.html


Adding a tag via Batch Edit removes other tags on the observations

Use Batch Edit to add a tag to observations which already have tags. After saving, the tag added via Batch Edit will be there but all other tags are gone.

What do you think it should do, just add to the existing list of tags?

Yeah, that's the behavior I would expect, although I see where you're coming from. I know some have been surprised that they lose their existing tags.

I would prefer it to not delete other tags. Otherwise bulk editing tags is
nearly impossible. But on the other hand I don’t do it that much.
On Wed, Jul 25, 2018 at 8:05 PM tiwane<EMAIL_ADDRESS>wrote:

Yeah, that's the behavior I would expect, although I see where you're
coming from. I know some have been surprised that they lose their existing
tags.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/inaturalist/inaturalist/issues/1856#issuecomment-407934319,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG1tk7VDUjZIv41VN2AHZweaXKENQfW_ks5uKQeygaJpZM4VfYjM
.

--
Sent from Gmail Mobile


reaper: init at 5.93

Motivation for this change
Linux native builds of REAPER are now available.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

The UI is hideous. I've got to see if this is the case on other Linux distributions as well.

yep, the UI looks like from the 1990s, in particular the fonts. Incorrect/missing font path, maybe?

eval error was unrelated, fixed
@GrahamcOfBorg eval

Anyway, it builds and runs, so I'll merge it now and you can improve the looks later.


Request -- Add image path to get-service and get-process

Sometimes it does is a good idea to know the image path when using get-service and get-process.

U may ask why I do not use bellow cmdlet directly , but I think get-process and get-service is much easier.
Get-WmiObject win32_service | select Name, DisplayName, State, PathName | ft -AutoSize
Get-CimInstance -ClassName win32_service | select Name, DisplayName, State, PathName | ft -AutoSize

It is dup #3322


python311Packages.pyskyqremote: 0.3.25 -> 0.3.26

Diff: https://github.com/RogerSelwyn/skyq_remote/compare/refs/tags/0.3.25...0.3.26
Changelog: https://github.com/RogerSelwyn/skyq_remote/releases/tag/0.3.26
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252293 run on x86_64-linux 1

4 packages built:

python310Packages.pyskyqremote
python310Packages.pyskyqremote.dist
python311Packages.pyskyqremote
python311Packages.pyskyqremote.dist


Problems with importing itergp: module named 'fcntl' not found

I've tried to import itergp, as stated in the README file, but got the error:
ModuleNotFoundError: No module named 'fcntl'
It seems as the fcntl module is not available on Windows. So is it nevertheless possible to import itergp on a windows pc?

Hi @L-in-da. We unfortunately just realized the issue you describe. The package KeOPs that IterGP depends on does not have Windows support yet (see also https://github.com/getkeops/keops/issues/43).  KeOps enables large-scale matrix-vector multiplies with a kernel matrix.
We are working on a solution for the homework currently. For now if you have a team member with a mac or linux machine try using that. We'll ensure this will not affect bonus points for you negatively.

I just implemented a hotfix, that avoids the use of KeOps on Windows. This means on Windows you may not be able to scale to very large kernel matrices (n > 10000), since the implementations works with dense matrices. That should not be an issue for the homework however.


MultiWorkerMirroredStrategy() hanging

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information
I have access to two computers and below give the info for both.

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Computer 1: Windows 10, Computer 2: Windows 10
TensorFlow installed from (source or binary):
TensorFlow version: 2.4.1 on both machines
Python version: 3.8.5 on both machines
Installed using virtualenv? pip? conda?: For both:  Installed using pip install tensorflow-gpu after manually installing the appropriate Nvidia driver, coda toolkit, cudnn versions.
CUDA/cuDNN version: CUDA 11.0 and cuDNN 8.0.4. Also both computers have an NVIDIA driver of 450x or higher
GPU model and memory: Computer 1: NVIDIA Quadro P2000 (GPU memory of 36.8 GB), Computer 2: NVIDIA Quadro P5000 (GPU memory of 79.9 GB)

Note: the CUDA, cuDNN were installed on each machine manually, I am not using docker.
Describe the problem
In case this might be an issue/helps to know, I am on a Mac remoting into my work's computer (Computer 1) using Microsoft Remote Desktop. From Computer 1 (Windows OS), I am remoting into Computer 2 (Windows OS as well) using Remote Desktop Connection (the GUI for RDP -- so not using ssh). Both these computers have a GPU as specified above and want to use them to create a two node distributed training job using tensorflow's distribute.multiworkermirroredstrategy. I believe my issue is that I do not understand if the nodes can communicate with each other.
Provide the exact sequence of commands / steps that you executed before running into the problem
Below is my script "worker.py"
def create_model():
    model = Sequential()
    model.add(Bidirectional(LSTM(128, return_sequences=True), input_shape=(T, D)))
    model.add(TimeDistributed(Dense(1, activation='relu')))
    return model

if __name__ == "__main__":

    random.set_seed(1)

    parser = argparse.ArgumentParser()

    # inputs for setting environment variable
    parser.add_argument('-node1', default=None, required=True, help='Node 1 IP and port')
    parser.add_argument('-node2', default=None, required=True, help='Node 2 IP and port')
    parser.add_argument('-type', default=None, required=True, help='Node type')
    parser.add_argument('-index', default=None, required=True, help='Node number', type=int)

    args = parser.parse_args()
    node_1 = args.node1
    node_2 = args.node2
    worker_type = args.type
    worker_index = args.index

    # set environment variable
    os.environ['TF_CONFIG'] = json.dumps({
        'cluster': {
            "worker": [node_1, node_2]
        },
        'task': {'type': worker_type, 'index': worker_index}
    })

    # load data
    with open('data/X.json', 'rb') as f:
        X = pickle.load(f)

    with open('data/y.json', 'rb') as f:
        y = pickle.load(f)

    # split data, set random state (for replicability)
    X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=0.2, random_state=1)
    _, T, D = X_train.shape

    # dynamic memory allocation
    # gpu = config.experimental.list_physical_devices('GPU')
    # config.experimental.set_memory_growth(gpu[0], True)

    # set training strategy
    strategy = distribute.MultiWorkerMirroredStrategy( )
    print(f"Number of devices: {strategy.num_replicas_in_sync}")

    num_epochs = 10000
    batch_size_per_replica = 64
    batch_size = batch_size_per_replica * strategy.num_replicas_in_sync

    # create data structure
    train_data = data.Dataset.from_tensor_slices((X_train, y_train))
    val_data = data.Dataset.from_tensor_slices((X_test, y_test))

    train_data = train_data.batch(batch_size, drop_remainder=True)
    val_data = val_data.batch(batch_size, drop_remainder=True)

    # Disable AutoShard.
    # options = data.Options()
    # options.experimental_distribute.auto_shard_policy = data.experimental.AutoShardPolicy.OFF
    # train_data = train_data.with_options(options)
    # val_data = val_data.with_options(options)

    with strategy.scope():
        model = create_model()
        model.compile(
            loss='mse',
            optimizer='adam',
            metrics=[metrics.RootMeanSquaredError()],
        )

    # fit
    model.fit(
        train_data,
        epochs=num_epochs,
        validation_data=val_data,
        # callbacks=[cp_callback, es_callback, tbd_callback]
    )

    # save
    # model.save('model/model.h5')

From the documentation, I understand that this script has to be run on all machines (in my case 2) and set the TF_CONFIG environment variable correctly on both machines. And so I am doing:
Command line machine 1: python worker.py -node1 <IP_ADDRESS>:8081 -node2 <IP_ADDRESS>:8081 -type worker -index 0
Command line machine 2:  python worker.py -node1 <IP_ADDRESS>:8081 -node2 <IP_ADDRESS>:8081 -type worker -index 1
Once I run the above command I see the following on machine 1:
2021-02-04 10:24:32.161847: I tensorflow/compiler/jit/xla_cpu_device.cc:41] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-02-04 10:24:32.171344: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library nvcuda.dll
2021-02-04 10:24:32.206509: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:65:00.0 name: Quadro P2000 computeCapability: 6.1
coreClock: 1.4805GHz coreCount: 8 deviceMemorySize: 5.00GiB deviceMemoryBandwidth: 130.53GiB/s
2021-02-04 10:24:32.213804: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-02-04 10:24:32.233653: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-02-04 10:24:32.237158: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-02-04 10:24:32.247535: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-02-04 10:24:32.254801: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-02-04 10:24:32.270340: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-02-04 10:24:32.278635: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-02-04 10:24:32.284876: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-02-04 10:24:32.288053: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-02-04 10:24:32.291911: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-02-04 10:24:32.300368: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:65:00.0 name: Quadro P2000 computeCapability: 6.1
coreClock: 1.4805GHz coreCount: 8 deviceMemorySize: 5.00GiB deviceMemoryBandwidth: 130.53GiB/s
2021-02-04 10:24:32.305947: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-02-04 10:24:32.309708: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-02-04 10:24:32.312512: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-02-04 10:24:32.315162: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-02-04 10:24:32.317685: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-02-04 10:24:32.320235: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-02-04 10:24:32.323467: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-02-04 10:24:32.326515: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-02-04 10:24:32.329607: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-02-04 10:24:32.868210: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1261] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-02-04 10:24:32.871587: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1267]      0
2021-02-04 10:24:32.873963: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1280] 0:   N
2021-02-04 10:24:32.876398: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1406] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 3835 MB memory) -> physical GPU (device: 0, name: Quadro P2000, pci bus id: 0000:65:00.0, compute capability: 6.1)
2021-02-04 10:24:32.883411: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-02-04 10:24:32.889654: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1720] Found device 0 with properties:
pciBusID: 0000:65:00.0 name: Quadro P2000 computeCapability: 6.1
coreClock: 1.4805GHz coreCount: 8 deviceMemorySize: 5.00GiB deviceMemoryBandwidth: 130.53GiB/s
2021-02-04 10:24:32.896221: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
2021-02-04 10:24:32.900555: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublas64_11.dll
2021-02-04 10:24:32.903795: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cublasLt64_11.dll
2021-02-04 10:24:32.906767: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cufft64_10.dll
2021-02-04 10:24:32.909681: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library curand64_10.dll
2021-02-04 10:24:32.912606: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusolver64_10.dll
2021-02-04 10:24:32.916783: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cusparse64_11.dll
2021-02-04 10:24:32.920150: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudnn64_8.dll
2021-02-04 10:24:32.923249: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1862] Adding visible gpu devices: 0
2021-02-04 10:24:32.925742: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1261] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-02-04 10:24:32.928836: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1267]      0
2021-02-04 10:24:32.932095: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1280] 0:   N
2021-02-04 10:24:32.934222: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1406] Created TensorFlow device (/job:worker/replica:0/task:0/device:GPU:0 with 3835 MB memory) -> physical GPU (device: 0, name: Quadro P2000, pci bus id: 0000:65:00.0, compute capability: 6.1)
2021-02-04 10:24:32.939752: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-02-04 10:24:32.948503: I tensorflow/core/distributed_runtime/rpc/grpc_channel.cc:301] Initialize GrpcChannelCache for job worker -> {0 ->  <IP_ADDRESS>:8081, 1 -> <IP_ADDRESS>:8081}
2021-02-04 10:24:32.953737: I tensorflow/core/distributed_runtime/rpc/grpc_server_lib.cc:411] Started server with target: grpc://<IP_ADDRESS>:8081

And see the same similar things on machine 2, essentially hanging at "Started server with target: grpc://<IP_ADDRESS>:8081."
I am not sure what the issue could be? Could it be related to the ports, I chose 8081? Is it installation-wise? I have tried many things suggested on GitHub and none seem to work. Could firewalls, very secure networks be causing this issue?
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Per one of the GitHub issues I added the environment variable GRPC_VERBOSITY=DEBUG on machine 1 and got back from the command line
D0204 10:40:31.617000000  8780 external/com_github_grpc_grpc/src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc:314] Using native dns resolver
I0204 10:40:31.624000000  8780 external/com_github_grpc_grpc/src/cpp/server/server_builder.cc:332] Synchronous server. Num CQs: 1, Min pollers: 1, Max Pollers: 2, CQ timeout (msec): 10000

Googling I found "Make sure the nodes can ssh into each other without the request of the password. The most convenient way to do this is to use ssh keys instead of password authentication." Could this be the issue? I am new to setting up multi-node training jobs and was hoping to use tensorflow's API but maybe for the setup I have it might not be ideal?

Hi @inespancorbo, I don't see anything immediately suspect in your code. Have you tried explicitly setting the autoshardpolicy to DATA? And can you also confirm that you're able to run the code on a single machine? You can use MultiWorkerMirroredStrategy on a single machine (just don't pass in both IP/ports in the TF Config).

Hi @nikitamaia I will try both suggestions and see what happens (I believe I have tried setting autoshardpolicy to DATA but will try again). However, could the ssh-ing be an additional issue? As in, I am using RDP for remoting into the different machines and I do not believe ssh is set up

log.log
I ran the same python script on both machines. One works fine and the other one get an error after some iterations of the first epoch. I have attached the log file.

Ah okay, seems we're closer to identifying the problem! Please take a look at this similar issue here #45987. Before trying to get multi worker mirrored strategy working, we should confirm that your GPU(s) are working.

Thanks! I updated to the Nvidia driver suggested in the post and running multiworkerstrategy() on each machine individually works fine. When I do it jointly (setting the TF_CONFIG environment variable) it is able to train for a couple epochs until it raises the following error. I am attaching the command output from both machines in the form of a log file.
log.log
log.log

I have set the autoshardpolicy to DATA and I still get the same error.

log.log
log.log
Update: see these log files as opposed the ones above.

Hi @inespancorbo did you mean to close this issue? From the logs it seems it runs for 352 epochs and then crashes. Did you find a solution?


tls: implement SPIFFE Certificate Validator for independent multiple trust domain support

Signed-off-by: Takeshi Yoneda<EMAIL_ADDRESS>This is the sequel to the previous refactoring PR: https://github.com/envoyproxy/envoy/pull/14757
Commit Message: tls: implement SPIFFE Certificate Validator for independent multiple trust domain support.
Additional Description: Adds the extension point for certificate validations, and its first implementation for SPIFFE multi trust domain support in single listener. Resolves https://github.com/envoyproxy/envoy/issues/14614 and https://github.com/envoyproxy/envoy/issues/9284.
Risk Level: low (only adding the  new extension point and one implementation for it)
Testing: unit tests and integration tests.
Docs Changes:
Release Notes: tls: implement SPIFFE Certificate Validator for independent multiple trust domain support.
cc @lizan

/retest

the flaky verify example is of websocket and nothing to do with this PR.  It seems like the same thing happens in other PRs. So I am making this ready for review.

/retest

/retest

/retest

@lizan could you take another look?

/lgtm api
Where is the reverted part PR, or do you want to keep default validator non-extension?
This PR itself looks good to me. @ggreenway for non-Tetrands review.

do you want to keep default validator non-extension?

I'm now in favor of keeping default validator non-extension, but I don't have any concrete reason for that. So I would like to have you and @ggreenway's opinion. WDYT?

do you want to keep default validator non-extension?

I'm now in favor of keeping default validator non-extension, but I don't have any concrete reason for that. So I would like to have you and @ggreenway's opinion. WDYT?

What's the context of this question? Is it whether we should apply the default-validator in addition to the custom-validator?

@ggreenway I mean whether we should use "envoy_cc_extension" for default validation to be aligned with SPIFFE validator as I did in this PR. In anyway, that should be done in another PR and doesn't affect this PR.

coverage failure is irrelevant to this PR (same happens to other PRs): Code coverage for source/server is lower than limit of 94.5 (94.4).
/retest

/retest

/retest

@ggreenway I think all the comments are addressed. PTAL 👍

This is super exciting! I'm a maintainer on the SPIFFE and SPIRE projects and am happy to look at the validation logic.

/retest

@lizan I believe we are good to go now. Could you take another look? Thanks!

@mathetake two last things

add an entry in CODEOWNERS the new extension
add a note in version history

@lizan done!

/retest


Optimization should happen automatically

Users shouldn't have to worry about optimizing their pipelines. The system should handle this automatically. It would be good to have Optimizer.execute(pipeline) happen automatically as a first step of pipeline.apply(inputRdd) - or something.
Andy major reasons why this can't work?

We'll need to prevent an infinite recursion (but that shouldn't be too hard).
What is a bigger concern with this is we want optimization to only happen once, as it may take a bit of time. But, our pipelines are currently immutable so this would happen every time you try applying it to any data.

I'm quoting you on the first one when you become a rich and famous computer scientist. ;)
On the second part - i'm not terribly worried about this. We can build a catalog of pipelines and store them (and their optimized counterparts) somewhere, or we can add optimized pipeline as internal state (an unassigned var in the constructor). Important details but ones we can figure out. For now, optimization is a short procedure and one that we can afford to "waste" time doing multiple times.
The important part here is we want a clean separation of user-level concerns and system-level concerns.

Do you want this to happen both for single-item "apply" and bulk-rdd "apply"'s?

What if the implementation is just =

I'm pretty sure you'll still end up with the infinite recursion if you do that. What I'm going to do is just call the internal execution functions of the optimized pipeline directly, as opposed to it's apply method.


error: (10038, 'An operation was attempted on something that is not a socket')

In Windows :
[httpd, self.stop_read], [self.stop_write], []
error: (10038, 'An operation was attempted on something that is not a socket')
Expected : It should say capture ok   , But my firewall assked for approval to get them working . I have given access. but still is not working

Fixed. Thanks for the report!

https://github.com/SpectoLabs/hoverpy/releases/tag/0.1.17

It works as expected in latest version


Add gem about bit manipulations

Also based on #224 (will be rebased) - fixes #130.

I think the gems section needs a navigation redesign. I agree that it's a cool idea to present these ideas in the tour format. But if you're going to have lots of gems as your PRs imply, they shouldn't be accessed from a dropdown. Preferably, the nav would link to a page with the gems grouped into beginner and advanced techniques.

I think the gems section needs a navigation redesign. I agree that it's a cool idea to present these ideas in the tour format. But if you're going to have lots of gems as your PRs imply, they shouldn't be accessed from a dropdown. Preferably, the nav would link to a page with the gems grouped into beginner and advanced techniques.

I fully agree - see #269 (restructure chapters) and #52 (vertical left menu).

Ready for destruction ;-)
Out of interest does anyone know whether the fact that bitfields are no lvalues is a feature or bug?
vec.x = 2; // OK
vec.x += 2; // ERROR: vec.x is no lvalue

@wilzbach I would consider this "as designed". Bitfields need to do bit fiddling internally and if lvalue ought to be supported an opaque type would have to be returned that writes changes back. At first this sounds doable but increased the complexity and maybe hurts performance a little..

@wilzbach I would consider this "as designed". Bitfields need to do bit fiddling internally and if lvalue ought to be supported an opaque type would have to be returned that writes changes back. At first this sounds doable but increased the complexity and maybe hurts performance a little..

After that I asked on IRC and I was told that there no apparent reason and it's just a missing feature. Hence I opened a feature request:
https://issues.dlang.org/show_bug.cgi?id=16187
(I don't feel strongly about this, so if either the performance or complexity increase turns out to be true, I will weep a bit, but survive).

No, @stonemaster is right - you can't do this without returning a proxy, which would be pessimization for the general case. The only that could help is something like opDispatchOpOpAssign(string member, string op), but good or bad it doesn't exist.

BTW there  several other interesting applications of bit manipulation that I didn't see mentioned:

using built-in integers for generating all possible subsets of a random access range of fixed size (e.g. 32 or 64)
using http://dlang.org/phobos/std_bitmanip#.BitArray to store a general set (of any size)
using http://dlang.org/phobos/std_bitmanip#.bitsSet to get a range of the indexes of the bits that were set, which useful when these indexes are used to index another array and you need to find the first element in it that passes a certain condition: allowed.bitsSet.countUntil!(idx => arr[idx].isOK)
using std.bitmanip : peak, read to parse any binary format (e.g. network packets, image formats, etc), especially useful when you have described the format with structs (i.e. your not reading it an int at a time).

In my experience bitFields is a more rarely used, but it's still a nice showcase of D's CT power.


Throwing errors in console

I just set it up and it's showing this in the console.
@urql/devtools 0.0.3
devtools 0.0.3
urql 1.4.0

Hey @levrik
I've checked out my branches locally and it seems we have to publish a new version of the chrome extension itself. We'll make work of this, thanks for bringing this to our attention. Highly appreciated.

This is due to how we previously triggered our content script. This is nothing to worry about - just annoying to see.
The next release will have this fixed :+1:


test with k8s v1.20

Add k8s v1.20 to the matrix for testing.

/kind

Fixes #

Release Note

- :gift: Add new feature, run e2e tests with k8s v1.20

Docs

/lgtm


⚠ Roblox Site has degraded performance

In 99e67e3, Roblox Site (roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 5156 ms

Resolved: Roblox Site performance has improved in 2f451e0 after 9 minutes.

Resolved: Roblox Site performance has improved in af6699f after 9 minutes.


get data from the api and save to database

I am thinking we should best use Volley for this ? My experiences with fetching Json data have been the best with Volley.

I have never had experience with Volley, but It looks good :)

@championswimmer I also think that volley would be the best option. Intact we have used it in all the other event apps as well.

Please provide a link because I am not familiar with what you are talking about.

@leto Volley is a networking library from google itself. See this https://developer.android.com/training/volley/index.html

Volley is an extension of implementation detail, if you are look for RESTful consumption of web services, you can checkout Retrofit, Along with OkHttp it makes the code much cleaner and easier to read. With Volley I found out that extra time was wasted in implementation of serialization schemes etc, maintaining the life cycle of the objects etc. A combination of Retrofit+OkHttp+Gson handles the entire network stack in my case. I would suggest we use this, but using Volley is fine as well,except that Retry logic (in case of limited network connectivity) and other stuff you would need to take care of by yourself. With Retrofit, OkHttp this behavior is easy to implement.
Cheers

@creativepsyco your recommendation of Retrofit+OkHttp+Gson sounds like a best practice. Could you describe it a bit more so @mananwason can implement your idea? Thanks!

Yes @creativepsyco Please help me get started, I have never used these api's, but I am more than willing to learn ASAP. Thanks

Hi @mananwason you can check out https://github.com/creativepsyco/intercom-android-sdk/tree/master/intercom I did this a while back. You can see Retrofit, Gson and OkHttp being used together. There are tests as well under androidTest. With Retrofit you can specify the schema of the JSON as a Java Bean and provide this under the retrofit Interface. For example Users provides a REST interface to Intercom's API. The protocol is JSON mapped out as normal Java Beans. The advantage is that while testing you can mock out the API and provide JSON files to fix up tests and check out edge conditions. Check it out and I shall be available on Gitter for any questions you may have.
Cheers

Thanks @creativepsyco I'll get back to you for any questions I have :smile:

Since it was earlier discussed, let me bring it up here,
For twitterwall, if we use loklak library, we should probably use jackson
instead of gson, because jackson is already a dependency of loklak,
I do not know the inner dependencies of okhttp and retrofit, but I am
little apprehensive of weighing the app down with too many libraries, if we
can manage just as well with less.
On 19 May 2015 at 10:23, Manan Wason<EMAIL_ADDRESS>wrote:

Thanks @creativepsyco https://github.com/creativepsyco I'll get back to
you for any questions I have [image: :smile:]
—
Reply to this email directly or view it on GitHub
https://github.com/fossasia/open-event-android/issues/4#issuecomment-103336335
.

@mananwason
About the json parser that we are using. Please see above
On May 19, 2015 10:09 PM, "Arnav Gupta"<EMAIL_ADDRESS>wrote:

Since it was earlier discussed, let me bring it up here,
For twitterwall, if we use loklak library, we should probably use jackson
instead of gson, because jackson is already a dependency of loklak,
I do not know the inner dependencies of okhttp and retrofit, but I am
little apprehensive of weighing the app down with too many libraries, if we
can manage just as well with less.
On 19 May 2015 at 10:23, Manan Wason<EMAIL_ADDRESS>wrote:

Thanks @creativepsyco https://github.com/creativepsyco I'll get back
to you for any questions I have [image: :smile:]
—
Reply to this email directly or view it on GitHub
https://github.com/fossasia/open-event-android/issues/4#issuecomment-103336335
.

Oh so we we'll be using jackson?


[DOCS] is there any resources or practices so far?

Description
@krishguptadev is there any practices or resources in this repo? I can’t seem to see any or files related. Unless it hasn’t progressed to that part yet, I can help and give resources as I have some. Thank you.
Screenshots
No response
Additional information
No response

It's in progress #12, but yes we do need more resource, you are welcome to help us :D

Thank you, I will work on it

Do I give links and resources? Or do I write documents explaining open source best practices? I have found resources, if you would like I can share. Thank you.

@CodingSpecies, it should be both. you can take https://github.com/thedaviddias/Front-End-Checklist as a reference 🙂


add craco and craco-workbox to override config

this should hopefully fix the maxsize error?

closes #53


No endpoint  could be found for: direct://lra-compensation

I'm trying to run the Saga Camel K example, but I'm facing the folloing error on the saga service:
Failed to start application (with profile prod): org.apache.camel.NoSuchEndpointException:
No endpoint could be found for: direct://lra-compensation, please check your classpath contains the needed Camel component jar

Also, I tried to create the following route with an direct://lra-compensation endpoint just for testing:
from("direct://lra-compensation")
.log("Hey, I shouldn't be here!");

And I get the error
Failed to start application (with profile prod): org.apache.camel.FailedToStartRouteException:
Failed to start route route4 because of Multiple consumers for the same endpoint is not allowed: direct://lra-compensation

This is so weird. After all, does the endpoint exist or not?

What version of Camel K are you using? I've just tested the following with version 1.10.3 and it works correctly:
      from("timer:java?period=1000")
        .setBody()
          .simple("Hello Camel K from ${routeId}")
        .to("direct://lra-compensation");

        from("direct://lra-compensation")
           .to("log:info");

I ran kamel version and got Camel K Client 1.9.2.
Oh, notice that the direct://lra-compensation endpoint probably is created by Camel. I dint't directly use that endpoint in my project.

I've tried to run the example with 1.10.3 but it fails to start. I think it should be reviewed with the newest syntaxt expected by Camel 3.18+ versions. As for the direct endpoint it works correctly.

Okey, I understand which is the problem now. The route is generated dynamically, and in that case we're not able to detect the components (https://github.com/apache/camel-k/issues/527). In order to workaround this, you need to run the Saga route with -d camel:direct and include the direct component dependency.

Ok, It worked, thanks!
I opened the #3883 PR to fix this issue.

Just an additional question. Here I had difficulties with the logs.
Sometimes it takes a long time to update the logs in the terminal.
Both the log with kamel logs <service> and the log with kubectl logs <pod> are not updated as often as expected (every 5 seconds).
Any guidance?

Just an additional question. Here I had difficulties with the logs. Sometimes it takes a long time to update the logs in the terminal.
Both the log with kamel logs <service> and the log with kubectl logs <pod> are not updated as often as expected (every 5 seconds).
Any guidance?

I guess it depends on the kubernetes cluster. The kamel logs is using APIs exposed by kubectl if I am not wrong (so, they're equivalent)


Migrate to .NET Standard

Has this work been started yet?

No, not yet, as we're fairly busy at the moment. If all goes to plan, though, work on SharpDB 1.0 will start next week ;)
Don't worry, this is one of our top priorities.

I'm trying to do it, and I'll submit a PR later!

Okay, good luck! :)


Add information_schema examples

Closes #2956.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d774e9c8b21604643f46e022635256524a07d246/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fb52059b574b0c3c100d7cb6635315a20105cd65/


Allow for dynamic setting of Oraclize gas prices for callback

Currently, these are set at 20 gwei which is the default from Oraclize.it - in times of network stress we may need to allow the contract creator to increase these in order for the contract to be forced in to settlement.
This needs to be thought about carefully, as it is possible a contract creator will not care to push the contract into settlement.  Potentially the MKT token contract could be the one to do this.
more thought on this is needed.

Would like to work on this issue. @pelsasser I can research a little bit about dynamic fee setting.

@maektwain - with the current implementation this may actually not be possible.  It will be dependent upon oraclize.it
Some background -
Oraclize.it currently set the default gas price for the callback from them at 20 gwei.  This is typically a very high amount and the transactions get processed very quickly. However in times of network congestion this could mean that a callback to settle the contract is delayed.  This isn't a massive problem, since the payload for that transaction (the settlement price) isn't what is delayed, just the processing of that settlement price.
Oraclize.it may not offer the functionality to change the needed call back gas after a query has been created since that wold effect the cost of the query itself.
Happy to have you research it, but it may be a dead end for the time being, and it may also not be that big of an issue when we consider what is actually being delayed in a congested network state.

Closing.


Add the 3 files required for tinyprintf

tinyprintf originally from http://www.sparetimelabs.com/tinyprintf/index.html

There is no stdin, stdout or stderr provided with the FT9xx SDK libraries. The tinyprintf code has been used successfully as a replacement. It is currently installed with the SDK when the toolchain is installed. Placing it here makes it easier to obtain. Many thanks to Kustaa Nyholm http://www.sparetimelabs.com/tinyprintf/index.html


Add JET tests

This should help with experimenting / identifying why the PhaseEquil_ρeq is allocating (which is significantly worse in #100, for some reason).

bors r+


edit manager

production-order-manager.js

Coverage increased (+0.003%) to 66.125% when pulling 3c05dbb11c2ee51cc2558ea7ef8d1dfa7ef42007 on jarfva:dev into d7ad29734ab34a5400c1ff5a076cb3a1ac9e15b0 on danliris:dev.


Remove duplicated contents for accessing the API server

The topic of accessing the API server can be found in two places. This is not good.

/kind cleanup

/lgtm

Applying approve label from @sftim in an previous comment
/approve


[Additional Parameter Request] Codeunit 80 Sales-Post - OnAfterValidatePostingAndDocumentDate

Hi Team,
In codeunit 80 we need possibility to have additional checks in the procedure ValidatePostingAndDocumentDate. Standard publisher OnAfterValidatePostingAndDocumentDate would suit us if it had additional parameter ReplacePostingDate: Boolean and ReplaceDocumentDate: Boolean.

local procedure OnAfterValidatePostingAndDocumentDate(var PurchaseHeader: Record "Purchase Header"; CommitIsSuppressed: Boolean; PreviewMode: Boolean; ReplacePostingDate: Boolean; ReplaceDocumentDate: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Implement RSASSA-PKCS1-V1_5-SIGN/VERIFY with EMSA-PKCS1-v1.5-ENCODE

I had a go at this since I need it, open to suggestions or refactoring.
Addresses https://github.com/mirleft/ocaml-nocrypto/issues/119

Have some questions:

The calculation of minimum key size is done here and here. The cdiv rounding-up means that we accept keys that are smaller than the minimum length (hence the -7). Example: For SHA512 I would expect the minimum key size to be 752 bits: 512 + len(asn1 stuff == 19*8 == 152) + (min_pad == 11*8 == 88), which is 94 bytes, but due to the rounding up we accept key sizes down to 745 bits (744 and below are rejected with an Insufficient_key exception). This seems counter-intuitive to me, but the self-verification works, so I kept it like this. Is it intentional? I couldn't find a third-party RSA+PKCS1 library where it was easy to generate keys with strange sizes, so I haven't tested interoperability with other implementations.

I'm not currently using constant-time operations for comparing the structs, I guess I should?

The Travis check for 4.03 fails because of a missing dependency on ppx_deriving: https://travis-ci.org/mirleft/ocaml-nocrypto/jobs/233434937#L914

I think I fixed the link between Hash.S.t and Rsa.PKCS1.S.t now.
Merging Hannes' dup PR first, and adding support for that here, would allow me to not destroy the Hash.S.t when signing (that would be awesome): https://github.com/mirleft/ocaml-nocrypto/pull/125

Re: rounded-up key sizes: the first byte of PKCS paddings is 0x00 -- I presume for this reason exactly -- so the key can be up to 7 bits smaller than the padded message while the message still denotes a number smaller than the modulus.
It's total, delightful, pedantry because I doubt anyone ever uses keys with sizes not divisible by 8.

Ah, that makes sense!

👋


TEST: add cpp attribute example from docs

Add a test of attribute decorators from the docs to exercise the attribute getter/setter decorators

Close/open to rerun tests

the test still fails, I don't understand why. It passes locally, and seems to have the correct paths. The relevant part of the log is:
Compiling rect.pyx because it changed.

[1/1] Cythonizing rect.pyx

running build_ext

building 'rect' extension

creating build

creating build/temp.linux-x86_64-2.7

gcc -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -O0 -ggdb -Wall -Wextra -fPIC -I/home/travis/build/cython/cython/docs/examples/userguide/wrapping_CPlusPlus -I/home/travis/build/cython/cython/docs/examples/userguide/wrapping_CPlusPlus -I/opt/python/2.7.14/include/python2.7 -c rect.cpp -o build/temp.linux-x86_64-2.7/rect.o

/home/travis/build/cython/cython/Cython/Compiler/Main.py:344: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /home/travis/build/cython/cython/TEST_TMP/2/run/cpp_class_attrib/rect.pyx

  tree = Parsing.p_module(s, pxd, full_module_name)

gcc: error trying to exec 'cc1plus': execvp: No such file or directory

error: command 'gcc' failed with exit status 1

FAIL

Is it unable to find rect.cpp ? That should be the output of cythonize, no?

No - I think it's failing to find cc1plus. I think Travis splits the C and C++ tests. I imagine C++ isn't installed on the version that runs the C tests. I think you need to add tag: cpp so that it only gets run in C++ mode and not in C mode (e.g. https://github.com/cython/cython/blob/master/tests/run/cpp_assignment_overload.srctree)

tests now pass with the new CYTHON_PROJECT_DIR environment variable

ping

:+1:


Introduce separate CSS file

We are currently including our custom CSS mods within the oxygen.css file.
Eventually we may choose to move our CSS declarations to a dedicated f13ldman.css file, and include that in the export process.

Makes absolute sense. Shall I implement it?


Add Dependency-Track

Add entry for Dependency-Track https://dependencytrack.org/

Dropped the regex and template, and a few other fields with default values. The default regex does a good job: https://rubular.com/r/qPCcQLdjYjEZhc
Slightly expanded the text as well. Will do a final review and merge.


Cyclotron Installation on node v7.2 npm 3.10.9

I have try to install cyclotron on Debian Jessie
npm -v  3.10.9
node -v v7.2.0
I got the following error:
root@15e0daa602b2:~/cyclotron-1.43.0/cyclotron-site# gulp server
[11:27:02] Requiring external module coffee-script/register
/root/cyclotron-1.43.0/cyclotron-site/node_modules/socket.io/lib/store.js:35
Store.prototype.proto = EventEmitter.prototype;
^
TypeError: Cannot read property 'prototype' of undefined
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/socket.io/lib/store.js:35:41)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/socket.io/lib/manager.js:16:13)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/socket.io/lib/socket.io.js:87:19)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/socket.io/index.js:8:18)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/karma/lib/server.js:1:72)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/node_modules/karma/lib/index.js:3:18)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/gulpfile.coffee:50:9)
at Object. (/root/cyclotron-1.43.0/cyclotron-site/gulpfile.coffee:1:1)
at Module._compile (module.js:571:32)
at Object.loadFile (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:16:19)
at Module.load (/root/cyclotron-1.43.0/cyclotron-site/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Liftoff.handleArguments (/usr/lib/node_modules/gulp/bin/gulp.js:116:3)
at Liftoff. (/usr/lib/node_modules/gulp/node_modules/liftoff/index.js:198:16)
at module.exports (/usr/lib/node_modules/gulp/node_modules/flagged-respawn/index.js:17:3)
at Liftoff. (/usr/lib/node_modules/gulp/node_modules/liftoff/index.js:190:9)
at /usr/lib/node_modules/gulp/node_modules/liftoff/index.js:164:9
at /usr/lib/node_modules/gulp/node_modules/v8flags/index.js:108:14
at /usr/lib/node_modules/gulp/node_modules/v8flags/index.js:36:12
at /usr/lib/node_modules/gulp/node_modules/v8flags/index.js:47:7
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
at Module.runMain (module.js:607:11)
at run (bootstrap_node.js:420:7)
at startup (bootstrap_node.js:139:9)
at bootstrap_node.js:535:3

I think this is due to an out-of-date version of Karma.  I just pushed a change which upgraded the versions, can you npm install and try again?

solved

There is still issue with the API, Once i try to use the API for example call 'tags' the API stuck.
I downgrade the Node version to 6 and it's solved.

Hi @lshahar, I just pushed a release that should fix the API on Node 7.x, can you pull and try again?

Current npm install output:

npm WARN deprecated<EMAIL_ADDRESS>Please use gulp-clean-css
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>Use the globby package instead
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Deprecated, use jstransformer

graceful-fs warns that it isn't compatible with node 7

I've tested pretty thoroughly on Node 7 and haven't run into any issues, so hopefully these are just warnings and can be safely ignored.
It looks like Gulp 3.9.1 is a major culprit behind most of these warnings, but that's the latest released version so I'll have to wait for the next release.  However, I did find a few other dependencies which are out of date and logging WARN deprecated messages, which I will upgraded ASAP.


pip -r install requirements.txt?

The installed environment does not match the code
pytorch==1.7.0?
python==3.8.5?

I also encountered this problem, how can this problem be solved?

The installed environment does not match the code
pytorch==1.7.0?
python==3.8.5?

I also encountered this problem, how can this problem be solved?


Added incremental search to channel search (Ctrl + F)

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
Added incremental search to channel search. Can be toggled in settings under Use incremental search.

Thoughts on having this the default search method to also match emote and tagging auto-completion?

I feel like this should be the new default behavior instead of a setting.
If the setting stays though, it should not be called "Incremental search", thats more of a technical term and most users would probably not know what it does. Something in the lines of "Show search results while typing" would be more comprehensible.

My only concern if this becomes the default behavior is that it might be too taxing on low end computers and might lag users.
Regarding the name, my thought process was that people can google the term if they don't fully understand it, though I'm not opposed to changing it.

My only concern if this becomes the default behavior is that it might be too taxing on low end computers and might lag users.

I wouldn't expect this to be especially taxing on your systems resources tbh, but  yeah couldn't hurt to test it in a crappy VM or something.

Regarding the name, my thought process was that people can google the term if they don't fully understand it, though I'm not opposed to changing it.

Having to look up what the name of a setting means is definitely not a good UX.

I like it as a setting, 100% agree that "Show search results while typing" is more intuitive.

i would vote to make it default behavior and remove setting checkbox, it wont be more taxing than search in few hundred emotes/emojis which is currently the case and had no negative feedback

I'm fine with implementing this as the new default, as long as it's tested in some way on a low-end machine/vm as there are alot of Chatterino users in recent times without the best computers.
Otherwise a setting is fine, I'm aware we have alot of settings without "advanced" sorting but that doesn't mean we should always stray away from user(s) customization.
but change the setting name cuz the current one sucks.

I just tested the changes inside of a 1 CPU Core 2GB RAM crappy VM on my old laptop. Chatterino itself was a bit of a pain to use, but the search did not cause any problems whatsoever and worked absolutely flawless without any lags, hiccups, whatsoever.
So I would strongly advocate for this to be the default behaviour and not another new setting, since I can't really see any reason why anyone would need the old behaviour.

I agree with @LosFarmosCTL 's comment - removing setting and keeping this default is the right way to do this.
If you want to be fancy, you could add a benchmark!

@Mm2PL Merge in when you're happy!


Not able to get wallet id for store in my app

After successful connect wallet
I need to store my wallet id in my storage so no method is there
any help will be great.

Storing the name of the selected wallet in LocalStorage is handled by the WalletProvider: https://github.com/solana-labs/wallet-adapter/blob/296b7e17a6b14093f49ab4d1a3066cc0606718c5/packages/core/react/src/WalletProvider.tsx#L45
If you have autoConnect enabled, the stored wallet will automatically try to connect when your app loads.


Disabling security audit logs

Hi,
I did not find any means to disable the audit logs on opensearch with the operator. What is the recommended way to put in the required configuration opensearch.security.audit.enabled: false into the configmap item opensearch-config/opensarch.yml?
For a bit of context, we see around 30-40Gi daily growth on the audit index and it does not give us any advantage for now.

Another approach is to have the operator remove the line plugins.security.audit.type: "internal_opensearch" which is added as a default here https://github.com/Opster/opensearch-k8s-operator/blob/main/opensearch-operator/pkg/reconcilers/configuration.go#L69
Please add (maybe on the CRD) a switch to enable or disable audit logs.

Hey :)
you can always add additional configuration to Opensearch.yaml file. it should help you.
take a look at our guide :
https://github.com/Opster/opensearch-k8s-operator/blob/main/docs/userguide/main.md#configuring-opensearchyml:~:text=in later sections.-,Configuring opensearch.yml,-The Operator automatically
closing the issue for now, let me know if you need anything  :)

Setting opensearch.security.audit.enabled to false doesn't even disable audit logs. So additional Config will not work. We still need a flag to enable or disable audit logs.


The changelog is missing entries about recent changes to error handling and hooks.

Describe the problem
The changelog is missing entries about recent changes to error handling and hooks.
Describe the proposed solution
It would be a good idea to add this to the changelog because they're breaking changes.
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

Can you link to exactly which changes you're talking about?

For example the new split client and server hooks (https://kit.svelte.dev/docs/hooks) and the new typed PageError stuff (https://kit.svelte.dev/docs/types#app-pageerror).

I guess ultimately it's https://github.com/sveltejs/kit/pull/6586 that is missing from the changelog?


Add omitempty for SchedulerName, ImagePullSecrets, HostNetwork

Changes
This pull request adds omitempty for the following pod template fields:

SchedulerName
ImagePullSecrets
HostNetwork

As documented in #17, SchedulerName and HostNetwork are designated as optional fields and as such should be omitted if not declared. Why ImagePullSecrets is not considered optional seems interesting to me, and perhaps should be discussed a bit further before being introduced. But overall, it might have been overlooked when introducing #2547.
Please let me know if there should be further discussions with regard to this being a breaking change.
Submitter Checklist

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Omit SchedulerName, HostNetwork, and ImagePullSecrets if not declared for PodTemplate

/kind bug

/lgtm
This doesn't qualify as a breaking change because users shouldn't have been depending on specifics like "" being returned in JSON responses from the server.

/lgtm
This doesn't qualify as a breaking change because users shouldn't have been depending on specifics like "" being returned in JSON responses from the server.

Thanks for the clarification. I guess my concern is more about the request for developers working around the API. Those fields are included even when not declared (e.g., when I tried to introduce pod template support in tkn). That being said, I would consider that to be unexpected.

/approve


ComponentServiceObjects and ServiceObjects

I have the feeling I already asked this before, but here I go again:
org.osgi.framework.ServiceObjects and org.osgi.service.component.ComponentServiceObjects are besides some minor javadoc differences identical. I get why this needs to be a separate interface, but I don't see a compelling reason why ComponentServiceObjects can' t simply extend ServiceObjects. The only reason I can imagine is that they may evolve separately in the future that we may want the spec interfaces to be "self contained".
Have I already answered myself or is there more to it?

The only reason I can imagine is that they may evolve separately in the future that we may want the spec interfaces to be "self contained".

ServiceObjects is @ProviderType, we don't want DS becoming an implementor of org.osgi.framework

An update to ServiceObjects in the core spec should not break the implementation of Declarative Services (unimplemented method).
DS implementations should work across multiple versions of the OSGi core spec, even though the version of org.osgi.framework changes each time

ComponentServiceObjects fails the is a check for inheritance - you wouldn't want to pass a CSO instead of a SO

ComponentServiceObjects does caching and tracking linked to the component lifecycle, not the target service lifecycle. If my component is deactivated then my ComponentServiceObjects is closed and cannot be used any more, even if the backing service remains available
If my component is deactivated then any unretired instances from the ComponentServiceObjects are released, even if the backing service is still valid.

Also, we have an<EMAIL_ADDRESS>mail list to ask questions like this instead of using the defect reporting mechanism. So I am going to close this issue.


Improve focus-trapping robustness

The current <focus-trap> directive uses a very simple (naive) approach to focus trapping.

It assumes that the tab order is the same as DOM order, which is not necessarily true.
Things like tabIndex > 0, flex order, and shadow roots can cause to two to misalign.

This behavior needs to be improved, using ally.js as a guide.
This is somewhat complicated by the need to detect different browsers / platforms, for which behavior varies subtly.

The work I had in mind for this issue is done


[SUPPORT] z-order is not working

Describe the problem you faced
I am trying to see how z-order works in hudi by using the sample data set mentioned in the hudi official site , i have mentioned below property
"hoodie.layout.optimize.strategy", "z-order"
while writing the data , but i am not able to see any folder created with "mys3path/.hoodie/.zindex/"  as mentioned in the below issue
https://github.com/apache/hudi/issues/4609
below is my complete code
tableName = "hudi_trips_cow"
basePath = "mys3path"
dataGen = spark.sparkContext._jvm.org.apache.hudi.QuickstartUtils.DataGenerator()
inserts = spark.sparkContext._jvm.org.apache.hudi.QuickstartUtils.convertToStringList(dataGen.generateInserts(10))
df = spark.read.json(spark.sparkContext.parallelize(inserts, 2))
#df.show()
df.write.format("org.apache.hudi")
.option("hoodie.table.name", tableName)
.option("hoodie.datasource.write.table.name", tableName)
.option("hoodie.datasource.write.operation", "bulk_insert")
.option("hoodie.sql.insert.mode", "non-strict")
.option("hoodie.datasource.write.precombine.field", "ts")
.option("hoodie.datasource.write.recordkey.field", "uuid")
.option("hoodie.datasource.write.partitionpath.field", "partitionpath")
.option("hoodie.datasource.write.keygenerator.class", "org.apache.hudi.keygen.ComplexKeyGenerator")
.option("hoodie.datasource.write.hive_style_partitioning", "true")
.option("hoodie.bulkinsert.shuffle.parallelism", "2000")
.option("hoodie.bulkinsert.sort.mode", "NONE")
.option("hoodie.parquet.compression.codec", "zstd")
.option("hoodie.clustering.inline", "true")
.option("hoodie.clustering.inline.max.commits", "1")
.option("hoodie.clustering.plan.strategy.target.file.max.bytes", "1073741824")
.option("hoodie.clustering.plan.strategy.small.file.limit", "536870912")
.option("hoodie.clustering.plan.strategy.sort.columns", "ts")
.option("hoodie.layout.optimize.enable", "true")
.option("hoodie.layout.optimize.strategy", "z-order")
.mode("append")
.save(basePath)
Expected behavior
a folder named 'mys3path/.hoodie/.zindex/' should have been created , but i can't see any folder '.zindex' in '.hoodie' folder
Environment Description

Hudi version : 0.10.0

Spark version : 3.2.0

Storage (HDFS/S3/GCS..) : s3

Running on Docker? (yes/no) : No , in EC2

@sangeethsasidharan could you share the Hudi timeline, i.e., file listing under mys3path/.hoodie?  Is clustering scheduled and executed?

@sangeethsasidharan gentle ping^

@sangeethsasidharan : another ping. if we don't hear back from you, probably we will close the issue due to inactivity in a weeks time. thanks.
let us know if you are looking for assistance.

close due to inactivity


Add icons to bill sponsors and committees section

We need to display the legislator pictures as well as an icon for the committee on the bill detail page (note the mocks show a generic icon). We already have code for showing the legislator icon in the profile page. here is the component for the bill detail page. here is the component for the profile page.

@alexjball how do we navigate to this modal?  I do not see a button on the current bill page.


JavaScript Error

this.

Made the port work, but 0 pokemon on map.

you have a program running which is already listening that port (8001), pogomap can't bind to it.


Unable to delete external domains

Its impossible to delete external domains. now domain rm DOMAIN just throws error:
 Error! An unexpected error occurred in domain: TypeError: Cannot read property 'length' of undefined
    at module.exports.t.default.t.--yes.r (/snapshot/repo/dist/index.js:1:406154)
    at new Promise (<anonymous>)
    at confirmDomainRemove (/snapshot/repo/dist/index.js:1:405922)
    at rm (/snapshot/repo/dist/index.js:1:406615)
    at process._tickCallback (internal/process/next_tick.js:68:7)

now-cli: 12.1.11 OSX Mojave 10.14.1

I got the same error today.

This was fixed for me by upgrading to<EMAIL_ADDRESS>I upgraded like this:
$ yarn global upgrade<EMAIL_ADDRESS>

@goughjt got it


Visible focus for Mobile

Convert all visible focus desktop styles to their best equivalent for mobile.
Considerations for Mobile Accessibility:
https://cxwiki.sap.com/display/spar/Mobile+Accessibility

After a first testing round in a real iPhone 7 device the following bugs were detected:

Some elements are missing the focus indicator on iPhone (on menu links, forgot password link, footer links, checkboxes, radio buttons, buttons)
Modal's close icon has a partially hidden focus indicator on iPhone
Coupons button hides focus indicator on iPhone
Skip link doesn’t show up on iPhone

I'm closing this ticket and creating specific ones for each issue.


feat(tracing): Add types for traces_sampler implementation

This adds (but doesn't yet use) the types and attributes necessary for adding the traces_sampler option which is specced here. Extracted from the larger PR on that topic, https://github.com/getsentry/sentry-python/pull/863.

Types for the traces_sampler itself (the function and its input)
A new attribute on the Transaction class tracking the parent sampling decision separately from the sampling decision of the transaction itself, since part of the traces_sampler spec is that there needs to be a difference between an inherited decision and an explicitly set decision.

I have zero context on this PR, I don't know how to review this

Yeah, sorry - Rodolfo just went through helping me with the JS version of this, so I probably didn't explain as much as I should have in the PR description since he was originally going to be the one reviewing. I've added more context above.


Added a new parameter in the url request

Added the "key parameter" for the google private key

Look at the issue https://github.com/cderue/GoogleMaps/issues/8


Cleanup EventSource logging provider

Change namespace to be the same as project name.
Make LoggingEventSource internal.
Minor code style fixes.

@pranavkm

🐑 :it:


Migrate Updates:Page-footer, site, smooth-scroll, sticky, teaser, video, ul, brightcove

update @bolt/page-footer to 0.9.0
update @bolt/site to 0.9.0
update @bolt/smooth-scroll to 0.9.5
update @bolt/sticky to 0.10.0
update @bolt/teaser to 0.9.0
update @bolt/video to 0.9.6
update @bolt/unordered-list to 0.9.0
update @bolt/brightcove-player to 0.9.6

Dang @joekarasek you're on 🔥!! Awesome work dude! 👏


Launch-a-thon Ended a While Ago

Launch-a-thon ended a while ago no need for the banner at the top anymore.

It has been removed from the DAO


node: add routerrpc to node interface

Adds the routerrpc to lndmanage for a later use for missioncontrol-based node recommendation.
The routerrpc needs to be enabled in the lnd rpc server by make install tags="routerrpc".

MissionControl will be renamed in the future to Reputations (see https://github.com/lightningnetwork/lnd/pull/3214).


Cannot release library with np

Describe the Bug
Whenever I try to release the library with np, it never finishes. I have to do npm publish.
Steps to Reproduce

do this
do that
now this happens

Expected Behavior
np should work.
Environment

OS: [e.g. MacOS 10.2, Windows 10]
Modeler version: [e.g. 2.0.0]

For me it works, but only if my internet is fast (e.g., works via ethernet cable, does not work via wifi)

For me, it doesn't work regardless of internet speed.

I guess your internet connection is just too slow. Perhaps we need to switch to the fiber-optic cables.

Move the datacenter to yo.

Technically we could move the release to the datacenter tho (release on CI) 🤡


Projecting unions in thrift causes TExceptions in deserializatoin

Reporter: Alex Levenson / @isnotinvain
Assignee: Alex Levenson / @isnotinvain
Note: This issue was originally created as PARQUET-287. Please see the migration documentation for further details.

Alex Levenson / @isnotinvain:
Issue resolved by pull request 189
https://github.com/apache/parquet-mr/pull/189


POSIX signals are not working on PHP 7

Having declare(ticks = 1) inside registerSigHandlers() worked perfectly on PHP 5.6 but it doesn't on PHP 7.
I found it that moving the declare(ticks = 1) outside registerSigHandlers() solves the issue.
Could this please be merged and tagged ? :)
I found the idea of moving the declare(ticks = 1) in this PR: https://github.com/juriansluiman/SlmQueue/pull/175

Technically speaking, declare statements are intended to be at the beginning of a PHP file, before even namespaces, so the best spot to move this to would actually be there, immediately after the PHP open tag...

Done :)
@chrisboulton What do you think?

Looks good! 👍


Production cluster does not enable & start bacalhau service automatically

for x in {0..4}; do gcloud compute ssh "bacalhau-vm-production-$x"  --project "bacalhau-production" -- sudo systemctl enable bacalhau-daemon; done

for x in {0..4}; do gcloud compute ssh "bacalhau-vm-production-$x"  --project "bacalhau-production" -- sudo systemctl start bacalhau-daemon; done

gcloud compute ssh "bacalhau-vm-production-4" --zone europe-west4-a  --project "bacalhau-production" -- sudo systemctl enable bacalhau-daemon

gcloud compute ssh "bacalhau-vm-production-4" --zone europe-west4-a  --project "bacalhau-production" -- sudo systemctl start bacalhau-daemon

Fixed by changes in #1662?

Fixed by changes in #1662?

Don't think this has been fixed. It needs more investigation to pinpoint what the root cause is


Google colab not working for chinese-japanese subbed video

Hi, I'm trying to use the google colab client for this video I'm trying to extract subtitles from. It has chinese and japanese subtitles.
This is the log:
请输入视频完整路径：/content/video.mp4
请指定字幕区域 (ymin ymax xmin xmax)：
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x244d7200] moov atom not found
识别字幕语言：ch
识别模式：fast
使用GPU进行加速
帧数：0.0，帧率：0.0
【处理中】开启提取视频关键帧...
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x6fc6000] moov atom not found
【处理中】开始提取字幕信息，此步骤可能花费较长时间，请耐心等待...

0it [00:00, ?it/s]
【结束】提取视频关键帧完毕...
【结束】完成字幕提取，生成原始字幕文件...
【处理中】开始检测并过滤水印区域内容
视频是否存在水印区域，存在的话输入y，不存在的话输入n:n
-----------------------------
【处理中】开始检测非字幕区域，并将非字幕区域的内容删除
Traceback (most recent call last):
  File "./backend/main.py", line 996, in <module>
    se.run()
  File "./backend/main.py", line 176, in run
    self.filter_scene_text()
  File "./backend/main.py", line 437, in filter_scene_text
    subtitle_area = self._detect_subtitle_area()[0][0]
IndexError: list index out of range

Not sure how to configure it so that it detects both japanese and chinese subtitles. I didn't input anything on (ymin ymax xmin xmax) and I think this could be the problem, but isn't it supposed to autodetect the subtitles?
I'm running linux mint and have a not so good computer, but I obtained the subtitles location numbers by using wine (I cannot run the program, but I can obtain the numbers). Inputing this numbers in google colab results in an empty srt file

I'm sorry that biligual subs are not supported except Chinese-English


fix: randomly sample peers in NetworkState::announce_new_block() for block propagation

related to #5906
Changes
In NetworkState::announce_new_block() instead of propagating the block to the first N elements of the iterator, first perform reservoir sampling from all peers that have not already seen the block, then propagate to all peers in the reservoir.
Implementation
After following the conversation on #5310, I opted for an implementation of reservoir sampling because of the need to only sample from peers that have already reported the block.
if peer.blocks.contains(&msg.hash) {
    // don't sample peers which already reported the block
    continue
}

The implementation primarily follows rand::seq::IteratorRandom::choose_multiple_fill() with some simplifications.

I think we could still consider shuffling the hash-map keys instead of reservoir sampling as this would allow us to break out of the loop earlier, probably reducing computation. However, reservoir sampling should have a lower memory footprint.
// choose random peers at every propagation
let mut peer_ids: Vec<PeerId> = self.active_peers.keys().cloned().collect();
peer_ids.shuffle(&mut rand::thread_rng());

for (peer_idx, peer_id) in peer_ids.iter().enumerate() {
    // filter all transactions unknown to the peer
    let peer = self.peers.get_mut(peer_id).expect("peer must exists");

    // code unchanged ...
}

sorry I only read your comment in detail just now

I think we could still consider shuffling the hash-map keys instead of reservoir sampling as this would allow us to break out of the loop earlier, probably reducing computation. However, reservoir sampling should have a lower memory footprint.

agree, shuffling the peers is easier imo, let's do that, as mentioned above, this call is not on a hot path (once per block) so the additional alloc+shuffling is fine.
this could be converted to pseudo random shuffling but no need for that perf improvement right now since unused for ethereum anyway

Sounds good! I will probably update the PR tomorrow with alloc+shuffling, as discussed above.
Yes. This is indeed part of an assignment for the first iteration of KTHs blockchain and smart contracts course called Programmable Society.😃

Changed the implementation to the much simpler solution of shuffling the peers first and then iterating as before.


[BUG] manage team is not showing any data

Describe the bug
Manage team should show data. But it not showing anything.
To Reproduce
Steps to reproduce the behavior:

Go to website. login as admin.
add a team member.
now check in manage team member.

Expected behavior
Manage team should show all available team members.
Have you read the Code of Conduct?
Write your answer here.
yes

@Kajol-Kumari  can you please assign this to me.

As there is no data in db, so its not showing up, its expected.

@Kajol-Kumari  once try to add the team member data from add teammemmber. after adding also it is not showing. can you please check once.

@Kajol-Kumari  can you see this video. can you please reopen this issue and assign me.
https://github.com/HITK-TECH-Community/Community-Website/assets/106808387/4f507750-6c07-415e-9283-666cdaa66ee4

Hello @Kajol-Kumari
Please assign me the issue


JsonType field returning string instead of parsed object in subscriber

See PR reproduction

ChangeSet.originaEntity is a DTO/POJO, not entity instance, you get the serialized values, so the values returned by Type.convertToDatabaseValue, which for JSON can be a string (depends on the driver, they work differently when it comes to JSON properties).
Works as expected.

I'd rather not do that. Maybe we could think about how to have the runtime value there instead of the (not so stable and sometimes even driver-specific) database value. As for scalar properties, it might be just fine to use that instead of the database one.


Improve Filter Rerun Logic

Closes #1934.
Will now only rerun filters in on_message_edit if the content or attachments of a message changed. This stops reruns for removal of embeds, change in pin status, etc.

This would not alert us when an embed has been added to a message, which is why we should only really be skipping the filters if the message was pinned or unpinned.

This would not alert us when an embed has been added to a message, which is why we should only really be skipping the filters if the message was pinned or unpinned.

We don't want to be alerted of that, since it means we'll get double-pinned for domain filters

We might miss self-bots though.

This is only for message edits, can you actually edit an embed in?

Yep, you can

We might miss self-bots though.

I believe we have other filters for that

The reason we got two pings for that mod-alert is because of an oversight in the embed filter. So we should be running our filters on embed additions, I can PR a fix for the embed filter.

We should be running our filters on embed additions. I can PR a fix for the embed filter.
#1938 relevant issue.

@Qwerty-133 This has been addressed :+1:


TNO-2280: Fix keyboard shortcuts on report page

Does this handle input boxes and allow users to use the arrow keys within those?

Does this handle input boxes and allow users to use the arrow keys within those?

@Fosol yes, I just tested now to make sure, since the listener is on the window, it'll pick up the events no matter where the focus is

Yes would be bad.  If a user is typing in an input they don't want the data changing out from under them.

Yes would be bad. If a user is typing in an input they don't want the data changing out from under them.

What are the chances they'll press CTRL+Arrow keys in an input box? I think it's a bit odd to have hotkeys but disable them for inputs. If they want to nav back and forth they'll have to click outside of a input box to blur it, and then press the hotkeys
I can add something to ignore the hotkeys though, if you think that's best

Definitely ignore the prev/next shortcut keys actions within an any kind of input.  That means ignore the page level prev/next actions you're implementing when a user is in an input.

Definitely ignore the prev/next shortcut keys actions within an any kind of input. That means ignore the page level prev/next actions you're implementing when a user is in an input.

An alternative would be prompting the user if there any unsaved changes, "Are you sure you want to navigate away from this content?". Just throwing ideas out there.

That isn't ideal.  If I'm in an input and I want to move the cursor to another word I don't want a prompt firing every time.  I just want the cursor to move in the in put.

That isn't ideal. If I'm in an input and I want to move the cursor to another word I don't want a prompt firing every time. I just want the cursor to move in the in put.

For UX perspective, Google Chrome has a shortcut CTRL+TAB to navigate to the next tab in the browser, this works no matter where the focus is, I could be typing in this input, and it'll still work. It would be awkward if I had to first click outside the input for it to work. Kind of eliminates the point of a shortcut.
Maybe we should use a different shortcut rather than CTRL+Arrow keys
For now I'll work on disabling it in inputs

Perhaps I'm misunderstanding this PR.  Is this to handle the previous/next actions to move from one content to another within a report?  If so when a content item is selected a form is displayed.  That form is to enable the user to edit the content properties.  When a user focuses on an input they are changing the property values.  A valid keypress is the arrow keys within an input to allow the user to move the cursor.
Will the arrow keys work within the input as they normally would?  Or will this PR change the behavior?
All we want to make certain of is users should be able to use the arrow keys within an input normally.

Perhaps I'm misunderstanding this PR. Is this to handle the previous/next actions to move from one content to another within a report? If so when a content item is selected a form is displayed. That form is to enable the user to edit the content properties. When a user focuses on an input they are changing the property values. A valid keypress is the arrow keys within an input to allow the user to move the cursor.
Will the arrow keys work within the input as they normally would? Or will this PR change the behavior?
All we want to make certain of is users should be able to use the arrow keys within an input normally.

No the window listener would override the normal behaviour of CTRL+Arrow Key which would normally just skip the cursor to the next word, so you're right in thinking that. I'm just asking I'm not sure if disabling the shortcut in the input is the best solution as it makes the shortcut harder to use
I'm probably overthinking this. I'll just disable the shortcut if an input is active. Sorry about the confusion!

Ah I forgot about the CTRL+Arrow combination, I was thinking it was just the Arrow key.  I think that's specific enough to not have to worry about user mistyping it.  This is probably good enough in this case.


fix: nodejs: link direct bins

Fixes #221
At the end of the src/subsystems/nodejs/builders/granular/install-deps.py,
read package.json,
and link bins of direct dependencies to node_modules/.bin.
Needs to pass the src (+ run unpack phase) to devShell so package.json is available.

You might be interested in #195 - there the node_modules are always trees of symlinks and generated separately from the packages (makeModules function), and the .bin directories are correctly populated (I think).
individual node modules have bin/ so that they work as nix packages and makeWrapper etc work as expected, and the combined node_modules then symlinks those together into node_modules/.bin/

I could reproduce the problem using your package.json from https://github.com/nix-community/dream2nix/issues/221.
But even after switching to this PR, the problem is still not solved.
I used this flake.nix:
{
  inputs.dream2nix.url = "github:tinybeachthor/dream2nix/fix-nodejs-link-direct-bins";
  outputs = inp: let
    pkgs = inp.dream2nix.inputs.nixpkgs.legacyPackages.x86_64-linux;
    package_json = builtins.toFile "package.json" ''
      {
        "devDependencies": {
          "svgo": "^2.2.2",
          "cssnano": "^4.1.10"
        }
      }
    '';
  in
    inp.dream2nix.lib.makeFlakeOutputs {
      systemsFromFile = ./nix_systems;
      config.projectRoot = ./.;
      source = pkgs.runCommand "src" {} ''
        mkdir $out
        cp ${package_json} $out/package.json
      '';
    };
}

after running .#resolveImpure, nix develop still produces node_modules like this:
$ ls -lah node_modules/.bin/
total 0
drwxr-xr-x   2 grmpf users  200 Aug  9 15:10 .
drwxr-xr-x 162 grmpf users 3.2K Aug  9 15:10 ..
lrwxrwxrwx   1 grmpf users   85 Aug  9 15:10 browserslist -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/browserslist
lrwxrwxrwx   1 grmpf users   90 Aug  9 15:10 browserslist-lint -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/browserslist-lint
lrwxrwxrwx   1 grmpf users   79 Aug  9 15:10 cssesc -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/cssesc
lrwxrwxrwx   1 grmpf users   80 Aug  9 15:10 esparse -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/esparse
lrwxrwxrwx   1 grmpf users   83 Aug  9 15:10 esvalidate -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/esvalidate
lrwxrwxrwx   1 grmpf users   80 Aug  9 15:10 js-yaml -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/js-yaml
lrwxrwxrwx   1 grmpf users   79 Aug  9 15:10 mkdirp -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/mkdirp
lrwxrwxrwx   1 grmpf users   77 Aug  9 15:10 svgo -> ../gv0wz6r2k2i2cgmrmdip0az1al52x5sj-cssnano-4.1.11/lib/node_modules/.bin/svgo

Thesvgo bin still links to cssnano. Also the symlink seems to be broken which is probably another unrelated bug.

@DavHau
Adding a name field to the package_json makes this build as intended.
Name is a required field for npm packages.
{
  inputs.dream2nix.url = "github:tinybeachthor/dream2nix/fix-nodejs-link-direct-bins";
  outputs = inp: let
    pkgs = inp.dream2nix.inputs.nixpkgs.legacyPackages.x86_64-linux;
    package_json = builtins.toFile "package.json" ''
      {
        "name": "anything",
        "devDependencies": {
          "svgo": "^2.2.2",
          "cssnano": "^4.1.10"
        }
      }
    '';
  in
    inp.dream2nix.lib.makeFlakeOutputs {
      systemsFromFile = ./nix_systems;
      config.projectRoot = ./.;
      source = pkgs.runCommand "src" {} ''
        mkdir $out
        cp ${package_json} $out/package.json
      '';
    };
}

> ls -la node_modules/.bin
total 32
drwxr-xr-x 1 martin users  138 Aug  9 11:22 .
drwxr-xr-x 1 martin users 4590 Aug  9 11:22 ..
lrwxrwxrwx 1 martin users   22 Aug  9 11:22 browserslist -> ../browserslist/cli.js
lrwxrwxrwx 1 martin users   32 Aug  9 11:22 browserslist-lint -> ../update-browserslist-db/cli.js
lrwxrwxrwx 1 martin users   20 Aug  9 11:22 cssesc -> ../cssesc/bin/cssesc
lrwxrwxrwx 1 martin users   25 Aug  9 11:22 esparse -> ../esprima/bin/esparse.js
lrwxrwxrwx 1 martin users   28 Aug  9 11:22 esvalidate -> ../esprima/bin/esvalidate.js
lrwxrwxrwx 1 martin users   25 Aug  9 11:22 js-yaml -> ../js-yaml/bin/js-yaml.js
lrwxrwxrwx 1 martin users   20 Aug  9 11:22 mkdirp -> ../mkdirp/bin/cmd.js
lrwxrwxrwx 1 martin users   16 Aug  9 11:22 svgo -> ../svgo/bin/svgo

I am not sure why adding a name to package.json makes a difference,
but I would expect the behavior to be consistent regardless of the name field.

The name thing is because the discoverer gets a null name. I have a fix for it in my branch


Minor usability improvements

@trevorscott some small issues I ran into while using this. It's great otherwise!

Looks good! Thanks Chris.


Support the disaggregation of protocol buffer encoded aggregated records in Kinesis

Is your feature request related to a problem? Please describe.
I'm consuming aggregated records from Kinesis - as described in the https://github.com/awslabs/kinesis-aggregation project
I can't use the KinesisStreamEvent data class
Describe the solution you'd like
The KinesisStreamEvent data class to handle deaggregation automatically when it detects a need
Describe alternatives you've considered
Just using the from aws_kinesis_agg.deaggregator import deaggregate_records method and abandoning the KinesisStreamEvent class
Additional context

We're closing feature requests older than a year that haven't received enough customers +1 or that we were unable to prioritize. For newer customers interested in, please feel free to comment and we can reopen it.


Added BT Traversal code

Please add your Name and Program name as the first two lines. Please refer to CONTRIBUTING.md for more details.

Is it okay if I add name and program name in a .txt file?

I have added my name and the program name, please review it and kindly merge my pull request.

Yes great PR !!


Add strip_bbcode() method to String

Replaces #65384.
Adds a function to strip bbcode tags out of strings.
Example Code:
var s = "[color=#ffffff]Hello![/color]
print(s.strip_bbcode())

Result: Hello
Closes https://github.com/godotengine/godot-proposals/issues/5056

This is a great idea. Haven't looked in awhile, but if the implementation is the same, would it make more sense to add this to the TextServer and have both RTL and string the same method? Or do they need to be separate methods?

would it make more sense to add this to the TextServer and have both RTL and string call the same method?

I'm still not a big expert on Godot's code. I wasn't able to find the function that does that to RTLs, but if that is considered to be a better solution it's fine by me.

I don't see why you would call it in the RTL given that if you're using BBCode it has to process the text and if not then you want it to be a raw string including the BBCode tags.

I think they meant make the RTL and String use the same function for striping it, because the RTL converts bbcode_text to text in the interface.

After some digging, it looks like RTL is in fact not caching but stripping it every time you call get_parsed_text(), but it looks like it's doing something specific, so I'm going to say we should keep them separate unless otherwise needed.

Actually, there is a way to escape BBCode. Maybe we should add escape_bbcode instead of / together with strip_bbcode?

So it needs a check to make it convert [lb] and [rb] to brackets? I can start on that soon.

The other pretty important issue with this is that it doesn't check anywhere if it's valid BBCode or not. This is important, since RichTextLabel doesn't strip BBCode that doesn't match a tag.

@markdibarry any idea where the script that checks for valid bbcode is?

RichTextLabel doesn't strip BBCode that doesn't match a tag

Given that custom BBCodes can be added, I think it's correct to only consider the syntax (strip all tags, including non-existent and non-matching ones) and point this out in the documentation.

The other pretty important issue with this is that it doesn't check anywhere if it's valid BBCode or not. This is important, since RichTextLabel doesn't strip BBCode that doesn't match a tag.

The only simple independent way I can think of this being implemented is by having a list of valid tag names in an array and skipping skipping leaving anything outside that array, honestly doesn't look like that be difficult, (perhaps that can be considered, if so however it should be under a different name so it'll handle the default tags by default like strip_bbcode_tags(handle_defaults : bool = true, extra_tags : Array[string]) but if the function gets that complex then doesn't trying to better comply with BBCode enter the fray adding undue complexity?

If custom BBCode tags can be added, and RichTextLabel can access this, then surely this function could just automatically access whatever that store is, right? That seems like it would be the most elegant solution.

If custom BBCode tags can be added, and RichTextLabel can access this, then surely this function could just automatically access whatever that store is, right? That seems like it would be the most elegant solution.

That's the clunkiest solution actually, as you would be required to pass the RTL every time you made a call and makes the function heavily dependent upon the RTL. (meaning as well if you don't use the RTL now you're polluting the dependency of the class just for that function, which iirc is actually prohibited as new additions anyway as core can't be dependent upon scene files) And that aside its unnecessary since all the information this function needs to remove known tags is the name of the tags, as in all you need is strings, you don't need anything else in the RTL and don't need to keep a reference to an RTL in order to use it.

That's the clunkiest solution actually, as you would be required to pass the RTL every time you made a call and makes the function heavily dependent upon the RTL.

Considering the primary use case here is for RTLs, maybe this should be a function attached to RTLs? Like $RichTextLabel.strip_bbcode() which just returns the stripped text as the RTL would display it, and doesn't affect the RTL's actual bbcode_text or text? It not returning an identical string to what the RTL will end up displaying feels like it could make this function have limited use for many.

I guess the main purpose of strip_bbcode is to safely add text without markup (although there is add_text and [lb], [rb] tags). In order to get the current visible text there is get_parsed_text. strip_bbcode respecting the current set of tags is useful if you need to know the future visible text, but I think this is a rare use case.

useful if you need to know the future visible text, but I think this is a rare use case

Funny enough, that's the exact use case I have. When working with dialog, knowing the indices of rendered characters can be crucial. With any custom text syntax, your two options are to manually keep a list of valid bbcode tags up to date, or:

Set the text, so the text can be parsed
call get_parsed_text()
Use the full text and parsed text together to determine the rendered text.
Parse the text for custom syntax.
set the text again.

Can be a little over-the-top.

When working with dialog, knowing the indices of rendered characters can be crucial.

This is my exact use case as well, but I don't use custom bbcode. Wasn't sure if it was an odd edge case or not.

Sounds rad. Keep me posted with your project's progress after this!

When working with dialog, knowing the indices of rendered characters can be crucial.

I prefer not to rely on indexes, but to use invisible control characters.
According to your description, it should not be String.strip_bbcodes, but RichTextLabel.get_parsed_text_from_string or something like that. strip_* means that some character sequences will be removed (like strip_escapes or lstrip) and not replaced (like c_escape, c_unescape, etc.).
We also need to remember that rtl.text += s and rtl.append_text(s) give different results for unclosed tags. And the proposed behavior may not be suitable in one of the cases.


Content/ui fixes/enhancements

-Translations.
-Content redaction fixes.
-Content style changes.

Good job! 💩

I'm sorry, I meant to merge the code into my own repo :( 🤦


Allow StreamListenerParameterAdapter to be applied more broadly

Fix #890

Not from the scope of this PR, but it would be nice to include a test configuration that uses something similar to how KStream support is implemented. We can cover all the tests for that type of bindings as well.

LGTM, merging.

Merged as ab9cf91803ba83f6a101f6a93581e040a69459ff along with 6592c1a8cdbe0064b96f1907006db9fbeb415305


suggestion: path element

Something like https://shopify.github.io/react-native-skia/docs/shapes/path#using-path-object

Closing this as we have raw access to the Canvas now


registry tests assumes /go/bin is in the PATH

It is assumed that registryv2 binary under /go/bin is always in the path, when compiling with gccgo /go/bin is not in the path.This PR fixes that issue.
Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>

this comes from here https://github.com/docker-library/golang/blob/master/1.4/Dockerfile#L20
so this is kinda a problem with whatever base you are using

@brahmaroutu I don't understand problem. Could you describe your case? Why you just don't add your PATH outside of script? Or just copy binary to existing PATH?

Ping @brahmaroutu

I am closing this issue. I used to see registry-v2 executable under /go/bin but not anymore. And /usr/local/bin is already in my path and things seem to work fine.