Swagger update for ExecuteSsisPackageActivity in ADF

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: yuanliu-ms sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi Martin,
Based on Yandong’s feedback, ARM team want us not use enum since it maybe not clear to user.
+Yandong to share more comments.
Thanks a lot
Yuan
From: Martin Strobel<EMAIL_ADDRESS>Sent: Thursday, December 7, 2017 7:03 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Yuan Liu<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
@marstr commented on this pull request.
From my side, I don't have any particular changes to ask for. I did have a couple questions though.
Also, we'll need to get review from the ARM team before this can be merged.

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387166&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=PlcKSV69G8wG0mr5EaiJ3kVcXb9BpvU6jLXtNhv%2BXQs%3D&reserved=0:

     "description": "Execute SSIS package activity properties.",

     "$ref": "#/definitions/ExecuteSSISPackageActivityTypeProperties"

   }

 },

 "required": [

   "typeProperties"

 ]

},

"ExecuteSSISPackageActivityTypeProperties": {

 "description": "Execute SSIS package activity properties.",

 "properties": {

   "packageLocation": {

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

I'm surprised to see that the service takes this as a 'Yes' or 'No' string, and not a bool. Any particular reason that isn't the approach?

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387408&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=8hyLEZLSO6d2mnrlZ5oKM1c9EqFD04eCdlt0rr2MGZs%3D&reserved=0:

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

     "description": "Specifies whether to use 32 bit runtime to execute SSIS package.",

     "type": "string",

     "enum": [

       "Yes",

       "No"

     ],

     "x-ms-enum": {

       "name": "SSISExecutionUse32bitRuntime",

       "modelAsString": true

     }

   },

   "loggingLevel": {

This looks like something that should be an enum, or referencing a previously declared enum to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23pullrequestreview-81698568&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=jBWA7ovXMTna2plOC6xDHzjXf3dGBC6D%2FQQYykv6fXU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBStpYz-_jxGwhWDk8SmLwJboXklDWaks5s9x0mgaJpZM4Q3nNF&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=TsHr1GjTHWYa3Xcpkqr%2B70igHn3w%2F2vCKpuAJ%2Fnv4SI%3D&reserved=0.

Yuan Liu would like to recall the message, "[Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)".

Hi Martin,
Based on Yandong’s feedback, ARM team want us not use Boolean since it maybe not clear to user.
+Yandong to share more comments.
Thanks a lot
Yuan
From: Martin Strobel<EMAIL_ADDRESS>Sent: Thursday, December 7, 2017 7:03 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Yuan Liu<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
@marstr commented on this pull request.
From my side, I don't have any particular changes to ask for. I did have a couple questions though.
Also, we'll need to get review from the ARM team before this can be merged.

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387166&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=PlcKSV69G8wG0mr5EaiJ3kVcXb9BpvU6jLXtNhv%2BXQs%3D&reserved=0:

     "description": "Execute SSIS package activity properties.",

     "$ref": "#/definitions/ExecuteSSISPackageActivityTypeProperties"

   }

 },

 "required": [

   "typeProperties"

 ]

},

"ExecuteSSISPackageActivityTypeProperties": {

 "description": "Execute SSIS package activity properties.",

 "properties": {

   "packageLocation": {

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

I'm surprised to see that the service takes this as a 'Yes' or 'No' string, and not a bool. Any particular reason that isn't the approach?

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387408&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=8hyLEZLSO6d2mnrlZ5oKM1c9EqFD04eCdlt0rr2MGZs%3D&reserved=0:

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

     "description": "Specifies whether to use 32 bit runtime to execute SSIS package.",

     "type": "string",

     "enum": [

       "Yes",

       "No"

     ],

     "x-ms-enum": {

       "name": "SSISExecutionUse32bitRuntime",

       "modelAsString": true

     }

   },

   "loggingLevel": {

This looks like something that should be an enum, or referencing a previously declared enum to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23pullrequestreview-81698568&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=jBWA7ovXMTna2plOC6xDHzjXf3dGBC6D%2FQQYykv6fXU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBStpYz-_jxGwhWDk8SmLwJboXklDWaks5s9x0mgaJpZM4Q3nNF&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=TsHr1GjTHWYa3Xcpkqr%2B70igHn3w%2F2vCKpuAJ%2Fnv4SI%3D&reserved=0.

Also add Qianwen and David.
From: Yuan Liu
Sent: Thursday, December 7, 2017 10:48 AM
To: 'Azure/azure-rest-api-specs'<EMAIL_ADDRESS>'Azure/azure-rest-api-specs'<EMAIL_ADDRESS>Yandong Zhang<EMAIL_ADDRESS>Cc: 'Author'<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
Hi Martin,
Based on Yandong’s feedback, ARM team want us not use Boolean since it maybe not clear to user.
+Yandong to share more comments.
Thanks a lot
Yuan
From: Martin Strobel<EMAIL_ADDRESS>Sent: Thursday, December 7, 2017 7:03 AM
To: Azure/azure-rest-api-specs <azure-rest-api-specs<EMAIL_ADDRESS>Cc: Yuan Liu <yual<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
@marstr commented on this pull request.
From my side, I don't have any particular changes to ask for. I did have a couple questions though.
Also, we'll need to get review from the ARM team before this can be merged.

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387166&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=PlcKSV69G8wG0mr5EaiJ3kVcXb9BpvU6jLXtNhv%2BXQs%3D&reserved=0:

     "description": "Execute SSIS package activity properties.",

     "$ref": "#/definitions/ExecuteSSISPackageActivityTypeProperties"

   }

 },

 "required": [

   "typeProperties"

 ]

},

"ExecuteSSISPackageActivityTypeProperties": {

 "description": "Execute SSIS package activity properties.",

 "properties": {

   "packageLocation": {

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

I'm surprised to see that the service takes this as a 'Yes' or 'No' string, and not a bool. Any particular reason that isn't the approach?

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387408&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=8hyLEZLSO6d2mnrlZ5oKM1c9EqFD04eCdlt0rr2MGZs%3D&reserved=0:

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

     "description": "Specifies whether to use 32 bit runtime to execute SSIS package.",

     "type": "string",

     "enum": [

       "Yes",

       "No"

     ],

     "x-ms-enum": {

       "name": "SSISExecutionUse32bitRuntime",

       "modelAsString": true

     }

   },

   "loggingLevel": {

This looks like something that should be an enum, or referencing a previously declared enum to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23pullrequestreview-81698568&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=jBWA7ovXMTna2plOC6xDHzjXf3dGBC6D%2FQQYykv6fXU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBStpYz-_jxGwhWDk8SmLwJboXklDWaks5s9x0mgaJpZM4Q3nNF&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=TsHr1GjTHWYa3Xcpkqr%2B70igHn3w%2F2vCKpuAJ%2Fnv4SI%3D&reserved=0.

<EMAIL_ADDRESS>for more comments. I remember this suggestion was coming from Gaurav.

Thanks
Yandong
From: Yuan Liu
Sent: Thursday, December 7, 2017 10:49 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Azure/azure-rest-api-specs<EMAIL_ADDRESS>Yandong Zhang<EMAIL_ADDRESS>Qianwen Shi<EMAIL_ADDRESS>David Zeng (SQL<EMAIL_ADDRESS>Cc: Author<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
Also add Qianwen and David.
From: Yuan Liu
Sent: Thursday, December 7, 2017 10:48 AM
To: 'Azure/azure-rest-api-specs'<EMAIL_ADDRESS>'Azure/azure-rest-api-specs' <azure-rest-api-specs<EMAIL_ADDRESS>Yandong Zhang <Yandong.Zhang<EMAIL_ADDRESS>Cc: 'Author' <author<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
Hi Martin,
Based on Yandong’s feedback, ARM team want us not use Boolean since it maybe not clear to user.
+Yandong to share more comments.
Thanks a lot
Yuan
From: Martin Strobel<EMAIL_ADDRESS>Sent: Thursday, December 7, 2017 7:03 AM
To: Azure/azure-rest-api-specs <azure-rest-api-specs<EMAIL_ADDRESS>Cc: Yuan Liu <yual<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
@marstr commented on this pull request.
From my side, I don't have any particular changes to ask for. I did have a couple questions though.
Also, we'll need to get review from the ARM team before this can be merged.

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387166&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=PlcKSV69G8wG0mr5EaiJ3kVcXb9BpvU6jLXtNhv%2BXQs%3D&reserved=0:

     "description": "Execute SSIS package activity properties.",

     "$ref": "#/definitions/ExecuteSSISPackageActivityTypeProperties"

   }

 },

 "required": [

   "typeProperties"

 ]

},

"ExecuteSSISPackageActivityTypeProperties": {

 "description": "Execute SSIS package activity properties.",

 "properties": {

   "packageLocation": {

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

I'm surprised to see that the service takes this as a 'Yes' or 'No' string, and not a bool. Any particular reason that isn't the approach?

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387408&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=8hyLEZLSO6d2mnrlZ5oKM1c9EqFD04eCdlt0rr2MGZs%3D&reserved=0:

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

     "description": "Specifies whether to use 32 bit runtime to execute SSIS package.",

     "type": "string",

     "enum": [

       "Yes",

       "No"

     ],

     "x-ms-enum": {

       "name": "SSISExecutionUse32bitRuntime",

       "modelAsString": true

     }

   },

   "loggingLevel": {

This looks like something that should be an enum, or referencing a previously declared enum to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23pullrequestreview-81698568&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=jBWA7ovXMTna2plOC6xDHzjXf3dGBC6D%2FQQYykv6fXU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBStpYz-_jxGwhWDk8SmLwJboXklDWaks5s9x0mgaJpZM4Q3nNF&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=TsHr1GjTHWYa3Xcpkqr%2B70igHn3w%2F2vCKpuAJ%2Fnv4SI%3D&reserved=0.

Martin

From: Yandong Zhang
Sent: Thursday, December 7, 2017 10:54 AM
To: Yuan Liu<EMAIL_ADDRESS>Azure/azure-rest-api-specs<EMAIL_ADDRESS>Azure/azure-rest-api-specs<EMAIL_ADDRESS>Qianwen Shi<EMAIL_ADDRESS>David Zeng (SQL<EMAIL_ADDRESS>Gaurav Bhatnagar<EMAIL_ADDRESS>Cc: Author<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)

<EMAIL_ADDRESS>for more comments. I remember this suggestion was coming from Gaurav.

Thanks
Yandong
From: Yuan Liu
Sent: Thursday, December 7, 2017 10:49 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Azure/azure-rest-api-specs <azure-rest-api-specs<EMAIL_ADDRESS>Yandong Zhang <Yandong.Zhang<EMAIL_ADDRESS>Qianwen Shi <qianwens<EMAIL_ADDRESS>David Zeng (SQL) <davizen<EMAIL_ADDRESS>Cc: Author <author<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
Also add Qianwen and David.
From: Yuan Liu
Sent: Thursday, December 7, 2017 10:48 AM
To: 'Azure/azure-rest-api-specs'<EMAIL_ADDRESS>'Azure/azure-rest-api-specs' <azure-rest-api-specs<EMAIL_ADDRESS>Yandong Zhang <Yandong.Zhang<EMAIL_ADDRESS>Cc: 'Author' <author<EMAIL_ADDRESS>Subject: RE: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
Hi Martin,
Based on Yandong’s feedback, ARM team want us not use Boolean since it maybe not clear to user.
+Yandong to share more comments.
Thanks a lot
Yuan
From: Martin Strobel<EMAIL_ADDRESS>Sent: Thursday, December 7, 2017 7:03 AM
To: Azure/azure-rest-api-specs <azure-rest-api-specs<EMAIL_ADDRESS>Cc: Yuan Liu <yual<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Swagger update for ExecuteSsisPackageActivity in ADF (#2102)
@marstr commented on this pull request.
From my side, I don't have any particular changes to ask for. I did have a couple questions though.
Also, we'll need to get review from the ARM team before this can be merged.

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387166&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=PlcKSV69G8wG0mr5EaiJ3kVcXb9BpvU6jLXtNhv%2BXQs%3D&reserved=0:

     "description": "Execute SSIS package activity properties.",

     "$ref": "#/definitions/ExecuteSSISPackageActivityTypeProperties"

   }

 },

 "required": [

   "typeProperties"

 ]

},

"ExecuteSSISPackageActivityTypeProperties": {

 "description": "Execute SSIS package activity properties.",

 "properties": {

   "packageLocation": {

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

I'm surprised to see that the service takes this as a 'Yes' or 'No' string, and not a bool. Any particular reason that isn't the approach?

In specification/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/entityTypes/Pipeline.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23discussion_r155387408&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=8hyLEZLSO6d2mnrlZ5oKM1c9EqFD04eCdlt0rr2MGZs%3D&reserved=0:

     "description": "SSIS package location.",

     "$ref": "#/definitions/SSISPackageLocation"

   },

   "use32bitRuntime": {

     "description": "Specifies whether to use 32 bit runtime to execute SSIS package.",

     "type": "string",

     "enum": [

       "Yes",

       "No"

     ],

     "x-ms-enum": {

       "name": "SSISExecutionUse32bitRuntime",

       "modelAsString": true

     }

   },

   "loggingLevel": {

This looks like something that should be an enum, or referencing a previously declared enum to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2102%23pullrequestreview-81698568&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=jBWA7ovXMTna2plOC6xDHzjXf3dGBC6D%2FQQYykv6fXU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMBStpYz-_jxGwhWDk8SmLwJboXklDWaks5s9x0mgaJpZM4Q3nNF&data=02|01|yual%40microsoft.com|c39952a7734047c93fa608d53cfd8212|72f988bf86f141af91ab2d7cd011db47|1|0|636481981866751495&sdata=TsHr1GjTHWYa3Xcpkqr%2B70igHn3w%2F2vCKpuAJ%2Fnv4SI%3D&reserved=0.

Hi @marstr , I send out a new iteration based on your comments. Now I change the use32BitRuntime to runtime Property. Please help review.

Hi @marstr , thanks a lot for your review. We're ready to merge the swagger. Could you help do the merge since it seems like I have no permission to do the merge. Thanks again.

Hi @marstr, could you help do the swagger merge today? It seems like only after the swagger is merged into master, I can send out PR for SDK. And we are very closed to our timeline. Really appreciate for your help!

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-python


[Analysis] Investigate postgres async connector

References:

https://github.com/MagicStack/asyncpg
https://github.com/lv-386-python/moneta/blob/dev/moneta/src/python/core/db/pool_manager.py
https://github.com/aio-libs/aiohttp-demos/blob/master/demos/polls/aiohttpdemo_polls/db.py
https://www.python.org/dev/peps/pep-0249/


Feature request for removing neighbors that have only increasing "Dropped Packets"

Is your feature request related to a problem? Please describe.
Some peers on the /neighbors page are making no progress and should probably be removed after some time.
Describe the solution you'd like
When "Dropped packets" increases while metrics  "All", "New", "Stale" and "Sent" remain the same I would like to suggest we drop the neighbor. During the latest spam-event more and more nodes could not keep up while good nodes seemed to have a problem finding other healthy nodes. Maybe this helps a little.
Describe alternatives you've considered
Perhaps the interval should be longer that the refreshrate of the /neighbors page?

Added in #608


pub get error

pub get error

I don't know what hd2001 is, but it's that which causes that error. Not chewie. They've to update their static dependencies.

I don't know what hd2001 is, but it's that which causes that error. Not chewie. They've to update their static dependencies.

hd2001 is my project name

I don't know what hd2001 is, but it's that which causes that error. Not chewie. They've to update their static dependencies.

hd2001 is my project name

We need more context, reproducable project/code anything, that we can help, otherwise we can't do anything to help you.

I don't know what hd2001 is, but it's that which causes that error. Not chewie. They've to update their static dependencies.

hd2001 is my project name

We need more context, reproducable project/code anything, that we can help, otherwise we can't do anything to help you.

I create a new project, and get the same problem

I don't know what hd2001 is, but it's that which causes that error. Not chewie. They've to update their static dependencies.

hd2001 is my project name

We need more context, reproducable project/code anything, that we can help, otherwise we can't do anything to help you.

I create a new project, and get the same problem

Except pubspec.yaml add chewie: ^0.12.0, I didn't code anything

me too

Flutter clean, flutter upgrade, try out different things.
There is something wrong with your flutter/dart setup and not with this package.
Try stack overflow

Flutter clean, flutter upgrade, try out different things.
There is something wrong with your flutter/dart setup and not with this package.
Try stack overflow

Except for this library, other libraries are normal, such as dio...

But the version 0.9.10 of chewie is normal


Update to monthly-2021-11

Closing as other PR with update to monthly-2021-11+1 is already merged.


Add description field to "Add todoist task" window

It would be nice if we could add a task description from todoist as well

If would also be very useful if one can see task description in Obsidian.

Also, can the obsidian link be added to description, instead of task title?


overload: prevent segfault when disabling listener

Commit Message: Prevent segfault when disabling listener due to overload
Additional Description:
This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.
Risk Level: low
Testing: ran unit tests
Docs Changes: none
Release Notes: none
Fixes #13514

@cpakulski anything with backport/review label needs to be evaluated for backporting and if approved, that label should be changed to backport/approved and PRs sent to stable releases.

Backporting this fix to releases: 1.16, 1.15., 1.14 and 1.13.

The fix has been backported to 1.16, 1.15 and 1.14. Release 1.13 do not use pauseListening, resumeListening and shutdownListener methods, which this PR fixed and therefore the changes were not backported.
Removing backport/approved label.


check for permissions to use the command before doing any processing

in certain situations such as with lots of users, doing "/pex promote a a" will cause the server to hang trying to resolved the username. ensuring they have permission to use the command prevents malicious use of this problem

@PhanaticD decided that cussing at me when I was trying to help him was the correct way to get help.


--no-clear option does not have desired effect; cannot scroll after exiting; mouse scroll wheel ineffective

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf; fzf --version shows 0.33.0 (e03ac31)
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
Steps
Run fzf with the --no-clear option. Ex:
# search everything, including file names *and* contents
rg --hidden -L --color always -n '' | fzf --ansi --no-clear

Press Ctrl + C to exit fzf.
Actual behavior:
You'll see the content that was being viewed in fzf, but you can no longer scroll up or down in the terminal!--neither with your mouse scroll wheel nor with the PageUp and PageDown keys.
Expected behavior:
The content that was being viewed in fzf should still be visible when you exit fzf with the --no-clear option, and you should still be able to scroll up and down with your mouse scroll wheel and with the PageUp and PageDown keys, just the same as though you had run git log or less -RFX some_filename and then exited! (After running git log or less -X some_filename and exiting, you can still see the output that was on the screen and you can still scroll).

Work-around attempts
1. Run tput rmcup at the end
I see in man fzf the following:

--no-clear
Do  not  clear finder interface on exit. If fzf was started in full screen mode, it will not switch back to the original screen, so you'll have to manually run tput rmcup to return. This
option can be used to avoid flickering of the screen when your application needs to start fzf multiple times in order.

I tried running tput rmcup, and it clears the screen. That's obviously not what I want. I want the screen to not be cleared, hence the --no-clear option in the first place.
2. Add the --height=100 option
I also tried adding the --height=100 option, and it produces very different behavior, but still not the right behavior!
Ex:
# search everything, including file names *and* contents
rg --hidden -L --color always -n '' | fzf --ansi --no-clear --height=100

Now when I quit, I still cannot scroll, and the prompt remains at the top of the screen, overwriting the text beneath it as though you were writing terminal commands and output on top of the remaining fzf screen output. It clutters the screen and appears buggy as well.
3. Type reset to reset the terminal
This gets my scrolling back, but obviously also clears the terminal and wipes away the fzf output, which I don't want--again--the whole point of the --no-clear option is to not clear the fzf screen output.

Unfortunately, --no-clear is probably not what you're looking for. The option was added to address a very specific use case where the user wants to restart fzf on every keystroke to reload the input list while avoiding the constant flicking of the screen due to the restarts. You can read more about it here: https://github.com/junegunn/fzf/issues/974. The strange behavior you see is exactly what we need for that use case.
query=initial
while true; do
  query=$(echo "$query" | fzf --sync --bind change:accept --print-query --query "$query" --no-clear | head -1)
  [[ -z $query ]] && break
done; tput rmcup

However, since the introduction of the reload action (https://github.com/junegunn/fzf/issues/1750), the option has lost its raison d'etre. I'm going to remove --no-clear from the documentation not to confuse the users.
# Much simpler and easier to use
query=initial
echo "$query" | fzf --bind 'change:reload:echo {q}' --print-query --query "$query" --disabled

Thanks for replying. Do you have a solution then that would meet my need, or would that be a new feature request?

Note also that I'd love a clean rg solution like you have here: https://github.com/junegunn/fzf/blob/master/ADVANCED.md#switching-between-ripgrep-mode-and-fzf-mode, except which searches the filename as well, and allows toggling searching the filename as well via Ctrl + N.

It's going to be a new feature, but I'm unlikely to add it. Because 1. it's for niche use cases, 2. and fzf opens in two different modes depending on the value of --height and it's non-trivial to provide consistent UX.
You can limit the scope of search using --nth, but you can't dynamically change it during runtime because fzf is highly optimized for a specific nth value. You'll have to restart fzf with a different set of options in your script (check out --expect)

I came across this issue while trying to write a python script that used fzf twice in a row to gather different user input (basically I'm trying to replace all my rofi-based scripts with fzf-based scripts because I don't want to rely on a gui). It turns out that adding --no-clear to the first fzf call was exactly what I needed in order to avoid the flicker between the two calls. So I just wanted to flag that it might be worth putting information on --no-clear back into the documentation.


Error export .fig file

934-db9f79f4207e36b3.js:1 Uncaught (in promise) RangeError: offset is out of

Flow

Upload attached .fig, -> converted to JSON fine
Download JSON
refresh the page
Upload JSON file from 2
Export .fig -> Failed with error

small-sample.zip
Any idea where to start looking?

Figma introduced videos after I originally wrote this, so I never got to test it with videos yet.
They also support gifs now in fills and even pngs.
So if you stripped down images, can you still encode and decode a single file with a box with a fill in it?


question: how to fetch the remote IP address in WASM

I do not find any doc about how to fetch the remote IP address in WASM.
Many thx for your help.

It is possible to get the upstream IP address by getting the property upstream.address.
I am working with WASM filters written in Rust, so the code looks like.
impl Context for HttpFilter{}

impl HttpContext for HttpFilter {
    fn on_http_response_headers(&mut self, _: usize) -> Action {
        // Add a header on the response.
        let host = self.get_property(["upstream", "address"].to_vec()).unwrap();
        let s = match str::from_utf8(&host) {
            Ok(v) => v,
            Err(_e) => "",
        };
        error!("upstream address {}",s);
        self.set_http_response_header("Hello", Some("world"));
        Action::Continue
    }
}

I would like to create the docs about these properties, if possible.

ok, got it. many thx


Z-Stack 3.0.2 Issues and fixes.

As far as I can see the know issues and fixes for the Z-Stack 3.0.2 are not integrated in the binaries proposed in this repository?
https://e2e.ti.com/support/wireless-connectivity/zigbee-and-thread/f/158/t/902631

I've checked and only the points related to the MAXMEMHEAP for CC2531/CC2530 are integrated.

Ok, I'll have to make a build as I seem to have issue number 8.

I reviewed the patches (firmware_CC2531_CC2530.patch)
The following patch is not commented.
https://github.com/Koenkk/Z-Stack-firmware/blob/d0e58b6132e7363a933a51d027f208450abc6b99/coordinator/Z-Stack_3.0.x/firmware_CC2531_CC2530.patch#L126
Il also suggest that such specific changes are subject to the existance of a "#define" such as "ZIGBEE_MQTT" or something like that.

Summary
Most items on
TI ZSTACK 3.0.2 Patches
were already applied in the ZStack 3.0.2 .
CC2531/ZNP-without-SBL fails with a link error after applying the patches and instructions from this repository.
The issue is with the "CHECKSUM", maybe you already know how to fix it.
Compiling
I patch the tools/znp.bat file to launch znp.js :
[...]
wscript znp.js %2

as START does not start the correct interpreter on my Win10 machine.
Then, I create all binaries from the command line (BUILDZNP) with a script like this (from the CC253x directory):
"C:\Program Files (x86)\IAR Systems\Embedded Workbench 8.1\common\bin\IarBuild.exe" CC2531.ewp -build "ZNP-with-SBL"
"C:\Program Files (x86)\IAR Systems\Embedded Workbench 8.1\common\bin\IarBuild.exe" CC2531.ewp -build "ZNP-without-SBL"
"C:\Program Files (x86)\IAR Systems\Embedded Workbench 8.1\common\bin\IarBuild.exe" CC2530.ewp -build "ZNP-with-SBL"
"C:\Program Files (x86)\IAR Systems\Embedded Workbench 8.1\common\bin\IarBuild.exe" CC2530.ewp -build "ZNP-without-SBL"

I use these scripts in all cases
Original Z-STACK 3.0.2
Compiling the unchanged Z-STACK works.
The produced hex and bin sizes are the same as the original, the content changes
Modified Z-STACK 3.0.2
I applied patches from https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.0.x and changed the configurations as indicated - those are reflected in the *.ewp files.
The CC2530 compilations (hex and binary) work fine.
The CC2531/ZNP-with-SBL compilation also succeeds, CC2531/ZNP-without-SBL fails with a link error:
,  compilations fail during link:
Error[e16]: Segment CHECKSUM (size: 0x4 align: 0) is too long for segment definition. At least 0x2 more bytes needed. The problem occurred while processing the segment placement command "-Z(CODE)CHECKSUM=0x2090-0x2091", where at the moment of placement the available memory ranges were "CODE:2090-2091"
   Reserved ranges relevant to this placement:

After applying the patches proposed by TI,  CC2531/ZNP-without-SBL  still fails with the same error.
Review of TI's changes
The items below are not in the patches provided in this repository.  Item 9 is implicitally applied.  The BDB F&B functionnality (19) is not enabled in this repository and does not impact the ZNP.  21 may note berelevant either, so only the first item may need to be integrated for the ZNP.
I applied:
8. ZDAPP_UPDATE_NWK_NV_TIME change

Increase MAXMEMHEAP to 2800 in CC2530.ewp .
Increased INT_HEAP_LEN from 2048 to 2800 in TI2530DB/OnBoard.h

Errors due to BDB header build types
Changed f8wCoord.cfg accordingly - headers seemed changed already.
Changed EndDevice-Pro.lib and Router-Pro.lib in ewp files.
Changed all '#if ( ZSTACK_ROUTER_BUILD ) || defined ( ZBIT )' (nwk_globals.*)

Memory Leak in the F&B Function of BDB
Added bdb_zclSimpleDescClusterListClean call

Skipped: 20. Large number of Address Manager Entries Results in Long ZC Startup Times

Multiple attribute reporting issue

For that compile error try reducing the MAXMEMHEAP a bit

I set MAXMEMHEAP to 2800, but that did not help initially - I had to fix something else first.
It turns out that it's my bad, I got the "FIRMWARE_SBL" define correct for the CC2530 compilations, but wrong for the CC2531 compilations.
As a result two extra bytes were requested for the CHECKSUM as it is being added outside the source code when compiling for  "CC2531 - ZNP-without-SBL".
After fixing that, I got the error:
"Error[e104]: Failed to fit all segments into specified ranges. Problem discovered in segment XDATA_N. Unable to place 2 block(s) (0x200 byte(s) total) in 0x131 byte(s) of m
emory. The problem occurred while processing the segment placement command "-P(XDATA)XDATA_N=_XDATA_START-_XDATA_END", where at the moment of placement the available memory
ranges were "XDATA:1dcf-1eff"
Error while running Linker
"
I had to reduce the MAXMEMHEAP to 2995 (208 bytes less, or 0xd0 , about 0x200-0x131=0xCF) .
So the MAXMEMHEAP limit varies with FIRMWARE_SBL .
So your hint was anticipating the "next" error.  Thanks!


Remove xfail on fixed hpa_source tests

To be merged after CI rocm version updated

The change looks OK.
Could you confirm why CI test is failing?

The test failure was due to a compiler bug introduced in rocm 5.3. The test was marked xfail until a compiler update was ready. The current rocm build on CI has the fix in it, but CI is soon moving to another build that does not have the fix in it (so the test will again be expected to fail). We can merge this as soon as CI returns to a build with the patch (or sooner if we don't mind seeing a known test failure in builds)


In Go client 2.3.2, can't get re-delivered message after add AckTimeout in ConsumerOptions

Describe the bug
In Go client, after I set ack timeout in the consumer side; when I send messages and didn't ack them, I can't get the re-delivered messages
To Reproduce
package main

import (
	"context"
	"fmt"
	"log"
	"time"

	"github.com/apache/pulsar/pulsar-client-go/pulsar"
)

func main() {
	topic := "persistent://public/default/some_partition_topic"

	// Instantiate a Pulsar client
	client, err := pulsar.NewClient(pulsar.ClientOptions{
		URL: "pulsar://localhost:6650",
	})

	if err != nil {
		log.Fatal(err)
	}

	// Use the client to instantiate a producer
	producer, err := client.CreateProducer(pulsar.ProducerOptions{
		Topic: topic,
	})

	if err != nil {
		log.Fatal(err)
	}

	// Use the client object to instantiate a consumer
	consumer, err := client.Subscribe(pulsar.ConsumerOptions{
		Topic:            topic,
		SubscriptionName: "subName",
		Type:             pulsar.Shared,
		AckTimeout:       60 * time.Second,
	})

	ctx := context.Background()
	// Send 10 messages synchronously and 10 messages asynchronously
	for i := 0; i < 5; i++ {
		// Create a message
		msg := pulsar.ProducerMessage{
			Payload: []byte(fmt.Sprintf("message-%d", i)),
		}
		// Attempt to send the message
		if err := producer.Send(ctx, msg); err != nil {
			log.Fatal(err)
		}
	}

	// Listen indefinitely on the topic
	for {
		msg, err := consumer.Receive(ctx)
		if err != nil {
			log.Fatal(err)
		}
		// Do something with the message
		fmt.Println("" + time.Now().Format(time.RFC850) + " consume " + string(msg.Payload()))
		//consumer.Ack(msg)
	}
}

Expected behavior
I can get re-delivered message.
Screenshots
2019/06/25 13:40:55.168 c_client.go:68: [info] INFO  | PartitionedConsumerImpl:246 | Successfully Subscribed to Partitioned Topic - persistent://dev/genericfileproc/npulsar_test_input_topic with - 4 Partitions.
Tuesday, 25-Jun-19 13:40:55 NZST consume message-0
Tuesday, 25-Jun-19 13:40:55 NZST consume message-1
Tuesday, 25-Jun-19 13:40:55 NZST consume message-2
Tuesday, 25-Jun-19 13:40:55 NZST consume message-3
Tuesday, 25-Jun-19 13:40:55 NZST consume message-4

Desktop (please complete the following information):

OS: Linux

Additional context
In Java Client I can get re-delivered message.
/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/bin/java "-javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=52644:/Applications/IntelliJ IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath /Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/ext/zipfs.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/javaws.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/jfxswt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/management-agent.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/plugin.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/ant-javafx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/dt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/javafx-mx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/jconsole.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/packager.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/sa-jdi.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_212.jdk/Contents/Home/lib/tools.jar:/Users/stevenwang/Projects/Java/target/classes:/Users/stevenwang/.m2/repository/org/apache/pulsar/pulsar-client/2.3.2/pulsar-client-2.3.2.jar:/Users/stevenwang/.m2/repository/org/apache/pulsar/pulsar-client-api/2.3.2/pulsar-client-api-2.3.2.jar:/Users/stevenwang/.m2/repository/org/apache/pulsar/protobuf-shaded/2.1.0-incubating/protobuf-shaded-2.1.0-incubating.jar:/Users/stevenwang/.m2/repository/org/lz4/lz4-java/1.5.0/lz4-java-1.5.0.jar:/Users/stevenwang/.m2/repository/com/github/luben/zstd-jni/1.3.7-3/zstd-jni-1.3.7-3.jar:/Users/stevenwang/.m2/repository/org/bouncycastle/bcpkix-jdk15on/1.60/bcpkix-jdk15on-1.60.jar:/Users/stevenwang/.m2/repository/org/bouncycastle/bcprov-jdk15on/1.60/bcprov-jdk15on-1.60.jar:/Users/stevenwang/.m2/repository/com/sun/activation/javax.activation/1.2.0/javax.activation-1.2.0.jar:/Users/stevenwang/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/Users/stevenwang/.m2/repository/javax/validation/validation-api/1.1.0.Final/validation-api-1.1.0.Final.jar UnackedTrackerIssue
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
2019-06-25T01:42:31.590Z consume java 0
2019-06-25T01:42:32.596Z consume java 1
2019-06-25T01:42:33.608Z consume java 2
2019-06-25T01:42:34.616Z consume java 3
2019-06-25T01:42:35.628Z consume java 4
2019-06-25T01:43:12.076Z consume java 0
2019-06-25T01:43:13.076Z consume java 1
2019-06-25T01:43:14.076Z consume java 2
2019-06-25T01:43:15.082Z consume java 3
2019-06-25T01:43:16.079Z consume java 4
2019-06-25T01:43:53.122Z consume java 0
2019-06-25T01:43:54.122Z consume java 1
2019-06-25T01:43:55.123Z consume java 2
2019-06-25T01:43:56.125Z consume java 3
2019-06-25T01:43:57.126Z consume java 4
2019-06-25T01:44:34.172Z consume java 0
2019-06-25T01:44:35.173Z consume java 1
2019-06-25T01:44:36.175Z consume java 2
2019-06-25T01:44:37.176Z consume java 3

@wolfstudy If you have time, can you help with the go client issue?

@stevenwangnarvar hello, I didn't find the problem with the code you provided above. The acktimeout you set is 60s. When the 60s arrives and the message has not been acked, it will be received again.
2019/06/25 11:54:05.623 c_client.go:68: [info] INFO  | ConnectionPool:72 | Created connection for pulsar://localhost:6650
2019/06/25 11:54:05.626 c_client.go:68: [info] INFO  | ClientConnection:314 | [<IP_ADDRESS>:51022 -> <IP_ADDRESS>:6650] Connected to broker
2019/06/25 11:54:05.630 c_client.go:68: [info] INFO  | HandlerBase:52 | [persistent://public/default/some_partition_topic, ] Getting connection from pool
2019/06/25 11:54:05.630 c_client.go:68: [info] INFO  | ConnectionPool:72 | Created connection for pulsar://ranxiaolong:6650
2019/06/25 11:54:05.632 c_client.go:68: [info] INFO  | ClientConnection:316 | [<IP_ADDRESS>:51024 -> <IP_ADDRESS>:6650] Connected to broker through proxy. Logical broker: pulsar://ranxiaolong:6650
2019/06/25 11:54:05.635 c_client.go:68: [info] INFO  | ProducerImpl:155 | [persistent://public/default/some_partition_topic, ] Created producer on broker [<IP_ADDRESS>:51024 -> <IP_ADDRESS>:6650]
2019/06/25 11:54:05.635 c_client.go:68: [info] INFO  | Client:88 | Subscribing on Topic :persistent://public/default/some_partition_topic
2019/06/25 11:54:05.636 c_client.go:68: [info] INFO  | HandlerBase:52 | [persistent://public/default/some_partition_topic, subName, 0] Getting connection from pool
2019/06/25 11:54:05.639 c_client.go:68: [info] INFO  | ConsumerImpl:170 | [persistent://public/default/some_partition_topic, subName, 0] Created consumer on broker [<IP_ADDRESS>:51024 -> <IP_ADDRESS>:6650]
Tuesday, 25-Jun-19 11:54:05 CST consume message-0
Tuesday, 25-Jun-19 11:54:05 CST consume message-1
Tuesday, 25-Jun-19 11:54:05 CST consume message-2
Tuesday, 25-Jun-19 11:54:05 CST consume message-3
Tuesday, 25-Jun-19 11:54:05 CST consume message-4

2019/06/25 11:56:05.637 c_client.go:68: [info] INFO  | UnAckedMessageTrackerEnabled:47 | [persistent://public/default/some_partition_topic, subName, 0] : 15 Messages were not acked within 60000 time
Tuesday, 25-Jun-19 11:56:05 CST consume message-0
Tuesday, 25-Jun-19 11:56:05 CST consume message-1
Tuesday, 25-Jun-19 11:56:05 CST consume message-2
Tuesday, 25-Jun-19 11:56:05 CST consume message-3
Tuesday, 25-Jun-19 11:56:05 CST consume message-4

Hi @wolfstudy , did you use partition topic or non-partition topic? The issue occurs on partition topic.

Hi @wolfstudy , did you use partition topic or non-partition topic? The issue occurs on partition topic.

i use non-partition topic

Hi @sijie @wolfstudy, what's the status for this issue? When we can fix it? In the next release or?

hello @stevenwangnarvar the issue will be fixed in pull request:4653, PTAL thanks


[BP-1.12][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner

Backport of #17033 to release-1.12.

Thanks for the review @zentol. Merging this PR now.


Call Page.unpublish() on each page when unpublishing queryset

Fixes #745 (page_unpublished signal is now fired when unpublishing via queryset). Redo of #1279 with unit test.

Looks good to me

Merged in 78ba194f48ab8c42bcaac022e1e17c4d74906247. Thanks!


NIFI-4060: Initial implementation of MergeRecord

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

@mattyb149 I did realize that after setting mime.type we were overwriting it with the mime.type attribute of incoming FlowFiles. Sorry about that. I also found and fixed a threading issue in the RecordBinManager and improved the documentation around the Processor. I have pushed another commit that handles all of this. Please give it another review if you are able.

+1 LGTM, verified most recent updates and re-ran my functional tests, also verified updated doc. Thanks much! Merging to master


Texture on Singleplayer is different to the multiplayer texture

Title pretty much describes the issue, Lootr version is v.<IP_ADDRESS> (1.20.1)

What multiplayer texture are you using?

the multiplayer texture I've seen is the gold (unopened) > blue (opened) texture

You can change to the old textures through the configuration on the client. "old_textures" is the option you're looking for.


integrating this crashes my test android app

i am trying to use the azure/xamarin todo list app (mobile quickstart on azure) as a testbed. I am trying to add this in, and as soon as I try any of the sample code to scan my app crashes.
I am using the mobile quickstart because it integrates with azure, sql etc... so it shortcuts a number of issues I would have to figure out on my first azure app.  now I am just trying to figure out how to add a quick scan ability to see how I can work it into my app.

Please include a stack trace


METRON-1761, allow application of grok statement multiple times

This PR adds support for incoming messages to grok parsers that have multiple log lines.
Instead of having to split the logs before sending to metron/kafka, you could just send the logs in batches.
todo testing
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[-] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[-] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

@ottobackwards Any update on this? I think it's valuable to have in.

I am sorry, I missed the comments on this.  I will try to have something soon.

@mmiklavc wrt failing the whole message or some sort of partial failure scheme.  I don't like failing multiples if we can parse some lines, but I don't see a good way to cleanly handle it.  Or we need to talk it through.
We could track exceptions and lines processed.... and if we got an exception for every line fail the file, else log the execeptions and a message about only parsing x of y lines and pass back a partial message list.
Thoughts?

@ottobackwards Yeah, I took a look through the ParserBolt and the MessageParser interface. We process a raw byte array. A clean way of doing that isn't immediately obvious to me either. Perhaps these semantics could be documented for the parser? Minimally, I think we should describe the 2 cases I outlined above.

If you think the "every line fails" == fail, some fails = emit and log works, we can do that, but I don't know how or if we want to put things in the error stream.  I need to look at it more closely.  I think that solving this might be beyond this pr, with a documentation note as you state.

@mmiklavc Can you take a look at the parser.validate() stuff in the bolt?  Maybe the answer is put a dummy invalid record in there and fail validation for each parse failure?

@mmiklavc I looked through the validation stuff more, I think that validation is the way to go here.  The grok parser will add invalid message for each exception, parser failure, and then in the validation call fail those messages.  It will have to be done so that the returned message makes sense when it is sent to the error topic.
What do you think?   @cestella ?

@ottobackwards I see what you're saying. It looks like that could definitely work. Thinking out loud here, but might that conflate the semantics of our validation a bit? Validate currently does things like ensure that a timestamp exists on the message, though I don't see why we couldn't expand it to validations outside of our global Metron context.
One class that might be worth checking out is the unified enrichment topology. This was changed to include a parallel enricher that handles errors and message results in an EnrichmentResult class.

https://github.com/apache/metron/blob/master/metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/UnifiedEnrichmentBolt.java#L270
https://github.com/apache/metron/blob/master/metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/parallel/ParallelEnricher.java#L63

It looks to me like there might be some possible collaboration opportunity and overlap with the work you're doing here and the work @merrimanr is doing on this PR - https://github.com/apache/metron/pull/1213#pullrequestreview-161248142
I'm just wondering if we might be able to kill 2 birds with one stone. We probably don't want to change the MessageParser interface, but maybe we can manage the bulk processing through a more generalized bridge between the ParserBolt and parser implementations. I haven't dug too deep into implementation feasibility, but it seems worth considering.

@mmiklavc  but we don't have messages to split, we have bytes.  If we where going to leave the 'parser's as single object -> single result | single exceception', ie not change the interface and not subvert validate, then we would have to introduce 'splitStrategies' at the bolt.

@ottobackwards Yeah, understood about the message vs raw bytes. It seems like there are 2 options here - use validate or modify the message parser interface to return a List of something other than a List<JSONObject>. If you were to go the validate route, how would you modify and return the messages that failed to parse so that validate can handle them? I'd expect them to be indexed to the error topic in the same style as the single message parsers.

Looking at the code in parserbolt, I think the only thing missing with the validate route is the original parser exception. Here's how errors are handled when validation error occurs:
ErrorUtils.handleError(collector, error);

here's how they're handled when an exception occurs during parsing:
} catch (Throwable ex) {
    handleError(originalMessage, tuple, ex, collector);
}

So the idea would be that the JSONObject returned for the failed line ( that would be passed to handle error ) would be a new object that had the raw line, the exception type, the exception message in it.
That would all get passed through to the Error stuff.  We could put anything we wanted in there.

@ottobackwards That sounds reasonable to me. One thing I would definitely add to the documentation for this is some comment about how it changes processing semantics and might require additional tuning. Since we now have batch sizing specified for the writers to Kafka, there may be a little bit of tweaking there, but I'm just not sure.

It think the API should be improved ideally, but that is in the future

Let me give it a shot, I'll document the semantics of the failure mode and we can look again

If it turns out that this is just such a duck tape job, we can always close the PR and open a jira for the new api

actually, I'm just going to close this.  Once I step back from "how could I do this" to look at the big picture, it doesn't seem like a good idea.  This is not a field issue, more of an improvement, so there is no need to hammer something in.

Closing this pr. I will create a jira for api improvement

re-opening for input

So I talked @ottobackwards into initially adding this feature 😄 The reason I asked for this improvement is that have a bunch of log files which contain a relevant entry per line. I currently have to rely on 3rdparty tools to split these logfiles into messages (where 1 log line == 1 message) before sending them to Metron. I was hoping to just ingest the log and Metron would take care of this.
To me, relying on 3rdparty tools for what I assume to be a normal use case for a SIEM seems a bit strange.

I prefer @mmiklavc's suggestion several comments back:  return a List of something other than a List.  Could we use a wrapper that can contain results and errors?  The calling class could then determine the best way to handle errors without having to fail the whole batch.

@merrimanr @mmiklavc First pass of what we discussed

This looks good to me @ottobackwards. I think the only thing left is some docs telling users how to add both existing and custom parsers to take advantage of this feature.

@mmiklavc please see latest commit

@merrimanr any comment?

+1 from me too.  I will merge this into https://github.com/apache/metron/pull/1213 once it's in master and we can continue moving forward there.  Parsing is getting an upgrade!


Breadcrumbs tree structure on Product detail page is different

Breadcrumbs tree structure on Product detail page differs when page is opened from category and on page reload.
Steps to reproduce:

Open demo category page https://demo.vuestorefront.io/c/women-20
Click on "Minerva LumaTech™ V-Tee" product
Product details page for ""Minerva LumaTech™ V-Tee"" is opened
Breadcrumbs tree structure is:
Default Category / Women / Minerva LumaTech™ V-Te

Reload the page, breadcrumbs tree has another structure:
Tees / Minerva LumaTech™ V-Tee

This is because when You enter product URL directly we don't have the category context and product can be assigned to more than one category. VS is currently creating the breadcrumb probably from the first cateogry assigned to the product (to be checked) - which is not always the "root" one

@pkarw shouldn't we fix it?


feat: Add Staatliche Berufsschule Fürstenfeldbruck to JetBrains/swot

Added domain for Staatliche Berufsschule Fürstenfeldbruck to allow students access to JetBrains educational products.
Updated lib/domains/de/bs-ffb/ directory to include schueler.txt which is the subdomain domain used for students

This is the official school website: https://www.bs-ffb.de/

@karol-broda First stage of verification passed, official domain for Staatliche Berufsschule Fürstenfeldbruck is schueler.bs-ffb.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@philipto is there any update or a ETA?

@karol-broda Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


SystemMediaTransportControls example doesn't seem to work

I ran the sample in Win10 desktop (surface pro with play/cause on keyboard and volume controls) and on an xbox.  both running build 14295.  I played a file on both, and then hit the play/pause on the surface, or any of the 6 media control buttons on the media remote on the xbox and nothing fired (I added a Debug.WriteLine to the start of systemMediaControls_ButtonPressed and systemMediaControls_PropertyChanged).
On the xbox its hard to get to the file picker button (using the dpad and controls was able to do so however).   Also I hardwired in a sample file rather than using the picker.
In my own app I wasn't able to get the events to fire either.

Sorry to hear you're having trouble with that sample. We'll take a look tomorrow and get back to you.

You might also try the BackgroundAudio sample in the meantime which uses SystemMediaTransportControls as well. 14295 is a preview build and not feature complete, so to set expectations, you may need to revert to a release build or wait for the next flight update.

@aarononeal  alright figured it out.
It is 100% a 14295 issue, works fine on older builds.
A workaround for 14295 is also possible:
The problem is caused by setting
systemMediaControls.IsEnabled = false;
and then setting (or adding handlers) for any of the following:
Attaching to: AutoRepeatModeChangeRequested,PlaybackPositionChangeRequested,PlaybackRateChangeRequested
or touching properties like IsPauseEnabled, IsPlayEnabled, etc.

Ironically you can attach to certain events (like button pressed) without issue.  I figured maybe attaching to them after enabling the control would fix it, it does not.
The work around is fairly simple, before touching/attaching to those events set IsEnabled=true,  do your work then set it back to false.  This resolves it.
Have not tested on an xbox but assuming it will resolve there too.

Also, both on 14295 and 10586 don't seem to actually do anything with timeline information (I don't see a seek bar?) maybe it only responds to rewind/ff controls although I don't know the ID code to simulate those button presses, or maybe it is reserved for future use.

Thank you! I've just finished testing a recent build and it reproduces there as well. Looks like you've found a good platform regression for us to fix. I'll pass this info along to the team so we can get it corrected in a future flight.
Regarding timeline properties, we don't currently display it in the system control but it may show on Bluetooth devices and we may update OS controls in the future.


Black border at bottom or right side when SizeToContent défined

A border line bleck appears at bottom of window when SizeToContent is defined to Height ! It seems to me this problem has been fixed. But it appears since last version. Perhaps, the problem is in my code. I'm using the last stable version.

Thanks,
Jean-François

@jfbaudracco can you re-test this with 1.0 (or/and latest alpha version) ? this should be fixed now. thx


Collect a list of good skills and knowledge contributions

These can be previously created files in the taxonomy, added by the backend team early even, so that we can give a variety of examples that are high quality.
This may also need to be updated: https://github.com/instruct-lab/community/blob/main/docs/SKILLS_GUIDE.md

Ongoing, this has been a challenge in everyones side.


Added Unit Test functions for System Services APIs

Added Unit Test functions for the below System Services APIs :
1.SystemServices::getMfgSerialNumber
2.SystemServices::getDeviceInfo
3.SystemServices::setBootLoaderPattern
4.SystemServices::getXconfParams
5.SystemServices::clearLastDeepSleepReason
6.SystemServices::getStateInfo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Created another pull request for latest branch sprint/23Q1 here:  https://github.com/rdkcentral/rdkservices/pull/3768


Fix dark theme in widgets example

Fixes https://github.com/JetBrains/compose-jb/issues/1490

Interesting why this change fixes theming?

Material theme applies only to the material components.
In widgets example we didn't have "background" component, so it was always white.


[NEW FEATURE] Stateful functions

Hello guys, recently I created and started using a function that I think can be useful as part of this library.
The utility is quite handy when working with forms and requests like PUT, PATCH, POST, DELETE, i.e., when you need to perform some action on the backend while displaying its state to the user.
StatefulFn
This utility creates a function based on the passed function that contains the execution state based on the new signal API.
Creating a stateful function
This way you can create a function whose state you are interested in:
@Component()
class MyComponent {
  submit: StatefulFn;

  constructor() {
    this.submit = createStatefulFn(async () => {
      await firstValueFrom(this.httpClient.post(url));
    })
  }
}

And here's how you can use it in the template:
<form>
  <button (click)="sumbit()" [disabled]="submit.pending()">Submit</button>

  @if (submit.error(); as error) {
    {{ error.message }}}
  }
</form>

Let me know if you're interested and then I'll create a PR.

Duplicate of #56 in terms of usage in the template.


Product Card button text color same as background color

Issue Summary
The text inside a Product Card button is the same color as the background, making it invisible. This only happens when viewing the site, not editing it. (This happens in 3 different themes I tested, but not in Casper.)
When editing:

When not logged in:

Here's the same image but with all text selected to make it visible:

You can see this bug live here (password "letmein").
Steps to Reproduce

Install a theme other than Casper (e.g. Edition theme).
Add a Product Card with a button and some text.
Note that the value in (Settings / Site Design / Brand / Accent color) appears as both product button background and text color.

Ghost Version
Ghost(Pro)
Node.js Version
Ghost(Pro)
How did you install Ghost?
Ghost(Pro)
Database type
Other
Browser & OS version
Google Chrome Version 96.0.4664.110 (Official Build) (x86_64), OS X 11.6
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey @richtaur, I've just checked your site and found that the Edition theme installed on your site isn't up-to-date. If you're seeing the issue on other official themes as well, make sure you're using the latest copy of the themes.
This is how it looks on Edition theme demo site.

Ahh yes that was it, thanks!


.NET 4.5 System.Xml reference assembly has the wrong case in the name

The reference assembly in Reference Assemblies\Framework\.NETFramework\v4.5 is named System.XML.dll -- but the standard name used when referencing the dll is System.Xml, as far as I can tell. On case-sensitive file systems this causes MSBuild to not find the reference.

System.XML is a bit of a weird assembly, because the actual name in the GAC is System.Xml (see also https://github.com/aspnet/Testing/issues/60).
Mono uses System.Xml.dll everywhere, and I know it has caused issues in the past when someone took a csproj with System.XML in it to Linux. It seems that recent VS versions emit System.Xml in the csproj though and the .NET 4.6 reference assemblies also use that casing.

In newer versions of .NET, the assembly has been properly cased as System.Xml.


GitHub Action errors

Describe the bug
Warnings in compile-sketches.yml, e.g. warning: there are no arguments to 'readPin' that depend on a template parameter, so a declaration of 'readPin' must be available [-fpermissive]
To Reproduce
Steps to reproduce the behaviour:

Go to 'GitHub Actions'
Click on 'Look at a action og'
Scroll down to 'Compiling Sketch...'
See error

Expected behaviour
No warnings in the output.
Screenshots
If applicable, add screenshots to help explain your problem.
Arduino (please complete the following information):

OS: MacOS
IDE: GitHub Actions

Additional context
Add any other context about the problem here.

Fixed code. GitHub Actions passing without AbleButtons warnings (some platform warnings remain)


[WIP] Hide thumbnails from screen readers

*** THERE MAY BE A BETTER WAY ***
Override the featured and recent views on the home page to add aria hidden true to the thumbnail image options. Updates the catalog views from Blacklight to hide the thumb via aria hidden. Updates the works and collections listings in the MY index partials.
Adds empty alt tag as an option for render thumbnail tag. Update spec test to switch i element to span element per Bootstrap styles.

Yeah @awead and Derek and I worked on that on Friday in our refactoring session. Just trying to get the tests to run/pass. My branch is here:
https://github.com/psu-stewardship/scholarsphere/tree/thumbnails-%23464-3

Got a better way to do this. Abandon ship!


Labelling data using pre-tranied model

I have 230k images. How can I label them using pre-trained model or any suggestion .

There's integration with opencv's open model zoo and OpenVino: https://github.com/opencv/cvat/tree/develop/cvat/apps/auto_annotation
There's semantic segmentation via mask rcnn: https://github.com/opencv/cvat/tree/develop/components/auto_segmentation
There's semi automatic segmentation via Dextr: https://github.com/opencv/cvat/tree/develop/cvat/apps/dextr_segmentation
OpenVino can convert almost any tensorflow and pytorch model.
Did that help? Is there any other questions I can answer?

I need tool for yolo format

https://github.com/opencv/cvat/tree/develop/utils/open_model_zoo/yolov3

@ogulcankarayel5 ,
I hope @benhoff answered your questions. Please use our gitter channel to ask next questions. I will close the issue.
Thanks @benhoff for your help!


Update install_command in tox to force install up-to-date dependencies

Force pip by --no-cache-dir to pull in up-to-date versions of all dependencies. See https://github.com/jazzband/pip-tools/issues/858#issuecomment-515244332.
Print explicitly pip version for debugging to know which exactly version
of pip was installed with PIP=latest.
Also had to upgrade 19.0 to 19.0.3, since pip crashes with --no-cache-dir in 19.0. See https://github.com/pypa/pip/issues/6158.
P.S.
Previously i've been considered to add -U flag, but it doesn't work with pip==8.1.1 on windows py36. See https://github.com/jazzband/pip-tools/pull/859#issuecomment-515373865.

In general / on top of this: https://github.com/jazzband/pip-tools/pull/867

Thanks @blueyed!


feature Fix data wrong using mv rewrite and ignore case when getting mv related partition table

Proposed changes

Fix data wrong using mv rewrite
Ignore case when getting mv related partition table
Enable infer expression column name without alias when create mv

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


In 2048, issue when moving too fast

If starting the swipe move very fast, before the previous move is finished, there is an unexpected behaviour with tiles: new tiles appear with no value, and tiles are mixed up.

Possible solution: add variable that is set to True during the move, and False at the end of the move. The new move will not start until this is False.

Done, added a _moving variable that is true during the move (become false at the end of move). If a new move starts when still true, the new move is rescheduled 0.01s later.


:Telescope aerial showing way less results than :Telescope lsp_document_symbols picker

Describe the bug
Hello! In the README, it says:

If you have telescope installed, there is an extension for fuzzy finding and jumping to symbols. It functions similarly to the builtin lsp_document_symbols picker.

For me, it seems like Aerial is showing way less results than lsp_document_symbols. Here's the Telescope builtin results for a sample file I have (excuse the whacky colors):

And then this is what I see with :Telescope aerial on the same file (fwiw, this is also what's shown in the Aerial window, so I don't think this is a Telescope problem)

Am I doing something wrong? My basic configuration looks like this (I install LSP backends with nvim-lsp-installer, and things seem to be configured okay for most things):
local lsp_installer = require("nvim-lsp-installer")
lsp_installer.on_server_ready(function(server)
    local opts = {}
    local aerial = require("aerial")

    opts.on_attach = function(client)
        -- other configs

        aerial.on_attach(client)
    end

    server:setup(opts)
end)

System information

OS: macOS 12.0.1
Neovim version: 0.6.0
AerialInfo:

Aerial Info
-----------
Filetype: lua
Configured backends:
  lsp (supported) (attached)
  treesitter (supported)
  markdown (not supported)
Show symbols: Class, Constructor, Enum, Function, Interface, Method, Struct

To Reproduce
Steps to reproduce the behavior:

Compare the output of :Telescope aerial and :Telescope lsp_document_symbols

This is by design, though the documentation could be more clear. Aerial doesn't show all document symbols by default because it's very noisy. There are a lot of symbols (e.g. Array, Boolean, Null) that don't really help you get a summary of your file. See :help aerial_filter_kind for detailed information.
If you do want to see all the symbols that LSP provides, you can disable filtering by setting the filter_kind option to false. If you do that, it should behave exactly the same as :Telescope lsp_document_symbols

Ah, thanks for that! FWIW, I do want to see all that noise, especially in Telescope where really what I'm trying to do is jump to a symbol I know is in the document. Perhaps that should be the default for the telescope picker?

I think the aerial picker should only show the symbols that are in the aerial window. If you want that behavior, why not just use :Telescope lsp_document_symbols?

Touché 🙂


LED control support PWM-LED

change LED control from GPIO to PWM
base on QCA "ipq5018_wi-fi_access_point_soc_data_sheet.pdf"  and "IPQ50XX_SOC_Software_User_Guide.pdf"
add kernel config CONFIG_LEDS_PWM and pinctrl-ipq5018.c

check fail , close then re-request


Not able to find reference on s3.amazon

When I run any of the two examples I get the following error:
create_report examples/junctions/Introns.38.bed \
    https://s3.dualstack.us-east-1.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa \
    --type junction \
    --ideogram examples/junctions/cytoBandIdeo.txt \
    --output junctions.html \
    --track-config examples/junctions/tracks.json \
    --info-columns TCGA GTEx variant_name \
    --title "Sample A"

Traceback (most recent call last):
  File "/home/daniel/miniconda3/bin/create_report", line 8, in <module>
    sys.exit(main())
  File "/home/daniel/miniconda3/lib/python3.8/site-packages/igv_reports/report.py", line 234, in main
    create_report(args)
  File "/home/daniel/miniconda3/lib/python3.8/site-packages/igv_reports/report.py", line 87, in create_report
    data = fasta.get_data(args.fasta, region)
  File "/home/daniel/miniconda3/lib/python3.8/site-packages/igv_reports/fasta.py", line 21, in get_data
    fasta = pysam.FastaFile(fasta_file)
  File "pysam/libcfaidx.pyx", line 123, in pysam.libcfaidx.FastaFile.__cinit__
  File "pysam/libcfaidx.pyx", line 155, in pysam.libcfaidx.FastaFile._open
OSError: file `https://s3.dualstack.us-east-1.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa` not found

Are you able to access the hg38.fa file if you directly enter the link into your web browser?

Yes I am. I just tried running the command again, with the same error. I'm running from the newest master branch.

That is strange. And there's nothing about the environment where you're running create_reports that would prevent access to the file at Amazon? Since you do have access to the file via the browser, one workaround would be to download it and just use the local version.

In that case I suggest you download the fasta (and its associated index)
and use them as local files.   I can't reproduce your problem here.    To
run the example you referenced download
https://s3.dualstack.us-east-1.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa
and
https://s3.dualstack.us-east-1.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa.fai.
Save them locally and use the full path to the fasta file.
On Tue, Oct 6, 2020 at 11:47 PM Daniel Thaagaard Andreasen <
<EMAIL_ADDRESS>wrote:

Yes I am. I just tried running the command again, with the same error. I'm
running from the newest master branch.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/igvteam/igv-reports/issues/45#issuecomment-704732155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHD2HCQP273WRXK3P3UPLTSJQFHDANCNFSM4SF3LZOQ
.

The other thing you might try,  python being python,  is to create and install to a fresh environment.   You might have an old version of pysam that is not recognizing urls.
I'm closing this as it can't be reproduced.

Sorry to see this issue closed so fast.
I tried making a new conda environment, installed pip, and then igv-reports. I'm using python 3.8.6, and pysam <IP_ADDRESS> (the latest version as of right now), and still it doesn't work.
However, if I download the reference genome and its index I can make it run.
Just out of curiousity, which versions of python and pysam are you using?

I'll re-open if you describe a problem I can reproduce.   Closing just takes it off my active list,  I'm not meaning to preclude discussion and questions.   I use 3.7.2 with this project.

And which version of pysam do you use?

We have tried 0.15.3 and <IP_ADDRESS>

I am getting the same error. You can replicate it with this Dockerfile;
FROM continuumio/miniconda3:4.5.4

RUN conda install bioconda::pysam==0.15.3

# need to install igv-reports from Git because the pip version is out dated and lacks some critical bug fixes; https://github.com/igvteam/igv-reports/issues/47
RUN git clone https://github.com/igvteam/igv-reports.git && \
    cd igv-reports && \
    git checkout 7e12305 && \
    pip install -r requirements.txt && \
    python setup.py install

ADD test.sh /test.sh

with this test script test.sh;
#!/bin/bash
set -x
create_report \
/igv-reports/examples/variants/variants.vcf.gz \
https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa \
--ideogram examples/variants/cytoBandIdeo.txt \
--flanking 1000 \
--info-columns GENE TISSUE TUMOR COSMIC_ID GENE SOMATIC \
--tracks \
/igv-reports/examples/variants/variants.vcf.gz \
/igv-reports/examples/variants/recalibrated.bam \
/igv-reports/examples/variants/refGene.sort.bed.gz \
--output igvjs_viewer.test.html

Running it;
$ docker run --rm -it igv-reports-1.0.1 bash
root@729dc29e270b:/# ./test.sh
+ create_report /igv-reports/examples/variants/variants.vcf.gz https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa --ideogram examples/variants/cytoBandIdeo.txt --flanking 1000 --info-columns GENE TISSUE TUMOR COSMIC_ID GENE SOMATIC --tracks /igv-reports/examples/variants/variants.vcf.gz /igv-reports/examples/variants/recalibrated.bam /igv-reports/examples/variants/refGene.sort.bed.gz --output igvjs_viewer.test.html
Traceback (most recent call last):
  File "/opt/conda/bin/create_report", line 33, in <module>
    sys.exit(load_entry_point('igv-reports==1.0.1', 'console_scripts', 'create_report')())
  File "/opt/conda/lib/python3.7/site-packages/igv_reports-1.0.1-py3.7.egg/igv_reports/report.py", line 234, in main
    create_report(args)
  File "/opt/conda/lib/python3.7/site-packages/igv_reports-1.0.1-py3.7.egg/igv_reports/report.py", line 87, in create_report
    data = fasta.get_data(args.fasta, region)
  File "/opt/conda/lib/python3.7/site-packages/igv_reports-1.0.1-py3.7.egg/igv_reports/fasta.py", line 21, in get_data
    fasta = pysam.FastaFile(fasta_file)
  File "pysam/libcfaidx.pyx", line 123, in pysam.libcfaidx.FastaFile.__cinit__
  File "pysam/libcfaidx.pyx", line 155, in pysam.libcfaidx.FastaFile._open
OSError: file `https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa` not found

note that I am using a git clone of the repo in there and not installing from pip for the reason mentioned in the comments.

I also get the same error if I install igv-reports from pip;
Dockerfile;
FROM continuumio/miniconda3:4.5.4
RUN conda install bioconda::pysam==0.15.3 conda-forge::unzip
RUN pip install igv-reports
RUN wget https://s3.amazonaws.com/igv.org.test/reports/examples.zip && unzip examples.zip
ADD test.sh /test.sh

test.sh
#!/bin/bash
set -x

create_report \
/examples/variants/variants.vcf.gz \
https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa \
--ideogram examples/variants/cytoBandIdeo.txt \
--flanking 1000 \
--info-columns GENE TISSUE TUMOR COSMIC_ID GENE SOMATIC \
--tracks \
/examples/variants/variants.vcf.gz \
/examples/variants/recalibrated.bam \
/examples/variants/refGene.sort.bed.gz \
--output igvjs_viewer.test.html

result;
$ docker run --rm -it igv-reports-1.0.1 bash
root@342a8774e36b:/# ./test.sh
+ create_report /examples/variants/variants.vcf.gz https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa --ideogram examples/variants/cytoBandIdeo.txt --flanking 1000 --info-columns GENE TISSUE TUMOR COSMIC_ID GENE SOMATIC --tracks /examples/variants/variants.vcf.gz /examples/variants/recalibrated.bam /examples/variants/refGene.sort.bed.gz --output igvjs_viewer.test.html
Traceback (most recent call last):
  File "/opt/conda/bin/create_report", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.7/site-packages/igv_reports/report.py", line 234, in main
    create_report(args)
  File "/opt/conda/lib/python3.7/site-packages/igv_reports/report.py", line 87, in create_report
    data = fasta.get_data(args.fasta, region)
  File "/opt/conda/lib/python3.7/site-packages/igv_reports/fasta.py", line 21, in get_data
    fasta = pysam.FastaFile(fasta_file)
  File "pysam/libcfaidx.pyx", line 123, in pysam.libcfaidx.FastaFile.__cinit__
  File "pysam/libcfaidx.pyx", line 155, in pysam.libcfaidx.FastaFile._open
OSError: file `https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa` not found

root@342a8774e36b:/# ls -l /examples/variants/variants.vcf.gz
-rw-r--r-- 1 root root 7329 Jun 15  2020 /examples/variants/variants.vcf.gz

root@342a8774e36b:/# pip freeze
certifi==2020.12.5
chardet==4.0.0
idna==2.10
igv-reports==1.0.1
intervaltree==3.1.0
pysam==0.15.3
requests==2.25.1
sortedcontainers==2.3.0
urllib3==1.26.3

@stevekm OK I will look into it.    The examples should work of course, but as a workaround you can download that fasta and reference it as a local file.

Yes I tried that. The issue is that I want to be able to include a test script like this with my container builds in order to test that its working, in which case its very helpful to be able to load  the reference genome from the URL as shown. Hope there's a solution possible :)

@stevekm I will try to get to this next week,  this is not a very active project compared to IGV and igv.js, plus its a different language (python),  I will have to clear some time.   However I do recall trying to reproduce this before without success.  I do not us Docker,  I don't know what affect that would have but its the common thread between the OP and your report.

on a side note, I found out that my conda installation in those Dockerfiles was slightly wrong, it should be this;
RUN conda install python=3.6.5 bioconda::pysam==0.15.3

to avoid the error described here where upgrading the base Python version breaks conda; https://stackoverflow.com/questions/19825250/after-anaconda-installation-conda-command-fails-with-importerror-no-module-na
this does not change the error with pysam seen here but does get in the way of trying to debug it

@stevekm I just pushed 1.0.2, in response to an earlier report from you that the PIP package was not in sync with github.  There is some possibility, albeit slight, that this might resolve this issue.

Looking at the stack track the error is in pysam, which is trying to open the URL as a local file
File "pysam/libcfaidx.pyx", line 155, in pysam.libcfaidx.FastaFile._open
OSError: file `https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa` not found

Which in turn indicates an error in the htslib "isremote" function.   I do not know why you would see this error,  I do not see it with a clean pip install, but it has something to do with the pysam dependency.

Per notes above, this error was not reproducible but could have been caused by incorrect or out-of-date files pushed to pypi as part of release 1.0.1.

I ran into the same error with a Singularity image of igv-reports, with additional error information:
$ singularity exec -B $PWD singularity/igv-reports-1.0.4.sif create_report igv-reports/examples/variants/variants.vcf.gz https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa
[E::easy_errno] Libcurl reported error 77 (Problem with the SSL CA cert (path? access rights?))
[E::fai_load3_core] Failed to open FASTA index https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa.fai: Input/output error

Traceback (most recent call last):
  File "/usr/local/bin/create_report", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/dist-packages/igv_reports/report.py", line 271, in main
    create_report(args)
  File "/usr/local/lib/python3.9/dist-packages/igv_reports/report.py", line 105, in create_report
    data = fasta.get_data(args.fasta, region)
  File "/usr/local/lib/python3.9/dist-packages/igv_reports/fasta.py", line 21, in get_data
    fasta = pysam.FastaFile(fasta_file)
  File "pysam/libcfaidx.pyx", line 123, in pysam.libcfaidx.FastaFile.__cinit__
  File "pysam/libcfaidx.pyx", line 183, in pysam.libcfaidx.FastaFile._open
OSError: error when opening file `https://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa`

I'm using pysam 0.18.0

This looks like a libcurl bug affecting SSL certificates, there is nothing wrong with the certificate for that file.   A workaround is to use an http url (instead of https).   Specifically
http://s3.amazonaws.com/igv.broadinstitute.org/genomes/seq/hg38/hg38.fa
I don't know anything about singularity, but here is a Colab notebook with that example (working).   I will update the readme to use http:
https://colab.research.google.com/drive/1JJvyDm0r_Lyhmuk27zEwfkE0J1gV0wzp?usp=sharing

Thank you, this workaround solved my issue.


Cannot find the gradient handler example

📚 The doc issue
We provide a runnable example to demonstrate the use of gradient handler. In this example, we used DataParallelGradientHandler instead of PyTorch DistributedDataParallel for data parallel training.
The example of using customized gradient handler is not found and the url in the doc is 404

Hi @DarrenYing Thank you for your feedback. We will fix it soon.
By the way, we are restructuring the documents and examples, and the new version examples will be provided at the following link
https://github.com/hpcaitech/ColossalAI/tree/main/examples


django 3 compatibility

https://github.com/andreynovikov/django-rated-reviews/blob/3c99b8cd92a3b70c80d490d701211f8db93fd8f9/reviews/signals.py#L6
cases warning
  /usr/local/lib/python3.8/site-packages/reviews/signals.py:6: RemovedInDjango40Warning: The providing_args argument is deprecated. As it is purely documentational, it has no replacement. If you rely on this argument as documentation, you can move the text to a code comment or docstring.
    review_was_posted = Signal(providing_args=["review", "request"])

https://github.com/andreynovikov/django-rated-reviews/blob/3c99b8cd92a3b70c80d490d701211f8db93fd8f9/reviews/urls.py#L7-L11
cases warnings
  /usr/local/lib/python3.8/site-packages/reviews/urls.py:8: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
    url(r'^post/$', post_review, name='post-review'),

Have added Django 3 compatibility


Latest Chrome cookie not loading

 CRITICAL | Traceback (most recent call last):
  File "main.py", line 321, in <module>
  File "asyncio\runners.py", line 44, in run
  File "asyncio\base_events.py", line 649, in run_until_complete
  File "main.py", line 211, in main
  File "browser_cookie3\__init__.py", line 897, in load
  File "browser_cookie3\__init__.py", line 840, in chrome
  File "browser_cookie3\__init__.py", line 430, in __init__
  File "browser_cookie3\__init__.py", line 229, in __init__
  File "browser_cookie3\__init__.py", line 290, in __add_key_and_cookie_file
  File "browser_cookie3\__init__.py", line 45, in create_local_copy
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\user\\AppData\\Roaming\\..\\Local\\Google\\Chrome\\User Data\\Default\\Network\\Cookies'

Caused by: https://github.com/borisbabic/browser_cookie3/issues/180

The guys in this repository seem to have found a temporary solution. I have encountered this problem too, it occurs if Google Chrome is open while the script is running. As an option, you can close it. Or you can open it when the script has started the download process (after receiving all links from the archive).
Alternatively, do not use cookies by specifying the appropriate flag in the config file.

https://github.com/borisbabic/browser_cookie3/issues/180#issuecomment-1587691954


Support TeX (like texlab)

Hi there,
I think LaTeX is not yet supported by navigator.lua. Any plans to support that would be highly appreciated. I found this in nvim-lspconfig but I'm unfortunately unfamiliar with neovim/lua development: https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/texlab.lua
Any chance this feature might be available in the near future?

Basically, we just need to add the server names to the list.
What would you like to do?
https://github.com/ray-x/navigator.lua/blob/db09db7ef39966b9c1403ac0d439fadb4b1422e0/lua/navigator/lspclient/clients.lua#L264-L270

If you already have texlab installed. Add texlab in servers would auto-config the texlab.
But I have never used tex before. Also, I am not sure if the reference/definition/signature works the same way for tex compared to other lsp servers.

It works fine, at least for me. You might be able to close this issue.

Great, didn't know it was that easy 😃 thanks for the quick responses.


MNT: Pin pyvista

PyVista released 0.27.0 recently and some adjustments seem necessary to fix:
mne/tests/test_report.py::test_render_add_sections[pyvista] Traceback (most recent call last):

  File "/home/travis/virtualenv/python3.8.1/lib/python3.8/site-packages/pyvistaqt/plotting.py", line 699, in _close

    super().close()

  File "/home/travis/virtualenv/python3.8.1/lib/python3.8/site-packages/pyvistaqt/plotting.py", line 476, in close

    BasePlotter.close(self)

  File "/home/travis/virtualenv/python3.8.1/lib/python3.8/site-packages/pyvista/plotting/plotting.py", line 2739, in close

    if self.iren is not None:

  File "/home/travis/virtualenv/python3.8.1/lib/python3.8/site-packages/vtkmodules/qt/QVTKRenderWindowInteractor.py", line 335, in __getattr__

    raise AttributeError(self.__class__.__name__ +

AttributeError: BackgroundPlotter has no attribute named iren

While I work on a fix, I suggest pinning PyVista to a previous version.

I work on a fix in https://github.com/mne-tools/mne-python/pull/8495

Thanks @GuillaumeFavelier


using phpspec/prophecy for mocking

see https://samsonasik.wordpress.com/2015/08/29/testing-zend-framework-2-factory-using-prophecy/ . I think it can simplify the tests ;)

Sure!

@acelaya ok, I created #139 for it. The tests that still need to be updated is tests for Application\Module and LearnZF2I18n\Module .

prophecy for Application\Module tests has been implemented. now need to implement LearnZF2I18n\Module tests to be prophesized, @acelaya could you help? Thanks ^^

Yes, I'll try to do it this afternoon ;-)
--
Alejandro Celaya Alastrué
El 1/9/2015 0:34, "Abdul Malik Ikhsan"<EMAIL_ADDRESS>escribió:

prophecy for Application\Module tests has been implemented. now need to
implement LearnZF2I18n\Module tests to be prophesized, @acelaya
https://github.com/acelaya could you help? Thanks ^^
—
Reply to this email directly or view it on GitHub
https://github.com/sitrunlab/LearnZF2/issues/138#issuecomment-136518694.

Sorry, for the late answer. Been busy with life and the system. Will have a look at this tomorrow.

I'll porobably won't be finally able to do it until weekend
2015-09-03 21:05 GMT+02:00 Stanimir Dimitrov<EMAIL_ADDRESS>
Sorry, for the late answer. Been busy with life and the system. Will have
a look at this tomorrow.
—
Reply to this email directly or view it on GitHub
https://github.com/sitrunlab/LearnZF2/issues/138#issuecomment-137543832.

--
Alejandro Celaya Alastrué
http://www.alejandrocelaya.com

it's ok ;)

Just opened the pull request to implement this on the i18n module #140


Change instructions to use node's http-server instead of going into python land

http-server for node.js is very convenient, and is a lot faster than Python's SimpleHTTPServer. This is primarily because it uses asynchronous IO for concurrent handling of requests, instead of serialising requests.

🎶  it's a node world after all 🎶

Enjoy the ride! https://www.youtube.com/watch?v=iJFGAX77zw4

👍 Thanks!