Remove _strict_record_id

Instead of _strict_record_id, I think we switch from:
record_identifier = self._strict_record_id(record_identifier)

to:
record_identifier = record_identifier or self.record_identifier

Since this is what we're doing with pipeline_type

Or, maybe this is useful, since it provides an error handling -- in which case, maybe we should borrow this same idea for pipeline_type.
In that case, though, I think we should change the name. _strict_record_id doesn't really speak to me, and then forced_value is unintutive. I would suggest:
@property
def record_identifier(self, override: str = None) -> str:
        if override is not None:
            return override
        if self.record_identifier is not None:
            return self.record_identifier
        raise PipestatError(
            f"You must provide the record identifier you want to perform "
            f"the action on. Either in the {self.__class__.__name__} "
            f"constructor or as an argument to the method."
        )


create-platformatic should have a typescript template for "platformatic service"

Hi @mcollina, May I take this as my first PR?

sure thing!!!

Hi @mcollina, PR is merged onto the master. we can close this issue!


secretKey is triggering finding from GitHub Advanced Security and KICS scanning

Is your feature request related to a problem? Please describe.
The field secretKey is triggering a security finding from both GitHub Advanced Security and KICS scanning.

Also, see:
https://docs.kics.io/latest/secrets/#entropies
Describe the solution you'd like
If the field were named secretKeyName, it would not trigger these alerts.  I would like to change the field name.
I understand that you just can't change the field name without breaking everyone use the operator, but it would be great if there were an alias for the field name where you could use either field name.  I don't think you can specify an alias for a CRD field name, but you could introduce a new field named secretKeyName and then use the value of whichever field is specified (with preference to secretKeyName).  You could then schedule a deprecation of secretKey if you want to fully transition to the new name.

hi @RobCannon ! I'm pinging the other maintainers here, but I'm pretty sure this would go to our wont-do list 😅 - we already have way too many users to change our stable-ish APIs now.
@moolen @Skarlso @knelasevero @shuheiktgw @sebagomez @IdanAdar  FYI.

Hi.
Is there a reason you can't use an allowRules? Changing the whole API would be incredibly painful for existing users indeed. If we ever would to change it, I would use secretKeyValue as the Name is misleading to be a reference rather than an actual value. But even that doesn't really give it enough credit. It's the KEY in the secret that is being pushed. :) There is literally no better name for it. :D

My thought is that if you are already triggering vulnerability warnings in two different products, there are probably more that would flag this as a problem.  As a user, I now have to create exceptions in two different products and I don't even think there is a way to create exceptions in GitHub Advanced Security.
I don't understand why this would be named secretKeyValue instead of secretKeyName.  I am talking about secretKey in this structure.
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: database-user
spec:
  secretStoreRef:
    kind: SecretStore
    name: secret-store
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    name: database-user
  data:
    - secretKey: userName
      remoteRef:
        key: database-user
        property: userName
    - secretKey: password
      remoteRef:
        key: database-user
        property: password

That value is used to generate the key name when the secret is created, not the value;
apiVersion: v1
kind: Secret
metadata:
  name: database-user
data:
  userName: some-user
  password: super-secret

  - secretKey: userName
...

data:
  userName: some-user
  password: super-secret

Right. So you see it ended up as a key in a key value map. :) Hence the name SecretKey. :)
Regardless, even if we do a deprecation notice, the key will remain there for several months. :)

It doesn't even need to be deprecated.  Just having two names for the same value would be enough to resolve this issue.

How... would that resolve it? 🤔 It would still be part of the API and of the things it requires.

The scanning is done on source code.  If my source looks like this (changing secretKey to secretKeyName), it does not trigger a finding in either KICS or GitHub Advanced Security.
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: database-user
spec:
  secretStoreRef:
    kind: SecretStore
    name: secret-store
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    name: database-user
  data:
    - secretKeyName: userName
      remoteRef:
        key: database-user
        property: userName
    - secretKeyName: password
      remoteRef:
        key: database-user
        property: password

Oh you mean the output? Sorry, for some reason I was under the impression it's in OUR source code. :D My apologies.
Okay, so... Could you please describe how this is working where it is running and why is your generated yaml in source code? Is it a Gitops repository?

This is a GitOps repository.  We use ArgoCD for managing our k8s deployments and everything is stored in GitHub (typically as Helm charts).  As part of the PR process, we scan pull requests with KICS.  GitHub Advanced Secuirty is also looking for secrets in the code (but it does not replace much of what KICS does).
Ironically, we are using ExternalSecrets so developers will not try to store secrets in source code, but it is getting flagged as secret based on that attribute name.

Interesting. Okay, so this pr of mine: https://github.com/external-secrets/external-secrets/pull/2862 will make that key optional. Once that is rolled out, we can add in an alias which we can then internally resolve to secretKey.
After than, maybe we can start to migrate to using secretKeyName and maybe deprecate it. But that's gonna take some time.

Thank you!

@gusfcarvalho Does that sounds reasonable?

my only problem with that is that 'secretKey' does not match that regular expression, and probably is only caught due to entropy configuration. How are we sure that 'secretKeyName' will not get caught, or if this would persist if the entropy is increased by an arbirary value? I don't want to set the expectation that, if the entropy engine changes, we are going to change from 'scretKeyName' to 'anotherWordSoThatEntropyIsLowAndUnrelatedToCeKrets'
(or maybe I'm way too weak on regex these days)

I understand to go over false alerts is PITA, but I find it hard to envision a project which would comply to all security tooling out there 😞. As I personally don't really see the benefit to fix this for KICKS (and break it for KOCKS or any other tool out there), I'm still in favor to not implement it 😅
But that's why we have many maintainers , and maybe this problem  generally affects the community instead of a specific use case😄
@moolen  @knelasevero @sebagomez  @IdanAdar  thoughts?

(last comment, if we do it, maybe we want to have something like this, as it would solve  some issues with new users figuring out what's secretKey, remoteRef.Key, and prepare ourselves if we decide to implement the community ask to support multiple Secrets on a single ES)
data:
- localRef:
     key: foo #old secretKey
   remoteRef:
     key: bar # remoteRef.key as it is today

I'm sort of against this too. Like I said, it's a major disruption and I'm still unsure how it's flagged or why. I'll have to read much more into this security tool thing to understand where they are coming from.

+1 against, we shouldn't fix false positives here, it should be fixed upstream

I confirmed that secretKeyName did not trigger a security finding for GAS or KICS.  key would not either, because it is already passing conformance checks when used on the remoteRef.
Again, I argue that since this project's purpose is part of implementing security best-practices, it shouldn't trigger alerts when used with a tool that is built to validate best-practices.
I think having two fields to specify the same value is not a major disruption, but I am not very familiar with the codebase.  The logic could be as simple as: If key (or secretKeyName) is specified, copy that value into secretKey and everything else stays the same.
Thank you for your consideration.

I confirmed that secretKeyName did not trigger a security finding for GAS or KICS. key would not either, because it is already passing conformance checks when used on the remoteRef.

The problem is that it works for one specific KICKS configuration in a particular version, and for one particular configuration of GAS. If these false alerts start to appear in the near future after we implemented secretKeyName (because they decided to use a better entropy mechanism, or found a bug on the entropy calculation, or just decided to be straightforward more strict), what it is that you would expect to be conducted here? Renaming it to a third name? I just want to set the expectation that we are not going to drive our CRD development based on third party tools. This is coupling, and it is a bad practice (security included).
Is there a reason why can't you add a conformance check on secretKey when used on spec.data blocks? It is pretty much the same effort you needed to do for spec.data.remoteRef.key.

Also related, we can contribute a PR in here to add exceptions to ExternalSecrets secretKey, by creating a regexp that parses the kind: ExternalSecret.

+1 against (-1 🙂). If there is a way to make this an exception over those scanners, people should go for that.
I don't think having a name that won't trigger any scanner "best security practice" per se. As @gusfcarvalho mentioned, we would be chasing our own tail with no guarantees this would not happen again. API design is hard, deprecating fields is bad for the project and for our users.
I would personally only revisit this if we have enough people asking for it, but for now, against as well.

with that we have majority votes here against it, so I'm labeling this issue with a wontfix for now.
@RobCannon if you can't add secretKey to pass conformance checks, and you absolutely need to avoid these false alerts, what I suggest you to do to is to leverage dataFrom as opposed to data. With dataFrom spec, you don't specify a secretKey. You can then filter what key you specifically want with templates, if you cannot import all secret manifest to a given key.


Feature Request: Method to Create StreamingSoundData from Symphonia MediaSource

There are some (admittedly rare) cases where making a Cursor out of sound data isn't practical, while implementing Read+Seek and a few helper methods is (my particular use case is rewriting the Minecraft sound system, where I use callbacks to access a Java BufferedInputStream from Rust and implement Read+Seek on it)

I'm not doubting you, but why can't you make a Cursor out of the sound data?

I'm wrapping a Java InputStream object over FFI and it's a lot simpler to implement Seek+Read on it.

I'd like this too. I pack all my assets into one large file, and this would enable me to stream music directly from that file.
Creating Cursor requires all data to be loaded in memory first.

Added StaticSoundData::from_media_source and StreamingSoundData::from_media_source in v0.8.1. @The-Minecraft-Scientist @vdrn let me know if you need versions of those functions that take Box<dyn MediaSource>.


Gilneas

Implement the entire Gilneas faction from the live vJASS version of the map, including:

Any Quests
Any spells
Any mechanics

Hi @Sharkmike, I'm unassigning this for now since it's been a while and we need to get it started. Please reassign yourself if you find some time and pick it up!

I could take a stab at this.
I don't know if I am capable of implementing everything by myself but I think I can do enough to contribute something of value.

circle is castle, X is doodad (so not player controlled)


Cosmos: Native Wallet Support

As a user, I want to be able to use Cosmos and Osmosis on ShapeShift native.
Users can send, receive, stake (delegate), unstake (undelegate), and get reward on Native Wallet

reopening under hdwallet https://github.com/shapeshift/hdwallet/issues/415


[ISSUE] zeebeGateway incorrect rest ingress path

Describe the issue:
In the latest Helm chart release for Zeebe Gateway, the ingress.rest.path is unintentionally configured to include the readiness probe path actuator/health/readiness. This issue causes the readiness probe path to be exposed as part of the main ingress endpoint, which interferes with the intended REST API access at the specified ingress.rest.path (e.g., /zeebe).

Actual behavior:
The current configuration in the Helm chart generates the following path in the ingress:
/zeebe/actuator/health/readiness
This behavior differs from previous releases and results in the readiness probe being part of the main ingress endpoint, breaking external access to the REST API.

Expected behavior:
The ingress path should expose only the primary service path defined by zeebeGateway.ingress.rest.path, such as /zeebe, without appending the readiness probe endpoint. The readiness probe /actuator/health/readiness should be accessible internally for Kubernetes health checks only.

How to reproduce:

Logs:

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform:
Helm CLI version:
Chart version:
Values file:

https://jira.camunda.com/browse/SUPPORT-24246
https://jira.camunda.com/browse/SUPPORT-24281


Mingw cross compilation error

I'm working on cross compiling hiredis on linux to windows with mingw, and found that in sockcompat.h:53, mingw will fail compilation due to Mstcpip.h not being found
Simply changing this to mstcpip.h, compilation succeeds on the master branch without issue.
I didn't want to create a pull request for this change before creating an issue, because I'm not sure if this would affect anything else.
I'm assuming that given windows doesn't care about case for file names that this would not be a problem, but I don't have a development environment for windows to test this out.

Feel free to open a PR and I'll authorize a CI run.
As you said, it's probably fine as Windows is case-insensitive when it comes to filenames.

It's such a small change I doubt it would be an issue, but just wanted to check first
Thanks for the quick response! Give me a few and I'll make the pr


Chatterino Window unresponsive

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
I have restarted, cleared the cache file, tried older and newer builds, and have done multiple clean installs in an attempt to fix the problem to no avail.
My chatterino program opens and I am able to view chat but I am unable to use any mod icons and the title bar is almost completely unresponsive to me. The window also looks odd as if enlarged, I've tried zooming out and changing settings in properties and it didn't fix the issue.
What I am able to do:
see current active chat
add a new tab
change account
type in chat
what I cannot do:
close/minimize the window via title bar
click the settings icon
toggle moderator view
add a side chat
moderation actions
Screenshots
No response
OS and Chatterino Version
Chaterino 2.3.4 on Windows 10

I'm not able to screen record but here are the screenshots. Its hard to tell in the images but compared to how it used to look, its very enlarged

first of, check with latest build https://github.com/Chatterino/chatterino2/releases/download/nightly-build/chatterino-windows-x86-64.zip It will also shows as 2.3.4 version but its 50 updates above what you are using.

but it's 50 updates above of what you are using.

192*

I uninstalled the previous version and ran the new one after a restart. same result

Closing this issue for now - if this still happens with the latest nightly version please re-open this issue


SqlBulkCopy crashes instead of inserting default values with option KeepNulls off.

Describe the bug
When inserting records via SqlBulkCopy without the KeepNulls option enabled into a table with a non-nullable column with a default value constraint that is mapped to a C# property containing null values, SqlBulkCopy crashes. The docs say: KeepNulls [...] When not specified, null values are replaced by default values where applicable.
The following exception occurs.
Unhandled exception. System.InvalidOperationException: Column 'SomeValue' does not allow DBNull.Value.
   at Microsoft.Data.SqlClient.SqlBulkCopy.ConvertValue(Object value, _SqlMetaData metadata, Boolean isNull, Boolean& isSqlType, Boolean& coercedToDataFeed)
   at Microsoft.Data.SqlClient.SqlBulkCopy.ReadWriteColumnValueAsync(Int32 col)
   at Microsoft.Data.SqlClient.SqlBulkCopy.CopyColumnsAsync(Int32 col, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.CopyRowsAsync(Int32 rowsSoFar, Int32 totalRows, CancellationToken cts, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.CopyBatchesAsyncContinued(BulkCopySimpleResultSet internalResults, String updateBulkCommandText, CancellationToken cts, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.CopyBatchesAsync(BulkCopySimpleResultSet internalResults, String updateBulkCommandText, CancellationToken cts, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteToServerInternalRestContinuedAsync(BulkCopySimpleResultSet internalResults, CancellationToken cts, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteToServerInternalRestAsync(CancellationToken cts, TaskCompletionSource`1 source)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteToServerInternalAsync(CancellationToken ctoken)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteRowSourceToServerAsync(Int32 columnCount, CancellationToken ctoken)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteToServer(DataTable table, DataRowState rowState)
   at Microsoft.Data.SqlClient.SqlBulkCopy.WriteToServer(DataTable table)
   at <Program>$.<Main>$(String[] args) in C:\Users\nerbonne.PCA2018\source\repos\SqlBulkCopyBug\SqlBulkCopyBug\Program.cs:line 27

To reproduce
Single-file program:
using System;
using System.Data;
using System.Transactions;
using Microsoft.Data.SqlClient;

using var transaction = new CommittableTransaction();
var connectionString = Environment.GetEnvironmentVariable("CONNECTION_STRING") ??
                       @"Server = (localdb)\MSSQLLocalDB; Integrated Security = true";
using var connection = new SqlConnection(connectionString);
connection.Open();
connection.EnlistTransaction(transaction);

using var createTable = new SqlCommand
{
    Connection = connection,
    CommandText = @"create table Demo ( SomeValue int not null constraint SomeDefault default (1))"
};
createTable.ExecuteNonQuery();

using var bulkcopy = new SqlBulkCopy(connection) { DestinationTableName = "Demo" };
using var datatable = new DataTable();
datatable.Columns.Add("SomeInput", typeof(int));
datatable.Rows.Add(42);

datatable.Rows.Add(default(int?)); //works fine without this row

bulkcopy.WriteToServer(datatable); // crashes here

transaction.Rollback();

Project file:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net5.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Data.SqlClient" Version="3.0.0" />
  </ItemGroup>

</Project>

Expected behavior
The bulk copy completes without crash (i.e. the table contains 42 and 1 right thereafter)
Further technical details
Microsoft.Data.SqlClient version: via nuget 3.0.0
.NET target: appears irrelevant, but repro runs on .net 5.0
SQL Server version: appears irrelevant, but this repro runs with sql server 2019 LocalDB
Operating system: appears irrelevant, but this repreo runs on Windows 10 21H1
Additional context
The crash also occurs for other overloads of WriteToServer and with various other SqlBulkCopyOptions, as long as KeepNulls is off and the column is non-nullable.  A possible workaround could be to mark the columns nullable, but this isn't always possible (e.g. for primary keys with next value for defaults), and even where possible, the impact on the data model isn't ideal.

@EamonNerbonne I will look into this and will update you soon.
Thanks.

@EamonNerbonne  as you have mentioned inserting a nullable variable to a NOT NULL column is not permitted.
If you change
datatable.Rows.Add(default(int?)); //works fine without this row

to
datatable.Rows.Add(default(int)); //works fine without this row

it should be working fine.

However, that inserts the wrong value.
If I change the repro to this, perhaps its clearer:
using System;
using System.Data;
using System.Transactions;
using Microsoft.Data.SqlClient;

using var transaction = new CommittableTransaction();
var connectionString = Environment.GetEnvironmentVariable("CONNECTION_STRING") ??
    @"Server = (localdb)\MSSQLLocalDB; Integrated Security = true";
using var connection = new SqlConnection(connectionString);
connection.Open();
connection.EnlistTransaction(transaction);

var colType = "int not null";
//var colType =  "int null"; //wrong datamodel; but does print "1"

var createTableSql = $"create table Demo ( SomeValue {colType} constraint SomeDefault default (1))";
using var createTable = new SqlCommand { Connection = connection, CommandText = createTableSql };
createTable.ExecuteNonQuery();

using var bulkcopy = new SqlBulkCopy(connection) { DestinationTableName = "Demo" };
using var datatable = new DataTable();
datatable.Columns.Add("SomeInput", typeof(int));
datatable.Rows.Add(default(int?));
//datatable.Rows.Add(default(int)); //alternative that does not throw but prints wrong output: "0"

bulkcopy.WriteToServer(datatable); // crashes here

var selectSql = @"select SomeValue from Demo";
using var selectValue = new SqlCommand { Connection = connection, CommandText = selectSql };
var insertedValue = (int)selectValue.ExecuteScalar();
Console.WriteLine(insertedValue);

transaction.Rollback();

To avoid the  crash there are two alternatives:

Using a nullable column for a non-nullable value allows for KeepNulls off to work as described in the docs, but nullable columns cannot be e.g. part of a primary key, an in any case it's a misleading datamodel which may have consequences on things like query plans.
inserting 0 does not crash, but that ignores the default value constraint; which kind of defeats the purpose.

The real-life usecase where this matters is to insert a non-stable value; i.e. for constraints that provide defaults like sysdatetime() or next value for MySequence.

I see. When the field in the database is set to NOT NULL and is defined as DEFAULT CONSTRAINT  there would be to possibilities:

Pass the value in this case the database will not pick the default value, if this is the case it can never set to DBNull.Value.
Do not pass the value to the database and the default will be picked up. This could be achieved either by defining
1.   Do not define the value in the data table you are passing to BulkCopy
2. If the field is in the source define ColumnMappings collections, so that you can leave that field out.

In simpler words, such data should never be added to the source when database is set to NOT NULL and is defined as DEFAULT CONSTRAINT

Yeah, there are workarounds (but nothing trivial), especially if data is partially default, and partially not.  The behavior the  docs seem to imply would be ideal: KeepNulls [...] When not specified, null values are replaced by default values where applicable. - and that actually works, as long as the target is nullable.

The docs are talking about sql NULL and as far as I've seen there is no understanding of Nullable in this library  because most of the code predates that capability. Just don't use nallables and make sure you use DBNull.Value where you might mean NULL.

DBNull.Value has the same behavior as C# null, here. However, it sounds like the behaviour is by design? The docs don't make that clear, and it does not appear to be an sql-server limitation as the bcp utility does support non-KeepNulls behavior inserting mixed null/non-null input into a non-null target column with a default value.
This is simple to try by following the bcp example: https://docs.microsoft.com/en-us/sql/relational-databases/import-export/keep-nulls-or-use-default-values-during-bulk-import-sql-server?view=sql-server-ver15#sample-table but using a non-nullable target column:
CREATE DATABASE TestDatabase;
GO

USE TestDatabase;
CREATE TABLE dbo.myNulls (
   PersonID smallint not null,
   FirstName varchar(25),
   LastName varchar(30),
   Kids varchar(13) not null DEFAULT 'Default Value',
   BirthDate date
   );

with the provided sample content:
1,Anthony,Grosse,Yes,1980-02-23
2,Alica,Fatnowna,No,1963-11-14
3,Stella,Rosenhain,,1992-03-02

And then inserted from the command line:
bcp TestDatabase.dbo.myNulls IN C:\Temp\myNulls.bcp -c -t, -T

(you'll need to quote the -t, if you're using powershell).
The resulting data contains the value Default Value in the kids column corresponding to PersonID 3, even though the target column is non-nullable.
However, if this isn't practically feasible using SqlBulkCopy, perhaps it would help to at least clarify the limitation in the docs, e.g. saying something like: When not specified, null values in the source are replaced by default values in the target when the target column has a default constraint and is nullable.

@EamonNerbonne I am going to test this against other drivers to see if the behavior is different.

Closing this issue due to inactivity, feel free to open back if it still an issue


Unable  to Authorize

Hi,
I  am  using  this  Addons  for  User  Account  Switcher ,  but  when  i  switching  user  its  giving  error  as  Forbidden  do  we  have  any  idea  what  was  issues

Hello.
Could you specify more details about your issue?

here is  the  Catelina.out  logs
ERROR [login.webscript.LoginSwitcherWebScript] [http-apr-8080-exec-11] User switching is failed due to an error :
{
"status" :
{
"code" : 403,
"name" : "Forbidden",
"description" : "Server understood the request but refused to fulfill it."
},
"message" : "01100004 Login failed",
"exception" : "org.springframework.extensions.webscripts.WebScriptException - 01100004 Login failed",
"callstack" :
[
""      ,"org.springframework.extensions.webscripts.WebScriptException: 01100004 Login failed"

I  am  using  Alfresco  Community  version  5.1 ,  i  had  followed  the  same  steps  mentioned  in  doc

Thank you for your information. Unfortunately we didn't test in under alfresco 5.1. Target was 5.0. Anyway we will adapt it to work on latest version of alfresco.

Is this user account enabled?
We reproduced issue but only on disabled account

Right  now  its  disable,  do you  want  me  to  enable  Addons  to
alfresco  server
if  yes  please  let  me  know  ,  i  will  do  it
On Fri, Feb 12, 2016 at 3:34 PM, isushko<EMAIL_ADDRESS>wrote:

Is this user account enabled?
We reproduced issue but only on disabled account
—
Reply to this email directly or view it on GitHub
https://github.com/Aimprosoft/user-account-switcher/issues/1#issuecomment-183259034
.

--
Best Regards
VikashSingh
Bizrunttime ITServices

I asked about user account itself (ajit in you case). If user account disabled, you can't switch to it.

User  Account  ajit    is  enable  in  our  case,   i  tested  with  All
user  i  have  with  that  plugin  but non  of  work
is  is  possible  for  you  to  chat  on  skype  and  you  solve  our
issues  with  current  version
my  skype  id  is
vikash.bizruntime
On Fri, Feb 12, 2016 at 3:38 PM, isushko<EMAIL_ADDRESS>wrote:

I asked about user account itself (ajit in you case). If user account
disabled, you can't switch to it.
—
Reply to this email directly or view it on GitHub
https://github.com/Aimprosoft/user-account-switcher/issues/1#issuecomment-183259660
.

--
Best Regards
VikashSingh
Bizrunttime ITServices


Change all references to clientId and clientSecret to client.id, client.secret

Closing in favor of #203


[Style]The heading font color in About Us

What's the style idea?
We need to improve the font color of the headings in about us issue. It is not visible.
@Rakesh9100  I'm GSSOC'24 contributor, Can you please assign this to me?

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

i can solve the issue !!!, could you please assign

Please assign this task to me. And solved the problem.

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Additionally, could you please label it for the appropriate level? Thank you! 🚀

What exactly problem you are facing in this issue as it is properly visible on the website @Disha-Hati


If source is an array iterate through array

Currently the geoip filter takes either only one 1 IP or if its an array takes the first element into the array:
https://github.com/logstash-plugins/logstash-filter-geoip/blob/1d0c9c438ba3d767f7b7041fb3db90336299c062/lib/logstash/filters/geoip.rb#L44
  # The field containing the IP address or hostname to map via geoip. If
  # this field is an array, only the first value will be used.
  config :source, :validate => :string, :required => true

It would be useful if it encounters an array that it iterates through the array and creates something like:
geoip[0]
geoip[1]
etc..
for each IP address. Or whatever is defined in target.

May be applying a logic similar to the iterate_on option from the translate plugin would be nice.


ISPN-10534 SerializationContext ProtoStreamMarshaller.getSerializatio…

…nContext fails with unclear message

fix MarshallerUtil.getSerializationContext to distinguish between null marshaller and wrong type of marshaller

https://issues.jboss.org/browse/ISPN-10534

This is a minor one @ryanemerson .  Let's help a poor, confused, user have a clearer feeling of contrition and regret.

and here is the backport  https://github.com/infinispan/infinispan/pull/7242


GET /billings

Path: /billings
Method: GET
Auth: member
Query:

after={Date} billings emitted after this date
before={Date} billings emitted before this date
value-greater-than={Number} billings with value greather than Number
value-less-than={Number} billings with value less than Number
employer={String} billings registered for this Employer (CompanyRep.name = String)

Response:
[{
  status: {
    proForma: Boolean,
    invoice: Boolean,
    receipt: Boolean,
    payed: Boolean
  },
  employer: CompanyRep,
  value: Number, // €
  invoiceNumber: String,
  emission: Date,
  notes: String
}]

Notes:
Should return all billings by default.
Status codes:

Code
Rule

400
Bad query

200
Always

Tests:

No query

Should return all billings

Before on query

Should return all billings that were emitted before this date

After on query

Should return all billings that were emitted after this date

Value-greater-than on query

Should return all billings with value greater than this number

Value-less-than on query

Should return all billings with value less than this number

Employer on query

Should return all billings registered for this employer.

Bad query

Bad before/bad after: status code 404 on bad date format.
value-greater-than is less than value-less-than: status code 400.
All the others: return empty array.

Add a filter for Companies, that might be useful.
Billings have an ID field.


Define handler as async def in mlrun_footer

ML-4421

Will take care of it in nuclio instead – https://github.com/nuclio/nuclio/pull/3094.
Pretty sure mlrun_footer should really be in mlrun, though.


added -notmatch "kind-windows-amd64.sha256sum"

added -notmatch "kind-windows-amd64.sha256sum"  to kindDownloadLink assignment command
Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@adityajalkhare could you get this PR out of draft so we can test it and merge if everything is ok?

@miketimofeev this seems to be already fixed in https://github.com/actions/virtual-environments/pull/5217

@miketimofeev, I was about to publish it then saw someone else had submitted and merged changes. Hence closing the PR.
Thanks :)


More Documentation on how to use properly

Hi,
I just started to try and use this because it sounds awesome but the first thing I wanted to do, I couldn't make happen because I have no idea how we're suposed to even do it.
Which is why I'm suggesting the how to section of your readme could be updated a little.
I was mainly looking into starting specific debugging session using workbench.action.debug.selectandstart but it still ask for which I want to start. That makes it pretty useless. I get that I should probably add the json and the argument but I've tried a few things and none seems to do anything at all.
How do we find the JSON arguments for the different commands, if there is any. Is that documented somewhere?

Hey,
There's no friendly documentation about those commands except for the extension API.
Here's what I do, I go to the official repository and search for the "command id", then I try to look for the arguments.
There's not much I can do here.
If you think that adding these suggestions may help, I will gladly add this to our README.
Best regards,
Nicollas R.

I may consider adding this as a feature in the next release.

I have searched for it but have found nothing special. Are you search the vscode repository or something else?
this one in particular is mentioned only in tutorial startup and stuff like that. Are these in another repository just for the extension?
Have you ever done that with your stream deck? maybe another way to do it?

Hey,
I've looked in the documentation and the source code and couldn't find a way to do this. However, I could implement it through extension API.
I'm going to keep this open as a reminder.

I, too, am looking to send arguments to the workbench.action.debug.start command, namely nameOrConfiguration as specified here
https://github.com/microsoft/vscode/blob/0c4fa8a7b5f8ef2b59663b20d79df7776a697609/src/vs/vscode.d.ts#L8326
But I am unclear how to specify it, and would appreciate some documentation. This did not work.
{ nameOrConfiguration: 'dev' }

I've worked out how to get this to run a debug config saved in your launch.json.
Here's my launch.json for a Flask app:
{
  "version": "0.2.0",
  "configurations": [

    {
      "name": "Flask - Dev",
      "type": "python",
      "request": "launch",
      "module": "flask",
      "env": {
        "FLASK_APP": "wsgi.py",
        "FLASK_ENV": "development",
        "FLASK_DEBUG": "1",
        "TEMPLATES_AUTO_RELOAD": "true",
      },
      "args": ["run"],
      "jinja": true,
      "justMyCode": true,
    }
  ]
}

In the Stream Deck software, create an Execute Command button:
Command (ID): workbench.action.debug.start
Arguments (JSON): "args": {"name": "Flask - Dev"}
The name should just be equal to the name you've configured in your launch.json - in my case Flask - Dev
I've spent a long time figuring out a lot of functionality, so have some useful tips I can share - will do a pull request with @nicollasricas permission for enhanced documentation

I, too, am looking to send arguments to the workbench.action.debug.start command, namely nameOrConfiguration as specified here
https://github.com/microsoft/vscode/blob/0c4fa8a7b5f8ef2b59663b20d79df7776a697609/src/vs/vscode.d.ts#L8326
But I am unclear how to specify it, and would appreciate some documentation. This did not work.
{ nameOrConfiguration: 'dev' }

Sorry that I've missed your comment notification.
The link you have sent is from the extension API, so calling as a command won't work.
It appears that @cording12  have answered already.

I've worked out how to get this to run a debug config saved in your launch.json.
Here's my launch.json for a Flask app:
{
  "version": "0.2.0",
  "configurations": [

    {
      "name": "Flask - Dev",
      "type": "python",
      "request": "launch",
      "module": "flask",
      "env": {
        "FLASK_APP": "wsgi.py",
        "FLASK_ENV": "development",
        "FLASK_DEBUG": "1",
        "TEMPLATES_AUTO_RELOAD": "true",
      },
      "args": ["run"],
      "jinja": true,
      "justMyCode": true,
    }
  ]
}

In the Stream Deck software, create an Execute Command button:
Command (ID): workbench.action.debug.start Arguments (JSON): "args": {"name": "Flask - Dev"}
The name should just be equal to the name you've configured in your launch.json - in my case Flask - Dev
I've spent a long time figuring out a lot of functionality, so have some useful tips I can share - will do a pull request with @nicollasricas permission for enhanced documentation

Hey,
Thanks for figure this out.
I will gladly merge the pull request.
For those who ends up here and were wondering about the lack of documentation, I'm currently rewriting the whole project in my spare time to support multiple decks in the same codebase.
My main deck right now is Loupedeck (it was given to me by Loupedeck, thanks Emil) since my Stream Deck broke, and I don't plan to buy a new one right now (too expensive where I live). I'm still going to support it, but the testing will be slow as I'm using a friend's spare time to test it.
There's no right way of sending the arguments for every command, it depends on how it was implemented, and it will require a bit of research.
I think we could create something like an index for these commands that are not available as an exclusive action or exposed through the API.

Keeping this open for later closing in the next days when I start to push the commits from my local NAS.

I've worked out how to get this to run a debug config saved in your launch.json.
In the Stream Deck software, create an Execute Command button:
Command (ID): workbench.action.debug.start Arguments (JSON): "args": {"name": "Flask - Dev"}
The name should just be equal to the name you've configured in your launch.json - in my case Flask - Dev

Have you tried this with multiple debug configurations? I have 4 debug configurations in my launch.json and this just launches the last configuration used, not the one specified via arguments.

Thanks for the feedback @SierraJC - you are absolutely right, I'm seeing that behaviour too and didn't realise it due to having a single config in my launch.json.
I've done some reading and found this is a VS Code issue that would require further development of the Stream Deck VS Code extension to add such functionality to the Stream Deck buttons.
There is a workaround, albeit not ideal - you can put the entire launch config in the Stream Deck button instead. For my config above,  I created an Execute Command button with the below:
Command (ID): debug.startFromConfig

Arguments(JSON):  {
      "name": "Flask - Dev",
      "type": "python",
      "request": "launch",
      "module": "flask",
      "env": {
        "FLASK_APP": "wsgi.py",
        "FLASK_ENV": "development",
        "FLASK_DEBUG": "1",
        "TEMPLATES_AUTO_RELOAD": "true"
      },
      "args": ["run"],
      "jinja": true,
      "justMyCode": true
    }

This works alongside other buttons, for example, I've made a second button for npm run dev:
Command (ID): debug.startFromConfig

Arguments(JSON):
{
      "command": "npm run dev",
      "name": "NPM Dev",
      "request": "launch",
      "type": "node-terminal"
}

In the same vain, how to run a task? I have tried all possible combinations i.e.
commanadId: workbench.action.tasks.runTask and then as Arguments:
mytask

"mytask"

{"label":"mytask"}

{"taskName":"mytask"}

I probably forgot some variations.

I second/third/fourth this. I just got the stream deck and use VSCode semi regularly for a variety of projects. However, even the 'create terminal' event I have no idea what to put in any of the options. Some getting started docs would be very helpful :)

I second/third/fourth this. I just got the stream deck and use VSCode semi regularly for a variety of projects. However, even the 'create terminal' event I have no idea what to put in any of the options. Some getting started docs would be very helpful :)

Same, I'm trying to do something as simple as running a task automatically and project seems dead with no documentation unfortunatly


TypeError [ERR_INVALID_CALLBACK]: Callback must be a function

[INFO] Starting...
[WARN] Can not load PM2 config, the file "/root/.pm2/conf.js" does not exist or empty, fallback to auto-load by pm2 home.
[WARN] Can not load PM2 config, the file "/root/.pm2/conf.js" does not exist or empty, fallback to auto-load by pm2 home.
fs.js:135
throw new ERR_INVALID_CALLBACK();
^
TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
at maybeCallback (fs.js:135:9)
at Object.writeFile (fs.js:1181:14)
at Object.fork (/usr/lib/node_modules/pm2-gui/lib/daemon.js:121:12)
at start (/usr/lib/node_modules/pm2-gui/lib/daemon.js:47:30)
at /usr/lib/node_modules/pm2-gui/node_modules/async/lib/async.js:718:13
at Immediate.iterate (/usr/lib/node_modules/pm2-gui/node_modules/async/lib/async.js:262:13)
at processImmediate (timers.js:632:19)
[WARN] ✘ stopped

Also getting this same problem from the latest npm version,
It launches if I install from the repo though:
npm install pm2-gui@https://github.com/Tjatse/pm2-gui.git -g

same problem

same

same


for better ux, use pointer only when the field is not required

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   80.57%   80.57%
=======================================
  Files           9        9
  Lines         175      175
=======================================
  Hits          141      141
  Misses         21       21
  Partials       13       13

Impacted Files
Coverage Δ

cvm/instance.go
66.66% <ø> (ø)
:arrow_up:

clb/lb.go
55.55% <ø> (ø)
:arrow_up:

clb/wait.go
76.47% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a770e...2fbda42. Read the comment docs.

LGTM, Merged


Seeker blinding in Hide and Seek doesn't account for other avatar sizes

See below:
https://github.com/user-attachments/assets/d0bf6990-c7f7-4cd0-88fe-196a9cf44014

Fixed in https://github.com/Lakatrazz/BONELAB-Fusion/commit/bf5a95137db2790f19f0c0b8c88b025d651cf7f0


[Bug]: Query parameters not respected?

What happened?
I am trying to fetch images according to some filtering parameters and it seems they are not respected.
I don't really understand the formatting, but it should be fine in theory
Steps to reproduce the problem
I try to fetch according to this query:
https://civitai.com/api/v1/images?nsfw=false&sort=Most+Reactions&period=Day&limit=20
What should have happened?
Here are the results of that query:

nsfw=false - not respected, it returns images with both true & false ❌
sort=Most+Reactions - didn't checked, but it's fine ✅
limit=20 - as expected, returns 20 results ✅
period=Day - not sure, today is the 22nd, there are images "createdAt": "2023-11-21T21:56:13.121Z" (it would make sense to display only according to the request, but then limit has to be respected as well ❓

TBH, I just want to be able to filter out nsfw content :)
Thanks! 🚀

I also noticed that nsfw=false seems to be broken, but you can get the desired results with nsfw=None

@2picus Right, this seems to filter out alien content 🤭
@Anyone feel free to close this, if this is the intended behavior, but there is a mismatch between the docs and the implementation.
Thanks


Bring deferred_stat_options out of the cluster_manager's condition

Please provide a description of this PR:
Earlier the deferred_stat_options were under the condition for cluster_manager. Now bringing it out of the condition.

Hi @Sandeep-Varma. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/ok-to-test

@Sandeep-Varma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
ce33d50a0cdbc44c26ebcb56f1c071e0223ee94e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes


error doing a general search from documentation

Hello,
i dowloaded and install PyScopus  as instructed, assigned a Scopus API key, but when i run the example provided below i get an error:
search_df = scopus.search("KEY(interdisciplinary collaboration)", count=20)
Traceback (most recent call last):
File "", line 1, in
File "...\lib\site-packages\pyscopus
copus.py", line 56, in search
result_df, total_count = search_scopus(self.apikey, query, type, view=view)
File "...\lib\site-packages\pyscopus\tils.py", line 388, in _search_scopus
total_count = int(js['search-results']['opensearch:totalResults'])
KeyError: 'search-results'

try ...
search_df = scopus.search("KEY(interdisciplinary collaboration)", count=20, view='STANDARD')

The same issue.

Including view='STANDARD' worked for me.


Request: Netmaker Plugin

Netmaker is a full-mesh wireguard overlay network that is an alternative to Zerotier or Tailscale. Netmaker uses kernel wireguard, so it is ~5x faster than either competitor. It is open-source without any node limits like zerotier has.
An author has posted in r/opnsensefirewall declaring compatibility with FreeBSD, so there might be interest in collaboration.
The plugin in OPNSense should be capable of operating as an:

"Netmaker Server" so there is no dependency on a third-party (or subjection to future node-limits)
"Ingress Gateway" allowing any generic wireguard client access to the overlay network,
"Egress Gateway" allowing overlay network nodes access to other LANs

Posting rules:

[✅ ] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[✅ ] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[ N/A] When the request is meant for an existing plugin, I've added its name to the title.

I already invested couple of hours in it, but the full mesh was a bit clumsy in my testing. Die you test it by yourself on Linux or similar?

Hi, one of the authors of Netmaker here. Just wanted to +1 this. We maintain a FreeBSD client and would love to see an OPNSense plugin for it.

Hi, one of the authors of Netmaker here. Just wanted to +1 this. We maintain a FreeBSD client and would love to see an OPNSense plugin for it.

Is there a guide on how to deploy this on OPNsense, especially for site-to-site WireGuard VPN?

We do not have a guide for deploying on OPNSense, just for freebsd in general: https://docs.netmaker.org/netclient.html#freebsd

But this is the client only, most of the users want to run the server on it

But this is the client only, most of the users want to run the server on it

I would love to be able to run a netmaker server on Opnsense :)

+1 Definitely want to

+1!

+1 million - Just discovered OPNSense and Netmaker (researching for special use case project), both blowing my mind and using one atop the other but not integrated. If I could configure netmaker (server and client) using OPNSense.......well let me put it this way, there would be a rubbish skip in the front of the office filled with equipment to go for recycling. So please for the love of god DOOOOOOOOOOO IT!
LOL

If anyone volunteers installing the netmaker Binary on it and starts testen I will build one

any progress here? I have never done a plugin, however I would be in ;)

I would love to see a client implementation as a plugin, especially the Egress Gateway function would be really helpful

But this is the client only, most of the users want to run the server on it

I would be very happy with the client to start with.

I'm trying to get Netmaker Client running on OPNsense. But the FreeBSD script fails. Tried to install manually but I fail (probably due to my lack of FreeBSD/OPNsense knowledge). Did anyone succeed to get the netmaker client running of OPNsense in any way? @afeiszli?
I'm happy to invest some time in this if someone more knowledgeable can give me a hand.

As a big OPNsense user and having a need for the Netmaker server to run on the OPNsense platform, I am going to give it a shot.
Reversing the Github build process it should be able to be done, but no guarantee because it is built on Linux.
I created an SBC plugin for OPNsense using Asterisk so I should be able to build an OPNsense UI for it.
Don't expect an overnight success with it.
I'll take a look a the client too.

As a big OPNsense user and having a need for the Netmaker server to run on the OPNsense platform, I am going to give it a shot. Reversing the Github build process it should be able to be done, but no guarantee because it is built on Linux. I created an SBC plugin for OPNsense using Asterisk so I should be able to build an OPNsense UI for it. Don't expect an overnight success with it. I'll take a look a the client too.

If you need some help ping me, as mentioned never done a plugin but some it skills.

Good day.
Here is an initial FreeBSD package for Netmaker server that runs under FreeBSD and OPNsense.
https://ksatechnologies.jfrog.io/artifactory/os-netmaker/
This is first attempt but it does install and run.
Everything is under /usr/local/[ etc/netmaker | sbin | var/log/netmaker | var/run/netmaker ]
rc.d script is also included so you can use 'service netmaker '
This should get people started to manually configure it to run via the yaml file and a bit of "OPNsense" FW/NAT rules.
I will be added a os-netmaker repo to my GitHub with and initial netmaker skeleton pluging in the near future.
Also, looks like people might need a 'client' version. Will work on a package for that.

Did you manage to get something running?

Yes, just yesterday. Not yet complete but installs in OPNsense and configures a config file and runs the service.
Will be uploading the code to github and hopefully a OPNsense package to download and install.
I might change the way it configures it because I was thinking a "Tenet" type scenario but trying to figure out how that works in Netmaker.

Yes, just yesterday. Not yet complete but installs in OPNsense and configures a config file and runs the service. Will be uploading the code to github and hopefully a OPNsense package to download and install. I might change the way it configures it because I was thinking a "Tenant" type scenario but trying to figure out how that works in Netmaker.

Cool!
I'm about to test out netmaker next week or so.
Will be able to help out with testing.
My idea is to get a "manager" on one network and then have this as an ingress node for clients and a site-to-site

Have not done any ingress or egress yet, but that is to come as I am reverse engineering the Netmaker and Netmaker UI for Database transactions to see what needs to be done from that aspect.

@TheGrandWazoo I just found your personal (public) repo for the plugin, if you don't mind, I'd like to share the link here.
Maybe it'll help others make progression, I'm going to try it myself today.
GrandWazoo OPN os-netmaker plugin repo.
Would you be able to share the steps you've taken (as comment of direct message)? Don't exactly know how to start building plugins yet (only did an ARM64 OPN build so far), but would like to make it easier for others (like me, we don't know what were doing but we like it).

I am going to change from a top menu to a side menu so it is inline with the Netmaker product and other plugins.
I have not done any ingress/egress yet. Please use the GitHub issues to create tickets for suggestions and ideas so I can get what the community is looking for.

Also going to get some Github Actions going so it will create a OPNsense package.

@fichtner @AdSchellevis there's been movement on this initiative; can it remain open?

Bot is angry, bad botty.

I saw this - not sure I have time to work on it but I can test

I have a side menu working in the features/sidemenu branch Just trying to do a "connections" page like the netmaker-ui has. Once I have the basics then I will so some ingress and egress actions.

I possible, without revealing any sensitive information, can I have a few example configs that I can make sure the OPNsense UI and the backend templates work correctly? You can post them https://github.com/TheGrandWazoo/os-netmaker if you'd like.

FreeBSD 13.2-RELEASE Announcement
Date: April 11, 2023
(underlaying OS of OPNsense)
....
The kernel wg(4) WireGuard driver is now available.
....
https://www.freebsd.org/releases/13.2R/announce/

@TheGrandWazoo: I hope this work will still continue and -if confirmed- I'd be willing to prepare a test environment here that I can tear down and set up for testing. Please let me know if you intend to continue work on htis (it seems that last commits are some months old?)
I just discovered Netmaker and have now a cloud-init with some scripts to set it up easily on CentOS/RockyAlma 9. Would be great to get this in OPNsense! I may need some support here-and-there as I'm really not a network expert! I'd define some regular use-cases that verify a good initial starting-point for anybody who want to get going with this OPNsens <--> Netmaker setup

Any update @TheGrandWazoo ?

Had to spin up a OPNsense instance a DO to do testing between myself and an external source. Still working on it but making some progress. I have NOT updated to the latest version so I am sure there will be some changes due to that.
At the moment I am working on a "Hosts" page for Status like on the Netmaker UI. Just figuring that portion out and then I'll release to people to try it out. Don't expect miracles at first but we will get through it.

Just uploaded the latest FreeBSD package for Netmaker 0.20.1 to https://ksatechnologies.jfrog.io/artifactory/os-netmaker/. Will be updating the OPNsense plugin to reflect the changes.

Just uploaded the latest FreeBSD package for Netmaker 0.20.1 to https://ksatechnologies.jfrog.io/artifactory/os-netmaker/. Will be updating the OPNsense plugin to reflect the changes.

Hi Grand, any update on this?

@fichtner there's been movement on this initiative, can it remain open?

Still working on it...Slow but working on it.
You can always use https://ksatechnologies.jfrog.io/artifactory/os-netmaker to submit bugs/requests or get status.

Also, I am not sure but Jfrog said they were terminating my account. I have not heard from them since I replied so not really sure what it happening. They want me to upgrade but I can't justify $150/mo for the small number of packages I distribute so if it does go away I will most likely have to do a custom repo somewhere.

@TheGrandWazoo I recommend Disroot as they offer Gitea accounts, have been around for years and are funded by donations.  Highly recommended, I'm sure they will be happy to assist you with repo hosting.

@TheGrandWazoo I'm happy to donate to fund the dsitribution page - I'm sure others would be on board as well.
Do you have a Kofi or Patreon?

fyi, seems the current freebsd release is being deprecated as a part of the Netmaker project roadmap.  Sharing here in case that is relevant.
https://github.com/gravitl/netmaker/issues/2705

For FreeBSD, you can still integrate it into the network as external clients, check out this doc on how to integrate OPNsense, pfSense into the netmaker network. https://docs.netmaker.io/integrating-non-native-devices.html

I'll add my interest to this as well. Happy to test if needed.


[HTML5] "response.body is undefined" with 3.3 RC6 in Waterfox Classic

Godot version:

3.3.rc6
OS/device including version:

Windows 10
Issue description:

"response.body is undefined" message appears before loading bar completes.
This is only in Waterfox Classic v2021.02 64-bit (which is the classic version of regular Waterfox -- a Firefox fork).  Firefox, Chrome, and Edge work fine.  Did not test regular Waterfox but I expect it works like Firefox does.
The same export from Godot 3.2.3 works in Waterfox Classic.  My hunch is this is related to the excellent switch to Fetch but can't say I know (or even why a Fetch is being made).
I don't know if Godot wants to continue supporting browsers such as Waterfox Classic, but I would like to if the fix to this is easy.  It is still my primary browser due to vertical tab support (and a few other reasons).
Steps to reproduce:
Export the demo game, Dodge the Creeps, to HTML5.
Run in Waterfox Classic (with or without an http server).
Minimal reproduction project:

https://github.com/godotengine/godot-demo-projects/tree/master/2d/dodge_the_creeps

Seems that Waterfox doesn't support the fetch Response body property. Should be reported upstream.

Not sure what version of Firefox they forked, but body should be there since FF65.
You can try setting the flag javascript.options.streams to true in about:config but it probably still won't work.
Not much we can do, they simply don't support fetch well enough for it to work.

Waterfox should work but Waterfox Classic is forked from FF 56 for continued support of NPAPI plugins.  So, yeah, it doesn't support Body.body.  It does, however, support most of the older parts of the Fetch API.
I mostly just wanted to report it in case there was an easy workaround.  I don't know the use case here so I don't know if streaming through body is required versus arrayBuffer() and the like.  Assuming body is required, however, perhaps there is a solution through a polyfill such as https://www.npmjs.com/package/@stardazed/streams-polyfill .  There are too many polyfills to look at so I can't guess which one might be the thinnest for the use cases here -- and without going too crazy with trying to support too many browsers.  And are they worth the extra weight?  Maybe...maybe not.  I don't suppose an option to include the polyfills is possible?
Anyhow, again, I can't guess what's right for Godot and older and/or "classic" browsers.  I suppose it's all about who's willing to put in what time for maybe 2% of browsers.  Thank you for looking at this.

@juanitogan you can try including the polyfill in the html head include field in the export.

Ooh, interesting, thanks.  I might try it.  I'm only about 50 hours into Godot so there are still a lot of little things like this I have yet to learn.  I've been shaking Godot down to see if it's a fit for project I've been prototyping in another engine.

Just tried it... and it totally works.  Thank you!  I'm so used to complicated web builds that I didn't think about the obvious.
So, yeah, just put this in Head Include:

...and that's it.  Voila!


Override Python language version (kernel) for all notebooks in a Dev Container

I have created a Dev Container for this repo:
https://github.com/pamelafox/materials-fa22
When I open a notebook in that repo, I get prompted to pick a language version. It seems to have both 3.9 and 3.10 in the environment - I think 3.9 comes from the base Debian image, but 3.10 is the desired version for the notebooks.

When I do pick 3.10, it saves it into the notebook's metadata as the version, and it then recommends that version going forward for newly opened notebooks.

"version": "3.9.13"

"version": "3.10.11"
}

I would love to be able to just specify the version at the dev container level, in a setting for the Jupyter extension, as I don't want students using the repo to accidentally pick 3.9 instead of 3.10. I don't want them to have to make that decision at all, since it can be a difficult decision for someone new to Python. I also don't want to have to re-save every notebook with the exact version every time we update the Dev Container language version.
Thanks!

I agree that it would be nice to set this in some sort of in-repo configuration that will get pulled in by a devcontainer, perhaps combined with a reasonable default inference.
I suspect that the thing we'd actually want to specify is the path to the executable and not the version. That's because, across multiple computers, the patch version can often be different because devcontainers tend to come only at a major/minor level of specificity (and pulling the then-current patch when built).
Additionally, it's probably a reasonable inference that someone using a devcontainer image that specifies, for example, Python 3.11 will want /usr/local/bin/python and not usr/bin/python3, so this might be something that could be set at or inferred from the image level, making the right choice for most users without configuration (and being easily configurable when needed).

This is needed by my company as well. It would be nice if it simply defaulted to the default python path.

Duplicate https://github.com/microsoft/vscode/issues/130946


Unable to connect to lattice

I'm running lattice instance using vagrant and virtual box in windows. In the same host machine I'm running another Ubuntu virtual machine where ltc is installed. I'm trying the below ways to connect from ubuntu to the lattice instance but it is failing
Direct

ltc target <IP_ADDRESS>
Error verifying target: Get http://receptor.<IP_ADDRESS>/v1/desired_lrps: dial tcp: lookup receptor.<IP_ADDRESS>: no such host

Ping works fine to 192,168.11.11

xip.io

ltc target <IP_ADDRESS>.xip.io
Could not connect to the droplet store.

But the error message comes after a long time.

dns

ltc target lattice.dev
Error verifying target: Get http://receptor.lattice.dev/v1/desired_lrps: dial tcp <IP_ADDRESS>:80: connection refused

Ping works fine from Ubuntu on "lattice.dev

Passing by as I watch GitHub for "<IP_ADDRESS>" issues,
You don't own lattice.dev and therefore don't control its DNS, please don't use it, you're getting that IP to warn you to fix things.

I think the lattice.dev is a red herring there.  If you haven't gone through setting up a custom resolver on OS X to handle the .dev resolution requests, as @Sacro points out, you're going to pick up the new NS record that Google bought and see some unexpected results.
For one, you absolutely need to be using the xip.io suffix above.
It may be simpler to run ltc on the vagrant box itself rather than try to do this with two machines.  It should work to copy the linux ltc binary into the folder you vagrant up from, and then vagrant ssh into the box and access that ltc binary on /vagrant.
You should be able to run something like curl -v http://receptor.<IP_ADDRESS>.xip.io/v1/desired_lrps on the same machine you plan on running ltc.

@Sacro we're working on getting rid of our .dev dependency :fist: google
We now support ltc target local.lattice.cf  (requires LATTICE_SYSTEM_DOMAIN=local.lattice.cf vagrant up on v0.5.0) which might replace needing to use dnsmasq at all.
We also don't yet support Windows deployments.  Keep an eye on [#98709384] for support for that.
Closing this issue.


adjusting font sizes and spacing

Coverage remained the same at 65.132% when pulling a47f1e99b67ad101760405218f6cd3442009579e on oc-86 into d18302b08f4409c5439b3985ccc3a76f2e7d282a on master.

Coverage decreased (-0.003%) to 65.129% when pulling fec58791bf335660f50a11ff9d2962540c4bf9cb on oc-86 into d18302b08f4409c5439b3985ccc3a76f2e7d282a on master.


Improve handling default enum values

This merge request provides a fix for the problems highlighted in #77.
By default, Protobuf libraries do not encode first enum values. If the value is missing when decoded, those libraries assume the first enum value as default. According to https://developers.google.com/protocol-buffers/docs/proto3#default:

"For enums, the default value is the first defined enum value, which must be 0."

The problem is observed when trying to pass valid PBFs to the decode function that were not first encoded by geobuf.js but by another library (e.g. pygeobuf). The readCoords function is checking for type, which if it's a POINT, is undefined. Obviously, this impacts anything expecting valid GeoJSON.
The update to the readGeometry function adds behaviour similar to the functions above it (readFeatureCollection and readFeature) which set a default value. This solves the symptom observed in the readCoords function (captured in #77) by ensuring that the geom.type is not undefined.

can it be merged?


[request] Option to keep the order of keys, not sorting them

Sorting keys in message files are bothering. It's awesome if there's an option to keep keys as is.

Currently it is not possible to keep the sorting as we are not storing it from the original uploaded files. Could you maybe explain your use case for this a little bit?  That would help a lot

I would also find this useful - I'm developing Android apps.
The reason is that I tend to define my keys in a particular order - usually grouped by the screens in which some strings are used.
However, this order is broken by phrase when performing a push/pull, leaving me with my strings all scrambled.

Any updates here? I want to see keys exactly in the same order I've added them to the file. This should be a not impossible feature. Thanks in advance!

@letehaha Unfortunately right now we do not have this functionality planned. We do not store the original order of translations right now. The order could also be different for each language. In addition there is the question where newly created translation in Phrase would be placed at in the file.
@letehaha Could you maybe also describe your use case a little bit? In case you do manage the keys and translations in Phrase the order in the file itself should not be that important in most cases as it does not need to be looked at by a human

@theSoenke thanks for your answer!

In addition there is the question where newly created translation in Phrase would be placed at in the file.

Agree with you.
To tell you the truth, I don't really care what order these keys are in. But 😄 My current use case: the keys for configuration and formatting are at the very top of the file to make it easy to find them because my translation file is quite large. Since I am currently in the active development phase, I often have to look there and change things. Looking at the current limitation, I just created a general space for the project and split a large single file to a few smaller ones and store them as different projects. So configuration&formatting keys now are placed in a separate place. Then I merge all files into a single one on the building step. Sounds like a good and scalable solution, but this requires me to write additional code – I wouldn't say I'm super convenient with it :)
Maybe it would be nice to add some setting, that will allow to "attach" some root keys at the top of the file. But from another side, I understand this is a strange feature  🤷♀

here's my use-case 😢
      "duration": {
        "label": "Duration",
        "options": {
          "120": "2 hrs",
          "1440": "24 hrs",
          "15": "15 mins",
          "180": "3 hrs",
          "240": "4 hrs",
          "30": "30 mins",
          "360": "6 hrs",
          "45": "45 mins",
          "480": "8 hrs",
          "60": "1 hr",
          "720": "12 hrs",
          "90": "1:30 hrs"
        }
      },

@ElGoorf numbers as a key name are quite rare and sorting by length first not going to work for 99% of your keys too, so we cannot fix these keys order easily. Sorry.
On the other hand, looks like you are converting minutes to human-readable format. Hard coding it in localization file is not a good idea. I would use some helper function or package for it eg https://www.npmjs.com/package/humanize-duration so you need to store only units in translations eg mins hrs and not whole minutes to hours mapping. That will allow translate units and keep the logic separate from translations.
      "duration": {
        "label": "Duration",
        "units": {
          "mins": "mins",
          "hrs": "hrs"
        }
      },


Update PetPet.lua

this will fix a problem when u land and collecting the gas cloud. before this u will summon your pet in middle of the channeling its about this tool https://www.wowhead.com/wotlk/item=23821/zapthrottle-mote-extractor

Thanks @Toodo ! I am currently unsubscribed so I haven't been able to test any code changes I've made.
Can I please ask that you include the fix you mentioned on #2 on this PR as well?

LGTM @Toodo. Thanks again!

Resolves #2


After parse error, MMM swallows following parse-valid command

Sample script:
!mmm parse error
!mmm do execute error 1
!mmm do execute error 2

…results in the following output:

(From Mych's Macro Magic):
During parse, unknown command in script: ❌parse error
(From Mych's Macro Magic):
During execute, any identifier not expected here (expected binary operator) in expression in script: !mmm do execute ❌error 2

Note the absence of "error 1".

If the following command opens a (valid) block, everything in that block will be swallowed as well:
!mmm parse error
!mmm script
!mmm chat: this will be swallowed
!mmm chat: this will also be swallowed
!mmm end script

...results in:

(From Mych's Macro Magic):
During parse, unknown command in script: ❌parse error

...and nothing else.

First guess at the cause: A parse error skips over the this.complete = true, leaving the command open for subsequent additions as if it was a block command – even if it's not. So everything that gets desired actually gets added to that pseudo-block as nested commands.

It's actually that plus another separate bug where starting a script block doesn't entirely fulfill its promise of resetting pending-script state: While it does replace any pending script, it doesn't clear its error state, and so the entire script block will be gobble up and then not executed (because it's in an error state).


Suggestion: use standard logger name for logging

Logging systems use package separator to filter
<logger name="org.ehcache.spi" level="WARN"/>
So a suggestion would be to use that so that we can filter the different cache names in logs, if you are using cache names in logger names.
I saw it in UserManagedCacheBuilder . I don't know if other classes needs to be changed though...

Why not? I like the idea of keeping the dot ('.') as the separator.

I agree that this makes sense. For completeness, org.ehcache.core.EhcacheManager#createNewEhcache should be adapted as well then.

closing PR - created branch at wrong place. Will reopen and add the other modification :-)


[FEATURE]: assertContainerBuilderHasServiceDefinitionWithMethodCall - unable to test implementation of chain of responsibility

Considering that there is a service of type of "Registry", which gets injected with services of types of "Handler" via method call "addHendler" -> if order of injection of each individual handler via method call is significant, we are not able to test it.
Proposal: extend method signature of assertContainerBuilderHasServiceDefinitionWithMethodCall() to:
protected function assertContainerBuilderHasServiceDefinitionWithMethodCall(
    $serviceId,
    $method,
    array $arguments = array(),
    $index = null // Zero-based order of invocation of method call
)

This implementation will be BC compatible, if $index is provided, assert should check if method call has appropriate order in collection of registered method calls.
Application is useful, of course, when testing implementation of chain of responsibility pattern and/or visitor pattern where order of injection is prioritized.
I am willing to submit a patch, if you agree that this is a valid request for improvement.

Sorry - missing info: Injection of "Handler" services via method call is done via tagged services, where priority is provided. Compiler pass would sort services according to priority and add a method calls to the definition of "Registry".
For now, we are not able to test if this sorting is properly executed.

Hi, I'm sorry, I've not been working on or with this library for some time now. I am definitely willing to merge your proposal, in particular as I think it would make sense for more people. Please provide a PR, with tests and updated documentation :)

What? Why? What is wrong with this library? Are you planing to depreciate it? Why? Is there better alternative?
If there is no better alternative, and you do depreciate library, you know what comes next: https://cdn.meme.am/cache/instances/folder517/25205517.jpg
😄  😄  😄
Ok, I will write a patch and make a PR.

Mainly: I haven't done any big Symfony projects for almost 2 years ;)
I won't deprecate it, as it has its use cases, but I do believe that I would personally shift my focus while testing to testing the bundle as a whole, or in a fully functional setup. I intend to blog about this some day, but have been quite busy with some other technical content lately.
Anyway, thanks and looking forward to seeing your PR.

Would you please bump version to 2.0.1 ?
I can not fetch this feature without using "dev-master"....

I did actually: v2.1.0. Although it's not an official release, it is an official tag :)

Hm... there is something wrong on packagist then...
Version is missing, see: https://packagist.org/packages/matthiasnoback/symfony-dependency-injection-test - there is no 2.1.0? Should I raise issue there?

Okay, I clicked "Update" on packagist.org, don't know what could've gone wrong, but the new version is there now :)

Thanks!


Rounding error when setting celsius temperature

Hi there,
I just set this up with my LG LP1419IVSM, and I managed to get it working after some tinkering, however, initially it was failing due to a failing temperature conversion - some part of the Home Assistant stack was setting a temperature to 78.80000000000001ºF, and this crashed upon being passed to _ac.set_fahrenheit, because the mappings only contain fahrenheit values for each whole degree (see below).
I’ve overcome this temporarily by editing the source to set fahrenheit to False in LGDevice’s __init__ method, which appears to cause Home Assistant to send the unaltered Celsius value, but this seems like it should be gracefully handled in the default code, given it’s a natural behaviour within Home Assistant.
A partial log from when I experienced this failure is below:
2019-05-15 10:21:07 INFO (Thread-20) [custom_components.smartthinq.climate] Setting temperature to 24.5…
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/homeassistant/.homeassistant/custom_components/smartthinq/climate.py", line 189, in set_temperature
    self._ac.set_fahrenheit(temperature)
  File "/srv/homeassistant/lib/python3.5/site-packages/wideq.py", line 870, in set_fahrenheit
    self.set_celsius(self.f2c[f])
KeyError: 78.80000000000001

For further reference, my Air Conditioner’s reported f2c mapping is:
{50: 10, 51: 10.5, 52: 11, 53: 11.5, 54: 12, 55: 12.5, 56: 13, 57: 13.5, 58: 14, 59: 15, 60: 16, 61: 16.5, 62: 17, 63: 17.5, 64: 18, 65: 18.5, 66: 19, 67: 19.5, 68: 20, 69: 20.5, 70: 21, 71: 21.5, 72: 22, 73: 22.5, 74: 23, 75: 23.5, 76: 24, 77: 25, 78: 26, 79: 26.5, 80: 27, 81: 27.5, 82: 28, 83: 28.5, 84: 29, 85: 29.5, 86: 30, 87: 30.5, 88: 31, 89: 31.5, 90: 32, 91: 32.5, 92: 33, 93: 33.5, 94: 34, 95: 35, 96: 36, 97: 36.5, 98: 37, 99: 37.5, 100: 38, 101: 38.5, 102: 39, 103: 39.5, 104: 40}

And the c2f (noting that this one in fact has every half degree!) is:
{10: 50, 11: 52, 12: 54, 13: 56, 14: 58, 15: 59, 16: 60, 17: 62, 18: 64, 19: 66, 20: 68, 21: 70, 22: 72, 23: 74, 24: 76, 25: 77, 26: 78, 27: 80, 28: 82, 29: 84, 30: 86, 31: 88, 32: 90, 33: 92, 34: 94, 35: 95, 36: 96, 37: 98, 38: 100, 39: 102, 40: 104, 10.5: 51, 11.5: 53, 12.5: 55, 13.5: 57, 14.5: 58, 15.5: 59, 16.5: 61, 17.5: 63, 18.5: 65, 19.5: 67, 20.5: 69, 21.5: 71, 22.5: 73, 23.5: 75, 24.5: 76, 25.5: 77, 26.5: 79, 27.5: 81, 28.5: 83, 29.5: 85, 30.5: 87, 31.5: 89, 32.5: 91, 33.5: 93, 34.5: 94, 35.5: 95, 36.5: 97, 37.5: 99, 38.5: 101, 39.5: 103}

Makes sense! For what it's worth, you have stumbled across my least favorite part of this whole LG API mess: the f2c and c2f mappings are not algorithmically calculated, and you really do have to use those exact lookup tables to translate between the two. Someone at LG decided that they needed their own, in-house, LG-branded versions of these temperature scales. 🙄
I think the thing to do here is to make LGDevice here somehow sensitive to the Home Assistant configuration—i.e., it should set fahrenheit according to some global HA parameter that decides whether you prefer C or F. I hope this should just require some digging around in the HA source/docs to find the right parameter to use.

Fixed in #21.


opensnitch-ui: Add wayland support

Without this dependency opensnitch needs to be run with QT_QPA_PLATFORM=xcb override in Wayland environments.
Description of changes
This just adds a dependency to allow running opensnitch-ui natively under Wayland.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Just tested it and it works fine, thank you! Waiting for your fix


[Enhancement] Use standalone lake compaction txn timeout config

Why I'm doing:
Fixes #36242
What I'm doing:
add two fe configs related with transaction timeout for lake compaction
What type of PR is this:

[x] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[x] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@wxl24life Your newly added unit test failed


Payload limiting on app.get('user')?

There seem to be two options for limiting 'user' object fields:
1. Payload
i.e. the stuff that goes into the JWT token, set on token: { payload { /* set here */ }} in the call to .authentication on the server.
2. Using 'after' hooks
i.e. hooks.remove('password')
So far, so good.
Except app.get('user') on the client side seems to return the full user object, minus only the password field. If there are any other private fields returned by the service (in my case, using knex) then those are still exposed.
Is there a way to limit what the client sees via app.get('user')?
This isn't so much for security in my case, and more to limit bandwidth to data that I'll actually use. I have a lot of normalised statistical stuff in my user tables that aren't really relevant to send down the wire.

That's why auth 1.0 client is doing a separate get to get the user (with all the hooks). I recommend upgrading to 1.0-beta (see https://github.com/feathersjs/feathers-authentication/blob/master/docs/new-1.0-features.md).

great, I'll do that. Thanks @daffl


Improve ambiguous "he"

@jahfer I wasn't totally sure who "he" was - I think this was supposed to be Mulcair?

Sorry was on vacation. Thanks for the clarity fix.


added links for github template

pls update to resolve the conflict

Please help to resolve conflicts. Thanks.


A typo in neucon_network？

https://github.com/zju3dv/NeuralRecon/blob/cd047e2356f68f60adfb923f33572d712f64b57a/models/neucon_network.py#L161
Hi @JiamingSuen , I was trying to train NeuralRecon from scratch but failed to reach the performance mentioned in the paper.
After some investigation, I found out something I could not comprehend here in this line. Is it a typo for the scale argument? Should it be scale rather than i for this argument? Thank you very much.

@HaFred Hello HaFred, I also cannot get the performance mentioned in the paper. Have you solved this problem? Many thanks.


Add promise-do-whilst link and description

I added the promise-do-until module link and description to the
Convenience Utilities section.
I added clarification to the promise-whilst description to help
discern differences with promise-do-whilst.

Thanks!


privacy warning: t-addr

adds a privacy warning to the approval dialog if the Ics20Withdrawal message includes a transparent address (t-addr).
CI pipeline is currently failing because this depends on https://github.com/penumbra-zone/web/pull/1950 and requires bumping package dependencies.

need to truncate IBC-address rendering which is currently getting cut-off

Shouldn't the updated rendering show "use transparent address" rather than "use compat address"?

the approval dialogue needs to be updated to reflect the t-addr for USDC Noble withdrawls.

Shouldn't the updated rendering show "use transparent address" rather than "use compat address"?

yes, updating the approval dialogue to reflect the t-addr for USDC Noble withdrawals.

I am not going to block on it, but if we set the transparent flag on, I think it makes sense to render the withdrawal component with a return address encoded as a transparent address.
We do this by adding a PENUMBRA_BECH32_TRANSPARENT_ADDRESS_PREFIX with helpers to the web package @penumbra-zone/bech32. Then, we should be able to display the transparent encoding of an Address. This is how it's done in core: https://github.com/penumbra-zone/penumbra/blob/020986747245270a00d039306458be9e7f1f33f5/crates/core/keys/src/address.rs#L232

We do this by adding a PENUMBRA_BECH32_TRANSPARENT_ADDRESS_PREFIX with helpers to the web package @penumbra-zone/bech32


Hello Microverse Project Pull Request

Summary :
I have added linters and proper descriptions in the README.md file. I'm happy to start researching this path. Let's also consider breaking this out into its own service. We can then re-use it or share the accounts with other apps in the future.

README.md file has been updated with my self information

Changes have been made in README.me file as per guidance of Reviewer and Microverse Guidelines.

@topeogunleye this project is already accepted and approved the main reason is that i was failed to clear quiz so kindly approve and accept

@topeogunleye this project is already accepted and approved the main reason is that i was failed to clear quiz so kindly approve and accept

@tamoorsaeed22, You only need to revert your pull request as it's even impossible to approve a closed pull request on GitHub. Kindly DM me if you need help reverting you closed pull request


use primary constructors

I really feel guilty about being rude, but I'm closing this and will simply link to the contribution guidelines if it happens again.
The PR template pleads with contributors to read and honor the contribution guidelines:

Thanks for taking the time to submit a pull request! Before filling out a new PR, please review the
documentation on Contributing to Fixie.
Submissions that do not follow this guidance may be closed quickly with a link to the relevant section.

Most of the PRs submitted to this repo since inception have been incredibly disruptive, so I wanted to make it easier to get ahead of that by writing up the guidelines and sticking to them.

First, I'm partway through doing this already in a local branch. I set it aside for a little while on purpose as I wasn't quite sure as I went along which situations I prefer to use the feature and which situations I'll prefer not to.
Second, I have a lot of specific upgrades planned out in a specific order as I have pivoted to v4 development, and want to be very deliberate about the changes as I go since they all touch a lot of files and concepts. You'll see in the recent commit history that I'm being particularly fussy about what changes are automated by tools, why some changes are happening, and taking things in small enough chunks that they are easy to review with confidence. I'd disable all PRs from third parties for a couple months while I carry out the plan, but I don't think such a feature exists.
Third, I'm also seeing the following which would have been in feedback if I was entertaining the PR:

Unintentional changes meaning the code wasn't reviewed before submission, and meaning it is unclear which changes were automated by tooling and which were manual. e.g. ParserTests.cs
Renaming of important/meaningful/domain identifiers. e.g. assemblyPath to path, testPattern to pattern, defaultReports to reports, postAction to action. I suspect automated tooling slipped these in, but if so that's another signal to me that the changes weren't reviewed.
Unintentional addition of user specific resharper settings.

When I get PRs that have several signals that make it unclear which changes were automated, which were manual, and which were reviewed, I tend to do the review by implementing the changes more slowly in a throwaway branch and then diffing them against the submission for any surprising differences, which accounts for the risk but does have a cost in time and roadmapping efforts.
Lastly, here are the relevant sections copied verbatim from the contribution guidelines page:
Missing Description
An unanticipated PR with little to no Description is very likely to be rejected.
Receiving a PR is a job. A job can be welcome and fulfilling, but a job with no context is likely one you wouldn't want to sign up for either. Asking the reviewer to spend time and energy just to figure out what is going on or what train of thought you had in secret is a rough way to start a conversation.
Code Style Changes
An unanticipated PR that includes code style changes like whitespace or naming conventions is extremely likely to be rejected.
These are incredibly disruptive to any other branch in progress, and increases the code review effort when such changes are mixed in with another substantive change.
Sweeping Changes
An unanticipated PR that includes sweeping changes to many files across the solution is extremely likely to be rejected.
An example of such a change would be adopting a new C# feature solution-wide without a motivating use case. These are incredibly disruptive to any other branch in progress.
Although we do apply this kind of work from time to time, it is often a carefully scheduled activity early in development of a planned breaking major version bump, and that timing is influenced by Microsoft's own target framework support windows.
Please start by opening an Issue to discuss the motivation, the proposed change, and the risks of adding defects.


Typo: followed by vowel so a -> an

Tiny typo correction in the main text:
From "this is a optimization problem"
To "this is an optimization problem"

This seems to be quite a frequent error in the book, maybe it's a decision taken by the author to use 'a' instead of 'an'? Not sure why, but would be curious to find out :)

I assure you it's a mistake =)