adding props for detail panel offset right and left

Quick description
Detail panels take the whole length of the table when collapsed. This PR introduces a prop to enable setting an offset for detail panel in options prop. This offset prop is formatted as fixedColumns prop in options props (see https://material-table.com/#/docs/features/fixed-columns) with left and right offset attributes.
Detailed description
The actual behaviour of detail panels in terms of length and align is by taking the entire length of the table with no offset as shown in this picture:

This PR aims to enable way to set left and right offset of detail panel, controlling by the way its length, as shown in the following picture:

This option's prop is named detailPanelOffset has this shape:
detailPanelOffset?: { left?: number; right?: number };
Example: detailPanelOffset: { left: 1; right: 2};
Values given for left and right offset correspond to number of columns since each column of the table has a colspan of 1. The actual behaviour sets the colspan of detail panel to colSpan={renderColumns.length} which is the total lenght of the table. With this PR, an empty td is added when left offset is defined. It takes a number of columns equivalent to the left offset value. Right offset is made by reducing the length of the detail panel.
Default offset values are set to 0, which make it compatible with actual usage of the table.
Impacted Areas in Application
Detail panels

Hi thank you for the PR, The codes looks straight forward. What are you using this for in your table? I think one oze4 looked at it as well, we should be able to merge this.

Hi thank you for the PR, The codes looks straight forward. What are you using this for in your table? I think one oze4 looked at it as well, we should be able to merge this.

Hi. Thanks for having looked up the PR. A simple use case for us is that in terms of styling, we think it's nicer to have the detail panel aligned with the starting of the first (real) column, rather than with the icon column as shown here:
This is detail panel aligned to first real column:
The detail panel looks more like a subpart or the row, a child of the collapse.

Rather than this, which is detail panel aligned to icon:
The detail panel, as it takes the whole length of the row, does not look like its child.

We didn't want to add just an offset from the left, which is our need, because we said other people may want to have a right offset first, and that it's possible to set the collapse icon of detail panel in the right (look at the 'detailPanelColumnAlignment' props). On the more, it's more "symetric" to have right and left offset enabled, rather than just left offset.

Thank you. I will have a new version published shortly. I'm on mobile right now.


issue with laravel 5.4

in laravel 5.4 , event fire function renamed to dispatch  ...
If you are manually implementing the Illuminate\Contracts\Events\Dispatcher interface in your application or package, you should rename the fire method to dispatch.
in project we get this :
PHP Fatal error:  Uncaught Error: Call to undefined method Illuminate\Events\Dispatcher::firing() in /Users/roboticsexpert/Sites/UpperTime/vendor/sentry/sentry-laravel/src/Sentry/SentryLaravel/SentryLaravelEventHandler.php:29

@roboticsexpert are you using the current release of this library? We pushed out an update that added support for 5.4

yes ... but in package dependency you should add that .0.5 version just support laravel 5.3 ...

@roboticsexpert we dont update previous versions, and we didnt know 5.4 was going to break 0.5.0

Overall, Thank you for your quick response. @dcramer


Include in private-preview [request]

I would like to be included in the private preview for this extension!
Please provide your Azure DevOps "Organization Name" (https://dev.azure.com/ProofDB/):

(required) Organization Name: https://dev.azure.com/ProofDB

The Technology stack that best describes my scenario:

[x] JavaScript / TypeScript

Result format that I plan to use:

[x] JUnit

The Azure Pipeline Agent I intended to use is a:

[x] Linux - Microsoft cloud hosted

I intend to use the Test Plan extension in:

[x] YAML Pipeline

Added. Please see the deployment instructions on how to install the shared extension.
Please open a defect if you encounter any issues.


fix fix broker load with hdfs failed to get right file  type

Proposed changes
Issue Number: close #xxx
Problem summary
Introduced from #14808, using broker load with hdfs will get "LOCAL" file type, but should be "HDFS"
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.89 seconds
load time: 678 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221216103559_clickbench_pr_64449.html


Module docs don't appear in monolithic docs.rs page

Every bevy crate has it's own docs.rs page, and also appears as modules within the monolithic bevy documentation page. Users are usually directed to the monolithic docs, and it's what we link to on the website.
Unfortunately module level docs (like this) don't display properly on the monolithic module page (here for example). They do render properly on the individual crate docs (this is how the rendered docs should look). This means most users are loosing out on important structural documentation.

IMO we should use separate .md files for each of these, and #![doc = include_str!("path/to/docs.md")] in both locations.


✔ Improved the FAQ Section!

Hey @khushi-joshi-05 and @sunny0625
issue #1443
I have improved the FAQ Section of the Website -
What I Did -

Improved the Styling of Both Questions and Answers Triggers.
Added more "Comprehensive Questions" to the FAQ Page
Improved the "Accordian" Functionality to be smooth.
Added Text-Highlighting Shadow to the Main-Heading.
Added Hovering Effects to the Questions-trigger.
Added Hovering Effects to the Answer-trigger.
Also, Increased the Width of the Questions.

Here's the Implementation -
https://github.com/user-attachments/assets/5a566477-c3bf-45fd-9b50-5dbf147bfebe
Please take a look.
thankyou!
Type of PR

[x] Feature enhancement

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

@khushi-joshi-05 @sunny0625

@khushi-joshi-05 @sunny0625 Please take a look, resolved the conflicts


improvement: test file structure === server file structure

no issue

ensure we have the same structure in test folder (especially for unit tests)
it's hard as contributor to look for tests, when they don't sit in the correct folder
for now: we have some index_spec.js files because of the server structure
future: do not use index_spec.js to integrate logic, this is not the purpose of an index.js
created others folder, because we had tests for shared folder and general tests which don't belong to unit or integration

notes
Some Pull Requests needs a rebase with master after this change.
coverage-all master
Statements   : 90.88% ( 6653/7321 )
Branches     : 85.05% ( 3368/3960 )
Functions    : 88.88% ( 1623/1826 )
Lines        : 90.94% ( 6643/7305 )
coverage-all this PR
Statements   : 90.89% ( 6622/7286 )
Branches     : 85.09% ( 3343/3929 )
Functions    : 88.85% ( 1618/1821 )
Lines        : 90.95% ( 6612/7270 )
tasks

[x] wait that #6955 and #6929 are merged, they both cause random errors
[x] recheck coverage
[x] go over each test file and check if i deleted some new code

@kirrg001 when you've got a bit, both of those PR's mentioned in tasks have been merged, so would this work after a rebase/

@ErisDS do you have any thoughts on this before it gets merged?

This is all much, much cleaner 👍
Only thing I'm not 100% on is the others thing. Partly because that's an odd word, for showdown perhaps 3rd party or external is what's meant? Other reason is that these tests do contribute towards the coverage level, I think, and so it seems weird to separate them off?

will add to coverage-all, but not sure about the naming "external". maybe "extra"?

"extra" sounds good to me 😄

Sorry for dropping this. I also agree that extra makes sense. Would you like to get this merged ?

I would close it :(
It's too old now. Too many conflicts to resolve - especially for our playground branch.
Will do it again in the future for 1.0.


Opening hours on detailpage

The restaurant detailpage should contain the opening hours.

You are totally right. Here you go.


Fix Ubuntu installation instructions

Add g++ package to Ubuntu installation instructions. Otherwise, cargo-build on package librocksdb-sys fails with error occurred: Failed to find tool. Is c++ installed?
Add zlib1g-dev package to Ubuntu installation instructions. Otherwise, cargo-build fails on linking with

  = note: /usr/bin/ld: cannot find -lz
          collect2: error: ld returned 1 exit status

@ptqa @NukeManDan @shawntabrizi  not sure how to proceed here? I personally can't verify what's brought up here. Can we decide whether we want to rectify or drop this PR?

@sacha-l there is way to verify it - run a new ubuntu VM and check a list of packages installed by default. If required packages have no g++ & zlib then we should probably add it to docs and other scripts.
Luckily I've just did it for clean Ubuntu server  image on AWS - here is a list of packages installed by default https://termbin.com/b1w9 (output of dpkg -l command). And there is no g++ or zlib-dev.


[cleanup] unused code in file PropertiesStorage.java

ISSUE TYPE

Improvement Request
Enhancement Request

SUMMARY

location: agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java
line no - 122, 128, 146
screnshots-

There are some methods which are declared but do not have any working.
these methods can be removed.

EXPECTED RESULTS

can remove that code

Thanks for the issue @nikam14 you're welcome to submit a PR to cleanup. Code specific changes need not always require an issue, you can directly raise a PR instead.


Regex on hears method

Guys,
I don't know if I'm making a mistake, but I'm using this regex below:

I don't have the response from this method.
My botkit is "botkit": "^0.5",
Thanks!

Hello! What issue are you experiencing? Whats not working?
On Fri, May 5, 2017 at 9:21 AM Danilo Avilez<EMAIL_ADDRESS>wrote:

Guys,
I don't know if I'm making a mistake, but I'm using this regex below:
[image: image]
https://cloud.githubusercontent.com/assets/7416241/25746976/2aee0d16-317c-11e7-88ff-7f278061d757.png
I don't have the response from this method.
My botkit is "botkit": "^0.5",
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/howdyai/botkit/issues/832, or mute the thread
https://github.com/notifications/unsubscribe-auth/AMUR2y4WhTjjIEw_S7AKiUbj5v6NMArXks5r2yI2gaJpZM4NR6EK
.

When I type "quero ver o cardapio" this sentence has to go to that regex on hears method. Although, it appears that it goes to fallback, the core doesn't find my method hears with my regex.
In consequence, it doesn't answer nothing because I don't have any fallback.

Try RegExPal to debug regex.

It worked!! Thanks a lot!!!


v10-rc3: Live-view does not add blacklist record on ban

Hello everyone,
as discussed on discord (https://discord.com/channels/685692524442026020/685695097349734469/1269314363324497990) a blacklist entry can only be added via the history->players-tab.
Is it possible to change the temp and permanent ban buttons to "Add blacklist-Entry" or something similar?
Thank you!
PS: I don't want to put you under any pressure with this issue, but I would like to give you the opportunity to get an overview of the current problems. Discord messages are a bad idea, too cluttered.

Hey.
I believe this issue has been also resolved via https://github.com/MarechJ/hll_rcon_tool/pull/632/commits/dad45e185c39eb043c8e4208e9a86bce13d1d4df

Thank you for noticing, closing.


Calendar export has yet to include location of classes

Calendar export has yet to include location of classes

See #179


Revert "Azure Terraform Configuration"

Reverts vectorizedio/deployment-automation#40

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bug: API Request: TypeError: Cannot read properties of undefined (reading 'map')

Describe The Bug
Doesn't seem to connect to the API
To Reproduce
Occurs on startup
Expected behavior
Connect to API and bring accessories in
Relevant log output
[22/10/2022, 13:13:14] [SwitchBot] API Request: TypeError: Cannot read properties of undefined (reading 'map'), Submit Bugs Here: https://tinyurl.com/SwitchBotBug

Config for homebridge-switchbot
{
    "name": "SwitchBot",
    "credentials": {
        "token": "--",
        "secret": "--",
        "notice": "Keep your Token & Secret a secret!"
    },
    "options": {
        "devices": [
            {
                "deviceId": "--",
                "configDeviceName": "Apartment Door",
                "configDeviceType": "Smart Lock",
                "connectionType": "OpenAPI",
                "lock": {
                    "hide_contactsensor": false
                },
                "refreshRate": 30,
                "logging": "standard"
            },
            {
                "deviceId": "--",
                "configDeviceName": "Door Buzzer",
                "configDeviceType": "Bot",
                "connectionType": "OpenAPI",
                "bot": {
                    "mode": "press",
                    "deviceType": "switch",
                    "allowPush": true
                },
                "offline": true,
                "logging": "standard"
            }
        ]
    },
    "platform": "SwitchBot"
}

Screenshots
No response
Device & Model
Raspberry Pi 3 B+
Node.js Version
LATEST
NPM Version
LATEST
Homebridge Version
LATEST
Homebridge Switchbot Plugin Version
LATEST
Homebridge Config UI X Plugin Version
LATEST
Operating System
Rasbian

Need more logs please turn debug mode on and post those logs

[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] statusCode: 200
[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] headers: {"date":"Sat, 22 Oct 2022 18:22:11 GMT","content-type":"application/json","content-length":"73","connection":"close","x-amzn-requestid":"45f40ad2-3e7f-4b83-a943-744f4d107102","x-amz-apigw-id":"aa0w_HSgIAMF1ag=","x-amzn-trace-id":"Root=1-635434d2-796ef2dd2ebd85a005d5331d;Sampled=0"}
[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] d: {"statusCode":190,"body":{},"message":"Requests reached the daily limit"}
[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] devicesAPI: {}
[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] SwitchBot Device Config Set: [{"deviceId":"D64AB0850524","configDeviceName":"Apartment Door","configDeviceType":"Smart Lock","connectionType":"OpenAPI","lock":{"hide_contactsensor":true},"logging":"debug"},{"deviceId":"EC9EC0958692","configDeviceName":"Door Buzzer","configDeviceType":"Bot","connectionType":"OpenAPI","bot":{"mode":"press","deviceType":"switch","allowPush":true},"offline":true,"logging":"debug"}]
[22/10/2022, 14:22:11] [SwitchBot] API Request: TypeError: Cannot read properties of undefined (reading 'map'), Submit Bugs Here: https://tinyurl.com/SwitchBotBug

I had my refresh rate at 1second.. whoops. What's the daily limit for refreshing status? Any idea?

[22/10/2022, 14:22:11] [SwitchBot] [DEBUG] d: {"statusCode":190,"body":{},"message":"Requests reached the daily limit"}

Here is your issue.

10,000 a day.


Resolving issue 177

Issue Title:  [BUG] Canvas reset after brush color/thickness / Reset button Bug / Increase height bug
*resolve issue: #177
Type of change ☑
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙
Describe how have you verified the changes made.
Tested by running locally on my laptop

@shubhammjha22 The canvas size increase/decrease buttons are not working properly, can you attach a recording of them working on your end?

Sure here is the video attached-
https://github.com/singodiyashubham87/Draw-it-out/assets/68507333/982a7e7b-739f-4411-bc8d-6572d5d70fdd


B 20256 int prevent prime users from accessing pptas

Agility ticket
Summary
A new field 'allow_pptas' is added to client_certs to allow specified users to use PPTAS. New Authorization method has been added so PPTAS may only be acessed if the aforementioned flag is set for the user's certificate. The flag may be modified in sql directly or within the admin page. Also PPTAS has also been separated from prime's routing. Therefore all pptas routes follow Prime's api naming convention of 'pptas/v1'.
Setup to Run the Code

Make sure your postman has the latest devlocal certificate, you will need to update it each time you re-run the server
Verify that postman has the latest api spec. If not, remove it from postman and re add it using the swagger-def for pptas.

How to test
Swagger

Open the admin page, log in
Open the client_certs tab
Verify that devlocal certificate has 'Allow PPTAS' checked , otherwise, edit the flag to set it to true.
In another tab try to acess the swagger page for pptas at: PPTAS Swagger. if the last step worked, the page should show with no errors
Under the same certificate as before, set 'Allow PPTAS' to false
Attempt to access PPTAS Swagger
A Forbidden error should be returned

Postman

Open Postman
Don't modify client_certs (yet)
Make a call to the test method of listMoves
Because the devlocal certificate should still have 'allow_pptas' as false, you should get a Forbidden result
Back in your 'client_cert' tab, set the 'allow_pptas' flag to true
Give it a few seconds, then try the making a new request. this time there should be some results
Under the same certificate as before, set 'Allow PPTAS' to false
Attempt to access PPTAS Swagger
A Forbidden error should be returned

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 8004833c9492373c5ee0c9cd7c7944f72b6be31a


Add $destroy handler for case where using directive with ng-if

Just good house keeping.

thanks :+1:


Add esModuleInterop typescript option

Is your feature request related to a problem?
No
Describe the solution you'd like
When I install and use the tasuku library with typscript project
I have written code following this library document.
But I faced is not a function error and I founded issue point.
import task from "tasuku"

// it same below code without esModuleExport
const task = require("tasuku").default;

So I printed it and that is undefined.
Describe alternatives you've considered
Of course, it is not an important issue.
But How about the option was left in the readme.md?
I think it would be greater before then.
And I'm using this library very useful! thanks 😄
Additional context

Thanks for providing the reproduction details.
I looked into it but I think this is more of a user-land, general, TypeScript configuration issue than a tasuku documentation one (because it can happen with any ESM file importing a CJS module).
It seems the docs recommend using esModuleInterop anytime you're using ESM so you should have that on regardless of whether you're using tasuku.
There also appears to be other solutions too including: import task = require('tasuku').

Actually, I found another improvement by exporting the dts via export = task. This gives a warning:
Module<EMAIL_ADDRESS>can only be default-imported using the 'esModuleInterop' flag ts(1259)


Should --locked be a default argument for the cargo build pack?

My coworker and I ran into an unexpected issue today, a dependency in our stack had a different version of the crate then the main library but this was fine when built locally because the lock file resolved to a version that both libraries could use.
However, we found out that unlike cargo build, cargo install doesn't use the lock file by default, causing two different versions of the library to installed during build.
We fixed it by adding --locked to the build args, however it seems like that's the behaviour you would always want anyway? Since the detect requires you to have a lock file, seems surprising that we wouldn't use it.

It's funny you mention this. I was just reading something about this difference in behavior over the weekend. I knew about the --locked flag but wasn't really aware of what it did exactly (the description in --help isn't very clear).
I'm glad you mentioned this as I was leaning towards including it in the defaults as well. It sure seems like we should be trying to build with the exact set of dependencies from the lock file. Having someone else mention this a well makes me more confident to add it to the defaults.
It kind of makes me wonder if cargo install is the right choice of command to use. This is the second surprising difference between cargo build and cargo install that I've hit with the buildpack. The other was related to building a full workspace. Anyway, I'd be curious to get your thoughts on that as well. Is cargo install what you'd expect here? or would it make more sense to use cargo build?

IIRC the problem with cargo build is not knowing where the binaries end up. In cargo2nix we solved this by using json output from cargo and parsing it. Cargo install side steps that problem.
On a relatedish note though, I'd still like to find a way to build the test binaries and have them in the built image, so maybe cargo build would get me closer to that

Yes, we are pulling out binary names from cargo metadata already so it's probably not too much work to support cargo build as well. I will open a separate issue.


Add template_searchpath support

Hi!
The problem is that ClickhouseOperator doesn't support template_searchpath dag option which allows to pass filename instead of full query
Instead of:
ClickHouseOperator(
    task_id='task_1',
    clickhouse_conn_id='clickhouse_default',
    sql='SELECT * from db.some_table;' # <-- raw SQL query
)

We can write:
ClickHouseOperator(
    task_id='task_1',
    clickhouse_conn_id='clickhouse_default',
    sql='select_query.sql' # <-- filename of jinja template which is located in template_searchpath location
)

One more example how it works

Looks like it's already done https://github.com/whisklabs/airflow-clickhouse-plugin/pull/41

Hi @tiger24l7, thank you for you feedback. Yes, there is an open PR, feel free to contribute :)

My python skills are poor
But maybe, I'll try to implement this later
Would be nice if someone handle this now, if possible :)

Contribution is welcome, thank you! I will review you PR and let you know how you may enhance the code.

Implemented in #62


[Messaging] Stop Unnecessary Refresh of JWT Tokens

Summary
The focus of these changes is to cache JWT tokens used for authorization of AMQP connections and links to avoid making unnecessary requests due to network changes while the token is not near expiration.  For features like Service Bus sessions, links can be opened/closed frequently, leading to a non-trivial amount of requests to acquire tokens that are likely to remain valid for the duration of their use.
Also included is the addition of a small amount of random jitter when calculating the time that AMQP authorization should be resent; this is intended to reduce contention when a new token needs to be acquired.
References and Related

[BUG] Service bus refreshing AAD tokens a lot (#22991)

/azp run net - eventhub - tests

/azp run net - servicebus - tests

@JoshLove-msft:  I'm planning on not merging this until after the August release, so that I've got time to run the suite of long-running stress tests.    Any concerns with this not making it in immediately?

@JoshLove-msft: I'm planning on not merging this until after the August release, so that I've got time to run the suite of long-running stress tests. Any concerns with this not making it in immediately?

SGTM


Fixed loadFloodgate method

Hey, thanks for the contribution!
Other platforms' logic doesn't include the floodgate folder unless the Floodgate plugin/mod is present. I'd include that logic here, just in case.

So I should check if Floodgate-Fabric is present?

Thanks!


QbitNinja not responds many times

its happening many times that http://api.qbit.ninja/ not responds and service unavailable or too slow response/ response time out or http statuscode 503 . Can you please help in.
Please help me in starting my own node, indexer and ninja service. which repos should I clone.

I don't know, qbit is slightly retiring, you can go on https://github.com/MetacoSA/QBitNinja/ to fork it and see instructions to set it up.
That said, I would advise you now to use https://github.com/dgarage/NBXplorer  instead.
Reason is that QBitNinja is very heavy. It index everything, depends on Azure and run only on Windows.
NBXplorer does not need indexing, have better API for HD wallets and works on linux.

Yes I agree for NBXplorer, QbitNinja is unreliable now i guess.


WAU improvements implementation & new prerequisites

Review install script to bring new WAU implementations back
Added more prerequisites for standalone use (for Intune Autopilot app install for example)

Running as system, not detecting UWP Desxktop all the time...

This is installed:

System via NirSoft AdvancedRun on the left, admin on the rigtht (am I missing something?)...

Thank you, -AllUsers missing...

#93

Should we do this in WAU Winget-AutoUpdate-Install.ps1 also?
Can't reproduce it when installing WAU...

Strange. Should behave the same no?

In winget-install.ps1 you do the test for Microsoft.VCLibs.140.00.UWPDesktop every time in the function Install-Prerequisites
In Winget-AutoUpdate-Install.ps1 the test is done once under function Install-WinGet therefore we don't notice it...
...I'll add the -AllUsers in WAU too


Add support for include directive in configuration file.

Hello,
Would it be possible to add support for include in configuration file? Let's say I want to split general configuration server, acl, etc.. and user configuration into separate files.

interesting idea. we'd need to introduce some sort of preprocessing.
as usual - no firm commitments, PRs welcome.


Evaluate expressions passed header, footer, and view's styles

I want to be able to set properties dynamically across:

View style props (e.g. backgroundColor, scrollableView)
Header props
Footer props

View:
  styles:
    backgroundColor: '${flag == true ? "green" : "red"}'
  header:
    title: Home
    styles:
      backgroundColor: '${flag == true ? "green" : "red"}'
  body:
    Column:
      styles:
        backgroundColor: '${flag == true ? "green" : "red"}'
      children:
        - Content
  footer:
    styles:
      backgroundColor: '${flag == true ? "green" : "red"}'
    children:
      - Content

Global: |-
  //@code
  var flag = true;

Content:
  body:
    Spacer:
      styles:
        size: 100

this doesn't work for title as well. For header/title, the expression is evaluated only once but never updated. The whole header expression code is unfinished or just super buggy.
@vusters @vinothvino42
Example -
 header:

    title: Welcome ${ensemble.storage.players[ensemble.storage.currentPlayer].name}

will work only once. Afterwards even if I change the currentIndex or players array and assign, it won't update. Same code will update fine if it was on a Text instead of title. Super buggy!

appreciate if we start fixing these things

see the use case in #763 as well

Yes, https://github.com/EnsembleUI/ensemble/issues/763 is a duplicate of this, and for column and other widgets, this does work, it's only breaking for the View.

@hemish11 this is not right. You missed the styles under View even though both #763 and #847 mentioned View specifically. I see this code -
    LinearGradient? backgroundGradient = Utils.getBackgroundGradient(
        widget._pageModel.pageStyles?['backgroundGradient']);
    Color? backgroundColor =
        Utils.getColor(widget._pageModel.pageStyles?['backgroundColor']);
        ```
in Page.dart so it is clear that backgroundColor or gradient are not being evaluated.

Please don't just pick and choose and do this for ALL STYLES on View.

@hemish11 please do this at your earliest.

@hemish11 I checked in the fix for the backgroundColor on View. Please evaluate expressions for other properties as well


[BUG] - TxIdInMode type and constructor are not exported

*Internal
Other - Cardano API
Summary
The type and constructor for TxIdInMode are not exported in any publically accessible module. As such, LocalTxMonitorClient and queryTxMonitoringLocal are unusable.
Steps to reproduce
Steps to reproduce the behavior:

Try to compile the following Haskell module with access to the cardano-api package:module Example where

import Cardano.Api (TxIdInMode(TxIdInMode))

Expected behavior
Module compiles
Actual behavior
Module does not compile, but reports that Cardano.Api does not export TxIdInMode.
System info (please complete the following information):

OS Name: N/A
OS Version: N/A
Node version: cardano-node 1.35.3 - linux-x86_64 - ghc-8.10
CLI version: cardano-cli 1.35.3 - linux-x86_64 - ghc-8.10

Additional context
This is not the only occasion where I've encountered a problem like this in Cardano API. It would be a good idea to check in CI that the package exposes the complete closure of types and constructors needed to use the API. For example, a separate cabal project which proves via compilation that all exported functions can be called would be a way to do this.

Can confirm this, stumbled across the same issue - queryTxMonitoringLocal with LocalTxMonitoringQueryTx is therefore unusable. Please fix asap, this is crucial functionality!

I have created a fork and fixed this bug as well as adding a "QueryAllTxs" to the LocalTxMonitor. It is currently sitting at https://github.com/jonathangenlambda/cardano-node/tree/jonathan/fixlocaltxmonitor based on 1.35.3 but I have no idea to which branch I should submit this PR as I was not able to find any CONTRIBUTING.md / guidelines.

Closing this. If this is still relevant please reopen.

Why is this closed? I have not submitted my PR, because there are simply no guidelines/rules to be found anywhere in the repo. Has this been fixed by IOHK?


css parser: Show line numbers for errors.

This is a fairly major overhaul of the CSS parser to support
line numbers in error messages.
Basically, instead of passing "slices" of tokens around, we pass
indexes into the token arrays to all of our sub-parsers, which
allows them to have access to previous tokens in certain cases.
This is particularly important for errors where stuff is missing
(vs. being wrong).
In testing this out I found a few more places to catch errors.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @showell!


chore(dev-deps): update commitlint monorepo to v18 (major)

This PR contains the following updates:

Package
Type
Update
Change

@commitlint/cli (source)
devDependencies
major
^17.8.0 -> ^18.0.0

@commitlint/config-conventional (source)
devDependencies
major
^17.8.0 -> ^18.0.0

@commitlint/prompt (source)
devDependencies
major
^17.8.0 -> ^18.0.0

Release Notes

conventional-changelog/commitlint (@commitlint/cli)
v18.0.0
Compare Source

chore!: minimum node version v18 (#3644) (5b4aeaf), closes #3644

BREAKING CHANGES

drop node v14 and v16 support

chore: remove unused types

docs: prepare node update and new release

chore!: minimum TS version v5

drop TS v4 support

ci: remove node v14/16 checks

chore: adjust node types to minimal supported version

chore!: further major versions of other deps

upgrade conventional-changelog-conventionalcommits, conventional-commits-parser, conventional-changelog-atom,

docs: simplify releases and remove roadmap

17.8.1 (2023-10-20)
Note: Version bump only for package @commitlint/cli

conventional-changelog/commitlint (@commitlint/config-conventional)
v18.0.0
Compare Source

chore!: minimum node version v18 (#3644) (5b4aeaf), closes #3644

BREAKING CHANGES

drop node v14 and v16 support

chore: remove unused types

docs: prepare node update and new release

chore!: minimum TS version v5

drop TS v4 support

ci: remove node v14/16 checks

chore: adjust node types to minimal supported version

chore!: further major versions of other deps

upgrade conventional-changelog-conventionalcommits, conventional-commits-parser, conventional-changelog-atom,

docs: simplify releases and remove roadmap

17.8.1 (2023-10-20)
Note: Version bump only for package @commitlint/config-conventional

conventional-changelog/commitlint (@commitlint/prompt)
v18.0.0
Compare Source

chore!: minimum node version v18 (#3644) (5b4aeaf), closes #3644

BREAKING CHANGES

drop node v14 and v16 support

chore: remove unused types

docs: prepare node update and new release

chore!: minimum TS version v5

drop TS v4 support

ci: remove node v14/16 checks

chore: adjust node types to minimal supported version

chore!: further major versions of other deps

upgrade conventional-changelog-conventionalcommits, conventional-commits-parser, conventional-changelog-atom,

docs: simplify releases and remove roadmap

17.8.1 (2023-10-20)
Note: Version bump only for package @commitlint/prompt

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


KAFKA-13531: Disable flaky NamedTopologyIntegrationTest

Named topologies is a feature that is planned to be removed from AK with 4.0 and was never used via the public interface. It was used in a few versions of KSQL only, but was disabled there as well. While we do not want to remove it in 3.7 yet, we should disable flaky tests in that feature, that are disruptive to AK development.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Test failures are unrelated


Update actions/checkout and action/upload-artifact to node v20 versions

Fixes the node v16 and artifact v3 deprecation warnings in workflows.
Fix #339
Hardcodes Maester Test Results report in CI to use Windows-run as actions/upload-artifacts@v4 doesn't allow overwriting artifacts by default and report should always use the same OS. Windows results are currently used (slow runner so always last upload) and has more PSSA rules, so picked that one.

Report workflow will fail as it executes the workflow in main. Verified in fork, see result here: https://github.com/fflaten/maester/runs/27423735756


Mark messages read when deleting

@cketti This PR unfortunately does not work. Even though setFlag() should also update the remote message, it does not do that. Do you have an idea why?
Closes #591

Most actions in MessagingController work in two phases. The first one modifies the local message and writes information about what change needs to be done on the server into the pending_commands database table. The second phase is processing these pending actions that will make the actual change on the server. Depending on whether or not there's network connectivity that second phase may be delayed a lot.
I'm guessing the mark as read operation tries to mark the message as read in the original location while it has already been moved to the Trash folder.
I wonder if this is the right approach. We probably don't want to mark the message as read in the source folder. We want to mark it as read in the Trash folder. However, this is currently not very easy, because we reference remote IDs in pending_commands. But if we want to first move a message then mark the moved message as read we don't know the new remote ID at the time we write the pending commands to the database. To accomplish this as two separate operations we need to change the way we store pending commands. Reference the local IDs and only before performing the operation look up the remote ID (that may have changed since the time the pending command was written to the database, depending on which commands were executed in the meantime).
But really, it should be one logical operation. If moving the message to the Trash folder fails we don't want to mark it as read either. So we should probably add a new method moveMessagesAndMarkAsRead() to Backend. That should also have the benefit of not having to change the way we reference messages in pending_commands right now.

Might be related to https://github.com/k9mail/k-9/issues/4100 (comment #1)

Two issues:

Changing a PendingCommand requires a database migration to update entries stored in the old format to the new format. I think in this case I'd prefer a new PendingCommand subclass. That'll avoid the migration issue.
Your code marks the source message as read, then attempts to move it. We want to do it the other way around.

I think in this case I'd prefer a new PendingCommand subclass

I added a new subclass but I still modified the MessagingController methods like moveOrCopyMessageSynchronous to handle all 3 methods: copy, move and moveAndRead. That prevents tons of code duplications. Is this OK with you?

Your code marks the source message as read, then attempts to move it. We want to do it the other way around.

I will try to change that as soon as you are happy with the PendingCommands :)

My mails just stopped syncing after using this branch for weeks now. I found this in the logs. I have probably missed something.
09-14 01:16:57.931 30766 30785 E MessagingController: Failure processing command, but allow message sync attempt
09-14 01:16:57.931 30766 30785 E MessagingController: java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Collection java.util.Map.values()' on a null object reference
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.backend.imap.ImapBackend.moveMessagesAndMarkAsRead(ImapBackend.java:174)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.processPendingMoveOrCopy(MessagingController.java:1025)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.processPendingMoveAndRead(MessagingController.java:1003)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingControllerCommands$PendingMoveAndRead.execute(MessagingControllerCommands.java:100)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.processPendingCommandsSynchronous(MessagingController.java:829)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.syncFolder(MessagingController.java:714)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:706)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController$10.run(MessagingController.java:691)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.runInBackground(MessagingController.java:223)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController.access$000(MessagingController.java:116)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at com.fsck.k9.controller.MessagingController$1.run(MessagingController.java:166)
09-14 01:16:57.931 30766 30785 E MessagingController: 	at java.lang.Thread.run(Thread.java:764)

Above sync problem is obviously fixed by adding if (uidMapping != null) to ImapBackend.moveMessagesAndMarkAsRead. I can not explain why the mapping would be null, though. Maybe this happens if the message was moved on another device in the meantime?

Noticed another problem with this PR :P The setting does not seem to be exported/imported correctly.

@cketti Are there any open to-dos for this PR? I would love to have the feature in the official releases.

@ByteHamster: Sorry for the delay. I'll have another look this weekend.

Thanks :+1:


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/caching 9c09289...d885a80:
  > d885a80 upgrade to latest dependencies (# 649)
bumping k8s.io/apimachinery 276a8a7...276a8a7:
bumping k8s.io/api cd271e7...e08b72c:
  > e08b72c Update dependencies to v0.23.8 tag
  > 27e5860 Merge pull request # 109179 from liggitt/openapi-1.23
  > 905a7dc Drop enum tag from certificate request condition
  > a8c2f0b Merge pull request # 108740 from jiahuif-forks/automated-cherry-pick-of-# 108639-upstream-release-1.23
  > e1e0014 polish comments of non-enum values.
  > 5358347 unmark non-validated types as enums.
bumping k8s.io/code-generator fb849a7...31c00a6:
  > 31c00a6 Merge pull request # 108791 from aojea/cherry-pick-108772
  > 995ba7c client-go: update generated
  > f955c88 default kubernetes agent for generated clients
bumping knative.dev/eventing c1b0ea6...0866e62:
  > 0866e62 Report last error for unavailability periods (# 6381)
bumping knative.dev/pkg 7d607d6...9c5a731:
  > 9c5a731 bump k8s deps to v0.23.8 (# 2534)
  > 1f01575 Add fix for CVE-2022-28948 (# 2532)
bumping knative.dev/serving 35a94ff...3573163:
  > 3573163 only watch endpoints for our private services (# 13048)
bumping k8s.io/client-go 97582f2...14fa49e:
  > 14fa49e Update dependencies to v0.23.8 tag
  > a475c28 Merge pull request # 108791 from aojea/cherry-pick-108772
  > 8041ba9 Merge pull request # 109159 from wojtek-t/automated-cherry-pick-of-# 109137-upstream-release-1.23
  > a26f2df client-go: update generated
  > 0c2c708 Addresses the issue which caused # 109115
  > b6f49c1 default kubernetes agent for generated clients
  > 9b9e45f Add test for indexer with multiple values
  > ad6be0f sync: initially remove files BUILD */BUILD BUILD.bazel */BUILD.bazel Gopkg.toml */.gitattributes

/lgtm
/approve


Access Denied

Met the following problems during the execution of hack-browser-data.exe on win10 64-bit system:

Basically, the first line of Chinese says the file is currently used by another process and can not be accessed; the latter says access is denied.
A blue box would also jump out for the second message saying that the program could not be run on this computer, please enquire on the developer.
Not sure what's happening...
Looking forward to some reply.

Please check whether the Folder Protection is turned on, some ant-ivirus software has this featuer.


Updated connectors "fritz" and "radioeins"

Simplified "fritz" connector
The "is playing" status can simply be determined from a certain tag's class names.
Two types of "radioeins" players exist
The player page randomly provides one player (jwplayer) or another (lsplayer). The old (rather complicated) player is still supported. The new player has an  element.

@carpet-berlin Could you rebase master branch on latest master from upstream?


Dimensions reset upon re-launch - perhaps need a .cfg file

if we load the scan dimensions in from a config file, users won't have to re-enter these values at each launch.

Should be fixed by 542eee1.


sanitycheck: when present, point at handler.log instead of run.log

When Zephyr crashes immediately QEMU reports an error immediately. This
is immediately reported by "make run". Then sanitycheck points the user
at the output of "make run". However the error message(s) are in QEMU's
output which is in a different .log file.
To address this situation point the error message at handler.log
instead of run.log if and only if handler.log is not empty.
To reproduce here's an artificial but very simple crash:
sanitycheck --extra-args=CONFIG_TEST_USERSPACE=n
-p qemu_x86 -T tests/kernel/mem_protect/stackprot/
Signed-off-by: Marc Herbert<EMAIL_ADDRESS>

Can you file a bug for this, seems like something we might want to backport to 1.14

Are you sure @galak ? This feels like just a minor inconvenience/indirection in test logs to me. run.log does say that QEMU failed, so this issue is just wasting a bit of time looking at two files instead of one and only the first time(s), then one learns.
I looked at it because I was afraid there were a more serious bug in the handler logic but I found none, just this.

I don't think we need to backport this.


fix: support record in Object.keys

[ ] There is an associated issue that is labeled
'Bug' or 'help wanted' or is in the Community milestone
[x] Code is up-to-date with the master branch
[x] You've successfully run jake runtests locally
[x] You've signed the CLA
[x] There are new or updated unit tests validating the change

This PR fixes an issue when strictFunctionTypes: true. This code failed:
type K = 'foo' | 'bar'
const record: Record<K, boolean> = { foo: true, bar: false };
Object.keys(record).forEach((key: K) => {
});

with the error:
Argument of type '(key: K) => void' is not assignable to parameter of type '(value: string, index: number, array: string[]) => void'.
  Types of parameters 'key' and 'value' are incompatible.
    Type 'string' is not assignable to type 'K'.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: christophehurpeau sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This won't work because the object could have keys the static type isn't describing, so you can get types you didn't expect back.
See other discussion about trying to tie in Object.keys and keyof together: #12870, #13971, #24243, #25832, #26901


Need docs

How to use this with angular-js?

You provide not enough information to give you an answer. So please extend the question with information or close the issue.

You can use stackedit.js for that.


Rename blocktime to blockTime

This is missing part of https://github.com/trufflesuite/ganache-cli/pull/483 which renames blocktime to blockTime and pass that property in options while ganache-core still expects property named blocktime
This PR renames blocktime to blockTime in ganache-core.
Fixes  https://github.com/trufflesuite/ganache-cli/issues/506

Thanks for your diligence on this, @kosecki123! Apologies it took me a while to review, as I've been away for the past couple weeks dealing with an international move.
I notice there are two tests failing in the boron build. I'm fairly sure that this is an existing bug exposed by your changes here.  As a result I'll go ahead an accept this PR as-is and track down the cause of those test failures separately.
Thanks again!

Can you please make this into a release 🙏


Help Wanted: Clarify Elasticsearch vs Database search functionality

Problem space
A common question system admins ask on the Community Server is about searching for content in Mattermost, and what happens when both Elasticsearch and database search are enabled?
Example: If a system admin has a Mattermost server with Elasticsearch enabled (where ElasticsearchSettings.EnableSearching is true), but they also have database search enabled (where SqlSettings.DisableDatabaseSearch is false), how does Mattermost determine which search it is going to use?
Target audience: System administrators
Goal
Provide clear guidance and expectations on what happens when both Elasticsearch and database search are enabled in a Mattermost deployment for admins.
Delivery expectations

1 PR with all proposed changes
Update the Database configuration settings documentation to clarify that the default value of "false" will have specific consequences when Elasticsearch is enabled

Mattermost will try using Elasticsearch first, when enabled
if that fails, Mattermost tries using Bleve next, when enabled. If Mattermost falls back from Elasticsearch to Bleve, you'll see the following warning: Encountered error on SearchPostsInTeamForUser.
if both fail or both are disabled, Mattermost tries searching the database directly, if enabled.
if these fail or these are all disabled, search results will be empty
include links to both Elasticsearch and Bleve search documentation pages

Comment in the PR to request a generated preview of your work. The Docs team will add the appropriate labels to your PR.

Tech needed

RST format
Sphinx

Affected repository: mattermost/docs
Where to get help
Join the Mattermost Docs team on the Mattermost Community Server in the ~Documentation Working Group channel to discuss this ticket, or feel free to comment in this docs ticket.

Closed via https://github.com/mattermost/docs/pull/5962


Optimizated calculation of shared power of 2 in bn_gcd

https://www.openssl.org/policies/cla.html:

Every non-trivial contribution needs to be covered by a signed Contributor License Agreement (CLA) from all original authors.

It's trivial contribution, so CLA not needed.

This looks like it undoes constant time code.

This looks like it undoes constant time code.

Execution time of this function depends on size of input numbers, so it's not constant initially.

This comes from https://github.com/openssl/openssl/pull/10122, everything seems to be talking about constant time. This adds a branch, making it not constant time.
Of course it depends on the size. Assuming that's public info, that's fine.
This change will probably cause a timing leak in cases where there isn't one now.

I don't think this is a trivial contribution from a copyright viewpoint.
I'm also concerned about the loss of constant time here.
Do you have any performance figures for comparison?

Updated optimization to be consttime.
I didn't do perfomance measures, but there is 64 (32 on old CPUs) times less loop iterations so it must be faster.

I made some measures of perfomance. New code faster ~250 times when compiled with gcc -O0 on WSL:
Old | Size: 100000 Clocks per test: 27043
New | Size: 100000 Clocks per test: 1251

Test program (spoiler)
```cpp
#include
#include
#include
#include
#define SIZE (100000)
#define TESTS (1000)
static std::uint64_t r[SIZE];
static std::uint64_t g[SIZE];
template
void test();
int main() {
std::size_t i;
std::srand(123);
for (i = 0; i < SIZE; i++) {
r[i] = (((std::uint64_t) std::rand()) << 32) | (std::uint64_t) std::rand();
g[i] = (((std::uint64_t) std::rand()) << 32) | (std::uint64_t) std::rand();
}
auto start = std::clock();

for (i = 0; i < TESTS; i++)
    test<false>();

std::cout << "Old | Size: " << SIZE << " Clocks per test: " << (std::clock() - start) / TESTS << std::endl;

start = std::clock();

for (i = 0; i < TESTS; i++)
    test<true>();

std::cout << "New | Size: " << SIZE << " Clocks per test: " << (std::clock() - start) / TESTS << std::endl;

}
template
[[clang::noinline, gnu::noinline]]
void test() {
if constexpr (new_impl) {
    std::uint64_t pow2_temp, pow2_mask;
    int pow2_flag, pow2_chunk_index, pow2_shifts, i, j;
    pow2_flag = 1;
    pow2_chunk_index = 0;
    pow2_shifts = 0;
    for (i = 0; i < SIZE; i++) {
        pow2_mask = r[i] | g[i];
        pow2_temp = (pow2_flag != 0) & (pow2_mask != 0);
        pow2_flag &= !pow2_temp;
        pow2_temp = ((~pow2_temp & (pow2_temp - 1)) >> 63) - 1;
        pow2_shifts += 1uL & pow2_temp;
        pow2_temp = (i ^ pow2_chunk_index) & pow2_temp;
        pow2_chunk_index ^= pow2_temp;
    }
    pow2_shifts *= 64;
    pow2_mask = r[pow2_chunk_index] | g[pow2_chunk_index];
    pow2_flag = 1;
    for (j = 0; j < 64; j++) {
        pow2_flag &= pow2_mask;
        pow2_shifts += pow2_flag;
        pow2_mask >>= 1;
    }
} else {
    std::uint64_t mask;
    int j, bit, shifts=0, i;
    bit = 1;
    for (i = 0; i < SIZE; i++) {
        mask = ~(r[i] | g[i]);
        for (j = 0; j < 64; j++) {
            bit &= mask;
            shifts += bit;
            mask >>= 1;
        }
    }
}

}
</details>

We have a lot of test failing in CI, so I assume the result of the calculation is wrong now.

I still have some suspicions about how the compiler might make the logical ! operations non-const time. Perhaps the const_time_select...() functions could be used instead? Otherwise this looks fairly good to me.

If this is merged, we might want to reevaluate if ossl_bn_rsa_fips186_4_derive_prime() should use gcd or not.

I made some measures of perfomance. New code faster ~25 times when compiled with gcc -O0 on WSL:
Old | Size: 100000 Clocks per test: 27043
New | Size: 100000 Clocks per test: 1251

I think it would be enlightening to see the min and max times.  That would confirm constant time execution.

I will try to find the time for a proper review, but I am a bit swamped at the moment.
The first thing that came to mind inspecting the code changes, is that as a general rule of thumb, one generally wants to avoid mixing bitwise operations and the !  operator.
Quite often the !  is processed by the compiler in a way that introduces a branch in the resulting binary code, or that could be handled as a branch by the hw optimization heuristics.
I computing this kind of bitwise masks, we tend to prefer using only bitwise operators &¦^~ as that usually prevents optimization steps to unfold the computation into branches.
I might try to summon @cpereida and @bbbrumley if they can volunteer their expertise.

@landgrafhomyak Will you provide us with a CLA?

I think it would be enlightening to see the min and max times. That would confirm constant time execution.

I tested on general-purpose computer, so time of execution depends on a lot of factors:
Fixed old | Clocks: 151596 <= 213936 <= 335924
Fixed new | Clocks: 6376 <= 7781.11 <= 10398
Random old | Clocks: 156716 <= 200857 <= 311670
Random new | Clocks: 6667 <= 10194.9 <= 15905

As you can see time differs up to 2 times for same test inputs.

Test program (spoiler)
#include <cstdint>
#include <cstdlib>
#include <ctime>
#include <string>
#include <iostream>

#define SIZE (1000000)

#define TESTS (100)

volatile static std::uint64_t R[SIZE];
volatile static std::uint64_t G[SIZE];

template<bool new_impl>
void test(std::uint64_t *r, std::uint64_t *g);

void fill(std::uint64_t *r, std::uint64_t *g);

void measure(std::string name, bool regenerate, void (fn)(std::uint64_t *, std::uint64_t *));

int main() {

  std::srand(123);

  fill((std::uint64_t *) R, (std::uint64_t *) G);

  measure("Fixed old", false, test<false>);
  measure("Fixed new", false, test<true>);
  measure("Random old", true, test<false>);
  measure("Random new", true, test<true>);
}

void measure(std::string name, bool regenerate, void (fn)(std::uint64_t *, std::uint64_t *)) {

  int i;
  unsigned long long min = -1, max = 0, sum = 0;
  for (i = 0; i < TESTS; i++){
      if (regenerate)
          fill((std::uint64_t *) R, (std::uint64_t *) G);
      auto start = std::clock();
      fn((std::uint64_t *) R, (std::uint64_t *) G);
      auto delta = std::clock() - start;
      if (delta < min) min = delta;
      if (delta > max) max = delta;
      sum += delta;
  }
  std::cout << name << " | Clocks: " << min << " <= " << (((double) sum) / TESTS) << " <= " << max << std::endl;
}

void fill(std::uint64_t *r, std::uint64_t *g) {
  std::size_t i;
  for (i = 0; i < SIZE; i++) {
      r[i] = (((std::uint64_t) std::rand()) << 32) | (std::uint64_t) std::rand();
      g[i] = (((std::uint64_t) std::rand()) << 32) | (std::uint64_t) std::rand();
  }
}

namespace const_time {
  std::uint64_t msb(std::uint64_t v) {
      return 0 - (v >> 63);
  }

  std::uint64_t is_zero(std::uint64_t v) {
      return msb(~v & (v - 1));
  }

  std::uint64_t barrier(std::uint64_t v) {
      volatile std::uint64_t u = v;
      return u;
  }

  std::uint64_t select(std::uint64_t m, std::uint64_t t, std::uint64_t f) {
      return (barrier(m) & t) | (barrier(~m) & f);
  }
}

template<bool new_impl>
void test(std::uint64_t *r, std::uint64_t *g) {
  if constexpr (new_impl) {
      std::uint64_t pow2_temp, pow2_mask;
      int pow2_flag, pow2_chunk_index, pow2_shifts, i, j;
      pow2_flag = 1;
      pow2_chunk_index = 0;
      pow2_shifts = 0;
      for (i = 0; i < SIZE; i++) {
          pow2_mask = r[i] | g[i];
          pow2_temp = (pow2_flag != 0) & (pow2_mask != 0);
          pow2_flag &= !pow2_temp;
          pow2_temp = ((~pow2_temp & (pow2_temp - 1)) >> 63) - 1;
          pow2_shifts += 1uL & pow2_temp;
          pow2_temp = (i ^ pow2_chunk_index) & pow2_temp;
          pow2_chunk_index ^= pow2_temp;
      }
      pow2_shifts *= 64;
      pow2_mask = r[pow2_chunk_index] | g[pow2_chunk_index];
      pow2_flag = 1;
      for (j = 0; j < 64; j++) {
          pow2_flag &= pow2_mask;
          pow2_shifts += pow2_flag;
          pow2_mask >>= 1;
      }
  } else {
      std::uint64_t mask;
      int j, bit, shifts = 0, i;
      bit = 1;
      for (i = 0; i < SIZE; i++) {
          mask = ~(r[i] | g[i]);
          for (j = 0; j < 64; j++) {
              bit &= mask;
              shifts += bit;
              mask >>= 1;
          }
      }
  }
}

@landgrafhomyak so the idea is to first identify the number of shared LSB zero words in constant time, multiply that by the word size, then work on the sub-word zero bits only on that specific word, instead of every word along the way?

Will you provide us with a CLA?

Sent.

idea is to first identify the number of shared LSB zero words in constant time, multiply that by the word size, then work on the sub-word zero bits only on that specific word, instead of every word along the way?

Yes.

In CI of last commit one check failed because of fetch issues:
fatal: unable to access 'https://github.com/ngtcp2/nghttp3.git/': Failed to connect to github.com port 443 after 133642 ms: Connection timed out

idea is to first identify the number of shared LSB zero words in constant time, multiply that by the word size, then work on the sub-word zero bits only on that specific word, instead of every word along the way?

Yes.

OK yea, that seems clever :)
Given the nature of the change, I would suggest adding test cases here, such that one of the middle words of one and both arguments are zero, aligned and unaligned. Like
A = deadbeefdeadbeef0000000000000000cafebabecafebabe
B =<PHONE_NUMBER>3456780000000000000000abcdabcdabcdabcd

Then maybe sth like
A =<PHONE_NUMBER>21432100000000000000001234123412341234abcdabcdabcdabcd
B =<PHONE_NUMBER>896789987698769876987600000000000000004321432143214321

The "LSB word" test cases are already well-represented in the corpus.

Thank you for adding the unit tests! I think this is a solid contribution.

Commits to be squashed when merging.

This pull request is ready to merge

Squashed and merged to the master branch. Thank you for your contribution.


room list should warn rooms with unsent msgs

! in a red badge?

duplicate https://github.com/vector-im/vector-ios/issues/206


add termlist link

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

/LGTM

/merged


[FEAT REQ] Compact mode

Hi, would you consider having a "compact mode" like this?
Heavily inspired on good'old bull-arena Im in the process of replacing by this.

I could be able to implement this myself if you are willing to merge if done right.
Im also planning adding multiple job selector, retry / delete buttons and sorting options, yeah all pretty much the features present on bull-arena still missing here.
Thanks.

Hi, thank you for the feature request.
What is the motivation for this compact mode?

What is the motivation for this compact mode?

Basically to have a better overview of the jobs awaiting or being injected, it is (in my opinion) easier to see and handle when they are just a list of names than having the whole job expanded because you probably only want to know the full detail of a certain job on request (click and expand). You can only have like 2 or 3 jobs at quick sight even on large screens at the moment.
Just as a remainder this is how it looks like in bull-arena (ugly, but pretty functional tbh):

hey @felixmosh I started working on this, please have a look at this very initial Draft: https://github.com/felixmosh/bull-board/pull/687


Release notes for 1.24.0

I changed the style in the new features section after consulting with chatgpt about the content. If you find it weird, I am willing to revert them. 😁

All comments are addressed. Let me merge this PR since site build passed. I will proceed with the release process once all CI builds in the main branch finish successfully.


[Bug] doom/help opens empty buffer

Describe the issue
When tying SPC h D, a buffer opens for a new file ~/.emacs.d/docs/index.org
The only file that exists in docs is api.org. Is the keybinding wrong and there is not index.org on purpose? Or is the keybinding intended and the index.org does not exist (yet)?

Yeah, I think it's the latter.
doom/help was added in April, and I'm pretty sure the docs haven't improved a lot since then. It's WIP :)

docs/index.org simply doesn't exist yet. I'll keep this thread open until it's up.

As of 38bed2d this is resolved. Let me know if that isn't the case and I'll reopen the issue. Thanks for bringing it to my attention!


caffe2 + python layer?

Hi,
I couldn't find out if/how caffe2 supports python layers for the data and loss functions.
is there any example on this?
since https://github.com/BVLC/caffe/issues/2936 , caffe supports multi-gpu python layers which is very nice
any tip is helpful :)

Yeah, we do support python operators - see this for a few examples:
https://github.com/caffe2/caffe2/blob/master/caffe2/python/python_op_test.py
However, as you suspected, the python operators are inherently serialized right now due to GIL. The other C++ operators will run in parallel if you use net types such as DAG, though.

thanks @yangqing for the answer.
as you know the gil restrictions are not easy to solve. however a good strategy to parallelize was implemented in https://github.com/BVLC/caffe/pull/4563
a traincaffe2.py can be of great intrest !


ElementLifecycle.defunct

I'm getting the following error when running my Flutter app, and it said to report it as a bug.
The following assertion was thrown while finalizing the widget tree:
flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 4622 pos 12: '_lifecycleState
flutter: != _ElementLifecycle.defunct': is not true.
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:

Hi @Polibuzz, please provide a complete minimal reproducible code sample so that we can investigate this.
Please also provide the output of flutter doctor -v.
This error usually indicates that you're calling setState after a widget has been disposed. You'll need to check if the widget is mounted before you can call setState in that case by doing something like
if(mounted) {
	setState(() {});
}


feature request: 2d vector graphics export

Hi,
I just discovered your software as a replacement for OpenScad, which I cannot run on my company mac "because the developer cannot be verified".
ShapeScript seems very nice but I am only working with laser cutting, not with 3D print. Laser cutting requires export of 2D geometry, typically to PDF. You can see how OpenSCAD does it. They only export what crosses the x-y plane when you export to pdf.
I will buy the export option if you ever get round to adding a 2d vector graphics export. Pdf, svg, whatever...
Best of luck and thank you for the excellent documentation that you created.
Simon

Edit: I meant svg, which is a 2D vector format, not stl.

Hi Simon,
I've been looking into this feature and it seems very doable. It seems with OpenSCAD what they actually do is require you to use a projection() command to flatten the scene, then export as SVG/PDF.
I think it's actually going to be simpler for ShapeScript to implement it as you suggested, where anything crossing the XY plane will be converted to a path and everything else is discarded. Do you think that would be sufficient for your requirements?
Also, would you be interested in beta testing the feature before I release it?

You are right. I must have misremembered how it was done in OpenSCAD. This would absolutely be sufficient for my needs.
I would be happy to beta-test. I must say, however, that this is a hobby for me and I sometimes I don't work with 3D models for months at a time. If this is ok, for you then sign me up :)

@mrmasterplan if you send the email you use for your App Store account to<EMAIL_ADDRESS>I'll send you an invite for the beta program.

@mrmasterplan the SVG export feature is included in the latest ShapeScript release on the App Store.


Update datafiles

Created using the export_names() and export_taxa() functions in https://github.com/JelleZijlstra/taxonomy/blob/542195638da268b64fb1af28b61aca4f8f95c7e9/taxonomy/db/export.py
I gzipped the files because hesperomys.csv uncompressed is >100 MB.

@JelleZijlstra thank you!
Just wondering: as you named taxa.csv.gz , would it be consistent to rename hesperomys.csv.gz -> names.csv.gz ?

Yes, that would be better.

Ok! I'll rename the file.
btw - I am hoping to retire this repository at some point whenever you have a compatible data publication to point to. I see this repository as a way to get started with our integration / collaboration.


Updating documentation to clarify externalUrl difference for Grafana

What is missing?
The documentation on exposing the Prometheus/Grafana/Alertmanager dashboards is a bit vague about setting the external URL for Grafana, or more specifically, does not mention that this happens in a slightly different way than the Prometheus/Alertmanager approach.
Why do we need it?
For people familiar with the CRDs for Prometheus and Alertmanager this might be immediately clear, but as a newcomer to this operator and jsonnet, I wasted a bit of time figuring out what I was doing wrong. By referencing this directly in the documentation, others might avoid the same pitfall.
Environment
Not applicable

kube-prometheus version:
Not applicable

Anything else we need to know?:
I'll create a PR that updates the documentation, making a clear mention of the difference.

I think since the PR was merged, we can close this now. Thanks for your contribution! :)


Harbor OVA signed by invalid cert

The harbor 1.5.0 OVA is packed with an invalid cert. It is not possible to deploy it through vSphere at the moment.
https://www.dropbox.com/s/6vjw6a8d1h1tpq9/Screenshot 2018-07-09 15.38.08.png?dl=0
https://www.dropbox.com/s/bkkwje8puoisjsj/Screenshot 2018-07-09 15.40.41.png?dl=0

Is there a temporary fix for this issue?

@LinAnt I'd suggest using the offline installer, instead of the .ova, we are considering to drop the support of .ova

@LinAnt I was able to get the OVA to deploy after downloading the VMware OVF tool
I removed the cert using the following command and it deployed
kendrickc-m01:VMware OVF Tool kendrickc$ ./ovftool --skipManifestCheck /Users/kendrickc/Desktop/harbor-v1.5.0.ova /Users/kendrickc/Desktop/harbor-v1.5.0-nocert.ova
Opening OVA source: /Users/kendrickc/Desktop/harbor-v1.5.0.ova
The manifest does not validate
Opening OVA target: /Users/kendrickc/Desktop/harbor-v1.5.0-nocert.ova
Writing OVA package: /Users/kendrickc/Desktop/harbor-v1.5.0-nocert.ova
Transfer Completed
Completed successfully

I just installed it like reasonerjt suggested, thank you for the information. It might come in handy in the future 👍


Typescript version

Are there any plans of creating a typescript version of this repository, our team would really need it!
I have seen various inofficial forks but they are often outdated and not working properly.
Thank you!

We're going to build this into our cli and then maybe use that to also generate a skeleton. There are several other higher priority items for the CLI right now though.

https://github.com/aurelia/cli/issues/215


fix(interactive): Drop unused classes and modules in groot

Drop unused classes
Drop lgraph

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.79%. Comparing base (e6c922c) to head (1c2d7fe).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3577   +/-   ##
=======================================
  Coverage   27.79%   27.79%
=======================================
  Files         178      178
  Lines       16235    16231    -4
=======================================
- Hits         4512     4511    -1
+ Misses      11723    11720    -3

Files
Coverage Δ

python/graphscope/client/connection.py
37.09% <ø> (+0.37%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c922c...1c2d7fe. Read the comment docs.


Add support for multiple clocks with different time zones

Fixes #32
Add support for multiple clocks with different time zones.

src/clock/app.clock.tsx

Update to support multiple clocks with different time zones.
Modify the useEffect hook to handle multiple clocks.
Add a new state to manage multiple clocks.

src/setting/pages/clock/clock.setting.tsx

Update to allow setting multiple time zones for the clocks.
Modify the useEffect hook to handle multiple time zones.
Add a new state to manage multiple time zones.
Add a button to add new clocks.

electron/main.ts

Update to initialize multiple clock windows.
Modify the onAppReady function to handle multiple clocks.
Add a new function to create multiple clock windows.

electron/store.ts

Update to define settings for multiple clock widgets.
Modify the ClockSettingStore interface to handle multiple clocks.
Add a new state to manage multiple clock settings.

thanks for taking the time. but adding multiple time zones like this isn't a good idea. It will likely introduce many bugs into the application. A better approach would be to ask the user to select multiple time zones by default and provide templates that support multiple time zones.


Add the crazy car chassis

I need to finish the crazy car chassis so that it can be added to the snow speeder.

Yeah I've abandoned this idea.  We need to find something else to be the mobile base.


Not able to set cursor width

I tried using this but it's not working -
.cursor-node {
width: 6px !important;
}

I am able to set my cursor width by adding that CSS into config.termCSS. It needs to go in there because you're styling content in the terminal window. If you're putting it in config.css that's only for styling the main application window which wraps around the terminal itself.

@insanityfarm thanks, it worked :dancer:

@akashnimare @insanityfarm Which version of Hyper did you use? I can't make it work.
My .hyper.js:
module.exports = {
  config: {
    // ...
    termCSS: '.cursor-node { width: 6px !important; }'
  },
};

Hyper version: 2.0.0 (stable).


Monit: Service poll times in Webinterface

Hello community,
we use Monit for monitoring the VPN connections, which also works perfect.
Now it is the case that we only want to activate the monitoring during the day (between 7 a.m. and 6 p.m.). In other words, no messages should be sent at night if a failure is detected.
If I change the configuration file manually from the shell the changes are overwritten from the webinterface.
It would be nice if you could implement the service poll time configuration into the webinterface.
https://mmonit.com/monit/documentation/monit.html#SERVICE-POLL-TIME
Thank you!

#5244 was merged and will be available with 22.1 at the very latest.


Add timepicker field

How do I add timepicker field to the available options on the left panel?

It needs to be added.
Behind the scene it uses angular formly but easy form generator adds an upper layer. So the result is adding a new control can't be automatic...
I refactored code to use angular js 1.5+ components so that each control is a component: controls source.
It simplifies the process of adding new controls.


Error during SIGTERM shutdown: 1 active connections still exist after waiting for 0s

Situation
Hello, I saw many thread regarding this issue while using sqlproxy as side car in Kubernetes however, it seems that the "issue" is still here even after a couple of years (based on github issue's dates).
Question
What I would like to know is if there is a real proper solution to handle container termination (and avoid any critical output in GKE workload logs)?
Additional Context
I would like to add that this critical log (SIGTERM related) Error during SIGTERM shutdown: 1 active connections still exist after waiting for 0s is happening on gcr.io/cloudsql-docker/gce-proxy:1.22.0 when my autoscaler downscale my deployment
apiVersion: apps/v1
kind: Deployment
metadata:
  name: myApp
  namespace: foobarr
  labels:
    ...
spec:
  replicas: ...
  selector:
    matchLabels:
      ...
  template:
    metadata:
      labels:
        ...
    spec:
      containers:
        - name: sqlproxy
          image: gcr.io/cloudsql-docker/gce-proxy:1.22.0
          command: ["/cloud_sql_proxy",
                    "-instances={{ .Values.pgDbInstance }}",
                    "-verbose=false",
                    "-log_debug_stdout=true"]
          resources:
            requests:
              cpu: 400m
        - name: myApp
          image: myAppImage
          env: ...

Thanks for any relevant feedback :)

There's the CLI flag term_timeout that you can use to give the proxy some time to shut down active connections.
For more context, see https://github.com/GoogleCloudPlatform/cloudsql-proxy/issues/128#issuecomment-453213130.


feature: represent char arrays as strings in json

Hello,
This feature allows one dimensional array to be represented as string in json.
example output:

g++ --std=c++17 m.cpp

{
    "value0": {
        "name": {
            "value0": 97,
            "value1": 100,
            "value2": 97,
            "value3": 109,
            "value4": 0,
            "value5": 0,
            "value6": 0,
            "value7": 0
        }
    }
}

g++ -DCEREAL_NAMED_VARIANT --std=c++17 m.cpp

{
    "value0": {
        "name": "adam"
    }
}

multidimensional array would look like:
{
    "value0": {
        "name": {
            "value0": "adam",
            "value1": "mada"
        }
    }
}

code example:
https://gist.github.com/miartad/83ff9033da1080e55103e12e7763c772

What's the point of not using a std::string to begin with?
I think this pull request should be rejected since:

It changes global behavior based on a preprocessor directive.
Its benefit is dubious.

In my use case I'm using fixed size char arrays to represent strings because std::string allocates on heap. I guess it is a niche use case and will be deprecated when c++ std has some kind of support for stack allocated strings, which I dont think it currently has.

In my use case I'm using fixed size char arrays to represent strings because std::string allocates heap. I guess it is a niche use case and will be deprecated when c++ std has some kind of support for stack allocated strings, which I dont think it currently has.

C++ does support this already through polymorphic memory resources, see std::pmr::string.  So I guess the correct approach would to support those natively in cereal.

std::string is stack-only for short strings (SSO).
If used in a loop, put the string outside the loop and clear it once per iteration, this removes most heap allocations from the loop body.
std::string_view can be put on arbitrary binary storage.


Feedback on first_test_herpetology_one_user

Thanks for this first data input. I browsed through the file, here are my remarks:

Presence of non-Dwc terms:

The following terms are not Darwin core terms:

typekid
typeactid
typemid
act_occrem
kleed_occrem
met_occrem
act_samplingprotocol
met_samplingprotocol

typekid, typeactid and typemid are the respective id's from database tables type_kleed, type_activiteit and type_determination_method.  These id's have been translated to a vocabulary for the mapping of the Darwin Core fields shown in the table below. The content of a Darwin Core term can be a compilation of id's from type_kleed and/or type_activiteit and/or type_determination_method, this is why act_occrem, kleed_occrem, met_occrem(for occurrenceRemarks), act_samplingprotocol and met_samplingprotocol (for samplingProtocol) have been created.

id
identificationRemarks
lifeStage
occurrenceRemarks
samplingProtocol
reproductiveCondition
behavior

typekid

x
x

x

typeactid

x
x

x

typemid
x

x
x

accessRights: the current link https://www.natagora.be/usage-des-donnees does not work (already discussed this)

There should be no dataGeneralizations in the datasets: all locations should be point coordinates and not generalized to a 5x5km UTM grid

decimalLatitude and decimalLongitude are not in the correct format. now valeus like 507098773 and<PHONE_NUMBER>43018 are present, should be something like 50.7098 and 5.6765

Small note on the coordinates: please use 5 decimals (always, even when 0).

Those points have been taken into account. Nevertheless, as discussed, I temporally readded the fields TypeKid, typeActid, TypeMid to allow the checking of the values of the computated fields occurrenceRemarks and samplingProtocol.
To give the lighter dataset possible I only selected one line from each combination of the fields TypeKid, typeActid, TypeMid (along with their combination frequency as given by the count nombre_cas). Lines are ordered from most frequent to rarest combinations.

Closing issue, for a broader discussion on the fields typeKid, typeActid and typeKid, see #5 #6 and #7


Suppression of warnings and (optionally) output

Addresses #105
Some users have mentioned that it would be useful to suppress the output of songbird.multinomial, including the TensorFlow deprecation warnings and tqdm progress bar. This PR should address most of these issues.
make test passes on my build (added a couple tests of the new functionality).
Main changes

Filter out some of the more obnoxious warnings when importing TensorFlow and biom.
Add silent flag to songbird.multinomial, allowing users the option of suppressing both the TensorFlow logging warnings and the tqdm progress bar.

See this SO question and this GitHub issue. Note that the latter apparently works only on TensorFlow 1.14.0. If/when this requirement is updated in Songbird, we may need to come back to this issue.
Python Warnings
Python FutureWarnings are now all filtered regardless of silent flag.
RuntimeWarnings also suppressed in standalone CLI.
$ songbird multinomial \
	--input-biom data/redsea/redsea.biom \
	--metadata-file data/redsea/redsea_metadata.txt \
	--formula "Depth+Temperature+Salinity+Oxygen+Fluorescence+Nitrate" \
	--epochs 10000 \
	--differential-prior 0.5 \
	--summary-interval 1 \
	--summary-dir results

Old behavior
/miniconda3/envs/evans_fxr/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/miniconda3/envs/evans_fxr/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
.
.
.
/miniconda3/envs/evans_fxr/lib/python3.6/site-packages/biom/table.py:4049: FutureWarning: SparseSeries is deprecated and will be removed in a future version.
Use a Series with sparse values instead.

    >>> series = pd.Series(pd.SparseArray(...))

See http://pandas.pydata.org/pandas-docs/stable/user_guide/sparse.html#migrating for more.

  for r in self.matrix_data.tocsr()]
/miniconda3/envs/evans_fxr/lib/python3.6/site-packages/biom/table.py:4052: FutureWarning: SparseDataFrame is deprecated and will be removed in a future version.

WARNING:tensorflow:From /miniconda3/envs/evans_fxr/bin/songbird:173: The name tf.Session is deprecated. Please use tf.compat.v1.Session instead.

2020-01-17 14:06:30.183343: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
WARNING:tensorflow:From /miniconda3/envs/evans_fxr/bin/songbird:176: The name tf.set_random_seed is deprecated. Please use tf.compat.v1.set_random_seed instead.
.
.
.
WARNING:tensorflow:From /miniconda3/envs/evans_fxr/lib/python3.6/site-packages/songbird/multinomial.py:163: The name tf.train.Saver is deprecated. Please use tf.compat.v1.train.Saver instead.

  0%|                                                            | 0/80000 [00:00<?, ?it/s]

New behavior
WARNING:tensorflow:From /Users/gibs/projects/songbird/scripts/songbird:199: The name tf.Session is deprecated. Please use tf.compat.v1.Session instead.

2020-01-17 14:35:40.991584: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
WARNING:tensorflow:From /Users/gibs/projects/songbird/scripts/songbird:202: The name tf.set_random_seed is deprecated. Please use tf.compat.v1.set_random_seed instead.

WARNING:tensorflow:From /Users/gibs/projects/songbird/songbird/multinomial.py:75: multinomial (from tensorflow.python.ops.random_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use `tf.random.categorical` instead.
WARNING:tensorflow:From /Users/gibs/projects/songbird/songbird/multinomial.py:86: The name tf.random_normal is deprecated. Please use tf.random.normal instead.
.
.
.
WARNING:tensorflow:From /Users/gibs/projects/songbird/songbird/multinomial.py:167: The name tf.train.Saver is deprecated. Please use tf.compat.v1.train.Saver instead.

  0%|                                                                | 0/80000 [00:00<?, ?it/s]

Silent flag
Both standalone and Q2 implementations can now specify whether or not to suppress output.
$ songbird multinomial \
	--input-biom data/redsea/redsea.biom \
	--metadata-file data/redsea/redsea_metadata.txt \
	--formula "Depth+Temperature+Salinity+Oxygen+Fluorescence+Nitrate" \
	--epochs 10000 \
	--differential-prior 0.5 \
	--summary-interval 1 \
	--summary-dir results \
        --silent; \
        echo "Finished"
Finished

~NOTE: To my knowledge, calling qiime songbird multinomial from the CLI defaults to not showing the tqdm progress bar. In this case, the quiet flag is redundant and provided for compatibility. Calling through the Artifact API, however, outputs the tqdm progress bar normally, so the flag can be used there.~
Turns out that you will see the progress bar from the Qiime2 invocation if you provide the --verbose option.

@gibsramen I updated the changelog about this PR --  let me know if this description looks good/bad to you.


neonLIBRARY async calls should use Task.ConfigureAwait(false)?

I believe we should be using Task.ConfigureAwait(false) pretty much everywhere in neonLIBRARY.  We probably haven't noticed issues because we haven't been working on UI apps much.
https://devblogs.microsoft.com/dotnet/configureawait-faq/#when-should-i-use-configureawaitfalse
Note that we implemented and call SyncContext.ClearAsync() sometime ago to accomplish the same thing which may be good enough.  Let's reevaluate this and then do a pass the ensure that we're calling this everywhere we need to.

Closing this: SyncContext.ClearAsync() does what we want.


Fix slow tests sometimes failing

In some situations we reloaded the workspace in the tests after having reported
to be ready. There's two fixes here:

Add a version to the VFS config and include that version in progress reports,
so that we don't think we're done prematurely;
Delay status transitions until after changes are applied. Otherwise the last
change during loading can potentially trigger a workspace reload, if it contains
interesting changes.

bors r+


notesnook: 2.6.1 -> 3.0.4

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm closing this issue to reduce noise as it is already being tracked in https://github.com/NixOS/nixpkgs/pull/260523

Since we can't use the r-ryantm PR, want to re-open this?

Just needs a bump from 3.0.4 -> 3.0.6

Just needs a bump from 3.0.4 -> 3.0.6

Hey! New PR here: https://github.com/NixOS/nixpkgs/pull/314730#issuecomment-2131939307


Add lshift to fallback list

As was mentioned in https://github.com/intel/torch-xpu-ops/issues/570#issuecomment-2263621964 __rshift__.Scalar is already in the list. Adding lshift will allow running triton unit tests without patching pytorch.

Please hold on it. We are having XPU implementation for it.

Hey guys, I have a repro in https://github.com/intel/intel-xpu-backend-for-triton/issues/1780, where lshift has to be called. If I set the env var PYTORCH_ENABLE_XPU_FALLBACK=1 globally, the repro is passing. However, if I set the env var inside the script, it is failing with the error: NotImplementedError: The operator 'aten::__lshift__.Scalar' .... Is this the expected behavior?

Resolved in #688


Cannot find name 'expect'.ts(2304)

I know this is probably out of scope for the guidebook... but my vs-code is showing the following problem with:
expect(container.firstChild).toMatchSnapshot()

Any ideas on how to get my vs-code to stop complaining about this?
As an aside I used import 'mocha' to get rid of problems and errors for describe and it.

Possible solution.
https://github.com/facebook/jest/issues/8285#issuecomment-685843704


fix: Dremio alias

SUMMARY

For some reason the 3.x version of the Dremio driver shows the dialect as dremio+flight, instead of simply dremio with the driver flight.
This PR adds dremio+flight to the list of aliases in the Dremio DB engine spec, so that Dremio shows up in the database dropdown correctly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

Tested locally, connected to Dremio:

Run Dremio locally: docker run -p 9047:9047 -p 31010:31010 -p 32010:32010 -p 45678:45678 dremio/dremio-oss
Visit http://localhost:9047/ and create an account.
Use dremio+flight://username:password@localhost:32010/?UseEncryption=false for the SQLAlchemy URI.
Run a query.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

If this has been working correctly for other drivers, wouldn't this indicate that the problem is in the Dremio driver? I'm assuming we've never had trouble with postgresql+psycopg2, despite not aliasing for it..?

@villebro yeah, the problem is in the driver. I took a look at their repo and couldn't see anything wrong, but I'm going to file a ticket about it.
Here's the odd behavior:
>>> from sqlalchemy import create_engine
>>> engine = create_engine("dremio+flight://beto:XXX@localhost:32010/dremio")
>>> engine.dialect.name
'dremio+flight'
>>> engine.dialect.driver
'dremio+flight'

On the other hand:
>>> engine = create_engine("shillelagh+apsw://")
>>> engine.dialect.name
'shillelagh'
>>> engine.dialect.driver
'apsw'


Secondary energy prices removed from the variables definition

Could I ask why secondary energy prices were removed from the variables definition files?
https://github.com/openENTRANCE/openentrance/commit/4730be9b4133f0f74e5c798e866f4e4477acd5aa#diff-9720cdd30a1b714d520da007c71b80ea771e9856553f248aaabd08d84f377adeL28
Ex: It can be quite important to know the price levels for fossil, biomass and/or synfuel based gases at secondary energy level. The same for liquids, solids and, specially, hydrogen. However, the above linked commit removed them from the db.
The less than handful entries that remained in the database do not provide enough information to deeper analysis.
Besides, the removed variables were already being in use for ECEMF analysis carried in WP1 and they are part of the variables template used by the modeling teams.
I would kindly request to the removed variables to be reinstated the database.

Thanks for raising this issue, there were some conflicts when we migrated to an updated version of the nomenclature package (with additional validation). I will reinsert the removed variables asap.


In the API types, optional structs should be pointers.

Some API fields are optional, but they should then be pointers as per:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#optional-vs-required
Expected Behavior
There's couple of structs in the APIs that are marked as optional, but they are not pointers. This means that they get filled in as empties and that causes validation errors.
https://github.com/kedacore/keda/blob/v2/api/v1alpha1/triggerauthentication_types.go#L25
https://github.com/kedacore/keda/blob/v2/api/v1alpha1/triggerauthentication_types.go#L34
And that I could then define (simplified example):
		Spec: kedav1alpha1.TriggerAuthenticationSpec{
			SecretTargetRef: []kedav1alpha1.AuthSecretTargetRef{
				{
					Parameter: "host",
					Name:      secretName,
					Key:       secretKey,
				},
			},

Actual Behavior
However, unless I add this here, it will not pass because the webhook will fail it.
		Spec: kedav1alpha1.TriggerAuthenticationSpec{
			SecretTargetRef: []kedav1alpha1.AuthSecretTargetRef{
				{
					Parameter: "host",
					Name:      secretName,
					Key:       secretKey,
				},
			},
			// HACK. Without this doesn't work.
			HashiCorpVault: kedav1alpha1.HashiCorpVault{Secrets: []kedav1alpha1.VaultSecret{}},

Steps to Reproduce the Problem

Call the API with that object, webhook will fail it saying that VaultSecret is null
But, now I'm then left with these kinds of log messages:

2020-09-17T18:50:07.737Z	ERROR	scalehandler	Error authenticate to Vault	{"type": "ScaledObject", "namespace": "default", "name": "ping-trigger", "triggerAuthRef.Name": "default-trigger-auth", "error": "Vault auth method  is not supported"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128
github.com/kedacore/keda/pkg/scaling/resolver.ResolveAuthRef
	/workspace/pkg/scaling/resolver/scale_resolvers.go:74
github.com/kedacore/keda/pkg/scaling.(*scaleHandler).buildScalers
	/workspace/pkg/scaling/scale_handler.go:306
github.com/kedacore/keda/pkg/scaling.(*scaleHandler).GetScalers
	/workspace/pkg/scaling/scale_handler.go:67
github.com/kedacore/keda/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:182
github.com/kedacore/keda/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:134

But at least I can now create the resource :)
3.
Specifications

KEDA Version: V2 Head
Platform & Version: Please elaborate
Kubernetes Version: Please elaborate
Scaler(s): Please elaborate

@vaikas good catch, we should convert those structs to the pointers. We have changed the API for v2 anyway, so it won't be a problem.

/assign
I can do this.


Convert to relative paths for all

For ga4gh/dockstore#1422
Changing the absolute paths of the test parameter file download links to relative paths.
Conversion is mostly done using an altered nodejs path module relative function.
The relative path is based on the directory of the descriptor (not the descriptor itself).  See test for expected output.
Only works with hotfix/master webservice branch currently

Codecov Report

Merging #300 into hotfix/2.1.3 will increase coverage by 0.21%.
The diff coverage is 80.95%.

@@               Coverage Diff                @@
##           hotfix/2.1.3     #300      +/-   ##
================================================
+ Coverage         60.14%   60.35%   +0.21%
================================================
  Files               115      116       +1
  Lines              3510     3549      +39
  Branches            453      460       +7
================================================
+ Hits               2111     2142      +31
- Misses             1168     1172       +4
- Partials            231      235       +4

Impacted Files
Coverage Δ

...rc/app/workflow/paramfiles/paramfiles.component.ts
50% <50%> (-4.06%)
:arrow_down:

src/app/shared/path.service.ts
86.11% <86.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cd0bd...33b0b07. Read the comment docs.

Distracting environment, might be difficult for me to understand this.
But at first blush, it seems like you're calculating the relative path.
I think you should be able to just get the relative path from the files endpoint, pending the fix https://github.com/ga4gh/dockstore/issues/1448 for test files (and maybe container files)

Trying to avoid chaining too many http requests in sequence.  All info needed is already available to calculate the relative path.