Import Pinned Folders from File Explorer

What's the Problem?
It's hard to convince people to move to Files because they have a number of folders pinned in File Explorer that they rely on every day for work. Re-pinning in Files via favorites would be time consuming and hurt adoption.
Solution/Idea
It would be great if Files could automatically import pinned folders from Files Explorer.
If a one clicks auto import isn't possible, maybe we can allow dragging of folders from File Explorer to the Favorites section in Files so it's still a bit easier. Currently we can't drag a folder from File Explorer to favorites in Files.
Requirements
Allow user to 1-button click to import all pinned folders in File Explorer
Allow user to select which pinned folder to import or not import
Files Version
Version: <IP_ADDRESS>
Windows Version
OS Version: 10.0.22000.556

Not sure if the import should be automatic, one may want to keep the Default Explorer and Files separated.
Several options are equally viable for me:

Create a button to import the favorites one time. It would just fetch the favorites from Windows and add them to the existing favorites on Files. (See the picture below for an illustration)
Create an option to choice wether add the favorites at each start of Files. It'd be an automated version of the first option.
Create a button to synchronize the favorites one time. It would get the favorites from Windows and save them over the favorites of Files.
Create an option to choice wether synchronizing the favorites at each start of Files. It'd be an automated version of the third option.
All of the above. They are not so mutually excluding actions.

On the implemantation side, it seems that retrieving the shortcuts is not a difficult task : https://stackoverflow.com/questions/49657876/how-do-i-get-a-list-of-windows-explorer-favorites-shortcuts-lnk

also #4620

Asking @yaichenbaum for approval.

We don't have plans to implement this feature. The sidebar in Files has several differences with File Explorer and we want users to reconsider their pinned items when setting up Files.

Seems in the end this got implemented in https://github.com/files-community/Files/issues/10800#issue-1507048795 😄


Replacing email logic and notifications logic by signals

Purpose :muscle:
Remove email logic and instead use django signals to send an event every time we were going to send an email.
Changes required (Database, config, etc)
Remove all SENDGRID related variables in local config files.
Links :link:
https://docs.djangoproject.com/en/3.0/topics/signals/

still work in progress, a few changes left

Ok some questions:

Can you please point me where the signals are being received? I just see the dispatch of them.
I believe we used to have Notifications that were saved on DB. Now we are not going to persists this anymore? If so, shouldn't we also be removing that class from models? db migrations?

Great point regarding Notifications. I removed the model, the view, and all the references to them.
Ref Signals, the responsibility of consuming/receiving the events will be on the developer/project using our app. On our documentation, we will specify what kind of signals are sent under which actions, so then the developer will decide whether they want to consume those signals or not.

Please do not forget to squash


[Request] Change Logs / Release Notes

Just a suggestion, it would be nice if change logs / release notes were available so we know what the changes are when the SDK is updated.
For example, https://github.com/mobfox/MobFox-Android-SDK/releases just says "minor fix", instead of mentioning nice changes like fixing permissions or adding Android O support :)
Thanks!

Hi,
Yes, you are correct, we'll do it better from now on.


Add a fake "SizeOfImage" on Linux

SOS requires us to be able to know the size of an image in memory.  This unblocks some functionality by letting us use the SizeOfImage on coredumps for this purpose.

@mikem8361 This change makes it so that SOS can use ModuleInfo.SizeOfImage in the same way that it used to use ModuleInfo.Size.  The underlying values being given out should be the same here, let me know if this doesn't resolve the problem.

Is this ready to merge?  I would like to test it (and the IThreadReader changes) with my diagnostics repo branch.

Need to fix LinuxLiveDataReader, but will push a new build first thing Monday morning.


Ignore events which don't change text input - fixes #1134

Fixes #1134.

@lisa761 Thanks for testing! Feel free to use it, if it's helpful.


Can you share a well-trained model or settings?

Hi,
I'm using this code on AVA dataset  and have encountered some problem when training.  The model converges at around 10th epoch but the prediction result is not as expected. The score of all pictures are around 5.x and also the model can not figure out which picture is better. I'm using the directly training method and have tried mobilenet / vgg16 / resnet50 / inceptionv3 but none of them works.
So could you please share the exact settings for the one used in the demo images? Or can you share the well trained models ?  Many thanks.

The trained models are available in the releases tab. However, I will not be able to train any model currently.
It seems that it is necessary to fine-tune the entire model and not just the final few layers to improve performance.


demo.ipynb: Can't satisfy requested number of frames. Extracting all frames.

Describe the bug
In demo collab when importing a .mp4 video the following message appears.
To Reproduce
Steps to reproduce the behavior:

Using your phone create a small movie of an object by turning around
Run first cell to install python stuff
Run second cell and select upload custom movie, select your .mp4 file (the one i use makes 3.4Mb)

Saving xxx.mp4 to xxx.mp4
/content
Number of frames in video: 488
Can't satisfy requested number of frames. Extracting all frames.
[17:42:31] 🎉 Done converting video to images.

Run third cell then run the cell for training, the following error appears:

Error: Data processing did not complete

Expected behavior
The images should be extracted from the video and training should be started.
Screenshots

Additional context
Would be nice to provide explanation on:

what kind of video format is supported
minimal and maximal amount of frames that the video should contain

Annoyingly colab hides the underlying errors. It is likely running out of memory, or COLMAP is failing. Try with ~100 images to see if it performs any better.

Tried with a shorter video of 168 frames, same issue.
Tried with uploaded .jpg files extracted from the video, same issue.
Then by adding redirection of output of ns-process-data command to a file:
!ns-process-data video --data $video_path --output-dir /content/data/nerfstudio/custom_data/ 2>&1 | tee Log.txt

Got the following:
Number of frames in video: 168
Can't satisfy requested number of frames. Extracting all frames.
[23:05:12] 🎉 Done converting video to images.                                                 process_data_utils.py:208
──────────────────────────────────────────────  💀 💀 💀 ERROR 💀 💀 💀  ───────────────────────────────────────────────
Error running command: colmap -h
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
colmap: error while loading shared libraries: libGLEW.so.2.1: cannot open shared object file: No such file or directory

Hmm, sounds like COLMAP failed to install on the colab machine... The provided built package is probably no longer compatible due to a colab dependency update. Here are some instructions for installing colmap on colab that you can try in the meantime  - https://gist.github.com/kwea123/f0e8f38ff2aa94495dbfe7ae9219f75c


Create an initial 'quality' STAC extension

Enabler

So that we can understand the work in validating a full LINZ STAC extension(s), we want to create a STAC extension for validation of one metadata property
Acceptance Criteria

[x] Profile created that we can use for automated validation in the Geostore
[x] Use the process and templates from the STAC community
[x] Profile can be used to validate the mandatory 'quality' extension.
[x] Includes optionalquality:horizontal_accuracy property
[x] Stretch goal to include the optionalquality:horizontal_accuracy_type property (only two values allowed)
[x] Stretch goal to add the non-mandatory property quality:description property
[x] Add a README, tests and examples for the JSON schema

Additional context
For more information on the properties to implement (still under development) see here https://confluence.linz.govt.nz/display/LIFFP/STAC+Field+Mapping and here https://confluence.linz.govt.nz/display/LIFFP/Core+and+Spatial+Metadata+Content

Tasks

[x] Use template for extension and use LINZ stac extensions repo
[x] Create README
[x] Create JSON Schema
[x] Add tests (do we need to do this?)

Definition of Ready

[ ] This story is ready to work on, according to the
team's definition

Definition of Done

[ ] This story is done, according to the
team's definition

This looks good @MitchellPaff and @l0b0, once https://github.com/linz/STAC/pull/5 is merged, this story can be closed.


Add ability to set the date for iPad Pro.

This UI could probably be improved, so this is more of a proof of concept.

We can figure out the UI later on, if needed – this is a good improvement. Thank you 👍


FinalForm: Don't handle sync submit differently than async submit

before, the formStatusChange, onAfterSubmit, reset another stuff was not executed

You can also say it's a bugfix.
but in practice we don't have many (any?) sync save handler anyway (I noticed this in a story with an sync alert)

While I doubt that this change breaks anything in existing projects, let's merge it into next to be sure.


Release .aar contains ic_launcher.png in drawable-hdpi-v4

All resources should be namespaced.
And maybe default generated resources should not be included in released builds
This will cause aapt duplicate file errors if imported into a project that has a default generated ic_launcher file in a drawable-hdpi directory.

+1 for this issue

The icon file has been removed already, so close this issue. Thanks for your feedback.


Consider separating SDK programmatic access from Blueprints

To have the SDK accessible through blueprints we're relying on UObjects. This does come at a performance cost (depending on SDK usage).
Right now, even if you were not to use blueprints, technically you still have to deal with that.

Closed in https://github.com/getsentry/sentry-unreal/pull/662


ramen https secure access to s3 storage is disabled

In the ramen-hub-operator-config configmap, the s3compatibleEndpoint has to be set to http. If set to https, it shows error:
2023-05-03T21:38:07.554Z ERROR controllers.VolumeReplicationGroup.vrginstance controllers/vrg_kubeobjects.go:343 VRG Kube object protect error {"VolumeReplicationGroup": "cpd-instance/ci", "rid": "c7216dc1-8ad5-42b9-a212-06068767a063", "State": "primary", "profile": "s3profile-cluster6-ocs-external-storagecluster", "error": "failed to upload data of odrbucket-cb7b2ca30375:cpd-instance/ci/v1alpha1.VolumeReplicationGroup/a, RequestError: send request failed\ncaused by: Put \"https://s3-openshift-storage.apps.cluster6.local/odrbucket-cb7b2ca30375/cpd-instance/ci/v1alpha1.VolumeReplicationGroup/a\": x509: certificate signed by unknown authority"}
In the ramen code, when creating s3client, the DisableSSL is set to true so the https access is disabled. DisableSSL needs to be set to false to resume the secured connection.

The error is due to certificate trust not established, specifically x509: certificate signed by unknown authority. When using s3 stores with their https end-points that have a CA signer that is not by default in the trustes CA store, this error would appear. For example in Openshift to resolve this we have these instructions.
I do not have similar steps handy for non Openshift environments, so in case you are on vanilla k8s the ramen pods need to trust the CA for https to work, and this needs to be added into the ramen pod afaict.
Disabling SSL is not a resolution we would look at for this failure, unless I am missing something.

I followed the instructions when setting up the clusters but the same issue still appears. After discussion, there are two possible ways to solve this: 1. Ramen allows secured access and takes a certificate to pass it to velero then to s3 storage in order to access the secured https endpoints of the s3 storage. 2. Modify s3 storage image to make it accessible by anyone through the secured https endpoints. The minio image needs to include the certificate and a secured route needs to be created. Pallavi may have more details on this.

Labeled low priority as the "disable SSL" setting does not seem to be disabling encrypted communication.


Add TE Connectivity as a Tier 1 sponsor

https://github.com/ML-Purdue/ml-purdue.github.io/commit/b135b5e4c5d2820b9adb77b71f75c67026d0150e


Revert: Pending IBC Transactions removal

Mintscan doesn't have support for all IBC chains. Users may like to see IBC transfers from non-supported chains (this happens often in the context of new chain airdrops).

Please add the Pending IBC transactions table to the bottom of the Assets page.

This is duplicate of #427
https://github.com/osmosis-labs/osmosis-frontend/issues/427


MSI: CurrentVersion is removed on latest Adoptium build

To reproduce

Install 8u292 with install option JavaSoft (Oracle) Registry Keys
Install 8u302 with same install option

Observed behaviour

After 292 install, entry for HKEY_LOCAL_MACHINE/SOFTWARE/JavaSoft/Java Development Kit CurrentVersion=1.8
After 302 install, this entry is not there. The child entries are there (i.e 1.8 folder and 8.0.302.8 folder)

Expected behaviour

CurrentVersion should still be set to 1.8

Screenshots

Suspected change
https://github.com/adoptium/installer/commit/e178aefa05d159b0f031ebfff3d543ee8f6103a7
https://github.com/adoptium/installer/pull/307
https://github.com/adoptium/installer/issues/300
I don't quite understand this condition
<Condition><![CDATA[JAVASOFT_CURRENTVERSION <> "1.8" AND JAVASOFT_CURRENTVERSION < $(var.ProductMajorVersion)]]></Condition>

Says if current version (installed) is 1.8 and current version is less than major version we're building (8), then set CurrentVersion. So it should work? Not sure why it doesn't or why that condition is there. But, this is a bit beyond me.
If I change it to the following, it works
<Condition><![CDATA[$(var.ProductMajorVersion) <> "8"]]></Condition>

But If I install one with the patch, with no previous install, I don't get the reg values. So I'm not sure what's going on.

@douph1 Do you have a comment on this issue? We likely need to respin the MSI's again.

This condition is here to overide the reg key only if the new major version from the running installer is greater than the previous one installed.

JAVASOFT_CURRENTVERSION

is read from the regritry.
If the new var.ProductMajorVersion is greater ( installing java17 over java16) then we overiding the reg key.
If we install java11 after java16 .. the key is unchanged.
JAVASOFT_CURRENTVERSION must pointing to the highest version.

https://www.oracle.com/java/technologies/javase/runtime-windows.html
Note that CurrentVersion is set only if the version being installed is the highest version number on the machine. For example, if JRE 1.5.0 already exists on a machine on which 1.6.0 is being installed (also called 6), then CurrentVersion will be set to 1.6. If 1.6.0 is installed first, and then 1.5.0 is installed, CurrentVersion will remain set to 1.6.

But, we can't compare numericaly 1.8 and 11, we test first if JAVASOFT_CURRENTVERSION <> "1.8" then compare 11 vs 16 for exemple.
I have fixed the wrong comparaison order "<" in 26d01e8e818d0b956e86e9746268015d11904319  but not fixed the jdk8 specific case

See linked PR #329 for the fix, you can test the artefact build via github action.

@douph1 @karianna
Same case with Temurin 8u312, if I upgrade from 292 to 312, JavaSoft->Java Development Kit->CurrentVersion=1.8 is removed.
If I do a fresh install of Temurin 312 or Semeru 312 it is set properly to 1.8. It makes me believe that the next release will be the same way. That is, If 312 is upgraded, the value will be removed but if I uninstall first, then it is fine.


remove relURL from render-image markup

this breaks relative markdown images, e.g.:
![example](images/examples.png)

doesn't work, because a / is appended, making it an absolute URL

Thanks for the pull request! 😀


Bug 1982250: (fix)InstallPlan: Do not tranisition IP to failed on OG/SA failure

In #2077, a new phase Failed was introduced for InstallPlans, and failure in
detecting a valid OperatorGroup(OG) or a Service Account(SA) for the namespace
the InstallPlan was being created in would transition the InstallPlan to the
Failed state, i.e failure to detected these resources when the InstallPlan was
reconciled the first time was considered a permanant failure. This is a regression
from the previous behavior of InstallPlans where failure to detect OG/SA would
requeue the InstallPlan for reconciliation, so creating the required resources before
the retry limit of the informer queue was reached would transition the InstallPlan
from the Installing phase to the Complete phase(unless the bundle unpacking step
failed, in which case #2093 introduced transitioning the InstallPlan to the Failed
phase).
This regression introduced oddities for users who has infra built that applies a
set of manifests simultaneously to install an operator that includes a Subscription to
an operator (that creates InstallPlans) along with the required OG/SAs. In those cases,
whenever there was a delay in the reconciliation of the OG/SA, the InstallPlan would
be transitioned to a state of permanant faliure.
This PR:

Removes the logic that transitioned the InstallPlan to Failed. Instead, the
InstallPlan will again be requeued for any reconciliation error.

Introduces logic to bubble up reconciliation error through the InstallPlan's
status.Conditions, eg:

When no OperatorGroup is detected:
conditions:
    - lastTransitionTime: "2021-06-23T18:16:00Z"
      lastUpdateTime: "2021-06-23T18:16:16Z"
      message: attenuated service account query failed - no operator group found that
        is managing this namespace
      reason: InstallCheckFailed
      status: "False"
      type: Installed

Then when a valid OperatorGroup is created:
conditions:
    - lastTransitionTime: "2021-06-23T18:33:37Z"
      lastUpdateTime: "2021-06-23T18:33:37Z"
      status: "True"
      type: Installed

Signed-off-by: Anik Bhattacharjee<EMAIL_ADDRESS>Upstream-repository: operator-lifecycle-manager
Upstream-commit: 3a3874b1e7a663742a6c839d9ff630c921d8c689

/bugzilla refresh

/retest

/retest

/test e2e-aws-console-olm

/test e2e-aws-console-olm


Input format

Hello! Thank you for your library. Can you please clarify in the README about input shape? I assume it is (height, width, channels), where height and width is limited up to 400000000 pixels total (h*w) (link), and channels are either 3 or 4 dimension of RGBA (link).

Cool, made a note of HWC ordering in the example = ) Re-open if you need more.


Crash on Startup 1.16.5 custom Modpack

Hello,
I have a crash on Startup with Backpacker 1.3.1 on 1.16.5 with 195 other mods :)
if i remove it it workes fine.
latest.log
crash-2022-09-30_12.46.12-client.txt

nvm i just saw Backpacked 2.0 doesnt work with packpacker and this is the wrong channel. sry im new to Github.


Error from API comes empty

I have implemented this project into my early work for a newly created SPA.
My successful responses come into the State of Redux as expected. But the error responses come in a empty error in the State of Redux, but the response from the API seems to look ok to me.

If you could enlightenment me about it, it good be awesome.
UPDATE: I'm using fetch driver, without a polyfill and using Google Chrome: 64.0.3282.140 (Official Build) (64-bit) in MacOS High Sierra
Thanks for this work, is pretty awesome. :-)

Maybe this behavior with Fetch has to be related: https://www.tjvantoll.com/2015/09/13/fetch-and-errors/

@pitakill This is probably serialization problem of redux dev tools. Did you try to console.log(error) in your reducer/selector/component?

@klis87 I can see clearly now. The error in the state is a Response from Fetch, so I'm figuring out how to responde with the response.json() in the onError my attempt it is:

Thank your for your time and support. :-)

So you try to use interceptors for this, this really should work but I guess it won't, at least not until I will improve interceptors in this library, which is on my list. Now you have for instance dispatch some actions in interceptors, but return value of interceptors is not taken into account yet (which is really wrong I know:)).
What you could do know is to overwrite getErrorPayload in official fetch driver before passing it to createRequestInstance - see https://github.com/klis87/redux-saga-requests/blob/master/packages/redux-saga-requests-fetch/src/fetch-api-driver.js#L39

Thank you a lot!

Works like a charm! :-)
I'm going to try to send you a PR with the changes in your comment above. :-)

Great! One thing I am a little worried about, returning only responseError.json() will include all error data which might be useful? If not, I guess it can be safely added to fetch driver itself, despite the fact it would be a breaking change :)

@pitakill Just see a new version of Fetch driver - https://github.com/klis87/redux-saga-requests/releases/tag/redux-saga-requests-fetch%400.7.0
You don't need to use response.json() anymore anywhere, just read response.data.


Detach node before making present/missing in diagnostics generator

Changes only needs the node itself, detach before rewriting to avoid having to re-create all the parent nodes.
Resolves rdar://111332992 (#1847).

@swift-ci please test

Ah, we can't detach because we're formatting... That's unfortunate 🤔

@swift-ci please test

@swift-ci please test


[Feature] Remove the red update circle once the info button is pressed

Is this feature related to existing issues?
No
What feature do you want or what suggestions do you have?
Remove the red update circle once the info button is pressed.

Are there any similar competitors that can be referenced?
No
Additional information
Regarding the FAQ entry for an offline environment, if you manually download the extension and then remove the translation packages the version that is shown when the info button is pressed is "Unknown Version" which means the red update circle will always be there.

同问

Modified as:
If you don't open the About page, it won't connect to the internet to check for new versions. The red dot has been removed.


Update s3, sdk-core, sqs to 2.20.115

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.295 to 2.20.115
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #645.


Update portable targets for the Mono 4.0 upgrade

Why does everyone always forget about PCLs? :-(
#388 broke PCLs because Microsoft.FSharp.Targets and Microsoft.Portable.FSharp.Targets are installed into 4.5 now... but Microsoft.Portable.FSharp.Targets references Microsoft.FSharp.Targets using the 4.0 path.

This change shouldn't be needed - the canonical path where the targets should be installed is indeed "C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0" (on Windows + .NET) with corresponding path on Linux/Mac or WIndows + Mono.

Also please be more explicit about "broke". How did it break? Can you post an exception that you got? Steps to reproduce?

#436 fixes the underlying problem.  I'd also like to know exactly what broke so we can add another cross-platform PCL project build to tests/projects

The 4.0 folder does not exist when installing F# from Homebrew.
$ ls /usr/local/Cellar/fsharp/<IP_ADDRESS>/lib/mono/Microsoft\ SDKs/F\#/3.1/Framework/
v4.5

See Homebrew/homebrew#41019.
How could 4.0 be the canonical path if #388 made 4.5 canonical?
Here's the error:
X.fsproj(0,0): X.fsproj: /usr/local/Cellar/mono/<IP_ADDRESS>/lib/mono/xbuild/../Microsoft SDKs/F#/3.1/Framework/v4.5/Microsoft.Portable.FSharp.Targets: Project file could not be imported, it was being imported by X.fsproj: /usr/local/Cellar/fsharp/<IP_ADDRESS>/lib/mono/4.5/Microsoft.Portable.FSharp.Targets: Project file could not be imported, it was being imported by /usr/local/Cellar/mono/<IP_ADDRESS>/lib/mono/Microsoft SDKs/F#/3.1/Framework/v4.5/Microsoft.Portable.FSharp.Targets: /usr/local/Cellar/fsharp/<IP_ADDRESS>/lib/mono/4.5/Microsoft.Portable.FSharp.Targets could not import "$(MSBuildExtensionsPath32)..\Microsoft SDKs\F#\3.1\Framework\v4.0\Microsoft.FSharp.Targets"

Hi @myfreeweb  - thanks so much for finding this problem.  The issue was that #388 was an incorrect fix - the "canonical" path I mentioned above is one that should never have been changed for proper installations of F# tools on a machine.
We should update homebrew to use the latest tag after #436 is integrated

@myfreeweb - I submitted a request to update homebrew to the corrected build here: https://github.com/Homebrew/homebrew/pull/41454

That's already in a release? Wow, great, thanks!

master here is very stable (apart from configuration changes like #388) so releasing to homebrew is just a matter of fixing and retagging.


Deployed Frontend in AWS 'Dev' has error.

Using production build when deploying to AWS 'dev' is having issue with getting value from locationStorage:
Uncaught TypeError: Cannot read properties of null (reading 'fam_cognito_region')

Also it is better in AWS 'dev' Cognito to add locally callback urls configuration so developers are easy to work with. Find a way to do this extra addition in Terraform.

    'redirectSignIn': 'http://localhost:5173/authCallback' and
    'redirectSignOut': 'http://localhost:5173/authLogout'

This is done and the PR was reviewed by Basil and merged tonight.
Some interesting discovery will be commented into #260.
Close this one.


Screenshot with docker

I deploy source with docker, server Linux, have not GPU
Like the title, I want to use a screenshot function to render the mesh texture layer, but not working
is there any way to export images without GPU?
this my source
from vedo import Mesh, settings, show

settings.screenshotTransparentBackground = True
mesh = Mesh("test.obj").texture("test-design.png").forceOpaque()

x0,x1 = mesh.xbounds()
y0,y1 = mesh.ybounds()
size = ((x1-x0)*5, (y1-y0)*5)

plt = show(mesh, size=size, zoom='tight', interactive=False)

plt.screenshot("result.png")

Linked issue

Hi,
It's quite possible, I am using vedo in this way.
You need to set everything up for offscreen rendering: there are two main ingredients

Vedo should be set to render in offscreen mode
Guest OS in the docker container needs the relevant libraries installed (e.g., see here and here. Specifically in this example we need the Mesa openGL and GLX extensions, and Xvfb to act as a virtual screen.

(I think it's maybe also possible to use OSMesa offscreen driver directly, but that requires a custom build of VTK as far as I know...)
Here is what I am using (NB I am not a docker expert so this is not necessarily optimal or anything...)

Dockerfile

FROM python:3.8-slim-bullseye

RUN apt-get update -y \
  && apt-get install libgl1-mesa-dev libgl1-mesa-glx xvfb -y --no-install-recommends \
  && apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false \
  && rm -rf /var/lib/apt/lists/*

RUN pip install vedo \
  && pip install pillow \
  && rm -rf $(pip cache dir)

RUN mkdir -p /app/data

WORKDIR /app/
COPY test.py set_xvfb.sh /app/
ENTRYPOINT ["/app/set_xvfb.sh"]

set_xvfb.sh

#!/bin/bash
set -x
export DISPLAY=:99.0
Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
#sleep 3
set +x
exec "$@"

test.py

from vedo import Sphere, Plotter, settings

settings.screenshotTransparentBackground = True

vp = Plotter(interactive=False, offscreen=True)

s = Sphere(pos=[-5, 0, 0], c="r")
vp.show(s)

vp.screenshot("./data/out.png", scale=2)

Then you can

$ docker build -t vedo-test-local .
$ docker run --rm -v /some/path/output:/app/data vedo-test-local python test.py (directory /some/path/output needs to exist)
There should be an "out.png" in the output directory.

Probably a good idea to set specific versions for your packages etc. in the dockerfile to avoid surprises later if vedo API changes or something.

@antmatyjajo thanks for the help, but server RAM is not auto-clear when the screenshot function done

Sure, no problem.
About the RAM, I don't understand what you mean. docker run --rm ... should both stop and then delete the container once the function has finished running, is that not happening?

Sure, no problem. About the RAM, I don't understand what you mean. docker run --rm ... should both stop and then delete the container once the function has finished running, is that not happening?

thank you for your help, I did it, thank you very much, if there is any other problem I will create a new issue :D


Add credential_revoked state

Pull request for Issue: 1539
@swcurran  Added the credential_revoked state.
For now I have considered only issue-credential 1.0, I should check for the record in V20CredentialExchange too.
Will do it soon. If you have any suggestions on my approach please comment below.
Questions:

Is it required raise an error if the credential record doesn't exist?
The credential state should be changed only after publishing revocation.
When publish is set to pending, what is the best way to implement this?. I'm planning to create retrieve credential records using rev_reg_id and cred_rev_id

Typically the credential exchange records will get deleted after the credential is issued, so in most use cases there will be no credential exchange record when the credential is revoked.
I'm not sure if it makes sense to add a status or tag on the credential itself with the status (issued vs revoked)?

Typically the credential exchange records will get deleted after the credential is issued, so in most use cases there will be no credential exchange record when the credential is revoked.
I'm not sure if it makes sense to add a status or tag on the credential itself with the status (issued vs revoked)?

While "typically" they will get deleted, not always, and the intention of this PR is to updated the non-deleted protocol state objects if they are not deleted.

Is it required raise an error if the credential record doesn't exist?

It shouldn't raise an error.  The credential exchange record can be deleted, and could even be deleted in between the revocation and publishing events.

The credential state should be changed only after publishing revocation.
When publish is set to pending, what is the best way to implement this?. I'm planning to create retrieve credential records using rev_reg_id and cred_rev_id

Not completely sure of the intent, but you may want to change the status to revocation_pending if publishing the revocation status will be delayed, otherwise it looks like the credential is still in issued status.  Then, when you publish revocations, you can just flip the status from revocation_pending to revoked.
Also note that there are some tests failing on this PR (formatting and unit tests).

Hi @swcurran  @ianco
For the current approach I added a revoke_credentials method in Credential Manager which retrieves credential records using revoc_reg_id and revocation_id and changes their state to credential_revoked.
This approach supports credentials records issued after this merge. As the previous credential records did not have tags to be retrieved using revoc_reg_id and revocation_id

Codecov Report

Merging #1545 (8fcb309) into main (6aceb54) will decrease coverage by 0.00%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
- Coverage   95.75%   95.75%   -0.01%
==========================================
  Files         527      527
  Lines       32306    32325      +19
==========================================
+ Hits        30936    30952      +16
- Misses       1370     1373       +3

This approach supports credentials records issued after this merge. As the previous credential records did not have tags to be retrieved using revoc_reg_id and revocation_id

I don't see any changes to TAG_NAMES here and here

This approach supports credentials records issued after this merge. As the previous credential records did not have tags to be retrieved using revoc_reg_id and revocation_id

I don't see any changes to TAG_NAMES here and here.  I am just confused by the above comment regarding cred_ex_record tags. Just to confirm in regards to cred_ex_record backward compatibility, there should be no breaking change, and only that cred_ex_record state will be updated as credential_revoked upon revocation after the merge?

Hi @shaangill025 initially I tried the tags approach but V20Cred_ex_record doesn't include values of rev_reg_id and cred_rev_id so went with a different approach.

First I retrieve IssuerCredRevRecord using rev_reg_id and cred_rev_id
extract the cred_ex_id from the record
retrieve credential record using cred_ex_id
update state of credential record


Copy URL and Share Event Details Options

Feature Description
Share option in Dashboard which will open a fragement containing options to -

Copy Event URL.
Share Event Details via Email.
Share Event Detail via Other apps.

EventBrite offer these functionalities.

Would you like to work on the issue?
Yes

I think this is trivial. Sharing right now is probably fine. Take this up later

@iamareebjamal Can I send a PR for this now ?

Sure


fix cipher suite not matching on group policy list

Group policy list is separated by commas instead of spaces and fails on the -contains check

Thanks for this fix proposal! We've been working on this same bug in parallel :) Not noticing this PR, I pushed my fix.
CheckFunctionsList is called in two ways:

#1 with  $localCiphersPath when the $list is String[] (Functions is of type REG_MULTI_SZ)
#2 with $gpolicyPath when the $list is String (Functions is of type REG_SZ)

I verified that approach proposed in this PR works for both #1, #2. But for case #1 it is not straightorwardly clear that '-match' + bool-casting can be used this way, so I find it less readable and prefer the "-split" approach (see my commit).


[Feature][Transformer] Ability to hook into transformer operations

Hi again!
I will refer to movement/scale/rotation/skew as operations for brevity.
As of right now, the Transformer handles all inputs and operations by itself, but it would be nice to be able to handle some more interesting cases. Here are the main options i'm missing, forgive me if they are already present and I simply did not find them.

Getting the group transformations.
As far as I can tell right now Transformer handles all the input and directly applies the operation to the group members, it would be useful to have a way to get the applied transformations.
Setting the group transformations.
Since Transformer applies its changes directly to the target objects, it does not expose a way to easily set any parameter from the outside.
This could be very useful in cases in which thanks to (1) we save somewhere the operations we performed to a group and then retrieve and set those same operations to a new Transformer, without having wokny wireframes.
Being able to hook inside the transform process.

It would be very useful to have a callback after the changes are computed but before the actual transform is performed, to be able to handle some more interesting logic.
Some use cases that would be enabled are:

Being able to add some constraints to the operations, for example forcing the group to be inside some bounds.
Being able to smooth out the interaction, say with a library like React Spring.
Being able to have movement and scaling snapping, as right now only rotation and skew are enabled.

Ideally, one such callback would take as input the delta of the current frame and the delta since the beginning of the event and be able to make any change to the operation.
Please excuse the very crude example.
interface IScale {
    x: number
    y: number
}

interface IDelta {
    x: number
    y: number
    scale: IScale
    angle: number
}

interface IChangeCallback {
    operation: string
    frame: IDelta
    total: IDelta
}

type IChangeCallbackFunc = (IChangeCallback) => IChangeCallback;

Let me know what you think about it

Hi @Thanzex, I would suggest you override prependTransform: https://github.com/ShukantPal/pixi-essentials/blob/70a16f9befc9d3b7ee799b8cea4bd11c8454b26f/packages/transformer/src/Transformer.ts#L1407
It emits a transformchange event already but if you want to change the applied transform itself, you would need to override it. Let me know if you need additional consulting services.

But prependTransform it private


Add heartbeat to consumer info, default LATEST if heartbeat stale [TUNA-64]

Adds heartbeat checks for the consumer. If the consumer's last heartbeat is older than the given retention_period_hours (typically 24 hours on a "free" tier), consume from the latest.
Fixes: https://saleswhale.atlassian.net/browse/TUNA-64

Just merging this myself, already tested this out. Feel free to leave reviews after merging though!


Index multiple fields.

I couldn't index multiple fields in the index of Elasticsearch using nboost-index command. My csv file contains 5 columns and I want to index all the field and search on one field. How can I achieve that in NBoost?

nboost-index is a helper to index documents with a single text column that can be ranked on with BERT.
So you can either use the --id_col and --body_col switches with nboost-index to specify a single text column to index
or index the whole csv in elasticsearch as you normally would  e.g. this link and then specify which field you want to rerank on with nboost using the  --cvalues_path and the jsonpath of the choice

I just added new documentation for the dsl. You can find it here.


Returning the correct code when per_try_timeout budget is exhausted

Title: Returning the correct code when per_try_timeout budget is exhausted
Description:
If a per_try_timeout budget is exhausted, the returned code is 503. This is arguably correct for HTTP1 but for gRPC communication a deadline-exceeded (setting grpc-status to 4) would be more accurate.

I thought sendLocalReply already does this mapping in https://github.com/envoyproxy/envoy/blob/master/source/common/http/utility.cc#L441.
@jrajahalme @dio any thoughts on this one?

I think what's happening is that when per try timeout is hit we reset the upstream request, expecting it be retried. If you run out retry attempts, it will be treated as an upstream reset and results in 503/UNAVAILABLE response.
Conceptually the overall timeout better matches the gRPC deadline concept, because you can have multiple per try timeouts without actually exceeding the deadline. The case I suspect you're running into is not reaching the overall timeout, but per request timeout until there are no more retry attempts.
I'm not sure if it makes sense to change the response code here since we're not actually hitting the overall time limit, but I can see where the confusion is coming from. WDYT?


Contributions menu: Sort function 'speak end time' needs to be reworked

Description: Currently it is not possible to sort the speakers in the contributions list according to the last speakers list. The last speakers list sort the speeches by start time. The sort function doesn't include this. But it has the option the sort by speak end time. This is not helpful at all and needs to be reworked. The sort function 'speak end time' tracks the wrong desired data and is also incoherent to the export column speech start time in the csv export file.
What should happen:

[ ] The sort function 'speak end time' should be redesigned to track the speak start time.
[ ] Speak end time should than be renamend to Speak start time.

In general the sort function should works in the same logic like the last speakers list. So please take care of for example interposed questions.

This issue should have been automatically closed with the PR together
closing it manually


[Bug] integration requires a reboot of the Home Assistant

The problem
After the computer with connected Razer Chrome devices is offline for a while, the integration requires restarting the Home Assistant, after the computer appears on the HA network. Devices switch to the unavailable status. And when you restart the Chrome integration, it requires "Restart the Home Assistant to complete the integration reboot".
Your device(s) with a problem
No response
Firmware version
3.29.00
Integration version with the issue
3,29,00
Method of the integration installation
HACS
What version and type of Home Assistant installation do you use
Supervisor 2022.10.2
Is there anything useful in the logs?
No response
Additional information
No response

Hello, @KaportsevIA,
Thanks for your feedback! :+1:
I will check, why Chroma cannot restart without rebooting HA. I will let you know whether any more info is needed from your side or when the bug fix will be released.

Hello.
Some progress? I have the same problem.

Hey,
There are quite several problems with keeping a connection between HA and Synapse API. Unfortunately, Synapse is not the most stable software ever.
But the work is still in progress and I am expecting to make Chroma integration more stable and user-friendly.

OK. Thanks for the reply.

But the work is still in progress and I am expecting to make Chroma integration more stable and user-friendly.

What's the solution in the meantime, it the only way for now to restart HA every time you want to reestablish connection with the device?

Same issue on my side. Any solution or work around by now?

Hello. Unfortunately, I had no free time to work on the Chroma integration before. I will try to solve the issues reported by the users shortly

Please, check the new version 0.3.0. The integration should now properly reconnect to your Chroma devices by itself. Also, you should be now able to reload the integration without a need to reload HA

Please, check the new version 0.3.0. The integration should now properly reconnect to your Chroma devices by itself. Also, you should be now able to reload the integration without a need to reload HA

Great so see progress is made on this, but unfortunatley after some testing it does not seem to change anything for me yet. Updated the HACS integration, anything else I need to do?


Check if length of frame is valid

Fix for #69

Before processing a frame, check if its length is valid using the range defined by the spec.
Allow endpoint to update the max frame size setting.

Brilliant stuff @jdecuyper! Great start. I've made some notes inline. =)

@Lukasa just to make sure I understand this right, when serializing a frame, we should be checking the length of the body against the maximum frame size. I think it would be nicer to apply this check when calling serialize from the send data callback. Is it okay to have serialize also return the body length?

@jdecuyper That sounds reasonable to me =)

Have that function serialize return 2 values was breaking too many existing code so I took a different approach and expose the length of the body through self.body_len.

@jdecuyper What's the status here?

Status is: will work on fixes tomorrow if that's alright :)

Sure thing. =) There's no rush, just wanted to make sure this didn't get lost! :+1:

@Lukasa
When sending a frame, the size is checked against the maximum frame size setting (which can be updated by the server). As you asked, I have also added a test for this case.

Cool! Curious to see what the fix is about =)
In the meantime I have create the PR: https://github.com/Lukasa/hyperframe/pull/2

The fix already landed, see Lukasa/hyperframe@236394736fa0b60447b7ce10965c715b0122788c.
If you rebase on top of development you should find the code you need has been vendored in from hyperframe. =D

@Lukasa the rebase worked, let me know if it looks alright to you!

This is generally good, though the commit log has gone a bit wacky. Do you feel comfortable enough in git to fix it up, or do you want me to handle that on my end?

Sorry to bother you with this, it would be great if you could help me out here and even better if you could explain how you do it (if you have some time of course). Thanks!

Of course! I'll see if I can screen record the fix.

Asciinema is pretty great fwiw

@jdecuyper The fix was easy, as you can see here. All I did was take the last commit that contained actual work from you (a0316057dfa21b2656ceee0a109df0cd31d1e8ed) and merge it into the development branch. In that video you can see me scrolling down the terminal to ensure that none of your commits are there twice, which they aren't, so we know we're good.

Alrighty, merged manually. Thanks @jdecuyper!

@Lukasa  many thanks for taking the time to explain :+1: :+1:

And btw thanks for the mentions in the v0.4.0 release notes =)


Remove check for explict access/secret key in env

This allows using an EC2 instance role if configured and fails with a permission error if not configured.

Sounds reasonable. Thanks.

Released in 0.2.1


Inline Editor structure revamp

Purpose

This PR will update the component structure of the inline edit component. The new inline edit consists of smaller component implementation of the inline edit.

Codecov Report

Merging #13732 into api-designer-hackathon will decrease coverage by <.01%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##             api-designer-hackathon   #13732      +/-   ##
============================================================
- Coverage                     64.62%   64.62%   -0.01%
  Complexity                      659      659
============================================================
  Files                          2110     2110
  Lines                         93134    93134
  Branches                      12238    12238
============================================================
- Hits                          60190    60185       -5
- Misses                        28050    28056       +6
+ Partials                       4894     4893       -1

Impacted Files
Coverage Δ
Complexity Δ

...allerinalang/test/util/client/ResponseHandler.java
65.38% <0%> (-15.39%)
0% <0%> (ø)

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
82.09% <0%> (-2.47%)
0% <0%> (ø)

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
50% <0%> (-1.67%)
0% <0%> (ø)

...et/http/actions/httpclient/AbstractHTTPAction.java
78.29% <0%> (-0.86%)
0% <0%> (ø)

...ain/java/org/ballerinalang/net/websub/hub/Hub.java
71.09% <0%> (+1.56%)
0% <0%> (ø)
:arrow_down:

...llerinalang/stdlib/socket/tcp/SelectorManager.java
71.79% <0%> (+1.7%)
0% <0%> (ø)
:arrow_down:

...va/org/ballerinalang/channels/ChannelRegistry.java
97.29% <0%> (+5.4%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae26f7e...74c5bb8. Read the comment docs.


chore(sdk): Add contextmanager support to SendManager

Fixes

Part 3 of a series of PRs for landing W&B -> W&B Import API

https://github.com/wandb/wandb/pull/5780
https://github.com/wandb/wandb/pull/5781
https://github.com/wandb/wandb/pull/5782
https://github.com/wandb/wandb/pull/5783
https://github.com/wandb/wandb/pull/5785
https://github.com/wandb/wandb/pull/5777

Description
What does the PR do?

🤖 Generated by Copilot at a73106a
Added context manager support to SendManager for easier standalone usage. This allows using with SendManager.setup(...) as sender: to create and close a sender instance with custom settings. Modified wandb/sdk/internal/sender.py to implement this feature.
Testing
How was this PR tested?
Checklist

[ ] Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Ensure PR title compliance with the conventional commits standards

🤖 Generated by Copilot at a73106a

To use SendManager with ease
You can now employ the with keys
Just pass in a setup
To tweak the instance's getup
And enjoy the context manager breeze

/fix-title


Toggle layout wrappers based on request headers

With htmx it'd be nice to be able to toggle recent layout wrapping features based on the header 'hx-request', but these values seem to be statically exported with routeConfig and not when handling the request. Opening issue here to start any discussion on being able to handle this.
Also can mention that I'm not actually using htmx in my project like this just yet, and i suppose i could render separate route with similar render function but different routeConfig.

Closing as Fresh 1.5 comes with Partials which allow htmx-style updates to send any layouts to the client. We explored some heuristics to enable/disable layouts, but ultimately always ran into the problem that it's confusing and requires a bit of machinery to make overrides and all that to work. Often there is a scenario, where you only want a particular layout to be applied and that complicates this even further.
Instead with Partials you can just import the Layout component and render that in the partial response. That seems like the best middleground of both worlds.


Add the PrometheusRemoteWrite output plugin

Is your feature request related to a problem? Please describe.
Fluent operator already supports node exporter metrics input plugin and opentelemetry output plugin in https://github.com/fluent/fluent-operator/pull/345
The popular Prometheus remote write plugin should also be supported which enables users to send node exporter metrics to remote Prometheus long-term storages such as Thanos, Cortex, Mimir, or cloud services like grafana cloud
https://docs.fluentbit.io/manual/pipeline/outputs/prometheus-remote-write
Describe the solution you'd like
And plugin called PrometheusRemoteWrite for fluentbit ClusterOutput
Additional context
No response

@tonyzaizai will work on this issue


Option to read from a specific file for tools like tfenv, tofuenv, asdf, etc

Related

https://github.com/hashicorp/setup-terraform/issues/208

Thanks @nitrocode for opening this issue and suggesting this enhancement. We will discuss this in our next weekly meeting.

Meeting notes
Case 1: default/empty
      - name: Get Terraform version
        id: terraform_version
        uses: cloudeteer/actions/get-terraform-version@main

First found:

required_version from *.tf file (already implemented) (version constraint)
File: .terraform-version
tenv?
tfenv?
tofuenv?
asdf config?
more?

Case 2: specific file
      - name: Get Terraform version
        id: terraform_version
        uses: cloudeteer/actions/get-terraform-version@main
        file: file.txt

Search for Terraform version only in file.txt.
Case 3: custom file with custom pattern
      - name: Get Terraform version
        id: terraform_version
        uses: cloudeteer/actions/get-terraform-version@main
        file: custom_file.txt
        pattern: ^version: (.*)$

Tasks

Implement .terraform-version
Implement custom pattern
Implement built-in pattern for tenv, tfenv, tofuenv, asdf configuration files


Disable phrase search

Originally coming from here https://github.com/datahq/datahub-qa/issues/170#issuecomment-376768055
We need to search words instead of phrases to get better matches as users might include various stopwords while they search like and, or, no etc...
Acceptance Criteria

[x] results with examples dataset on top http://datahub.io/search?q=Aggregation+into+UK+Gross+Domestic+
[x] results with examples dataset on top - http://datahub.io/search?q=Aggregation+UK+Gross+Domestic+
[x] results with core dataset on top http://datahub.io/search?q=the+UK+Gross+Domestic+
[x] results with core dataset on top http://datahub.io/search?q=UK+Gross+in+Domestic
[x] results with 3 datasets http://datahub.io/search?q=Mauna+Loa
[x] results with 3 datasets http://datahub.io/search?q=the+Mauna+Loa

Tasks

[x] remove phrase search

FIXED


Wrong SHA256 hash for Ova for it-IT

I would suggest to check the hash signature for the OVA that can be downloaded using the link in the documentation page when browsing as it-IT (this is the page I'm talking https://docs.microsoft.com/it-it/azure/migrate/tutorial-discover-vmware#verify-security). When you click to the link "Versione più recente" the link point to : https://go.microsoft.com/fwlink/?linkid=2140333.
After downloading the ova, and checking for hash 256 the results are different than reported.
The link for the en-US page version is point to a different resource:  https://go.microsoft.com/fwlink/?linkid=2191954. Is that due to a different ova downloaded?
Thank you
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2dc0f9e8-9503-5d8c-e597-66c629e23357
Version Independent ID: 2f6e08f6-8e07-f283-9254-c2152774dd4b
Content: Discover servers running in a VMware environment with Azure Migrate Discovery and assessment - Azure Migrate
Content Source: articles/migrate/tutorial-discover-vmware.md
Service: azure-migrate
GitHub Login: @Vikram1988
Microsoft Alias: *vibansa

@ganniaiuei Thanks for your feedback. We will investigate and update the thread.

@ganniaiuei, thank you for pointing it out to us. I am assigning this issue to content team for review.
@Vikram1988, can you please review this question and share your thoughts. Thanks.

@ganniaiuei I am looking the SHA mismatch issue and would take up the correction after reviewing the issue

@Vikram1988 Any update on this?

@SadiqhAhmed-MSFT I am still checking on this and will get back on this thread when i have an update. Meanwhile requesting @ganniaiuei to use the link  https://go.microsoft.com/fwlink/?linkid=2191954 to download the latest version of the OVA whose Hash value should match the one documented

@ganniaiuei I have updated the aka.ms link to point to the right download link now so you wouldn't have this issue henceforth

Thank you @Vikram1988.
I would ask you one last thing. Was the file that one can download from the previous link a safe ova or not ? because I’ve downloaded it and installed it.

Closing this issue since it is resolved.
#please-close


ND behavior with test_scaled_dot_product_attention.py

Seeing this test fail on both N150 and N300:
https://github.com/tenstorrent/tt-metal/actions/runs/8902134133/job/24447782333
https://github.com/tenstorrent/tt-metal/actions/runs/8885562726/job/24397601439
https://github.com/tenstorrent/tt-metal/actions/runs/8889116545/job/24406991042
I haven't been able to repro successfully on my on dev machine yet.

@cglagovichTT please re-assign if you aren't the right person to investigate, thanks :)

another failed run https://github.com/tenstorrent/tt-metal/actions/runs/8904505690/job/24453963816

seems to be fail whether clock is 800mhz or 1Ghz

I'll take a look, thanks for reproing

It's fine to disable until it's resolved

When you ran 100 times locally, is there a specific test which fails consistently or does it vary?

These seem to be the problem. Reproed on aus-glx-01 N150 at 800 MHz
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_scaled_dot_product_attention.py::test_sdpa_tt_with_program_cache[1-8-1-2048-128-k256-q128-bfp8-65-100] - assert False
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_scaled_dot_product_attention.py::test_sdpa_tt_with_program_cache[1-16-1-2048-64-k128-q128-bf16-23-100] - assert False

I've seen the error mostly in test_sdpa_tt_with_program_cache, is it ok to disable the whole test?

yes please disable

My tests passed CI, but eager unit tests 3 on N300 failed https://github.com/tenstorrent/tt-metal/actions/runs/8914556845/job/24482620568

All green after rerunning the failing test (which my code doesn't touch)

my tests were in eager test group 4 which is passing.
Locally this passed as well
pip install pytest-repeat
pytest --count=100 tests/tt_eager/python_api_testing/unit_testing/misc/test_scaled_dot_product_attention.py::test_sdpa_tt_with_program_cache -v

PR https://github.com/tenstorrent/tt-metal/pull/8061


palib: update to v1.0.4

Change-type: patch
Signed-off-by: Tomás Migone<EMAIL_ADDRESS>

@balena-ci I self-certify!


providing terminal editor during conflicts hangs the process

when providing editor like nano or (n)vim
during a cherry pick conflict resolution I never get to the listing of files
to resolve
it hangs one step before.

And waits for a stdin input, which is understandable because nvim as any terminal editor is operating in interactive mode
and expecting stdin to be continuously fed.
Since child_process.spawns default stdio option is pipe it creates an indirection layer between parent and child pipes, making nvim or any other editor hang disconnected while waiting for any input.
One way of fixing this would be to add stdio: inherit to spawn, to remove the unnecessary pipe layer and connect child process to parent io pipes.
I already tested it and it indeed works. Let me know wdyt.
Thanks

Hi @kapral18

I already tested it and it indeed works. Let me know wdyt.

Can you open a PR? Don't worry about failing test, I'll gladly help out with that.


Does clickhouse-server need to run when I only use clickhouse-client to send data?

Hello all,
I have two machines(i.e. machine A and machine B). The clickhouse-server is running on machine A to accept queries and data insertion. I use clickhouse-client to send data constantly from machine B to machine A. During testing, I realized that the clickhouse-server process is also running on machine B and it takes 500MB memory space and a little CPU usage.
Question> The machine B is only used to send data to machine A. Can I stop the clickhouse-server on machine B to save resources?
Thank you

Yes.
clickhouse-client doesn't need and doesn't use any clickhouse-server other than the server it is connected to.


Redesign how "Your maps" dashboard displays LEARN MORE content

Context
From Your maps dashboard in CARTO, extra map tiles appear with links to LEARN MORE. The text that appears here auto-rotates and comes from a template. (Yes, I know where to edit this text)

Current Result
When you click on the LEARN MORE button, a video splash screen appears.

(Template=https://github.com/CartoDB/cartodb/blob/fca87ab3b7c44529553cd1b059b0eaaa82d55004/lib/assets/javascripts/cartodb/common/map_templates.js)
If you click the back arrow, located from the upper-left hand corner of the splash screen, the following module appears:

Expected result
We would like to remove the "Create a map with a video tutorial" module, and remove the example video splash screen that appears.
Ideally, we would like to be able to just edit the descriptive text that appears in the map tile, and add a url to a Learn More button - but this may require some redesign of all these templates?
(Template=https://github.com/CartoDB/cartodb/blob/fca87ab3b7c44529553cd1b059b0eaaa82d55004/lib/assets/javascripts/cartodb/dashboard/maps/placeholder_item.jst.ejs)
Additional info
Let me and @noguerol know if you have any questions.  I have more descriptive images too, if that helps. Related to this Learn issue.

cc @juanignaciosl

We could help if needed, but this is pure frontend cc @xavijam

In short:

We remove that modal with the videos and so on.
Those "placeholder" items will be static, so max 2.
Texts will be provided by christa and they will point to any learn guide we decide.
If we need to change the icons, @CartoDB/design will provide them.

Be careful with the link to that old modal in the connect-dataset dialog.

Yes, summarizing:

We remove the two modals that come after clicking the button
We change the behavior of the button, now points to an specific guide for each map module

@csobier we need to choose the two guides and copywriting for those two modules.
@CartoDB/design we need to figure out what we do with the icon. Either we use the guide's header image in a similar fashion than maps or we choose a single icon for these guide modeules.

Maybe we can use an icon as a tutorial, learn or something like so.

We can test using the following copy and links:
Description: Merge your current dataset with another, existing dataset
Link: https://carto.com/learn/guides/analysis/join-column-from-second-layer
Description: Style your layer based on column values
Link: https://carto.com/learn/guides/styling/style-by-value

What if we use the icons we use on Learn right now to represent each category?

For me, totally makes sense!

Cool, good to go on our end. Ping us if you need anything else from us!

For new hires!

@xavijam Should I remove all video tutorial functionality? I saw the link on the connect-dataset view, but there's a lot of code around, stuff like embedding a video so you can watch it while using the app & so on.

Yes, burn it.

Shipped! 🚀


go build/get can't find vendored open-golang dependency

I've had success in the past vendoring dependencies with git submodules (e.g. in my https://github.com/mcandre/go-ios7crypt project). However, when I try to vendor open-golang in my DuckDuckGo command line launcher project, something breaks. Neither go build nor go get work for ddg.
Source: https://github.com/mcandre/mcandre/tree/master/go/ddg
Am I doing something wrong?

I was :P
HEAD now has a working vendor setup using git submodules, over and out.

Sorry I didn't address this.  Thanks for looking into this and closing the ticket @mcandre !


Getting fanin error while trying to use custom pinlocations

I'm facing an issue for an ADDER custom pb_type.
The error is:
[ -1.7e-09: -1.Error 1: in check_rr_graph: node 1080 (IPIN) at (2,2) block=ADDER1 side=BOTTOM pin=ADDER1.b[29] has no fanin.
Error 2: in check_rr_graph: node 1081 (IPIN) at (2,2) block=ADDER1 side=BOTTOM pin=ADDER1.b[30] has no fanin.
Error 3: in check_rr_graph: node 1082 (IPIN) at (2,2) block=ADDER1 side=BOTTOM pin=ADDER1.b[31] has no fanin.
Error 4: in check_rr_graph: node 1112 (IPIN) at (2,2) block=ADDER1 side=LEFT pin=ADDER1.a[29] has no fanin.
Error 5: in check_rr_graph: node 1113 (IPIN) at (2,2) block=ADDER1 side=LEFT pin=ADDER1.a[30] has no fanin.
Error 6: in check_rr_graph: node 1114 (IPIN) at (2,2) block=ADDER1 side=LEFT pin=ADDER1.a[31] has no fanin.
-11
The below is the ADDER tile:

openfpgashell.log
k6_N10_40nm_copy_open.txt
k6_N10_40nm_openfpga_proj.txt
I have uploaded the files, can you help me out?

@PradyumnaG The root of the cause is that pin location should be well considered when you define a tile whose height/width is larger than 1. To ensure every pin can be accessed by routing tracks, there are two choices:

Enable the through_channel
Use the perimeter pattern for pin location: https://docs.verilogtorouting.org/en/latest/arch/reference/#tag-<pinlocationspattern=


Problem to define objective function in numpy array

Hi!
I have some real value inputs (in numpy array) and also the corresponding observation from a black box function (also in numpy). How can construct in appropriate form in BayesianOptimization? In tutorial notebook there is an analytical function which I think is for illustration goal.
Thanks for help!

Are you able to pass inputs to your blackbox function and get one output back? All you need to make this work is to be able to define a function with named inputs:
f = lambda x, y: any_function_that_returns_a_real_number(x, y)
bo = BayesianOptimization(f, {'x': (-1, 1), 'y': (-1, 2)})
bo.maximize()

Don't mind the analytical-ness of the example function, as far as the algorithm is concerned, that function is blackbox.


Delete marketing directory

@codyseibert You can delete this directory, because this project is anyway made in Typescript. I just wanted to see how it looks and make the links go somewhere.
On this repo, they have hosted their typescript on a website called - https://vercel.com/, can you see if you can figure out how to do that?
Repo: https://github.com/joaogelado/Spammer-Purge-Web-App/tree/main/pages

Thanks, let me know the url for the vercel site @codyseibert .


Incorrect Visio file link

The visio file link on this page is marked as a .zip file, but is actually the vsdx file. Not a difficult process to change the file extension after download, but may be helpful to others if you can correct the link.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd0b3eb4-8e2b-3d18-6d58-f38aceeaef78
Version Independent ID: afa5fa74-f6be-bcf4-fea2-e84565b45ac4
Content: Use Azure Stack HCI switchless interconnect and lightweight quorum for Remote Office/Branch Office - Azure Architecture Center
Content Source: docs/hybrid/azure-stack-robo.yml
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 387446

@beheb The Visio file link does actually download a vsdx file that I'm able to open on Visio. Do you see different?
This is the hyperlink it points to: https://archcenter.blob.core.windows.net/cdn/azure_stack_robo.vsdx


[Bug] [Module Name] When creating workflows containing switch nodes in different orders, the copied workflows may lose associations.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
当按照不同顺序创建含有switch节点的工作流时，复制出来的工作流存在丢失关联关系的情况。可见文件中的gif
sw.zip
What you expected to happen

How to reproduce

Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We need put code to taskCodeMap in advance.
Can you assigned this job to me? @ruanwenjun @SbloodyS
I am willing to submit a PR.


Any plans to expand this solution for PPT, CSV and Excel files to ingrest and do for comparion of tabs in the excel/csv sheet

Motivation
A clear and concise description of why this feature would be useful and the value it would bring.
Explain any alternatives considered and why they are not sufficient.
How would you feel if this feature request was implemented?
Share a gif from giphy to tells us how you'd feel
Requirements
A list of requirements to consider this feature delivered

Requirement 1
Requirement 2
...

Tasks
To be filled in by the engineer picking up the issue

[ ] Task 1
[ ] Task 2
[ ] ...

#106 is currently being looked at. We will investigate the other file formats and get back to you. Many thanks for the question!

I've just created an issue for Excel + CSV here https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/issues/659.
Closing this issue in favour of those linked above.


Small misc updates

Purpose
Implement latest team feedback.
Proposal
One thing to note is I intentionally changed how the footer is handled:

💄(footer) anchor footer at bottom of page

remove the big bottom padding at the end of the page that was a bit
weird? I feel like it's more of a figma design thing to better view
stuff than the actual thing we want… lets match DSFR
stick the footer at the bottom of the page when there is not enough
content

Looks like this now:


fix(ci): reorder gke tags and labels variable expansions

Description
If you're really unlucky, you can get a . at the end of the tags variable, which will be substituted for - after we replace the last - with x.  GKE doesn't allow for - at the end of the string, which is why we change the last -.
See https://github.com/openshift/release/pull/47789 for a real-world example of this problem.
These changes reorders the shell expansion so we first replace all . with -, then delete the last -.
Cherry-picked from https://github.com/stackrox/scanner/pull/1513
Testing Performed
Testing the variable expansions:
# Before
❯ JOB_NAME=rehearse-47789-pull-ci-stackrox-scanner-release-2.32-e2e-tests
❯ tags="stackrox-ci"
❯ tags="${tags},stackrox-ci-${JOB_NAME:0:50}"
❯ echo "${tags}"
stackrox-ci,stackrox-ci-rehearse-47789-pull-ci-stackrox-scanner-release-2.
❯ tags="${tags/%-/x}"
❯ echo "${tags}"
stackrox-ci,stackrox-ci-rehearse-47789-pull-ci-stackrox-scanner-release-2.
❯ tags="${tags//./-}"
❯ echo "${tags}"
stackrox-ci,stackrox-ci-rehearse-47789-pull-ci-stackrox-scanner-release-2-

# After
❯ JOB_NAME=rehearse-47789-pull-ci-stackrox-scanner-release-2.32-e2e-tests
❯ tags="stackrox-ci"
❯ tags="${tags},stackrox-ci-${JOB_NAME:0:50}"
❯ tags="${tags//./-}"
❯ tags="${tags/%-/}"
❯ echo "${tags}"
stackrox-ci,stackrox-ci-rehearse-47789-pull-ci-stackrox-scanner-release-2

O.B.E - we're only supporting this change for 2.34+


Create troubleshooting guide to improve problem reporting

As it stands users do not have anything to help them troubleshoot possible problems with YTC, this results in the majority of them -which understandably lack the knowledge- coming here expressing a vague description of the problem without mentioning the browser or the script they are using. This leads to time consuming efforts to understand what is going on and, in some cases, it is a conflict caused by something external to YTC.
This is a proposal for a dedicated Help or Report problem tab in the YTC settings menu where the user will have the opportunity to learn how he can properly help here and himself on solving problems that might appear.
Structure example for when the tab is selected:

Before reporting a problem please read the following:
1 - Disable Youtube Center and see if the problem still persists.
1.a - If the problem still persists then the problem isn't being caused by Youtube Center, it might be due to either another extension/addon or a recent Youtube change. To find out which one of these is causing the problem disable all the other extensions/addons you have running and see if the problem still persists.
1.a.a - If it doesn't persist then enable each extension/addon individually until the problem returns and report to the respective extension/addon feedback page.
1.a.b - If it still persists then it is a problem created by a recent Youtube change, in which case you will have to report it in their respective forums.
1.b - If the problem doesn't persist with Youtube Center disable then report it in {Report location link here} using the reporting format provided below. Please remember to search before reporting since your problem might have already been reported and it might also have been fixed.
Browser name:
Browser version:
Youtube Center Version:
Problem description:
Please try to be as accurate as possible with the problem description and, if possible, provide examples/steps to reproduce the problem.

Remember that this is just an example to elaborate the idea, it is not required for it to be exactly like that, but as long as it is functional and easy to understand then that is all that matters. This also does not have any urgency, I know that there might be other issues that are more important to solve right now.

I've added this to the wiki, (here)[https://github.com/YePpHa/YouTubeCenter/wiki/Reporting-issues].
Also, uploading debug log, seems to be broken.


Unknown Extension: autoprefixer when creating blog

Problem
I created a new blog using middleman init MY_BLOG --template=blog, but when I try to start the server I get the following error message:
from /Users/duarte/.rvm/gems/ruby-2.7.1/gems/middleman-core-4.3.7/lib/middleman-core/extension_manager.rb:51:in `activate'
/Users/duarte/.rvm/gems/ruby-2.7.1/gems/middleman-core-4.3.7/lib/middleman-core/extensions.rb:86:in `load': Unknown Extension: autoprefixer. Check the name and make sure you have referenced the extension's gem in your Gemfile. (RuntimeError)

Any idea what could be the problem? This happens any time I use the middleman command on VSCode.
Additional information

Ruby version: 2.7.1
Middleman version: 4.3.7
OS version: MacOS 10.15.6

Can you share your Gemfile?

I am using Ruby 2.6 as 2.7 gave me errors.
On Thu, Aug 6, 2020, 18:02 Duarte Martins<EMAIL_ADDRESS>wrote:

Problem
I created a new blog using middleman init MY_BLOG --template=blog, but
when I try to start the server I get the following error message:
from /Users/duarte/.rvm/gems/ruby-2.7.1/gems/middleman-core-4.3.7/lib/middleman-core/extension_manager.rb:51:in activate' /Users/duarte/.rvm/gems/ruby-2.7.1/gems/middleman-core-4.3.7/lib/middleman-core/extensions.rb:86:in load': Unknown Extension: autoprefixer. Check the name and make sure you have referenced the extension's gem in your Gemfile. (RuntimeError)
Any idea what could be the problem? This happens any time I use the
middleman command on VSCode.
Additional information

Ruby version: 2.7.1
Middleman version: 4.3.7
OS version: MacOS 10.15.6

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/middleman/middleman/issues/2347, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG4IGLGMJFLGNYQGSLL3GDR7MR55ANCNFSM4PXAQ6SQ
.

Can you share your Gemfile?

source 'https://rubygems.org'

# Middleman Gems
gem 'middleman', '~> 4.2'
gem 'middleman-blog'

gem 'redcarpet', '~> 3.3', '>= 3.3.3'

# For feed.xml.builder
gem 'builder', '~> 3.0'

# Windows does not come with time zone data
gem 'tzinfo-data', platforms: [:mswin, :mingw, :jruby, :x64_mingw]

# For faster file watcher updates on Windows:
gem 'wdm', '~> 0.1', platforms: [:mswin, :mingw, :x64_mingw]

Looks like it's the active prefex gem, its deprecated... best we can do is wait for a middleman update, patch or use webpacker....?

Seems to have worked for me now. Unsure what changed.

Updated the template to include the gem, please try now.

Yes it works now, thank you.


bugfix: fix bug when spaces in agent path. resolve #1219

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues
resolve #1219

Bug fix

Bug description.

the agent file path with blank space would cause an error because it's encoded

How to fix?

use non-encode method

CI fails. Please fix.

Coverage decreased (-0.003%) to 13.873% when pulling 3be2414c5bd7fc77255ac89380baf078877b5437 on kezhenxu94:bugfix/1219 into eb19715f990821825759244a7543815a3ebdc8c8 on apache:master.

@wu-sheng done

Test pass on Windows.
When using this change, you can set the path of the agent to contain blank,
OS:win7,
test path :G:\agent test\skywalking. jar,
application: spring-mvc-demo

Test pass on Windows.
When using this change, you can set the path of the agent to contain blank,
OS:win7,
test path :G:\agent test\skywalking. jar,
application: spring-mvc-demo

Thanks


Object definition requires optional values

TypeScript 3.7.2
Playground link
Compiler Options:
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Input:
interface SomeObject {
  [key: string]: string
};

const foo: SomeObject = { foo: 'bar' }

const baz = foo['baz']

baz.toUpperCase()

Output:
"use strict";
;
const foo = { foo: 'bar' };
const baz = foo['baz'];
baz.toUpperCase();

Expected behavior:
I ran into a bug in production here where I've defined my own object type. It's a bit unexpected that this doesn't cause an error (but does cause a run-time error). The solution is to mark the value type as optional string? – but it seems like this should be the default behavior, you can never guarantee that this object will return a non-optional value, right?

This is why I almost always use { [k:string] : T|undefined }, if I need a string-indexed type (or Record<string, T|undefined>) instead of just { [k:string] : T } (or Record<string, T>).
It's one of those times where usability is preferred over soundness, I think.

While people creating SomeObject cannot say someObj.prop = undefined, consumers of SomeObject have to be on guard.
If you need to guarantee baz exists,
interface SomeObject {
  [key: string]: string | undefined
  baz : string
};

//Error
//Property 'baz' is missing in type '{ foo: string; }' but required in type 'SomeObject'.(2741)
const foo: SomeObject = { foo: 'bar' }

const baz = foo['baz']

baz.toUpperCase()

Playground

> const foo = { bar: undefined }
> foo.hasOwnProperty('bar')
< true

Something to note, a key can exist and still be undefined. It seems to me like the type { [key: string]: string | undefined } implies my example above.
My use-case specifically the object keys are record IDs, so they can't be encoded into the type.
IMO, If you specify a type the contains { [key: string]: T } then arbitrary lookup should always be T | undefined.
It would be cool indeed if this was the case, then typescript could know the key exists and infer T, in cases like these
Object.keys(foo).map(key => foo[key].toUpperCase())

if (key in foo) return foo[key].toUpperCase()

I have no idea how that would work, but it seems like a thing! 😀

Except, if you make foo of type SomeObject (Record<string, string>), then { bar : undefined } would not be assignable to it.

Sure, in my use case the key doesn't exist yet. I was just pointing out the difference between a nonexistent key and a key with undefined value shouldn't be represented the same in the type system (I could be wrong about this, but my example shows at least one issue with that). My point was the type Record<string, T | undefined> (or { [key: string]: T | undefined } says to me: keys that exist have values of type T | undefined.
I shouldn't specify the | undefined because arbitrary lookup of [key: string]: T is really T | undefined

See #13778

Thanks, I thought it must be well known!


Auth::attempt works, but can't login via form

Laravel Version: 5.7.27
Adldap2-Laravel Version: 5.1.1
PHP Version: 7.2.3
LDAP Type: OpenLDAP

Description:
I can login via Auth::attempt and Adldap::auth()->attempt, e.g.
Auth::attempt(['username' => 'xxxxxx', 'password' => 'yyyyyyy']);

returns true. So I thing almost everything is setup correctly. But using the login form always returns "These credentials do not match our records.".
I found out, that dd($user) in DatabaseUserProvider.php -> retrieveByCredentials()
 $user = Resolver::byCredentials($credentials);
 dd($user);

returns null using the login form, and returns $user using Auth::attempt.
$credentials are exactly the same in both cases.
Can you give me hint where to search for the problem?

Can you post your config/auth.php config file as well as your LoginController code and a snipped of your login blade view containing your username and password fields?

Thank you for your fast reply!
auth.php
<?php

return [

    'defaults' => [
        'guard' => 'web',
        'passwords' => 'users',
    ],

    'guards' => [
        'web' => [
            'driver' => 'session',
            'provider' => 'users',
        ],

        'api' => [
            'driver' => 'token',
            'provider' => 'users',
        ],
    ],

    'providers' => [
        'users' => [
            'driver' => 'ldap', // Was 'eloquent'.
            'model' => App\User::class,
        ],

        // 'users' => [
        //     'driver' => 'database',
        //     'table' => 'users',
        // ],
    ],

    'passwords' => [
        'users' => [
            'provider' => 'users',
            'table' => 'password_resets',
            'expire' => 60,
        ],
    ],

];

login.blade.php

                            {{ __('Username') }}

                                <input id="username" type="text" class="form-control{{ $errors->has('username') ? ' is-invalid' : '' }}" name="username" value="{{ old('username') }}" required autofocus>

                                @if ($errors->has('username'))

                                        {{ $errors->first('username') }}

                                @endif

                            {{ __('Password') }}

                                <input id="password" type="password" class="form-control{{ $errors->has('password') ? ' is-invalid' : '' }}" name="password" required>

                                @if ($errors->has('password'))

                                        {{ $errors->first('password') }}

                                @endif

loginController.php
<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use Illuminate\Foundation\Auth\AuthenticatesUsers;
use Illuminate\Http\Request;

class LoginController extends Controller
{

    use AuthenticatesUsers;

    protected $redirectTo = '/home';

    public function __construct()
    {
        $this->middleware('guest')->except('logout');
    }

    public function username()
    {
        return 'username';
    }

}

I got it on my own. I just set up new laravel project with these configuration and somehow everything ist working now!

Awesome! Glad you were able to resolve it :smile:. Apologies for my late response.


need we update "clades.tsv" file if new clades are classified?

Hi @liamxg, yes, when new clades get defined, you need to update the clades TSV file accordingly and re-run the workflow to reflect that change.

@liamxg If you want the latest SARS-CoV-2 clades, then you can follow the ncov workflow change log to see when new clades get mentioned. You can also check for updates to the emerging lineages file (which is in the same format as the clades.tsv in this repo) or the Nextstrain clades file.


Failed to exec deploy-storybook script

Describe the bug
No longer able to deploy to GH Pages after updating to react-scripts 4.0.1 Previously I was able to simply run npm run deploy-storybook. Now when running the deploy command it fails when building -storybook. It fails at 92% of build process on chunk asset optimization TerserPlugin.
To Reproduce
Using react-scripts 3.4.4 storybook build correctly
Updating to react-scripts 4.0.1 storybook build fails which also prevents deploying to gh pages
Expected behavior
Successfully builds and deploys updates to GH Pages
System
OS: macOS 10.15.6
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 12.12.0 - ~/.nvm/versions/node/v12.12.0/bin/node
npm: 6.11.3 - ~/.nvm/versions/node/v12.12.0/bin/npm
npmPackages:
@storybook/addon-actions: 6.1.21 => 6.1.21
@storybook/addon-essentials: 6.1.21 => 6.1.21
@storybook/addon-links: 6.1.21 => 6.1.21
@storybook/addons: 6.1.21 => 6.1.21
@storybook/node-logger: 6.1.21 => 6.1.21
@storybook/preset-create-react-app: 3.1.7 => 3.1.7
@storybook/react: 6.1.21 => 6.1.21
@storybook/storybook-deployer: 2.8.7 => 2.8.7
@storybook/theming: 6.1.21 => 6.1.21
Additional context
 _lastActiveSortFn: undefined, ERR!       _sortFn: undefined, ERR!       _cache: undefined, ERR!       _cacheOrderIndependent: undefined ERR!     }, ERR!     contextDependencies: SortableSet [Set] { ERR!       '/Users/private-user/private-repo/src', ERR!       _sortFn: undefined, ERR!       _lastActiveSortFn: null, ERR!       _cache: undefined, ERR!       _cacheOrderIndependent: undefined ERR!     }, ERR!     missingDependencies: SortableSet [Set] { ERR!       _sortFn: undefined, ERR!       _lastActiveSortFn: null, ERR!       _cache: undefined, ERR!       _cacheOrderIndependent: undefined ERR!     } ERR!   }, ERR!   hash: '82b3f88322128a30b9ea', ERR!   startTime:<PHONE_NUMBER>781, ERR!   endTime:<PHONE_NUMBER>706 ERR! }

Hey @jessepinuelas How did you fix this error?

@jessepinuelas Hi, I am facing the same problem, do you have any solution to the problem?


Fix CVE-2023-34104 vulnerabilitie in kogito-apps<EMAIL_ADDRESS>

<EMAIL_ADDRESS>brings in the CVE-2023-34104 vulnerability. This package is being used in both @kie-tools-core/backend and @kie-tools-scripts/check-junit-report-results.
Issue already got fixed in kie-tools , but it comes transitively to kogito-apps.
Acceptance criteria:

[x] Add resolution to<EMAIL_ADDRESS>or greater in kogito-apps.

Fixed by: https://github.com/kiegroup/kogito-apps/pull/1767


Question (Urgent): Agent with multiple tools doesn't work as expected and also caused infinite loop.

Issue you'd like to raise.
I am trying to build an agent with multiple tools. Based on the query agent may need to execute single or multiple tools. Some of the tools may ask clarification question to the user. In that case agent should add the question to the final answer along with other tools response. But it wont work as expected. Also It executes the same tool again and again with similar kind of input if the tools response not satisfactory to it.
My agent has 4 tools. I have added portion of the code and a screenshot for better understanding.
I have also tried to modify the prefix, suffix and format_instruction in so many ways but no luck. Also I know return_direct=true will return the tools response to the user directly but this is not my case as this flag won't execute multiple tools.
Expectation:  Agent should return the tools clarification question to the user along with other tools response instead of answering on it's own and execute same tool for similar kind of input. Also Agent should reply proper answer if the Query not related to tools. Eg: If the query is just "Hello" it produce error.
FORMAT_INSTRUCTIONS = """Use the following format:

Question: the input question you must answer
Thought: you should always think about what to do
Action: the action to take, should be one of [{tool_names}]
Action Input: the input to the action
Observation: the result of the action
... (this Thought/Action/Action Input/Observation can repeat N times)
Thought: I now know the final answer
Final Answer: the final answer to the original input question"""

PREFIX_PROMPT = """Have a conversation with a human, answering the following questions as best you can. You have access to the following tools:"""
SUFFIX_PROMPT = """Begin!

Previous conversation history:
{chat_history}
Question: {input}
Thought:{agent_scratchpad}"""

class ChatService(RequestAccessorService):
    def __init__(self, model: SenseChatModel, request: Request):
        super().__init__(request)
        self.model = model

    async def execute_async(self):
        tools = [
            QATool(self.model, self),
            RecordCreateTool(self.model, self),
            RecordSearchTool(self.model, self),
            AppCreateTool(self.model, self)
        ]
        llm = ChatOpenAI(openai_api_key=self.model.openai_api_key, temperature=0)
        prompt = ZeroShotAgent.create_prompt(
            tools,
            prefix=PREFIX_PROMPT,
            suffix=SUFFIX_PROMPT,
            format_instructions=FORMAT_INSTRUCTIONS,
            input_variables=["input", "chat_history", "agent_scratchpad"],
        )

        llm_chain = LLMChain(llm=llm, prompt=prompt)
        agent = ZeroShotAgent(llm_chain=llm_chain, tools=tools, verbose=True)

        agent_chain = AgentExecutor.from_agent_and_tools(
            agent=agent, tools=tools, verbose=True
        )
        print(agent.llm_chain.prompt.template)
        result = await agent_chain.arun(input=self.model.query)
        return result

Query: Give me the all product in the inventory and create a product named dell in inventory
Output: The output of the query. Please see the Action, Action Input and observation to understand the whole scenario.

Suggestion:
No response

RecordCreateTool: It will take a string input and make a API call to our internal server and In that API we have also used AI. By using AI we convert the user query to a record inside the application. If user provide all information to create the record it will create the record and tell the user record has been created and may provide some url to see the record. If there is not enough information to create the record it will ask some clarification question. Eg: Let's say In our Inventory application I have a product table and The product table has a required field Name, Price etc. If the user don't provide all the information it will ask clarify question.
RecordSearchToo: Here also Use AI. By AI we will search in Inventory application database to get the product based on the user query. It will provide the number of product found in the database and may also return the details of products as flat string
So there is no problem in the tools. It all about how the agent handle the tools response.
And you can ignore the rest of the tools for the time being. If I can solve it for this two tools I can solve it for other tools.

HI, you should change this part to stop agent iteration:
Thought: you should always think about what to do Action: the action to take, should be one of [{tool_names}] Action Input: the input to the action Observation: the result of the action
to something like this:
"Thought: Do I need to use a tool base on the given plan? Yes \n"
f"Action: the action to take, should be on of {selected_tools} \n"
"Action Input: the input to the action that is a stand-alone question created from the user's question and chat history, and it contains the sensor name. \n"
"Observation: the result of the action \n"


[Fix] Do not use 'Link All' to ensure that reflection works.

As stated in bug 37242 the sample does not work because the different
properties are read only. This happens when the linker is set to link
everything because the different getter methods are not used.
In this case, we want to keep those methods that are not used so that
the json library, which uses reflection, can find readable properties.

@mandel-macaque thanks for the fix :+1: I think we should file an issue for docs team to update code snippet in the guide.


Possible XSS Vulnerabilities in User Prompt Function

Data in $data['alertSuccess'] and $data['alertDanger'] is passed directly to the DOM without any filtering, resulting in XSS vulnerability.
<?php
if (isset($data['alertSuccess'])) {
    echo '

        <button type="button" class="close" data-dismiss="alert">
            ×
            '.CLOSE.'
        </button>
        ';
    foreach ($data['alertSuccess'] as $alert) {
        echo "$alert\n";
    }
    echo '
';
} elseif (isset($data['alertDanger'])) {
    //print_r($data['alertDanger']);
    echo '

        <button type="button" class="close" data-dismiss="alert">
            ×
            '.CLOSE.'
        </button>

';
    foreach ($data['alertDanger'] as $alert) {
        echo "
$alert
\n";
    }
    echo '

';
} ?>

Related codes

https://github.com/semplon/GeniXCMS/blob/master/register.php#L166
https://github.com/semplon/GeniXCMS/blob/master/login.php#L117
https://github.com/semplon/GeniXCMS/blob/master/inc/lib/System.class.php#L285
https://github.com/semplon/GeniXCMS/blob/master/inc/mod/newsletter/options.php#L77

Untrusted input data is in different ways, filter the output node may be a good idea.


Ensure comment panels can get focus correctly

Fixes #11021
Notes

Not sure if delayFocus was ever an option but I cannot find this in the docs anywhere, so it's possible this never did anything (or at least has not done anything for a while). https://github.com/focus-trap/focus-trap#createoptions
I opted for a hard-coded 250ms delay, this gives enough time for the side panel and the comment panel (card) itself to become visible. I initially tried to set up something more complex that checked if the side panel was visible but this felt too complex. 250ms is not too much of a delay and gives time for any animations to resolve.

Validation screenshot

Checklist

[X] Do the tests still pass?
[X] Does the code comply with the style guide?
[X] For front-end changes: Did you test on all of Wagtail’s supported environments? Chrome 118, Firefox 117, Safari 16.1
[X] For new features: Has the documentation been updated accordingly? N/A

It's been six months of rebasing this, I'll close for now as it doesn't seem to be a priority. Happy to reopen or do a new PR if this fix is needed.


Script exit status

I am working on integrating this into my Unmanic project as a plugin.
While doing this I noticed that the script does not produce a corresponding exit status when any of the commands that it ran fail.
Is this by design? Or is this something I can write up a PR to add? Would it break the current use-cases if we added a failure exit status to the sma manual.py script if, for example, the ffmpeg command fails?
For my project, I'm either going to wrap this up in another script that provides the correct exit status codes or I can look into modifying your SMA processes such that the manual.py script will exit with status 1 when any of it's processes failed.

Manual is just meant to be run manually and thus the exit codes were not prioritized but if you wanted to submit a pull request to include them that would be totally fine


⚠ SkipTheCommericals has degraded performance

In 1acda4f, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 4668 ms

Resolved: SkipTheCommericals performance has improved in 3dae8df.


Metadata service pointing to older version on master

Rancher Versions:
Server:Master
**Docker Version:**1.12.6
**OS and where are the hosts located? (cloud, bare metal, etc):**Ubuntu, Cloud
**Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)**Single node
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Steps to Reproduce:
Create a master setup with 3 hosts
Metadata service pointing to  older version rancher/metadata:v0.7.0
Infrastructure services fail to come up
Catalog is pointing to v1.5.0-dev but network services stack is still not pulling the required folder
Metadata container logs:
2/13/2017 3:13:50 PMtime="2017-02-13T23:13:50Z" level=info msg="Downloaded in 3.961042ms"
2/13/2017 3:13:50 PMtime="2017-02-13T23:13:50Z" level=error msg="Failed to download and reload metadata: non-200 response 404: {\"id\":\"d03a3602-3cb8-4518-92b6-60a01cebf29e\",\"type\":\"error\",\"links\":{},\"actions\":{},\"status\":404,\"code\":\"Not Found\",\"message\":\"Not Found\",\"detail\":null,\"baseType\":\"error\"}"

Network Services container logs
2/13/2017 3:13:57 PMCreating metadata client: Error 404 accessing /version path
2/13/2017 3:13:58 PMtime="2017-02-13T23:13:58Z" level=info msg="Waiting for metadata"
2/13/2017 3:14:29 PMCreating metadata client: Error 404 accessing /version path
2/13/2017 3:14:31 PMtime="2017-02-13T23:14:31Z" level=info msg="Waiting for metadata"
2/13/2017 3:15:02 PMCreating metadata client: Error 404 accessing /version path
2/13/2017 3:15:03 PMtime="2017-02-13T23:15:03Z" level=info msg="Waiting for metadata"
2/13/2017 3:15:34 PMCreating metadata client: Error 404 accessing /version path
2/13/2017 3:15:35 PMtime="2017-02-13T23:15:35Z" level=info msg="Waiting for metadata

When adding a new catalog - "Hello" - using "Admin"->"Settings" page , not able to list any templates from this catalog.
The newly added catalog is not saved in the DB .
mysql> select * from catalog;
+----+---------------------+---------------------+----------------+-----------+----------------------------------------------+--------+------------------------------------------+------+
| id | created_at          | updated_at          | environment_id | name      | url                                          | branch | commit                                   | type |
+----+---------------------+---------------------+----------------+-----------+----------------------------------------------+--------+------------------------------------------+------+
| 13 | 2017-02-14 15:52:28 | 2017-02-14 15:52:28 | global         | community | https://git.rancher.io/community-catalog.git |        | 01a0d8f723ee8b7b4cf7ea54e6eddcf1245bcace |      |
| 14 | 2017-02-14 15:52:36 | 2017-02-14 15:52:36 | global         | library   | https://git.rancher.io/rancher-catalog.git   |        | e6f8944ef89e393e8d625c00c897ecf70f582678 |      |
+----+---------------------+---------------------+----------------+-----------+----------------------------------------------+--------+------------------------------------------+------+
2 rows in set (0.00 sec)

@joshwget , If the catalog was not saved in the DB at all , how is UI able to list this catalog in "Catalog" dropdown menu ? We expect this information to be queried from the DB ?

@sangeethah Was this before or after the 0.16.1 release? This should have been fixed in that release.

Tested with master. Metadata service points to the correct version. When a catalog is added through Admin-settings tab, the templates are listed correctly:
mysql> select * from catalog;
+----+---------------------+---------------------+----------------+----------------+----------------------------------------------+------------+------------------------------------------+------+
| id | created_at          | updated_at          | environment_id | name           | url                                          | branch     | commit                                   | type |
+----+---------------------+---------------------+----------------+----------------+----------------------------------------------+------------+------------------------------------------+------+
|  4 | 2017-02-17 21:03:40 | 2017-02-17 21:03:40 | global         | community      | https://git.rancher.io/community-catalog.git | master     | 1022ba141640833b40d27d8dec478a57a8b4bab4 |      |
|  6 | 2017-02-17 21:03:44 | 2017-02-17 21:03:44 | global         | library        | https://git.rancher.io/rancher-catalog.git   | v1.5.0-dev | db6d23ae5c40bf5c060550f704511d1456e2a13d |      |
|  8 | 2017-02-17 21:19:32 | 2017-02-17 21:19:32 | global         | soumya-catalog | https://github.com/soumyalj/rancher-catalog  | master     | e521d8e96532a6eaf23c1fbed58dd7d3cac28689 |      |
+----+---------------------+---------------------+----------------+----------------+----------------------------------------------+------------+------------------------------------------+------+
3 rows in set (0.00 sec)