False positive 00000000 selector - regression 0.7.3->0.8.3

Component
Heimdall (Core)
Have you ensured that you are up to date?

[X] Bifrost
[X] Heimdall

What version of Heimdall are you on?
0.8.3
Operating System
Linux
Describe the bug
Regression found on 0.8.3 vs 0.7.3 - false positive 00000000 selectors in some contracts, for example (mainnet): 2ede8C6Ae4a08e0886509B328F95E257F424B2b7, 623d39fFc2a2De6cDFfaA3Bd1172A1DfD995d873, 7D7B6bddf5E15ACe5A16a8e3a92c46538F1f5F7F and all vyper contracts (
466c8fa3a6cd4625517594786013262a6abd3f96,54cdeebe729d799c9875004fb20f182ef0c60c7e,69b1e85b0c9a076e3fccb65e25626c5f98395712, ...)
p.s. heimdall 0.8.3 can process random50k dataset without panic: https://github.com/cdump/evmole/commit/9bc0b3107f3c39abfd23525d24a0900b9650d978

thank you for opening!
0x00000000 is just a placeholder used for the fallback, although this shouldn't show up in the ABI like it is now. this happens when we cant find any function signatures (so thats why you see it for ALL vyper contracts, because I havent added vyper selector detection just yet)
i'll make a fix tonight to remove this from the ABI and it should be on nightly soon. 0.8.4 will include the fix as well, but is probably a week or so away.

and yep! I actually run heavy integration tests on the 10k dataset every night: https://github.com/Jon-Becker/heimdall-rs/actions/workflows/heavy-integration.yml


Add init.py for python2 users

I have a few libraries that require python2 so having an init.py in the lib folder would be really nice so that I can automatically import the library without additional changes.

Does it work in Python 2 with just an __init__.py ? I guess there are other necessary changes to make it work under Python 2 (I only use Python 3). If it's only a matter of __init__.py I can add it.


ci: fix bazel.asan target.

BAZEL_BUILD_OPTIONS was expanded without a leading whitespace,
which broke build with non-empty BAZEL_BUILD_EXTRA_OPTIONS.
Broken in #8631.
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

cc @lizan


Make sure NoDataComponent is truly an optional prop

It looks like noDataComponent is intended to be an optional prop, but I discovered that the grid fails to render an empty grid if this component is not provided. This change makes sure the noDataComponent prop is truly optional.
I am also adding a few unit tests, both for this bug and for the datagrid component in general. The project did not have any unit tests before, so that required me to add some packages.
My goal was to get unit tests up and running with minimal changes. Here are some notes:

I followed these react guidelines and installed the React Testing Library.
I stuck with raw jest commands instead of installing heavy scripting packages like react-scripts.
The latest jest package is not compatible with the older version of babel that this package is using. I didn't want to get bogged down in upgrading babel, so I followed some tips online to get jest working with babel6.

Upon closer inspection, I think there are still some issues to sort out before committing these changes.


v4.19.0

Version 4.19.0 adds the following:
PR #329
Amend GOVUK.StickAtTopWhenScrolling to check on resize if an element
should be “unstuck”.
For smaller screens (<768px) ensure that the
GOVUK.StickAtTopWhenScrolling JS "unsticks" the element which was
previously "stuck" (by removing both the class which sets fixed
positioning and the shim).

Closing in favour of #336.


Rename "owners" to "uploaders" on pub.dartlang.org

We don't want to give them impression that the set of people who can upload a package are somehow owners/maintainers/whatever of the package itself.

This issue has been moved to dart-lang/pub#136.


500 Server error in materialize

I have a 500 server error when I access the table list using the materialize.get_tables() function.
url = "https://global.brain-wire-test.org/"
datastack = "h01_c3_flat"

client = CAVEclient(datastack_name=datastack, server_address=url)
client.materialize.get_tables()

HTTPError: 500 Server Error: INTERNAL SERVER ERROR for url: https://local.brain-wire-test.org/materialize/api/v3/datastack/h01_c3_flat/version/377/views content:b'<!doctype html>\n\n<title>500 Internal Server Error</title>\n
Internal Server Error
\n
The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.
\n'

I could access info functions such as client.info.get_datastack_info("h01_c3_flat").
From the error log, https://local.brain-wire-test.org/materialize/api/v3/datastack/h01_c3_flat/version/377/views returns internal server error, but with /tables endpoint correctly returns the table list.

Additional info: We currently use the spatial_aligned_svid_lookup branch rather than the master branch.


Feature/doctrine module zend hydrator

I've just come across this issue:
Fatal error: Declaration of ZF\Apigility\Doctrine\Server\Resource\DoctrineResource::setHydrator() must be compatible with Zend\Hydrator\HydratorAwareInterface::setHydrator(Zend\Hydrator\HydratorInterface $hydrator) in /blah_project/vendor/zfcampus/zf-apigility-doctrine/src/Server/Resource/DoctrineResource.php on line 38
Is there anything I can do to help resolve the build failures?
Cheers
Alex

https://github.com/doctrine/DoctrineModule/issues/546#issuecomment-227930932


Request Interception is not enabled.

I'm just reporting that my version of it (current) is crashing, with the aforementioned error in the title. Feel free to make suggestions, but I'm just doing my part and reporting it.

I think it has something to do with the ad-blocker?

Could you pull latest and see if it works? Thanks.

https://github.com/cliqz-oss/adblocker/issues/1495
https://github.com/jef/streetmerchant/issues/826


Unable to contact Plex - No JSON object could be decoded

Reporting Issues:

Use proper markdown syntax to structure your post (i.e. code/log in code blocks).
Make sure you provide the following information below:

[ ] Version
c0ed30551f183437753773e317cacf7c00750f6c

[ ] Branch
master2

[ ] Commit hash
c0ed30551f183437753773e317cacf7c00750f6c

[ ] Operating system
Linux-2.6.32-042stab123.1-x86_64-with-Ubuntu-16.04-xenial

[ ] Python version
2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

[ ] What you did?
From clean install, entered Plex settings, saved settings, and clicked on test. Have restarted HTPC service multiple times along with Plex.

[ ] What happened?
Unable to contact Plex via http://localhost:32400 error No JSON object could be decoded

[ ] What you expected?

[ ] How can we reproduce your issue?

[ ] What are your (relevant) settings?
Screenshot here - https://i.imgur.com/SUSSeER.png
htpcmanager.txt

[ ] Include a link to your FULL (not just a few lines!) log file that has the error. Please use Gist or Pastebin.

Close your issue when it's solved! If you found the solution yourself please comment so that others benefit from it.
Link to log: https://pastebin.com/npAqXjNr

Ran into the same issue when testing the latest plex server version.
After digging a bit into the plex.py module, it looks like the username and password fields are not being populated in the htpc.settings by cherrypy(?) when the ping method is called by __call__(?). Thus the auth_token is not fetched or populated, yielding a 401 response that fails to parse (because it does not return a JSON body).
On a brief tangent.. plex itself doesn't seem to use the same signin API anymore, favoring https://plex.tv/api/v2/users/signin instead of https://plex.tv/users/sign_in.xml
One solution I found was to hardcode the auth_token you get by curling the plex signin API manually (or looking at an authenticated XHR in plex web client for a valid token).
I don't recommend it as a long-term solution, but adding the token @L861 works in a pinch.. until the token expires.
As a 1-liner in HTPC-Manager directory:
sed -i "861s/.*/                    authtoken='YOUR_TOKEN_HERE'/" modules/plex.py
(GH eats the formatting.. use 20 spaces to tab in before "authtoken" instead of the 1 shown)

The username and password fields aren't being carried into the modules/plex.py file through cherrypy to htpc.settings, so when the ping method gets called it never triggers the initial plex signin to get an auth token for all other requests.
I was able to rig a 'solution' for this (which I do not recommend anyone to use, unless you know what you're doing) that involves putting an auth token ripped out of a plex web player XHR's query parameters.
Then you shoehorn it into the application logic as a hard-coded value.
The hack can be condensed to:
sed -i "897s/.*/            authtoken='YOUR_TOKEN'/" modules/plex.py
(12 spaces before authtoken, despite my inability to properly format)

This issue comes of from time to time but i cant seem to reproduce it. Ill take alook and see if cant make this more robust.

can you try to signin manually using http://ip_to_htpc_manager:port/plex/myPlexSignin?username=your_username&passord=your_passwird

Sorry for the delayed response, and thank you for your help on this. I just reinstalled HTPC Manager and it is working fine now for some reason. Thank you for the help.

In my case, with near certainty this was because I had the manager setup to point to Plex by local subnet IP instead of by loopback address. The local subnet was exposed via a reverse proxy with basic auth enabled (which was cached for the browser, making it not obvious).
Changing the IP should fix it, but I haven't verified.

I have the same issue and don’t understand the fixes

I have just started using this and have the same problem, is there a fix coming for this?

Found the fix, I set up the rest of HTPC and then obviously restarted this seemed to then allow plex to work just fine :)


New version: Transmission.Transmission version 4.0.4

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Can a moderator not approve this pull request? Installation is failing because this package has a dependency on Microsoft Visual C++ Redistributable. Previous versions were being approved despite failing the installer validation.

/AzurePipelines run

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-09-08 14:36:27.098 [CLI ] ShellExecute installer failed: 1603 Property(S): ErrorDialog = ErrorDlg
MSI (s) (68:94) [14:36:26:884]: Product: Transmission 4.0.4 (24077e3511) (x64) -- Installation failed.
MSI (s) (68:94) [14:36:26:884]: Windows Installer installed the product. Product Name: Transmission 4.0.4 (24077e3511) (x64). Product Version: 4.0.4. Product Language: 1033. Manufacturer: Transmission Project. Installation success or error status: 1603.
2023-09-08 14:36:13.467 [CLI ] ShellExecute installer failed: 1603
MSI (s) (A0:20) [14:36:13:354]: Product: Transmission 4.0.4 (24077e3511) -- Installation failed. MSI (s) (A0:20) [14:36:13:354]: Windows Installer installed the product. Product Name: Transmission 4.0.4 (24077e3511). Product Version: 4.0.4. Product Language: 1033. Manufacturer: Transmission Project. Installation success or error status: 1603.

1603 sometimes indicates a missing dependency.

@wingetbot waivers Add Validation-Shell-Execute


want an API can get webview cookie

Is your feature request related to a problem? Please describe.
I want use wry load a remote url, wait user login, and get cookie to use user cookie to call thrid-service api, so I need get cookie on user login sucesss.
Describe the solution you'd like
I use electron session to finish it, the sesion can give all webview  cookies, cache, proxy setting...
but I can't found tauri have similar API
Describe alternatives you've considered
I found wry can preload script , I try init script and send event to main process, but the remote url will run 302 redict and callback , my init script will loss.
Would you assign yourself to implement this feature?

[ x ] No

Additional context
electron session : https://www.electronjs.org/docs/latest/api/session

related to https://github.com/tauri-apps/wry/issues/444.
I think you can access non secure cookie from HTTP request by using custom protocol but can't get secure cookie.
Because wry is not supporting HTTPS request yet. See related issue for more details.

Do we need to implement feature to access webview cookie even if secure cookie can not be handled?

This is useful.

I need this one as well.

I need this one as well.

please just tick the thumbs up button at the top instead of adding "+1" comments that will notify all users subscribed to this issue!

I need like this
https://developer.chrome.com/docs/extensions/reference/cookies/#method-getAll

Hello :).
Hey is this still an open issue? I have exactly the same problem. We have an authentication server that renders a login mask. As soon as the user logins it set's a private cookie that can not be obtained by javascript. In another electron app we are using it is relatively simple to get the cookie then in the backend and handle all secure relevant authentication functions inside the electron backend. I want to implement the same in tauri. How can I achieve if I have no possibility to obtain the cookie itself?
for example in electron I can use in my backend as this:

Thx in advance <3

For those who absolutely want to read cookies from a window's browsing context, you can still do the following:
let window = WindowBuilder::new(
        app, // your AppHandle
        "some-window",
        WindowUrl::External("https://somewhere.com".parse().unwrap()),
    )
    .data_directory("/home/me/session-data") // pass custom path here
    .build()
    .expect("could not create window");

let cookies = std::fs::read_to_string("/home/me/session-data/cookies").expect("could not read cookies");

println!("{cookies}");

This code would display something like that:
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_1      COOKIE_VALUE       None
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_2      COOKIE_VALUE       None
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_3      COOKIE_VALUE       None
... etc

I don't know what all the fields are but at least you can easily retrieve the name and value for each cookie.
It's a terrible solution but it works for me !
I believe the feature should really be available, just like in Electron.

I would really love this feature as well. Love the tauri "ecosystem" btw thanks for everything.

Is there any progress on this issue?

Is there any progress on this issue?
Not on our side at least, meaning no maintainer is actively working on it. No idea if there's a community member working on it but at least nobody reached out to us :)

For those who absolutely want to read cookies from a window's browsing context, you can still do the following:
let window = WindowBuilder::new(
        app, // your AppHandle
        "some-window",
        WindowUrl::External("https://somewhere.com".parse().unwrap()),
    )
    .data_directory("/home/me/session-data") // pass custom path here
    .build()
    .expect("could not create window");

let cookies = std::fs::read_to_string("/home/me/session-data/cookies").expect("could not read cookies");

println!("{cookies}");

This code would display something like that:
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_1      COOKIE_VALUE       None
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_2      COOKIE_VALUE       None
somewhere.com   FALSE   /       FALSE<PHONE_NUMBER>      COOKIE_3      COOKIE_VALUE       None
... etc

I don't know what all the fields are but at least you can easily retrieve the name and value for each cookie.
It's a terrible solution but it works for me !
I believe the feature should really be available, just like in Electron.

It's quite strange, the contents of my data folder are empty.

Is there any progress on the issue?
I want to fix my insecure workarounds on our auth server that I had to do in order to make it working with tauri. It really would make me sad to go back to electron for our applications...😢.

Where are the cookies stored, than I can write my own get cookie handler on rust side.

I need this if I'm ever to port an Electron app to Tauri too.

It's somtimes possible to grab cookies indirectly by intercepting WebView network requests (Set-Cookie), but there seems to be no readily available implementation.

@Zihan-Hu Do you think it would be hard to implement cross-platform reliably?

@Zihan-Hu Do you think it would be hard to implement cross-platform reliably?

Sometimes it feels like herding cats and sometimes very easy 🤔 In my opinion, it depends on the tech stack you're using and your target user base.

Getting cookies by reading Chrome's cookie database on your computer. https://github.com/lei4519/extract-chrome-cookies

I am using an alternative approach to grab cookies: Register a custom protocol for your window using register_uri_scheme_protocol, then just replace the custom scheme with http (s), send your request, extract cookie data from the response, and send the response back to the window.
Example implementation (with reqwest):
fn change_uri_scheme(uri: &tauri::http::Uri, new_scheme: &str) -> Result<tauri::http::Uri, tauri::http::Error> {
    let scheme = tauri::http::uri::Scheme::try_from(new_scheme)?;

    let path_and_query = uri.path_and_query().map(|pq| pq.as_str()).unwrap_or("");
    let new_uri = tauri::http::Uri::builder()
        .scheme(scheme)
        .authority(uri.authority().unwrap().as_str())
        .path_and_query(path_and_query)
        .build()?;

    Ok(new_uri)
}

fn convert_reqwest_to_http_response(reqwest_response: reqwest::blocking::Response) -> Result<(Response<Vec<u8>>, Option<String>), Box<dyn Error>> {
    let status = reqwest_response.status();
    let mut http_response = tauri::http::Response::builder()
        .status(status);

    let mut cookie_data = None;
    for (key, value) in reqwest_response.headers().iter() {
        if key.as_str() == "set-cookie" {
            cookie_data = Some(value.to_str().unwrap().to_string());
        }
        http_response = http_response.header(key, value);
    }

    let body = reqwest_response.bytes()?.to_vec();
    Ok((http_response.body(body)?, cookie_data))
}

fn main() {
    tauri::Builder::default()
        .register_uri_scheme_protocol("cookie", move |_ctx, mut request| {
            *request.uri_mut() = change_uri_scheme(request.uri(), "https").unwrap();

            let client = reqwest::blocking::Client::new();
            let reqwest_request = reqwest::blocking::Request::try_from(request).unwrap();

            let (response, cookie_data) = convert_reqwest_to_http_response(client.execute(reqwest_request).unwrap()).unwrap();
            // do whatever with cookie_data
            response
        })
        .setup(move |app| {
            let window = tauri::webview::WebviewWindowBuilder::new(app, "some-window", tauri::WebviewUrl::External("cookie://some-url-to-visit/".parse().unwrap()));
            let window = window.title("Some window").build().expect("could not create window");
            Ok(())
        }).run(tauri::generate_context!()).unwrap();
}


Fix missing escape field for marks extensions

prosemirror-markdown  uses the field escape to check if the current mark needs to be escaped or not

Your branch is not up to date, it was fixed in #18

🙈


Changes to add a VirtualService for the v1 dataplane

Replaces #339 with a squash rebase

This change is

/lgtm
/approve


laser tag players do not act as commanded.

Hi I have been reading through laser_tag.cc, and open_spiel/open_spiel/integration_tests/playthroughs/laser_tag(horizon=20).txt.
Some of the agents' behaviors are strange. Here is one example where agent A fails to step right even when it is still within the grid even after doing so. There exist numerous similar problems in the afore-mentioned txt file. Would you kindly look into that?
laser_tag(horizon=20).txt

Hi Gary, took a look-- yeah, I agree... that appears to be a bug.
I will take a look, hopefully have it fixed by Monday's update.. but unfortunately can't guarantee any timeline for now, a bit busy with some paper submissions at the moment.

Been a while since I've looked at this but it looks like there's a joint action of ["step right", "move forward"] for A and B respectively, then the chance node decides to apply B's action first (which it then does) but then A's action is never applied.  I could maybe look into this this weekend.

@lanctot @alexminnaar  thank you for looking into this.

Looks like the issue is on this line.  The left step is there twice and one of them should be the right step.  I created a PR https://github.com/deepmind/open_spiel/pull/227/  I'm not sure about the other problems you mentioned but this should at least cover the linked issue.

Hi Alex. Yup I think that is it. All of the other cases that I have spotted so far are step-right related.

Thanks for the quick fix @alexminnaar !

Fixed by https://github.com/deepmind/open_spiel/pull/227 which was just merged. Closing.


bootstrap example error

$collection = ResourceTable::of($news)
    ->addColumn...
    ...
    ->view('bootstrap');

Using your above example in docs gives me the following error in Laravel 5:
Object of class Msieprawski\ResourceTable\Generators\Collection could not be converted to string (View: /var/www/project/resources/views/home.blade.php)

But adding make() to the end makes is work:
$collection = ResourceTable::of($news)
    ->addColumn...
    ...
    ->view('bootstrap')
    ->make();

This is desired result of your action because ResourceTable object will return itself on each "setter" method and ResourceTable cannot be converted to string. Only make method returns string (HTML with table to be more specific).
So if you want to set bootstrap view, that's fine - you are doing it in the right way. However if you want to display table as you do (I can see from your error) you must call make method.


write python program to print largest number in list

Hi, I would like to do

ok @Bhavyakalra-13 I will assign you :+1:

Ok, I will do it:)

Is this still open?

Hello. Please assign this to me


Dynomite Manager with Conductor

(Note: I posted this same issue to the Conductor forum.)
Does anyone out there have any experience deploying Dynomite Manager with Conductor on AWS? We have a topology we think works: One Conductor ELB with two 1.8.0 instances on different AZs, three 0.5.9 Dynomite instances per each of these AZs (for a total of 6), with a Redis 3.2.10 server running on each instance. Each Dynomite config file points to the other 5 EC2 ip's; and the Conductor config points to all 6. While this works great from a functionality perspective, from an OPS perspective it's a nightmare; if any Dynomite instance goes down, not only will they have to stand up an instance manually (since the config file has to point to the other running instances), they also have to restart the running instances (because their individual conf files also will have to be modified). We are currently researching Dynomite Manager to handle issues like this, but we can't find any specific documentation addressing how to get Dynomite Manager working with Conductor. From our understanding, the setting workflow.dynomite.cluster.hosts has to point to individual EC2 ip's, not some manager "host". Can someone point me to some documentation that addresses this type of deployment strategy?

Let me explain the pieces so that you can a better understanding. Redis is the storage layer, Dynomite is the proxy above Redis that replicates the data across multiple other Dynomite nodes. Each node has Dynomite, Redis, and Dynomite-manager (at least in Netflix). Dynomite-manager is used such that Dynomite can be well integrated with AWS and other infra.
Conductor is a workflow engine. It is an application. Conductor uses Dynomite/Redis as the storage layer to write the data to and read the data from. Conductor leverages Eureka to identify the Dynomite cluster (not Dynomite-manager).
The configuration files in Dynomite are only read during the start of Dynomite. Hence even if the YAML change, it does not matter. Dynomite-manager, however, does a good job in updated the YAML files every 30 seconds such that in case of a Dynomite process getting killed, when you restart it then you can have the latest configuration (and no need to wait for another 30 seconds to get the most recent update). In fact, even if you had a bad configuration in terms of the topology Dynomite-manager would fix that by sending the correct topology to Dynomite.
When a node dies, then we leverage AWS autoscaling groups (we deploy each AZ in each ASG - that 1-1 mapping is very important). Hence when a node dies it does not matter. It is a tree in the forest. A new node will come up and Dynomite-manager makes sure that the new node gets the data from another replica. Hence there is no OPS overhead. Everything should be fully-automated.

I am closing this due to inactivity. If you have any more questions please feel free to reopen it or open a new issue.


Security alert: Busboy can crash on manipulated multipart/form-data header names

I already wrote a PR for this problem. which is actually a problem of Dicer which busboy uses. For more information see mscdex/dicer#22.

This was fixed in https://github.com/fastify/busboy

This should be fixed in v1.0.0.


SAK-45751 - Assignments: Support video submissions

This feature is present in our roadmap, the implemetation is more a proof of concept than a final version because it can be improved a lot.
I'd like this being merged as is before the code freeze, in order to begin testing in nightlies, and provide refinements or improvements in separate work packages.
Thanks

I know you're not going to like this. I think you should namespace these js objects properly. It will future proof them by stopping name clashes with other code in Sakai. The trend is for more JS, so this will become more and more likely. The question is: if I don't worry about this and approve it, will anybody come back and namespace it later? Probably not!

Nobody! I'll work on that.

Added namespace here:
https://github.com/sakaiproject/sakai/pull/9444/commits/6fcf77f2c1df2df54a88e8707bc129c0f4c2ce53

Wow @adrianfish can't even imagine that Codacy is happy with my JS!

No, thanks to you!


firefox-bin icon symlinks broken

Issue description
$ NIXPKGS_ALLOW_UNFREE=1 nix build nixpkgs.firefox-bin
$ file result/share/icons/hicolor/32x32/apps/firefox.png
result/share/icons/hicolor/32x32/apps/firefox.png: broken symbolic link to /nix/store/ybr18padw3r94g01q53drdr3cz6znxhf-firefox-release-bin-unwrapped-61.0.1/lib/firefox/browser/chrome/icons/default/default32.png

Due to a nix bug (nixos/nix#2344) this prevents normal installation in user profiles:
NIXPKGS_ALLOW_UNFREE=1 nix-env -f '<nixpkgs>' -iA firefox-bin
installing 'firefox-bin-61.0.1'
building '/nix/store/fm71d8mx21jqjcbgbfjg2q74g3zzk3dm-user-environment.drv'...
error: getting status of '/nix/store/ki91j9mk8s43768bbyq0g7cxy8anly4p-firefox-bin-61.0.1/share/icons/hicolor/128x128/apps/firefox.png': No such file or directory
builder for '/nix/store/fm71d8mx21jqjcbgbfjg2q74g3zzk3dm-user-environment.drv' failed with exit code 1
error: build of '/nix/store/fm71d8mx21jqjcbgbfjg2q74g3zzk3dm-user-environment.drv' failed

Technical details

system: "x86_64-linux"
host os: Linux 4.14.55, NixOS, 18.03.133065.e42c07d78a1 (Impala)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0.4
channels(root): "nixos-18.03.133065.e42c07d78a1, nixos-unstable-18.09pre140099.f53d22edd68"
channels(linus): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

cc maintainer @garbas

@lheckemann i tried to reproduce on current master what you reported. Are you still seeing this issue? If yes, which branch/revision?

As per nix-info in the original report, this is on 18.03. unstable is fine.

@lheckemann sorry i should have seen Technical details section. Care to check if PR I submited works for you as well?


50 unseen classes of the CUB dataset?

Hello @Glaciohound ,
Thank you for sharing the code of your great work.
I read your paper and code but cannot find which of your 50 CUB classes were used for testing.
Can you share how you chose those classes, please?
And I also have a question on the CLIP_linear, you said that you add a linear layer on top of CLIP and fine-tune it. So what is the size of that linear layer (200 or 150)? if it is 150, then how can you use that to infer 50 test classes?
It would really help in my research.
Thank you so much.

Hi Tin,
Thanks for your interests in our work! Let me respond to the questions one by one:

As describe in this section we follow the splitting of data classes of TF-VAEGAN. The split file is copied in our repo in guidelines/CUB/att_splits.mat. If one loads the file, it contains fields named train_loc, val_loc, test_seen_loc, and test_unseen_loc just as their names imply.

CLIP model is a feature matching model, which means it provides embeddings for each input (textual or visual) instead of directly emitting logits for specific classes. In our linear setting we keep this paradigm and the model structure untouched. So "linear layer" we fine-tuned is exactly the original feature output layer which has a output embedding of 512 as explained here. For the test 50 classes the matching scores (or, logits) also come from dot-products between visual and textual features.

Hope this answers your questions and feel free to let us know if you have further questions.
Best,
Chi

Hi @Glaciohound , thank you for the clarification.


Postgres function args weird types

create type test.enum1 as enum ('foo','bar','baz','qux');
create function test.echo(test.enum1) returns test.enum1 as $$ select $1 $$ language sql;
This shows function test.echo() (no args!) in the navigator, which is broken.
Clicking it open the function ok, but it cannot be dropped, etc.

Update:
After closing and reopening the connection, the function arg shows up, but it is not schema-qualified. Instead of test.echo(test.enum1) it is test.echo(enum1), so drop etc still doesn't work.
Solution: use postgres format_type() function to convert type oids to sql strings.
It also takes care of identifier quoting and not explicitly adding current or system schemas.

When you create new type or new table in SQL editor - you'll need to refresh connection metadata.
I will show fully qualified column type name if type owner schema differs from procedure owner schema.


Intellisense not working in Jupyter notebook

Bug: Notebook Editor, Interactive Window, Python Editor cells
Issue: Intellisense not working in jupyter notebook
Setup:
VSCode Version: 1.4
Using VSCode from Windows 10 to connect to remote Linux VM
Linux VM details: 4.15.0-1050-azure microsoft/vscode-python#55-Ubuntu SMP
Python version in vm - 3.5.6
Env: Conda
Python extension version - 2019.10.44104
Setting python.jediEnabled:**               false
Jupyter server: remote
Issue:
Intellisense is not working with Jupyter notebook, however intellisense is working with python files (.py)
I am able to run cells in jupyter notebook

Unfortunately I have exactly the same problem as @jqluisneumann, I installed everything from 0 to see if it solved, I just added the extension Jupyter, Pylance, Python and Visual Studio IntelliCode, but it ends up being the same.

Unfortunately I have exactly the same problem as @jqluisneumann, I installed everything from 0 to see if it solved, I just added the extension Jupyter, Pylance, Python and Visual Studio IntelliCode, but it ends up being the same.

@rBatist4 Could you please open up a new issue here in the vscode-jupyter repo regarding your issue? This particular bug has been closed as of 2019. That way we can help track your issue individually and help resolve it.

@rBatist4 Could you please open up a new issue here in the vscode-jupyter repo regarding your issue? This particular bug has been closed as of 2019. That way we can help track your issue individually and help resolve it.

I have this same issue. Any solutions ?

I have this same issue. Any solutions ?

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

Yes sure I will open a new issue. Could you please mention what are the information you need. Then I open a new issue with that information.
Thank you

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

@CSAapps can you open a new issue? This issue was long ago resolved. We'd need a lot more information to diagnose why intellisense may not be working for you.

Yes sure I will open a new issue. Could you please mention what are the information you need. Then I open a new issue with that information.
Thank you


Failed to load the always-up package

[Enter steps to reproduce below:]

Open atom

Atom Version: 1.1.0
System: Windows 10
Thrown From: Atom Core
Stack Trace
Failed to load the always-up package
At Cannot read property 'prototype' of undefined

TypeError: Cannot read property 'prototype' of undefined
    at __extends (<anonymous>:1:1)
    at <anonymous>:6:3
    at Object.<anonymous> (<anonymous>:6:3)
    at Object.<anonymous> (<anonymous>:1:1)
    at Module._compile (module.js:428:26)
    at Object.defineProperty.value [as .coffee] (C:\Users\Fabiano\AppData\Local\atom\app-1.1.0\resources\app.asar\src\compile-cache.js:169:21)
    at Module.load (module.js:353:32)
    at Function.Module._load (module.js:308:12)
    at Module.require (module.js:363:17)
    at require (module.js:382:17)

Commands

Config
{
  "core": {
    "audioBeep": false,
    "disabledPackages": [
      "data-atom",
      "atom-jshint",
      "jshint",
      "terminal-status",
      "save-session",
      "open-in-sourcetree",
      "open-last-project",
      "autoclose-html"
    ],
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "editor": {
    "invisibles": {},
    "fontSize": 15
  }
}

Installed Packages
# User
always-up, v0.4.0
angularjs, v0.3.3
auto-indent, v0.5.0
autocomplete-paths, v1.0.2
color-picker, v2.0.13
debugger-lines, v0.5.2
docblockr, v0.7.3
git-log, v0.4.1
http-status-codes, v1.0.4
language-mongodb, v0.2.0
line-ending-converter, v1.3.2
linter, v1.10.0
linter-htmlhint, v0.2.1
linter-jshint, v1.2.1
local-history, v3.2.3
minimap, v4.16.0
modular-snippets, v0.2.1
pretty-json, v0.4.1
project-manager, v2.6.5

# Dev
No dev packages

The always-up package no longer seems to be maintained - I would suggest uninstalling it and finding an alternative.


return the model's actual version metadata

when a version is requested, return that version's model metadata
support all variants of versions (name-specified, kwargs version, tag, commit)

closing, declined because this behavior is already implemented (and the PR results in failed tests)


Rethink middleware hostname overrides

Topics to be discussed

Should we have hostname overrides on assets
Should we allow moving assets outside a facility
Make hostname unique per facility

cc: @gigincg


Error: Updating metrics in all the app - "Tag does not exist..."

I get the following error when using the endpoint POST /update/all:
Status output:
Updating metrics in all the apps...
...POST update/all failure::Error: Tag does not exist, shutting down run.
What could be wrong?
I have a custom property called "ManagedMasterItems"?

Ahh - solved it. The new version does use a tag.
You can close this issue.
From the docs:
To create the gms tag:
Navigate to the Tags menu item in the QMC.

Click the "Create New" button.
Enter gms into the Name field.
Click Apply.

#59 resolves.  Thanks @dauledk!


idle_check kills terminal-only sessions prematurely

It appears that the clock starts ticking for new apps with the first call to idle_check, when the app name is registered.  However, this reference time does not seem to be refreshed at any point.  Consequently, when working at the terminal with keep_terminals = False and without any notebook running, the app will be terminated with a log message of "Keep alive time for terminal reached".  Is this intended behavior?  Ideally the IdleChecker would look to see if the terminal is in active use (maybe by resource usage or the output of the w command).

I'm suggesting something along the lines of replacing idle_checker.py#L272-L276 with
mintime = float('inf')
for term in os.listdir('/dev/pts'):
    atime = os.stat(f'/dev/pts/{term}').st_atime
    now = time.time()
    delta = now - atime
    if delta < mintime:
        mintime = delta

if mintime > self.idle_time:
    self.log.info(
        "Keepalive time for terminal reached : " + str(app_name)
    )
    await self.delete_application(app_name)


Add Koin injector

Implements adding Koin annotations defined in here: https://insert-koin.io/docs/reference/koin-annotations/definitions
There is one issue @mcarleio - i believe it's something with the proxy. When i'm trying to pass TestScope::class as annotation parameter the ksp fails (cannot resolve that class name). There is a failing test with repro named factoryScopedWithClass, please take a look at a spare time.
As to injectors themselves - super solution, adding new one was very easy. There are two features i'd love to have:

Pass ksp options to injector, so we can use some options directly in injectors themselves. This is related to the next feature
Add option to specify default injecting annotation for all mappers. For example - i know the 99% of my mappers will be simply annotated with a @Factory without any additions. So instead of adding @KFactory to every single interface i create maybe it would be nice to add some ksp option, like konvert.koin-injector.default-annotation: @KFactory

Also it would be beneficial to run build action in pull requests too :)

Thank you for the PR!

There is one issue @mcarleio - i believe it's something with the proxy. When i'm trying to pass TestScope::class as annotation parameter the ksp fails (cannot resolve that class name). There is a failing test with repro named factoryScopedWithClass, please take a look at a spare time.

Yeah, I had the same problem with e.g. @KonvertTo and could only solve it, by not using getAnnotationsByType. That is the main reason for the AnnotationData. The problem is, that you can reference a class, which is being compiled at the same time and then the ksp method is sadly not working as expected.

Pass ksp options to injector, so we can use some options directly in injectors themselves. This is related to the next feature
Add option to specify default injecting annotation for all mappers. For example - i know the 99% of my mappers will be simply annotated with a @Factory without any additions. So instead of adding @KFactory to every single interface i create maybe it would be nice to add some ksp option, like konvert.koin-injector.default-annotation: @KFactory

This should already be possible, but is not documented well.
You can simply access the configuration via
import io.mcarle.konvert.converter.api.config.Configuration

Configuration.CURRENT.get("konvert.koin-injector.default-annotation")

I think it would be good to have all possible configuration keys in KonvertOptions. To simplify usage, I would recommend to implement something like this and use it in your injector.

Also it would be beneficial to run build action in pull requests too :)

I would have thought that GitHub will show a "Approve and run" button in this PR, because you are a First-time contributor here. But there is no button and I am unsure why. I suspect the
permissions:
      packages: write

part, so maybe I have to extract the release part from the build.yml.

There is one issue @mcarleio - i believe it's something with the proxy. When i'm trying to pass TestScope::class as annotation parameter the ksp fails (cannot resolve that class name). There is a failing test with repro named factoryScopedWithClass, please take a look at a spare time.

Yeah, I had the same problem with e.g. @KonvertTo and could only solve it, by not using getAnnotationsByType. That is the main reason for the AnnotationData. The problem is, that you can reference a class, which is being compiled at the same time and then the ksp method is sadly not working as expected.

I'll look at that tomorrow.

I would have thought that GitHub will show a "Approve and run" button in this PR, because you are a First-time contributor here. But there is no button and I am unsure why. I suspect the
permissions:
      packages: write

part, so maybe I have to extract the release part from the build.yml.

Don't you need to add
on:
    pull_request:
        types: [ opened, synchronize, reopened ]

to your workflow?

Don't you need to add
on:
    pull_request:
        types: [ opened, synchronize, reopened ]

to your workflow?

Oh, you are right, I have no pull_request defined... I just added it (and split the build and release workflows) - hope it works now :+1:

Yeah, I had the same problem with e.g. @KonvertTo and could only solve it, by not using getAnnotationsByType. That is the main reason for the AnnotationData. The problem is, that you can reference a class, which is being compiled at the same time and then the ksp method is sadly not working as expected.

I think i figured it out, but please take a look if you can spot something fishy.
I can add the default factory injectors in another PR

I think i figured it out, but please take a look if you can spot something fishy.

Feels a bit strange to have to handle the annotations like that, but I also have no other good idea 🤔
Could you please amend the KoinInjector to do the same logic for these examples:

@KFactory(Factory(binds=[SomeClass::class]))
@KSingle(Single(binds=[SomeClass::class]))
@KScoped(Scoped(binds=[SomeClass::class]))

To have to test coverage collected for the new modules, please amend the root build.gradle.kts and add
kover(project(":injectors:koin-annotations"))
kover(project(":injectors:koin-injector"))

Sure, will do

@mcarleio I'm just running both methods on all annotations now, i think that covers all of possible use cases


SavePath from config.yaml file

Hi :) Spock is cool and I like what I see so far. I appreciate the work you put into Spock and after using Hydra for over a year I want to check out Spock for configuration. However, I am having some troubles with it.
Describe the bug
Cannot load in a SavePath for the spock configuration used during a run from the config.yaml provided. Right now my ugly workaround is to hardcode the path with
save_path = f"{environ.get('PWD')}/runs"
and
SpockBuilder.save(user_specified_path=save_path)
To Reproduce
Steps to reproduce the behavior:

instantiate spock namespace with SpockBuilder(somecfg, desc="somecfg", config=['src/config.yaml']).save(file_extension=".toml").generate()`
ValueError Exception was raised: ValueError: Save did not receive a valid path from: (1) markup file(s) or (2) the keyword arg user_specified_path

Expected behavior
I want to specify a mutable path for outputs/saving in the external config.yaml file. Having to do this hardcoded in user_specified_path inside the main file is an inferior alternative.
Desktop (please complete the following information):

OS: macOS Monterey 12.3.1
Browser: chrome
Version: 100.0

Additional context
I hope I am missing it in the docs, but I cannot find it here: SavePath
Here it says We simply specify a SavePath in a spock config, which is a special argument type that is used to set the save path from a configuration file., which does not work for me. I also do not know where to import this SavePath type from.
Thanks in advance for your help,
Sven

Hey @svenstehle!
Thanks for the kind words. Hydra is a pretty great library too (it didn't exist when we first wrote Spock internally) but hopefully both fit into their own respectively different niches.
I think maybe the docs were not clear enough from my end... There are two ways to save in Spock: (1) via the SavePath type  which can be imported from the top level of spock or (2) via the user_specified_path kwarg within the save function. (Note that user_specified_path will take precedence over SavePath)
Option 1: SavePath Example
# -*- coding: utf-8 -*-
from spock import SpockBuilder
from spock import spock
from spock import SavePath

@spock
class Simple:
    only: int = 1
    save_path: SavePath

def main():
    test = SpockBuilder(
        Simple,
        lazy=True,
        configs=["/path/to/config/issue.toml"]
    ).save(file_extension=".toml").generate()
    print(test)

if __name__ == '__main__':
    main()

With the config file as:
[Simple]
    save_path = "/tmp"

Option 2: Specify Path In-Line
# -*- coding: utf-8 -*-
from spock import SpockBuilder
from spock import spock

@spock
class Simple:
    only: int = 1

def main():
    test = SpockBuilder(
        Simple,
        lazy=True,
        configs=["/path/to/config/issue.toml"]
    ).save(file_extension=".toml", user_specified_path='/tmp').generate()
    print(test)

if __name__ == '__main__':
    main()

Both of those should be working examples that you should be able to run locally (with correct paths for your system).
I'm updating the docs to be a bit clearer that these are the two ways to specify save paths and to indicate that SavePath can be imported from the top level.
Hope this helps clear up the confusion!
Best,
Nick

Hi Nick, thanks for the very fast response and the great working examples :)
They both work on my end, thanks! On a side-note: Hydra may be newer, but Spock already fixes the testability issue I have with Hydra with the no_cmd_line=True in the SpockBuilder when using something like pytest --pdb tests. I think that is a very necessary thing to work around conflicts of that nature.
I have a few follow-up questions, though. Please tell if I should open/move this to another issue or feature request :)
I have played around some more with Spock and found
from spock.backend.typed import SavePath, which lets VSCode know the type of this parameter and surprisingly also works functionally, i.e. I can adjust the save_path in the config and Spock will save the config in the correct adjusted save_path without specifying user_specified_path.
Nice! But is this intended? When I use from spock import SavePath, VSCode does not recognize the type of SavePath and leaves it as Any
On another matter, and maybe you will tell me I should open a feature request for this, I have learned to use OmegaConf while working with Hydra, and I would love to have this possibility of interpolation and accessing environment variables and other resolvers inside the config.yaml, e.g.
# config.yaml
save_path: ${oc.env:PWD}/runs

This gives so much flexibility. Are there plans to integrate OmegaConf into Spock, would this even be feasible?

I have played around some more with Spock and found
from spock.backend.typed import SavePath, which lets VSCode know the type of this parameter and surprisingly also works functionally, i.e. I can adjust the save_path in the config and Spock will save the config in the correct adjusted save_path without specifying user_specified_path.
Nice! But is this intended? When I use from spock import SavePath, VSCode does not recognize the type of SavePath and leaves it as Any

Ahhh this makes sense. There are some stubs in various places to get type hinting and autocompletion to work in VSCode when using spock objects (see here). Should be a simple fix to the stub to make sure the type hinting works from the top level import.. I'll get a PR in to change this, no need for a new issue as this should be a very minor change

On another matter, and maybe you will tell me I should open a feature request for this, I have learned to use OmegaConf while working with Hydra, and I would love to have this possibility of interpolation and accessing environment variables and other resolvers inside the config.yaml,

Please do open a feature request for this. We can't support OmegaConf directly (as it provides a lot of similar functionality that we already leverage from attrs as an underlying library), but we should definitely be able to replicate this functionality. Shouldn't be too much legwork on my end. I'll add it to my todo list. Happy to have you help/contribute if you want as well :-)
Nick

Thanks for taking this on! :)

Please do open a feature request for this. We can't support OmegaConf directly (as it provides a lot of similar functionality >that we already leverage from attrs as an underlying library), but we should definitely be able to replicate this functionality. >Shouldn't be too much legwork on my end. I'll add it to my todo list. Happy to have you help/contribute if you want as well >:-)
I will open a feature request for this then. I am happy to help/contribute on this. I would not know where to begin with this, however.

closing per resolution and new open feature request


[$125] [Form Provider Refactor] ACHContractStep

Coming from https://github.com/Expensify/App/issues/25397#issuecomment-1743272245, we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.
This issue is specific to refactoring src/pages/ReimbursementAccount/ACHContractStep.js
cc @kowczarz @cdOut
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc4521b1d4b152cc
Upwork Job ID:<PHONE_NUMBER>301692928
Last Price Increase: 2023-10-26

Issue OwnerCurrent Issue Owner: @cdOut

@cdOut will you be working on this issue too?

@luacmartins yes, I will be working on this issue.

Waiting on a PR

I am working on it, should create a PR soon

We have a draft PR

Still working on draft PR

There are errors regarding the refactored elements in this specific flow that didn't appear before, I am still working on fixing them

Any update here @cdOut?

Ah wait, I see: https://github.com/Expensify/App/pull/30665#issuecomment-1814217374

This issue was fixed in https://github.com/Expensify/App/pull/30568, both flows were using a specific subform that had to be updated, so I had to update all the forms using it. This component is already refactored into FormProvider and is currently merged on main.

Looks like this caused some deployblockers: https://github.com/Expensify/App/pull/30568#issuecomment-1820794833. I don't think we can call this done yet.

Can we close this out now actually @cdOut and @luacmartins?

Yea, we're good to close this one. Thanks everyone!


fix: assure possibly blocking non-files (like FIFOs) won't be picked up for publishing.

Follow-up of #14975, related to https://github.com/GitoxideLabs/gitoxide/pull/1629.
This would otherwise cause the publish to hang if it tries to read from a fifo.

The test-failure seems unrelated:
---- expected: tests/testsuite/test.rs:5014:13
++++ actual:   stderr
   1    1 | [RUNNING] `[..]--crate-name a [..]-C panic=abort[..]`
   2    2 | [RUNNING] `[..]--crate-name foo [..]-C panic=abort[..]`
   3      - [RUNNING] `[..]--crate-name foo [..]-C panic=abort[..]--test[..]`
   4    3 | ...∅

The test-failure seems unrelated:

Yes. It is unrelated. I tried it locally, and it works well. I will help you rerun it.


localhost redis-cli Connection refused on redis-cluster:latest

localhost redis-cli Connection refused to container, didn't get enough time to investigate but probably has to do with docker, host/IP resolution.
$ redis-cli -c -p 7000
Could not connect to Redis at <IP_ADDRESS>:7000: Connection refused
$ redis-cli -c -h <IP_ADDRESS> -p 7001
Could not connect to Redis at <IP_ADDRESS>:7001: Connection refused
$ redis-cli --cluster check <IP_ADDRESS>:7000
Could not connect to Redis at <IP_ADDRESS>:7000: Connection refused

Tried all possible combinations:
export REDIS_CLUSTER_IP=<IP_ADDRESS>
docker run  grokzen/redis-cluster:latest

And
unset REDIS_CLUSTER_IP
docker run  -e "IP=<IP_ADDRESS>" grokzen/redis-cluster:latest
CREATED             STATUS                  PORTS                                      NAMES
3688531bf7c6        grokzen/redis-cluster:latest                                                           "/docker-entrypoint.…"   14 seconds ago      Up 13 seconds           5000-5002/tcp, 6379/tcp, 7000-7007/tcp     compassionate_hofstadter

Environment: Mac Docker Desktop Engine: 19.03.2
Quick inspect showed no port bindings or ports exposed to connect?
      "NetworkSettings": {
           "Bridge": "",
           "SandboxID": "2dedfbf197b1ec846ffd17f6ef62a0dd9bddc1a06fff08ebd6a828e7c449d20b",
           "HairpinMode": false,
           "LinkLocalIPv6Address": "",
           "LinkLocalIPv6PrefixLen": 0,
           "Ports": {
               "5000/tcp": null,
               "5001/tcp": null,
               "5002/tcp": null,
               "6379/tcp": null,
               "7000/tcp": null,
               "7001/tcp": null,
               "7002/tcp": null,
               "7003/tcp": null,
               "7004/tcp": null,
               "7005/tcp": null,
               "7006/tcp": null,
               "7007/tcp": null
           },

Solution to expose ports:
docker run  -e "IP=<IP_ADDRESS>" -p 7000:7000 -p 7001:7001 -p 7002:7002  grokzen/redis-cluster:latest

Sorting the ports depending on where/how you run the container, is not an issue for this repo to deal with.

Makes sense, thought it was a bug and realized it too late!


Tip Use Per Step: Change Tip Copy

As a protocol designer, I would like clear tip management choices, so that I can make accurate choices about when to use a fresh tip.
Acceptance Criteria

[ ] Update label and option copy in the 'Change Tip' field as follows:
[ ] Transfer, Distribute, and Consolidate should be the same (have all options)

Field Label: Change Tips
Option 1: Use a new tip for this step
Option 2: Use a new tip for this step, and every transfer within this step.
Option 3: Use tip from previous step
Design

@howisthisnamenottakenyet is this still WIP or should we remove the WIP label?

@IanLondon we're good to go


Use gen/ids into im_cluster_command_handler.cpp

Problem
This PR uses gen/ids files with constexpr inside namespaces instead of the code generated for gen/command-id.h and gen/cluster-id.h.
Testing
I have locally runned the test suites to validate the commands/clusters works.

@mspang @LuDuda  @Damian-Nordic ?


add template file size to 3m and throw clearly error

What this PR does / why we need it:
It is to solve a problem that the error cannot be understood completely after the template creation fails.
How to reproduce：
Use a template package over 3m：
ll test-0.1.0.tgz

-rw-r--r--  1 xxx  staff    13M  6 20 22:17 test-0.1.0.tgz

helm install test test-0.1.0.tgz --debug

install.go:159: [debug] Original chart version: ""
install.go:176: [debug] CHART PATH: /Users/xxx/Desktop/test-0.1.0.tgz

Error: create: failed to create: Request entity too large: limit is 3145728
helm.go:84: [debug] Request entity too large: limit is 3145728
create: failed to create
helm.sh/helm/v3/pkg/storage/driver.(*Secrets).Create
	/home/circleci/helm.sh/helm/pkg/storage/driver/secrets.go:161
helm.sh/helm/v3/pkg/storage.(*Storage).Create
	/home/circleci/helm.sh/helm/pkg/storage/storage.go:66
helm.sh/helm/v3/pkg/action.(*Install).Run
	/home/circleci/helm.sh/helm/pkg/action/install.go:315
main.runInstall
	/home/circleci/helm.sh/helm/cmd/helm/install.go:229
main.newInstallCmd.func1
	/home/circleci/helm.sh/helm/cmd/helm/install.go:117
github.com/spf13/cobra.(*Command).execute
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
	/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main
	/home/circleci/helm.sh/helm/cmd/helm/helm.go:83
runtime.main
	/usr/local/go/src/runtime/proc.go:203
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1357

This is because the api-server limits the size of the requested body to 3m when creating secrets. Therefore, we can verify the size of the template problem before installation, avoid unnecessary requests, and give user-friendly prompts.

Hi, @Cweiping - for us to review this, we will first need the tests to pass. Can you take a look? Thanks!
pkg/storage/driver/cfgmaps.go:169: File is not `gofmt`-ed with `-s` (gofmt)

		}else if apierrors.IsRequestEntityTooLargeError(err){

pkg/storage/driver/secrets.go:159: File is not `gofmt`-ed with `-s` (gofmt)

		}else if apierrors.IsRequestEntityTooLargeError(err){

Hi, @Cweiping - for us to review this, we will first need the tests to pass. Can you take a look? Thanks!
pkg/storage/driver/cfgmaps.go:169: File is not `gofmt`-ed with `-s` (gofmt)

		}else if apierrors.IsRequestEntityTooLargeError(err){

pkg/storage/driver/secrets.go:159: File is not `gofmt`-ed with `-s` (gofmt)

		}else if apierrors.IsRequestEntityTooLargeError(err){

Done.

Thanks for the pull request. I'm wondering if there is a better way to pass the max value around.

Changes have been made according to your suggestions, waiting for your review again.

Any chance we can get test coverage for these changes? Possibly by having a test fixture return apierrors.RequestEntityTooLargeError. Thanks.

Any chance we can get test coverage for these changes? Possibly by having a test fixture return apierrors.RequestEntityTooLarge. Thanks.

Oh, my God. I'm waiting for you to review.
Done.
The test case has been completed and will be reviewed again


from_canonical function is missing

Comments for issue #17 say that from_canonical() was added, but after extracting the 0.8.1 tarball fgrep cannot find any such function.

I miswrote there, my bad, that's what I get for writing up comments at 2 AM. Upon comparing the C and CPP version of the library, I realized that the currently existing canonical_t::to_hash() function does what the theoretical from_canonical() function would, and so the latter would be superfluous.

Did you mean get_hash() not to_hash()?

Yes, my bad.


Update packages

Pull Request Test Coverage Report for Build 917806368

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 917768601:
0.0%

Covered Lines:
42

Relevant Lines:
42

💛  - Coveralls


docs(rc): nominate Victor Adossi

Signed-off-by: Bailey Hayes<EMAIL_ADDRESS>I am nominating a Recognized Contributor.
Name: Victor Adossi
GitHub Username: vados-cosmonic
Projects/SIGs:

SIG Guest Langauges JS Subgroup
Contributions to many Bytecode Alliance projects:

wasm-tools
component model book
wit-bindgen
wasmtime
JCO
ComponentizeJS

Nomination
Victor was part of the effort to land the feature gate implementation in JCO which was critical for us to roll out the first WASI patch release in the Bytecode Alliance.
Victor has a focus on improving usability from creating examples and documentationto improves our projects with bug fixes and contributions. He regularly responds to new users asking for help on our Zulip and aids in growing our community.
Optional: Endorsements

Bailey Hayes (@ricochet)

[x] I have read and understood the qualifications for a Recognized Contributor

Thanks @fitzgen ! I sent the email earlier -- hopefully ya'll have received it! :bow:

Thanks for the acknowledgement email, Victor, to which I've confirmed in reply and added you to our RC mailing list and public roster. Congratulations and welcome!


Using custom icon from Material Icons is not working

Hello guys, im using this wonderfull solution, but i needs to change the default icons to Material Design Icons:
import Icon from 'react-native-vector-icons/MaterialIcons'
....
<TabScreen label="Geral" icon={<Icon name="add"/>} style={{color:'#FFF'}}>

How can i do this?
Thanks for your attention!

It does use Material Community Icons, but this could also work if I'm correct
<TabScreen label="Geral" icon={iconProps => <Icon name="add" {...iconProps}/>} style={{color:'#FFF'}}>
~``


[RFC]: notations used in this package

At the moment, we are using the following notations:

logπ - log target distribution
∂logπ∂θ - gradient
prop - transitioning kernel
θ_init - initial value for sampling states / parameters

I think this can be improved by

∂logπ∂θ ==> ∇logπ
prop  ==> κ (kappa) or τ (tau) - MH transitioning kernel
θ - parameters, r - momentum
θ_init ==> θ₀ (theta_{0}), r_init ==> r₀ (r_{0})
z := (θ, r)   - (position, momentum) pair

Any other notations missing?

I completely agree with all of @yebai 's proposals. Couple of quick comments:

I would prefer τ to kappa, but don't have a hugely strong feeling either way.
By q₀, do you mean q₀ or r₀?

If the above are resolved, I'm happy :slightly_smiling_face:

By q₀, do you mean q₀ or r₀?

should be  r₀.

Nice call! I agree we with these notations! Let's change to them.

@yebai Did we have similar agreement on things like \epsilon used in Turing?

@yebai Did we have similar agreement on things like \epsilon used in Turing?

how about using the symbol ϵ?

\epsilon is ϵ


proposal: runtime: use zero byte as empty control word (potential performance improvement)

Proposal Details
Context
The implementation of Swiss maps brought in Go 1.24 is more complex than previously seen implementations, but it retains one of the original details that everyone seems to implement in the same way: the control word used to denote an empty slot is 0b10000000 (and the one for deleted items is 0b11111110.
Problem
Every time a new table is allocated or it grows, it has to be filled with this specific "empty control word" pattern. For large maps, this is quite a lot of work.
Proposal
I propose to:

Use zero-byte 0b00000000 to denote an empty slot.
Use byte 1 (0b00000001) for deleted slots.
Add 2 to h2 to ensure that it always has some non-zero bit set in bits 1-7.

While writing this issue I saw a similar proposal in a TODO comment in the implementation.
// TODO(prattmic): Consider inverting the top bit so that the zero value is empty.
type ctrl uint8

What does this mean:

The most important thing: an zeroed group is filled with empty control words out of the box, so we don't have to do that manually on each allocation/growth of the table.
There's an extra operation to be done when splitting a key into the h1/h2 pair (plus two, my guess is no modern CPU will have a noticeable impact of that, but it's worth noting).
Depending on how the SIMD code is written, this may result in less operations needed.

When I proposed this to github.com/dolthub/swiss, I was able to use 2 less operations, although their version appears to be longer than the one implemented here in stdlib, but it's also designed for 16-element groups, which isn't done in Go yet.
I checked the code in stdlib and I don't even understand why it works yet[^1].

I previously sent a PR to dolthub's swiss map implementation implementing this change, and the benchmarks were quite promising (although I didn't test the SIMD path, since I was benchmarking on arm64).
Given that Go's version is quite more complex than that one, I decided to drop an issue before attempting to hack a proof-of-concept.
cc @prattmic
[^1]: The comment says that Empty slots are negated, becoming 1000 0000 (unchanged!)., but negating something should change it, right? I didn't find any docs regarding this behaviour, only ChatGPT explained me that since it's already the most negative value, it remains unchanged.

Related Issues

runtime: map cold cache improvements #70835

Related Code Changes

internal/runtime/maps: initial swiss table map implementation
runtime: use SwissTable

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

This would be an internal implementation detail, and as such would not need to go through the proposal process.

The original Abseil swisstable design uses 0b10000000 for empty specifically to enable the use of PSIGNB, which you also linked to above.
I think the comment there does a pretty good job of explaining how it works, but to your question:

The comment says that Empty slots are negated, becoming 1000 0000 (unchanged!)., but negating something should change it, right?

In 2's complement, negation is defined as NEG a = (NOT a) + 1. So:

a = 1000 0000
NOT a = 0111 1111
(NOT a) + 1 = 1000 0000

Big kudos to the Abseil folks for coming up with this optimization, I never would have thought of something so subtle using a seemly unrelated instruction.

Whether we need to keep this optimization is the question.
There are several things at play here:
Use of PSIGNB is fewer instructions than PCMPEQB in general because the latter needs to load ctrlEmpty into a register prior to comparison. But in the register ABI, X15 is defined as a zero register, so we wouldn't actually need to load anything for PCMPEQB.
On the other hand, matchH2 benefits from having bit 7 clear. If we do the obvious change of using bit 7 to indicate in use, then matchH2 needs to set bit 7 of h2 prior to comparison. That should be cheap, but it is more work.
I haven't fully considered the implications of your alternative proposal of adding 2 to h2, but that would be a similar amount of work.


Error message for wrong ways to run

No token given but PII requested
Forgot to stage
???

These are for the future, implementing all the time


Enforce test code coverage

CodeCov or SonarCloud?

CodeCov upload/enforce
https://elisegev.medium.com/running-tests-and-creating-code-coverage-reports-for-react-nodejs-project-continuously-with-60312b6a2dd0
Block Action
https://github.com/marketplace/actions/check-code-coverage

Works!  Cut off is 80% for new code.
https://github.com/bcgov/greenfield-template/pull/392


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter google-spreadsheet for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.google-spreadsheet
   -
ERRORS:

[x] :heavy_exclamation_mark: [E029] Node.js 18 is required as minimum, node.js 18 is recommended. Please adapt "{'engines' : { 'node' >= '16' } }" at package.json.
[x] :heavy_exclamation_mark: [E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[x] :heavy_exclamation_mark: [E254] Version "0.0.1" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
[x] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2024 Thomas Pohl<EMAIL_ADDRESS>at the end of README.md

WARNINGS:

[X] :eyes: [W028] Minimum node.js version 18 recommended. Please adapt "{'engines' : { 'node' >= '16' } }" at package.json.
[x] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[x] :eyes: [W132] Many "common.news" found in io-package.json. Repository builder will truncate at 7 news. Please remove old news.
[x] :eyes: [W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[x] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[x] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.
[X] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[x] :eyes: [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required?

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Sat, 26 Oct 2024 03:57:44 GMT based on commit 263d8acd93a945a18b9b2251a88da5aaf4dc98b1
ioBroker.repochecker 3.1.3

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

@iobroker-bot recheck

@ioBroker-Bot recreate


Bump and fix OpenTelemetry metrics

This change bump all open telemetry dependencies to latest version and fixes issues that arise from doing that.

Maybe one can read each commit's message but in short, as Eric summarised:
We need these two fixes:

exporting metrics fails because high cardinality attributes cause too many time series to be created (filters fix those)
filtered attributes still consume memory in some cache (bump to unreleased fixes that)


Baichuan2-7b-chat Tokenizer and outputs difference between your repo and officical hugginface example.

Hi, I found some differneces between your baichuan2-7b-chat example and hugginface baichuan2-7b-chat example.
About tokenizer.
from transformers import AutoModelForCausalLM, AutoTokenizer

tokenizer = AutoTokenizer.from_pretrained("baichuan-inc/Baichuan2-7B-chat", trust_remote_code=True)
model = AutoModelForCausalLM.from_pretrained("baichuan-inc/Baichuan2-7B-chat", device_map="auto", trust_remote_code=True)
inputs = tokenizer('你好吗', return_tensors='pt')
print(inputs)

# {'input_ids': tensor([[16829, 93122]]), 'attention_mask': tensor([[1, 1]])}

I found there were no specical tokens 195 and 196 from the transformers tokenizer, but you repo adds these two special tokens for each sencetence. I don't know why adding these two speical tokens and how do you know this two special tokens? Coule you please help this?~
About outputs:
from transformers import AutoModelForCausalLM, AutoTokenizer

tokenizer = AutoTokenizer.from_pretrained("baichuan-inc/Baichuan2-7B-chat", trust_remote_code=True)
model = AutoModelForCausalLM.from_pretrained("baichuan-inc/Baichuan2-7B-chat", device_map="auto", trust_remote_code=True)
inputs = tokenizer('你好吗', return_tensors='pt')
pred = model.generate(**inputs, max_new_tokens=64,repetition_penalty=1.1)
print(tokenizer.decode(pred.cpu()[0], skip_special_tokens=True))

output screenshot:

As the screenshot shown, not sure why it's different from your example, but outputs of your repo looks good!

There are actually two kinds of tokenization strategies. For base models (pretrained without SFT) like Baichuan2-7B, it's fine to directly encodes the text into token ids without adding any special prefix or suffix tokens, just as your tokenizer('你好吗', return_tensors='pt'). However, for chat models (after SFT) like Baichuan2-7B-Chat, they are usually trained on a specific prompt template during SFT. When they're deployed for inference, their prompt patterns should be respected. In this case, Baichuan2-7B-Chat uses a prompt template like: (see https://huggingface.co/baichuan-inc/Baichuan2-7B-Chat/blob/main/generation_utils.py#L30-L43)
<user_token_id>prompt1<assistant_token_id>response1<user_token_id>prompt2<assistant_token_id>response2 ...

where <user_token_id> is 195 and <assistant_token_id> is 196 according to their generation config (see https://huggingface.co/baichuan-inc/Baichuan2-7B-Chat/blob/main/generation_config.json#L5-L6). We should add these special tokens to make it chat normally.

Thanks for your reply. I closed this issue.


Template management component for dynamic prompt

If the admin wishes to prompt the user for any additional information or display custom pages of their own during the authentication process, what the IS server is currently providing is a generic form for information input with minimum customizability.
To grant the admins the ability to customize the user prompt pages and to add custom pages, a template management system is in place. With this Template Management System, identity admins can add/ update/ delete templates that they develop from the management console.

Fixed with
https://github.com/wso2/carbon-identity-framework/pull/2002
https://github.com/wso2/carbon-identity-framework/pull/1998
https://github.com/wso2/product-is/pull/4135

Disabled the feature [1] since it is not production ready
[1] https://github.com/wso2/product-is/issues/4620


fix(abg): handle non-numeric versions gracefully

Fixes #1667.
In the logic, we were trying to parse version like v2-beta into an
integer. We could generally try to do it, but I think there are too
many possible variations to support them, so let's just support
versions that after removing the leading v, gives us an integer.

#1668  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @krzema12 and the rest of your teammates on  Graphite


Allow custom port number in printer url

Currently unable to add custom port to the printer url, normally this is done via the http://url.com:port but upon entering the ':' character it says the URL is invalid.

Never mind, shows invalid URL soon as the : is pressed but goes valid once the port number is added, i see why from the RegEx
"(http|https)://((\w)|([0-9])|([-|_]|[\.|/])*)+(:[0-9]+)?"


Daedalus stake key is not recognized by cardano-cli

A stake key of a restored ITN Daedalus wallet in Daedalus 1.5.1-STN4 is not recognized by cardano-cli 1.17.0.
The query stake-address-info fails with invalid address. See below.
The stake key was copied from the transaction log within Daedalus that included the stake reward as tx input.
stake_addr1ux6xkhz7zfvq5pz8uvy6e2qqulnj4gp2k29qpp70kdjrmagh9agha

The format is different from the address format created by the cardano-cli:
stake1u92m8xkme6aym25xrm70ee2cwx7n0k5uvw4md0u2h93peac3n0794

Adapting the prefix does not make the key valid either:
stake1ux6xkhz7zfvq5pz8uvy6e2qqulnj4gp2k29qpp70kdjrmagh9agha

Examples:
cardano-cli shelley query stake-address-info --address stake_addr1ux6xkhz7zfvq5pz8uvy6e2qqulnj4gp2k29qpp70kdjrmagh9agha --cardano-mode --testnet-magic 42
option --address: Failed reading: invalid address

cardano-cli shelley query stake-address-info --address stake1ux6xkhz7zfvq5pz8uvy6e2qqulnj4gp2k29qpp70kdjrmagh9agha --cardano-mode --testnet-magic 42
option --address: Failed reading: invalid address

cardano-cli shelley query stake-address-info --address stake1u92m8xkme6aym25xrm70ee2cwx7n0k5uvw4md0u2h93peac3n0794 --cardano-mode --testnet-magic 42
{
    "e055b39adbceba4daa861efcfce55871bd37da9c63abb6bf8ab9621cf7": {
        "delegation": "3f5be3b86753c2a0253e44125ef991e8623021903f011924c50389f3",
        "rewardAccountBalance": 0
    }
}

Bech32 conversion solves the problem!


Fix the CI configuration

Signed-off-by: aisuko<EMAIL_ADDRESS>fiexes: #140 #141

@Aisuko The changes look good. Will you be able to address to the static checks? They are mostly just comments which are missing.

@Aisuko The changes look good. Will you be able to address to the static checks? They are mostly just comments which are missing.

No problems.


Run command does not execute current script when using unittest

Consider the two below files using unittest:
test1.py
import unittest

def fun(x):
    return x + 1
class MyTest(unittest.TestCase):
    def test(self):
        print "test = test1.py"
        self.assertEqual(fun(3), 4)

if __name__=='__main__':
    unittest.main()

test2.py
import unittest
# content of test_sample.py
def func(x):
    return x + 1

def test_answer():
    assert func(3) == 6

if __name__=='__main__':
    unittest.main()

If I load both files into Spyder then make test1.py the active window, I can execute the test via the 'run' button or f5. This will give the following output:
runfile('C:/Users/YE91224/Desktop/test2.py', wdir='C:/Users/YE91224/Desktop')
.test = test1.py

Ran 1 test in 0.000s
OK
In [11]:
If I then switch window and execute the second unittest (script) via pressing the run button or F5 the behaviour is not as expected.  In fact it will still run the old file, not the new active window.  Even if I make changes to the active / open file, then press F5/run the untittest that executes is still the old unittest from the previous script, not the current test.
Spyder Version:  2.3.1
Python Version:  2.7.8
Qt Version    :  4.8.6, PyQt4 (API v2) 4.10.4 on Windows
pyflakes >=0.5.0:  0.8.1 (OK)
pep8 >=0.6      :  1.5.7 (OK)
IPython >=0.13  :  2.2.0 (OK)
pygments >=1.6  :  1.6 (OK)
pandas >=0.13.1 :  0.14.1 (OK)
sphinx >=0.6.6  :  1.2.3 (OK)
rope >=0.9.2    :  0.9.4 (OK)
matplotlib >=1.0:  1.4.0 (OK)
sympy >=0.7.0   :  0.7.5 (OK)
pylint >=0.25   :  None (NOK)

There's now a plugin to run tests in Spyder. Hopefully it fixes this problem.


build(docker): fix XRootD repository location

The CERN storage team repository from which the XRootD packages were installed has temporarily moved its URL location from "debian" to "old_debian", with plans to move it back. This fix therefore attempts to recognise both URLs so that the builds would work regardless of where the repository is hosted.

I could successfully build and deploy the cluster locally


Implemented reconnection feature

This PR contains the reconnection feature and a UI toggle switch to activate it.

Approved :D
:panda_face: :+1:

Looks good!


How to print the trace when segmentation fault happened

Hi @BigFaceBoy, signal-safe stack tracing is tricky to do. You may be able to simply call cpptrace::generate_trace().print() from a signal handler and get away with it, but it's risky (segfaulting again or deadlocking are the primary concerns). I have written up instructions for how to do this safely at https://github.com/jeremy-rifkin/cpptrace#signal-safe-tracing and https://github.com/jeremy-rifkin/cpptrace/blob/main/signal-safe-tracing.md. Hope these help, I'm happy to help with any additional questions!

@jeremy-rifkin Hello. In signal_demo.cpp , register  the handler to sigaction. I wonder how  to ensure that the handler will be called.
In my program, I register a handler to sigaction for printing the call stack when segmentation fault happened. But sometimes it will not print the call stack, the handler may not be called.

I don't know of any way right off hand that a sigaction handler could not be called when that signal fires. If you're able to reproduce, are you able to observe anything in gdb? Does something go wrong in your handler? Does your program SIGSEGV or is it another signal?

@jeremy-rifkin Thanks, I will debug with gdb to find out what cause this

@jeremy-rifkin

Hi @BigFaceBoy, unfortunately both using std::cout and cpptrace::generate_trace().print(); are not async-signal-safe so it's not guaranteed to work. It's very possible you could be hitting a deadlock or some other critical error that results in an abort or trap. The https://github.com/jeremy-rifkin/cpptrace/blob/main/signal-safe-tracing.md doc provides an example for how to do this safely, it is unfortunately a lot of work but it's pretty much the only way to truly do this safely.

@jeremy-rifkin Hello， I build the demo  signal_demo.cpp and signal_tracer.cpp， the run signal_demo. It prints:
SIGSEGV ocurred:
Stack trace (most recent call first):

Have you configured cpptrace to use libunwind? Unfortunately that's the only way to do signal-safe unwinding. If you haven't, clear your build directory / cmake cache and configure with -DCPPTRACE_UNWIND_WITH_LIBUNWIND=On. This does require you to have libunwind installed.

@jeremy-rifkin I compiled with -DCPPTRACE_UNWIND_WITH_LIBUNWIND=On. But I still get empty trace:
SIGSEGV ocurred:
Oops, size mismatch 4120 4120
Stack trace (most recent call first):
empty trace

size mismatch 4120 4120 is odd to me, fread should be reading exactly one item and returning 1 if successful. What system are you on? Does -DCMAKE_BUILD_TYPE=Debug change anything?

Thanks @BigFaceBoy, I'll look into this more

Sorry this hasn't been as seamless as a process as I'd have liked. Unfortunately to do these traces safely a lot of logistics are required. The Unable to read file Unable to read object file error seems to indicate the library is trying to open a blank path, so it'd probably make sense to skip the frame.resolve() any time frame.object_path is empty.
I can update the signal demo to do this, or update the internal handling to better deal with this.
I'm going to close this for now. Thank you for your patience and please let me know if there's anything else I can help with or if you run into any additional issues.


SQS: EmptyBatchRequest error with slightly older @aws-sdk/client-sqs package (e.g. 3.445.0)

Hi,
When using this service with a slightly older version of the AWS SDK (e.g. 3.445.0) we get an error like the following when receiving some SQS messages (note that here we're manually calling send on the SQS client with a DeleteMessageBatchCommand). This works with the real AWS SQS service.
const entries = [
  {
    Id: '309ef453-bf32-42c5-a45e-2e1c2083e5af',
    ReceiptHandle: '309ef453-bf32-42c5-a45e-2e1c2083e5af#fd721ed5-6317-437e-8f23-1b3bdb20bc53'
  }
]
client.send(new DeleteMessageBatchCommand({ Entries: entries, QueueUrl: queueUrl }))

EmptyBatchRequest: UnknownError
    at de_EmptyBatchRequestRes (/opt/nodeservice/node_modules/@aws-sdk/client-sqs/dist-cjs/protocols/Aws_query.js:1036:23)
    at de_DeleteMessageBatchCommandError (/opt/nodeservice/node_modules/@aws-sdk/client-sqs/dist-cjs/protocols/Aws_query.js:498:25)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /opt/nodeservice/node_modules/@smithy/middleware-serde/dist-cjs/index.js:35:20
    at async /opt/nodeservice/node_modules/@aws-sdk/client-sqs/node_modules/@aws-sdk/middleware-signing/dist-cjs/awsAuthMiddleware.js:14:20
    at async /opt/nodeservice/node_modules/@smithy/middleware-retry/dist-cjs/index.js:320:38
    at async /opt/nodeservice/node_modules/@aws-sdk/client-sqs/node_modules/@aws-sdk/middleware-logger/dist-cjs/loggerMiddleware.js:7:26
    at ... {
  '$fault': 'client',
  '$metadata': {
    httpStatusCode: 400,
    requestId: undefined,
    extendedRequestId: undefined,
    cfId: undefined,
    attempts: 1,
    totalRetryDelay: 0
  },
  Error: {
    Type: 'EmptyBatchRequest',
    Code: 'AWS.SimpleQueueService.EmptyBatchRequest',
    Message: "The batch request doesn't contain any entries.",
    message: "The batch request doesn't contain any entries."
  },
  RequestId: '00000000-0000-0000-0000-000000000000'
}

Hm, this looks like it should work I think.  What version of GoAWS are you on?

Hm, this looks like it should work I think. What version of GoAWS are you on?

Thanks for the response. v0.5.0, I believe.

Hm, I'll see if I can recreate it.  Thanks!

@mattcobley thanks for bringing this to our attention!  Definitely a problem here.  🤦  I just put up a PR for it - https://github.com/Admiral-Piett/goaws/pull/336  That should take care of it I think.  It'll be out in v0.5.2, I'll let you know when it's out.


Gulpfile changes

Separate module.exports to functions
Add clean function to gulpfile
Add default function to clean, then build module and browser
Change build scripts in package.json to work with new Gulpfile

Looking good


SP5: Improve label rendering logic

Every time labels are rendered a lot of logic is re-implemented (and often incorrectly). Consider this difficult case: Render a text label with a custom font and yellow letters over a blue background with 10px padding around the edges, rotated 45º, with the label's upper-right point centered at coordinate (123, 456)
Label.Draw() gets pretty close, but it doesn't support padding and when I tried to implement it, rotation produced alignment issues
https://github.com/ScottPlot/ScottPlot/blob/f287cb16bf11dfac38f4f00412d636252677d3ed/src/ScottPlot5/ScottPlot5/Primitives/Label.cs#L78-L116
This issue will track creating a better solution, and refactoring the Label class while I'm working on it


Setting Startup URL via --app does not work

Chrome is able to accept --app "http://github.com" but it does not work with Chilipie Kiosk.

Good point, and this is definitely on the radar!
In those cases the biggest hurdle is usually this: most people's dashboards aren't going to be publicly available on the Internet, so you'd still need to authenticate, with a login form or something. Being able to specify that via command line args/SSH is more complicated.

Yes, you're right. If the webpage uses a http basic auth, it's quite simple to define the user and password in the url, but for a advanced auth process, you have to use a mouse and keyboard…
… Maybe for all the other url, that would be useful ?

Created #31 to track this.


configMap not available as option to use in deployments.

Rancher versions: v2.0.0-alpha27
Steps to Reproduce:
Created a config name for a namespace.

When creating a pod in this namespace , "Add from Source" does not have Config Map option enabled.

For volume , there is no "use a config map" option.

Version - 2.0 master 4/17
Verified fixed


Incorrect patterns in DateTimeFormatInfo.InvariantInfo

Hi, I found a slight discrepancy in DateTimeFormatInfo.InvariantInfo. The several fields contain incorrect patterns, e.g.:
longDatePattern: "dddd, MMMM dd, yyyy"

However, in .NET Framework the following code produces a different result:
// Outputs "dddd, dd MMMM yyyy"
Console.WriteLine(DateTimeFormatInfo.InvariantInfo.LongDatePattern);

I'm going to fix these patterns as a part of Convert class implementation.

What culture are you testing with? Likely we should be rendering as Invariant by default.

You are right, the information above is for Invariant culture, you can see the entire entity here:
https://github.com/bridgedotnet/Bridge/blob/master/Bridge/Resources/Globalization.js#L41

yep, you are correct. Good find. I read the title too quickly on the first post and missed that you were already testing with InvariantInfo.
This will need to get fixed. The other format specifiers should be checked too.

There were several other errors in the formats. I'm not sure where these came from, but looks like they were pull from the wrong culture (likely en-US).
Here's the full list of corrections I found:
     dddd, MMMM dd, yyyy h:mm:ss tt // Existing
     dddd, dd MMMM yyyy HH:mm:ss    // Revised

longDatePattern:
     dddd, MMMM dd, yyyy // Existing
     dddd, dd MMMM yyyy  // Revised

longTimePattern:
     h:mm:ss tt // Existing
     HH:mm:ss   // Revised

shortDatePattern:
     M/d/yyyy   // Existing
     MM/dd/yyyy // Revised

shortTimePattern:
     h:mm tt // Existing
     HH:mm   // Revised

yearMonthPattern:
     MMMM, yyyy // Existing
     yyyy MMMM  // Revised```

We should try to get this into 1.11. Easy fixes, but writing the test might prevent it from this release. We will try.

Thanks for the detailed information on that.
I hope it will go smoothly. I've fixed the formats and updated the unit test, all tests passed.

If you fixed each format and each are tested, can you send a pull request? We could likely get it accepted right away.

@AndreyChechel , thanks for the contribution.
We incorporated you code change into a pull request #971 and merged into master.


unit tests fail (curl)

Performing unit tests after a new build and system-wide install of MAVSDK, 3 tests fail:
[----------] Global test environment tear-down
[==========] 61 tests from 12 test cases ran. (42358 ms total)
[  PASSED  ] 58 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CurlTest.Curl_DownloadFile_WithoutProgressFeedback_Success
[  FAILED  ] CurlTest.Curl_DownloadFile_ProgressFeedback_Success
[  FAILED  ] CurlTest.Curl_DownloadFile_ProgressFeedback_COULDNT_RESOLVE_HOST
any ideas?
log.txt

Thanks for reporting, let me have a look if I can reproduce.

It works for me which would mean either your internet connection was flaky when you ran it or the servers were not responding for some reason.
This reminds me that we should actually move the curl unit tests to integration tests because unit tests are not supposed to need anything to run, so they should not depend on an internet connection.


Making Polygons Tool Error  - IndexError : list index out of range

Hi Folks-
I am running into the error of "IndexError : list index out of range"  when running the Making Polygons tool in ArcMap. It appears to be triggered by line 302 - lastPt = cpList[0]
I've attached an image of the dialog box. Let me know what I can do to fix it.
Thanks,
Lauren

Hi Lauren,
Apologies for not getting back to you sooner. I don't have a suggestion yet, but I will l run some tests today.

Hi Lauren,
Turns out I could not get the Make Polys tool to run without errors or hang as it was trying to write one of the error feature classes to the geodatabase. So, I added a simpler and less robust tool to the toolbox. It is in the latest release (v1.6) and is called Rebuild MapUnit Polygons. You cannot use the new tool to make MapUnit polygons from scratch; use the ArcGIS Feature to Polygon tool for that, but you can use alongside editing sessions if you are editing linework to change the shape of polygons or make new ones and you want to re-build the polygons every few edits.
The new tool mostly uses code for a tool I wrote years ago after some frustration trying to use the Topology Edit tool so if you are comfortable using that, then this new tool is basically moot.
Let me know if you prefer the functionality of the Make Polygons tool and I can try another crack at it.


[Code Health] Rename Record to Observation everywhere except remote db

Work towards #143, #174. Depends on #280.

@scolsen merged #280, so commits and diffs should all be correct now. PTAL!

Yep, that's intentional. We'll change those once we switch over to the
latest schema. thanks for reviewing!


Use the same Python environment when using pip.

If system has older pip version then pydep can fail as you can see in srclib-python travis errors.
This fixes the issue by making sure that pydep uses pip of the Python environment it was called from.

thanks for the patch!


Do formal validation of the form inputs

Is your feature request related to a problem? Please describe.
Even though we currently have checks for blanks in the form, we should add a library for official validation of every form. For example, there's nothing that checks if a link is valid or a date is valid.
Describe the solution you'd like
We can use validator.js or another library that does frontend validation.
Describe alternatives you've considered
We could also do validation on the backend, but that's a lot of unneccessary API calls that I want to avoid.
Additional context
Replacement of #76

already kinda did this


afterAll fails to close Express server and leaves open handles

🐛 Bug Report
Jest fails to close the Express server in the afterAll hook and leaves an open handle. After running into this issue with both supertest and axiosist, and then trying to roll my own solution, I'm starting to think this is actually an issue with Jest.

relevant supertest github issue
relevant axiosist github issue
relevant stackoverflow question

To Reproduce

Clone this repo
Checkout the jest-github-issue branch
Run npm install
Create .env file containing NODE_ENV=test
Run npm test

Expected behavior
Jest should close the Express server in the afterAll hook and not leave any open handles
Link to repl or repo (highly encouraged)
https://github.com/johncmunson/todo-api
Be sure to checkout the jest-github-issue branch
envinfo
System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  Binaries:
    Node: 10.16.3 - ~/n/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/n/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0

After following @SimenB's advice here, I converted my beforeAll and afterAll hooks to use done instead of being async. His advice did not work, and the issue is not resolved. Jest still leaves open handles.
const { createServer } = require('http')
let axios = require('axios')
const getPort = require('get-port')
const { app } = require('../../index')
const { Todo } = require('../../models')

let server

beforeAll((done) => {
  return getPort()
    .then(port => {
      axios = axios.create({ baseURL: `http://localhost:${port}` })
      server = createServer(app)
      server.listen(port, done)
    })
})

afterAll((done) => {
  server.close(done)
})

describe('GET /todos', () => {
  it('returns a list of todos', async () => {
    const { data: todos } = await axios.get('/todos')
    todos.forEach(todo => {
      expect(() => Todo.fromJson(todo)).not.toThrow()
    })
  })
})

This is because knex has a connection pool. This diff will exit the process correctly, but probably also make it so you can't reuse your db in other tests. You should startup and close a db connection in every test, not have a shared singleton.
diff --git i/tests/integration/todos.test.js w/tests/integration/todos.test.js
index d5e79d5..a37475e 100644
--- i/tests/integration/todos.test.js
+++ w/tests/integration/todos.test.js
@@ -2,6 +2,7 @@ let axios = require('axios')
 const getPort = require('get-port')
 const { app } = require('../../index')
 const { Todo } = require('../../models')
+const knex = require('../../db')

 let server

@@ -13,6 +14,7 @@ beforeAll(async () => {

 afterAll(() => {
   server.close()
+  knex.destroy()
 })

 describe('GET /todos', () => {

Note that you should probably wait for both close and destroy to invoke their callbacks.
We have a guide for mongodb - I'm sure knex is similar enough that it can be applied https://jestjs.io/docs/en/mongodb

@SimenB thank you for drawing my attention to the testEnvironment config property. Perhaps drawing more attention to this in the docs would be helpful, because unintuitively it would seem that in many cases globalSetup and globalTeardown are not sufficient on their own. I will make another comment with my solution once I've got it working. Perhaps it can be the basis for a new example repo in the docs, similar to the mongo example.

Yeah, sounds good! Happy to take any other doc updates to make it clearer as well

On a sidenote, jest-circus looks absolutely fascinating. The ability to act on any one of these Jest events looks very powerful!


for a waterfall website ,can you set a function for auto scroll down until "selector" shown?

as title
or how to scroll down ?

Steps to reproduce
Tell us about your environment:

Puppeteer version:
Platform / OS version:
URLs (if applicable):

What steps will reproduce the problem?
Please include code that reproduces the issue.

What is the expected result?
What happens instead?

@Wolke you'll have to implement this on your end knowing the specifics of the website you're working on. There's no general way to do that.

Maybe this issue can help a little: https://github.com/GoogleChrome/puppeteer/issues/844