[🐞] _getInfo(originalSrc) fails to fetch the image size if using self-signed cert.

Which component is affected?
Qwik Optimizer (rust)
Describe the bug
I am testing my app at local environment with self-signed cert.
I have placed an <img> tag with static images located under the ./public/ and then the error caused even if the cert is installed as trusted.
GET https://foo.local:5174/__image_info?url=https%3A%2F%2Fjotter.local%3A5174%2Fimages%2Fdefault-face.png net::ERR_ABORTED 500

It seemed the _getInfo() in optimizer/src/plugins/image-size-runtime.html failed to fetch the image size because of the cert issue which might be relating with configuration of the undici.
Reproduction
couldn't provide because relating with the cert issue.
Steps to reproduce

setting up self-signed cert in the vite.config.ts
place an <img> tag with some static image in some component.
start the dev-server and see the page
check out the console log.

System Info
System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M2
    Memory: 84.06 MB / 24.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 20.5.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.1 - /opt/homebrew/bin/npm
    pnpm: 8.6.11 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 115.0.5790.170
    Safari: 16.5.2
  npmPackages:
    @builder.io/partytown: ^0.8.0 => 0.8.0
    undici: 5.22.1 => 5.22.1
    vite: 4.4.7 => 4.4.7

Additional Information
No response

Found workaround that is setting the env var NODE_TLS_REJECT_UNAUTHORIZED to  0 and start dev server.
But note for once this error occurred, the fetch always fails until clear the browser cache.

It might be a solution that setting the NODE_EXTRA_CA_CERTS env var to the certs path specified in the vite.config.ts


Update README.md

v3 of upload-artifact dependency is no longer recommended

Raised https://github.com/adoptium/run-aqa/issues/195 for the broken PR tests (not related to this PR).


Markdown stops rendering after custom components

If we want to use a bold for example after a custom component, the markdown will render correctly the custom component but not the following text. It seems to be only when the markdown is on multi lines.
const Text = (props) => {props.children}

# Important to put on multi lines here
const markdown = `
<Text>Hello world!</Text> **bold**
`;

<Markdown options={{ overrides: { Text: { component: Text } } }} >
  {markdown}
</Markdown>

Expected: bold
Result: **bold**
It was working fine in version 7.1.5 but not since 7.1.6.

I'm also experiencing this, with default html elements as well as custom components.
Can reproduce on https://probablyup.com/markdown-to-jsx/ with (the newline is important):

 **bold**

I'm using 7.2.1, downgrading to 7.1.5 also fixes it for me.

Facing same issue on 7.4.7. Any updates/plans to fix this ?

Facing same issue on 7.4.7. @quantizor any updates/plans to fix this ?

Will try to take a look this weekend

@quantizor  Were you able to check this ?


fullnameAndEmail problem solved using types

Description
Add new class "Employee" using types in methods to get fullname and email for Employee Object.
Issue No.- #257

Type issue number after hash(#)

Checklist

[ ] Yes, this task assigned to me.
[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

wrong issue number


Implement SetEvent()

Fixes #123.

@rodrigc PTAL.

Codecov Report

Merging #136 into master will increase coverage by <.01%.
The diff coverage is 100%.


Track key unhandled DialogEvents in telemetry

SDK tracking issue microsoft/botframework-sdk#5861
Send a trace activity and log a trace event via the telemetry client for 'versionChanged' and 'error' dialog events.
.NET PR https://github.com/microsoft/botbuilder-dotnet/pull/4270

@luhan2017 and @chon219 , could you please let us know if this is on track to be done in R10? Thank you.

@luhan2017 and @chon219 , could you please let us know if this is on track to be done in R10? Thank you.

We already have a PR and I think it is ready to be merged, @stevengum can you verify that? Thanks.


Track Selector

Is there a way to invoke Track Selector dialog?
Thank you! :)

i am not implementing a dialog but i  have implemented a method to set maxBitRate so we can be able to set the quality
will push this by this weekend


Fix cfs-signed override check

Minor fix, though the original code shouldn't ever cause any issues.

Does this need to be in master as well?

Does this need to be in master as well?

Good point. Yes, I'll make another PR for that.


Build failure: python311Packages.sphinxcontrib_newsfeed

Steps To Reproduce
Steps to reproduce the behavior:

build python311Packages.sphinxcontrib_newsfeed

Build log
https://paste.sr.ht/~toastal/1a0d87838090073fa4d068f51a34cf9dda776cb4
Additional context
This was part of building khal
Notify maintainers
none listed

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix shell nixpkgs#nix-info --command nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.7, NixOS, 23.11 (Tapir), 23.11.20231019.7c9cc5a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(toastal): `""`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I discovered this yesterday and bisected the build failure to be introduced in 2b1ad99374ed5af40dd3603b63b12ad11eb19af3. Didn't get to look much further into it

Yup, got the same problem here

@natsukium do you know whether #259350 will fix this issue?

That PR will not fix this problem.
We need to relax the constraint of docutils version for checking.

Sorry to ask, but is there any progress?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-pin-a-single-software-to-a-specific-version-when-using-home-manager/34874/1

If I'm not mistaken 91bf7eff618ee531a5510115ebaab4890780a8c1 does fix this build failure, and will be merged with #263535, the current staging cycle.

As the mentioned PR has been merged now, sphinxcontrib_newsfeed (now also renamed to sphnixcontrib-newsfeed) builds again.


raftstore: limit snapshot generation based on actual I/O usage

This PR enhances the snapshot generation mechanism to limit speed based on actual I/O usage。
In the previous implementation, the snapshot generation speed was limited by the I/O limiter based on the logical scanned key-value size. This approach was inaccurate due to SST compression and negatively impacted scale-in/scale-out efficiency. To address this, the I/O limiter is now based on actual I/O usage.
After this change, in a non-cloud environment running TPCC-20000 workload, scaling out from 4 nodes to 7 nodes and then scaling in from 7 nodes to 3 nodes resulted in a 25% increase in scale-in/scale-out efficiency. The foreground P99 duration increased by only ~1ms (9%), while the P9999 duration increased by ~170ms (25%). The increase in P9999 duration is attributed to higher I/O usage, which caused the disk performance to degrade. This is reflected in the Write Raft Log duration, as shown in the images later.
Overall, the trade-off is justified and provides significant benefits.
Before this change:

After this change:

Before this change:

After this change:

Before this change:
(-generate: the total generation throughput for the cluster; -recv: the total receiving throughput for the cluster)

After this change:

Before this change, P9999 duration:

After this change, P9999 duration:

Write Raft Log duration is increased by ~1ms.

What is changed and how it works?

Issue Number: Close #17973

What's Changed:
This PR enhances the snapshot generation mechanism to limit speed based on
actual I/O usage instead of the logical size of scanned key-value pairs.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

none

/cc @glorv @hbisheng @Connor1996 @LykxSassinator @v01dstar PTAL, thanks~

Pls supply the release note of this PR.

/ok-to-test

/retest

/retest


[C++][CI] Set CTEST_PARALLEL_LEVEL to $concurrency

Currently the default test target runs serially while unittest arbitrarily uses 4 threads. On many systems that's suboptimal. The environment variable CTEST_PARALLEL_LEVEL can be set to run tests in parallel, and we should probably have a good default for it (like the hardware concurrency)
https://cmake.org/cmake/help/latest/manual/ctest.1.html
Reporter: Ben Kietzman / @bkietz
Note: This issue was originally created as ARROW-8012. Please see the migration documentation for further details.

We're passing a proper --parallel value nowadays, closing as stale.


Boolean values always are false in dependency container

laravel/framework: v5.7.26
laravel/nova: v1.3.2
epartment/nova-dependency-container: 1.1.1
I have 2 Boolean fields in DependecyContainer
Text::make('Domain'),
NovaDependencyContainer::make([
    Boolean::make('Redirect to www')->rules('required'),
    Boolean::make('Force HTTPS'),
])->dependsOnNotEmpty('domain'),

When I check the checkboxes, The request has the values as true, but the response always is false for these boolean fields.
If I remove the container and just use Boolean fields, everything works as expected.

Same trouble:

laravel/nova: v1.3.2
epartment/nova-dependency-container: 1.1.1

Though with only one boolean field:
`NovaDependencyContainer::make([
Boolean::make('Subscribed', 'no_bulk')
        ])->dependsOnNotEmpty('do_not_contact'),`

I'm having the same issue as @yaroslavshyshkin and @ArmeniaH

laravel/nova v1.3.2
epartment/nova-dependency-container: 1.1.1

NovaDependencyContainer::make([
Boolean::make('Has Billable Shipping'),
])->dependsOn('is_material', true),

@unxsist Any chance we will get update any time soon?

@ArmeniaH @yaroslavshyshkin @FhatFreak  I'm unable to reproduce the problem with given examples, it seems to work just fine, tested with latest v1.2, Laravel 5.8|6.0 and Nova 2.3, can you confirm?


Issue: Not getting desired output while implementing memory

Issue you'd like to raise.
`below is my code for generating custom prompt which takes context and user query and we pass it into model:
def generate_custom_prompt(new_project_qa,query,name,not_uuid):
check = query.lower()
result = new_project_qa(query)
relevant_document = result['source_documents']
context_text="\n\n---\n\n".join([doc.page_content for doc in relevant_document])
# print(context_text,"context_text")
user_experience_inst = UserExperience.objects.get(not_uuid=not_uuid)
greetings = ['hi', 'hello', 'hey', 'hui', 'hiiii', 'hii', 'hiii', 'heyyy']
if check in greetings:
custom_prompt_template = f"""
Just simply reply with "Hello {name}! How can I assist you today?"
"""
elif check not in greetings and user_experience_inst.custom_prompt:
custom_prompt_template = f"""Answer the question based only on following context: {context_text}
You are a chatbot designed to provide answers to User's Questions:{check}, delimited by triple backticks.
Generate your answer to match the user's requirements: {user_experience_inst.custom_prompt}
    If you encounter a question for which you don't know the answer, please respond with 'I don't know' and refrain from making up an answer.
    - Before saying 'I don't know,' please re-verify your vector store to ensure the answer is not present in the database.

    Remember, your goal is to assist the user in the best way possible. If the question is unclear or ambiguous, feel free to ask for clarification.

    User's Question: ```{check}```
    AI Answer:"""
else:
    # Create the custom prompt template
    custom_prompt_template = f"""Generate your response exclusively from the provided context: {{context_text}}. You function as a chatbot specializing in delivering detailed answers to the User's Question: ```{{check}} ```, enclosed within triple backticks.
        Generate your answer in points in the following format:
        1. Point no 1
            1.1 Its subpoint in details
            1.2 More information if needed.
        2. Point no 2
            2.1 Its subpoint in details
            2.2 More information if needed.
        …
        N. Another main point.

        If you encounter a question for which you don't know the answer based on the predefined points, please respond with 'I don't know' and refrain from making up an answer.
        However, if the answer is not present in the predefined points, then Provide comprehensive information related to the user's query.
        Remember, your goal is to assist the user in the best way possible. If the question is unclear or ambiguous, you can ask for clarification.

        User's Question: ```{{check}} ```
        AI Answer:"""

# Create the PromptTemplate
custom_prompt = ChatPromptTemplate.from_template(custom_prompt_template)
formatted_prompt = custom_prompt.format(context_text=context_text, check=check)
return formatted_prompt

below is my conversation chain where i am inplementing memory
def retreival_qa_chain(chroma_db_path):
embedding = OpenAIEmbeddings()
vectordb = Chroma(persist_directory=chroma_db_path, embedding_function=embedding)
llm = ChatOpenAI(temperature=0.1)
memory = ConversationBufferMemory(llm=llm,output_key='answer',memory_key='chat_history',return_messages=True)
retriever = vectordb.as_retriever(search_kwargs={"k": 2})
qa = ConversationalRetrievalChain.from_llm(llm=llm,memory=memory,chain_type="stuff",retriever=retriever,return_source_documents=True,get_chat_history=lambda h : h,verbose=True)
# qa = RetrievalQA.from_chain_type(llm=llm, chain_type="stuff", retriever=retriever,return_source_documents=True)
return qa
but I am not getting desired output as expected   `
Suggestion:
No response

🤖
Hello @deepak-habilelabs! 🚀 Good to see you back here. We seem to be caught in a bit of a coding conundrum, aren't we? 🤔 No worries, we'll do our best to untangle it. 🌟
Based on the information you've provided and the context from the LangChain repository, it seems like the issue you're facing might be related to how you're structuring your prompts and how you're implementing memory in your application.
In your generate_custom_prompt function, it's important to clearly distinguish between previous chat history and the new input. This is because the LangChain model uses these distinctions to understand the importance of the new input. A similar issue was discussed in the LangChain repository here. The solution suggested was to structure the prompts like this:
...
To answer for the new input, use the following format:

New Input: the input question you must answer
Thought: you should always think about what to do
Action: the action to take, should be one of [Google Search, lookup_ingredients]
Action Input: the input to the action
Observation: the result of the action
... (this Thought/Action/Action Input/Observation can repeat N times)
Thought: I now know the final answer
AI: the final answer to the original input question in JSON format

DO NOT make up an answer. Only answer based on the information you have. Return response in JSON format with the fields: intent, entities(optional), message.

Previous chat history:

Human: Show me the ingredients for making greek salad
AI: XXX
Human: XXX
AI: XXX

Begin!:

New Input:

Regarding the implementation of memory in your retreival_qa_chain function, it seems like the SimpleMemory class in your code doesn't actually store or update any information. The save_context method, which is typically used to update the memory, is empty. This means that no matter what inputs or outputs you pass to it, it won't change the state of the memory. Similarly, the load_memory_variables method just returns the current state of the memory without making any changes or updates based on the inputs parameter.
If you want to store and update information in the memory, you'll need to modify these methods. For example, you could update the save_context method to store the outputs in the memories dictionary:
def save_context(self, inputs: Dict[str, Any], outputs: Dict[str, str]) -> None:
    self.memories.update(outputs)

And you could update the load_memory_variables method to update the memories based on the inputs:
def load_memory_variables(self, inputs: Dict[str, Any]) -> Dict[str, str]:
    self.memories.update(inputs)
    return self.memories

Please note that this is a simple example and might not fit your exact use case. You might need to adjust the code to fit your specific needs.
I hope this helps! If you have any other questions or need further clarification, feel free to ask.
Sources

Agent + Memory causing issues with tool interaction
libs/langchain/langchain/memory/simple.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

how can i implement custom prompt in retreival conversation chain?

🤖
Based on the information provided in the context, it seems you can pass your custom prompt to the ConversationalRetrievalChain.from_llm method via the combine_docs_chain_kwargs argument. Here's how you can modify your retreival_qa_chain function to include your custom prompt:
def retreival_qa_chain(chroma_db_path, custom_prompt):
    embedding = OpenAIEmbeddings()
    vectordb = Chroma(persist_directory=chroma_db_path, embedding_function=embedding)
    llm = ChatOpenAI(temperature=0.1)
    memory = ConversationBufferMemory(llm=llm,output_key='answer',memory_key='chat_history',return_messages=True)
    retriever = vectordb.as_retriever(search_kwargs={"k": 2})
    qa = ConversationalRetrievalChain.from_llm(llm=llm,memory=memory,chain_type="stuff",retriever=retriever,return_source_documents=True,get_chat_history=lambda h : h,verbose=True, combine_docs_chain_kwargs={"prompt": custom_prompt})
    return qa

In this code, custom_prompt is the custom prompt you want to use, which you can generate using your generate_custom_prompt function. You can call this function before calling retreival_qa_chain and pass the generated prompt as an argument.
This solution is based on the information provided in the Issue: Changing Prompt (from Default) when Using ConversationalRetrievalChain? in the LangChain repository.
Please note that the combine_docs_chain_kwargs argument is used to pass additional keyword arguments to the CombineDocsChain that is used internally by the ConversationalRetrievalChain. The prompt keyword argument is used to specify the prompt that should be used when generating responses.
If you're still facing issues, could you please provide more details about the problem? Specifically, what output are you getting and how does it differ from your expectations? This will help me provide a more accurate solution.
Sources

Issue: Changing Prompt (from Default) when Using ConversationalRetrievalChain?
libs/langchain/langchain/chains/retrieval_qa/prompt.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

Can implementing above code, what is structure of memory and how can i fetch the response?

🤖
In the context of the retreival_qa_chain function, the memory is an instance of the ConversationBufferMemory class. This class is designed to store the history of a conversation, which is used to provide context for generating responses. The memory is structured as a list of dictionaries, where each dictionary represents a turn in the conversation and contains the following keys:

'input': The input message for that turn.
'output': The output message for that turn.
'chat_history': The entire chat history up to and including that turn.

The output_key parameter in the ConversationBufferMemory constructor is set to 'answer', which means that the output message for each turn is stored under the 'answer' key in the dictionary.
To fetch the response from the retreival_qa_chain function, you would call the function and pass in your custom prompt as an argument. The function returns an instance of the ConversationalRetrievalChain class. You can then call the _call or _acall method on this instance, passing in a dictionary where the key is 'query' and the value is your custom prompt. The method returns a dictionary where the key is 'result' and the value is the generated response.
Here is an example:
qa_chain = retreival_qa_chain(chroma_db_path, custom_prompt)
inputs = {"query": custom_prompt}
response = qa_chain._call(inputs)
print(response["result"])

In this example, chroma_db_path is the path to your Chroma database, and custom_prompt is the custom prompt generated by your generate_custom_prompt function.
Please note that the _call method is synchronous and will block until the response is generated, while the _acall method is asynchronous and returns a future that will be resolved with the response. If you're working in an asynchronous context, you should use the _acall method.
For more information, you can refer to the BaseRetrievalQA class and its subclasses in the LangChain repository.
Sources

libs/langchain/langchain/chains/retrieval_qa/base.py

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

is there any other way to implement without conversation retreival chain as i dont want system message


[JA Presamp Phonemizer] Supports "っ", etc

New features:

Add replaces ぢ, づ, with じ, ず
Support for "っ"

Improvement:

When there is a phonetic hint, the lyrics are not replaced

The "っ" consonant lengthening symbol.
If the "a っ" is present, it is converted to it; if not, it is automatically converted to VC.

Added an improved version of #824 .


Switch to final version of Ignition spec 3.1.0

Switch FCC spec 1.1.0-experimental to produce stable spec 3.1.0 configs.  This breaks 1.1.0-experimental compatibility with Ignition < 2.3.0, which is permissible because we can break experimental FCC specs at any time.  In practice, https://github.com/coreos/fcct/pull/100 breaks inline in 1.1.0-experimental anyway for older versions of Ignition.
We'll support 3.2.0-experimental in 1.2.0-experimental, once 1.1.0 is stabilized.

Can we write down the semantics of how FCC spec versioning vs Ignition spec versioning match up in a document under docs/? (Or if it's already written somewhere else, let's put it under there?).

@jlebon There's no general rule.  In each FCC spec doc, the description of the version attribute gives the corresponding Ignition spec version (example).


Data.Generics.Any: Undefined field inside compose0, :% :: Ratio Int

Getting a runtime error on:
{-# LANGUAGE DeriveDataTypeable -}
module Main where

import Data.Ratio
import System.Console.CmdArgs

data Options = Options { r :: Ratio Int
                                      } deriving (Show, Data, Typeable)

defaultOptions = Options { r = 4 % 7 }

main = print =<< cmdArgs defaultOptions

The error message is:
Data.Generics.Any: Undefined field inside compose0, :% :: Ratio Int

The problem is that Ratio is defined with strict fields, specifically:
data  Ratio a = !a :% !a  deriving (Eq)

And that plays havoc with certain types of Data operations. Fortunately, I was able to fix it up relatively easily in this instance. I've released 0.10.13 with the fix.
While it's fixed, I didn't really expect people to pass Ratio on the command line, and it might not be as useful as you would hope.


TypeError: list indices must be integers or slices, not str

Hi,
I try to query
import osrm
result = osrm.simple_route([50.843920, 4.369253], [50.845794, 4.372178],output='route', overview="full", geometry='wkt')
result['geometry']

but the answer is an error TypeError: list indices must be integers or slices, not str
When i tried directly on OSRM server with
http://<IP_ADDRESS>:5000/route/v1/driving/polyline(yjtYomiuHiQuJ)?overview=full&steps=false&alternatives=false&geometries=polyline&annotations=true&continue_straight=default
I get a right answer.
What should i change ?
Thanks

The result of simple_route is a list (the error is telling you that you are trying to index that list with geometry).
You should try result[0]["geometry"] ie the geometry of the first route.

Please make sure the issue you report is about this library, not python related nor OSRM engine related.


🏃♂ Sprint 15/05/24

Guidelines for Beta

[ ] Getting to a consistent API between all components
[ ] Dogfooding each component in production
[ ] 100% coverage on all headless components (and a11y validated)
[ ] Logical test coverage on styled components which are not covered by headless
[ ] Visual tests for styled components
[ ] Build is optimized for tree shaking (or fix namespace issues)
[ ] Make docs fully optimized (shiki bug fix)

Actual Tasks
Must haves

[ ] Fix CLI on new projects - Shai & Maieul
[ ] Finish Popover tests (polyfill & critical tests) - Nate & Chris
[ ] Add docker for visual testing with playwright - Shai & Nate
[x] Rename ALL the styled components to dot notation - Maieul
[x] #726 - Maieul
[x] Complete refactor of Tooltip - Jack & Shai & Chris
[x] Refactor Accordion to remove useVisibleTask$ - Jack
[ ] Finish headless Checkbox - Nate
[ ] Add the SSG adapter - Maieul & Shai

Edit (Maïeul):

[x] update package.json deps (probably "@k11r/nx-cloudflare-wrangler") for node v21.7 compatibility and above: https://github.com/cloudflare/workers-sdk/pull/5201

Nice to haves

[ ] Review styled components - Maieul & Shai
[x] Styled Select component (Jack)
[ ] Complete sonner component (Victor)
[ ] Sort out the github project
[x] Change Modal API
[ ] Write tests for Combobox (look at the select ones)
[ ] Add the ability to add custom elements / components inside of select options
[x] Fix the "preserve modules" issue
[ ] Open an issue about PW component tests on PW github (Shai)
[ ] Make cli E2E test working (Shai)
[ ] Update the CLI to handle animation "apply" per component (Shai)
[ ] Test cli in nx projects (and sub folders) (Shai)

closing in favor of the GH project -
https://github.com/orgs/qwikifiers/projects/1/views/1


Added missing defines for AVX512 packets

Jenkins, test this please.
On Feb 25, 2017 2:27 PM, "Benoit Steiner"<EMAIL_ADDRESS>wrote:

@benoitsteiner https://github.com/benoitsteiner requested your review
on: tensorflow/tensorflow#7888
https://github.com/tensorflow/tensorflow/pull/7888 Added missing
defines for AVX512 packets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/7888#event-977230701, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT_Sbd_6RLMffEY0bOGNdRGk_WB11tWUks5rgKq1gaJpZM4MMKQk
.


some nodes are ignored

Input:
x: #@ { "first": "is included"}
  second: is ignored

The second line is silently ignored.
Also here:
--- #@ { "first": "is included"}
this line: is ignored too

If this is not valid, I'd expect an error message instead of silently ignoring part of the input.

same situation as above,
key: replaced-val #@ "computed-val"

@laurentlb yeah, we probably should error if we see that node has an existing value and also has a "computed" value. i cannot think of a case when it will be useful to allow above form. i can imagine if somehow computed value is conditional and we somehow indicate to keep the original node value, but im not sure that would be useful.


No releases

Releases tab empty
me lazy, me no have visual studio, me can not compile
please post binaries
thanks you

ok my dumbass didnt read the compiling section, please delete this issue

Sorry for not providing binaries, but I was really busy in the last couple of months and also didn't expected anyone to come across this since I never promoted it anywhere. I'm gonna compile some binaries right now.


Allow undoing making a node into a field

Should be a more elegant option than just deleting it. We could either concatenate the key + value with a space between, or we could just use the value for the node text.

If you've gone to the point of setting a value, I don't really understand why/when somebody would want to go back to a normal node.

I'm thinking mostly cases where they've made a mistake (so they most likely haven't set a value).

How many individual solutions to one-off undo should we have before figuring out undo?


rebased version of 2076-2 branch

this is the same, but on top of current master, and with some changes squashed
closes #115

Codecov Report

Merging #131 (a75d87b) into master (446a1a4) will increase coverage by 1.37%.
The diff coverage is 95.39%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   88.99%   90.37%   +1.37%
==========================================
  Files         113      125      +12
  Lines        5379     5724     +345
==========================================
+ Hits         4787     5173     +386
+ Misses        592      551      -41

Impacted Files
Coverage Δ

include/adm/detail/named_type.hpp
100.00% <ø> (+8.10%)
:arrow_up:

...clude/adm/elements/audio_block_format_binaural.hpp
93.75% <ø> (+7.08%)
:arrow_up:

include/adm/elements/audio_block_format_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_block_format_matrix.hpp
93.33% <ø> (+6.66%)
:arrow_up:

...nclude/adm/elements/audio_block_format_objects.hpp
100.00% <ø> (ø)

include/adm/elements/audio_channel_format.hpp
94.64% <ø> (ø)

include/adm/elements/audio_channel_format_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_content_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_object.hpp
100.00% <ø> (ø)

include/adm/elements/audio_object_id.hpp
100.00% <ø> (ø)

... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446a1a4...a75d87b. Read the comment docs.


Roll Plugins from 112fe4eb497a to 76799fa023b6 (1 revision)

https://github.com/flutter/plugins/compare/112fe4eb497a...76799fa023b6
2021-11-10<EMAIL_ADDRESS>Fix bugs in Dart Implementation of the Pigeon API  (flutter/plugins#4461)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Modify start pair after typing

Is your feature request related to a problem? Please describe.
I want to be able to add symbols before cursor after I have hit a pair trigger, for example
let |   .I press $, and text becomes  let $ | $, where | is cursor position.
Describe the solution you'd like
A way to make rule modify symbols before cursor, or simply move the cursor to the right
Describe alternatives you've considered
Maybe you can just move cursor somehow, haven't found a way to do that

on readme file
-- you can do anything with regex +special key
-- example press tab to uppercase text:
-- press b1234s<tab> => B1234S1234S

npairs.add_rules({
  Rule("b%d%d%d%d%w$", "", "vim")
    :use_regex(true,"<tab>")
    :replace_endpair(function(opts)
          return
              opts.prev_char:sub(#opts.prev_char - 4,#opts.prev_char)
              .."<esc>viwU"
    end)
})


SECURITY.md: Fix a broken markdown link.

Testing plan: Looked at it on Github.

Merged, thanks @alexmv!


fix: upgrade to version 3.1.335

from: https://github.com/jenkins-x/jx-cli

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm-kapp

vault
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm-kapp

vault
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test vault

gsm
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm-kapp

vault
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test vault

gsm
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm

tls
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm-kapp

vault
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test vault

gsm
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test gsm

tls
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test tls

kube
56c5009127a68b8d170c6e98ea7d237bf5b43529
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Add an API to list cortexes

Add an API to list cortexes

I guess we don't need to worry about pagination right? Generally not a lot of cortexes.

Yeah I'm deferring pagination until someone needs it. I was able to list 940 cortexes without pagination.


Fix null pointer when setmethod is null

If a targetProperty didn't have a set it causes the extension to crash

this has been fixed already in commit be65110e4003e42fbb76c707c5574895f13794ea on the develop branch. It should be released in few days. For now you can downloaded fixed version from develop build artifacts. Anyway, thanks for collaboration, I'm really appreciate.


Add UserFactory to rest-api project

Add a UserFactory to mirror the GraphFactory object and its behaviour. This will give developers an easy hook into which User creation can be controlled.

Merged into develop

Migration Steps
The default graph factory class has been renamed to:
uk.gov.gchq.gaffer.rest.factory.DefaultGraphFactory

A new user factory exists with class:
uk.gov.gchq.gaffer.rest.factory.UserFactory

The default UserFactory to be used in the rest api is:
uk.gov.gchq.gaffer.rest.factory.UnknownUserFactory

To override this set the rest system property:
gaffer.user.factory.class


Error: Verify otp failed. Mautic Error

Precondition:
The user wants to change the mobile number
User changes the mobile on the  "Edit profile" page and gets OTP
Steps to reproduced:

Enter the OTP in the field
Pay attention to the error message

Actual result: The error message is displayed on the "Edit profile" page  after entering the OTP in the field
Expected result: The mobile number should be successfully changed on the "Edit profile" page  after entering the OTP in the field
Env:  next.gooddollar.org
Note: the issue is reproduced also during the changing mail
Checked on NEXTorg V 1.0.5
Desktop: Windows 10 // Google Chrome  84.0.4147.125

does it happen on QA?

@AnastasiiaOdnoshevna This happens when the account on mautic doesn't exists
I assume this is because it is some test account that is used on multiple envs.
Because we dont have a dev/staging mautic env if you delete the account on dev env it will be also deleted on qa/prod.
The email/mobile changing flow should be tested on accounts that were recently created so you know the mauticId is synced and correct

@sirpy I have checked it out on the fresh account and here the result - the user is able to change the mobile/email successfully
Video: https://www.screencast.com/t/aLv42AuCzwTw


Double clicking on an item in Outline does not highlight occurrences.

Issue Type: Bug
Double clicking on an item in Outline does NOT highlight occurrences while directly clicking any occurance in the editor DOES highlight occurrences.  This seems inconsistent.
I found this while editing a python file.
...Bob
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.81GB (22.07GB free)

Process Argv
--crash-reporter-id 25d5146f-f41b-4131-9f51-4991f3fdae56

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

gather
ms-
2020.11.0

python
ms-
2020.11.358366026

vscode-pylance
ms-
2020.11.1

jupyter
ms-
2020.11.358541065

remote-wsl
ms-
0.51.3

vsliveshare
ms-
1.0.3121

We have written the needed data into your clipboard because it was too large to send. Please paste.

Please clarify what highlight means. What happens is that a single click selects the item and double selects the item AND puts focus into the editor

Please clarify what highlight means. What happens is that a single click
[in the outline] selects the item and double click [in the outline] selects
the item AND puts focus into the editor

What I mean by "highlight" is that when I click on an item in the editor
the background color changes on that occurrence as well as marking all
other occurrences in the file. I think that double clicking an object in
the outline should do a similar thing for occurances of the object.
I think that you should also consider:

Make subsequent  double clicks in the outline advance to the next
occurrence of the object.
Make an RMB click in the outline bring up the same menu that it does
when right clicking that object in the editor window.

I hope this helps.
...Bob
On Mon, Nov 16, 2020 at 12:53 AM Johannes Rieken<EMAIL_ADDRESS>wrote:

Please clarify what highlight means. What happens is that a single click
selects the item and double click selects the item AND puts focus into the
editor
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/110613#issuecomment-727834145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQVEH3P6T2RFR3C5RC4QP3DSQDSBBANCNFSM4TVIAADA
.

Closing this as designed. It's also likely that the extension providing your outline return non-empty ranges (leading the selection highlight). Generally, once the editor has focus and is active then it's editor rules and they make sense


Style updates

Just a couple of small styling updates:

I made the text area, under contact us, non resizable. When the text area was resized it would mess around with neighbouring elements, so I thought it'd be best to disable it.
I made the placeholder text for all input elements, under contact us, a little darker. It was previously at #eee and I've now bumped it up to #ccc to make it a little easier to read.

I ran into an issue before I was about to create the PR - the styling for the idea cards was missing. I think what might have happened is that the styles had previous only existed in agency.min.css (see: cba1da88d442a841f1c0a137771733725fcbc30e), so when gulp ran the minify task on setup it removed the styles. I found them in a previous commit and re-added them. I wasn't sure if that was the best solution, but it does look to be working again now.
Any issues let me know (this is my first PR to someone else's repo - I apologise in advanced if I've made any mistakes)

Hi, I saw you merged in the current master branch - is there anything else you'd like me to do to help this PR?

Hey @elliotmassen! I just had to make sure there weren't conflicts before I merged but this looks great!
Thanks for giving this repo a chance as your first PR! :+1:
Feel free to work on anything else in this repo! :blush:
(Also I noticed you are organizing HackSussex, I organize UBC Hacks in Vancouver! Yay hackathon fam :tada:)

Ah brilliant - great news! No worries 😊
Small world 🎉 Would love to go to a hack in the US or Canada some day!


Statusbar gone?

Using JLab 3.2.5, when switching on this beautiful theme, the statusbar is gone, which unfortunately I cannot live without.
Any way to get the statusbar back in?

Here's the official dark theme that supports the status bar:

I just noticed that the statusbar briefly flashed up and then goes away after activating the theme.

Hm.. Not sure where this is happening in the code but I will certainly look into it.

Still trying to pin this down, just wanted to say that if anyone has any idea as to how to re-surface the status bar I'd invite any tips (or better yet, a PR). Had some time to do a cursory look through the code today, no dice. Probably a bad copy/paste somewhere in the style/variables.css file.

Confirmed PR #7 fixes this issue - just published an update to PyPI (v0.2.3). Marking this closed. Thanks again @diegombar


Feature: Class Skills

These should be rollable, and would be needing to have various fields like:

Uses per day

These are different than talents that tend to provide passive buffs to characters.

Characters would need a learn new skill with a selection of DC 18 Int down to DC 9 Int.
The pop up needs an input field with the skill name and input field with skill description. If the check is successful then the user can create the skill and add it to their auxiliary skills.
Or is this outside the scope of this feature?

Characters would need a learn new skill with a selection of DC 18 Int down to DC 9 Int.
The pop up needs an input field with the skill name and input field with skill description. If the check is successful then the user can create the skill and add it to their auxiliary skills.
Or is this outside the scope of this feature?

Yeah, I don't recognize that as a rule from the books. If you can refer me to a page, I'll take a look though!


Search: CMD + K and Other OS's

Currently this seems to be tied to Mac, I have not tested it on other OS's it would be good to make it work with other OSs

I solved this one by allowing to trigger the search with ctrl+k as well.


Nothing Happning

Same problem. Unity 2018.2.09b. Just nothing happens

@arhcy Thanks for letting us know! Can you please check whether any errors appear in the console when you add a SpriteGlowEffect component? Also, check out SpriteOutline shader asset status (it will show any compilation errors in the inspector when selected).

I've updated the project to work with Unity 2018.2. Feel free to reply here in case the issues will still persist.


Fix missed Workbox v5 documenation change

Fixes: https://github.com/GoogleChrome/workbox/issues/2465
Target Live Date: ASAP

[x] This has been reviewed and approved by (@jeffposnick)
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 10 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/guides/using-bundlers.md#L259 - '


Update jobs endpoint to account for exceptions

Jobs Endpoint
Location

external.py

Details

updated get_records function with try and except block

Committed Features

users can view jobs for desired city

 DS will create endpoint that shares job opportunities


[SPARK-23312][SQL] add a config to turn off vectorized cache reader

What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-23309 reported a performance regression about cached table in Spark 2.3. While the investigating is still going on, this PR adds a conf to turn off the vectorized cache reader, to unblock the 2.3 release.
How was this patch tested?
a new test

cc @kiszk @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/505/
Test PASSed.

Test build #86966 has started for PR 20483 at commit 376c855.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/506/
Test PASSed.

Test build #86967 has started for PR 20483 at commit 53d3259.

Test build #86966 has finished for PR 20483 at commit 376c855.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #86967 has finished for PR 20483 at commit 53d3259.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86967/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86966/
Test FAILed.

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/523/
Test PASSed.

Test build #86983 has started for PR 20483 at commit 53d3259.

Test build #86983 has finished for PR 20483 at commit 53d3259.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86983/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master/2.3!

Thank you for adding this. I will look at the performance regression.


Fury breaking window

Equiping Fury on at least Finn and Ryoma is cause the whole window to go blank

It's happening with quite a few A-skills. Brazen Def/Res for sure


Checkboxes should be rendered with consistent indenting compared to bullet/numbered lists

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
When creating a checkbox, there's always an indent rendered before the checkbox itself, instead of adding the indent between the checkbox and its text (like it's done in lists).
Additionally, in case the line is too long, the second line starts at the same indent level as the checkbox, instead of being aligned with the text of the first line.
This makes lists look inconsistent when mixing checkboxes with bullet/numbered lists. Example here.
Describe the solution you'd like
Checkboxes should be aligned and indented the same way bullet points are. The checkbox itself should remain at the very beginning of the line, and the indentation should be inserted between the checkbox and its text. Ideally, checkboxes should be fully aligned with bullet points in case both elements are mixed in the same list.
Describe alternatives you've considered
--
Additional context

This bullet is correctly indented
[ ] This checkbox may or may not be
This one is fine again
[ ] If this checkbox is indented correctly and the text oveflows, the second line of text will be aligned with the first one, and with the bullet above it. This seems to work correctly in this GitHub post (although it's not pixel-perfect), but not in Dendron!

Thank you for the report. This is indeed something we can improve upon. We'll let you know once we get to this 🙏🏼


[bug] Deleting a Subnet Fails When DB Subnet Group Exists

Description
When trying to delete a RDS DB instance, it automatically tries to delete its related security group instead, which ultimately renders a terraform error since a subnet can't be deleted with an associated resource to it.
Official Provider Issue Related Discussions

terraform-provider-aws
terraform

Hey any progress on this?


MSSQL Server Vulnerability assessment points to wrong storage_account

Small bug in the below mssql_server sub-module.
The storage account for vulnerability assessments is not correctly referenced.
Currently sets to storage account defined in var.settings.security_alert_policy.storage_account
https://github.com/aztfmod/terraform-azurerm-caf/blob/master/modules/databases/mssql_server/vulnerability_assessment.tf#L8-L9
data "azurerm_storage_account" "mssql_va" {
  count = try(var.settings.security_alert_policy.vulnerability_assessment.storage_account.key, null) == null ? 0 : 1

  name                = var.storage_accounts[var.settings.security_alert_policy.storage_account.key].name
  resource_group_name = var.storage_accounts[var.settings.security_alert_policy.storage_account.key].resource_group_name
}

Should reference account defined in var.settings.security_alert_policy.vulnerability_assessment.storage_account
data "azurerm_storage_account" "mssql_va" {
  count = try(var.settings.security_alert_policy.vulnerability_assessment.storage_account.key, null) == null ? 0 : 1

  name                = var.storage_accounts[var.settings.security_alert_policy.vulnerability_assessment.storage_account.key].name
  resource_group_name = var.storage_accounts[var.settings.security_alert_policy.vulnerability_assessment.storage_account.key].resource_group_name
}

assign to me and I can fix

closing issue.  Fix was submitted in associated PR and subsequently merged into 5.3.0 release


Flasher is not working in Store, Update or Delete functions, but working in Index function ?

Hello Sir,
Working in Index Method :
    public function index(FlasherInterface $flasher)
    {
        $users = User::all();
        $flasher->addSuccess('Welcome To Users Section');
        return view('admin.users.index', compact('users'));
    }

But not working in :
    public function destroy(FlasherInterface $flasher, User $user)
    {
        $user->delete();
        $flasher->addSuccess('User Deleted!');
        return redirect()->back();
    }

What is the reason, Am I doing anything wrong ?
laravel framework = 9.11
package = 1.4.0

Hello @ravindra135, Thanks for reporting the issue.
I will look at it in a moment

Hello again, can you please upgrade PHPFlasher to v1.5.2, this will fix the issue.
And thank you again for your help

hey! @yoeunes Thank you so much,  I have updated to the version to  1.5.2, Now its working fine,


Adding Admin setting page

Added a Admin page to modify the plugin specific properties and do some additional checks to inform the admin of difference between the internal and external address. Also checks the usability of the repository folder.

Thanks for providing this! Many people are going to find this very useful!
I've added a bunch of commits to your PR that apply small changes. The most relevant change is one that aims to prevent CSS, by ensuring that user-provided input is escaped while rendered on screen.
@annovanvliet can you please verify that I didn't break anything for your environment?

fixed one essential type. Still one question about the Maximum file size. The readme says -1 to disable the check. This value cannot be entered. Also the code is checking if value is larger then 0. So setting value to zero also disables the check. Whereas we actually were hoping to to be able to block filesharing by specifying 0 as the Maximum file size.

Thanks for the fix, @annovanvliet!
The discrepancy between documentation and implementation with regards to the maximum file size setting is annoying. That should be aligned.
I'm not a big fan of re-using that particular setting to disable all of the functionality of the plugin. From an admin's perspective, that would be confusing, as we're mixing a very permissive configuration (do not use a limit) with a very restrictive one (disable all of the plugin). We should have a distinct setting for the latter (although one could just as well unload the plugin, I suppose).
There might be room for yet another configuration option: one that disables upload, but allows download. Pragmatically, I'm not sure if there's a use-case for that. If there is not, then adding such an option might only add to the maintenance burden of the plugin.

Thank you for your answer. You are raising a valid point with the permissive and restrictive site of the two distinct values. For now we go with the pragmatically solution of specifying 1 as the max size. An additional parameter is an option, but you are slowly opening an complete new area of functionality here, like access control and group or role based permissions to upload content, which might be for out-of-scope.

I agree that we best create new issues for newly desired configuration options, but I think it's fine to have a generic "enable/disable" option added to this PR. Is that something that would benefit your use-case?


Uniface

does your code (patial fc + uniface) work on wf42m? have you tried to train uniface + patial fc?

I don't think dataset matters as long as you process it to the correct format, so my answer is yes.

@HaiyuWu  thank you for your great work! Do you have a plan to benchmark on webface42m dataset ?

No problem. I am not planning to do it, because webface42m is too much for me to train. T . T


Create UNHCR theme directory

Closes #31
I'm pretty sure this is how we're supposed to start customizing Semantic UI. I copied the default theme into a new directory, called unhcr, and modified the theme configuration to point to that theme. From now on, all our customizations can be changes in the files under dataviz-styleguide/semantic/src/themes/unhcr.
@vidonne I've managed to figure out that in order to build the CSS file, you need to do the following:
cd semantic
gulp build-css

This depends on having Gulp installed globally, which you can get with npm install -g gulp.
Each time a variable is changed, it should reflect on the page after building the CSS.

Maybe we should also delete all the other theme directories? Not sure.. It might be good to have them around too, for reference/comparison.


Gravity not working for title or content on Android 4.3

Really? It's working for me on Android 4.2.2 (from an emulator), see the "Themed" dialog in the sample project.

https://github.com/afollestad/material-dialogs/releases/tag/<IP_ADDRESS>


clean(lookup): dependencies

Add core and input to dev deps to hoist them via lerna. Otherwise build won't find the dist folders.
Remove aurelia dependencies - they are "peered" through core.
Unify other dev dependencies.

Thanks


Sympy-1.1 update

This merge adds the necessary compatibility changes to make Devito work with the new sympy-1.1 and updates the dependencies everywhere.
Note: This is not backwards compatible with sympy-1.0 and all environments have to be upgraded!

Should Eq be imported from devito instead of sympy too in:
examples/seismic/acoustic/operators.py
examples/seismic/tti/operators.py
devito/pointdata.py
And any other one I may have missed?

@mloubout Good call, I have updated as many as I could find. It technically doesn't matter, as only some degenerate expressions are affected (see comment above), but it's good for consistency.

Oh, perhaps time to replace q_indexed (in dse/queries) with .is_Indexed all over the codebase ?

I think this should be the next one to go

@FabioLuporini Agreed. I just rebased and tried to get rid of most of the q_indexed usages, although we still need it for the search engine. Should be good to go once travis is happy.

Thanks. Let's merge this as soon as Travis is happy

OK, merging...

Merged.


can we use PPO for discrete action spaces ?

No you can't. There are several good algorithms for discrete action spaces. You can find them for example in OpenAI Baselines.

@shamanez Hi, I updated my codes. Please check my repository again!

FromOpenAI Spinning-up Docs:
"PPO can be used for environments with either discrete or continuous action spaces."


[Experimental] Versioning feature added to multi-cloud

What this PR does / why we need it:
This is just an experimental PR used for testing, please don't review or merge
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Hi @nguptaopensds what's the relationship between this PR and PR #853, #855 and #856.

Hi @nguptaopensds what's the relationship between this PR and PR #853, #855 and #856.

These are all versioning PRs and this PR I have created just for testing on different environment, so someone can take this and test on local machine.


ZopfliPNG cannot read filenames with special characters

What steps will reproduce the problem?
1. Run ZopfliPNG with input filename that contains non-English chars.

What is the expected output? What do you see instead?
The image should be read correctly, no matter of what chars are used in its
filename. (The same applies to writing output.)
Decoding error 48 is shown instead.

What version of the product are you using? On what operating system?
Unknown, downloaded from
http://encode.ru/threads/1717-ZopfliPNG?p=33092&viewfull=1#post33092
Windows

Please provide any additional information below.

As an example, the attached screenshot shows:
1) an error with a filename containing all capital letters from the French
alphabet that are not in the English alphabet,
2) comparison with PNGOUT (although incorrect chars are shown when processing,
the input is read and the output is saved with a correct name),
3) correct filenames in the title of the window.

There are 3 levels of failure, depending on chars used:
1) The file is read by both ZopfliPNG and PNGOUT. Example: Filename contains
"u" with umlaut.
2) The file is not read by ZopfliPNG but it is read by PNGOUT. Example: The
case described with the attached screenshot.
3) The file is read neither by ZopfliPNG nor by PNGOUT. Example: Filename
contains all Czech letters (https://en.wikipedia.org/wiki/Czech_alphabet).

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 28 Jul 2014 at 10:37
Attachments:

[test with french characters.png](https://storage.googleapis.com/google-code-attachments/zopfli/issue-41/comment-0/test with french characters.png)

This is still an issue, for example on Linux, files with colons in the name fail:
Optimizing ./Marvel Vs. Capcom: Clash of Super Heroes.png
Decoding error 78: failed to open file for reading


Tests are Inconclusive and non discoverable with latest version of Xbehave and Xunit with dotnet core 2.0

I'm using the following
XUnit 2.3.0
XBehave 2.1.4
dotnet core 2.0
When I tried to run sample XBehave Scenario(exactly the one given in Quickstart) I'm getting error saying Addition is InConclusive with the following stacktrace. xbehave.txt
I have referred to issue #373  and disabled ReSharper and executed tests only with VisualStudio.
Still the tests are not discoverable.
Tried with dotnet-xunit cli runner too,still it says no Tests are found in Test.dll

@Saisuryakattamuri thanks for raising this.
Indeed, xBehave.net 2.1.4 does not support either .NET core or xUnit.net 2.3.0.
xBehave.net 2.3.0 will add support for both .NET core and xUnit.net 2.3.0. I don't have an ETA yet, but coincidentally I started work on this last weekend.
In the meantime, you can try the latest xBehave.net pre-release (2.2.0-beta0003-build685).

@Saisuryakattamuri assuming you've got things working for now, I'm closing this issue. Thanks for raising it. Please keep an eye on the repo for the 2.3.0 release and/or follow our Twitter account for updates. If you have any further questions please re-open this issue or raise a new one.


Make toolbar toggleable

Sometimes, you don't want the toolbar to overlap certain elements, but you don't want to deactivate it either, so it would be nice to have the option to just toggle the toolbar whenever you feel like it.

This is pretty old by now, but still - push.

I have currently no time. Feel free when somebody wants to create an PR 😊


ci: fix status reporting in the ci-multicluster test

This PR applies the same changes introduced in https://github.com/cilium/cilium/pull/23865 to the ci-multicluster workflow, moving the status reporting after all matrix jobs are done. This prevents that the status reported by one job is later overwritten by a subsequent one.
Related: https://github.com/cilium/cilium/issues/23729

ci: fix status reporting in the ci-multicluster test

Link to last successful run: https://github.com/cilium/cilium/actions/runs/4630200074
I've additionally tested this change in my fork with the /ci-multicluster trigger, and it also worked properly

Integration tests failed due to known flake https://github.com/cilium/cilium/issues/24696

Marking as ready to merge, since reviews are in, and it is pointless to run the additional tests (as this PR affects a workflow only).


Support --help and --version arguments

The command line tool does not support --help nor --version.
For this reason I do not even know which version to report this bug against ;)
$ watchify --help
You MUST specify an outfile with -o.
$ watchify --version
You MUST specify an outfile with -o.

npm ls watchify or npm ls watchify -g (if you've got it installed globally) will tell you the version.


v2 readme updates

Correct the link to the v3 repo

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the [development checklist][dev-checklist]
[ ] The code compiles without warnings (code quality chek)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

Codecov Report

Merging #1 (65d3d2b) into dev (ed01856) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev       #1      +/-   ##
==========================================
- Coverage   62.60%   62.57%   -0.04%
==========================================
  Files         179      179
  Lines        6667     6667
  Branches      930      930
==========================================
- Hits         4174     4172       -2
- Misses       2157     2158       +1
- Partials      336      337       +1

Flag
Coverage Δ

unittests
62.57% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rc/Daemon/NetDaemon.Daemon/Daemon/NetDaemonHost.cs
55.15% <0.00%> (-1.17%)
:arrow_down:

...pp/NetDaemon.App/Common/Reactive/NetDaemonRxApp.cs
83.89% <0.00%> (+1.69%)
:arrow_up:

...mon.HassClient/Internal/HomeAssistantConnection.cs
89.01% <0.00%> (+2.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed01856...65d3d2b. Read the comment docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 63.15%

Files with Coverage Reduction
New Missed Lines
%

src/Daemon/NetDaemon.Daemon/Daemon/NetDaemonHost.cs
5
60.26%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4505

Relevant Lines:
6666

💛  - Coveralls


Get the Actions bot out of the PR review business.

I cleaned up the markdown output, here's what an error looks like:

With only warnings it just makes a green check, so the user needs to go find it:

Hm since you get a green ci I guess that most users will never detect the warnings without a comment (You have to know that there could be warnings that you are searching for, but how are new users supposed to know that).


MethodID for 0x79292235

Hello Lido team,
Can you please provide the abi for function 0x79292235?  we would like to decode txIntput for xcm/staking transaction like this: https://polkaholic.io/tx/0x6d3894798e40bc9f7727caa7db9c3f6f2b6996bbdb446d442ffde17a5c64b16f
I've compiled the current master branch and load all the available abi into our database but there's no exact match for 0x79292235. Is there any other branch I should look at?

Hello! Sorry for so long delay( It is reportRelay() function from OracleMaster contract (here is the link https://github.com/mixbytes/lido-dot-ksm/blob/main/contracts/OracleMaster.sol#L255-L275)


Incomplete Downloads from Browsed Tables

BUG DESCRIPTION
Problem

The various "browsing" tables (like Compounds, Animals, and Samples) can be downloaded in either csv, txt, or xls formats.  However, there are two related problems:  1)  downloads only include the rows which are shown in the page and 2) downloads only include 200 rows, even if more rows are displayed in the page.
Steps to reproduce

Browse to https://tracebase.princeton.edu/DataRepo/compounds/
Change number of records shown to "All"
Click the blue download button, and select "text" format
Open the downloaded file, and count the number of rows / check the identity of the last compound.

Current behavior

The final compound included is "citrulline" and this is the 200th compound in the table.
Expected behavior

The final compound should be "xylulose-5-phosphate", and this should be the 689th compound.
Generally, clicking this download button should always download the full table, regardless of the view.
Comment

I discovered this when trying to download the Compounds table, because I wanted to use the list of synonyms outside of tracebase.

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

DESIGN
GUI Change description

None provided
Code Change Description

None provided
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

Looking at this...
It appears to not be just compounds.  I checked Animals too (388 currently).  It also only downloads 200.

Based on this bootstrap-table issue, it appears to be resolved by using server-side pagination.  There is a "working" example in the bootstrap-table documentation.
I put working in quotes, because it depends on implementing a json data "view" in the python code.
I have tried to push implementing server side pagination on our bootstrap table pages for some time.  Either it will have to involve the dataframe data, or it might be easier to implement as a data format, like the advanced search uses, because I'm concerned about the maintainability of the dataframes code.

Having dug into this all yesterday, I have come to the following conclusions.

Server side pagination is how the 200 row download limit is fixed
Server side pagination does not support the following (in the documentation of user-facing interface):

The search boxes at the top of each column
Sorting on each column

Server side pagination requires the implementation of a JsonResponse view in django

Required inputs to the view(s) are offset and limit
We can create the JsonResponse view for every such table, but the way the dataframes code is written, you cannot provide those arguments to the existing code to change the amount of data returned

As suggested in a related bootstrap repo issue, there might exist a way to take advantage of undocumented bootstrap-table source code to write your own custom parameters for the view that can handle sort/search

The caveats are that

The context of that related bootstrap issue wasn't about the column search feature.  It was about a single search box.
Even if we could send the parameters, the dataframes code still doesn't support them
There's no guarantee that an effort to customize bootstrap table would succeed and it would probably take a lot of effort.

The way I see it, there are a few options:

simplest (but other issues persist, such as slowness, and search box quirks): Disable the bootstrap-table download feature and create our own download button that always downloads everything.
simple (but limiting): Disable the sort and search features in the tables and implement server-side pagination that always returns all rows (just to fix the download feature)
half-way (but risky): Same as 2, but try to customize bootstrap table to make server-side pagination support search and sort
full bootstrap solution (but risky and lots of effort): Same as 2, but also refactor the dataframes to be able to take offset and limit as arguments
full Format solution with bootstrap (no risk, but relatively moderate effort): Server-side pagination, download, speed, search, and sort are already solved in DataRepo.formats.dataformat.Format, which is the code that the advanced search uses to present a results table using bootstrap.  The only thing it doesn't do is provide metadata columns such as the "is tracer" and "animals..." columns, but I don't think it would be too hard to add.  I already wrote a quick proof-of-concept compounds format yesterday that is mostly working.  I think it would even be possible to implement a column search significantly similar to the existing pages, which could easily transfer to the same search in the advanced search interface with a single click.  Here's an example:

I'm fine with attempting any of these solutions, but the ones that I think are the least risky are 1, 2, and 5.  Trying to customize bootstrap to make their server-side pagination support the client-side features may never yield a working interface and it would be fragile.

I like option 1 (disabling the current download button and creating some kind of replacement "download everything" button).

OK.  I implemented option 1, but there are a couple differences that I thought I would point out:

The "Is Tracer" column (in the download only) is now titled "Tracers" and shows a count of tracers based on the compound instead of "yes"/"no".  (The page still displays "yes"/"no".)
The "Total Animal By Tracer Parent Compound" column (again, in the download only) is now titled "Animals (with Tracer)"
The file now comes with a header containing download time, and a query string that you can use in the advanced search, which segues into...
I added a Compounds format to the advanced search page.  That way, you could go there and download a subset of data to account for the lost functionality on the compounds page

Here is a sample of the top of the file I just downloaded:
# Download Time: 15/08/2024 11:01:02
# Advanced Search Query: {'selectedtemplate': 'cptemplate', 'searches': {'pgtemplate': {'name': 'PeakGroups', 'tree': {'type': 'group', 'val': 'all', 'static': False, 'queryGroup': [{'type': 'query', 'pos': '', 'static': False, 'fld': '', 'ncmp': '', 'val': '', 'units': ''}]}}, 'pdtemplate': {'name': 'PeakData', 'tree': {'type': 'group', 'val': 'all', 'static': False, 'queryGroup': [{'type': 'query', 'pos': '', 'static': False, 'fld': '', 'ncmp': '', 'val': '', 'units': ''}]}}, 'fctemplate': {'name': 'Fcirc', 'tree': {'type': 'group', 'val': 'all', 'static': False, 'queryGroup': [{'type': 'query', 'pos': '', 'static': False, 'fld': '', 'ncmp': '', 'val': '', 'units': ''}]}}, 'cptemplate': {'name': 'Compounds', 'tree': {'type': 'group', 'val': 'all', 'static': False, 'queryGroup': [{'type': 'query', 'pos': '', 'static': False, 'fld': '', 'ncmp': '', 'val': '', 'units': ''}]}}}}
#
Compound	Formula	HMDB ID	Synonym(s)	Tracers	Animals (with Tracer)
(±)-2-hydroxy-4-(methylthio)butanoic acid	C5H10O3S	HMDB0037115	(±)-2-hydroxy-4-(methylthio)butanoic acid	0	0
(2e,4e)-2,4-hexadienoic acid	C6H8O2	HMDB0029581	(2e,4e)-2,4-hexadienoic acid	0	0
(R)-2-benzylsuccinate	C11H12O4	HMDB0012127	(R)-2-benzylsuccinate	0	0
(R)-lipoic acid	C8H14O2S2	HMDB0001451	(R)-lipoic acid	0	0
1,2,3-propanetricarboxylic acid	C6H8O6	HMDB0031193	1,2,3-propanetricarboxylic acid; propane-1,2,3-tricarboxylic acid	0	0
1,3-dimethyluracil	C6H8N2O2	HMDB0002144	1,3-dimethyluracil	0	0
1,3-dimethyluric acid	C7H8N4O3	HMDB0001857	1,3-dimethyluric acid	0	0
1-aminocyclopropanecarboxylic acid	C4H7NO2	HMDB0036458	1-aminocyclopropanecarboxylic acid	0	0
1-methyladenosine	C11H15N5O4	HMDB0003331	1-methyladenosine	0	0
1-methylhistidine	C7H11N3O2	HMDB0000001	1-methylhistidine	0	0
1-methylnicotinamide	C7H9N2O	HMDB0000699	1-methylnicotinamide	0	0
1-pyrroline-5-carboxylate	C5H7NO2	HMDB0001301	1-pyrroline-5-carboxylate; 1-pyrroline-5-carboxylic acid	0	0
11a-hydroxyprogesterone	C21H30O2	HMDB0000920	11a-hydroxyprogesterone	0	0
1H-indole-3-acetamide	C10H9NO2	HMDB0029739	1h-indole-3-acetamide	0	0
2'-deoxyguanosine 5'-monophosphate	C10H14N5O7P	HMDB0001044	2'-deoxyguanosine 5'-monophosphate	0	0

Note the '.  I'll be fixing that momentarily.

OK, I fixed the url-encoding issue.  I should have a PR for the compounds download shortly, however this will need to be done for every table (at least that currently have more than 200 records/rows).

this looks great!

Other tables whose downloads need fixed:
Currently more than 200 rows:

https://tracebase.princeton.edu/DataRepo/studies/study_summary/
https://tracebase.princeton.edu/DataRepo/animals/
https://tracebase.princeton.edu/DataRepo/samples/
https://tracebase.princeton.edu/DataRepo/archive_files/

Currently might have more than 200 rows, depending on the record:

https://tracebase.princeton.edu/DataRepo/studies/7/
https://tracebase.princeton.edu/DataRepo/animals/243/

Currently fewer than 200 rows (i.e. lower priority):

https://tracebase.princeton.edu/DataRepo/studies/
https://tracebase.princeton.edu/DataRepo/tissues/
https://tracebase.princeton.edu/DataRepo/infusates/
https://tracebase.princeton.edu/DataRepo/infusates/37/ (any infusate)
https://tracebase.princeton.edu/DataRepo/protocols/animal_treatments/
https://tracebase.princeton.edu/DataRepo/lcprotocols/

I'm going to hold off on implementing these until the compounds solution has been reviewed.  In the meantime, I will move on to other issues...

@mneinast - Just submitted an alternate fix for this issue that has a much much smaller code footprint.  There are some strategy gems in the closed PRs that I can repurpose on the advanced search page, but for now, I think the newer fix is the way to go.  There are still various issues with the speed and search boxes in the full bootstrap solution, but this solves the 200 row download limit on all of the pages in 1 PR.  Oh, and also, this means no header and the last 2 columns remain identical to what you see on the page.


listRecommendations API fixes

0.0.8_mvp release has the following issues in the listRecommendations API JSON

recommendation has to be changed to recommendations
duration_based object is missing. The hierarchy should be as follows "recommendations": {
         "2022-12-20T17:55:05.000Z": {
           "duration_based": {
             "short_term": {
               "monitoring_start_time": "2022-12-19T17:55:05.000Z",
               ...
             },
             "medium_term": {
             ...
           }

Remove the element "error_msg". Instead this should be added as part of the "notifications" section that is missing "notifications": [
   {
     "type": "info",
     "message": "There is not enough data available to generate a recommendation."
   }
 ]

PR #592 now fixes this


Better name would have been connect-validator

Hi ctavan,
Thanks for this great effort. I am using restify for my project and after looking at your code I can not see any dependency on express framework.
Just for the semantics of things it would have been great if your repository / module would have been called connect-validator as including it in my restify project would look odd.
Regards
Kapil

I appreciate the feedback, but this module is 4+ years old, so we don't plan on changing the name.


Fix require.Equal calls

Expected should go first. Otherwise, the message
emitted on assertion failure is confusing.

Coverage remained the same at 84.71% when pulling 0e27313c17247976a2034ea2f5d0acffe49b8f8f on akalin/fix-require into 3a15e83714ed591dd785095a0a435bd097bf6603 on master.


Fix formatting

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: skippylapres sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Fix] Handle Error when deleting too many repositories

Notes:
This is untested as I do not know where to add additional auth URLs (Under Setup) and what values to fill in to register a new OAuth application.

Assumptions:
As the GitHub API documentation does not specifically indicate the rate limit for the number of deletions one can do at a time, only a total number of rate limits, I am going with the assumption to group/chunk the repos.
I have also included a popup message to display an error message if the HTTP response is outside the 200 - 299 range. The documentation contains a list of codes that are being used.
Others
Is there a testing library we could use to write tests?
Fixes Issue:
https://github.com/lyqht/Octokit-lite/issues/3

Tested deleting with a few repositories, still works as intended. Thanks for making this fix!


Rollback a published Chrome Web Store item

Chrome released possibility to rollback extensions https://developer.chrome.com/docs/webstore/rollback
Will this tool support testing of rollback?

Hmm, interesting idea! Ultimately a rollback is just re-publishing the previous version but it would be nice to add a button for that perhaps.


add items : several same items displaying

Hello,
I have a list of object (there are 20 objects) but when I add in the adapter with fastAdapter.add(result.getResults()) I got the 5 first items several times (There are 20 objects displaying)
I don't understand why I obtain this result.
I noticed that the ViewHolder is instanced and bindview is call just 5 times...
Thank you in advance for your answer.

do your items have unique identifiers?

Yes, I sure because I have the same image, description. Before I used the base adapter and it worked...
My Set class :
`public class Set extends AbstractItem<Set, Set.ViewHolder> implements Parcelable {
public String theme;
public String year;
public String idSet;
public String name;
public String image;
public String nbParts;
public Set(String name, String year, String idSet, String image, String theme, String nbParts) {
    this.name = name;
    this.year = year;
    this.idSet = idSet;
    this.theme = theme;
    this.image = image;
    this.nbParts = nbParts;
}

protected Set(Parcel in) {
    theme = in.readString();
    year = in.readString();
    idSet = in.readString();
    name = in.readString();
    image = in.readString();
    nbParts = in.readString();
}

public static final Creator<Set> CREATOR = new Creator<Set>() {
    @Override
    public Set createFromParcel(Parcel in) {
        return new Set(in);
    }

    @Override
    public Set[] newArray(int size) {
        return new Set[size];
    }
};

@Override
public int describeContents() {
    return 0;
}

@Override
public void writeToParcel(Parcel dest, int flags) {
    dest.writeString(theme);
    dest.writeString(year);
    dest.writeString(idSet);
    dest.writeString(name);
    dest.writeString(image);
    dest.writeString(nbParts);
}

@Override
public int getType() {
    return R.id.rv_recycler_view;
}

@Override
public int getLayoutRes() {
    return R.layout.list_set;
}

@Override
public void bindView(ViewHolder viewHolder, List<Object> payloads) {
    super.bindView(viewHolder, payloads);

    viewHolder.name.setText(idSet + " : " + name);
    viewHolder.year.setText(year);
    viewHolder.theme.setText(theme);
    viewHolder.nbParts.setText(nbParts);
    Ion.with(viewHolder.image)
            .load(image);
}

@Override
public void unbindView(ViewHolder holder) {
    super.unbindView(holder);
    holder.name.setText(null);
    holder.year.setText(null);
    holder.theme.setText(null);
    holder.nbParts.setText(null);
    holder.image.setImageResource(0);
}

protected static class ViewHolder extends RecyclerView.ViewHolder {
    public ImageView image;
    public TextView year;
    public TextView name;
    public TextView theme;
    public TextView nbParts;

    public ViewHolder(View itemView) {
        super(itemView);

        theme = (TextView) itemView.findViewById(R.id.theme_set);
        year = (TextView) itemView.findViewById(R.id.year_set);
        name = (TextView) itemView.findViewById(R.id.name_set);
        nbParts = (TextView) itemView.findViewById(R.id.nb_parts_set);
        image = (ImageView) itemView.findViewById(R.id.image_set);
    }
}

}`

caling the bindView method is done by the RecyclerView nothing of the lib.
You are sure the elements inside your result.getResult() is correct?

Close for inactivity. Please report back to re-open


16 additional tests passing in Haskell backend

Two more bihu and 12 more mcd tests passing in the Haskell backend. Detailed summary of changes can be found here.

Currently passing tests:
tests/specs/bihu/forwardToHotWallet-success-1-spec.k                   10m 38s
tests/specs/bihu/forwardToHotWallet-success-2-spec.k                   10m 43s
tests/specs/mcd/end-cash-pass-rough-spec.k                             52m 28s
tests/specs/mcd/end-pack-pass-rough-spec.k                             29m 40s
tests/specs/mcd/flapper-yank-pass-rough-spec.k                      3h 07m 22s
tests/specs/mcd/flipper-bids-pass-rough-spec.k                         34m 17s
tests/specs/mcd/flopper-file-pass-rough-spec.k                         59m 16s
tests/specs/mcd/flopper-kick-pass-rough-spec.k                      1h 29m 36s
tests/specs/mcd/flopper-tick-pass-rough-spec.k                      1h 29m 54s
tests/specs/mcd/flopper-dent-guy-same-pass-rough-spec.k             3h 20m 24s
tests/specs/mcd/gemjoin-exit-pass-rough-spec.k                      1h 29m 14s
tests/specs/mcd/pot-join-pass-rough-spec.k                             22m 22s
tests/specs/mcd/vat-fold-pass-rough-spec.k                             50m 34s
tests/specs/mcd/vat-fork-diff-pass-rough-spec.k                     5h 43m 52s
tests/specs/mcd/vat-slip-pass-rough-spec.k                             15m 32s

Just noting that there is some non-mcd failing test in the CI.


Display HeroCard using luis action binding

how to create a HeroCard in the "fulfill()" of  luis action binding? any examples..?

Hi @HelloJyo ,
Take a look at the FullfillReplyHandler @ https://github.com/Microsoft/BotBuilder-Samples/blob/master/Node/blog-LUISActionBinding/samples/bot/app.js#L38
See how to configure LAB with the option @ https://github.com/Microsoft/BotBuilder-Samples/blob/master/Node/blog-LUISActionBinding/samples/bot/app.js#L28
More information here:

README (search for fulfillReply)
Commit Details: https://github.com/Microsoft/BotBuilder-Samples/pull/130

Regards,
-PabloC.

How can I make the intent specific logic (content on the "card") coded as:
`fulfill: function (parameters, callback) {
utilities.FilterFunction(parameters.x, parameters.y).then(function (matches){
   utilities.CreateCard(session, matches).then(function(cards){

        var reply = new builder.Message(session)
            .attachmentLayout(builder.AttachmentLayout.carousel)
            .attachments(cards);

        callback(util.format(reply));
    });

});

}
`
How can I use session value in the fulfill method?...without session "utilities.CreateCard" won't work...

If there are multiple intents (say 10) the app.js file needs to handle more logic which makes it complex.
What I want is return the result object (i.e, "matches" ) from
utilities.FilterFunction(parameters.x, parameters.y).then(function (matches)
to the FulfillReplyHandler and create the HeroCard there. An example would be helpful if possible.
regards,
HelloJyo

Hi @HelloJyo
You should NOT create the card in the action's fulfill method. In it you should only invoke your action and pass back a result using the callback handler.
You should create the HeroCard from the optional fulfillReplyHandler when calling the bindToBotDialog method. See here for an example: https://github.com/Microsoft/BotBuilder-Samples/blob/master/Node/blog-LUISActionBinding/samples/bot/app.js#L28
In there you'll have access to the session object and the actionModel with the result.
You can then check the actionModel.intentName  to verify which LUIS intent was triggered and create the card as you wish.
Regards,
-PabloC.

Okay, I got it now...
Thanks and regards,
-Jyo


Contribute tVM to b9org/tVM

Signed-off-by: Nazim Uddin Bhuiyan<EMAIL_ADDRESS>

@xliang6 @Leonardo2718 @a7ehuo tVM is ready to go out in the open!


[FEAT] Remove the automatic loading of notes review queue pane

Is your feature request related to a problem? Please describe.
I don't use it so I don't want it cluttering my sidebar. Unfortunately, it keeps reopening after restart.

+1 to this issue.


Make throw/assertion stack traces useful

TODO:

[x] tests – who tests the tester
[x] confirm with @trentmwillis this is public or can be made public in QUnit.

before:

after:

This is a great step in the right direction. 👍

test failures look unrelated to this... But i'll investigate in the AM

Not sure what needs to be confirmed RE: QUnit. assert.pushResult is definitely public...

Also, LGTM.

@rwjblue this PR also fixes CI/tests

@rwjblue / @trentmwillis either of you guys got time to release. I think this can be a minor version.

getting trolled by something strange, where some bower deps have an invalid ember.debug.js..... @rwjblue any ideas?  I opened a dedicated tracking issue -> https://github.com/emberjs/ember.js/issues/15533


Analytics error on Android

I managed to get the firebase analytics working for iOS. Great stuff! However on Android, when I call the following
import Firestack from 'react-native-firestack'
componentWillMount() {
var firestack = new Firestack();
firestack.analytics.logEventWithName("view_screen", {
'screen': 'Now Showing'
})
.then(res => console.log('Sent event named view_screen'))
.catch(err => console.error('Firebase Analytics Error: ' + err));
}
I'm getting the following error. Anyone else experienced this?
undefined is not an object (evaluating 'NativeModule[fn]')

Did you run react-native link react-native-firestack ?


TypeError: Cannot read property 'replace' of undefined

Hello,
I first had this issue but could solve it with the solution from @TheCodeDestroyer. But now I'm getting the error:
TypeError: Cannot read property 'replace' of undefined
I first thought it had something to do with the angular version but even replacing it with a newer one  didn't solve it. Can someone help?

Okay found the issue. You have to setup a local server to view the docs. The filesystem doesn't work.

Do you still have an issue? Otherwise, just close the task :)

No, no issue anymore :)


Update readme.md

Adding a few things and fixed a typo

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   89.84%   89.84%
=======================================
  Files          10       10
  Lines         975      975
=======================================
  Hits          876      876
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa44d3...6904322. Read the comment docs.


Twitter: publish include location

for https://github.com/snarfed/bridgy/issues/317
confirmed working here https://twitter.com/kylewmahan/status/684920569641349120

so clean, so simple! love it. lgtm!


Filter out MEV Swaps that cause noisy Wicks in Candles

Sandwich attacks are causing candle wicks in GCGO-Candle to appear out of scale:

Orignal GC python server has logic for filtering these out.

NOTE: this is a lower prio than #2

high-prio blocks deployment


65 feature implementation of simple first state machine

Description
A draft for the first state machine part
Fixes #65
Time invested
Josef Kircher: 5h
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Does this PR introduce a breaking change?
e.g. is old functionality not usable anymore
Most important changes
Which files functionalities are most important in this PR. On which part should the reviewer be focussed on?
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[ ] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

After abandoning the idea of using SMACH for the state machine this PR will be closed


add setindex

Codecov Report
Patch coverage: 90.32% and project coverage change: +0.23 :tada:

Comparison is base (9cd960b) 78.98% compared to head (fbe77c7) 79.22%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   78.98%   79.22%   +0.23%
==========================================
  Files          42       43       +1
  Lines        4368     4394      +26
==========================================
+ Hits         3450     3481      +31
+ Misses        918      913       -5

Impacted Files
Coverage Δ

src/Finch.jl
83.33% <ø> (ø)

src/asarray.jl
70.00% <70.00%> (ø)

src/execute.jl
88.27% <100.00%> (-0.24%)
:arrow_down:

src/fibers_meta.jl
79.71% <100.00%> (+3.04%)
:arrow_up:

... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


output arrays are changed in place

Some arrays, such as the kappa maps in glass.lensing.convergence, are outputs that are later modified in place. This is potentially an issue if users make a shallow copy of the results.
It needs investigation whether the efficiency gained by modifying the outputs in place is enough to warrant this becoming a common issue.

How do you avoid this issue?
to_save.append(shell['kappa'].copy()) ?


fix for deposit issue

Adjusts DEPOSIT_GAS_PER_PUBDATA_LIMIT to correct value for deposits and calculates base_cost to use for l1_value parameter.
#10

This is not enough to fix 'mv' error when withdrawing something little like 0.001 ETH. check_base_cost passes in SDK but not in the smart contract.

@kpp I hadn't attempted a withdrawal in my testing, I'll take a look when I get to withdrawals in my use case later this week if it's not fixed by then.


Bugfixes

#Sorry for this PR. I've made some mistakes in previous PRs.
Fix 1:
We should see if the candidate got a condition when we fetch it from the cache.
Fix 2:
Improved the doc blocs
Fix 3:
We should not require an object of type DiscoveryStrategy on appendStratey and prependStrategy. We should require a string FQCN.

LGTM!

Thank you for merging.


Backpage Seized

Backpage.com appears to have been seized as part of an enforcement action by various U.S. government agencies on April 6, 2018.
Although the seizure notice discloses to email<EMAIL_ADDRESS>for backpage record certification requests, you may replace this site with an alternative or remove it.

Removed, thanks.


Add support for the project section (PEP 621)

Closes #567
should not be squashed
Hints:

Do not rebase without updating the downstream branch python-poetry/poetry#9135
Downstream tests were disabled because this will be breaking for downstream

Notable changes compared to #567 or "why I did not just rebase it":

Instead of two complete schemas (one legacy and one PEP 621), I decided to introduce two partial schemas (one for tool.poetry and one for project). Reasoning:

By introducing the non-package mode, having one legacy schema and one PEP 621 schema as in #567 does not work well anymore. In non-package mode all project fields are optional.
Further, I had difficulties distinguishing the definitions of the project section and the tool.poetry section in the PEP 621 compatible schema.
Using a complete schema makes it easier to define relations between the project section and the tool.poetry section. However, this would require heavy use of anyOf (because of the non-package mode) and this results in hard-to-understand error messages, see https://github.com/python-poetry/poetry-core/blob/7d40189393b441b975f7490845204a5598813730/src/poetry/core/factory.py#L390-L404 Thus, it makes more sense not to use anyOf and validate the relation between both sections in the validate() method anyway.

See https://github.com/python-poetry/poetry-core/pull/567#issuecomment-1962301897

Do not introduce [tool.poetry.dependency-options] but keep [tool.poetry.dependencies], just make version optional and implement the distinction/merging of abstract dependencies ([project.dependencies]) and concrete dependencies ([tool.poetry.dependencies]).
Do not change anything related to [tool.poetry.group]. That especially makes sense since there might be a standard way for dependency groups in the future (see PEP 735) so we can have the same distinction between abstract and concrete dependencies.

Deprecate fields in tool.poetry that can be completely replaced by fields in the project section, see Factory.validate().

another way to do this would be not-chaning poetry's internal layout of configuration at all, and just mapping the project section's features into poetry's features, right?

@radoering @charliermarsh  What's the status of this PR?

What's the status of this PR?

It is ready for review.


Misc markdown improvements

@Youssef1313 , thanks for the fix!
To may checker happy, please revise your commit message with a body message like;
Misc markdown improvements

This will improve markdown in Tutorial document.

ONE-vscode-DCO-1.0-Signed-off-by: (your name) (your e-mail)

You can refer other commits with git log