Auto-resizing or initial zooming/scaling of models doesn't work (for me)

Hi!
First off, thanks for the viewer. It's such a breeze to use! Even for a newbie like myself.
I have run into a small issue when using it on my website, though: In my opinion the auto_resize doesn't work well (for my models anyway) as it leaves a lot of space around the model.
And when I tried using zoom or per-model scale to compensate, then the result was also not what I would expect.
Here's a test page to illustrate (at the bottom of it):
https://wejn.org/2000/01/test-page/
(plus here is a snapshot with the <div>s emphasised by a border... in case the page misbehaves for you)
What I would expect with the default setup is that the model would more or less fill out the entire canvas. And it doesn't.
But that wouldn't be a big deal if I could find a zoom or per-model scale parameter that would allow me to position/zoom the model properly. Which turned out to be a bit of a challenge so far.
So I'm thinking -- am I holding it wrong? Or is there indeed a bug?
Btw, for the interest of readability (because in the page source the json is serialized, thus hard to read), here's the code I'm using to initialize the individual viewers in my Jekyll site:
---

A bit of space for the viewstl:

Default:
{% complexstl 16:9 %}
{
  "models": [ {
      "filename": "{{ "/assets/2020-12-13-curtain-holder/model-older.stl" | relative_url }}",
      "rotationx": -0.8, "rotationy": 0.0, "rotationz": 0.0, "color": "#bbbbbb"
    }
  ]
}
{% endcomplexstl %}

`auto_resize: false, zoom: 1.1`:
{% complexstl 16:9 %}
{
  "auto_resize": false,
  "zoom": 1.1,
  "models": [ {
      "filename": "{{ "/assets/2020-12-13-curtain-holder/model-older.stl" | relative_url }}",
      "rotationx": -0.8, "rotationy": 0.0, "rotationz": 0.0, "color": "#bbbbbb"
    }
  ]
}
{% endcomplexstl %}

`auto_resize: false, zoom: 0.1`:
{% complexstl 16:9 %}
{
  "auto_resize": false,
  "zoom": 0.1,
  "models": [ {
      "filename": "{{ "/assets/2020-12-13-curtain-holder/model-older.stl" | relative_url }}",
      "rotationx": -0.8, "rotationy": 0.0, "rotationz": 0.0, "color": "#bbbbbb"
    }
  ]
}
{% endcomplexstl %}

`auto_resize: false, model's scale: 1`:
{% complexstl 16:9 %}
{
  "auto_resize": false,
  "models": [ {
      "filename": "{{ "/assets/2020-12-13-curtain-holder/model-older.stl" | relative_url }}",
      "rotationx": -0.8, "rotationy": 0.0, "rotationz": 0.0, "color": "#bbbbbb",
      "scale": 1.0
    }
  ]
}
{% endcomplexstl %}

`auto_resize: false, model's scale: 1.3`:
{% complexstl 16:9 %}
{
  "auto_resize": false,
  "models": [ {
      "filename": "{{ "/assets/2020-12-13-curtain-holder/model-older.stl" | relative_url }}",
      "rotationx": -0.8, "rotationy": 0.0, "rotationz": 0.0, "color": "#bbbbbb",
      "scale": 1.3
    }
  ]
}
{% endcomplexstl %}

Think of everything in between the {% complexstl 16:9 %} and {% endcomplexstl %} as the optional init parameters that get passed to the StlViewer constructor (using a simple scaffold).
Btw, the model is: https://wejn.org/assets/2020-12-13-curtain-holder/model-older.stl but there's plenty of other examples in the last few posts on my site (if interested or in need of a few more models).

Thanks wejn ,
I know the auto_zoom is far from perfect.
Also, the zoom functionality is opposite from logic - the more zoom you set, the farer the model.
Try to set the zoom value to 100 and see.
(here is my little test here: https://www.viewstl.com/plugin/try8.html)
(I guess I should not call it zoom ...)
As to the scale - as long as you don't set the zoom value, it will try to set auto_zoom anyway (even if auto_zoom is false), so the scale won't do nothing here (unless you have another model in scene already).
Please let me know if that solve the issue.

Hi, yes, this works somewhat. It's not the best solution for responsive designs (the sizing is different based on device width) but it provides better results.
Btw, I think that the problem is non-trivial given the possibility of arbitrary rotation of the model(s) and non-constant aspect ratio.
From what I was able to find, there aren't readily re-usable examples using three.js that would solve this general case in a satisfactory fashion.

For the record, I think I have solved the auto_resize problem for my simplified stlviewer: https://wejn.org/2020/12/cracking-the-threejs-object-fitting-nut/
But I don't know how to backport it to viewstl. So I'm leaving it here, in case you want to take it as inspiration.

Well done wejn - I'll try to apply your idea on the stlviewer, and will do some tests.
the addition of z/2 of the model may do the trick ...

Applied your code to the new version (1.12) - thank you very much!!


Add ability to pass Channel

Add the ability to pass the Channel to use from Jenkins into Octopus Deploy

Done. Released with version 1.6.0 at 2017-02-27T11:20:27-05:00


In NLog, if use log.Info() with many parameters, can these parameters will be stored as properties in appInsights?

I have installed Nlog and Microsoft.ApplicationInsights.NLogTarget with latest nuget package version.
If I use this method log.Info() in NLog, with many parameters, like below:
log.Info("a test", "param1", "param2", "param3", "param4");
then how can I send these paramters like "param1" / "param2" as custom properties in azure application insights(it means that in azure portal-> application insights-> this message "a test" should have these custom proerties)?

As per this code, AI takes a look at the properties of the logged event (LogEventInfo.Properties) and then adds them to the custom dimensions.
Are those "param1", "param2", … making it into the property bad on NLog end or there is another API to get them there?


x/tools/gopls: log error frames when logging an error

Now that we are using x/errors in gopls, we can also log error frames when logging errors.
@jan-xyz is interested in adding this behavior.

According to the blog post https://blog.golang.org/experiment the design draft for printing frames is abandoned and they are on a look out for a better solution. I am not sure if the current implementation will stay. Do you have any more insights on this @stamblerre ?

Ah, I missed Russ's talk at GopherCon. I think I'm fine with using the features supported by x/errors as long as they are around, just to try them out.
I think we could make these changes quite simple and easy to revert because @ianthehat's telemetry work introduced a new way of logging errors. Supporting this behavior might be as simple as adding the %+v in a single place. Take a look at https://godoc.org/golang.org/x/tools/internal/lsp/telemetry/log and let me know what you think.

Just printing errors as %+v probably doesn't hurt in general. I suppose it's enough to change the format here:
https://github.com/golang/tools/blob/128824a23e7c038a341252700f1001ad29ef1988/internal/lsp/telemetry/log/entry.go#L46

Something like messing with the name of the package, adding an import that doesn't exist, completing something that's not declared - these would all likely cause errors to be logged.


Implement physics in some way

One current idea is to make it so that all of the objects fall of the screen when the player loses. Also, this can happen as the camera shakes over multiple shakes. This fulfills the requirement of shake position being used by using it for the camera.

This has been implemented as one shake. If someone wants to, they can modify it to be multiple shakes.


Replace curl with wget to download kops

Curl is weirdly failing at the time to download kops, let's use wget instead to see if that solves the problem.

This is one-liner to replace curl with wget, I will self-merge without review to, hopefully, unblock the failing aws builds on master.


[Fix-14790][dolphinscheduler-ui] Fix the data quality task, keyword filtering not supported

Purpose of the pull request
Fix https://github.com/apache/dolphinscheduler/issues/14790
Brief change log
I have fix this problem.
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14792 (bae7a99) into dev (70731a1) will increase coverage by 0.00%.
Report is 1 commits behind head on dev.
The diff coverage is n/a.

:exclamation: Current head bae7a99 differs from pull request most recent head 4a6e2ae. Consider uploading reports for the commit 4a6e2ae to get more accurate results

@@            Coverage Diff            @@
##                dev   #14792   +/-   ##
=========================================
  Coverage     38.85%   38.86%
+ Complexity     4685     4681    -4
=========================================
  Files          1289     1289
  Lines         44315    44269   -46
  Branches       4880     4852   -28
=========================================
- Hits          17219    17203   -16
+ Misses        25196    25165   -31
- Partials       1900     1901    +1

see 35 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update formatting by re-running latest stable rustfmt

I noticed #213 recently failed because of formatting, and thought this would be good to do in a separate PR.

Superseded by #217

cc 1.0.28 reverts the requirement for rustc >= 1.30, so pinning the version is no longer required.


Schema overriding

Some JDBC drivers may return null value for non-null column :< Query parameter null_as_default may help in some cases but not all as it changed value. On the other hand, adding null-check rs.getObject(1) == null in JDBC bridge may have side effect, especially when dealing with large columns(e.g. BLOB or CLOB etc.). We can introduce schema overriding as a workaround, for example:
-- when there's * in the inline-schema, we'll need to execute the query(fetch_size=1 and max_rows=1) for type inferring,
-- and then use custom column definitions to override
select *
from jdbc(
    'ds1',
    '*, non_null_column Nullable(String), non_exist_column_will_be_discarded String',
    'select * from some_table'
)

This will also help for implicit type conversion without changing inner query.
-- assume below query will return two columns: key UInt8, value Int32
select * from jdbc('ds1', 'select * from some_table')
-- key UInt8, value String
select * from jdbc('ds1', 'value String, *', 'select * from some_table')
-- key String, value String
select * from jdbc('ds1', '* Int64, key String, value Int32, value String', 'select * from some_table')

I noticed this sort of behavior with UUIDs and timestamps too: https://github.com/ClickHouse/ClickHouse/issues/56812
For instance,
describe table (
    select ts
    from jdbc('postgres', 'select now() as ts')
);

returns a Nullable(DateTime64(6)) instead of a DateTime64(6).
Even if you pass ts through a function that the docs say returns a DateTime64, you still get a Nullable type:
describe table (
    select toDateTime64(ts, 6) as ts
    from jdbc('postgres', 'select now() as ts')
);

returns a Nullable(DateTime64(6)) too.


Adding history items

Hello. I found your extension and at first glance it seemed to be exactly what I need.
But I have a trouble when I need to add truly historical rows (that have been active decades ago). How I can set sys_period to be timestamp in the past?
Here is the proble:
nsi=# INSERT INTO subscriptions (id, sys_period) VALUES (100, tstzrange('1900-01-01', 'infinity'));
INSERT 0 1
nsi=# select * from subscriptions where id = 100;
 id  |             sys_period
-----+------------------------------------
 100 | ["2016-04-11 15:27:10.533796+03",)
nsi=# update subscriptions set sys_period = tstzrange('1940-01-01', 'infinity') where id = 100;
UPDATE 1
nsi=# select * from subscriptions where id = 100;
 id  |             sys_period
-----+------------------------------------
 100 | ["2016-04-11 15:28:33.569874+03",)
(1 row)

This is my schema:
CREATE TABLE subscriptions
(
  id SERIAL PRIMARY KEY
);
ALTER TABLE subscriptions  ADD COLUMN sys_period tstzrange NOT NULL;
CREATE TABLE subscriptions_history (LIKE subscriptions);
CREATE TRIGGER versioning_trigger
BEFORE INSERT OR UPDATE OR DELETE ON subscriptions
FOR EACH ROW EXECUTE PROCEDURE versioning(
  'sys_period', 'subscriptions_history', true
);

Hello @suricactus,
What you are trying to achieve is called application-time period tables and is not currently supported by the extension. In fact, you do not even need an extension to implement them since the application-time period is controlled by the application, not by the system (that is why the other type of temporal tables is called system-time period tables).
I have been thinking about implementing application-time period tables, but I am not sure if I will find enough time to tackle it. The most painful part is versioned FKs and PKs.

Thank you! Sorry I misunderstood the purpose of your extension. I just thought I might be reinventing the wheel.
Hope you have enough time to implement another plugin for application-time period tables one day.
Best wishes!

Sorry, I might be totally misunderstanding but I wondered ... it seems in this case these old historical rows have no history yet, then you might really be simply wanting the sys_period start timestamp to match some prior timestamp?
It seems to me that if you don't have the trigger active you can update that start timestamp.  So you could only create the trigger after the start timestamps are what you want.
Sorry, I just thought I'd add that in case you really are looking for that option.


Preview does not match export

Describe the bug
Extra new line on exported image not present in preview
To Reproduce
Steps to reproduce the behavior:

Look at preview

Preview:

Actual exported image:

Expected behavior
Preview to match exported image
Info (please complete the following information):

OS MacOS
Browser Chrome 119

Minimal reproduction: https://carbon.now.sh/?bg=rgba(171%2C+184%2C+195%2C+1)&t=seti&wt=none&l=text%2Fx-java&width=750&ds=true&dsyoff=20px&dsblur=68px&wc=true&wa=true&pv=18px&ph=14px&ln=false&fl=1&fm=Hack&fs=14px&lh=133%25&si=false&es=2x&wm=false&code=new%2520Rental()%253B
Env: Chrome on OSX, Version 120.0.6099.216 (Official Build) (arm64)
Not reproducible in Safari.

Meanwhile this bug is fixed ;)


Storage rewrite

The storage package was needlessly complex, large and led to frequent misunderstandings from developers who expected it to work like a store. I have learned from my mistakes and deprecated the old APIs with the exception of the cookieStorage. I also added a new smaller makePersisted(signalOrStore) primitive that should fulfil the general requirements and improved the cookieStorage.

What if I have a custom state API that requires special reconciliation, or I'm using a store and want to reconcile manually with produce? What if my state API does not provide a tuple?

Then you're welcome to write an adapter that projects your custom state API to something resembling either a signal or a store.
I want the simplest possible API for the default use cases, though I'm happy with splitting this like you suggested, as long as the main API remains the same. I'd prefer to get this out in any case. So I'd prefer to have this merged now and take some time to split this up afterwards.

What if I want to use it with createResource?

Then you should use createResource(fetcher, { storage: makePersistent(createSignal()) }); anything else might make things unneccessary complex. But you're right, I should document that.

I'd prefer to get this out in any case. So I'd prefer to have this merged now and take some time to split this up afterwards.

yup go ahead, just wanted to get my thoughts out. The new API is definitely an improvement.

I should document that.

💯😊


Allow using cmd as DSL for ctrl or command key.

Users of macOS expect to press Command+Key whereas Windows, Linux, etc.
expect to press Ctrl+Key. This allows easily defining that behavior.
Fixes #38.

This is excellent work. Thank you, @blimmer!

No problem, thank you for this excellent library!


/usr/bin/tar -xf /home/runner/work/_temp/61d82b15-a59d-4f77-952b-ce66fa49e178/cache.tzst -P -C /home/runner/work/setup-java/setup-java --use-compress-program unzstd

https://github.com/actions/setup-java/actions/runs/10001779425/job/27646015003

Hello @Chuysalgafo,
Since this appears to be spam, I am going to close the issue.


Implemented cluster checks to warn for tables that need to be re-indexed

or upgraded to be able to be used with future versions of CrateDB.

@nslater Please also take a look at changelog and documentation changes

Codecov Report

Merging #5006 into master will increase coverage by 0.04%.
The diff coverage is 85.55%.

@@             Coverage Diff              @@
##             master    #5006      +/-   ##
============================================
+ Coverage     82.02%   82.06%   +0.04%
- Complexity    10662    10691      +29
============================================
  Files          1294     1297       +3
  Lines         44609    44699      +90
  Branches       5669     5679      +10
============================================
+ Hits          36590    36684      +94
- Misses         5351     5355       +4
+ Partials       2668     2660       -8

Impacted Files
Coverage Δ
Complexity Δ

...peration/reference/sys/check/AbstractSysCheck.java
90.9% <ø> (ø)
4 <0> (ø)
:x:

...n/java/io/crate/metadata/doc/DocIndexMetaData.java
92.53% <100%> (+0.02%)
119 <1> (+1)
:white_check_mark:

.../main/java/io/crate/metadata/doc/DocTableInfo.java
82.84% <100%> (+18.16%)
53 <1> (+4)
:white_check_mark:

...ys/check/cluster/TablesNeedReindexingSysCheck.java
100% <100%> (ø)
3 <3> (?)

...operation/reference/sys/check/SysChecksModule.java
100% <100%> (ø)
2 <0> (ø)
:x:

...ava/io/crate/metadata/doc/DocTableInfoBuilder.java
84.61% <100%> (+0.17%)
14 <0> (ø)
:x:

...e/sys/check/cluster/TablesNeedUpgradeSysCheck.java
81.39% <81.39%> (ø)
4 <4> (?)

...ference/sys/check/cluster/LuceneVersionChecks.java
83.33% <83.33%> (ø)
15 <15> (?)

.../main/java/io/crate/planner/PositionalOrderBy.java
41.02% <0%> (-41.03%)
9% <0%> (-4%)

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5826e43...6eafa76. Read the comment docs.

retest this please

Implemented in this PR: https://github.com/crate/crate/pull/5026


dev-cmd/bottle: fixup macOS symlink permissions.

These can be changed on macOS but not on Linux so we need to make them consistent in both places for all: bottles to have consistent checksums.
I investigated adding to cleaner.rb to fix these symlink permissions on installation but it seems it already happens by default when extracting so there's no need.

Review period skipped due to critical label.


Feature request: conversion.waitFor

Thanks for both the tool and answering earlier issues today!
I have a webpage that downloads a set of files and then runs a script to translate the content to the right language. This works great, unless the PDF is generated before the content has been translated.
conversion.printDelay is useful, but isn't reliable enough.
Instead, I want to run a custom JS test to check whether or not the page has actually been loaded. If it hasn't, then I'd wait 100ms and try again. This polling technique is common with Selenium-based testing frameworks (e.g. Protractor).
I'm going to be looking into this tomorrow, so any guidance on how to implement this with (or as an extension/pull-request for) phantom-html-to-pdf would be very welcome :)

Yes, this feature is missing. We are having plans to implement it in the short time frame, however we didn't discuss the implementation details yet.
Feel free to fork and try to add some evaluations you need before printing.
https://github.com/pofider/phantom-html-to-pdf/blob/master/lib/scripts/conversionScriptPart.js#L79

I have working support for this when just running a single phantom server: https://github.com/pofider/phantom-html-to-pdf/pull/14
I've not updated conversionScriptPart.js (when is this used?) or standaloneScript.js (currently unclear on best way to return an error). It feels like the 3 files should be refactored and DRYed up...
Any tips for how to return an error in standaloneScript.js ?

conversionScriptPart.js (and serverScriptPart.js, standaloneScriptPart.js) are used in prepareScripts.js which is executed in npm postinstall hook.
don't need to return an error in standaloneScriptPart.js (well, if you really need that just throw new Error()) because this file will be running inside a child process, if it has an error it will reported in the callback of childProcess.execFile

@PaddyMann the feature is complete :smile:

Had a quick play and it works great - thank you kindly sir :)


How to execute command from CallbackqueryCommand, but from user, not from bot

Hello! Thanks in advance for your help.
I'm creating something like "notebook", so I made a function "/addnote", where user first prints the title, then adds some notes. And this note saves to database. I used "survey" command like a template, so thank you for this example, it was very useful.
Here is some code of AddnoteCommand:
$message = $this->getMessage();
$chat = $message->getChat();
$chat_id = $chat->getId();
$user = $message->getFrom();
$user_id = $user->getId();
$text = trim($message->getText(true));

...

switch($state)
{
    case 0:
        if ($text === '') {
            $notes['state'] = 0;
            $this->conversation->update();
            $data['text']         = 'Please print the title:';
            $data['reply_markup'] = Keyboard::remove(['selective' => true]);
            $result = Request::sendMessage($data);
            break;
        }
        $notes['note_title'] = $text;
        $text           = '';

    case 1:
        if ($text === '') {
            $notes['state'] = 1;
            $this->conversation->update();
            $data['text'] = 'Add some notes:';
            $result = Request::sendMessage($data);
            break;
        }
        $notes['note_text'] = $text;
        $text                   = '';

    case 2:
        $this->conversation->update();

        // here some code for saving note to database
        $data['text'] = "✅ Written!";

        $data['reply_markup'] = Keyboard::remove(['selective' => true]);
        $this->conversation->stop();
        $result = Request::sendMessage($data);
        break;
}

Here how it looks:

As you can see, I used "survey" as a template. I just changed "steps" and wrote some code for saving to database.
So, user should print "/addnote" to create a note. But my idea was to create for user a "button" that he can press instead of printing "/addnote". Something like a button "Add a note", and when user press it, in chat appears message "/addnote" and starts this command. Or starts the command without printing "/addnote".
I know about two ways to do it: by using Keyboard or InlineKeyboard.
Keyboard looks good, but unfortunately, as I understood, I can't make a button with caption on it like "Add a note", but on pressing print in chat something like "/addnote" or starting command. If it's "Add a note" on button, by pressing it in chat appears "Add a note".
So I need use a button with caption "/addnote" or use GenericCommand to handle "Add a note" text. I refused these solutions and tried to find something else.
And I found InlineKeyboard allows to make a button with callback. So in StartCommand I wrote this:
$inline_keyboard = new InlineKeyboard([
  ['text' => 'Add a note', 'callback_data' => 'addnote']
]);

$data = [
  'chat_id' => $chat_id,
  'text' => 'Available functions:',
  'reply_markup' => $inline_keyboard
];

How it looks:

Then in CallbackqueryCommand I wrote this code to catch my 'addnote' data:
$callback_data = $callback_query->getData();

if( $callback_data == 'addnote' )
{
  $this->getTelegram()->executeCommand('addnote');
}

But when I pressed button "Add a note", I got PHP error:

PHP Fatal error:  Call to a member function getChat() on null in …/UserCommands/AddnoteCommand.php on line 61

Line 61 is:
$chat    = $message->getChat();

I read lot of issues with same question - how to execute command from callback. And got this solution here: #532 - change one line in AddnoteCommand:
$message = $this->getMessage() ?: $this->getCallbackQuery()->getMessage();

I did it but get another problem: when I press "Add a note", bot shows me a message from step 2 - "Add some notes". There was no step 1 - "Print the title":

I checked content of $message:
{"message_id":696,"from":{"id":508719247,"is_bot":true,"first_name":"My bot","username":"mybot"},"chat":{"id":323411265,"first_name":"Name","username":"myusername","type":"private"},"date":1521750659,"text":"Available functions:"}

So I understand, scripts wrote text "Available functions:" as "title". So I add this code to AddnoteCommand:
$is_bot  = $user->getIsBot();
$text = ($is_bot ? '' : trim($message->getText(true)));

It means: if command executed not by user, but by bot, text message cleared.
And at first sight it works good: after I pressing "Add a note" comes first question "Please print the title". But when I'm printing something and press "Enter", nothing happens.

I tried to understand, where is the problem. And found this:

When I try to add note by printing "/addnote" in chat, script creates conversation in database (ID 51 on screenshot), where user_id is mine.
But when I try to add note by printing "/start" and pressing "Add a note", which use callback, script also creates conversation in database (ID 52 on screenshot), but user_id belongs to the bot! And when I print some title, conversation doesn't update! I mean, field notes doesn't change.

Just look what $message (actually $this->getMessage()) contains if I print "/addnote" in chat:
{"message_id":706,"from":{"id":323411265,"is_bot":false,"first_name":"Name","username":"myusername","language_code":"en"},"chat":{"id":323411265,"first_name":"Name","username":"myusername","type":"private"},"date":1521751232,"text":"\/addnote","entities":[{"offset":0,"length":8,"type":"bot_command"}]}

And what $message (actually $this->getCallbackQuery()->getMessage()) contains when command 'addnote' executed from callback:
{"message_id":713,"from":{"id":508719247,"is_bot":true,"first_name":"My bot","username":"mybot"},"chat":{"id":323411265,"first_name":"Name","username":"myusename","type":"private"},"date":1521751365,"text":"Available functions:"}

That's why in this situation, user_id field in table conversations belongs to bot, not user. It looks like when "Please add some notes" appears on screen and I print some text, it handles like an another conversation.
So…
I can't find solution for this.
All I want - use Keyboard / InlineKeyboard for executing 'addnote' command, so any user can add note just by pressing a button, not by printing "/addnote" in chat.
Please, help me find any solution. And, I hope, my mini-research will be useful for somebody in same situation.
Thanks for you time!

Hi @f4strg
Wow, great write-up and research you put into this :tada:
What you have found is a common issue. A simple solution for this, is to just use the user_id as the chat and user ID when creating the new conversation:
$this->conversation = new Conversation($user_id, $user_id, $this->getName());

Give that a try and see if it does it for you.

Thank you, @noplanman ! Great and easy solution. It works!
Thank you very much for fast answer and, of course, for this bot!


Set cell backgrounds by createStyle not working

Describe the bug
Set cell backgrounds by createStyle not working
To Reproduce
Run next code
`var style = workbook.createStyle({
font: {
color: '#FF0800',
size: 12
},
numberFormat: '$#,##0.00; ($#,##0.00); -'
});
var style2 = workbook.createStyle({
fill: {
type: 'pattern',
pattern: 'solid',
fgColor: '#f20202',  // Foreground color
bgColor: '#f20202', // Background color
},
font: {
color: '#10c8c8',
size: 10,
}
});
worksheet2.cell(1,1).string("#").style(style2);
worksheet2.cell(1,2).string("Full Legal Name").style(style);
worksheet2.cell(1,3).string("Job Title").style(style2);
worksheet2.cell(1,4).string("Market").style(style2);
worksheet2.cell(1,5).string("Location Type").style(style2);
worksheet2.cell(1,6).string("Termination Date").style(style2);
workbook.write('Excel.xlsx');`
This will not apply red colors to the cell at style2, it keeps it white.
Expected behavior
Color should be applied to cell
Environment (please complete the following information):

OS: macOS Sonoma 14.1.1
Node Version: v20.9.0
excel4node Version: 1.8.2
Application: Office 365
Application Version (if applicable): Excel 16.79.23111614

Additional context
There are no environment errors

I had a similar problem, but my cells used to stay black. I was looking for a reason and found this issue. Then i realized i missed to add fgColor to my style. I also see the problem in your case. It yould be patternType: 'solid' not just pattern. You might have solved this old issue i just wanted to note for any other that might stumble over it!


Document sidebar classes

.sidebar-nav affix-top

http://gios-asu.github.io/ASU-Web-Standards-Bootstrap/section-14.html

No longer documented at that location. Should be documented inline and the KSS docs will automatically be generated.

Already documented.


Ignore source files that are used as main when inferring modules

(fixes #188)

This PR attempts to address https://github.com/sol/hpack/issues/188.  However, this is non-trivial.  I'm not even sure if there is a sound solution.  Consider the following:
# source files:
#
#   linux/L.hs
#   windows/W.hs
#   src/L.hs

executable:
  when:
    condition: os(windows)
    then:
      source-dirs:
        - windows
        - src
      main: W.hs
    else:
      source-dirs: linux
      main: L.hs

#416 will produce the following output for this:
executable foo
  if os(windows)
    main-is: W.hs
    hs-source-dirs:
        windows
        src
  else
    main-is: L.hs
    hs-source-dirs:
        linux

specifically, other-modules: L is not mentioned under if os(windows), while arguably, a user would want to have it there.
Ignoring any code for now, can we conceptually come up with an algorithm that produces sensible results?
One of the issues is that main-is and hs-source-dirs "interact" with each other, but they can be specified in different places.  From what I understand, Cabal will evaluate the conditionals, eliminating everything that is false and then interpret the whole thing as if it were specified sequentially, adding a kind of procedural component to the mix (akin to what @quasicomputational already described in https://github.com/sol/hpack/issues/255).
For the example above, we know that the two branches of the if-statement are mutually exclusive, giving us more information to work with. But conceptually you could have something like:
when:
  - condition: ...
    main: ...
  - condition: ...
    source-dirs: ...
  - condition: ...
    ...

Here I don't think it is statically decidable how things interact. (statically == independent of a specific build configuration)


how to read a complete Row ?

Hi,
still learning Rust, so maybe not really a Grid question but how can I read an entire Row and not cell by cell ?
so not grid[x][y], but a way to have grid.get_row(x)
thanks
[Edit:] did what I needed differently by using pop_row().

Hey,
I am not sure what exactly you are trying to achieve, but if you want to access a specific row, why don't you just use the grid[x] function? This will return a row as a slice.

as I said, I did what I needed completely differently, so I got it working.
but I tried yesterday with grid[x] and since I got an error, I thought it wasn't the right way...
for example, this :
let mut result: Grid<u8> = Grid::new(36,6);
...
println!("{:?}", result[4]);

give me this error :
Compiling tst6 v0.1.0 (K:\dev\rust\tst6)
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
   --> src\main.rs:45:22
    |
45  |     println!("{:?}", result[4]);
    |                      ^^^^^^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `Sized` is not implemented for `[u8]`
note: required by a bound in `ArgumentV1::<'a>::new_debug`
   --> D:\Users\ffred\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\core\src\fmt\mod.rs:351:5
    |
351 |     arg_new!(new_debug, Debug);
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `ArgumentV1::<'a>::new_debug`
    = note: this error originates in the macro `$crate::format_args_nl` which comes from the expansion of the macro `arg_new` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0277`.
error: could not compile `tst6` due to previous error

 *  The terminal process "D:\Users\ffred\.cargo\bin\cargo.exe 'run', '--package', 'tst6', '--bin', 'tst6'" terminated with exit code: 101.
 *  Terminal will be reused by tasks, press any key to close it.

@ffred you could use the to_vec method to create a vector out of the slice. I guess that would solve your problem. Such as grid[0].to_vec(). Does this answer your question? For more info on slices have a look here: https://doc.rust-lang.org/book/ch04-03-slices.html

you're right, it's good. 👍
still have a lot to learn...  thank you !!


New search design

⚠ DRAFT FOR DISCUSSION ⚠
Advantages

Search from anywhere. The home page's focus is still searching, but people can also search from the results page after a query executes, and even the package pages, FAQ pages, etc.
The search results are much less cramped. I already prefer it over the small dropdown, but as we get more packages and more information to display per search result, this problem worsens.

For discussion:

We could remove the search buttons from being visible. They need to be there for accessibility but do not need to show. The search field in the navigation bar does this.

Or, the search button could be an icon or different colours rather than being removed. I could style it nicely as an icon to look like a macOS search field.

Ideas for making search progressively enhance

We could add keyboard navigation on the search results page. Pressing up/down should start a selection in the list, and enter could navigate to the selected item.

The search field also could be autofocused on the search results page. We'd need to make sure this worked well with the previous keyboard navigation with up/down taking focus out of the text field and into the selection. A little like it does now on the home page right now.

The search results page could be search-as-you-type. Unfortunately, this is not quite as simple as it first seems. The API only returns one page of results, where the search results page returns paginated results. We could fake it as we have a hasMoreResults field in the API, which we could use to add a "Next page" link.

If we don't like this method at all

What is currently the search results page could be turned into the home page. Without a query, it could show the current home page content. Then, as you start typing, we could replace that with search results. I don't think this is necessarily the best idea, but it would be the compromise I'd propose if we decide that the home page search must be as-you-type.

Not yet completed

I'd like to turn the results page into a two-column layout with a right sidebar that could show things such as:

A list of categories from the packages that would allow exploring from a search into related categories. I kind of love this idea.
The recent packages/recent releases lists.
Sponsorship CTA 💰

Mobile layout for the search field. I know what to do here, but I have not yet done it.
When a search returns no results, the opening paragraph should be better.
Pagination is not styled.

Screenshots

Mmm, I can't run make build-front-end on the M1 - there seems to be an incompatibility with the arm image.
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[-/3] ⠄ waiting...
[2/3] ⠄ deasync
error /host/node_modules/deasync: Command failed.
Exit code: 1

Just recalled that last time I extracted the compiled resources from the image. Will try that.

I want to give it another look over in the morning, but I think this is ready to go.
No major changes after our review of it this afternoon, but you might want to look through this commit as you may have thoughts on some things in there.

This is ready to go 👍


Updating allowNullOrigin to return 'null' instead of '*'.

Motivation:
Currently the way a 'null' origin, a request that most often indicated
that the request is coming from a file on the local file system, is
handled is incorrect. We are currently returning a wildcard origin '*'
but should be returning 'null' for the 'Access-Control-Allow-Origin'
which is valid according to the specification.
Modifications:
Updated CorsHandler to add a 'null' origin instead of the '*' origin in
the case the request origin is 'null'.
Result:
All test pass as does the cors.html example if you
try to serve it by opening the file directly in a web browser.

LGTM

Cherry-picked into 4.1 :)

@normanmaurer Thanks!


[MSL] SPIRV-Cross assumes std140 layout and fails with SPIR-V generated with DXC's -fvk-use-dx-layout option

This issue seems highly related to the assumption about float array implementation mentioned in https://github.com/KhronosGroup/SPIRV-Cross/pull/134#issuecomment-287390362.
It seems that currently a float array is expanded to a float4 array of the same length with the assumption that every element takes up 16 bytes, which is not the case when generating SPIR-V with DXC with the -fvk-use-dx-layout option, which packs UBOs and SSBOs in DirectX's format. In the following snippet the last element of the UBO member Float_16 should not be padded
cbuffer NamedCBuffer
{
    float Float_16[15];
    float Float_0;
};

RWBuffer<float> Result;

[numthreads(8,8,1)]
void CSMain (uint3 id : SV_DispatchThreadID)
{
    Result[id.x] = Float_0;
}

Passing this snippet through DXC with the CLI command:
dxc.exe repro_shader.txt -spirv -fvk-use-dx-layout -E CSMain -T cs_6_0
generates the following SPIR-V:
; SPIR-V
; Version: 1.0
; Generator: Google spiregg; 0
; Bound: 26
; Schema: 0
               OpCapability Shader
               OpCapability SampledBuffer
               OpCapability ImageBuffer
               OpMemoryModel Logical GLSL450
               OpEntryPoint GLCompute %CSMain "CSMain" %gl_GlobalInvocationID
               OpExecutionMode %CSMain LocalSize 8 8 1
               OpSource HLSL 630
               OpName %type_NamedCBuffer "type.NamedCBuffer"
               OpMemberName %type_NamedCBuffer 0 "Float_16"
               OpMemberName %type_NamedCBuffer 1 "Float_0"
               OpName %NamedCBuffer "NamedCBuffer"
               OpName %type_buffer_image "type.buffer.image"
               OpName %Result "Result"
               OpName %CSMain "CSMain"
               OpDecorate %gl_GlobalInvocationID BuiltIn GlobalInvocationId
               OpDecorate %NamedCBuffer DescriptorSet 0
               OpDecorate %NamedCBuffer Binding 0
               OpDecorate %Result DescriptorSet 0
               OpDecorate %Result Binding 1
               OpDecorate %_arr_float_uint_15 ArrayStride 16
               OpMemberDecorate %type_NamedCBuffer 0 Offset 0
               OpMemberDecorate %type_NamedCBuffer 1 Offset 228
               OpDecorate %type_NamedCBuffer Block
        %int = OpTypeInt 32 1
      %int_1 = OpConstant %int 1
       %uint = OpTypeInt 32 0
    %uint_15 = OpConstant %uint 15
      %float = OpTypeFloat 32
%_arr_float_uint_15 = OpTypeArray %float %uint_15
%type_NamedCBuffer = OpTypeStruct %_arr_float_uint_15 %float
%_ptr_Uniform_type_NamedCBuffer = OpTypePointer Uniform %type_NamedCBuffer
%type_buffer_image = OpTypeImage %float Buffer 2 0 0 2 R32f
%_ptr_UniformConstant_type_buffer_image = OpTypePointer UniformConstant %type_buffer_image
     %v3uint = OpTypeVector %uint 3
%_ptr_Input_v3uint = OpTypePointer Input %v3uint
       %void = OpTypeVoid
         %18 = OpTypeFunction %void
%_ptr_Uniform_float = OpTypePointer Uniform %float
%NamedCBuffer = OpVariable %_ptr_Uniform_type_NamedCBuffer Uniform
     %Result = OpVariable %_ptr_UniformConstant_type_buffer_image UniformConstant
%gl_GlobalInvocationID = OpVariable %_ptr_Input_v3uint Input
     %CSMain = OpFunction %void None %18
         %20 = OpLabel
         %21 = OpLoad %v3uint %gl_GlobalInvocationID
         %22 = OpAccessChain %_ptr_Uniform_float %NamedCBuffer %int_1
         %23 = OpLoad %float %22
         %24 = OpCompositeExtract %uint %21 0
         %25 = OpLoad %type_buffer_image %Result
               OpImageWrite %25 %24 %23 None
               OpReturn
               OpFunctionEnd

If the -fvk-use-dx-layout were omitted the line OpMemberDecorate %type_NamedCBuffer 1 Offset 228
would become  OpMemberDecorate %type_NamedCBuffer 1 Offset 240 which is what SPIRV-Cross expects.
That is Float_0 should end up at offset 228 with DX layout and not 240.
SPIRV-Cross ends up returning SPVC_ERROR_UNSUPPORTED_SPIRV after the following part of the code returns false in spirv_msl.cpp:
	if (!mbr_type.array.empty())
	{
		// If we have an array type, array stride must match exactly with SPIR-V.
		uint32_t spirv_array_stride = type_struct_member_array_stride(type, index);
		uint32_t msl_array_stride = get_declared_struct_member_array_stride_msl(type, index);
		if (spirv_array_stride != msl_array_stride)
			return false;
	}

We at Unity would like to use SPIRV-Cross for MSL generation and would prefer the constant buffers in MSL to have binary compatibility with other platforms such as DX, which is the standard for us.
Since the use of the dx-layout is not indicated anywhere in the SPIR-V, it seems that this issue could be addressed with an additional option to SPIRV-Cross telling it to expect and emit DirectX layout conformant MSL. A possible solution that comes to mind would be instead of generating a float4 array, generate an array of floats with a size that fills the inner padding and only pads the last element when to match DirectX's layout. e.g. doing something like float Float16[15*4-3]; in this particular case (the name Float16 here is just to match the snippet, it is not intended to help in explaining)

Buffer layout can only be deduced directly from Offset/ArrayStride/MatrixStride, there will not be an option to handle this. This detail of DX layout is surprising to me.
Reading the Vulkan spec, this kind of buffer layout requires scalar block layout:
Unless the scalarBlockLayout feature is enabled on the device:
• Vectors must not improperly straddle, as defined above.
• The Offset decoration of a member **must not place it between the end of a structure or an array
and the next multiple of the alignment of that structure or array**.

Is it intentional for DXC to emit ArrayStride of 16 here at all? DXC might as well just emit flat ArrayStride of 4 here. It might be possible to emit that workaround in SPIRV-Cross, and it seems it might be required for scalar block layout, which is a shame ...

I'll give it a spin, worst case, DXC could support a std140 friendly mode for CBV which does not rely on scalar block layout where the UBO is represented as a plain vec4 array like DXBC/DXIL.

It might be possible to emit that workaround in SPIRV-Cross, and it seems it might be required for scalar block layout, which is a shame ...

Given that SPIRV-Cross intends to support scalar layout (from what I've seen in the code) it would be desirable that DX layout could be handled as well, since it does not introduce any permissions which are not present in scalar block layout. To this point the DXC Vulkan doc says:

To use scalar layout, the application side need to request VK_EXT_scalar_block_layout. This is also true for using DirectX memory layout since there is no dedicated DirectX layout extension for Vulkan (at least for now). So we must request something more permissive.

in the section about memory layout rules
https://github.com/microsoft/DirectXShaderCompiler/blob/master/docs/SPIR-V.rst#memory-layout-rules

I'll give it a spin, worst case, DXC could support a std140 friendly mode for CBV which does not rely on scalar block layout where the UBO is represented as a plain vec4 array like DXBC/DXIL.

It would be great if SPIRV-Cross could address this! DXC does support a combined std140/std430 mode with -fvk-use-gl-layout which is essentially the default, but it's not compatible with the DirectX layout, which is the key here. Sadly, as the previous quote from DXC says you cannot have dx layout without conforming to scalar layout currently.

Awesome, thank you!


Cannot use the original Element as React::Element overrided it

From @raysegantii on August 14, 2015 1:9
The compiled React::Element goes directly under Opal and the original Opal.Element is lost.
Copied from original issue: zetachang/react.rb#57

From @wied03 on September 28, 2015 20:52
https://github.com/zetachang/react.rb/issues/36

From @ajjahn on October 30, 2015 14:12
@raysegantii Closing in light of #36.


[migration] Migrating files from v1 to Mino in v2

Files are named based on SHA1s.
We'll need to

Export a list of originally uploaded file paths from the v1 database
Queue each of those files for import
Find out how many videos are already in an HTML5-friendly format (#9 )

Moved to a milestone https://github.com/databrary/databrary.org/milestone/1


SSL Error

Android Version 4.4.2
Great app btw.
I'm in the USA.
CONSISTENTLY recieving error: your system does not support new ssl ciphering error : fatal alert received handshake failure

When I hit send it hard crashes.

Smartcoins Wallet requires Android 5 or higher (Lollipop) even though Google Play says 4.x, not sure why. Smartcoins Wallet uses Secure Web Sockets (wss), which are only supported by Android 5 or higher. Sorry, wish I had better news for you :( We have contacted Google Play about this, but to no avail.


Higher level electric miners for Bob's Mods?

Hi there!
Apologies in advance if this has been suggested already, but it'd be great to see the higher tier Electric Miners from Bob's Mining mod added to the calculator. Doesn't seem to be there already, unless I've missed it!

This is not the first time this has been reported (and fixed):
https://github.com/factoriolab/factorio-lab/issues/478
I'm not sure how they got removed yet again, I will look into it.


Provide support for having same column as clustering key and secondary index in cassandra

cassandra do provide this feature of having same column as clustering key and secondary index. But achilles have no such feature. Can you please provide this feature ASAP.

supporting this feature would require a rework on the DSL to avoid name clashing when using clustering column with normal CQL syntax and with secondary index syntax

Fixed in Achilles 6.0.0


SVG Injector pre-processor

Is there anything similar to this to pre-process the html and replace the img tags with embedded svg?

For pre-processing and static compiling, I'd probably go with Jade includes.
There are also plenty of run-time, client-side template systems that could work well too.


Fixing the CI workflows concurrency after file split

After merging https://github.com/spacemeshos/go-spacemesh/pull/3914 we broke the concurrency checks f.or GH.
This should fix it

bors merge

bors merge

bors merge

@pigmej What's happening with this?

Bors try

@pigmej What's happening with this?

Should be merged :) thx for rechecking:)

bors try

bors try

bors try

bors try

bors try


Provide Insight into queued compactions

Is your feature request related to a problem? Please describe.
When there are lots of compactions running, they get queued up in the tservers? (possibly the CompactionManger) and can only be seen through the Monitor. The only reason an Admin knows that there are compactions queued is in the monitor showing the number in parenthesis.
Describe the solution you'd like
Someway for an admin to know the types of the compactions queued and get more information about queued compactions.
Describe alternatives you've considered
The Shell provides information about running compactions through the listcompactions command and the fate command. But the fate command will only show user compactions and listcompactions will only show running compactions.

Per executor metrics for running and queued are emitted for each tserver.  I think that is done by this code.  The blog post about external compactions plotted these metrics in the ingest section, in that section look for the compaction queued plot and the description under it.  We also have documentation that briefly mentions these metrics exists, however it does not give any information about how to use them. Would these metrics meet your needs?  If your are looking for detailed info about what is qeueud (like tablets and files to compact, which subject to change at any time before it runs like Dave mentioned) then would possibly need new APIs to expose this information to the shell.

+1 for leveraging metrics.  If this information is useful (and I think it is) making it externally available via metrics makes it possible for monitoring, alerting and possibly trending.  While it could be useful to have the values available via the shell during troubleshooting and development - operators should not need to use the shell to perform routine monitoring.

Somewhat related to #4782


Mission Center does not show GPU stats on NVIDIA GPU

          Does not show up on my Nvidia GPU either.

Originally posted by @kimjongbing in https://github.com/NixOS/nixpkgs/issues/294143#issuecomment-2347918525
Describe the bug
No GPU under mission control
Steps to Reproduce

Open mission center

Expected behavior
GPU usage should be shown
Additional Context
I have an RTX 4070ti.
OS: NixOS 24.11.20240910.1355a0c (Vicuna) x86_64
Kernel: Linux 6.10.9-cachyos
DE: GNOME 46.4
WM: Mutter (Wayland)
Please let me know if I can provide any other information.

Same problem here, did you manage to fix it?

Same problem here, did you manage to fix it?

Nope, just waiting for a fix lol

Fixed it with setting nixpkgs.config.cudaSupport = true either globally or using overlay for this package

I already had that setting on, still it does not show nvidia dGPU.

I already had that setting on, still it does not show nvidia dGPU.

Do you use proprietary drivers or opensource ones?
https://nixos.wiki/wiki/Nvidia

I was already using the proprietary drivers and I had the cudasupport on. I am using it in offfoad mode, usign nvidia-smi I can see it working, am using ollama with cuda. Just that mission center does not show the nvidia gpu.

Then dunno

Oh, sorry, I confused this for btop. Mission center doesn't show GPU for me as well, I ended up switching to btop which works if cudaSupport is enabled

Fixed for me by re-installing a newer version of nvidia proprietary driver : nvidia-driver-550
I had the same problem on oct 6th (it worker before with older driver version)


[wip] Send tests results to Sheet

What type of PR is this:
/kind feature
/area testing
What does this PR do / why we need it:
Send data collected into a junit file during integration tests to a Goole Sheet
Which issue(s) this PR fixes:
Fixes #6451
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

Is it possible to also set this up for podman tests running via GH actions.

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
Known issue (#6876)

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated

/override "SonarCloud Code Analysis"
Code duplication on mocks


Gateway - Unhandled error in background task: 'AMM'

Describe the bug
When checking latest client and gateway development setup, an hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'AMM' occurred after successfully connected AMM-connector wallets

2023-05-19 18:54:39,322 - 5669 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 18:55:22,297 - 5669 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'AMM'
Traceback (most recent call last):
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/client/command/gateway_command.py", line 321, in _gateway_connect
    AllConnectorSettings.create_connector_settings()
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/client/settings.py", line 435, in create_connector_settings
    type=ConnectorType[connection_spec["trading_type"]],
  File "/home/rapcmia/miniconda3/envs/hummingbot/lib/python3.8/enum.py", line 344, in __getitem__
    return cls._member_map_[name]
KeyError: 'AMM'
2023-05-19 18:55:33,427 - 5669 - hummingbot.core.gateway.gateway_status_monitor - INFO - Connection to Gateway container lost...
2023-05-19 19:00:59,963 - 5669 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 19:01:49,052 - 6383 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 19:02:28,435 - 6415 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 19:03:57,789 - 6456 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 19:06:57,483 - 8193 - hummingbot.core.gateway.gateway_status_monitor - INFO - Gateway Service is ONLINE.
2023-05-19 19:07:14,489 - 8193 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'AMM'
Traceback (most recent call last):
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/client/command/gateway_command.py", line 321, in _gateway_connect
    AllConnectorSettings.create_connector_settings()
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/client/settings.py", line 435, in create_connector_settings
    type=ConnectorType[connection_spec["trading_type"]],
  File "/home/rapcmia/miniconda3/envs/hummingbot/lib/python3.8/enum.py", line 344, in __getitem__
    return cls._member_map_[name]
KeyError: 'AMM'

This error also affects the client when we tried to relaunch making it unusable at the moment.

Work around is to delete the  ../conf/gateway_connections.json file and client will work again
The last working commit was 6d7b639ddd219b4fad60b7cf612c2a81c2bf0076
Crosscheck on mbp(m1) and WSL ubuntu20.04 getting same behavior

Steps To Reproduce

Setup client and gateway latest development branch
Connect any AMM connector wallet then observe behavior
Relaunch client to observe behavior of the bug

Release version
Development dev-1.16.0
Attachments
logs_hummingbot.log

Fixed on latest Client development branch


Implement log error subscription service

Since appender must load in the very beginning of Karaf boot up we can not use other modules like Hub module in it. WE need to make subscription(observer) so that interested modules will get notified about error logs.

Added SubutaiErrorEventListener service to subscribe for error events


Do not rely on the asset pipeline when calling backend PDF generation

There were some extra asset pipeline-related calls even after #18226 in the backend PDF generation code that caused problems in some special cases. I have no idea why would we call the asset_path on a file twice, but now it's not called even once.
@miq-bot add_label gaprindashvili/no, hammer/yes, bug
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650057

@miq-bot add_label blocker

Hammer backport details:
$ git log -1
commit 2f9fa80e8513b100014bf40f4cdcd7f8a0d325e6
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Wed Dec 5 09:45:51 2018 +0100

    Merge pull request #18236 from skateman/asset-pipeline-pdf

    Do not rely on the asset pipeline when calling backend PDF generation

    (cherry picked from commit ce0cd617bd1a98a9f8d266529d01e878231528ef)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650057


ML_7_8_Gaussian_Mixture_Models_(D)_7051

Description 📜
I have included documentation on the topic Gaussian Mixture Model.
Fixes #7051

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Machine #Learning

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Isha307 I have made the changes. Sorry for the inconvinience.

@Isha307 I have made the changes. Sorry for the inconvinience.

No Problem, Good Work :(


Mentee: Mentorships page, card, and API endpoints

What Github issue does this PR relate to?
Close #71
Changes proposed in this pull request:

MentorshipsList and MentorshipCard components
mentorships page
mentorships and mentorshipsCount endpoints

What should the reviewer know?
There must at least an entry in relationships table with the mentee being the current user.

LGTM, we can iterate later on the looks of the card.

yes there is #82


Markdown improvements and architecture updates

Description / Motivation

Switched from react-markdown to next-mdx-remote
Introducing (automatically generated) permalinks for h1-h6 in articles (fixes #117)
Support for oembed  within articles
Configured ESLint and pre-commit checks for code consistency
Restructured project

How Has This Been Tested?
Local and on Vercel
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update (non-breaking change; modified files are limited to the /data directory or other markdown files)

Checklist:

[X] I have read the Contributing guide.
[X] My code/comments/docs fully adhere to the Code of Conduct.
[X] My change is a code change.
[ ] My change is a documentation change and there are NO other updates required.
[ ] My change has new or updated images which are stored in the /public/images folder that need to be migrated to Sitecore DAM

📝 Changed routes:

/404
/[solution]/[product]

(view full size)
(view full size)

/[solution]
/community

(view full size)
(view full size)

/contribute
/discover

(view full size)
(view full size)

And 18 other routes:

/api/sitecore-community
/docs
/help
/
/learn/faq/[article]/[page]
/learn/faq/[article]
/learn/getting-started/[article]
/learn/getting-started
/learn
/learn/integrations/[integration]
/learn/integrations
/newsletter/[year]/[month]
/newsletter/[year]
/newsletter
/search
/trials/[trial]/[parent]/[child]
/trials/[trial]
/trials

Commit 0d96ef5cb064ed41b2516d8ce4cfaa351258abf1 (https://developer-portal-keqa1axnv-sitecoretechnicalmarketing.vercel.app).

@markvanaalst : I think the current site looks like it's working, but I'm not able to review the new MDX features. I have not done the merge until we can chat about whether there's a way to validate the MDX.

Added two commits that show the improvements:

YouTube embed
new line in (first) table


Error while running npm install

Receiving the following error on running npm install
><EMAIL_ADDRESS>postinstall /home/daksh0225/open-source/dengue-stop/node_modules/react-native-router-flux
> opencollective postinstall

/home/daksh0225/open-source/dengue-stop/node_modules/core-js/modules/_typed-buffer.js:157
  if(numberLength != byteLength)throw RangeError(WRONG_LENGTH);
                                ^

RangeError: Wrong length!
    at validateArrayBufferArguments (/home/daksh0225/open-source/dengue-stop/node_modules/core-js/modules/_typed-buffer.js:157:39)
    at new ArrayBuffer (/home/daksh0225/open-source/dengue-stop/node_modules/core-js/modules/_typed-buffer.js:247:29)
    at zlib.js:334:28
    at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:217:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Function.Module._load (internal/modules/cjs/loader.js:685:15)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/home/daksh0225/open-source/dengue-stop/node_modules/opencollective/node_modules/node-fetch/index.js:12:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `opencollective postinstall`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Getting the following errors:

There are lot of building issues with this app. So it would be waste of time to build this. As one of the mentor said that they will fix this once the coding period starts.


"error installing docker: bash: line 0: type: docker: not found" - error seen intermittently when trying to add Digital ocean machine.

Server version - v0.32.0-rc1
"error installing docker: bash: line 0: type: docker: not found" - error seen when trying to add Digital Ocen machine.
The next attempt to add the machine succeeds.
time="2015-08-07T00:20:36Z" level=info msg="Creating Machine" eventId="3990cfbb-1c7c-4dfa-8fb0-f239be518fbf" resourceId=1ph3
time="2015-08-07T00:20:36Z" level=info msg="Cmd slice: [create -d digitalocean --digitalocean-access-token ********* --digitalocean-image ubuntu-14-04-x64 --digitalocean-region nyc3 --digitalocean-size 1gb do1]"
time="2015-08-07T00:20:36Z" level=info msg="stdout: Creating CA: /var/lib/cattle/machine/********certs/ca.pem" resourceId: =1ph3
time="2015-08-07T00:20:37Z" level=info msg="stdout: Creating client certificate: /var/lib/cattle/machine/74d98c13-0355-40f9-89b9-f4639a1a4a8f/certs/cert.pem" resourceId: =1ph3
time="2015-08-07T00:20:38Z" level=info msg="stdout: Creating SSH key..." resourceId: =1ph3
time="2015-08-07T00:20:39Z" level=info msg="stdout: Creating Digital Ocean droplet..." resourceId: =1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: Error creating machine: error installing docker: bash: line 0: type: docker: not found" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: apparmor is enabled in the kernel and apparmor utils were already installed" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: + sh -c apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys **********" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.IKoV8B86dk --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: gpg: requesting key 2C52609D from hkp server p80.pool.sks-keyservers.net" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: ?: p80.pool.sks-keyservers.net: Network is unreachable" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: gpgkeys: HTTP fetch error 7: couldn't connect: Network is unreachable" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: gpg: no valid OpenPGP data found." resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: gpg: Total number processed: 0" resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: " resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: " resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="stderr: You will want to check the provider to make sure the machine and associated resources were properly removed." resourceId=1ph3
time="2015-08-07T00:23:39Z" level=info msg="starting cleanup..." machine name=do1
time="2015-08-07T00:23:40Z" level=info msg="cleanup successful" machine name=do1
time="2015-08-07T00:23:40Z" level=error msg="Error processing event" err="error installing docker: bash: line 0: type: docker: not found" eventId="3990cfbb-1c7c-4dfa-8fb0-f239be518fbf" eventName="physicalhost.create;handler=goMachineService" resourceId=1ph3

I cant see that there is anything we can do about this. It's a docker-machine error. Can we close?

docker machine issue


Multi Arch Support for Devfile Index and Devfile Index Base

Please specify the area for this PR
Building images for multiple architectures
What does does this PR do / why we need it:
This PR allows for the devfile-index-base image to be built for different architectures. A summary of the changes are:

Added support for ./build.sh to take an optional argument that allows a user to build for a different architecture. The default is linux/amd64.
Added build-multi-arch.sh which takes care of building and pushing a multi-arch image called devfile-index-base:next to quay. This allows for users to pull from quay.io/devfile/devfile-index-base:next and it will provide them with the correct image for their arch.
Updated testing run on PRs to test the image build for both linux/amd64 and linux/arm64.
Updated pushimage-next.yaml to utilize the new build-multi-arch.sh script.
Updated documentation to explain the new ability to use the build scripts for different architectures.
Updated .ci/Dockerfile to set the yq architecture to be consistent with the architecture being built, previously it was hardcoded to amd64.

Which issue(s) this PR fixes:
fixes https://github.com/devfile/api/issues/1547
partially fixes https://github.com/devfile/api/issues/1551
PR acceptance criteria:

[ ] Test Coverage

Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

[ ] Does the REST API doc need to be updated with your changes?
[ ] Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

@Jdubrick Ive also read today this blog post. Not sure if it's something that we would like to use here
https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/


Add kTLS support for TLS 1.3

Also, I believe ktls for AES-CCM-128, AES-GCM-256 and CHACHA20-POLY1305 are also available in the kernel now, we can try to support these.


Add V1 API Version

Copied v1beta1 API files to v1
Updated package names
Added v1 API to the code generation configuration
Ran update-all.sh
Copied v1beta1 CRD version definitions to v1
Updated CRDs to make v1, the storage version
Updated filter-crds to only retain the v1 version
Updated conversion integration tests

Part of: https://github.com/jetstack/cert-manager/issues/3156
Add `v1` API version

Seems the YAML is missing, not sure if that was on purpose or not?
You should also

Make it the stored version
Modify /hack/filter-crd to only release the v1 API

Thanks for the review @meyskens. I've addressed / answered your comments. Is there anything I've missed?
I've tried to keep the commits quite self contained.

@wallrj looking good to me after the tests pass, we should also have a quick think about the API if we want to change something before it's too late

Rebased on latest master and updated the conversion integration tests accordingly.
I have not updated the cmctl convert tool or its integration tests.
I'd rather do that in a separate PR.

/test pull-cert-manager-e2e-v1-19
/test pull-cert-manager-e2e-v1-17
/test pull-cert-manager-e2e-v1-16
/test pull-cert-manager-e2e-v1-15
/test pull-cert-manager-e2e-v1-14
/test pull-cert-manager-e2e-v1-13
/test pull-cert-manager-e2e-v1-12
/test pull-cert-manager-e2e-v1-11

/test pull-cert-manager-e2e-v1-19
/test pull-cert-manager-e2e-v1-17
/test pull-cert-manager-e2e-v1-16
/test pull-cert-manager-e2e-v1-15
/test pull-cert-manager-e2e-v1-14
/test pull-cert-manager-e2e-v1-13
/test pull-cert-manager-e2e-v1-12
/test pull-cert-manager-e2e-v1-11

Changing storage version and using v1 API in legacy CRD can't work until we update all the controllers and E2E tests scripts to use the v1 API, so I removed those commits from this PR.
We agreed to make those changes in a followup PR at the same time as those controller changes.

/test pull-cert-manager-e2e-v1-19
/test pull-cert-manager-e2e-v1-17
/test pull-cert-manager-e2e-v1-16
/test pull-cert-manager-e2e-v1-15
/test pull-cert-manager-e2e-v1-14
/test pull-cert-manager-e2e-v1-13
/test pull-cert-manager-e2e-v1-12
/test pull-cert-manager-e2e-v1-11

/kind feature

/test pull-cert-manager-e2e-v1-19
/test pull-cert-manager-e2e-v1-17
/test pull-cert-manager-e2e-v1-16
/test pull-cert-manager-e2e-v1-15
/test pull-cert-manager-e2e-v1-14
/test pull-cert-manager-e2e-v1-13
/test pull-cert-manager-e2e-v1-12
/test pull-cert-manager-e2e-v1-11

/approve
/lgtm


How many times do I have to open the result to get a high score on the one I'm interested in?

@mykhailopylyp
OK, then I need to make sure I pick the correct one a couple of times to have it as the first result...
Originally posted by @dantorsmar in https://github.com/microsoft/PowerToys/issues/3148#issuecomment-802673903
I still have a mixup between the two Outlook search results!

Sorry again, I'm not used to the terminology of GitHub why I accidentally created a new issue.

@dantorsmar
Can you update to the latest PowerToys version? After that try to launch two applications.
Then, right-click on PowerToys icon in the tray menu and select Report Bug.

Drag and drop the report into a Github comment.
I start suspecting that the identifier we use to store how many times an app was opened is the same for both outlook apps.

PowerToysReport_2021-03-23-13-15-31.zip

@dantorsmar
haha, we exclude UserSelectedRecord.json file from the bug report for security issues. So I did not get any useful information.
Anyway, after some investigation is seems as we do not distinguish between those items in context of scoring. So I created #10408 to track it.


tbats dependency added

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Changes include the following:

Added tbats under requirements.run_constrained for sktime and under requirements.run for sktime-all-extras.
Updated the build number to 1.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xref: https://github.com/conda-forge/tbats-feedstock

Thank you @RISHIKESHAVAN


Added instructions and game title in Master Typing Game

PR Description 📜
summary:-

I have added Game title inside the game.
I have added an options "instructions" which navigates to instructions page.

Fixes #3308

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[ ] I have added entries for my game in main README.md
[ ] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

Thank you @TusharChamlikar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@TusharChamlikar resolve merge conflicts !

@TusharChamlikar resolve merge conflicts !

i have resolved the conflict

Thank you  @TusharChamlikar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Update docs with examples of error handling

Describe the feature
We need to update the client docs with examples of error parsing, for the new standardised errors in dapr (https://github.com/dapr/dapr/pull/7257)
Release Note
RELEASE NOTE:
DOCS UPDATE Update docs with examples of error handling.

There are no standardized errors yet - and these are unknown to me as maintainer. This issue is not actionable until standardized errors are released and finalized.

Yes, the issue is not actionable yet indeed, but I needed to create it so I could add it to the dapr/dapr PR, because they're related. The PR is not merged yet, but it's actively being worked on.
This is the work Cassie and I presented in the last community call btw, related to this proposal.

Closed in https://github.com/dapr/python-sdk/pull/659


Update issue templates

Added references for msal-node beta to all templates.

FYI these changes are also included in PR #2569

Closing as issues template was updated in PR #2569 .


How to draw the figure 1 (Radar?) of BEiT3's results ?

Describe
BEiT3

https://gist.github.com/donglixp/15f619a7ed5588755eb48d320f2b8325

The code and pre-trained models of BEiT-3 can be found at aka.ms/beit3.


Add trace identifier to gorouter logs when handling request

A short explanation of the proposed change:
Every request handler in the Gorouter now adds unique trace and span ID to the logs.
Trace and span IDs are consolidated from B3, W3C and VCAP_REQUEST_ID headers.
Details on how consolidation of headers works:

If B3 headers are set by user and zipkin is enabled in Gorouter, if they can be parsed as valid UUID, they will be used for trace and span ID as well as for VCAP_REQUEST_ID and W3C ID.
If B3 headers are not set and zipkin is enabled, Gorouter will generate trace and span ID. They will be used for B3, VCAP_REQUEST_ID and W3C ID.
If zipkin is disabled, and W3C headers are set by user and W3C is enabled in the Gorouter, W3C headers will be used as trace and span ID as well as for VCAP_REQUEST_ID.
If W3C headers are not set by user and W3C is enabled in the Gorouter, W3C headers will be generated in the Gorouter and set as trace and span ID as well as for VCAP_REQUEST_ID.
VCAP_REQUEST_ID cannot be set by user. It will be generated and used as trace and span ID if zipkin and W3C are disabled in the gorouter.

An explanation of the use cases your change solves
It would be easier to trace a specific request across multiple logs - gorouter.log, gorouter.err.log, access.log. In the future, the same trace ID will be used for the logs that follows a transaction in the system across multiple components (Cloud Controller, BBS, Rep, Garden) like cf push. This trace ID can be used to search all related logs to the transaction in log accumulating systems like splunk.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
$ curl api.cf-app.com

On the gorouter VM, tail all logs in /var/vcap/sys/log/gorouter. See logs contain:
"data":{"trace-id":"25f23d6af46d460e71357ddc0759a198","span-id":"71357ddc0759a198"}

Expected result after the change
All gorouter logs related to request handling have trace and span ID.
Current result before the change
Only access.log contain request ID.

[X] I have viewed signed and have submitted the Contributor License Agreement

[X] I have made this pull request to the main branch

[X] I have run all the unit tests using scripts/run-unit-tests-in-docker from routing-release.

[ ] (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite

[ ] (Optional) I have run CF Acceptance Tests on bosh lite

@mariash how does this behave across route service calls? e.g. if gorouter get a request for a route that has a route service attached, it will forward the request to the route service first. the request usually ends up again at gorouter, now with host set to the host of the route service. When the route service decides to forward the request to the backend app, there will be another request to yet another gorouter, this time targeting the backend app.
Currently, there will be three different VCAP_REQUEST_IDs used for each of the requests and it is relatively hard to correlate them. Will this PR keep a single trace-id across all of them instead? Reading your description, they should be set by the user (in this case the use is gorouter itself), so they would replace VCAP_REQUEST_ID on subsequent requests?

LGTM too

@domdom82 It will be the same VCAP_REQUEST_ID in the following case:

Routers should have zipkin or w3c enabled.
Route services pass down b3 or w3c trace id to the gorouter.


trtllm-build: not found

I installed tensorrt-llm based on the source code：
git clone https://github.com/NVIDIA/TensorRT-LLM.git
cd TensorRT-LLM
git submodule update --init --recursive
git lfs install
git lfs pull
python3 ./scripts/build_wheel.py --trt_root /usr/local/tensorrt

When I run the llama example,

You may need to add it to the PATH
export PATH=/usr/local/bin:$PATH

You may need to add it to the PATH
export PATH=/usr/local/bin:$PATH

There is no tensorrt-build

python3 setup.py install

can fix my issue.


Predicton step that can be run in between training epochs

🚀 Feature
Add an "inference" step, or a keyword to trainer.predict() which doesn't remove the model from GPU after the prediction run.
Motivation
For things like online triplet mining, I am predicting batches of data in between epochs. I don't need gradients for those, so I use self.trainer.predict.
something curious I've noted, is that after running "trainer.predict", the model is removed from the cuda device. I assume that is wanted behaviour, so right now I fix that by running "self.cuda(gpu_index)" afterwards.
Pitch
Since lightning is all about keeping code beautiful and organized, I propose there should be a keyword in trainer.predict() which keeps the model on the cuda device.
Alternatives
Right now, it works to write "self.cuda(gpu_index)"  at the end of the prediction loop. However, if one doesn't know this, then it can take quite a while to figure out, especially in larger projects.

Dear @OlfwayAdbayIgbay,
This sounds reasonable. Potentially we could prevent this behaviour for predict only.
@ananthsub Any opinions ?
Best,
T.C

@OlfwayAdbayIgbay could you share what your code calling trainer.predict currently looks like? I'm curious about this

For things like online triplet mining, I am predicting batches of data in between epochs. I don't need gradients for those, so I use self.trainer.predict.

@tchaton i don't think this is prediction specific, right? this is more about the accelerator/training type, and expectations around moving the model back to cpu after execution. this is currently hardcoded in the parallel plugin: https://github.com/PyTorchLightning/pytorch-lightning/blob/c4a1c8ba20975ecf5d3ffb76b8cbc107ab761356/pytorch_lightning/plugins/training_type/parallel.py#L141-L145
In general I wonder what our principles for plugins are in terms of cleanup. We had a slightly related discussion with @awaelchli, @carmocca, and @yifuwang about process groups here: https://github.com/PyTorchLightning/pytorch-lightning/pull/8080
Strawman proposal: if the model is already on the device at the start of training, we don't move it to CPU afterwards. This way, the lightning trainer leaves things as it finds them. is that too idealistic?

Strawman proposal: if the model is already on the device at the start of training, we don't move it to CPU afterwards. This way, the lightning trainer leaves things as it finds them. is that too idealistic?

makes sense to me :) just requires more bookkeeping for metrics, optimizer state, and model parameters (and maybe more) too keep track of.

@ananthsub of course! See the following:
It also has to be done on_train_epoch_start, because if you call this on_train_epoch_end, the trainer will not do the logging! Maybe I should open an issue for that as well :)
    def on_train_epoch_start(self):
        # Gets random triplets
        self.dataset.start_building()
        # Predict Embeddings
        embeddings = self.trainer.predict(self,return_predictions=True)
        embeddings = torch.vstack(embeddings)
        # Sort by class
        embeddings = embeddings.view(self.dataset.num_classes,len(embeddings)//self.dataset.num_classes,embeddings.shape[-1])

        #Mine the embeddings (done on cpu, for maximum gpu
        self.dataset.start_mining(embeddings.cpu())

        #Put model back on gpu, which has been moved off the gpu after trainer.predict ended
        self.cuda(*gpu_index)


Allow specifying explicit kernel release and version for falco-driver-loader

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
This PR adds the ability to specify explicit kernel release and version when running falco-driver-loader. This is important in cases where the Falco driver needs to be compiled for a kernel other than the currently-running kernel (such as when the kernel had been updated but not yet booted into).
Which issue(s) this PR fixes:

Fixes #2658
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?:

feat: Allow specifying explicit kernel release and version for falco-driver-loader

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: johananl
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @johananl! It looks like this is your first PR to falcosecurity/falco 🎉

/milestone 0.36.0
Thanks for taking the time to tackle this one! We are going to look into it asap!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, johananl
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 15c8df01fe85054ab9832eda5ee00556b1333b84

Forgot to mention that I tested my changes by executing the script manually in both modes (kmod and BPF) with default values as well as with explicit kernel release and version on the following distros:

Amazon Linux
Debian (kmod compilation didn't work for me, but that's true even before my changes)
Ubuntu
Flatcar (download doesn't work because the driver repo doesn't contain files for Flatcar, bpf compilation didn't work due to https://github.com/falcosecurity/falco/pull/2729 but should work now)

If we refactor the script to be functional, we could use something like https://github.com/bats-core/bats-core to unit-test the file.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, johananl
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Bug: viewing .usdz in Chrome breaks every time

Description
I'm using glitch.com to view/test my model-viewer scenes and have been for a couple of years. While testing my most recent project I noticed that I'm getting a strange crash every time I am trying to view the AR model in iOS when using Chrome. I assumed it was a user error but then even tested the google animals that are using modelviewer as well as the models straight from modelviewer.dev in chrome. The same scenes work as expected in Safari.
This bug can be reproduced by using Chrome on iOS and attempting to view an AR asset in preview. (Not sure if this matters but I'm using iOS 15.4)
Example File

https://glitch.com/~anasazi-raven-and-pot

Loom Recording

https://www.loom.com/share/9f02e8a3486a4f2aaf8e27a896b49010

Screenshots
The following screenshots were taken from attempting to view models on modelviewer.dev in AR using Chrome iOS:

Loom Recording

https://www.loom.com/share/9f02e8a3486a4f2aaf8e27a896b49010

Version

model-viewer: v1.10.1

Browser Affected

[x] Chrome, version: 99.0.4844.59
[ ] Edge
[ ] Firefox
[ ] IE
[ ] Safari

iOS

[ ] Android
[x] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

AR

[ ] WebXR
[ ] SceneViewer
[x] QuickLook

I have observed the same bug in my app. QuickLook worked for iOS Chrome and iOS Firefox before the update to iOS 15.4. Now it only works for Safari on 15.4.
Before the update to iOS 15.4, I was able to get QuickLook working on iOS Chrome and iOS Firefox with the help of this issue comment from issues/1796. Maybe helpful because it seems that the .usdz file is interpreted as a text file again.

Can confirm here too. On iOS 15.4 iPhone 12 Pro, trying to open USDZ in Chrome, Firefox results in page of text.

Having done some digging, I found this chrome bug report:
https://bugs.chromium.org/p/chromium/issues/detail?id=1302551&q=USDZ&can=2
Where there is a discussion about Content-Disposition header.
In some initial tests, when I set the USDZ file to be served with header Content-Disposition: attachment
the following is observed:

iOS Safari - opens AR QuickLook
iOS Chrome - opens AR QuickLook 🎉
iOS Firefox - opens page of text 😕
iOS Edge - opens AR QuickLook 🎉
iOS Opera - opens a file download dialog 😕

I can confirm @milesgreen findings (thanks for sharing) for:

iOS Safari - opens AR QuickLook
iOS Chrome - opens AR QuickLook 🎉
iOS Firefox - opens page of text 😕

and that  serving USDZ files with an Content-Disposition: attachment header fixed AR QuickLook on iOS Chrome for me.

Hey, can you please share the fix for a beginner please?
Thanks!

@AdrianTabacaru In our case, we have an Apache based server and we simply added the following to the .htaccess file in the root directory.
<FilesMatch "\.usdz$">     Header set Content-Disposition: attachment </FilesMatch>

@AdrianTabacaru my .htacces file looks like this:
<FilesMatch ".+\.(usdz)$">
    Header set Content-Type "model/vnd.usdz+zip"
    Header set Content-Disposition "attachment"
</FilesMatch>

The Header set Content-Type "model/vnd.usdz+zip" row fixed Problems with iOS-Firefox and iOS-Chrome on iOS < 15.4

Thank you for your answers. My .htacces files was empty, I've been trying both:
<FilesMatch ".usdz$"> Header set Content-Disposition: attachment
or
<FilesMatch ".+.(usdz)$">
Header set Content-Type "model/vnd.usdz+zip"
Header set Content-Disposition "attachment"

refreshed the page on the phone and still ASCI text appears on my iPhone iOS 15.4
What am I doing wrong?
Thank you!

Can you guys confirm that accessing this page works on you iOS 15.4 ?
For me it worked on the previous iOS version but after update I get ASCII

Thank you!

Thank you for your answers. My .htacces files was empty, I've been trying both: <FilesMatch ".usdz$"> Header set Content-Disposition: attachment
or
<FilesMatch ".+.(usdz)$"> Header set Content-Type "model/vnd.usdz+zip" Header set Content-Disposition "attachment"
refreshed the page on the phone and still ASCI text appears on my iPhone iOS 15.4 What am I doing wrong?
Thank you!

Based on this code. Seems like you missed the closing tag and missed a backslash. Make sure you copy the exact code
</FilesMatch>

Hey sorry, that was a mistake in the previous post. the .htacces file on the root folder on my webpage is pasted correctly:
<FilesMatch ".usdz$"> Header set Content-Disposition: attachment
but still has the ASCII response on my phone :-)
Shoult it need more time to propagate? I have no idea :-(
Thanks!

The effect is usually immediate on normal servers. I am not sure why it doesn't work for you (I tested it with your QR and can confirm it doesn't work on Chrome 15.4)
Another thing, might be a typo on your post, it is .htaccess with two 's' at the end

Much more weird is that the official  webpage has the same ASCII response behavior on my phone.
https://modelviewer.dev/

I confirm this was fixed using this code:
<FilesMatch ".+\.(usdz)$">     Header set Content-Type "model/vnd.usdz+zip"     Header set Content-Disposition "attachment" </FilesMatch>
in the .htaccess file
Now, I have multiple .htaccess files, one is located on root, one is on public_html folder and another one is in the folder where the .usdz and the .html files sit. I don't know which one does the job, putting it only on root doesn't seem to fix it in the beginning for me.
Also, after making it to work, I have deleted all the .htaccess files on all the folders including the root, deleted the cache on my phone and it looks like now it works without that file. Or maybe tha cache wasn't completely deleted...
Anyway I will put one .htaccess file on root as @Ocupe suggested and I will post here if everything works smoothy.
Thank you @Ocupe for the code and everyone for your support!
Cheers!
Adrian

@Lavosbit hello! Excuse me, were you able to get it to work on Glitch? Thanks!

I think this issue may have been patched somewhere along the way with Chrome 100.
I'm testing on iOS 15.5 beta (19F5047e), Chrome 100.0.4896.77.

Thanks for sharing @milesgreen! I'm going to close this to let others know. Please post if you need me to reopen.

Sooo... I did some more thorough testing. It appears this is in fact still an issue, even with Chrome 100 in iOS 15.4.1. In this instance, event with Chrome 100 but without the Content-Disposition: attachment HTTP header, Chrome will still attempt to display USDZ in-line as text.
But in iOS 15.5 (beta 1 and 2), this is no longer an issue in Chrome, and even without the Content-Disposition: attachment HTTP header, Chrome will display USDZ properly via QuickLook.
So for now, folks may want to keep adding Content-Disposition: attachment, as iOS 15.4 will be around a little while longer.

Ran into the problem myself today with Chrome 100+ on iOS 15.4.1, added the header and it works in both (Safari and Chrome) on iOS fine now... thanks for the help, folks!

From iOS-Chrome, it sounds like they are planning to have this fix go into Chrome 102.


Make empty address addition explicit

fixes #470

Good Idea and nice implementation of the ternary operator 🧠!
However i noticed some inconsistencies during testing:
1.) I was not able to select "no address addition" for multiple affiliations:

This affiliation does not have "no address addition" as an option, therefore you cannot select it

2.) If no address affiliation is explicitly selectable i'd argue that the empty selection should be removed.

It's the part of the implementation of the vaadin dropbox. I would argue then to remove it for all organisations independent of how many affiliations are associated with it

I think it makes sense to remove the empty selection for all organisations but maybe this is something we can add as a seperate issue down the line 👍


Engagement Report Cannot be Approved

Report author submitted a report but when the report approver went to the report, the report had a draft status.  The approval step ID in the reports table record is NULL in the database.
Report number 73127
Report author 1755
2027 (15:57:49 Z)
Source: auditLogger file from 2018-03-13
Report author has submitted report 73127
2028
Source: ANET email
Email sent to report author stating report is ready to be approved
2029
Source: email from report author to ANET administrator
Report author has submitted report

@VassilIordanov I emailed a supporting screenshot to you.
In the screenshot, the approval chain is in edit mode.  The super user added himself to two approval steps with differing results.
The super user added himself to Step 1.  The super user's name is the last name displayed in Step 1.  The super user's name in Step 1 is rank and then name.  In the position column, the super user's billet number is displayed.
The super user added himself to Step 2.  The super user's name is the first name displayed in Step 2.  The super user's name is just the name without a rank.  In the position column, the super user's position title is displayed.

This is what I think has happened:

the report author has submitted the report
the report approver has received an e-mail about the report ready to be approved
the report author has edited the report and saved it (at this point the report becomes draft again
the report approver went to the report to be approved but meanwhile this one is draft again

@gjvoosten I agree with creating a second issue.

@maradragan Per your comments above, the log file reflects that the report author retrieved the report immediately after submitting the report.  However, the time difference between submitting the report and then retrieving the report was .285 of a second.
The report author submitted the report at 15:57:49.704; this is a "report" log entry
The report author retrieved the report at 15:57:49.985; this is a "ReportSensitiveInformation" log entry
The report author updated the report at 15:58:25.423; this is a "ReportSensitiveInformation" log entry
I also emailed the report author.  He doesn't remember editing the report again.  And this wasn't the first time this has happened to this report author.  On 12 March, the report approver also could not approve the same report.  I found the log entries.
The report author submitted the report at 16:49:27.446; this is a "report" log entry
The report author retrieved the report at 16:49:27.555; this is a "ReportSensitiveInformation" log entry
The report author updated the report at 16:49:43.071; this is a "ReportSensitiveInformation" log entry
This is followed by about 100 update "ReportSensitiveInformation" log entries.  And per @gjvoosten 's suggestion, the updated log entries are approximately 30 seconds apart.

@dspCarlson One hypothesis of what could have happened is this:

the author saved the report
the author submitted the report
the author clicked on Edit of that report, did not actually change anything, but might have clicked or tabbed into the Report text or Report sensitive information text fields
this could have made the page autosave the report, at which point it gets reset to Draft state

At least with release 2.0.15 (which presumably is what was running at the time of reporting this issue), I can reproduce that behaviour. With the latest release (where autosave is slightly smarter) I am no longer able to reproduce this. So it would appear to be fixed, at least for this hypothetical scenario.
If you agree with the above you may close this issue.

@gjvoosten I believe this is the behavior too.  The report author clicks the "Edit" button after submitting the report.  Believe it or not, yesterday the same super user contacted me again about the same problem.  I emailed the report author directly and asked them if they had clicked the "Edit" button after submitting.  I have not heard back (so that means that was the problem).


fixed the meme generator script

The minor bugs listed in #163 were fixed by

Using .png extension instead of .jpg
Replacing spaces in input line with underscores, using tr (fastest method according to this ).

Pull Request Label:

[x] Bug
[ ] New feature
[ ] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same fix or component?
[x] Have you ran the tests locally with bats tests?

fixed #163

Hey, sorry I haven't been able to answer this but before I merge I want to understand why some of  the tests are failing. When I am able to I will take a further look into it

I was wondering the same about the tests. Also I appreciate your looking into it.

Not stale still looking into this, been busy with finals


Yatin: Watch surveytoearn.us

Yatin requests the watch of the watch_keyword surveytoearn\.us. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

surveytoearn\.us has been seen in 1 true positive, 0 false positives, and 0 NAAs.

surveytoearn\.us has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ

Approved by tripleee in Charcoal HQ


Don't use hover effects when on mobile

from 6b1c0c0 to 110afe0

rebased with main

@jarolrod I'm not able to reproduce the issue with the TextButton

@johnny9 Press it, hold it, then let go somewhere else on the screen

I think the apk maybe isn't updating from CI

update from 110afe0 to 405a5c8:

rebased with main