Can Not Post Any Data From Panel

Describe the bug
hi every body, my admin panel has set up successful and working fine BUT i cant post any data from my panel but its OK with postman
on panel error: There was an error updating record, Check out console to see more information.
AND no log in console!
Installed libraries and their versions
"@admin-bro/express": "^3.0.0",
"@admin-bro/mongoose": "^1.0.0",
"admin-bro": "^3.2.5",
"admin-bro-theme-dark": "^1.0.0",
"body-parser": "^1.19.0",
"express": "^4.17.1",
"express-formidable": "^1.2.0",
"mongoose": "^5.10.4",
"morgan": "^1.10.0",
"nodemon": "^2.0.4"
My POST Req Source
router.post('/' ,(req, res, next) => {
    const product = new Product({
        _id: new mongoose.Types.ObjectId(),
        name: req.body.name,
        description: req.body.description,
        price: req.body.price,
        perviousPrice: req.body.perviousPrice,
        inStock: req.body.inStock,
    })

    product
    .save()
    .then(result => console.log(result))
    .catch(error => console.log(error))

    res.status(201).json({
        Created: product
        })
})

help me with this
thanks you

Info: admin uses formidable to parse the incoming data (we are sending it via FormData - not via application JSON, due to the fact that we have to be able to send Files).
And some other express middleware also parses the incoming data and brakes AdminBro (body parser is the most often a problem). So this is what I suggest
Turn off all your other routes temporarily and see if (when left alone) AdminBro works fine with POST. If that is the case, move AdminBro initialization on the top of the file (as the first middleware) and turn off other middleware.
You can gradually turn on middleware as well and let me know which happened to be an issue. I will add some message to the core as we did with body parser: https://github.com/SoftwareBrothers/admin-bro-expressjs/blob/948b0b78841aebfd207eb68cee2e43cb6e6c3147/plugin.js#L157-L171

thanks very much.
all of my middlewares are deactive
so there is nothing wrong between middlewares
and when i check console there is an error in network section witch i forgot to check yesterday:
admin bro req is :
-----------------------------188910956530102845323742406638
Content-Disposition: form-data; name="name"

test
-----------------------------188910956530102845323742406638
Content-Disposition: form-data; name="price"

12
-----------------------------188910956530102845323742406638--

and server res is
MongooseError: document must have an _id before saving
    at Timeout._onTimeout (D:\Work Space\ExpressJS\RESTful Store API\node_modules\mongoose\lib\model.js:269:18)
    at listOnTimeout (internal/timers.js:551:17)
    at processTimers (internal/timers.js:494:7)

it seems admin bro does not generate _id using mongoose
thank you very much again sir

admin does not generate id. mongoose should do this. can you paste:

schema
full stack trace (where it happens in AdminBro)

closing due to lack of communication


⚠ Samsung has degraded performance

In 4b748ef, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2098 ms

Resolved: Samsung performance has improved in dd8ff28.


Incorrect highlight count

Version 3.0.9 (explicitly tagging versions in public git would be recommended).
It would seem the highlight function is somehow off-by-one - not sure if this affects all of the blocks, but the easiest testable (Crimson Heart) doesn't highlight the leftmost heart on one map.

...tested with another map, this time with Corruption map. Again, one Shadow Orb isn't highlighted.
It's not a matter of map position though, it's probably an internal order of the counted objects.

Strange.  I'll have to look into what's happening.

...:sweat:...
OK, this is a dupe of #36 after all.
It just happens to be that both of the non-highlighted objects were submerged.
If you happen to have a map were a large object is partially submerged, you may sometimes (on lower zoom level or when textures aren't used) see that the object is partially highlighted (just the part above water level).

...however, I've found a different typo: in res/items.json, Space Gun is incorrectly listed with the same id as Bottled Water.

...funny, you've failed to address my last comment...

Actually, I'm a bit curious: how do you produce those res json files in the first place ?
Cause given their size, it doesn't seem to be by manual entry...

I didn't comment on it, sorry, but I did fix it.  I just haven't pushed it yet.
The json files are generated by a web tool.  I've been contemplating porting the tool over to Qt and sticking it into Terrafirma.

...correct me, if I'm wrong, but doesn't that tool get its values from the executable ?
Not that I know which tool you're talking about, I simply don't see any file among loose data that would contain such info.
Also, such tool would still need a history database - I didn't check if you're actually using 'min' fields from header.json, but I'm nearly certain that those are history related.
Cause if so, it might be tricky to get it to work with both Windows and Linux executables...

Pretty much all the data is gotten from reverse engineering the executable.  The header stuff definitely is (and I do use min and max).  The tool just gives a nice way of editing the jsons.

...I wonder if there's a freeware tool not written in C#, that is able to do some of the more basic stuff dnSpy/ILSpy are doing - some of basic bytecode reversing at least...

...I mean something scriptable, like able to list contained classes, then dump the selected ones...


Fixed wrong counter modifying

Changes proposed in this pull request:

fixed wrong counter modifying

Related: https://github.com/SoftEtherVPN/SoftEtherVPN/issues/1854

brief look at th PR gives me an idea that we leak something on l2tp client disconnect so, if I for example connect/disconnect many times, I'll see something bad, right ?
In short - yes. But did some tests and can say that it seems something also needs to be fixed. I need some time to investigate it in more detail. Fixing counter in this PR resolves problem when l2tp after "reconnect-spam" gets unaviailable at all with eating 100% core. So i marked it as draft.


Add missing assembly to 'Creating the Data Set' section in the 'Working with linq' tutorial

Summary
The Creating the Data Set section was missing two assembly that it needs in order to compile. If the the user tried to compile the code as the tutorial told him to do, he would see an error message, instead of what was prompted in the image used at the end of this section.

Thanks, @Marcos-Costa, for making the additional change. I'll merge your PR now. Your changes should be live on docs.microsoft.com in the next day or two.


[PR][CLOSED] Improved clang format checker

 Issue by geunsik-lim
Monday Jul 09, 2018 at 11:02 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/111

This PR is to update the existing clang format checker for maintenance
and to improve exception handing due to incorrect source folder name
Changes proposed in this PR:

Added annotations in clang format module
Updated source folder check routine

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

geunsik-lim included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/111/commits

 Comment by git-bot-sec
Monday Jul 09, 2018 at 11:02 GMT

Thank you for submitting PR #111. Your PR has to pass all verificiation processes of cibot before getting a review process from reviewers. We recommend that you read instruction manual in . If you want to monitor the progress status of your PR in detail, visit http://aaci.mooo.com/.

:octocat: cibot: Thank you for posting issue #135. The person in charge will reply soon.


Cannot import SignInConfig in App.tsx from @backstage/core

After adding the GitLab authentication provider as per the documentation, compilation with yarn tsc fails as it can't find SignInConfig from @backstage/core
Expected Behavior
yarn tsc compiles the project without errors
Current Behavior

27 import { gitlabAuthApiRef, SignInConfig, SignInPage } from '@backstage/core';
                              ~~~~~~~~~~~~

  node_modules/@backstage/core/dist/index.d.ts:784:14
    784 declare type SignInConfig = {
                     ~~~~~~~~~~~~
    'SignInConfig' is declared here.

Steps to Reproduce

Add code to import SignInConfig from @backstage/core in App.tsx as per the documentation
Run yarn tsc

Context
Using a backstage app originally created using npx @backstage/create-app (@backstage/core 0.7.3)
Your Environment

NodeJS Version: 14.16.1
Operating System and Version: Ubuntu 20.04.2 LTS

Thanks, my mistake! Remove the type for now if this is blocking you, but will be fixed by #5277. 🙂


⚠ ukgrpc.serverssh.us has degraded performance

In 8e5ceff, ukgrpc.serverssh.us (http://ukgrpc.serverssh.us/) experienced degraded performance:

HTTP code: 200
Response time: 5324 ms

Resolved: ukgrpc.serverssh.us performance has improved in d1b9604.


DaaS Environment Support for CitrixCloudGov

In 'internal/provider/provider.go' there is support for Citrix Cloud and Citrix Cloud Japan but there is no support defined for Citrix Cloud Government.  Requesting the endpoint URLs be added for CitrixCloudGov support.

Hi @shilllabs ,
Please check out our latest release tagged in the issue thread. We have added support for Citrix Cloud Gov environment.
Please let us know if it solves your issue.
Thank you!


Feature [Tooltip]: Controlled open state

Describe the bug
This is not a bug but more an enhancement. Sometimes there is a need to keep a tooltip open regardless of mouseout.
In my scenario I am using it for erronous input. I don't want it to close until the input is valid again.
To Reproduce
Steps to reproduce the behavior:
Create a tooltip and mouse over and out.
Expected behavior
A new flag to allow it to remain open regardless of mouseout.

Got it! So you basically want an option to control the state of the tooltip!

Yeah. There is already a control for mouse click. It would be nice to also have a mouse out one too. That way it can be controlled programmatically

Closed as duplicate of #182


ESV Proverbs do not import correctly

Import a block of proverbs.
Only the first two lines are included in the block.
*update - actually I think it is the default English Word Bible and not ESV

Like this?

Thanks for the feedback, it is due to the different formating of proverbs, will have a look

KJV does it too.

I can confirm it's still an issue.


"Join our community on Slack" link on homepage is dead

The big button "Join our community on Slack" on your homepage is no longer working:

CC @krzysztofstudniarek

Thanks for reporting, will take a look.

@CherryDT what kind of device did u use to access the link?
I can't reproduce the issue on desktop, however Slack links does not work on mobile devices.

Desktop with Chrome on Windows

Firefox Desktop (Mac) same - so no client issue.

I have the same problem in MAC

Facing same issue

@CherryDT, @on21life, @amoghgopinath could you check this link: https://join.slack.com/t/adminbro/shared_invite/zt-1c7z4k0v9-kBNAivB8lX3OWLWu6TLE7A ?

@CherryDT, @on21life, @amoghgopinath could you check this link: https://join.slack.com/t/adminbro/shared_invite/zt-1c7z4k0v9-kBNAivB8lX3OWLWu6TLE7A ?

yes it's working

Closing as resolved


Only one cersion of nwjs

File nwjs.rb has only 0.19.4 vesion, could it be updated - I can download all major versions, for ex.: 0.14.5, 0.19.5, etc?

We’ll only take the latest version. See Acceptable casks policy in caskroom/versions.
Being updated in #30306.


[Snapshot Interop] Improve Test Coverage for Snapshot Interoperability with Remote Store.

Description
Adding more ITs for Snapshot Interoperability w/ Remote Store as part of this PR.
Check List

[x] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

tagging @sachinpkale and @gbbafna for review.

@harishbhakuni are we planning to merge this

@neetikasinghal yes, will pick this before 2.12 release.

Hi @harishbhakuni, Is this being worked upon? Feel free to reach out to maintainers for further reviews.

Closing this stalled PR. Please reopen to continue with the contribution.


[Exam] Enable instructor code editor assignment repository

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: Added integration tests
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I documented the TypeScript code using JSDoc style.

Motivation and Context
The assignment repository allows instructors to easily check whether the tests for a programming exercises work as expected. This is especially helpful when setting up an exam.
 Auto gc might lock files preventing a proper deletion. See https://stackoverflow.com/questions/45266021/java-jgit-files-delete-fails-to-delete-a-file-but-file-delete-succeeds and https://git-scm.com/docs/git-gc for a secription
[x] As the assignment repository is just a student participation of the instructor, an additional argument was added to the startExercise method to identify this case. Otherwise, we don't have semantically correct information whether to lock the repository for this exam exercise or not.

Steps for Testing

Exam exercise

Create a exam programming exercise
Open the instructor code editor
Create the assignment repository
Play around with the common code editor actions and verify that they work as expected
Hit the button "Delete assignment repository"
--> The assignment repository should be deleted
Re-create the assignment repository
Conduct the exam
--> No problems occur during preparation, participation and assessment

Course exercise

Create a course programming exercise
Participate in it
--> Everything should work like before

Screenshots

Reset -> Delete

I think you have an outdated Steps for Testing Description regarding the 'Delete Assignment Repository' button.
Other than that everything works as expected with creating / deleting assignment repositories for exam exercises. The code looks good. 👍

Fixed the testing description. Thx

I just found a small thing:
When creating a merge conflict in the instructor code editor, the right error is thrown, but the resolve conflict button is not displayed:

But not quite sure if this is even relevant for the instructor code editor 😅

@sascha11110  @stefanwaldhauser This problem was difficult to debug. Can you try again and make sure that you are instructor in the specified course? Only being admin is not sufficient as WebSocketConfiguration.isUserInstructorOrHigherForExercise denies the subscription to the topic in this case. The authorization context is not set in this case and isAdmin() will return false. This is unrelated to the PR.

@sascha11110 @stefanwaldhauser This problem was difficult to debug. Can you try again and make sure that you are instructor in the specified course? Only being admin is not sufficient as WebSocketConfiguration.isUserInstructorOrHigherForExercise denies the subscription to the topic in this case. The authorization context is not set in this case and isAdmin() will return false. This is unrelated to the PR.

We should make sure that admins can always do all actions in Artemis! Would be nice if we can fix this issue, either directly here or in a follow up PR


use extentions for the modern files project

Can I use extensions in this modern file explorer like : Qttabbar  or file converter ?
I know this project is very powerful and has functioned better than the old file explorer but I really miss the function of clicking on files and showing the content of it in a dropped menu, it increases my speed and my productivity,
I will be happy if I can use Qttabbar on this files explorer or if you add this function in the future.

No visual changing ones. Other rpograms would have to make it for Files. If the extention adds entries to the context menu then yes it will work.


Workspace: Inherit project-oriented Cargo.toml attributes

Describe the problem you are trying to solve
Having a workspace set up for multiple related crates, there's usually a big chunk of Cargo.toml attributes which need to be copy-pasted across all instances.
For example, in UNIC, we have (at least) these lines in all (published) Cargo.toml files:
[badges]
maintenance = { status = "actively-developed" }
is-it-maintained-issue-resolution = { repository = "open-i18n/rust-unic" }
is-it-maintained-open-issues = { repository = "open-i18n/rust-unic" }
appveyor = { repository = "open-i18n/rust-unic", branch = "master", service = "github" }
travis-ci = { repository = "open-i18n/rust-unic", branch = "master" }

Most of such properties are project-specific, but not crate-specific. For example, an indicator of that would be the fact that the share the same repository value.
Describe the solution you'd like
It would be great if we could actually have such project-oriented attributes inherit from the workspace's main Cargo.toml, and do no need to maintain copies of them.
Notes
Wdyt?

For anyone interested in this issue I've posted an RFC which I think will help resolve this. Feedback on the RFC would be most welcome!

@alexcrichton isn't this superseded by https://github.com/rust-lang/cargo/issues/8415#issuecomment-785277387? If so, we can close this

Workspace inheritance is stablized and will be released in 1.64.
This issue specifically mentions [badge] which was not included but it is no longer used on at least crates.io.
I lean towards going ahead and closing this.  If there is a reason to re-evaluate this, let us know!


LTC-USDC pair is missed

hey, its me again)
this pair is missed in ProductType enum
btw, is there any ETA of the next release?

hey @ahilis . i don't see LTC-USDC as a valid trading pair so I don't think it makes sense to add.

there's no set schedule.  Typically as changes pile up over time, I do releases.
will close for now, thanks!

hey @ahilis . i don't see LTC-USDC as a valid trading pair so I don't think it makes sense to add.

there's no set schedule.  Typically as changes pile up over time, I do releases.
will close for now, thanks!


How to change element content in sciter.js?

Hi, I can change button's text dynamically using zepto.js (refer by samples/$).
Sciter.JS version = latest.
below source code is right : `

I want use sciter.js only (not depend on zepto.js), but I failed many times.
Would you give me equivalent solution without any dependencies.
Thanks.

<html>
    <head>
        <title>Test</title>
        <style></style>
        <script>

var counter = 0;

document.$("button").on("click", function() {
  this.innerHTML = `clicked ${++counter} times`;
});

        </script>
    </head>
    <body>

<button>Click me</button>

    </body>
</html>

This above:
  this.innerHTML = `clicked ${++counter} times`;
should be
  this.innerText = `clicked ${++counter} times`;
but it is a bug in innerText implementation for buttons. My pardon.

Thanks!   I'm researching htmx (htmx.org) and want to modify it and use with sciter.js. I think it's a better approach to reduce event handler efforts and avoid many errors especially for local desktop UI with remote backend application architecture.
But htmx is relied on xmlhttprequest, it's failed for my first try.

But htmx is relied on xmlhttprequest,

xmlhttprequest is quite outdated, Sciter supports Fetch API instead.
But I think in case of Sciter and desktop application with local backend it is more convenient to just add one native gate-function
backend.exec("get"|"put"|"delete", "path" [, params ])

It's good idea. My expectation is use sciter.js to develop android application, and have a gateway or façade to talk with remote backend. This is similar as BFF pattern, My sciter.js app is separate 3 layer : UI (user interface ) layout layer and UI (user interaction) logic layer in customer device (laptop or android mobile, package by sciter.js quark), business logic or  data service layer are running on remote. with exposed APIs.


invert "can be a package or workspace" between dist-workspace.toml and dist.toml

Currently a dist.toml can be a [workspace] but we'd like to instead make it so dist-workspace.toml can be a [package].
Constraints/goals:

for simple single-project cases you shouldn't have to make manifest files
don't want the gross distinction of cargo with "virtual" and "non-virtual" workspaces
want it to be easy to say which file to put something in

Right now we let a dist.toml be a defacto dist-workspace.toml but it can't have the workspace.members field. We should flip it around so that a dist-workspace.toml file is always the root, and if it doesn't have workspace.members it's assumed the current dir is a package, as if it were a dist.toml.

Done in #1395


[FEATURE] Endpoint to purge cache entries for specific users

Description
Finishing previous PR here: https://github.com/opensearch-project/security/pull/4314
Currently, our system only allows for the invalidation of the entire user authentication cache, which can lead to numerous cache misses and inefficiencies. This change is required to allow for more precise cache management, specifically targeting stale cache entries at the individual user level without disrupting the cache state of other users
Category: New feature
Why these changes are required?
Currently, our system only allows for the invalidation of the entire user authentication cache. This change is required to allow for more precise cache management, specifically targeting stale cache entries at the individual user level without disrupting the cache state of other users.
What is the old behavior before changes and new behavior after changes?
Previously, invalidating a user's cache required clearing the entire cache, affecting all users. The new behavior introduces an endpoint that allows for the invalidation of cache entries on a per-user basis, thereby maintaining cache integrity for other users and reducing unnecessary cache misses.
Issues Resolved
https://github.com/opensearch-project/security/issues/2829
Is this a backport? If so, please add backport PR # and/or commits #
no
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
Unit testing was written in FlushCacheApiTest.java
Check List

[x] New functionality includes testing
[ ] New functionality has been documented
[ ] New Roles/Permissions have a corresponding security dashboards plugin PR
[ ] API changes companion pull request created
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks This should be a better PR, I'm not sure why there's integration test errors I don't change them, can you help me out with that? It should be the same test errors as in https://github.com/opensearch-project/security/pull/4568

Thank you @prabhask5 ! Looking at the integ test failures now.

@prabhask5 Can you rebase this PR with the latest from main that has a fix for the compilation error?

@prabhask5 For the issue with FlushCacheApiIntegrationTest.testFlushCache there are 2 problems:

In FlushCacheApiAction you need to modify the response message if the param username is non-null. i.e.

if (username != null) {
    LOGGER.debug("Cache invalidated for user: " + username);
    ok(channel, "Cache invalidated for user: " + username);
} else {
    LOGGER.debug("cache flushed successfully");
    ok(channel, "Cache flushed successfully.");
}

You would also need to move the extraction of this param up one level in scope.

This line is using the wrong response object. It should be referencing deleteUserCacheResponse instead of deleteAllCacheResponse.

@prabhask5 Closing this PR since there hasn't been activity since 1 month. Please feel free to open a new PR if you intend to continue working on this.


Inconsistency between Enumerable#zip and Iterator#zip

It seems that Enumerable#zip raises IndexError when any of the other enumerables/iterators don't have elements. For example:
[1, 2].zip([1]) # IndexError, because there's no matching element for 2

But Iterator#zip will just stop whenever any of the iterators don't have any elements.
There's also Enumerable#zip? which yields nil instead of raising.
BUT, there doesn't seem to have a way to get Enumerable#zip to work like Iterator#zip. That is, have a way to get this:
[1, 2, 3].zip([4, 5]) #=> [{1, 4}, {2, 5}]

This is especially important to have if the first enumerable if an infinite stream:
Iterator.of(1).zip([4, 5]) # Ideally we would get [{1, 4}, {1, 5}]

I'm thinking we could add a named argument to the zip overloads to control this behavior.
What do you think?

I ran into this too while cleaning up my solution. I ended up doing
(short_y ? xs.zip(ys.cycle) : xs.cycle.zip(ys)).count {..}

which was a bit bulky. I could also see something like
xs.zip(ys, cycle_shortest: true).count {..}

to make it cycle whichever is shortest. If either is infinite the the resulting iterator would also be infinite I guess.

Maqybe zip and zip? could be an option? It's prob not as expressive as a named arg. But I also don't see that an argument cycle_shortest: true would be very self-explanatory.

For reference, Python has:

zip - cuts at the shortest iterable -- like Iterator#zip
zip_longest - cuts at the longest iterable, other items are filled as default=None -- like Enumerable#zip?
does not have any such method that raises

@straight-shoota note that zip?  already exists but it's not useful for infinite streams.
Maybe deciding to raise was a mistake... I wonder if changing that would be a breaking change. After all, you really don't want to have code that raises.

Enumerable#zip can nevr cycle self if it is the shortest.

I think the name cycle isn't good here. I think it was meant to be zip, like zip_shortest and so on. There's never cycling involved in zip.


SPIKE: Spot updated version and download it

As a user I want to be able to update the software,
When there is a new update that matches the network I am connected to,
And this without having to browse the GitHub release page.
Hopefully, it will replace my current version, and relaunch the app when ready.
Notes

The update version shouldn't be resolved by looking at the release, but by looking at the network version. So when the network update to a new version, the wallet software should search for the version that matches the network, and return the version to download.
There are different type of updates: regular improvements, and critical updates. This system should be able to figure out the criticality of the update and return it with the version
It should return all the user-friendly changelogs between the current version and the new one

Technical implications

Only replace the current app if the zip has a .app.
Figure out from where the software is running to replace it. We can't assume it's running form a standard folder.

References

https://github.com/sanbornm/go-selfupdate
https://github.com/minio/selfupdate

Autoself updating the binaries
I think this is a solved problem. There is a discussion about this on the Wails repo and support for it is in their roadmap, but its not deemed important because its possible to it without any changes to wails: https://github.com/wailsapp/wails/issues/1178#issuecomment-1368282024
Riftshare, which is mentioned as an example, is a wails based application that is open source and has a self-update mechanism:
https://github.com/achhabra2/riftshare
It uses this go-package which wraps up checking for releases on GitHub, downloading them replaces the running binary:
https://github.com/minio/selfupdate
The interesting bit in riftshare is here:
https://github.com/achhabra2/riftshare/blob/main/internal/update/selfupdate.go
The selfupdate package doesn’t work for macOS application but luckily riftshare has a workaround for that already: https://github.com/achhabra2/riftshare/blob/main/internal/update/selfupdate.go#L34
So we can leverage a lot of this. The main difference for us will be the CheckUpdate method because we will want to do more than just check for github releases.
Automatically restarting the application
Unfortunately riftshare gives us nothing on this and they just have a prompt that says "you can restart us now".
Digging around I found a package called “goagain” which seems sufficiently fancy, maybe even too fancy. It allows for a parent app to start a child application, where the child application can then kill the parent when it’s ready. The idea is that is allows for 0 downtime.
Do we need all of that? Probably not, as we only need to be able to start the desktop-wallet anew and instantly kill ourselves but we can still learn from the package and can take what we need from this function: https://github.com/rcrowley/goagain/blob/master/goagain.go#L77
The problem here is, again, it doesn't work for mac applications and only for launching binaries. Results from more googling into how to do it for Mac were sparse, and then were in relation to swift or apple-script and then still inconclusive.


Add logic to capture message within default setup

Forgive me if the default setup was deliberately being set to a noop, but I thought it would be convenient if instead it captured the error message.

:+1:
I'm not used errors without setup functions, so noop function was making sense for me.


Add partOf/part relationships between existing Works coming from Sierra

Some relationships in Sierra, encoded by 773/774, link between Works.
Example:
This portrait of Basil Hood https://wellcomecollection.org/works/teupafzu is part of this Basil Hood Photo Album:
https://wellcomecollection.org/works/tw5yfsfv
This is encoded in the album (along with all the other photos) as a set of 774s: https://search.wellcomelibrary.org/iii/encore/record/C__Rb1172977?lang=eng&suite=cobalt&marcData=Y
and in the photo itself as a 773: https://search.wellcomelibrary.org/iii/encore/record/C__Rb1186777?lang=eng&suite=cobalt&marcData=Y
However, this is not present in the API responses for either the album or the picture:

https://api.wellcomecollection.org/catalogue/v2/works/tw5yfsfv?include=items%2CpartOf%2Cparts
https://api.wellcomecollection.org/catalogue/v2/works/teupafzu?include=items%2CpartOf%2Cparts

See https://github.com/wellcomecollection/docs/blob/sierra-series/rfcs/044-sierra-series/README.md
Specifically:

https://github.com/wellcomecollection/docs/blob/ceb49eab7173ad09c31890aee30d3c201801b0eb/rfcs/044-sierra-series/README.md?plain=1#L96-L121
https://github.com/wellcomecollection/docs/blob/ceb49eab7173ad09c31890aee30d3c201801b0eb/rfcs/044-sierra-series/README.md?plain=1#L438

Part of https://github.com/wellcomecollection/platform/issues/5408

IIUIC, this represents the quickest win in the Library Linking space, as I would essentially expect it to behave in the same manner as Collections like this one: https://wellcomecollection.org/works/r4ap6hha

Actually, this has raised a few questions about the proposal, WRT changes to the API.


add vishnur's hackbar

I add a file in hackbar

how to add bro?? Jam new to github..could u please guide me??
Thank you
On Sun 11 Oct, 2020, 5:23 PM Tasnim Zotder<EMAIL_ADDRESS>wrote:

@tasnimzotder commented on this pull request.
In _hackbars/vishnur.md
https://github.com/tasnimzotder/hacktoberfest-2020/pull/127#discussion_r502905457
:

+layout : hackbar
+title  : hacktoberfest
+autor  : vishnur
+---

+open source is the best source to show one's talent.
+
+
+---
+
+## Leave some greenery for the future to enjoy the Scenery..
+
+---
+
+
hey @Vishnurr2k01 https://github.com/Vishnurr2k01 Welcome to
Hacktoberfest-2020
Can you please add the missing image vishnur.jpg?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tasnimzotder/hacktoberfest-2020/pull/127#pullrequestreview-506171994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARIF7TOGTL52WR5KLIGJBILSKGMB7ANCNFSM4SLUIPZA
.

Sure. You can follow the steps to add an image -

Take an image (climate-change themed) and rename it vishnur.jpg
On your local machine go to the repository directory (folder) hacktoberfest-2020
Copy the image vishnur.jpg to the directory /assets/images/
Make a commit
That's it 🎉

thank you
.I will update it as soon as possible
On Sun 11 Oct, 2020, 5:47 PM Tasnim Zotder<EMAIL_ADDRESS>wrote:

Sure. You can follow the steps to add an image -

Take an image (climate-change themed) and rename it vishnur.jpg
On your local machine go to the repository directory (folder)
hacktoberfest-2020
Copy the image vishnur.jpg to the directory /assets/images/
Make a commit
That's it 🎉

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tasnimzotder/hacktoberfest-2020/pull/127#issuecomment-706696282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARIF7TOYXYV5IO6NSYZEAXDSKGO5FANCNFSM4SLUIPZA
.

its showing upload disabled..

@Vishnurr2k01 It is uploaded

@Vishnurr2k01, Thanks for your contributions :)

thank you : )
On Sun, 11 Oct 2020 at 18:09, Tasnim Zotder<EMAIL_ADDRESS>wrote:

@Vishnurr2k01 https://github.com/Vishnurr2k01, Thanks for your
contributions :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tasnimzotder/hacktoberfest-2020/pull/127#issuecomment-706698937,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARIF7TPS7B3FRLQU5AZHLR3SKGRQRANCNFSM4SLUIPZA
.


docs: Add Retry Guide

Fixes: https://github.com/googleapis/google-cloud-java/issues/10586
Add a section to the README.md to include basic information about how Google Cloud Java Client Libraries deal with retries.

@burkedavison @suztomo @blakeli0 @alicejli Could I get a re-review on this whenever you all get time? Plan is to add details for retries, LRO, endpoint, client initialization, etc. so that we can reference this on future customer issues.


Adding another section similar to Blog section

I was wondering how to create another section similar to the "blog" section. For instance, I was thinking of creating a "blog" section and "daily thoughts" section.
The step I took so far:
1). in navigation.yml,
I added

title: "Daily thoughts"
url: /daily-thoughts/

2). made a folder called "_daily-thoughts"
3). Made my markdown post "daily-thought_1.md" and save that file in "_daily-thoughts"
4). added daily-thought.html in _pages

layout: archive
permalink: /daily-thoughts/
title: "Daily Thoughts"
author_profile: true

{% include base_path %}
{% capture written_year %}'None'{% endcapture %}
{% for post in site.daily-thoughts %}
{% capture year %}{{ post.date | date: '%Y' }}{% endcapture %}
{% if year != written_year %}
{{ year }}
{% capture written_year %}{{ year }}{% endcapture %}
{% endif %}
{% include archive-single.html %}
{% endfor %}
It seems that I am to get the section created with the title. But my content "daily-thought_1.md"  saved in "_daily-thoughts", is not displayed at all. What am I doing wrong? Any guidance would be greatly appreciated.

did you all add your daily thoughts as a collection in the config? e.g.
collections:
  daily-thoughts:
    output: true
    permalink: /:collection/:name/


Enabled chunked transfers in LFS

Feature Description
LFS in Gitea currently doesn't use chunked transfers, which causes the whole body to be read before it is stored. This means 100+ MB uploads will be blocked by Cloudflare.
It looks like the LFS client looks for the Transfer-Encoding: chunked header from the server in https://github.com/git-lfs/git-lfs/blob/4140f638e9e305605f2e8cd941355340bb71fbf0/tq/basic_upload.go#L58-59 even though HTTP/1.1 says this isn't required.
Screenshots
No response

Is there some way to bypass this "error" or it only can be done by removing cloudflare as a proxy?

Please!


No such module 'Alamofire'

I have xcode 8.2.1 with swift 3. I didn't use cocoapods but i simply put the alamofire folder into my project. Xcode can't find the Alamofire files

stackoverflow answer helped me here. I don't need to put "import Alamofire". http://stackoverflow.com/questions/31706589/how-to-add-alamofire-to-xcode-project-swift


set environment variable based on script evaluation

Problem Description
I need to set environment variable based on result of the script.  This variable will be feed to another task.   This is blocker for me to use this tool.  Something like this will be good way to configure env variable.
Code Example
[env]
name = "count"
description = "count of file"
script = "wc file.txt"

[task.echo]
script = ["echo ${count}]

Error Stack/Info (if any)

Nice feature.

This is show stopper.   I have to go back to Makefile or alternative solutions without this feature.

alrealy assigned it to me. I'll handle it

pushed this to the 0.5.3 branch. once I finish the other 2 items i'll publish a new release.

Nice work.   Thanks!

new 0.5.3 version released


Collection Docs: Missing note about parse option

On the Model docs, there is this note:

If {parse: true} is passed as an option, the attributes will first be converted by parse before being set on the model.

This appears to be true on Collections as well, but is not documented.

I create PR #4174
Is it correct?


send message like roomId in the connectionLostTimerTask

Hi,
Now Java-WebSocket just uses conn.sendPing() in the connectionLostTimerTask. I need to send message like roomId in the connectionLostTimerTask when it is timeout. Could you please tell me how can I do it?
Thanks!
protected void startConnectionLostTimer() {
    if (this.connectionLostTimeout <= 0) {
        if (WebSocketImpl.DEBUG)
            System.out.println("Connection lost timer deactivated");
        return;
    }
    if (WebSocketImpl.DEBUG)
        System.out.println("Connection lost timer started");
    cancelConnectionLostTimer();
    connectionLostTimer = new Timer();
    connectionLostTimerTask = new TimerTask() {
        @Override
        public void run() {
            Collection<WebSocket> con = connections();
            synchronized ( con ) {
                long current = (System.currentTimeMillis()-(connectionLostTimeout * 1500));
                for( WebSocket conn : con ) {
                    if (conn instanceof WebSocketImpl) {
                        if( ((WebSocketImpl)conn).getLastPong() < current ) {
                            if (WebSocketImpl.DEBUG)
                                System.out.println("Closing connection due to no pong received: " + conn.toString());
                            conn.close( CloseFrame.ABNORMAL_CLOSE );
                        } else {
                            **conn.sendPing();**
                        }
                    }
                }
            }
        }
    };
    connectionLostTimer.scheduleAtFixedRate( connectionLostTimerTask,connectionLostTimeout * 1000, connectionLostTimeout * 1000 );
}

Hello @hattie0312,
sendPing() does not support custom payloads write now.
So you have to implement the connectionLostTimerTask on your own.
Keep in mind that the specification does not specify what payload is allowed to be send in a ping.
If you are using a different implementation it could be the current time in milliseconds or stuff like that!
Apart from this, the other endpoint should now in which room this endpoint is and should not require a ping for this.
Greetings
marci4

Hello @marci4 ,
Thanks and I implemented the connectionLostTimerTask on my own.
Our server-side developer asked us to send a message every 5 seconds to keep the connection. If it is not received, they will close the connection from the server-side. But I think to send message such frequently is a waste of flow.
Any Suggestions please？
Greetings
Hattie

Hello @hattie0312,
if that is the requirement, then you cannot do anything against it.
I am just sure that it will create a lot of load. You may wanna estimate how many ping/pong frames are send from and to the server with your planned user base.
Maybe this would change the requirement...
Greetings
marci4

Closing issue since it is solved!
Greetings
marci4


feat: add config cmd, including subcmds get,list,set,unset

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

230 of 242 (95.04%)  changed or added relevant lines in 9 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.7%) to 61.403%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cmd/config/cmd.go
21
23
91.3%

pkg/cmd/config/get/options.go
20
22
90.91%

pkg/cmd/config/set/options.go
23
25
92.0%

pkg/cmd/config/unset/options.go
19
21
90.48%

pkg/cmd/config/list/cmd.go
35
39
89.74%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/parser/parser.go
3
79.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.7%

Covered Lines:
7614

Relevant Lines:
12400

💛  - Coveralls


Commas in cookie value not parsed correctly on Android

Description
tl;dr Commas are treated as cookie deliminators on Android only
Commas (,) in cookie values are not allowed as part of the cookie specification but they're still allowed on all major browsers and through iOS's networking APIs. However in Android okhttp (specifically okhttp3.JavaNetCookieJar) commas are treated as cookie delimiters in the same way that semicolons are. This behaviour isn't mentioned anywhere and is inconsistent with iOS/Web.
I have found an existing issue on okhttp which suggests the regular CookieJar doesn't have this limitation and should be used instead of JavaNetCookieJar. I can also confirm that removing the comma here fixes the issue. React Native sets the okhttp cookie jar to JavaNetCookieJar here.
I'm working with an external service which I can't control so changing the cookie isn't an option. Because {redirect: "manual"} doesn't work in React Native iOS/Android, it's impossible to override this behaviour if the cookie is set in a 302 response and required for subsequent responses.
React Native version:
System:
    OS: Linux 5.3 Linux Mint 19.1 (Tessa)
    CPU: (4) x64 Intel(R) Core(TM) m3-6Y30 CPU @ 0.90GHz
    Memory: 1.50 GB / 7.67 GB
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 10.15.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.4.1 - /usr/local/bin/npm
    Watchman: Not Found
  SDKs:
    Android SDK:
      Android NDK: 17.2.4988734
  IDEs:
    Android Studio: Not Found
  Languages:
    Java: 11.0.3 - /usr/bin/javac
    Python: 2.7.17 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ~16.11.0 => 16.11.0
    react-native: github:facebook/react-native#0.63-stable => 0.63.2
  npmGlobalPackages:

Steps To Reproduce and expected results
If a fetch request is made to a server which responds with the following header:
Set-Cookie: TestCookie=a:hello,b:goodbye

On every platform apart from Android, the following Cookie header is sent in future requests:
Cookie: TestCookie=a:hello,b:goodbye;

but on Android the cookie is parsed incorrectly and the following header is sent (2 cookies):
Cookie: TestCookie=a:hello;b:goodbye=;

Snack, code example, screenshot, or link to a repository:
To easily reproduce this, run this express project https://gist.github.com/uen/f8bbded0fc10fd2d3910d388cd3fea6e and load snack https://snack.expo.io/8y09x_Bc7 on a real Android and iOS device (and web). The Android cookie will not be correct as described above

Are there any plans to change this / would a PR changing the cookie jar be accepted?

Anyone having this issue, I forked react-native with a fix here: https://github.com/uen/react-native-34/commit/4a054da2169c4f085b6165648a1290b3ea8b3751 - It should be pretty much the same in every other version of RN too.
The fork simply copies the okhttp JavaNetCookieJar class and fixes the issue, and then makes React Native use it. Ideally JavaNetCookieJar needs to be changed to use CookieJar from okhttp, but this may have unintended side effects & probably needs tests updating etc.
I will eventually create a module that replaces the Networking module here: https://github.com/uen/react-native-cookie-fetch so it's more 'drop-in' and won't require a custom RN version.
If you use Expo managed workflow there is no way around this issue and I doubt it will be fixed since there's over 1k issues open in this repo currently
@whyer

Sorry, here it is @uen
https://github.com/kolplattformen/skolplattformen/tree/main/packages/app/android/app/src/main/java/org/skolplattformen/app

Still having issues, hard to debug unfortunately!

It is still an issue

It's still an issue
On Thu, 11 Jan 2024, 05:13 github-actions[bot], @.***>
wrote:

This issue is stale because it has been open 180 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/29916#issuecomment-1886256324,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6E224BEWBOUZBN3S5TB63YN5YIFAVCNFSM4RDNAMF2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBYGYZDKNRTGI2A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Mixin occlusion-collection to scrollable component

I'd like to use the occlusion-collection mixin on the component that has the scroll overflow, so I'd need to change the container logic to something like:
https://github.com/runspired/smoke-and-mirrors/blob/develop/addon/mixins/occlusion-collection.js#L632
if (containerSelector === 'body') {
  container = window;
} else {
  let $container;
  if (containerSelector === 'self') {
    $container = this.$();
  } else {
    ...

Does this sound ok as a PR?

Ignore me... I seem to have forgotten how jQuery.closest works
"Description: For each element in the set, get the first element that matches the selector by testing the element itself and traversing up through its ancestors in the DOM tree."
http://api.jquery.com/closest/


Descheduler goes into a loop with Remove duplicates strategy

I try to create a pod using an rc with replicas as 12 and i run descheduler.  I don't think there's anything in the duplicate pods strategy that considers the replica request vs number of available nodes and this causes a deschedling loop. descheduler tries to evict the pods every time the descheduler is run.

/kind bug

This is a duplicate of #263.
/triage duplicate
/close


Add Buf and BufMut auto-impl for pinned data types

Fixes #654.
Adds default implementations for Buf and BufMut on Pin<T> where T is a type that implements Buf/BufMut and Unpin.
See the Rust docs (link) for more information on pinned types.

Closing as a breaking change. See https://github.com/tokio-rs/bytes/issues/654.


python310Packages.fs: propagate setuptools

fixes pkgsCross.aarch64-multiplatform.python310Packages.statmake

ERROR: Could not find a version that satisfies the requirement setuptools (from fs) (from versions: none)
ERROR: No matching distribution found for setuptools

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

(nixpkgs-review revealed no new failures, macos 10.15 & nixos x86_64)


Producer description: -> prefixGroup: true

The consumer has the property       prefixGroup: true.
Is the same also useful for the Producer? Or what is the reason for not having this property in the Producer?

The setting controls whether a prefixed ACL will be created for the READ access on the consumer group. I think this is useful when a team wants to be able to read a copy multiple times, especially during development, without having to reset offsets, e.g. with the consumer-groups tool.
Since producers don't keep state in Kafka, no setting is necessary for them.


Add component evaluation for inactive sections

Now filename component updates on inactive_status .
closes #157

Note: this relies on a week old nightly https://github.com/neovim/neovim/pull/14558
So this can probably be delayed for adoption.
@hoob3rt you can directly push the changes you need to my branch and merge these prs If you like the feature.

Merged in https://github.com/shadmansaleh/lualine.nvim

Part of #311


The new signature comments popup everywhere, over existing members or comments

I really like the 15.8 addition of the signature comments (not sure if that's the name for it), but they often obscure existing code, or comments and make both unreadable. Or they just appear where there isn't any signature or let binding at all.
Not sure this is a VS feature or an F# feature or both, I'll be happy to post the bug to the VS team instead.
In non-compiled (#if false) code, in places where there is no signature at all:

Over the signature itself:

There are no signatures at all here:

Repro steps
Seems to happen basically always when a file is significantly large or when you do some edits back and forth.
Expected behavior
The comments should not obscure existing text and should appear next to the members or let bindings.
Actual behavior
They popup everywhere.
Known workarounds
Switching it off (though I haven't found the setting yet, if it is in Editor > F# > Advanced, then it is currently inaccessible as that crashes VS).
Related information
Seen in Visual Studio 15.8.0 Preview 2

Hey Sorry for any problems with the line lens.
I've already opened a PR which should at least solve caching problems. It doesn't fix all problems yet and I plan to investigate what happens that the line lens aren't invalidated correctly.

You can reproduce this problem by fast jumping around in the code. The code lens should actually disappear  (be set to invisible).

Hey Sorry for any problems with the line lens.

@realvictorprm  No problem, I'm using the Preview, so things are bound to happen ;).
So this is called the Line Lens? Is there a way I can refresh it or disable it for certain (complex) files? It is very helpful, I really like it, but not so much when it covers existing code or comments...

To my knowledge with the next preview it's possible again to disable them.
Refreshing them should easily work through closing and reopening the file.

Yes, in the forthcoming preview 3 of 15.8, they are toggle-able.

jesus christ I found the bug. A single field access is wrong 🤣. I'm so sorry fellow F# coders.
@cartermp bugfix incoming.

@abelbraaksma this is now fixed too with #5145

@realvictorprm, I can confirm that in VS 2017 15.8 P3 this mostly works now, I can scroll wildly and it remains mostly stable. However, when the option "appear above signature" is on, the refreshing goes wrong sometimes:

Tempo of scrolling doesn't seem to matter. The way it happens for me is when you scroll quickly to a "crowded" place and then halt, that the signature-comments overlap.
Though after it happens, scrolling back and forth a bit restores it again, so the impact of this redraw issue is minor in comparison.

Closing old issue


Release v1.5.0

This is an automated PR to prep Data Science Pipelines Operator for release.

odh_org: opendatahub-io
release_branch: v1.5.x
target_version_tag: v1.5.0
previous_release_tag: v1.4.0

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-390
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/390/head
git checkout -b pullrequest d76b3a39045b1ba246bc5827dcd946d26a4e6eb0
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-390"

More instructions here on how to deploy and test a Data Science Pipelines Application.

/lgtm
/approve

Release created successfully:
https://github.com/opendatahub-io/data-science-pipelines-operator/releases/tag/v1.5.0
https://github.com/opendatahub-io/data-science-pipelines/releases/tag/v1.5.0


Updated ACL build config to work with the latest public version of ACL.

I'm closing this PR since the latest version of ACL has some issues. I will open an alternative PR to lock ACL to the known-working version.


Load runtime and native libraries in dotnet-ef

Customizes the creation of ProjectLoadContext to include native and runtime libraries.
Fix https://github.com/aspnet/EntityFramework/issues/3925
Work-around https://github.com/dotnet/cli/issues/2289
~~:watch: wait for fixes in CLI regarding #4953 ~~
Added some end-to-end testing for dotnet-ef using sqlite.

cc @anurse

:watch: pending changes to DependencyContext, we may be able to remove the hard-coded RID graph here.

FYI: https://github.com/dotnet/cli/pull/2379

Just added a fix for loading sni.dll at design time. With this change, dotnet-ef now completely reimplements everything from  "Microsoft.DotNet.ProjectModel.Loader"... but with bug fixes.

ping @anurse for code review. I've updated to use DependencyContext now that we've taken the fix from https://github.com/dotnet/cli/pull/2379. This resolves the remaining issues on #3925 but still implements its own assemblyload context.

Looks good to me. Btw, post-RC2 we'll probably just take your load context into the CLI, it looks much richer that our current one :)

we'll probably just take your load context into the CLI

Sounds good. For now this workaround seems fine to have in dotnet-ef. When you move changes into cli, you ping me on the change?

Looks good to me.

@anurse so is that a :shipit:?

Yeah, I didn't know for sure if you wanted anyone from EF to sign off, but I'm :shipit:

:shipit:


Add CSR/CSC product subroutine

Requiring conversion before the product can be really slow. This requires setting up some benchmarks to measure the concrete effect.

I'm interested in working on this! In particular it seems CSC * CSR is actually broken at the moment, and this seems like a good place to fix that issue, as well as improve performance. Will you accept a PR?

PRs are accpepted. Would be nice to start with some basic benchmarks to see how we compare against scipy and the likes.

Beware though, this issue is quite old, and since then matrix products has seen several changes, mostly the SMMP implementation #187 so I think the first thing to do would be to enhance the existing product benchmarks to see precisely the impact of storage conversion.
You mentionned CSC*CSR being broken, do you have an example?

I don't have a functional code example handy, but if you take two CsVec, call them a and b, and you do a.col_view() * b.row_view() you get a panic, instead of a len(b) x len(a) matrix


Angular Lazy loaded modules not working

I have converted my angular (v4) webpack (v3) over to use HappyPack and the build time has gotten MUCH faster so thank you for that.
However, I have gotten things to build and the initial module loads up just fine but there are no lazy loaded module chunks downloaded and when I click on a link that uses a lazy loaded module I get an error about the module could not be found. Here is some of my code. Any ideas on how I set this up for lazy loaded modules?
I use to use raw-loader for the index.html file but HappyPack does not support that so I tried file loader which works at least for the root module but maybe that is causing this issue?
 const HappyPack = require('happypack');
 const happyThreadPool = HappyPack.ThreadPool({ size: 3 });

...

 new HappyPack({
    id: 'ts',
    threadPool: happyThreadPool,
    loaders: [
      {
        loader: 'ts-loader',
        query: { happyPackMode: true }
      },
      {
        loader: 'angular2-template-loader',
        query: { keepUrl: true }
      },
    ]
  }),

  new HappyPack({
    id: 'json',
    threadPool: happyThreadPool,
    loaders: [ 'json-loader' ]
  }),

  new HappyPack({
    id: 'styles-string',
    threadPool: happyThreadPool,
    loaders: [ 'to-string-loader', 'css-loader' ]
  }),

  new HappyPack({
    id: 'styles',
    threadPool: happyThreadPool,
    loaders: [ 'to-string-loader', 'css-loader', 'postcss-loader', 'sass-loader' ]
  }),

  new HappyPack({
    id: 'file',
    threadPool: happyThreadPool,
    loaders: [ 'file-loader' ]
  }),

...

new CommonsChunkPlugin({
    name: 'polyfills',
    chunks: ['polyfills']
  }),
  // This enables tree shaking of the vendor modules
  new CommonsChunkPlugin({
    name: 'vendor',
    chunks: ['main'],
    minChunks: module => /node_modules\//.test(module.resource)
  }),
  // Specify the correct order the scripts will be injected in
  new CommonsChunkPlugin({
    name: ['polyfills', 'vendor'].reverse()
  }),

Does your problem got resolved already? @GenZodd
I have to improve my angular build as well because the slowness of the source codes recompilation on development mode, maybe you can help by providing your changes on @angular/cli webpack configuration, thank you

Technically, enabling happypack shouldn't affect the generation of chunks, but maybe it's not working as you expect and then the chunks aren't generated in the first place? It's hard to tell without looking at logs.
Can you provide the output of webpack both while using happypack and while not? Run it with --display-chunks so that we can see the generated chunks and their hashes.


Filter away NDK warning

Whenever gradle fails for any reason, the logs are "polluted" by this additional warning:
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to /home/melkir/Android/Sdk/ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

We don't actually depend on NDK, so would be good if this wasn't always printed.

The only way I have been able to reproduce the problem is by deliberately misconfiguring the gradle build in the way outlined in the above-referenced bugs.  Then, I can get the error message to appear unconditionally when running gradle by hand (resulting in it propagating up through flutter run failures).
Without the bogus setting:
~/dart/flutter_untitled/android
$ cat local.properties
sdk.dir=/usr/local/google/home/jcollins/Android/Sdk
flutter.sdk=/usr/local/google/home/jcollins/dart/flutter
flutter.buildMode=debug
~/dart/flutter_untitled/android
$ ./gradlew assembleDebug

BUILD SUCCESSFUL in 0s
30 actionable tasks: 4 executed, 26 up-to-date
~/dart/flutter_untitled/android
$

With it:
~/dart/flutter_untitled/android
$ cat local.properties
ndk.dir=/tmp/garbage
sdk.dir=/usr/local/google/home/jcollins/Android/Sdk
flutter.sdk=/usr/local/google/home/jcollins/dart/flutter
flutter.buildMode=debug
~/dart/flutter_untitled/android
$ ./gradlew assembleDebug

> Configure project :app
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to /tmp/garbage.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

BUILD SUCCESSFUL in 0s
30 actionable tasks: 4 executed, 26 up-to-date
~/dart/flutter_untitled/android
$

I can filter it, but it is indicating something wrong with their configuration.  Even if it might be unimportant to us, they might be using it for a custom plugin or for native profiling.

Dug in a bit more, and flutter doctor does check for NDK.   So filtering the message seems reasonable to me since there's another way to discover that something might be wrong with that.  PR to come.

I don't think this bug actually exists anymore.  With -q to gradlew, the message disappears, and we always pass that in outside of verbose mode:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle.dart#L282
This does not preclude the possibility that a version of gradle exists somewhere that will print the message even when -q is passed, which seems likely since we've been passing that -q to gradle for a year and the original bug was filed more recently than that.

I'd like to close this issue as WAI:

The only time this warning shows up at all is when the user's installation is corrupt in a specific way.
Even when such a condition is manually created, recent versions of Gradle do not seem to display this warning, even on build failures, when -q is passed.  And we always pass '-q' outside of verbose mode, where presumably you really do want all the output from the underlying tools.
flutter create doesn't create this situation:

the version of gradle it configures behaves like we want and hides this when -q is issued
flutter create does not set environment variables or manually modify build.gradle to create the issue

So IMO there's good reason to believe that right now, the user will never see this message.  That is, unless they run with '-v', and there's a real (if possibly irrelevant) problem.

Would it make sense to detect the warning and add our own more helpful comment explaining what might be wrong?

I usually avoid such things as they tend to introduce more complication and possibly user confusion as to the source of the message -- but that's the other option.   Between the two I'm for closing the issue as I can't seem to find a condition that actually creates this problem anymore, so the potential benefit seems small.

SGTM

@mravn-google WDYT?

I run into this error 2 days ago but after some tinkering it started working again.
I think it was during upgrading to the new Gradle plugin (don't remember exactly because I had to cope with a bunch of issues that day)

@zoechi: Do you remember if this was visible without passing -v to flutter run?  I'm trying to determine if there are still scenarios where this error can be displayed unconditionally.  (The original issue was filed some 11 months ago, and much has changed).
If you happen to remember the version of gradle you upgraded from, that would be helpful too.

@jcollins-g without -v (I got it for flutter run and when I run it from IntelliJ.
I'm not entirely sure about the Gradle versions gradle-wrapper.properties file was gitignored, therefore can not check the old value as well, but I think it was plugin 3.0.1 as mentioned in https://github.com/flutter/flutter/wiki/Updating-Flutter-projects-to-Gradle-4.1-and-Android-Studio-Gradle-plugin-3.0.1
I'm pretty sure that Gradle itself was 4.5 before and after I got the error.

@zoechi Thanks, that's extremely helpful -- I've been investigating this largely blind to the versions of things where folks are experiencing the problem.  Will investigate.

this one was very helpful: https://github.com/flutter/flutter/wiki/Updating-Flutter-projects-to-Gradle-4.1-and-Android-Studio-Gradle-plugin-3.0.1

One question:  does the error message still appear after the upgrade?  Working on reproducing this today.

Tried creating an old-style flutter project and upgrading it myself, still no dice.  I can not see the message from flutter run without using -v, and the Gradle wrapper in both versions consistently hides the message when passed -q.
I'll  try assuming that I'm just missing some key element of a reproduction step and implement code to try to hide the error message blindly, but I again don't believe it is possible to see this directly from the flutter tool as described without some kind of funny business going on behind the scenes -- funny business that might make whatever fix I implement in the tool be ineffective at actually solving this.

Sorry to disturb for you, I have use the latest flutter version (Channel stable, v1.0.0, on Linux, locale en_US.UTF-8), but when I run flutter run for flutter example, it will reproduce same error message.
Could you kindly help to check it, thanks a lot.
      ProcessException: Process

"/home/fuchsia/opensource/flutter/flutter-examples/tip_calculator/android/gradlew"
exited abnormally:
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to
/home/fuchsia/Android/Sdk/ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove
this
warning.
       BUILD FAILED

       Total time: 0.715 secs

@dongjinguang-china probably better to create a new issue with a link to this one and the output of flutter doctor -v

ok no problem, thanks for zoechi:）


Crash when non-current WinBar click closes window

Describe the bug
Vim crashes (sometimes) with SEGV when clicking a WinBar in a non-current window and the menu command closes the current window.
To Reproduce

Run vim -Nu NONE
:nnoremenu WinBar.Test :close!<CR>
:new
:set mouse=a
:set ttymouse=sgr
Click the Test WinBar menu

Expected behavior
Well, I admit that the correct behaviour of such a menu is not obvious (which window should be closed?), but certainly, crashing (and actually spinning at 100% CPU until killed on macOS) is not expected.
I suspect the correct (intuitive behaviour) is to close the window in which the WinBar exists. Or at least just close the window that's current, though we should probably update :help WinBar to state that commands are executed without changing the current window (though looking at the code, I don't think this is true).
Environment (please complete the following information):
BenMBP:vim ben$ ./src/vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled May  4 2019 10:55:52)
macOS version
Included patches: 1-1259
Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl               +extra_search      +mouse_netterm     -tag_old_static
+arabic            -farsi             +mouse_sgr         -tag_any_white
+autocmd           +file_in_path      -mouse_sysmouse    +tcl
+autochdir         +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    -gettext           +netbeans_intg     +textprop
+byte_offset       -hangul_input      +num64             +timers
+channel           +iconv             +packages          +title
+cindent           +insert_expand     +path_extra        -toolbar
-clientserver      +job               -perl              +user_commands
+clipboard         +jumplist          +persistent_undo   +vartabs
+cmdline_compl     +keymap            +postscript        +vertsplit
+cmdline_hist      +lambda            +printer           +virtualedit
+cmdline_info      +langmap           +profile           +visual
+comments          +libcall           -python            +visualextra
+conceal           +linebreak         +python3           +viminfo
+cryptv            +lispindent        +quickfix          +vreplace
+cscope            +listcmds          +reltime           +wildignore
+cursorbind        +localmap          +rightleft         +wildmenu
+cursorshape       -lua               +ruby/dyn          +windows
+dialog_con        +menu              +scrollbind        +writebackup
+diff              +mksession         +signs             -X11
+digraphs          +modify_fname      +smartindent       -xfontset
-dnd               +mouse             +startuptime       -xim
-ebcdic            -mouseshape        +statusline        -xpm
+emacs_tags        +mouse_dec         -sun_workshop      -xsmp
+eval              -mouse_gpm         +syntax            -xterm_clipboard
+ex_extra          -mouse_jsbterm     +tag_binary        -xterm_save
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/Users/ben/Development/vim-env/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L.  -L/usr/local/lib -o vim        -lm -lncurses  -liconv -framework AppKit     -L/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/config-3.7m-darwin -lpython3.7m -framework CoreFoundation -F/System/Library/Frameworks -framework Tcl -framework CoreFoundation

macOS 10.14.4
iTerm2
Additional context
I am working on a test to repro this and will look at a fix if I can.
NOTE: Seems to be inconsistent, indicating a race. I reliably repro'd this like 5 times in a row to write this report, but since then it doesn't reliably repro.
Importantly, I see frequent crashes in vimspector caused by curbuf being invalid. This is usually triggered by a WinBar command which does :tabclose!. I tracked it down to winbar_click() where wp's w_buffer is set to some invalid address.

OK I can repro with the following test (which borrows a function from test_termcodes.vim):
function _Click( arg )
  let s:did_click_winbar = a:arg
  close!
endfunction

function! Test_Winbar_Click_Not_Current()
  set mouse=a
  for ttymouse_val in g:ttymouse_values + g:ttymouse_dec + g:ttymouse_netterm
    " Add a winbar to that window (containing "This is ..." buffer)
    nnoremenu WinBar.Click :call _Click( 'click0' )<CR>
    redraw

    call assert_match( 'Click', Screenline( 1 ) )

    " check where it is
    " Switch a new buffer
    botright new

    let msg = ttymouse_val
    exe 'set ttymouse=' .. ttymouse_val

    " Click the button, which wipes out the tabpage?
    " Use any available ttymouse value
    let row = 1
    let col = 3

    let s:did_click_winbar = ''
    call MouseLeftClick(row, col)
    call assert_equal( 'click0', s:did_click_winbar, Screenline( 1 ) )
  endfor

  %bwipeout!

  set mouse&
  set ttymouse&
endfunc

Leading to NULL curbuf:

running the test with asan:
|| ==41516==ERROR: AddressSanitizer: heap-use-after-free on address 0x6250000052d8 at pc 0x00010e2dadb8 bp 0x7ffee1c9cc10 sp 0x7ffee1c9cc08
|| READ of size 8 at 0x6250000052d8 thread T0
||     #0 0x10e2dadb7 in winbar_click menu.c:2485
||     #1 0x10e73fd3c in jump_to_mouse ui.c:2938
||     #2 0x10e37258b in do_mouse normal.c:2750
||     #3 0x10e3ad2a3 in nv_mouse normal.c:4591
||     #4 0x10e35a8fa in normal_cmd normal.c:1106
||     #5 0x10e13ee41 in exec_normal ex_docmd.c:8934
||     #6 0x10e058798 in f_feedkeys evalfunc.c:3795
||     #7 0x10e04554c in call_internal_func evalfunc.c:1142
||     #8 0x10e773f9c in call_func userfunc.c:1553
||     #9 0x10e772681 in get_func_tv userfunc.c:453
||     #10 0x10e7896cc in ex_call userfunc.c:3217
||     #11 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #12 0x10e109122 in do_cmdline ex_docmd.c:988
||     #13 0x10e777961 in call_user_func userfunc.c:1000
||     #14 0x10e773dee in call_func userfunc.c:1534
||     #15 0x10e772681 in get_func_tv userfunc.c:453
||     #16 0x10e7896cc in ex_call userfunc.c:3217
||     #17 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #18 0x10e109122 in do_cmdline ex_docmd.c:988
||     #19 0x10e777961 in call_user_func userfunc.c:1000
||     #20 0x10e773dee in call_func userfunc.c:1534
||     #21 0x10e772681 in get_func_tv userfunc.c:453
||     #22 0x10e7896cc in ex_call userfunc.c:3217
||     #23 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #24 0x10e109122 in do_cmdline ex_docmd.c:988
||     #25 0x10e777961 in call_user_func userfunc.c:1000
||     #26 0x10e773dee in call_func userfunc.c:1534
||     #27 0x10e772681 in get_func_tv userfunc.c:453
||     #28 0x10e7896cc in ex_call userfunc.c:3217
||     #29 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #30 0x10e109122 in do_cmdline ex_docmd.c:988
||     #31 0x10e0222b0 in ex_execute eval.c:8648
||     #32 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #33 0x10e109122 in do_cmdline ex_docmd.c:988
||     #34 0x10e777961 in call_user_func userfunc.c:1000
||     #35 0x10e773dee in call_func userfunc.c:1534
||     #36 0x10e772681 in get_func_tv userfunc.c:453
||     #37 0x10e7896cc in ex_call userfunc.c:3217
||     #38 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #39 0x10e109122 in do_cmdline ex_docmd.c:988
||     #40 0x10e0fcf5b in do_source ex_cmds2.c:3632
||     #41 0x10e0fa6e6 in cmd_source ex_cmds2.c:3252
||     #42 0x10e0fabdb in ex_source ex_cmds2.c:3227
||     #43 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #44 0x10e109122 in do_cmdline ex_docmd.c:988
||     #45 0x10e10ce83 in do_cmdline_cmd ex_docmd.c:589
||     #46 0x10e8ea586 in exe_commands main.c:2967
||     #47 0x10e8e72bf in vim_main2 main.c:798
||     #48 0x10e8df0bc in main main.c:445
||     #49 0x7fff7abae3d4 in start (libdyld.dylib:x86_64+0x163d4)
||
|| 0x6250000052d8 is located 472 bytes inside of 8192-byte region [0x625000005100,0x625000007100)
|| freed by thread T0 here:
||     #0 0x10f09220d in wrap_free (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x5c20d)
||     #1 0x10e311e5f in vim_free misc2.c:1820
||     #2 0x10e7a4617 in win_free window.c:4793
||     #3 0x10e7b0b00 in win_free_mem window.c:2606
||     #4 0x10e7989b7 in win_close window.c:2451
||     #5 0x10e136f36 in ex_win_close ex_docmd.c:5885
||     #6 0x10e145b75 in ex_close ex_docmd.c:5810
||     #7 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #8 0x10e109122 in do_cmdline ex_docmd.c:988
||     #9 0x10e777961 in call_user_func userfunc.c:1000
||     #10 0x10e773dee in call_func userfunc.c:1534
||     #11 0x10e772681 in get_func_tv userfunc.c:453
||     #12 0x10e7896cc in ex_call userfunc.c:3217
||     #13 0x10e117e0b in do_one_cmd ex_docmd.c:2486
||     #14 0x10e109122 in do_cmdline ex_docmd.c:988
||     #15 0x10e38d6fc in nv_colon normal.c:5310
||     #16 0x10e35a8fa in normal_cmd normal.c:1106
||     #17 0x10e13ee41 in exec_normal ex_docmd.c:8934
||     #18 0x10e13e9fa in exec_normal_cmd ex_docmd.c:8897
||     #19 0x10e2da136 in execute_menu menu.c:2355
||     #20 0x10e2db32c in winbar_click menu.c:2509
||     #21 0x10e73fd3c in jump_to_mouse ui.c:2938
||     #22 0x10e37258b in do_mouse normal.c:2750
||     #23 0x10e3ad2a3 in nv_mouse normal.c:4591
||     #24 0x10e35a8fa in normal_cmd normal.c:1106
||     #25 0x10e13ee41 in exec_normal ex_docmd.c:8934
||     #26 0x10e058798 in f_feedkeys evalfunc.c:3795
||     #27 0x10e04554c in call_internal_func evalfunc.c:1142
||     #28 0x10e773f9c in call_func userfunc.c:1553
||     #29 0x10e772681 in get_func_tv userfunc.c:453
||
|| previously allocated by thread T0 here:
||     #0 0x10f092053 in wrap_malloc (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x5c053)
||     #1 0x10e30f0fa in lalloc misc2.c:942
||     #2 0x10e30f267 in alloc_clear misc2.c:851
||     #3 0x10e7a33cb in win_alloc window.c:4600
||     #4 0x10e7b530c in win_alloc_firstwin window.c:3511
||     #5 0x10e7b5170 in win_alloc_first window.c:3474
||     #6 0x10e8df65e in common_init main.c:995
||     #7 0x10e8deae9 in main main.c:176
||     #8 0x7fff7abae3d4 in start (libdyld.dylib:x86_64+0x163d4)
||
|| SUMMARY: AddressSanitizer: heap-use-after-free menu.c:2485 in winbar_click
|| Shadow bytes around the buggy address:
||   0x1c4a00000a00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
||   0x1c4a00000a10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
||   0x1c4a00000a20: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000a30: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000a40: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
|| =>0x1c4a00000a50: fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd fd fd
||   0x1c4a00000a60: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000a70: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000a90: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
||   0x1c4a00000aa0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
|| Shadow byte legend (one shadow byte represents 8 application bytes):
||   Addressable:           00
||   Partially addressable: 01 02 03 04 05 06 07
||   Heap left redzone:       fa
||   Freed heap region:       fd
||   Stack left redzone:      f1
||   Stack mid redzone:       f2
||   Stack right redzone:     f3
||   Stack after return:      f5
||   Stack use after scope:   f8
||   Global redzone:          f9
||   Global init order:       f6
||   Poisoned by user:        f7
||   Container overflow:      fc
||   Array cookie:            ac
||   Intra object redzone:    bb
||   ASan internal:           fe
||   Left alloca redzone:     ca
||   Right alloca redzone:    cb
||   Shadow gap:              cc
|| ==41516==ABORTING

Ben Jackson wrote:

OK I can repro with the following test (which borrows a function from
test_termcodes.vim):

Thanks.  I added test_setmouse() to make this easier to test.  And it
turns out that the test I added for WinBar already triggers the problem.
But for me it only shows up when using valgrind.
Fix coming...
--
ARTHUR:          What does it say?
BROTHER MAYNARD: It reads ... "Here may be found the last words of Joseph of
Aramathea." "He who is valorous and pure of heart may find
the Holy Grail in the aaaaarrrrrrggghhh..."
ARTHUR:          What?
BROTHER MAYNARD: "The Aaaaarrrrrrggghhh..."
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thanks so much, Bram. This one has been tricky to track down :)


TypeError: undefined is not an object (evaluating 'route.routeName')

I'm having an error like this, I've added the routename but it's still an error like that
TypeError: undefined is not an object (evaluating 'route.routeName')
This error is located at:
in DrawerView (at DrawerNavigator.js:127)
in Unknown (at createNavigator.js:52)
in Navigator (at createNavigationContainer.js:210)
in NavigationContainer (at SceneView.js:31)
in SceneView (at CardStack.js:412)
in RCTView (at View.js:113)
in View (at CardStack.js:411)
in RCTView (at View.js:113)
in View (at CardStack.js:410)
in RCTView (at View.js:113)
in View (at createAnimatedComponent.js:134)
in AnimatedComponent (at Card.js:26)
in Card (at PointerEventsContainer.js:55)
in Container (at CardStack.js:454)
in RCTView (at View.js:113)
in View (at CardStack.js:383)
in RCTView (at View.js:113)
in View (at CardStack.js:382)
in CardStack (at CardStackTransitioner.js:97)
in RCTView (at View.js:113)
in View (at Transitioner.js:192)
in Transitioner (at CardStackTransitioner.js:49)
in CardStackTransitioner (at StackNavigator.js:60)
in Unknown (at createNavigator.js:52)
in Navigator (at createNavigationContainer.js:210)
in NavigationContainer (at registerRootComponent.js:34)
in RootErrorBoundary (at registerRootComponent.js:33)
in ExpoRootComponent (at renderApplication.js:35)
in RCTView (at View.js:113)
in View (at AppContainer.js:102)
in RCTView (at View.js:113)
in View (at AppContainer.js:122)
in AppContainer (at renderApplication.js:34)
My code
https://pastebin.com/KkqX1MUD
what is the solution ?

I'm having the same issue.

Closing in favour of https://github.com/react-community/react-navigation/issues/3148

I'm using beta 2.1 but it's still an error

@tegarkurniawan try to delete ^ and then yarn install

I got this error for one week. Any test case run before release?

@HunDunDM, it didn't worked for me. Any ideas on how to resolve this issue?

as @sonaye mentioned in issue #3148, adding
drawerOpenRoute: 'DrawerOpen',
drawerCloseRoute: 'DrawerClose',
drawerToggleRoute: 'DrawerToggle'

makes it work.

@SamiChab

@SamiChab thank you!


No option to sanitize input

There is no option to escape CSS or HTML tags.
Eg entering<style> * { float: left }</style> will render the whole content  useless and there is no option to disable it.
Can be tested on https://simplemde.com/

duplicate #243

Am I write in thinking there is is a previewRender() hook. Couldn’t you use DomPurify on the preview. The reason why SimpleMDE doesn’t sanitise is because it uses Marked library for the preview.


make .fit_transform() pipeline-ready

Makes .fit_transform() accept lists for easier pipelining.
mapper = km.KeplerMapper(verbose=2)

projected_X = mapper.fit_transform(X,
    projection=[TfidfVectorizer(analyzer="char",
                                ngram_range=(1,6),
                                max_df=0.83,
                                min_df=0.05),
                TruncatedSVD(n_components=100,
                             random_state=1729),
                Isomap(n_components=2,
                       n_jobs=-1),
                [0,-1],
                "l2norm"],
    scaler=None)

print("SHAPE",projected_X.shape)

Adds notebook with NLP pipeline example.
Also fixes a bug in cluster statistics (probably a better check on json-encoded content/HTML).

Hello @MLWave, Thank you for submitting the Pull Request !

In the file kmapper/kmapper.py, following are the PEP8 issues :

Line 23:1: E303 too many blank lines (3)
Line 45:101: E501 line too long (103 > 100 characters)
Line 46:101: E501 line too long (130 > 100 characters)
Line 55:101: E501 line too long (404 > 100 characters)
Line 58:101: E501 line too long (666 > 100 characters)
Line 69:101: E501 line too long (114 > 100 characters)
Line 78:51: E228 missing whitespace around modulo operator
Line 115:17: E722 do not use bare except'
Line 119:9: E722 do not use bare except'
Line 170:57: E228 missing whitespace around modulo operator
Line 181:18: E128 continuation line under-indented for visual indent
Line 182:18: E128 continuation line under-indented for visual indent
Line 183:18: E128 continuation line under-indented for visual indent
Line 184:18: E128 continuation line under-indented for visual indent
Line 216:63: E228 missing whitespace around modulo operator
Line 217:40: E228 missing whitespace around modulo operator
Line 218:46: E228 missing whitespace around modulo operator
Line 219:36: E228 missing whitespace around modulo operator
Line 223:13: E125 continuation line with same indent as next logical line
Line 223:13: E128 continuation line under-indented for visual indent
Line 226:21: E128 continuation line under-indented for visual indent
Line 227:21: E128 continuation line under-indented for visual indent
Line 228:21: E128 continuation line under-indented for visual indent
Line 231:21: E128 continuation line under-indented for visual indent
Line 232:21: E128 continuation line under-indented for visual indent
Line 233:21: E128 continuation line under-indented for visual indent
Line 245:101: E501 line too long (119 > 100 characters)
Line 259:101: E501 line too long (136 > 100 characters)
Line 262:101: E501 line too long (153 > 100 characters)
Line 265:101: E501 line too long (112 > 100 characters)
Line 278:101: E501 line too long (151 > 100 characters)
Line 292:101: E501 line too long (111 > 100 characters)
Line 305:101: E501 line too long (153 > 100 characters)
Line 350:101: E501 line too long (119 > 100 characters)
Line 418:101: E501 line too long (129 > 100 characters)
Line 436:101: E501 line too long (111 > 100 characters)
Line 442:9: E303 too many blank lines (2)

In the file kmapper/visuals.py, following are the PEP8 issues :

Line 58:13: E741 ambiguous variable name 'l'
Line 96:101: E501 line too long (107 > 100 characters)
Line 128:49: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 129:49: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 155:101: E501 line too long (105 > 100 characters)
Line 172:101: E501 line too long (105 > 100 characters)
Line 173:101: E501 line too long (106 > 100 characters)
Line 174:101: E501 line too long (115 > 100 characters)
Line 175:101: E501 line too long (118 > 100 characters)

Do see the Hitchhiker's guide to code style

Codecov Report

Merging #64 into master will decrease coverage by 3.73%.
The diff coverage is 52.5%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   84.27%   80.54%   -3.74%
==========================================
  Files           6        6
  Lines         337      370      +33
  Branches       74       86      +12
==========================================
+ Hits          284      298      +14
- Misses         41       52      +11
- Partials       12       20       +8

Impacted Files
Coverage Δ

kmapper/visuals.py
92.79% <100%> (ø)
:arrow_up:

kmapper/kmapper.py
72.08% <44.11%> (-5.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8218e75...b811c61. Read the comment docs.

Needs tests.

Support for model functions.
# Following takes a fitted model and produces
# predictions for a test set
model = linear_model.Ridge(random_state=1)
model.fit(X_train)
X_projected = mapper.fit_transform(X_test,
	projection=(model, X_test), scaler=None)

# Following does 5-fold stratified cross-validation
# saving out-of-fold predictions. Also called:
# stacked generalization
model = linear_model.Ridge(random_state=1)
X_projected = mapper.fit_transform(X_train,
	projection=(model, X_train, y), scaler=None)

Could use some feedback, since these are pretty big changes, and difficult to change at later time.


aerender not exiting on windows

Hi!
I'm having trouble with aerender not closing properly: even when I run the command manually, the command prompt never gives control back to me. Using node, the 'on close' event is never called, and the program gets stuck.
Have yo had this problem before and how do you solve it ?
thanks!

Hello @bgirschig !
Never had similar problem. Does that issue apply specifically to the nexrender, or you can reproduce it on any nodejs script? Maybe it's somehow connected to the particular version you are using...

Hi!
No the problem does not only affect nexrender: I've been trying to make it
work with a more basic script (spawning the command with basic options),
but it does the same (even using the command prompt).
The command works but does not exit
When you talk about the "particular version", do you mean the particular
version of after effects ?
Le lun. 17 sept. 2018 à 16:20, Vladyslav Hrytsenko<EMAIL_ADDRESS>a écrit :

Hello @bgirschig https://github.com/bgirschig !
Never had similar problem. Does that issue apply specifically to the
nexrender, or you can reproduce it on any nodejs script? Maybe it's somehow
connected to the particular version you are using...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/inlife/nexrender/issues/73#issuecomment-422035907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF9ZHs32iJsHv1Qlb-hb3VfRHRcthKh8ks5ub6-4gaJpZM4Wrch9
.

--
Bastien Girschig
+33 69 563 22 02
<EMAIL_ADDRESS><EMAIL_ADDRESS>

I was actually asking about nodejs version, have you tried creating a child spawning process and testing it like that?

Hi
sorry for the late reply...
I have been chatting with after effects support, and this is apparently a known bug with AE 15.1.2 Downgrading to version 15.1.1 did the trick.
Thanks for your help!

Hi,
I don't think it should be closed yet. It's happening on AE 16.0 too, better adapt than being stuck.
I had a very similar issue, on macOS, w/ the error being:

aerender ERROR -1712: AESend failed to send apple event at line 771

Note: After command is spawn, there's a few minutes before this error pops.
As @bgirschig mentionned, it's occuring w/ 15.1.2. But also w/ 16.0 (16.0x235).
I noticed the command used, was perfectly running in a terminal, therefore, I started looking around the spawn, which led me to the following workaround:
let ae = spawn(process.env.AE_BINARY, params, {
    env: {
        PATH: path.dirname(process.env.AE_BINARY)
    }
});

Yep, simply specifing PATH within env option solved the issue.


Release 1.3.0-alpha.8

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.953%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1541

Relevant Lines:
1937

💛  - Coveralls


Issue31 document systems using

Fixes #31
Need documentation home to:

list **Systems that use the quicksilver-api as well as point to other system documentation in general.

list internal quicksilver systems that access the infrastructure the quicksilver-api is providing a gateway to.

Required by Trello Card "Link Co-Reg Documentation"

https://trello.com/c/i6zkVWmF

:+1:


Texture creation from flash.display.BitmapData

Why texture creation is limited only from sprites ? I think it would be good if you could work with imported images too.
Example: Having an flv you want in the fla . I am breaking it apart to sequence of images and when I import them in a movieclip symbol right now if I understand correctly I have to go trough all the images and make a symbol for them extending Sprite and after that it would work.
Am I wrong and is there a better way to import and work with flv in the fla ?
Thanks.

Yes, this is a pain, and is unlikely to change without some serious work -- but it may be possible.
Flump uses the FLA to parse the symbol library and animation data; and it uses the SWF to create textures. This latter step it does by simply loading the SWF (the Flump exporter is a regular Flash app), instantiating Sprite symbols from the library, and rendering them to texture files.
"Bitmap" objects are not accessible to Flash runtime - it can only load named symbols, and Bitmaps aren't symbols. So there's no way to get them to work with this system. Support for Bitmaps would require an alternate texture-creation path; and would also require a different scheme for deciding which bitmaps are exported, since the "only export named Sprite symbols" scheme would of course not work here.

@jkanchelov you don't need to convert each frame in a Sprite, you just have to make your MovieClip a Flipbook
See Flipbook documentation here : https://github.com/tconkling/flump#flipbook-creation
Hope it will help

(Oh indeed, thanks for pointing that out @mathieuanthoine!)

Thanks both of you guys @tconkling  @mathieuanthoine ! I will try it tomorrow .
Till then I will leave this issue open if I have more questions about it later ( I hope I won't ..)


Version 0.1-4 won't launch on Xubuntu

I installed version 0.1-3 using the .deb file, and it launches fine.  I launched the archive manager as root and extracted version 0.1-4 to the directory where 0.1-3 was installed (/usr/local/bin/discord-linux-x64).  After doing this, Discord-linux no longer launches.  Attempting to launch it through the terminal reveals this error:
error while loading shared libraries: libnotify.so.4: wrong ELF class: ELFCLASS64

Thanks in advance for any help.

The app is trying to load a 64bit library. I'm assuming you downloaded the x86 version. Did you download the correct version architecture for your computer?

Sure didn't.  The download was a bit confusing.. I think you might have mislabled the most recent version; they both say (64-Bit).
Linux x86 Release (64Bit) 0.1-4
Linux x64 Release (64Bit) 0.1-4
It's working now that I installed the correct version.  Thanks.

My bad. Sorry for the confusion.


add WHO as OSPO adopter

Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Have you picked the single best (existing) category for your project?
[ ] If submitting a tool, is your project closed source or, if it is open source, does your project have at least 100 GitHub stars?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~10 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Issues with the logo. Let's contact WHO OSPO first to see if they can provide a valid SVG image.


Use component build annotations to get PR link

Fixes
https://issues.redhat.com/browse/HAC-4288

Description
Use component annotations to show the correct PR link in customize pipeline modal.

Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
(No UI changes)
https://github.com/openshift/hac-dev/assets/20013884/01d762c3-df67-4dc9-b17d-379ec8c46dfd

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/retest

/retest

/retest


Dataset Structure Probelm

Hello dear authors,
I've run the SLAM pipeline and got the generated dataset for diffusion policy training in the form of the following six folders:

camera0_rgb
robot0_demo_start_pose
robot0_demo_end_pose
robot0_eef_pose
robot0_eef_rot_axis_angle
robot0_gripper_width

I'm confused about the contents of the six folders for most of them are binary files, and her are my questions:

For robot0_demo_start_pose and robot0_demo_end_pose, what's the structure of the pose information, and what's the definition of 'start' and 'end' ? Are there any specific timestamps?
Is robot0_eef_pose in the form of 3D Cartesian Coordinate and robot0_eef_rot_axis_angle in the form of quarternion?
Do camera0_rgb, robot0_demo_start_pose and robot0_demo_end_pose act as At, and robot0_eef_pose, robot0_eef_rot_axis_angleandrobot0_gripper_widthact asOt` in the input of the diffusion policy?
What's the exact structure of the input and output of the SLAM pipeline?
What's the function of the marker in the Mapping Video step in data collection? Is it only for the scale calibration or it also acts as a reference for global localization of the end effector?

Thank you so much for your patience!

I think all "poses" (i.e. robot0_eef_pose) task-space coordinate in the following form:

pose[:3]  are standard x,y,z translation
pose[3:] is encoded as a rotation vector

so robot0_eef_rot_axis_angle is a 3-element vector representing a rotation vector