custom ads

hi, i want to know , is there any way to add custom video ads before or middle videos?

You need to use a VAST tag and set it via the ads.tagUrl option.

how can i make vast tag?

How would set VAST on the following js code I am using for multiple videos?
<script>
const players = Array.from(document.querySelectorAll('video')).map(p => new Plyr(p));
</script>

I know from this demo it is set like this:
<script>
// Change the second argument to your options:
// https://github.com/sampotts/plyr/#options
const player = new Plyr('video', {captions: {active: true}, ads: {enabled: true, tagUrl: 'https://www.videosprofitnetwork.com/watch.xml?key=3335b438aa33d6c887e79207d1bd9c53'}});

// Expose player so it can be used from the console
window.player = player;
</script>

How would set VAST on the following js code I am using for multiple videos?
<script>
const players = Array.from(document.querySelectorAll('video')).map(p => new Plyr(p));
</script>

I know from this demo it is set like this:
<script>
// Change the second argument to your options:
// https://github.com/sampotts/plyr/#options
const player = new Plyr('video', {captions: {active: true}, ads: {enabled: true, tagUrl: 'https://www.videosprofitnetwork.com/watch.xml?key=3335b438aa33d6c887e79207d1bd9c53'}});

// Expose player so it can be used from the console
window.player = player;
</script>

Is there any demo or implementatons?

Third reply. You don't need to reply to all ad-related issues. See my other two replies.


Dockeree tolerations and new Typha replicaset algorithm

Description
This PR ensures that an exists toleration to calico-node for key: "node.kubernetes.io/not-ready". This is required for at least DockerEE. We are also adjusting the replicaset #s for Typha to make sure we only have 1 typha for clusters where there is <= 4 nodes and then scale up from there. You can see the scaling in the code / comments below. Once we get above 1000 nodes, we calc using a max node per typha of 200.
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

@doucol @tmjd is this still in progress? Looks like it has a conflict now.

I think this should be closed. I think we don't need the Dockeree tolerations. @doucol feel free to reopen if you disagree.


Release 0.5.1

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

Coverage decreased (-0.3%) to 85.832% when pulling d9515205dcf896957293497c52567994ba64c0a6 on develop into 16cbdb88222ec00c2fbadd0333add2084ef6e565 on master.


Feature/batch get key dne

modifies multi-get endpoint to not include missing keys in return json.
eg. Say that a ldb instance has the following keys and values:
{
    "x": "1",
    "y": "2"
}

then, a multi-get for the following keys:
["x", "z"]

will return:
{
    "x": "1"
}

Note: the single-get endpoint did not change, this will still 404 if the key does not exist

regroups resources.go so that each route has its own named handler -- essentially, breaks apart the one large InitRouter func into multiple, smaller funcs

adds a wercker.yml for CI integration

I guess you can't assign to multiple people.
@teepark @antondam - please review

I'm still working on wercker test builds, should be working soon


Implement join between entries for AD queries

Allow joining LDAP entries together based on a DN attribute. The syntax is similar to the one used to give the CN of a DN attribute (e.g. {member.cn}) and allow to give entry attributes through an additional LDAP query (e.g. {member.userPrincipalName}).
The ldap configuration has been extended with one additional attribute joins to permit the user to specify the filter to be used for the query (e.g. to filter out entries not having the referenced attribute).
Thanks in advance for the review.

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #273   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          12     12
  Lines        1700   1755   +55
=====================================
+ Hits         1700   1755   +55

Impacted Files
Coverage Δ

ldap2pg/validators.py
100% <100%> (ø)
:arrow_up:

ldap2pg/ldap.py
100% <100%> (ø)
:arrow_up:

ldap2pg/utils.py
100% <100%> (ø)
:arrow_up:

ldap2pg/manager.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8380ad...bffb2fb. Read the comment docs.

Wow, very interesting ! Did you found somethings hard to understand in the code base ? Some remark :

Can you write a func test or extend the func test fixtures to validate the features ?
Can you add a Changelog entry ?
Would you mind add a full example of join in documentation (for exemple in cookbook) ?

Did you know my naïve mock up of join feature : https://github.com/dalibo/ldap2pg/issues/128#issuecomment-347879982 ?
Thanks for this huge contribution :-)

Thanks for the review. The ldap2pg code base is very well structured which allowed to make this change quite small.

Added a func test which is a variation on the default ldap2pg.yml configuration. As the AD schema is not loaded in the LDAP directory, I used the mail attribute instead of sAMAccountName. The default fixture of the LDAP database has been modified for this.
Changelog added
Added an example of configuration in the cookbook. I'm not 100% satisfied about it as it is not something that could be tried on the LDAP database configured by the default fixture, but in my opinion it is closer to a real usage.

Yes, I've seen the mock up of the join feature when investigating how to link objects together. I took some latitude as I struggled to find a link between the configuration of the mock up and the configuration found in recent versions of ldap2pg.yml. The advantages of specifying the attribute (instead of join) is to allow multiple joins from the same entry (although I do not think of a usage scenario for that) and implicit configuration of the search base. The disadvantage is that it adds one more level in the configuration of the join.
Would you prefer the implementation to follow more closely the mock up of issue #128?

@hlecleme That's very good. For the format, I prefer list over dict. List item are more embeddable with all information. What do you think of a using extension like this:
- ldap:
    base: …
    filter: …
    join:
      using: member
      filter: …
  role:
  - name: '{sAMAccountName}'
    member: '{member.sAMAccountName}'
  - name: '{member.sAMAccountName}'

join can be a list. And joins is accepted as an allias as usual. You did it right.

Note that it's just a matter of yaml formatting. using: member is just a way to pass the key in value. This limits depth of YAML but loose the implicit unicity of each join. Still, you can map this to a dict in internal representation and thus, not changing the code).
Maybe you could accept both:
- ldap:
    join:
      using: member
- ldap:
    joins:
    - using: member
- ldap:
    joins:
      member:
        filter: …
...

I tend to accept different formats in YAML. The inner representation must always be stable (in this case, a dict). The idea is that internal representation handle all cases. But user can write only what he need to define : a single join rather than a list of one join.
Actually, lighter YAML syntax can be added later. The join dict is a good starting point !

@hlecleme I'm ok to merge. We could improve this later (more YAML syntax, some refactoring, etc.). Can you confirm you're ready for merging ?

@bersace Thanks again for the review. Yes, I'm ready.

Bravo \o/


Missing Phonon.dll in exported project

Are you using the provided fork of Godot?
yes
Godot-steam-audio version
0.2.0
Steam-Audio version
4.5.3
Operating System
Windows 10
Describe the bug

Tried exporting a project that uses steam audio but an error pops up that says "phonon.dll" is missing. The game then crashes.
To Reproduce
Steps to reproduce the behavior:

Export a project that uses steam audio.

Expected behavior
No missing dependencies
Example project, code snippet, or screenshots
Additional context

wait nah I'm dumb I should just copy it manually


Feature authorized domains

Add a safe list of domains that can be sent invitations to.
https://trello.com/c/hJnWwOFf/283-limit-account-invites-to-certain-email-domains

If it is not possible to have two font weights in the same message, let's remove the second sentence and keep it in the error validation message.
Updated design can be viewed in Figma.


project not building due No resource found that matches the given name: attr errors

Using VS2017 - PC (15.7.2), have API level 27 (sdk and google apis intel sys image), same for API 26 and API 21 installed. I tried to follow the article to change the navigation bar back arrow colors, created values-v21 styles.xml file, have a few attributes there, minimum android and target set both to API level 21 and I am unable to build
No resource found that matches the given name: attr  'statusBarColor'
No resource found that matches the given name: attr  'textColorPrimary'
my proj is using latest Android nuget packages, and Xamarin Forms 2.5... this is just ridiculous!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87b678e7-5336-db4f-02ac-db6d2115ebec
Version Independent ID: 5434c705-8fa7-f2ed-e358-6c05d915cde0
Content: Material Theme - Xamarin
Content Source: docs/android/user-interface/material-theme.md
Service: unspecified
Product: xamarin
GitHub Login: @mgmclemore
Microsoft Alias: mamcle

Hi @BDTomasz, it looks like you've found a bug. This repository is only for documentation-specific issues: could you please report your build error at Developer Community (click Report a problem). Thank you!


[WIP] Enable the E2E tests for v1alpha2.

Fix #634

This change is

Coverage decreased (-0.08%) to 57.405% when pulling 0f4abf6d03e81cc2143651f184c2a73e073db0f1 on jlewi:v1alpha2_enable_tests into 96e640901804ac22a271b793f7fd1b8d7bfe74bf on kubeflow:master.

/test all

Pod "kubeflow-tf-operator-presubmit-tfjob-e2e-v1alpha2-667-0f4abf6-653-e330-1343997362" is invalid: metadata.labels: Invalid value: "kubeflow-tf-operator-presubmit-tfjob-e2e-v1alpha2-667-0f4abf6-653-e330": must be no more than 63 characters

/test all

This should be ready for review. Most recent test run passed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_tf-operator/667/kubeflow-tf-operator-presubmit/686/
Tests are rerunning because I rebased to squash some commits.
/assign @ankushagarwal
/assign @gaocegege


Hide leaked internal type NativeToolChainRegistryInternal from project extensions

Context: https://github.com/gradle/gradle/issues/4079
I think this is as simple as changing the public type to NativeToolChainRegistry in NativeComponentModelPlugin and making sure to look-up the right type in the RuleSource plugin.

Fixed in https://github.com/gradle/gradle/commit/9568a0896f32ad7f5ee4f19430879f783c8ddb18


How to restrict editing only for authenticated users?

Is it easy to enable editing only for those user/admins that are authenticated and otherwise just display the values in non-input fields (div, p, h1, etc)?

It is possible to do this with built in functionality. Using the e-ng-disabled="boolean" value, one can easily enable and disable an xeditable element. Here I have shown it used on a standard text element, as well as a date time picker. https://jsfiddle.net/carcomp/dpf5jb39/1/

@mitcht This did not work. e-ng-disabled did not affect the editability of the particular element at all. I saw somewhere else to use edit-disabled="boolean". This... mostly works. For whatever reason, the exact same code works just fine on an element being ng-repeat'd, and not at all outside of one. So if I have an array of string info from an API I'm iterating through it's fine, but if I have just a single text element, no dice.

Can you provide a plunker/jsfiddle showing your issue?

Hmm. No I cannot. The code from my project works exactly as it should in the fiddle. I think I've identified another issue that is causing my problems that is not xedit related.
Here's the fiddle anyway for anyone that wants to see e-ng-disabled and edit-disabled side by side. http://jsfiddle.net/dpf5jb39/12/
The ngRepeat should be

        <span editable-text="aliases[$index]" e-name="aliases[$index]"e-required
Fiddle just didn't like "track by $index" for whatever reason.

The reason your track by index didn't work is because you are using an older version of angular in your fiddle.


Add support beanie backend for Mongo

I can provide PR with my changes on top of this one, if it has any chance of being merged...

@ADR-007 and @arthurio Can you review again?


ROX-13899: Clear selected deployments when namespace deselected in new Network Graph

Description
By passing two additional parameters--the currently selected deployments and an array of all namespaces with their child deployments--to the Namespace select component of the Network Graph breadcrumbs, this additional logic filters the selected deployments whenever a namespace select change event occurs.

Whenever the Namespace select component re-renders, it build a map with each NS as a key, and a simple array of string values of its deployments as the key's value.
When a NS select event occurs, the change handler takes the new selection and uses it to filter that map of NS-deployments (object -> array of entries -> array filter -> back to filtered object)
It then flattens all those deployments into a single array of the allowed deployments.
It then filters the lists of currently selected deployments against the new list of allowed deployments.
In addition to updating the URL with selected namespaces, it updates the URL with filtered list of selected deployments.

Notes:

I did not refactor this logic into a separate function, because it is currently only used in this one place. Refactoring for unit testing would be a good follow-up task.
I also added a new optional parameter to the Network Service's  fetchNetworkFlowGraph and fetchNetworkPolicyGraph functions, that allows the new Network Graph to force Orchestrator components to always be shown.

Checklist

[ ] Investigated and inspected CI test results

Testing Performed
Two namespaces and deployments from each selected

After de-selecting one of those namespaces, the deployments from the deselected NS no longer appear (gone from the URL, and hence graph and the select)

/retest-required


Can cluster symbology be added to an atlas's legend?

ICC would like me to add the cluster symbology to the ArcticCBM legend, is this possible?
Thanks,
Amy

Is it possible? Yes, with a lot of work. Nunaliit currently does not support adding the clusters in the legend, since the legend is a layer selector (which doubles as a legend).
However, it would be possible to augment the layer selector with custom information. The element that contains the layer selector can be selected with $("div.layersDiv"). Probably the best place to insert the code would be in the nunaliit_custom.js. One could register for the event 'reportModuleDisplay', look for the element and augment it with more legend information.

Amy, some custom code could do the trick as JP suggests. But you could also have the cluster symbology share the same colour/fill/shape as the layer and do something more subtle for the cluster like increase the radius, thicken the stroke, and include a label inside with the number. That way it can still be recognized as the same type of symbol as far as the layer selector/legend goes.

Hi Amos and JP - thanks for your responses.  I'll note the options you provided and let the powers that be work out the most appropriate solution.  I'm no longer on this project as I've taken on a new position at NSIDC.  I appreciate the help you've provided over the past year or so, and I've quite enjoyed working with Nunaliit!
Kind regards,
Amy


RangeDoppler heat maps

Hi Guys, good work there.
Thanks a lot guys...

Hi,
I am glad to see you solved your problem. What was the reason? Just in case someone else has the same problem.


Typo: Join Page

When visiting the main player page, it says "joni" where it should say "join" instead:

Fixed the issue.


An error message pops up when unload project.

Environment

Steps to Reproduce

Create a python application
Select "Property" page, select "Test" to set "Test framework" to "pytest"
Unload the python project

Expected behavior
The project unload successfully without any error.
Actual result
An error message pops up.

Log
ActivityLog.zip

I meet this problem more frequently, but sometimes this issue is not repro after restart the VS.

This issue reproduced on today's build.


Title replaced by value in imBack message unexpectedly (Blocker)

We are experiencing an unexpected value in the message sent in a suggestedAction as an object containing the imBack action when the title and value are different accessing the bot via DirectLine.
Here is the setup:
define conversation.CONSTANTS as {"LINK_1" : {"type":"imBack", "title": "Home page", "value": "https://www.homepage.com/"}}
If we set the following properties on the prompt:
"List style" to "suggestedAction"
"Array of choices" to "simple choices"
Expression =[conversation.CONSTANTS.LINK_1]"
The expected message payload would be:
{"type":"imBack", "title": "Home page", "value": "https://www.homepage.com/"}}
Instead, we are getting:
{"type":"imBack", "title": "https://www.homepage.com/", "value": "https://www.homepage.com/"}
when viewed via the Message Inspector.
### Tasks

@waynehsmith,
Apologies for the delay. Unfortunately, I am unable to reproduce your issue at the moment. Would you be willing to provide more detailed reproduction steps? Perhaps I am doing something differently than you which may be causing the discrepancy.

Thanks for the response - Let me create a small project duplicating this and attach it to the issue this evening.

Closing this issue due to inactivity. If you still require assistance, please comment and we can reopen the issue.


Add utility to change default zoom

Currently the zoom is set to the default of 40 (I believe this stems from the minimum bases being 39 but I have not verified) such that using only a single position (chr5	474989) results in a 41bp window (chr5:474,969-475,009). I added an argument that allows users to change this value. The default is set to 40, so the current output is maintained in the absence of this argument.
Let me know if you have any comments.

There's already a flanking argument, see the readme.

Yes, I see that. If I understand correctly, that allows the user to have a set number of bases around the location show up in the html file. What this does is actually set the zoom. If you look at the example here, the flanking was set to 1000 and that can seen in the fact that the html contains 500 bases on each side, but the initial zoom is 41. Now consider the attached file where the zoom was added using the --zoom argument and set to 300. The flanking is still 1000.
I had to edit the extension to allow uploading but you can change it and see if it makes sense. example_vcf.html.txt

OK,  I don't have any time for igv-reports at the moment but keep this open.

Sorry for the delay.   This looks like a good addition.   I have just a couple of suggestions.

Rename the "zoom" argument to "window".  Zoom is used internally in igv.js to mean something else.  I'm open to other name suggestions.
Default the value to None, not 40, and if it is None leave the current behavior as is.   As coded here it actually changes behavior when start & end are specified.     Also, there could be a difference in igv.js between zooming to a single nucleotide and zooming to a window around that nucleotide, although the visual effect is the same.   In any event I don't want to change behavior in any way if this optional argument is not specified.

That makes sense! I've added in the requested naming changes, and added code to allow for a None default for the argument. Let me know what you think.

Looks good


Download sparse blob

Resolves #7295
GitHub issue link https://github.com/Azure/azure-cli/issues/5872

Can one of the admins verify this patch?

            self.assertEqual(byte, 0)

add comment to explain except

Refers to: sdk/storage/azure-storage-blob/tests/test_page_blob.py:1579 in 4327bf1. [](commit_id = 4327bf1dcf95c81495bc3f5ab3da8fe19af856a1, deletion_comment = False)


Add private github repo e2e test

Changes

This PR made the following changes:

Add code logic to create sshkey secret in workflow ci.yml file
Add build/buildrun yml for testing private github repo
Only keep one set of build/buildrun yml for testing private github repo and deleted others

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes

@zhangtbj @SaschaSchwarze0 could you please help review this PR? Thanks.

the release-note label was applied this PR but the release note text in the description is invalid
I think this is how you switch it
/release-note-none

@gabemontero: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

Ah right that is the rule .... can you edit your description @mattcui and remove the release note block / heading

@gabemontero  Hi Gabe, previously, Enrique helped create the secret SAMPLE_RUBY_PRIVATE_SSHKEY as we planned to do this test for ruby sample, but it's changed to use nodejs, as Sasha suggested, would you mind to use a meaningful name by recreating a new secret, may be called E2E_PRIVATE_SSHKEY? Or you can use a name you like. If you could help (Enrique is on vacation), please let me know, I could send the sshkey to you by mail. Thanks.

@gabemontero Hi Gabe, previously, Enrique helped create the secret SAMPLE_RUBY_PRIVATE_SSHKEY as we planned to do this test for ruby sample, but it's changed to use nodejs, as Sasha suggested, would you mind to use a meaningful name by recreating a new secret, may be called E2E_PRIVATE_SSHKEY? Or you can use a name you like. If you could help (Enrique is on vacation), please let me know, I could send the sshkey to you by mail. Thanks.

hey @mattcui - apologies, but I do not have those level of permissions in our repos.  You'll need @adambkaplan.

@gabemontero Hi Gabe, previously, Enrique helped create the secret SAMPLE_RUBY_PRIVATE_SSHKEY as we planned to do this test for ruby sample, but it's changed to use nodejs, as Sasha suggested, would you mind to use a meaningful name by recreating a new secret, may be called E2E_PRIVATE_SSHKEY? Or you can use a name you like. If you could help (Enrique is on vacation), please let me know, I could send the sshkey to you by mail. Thanks.

hey @mattcui - apologies, but I do not have those level of permissions in our repos. You'll need @adambkaplan.

Thank you, Gabe, @adambkaplan could you please help? Thanks.

/release-note-none

@mattcui I have added a separate GitHub actions secret with the name CI_USER_PRIVATE_SSH_BASE64. This contains the SSH key associated with the @shipwright-ci-user account that has read-only permissions to the private repo.

@adambkaplan Adam, thanks for creating the key, where can I get the public key?
@qu1queee Enrique, as the e2e test will fail in my PR because it's from the branch of my forked repo,the forked repo can't access the secret of main repo, I still need your help to merge my code into test_private_repos for e2e test. Thanks.
/cc @qu1queee

Im closing this one. I will reopen with the same changes as before. At the moment Matt will not be able to continue working on this.


List of all configurable settings

Let's keep a list of what can be set up in engine-q until we document it properly.
$config
With PR #489 one can now specify foreground (as fg), background (as bg), and font attributes (as attr) in the color_config section of the config file, config.nu. Additionally PR #486 allows one to specify only the foreground color in a rgb hex color like "#rrggbb".
The available attributes are documented in this code snippet. Some of these, like blink, may not be supported by your terminal.
for ch in color_attr.to_lowercase().chars() {
        match ch {
            'l' => blink = true,
            'b' => bold = true,
            'd' => dimmed = true,
            'h' => hidden = true,
            'i' => italic = true,
            'r' => reverse = true,
            's' => strikethrough = true,
            'u' => underline = true,
            'n' => (),
            _ => (),
        }
    }

Here are a couple examples of using multiple color setting syntaxes.
color_config: {
    separator: "#88b719" # this sets only the foreground color like PR #486
    leading_trailing_space_bg: white # this sets only the foreground color in the original style
    header: { # this is like PR #489
      fg: "#B01455", # note, quotes are required on the values with hex colors
      bg: "#ffb900",# note, commas are not required, it could also be all on one line
      attr: bli # note, there are no quotes around this value. it works with or without quotes
    }
    date: "#75507B"
    filesize: "#729fcf"
    row_index: { # note, that this is another way to set only the foreground, no need to specify bg and attr
      fg: "#e50914"
    }

This is an example config will all "original style" coloring but it also demonstrates all configurable settings at this point.
Config file 1 - Normal/Basic
let $config = {
  filesize_metric: $true
  table_mode: rounded # basic, compact, compact_double, light, thin, with_love, rounded, reinforced, heavy, none, other
  use_ls_colors: $true
  color_config: {
    separator: yd
    leading_trailing_space_bg: white
    header: cb
    date: pu
    filesize: ub
    row_index: yb
    hints: dark_gray

    bool: red
    int: green
    duration: red
    range: red
    float: red
    string: red
    nothing: red
    binary: red
    cellpath: red
  }
  use_grid_icons: $true
  footer_mode: always #always, never, number_of_rows, auto
  animate_prompt: $false
  float_precision: 2
  use_ansi_coloring: $true
  filesize_format: "b" # b, kb, kib, mb, mib, gb, gib, tb, tib, pb, pib, eb, eib, zb, zib, auto
  env_conversions: {
    "PATH": {
        from_string: { |s| $s | split row (char esep) }
        to_string: { |v| $v | str collect (char esep) }
    }
  }
  edit_mode: emacs # emacs, vi
  max_history_size: 10000
  log_level: error
}

PR #502 brings cli syntax highlighting. These symbols are called FlatShape in nushell/engine-q so that is what the configuration points are called. With this config example we attempt to make a first pass at a base16 theme.
To go full base16 you'll still need to change your LS_COLORS and PROMPT_COMMAND to match.
Config file 2 - with themes / advanced
let base00 = "#181818" # Default Background
let base01 = "#282828" # Lighter Background (Used for status bars, line number and folding marks)
let base02 = "#383838" # Selection Background
let base03 = "#585858" # Comments, Invisibles, Line Highlighting
let base04 = "#b8b8b8" # Dark Foreground (Used for status bars)
let base05 = "#d8d8d8" # Default Foreground, Caret, Delimiters, Operators
let base06 = "#e8e8e8" # Light Foreground (Not often used)
let base07 = "#f8f8f8" # Light Background (Not often used)
let base08 = "#ab4642" # Variables, XML Tags, Markup Link Text, Markup Lists, Diff Deleted
let base09 = "#dc9656" # Integers, Boolean, Constants, XML Attributes, Markup Link Url
let base0a = "#f7ca88" # Classes, Markup Bold, Search Text Background
let base0b = "#a1b56c" # Strings, Inherited Class, Markup Code, Diff Inserted
let base0c = "#86c1b9" # Support, Regular Expressions, Escape Characters, Markup Quotes
let base0d = "#7cafc2" # Functions, Methods, Attribute IDs, Headings
let base0e = "#ba8baf" # Keywords, Storage, Selector, Markup Italic, Diff Changed
let base0f = "#a16946" # Deprecated, Opening/Closing Embedded Language Tags, e.g. <?php ?>

let base16 = {
    separator: $base03
    leading_trailing_space_bg: $base04
    header: $base0b
    date: $base0e
    filesize: $base0d
    row_index: $base0c
    bool: $base08
    int: $base0b
    duration: $base08
    range: $base08
    float: $base08
    string: $base04
    nothing: $base08
    binary: $base08
    cellpath: $base08
    hints: dark_gray

    # flatshape_garbage: { fg: $base07 bg: $base08 attr: b} # base16 white on red
    # but i like the regular white on red for parse errors
    flatshape_garbage: { fg: "#FFFFFF" bg: "#FF0000" attr: b}
    flatshape_bool: $base0d
    flatshape_int: { fg: $base0e attr: b}
    flatshape_float: { fg: $base0e attr: b}
    flatshape_range: { fg: $base0a attr: b}
    flatshape_internalcall: { fg: $base0c attr: b}
    flatshape_external: $base0c
    flatshape_externalarg: { fg: $base0b attr: b}
    flatshape_literal: $base0d
    flatshape_operator: $base0a
    flatshape_signature: { fg: $base0b attr: b}
    flatshape_string: $base0b
    flatshape_filepath: $base0d
    flatshape_globpattern: { fg: $base0d attr: b}
    flatshape_variable: $base0e
    flatshape_flag: { fg: $base0d attr: b}
    flatshape_custom: {attr: b}
}

let config = {
  filesize_metric: $true
  table_mode: rounded # basic, compact, compact_double, light, thin, with_love, rounded, reinforced, heavy, none, other
  use_ls_colors: $true
  color_config: $base16
  use_grid_icons: $true
  footer_mode: always #always, never, number_of_rows, auto
  animate_prompt: $false
  float_precision: 2
  without_color: $false
  filesize_format: "b" # b, kb, kib, mb, mib, gb, gib, tb, tib, pb, pib, eb, eib, zb, zib, auto
  edit_mode: emacs # vi
  max_history_size: 10000
}

$nu.env

LS_COLORS: Sets up colors per file type in ls
PROMPT_COMMAND: Code to execute for setting up the prompt

Still on the list and yet to be done

[ ] CMD_DURATION_MS to get the execution time of the last command
[ ] LAST_EXIT_CODE to get the exit code of the last command (internal or external)
[ ] Configure the indicators from reedline (see below)

Here are the indicators from reedline. I don't think all of these are exposed yet.
/// The default prompt indicator
pub static DEFAULT_PROMPT_INDICATOR: &str = "〉";
pub static DEFAULT_VI_INSERT_PROMPT_INDICATOR: &str = ": ";
pub static DEFAULT_VI_VISUAL_PROMPT_INDICATOR: &str = "v ";
pub static DEFAULT_MULTILINE_INDICATOR: &str = "::: ";

We also need a way to configure the prompt indicators, so that it's easier to use things like starship

@jntrnr I added the prompt indicators from reedline above, is this what you are talking about?

@fdncred - ah okay, so those aren't yet supported. Cool.
Oh unrelated but while I'm here - I was wondering if we should pick nicer names for the syntax highlighting. flatshape_int feels kind of like you have to know how nushell works internally to know what that means :D Maybe we could use "nu_int" or "lang_int" or something?

I could go for cli_int since it's really coloring the cli syntax - or syntax_int.

The only items that are the same between flatshape and primitives are int, float, range, string - all there rest are different and not included in the primitive coloring. Also, the flatshapes have different coloring that primitives. so, I think we need to keep the flatshapes different from primitives as far as coloring. I was once thinking about combining these, for instance, only have one int coloring, but now I think that would be wrong.

I added log_level which lets you turn on tracing if you want. It currently restarting the shell when you change it (but maybe that's fixable with a few tweaks)

I added log_level which lets you turn on tracing if you want. It currently restarting the shell when you change it (but maybe that's fixable with a few tweaks)


Ability to override terraform version per Workspace with environment variable

Description of your changes

Inspired by  https://github.com/upbound/provider-terraform/pull/82 CC @bdwyertech
Add https://github.com/tofuutils/tenv/ to the provider image, a Golang-based successor to https://github.com/tfutils/tfenv
Manage the terraform cli version with it, default to the current 'safe' 1.5.5
Document usage
Overriding the custom version of terraform per Workspace is as easy as

    env:
      - name: TFENV_TERRAFORM_VERSION
        value: 1.4.0 #custom version per workspace

the tenv will handle the installation and invocation of the custom version

Within provider pod the multiple version are stored in /.tenv and looks like this in case of multiple version usage

~ $ cd .tenv/
/.tenv $ tree
.
└── Terraform
    ├── 1.4.0
    │   └── terraform
    ├── 1.5.5
    │   └── terraform

/.tenv/Terraform/1.5.5/ is the current default version and prepackaged to the provider image

Fixes #84
I have:

[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested
Running custom provider image with this change and invoking several workspace examples
k get workspaces.tf.upbound.io
NAME                           SYNCED   READY   AGE
sample-inline-with-env         True     True    26m
sample-inline-own-tf-version   True     True    19m

Checked the associated contents of /.tenv directory and custom terraform cli invocation in the process list  - it worked as expected.

Hey this looks really cool, thanks for the shout out @ytsarev

/test-examples="examples/workspace-inline-aws.yaml"

At this point in time, we will not allow overriding the Terraform binary with the possibility of one released after 1.5.x as they are released under the BSL license. This provider would violate the license terms, and we do not want to open the possibility for that even if the action was taken by a user of the provider.


Remove jquery-rails, explicitly add jquery 2.1 to bower

We've been using jquery from bower for quite a while (depended upon by patternfly and others), this is just making it obvious.
jquery-rails provides jquery & jquery-ujs, and we already have ujs in bower.json as well - not needed, removing

Euwe Backport details:
$ git log
commit 64a8626f8ddfa5512b29e60dbff865a3119c84db
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Thu Sep 29 14:41:54 2016 +0200

    Merge pull request #11398 from himdel/jquery-rails

    Remove jquery-rails, explicitly add jquery 2.1 to bower
    (cherry picked from commit a7dbd45fd0e9bfca2374eaaddf3e4aa6aee1283c)


Dependency & Maintenance update (#214)

Bump the production-dependencies group across 1 directory with 5 updates (#213) Bumps the production-dependencies group with 4 updates in the / directory: @babel/runtime, @natlibfi/marc-record, @natlibfi/melinda-commons and @natlibfi/melinda-rest-api-commons.

Bump the development-dependencies group across 1 directory with 7 updates (#210) | Package | From | To |
| --- | --- | --- |
| @babel/cli | 7.23.9 | 7.24.5 | | @babel/core | 7.23.9 | 7.24.5 | | @babel/plugin-transform-runtime | 7.23.9 | 7.24.3 | | @babel/preset-env | 7.23.9 | 7.24.5 | | @natlibfi/eslint-config-melinda-backend | 3.0.4 | 3.0.5 | | eslint | 8.56.0 | 8.57.0 | | nodemon | 3.0.3 | 3.1.0 |

Bump mikaelvesavuori/license-compliance-action from 1.0.2 to 1.0.3 (#196)

Update deps

Node-tests: add v22, remove v19

Update license to MIT [MRA-40]

3.0.19-alpha.1

Draft, until we see how this behaves in the testing environment.


AsyncDataCache issue with checkpoint.

Bug description
We observed query failures where AsyncDataCache is recovered from a corrupted checkpoint. This issue reproduces if check pointing is enabled (e.g. "async-cache-ssd-checkpoint-gb": "8") and restarting software (e.g. Presto Server) with previous cache file directory. Failures are observed with following message:
!ZSTD_isError(ret) ZSTD returned an error: Data corruption detected Info: Stripe 0 Stream [id=33, node=1, sequence=0, column=0, kind=1] Split [Hive: /path/to/file/part-00013 0 - 33554432 13] Task 20230816_094327_00826_4t6fh.<IP_ADDRESS>
To reproduce the issue - one needs to enable check-point and run a considerable amount of sql query (lets say 500 to 1K query) with Presto server. Then, stop the server and restart the server without wiping out the cache directory so that cache can recover from its previous state. Then running exactly same workload reproduces the issue.
System information
Presto server running in 60 Node workers and 1 coordinator.
Relevant logs
Error message:

!ZSTD_isError(ret) ZSTD returned an error: Data corruption detected Info: Stripe 0 Stream [id=33, node=1, sequence=0, column=0, kind=1] Split [Hive: /path/to/file/part-00013 0 - 33554432 13] Task 20230816_094327_00826_4t6fh.<IP_ADDRESS>

One fix for this issue was done here https://github.com/facebookincubator/velox/pull/6371 (thanks @xiaoxmeng)
Another fix is data integrity check with checksum so that cache knows its reading exactly what was written to storage device by itself (https://github.com/facebookincubator/velox/pull/6148 is an attempt on that).

CC: @aditi-pandit @oerling @majetideepak  @mbasmanova @xiaoxmeng @pranjalssh

Due to the above error, we disabled cache persistence in Prestissimo. Recently, we enabled it by setting async-cache-ssd-checkpoint-gb=8. However cache checkpoint files (.cpt files) are no longer written. Thanks @gggrace14 for pointing this out. So the major issue now is checkpoint is written at all.
@gggrace14 you mentioned cache TTL writing dependent on checkpoint. Will be great if you can clarify or create a separate issue about TTL, what's added and what's missing.

CC: @zacw7 @xiaoxmeng


What is the current status of car-mirror?

It is October, and i don't see movement on issues since Feb, and code since June.
Is this project an active priority for anyone? Any timeline or roadmap available for us eager consumers?

Hello!
kubo-car-mirror will likely not see many updates in the immediate future.
We'll be building on top of https://github.com/fission-codes/rs-car-mirror/ instead!
That'll just enable us to make car mirror requests easier from browsers (with Wasm) and any rust CLIs we'd write in the future.
Also of note is that rs-car-mirror and go-car-mirror are not compatible at the moment. Neither are completely spec-adhering, (although rs-car-mirror may be at some point), and rs-car-mirror is just a lot simpler in terms of implementation & protocol.

Also of note: rs-car-mirror at the moment is mostly a bag of pure functions. It's not integrated with for example an HTTP library yet to turn car mirror protocol calls into HTTP requests & responses, and there's no Wasm bindings for now.
But it's definitely where development will continue.

Update: rs-car-mirror is now released to crates.io and there exist libraries to use car mirror over HTTP & in Wasm, using car-mirror-reqwest and car-mirror-wasm.
For anyone interested in using car mirror with kubo, almost all necessary code to build a small webserver binary that exposes car mirror HTTP endpoints and talks to kubo as the blockstore exists out there, it just needs to be factored out, collected and packaged up.


Initial data loading and reacting to server notifications

As I've understood for now there is no way to call dispatch from outside of view or action creator.
So I'm not quiet understand how should I deal with initial data loading and in case when server emits an event and I have to call action from API.

Btw I'm using 0.12 version for now.

As I've understood for now there is no way to call dispatch from outside of view or action creator.

There is. You get a Redux instance (renamed to Store in 1.0) by calling createRedux:
let redux = createRedux(...);

It has a dispatch method.
See https://github.com/gaearon/redux#running-the-same-code-on-client-and-server

@gaearon Dont you think that its some kind of boilerplate? Why would we always call actions like dispatch(action())? It there any reasonable way when we need to call action() without dispatch?

@gyzerok I'm wondering, what does the non-boilerplate version of that look like to you? dispatch() just takes an action object. If you don't what to use action creators, that's up to you.

@acdlite mb I did no get it right.. I'm taking about calling actions like action() from anywhere. Like we do after bindActionCreators in the view. For now if I have to call an action from my API wrapper I need to do: move redux creation into a separate file, import dispatch, import action. And my point of view is: why do we need 2 function in place of one if we always have to "call them together"?

@gyzerok Again, do you have a better alternative in mind?

@acdlite making action execution simple by calling someAction() without dispatch?

Where does someAction() come from? How to you access it?

@acdlite Lets hold on a little. Do we need to talk about concrete solution before we agree that it would be better?

@gyzerok I'm trying to prove a point :) If you can come up with a concrete solution that's less boilerplate than the current solution, then we can consider it. I don't think one exists, but I'd be happy to be proven wrong.
One solution is to bind just once after creating your store, then exporting the bound action creators as a singleton. But this doesn't work for server-side rendering — you need to pass dispatch through the React component tree using context, like we do with state subscriptions. If you don't care about server-side rendering, though, then a singleton is fine.
Another solution is to update the Connector API so that instead of passing dispatch(), it passes a collection of bound action creators. But then that means you have to register them somehow with the Store upon creation. And then, in the Connector, you need an API to select just the ones you want. To me, this is a lot more boilerplate than just a single function call, bindActionCreators() at the Connector site.
Again, though, I'd be happy to be proven wrong!

The best point here I suppose is to decorate action creators with dispatch, but for now we cant use decorators on an exported function.
Thank you for your explanation though!

Even if you could use a decorator...
@bindActionCreator(dispatch)
export actionCreator() {}

where does dispatch() come from?

@acdlite in this way I can import it from redux instance like I do now.

@gyzerok That requires creating a singleton. Not the worst thing ever, just be aware of the downsides.

As I understand for now there is no way to handle with my problem without creating singleton.
Is there another way to perform action on some event from the server?

Pass the store to a function
function listenToServer(store) {
  // ...
  store.dispatch()
}

then call that function from wherever you call createStore().

@acdlite do you mean redux instance by the store? If so I do not see any differences from importing dispatch from this instance and calling it as dispatch(actionCreator()). Correct me if I'm wrong.

@gyzerok The Redux instance is being renamed to Store in 1.0, sorry for the confusion.https://github.com/gaearon/redux/pull/195
And you're right, just passing dispatch would be even better.


Make all docs references relative

For supporting GH markdown and GH (web)pages
We can ensure the links work in GH with
https://github.com/eclipse-pass/main/tree/relative-links-everywhere
And we cannot fully test on eclipse-pass.org/main until it's deployed :-(

Correct, we just need to deploy and try.

Perfect, links now work as expected in the GH Pages view: https://eclipse-pass.org/main/. Thanks @aforward!


Add Search TextBox to Explorer Pane

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 10.0.14393

Visual Studio has a nice search box (Ctrl + ;) shown in the picture below. When you type here some text it finds it across all file names and inside files showing each occurence.

Could you please add that to explorer pane. It'll be more comfortable to search via it, not via Ctrl+Shift+F.

If you press ctrl+p you can then search your files from the dropdown that appears.

Command palate is our preferred way to navigate through/search files :)


Codecov Report

Merging #580 (fcdd76b) into dev (0f0ae68) will decrease coverage by 0.06%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##              dev     #580      +/-   ##
==========================================
- Coverage   79.05%   78.99%   -0.07%
==========================================
  Files         152      152
  Lines        3319     3327       +8
==========================================
+ Hits         2624     2628       +4
- Misses        695      699       +4

Impacted Files
Coverage Δ

zhaquirks/terncy/__init__.py
49.42% <44.44%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0ae68...fcdd76b. Read the comment docs.

Pull Request Test Coverage Report for Build 356346236

4 of 9 (44.44%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 78.99%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/terncy/init.py
4
9
44.44%

Totals

Change from base Build 353925433:
-0.07%

Covered Lines:
2628

Relevant Lines:
3327

💛  - Coveralls

@ilarrain I was able to pull a FW image for the Smart Dial from sniffing the traffic from the terncy hub. and worked with @walthowd to get into the form of an OTA file. If you're dial is not upgraded to the 26 file would you be willing to test it? mine got updated in the process of getting the FW.
Sorry for posting in the closed PR. you can ping me on discord, I'm tube there.


Change storefront homepage

Unable to find how to change storefront homepage from the documentation
Is it possible to do from dashboard ?
If code changes require, where exactly codes need to be changed ?

Take a look at AppRoutes.tsx. You'll want to adjust the component used for the Route with the baseUrl.

This is a storefront issue, please refer to the README in saleor-storefront repo.


Different Send On Behalf of

Can we have a different send as on what is being sent for example sales documents should goto<EMAIL_ADDRESS>or purchasing documents should goto<EMAIL_ADDRESS>[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9afe7e0d-9a4e-ad47-e04d-717e6315e768
Version Independent ID: 1f1e0f8d-9c90-0204-0480-45bc89fcbba4
Content: Set Up Document-Specific Email Content - Business Central
Content Source: business-central/ui-how-send-documents-email.md
Service: dynamics365-business-central
GitHub Login: @edupont04
Microsoft Alias: edupont

Hello Ben,
Thank you for your feedback! Since this question is not about the docs, I recommend that you vote for this suggestion: https://experience.dynamics.com/ideas/idea/?ideaid=5f574a76-47c1-e811-b96f-0003ff68dcaf


Hierarchical Topic Parsing

First of all, amazing work and thanks for making this open source!
Issue
I'm interested in obtaining hierachical topics after converting PDF -> MD. My naive attempt resulted in a document well extracted, but with a somewhat flat structure.

## About This Insurance

## A brief overview

Motor Vehicle Insurance provides cover for your car, motorcycle, trailer and horse float, anywhere in Australia. These types of vehicles are referred to as 'your vehicle' in this booklet. Under this insurance you can choose from three different levels of cover, and three types of policies.

## Levels of cover you can choose from

You can choose from three levels of cover, depending on your needs and your type of vehicle.

## You can choose from:

· Comprehensive for cars, motorcycles, trailers or horse floats.

· Third Party Fire And Theft for cars or motorcycles, or

· Third Party Property Damage for cars or motorcycles.

I used the out of the box pipeline for this extraction DocumentConverter().
Is there a way I could obtain hierarchical topics (#, ##, ###). What components of the pipeline can I change?
Thanks!

At the moment, the system is detecting only one level of section headers.

New capabilities will come, but for now, the system only recognises titles and the first level of section headers.

Can I know when this cool feature of header hierarchy is released?

Following because very interested


Detect noop missing from update request

https://www.elastic.co/guide/en/elasticsearch/reference/2.0/docs-update.html#_literal_detect_noop_literal

Not missing.  Right now we're treating it as a query string param because it's defined in the REST spec.  However, I think that's wrong and just opened https://github.com/elastic/elasticsearch/pull/16386.


Trin should use only one database

Currently, Trin uses two databases: RocksDB and SQLite. Originally only RocksDB was used. It was chosen because it's a very performant key-value store, and the portal network is a big key-value store. So that made sense. SQLite was later added once it became clear that RocksDB currently does not appear to be able to sort its set of data by an arbitrary function, which is necessary for finding the farthest piece of data stored.
There are multiple reasons that Trin should use one database instead of using both RocksDB and SQLite as it does currently.

Performance, as pointed out by @carver here: https://github.com/ethereum/trin/issues/91
Complexity involved with keeping DBs in-sync with each other in case of failure, as pointed out by @jacobkaufmann here: https://github.com/ethereum/trin/pull/230#discussion_r798106431

Recent discussion about this with @njgheorghita led to the idea of using only SQLite, and then re-evaluating our DB strategy in the future if SQLite is measured to be any kind of significant bottle-neck upon deployment of the network.

I agree that using two databases might not be ideal. But a couple of other thoughts come to mind now.

What are the consequences of out-of-sync dbs?
How often can we reasonably estimate that dbs will fall out of sync?
Could we just provide some util function that will clear the metadb, iterate over rocksdb, & reseed the metadb should they fall out of sync?
Ultimately, I wouldn't consider this that high of a priority. Performance does not appear to me to be one of our primary concerns. But as we get more features shipped, I'd love to see some benchmarks comparing a few of the possible strategies

On the one hand I see your point, on the other hand I think that leaving two DBs is actually more work for right now because we should then consider the excellent questions that you brought up above. As opposed to implementing the key/value get/set/delete functionality in SQLite that RocksDB is currently doing which is very straightforward.
RocksDB also makes up 54% of the crate binary data in the Trin binary according to building master currently: Downloaded 115 crates (15.0 MB) in 3.39s (largest was librocksdb-sys at 8.1 MB), which also might be a reason to remove it until we find that we need it.

Ok, well yeah I guess I'm sold. It doesn't seem that complex of a change, and can easily (as far as I can tell) be improved / refactored for performance when performance becomes high-priority. But, I guess there's one last blocker. TrieDB, the library @carver built for the state network to use relies on rocksdb here. On one hand, we're currently targeting the history network, so maybe we drop that import until we're focused on the state network, to benefit from dropping the rocksdb dependency. On the other, it does seem inevitable that we'll eventually end up using rocksdb in some manner, is it smart to move over to sqlite entirely now, even for some temporary short-term gains.
"it does seem inevitable that we'll eventually end up using rocksdb in some manner," - Ok, I guess this is also an assumption, but one I'm somewhat comfortable with.

Good point on TrieDB, that definitely changes things. Let's take a closer look at whether the necessary functionality mentioned above is possible with RocksDB.

https://github.com/btrask/sqlheavy looking at projects like this it must be possible
(this is drop in replacement for sqlite using for example rocksdb as storage engine)

SQLite was later added once it became clear that RocksDB currently does not appear to be able to sort its set of data by an arbitrary function, which is necessary for finding the farthest piece of data stored.

From looking into it a bit maybe I am missing something aggregates like TOTAL, COUNT iterate over the whole DB in SQLite hence they are O(n) TOTAL_DATA_SIZE_QUERY/TOTAL_ENTRY_COUNT_QUERY Could be replaced iterating over our whole rocksDB (which would be exactly what SQLite is doing with its storage engine, except with the overhead of SQL).
CONTENT_KEY_LOOKUP_QUERY/CONTENT_SIZE_LOOKUP_QUERY we can use Rocks get?
PAGINATE_QUERY https://stackoverflow.com/questions/63318315/sorting-by-value-in-rocksdb can be done with this and a rocksdb ``snapshot`?
XOR_FIND_FARTHEST_QUERY this is just a ORDER BY DESC which would just be n*log(n) which RocksDB iterator then a sort? This could easily be implemented in n*logn
If we only use rocks DB we won't need CREATE_QUERY, INSERT_QUERY, DELETE_QUERY since we already have that
TL:DR
Looking into it, it seems very possible to implement this functionality with RocksDB which is simply just a faster storage engine then SQLite, Our implementations for the replacements for the functions above would be the same time complexity (it isn't like sqlite has some special unknown sauce for Data Structures and Algo's).
So the main benefits of this would be

decreasing PortalStorage complexity since we would only need 1 DB again
none of the potential issues of using 2 key-store databases at once
lowering disk usage (we wouldn't have do everything twice)
responses to get what we need from PortalStorage since RocksDB is a faster engine

Ah ok so purge/paginate use sqlite for content_key, rocksdb doesn't include that right now. content_key can derive content_id used for xor.
So if we used content_key for rocksdb key then there would be no issue. For get() in rocksdb we already derive content_id there. Another solution would be union(content_key, data).
But maybe I should try and bench mark if total is faster doing it like this. (maybe a index is magic)
😵💫I need to look into things more before I talk.


Better integration with clients that aren't willing to use innerHTML

Right now fuzzy returns formatted string results like this:
"<b>t</b>est"

That doesn't work well with clients that don't insert into the DOM with innerHTML, like React. Need to find a better way

Check out PR #17 for an example


Testing setup with Test Cases tree view

Changes

Port test framework from Code for i
Add iProject and ProjectManager tests

To run tests:

Run the Extension Tests
Connect to an IBM i
Check results in Test Cases tree view or debug console

Please review PR #48 first


[unconfirmed] "Datum goedkeuring" presented to submitter should refer to date_confirmed

Currently it refers to date_reviewed, or at least it's incorrect according to secretary.
Sorry for the vague issue, this came up in a rushed team call and I'm heading out soon.

Thus, in technical terms, it should refer to date_confirmed. This is going to be a fun hunt in the code :P


Server not starting

Steps to reproduce:

Clone the repo
Set up python3.9 environment
pip install the requirements
Run python basic_table.py

I get the following error:
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
Traceback (most recent call last):
  File "/home/temp/web_spreadsheet/flask-gridjs/basic_table.py", line 29, in <module>
    app.run()
  File "/home/temp/web_spreadsheet/venv/lib/python3.9/site-packages/flask/app.py", line 922, in run
    run_simple(t.cast(str, host), port, self, **options)
  File "/home/temp/web_spreadsheet/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 1008, in run_simple
    inner()
  File "/home/temp/web_spreadsheet/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 948, in inner
    srv = make_server(
  File "/home/temp/web_spreadsheet/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 780, in make_server
    return ThreadedWSGIServer(
  File "/home/temp/web_spreadsheet/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 686, in __init__
    super().__init__(server_address, handler)  # type: ignore
  File "/home/temp/miniconda3/lib/python3.9/socketserver.py", line 452, in __init__
    self.server_bind()
  File "/home/temp/miniconda3/lib/python3.9/http/server.py", line 136, in server_bind
    socketserver.TCPServer.server_bind(self)
  File "/home/temp/miniconda3/lib/python3.9/socketserver.py", line 466, in server_bind
    self.socket.bind(self.server_address)
OSError: [Errno 98] Address already in use

I don't have anything running on port 5000 and I also checked multiple other ports using the -p parameter

Is this a problem specifically with this one application? Or with all Flask applications? Because I don't see how this can be an issue with my app.

Yes I think it was an issue with the version of Flask that I was using.
Upon upgrading that, the app started to work
Thanks!


Add plugin suggestion

I do not have found information on how the plugin selection process works here, so sorry if I do something wrong.
Anyway, I want to suggest the inclusion of zsh-syntax-highlighting and zsh-autosuggestions plugins inside oh-my-zsh. These are very useful plugins that bring some fish-like features on zsh.
Let me know if I can do something to help.

These plugins already have instructions on how to install them in Oh My Zsh, and bundling them in would suppose getting them up to date frequently. Thanks for the suggestion though


task: add OpenAPI spec validation as part of npm test

Three steps:

Add the package.json line(s) https://github.com/adobe/adobeio-cna-core-campaign-standard/blob/45c9cf1ae2cb0b262b637dcb21c13275d2b74cc9/package.json#L9
Add the script and modify as needed https://github.com/adobe/adobeio-cna-core-campaign-standard/blob/45c9cf1ae2cb0b262b637dcb21c13275d2b74cc9/bin/validate_spec.js
npm install --save-dev openapi-schema-validator

Added PR for this - https://github.com/adobe/aio-lib-target/pull/36


OOB communication (e.g. via pub/sub) and client-side queue filtering

Three desirable features:

Support for dynamically changing limits, i.e. Issue #4. PR #6 provides some support in this direction, but it would be nice to be able to go further.
Support for queue-based concurrency throttling at a per-worker level. Note that PR #6 actually already provides this, just less efficiently than it might otherwise be done.
Ability to globally disable/re-enable a particular queue, i.e. Issue #18.

I've listed the three of these in a single issue as the following two high-level enhancements would be applicable to both:

Support "pushing" data to the various workers. The obvious mechanism to accomplish this would be pub/sub, though the redis engine being used will need to effectively support these operations.
This would enable (1) from above and assist with (3).

Support for temporarily disabling queues on the worker end.
This would enable (2) from above and assist with (3).

Caveats
The big caveat here is that it's debatable how related to this project the above actually are. I've seen some evidence of existing support for "pushing" data to workers via the current UI; if such support exists and is sufficiently robust, then we'll actually need to do very little. If not, however, then things grow more complicated.
This caveat applies even more heavily to support for disabling queues on the worker end; the very granularity involved (job versus queue) is different from the rest of the repo. Really the reasons to include it in here would be a vague sharing of purpose and, probably more importantly, convenience.

Existing machinery for OOB communication:

Send: Sidekiq::Process#signal
Receive: Sidekiq::Launcher#❤

Could potentially take advantage of Sidekiq::redis_pool being a ConnectionPool to support pub/sub style communication, but it may not be worth it.

Substantially resolved by PR #21.


Task to find closest peers fails when no peer is connected

Version: 0.36.2

Platform: Linux odesenfans-desktop 5.13.0-28-generic 20.04.1-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux

Subsystem: Peer Routing

Severity: Low
Description:
The _findClosestPeersTask task from the peer routing module throws an error when no peer is connected. I am using the JS libp2p daemon for an application and I noticed errors in the logs when starting the daemon in debug mode:
  libp2p:peer-routing:err Error: not found
  libp2p:peer-routing:err     at requirePeers (/usr/lib/node_modules/libp2p-daemon/node_modules/libp2p/src/content-routing/utils.js:65:19)
  libp2p:peer-routing:err     at processTicksAndRejections (node:internal/process/task_queues:96:5)
  libp2p:peer-routing:err     at async PeerRouting.getClosestPeers (/usr/lib/node_modules/libp2p-daemon/node_modules/libp2p/src/peer-routing.js:165:5)
  libp2p:peer-routing:err     at async drain (/usr/lib/node_modules/libp2p-daemon/node_modules/it-drain/index.js:12:20)
  libp2p:peer-routing:err     at async PeerRouting._findClosestPeersTask (/usr/lib/node_modules/libp2p-daemon/node_modules/libp2p/src/peer-routing.js:87:7)
  libp2p:peer-routing:err     at async _runPeriodically (/usr/lib/node_modules/libp2p-daemon/node_modules/set-delayed-interval/src/index.js:17:7)

This is caused by a call to requirePeers without specifying min, which defaults to 1. This is not a huge issue because the task runs periodically anyway, but the error log seems unwarranted for the situation.
The easiest way to reproduce the issue is to use the JS daemon directly, even if the issue seems unrelated to it.
npm install --global<EMAIL_ADDRESS>DEBUG=libp2p* jsp2pd --listen /ip4/<IP_ADDRESS>/tcp/2220 --hostAddrs /ip4/<IP_ADDRESS>/tcp/2222
# Wait for the error log

@odesenfans : closing for now since haven't received confirmation that it's an issue in the latest version.  Feel free to reopen if it is.


Improve start up time for Interactive

fixes  #3306
It used to take around 3.5 second to load Interactive. This PR will decrease that time to about 1.5 seconds.
Uses a cached command table while loading the new command table and then refreshes the interactive shell with that command table.

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

(see Authoring Command Modules)

Codecov Report

Merging #3887 into master will decrease coverage by 0.12%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
- Coverage   70.93%   70.81%   -0.13%
==========================================
  Files         428      429       +1
  Lines       27048    27077      +29
  Branches     4119     4123       +4
==========================================
- Hits        19187    19174      -13
- Misses       6608     6655      +47
+ Partials     1253     1248       -5

Impacted Files
Coverage Δ

...zure-cli-interactive/azclishell/gather_commands.py
51.75% <ø> (ø)
:arrow_up:

...modules/azure-cli-interactive/azclishell/layout.py
43.13% <0%> (-0.43%)
:arrow_down:

...dules/azure-cli-interactive/azclishell/__init__.py
100% <100%> (ø)
:arrow_up:

...azure-cli-interactive/azclishell/_dump_commands.py
17.17% <20%> (-0.66%)
:arrow_down:

...odules/azure-cli-interactive/azclishell/threads.py
30.55% <30.55%> (ø)

...s/azure-cli-interactive/azclishell/az_completer.py
53.39% <53.84%> (-6.33%)
:arrow_down:

...nd_modules/azure-cli-interactive/azclishell/app.py
31.47% <54.54%> (+0.27%)
:arrow_up:

...dules/azure-cli-interactive/azclishell/az_lexer.py
84.61% <60%> (-15.39%)
:arrow_down:

...c/azure-cli-testsdk/azure/cli/testsdk/utilities.py
72.72% <0%> (-13.64%)
:arrow_down:

...ules/azure-cli-interactive/azclishell/argfinder.py
31.57% <0%> (-10.53%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba0a0b...3bc8660. Read the comment docs.

Updated

@derekbekoe please take a look the mechanism itself.

@derekbekoe would you please take another look?


Give a Support of Ubuntu 20.04

By default, Google Colab provide Ubuntu 18 LTS. The only way to get any version above that would require to set up an upgrade script, which then will take much more time to download the new version and upgrade the entire OS.

Yeah but there are so many files in ubuntu 18 lts which are no longer supported and tho some errors so thats why i open this issue

These are the commands to upgrade to latest LTS
sudo apt-get update -y && sudo apt-get upgrade -y
sudo apt-get install update-manager-core
sudo do-release-upgrade

I tried but not working need to change the whole script

Why don't you try using docker and using your desired version inside of docker container
This may make colab lag a bit
But i think This is only solution
Or wait for Google to upgrade their system to ur version ( not sure if they will do it ) @Hunter-XD try for it 👍


Set quorum to tolerate 2 failures for validator list of 6 members.

Without this PR, when moving from 5 to 6 validators, we will tolerate only 1 failure instead of 2. Quorum will go from 3/5 to 5/6. This fixes it so that the latter will be 4/6 (tolerating 2 failures. In each case, quorum for 7 and above allow at least 2 failures, so no modifications need to be made.

Codecov Report

Merging #2246 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2246   +/-   ##
========================================
  Coverage    70.12%   70.12%
========================================
  Files          689      689
  Lines        50800    50800
========================================
  Hits         35621    35621
  Misses       15179    15179

Impacted Files
Coverage Δ

src/ripple/app/misc/impl/ValidatorList.cpp
83.33% <100%> (ø)
:arrow_up:

src/ripple/protocol/impl/STVar.cpp
85.71% <0%> (-2.6%)
:arrow_down:

src/ripple/protocol/impl/Serializer.cpp
69.96% <0%> (-0.35%)
:arrow_down:

src/ripple/basics/DecayingSample.h
86.11% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5490e...249781d. Read the comment docs.

Here's the unit test that should be updated. Unfortunately it wasn't checking things properly, which is why tests were still passing despite the change.
https://github.com/wilsonianb/rippled/commit/1cd6ff460dd24bd6bba7dcc55a7604a0cc616ccf

@wilsonianb fixed

Merged as dffb999efb8285334fe88d95011c0c17e3a352cd


Latest fsnotify API

For more details
https://groups.google.com/forum/#!msg/golang-nuts/G5VgniBzSSE/VlwFwep_juUJ

Hi @nathany,
Thank you for standardizing the fsnotify API to make it better for the future.
When you have time, could you please take a quick look at 81695717e6dcb6c040cbaf54d179c2c49202a5d1 to make sure I did the fsnotify.v0 → fsnotify.v1 switch correctly?  Many thanks for your help!  :-)

@anthonyfok Looks good to me. Thanks!

@nathany Thank you!  :-)


chore: CI use orka for macos agents

We are in the transition to use ephemeral workers.
TL;DR
Moved macos build from github actions to the martix build with orka in Jenkinsfile

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-05T15:42:04.178+0000

Duration: 6 min 17 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
16

Skipped
0

Total
16

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


bug: trailing search character corrupt

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.0 (appimage)
Operating system/version
Ubuntu 23.04
Describe the bug
When searching, the first character following a match is shown with a different color and becomes a different character. After hitting enter to complete the search, the search matches are shown properly.
I'm using UbuntuMono Nerd Font but have also tried other monospaced fonts including JetBrains Mono Nerd Font (all the same).
I tried changing the color scheme from the default to gruvbox but the issue remained (just a different color).
I've tried a full update of Lazy and Mason as well as a clean re-install with no changes to the base config (today).
I'm using Kitty but observed the same issue in the default Ubuntu Gnome terminal.
Note the search below for fi as an example:

Happy to try any suggestions or help debug further. Thanks for the great project!
Steps To Reproduce

Clean install
Search for fi on dashboard (though not specific to the dashboard or search term)

Expected Behavior
Trailing character should not highlight/change.
Repro
No response

Those are jump labels from the flash.nvim plugin. In your screenshot, typing j would have jumped to config


Revisiting whether ion_schema should re-export ion_rs

The current situation:
If you're already using ion_rs, and then you want to start using ion_schema, you may have to change a lot of your imports from ion_rs:: to ion_schema::external::ion_rs::. As long as the versions are the same, this should be a fairly mechanical change that an IDE can handle for you. If the versions are different, then it may be more complex to switch.
In addition, whenever there is a new version of ion_rs, and you are using ion_schema, you have to wait for ion_schema to pick up the latest version of ion_rs and release a new version of its own before you can get the benefits of the latest version of ion_rs.
Some alternatives to consider:
These are just ideas. I'm not sure of the feasibility of all of them.

Stop exporting ion_rs in ion_schema
Make ion_rs export a gated feature in ion_schema
Make ion_schema a feature in the ion_rs crate

This might not be a possibility while both of the libraries are at a 0.x version, but I think it is something to re-evaluate before releasing a 1.0.0 version of either one of them.

+1 for dropping the re-export of ion_rs.  I think that the use of ion_schema in applications that don't also directly use ion_rs would be rare.  Please don't lock us into a specific version of ion_rs and require us to use ion_schema__external::ion_rs  just so can also use ion_schema.

@dlurton do you care to opine on any of the alternatives I've suggested or any ideas you might have?

-1 for: "Make ion_rs export a gated feature in ion_schema" -- this doesn't seem to help the issue at all.
Between the other two, "Stop exporting ion_rs in ion_schema", "Make ion_schema a feature in the ion_rs crate"--either of these I think would be a lot better and it's just a matter of packaging.
It's not good to force the application that wants to use ion-schema-rust to use ion_schema::external::ion_rs, but it's kind of required right now and leads to one of two somewhat unhappy scenarios when reading Ion from external sources:

We can parse the payload into an Element from ion_schema::external::ion_rs, perform validation with ion_schema, and then the use the same Element instance to map to internal domain objects.  This is sub-optimal because now we're stuck with whatever potentially out of date version of ion_rs that ion_schema re-exports.  This isn't just limited to mapping to internal domain objects, but lots of other code that manipulates Element instances.
Alternatively, we could parse the payload twice--once to ion_schema::external::ion_rs for ISL validation, and again using  regular ion_rs::value::owned::Element, but this occurs obvious additional overhead.

Would like to express support for dropping re-exports. Was bitten by this issue, when upgrading from older versions of ion_rs and ion_schema. The solution (change all imports to ion_schema::external::ion_rs:: seemed quite counter-intuitive).
I don't fully understand why the re-export is necessary. Is it just go guarantee version compatibility? Surely this is solvable with pinning/appropriate ranges in Cargo.toml?


Pipette Gen2: Inform User on File Overview if Pipette Incompatible

As a Run App user, I would like to know if the pipette specified in my protocol is incompatible with the pipette attached to my robot.
Acceptance Criteria

[ ] If pipette specified in protocol and pipette attached to robot are incompatible, display "Required pipette is missing" in the "Required Pipettes" card on the "File Overview" page.

Note this is an existing alert message.

Compatibility
Note pipettes are incompatible if:

Protocol specifies Gen2 pipette and robot has Gen1 pipette
Protocol specifies a P50 Gen1 pipette and robot has any Gen2 pipette
Protocol specifies a P20 pipette Gen2 pipette and robot has any Gen1 pipette
Gen2 pipette specified in the protocol is different than the Gen2 pipette attached to the robot
Gen1 pipette specified in the protocol is different than the Gen1 pipette attached to the robot

Full list of compatibility here:
https://docs.google.com/spreadsheets/d/1M6azQXZocWTqnEZDQ1Bpp9V1F9Fn86otdd4Go_LTIlQ/edit#gid=0
Design
https://app.zeplin.io/project/5aa97729db58a2192f10d0d6/screen/5d0217088ac43c5dd4da8ef9

Covered by #3432 , ticket no longer needed.


{network}Add hint to public-ip create with standard sku

Description

Add hint to public-ip create with standard sku
Description of the new feature
In the latest profile and the profiles that use the same api-version as latest profile, the default public IP used for creation with "az network public-ip create" will be changed from Basic to Standard. In advance of eventual breaking change, would like to add warning for users.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

network


Discriminator-Property not working in allOf

What version of Ajv are you using? Does the issue happen if you use the latest version?
8.12.0
JSON Schema
{
  "type": "object",
  "discriminator": {
    "propertyName": "type"
  },
  "oneOf": [
    {
      "allOf": [
        {
          "$ref": "#/components/schemas/A"
        },
        {
          "type": "object",
          "required": ["type"],
          "properties": {
            "method": {
              "type": "string",
              "enum": ["a"]
            }
          }
        }
      ]
    },
    {
      "allOf": [
        {
          "$ref": "#/components/schemas/B"
        },
        {
          "type": "object",
          "required": ["type"],
          "properties": {
            "method": {
              "type": "string",
              "enum": ["b"]
            }
          }
        }
      ]
    }
  ]
}

When accessing the schema from above, I get this error:
Error: discriminator: oneOf subschemas (or referenced schemas) must have "properties/type"
For me this Schema seems to be valid, but there seems to be a problem with this nested oneOf / allOf structure.
Is there a way to solve this, because I would like to stay with this Schema which is autogenerated from the backend.

Looks like a duplicate of #2261

You may need to add the definitions for "#/components/schemas/A" and "#/components/schemas/B" to your example, because currently there is no property named type. You have a property named method, was this a typo?

Yes, it's a limitation, as documented. For it to work it should have discriminator tag property defined on the top level in subschema.

I encountered the same issue and I understand the complexity of solving this issue. Could it be possible to add an arbitrary property to discriminate ?
{
  "type": "object",
  "discriminator": {
    "propertyName": "type"
  },
  "oneOf": [
    {
+      "discriminatorValue": ["a"],
      "allOf": [
        {
          "$ref": "#/components/schemas/A"
        },
        {
          "type": "object",
          "required": ["type"],
          "properties": {
            "method": {
              "type": "string",
              "enum": ["a"]
            }
          }
        }
      ]
    },
    {
+      "discriminatorValue": ["b"],
      "allOf": [
        {
          "$ref": "#/components/schemas/B"
        },
        {
          "type": "object",
          "required": ["type"],
          "properties": {
            "method": {
              "type": "string",
              "enum": ["b"]
            }
          }
        }
      ]
    }
  ]
}


Expose ability to reconnect

I'd like to be able to get the client to reconnect to the server. Our use case is to rebalance connections to a cluster that's behind HAProxy.

How are you using the nats client? It will reconnect out of the box, however be aware it has a few reconnect settings you may want to switch, like MaxReconnect and ReconnectWait. If you are having an issue, you may be hitting the default max reconnect number.

One other thing to add... nats behind HAProxy, are you running it in clustered mode?  If not, it will produce some odd issues as not all clients will be on the same system. But with clustered, haproxy really isn't necessary. You can simply configure the clients with the list of all the NATS servers, and have them pick a random one rather than just the first one.

We want to have the ability to reconnect so we can rebalance the connections to another gnatsd server. A disconnect won't preserve the subscriptions.
We are running it in clustered mode. I have a fork that lets us dynamically add and remove routes to the cluster, so we can dynamically scale gnatsd up and down. HAProxy does the balancing and the config is automatically generated and updated via Marathon.
The problem comes when the machines that gnatsd are on die for some reason, and the clients all reconnect to the existing one, but when the replacements are spun back up, the connections are unbalanced to the one that survived.

Were you hitting scaling limits with gnatsd? Although rebalancing can help and it avoids clumping on a single gnatsd server, can also be clumped or gated with haproxy itself.
While haproxy just proxies data, it may be that the latency from the added network hop ends ip costing more than an unbalanced set of clients.

Not yet, but I suspect we will at some point.
Our setup has haproxy running on every Mesos worker, so haproxy is always
on localhost, then it picks the least connections for a backend. This
doesn't guarantee that it gets sent to the least loaded backend as haproxy
doesn't share state with others but in our tests, it has been good enough.
On Saturday, March 7, 2015, Ken Robertson<EMAIL_ADDRESS>wrote:

Were you hitting scaling limits with gnatsd? Although rebalancing can help
and it avoids clumping on a single gnatsd server, can also be clumped or
gated with haproxy itself.
While haproxy just proxies data, it may be that the latency from the added
network hop ends ip costing more than an unbalanced set of clients.
—
Reply to this email directly or view it on GitHub
https://github.com/apcera/nats/issues/50#issuecomment-77591542.

--
Sent from my iPhone.

We will add rebalancing via gnatsd at some point in the future, most likely when we introduce the gossip protocol for clustering that will also transfer to the clients.


Coexistence of bazel and go with travis

This change is

It ensures continued interop between bazel and go
Regards,
Sent from my Motorola Next
Mandar U Jog

On Jan 7, 2017, at 10:35 PM, Douglas Reid<EMAIL_ADDRESS>wrote:
@douglas-reid commented on this pull request.
In .travis.yml:

@@ -34,7 +33,11 @@ before_install:

cat .bazelrc.travis .bazelrc.orig > .bazelrc

script:

bazel --output_base=${HOME}/bazel/outbase test //...

#- bazel --output_base=${HOME}/bazel/outbase test //...

bazel test //...

bin/bazel_to_go.py

ls -l ${TRAVIS_BUILD_DIR}

go test -v ./pkg/... ./adapter/... ./cmd/...
Is re-running the tests critical to the overall function of the linters?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Question regarding id and speed up of group search

Is the id indexed by default or is that something that needs to be done. My group search is very slow...like 18 seconds over 2 collections of sizes 420k and 60k approx.
is the group_by in the outer collection supposed to be indexed?? and on which field does it join on the inner lookup collection??
heres my code
search_results=client.search_groups(
collection_name="us_fto_collection",
    with_payload = True,

    search_params=models.SearchParams(
        hnsw_ef=128,
        exact=False
    ),
    group_by="file_uuid", # Path of the field to group by
    limit=3,                # Max amount of groups
    group_size=1,           # Max amount of points per group
    query_vector=patent_embedding,
    # Lookup parameters
    with_lookup=models.WithLookup(
        # Name of the collection to look up points in
        collection="us_fto_collection_master",

        # Options for specifying what to bring from the payload
        # of the looked up point, True by default
        with_payload=["file", "file_uuid"],

        # Options for specifying what to bring from the vector(s)
        # of the looked up point, True by default
        with_vectors=False,
    )
)

hello @nairajay2k
you need to create payload indices manually
values from group_by field will be matched with point.id in your lookup collection

Do I need to index id field also?
On Thu, Sep 14, 2023 at 6:29 PM George @.***> wrote:

hello @nairajay2k https://github.com/nairajay2k
you need to create payload indices manually
values from group_by field will be matched with point.id in your lookup
collection
—
Reply to this email directly, view it on GitHub
https://github.com/qdrant/qdrant-client/issues/288#issuecomment-1719406777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6XWJ565PFHBYJV5E3VUVDX2L5URANCNFSM6AAAAAA4TOBCKY
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Regards
Ajay
8762803277

No


Closed issue 277 is still an issue

Fixed by https://github.com/alexa/ask-toolkit-for-vscode/pull/231

This change will go out in the next release.


Update site links to dirs

Changes the linkml generator to move classes, enums and slots into their own directories like they do for types.  This then allows for the mkdocs integration to create a better menu structure on the left hand navigation menu.  Much similar to the structure that is given to the overall index document that is generated.  The schema base document that is generated will be generated into a _Home folder to allow for it to appear at the top of the left hand navigation menu generated by mkdocs.

Should enable the left hand menu to look something like this

Yes the command line trigger needs to be worked out, so it can be triggered as a toggle.  I presumed that the deploy failed as I tried to do it from the branch rather than main, just to work out if it would work and was then going to revert it back.  I have built locally and seems to work ok.  The error message seems to back that up - "Branch "update-site-links-to-dirs" is not allowed to deploy to github-pages due to environment protection rules."  If we can approve this for now we can merge and then look to sort out the flags issue next.  I have raised https://github.com/alphagov/di-identity-vocab/issues/28 to track.


limit of batch size

Hello,
thank you so much sharing such a great framework to consolidate and streamline the prediction pipeline.
As I'm trying to implement in-house prediction workhorse, I got into a situation how much I can speed up by batching the peptide sequences at once without breaking the model. I tried my best but I don't see much of those recommendation or benchmark for it. Do you have a general suggestion or estimation? Also, are there any parameters I need to adjust based on CPU and GPU memory sizes?
Thank you.
best,
heejong

Hi,
Thanks for reaching out! The batch size you can support depends on the model & the GPU (VRAM) you are using. We developed Koina on a GTX 1080 with 8 GB of VRAM. With the current batch size, we tried to balance stability and performance (for this amount of VRAM). If you increase the batch size, you will reach a point where calls to one model work fine, but concurrent calls to multiple models can cause the service to crash.
Without knowing more about which model you want to optimize, which hardware you want to run it on, and how you use it, any recommendations are tricky.
Best,
Ludwig

Hi Ludwig,
Thanks for the explanation.
I'm currently testing with one A100 80G VRAM with 1000 peptides and 10,000 peptides in one batch. It seems regardless of batch size, it's at 1-2 second per 1000 peptides if I understood correctly. Also, the gpu core usage only hits 4% with that. I'm not sure what's the best way to parallelize the model to speed up more than what I observed. Should I just fire up more docker container within single gpu until it hits the max memory or I should only have one container per gpu?
Thank you.
best,
heejong

We haven't tested yet how multiple containers on one GPU behave under heavy load. They might get into each others way.
One thing you can try out is to increase the instance group setting of the models

We have yet to test how multiple containers on one GPU behave. They might get into each other's way, and you would need to run a load balancer to distribute the load between the containers. But it is probably the easiest option to increase performance.
It's surprising that you see the same performance regardless of batch size. We observed that performance improves with increasing batch size. Did you increase the batch size of all models or only the main ensemble? In the latter case, your observation would make sense since Koina internally splits the requests into batches of 1000 to adhere to the limits of the "sub-models".
You could also try to increase the count within the instance_group setting of the model (see below). You would also need to do this for every part of the pre-and postprocessing step of the model. Considering your GPU, the core model is likely not the limiting factor. Increasing the count of pre- and postprocessing instances should give you a bigger performance boost.
  instance_group [
    {
      count: 2
      kind: KIND_GPU
    }
  ]

Thank you so much for your explanation.
So, basically I need to get inside of the container and manually edit the config file for each model?
For example, if I were to use this model, AlphaPeptDeep_ms2_generic, then I need to edit the following?
https://github.com/wilhelm-lab/koina/blob/d72be952c991ec27258edc9b7319329b6f391edb/models/AlphaPept/AlphaPeptDeep_ms2_generic/config.pbtxt
Also, in this particular case, I don't see the instance_group while I see it in other model config files. I wonder it's because the framework is designed around this model so pre-/post-processing is bypassed?
Thank you so much.
best,
heejong

Yes, that's why the easier option is to spawn multiple containers on the same GPU and host a separate load balancer. To check how they would interact with each other. Increasing the batch size for each model is, for sure, a more manual approach, but it is almost guaranteed to be more stable.
The reason you don't see instance groups for this model is that the config is autocompleted to fill this in.
Here is the autocompleted instance_group config:
"instance_group": [
{
"name": "AlphaPeptDeep_ms2_generic",
"kind": "KIND_GPU",
"count": 1,
["gpus"](https://koina.proteomicsdb.org/v2/models/AlphaPeptDeep_ms2_generic/config): [
0
],
"secondary_devices": [],
"profile": [],
"passive": false,
"host_policy": ""
}
],

Thank you for your explanation.
I changed the batch_size from 1000 to 10000 for all AlphaPept config.pbtxt inside of the container that I'm currently using and found no performance boost so I would like to try the instance_group count parameter. Unfortunately, I'm having a little bit of issue to locate where to go to change the setting to tweak the autocompleted config for AlphaPept. I would really appreciate if you can guide me where to look for and what to change.
Thank you so much.
best,
heejong

Since there are different autocomplete behaviors per backend, I don't think there is a central place to adjust default values or the general autocomplete behavior. You would need to adjust this for every model individually.


Introduce explicit adversaries

Ideally we would test the protocols with explicit adversaries. This is a huge topic in its own right however. There is some work by the researchers on defining "ideal" adversaries; if this research comes to something we can use, that would be a good starting point for this ticket. Otherwise, this might be too ambitious for now. Bear in mind that the network problems that we do extensively test are already a kind of adversary from the point of the crypto, so we already cover this to some extent.
One thing we should check at least is that if a node produces an invalid block, the other nodes properly disconnect from it.

@nfrisby does the work around Genesis testing cover any of this?


[BUG] Document-level security not working with nested documents

Describe the bug
I have an index with some nested documents and am trying to use Document-level security feature.
When I'm trying to perform a simple search request
_search?pretty=true&q=*

I get this error:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_state_exception",
        "reason" : "Parent query must not match any docs besides parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=1"
      }
    ],
    "type" : "search_phase_execution_exception",
    "reason" : "all shards failed",
    "phase" : "query",
    "grouped" : true,
    "failed_shards" : [
      {
        "shard" : 0,
        "index" : "my-index",
        "node" : "pWhrtIQPRdCWuw6hyeGCwQ",
        "reason" : {
          "type" : "illegal_state_exception",
          "reason" : "Parent query must not match any docs besides parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=1"
        }
      }
    ],
    "caused_by" : {
      "type" : "illegal_state_exception",
      "reason" : "Parent query must not match any docs besides parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=1",
      "caused_by" : {
        "type" : "illegal_state_exception",
        "reason" : "Parent query must not match any docs besides parent filter. Combine them as must (+) and must-not (-) clauses to find a problem doc. docID=1"
      }
    }
  },
  "status" : 500
}

To Reproduce
Steps to reproduce the behavior:

Start Opensearch and Opensearch-dashboards using docker-compose with docker-compose.yml using 1.0.0-beta1 images version
Create index with one text and one nested field

PUT my-index
{
  "mappings": {
    "properties": {
      "field1": {
        "type": "text"
      },
      "field2": {
        "type": "nested",
        "properties": {
          "field3": {
            "type": "text"
          }
        }
      }
    }
  }
}

Put several documents to the index:

POST my-index/_bulk
{ "create" : { "_index" : "my-index", "_id" : "1" } }
{ "field1": "a"}
{ "create" : { "_index" : "my-index", "_id" : "2" } }
{ "field1": "b", "field2": [    {      "field3": "1"    },    {      "field3": "2"    }  ]}
{ "create" : { "_index" : "my-index", "_id" : "3" } }
{ "field1": "b"}
{ "create" : { "_index" : "my-index", "_id" : "4" } }
{ "field1": "a","field2": [    {      "field3": "1"    },    {      "field3": "2"    }  ]}

Create role in Opensearch-dashboards with read index-permission + this Document-level security query

{
  "bool": {
    "must_not": {
      "match": {
        "field1": "a"
      }
    }
  }
}

Create user and map it to the role
Perform simple search request by this user

_search?pretty=true&q=*

See the error described above

Expected behavior
This search request should return all documents, except those which were filtered out by the DLS-request.
So 2 documents are expected:
"hits": [
      {
        "_index": "my-index",
        "_type": "_doc",
        "_id": "2",
        "_score": 0,
        "_source": {
          "field1": "b",
          "field2": [
            {
              "field3": "1"
            },
            {
              "field3": "2"
            }
          ]
        }
      },
      {
        "_index": "my-index",
        "_type": "_doc",
        "_id": "3",
        "_score": 0,
        "_source": {
          "field1": "b"
        }
      }
    ]

Plugins
Nothing special except the default plugins
Host/Environment (please complete the following information):
docker images opensearchproject/opensearch:1.0.0-beta1 and opensearchproject/opensearch-dashboards:1.0.0-beta1
Additional context
I also tried this on OpenDistro for ElasticSearch docker images. Specifically, amazon/opendistro-for-elasticsearch:1.2.1 and amazon/opendistro-for-elasticsearch:1.9.0 (and corresponding Kibana) images.

Started discussion on this issue here:
https://discuss.opendistrocommunity.dev/t/document-level-security-fails-with-nested-documents/6248

Lucene is used to parse the document-level security query. For this to work for nested documents, you must include a field that identifies the parent document as a parent or it will throw illegal_state_exception.
Like this example discussed here. https://discuss.opendistrocommunity.dev/t/document-level-security-fails-with-nested-documents/6248
{
  "bool": {
    "must": [
      {"exists": {
        "field": "field1"
         }
      }
    ],
    "must_not": [
      {"match": {
        "field1": "a"
      }}
    ]
  }
}

This is actually not a bug but an implementation by Lucene.
Will close this issue for now, feel free to reopen it if there are any questions or correct me if I am wrong.

Sorry, but the problem is that [simple DLS-query + some existing nested documents in my index] => just breaks the "q=*" query. This query (at least from the client-side) doesn't deal with nested documents at all (and neither does DLS-query).
So this looks like a bug.
Thank you for the link to the related discussion on discuss.opendistrocommunity.dev but actually it was me who started that discussion ^_^.
The workaround mentioned there does work indeed. But, as I said in that discussion, I don't understand why that workaround is needed at all. I glanced over the relevant Lucene source and there is already some code which deals with nested docs if they exist in the index https://github.com/opensearch-project/security/blob/2b69d9c84d807fc68b3ad9770d8bb75f6b99e725/src/main/java/org/opensearch/security/configuration/DlsQueryParser.java#L144
P.S.
Github doesn't allow me to reopen this issue, could you please reopen it @andy840314

Thank you for the link to the related discussion on discuss.opendistrocommunity.dev but actually it was me who started that discussion ^_^.

Yes, i know you started the discussion. Sorry forgot to mention that. Just want to mention the example in the discussion.
I am wrong about my comments above. There is definitely an issue since this happens when using only must_not clause.
The exception comes from here.
https://github.com/opensearch-project/security/blob/2b69d9c84d807fc68b3ad9770d8bb75f6b99e725/src/main/java/org/opensearch/security/configuration/DlsQueryParser.java#L161
It could be that parentDocumentsFilter contains all non-nested docs so when you use must_not clause only, it also matches nested docs and this results in the exception.
If you provide must: exist: field: "field1", it matches only the non-nested docs so the query works.

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


Ionic Capacitor

const loader = new Loader(apiKey, options);
"There is no application set to open the URL capacitor://maps.googleapis.com/maps/api/js?...."
Change :
return //maps.googleapis.com/maps/api/js?${parameters.join('&')};
To:
return https://maps.googleapis.com/maps/api/js?${parameters.join('&')};

@niojihy can confirm this fixes the issue in a capacitor app. I made a fork if you want to use it in the meantime yarn remove google-maps && yarn add google-maps-cap

Url is loading fine in Android WebView Capacitor, but iOS UIWebView is not loading. You need to use @niojihy fork, or switch to @googlemaps/js-api-loader.

Thanks, fixed in version 4.3.3


Move the send_html_email function somewhere more visible

I noticed that send_html_email is in the utils/misc.py file. I think that may lower awareness of this function too much, when we really should try to raise awareness of it. IMO, it's really, really useful and should be our default way of sending emails - everyone expects HTML emails these days. I'd recommend at least moving it to utils/emails.py or maybe even into the core Django app so it's more readily visible.
Open to suggestions. Maybe Django has a better built-in email sender nowadays?

Addressed in PR 76 https://github.com/thinknimble/tn-spa-bootstrapper/pull/76

This has been fixed. closing issue now.