[INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions

Prepare a Pull Request

Fixes #5066

Motivation
Remove the LightGroup-related workflow listener and definitions.
Modifications

Merge LightGroupXxxListener into InitGroupXxxListener and UpdateGroupXxxListener.
Merge XxxLightGroupWorkflowDefinition into XxxGroupWorkflowDefinition.

Verifying this change

[x] This change is already covered by existing tests, such as:
InlongGroupProcessOperationTest
CreateGroupWorkflowDefinitionTest
WorkflowServiceImplTest

Documentation

Does this pull request introduce a new feature? (no)

@healchow
1.Please added background and benefits of modification.
2.Refactoring design needs to be added.

@healchow 1. Please added background and benefits of modification. 2. Refactoring design needs to be added.

Added in the parent issue, see #5029.

@woofyzhao @gong PTAL, thanks.


[BangleJS 2] Notifications don't appear to be cleared.

Not sure if this is an issue with Gadgetbridge or BangleJS 2, but notifications on watch don't appear to ever be cleared.
And given they seem to be ordered from top oldest to bottom newest in the menu, that's going to become more of an issue the more notifications that don't get removed.

This is using the Gadgetbridge app on Bangle.js 2, or the Android one I guess?
Maybe the notify- event isn't being handled properly? I think there's also an argument that all notifications should be cleared when Gadgetbridge/iOS disconnects. iOS definitely re-sends them at startup.
Also, feel free to report issues, but this is the 3rd one in 30 minutes - given the load I'm currently under with shipping I can't respond to everything so unless someone else wants to jump on these, most will have to wait until the remaining Bangles are out the door.

@gfwilliams The setup is Gadgetbridge on phone, gadgetbridge and message (with or without the android app) on the BangleJS 2.
No worries, I just like to report them before I forget myself, no rush at all. I might even take a look myself if I get some free time this weekend since I know C/JS, but not sure how likely that'll be.

Ok, thanks! I believe the 'messages' app won't actually do anything useful without the Android/iOS apps installed - so that could be causing some issues I guess? But I'll look into it here when I get a moment.

Notifications now get cleared on disconnect, so I think that's ok - but good point about message ordering - I'll tweak that


Update Constants.java

Pull request

[ ] I have read and agreed to the code of conduct.
[ ] I have read and complied with the contributing guidelines.
[ ] What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
[ ] I have tested all of my changes.

Added/Changed
What did you add and/or change for this.
Feature
If this is a new feature, why should we add it to the bot.

jenkins approve

jenkins whitelist

Don't pr one line prs


Submodule versus npm

I'm pretty new to node, but was wondering why jasmine-reporters uses a submodule instead of package dependency?  Makes the library difficult if you need to bring the source code in house for code-reproducibility issues.  Submodules force a hard link to an external resource, which may or may not be available.
Thanks,
Sean

jasmine-reporters was not originally a node package
the included submodule is not a dependency for using jasmine-reporters

the submodule allows you an alternative way of running the specs (specs can now run via PhantomJS or Rhino or Node)

I actually removed the submodule and dependency on the library it included even for running tests via PhantomJS last night, I just didn't tag or do a new release

I will happily do so

0.2.1 has been tagged and pushed to npm

Very much appreciated.  I wish my co-workers were as responsive.
On Fri, Mar 9, 2012 at 5:01 PM, Ben Loveridge
<EMAIL_ADDRESS>wrote:

0.2.1 has been tagged and pushed to npm

Reply to this email directly or view it on GitHub:
https://github.com/larrymyers/jasmine-reporters/issues/16#issuecomment-4425562


refactor_openjdk_release_tool does not support jdk17 parameter

13:45:45  Scheduling project: build-scripts » release » refactor_openjdk_release_tool
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] End of Pipeline
ERROR: Value for choice parameter 'VERSION' is 'jdk17', but valid choices are [jdk16, jdk15, jdk14, jdk13, jdk12, jdk11, jdk10, jdk9, jdk8]

I've updated the Jenkins job.


failed calling webhook "issuers.admission.certmanager.k8s.io"

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Upgraded rancher from v2.2.8 to v2.2.9
First I did follow https://rancher.com/docs/rancher/v2.x/en/installation/options/upgrading-cert-manager/ to upgrade cert-manager (UPGRADING CERT-MANAGER WITH INTERNET ACCESS), everything worked fine, no errors at all.
Then when upgrading rancher...
Followed the steps from https://rancher.com/docs/rancher/v2.x/en/upgrades/upgrades/ha/
helm repo update
helm repo list
helm fetch rancher-stable/rancher

and finally when running:
helm upgrade rancher rancher-stable/rancher -f values.yml
values.yml:
hostname: [[ -- ]]
ingress:
  tls:
    source: letsEncrypt
letsEncrypt:
  email: [[ -- ]]

Result:
UPGRADE FAILED
Error: failed to create resource: Internal error occurred: failed calling webhook "issuers.admission.certmanager.k8s.io": the server is currently unable to handle the request
Error: UPGRADE FAILED: failed to create resource: Internal error occurred: failed calling webhook "issuers.admission.certmanager.k8s.io": the server is currently unable to handle the request

It says UPGRADE FAILED but rancher did upgrade to v2.2.9
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): UI

Rancher
v2.2.9

User Interface
v2.2.98

Helm
v2.10.0-rancher11

Machine
v0.15.0-rancher8-1

Installation option (single install/HA): HA (1 node)

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory): VPS 4gb ram 4gb cpu
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:16:51Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Helm version

Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}

Docker version (use docker version):

Client: Docker Engine - Community
 Version:           19.03.4
 API version:       1.40
 Go version:        go1.12.10
 Git commit:        9013bf583a
 Built:             Fri Oct 18 15:52:22 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.4
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.10
  Git commit:       9013bf583a
  Built:            Fri Oct 18 15:50:54 2019
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.2.10
  GitCommit:        b34a5c8af56e510852c35414db4c1f4fa6172339
 runc:
  Version:          1.0.0-rc8+dev
  GitCommit:        3e425f80a8c931f88e6d94a8c831b9d5aa481657
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Hi, I can confirm I observe the same message when installing a brand new rancher 2.2.9
I didn't saw this message in 2.2.8


Variadic argument validation

Add a parameter to the VariadicArgument type to make it more consistent with the Argument type.

@kylef any news on when you'd be able to release 0.6? Would be nice to be able to use the new features in SwiftGen.

@djbe I'll be traveling today, I'll try push a release out tomorrow or Monday.


Typeahead search: button can't be triggerd

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 241af5f4-3d0b-5d00-4ecf-94681543159d
Version Independent ID: 241af5f4-3d0b-5d00-4ecf-94681543159d
Content: Typeahead search in Adaptive Cards - Teams
Content Source: msteams-platform/task-modules-and-cards/cards/dynamic-search.md
Service: msteams
GitHub Login: @Rajeshwari-v
Microsoft Alias: surbhigupta

if i select a static option it trigger will, but if i search an option and select it, click the button and no response.

@CodeABao - Thanks for reporting your issue. We will test this and update you soon.

@Nivedipa-MSFT can you please advise on how I can escalate this issue. This is affecting production corporate bot servicing 19000 employees IT issues. There is no work around or alternative short term fix

@Nivedipa-MSFT we faced the same issue and our bot also affected. Pls fix 'Dynamic typeahead search' feature asap because now it's not usable

@oleksiirud - Engineering team is actively working on the bug fix. We will let you know once we get any updates on it.

@Nivedipa-MSFT Any updates this is critically affecting dozens of our automated processes that depend on valid inputs achieved through typeahead. Its been multiple weeks, any guidance from engineering team, possible cause. Im pretty surprised there arent more people reporting this issue

@01 - We are checking the status of the bug with engineering team. We will let you know once we get any updates from them.

@Nivedipa-MSFT  Is there a way we can push engineering team fix it quickly? Can i do that by submit an "A" case?

Hi @Nivedipa-MSFT , I'm encountering the same issue. Is there any workaround to make it usable?

The engineering team is actively working on the fix. It will be released real soon. We will let you know once it is publicly available.

@Nivedipa-MSFT are you able to provide an expected eta that I can pass along. This has been nearly a month now and I have no been able to provide any information other than its being worked on.


Add support for League Tournament Realm

I'm trying to connect the program to League tournament realm, but it doesn't register it as a client.
Maybe add League tournament realm as a valid client for the program to attach to.

Duplicate #3


SPIKE: Explore aws-vault

Investigate whether incorporating aws-vault into our workflow would be beneficial.
https://github.com/99designs/aws-vault

Raised in the wrong place.


Duration Calculator

Measure duration calculation design doc.

[Current coverage][cc-pull] is 84.09%

Merging [#16][cc-pull] into [master][cc-base-branch] will increase coverage by 1.82%

@@             master        #16   diff @@
==========================================
  Files            11         11
  Lines           581        679    +98
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            478        571    +93
- Misses          103        108     +5
  Partials          0          0

Powered by Codecov. Last updated by [7160864...5f176f6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/drumnkyle/music-notation-swift/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/drumnkyle/music-notation-swift/compare/7160864f5bc55ec430eb3d8ed7dc6e4f96c10cd3...5f176f68fdac8d23a0e634ab535652b93c737f6c?src=pr
[cc-pull]: https://codecov.io/gh/drumnkyle/music-notation-swift/pull/16?src=pr

I just reviewed everything. Looks pretty good. I would fix the couple little things I mentioned and then I will merge it.
Then, let's start looking into MIDI and how this affects anything. After that, I think we may have our solution.


Mongo is not defined on client

I'm not sure why this was working some of the time, but now I am only able to get this package working if I change the package.js file to use mongo on both client and server, otherwise I get a Mongo is not defined error.
Here's the change I made to get it working:
https://github.com/37d/Meteor-logger-mongo/commit/96887b918cdfbf2677a7ea5dd0f2dcc219c18fb7
I'm invoking it like this:
(new LoggerMongo(logger, { collectionName: 'logs' } )).enable({
  enable: true,
  filter: [ 'warn', 'error', 'fatal' ],
  client: false,
  server: true,
});

And I'm referencing this package from within another package, which may be why this issue is showing up for me.

Hi @bryanterrell ,
Sorry for delayed response, is that appeared after meteor update? To which version?

Hi @dr-dimitru,
No worries. I'm on version <IP_ADDRESS> of Meteor. I haven't tried other versions recently so not sure if it's due to an update or not. My guess is Meteor started requiring 'mongo' to be explicitly listed in the package.js at some point.

is meteor add mongo helps, or only editing package config?

I believe I tried that and it wasn't enough. I'd have to try again, though, to confirm.

Hello @bryanterrell ,
I know it's been a while, hope you're still using this package.
I just released an update, should fix this issue.
Let me know, thanks.

Closed due to silence at issue owner end.
Feel free to reopen it in case if the issue still persists on your end.


Few little typo fixes

Fixed a few typos.
comon → common
Added closing bracket:
“∩”, “=”, or “∅ → “∩”, “=”, or “∅”
Changed 5 to k as we are throwing k dice, not 5 (makes more sense when reading the entire paragraph):
So we can throw any value between k + 1 and 6k + 1 by throwing 5 dice and then rolling a 1 with the (k + 1)-st die → So we can throw any value between k + 1 and 6k + 1 by throwing k dice and then rolling a 1 with the (k + 1)-st die

Thanks!


Haven't implement gradient descent in linear regression

Run time of computing a matrix's inverse is o(n^3), kinda slow when n is very large. Usually we will consider gradient descent when n is almost 1000,000.

Done


Refactor FileRequestHandler's methods to non-static methods

Closes issue #75.

Just want to mention that there were some changes to FilRequestHandler in Issue 19. Including static to non-static methods.

There is a problem with glf on my computer. I have to fix it before I can propperly review the code. (So someone elfs might have to review this :) )

Look good! Maybe we shouldn't change the package name in this issue since it is not part of the issue itself(It could be done separately in another issue). However it is a good idea and sould be done.

I have reverted the package name changes but now the issue needs to be reviewed again 😅

I went ahead and refactored the ClientHandler to work with the FileRequestHandler injection as well as merged the Server class from main


feat(Event_Logs): Remove unencrypted emit in private

In PrivateContext we got emit_unencrypted_log. To reduce the option for error, I think it might be the best idea (as it is also written in the comment above the code) to kill it. It lures people in, and can wreck them. Also, if you "REALLY" want it, you can get very similar functionality by doing a emit_raw_event_log_with_masked_address where you are masking using randomness = 0. The main diff really "what" list you expect it to be in 🤷♂.

So it is here for prosperity. It is possible to use the raw masked data emission with a mask of 0, but this would end up broadcasting additional data, and since we are mainly interested in using it to broadcast code to be used in public, it makes sense to emit it using something that we would usually do only in public.
While slightly painful, just got thinking, could be actually have the function implemented inside the deployer itself? e.g., have emit_contract_class_unencrypted_log in there, but still purge it and emit_unencrypted_log from the context? While we need the logic, we might not need it be as easily available from there.
Separately, are we even able to constrain these without making an absolute explosion in the circuit size? Since it needs to know sizes at compile time don't we end up having absolutely crazy expensive deployments? 👀

While #7232 helped make the user flows more aligned, there are now a bit of duplication of data, e.g., the event_selector in emit_unencrypted_log is for example populated and used, even though it is already inside the log argument, so we can cut off a few things here.

Closing in favor of https://github.com/AztecProtocol/aztec-packages/issues/8978. We've already removed the unencrypted logs from the private context (though the oracles remain as the instance deployer uses them) - logs will likely be refactored in the kernel soon anyway.


what is the provider do i put

what do i put there

Need more information, what kind of provider? Do you mean the AI service provider?

i fixed it i looked at the code

nice bot is there other things coming to it

Thanks ^^ I started the whole thing like 2 days ago. Huge developments coming soon. I'm planning to add these features:
Welcomer, some basic Moderation Tools, free games announcer (EpicGames), Giveaway, live stream announcer, reaction roles, some basic fun commands and ticketing.
Anime commands are pretty much done. Will start documenting when developments for the features are done.

you should add a dashborad

Now you can set the AI from the config file or the .env file. Must be one of: NLPCloudProvider or OpenAIProvider


Fatal errors with new projects under both VS 2017 and VS 2019

A fresh Oryol-based project fails with win64-vs{code,2017,tudio}-debug, with or without a d3d11- prefix, with errors like
LINK : fatal error LNK1104: cannot open file 'oryol_Gfx\Debug\Gfx.obj' [C:\Users\...\d3d11-win64-vs2017-debug\....vcxproj
]```
 I'm reporting this here, not there, because if I manually copy files from e.g. oryol_Gfx\Gfx.dir\Debug into that folder, and repeat for the next five or six, it eventually happens with every single dependency.

I'll give it a try, at first glance it this path 'oryol_gfx...' looks wrong, it should be an absolute path, not relative..

Release builds are also failing, with e.g. LINK : fatal error LNK1181: cannot open input file 'oryol_Gfx\Release\Gfx.obj'

Does https://github.com/floooh/oryol-test-app build and run for you? I just tried that on a Win10 machine with the default build config.

Either way, that path doesn't exist for any given configuration - but, in a slightly different folder (e.g. oryol_Gfx\Gfx.dir\Debug\ instead of oryol_Gfx\Debug), the files are present.

... it does build, without issues, and runs. Sorry for wasting your time, this is almost certainly an issue with my setup.

Hmm, yeah, in my test-build the files are also in a Gfx.dir subdirectory:
...fips-build/oryol-test-app/win64-vstudio-debug/oryol_Gfx/Gfx.dir/Debug/...
Can you post your fips.yml file and toplevel CMakeLists.txt file? I suspect it has something todo with no_auto_import policy in the fips.yml file, but then not manually importing the required Oryol modules in the CMakeLists.txt file.
See here:
https://github.com/floooh/oryol-test-app/blob/aacc0ff10890bf2801c13eb05f2e7e0701d46525/fips.yml#L5-L6
And here:
https://github.com/floooh/oryol-test-app/blob/aacc0ff10890bf2801c13eb05f2e7e0701d46525/CMakeLists.txt#L15-L22

no_auto_import is set to false...
policies:
  no_auto_import: false
imports:
  oryol:
    git: https://github.com/floooh/oryol.git
  oryol-imgui:
    git: https://github.com/floooh/oryol-imgui.git
  stb:
    git: https://github.com/fips-libs/fips-stb

cmake_minimum_required(VERSION 3.1)

if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
# Suppress warnings for dependencies
    add_definitions(-Wno-implicit-fallthrough)
endif()

# include the fips main cmake file
get_filename_component(FIPS_ROOT_DIR "./build/fips" ABSOLUTE)
include("${FIPS_ROOT_DIR}/cmake/fips.cmake")

if (FIPS_EMSCRIPTEN)
    add_definitions(-DSOKOL_GLES3)
    set(SOKOL_GLES3 TRUE)
elseif (FIPS_RASPBERRYPI)
    add_definitions(-DSOKOL_GLES2)
    set(SOKOL_GLES2 TRUE)
elseif (FIPS_ANDROID)
    add_definitions(-DSOKOL_GLES3)
    set(SOKOL_GLES3 TRUE)
elseif (SOKOL_USE_D3D11)
    add_definitions(-DSOKOL_D3D11)
    set(SOKOL_D3D11 TRUE)
elseif (SOKOL_USE_METAL)
    add_definitions(-DSOKOL_METAL)
    set(SOKOL_METAL TRUE)
else()
    if (FIPS_IOS)
        add_definitions(-DSOKOL_GLES3)
        set(SOKOL_GLES3 TRUE)
    else()
        add_definitions(-DSOKOL_GLCORE33)
        set(SOKOL_GL TRUE)
    endif()
endif()

fips_setup(PROJECT DocTag-Client)
project(DocTag-Client VERSION <IP_ADDRESS>)

set(VERSION_PREFIX "alpha-")
set(VERSION_SUFFIX "")
configure_file(${CMAKE_SOURCE_DIR}/src/config.h.in ${CMAKE_BINARY_DIR}/config.h)

if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
    # Re-enable warnings that are suppressed for dependencies
    add_definitions(-Wimplicit-fallthrough)
    # Make all warnings errors, helps avoid accidentally introducing UB. Done here
    # so as to affect the client and libdoctag both without affecting any third
    # party dependencies.
    add_definitions(-Werror)
endif()

# Manually import libdoctag
set(FIPS_IMPORT 1)
get_filename_component(LIBDOCTAG_DIR "../libdoctag" ABSOLUTE)
add_subdirectory("${LIBDOCTAG_DIR}" "libdoctag")
set(FIPS_IMPORT)
fips_include_directories("${LIBDOCTAG_DIR}/src")
if (FIPS_WINDOWS)
    fips_include_directories("${LIBDOCTAG_DIR}/src/backends/windows")
endif()

# Has to be defined as cmdline for stdio to work properly on Windows
fips_begin_app(doctag-client cmdline)
fips_src(src NO_RECURSE)
fips_include_directories(${CMAKE_BINARY_DIR})
fips_deps(Gfx Input IMUI doctag)
fips_end_app()

if (UNIT_TESTING)
	add_definitions(-DUNIT_TESTING)
endif()

fips_finish()

Hmm weird. If you find out what's wrong can you post an update here? I'd like to know what happened there. Even when it's not a bug a bug in fips it might sense to print more helpful error messages...

Yeah, sure. Going to have to find out what's wrong now that I know this on my end and I really need to get this working 😬

Going to start with a literally empty folder and slowly build it up to see what pushes it over to the error.


Need to encode to 1-bit BMP

Is your feature request related to a problem? Please describe.
I have web service that receives PNG/JPEG and converts them into BMPs. The generated BMP is then requested by a low-powered microcontroller (esp8266) and then displayed in a small B&W 2.7 inch E-Ink display. The microcontroller has some issues with timeouts when image sizes are "large".
Describe the solution you'd like
I would like the option to encode as a 1-bit BMP output. Currently, If I read a 58Kb JPEG image the BMP output (with resizing as well as removing color) comes out as a 143Kb. If I use gimp to convert to 1-bit indexed color the result is 7Kb!
Adding a . bitPP - Bits per pixel option where I can set to 1 to encode will be ideal.
Describe alternatives you've considered
Here is the code I'm using:
const fs = require('fs');
const Jimp = require('jimp');

test();

async function test() {
    const image = await Jimp.read('lion.jpeg');

    await image
      .contain(264, 176, Jimp.HORIZONTAL_ALIGN_CENTER | Jimp.VERTICAL_ALIGN_MIDDLE)
      .greyscale()
      .contrast(0.8)
      .dither565()
      .deflateStrategy(0)
      .filterType(Jimp.PNG_FILTER_NONE)
      .colorType(0)
      .background(0xFFFFFFFF)
      .rotate(90)
      .writeAsync('lion.bmp');

    const orig = fs.statSync('lion.jpeg');
    const result = fs.statSync('lion.bmp');

    console.log(`${orig.size / 1000.0}kb`, `${result.size / 1000.0}kb`);
}

Additional context

related https://github.com/shaozilee/bmp-js/issues/21

Exactly what I need...  1-bit by pixel

I have created https://github.com/hipstersmoothie/bmp-js/tree/ts a fork of bmp-js to handle encoding. Just need to write some tests and release @bkonno @noelportugal

Great news @hipstersmoothie! I'm hoping is released in the next couple days :)

+1

@hipstersmoothie your link dosent work anymore, could you share a new example thanks


Add Weer

A HTTP protocol debugger, base on Chrome DevTools frontend interface.
But this is not an open source project, it is fine to list here?

I will defer whether this should be added or not to @paulirish.
My feeling is we shouldn’t because there doesn’t seem to be a free/open-source component to it. That means having it linked here feels like an endorsement of a paid product.
We also currently have Betwixt referenced, which is open-source, free, and carries out the same function. It just needs some TLC and someone to keep it up-to-date since Konrad is pretty busy now with other things.


Lex: Remove todo!() there to avoid unexpected behavior when meeting new command like #SCROLL which is not supported by this library.

Lex:

Remove todo!() there to avoid unexpected behavior when meeting new command like #SCROLL which is not supported by this library.
Split LexWarning from LexError.
Modified the behavior of lex::parse(), and renamed some elements. New function lex::parse_and_get_warnings() added, the original lex::parse() is there, but now that is not recommand. The usage of this library is not modified, when old codes relying it can be built with the action changed above.

Thanks for contribution. Sorry, I've missed that there is #SCROLL command, because of I referred this site.
It seems that they are Bemuse's extensions. But I'd like to support them because I'm a contributor of Bemuse. I'll make it an issue.
Anyway, I think this library is still unstable and want to keep todo!() until there is no missing major commands unsupported. Currently, a good way to improve I thought is adding debug message about reporting bug to this repository.

Ah...
I think that there is a situation when the bms file itself has errors in a little part. It's not the fault of this library, but the panic is unacceptable when using this library.
This PR's purpose is to read vaild chart infomation as more as possible.
I'll keep my fork when I want to use this library.
Thanks for replying.


GML Format Improvements #8516 #8517 #8518

This PR is for three issues unfortunately, because the patches are interdependent. There are however three separate commits.
faetureMember tag support #8516
basic GML 3.2 format and namespace support #8517
complex feature support #8518
all patches have test cases included.

Hmmm the tests for the complex feature parser pass on linux but fail on windows. I have no idea why.

@ahocevar could you perhaps  have a look at this?
would like to have an idea of the chances or what else needs to change before I resolve the merge issues

@NielsCharlier, I don’t know much about the XML parsers. @fredj or @bartvde would be better reviewers.

I don't have time for an in-depth review but from glancing over the code it looks fine to me, and it's got tests. So I'm +1 for getting this in once it's updated for master and typescript.

The code looks good to me too (but I'm not a GML expert ...).
@NielsCharlier If you want, I can update your code to fix the type annotation.

thanks @bartvde. I have fixed the current merging issue and will do this again once the typescript PR has been merged so that this one can be merged shortly afterwards

that would be fantastic @fredj

@NielsCharlier I've pushed a commit into your branch that fixes the type annotations.
I will take a last look tomorrow morning and merge this.
And thanks again for your contribution!

@fredj Should #8711 be merged first to fix existing TS errors in the GML stack? That fixes all of them, which will make it easy to verify this PR doesn't introduce new errors.

@schmidtk yes, I've merged merged #8711, thanks

Thanks @fredj !


Enable tailwind css building for unit tests

Description
Previously it was enabled only when developer runs all java unit tests locally. This PR adds tailwind building hook to the following test commands: jococo - used to run tests on CI, testOnly/testQuick - used to iteratively run individual tests locally.
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Codecov Report

Merging #3437 (1b1e797) into main (4dd8e49) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3437      +/-   ##
============================================
+ Coverage     80.30%   80.42%   +0.11%
- Complexity     2359     2365       +6
============================================
  Files           291      291
  Lines          9361     9428      +67
  Branches        627      629       +2
============================================
+ Hits           7517     7582      +65
- Misses         1597     1599       +2
  Partials        247      247

Impacted Files
Coverage Δ

server/app/controllers/ErrorHandler.java
79.16% <0.00%> (-8.34%)
:arrow_down:

server/app/repository/UserRepository.java
60.00% <0.00%> (-1.30%)
:arrow_down:

.../app/controllers/applicant/RedirectController.java
56.09% <0.00%> (ø)

...rollers/applicant/ApplicantProgramsController.java
100.00% <0.00%> (ø)

server/app/repository/ApplicationRepository.java
97.84% <0.00%> (+0.04%)
:arrow_up:

server/app/models/Application.java
94.59% <0.00%> (+0.65%)
:arrow_up:

...erver/app/services/applicant/ApplicantService.java
89.05% <0.00%> (+3.40%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create or update baselines to match 2.0

This causes legit build failures:

C:\Users\appveyor.nuget\packages\internal.aspnetcore.sdk\2.1.0-preview2-15728\build\ApiCheck.targets(39,5): error : ERROR: The following exclusion is in the exclusion file, but is no longer necessary:

https://ci.appveyor.com/project/aspnetci/dataprotection/build/1.0.658#L279

:up::date:

:shipit:


Updated to support Android API 30 and latest Android command line tools.

Support for Android SDK API 30.

LGTM. Thank you for your contribution.

You're welcome. I have to thank you for maintaining this nice project and open sourcing it.


Check and document Python 3.10 support

Checking the Github Action run it seems it might be a tad early for Python 3.10 support. I think I have spotted scikit-learn building from source instead of having a pre-built wheel. Maybe we could re-run this a few weeks later again?

As we were already running stuff against the newest, this changes very little, noice :)

Perhaps we might want to check against our entire supported range of Python versions soon, using the Github Actions version matrix, but for now let's merge.


SMTP authentication

Hi, is possible to add the support for self signed certificate?
Mail Error on STARTTLS: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs
Thanks

I am also having this issue after configuring postfix and setting the environment variables (/etc/environment).

Add settings
    environment:
      .....
      - SMTP_NO_TLS_CHECK=true

https://github.com/ngoduykhanh/wireguard-ui/blob/87b08a8f7c026e325438b18a1d7384fd33847e5c/main.go#L59


feat: activate ignore_account_root_nodes option

This PR covers following changes:

Add an option ignore_account_root_nodes: bool = False to CashCtrlClient.update_categories(). When set, we silently ignore additions, updates and deletions of root account categories.
Modify mirror_account_chart() to activate this option. Remove trick on  ledger.py#L140 that ignores root node most of the time but fails to work in some circumstance.

First commit - shows the issue exist with the new test suit
Second commit - fixes the issue
@lasuk Please review the changes and provide feedback or approval for merging.

Nice. Thanks a lot!


Selecting tags shows only value and doesn't select multiple tags

Hi,
Below is my component code. But that's not working the way I expected it to like this. What am I doing wrong?
Expected behaviour: https://vue-multiselect.js.org/#sub-tagging
Actual behaviour:

<template>
  <multiselect v-model="value" :options="options" :taggable=true tag-placeholder="Add this as new tag"></multiselect>
</template>

<script>

import Multiselect from 'vue-multiselect'

export default {
  components: {
    Multiselect
  },
  data () {
    return {
      value: [
        { name: 'Javascript', code: 'js' }
      ],
      options: [
        { name: 'Vue.js', code: 'vu' },
        { name: 'Javascript', code: 'js' },
        { name: 'Open Source', code: 'os' }
      ]
    }
  },
  methods: {
    addTag (newTag) {
      const tag = {
        name: newTag,
        code: newTag.substring(0, 2) + Math.floor((Math.random() * 10000000))
      }
      console.log('tag', tag)
      this.options.push(tag)
      this.value.push(tag)
    }
  }
}

</script>

<style src="vue-multiselect/dist/vue-multiselect.min.css"></style>

add :label='name'

@sourenaraya still dint help buddy!

Also add track-by. Look at the example you linked to.

Thanks @shentao. Didn't notice the HTML part below.


Support customize cluster manager namespace

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>https://github.com/open-cluster-management-io/registration-operator/issues/157
Please note that this PR is scoped, it only supports detached mode install in a customize namespace, but in any other way, it behaves just like the default mode.
Therefore there are no test cases for the logic of detached mode. The rest of detached mode will come with another PR later.

/assign @zhiweiyin318
/assign @zhujian7
/assign @qiujian16

Commits lost after squash.. Recovering.

Once the Makefile is updated, please confirm if you need to update the README.md

Once the Makefile is updated, please confirm if you need to update the README.md

Yes, README.md will be updated in the next PR because for this moment no detached cluster-manager logic code yet. After this PR, we assume users feel nothing changed about cluster-manager.

/approve
Thanks, I think it looks good in general.

/lgtm


Error compiling the glocal_exploration folder

When I executed the command:catkin build glocal_exploration_ros, the following errors appeared. These errors should be from the same problem. I intercepted one of the errors.
/HOME/exploration_map/src/glocal_exploration/glocal_exploration/include/glocal_exploration/3rd_party/config_utilities.hpp:200:39: error: invalid static_cast from type ‘const XmlRpc::XmlRpcValue’ to type ‘bool’
*param = static_cast(xml);
Do you know how to solve these problems?

Have you solved this problem?


Complile JS to ES5

Check that Gulp bulid is refactoring/compiling the JS to ES5. This will allow app to run on all browsers.

Check that Gulp bulid is refactoring/compiling the JS to ES5. This will allow app to run on all browsers.

Used Babel to compile all own JS files to ES5 syntax for cross browser support. Babel introduced to application and into the Gulp build thru gulp-babel. Babel.json section added to composer.json file to setup presets defaults and so not required in the gulpfile other than .pipe(gulp()).


nixos/tailscale: obey system's networking.proxy settings.

Signed-off-by: David Anderson<EMAIL_ADDRESS>Description of changes
More complete version of #205869, which obeys http_proxy (used for some control plane dials) and no_proxy (if tailscale is excluded from proxying by site config). Incidentally also migrated to using the structured Nix systemd.services.<name>.environment option, which makes the envvars more readable.
Tested on my NixOS systems.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/782

Closing the PR. Feel free to reopen it if needed.


VaultBootstrapConfiguration Error

Hi!
Since today I'm having the following error while trying to start my application, yesterday was working OK.
Is it possible that same changes in the snapshot crashes with my code?
Thanks a lot!
Caused by: java.lang.NoSuchMethodException: org.springframework.cloud.vault.config.VaultBootstrapConfiguration$$EnhancerBySpringCGLIB$$f3816d8f.<init>()
       	at java.lang.Class.getConstructor0(Class.java:3082)
       	at java.lang.Class.getDeclaredConstructor(Class.java:2178)
       	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:80)
       	... 57 more

This ticket belongs to https://github.com/spring-cloud-incubator/spring-cloud-vault-config as you're using Spring Cloud Vault. Please update/refresh your snapshots.

Thanks for your quick answer! I just did it but problems is still there, should I change something in my configuration?
BTW, do you want me to move this ticket to the other project?
Thanks again,
M.

Let's keep it for now here.
Could you verify whether you are able to reproduce the issue with https://github.com/mp911de/spring-cloud-vault-config-samples/tree/master/hello-world ? The readme in https://github.com/mp911de/spring-cloud-vault-config-samples contains instruction (5 shell scripts) how to run/prepare Vault for the examples.

Any update on this ticket?

Hi Mark,
The use was that I was using spring boot 1.3.5.
I had to switch to 1.4.0-RELEASE and the problem has been fixed.
Thanks,
M.
On Mon, Sep 26, 2016 at 4:29 PM, Mark Paluch<EMAIL_ADDRESS>wrote:

Any update on this ticket?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/spring-vault/issues/6#issuecomment-249672333,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByor-488rN1Zo_lcaooiqlIHkHy3C7Eks5quB00gaJpZM4KEOP4
.

--
Mario

Thanks for the feedback. Closing this ticket as it's resolved.

Thanks Mark!
M.
On Tue, Sep 27, 2016 at 3:28 AM, Mark Paluch<EMAIL_ADDRESS>wrote:

Thanks for the feedback. Closing this ticket as it's resolved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/spring-vault/issues/6#issuecomment-249777504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByorxxQVQlhilpWLPOTiMwSaDqo6KL2ks5quLeCgaJpZM4KEOP4
.

--
Mario


When does the update get pushed to scoop?

I see that v1.3 has been released,
But scoop is still showing v1.2 as the latest version.
When does the scoop version usually get updated?

It's automatic but even so it can sometimes take up to a day or two for Scoop manifests to update. Longer if they've broken and someone needs to fix it. Usually it's within hours.

wingetui: Update to version 1.3.0 9 minutes ago. Should be ready to download.

Yes, and the winget one will come soon


Add Win32, Win64 and other platforms to Defines.h

Actually, I will just remove Mac OS and Linux platforms support. I do it like that:
#if defined(__APPLE__)
    // show error popup and close the engine
#elif defined(__linux__)
    // show error popup and close the engine
#endif

But first I need to implement popup functionality in Common project

#12


Feature Request: Change emoji navigation with arrow keys

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open app
Navigate to any conversation and open emoji picker
When typing in the emoji search box, when there are no characters in front of the cursor, you click the right arrow key

Expected Result:
User should navigate to the first emoji listed below (the same as if you clicked the down arrow)
Actual Result:
Nothing happens when you click right arrow
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.1.25-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/148168046-28bff3e5-9f9a-4902-a286-a5ae983e69f2.mp4
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640907606322500
View all open jobs on GitHub

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal:
https://github.com/Expensify/App/blob/fbb4674521536923ee83c6e3f093fbe6bc029f9f/src/pages/home/report/EmojiPickerMenu/index.js#L180-L183
Change the if condition to:
if (['ArrowDown', 'ArrowRight'].indexOf(arrowKey) === -1) {
   return;
}

I am working on this https://github.com/Expensify/App/pull/6977 and have moved the location/renamed files, etc. for the EmojiPicker. I can take this up as a follow-up PR and add the feature.
cc - @mallenexpensify

sending to the pool

@bondydaa @johncschuster Nobody’s assigned to the issue after being unassigned

is sending to the engineering pool no longer an option?
I guess external is probably fine but for new feature requests I think letting this go to the pool and have someone who's more involved in new dot review is better than me just willy nilly saying sure go for without any context.

posted about this in engineering-chat to see if someone more familiar with new dot wants to review first

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Hmm, yeah I agree with @mvtglobally. Posting to Upwork shortly.

Upwork job is here: https://www.upwork.com/jobs/~016537449e7470b466

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav your proposal looks good!

📣 @mananjadhav You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Yup, @mananjadhav's proposal looks good.

I am working on #6977 PR, can I combine this one in that PR?

Sure, that's fine. Just make sure to link this issue there as well.

I am working on #6977 PR, can I combine this one in that PR?

I'm  really sorry, missed this.

I am working on #6977 PR, can I combine this one in that PR?

I'm really sorry, I missed this.
@mananjadhav
That PR seems huge. I'd prefer if you create a new PR so it's easy to review and revert in case of regressions.

No problem. I’ll finish that one by tomorrow and probably keep this on hold?

Sounds good

@mananjadhav any updates on when your PR will be ready for review? Thanks :)

Put in an update on the PR.

@rushatgabhane  @luacmartins  PR updated

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.31-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7127

If no regressions arise, payment will be issued on 2022-01-27. :confetti_ball:

No regressions. @mananjadhav Payment processed.
@mvtglobally Thanks for reporting. I closed the above Upwork contract so I created a new job for you to apply for here: https://www.upwork.com/jobs/~01e92d1d2a7f6a2c45.
Thank you all!

@JmillsExpensify sorry to ping you, I've applied to the same job. I hope that's okay!

Ah thank you! Will handle, apologies for missing.

All contributors should be successfully paid at this point. Closing the issue, but please reach out if I can help with anything or if I missed something!


fix(deploy) Deploy condition for Windows build

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

Coverage remained the same at 95.221% when pulling d99b08763213a7260866d64ccd9ee7b0050b2755 on jeromesimeon:js-fix-windows-deploy into 120a70345f5dca8551d3266bb8cc4a34436392e6 on accordproject:master.


ZEPPELIN-1516. NPE LivySparkSQLInterpreter thrown with %livy.sql interpreter

What is this PR for?
This PR fixed NPE issue in LivySparkSQLIntepreter, also it resolves the multiple thread issues discussed in #1503
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1516

How should this be tested?

Enable shiro
Log in 2 users in 2 browsers
Start livy sql paragraph at almost the same time
2 livy sessions are created correctly.

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

looks good. is it possible to have a test for this?

I plan to do it after #1462, could you also take a look at #1462 ?

@felixcheung @prabhjyotsingh Please help review.

Does this happens only for livy.sql, or can it happen to others as well ?

@prabhjyotsingh I have only seen this issue with livy.sql as it is the only one that shares the HashMap between livy.spark and livy.sql. livy.sparkr and livy.pyspark do not share session info. In the future yes?

If you start livy.sql first, you will hit this issue, because userSessionMap is null.

Sure, got it. LGTM!

Got it. Is there a way to version check Livy, like how we do Spark? Perhaps a PR on Livy to expose that?
Just thinking this could be fragile when moving to SparkSession and so on (maybe in the future)

I am planing to add such rest api for livy, but for now livy don't have such api for checking version.

Great, one question LGTM otherwise

Close this PR, as I am refactoring LivyInterpreter in ZEPPELIN-1607


Bug when inference with custom video

After runing about 8 batch, it returns bug
Fail to perform transform [<paddlevideo.loader.pipelines.sample_one_file.OneFileSampler object at 0x7f5ab4d1f3a0>] with error: index 333 is out of bounds for axis 0 with size 327 and stack:
Traceback (most recent call last):
File "/content/Soccernet-features/paddlevideo/loader/pipelines/compose.py", line 69, in call
data = p(data)
File "/content/Soccernet-features/paddlevideo/loader/pipelines/sample_one_file.py", line 171, in call
return self._get(frames_idx, results)
File "/content/Soccernet-features/paddlevideo/loader/pipelines/sample_one_file.py", line 126, in _get
imgbuf = frames[idx]
IndexError: index 333 is out of bounds for axis 0 with size 327

Hi, thank you for submitting the issue. Here's the steps I suggest to dig deeper.
First, you can focus on running the file that produces this error. The indices are computed from start seconds, end seconds and fps. One of them is inconsistent with the input file hence reading the frame is out of bound for the index.
Let me know if this helps you.

Hi, I have the same issue. I tried it with a a video of duration 6:53 so I typed in the json this one ("fps": 25, "length_secs": 413) and I got this error after 15 batches
12/02 12:31:41] fail to perform transform [<paddlevideo.loader.pipelines.sample_one_file.OneFileSampler object at 0x7ee2eebae740>] with error: index 516 is out of bounds for axis 0 with size 513 and stack: Traceback (most recent call last):   File "/content/Soccernet-features/paddlevideo/loader/pipelines/compose.py", line 69, in call     data = p(data)   File "/content/Soccernet-features/paddlevideo/loader/pipelines/sample_one_file.py", line 171, in call     return self._get(frames_idx, results)   File "/content/Soccernet-features/paddlevideo/loader/pipelines/sample_one_file.py", line 126, in _get     imgbuf = frames[idx] IndexError: index 516 is out of bounds for axis 0 with size 513

Hi @Daanfb, it's a simple io error. We can work through this.
One file failed with number of frames index out of bound. Do you know which file?
You can just run that one file and check the number of frames read in in line 95 for example. I would also check if number of seconds is slightly less than 413. Like actually 412.xx but rounded up?

Hi @paulxinzhou. The number of seconds is 413.88, so I wrote 413 in the json.
I printed out the length of the frames variable from File "/content/Soccernet features/paddlevideo/loader/pipelines/sample_one_file.py" and I got 513. I don't know why this is the length when the video is 413 seconds long and 30 fps. Shouldn't it be 413*30 frames?

Hi @Daanfb, right, 513 sounds wrong, and it should be 413 * 30.
One of the worries I have is having a long-ish video with a high fps make you run out of RAM pretty quickly.  There is a possibility you may be hitting the memory limit of your machine and something failed along the way.
I would suggest trying a couple of things. 1. Try with another video that worked to see if len(frames) make sense. 2. Convert this video to a lower fps and see if that can be read correctly.

Hi @paulxinzhou. After several tests I came to the following conclusions:
For videos with mp4 format, the maximum duration allowed is the duration in seconds * the number of frames indicated in the .json file < 513. These are several examples in which it would work:

Duration 3:30 (30 fps), but 2 fps is set in the json file. When printing frames_len it would output 513, but it works.
Duration 0:15 (30 fps), and 30 fps is set in the json file. frames_len = 461 (correct because actually the duration was 15.38 seconds)

On the other hand, for mkv format files it seems to work fine. I have performed the following tests:

Duration 4:42 (25 fps), and 25 fps is set in the json file.
frames_len = 6635. WORKS
Duration 9:23 (25 fps), and 25 fps is set in the json file.
After 'opened path' is printed I get the error message Exit_code -9. Maybe it may be because it requires too much RAM.
Duration 7:32 (25 fps), and 25 fps is set in the file.
frames_len = 11300. WORKS.

In this last test the System RAM is between 8-11 GB and my system has 12.7GB.

@Daanfb , that's a great observation. Re mp4 vs mkv, it must be that mkv is more memory efficient. The system memory is used up while decoding mkv / mp4 into numpy. That was my hypothesis and I think it still holds with the new data.


DatePicker:fix weeknumber error

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.
fix bug #21614

@xinguanhua 这个项目还维护吗，麻烦审核下我这个pr💕


UnsatisfiedLinkError: Can't load library: libskiko-macos-arm64.dylib

Describe the bug
Unable to start the application compiled app. (It runs though using directly IntelliJ)
Affected platforms
Select one of the platforms below:

Desktop

Versions

Kotlin version*: 1.9.10
Compose Multiplatform version*: 1.5.1
OS version(s)* (required for Desktop and iOS issues): Mac Os Ventura 13.5.2
OS architecture (x86 or arm64): arm64
JDK (for desktop issues): zulu-17-jdk

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

Write app's code
Compile code using Gradle createDistribuable script (it is working)
Run compiled app using Gradle runDistribuable OR double clicking the app's icon

Expected behavior
A clear and concise description of what you expected to happen:
The app should start.
Screenshots
If applicable, add screenshots to help explain your problem:
None available
Additional context
Add any other context about the problem here:
Here is the error log i got:
Exception in thread "main" java.lang.UnsatisfiedLinkError: Can't load library: /Users/XXX/Documents/Sources/Samples/ComposeDesktopDemo/build/compose/binaries/main/app/ComposeDesktopDemo.app/Contents/app/libskiko-macos-arm64.dylib
at java.base/java.lang.ClassLoader.loadLibrary(Unknown Source)
at java.base/java.lang.Runtime.load0(Unknown Source)
at java.base/java.lang.System.load(Unknown Source)
at org.jetbrains.skiko.Library.loadLibraryOrCopy(Library.kt:20)
at org.jetbrains.skiko.Library.findAndLoad(Library.kt:85)
at org.jetbrains.skiko.Library.load(Library.kt:59)
at org.jetbrains.skia.impl.Library$Companion.staticLoad(Library.jvm.kt:12)

Cannot reproduce based on your description. Could you please try to reproduce it on our template?

Cannot reproduce based on your description. Could you please try to reproduce it on our template?

Thanks for the feedback.
I cloned the repo, run Gradle Sync, then createDistribuable and then runDistribuable and end up with the same error.

Just in case: you're using the arm64 version of JDK, right? Is build/compose/binaries/main/app/ComposeDesktopDemo.app/Contents/app/libskiko-macos-arm64.dylib file really missed in your file system?

Both files (libskiko-macos-arm64.dylib and libskiko-macos-arm64.dylib.sha256) are present in the folder mentionned.
What surprises me is I can run my app using the "Run" button on IntelliJ, but bundled in an application, i can't...

Just in case: you're using the arm64 version of JDK, right?

For now it looks like the issue is somewhere in the JDK installation. That's why I asked such a question

I can run my app using the "Run" button on IntelliJ, but bundled in an application, i can't

It is probably because of different JDK/JRE. Could you please try with different one?

Can you please print result of running command:
/usr/libexec/java_home --verbose

Was there any resolution found here? I seem to be having the same issue. I've cloned the example repo with the following results:

./gradlew run works fine
./gradlew createDistributable works fine
./gradlew runDistributable throws the following error:

Exception in thread "main" java.lang.UnsatisfiedLinkError: Can't load library: /.../compose-multiplatform-template/desktopApp/build/compose/binaries/main/app/KotlinMultiplatformComposeDesktopApplication.app/Contents/app/libskiko-macos-arm64.dylib
        at java.base/java.lang.ClassLoader.loadLibrary(Unknown Source)
        at java.base/java.lang.Runtime.load0(Unknown Source)
        at java.base/java.lang.System.load(Unknown Source)
        at org.jetbrains.skiko.Library.loadLibraryOrCopy(Library.kt:20)
        at org.jetbrains.skiko.Library.findAndLoad(Library.kt:85)
        at org.jetbrains.skiko.Library.load(Library.kt:59)
        at org.jetbrains.skia.impl.Library$Companion.staticLoad(Library.jvm.kt:12)
        at androidx.compose.ui.ConfigureSwingGlobalsForCompose_desktopKt.configureSwingGlobalsForCompose(ConfigureSwingGlobalsForCompose.desktop.kt:49)
        at androidx.compose.ui.ConfigureSwingGlobalsForCompose_desktopKt.configureSwingGlobalsForCompose$default(ConfigureSwingGlobalsForCompose.desktop.kt:38)
        at androidx.compose.ui.window.Application_desktopKt.application(Application.desktop.kt:110)
        at androidx.compose.ui.window.Application_desktopKt.application$default(Application.desktop.kt:105)
        at MainKt.main(main.kt:4)
        at MainKt.main(main.kt)
Failed to launch JVM

Any idea what I can do here to resolve?

@jamesoneill54
Can you please also execute this command and copy result here:
/usr/libexec/java_home --verbose

Hi @dima-avdeev-jb, here's the output from me running that command:
Matching Java Virtual Machines (2):
    11.0.15 (x86_64) "Eclipse Adoptium" - "OpenJDK 11.0.15"
    1.8.0_342 (arm64) "Azul Systems, Inc." - "Zulu <IP_ADDRESS>"

If it's of any help, I'm also using sdkman to manage java versions. The current version installed is:
❯ java --version
openjdk <IP_ADDRESS> 2022-08-12 LTS
OpenJDK Runtime Environment Microsoft-40354 (build <IP_ADDRESS>+1-LTS)
OpenJDK 64-Bit Server VM Microsoft-40354 (build <IP_ADDRESS>+1-LTS, mixed mode)

@jamesoneill54 Thanks!
I supposed you are using x86_64 for launching Compose.
Better to remove your x86_64 JDK and install ARM version. Or install ARM version and change path in JAVA_HOME environment variable.

Hi again @dima-avdeev-jb, happy holidays!
I've removed the x86_64 JVM from my machine, so now the command above reads:
❯ /usr/libexec/java_home --verbose
Matching Java Virtual Machines (2):
    1.8.0_342 (arm64) "Azul Systems, Inc." - "Zulu <IP_ADDRESS>" /Users/{user}/Library/Java/JavaVirtualMachines/azul-1.8.0_342/Contents/Home
    1.8.0_342 (arm64) "Azul Systems, Inc." - "Zulu <IP_ADDRESS>" /Library/Java/JavaVirtualMachines/azul-1.8.0_342/Contents/Home
/Users/{user}/Library/Java/JavaVirtualMachines/azul-1.8.0_342/Contents/Home

My $JAVA_HOME is still set up using SDKMAN, and reads /Users/{user}/.sdkman/candidates/java/current.
Output of sdk current:
❯ sdk current

Using:

java: <IP_ADDRESS>-ms
kotlin: 1.7.21

Unfortunately I'm seeing the same behaviour. After successfully running ./gradlew createDistributable, ./gradlew runDistributable does not work with the same JVM error as above.
Are there any further steps I can take?

Are this JAVA_HOME JDK is X86_64 or ARM ?
I think it is X86_64

Listing the sdkman available java distributions, it's listing my currently installed version as ARM:
❯ sdk list java
================================================================================
Available Java Versions for macOS ARM 64bit
================================================================================
 Vendor        | Use | Version      | Dist    | Status     | Identifier
--------------------------------------------------------------------------------
 Corretto      |     | 21.0.1       | amzn    |            | 21.0.1-amzn
               |     | 17.0.9       | amzn    |            | 17.0.9-amzn
               |     | 11.0.21      | amzn    |            | 11.0.21-amzn
               |     | 8.0.392      | amzn    |            | 8.0.392-amzn
 Gluon         |     | <IP_ADDRESS>.r17 | gln     |            | <IP_ADDRESS>.r17-gln
               |     | <IP_ADDRESS>.r11 | gln     |            | <IP_ADDRESS>.r11-gln
 GraalVM CE    |     | 21.0.1       | graalce |            | 21.0.1-graalce
               |     | 17.0.9       | graalce |            | 17.0.9-graalce
 GraalVM Oracle|     | 21.0.1       | graal   |            | 21.0.1-graal
               |     | 17.0.9       | graal   |            | 17.0.9-graal
 Java.net      |     | 23.ea.3      | open    |            | 23.ea.3-open
               |     | 23.ea.2      | open    |            | 23.ea.2-open
               |     | 23.ea.1      | open    |            | 23.ea.1-open
               |     | 22.ea.29     | open    |            | 22.ea.29-open
               |     | 22.ea.28     | open    |            | 22.ea.28-open
               |     | 22.ea.27     | open    |            | 22.ea.27-open
               |     | 22.ea.26     | open    |            | 22.ea.26-open
               |     | 21.ea.35     | open    |            | 21.ea.35-open
 JetBrains     |     | 17.0.9       | jbr     |            | 17.0.9-jbr
               |     | <IP_ADDRESS>    | jbr     |            | <IP_ADDRESS>-jbr
 Liberica      |     | 21.0.1.fx    | librca  |            | 21.0.1.fx-librca
               |     | 21.0.1       | librca  |            | 21.0.1-librca
               |     | 17.0.9.fx    | librca  |            | 17.0.9.fx-librca
               |     | 17.0.9       | librca  |            | 17.0.9-librca
               |     | 11.0.21.fx   | librca  |            | 11.0.21.fx-librca
               |     | 11.0.21      | librca  |            | 11.0.21-librca
               |     | 8.0.392.fx   | librca  |            | 8.0.392.fx-librca
               |     | 8.0.392      | librca  |            | 8.0.392-librca
 Liberica NIK  |     | 23.1.1.r21   | nik     |            | 23.1.1.r21-nik
               |     | 22.3.4.r17   | nik     |            | 22.3.4.r17-nik
               |     | 22.3.4.r11   | nik     |            | 22.3.4.r11-nik
 Microsoft     |     | 21.0.1       | ms      |            | 21.0.1-ms
               |     | 17.0.9       | ms      |            | 17.0.9-ms
               | >>> | <IP_ADDRESS>     | ms      | local only | <IP_ADDRESS>-ms
               |     | 11.0.21      | ms      |            | 11.0.21-ms
 Oracle        |     | 21.0.1       | oracle  |            | 21.0.1-oracle
               |     | 17.0.9       | oracle  |            | 17.0.9-oracle
 SapMachine    |     | 21.0.1       | sapmchn |            | 21.0.1-sapmchn
               |     | 17.0.9       | sapmchn |            | 17.0.9-sapmchn
               |     | 11.0.21      | sapmchn |            | 11.0.21-sapmchn
 Semeru        |     | 17.0.9       | sem     |            | 17.0.9-sem
               |     | 11.0.21      | sem     |            | 11.0.21-sem
 Temurin       |     | 21.0.1       | tem     |            | 21.0.1-tem
               |     | 17.0.9       | tem     |            | 17.0.9-tem
               |     | 11.0.21      | tem     |            | 11.0.21-tem
 Tencent       |     | 17.0.9       | kona    |            | 17.0.9-kona
               |     | 11.0.21      | kona    |            | 11.0.21-kona
               |     | 8.0.392      | kona    |            | 8.0.392-kona
 Zulu          |     | 21.0.1       | zulu    |            | 21.0.1-zulu
               |     | 21.0.1.fx    | zulu    |            | 21.0.1.fx-zulu
               |     | 17.0.9       | zulu    |            | 17.0.9-zulu
               |     | 17.0.9.fx    | zulu    |            | 17.0.9.fx-zulu
               |     | 11.0.21      | zulu    |            | 11.0.21-zulu
               |     | 11.0.21.fx   | zulu    |            | 11.0.21.fx-zulu
               |     | 8.0.392      | zulu    |            | 8.0.392-zulu
               |     | 8.0.392.fx   | zulu    |            | 8.0.392.fx-zulu
 Unclassified  |     | 11.0.15      | none    | local only | 11.0.15
================================================================================
Omit Identifier to install default version 21.0.1-tem:
    $ sdk install java
Use TAB completion to discover available versions
    $ sdk install java [TAB]
Or install a specific version by Identifier:
    $ sdk install java 21.0.1-tem
Hit Q to exit this list view
================================================================================

This leads me to believe that it is using an ARM version correctly. Additionally, I've run ./gradlew runDistributable with info logs and the following line is printed about the JVM version used:
Received JVM installation metadata from '/Users/{user}/.sdkman/candidates/java/<IP_ADDRESS>-ms': {JAVA_HOME=/Users/{user}/.sdkman/candidates/java/<IP_ADDRESS>-ms, JAVA_VERSION=<IP_ADDRESS>, JAVA_VENDOR=Microsoft, RUNTIME_NAME=OpenJDK Runtime Environment, RUNTIME_VERSION=<IP_ADDRESS>+1-LTS, VM_NAME=OpenJDK 64-Bit Server VM, VM_VERSION=<IP_ADDRESS>+1-LTS, VM_VENDOR=Microsoft, OS_ARCH=aarch64}

Is there something I'm missing here? I'll try using a different distribution perhaps.

@dima-avdeev-jb I've found the solution to my problem!
I changed my java distribution from my local versions <IP_ADDRESS>-ms to the generic 17.0.4-ms, but this ran into the same issues. However, changing it then to 17.0.9-ms (or potentially another java version > 17.0.4) and it runs successfully.
Thank you for your help here, and let me know if there's any other info I can provide if you'd like to investigate this case any further.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


API Server Timeout when entering Admin Ingress Location

What steps did you take and what happened:
Created an AWS Quickstart cluster and utilized the Admin Ingress Location IP address of my local isp to lock down access to the cluster.
The API ELB is locked down to only my admin ingress location but not any nodes for the cluster.
What did you expect to happen:
Cluster would be created and function properly without manual intervention.
Anything else you would like to add:
Was able to make the api elb work when adding the EIP of the vpc to the api security group.

Kubernetes version: (use kubectl version):Kubernetes 1.11.1
OS (e.g. from /etc/os-release): Ubuntu 16.04

@rbankston could you please provide some additional details on how to reproduce this issue

Steps to Reproduce

Launch latest AWS-quickstart template from the Readme.
Proceed to fill out fields in the template as normal
In Admin Ingress Location enter your ip address if <IP_ADDRESS> was your ip address would be <IP_ADDRESS>/32
Launch quickstart

Quickstart will launch. The bastion host ingress location will be set properly to your local IP address. The load balancer for the control plane will be set to allow traffic from only <IP_ADDRESS>/32 on ports 6443 and 443 sent to port 6443 of the control plane instance. The external control plane nat ip address isn't allowed to access the load balancer causing the cluster to fail creation.

@timothysc FYI - low priority, but definitely a bug we should probably fix.


Update sharing-workflows-with-your-organization.md

Why:
Documentation didn't highlight an important piece of information effectively.
What's being changed:
Placing a small piece of documentation in a callout box so it stands out more.
Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@MaxFlanders Thanks so much for opening a PR! I'll get this triaged for review ⚡


adding callbacks to withRelated to the docs

some missing stuff in the docs with withRelated

Thanks @dsauerbrun. I added a little more (including the withRelated @param tag).


changes for trending data

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #WRLDBAEMS-38
Test URLs:

Before: https://main--world-bank--aemsites.hlx.live/
After: https://trending-data--world-bank--aemsites.hlx.live/

@skumawat1 Few observations:

API call for trending data happens on Mobile which is not required.
When the trending data is loaded for the first time, I see the previous text for a short time, this goes away when there is data. This is not a good UX, can we keep the div empty before trending data is loaded, or show the trending data div only after the response is available?
When the trending data is short, the div doesn't look very centered. Take help of @naina66406 for this as she worked on header.

@skumawat1 Few observations:

API call for trending data happens on Mobile which is not required.
When the trending data is loaded for the first time, I see the previous text for a short time, this goes away when there is data. This is not a good UX, can we keep the div empty before trending data is loaded, or show the trending data div only after the response is available?
When the trending data is short, the div doesn't look very centered. Take help of @naina66406 for this as she worked on header.

Added all the review comments @thomsebastin


Restore mock ViewContext to fix background triggers needing user and URL

Rationale
Additional tests last night turned up a problem with the PR I merged that correctly tracks the container for a given TableInfo trigger event even if it's a different container from the originating ViewContext. Ideally we'd not rely on the ViewContext at all and may be able to revisit, but need to get these scenarios working in the meantime. They only rely on the User and URL, so they aren't varying from operation to operation at this time.
https://teamcity.labkey.org/buildConfiguration/LabKey_2211Release_Premium_Ehr_DailyEhrPostgres/2185329?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildTestsSection=true&expandBuildChangesSection=true
https://github.com/LabKey/platform/pull/3942
Changes

Push a mock view context when we don't have one already

@bbimber FYI

thanks @labkey-jeckels. yes, I optimistically removed that MockViewContext, but I guess this needs it.  This is a background pipeline job that caused this, right? In any event, a MockViewContext has been injected by LK code for a long time, so it's probably not that much of an issue. It might be possible to side-step whatever code is trying to grab the URL, which I'd be happy to look at next week, but I'm not sure if's that big a deal to have this.

@bbimber I was able to handle the URL part without the mock ViewContext but passing the User around was going to be a lot harder.


updates react in test html

I tried viewing test.html and got these errors:

Updating React and JSXTranformer in test.html, and changing React.renderComponent to React.render fixes this:

¯\_(ツ)_/¯ ok I guess


Add option to only create zone config whern zonefiles are externally managed

Description
Currently, this cookbook expects to manage the zonefiles either continually, or at initial setup via :create_if_missing. This PR adds an action to have bind_primary_zone not touch the zonefiles at all when they are externally managed outside of this cookbook.
Issues Resolved
(none)
Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

Released as: 3.2.0


Implement Cypher support for Neo4j and Redisgraph

~PR #368 was merged into cypher support but we still need to merge it into master.
No new changes here-- this is from PR 368 which merged cypher_support_compiler_changes into cypher_support-- it's just that at the time, it was supposed to merge into the cypher_support rather than master and that never got changed.~
Implement Cypher support for Neo4j and Redisgraph. There are some significant differences between the way the two backends support Cypher, see 1 and 2 for starters, which is why we separate the two.

The Neo4j client does understand query parameters, for instance from the tutorial:
result = tx.run("CREATE (a:Greeting) "
                        "SET a.message = $message "
                        "RETURN a.message + ', from node ' + id(a)", message=message)

where message is a variable.
However, insert_arguments_into_{cypher, sql, gremlin, match}_query ends up being used in ./__init__.py in its graphql_to_cypher function and test_end_to_end.py, rather than with the Neo4j client. Right now there are no tests for Cypher in test_end_to_end.py but it follows the same pattern.

Unsure if redisgraph-py also supports query parameters. The documentation doesn't mention it, but I'll be able to test it out soon after this gets merged.

Update: I've looked through the entirety of the redisgraph python client codebase and haven't found anything for inserting arguments.
However there may be a hacky way to get this to work-- I'll update this as I find out more.

Follow up re: Neo4j's client being able to handle parameters.
It's pretty straightforward to call run with parameters-- something like this would be valid, given a Neo4j client called neo4j_client:
query = '''
MATCH (n:Animal)
WHERE n.net_worth = $net_worth
RETURN n
'''
parameters = {'net_worth': 100}
with neo4j_client.driver.session() as session:
    results = session.run(query, parameters)
return results.data()

The problem is, the client only supports certain types e.g. int, float, bool, string, dict but not Decimal (and we're passing in all our floats in as type decimal.Decimal in the parameters dictionary). Worse yet, it looks like there's no support for dates and datetimes in the function that handles all of this.
For reference, PackStreamDehydrator's dehydrate method seems to be doing the type checking. session.run() calls the fix_parameters function which calls the dehydrate method.
What approach makes more sense in this situation, use their library and try to patch up the types they don't support, or do the whole thing ourselves using the cypher formatting file?

What approach makes more sense in this situation, use their library and try to patch up the types they don't support, or do the whole thing ourselves using the cypher formatting file?

How about this: let's simply add a Float-typed field somewhere in the schema, and use that? For databases that don't support Decimal-typed fields, let's not use the field that is defined as Decimal at all -- pretend it doesn't exist.

Summary of changes:

Remove graph_to_neo4j_cypher function and make a note of it in the README and in the docstring for the RedisGraph function
Nits


Add to OpenVSX

For use with code-server and other non-microsoft distributions
https://open-vsx.org/

I just came here to add this issue. +1!
I am happy to help if you are open to PRs. For reference, here are the instructions: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions
If the author does not want to add to open-vsx, it can also be published via this repo:https://github.com/open-vsx/publish-extensions/blob/master/CONTRIBUTING.md. But this is only a backup plan; open-vsx prefers to have the authors publish directly.

@SamEdwardes any contribution will be appriciated. Feel free to open a PR

Hi @rhalaly, I look into the steps in more detail. They are all provided here: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions, but I will summarize:

Create an Eclipse account
Log in and sign the Publisher Agreement
Create an access token
Create the namespace
Package and upload

I was hoping that I could help more, but unfortunately, I think these are all steps that you would have to run.
Would you be able to look into this?
If not, I can create a PR to add your package via this repo: https://github.com/open-vsx/publish-extensions/blob/master/CONTRIBUTING.md. However, the open vsx maintainers prefer to have the extension publishers publish directly.

Thanks for the guidence @SamEdwardes! After some revivals and maintanance here, I've published the extension to open-vsx: https://open-vsx.org/extension/rhalaly/scope-to-this
There is a warning that I'm not a "verified publisher". I started the process to being verified, so don't worry :)
Although, I haven't tested it in other distributions than VSCode itself. I hope it will work smoothly. :)
I'm closing this issue for now. Please feel free to re-open it if needed

Awesome, thank you, @rhalaly. I appreciate it. If I run into any issues, I will create a new issue.


FIX Resource class name was not derived correctly from the Collection…

… name
this only worked if the Resource class did not have a Resource suffix (like in the first class_exists check) However the code clearly intends to support the Resource suffix aswell
does not break existing usage! fixes expected functionality

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Add subdivisions code

This would be a great feature (excellent help to parse addresses)

We have them for the countries that use them.
Example
https://github.com/hexorx/countries/blob/master/lib/data/subdivisions/DE.yaml#L2

I meant numerical codes (the beginning of postal codes, when applicable)
Example (the green code, only numbers)
http://www.geopostcodes.com/Germany
http://www.geopostcodes.com/Andalucia
http://www.geopostcodes.com/Cataluna


Support web

Supporting the web has very many restrictions due to the sandboxed web environment. Native threads, atomics, and time are not possible in webassembly and therefore many features are missing from the Rust's std and other crates due to these limitations.
flutter_rust_bridge does provide some way to utilize web workers and streams thanks to its bindings with JavaScript. However, there are still additional support needed from various libraries.

flutter_rust_bridge's 'no such method' error
tokio::time not working on webassembly because std::time::Instant does not support the web. Here's a link to the related forum post

We think that when Threads Proposal for WebAssembly is fully accepted and realized, support from Rust and various libraries will mature. For now, there is a long way to go.

Maybe we would need a workaround, such as using async runtime for webassembly.

There is really no need for web, because the pure web is too strong, and the mobile terminal and desktop should be perfect

Yes, I agree that mobile and desktop support should be perfect, and we should not compromise those features in order to support the web. Maybe supporting a subset or providing a separate main Rust function for wasm can be possible.
I believe that web support should be a separate feature if implemented. The demand for it IS much lower than native platforms, yes :)

References:

https://cjycode.com/flutter_rust_bridge/integrate/web.html
https://rustwasm.github.io/wasm-bindgen/api/wasm_bindgen_futures/
https://docs.rs/wasm-rs-async-executor/0.9.0/wasm_rs_async_executor/

The web can be used, but the performance is very slow. I have experienced the online demo, and it is not as smooth as the native web.

Hi @107295472 , thanks for telling us about the web :) Do you mind if I ask you for the link to that web app?

No, flutter's web is wasm

Yes, as far as I know, Flutter uses WASM and JavaScript for the web and it's known to be very slow. Why the web support is being considered though is that Flutter team is trying to make the web part faster and there are some demands from various people that want to use the same Rust code for the web backend. Hope we come up with a reasonable idea someday!
The main drawbacks right now:

Most async Rust runtimes like tokio is not available in WASM.
Async runtimes do not yield to JavaScript so they cannot receive messages or send them with other Web Workers.

There is really no need for web, because the pure web is too strong, and the mobile terminal and desktop should be perfect

I disagree, many people use Flutter for mainly mobile and web, with desktop usage being much lower (how many desktop apps have you installed recently compared to going to the web version? And most desktop versions like Figma, Slack etc are just Electron wrappers around the web app). There are also a lot of web based Flutter apps like Rive.
So I would definitely like to see web support for this library, I'm using flutter_rust_bridge currently for this.

There is really no need for web, because the pure web is too strong, and the mobile terminal and desktop should be perfect

I disagree, many people use Flutter for mainly mobile and web, with desktop usage being much lower (how many desktop apps have you installed recently compared to going to the web version? And most desktop versions like Figma, Slack etc are just Electron wrappers around the web app). There are also a lot of web based Flutter apps like Rive.
So I would definitely like to see web support for this library, I'm using flutter_rust_bridge currently for this.

While I agree that Flutter is mainly used for mobile and web as opposed to desktop, the addition of rust makes desktop more appealing. My biggest issue with Rust is UI support, so being able to use Flutter to develop UI desktop applications is welcoming. I don't have an issue with supporting web, but I do like that desktop support is the main focus of this project.

Support for the web seems to be successful and the new version will be released in a few days! Now you can target 6 platforms with Flutter and Rust with a single codebase. Version 2.0 will release once below tasks are done 😊

[ ] Modify bridge code
[ ] Use UniversalPlatform package in Dart
[x] Apply worker-single and zero-copy
[ ] Remove unneeded crates such as anyhow
[x] Remove print( and println!( used for debugging
[ ] Update code snippets
[ ] Simplify serve_web and detach wasm compilation wasm from running
[ ] Apply crossOriginIsolated policy to the web server
[ ] Add guides about threads and concurrency of wasm and non-wasm
[ ] Add a guide about switching Rust-analyzer to wasm mode
[ ] Add guides about running and building in wasm
[ ] Make sure web support appears on pub.dev
[ ] Check API visibility on pub.dev


[DSW-294] Email inline images compatibility

To best support inline images in HTML emails, the multipart structure is (according to this):

mixed

alternative

plain text
related

html
inline images

attachments

This is supported by mime-mail since version 0.5.0 but it breaks HaskellNet requirement <0.5 (only for example :man_facepalming:). Currently, it works from my fork of mime-mail without new versioning but I've already submitted PR to fix this: https://github.com/jtdaugherty/HaskellNet/pull/52

It doesn't seem that https://github.com/jtdaugherty/HaskellNet will create new release soon, can we leave it as it is now in stack.yaml?


Message: add 'undefined' check to rowData.image

sometimes we don't want to store/send redundant rowData.image = null if we don't need it.
add this check to prevent Required prop 'source' was not specified in 'Image'

thank you @zxcpoiu


max_vectors_per_token

what does 'max_vectors_per_token ' means? under what kind of situation? any example?

It was used as part of the experiment in the paper where we progressively add more vectors to the inversion. Probably not relevant to you unless you set progressive_words to True in the config.

Thanks for your response.

We describe this experiment in the paper. It is equivalent to starting training with only a single word representing your concept and adding more and more words as training progresses

many thanks!


Only retain relevant statistics in certain metrics

Is your feature request related to a problem? Please describe.
As I understand, in the add_batch() function, the raw predictions and references are kept (in memory?) until compute() is called.
https://github.com/huggingface/datasets/blob/e248247518140d5b0527ce2843a1a327e2902059/src/datasets/metric.py#L423-L442
This takes O(n) memory. However, for many (most?) metrics, this is not necessary. E.g., for accuracy, only the # correct and # total need to be recorded.
Describe the solution you'd like
Probably an inheritance hierarchy where "predictions" and "references" are not always the two keys for the final metric computation. Each metric should create and maintain its own relevant statistics, again for example, "n_correct" and "n_total" for accuracy.
I believe the metrics in AllenNLP (https://github.com/allenai/allennlp/tree/39c40fe38cd2fd36b3465b0b3c031f54ec824160/allennlp/training/metrics) can be used as a good reference.
Describe alternatives you've considered
At least Metric.compute() shouldn't hard-code "predictions" and "references" so that custom subclasses may override this behavior.
https://github.com/huggingface/datasets/blob/e248247518140d5b0527ce2843a1a327e2902059/src/datasets/metric.py#L399-L400

Since the metrics use Arrow to store the predictions/references adding a batch does not use more memory, only during compute all data is loaded. There are plans to avoid this (#168). Closing this in favour of the newer issue.


Properly handle the relayState in SAML

Providing the ability for client code to set & get the RelayState would be particularly helpful in our case.
We presently use RelayState in support of the ability to specify an alternate hostname in the callback URL, which handles the case where a Web Proxy or Load Balancer sits "in front" of the User Agent and Identity Provider.
More specifically, The IdP returns a SAML Response through the Web Proxy or Load Balancer (hostname="proxy"), which gets forwarded to our server software (hostname=myhost). If HTTP Session Cookies are used for this scenario, the cookie is lost because a different domain name is specified for the Web Proxy or Load Balancer (proxy) than the back-end server (myhost), and applying sticky rules is of no help here because the browser never sends the cookie. And loss of session state causes problems for our application. However, use of the RelayState remedies this problem for us since it enables the application to maintains state information without the use of HTTP session cookies.
Workaround
To set the RelayState in PAC4J, this call is made in a Filter that wraps the SecurityFilter httpSession.setAttribute(SAML2Client.SAML_RELAY_STATE_ATTRIBUTE, data);
And then retrieval of the RelayState is made through this call, in a Filter that wraps the CallbackFilter
String data = request.getParameter("RelayState");
Suggested change
It would be more convenient if an API were made available to client code for the purpose of getting & setting the RelayState for SAML. Also, an API would be supported, whereas I have no idea if/when the workaround I've employed might become incompatible with future versions.

The way the relay state is handled in the SAML support is a bit strange indeed (it relies on the web session and no check is done), we should certainly try to converge with what is already done for OAuth or OpenID Connect, this needs more investigation on the role of the relay state.

Hi @leleuj and @matthema -  sorry to revive this thread. Do you have any usage documentation for SAML2StateGenerator? The only thing I can find is here: https://github.com/fogbeam/cas_mirror/blob/master/support/cas-server-support-pac4j-webflow/src/main/java/org/apereo/cas/web/DelegatedClientWebflowManager.java#L85
Any other code samples or usage documentation would be much appreciated. Thanks!
(For full disclosure, I'm using akka-http-pac4j and have posted a similar message here: https://github.com/StackVista/akka-http-pac4j/issues/25)

The SAML relayState is generated from the StateGenerator (which currently uses the session to store the value): https://github.com/pac4j/pac4j/blob/master/pac4j-saml/src/main/java/org/pac4j/saml/state/SAML2StateGenerator.java
This is where you can put your own logic.

Thank you @leleuj, that is what I have done

In that case, I'm not sure to understand your question...

Sorry, I should have been clearer.
My first comment was made when I couldn't find any usage documentation for the SAML2StateGenerator.
After that (and on the linked message) I kind of figured things out for myself.
Your subsequent reply was helpful, and let me know that I was on the right track!
And now, anybody who wants to know more about the  SAML2StateGenerator has at least one more Google hit to guide them in the future.

Just provide a simple example for use SAML2StateGenerator. When I search "play pac4j saml2 relay state" in google, this issue is the first result.
If you want to replace SAML2StateGenerator by your own StateGenerator, there are 2 steps.

create a CustomStateGenerator class extends SAML2StateGenerator.

class CustomStateGenerator(client: SAML2Client) extends SAML2StateGenerator(client){
  override def generateState(webContext: WebContext): String = {
    // Return any value you want. You can get all request information form webContext
  }
}

In SecurityModule, configure SAML2Client to use your CustomStateGenerator

  @Provides
  def provideSaml2Client: SAML2Client = {
    val cfg = new SAML2Configuration("resource:samlKeystore.jks", "pac4j-demo-passwd", "pac4j-demo-passwd", "resource:openidp-feide.xml")
    cfg.setMaximumAuthenticationLifetime(3600)
    cfg.setServiceProviderEntityId("urn:mace:saml:pac4j.org")
    cfg.setServiceProviderMetadataPath(new File("target", "sp-metadata.xml").getAbsolutePath)
    val client = new SAML2Client(cfg)
    val stateGenerator = new CustomStateGenerator(client)
    client.setStateGenerator(stateGenerator)
    client
  }

Don't hesitate to supplement the documentation with this: https://github.com/pac4j/pac4j/blob/master/documentation/docs/clients/saml.md


check if column needs defaults set in BodyCellComponent.column setter

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Some users are able to construct BodyCellComponent without setColumnDefaults being called on the column. This causes an error because $$valueGetter is undefined #683
What is the new behavior?
BodyCellComponent column setter checks if defaults need to be set.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
May also fix #666 but I haven't reproduced that issue yet.

Ideally, column defaults should be checked at a higher level for efficiency. This does add a function call (the setter) and a few checks every time BodyCellComponent.column is set.
But I'm not sure how people are creating their tables so that they avoid this DatatableComponent code
  @Input() set columns(val: TableColumn[]) {
    if(val) {
      setColumnDefaults(val);
      this.recalculateColumns(val);
    }

Is there a better place to double-check column defaults?

I'm worried this doesn't actually fix the problem. I think Angular may be calling the value getter before column is set, so I want to reproduce the bug first before submitting a PR.

@amcdnl I don't know how some users avoid setColumnDefaults()
The demo/templates/template-dom.component.ts example doesn't set the columns attribute, but setColumnDefaults is still called.


cannot generate examples with plc

ghc: 8.6.5
hedgehog: 0.6.1 (it appears)
I get the following error message when trying to generate examples using plc. The evaluate and typecheck modes seem to work ok.
$ plc example -a
plc: Hedgehog.Gen.sample: too many discards, could not generate a sample
CallStack (from HasCallStack):
  error, called at src/Hedgehog/Internal/Gen.hs:1541:11 in hdghg-0.6.1-f3bad993:Hedgehog.Internal.Gen

Fixed by #1552.

thanks! Working for me now.


⚠ ClamAV has degraded performance

In b499818, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 452 ms

Resolved: ClamAV performance has improved in 14e03a3.


Drop down menu issue

In dropdown menu, 2nd level on navigation doesn't pops up.

submenus are in WIP #270

Closing in favour of https://github.com/Semantic-UI-Vue/Semantic-UI-Vue/issues/293


changeData on comboForce layout breaks the graph

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce
after few seconds call graph.changeData with new data and graph will break

Environment
Info

g6
4.3.3

System
-

Browser
-

in comboForce graph, when it's changeData is called, whole graph gets broken. On doing console log of graph.save() after changeData is called, it looks something like below:

Here, coordinates of all the nodes, edges and combos are NaN

This bug should be related to combo config and comboForce layout method, if using other layouts it can't reproduce.
So you can use graph.render() instead of graph.refresh() or switch to other layouts to solve the problem.
Then waiting for the bug can be fixed :)

This bug should be related to combo config and comboForce layout method, if using other layouts it can't reproduce.
So you can use graph.render() instead of graph.refresh() or switch to other layouts to solve the problem.
Then waiting for the bug can be fixed :)

For other layouts like force, grid, etc , it is working fine. It's only breaking for comboForce. And I cannot use other layouts because I need the "Combo" feature

Fixed. Upgrade @antv/layout to 0.1.15 pls.


Move to python 3.9 in the bundle for Big Sur support

🚀 Feature
This is an issue to discuss whether we should move to Python 3.9 for the bundled napari installation
Motivation
As mentioned in #2895, the bundle is currently incompatible with macOS Big Sur because it comes with Python 3.8. The workaround seems to be moving to the conda-forge distribution of Python 3.9. Moving to Python 3.9 in the bundle would mean users on Big Sur (including those on systems with M1 chips) could use the bundled installation of napari.
Are there any negatives of moving to 3.9 we should think about?
EDIT:
info from @tlambert03 (copied here from #2895)

As for 3.9, we had been waiting for the 3.9 briefcase support pack to drop. It's now available, and so is m1 support ... so it might be worth a try updating the bundle.

:+1: on this

bundle built and working locally without any fuss on Big Sur (running on an M1, but built for x86) - I just have to figure out how to replicate on github actions

actually... looks like you might have a bug there:

big trouble 🤣

actually... looks like you might have a bug there:

Actually it's a secret folder he has changed the icon of, to make sure nobody click on it.

For support macos arm natively you need to check if all packages with binary extension provides universal2 wheels.  At this moment imagecodecs does not provide.
Other solution may be create build base on conda.

I was not planning on building a native bundle (for now at least), I was planning to build with the conda-forge packaged python interpreter though

Briefcase packs it's own python interpreter... (https://github.com/beeware/Python-Apple-support) so I'm not sure that's going to be as easy as it might seem?  That is, it doesn't use the python in the build environment

oh! I assumed it was using my conda-forge interpreter and that was why it worked... it seems like the 3.9 briefcase interpreter already works out of the box then, great! 🙂

But it works using rosetta emulation or uses native architecture?
The main problem with rosetta is that it does not support vector instruction translation (SSE2 etc). This instruction could be used to speed up typical image processing operations.

It's using rosetta emulation (at least the way I built it). I understand it might not be the perfect solution, but it's at least better than the current situation which is no working bundle on Big Sur on any mac? Longer term I agree we should look at building a native bundle too

I agree. But with this update, there should be added proper annotation on the download page.

This has now been closed by #2991, thanks all!


Exception "Invalid operation on start activity cache. Fail to record the activity."

Using 2.2.0-beta1 w/ ApplicationInsights 2.14.0, I have got the following error in my logs.
    "RenderedMessage": "Invalid operation on start activity cache. Fail to record the activity.",
    "Exception": "System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.
    at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
    at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
    at Microsoft.ServiceProfiler.DictionaryExtension.GetOrAdd[TKey,TValue](IDictionary`2 dictionary, TKey key, Func`2 valueFactory)
    at Microsoft.ServiceProfiler.Sampling.SampleActivityContainer.AddSample(SampleActivity activity)
    at ServiceProfiler.EventPipe.Client.EventListeners.TraceSessionListener.AppendSampleActivity(SampleActivity activity)",

This happened twice back to back, early on after starting the process, then no longer. And I noticed that no Upload logs are presents (no idea if that related?). I restarted the process after from scratch and the error did not occur.
Attached are all the ServiceProfiler logs leading to the error and some after (noticed another exception at L300): profiler-error-logs.txt (I tried to format the JSON logs as best I could)
Environment:
Dev workstation, Windows 10 Pro, .NET Core 3.1.402

@dstj thanks for your feedback. I'll take a look.

This could trace back to: https://github.com/dotnet/runtime/issues/26868.
I'll issue an fix to the bug.

The fix is released with the latest package: https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/2.2.0-beta2


Add initial support for CosmosDB

Initial support for Cosmos DB into CAF module, as per https://www.terraform.io/docs/providers/azurerm/r/cosmosdb_account.html

[x] Account (Rahul)

[x] SQL (Rahul)

[ ] Cassandra (Ben)

[x] Mongo (Ben) - Still pending https://github.com/terraform-providers/terraform-provider-azurerm/issues/8660 to be resolved

[ ] Gremlin (Ben)

[ ] Table (Ben)

[ ] Add diagnostics capabilities

Work in progress

Created Cosmos account,
SQL database & Container.

Table API PR: https://github.com/aztfmod/terraform-azurerm-caf/pull/214

Cassandra API PR: https://github.com/aztfmod/terraform-azurerm-caf/pull/217

Gremlin API PR: https://github.com/aztfmod/terraform-azurerm-caf/pull/218

Refactoring of Mongo API for consistency with module hierarchy: https://github.com/aztfmod/terraform-azurerm-caf/pull/219