testing updated version with changes to user agent and headers

@shahzebsiddiqui this is a branch for you to test! You should be able to change your action to use this branch, and it will test https://github.com/urlstechie/urlchecker-python/pull/72.
Signed-off-by: vsoch<EMAIL_ADDRESS>

So i ran this pipeline https://github.com/buildtesters/buildtest/runs/6941983724?check_suite_focus=true and i am getting the same error. I guess if you want to add this link in check https://www.hpcwire.com/2019/01/17/pfizer-hpc-engineer-aims-to-automate-software-stack-testing/

I can also confirm that this page is getting me a 403 so i am inclined to keep this in the exclude list. Let me know if you want me to do any further testing.
 ~/ python3
Python 3.6.15 (default, Sep 23 2021, 15:41:43) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.get("https://www.hpcwire.com/2019/01/17/pfizer-hpc-engineer-aims-to-automate-software-stack-testing/")
<Response [403]>

Yeah, but the weird thing is that if you add a user agent header, it works for me (at least locally). I'm starting to think that they have explicitly blocked the ip addresses from GitHub actions.
I think you might just have to make an exception - I don't have any other ideas for how this could work (or why it's not working) but we aren't doing a good enough job emulating a browser.

Yeah I'll exclude this link that what I have right now. This is not the only link but several others didn't work. Overall this url checker works 95% of the time so it's still pretty good 👍

This is superceded by #95, which should help with some of these user-agent strings, and for the remainder I'm going to look into selenium soon!


Add hand tool shortcut

resolved in https://github.com/camunda/camunda-modeler/issues/125 via https://github.com/camunda/camunda-modeler/commit/6feb0104c409b8c1b26f7782859ee176224ba3f9


feat(zebra-state): Send a reference to latest non-finalized state in TipAction::Reset

Motivation
This is needed for the scanner task in zebra-scan (https://github.com/ZcashFoundation/zebra/issues/7905) to get any blocks in the non-finalized portion of the best chain when there is a Reset action without repeated calls to the state service.
Possible Design

Add the latest_non_finalized_state watch channel receiver
Add a method on LatestTipChange

accepting a previous block hash
check if it matches any previous_block_hash in the non-finalized best chain (follow the old chain from the tip until reaching a common ancestor block)
return all blocks after and including the block with a matching previous_block_hash, or
return all blocks in the non-finalized best chain if it doesn't find the provided hash

I think we're missing the ticket that this ticket enables:

[ ] When the best chain changes, scan the new blocks in the chain fork

I think we're missing the ticket that this ticket enables:

I was thinking this ticket could involve adding a method to be used instead of wait_for_tip_change() returning any new blocks on the chain that the receiver hasn't seen yet, so the task that scans new blocks as they come in would work for best change changes too.

@mpguerra did we decide to move this issue to a later sprint?

@upbqdn @oxarbitrage I was wondering about adding a state request for getting the latest non-finalized state instead of adding it here, which makes more sense?

We won't be doing any more work on the scanner


Search by POST and _revinclude=Provenance:target

Coverage increased (+0.01%) to 94.109% when pulling 6f2ad8f42f41f3c0fd7fc6bc01b31fcc47bb6eac on cody-post-search-revinclude-provenance into 48031f011d5961498dd02364d5df31c5768f4596 on main.


Add a HTML5-based logview

@itowlson
This adds a webview based log viewer. It adds 4 capabilities:

Filter matches
Hide matches
Show logs that follow match
Show logs that preceed match

Here's some screenshots to show how it works...
No filtering:

Matches /health

Hides /health

Logs after a specific date:

@itowlson thanks for the feedback. I'll add the "open in document" option and yes, follow logs is absolutely next on the list, I just wanted to get agreement on the added functionality before I did the work.
I'll address your detailed comments, and see how hard it is to add follow logs to this PR. It might be easier to do it in a follow on.
Thanks again for the thoughts and the feedback!

Comments addressed, new screen shot is attached.

You've got a few CI errors due to a bunch of strictness options being turned on in master.  The CI logs don't seem to actually list the warnings for some reason, but when I run tsc -p . locally I get:
src/components/describe/describeWebview.ts(2,1): error TS6133: 'Dictionary' is declared but its value is never read.
src/components/kubectl/logs.ts(9,1): error TS6133: 'host' is declared but its value is never read.
src/components/kubectl/logs.ts(11,1): error TS6133: 'ShellResult' is declared but its value is never read.
src/components/kubectl/logs.ts(96,13): error TS2532: Object is possibly 'undefined'.
src/components/kubectl/logs.ts(97,67): error TS2532: Object is possibly 'undefined'.
src/components/kubectl/logs.ts(99,27): error TS2532: Object is possibly 'undefined'.
src/components/webpanel/webpanel.ts(12,30): error TS7017: Element implicitly has an 'any' type because type 'Map<string, T>' has no index signature.
src/components/webpanel/webpanel.ts(17,13): error TS2322: Type 'undefined' is not assignable to type 'T'.
src/components/webpanel/webpanel.ts(27,9): error TS7017: Element implicitly has an 'any' type because type 'Map<string, T>' has no index signature.
src/components/webpanel/webpanel.ts(43,42): error TS6133: 'e' is declared but its value is never read.
src/components/webpanel/webpanel.ts(57,16): error TS7017: Element implicitly has an 'any' type because type 'Map<string, T>' has no index signature.
src/components/webpanel/webpanel.ts(69,24): error TS7010: 'update', which lacks return-type annotation, implicitly has an 'any' return type.

None of these will affect behaviour; I can fix them up before merge if you want.

I'm playing with the filter stuff and I've noticed some performance hiccups with large volumes of logs.  I created a logspouter pod for testing and it has perhaps been spouting too often for too long now... but the result is that when I switch from Show log entries: all to that match, it locks up for several seconds (the drop-down stays open and I can't click on the filter box).  Then when I type the first character of the filter, it freezes again.  Only as I type enough characters to filter the logs down to a more reasonable amount does it become responsive.
logspouter may well be unrepresentative of real k8s pod logs, as it was specifically created to emit logs often enough that I could experiment with tailing ideas - but then again a real pod might have lived far longer than logspouter's 5 days.  You have more experience than me of the sort of volumes that are realistic, and if you feel that it's responsive enough with realistic data sets then I trust you!  But it's definitely slower than I would like in this particular test case.
(I can give you access to logspouter if you want to try it - just let me know.)

Okay sorry to keep leaving naggy comments but there is also a glitch if you switch away from the logs window.  When you switch back it appears completely blank (no controls or Loading... message).  If, as with the logspouter test, it takes a long time to render, then there is no feedback during this time.
There is an option retainContextWhenHidden which appears to fix this - it does incur memory overhead, which is not exactly something VS Code needs more of, but worth it I feel....?  But again maybe it isn't going to be an issue for more realistic data sets.

If it helps to provide context, at the time I was playing with this stuff, logspouter had emitted about 186000 lines of logs with a total size of about 17MB.

Re the toolbar scrolling, I was playing with this for something else and this worked for me: https://stackoverflow.com/questions/9677894/header-div-stays-at-top-vertical-scrolling-div-below-with-scrollbar-only-attach.  The hardwired height is a bit of a cheat but we're not exactly writing a HTML style tutorial here... grin

Thanks, yeah, I had the toolbar pinned before, and I agree, I'll figure out to pin it again.
And thanks for the performance reports, I'll try to repro and fix.

Ok, so I put it under the electron performance microscope :) and it turns out that nearly all of the time is spent rendering, filtering is pretty fast, it's the actual pixel spitting that is slow.
I cleaned this up somewhat. Here's what I did:

Moved the filtering to an async method, so the UX won't freeze
Split the rendering up into batches via setTimeout so that the UX won't freeze and it will feel responsive (this actually works pretty slick, the only downside is that the scrollbar wiggles a little, but it's barely noticeable)
Added retainContentWhenHidden to the Webview so that the switching tabs thing doesn't happen.

At this point, I think it feels pretty good in terms of responsiveness.
Please take another look. I'll start a new PR to add support for following logs.

Performance is great now!  Thanks!
Unfortunately... (and apologies if this is something you're still working on)... the toolbar is now pinned but the content scrolls underneath it.  The logs need to be in a separate scrolling div.

Fixed. (though the length of time it took me to figure out how to do it is a clear sign I shouldn't be slinging CSS)
Please take another look...

Urgh, I am sorry to be a pain but... now the docking is working but the scroll bar is not visible...

...unless I horizontally scroll to it, which cuts off the beginning of the log lines...

The lines in the log file are not so long that they should require horizontal scrolling, and even if they were, it would be good if the vertical scroll bar were always visible...
(I have artifically ensmallened the VS Code window for screenshot purposes... if I embiggen it then I get a different misbehaviour:

Here the scroll bar does not dock to the RHS of the window.  So it does feel like a div width issue.)

I did have a go at fixing the scrollbar positioning but have had no luck I'm afraid - I think it's tricky with the progressive loading...

Yeah, I noticed that issue and hoped no one else would sigh
I'll work on fixing things some other way...

@itowlson a miracle occurred and I was enlighted about CSS. Well, not actually, but I did figure out what was needed here (I think) please re-check!
Thanks

I understand miracles are a core element of the CSS design workflow.  Thanks, will take a look!

Thanks (insert Neo/Matrix "I know CSS" meme here :)
I'll work on the follow logs implementation next.


[Terraform task] Failed to get existing workspaces: storage: service returned error: StatusCode=404, ErrorCode=ContainerNotFound, ErrorMessage=The specified container does not exist.

Extension does not ensure remote state storage container exists. The extension should either provide this or the documentation should indicate that additional steps be configured to create the container prior to using the extension.
##[section]Starting: Terraform : azurerm init
==============================================================================
Task         : Terraform
Description  : Execute terraform commands to manage resources on AzureRM, Amazon Web Services(AWS) and Google Cloud Platform(GCP)
Version      : 0.0.137
Author       : Microsoft Corporation
Help         : [Learn more about this task](https://aka.ms/AA5j5pf)
==============================================================================
[command]/opt/hostedtoolcache/terraform/0.11.14/x64/terraform init -backend=true -backend-config=storage_account_name=dmtestlpusctf01 -backend-config=container_name=terraform-state-client-azuread-demo-test-lp-01 -backend-config=key=demo-test-lp-01.terraform.tfstate -backend-config=resource_group_name=demo-test-lp-usc-rg-terraform-01 -backend-config=arm_subscription_id=2ad51abf-5c99-4c52-8bd9-fcceab4ea891 -backend-config=arm_tenant_id=*** -backend-config=arm_client_id=*** -backend-config=arm_client_secret=***

Initializing the backend...

Successfully configured the backend "azurerm"! Terraform will automatically
use this backend unless the backend configuration changes.
Failed to get existing workspaces: storage: service returned error: StatusCode=404, ErrorCode=ContainerNotFound, ErrorMessage=The specified container does not exist.
RequestId:b3d9b6c1-e01e-001e-5961-4c0d3f000000
Time:2019-08-06T14:18:26.9024870Z, RequestInitiated=Tue, 06 Aug 2019 14:18:26 GMT, RequestId=b3d9b6c1-e01e-001e-5961-4c0d3f000000, API Version=2016-05-31, QueryParameterName=, QueryParameterValue=
##[error]Error: The process '/opt/hostedtoolcache/terraform/0.11.14/x64/terraform' failed with exit code 1
##[section]Finishing: Terraform : azurerm init

This is already in pipeline but to some other priority task we are not able to pick this for now.
This repo is also available for contribution. You can also raise PR and assign to me. We will be happy to take changes.


Disable CONFIG_DEBUG_INFO_BTF for Fedora configs

Until this can get sorted out on the TuxSuite side.
Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/290

Is this needed for allmodconfig builds too, or just Fedora configs?

CONFIG_DEBUG_INFO does not get enabled with allmodconfig without explicit opt-in. As far as I am aware, the Fedora configurations are the only ones that show this right now but I'll keep an eye out in case we have to keep playing whack-a-mole.


Documentation Incorrect!

We have found that with all of the settings entered as shown above, we still don't have the three buttons in the upper right side of the screen that allows for screen sharing and other features in normal chat.
The instructions above only seem to pertain to screen sharing from within an actual meeting, not during chat.
After much time spent trying to figure out why our policies were failing to apply.
It turns out in addition to the above instructions,
You also need to enable the "Calling Policy" for the three buttons to appear in the upper right hand corner of the screen and allow screen sharing during regular chat sessions.
/OffTopicFrustration
It costs our IT department way too much time having to go back and correct mistakes we made because we followed MS documentation.
People go to Microsoft's official documentation to find instructions to help them.
Why do the users have to tell MS all the time that their own documents are wrong?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ce30163-6327-899b-281d-d4ef982fce5e
Version Independent ID: e61dcbb8-4877-ef6f-1987-981cdd7fc82f
Content: Configure desktop sharing in Microsoft Teams - Microsoft Teams
Content Source: Teams/configure-desktop-sharing.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: Lolaj

@Krytical13 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

The link is fixed and the doc has been republished. The issue is fixed.


ODataHelper from Cumulus and Club should be part of System.Utilities package

Currently several projects use OdataHelper methods (such as Cumulus and Club). This code should be organized in this repository to avoid duplication and diverged code.

moving the code with the same version leads to this error:
install-package Microsoft.AspNet.WebApi.OData -Version 5.2.0

Install failed. Rolling back...
install-package : Already referencing a newer version of 'Microsoft.Data.Edm'.
At line:1 char:1
+ install-package Microsoft.AspNet.WebApi.OData -Version 5.2.0
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
    + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PowerShell.Commands.InstallPackageCommand

Microsoft.Data.Edm 5.6.1     # < -- required/resolved
Microsoft.Data.Edm 5.6.4     # < -- installed

When installing the current version of OData then the required objects cannot be resolved. Packages with their versions which are then installed:
2.0.3 log4net
5.2.3 Microsoft.AspNet.WebApi
5.2.3 Microsoft.AspNet.WebApi.Client
5.2.3 Microsoft.AspNet.WebApi.Core
5.7.0 Microsoft.AspNet.WebApi.OData
5.2.3 Microsoft.AspNet.WebApi.WebHost
5.6.1 Microsoft.Data.Edm
5.6.4 Microsoft.Data.Edm
5.6.1 Microsoft.Data.OData
4.0.0 MSTestExtensions
6.0.8 Newtonsoft.Json
5.6.1 System.Spatial

Will leave the feature branch as is.
@rufer7 any idea on how to fix this?


Do not log sensitive information on startup

During Marathon startup, the first log to be written contains all credentials and sensitive information.
When system logs are forwarded and centralized, it could be an issue.
The log is written by https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/marathon/Main.scala#L51
And could be probably fixed using filtering on sensitive arguments like what follows --master, --zk and --http_credentials.

Hi there, just FYI - I'd like to take this one as my first Marathon issue.

Hello,
to solve this straight forward we could just filter args on given values in Main.scala line:65
However, I do not like this approach because it causes arg parsing boilerplate (e.g distinguish between args provided as key value and key=value ...) that is already done by scallop library used in Marathon. Scallop provides ScallopConf.summary we could replace the logging statement with it. Unfortunately, scallop does not filter the arguments.
I made a PR with filtered summary in scallop. It could be used in marathon after it is merged.

I left a comment on the scallop commit regarding subbuilders and invoking
filteredSummary there too
On Tue, Feb 21, 2017 at 2:23 PM, Ivan Morozov<EMAIL_ADDRESS>wrote:

Hello,
to solve this straight forward we could just filter args on given values
in Main.scala line:65
https://github.com/mesosphere/marathon/blob/ca9e12641e637d46c622e8549a734d98030c2d6a/src/main/scala/mesosphere/marathon/Main.scala#L65
However, I do not like this approach because it causes arg parsing
boilerplate (e.g distinguish between args provided as key value and
key=value ...) that is already done by scallop library used in Marathon.
Scallop provides ScallopConf.summary we could replace the logging
statement with it. Unfortunately, scallop does not filter the arguments.
I made a PR with filtered summary in scallop
https://github.com/scallop/scallop/pull/131. It could be used in
marathon after it is merged.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/marathon/issues/4647#issuecomment-281451663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACPVLHokd1_RLI4cDxG9ra6MH3ZnI0x4ks5rezm4gaJpZM4Kue7Z
.

@jdef done and merged. To used would mean to upgrade marathon scallop version any objections on that?

@allquantor I'm guessing we pull in our scallop dependency from chaos here: https://github.com/mesosphere/chaos/blob/master/project/build.scala#L130
I think we've recently added an item to the roadmap for eliminating the dependency on chaos. Scallop may be on the chopping block too. If Marathon 1.5 will continue to use Scallop then it's probably worth an upgrade.
@jasongilanfarr care to chime in here?

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2071. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


HHH-18325: Prevent comparison between proxied and non-proxied statements

Some JDBC connection pools create a dynamic reflective Proxy wrapper around connections in the pool, plus the generated statements and the result sets those statements create, with the proxies allowing for methods calls to be intercepted by the connection pool for the purposes of returning items to the pool when they're released rather than destroying the underlying database connection. Tomcat's JDBC pool implementation does not correctly wrap the full chain of objects, meaning the raw Statement can be retrieved from a ResultSet rather than returning the proxied statement. This results in the ResourceRegistry cache attempting to store both the proxied Statement and the non-proxied Statement in its cache, but encountering an exception when the HashMap encounters two entries with the same HashCode and then attempts to differentiate them with an equals call which Tomcat's wrapper expects both instances to be proxied connections. To overcome this issue in Tomcat, as well as any other pool implementation which may use Proxy classes but leak the un-proxied entries, the original PreparedStatement used to create the ResultSet is being passed into the GeneratedValuesHelper for passing into the ResourceRegistry, rather than the GeneratedValues helper attempting to extract the Statement from the ResultSet.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-18325

Tomcat's JDBC pool implementation does not correctly wrap the full chain of objects, meaning the raw Statement can be retrieved from a ResultSet rather than returning the proxied statement.

That sounds like a bug in the Tomcat connection pool, and is something that should be fixed in Tomcat.
Thus, I would argue against merging this PR.
That said, I am not at all a fan of our ResourceRegistry and:

I would much prefer to see it go away,
but, if that's impossible, could it at least be changed to use an IdentityHashMap?

@sebersole ?

That sounds like a bug in the Tomcat connection pool, and is something that should be fixed in Tomcat.

Agreed, the original detection of this is due to an issue in Tomcat, which I've raised a separate bug and proposed fix for

Thus, I would argue against merging this PR.

The bug in Tomcat has highlighted that Hibernate is discarding objects that it then has to retrieve later on but could be easily passed through the calls to the ResourceRegistry. If the ResourceRegistry can be killed off then this largely becomes irrelevant, but just now Hibernate is presuming that statement.equals(statement.getResultSet().getStatement()) == true which isn't mentioned as a requirement in the JDBC specification, so this MR still provides value in making Hibernate resilient to different Driver or Connection Pool implementations.

but, if that's impossible, could it at least be changed to use an IdentityHashMap?

There's nothing in the JDBC spec that says the same instance has to be returned for a Statement and the calls to a child ResultSet's getStatement method (i.e. Connection Pools or Drivers could create new wrapper/proxy instances for those 2 calls) so an IdentityHashMap still carries a risk of a memory leak.

That said, I am not at all a fan of our ResourceRegistry and:

I would much prefer to see it go away,
but, if that's impossible, could it at least be changed to use an IdentityHashMap?

IdentityHashMap is not going to help, so your (2) is a moot point.
As for ResourceRegistry going away, I'm not against it but it does serve a few purposes which then need to be handled in some other way.  I think we have to look at the different parts of the ResourceRegistry:

LOB reference tracking.  As we create LOB references via the JDBC Connection, we register them here to ensure we can clean them up later.
Statement/ResultSet tracking.  In many ways this is used as a super complicated try-with-resource and in many cases we can probably just not do that anymore.  However, there are cases (scrolling, ..) where we do need to track these and we'd need to come up a different solution.

Historically that second usage has always been in Hibernate, it was just previously done in a worse way before the introduction of LogicalConnection and the redesign of batching.  I've never liked the fact that we keep this, but dropping it is not easy (or at least was not when I last tried).

I'm fine with the change.  I agree with @mc1arke that it, at worst, makes Hibernate more robust.

I'm fine with the change. I agree with @mc1arke that it, at worst, makes Hibernate more robust.

OK, fine. I withdraw my objection.


Feature/commands refactor

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.

retest this please


templateSimpleExpression - add line number

I have a question @rrd108
If I want to print a new thing, in this case the Line Number, how can I reproduce a fail test so I can see the real output (as if I was an end user). I don't have that much experience with tests so I'm a bit confused

There are multiple ways to do it.
One is to use the debugger. If you use vscode you can press Shift + Ctrl + p to open the command pallet and start typing debug. There will be an option in the dropdown called Debug: JavaScript Debug Terminal
If you select it, it will open a new debug terminal.
Now you can add a breakpoint anywhere in the code by clicking before the line number. A red dot will appear.
If you execute yarn test in the JS Debug Terminal it will run all the tests, and will stop at the breakpoint. There you can check any js variable.
The other way is to issue yarn build in the normal terminal, and then execute yarn analyze /path/to/any/vuejs/folder
This will actually run the analyzer on the selected folder, and you will get all console outputs.
In this case the dist folder will be overwritten, please leave it out from the PR.

I just created a sample component to test a few things:

And then I run yarn build and yarn analyze /src/demo/DemoComponent.vue but it only shows me this on console

And in vscode, the dist/cli.js file opens by itself and its content is this

Is there any specific node version I should use? or why I'm not able to visualize the output for my demo component?

@David-Pena try executing yarn analyze /src/demo
Analyze accepts folders, not files.

Good morning @rrd108
I tried that but the result is the same

That is strange.
Can you please try to run it in a normal terminal and not the js debug terminal? Do you get the same?

Yes, it happens with other terminals too (I tried bash and cmd).
I created this draft PR for this issue https://github.com/rrd108/vue-mess-detector/pull/58. It's a draft PR because I couldn't verify it as an end user (I couldn't see the actual output the package gives)
Maybe someone else can try running it?

I did some quick reserch and it seems to be some OS level problem.
Anyway I fixed this at a1203bbb509e6bc5765749afae6e8fc9e9908ae1
Your solution was not in line with the other line number solutions, but I used some idea from your code :)
So you can cloce the PR as the issue is already fixed.

Hi @rrd108 I finally was able to reproduce the logs without any error, it worked with the build step and then executing the command from the docs npx vue-mess-detector analyze path/to/fle.
With yarn analyze path/to/file it doesnt work (I'm not sure if its suppose to but with the command from the docs is more than enough!


bugfix: fix get mountpoint by metadata

Ⅰ. Describe what this PR did
fix get mountpoint by metadata for local volume driver.
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NA
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang<EMAIL_ADDRESS>

Do we have some kind of bug report? @rudyfly
Or can we add more description about how to reproduce the bug?
Since that, it could be much easier for us to review. Thanks a lot.

@allencloud  I have modified PR's description, do you still have something to understand?


Feature/canvas flow reorder filter

Fix:
When reordering static elements we should skip these siblings as they are not a bit standing somewhere outside of the flow layout:

absolute
float
relative with at least one position property set

The fallback strategy still shows the slider control for these (except for absolute)
Commit Details:

added float to specialSizeMeasurements
filter selected element in isApplicable
filter potential reorder sibling target when dragging an element over these special siblings
test

should we apply the same sibling exclusion for Flex reorder? I think so!

yes! relatives in flex need to be excluded from reorder too :)


WIP Chat 2: Part 12 - bugfix finalized

[ ] need https://github.com/keybase/client/pull/10820 merged up into this for this to work

@buoyad this is a wip cause i need that core fix (it's hardcoded to be finalized always) but you can start to look


add text about log(theta) estimates

Numerical values should be reported, but not bothering adding to tables for this year.

log(theta) values now calculated in custom-knitr-variables.r and numerical values reported in revised text under "Model Fit" within "Assessment model results". Not sure if my notation of
$\log(\theta_{\mbox{surv}})$ and $\log(\theta_{\mbox{fish}})$
is ideal, so feel free to adjust as you wish.

So the multinomial likelihood equation is repeated for the survey data and the catch data, yes? Again, I'll just add a sentence to explain this. Just want to double check. See commit that references this issue....

Changes to text about Dirichlet-Multinomial all look good to me. Definitely an improvement.
If you prefer \log \theta to \log(\theta) as written on the final line on page 42, then we should remove the parentheses on \log(\theta) elsewhere for consistency.

Thanks. I do prefer no (.) , but then realised I'd have to change others. Probably should change them but no big deal if we miss any.

No parentheses does look cleaner and it should be easy to change them, but I'll leave that to you to avoid conflicting edits. Note that log(theta) also occurs in Table 17.

That Table one is the only one in hake-assessment.tex, but leaving it, not crucial.


Added Germantown Muncipal School District

District Website: gmsdk12.org
2017 - 2018 Houston High School Course Catalog: HHS Course Catalog 2017-18.pdf
"AP Computer Science Principals", "AP Computer Science A", "Coding I", "Coding II Honors", "Programming & Software Development Dual Enrollment", and "Mobile App Development" are all on pages 11 and 12
I hope that this counts as official proof that students.gmsdk12.org is the students' email domain for GMSD: Logging into Office365.pdf

@MrKoookaburra  Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


[cluster-test] Use default port in --swarm if port is not specified

This allows to use --swarm --peers ip1,ip2,ip3 instead of --swarm --peers ip1:8000,ip2:8000,ip3:8000
Custom port can still be specified, for example --swarm --peers ip1,ip2:6000,ip3 is a valid command

@bors-libra r+

:pushpin: Commit 7c7c176 has been approved by ankushagarwal

@bors-libra r=ankushagarwal

:pushpin: Commit b3eb384 has been approved by ankushagarwal

:hourglass: Testing commit b3eb3841b6e884b807d4135f0331788900a7ae6b with merge 839b86f3933bdf001ffd109f378f49b86f7296d5...

:broken_heart: Test failed - checks-actions_land_blocking_test

@bors-libra r=ankushagarwal

:pushpin: Commit ec3cef1 has been approved by ankushagarwal

:hourglass: Testing commit ec3cef18f6de2e851559dcc9d3f12aff08f7f4ed with merge 2acd5174bfb5af38db0bc86a4855f3770c6e100e...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 2acd5174bfb5af38db0bc86a4855f3770c6e100e to master...


using blobscan API or GUI, depending on blobs-url config param

Generally, I think it looks good! Though, I will say that as this is meant more as an ad-hoc solution, I don't think we necessarily need to support both methods at the same time. I was roughly imagining something like:

I suppose it would be possible to test whether we can sync by switching the program versions, but IMHO it would be a major hassle...

1. Make the API-specific things separate from the client and make create a trait for whatever the client need.

2. Make a scraper that can act in place of the API. (implementing that trait too of course)

Well, isn't that what's implemented?

I'm fine with this method too though. It will just be slightly more work to decouple it once we actually do.

At the end of the day, it's just a code change - we can cross that bridge when we get to it...


Is the gradient penalty loss problematic when input image is large?

Hi,
Here the sum of squares is computed
slopes = tf.sqrt(tf.reduce_sum(tf.square(gradients), reduction_indices=[1]))
However, when the input image is extremely large, the dimension of gradients would be huge. It seems possible that the resulting slopes would be extremely large compared to 1.
Is this the case?

In theory I agree with you; in practice I haven't found compelling evidence that it's a problem. If you find any I'd love to know :)

You might want to experiment with replacing the penalty of (norm(grad) - 1)^2 by (norm(grad) - k)^2 for a larger k > 1.
Let us know if you find anything interesting :)


Properly merge arrays of allowed hash algorithms.

The + operator does not renumber array keys.
The keys that existed on the left side will replace fields from the
right hand side with the same keys.
On my installation, md2 and md4 would left out of the final result.
This was detected by static analysis (Phan dev-master). I don't have a personal use case
for md2/md4.
php > echo count(array_merge([0,1], hash_algos()));
54
php > echo count([0,1] + hash_algos());
52

Provide a narrative description of what you are trying to accomplish:

[x] Are you fixing a bug?

[x] Detail how the bug is invoked currently.
[x] Detail the original, incorrect behavior. (md2 and md4 aren't allowed hashes for SessionConfig->setHashFunction, probably unintentionally)
[x] Detail the new, expected behavior. (md2/md4 are allowed)
[x] Base your feature on the master branch, and submit against that branch.
[x] Add a regression test that demonstrates the bug, and proves the fix.
[x] Add a CHANGELOG.md entry for the fix.

[ ] Are you creating a new feature?

[ ] Why is the new feature needed? What purpose does it serve?
[ ] How will users use the new feature?
[ ] Base your feature on the develop branch, and submit against that branch.
[ ] Add only one feature per pull request; split multiple features over multiple pull requests
[ ] Add tests for the new feature.
[ ] Add documentation for the new feature.
[ ] Add a CHANGELOG.md entry for the new feature.

[ ] Is this related to quality assurance?

[ ] Is this related to documentation?

Thanks, @TysonAndre!


s3: parallel upload

this pr introduces the use of threads to upload files in parallel -- inspired by jekyll-s3.
using this on a site with 18 files (636k) on a 14mbit dsl connection, it cuts the upload time consumption by ~50%. before: ~6 seconds. after: ~3 seconds. by ~25%. before: ~12 seconds. after: ~9 seconds.
this feature will also be configurable in _deploy.yml via parallel: true|false and defaults to true.
i didn't get around refactoring quite a bit. sorry ;)

bump.

@imathis can we get this done?

bump.


"File URL" in "Files upload and handling" example can be improved

I like how nicely you integrated concept of files into the database!
But let me suggest some improvements for the documentation.
I'm talking about this page: https://pocketbase.io/docs/files-handling/, "File URL" section.
In the beginning:

Each uploaded file could be accessed by requesting its file url:
http://localhost:8090/api/files/COLLECTION_ID_OR_NAME/RECORD_ID/FILENAME

Probably worth mentioning that FILENAME is not name of the file which was uploaded, but rather "RANDOM_STRING_OF_32_CHARACTERS.ORIGINAL_EXTENSION".
It would also answer my original question: what happens if someone tries to upload two different files with a same filename into one field? - Nothing bad, since original filename is lost.
As a sidenote: I don't know how to test it, but I hope that you have some protection in case someone tries to upload a file with a "path traversal" (/../../) in extension.
And at the end of this section, this example:
// returns something like:
// http://localhost:8090/api/files/demo/9bca0d32-bbc8-4e82-b6a2-08a9dc6e2a19/1234b76.png?thumb=100x250
const url = client.Records.getFileUrl(record, firstFilename, {"thumb": "100x250"});

I would update return example to match what it currently returns (with a different style of record ID and filename):
http://localhost:8090/api/files/demo/KfZjt5OY8r34HVN/52iWbGINpUXB3prKOPa857IiZRV4RZjL.png?thumb=100x250

About the /../../ as part of the extension name - this usually shouldn't be supported by the OS and even if you somehow manage to upload a valid file with slashes it will be either ignored or escaped (eg. __0x2f__..__0x2f__..__0x2f__).
And further, in PocketBase this doesn't matter because we always set a "root" storage directory path (default to pb_data/storage) when intializing the filesystem abstraction and  you can't go outside of that directory (https://github.com/pocketbase/pocketbase/blob/master/core/base.go#L349).
Otherwise, thanks for doc tips. I'll try to update them this evening.

@Lex-2008 I've updated the Files upload and handling documentation with some of your suggestions.
Thanks again and feel free to let me know if you think its not OK as it is now!


Feature request: Add flag to identify whether a user was logged in via SSO

I would like to add a flag to the session like request.session["is_sso"] to indicate to other parts of my app that the user's session was established via SSO.
In order to support this feature, you could simply add a flag to the request that tells us that it was authenticated via SSO or via username/password.
This would allow us to use a django signal on login to then set the field.
Another option is to add ability to pass an on_logged_in callback so users of your library can modify the session immediately on establishment with arbitrary logic.

Hi @jkgenser
I don't think it's documented anywhere but you could maybe achieve this already with the user.backend attribute:
https://github.com/django/django/blob/cbf1e87398a58737e27e1b680283903caf661f90/django/contrib/auth/__init__.py#L87 This wouldn't work if you wanted to differentiate between uses of the django-authlib ModelBackend of course.
You could also write your own email_login helper:
from functools import partial
from authlib.views import email_login, oauth2
def my_email_login(request, **kwargs):
    user, created = email_login(request, **kwargs)
    if user:
        request.session["is_sso"] = True
    return user, created

my_oauth2 = partial(oauth2, email_login=email_login)

Or maybe even better, override post_login_response with your own callable which does all the things you want? https://github.com/matthiask/django-authlib/blob/8c47aea03d8cedb2cf494d320c60db6a33283b9d/authlib/views.py#L79
I'm not against adding additional functionality to django-authlib, e.g. a signal or something, if there are good reasons why the existing hooks aren't sufficient?
Thanks!


Add supply/demands for basins in allocation to allocation.arrow output

What
The supply/demand of basins is computed (since https://github.com/Deltares/Ribasim/pull/1082) but never stored. I propose to store this information in the allocation.arrow output file. It fits in there quite well, apart from that the column name user_node_id must be generalized to something that encompasses all nodes that have a demand.

It fits in there quite well, apart from that the column name user_node_id must be generalized to something that encompasses all nodes that have a demand.

Sounds like the combination of node_type and node_id will do, in light of #1113.


Add support for STSAssumeRoleSessionCredentialsProvider

Closes #136

@anshlykov thanks for your patience. We need to handle this use case when sts dependency is missing and then once @eddumelendez agrees I would be happy to merge it!


[Feature Request] Command to generate Spacefile

It would be useful in some cases to have a generate command which generates a Spacefile, similar to new but without having to create a new project. If the file exists, it should prompt to overwrite if a command line flag was not provided to overwrite.

i remember having/suggesting this. do we still have the code, @brkp?


#10 Fixing remaining FCC eslint errors

I did it! Finally got through all the errors!
The biggest change going forward is the need to use PropTypes for any props on React components. If you haven't seen that before, a good guide is here: https://facebook.github.io/react/docs/typechecking-with-proptypes.html.
In short, PropTypes gives us type checking on our React components so we can make sure that we are using booleans where we expect booleans, strings where we expect strings, etc.
The other change worth noting is I changed the keys in the database to camel case. This will either require a migration of your existing data, or the easier way is to just blow away the database and start fresh.
As far as I can tell, everything on the site works as it was before I made all of these changes. Please give this a runthrough before merging in case I did break anything that wasn't already broken before!
If everything looks good, we can close issue #10 and celebrate that our linting is just a great as the main FCC codebase! 💯 🥇

That green checkmark from Travis CI is beautiful.


Scrcpy device not found

hello i am using realme 6.when i use scrcpy in cmd all it shows is device not found and i also use abd devices it shows nothing but a line"list of device".i enable debugging in mobile and i don't know whats wrong

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#device-not-detected

i read lots of thing before writting here
i do whats it say in the above link and it still dont work

Basically, you need to make your device detected by adb before trying to run scrcpy.
If it does not work, the cause of your issue is system and device specific, so you could check on stackoverflow, for example https://stackoverflow.com/questions/10705089/how-to-fix-error-device-not-found-with-adb-exe/10705506

thanks for your help
but i still coundn't connect my device
i dont know whats happening
i tried everything installing driver,changing the path,enabling debugging, but still dont work

this the error i get when i want to start scrcpy

Please do not post screenshots of terminals, but just the terminal content as text. It allows searching or copy-pasting.

adb server version (31) doesn't match this client (41); killing...

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#conflicts-between-adb-versions

okay
DO i need to install ADB before using scrcpy?

It's included in the release.

Sorry for the screenshot
this is te way i do,tell me if i am wrong

the error is
when i run adb ,it shows empty list with the title "list of device"
and for scrcpy ,it shows"failed to get feature set:no device emulator found,adb push returened value 1"

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#device-not-detected


Will the ATP create a separate container in the storage for the scan results?

Does ATP create a separate container in the storage selected for saving scan results?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcc04833-193c-4ab6-678e-de078b7275ce
Version Independent ID: 289a64b5-4031-3876-6566-dbb45a8e98d5
Content: Advanced Threat Protection - Azure SQL Database
Content Source: articles/sql-database/sql-advanced-threat-protection.md
Service: sql-database
GitHub Login: @ronitr
Microsoft Alias: ronitr

Once you configure a storage account, then YES - a new separate container will be created where your vulnerability assessment scan results are stored.

@v-maroge Do you have any additional questions? If not, we will proceed to close this thread.

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


override vterm_unicode_width with utf_char2cells

Some unicode characters are displayed as two cells in vim but there are displayed as one cell in :terminal. Below is workaround patch to fix this issue. But I wonder whether we should apply patches for libvterm.
@brammool  how do you think?
diff --git a/src/libvterm/src/unicode.c b/src/libvterm/src/unicode.c
index b989add3c..8383f67e6 100644
--- a/src/libvterm/src/unicode.c
+++ b/src/libvterm/src/unicode.c
@@ -181,6 +181,7 @@ static int bisearch(uint32_t ucs, const struct interval *table, int max) {
  */

+#if 0
 static int mk_wcwidth(uint32_t ucs)
 {
   /* test for 8-bit control characters */
@@ -211,6 +212,7 @@ static int mk_wcwidth(uint32_t ucs)
       (ucs >= 0x20000 && ucs <= 0x2fffd) ||
       (ucs >= 0x30000 && ucs <= 0x3fffd)));
 }
+#endif

 #if 0 /* unused */
 static int mk_wcswidth(const uint32_t *pwcs, size_t n)
@@ -322,7 +324,8 @@ static int mk_wcswidth_cjk(const uint32_t *pwcs, size_t n)

 INTERNAL int vterm_unicode_width(uint32_t codepoint)
 {
-  return mk_wcwidth(codepoint);
+  extern int utf_char2cells(int);
+  return utf_char2cells((int) codepoint);
 }

 INTERNAL int vterm_unicode_is_combining(uint32_t codepoint)

Yasuhiro Matsumoto wrote:

Some unicode characters are displayed as two cells in vim but there
are displayed as one cell in :terminal. Below is workaround patch to
fix this issue. But I wonder whether we should apply patches for
libvterm.
@brammool  how do you think?

Thanks for the idea. I think we should do the same as with vsnprintf().
--
A consultant is a person who takes your money and annoys your employees while
tirelessly searching for the best way to extend the consulting contract.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Fixed by 8.0.0985.


Remove docs/containers for insecure releases

description
checking the docs page, i think some of the docs relate to builds/releases for which there are known sec issues:
https://www.envoyproxy.io/docs
(also, some of the links are dead)
afaict there are also still dockerhub images with a similar issue:
https://hub.docker.com/r/envoyproxy/envoy/tags?page=1&ordering=last_updated&name=1.17
if you read the docs and look at the published images there is no way of knowing that some versions should be avoided
imho we should probably just delete all images and docs other than the latest for each minor version

cc @mattklein123

I don't think we can remove old images, because for better or worse people may be pinned to them.
I think removing old releases is very reasonable. Do you want to do a PR over on the docs site? https://github.com/envoyproxy/envoyproxy.github.io/blob/c470b304486a3ca1edbc50527c1f5ea32e2db290/_config.yml#L25

sort of yes - the repo is huge - need to find some disk space to do it
after playing with netlify over on envoy-playground - i like it a lot - but i guess that is a separate issue

also just thinking we may need to change envoy ci too to prevent changes being overwritten (ill check further)

the other thing i need to procede with this are:

supported versions
list of known insecure versions


chore: Fix links

What ❔
1.fix links since zksync_core has been moved
2.fix code line eg.process_l1_batch

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via zk spellcheck.

Thank you, though at this moment we don't merge small contributions (see contributing FAQ).


Getting Segmentation fault on running asn1c with some changes to source file

Hi
I recently made some changes to the source file of asn1c and tried compiling a set of ASN files with this new version of asn1c but I'm getting segmentation fault

I made some major changes so can't go looking for changes in each file. Is there a way to know which file might be causing this segmentation fault?

Doesn't the debugger catch the exception?


Nightly test failure log

This is an issue to contain tracking comments from the new nightly CI runs of the full test matrix.  Maintainers can subscribe to this issue to get notified whenever the nightly CI encounters issues.

Oversubscribed VM, nothing to worry about for us.

Oversubscribed VM again.

Oversubscribed VM - nothing to worry about.

The last five failures (while I was away on leave), numbered from oldest to newest:

Some sort of unlucky hang:

test.python.quantum_info.states.test_densitymatrix.TestDensityMatrix.test_drawings [] ... inprogress

This was only in Windows on Python 3.10, which is also tested in the PR CI and passed. We might want to keep an eye on that, in case it happens again.

Oversubscribed VM.

A stochastic failure on the Windows Python 3.7 job:
test.python.algorithms.test_amplitude_estimators.TestSineIntegral.test_confidence_intervals_2
---------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "D:\a\1\s\test-job\lib\site-packages\ddt.py", line 191, in wrapper
    return func(self, *args, **kwargs)

      File "D:\a\1\s\test\python\algorithms\test_amplitude_estimators.py", line 412, in test_confidence_intervals
    self.assertGreater(self._statevector.time_taken, 0.0)

      File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\unittest\case.py", line 1251, in assertGreater
    self.fail(self._formatMessage(msg, standardMsg))

      File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\unittest\case.py", line 693, in fail
    raise self.failureException(msg)

    AssertionError: 0.0 not greater than 0.0

Strange build/install failures within matplotlib

Issues caused by setuptools 64.

When that happens it means that the test runner worker process stopped for some reason that python doesn't know about so didn't report a result status to stestr. The normal cause of this is a segfault or a similar class of errors. These can be tricky to debug in CI because we typically need extra debug information like kernel logs or a core dump which we don't typically collect.

This most recent failure is the same as point 3 in my previous comment, and I've seen it in several PR CI runs as well, so we definitely need a fix.

Oversubscribed VM.

Oversubscribed VM

Oversubscribed VM

Dodgy network link

Nightly slow test run failed at commit 93fbc0d.
Logs: https://github.com/Qiskit/qiskit-terra/actions/runs/3529073518.

This should be fixed by #9192

VM timeout.

I've been away for a month, which is why there's a lot of errors.  All the failures to do with 62eaa5d (and several before those) are due to issues with Numpy 1.24 on the stable branch, where the Numpy fix hasn't been backported.

Ok, as of now we should be back on top of the nightly runs, after Matthew and I were away for a lot of December, and a few more things broke stable this week too.
The two most recent failures (one on main, one on stable) are because of networking issues on the Azure Linux VMs overnight, but all other tests passed.

Last two failures are VM timeout and dodgy networks, not us.

Dodgy VM/networking.

VM management issue.

The previous three comments (and probably still a couple to come) are related to #9672.

@ElePT I'm wondering why the backend primitives fail to call the bound pass manager at slow test. Do you have any idea? Your fix #9674 looks correct to me...
https://github.com/Qiskit/qiskit-terra/actions/runs/4954977087/jobs/8863956398#step:5:22086
==============================
Failed 2 tests - output below:
==============================

test.python.primitives.test_backend_estimator.TestBackendEstimator.test_bound_pass_manager
------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/runner/work/qiskit-terra/qiskit-terra/test/python/primitives/test_backend_estimator.py", line 349, in test_bound_pass_manager
    self.assertEqual(mock_pass.call_count, 2)

      File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/unittest/case.py", line 845, in assertEqual
    assertion_func(first, second, msg=msg)

      File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/unittest/case.py", line 838, in _baseAssertEqual
    raise self.failureException(msg)

    AssertionError: 0 != 2

test.python.primitives.test_backend_sampler.TestBackendSampler.test_bound_pass_manager
--------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/runner/work/qiskit-terra/qiskit-terra/test/python/primitives/test_backend_sampler.py", line 401, in test_bound_pass_manager
    self.assertEqual(mock_pass.call_count, 2)

      File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/unittest/case.py", line 845, in assertEqual
    assertion_func(first, second, msg=msg)

      File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/unittest/case.py", line 838, in _baseAssertEqual
    raise self.failureException(msg)

    AssertionError: 0 != 2

I don't exactly know why it is failing, but I am thinking of other alternatives. It is particularly strange that for a while it was running fine, right? It might be related to some library update.

I don't know when the failure started, but it might last for months. It failed at least three weeks ago. https://github.com/Qiskit/qiskit-terra/actions/runs/4782272346/jobs/8501452366#step:5:22303

This seems the oldest failure after #9672 was merged, which happened on Mar 2.
https://github.com/Qiskit/qiskit-terra/actions/runs/4310392927/jobs/7518775522#step:5:19953

The nightly azure jobs are failing now with Python 3.12 because pyzmq doesn't support Python 3.12 yet and is a requirement of the jupyter stack.
It also looks like the azure nightly jobs haven't been commenting here since the repo rename, there's probably a config issue around that.

The Azure nightly jobs use some particular path through the GitHub REST API to retrieve the correct thread to comment on and then to comment - I wouldn't be surprised if some component of that chain doesn't handle the redirects through the renaming.  Should be an easy fix, at least.


App : Show only Employees for Project in HRMS Tab

Expected behavior
Need to show only project Employees.
Actual behavior
Its showing all employees registered in system
Steps to reproduce the behavior
In App > Select Project > Select HRMS > Show Employees

Fixed.


Pinch gesture example

Create an example for the pinch gesture.
https://user-images.githubusercontent.com/1410314/148695108-7bfebdf4-a8ed-4782-ba51-fd4567f197bd.mp4
Please note that we add the following dependencies to the examples project:

react-native-reanimated
react-native-gesture-handler

The code was tested on a physical iOS device.

Hi @ChrisJamesC! Thanks so much for the PR, we really appreciate it. We have decided to wait with adding reanimated and gestures to the example app because we want to wait until we've decided on our integration points. Maybe this example could be shared as a blog post in stead? @wcandillon We do have a blog, right? :)

That's cool 🎉

@chrfalch would you be open to have such an demo in the example project? would be a good way to quickly test the useSharedValueEffect hook

Actually it would be much more correct to have a separate branch with the examples than to remove it from here.

We've thought about having different example projects, but haven't gotten around to it yet due to other priorities unfortunately. So this is a good suggestion.

@chrfalch : Having a pull that hangs out wouldn't be the best thing.
So what do you think you will do?


refactor bmi adapters into their own library

[Short description explaining the high-level reason for the pull request]
Changes

Refactor the bmi adapter code into its own ngen_bmi library
Refactor test code/organization for bmi adapters

Testing

All tests refactored and running locally

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Target Environment support

[x] Linux
[x] MacOS

Ugh...looks like I'll have to a little more work on the build refactors (not sure why I didn't run into it locally, but I'll get this cleaned up soon)

Looks like the runners are happy now...If no other changes are needed, I'll rebase my last commit and get this ready to merge.  If there are some additional changes anyone thinks are required, I'll clean up with those changes.


[FEATURE REQUEST] lora size wish

lora size restrict less than 100mb is a little bit strict，，，，200mb is  a reasonable choice

the upload size limit is not set by BizyAir, it is set by comfyui, however, you can set it to a bigger size, please refer to https://bizyair.siliconflow.cn/model-host/introduce.html#comfyui

the upload size limit is not set by BizyAir, it is set by comfyui, however, you can set it to a bigger size, please refer to https://bizyair.siliconflow.cn/model-host/introduce.html#comfyui

ok, 600mb lora uploaded, but cannot work with flux, vram got boomed
Unexpected error accessing result["data"]["payload"]. Result: {'status': 'error', 'message': {'exception_message': 'CUDA out of memory. Tried to allocate 216.00 MiB. GPU '}, 'data': {'error': '0'}}


on('fetchcomplete') responseBody.toString('utf8') error "Disallowed Key Characters"

[x] I have read the contributing guidelines.

What happened (Observed behaviour)
got error "Disallowed Key Characters"
What should happen (Expected behaviour)
get html of http://peterbiltradiators.ca/catalog
Steps to reproduce the problem (include code examples)
  crawler.on('fetchcomplete', (queueItem, responseBody, responseObject) => {
    console.log(`Completed fetching resource: ${queueItem.url}`);
    console.log(`responseBody.toString('utf8'): ${responseBody.toString('utf8')}`);
...

result:
Completed fetching resource: http://peterbiltradiators.ca/catalog
responseBody.toString('utf8'): Disallowed Key Characters.

You don't even have to call toString('utf8') it still returns Disallowed Key Characters

I tried reproducing your problem with the following code, but didn't manage to get the problem to appear. Could you post a more complete sample of your code? That way we'll be able to tell if something seems off
This was my test code:
var Crawler = require("simplecrawler");

var crawler = new Crawler("peterbiltradiators.ca", "/catalog");

crawler.on("fetchcomplete", (queueItem, responseBody, responseObject) => {
    console.log(`Completed fetching resource: ${queueItem.url}`);
    console.log(`responseBody.toString('utf8'): ${responseBody.toString('utf8')}`);
});

crawler.on("complete", () => {
    console.log("Crawl completed!");
});

crawler.start();

Thanks for filing an issue!
This is likely to be an issue with the encoding of the page in question — it is likely that it was corrupt or unable to be parsed. Unfortunately unless we can reproduce the issue locally (and it is demonstrated that simplecrawler is responsible for corrupting the data) it is not likely to be something we can fix. Instead, try coercing the page to ASCII or an encoding which will disregard character sequences. The Buffer.prototype.toString method is provided by Node.js itself, and it is advisable that if you continue to have problems it might be better to address this question to the Node.js repo.
I'm closing this issue as 'unable to reproduce', but if you vehemently disagree with anything I've written here, don't hesitate to let me know.


Ollama on Windows ARM 64 on Mac M1 via Parallels

Before submitting your bug report

[ ] I believe this is a bug. I'll try to join the Continue Discord for questions
[ ] I'm not able to find an open issue that reports the same bug
[ ] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:
- Continue:
- IDE:
- Model:
- config.json:

Description
I installed Ollama on a Windows ARM64 on a Mac M1 using Parallels. I installed and ran Continue Dev in VS Code, but it hangs. Infinite loop trying to start. Can you advise if there is a workaround for this? Thank you.
To reproduce
No response
Log output
No response

This might an issue with the virtualization environment combined with binaries that Continue ships and the platform detection logic.
The solution for a similar case was to install VSCode x86 version (not the ARM version), see discussion in Discord here -> https://discord.com/channels/1108621136150929458/1108621136830398496/1267460362815672340
(scroll a bit up from the comment to the start)

I can't find VS Code x86 for download. Do you by any chance have the link? Thank you

From: fry69 @.>
Sent: Sunday, August 4, 2024 4:54:09 AM
To: continuedev/continue @.>
Cc: skyv195 @.>; Author @.>
Subject: Re: [continuedev/continue] Ollama on Windows ARM 64 on Mac M1 via Parallels (Issue #1906)
This might an issue with the virtualization environment combined with binaries that Continue ships and the platform detection logic.
The solution for a similar case was to install VSCode x86 version (not the ARM version), see discussion in Discord here -> https://discord.com/channels/1108621136150929458/1108621136830398496/1267460362815672340
(scroll a bit up from the comment to the start)
—
Reply to this email directly, view it on GitHubhttps://github.com/continuedev/continue/issues/1906#issuecomment-2267441317, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATVUBLP4UEOX34UA6PWEBVTZPXT3DAVCNFSM6AAAAABL6DV7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGQ2DCMZRG4.
You are receiving this because you authored the thread.Message ID: @.***>

Sorry, I have no real clue how to download or install the x86/x64 version instead Arm64 on Windows, I'm on macOS. The message on Discord from the user who claimed to get it working just read:

I've just installed VS Code x86 and it works

Thank you for the great support. I can confirm that installing the x86-x64 version worked. Thanks again!

From: fry69 @.>
Sent: Monday, August 5, 2024 4:05:15 PM
To: continuedev/continue @.>
Cc: skyv195 @.>; Author @.>
Subject: Re: [continuedev/continue] Ollama on Windows ARM 64 on Mac M1 via Parallels (Issue #1906)
Sorry, I have no real clue how to download or install the x86/x64 version instead Arm64 on Windows, I'm on macOS. The message on Discord from the user who claimed to get it working just read:
I've just installed VS Code x86 and it works
—
Reply to this email directly, view it on GitHubhttps://github.com/continuedev/continue/issues/1906#issuecomment-2269821308, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATVUBLN26LPUH5BCK4XIDS3ZP7LHXAVCNFSM6AAAAABL6DV7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZHAZDCMZQHA.
You are receiving this because you authored the thread.Message ID: @.***>

I also get this on a x elite laptop with no virtualization involved.

Dup of https://github.com/continuedev/continue/issues/839


Provide scan codes in input events

Scan codes refer to the physical location of the key on a QWERTY keyboard disregarding any customizations or cultural variations.
Dramatized example:

A developer using the QWERTY layout has made a game, the game listens for the W, A, S, D "letters" (SDL_Keycodes) in order to move forward, left, backward, right. A potential player of that game lives in France, and uses the AZERTY keyboard layout. She starts the game and tries to move forward, but nothing happens. A second potential player uses the Dvorak keyboard layout, she can only move to the left. A third potential player has created her own layout, she can't move at all.
If the players are lucky, the developer has provided a way to rebind keys, and the users will have to go through that to fix any differences between their layout and the developer's layout.
If the game had listened for the W, A, S, D "keys" (SDL_Scancode), the users would have been able to move around and explore the game right from the start.

Disclaimer: I barely know any rust at all, but i wanted to start learning it using piston, just to get annoyed by this issue since I use Svorak.
My impression is that the Button type should provide both the "text" meaning of the button pressed and the "key" meaning of the button pressed. In the case of AZERTY this would be Button { key: "Q", char: "A" } for the top-left button on the keyboard.
It seems that at least SDL2 emits Button events with both the "text" (SDL_Keycode) meaning and the "key" (SDL_Scancode) meaning attached.
Resources:

How can I handle different keyboard layouts?
An enumeration of the SDL keyboard scancode representation

@lucklove  I see this as more of an error needing fixing rather than an enhancement.
Press and release events are broken on my keyboard.  I use dvorak layout, so normally when I press s on my keyboard, 'o' is typed on the screen.  You could say that's working as intended, but if I change my keyboard layout to the US sub-layout like I normally would do for games, Piston doesn't react.
I still get ",aoe" instead of the expected "asdf" read by piston, even though my keyboard layout is US
This is definitely an error, as Piston should either return the scan code (the code associated with the physical button on the keyboard), or the key code (the character obtained by pressing the key) ... or ideally both.

My default keyboard layout is Dvorak
I switch to US layout (before running the bin or during... doesn't matter).
I push the 's' key on my keyboard.
Piston interprets an 'o'

Expected:  Piston interprets an 's' like everything else on my computer

There's two parts here:
1 - As per above, ideally scancode and keycode should both be emitted in the event
2 - Piston seems to be incorrectly reading keycodes from the system

Somebody who want to help fixing this? I'll create a todo-list in the meantime.

[ ] Do we need a new ScanCode enum in pistoncore-input?
[ ] Add new AdvancedPress and AdvancedRelease event traits for backward compatibility?
[ ] Update user-input to test scan codes

One idea is to add a new ButtonEvent which has more arguments than PressEvent and ReleaseEvent. The scancode can be stored in a ButtonArgs struct such that Button still works with equality checks.

Closed by https://github.com/PistonDevelopers/piston/pull/1195


Fix virtctl imageupload on default storageclass

What this PR does / why we need it:
The PR removes the logic to get storageclasses and storageprofile.
Previously When StorageClass is not provided then Virtctl requires the clients to have permissions to list storageclasses and get cdi storage profiles within the cluster, which limits who can upload images. This is only used to get error message faster, and to provide default value.
All of this is actually not needed, we don't need to figure out access modes and volume modes if not provided. We just fill in the parts of the DV storage section that we did get, and let the backend figure out the rest. This does mean we cannot give the nice error message about uploading to readonly volumes if the storage profile determines that is the access mode. But this should be a rare occurrence. And the error message can be read from DV Events.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://github.com/kubevirt/kubevirt/issues/6442
Special notes for your reviewer:
I need to check if nice error message can be provided (one TODO in the code), if can be read from DataVolume Status (events/conditions). Probably a new upload test can be provided as well.
Release note:

NONE

/retest

@davidvossel this is a fix for https://github.com/kubevirt/kubevirt/issues/6442

When access mode is not provided and storage profile does not have it configured then the upload will not start (wait for DataVlume to be ready) and the user can see any warnings on DataVolume events.

When access mode is not provided and the storage profile has it configured to ReadOnlyMany, then unfortunately we do not get the error message. But, in my opinion, it should be a very rare occurrence.


method call not working when method has no input params

/* Main function */
    function greet() public view returns (string memory) {
        return greeting;
    }

greet method will not work in ethcode.

Can recreate the issue


allow for case insensitive parquet-xxx prefix in PR title

Reporter: Julien Le Dem / @julienledem
Assignee: Julien Le Dem / @julienledem
PRs and other links:

PR

Note: This issue was originally created as PARQUET-1024. Please see the migration documentation for further details.

Julien Le Dem / @julienledem:
Issue resolved by pull request 415
https://github.com/apache/parquet-mr/pull/415

Julien Le Dem / @julienledem:
PR: https://github.com/apache/parquet-mr/pull/415


is there any method to set dynamic ZoomLevel ?

Hello
Zoom level is adjusted based on distance to the map.
What do you mean by dynamic zoomLevel here?
Thanks in advance


RDKCMF-8943 LISA: Change behaviour to retreive configUrl insted of asmsUrl

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Auto Release] Update istio.Version

Update istio.Version

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
61b644a21c4bc00b025b3004787c18f0d9632ec7
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
61b644a21c4bc00b025b3004787c18f0d9632ec7
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
61b644a21c4bc00b025b3004787c18f0d9632ec7
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fetch Web of Science links and counts

A relatively new feature in Google Scholar is to report the Web of Science citation counts (and provide WoS link) to papers in PUBLICATION_SEARCH_SNIPPET. We should be able to include this in v1.5
https://scholar.google.com/scholar?q=Machine-learned+epidemiology:+real-time+detection+of+foodborne+illness+at+scale&hl=en

My hypothesis is that the introduction of this feature (not seen until yesterday) is likely the cause of #368

My understanding is that WoS links only appear when you are in a subnet that provides access to WoS (typically an academic campus)

Ah, that makes sense. However, this is still new since I have not seen this before from university network, so this is nevertheless a new feature. But restricted access likely means this is almost never going to work with proxy services (it's a /scholar? page).

No, definitely not new. See https://github.com/scholarly-python-package/scholarly/issues/58

Strange! May be I have only been checking Google Scholar from my home network. Closing it then.

I think you also need to login to your university library (or WoS), so that Google can recognize that you have access to the WoS data. No idea how Google detects that


Added Introduction to Dotvvm Presentation Slides

I added slides that can be used for a 30 - 60 minute intro to dotvvm talk. I am hoping to use same slides for Dotvvm Meetup in Lagos this month

Thanks!


iOS 17.0.1: Home screen widget has black border

This widget is now useless anyway since it doesn't get updated regularly in iOS 17


VirusTotal: "snake has encountered an Error!"

Hi,
I have installed the VirusTotal Scale (snake-scales) and get multiple "snake has encountered an Error!" messages on the application.
Is this a known issue?

No known issues until now. Are you able to provide some of the snake.log for when that is occurring? I assume you have just installed the scale and set the API key.
Also are you on the latest build I think I addressed some poor handling for when the sample was actually not on VT.
Alex

Alex, thanks for getting back to me so quickly, i know I am not the only one with this issue.
I have installed the scale and entered my API key. The version is e8b8ae5.
I have had a look through the log an found the below which might be the source of the error?
[E 180328 15:09:10 web:1621] Uncaught exception POST /scale/virustotal/interface (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='POST', uri='/scale/virustotal/interface', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/web.py", line 1543, in _execute
        result = yield result
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/gen.py", line 1099, in run
        value = future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
        result = coro.throw(exc)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/routes/scale.py", line 115, in post
        output = await loop.run_in_executor(None, command, data['args'], data['sha256_digest'])
      File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
        yield self  # This tells Task to wait for completion.
      File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
        future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/scale.py", line 726, in wrapper
        output = func(args=args_, file=file_storage, opts=opts, self=self)
      File "/usr/local/lib/python3.5/dist-packages/snake_virustotal/interface.py", line 113, in info
        'first_seen': j['first_seen'],
    KeyError: 'first_seen'

I have also attached a screenshot of the issue.

Ah awesome, that is just the info I need and we can't fix things if we don't know about them so thanks for raising it as an issue. I'll go investigate this now shouldn't take too long to fix :)

Alex, thanks for looking into this. Just for a little more info, this is the full error when trying to show the virustotal interface:
[E 180328 15:35:26 web:1621] Uncaught exception POST /scale/virustotal/interface (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='POST', uri='/scale/virustotal/interface', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/web.py", line 1543, in _execute
        result = yield result
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/gen.py", line 1099, in run
        value = future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
        result = coro.throw(exc)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/routes/scale.py", line 115, in post
        output = await loop.run_in_executor(None, command, data['args'], data['sha256_digest'])
      File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
        yield self  # This tells Task to wait for completion.
      File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
        future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/scale.py", line 726, in wrapper
        output = func(args=args_, file=file_storage, opts=opts, self=self)
      File "/usr/local/lib/python3.5/dist-packages/snake_virustotal/interface.py", line 113, in info
        'first_seen': j['first_seen'],
    KeyError: 'first_seen'
[E 180328 15:35:26 web:2106] 500 POST /scale/virustotal/interface (xxx.xxx.xxx.xx) 12.44ms
[I 180328 15:35:27 web:2106] 304 GET /scale/virustotal/interface (xxx.xxx.xxx.xx) 1.58ms
[E 180328 15:35:27 web:1621] Uncaught exception POST /scale/virustotal/interface (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='POST', uri='/scale/virustotal/interface', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/web.py", line 1543, in _execute
        result = yield result
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/gen.py", line 1099, in run
        value = future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
        result = coro.throw(exc)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/routes/scale.py", line 115, in post
        output = await loop.run_in_executor(None, command, data['args'], data['sha256_digest'])
      File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
        yield self  # This tells Task to wait for completion.
      File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
        future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/scale.py", line 726, in wrapper
        output = func(args=args_, file=file_storage, opts=opts, self=self)
      File "/usr/local/lib/python3.5/dist-packages/snake_virustotal/interface.py", line 179, in parents
        if 'compressed_parents' in j['additional_info']:
    KeyError: 'additional_info'
[E 180328 15:35:27 web:2106] 500 POST /scale/virustotal/interface (xxx.xxx.xxx.xx) 14.80ms
[I 180328 15:35:27 web:2106] 304 GET /scale/virustotal/interface (xxx.xxx.xxx.xx) 2.30ms
[I 180328 15:35:27 web:2106] 200 POST /scale/virustotal/interface (xxx.xxx.xxx.xx) 12.64ms
[I 180328 15:35:27 web:2106] 304 GET /scale/virustotal/interface (xxx.xxx.xxx.xx) 2.34ms
[E 180328 15:35:27 web:1621] Uncaught exception POST /scale/virustotal/interface (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='POST', uri='/scale/virustotal/interface', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/web.py", line 1543, in _execute
        result = yield result
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/gen.py", line 1099, in run
        value = future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
        result = coro.throw(exc)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/routes/scale.py", line 115, in post
        output = await loop.run_in_executor(None, command, data['args'], data['sha256_digest'])
      File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
        yield self  # This tells Task to wait for completion.
      File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
        future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/scale.py", line 726, in wrapper
        output = func(args=args_, file=file_storage, opts=opts, self=self)
      File "/usr/local/lib/python3.5/dist-packages/snake_virustotal/interface.py", line 142, in names
        return j['submission_names']
    KeyError: 'submission_names'
[E 180328 15:35:27 web:2106] 500 POST /scale/virustotal/interface (xxx.xxx.xxx.xx) 13.68ms
[E 180328 15:35:28 web:1621] Uncaught exception POST /scale/virustotal/interface (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='POST', uri='/scale/virustotal/interface', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/web.py", line 1543, in _execute
        result = yield result
      File "/usr/local/lib/python3.5/dist-packages/tornado-5.0.1-py3.5-linux-x86_64.egg/tornado/gen.py", line 1099, in run
        value = future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
        result = coro.throw(exc)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/routes/scale.py", line 115, in post
        output = await loop.run_in_executor(None, command, data['args'], data['sha256_digest'])
      File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
        yield self  # This tells Task to wait for completion.
      File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
        future.result()
      File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
        raise self._exception
      File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/local/lib/python3.5/dist-packages/snake-1.0-py3.5.egg/snake/scale.py", line 726, in wrapper
        output = func(args=args_, file=file_storage, opts=opts, self=self)
      File "/usr/local/lib/python3.5/dist-packages/snake_virustotal/interface.py", line 160, in urls
        return j['ITW_urls']
    KeyError: 'ITW_urls'
[E 180328 15:35:28 web:2106] 500 POST /scale/virustotal/interface (xxx.xxx.xxx.xx) 17.59ms

Hmm this is odd, looks like not all of the json has been saved into the VT entry, but I can't replicate this!
Does resetting the VT cache for the sample fix the error?
curl 'http://<IP_ADDRESS>:5000/scale/virustotal/interface' -d '{"sha256_digest":"SAMPLE_HASH_HERE","type":"pull","command":"info","args":{"cache":"false"}}' -XPOST

Otherwise what json is VT returning you for the sample?
curl -v --request POST   --url 'https://www.virustotal.com/vtapi/v2/file/report'   -d apikey=API_KEY   -d 'resource=SAMPLE_HASH_HERE'

Sorry for the inconvenience.

Ah, are you using a public VirusTotal API key or a private one? If public this would make sense. I will have to tweak the scale to accommodate the limitations of public VT API.

Right, I have updated the VT scale to support the public API (682168e2e3f0b8c576545dd4f1a43309ce91187c), I also had to make a minor change to the core so you should be error free if you do the following:
sys/install.sh # Should upgrade snake to 1.0.1, let me know if not
sudo snake upgrade virustotal # Upgrade to 1.1

Reload snake and it should be good to go.

Thanks Alex, I will give it a go when I get a chance!

Alex, thanks for checking that out. Sorry for the delay in reply.
I have updated and still get the same error. I still get the same type of error as above.

Looks like my sys/install.sh has not upgraded Snake, still says 1.0 there should say 1.0.1!
Does the following upgrade snake to 1.0.1?
cd snake/snake-core
sudo python3 setup.py install --force

So, good news and really bad news...
Good news:
The update worked and I am now running 1.0.1...
Bad news:
I am now unable to see any previous uploads and I am unable to upload a new sample. I also appear to have lost all scales in the upload menu...
Looking through the logs, I now have:
[E 180410 14:06:42 web:1621] Uncaught exception GET /store?limit=10&sort=timestamp&file_type=memory (xxx.xxx.xxx.xx)
    HTTPServerRequest(protocol='http', host='xxx.xx.xx.xxx:5000', method='GET', uri='/store?limit=10&sort=timestamp&file_type=memory', version='HTTP/1.1', remote_ip='xxx.xxx.xxx.xx')
    Traceback (most recent call last):
      File "/usr/local/lib/python3.5/dist-packages/tornado/web.py", line 1541, in _execute
        result = method(*self.path_args, **self.path_kwargs)
      File "/usr/local/lib/python3.5/dist-packages/webargs/core.py", line 448, in wrapper
        force_all=force_all)
      File "/usr/local/lib/python3.5/dist-packages/webargs/core.py", line 370, in parse
        parsed = self._parse_request(schema=schema, req=req, locations=locations)
      File "/usr/local/lib/python3.5/dist-packages/webargs/core.py", line 291, in _parse_request
        argname = field_obj.data_key or argname
    AttributeError: 'String' object has no attribute 'data_key'

I have a feeling that this might be due to packages being the incorrect versions (probably marshmallow being too old), I need to freeze the version numbers into setup.py, that is an error on my part, apologies. Does this work:
sudo pip3 install celery==4.1.0 celery[redis]==4.1.0 marshmallow==3.0.0b7 motor==1.2.1 python-magic==0.4.15 pyyaml==3.12 requests==2.18.4 tornado==5.0.1 webargs==2.0.0

Worked like a charm!
Tank you, snake and virustotal now working perfectly!

Thanks for riding through the teething issues :) I will push a commit to freeze the packages.


fix isMisplaced() in command_volume_fix_replication.go

What problem are we solving?
A volume ID is considered to be misplaced only if all the replicas don't meet the configured replica placement setting.
It should be considered misplaced even if only one of the replicas is in in the wrong place.
fixes #4836

@zehweh Could you add a test for this case?
https://github.com/seaweedfs/seaweedfs/blob/17710e1ecbd36409fa5b14861c025aacf943b6fd/weed/shell/command_volume_fix_replication_test.go#L379

@kmlebedev sure, done: https://github.com/seaweedfs/seaweedfs/pull/5040

@kmlebedev sure, done: #5040

@zehweh Thank you!


Create/Update/Delete behavior consistency

Currently there is a little inconsistency in create/update/delete feedback:

kubectl create/app  for CR  and handling is asynchronous - CR created/configured/unchanged - returns immediately and role/playbook is run asynchrously, and CR status needs to be checked for the result
kubectl delete for CR hangs until playbook/role finishes successfuly (if play/role fails, it hangs forever)

Please make the behavior consistent for all CUD operations.
Please consider adding the following configurable options:

allow to block kubectl create/app until the underlying play finishes successfully
allow to fail kubectl create/app when underlying play finishes with error
allow to make delete/finalizer logic asynchronous (CR deleted returns immediately while play/role is run asynchronously)

Hi @matihost
Kubectl is behaving correctly. The deletion is not actually "hanging." You can exit the command, and the deletion still happened. You can make sure of this by checking the metadata. DeletionTimestamp field.
Basically what is happening is that kubectl is waiting for the resource to be garbage collected. Because of the finalizer, you're correct that the resource will never be cleaned up due to the controller failing. This is the correct behavior; a user will need to clear the finalizer if they think it is acceptable that the resource is cleaned up. The reason for this is that the controller does not know if everything was cleaned up correctly and we need to make sure that is true before the finalizer is removed.
Please note that kubernetes is an eventually consistent system, this means that when you create a resource, the resource is created. If for some reason we are unable to complete the actions in the cluster the correct behavior is to alert the user via the status of the resource.  There is the ability to add a Webhook for a CRD that will check if the fields are valid and can reject creation/updates.
Lastly, changing kubectl behavior is out of the scope of this project. How this interacts with kubernetes resources is a standard thing. I am going to close this issue, and if you believe that the kubectl behavior for interacting with resources should be updated, please open a bug here:
https://github.com/kubernetes/kubectl

Good explanation! Thank You!


Make Power Toys localization!

Translate the Power Toys
Easy to use for people around the world.
Proposed technical implementation details (optional)
Microsoft is good at doing that.

Tracked in issue #199
Working on it, too many things were getting brought online / getting changed.


feat(reporters): show full test suite when testing 1 spec file at a time

close: #3266

Looks like tests are failing now

The tests looks good now.

Looks like the test is still very unstable. Please, have a look when you have more time @Dunqing

Ok, I will do it later.

Looks like the test is still very unstable. Please, have a look when you have more time @Dunqing

Ok, I will do it later.

Another issue I see now is that console.log is hidden at the top (before the screen) if there are a lot of tests inside a file which leads to degraded user experience in my opinion.

Another issue I see now is that console.log is hidden at the top (before the screen) if there are a lot of tests inside a file which leads to degraded user experience in my opinion.

This behaviour should be the same as jest, If I cared about the contents of the console.log, I think I would use test.only.
Or do we need to make sure that the number of tests in the file < xxxx before enabling this behaviour?

This behaviour should be the same as jest,

Is it the same as jest? This test file runs quite differently:
it.each(new Array(100).fill(0).map((_, i) => i))('test', async (num) => {
  expect(true).toBe(true)
  await new Promise(resolve => setTimeout(resolve, num))
})

Vitest shows all 100 tests, but jest only shows the file name

This behaviour should be the same as jest,

Is it the same as jest? This test file runs quite differently:
it.each(new Array(100).fill(0).map((_, i) => i))('test', async (num) => {
  expect(true).toBe(true)
  await new Promise(resolve => setTimeout(resolve, num))
})

Vitest shows all 100 tests, but jest only shows the file name

I tested the code you provided with jest and at the end of the run, all the tests are printed.

I tested the code you provided with jest and at the end of the run, all the tests are printed.

Yes, in the end, but not during

Oh, yes, It looks like this is the wrong implementation and needs to be changed to print only at the end of the test.

@sheremet-va
When I revert this pr and tested again using vitest with the code you provided, the results were the same, vitest will show all 100 tests. I guess this is because it.each is handled differently in jest and vitest?

@sheremet-va
When I revert this pr and tested again using vitest with the code you provided, the results were the same, vitest will show all 100 tests. I guess this is because it.each is handled differently in jest and vitest?

I don't know how it's handled in jest. In vitest test.eash is the same as calling test function 100 times. I guess if behavior didn't change then it should be ok for the time being?..

Tets fails too often tho, we might have to revert this PR before release. Do you have plans to fix the issue with a flaky test?

I'm working on this, I'm still not sure what's causing the different results, can't we really add retries for it?

Retry just halves the time it will fail, not fix the issue

@Dunqing just curious was this PR issue fixed or is it still falling because that caused some unit tests to fail right? I can't wait to see this in action though 😉

@Dunqing just curious was this PR issue fixed or is it still falling because that caused some unit tests to fail right? I can't wait to see this in action though 😉

It has been fixed, and we should see it in the next release.

@Dunqing  sweet thanks, however just to let you know that the issue #3266 was actually reopened by @sheremet-va, someone might need to recheck if it can be closed again :)


请问，这个模块，支持缓存配置吗

Why you need it?

How it could be?

Other related information

需要缓存常用的get请求，节省带宽

这个是纯代理模块，无法缓存数据的。This module is designed to support to proxy flow, it could not cache some data of the proxied data flow.


Fix JSON, YAML use_*_discriminator for recursive struct types

Fixes #13214. This makes sure the temporary variables are not nilable for properties that aren't nilable and have no default values, since otherwise it seems the deserialization method recursively calls itself and breaks type inference.
This was discovered for JSON but applies to YAML as well.

I think the proper action is to raise right away instead of returning nil.
Suppose the deserializer could technically type the variable as typeof(::Union({{value[:type]}}).new(pull)) and verify the actual runtime value at the end. This would preserve this use case while still fixing the invalid nil propagation issue.

It's unfortunate to see this previously working code break. But I think it's for good. It only worked due to a bug in the first place and as far as I can tell was never intended nor documented behaviour.
We could re-enable that behaviour by adding in an appropriate cast in the deserialization logic. But I don't like that. It trades away type safety for no real benefit out of itself only to keep existing code that relied on a bug working.
This is a tough call of course. Should we prioritize avoiding to break code that worked previously out of error? We value backwards compatibility, but in this situation it depends on goodwill.
I believe it's best to accept the breaking code. The quality of the library will be better that way. And as the last example shows (https://github.com/crystal-lang/crystal/pull/13238#issuecomment-1512096511) the breakage even helps to discover type errors.
That's the point of having type safety. Giving that away opens up other holes.
It's easy to fix the affected code by raising directly in the converter. This is also backwards compatible with older Crystal releases.


TypeError: perf.getEntriesByName is not a function

I have followed the instructions carefully, but no matter what sites/URLs I want to audit, there is always this fatal error:
Error 1: Caught error for https://example.com/foo/:
TypeError: perf.getEntriesByName is not a function
node 16.5.0, Windows 10

Hi @dragan1700 — thanks for the heads-up!
I can reproduce this error using 16.5.0 on Mac 12.6.
Looks like performance.getEntriesByName() is only supported in Node from version 16.7.0: developer.mozilla.org/en-US/docs/Web/API/Performance/getEntriesByName
I've updated the README to add a Requirements section.
Using Node 16.7.0 and following the instructions in the README, I get the following:
multihouse: cd src
src: node index.js
Running Lighthouse for 1 page(s) in input.csv

Run 1 of 3: page 1 of 1
https://example.com: Performance 100
https://example.com: Accessibility 92
https://example.com: Best Practices 100
https://example.com: SEO 91
https://example.com: Progressive Web App 25

Start run 2

Run 2 of 3: page 1 of 1
https://example.com: Performance 100
https://example.com: Accessibility 92
https://example.com: Best Practices 100
https://example.com: SEO 91
https://example.com: Progressive Web App 25

Start run 3

Run 3 of 3: page 1 of 1
https://example.com: Performance 100
https://example.com: Accessibility 92
https://example.com: Best Practices 100
https://example.com: SEO 91
https://example.com: Progressive Web App 25

Completed 3 run(s) for 1 URL(s)with 0 error(s).

View output: output.csv

src: node -v
v16.17.0```

Hi @samdutton
Thanks for your swift response! Really appreciate it.
I can confirm with node 16.17.0 it works now here as well.
I'm sorry to bug you with another thing I've noticed... actually two:
a) If I only want a11y results, I do node ./index.js -r=1 -c="accessibility"
Is this the correct format/syntax, i.e. using double quotes? The start of the script seems to confirm my category choice ("Auditing categories: accessibility"), but it's doing all 5 categories regardless of that. All 5 categories are output in the terminal and output.csv.
b) There is a mismatch between the heading/value pairs as output in the terminal, as opposed to what you get in output.csv. Here's a screenshot. Compare the terminal and CSV values. Only performance and best practices match. The other ones are shifted somehow.

(Sorry for delay — haven't forgotten about this, but I've just returned from an event and holidays. I'll take a look.)


drop fancy Unicode quote to make example pastable

U+201D is not stripped by the shell which makes the command illegible to k8s.

Good catch!
/lgtm
/approve