Do not use SetOpCode() to freeze spec constants

Remove the opt::ir::Instruction::SetOpCode() interface.
Spec constant freezing is done by adding new front-end constant
instructions and turning the original spec constant instruction to Nop.

I'm afraid I don't quite get the rationale behind this PR.
For me, the old approach is clear (turning OpSpec* to Op* directly) and efficient (since we don't create extra copies and insert them, which is a costly operation). Would you mind to explain why the new way?

(also "Constants" is mis-spelled in the title)

I think the reason for having this is that, setting opcode directly is generally an unsafe behavior. And that is also the reason why we have a TODO at that location. There may be rules for creating valid instructions, like different constructor for different subclass of instructions, and in the constructor we can impose rules to make sure the built instruction is somewhat 'more' likely to be valid. So having an interface to set arbitrary opcode looks quite dangerous.
But if we really want to keep the optimization framework lightweight, and let the user to take the full responsibility to generate valid code, we can keep the SetOpcode().

The current design is to keep the in-memory representation just a vehicle of data, nothing more. It is lightweight and the user is expected to guarantee its validness. This gives us the benefits of not imposing heavy analyses on passes that does not need them (e.g., def use is not used for stripping debug info) and flexibility in writing tests (we can sometimes create invalid in-memory representation for testing's ease).
So I think it's preferable to keep the old SetOpcode way.

closed as we decided to keep the SetOpcode()


Week-3 application deploy

This issue is intended to explain that the project was already deployed. The readme is up-to-date including the link to the live website. You can take a look over the website here:
https://diegogagan2587.github.io/Diego-Vidal/#
You can verify the readme here:
https://github.com/Diegogagan2587/Diego-Vidal/blob/main/README.md
thanks for reviewing.

status: APPROVED :green_circle: :100:
Hi, @AndreaM2429,

Good job so far 👍 Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights ⚡
✅ Descriptive PR 👍
✅ Nice design 🔥
✅ Linters are passing 👏
Optional suggestions
You should add the link to the live demo section and remove the link to your GitHub you've added instead
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Play unprotected SRG SSR contents from URNs

As an integrator I want to be able to play any unprotected Play SRG content via its URN.
Acceptance criteria

The API allows content to be played from a URN.
Production, stage and test environments are supported.
The first available resource is played (no complicated resolution logic as currently in Letterbox).
URN-based content is playable from the demo (keep URL-based examples as well).

Tasks

[x] Create module pillarbox-core-buisness as discussed here.
[x] Integration layer service and data.
[x] Basic Resource filter, take the fist resource.
[x] Implement MediaItemSource using Integration layer
[x] Fill metadata from chapter
[ ] Update demo with urn

The first available resource to played is a too bad criteria. We select the first resource that is "playable" by the Player.


ModuleNotFoundError: No module named 'tzlocal'

tzlocal is not native to every python environment. Possible modification to poetry config?

tzlocal does appear in the poetry build, although it still had to be installed locally to get the program to run.


Removed Lisa Templates from twig-tools.md

Removed Lisa Templates as:
"This plugin was closed on November 7, 2018 and is no longer available for download. Reason: Author Request."
First off, hello! Thanks for submitting a PR. We love/welcome PRs (especially if it's your first). Have any questions? Read this section in CONTRIBUTING.md
Issue
Lisa Templates link in docs goes to dead link on wordpress:
"This plugin was closed on November 7, 2018 and is no longer available for download. Reason: Author Request."
Solution
removed link and section header (as would be redundant).
Impact
minimal.
Usage Changes
mild docs change.
Testing
n/a

Thanks for the heads-up on that — goodbye!


Duplicated hosted zones get created with trying to create a stack with "ROOT DOMAIN NAME" that does not end with ".".

Server version - Build from master - oct 30
Create a stack from "External DNS" catalog by providing a stack with  "ROOT DOMAIN NAME" that does not end with "." like "test.com".
2 hosted zone entries get created with "test.com."  out of which one of them gets updated with all the dns entries.
Even in the case where there is already a hosted zone with "test.com." was already present , 2 more hosted zone entries get created with "test.com."  and all the dns entries get programed in one of the newly created hosted zone.

Hosted name has to be pre-created

Tested with latest version of the template for "External DNS".
When creating a stack from "External DNS" catalog by providing a stack with "HOSTED ZONE" that does not end with "." like "test.com" and "test.com" already is pre created , existing hosted  zone entry is used by rancher-server and dns entries get programmed here.
When creating a stack from "External DNS" catalog by providing a stack with "HOSTED ZONE" that does not exist , the service does not start successfully. They keep restarting.


feat: OverlayEntry implementation

Closes #92

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add kafkaQueueProblems featureflag to flagd json & update env vars

Add kafkaQueueProblems featureflag to flagd file and added FLAGD_HOST & FLAGD_PORT environment variables. Also adjusted resource limits of the frauddetection service since it kept dying.
See upstream PR here: open-telemetry/opentelemetry-demo#1528

@EislM0203 I see the chart version was bumped but no other files including the demo.flagd.json file have been changed. Do you need to push a local commit?


Firefox get different render for dropdown

Firefox browser (linux and widows) false render dropdown. I've try in chrome (linux and windows) and edge, they render it correctly.
Demo: http://codepen.io/3mp3ri0r/pen/bpPWax

Please use StackOverflow for support and integration assistance. This tracker is only for problems with the code provided by Material Design Lite.
Thank you.


Fix undefined method `example_group' for nil & NoMethodError: render_views? for feature specs

This is my stab at issue #1800.
In my case the ViewRenderer code that was added with PR #1732 was triggered via the capybara webdriver and RSpec.current_example is nil then causing the error in the title. @yujinakayama's spec repro in #1818 points to the cause being that FeatureExampleGroup doesn't include RSpec::Rails::ViewRendering while ControllerExampleGroup does.
This commit makes the tests in PR #1818 pass (via the respond_to?) and running the whole rspec-rails suite only caused bundler errors for me (I tweaked the gemspec for local gem development). Using this local commit also got rid of loads of errors (those from the title) when running feature specs in my own project.
I have to say that this is my very first experience with RSpec code and that I just deemed the included block to be a good place to do this. Bear with me, if I forgot something.

Maybe the author of #1732 @andymorris can also have a look at it, whether I preserved all behavior. As I said tests are green and to me it looks good. But I'm not deep into RSpec behavior.

ad40aae is only an optimization for the case when no controller specs are run

now I also confronted with this error message.
and I have no idea why this error happen and how to avoid it under latest rspec-rails of version 3.6.0.

Fixed in https://github.com/rspec/rspec-rails/pull/1831

(sorry I didn't see this PR until after I merged the other one, but I do think it addresses the feedback in here)


feat(route_handler): add lateral distance calculator

Description
Add a member function to RouteHandler that computes the lateral distance to the preferred lane from the given lane.

🤖 Generated by Copilot at a469954
Add a new function getLateralDistanceToPreferredLane to the RouteHandler class in planning/route_handler. The function calculates the distance from the current lane to the preferred lane for lane change planning.

Tests performed

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901
Thank you very much. It looks good, and if degradation test passes, then it can be merge 👍🏼


The documentation differs from the actual production status

The documentation seems to be out of date. At the time of writing (Set 2 2019), when adding an public upstream on an existing source:

you must specify a repository type of the upstream source besides the url
the only repository type seem to be 'npm'

Since the remote repository is validated before adding it, it is right now impossible to add a Maven Upstream source. Should this be filed as an issue?

Dettagli del documento
⚠ Non modificare questa sezione. È necessaria per i collegamenti relativi ai problemi tra docs.microsoft.com ➟ GitHub.

ID: dd5891bb-c68e-d8d8-a08a-d7618904fcb6
Version Independent ID: 56f9b4c1-4ba1-70ad-034b-a94912f03923
Content: Use packages from Maven Central
Content Source: docs/artifacts/maven/upstream-sources.md
Product: devops
Technology: devops-artifacts
GitHub Login: @chasewilson
Microsoft Alias: phwilson

Well, the documentation now clearly states in docs/artifacts/concepts/upstream-sources.md that custom upstream urls are supported only for NPM 😒


Please help can not get into the wallet

Hello! There were problems with the entrance to the purse, there Keystore File UTC came in repeatedly, now I enter the password and wrote that it is not true. Help to understand the problem, wrote in support, but so far in response to silence.

up

I understand that you probably will not help me, maybe your customers have already faced this and somehow solved this problem, I will be grateful, I have a programming experience, I'm noob

Please enter your correct password or, if you saved the private key or paper wallet, try that.
We do not save, store, or transmit any sensitive information like your private key or password. We cannot recover or reset anything.

Please reach out to<EMAIL_ADDRESS>if you need anymore help.


Fix bug in freeing geo polygon memory

Closes #103
This fixes some errors in freeing GeoPolygon memory, which could get the Emscripten virtual memory management into a bad state.
Explanation of the issue: We were expecting the GeoPolygon reference to Geofence to be a pointer, but it’s not, the struct is inlined into GeoPolygon. So I was trying to free the value at the geofence position, because I thought it was a pointer, but I’m actually getting the first value in the Geofence struct, which is numVerts, and trying to free that. C would probably segfault at this point, Emscripten just gets confused and ends up with undefined behavior in future calls.

Pull Request Test Coverage Report for Build 215

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 213:
0.0%

Covered Lines:
397

Relevant Lines:
397

💛  - Coveralls

Are there any ways to test for this class of bugs? For example is there an equivalent to Valgrind that can be used to check that the allocated/freed buffers match up?

I honestly don't know. The memory starts off clean, so all of the issues are deterministic. The original test case (the pair of polygons in #103) was deterministic, so I could test via script and determine whether the counts matched or not. The test I put into the test suite was deterministic too, but not in the way I'd like - if it mismanaged the memory, that test still passed, but 23 other subsequent tests failed with weird behavior. But I doubt there's any Valgrind equivalent just for Emscripten-compiled code :/.


Can we have path as a parameter for open() command?

It's nice to have this so we can quickly open nvim-spectre to search in current directory, or search in a directory selected in NERDtree.

check readme . it is cwd param


Check for nillnes before Set[Edge]ID() if edge can be `nil

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I just ran into the most infamous error you can have with Go: invalid memory address or nil pointer dereference.
In the ent-generated file player_create.go we have:
// SetTeam sets the "team" edge to the Team entity.
func (pc *PlayerCreate) SetTeam(s *Team) *PlayerCreate {
  return pc.SetTeamID(s.ID)
}

even if I have the edge .Required():
edge.To("team", Team.Type).Field("team_id").Unique().Required(),

The problem with this code is that Team is a * and consequently it can be nil and we should add a check for nillness here, right?
Your Environment 🌎

Tech
Version

Go
1.18.3

Ent
entgo.io/contrib v0.2.1-0.20220609194656-bea889a722a8, entgo.io/ent v0.10.2-0.20220614093246-195be2d98d88

Database
PG

Edge-setters assume objects are not nil because entities are created by Ent and cannot be created manually. However, for cases like SetEdgeID, you can use the SetNillableEdgeID() option for edge-fields that can be nil and may be passed as null in GraphQL inputs, to avoid the reparative if tid != nil { c.SetTeamID(*tid) } checks in your resolvers.

Example from my codebase:

Edge-setters assume objects are not nil because entities are created by Ent and cannot be created manually.

I don't understand what you mean.
Let's say I'm using ent without graphql, only with my "domain" entities:
func newPlayerCreateFromDomain(tx *ent.Tx, player *domain.Player) *ent.PlayerCreate {
	if tx == nil || o == nil {
		return nil
	}

	res := tx.Player.Create().
		SetName(player.Name()).
		SetNillableAge(player.Age()).
    SetTeam(convertToEntTeam(player.Team())).

	return res
}

func convertToEntTeam(team *domain.Team) *ent.Team {
	if team == nil {
		return nil
	}

	return &ent.Team{
		ID:   team.ID(),
		Name: team.Name(),
	}
}

This is my situation currently.
Here Team can be nil.
I'm already using .Nillable*() methods for ID fields.

I have the GraphQL resolvers as an example. But for your use case, I'll recommend you do write the above code as follows:
func newPlayerCreateFromDomain(tx *ent.Tx, player *domain.Player) *ent.PlayerCreate {
  if tx == nil {
    return nil
  }
  build := tx.Player.Create().
    SetName(player.Name()).
    SetNillableAge(player.Age())
  if t := player.Team(); t != nil {
    build.SetTeamID(team.ID())
  }
  return build
}

If you really want to save these if-statements, which IMO simpler than allocating and converting temporary types you can use templates. You can also use templates to accept your domain-specific types and extend these builders. We usually develop features on templates, and after we feel they are stable and good enough (and should be shared), we add them to Ent.

Perhaps my confusion is to be ascribed only to one thing that I have not yet understood:
Is there any difference between this:
tx.Player.Create().SetTeam(some.Team()).Save(ctx)

and this
tx.Player.Create().SetTeamID(some.Team().ID).Save(ctx)

Or is Ent only getting the ID from team to be saved in database?


Persist ktbl datastream by master

A new endpoint named updateKtbl for KTBL-Metadata(json) has been implemented in this branch.
This KTBL-Metadata (Json file) will be sent to the new implemented endpoint as a Rest-Api-Call. The endpoint maps the wanted metadata and persists it as a new data stream named KTBL in the Data Layer of the system.
route: PUT /resource/:pid/ktbl

I have seen these changes and I find them very well done. No more lines of code than necessary have been changed or added.
Furthermore, I propose to remove the commented methods (e.g.  updateMetadata2(Node node, String content) ) from the code because the code will still be available in the github history.


[HELP] OpenGL & Vulkan compute shader not working

Hi,
I have a working Compute Shader/Instanced Vertex Shader example on Direct3D11, however, when switching to OpenGL (or GLES/Vulkan) I get a blank screen with no errors.  Rolling back to older versions of Veldrid doesn't appear to fix, so I'm stuck.
Is it possible to invite you to the teamsystem repo?

Is it possible to invite you to the teamsystem repo?

Sure -- can you send an invite email or something? I'm not sure how teamsystem works.

I can confirm that Vulkan stops working on commit 86997413 which is when I move to using vertices with the instances (note I have to update the packages for any of the builds to support OpenGL compilation until 7e9c4486).  So OpenGL/GLES just aren't working with the simple compute shader, and Vulkan stops working when I moved to instances.

Ah, checking the FAQs your email has to be a Microsoft account, so it might not work if you're gmail isn't used as your Microsoft sign in?  If you sign into Visual Studio, it would be that account.

I'm not sure what commits you're referring to -- I don't see either of those in the tree.

Possibly. Vulkan will not work correctly if the ResourceLayout you define doesn't match what is in the shaders. Likewise, OpenGL will not behave properly if the resource names you put in your ResourceLayoutDescription don't exactly match the ones specified in your shader code.

I haven't received an invite or anything, but I did email your git author address with an alternate email address you could try.


Remove cron library in favour of time.Ticker

As we only use the cron lib for running a task once every X, we could introduce a time.Ticker conigured via the same config options as now.
Using the std lib will make the project lighter and execution should be much faster from go 1.13

New timers will land only to go1.14 :(
Also the cron lib internally uses the timer.Timer too, but with some multiplexing.

we can keep the library


Bud should release itself

Currently, there's a python script that performs Bud's releases (see https://github.com/urbas/bud/blob/master/DevelopmentUtils/prepare-release.py).
This script has to be ported to a Bud task (or a macro).

Resolved by PR #11


Incompatibility with new anndata 0.10.9

Issue
There is a new anndata release incompatible with scVI
Error message
> import scvi
ImportError: cannot import name 'AlignedViewMixin' from 'anndata._core.aligned_mapping' (/local_disk0/.ephemeral_nfs/envs/pythonEnv-41a17f4f-ae47-4ddc-a406-410dcbd282df/lib/python3.10/site-packages/anndata/_core/aligned_mapping.py)

Temporary fix
Pin down anndata:
pip install anndata==0.10.8

Hi, thanks for posting this. Please read the full error and post it as it makes it easier to figure out what's causing this. I opened the issue for MuData as it seems like this is causing the issue: https://github.com/scverse/mudata/issues/77.

Fixed in MuData.


Drop UA ID

Contributes to:

#972

/area documentation
/kind cleanup
/cc @LucaGuerra @leogr

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b4e3e19 Drop UA ID

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chalin
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Marking as draft until we resolve the duplicate GA4-property issue. For context, see https://cncfservicedesk.atlassian.net/browse/CNCFSD-1770?focusedCommentId=24180.

Via Slack, @aijamalnk wrote:

... we will be migrating to a new GA4 owned by CNCF.

Thanks for the confirmation. In that case, we can proceed with the review and merge of this PR. Removing draft status.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chalin, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR went live about 25 min ago (at the time of writing). I confirm that the UA ID is still receiving events, as it should, since it is connected from the new CNCF GA4 ID:


Can't add storage resource access permission to function using @mapsTo directive.

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.15.1
Amplify CLI Version
10.4.1
What operating system are you using?
mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
function
Amplify Commands
update
Describe the bug
I've changed model name in API GraphQL category with @mapsTo directive. (e.g. Account to User)
After that, I can't select resource access permission previous storage model (Account) executing amplify update function.
Expected behavior
Be able to select the storage model before changed in update resource access permission of function because @mapsTo directive does not change DynamoDB Table.
Reproduction steps

create graphql api category and make some model in schema.graphql.
amplify push
change model name with @mapsTo derective in the schema.graphql.
amplify update function > Resource access permissions > storage

GraphQL schema(s)

type Account @model {
  id: ID! @primaryKey
  name: String!
}

type User @model @mapsTo(name: "Account") {
  id: ID! @primaryKey
  name: String!
}

Additional information
You can avoid this bug temporary making previous model.

Add previous model in schema.graphql
amplify update function and update resource access permission.
Remove the previous model.

Hey, thank you for reaching out. I tried reproducing this in my Amplify project.

Create a Amplify application and added api with the following schema

type Task @auth(rules: [{allow: public}]) {
  id: ID!
  descption: String
}

added a function and provided the additional permissions.

amplify add function
? Select which capability you want to add: Lambda function (serverless function)
? Provide an AWS Lambda function name: taskappa2a08d1d
? Choose the runtime that you want to use: NodeJS
? Choose the function template that you want to use: Hello World

Available advanced settings:
- Resource access permissions
- Scheduled recurring invocation
- Lambda layers configuration
- Environment variables configuration
- Secret values configuration

? Do you want to configure advanced settings? Yes
? Do you want to access other resources in this project from your Lambda function? Yes
? Select the categories you want this function to have access to. storage
? Select the operations you want to permit on Task:@model(appsync) create, read

You can access the following resource attributes as environment variables from your Lambda function
        API_TASKAPP_GRAPHQLAPIIDOUTPUT
        API_TASKAPP_TASKTABLE_ARN
        API_TASKAPP_TASKTABLE_NAME
        ENV
        REGION
? Do you want to invoke this function on a recurring schedule? No
? Do you want to enable Lambda layers for this function? No
? Do you want to configure environment variables for this function? No
? Do you want to configure secret values this function can access? No
? Do you want to edit the local lambda function now? No
Successfully added resource taskappa2a08d1d locally.

As we observe the permit on Task:@model(appsync) indicated the Task model was recognised.

Pushed the application
updated the schema.graphql with the following schema.

type Test @model @mapsTo(name: "Task") @auth(rules: [{allow: public}]) {
  id: ID!
  descption: String
}

ran amplify update function

? Select the Lambda function you want to update taskappa2a08d1d
General information
- Name: taskappa2a08d1d
- Runtime: nodejs

Resource access permission
- Task:@model(appsync) (create, read)

? Which setting do you want to update? Resource access permissions
? Select the categories you want this function to have access to. storage
? Select the operations you want to permit on Test:@model(appsync) create, read

You can access the following resource attributes as environment variables from your Lambda function
        API_TASKAPP_GRAPHQLAPIIDOUTPUT
        API_TASKAPP_TESTTABLE_ARN
        API_TASKAPP_TESTTABLE_NAME
? Do you want to edit the local lambda function now? No

updated the function and observed the flow recognized the change  permit on Test:@model(appsync)
6. added code to the function calling the Task DDB Database. Tested the function on console. observed the following output.


Fixed master's failure due to missing apk files

Issue

None

Overview (Required)

Use copy command to remain apk files

Links

CircleCI build / https://circleci.com/gh/DroidKaigi/conference-app-2017/186

Thank you 🙇


[actions] Remove jdk 16, add jdk 18-ea and move from temurin to zulu …

…to pick up jdk 18-ea

Thanks - I don't particularly want to run the EAs just yet -- when we did that for v17, we got a lot of build failures, particularly on the Mac builds. I think it's best to wait for it to stabilize first.

18 is ramp down now so it should be stable but that makes sense.  I can re-raise this and just use the 17 release to replace obsolete 16.

Thanks, sounds good. Can stay on Temurin too I guess.


Tensorflow2.0 checkpoint restore error

Here is an error message:
Exception ignored in: <bound method _CheckpointRestoreCoordinatorDeleter.__del__ of <tensorflow.python.training.tracking.util._CheckpointRestoreCoordinatorDeleter object at 0x0000014FDDC7CFD0>> Traceback (most recent call last):   File "C:\Users\17551\Miniconda3\lib\site-packages\tensorflow_core\python\training\tracking\util.py", line 140, in __del__     TypeError: 'NoneType' object is not callable
I'm using tensorflow-gpu 2.0, windows10, I imported the following libraries:
from tensorflow.keras.preprocessing.text import text_to_word_sequence
import tensorflow as tf
This is the code piece of how I restore the checkpoint:
checkpoint_dir = gConfig['model_data']     seq2seqModel.checkpoint.restore(tf.train.latest_checkpoint(checkpoint_dir))

Please fill in the issue template, please use ``` around code blocks and errors, please make sure you search for duplicates of your issue, in case there is already some solution available.

@Panshangka, Please provide the information asked in the Template to analyze the issue.

Thanks, it's solved. I'll close the issue

I met the same problem as you do, can you tell me how you solved the problem?

I met the same problem as you do, can you tell me how you solved the problem?

It's long time ago and I forget. Maybe you can post the code I'll see if I can help

if __name__ == '__main__':
model = TransE()
checkpoint = tf.train.Checkpoint(my_model = model)
checkpoint.restore(tf.train.latest_checkpoint('./checkpoint1'))
test_case = [5, 6, 7]
a, b = model.evaluate(test_case)
print (a, b)
And the output went like
 tf.Tensor([11028  7542  2595 ...  9127 14509     6], shape=(14951,), dtype=int32) tf.Tensor([ 6383  5011  5887 ...  3105 12434     5], shape=(14951,), dtype=int32)
Exception ignored in: <bound method _CheckpointRestoreCoordinatorDeleter.__del__ of <tensorflow.python.training.tracking.util._CheckpointRestoreCoordinatorDeleter object at 0x7f47d1dc2d30>>
Traceback (most recent call last):   File "/home/zhx/Paper/CL-KG/venv/lib/python3.6/site-packages/tensorflow_core/python/training/tracking/util.py", line 140, in __del__
TypeError: 'NoneType' object is not callable

tf.train.Checkpoint
I can't really help, but you can probably change the way of save and restore,  checkpoint manager maybe helpful.
And double check the checkpoint the directory

Thank you all the same
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2020年4月26日(星期天) 晚上6:23
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [tensorflow/tensorflow] Tensorflow2.0 checkpoint restore error (#36420)
tf.train.Checkpoint
I can't really help, but you can probably change the way of save and restore,  checkpoint manager maybe helpful.
And double check the checkpoint the directory
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I am facing the same issue can any one guide me?

Testing the model performances.
import matplotlib
import matplotlib.pyplot as plt
import io
import os
import scipy.misc
import numpy as np
from six import BytesIO
from PIL import Image, ImageDraw, ImageFont
import tensorflow as tf
from object_detection.utils import label_map_util
from object_detection.utils import config_util
from object_detection.utils import visualization_utils as viz_utils
from object_detection.builders import model_builder
#%matplotlib inline
def load_image_into_numpy_array(path):
img_data = tf.io.gfile.GFile(path, 'rb').read()
image = Image.open(BytesIO(img_data))
(im_width, im_height) = image.size
return np.array(image.getdata()).reshape(
(im_height, im_width, 3)).astype(np.uint8)
#recover our saved model
pipeline_config = './exported/pipeline.config'
#generally you want to put the last ckpt from training in here
model_dir = './train_output/ckpt-1'
configs = config_util.get_configs_from_pipeline_file(pipeline_config)
model_config = configs['model']
detection_model = model_builder.build(model_config=model_config, is_training=False)
Restore checkpoint
ckpt = tf.compat.v2.train.Checkpoint(model=detection_model)
ckpt.restore(os.path.join('./train_output/ckpt-2'))
def get_model_detection_function(model):
"""Get a tf.function for detection."""
@tf.function
def detect_fn(image):
"""Detect objects in image."""
image, shapes = model.preprocess(image)
prediction_dict = model.predict(image, shapes)
detections = model.postprocess(prediction_dict, shapes)

return detections, prediction_dict, tf.reshape(shapes, [-1])

return detect_fn
detect_fn = get_model_detection_function(detection_model)
#map labels for inference decoding
label_map_path = configs['eval_input_config'].label_map_path
label_map = label_map_util.load_labelmap(label_map_path)
print(label_map)


add options to make output baidu_urls.txt file

add options to make output baidu_urls.txt file

done


"MgtHostName" configuration is templated to take the "HostName" configuration

In carbon.xml file we have following configuration.
*****
This configuration has been templated in carbon.xml.j2 file as below to take the "HostName" by default.
`Host name to be used for the Carbon management console
 {%if server.hostname is defined %}
<MgtHostName>{{server.hostname}}</MgtHostName>
 {% endif %}`

This becomes an issue when using a different hostname for management console.
Version - WSO2IS-5.10.0

I will work on this.


Unable to scroll through Pull Request Installation Menu

Title says it all. On Switch, it seems to be impossible to scroll through the pull request installation menu despite more options being visible.

resolved


Tixati

There's no official API but there's this, not sure if it would suffice
https://github.com/MisanthropicShayna/tixati-python-api-cli

Unfortunately, without a documented, official, stable API I won't be able to implement this, especially since Tixati is not widely used.


Prepare for July Drone Interest Group meeting

Task to do
Prepare for July Drone Interest Group meeting
Reason
It won't be held otherwise
Result
The meeting is setup with presenter

Cancelled the meeting


Website is down

http://simiki.org is down.
Just wanted to bring this to your attention. Seems like its pending ICANN verification.

Thank you for your reminding, it's ok now.


Unable to use botname and pattern argument

I only wanted to delete messages from one incoming webhook in a channel but the botname did not want to filter out those messages. I tired a few different variation but I always got 0 messages back.
I tried to filter the messages by the title or message but that did not seem to work too. I would like to delete the messages from "production Monolog" but keep those from "staging-server"

take a look at the develop branch using the contained python module you have a fine granular access to the messages and whether to delete them or not


Hey guys! When in Intel Torch coming out?

Any ETA on the Intel Torch release date?
Will be great if you can also run following two benchmarks and share performance of Torch on Phi 72xx series, so we can compare it against NVidia cuDNN performance.

https://github.com/jcjohnson/cnn-benchmarks
https://github.com/soumith/convnet-benchmarks

Thanks!

@campbx We are still in performance tuning for KNL, and the benchmark we are using is https://github.com/xhzhao/IntelTorch-benchmark, which is forked from the convnet-benchmarks, with some parameter change.


Config of two-stage VoxSeT

Thanks for your sharing. Can you give the config of the two-stage VoxelSet? I notice that there is only a config of one-stage VoxelSet.

same question!!

same question!


[PasscodeLock] You can send a message even if discord is showing the lock screen

Hi there. just found a bug.
To do this bug you need to prepare a message but not to send it and let it be saved in drafts after that lock your screen and if you press ENTER it'll send the message to him.

Fixed in bd8a84376b04a2373d8250c8f4ff1a66377e7a3b


ci: fix snyk.yaml and release.yaml for Node v20

Fixes #11459 , Fixes https://github.com/argoproj/argo-workflows/pull/11410#issuecomment-1653775914
Motivation

There was some breakage in different CI workflows due to the node v20 upgrade in #11410

node was updated in ci-build.yaml but not synk.yaml

caused Snyk to (correctly) error on the node.engines requirement

see https://github.com/argoproj/argo-workflows/actions/runs/5676115276/job/15382363976

--openssl-legacy-provider was set in release.yaml's NODE_OPTIONS env, but not the others

it is already set in-line in the package.json, so no need to set it globally as an env var

setting it as an env var also breaks GH's default runner version that runs for checkout: https://github.com/argoproj/argo-workflows/actions/runs/5676125574/job/15383405669
this was removed from some of the GH workflows during iteration on #11410, but this one reference seems to have been left in

Modifications

add actions/setup-node@v3 with node-version: "20" to snyk.yaml

also add comments about updating Node in all GH workflows, not just one

remove --openssl-legacy-provider from release.yaml

Verification

CI build should pass now
Future Work
Ideally, we should update more NPM deps so that this flag is not needed

Snyk passed: https://github.com/argoproj/argo-workflows/actions/runs/5683894853/job/15405447864
Release passed: https://github.com/argoproj/argo-workflows/actions/runs/5683894876/job/15406913607

Thanks!


It was hanging when UTM being put in background

Description
As titled, background mode is with issues, everything was hanging when UTM being put in background.
Please close if it’s duplicated.
Minimal Reproduce

ssh to VM spawned by UTM when UTM is in front, run shell like:

while true
do
    echo it’s not hanging; date
done

We could see from ssh client screen it’s refreshing before putting UTM into background

Put UTM in background, we could see ssh client hanging

Switch UTM back in front, the while script was resumed ;-)

I recorded this screen shot video here: https://vimeo.com/407004796

Environment Information
UTM version: 0.9
Distribution: AltStore source
Host Info:
    Host OS:
        name: iPad OS
        version: 13.4.1 (17E262)
    Host Machine:
        name: iPad Pro Gen2
        type: A1671

Thanks!
BR//Wey

Can you post a screen of your UTM settings from iOS settings app?

Can you post a screen of your UTM settings from iOS settings app?

Sorry for wasting your time. I was not aware of this background switch in settings. It was off.
Please close this false issue.
Sorry again and thanks!
BR Wey


UI: VM retirement throwing an error in log

On VM retirement form, select a retirement date, then select a value in "Retirement Warning" drop-down, that will throw an error in log, ActionController::RoutingError (No route matches [POST] "/vm_infra/undefined"), when i press save button selected value for Retirement Warning field does not get saved.
See log snippet:
***** MIQ(vm_infra_controller-x_button): Session object size of 51.2 KB exceeds threshold of 50 KB
[----] I, [2015-09-16T13:14:42.052735 #22086:539990]  INFO -- : Completed 200 OK in 387ms (Views: 0.4ms | ActiveRecord: 6.5ms)
[----] I, [2015-09-16T13:14:42.397969 #22086:539990]  INFO -- : Started GET "/vm_infra/retirement_info/1000000002016" for <IP_ADDRESS> at 2015-09-16 13:14:42 -0400
[----] I, [2015-09-16T13:14:42.458143 #22086:539990]  INFO -- : Processing by VmInfraController#retirement_info as HTML
[----] I, [2015-09-16T13:14:42.458333 #22086:539990]  INFO -- :   Parameters: {"id"=>"1000000002016"}
Session:	 Hash of Size 53169, Elements 58
***** MIQ(vm_infra_controller-retirement_info): Session object size of 51.9 KB exceeds threshold of 50 KB
[----] I, [2015-09-16T13:14:42.663255 #22086:539990]  INFO -- : Completed 200 OK in 205ms (Views: 0.5ms | ActiveRecord: 4.1ms)
[----] I, [2015-09-16T13:14:55.820844 #22086:539990]  INFO -- : Started POST "/vm_infra/undefined?retirementWarning=14" for <IP_ADDRESS> at 2015-09-16 13:14:55 -0400
[----] F, [2015-09-16T13:14:55.884333 #22086:539990] FATAL -- :
ActionController::RoutingError (No route matches [POST] "/vm_infra/undefined"):
actionpack (4.2.4) lib/action_dispatch/middleware/debug_exceptions.rb:21:in call'   actionpack (4.2.4) lib/action_dispatch/middleware/show_exceptions.rb:30:in call'
railties (4.2.4) lib/rails/rack/logger.rb:38:in `call_app'

This report helped me to discover two problems, which were fixed in pull requests #5042 and #5046
With these two pull requests merged, I tried to reproduce the problem described here, but
the problem wouldn't show.
@h-kataria Is this still a problem in current master? If not, can this please be closed? Thank you.

@mzazrivec tested on upstream, this is no longer an issue there.


UX: Tag topic count should be comma separated

As per Meta request, this PR updates appearance of the topic count on filter tags so they are rendered based on locale (typically with commas).
So that 427075 is rendered as 427,075

@janzenisaac Can't seem to pinpoint why plugin frontend tests are failing here... I don't see anything related to the changes in this PR


About the type of value

In karate, how do I check the type of a value, such as float, double. Although I found something relevant in the documentation, it didn't seem to be what I wanted. I only found out if the value was a number, and I didn't find out if the value was an integer, float, etc. Java method to judge?

interesting question ! I did a search and found this: https://stackoverflow.com/a/3886106/143475
Note that you could also write a static method in Java and use it if you need to something more advanced:
Background:
* def isInt = function(x){ return x % 1 === 0 }

Scenario Outline:
* assert isInt(<value>) == <isInt>

Examples:
| value | isInt |
| 1     | true  |
| 1.0   | false |


iOS 9: SSDP discovery doesn't work

We use HTTP to connect with local SSDP-discovered devices, and that is blocked by default in iOS 9. Here is a warning in logs:

App Transport Security has blocked a cleartext HTTP (http://) resource load since it is insecure. Temporary exceptions can be configured via your app's Info.plist file.

Adding this to the app's Info.plist file fixes this for now, although not recommended:
<key>NSAppTransportSecurity</key>
<dict>
	<key>NSAllowsArbitraryLoads</key>
	<true/>
</dict>

The other thing is to check whether devices support HTTPS (via DLNA, DIAL, Netcast, etc.).

Closing the issue as there is a work around as mentioned above


js-debug vs js-release

1. CSS file
Build works with "js-debug" but in "js-release" compiler change file name Main.css to Main.min.css but entry of css file doesn't reflects in "index.html"
either css file name should not be change or correct new file name must be added in index.html
2. Reading JSON file
in "js-debug"
_data is a JSON object
for each(var i:Object in _data){
trace(i.topic);
}
this works perfectly fine in "js-debug" but doesn't works in "js-release" it has to be change as below
for each(var i:Object in _data){
trace(i['topic']);
}
"js-debug" approach is standard one i think "js-release" must follow the same

Regarding your first point: What does your template html file look like? Make sure you have the ${head} token. Your minified css file should be correctly linked.
Regarding your second point, please read this page: https://apache.github.io/royale-docs/create-an-application/optimizations/minification

Actually, here's what I have in my template file:
<link rel="stylesheet" type="text/css" href="${application}.css?{build_number}">
${application}.css becomes MyApp.css in debug and MyApp.min.css in release. I have a build script which appends the build number for cache-busting.

@Harbs - it does works
the main confusion is - you won't find "Main.min.css" in debug mode but it appears in "js-release"
this is what my index-template.html

Learning Module
${head}

    ${body}

asconfig.json
{
"config": "royale",
"compilerOptions": {
"debug": true,
"targets": ["JSRoyale"],
"source-map": true,
"html-template": "src/assets/config/resources/index-template.html",
"theme": "${royalelib}/themes/JewelTheme/src/main/resources/defaults.css"
},
"copySourcePathAssets": true,
"additionalOptions": "-remove-circulars -js-output-optimization=skipAsCoercions",
"files":
[
"src/Main.mxml"
]
}

It does probably make sense to not add the min. to the name for release. It doesn't really add anything.


chore(pkg): remove duplicate babel-code-frame dependency

Hi
Looking at the ava dependencies I spotted a double babel-code-frame L86 and L151
No problem with removing the one in the devDependencies ?

Thanks!


Make the test script run on Windows

The current test script is
elm make --docs=docs.json && elm-format src/ tests/ --validate && elm-test && elm-review && npm run package-tests -s

But && does not work on Windows, so this prevents Windows users from helping out on this package.
I know of npm-run-all which helps make scripts run on Windows. It does require using npm scripts, so every part will need to be defined in a separate npm script. That has its benefits, but if you can come up with a different solution, let me know.
If we go with using npm-run-all, the task would be to

Create a script for every part of the test script

Add npm-run-all as a dependency

Replace the test script with one like npm-run-all make verify-format ...

Make sure the scripts are run sequentially. Running them in parallel would have little performance benefits but make failures quite hard to understand I think.

See if everything

Optional/bonus: Make the CI run the tests on Windows (and Mac?) to make sure that works. I think we'd need to change the runs-on field for test in .github/workflows/test.yml to [ ubuntu-latest, windows-latest, macos-latest ] but I haven't tried it out. More info here.

The idea is that all of this work, if proved successful, will then be the default setup for all review packages when created by elm-review new-package. That can be a separate PR for jfmengels/node-elm-review, but I think this is a good first step before generalizing.

Hello, I've just submitted PR #9 that splits the test script into separate subscripts using npm-run-all. I've tested it with success on my Windows machine (some subtests fail on my machine but this has nothing to do with the NPM scripts themselves since the plain command lines produce the same outcome).
I have not implemented the CI part because I have no experience with GitHub CI. I suggest you create a separate issue.
Happy Hacktoberfest!


Cannot share file from Safari

Describe the bug
In Safari if the web page is a file and we try to share it, our app is not showing as an option. We are able to share images, videos, files, audio from Photos and Files, also regular web pages and selected text. Android works fine and so does iOS chrome.
Here is our plugin config. Maybe we are missing some activation rule, but could not find information.
 "plugins": [
      [
        "expo-share-intent",
        {
          "iosActivationRules": {
            "NSExtensionActivationSupportsText": true,
            "NSExtensionActivationSupportsWebURLWithMaxCount": 1,
            "NSExtensionActivationSupportsWebPageWithMaxCount": 1,
            "NSExtensionActivationSupportsImageWithMaxCount": 10,
            "NSExtensionActivationSupportsMovieWithMaxCount": 1,
            "NSExtensionActivationSupportsFileWithMaxCount": 1
          },
          "androidIntentFilters": [
            "text/*",
            "image/*",
            "video/*",
            "audio/*",
            "application/*"
          ],
          "androidMultiIntentFilters": [
            "image/*"
          ]
        }
      ]
    ]

https://github.com/user-attachments/assets/55b82f24-32b3-416a-b11a-24f84de63db3
To Reproduce

create new expo project npx create-expo-app StickerSmash --template blank
install and configure expo-share-intent
open http://www.labottega.bg/assets/winelist_apr2023.pdf in safari and try to share it

Additional context

expo version : 51
using firebase : no
package version : 2.3.0
platform target : iOS
device : simulator & real device
type: local build

When you initiate a share for a PDF in Safari, it will actually consider 2 input items: the PDF and the URL. To handle this we need a custom NSExtensionActivationRule. But it's not handle in this plugin yet.
a workaround  is to use chrome on iOS to share pdf from the url
you can configure custom activation rule like this on your app.json:
    "plugins": [
      [
        "expo-share-intent",
        {
              "iosActivationRules": "SUBQUERY (\nextensionItems,\n$extensionItem,\nSUBQUERY (\n$extensionItem.attachments,\n$attachment,\nANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO \"com.adobe.pdf\"\n|| ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO \"public.file-url\"\n|| ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO \"public.url\"\n|| ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO \"public.jpeg\"\n|| ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO \"public.png\"\n).@count == $extensionItem.attachments.@count\n).@count >= 1",
         ...
        }
      ],

with this configuration (and some code update), the app appear in sharing view.

but the plugin doesn't handle it in the custom view

@m1st1ck available in v2.5.0 using a custom activation rule !


Fix timeline-comment arrows

Fixes #7. (retargeting dev)
Changes proposed in this pull request:
Override GitHub's .timeline-comment pseudo styles to correct arrow colors.

Thanks :+1:


UI not proper on Tablet

Device Info:
Model Name: Lenovo Tab4 10
Android Version: 8.1.0

I have tried running my application on Tablet and the unselected icons are going outside the tab. Also the selected tab icon is not centred properly. Even the circle slightly appears to be oval and not round.
Can you please provide tablet support?

Hello 👋
Thank you for the report, i'll check that very soon 👍

Could you provide sample code to reproduce the issue ?

You can use your own sample code and run on any android Tablet.

Try adding height
          bottomBarContainerStyle={{
            position: 'absolute',
            height: 70, <---- Here
            bottom: 0,
            left: 0,
            right: 0,
          }}

For the unselected icons that are going outside the tab, add higher height in bottomBarContainerStyle

Tried increasing the height in bottomBarContainerStyle but the curve for selected tab goes up and it doesn't look good.

how do you show the tab bar label? i cant show my tab bar label.

@Standin-Alone You can show the label using the default option from react-navigation :
tabBarLabel: 'Meh'

not working for me

Pass your label in the name prop like the following..

<Tab.Screen
options={{ tabBarIcon: tabBarIcon('wallet') }}
name="Wallet"
component={generateScreen('Wallet')}
/>

@Jm-Zion Any update on this?

@Jm-Zion Did you reproduce it at your end?


There is a problem with the contact form js ,can anyone help please

Could you please elaborate on the issue?

This is the code in apps.js, but when using the contact form on the page, it doesn't send anything.

Get In Touch

Hey AlsaidAbdu,
Remove the first form tag.
 <form action="form-carry-link-here" method="POST" accept-charset="UTF-8" >                   <input type="text" name="field1" placeholder="Your Name" required/>                   <input type="email" name="field2" placeholder="Email Address"  required/>                   <textarea name="field3" placeholder="Type your Message" required></textarea>                   <input type="submit" value="Send" />                 </form>

Hey AlsaidAbdu,
Remove the first  tag
 <form action="your-form-carry-link-here" method="POST" accept-charset="UTF-8" >                   <input type="text" name="field1" placeholder="Your Name" required/>                   <input type="email" name="field2" placeholder="Email Address"  required/>                   <textarea name="field3" placeholder="Type your Message" required></textarea>                   <input type="submit" value="Send" />                 </form>


HHH-18629 Fix inconsistent column alias generated while result class is used for placeholder

Alternative to #8971

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-18629

Ready to review @beikov

Could you rebase this on current main and repush please?  I'm having trouble doing it myself locally.

Superseded by https://github.com/hibernate/hibernate-orm/pull/9301


Bimodal threshold as Mean?

Bimodal threshold according to the histogram:
https://github.com/mauvilsa/imgtxtenh/blob/9a5113db63220a1e947d1a5690025b4b0c73698a/src/imgconv.c#L58-L69
when used as minval in:
https://github.com/mauvilsa/imgtxtenh/blob/9a5113db63220a1e947d1a5690025b4b0c73698a/src/intimg.c#L439
gives good results on pages with images.
Maybe you should consider replacing minval with various options?
Bimodal threshold:
int threshold_bimodal_graym (gray** img, gray** alph, int imgW, int imgH)
{
  int k, hist[256];
  int cnt = hist_graym(img,alph,imgW,imgH,hist);
  float T, Tw, Tb, Tn, iw, ib;
  int threshold = 0;

  T = 0.5 * 256;
  Tn = 0;
  while ( T != Tn )
  {
    Tn = T;
    Tb = Tw = ib = iw = 0;
    for (k = 0; k < 256; k++)
    {
      if ( k > T)
      {
        Tw += (k * hist[k]);
        iw += hist[k];
      } else {
        Tb += (k * hist[k]);
        ib += hist[k];
      }
    }
    if (iw == 0 && ib == 0)
    {
      T = Tn;
    } else if (iw == 0) {
      T = Tb/ib;
    } else if (ib == 0) {
      T = Tw/iw;
    } else {
      T = ((Tw / iw) + (Tb / ib)) * 0.5;
    }
  }
  threshold = (int)(T + 0.5);

  return threshold;
}

@zvezdochiot I am not actively developing this tool. You are welcome create a pull request. The only requirement is that with all the current options the tool should do exactly the same process. Several people use this tool, so I wouldn't accept a pull request that could change the original behavior.


Mistake - Expected declaration

Does anyone know what can it be?

The last release of ObjectMapper requires Xcode 7.3.
So you can either update Xcode, or use the previous version of ObjectMapper


How to reset the canvas?

I experimented on the plunker , I made clear function to reset to initial state:
clear() {       this.data1 = {};     }
the image cropper data resets but the canvas content is still there.

The cropper object has a reset function available

cropper object has not reset by using this function
clear() { this.data1 = {}; }

plz help me to  Reset canvas in anotherway

I have the same issue. I am not using the cropper as a component, just using it directly inside my other component, so I don't have the whole cropper object to reset. How can I clear the canvas without using cropper1.reset()?

I found an answer to this (to reset the canvas. you already know how to clear the cropped data):
In the html use #cropper like this:
<img-cropper #cropper [image]="data1" [settings]="cropperSettings" (onCrop)="cropped($event)">
In component.ts include these lines:
export class myComponent implements OnInit {
@ViewChild('cropper', undefined) cropper:ImageCropperComponent;
constructor () {}
clear () {
this.cropper.reset();
}
}

I am using the reset function as well as the resizeCanvas function, but the cropper size isn't changing. Anyone find how to do this?

thanks @savita-turner


Add Filter for Formatting Repeating Answers

What is the context of this PR?
Trello
This adds a filter to display lists of items (currently names, in future addresses etc.). These items can be from multiple groups.
How to review

Run test_repeating_answer_summaries

Enter a name

Ensure that name is displayed on the confirmation question

Ensure that each of the following confirmation questions also show the current list of names.

There is an example of the LMS survey which this should 'match' in trello.

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

@dwyeradam @jonnyshaw89 Ready to merge I think.

@bitdivision yeh, after the build has finished 👍


Upgrade to dev05

[IMPORTANT] compose-router needs to be updated to dev05 first, otherwise this code will not run!

Padding Composable was deprecated. Replaced it with LayoutPadding modifier where possible, otherwise Container with LayoutPadding modifier.
Fonts are now created with ResourceFont constructor, which is more resilient.
Tab constructor now has onSelected parameter instead of lambda for callback.

Pushed compose-router 0.5.0, tried it in your branch, will work fine. Please update when you can, and I'll merge.

@zsoltk updated!


CB-6764 Create private endpoints for cloud provider services in CB-created networks

@keyki or @lacikaaa pls review

There are conflicts. Please resolve them and we can merge.


Fixing links for SSD

looks good to me. @guschmue please merge if you are OK with the change.

@pkanwar23 it looks like https://zenodo.org/record/3246481#.XQbwEJJKhGF is outdated, as they uploaded another version of the model on June 16th. There are multiple Zenodo links that they have uploaded, and so we have to stick with the latest version as that was their request.


Kwallet doesn't unlock on login

Describe the bug
I've set Kwallet to unlock automatically on login but it doesn't unlock.
I'm not using KDE but my own i3-based environment, but I tested that this happens on Xfce too. I've tried SDDM and LightDM as my display manager, both fail to unlock the wallet.
I'm using recent nixos-unstable so I have the fix from this issue: #62045 That was supposed to fix on LightDM but the wallet still isn't unlocking with LightDM either.
This issue is related to KDE: #68316 But perhaps it's the same issue.
To Reproduce
Key parts in configuration.nix:
    services.xserver = {
      enable = true;
      displayManager.sddm.enable = true; # or lightdm
      desktopManager.xfce.enable = true;
    };

    security.pam.services = {
      gdm.enableKwallet = true;
      kdm.enableKwallet = true;
      lightdm.enableKwallet = true;
      sddm.enableKwallet = true;
      slim.enableKwallet = true;
    };

    environment.systemPackages = with pkgs; [
      kdeFrameworks.kwallet
      kdeApplications.kwalletmanager
    ];

Note: Kwallet must have the same password as the user login.
Steps to reproduce the behavior:

(Log out and restart the display manager?)
Log in to Xfce.
Open kwalletmanager5.
The wallet is locked.

Expected behavior
The wallet should be unlocked.
Metadata
]$ nix run nixpkgs.nix-info -c nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.74, NixOS, 20.03.git.0adcf14 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3`
 - nixpkgs: `/etc/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

If it's the same as #68316, you should see a core for kwalletd like this:
$ coredumpctl
...
Thu 2019-09-26 13:42:07 EDT    2336  1000   100   6 missing   /nix/store/38w20yz66bzkmrw6l2ml8x0alj1mkzxq-kwallet-5.61.0-bin/bin/.kwalletd5-wrapped
...

There's no kwalletd in my coredumpctl output. Well, there's one instance yesterday when I tried running KDE Plasma once. But as I've been logging in and out many many times during the last few days to my custom DE, there should've been plenty of those if it happened on my DE.

@jluttine Could you try out this PR: #70140, I suspect it will fix your case as well.

You also need to make sure /run/current-system/sw/etc/xdg/autostart/pam_kwallet_init.desktop is being run on startup.

@matthewbauer Thanks! Now it works. I cherry-picked the commit from the PR and ran ${pkgs.kwallet-pam}/libexec/pam_kwallet_init at DE start-up (that was the command the desktop file would have run, so yes, autostarting that desktop file would have worked too). Thanks a lot!

Just for reference: I was missing pkgs.kwallet-pam from environment.systemPackages. Adding the package there and having some tool that runs autostart desktop files should do the trick (and also having the PR fix).

I have the same issue with the following setup:

security.pam.services.lightdm.enableKwallet = true;
kwallet-pam and kdeFrameworks.kwallet in environment.systemPackages
home-manager manages the xsession which means that it generates a .xsession file that starts the window manager (i3 in my case)
putting ${pkgs.kwallet-pam}/libexec/pam_kwallet_init into .xsession via home-manager
checking that /run/current-system/sw/etc/xdg/autostart/pam_kwallet_init.desktop is present

The result is that in NixOS 20.03 kwalletd does not start at all and there is no entry in the coredumpctl log either.
With NixOS 19.09 kwalletd did start automatically but was not unlocked automatically despite naming it kdewallet and it having the same password as my user.

@lukasstevens Perhaps you are affected by #77290 which was fixed in https://github.com/NixOS/nixpkgs/commit/8021f0a4a54b03bc9cd1f4c1d40e00fa28ec6ad9?

If this is would be the root of the issue, I should have entries in coredumpctl, right? As I said, there are no entries for kwalletd in there.

@lukasstevens I don't know, I'm just suggesting. Perhaps open a new issue then if that fix didn't help?

Yeah this sounds like a new issue. I haven't testing lightdm+i3 support, but I expect somehow the autostart is not getting run.


Danger id as context of Github status

This uses the danger_id to set the context of Github status. Should allow multiple status for multiple execution of danger cli.
See #570

          1 Message

  :book:
  @thiagofelix is not a contributor yet, would you like to join the Danger org?

  Generated by :no_entry_sign: danger

Only two Rubocop offenses and we are good to go! 👍

@JuanitoFatas want me to fix the Rubocop offenses? They were already in the master branch when I forked.

OK, this just needs to rebase now 👍 then you are free to merge

we do :


proposal: spec: treat s[-1] as equivalent to s[len(s)-1]

Overview
This is a backwards-compatible language change proposal. It will not be as thorough as it could be, since I do not think it should be adopted. I am writing it up merely for future reference.
I propose to treat negative constant literals in slicing and indexing expressions as offsets from the end of the slice or array. For example:

s[-1] is equivalent to s[len(s)-1]
s[:-1] is equivalent to s[:len(s)-1]
s[:-2:-1] is equivalent to s[:len(s)-2:len(s)-1]

The motivation is to improve readability. Slice and index expressions like this occur commonly when treating slices as stacks.
Consider this code from the compiler:
func (f *Func) newPoset() *poset {
	if len(f.Cache.scrPoset) > 0 {
		po := f.Cache.scrPoset[len(f.Cache.scrPoset)-1]
		f.Cache.scrPoset = f.Cache.scrPoset[:len(f.Cache.scrPoset)-1]
		return po
	}
	return newPoset()
}

Using the proposed syntactic sugar, it would read:
func (f *Func) newPoset() *poset {
	if len(f.Cache.scrPoset) > 0 {
		po := f.Cache.scrPoset[-1]
		f.Cache.scrPoset = f.Cache.scrPoset[:-1]
		return po
	}
	return newPoset()
}

Scope
The proposed sugar would only apply to negative constant literals.
var b [10]byte
var v int = -1

const c = -1

var (
	_ = b[v]  // unchanged: results in runtime panic
	_ = b[c]  // unchanged: results in compile time error: index bounds out of range
	_ = b[-1] // new: evaluates to b[len(b)-1]
)

The rationale for b[v] to panic at runtime is that negative indices often arise due to overflow and programmer error.
The same rationale discourages allowing constant expressions such as b[c] as syntactic sugar. Constant expressions can be complex, non-local, and build-tag controlled.
However, a constant literal displays clear, obvious, local intent, and overflow-free, and affords little room for programmer error.
Order of evaluation and side-effects
Currently, the slice/array is evaluated before any index or slice indices. See https://play.golang.org/p/kTr9Az5HoDj.
This allows a natural order of evaluation for the proposal. Given expr[-1] or expr[:-1], expr is evaluated exactly once, and its length is used in subsequent len(expr)-c calculations.
Data
A quick-and-dirty AST parsing program examining slice expressions suggests that such expressions occur, but not with particularly high frequency.
Running over GOROOT yields that 2.51% of slice expressions could be rewritten to use this syntactic sugar. Running over my GOPATH yields 3.17%. Searching for candidate index expressions yields 0.35% and 0.91% respectively.
This is an underestimate. In many cases, for clarity, the code will already have been rewritten like:
n := len(s)-1
x = s[n]
s = s[:n]

And all index expressions were considered candidates for this analysis, which includes map accesses and assignments.
Nevertheless, this analysis suggests that this sugar is unlikely to be transformative in how Go code is written, and therefore probably does not pull its weight.

Similar proposal in the past: https://github.com/golang/go/issues/20176

Also #11245, but this variant is, on the one hand, better because because it doesn't accept variables, but, on the other hand, worse because why should we only accept constants?

@mvdan yes, this proposal was follow-up to a suggestion mooted during the conversation in #20176. I should have noted that.
@ianlancetaylor indeed. The best argument I see for the discrepancy is one of practicality: variables (and constant expressions) and constant literals should be treated differently because doing so affords increased readability without increasing the probability of silent bugs. But I agree that that isn’t a particularly compelling argument, given the small proportion of code that matches the pattern.

How does adding an exception to an expression (-1 in some cases is to be read as len(foo)-1) improve readability? Please explain, for me it's quite the opposite.

@gopherbot please close this issue in 48 hours.
(That obviously doesn’t work. But I wish it did. I’ll be the bot.)

@cznic the same way all syntactic sugar does: By providing a mental shortcut for common uses. Instead of having to parse out everything and confirm equivalence of the inner/outer expressions, I see [-1] and think “final element”.

That would be more natural if the indices of the slice were treated as elements in a ring of order len(s).

I don't think is usually that much of a big deal usually, but I've wanted this feature sometimes for cases where I'm indexing into a slice that isn't bound to a variable. For example, given func Example() []string, I've occasionally wanted to do something like Example()[:-1] for various reasons. Similarly, if the slice has a really long identifier for some reason, it definitely improves readability if using the name twice on the same line would make it annoyingly long. Of course, in either of these cases you could probably just stick it in a variable most of the time, but there are occasionally instances where that's kind of annoying.
Not the best examples, perhaps, but I think that it could be useful in these cases.

I'd like to re-open this. I wrote it six years ago(!) only to dismiss it. But over the years, talking to gophers, this comes up over and over as a common ergonomics complaint, like min and max (which I'm thrilled to have).
I propose the narrowest possible addition: special handling for the literal -1 in indexing and slicing. This gets the vast majority of the value, while leaving lots of options for future expansion (to other negative literals, to constant expressions).

Now that there's a slices package we could have something like slices.At(s, -1) which is a bit longer but has the benefit of not requiring a language change and being easier to spot

Or slices.Last(s). But then you also want slices.Pop(s) for the indexing. But should that do cap as well or just length? Should it return the final element as well as reslicing it? The space of useful operations is quite large here, which is why having access to raw indexing/slicing operators is valuable; they provide readable, orthogonal ways to express all of them.

Lots of relevant discussion at https://github.com/golang/go/issues/53510 (thanks to @dsnet for pointing this out).

To summarize some of my concerns with slices.Last:

It introduces an inconsistency where the first element is obtained with s[0], while the last is obtained with slices.Last(s).
It's unclear how to handle mutability. If slices.Last returns just E, then this is more natural to operate with, but if it returns *E, then you can mutate the element by storing into the pointer, but always handling a pointer can be fairly unnatural.

I support a language change that allows indexing with negative literals. Restricting it to just literals avoid any possibility of arithmetic bugs since there's no arithmetic involved. The presence of s[-1] is clear user intent to get the last element.

Copying over some of my usage analytics from #53510:
Frequency of constant slice indexes relative to start or end:

Index
Occurrences
Percentage

0
4953854
41.684%

1
2192516
18.449%

2
1135707
 9.556%

3
1370480
11.532%

4
521199
 4.386%

other
1391696
11.710%

-5
196
 0.002%

-4
443
 0.004%

-3
1682
 0.014%

-2
10336
 0.087%

-1
306168
 2.576%

Even though obtaining the last element is an order-of-magnitude less frequent than getting the first element, there are still ~300k occurences.

I'm a bit on the fence on this.
It makes sense to me especially if we consider the wrapping behavior of uints.
But people are probably used to seeing len(s) - 1 anyway.
My worry is the curse of knowledge.
Is there a way to check that someone who has never coded in go, looking at a codebase, can intuit what the negative slice index does?
Other than that, if it's only literals as proposed, I guess that could work. But that's never something that truly bit me in my own code. Or at least I don't remember.

Should slicing syntax also support negative indexes? Such as aSlice[0:-1]?

I believe yes.
The original proposal said that:

s[:-1] is equivalent to s[:len(s)-1]

and I would assume aSlice[0:-1] is equivalent to aSlice[:-1].

Is there a way to check that someone who has never coded in go, looking at a codebase, can intuit what the negative slice index does?

it's familiar enough from other languages like python, ruby etc and it's one the main question for "why doesn't support" in languages that don't.
It's easy to remember and explain if you think of it as wrapping around.
and while i think this particular one is easy to intuit not everything should necessarily be easy to intuit, it's enough that it is clear  and one search/spec consultation away.

@doggedOwl not convinced. Searching python negative index and the first result is a stackoverflow question:
https://stackoverflow.com/questions/11367902/negative-list-index

I thought about what the semantics should be for various library functions then realized I've written these things enough times and threw it all in a repo so I can use it later https://pkg.go.dev/github.com/jimmyfrasche/sidx I wouldn't expect most of that to be in std.

note this was declined by review in #33359

One interesting thing about the slices.At variant is that it could be defined as resolving the index modulo the length, so that indices greater than the length of the slice would "wrap around" back to the start again. That sort of function is useful if you want to distribute a smaller number of things somewhat-evenly over a larger number of things.
Negative indices are therefore just the extension of that principle to lower numbers, wrapping around to the end of the slice.
However, I suppose to be an adequate answer to the original use case it would also need something like slices.SliceAt for taking a sub-slice with similar handling of the indices.
package slices

// At returns the element from s at the given index modulo the slice length.
func At[Slice ~[]E, E any](s Slice, index int) E

// SliceAt returns a subslice of s starting at start modulo the slice length and ending at
// start+length modulo the slice length.
//
// If the requested subslice would cross from the end of s back to the start of s then
// the result is a slice over a newly-allocated backing array. Otherwise the result
// shares the backing array of s.
func SliceAt[Slice ~[]E, E any](s Slice, start, length int) Slice

// (no variation for the three-operand slice because it doesn't really make sense
// to specify capacity modulo length.)

Both of  these functions effectively treat the slice as an infinite series containing repetitions of slice s in both directions.
The quirk of SliceAt sometimes causing a new allocation and copying but sometimes behaving like a normal slice is admittedly awkward. Perhaps it would be better to require (start % len(s)) <= ((start + length) % len(s)) and length <= len(s), panicking if not, so that the result can be guaranteed to always share the same backing array, but that then adds an additional panicking case to carefully avoid. :man_shrugging:
I will pre-concede that earlier comments suggest that taking the final element is considerably more common than any other variation that isn't an already in-bounds index and so this generality might not actually be justified.


Navigation using VIM keys

Hello!
One big issue stoping me from daily driving this thing is just basically adding a support for VIM like navigation and usage.
There are bunch of terminal enthusiast that would much appreciate having that!
I could try adding that feature if the issue would be verified by the maintainer

Hi!
I am also enthusiast and every day NeoVim user so I know it needs to be added.
So I think this Issue is good point to start discussion: What mapping do you expect (of course I have my own thoughts)?
I think target group of this App will be happy about config file where you can setup remapping :thinking:

Hi!
I am also enthusiast and every day NeoVim user so I know it needs to be added.
So I think this Issue is good point to start discussion: What mapping do you expect (of course I have my own thoughts)?
I think target group of this App will be happy about config file where you can setup remapping :thinking:

I believe that the default key mapping would be a good one to start with. And for the mapping customisation some configuration would be needed. I believe there are few ways that could make that happen from ENV variables up to arguments passing, but I believe the best way would be start with some YAML or TOML configuration file.
This way the configuration could easily be transferred from one machine to another if needed. Or shared with the community.
Indeed, it has to be mentioned that there could also be some other configurable settings, so that has to be in mind when designing the integration of that into the existing codebase.

This is one of the biggest challenge because Textual is so "mouse" friendly that I wasn't sure if it is better to go with "left hand + mouse" approach or "both hand on keyboard".
But I think that this can be resolved as two different modes as there still might be both types of users

Hello, great tool, thanks! And I am very pleased that you are already dealing with Vim keys. Apparently shortcuts like 'C+A' or 'C+B' don't work under byobu-tmux, luckily the buttons are there, but shortcuts are faster. Where can you configure your own shortcuts?

As well as everyrhing outlined its worth mentioning a warpd project.
It utilizes vim keybibdings quite well. So we could take some ideas from it.

Last change introduced Vim/Custom Bindings.
You can try defaults but also in user_bindings.toml (next to default_bindings.toml in directory where project is installed) you can customize it.
Feel free to share you setups here.
I will appreciate any feedback.


add test servers for sending x-sendfile and x-accel-redirect

waiting on apache change to go in to merge, will then cherry-pick to master for <IP_ADDRESS> point release.

LGTM


Added PaperAuthorAffiliations.OriginalAuthor field

OPS Build status updates of commit 1cfca4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Demo script fails with ImportError: cannot import name 'metanet_pb2' from 'caffe2.proto'

Instructions To Reproduce the 🐛 Bug:
What exact command you run:
python demo.py --config-file faster_rcnn_fbnetv3a_C4.yaml --input input1.jpg --output output1.jpg
Full logs or other relevant observations:
(d2go) mat@ada:~/repos/d2go/demo$ python demo.py --config-file faster_rcnn_fbnetv3a_C4.yaml --input input1.jpg --output output1.jpg
Traceback (most recent call last):
  File "demo.py", line 11, in <module>
    from d2go.model_zoo import model_zoo
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/d2go/model_zoo/model_zoo.py", line 7, in <module>
    from d2go.runner import create_runner
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/d2go/runner/__init__.py", line 10, in <module>
    from .default_runner import BaseRunner, Detectron2GoRunner, GeneralizedRCNNRunner
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/d2go/runner/default_runner.py", line 28, in <module>
    from d2go.export.d2_meta_arch import patch_d2_meta_arch
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/d2go/export/__init__.py", line 5, in <module>
    from . import torchscript  # noqa
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/d2go/export/torchscript.py", line 13, in <module>
    from detectron2.export.flatten import TracingAdapter, flatten_to_tuple
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/detectron2/export/__init__.py", line 3, in <module>
    from .api import *
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/detectron2/export/api.py", line 6, in <module>
    from caffe2.proto import caffe2_pb2
  File "/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/caffe2/proto/__init__.py", line 11, in <module>
    from caffe2.proto import caffe2_pb2, metanet_pb2, torch_pb2
ImportError: cannot import name 'metanet_pb2' from 'caffe2.proto' (/home/mat/anaconda3/envs/d2go/lib/python3.7/site-packages/caffe2/proto/__init__.py)

pytorch                   1.11.0.dev20211109 py3.7_cuda10.2_cudnn7.6.5_0    pytorch-nightly
pytorch-lightning         1.5.0                    pypi_0    pypi

Was unable to track down what the issue was. Tried installing stable PyTorch build and got segfault

Hmm, how did you install those versions in particular? I can't seem to get conda to do this

I believe that the same possible with conda, but it was pip installation
pip3 install --pre torch==1.11.0.dev20211001+cu113 torchvision torchaudio -f https://download.pytorch.org/whl/nightly/cu113/torch_nightly.html

That definitely seems to work. Although I did it for cuda 10.2
I did have to recreate the env a couple of time though to get it to work not sure what I did wrong the first time

savanovich is right!

That definitely seems to work. Although I did it for cuda 10.2 I did have to recreate the env a couple of time though to get it to work not sure what I did wrong the first time

Hello, I am having the same issue and I use cuda10.2. Could you please share your command to install pytorch/torchvision on cuda10.2? Also, can you share command using conda if possible? thanks a lot in advance!

hello, did you sovle it in cuda10.2 enviroment?, can you show the pytorch installation command?

@xiyinmsu

savanovich
Hi guys, I tried to install torch==1.11.0.dev20211001+cu113, but this version seems to be deleted. Is there any solution ?
I also tried with torch-1.11.0.dev20211002+cu111, but it still had caffe2.proto importing issue.
Or, should I build pytorch with specific commit ?

Hi @nightheronry,
I'm currently facing the same issue you had. Were you able to resolve this?
Thanks.

Also facing this issue. Please help

I'm running into the same error.

I'm facing the same issue! any solutions?

same question, sad...

I am also experiencing this problem.
My device is Mac M1.
torch version: 1.13.0
torchaudio version: 0.13.0
torchvision version: 0.10.0


⚠ ClamAV has degraded performance

In b1381fd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 237 ms

Resolved: ClamAV performance has improved in 718cca2.


Consistent readiness status updates

What problem are you facing?
The Ready status of a resource is reflected nicely when the resource is being created, but not so when updating or doing other things.
For example, when a resource needs to be updated, there is no status indicating this to the user, except for an event and log saying "Successfully requested update of external resource". The Ready status will just be true while this is happening. Successfully updating a resource also doesn't return reconcile.Result{Requeue: true}..., which means it won't trigger an observe right after to confirm that the update did its job.
When creating a resource, the Ready status is set to false with Creating as the reason both when it errors and succeeds, which is the correct way to do it. It also returns reconcile.Result{Requeu: true}... to make sure the resource is ready for use.
How could Crossplane help solve your problem?
I don't see why Create should be different than Update, so I would prefer if they were consistent.
I would personally add a ConditionReason for this as well as a helper function to set the Ready status for you, like its done with Create and Delete:
const ReasonUpdating ConditionReason = "Updating"

// Updating returns a condition that indicates the resource is currently
// being updated.
func Updating() Condition {
    return Condition{
	Type:               TypeReady,
	Status:             corev1.ConditionFalse,
	LastTransitionTime: metav1.Now(),
	Reason:             ReasonUpdating,
    }
}

The code that executes external.Update should be updated to return this reconcile.Result:
return reconcile.Result{Requeue: true}, errors.Wrap(r.client.Status().Update(ctx, managed), errUpdateManagedStatus)
All the returns related to the update should also add xpv1.Updating() to its SetCondition:
managed.SetConditions(xpv1.Updating(), xpv1.ReconcileSuccess())

This makes sense to me.
I think the Create case was more obvious since it usually impacts time to readiness. For resources that do not require a provisioning time, e.g. a bucket, we want to mark it as Ready as soon as possible after the Create call, so, we re-queued immediately instead of waiting for the next reconcile (usually after the poll interval, assuming we don't update the CR in Create).
Reflecting on the Updates feels less of an issue than Create, but it is still valid.
We need to make sure it doesn't introduce loops (for whatever reason I can think of) or extra loads, at least by testing with some of the providers/resources out there.

Would this also mean that a failed update results in the resource no longer being ready? I think that would be really valuable; the fact that this doesn't happen (at least not always) today makes troubleshooting much harder.

Does a resource being updated mean it's not ready? I don't think so, at least not usually.
The Ready status condition indicates that the resource in the external system that the MR represents is ready to use.
When the provider requests that a resource be created, it typically takes a little time for the creation process to complete. During this time the resource isn't usable. The provider confirms the creation has succeeded before marking the resource ready.
When the provider requests that a resource be updated, it doesn't necessarily prevent anyone from using the external resource. Some resources (for example a GKE cluster) may enter a state like 'Repairing' and be degraded or unavailable while the external system processes the update. This isn't always the case though - in fact anecdotally I think it's less common.

Does a resource being updated mean it's not ready? I don't think so, at least not usually.
The Ready status condition indicates that the resource in the external system that the MR represents is ready to use.
When the provider requests that a resource be created, it typically takes a little time for the creation process to complete. During this time the resource isn't usable. The provider confirms the creation has succeeded before marking the resource ready.
When the provider requests that a resource be updated, it doesn't necessarily prevent anyone from using the external resource. Some resources (for example a GKE cluster) may enter a state like 'Repairing' and be degraded or unavailable while the external system processes the update. This isn't always the case though - in fact anecdotally I think it's less common.

I totally agree with this, we currently use the ready status on a resource to determine whether or not we can access status properties on the resource, which usually includes some for ID / ARN.
From our perspective, a resource that is updating is still "ready" even if the update fails because its existing status properties remain valid.
For example we may request to expand a disk on a VM which fails, but other resources consuming that VM's ID should consider the VM ready.
Synced being set to false, might make sense, or an addition of a new state property.

More robust status conditions like it sounds like are being discussed here would be a better solution to https://github.com/crossplane/upjet/issues/327 than what I proposed in that issue.

Also related: https://github.com/crossplane/crossplane-runtime/issues/198
If we basically merge synced/upToDate into Ready as Reason, I think we should try to get reason as a field in additionalPrinterColumns so the same information in kubectl as today with synced.

And this? :) https://github.com/crossplane/crossplane-runtime/issues/39

And: https://github.com/crossplane/crossplane-runtime/issues/363#issuecomment-1402333428


Adding Hawaii

@lorensen two things:

I have provided a set of options, for different color schemes, I like the default one I selected as it shows a lot of detail. If you don't like it please change it. I also fixed the old preset table of colours to look a lot better.
I cannot get the test to work. If you run the program manually the image is generated OK, however when ctest runs, all I get is a blue background. I have no idea why so maybe you could help here.

Thanks! I'll fix it up.

Wrong data name in CMakeLists.txt and ren->Render()'s were causing crashes.

Thanks for finding that.
Andrew Maclean
On 17 Oct 2017 10:16, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

Wrong data name in CMakeLists.txt and ren->Render()'s were causing crashes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/49#issuecomment-337071117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIJ4O2UDSo22aoC2_xASsNVMkodY4PYeks5ss-PlgaJpZM4P7T-1
.

You did the hard part. I like your improvements.
On Oct 16, 2017 5:55 PM, "Andrew Maclean"<EMAIL_ADDRESS>wrote:
Thanks for finding that.
Andrew Maclean
On 17 Oct 2017 10:16, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

Wrong data name in CMakeLists.txt and ren->Render()'s were causing
crashes.
—
You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/49#issuecomment-337071117,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIJ4O2UDSo22aoC2_
xASsNVMkodY4PYeks5ss-PlgaJpZM4P7T-1>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/49#issuecomment-337085566,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDPFyX8mDCp3x4jbFrykqzOQn6DGfks5ss_r2gaJpZM4P7T-1
.


Create empty VM Templates in vCenter for marketplace apps

Description
Currently the VM Template associated to an image is not valid if the underlying hypervisor is vCenter, since a reference to an existing template is needed.
The qcow2 to vmdk conversion process should also create an empty template in vCenter, so the VM Template defined in the marketplace can be updated and the reference for the new empty template be added to it.
Use case
User tries to deploy a marketplace app onto vCenter. Needs to go over this awkward process:
http://docs.opennebula.org/5.8/advanced_components/marketplace/migrate_images.html#qcow2-image-to-vmdk-datastore
Interface Changes
No changes

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

In order not to interfere with older versions, a VERSION should be added to hosts by the vCenter IM probe.

for old users, it'll ensure the template can't be planned for any vcenter
for new users (which matches VERSION>5.10.0), it'll plan the template

A direct way of implementing this is through a default VM Template ID

A direct way of implementing this is through a default VM Template ID

[DOC]

https://github.com/OpenNebula/docs/pull/1418

[TEST]

https://github.com/OpenNebula/development/pull/1260

[ONE]

https://github.com/OpenNebula/one-ee/pull/629


Form Rows do not  keep the continuity of their side edges in snapshot

How to reproduce
Just make a very simple form view like this:
static var previews: some View {
        Form {
            Section("Test") {
                Text("Row 1")
                Text("Row 2")
            }
        }
    }

The preview that SwiftUI Canvas shows is the following:

The generated previews instead is:

Is very subtle but if you check the edges on the sides of the two rows you will see that the rounding happens PER ROW in the preview snapshot, instead of happening only at the end and at the start of the row like in the SwiftUI preview.
These happens for all views that use the system rows.

Hi! Prefire uses the library - swift snapshot testing inside. I tried to reproduce using this library and the bug is also reproduced.
As I understand it, the problem is that the library uses SwiftUI.View wraps in a UIHostingViewController. I will try to look for an alternative or a workaround to this problem. In the meantime, I recommend bringing this problem to the library repository.


Write tests for S3 store

This mocks S3 REST API via Bypass.  In my humble opinion in this
situation it is better choice than mocking ExAws directly as S3 REST API
is less likely to change and we can test different situations
independently (i.e. network outages) without digging to ExAws internals.

Coverage increased (+3.7%) to 76.329% when pulling b998d8f0fa12135b5c13fb8ba60865b56e405c60 on test-s3-store into 8e111ad5808ab9b4b3a86027ec23372f150ddbb7 on master.


tooltip.formatter function receives wrong data when using dataset.source

Version
4.2.1
Reproduction link
https://stackblitz.com/edit/typescript-tjkfuf?file=index.ts
Steps to reproduce

Open the reproduction link
Hover over any series
Open the console and investigate

What is expected?
The array[i].data should contain the correct data for hovered group.
What is actually happening?
The array[i].data contains incorrect data.

Why do you think the data is incorrect? What data is expected?

I'm sorry, misunderstanding from my side. I managed to do what I intended. Closing the issue.


gdb-multitarget: add to all-packages

Motivation for this change
Tired of building it myself.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc maintainer @nbp

I was thinking of making this default for gdb, as it does add more features to gdb but doesn't add any dependency (as far as I know).

@rasendubi, add a lowPrio and I will merge

@obadz done


feat: Live query validation in the SQL Lab UI (#7461) (#7516)

REGARGET TO MASTER (#7461 / #7516)

[WIP] Live query validation, where supported

This builds on #7422 to build check-as-you-type sql
query validation in Sql Lab. This closes #6707 too.
It adds a (debounced) call to the validate_sql_json
API endpoint with the querytext, and on Lyft infra is
able to return feedback to the user (end to end) in
$TBD seconds.
At present feedback is provided only through the
"annotations" mechanism build in to ACE, although
I'd be open to adding full text elsewhere on the
page if there's interest.

fix: Unbreak lints and tests

Codecov Report

Merging #7518 into master will decrease coverage by 0.14%.
The diff coverage is 17.91%.

@@            Coverage Diff             @@
##           master    #7518      +/-   ##
==========================================
- Coverage   65.43%   65.29%   -0.15%
==========================================
  Files         432      432
  Lines       21319    21386      +67
  Branches     2347     2357      +10
==========================================
+ Hits        13951    13963      +12
- Misses       7252     7303      +51
- Partials      116      120       +4

Impacted Files
Coverage Δ

...rset/assets/src/SqlLab/reducers/getInitialState.js
0% <ø> (ø)
:arrow_up:

superset/views/core.py
72.92% <ø> (ø)
:arrow_up:

superset/assets/src/SqlLab/reducers/sqlLab.js
50% <0%> (-6.61%)
:arrow_down:

superset/assets/src/featureFlags.ts
90% <100%> (+1.11%)
:arrow_up:

superset/assets/src/SqlLab/actions/sqlLab.js
64.73% <13.04%> (-5.92%)
:arrow_down:

...uperset/assets/src/SqlLab/components/SqlEditor.jsx
54.7% <20%> (-5.11%)
:arrow_down:

.../assets/src/SqlLab/components/AceEditorWrapper.jsx
58.33% <71.42%> (+1.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda1002...2ccd62e. Read the comment docs.


Typo

No issue number, just a typo I noticed when reading the docs.

@azerbijon123  thanks for the fix.


[WIP] remove expensive api from InternalRow

This is a follow up PR for #6792, to use narrow down the APIs in InternalRow (remove those expensive ones).

Merged build triggered.

cc @liancheng @rxin @JoshRosen

Merged build started.

Test build #35092 has started for   PR 6869 at commit 444382e.

hi @davies , I met a bug at https://github.com/apache/spark/pull/6825 that we didn't handle BinaryType(byte[]) correctly at equals and hashCode. We should use java.util.Arrays.equals and java.util.Arrays.hashCode. Could you fix it here?

Test build #35092 has finished for   PR 6869 at commit 444382e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Row extends InternalRow
abstract class InternalRow extends Serializable
final class SpecificMutableRow(val values: Array[MutableValue]) extends Row with MutableRow
class GenericRow(protected[sql] val values: Array[Any]) extends Row
abstract class InternalOutputWriter extends OutputWriter

Merged build finished. Test FAILed.

@davies can you update the pr description to include what you actually removed?

@cloud-fan it will be fixed by https://github.com/apache/spark/pull/6876

Close this, in favor of #7003


Update and fix backend readme

Is your feature request related to a problem? Please describe.
The backend readme currently specifies the incorrect directory for npm install
Describe the solution you'd like
It should be /Updog/backend/ not /Updog/

See pull request https://github.com/SE701Team2/Updog/pull/220