HTTP requests changing to HTTPS before hitting SW

Just noticed a difference between Chrome and Firefox Nightly (v47).
Making a fetch request over HTTP in Chrome is hitting the service worker with that URL. In Firefox however, the URL has it's protocol changed to HTTPS.
@jakearchibald @wanderview @slightlyoff I call on your mega brains for thoughts / insights.
I'm guessing that this is a HTST header issue perhaps as I noticed it when using http://developers.google.com.

We explicitly test for this behavior:
https://dxr.mozilla.org/mozilla-central/source/dom/workers/test/serviceworkers/test_hsts_upgrade_intercept.html
Also, I think the spec calls for the upgrade to take place before interception.  The upgrade takes place in step 4 of Main Fetch, but service worker intercept doesn't happen until later at step 3 of HTTP Fetch.

Awesome, will double check spec and if that's a case put together a test case for a Chrome issue.
(Also now realising I completely messed up jake's and alex's github usernames)

This looks like a Chrome bug, raised it here - https://bugs.chromium.org/p/chromium/issues/detail?id=599406


Initial support for Windows Auto tests

@BFH-E1D-2015-2016/romand  -> Our tests servers now build SuperTeach and run the test suit on Linux, Mac OS X and Windows


Add more native docker test cases

Add test cases for container exec, logs, and ip injection

LGTM

LGTM


Perfomance degradation compared to vanilla with the same config

vanilla:
pgbench -M prepared -S -s 10 -p 6432 -h <IP_ADDRESS> -P1 -T180
Scale option ignored, using pgbench_branches table count = 10
starting vacuum...end.
progress: 1.0 s, 12637.7 tps, lat 0.078 ms stddev 0.054
progress: 2.0 s, 12991.0 tps, lat 0.076 ms stddev 0.069
progress: 3.0 s, 12806.6 tps, lat 0.077 ms stddev 0.053

current version:
pgbench -M prepared -S -s 10 -p 6432 -h <IP_ADDRESS> -P1 -T180
Scale option ignored, using pgbench_branches table count = 10
starting vacuum...end.
progress: 1.0 s, 8209.9 tps, lat 0.121 ms stddev 0.114
progress: 2.0 s, 8436.1 tps, lat 0.117 ms stddev 0.092

config
[databases]
vadv = host=localhost dbname=vadv
[pgbouncer]
logfile = /home/vadv/.pg/pgbouncer/git/pgbouncer.log
pidfile = /home/vadv/.pg/pgbouncer/git/pgbouncer.pid
listen_addr = <IP_ADDRESS>
listen_port = 6432
auth_type = trust
auth_file = /home/vadv/.pg/pgbouncer/git/users.txt
pool_mode = transaction
server_reset_query = DISCARD ALL
max_client_conn = 100
default_pool_size = 20

fixed


Update DG

Update DG UML Model diagram to current code state
Add attribute income to invalidAndValidPersonAddressBook.json since a valid person will have a income attirbute

See file changes for more details

Codecov Report
Base: 72.74% // Head: 72.74% // No change to project coverage :thumbsup:

Coverage data is based on head (3f79bc6) compared to base (7137a5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     72.74%   72.74%
  Complexity      437      437
=========================================
  Files            74       74
  Lines          1350     1350
  Branches        149      149
=========================================
  Hits            982      982
  Misses          320      320
  Partials         48       48

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

.../java/seedu/address/model/meeting/MeetingDate.java
75.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Usability: NVDA: Position and Size of list item of Combo box in 'package Manager' window is not announced by NVDA

Steps to Reproduce

Open "Xamarin Workbook"
Products window is opened.
Navigate to the "wpf "icon and select "create workbook".
4.Under "File" menu select "Add packages" or select 'Add package' button at the bottom of the workbook page.
Navigate to 'package Source' combo box and expand it
Navigate through list item and observe NVDA announcement

Expected Behavior
Position and Size of list item should be  properly announced by NVDA
Actual Behavior
Narrator Behavior: Narrator is announcing as '''Xamarin.Interactive.NuGet.PackageSourceViewModel, 1 of 2 Selected'''
NVDA behavior:NVDA is announcing as ''Xamarin.Interactive.NuGet.PackageSourceViewModel, list item focus not Selected"
User Impact
Users who rely on screen reader will not be able to know the position and size of list items
Screenshots

Environment
Windows :Widows 10 Pro Version 1803 (OS Build : 17672.1000)
Xamarin Version : 1.4 (master/b3f92f9)
NVDA Version: 2018.1

Log File

Please add the following labels to the bug:
A11yUsable
Accessibility
Xamarin-Workbooks-Windows
Wipro


Anyway you could add a "date" field to column types to sort on?

I could probably hack something together or edit the current component but I'm sure you could do this more efficiently than me. Just let me know, thanks!

Guessing that's a no? Lol

Don't sell yourself short friend! You would have done a fine job i'm sure. I used moment to parse/format dates. you can find the changes in version 1.4.0.

Example usage:
you can add a column like so:
{
          label: 'Created On',
          field: 'createdAt',
          type: 'date',
          inputFormat: 'YYYYMMDD',
          outputFormat: 'MMM Do YY',
          filterable: false,
        },

and your date should look like '20160423' //depending on the format you specify in inputFormat.

Awesome! Thanks, I appreciate it!

No problem! let me know if you have a problem using it.

Sounds good, ill do some testing tomorrow and report back with the results.
On Jun 1, 2017 7:14 PM, "xaksis"<EMAIL_ADDRESS>wrote:

No problem! let me know if you have a problem using it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xaksis/vue-good-table/issues/4#issuecomment-305646064,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG9Inz3n2TM3JDi0DqCVY-340DtxGWzgks5r_0XFgaJpZM4NtdFg
.

I got that working but it looked like there was an error in your sort method.
I had to change
  if (this.columns[this.sortColumn].field === 'date') {
                x = moment(x + '', this.columns[this.sortColumn].inputFormat);
                console.log(x)
              }

to
  if (this.columns[this.sortColumn].type === 'date') {
                x = moment(x + '', this.columns[this.sortColumn].inputFormat);
                console.log(x)
              }

Looks like you have it looking at the field name instead of the field type. My field name was "due_date" so it wasn't working at first and I had to go through and change that.
Other than that, it works great. Thanks again!

whoops! good catch... 1 fix coming right up.

v1.4.1

@bbennett36 I just switched out the date parsing/formatting library. Please let me know if all your use cases still work fine? Thank you!

Are you able to use the 'defaultsortby' setting on a date field? Mine doesn''t seem to be working. The regular date sorting is still working perfect though.


Latest version?

Hi,
I see the version 2019.4 available on pip. However, I fail to find it in the source code. Is this repository containing the latest version of the code? The ReadMe suggests to use the git clone but in this case it seems that the repository has an even older version than is available in PyPi.
Great project, BTW. Just doing some experiments initially. Hope to be able to contribute.
Cheers

Hello @MisterY
I forgot to apply a tag to the last commit. The last commit correspond to the last pip version. Have a good coding

Great, thanks! setup.py shows 2018.12, which confuses me.

Thank you for reporting this, I make a correction now


how do you change the colour of your name

i saw people with a purple nametag and how do you d that

you cannot change it yourself, server owner has to change it for you


Authentication failed for user<EMAIL_ADDRESS>

I run "bundle exec veewee vbox build" command as follows, it returns "Authentication failed for user<EMAIL_ADDRESS>but after that,  "ssh<EMAIL_ADDRESS>-p 7222" command works.
$ bundle exec veewee vbox build -n -f freebsd91
==========================================

The isofile VBoxGuestAdditions_4.1.18.iso already exists.
Building Box freebsd91 with Definition freebsd91:
- debug : false
- cwd : /home/xxx/veewee
- force : true
- nogui : true
- auto : false
- checksum : false
- redirectconsole : false
- postinstall_include : []
- postinstall_exclude : []
- skip_to_postinstall : false

The isofile FreeBSD-9.1-RELEASE-amd64-disc1.iso already exists.
Shutting down vm freebsd91
VBoxManage unregistervm  "freebsd91" --delete
Deleting vm freebsd91
Creating vm freebsd91 : 8096M - 4 CPU - FreeBSD_64
Creating new harddrive of size 100140, format VDI, variant Standard
Attaching disk: /home/xxx/VirtualBox VMs/freebsd91/freebsd911.vdi
Mounting cdrom: /home/xxx/veewee/iso/FreeBSD-9.1-RELEASE-amd64-disc1.iso
Mounting guest additions: /home/xxx/veewee/iso/VBoxGuestAdditions_4.1.18.iso
Finding unused TCP port in range: 7222 - 7262
Selected TCP port 7222
Finding unused TCP port in range: 7222 - 7262
Selected TCP port 7222
Waiting 10 seconds for the machine to boot
Finding unused TCP port in range: 7122 - 7199
Selected TCP port 7122
Starting a webserver :7122

Typing:[1]: <Esc>
Typing:[2]: load geom_mbr
Typing:[3]: <Enter>
Typing:[4]: load zfs
Typing:[5]: <Enter>
Typing:[6]: boot -s
Typing:[7]: <Enter>
Typing:[8]: <Wait><Wait><Wait><Wait><Wait><Wait><Wait><Wait><Wait><Wait>
Typing:[9]: /bin/sh<Enter>
Typing:[10]: mdmfs -s 100m md1 /tmp<Enter>
Typing:[11]: dhclient -l /tmp/dhclient.lease.em0 em0<Enter>
Typing:[12]: <Wait><Wait><Wait>
Typing:[13]: echo "Sleeping for 10 seconds, then running install script."<Enter>
Typing:[14]: sleep 10 ; fetch -o /tmp/install.sh http://<IP_ADDRESS>:7122/install.sh && chmod +x /tmp/install.sh && /tmp/install.sh freebsd91<Enter>
Done typing.

Serving file /home/xxx/veewee/definitions/freebsd91/install.sh
Shutting down for /home/xxx/veewee/definitions/freebsd91/install.sh
Waiting for ssh login on <IP_ADDRESS> with user vagrant with password vagrant to sshd on port => 7222 to work, timeout=10000 sec
............................................................................................Authentication failure
Authentication failed for user<EMAIL_ADDRESS>

closing as there was no feedback in three months, please let me know if you can provide more details and I will reopen


Request Telemetry Filtering and AutocollectedMetricsExtractor

Please note that standard metrics collection (avg server response time, etc.) is done by built-in AutocollectedMetricsExtractor telemetry processor. Custom telemetry processors that filters our request telemetry should be registered before standard processors to exclude requests from both telemetry and metrics. E.g. they should be registered at the beginning of <TelemetryInitializers> list (ASP.NET Framework), or registered before services.AddApplicationInsightsTelemetry(); call (e.g. you should call AddApplicationInsightsTelemetryProcessor<MyFilter>() first, and only then call AddApplicationInsightsTelemetry()). See https://github.com/microsoft/ApplicationInsights-Home/issues/445 for details on metrics screw for SignalR because of wrong registration order.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26b3e91f-c240-fffa-6ae9-d676deb7ad4c
Version Independent ID: bbfa099e-3ed6-09ea-fbde-f2a3ed13139a
Content: Filtering and preprocessing in the Azure Application Insights SDK - Azure Monitor
Content Source: articles/azure-monitor/app/api-filtering-sampling.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

Thank you for bringing this to our attention. We have added this request to our backlog.

Closing this issue for now since an internal work item has already been created and added to our backlog. Will update this thread when the work is completed. Thank you for your patience.
#please-close


Added a WEB entry to timezones

Sorry if I am doing this wrong, I figured it would be a good learning experience to try and fix my own bug instead of asking someone else to do it for me.
Thanks for any advice/criticism if I am submitting this incorrectly.

Thanks for the pull request! Before a real human comes by, please make sure your PR has all of the below criteria checked

[x] Give a description on what the PR is for.
[ ] Make sure your PR is based on the DEVELOP branch
[x] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

Please make sure you also read contribution guide and followed all of the steps.
Thanks!

re-doing this on the develop branch
sorry

Hey, the bot is wrong here, its ok on the master branch for sickrage.github.io I just need to update the bot =P


Kitchen sink - Plan, collect feedback for update and new Guide.

Generate an outline of items to show case Augury's features.
Come up with ideas for Augury guide.
Hold team meeting to collect feedback.
Also discuss ideas on improving Kitchen sink app.

Create initial idea google doc: https://docs.google.com/document/d/1_DgJA2JFWXMg42lxXUlbTYRF0pIa1sciIrDBIGoo33E/edit

Guide moved from gdocs to markdown file under Augury github docs/guide


doom-modeline ERROR: Wrong type argument: stringp, nil

What did you expect to happen?
emacsclient works well just like emacs.
What actually happened?
*ERROR*: Wrong type argument: stringp, nil

In the recent doom upgrade, I got this error on emacsclient startup.
I can do a doom/reload-theme and reopen doom dashboard, it works like normal.
It used to work without any problem couple days ago.
Additional details:

Maybe related to this issue: https://github.com/hlissner/doom-emacs/issues/2597
Steps to reproduce:
(setq doom-modeline-major-mode-icon t)

non-emacsclient works well. But emacsclient has this bug.
System information:

```
emacs   version    26.3
        features   JPEG RSVG IMAGEMAGICK GLIB NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2
        build      Feb 13, 2020
        buildopts  (--disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus/26.3/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus/26.3 --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained)
        windowsys  ns
        daemonp    daemon
doom    version    2.0.9
        build      HEAD -> develop ca74996d1 2020-03-01 13:25:47 -0500
        dir        ~/Dropbox/Apps/emacs/tru/doom-emacs/
system  type       darwin
        config     x86_64-apple-darwin19.3.0
        shell      /bin/zsh
        uname      Darwin 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan  9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64
        path       (/usr/local/opt/sqlite/bin ~/.tgenv/bin /usr/local/opt/node@8/bin /usr/local/opt /usr/local/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Applications/Server.app/Contents/ServerRoot/usr/bin /Applications/Server.app/Contents/ServerRoot/usr/sbin /Applications/Wireshark.app/Contents/MacOS /opt/local/bin /opt/local/sbin /usr/local/mysql/bin /usr/bin /bin /usr/sbin /sbin /usr/local/bin /usr/local/git/bin ~/.composer/vendor/bin /usr/local/sbin /snap/bin ~/go/bin /usr/local/opt/go/libexec/bin /usr/local/Cellar/emacs-plus/26.3/libexec/emacs/26.3/x86_64-apple-darwin19.3.0/)
config  envfile    envvar-file
        elc-files  716
        modules    (:input chinese :completion company ivy :ui deft doom doom-dashboard doom-quit hl-todo hydra modeline nav-flash neotree ophints (popup +all +defaults) tabs treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor file-templates fold multiple-cursors rotate-text snippets word-wrap :emacs dired electric ibuffer vc :term vterm :checkers syntax :tools docker (eval +overlay) (lookup +docsets) macos magit terraform tmux :lang data emacs-lisp go markdown (org +dragndrop +hugo +present) php python sh web :config literate (default +bindings +smartparens))
        packages   ((ox-twbs) (sudo-edit) (google-this) (git-auto-commit-mode) (grab-mac-link) (ivy-posframe) (helm-org-rifle) (nyan-mode) (edit-server) (whitespace-cleanup-mode) (pinyinlib) (pinyin-search) (youdao-dictionary) (ob-tmux))
        unpin      (n/a)
        elpa       (n/a)
```

I cannot reproduce this. Can you reproduce this with your private config disabled?
You also appear to have byte-compiled your config. Does the issue go away after running doom clean? How about doom update (in case doom-modeline isn't up-to-date)?

Thanks for replying.
Will try to dig more and update here soon.

I found the issue. Turns out it the settings I added from a blog causes it - http://sodaware.sdf.org/notes/emacs-daemon-doom-modeline-icons/
Comment it out and fixed, thanks.


[Windows] Could not use GCEPersistentDisk as Volume on Windows worker

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Prepare 1 Linux Ubuntu 18.04 and 1 Windows 2019
Set up a cluster with GCE cloud provider:cloud_provider:
  name: gce
  customCloudProvider: |-
    [Global]
    project-id=<your projcet ID, optional>
    network-name=<your network, optional if using default network>
    subnetwork-name=<your subnetwork of the above network, optional if using default network>
    node-instance-prefix=<your instance group name/your instance name specific prefix>
    node-tags=<your network tags, optional if not patching any tags>
services:
  kube-controller:
    extra_args:
      configure-cloud-routes: true

Add a Linux control plane + etcd + worker node
Add a Windows node
Deploy a Windows workload with an existing GCEPersistentDisk, following https://kubernetes.io/docs/concepts/storage/volumes/#gcepersistentdisk

Result:
-. Workload event:

kubelet logs from Windows:

Other details that may be helpful:
A related issue from Kubernetes: https://github.com/kubernetes/kubernetes/issues/74674
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom
Machine type (cloud/VM/metal) and specifications (CPU/memory): Cloud
Kubernetes version (use kubectl version): 1.14.1

Closing this issue, as its a duplicate
Tracking this issue in https://github.com/rancher/rancher/issues/20839


Update fedora Docker tag to v39 - 136

[Auto generated]
Number: [#136]

github-webhook-server: Closing issue for PR: Update fedora Docker tag to v39.
PR was closed.


Fix for bounds in Android

This needs to be reviewed and documented for Android because it behaves a little bit weird..but at least i want your attention on this to make this work please :)

I willl come back with this pull with proper curated values if you want.. just ping me.


[readme] Update broken link for configuration files

Fix broken link to ESLint docs in README

Codecov Report

Merging #3071 (bd270fc) into master (f4854ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3071   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files         111      111
  Lines        7529     7529
  Branches     2769     2769
=======================================
  Hits         7336     7336
  Misses        193      193

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4854ea...bd270fc. Read the comment docs.


Intermittent failure to render on iOS 11

I'm still investigating this and will add more here as I discover it, but I'm seeing that several (but not all) SVGs in my app intermittently (but not always) fail to render. Is anyone else seeing this?
According to the inspector, the element is there and has its proper dimensions as normal, but at least one element is completely invisible.
In my case, the elements in question are all Circles or Rects with gradient fills that are overlayed by something else. In one case, I have several shapes within one <Svg> component, and only one of those shapes ( a Circle) is intermittent, the rest work (inlcuding another Circle) never fail.

I’m experiencing something similar. Sometimes my SVGs don’t render. They all contain just one path though and not circles. I didn’t associate it with iOS11 so far, but it could be. Also happens much more often in the simulator.

It does seem to vary between devices, although I've seen it happen at least once on everything (iPad Pro, iPhone 6 simulator, iPhone SE) except an iPhone 6 still running iOS 10, hence the iOS 11 association.
I haven't been able to make any headway on it unfortunately, there are no errors or warnings and no way of programmatically detecting the problem I've been able to find. For now I've resorted to rendering a fallback view behind my SVG, which shows through only when the SVG fails.
Are you also using wix navigation by any chance?

Yep also using React native navigation

Interesting. Could be a coincidence, I've just suspected it might be related because navigation transitions seem to cause the svgs to disappear/reappear sometimes, whereas I haven't noticed that with any other re-renderings.

As noted in #526, it appears it is not isolated to iOS, Android is having a similar issue. The common item across all of these occurrences so far is react-native-navigation. Can you all post the versions you're using? I want to try and narrow down the search.

Thanks for investigating, although the OP in https://github.com/react-native-community/react-native-svg/issues/526 may actually be using react-navigation rather than react-native-navigation?
I was using:
react-native-svg 5.4.1
react-native 0.49.3
react-native-navigation 1.1.273
I've recently updated to RNSVG 6.0.0 and RN 0.50.1 - haven't seen the issue yet but it's too early to say.

react-native: 0.47.2
react-native-navigation: ^1.1.235
react-native-svg: ^5.4.1

I just updated to
react-native-navigation: 1.1.295
react-native-svg: 6.0.0
and the issue is still there

So it appears the common point is<EMAIL_ADDRESS>so far

And iOS11, there’s no indication so far that #526 is using React native navigation

I found a workaround, my app reliably didn’t render any SVGs after pushing a screen anymore, which made it unusable.
I‘m now simply triggering a rerender of the SVG path, after it loaded by setting a new color value in a 0 timeout in componentDidMount.

https://github.com/react-native-community/react-native-svg/commit/ca9855b1cd3b711d046a05caa5608695a031b1f6 looks promising as a fix. I'll be trying it out over the next few weeks

Been quite a while and I'm seeing this with my paths.  I am also using react-native-navigation now at ^2.18.2.  Specifically I'm using react-native-svg-charts and have implemented muti line charts.  It only seems to affect those.  You can see the PR file in question here: https://github.com/JesperLekland/react-native-svg-charts/pull/240/files
Specifically /src/chart/chart-grouped.js

This doesn't seem to happen for me anymore. But much in my setup has changed.
• iOS 12.1
• react-native: 0.55.4
• react-navigation: 2.2.5
• react-native-svg: 6.2.1

Closing this until a reproduction is provided.


receive_message_chain does not work with expect_any_instance_of

This code causes RSpec to fail internally:
klass = Class.new

expect_any_instance_of(klass).to receive_message_chain(:a, :b).with 2

Here's the stack trace:
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/stub_chain.rb:40:in `verify_invocation_order'
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/chain.rb:103:in `record'
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/chain.rb:28:in `block in record'
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/proxy.rb:110:in `block in method_missing'
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/proxy.rb:110:in `map'
rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/proxy.rb:110:in `method_missing'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/expectation_customization.rb:15:in `playback_onto'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/receive.rb:99:in `block in setup_method_substitute'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/receive.rb:98:in `each'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/receive.rb:98:in `setup_method_substitute'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/receive.rb:89:in `setup_any_instance_method_substitute'
rspec-mocks-3.4.0/lib/rspec/mocks/matchers/receive.rb:53:in `setup_any_instance_allowance'
rspec-mocks-3.4.0/lib/rspec/mocks/targets.rb:45:in `define_matcher'
rspec-mocks-3.4.0/lib/rspec/mocks/targets.rb:14:in `block in delegate_to'

And a pry session showing the internal state at the time:
From: /rspec-mocks-3.4.0/lib/rspec/mocks/any_instance/stub_chain.rb @ line 43 RSpec::Mocks::AnyInstance::StubChain#verify_invocation_order:

    39: def verify_invocation_order(rspec_method_name, *_args, &_block)
    40:   return if invocation_order[rspec_method_name].include?(last_message)
    41:   raise NoMethodError, "Undefined method #{rspec_method_name}"
    42: rescue => e
 => 43:   binding.pry
    44: end

[1] pry> e
=> #<NoMethodError: undefined method `include?' for nil:NilClass>
[2] pry> invocation_order
=> {:and_return=>[nil], :and_raise=>[nil], :and_yield=>[nil]}
[3] pry> rspec_method_name
=> :with
[4] pry> last_message
=> nil

Thanks for the report, closing in favour of #1061

Thanks for creating a PR for this. I wasn't really sure where to start :smile_cat:


⚠ Bofrost.be has degraded performance

In eaf72a3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 917 ms

Resolved: Bofrost.be performance has improved in 631a10d.


Perform larger scale run with -vv output

Do larger scale run with -vv output to verify everything works correctly.
Previous related issues: #1151, #1138

I ran this on all samples in tests/data and tests/data/dotnet and did not encounter more rendering issues.


google-cloud-datastore Entity.isUnindexedProperty API

In com.google.appengine.api.datastore.Entity we had an API to get whether an entity is indexed by callling com.google.appengine.api.datastore.Entity.isUnindexedProperty(String propertyName) during the read time.
Is there an API in google-cloud-datastore that provides the same capability during the read?

@mihania  - The below should work.
boolean unindexed = entity.getValue("myProperty").excludeFromIndexes();

thank you, @sai-pullabhotla! That's exactly what I needed.


fix(Button): added state for btn and removed some types

:tada: This PR is included in version 7.35.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue when timing code with a call to global

I tried fastero after listening to the April 28 2022 episode of Python Bytes.
In installed
fastero 0.2.4
python 3.10.4
windows 10.
I wanted to time two functions one that used global and one that didn't.
I made a file - "using_global.py"
R = 8.314

def calling_global():
    global R
    R*10

calling_global()

and a file - "not_using_global.py"
R=8.314

def not_calling_global():
    R*10

not_calling_global()

then at the command line ran:
python -m fastero "file: not_using_global.py" "file: using_global.py"

I received an error
────────────────────────────────────────────────── Benchmark started… ──────────────────────────────────────────────────
Benchmark 1: R = 8.314

def not_calling_global():
    R * 10

not_calling_global()
  Time  (mean ± σ):       196.1 ns ±   5.2 ns
  Range (min  … max):     190.9 ns … 204.9 ns    [runs: 14,000,000]
Benchmark 2: R = 8.314

def calling_global():
    global R
    R * 10

calling_global()
Traceback (most recent call last):
  File "C:\Users\XXX\Anaconda3\envs\eos\lib\site-packages\fastero\core.py", line 475, in app
    num_in_one_batch, time_taken = _autorange(timer, autorange_callback)
  File "C:\Users\rlarson\Anaconda3\envs\eos\lib\site-packages\fastero\core.py", line 461, in _autorange
    time_taken = timer.timeit(number)
  File "C:\Users\XXX\Anaconda3\envs\eos\lib\timeit.py", line 178, in timeit
    timing = self.inner(it, self.timer)
  File "<timeit-src>", line 14, in inner
    calling_global()
  File "<timeit-src>", line 11, in calling_global
    R * 10
NameError: name 'R' is not defined

if I run the file "using_global.py" with python I do not get the error related to this file.
python using_global.py

So after some debugging, I figured out that this is a problem with the python timeit library. If you try the following code:
import timeit

stmt = '''\
R = 8.314

def calling_global():
    global R
    R*10

calling_global()'''

timeit.timeit(stmt)

Then it would also raise the same error. But the following code does work:
import timeit

R = 8.314

def calling_global():
    global R
    R*10

timeit.timeit(calling_global)

So from this I can say for certain that the issue is with passing a string with code for a function to timeit, but passing the function itself works like expected. I wonder what can I do to fix this 🤔

In the timeit module near the bottom of the page they have something about using a setup keyword
def test():
    """Stupid test function"""
    L = [i for i in range(100)]

if __name__ == '__main__':
    import timeit
    print(timeit.timeit("test()", setup="from __main__ import test"))

I was about to make the example work with strings if I used this to import the function through timeit.

you can use setup with fastero too using the --setup / -s


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Bicep
Module Classification?
Pattern Module
Module Name
avm-ptn-openai-e2e-zt
Module Details
This pattern will assist with adding additional security guardrails to the OpenAI end-to-end baseline article from the Azure Architecture Center cited here: Baseline OpenAI end-to-end chat reference architecture. In this update, the reference architecture and implementation via bicep will be executed in a zero trust manner by adding an Azure Firewall for additional inspection, rules to the NSGs and other network security constructs.
This pattern will be providing a quick start mechanism for customers wanting to use Azure Open AI in a best practice manner and by incorporating the use of AVM modules to the overall solution. Below is a list of resources that would be part of the planned module:

Azure Firewall
NSGs
Virtual Network
Route tables
IP Groups
Public IP

Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
amillerb
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

@amillerb, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

@amillerb can you confirm that this ptn module will also create the the Azure OpenAI service as well as per the baseline architecutre?

Hi @jtracey93  - This pattern will include the components from the baseline reference implementation bicep (https://github.com/Azure-Samples/openai-end-to-end-baseline) and the addition of a firewall to the e2e architecture.

Hi @amillerb,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @amillerb,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@amillerb, I just pinged you internally regarding the inactivity on this module's development. Please let me know how you're planning to proceed. Thanks!

Hi @matebarabas - ran into some delays with this module. Re-shifted focus to a related article,
the app baseline, which shares many of the same components, except for Open AI.
Planning on completion by the end of this year.

Working Branch: https://github.com/amillerb/bicep-registry-modules/tree/aoai-avm

@amillerb, this is great news; thanks for sharing! Once you'll have a PR (even if it's draft), please provide a link to it as well! Thank you!

This is just fyi, in case someone is looking to contribute or support to create the https://learn.microsoft.com/en-us/azure/architecture/ai-ml/architecture/baseline-openai-e2e-chat as a patter module by converting https://github.com/Azure-Samples/openai-end-to-end-baseline into a pattern module. I'm currently developing, testing and validating portions of it since I understood @amillerb shifted focus from the baseline reference to https://github.com/Azure-Samples/app-service-baseline-implementation which does not include AOAI.


More stable communication

nugus_controller provides us with a way to communicate between NUbots and Webots without having to use the RoboCup official controller where GameController and AutoReferee can get in the way of testing systems.
However, the communication code on the NUWebots side is unstable. We would like it to be stable so we can reliably use it.
This is noticed while running scripttuner with the nugus_controller. Most of the time it crashes in the first 10 seconds. Occasionally, it will run nicely and not crash. Ideally it runs nicely and doesn't crash, otherwise it makes it very hard to test things and tune scripts.

Works fine now with the robocup player controller code.


Advantage over slice or Vec?

Is there any advantage this crate provides over slice or Vec other than the guarantees?

Yeah, it's the guarantee in type system. Nothing more.
In fact, it is just a wrapper around inner &[T] or Vec<T>.

Ah, I thought there is sort of performance benefit.

Maybe, some fallible methods like first, split_first non infallible. But it should be unnoticeable.


Bypass auth prompt when no credentials stored

Task/Issue URL: https://app.asana.com/0/488551667048375/1203320214644536/f
Description
Allows access to the AutofillManagementActivity without authenticating when there are no saved logins. So the decision tree on what happens when you access that activity is now:
flowchart LR
    start(Launch activity) --> deviceAuth{Has valid device auth}
   deviceAuth-- No ---showDisabled(((Disabled state)))
   deviceAuth-- Yes ---hasLogins{>= 1 logins}
   hasLogins-- No ---showPlaceholder(((Placeholder state, no auth)))
   hasLogins-- Yes ---gracePeriod{In auth grace period}
   gracePeriod-- Yes ---showLogins(((Show logins)))
   gracePeriod-- No ---authenticate
   authenticate{Authentication challenge}
   authenticate-- Success ---showLogins
   authenticate-- Failure/cancel ---exitActivity(((Exit activity)))

Steps to test this PR
Device auth disabled

[ ] Set device auth to disabled by removing all PIN/Password/Fingerprint protection
[ ] Access the cred management activity
[ ] Verify you see the disabled state

No logins stored

[ ] Enable device auth
[ ] Enter creds management activity
[ ] Verify you are not prompted to authenticate
[ ] Verify you can see the toggle to enable/disable
[ ] Verify you see the empty state placeholder

Logins stored

[ ] Store a login credential
[ ] Enter creds management activity
[ ] Verify you are prompted to authenticate
[ ] Cancel; verify you are exited from the activity
[ ] Re-enter, and authenticate
[ ] Verify you can see the credential list

Grace period

[ ] Re-enter the creds management screen within 15s of last successful authentication
[ ] Verify you are not prompted to authenticate
[ ] Verify you can see the credential list
[ ] Wait > 15s and re-enter; verify you are now prompted to authenticate again

Current dependencies on/for this PR:

develop

PR #2608   👈

This comment was auto-generated by Graphite.

cc @THISISDINOSAUR in case the diagram is useful to compare against your thinking on how it should flow


Fix bulk requests

Pull Request Test Coverage Report for Build 2118

0 of 0   changed or added relevant lines in 0 files are covered.
218 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.08%) to 70.443%

Files with Coverage Reduction
New Missed Lines
%

dist/routes/v2/util.js
1
82.69%

dist/routes/v2/rawtransactions.js
11
82.16%

dist/routes/v2/blockchain.js
24
75.58%

dist/routes/v2/slp.js
182
50.63%

Totals

Change from base Build 2080:
-0.08%

Covered Lines:
2054

Relevant Lines:
2720

💛  - Coveralls


native: android fixes, logout, & view build number

Bit of a hodgepodge.
Biggest piece is fixing a few Android bugs. Namely the new create/join sheets crashing due to an issue with Tamagui Sheet's "modal" property and one where the empty channel message was showing up rotated.
Also adds the ability to log out and display hidden dev info by clicking the Profile  page avatar 5 times rapidly
Fixes TLON-1935

Still saving a bit of authentication state, moving to DNM.

Updated this to fix the logout not sticking & removed the dev debug popup since that's pulled in/updated on the activity branch.
This was already reviewed, so think I'm just gonna merge it.


Coverage reporting fails with parallel code

pytest-cov seems to have issues, migrate to directly using coverage

@MarcelRosier can this be closed?


Mongoose Traveller 1e, GunCombat Fix

Replaced/repaired Gun Combat
Change the name of the repeating field under melee weapons, removing conflict with ranged weapons.
Added value "0" to weapon damage

Thank you


Move highlight.js from peerDependencies into dependencies

It seems more understandable to be in dependencies rather than in peerDependencies (in package.json)
Thanks

I don't want to fix highlight.js to specific version in dependencies.
But maybe I'll change my decision about this. 😅

I've thought over your suggestion. I think I will keep peerDependencies as-is.
Reasons:

peerDependencies will let you freely pick a version of highlight.js that you want.
In OSS, some bugs will happen in some version of package that you use. If I add it into dependencies, it'll use the latest version that match dependencies. So, it'll be hard to rollback to working version.
You may use Yarn resolutions to pick specific version. But why you have to do many step to solve a temporary bug. And it isn't possible for npm user to use resolutions feature now.

The easy step is specifying the version that you want in your own package.json. It's better. 😊
@ColinTree What do you think?

That sounds reasonable, but is there a lowest requirement in dependencies' versions? You can then add it into package.json.
And another solution is to simplily add an notice about installing dependencies in README.md XD

Lowest version is included in peerDependencies ("highlight.js": "^9.11.0"). The package manager will warn you if it mismatch.
I'll add installation command like this in README.
npm install highlight.js vue-highlight.js


Introduce uv_dlopen_with_flags()

This is a new try at extending uv_dlopen to support UNIX dlopen flags. Previous try was rejected and closed: https://github.com/libuv/libuv/pull/635.
@saghul reasons for closing were:

Closing. Current behavior is in use in the wild and we cannot break it. Also, since this has no applicability on Windows, you could use the dl* functions directly, libuv doesn't do anything special about them anyway.

First objection is addressed by introducing a new function, uv_dlopen_with_flags. This is a no-op in Windows.
Now, about the Windows behavior objection. Introducing a uv_dlopen_with_flags function makes portable programs (such as node.js) result in much cleaner code. In other words, we would like to simply call uv_dlopen_with_flags without any ugly platform specific ifdef'ery.
See https://github.com/ezequielgarcia/node/commit/3820c96802ea7133d933d4185eecfebfed7c3253 for an example on how this function would be used.
It's important to mention that uv_dlopen implementation is maintained, keeping backwards compatibility.

I'm still -1. IF you need Unix only support you can use dlopen(3) directly. Node already ships with a bunch of native methods, this one could live there too.

I must admit I don't really see the point either.  It doesn't add anything over dlopen() since you have to pass in platform-specific flags anyway.  Why not call dlopen() directly in that case?

Fair enough. However, it does seem a little short sight to provide support for dlopen and then force a given flag such as RTLD_LAZY. A quick google search shows that these flags are rather fundamental and many common uses of dlopen mandate using them.

@saghul @bnoordhuis While working on implementing this in Node exclusively, I came across tihs: https://github.com/dlfcn-win32/dlfcn-win32/blob/master/dlfcn.c. It shows a way to give meaning to RTLD_GLOBAL in Windows.

This appears to have moved to nodejs/node, so I'll close here.


Core.Links is not a Odata V2 Spec?

Dear community,
when using the plugin for the purpose of serving a OData V2 Service for MDK we get a sync issue saying:
Failed to initialize application data service - Error: :23
Annotation Error: Undefined term
'Org.OData.Core.V1.Links'.
<Annotation Term="Core.Links">...

The assumption is as this exists as well 1:1 in the V4 metadata, this is just overtaken. A short research indicates Core.Links is maybe only vaild in SAP OData V4.
If someone in the cummunity can give me a hint, if my assumptions are correct and maybe point me to the right place to fix it, I could work on a PR :)

After deep dive debugging I found that in<EMAIL_ADDRESS>the Core.Links annotation is injected by CDS itself in<EMAIL_ADDRESS>Line 280.
Still it could be supressed by adding
odataNoCreator: true
In line 1138 of<EMAIL_ADDRESS>Of course if the issue is that Core.Links is no valid Odata V2 it should be fixed in the CDS.

Thanks for reporting this issue. If Core Links are not valid for OData V2, then I think this should be generally fixed in CDS compiler. I will call internally to the colleagues and update here afterwards...

See line 267, you can disable watermarking with option odataNoCreator set to true

See line 267 and 280, you can disable watermarking with option odataNoCreator set to true

Yes that's true, but I can I do this from my CAP implementation? I only see the possiblilty in how I suggested here https://github.com/cap-js-community/odata-v2-adapter/pull/69

there should be a cdscrc.json file where you can add  { cds: { cdsc: { odataNoCreator: true } } } or similar, please look it up in capire, I am not very good in config. However, I am going to add a xmlns attribute to the watermark. It's allowed to set "unkown" annotations as foreign markup in any API...


Update workflows

launch a job if the first one is finished

Difficulty in adding launch conditions.
latex.yaml must be launched for each push. But must wait for the end of docker.yaml if it is running.


Fix commonly misrecognized kana, always provide ten-ten/small kana in swap quick action

Requesting:

kana always be given their ゛・゜options
〈 and < either being given the option for く, or else always being corrected to く with the option to switch back
somehow fixing the problem with リ and こ being split into two characters (especially in the case of vertical writing?) like a comma and a pipe or something

Other common errors that aren't problematic:

し is interpreted as L, but at least you can correct it to し

Other issues will be reported here

Similar looking:
き・さ
Smart replace:
い・ぃ

I can't say whether all the problems have been fixed yet, but the app just got so much easier to use with the latest update! Thank you!


Push failed. Errors:

Expected Behavior
Upload my changes, or provide useful error.
Actual Behavior
Fails to upload providing "empty" error.
Jeffs-MacBook-700:temp jeffharris$ clasp push
Push failed. Errors:
Jeffs-MacBook-700:temp jeffharris$ clasp status
The following files will be pushed by clasp push:
└─ Constants.js
└─ Utils.js
└─ appsscript.json
└─ new-bogus-file.js
Untracked files:

Steps to Reproduce the Problem

mkdir test && cd test
clasp clone <scriptId>
touch new-bogus-file.js
echo $(date) > new-bogus-file.js
clasp push

Specifications

Node version (node -v): v8.9.0
Version (clasp -v): 1.4.0
OS (Mac/Linux/Windows): Darwin Jeffs-MacBook-700.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64

I thought I had the latest version installed, but I found 1.5 in the releases section.
Updated and now I can push just fine, so I'll just close this.... after 5 minutes. 👍

Glad updating worked!


Add proper PVSCSI controller/disks create() automation

Fixes #38
The testing are done manually with simple scripts which create docker volume/run docker
container with given volume/destroy docker volume.
Before this fix, since it can only allocate 1 PVSCSI controller, the maximum number of disks which can attach to the VM is 15.
In the test, we create 15 volumes nameed "testvol0" ... "testvol15", and try to create docker container with those 15 volumes. Attaching volume "testvol0"... "testvol14" succeeded, but attaching "testvol15" failed since no available disk slot left.
...
08/05/16 14:36:47 34727 [photon] [INFO   ] Attaching /vmfs/volumes/datastore1/dockvols/testvol15.vmdk as independent_persistent
08/05/16 14:36:47 34727 [photon] [ERROR  ] Failed to place new disk - out of disk slots VM=564dcc0a-3711-142c-961f-cdd59ba48e63
08/05/16 14:36:47 34727 [photon] [INFO   ] executeRequest 'attach' completed with ret={u'Error': 'Failed to place new disk - out of disk slots'}
08/05/16 14:36:47 34727 [photon] [INFO   ] *** detachVMDK: /vmfs/volumes/datastore1/dockvols/testvol15.vmdk from photon VM uuid = 564dcc0a-3711-142c-961f-cdd59ba48e63
08/05/16 14:36:47 34727 [photon] [WARNING] *** Detach failed: disk=/vmfs/volumes/datastore1/dockvols/testvol15.vmdk not found. VM=564dcc0a-3711-142c-961f-cdd59ba48e63

With this fix, more than one PVSCSI controller can be created if needed. When try to search
an available disk slot, it will try to search all the existing PVSCSI controllers instead of just the
first one.

Configuration:
Before attaching any disk, we have 1 PVSCSI controller with controller_id = 1001, and we also have a LSI controller

Step 1: attach 15 disks ("t1" ... "t15")
Step2: attach another 15 disks ("t16 ... "t30")
A new PVSCSI controller with controller_id=1002 is created
...
08/06/16 17:17:49 84969 [photon1] [INFO   ] Add a new pvscsi controller, id=1002
08/06/16 17:17:49 84969 [photon1] [DEBUG  ] idx for newly added pvscsi controller is 0
08/06/16 17:17:50 84969 [photon1] [DEBUG  ] Set status=attached disk=/vmfs/volumes/datastore1/dockvols/t16.vmdk VM name=photon1 uuid=564d89a6-e012-61b4-6175-a7f1ddc3c6b9
08/06/16 17:17:50 84969 [photon1] [INFO   ] Disk /vmfs/volumes/datastore1/dockvols/t16.vmdk successfully attached. controller pci_slot_number=160, disk_slot=0
08/06/16 17:17:50 84969 [photon1] [INFO   ] executeRequest 'attach' completed with ret={'ControllerPciSlotNumber': '160', 'Unit': '0'}

Step 3: attach another 15 disks  ("t31" .. "t45")
A new PVSCSI controller is created with controller_id = 1003
....
08/06/16 17:22:04 84969 [photon1] [DEBUG  ] idx=0 controller_key=1001 availSlots=0
08/06/16 17:22:04 84969 [photon1] [DEBUG  ] idx=1 controller_key=1002 availSlots=0
08/06/16 17:22:05 84969 [photon1] [INFO   ] Add a new pvscsi controller, id=1003
08/06/16 17:22:05 84969 [photon1] [DEBUG  ] idx for newly added pvscsi controller is 0
08/06/16 17:22:05 84969 [photon1] [DEBUG  ] Set status=attached disk=/vmfs/volumes/datastore1/dockvols/t31.vmdk VM name=photon1 uuid=564d89a6-e012-61b4-6175-a7f1ddc3c6b9
08/06/16 17:22:05 84969 [photon1] [INFO   ] Disk /vmfs/volumes/datastore1/dockvols/t31.vmdk successfully attached. controller pci_slot_number=256, disk_slot=0
08/06/16 17:22:05 84969 [photon1] [INFO   ] executeRequest 'attach' completed with ret={'ControllerPciSlotNumber': '256', 'Unit': '0'}
...

Step4:
There is no slot left to add another PVSCSI controller, and no disk slot available in any existing PVSCSI controller
Try to add another disk, and it failed as expected
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] lib.vmci_get_one_op returns 4, buffer '{"cmd":"attach","details":{"Name":"t46"}}'
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] get_datastore_name: path=57473702-8b550986-70c0-000c290799f4 name=['datastore1']
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] Found /vmfs/volumes/datastore1/dockvols, returning
08/06/16 17:23:22 84969 [photon1] [INFO   ] *** attachVMDK: /vmfs/volumes/datastore1/dockvols/t46.vmdk to photon1 VM uuid = 564d89a6-e012-61b4-6175-a7f1ddc3c6b9
08/06/16 17:23:22 84969 [photon1] [INFO   ] Attaching /vmfs/volumes/datastore1/dockvols/t46.vmdk as independent_persistent
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] findDeviceByPath: Looking for device /vmfs/volumes/datastore1/dockvols/t46.vmdk
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] idx=0 controller_key=1001 availSlots=0
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] idx=1 controller_key=1002 availSlots=0
08/06/16 17:23:22 84969 [photon1] [DEBUG  ] idx=2 controller_key=1003 availSlots=0
08/06/16 17:23:22 84969 [photon1] [ERROR  ] Failed to place new disk - out of disk slots VM=564d89a6-e012-61b4-6175-a7f1ddc3c6b9
08/06/16 17:23:22 84969 [photon1] [INFO   ] executeRequest 'attach' completed with ret={u'Error': 'Failed to place new disk - out of disk slots'}

Right now,  the test are done manually with simple scripts, I will file another issue which will
track the effort to automate this test.

Refactor the code, address comments from Govindan.
Repush the change.

Changes look good. But, please re-run the tests to add the max disk count and beyond. Plus as discussed last week, could raise a separate issue, where, when no disks are attached to a controller then remove the pvscsi controller from the VM config.

Hi Govindan,
Thanks for the review. I have re-run the test after refactoring the code.
I am not sure do we need file a issue for "when no disks are attached to a controller then remove the pvscsi controller from the VM config?"
Why we should do that? Is there any specific reason for that? What do you think @msterin ?

I do not see a reason to remove controllers even if there are no devices attached.  Unless @govint provides a reason (resource consumption? something else ?) let's keep it as is.

Address the conflicts and repush the change.

Looks good.  a few minor comments - please take a look inline (need dostrings in new functions, need to rephrase error messages, and some cosmetic code changes are suggested)

Address comments from Mark and Prashant, repush the change.

LGTM

LGTM. 2 minor comments above.


Add code_deployment_healthy status check

Use Case
Sometimes my code seems to silently fail to deploy--especially in my development environment where I'm pretty ruthless with check-ins and squash-updates.
Describe the Solution You Would Like
I'd like a fact that checks the status of the last attempted code deploy--was it successful for all environments?
Describe Alternatives You've Considered
I'm not aware of any alternatives.  However, maybe this fact could be rolled into something more generic like the "health" of code deployment.  Not sure how reasonable it would be, but perhaps some of the checks described here https://puppet.com/docs/pe/2019.8/code_mgr_troubleshoot.html#troubleshooting_code_manager-monitor-webhook-deployment-trigger-issues could be rolled into this check...
Additional Context
Would be nice to see a warning when I do a puppet run on my primary--as I know the pe_status_check does already--if the code deployment is not healthy.  For example, I have automated code deploys so didn't notice the following error until doing it manually.  My puppet runs for the 'development' all seemed to work fine apart from the fact that I didn't see my new code check-ins.  The issue was pretty simple: I had a typo on one of my modules...

@gavindidrichsen its maybe not quite right for this but are you aware of https://github.com/puppetlabs/puppetlabs-peadm/blob/main/tasks/code_sync_status.rb ?

I've spoken with @gavindidrichsen and he's happy to close this one out


Add localization to Python Extension

Adding the ability to localize strings for the Python Extension
Design is based on the https://github.com/Microsoft/vscode-extension-samples/tree/master/i18n-sample
There's a new global location to put strings to be localized, src/utils/localize.ts.
This file is postprocessed after compiling to wire up translations found in i18n//out/src/utils/localize.i18n.json
New strings are added to both the "load" function in the localize.ts file and into the appropriate i18n json files.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] ~Has a news entry file (remember to thank yourself!)
[x] Unit tests & system/integration tests are added/updated
[x] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
[x] package-lock.json has been regenerated by running npm install (if dependencies have changed)

All good, @brettcannon @rchiodo
Will not merge this, as we're a day away from release.
Will merge tomorrow after the release.

Switching to doing loc ourselves so as not to require mucking with the final js output


Clue Scroll Leaderboards and ease of opening

🚀 Feature Proposal
Similar to how there are leaderboards for gp and kill counts I am suggesting a clue scroll leaderboard as well as being able to open multiple at a time. I have been saving up beginner and easy clue scrolls and i have roughly 800 of each at the moment in hopes that an update like this goes through. If I have to manually open each of them that is fine as long as there is a leaderboard to keep track of them.

half issue solved  #385 .


Update the game over message

Update the game over message so people know how to play again!

Not a bad looking PR, lgtm


Question: compiling and adding to project

I may want to add this to a project I am working on and have a question on this;
The readme says to compile the style sheets to use them. Does that mean that every user of the project need to compile the dark theme or when does this happen?
If the theme needs to be compiled every time, is there a trick to have this be done automagically on the first time the software runs?

you suuurely tried this before posting two issues about it........
once you have compiled a qrc into a .py file you just import it. This is documented by qt.

@marc-vdm You can distribute the compiled QRC files (as either a Python file, or by including it as a resource in a Qt5 app, which are portable. Once you've compiled the file (Python) or provided it as a resource, it will do it's magic every time.


[PyTorch] Remove pointer class

Channel for questions
Before or while filing an issue please feel free to join our Slack channel to get in touch with development team, ask questions, find out what's cooking and more!
Description
(Brief description of what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
[ ] Code is well-documented:

For user-facing API changes, Java doc has been updated.
For new examples, README.md is added to explain the what the example does.

[ ] To the my best knowledge, examples and jupyter notebooks are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, Java doc)
[ ] Feature2, tests, (and when applicable, Java doc)

Comments

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Why we decided to remove pointer?

@lanking520 we don't need lots of small Pointer class. The performance should be better if not equal to the original but reduce the GC workload

@frankfliu please take a look when you have time


[ENH] BEP031 - New entity: sample

Dear BIDS community,
Context
As part of the development of the Microscopy BEP (BEP031 @mariehbourget, @jcohenadad) and Animal Ephys BEP (BEP032 @SylvainTakerkart, @JuliaSprenger), the “sample” entity was introduced in order to distinguish different tissue samples from the same subject.
In brief, the scope of the BEP031 proposal is to extend the Brain Imaging Data Structure (BIDS) specification to 2D and 3D microscopy images of histological samples, both ex vivo and in vivo. In this context, we were advised to split the BEP into smaller separate PRs when possible.
Contribution
The purpose of this PR is to add a new “sample” entity.
The sample entity is described as:
A sample pertaining to a subject such as tissue, primary cell or cell-free sample.
The `sample-<label>` key/value pair is used to distinguish between different samples from the same subject.
The label MUST be unique per subject and is RECOMMENDED to be unique throughout the dataset.

See issue #779 for related discussions on this topic.

@mariehbourget - shouldn't this PR also describe a samples.tsv file providing additional details about a sample?

@mariehbourget - shouldn't this PR also describe a samples.tsv file providing additional details about a sample?

Hi @satra,
From previous discussions in the BEP031 meeting and with the maintainers, and from the comments in #779 (here, here and here), my understanding was that dealing with the sample entity and the samples.tsv file in different PRs was preferred. So the plan is to open 2 separate PRs: 1) sample entity 2) participants.tsv and samples.tsv.

they would likely have to be merged at the same time, so perhaps doing it together instead of linking would work better for review.  @bids-standard/maintainers thoughts?

they would likely have to be merged at the same time, so perhaps doing it together instead of linking would work better for review. @bids-standard/maintainers thoughts?

I suggest to add the samples.tsv file description in this PR, and open another PR for the additional recommended columns in the participants.tsv file.

Sounds good to me.

Hi everyone!
As discussed, this PR now includes the description of the new samples.tsv file.
A new PR #816 is also open for the addition of recommended/optional columns in participants.tsv.

@mariehbourget - this looks good. just a few clarification comments.

Couple of open questions that relate more to where those changes should go rather than about their content:
Currently those changes read to me like the sample entity will be made "available" for ALL modalities.

Describing it in the common principles puts it at the same level as the other entities that are described there and that are pretty much available to all modalities (subject, session, run). Though this is not the case for event so there is a precedent although it is a suffix not an entity.
Should we possibly only have the entity defined only the in the entity table? Or do we feel that sample is a concept important enough that it deserves to be defined in the common principle?
I think a good case can be made for the latter but I just want to make sure we are on the same page.

Similarly putting the description of the samples.tsv in the modality agnostic section feels strange. Sample will be used for microscopy  and ephys. Therefore samples.tsv is not like the scans.tsv or sessions.tsv (the latter is being transferred into the modality agnostic section in another PR).
So maybe it should go somewhere else?
What has been done so far is to duplicate, into their respective page, a description of the file: for example with the electrodes.tsv and channels.tsv files in EEG, MEG, iEEG (also because they might have slightly different requirements). See also my regular mentions of the details about the task entity being repeated across several pages. #IAmABrokenRecord
As a user or reader of the spec this is usually fine because this concentrates all the info about a modality in a single page. As maintainer I am not a big fan of duplication.
The other problem is that we don't even have a microscopy or ephys page so far to put this in.
I would not be against the creation of a new page where we can put information about things that are shared by some but not all modalities: this could definitely help with "refactoring".
That latter point would probably deserves its own issue and PR, so feel free to disregard this for this PR.

@Remi-Gau, thank you for the feedback about where those changes should go, those are important questions and I’m glad to discuss them here.

Should we possibly only have the entity defined only the in the entity table? Or do we feel that sample is a concept important enough that it deserves to be defined in the common principle?

The rationale for this was twofold:

It was discussed in (https://github.com/bids-standard/bids-specification/issues/779#issuecomment-822660725) and in meetings that sample could eventually be used by modalities other than microscopy/ephys. For example, sample could be scans from different body part of the same subject in anat MRI.
Moreover, sample is closely related to subject because it serves to identify “what” is scanned rather than “how” (e.g.: acq, task, ce). To preserve the BIDS subject definition, we added the sample entity. When sample is used, it is the combination of sub-id + sample-id that serves as the “unique identifier” for the specimen scanned.

On the other hand, since no modality is using the sample entity yet in the spec, we could add the entity in the appendix list, and postpone its integration to the common principles for when microscopy is merged.

Similarly putting the description of the samples.tsv in the modality agnostic section feels strange. Sample will be used for microscopy and ephys. Therefore samples.tsv is not like the scans.tsv or sessions.tsv

For the same reason as above, I put samples.tsv in the modality agnostic files section. Another particularity is that the samples.tsv file is global and sits at the root of the dataset (unlike channels.tsv or electrodes.tsv).
Finally, as you mentioned, without an official page for microscopy yet, that information has nowhere to go! I am not against creating a page for microscopy with only the sample description and samples.tsv file for now. That page could eventually become the official microscopy page and the samples info could be moved to the page “about things that are shared by some but not all modalities” you suggested.
So I’m open to make changes to facilitate the integration and maintenance of the specs but I'm not sure what is best, let me know your thoughts. Thanks!

For the same reason as above, I put samples.tsv in the modality agnostic files section. Another particularity is that the samples.tsv file is global and sits at the root of the dataset (unlike channels.tsv or electrodes.tsv).

+1 on listing the samples.tsv file in the modality-agnostic files section ; on top of @mariehbourget 's arguments, I think any future modality that can be recorded in animal models will probably use this file...

Thank you @effigies and @Remi-Gau for your feedback, I left a few suggestions and questions regarding the validation and BIDS-compliance, let me know what you think and I’ll make the appropriate changes to the PR. Thanks!

Hi @bids-standard/maintainers,
The doc build failed after my last change 2 weeks ago. I’m not sure why this error occurs, I can build the doc locally with mkdocs serve. I was wondering if there is a way that I can re-trigger the build of the doc or correct the error in the PR? Thanks!

yes, you can merge master into your branch, these issues have been fixed on there already. Or you can rebase your changes on top of master and force push.
Look at this screenshot:

you are 37 commits behind master, that should be removed so that you are even with master

@yarikoptic I initially (https://github.com/bids-standard/bids-specification/issues/779#issuecomment-823303226) preferred using a per-subject table or the for a global table that applied to all via the inheritance principle, but the BEP working group argued that a global table would need to be recomputed by every tool, so dropped the objection (https://github.com/bids-standard/bids-specification/issues/779#issuecomment-825777533).

Thank you everyone for the reviews!
I’ll tag @SylvainTakerkart and @lazaral here if they want to take a look at the latest changes.
Also, this is our first PR for BEP031, are there other things we have to do before the merge? Thanks!

This looks great to me, and very much in line with the discussions of the BEP031 working group. Thank you @mariehbourget and all the BIDS maintainers who helped with it. Exciting to see the first PR from BEP031 is about to come to life!

@mariehbourget @jcohenadad @SylvainTakerkart @JuliaSprenger @satra @Remi-Gau @sappelhoff is there any overlap with https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/08-genetic-descriptor.html
SampleOrigin: Describes from which tissue the genetic information was extracted
TissueOrigin: Describes the type of tissue analyzed for SampleOrigin value 'brain'
BrainLocation: Refers to the location in space of the TissueOrigin
CellType: Describes the type of cell analyzed

is there any overlap with https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/08-genetic-descriptor.html

Hi @CPernet,
I double-checked the genetic descriptor part of the spec and I don’t see any overlaps.
If I understand correctly, the genetic information in genetic_info.json applies to all participants, whereas the sample-<label> entity from this PR is meant to distinguish between different samples from the same participant.
For example, a participant sub-01 could have 2 tissue samples extracted (sample-01 and sample-02). Each sample would be imaged by a microscope and the sample-<label> is used in the filename of those images, ex: sub-01_sample-01_TEM.png, sub-01_sample-02_TEM.png.
The samples.tsv file is meant to list all the different samples present in the dataset with their attributes. In particular, the column sample_type which describe the type of sample (ex: tissue, primary cell, cell-free sample). This is similar to the CellType field in genetic_info.json but does not directly overlap as it is an attribute of the samples that are imaged and not the cells used for genetic analysis.
There are no suggested columns in samples.tsv similar to SampleOrigin, TissueOrigin or BrainLocation from genetic_info.json. In the Microscopy BEP, we use the metadata fields BodyPart and BodyPartDetails to describe the tissue location (PET also uses BodyPart). However, those fields will be included in the JSON sidecar files associated to the image files (for each sample of each participant).
Please let me know if that answer your question or if your have any other concerns.

ok cool - I just wanted to make sure the names and possibly ontologies to pick information from are in agreement (and by that I mean we can amend genetic if that's easier, re cell type for instance) - thx

Definitely a good thing to keep genetics concepts in mind as we add microscopy and electrophysiology. Thanks for the nudge, @CPernet!

i think the sample stuff can be pulled over into the genetic side too, or the columns of samples.tsv augmented with some of the keys. spatial proteomics and transcriptomics across tissues/samples from humans and others are going to share a bunch of things.


Windows File Version History support

Is Windows File Version History supported?
By this I'm referring to, the built-in feature in Windows 10. https://msdn.microsoft.com/en-us/library/hh829789(v=vs.85).aspx
And what other types of file versions are accepted for this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 041ce12b-b77a-9b46-66ad-4b9fda465122
Version Independent ID: 20a73f2f-a66f-e5af-8ced-6fa70e2e5e3f
Content: Migration Assessment Scan File Versions
Content Source: SharePoint/SharePointServer/migrate-to-sharepoint-online/migration-assessment-scan-file-versions.md
Service: unspecified
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Also, I have some SAMBA shares that support Shadow Copy or VSS, will those versions be migrated in the SPMT aswell?
Thanks,

This particular scan article is referring to versions in the source SHAREPOINT environment.
This assessment scan does not look at file versions in Windows/File Shares.


Update vafComapre.R

Relates to #854

Take a look at this @PoisonAlien ?

Thank you @ShixiangWang for the fix.

@PoisonAlien You're welcome. The issue related to this PR could also be closed now.


Block blacklisted people receiving gp from /pay

Adds a blacklist check to the /pay command.
Informs the sender that they can't send gp to someone blacklisted, similar to how it works for /trade

[x] I have tested all my changes thoroughly.

Could you change the error text to say, 'cannot receive money' to be consistent with the other failure modes?