Attach on musl libc doesn't always work

top crashes just after the attach:
start an alpine container; docker run --privileged --rm -it alpine
install curl; apk add curl
install scope; curl -O https://cdn.cribl.io/dl/scope/0.7.1-rc1/linux/scope && chmod u+x scope
extract scope; ./scope extract .
start a long-running process top
create another shell into the same container docker ps, docker exec -it <container id> /bin/sh
observe with ./scope ps that there are not currently scoped processes
attach to top ./scope attach top

And I've seen us have trouble getting event data out of processes we've attached to:
I can install python3 apk add python3 and start a webserver with it python3 -m http.server .
When I attach ./scope attach python3 it doesn’t crash, and ./scope ps looks good, and I the webserver still works when I hit it with curl, but I’m not getting any event data out.  ./scope events (edited)

These are related to the original work to start supporting attach on musl (#362).

support for attach to musl ibc processes is not supported 0.7.1.

The issue with attach on musl libc starts with ELF file patching.
In order to support a single executable and library for GNU libc and musl libc we build on a GNU libc distro and then update the entry in the .INTERP section of ldscopedyn and the NEEDED list in libscope to replace ld-linux.so with ld-musl.so and write the changes back to the file system. This removes the need for setting the LD_LIBRARY_PATH env var and makes things seamless for users on musl libc based distros.
This approach is fragile in that it isn't done "right". We use the string length of the source to write the new ld-musl.so string in both cases. This only works if the pathname of ld-linux.so is <= to the path for ld-musl.so. This is the case on x86_64 distros. It is not the case on aarch64 distros. Therefore, we need to create new sections, allocate the space required, copy existing data and not break the ELF definition.
Note that ELF patching is not expected to be needed if we build separate instances for GNU libc and musl libc. We do not build separate at this point in order to support the current requirements for k8s support. When we are able to extend how we scope processes in k8s pods such that we can determine which exec is needed we expect that we can build separate and stop ELF patching.

Found that an update applied to libyaml early on causes config file parsing to fail on attach in musl libc. In order to not report file activity from libyaml out of libscope we used dlsym(RTLD_NEXT) to find the address of fread() and fwrite(). This works with GNU ld.so. However, musl ld.so is far more strict and the RLD_NEXT param of course doesn't work as libscope is the last object loaded.
Replaced the use of dlsym() with g_fn.fread() and g_fn.fwrite() and that allows config file parsing to work using the dlsym() logic in fn.c.

Data emitted to files after an attach is not being flushed as expected.
Connecting to LS cloud results in data being send as expected after attach.
We are flushing after file writes in doEvent().  Need to investigate.

The dl_iterate_phdr() callback function used in initFn() respects the hierarchy of objects as seen in the GNU ld.so loader by starting symbol resolution after a specific library in sequence. We don't expect it to work with musl ld.so and therefore, a subsequent dlsym(RTLD_NEXT) resolves symbols as needed with musl ld.so.
That works well when musl ld.so loads libscope.so on an execve(). The use of RTLD_NEXT does not resolve symbols when dlopen() is used with attach on musl libc.
Gotta love the strict adherence used by the musl loader. The behavior is not wrong, it's just strict.
Need to determine the proper approach on attach using musl ld.so.

The issue with python3 in a musl libc based distro (alpine) is very similar to, if not the same as, what we are seeing with attach to a java process.  The functions we want to GOT hook are in a shared library. With preload we handle this because we interpose dlopen and GOT hook at that time. Therefore, the functions we want to interpose from a shared lib are interposed during load time. In the attach case the libs are already loaded. Therefore, we need to iterate through all the shared objects and GOT hook as needed. Have not tested the java case.
Was able to get network and http events from a python 3 process in a musl instance using attach. Added a step during attach hooking to iterate all shared libs and GOT hook the functions we want to interpose. No testing has been done at this point. Peer reviewing the approach.
We are missing console I/O after attach in the musl/python3/attach case. Not sure how to approach that situation.

When I repeated the test at the top of this ticket, I got the same result...  well, first I got this message:
/ # ./scope attach top
error: use of --attach in musl libc isn't currently supported
error: set SCOPE_ALLOW_MUSL_ATTACH=true to attempt anyway

So, I responded in the shell by running export SCOPE_ALLOW_MUSL_ATTACH=true, then ran ./scope attach top again.  The top process crashed shortly afterwards.
Mem: 30398284K used, 2488232K free, 956K shrd, 859984K buff, 21923164K cached
CPU:   0% usr   0% sys   0% nic  99% idle   0% io   0% irq   0% sirq
Segmentation fault (core dumped)
/ #

Here's the version I used.  I built it myself on ubuntu 18.04.5 LTS system, is that part of my problem, somehow?
/ # ./scope version
Version: v0.7.5-5-g4e691db3
Build Date: 2021-10-05T19:19:00Z


Return errors from TSA verification if there are no valid timestamps

Summary

Release Note

Documentation

as the test expects that there is no returned error even if there are no valid timestamps (as the count of timestamps is used to test against the threshold, which may be zero). Should we update that test? Or is there a valid reason to expect that behavior?

Thinking out loud, should VerifyTimestampAuthority error if there are no entity.Timestamps() to verify?
On the one hand, I'm inclined to say "yes". It feels dangerous to be have a function named "Verify" that can return successfully when it has not actually verified anything. This got us in trouble in gh at verify recently, where we returned successfully when supplied with an empty list of attestations.
On the other hand, as currently implemented there is some ambiguity around how VerifyObserverTimestamps calls this function; as currently implemented, returning a zero-len array is expected behaviour. However I'm not a huge fan of how VerifyObserverTimestamps ended up & would be willing to endorse a polite refactor - do we remember why the TlogInclusion is verified independently of this function?


RC Spot-Check Test: Greenhouse Effect 1.1.0-rc.3

Prototype Test
Mentions: @arouinfar, @kathy-phet, @@Nancy-Salpepi
Simulation links

github repository for issues
phet top level directory
sim: all_phet.html

Test Matricies

[X] Tester = NS, Platform = mac + safari , Time = .5

Features included

[ ] Alternative Input
[ ] UI Sound
[ ] Sonification

Focus and Special Instructions
A decision has been made to publish what was previously the prototype of Greenhouse Effect as a production version.  In
the process of doing this, a minor issue was discovered, so a spot check RC is warranted.  There is one issue to
verify, and the code changes for it only affected the "Waves" screen, so this should be the focus of the spot check.

Issues to Verify

[x] https://github.com/phetsims/greenhouse-effect/issues/269

For QA...

General features

What to Test

Play with the simulation normally.
Make sure you can't lose anything.
Complete the test matrix.
Try to include version numbers for browsers
If there is a console available, check for errors and include them in the Problem Description.
Focus on pedagogy issues and bugs that break the sim.
If you find bugs beyond pedagogy/breaking, still document these bugs as github issues.
If a11y aspects are present, test them, but with an eye for "normal use".

Accessibility features

What to Test
If a11y aspects are present, test them, but with an eye for "normal use".

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

@jbphet I checked the Waves Screen and opened one issue. I also noticed the artifacts in the waves, but that is a known issue. Back to you.

Thanks, I'll take it from here.  Closing.


Fix enums definitions

This fixes issue #13 for me on Visual Studio 2015. Tried to stick to your naming conventions.

ERROR and FALSE are defined as 0 on Windows and therefore caused the errors in Visual Studio for State::ERROR and StaleMode::FALSE definitions.


lable issue for proposal and feature

Add github action to lable issues as proposal/feature, just the way bugs label automatically gets added

please assignme thhis issue

Go ahead
Deadline 1 May,2021


6.3.0: Remove REVVMotorsportShardClaim contract and recompile

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@4eeb4de). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #17   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?        16
  Lines           ?       147
  Branches        ?         4
========================================
  Hits            ?       147
  Misses          ?         0
  Partials        ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Please write entry in CHANGELOG


Add a cmake-preset for openwrt

Creates a CMakeToolchain file that automatically downloads the OpenWRT 19.07.10 mvebu/cortexa9 SDK, and uses that for cross-compilation.

Is this the best way of doing this??

If we don't need any OpenWRT specific libs, we might be able to get away with just using sudo apt install gcc-arm-linux-gnueabihf instead of downloading a giant SDK

Additionally, I've added a cmake-preset for it, and it seems to work just with the following, but I haven't tested it yet:
cmake --preset openwrt
cmake --build --preset openwrt # builds in ./build/openwrt

I haven't bothered running tests yet, but if you're interested in using this on your computer, @mereacre, you can try and see if the changes actually work.
I haven't yet tested whether the built edgesec binary actually runs on OpenWRT!! Especially since the SDK is from vanilla OpenWRT; it might not work on Turris's fork!!.
Currently untested, please don't merge this unless this has been tested on a real OpenWRT device.

OpenWRT does not use glibc.  Are we building with glibc?
At present 90% of Turris has been upstreamed to OpenWRT, so they share most of the fundamental pieces, but Turris has a different package manager and image build process.  This matters if one wants to get things packaged into the image, for instance because one wants to generate an identity on first boot.

OpenWRT does not use glibc. Are we building with glibc?

Not for the OpenWRT build using the CMakeModules/CMakeToolchains/openwrt-mvebu-cortexa9.cmake file I just added.
That uses muslgnueabi, which is what comes with the OpenWRT SDK for mvebu/cortexa9 19.07.10
https://github.com/nqminds/EDGESec/blob/222ddfa3bfec9931122084ab98eb03fbfb4222aa/CMakeModules/CMakeToolchains/openwrt-mvebu-cortexa9.cmake#L28-L30
After having a look at https://gitlab.nic.cz/turris/os/build, I'm pretty sure this should work with Turris OS on the Turris Omnia, but I'll need to test it on Monday to confirm.
The glibc check in #125 was only active when compiling locally for testing (i.e. on Ubuntu). But I'm about to remove it since it seems redundant.

At present 90% of Turris has been upstreamed to OpenWRT, so they share most of the fundamental pieces, but Turris has a different package manager and image build process. This matters if one wants to get things packaged into the image, for instance because one wants to generate an identity on first boot.

:+1: The way we're compiling right now is a bit hacky, we're compiling and statically linking libubox/libuci from the latest master. Ideally we should use the OpenWRT/Turris OS packaging system, so that we can instead use dynamic linking on the versions of libubox/libuci actually on OpenWRT 19.07.x.

I would prefer a docker container for cross compiling and other staff

100%. Docker is useful since you still need to sudo apt install a bunch of dependencies. CMake still recommends putting cross-compiling settings into their own toolchain file, even if we use a Docker container.

Can we remove/comment for now the mvebu/cortexa9 SDK part?

In commit https://github.com/nqminds/EDGESec/pull/127/commits/f67dd7f1baa8ae35e4b5887353f6a9af2be4e939, I've changed the cmake-preset so it's now called openwrt/mvebu/cortexa9, and I've added the old config as just openwrt (where the cross-compiler is installed under /usr/local)
So:

cmake --preset openwrt is the same behaviour as the old mkdir build && cd build && cmake .. && make, where it uses /usr/local/bin/arm-linux-musleabihf-*, and has an error if it's not installed.
cmake --preset openwrt/mvebu/cortexa9 is the one that downloads the OpenWRT SDK automatically

If you let me know where you got your /usr/local/bin/arm-linux-musleabihf-* toolchain from, I can test it locally and make a Dockerfile.

I made a container for the toolchain here: https://github.com/nqminds/EDGESec/tree/main/deployment/containers

Hey @mereacre:
I compiled the openwrt/mvebu/cortexa9 code, and then copied over the edgesec and capsrv executables to the Turris Omnia OpenWRT router:
scp build/openwrt/mvebu/cortexa9/config.ini build/openwrt/mvebu/cortexa9/src/edgesec build/openwrt/mvebu/cortexa9/src/capsrv turris:/tmp/edgesec_openwrt-cmake-prefix-6ff921c62

Then I ran the new edgesec code compiled with the OpenWRT SDK, but using the old config.ini, and it outputs the same results as the edgesec_v0.9.9_alpha5_arm32 exe, so it looks like it works!
root@turris:/tmp/edgesec_openwrt-cmake-prefix-6ff921c62# ./edgesec -c ../edgesec_v0.9.9_alpha5_arm32/config.ini  -s 12345 -dddddddd
[...]
2022-05-03 11:30:44.598  ERROR[ENOTCONN(107)] domain.c:208: [Socket not connected] sendto
2022-05-03 11:30:44.599  TRACE supervisor.c:347: SET_IP fail
2022-05-03 11:30:45.118  TRACE supervisor.c:336: Supervisor received 59 bytes from socket length=0
2022-05-03 11:30:45.118  TRACE cmd_processor.c:336: Received DHCP request with type=arp
2022-05-03 11:30:45.118  TRACE cmd_processor.c:344: Wrong type
2022-05-03 11:30:45.118  TRACE domain.c:205: Sending to socket on

I've also updated the deployment/containers/README.md instructions to use the new openwrt/default preset.
All I had to do to get it working is change the Dockerfile to use ubuntu:22.04, since that has a newer version of CMake.


Idiomatic HashToField

Is construct_dst_prime from ExpanderXof anywhere in the spec?  If not, then maybe we should remove it?  Anyways..
I'd think ExpanderXof should become a free pub fn like
fn update_dst_prime<H, const K: u16>(h &mut H, dst: &[u8])
where H: ExtendableOutput+Default+Sized,
{
    if self.dst.len() > MAX_DST_LENGTH {
        let mut long = H::default();
        long.update(&LONG_DST_PREFIX.clone());
        long.update(&self.dst);
        let mut dst = [0u8; MAX_DST_LENGTH];
        long.finalize_xof_into(dst);
        h.update( dst[0..(2 * K + 7) >> 3] );
    } else {
        h.update(dst);
    };
    // I2OSP(len,1) https://www.rfc-editor.org/rfc/rfc8017.txt
    h.update(dst.len() as u8);
}

pub fn expand_xof<H>(domain: &[u8], message: &[u8]) -> Result<<H as ExtendableOutput>::Reader, &'static str>
where H: ExtendableOutput+Default+Sized
{
    if message.len() > u16::MAX as usize {
        return Err("expand_message_xof cannot handle messages longer than 2^16 bytes.");
    }
    let len = message.len() as u16;
    let mut h = H:default();

    h.update(message)
    /// I2OSP(len,2) https://www.rfc-editor.org/rfc/rfc8017.txt
    h.update(len.to_be_bytes())
    update_dst_prime(&mut h,domain);
    h.finalize_xof()
}

We could seemingly  impl<H: Digest+Clone> XofReader for ExpanderXmd<H> too.  I think KeyInit cannot work here, so we'd provide some free fn like
pub fn expand_xmd<H: Digest+Clone>(domain: &[u8], message: &[u8]) -> ExpanderXmd<H> { ... }

It's possible the rust crypto project would upstream this somehow even.
At this point, XoFs have become our common currency, so our HashToField trait also becomes a free fn like
pub fn hash_to_field<F: Field,H: XofReader>(h: &mut H) -> F { .. }

As field hashers are specified for each curve, individual curves might specify them via
pub trait HashToCurve: CurveGroup {
    pub fn hash_to_curve(domain: &[u8], message: &[u8]) -> Self { ... }
}

Assuming #629 this looks like:
impl HashToCurve for Projective<Config> {
    pub fn hash_to_curve(domain: &[u8], message: &[u8]) -> Self {
        ark_ec::hashing::xof_to_curve( ark_ec::hashing::expand_xmd::<sha2::sha256>(domain, message) )
    }
}

where
// Produce a hash of the message, using the hash to field and map to curve
// traits. This uses the IETF hash to curve's specification for Random
// oracle encoding (hash_to_curve) defined by combining these components.
// See https://tools.ietf.org/html/draft-irtf-cfrg-hash-to-curve-09#section-3
pub fn xof_to_curve<C: MapToCurve,H:XofReader>(h: &mut H) -> C {
    // IETF spec of hash_to_curve, from hash_to_field and map_to_curve
    // sub-components
    // 1. u = hash_to_field(msg, 2)
    // 2. Q0 = map_to_curve(u[0])
    // 3. Q1 = map_to_curve(u[1])
    // 4. R = Q0 + Q1              # Point addition
    // 5. P = clear_cofactor(R)
    // 6. return P
    let rand_curve_elem_0 = C::map_to_curve(hash_to_field(h));
    let rand_curve_elem_1 = C::map_to_curve(hash_to_field(h));

    // TODO: Avoid the extra affine conversion before clearing the cofactor.
    Ok( (rand_curve_elem_0 + rand_curve_elem_1).into().mul_by_cofactor_to_group() )
}

I've slightly wrong here, the IRTF draft cannot be described using XofReader because they hash the output length.  We can however still simplify the code along similar lines, but using our own XoF-like trait.

I've slightly wrong here, the IRTF draft cannot be described using XofReader because they hash the output length.  We might still simplify the code along similar lines, using our own XoF-like trait, but not really sure.

I think XofReader works anyways, but then under the hood you're taking the same field as input in two places, only a minor wart in the higher level interface.

It's mostly done in https://github.com/w3f/arkworks-algebra/tree/xof_reader but we should still clean up the map_to_curve mess ala https://github.com/arkworks-rs/algebra/issues/629


Is the file/stream size known on CreateFile?

Hi, is the file/stream size/length known at the time CreateFile is entered?  If so where can this property be accessed, specifically for FileMode.Create, OpenOrCreate, etc?

@jchristn Hi!
We cannot know at the time of CreateFile this inform unfortunately.

Got it, thank you.  Do most/all applications reliably close the file?  Trying to figure out how/when I can go back to the object and measure its length to store in my own metadata layer.  Thanks!

@jchristn You could keep if write happened on the handle / file and get the length on the file in close. Be aware that write can happen after close (windows feature) so maybe write should store the file length only if the write was outside the original length :D

Semantically should I consider the file length to be zero on CreateFile, and then update after each WriteFile if offset + buffer.Length > previous size?

@jchristn If it is a new file or truncated yes, otherwise if already existing file, will need to get the current length.

ok thank you!


Error trying to combine "include" or "contain" with "one"

should any of these be valid?
[].should.include.one.item.with.property("isOrganizer", true);
[].should.contain.one.item.with.property("isOrganizer", true);
I receive this error:
Error: cannot use something without include or contains

This should be valid, yes.


ImageNet  COCO , ImageNet DET , ImageNet VID, and YouTube-BoundingBoxes Dataset

resnet50.model is trained from only ImageNet ?
siamrpn_r50_l234_dwxcorr/model.pth is trained from ImageNet  COCO , ImageNet DET , ImageNet VID, and YouTube-BoundingBoxes Dataset ?

yes.

when do you offer the baidu pan of YouTube-BoundingBoxes Dataset?
thanks
@ lb1100

when do you offer the baidu pan of YouTube-BoundingBoxes Dataset?
thanks
@lb1100


Installation issue

Hello Support,
please see the current issue during installation.
OS: Amazon Linux AMI release 2017.03
./build/composer.phar install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
[jcontreras@ip-172-30-0-84 taskboard]$ ./build/build-all
Building...
Installing dependencies
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
Compiling lib JS files...
Minifying lib CSS files...
Compiling app JS files...
controllers/settingsBoardForm.js:241: ERROR - Parse error. IE8 (and below) will parse trailing commas in array and object literals incorrectly. If you are targeting newer versions of JS, set the appropriate language_in option.
preferredFormat: 'hex3',
^
1 error(s), 0 warning(s)
It's kinda urgent for me. please assist me.
Thanks and regards
Kaustuva

Web browser version ?

hello @rautamiekka
thank you for your response. I am installing in command line mode where i have encountered this error. May i need to install it in any command line web browser in my linux server? please let me know
Thanks
Kaustuva

^ I hope not. Could be I misunderstood something, too.

It looks like the compilation is failing because of a comma at the end of this line: https://github.com/kiswa/TaskBoard/blob/master/js/controllers/settingsBoardForm.js#L241
Edit that file and remove the comma and the build should work

Closing due to lack of response. Comment if this still needs assistance.


Revert "Node 18+ Update"

Reverts AlaskaAirlines/auro-icon#72

:tada: This PR is included in version 3.4.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove develop domains from float-tutorial.md

The develop subdomain is only used internally for testing/development so any references should be removed in order to avoid confusion for users.

@peterjjohnson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jeevansd Changes look good, could you please approve the PR

#sign-off

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: peterjjohnson sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @peterjjohnson - Would you take a moment to sign the Microsoft Contributor License Agreement (CLA)? Then we can merge your update. Thanks.

There's a known issue in which an accurate CLA status isn't revealed until/unless additional commits are added to a PR. See https://ceapex.visualstudio.com/Engineering/_workitems/edit/168950

Thanks @ktoliver - I've signed the CLA, do I also need to make an additional commit before it can be merged?

Thanks @peterjjohnson No, my commit triggered the CLA status. That's a note for repo admins, etc. Thanks--merging the PR now.


Running for new season

There are a few issues right now when running for the 2019-2020 NBA season. I am trying to comb through and fix as many as possible.

Hi DigitalTechnicality,
Are you using the Master branch? If so, I would not use your time fixing those issues. As designed, the database tables are not in any kind of normal form (along with some other issues). However, if you'd like to help, please take a look at the reorganization branch where I'm working on normalizing the databases. That branch will become master in the coming weeks, and will be far more resilient. Let me know if that helps, or if I can help in another way.


app-init.md fixes

I'm following the tutorial and I noticed that the app-init.md part was missing some imports. Also the name Cosmos is spelled wrong. I added the missing imports so anyone that follows the tutorial will not have issues.

This has been fixed in the most recent merge with the updated version of the tutorial


Unexpanded user agent string

In the BaseClient::user_agent_ member, I can see MinIO (windows; x86_64) minio-cpp/MINIO_CPP_MAJOR_VERSION.MINIO_CPP_MINOR_VERSION.MINIO_CPP_PATCH_VERSION content, which looks wrong. I'd expect the MINIO_CPP_MAJOR_VERSION, etc., to be replaced with their numeric values.

Regression since #121


Nimble throughput example NimBLE: exp_time:0.now:12755.ticks:3939.active:1.Need reset. error (IDFGH-7004)

What does this error even mean? I can't find anything about this error on the internet. I'm using IDF from the master branch and I'm constantly facing issues with NimBLE stack (I'm prototyping hence the master branch).
Issue is in the blecent_throughput example

Hi @listout ,
The print should be under debug tag rather than error tag, as it is just a condition to call timer reset. Also, it is just a information print and ideally should not cause any issue. Can you elaborate the issue because of this message you are observing ?
Thanks,
Rahul

Hi @rahult-github I was just testing out the examples from the master branch and haven't changed anything so I don't actually know why is this under the Error tag. From the central project when I try to write (throughput write 100) I get the following log
Throughput demo >> throughput write 100
I (68013) Throughput demo handler: throughput write 100
E (68503) blecent_throughput:  Read failed, callback error code = 13
I (68503) NimBLE: GAP procedure initiated: terminate connection; conn_handle=0 hci_reason=19

I (68503) NimBLE: GATT procedure initiated: read;
I (68513) NimBLE: att_handle=17

E (68523) blecent_throughput:  Read failed, callback error code = 7
I (68523) NimBLE: GATT procedure initiated: read;
I (68523) blecent_throughput: disconnect; reason=534
I (68523) NimBLE: att_handle=17

                                                                                I (68543) blecent_throughput:

E (68543) blecent_throughput: Error: Failed to read characteristic; rc=7
I (68553) NimBLE: GAP procedure initiated: discovery;
I (68563) NimBLE: own_addr_type=0 filter_policy=0 passive=1 limited=0 filter_duplicates=1
I (68563) NimBLE: duration=forever
I (68573) NimBLE:

I (68643) blecent_throughput: Event DISC
I (68643) blecent_throughput: connect; fields.num_uuids128 =0
I (68643) blecent_throughput: Device Name = nimble_prph

E (68653) blecent_throughput: Error while reading from GATTS; rc = 7
I (68653) blecent_throughput: central connect to `nimble_prph` success
I (68673) NimBLE: GAP procedure initiated: connect;
I (68673) NimBLE: peer_addr_type=0 peer_addr=
I (68683) NimBLE: 58:bf:25:32:e3:1a
I (68683) NimBLE:  scan_itvl=16 scan_window=16 itvl_min=24 itvl_max=40 latency=0 supervision_timeout=256 min_ce_len=0 max_ce_len=0 own_addr_type=0
I (68693) NimBLE:

I (68743) blecent_throughput: Connection established
E (68753) blecent_throughput: Failed to set preferred MTU; rc = 3
I (68753) NimBLE: GATT procedure initiated: exchange mtu

E (68763) blecent_throughput: Failed to update params; rc = 3
I (68773) NimBLE: GATT procedure initiated: discover all services

Throughput demo >> I (68873) blecent_throughput: mtu update event; conn_handle = 0 cid = 4 mtu = 512
I (68963) NimBLE: GATT procedure initiated: discover all characteristics;
I (68973) NimBLE: start_handle=1 end_handle=5

I (69163) NimBLE: GATT procedure initiated: discover all characteristics;
I (69173) NimBLE: start_handle=6 end_handle=9

I (69363) NimBLE: GATT procedure initiated: discover all characteristics;
I (69373) NimBLE: start_handle=10 end_handle=65535

I (69563) NimBLE: GATT procedure initiated: discover all descriptors;
I (69573) NimBLE: chr_val_handle=8 end_handle=9

I (69663) NimBLE: GATT procedure initiated: discover all descriptors;
I (69673) NimBLE: chr_val_handle=14 end_handle=15

I (69763) NimBLE: GATT procedure initiated: discover all descriptors;
I (69773) NimBLE: chr_val_handle=17 end_handle=65535

I (69863) blecent_throughput: Service discovery complete; status=0 conn_handle=0

I (73873) blecent_throughput: Format for throughput demo:: throughput read 100
 ==================================================================
 |                 Steps to test nimble throughput                |
 |                                                                |
 |  1. Enter throughput [--Type] [--Test time]                    |
 |  Type: read/write/notify.                                      |
 |  Test time: Enter value in seconds.                            |
 |                                                                |
 |  e.g. throughput read 600                                      |
 |                                                                |
 |  ** Enter 'throughput read 60' for reading char for 60 seconds |
 |  OR 'throughput write 60' for writing to char for 60 seconds   |
 |  OR 'throughput notify 60' for notifications (for 60 seconds)**|
 |                                                                |
 =================================================================

I (77653) blecent_throughput: Format for throughput demo:: throughput read 100

Also the command throughput read 100 does nothing, I mean like the read of the sketch shows and there is almost no update (on the terminal) on the central app. The only update are of connect, disconnect and connection update (again not matching with the readme of the peripheral example)


var name docu mismatch alertmanager_binaries_local_dir

The README calls the variable alertmanager_binaries_local_dir but it is actually called
alertmanager_binary_local_dir.
This causes playbook fails, when people use the name from the README.

Proper name should be alertmanager_binaries_local_dir as alertmanager tarball contains amtool and alertmanager binaries and both are required by this role.
Could you create PR?


pull request for e2e test at 01/12/2017 06:26:14

:x: Validation status: errors
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Mono] GetFilename returns a zero-length string

Godot version: 3.0.2 and Build from master on 5971088
OS/device including version:

3.0.2: Windows 10, Mono 5.4
5971088: Windows 7, Mono 5.4

Issue description:
Discovered this when writing documentation.
The method GetFilename() always returns a zero-length string when called on a C# Node.

Closing this issue as requested by OP.


Author Address

Closes https://github.com/trustlines-protocol/blockchain/issues/532
It doesn't work right now. I get the error "Unkown argument: --author" from parity. I'm not sure what's wrong: I checked that the environment variables are configured properly and from there on I just do the same for "author" as is already done for "validator". "author" is the right name according to the documentation and the changelog doesn't mention it, so it shouldn't have been renamed.
Could this the same issue you encountered, @berndbohmeier ?

same error, yes. fix has been merged to master in c7b11cc.

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #543   +/-   ##
=====================================
  Coverage      76%    76%
=====================================
  Files          18     18
  Lines         925    925
=====================================
  Hits          703    703
  Misses        222    222

Flag
Coverage Δ

#bridge_end2end
0% <ø> (ø)
:arrow_up:

#bridge_unit
76% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ab0bf...24d8030. Read the comment docs.

The error persists even after rebasing, so it seems to be a separate issue. Investigating...

This seems to work now, but requires both the blockchain image to be rebuilt (as the wrapper script was updated).

So, by default we burn the block rewards on the zero address?

No, by default it goes to the validator address (https://github.com/trustlines-protocol/blockchain/pull/543/files#diff-9aa8e06f1aece82472dc89a029529a57R161). The zero address is only used for non-validators so that the parity wrapper has a valid argument to parse.

Working on it


Added vSphere support

What is this change about?
Added support for vSphere backend
Please provide contextual information.
n/a
Please check all that apply for this PR:

[ ] introduces a new task
[X] changes an existing task
[ ] changes the Dockerfile
[ ] introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

[ ] YES
[X] N/A

How should this change be described in release notes?
Added support for vSphere backend
What is the level of urgency for publishing this change?

[ ] Urgent - unblocks current or future work
[X] Slightly Less than Urgent

Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@axelaris Hi Alexey - thanks for the PR!
Could you give us an idea of what level of testing you have done for this? We don't currently have infrastructure for testing this PR, so we are interested in what you have done to ensure operation.

Hi @Birdrock,
thank you for looking into my PR.
Currently I'm actively using my fork to deploy CF to our internal vSphere infra.
Do you need any details/logs to prove that?

Thanks @axelaris. After some team discussion we've decided that we're comfortable with merging this without validating it in our own pipelines. Especially after hearing that you've tested it yourself.


Link to Colab for each demo/example

Add an "Open in Colab" button for each demo in the demo gallery.
Need to add colab_run and colab_show (and perhaps cell delimiters?) so it works on Colab.

You can't open .py files from Colab which makes this a non-trivial amount of work to support (we would need to generate ipynb from the py files)


Selected item for simulation is not displayed in policy simulation page

Version:
master.20170813013530_81d444b
Steps:
1.Navigate to Compute->infrastructure->Virtual machines and select any vm or template.
2.From configuration click on policy->policy simulation
Observation:
Selected item is not displayed in policy simulation page. No records found displayed.see attached screenshot

@akarol please open an [UPSTREAM] BZ for this if not done already.


Move "Bulk tag by upload" into "Bulk Tag"

Trello: https://trello.com/c/XZGZNtHb/213-content-tagger-updates-to-page-titles-and-labelling
We belive this functionality should move into the Bulk Tag tab.
Although having it directly within the page would make it confusing when
you search for content to be tagged and also see the list that comes
from the uploaded content. That's why I've created a "button" to point
to the "Bulk tag by upload"
Also the reason to make it a button is that it stands out in the eye of
the user instead of a link, which looks tiny and reads weird next to
"Bulk tag history".

Should https://github.com/alphagov/content-tagger/pull/210/commits/931e30627a8c00062ebe2afad65ebf4ff8bcd123 be in a separate PR?

@tijmenb Indeed, I've move it here https://github.com/alphagov/content-tagger/pull/211

@Davidslv this is ok to merge, please rebase it first

Thanks @carvil, just rebased


Move hero after breadcrumbs and add space for breadcrumbs in story pages

Currently, we don't use heroes anywhere that breadcrumbs exist. However, story-pages can indeed be added as subpages of verticals and get associated breadcrumbs. This can lead to funky layouts, eg:

This swaps the location of the breadcrumbs and hero and adds some spacing to make this look reasonable:

So, let me make sure I have this right. We currently have two story pages total:

https://www.consumerfinance.gov/about-us/small-business-lending/
https://www.consumerfinance.gov/about-us/racial-equity/

The TDP page is its own non-wagtail thing

https://www.consumerfinance.gov/consumer-tools/educator-tools/youth-financial-education/journey/

You're looking at moving this page into Wagtail as a new Story page? Is that right?
So, if I look at the pages around that. Here is the parent page:

And here is one of the siblings:

And here is the page in question:

Not only does the breadcrumb chain differ on that page, it doesn't appear in the secondary nav along with its siblings.
I would say remove the breadcrumbs entirely from the Story pages template. Is this an option?

@anselmbradford The current journey page is hardcoded into its own template. It may be that we remove this page entirely (since it seems pretty duplicative) but I was rebuilding it in Wagtail as a POC and the page type that best matched (imo) was a story page. It's certainly possible to remove breadcrumbs from story pages instead, if we think they shouldn't include them.

@wpears oh hi again, just barging in a second time to say that the breadcrumb shouldn't be used on the story page template, as it's not a recommended practice to add breadcrumbs on page templates with heroes...so I'd agree with @anselmbradford.

👋 That makes sense to me: Continuing not to include a breadcrumb on story (and sublanding) page types. So if this TDP page comes into a story page template, it wouldn't have a breadcrumb.

Thanks for chiming in folks! Breadcrumbs have been removed in a07fb67fac93f5fccc6ab20924c2cb8379f47db4 and I updated the OP


Use a config file instead of env vars

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: carlossg
If they are not already assigned, you can assign the PR to them by writing /assign @carlossg in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-29 here

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-29 here

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: carlossg-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [carlossg-bot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create more open sell orders on testnet

Right now, are only 5 estates open sell orders.

4 left now (I bought one while checking if my old account was disabled or not)

Script is running right now

Script is running right now

Great. Feel free to close this once you're satisfied with the result. Hopefully there won't be any weird behavior resulting from duplicates.

We have 50 estates now.


Add comments and likes counters

I Created counters for likes and comments.
This is from Postman:
[
{
"id": 1,
"name": "Vespa Model X",
"created_at": "2023-06-21T19:18:05.078Z",
"updated_at": "2023-06-21T19:18:05.078Z",
"icon": "vespa_x.png",
"description": "This is the Vespa Model X.",
"cost_per_day": 50.0,
"comments_count": 1
}
]
[
{
"id": 1,
"user_id": 1,
"vespa_id": 1,
"content": "This is a reservation for Vespa Model X.",
"created_at": "2023-06-21T19:30:50.825Z",
"updated_at": "2023-06-21T19:30:50.825Z",
"likes_count": 1
}
]

THX


Remember instances for annotated entities too

This solves issues: #215 and #243 as well as #185.
Basically I'm using a Map with weak keys to keep track of the row ID for a given object instance. In the past the id field was used for the entities that extend SugarRecord, but that's not possible for annotated entities.

I'm going to take a look at this tomorrow. This is a pretty big bug that should be fixed!

The fix is pretty straightforward. The only thing is that I had to add the Guava dependency to create the concurrent map with weak keys to avoid a memory leak.
Let me know if I can be of any help.

I'm close to merging this in, but it's failing an important case:
Model model = new Model("Test");
long id = SugarRecord.save(model);
Model query = SugarRecord.findById(Model.class, 1);
assertEquals(id, new Long(query));

The expectation is that the queried model retains the id from the original, but Java sees model and query as different objects. One was created by the user, the other was inflated by Sugar.

@jivimberg do you have any ideia of how to remove guava dependency?
Another problem is that MapMaker is deprecated (https://github.com/google/guava/wiki/MapMakerMigration)
is there no way to fix this issue without using a Map?

It seams that the MapMaker call can be replaced by a CacheBuilder which still has the option of specifying weakKeys

@jivimberg the problem with CacheBuilder is that it has guava dependency that make the size of this lib bigger, can we just add part of guava ?

Oh! I see. I guess we could easily take a look at the CacheBuilder implementation. The key thing here is to have weak reference for the keys in the map so we don't run into a memory leak


HellaSwag with UnicodeDecodeError

When I was trying to evaluate HellaSwag using:
lm_eval --model hf      --model_args pretrained=HuggingFaceH4/zephyr-7b-beta,dtype="bfloat16"      --tasks hellaswag      --device cuda:0      --num_fewshot 10      --batch_size auto      --trust_remote_code
I met the error:
File "/root/miniconda3/envs/lm_eval/lib/python3.10/site-packages/datasets/load.py", line 2587, in load_dataset
builder_instance = load_dataset_builder(
File "/root/miniconda3/envs/lm_eval/lib/python3.10/site-packages/datasets/load.py", line 2259, in load_dataset_builder
dataset_module = dataset_module_factory(
File "/root/miniconda3/envs/lm_eval/lib/python3.10/site-packages/datasets/load.py", line 1910, in dataset_module_factory
raise e1 from None
File "/root/miniconda3/envs/lm_eval/lib/python3.10/site-packages/datasets/load.py", line 1862, in dataset_module_factory
can_load_config_from_parquet_export = "DEFAULT_CONFIG_NAME" not in f.read()
File "/root/miniconda3/envs/lm_eval/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb5 in position 1: invalid start byte
How can I solve this error?

same problem

encounter the same issue in local environment

same issue

same issue

same issue

Cannot initially seem to replicate on a fresh HF cache... perhaps did something wrong though?

Cannot initially seem to replicate on a fresh HF cache... perhaps did something wrong though? Is the connection to the HF Hub working for those facing this problem?

It seems not this reason, the connection is well on my machine.

same problem

same with drop

已解决，可以参考这个https://github.com/padeoe/hf-mirror-site/issues/22

Waiting for solution...

same problem, someone solved it?

download dataset from hf to local,then modify yaml files will success

A workaround is to downgrade datasets to 2.14.6.
For more details, please refer to this issue: https://github.com/huggingface/datasets/issues/6760#issuecomment-2041390144 .


how can we make pdf with included image

i am unable to make pdf with image

I'm sorry, but this is for reporting issues not for support questions. Please study the README first, make sure you've configured the binary path and that it's executable. If you think, something is broken, please provide a example that shows the issue. But I can not help with configuration issues.


Add second data source

Description
Assign yourself if you wish to work on this.
Check in with @IT2901-SINTEF01/frontend and hear what kind of visualisation they are interested in. Choose one based on feedback and points mentioned in previous issue with data sources – #15.
Subtasks

[x] Choose data source (comment why that one)
[x] Create POCO and GraphQL types
[ ] Mock
[ ] Test

Related sources

Entertainment while you're writing POCOs

I suggest we use SSB's population statistics. The three topmost give population data for the whole country, municipalities and counties, as well as data regarding the ages of the result set.
Some questions:

Are the frontend guys on board with this, or do you suggest another data source? (@IT2901-SINTEF01/frontend)
Would historical data be more benefitial, so that we could test out different graph types?
Is there any way in the frontend to map the county/municipality names to places on a map?

A similar alternative if historical data is interesting: Befolkning. Kommuner, pr. 1.1., 1986 - siste år
. Also in the JSON-stat structure.
(If you wan't to see how the data for each municipality looks like it's a bit easier to read the CSV format rather than the JSON-stat)

Interesting, what do you think, @IT2901-SINTEF01/frontend.
Regarding

(If you wan't to see how the data for each municipality looks like it's a bit easier to read the CSV format rather than the JSON-stat)

You may also open CSV files with Excel (or Numbers on Mac, Google Sheets on web) to explore the files.

I'll start with mocking and testing. Will you take the GraphQL side of things @FredrikAugust?

Aye aye, captain @Kpaubert!
@IT2901-SINTEF01/backend can I get a "heee-yaaaa"?
Great work as always

He-ya

what does this mean, @blauks?

How's the mocking going, Cpt. @Kpaubert?

Continuing soon, hopefully finished by the end of the day.


Recovering wallet created by Android Bitcoin Wallet fails

Hello,
I'm not sure this is really a bug on the lnwallet side, but figured it was probably worth reporting nonetheless, even if just to help future people who may run into the same situation.
Using the BIP32 mnemonic phrase from [Android Bitcoin Wallet](https://github.com/bitcoin-wallet/bitcoin-wallet/] to restore a wallet in Lightning Wallet leads to the following:

mnemonic phrase is accepted
lnwallet starts syncing
lnwallet finishes syncing and shows no funds available, and no error message

My understanding currently is that is probably due to the fact Android Bitcoin Wallet is "BIP32 non 44 Compatible" to quote WalletsRecovery.org (that or the alternative is that my wallet is really empty, oops).
Maybe lnwallet could throw some sort of error, if it can in fact detect that the wallet is not being properly imported?

Just to be complete, I've checked that the mnemonic I ienterred is correct, and it is.

Both wallets use BIP32 so I guess it has something to do with derivation path, BLW uses m/84’/0’/0’.

Maybe lnwallet could throw some sort of error, if it can in fact detect that the wallet is not being properly imported?

This can't be detected, from wallet's point of view any valid mnemonic is usable.


[Build] remove dependency to leveldb

Change database to sqlite, remove dependency to leveldb.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #263. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


net: context: move send_cb from net_context to net_pkt

Each net_context_send*() call accepts send_cb and user_data as
parameters. Those parameters were saved in net_context structure during
each send request. There were two problems related to such behavior:

'user_data' is shared for connect_cb and recv_cb, which means that
it got overwritten during each net_context_send*() call. This means
that net_context API consumer needed (in most cases) to always pass
user_data that was previously used for net_context_recv(), even when
send_cb was NULL.
'send_cb' together with 'user_data' got overwritten during each
net_context_send*() call, so there was no way of keeping track which
packet was actually sent and which was not.

Move send_cb and user_data to net_pkt structure, so no undesirable
overwriting happens. This allows to keep track of each data portion that
is requested to be sent with net_context_send*() APIs. Additionally
user_data is no longer shared with the one passed to net_context_recv(),
which means that the same pointer doesn't have to be passed during each
subsequent net_context_send() call.
Simplify and cleanup code assuming previous behavior.

It is not clear what use case this PR would help to solve, could you elaborate this a bit more.

'user_data' is shared for connect_cb and recv_cb, which means that it got overwritten during each net_context_send*() call.

You probably meant send_cb here instead of connect_cb. If this is a big problem, we could add second user_data pointer to net_context struct if needed. We have been trying to avoid adding more stuff to net_pkt because it uses more RAM.

@mniestroj: Echoing concerns from previous comments: net_context was effectively deemed to be internal implementation layer of network stack, sockets were deemed to be the public API. So, why do you need to use it in the first place, and how would you relate to the fact that if some other party also using it, you would be breaking them now?
Beyond that, there's a bunch of "unbeautifulness" in the underlying netstack implementation, but why patch it randomly? E.g. you patch net_context_send, but there's also net_context_recv with about the same issues. Is it worth it? Is risk worth it? I don't see anything with starting with test: included in the commits...

This goes against the network stack architecture.
I don't see the problem with passing user_data on each send calls. It was meant to be like that.

@tbursztyka Then what is the purpose of passing user_data and send_cb at all? Unfortunately it is not clear for me. After going through networking code for the last few days the only use case for send_cb + user_data would be to keeping track whether sending network packet was successful and at which point in time has that happened. See also below example with net_context_send() consumer code.

It is not clear what use case this PR would help to solve, could you elaborate this a bit more.

@jukkar Sure. I was trying to improve ESP WiFi (NET_OFFLOAD) driver, because there are currently race conditions that need to be solved to further improve its reliability. Looking at the .send() and .sendto() implementations I have noticed that it might be good idea to simplify "packet send" code path and always use workqueue for actually sending (offloading) packet to ESP WiFi chip, regardless timeout passed as function parameter. Next issue was socket->tx_pkt, which should be somehow protected from two threads trying to access it simultaneously. Those things can be easily fixed by using net_pkt->work, as implemented  here.
The problem that I encountered was that each .send() and .sendto() calls could have different send_cb and user_data parameters values. If that is true, then we need to add each send_cb+user_data pair to net_pkt, so we call the right ones when packet is actually being sent. Looking at the net_context and net_offload APIs, there was nothing being said that they are always the same during each call. I haven't even found a purpose of those. There is no clear way how to treat them, when should callback be executed, etc. Some drivers ignore send_cb (they do not call it at all), TCP stack executes callback whenever new packet is scheduled (not actually sent) and net_if layer calls net_context->cb with net_context->user_data whenever a packet is sent over interface. In summary: pretty inconsistent behaviour and no clear way what is the purpose of send_cb.
Most code that actually makes some use of send_cb suggest that this callback should be executed whenever a network packet is being sent over network interface. So changes in this PR were supposed to improve handling of send_cb, making sure that the same send_cb+user_data is used that was passed to net_context_send*() APIs. I might misunderstood intention of send_cb, in which case this PR might be invalid.

You probably meant send_cb here instead of connect_cb. If this is a big problem, we could add second user_data pointer to net_context struct if needed. We have been trying to avoid adding more stuff to net_pkt because it uses more RAM.

@jukkar Well, user_data is shared across all 3 callbacks. I should probably rephrase that somehow.

Echoing concerns from previous comments: net_context was effectively deemed to be internal implementation layer of network stack, sockets were deemed to be the public API. So, why do you need to use it in the first place, and how would you relate to the fact that if some other party also using it, you would be breaking them now?

@pfalcon I try to understand (and possibly improve) net_context from network drivers point of view. As I have written above, I started from WiFi ESP driver and ended up at strange (to me) behavior of send_cb handling at net_context layer.
I understand your concern about breaking API compatibility. Question is: is the current behavior of send_cb completely documented/defined, and if so, is this behavior properly enforced in current networking stack? Let's assume below user code:
net_context_send(ctx, buf, len, cb_1, K_NO_TIME, user_data_1);
net_context_send(ctx, buf, len, cb_2, K_NO_TIME, user_data_2);

According to net_context_send() documentation "After the network buffer is sent, a caller-supplied callback is called.". It means to me that first cb_1(user_data_1) is called when first packet is sent, then cb_2(user_data_2) is called when second packet is sent. This doesn't work like that currently, and this PR was supposed to fix that.

Beyond that, there's a bunch of "unbeautifulness" in the underlying netstack implementation, but why patch it randomly? E.g. you patch net_context_send, but there's also net_context_recv with about the same issues. Is it worth it? Is risk worth it? I don't see anything with starting with test: included in the commits...

Basically I need to know how to handle net_context_send in NET_OFFLOAD drivers, such as ESP WiFi. Second reason is that why not fixing stuff in small steps, hence its easier to review?
Thanks for noticing lack of tests. I will include some tests as far as we agree that the direction of those changes is good enough. Right now we are far from that yet.

Trying to solve a hypothetical high level API issue from the drivers was, I think, your mistake.
In the first place, you should not be moving anything that belongs to net_context to net_pkt. That's 2 different architectural blocks.

net_pkt is about data buffer and metadata about l2 and l3
while net_context is all about enabling user API

So a net_pkt might belong to a net_context, but no net_context stuff belongs to net_pkt, ever.
Nowadays, net_context is there to enable socket. There is no other API that will use net_context.
In early stage of this network stack, net_context used to be the API exposed to users, but now it's socket API.
(There are one sample as well as a few tests that still uses net_context, either because it was not ported to socket or just by convenience.)
And if you look at socket, you'll see it's being used only once: on listen call.
All other calls make sure to pass ctx->user_data back. (It's actually commented to be that way, in socket code).
So there is no way send/sendto etc.. will have different user_data.

Trying to solve a hypothetical high level API issue from the drivers was, I think, your mistake.

It is not hypothetical problem, if that behaviour is what directly comes from net_context API documentation. And this is not my problem only, because there are many existing drivers that handle net_context callbacks inconsistently.

In the first place, you should not be moving anything that belongs to net_context to net_pkt. That's 2 different architectural blocks.

net_pkt is about data buffer and metadata about l2 and l3
while net_context is all about enabling user API

So a net_pkt might belong to a net_context, but no net_context stuff belongs to net_pkt, ever.

Understood. But... There is already a net_pkt->context that points to net_context. If net_context_send_cb_t send_cb; is the problem, then lets make it context agnostic net_pkt_send_cb_t send_cb; and adjust net_context to make use of it.

Nowadays, net_context is there to enable socket. There is no other API that will use net_context.
In early stage of this network stack, net_context used to be the API exposed to users, but now it's socket API.
(There are one sample as well as a few tests that still uses net_context, either because it was not ported to socket or just by convenience.)

That is not true. There are shell_telnet, net_shell, dns, socks and log_backend_net all using net_context API. Together with sockets this makes 6 in-tree modules.

So there is no way send/sendto etc.. will have different user_data.

First of all there are 5 other in-tree modules using net_context API + some possible out-of-tree modules as well.
Second thing is that this should be directly written in net_context API. This is what (for example) NET_OFFLOAD driver writers look into when they receive net_context_send_cb send_cb as send/sendto function parameter and they want to figure out how to deal with it.
Last thing... if net_context API is supposed to be just a helper layer for sockets, then there should be a note/warning in net_context API to stop using it directly. And in the long-term net_context.h should be deprecated and hidden from application code at all.
With all this discussion, I still don't know what is the purpose of net_context_send_cb_t send_cb and how should I deal with it in network driver code to respect current "networking stack" / "networking architecture".

There are shell_telnet, net_shell, dns, socks and log_backend_net all using net_context API. Together with sockets this makes 6 in-tree modules.

Yes, that is correct. But as Tomasz said, many of these uses are because the code was not ported to use socket or just by convenience (net_context is async API which can be quite useful). Anyway, the point is that net_context API should only be used inside the net stack, not by application.

if net_context API is supposed to be just a helper layer for sockets, then there should be a note/warning in net_context API to stop using it directly. And in the long-term net_context.h should be deprecated and hidden from application code at all.

This is already documented in the documentation https://docs.zephyrproject.org/latest/reference/networking/net_context.html
I agree that we could move the header files away from include/net so that those would not be so easily found by app devs. I don't think we cannot deprecate the net_context API as we use it internally.

The problem that I encountered was that each .send() and .sendto() calls could have different send_cb and user_data parameters values.

I think that for the code using send_cb, the actual cb is most probably always the same. It is the user_data that might differ.

pretty inconsistent behaviour and no clear way what is the purpose of send_cb.

I have to agree with you that the usage of send_cb is a bit thin, and it is not really utilized much. I just wonder should we stop using the callback then if there is no need for that, and document it properly. Question to all, would that make sense here? Is there proper use cases for the send_cb, and if there is none, then we could just remove that.


The following table will report errors

system.grants
system.quota_limits
system.quota_usage
system.quotas
system.quotas_usage
system.role_grants
system.roles
system.row_policies
system.settings_profile_elements
system.settings_profiles
system.users
SQL 错误 [497]: ClickHouse exception, code: 497, host: <IP_ADDRESS>, port: 8123; Code: 497, e.displayText() = DB::Exception: default: Not enough privileges. To execute this query it's necessary to have grant SHOW USERS ON . SQLSTATE: HY000 (version <IP_ADDRESS>)

The access control and FGAC is not supported in ByConity yet.

The access control and FGAC is not supported in ByConity yet.

so it would be better if we could remove the tables mentioned above?

so it would be better if we could remove the tables mentioned above?
I think we can keep them until FGAC has been integrated into ByConity.

Currently you can query these tables after setting access_management = 1 in the users.xml and adding a password for the default user. More info can be found here: https://clickhouse.com/docs/en/operations/access-rights/#enabling-access-control

After doing the above, you can query these tables:


enhancements

skip deploy of parent project
removed zip file support
removed zip file binaries
added support to download web js/css files needed by the HTML files

Current coverage is 15.67%

Merging #14 into master will decrease coverage by -2.39% as of 3fa0ec0

@@            master     #14   diff @@
======================================
  Files           20      19     -1
  Stmts          382     370    -12
  Branches        37      37
  Methods          0       0
======================================
- Hit             69      58    -11
  Partial          7       7
+ Missed         306     305     -1

Review entire Coverage Diff as of 3fa0ec0

Powered by Codecov. Updated on successful CI builds.


Tracking windows support

I hope devshell will grow into an universal tool, if wsl2 is properly supported for nix.
It would be interesting to hear, if somebody has already experience to share, so that I can provide instructions to windows users for a repository I maintain.

Nix works fine in WSL and WSL2 as far as I know. The only issue is that it doesn't start services so it must be a single-user install.

The below works to install nix on WSL 1:
# Work around incorrect file locking https://github.com/Microsoft/WSL/issues/2395
use-sqlite-wal = false' | sudo tee /etc/nix/nix.conf

bash <(curl -L https://nixos.org/nix/install) --no-daemon --no-modify-profile


Fix layout

Increase the size of Star icon at note list
Change position new note button and refresh button at note list
Change color of Star button at header

Before

After

Android


Question about sampling the x' (negative samples) & code.

Hi,
I've read your paper, which is quite inspiring!
But here I have some questions regarding the eq.4, which states "x' is an input sampled from \tilde{P} x P". Does it mean that we randomly pick (x,y) independently from the X and Y(Y is the generated representation distribution of X)? If so, which part of the code implements this sampling method?
Thanks a lot!

x and x' are just sampled independently of each other, so for instance two different images in a batch where there are no dependencies on how different samples in the batch were sampled.

meaning x' and x (together) are sampled from product of marginals P x P_tilde. P_tilde is just a placeholder for a "copy" of P

Ahhh! Got it!

Thanks for your kind reply!


[IDE/SourceKit] New SourceKit request for filtered method list

source.request.conformingmethods is a new SourceKit request which receives a source position and a list of protocol namses, returns a list of methods whose return type conforms to the requested protocols.
rdar://problem/44699573

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test


Set up Kanban board

Link to project
Click here

This project consist of 2 team members @mershark and @aqurds

Hi @mershark and @Aqurds ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉
Highlights
✔ Set up the Kanban board correctly with all required columns.
✔ Ensured all tasks from the project requirements have been added correctly.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Provide Exception details for Component.Invoke/InvokeAsync like within @Html.Partial

When using @Html.Partial call and if view cannot be found, the exception message lists locations it searched:

InvalidOperationException: The partial view 'none' was not found. The following locations were searched: /Pages/none.cshtml /Views/Shared/none.cshtml

However when dealing with ViewComponents it just says:

InvalidOperationException: Could not find an 'Invoke' or 'InvokeAsync' method for the view component ...

Basically it results in hard-to-debug or hard-to-learn issues #2342 and https://stackoverflow.com/questions/50266952/how-are-razor-page-view-component-paths-searched-i-fail-to-get-them-working-n and would be of great help if we could see what locations are actually searched, so mistakes can be fixed quickly.
dotnet 2.0.7

Thanks for contacting us, @janis-veinbergs.
@kichalla, can you please look into this one? Thanks!

@janis-veinbergs how are you invoking your view? As far as I can tell, the only time you should see this error is if the type that Mvc discovers does not have an Invoke \ InvokeAsync method on it. You should see

an error that says the View Component could not be found if invoking it by name does not find a corresponding view component
an error listing search paths when a view component view could not be located.

@pranavkm
@await Component.InvokeAsync("whatever"); more specifially this:

#region Assembly Microsoft.AspNetCore.Mvc.ViewFeatures, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60
// C:\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.aspnetcore.mvc.viewfeatures\2.0.3\lib\netstandard2.0\Microsoft.AspNetCore.Mvc.ViewFeatures.dll
Microsoft.AspNetCore.Html.IHtmlContent.public static Task InvokeAsync(this IViewComponentHelper helper, string name);

No matter what view name I provide, it tells me this:

InvalidOperationException: Could not find an 'Invoke' or 'InvokeAsync' method for the view component '....Pages.Identities.IndexModel'.

It finds completely irrelevant model class which truly doesn't have InvokeAsync method. I havent yet tripped exception where it will list me search paths.

Find at least one issue. What I did was, throught trial & error, I left ViewComponent decorator for .Pages.Identities.IndexModel : PageModel class. And it referenced this class no matter what.. For non-existant view component I am now getting this exception:

InvalidOperationException: A view component named 'whatever' could not be found. A view component must be a public non-abstract class, not contain any generic parameters, and either be decorated with 'ViewComponentAttribute' or have a class name ending with the 'ViewComponent' suffix. A view component must not be decorated with 'NonViewComponentAttribute'.

I still don't see that it would tell me what paths have been searched tho.
But now I am hitting my ViewComponent InvokeAsync method with debugger.

There are two distinct discovery errors with ViewComponent discovery - the first when it attempts to look up a ViewComponent. It's essentially looking up the type, there aren't search paths involved. Consequently the second error you listed ("A view component named 'whatever' could not be found...") is appropriate. Search paths would only kick in once you attempt to return a View from a ViewComponent and it could not be found.

I left ViewComponent decorator for .Pages.Identities.IndexModel : PageModel class. And it referenced this class no matter what.

Do you have a sample that I could try this with? Having a Razor Page model be a View Component is not a scenario we've thought through, maybe it's running in to some odd edge case.

Actually when I think about it, it's not an issue.

You explained that for Type lookups, no search paths involved.
I should have spotted that [ViewComponent] attribute, and yes, exception kind of tells me that the viewcomponent (which is called SomethingModel) doesn't have a method Invoke, but was blind.

Great. Nothing to do here in that case 👍


[Feature request/Discussion] Multiple Windows is it real windows or inside single WebWindow ?

Hello! Great project and future future vision !
I noticed feature "Multiple Windows" but in demo/example find single Web browser window with multiple canvas only.
So question is there possibility for real multiple browser windows?
I was using multiple Dear Imgui windows in standard application (not Web) from docker branch.
Is it possible with WebApp with this emscripten-glfw library?
I was looking for multi-window webapp around and find interesting article :
[https://medium.com/swlh/expanding-single-page-apps-into-multiple-browser-windows-e6d9bd155d59]
so could this library be used in similar approach ?
How do you think should this question be redirected to Emscripten / Dear Imgui ?

Thank you for your questions.
As explained in the documentation, this library associates the concept of a "window" (in this instance a GLFWwindow) to an HTML "canvas".
So the concept of multiple windows is tied to the concept of having multiple canvases in a single browser window.
Note that both SDL2 and the JavaScript GLFW implementation that comes with Emscripten use the same concept of "canvas is a window". But only this library supports more than one at a time. This can be seen in a more realistic example here WebGPU Shader Toy (you need Chrome to see it in action).
What you are asking about is having an application that spans multiple browser windows like the link you provided. It is definitely not supported at the moment by this library (or others like SDL2), because of the fact that a GLFW window is associated with a canvas, not a browser window.
I don't think that ImGui can help you with this because ImGui uses this library or SDL2 so unless it is provided by the library that would not happen IMO.
I am not familiar at all about how to build an application across browser windows and it is certainly not a trivial thing to do. That would change this library quite drastically. That doesn't mean it won't happen but it is definitely a massive project: it is like starting from scratch...


Add export buttons to the Synthesis of reviews page(WIP)

closing as no longer needed (Trello ticket archived)


Install sample project with BP.

@estiens wrote:

It might also be nice to have a custom_animations directory installed with one very well documented example of a python animation for bibliopixel. This could allow people an animation where they could play with altering parameters in a step function for example and see what they do.

It would also give them a directory to put custom animations in that would be loaded automatically so no need to do anything with a path or alias. (Put your own animation here and call it by putting custom_animations.YourCustomAnimation in a project file!)

I'm concentrating on documentation these days but this would be very good for that.

@esteins wrote:

Or could be a CLI generator bp create MyCustomAnimation

Hah, funny, I was thinking that too and then I got to the later part of the email.
I need to let this sit for a while to get the correct setup, but the overall shape is good, and the goal - "Make it really really easy for someone to write their first animation" - is extremely seductive.

I agree, that would be nice. But v4.0. Let's get 3.5 out first.
On Mon, Jul 16, 2018 at 6:58 AM Tom Swirly<EMAIL_ADDRESS>wrote:

@esteins https://github.com/esteins wrote:
Or could be a CLI generator bp create MyCustomAnimation
Hah, funny, I was thinking that too and then I got to the later part of
the email.
I need to let this sit for a while to get the correct setup, but the
overall shape is good, and the goal - "Make it really really easy for
someone to write their first animation" - is extremely seductive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405212186,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6mfTDgxc5RiaygBI5kdUvyZ9ZLaaks5uHHG6gaJpZM4VQ55Z
.

OK, so how exactly *do *we get people started writing projects then,
without a sample project?
On Mon, Jul 16, 2018 at 1:00 PM, Adam Haile<EMAIL_ADDRESS>wrote:

I agree, that would be nice. But v4.0. Let's get 3.5 out first.
On Mon, Jul 16, 2018 at 6:58 AM Tom Swirly<EMAIL_ADDRESS>wrote:

@esteins https://github.com/esteins wrote:
Or could be a CLI generator bp create MyCustomAnimation
Hah, funny, I was thinking that too and then I got to the later part of
the email.
I need to let this sit for a while to get the correct setup, but the
overall shape is good, and the goal - "Make it really really easy for
someone to write their first animation" - is extremely seductive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-
405212186>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AA6a6mfTDgxc5RiaygBI5kdUvyZ9ZLaaks5uHHG6gaJpZM4VQ55Z>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405212699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdskky5vTjgfqKElJjMH0VkYqXhqkRks5uHHJSgaJpZM4VQ55Z
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

Ah, I muffed the title. :-/  Moment.

As I said, I'm not sure if an autogenerator, or just distributing an
"empty" project with things to fill out, is the solution, but *some *sort
of sample project is necessary, as well as a tutorial on how to use it.
On Mon, Jul 16, 2018 at 1:09 PM, Tom Swirly<EMAIL_ADDRESS>wrote:

OK, so how exactly *do *we get people started writing projects then,
without a sample project?
On Mon, Jul 16, 2018 at 1:00 PM, Adam Haile<EMAIL_ADDRESS>wrote:

I agree, that would be nice. But v4.0. Let's get 3.5 out first.
On Mon, Jul 16, 2018 at 6:58 AM Tom Swirly<EMAIL_ADDRESS>wrote:

@esteins https://github.com/esteins wrote:
Or could be a CLI generator bp create MyCustomAnimation
Hah, funny, I was thinking that too and then I got to the later part of
the email.
I need to let this sit for a while to get the correct setup, but the
overall shape is good, and the goal - "Make it really really easy for
someone to write their first animation" - is extremely seductive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/ManiacalLabs/BiblioPixel/issues/876#
issuecomment-405212186>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6a6mfTD
gxc5RiaygBI5kdUvyZ9ZLaaks5uHHG6gaJpZM4VQ55Z>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405212699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdskky5vTjgfqKElJjMH0VkYqXhqkRks5uHHJSgaJpZM4VQ55Z
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

oh oh... the docs should have a sample project. I was saying no to bp create. Let's just write good docs and call it a day.
On Mon, Jul 16, 2018 at 7:12 AM Tom Swirly<EMAIL_ADDRESS>wrote:

As I said, I'm not sure if an autogenerator, or just distributing an
"empty" project with things to fill out, is the solution, but *some *sort
of sample project is necessary, as well as a tutorial on how to use it.
On Mon, Jul 16, 2018 at 1:09 PM, Tom Swirly<EMAIL_ADDRESS>wrote:

OK, so how exactly *do *we get people started writing projects then,
without a sample project?
On Mon, Jul 16, 2018 at 1:00 PM, Adam Haile<EMAIL_ADDRESS>wrote:

I agree, that would be nice. But v4.0. Let's get 3.5 out first.
On Mon, Jul 16, 2018 at 6:58 AM Tom Swirly<EMAIL_ADDRESS>wrote:

@esteins https://github.com/esteins wrote:
Or could be a CLI generator bp create MyCustomAnimation
Hah, funny, I was thinking that too and then I got to the later part
of
the email.
I need to let this sit for a while to get the correct setup, but the
overall shape is good, and the goal - "Make it really really easy for
someone to write their first animation" - is extremely seductive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/ManiacalLabs/BiblioPixel/issues/876#
issuecomment-405212186>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6a6mfTD
gxc5RiaygBI5kdUvyZ9ZLaaks5uHHG6gaJpZM4VQ55Z>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405212699
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAPdskky5vTjgfqKElJjMH0VkYqXhqkRks5uHHJSgaJpZM4VQ55Z

.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405214929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6tjZkA-pff7TMZSyGUpkXkUrhE2rks5uHHUVgaJpZM4VQ55Z
.

sigh - we're never going to release 3.5 :P
Fine. Just do it. But NO MORE NEW FEATURES :P

<3 <3 <3
I do have a very specific goal with the documentation - it's to completely wow someone coming in off the street to the point they actually invest time in making some projects.
(And to be cynically frank, I am going to be using this to be selling myself for jobs, and I want that early experience to shine!)
In order to achieve that, we need three things.
The first is a fairly high level of completeness of the documentation - which is the gross goal here.   No complaints with that.
The second is a "wow factor".
My recent and upcoming commits relating to "GIF animations" are what I hope will give the "wow factor" - because the documentation will actually have moving images in it, and then you can go right to your browser and see the same things in simpixel.
So once we have GIF animations playing in most of the documentation pages, I'll consider the "wow factor" done.
But the third, indispensable idea for converting visitors into users, is a coherent story for someone to follow from "I just downloaded this" to "I am developing simple projects".

If there's one takeaway from this rant, it's that we should be evaluating this release entirely from the point of view of "casual developer who has come to the project by clicking a link from some new article" and we should be desperately trying to appeal to, amuse and educate them in the slickest manner possible.

I don't disagree with any of that. I just keep seeing new little features
and stuff creeping in so trying to keep focus. So if it's a new thing in an
effort to make what you said possible, then fine. But no to anything else ;)
On Mon, Jul 16, 2018 at 7:43 AM Tom Swirly<EMAIL_ADDRESS>wrote:

<3 <3 <3
I do have a very specific goal with the documentation - it's to completely
wow someone coming in off the street to the point they actually invest time
in making some projects.
(And to be cynically frank, I am going to be using this to be selling
myself for jobs, and I want that early experience to shine!)
In order to achieve that, we need three things.
The first is a fairly high level of completeness of the documentation -
which is the gross goal here. No complaints with that.
The second is a "wow factor".
My recent and upcoming commits relating to "GIF animations" are what I
hope will give the "wow factor" - because the documentation will actually
have moving images in it, and then you can go right to your browser and see
the same things in simpixel.
So once we have GIF animations playing in most of the documentation pages,
I'll consider the "wow factor" done.
But the third, indispensable idea for converting visitors into users, is a
coherent story for someone to follow from "I just downloaded this" to "I am
developing simple projects".
If there's one takeaway from this rant, it's that we should be evaluating
this release entirely from the point of view of "casual developer who has
come to the project by clicking a link from some new article" and we should
be desperately trying to appeal to, amuse and educate them in the slickest
manner possible.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/876#issuecomment-405220877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6li-HvPaC2_LejijL_xAbyGFX561ks5uHHxFgaJpZM4VQ55Z
.

:+1:


Problems with RandomEventExecution test suite examples

These examples have some mismatch issues that grow over time.

By the way:  it is suspicious to me that your error jumps in discrete chunks of 0.01 at 5 seconds, and every 10 seconds after that, with periodic decreases at multiples of 10 seconds.  The model itself doesn't do anything unusual at the 5-second marks, so it looks to me like the event might be failing to fire a single time at those time points.
The other thing is that your error trace looks identical for several different models, which I wouldn't expect from random errors, and all of the errors center around the multiples-of-5 data points.  (The requested output time points are slightly staggered from standard output--1001 steps over 100 seconds).
This is probably not an SBML interpretation issue, so I'm fine with leaving the model with a generous tolerance so you pass anyway.  But I suspect something is actually slipping at those points, as opposed to a general 'accumulation of error'.
-Lucian


node server.js → Error:Canont find module'node-sass-example'

Why? Error:Cannot find module'node-sass-example'

I'm no longer supporting this library as I don't use it any longer so I'm going to close this issue.


TurnBasedMatch expiration does not work.

Scenario is a two player match where participant p_2 waits 3 weeks before taking turn.
Before p_2 takes the turn, the match looks like this on the two devices:
Device 1:
Match status:           MATCH_STATUS_ACTIVE
Match turn status:      MATCH_TURN_STATUS_THEIR_TURN
Participant p_1 status: STATUS_JOINED
Participant p_2 status: STATUS_JOINED

Device 2:
Match status:           MATCH_STATUS_ACTIVE
Match turn status:      MATCH_TURN_STATUS_MY_TURN
Participant p_1 status: STATUS_JOINED
Participant p_2 status: STATUS_JOINED

So everything seems fine. Participant p_2 now takes turn on device 2:
Device 2:
takeTurn returns the following UpdateMatchResult (and afterwards the match disappears from device 2):
Error code:             STATUS_MATCH_ERROR_OUT_OF_DATE_VERSION
Match status:           MATCH_STATUS_EXPIRED
Match turn status:      MATCH_TURN_STATUS_COMPLETE
Participant p_1 status: STATUS_JOINED
Participant p_2 status: STATUS_UNRESPONSIVE

Device 1:
Nothing happens (not even after rebooting the device). It still looks like p_2 is having turn:
Match status:           MATCH_STATUS_ACTIVE
Match turn status:      MATCH_TURN_STATUS_THEIR_TURN
Participant p_1 status: STATUS_JOINED
Participant p_2 status: STATUS_JOINED

Thanks for the detailed report.  I'll pass it along.


how to train x4model

hi! the sever show out of memory when i train x4model. i should how to set bath_size and patch_size? my gpu gtx 24g

For offical paper, X4 model patch_size = 192, batch_size=16

For offical paper, X4 model patch_size = 192, batch_size=16

the server show me “out of memory” my server is  24g memory！so can you help me！

hello！ i have same question. have you get it？

I will take time to update the content of this library in the future, please wait for my solution to this problem.

Excuse me, when I was training x2, PSNR-inf and SSM-NAN appeared in the first 10 epoch. Have you ever encountered the same problem?

No, you should check the path.
---- Replied Message ----
| From | @.> |
| Date | 12/10/2022 21:48 |
| To | @.> |
| Cc |<EMAIL_ADDRESS>|
| Subject | Re: [Lornatang/CSNLN-PyTorch] how to train x4model (Issue #2) |
Excuse me, when I was training x2, PSNR-inf and SSM-NAN appeared in the first 10 epoch. Have you ever encountered the same problem?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Thank you for your reply! Specifically, I didn't have this problem when I first trained the network directly with the DIV2K dataset. However, this does not achieve the PSNR in the paper. I realized that I wasn't preprocessing the data. The problem occurred when I ran the run.py file in the scripts folder for data preprocessing.

I found this problem, this is a mixed precision training error, just need to modify one line code. plz wait me

Thank you. Where should I go to find your solution?

@EchoXu98 ok

Has the problem been solved? What line of code is it? How should I modify it?

optimizer， you pull it

thank you! How to understand" you pull it“？

chinese spoken english. emmmmm

哈哈哈，大佬，请问没理解你说的那个。请问我应该怎样修改optimizer？

这个问题主要是由adam优化器导致的，数值溢出，修改原始Adam中eps为1e-4

谢谢大佬，现在训练了17个epoch，没有出现同样的问题。

你好！我想问一下他这里面是不是没有给出数据增强的代码？
---- 回复的原邮件 ----
| 发件人 | @.> |
| 日期 | 2022年12月13日 21:18 |
| 收件人 | @.> |
| 抄送至 |<EMAIL_ADDRESS>|
| 主题 | Re: [Lornatang/CSNLN-PyTorch] how to train x4model (Issue #2) |
谢谢大佬，现在训练了17个epoch，没有出现同样的问题。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

这个问题主要是由adam优化器导致的，数值溢出，修改原始Adam中eps为1e-4
大佬，我在训练到第23个epoch时，这个问题又出现了。PSNR -inf   SSIM nan

你好！我想问一下他这里面是不是没有给出数据增强的代码？
…
---- 回复的原邮件 ---- | 发件人 | @.> | | 日期 | 2022年12月13日 21:18 | | 收件人 | @.> | | 抄送至 |<EMAIL_ADDRESS>| | 主题 | Re: [Lornatang/CSNLN-PyTorch] how to train x4model (Issue #2) | 谢谢大佬，现在训练了17个epoch，没有出现同样的问题。 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

给出了


Device Plugins: add an info about beta graduation

/remove-lgtm
Let's address @windsonsea's comments first.

@windsonsea @elezar Thank you for the review! All suggestions have been merged into the PR branch. PTAL.

/sig node

/assign @SergeyKanzhelev @mrunalp @derekwaynecarr @dchen1107
for SIG-Node approval

@pacoxu thank you for the review. Code change PR has been created as suggested: https://github.com/kubernetes/kubernetes/pull/121254, PTAL.

Just noting that the related PR is blocking promotion to beta pending additional e2e tests.

/approve
/hold
For https://github.com/kubernetes/kubernetes/pull/121440

/unhold
as https://github.com/kubernetes/kubernetes/pull/121440 and https://github.com/kubernetes/kubernetes/pull/121254 have been merged

@mrunalp @SergeyKanzhelev can you review / approve?

/lgtm

/assign @SergeyKanzhelev @mrunalp @derekwaynecarr @dchen1107 for SIG-Node approval

/lgtm
/assign @reylejano

/lgtm

/lgtm

Hello @bart0sh 👋, gentle reminder to get your PR merged before the deadline, Tuesday 28th November 2023. Thank you!

/assign @reylejano


[MXNET-424] dtype option for multinomial

Description
This PR adds dtype option to set the data type of the sample output array of random.multinomial, which is fixed as 'int32' in the current implementation. The default value is int32.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

This change would make things a bit more consistent with other samplers. For all the rest (uniform , gamma etc), we consistently use a floating point type as return value (by default 32bit) though some of them (Poisson, negative binomial) are distributions on integer values. And for the cases that I have seen where these samplers get used in practice, in fact the users needed floating-point data for further processing.
We hardly can't change the default type of the multinomial anymore, but I think we should add floating point as a result type.
The nested compile switches are used a lot in MXNet, not sure whether this is an issue when used also here.

otherwise LGTM


chore: cache node_modules

Sorry, but we actually stopped doing this because we were experiencing issues with stale node modules.

Well, there is also another caching strategy and I did not see any issues with this proposed caching strategy recently.


Incorrect parse tree for comparison operator

Given the expression:
assert isinstance(copy2, variables.Variable)
The parse tree generated is:
(module [0, 0] - [1, 0]
  (expression_statement [0, 0] - [0, 44]
    (comparison_operator [0, 0] - [0, 44]
      (identifier [0, 0] - [0, 6])
      (call [0, 9] - [0, 44]
        (identifier [0, 9] - [0, 17])
        (identifier [0, 18] - [0, 23])
        (attribute [0, 25] - [0, 43]
          (identifier [0, 25] - [0, 34])
          (identifier [0, 35] - [0, 43]))))))

The comparison_operator rule contains in, and it appears the isinstance call is being incorrectly labeled as a comparison_operator because it's matching in. Is that what you think is happening @maxbrunsfeld?

I think the problem is that the grammar did not include assert statements, so tree-sitter was parsing this code as if assert was just a normal identifier. It was then interpreting the word is in isinstance as a relational operator, as if the code was
a is instance(copy2, variables.Variable)

I had an un-pushed commit adding assert statements, so I just pushed that. Maybe it will fix this issue.

@maxbrunsfeld ah thanks so much! I didn't think of assert as a Python keyword, instead seeing it in test files assuming it was a method call for a test framework used by tensorflow. That said, my Python knowledge is very limited 😅 .
Given the statement:
assert isinstance(copy2, variables.Variable)
The assert_statement rule now correctly parses this as:
(module [0, 0] - [1, 0]
  (assert_statement [0, 0] - [0, 44]
    (call [0, 7] - [0, 44]
      (identifier [0, 7] - [0, 17])
      (identifier [0, 18] - [0, 23])
      (attribute [0, 25] - [0, 43]
        (identifier [0, 25] - [0, 34])
        (identifier [0, 35] - [0, 43])))))

All looks 👍


need have a way to set runtime flags for the IC

Is your feature request related to a problem? Please describe.
Pomerium Core has some runtime flags that may enable or disable certain behaviours.
They were introduced mainly as escape valves.
It is possible to set them in Core via the config file, however no method currently exists for the ingress controller.
Describe the solution you'd like
One option would be to keep it similar to the runtime_flags section of the config.yaml, and add a runtimeFlags: map[string]bool property to the CRD.
Describe alternatives you've considered
Explain any additional use-cases
If there are any use-cases that would help us understand the use/need/value please share them as they can help us decide on acceptance and prioritization.
Additional context
Add any other context or screenshots about the feature request here.

Adding a runtimeFlags property to the CRD makes sense to me.


kicad: init unstable at version 2017-12-11

Motivation for this change
Files are not forward compatible, so when cooperating with someone who needs features of the Nightly Development Build, you also need this newer version.
In contrast with the current package for the stable release of KiCad, this package also enables oce, ngspice and scripting support.
This package does not provide the component libraries (schematics, PCB footprints, 3D models). They can be obtained from KiCad, unpacked and referenced at runtime.
It is called unstable and not nightly because it doesn't automatically track upstream nightly development builds.
wxPython headers are needed at buildtime. This PR includes  a necessary change to wxPython. That change is also in a separate PR: #32647
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I took the liberty of adding @viric as a maintainer. Please approve :-)

It failed because I tried to set the version of wxGTK used by wxPython in a wrong way.
For testing I had set wxGTK = wxGTK30 in all-packages.nix. That worked.
How can I specify the version of a dependency of wxPython in inherit (pythonPackages) wxPython;

All proposed changes have been applied.


Create a CONTRIBUTING.md

Can i work on this issue? @NathanTarbert

@anevski-stefan | @HimanshuTembhe - I have a PR, it's just waiting for approval