Integration Account api spec

Integration Account api specs for Logic App with composite client to support two API versions.

Hi @pankajsn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (pankajsn). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Hey @pankajsn,
Very nice spec. Very clean :)
The only thing I wanted to mention is when you have a $ref with a sibling description property :
ie:
    "EdifactFramingSettings": {
            "type": "object",
            "properties": {
               // ... snipped for berevity ...
                "characterSet": {
                    "$ref": "#/definitions/EdifactCharacterSet",
                    // LOOK HERE
                    // This description should really be in the definition at "#/definitions/EdifactCharacterSet"
                    "description": "Gets or sets EDIFACT one-way receive agreement."
                },
            }
               // ... snipped for berevity ...
        },

// ... snipped for berevity ...
  "EdifactCharacterSet": {
            "type": "string",
             // LOOK HERE
             // description should really go here
            "enum": [
                "NotSpecified",
                "UNOB",
                "UNOA",
                "UNOC",
                "UNOD",
                "UNOE",
                "UNOF",
                "UNOG",
                "UNOH",
                "UNOI",
                "UNOJ",
                "UNOK",
                "UNOX",
                "UNOY",
                "KECA"
            ],
            "x-ms-enum": {
                "name": "EdifactCharacterSet",
                "modelAsString": false
            }
        },

At this point, if you're getting the right generated code, I wouldn't worry too much today, however, in the near future, the forthcoming linter tool will pick these up as warnings.  (hmm. perhaps we should make it so the linter can auto-fix stuff like that)
Other than that
Looks Good To Me ™
Unless @amarzavery  finds anything, good to merge.

Hey @pankajsn,
Oh yeah,  @amarzavery   mentioned one thing we'd like to see fixed --
Remove the Gets or sets text from the properties, the code generator will add that on languages where that's appropriate.

This is fixed.
Regards,
~Pankaj
From: Garrett Serack<EMAIL_ADDRESS>Sent: Wednesday, June 22, 2016 11:01 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Pankaj Singh Negi<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Integration Account api spec (#368)
Hey @pankajsnhttps://github.com/pankajsn,
Oh yeah, @amarzaveryhttps://github.com/amarzavery mentioned one thing we'd like to see fixed --
Remove the Gets or sets text from the properties, the code generator will add that on languages where that's appropriate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-rest-api-specs/pull/368#issuecomment-227826817, or mute the threadhttps://github.com/notifications/unsubscribe/APZfc0GPVvNypNNxELnAmJxYwQgskxGbks5qOXh2gaJpZM4I7T3a.

No modification for Python

No modification for NodeJS


[stable/postgresql] add HA comment

Signed-off-by: Xiang Dai<EMAIL_ADDRESS>Now this repo does not cover HA, add comment for this.

/assign @juan131

/ok-to-test
/lgtm


Android 4.4.4

On startup doesn't show qr code, it ask to use a browser.

Hi, thanks for reporting this.
I could reproduce this with an 4.4.4 device. Will check.

It looks like the webview shipped with Kitkat (4.4.4.) does not work the way it should to support whatsapp web. The problem is, that the webview was not shipped as an apk in 4.4.4 but was baked into the system, so it cannot be updated. I'll look for other ways to solve this, but it could take a while

Thanx for your work,  I'll wait for a fix.

Looks like there is now way getting it to work on Kitkat (4.4(.4)) devices. The next update disables the possibility to install on devices lower than 5.0 (Lollipop)
I'm sorry i couldn't fix this. I'll close this now but continue to search for a fix. Should I find something I will update this issue.


Add hydrogen reference docs

Add official reference docs for Hydrogen, which will replace https://shopify.dev/docs/api/hydrogen. This will allow us to more quickly add docs for new Hydrogen abstractions.

Resolves https://github.com/Shopify/hydrogen/issues/837


Generate pxd

Closes #69

nice, sorry ;]

Could we get some benchmarks ? Given the workflow of pegen it is not obvious to me how much cython will be able to optimize things. In particular since we would have to drop the walrus operator which makes the generated parser more readable IMO.

Also if we can wait for Cython 3.0 we will get walrus support (see https://github.com/cython/cython/issues/2636). However I have no idea regarding the timeline for its release.

Also if we can wait for Cython 3.0 we will get walrus support (see cython/cython#2636). However I have no idea regarding the timeline for its release.

It's very unlikely that it'll be out in 2022
There are not a lot of people working on cython, so unfortunately 3.0 will not be out soon

Could we get some benchmarks ?

Of course
Also regarding drop of the walrus. I'll merge no_walrus branch here because changes will not work without it.
And if we'll be fine with that change I will open a pr for this branch, so it could be merged first

fyi, walrus operator support is now released with 3.0a11 version https://github.com/cython/cython/blob/master/CHANGES.rst#300-alpha-11-2022-07-31


fix: round after math

Fixes #1300
Fixes #1410
Refs #1400
Rounding was previously happening to ONE of the measured inputs and then other inputs were not, so the output wouldn't actually be rounded. This moves the rounding to only happen at the end of the style calculations so that it ensure the styles sent the the client are rounded.

Does it also help this https://github.com/popperjs/popper-core/issues/1410?

It definitely looks a lot better. "Solved" is tricky when somethings can be subpixel and some things can't be. While zooming in continues to throw a big fat wrench, non-zoomed this appears to align things as expect in the case of #1410 as well.

While zooming in continues to throw a big fat wrench

What about in combo with the DPR PR too https://github.com/popperjs/popper-core/pull/1400

DPR doesn't seem to change while zooming. I'm not sure there is any way to surface zoom in the client to account for it either. I'll look into that.

My mistake, window.devicePixelRatio does seem to follow the zoom, the issue is when during the 110% zoom where the math still ends up with a non-representable pixel fraction. However, even in that case it looks much better than what was being previously delivered. All other zooms seem to be good to go in the provided demo.

Any thoughts on this test failure? I’m not sure how it was considered passing before based on the code I’m seeing. Happy to update the baseline with some agreement there. This update helps my project a lot and I’d love for it to come without having to patch the package.

Regarding that test, a difference of 4px seems kinda odd (I'd expect 1px max), do you have a replication of the differences?

The test asserts that 100px width + 10.3px offset + 2px should result into 112px after it gets rounded. 108 seems not to be correct, it looks like you are subtracting 2 rather than adding them?

I stepped through this some more and better understand what is going on, but I'm not sure what to say is the right answer.
The roundOffsets method here is:
roundOffsets: ({ x, y }) => ({
        x: Math.round(x + 2),
        y: Math.round(y + 2),
}),

If you round at the beginning, you'll end up with -112 because you add 2 to the input (10.3 to 12), and if you round at the end you get -108 because you round the output (-110.3 to -108).
What is the meaning of this test? // customize roundOffsets impls doesn't really explain why you are making a custom roundOffset to tell what is supposed to be happening here. However, it does imply that my alteration would be a breaking change for some, regardless of it being more or less correct output. Rounding at the beginning and at the end would be less accurate, but would allow for this to both function as before and ensure all number sent to the client are rounded correctly. OR, we could allow for all custom roundOffset code to be run only at the beginning, as that likely means the user is getting what they'd prefer here already?

Or maybe use the roundOffsets option at the beginning of the process as available, but not as a replacement for roundOffsetsByDPR, which should likely be renamed to roundPlacementByDPR and run 100% of the time at the end of mapToStyles?

Split the two parts of rounding outlined in https://github.com/popperjs/popper-core/pull/1418#issuecomment-981094250 to before and after the computations and added a new test (leveraging measurements from https://stackblitz.com/edit/react-nyp2yj?file=src%2FApp.js) that failed to deliver DPR correct computations when using the previous method of rounding (which is the basis for #1410).

Any insight on the Flow issue would be most helpful. That same command doesn't fail locally and I've never used Flow outside of this project.

Oh, I think I got it now. My branch was out of date 😅 Hopefully this is the one!

Thanks! Merging.

Can we get a release on this to hold people over until they're able to update to Floating UI?


"Managing Utilization Notifications

This pull request adds a new Java class CPUMemoryUtilizationAnalyzer that provides functionality to analyze CPU utilization based on current and recommended values. The class includes a method analyzeCPUState abd analyzeMemeroyState which determines the state of the CPU (overutilized, underutilized, or idle) based on the provided parameters.

Closing stale PRs


Add more related topics

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Suggesting edits to an existing Topic page
[ ] Curating a new Topic page

EDITING AN EXISTING TOPIC PAGE*
I'm suggesting these edits to an existing topic:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please explain why these changes are necessary:
For the react changes: if someone lands on /topics/react, they might not know react-native is a thing. Oppositely, if they land on /topics/react-native, it'd be good to link back to react so they can find out about the base framework.
I also added related topics to connect languages, and tie topics for programming languages back to the general 'languages' topic. I think this will let users branch out to discover new languages.

I do not have clue on what I'm doing I did not want to claim or verify 21 hospital drive Atlantic urology assoiciat

Did not know some one was even out there watching me make mistakes


Move all documentations and charters

Move all charters and documents part of the Express repository in the Admin repository
The current list is comprised of

Charter.md
Code-Of-Conduct.md
Collaborator-Guide.md
Contributing.md
Readme-Guide.md
Release-Process.md
Security.md
Triager-Guide.md

In the same time a PR in the Express repository will be opened to remove (or update and link) to this repository
I am not sure about how we want to order that in this repository, I added everything in a charters folder, but it may make sense to split that in

charters
contributing (or contribution)
processes (for security, triage...)

yes, I was discussing that (and learned that) from Jordan yesterday - but this only work with specific files.
On our current list, only CoC/Contributing/Security would be "shared"
Learning that, I was planning to open a PR inside for all issue and pr template (should be done today)

The main question being: Do we want to split the files between .github and Admin? Or do we want to put them in .github and if they are not propagated we just use a normal link (like we would do here in Admin)

For simplicity I will keep it under one repository. That is what I do in other orgs.
Any document that is not shared by Github automatically I will add a reference to the .github/xxx.md. That is easy because we only need to edit things in one place.

The contents of Contributing.md, Collaborator-Guide.md, and Security.md are duplicated into https://github.com/expressjs/expressjs.com/blob/gh-pages/en/resources/contributing.md via the script at
https://github.com/expressjs/expressjs.com/blob/gh-pages/get-contributing.sh... And the page is published to https://expressjs.com/en/resources/contributing.html.
So get-contributing.sh will just need to be updated for the new file locations, then re-run, and the updated file committed to the expressjs.com repo.  I think @jonchurch worked on that script, so perhaps he could take a stab at it.  My "sed-fu" is extremely rusty, and my "bash-fu" is somewhat shaky, so I'm hesitant to do so.

@UlisesGascon
I think that Github offers a lot of advantages if we rename this repo to .github. I see that other orgs are using this, like fastify. That way we can inherit these files to other repos like security, CoC, contributing and so on... more info

We do have https://github.com/expressjs/.github already, so we cannot rename this one.
I like the .github convention for this actually.

@sheplu
The main question being: Do we want to split the files between .github and Admin? Or do we want to put them in .github and if they are not propagated we just use a normal link (like we would do here in Admin)

One repo to rule them all.
That being said, these are convos for an issue. I don't have any edits to suggest for this PR in it's current state and think we can merge and carry on in an issue.

Multiple threads of this convo lol, and I just commented on the other one. I'm on my phone so lost it, but it's in the discussions one IIRC.
Basically I am 👍 on using .github and think we should at most rename the discussions repo not have a new one.


Can't run Example Pulsar Locally

Expected behavior
Either the run from local files, or run with docker command should work.
Actual behavior
Running bin pulsar/standalone results in this:
[AppClassLoader@685f4c2e] info AspectJ Weaver Version 1.9.1 built on Friday Apr 20, 2018 at 16:47:33 GMT
[AppClassLoader@685f4c2e] info register classloader sun.misc.Launcher$AppClassLoader@685f4c2e
[AppClassLoader@685f4c2e] info using configuration file:/Users/josh/Documents/tools/apache-pulsar-2.1.0-incubating/lib/org.apache.pulsar-pulsar-broker-2.1.0-incubating.jar!/META-INF/aop.xml
[AppClassLoader@685f4c2e] info using configuration file:/Users/josh/Documents/tools/apache-pulsar-2.1.0-incubating/lib/org.apache.pulsar-pulsar-zookeeper-2.1.0-incubating.jar!/META-INF/aop.xml
[AppClassLoader@685f4c2e] info register aspect org.apache.pulsar.broker.zookeeper.aspectj.ClientCnxnAspect
[AppClassLoader@685f4c2e] info register aspect org.apache.pulsar.zookeeper.FinalRequestProcessorAspect
[AppClassLoader@685f4c2e] info register aspect org.apache.pulsar.zookeeper.ZooKeeperServerAspect
11:43:56.987 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - Running 1 bookie(s) and advertised them at random.
11:43:57.021 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - Starting ZK server
11:43:57.606 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - Server UP
11:43:57.607 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - ZooKeeper server up: true
11:43:57.608 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - Instantiate ZK Client
11:43:57.685 [main] INFO  org.apache.pulsar.zookeeper.LocalBookkeeperEnsemble - Starting Bookie(s)
11:43:58.537 [main] WARN  org.apache.curator.retry.ExponentialBackoffRetry - maxRetries too large<PHONE_NUMBER>). Pinning to 29
11:43:58.687 [main] INFO  org.apache.curator.framework.imps.CuratorFrameworkImpl - Starting
11:43:58.708 [main-EventThread] INFO  org.apache.curator.framework.state.ConnectionStateManager - State change: CONNECTED
11:43:58.711 [main] INFO  org.apache.curator.framework.imps.CuratorFrameworkImpl - Default schema
11:43:58.715 [main-EventThread] INFO  org.apache.curator.framework.imps.EnsembleTracker - New config event received: {}
11:43:58.715 [main-EventThread] INFO  org.apache.curator.framework.imps.EnsembleTracker - New config event received: {}
11:43:58.747 [Curator-Framework-0] INFO  org.apache.curator.framework.imps.CuratorFrameworkImpl - backgroundOperationsLoop exiting
11:43:58.917 [main] WARN  org.apache.curator.retry.ExponentialBackoffRetry - maxRetries too large<PHONE_NUMBER>). Pinning to 29
11:43:59.002 [main] INFO  org.apache.curator.framework.imps.CuratorFrameworkImpl - Starting
11:43:59.004 [main] INFO  org.apache.curator.framework.imps.CuratorFrameworkImpl - Default schema
11:43:59.005 [main-EventThread] INFO  org.apache.curator.framework.state.ConnectionStateManager - State change: CONNECTED
11:43:59.007 [main-EventThread] INFO  org.apache.curator.framework.imps.EnsembleTracker - New config event received: {}
11:43:59.007 [main-EventThread] INFO  org.apache.curator.framework.imps.EnsembleTracker - New config event received: {}

And it never starts.
Running with the docker command tells me fetching failed and the repository may not exist. A quick check of dockerhub shows that apachepulsar/pulsar-standalone in fact does not exist.
Steps to reproduce
The first issue I'm not sure about. There was a time when it did work, but it doesn't now. The second issue is pretty straightforward, just run:
docker run -it -p 80:80 -p 8080:8080 -p 6650:6650 apachepulsar/pulsar-standalone
System configuration
2.1.0 for local, N/A for docker attempt.

@MrThreepwood Can you try with docker run -it -p 80:80 -p 8080:8080 -p 6650:6650 apachepulsar/pulsar bin/pulsar standalone ?

@merlimat this command works for me.
pulsar: 2.2.0
image repo: apachepulsar/pulsar-all:latest

Yes, that command appears to work. If that's the intended method to run this in docker, then the documentation should probably be updated at:
http://pulsar.apache.org/docs/en/standalone/


Remove tide-related methods until tides are actually supported

@ashjbarnes
If I understand correctly, these methods
https://github.com/COSIMA/regional-mom6/blob/a364cec870b59547a58aa28ebf3eadc56a99bfe2/regional_mom6/regional_mom6.py#L30-L153
are neither used nor tested at the moment. They are just there in anticipation of tide forcing functionality. Or are they used?
If they are not used could we remove them and add them back together with the tide-forcing functionality? What do you think?
(If this will complicate or break any workflows you've set up for research then let's not bother -- feel free to close the issue in that case.)

yeah this is fine we can take them out! I'll they exist in the tides branch anyway


add more ingress metrics with low cardinality

this has been a larger rework. ingress metrics have been scraped and
dropped within the workload job. Switching from action drop to action
keep would have dropped a lot of other metrics. so i decided to remove
the ingress controller from workload and add a new job called
ingress.
new ingress metrics are:

nginx_ingress_controller_config_hash
nginx_ingress_controller_config_last_reload_successful
nginx_ingress_controller_config_last_reload_successful_timestamp_seconds
nginx_ingress_controller_nginx_process_connections
nginx_ingress_controller_nginx_process_connections_total
nginx_ingress_controller_nginx_process_cpu_seconds_total
nginx_ingress_controller_nginx_process_num_procs
nginx_ingress_controller_nginx_process_oldest_start_time_seconds
nginx_ingress_controller_nginx_process_read_bytes_total
nginx_ingress_controller_nginx_process_requests_total
nginx_ingress_controller_nginx_process_resident_memory_bytes
nginx_ingress_controller_nginx_process_virtual_memory_bytes
nginx_ingress_controller_nginx_process_write_bytes_total
nginx_ingress_controller_success

the mentioned metrics are less than 5 timeseries per ingress pod and
shouldn't do any harm atm.
example from a production cluster:
   6776 nginx_ingress_controller_bytes_sent_bucket
    847 nginx_ingress_controller_bytes_sent_count
    847 nginx_ingress_controller_bytes_sent_sum
      1 nginx_ingress_controller_config_hash
      1 nginx_ingress_controller_config_last_reload_successful
      1
nginx_ingress_controller_config_last_reload_successful_timestamp_seconds
    393 nginx_ingress_controller_ingress_upstream_latency_seconds
    131 nginx_ingress_controller_ingress_upstream_latency_seconds_count
    131 nginx_ingress_controller_ingress_upstream_latency_seconds_sum
      4 nginx_ingress_controller_nginx_process_connections
      2 nginx_ingress_controller_nginx_process_connections_total
      1 nginx_ingress_controller_nginx_process_cpu_seconds_total
      1 nginx_ingress_controller_nginx_process_num_procs
      1 nginx_ingress_controller_nginx_process_oldest_start_time_seconds
      1 nginx_ingress_controller_nginx_process_read_bytes_total
      1 nginx_ingress_controller_nginx_process_requests_total
      1 nginx_ingress_controller_nginx_process_resident_memory_bytes
      1 nginx_ingress_controller_nginx_process_virtual_memory_bytes
      1 nginx_ingress_controller_nginx_process_write_bytes_total
  10164 nginx_ingress_controller_request_duration_seconds_bucket
    847 nginx_ingress_controller_request_duration_seconds_count
    847 nginx_ingress_controller_request_duration_seconds_sum
    496 nginx_ingress_controller_requests
   9317 nginx_ingress_controller_request_size_bucket
    847 nginx_ingress_controller_request_size_count
    847 nginx_ingress_controller_request_size_sum
   8592 nginx_ingress_controller_response_duration_seconds_bucket
    716 nginx_ingress_controller_response_duration_seconds_count
    716 nginx_ingress_controller_response_duration_seconds_sum
  10164 nginx_ingress_controller_response_size_bucket
    847 nginx_ingress_controller_response_size_count
    847 nginx_ingress_controller_response_size_sum
      1 nginx_ingress_controller_success

towards: https://github.com/giantswarm/giantswarm/issues/9779

Do we need the metrics that are not prefixed with nginx_ingress_controller from the ingress controller ports? Afaik those have not been dropped before. Those metrics were the only reason we scraped the ingress controller before btw.
go_gc_duration_seconds{quantile="0"} 1.0806e-05
go_gc_duration_seconds{quantile="0.25"} 1.6164e-05
go_gc_duration_seconds{quantile="0.5"} 2.8837e-05
go_gc_duration_seconds{quantile="0.75"} 5.0732e-05
go_gc_duration_seconds{quantile="1"} 0.001450196
go_gc_duration_seconds_sum 0.663422818
go_gc_duration_seconds_count 5249
go_goroutines 90
go_info{version="go1.13.8"} 1
go_memstats_alloc_bytes 1.53273912e+08
go_memstats_alloc_bytes_total 5.27835440992e+11
go_memstats_buck_hash_sys_bytes 2.64581e+06
go_memstats_frees_total 9.812518436e+09
go_memstats_gc_cpu_fraction 3.855068069737587e-05
go_memstats_gc_sys_bytes 1.8720768e+07
go_memstats_heap_alloc_bytes 1.53273912e+08
go_memstats_heap_idle_bytes 2.83738112e+08
go_memstats_heap_inuse_bytes 1.835008e+08
go_memstats_heap_objects 1.003591e+06
go_memstats_heap_released_bytes 2.06348288e+08
go_memstats_heap_sys_bytes 4.67238912e+08
go_memstats_last_gc_time_seconds 1.5866823854842064e+09
go_memstats_lookups_total 0
go_memstats_mallocs_total 9.813522027e+09
go_memstats_mcache_inuse_bytes 13888
go_memstats_mcache_sys_bytes 16384
go_memstats_mspan_inuse_bytes 2.041632e+06
go_memstats_mspan_sys_bytes 2.932736e+06
go_memstats_next_gc_bytes 2.40246784e+08
go_memstats_other_sys_bytes 2.00135e+06
go_memstats_stack_inuse_bytes 2.523136e+06
go_memstats_stack_sys_bytes 2.523136e+06
go_memstats_sys_bytes 4.96079096e+08
go_threads 27
process_cpu_seconds_total 11449.63
process_max_fds 1.048576e+06
process_open_fds 30
process_resident_memory_bytes 3.05647616e+08
process_start_time_seconds 1.58616682762e+09
process_virtual_memory_bytes 5.67226368e+08
process_virtual_memory_max_bytes -1
promhttp_metric_handler_requests_in_flight 1
promhttp_metric_handler_requests_total{code="200"} 33779
promhttp_metric_handler_requests_total{code="500"} 0
promhttp_metric_handler_requests_total{code="503"} 0

@sslavic can probably give a better answer to which metrics are useful. the default ones don't seem particularly useful to me

If these other metrics are already being scraped, lets keep them for now.

Running this on testing installations shows no large increase in resource usage.
Testing on asgard shows a ~10Gb increase in memory consumption from 17Gb to 27Gb.

@glitchcrab thanks for testing this already :heart:
is it this still deployed? my question would be if we have seen similar spikes on restarts of prometheus before the change and the memory usage is not related to the new metrics.

This comment belongs here rather than in Slack.
@teemow aside from the spike on startup it ran quite happily for a few hours before someone's change was deployed over the top of it. I saw nothing which really worried me.


Group interfaces

Closes #1513
I've just implemented it for the std-http code generation, give me some thoughts about it and I could implement other server frameworks.

Thanks, will try and have a look once we've got down the https://github.com/oapi-codegen/oapi-codegen/milestone/10 backlog


Shapes are not perfect

Describe the bug
When I click the rectangle button there is no perfect rectangle formed
To Reproduce
Steps to reproduce the behavior:

Go to 'Nav bar'
Click on 'Rectangle button'
Draw the rectangle
See error

Expected behavior
A perfect shape would be drawn with single line
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS] - Windows 11
Browser [e.g. chrome, safari]- Chrome
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
Please assign the task to me

Hi @Souvik34 , thanks for opening an issue . I think you have selected the slopiness option 3rd . That's why the rectangles are of that shape that you are seeing . May you please check one time .

Hi @Souvik34 , thanks for opening the issue . I think you have selected the slopiness option 3rd . That's why the rectangles are of that shape that you are seeing . May you please check one time .

No there are multiple lines if I create any shape.

@Souvik34  yes , these multiple lines are due to the sloppiness . We can change the sloppiness to a value so that this multiple lines will disappear . For such case you have to look into the rough.js docs and find how the sloppiness is handled.
What we can do in this case , is add a slide bar or some thing like fuzzy value selector for the sloppiness . You may work on creating the same for the issue that you are pointing out . In that case person may select the settings that he want.
You may start working on this.


Implement global load/set, memory 64bit/32bit load

This PR starts implementing more tablestakes.
All the complexity here is in mitigating Spectre. We use the same technique as v8, which is this:

Set a register to 0xffff... before the bounds check
Zero the register in a non-branching way if out-of-bounds
Mask the result read from the the memory array with the mask register

This works because CPUs do not speculate through bitmask operations, and because if the bounds check was mis-speculated, the poison register would be set to zero. As a result, attacker-controlled instructions later on would always get a zero value for their speculation attack, so they cannot build any measurement primitives to determine the value from the speculated out-of-bounds access.

Codecov Report

Merging #129 into master will increase coverage by 0.66%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage    66.5%   67.17%   +0.66%
==========================================
  Files          41       41
  Lines        4490     4700     +210
==========================================
+ Hits         2986     3157     +171
- Misses       1233     1271      +38
- Partials      271      272       +1

Impacted Files
Coverage Δ

exec/internal/compile/native.go
54.54% <ø> (ø)
:arrow_up:

exec/internal/compile/scanner.go
0% <0%> (ø)
:arrow_up:

exec/internal/compile/native_exec.go
100% <100%> (ø)
:arrow_up:

exec/native_compile.go
55.35% <100%> (ø)
:arrow_up:

exec/internal/compile/backend_amd64.go
78.39% <83.09%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c8885...f7212ac. Read the comment docs.

With these changes (and the last few PRs), the integer benchmark is now 50% faster than when it was introduced.
[xxx@xxx]:~/projects/wagon> go test -bench=BenchmarkU github.com/go-interpreter/wagon/exec
goos: linux
goarch: amd64
pkg: github.com/go-interpreter/wagon/exec
BenchmarkU64Arithmetic10Interpreted-8   	  100000	     17064 ns/op
BenchmarkU64Arithmetic10Native-8        	  300000	      3787 ns/op
BenchmarkU64Arithmetic50Interpreted-8   	   20000	     76593 ns/op
BenchmarkU64Arithmetic50Native-8        	  100000	     16423 ns/op
PASS
ok  	github.com/go-interpreter/wagon/exec	9.162s


Option to stop opening other files when going to next error.

When clicking to see the next error in a file, it often switches context to a completely different file I have open which is often completely out of context and leaves me searching for the previous file I had open. I understand wanting to show errors for all files open, but taking you to errors completely out of context seems like the wrong solution.
Perhaps if we disable the "Show Project Tab" option, you should also only be iterating over the File errors (rather than project errors).

Are you saying that "Show next error" is moving you to errors from different files, even when:

On the File tab, with the Project tab enabled
On the File tab, with the Project tab disabled
On the project tab, but you want it to stay on the same file anyway

This issue has already been solved in the linter ui split package, but I'll keep this open until it's published

It sounds like steelbrain understands the issue. Just to make this bug complete, here is the answer to the questions asked. Having the Project tab enabled or not should be irrelevant. I only mentioned it above because I was trying everything I could think of to make it stop changing the files on me.

On the File tab, with the Project tab enabled: cycling through issues should stay on the same file.
On the project tab, but you want it to stay on the same file anyway: cycling through issues should span all files.

As it is right now, with the File tab selected, its still changing files when cycling through errors.

@mjs7231 The linter commands haven't received any love in a long-long time. In the master branch, it iterates over all of the messages in a seemingly-random order, I have/would change it to iterate between a file once I'm done with the UI changes I'm working on


delete unnecessary settings

There are some unnecessary setting in manifests.
Signed-off-by: YujiOshima<EMAIL_ADDRESS>

/assign @gaocegege


it seems the plugin is not compatible with vuejs3, or im not qualified to install it properly

i tried installing the plugin and adding it to my project.
once i tried the install cmd i got this error :
 npm install --save vue-advanced-chat
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vue
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/vue-advanced-chat
npm ERR!   vue-advanced-chat@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\Dell PC\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!      C:\Users\Dell PC\AppData\Local\npm-cache\_logs\2022-06-11T13_36_22_585Z-debug-0.log

while my understandings to vuejs 3 are still lacking, i believe it means the plugin cant be used for vuejs3

You have to install using this command:
npm install --save https://github.com/antoine92190/vue-advanced-chat/tarball/next
The version compatible with vue 3 is on the nextbranch.

Indeed, you need to use the next branch to use this plugin with Vue 3


Define license

MIT sounds great for this project!

Lgtm too

Added

+1 MIT

@rsomlette please comment here so I can assign you

@lubien i’ll add the license.md file tomorrow morning if that’s alright.

No problem @rsomlette take your time
Just wanted to you to comment here so I can do this:


[DS-3178] Submission still in workflow not shown in submitters My DSpace

https://jira.duraspace.org/browse/DS-3178
There was a wrong method called, I fixed the method call + documented the actual purpose of the method.

+1 obvious fix. Merging


⚠ Samsung has degraded performance

In cf614d4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2424 ms

Resolved: Samsung performance has improved in 489bb36.


New room visibility format refactor

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/32614
PROPOSAL: https://github.com/Expensify/App/issues/32614#issuecomment-1851610628
Tests

Click on '+' FAB.
Click on 'Start chat'
Select the '#Room' tab
Enter any name
Hover over the visibility menu item
Make sure the bottom line of additional text is a part of the menu item. ('People in your workspace can find this room')
Click on the visibility.
Make sure the titles of all options are bold.
Make sure changing an option also changes the additional text of the menu item.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on '+' FAB.
Click on 'Start chat'
Select the '#Room' tab
Enter any name
Hover over the visibility menu item
Make sure the bottom line of additional text is a part of the menu item. ('People in your workspace can find this room')
Click on the visibility.
Make sure the titles of all options are bold.
Make sure changing an option also changes the additional text of the menu item.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/77237602/c4d3428f-56e0-49a3-b98d-b7d0c88dd2d4

iOS: Native

https://github.com/Expensify/App/assets/77237602/a5db2c6c-634c-44d5-b64d-7611dcb3d6d0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/77237602/599058d0-d12c-44d6-aa24-af91f80345bc

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/77237602/c0e725fd-0d51-443e-a3f6-c1ecf5199743

MacOS: Desktop

https://github.com/Expensify/App/assets/77237602/445b4ea5-68d9-44e9-a878-18d0a4194d9e

Font size does not match the mock up

Spacing does not match the mock up

@s77rt As for the font-size in the menu item, it is the same style being used in the violations tab:

So, changing this would mean changes to this tab as well, it is possible to have the style props passed from the parent as separate but I think we should be consistent with how we handle all furtherDetails text in MenuItem. So, keeping all that in mind, should we change the styles.furtherDetailsText?
And does the spacing look fine now?

@esh-g I think we make the changes to be global

@shawnborton Need some help here:

Figma design for the selection list https://github.com/Expensify/App/issues/32614#issuecomment-1850797464

@esh-g Yes, let's work on it then apply any necessary changes later

Yes, let's work on it then apply any necessary changes later
@s77rt So, right now we should wait for design approval before making any change or should I increase the text size now and then wait for design approval later?

Let's increase the size first, I think the correct font size here is variables.fontSizeLabel

Made the change, this is how it looks in violations:

I'm sorry for my confusion here, can you catch me up?  So far as I can tell:

Is the question whether to change the global font size?  If so, I do not think we want to change any global fonts.  This is a very tiny, local change, let's follow the global styling, not change it.

Given that we're going to follow global stying, can you show what this looks like next to what the mockup asked for, side by side?  I suspect following global styling is just fine, but I'd like to see it.

Thanks!

Mockup vs PR

The "People in this workspace can find your room message" message shares the same stye with "Message hidden from channel, plus anonymous warning and message is reported for review" so you can see we had to increase the font size in order to match with the mockup. Do you think that increase in size is okay or we should keep that one untouched?

Please leave the abuse screen untouched.  The PR looks fine to me; let's stick with the global styling.

@quinthar I have opened a new PR for urgency (@esh-g does not seem online atm). https://github.com/Expensify/App/pull/33808 Can you merge it?

Ah I will defer to others to merge.  Thanks for the hustle, though!

@s77rt I am online now... should I just reverse the font change and merge this?

Works for me!
On Sat, Dec 30, 2023 at 6:40 PM Esh Tanya Gupta @.***>
wrote:

@s77rt https://github.com/s77rt I am online now... should I just
reverse the font change and merge this?
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/33717#issuecomment-1872653312, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMNUQ3IWCEKKNNELINTYTYMDGAVAVCNFSM6AAAAABBFXUVMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGY2TGMZRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@esh-g No. I have created another PR https://github.com/Expensify/App/pull/33808 to keep the flag page untouched. Can you please close this one?


Better error message for updating a hosted workflow

Feature Request
When you update a hosted workflow, the snackbar pops up saying "Updating hosted workflow succeeded".
The message should be more specific, e.g., "Saved version 6 of workflow my-awesome-workflow".
Although the doc talks about hosted workflows, the UI itself doesn't, so I feel like the word "hosted" is just slightly confusing in this context and we should just drop it.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Issue Number: DOCK-1004

Although the doc talks about hosted workflows, the UI itself doesn't, so I feel like the word "hosted" is just slightly confusing in this context and we should just drop it.

On this specific point, I feel like if the GUI is not making the distinction clear enough, we should make it more clear rather then erase the distinction.
i.e. we want users to be aware of the trade-off they're making (convenience vs. stability of real source control)

On this specific point, I feel like if the GUI is not making the distinction clear enough, we should make it more clear rather then erase the distinction.
i.e. we want users to be aware of the trade-off they're making (convenience vs. stability of real source control)

Good point... then I suggest "Saved version 6 of hosted workflow my-awesome-workflow"

Says Saved version 2 of hosted workflow exampleHostedWorkflow


Releases are in reverse order

The releases page is in reverse order. The latest release should appear on top.

Whoops Fixed, thanks for catching that!


[BugFix] Runtime fiter should use Brpc port not thrift port

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 4 / 4 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/qe/DefaultCoordinator.java
1
1
100.00%
[]

@Mergify backport branch-3.1

Related to #28029.


typo Fixed typos in hive.md

Proposed changes
typo Fixed typos in hive.md
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[x] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

Please rebase the code.

Please rebase the code.

Okay

run buildall


MSFT_SqlAGReplica  failed to execute Set-TargetResource functionality with error message: HADR is not enabled

    SqlServerLogin AddNTServiceClusSvc
    {
        Ensure               = 'Present'
        Name                 = 'NT SERVICE\ClusSvc'
        LoginType            = 'WindowsUser'
        ServerName           = $SqlNode
        InstanceName         = "MSSQLSERVER"
        PsDscRunAsCredential = $SqlInstallCredential
    }

    # Add the required permissions to the cluster service login
    SqlServerPermission AddNTServiceClusSvcPermissions
    {
        DependsOn            = '[SqlServerLogin]AddNTServiceClusSvc'
        Ensure               = 'Present'
        ServerName           = $SqlNode
        InstanceName         = "MSSQLSERVER"
        Principal            = 'NT SERVICE\ClusSvc'
        Permission           = 'AlterAnyAvailabilityGroup', 'ViewServerState'
        PsDscRunAsCredential = $SqlInstallCredential
    }

    SqlServerEndpoint HADREndpoint
    {
        EndPointName         = 'HADR'
        Ensure               = 'Present'
        Port                 = $portNumber
        ServerName           = $SqlNode
        InstanceName         = "MSSQLSERVER"
        PsDscRunAsCredential = $SqlInstallCredential
    }

SqlAGReplica AddReplica
{
Ensure                     = 'Present'
Name                       = $SqlNode
AvailabilityGroupName      = $avgGroupName
ServerName                 = $SqlNode
InstanceName               = "MSSQLSERVER"
PrimaryReplicaServerName   = $SqlPrimaryReplicaNode
PrimaryReplicaInstanceName = "MSSQLSERVER"
PsDscRunAsCredential       = $SqlInstallCredential
DependsOn                  = '[SqlSetup]InstallDefaultInstance'
}

You must enable AG with SqlAlwaysOnService resource.

I ran into this issue today.
Is it not worth adding this to the example here ?


Update Form1.cs

I reviewed code, pretty good, please see min file comments

I approved changes, but still need some more tweaks


Chat  notifications

Copy air bnb method.

User should be able to open old chat that he leave (when move was deleted) and rejoin (create move).
New chats between same users should be reopened ... regardless of group ages


Dogfood: Internal Production Clusters

When speaking to customers, we promote best practices, such as:

Fewer, larger clusters
Cluster promotion: Dev, QA, Prod
Separate CI Cluster Interacting with Dev, Qa, Prod
Right-Sized clusters
Use of virtual clusters

We need to operate in the same manner that we recommend to our customers.  This issue is intended to be a top-level issue incorporating the collection of capabilities needed to meet this goal.
Success Criteria:

Single set of operating clusters for CNCT. At least CI, DEV, PROD.
Cluster operations toolsets hosted on virtual clusters
All changes to clusters done on DEV and promoted to other clusters
CI chain automating promotion of virtual clusters across physical clusters
CI chain automating promotion of applications across physical clusters
Health and performance reporting on clusters

Comments welcome.

What of these criteria do you think our current common-tools production cluster meets?

moved to appropriate repo: https://github.com/samsung-cnct/issues/issues/31


Error when register name starts with "qreg" or "creg"

I found this bug :
when creating a quantum register with create_quantum_register or create_classical_register, if one gives a name starting by "qreg" or "creg" then subsequent execution of a program using this register raises an error.
Here is an example code to reproduce the error :
from qiskit import QuantumProgram
import Qconfig

qprogram = QuantumProgram()
qprogram.set_api(Qconfig.APItoken, Qconfig.config["url"])

qtoto = qprogram.create_quantum_register("qregbliblablu",5)
ctiti = qprogram.create_classical_register("ctutu",5)
qcircuit= qprogram.create_circuit("mycircuit",[qtoto],[ctiti])

qcircuit.h(qtoto[0])
qcircuit.measure(qtoto[0],ctiti[0])

qprogram.execute(["mycircuit"], "ibmqx_qasm_simulator", shots=1000, max_credits=5, wait=10, timeout=240)

Thanks for the report, @ChristopheVuillot! The parser seems indeed to lack robustness when handling tokens that start with reserved QASM words - we will look into this issue.

Closed via #83 - as usual, thanks for reporting and don't hesitate on reopening on filing a new issue if needed!


Add args to buildrelease.sh to rebuild docs post-release

When this is merged, I'll update the jenkins config to specify the new --ssh flag.

@evildour Awesome, thanks!


Add our line length convention

This is the result of the discussion(s)/forms we have had along with the excellent presentation by @mshafer-NI.

@mshafer-NI  @DavidCurtiss  @rtzoeller  sorry for the noise. Going to close this one in favor of #20, which spammed the group members correctly 🎉


Default order by timestamp to ensure early versions are cleaned

Addresses #699: 'cleaner' intermittently fails to keep the latest version because the query assumes but does not enforce chronological order. Postgresql exposes the assumption by failing the tests but not 100% of the time.
I had considered ordering by id instead of timestamp but was unsure about the reliability of that approach.

Very nice.  Personally I find ordering by ID more reliable since timestamps can end up equal.

How about order(PaperTrail.timestamp_field, :id) ?

Sure, that fixes the equality problem.  Does it have a benefit over sorting by id only?

If someone changed the assignment of IDs in their database I could see it being a problem, but having checked it looks like the table will always be created with monotonically-increasing IDs. @jaredbeck, any preference?

The documentation for the :keeping says:

:keeping - An integer indicating the number of versions to be kept for
each item per date. Defaults to 1.

Can you add something about how the one that's kept is the most recent?
For the sort order, I'd suggest order(PaperTrail.timestamp_field, :id) because it just makes sense to use timestamps for a chronological ordering. Scott makes a good point about timestamp equality, and adding the id as a secondary sort should give us deterministic results in that case.
Finally, please add a line to the changelog, under 5.0.0 -> Fixed. Thanks!

Done.

Thanks!

I believe we need should update this to use PaperTrail::Version.timestamp_sort_order. Apologies for the delayed response, just saw this, I'm happy to work that in tomorrow when I get a chance.

Made the aforementioned update: c2007210050a93223110a2b4fb4cf3a099c2755d

Thanks Ben. Good catch.


Typo

This sentence: "Deny assignments follow a similar pattern as deny assignments..."
Should've probably said: "Deny assignments follow a similar pattern as role assignments..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bc146ac-d530-fccb-0157-43cfcaeab937
Version Independent ID: 84376ebf-b328-39b0-5435-569a31c879e1
Content: Understand deny assignments for Azure resources
Content Source: articles/role-based-access-control/deny-assignments.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

@bvandersen
Thanks for your feedback! We will investigate and update as appropriate.

@bvandersen thanks for catching this! I made a pull request to fix this typo. https://github.com/MicrosoftDocs/azure-docs-pr/pull/79829
It should go live within 24 hours.


how to install all dependencies packages globally?

When I create react app then there's create node_modules with more than thousands of packages under app/project folder and if I create more than ten apps then node_modules folder creates for each app with thousands of packages. so this way repeating same node_modules folder with thousands of packages which is not a good idea I think. After a long time system getting slow down with millions of files and folder created by npm based projects. if node_modules run from globally then app/project will install quickly and no one package will install duplicated/repeated.
I want to install a node_modules folder globally with thousands of packages instead locally(under app folder) when create/install any app/project.
I have tried all way using global command Like:
npm -g install
yarn-g install
Let me explain what exact i mean: Suppose, If I create three react app
npx create-react-app my-app1
npx create-react-app my-app2
npx create-react-app my-app3
after setup all app, we get below like that node_modules with packages:
my-app1
-node-modules->p1,p2,p3....p999, so on..
my-app3
-node-modules->p1,p2,p3....p999, so on..
my-app3
-node-modules->p1,p2,p3....p999, so on..
See all same packages install multi times and repeating

Hi, @npscorpio  👋
The problem you're addressing is actually not related to Create React App but rather to npm and yarn. npm and yarn work like this by design.
There are benefits to managing dependencies locally, "All that is mine I carry with me“ approach. It makes projects self-contained, allows you to specify a versions of a dependencies for each project individually. This in the long run prevents situations where you struggle with "tangled mess" of global dependencies among apps. There might be other benefits as well, e.g. you can debug easily inside your dependencies.
This design never caused much pain to me, but I get your point. Maybe you could use symlink for your dependencies? I found one article that could be helpful: https://medium.com/dailyjs/how-to-use-npm-link-7375b6219557

Thanks @MiroslavJelaska!


Theming with bootstrap, etc.

Hi Ben,
Is there a way to theme the grid with particular css frameworks.
Let's say for example: Theme it with bootstrap and associate the grid with bootstrap css classes like:
table, table-bordered, table-hover, table-responsive, etc.. so that when my bootstrap theme changes, the grid's look and feel changes as well.
That would be really nice.
Cheers

@bencripps,
I looked at the documentation and I am suspecting that I might be able to do this just by overriding CSS_PREFIX and ClassNames properties of the grid.
But when I tried it, it seems like it ignores the overrides.
So the question is can I override both css prefis and classnames properties?
And if yes how exactly you do it?
I tried:
const cssPrefix = 'table';
const classNames = {
  ROW: 'row',
  ... // Rest of the names go here.
}
const config = {
  cssPrefix,
  classNames,
  ... // Rest of the grid config
}

return (
  <Grid {...config} />
)

but it seems like it is ignoring both cssPrefix and classNames!
Any advice?
Cheers

This is the intended design. All of the CSS classes are defined in the dictionary, and the CSS prefix is defined as a core constant.
The implementation has not been complete, which allows these variables to be configurable. We're currently working on drag and drop, and a couple other high priority bugs. Once these have been complete, I will finish up this enhancement.

Thanks @bencripps,
Looking forward to it.
Cheers

Any news on this @bencripps ?

@innopal working on it now! i'll let you know as soon as its ready.

ok @innopal clone down master. you will need to run npm run dist in order to get the built assets (since this is no longer a part of the source control). let me know if you have any issues, otherwise I can make a new release.

Thanks @bencripps ,
This is a game changer man! I'll play with it and get back to you asap.
Cheers

Very close Ben!
I found a couple of issues:

When you set the prefix to an empty string, it adds a hyphen to the beginning of all classes.
like -container.
Some class names seem to be used as a selector in your code so you cannot set them to empty, for example ROW. This is not a huge issue but needs to be documented.

It would also be nice to document a mapping of these classnames to popular css frameworks, For example a rough mapping for Bootstrap would be:
applyGridConfig({
    CLASS_NAMES: {
        TABLE: 'table table-sriped',
        TABLE_CONTAINER: 'table-responsive',
        CONTAINER: 'container',
        HEADER: 'header',
        ROW: 'row',
        CELL: 'cell',
        COLUMN: 'column'
    },
    CSS_PREFIX: ''
});

Cheers

Awesome! I will take a look at these bugs this morning.

@innopal I've fixed the CSS_PREFIX issue so that if you set CSS_PREFIX to false or '' it will not add the dash delimiter.
I also checked the rest of the source code for any reference to a 'react-grid' string literal, and I don't see anything that should be causing issues. Can you let me know more speficially what issues you're seeing with row?
Since you're working on getting the bootstrap example mapped, would you mind posting it in this issue thread so that others can use it when you've got it working?

one other note -- I set the row class to empty string, and that does create an error. But I think that's ok. If you don't want the default grid css, just change the row class to something else, that wont inherit any css.

Would you mind posting instructions on how to use this new feature? I'd also like to use Bootstrap styles with this grid (and I'm a react/redux newbie). Thanks!

Hi @bencripps ,
Sorry I've been swamped these days.
I got the latest and it works, so feel free to kick off a release.
For your users I you like to use bootstrap styling I;d just say:
Instead of the usage example in the document:
import { Grid, Store } from 'react-redux-grid'

const config = {
    store: Store,
    stateKey: 'unique-grid-id',
    ...data
};

const GridInstance = <Grid { ...config } />

Try this instead:

import { Grid, Store, applyGridConfig } from 'react-redux-grid'

const config = {
    store: Store,
    stateKey: 'unique-grid-id',
    ...data
};

applyGridConfig({
    CLASS_NAMES: {
        TABLE: 'table table-striped',
        TABLE_CONTAINER: 'table-responsive',
        HEADER_FIXED_CONTAINER: 'hidden',
        HEADER: 'header-bs',
        ROW: 'row-bs',
        CELL: 'text-left',
        COLUMN: 'column-bs',
    },
    CSS_PREFIX: '',
});

const GridInstance = <Grid { ...config } />

Cheers,

The only thing I would add would be to hide the error_container. The file config would be:
applyGridConfig({
    CLASS_NAMES: {
        TABLE: 'table table-striped',
        TABLE_CONTAINER: 'table-responsive',
        HEADER_FIXED_CONTAINER: 'hidden',
        HEADER: 'header-bs',
        ROW: 'row-bs',
        CELL: 'text-left',
        COLUMN: 'column-bs',
        ERROR_HANDLER: {
            CONTAINER: 'hidden'
        }
    },
    CSS_PREFIX: ''
});

Thanks!

I've added a bootstrap example to the demo page.
http://react-redux-grid.herokuapp.com/
The source is available here;
https://github.com/bencripps/react-redux-grid-demo/blob/master/app/public/dev/scripts/src/components/app/grid-container/Bootstrap.js


feat: Add parent tab to GalleryItemDescription

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #5673
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[ ] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 5ea0663
This pull request adds the functionality to display the parent NFT of a gallery item, if it exists, in a new tab on the gallery item page. It modifies the useGalleryItem function, the NFT interface, and several GraphQL queries to fetch and handle the parent NFT data. It also adds a new translation key and some styles for the parent tab.

🤖 Generated by Copilot at 5ea0663

Sing, O Muse, of the skillful code that added parent to the NFT
And how it fetched the metadata of the ancient and the new
With fragments and queries, the useGalleryItem function was enhanced
To show the nested NFTs and their origin in the gallery view

The 4 tab selection will be a bit tricky on mobile but I will deliver design for this, created follow up that will solve this:

#5754

@Matehoo can you share a link that you used for testing ?

@Matehoo can you share a link that you used for testing ?

if you mean what nft i used http://localhost:9090/ksm/gallery/17528332-3a4100ce6c6ae0292c-KDWINGS-RHAEGAL_GREEN_WINGS-0000000000000096

cc @Matehoo can you please resolve conflicts


--download supports multiple users

This way you can use it for multiples profiles with just one call
python3 pyinstastories.py -d "jacobsartorius" "gianluigibuffon"

Thank you for your contribution. 👍


Should suggest keywords

bash-language-server should include bash keywords in the suggestions list, otherwise pressing Enter at the end of this line will substitute gsf-office-thumbnailer

Thanks for reporting this. It has been fixed in<EMAIL_ADDRESS>and the latest VS Code client (version 1.7.0).

Thanks a lot for the fast turnaround!


Update year to 2016 in footer layout

Going back to the future

whatyearisit.jpg
Thanks for fixing this!


Fix local docker-compose support on Windows10

Local Docker-Compose was failing on Windows10 because of different, path related, problems.
Also note that the COMPOSE_FILE environment variable uses system specific path separators:

The COMPOSE_FILE environment variable can now contain multiple files, separated by the host system's standard path separator :slightly_smiling_face: on Mac/Linux, ; on Windows).

Released for preview in 1.9.0-rc2, to be published on Bintray.