Fix comment typo in threading.c

Fixes #5349
sorry about the exessive pull requests, its my first issue fix i have done.
Signed-off-by: Artur Allmann<EMAIL_ADDRESS>Notes:

Pull requests cannot be accepted until the PR follows the contributing guidelines. In particular, each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.
This is just a template, so feel free to use/remove the unnecessary things

Description
fixed typo in /library/threading.c
Status
READY
Requires Backporting
When there is a bug fix, it should be backported to all maintained and supported branches.
Changes do not have to be backported if:

This PR is a new feature\enhancement
This PR contains changes in the API. If this is true, and there is a need for the fix to be backported, the fix should be handled differently in the legacy branch

NO
Which branch?
development
Migrations
If there is any API change, what's the incentive and logic for it.
NO
Additional comments
again, sorry about the exessive commits and pull requests, its my first commit and i have been struggling with the signing part.
Todos

[ ] Backported

For future reference, you can use the commands
git commit --amend and git push --force-with-lease to fix issues with the topmost commit or commit message, and update the PR branch without having to open a new PR.

The signing troubles are most likely caused by having "Keep my e-mail address private" checked under the Github e-mail settings.
If you uncheck that, any future commits of yours should pass the DCO check.

2.28 Backport: #5670

The only CI failure is yet another instance of #5279 which can be ignored as far as the present PR is concerned.


Version 0.4.1 or 0.5.0 ?

Hi @vkosuri & @oleduc ,
I was about to publish a new version to PyPI but not sure which version number I should go with.
Was #86 a major or minor issue ?
Also @oleduc yes I would like it if you guys can help out here as I don't use RF anymore.

I say 0.4.1 as we didn't implement any major features. And great, we use RF and rf-requests very heavily at my workplace and we will continue to do so for the foreseeable future.

@bulkan i agreed with @oleduc will go with 0.4.1 before that we need finish below tasks

[ ] Pending PRs
[ ] testcase updation with latest changes
[ ] gh-pages updation

@oleduc Thanks !
I've pushed 0.4.1 to PyPI. I can always create another release when we merge more of the  PR's


crop function for existing image

hi, first of all its a great image picker lib. Anyway is it possible to use your crop function to photo that already in app?
Thank You

I'd like to know this too.


Fix empty argument "max-empty-rows" in xls script

We send argument "max-empty-rows" to two different script. In xls need to set, that this argument is available

@arodiss
Sorry, wasn't checked "xls" format. Pls, add this to previous tag.

@reggin
Forcing live repositories is not a good idea, so I added tag 0.5.8
Thank you for fix


Revert "Feature/265 - Freeform-text component"

Reverts Adobe-Marketing-Cloud/asset-share-commons#351

reverted this PR, seems to break search on AEM 6.5:
In the logs you can see that the QueryBuilder parameters look good but the resulting xpath query is way off...
[ com.adobe.aem.commons.assetshare.components.predicates.PagePredicate ] from cache
10.03.2019 16:37:46.772 *DEBUG* [0:0:0:0:0:0:0:1 [1552261066728] GET /content/asset-share-commons/en/light.results.html HTTP/1.1] com.adobe.aem.commons.assetshare.search.providers.impl.QuerySearchProviderImpl Query Builder Parameters:
2_group.0_path = /content/dam/asset-share-commons/en/public
2_group.1_path = /content/dam/we-retail/en
2_group.p.or = true
4_group.mainasset = true
5_group.property = jcr:content/contentFragment
5_group.property.operation = not
7_group.1_propertyvalues.2_values = video/quicktime,video/mp4
7_group.1_propertyvalues.operation = equals
7_group.1_propertyvalues.property = ./jcr:content/metadata/dc:format
orderby = @jcr:content/jcr:lastModified
orderby.sort = desc
p.guessTotal = 100
p.limit = 24
p.offset = 0
type = dam:Asset
10.03.2019 16:37:46.774 *INFO* [0:0:0:0:0:0:0:1 [1552261066728] GET /content/asset-share-commons/en/light.results.html HTTP/1.1] com.adobe.aem.commons.assetshare.core Service [com.adobe.aem.commons.assetshare.search.impl.predicateevaluators.PropertyValuesPredicateEvaluator,14401, [com.day.cq.search.eval.PredicateEvaluator]] ServiceEvent REGISTERED
10.03.2019 16:37:46.784 *INFO* [0:0:0:0:0:0:0:1 [1552261066728] GET /content/asset-share-commons/en/light.results.html HTTP/1.1] com.adobe.aem.commons.assetshare.core Service [com.adobe.aem.commons.assetshare.search.impl.predicateevaluators.PropertyValuesPredicateEvaluator,14401, [com.day.cq.search.eval.PredicateEvaluator]] ServiceEvent UNREGISTERING
10.03.2019 16:37:46.785 *DEBUG* [0:0:0:0:0:0:0:1 [1552261066728] GET /content/asset-share-commons/en/light.results.html HTTP/1.1] com.adobe.aem.commons.assetshare.search.providers.impl.QuerySearchProviderImpl Executed query statement:
(/jcr:root/content/dam/asset-share-commons/en/public//element(*, dam:Asset)[(not(jcr:content/@contentFragment))] | /jcr:root/content/dam/we-retail/en//element(*, dam:Asset)[(not(jcr:content/@contentFragment))]) order by jcr:content/@jcr:lastModified descending

FYI @davidjgonzalez


[BUG] Bogus "Expected Spec to be in the canonical form Init /\ [][Next]_vars"

Reported as not in canonical form:
VARIABLE x
Init == x = TRUE

Spec == Init /\ [][UNCHANGED x]_x

Works fine:
VARIABLE x
Init == x = TRUE
Next == UNCHANGED x
Spec == Init /\ [][Next]_x

With APALACHE version 0.11.1-SNAPSHOT build v0.11.0-17-gf55663c

Spec == Init /\ [][TRUE]_x

also not accepted.

Right. Now Apalache is expecting an operator name like Next. A similar issue has been raised by @Quantifier

Closing this, as it is effectively a duplicate of #468


feat: Added About Page

Description
I have Added About Page as per the website's current style
Fixes #221
Checklist

[x] Tests have been added or updated to cover the changes
[x] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

The Ui of about page not good as expected !
The mistake you did , you created a about page on navbar instead the about page is already there in footer page , so mention the path from footer page and cancel down the about page from navbar

@thestarsahil
I have updated the About Page UI
Made it look attractive
and I have also added animations to it

Nice Work  ! but about page have to open in every section either in any page
You mentioned to open when dashboard open , please change the navigation and this also conflicting with other pages
Fix it also

@thestarsahil
I will do that once the number of page increases since the website has only dashboard and about page till now
Later I will make a navbar component which could be imported in all
Please merge it for now
I need points for my IWOC

First pic is original ones but after adding the about page its effect in all overall pages ( second pic )

I'll fix it in my next PR @thestarsahil

@thestarsahil I have added About Page in footer component so it will be automatically imported wherever Footer is imported
Please merge it

@thestarsahil
I have made the changes as you said
Kindly review it

Can you check the changes done by some other contributor made for about page

@thestarsahil I have already corrected what you said

The page added sucessfully but the code having problem which effect other , but we sort it later
Now I am merging

@thestarsahil Can I start working for Contact page now?

Sure and please make sure that contact page not to conflict with other pages


Update scss-lint properties for v0.38.0

We’ve updated our scss_lint gem to the latest version, and this
required us to update some of the properties here. We also added and
turned off new ones.
This pull updates the config to keep in line with the rest of our
codebase.
@mdo @primer/owners

Is the (re?)addition of the severity: errors specific to the upgrade? I thought we used to have those, but removed them at some point.

Is the (re?)addition of the severity: errors specific to the upgrade?

yes our ci setup treats them all as warnings if it's not specified.

:thumbsup: Cool, thx.

Are all those Hound checks good to go then?

Are all those Hound checks good to go then?

yeah ignore those.


Transitive dependency modules need to be explicitly imported in the app

This app depends on two packages: pg and sql.
The sql package also depends on  Pg.Cmd and Pg.Result from pg, so its main.roc's package header references it.
The app depends on Pg.Client directly, but it only depends on Pg.Cmd and Pg.Result transitively through Sql, so it shouldn't require imports to these.
However, if we don't import them in the app, we will get a compiler error like the following for every reference on Sql:
── MODULE NOT IMPORTED ─────────────────────────── sql/examples/../src/Sql.roc ─

The `Pg.Cmd` module is not imported:

240│      { options & limit: [Raw " limit ", Param (Pg.Cmd.nat max)] }
                                                    ^^^^^^^^^^

Did you mean to import it?

The Sql module includes imports to Pg.Cmd and Pg.Result, so those references should be ok.

I think this is caused by the compiler sharing ModuleIds across packages

Fixed by #6658


Add CODEOWNERS file

From the GDS Way:

Consider protecting the .github/workflows folder by using a CODEOWNERS file and requiring review from CODEOWNERS for merges into protected branches.

Closed by #20 . I have enabled 'Require review from Code Owners' in Settings


Incorrect url in ActionLinkButton with RouteName

I don't seem to be getting the correct url if I try to reference a named route. So when I use
@Html.Bootstrap().ActionLinkButton("Edit", "").RouteName(ManageSitesControllerRoute.GetEditSite).RouteValues(new { id = "test" })
I get a button with a destination address of: http://localhost:49518/home/manage-sites/edit-site/test/test/
When I use: @Html.RouteLink("Edit", ManageSitesControllerRoute.GetEditSite, new { id = "test" })
I get an ordinary link with the (expected) destination address of: http://localhost:49518/manage-sites/edit-site/test/
It appears to have added the "home" part to the path and an extra copy of the route variable. Do I need to do something else to use named routes?

Thanks for submitting this bug. Was kind of surprised nobody stumbled across this before.
In any case, this is fixed. Please get latest.

Thanks for tackling this so quickly; it is much appreciated!
I pulled the latest. Now when I have:
@Html.RouteLink("Add User", AccountManagerControllerRoutes.GetNewUser)
@Html.Bootstrap().ActionLinkButton("Add User", "").RouteName(AccountManagerControllerRoutes.GetNewUser)
The first generates the expected link, but the second generates an empty href.
If I use @{
var b = Html.Bootstrap().ActionLinkButton("Add User", "").RouteName(AccountManagerControllerRoutes.GetNewUser);
}
I can inspect b and see:

So the ActionName property has the correct link url. But unfortunately the rendered anchor tag doesn't appear to get it.

Could you please show me what your route AccountManagerControllerRoutes.GetNewUser looks like? I haven't done much RouteLinks in MVC development, so it's a bit of an uncharted area for me.

New for me too. I haven't done much in ASP.Net and found this template that seems to have a lot of useful things built-in: https://visualstudiogallery.msdn.microsoft.com/6cf50a48-fc1e-4eaf-9e82-0b2a6705ca7d  Has worked straight out of the box.
Then AccountManagerControllerRoutes.GetNewUser is a string constant equal to "AccountManagerGetNewUser" that names the route in some lookup table (they have to be unique).
The controller and methods get attributes:
[Authorize(Roles = StandardRoleNames.Administrator)]
[RoutePrefix("AccountManager")]
public class AccountManagerController : Controller
{
:
:
[HttpGet]
[Route("new-user", Name = AccountManagerControllerRoutes.GetNewUser)]
public ActionResult NewUser()
{
var Model = new EditAccountModel { AccountLocked = false, DailyReport = true };
return View(Model);
}
:
And the routes are setup like this:
public static void RegisterRoutes(RouteCollection routes)
{
:
:
// Enable attribute routing.
routes.MapMvcAttributeRoutes();
  // Normal routes are not required because we are using attribute routing. So we don't need this MapRoute
  // statement. Unfortunately, Elmah.MVC has a bug in which some 404 and 500 errors are not logged without
  // this route in place. So we include this but look out on these pages for a fix:
  // https://github.com/alexbeletsky/elmah-mvc/issues/60
  // https://github.com/RehanSaeed/ASP.NET-MVC-Boilerplate/issues/8

#if false
routes.MapRoute(
name: "Default",
url: "{controller}/{action}/{id}",
defaults: new { controller = "Home", action = "Index", id = UrlParameter.Optional });
#endif
I disabled the MapRoute as that seemed to be making the problem worse & I could live without some of that error logging to use your add-in.
Is it possible that after resolving the route and placing it in ActionName that it tries to look up a route for that action name? It would come up empty.

Hello again, I put a simple project that illustrates the problem here:
https://www.dropbox.com/s/68tk3p88x3ey9wg/WebApplication1.zip?dl=0

The demo helped a lot, thanks.
This should be fixed. Please get latest.

Thanks Dmitry. That seems to have solved it. I appreciate all your work on this project. It makes building sites much faster!


After Taking picture getting only 2 or 3 cropping dots

After Taking picture getting only 2 or 3 cropping dots to crop  we can crop the pic by having four cropping dots Please solve my issue

this is the issue with openCV library. not you need to have a decent contrast difference in background and the paper you are scanning or else it will not be able to detect all the corners for the cropping.


Standardize capitalization of library name and other edits

Other edits included replacing dev doc links with stable doc links

Thanks for the changes 🙂
Merging


Dockerfile: Upgrade base distro to Ubuntu 16.04, fix support for JDK8

Fix current broken build introduce with JDK upgrade from #1888 of docker simulator because of missing dependencies and JDK8. This PR upgrade the distro to Ubuntu 16.04 and use default jdk version 8.
I've quickly test the build locally, no error in the UI and logs.

LGTM, did not test it.

docker specific. merging.


Decrease build time when switching copts

As has been explained by @mcevoypeter, switching a bazel build's command line copt switch rebuilds all dependencies which is a pain when you're testing vere's behavior with/without a given copt, e.g. --copt="-DU3_MEMORY_DEBUG"
I think an option for this would be defining aliases that do a per-file copt instead of a global copt. See https://bazel.build/docs/user-manual#per-file-copt
The per file copt can be used to scope the copt. Doing this manually would be tedious though. Can we define some sort of alias? We could always wrap the bazel commands in a Makefile.
Including @joemfb
@matthew-levan for his thoughts as well

@mcevoypeter I think that's a good idea. I didn't know multiple configs could be specified. In fact, wrapping all configurable macros like that is probably a good idea.


Differential Expression link - brings you back to homepage

Brings you here:

Here is what the first picture should be:

this was a part of the homepage prototype and we are not using this.


Built-in System.Drawing.Image and Bitmap methods

Theres a repeating need for methods to load Image to bitmap, we should provide performant builtin API for that.

Yes, many people need it. It helps.

Just a DLL contained in the .NET Framework so we won't need to add any nuget-packages.
I'm talking about new NDArray(System.Drawing.Image) or something of that sort.

Thanks for all the hard work.
My 2 cents.   It might be worth considering the pros and cons of keeping System.Drawing.Image outside of the core NDArray through a factory approach. At some later date you might consider introducing a factory class  for images loaded using ImageSharp or some other imaging library.
This approach will not cut down your code, however it might spare end developers from having to add too many NUGET references. Gives them the opportunity to progressively encompass more packages as the needs grow.  E.g. In my company, System.Drawing is not really favored because it does not work on Azure functions due to GDI+ restrictions of Azure function sandbox.

@sdg002 Thanks for the note,
I've decided to create separate repositories and nuget packages for NumSharp.Bitmap and NumSharp.ImageSharp.

@ sdg002 Cảm ơn bạn đã lưu ý,
tôi đã quyết định tạo các gói nuget và dự án riêng biệt cho NumSharp.Bitmap(xuất bản) và NumSharp.ImageSharp(WIP).

i try using imgArr = bitmap.ToNDArray(); not work and get this error
NumSharp.IncorrectShapeException: 'Given shape size (198000) does not match the size of the given storage size (264000)'

@unominhtuan Please open a separate issue with reproducing code.

Is it possible to integrate OpenCvSharp into NumSharp.ImageSharp?


Check if date or date containing string has 12h (am pm) or 24h format

I've faced a necessity of checking current device's time display settings, exactly 12/24h format.
What about having such kind of extensions both for Date and String types?
extension Date {

    var is12HourFormat: Bool {
        let dateFormatter = DateFormatter()
        let dateString = dateFormatter.string(from: self)
        return dateString.contains(dateFormatter.amSymbol) || dateString.contains(dateFormatter.pmSymbol)
    }
}

extension String {

    /// Check if string can be formatted as date and if it has 12 hour format.
    /// Returns nil if string isn't a date, and true or false if it has 12 hour format or not.
    var is12HourFormat: Bool? {
        let dateFormatter = DateFormatter()
        let date = dateFormatter.date(from: self)
        return (contains(dateFormatter.amSymbol) || contains(dateFormatter.pmSymbol)) && date != nil
    }
}

@DimaZava Thanks for bringing this :)
The AM or PM time is coming from the DateFormatter and not from Date, if we have the same date on different devices with different Locale we will get both is12HourFormat  and is12HourFormat true for the same date 🤔

I think it makes more sense for this to be a Locale extension. Something like
extension Locale {
    var is12HourTimeFormat: Bool {
        let dateFormatter = DateFormatter()
        dateFormatter.timeStyle = .short
        dateFormatter.dateStyle = .none
        dateFormatter.locale = self
        let dateString = dateFormatter.string(from: Date())
        return dateString.contains(dateFormatter.amSymbol) || dateString.contains(dateFormatter.pmSymbol)
    }
}```

@guykogus I think it's better idea than mine. If you don't mind I can create PR for it


Sphinx(it) deploy of doc

@AFg6K7h4fhy2, I've opened the PR for you. I think we are almost there to merge. I'll check on the github-pages environemnt to ensure all works OK (and delete the github-pages-test environment.)

This is ready for review. We can figure out the details later on. The only thing I would double-check is that we are not adding any file that is not human-generated. @AFg6K7h4fhy2, can you double-check that?


Injector and Router tree merged

will resolve #177 and #178

this can be closed as it's addressed in two separate PRs #233 and #219


script create_warps.py resource management

Proceeding as discussed in https://github.com/khanlab/hippunfold/issues/92

Currently, the max matrix size is set to 200200200 = 8M. In space-corobl, matrix size is 128256128 = 4.2M.
Could perhaps set the max matrix size even larger, though in my other test cases this hangs (despite never reaching even close to memory limit).
Another quick note: its not actually the matrix size that matters but the number of GM voxels (which in my ex-vivo case was 456K after downsampling. In space-corobl this is typically ~80K). This could vary quite a bit depending on the sample, so matrix size is probably a better basis for downsampling.

After spending a long time trying to get this step (and the next) to work on 3D PLI and BigBrain data at super high resolution, I realized the issue wasn't memory. I'll leave https://github.com/khanlab/hippunfold/tree/create_warps_resource_manage as is in case we need further memory management (in this case by downsampling) in the future.
The actual issue is outlined here:
https://stackoverflow.com/questions/10886971/alternatives-to-scipy-interpolate-griddata-that-dont-hang-on-aligned-points
I created a new branch with this fix: https://github.com/khanlab/hippunfold/pull/95

Closing this PR as it is no longer needed, but may be useful if we need downsampling to manage memory in the future!


Sample App and Integrated App crashes when entering foreground

App crashes when entering foreground. Works fine if i don't switch to any other view controllers but if i switch to a view controller other than the initial one presented it crashes when entering foreground from background. Never reaches the app delegate function  "applicationWillEnterForeground(application: UIApplication)"
Sample app provided crashes using FoldingTabBar
Custom app crashes using FoldingTabBar
Error Code: *** -[Not A Type CA_copyRenderValue]: message sent to deallocated instance 0x141241830
Specs:
Using version 'FoldingTabBar', '~> 1.0.7'
Apple Swift version 2.2 (swiftlang-7<IP_ADDRESS> clang-703.0.31)
I have the latest version of CocaoaPods - cocoapods-1.0.0
Swift Project with Bridging Header
Iphone 6 Software Version 9.1

Workaround (if you don't using new features)
 'FoldingTabBar', '~> 1.0.6'

When i enter pod 'FoldingTabBar', '~> 1.0.6' that into my pod file it still downloads the version 1.0.7...... I even tried 1.0.5

I also did a manual installation of version 1.0.6 and the app still crashes when returning to the foreground.

Hi @imanodaysoffdotcom, @schuleplus! Thanks for reporting the issue. It's fixed in a new release


How can I ues visual tools such as Grad-CAM while use tao training models

After finish training model,I get a very high accuracy and I want to see where the focus of the model is.Before this,I used to use Grad-CAM to see this,but I find tao can't use such tool.So please give me some advice about how can I see the foucus of model

@Frankieljy11, The new nvidia tao 5.0 supports this, since they have made nvidiatao opensource.


R predict error : object 'lower' not found

library(prophet)
df <- read_csv("https://raw.githubusercontent.com/facebookincubator/prophet/master/R/tests/testthat/data.csv")

m <- prophet(df)

future <- make_future_dataframe(m, periods = 365)

forecast <- predict(m, future)
head(forecast)

That above code (essentially lifted from the prophet quick start) fails on the call to predict:
Error in overscope_eval_next(overscope, f) : object 'lower' not found

 R.version
               _
platform       x86_64-redhat-linux-gnu
arch           x86_64
os             linux-gnu
system         x86_64, linux-gnu
status
major          3
minor          3.2
year           2016
month          10
day            31
svn rev        71607
language       R
version.string R version 3.3.2 (2016-10-31)
nickname       Sincere Pumpkin Patch

Same error on OSX:
> R.version
               _
platform       x86_64-apple-darwin15.6.0
arch           x86_64
os             darwin15.6.0
system         x86_64, darwin15.6.0
status
major          3
minor          4.0
year           2017
month          04
day            21
svn rev        72570
language       R
version.string R version 3.4.0 (2017-04-21)
nickname       You Stupid Darkness

Both use prophet v0.1.1

Dependency purgatory, fixed by
devtools::install_github("hadley/dbplyr")
devtools::install_github("facebookincubator/prophet/R")

Probably prior addressed by https://github.com/facebookincubator/prophet/commit/2bb5827303ba2dc061b3b6c70481e8c0389a0e0f
Closing


Failed Autorest Regen Preview to 3.0.0-alpha.20231024.1 by Patrick Hallisey from refs/pull/3862/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3862

API change check
API changes are not detected in this pull request.


Missing Images in Summaries

Images for summary numbers 53 and lower are missing from the web app (on both common and individual summary pages). This might be an issue with Deta (our current hosting provider) due to limited upload sizes (which has been an issue before), but is an assumption. Let's see if this issue persists once we migrate our web app (#207).

Cc: @KartikSoneji, @SirusCodes

That's because of now we are getting images directly from githubraw. I was too lazy to update paths for all such edge cases🙃


Make example and error texts in accordance with behaviour

Current behaviour:
$ jx application delete
Error: failed to validate options: missing option: --name
---

$ jx application delete --name app
Error: unknown flag: --name
Usage:
  jx-application delete [flags]

Examples:
  # deletes the application with the given name from the development cluster
  jx application delete --name myapp

  # deletes the deployed application for the remote production cluster only
  jx application delete --name myapp --env production

  # deletes the application with the given name with the git owner
  jx application delete --name myapp --owner myorg

  # deletes the deployed applications but doesn't remove the '.jx/gitops/source-config.yaml' entry - so new releases come back
  jx application delete --name myapp --owner myorg --no-source
---

/assign @rawlingsj

/lgtm


add support for step files

massflowrate and temprature timestep files are in sim folder not in temp, others would show up in temp
they dont have a period, coulum they use TIME (TO BE CLARIFIED)
reading of timestep can be omitted by user
all timestemp files should be put in the same dataframe
histogram ususally uses the T.prt(temprature timestemp file)

Shouldn't this be in https://github.com/SPF-OST/pytrnsys_process?
Yes, sorry it likes to select gui instead of process


Add endpoint aggregation capability

Add endpoint aggregation capability
* replace the concept of labels associated to a sample with the concept
of context. Context can be any JS object and is associated with a
sample.
* stop takes an optional function that generates labels from a context.
* Profiler now exposes a state attribute which is a UInt32Array that
allows sharing some profiler state directly. Currently only index 0
(kSampleCount) is used and return the number of samples taken.

All good, two minor points though:

I would've appreciated a separate commit with just the nomenclature change (labels -> context), that would've made the significant changes stand out better.
We can keep mutateContext, but if we don't think we'll use it, removing it is also an option.

I split the PR into 3 commits and removed mutateContext.

I split the PR into 3 commits and removed mutateContext.

Thank you, although I didn't expect it for this PR retroactively – I have already reviewed it in its original form after all :-) Just something to keep in mind as a good practice going forward when doing these kinds of lexical changes that touch many lines.


chore(fix): Close unclosed file handle

Description
This is a recreation of #11234 with a rebase, so that CI can build it.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed
Here I tell how I validated my change

[ ] CI

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test gke-nongroovy-e2e-tests


Suppress extraneous extra files warning in CI

Previously, notify jobs in genesis ci had a large window for false
positives for the warning when an environment file was added to the
repo. Reined that in a little bit, by not warning if non-cached files
are identical.

This addresses #432


[INLONG-8042][CI] Update the CI workflow to avoid the network being unreachable

Prepare a Pull Request

Fixes #8042

Motivation

Maven http connection reset on GitHub Actions VMs.
Maven is switching to "Maven Resolver" ("aether") in newer versions instead of using Wagon.

Modifications

Disable Maven http connection pooling also for aether
Set request timeout to 60000ms also for aether

Also, I changed the link to the inlong project in idea/vcs.xml

please remove .idea/vcs.xml


Force /usr/bin/sed usage in setup script

Sometimes developers have installed GNU sed as their primary sed command. However, it doesn’t work with how we pass arguments in the setup script.
This pull requests forces the setup script to use /usr/bin/sed.

🦀 Requesting reviewers for this pull request:

@loboulet (contributor with 0 commits in the last 90 days and 22 commits overall)


Agda files are not Markdown files

#121 highlights all Agda files (Agda, TeX, rST, etc) as though they were Markdown. They are not

Fixed by #148.


update

Please read the submission instructions carefully. Otherwise I could not merge your PR (0 grade for code).


Primary key, MergeTreeIndexFullText and MergeTreeIndexSet support for string functions

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

New Feature

Short description (up to few sentences):
Added support startsWith, endsWith, multiSearchAny, notLike for MergeTreeIndexFullText.
Added support startsWith, endsWith, multiSearchAny for MergeTreeIndexSet.
Added support empty, notEmpty, notLike for Primary key.

I have a test for primary key as well, should I add it after checks are completed?


Rejected Mentors shouldn't be able to access manage mentee view

Describe the bug

Currently, Manage mentees UI is accessible for rejected Mentors

To Reproduce
Steps to reproduce the behavior:

Go to Home
Click on 'Manage' button
See the UI

Expected behavior

Remove the Manage button for rejected mentors

Screenshots

Desktop (please complete the following information):

OS: MacOS Monteray
Browser: Chrome

Assign this to me :)

Assign this to me :)

sure

@kumuditha-udayanga can you check if this bug is still there or not?

@Gravewalker666 This bug is still valid.


Fix MPS support for MAE metric

What does this PR do?
Fixes #1209
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Haha, I misread and just fixed it myself. Was about to check in the PR and then I saw this.
Btw your fix doesn't fix it.
TypeError                                 Traceback (most recent call last)
Cell In [4], line 4
      1 a = torch.tensor([1, 2, 3]).to(torch.device("mps"))
      3 mae = torchmetrics.MeanAbsoluteError().to(torch.device("mps"))
----> 4 mae.update(a, a)
      5 mae.compute()

File ~/Desktop/metrics/src/torchmetrics/metric.py:391, in Metric._wrap_update.<locals>.wrapped_func(*args, **kwargs)
    389 with torch.set_grad_enabled(self._enable_grad):
    390     try:
--> 391         update(*args, **kwargs)
    392     except RuntimeError as err:
    393         if "Expected all tensors to be on" in str(err):

File ~/Desktop/metrics/src/torchmetrics/regression/mae.py:63, in MeanAbsoluteError.update(self, preds, target)
     56 def update(self, preds: Tensor, target: Tensor) -> None:  # type: ignore
     57     """Update state with predictions and targets.
     58
     59     Args:
     60         preds: Predictions from model
     61         target: Ground truth values
     62     """
---> 63     sum_abs_error, n_obs = _mean_absolute_error_update(preds, target)
     65     self.sum_abs_error += sum_abs_error
     66     self.total += n_obs

File ~/Desktop/metrics/src/torchmetrics/functional/regression/mae.py:34, in _mean_absolute_error_update(preds, target)
     32 diff = preds - target
     33 diff = diff if diff.is_floating_point else diff.float()
---> 34 sum_abs_error = torch.sum(torch.abs(diff))
     35 n_obs = target.numel()
     36 return sum_abs_error, n_obs

TypeError: Operation 'abs_out_mps()' does not support input type 'int64' in MPS backend.

I suggest just changing it to
def _mean_absolute_error_update(preds: Tensor, target: Tensor) -> Tuple[Tensor, int]:
    """Updates and returns variables required to compute Mean Absolute Error.

    Checks for same shape of input tensors.

    Args:
        preds: Predicted tensor
        target: Ground truth tensor
    """
    _check_same_shape(preds, target)
    sum_abs_error = torch.sum(torch.abs(preds.to(torch.float32)) - target.to(torch.float32))
    n_obs = target.numel()
    return sum_abs_error, n_obs

which fixes it.

That's fair @justusschock
And yeah, you probably have to do that check before you compute the diff, i.e., reverse the order in
diff = preds - target
diff = diff if diff.is_floating_point else diff.float()

so that it's more like
preds = preds if preds.is_floating_point else preds.float()
target = target if target.is_floating_point else target.float()
diff = preds - target


Any plans to add an SQS hook and SQS Sensor?

I would add the following actions to the Sensor?

Check for new message
Check for empty queue
Check for non-empty queue

Wouldn't SQS make most sense as a broker for Celery? Seems like it may doable from this old article here:
https://www.caktusgroup.com/blog/2011/12/19/using-django-and-celery-amazon-sqs/

It does make sense for use with Celery, but that is a different use-case than what I have in mind.
But, our data pipeline uses SQS : Agari's Data Pipeline
We use SNS+SQS actually - we publish S3 object-created notifications over SNS+SQS. SNS has push-based topics with 0 day message retention and SQS has pull-based queues with max 14 day message retention. When we publish to SNS, SNS pushes to multiple SQS queues. We have several data importers that load this data into different DBs.
So, as  part of my data pipeline, I would like to detect that a queue receives a message (it signals that it is receiving data). If that sensor returns true, I advance to the next stage : checking whether my db is receiving data. If that passes, I advance to checking if the SQS queue is drained (end of data load). If any of these fail, I want email notification. If the last step succeeds, I would like to send a "Data Load Successfully Completed" email notification.

Interesting! An alternative would be to check on whether the file exists in s3 (you may have to use a trigger file to signify the file is fully loaded, or load into a tmp key and rename it).
But I know nothing about your setup so I'm sure you have a much better understanding of the components you need. BTW it's very easy to create hooks and operators, and we're excited for the community to extend the portfolio of external systems we integrate with.


Viewer.fitTo multiple MolView objects

What is the best way to center a viewer on multiple MolViews across multiple structures?
Is it possible to combine MolViews into one object on which I can call Viewer.fitTo?
Would you consider an extended method signature for Viewer.fitTo that centers the viewer on the centroid of an arbitrary number of objects?

Looking at the code, this should already be possible. Have you tried to pass an array of mol views to fitTo?

Works perfectly. Sorry, I assumed only one MolView could be fitTo based on the docs. Thanks for explaining!

Hmm, in that case the docs are not accurate enough. I'll add the list-based fitTo signature to the documentation


Add book in author schema

#    books: [Book!]! TODO: bring this back
In the Author schema, uncomment the books line and get it to work. It should be possible to find all of the books that belong to a particular author

Hello! Can I work on this task too?

Hello, sure. Thanks!

I have a question before I start working on this. For returning the books of an author can I use the findAllAuthors method that already exists or I should create a new method that will have inputs the first name and last name of the author and return only the book list of that author?

I don't think you'll need that method. You may want a findByAuthor method in the BookRepository, though


Docs say "--projFile" is default argument, but it needs to be explicit

Description
The docs say you can just do fable foo.fsproj instead of fable --projFile foo.fsproj.  But when I try that I get
Unhandled Exception: System.InvalidOperationException: The input list was empty.

   at Microsoft.FSharp.Collections.FSharpList`1.get_Head()
   at Fable.Main.readOpts@15(FSharpMap`2 opts, FSharpList`1 _arg1) in C:\GitHub\
dsyme\Fable\src\fable-fsharp\Main.fs:line 18
   at Fable.Main.readOptions(String[] argv) in C:\GitHub\dsyme\Fable\src\fable-f
sharp\Main.fs:line 26
   at Fable.Main.main(String[] argv) in C:\GitHub\dsyme\Fable\src\fable-fsharp\M
ain.fs:line 148

Ah, ok, you're using directly Fable.exe. The docs only cover when you call the node bootstrapper instead, as this normalises the arguments before sending them to the .NET/Mono process. There're also some arguments that don't apply to Fable.exe, neither will it read directly fableconfig.json by itself.
If you've built the project yourself, to run the node bootstrapper, you'd have to do something like (from the project root folder):
node build/fable path/to/foo.fsproj

Note: This is equivalent to node build/fable/index.js. Node will load index.js by the default when you pass a directory.

If you don't have node installed you can just download the binary from nodejs.com.
I hope this helps, please tell me if you've any other question and thanks a lot for checking the tool!


fix: build-label description

Add a closing parenthesis to buildLabelDesc.

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MAISTRA-1153: adds ability to read pods and services for ior

Whoops, what @jwendell said.  Change looks good, but charts need to be regenerated or it won't get applied on install.

Whoops, what @jwendell said. Change looks good, but charts need to be regenerated or it won't get applied on install.

Sure, will do. Can this be automated though? i.e. GitHub action / prow job reacting on certain file changes should do the job, right? This way we always going to have consistency.

Something is not right with this target, gettings following changes all over the place
-    maistra-version: 1.1.0
+    maistra-version: 1.0.5

make sure to run that command while checked out at ior_roles branch

make sure to run that command while checked out at ior_roles branch

I did. It turned out that I had MAISTRA_VERSION env var exported for some earlier shell-fu I was fiddling with and that is used by this target as well.


Requirement simplification and updates

Adjusting requirements to make more compatible with other packages like msticpy and bumping version # to 0.1.8

hey @adonm!
I knew about this problems, but I was waiting with my other local changes to be commited. I'll get into it in the beginning of the next week

@adonm hey again!
I've made some changes and applied it here https://github.com/streanger/abuseipdb-wrapper/commit/98da4f659cd2065420960dccea2f91d4e2e6b8bd. I also bumped pypi version to 0.1.8
First thing you might be interested in is to change param API_KEY (uppercase) to api_key (lowercase) as in the code below:
from abuseipdb_wrapper import AbuseIPDB
API_KEY = 'YOUR_API_KEY'
abuse = AbuseIPDB(api_key=API_KEY)

Second thing is requirements. I adjusted them using >= to meet current and latest versions of packages.
https://github.com/streanger/abuseipdb-wrapper/blob/7d4771e104825986983c4641a250cab675f4722e/setup.py#L18-L27
Please give a try and let me know if it fit your needs. I'm gonna fix one more bug soon, so I'm open to any changes proposal

Hi @streanger - I've tested and this is great for our needs =). Note I saw a small bug in CI for the import related to the tor_enrich module but not an issue for us with interactive use:
https://github.com/streanger/abuseipdb-wrapper/blob/main/abuseipdb_wrapper/tor_enrich.py#L11 - sometimes (e.g. in a CI job) sys.stdout.encoding can be none which causes base import to fail.
Thanks again!

https://github.com/streanger/abuseipdb-wrapper/blob/main/abuseipdb_wrapper/tor_enrich.py#L11 - sometimes (e.g. in a CI job) sys.stdout.encoding can be none which causes base import to fail.

thanks for pointing this out. It was meant to check if specific terminal handles encoding of this character. However it didn't work at all. And in the next version (0.1.9) I removed imports related to tor_enrich due to existing of isTor field supported by abuse api. So I hope for now it shouldn't be a problem at all.

As of yesterday I released version 0.2.0, where I get rid of pandas dependency, in place of custom export functions. I realized that some packages are too heavy, and use of single function is not enough in that case. I think that last changes shouldn't affect other important parts of code. At least tests are passing :)
And for now I'm not planning any other releases until someone will ask for update and I find time for it.
Thanks for your interest!


Expected result on Kafka/ZK/network failure?

I'm trying to ensure the fact that one of my services which use

kafka-node Client
kafka-node HighLevelProducer
kafka-node HighLevelConsumer
is resilient to kafka/zk/network failure. In this case, all I need to know is that it will continually retry to connect to the kafka/zk services and log every time it tries/fails to reconnect.

I thought I could achieve this by setting .on('error' ...) handlers on my Client, HighLevelProducer, and HighLevelConsumer. Unfortunately this does not seem to be showing me any information about disconnections.
For info, I am simulating a failure by:

docker-compose up (on ZK and kafka together)
start my Client, HighLevelProducer, and HighLevelConsumer
register error listeners on each
docker-compose down (on ZK and kafka together)

This case is not emitting any error events I would expect.
How should I best enforce that my objects reconnect and that they log all disconnects and all reconnect retries?

There's code in kafka-node to recover from network issues. Though there's an open issue (#469) about this not working properly for producer (very possible the recovery was mainly focused from the consumer perspective).
If you are interested to know about connection changes you could listen for reconnect and connect events on the client. Unfortunately there is not an event for disconnects but you will likely get a socket level error emitted on your consumer/producer. In your case you should  expect to receive lots of ECONNREFUSED errors. If you aren't seeing these I would verify the consume/producers are connected before the containers were taken down.
And I would encourage a migration to ConsumerGroup if possible. HighLevelConsumers will be likely deprecated by kafka in the future.

@hyperlink Thank you for the information. It's a huge help.
I've already ensured that the consumer/producer are connected before causing disconnection.
I will start listening on the reconnect event.
As for the ECONNREFUSED errors, I will probably have to check all of my catch clauses to be sure we're not accidentally swallowing those errors.


[OpenCL] Coder.py example - No prompt response - Possible bug?

Hello guys.
Trying to run the coder.py example, but getting this error when using HIP.
My setup:
Ubuntu 22.04.3 LTS, 6.2.0-39-generic. ROCM 5.7
4 x AMD WX9100 (Instinct MI25).
Other HIP workloads seem to work as expected.
Summarized Logs:
:3:comgrctx.cpp :33  :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] Loading COMGR library.
:3:hiprtc.cpp :110 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcCreateProgram: Returned HIPRTC_SUCCESS
:3:hiprtc.cpp :114 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcCompileProgram ( 0x55cf50f89a70, 1, 0x7f0a5ec3c910 )
:1:hiprtcInternal.cpp :307 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] Error in hiprtc: unable to compile source to bitcode
:3:hiprtc.cpp :129 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcCompileProgram: Returned HIPRTC_ERROR_COMPILATION
:3:hiprtc.cpp :218 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcGetProgramLogSize ( 0x55cf50f89a70, 0x7f0a5ec3c910 )
:3:hiprtc.cpp :226 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcGetProgramLogSize: Returned HIPRTC_SUCCESS
:3:hiprtc.cpp :206 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcGetProgramLog ( 0x55cf50f89a70,  )
:3:hiprtc.cpp :214 :<PHONE_NUMBER> us: [pid:3539  tid:0x7f0a9de75000] hiprtcGetProgramLog: Returned HIPRTC_SUCCESS

RuntimeError: compile failed: /tmp/comgr-58f5a7/input/<null>:30:97: error: cannot take the address of an rvalue of type 'unsigned int'
  *((half4*)(data0+(gidx0*32768)+alu0+(lidx2*4096)+alu1)) = (half4)make_half4((half)((*((float*)&((unsigned int)((*((unsigned short*)&val0)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val1)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val2)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val3)))*(unsigned int)(65536))))));
                                                                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/comgr-58f5a7/input/<null>:30:187: error: cannot take the address of an rvalue of type 'unsigned int'
  *((half4*)(data0+(gidx0*32768)+alu0+(lidx2*4096)+alu1)) = (half4)make_half4((half)((*((float*)&((unsigned int)((*((unsigned short*)&val0)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val1)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val2)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val3)))*(unsigned int)(65536))))));
                                                                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/comgr-58f5a7/input/<null>:30:277: error: cannot take the address of an rvalue of type 'unsigned int'
  *((half4*)(data0+(gidx0*32768)+alu0+(lidx2*4096)+alu1)) = (half4)make_half4((half)((*((float*)&((unsigned int)((*((unsigned short*)&val0)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val1)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val2)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val3)))*(unsigned int)(65536))))));
                                                                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/comgr-58f5a7/input/<null>:30:367: error: cannot take the address of an rvalue of type 'unsigned int'
  *((half4*)(data0+(gidx0*32768)+alu0+(lidx2*4096)+alu1)) = (half4)make_half4((half)((*((float*)&((unsigned int)((*((unsigned short*)&val0)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val1)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val2)))*(unsigned int)(65536))))),(half)((*((float*)&((unsigned int)((*((unsigned short*)&val3)))*(unsigned int)(65536))))));
                                                                                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 errors generated when compiling for gfx900.

I have seen similar compilation error when the generated kernels were in half precision. And they have disappeared after upgrading it to rocm 6.0. Also, did you change the bf16 definitions in dtype? Currently it's used METAL one by default.

I have seen similar compilation error when the generated kernels were in half precision. And they disappeared after I upgrade to rocm 6.0. Also, did you change the bf16 definitions in dtype? Currently it's used METAL one by default.

I tried ROCM 6.0, but I don't think my GPUs are supported because other use cases such as Llama.cpp gave me a lot of errors.-
I have not changed the definitions in dtype, and I don't understand what I should change.

I have not changed the definitions in dtype, and I don't understand what I should change.

This is related to this issue that we couldn't find a clean solution yet.

such as Llama.cpp gave me a lot of errors.

llama's kernels are also generated in half precision which probably lead you to similar error messages. Can you run
HIP=1 HALF=1 TC=0 python examples/hlb_cifar10.py?

yep they are expected. However, if the new HIP/ROCM version are no longer supported on your platform, you might still able to run them with OpenCL, I think we still need to add the bf16 support for coder.py because of that issue but you should be able to use opencl to run llama as well as hlb_cifar. Just do HIP=0 GPU=1 before.

@g1y5x3
OpenCL works fine for hlb_cifar, It seems to almost work for coder.py. It starts up correctly and I get to the prompt, I however do not get any answer. So I got some more troubleshooting to do.

I can confirm the same behavior with OpenCL on coder.py as well. Would you mind change the title of this from HIP to OpenCL? As far as HIP for rocm 5.7 I doubt it will be fixed in the short term.

I fixed this issue I believe with the bitcast fix


Update database-cannot-be-started-in-this-edition-of-sql-error-when-r…

…estoring.md
Added check for temp table if it already exists and drop it. Fixed temp table name from "# indexesScript" to "##indexesScript".

@tim-tllc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@simonxjx : Thanks for your contribution! The author(s) have been notified to review your proposed change.


chore: switch to xtask

xtask is a more native alternative to cargo-make. While it's not as easy to write and understand, it does not require any external setup and only uses cargo and rustc to get started. Many Rust projects including cargo and rust-analyzer use xtask idiom as an alternative to Makefiles and bash scripts.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

22 of 59 (37.29%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 85.341%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xtask/src/main.rs
22
59
37.29%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.7%

Covered Lines:
3621

Relevant Lines:
4243

💛  - Coveralls


bug: indent marker disappears with default_component_configs.indent.padding < 1

Hi, Thanks for the awesome plugin :)
I found out that when setting the padding to 0, the indent marker on the first indentation (far left) disappears as in the following screenshot. (indent of lua/ in the picture.)
I think it is more intuitive to have it not disappear especially since I hide_root_node = true.
If this is indented, may I kindly ask you to expose some kind of setting that I can change in the setup?
Reproduce
local neotree = require("neo-tree")
neotree.setup({
  hide_root_node = true, -- disappears with `false` as well
  retain_hidden_root_indent = false,
  filesystem = {
    follow_current_file = true,
  },
  default_component_configs = {
    indent = {
      indent_size = 2,
      padding = 0, -- HERE
    },
  },
})

padding = 0 (disappears)

padding = 1 (no problem)

Notes

neo-tree

branch: main
commit: 9f5119a7d47edcb0c30f0c44e6f4580b5101b5f5

Details

nvim --version

NVIM v0.8.0-dev+nightly
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system: <IP_ADDRESS>-microsoft-standard-WSL2

Best,
@pysan3

Hi @cseickel, this issue seems to be not yet fixed.
Do you have any plans on working on it?

Hey @pysan3, sorry I missed this one. Life has been very busy lately so I am just keeping up with PRs and bug reports and not adding much new code myself.
It seems like this doesn't really need configuration, the indent component should just force a minimum padding of 1 if the indent guides or expand markers are enabled. Does that make sense to you.

I see. Yes when I do not set anything to default_component_configs.indent.padding, it seems to work alright.
I think I'll go with this for now so closing this issue.
BTW, I might be able to help you especially for issues related to the source selector, so feel free to ping me. (mentioning with @pysan3 should send an email to me?)


Upgrade lnd in dev env to v0.13.1-monitoring

update docker images to v0.13.1-monitoring
reorganize lnd.conf file
add protocol.no-anchors=true (to avoid fee issues in tests, this also need to be configured in production)

ref: issue 364

We should keep the dev dependencies == to the versions we are running in production. I will close this PR (to avoid accidental merging) until we have updated to lnd 0.13.1 in prod.


Having several entries from "flynn ps" in pending state, and deployment now fails on timeout.

I can see processes from 4 different releases. The oldest one has all 7 nodes up and the 3 newer releases each has 2 nodes in pending state. When I now tried to push a new release, it times out with the following error message:
remote: ERROR: Error deploying app release: timed out waiting for job events: map[upload-web:map[up:3] web:map[up:3] admin-web:map[up:1]]
Are the processes with pending state the problem? Why are they in pending state? How to get them out of it? Thanks!

@alfredqy Please run sudo flynn-host collect-debug-info on one of the hosts and provide the resulting debug logs here.

@titanous thanks. Following instructions here: https://flynn.io/docs/installation/cloud#ssh-access
When I try to ssh in with the keys it still asks for password. There shouldn’t be one with the keys should it?
I get this debug when I run with -vvv:
debug1: Authentications that can continue: publickey,password
debug3: start over, passed a different list publickey,password
debug3: preferred publickey,keyboard-interactive,password
debug3: authmethod_lookup publickey
debug3: remaining preferred: keyboard-interactive,password
debug3: authmethod_is_enabled publickey
debug1: Next authentication method: publickey
debug1: Offering RSA public key: /Users/username/.flynn/installer/keys/flynn
debug3: send_pubkey_test
debug2: we sent a publickey packet, wait for reply
debug1: Authentications that can continue: publickey,password
debug2: we did not send a packet, disable method
debug3: authmethod_lookup password

What hosting provider did you use? What username did you pass to SSH?

DigitalOcean. I passed ubuntu as the username.

Try using root, looks like a docs update needs deploying.

Tried using root. Sort of hanging but in the log: Authentication succeeded (publickey).

If auth succeeded and the login is hanging, the VM is broken or the CPU is pegged. How many hosts in the cluster? Can you try a different one?

We are able to get in one of the hosts with root. The other two however don't seem to be accessible.
And we've got from collect-debug info command:
fatal error: runtime: out of memory
The output above the error:
INFO[11-02|19:17:24] uploading logs and debug information to a private, anonymous gist
INFO[11-02|19:17:24] this may take a while depending on the size of your logs
INFO[11-02|19:17:24] getting flynn-host logs
INFO[11-02|19:17:25] getting scheduler state
INFO[11-02|19:17:25] getting job logs

We have three hosts in the cluster. We are able to get into one of the three with root but not the other two.

We rebooted the two hosts that we lost access. Before reboot, our site page shows service not available. After reboot, flynn ps looks clean now and we are trying to make a new release push.
Any suggestions where we can look at to learn from the situation? What happened and maybe how to prevent getting into it again?
By the way, thanks for your prompt responses!

Can you provide the logs from the command? It should generate a gist link.

We've got this:
Total size of 305005871 bytes exceeds gist limit, falling back to tarball
Its in a tmp file on the server 300mb. Let us know what we need to do.

Can you upload it somewhere and post a link here?


run the pipeline locally only to get empty floders

Thanks for releasing the code. When I run the pipeline locally, only to get three empty folders like "beam-temp-test.tfrecord-3e99843c1d3411ec8a4cfa163ee22da8".  And the logs shows "I0925 18:54:12.767069<PHONE_NUMBER>03232 number_annotation_utils.py:149] Can't consolidate types: (None, text: "Portland, Maine mayoral election, 2011\nCount 6".  I would appreciate it if you could offer me some advice to make it works.

Dear developers:
Another question is when I run tapas/experiments/tapas_classifier_experiment.py(MATE) raising an error: _get_projection_length' is not defined. I try to import the function, however, it can not be searched from other "*.py" files.

Hi,
Thank you for spotting this error. The fix is in the latest release. (The
function _get_projection_length is added.)
Thanks,
Syrine
On Mon, Sep 27, 2021 at 4:48 AM airsYuan @.***> wrote:

Dear developers:
Another question is when I run
tapas/experiments/tapas_classifier_experiment.py(MATE) raising an error:
_get_projection_length' is not defined. I try to import the function,
however, it can not be searched from other "*.py" files.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google-research/tapas/issues/139#issuecomment-927475691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APARZOPTXII2TJU7NLAVPD3UD7LONANCNFSM5EXW3WXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Code refactoring

The goal of this is to simplify the library, enough so that it is easy to understand & new developers can dive right into creating their own additions without getting confused. The list for what needs to be refactored is as follows:

Move all semantic parsers into individual library
Move literal parser into individual library

I will edit this comment as I determine what code needs to be altered.

This should be good enough for the time being.


Password PDF Form: Still able to submit even when Form has error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Send pdf that has password
Click on that pdf and enter wrong password, press Confirm now the error will show, press the Confirm button couple of times.
Notice that user's still able to submit the form even there's error visible.

Expected Result:
If Form has error, we shouldn't allow user to submit the form again.
Actual Result:
Still able to submit even when Form has error
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/f3e5f78e-5e45-41f8-b541-5750eeaa8959
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688538758574899
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Password PDF Form: Still able to submit even when Form has error
What is the root cause of that problem?
In out PDFPasswordForm, we're checking the validation here:
https://github.com/Expensify/App/blob/11b8908b8ba3282d06543e2808a7c722690521fa/src/components/PDFView/PDFPasswordForm.js#L84-L92
If validate returned false then we disabled the submit:
https://github.com/Expensify/App/blob/11b8908b8ba3282d06543e2808a7c722690521fa/src/components/PDFView/PDFPasswordForm.js#L69-L71
As we can see our validation function only validated the empty password, in this case when password was wrong, validate function still return true which caused the issue.
What changes do you think we should make in order to solve the problem?
We also need to check if isPasswordInvalid is true then early return in out submit function.
    validate() {
        if (!_.isEmpty(this.state.password) && !this.props.isPasswordInvalid) {
            return true;
        }
     // other code
    }

What alternative solutions did you explore? (Optional)
N/A

This is more of a feature request than a bug. I'm going to close the issue, since I don't think we should prioritize this as a new feature.


Better error for migration "Error: Database error: Error querying the database: db error: ERROR: number of referencing and referenced columns for foreign key disagree"

Problem
I have this error when migrating:
Error: Database error: Error querying the database: db error: ERROR: number of referencing and referenced columns for foreign key disagree
   0: migration_core::api::ApplyMigrations
             at migration-engine/core/src/api.rs:51

I understand what it says, but it does not specify neither the line nor the model that has this problem.
Suggested solution
Specify the line and the model that are related with the error

On which database is this happening?

Postgres

How do we create the same situation where this error happens?

Sorry, I created this issue a lot of months ago, I actually don't remember


Guard for DDoS.

Prevent programs from taking arbitrarily large CPU or memory to compile.

Merged with #35


Renaming files that was moved by drag-and-drop makes the sidebar grey

VSCode Version: 0.10.11
OS Version: OS X 10.11.3

Steps to Reproduce:

Move a file to another folder using drag and drop
Hit enter to rename the file that you just moved
Rename the file and hit enter

File names in the file browser in sidebar becomes all grey
Video: https://gfycat.com/RemorsefulMixedIchneumonfly
Edit: updated video

Fixed for March. You can try the fix in http://code.visualstudio.com/insiders


Chore - Travis-CI PHP versions and enhanced configuration

This PR simply updates our Travis-CI configuration to test on newer PHP versions (5.6, 7.0, and the nightly), while also enabling our Travis-CI configuration to use the new container-based infrastructure.

Alllll 💚! Merging...


Error when adding Image from Asset in Xcode 11.1 IOS 13 (CUICatalog: Invalid asset name supplied: '')

Hi, I wanted to set the image into the ONBoardingItemInfo. However, I am adding this function informationImage: UIImage(named: "Page1")!. My Asset file image has called "Page1"). I guess this should be the correct code to call the specific image. But the error is  CUICatalog: Invalid asset name supplied: ''". Do you know how to fix this problem? Thank you
2019-10-18 10:37:54.442804+0700 CollaborationApp[2673:92187] [framework] CUICatalog: Invalid asset name supplied: ''

It should work fine. Please provide source code if you still need help


Fixes for ASimAuthenticationMicrosoftWindowsEvent

Change(s):

Fixed ASimAuthenticationMicrosoftWindowsEvent function (forwarded events part of the function)
Reason for Change(s):

WindowsEvent contains EventOriginId as a field, hence the project-rename for EventID to EventOriginId was failing, resulting in no records being found at all. Fixed by removing this from project-rename and uncommented rename for EventOriginId to EventOriginalUid which seemed to be in the kusto query already.  Also put EventID in EventOriginID + dropped EventID as per consistency for how SecurityEvents are handled.

ActorUsername and TargetUsername were "extended" twice. Moreover, 2nd extend of TargetUsername was relying on EventData.TargetUsername which is faulty as it's EventData.TargetUserName (upper N) resulting in empty Targetusername. Fixed by removing the first 2 extends for these fields and correctly implementing lower in the query.

TargetDomainName was blank in my forwarded events, resulting in Windows to be used for TargetUsernameType rather than Simple. Fixed this by not only looking for a "-" but also "" (blank string)
Version Updated:

No

Testing Completed:

Yes, in my own environment

Checked that the validations are passing and have addressed any issues that are present:

Yes

@oshezaf Not sure I understand your last message in the thread here. While you posted it I was working on testing/changing the vim-parser as you said in the email as well. I removed the extend/project-away in favor of simply renaming.
Let me know if something is still not as you intend it.

ensured all instances where checks happen for TargetDomainName == '-' also check for '' as that seems to be some inconsistency in the event logging. Often - == blank, but sometimes it seems blank is also used. Cleaning this upfront could be a better approach then checkin for in ('-','') in various places...
I think this PR should be OK for now. Definitely do let me know if you still see challenges with it.

@oshezaf understood. I checked the schema (https://docs.microsoft.com/en-us/azure/sentinel/normalization-about-schemas#common ) and I see what you mean. Adjusted. I think we should be where we need to be now. Thanks for your help on this!

Approved and will merge. To your question: pre-cleansing may make sense, but not always. The main challenge is that Kusto works better on native fields, so as much work as you can done on native fields rather than the cleansed fields, the better.


Setup system-wide init scripts for all Docker containers

global across all notebooks, etc

add INIT_SCRIPT=init.sh ENV VAR to -deploy.yaml files.
modify run method to call this INIT_SCRIPT if the script exists.
these should all be put in /source.ml (not /pipeline).

https://kubernetes.io/docs/concepts/workloads/pods/init-containers/


Terms without definitions

We now have a lot of terms without definitions which had definitions previously from DO
see
mondo_terms_no_definition.tsv (1).txt

@cmungall do we want to add the definitions from DO?

These defs were really useful.
I also liked the fact that most mentioned the causative gene,  which made it clear that we had the fission yeast assignment  correct.

@ValWood were all the terms in the list above in DO (and defined in DO)? I did some spot checking of some terms and I didn't see all of the terms in DO. Thanks!

Oh sorry no. The ones I mentioned originally (I can't remember which ticket)  had defs in DO when I looked. This is just a list of everything without defs. I don't think we can easily now get just the list without MONDO defs but with DO defs, but I can ask @kimrutherford if it would be really useful

Hi Val - no need to get the list without MONDO defs but with DO defs. I talked to Chris today and we have a strategy.
We'll try to pull in any defs from OMIM where we can, and I'll review the list to determine other sources of defs. This will take me some time though, I hope that's okay.
I added this list to a spreadsheet here.

No hurry for me. This sounds like a long term task!
val


⚠ Minecraft has degraded performance

In d6cc2ee, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1162 ms

Resolved: Minecraft performance has improved in 34be4ca.


feat: 🎸 Stargazers remotion dev comleted

✅ Closes: #453
This pull request introduces significant changes to the project, including the addition of a new stargazers feature, updates to dependencies, and code formatting improvements. The most important changes include adding new dependencies, implementing the stargazers feature, and updating ESLint and Prettier configurations.
Dependency Updates:

Added @remotion/bundler, @remotion/cli, @remotion/renderer, and remotion to the package.json dependencies. [1] [2]

New stargazers Feature:

Created stargazers/package.json with necessary scripts and dependencies for the new feature.
Implemented caching logic in stargazers/src/cache.ts to store and retrieve stargazer data.
Added stargazers/src/fetch/fetch-data.ts to fetch stargazer data using GitHub's API.
Developed stargazers/src/Content.tsx and stargazers/src/Main.tsx to display stargazer information. [1] [2]
Configured Remotion settings in stargazers/remotion.config.ts and registered the root component in stargazers/src/index.ts. [1] [2]

Code Formatting and Configuration:

Added ESLint configuration file stargazers/.eslintrc to extend Remotion's ESLint rules.
Introduced Prettier configuration file stargazers/.prettierrc to enforce consistent code formatting.
Updated .gitignore to include common ignored files and directories.

SUMMARY
Final setup of the Remotion studio application is completed, this will allow users to easily go to the stargazers dir and run the application from there manually
Video/Screenshots
fitflex-453.webm
Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md if its a new page/tech stack
[X] I have gone through the  contributing.md file before contributing

Are you contributing under any Open-source programme?

[X] I'm a GSSOC-EXT contributor

@GAVINESHWAR @jeevan10017 Kindly review this PR, at least lvl 3

@yashksaini-coder can you justify, Why it is useful, like what in video you are saying about?


JSON Schema for 'Tuple' could be more specific

Feature Request
from pydantic import BaseModel
from typing import List, Tuple

class Foo(BaseModel):
    pair: Tuple[str, int]

print(Foo.schema())

Output:
{
    "title": "Foo",
    "type": "object",
    "properties": {
        "pair": {
            "title": "Pair",
            "type": "array",
            "items": [
                {
                    "type": "string"
                },
                {
                    "type": "integer"
                }
            ]
        }
    },
    "required": [
        "pair"
    ]
}

Maybe we should put "maxItems: 2" and "minItems: 2" in this situation.

yup, PR welcome.

Have in mind that having a JSON array (Python list) of schemas as in:
"items": [
                {
                    "type": "string"
                },
                {
                    "type": "integer"
                }
            ]

Means that:

[...] validation succeeds if each element of the instance [the JSON array] validates against the schema at the same position, if any.

Ref: http://json-schema.org/latest/json-schema-validation.html#rfc.section.6.4.1
That means that there's an implicit restriction on how many items are acceptable and the exact type of each item at each position.

Now, also have in mind that if you plan on using this in OpenAPI, by OpenAPI it's not valid, a JSON array can have only one type, so, only one schema. This is one of the few small differences between JSON Schema and OpenAPI.

fair enough to me

Looks like OpenAPI support mixed type arrays using anyOf @tiangolo (under the section "Mixed-Type Arrays").
If JSON Schema also support using {max,min}Items (the site is down at the moment so I can't check the latest format), then wouldn't it be preferable to use this format and get support for both JSON Schema and OpenAPI?
(I recently got caught out by this when parsing a schema generated by FastAPI)

So, Pydantic is outputing valid JSON Schema, and if the two types in the tuple are different, there's no other way to generate a schema for that.
So, OpenAPI is simply not compatible with that type of data :cry: . But Pydanticis compatible with it. And if you use it with FastAPI, your API will be able to handle and validate that data, it's just OpenAPI the part that can't handle it.
So, if you need to be fully compatible with OpenAPI, you would have to restrain yourself from using tuples.
On another note, OpenAPI v 3.1.0 (the next one) will be compatible with several JSON Schema features (I'm not sure about tuples, though).

Ah I see! Thanks for clearing that up.
Maybe we could detect if an array is homogeneous, and use the "oneOf/{min,max}Items" form if it is? It would make the schemas more concise, and probably help with the difficulties in using ellipses in Tuples too by just omitting maxItems (I'm not sure if this breaks the JSON Schema spec though, my experiments with online validators was inconclusive..).
Or perhaps it's worth seeing what OpenAPI 3.1.0 brings first? (Good news about that by the way :+1:)


Not working on the live site

Thanks for the nice code.
On my local server it works fine but not working on the live site on Godaddy shared host.
Why?

The crawlers make use of cURL internally. Maybe cURL is not available on your shared host.

I check it: in Godaddy server cURL is enabled. I recreated the error in local deleting the "extends" or "implements" of the class, so I think the problem is the case sensitivity of class names because in local (Windows XAMPP) all works fine: Godaddy shared host is Linux.


Status endepunkt for status.nav.no

/schedule 2023-10-18T08:58

:hourglass: Merge Schedule
Scheduled to be merged on 2023-10-18 08:58:00 (UTC)


Extracted ReposList

Splitting #1236 into smaller chunks

Coverage increased (+0.02%) to 98.598% when pulling d0b989afbbf167727288a092f2a410055d8c405e on tomazy:ssr-extract-reposlist into 7652c6da7deed3a8775d3d29e81c6e0ce0294ced on mxstbr:dev.

Coverage increased (+0.02%) to 98.598% when pulling 5775f905e028733854e784ddc2bb0da52214d022 on tomazy:ssr-extract-reposlist into 1702bf52ee849c17e99f83bb019eab7a39d400e3 on mxstbr:dev.

Coverage increased (+0.02%) to 98.598% when pulling ef4dda0d18a4f0242a15fc7a0000a1e501684c40 on tomazy:ssr-extract-reposlist into fef5eb3a8b3b106b04f0209ce4d4848093504dbc on mxstbr:dev.

Coverage increased (+0.02%) to 98.598% when pulling ef4dda0d18a4f0242a15fc7a0000a1e501684c40 on tomazy:ssr-extract-reposlist into fef5eb3a8b3b106b04f0209ce4d4848093504dbc on mxstbr:dev.

Yeah,  LGTM 💯
I tested dev and prod, even with invalid entries "~" and "`" (invalid Github entries are hard to find) ;-)

Yeeeaaaah +0.02% coverage 😎
lol


Mayastor Addon with latest version - 2.0

Summary
Mayastor Addon with latest version - 2.0
Why is this important?
Mayastor Addon with latest version - There are new features and bug fixes with the latest version of Mayastor 2.0
Are you interested in contributing to this feature?
Yes, we would like to contribute to place the new version of mayastor addon. we need further details on this to proceed.

Hi @datacore-tilangovan, thanks for creating this PR. I just went through the release notes for 2.0.0 in https://github.com/openebs/mayastor/releases/tag/v2.0.0
I see some changes that I like in Mayastor 2.0.0, namely the single helm chart to deploy all of the mayastor components in the cluster.
For MicroK8s, we initially used a fork of the available helm charts due to required configurations that were missing from upstream, and for which the PRs were dropped https://github.com/openebs/mayastor-control-plane/pull/250 and https://github.com/openebs/mayastor/pull/1122
Further, we also provide and validate mayastor arm64 builds, which requires building and maintaining our own images for mayastor. The whole process is described in https://github.com/canonical/microk8s-core-addons/blob/main/addons/mayastor/chart/README.md#L169
This needs to be updated considerably for 2.0.0.

Hi @neoaggelos Thanks for your response !!
Any updates on how we are going to proceed further on this ? Does upgrading mayastor in Microk8s addon will be owned by canonical itself. If yes, any timelines ?
If this needs contribution from our side, Please do let us know how can we help to get this done as soon as possible. Thanks !

Hi @datacore-tilangovan
It definitely requires work from our side since we are building images for amd64 and arm64. I also see that the helm charts have changed significantly from 1.0.0, so we will have to take a look at them as well.
We will pick this up shortly and will keep in the loop if we encounter any blocking issues. Thanks!

Hi @datacore-tilangovan , the upcoming 1.27 release will include Mayastor 2.0.0. Please have alook at https://github.com/canonical/microk8s/issues/3732 to see what we had to do to port it to MicroK8s. Thanks.


changelog for private repos on an organisation

Hi, I have an organisation with a couple of private repositories. Is it possible to use github-changelog-generator to generate release-notes for these private repos?
Thanks.

Yes!
Generate a GitHub API token which has access to the repo you need to lookup metadata (PRs and such) for.
Then use this tool to make a changelog.

@MehdiK Good luck!


[WIP]Storageclean

add new keys for dead containers and exited containers , clean dead containers and exited containers when the avalable less than 90%

@twiest.  I watched this work with him on a dev-preview-int.  I'd like another set of eyes on it as well.

@mwoodson ok, sounds good.
@BlueShells I would like us to make sure that the openshift-node container garbage collection stuff is enabled and working BEFORE we push this code.  I want openshift-node handling the day to day cleanup and this to only handle the extreme case.
Feel free to talk to Goulding about priority on that.


clang & windows build should use longjmp

windows clang use setjmp like posix, the current implement only work for msvc.
I guess for mingw ,  BH_PLATFORM_WINDOWS also should be disabled.
#if defined(__clang__) || defined(__GNUC__)
    #define os_thread_local_attribute __thread
#elif defined(_MSC_VER)
    #define os_thread_local_attribute __declspec(thread)
#else
    #error "Unknown compiler, unable to define os_thread_local_attribute"
#endif

https://github.com/mstorsjo/llvm-mingw is great to cross build windows app.

diff --git a/core/shared/platform/windows/shared_platform.cmake b/core/shared/platform/windows/shared_platform.cmake
index 502a8a2e..0b402a06 100644
--- a/core/shared/platform/windows/shared_platform.cmake
+++ b/core/shared/platform/windows/shared_platform.cmake
@@ -3,7 +3,10 @@

 set (PLATFORM_SHARED_DIR ${CMAKE_CURRENT_LIST_DIR})

-add_definitions(-DBH_PLATFORM_WINDOWS)
+if(NOT MINGW)
+  add_definitions(-DBH_PLATFORM_WINDOWS)
+endif()
+
 add_definitions(-DHAVE_STRUCT_TIMESPEC)
 add_definitions(-D_WINSOCK_DEPRECATED_NO_WARNINGS)

with this patch and some adjust I am able to build.
without AOT it work as expect, with AOT it crashed.
=================================================================
==1564==ERROR: AddressSanitizer: access-violation on unknown address 0x12fb40490004 (pc 0x7ffee8ad46f8 bp 0x00cdb15ab370 sp 0x00cdb15ab2e8 T0)
==1564==The signal is caused by a WRITE memory access.
    #0 0x7ffee8ad46f7 in memset+0x77 (C:\Windows\SYSTEM32\ntdll.dll+0x1800a46f7)
    #1 0x7ffe8b672cc0 in _asan_memset+0x90 (C:\Users\admin\libclang_rt.asan_dynamic-x86_64.dll+0x180042cc0)
    #2 0x7ff67678fed6  (C:\Users\admin\tests_wamr.exe+0x14020fed6)
    #3 0x7ff676790a6d  (C:\Users\admin\tests_wamr.exe+0x140210a6d)
    #4 0x7ff67671473c  (C:\Users\admin\tests_wamr.exe+0x14019473c)
    #5 0x7ff6766a86ab  (C:\Users\admin\tests_wamr.exe+0x1401286ab)
    #6 0x7ff67669e3cc  (C:\Users\admin\tests_wamr.exe+0x14011e3cc)
    #7 0x7ff67669b61c  (C:\Users\admin\tests_wamr.exe+0x14011b61c)
    #8 0x7ff6765f8991  (C:\Users\admin\tests_wamr.exe+0x140078991)
    #9 0x7ff6765f8a23  (C:\Users\admin\tests_wamr.exe+0x140078a23)
    #10 0x7ff6765da2b7  (C:\Users\admin\tests_wamr.exe+0x14005a2b7)
    #11 0x7ff676581310  (C:\Users\admin\tests_wamr.exe+0x140001310)
    #12 0x7ff676581365  (C:\Users\admin\tests_wamr.exe+0x140001365)
    #13 0x7ffee8237373 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017373)
    #14 0x7ffee8a7cc90 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18004cc90)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: access-violation (C:\Windows\SYSTEM32\ntdll.dll+0x1800a46f7) in memset+0x77
==1564==ABORTING

=================================================================
==10248==ERROR: AddressSanitizer: access-violation on unknown address 0x126a940b0004 (pc 0x7ffee8ad46f8 bp 0x00e9ec1ab550 sp 0x00e9ec1ab4c8 T0)
==10248==The signal is caused by a WRITE memory access.
    #0 0x7ffee8ad46f7 in memset+0x77 (C:\Windows\SYSTEM32\ntdll.dll+0x1800a46f7)
    #1 0x7ffe8ed92cc0 in _asan_memset+0x90 (C:\Users\admin\libclang_rt.asan_dynamic-x86_64.dll+0x180042cc0)
    #2 0x7ff79b1a2df6  (C:\Users\admin\tests_wamr.exe+0x140212df6)
    #3 0x7ff79b1a398d  (C:\Users\admin\tests_wamr.exe+0x14021398d)
    #4 0x7ff79b12718c  (C:\Users\admin\tests_wamr.exe+0x14019718c)
    #5 0x7ff79b0c6d6b  (C:\Users\admin\tests_wamr.exe+0x140136d6b)
    #6 0x7ff79b0bc7ec  (C:\Users\admin\tests_wamr.exe+0x14012c7ec)
    #7 0x7ff79b0b9a3c  (C:\Users\admin\tests_wamr.exe+0x140129a3c)
    #8 0x7ff79b008b21  (C:\Users\admin\tests_wamr.exe+0x140078b21)
    #9 0x7ff79b008bb3  (C:\Users\admin\tests_wamr.exe+0x140078bb3)
    #10 0x7ff79afea2b7  (C:\Users\admin\tests_wamr.exe+0x14005a2b7)
    #11 0x7ff79af91310  (C:\Users\admin\tests_wamr.exe+0x140001310)
    #12 0x7ff79af91365  (C:\Users\admin\tests_wamr.exe+0x140001365)
    #13 0x7ffee8237373 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017373)
    #14 0x7ffee8a7cc90 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18004cc90)

=================================================================
==10248==ERROR: AddressSanitizer: access-violation on unknown address 0x126a940b0004 (pc 0x7ffee8ad46f8 bp 0x00e9ec1ab550 sp 0x00e9ec1ab4c8 T0)
==10248==The signal is caused by a WRITE memory access.
    #0 0x7ffee8ad46f7 in memset+0x77 (C:\Windows\SYSTEM32\ntdll.dll+0x1800a46f7)
    #1 0x7ffe8ed92cc0 in _asan_memset+0x90 (C:\Users\admin\libclang_rt.asan_dynamic-x86_64.dll+0x180042cc0)
    #2 0x7ff79b1a2df6  (C:\Users\admin\tests_wamr.exe+0x140212df6)  gc_init_internal
    #3 0x7ff79b1a398d  (C:\Users\admin\tests_wamr.exe+0x14021398d)  gc_init_with_struct_and_pool
    #4 0x7ff79b12718c  (C:\Users\admin\tests_wamr.exe+0x14019718c)  mem_allocator_create_with_struct_and_pool
    #5 0x7ff79b0c6d6b  (C:\Users\admin\tests_wamr.exe+0x140136d6b)  memory_instantiate
    #6 0x7ff79b0bc7ec  (C:\Users\admin\tests_wamr.exe+0x14012c7ec)  memories_instantiate
    #7 0x7ff79b0b9a3c  (C:\Users\admin\tests_wamr.exe+0x140129a3c)  aot_instantiate
    #8 0x7ff79b008b21  (C:\Users\admin\tests_wamr.exe+0x140078b21)  wasm_runtime_instantiate_internal
    #9 0x7ff79b008bb3  (C:\Users\admin\tests_wamr.exe+0x140078bb3)  wasm_runtime_instantiate
    #10 0x7ff79afea2b7  (C:\Users\admin\tests_wamr.exe+0x14005a2b7)
    #11 0x7ff79af91310  (C:\Users\admin\tests_wamr.exe+0x140001310)
    #12 0x7ff79af91365  (C:\Users\admin\tests_wamr.exe+0x140001365)
    #13 0x7ffee8237373 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017373)
    #14 0x7ffee8a7cc90 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18004cc90)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: access-violation (C:\Windows\SYSTEM32\ntdll.dll+0x1800a46f7) in memset+0x77
==10248==ABORTING


Patch Outline not working with ts 5.5.3

Per the title, I just installed this plugin and enabled "patch outline" yet no jsx elements show up in the outline for my react native tsx files. On typescript 5.5.3. Could this be affected by  "jsx": "react-native", in my tsconfig?

Could this be affected by  "jsx": "react-native", in my tsconfig?

No, I just checked that it works with TS 5.5.4. Can you send a sample file where it doesn't work?

cant reproduce, can try tracking down the problem?


A11y_AzureDataStudio_Selectthedeploymentoption_ScreenReader(NVDA):NVDA does not annouce the the selected imgae as selected.

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHubTags: #A11y_AzureDataStudio;#A11yMAS; #A11yTCS;#MAS1.3.1,#DesktopApp;#electron.0,#NVDA
Environment Details:
Application Name: Azure Data Studio
Version: 1.12.0-insider (user setup)
Commit: 32df727ff9fe68421b004bf270cd509e4c5de165
Date: 2019-10-08T19:18:43.743Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
Additional Details:
NVDA Version:2019.2
**MAS References:**MAS1.3.1
Steps to Reproduce :

Install /Launch the application Azure data studio.
Navigate to connections and click on more action button.
Select “Deploy SQL Server big data cluster” from more action drop down.
Click on “Deploy SQL Server big data cluster” .
Start NVDA and observe the announcement.
Actual:
When the focus is going on the selected image or the radio button the NVDA does not announce the selected word for the selected image.
**Expected:
NVDA should announce the selected item as selected.

User Impact:
Screen reader User will not able to understand on which server they are connected to.
MAS Reference:
MAS1.3.1 -
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Attachment for Reference:
A11y_AsureDataStudio_Selectthedeploymentoption_ScreenReader.pptx

Wrong place to log this bug.
From: TCS Accessibility Testing Team<EMAIL_ADDRESS>Sent: Wednesday, October 9, 2019 2:33 AM
To: microsoft/AzureStorageExplorer<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/AzureStorageExplorer] A11y_AsureDataStudio_Selectthedeploymentoption._ScreenReader(NVDA):NVDA does not annouce the the selected imgae as selected. (#2023)
"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHubTags: #A11yMAS; #A11yTCS;#MAS1.3.1,#DesktopApp;#electron.0,#NVDA
Environment Details:
Application Name: Azure Data Studio
Version: 1.12.0-insider (user setup)
Commit: 32df727ff9fe68421b004bf270cd509e4c5de165
Date: 2019-10-08T19:18:43.743Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
Additional Details:
NVDA Version:2019.2
**MAS References:**MAS1.3.1
Steps to Reproduce :

Install /Launch the application Azure data studio.
Navigate to connections and click on more action button.
Select “Deploy SQL Server big data cluster” from more action drop down.
Click on “Deploy SQL Server big data cluster” .
Start NVDA and observe the announcement.
Actual:
When the focus is going on the selected image or the radio button the NVDA does not announce the selected word for the selected image.
**Expected:
NVDA should announce the selected item as selected.

User Impact:
Screen reader User will not able to understand on which server they are connected to.
MAS Reference:
MAS1.3.1 -
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}https://nam06.safelinks.protection.outlook.com/ap/w-59584e83/?url=https%3A%2F%2Fmicrosoft.sharepoint.com%2F%3Aw%3A%2Fr%2Fteams%2Fmsenable%2F_layouts%2F15%2FWopiFrame.aspx%3Fsourcedoc%3D%257B54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4%257D&data=02|01|jinglou%40microsoft.com|bfde6c27fd64417f951708d74c9bb9c2|72f988bf86f141af91ab2d7cd011db47|1|1|637062104027958267&sdata=siDoA4vyNFVTPIHra%2FM1rvvXICx%2BaX4eEsQewte6HAA%3D&reserved=0
Attachment for Reference:
A11y_AsureDataStudio_Selectthedeploymentoption_ScreenReader.pptxhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FAzureStorageExplorer%2Ffiles%2F3706587%2FA11y_AsureDataStudio_Selectthedeploymentoption_ScreenReader.pptx&data=02|01|jinglou%40microsoft.com|bfde6c27fd64417f951708d74c9bb9c2|72f988bf86f141af91ab2d7cd011db47|1|1|637062104027968225&sdata=aWKo6sSZV5hUzEDDFjt6kYBNaS1mP%2BuEAIs6CW8Ugwg%3D&reserved=0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FAzureStorageExplorer%2Fissues%2F2023%3Femail_source%3Dnotifications%26email_token%3DACM5JS23IEO6P6XDWAOSA3TQNWQODA5CNFSM4I64W3QKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQSQFDQ&data=02|01|jinglou%40microsoft.com|bfde6c27fd64417f951708d74c9bb9c2|72f988bf86f141af91ab2d7cd011db47|1|1|637062104027968225&sdata=sAWmn0OiOlHxexoZi0MvYiveuo01MOAjVndWIKWbAxQ%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACM5JSYC2YOVLF6E3EAJ5ADQNWQODANCNFSM4I64W3QA&data=02|01|jinglou%40microsoft.com|bfde6c27fd64417f951708d74c9bb9c2|72f988bf86f141af91ab2d7cd011db47|1|1|637062104027978179&sdata=SyqqudMH7Q1T5ly9s%2BFEVjkjo725VyOrNHqjFL82eHg%3D&reserved=0.


WIP: Structured Generation for the Simulator

added Arbitrary and ArbitraryOf traits for mroe centralized generation
implemented random generation for tables and structured queries

IMO this looks like a great direction 👍

IMO this looks like a great direction 👍

Glad to hear that! I feel like after https://github.com/tursodatabase/limbo/pull/469 is merged, I can change the current workaround to be able to run the simulator (I had changed write!(f, "TRUE") to write!(f, "1 = 1")), and we can merge this in its current form and gradually improve. What do you think @jussisaurio ?

@pereman2 @jussisaurio I wanted to point out several design decisions worth discussing:
The current mode of generation is online, in other words, we decide on the next query as we execute the current one. This is one potential approach, which I think does not always benefit us. The reason I feel this is related to the idea of properties.
In the previous version of the simulator, correctness was based on modeling, or shadowing. We have a model of each operation, and we keep a replica of the database with respect to those models. Whenever we create an insert query, we push the same value to the replica table we have, whenever we run a select query, we check the result rows are those that exist in the replicate table.
I personally think this approach does not scale well to testing the entirety of limbo. Keeping the model up with limbo functionality is not going to be easy as the database gets more complex, because we'll have to reimplement every functionality we want to test in the database in the simulator model.
The approach I had taken was to define properties on the database, without necessarily using a separate model. property_insert_select is a good example. The correctness does not depend on a model, but the expectations from the database itself.
property_insert_select tells us that running INSERT on a value V, then running aSELECT query that has a where clause that evaluate to TRUE for the value V should give us at least one row, and the resulting row set should include V. We can test this property without keeping a replicate database ourselves.
Other examples of such properties would be;

Adding an AND TRUE to a where clause should not change the output of a select query
Adding an OR FALSE to a where clause should not change the output of a select query
Running the same SELECT query two times, without any INSERT statements in the middle, should yield the same output
Running select V for a value should not contain the value is it was deleted and not added beforehand.

Of course, my initial property-based approach was naive, in the sense that it solely focused on the correctness of query execution, not thinking of database as a live object, so I didn't understand why the workloads was an important part. That's why I think an offline generation approach might be better now.
In the offline generation, we first generate an array of queries and assertions to run on the database. This part again requires us to have some model of the database as we want to create meaningful queries. The generation would have several constraints:

We generate queries based on properties we want to test at certain points. The property_insert_select would generate an array of 3 items (2 queries and 1 assertion). INSERT V ; SELECT V ; assert V in RESULT.
We generate queries respecting the overall expected workload. Properties have flexibilities, in which you can actually insert statements between them. Going back to insert_select, we can inject as many INSERT (NOT V) or SELECT ANY statements in the middle without breaking the property, so as long as we don't insert another V or somehow delete or update the existing V. Leveraging this, we can dynamic adjust generation probabilities(because we have access to the overall list of statements to execute`.
Currently, it's sometimes possible to generate invalid statements, crashing the simulator. If we create a table with the same column name twice, the parser fails, and we currently sometimes create such tables. It makes sense to have a test where that happens, but I don't think that's what the simulator is testing. Using the offline generation, we can just discard such generations that don't conform to our assertions.

The harder part about this is that we need to come up with those properties I mentioned. Some of those queries already exist in database testing literature, so it's easy to borrow.
This approach has two more nice things about it:

It's very easy to produce a corpus of failing query arrays, making it easier to handle regressions by running previously failing query arrays. Perhaps this becomes kind of irrelevant with DST though, because the seed keeps all of this information already at hand.
We can now run shrinking on the results by systematically making the query array smaller, automatically receiving minimum reproducible examples, compared to the online generation where debugging will certainly become a mess for complex bugs.

Please let me know what you think about it so we can move forward.

I personally think this approach does not scale well to testing the entirety of limbo. Keeping the model up with limbo functionality is not going to be easy as the database gets more complex, because we'll have to reimplement every functionality we want to test in the database in the simulator model.

Maybe we could add a strict mode where we test the output of a query with sqlite3. But maybe this is a bad idea because sqlite3 could have the same bug.
With regards to online vs offline, I don't mind if its done first or while the process, at the end the test should be reproducible through the seed right?. In offline runs I see the benefit of dry-run of seeds we know fail.
Anyways, I loved your explanation. I agree it seems like it will not scale well because if we have to reimplement every query logic again it would be bad. I would say I would still love to see the environment setup of percentages of stuff at the beginning and for the rest it seems great.

Maybe we could add a strict mode where we test the output of a query with sqlite3. But maybe this is a bad idea because sqlite3 could have the same bug.

I actually like this idea a lot, it's the simplest property we could test. We should definitely have it as one of the options.

With regards to online vs offline, I don't mind if its done first or while the process, at the end the test should be reproducible through the seed right?. In offline runs I see the benefit of dry-run of seeds we know fail.

Yeah I think it would be reproducible in either case, but I still think having a corpus is nice. It's also nice in the sense that you can directly give it to a fuzzer and ask it to test things. So it opens up other possibilities too.

Anyways, I loved your explanation. I agree it seems like it will not scale well because if we have to reimplement every query logic again it would be bad. I would say I would still love to see the environment setup of percentages of stuff at the beginning and for the rest it seems great.

Yeah I agree with the percentages. I just broke down everything into parts, and today I'll work on getting it into a better shape while increasing the documentation coverage.

Hi @pereman2,
This latest change adds the offline generation via interaction plans, found in simulator/generation/plan.rs. A plan is basically a list of queries and assertions, where queries are our typical sql queries, and the assertions are Rust closures reasoning about the results of the queries themselves.
The query plans respect the workload distributions, handled via the frequency calculation at simulator/generation/plan.rs/L322. You can see an example of how to write a property with simulator/generation/plan.rs/property_insert_select at line 246.
When an assertion fails, we write the query plan at a temporary directory the same as the database as a valid set of sql statements, so that it's easy to use and reproduce. The seeds themselves are(at least to me) enough for reproducing too, as I've been using them to reproduce failing experiments.
What's missing?

[ ] There are no fault injections for now. We can add fault injections as part of the query plans. As I didn't fully know how they worked, I didn't wanna touch them.
[ ] No shrinking: Ideally, when a test fails, we should be able to obtain a smaller test that fails too. I plan to implement that as one of the next steps.
[ ] Complex generation: For now, I only added the eq check in the property_insert_select. The complex generation strategies implemented in simulator/generation/query.rs will give a better test coverage in the long term.
[ ] CLI: Another long term feature I wanna have is a CLI in front of the simulator to run configuration independent of the code, which we currently do in ad-hoc manner using the environment variables such as SEED.
[ ] Documentation: The current documentation is not very comprehensive. Please let me know if you see any undocumented code that is cryptic.

The discussion related to the code itself has been quite a mess in the previous comments, so I suggest that the future discussion moves forward independent of them, maybe by resolving all of them even we open duplicates after this comment.  I would love to resolve them in a linear fashion, as the PR itself is quite big at this point, causing even more confusion as time goes on.

btw there are CI failures.

@pereman2 added the interaction logs, increased the table creation probability at generation/plan.rs, and fixed the build problems.