RFC: Out-of-tree test suite

This PR proposes the creation of an external stand-alone test suite and associated tools for verifying the Rust toolchain that also fits into existing Rust development workflows.
Rendered

I think that having some form of standalone end-to-end testing is a great idea. Also nice for other implementations, e.g. gccrs seems to be interested: https://gcc-rust.zulipchat.com/#narrow/stream/266897-general/topic/RFC.3A.20Out-of-tree.20test.20suite.
A few questions/notes:

What kind of tests should live in this suite? Codegen tests make sense but UI tests are trickier, since the stderr may vary by implementation. Maybe the runner could accept a --ui-output-dir that can override files of the same name.
Assuming there will still be  tests directory in rust-lang/rust that isn't this submodule, how should a user decide where to place tests?
When would this test suite get run in CI?

A downside of tests in a submodule is that workflow for adding tests with a feature gets less ergonomic - two places to commit and potentially get out of sync. Perhaps the main test suite source could still live in rust-lang/rust, but certain directories get automatically synced to rust-lang/rust-test-suit that has the OOT runner and additional tests.
llvm-test-suite provides a good reference.

I think it would be more productive if you came to Zulip t-compiler with a precise problem description and we could then brainstorm a nice solution from scratch, considering all the potential downsides.

my personal recommendation would be to make this RFC a living document e.g. on hackmd and then discuss this on zulip to figure out the details and potential smaller uncontroversial steps that you can implement immediately.

What kind of tests should live in this suite? Codegen tests make sense but UI tests are trickier, since the stderr may vary by implementation. Maybe the runner could accept a --ui-output-dir that can override files of the same name.

Ideally, that would be all tests, including codegen, UI, cargo, clippy, etc.
For UI, I see several possibilities:

If the testable is rustc, then the driver uses the existing .stderr files.
If the testable is some other conforming tool, then the driver accepts a --ui-output-dir path with similar hierarchical structure as UI, with custom .stderr files that are tailored to the tool. When checking for the presence of an error, the driver could ignore everything after an ERROR annotation, and check for the presence of a corresponding .stderr with an error diagnostic at that location.

Assuming there will still be  tests directory in rust-lang/rust that isn't this submodule, how should a user decide where to place tests?

Given that the OOTTS is supposed to be a complete testing replacement, there will no longer be a tests directory in rust-lang/rust.

When would this test suite get run in CI?

The OOTTS would run after the toolchain is built, packaged, and installed in a clean environment, like so:

Apply PR (if there is one)
./x build ...
./x dist ...
./x install ... in a clean environment
Run the OOTTS.

I think such a big RFC is the wrong way to tackle this. As far as I understand, the problem being solved here is that you want to be able to test the distributed toolchains.

The problem that is being solved is to ensure that currently performed post-test processing do not alter the validity of a toolchain. This basically amounts to testing an off the shelf toolchain.

I think there are simpler ways to solve this problem, for example by just shipping the current testsuite as-is with some changes to tooling that would allow testing distributed toolchains.

If there are simpler solutions, then that would be great!

Instead of bikeshedding about this RFC, I think it would be more productive if you came to Zulip t-compiler with a precise problem description and we could then brainstorm a nice solution from scratch, considering all the potential downsides.

I will follow up on this.

By your description of the problem, I am slightly worried that in general you have a different idea of how the build process goes down than what happens in actuality, both for toolchains and actual executions of rustc involving cargo.

My understanding, which is derived from poking around sources and looking at very verbose logs, and which could be very wrong, is that ultimately the testing portion of the infrastructure constructs a call to cargo, passing various details such as which rustc to use. The call itself could be nested in higher-level tools such as compiletest.
Is this close to reality?
Note that even if the "right" rustc is being called and so forth, post-test processing can still alter the state of a toolchain, thus invalidating the testing that was performed.

Because of the issues I mentioned re: "rustc is a cross compiler and host and target remain build parameters", I am slightly concerned that a test driver might have to be compiled, for each host, for each target, in a combinatorically explosive fashion, as is the case (as far as I understand it) with libstd's artifacts?

Unless I am misunderstanding, I do not think that this will be the case. The test driver would be compiled for each host. Since a testable cross Rust toolchain comes with its own cargo, rustc, host libstd, and target libstd, the test driver's job is to execute a compile command which indicates the host and target. cargo or rustc will then link the correct libstd and produce a target executable.

I realize "run tests for a random target that can't host the toolchain but would support most of the test suite via the remote-test-client and remote-test-server" isn't exactly trivial, so improving the experience of doing that is certainly something can get behind. Unless this proposal isn't actually concerned about such targets except as a "future possibility", and is only truly worried about hosts? In which case, it should probably say that, because there are more bins than "we ship a host Rust toolchain" and "this target doesn't support std". People are happy to accept "this isn't implemented for this target" and are disappointed to see "this was supposed to work for every target! ...but actually doesn't".

The proposal does take into account native and cross compilation, though it does not mention how to perform execution on the target (possibly via remote-test-client/-server).

Just to be sure: are you planning to do all the work that needs to be done for whatever solution we end up accepting?

I think such a big RFC is the wrong way to tackle this. As far as I understand, the problem being solved here is that you want to be able to test the distributed toolchains.
I think there are simpler ways to solve this problem, for example by just shipping the current testsuite as-is with some changes to tooling that would allow testing distributed toolchains.

We have had a few post-PGO/BOLT miscompilations which tests don't catch since those optimizations only happen on the dist runners but not on the test ones. So it would also be useful for the rust repo itself we could run the testsuite against dist artifacts too.

This has been fixed, we now run tests on post PGO artifacts. The optimized artifacts are tested before they are shipped.

Just to be sure: are you planning to do all the work that needs to be done for whatever solution we end up accepting?

No, AdaCore will not be doing all the work, as we were hoping that this effort would be community-led.

No, AdaCore will not be doing all the work, as we were hoping that this effort would be community-led.

What does that mean?
To me, "community-led" means that someone from the community, like yourself or AdaCore, is doing the work.

No, AdaCore will not be doing all the work, as we were hoping that this effort would be community-led.

While I do like the motivation, I don't think it is very high priority for volunteer contributors. To state this more controversially: Who other than AdaCore benefits from this work?
I would recommend trying to find an existing contributor that you can contract to do this work. I do fear otherwise this RFC may, even if accepted, become nothing more than that. We've had various RFCs and MCPs before that were well motivated, but ended up lacking a dedicated implementor to actually do the work.

Who other than AdaCore benefits from this work?

@oli-obk I suspect that Ferrous Systems (hello @skade, @pietroalbini !) would benefit from this work, as Ferrous Systems has and will continue to certify the Ferrocene toolchain for ISO 26262, and I assume they would care about the "Testing the artifacts to be distributed" and "Certification" motivations.

I would recommend trying to find an existing contributor that you can contract to do this work. I do fear otherwise this RFC may, even if accepted, become nothing more than that. We've had various RFCs and MCPs before that were well motivated, but ended up lacking a dedicated implementor to actually do the work.

Thanks for the suggestion, I will pass this along.

@Nilstrieb Out of curiosity, what kind of test would detect an improper packaging of a tool or a library?

@m-ou-se @Nilstrieb @oli-obk @the8472 Assuming that AdaCore does all the implementation work on the RFC, what would it take to get the RFC accepted?

@Nilstrieb Out of curiosity, what kind of test would detect an improper packaging of a tool or a library?

Compile hello world after extracting the tarball or something like that.

@m-ou-se @Nilstrieb @oli-obk @the8472 Assuming that AdaCore does all the implementation work on the RFC, what would it take to get the RFC accepted?

We'd want the best solution to your problems, which from what I've gathered so far, is not this RFC. If you list all the specific problems you're having, we may be able to come up with something better for each.

@Nilstrieb To understand the problem we are trying to solve with this RFC, we will need to switch our view point to the safety critical software paradigm. In this world, human lives depend on the correct operation of software. In a worst case scenario, a software error could lead to falling airplanes, exploding nuclear plants, etc.
To prevent this from happening, compilers and their libraries and runtimes are certified against a software safety standard, such as DO-178C. The certification aims to build high degree of confidence that the compiler will not generate wrong code under various conditions. To prove this, the compiler and the generated code are subjected to rigorous testing, where each test is linked back to requirements. Since nothing is without fault, known compiler issues are described and supplemented with detection, workaround, and mitigation strategies.
One way to achieve high degree of testing confidence is to test the delivered version of the compiler. This method ensures that the compiler being certified is the exact same compiler used to compile safety critical software. Our RFC is essentially trying to modify the existing testing process to achieve this methodology, while at the same time maintain developer friendliness.

Given the complexity and limited value to the community at large, I am retracting this RFC.
AdaCore plans to employ a sanity check test suite consisting of selected relocated cargo, clippy, core, and std tests, along with new tests, that exercise the toolchain after installation.
Thank you for your time, consideration, and reviews!


let borgs wear hat

About the PR
title
Why / Balance
its time to get festive
Technical details
no
Media
dapper

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog
:cl:

tweak: Borgs can wear hats now. Time to get festive!

this is the kind of stuff we desperately need

also this may need a whitelist since it could be bad for powergaming borgs to instantly get helmet for x% resistance

finally, borgs can now participate in tf2 hat economy

you can offset by making a new inventory template see how drone does it

how does it look on the different borg chassis

:trollface: edit time

better

looks wonky but whatever. main issue is with borgs wearing helmets and stuff but honestly i dont care that much lol

would be very bad if batong module existed then validhunter borgs would always wear helmet but rn there isnt much reason to, drip is far better

Thing is it has to account for the future alternative skins whenever we have them

alternative skins

borg loadout???

you can offset by making a new inventory template see how drone does it

can we use this to offset the inhand sprites for monkeys?

doesnt seem to use inventory layout for hand

DELTAAAAAAAA

ITS OFFSET FIX IT

its because (most) borgs have even width head but humans have odd width

DELTAAAAAAAA

ITS OFFSET FIX IT

its because (most) borgs have even width head but humans have odd width

.5 px offset or resprite this is unacceptable

nfi if half pixel offsets are a thing but wyci


Refactor the PostProcessing of the WindTunnel

In this PR, we refactor the post-processing methods of the WindTunnelOutput:

get_streamlines();
get_flow_slice().

The outputs of these functions are objects that provide immediate rendering capabilities, with various view options.
To compute both the streamlines and the slices of the flow, we use pyvista methods to extract these info from the flow measurements obtained from simulation over the whole domain mesh.
Before, these metrics relied on run-time processes to obtain a single cutting plane, a slice of streamlines and force coefficients.
This refactor empowers users and gives them all the flexibility to compute the aerodynamic metrics they want for several slices of the flow and varying the number of streamlines. Moreover, it reduces the needs for unnecessary files to be downloaded.
After this PR, I will remove the run-time steps.

The code is looking good @IvanPombo, thank you!
I have a couple of questions:

You are using a pattern different than that used in other scenarios, where the output class methods return objects that themselves can be rendered. Why not render stuff directly from methods of the output class?
Can you upload some of the visualizations obtained as comments to the PR?

In this way, one can do:
pressure_field = output.get_output()
pressure_field.render()

Or:
slice = output.get_flow_slice()
slice.render_frame()

In this way, you mesh data readily available for users to play with and render methods together with them. Otherwise, we would need to do
slice = output.get_flow_slice()
output.render_slice(slice,...)

which is not so intuitive.

In this way, you mesh data readily available for users to play with and render methods together with them. Otherwise, we would need to do
slice = output.get_flow_slice()
output.render_slice(slice,...)

which is not so intuitive.

Why not output.render_streamlines() or output.render_slice()?

In this way, you mesh data readily available for users to play with and render methods together with them. Otherwise, we would need to do
slice = output.get_flow_slice()
output.render_slice(slice,...)

which is not so intuitive.

Why not output.render_streamlines() or output.render_slice()?

Because, that implies creating the streamlines inside and losing them afterwards.
Or do you think creating attributes inside these function, like output.streamlines, is ok and intuitive?

Because, that implies creating the streamlines inside and losing them afterwards. Or do you think creating attributes inside these function, like output.streamlines, is ok and intuitive?

I don't see why you would have to store the streamlines. Is their computation expensive? Why would you want to recycle them?

I don't see why you would have to store the streamlines. Is their computation expensive? Why would you want to recycle them?

Manipulation, save them, metrics, etc..

Fair enough. I think we should tie them to this scenario then, WindTunnelStreamlines. If later we find other applications for them, we can generalize and reorganize the code.

I don't see why you would have to store the streamlines. Is their computation expensive? Why would you want to recycle them?

Manipulation, save them, metrics, etc..

Fair enough. I think we should tie them to this scenario then, WindTunnelStreamlines. If later we find other applications for them, we can generalize and reorganize the code.

I already have in mind for this to be adapted to other scenarios. HeatSink could easily use both streamlines and FlowSlices to have more render properties :) So I am not sure if it is worth the effort to make the name change, since in the next days we can add it there already!


Update field api json with VB.NET

Hi all,
I want to update a field using PATCH method but nothing move.
Some help ?

Ask questions on stackoverflow.


Change spotter - site link in the database

We need to update the relationship between sites and spotters to account for the fact that spotters will be replaced and a site may have multiple spotters over different time periods

This is resolved by https://github.com/aqualinkorg/aqualink-app/pull/457
However we still have (for compatibility reasons) the old endpoint with which you can fetch any reef-application unrestricted (provided that you guess the hashed id or the uid correctly)
Anything else that should be done on this @ericboucher ?

This is partially solved with the sources table, since we can track the sensor of the reef at certain period.
Do we need more functionality?

I think we need to take a step back and make the system evolve still. We want to be able to backfill a site that has had different spotters over time. Can you propose a few ways to do this?


DeviceInfo.getDeviceName() returns 'unknown' on Android

Summary
We just upgraded from DeviceInfo v8.3.2 to v10.1.2 and noticed that DeviceInfo.getDeviceName() is always returning 'unknown' on Android.

Version
10.1.2

Affected OS
Android

OS Version
12, 13

Current behavior

DeviceInfo.getDeviceName() always returns 'unknown' as the device name.
Expected behavior

DeviceInfo.getDeviceName() should return the actual device name.

Hi there!
I just pulled the repo and ran the example. I can't reproduce
https://github.com/react-native-device-info/react-native-device-info/blob/7387a623a4f9a4445b81a73172fb54a9c5ef5f37/example/App.js#L207
If you can reproduce this using the example please let me know. Note that the example needs a refresh but I removed example/yarn.lock and re-ran yarn example:install to make sure it pulled fresh / updated code here from master, and it works like this

I should mention - execution environment, I ran that test against an API33 / android 13 emulator

Okay, I finally got some time to dig into this and I realized it's due to the fact that our app is targeting API 31. That causes the Settings.Secure.getString(getReactApplicationContext().getContentResolver(), "bluetooth_name"); call to throw an exception: Settings key: <bluetooth_name> is only readable to apps with targetSdkVersion lower than or equal to: 31.
That exception causes us to get thrown into the exception block so we don't even get the chance to try the Settings.Global.getString(getReactApplicationContext().getContentResolver(), Settings.Global.DEVICE_NAME); alternative.
My plan is to patch this for our use by wrapping the 'bluetooth_name' call in a version check. Curious if that makes the most sense to you or if there are other plans for API 31+?

Oh interesting - no other plans at the moment, if it throws an exception it seems it should definitely be in a try/catch or version detection conditional. Any reasonable PR like that seems like an easy merge

I made a PR for this: https://github.com/react-native-device-info/react-native-device-info/pull/1471


Firstb

Related Issues
improve discord banner  interaction
Proposed Changes
hover effect on the banner font
https://user-images.githubusercontent.com/60725346/136591813-49399ab0-97b4-4566-8b3c-9e41d132164b.mp4

Thanks for the contribution @harshitpaliwal95 🚀

These two contributions are my first time 🤩 and i m loving it thank you so much Opentek


permissions: files not writable

From @Neil-Swanson:

Hi Ben,
I’m running into some permissions issues again.  I’m trying to run the ‘generate_all_data.R’ script from the Shiny rep to update the three .csv files that are inputs to the Projects page.  I’ve updated the Google Sheet on the Google Drive with the new project info from Grace/Sharon, so these files need to be updated.  Would you mind running the script to get the new datasets ready?

This is a recurring problem despite thinking I fixed it, per mhk-env_server-software: README.md:
echo 'umask 002' >> /etc/profile

Problem
So despite setting the Linux environment properly with group write permissions (with the umask), the R session overrides to being without group write:
Sys.umask()
# "22"
fs::file_touch("data/test_r.txt")

Sys.umask("002")
fs::file_touch("data/test_r2.txt")
Sys.umask()
# "2"
readr::write_csv(data.frame(a = 1:3), file = "data/test2.csv")

cd /share/github/mhk-env_shiny-apps/data
umask
# 0002
touch test.txt
ls -la | grep test
# -rw-r--r--  1 bbest staff        0 Mar  4 16:43 test_r.txt
# -rw-rw-r--  1 bbest staff        0 Mar  4 16:42 test.txt
tail -1 /etc/profile
# umask 002

RStudio Server config? No
Then I thought I found where RStudio Server was overriding this here:
https://docs.rstudio.com/ide/server-pro/1.2.1237-1/access-and-security.html#umask
sudo vi /etc/rstudio/rserver.conf
# server-set-umask=0
docker exec -it rstudio bash

but that didn't work.
Solution: Sys.umask("2") in Rprofile.site
Went ahead with overriding user file mask for all users by editing Rprofile.site Managing R with .Rprofile, .Renviron, Rprofile.site, Renviron.site, rsession.conf, and repos.conf – RStudio Support.
Get directory:
R.home(component = "home")
# "/usr/local/lib/R"

Edit Rprofile.site:
sudo vi /usr/local/lib/R/etc/Rprofile.site

Add this line:
Sys.umask("2") # allow group write vs default 22 group read only

Systematically do this once during installation, now in mhk-env_server-software: README.md:
docker exec rstudio sh -c "echo 'Sys.umask('2')\n' >> /usr/local/lib/R/etc/Rprofile.site"

Hi  @Neil-Swanson,
I reran all, and hopefully fixed for future :) Wanted to log these for future reference. Also here's the quick for future in Terminal of rstudio.marineenergy.app:
# change directory, eg
/share/github/mhk-env_shiny-apps/data

# change mode as superuser with group write permissions recursively
sudo chmod -R g+w *

Look at permissions of file
bbest@df3e3af5e27f:/share/github/mhk-env.github.io_dev$ ls -la | grep mgt
-rw-rw-r--  1 bbest    staff  339951 Feb  3 19:49 mgt.html
-rw-r--r--  1 bbest    staff    1171 Feb  3 19:48 mgt.Rmd

So we're missing the group write permission.
Fix permissions
To add the group write permission, please use the command mentioned previously:
# what's the present working directory?
pwd

# superuser do (sudo) change mode (chmod) recursively (-R) group (g) add (+) write (w) permissions on all (*) files within the present working directory
sudo chmod -R g+w *

Check all's well
# list permissions if mgt file
$ ls -la | grep mgt
-rw-rw-r--  1 bbest    staff  339951 Feb  3 19:49 mgt.html
-rw-r--r--  1 bbest    staff    1171 Feb  3 19:48 mgt.Rmd

# get present working directory
$ pwd
/share/github/mhk-env.github.io_dev

# fix permissions
$ sudo chmod -R g+w *

# check that the write flag to the group got added
$ ls -la | grep mgt
-rw-rw-r--  1 bbest    staff  339951 Feb  3 19:49 mgt.html
-rw-rw-r--  1 bbest    staff    1171 Feb  3 19:48 mgt.Rmd

$ groups nswanson
nswanson : staff sudo shiny


items schema of an array field is not displayed if anyOf is used

Describe the bug
the following schema
schema
---
openapi: 3.0.3
servers:
  - url: https://
info:
  title: ""
  version: "1.0"
components:
  securitySchemes:
    basicAuth:
      type: http
      scheme: basic
paths:
  "/test":
    summary: summary
    post:
      summary: summary
      security:
        - basicAuth: []
      responses:
        "200":
          description: ""
          content:
            application/json:
              schema:
                type: object
                properties:
                  id:
                    type: integer
      requestBody:
        content:
          application/json:
            schema:
              type: object
              properties:
                items:
                  type: array
                  items:
                    anyOf:
                      - type: object
                        properties:
                          a:
                            type: integer
                      - type: object
                        properties:
                          b:
                            type: integer

is displayed as

Schema of the items options is not displayed.
Expected behavior
The schema is displayed in a way that elements in anyOf property of items are displayed.
Current behavior
Schema of the items options is not displayed.
Steps to reproduce

Use the schema from this issue
yarn docusaurus gen-api-docs all
yarn start
go to the page that shows API schema

Hi @maciekpitucha, thanks for reporting. This is a new edge case for our plugin that I believe we can support. My initial thought is that we can use DiscriminatorTabs to allow for choosing the object schema you want to reference inside the array.

Hi @maciekpitucha, thanks again for bringing this issue to our attention. It actually pointed me to a bug that we hadn't noticed before which could have prevented schema properties from rendering in some cases.
Does the following match what you would expect to see?

@maciekpitucha the fix is now available to test using canary release 0.0.0-515.


Include examples of fetching data

As-is, ReactServerAgent is mostly undocumented.  We may want to borrow @aickin's example and stick it somewhere in the docs.

Yep, needs to be discoverable.

+1


(GH-13) Building against cake 0.22.0.

Can you take a peek @AdmiringWorm when you get a chance?
Thanks!

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   88.23%   88.23%
=======================================
  Files           3        3
  Lines         136      136
  Branches       19       19
=======================================
  Hits          120      120
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7ac61...0427617. Read the comment docs.


TramplerPatch2 Crash on M&B 1.4.1 and CP v0.1.0-rc4

A crash appears immediately on contact with enemy while on a horse and only appeared after updating to newest release of CP mod. I verified and could reproduce even after disabling every other mod (except one non-combat mod that breaks saves on removal)
Crash trace:

Mount and Blade Bannerlord has crashed
Mount and Blade Bannerlord has encountered an error and needs to close. See the error information below.
NullReferenceException:
Object reference not set to an instance of an object.
Stack trace:
at DMD<DMD<__refget_Object_fi_AttackerAgentCharacter>?29840268::__refget_Object_fi_AttackerAgentCharacter>(Object )
at CommunityPatch.Patches.Perks.Endurance.Riding.TramplerPatch2.UpdateCorrectCharacterForHorseChargeDamagePostfix(Object& __instance, Agent attackerAgent, AttackCollisionData& attackCollisionData)
at DMD<DMD<.ctor_Patch1>?45319986::.ctor_Patch1>(AttackInformation& this, Agent attackerAgent, Agent victimAgent, GameEntity hitObject, AttackCollisionData& attackCollisionData)
at TaleWorlds.MountAndBlade.Mission.GetAttackCollisionResults(Agent attackerAgent, Agent victimAgent, GameEntity hitObject, Single momentumRemaining, AttackCollisionData& attackCollisionData, Boolean crushedThrough, Boolean cancelDamage, WeaponComponentData& shieldOnBack)
at TaleWorlds.MountAndBlade.Mission.ChargeDamageCallback(AttackCollisionData& collisionData, Blow b, Agent attacker, Agent victim)
at ManagedCallbacks.CoreCallbacksGenerated.Mission_ChargeDamageCallback(Int32 thisPointer, AttackCollisionData& collisionData, Blow b, Int32 attacker, Int32 victim)
at TaleWorlds.MountAndBlade.MissionState.TickMission(Single realDt)
at TaleWorlds.MountAndBlade.MissionState.OnTick(Single realDt)
at TaleWorlds.Core.GameStateManager.OnTick(Single dt)
at TaleWorlds.Core.Game.OnTick(Single dt)
at TaleWorlds.Core.GameManagerBase.OnTick(Single dt)
at DMD<DMD<OnApplicationTick_Patch1>?1954641::OnApplicationTick_Patch1>(Module this, Single dt)

OK

It's strange, since the NRE is occurring in the field ref dynamic method, it means the instance is null, but I'm not sure if that's  possible... trying to recreate...

https://puu.sh/FJhmg.png
I have the issue too, I believe the above picture shows it, looks exactly the same

I however wasn't the one to do ramming, this is the last picture capture I had. So one of the units must have triggered it

@harlanrs @PackOfDingoes i don't suppose either of you have a save that can reproduce this? Preferrably with a minimal amount of mods?

@iPherian Here's a save that reproduces the above bug, with all mods disabled (I can produce a list of mods that were in use when the save file was originally created, if needed).
Steps to reproduce:

The party contains 4x Aserai Noble Sons, set them to unit 8
Engage the pack of 7x Looters next to the PC
Select unit 8 and F1, F3. The game will crash as soon as the Aserai Noble Sons contact the looters.

I was just uploading mine, but with australian internet it takes ages, so glad you swooped in lol.

Was just about to upload as well. LMK if y'all want any more saves to test against.
Thanks for the responses as well. I appreciate the work y'all put in.

Also happened to me, new save, just met looters, and crash on contact.

@genisaurus thanks for the save and detailed instructions!

UpdateCorrectCharacterForHorseChargeDamagePostfix is getting a ref of a struct as an argument.
here's the issue... This is a constructor on a type that doesn't exist on previous versions. Referring to the type directly works, but breaks the build against older versions of the game.
Since the fallback "ref object" is supposed to work for __instance according to documentation, that's what it was changed to.
So we need to use 'void *' instead and then make a ref pointer/setter. I'm working on it.

Needs confirmation that it's fixed in rc5.

RC5 fixed the issue for me.

Fixed for me as well!

No crash so far for me in 2 battles with a lot of Cav units.

Ok, closing under the assumption it's fixed. Feel free to ping this issue or post a dupe if something happens that seems related.

Not quite fixed. Might still crash when getting trampled and some other variations.
Needs more testing.

This is still bugged in custom battle. Need to work out what to do about lack of perks.

This has been fixed with the latest releases. Closing


Add SwiftPM and iOS/watchOS/tvOS support

Add Package.swift so that swift build and swift test works.
Use universal frameworks xcconfigs to support all Apple
platforms.
Fix some syntax errors so tests compile.

This is incredible - thank you so much @dduan!


Highlight bad Epochs instead of dropping them when preload=False upon plotting

Describe the new feature or enhancement
Hello! I am currently working on a feature to drop Epoch based on callables in #12195, and thought it would be a nice feature to be able to see which Epochs would be dropped (since you may have complicated callables) if preload=False in the Epochs constructor.
Describe your proposed implementation
I think this could be implemented by displaying the rejected epochs instead of dropping them when plotting. For instance:
epochs = mne.Epochs(
    raw,
    events,
    tmin=-0.2,
    tmax=0.5,
    reject_tmax=0,
    reject=reject_criteria,
    flat=flat_criteria,
    reject_by_annotation=False,
    preload=False
)
epochs.plot()

Hypothetical output (Epochs in red will be dropped):

Describe possible alternatives
Maybe instead of this method. I can add another parameter, but I think this is too complicated.
Additional context
No response

Based on how Epochs works under the hood, I suspect this would be complicated to implement.
Another way to accomplish something similar using current API would be with something like
all_epochs = mne.Epochs(..., reject=None)
good_epochs = all_epochs.copy().drop_bad(reject=reject_criteria)
bad_epochs = all_epochs[np.setdiff1d(all_epochs.selection, good_epochs.selection)]
bad_epochs.plot()

It would only plot the bad ones but maybe it's good enough?


Fonts.com version is hanging with the class wf-loading, no events called

I had this working on a live site for a while but recently it stopped calling the active function.
I have a pen here to simulate the live site (which I'm going to remove webfontloader in the meantime). If you look in the console you will see only 'loading' being called. https://codepen.io/petebarr/pen/RRrNqm

I'm seeing this too.

I was able to fix this issue by updating to the latest version of webfontloader.

@pburke but he is using the most recent version...
I am also experiencing this problem. I am using:
wf.src = 'https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js';
Which gets 1.6.16 There is no higher version at this time hosted by googleapis.com.

It appears that the problem is with fonts.com. If I comment out my projectId within the monotype object, the .wf-loading class gets removed from the html and .wf-active class is added.

I'm running 1.6.26 via NPM and running into this issue as well. Per @lexbi's comment, I've reached out to Monotype as well to make sure their support staff is aware of this problem.

I got the follow response from Monotype:
_Hello Peter,
I apologize for your inconvenience. It sounds like you might be using an older version of the webfont loader API (if you are using the Google hosted version, it is very outdated at 1.6.16). You can use an up-to-date version of the API by hosting the JavaScript file with your website itself or by using the CloudFlare CDN's hosted version:
https://github.com/typekit/webfontloader
https://cdnjs.com/libraries/webfont
Additionally, if you are using a node-based backend, it may interest you to know that the maintainer of the GitHub repo also maintains an npm package:
https://www.npmjs.com/package/webfontloader
Let us know if you have any further questions.
Best Regards,
Domenic_

@petebarr: Looking at the gitHead SHA in my /node_modules/webfontloader/package.json, I'm seeing 33bec9da7ca4b0a46b1efbaca705c2ae5029840b which corresponds to the release of v1.6.26, and still running into this issue (the loading callback works, but active does not fire).
I've e-mailed Domenic that this was the case as well.

@dkozma Yeah, I'm getting a timeout this time round. Not sure if this might be down to the iframe in codepen for fonts.com, but the typekit version works perfectly.

For me, the fonts load, but the active event doesn't fire. The library is also correctly getting a 200 when loading the font resource.
I tried to debug the webfontloader library, however it seems that NPM is pointing to the minified /webfontloader.js file which is hard to put debug statements into. Unfortunately, there's not much documentation on how to easily modify/debug the source files (that I can find, at least).

Just requested google update their hosted libraries here: https://groups.google.com/forum/#!topic/google-ajax-search-api/SpsP5bmc_pc
No idea if any google staff actually view that forum, but, hopefully someone will suggest where else we could submit that request if not.

Monotype's customer support got back to me with the following response (which is pretty awesome of them since this library probably isn't an officially supported means of integration):

Yes, this is something that our developers are aware of. If you'll notice in the CodePen, there is a "loadAllFonts" property that is commented out. If you enable that property, you will find the commonly expected behavior in regards of which events fire.

The gist of the issue is that our service's JavaScript is fairly specialized in that it will only include web fonts from the project if it detects that the page is actually using them. For example, if a project has three web fonts included but the JavaScript only detects that the page is trying to use one of them, it will only include that one into the page and therefore one will be active and the other two will be inactive.

This "partial" state (1/1 attempted fonts loaded but also 1/3 total fonts loaded) is resulting in the ambiguous decision of whether to produce the general "active" or "inactive" callbacks (the individual font callbacks function more predictably).

As such, there are a few ways to proceed if you are set on using the web font loader to include your Fonts.com web font project and provide callbacks:

If you are set on using the general/overall events that are provided, then you can ensure that the page is using all web fonts from the project by removing some from the project that are unused, or, more practically, by enabling the "loadAllFonts" property in the WebFontLoader config block

If you can, it may be worthwhile to ignore the general/overall events provided and instead monitor for font-specific events. You can then consider keeping track of fonts loaded vs. inactive and react accordingly (e.g. with logic like "If X number of fonts loaded are inactive (failed to load), do Y").

Following their advice, I tried adding loadAllFonts: true to my monotype config key and after that both the active and fontactive events fired successfully. Since I only have the fonts I'm using within in my page contained in my project, I don't think this will have an effect on payload size for me, however you might want to keep this in mind if your project is set up differently.

I got the same response, they were very helpful. I'll be trying it tomorrow but great it's working for you.

1.6.26 is now available from google, BUT, doesn't work with the "1" version which I think is deprecated? But still used on google font's snippets.
https://ajax.googleapis.com/ajax/libs/webfont/1.6.26/webfont.js
https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js - still 1.6.16
I've asked google to update that too.

On Sun, Aug 7, 2016 at 1:22 PM, joe<EMAIL_ADDRESS>wrote:

1.6.26 is now available from google, BUT, doesn't work with the "1"
version which I think is deprecated? But still used on google font's
snippets.
https://ajax.googleapis.com/ajax/libs/webfont/1.6.26/webfont.js
https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js - still 1.6.16
I've asked google to update that too.

FWIW, I am seeing v1.6.26 served for https://ajax.googleapis.com/
ajax/libs/webfont/1/webfont.js
$ wget -O - https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js
2>/dev/null | grep 'Web Font Loader' | cut -c -78
/* Web Font Loader v1.6.26 - (c) Adobe Systems, Google. License: Apache 2.0
*/
$ wget -O - https://ajax.googleapis.com/ajax/libs/webfont/1.6/webfont.js
2>/dev/null | grep 'Web Font Loader' | cut -c -78
/* Web Font Loader v1.6.26 - (c) Adobe Systems, Google. License: Apache 2.0
*/
$ wget -O - https://ajax.googleapis.com/ajax/libs/webfont/1.6.26/webfont.js
2>/dev/null | grep 'Web Font Loader' | cut -c -78
/* Web Font Loader v1.6.26 - (c) Adobe Systems, Google. License: Apache 2.0
*/

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/typekit/webfontloader/issues/331#issuecomment-238106050,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOysgKQXFjuUVA9nbACNXOZdqmvplZ1ks5qdj6KgaJpZM4JQsc0
.

  I was able to get to the bottom of this.  You are correct
in that the older version is being cached.  When I checked internally, the
request bypassed the cache, thus the different response.
Long story short though, support for aliases e.g. /ajax/libs/webfont/1,
/ajax/libs/webfont/1.6 has been deprecated for quite a while now.  To
pickup the latest version, users will need to reference it directly. e.g.
/ajax/libs/webfont/1.6.26.
While aliases worked out quite well for webfont.js, it was problematic for
other libraries, where changes would end up breaking integrations.  Thus
the larger push to deprecate aliases.

the 1 version now loads 1.6.26 fine, but, I'd still use a link to the specific version
https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js


Simulator gets stuck if a Thang fails to load

My current fuzzing setup fails 5% of the calls to /db/thang.type/... The frequently results in the simulator getting stuck at "Setting up simulation". A behavior I see somewhat regularly on the live site.  It would be nice if we could recover gracefully from Thangs failing to load.

@yaur I haven't implemented request retries, but do you still see occasional ThangType load failures causing to "Setting up simulation" hangs? Recently it seems that simulations have been much more stable.

Closing unless this still seems to be a frequent problem with ThangType requests failing.


[21pt] Determine optimal crosswalking method

From Shutdown Planning (@CarsonPruitt-NOAA):
Determine optimal crosswalking method using new tool

Midpoint method
Majority Catchment method
Hybrid approach of the two (e.g. midpoint on branch 0 and catchment on GMS branches)
Carter method used in ras2fim

Originally posted by @mluck in https://github.com/NOAA-OWP/inundation-mapping/issues/1000#issuecomment-1756202951

Initial comparison of crosswalking methods (midpoint, majority catchment, and hybrid approaches) for two HUCs (highest score in bold and lowest in italics)

branch 0
other branches
magnitude
HUC
CSI
MCC
HUC
CSI
MCC

midpoint
midpoint
100 yr
12040101
0.60651
0.70975
12090301
0.67861
0.77242

catchment
catchment

0.60545
0.70859

0.67517
0.76981

catchment
midpoint

0.60546
0.70865

0.67852
0.77237

midpoint
catchment

0.60646
0.70965

0.67653
0.77084

midpoint
midpoint
500 yr
12040101
0.62482
0.71151
12090301
0.71492
0.79080

catchment
catchment

0.62526
0.71168

0.71308
0.78940

catchment
midpoint

0.62517
0.71163

0.71489
0.79081

midpoint
catchment

0.62492
0.71157

0.71412
0.79016

A preliminary comparison of the midpoint vs. majority catchment crosswalking algorithms suggests that the midpoint method (currently in use) results in slightly fewer crosswalking errors than the majority catchment method. In the hybrid/mixed methods (e.g., using midpoint for branch 0 and majority catchment for the remaining levelpath branches), the method used for branch 0 was identical to using that same method for all branches. In other words, the effect of the two crosswalking algorithms was only evident in stream orders 1 and 2, and levelpath branches had the same amount of crosswalking error regardless of crosswalking algorithm.

HUC
method
crosswalking tool
correct
total
crosswalking tool
correct
total

12040101
midpoint
intersections
1534
1997
tree
1231
1555

catchment

1483
1997

1175
1555

12090301
midpoint

2809
3585

2374
2865

catchment

2754
3585

2326
2865

18100201
midpoint

2206
2902

1707
2264

catchment

2127
2902

1523
2264


How to color header? (for console)

I tried table.setRowConfig(0, { color: 'cyan' ) but it doesn't work
For the context, I'm trying to output this table into console, console.info(table.toString())

After some trial-and-error, found out it's required to table.toString({ ansi: true }) for colors to work.


An error occurred with entity meta data for ...

What version of ViaVersion are you using? Type /ver viaversion
0.8.2
What version of Spigot are you using? Type /ver
Latest 1.8.8 paperspigot
What plugins are you using? Type /plugins
Not relevant I think
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Also not usefull
How does this error happen? login? Using an item?
Not sure, it get's spammed a few times in console, might have something to do with particles
Is there an error in the console? Use pastebin.com. Is there a kick message?
http://pastebin.com/Wp4XCARJ

First of all, plugins are always relevant.
Second of all, one of your plugins is sending invalid metadata.
You can disable this message in your config.


Integrate Clinvar with SVs

@hanars commented on Thu Apr 23 2020
Might also involve using Clinvar's dosage sensitivity

This is probably part of the Talkowski SV/gCNV pipeline process.


SQL Server bulk insert target

Hi, I have previously implemented a custom target that uses SQL Server's proprietary bulk insert API. I'm thinking about updating it for inclusion into the main NLog project.
Would this contribution likely to be accepted? I guess it would be in its own project/package, NLog.Extensions.SqlServer or something.
Cheers, Aled.

Unless you are writing 50.000 records/sec. Then I think a NLog target that could concat multiple Sql-statements into a single transaction would be more useful. Anyway not using the DatabaseTarget, so maybe not be best to answer this question :)

Thinking about this.
With an async/buffer target, it could make sense.
Was thinking of a NLog.Target.SqlServerBulk package, but it will create a new repo for that.
@aled do you think we could proper unit test this?

Unit tests should be no problem. Am I right in thinking that the builds/tests are run on appveyor? If so, SQL Server is available in their build environments, so it should be possible to run tests against a real database, rather than mocking it out.

@aled
Need any help on this?
A late answer on your question:

Am I right in thinking that the builds/tests are run on appveyor? If so, SQL Server is available in their build environments, so it should be possible to run tests against a real database, rather than mocking it out.

Yes those are on appveyor. You could do it without mocking, but it would make the test slower. Also it would be an integration test (which we already have for the DB target). So I prefer mocking :)

I wasn't sure whether I should start it or not, as the issue was assigned to you.
The only area I might need help with is testing with all the various runtimes that nlog supports (Xamarin iOS, windows phone, silverlight, etc). I'll make it work with .net core and .net framework initially and then look at the others.

I wasn't sure whether I should start it or not, as the issue was assigned to you.

that's means I have to react ;) (or someone else). You can't set notification to unread in Github :(

The only area I might need help with is testing with all the various runtimes that nlog supports (Xamarin iOS, windows phone, silverlight, etc). I'll make it work with .net core and .net framework initially and then look at the others.

IMO you could disable it for Xamarin iOS, windows phone, silverlight. See the various #if regions in the code

Initial implementation here: https://github.com/aled/NLog.Targets.SqlServerBulk
Only implemented as a .net standard library for now. Probably needs more error handling (this is one area of NLog I'm not very familiar with tbh)
Any criticism or comments welcome.

briefly looked at, but looks good!

What is the performance difference between your MsSqlServer specific approach, and this more generic approach that works for MsSql, MySql and SqlLite?
https://codereview.stackexchange.com/questions/193462/fastest-way-to-insert-rows-in-mysql-vs-sqlserver-large-dataset
Would "just" require that one loads the DbProvider-SqlDataAdapter, and then one can send bulk-data to many different databases.

SqlBulkCopy  is SqlServer only and AFAIK the recommend approach when using Sql Server

But if SqlDataAdapter is just as fast and works on many database type. Why not focus on that?
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
SqlBulkCopy is SqlServer only and AFAIK the recommend approach when using Sql Server
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/2821#issuecomment-425937882, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnKSGCB0hkyMx-LfnaXiDemAIjr2pks5ugizrgaJpZM4VnTha.

But if SqlDataAdapter is just as fast and works on many database type. Why not focus on that?

good point, but I don't know for sure if that's true. e.g. the bulkInsert could ignore triggers and checks, and that MS specific.

https://codereview.stackexchange.com/questions/193462/fastest-way-to-insert-rows-in-mysql-vs-sqlserver-large-dataset

there is nothing about SqlBulkCopy  there?

FYi: SQLBulkCopy  is still a recommend approach of MS: https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2008/dd425070(v=sql.100)

The goal is to avoid calling the database 100 times, for saving 100 LogEvents. Whether using SqlBulkCopy or SqlDataAdapter gives the same result by saving a DataTable in one call.
I think the difference between SqlDataAdapter and SqlBulkCopy is the ability to save 50.000 records/sec vs 100.000 records/sec. I don't think anyone is planning to reach those levels.
Anyway don't mind me. Please continue your quest. I was just curios about the choice of direction.

It would be silly if Microsoft did not recommend the MS-approach for a MS-database, else there would not be any lock-in of technology.

That's kinda of biased ;) I have my fate in MS since .NET Core/Nadella :)
I think the bulk-insert-sql-server-only-target is a nice addition, even when it's SqlServer only.

I think the bulk-insert-sql-server-only-target is a nice addition, even when it's SqlServer only.

Sure is. Especially when changing inheritance to the builtin DatabaseTarget with support for IRawValue.

inheritance to the builtin DatabaseTarget

That's a very good idea.
@aled  could you inherit from the current DatabaseTarget ?

@aled could you inherit from the current DatabaseTarget ?

I guess so, hadn't thought about it. What would be the advantage of doing this?

What is the performance difference between your MsSqlServer specific approach, and this more generic approach that works for MsSql, MySql and SqlLite?

Looking at the code in the linked StackOverflow question, it doesn't seem like a generic approach; the C# code is different depending which database it is writing to, and it requires a stored procedure on the database (again, different depending which database it is).
That SQL Server technique (passing a table-valued parameter into a stored procedure) is in my experience likely to be similar in performance to a bulk insert; though with the disadvantage that it requires a stored procedure. The advantage of that approach is the ability to do clever things in the stored procedure, for instance inserting new rows or updating rows if they already exist; but for logging it is not particularly useful.
The MySql technique (passing a big JSON payload and parsing it in the stored procedure) is perfectly legitimate, but it isn't the fastest technique on SQL Server. So I would prefer to keep the SqlServerBulk target as it is, i.e. specific to, and optimised for, SQL Server.
I would create a MySqlBulkInsertTarget that works with MySql, if that was my database.

@aled Sorry about. Just saw the use of MySqlDataAdapter and DataTable. Didn't see the JSON-payload
Maybe this is a more generic example:
var mySqlDataAdapter = new MySqlDataAdapter();
MySqlCommand ins = new MySqlCommand("INSERT INTO test (id, name) VALUES (?p1, ?p2)", conn);   // Replace with SQL where parameters matches columns
mySqlDataAdapter.InsertCommand = ins;
ins.UpdatedRowSource = UpdateRowSource.None;
AddParametersToCommand(ins);   // One parameter for each column

var dataTable = CreateDataTable();  // Initialize columns in DataTable
foreach (var l in batch)
   AddRow(dataTable, l.LogEvent);

mySqlDataAdapter.UpdateBatchSize = 100;
mySqlDataAdapter.Update(dataTable);

Most efficient way to insert Rows into MySQL Database
DataAdapter.Update slowdown

@aled Sorry about that example. Just saw the use of MySqlDataAdapter and DataTable. Didn't see the JSON-payload
Maybe this is a more generic example:
var mySqlDataAdapter = new MySqlDataAdapter();
MySqlCommand ins = new MySqlCommand("INSERT INTO test (id, name) VALUES (?p1, ?p2)", conn);   // Replace with SQL where parameters matches columns
mySqlDataAdapter.InsertCommand = ins;
ins.UpdatedRowSource = UpdateRowSource.None;
AddParametersToCommand(ins);   // One parameter for each column

var dataTable = CreateDataTable();  // Initialize columns in DataTable
foreach (var l in batch)
   AddRow(dataTable, l.LogEvent);

mySqlDataAdapter.UpdateBatchSize = 100;
mySqlDataAdapter.Update(dataTable);

Most efficient way to insert Rows into MySQL Database
DataAdapter.Update slowdown

This looks like a good solution for MySql. But I can't see how it would work on SQL Server (correct me if I am wrong).
Having said that, most of the code in the SqlServerBulk target is not actually specific to SQL Server. It should be possible to factor out the generic code into an abstract class, and have a subclass for each database, implementing the bulk insert in the most appropriate way for that database.

This looks like a good solution for MySql. But I can't see how it would work on SQL Server (correct me if I am wrong).

I was guessing the logic would be the same for SQL-Server. Just replace MySqlDataAdapter with SqlDataAdapter and MySqlCommand with SqlCommand.

That SQL Server technique (passing a table-valued parameter into a stored procedure) is in my experience likely to be similar in performance to a bulk insert; though with the disadvantage that it requires a stored procedure.

Also in that case you need to creating a Table-Valued Parameter Type. Which isn't always  what you want.

Also in that case you need to creating a Table-Valued Parameter Type. Which isn't always what you want.

Not sure I understand. The example shown here does not depend on custom user defined table type. It is not sending the DataTable directly over the wire. Ex the Microsoft SqlDataAdapter will build an internal SqlCommandSet (Collection of DbCommands) and send them over in a single batch.

for passing a table-valued parameter into a stored procedure, you need to create a Table-Valued Parameter Type?  See https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql/table-valued-parameters

for passing a table-valued parameter into a stored procedure, you need to create a Table-Valued Parameter Type?

But the the Microsoft SqlDataAdapter takes the rows in the DataTable and converts into DbCommands that are then bulk-saved into the database using SqlCommandSet. I repeat that my example doesn't sent the DataTable as a Table-Valuet parameter.

But the the Microsoft SqlDataAdapter takes the rows in the DataTable and converts into DbCommands that are then bulk-saved into the database using SqlCommandSet. I repeat that my example doesn't sent the DataTable as a Table-Valued parameter.

I don't think I've ever used SqlDataAdapter.Upate(). Looks like a good way to do bulk updates without needing a TVP.

Initial implementation here: https://github.com/aled/NLog.Targets.SqlServerBulk
Only implemented as a .net standard library for now. Probably needs more error handling (this is one area of NLog I'm not very familiar with tbh)
Any criticism or comments welcome.

Hey, this looks great. I'm planning on using something like this with the buffering wrapper. I'm not a fan of copy/pasting code, so I was wondering if this is something that was being considered for incorporation into a future release. As it stands right now, sending 5000 individual insert statements as separate commands every few seconds in my app is abysmal. The old log4net database adapter had a built-in buffer so I was surprised to see NLog's OOTB support for bulk inserts was so limited.

@D9001 Can you show me the log4net-appender that performs bulk-insert? If you mean the default adoappender then I think it is merely reusing the same connection and dbcommand when doing batching. I think the NLog DatabaseTarget can be easily modified to do the same.
If I create a pre-release nuget-package of NLog, would you be willing to test performance?

Hey, I would be very glad to test it. I may be mistaken about how the
adoappender worked. I hadn't used it in a microservice environment where I
would've tested its performance to the same extent.
On Wed, Feb 20, 2019, 1:33 AM Rolf Kristensen<EMAIL_ADDRESS>wrote:

@D9001 https://github.com/D9001 Can you show me the log4net-appender
that performs bulk-insert? If you mean the default adoappender then I think
it is merely reusing the same connection and dbcommand when doing batching.
I think the NLog DatabaseTarget can be easily modified to do the same.
If I create a pre-release nuget-package of NLog, would you be willing to
test performance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NLog/NLog/issues/2821#issuecomment-465444002, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AtlarEi-IFpQDTnRZuJD8DBbG8TDmxdmks5vPOw_gaJpZM4VnTha
.

@D9001 Created https://github.com/NLog/NLog/pull/3131#issuecomment-465779908 (With custom build attached).

Created #3150 as a prototype of using MySqlDataAdapter

Closing as NLog will not get a Microsoft-SQL-Server specific target. Instead it should be created as seperated nuget-package.


Change Model::FIELDS to be an array with column info

I thought originally this would be a good idea but it would just add extra coding that would go unused.


Make the function bnd_associatedObservableForValueForKey public

I wanted to extend NSLayoutConstraint and add bnd_constant to it, but currently it's inconvenient because the function bnd_associatedObservableForValueForKey is internal to Bond.

Will make it public.

Done.


Upgrade Grpc.Net.Client library (Vulnerability Issue - Connection Confusion)

Describe the bug
In our application we found out vulnerability issue (Connection Confusion) regarding Grpc.Net.Client library which this library uses. Issue was found with Veracode scans.
Dependency graph:
eventdriven.eventbus.dapr 1.3.6 -> dapr.aspnetcore 1.10.0 -> dapr.client 1.10.0 -> grpc.net.client 2.47.0
Please upgrade affected libraries that will use at least grpc.net.client 2.52.0 in which Connection Confusion vulnerability is fixed.
Additional context
grpc is vulnerable to Connection Confusion. The vulnerability exists when the gRPC HTTP2 stack raised a header size exceeded error, and it skipped parsing the rest of the HPACK frame, which caused any HPACK table mutations also to be skipped, resulting in the desynchronization of HPACK tables between sender and receiver, leading to requests from the proxy being interpreted as containing headers from different proxy clients, allowing an attacker to gain sensitive information and gain access to the system or data exfiltration.

This dependency needs to be fixed in the Dapr.Client library. I opened this issue there: https://github.com/dapr/dotnet-sdk/issues/1137
In the meantime, you can simply create a direct reference to grpc.net.client 2.52.0 in your project(s). Please let me know if this addresses your issue.

Closing this issue, as it can be resolved by referencing grpc.net.client 2.52.0 in your projects. Since this is an indirect dependency, it is best resolved in this fashion, until the .NET Dapr SDK updates its reference to the GRPC library.

This issue has been resolved with Dapr version 1.12. This is referenced by Dapr Event Bus v1.4.0. Please upgrade to this version and also upgrade your Dapr CLI and runtime to 1.12 or greater.


Add Travis CI Integration For Linting

Resolves https://github.com/viniciuskneves/vue-eleicoes-2018/issues/17

Hi @viniciuskneves is there anything you'd like me to change?

Sorry @PedroPovedaQ didn't have time to test yet but looks good as far as I checked. As soon as I can test it I let you know. Nevertheless you can add yourself to the contributors list in package.json if you want!

Looks like it worked like a charm! I will add the badge soon! Thank you very much!
I've another project in need of a CI hahaha, wanna try it out again? https://github.com/viniciuskneves/vue-github-repository-contributions/issues/10


Implement the G Force Recording System

Complete GForceMeter
Include G force data in the default data container yet
Create data persistence for G force data in leads_vec_rc
Include G force data in the remote analyst

Does the rpi4 have a built-in accelerometer?

Unfortunately no.

We need an external at least 6 DoF accelerometer.

here's where the Phyphox feature would come in handy.

Bug found: render delay significantly increases after 30 seconds.

Resources are wasted on unnecessary re-rendering.

Replacing the dynamically drawn circles with a fixed image is worth trying.

CPU usage still increases extremely as long as the G force meter is rendered.

It is confirmed that this is caused only by the G force meter.

Investigating.

Bug fixed.

https://learn.adafruit.com/adafruit-9-dof-orientation-imu-fusion-breakout-bno085/uart-rvc-for-arduino


Skip default RepositoryFilter for maven metadata when GA cache in action

If the path is non-snapshot maven metadata, we use GACacheGroupRepositoryFilter result directly. And skip the default filter. This will life some Cassandra load.

Thank you guys. I will merge it.


unmanned_aerial_vehicle.cpp:62:1: error: control reaches end of non-void function [-Werror=return-type]

While as seen by human control would not reach the end of this function, as it contains switch statement with all cases of enum, my compiler that is 12.3.1 20230730 anyway responds with the error as given in the title.
The glitch can be fixed by adding assertion statement to the end of the function (assert (false & "why"), as proposed in the path. Let's agree if we want to fix it this way, some other way or not to fix. I can then open a pull request.
path.txt

Here it is: https://github.com/mpusz/mp-units/pull/480

Merged. Thanks!


Update how-to-secure-workspace-vnet.md

Fixed a small typo that results in an error when setting image build compute with CLI.
There should be no space between the inverted commas.

@Blackmist
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


TAJO-1130 Concurrent execution of independent execution blocks

+1.
This will improve Tajo more faster!

Fixed problems in shuffle join.

I'll review today.

@navis thanks for your nice work!
In overall, it looks good.
However, since this is a new feature, we need to test the patch thoroughly.
First of all, it is required to add some tests for this issue.
I think that you can enable your concurrent execution option for query tests. It will be easier than adding new test functions.
 Can you share any performance test results?

Yes, it's enabled just for test. I'm not implying this should be enabled by default. We can fix things that could be caused by this in SNAPSHOT term and disable it for release version, of course.
For performance numbers, I should admit I've not done any serious tests with this. But when TAJO-1410 is to be included, I expect we can test this thoroughly.

Sorry. There are some misunderstandings. I mean that unit tests should be added for this issue because it is difficult to expect what kinds of errors we will meet.
However, I think it will be also difficult to write some new test functions to test only concurrent execution of multiple stages. So, I suggest adding a parameter to existing tests to test this feature. If so, we can test Tajo's query processing with and without concurrent execution.
I think you already know the parameterized test, but you can find an example at TestJoinQuery.
What do you think?

I don't want to double the test time, but you insists..

It's just my suggestion.
If you have any better ideas, please feel free to tell me.

Hi guys,
I agree with all you guys. This feature still requires unit tests, yet I also don't want to double test time. We can compromise it.
First of all, this feature will completely work after we have a better scheduler. So, we need to mark this feature as experimental for a while. As navis said, we need to keep it disabled by default, and if necessary, users can enable this feature with session variables.
With this approach, we may not need to verify all unit tests with this feature right now. We won't double the unit test time. Nevertheless, since this feature will require unit tests, it would be great if we test this this feature in only some unit tests like TestJoinQuery and TestUnionQuery, which mostly have independent execution blocks.
After we have a better scheduler, Tajo will use this feature by default. At that time, all unit tests verify this feature.

Thanks. It looks a good compromising point.
In addition, I think this feature should be disabled by default even in SNAPSHOT term because most developers don't want to be bothered by potential bugs which this feature can newly introduce.

ok. got it.

I missed one point. If you want to enable it during SNAPSHOT term, I agree with navis's suggestion.

Thanks.
I had a direct chat with @hyunsik, and finally agree on enabling this feature by default during SNAPSHOT term. We can aggressively find hidden bugs.

We need to be eager to fix the problems for SNAPSHOT term. If we face some very critical issues to interrupt other developments, we can disable it by default at that time.
Also, I think that this feature will have the following problem in the current implementation:

Resource allocation will be performed once when ExecutionBlock starts, and the allocated resources won't be changed during the execution block.
It means that some execution block can be slow if the execution starts with few resource capacity.

TAJO-1397 (https://issues.apache.org/jira/browse/TAJO-1397) will solve this problem, enabling continuous resource allocation while an execution block is running. I'll rush this issue.

Hi, all. Is it ready to be included in SNAPSHOT now? :-)

Uufortunately, not yet.
As discussed above, unit tests for this feature are required.
As @navis update his patch, I'll review as soon as possible.

Didn't we agree to put this feature during SNAPSHOT in order to find aggressively hidden bugs? I remember like that.

Sorry. You are right. It was my mistake.
If there aren't any further objections, I'll finish my review.

Guys, I think that we can disable this feature for a while in default. and we can enable this feature in TajoTestingCluster.
If this feature is stabled, we should enable this feature in default.

It looks a good idea. We can find simple bugs with unit tests.
After making this feature more stable, we can enable it by default.

Ok, whatever. What should I do?

As @jinossy said, it would be better if this feature is enabled only in unit tests by default. TajoTestingCluster::initPropertiesAndConfigs() looks good to enable it for unit tests. Additionally, you also should increase WORKER_RESOURCE_AVAILABLE_MEMORY_MB because only a single task can be executed with a query master due to the small size of the default available memory (1024 MB). Please note that a query master and a task use 512 MB by default, respectively.

done

Thanks. I'll test.

Travis CI seems to be failed due to the test hang.

Yes, seemed some part of tajo is not ready to launch two block simultaneously. I'll check that.

It seemed caused by tajo.yarn-rm.parallel-task-runner-launcher-num(I've commented this once and took half of a day to remind it, damn), which is also used for resource release. we should separate this on dedicate thread. I'll book this on lira.
Confirmed in local. Let's see what travis says.

I run a test with TPC-H Q10, and found a problem of the wrong query result.
Please see the following.
default> \set QUERY_EXECUTE_PARALLEL 1
default> select count(*) from (select c_custkey, c_name, sum(l_extendedprice * (1 - l_discount)) as revenue, c_acctbal, n_name, c_address, c_phone, c_comment from customer as c join nation as n on c.c_nationkey = n.n_nationkey join orders as o on c.c_custkey = o.o_custkey and o.o_orderdate >= '1993-10-01' and o.o_orderdate < '1994-01-01' join lineitem as l on l.l_orderkey = o.o_orderkey and l.l_returnflag = 'R' group by c_custkey, c_name, c_acctbal, c_phone, n_name, c_address, c_comment order by revenue desc) t;
Progress: 16%, response time: 2.185 sec
Progress: 16%, response time: 2.186 sec
Progress: 16%, response time: 2.588 sec
Progress: 16%, response time: 3.394 sec
Progress: 37%, response time: 4.399 sec
Progress: 100%, response time: 4.946 sec
?count
-------------------------------
37967
(1 rows, 4.946 sec, 6 B selected)
default> \set QUERY_EXECUTE_PARALLEL 3
default> select count(*) from (select c_custkey, c_name, sum(l_extendedprice * (1 - l_discount)) as revenue, c_acctbal, n_name, c_address, c_phone, c_comment from customer as c join nation as n on c.c_nationkey = n.n_nationkey join orders as o on c.c_custkey = o.o_custkey and o.o_orderdate >= '1993-10-01' and o.o_orderdate < '1994-01-01' join lineitem as l on l.l_orderkey = o.o_orderkey and l.l_returnflag = 'R' group by c_custkey, c_name, c_acctbal, c_phone, n_name, c_address, c_comment order by revenue desc) t;
Progress: 25%, response time: 1.627 sec
Progress: 25%, response time: 1.628 sec
Progress: 25%, response time: 2.034 sec
Progress: 25%, response time: 2.837 sec
Progress: 35%, response time: 3.841 sec
Progress: 100%, response time: 4.398 sec
?count
-------------------------------
1159
(1 rows, 4.398 sec, 5 B selected)

isExecutable() should be also checked for first() call. Took time to make env for TPC-H. Anyway I'm off today but dealing this in kids cafe. ^^

Thanks for your effort for fast bug fix! I know that working in the kids cafe is not easy.
Anyway, I'm happy with the valid query result.
Since this is an issue for the performance improvement, I'd like to see how fast Tajo is with this feature. So, I'll conduct a simple performance evaluation on a real cluster within the next few days.
If possible, would you mind testing, too?

@jihoonson, I'll test on a real cluster.

Performance gain seemed hard to see if it's not running on very big cluster.

I dont think so. If a query involves two or more independent ebs and there are sufficient amount of resources in the cluster, the query is expected to be faster with the concurrent execution of ebs.

+1. This patch looks good to me.
I've simply evaluated performance gain with this patch as follows.
Configurations and environment

Broadcast join is disabled.
The test is conducted on my desktop which equips 8 cores, 32 GB memory, and 2 HDDs.

Data

Input: TPC-H scale factor of 1

Query
tpch> select sleep(1) from region, nation where n_regionkey = r_regionkey;

Result

with QUERY_EXECUTE_PARALLEL 1: 30.399 sec
with QUERY_EXECUTE_PARALLEL 2: 25.571 sec
The performance is improved due to the two input relations are read concurrently.


bug:1691546 fix(catalog): do not add owner references to clusterroles or crbs

/retest

/retest

/retest

/lgtm

/lgtm

/retest

/cherry-pick release-4.1

/cherrypick release-4.1

/cherrypick release-4.1

/cherrypick release-4.1

/cherrypick release-4.1

/cherrypick release-4.1


WIP: Follow README style guide

Obeys the style guide proposed in #1139.
Closes #1139

This could probably be tackled in a separate PR, but I'd recommend imperative language for describing added features:
"Copy canonical link to file" vs "Copies canonical link to file" across all features. This follows popular commit convention by Linus Torvalds. The reasoninng is that you instruct Git to apply that change if you pick this commit. In the same way, you instruct the extension if you have that feature. It's similar to changelog formats based on commit messages following that convention. I guess I'm probably used to that, but I still like the brevity and clarity of the imperative form.

@hkdobrev sounds good.
I'd add dropping lets you/allows. Examples:
- Allows you to toggle all outdated PR comments or PR/Commit files with alt click
+ Toggle all outdated PR comments or PR/Commit files with alt click

- Makes it possible to automatically merge a PR after its build has passed
+ Automatically merge a PR after its build has passed (checkbox)

- Supports indenting with the tab key in textareas like the comment box (shift tab for original behavior)
+ Indent with the tab key in textareas like the comment box (shift tab for original behavior)

@hkdobrev @bfred-it There's a difference between Refined GitHub doing something by default (decluttering the UI) and it allowing the user to do something (copying a link).
Using the same style for both cases might make users think Refined GitHub does things by default that actually have to be explicitly triggered/enabled by them.

For reference, that’s also how Apple talks about what their software lets you do:

For reference, that’s also how Apple talks about what their software lets you do:

I like that style, but it requires adding the features' uses to the current descriptions that just say what they do:

Adds a Trending link to the global navbar. (g t hotkey)

Access the trending repositories with a link in the global navbar or the g t hotkey.

Moves destructive buttons in commenting forms away from the primary button

No longer click destructive buttons on accident as they're moved away from the primary button.

What do you think about rewording the features in this way?

Love it! The third one is a bit awkward, maybe it could be made passive:

Destructive buttons are moved away from the primary button

Random ping: @shroudedcode resolve this before we have any merge conflicts later!

@ramlmn I'll fix the merge conflict on the weekend. I'm doing an internship this week and can barely focus on doing any kind of open source work in the evening. Also, stop pinging people about their pull requests unless the pull request is really old and they have been active within the last week (a sign that they might have actually forgotten about it). Often they have reasons for "abandoning" them for a while.

The pull request is by the way ready for review again. @bfred-it @hkdobrev

Sorry! Lots of notes. I should have just made the changes where I was sure

Regarding the things I haven't changed yet: I'm trying to use the same style for all features: A sentence starting with an imaginary Refined GitHub allows you to … Having features that use a different style in between the others looks weird and is harder to read. I agree that some of the features still sound kind of awkward. If you have any suggestions on how to improve them while adhering to the style, let me know.

I don’t think we can stick to just that. It’s preferrable to keep sentences short and readable instead, given that there’s a lot of them.

People have fled

Is preferrable to

The boats have allowed people to flee

Alright let's merge this asap, at least partially, @shroudedcode doesn't have to deal with insane merge conflicts

@shroudedcode thanks for this PR!
I just had to make many of them passive because this was just too awkward:

Quickly determine what file you're looking at with the sticky file headers on pull requests.

and can just be:

File headers are always visible when scrolling.


Fixed JavaDoc of GuildMessageUpdateEvent

Pull Request Etiquette
There are several guidelines you should follow in order for your
Pull Request to be merged.

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

It is sometimes better to include more changes in a single commit.
If you find yourself having an overwhelming amount of commits, you
can rebase your branch.

Description
Kantenkugel said I'm not a JDA dev. Now I am.

If you want to work on event docs, do it on all of the event classes.
The event docs are really outdated because of the amount of events that need to be updated, only updating one isn't really helping.

Feel free to re-open a new PR if you actually want to fix event documentation.


RemoveQuotes not working

Hello, last week I upgraded cleancss version from 3.1.9 to 5.3.3
Now I'm getting different behaviour after using cleancss on the same source file. The quotes inside an "url" function aren't removed.
For example this source css:
@font-face {
    font-family: 'Catamaran';
    font-weight: 300;
    font-style: normal;
    src: local('Catamaran Light'),
    local('Catamaran-300'),
    url('/fonts/Catamaran-300/Catamaran-300.woff2') format('woff2'),
    url('/fonts/Catamaran-300/Catamaran-300.woff') format('woff');
    font-display: swap;
}

In cleancss 3.1.9 result:
@font-face{font-family:Catamaran;font-weight:300;font-style:normal;src:local('Catamaran Light'),local('Catamaran-300'),url(/fonts/Catamaran-300/Catamaran-300.woff2)format('woff2'),url(/fonts/Catamaran-300/Catamaran-300.woff)format('woff');font-display:swap}
In cleancss 5.3.3 (cleancss fonts.css -o fonts.cleaned.css or cleancss fonts.css -O1 -o fonts.cleaned.css):
@font-face{font-family:Catamaran;font-weight:300;font-style:normal;src:local('Catamaran Light'),local('Catamaran-300'),url('/fonts/Catamaran-300/Catamaran-300.woff2') format('woff2'),url('/fonts/Catamaran-300/Catamaran-300.woff') format('woff');font-display:swap}
I tried:  cleancss fonts.css -O1 removeQuotes:on -o fonts.cleaned.css, also  options like urlQuotes:false, but always I get quotes on the output. Using double quotes inside url() also keeps them in output.

Closing as 'won't fix' as clean-css-cli is going into maintenance mode. If anyone wants to bring it back up, please submit a PR.


Error when using with angular-redux/store

Hi,
Currently using your library with angular-redux/store and I'm getting the following error when implementing:

Not sure if middleware is implemented differently in angular-redux/store.  I hope you can help me out on this one.
Thanks!

Hey @jaypanares ,
It's unlikely this has to do with either. You're trying to require fs (a node module) through webpack, so will likely need a shim. A quick google search surfaced this: https://stackoverflow.com/a/39249719/495771

Unfortunately not heard back from you @jaypanares, so closing this for now. Feel free to comment and we'll get back on it.

I just published 1.5.1. This might fix the issue.

I have the same problem. It is related to require('electron') inside forwardToMain.js. This article explains the dilemma.
Is there any way to work around this?

My bad, I tried 1.5.4 and thought the 1.5.1 fix referenced above was included. Downgrading to 1.5.1 solves the problem for me.


Feature: Use lodash.get to get params by path

Motivation
Say I navigate to a screen like this;
navigate('Hello', {
  user: {
    name: 'Ali',
    // more properties here
  }
}

If I want to use the user.name param in Hello.navigationOptions, I have to write some dirty code. Maybe something like this;
Hello.navigationOptions = ({ navigation: { getParam } }) => {
  const { name } = getParam('user', {
    name: 'Fallback name'
  })

  return {
    header: <CustomHeader title={name} />
  }
}

Or even;
Hello.navigationOptions = ({ navigation: { getParam } }) => {
  const user = getParam('user')

  return {
    header: <CustomHeader title={user ? user.name : 'Fallback user'} />
  }
}

With this feature, we can just;
Hello.navigationOptions = ({ navigation: { getParam } }) => ({
  header: <CustomHeader title={getParam('user.name', 'Fallback name')} />
})

Changes

Use lodash.get to get route parameters by path
I couldn't get yarn install to work because of an outdated version of fsevents which doesn't install on Node v12.3.1 so I had to regenerate yarn.lock to add lodash.get to it. Maybe someone with an older version of Node can revert it?

You can do this in userland:
get(state.params, 'user.name', 'Default value')`

I don't want to add this because:

It doesn't work with static type checkers which i'm trying to support better in React Navigation
It's an extra 4kb+

While not ideal, that works.
Would you consider a small util method to replace lodash.get?

@alizahid main problem for me is that I don't want to add an API that won't work with static type checkers. I think it's bet left for userland.

I understand. Thank you.


EL-406 return to same section

Link to the Jira ticket
When returning to check answers screen from check answers flow, specify an anchor so that we return to the relevant section of the screen.
Checklist
Before you ask people to review this PR:
Tests and rubocop should be passing
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

RIght, I think this is better:
The only thing that knows about the yml file is one service. Then both the check answers view and a new service know that the original service outputs an array of Section objects that contain Subsections that contains Fields, and the new service does a minimal bit of work to essentially invert that tree in order to provide an answer.


Fixes Issue #350: qiskit/init.py linting

Now both linter and PEP8 style are happy. The version checks are also done before anything else is imported.
Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Looks good to me.

Thanks, @ajavadia ! Can you also rename the function that is called on the failing test at https://github.com/QISKit/qiskit-sdk-py/blob/master/test/python/test_util.py#L29? We should be good to merge after that :+1:

Sorry about that. Fixed now.

Great, thanks @ajavadia !


chore: Google clone added by ayan-joshi

Description
I added a Google Clone project , yesterday I made one contribution , so my id was already there in the project.json
just added a new project to my same github profile.
please have a look and merge my pull request @priyankarpal

@priyankarpal have a look

@priyankarpal please merge the request


KeyError: incremental_develop

Traceback (most recent call last):
File "/Users/mooncake/gpt/ChatDev/run.py", line 82, in
chat_chain = ChatChain(config_path=config_path,
File "/Users/mooncake/gpt/ChatDev/chatdev/chat_chain.py", line 71, in init
incremental_develop=check_bool(self.config["incremental_develop"]))
KeyError: 'incremental_develop'
I print self.config the key incremental_develop is not found

Thank you for your feedback! There was a small mistake in our previous version, we will fix it right away.

We have already fix it. Thank you.

I am also getting same error. How to fix it.

@Mohansolopre The error has been fixed, try to pull the newest version of ChatDev.
Hope you enjoy it!


Data-Flow Analysis of fscanf

Is joern able to analyze the data-flow of functions like fscanf? For example, if I have the code below
void foo()
{
    char data;
    data = ' ';
    fscanf (stdin, "%c", &data);

    char result = data + 1;
    printf("%c\n", result);
}

how could I get the data-flow from fscanf to result?

This can now be done like this: https://github.com/joernio/joern/pull/934/files#diff-735dff781c87fdd020336c8833cbe6b12dd35a1ddbe75e39fc6aed9f4adbfa91R1687-R1716


Handle multiple major ircd versions

Maybe suffixing each folder eg. charybdis-3.5 charybdis-4

This is now done for the servers that warrant it, namely: Chary, Insp, Hybrid, and Unreal. If there's any other servers that require the specific versions just note them and I can rename/etc them as we go. For any other requests, give us how specific you think we should be with them (e.g. InspIRCd-2.0, InspIRCd-2.1, InspIRCd-2.2, etc, or just Unreal-3, Unreal-4. given how weird some servers are with bumping major version numbers (irc2 for example), we'll need to be more and less specific).


Upgrading handlebars version

Fixes all security related issues on https://github.com/finos/finos-fo/issues

Closing PR, as handlebars was updated by a previous PR


Latest version released on Maven has security vuln

Maven repo page: here
CVE report: here
Please cut a new release as soon as possible to protect your users.

I'm having issues deploying to mvn :(

Still no 0.4.6 anywhere... Where do I get one?


JetBrains: Chat history from another account keep showing when user switch to different account.

IDE Information
PyCharm 2023.3.3 (Community Edition)
Build #PC-233.13763.11, built on January 26, 2024
Runtime version: 17.0.9+7-b1087.11 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.3
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Metal Rendering is ON
Non-Bundled Plugins:
com.sourcegraph.jetbrains (6.0.38-nightly)
Bug Description
Platform: macOS
Steps to reproduce:

Have Cody plugin installed in your JB PyCharm editor
Login to Cody with Free/Pro user
Check the Chat history
Switch to another account
Check the Chat history

Observed behavior:
Chat history from first account keep showing
Expected behavior:
Chat history for correct account should load
Additional context
Video link:
https://drive.google.com/file/d/1z1Lurp4LgGwa00ZpaWnR3m0AzDnq6G8d/view?usp=drive_link

The problem is that setActiveAccount calls ChatsController.disposeAllChats that calls ChatController.clearAndRestartSession that calls  ChatController.saveSession that uses AuthProvider.getAuthStatus. the auth status is already new in the auth provider. we should rely on currentAuthAccount instead.

I spent some time on it today but no success. If anyone want's to pick it feel free. I will get back to it on Monday.

I am back on it 👀

@mkondratek I am able to repro this issue with 7.0.3-nightly hence reopening.

https://linear.app/sourcegraph/issue/CODY-3754/chat-history-from-another-account-keep-showing-when-user-switch-to


Source for test_process_align binary

It would be very helpful if you can share the source code for the test_process_align binary. Because the binary is looking for opencv 3.4 related shared object files which is a bit old. If you can share the source I can make it work with the new version of opencv too.
Thanks in advance.

Source code of test_process_align belongs to a commercial company (i.e. SenseTime), thus it's not shareable.
I would suggest you to try other open-source face alignment code, it is not necessary to use our original code, which is written in 2017 and out-of-date.


Update base.html

Have added some color to the elements and re-vamped the text fonts as well. I have also edited the text, for it to sound to the point. Please have a look and let me know if you like it.
Thank You.

hey @khannakshat7 i'm gssoc'21 participant, can i make some contribution in this project.
Thank you!

hey @khannakshat7 i'm gssoc'21 participant, can i make some contribution in this project.
Thank you!

Yes

hey @khannakshat7 i'm gssoc'21 participant, can i make some contribution in this project.

Thank you!

Yes, you can contribute by making issues and pull requests.

Hi! Can you please take a look at my pull requests for an issue that I was assigned, thanks!

Hey @ketakitankk your PR is having Conflicts, Please resolve them to get your PR merged :)

Hi @CodesbyUnnati , please go ahead with the merge, I have resolved the conflicts.
Thanks a ton

both the colors are different

please stick to one font, as we cannot have multiple fonts in a website.

Hi, I have made the changes that didn't match the theme, please have a look and let me know. Sorry for being late, had my exams.


I think you should be able to publish a release now.

We finally got to the bottom of the problem with bigints.  Version 5.0.0 was still using the PureScript 0.13 libraries.  See https://github.com/sharkdp/purescript-bigints/issues/36.

Not sure how you want to take it forward, but I've issued a PR against the fix/travis-spago branch which uses the ps 0.14 compatible version of bigints plus a handful of smaller updates to dependencies.

Could you publish a new release after accepting my PR
https://github.com/anttih/purescript-rationals/pull/39
The bower.json of the last released version refers to packages with purescript version 0.13.

I have just now attempted to publish abc-parser using the new Registry.  It failed because it could not resolve dependencies in order to build the manifest,  This could be resolved if you could publish a version that is PS 0.15 compatible (as it currently is).

Now done - many thanks.


Service Unavaliable Unable to connect to Quay.io inside private network

I'm recieving a Caused by: com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"Get https://quay.io/v2/: Service Unavailable"} when trying to build my docker container.
@Testcontainers
public class ElasticSearchServiceTest {

  @Container
  public static ElasticsearchContainer compose =
      new ElasticsearchContainer(
          "hub.docker.prod.walmart.com/library/elasticsearch:7.0.0")
          .withExposedPorts(8080);

I'm inside my company private network, however i am able to hit https://quay.io/v2/ via chrome with no issues. I created a Docker compose file as well with the docker image name mentioned above

duplicate


NFC Tag Writing Issue

Hi guys l need your assistance please. I have NFC reading and writing on my app. The reading is fine it's the writing part that is an issue. If l start my app and proceed to go to writing to tags and the tag writing works but if  l navigate to the previous page and go back to the writing page the tag writing when you try to write to  tag it keep on giving a success message but it's not writing to the tag. I have to restart the app for the tag writing to function again.
Is there something that l am not switching of from the tag or is there something hanging  when l navigate to the page.
Any assistance or pointing me in the right direction will be much appreciated.
Writing Function  Code below
writeTag(tagData) {
this.writeDate = moment().format('DD-MM-YYYY HH:mm:ss');
this.tag = tagData?.item;
console.log(this.tag);
this.platform.ready().then(() => {
this.writingTag = true;
this.listener = this.nfc.addNdefListener((res: any) => {
console.log('Listener is Active: ' + res);
}, (error) => {
this.presentToast(error);
}).subscribe(() => {
const referenceNumber = this.ndef.textRecord(this.tag?.reference_number);
const date = this.ndef.textRecord(this.writeDate);
    this.nfc.write([referenceNumber, date]).then(success => {
      alert(JSON.stringify(success));
      if (success === 'OK') {
        this.listener.unsubscribe();
        this.presentToast('Successfully written to RFID Tag!');
      } else {
        this.presentToast('Could not write to tag sucessfully!');
      }
    }).catch(error => {
        if (error === null) {
          this.presentToast('Tag could not be written!');
        }
        if (error === 'Only one Tag Technology can be connected at a time.') {
          this.presentToast('Failed to write to tag sucessfully, please try again!');
        }
      });
  }, err => {
    this.presentToast(JSON.stringify(err));
  });
});

}
My environment information
Ionic:
Ionic CLI                     : 6.20.1 (C:\Users\Tigere Bervin\AppData\Roaming\npm\node_modules@ionic\cli)
Ionic Framework               : @ionic/angular 6.7.5
@angular-devkit/build-angular : 13.0.4
@angular-devkit/schematics    : 13.0.4
@angular/cli                  : 13.0.4
@ionic/angular-toolkit        : 5.0.3
Cordova:
Cordova CLI       : 11.0.0
Cordova Platforms : android 12.0.1
Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 14 other plugins)
Utility:
cordova-res                          : 0.15.4
native-run (update available: 1.7.3) : 1.7.2
System:
Android SDK Tools : 26.1.1 (C:\Users\Tigere Bervin\AppData\Local\Android\Sdk)
NodeJS            : v16.14.0 (C:\Program Files\nodejs\node.exe)
npm               : 8.3.1
OS                : Windows 10

Anyone out there who is facing the same issue l am facing when writing to tags?


Bounding Boxes Ordering is wrong

Hello, Thank Clovaai for your work. I really loved it. I've some problem with the Bounding Box which is getting generated after the text detection in txt file.
I've already tried to sort it through first y-axis but it didn't work for me.
I know there is already Issue created like this but no one shared the code even if they found it out. So, I think it'll be really better if you @YoungminBaek or @ClovaAIAdmin can please share some insights regarding this Issue. It'll be of great help.

its hard to fix, re-order it by algorithm

@debparth Can you share the solution?

@debparth @SaeedArisha did you guys solved this issue?
I am facing the same problem, it will really help.
Thanks!


Fix issue where framework couldn't be embedded in app product

This PR fixes an issue where the framework built from this package couldn't be embedded in the final app product. This was causing apps to crash when ran on a physical device. Fixes https://github.com/airbnb/lottie-ios/issues/1925. Fixes https://github.com/airbnb/lottie-ios/issues/1926.

Before
After

🫠

I filed an issue about this here: https://github.com/apple/swift-package-manager/issues/6069

On our CI the build still fails with 4.1.1 and the spm version.
...
❌  /Users/runner/Library/Developer/Xcode/DerivedData/Beenera-aldfnfasymjwpfdubyhxlfreeqol/SourcePackages/checkouts/lottie-spm/Sources/_LottieStub/Stub.swift:4:8: no such module 'Lottie'
...
The following build commands failed:
SwiftEmitModule normal x86_64 Emitting\ module\ for\ _LottieStub (in target '_LottieStub' from project 'Lottie')
Don't know if this is related. Any idea?

@honkmaster, can you share a sample project and build command that reproduces that error?

Currently not. However, it was working with 4.1.0 and not with 4.1.1.
And the compilation fails in [Sources/_LottieStub/Stub.swift, added in 4.1.1.

Only happening on our Azure CI, not locally. Command
/usr/bin/xcodebuild -sdk iphoneos -configuration Debug -workspace /Users/runner/work/1/s/.xcodeproj/project.xcworkspace -scheme  -destination platform=iOS Simulator,name=iPhone 13 test CODE_SIGN_STYLE=Manual CODE_SIGN_IDENTITY= PROVISIONING_PROFILE= PROVISIONING_PROFILE_SPECIFIER= | /usr/local/lib/ruby/gems/3.0.0/bin/xcpretty -r junit --no-color

I tested a similar command locally and didn't have any issues:
xcodebuild -sdk iphoneos -configuration Debug -workspace Example/Example.xcworkspace -scheme Example -destination "platform=iOS Simulator,name=iPhone 14"

It would be really helpful if you could create and share a sample project that reproduces this issue. I definitely want to investigate and fix it but I can't until we find a repro case.

@honkmaster I created a branch called [cal--test-stub-change](https://github.com/airbnb/lottie-spm/compare/cal--test-stub-change) that removes the import Lottie from the _LottieStub module. Could you check if using that branch instead of 4.1.1 resolves your issue?

I tried the solution. Seems to works locally and on our Azure CI (Build still running, but not failing on the previous site).
For reference another similar issue: https://github.com/airbnb/lottie-ios/issues/1926#issuecomment-1398866563


Add support for Node Subject Alternative Names

Allows SANs to be added to SRL nodes.

Thanks @alexandrehassan
I cleaned it up a little, and it looks good now
thank you for your contribution!


[Bug] Need error when indexing non-indexable symbol

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
fn anchoring(x, q) {
var t = tangent()
var wxx = t[0]t[0]-0.5
var wxy = t[0][1]
//return (q[0]-wxx)^2+(q[1]-wxy)^2
return 0
}
morpho5 indexing.morpho doesn't throw a complication error despite *[1]
Trying to use this fn results in a segfault
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
indexing.zip

@ConduitDan I think this is now fixed?

I didn't fix this. I fixed a similar bug that happens with var a = [1,2,3] print a[[1]]
this is about trying to index the multiplication operator, among other things
I've found that you can only get this behavior in by writing the bad code in a function.
Perhaps this bug is actually about compliance checking inside function definitions


choice max supported camera resolution if best one not found

Different phone models has different order of support camera resolution

nexus 5: http://take.ms/RVyL2
explay fresh: http://take.ms/8HiNz

so we should choice correct one

I agree, this is a better algorithm. Thanks!