Primary key, which is not sequential, doesn't work

Describe the bug
This is not so much a bug as it is a failing of the current design, but I wouldn't class it as a feature request because I believe that the current behaviour isn't the expected behaviour.
If I have a Primary Key that is a string for example and it's not autogenerated as a sequence, and I add it as a column to show up in the form, I can not create records. That happens right now because BaseRecord makes the false assumption that because an ID is present inside of the properties then the record was saved at some point and it should do an update. But this doesn't have to be the case.

This currently happens with typeorm, but I have looked at the sequelize code and haven't seen any reason to believe it doesn't happen there as well.

This could be addressed outside of the main project at the admin-bro-typeorm or admin-bro-sequlize level by extending and using a different record type. But I think it would be better if there's a BaseRecord.create method which, unlike BaseRecord.save just calls this.resource.create instead of checking the id. Then in the action we should call await record.create().
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
To Reproduce

Setup a record with a primary id that's not automatically set by the database.
Add the id to the proprieties that show up in the form
Try to create a record with a manually filled in ID.

Expected behavior
It should be possible to create a record.
Other cases
take a look at this issue: #545 - this case also should be taken into consideration

yep - this is a known issue. The way of solving that could be:

add a new method: 'isNew' in the BaseRecord or in BaseResource, which will simply return !!this[primaryKey] for backward compatibility.
and then implement this method in all the adapters.

But since this issue is easy to fix (add a primary key which is sequential) it is on the bottom of the backlog :(

Yeah I understand, there are valid use-cases where a sequential key is not possible. But I understand it being low priority because it can be solved by extending the resource.
But I'm not sure what you mean by the !!this[primaryKey] at which point would you do that because you can't really know if this is an update or create just by looking at the data. You have to either rely on the intent (i.e. explicit create method in the controller) or query the database beforehand, unless I'm missing something.

Are there any updates to this?

I got validation errors randomly when adding new record based on this typeorm definition. Not sure why. Maybe hide uuid in edit mode will fix it?
  @PrimaryGeneratedColumn()
  id: number;

  @Column()
  @Generated('uuid')
  uuid: string;

Why is this closed? I think I'm having the same problem with express/sequelize and a string primary key.


Add test config to allow globus worklow to be testable in localhost

Add some config to fake/simulate the globus client API calls for easier testing in localhost

Closed by #2903


feat: Golang slsa module 0.2 to 1.0 migration

HI all,
Trying to lend a hand by migrating the golang slsa module to SLSA 1.0.
Basically i tried to follow the https://slsa.dev/provenance/v1  section Migrating from 0.2 to 1.0.
I am a first time contributor so take your time reviewing my code and i appreciate any feedback or comments.
Fixes https://github.com/slsa-framework/slsa-github-generator/issues/1525

Thanks for this!
A couple general comments:
Some downstream consumers of the provenance might still need to consume v0.2. Could we make this an option (similar to the slsa-version input in slsa-token action)? /cc @laurentsimon
Please add "Fixes #1525" to your PR description.

@ianlewis Do you think this versioning input flag capability should be part of this PR or another?
I am probably two new to this project to answer how this should be done
But anyhow here is are my thoughts ..

Have multiple builder options for each version of slsa in the repo side by side, Action Input flag select between the two implementations.

In workflow ref selection process , For each version of SLSA autoselect the ref (Branch, Tag?) the builder uses to bulid the generator binary (i am not sure how to autoselect this)..

Document the action tag to use for each version ... not really a input flag like you wanted..

Add the https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/generic As a Embedded Sumodule versioning it aligned to the SLSA versions. Builder selects the submodule for build using the input_flag directly.

Hi @houdini91, thanks for sending this PR. Migrating to v1.0 seems like a seamless change, but it's more complicated that it seems. There are a few things that need to happen for a complete solution, which probably needs a series of PRs

I think we need a new workflow for the migration. Otherwise we won't be able to release other workflows / updates until migration is complete - because it may be considered a breaking change
We currently don't explicitly "separate" inputs based on the trigger, but the examples for v1.0 does https://github.com/slsa-framework/github-actions-buildtypes/tree/main/workflow/v1. We may want to follow this.
Remove privacy inputs https://github.com/slsa-framework/slsa-github-generator/issues/2060
We need to record the inputs to the builder itself (https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/builder_go_slsa3.yml#L38-L98), because that's the interface for v1.0. We no longer need to record the compiler commands run by the compiler, which will greatly simplify the workflow.

The good news is that we have a new framework to do all this for all builders at once https://github.com/slsa-framework/slsa-github-generator/milestone/11. This means we need to re-write the workflow. You can seen an example for nodejs https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/builder_nodejs_slsa3.yml and the underlying workflow it's calling to handle provenance generation https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/delegator_lowperms-generic_slsa3.yml. The SLSA predicates end up being generated in https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/verify-token/src/index.ts#L171-L188. Points 2, 3 and 4 above are taken care of in this code (or will) so you don't have to worry about them yourself. All you need is use this framework to implement point 1.
If you're interested, we can share a Google doc with you to help you understand how how the framework works (we also have examples for other ecosystems, e.g. JReleaser, Gradle). We're working on documentation for this framework which hopefully will be ready next month.

Ok i totally missed this https://github.com/slsa-framework/github-actions-buildtypes/tree/main/workflow/v1
I try and write down what i understood (more for me that for you guys).

We currently don't explicitly "separate" inputs based on the trigger
Not sure i understood? Filter out any event that is not in the Support event table (for v1), should this be done in the workflow or code level?

Remove privacy inputs
Understood i think, Some filter of the event and inputs needs to be done somehow.

We need to record the inputs to the builder itself
Understood i think, So we need to add the Workflow input to the v1 prov.

The good news is that we have a new framework to do all this for all builders at once
Points 2, 3 and 4 above are taken care of in this code
What do you mean in this code ? (This PR, The Code you refer to for ts builder?, BYOB?)
So you mean the BYOB will take of these points or i should update this PR to match these requirements.

If you're interested, we can share a Google doc with you to help you understand ...
Please do, i am a bit lost.

General question:
BYOB - This framework is going to allow SLSA-lv3 using there own build action by providing workflow that wraps the build action with SLSA prov generation (key and generation and so on) ?
As Part of the framework will already provide workflows that separate different versions of SLSA and builders, Did i understand correctly?

In my head LV3 was only forcing the builder to attest to the Artefacts Built apon it, not actually building the Artifact.

Ok i totally missed this https://github.com/slsa-framework/github-actions-buildtypes/tree/main/workflow/v1 I try and write down what i understood (more for me that for you guys).

We currently don't explicitly "separate" inputs based on the trigger

Not sure i understood? Filter out any event that is not in the Support event table (for v1), should this be done in the workflow or code level?

The provenance output needs to be:
externalParameters{
  inputs: {
    <name>: <value>
  }
}

and currently it's:
externalParameters{
  <name>: <value>
}

Remove privacy inputs

Understood i think, Some filter of the event and inputs needs to be done somehow.

Correct, we have a tracking issue to remove usernames https://github.com/slsa-framework/slsa-github-generator/issues/2060

We need to record the inputs to the builder itself

Understood i think, So we need to add the Workflow input to the v1 prov.

Correct. The BYOB framework makes this easy. You just do https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/workflows/builder_nodejs_slsa3.yml#L99

The good news is that we have a new framework to do all this for all builders at once
Points 2, 3 and 4 above are taken care of in this code

What do you mean in "this code" ? (This PR, The Code you refer to for ts builder?, BYOB?) So you mean the BYOB will take of these points or i should update this PR to match these requirements.

code = BYOB framework. Sorry for the confusion.

If you're interested, we can share a Google doc with you to help you understand ...

Please do, i am a bit lost.

Do you have an email address I can share the doc with?

General question: BYOB - This framework is going to allow SLSA-lv3 using there own build action by providing workflow that wraps the build action with SLSA prov generation (keys, delegation and other magic) ? did i understand the premis?

Correct

As Part of the framework will already provide workflows that separate different versions of SLSA and builders, Did i understand correctly?
not sure what you mean exactly. But I think yes it will take care of supporting multiple version and creating the right format.  In my head LV3 was only forcing the builder to attest to the Artefacts Built apon it, not actually building the Artifact.

no problem. I think we can help you design the workflow for the Go builder to use BYOB.. and get v1.0 support. If you're up for it we're happy to chat and provide guidance.

Closing this PR since these changes are more complicated.


pytest 3.6 support

I am new to pytest, so maybe I misunderstand something.
I installed your plugin and got:
...
TERNALERROR>   File ".../site-packages/pytest_django_ordering/plugin.py", line 13, in get_marker_transaction
INTERNALERROR>     return marker.transaction
INTERNALERROR> AttributeError: 'MarkInfo' object has no attribute 'transaction'

I could fix this by replacing marker.transaction with marker.kwargs['transaction']

Thanks for the heads-up @ostcar. Assuming that change also works for older versions of pytest, I'd be happy to accept a PR.


Analytics

@v-sambati : Thanks for your contribution! The author(s) have been notified to review your proposed change. @nikotha

Docs Build status updates of commit 1d99701:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/analytics/custom-reports/power-bi-integration.md
:white_check_mark:Succeeded
View

microsoft-community-training/analytics/in-built-reports/group-view-report.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


please document how to rebuild the extension and how to try from git clone

It would be nice to not guess how to rebuild the extension (after npm install).
Chrome can "install from unpacked extension", so it surely is easy.

Oh hey, good point! Yeah didnt think anyone would bother to do that. So, run pnpm i. Then pnpm --filter prosemirror-dev-toolkit dist and last pnpm --filter extension build. Should create a folder to packages/extension/dist which you can load from chrome://extensions (as unpacked extension, as you said).
I'll update the docs.


support telemetry addons

https://github.com/istio/istio/issues/16970

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test mandiff

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test mandiff

test_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart @richardwxn @morvencao Please take a look if this a correct direction for fixing this.  Thanks.  The test failures are most because the profile change.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test mandiff

test_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test test

lint_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
a1df6912a8b765270350254b3ff736b81fae3208
link
/test test

lint_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test lint

mandiff_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test mandiff

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test lint

mandiff_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test mandiff

test_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test lint

test_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test test

mandiff_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test mandiff

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
c404f8c20b18fd96a141bc59b59b912984955405
link
/test test

mandiff_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test mandiff

lint_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test mandiff

lint_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test lint

test_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test mandiff

test_operator
d1ffc4872f4c4e32a02cdec725211d1df3211b47
link
/test test

lint_operator
b1ebaafb65224d4cee00c5a64ac5174b2641e179
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart @morvencao PTAL

@irisdingbj could you please confirm the indentation is not due to manual changes (like your editor)? Otherwise lgtm.

@irisdingbj could you please confirm the indentation is not due to manual changes (like your editor)? Otherwise lgtm.

The indentation is not due to manual changes. They mainly caused by prometheus will be installed for default  profile.

/cherrypick release-1.3

@ostromart: #286 failed to apply on top of branch "release-1.3":
Using index info to reconstruct a base tree...
M	cmd/mesh/testdata/manifest-generate/output/all_off.yaml
M	cmd/mesh/testdata/manifest-generate/output/all_on.yaml
M	cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
M	cmd/mesh/testdata/manifest-generate/output/pilot_default.yaml
M	cmd/mesh/testdata/manifest-generate/output/pilot_k8s_settings.yaml
M	cmd/mesh/testdata/manifest-generate/output/telemetry_default.yaml
M	pkg/manifest/installer.go
M	pkg/name/name.go
M	pkg/translate/translate.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/translate/translate.go
Auto-merging pkg/name/name.go
Auto-merging pkg/manifest/installer.go
Auto-merging cmd/mesh/testdata/manifest-generate/output/telemetry_default.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/telemetry_default.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/pilot_k8s_settings.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/pilot_k8s_settings.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/pilot_default.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/pilot_default.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/all_on.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/all_on.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/all_off.yaml
error: Failed to merge in the changes.
Patch failed at 0001 Support ThirdParty addOns in Operator

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Ssh temporary agents don't persist (conflicts with --persistant)

Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused
"process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/tmp/ssh-8eDpQ7z91JXs/agent.2621\\\" to rootfs
\\\"/var/lib/docker/overlay2/3c0dcc15df646cb326f57c4f2643f89ddf4d9e8752e35897f2f2d0bd425ff615/merged\\\" at
\\\"/var/lib/docker/overlay2/3c0dcc15df646cb326f57c4f2643f89ddf4d9e8752e35897f2f2d0bd425ff615/merged/tmp/ssh-
8eDpQ7z91JXs/agent.2621\\\" caused \\\"not a directory\\\"\"": unknown: Are you trying to mount a directory onto a file (or vice-
versa)? Check if the specified host path exists and is the expected type

Workaround for now that re-establishes it with a new agent (ostensibly after a reboot):
$ docker container rm colcon
$ groot-rocker-workspace --colcon --bind /mnt/mervin/workspaces/foo:/mnt/foo --name colcon ubuntu:18.04

That should reuse the image and just apply the docker run args to the newly built container.


indirectly depends on deprecated packages

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.0.0-beta.59
Electron version
any
Operating system
any
Last known working Electron Forge version
No response
Expected behavior
Installation of the module should not trigger any depreciation warnings.
Actual behavior
Installation contains
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
the reason is that electron-forge depends on older electron-rebuild which in turn does not depend on even older lzma-native which depends on very old and deprecated node-pre-gyp (see https://www.npmjs.com/package/node-pre-gyp).
I understand that this not entirely fault of electron-forge, but someone should push the upgrade. Of course this can be also resolved by asking authors of the dependencies to upgrade.
Steps to reproduce
npm install electron-forge
Additional information
No response

It is generally not possible to get rid of all deprecation warnings as deeply transitive dependencies get deprecated all the time. So I don't really see a good reason to keep an issue like this open.


Add items, keys and values to BatchDict

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (8aef0ff) 100.00% compared to head (3fd7699) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines         1264      1270    +6
  Branches       145       145
=========================================
+ Hits          1264      1270    +6

Impacted Files
Coverage Δ

src/redcat/batchdict.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Standalone plugin with no jQuery?

Nice work on this! But will we be able to see this plugin as js library agnostic(no jquery needed)?

Thank you! Wouldn't be too much work, mainly use it for easy element access. Just figured most sites use it anyways? :)

Nice library! If you don't really need jQuery then using pure JS would please more people :)
For example the React community is proud not need any jQuery ;)

@petrbela Noted! Will take care of it when I get a sec! :) Be sure to nag me if you haven't seen it before next weeks end ;)

+1!

@gopatrik NAG ... get a move on! :+1:


Docs: Example of tracer.captureMethod() should demo in async instead of sync function

What were you searching in the docs?
About the tracer.captureMethod() example of correct usage, actually the method is not support non-promise function.
Is this related to an existing documentation section?
https://awslabs.github.io/aws-lambda-powertools-typescript/latest/core/tracer/#methods
How can we improve?
It should change the example with show @tracer.captureMethod() in async - promise function.

Got a suggestion in mind?
No response
Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

Thank you @kennethwkz-mm for spotting and reporting this. We do indeed need to make the change as it could be confusing for folks copy/pasting the example (as proven by our conversation on Discord).
I have added the help-wanted & good-first-issue labels. If anyone wants to pick this up, please leave a comment below to discuss and have the issue assigned to you before opening a PR. Apart from that, it should be a fairly straightforward change so I'll be happy to review & merge it once it's up.

As part of #1219 we are reworking some of the code snippets of that page, we will address this issue as part of that work.

this is addressed in PR #1229


Feature request: more flexible rule name matching in the compdb tool

Currently, to use the compdb tool you need to know the exact name of the rules which you want to query. This works OK provided these names are predictable, but this not necessarily the case for some generators.
Most notably, in version 3.2 (I think) CMake's ninja generator has started generating rules of the form <lang>_COMPILER__<directory>. This means that in order to query the compilation database, you need to first scan the project directory tree, or resort to other hacks. CMake prior to 3.2 generates rules of the form <lang>_COMPILER which made them possible to query from generic tools - without specific knowledge of the project.
Hence this feature request is for more flexible matching of rule names against command line arguments. A minimally-useful implementation would allow prefix-only matching. Alternatively regex matching would also be useful.

In the past there was a "rules" tool (7b67e48a1479c6fc7326c55756088bd57d64fc82) that could print the list of all rule. With that tool we could have done something like that:
ninja -t compdb `ninja -t rules | grep 'CXX_COMPILER_'`

I think it would be a good idea to resurrect this tool since it could also help to write shell completion script. I will try to do that in the next few days.

That would also work, thanks.

I find the compdb tool pretty hard to use -- to me, it's surprising that it needs a list of rules (it took me a while until I figured that out). Maybe if no explicit rules are explicitly passed that could just mean "all rules"? Would that be enough for cmake-based builds?
(Unrelated: I think you can pass CMAKE_EXPORT_COMPILE_COMMANDS to cmake to have it write a compilation database directly.)

Is there anyone here? 🙂

the rules tool seems removed from the build？

This would be really helpful.

I like @nico's suggestion to just print all the rules by default. In future something more sophisticated (like wildcard matching) could be added if needed.
I note @sarcasm's suggested workarounds here are rather ugly, motivating a more beautiful solution in ninja itself :)

There's now #1377 for dumping all rules by default.

Wanted to add a small note here, it seems that for some CMake projects [0], ninja -t compdb (no args) will not dump anything (the output is an empty list []).
cmake -G Ninja .
ninja -t compdb
[
]

However, using CMAKE_EXPORT_COMPILE_COMMANDS as nico suggested will:
cmake -G Ninja . -DCMAKE_EXPORT_COMPILE_COMMANDS=1
ninja -t compdb
[
]

ninja -t compdb still returns empty, but compile_commands.json is already generated.
Thanks nico!
[0] for Binaryen at least

What does ninja --version say?

1.8.2

That version is missing #1377.


images with srcset should be replaced with base64 as well or removed

Hey,
just had an example where an image is defined with srcset in addition to src. So the normal behaviour should be to replace the srcset with base64 as well. I would suggest to add an option, which removes the srcset if src attribute exists to avoid unneccessary huge inlined files.
Example: http://www.airlinereporter.com/2016/07/happy-100th-birthday-boeing-heres-special-alaska-livery/
What do you think?
Cheers, Marcel

Oh, ha, I just replied to your other issue, and yep - srcset needs supporting 👍

I appreciate this was months ago, but do you want to take a shot at a PR? The tests are very easy to setup (follow the contributing doc - just need two HTML files). Thanks so much!


StationMode Not Valid

Yep, after loading the firmware and after the reset I have an error. StationMode Not Valid change it on : /data/igate_conf.json.
I've tried them all from 1 to 5 and it's always the same thing.
Some help would come in handy

hi! sorry to not answer sooner , but I guess you uploaded all over again and it worked?


Is the QUADRO RTX 6000 supported for GPU acceleration, and is it DETECTED?

Hello,
Where can I see in the code where it detects the current GPU card used?
I am note sure if it has detected my card or not?
I gave it a 1H video and it spearated it with MDX Net in 6 minutes,
is that long or fast? I am not sure.
It can be even faster no?
Anyway I am new here! Hi

Yes it supports RTX 6000. As I am using the same GPU.
You can check it in Settings -> Additional Settings -> GPU Device
Speed is depend upon which MDX model is you have selected and also on Segment Size and Overlap


Remove unrequired endpoint security group from bastion

Following a code review it was noted that the inclusion of the VPC Endpoint security group was not needed for the bastions to access the VPC endpoints.
Remove the security group from the Terraform configuration for the RDS Admin bastions in the following two repositories

https://github.com/ministryofjustice/network-access-control-infrastructure
https://github.com/ministryofjustice/staff-device-dns-dhcp-infrastructure

PR
https://github.com/ministryofjustice/staff-device-dns-dhcp-infrastructure/pull/312


Some tiles disappear after switching to and from 2d mode

We have a 3dTiles model which gets corrupted after switching to 2d mode and then back to 3d. Some DrawCommands seem to have wrong BoundingSphere center and not being rendered.
Can you take a look at https://github.com/AnalyticalGraphicsInc/cesium/blame/b0939bf96697ec8c51cc32b8b96c5ed79b94a71a/Source/Scene/Model.js#L3798
It seems that when we switch back to 3d, model._rtcCenter not gets switched back to _rtcCenter3D

Thanks for the report @Vineg.  This is a duplicate with #5955.  I'll add your note there.  Keep an eye on it.


Development: Introduce basic interactivity to active students line charts and course exercises average bar chart

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I implemented the changes with a good performance and prevented too many database calls.

Client

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

This PR increases the interactivity for several charts:

The line chart on the course detail page
The line chart in Course administration
The bar chart displaying the average student score of each exercise in course statistics

Description

It is now possible to perform some more interaction with these chats:

Next to the title of the line charts, a Tooltip is now placed that explains the term "active students"
The title of the line charts are now clickable
The line chart on the course detail page is now displayable in full screen mode
By clicking on a bar, the user is delegated to the corresponding exercise statistics page

Besides that, some minor adjustments in the diagrams are included in this PR as well:

The lines in the line chart are now smoothed in order to present a trend-line.
The size difference within the tooltips is now a bit reduced
The line chart on the course detail page now displays one additional week in the view
The tooltips for specific points in the line chart now contain the relative value represented by the point as number
The line chart on the course detail page contains the average over the displayed time frame as reference line that is toggleable
For the bar chart on the course exercise, now a first color coding is introduced: If the average score is higher than 90% the bar is displayed in green, it it is below 25% it is displayed in red
The tooltips of the bar chart now contain the exercise type of the corresponding exercise

Steps for Testing

Prerequisites:

1 Instructor
1 Course with some exercises and participation

Log in to Artemis
Navigate to Course Administration
Inspect the line chart there. Have a look at the tooltips in the chart and the explanation tooltip next to the title. Also check the translation of the explanation tooltip.
Click on the chart title. You should be delegated to the corresponding course detail page.
Inspect the more detailed line chart there. Again, check the tooltips and the explanation translation. Make sure that the reference line disappears if the check box is unchecked.
Also inspect the appearance of the chart in full screen mode.

Important: There is a remaining problem with the fullscreen mode of the chart: The tooltips are not visible in full screen. This is due to the underlying mechanics of ngx-charts (at least as far as I can tell). I found a PR in the GitHub project of the framework that seems to tackle this issue. But as this PR is from Freburary of 2019 at it is still open, I do not have much hope that this is still maintained.

Click on the chart title again. You should be delegated to the course statistics.
Check the first bar chart there. Make sure that the color coding works as expected. Also check the tooltips if the exercise type is matching and the translations are appropriate/ aligned with translations at oder places in Artemis.
Click on a bar of your choice. You should be delegated to the corresponding exercise statistics page.

Review Progress

Code Review

[x] Review 1
[x] Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

statistics-average-score-graph.component.ts: 72.72% | 93.87%
course-detail-line-chart.component.ts: 68.42% |  92.85%
Screenshots

The line chart on course administration:

The line chart on course detail page:

The bar chart in the course statistics:

Tested on ts1 and found a small issue about the translations. In the course statistics page if you change the language, everything except the days&months in charts change.
The days and months are still in German even if i change the language to English. If i refresh the page they are also translated to English.

Yes, this is due to the realization of translations for these charts and I'm aware of this inconsistency. I have an idea on how this can be solved. In this PR, only the first bar chart is changed, the ones below are not affected by my changes, therefore I would prefer to deal with this in another PR. But thanks for reporting the observation. 👍


Default path not working with Single Types

Hello,
I tried to create navigation with items related to single types. In the settings screen, I selected a field in the single type to use as the default path. When saving navigation item path gets set to undefined.
Screenshots

Steps to reproduce

Create a new project and install the plugin.
Create a Single Type named Contact with a field slug. ( See the first screenshot)
Go to the settings screen, enable navigation for the single type, and set the slug field as default for the path. (See the second screenshot)
Add a new item to navigation, leave the URL field empty, select Contact as content-type, and save. ( See the third screenshot)

Expected Result
URL in the contact item should be /contact is undefined. ( See the fourth screenshot)
Thanks for creating this plugin and have a nice day!

Released as part of version 2.2.2.


Bump test-infra to 9703a3111217

We need to bump test-infra in ci-tools
(https://github.com/openshift/ci-tools/pull/2681) and we gate on
release-controller and ci-chat-bot bumped first.

/cc @bradmwilliams


Gilded Dreams 4-set bonus doubling/tripling up if teammates are already configured

The manual override options should probably be hidden if a full team is already present.

If a partial team is set or depending on the option already set the number of additional members allowed to be allocated should also be dynamic. Eg; in this situation only allow "1 Member" because 2 are already assigned to "same element"

Because with the current implementation you can get the bonus of the current team, plus the full bonus of 3 same and 3 different team mates:

Where was this nitpick when this PR was live for like 3 weeks? https://github.com/frzyc/genshin-optimizer/pull/1240

i had something similar to this nitpick to some degree but then next i looked it was merged :sob:
the thing for dynamic limits on the conditional is only possible after #1243 btw

Told ya it was a can of worms. It's ok this is what we do best

We went from a system that mimicked the game by forcing the user to configure 3 team mates to fulfill the requirements of team buffs. Making the implementation easy, intuitive and very difficult to mess up.
To now a system that can very easily be misunderstood and misused by the careless or uninformed.
While I have nothing against the option to set these conditionals manually they really should override rather than be additional.
I don't think it needs to be reverted because it's not fundamentally broken. It just needs to be tidied up.


Make sure button child is not null before accessing its props (Fixes #1208)

Handle case where the child Buttons could be null.
Searched through all references to children in the codebase, didn't see any other places where we are doing anything other than passing the children through to another component, or similarly null-safe operations.
Fixes #1208

Note this issue was introduced in v22

Thank you. Merging this now as looks uncontroversial to me and a clear fix
If this is something a client reported can you please add a changelog entry for the record? Otherwise happy to just include this quietly if we have only run into the bug internally.

Ran into it while upgrading a client app from v21 -> v24 - has not been an issue for any deployed applications or been seen by client users.


Show moderator fee in moderator listings

Closes #914
@morebrownies you may want to look at this, there wasn't a great place to put the moderator fee, so I stuck it under the view button.

Will do


Newlines for DESCRIPTION in ics files are unescaped

Bug report
Describe the bug
Newlines in ics files need to be escaped to be visible when viewed in MS outlook and similar ics file viewers ( https://stackoverflow.com/a/18328506 ). Right now, the HOC doesn't do anything special to escape <br>s or \ns in input fields, which works great for google calendar invites, but won't show up in ics files. I'm guessing that a simple regex as part of https://github.com/jasonleibowitz/react-add-to-calendar-hoc/blob/master/lib/utils.js#L121 would do the trick in producing an ics file with newlines that ics file clients would accept and display properly.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Make an event with newlines in the description field
Share in as OUTLOOK
Open it up it MS outlook

Expected behavior
Newlines to appear in the description
Actual behavior
No newlines appear in the description
System information

OS: windows 10 pro v1809
Version of Library: 1.0.9

Additional context
If my instinct about where the fix is needed here is correct, happy to put up a PR with a fix. Let me know. Thanks for your work!

Hey @wyantb Feel free to put up a PR. However, I'll probably have time to take a look over the holiday, i.e. before Monday.

Apologies for the delay. This has been resolved by #37 and released in version 1.0.10, which is now available on NPM.


Smoke test for Docfx v3

Docs Build status updates of commit 8943c89:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/SmokeTest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Decoder/Encoder documentation

This pertains to OpenSSL3 encoder/decoder documentation (feel free to tick checkboxes when reviewing issue(s)).

[x] Wrong API description in OSSL_ENCODER and OSSL_DECODER: "OSSL_DECODER_do_all_provided() [...] data as arguments.": data is no argument to the function, arg is.
[x] Wrong wording in OSSL_DECODER: "OSSL_DECODER_do_all_provided() traverses all encoder implementations by all activated providers" should refer to decoders.
[ ] Missing: provider-decoder (analogous to provider-encoder)
[x] Nit: Wrong HTML markup, e.g., https://www.openssl.org/docs/manmaster/man7/ "$description$lt;-$description$gt;"

Thanks.  Fixups coming up, for now the quick ones.
See #13954 for the OSSL_ENCODER / OSSL_DECODER manual issues.
See openssl/web#214 for the $description$ problem.
provider-decoder(7) will be a separate PR that will take a bit longer to finish, stay tuned.

Thanks.  Fixups coming up, for now the quick ones.
See #13954 for the OSSL_ENCODER / OSSL_DECODER manual issues.
See openssl/web#214 for the $description$ problem.
provider-decoder(7) will be a separate PR that will take a bit longer to finish, stay tuned.

There is still missing the provider-decoder, which should imo be there before beta1.


Can't build under go1.6

Even under go1.6, I can't get it to build
% go build
# github.com/zmb3/gogetdoc
./ident.go:18: impossible type assertion:
	*"go/types".PkgName does not implement "golang.org/x/tools/go/types".Object (wrong type for Parent method)
		have Parent() *"go/types".Scope
		want Parent() *"golang.org/x/tools/go/types".Scope
% go version
go version go1.6 darwin/amd64

Any ideas?

It sounds like you have an older version of golang.org/x/tools that still depends on the go/types package there.  In the last couple months the tools repo was updated to import go/types from the standard library.
Try doing a go get -u to update dependencies, or even just setting up a separate GOPATH so that we can be sure you're getting the latest version of everything.

thanks! problem solved


Change gateway and tunnel interface names to antrea-gw0 and antrea-tun0

Add "antrea-" prefix to the default names of host gateway and tunnel
interfaces.
To handle interface name changes after Antrea upgrade, or name changes
due to agent configuration changes, antrea-agent will use the discovered
interface names (from the OVS bridge) as the gateway and tunnel
interface names.

/test-all

I'm not really opposed to this approach but it seems a bit unintuitive to me. Why do we not honor the provided configuration by renaming the interfaces as needed (even if it means deleting the port and adding it again with the same of_port number)? Any drawback to this?

I just hope to avoid traffic disruption when recreating the ports. Also for tunnel port we do not really support user configured name and for gateway port even we support that I doubt anyone really changes the name, so seems the only case we are handling is for upgrade, and I hope to get a simpler implementation in 0.8.0.
But agreed we should have a better implementation to support config option changes, and probably support runtime changes for some of them.

LGTM. I also want to confirm, it looks the new default names (antrea-gw0, antrea-tun0) are working in new clusters. As for the existing clusters and upgrade cases from existing clusters, the gateway and tunnel are still using the original names, right?

Yes, with this PR, after upgrade, the existing clusters will keep using the old names (gw0 and tun0).

/test-all

/test-networkpolicy

/test-networkpolicy

/test-networkpolicy

So it seems that the netpol tests are failing consistently for this PR. Not sure why, maybe it is connected to changing the default tunnel type from VXLAN to Geneve (it seems that this PR is the one changing the tunnel type, not #858?).
@jianjuns @abhiraut Not sure how it is possible but it seems that there is more lag when adding / removing NetworkPolicies (lag == time it takes for the Agent / OVS to enforce the changes). I don't see how it can be connected with these changes... But it's probably worth trying to increase the timeout in hack/netpol/pkg/main/main.go.

Right, @abhiraut and I are discussing this, and @abhiraut is looking at netpol failures in multiple PRs.

Has it been failing for other PRs? I didn't see anything interesting in the Actions history for other recent PRs and the master branch, but I maybe I missed something.

BTW, if this is the PR changing the default tunnel type, it's probably worth mentioning it in the commit message / description.

Has it been failing for other PRs? I didn't see anything interesting in the Actions history for other recent PRs and the master branch, but I maybe I missed something.

This is one run that Yang mentioned to me, https://github.com/vmware-tanzu/antrea/runs/824306495?check_suite_focus=true
Deny-all TestCase is failing in both PRs, but it is not exactly the same.

Has it been failing for other PRs? I didn't see anything interesting in the Actions history for other recent PRs and the master branch, but I maybe I missed something.

This is one run that Yang mentioned to me, https://github.com/vmware-tanzu/antrea/runs/824306495?check_suite_focus=true
Deny-all TestCase is failing in both PRs, but it is not exactly the same.

All the Kind tests seem to be failing for this one, so it looks unrelated to me?

Let me do some tests of increasing the timeout, reverting back the tunnel type with this PR.

BTW, if this is the PR changing the default tunnel type, it's probably worth mentioning it in the commit message / description.

should we keep this PR only for name change? and update the tunnel type in a different PR?

should we keep this PR only for name change? and update the tunnel type in a different PR so we can figure the netpol failures with it?

Yes, seems the failure is indeed caused by the tunnel type change. Let us remove that change from this PR, and continue to test it separately.

/test-all

/test-all

So what's the decision for the default tunnel type for 0.8.0?

@jianjuns ,
Ran just found one weird issue if users didnt set tunnel type, the antrea agent will use Vxlan as tunnul type. Do you think it related to line 139 https://github.com/vmware-tanzu/antrea/pull/854/files#diff-aeb26b09aa46f9d28a9916c464a09f5b.

@jianjuns ,
Ran just found one weird issue if users didnt set tunnel type, the antrea agent will use Vxlan instead of geneve as tunnul type. Do you think it related to line 139 https://github.com/vmware-tanzu/antrea/pull/854/files#diff-aeb26b09aa46f9d28a9916c464a09f5b. Here "Vxlan" was hardcoded.

Yes, it is indeed not changed. @weiqaingt also reported that to me. However, we got netpolv2 test failures after changing to Geneve. So, @abhiraut and I are still looking at that

@jianjuns ,
Ran just found one weird issue if users didnt set tunnel type, the antrea agent will use Vxlan instead of geneve as tunnul type. Do you think it related to line 139 https://github.com/vmware-tanzu/antrea/pull/854/files#diff-aeb26b09aa46f9d28a9916c464a09f5b. Here "Vxlan" was hardcoded.

Yes, it is indeed not changed. @weiqaingt also reported that to me. However, we got netpolv2 test failures after changing to Geneve. So, @abhiraut and I are still looking at that

@jianjuns ,
Ran just found one weird issue if users didnt set tunnel type, the antrea agent will use Vxlan instead of geneve as tunnul type. Do you think it related to line 139 https://github.com/vmware-tanzu/antrea/pull/854/files#diff-aeb26b09aa46f9d28a9916c464a09f5b. Here "Vxlan" was hardcoded.

Yes, it is indeed not changed. @weiqaingt also reported that to me. However, we got netpolv2 test failures after changing to Geneve. So, @abhiraut and I are still looking at that

/test-all

/test-all

/test-e2e

/test-windows-conformance

/test-e2e

Have we root cause the failure of netpol test?

Just noticed the default tunnel type change is moved out, LGTM, but PR needs rebase

@tnqn we believe the failure may be connected to the Geneve implementation of the OVS netdev datapath. @abhiraut is opening an issue to track this and we will revisit after the release. In the mean time, we are "forcing" the tunnel type to VXLAN for that specific test job.

@tnqn we believe the failure may be connected to the Geneve implementation of the OVS netdev datapath. @abhiraut is opening an issue to track this and we will revisit after the release. In the mean time, we are "forcing" the tunnel type to VXLAN for that specific test job.

Got it, thanks for the explanation.

/test-e2e

/test-all

/test-e2e

/test-e2e

/test-e2e

/test-e2e

/test-all

/test-all


RFC: Restructure benchmarks to use Weave instead of notebooks

Is the idea here that Weave will play nicer with git? I like being able to view the notebooks online, with Weave will we be able to store snapshots of completed benchmark studies that can be viewed online?
(I do agree that notebooks don't work super well with git, so maybe Weave + some other method to store completed benchmark results would be good.)

This generates a script, html, and a pdf. The script is a .jl file with all of the commands and the text included as comments. The html is a good web display of the results:
http://htmlpreview.github.io/?https://github.com/JuliaDiffEq/DiffEqBenchmarks.jl/blob/3d633c069db8338467172acfe191093ed9621d0b/html/NonStiffODE/linear_wpd.html
and the pdf is a shareable version of the results:
https://github.com/JuliaDiffEq/DiffEqBenchmarks.jl/blob/3d633c069db8338467172acfe191093ed9621d0b/pdf/NonStiffODE/linear_wpd.pdf
So these are all still viewable online. The .jmd plays much nicer with Git though, it plays well with Juno (and probably more support coming elsewhere. In Juno it just acts as a runnable .jl file where you can execute lines and blocks). And this also makes it easier to do programmable parts like the footer which will include information about the computer, how to run the script, and the current package state.

This is what the completed example looks like with the footer: https://htmlpreview.github.io/?https://github.com/JuliaDiffEq/DiffEqBenchmarks.jl/blob/9f2c1a96db339251e00eaf825ae60c9195070a66/html/NonStiffODE/linear_wpd.html

Switching to Weave.jl has no objections from me. Just one very minor detail, I suggest using plot(..., dpi=200) to achieve higher quality plots.

But in the generated HTML file, it still uses the PNG format.

Ahh I didn't catch that. Yes, we should change that.

Conversion was done via:
for folder in readdir(joinpath(repo_directory,"benchmarks"))
  folder == "test.jmd" && continue
  for file in readdir(joinpath(repo_directory,"benchmarks",folder))
    file[end-4:end] != "ipynb" && continue
    println("Converting $(joinpath(folder,file)))")
    convert_doc(joinpath(repo_directory,"benchmarks",folder,file),
                joinpath(repo_directory,"benchmarks",folder,file[1:end-5]*"jmd"))
  end
end

SDEs should be able to run too. Doing some quick checks.

For non-stiff SDE, it's just the weak wpd

[ ] AdaptiveEfficiencyTests needs to be re-ran
[ ] ~2x speed-downs are seen in Oval2LongRun and Oval2LongTimes. @YingboMa we need to @.. StochasticDiffEq.jl since it's using broadcast everywhere. Note that the implicit methods are more stable.
[ ] Oval2Timings needs to be re-ran
[ ] qmaxDetermination needs to be re-ran

Henon-Heiles was fine

[ ] Quadrupole_boson_Hamiltonian_energy_conservation_benchmark needs to be re-ran

[ ] single_pendulums needs to precompile

[ ] nonstiff DDEs improved. Need to be re-ran for precompile.

[ ] Pleiades_wpd needs to be re-ran with the error message removed.

[ ] ThreeBody_wpd needs to be re-ran with the error message removed.

[ ] Weak SDE needs to be re-ran

[ ] BasicSDEWorkPrecision shows a regression, possibly needs @.. everywhere.

[ ] LotkaVolterraSDE RKMil is wonky. Shows a regression.

[ ] DiffEqBayesLorenz and DiffEqBayesLotkaVolterra need to be re-ran

QuroumSensing improved. MethodOfSteps(Rodas5) is now more sensitive to tolerances, diverging at 1e-3 on QuorumSensing. Tolerances were changed to reflect this.

[ ] Filament needs to be fixed

The stiff ODE solver benchmarks are fine timing-wise. In fact, everything improved, even the Sundials and LSODA wrappers (could be due to the new benchmarking computer to some extent). However, we need to check the effect of BLAS threading and W-matrices.

[ ] There are massive performance regressions in StochasticHeat.

QuadraticStiffness is looking great!


Question: how to get $this->remote->run() result

Sorry that asking so simple question, but i didn't found an answer.
I am running remote command like this
$result = $this->remote->run(             "if [ -f {$remote_backup_directory}/{$backup_name} ]             then echo 'true'             else echo 'false'             fi");
How can i get it's result? $result - doesn't contain anything.
Can u pass me straight to documentation unit (if there an answer)?

Well run actually should return the output of the command, here is the relevant part of the documentation.
Are you sure the command is built correctly (ie. that your variables are correct and form the correct bash command)? If you run that string by doing ssh user@server 'if [ -f .... ] then bla bla' do you get either true or false?


CustomerError: Missing frontend definition in buildspec

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.1.0
Amplify CLI Version
7.6.3
What operating system are you using?
MAC
Amplify Categories
function, api, hosting
Amplify Commands
push
Describe the bug
I have application with function rest api. I don't have frontend just backend nothing more. When I push changes to branch, builder run and shows error: !!! CustomerError: Missing frontend definition in buildspec
If I add frontend with empty formula: it will remove files which run api. Command amplify push work perfect, why builder can't do this same?
version: 1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  artifacts:
    baseDirectory: ./
    files:
      - 'README.md'

Expected behavior
I Expected that builder will push files from branch as like I do it locally with amplify push
Reproduction steps

git push
WAIT FOR STATUS/MONITOR PIPELINE
Error or files are remove/access denied.

GraphQL schema(s)

# Put schemas below this line

Log output
No response
Additional information
No response

Hi @GGG1998 thank you for raising this issue. Can you try this workaround:

Closing due to no response. If you're still having this problem please submit a new issue.

had the same issue and @hloriana your solution worked for me. Thank you


example of side setting using PIO

Hi, thanks for the great project. I would like to suggest this example, a slight modification of rp2040-hal/examples/pio_proc_blink.rs which implements side setting on the PIO. I would have found this example useful because I didn't realize that there was a different way to enable the pins for this case https://github.com/rp-rs/pio-rs/issues/18.

This looks great. Thank you for the PR!
It looks like rustfmt failed - would you mind checking that and doing a cargo fmt if required?

Thanks. I now ran cargo fmt and pushed a new commit.

Thank you!


Out of date runtime file

https://github.com/yangclaraliu/COVID19_NPIs_vs_Rt/blob/f71a74575722678dcf4171a2b0daff31c17963a3/NPIvsRt_main.r#L1
Looks like this is the main runtime file but won't work with the current layout?

removed this but doesn't look like this is relevant anymore.
will provide a more detailed README that essentially cover the same thing as this original one wasn't that informative.


Inconsistent naming convention between LSTM and GRU

Chainer has both stateful and stateless RNN units (e.g. LSTM) as links. But there naming convention is not consistent among different kinds of RNN. We should

L.StelessLSTM and L.LSTM (stateful)
L.StatefulPeepholeLSTM
L.StatefulZoneoutLSTM
L.GRU(stateless) and L.StatefulGRU

I am considering to remove or change the implementation of at least one of L.LSTM and L.GRU because it should be confusing for users that default implementations of how states are handled (stateless/stateful) are different. So, this issue should be solved in v2.

Close it because it is duplicated to #2285

Sorry, what this issue wants to solve is different form #2285.

Take the LSTM case for example. My idea is to make both StatefulLSTM and StatelessLSTM and also prepare an LSTM as an alias for the stateful one. I (and also some development team members) think that the abbreviation should point a more commonly-used object, which is, I think, the stateful version.
So, what we do is

Add L.PeepholeLSTM, which is alias of L.StatefulPeepholeLSTM
Add L.ZoneoutLSTM, which is an alias of L.StatefulZoneoutLSTM
Add L.StatelessGRU whose implementation is almost identical to that of current L.GRU.
Change L.GRU from stateless to stateful (todo that, we must declare changes).


upload from android or iphone

Checklist

[X] I'm reporting a site feature request
[X] I've verified that I'm running ts-up version 2023.08.24 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Example URLs
No response
Description
if we can use real phone or stimulator to do this

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

emulator
https://boluokk.github.io/e7Helper/#/zh/guide.html#模拟器下载地址

https://github.com/rev1si0n/lamda/wiki/安装‐前期准备

https://github.com/rev1si0n/lamda
https://github.com/wanghaisheng/e7Helper
https://github.com/wanghaisheng/mobile-automation-template


[PROPOSAL] ColumnLineageDatasetFacet - Allow transformation type to vary between input fields for a specific output field

Purpose:
The transformationType and the transformationDescription in ColumnLineageDatasetFacet are applicable to all input fields for a given output field. I think it is possible to construct examples where different input fields for a given output field can have a different transformation type. For example:
create or replace table output as
select concat(obscured_user_id, ‘ ’, TO_BASE64(SHA256(email))) user from users;

In this case, there is an identity copy of obscured_user_id and a non-identity copy/transform of email. This cannot be modeled with the current spec.
Proposed implementation
Move transformationType and transformationDescription from the output field level to the input field level.
Change this part of ColumnLineageDatasetFacet.json:
"additionalProperties": {
  "type": "object",
  "properties": {
    "inputFields": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "namespace": {
            "type": "string",
            "description": "The input dataset namespace"
          },
          "name": {
            "type": "string",
            "description": "The input dataset name"
          },
          "field": {
            "type": "string",
            "description": "The input field"
          }
        },
        "additionalProperties": true,
        "required": ["namespace", "name", "field"]
      }
    },
    "transformationDescription": {
      "type": "string",
      "description": "a string representation of the transformation applied"
    },
    "transformationType": {
      "type": "string",
      "description": "IDENTITY|MASKED reflects a clearly defined behavior. IDENTITY: exact same as input; MASKED: no original data available (like a hash of PII for example)"
    }
  },
  "additionalProperties": true,
  "required": ["inputFields"]
}

To:
"additionalProperties": {
  "type": "object",
  "properties": {
    "inputFields": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "namespace": {
            "type": "string",
            "description": "The input dataset namespace"
          },
          "name": {
            "type": "string",
            "description": "The input dataset name"
          },
          "field": {
            "type": "string",
            "description": "The input field"
          },
          "transformationDescription": {
            "type": "string",
            "description": "a string representation of the transformation applied"
          },
          "transformationType": {
            "type": "string",
            "description": "IDENTITY|MASKED reflects a clearly defined behavior. IDENTITY: exact same as input; MASKED: no original data available (like a hash of PII for example)"
          }
        },
        "additionalProperties": true,
        "required": ["namespace", "name", "field"]
      }
    }
  },
  "additionalProperties": true,
  "required": ["inputFields"]
}

https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/ColumnLineageDatasetFacet.json#L23

@jenspfaug Thank you for providing clear example and the motivation behind that change. Existing transformation types' fields are non-mandatory, so we can remove them safely.
For other readers: please be aware of #2186. My understanding is that this proposal corrects the location of transformation types, while the other extends its capabilities. Please keep in mind that change should be implemented in one go to avoid non-compatible changes.


Generate the documentation via templates

Rather than generating the documentation via Antora extension at website build time, this generates the documentation using golang templates at build time.
Reference: EC-513

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (846cec1) to head (1f588e5).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #965   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          103       103
  Lines         4859      4859
=========================================
  Hits          4859      4859

Files
Coverage Δ

policy/pipeline/task_bundle.rego
100.00% <ø> (ø)

policy/release/attestation_type.rego
100.00% <ø> (ø)

policy/release/hermetic_build_task.rego
100.00% <ø> (ø)

policy/release/labels.rego
100.00% <ø> (ø)

policy/release/olm.rego
100.00% <ø> (ø)

policy/release/sbom_cyclonedx.rego
100.00% <ø> (ø)

policy/release/sbom_spdx.rego
100.00% <ø> (ø)

policy/release/source_image.rego
100.00% <ø> (ø)

policy/release/tasks.rego
100.00% <ø> (ø)

policy/release/test.rego
100.00% <ø> (ø)

... and 1 more

Preview is here: https://ecd3e852.test-alm.pages.dev/docs/ec-policies/release_policy
I'll probably merge this today.


bump up diarkis to v1.1.0-alpha5

@hobein
Could you please check if there are no problems with the code reference in this PR?

@KohjiNakahata There is no problem with the alpha5.


update vpn gateway doc to better highlight configuration options to b…

…e used
the original doc state the configuration parameters for both the VPG and the VNET in a single flat bullet list, making difficult to understand what property was intended for which resource. nesting helps understand better IMHO

@grava : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi! Thanks for your suggestion. I've gone ahead and formatted this in a different PR, as this one has a merge conflict with the existing version of the doc at this point. The change should publish this week. Thanks again!  #please-close


Remove unused Procfile

If I'm understanding it correctly, the procfile is used by Heroku, but we are hosting this project on GCP, so it should be safe to remove this file.
If the file is useful, please let me know and I'll add a note somewhere.

It's used to export to Debian's upstart: http://blog.daviddollar.org/2011/05/06/introducing-foreman.html
If we migrate of Debian.. we can let go :)

Ah thank you for the context


Rewrite in Teal

Relates to #106, first step in getting better docs put together
Defines proper types for each table type using Teal
Test the Following

[ ] Triggering keymaps from legendary.nvim in all modes (normal, insert, visual)
[ ] Creating keymaps via legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)
[ ] Triggering commands from legendary.nvim in all modes (normal, insert, visual)
[ ] Creating commands via legendary.nvim, then running the command manually from the command line
[ ] augroup/autocmds created through legendary.nvim work correctly

@olimorris @tsyroid @hsheikhali1 This is gonna need some really thorough testing. If you're willing, install from this branch, and let me know if you run into any issues.

I think builtins are getting registered twice or something?

never mind. Fixed in latest commit.

Would love to. Will give this a run tomorrow!

So far so good here; been kicking the tires for a few hours and nothing’s
fallen off.
I haven’t really applied my ‘destructive nature’ to it yet, but I plan to
do so after dinner.
The only complaint I have, so far, is it’s annoyingly fast ;-)
/tom
On Apr 9, 2022 at 15:46:47, Oli M @.***> wrote:

Would love to. Will give this a run tomorrow!
—
Reply to this email directly, view it on GitHub
https://github.com/mrjones2014/legendary.nvim/pull/113#issuecomment-1094136635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGTYGVLZ3COTERFS6S7UW3VEICFPANCNFSM5S7YQGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Working like a charm for myself too. Also agree...feels sooooo fast. Is this in my mind?

Hmm, I don't think these changes would really affect performance. Although it is possible that there were some bugs that are now fixed due to me fixing typing errors, now that I have static typing with Teal, so maybe that affected it.

That and the fact it’s now compiled, no?
On Sun, Apr 10, 2022 at 12:23 Mat Jones @.***> wrote:

Hmm, I don't think these changes would really affect performance. Although
it is possible that there were some bugs that are now fixed due to me
fixing typing errors, now that I have static typing with Teal, so maybe
that affected it.
—
Reply to this email directly, view it on GitHub
https://github.com/mrjones2014/legendary.nvim/pull/113#issuecomment-1094352882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGTYGSTBEK4O3VIOIF6II3VEMTEBANCNFSM5S7YQGZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

It’s compiled to Lua though

Going to go ahead and merge this.


feat: openapi export

Fixes: https://github.com/stoplightio/elements/issues/707
Requires https://github.com/stoplightio/platform-internal/pull/7315 to make export button visible in StoplightProject (it's on v2 but not yet in prod)
Adds export/download feature to API and StopolightProject components.

I'd make the button more neutral, maybe outlined, as in platform. But @mnaumanali94 will decide

minimal appearance doesn't look good but default does. Switched to:

Is there any documentation on what exporting "Bundled References" means (as opposed to a exporting "Original")?

@cancan101 While there is no documentation on this original export doesn't resolve references while bundled resolves references and places them in the components section so that there is no duplication. Generally bundled export would be your best bet.

@pamgoodrich probably a good topic to document at some point


WIP: Set implementation

This is a WIP implementation of set semantics. It would require adding the method getRW to thriftrw in order to be able to lookup the correct RW for atomic types.
The other alternative is to implement some kind of equals comparison function on every type directly. I thought this was simpler, though may not be as clean. What do you guys think is the best way to do this? @kriskowal @Raynos @leizha

We’ve eliminated lodash from this project. We need Thriftify to be faster than JSON (It isn’t yet), so we’ll need to inline map, filter, and uniq, eliminating their closures and short circuiting when appropriate.

None of this uses lodash but point taken. I can rewrite in a more performant fashion. The question I want to answer before I do that is, do you think doing a straight buffer comparison is the best way to go? If so, what are the performance characteristics of converting types to buffers?

I’m not sure whether buffer comparison would be correct, much less fast. Let’s restrict our appetite to things that can be reduced to strings and numbers (including enumerations), so they can be used as keys in an object-as-map.

agreed. the key type of set should be either number or string.
I don't think python supports something like set<list> either.

Looks like almost all of the usages of sets in our codebase are for struct types. Enforcing strings and numbers is going to be overly restrictive.
@kriskowal How would the buffer comparison ever be incorrect?

@Willyham order, optional fields from the future.

Good point! I'll close this and just open an issue to discuss the types issue.


Update version: OpenWhisperSystems.Signal.Beta version 6.39.0-beta.2

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

https://github.com/microsoft/winget-pkgs/pull/126935#issuecomment-1816892023 Reset PR

Automatic Validation ended with:
#126935 (comment) Reset PR

@vedantmgoyal2009,
Please update OpenWhisperSystems.Signal and OpenWhisperSystems.Signal.Beta to not revert the architecture.


Include generated query in the API

Besides the generated query, we can also include the recommended indexes.

I think the way to do this would be:

Create unit tests for the PostgREST.Request.DbRequestBuilder module in core.
Copy/Paste the result of the tests on the docs - which are the generated queries
If the queries do change in core, the resulting unit tests would fail - so that would let us know when to update the docs as well.

What I like about this:

Increasing overall code quality - more unit tests
If maintenance turns out to be high, it would force us to merge docs with core


Need API to Close Modals

See comment at:
http://www.dwmkerr.com/the-only-angularjs-modal-service-youll-ever-need/#comment-1810738299
It would be useful to have an API such as:
modalService.closeModals();

which simply closes any open modals. A potential use case is in the application router, where changing a URL should not leave the modal open. Even better would be:
modalService.closeModals(someValue);

Which would close all the modals and resolve their close promises with the value someValue. This would allow application developers to decide whether they want to allow consumers of modals to be able to handle the cases where they are closed externally explicitly.

+1

+1

+1

+1

+1

+1

+1

+1

I needed to close an opened modal every time an ui router stateChange event fires. I ended up writing a decorator to keep track of opened modals promises:

  var decorator = function($delegate, $rootScope) {
    var ModalList = [];

    var originalShow = $delegate.showModal;
    $delegate.showModal = function(args) {

      // showModal retorna una promesa,
      // guardaré la lista de promesas para poderlas cerrar
      var promise = originalShow.apply(null, [args]);

      ModalList.push(promise);

      return promise;
    };

    $rootScope.$on('$stateChangeSuccess', function(event) {
      ModalList.forEach(function(modalPromise) {
        modalPromise.then(function(modal) {
          console.log('closing modal due to state change...');
          modal.element.modal('hide');

           // Remover de la lista
          var idx = ModalList.indexOf(modalPromise);
          ModalList.splice(idx, 1);
        })
      });
    });

    return $delegate
  }

  return decorator;

and added like this in my module config phase:

$provide.decorator('ModalService', decorator);

+1

+1

+1

News?

Hi everyone, I'm starting on this now!

The easiest way (as of [0.12]9https://github.com/dwmkerr/angular-modal-service/releases/tag/v0.12.0) is to do this with a preClose hook:
ModalService.showModal({
  templateUrl: "some/bootstrap-template.html",
  controller: "SomeController",
  preClose: (modal) => { modal.element.modal('hide'); }
}).then(function(modal) {
  // etc
});

Apologies for the delays everyone, it's hard to find time to work on my open source projects when I'm super busy at work!


Windows Support

There is a line in the current source that appends '/' to a path, which causes a later comparison to fail on Windows.  I changed the '/' to path.join('_','_')[1] in order to get the correct directory separator for the platform, though there may be a nicer way to do this.

Closing.  path.sep (e.g. #50) is obviously a better choice, now that it exists.


SharpCompress generates Zips that don't pass System.IO.Packaging validation

I'm working on switching Squirrel.Windows to SharpCompress in https://github.com/Squirrel/Squirrel.Windows/pull/803, and one thing I'm seeing is that files compressed with SharpCompress and then later opened via NuGet's code (which uses WPF's System.IO.Packaging code) blow up here:
    WindowsBase.dll!MS.Internal.IO.Zip.ZipIOLocalFileBlock.Validate(string fileName, MS.Internal.IO.Zip.ZipIOCentralDirectoryBlock centralDir, MS.Internal.IO.Zip.ZipIOCentralDirectoryFileHeader centralDirFileHeader) Unknown
    WindowsBase.dll!MS.Internal.IO.Zip.ZipIOLocalFileBlock.ParseRecord(System.IO.BinaryReader reader, string fileName, long position, MS.Internal.IO.Zip.ZipIOCentralDirectoryBlock centralDir, MS.Internal.IO.Zip.ZipIOCentralDirectoryFileHeader centralDirFileHeader)    Unknown
    WindowsBase.dll!MS.Internal.IO.Zip.ZipIOLocalFileBlock.SeekableLoad(MS.Internal.IO.Zip.ZipIOBlockManager blockManager, string fileName) Unknown
    WindowsBase.dll!MS.Internal.IO.Zip.ZipIOBlockManager.LoadLocalFileBlock(string zipFileName) Unknown
    WindowsBase.dll!MS.Internal.IO.Zip.ZipArchive.GetFile(string zipFileName)   Unknown
    WindowsBase.dll!MS.Internal.IO.Zip.ZipArchive.GetFiles()    Unknown
    WindowsBase.dll!System.IO.Packaging.ZipPackage.ContentTypeHelper.ContentTypeHelper(MS.Internal.IO.Zip.ZipArchive zipArchive, System.IO.Packaging.ZipPackage.IgnoredItemHelper ignoredItemHelper)    Unknown
    WindowsBase.dll!System.IO.Packaging.ZipPackage.ZipPackage(System.IO.Stream s, System.IO.FileMode mode, System.IO.FileAccess access, bool streaming) Unknown
    WindowsBase.dll!System.IO.Packaging.Package.Open(System.IO.Stream stream, System.IO.FileMode packageMode, System.IO.FileAccess packageAccess, bool streaming)   Unknown
    WindowsBase.dll!System.IO.Packaging.Package.Open(System.IO.Stream stream)   Unknown
>   NuGet.Squirrel.dll!NuGet.ZipPackage.EnsureManifest() Line 142   C#
    NuGet.Squirrel.dll!NuGet.ZipPackage.ZipPackage(string filePath, bool enableCaching) Line 53 C#

http://referencesource.microsoft.com/#WindowsBase/Base/MS/Internal/IO/Zip/ZipIOLocalFileBlock.cs,788
        private void Validate(string fileName,
            ZipIOCentralDirectoryBlock centralDir,
            ZipIOCentralDirectoryFileHeader centralDirFileHeader)
        {
            // check that name matches parameter in a case sensitive culture neutral way
            if (0 != String.CompareOrdinal(_localFileHeader.FileName, fileName))
            {
                throw new FileFormatException(SR.Get(SRID.CorruptedData));
            }

            // compare compressed and uncompressed sizes, crc from central directory
            if ((VersionNeededToExtract != centralDirFileHeader.VersionNeededToExtract) ||
                (GeneralPurposeBitFlag != centralDirFileHeader.GeneralPurposeBitFlag) ||
                (CompressedSize != centralDirFileHeader.CompressedSize) ||
                (UncompressedSize != centralDirFileHeader.UncompressedSize) ||
                (CompressionMethod != centralDirFileHeader.CompressionMethod) ||
                (Crc32 != centralDirFileHeader.Crc32))
            {
                throw new FileFormatException(SR.Get(SRID.CorruptedData));
            }

            // check for read into central directory (which would indicate file corruption)
            if (Offset + Size > centralDir.Offset)
                throw new FileFormatException(SR.Get(SRID.CorruptedData));

            // No CRC check here
            // delay validating the actual CRC until it is possible to do so without additional read operations
            // This is only for non-streaming mode (at this point we only support creation not consumption)
            // This is to avoid the forced reading of entire stream just for CRC check
            // CRC check is delegated  to ProgressiveCrcCalculatingStream and CRC is only validated
            //  once calculated CRC is available. This implies that CRC check operation is not
            //  guaranteed to be performed
        }

If you want a live repro, clone that PR and run the CreateFullPackagesFromDeltaSmokeTest test, or if you want a sample file to check out, https://cl.ly/0W3D3V1x0V2J

Did you create the zip file with ZipWriter?  It might not like the streaming mode entries as there's a trailing header behind the file bytes to record the actual size and whatnot.
Knowing which way you created the file will help the most.  It could be a bug in SharpCompress or it could be that the packaging API doesn't like streaming created zip files that are to spec :)  Does something like WinZip or WinRar open the file?
I'm about to go on vacation for a week so I'm not sure when I'll get to take a look.

Usually something like https://github.com/Squirrel/Squirrel.Windows/pull/803/files#diff-dc4101658eac6c569618cb80ac0bffccR99

Cool.  I'll try to setup a test Tuesday when I'm back in front of a machine.

Coming up with nothing.  Then again, I don't think I know how to properly use the Packaging API.

@adamhathcock You and me both fam. An easier test if you're playing around with it is to use the NuGet library, the ZipPackage class there is super straightforward

@paulcbetts I must be thick because I just downloaded the Squirrel.Core.<IP_ADDRESS>.nupkg and can enumerate the parts
 using (Stream stream = File.Open("Squirrel.Core.<IP_ADDRESS>.nupkg", FileMode.Open, FileAccess.ReadWrite))
            {
                var package = ZipPackage.Open(stream);
                foreach (var part in package.GetParts())
                {
                    Console.WriteLine(part.Uri);
                }
            }

@adamhathcock Lemme try it again with the latest SharpCompress

So I've found what is causing this - it's the check to make sure the version requirement from the Central Directory File Header matches the version requirement of the ZIP Local File Header contained within it.
Unfortunately for SharpCompress generated files there is a mismatch.
ZIP central directory file header is set to 10 at https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs#L33
ZIP local file header is set to 20 at https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Writers/Zip/ZipWriter.cs#L162
I suspect we can probably just change the 20 to a 10 in the ZipWriter? I can send a PR with the fix and a test if this is the case. Alternatively I guess we could change the central one to 20 but that might reduce compatibility.  I guess a lot of tools outside of Microsoft's Packaging are only using one of the two.

That's definitely a problem.
Quickly reviewing APPNOTE.txt again I should be dynamically changing the version needed to extract based on features.
Changing to 10 is probably the benign thing to do for now.  I'll investigate more by looking at other implementations next week.

Maybe it's just the fact that it's mismatched is the problem.  Otherwise I would have said 20 is the proper thing for now.

It looks like Deflate is only supported in version '20' so I thikn you're right - changing the ZIP central dictory file header to '20' would be the smallest fix.
If there was a need to support '10' then it would need to also not use deflate or encryption.


Additional details and impacted files
@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   81.24%   81.24%
=======================================
  Files         256      256
  Lines       23100    23100
=======================================
  Hits        18767    18767
  Misses       4333     4333

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Optimize the unit test for restartmanager

- What I did
Optimize the unit test for restartmanager
- How I did it
- How to verify it
- Description for the changelog

Fix some typos
Use const and variable instead of expression such as 100*time.Millisecond etc.
Modify some logs information

Signed-off-by: yuexiao-wang<EMAIL_ADDRESS>

@crosbymichael PTAL
Thanks

LGTM


Steps to create Windows Packages such as MSI

Hi @raghushantha, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Raghu Shantha). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Error: $config is not defined

After installation of sst with curl -fsSL https://ion.sst.dev/install | bash
Receiving the following error:
╰─ sst init
╰─ npx sst deploy                                                                                ─╯
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y

Error: $config is not defined

Trace: ReferenceError: $config is not defined
    at file:///Users/.../.sst.config.1720338849962.mjs:4:26

sst.config.ts
/// <reference path="./.sst/platform/config.d.ts" />

export default $config({
  app(input) {
    return {
      name: "00",
      removal: input?.stage === "production" ? "retain" : "remove",
      home: "aws",
    };
  },
  async run() {},
});

(Environment: Apple M1 Max OS Sonoma 14.5)

its not npx sst dev its just sst dev sst is not installed on your machine as a cli tool

I've got this problem too, it seems a conflicting issue between SST V2 and Ion. Especially, sst is installed locally when initializing a new ion project with "sst" : "ion" in the package.json and ion is in fact referencing the latest SST version, i.e. v2 at the moment. So when you have a package.json script executing a sst command, you're essentially running sst v2 ... The fix I've found is simply to remove the sst entry from package.json, sst is not referenced from sst.config.ts anymore.
Because SST is installed globally, specifying e.g. sst deploy ... in the package.json scripts will default back to the globally installed SST (i.e. ion).

We are now pushing Ion to npm as well. https://ion.sst.dev/docs/reference/cli/
So you don't need to install it globally anymore if you are using it in a Node project.

Closing this for now.


Bump pooled-jms to 3.1.3

Bump version to include:
Fix session pooling under load: https://github.com/messaginghub/pooled-jms/pull/30

@zhfeng, could you please review and release this?

Thanks @brunobat and it is only effect pooled-jms 3.x ?

I imagine it will affect all previous versions... However the backport was not implemented on the pooled-jms side.


ERROR: Invalid UserOp signature or paymaster signature

[REQUIRED] Environment
Details: Invalid UserOp signature or paymaster signature
Version<EMAIL_ADDRESS>at Object.http (/Users/user/eth/aa-account/node_modules/@alchemy/aa-core/node_modules/viem/src/utils/rpc.ts:110:13)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async request (/Users/user/eth/aa-account/node_modules/@alchemy/aa-core/node_modules/viem/src/clients/transports/http.ts:56:30)
at async delay.count.count (/Users/user/eth/aa-account/node_modules/@alchemy/aa-core/node_modules/viem/src/utils/buildRequest.ts:68:18)
at async attemptRetry (/Users/user/eth/aa-account/node_modules/@alchemy/aa-core/node_modules/viem/src/utils/promise/withRetry.ts:34:22) {
details: 'Invalid UserOp signature or paymaster signature',
docsPath: undefined,
metaMessages: [
'URL: https://polygon-mumbai.g.alchemy.com/v2/DH4n-QvjWVu44OvUFRtIOAaOvzsu1U9B',
'Request body: {"method":"eth_sendUserOperation","params":[{"initCode":"0x","sender":"0xFAF9c42cd05063fe22A966a0886BD48e51Eef9F1","nonce":"0x3","callData":"0xb61d27f6000000000000000000000000490dd3ccc7ff94823d4f10bb6d97c7802957e6bf00000000000000000000000000000000000000000000000000038d7ea4c6800000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000","signature":"0x92569ae9ecab9058307e464a68edd1e79cc8f1a9fca10404a4f59ab4a5120e2a0d50e5ee4ac04d54b74885d47b87f822cb005d29ef42dd3cce122a9b47f6cc971b","paymasterAndData":"0x","callGasLimit":"0x3400","verificationGasLimit":"0xa1c4","preVerificationGas":"0xab90","maxFeePerGas":"0xdbd76b5e","maxPriorityFeePerGas":"0xdbd76b3e"},"0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789"]}'
],
shortMessage: 'RPC Request failed.',
version<EMAIL_ADDRESS>cause: {
code: -32507,
message: 'Invalid UserOp signature or paymaster signature'
},
code: -32507
}

Browser version: ts-node
AA SDK version: last
Package:

[REQUIRED] Describe the problem
How to reproduce:
Relevant code or sample repro:

We need more info to help out here, can you attach some code samples or a way to reproduce the bug? This issue may occur if something changes in the user operation after the signature is calculated.

import {
  SimpleSmartContractAccount,
  SmartAccountProvider,
  type SimpleSmartAccountOwner,
} from "@alchemy/aa-core";
import { privateKeyToAccount, mnemonicToAccount } from "viem/accounts";
import { polygonMumbai } from "viem/chains";
import { toHex } from "viem";
import { PRIVATE_KEY } from "./privateKey";

async function main() {
  const SIMPLE_ACCOUNT_FACTORY_ADDRESS =
    "0x9406Cc6185a346906296840746125a0E44976454";

  // 1. define the EOA owner of the Smart Account
  // This is just one exapmle of how to interact with EOAs, feel free to use any other interface
  const ownerAccount = privateKeyToAccount(
    PRIVATE_KEY
  );
  // All that is important for defining an owner is that it provides a `signMessage` and `getAddress` function
  const owner: SimpleSmartAccountOwner = {
    // this should sign a message according to ERC-191
    signMessage: async (msg) =>
      ownerAccount.signMessage({
        message: toHex(msg),
      }),
    getAddress: async () => ownerAccount.address,
  };

  // 2. initialize the provider and connect it to the account
  const provider = new SmartAccountProvider(
    // the demo key below is public and rate-limited, it's better to create a new one
    // you can get started with a free account @ https://www.alchemy.com/
    "https://polygon-mumbai.g.alchemy.com/v2/DH4n-QvjWVu44OvUFRtIOAaOvzsu1U9B", // rpcUrl
    "0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789", // entryPointAddress
    polygonMumbai // chain
  ).connect(
    (rpcClient) =>
      new SimpleSmartContractAccount({
        entryPointAddress: "0x5FF137D4b0FDCD49DcA30c7CF57E578a026d2789",
        chain: polygonMumbai,
        factoryAddress: SIMPLE_ACCOUNT_FACTORY_ADDRESS,
        rpcClient,
        owner,
        // optionally if you already know the account's address
        // accountAddress: "0xFAF9c42cd05063fe22A966a0886BD48e51Eef9F1",
      })
  );
  // 3. send a UserOperation
    const { hash } = await provider.sendUserOperation({
      target: "0x490Dd3cCc7ff94823d4F10bb6d97c7802957e6bf",
      data: "0x",
      value:<PHONE_NUMBER>000000n, // value: bigint or undefined
    });

    console.log(hash);

}
main();

It worked when I used<EMAIL_ADDRESS>It got an error when I used other versions

The fix for now is to modify
message: toHex(msg),

to be:
message: { raw: toHex(msg) },

We're working on a longer term fix, and updates to our example code, in https://github.com/alchemyplatform/aa-sdk/pull/42

I've update the README and merged #42 . this should be working now. Make sure to update the latest version of viem as well (at least 1.1.7 is required)


Show use of miniaudio via new command that accepts entered AMY ASCII commands.

As per https://github.com/bwhitman/amy/issues/21 this PR shows using a different audio library.
Has been primarily tested on Fedora 37, but also macOS Ventura, and Raspbian.
make -f Makefile.message
./amy-message
v0f440l1
v1f441l1
v2f442l1

The first thing I noticed (other than it just working, which was great, with no library installs) is that the -c parameter does not work as expected. I use -c to address individual outputs of a multi-channel sound card for things like Alles running on a computer.
I'll take a moment to try to shim that back in, but need to see how miniaudio does its channel handling.

Oh, ugh, i created a new PR by accident , but I think I got channels in there

OK, we're back. Take a look at what I did and lmk if it still works for you? You can try -c 0 or -c 1 and it should only play on that channel

OK, we're back. Take a look at what I did and lmk if it still works for you? You can try -c 0 or -c 1 and it should only play on that channel

Oh. I totally removed the channel part. Thanks for putting this back in. It works.
The only thing remaining is I forgot to put amy-message in .gitignore.

Great. I merged this in. Thanks so much for all your help @octetta . I'll work on porting this over to Alles and Tulip later too, it'll simply things a bit there.


chore: bump validator plugin version to support rule addition

Codecov Report

Merging #119 (552bdbd) into main (424210c) will decrease coverage by 1.26%.
The diff coverage is 100.00%.

:exclamation: Current head 552bdbd differs from pull request most recent head c9dd8c0. Consider uploading reports for the commit c9dd8c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   81.15%   79.89%   -1.26%
==========================================
  Files           4        4
  Lines         382      383       +1
==========================================
- Hits          310      306       -4
- Misses         65       67       +2
- Partials        7       10       +3

Files
Coverage Δ

internal/controller/azurevalidator_controller.go
78.94% <100.00%> (-6.39%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424210c...c9dd8c0. Read the comment docs.


Mimalloc Alignment

What is the default alignment for memory allocated by mimalloc? and is it configurable?
For windows I would want to set the alignment to 16 bytes as that makes all fields align to be read by sse instructions.

Well, I guess this answer is a bit late (apologies!), but, yes, mimalloc always aligns to at least 16 bytes (set as MI_MAX_ALIGN_SIZE in mimalloc-types.h), so it is safe for SSE2 instructions.

Well, mine also very late response: Thank you! 👍

ok I got curious, why is it called MI_MAX_ALIGN_SIZE instead of MI_MIN_ALIGN_SIZE or something like MI_QUANTUM_SIZE? Even the comment on mimalloc-types mentions minimal alignment.


initial x64 build

consolidated VS2015 and VS2017 builds back into one solution
updated dllexport and started to adapt for x64, may be some lower level functions of NppPluginNETBase.cs, NppPluginNETHelper.cs or UnmanagedExports.cs are not adapted yet
fixed xunit compiler warnings
seems for mdbghost32.csproj and mdbghost64.cspro it might be sufficient to have just one project

Build, see https://ci.appveyor.com/project/chcg/cs-script-npp/build/<IP_ADDRESS>

Thank you. Looking forward to see the how far it is in the x64 land.
I am on holidays right now so it will need to wait till the next year (a week or so :o)

Just wanted to let you know that I have started the actual porting to the new x64 hosting model (https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net).
The effort requires significant project restructuring thus please put on  hold any modifications based on the current master.
If you must to work on something before the completion x64 porting please use before_x64_porting branch.

The minimum required parts from https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net are already merge with this PR and are functional. I think just if you want to use the new splitted interface you need to port. Be carefull to take the data from the template, as the demo is outdated.
I already worked in the suggestion for VS2017 from https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net/issues/31 to remove the path:

Ok, by simply removing the LibBoolPath attribute on the DllExportTask in NppPlugin.DllExport.targets it works for me in both VS2015 and VS2017. :P

The minimum required parts from https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net are already merge...

I am not sure what I follow. I tried to build the merged project and had no luck with hosting x64 binaries at runtime. I also noticed that the correct NPP interface (content of PluginInfrastructure) still wasn't in the codebase.
Anyway, I have already brought the correct "NppPluginNET*.cs" and their dependencies as well as have a working x86/x64 plugin hosting infrastructure. Thus I am really close to get is all together.
And yes, "Ok, by simply removing the LibBoolPath attribute on the " is a silly thing that supposed to be already fixed in the https://github.com/kbilsted/NotepadPlusPlusPluginPack.Net  but.... I have also figured this out. Interestingly enough "LibBoolPath" does not upset VS2015 but breaks VS2017 build. But removing it makes both IDEs to build just fine.

Similar to:
    - if "%PlatformToolset%"=="VS15" call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" %archi%
    - if "%PlatformToolset%"=="VS17" call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" %archi%

also the path to the libtool is no longer at:
                    LibToolPath="$(DevEnvDir)\..\..\VC\bin"
, but anyhow the path seems to be set automatically by the IDE, so maybe:
LibToolPath="$(DevEnvDir)....\VC\bin;$(LibToolPath)"
would work similar.

I also want to use this opportunity to restructure the project by making both core assemblies pure .NET and introducing a lean pure plugin (exported) assembly that simply loads the core assemblies at runtime.
Though this task has its own challenges as it is a canonical cyclic dependency case. But I have solved it by mixing binary and source sharing.
Merging both core assemblies may be somewhat beneficial but not essential (at least at this stage)


Title line in content/ja/case-studies/chinaunicom/index.html is not translated into Japanese

This is a Bug Report

Problem:
The title line (line 2) is not tranlated in Japanese translation of China Unicom's casestudy
https://github.com/kubernetes/website/blob/master/content/ja/case-studies/chinaunicom/index.html
title: China Unicom Case Study
Proposed Solution:
Translate the title line and update the index.html file.
Change from:
title: China Unicom Case Study
To:
title: China Unicom ケーススタディ
Page to Update:
https://kubernetes.io/ja/case-studies/chinaunicom/index.html
/language ja
/assign

/kind cleanup

/priority backlog
/lifecycle active

/close