Powerflow background is transparent, not black.

When I access x.x.x.x:8675/ for the powerflow animation, the background of the page is transparent, and I can't see the current battery percentage without highlighting the text on the page.
Did I miss a configuration step?

If I look at the page source and change the CSS background to black, it looks great, but then I think it autorefreshes and goes back to background=transparent.

Hi @venturanc!
How are you running the proxy?  Docker or direct via command line?  There are some envrionmental settings that change the color settings (see https://github.com/jasonacox/pypowerwall/tree/main/proxy/web):
# default
PW_STYLE=clear

# others
PW_STYLE=black
PW_STYLE=white
PW_STYLE=dakboard
PW_STYLE=grafana

Also, try this: http://x.x.x.x:8675/example.html - it should render an iFrame example like this:

Ahh! Thanks! I'm running the docker version. The example html link does work too. Sorry that I missed that. I'll close this issue that was my user error.
BTW, thanks so much for developing this! I'm using this to get Tesla Powerwall info into Smartthings for home automation (switching off devices if grid outage, reminders to do laundry/dishes when the powerwall is full and excess solar production etc.)
I also have a python script that gets the grid power usage every 2 minutes from pypowerwall during solar production time and if my car is charging, it uses Teslapy to adjust the car charging speed to try and maintain minimal to no grid exports to avoid non-bypassable charges, and it stops charging at 4pm when the 4-9 peak period starts to not drain the powerwall. it was pretty easy to modify the TesSense project and get the data from pypowerwall instead of Sense!

Thanks @venturanc !  I would love to see some of your scripts if you are ever willing to share.  Post them here if it is easy or we have a section where cool automation contributions can be added: https://github.com/jasonacox/pypowerwall/tree/main/tools - No pressure. Thanks for the kind words. 🙏

Sure @jasonacox - I did a writeup about how to use PyPowerwall with SmartThings here:
I need to spend some more time cleaning this up, and perhaps add a web API call to start/stop the solar charging, and maybe tie it all together with pypowerwall with a docker-compose file, and get it published to my own github (after I figure out how to have it read/use the environmental variables to get the tesla login data and input a tesla refresh token, lat/lon and py-powerwall_IP variables - I'll refer to your code on the environmental variables stuff), but here's the quick and dirty functional python script:
"""
 Adapted by Nate Carroll 03/2023 from TesSense w/ SenseLink  -Randy Spencer 2023 Version 9.7
 Python charge monitoring utility for those who have a Tesla Powerwall.
 Uses jasonacox/pypowerwall docker container to get realtime stats from the local gateway for Production
 and Grid Utilization of electricity to control
 your main Tesla's AC charging amps to charge only with excess production.
 Simply plug in your car, update your info below, and run this in python.

 Added: checking of location of Tesla to be sure it's charging at home
 Added: tracks cabin temp and local chargers, vents the car if it gets too hot
 - removed due to Tesla removal of Vent option from API
"""

username =<EMAIL_ADDRESS># Fill in Tesla login email address/account
lat, lon  = ##.###, -###.###        # Fill in Location where charging will occur (shown at startup)
pypowerwall_IP = '10.x.x.x:8675'	# Fill in IP address and port for pypowerwall docker container

RedTxt, BluTxt, NormTxt = '\033[31m', '\033[34m', '\033[m'
RedBG, GrnBG, NormBG = '\033[101m', '\033[102m', '\033[0m'

import datetime, asyncio
import logging, sys#, json
# pip3 install teslapy
import teslapy
#/c Set stdout as logging handler
root_log = logging.getLogger()
root_log.setLevel(logging.WARNING) # WARNING or INFO or DEBUG
handler = logging.StreamHandler(sys.stdout)

def printerror(error, err) :                               # Error message with truncated data
    print(str(err).split("}")[0], "}\n", datetime.datetime.now().strftime( "%a %I:%M %p" ), error)

def printmsg(msg) :                                        # Timestamped message
    print( " ", datetime.datetime.now().strftime( "%a %I:%M %p" ), msg )

def PrintUpdate(chargedata, fast) :                        # Display stats at every % change
    print( "\nLevel:",
        chargedata['battery_level'], "%, Limit",
        chargedata['charge_limit_soc'], "%,",
        chargedata['charge_rate'], "MPH",
        chargedata['charger_voltage'], "Volts",
        chargedata['charge_energy_added'], "kWh added,")
    if fast : print("Rate:",
        chargedata['charger_power'], "KWs",
        chargedata['conn_charge_cable'],
        chargedata['fast_charger_type'],
        chargedata['minutes_to_full_charge'], "Minutes remaining\n" )
    else : print(chargedata['charger_actual_current'], "of a possible",
        chargedata['charge_current_request_max'], "Amps,",
        chargedata['time_to_full_charge'], "Hours remaining\n" )

def PrintTemp(car) :
    #Tesla removed vent API in USA due to NTHSA ~01/2023 - causes API error
	#if car.get_vehicle_data()['climate_state']['inside_temp'] > 40 : # 104°F
    #    if not car.get_vehicle_data()['vehicle_state']['fd_window'] : # Not Open
    #        Vent(car, 'vent')
    #else :
    #    if car.get_vehicle_data()['vehicle_state']['fd_window'] :    # Open
    #        Vent(car, 'close')
    print(car.temp_units(car.get_vehicle_data()['climate_state']['inside_temp']), end='')
    if car.get_vehicle_data()['climate_state']['fan_status'] : print(car.get_vehicle_data()['climate_state']['fan_status'], end='')
    if car.get_vehicle_data()['climate_state']['cabin_overheat_protection_actively_cooling'] : print(car.get_vehicle_data()['climate_state']['cabin_overheat_protection_actively_cooling'], end='')

def SendCmd(car, cmd, err) :                               # Start or Stop charging
    try :
        car.command(cmd)
    except teslapy.VehicleError as e :
        print(err)
        printmsg(e)

def SetAmps(car, newrate, err) :                           # Increase or decrease charging rate
    try :
        car.command('CHARGING_AMPS', charging_amps = newrate)
    except teslapy.VehicleError as e : printerror("V: "+err, e)
    except teslapy.HTTPError as e: printerror("H: "+err, e)

def SetCharging(car, newrate, msg) :
    print(msg, "charging to", newrate, "amps")
    if newrate == 2 : newrate = 1                          # For API a newrate of 3=3, 2=3, 1=2
    SetAmps(car, newrate, "Failed to change")              #  so to set to 2 newrate must be 1
    if newrate < 5 :                                       # if under 5 amps you need to send it twice:
        SetAmps(car, newrate, "Failed to change 2")

def StartCharging(car) :
    try :                                                  # Collect new data from Tesla
        state = car.get_vehicle_data()['charge_state']['charging_state']
    except teslapy.HTTPError as e:
        printerror("Tesla failed to update, please wait a minute...", e)
        return
    print(GrnBG + "Starting" + NormBG + " charge at 2 Amps")     # Underlined
    if state != "Charging" :
        SendCmd(car, 'START_CHARGE', "Won't start charging")
        SetAmps(car, 1, "Won't start charging 2")
        SetAmps(car, 1, "Won't start charging 3")

def StopCharging(car) :
    print( RedBG + "Stopping" + NormBG + " charge" )            # Underlined
    SendCmd(car, 'STOP_CHARGE', "Failed to stop")

def SuperCharging(chargedata) :                            # Loop while DC Fast Charging
    if chargedata['fast_charger_present']:
        printmsg("DC Fast Charging...")
        PrintUpdate(chargedata, 1)
        return(True)

def Wake(car) :
    printmsg("Waking...")
    try : car.sync_wake_up()
    except teslapy.VehicleError as e :
        printerror("Failed to wake", e)
        return(False)
    return(True)

def update_powerwall(): #get site data on solar/grid from local Powerwall gateway via pypowerwall docker container
    instant_stats = requests.get('http://'+pypowerwall_IP+'/aggregates')
    return (instant_stats.json())

def UpdateSense() :  # Update Powerwall and charger voltage
    global power_diff, volts
    try :
        power_diff = update_powerwall()['site']['instant_power']
        volts = int(vehicles[0].get_vehicle_data()['charge_state']['charger_voltage'])
    except :
        printmsg(RedTxt + "Powerwall data timeout or cannot get charger voltage" + NormTxt)
        power_diff = 0
        return(True)
    else :
        #volts = int(car.get_vehicle_data()['charge_state']['charger_voltage'])
        power_diff = int(update_powerwall()['site']['instant_power'])*-1

def Vent(car, command) :
    try :  car.command('WINDOW_CONTROL', command = command, lat=lat, lon=lon)
    except teslapy.VehicleError as e : printmsg("Window_Control Failed " + str(e))
    else:  print(RedTxt + "Windows will now", command + NormTxt)

async def TesSense() :
    rate = newrate = limit = level = lastime = fullORunplugged = 0
    minrate = 2                                            # Minimum rate you can set the charger to

    retry = teslapy.Retry(total=3, status_forcelist=(500, 502, 503, 504))

    with teslapy.Tesla(username, retry=retry, timeout=30) as tesla:
        if not tesla.authorized:
            print('Use browser to login. Page Not Found will be shown at success.')
            print('Open this URL: ' + tesla.authorization_url())
            tesla.fetch_token(authorization_response=input('Enter URL after authentication: '))
        vehicles = tesla.vehicle_list()

        print("Starting connection to", vehicles[0].get_vehicle_summary()['display_name'], end='')
        cardata = vehicles[0].get_vehicle_data()
        try:
            print("... [", round(cardata['drive_state']['latitude'], 3), round(cardata['drive_state']['longitude'], 3), "]")
        except: pass
        #print(' last seen ' + vehicles[0].last_seen(), end='') #last seen timestamp in future error
        if vehicles[0]['charge_state']['battery_level']:
            print(' at ' + str(vehicles[0]['charge_state']['battery_level']) + '% SoC\n')
        else: print('\n')

        while (True):                                      # Main loop with night time carve out
            if vehicles[0].get_vehicle_summary()['in_service'] :
                print("Sorry. Currently this car is in for service")
                exit()

            if datetime.datetime.now().time().hour < 8 or datetime.datetime.now().time().hour >= 16 :
                printmsg(BluTxt + "Nighttime" + NormTxt +", Sleeping until next hour...")
                if 16 <= datetime.datetime.now().time().hour <= 17 :
                    StopCharging(vehicles[0])
                    printmsg(BluTxt + "4-9pm" + NormTxt +", Stop charging...") #4-9pm peak rate when PowerWall is powering house, so don't charge car and drain powerwall
                await asyncio.sleep(60 * (60 - datetime.datetime.now().time().minute))
                continue

            if UpdateSense() :                             # Collect new data from Energy Monitor
                await asyncio.sleep(20)                    # Error: Return to top of order
                continue

            minwatts = minrate * volts                     # Calc minwatts needed to start charging

            if not vehicles[0].available() :               # Car is sleeping
                if power_diff > minwatts and not fullORunplugged :
                    if Wake(vehicles[0]):                  # Initial daytime wake() also, to get status
                        rate = newrate = 0                 # Reset rate as things will have changed
                        continue
                    else:
                        print("Wake error. Sleeping 20 minutes and trying again")
                        await asyncio.sleep(1200)          # Give the API a chance to find the car
                        continue
                else :
                    if fullORunplugged == 1 : print("Full-", end='')
                    elif fullORunplugged == 2 : print("Unplugged-", end='')
                    print("Sleeping, free power is", power_diff, "watts" )
                    if fullORunplugged :
                        printmsg(" Wait twenty minutes...")
                        await asyncio.sleep(1200)
                        continue

            else :                                         # Car is awake
                try :
                    cardata = vehicles[0].get_vehicle_data() # Collect new data from Tesla
                    chargedata = cardata['charge_state']
                except teslapy.HTTPError as e:
                    printerror("Tesla failed to update, please wait a minute...", e)
                    await asyncio.sleep(60)                # Error: Return to top of order
                    continue

                if SuperCharging(chargedata) :             # Display any Supercharging or DCFC data
                    await asyncio.sleep(120)               # Loop while Supercharging back to top
                    continue

                if 'latitude' in cardata['drive_state'] :  # Prevent remote charging issues
                    if round(cardata['drive_state']['latitude'], 3) != lat and \
                       round(cardata['drive_state']['longitude'], 3) != lon :
                        print(round(cardata['drive_state']['latitude'], 3), \
                             round(cardata['drive_state']['longitude'], 3), end='')
                        printmsg(' Away from home. Wait 5 minutes')
                        fullORunplugged = 2                 # If it's not at home, it's not plugged in nor full
                        await asyncio.sleep(300)
                        continue
                else :
                    print(RedTxt + 'Error: No Location' + NormTxt)

                if not chargedata['charging_state'] == "Charging" :   # Not charging, check if need to start

                    if power_diff > minwatts and not fullORunplugged: # Minimum free watts to start charge
                        if chargedata['battery_level'] >= chargedata['charge_limit_soc'] :
                            print("Full Battery, power at", power_diff, "watts" )
                            fullORunplugged = 1
                        elif chargedata['charging_state'] == "Disconnected":
                            print(RedTxt + "Please plug in" + NormTxt + ", power at", power_diff, "watts" )
                            fullORunplugged = 2
                        else :                             # Plugged in and battery is not full so
                            StartCharging(vehicles[0])

                    else :
                        print( "Not Charging, free power is at", power_diff, "watts" )

                else :                                     # Charging, update status
                    if chargedata['battery_level'] < chargedata['charge_limit_soc'] :
                        fullORunplugged = 0                # Mark it as NOT full and AS plugged-in

                    if  level != chargedata['battery_level'] or limit != chargedata['charge_limit_soc'] :
                        level, limit = chargedata['battery_level'], chargedata['charge_limit_soc']
                        PrintUpdate(chargedata, 0)         # Display charging info every % change

                    rate = chargedata['charger_actual_current']
                    newrate = min(rate + int(power_diff/volts), chargedata['charge_current_request_max'])

                    print( "Charging at", rate, "amps, with", power_diff, "watts surplus" )

                    if newrate < minrate :                 # Stop charging as there's no free power
                        StopCharging(vehicles[0])
                        newrate = 0
                    elif newrate > rate :                  # Charge faster with any surplus
                        SetCharging(vehicles[0], newrate, "Increasing")
                    elif newrate < rate :                  # Charge slower due to less availablity
                        SetCharging(vehicles[0], newrate, "Slowing")

            if lastime != vehicles[0].get_vehicle_data()['climate_state']['timestamp'] :
                lastime = vehicles[0].get_vehicle_data()['climate_state']['timestamp']
                PrintTemp(vehicles[0])                     # Display cabin temp and fan use
            printmsg(" Wait two minutes...")               # Message after every complete loop
            await asyncio.sleep(120)                       # Could use variable to change frequency of updates, but 2 minutes seems reasonable without hitting Tesla API frequently enough to cause lockout

#run the main program
try:
    await TesSense()
except KeyboardInterrupt:
    print("\n\n Interrupt received, stopping TesSense\n")

This is awesome! Thanks @venturanc 🙏
Do you mind if I add this to our /tools section (also happy to add a link to your github location once you have it)?  Or you could submit a PR youself to get listed as a pypowerwall contributor. 😉

I'd be honored to submit a PR to /tools and contribute! Give me just a few days to sort everything out and hopefully will get it in soon.

Thanks @venturanc !


npm install fails

Is this a problem of npm or a broken publish?
$ npm install tap-dev-tool
# After a minute or two…
npm ERR! fetch failed https://registry.npmjs.org/tap-dev-tool/-/tap-dev-tool-1.3.0.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 503
# Retrying………

$ curl https://registry.npmjs.org/tap-dev-tool/-/tap-dev-tool-1.3.0.tgz
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<title>503 No healthy backends</title>

Error 503 No healthy backends

No healthy backends

Guru Mediation:

Details: cache-fra1238-FRA<PHONE_NUMBER><PHONE_NUMBER>

Varnish cache server

I get the same error when trying to install<EMAIL_ADDRESS>and @1.0. When installing Jam3/tap-dev-tool here’s what I get:
$ npm install Jam3/tap-dev-tool
npm ERR! fetch failed https://registry.npmjs.org/tap-console-parser/-/tap-console-parser-1.0.4.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 503

Other modules install fine:
$ npm install once
<EMAIL_ADDRESS>node_modules/once
└──<EMAIL_ADDRESS>

Alright, now it’s all up and running again. Seems like one of npm’s servers was down.
I wonder what happens when npm goes bankrupt or something. Web developer apocalypse :)


Add helm docs to generate chart readme

Signed-off-by: Tuan Anh Tran<EMAIL_ADDRESS>1. Issue, if available:
2. Description of changes:
use helm-docs to generate chart readme and add a step in CI to check if the chart readme needs updated.
3. Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'm a bit confused by how this PR works. I'd expect some line like helm-docs in the verify step of the Makefile.

I'm a bit confused by how this PR works. I'd expect some line like helm-docs in the verify step of the Makefile.

there's already an github action for this so i use it but if you prefer to have it in Makefile (eg we change to sth else other than github action) then it's good too. I will move it to Makefile

I'm not sure how i got this error in CI New file modification detected in the Git working tree. Please check in before commit. 335. I don't have problem when i do make codegen locally? do you know why @ellistarn ?

I'm not sure how i got this error in CI New file modification detected in the Git working tree. Please check in before commit. 335. I don't have problem when i do make codegen locally? do you know why @ellistarn ?

That's this check: https://github.com/aws/karpenter/blob/main/Makefile#L42. It's what I was mentioning earlier -- we make sure the workspace is clean after running make verify.

@ellistarn i fixed it CI. The go.mod in toolds/ needs update


Validate formatting placeholders (%s, %d, etc)

Formatting placeholders (%s, %d, etc) in strings are used to insert dynamic content within static and usually translatable text. Most programming languages (C, C++, PHP, Pascal, Java, etc) support them and many applications actively use them.
Miss-placed, miss-typed or simply missing formatting placeholders in the translated text can cause application issues, from minor confusion to more serious application crashes (due to type incompatibilities for example).
Validating formatting placeholders could save the day. By extracting a list of used placeholders in each string and simply comparing them.

I wrote a small PHP script that validates simple formatting placeholders (e.g. %s, %d, etc), but could be easily expanded to also process more complex placeholders (e.g. %10.4d, %.1f, etc) by adjusting the regex pattern. Below is a snippet to demonstrate.
Call PoToolkit::containSamePlaceholders($msgid, $msgstr) for every PO entry, it returns true if placeholders match, otherwise false.
class PoToolkit
{
	public static function extractPlaceholders($str)
	{
		// strip escaped placeholder symbol
		$str = str_replace('%%', '', $str);
		$matches = array();
		if (preg_match_all('#%[\w]\b#', $str, $matches) !== false)
			return $matches;
		else
			return array();
	}

	public static function containSamePlaceholders($str1, $str2)
	{
		$phs1 = self::extractPlaceholders($str1);
		$phs2 = self::extractPlaceholders($str2);
		if (count($phs1) != count($phs2))
			return false;
		$index = 0;
		$count = count($phs1);
		while ($index < $count)
		{
			$ph1 = array_shift($phs1);
			$ph2 = array_shift($phs2);
			if ($ph1 != $ph2)
				return false;
			$index++;
		}
		return true;
	}
}

msgfmt already validates format strings and Poedit's validation functionality uses it. I'm not sure what's the point of obvious code snippet in irrelevant (for Poedit) language either to honest…

I am talking about Poedit's built in Validate functionality. It doesn't seem to be catch mismatched placeholders for me...

Again: msgfmt most definitely does validate these. Whatever the problem is, it's on your end. Most likely not having strings tagged as php-format (read the gettext manual).

Here is a simple example of some PO entries which according to Validate functionality fine:

No problems with the translation found. The translation is ready for use.

msgid "Example"
msgstr "Example"

msgid "Result: %d out of %d matched."
msgstr "Result"

msgid "Not supported format (%d)"
msgstr "Not supported format"

Am I missing something? Shouldn't validation give out that some placeholders are missing?

Am I missing something?

 Please read the goddamn GNU gettext manual already, it exists for a reason.


Delete all tags after we use spring-cloud-azure-dependencies:4.0.0

<!-- {x-version-update;com.azure.spring:azure-spring-boot-starter-active-directory;dependency} -->

Such kind of tag can be deleted after we use spring-cloud-azure-dependencies:4.0.0

Closing this issue, since all tags begin with <!-- {x-version-update have been deleted in main branch.


Add a test for posting files

This fails at the moment, but should help with fixing the issue

#102 is closed with v1.5.3, close this PR as well.


Can add movement speed modifications and skills without CD

Can add movement speed modifications and skills without CD

movement speed obfuscate
I need to research

You can try to add a box drawing for other players

Accelerate directly with Initial 5 Soul 7.5 to search back and forth

Use CE

https://github.com/asd9176506911298/Goose-Goose-Duck-ImGui/releases/tag/v0.0.2
Only Test on Tutorial Mode

You can try to add a box drawing for other players

https://github.com/asd9176506911298/Goose-Goose-Duck-ImGui/releases/tag/v0.0.5


Bug report 'from torchvggish import vggish'

when I cd to 'avs_scripts/avs_s4' and run 'from torchvggish import vggish'
it reports following error message:

Traceback (most recent call last):
  File "/root/miniconda3/envs/avs/lib/python3.7/site-packages/soundfile.py", line 151, in <module>
    raise OSError('sndfile library not found')
OSError: sndfile library not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/miniconda3/envs/avs/lib/python3.7/site-packages/soundfile.py", line 178, in <module>
    _snd = _ffi.dlopen(_os.path.join(_path, '_soundfile_data', _packaged_libname))
OSError: cannot load library '/root/miniconda3/envs/avs/lib/python3.7/site-packages/_soundfile_data/libsndfile.so': /root/miniconda3/envs/avs/lib/python3.7/site-packages/_soundfile_data/libsndfile.so: cannot open shared object file: No such file or directory

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/yhling/avs/avs_scripts/avs_s4/torchvggish/vggish.py", line 6, in <module>
    from . import vggish_input, vggish_params
  File "/home/yhling/avs/avs_scripts/avs_s4/torchvggish/vggish_input.py", line 27, in <module>
    import soundfile as sf
  File "/root/miniconda3/envs/avs/lib/python3.7/site-packages/soundfile.py", line 189, in <module>
    _snd = _ffi.dlopen(_libname)
OSError: cannot load library 'libsndfile.so': libsndfile.so: cannot open shared object file: No such file or directory

I wonder if there is something I missed. Thank you for your help in advance~

I tried 2 things and finally deal with it:
1.
pip install librosa==0.6.0 numba==0.48.0
2.
yum install libsndfile
this works for me


feat: add support for node version 20

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

v1.7.0
GitHub release

Your semantic-release bot :package::rocket:


Update recipe for py312_patch

Preparation for py312 release.

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:26: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: clone/recipe/meta.yaml:26: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
WARNING: clone/recipe/meta.yaml:29: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: clone/recipe/meta.yaml:39: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: MPL-2.0
WARNING: clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
ERROR: clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: clone/recipe/meta.yaml:41: missing_description: The recipe is missing a description
Errors were found


reformated using capafmt

mostly affects:

meta reorder
whitespace
indents

with these changes and https://github.com/fireeye/capa/pull/401 the linter should be happy

currently depends on #398

currently depends on #398


Clarify environment variables

An attempt to make the whole issue of what environment variables are available where and when make sense.
Branched off #1368
Whole bunch more refactoring of interpolation and custom variables to come.

Closing this for now. I'll start a new PR when I pick up the work to update our env variable docs.


Update sentry and logging configuration

What does this PR do?
Refactors configuration into its own module, adds some useful logging, plus a bunch of standardization/cleanup changes.
Helpful background context
Our terraform template requires that each env variable be present in all envs, even if we don't need it in a particular env (e.g. SENTRY_DSN is not needed in dev). Env variables are now given a string value of "None" in env(s) where they are not needed.
How can a reviewer manually see the effects of these changes?
Run a transform locally with SENTRY_DSN=None in .env to confirm that it configures correctly and that the logging output is as expected and includes new total transformation time information. Sample command:
pipenv run transform -i tests/fixtures/datacite/datacite_records.xml -o output/datacite-timdex-records.json -s jpal

Also verify successful GH actions run using shared workflow.
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/RDI-160
https://mitlibraries.atlassian.net/browse/RDI-148

Includes new or updated dependencies?
YES
Developer

[x] All new ENV is documented in README
[x] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Yeah I had commented in the code initially to add that test but removed it here because tickets are better. On my to-do list to add a ticket for it :)

Looks good and works as expected, I did notice that we don't have a unit test for write_timdex_records_to_json, I assume coverage is counting that as covered by the CLI tests. I don't think that needs to block this but we might circle back to creating that


404 Page not found

Hi
Thanks for this great tool :)
I've got an error 404 when i try to connect to my influxdb server from my munin box
What i'm typing in :

host/handle [localhost]: myinfluxdbserver.mydomain
port [8086]: 8086
user [None]: influxdbuser
password: influxdbuserpass
⚠ Could not connect to database: 404: 404 page not found

Am i doing something wrong ??
Nothing appears in influxdb.log and tcpdump shows nothing too
Makgin a curl -G 'http://myinfluxdbserver.mydomain:8086/query?q=SHOW+USERS&u=influxdbuser&p=influxdbuserpass' throws the good result
Thanks for any advice

Hi
For these who'd read this, it was my influxdb version that was in cause
I was trying to connect to influxdb 0.10 :-1:
Now i've installed another instance with influxdb 0.8.1 and that's working better...


Add documentation on group JWT authorization for Astarte Channels

The paths for group authorization are not mentioned anywhere in the docs

Expand this section by explaining the semantics of the claims


Use view's requested size when floating it initially

Right now it uses the size of the window when it was still tiled.

I just tested this with urxvt, and when I toggle floating, the terminal goes to the correct requested size. Can someone else confirm/deny this?

Must be an older problem that has been fixed since. Works for me, too.


Support  service discovery with SRV record

Which issue(s) this PR fixes:
follow up https://github.com/fluent/fluentd/pull/2496
What this PR does / why we need it:
Docs Changes:
needed
Release Note:
Same as the title

@repeatedly @cosmo0920
I added some config to support password, username, shared_key. Could you take a look at it?
https://github.com/fluent/fluentd/pull/2876/commits/93ca09e573e11bfcfd78009e5247e10a2a8ae7e8


Improve error messages when ninja commands fail on Windows.

Leading spaces cause the Win32 CreateProcessA function to
generate an ERROR_INVALID_PARAMETER error. This change
strips leading spaces from commands to prevent the error.
Also, output the command that caused CreateProcessA to result
in an error. This will help users track down the cause of a
ninja build failure.

I think stripping white space is not the thing ninja needs to do.
Why not fix build.ninja instead?

Suppose your build.ninja file has an entry like this:
command = $pre_link gcc -o $out @$out.rsp $all_ldflags  $libs  $post_build

Then suppose that $pre_link is undefined.  This leads to a space character before the gcc command.  The leading space character causes CreateProcessA to fail.
It's true that the problem can be fixed by changing the build.ninja file, but it took me a lot of work to track down the cause.  Ninja didn't tell me why the command failed.  It just said "CreateProcess failed (is the command line too long?)".
It also seems strange that ninja would even allow a command with leading whitespace.  It feels like that should be reported as an error, or the whitespace should be stripped.  In the interest of user-friendliness, my pull request stripped the whitespace.

Even in such case, I think you need to fix build.ninja instead.
Also this breaks build running binary like '    .exe'?
Error message improvement looks good to me though.

The example I gave is the one that built me.  Since it was in the link rule, it prevented me from building the executable.
If you're not willing to allow a correction of the white-space, can we at least include an error message if the command includes leading white space?  That would have prevented me from wasting a couple hours building ninja and trying to understand why it failed in the first place.
It's still concerning to me that some build.ninja files will end up working on one platform but not another.  Unless they test on Windows, other people will end up shipping ninja files that work on linux and Mac without realizing they are broken on Windows.

I think that for the whitespace stripping to be accepted, it would have to be demonstrated that all possible build rules which have leading whitespace will always be broken.
Otherwise, if ninja strips the whitespace, it would prevent a build rule that intentionally had leading whitespace from functioning.

Otherwise, if ninja strips the whitespace, it would prevent a build rule that intentionally had leading whitespace from functioning.

Out of curiosity, how would you create a rule that has leading whitespace?  According to the documentation:

In a name = value statement, whitespace at the beginning of a value is always stripped.

The problem with leading whitespace in my case is arising because of a combination of two effects:

The command value starts with a substituted variable name, and
The substituted variable is not defined.

Consider the original example:
rule link
  command = $pre_link gcc -o $out @$out.rsp $all_ldflags $libs $post_build

Because $pre_link is not defined, this leads to a command value with leading whitespace, which seems to violate the expectation described by the documentation.  CreateProcessA doesn't like the command, since it's trying to  run " gcc" (with a leading space) instead of "gcc".
On the other hand, if I do this:
rule link
  command = $pre_link gcc -o $out @$out.rsp $all_ldflags $libs $post_build
  pre_link =

then ninja does what the documentation describes and strips the leading whitespace from the command value.
I'm currently working around this issue by defining pre-link to be the empty string.

Ah.
Thank you for explaining more.
I now agree with you that stripping the white space would be the correct behavior.

@jonesmz It turns out that I was wrong about my second example:
rule link
  command = $pre_link gcc -o $out @$out.rsp $all_ldflags $libs $post_build
  pre_link =

This work-around doesn't actually solve the problem.  Even if pre_link is defined as the empty string, you still end up with a space in front of the gcc command.  (The reason it was working for me is that I was still running my own version of ninja that stripped the leading whitespace.)
Of course, stripping leading whitespace from a command will allow the example above to work.  But since my explanation above was not 100% correct, I don't know if this affects your conclusion that leading white-space stripping should still be performed.

@beevik I should point out that the only person who regularly interacts with this Ninja project on github, who also has the access-permissions to accept merge requests, is @jhasse
So you don't have to convince me one way or another.
But I don't believe my re-formed opinion has changed.
As you pointed out, the ninja documentation does clearly state that leading whitespace will be stripped, so it's not supposed to be possible to construct a build rule that has leading whitespace, even if there is a loop-hole that allows it to happen in the current code.
As a user of Ninja, it is not my expectation that an empty variable will result in the leading whitespace of the fully calculated build rule not being fully stripped.

I still don't think stripping whitespace after variable expansion is correct.
The document does not say exactly about the behavior when first variable is empty, but I think we can interpret that stripping is only happen before variable expansion.
Also, stripping in subprocess-win32.cc may remove intententional whitespace which can be given by '$ '?

@atetubou wrote:

Also, stripping in subprocess-win32.cc may remove intententional whitespace which can be given by '$ '?

This is a good point.  My change would have stripped out that whitespace, inappropriately.
I think I'll just keep my pull request as is (without the white-space stripping).


Cannot read property 'type' of undefined(same as #103)

same as #103
Reproduction: https://github.com/JounQin/test/tree/master/babel-plugin-typecheck

Hi, sorry for taking so long to respond to this, this project is now deprecated in favour of https://codemix.github.io/flow-runtime which aims for full compatibility with Flow.
I checked and babel-plugin-flow-runtime does not have this particular bug.


Congestion control in Netty

Hello,
I'm trying to understand congestion control in Floodlight, which implements Netty to handle its control channel. I find that if I burst to send more than around 1000 pkt-in, pkts begin to loss. I have asked the Floodlight people but they said they did not make this control by default and suggested me to look into Netty. Therefore I'm wondering whether there is such mechanism in Netty (where is it)? And is it possible to configure this mechanism by myself (eg, modify the threshold or even disable it)?
Many thanks!

@zhenyu-zhou we not do any controlling by our own. What we have is the ability to get notified when a Channel becomes non writable and writable again. It's up to the user to back-up and continue in this cases-


ClusterProfile installing multiple Helm charts does not update clusterconfigurations in case of failures

If a ClusterProfile is listing more than one Helm charts, and some are installed before an error happens, the installed Helm charts are not reported.
For instance, deploy following ClusterProfile
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
  name: multiple-helm-charts
spec:
  clusterSelector: env=fv
  syncMode: Continuous
  helmCharts:
  - repositoryURL:    https://prometheus-community.github.io/helm-charts
    repositoryName:   prometheus-community
    chartName:        prometheus-community/prometheus
    chartVersion:     23.4.0
    releaseName:      prometheus
    releaseNamespace: prometheus
    helmChartAction:  Install
  - repositoryURL:    https://grafana.github.io/helm-charts
    repositoryName:   grafana
    chartName:        bitnami/grafana
    chartVersion:     9.0.6
    releaseName:      grafana
    releaseNamespace: grafana
    helmChartAction:  Install

Prometheus gets installed. Grafana does not (as repositoryName is incorrectly set). Yet ClusterConfiguration does not list Prometheus as installed
  apiVersion: config.projectsveltos.io/v1alpha1
  kind: ClusterConfiguration
  metadata:
    creationTimestamp: "2023-08-20T14:27:28Z"
    generation: 1
    labels:
      projectsveltos.io/cluster-name: clusterapi-workload
      projectsveltos.io/cluster-type: Capi
    name: capi--clusterapi-workload
    namespace: default
    ownerReferences:
    - apiVersion: config.projectsveltos.io/v1alpha1
      kind: ClusterProfile
      name: multiple-helm-charts
      uid: 634678b8-ff6f-479c-acae-de5dd50ab0c2
    resourceVersion: "20595"
    uid: 8b2db1ac-cfdc-418b-a5ec-e20fce064179
  status:
    clusterProfileResources:
    - clusterProfileName: multiple-helm-charts

same is visible with
kubectl exec -it -n projectsveltos sveltosctl-0 -- ./sveltosctl show addons
+---------+---------------+-----------+------+---------+------+------------------+
| CLUSTER | RESOURCE TYPE | NAMESPACE | NAME | VERSION | TIME | CLUSTER PROFILES |
+---------+---------------+-----------+------+---------+------+------------------+
+---------+---------------+-----------+------+---------+------+------------------+

Correct ClusterProfile is
apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
  name: multiple-helm-charts
spec:
  clusterSelector: env=fv
  syncMode: Continuous
  helmCharts:
  - repositoryURL:    https://prometheus-community.github.io/helm-charts
    repositoryName:   prometheus-community
    chartName:        prometheus-community/prometheus
    chartVersion:     23.4.0
    releaseName:      prometheus
    releaseNamespace: prometheus
    helmChartAction:  Install
  - repositoryURL:    https://grafana.github.io/helm-charts
    repositoryName:   grafana
    chartName:        grafana/grafana
    chartVersion:     6.58.9
    releaseName:      grafana
    releaseNamespace: grafana
    helmChartAction:  Install


Add algolia service search results to Redux store

Currently, search for services related to a given topic causes the returned services to be stored in the redux store. Services returned from Algolia is kept in the component and not saved to the redux store. This stops us from putting a service from Algolia into a service detail screen.
Acceptance Criteria

[x]  Service search results from Algolia are added to the Redux store
[x] Can open a service detail screen with a service from the algolia search result.
[x] Add google analytics hooks on how many services are stored, with the view to understand whether services take up too much memory on users' phones, send an event for each time more services are added to the store.

Testing steps
To get started testing you'll need to first add a test GOOGLE_ANALYTICS_TRACKING_ID key to your .env, this work sends events to GA so we don't want them going to the production GA account. Now, in GA, open the Reports > Realtime > Events tab so you can monitor events in realtime (see screenshot below). Finally you'll want to adjust the value of MEMORY_REPORT_SEND_EVERY_SERVICES_COUNT to be something smaller and easier to test with, say 1 or 2, you can refer to the PR for more implementation details. Confirm the following:

[x] Search results now click through to their detail screen, services are added to Redux when you tap their title in the search results
[x] MemoryReport Events are sent to GA every MEMORY_REPORT_SEND_EVERY_SERVICES_COUNT count, for example, if this was set to 2 we'd see a report every time the number of new services in Redux is divisible (no remainder) by 2, so, 2, 4, 6 etc...
[x] MemoryReport Events are only sent when NEW services are added to Redux, we shouldn't see a report just because the current Redux count is divisible
[x] Topic service results also trigger MemoryReport events in GA

Here's an example of what you should start to see in GA when you start clicking on services:

Passes QA in Staging Version 1.12


arrow disappeared from the address bar

I recently install powerline-shell both from github and pip. but it doesn't solve the problem. below is an example of my shell. there is no arrow in the shell address,

Hi there, did you follow the instructions to install a patched font as described in https://github.com/b-ryan/powerline-shell#setup ?


Disable AntiVirus Error

It says "Error: make sure your antivirus is disabled."
but my pc don't have antivirus, i can't disable it, and i can't enable ( im using KernelOS ), i dont have antivirus apps, so i dont know what can i do.

An easy fix for this error would be to validate the game files or reinstall the game directly, if the problem still persists you can follow this outdated tutorial which should fix the issue once and for all.

Okey, thanks, the video fix the error! ❤


All hosts Update walkthrough for ASP.NET Core

The sample that this walkthrough uses is changed to ASP.NET Core and has had some additional security updates based on feedback from the identity team.
This updates the walkthrough to match changes made to the sample.

Docs Build status updates of commit 5573909:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8b93423:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:warning:Warning
View
Details

docs/images/SelectHost.JPG
:white_check_mark:Succeeded

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md

Line 542, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'authorize-to-microsoft-graph'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e922e7d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Learn Build status updates of commit 4710cfc:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:warning:Warning
View
Details

docs/images/SelectHost.JPG
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/develop/create-sso-office-add-ins-aspnet.md

Line 291, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 285, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'MicrosoftGraphOptions' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit b755e8a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 9802947:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@davidchesnut I was able to get everything working, including the fallback path. Aside from the previous comments, looks good to me!

Learn Build status updates of commit 4c0bf03:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 10c4b9f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded
View

docs/images/SelectHost.JPG
:white_check_mark:Succeeded
n/a (file deleted or renamed)

docs/images/select-host.png
:white_check_mark:Succeeded
View

docs/includes/register-sso-add-in-aad-v2-include.md
:white_check_mark:Succeeded
View

docs/includes/sso-tutorial-prereqs.md
:white_check_mark:Succeeded
n/a (file deleted or renamed)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Basic Scaffolding

Github actions - build, test and release
Nestjs boilerplate with Blockchain support
Main service controller/module/class
etc.

Closes #2

there is an assumption that we might use redis which might be correct but other than that shouldn't Redis start before the app?

True that is something we would want to do in reconnection-service as well to prevent injection or inject only after it connects, we may want to do that in this work, but this is a just placeholder

question: why are we removing these values?

We might not need all of them, some are related to graphsdk, we will add/remove env variables (check .env.template) and also env.config.ts


Feature/pseudotime tutorial

This adds a tutorial for the pseudotime kernel using the bone marrow data. I'll have to upload this to Figshare and include in cellrank.datasets, see https://github.com/theislab/cellrank/issues/884
closes #47

I disagree with the former and agree with the latter.

View entire conversation on ReviewNB

ok.

View entire conversation on ReviewNB

ok

View entire conversation on ReviewNB

No; for a user who runs this on their computer, it's a good pointer to know roughly how long it takes to execute this on their own machine.

View entire conversation on ReviewNB

Thanks for spotting this.

View entire conversation on ReviewNB

ok.

View entire conversation on ReviewNB

ok.

View entire conversation on ReviewNB

ok.

View entire conversation on ReviewNB

ok.

View entire conversation on ReviewNB

Citation will be inserted there, should see it once we render this.

View entire conversation on ReviewNB

Thanks for your feedback @michalk8, I incorporated your suggested changes.


"now dns add" should have a flag to overwrite any existing matching entry

I use a script and now dns to have dynamic DNS, but I have to have the script remove the old DNS entries for the subdomain because overwriting isn't the default.
It would be very helpful if I could use a command like now dns add --overwrite <details...> to add the new DNS entry while overwriting all others that match.  Matching would be based on everything that uniquely identifies the entry, which would be the domain/subdomain, and possibly other factors for certain record types if applicable.

Sounds like a very good idea!

Wrong button 😄

Hey, it's been over a month.  I would figure this to be fairly simple.  Any idea when I can expect it?

Still nothing happening? This would be very useful to me because my expect script doesn't always work right for removing the old entry, and then I end up with 2 entries, one of which won't work, and that means that if I load the page before manually removing the old entry, the page might be broken until the DNS cache of my browser finally resets.

Thank you for creating this issue!
Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in.
In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on.
For well-explained feature requests (like the one you just posted), please contact us at<EMAIL_ADDRESS>so that we can consider adding it to our roadmap.


Multiple shots in Cinematics and User input

System diagram:

This PR completes the command running component of the cinematic, where commands are run and cancelled.
Thus the testing has focused on the commandRunner.
Thus the CinematicController can play and cancel the shots. In this PR the user can cancel the shot via a mouse click on the canvas or by hitting the enter key.
The user can play the next shot by pressing the "Enter" button as per spec.
Features

Multiple shots are now supported.
Handlers added to listen to changes in the cinematic playback.

onPlayHandler triggers when shot starts playing.
onPauseHandler triggers when shots pause.
onCompletionHandler triggers when cinematic has completely finished.

Add cancelShot and runShot public methods on cinematicController to cancel a shot and run a shot respectively.
Added test coverage to the commandRunner to ensure all behavior is expected.

This change is

@codeluggage I responded above.  Hmmmm. I really don't like how. Reviewable formatted the comment responses.


Gateways supporting LLMServerPool as a an HTTPRoute BackendRef

Our current Envoy integration relies on EnvoyExtensionPolicy and EnvoyPatchPolicy this is very manual, and not sustainable.
(See: https://github.com/kubernetes-sigs/llm-instance-gateway/pull/18)
We're trying to settle on a single implementation that this project will work on to extend to support LLMServerPool as a Gateway API backend. This will enable us to run e2e tests against these concepts and iterate more quickly. That implementation should be:

An existing conformant implementation of Gateway API
Part of CNCF
Envoy-based for simplicity of extension mechanisms
Open to contributions from us to support this new type of backend

We propose extending existing this gateway implementation to act as the controller for the LLMServerPool object. (See: https://github.com/kubernetes-sigs/llm-instance-gateway/blob/main/docs/proposals/002-api-proposal/proposal.md#llmserverpool). As well as updating HTTPRoute to support a LLMServerPool as a backendRef.
At a high level we expect this to look like:

Upon creation of an LLMServerPool the controller creates: An ext-proc deployment/service. An original_dst cluster.
Upon creation of an HTTPRoute with an LLMServerPool as a backendRef: A Listener that routes requests to the appropriate original_dst cluster (there may be multiple LLMServerPools), and configure ext_proc to operate on requests sent to this cluster

hey @kfswain ive created https://github.com/envoyproxy/gateway/issues/4423 to make a decision on supporting this in Envoy Gateway


bug: How to set mode="ios" or mode="md" for page navigation?

Hi,
Could you provide an example for page navigation to set custom mode option?
this.navController.navigateForward('/tabs/tab4/disclaimer');
this.navController.navigateBack('/tabs/tab4');

Thanks for the issue. The recommended way to set mode is via the global app config: https://ionicframework.com/docs/angular/config. From there, you can set the mode to be ios or md.
In the next major release of Ionic Framework you will also be able to set mode on a component such as ion-content and have each child component inherit that specific mode. For more information on this change in the next major version of Ionic Framework, please see: https://github.com/ionic-team/ionic/blob/master/BREAKING.md#mode

Thanks for your reply. I am expecting mode option for the below APIs
this.navController.navigateForward
this.navController.navigateBack
This will provide me flexibility to set ios transition for android devices using navController API.
Could you please provide solution on this?

Is this for an Ionic 3 application? NavController does not exist in Ionic 4+ anymore.

Hi ,
I am using ionic 4 for my application. The below mentioned APIs are working in ionic 4
this.navController.navigateForward
this.navController.navigateBack
How to do navigation programatically using ionic 4 using API with mode option?
Please provide solution.

As per the docs, you can provide a custom animation in navAnimation: https://ionicframework.com/docs/angular/config. You can either a) provide a separate animation per mode, or b) add some logic inside of your animation that changes depending on the mode.
It is not recommended that you set the animation when doing navigateForward or navigateBack. For follow up questions, I recommend asking your question on our forums as this is really more of a support question.


[Feature Request] [SuperPins] Option to remove "reset pinned tab" icon

The option to make pinned tabs look like essentials works great...

However, when hovering to click on them the "reset pinned tab" arrow icon takes roughly 50% of the space of the button, making it 50/50 chance to either go to the pinned tab (desired outcome) or accidentally resetting the pinned tab (frustrating when not intended).

Having an extra checkbox in the mod settings to remove this on-hover icon would be great considering the feature itself is still available anyway if you right-click the pinned tab

Hi I have submitted a PR #67 to add this capability. In the meantime anyone can just disable them by doing below:

Follow the steps to enable userChrome.css file (you have to restart the browser once the file is there): https://docs.zen-browser.app/guides/live-editing
Add this to your userChrome.css

#vertical-pinned-tabs-container .tab-reset-button {
    display: none !important;
}

Thanks for the pr, will add it to the store asap

Thank you both, new update works as expected! Feel free to mark this one done, happy holidays!

Thank you both, new update works as expected! Feel free to mark this one done, happy holidays!


Increase coin denom maxsize in order to support transactions with IBC tokens

Description
Currently, signing any transaction with an ibc token results in unrecognized error code due to the current coin denom maxsize validation of 50 characters including the null byte.
IBC denoms, such as ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2, are 68 characters in length, and the cosmos-sdk supports denominations up to 128 characters in length.
⚠ This is currently blocking ledger users that have updated to the latest app version from managing their IBC funds on all cosmos chains that use app.
Changes
This PR adds a failing test with an example transaction containing an ibc denom, and then increases the denom max length to 129 (128 characters + null byte) to pass the test.
Testing
make cpp_test and make zemu_test both passed locally.
I also used make load and tested I was able to successfully sign transactions with ibc denoms on the command line and from the browser with this PR.

hi @jleni any chance this can be looked at?  We are seeing more users updating and then being unable to manage their IBC token positions.
I'm also happy to add a test case to the zemu test suite -- do you generally write a separate script to create the initial snapshots?  Or is there a flag that can be set to update them during the the test run?


MERGE PRs

@AyushSingh22 @Jaideep25-tech PRs would be accepted till JUNE 2nd night. Please merge the PRs. For PROOF, Please visit GSSoC Discord channel.
Please merge my PRs with proper labels

@Jaideep25-tech @AyushSingh22 Please review my PRs


File removed in before_destroy is missing if destroy fails and rolls back

If a model destroy action fails and the database rolls back the transaction, the before_destroy callback has already removed the file, leaving the model data and file datastore in an inconsistent state.
Could this be fixed by changing the callback to after_destroy?

potentially yes. what's an example of destroy failing? (so I can add a test)

We have a model with a has_many relation with a database foreign_key constraint (Postgres in our case). On our model has_many association we have dependent: :restrict_with_error which handles catching the dependent error apparently before the destroy happens. To cause this issue, you can remove the dependent: option altogether, and let the database constraint cause a failure and rollback.
Thanks

Hi, I also came across this situation. Is there any forecast for an update that includes this change?
Thanks.

released in version 1.1.5 - cheers

Actually after_destroy is called before commit. As @rlow said, before_destroy is not safe and removing dependent will call destroy_dragonfly_attachments before DELETE. But this is not related with any transaction, SQL fails just because foreign key constraint's fails, not because a COMMIT. The real issue is when you start a transaction, calls destroy then rollback it. Example:
class Foo < ApplicationRecord
  dragonfly_accessor :bar
end

f = Foo.create(bar: File.new('some.blob'))
Foo.transation do
  f.destroy
  raise ActiveRecord::Rollback
end

# Ooops! There is no more file :'(


⚠ Bofrost.es has degraded performance

In 93fa232, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1605 ms

Resolved: Bofrost.es performance has improved in 4356d9f.


Don't add false as a mine.

This prevents the duplicate mining bug.

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

5
0
0
5

Vote Breakdown

User
Yes
No
Abstain

tedivm
✔

dragoonreas
✔

ViezeVingertjes
✔

ButAds
✔

PostCrafter
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Consider adding a means to turn on default lints with an analysis option.

The analyzer supports a default set of lints with the --lints flag.  We should consider a means to flip this bit with .analysis_options as well.  (See https://github.com/flutter/flutter/pull/5573 for discussion.)

FWIW, I think support for lint groups is the better way to do this. We could have a single solution that would satisfy all of the known use cases instead of multiple solutions that overlap and conflict. The --lint option could be extended to take a group, and if none is given could default to the "default" group.

Closing in favor of ongoing discussions of "meta-lints": https://github.com/dart-lang/linter/issues/288


[deploy] Display expiration date of the chosen key

Is your feature request related to a problem? Please describe.
Deployment to Maven Central requires a valid PGP key.
Describe the solution you'd like
Fail deployment when the signing key is no longer valid, warn when running in dryrun mode.
Describe alternatives you've considered
None.
Additional context
Recently encountered a couple of builds whose deployment failed because of expired keys.

🎉 This issue has been resolved in v1.15.0 (Release Notes)


DUP SMS feature-> Issue with the phone number field validation

Scenario:

Navigate to the DUP public on TEST environment: https://d2yc82svj0l8d5.cloudfront.net/dayuse/
Select a park and a facility, then try to book a pass
Check the option to receive the SMS reminder
In the field to add the phone number try copying and pasting an invalid phone number (eg:<PHONE_NUMBER>1234)
Try to submit the form.
Similarly try to copy and paste alphabetical letters into the field.

Issue:

The phone number won't get validated when you add an invalid entry by copy/paste method.
It is possible to copy/paste characters into the field but it later get validated.

Expected:

The users should not be able to submit the form with an invalid phone number.
The field should not allow pasting invalid characters.

https://github.com/bcgov/parks-reso-public/assets/65190263/b8e8c1aa-505f-44a9-8bdd-1d48501aacc5

I am wondering what should happen if a user pastes in a number longer than accepted, will it be rejected (nothing pasted to field) or will the first 10 digits be accepted and the rest ignored? @manuji

Hi @ndelraye , will you be able to advise us on the best solution for this issue in terms of UX.

Are we accepting international phone numbers? If so, some will be longer than 10 digits. I believe 15 digits is the max.
In general I would suggest if the number doesn't match the expected format, you would display an error. In the case of pasting a too long number, I would expect it to paste into the field and trigger an error.
Grab me on teams if you want to chat further about this.

By the way, just dropping this in-depth phone number UI design article here in case we want to reference it later: https://evilmartians.com/chronicles/phone-inputs-and-you-the-designers-essential-ui-guide

@janemoxd
We are not accepting international phone numbers for initial release of this feature. I will look into allowing users to paste numbers longer than accepted but flagging the input.  Thanks

@Christopher-walsh22 can you also create anew ticket under this repo for adding international numbers and assign it to me?

GC notify will allow it for this season with us in the pilot phase of their SMS service and we can report how many international numbers we collected over the next couple months and share with them.

@Christopher-walsh22 I was just looking through the public side of this and I think if we are not currently using international numbers we need to have the 1+ in there somewhere or enable the longer phone numbers, because sometime might try to type in 1-250-555-1245.
I will update AC of this ticket to show an error when too many numbers are added to the phone number field (like the email validation) and to either show 1 at the start or enable up to 15 numbers.

@JLWade The international numbers ticket would handle the country code in its own way. If we want to add the (1-) prior to I would suggest we make a separate ticket, it would be pretty small and quick to complete but would different work than adding the international feature.
Another thing I have found is pasting into a validated field is bringing a few more bugs along with it. I have been looking at the "Confirm Email" input section (The other validated field in this form) and pasting into that is prevented. I think that is the appropriate solution for this field as well. This will also stop users from exceeding maximum length and adding invalid characters.

@manuji  I have just had a conversation with @JLWade about removing the ability of pasting into the number field. That solution will address the problems you have highlighted. I will have a the fix over to you very shortly!

Tested on TEST: passed

Verified that this issue has been fixed.


Only import ballerina/constraint is removed when generating with --nullable

Description:

Ideally, it should also remove all places where it uses import ballerina/constraint.
Steps to reproduce:
Generate stripe connector with. --nullable
Try to build it.
Output
Compiling source
        ballerinax/stripe:1.4.0
ERROR [types.bal:(19:1,19:37)] undefined annotation 'String'
ERROR [types.bal:(19:1,19:37)] undefined module 'constraint'
ERROR [types.bal:(22:1,22:37)] undefined annotation 'String'
ERROR [types.bal:(22:1,22:37)] undefined module 'constraint'
...

(Note: Left side - Generated without --nullable)
Solution
It should remove @constraint:String {maxLength: 5000} part too

Related issue
Generate powertoolsdeveloper.collections using openapi.yml
Try to compile...
It gives an error like this on complication
Compiling source
        ballerinax/powertoolsdeveloper.collections:1.4.0
ERROR [types.bal:(18:18,18:28)] unused module prefix 'constraint'


support &Bound<PyType> for classmethod

Build on stream this morning; there's a little bit of tidy up to do later.
This solves https://github.com/PyO3/pyo3/pull/3705#discussion_r1443763530 by introducing some helper functions in impl_/pymethods.rs

👍 Note that a large part of this was split into #3831

Rest is now in #3897. Thanks @LilyFoote!


[MM-53015] Allow the user_agent field to be included in context

Summary

When the InvokeCall method is executed, AppContext is assigned an expanded context.
https://github.com/mattermost/mattermost-plugin-apps/blob/89a1e4c1fd9e784a52129266e7021b72fc813100/server/proxy/invoke_call.go#L185-L190
I found that the user_agent field disappears because expandContext method initializes the UserAgentContext when it runs.
I changed the user_agent and track_as_submit fields to keep their original values on initialization.
https://github.com/mattermost/mattermost-plugin-apps/blob/89a1e4c1fd9e784a52129266e7021b72fc813100/server/proxy/expand.go#L216-L217
Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/23621
JIRA https://mattermost.atlassian.net/browse/MM-53015

Hello @kyeongsoosoo,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (89a1e4c) 20.12% compared to head (4b7e412) 20.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   20.12%   20.16%   +0.03%
==========================================
  Files          80       80
  Lines        6609     6612       +3
==========================================
+ Hits         1330     1333       +3
  Misses       5147     5147
  Partials      132      132

Files Changed
Coverage Δ

server/proxy/expand.go
46.01% <100.00%> (+0.41%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/update-branch

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


Feature request: State/Province Abbreviations

Thank you for the great script. One feature that would be very useful is to be able to optionally use state/province 2-letter abbreviations as values in the region selector.

Agreed, that would be very nice. Good suggestion.

:+1:

Problem about this one is that I don't think all country regions are able to be reduced to a 2-char abbreviations. But perhaps just an "abbreviate" option that limits them to whatever abbreviation is appropriate, according to the country.

@benkeen Sounds like a sound idea to me, or perhaps 'alpha-2-code' or 'code' option would be a bit more explicit.

Do you have a plan for how to approach this? We could get a spreadsheet of region codes for each country perhaps... Or use the wiki.

How about this? https://github.com/benkeen/country-region-selector/blob/master/source/data-with-abbrev.js#L47
It's super simple: right now the | separator is used to delimit the list of regions in a country; I just added a secondary ~ delimiter to delimit the region and the region abbreviation. That'll keep the data set as small as possible and work for any country.
If people are willing to do the (tedious!) task of updating that file, I can update the code to support it...
[I can help out, too - but it may take some time for me to get to it].

Works great for me! I care most about US/AU/NZ/GB/BR/NO and a couple others, so I should be able to track down the data, then I'll fill in any others I can find easily. Hopefully @iapparatus will contribute some codes too and we can fill it out quickly. :+1:

Nice, thanks @sventech!

The regions we have for American Samoa are those from the tourist info, but the Wikipedia page lists these counties:
Ituau~01|Ma'oputasi~02|Sa'Ole~03|Sua~04|Vaifanua~05|Alataua~06|Fofo~07|Leasina~08|Tualatai~09|Tualauta~10|Faleasao~11|Fitiuta~12|Ofu~13|Olosega~14|Ta'ū~15|Rose Atoll~21|Swains Island~22

you can hook up data from my fork guys, i changed some core functionality (defaulting to abbr data and such) and the regions/countries are a bit different, more ISOish i guess, so i didn't want to create a pull request. I will be using my modified version for my own needs - so feel free to pull my changes if you need to.
https://github.com/sQu1rr/country-region-selector/blob/master/source/data-with-abbrev.js

This will be a great enhancement. Has code been written to support it? All I see is the data.

I think Ben is planning to implement it when the data is finished. He designed the data format to be handled by a trivial mod to his code, from what I understand.

Thanks for everyone whose chimed in - and for the pull requests! :) Clearly there's interest in this feature, so I'll work on this shortly, even though all the data isn't fully available yet.

I'll add a big proviso saying "currently only supports X,Y,Z countries" which we'll update as the data gets added.
if the shortcode region doesn't exist for a country but the user requests it, output a console.warn() saying as much and downgrade to the full region name.

I think between those two, it'll be okay to implement now without the full data set.

That would be great. The second bullet, in particular, is how I imagined the feature would work.

Hi all, I've just added this. Couple of quick comments:

You can see how it works in Example 8 here: http://benkeen.github.io/country-region-selector/ (also see examples 6 & 7 for the whitelist and blacklist options, respectively).
I've now deleted the data-with-abbrev.js file - all future updates to add abbreviations can be made right to the data file itself: https://github.com/benkeen/country-region-selector/blob/master/source/data.js
I decided not to output a console.warn if the condition where the developer had specified data-value="shortcode" and the user selected a country whose regions didn't have a shortcode... seemed wrong somehow.

Let me know if anyone spots any problems! I'll leave this issue open a little while before closing it.

Norway's listing has the name and abbreviation twice. Probably my fault. I won't get to fix that right away but if nobody else does I will get to it.

This is working great, Thank you so much! One small change that should probably be made to the README file. If you are using the data-value="shortcode" option, then the data-default-value for region needs to be the abbreviation, not the full name. So the data-default-value definition should read something like this:
data-default-value - optional. The default selected value in the region dropdown (e.g. "British Columbia", or "BC" if using the data-value="shortcode" option)
I apologizing for not implementing this myself, but I'm not very git-literate (I'm working on it!).

Ah, good call! I'll make a note to update the doc tonight.

Since this new version with the region abbreviations was posted, I'm having trouble adding a customization I had working in the previous version. I'm using this in conjuction with another function that requires the 2 letter country code as a parameter. When the country under crs is changed, I want to populate the region fields, but I also want to fire this other script. In the older version of crs, I put my function within $(this).on("change", function() {_populateRegionFields... and it worked perfectly. But when I try to do this in the new version it doesn't fire. Even an alert() isn't triggered, although it was in the older version. What am I missing?
Relatedly, I stupidly didn't save my customized old version and now I can't figure out how to grab the 2 letter country code for the selected country. Can someone help me with that as well? I don't want to use the country shortcode option when I trigger crs; I just want to grab the selected country shortcode from within the crs script when the selected country changes.
Thanks.

To be more clear, if I change the code,
$(this).on("change", function() {
_populateRegionFields(countryElement, regionElement);
});

to

$(this).on("change", function() {
_populateRegionFields(countryElement, regionElement);
alert('Hello!');
});

The list of regions does correctly change when the country changes, but the alert doesn't fire. It did fire under the older version from last week.

Hey @wobblymusic! Hmm... I can't think of anything that would affect that change. But do you need to modify the script at all? Might be better to just add your own JS so it won't get overwritten with future upgrades.
e.g. just add some JS in your page like $(".your-selector-here").on("change", function() { ... });. That should work... I'm not canceling the event, so it should get called on the onChange event. There, you could do whatever you want.
To get the value with jQuery, you can do this:
$(".your-selector-here").on("change", function() {
   console.log("my value is: ", this.value);
   console.log("or using jQuery... ", $(this).val());
});

Hope this helps a bit.

Hi Ben. The problem is that I want to grab the two letter country abbreviation for my other function, but I want crs to give me the full country name in its selector. How can I grab the two-letter abbreviation outside of crs.js when it's not $(this).val() ?

Ah, I see... Drat. Yes, you're kind of stuck with hacking it in that case. Maybe the least unobtrusive hack would be to edit it to output an extra data-shortcode attribute on the options. Then you could do your own JS to just extract that value...
<option value="full region name here" data-shortcode="shortcode here">full region name here</option>

If you're really stuck, email me what you have and I can see if I can edit it this weekend<EMAIL_ADDRESS>

Good to hear! Thanks for the follow-up. :)

N.B. on this issue. I thought I'd implement a React version of the country-region-selector script, so will be moving the data source to a separate location in a different format. See: https://github.com/benkeen/country-region-data
That way I'll be able to pull that data source into whatever scripts I need and manipulate it into an appropriate format for packaging.

That seems like a good idea. It also makes it easier for other projects, such as Zippopotam.us to use the data (although I suppose there might be license issues, since they use the OpenData license).


go checksum mismatch on minikube

/kind bug

What versions of software are you using?
Operating System:
Fedora 32 (running minikube)
Output of odo version:
main
How did you run odo exactly?
++ make bin

[ssh:Fedora 32] verifying<EMAIL_ADDRESS>checksum mismatch

[ssh:Fedora 32] 	downloaded: h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=

[ssh:Fedora 32] 	go.sum:     h1:ahVqZF4n1W4NqwvVnZzC4es67xsW9uR/RRf2RRxieJU=

[ssh:Fedora 32]

[ssh:Fedora 32] SECURITY ERROR

[ssh:Fedora 32] This download does NOT match an earlier download recorded in go.sum.

[ssh:Fedora 32] The bits may have been replaced on the origin server, or an attacker may

[ssh:Fedora 32] have intercepted the download attempt.

[ssh:Fedora 32]

[ssh:Fedora 32] For more information, see 'go help module-auth'.

Actual behavior
Expected behavior
Any logs, error output, etc?
Minikube job running on psi has this issue https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4722/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1394141688028467200#1:build-log.txt%3A219

Switching to long running VM https://github.com/openshift/odo/issues/4675#issuecomment-832445271 resolves the issue https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4658/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1394254608859140096
/close

We are still facing the same issue with golang 1.14 on fedora.


npm install failed

npm ERR! code ECONNRESET
npm ERR! errno ECONNRESET
npm ERR! network request to https://repo.geodan.io/repository/npm/mapbox-gl failed, reason: socket hang up
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
npm ERR!      C:\Users\wbz\AppData\Roaming\npm-cache_logs\2020-06-27T14_17_15_655Z-debug.log

Sorry, currently this library is not available on the public npm server. You can still install it from this git repo though.


Derived RepresentableK should proxy all methods including implemented

The current implementation in HigherKindedMacros only proxies unimplemented methods. Because of this, the behavior of the class may change when wrapping it in Embed:
import tofu._
import tofu.higherKind._

trait Service[F[_]] {
  def defaultValue: F[String]
  def value: F[String] = defaultValue
}

object Service {
  implicit val representableK: RepresentableK[Service] = derived.genRepresentableK[Service]
}

final class ServiceImpl extends Service[Option] {
  override def defaultValue: Option[String] = None
  override def value: Option[String] = Some("value")
}

val impl = new ServiceImpl()
impl.value // Some("value")

val embedded = Embed.of[Service, Option](Some(impl))
embedded.value // None

https://scastie.scala-lang.org/qyV8mImjQTGuw65bOPa5xw

This affects Loggable in tofu-0.9.0: when logging through slf4j, all exceptions are wrapped in LoggedThrowable.
https://scastie.scala-lang.org/Hc8loyy3R6O1mVW5UcauxQ

This affects Loggable in tofu-0.9.0: when logging through slf4j, all exceptions are wrapped in LoggedThrowable.
https://scastie.scala-lang.org/Hc8loyy3R6O1mVW5UcauxQ

When I did #424 I was in the delirium of brainfever. Why did nobody stop me?

When I did #424 I was in the delirium of brainfever. Why did nobody stop me?


KHD stopped working after upgrading to 1.1.2

I have the following config in my .khdrc previous and it is working fine.
It opens a new chrome tab with ctrl-t in chrome.
lctrl - t   [Google Chrome]  : khd -p "cmd - t"
However, after upgrading to 1.1.2 it stopped working.
I have rebooted my mac and reinstalled khd and it is still not working.
From /tmp/khd.out, every time I press ctrl + t when the focus is on chrome, the following is printed:
Token_Modifier: cmd
Token_Literal: t
I tried to run khd -p "cmd - t" from iTerm2, and it printed the same thing and opens up
a new iTerm tab, which seems to indicate khd is functioning fine.
Please advice how I can debug?
Thanks!

Also, I have another hotkey defined as follows:
lctrl - l [Google Chrome] : khd -p "cmd - l"
After pressing ctrl + l, instead of having the focus go to the chrome url input box, it triggers a shortcut I defined using automator (ctrl + cmd + l)

Am I correct in assuming that you are running MacOS Sierra?
I'm unable to reproduce this issue, but that makes sense as I am on El Capitan.
I believe this is actually an issue caused by #40 (which was necessary for Sierra) to work at all.

This fixes the issue for me and also keeps system shortcut working.
diff --git a/src/hotkey.cpp b/src/hotkey.cpp
index 4ee5d80..7242446 100644
--- a/src/hotkey.cpp
+++ b/src/hotkey.cpp
@@ -572,7 +572,21 @@ CreateAndPostKeyEvent(CGEventFlags Flags, CGKeyCode Key, bool Pressed)

     if(IsMacOSSierraOrNewer())
     {
-        Flags |= CGEventGetFlags(KeyEvent);
+        CGEventFlags EventFlags = CGEventGetFlags(KeyEvent);
+        EventFlags &= ~Event_Mask_Cmd;
+        EventFlags &= ~Event_Mask_LCmd;
+        EventFlags &= ~Event_Mask_RCmd;
+        EventFlags &= ~Event_Mask_Shift;
+        EventFlags &= ~Event_Mask_LShift;
+        EventFlags &= ~Event_Mask_RShift;
+        EventFlags &= ~Event_Mask_Alt;
+        EventFlags &= ~Event_Mask_LAlt;
+        EventFlags &= ~Event_Mask_RAlt;
+        EventFlags &= ~Event_Mask_Control;
+        EventFlags &= ~Event_Mask_LControl;
+        EventFlags &= ~Event_Mask_RControl;
+
+        Flags |= EventFlags;
     }

     CGEventSetFlags(KeyEvent, Flags);

A more elegant way would be to know what modifiers were used to trigger an event and clear only those, but this also solves the issue.

@koekeishiya yes, I am using sierra

@koekeishiya I suppose that this also solves incompatibility of the previous change with El Capitan

I suppose that this also solves incompatibility of the previous change with El Capitan

I think that is the case, would any of you mind trying this patch:
https://gist.github.com/koekeishiya/c540c959dc110be15d58464a4f162b1a

I can confirm the patch works

A more elegant way would be to know what modifiers were used to trigger an event and clear only those, but this also solves the issue.

Indeed that would be true, but as the khd -p happens in a newly created process, it has no information regarding the existing modifier state, and it would be more expensive to detect this instead of just performing a clear for every flag.
I suspect this won't be much trouble, as it should be faster to clear these flags than it was to check for the OS version.

Patch has been applied and v1.1.3 released.


rmi -f inconsistent with docker

Description
TestRemoveRunningImage comments are outlining the issue.
rmi -f an image with a running container will fail with nerdctl, while it will succeed with docker (and untag the image).
Steps to reproduce the issue
na
Describe the results you received and expected
na
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Hi, team
I'd like to work on this issue, so could you assing to me?

Tagging @AkihiroSuda for that ^.


Compatibility with PHP 7 and Symfony 3 / Allow norkunas/onesignal-php-api fixs

Just update composer.json to:

Make it compatible with PHP 7 and Symfony 3.
Allow norkunas/onesignal-php-api fixs

Thank you


Cannot start BigchainDB in a 3 node cluster installation

BigchainDB version: 1.3.0

Operating System: Linux 10-1-0-6 4.4.0-109-generic

Deployment Type: Host

Cluster of 3 nodes

Description
BigchainDB was working before with 3 nodes. In the logs of BigchainDB I could see that a lot of transactions were posted, then I tried to insert some others, but I did not received any response from BigchainDB likely because the node collapsed due to a huge amount of transactions coming in.
Then I restarted the node, but I could not start it again. I get the following error:
Steps to Reproduce
Install BigchainDB, share keypairing among the 3 different nodes, and try to start BigchainDB.
What I Did
sudo bigchaindb start

INFO:bigchaindb.config_utils:Configuration loaded from `/home/manuel/.bigchaindb`
[2018-01-29 04:14:49] [INFO] (bigchaindb.commands.bigchaindb) BigchainDB Version 1.3.0 (MainProcess - pid: 2160)
[2018-01-29 04:14:49] [INFO] (bigchaindb.commands.bigchaindb) Initializing database (MainProcess - pid: 2160)
[2018-01-29 04:14:49] [INFO] (bigchaindb.backend.mongodb.connection) Closing initial connection to MongoDB (MainProcess - pid: 2160)
[2018-01-29 04:14:49] [INFO] (bigchaindb.commands.bigchaindb) Starting BigchainDB main process with public key CSAsm8wxcdHoqCNVKxAdMLLiTRp1s3iK6mb2pmAK9rEs (MainProcess - pid: 2160)
[2018-01-29 04:14:49] [INFO] (bigchaindb.processes) Initializing BigchainDB... (MainProcess - pid: 2160)
[2018-01-29 04:14:49] [INFO] (bigchaindb.processes) Starting block (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.processes) Starting voter (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.backend.mongodb.connection) Closing initial connection to MongoDB (Process-8  - pid: 2178)
[2018-01-29 04:14:50] [INFO] (bigchaindb.backend.mongodb.connection) Closing initial connection to MongoDB (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.backend.mongodb.connection) Closing initial connection to MongoDB (Process-8  - pid: 2178)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
de4ee6e4fab4c666aacc313bf968e6e29cc0c389cce27d71132411dc1f09a89c
 (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
5996e0bdb5f36fa359d8423c7ffbbd5fbceba3a35986eb5a3a927f189761ebda
 (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
df75f3c1a864db5561b68fc5358b0dc6fee096dfab7d1343f1026ea4a03801a8
 (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.backend.mongodb.connection) Closing initial connection to MongoDB (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
de4ee6e4fab4c666aacc313bf968e6e29cc0c389cce27d71132411dc1f09a89c
 (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
5996e0bdb5f36fa359d8423c7ffbbd5fbceba3a35986eb5a3a927f189761ebda
 (MainProcess - pid: 2160)
[2018-01-29 04:14:50] [INFO] (bigchaindb.common.transaction) transaction::validate_id txn_id
df75f3c1a864db5561b68fc5358b0dc6fee096dfab7d1343f1026ea4a03801a8
 (MainProcess - pid: 2160)
Traceback (most recent call last):
  File "/usr/local/bin/bigchaindb", line 11, in <module>
    load_entry_point('BigchainDB==1.3.0', 'console_scripts', 'bigchaindb')()
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/commands/bigchaindb.py", line 356, in main
    utils.start(create_parser(), sys.argv[1:], globals())
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/commands/utils.py", line 206, in start
    return func(args)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/commands/utils.py", line 51, in configure
    command(args)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/commands/utils.py", line 78, in start_logging
    command(args)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/commands/bigchaindb.py", line 209, in run_start
    processes.start()
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/processes.py", line 57, in start
    vote.start()
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/pipelines/vote.py", line 184, in start
    pipeline.setup(indata=get_changefeed())
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/pipelines/vote.py", line 176, in get_changefeed
    feed = backend.query.get_new_blocks_feed(b.connection, last_block_id)
  File "/usr/lib/python3.5/functools.py", line 743, in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/backend/mongodb/query.py", line 362, in get_new_blocks_feed
    last_ts = conn.run(query)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/backend/mongodb/connection.py", line 62, in run
    return query.run(self.conn)
  File "/usr/local/lib/python3.5/dist-packages/bigchaindb/utils.py", line 175, in run
    last = last(*item[0], **item[1])
  File "/usr/local/lib/python3.5/dist-packages/pymongo/cursor.py", line 1140, in next
    raise StopIteration
StopIteration

Usually transactions are put in a block every second, or every 1000 transactions, whatever comes first. Depending on your setup, pushing 400 transactions to a single node might take few seconds, so you should not reach the 16MB MongoDB limit.

[...] but the asset ids cannot be retrieved (404 - not found) after the load completes.

This is a bug we need to fix. We can easily write a test case for that.

What is the status of this?

The way that one sets up a multi-node cluster is quite different in BigchainDB 2.0+ so I'm closing this issue.


Support for Packed Sequence Dataset

What does this PR do ?
Adding support for Packed Sequence Dataset for SFT. NeMo supports SFT/PEFT with packed sequences, but this support is missing in NeMo-Aligner. This PR aims to add support for SFT with packed sequences in NeMo-Aligner.
Changelog

Please update the CHANGELOG.md under next version with high level changes in this PR.

[ ] Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials

Checklist when contributing a new algorithm

[ ] Does the trainer resume and restore model state all states?
[ ] Does the trainer support all parallelism techniques(PP, TP, DP)?
[ ] Does the trainer support max_steps=-1 and validation?
[ ] Does the trainer only call APIs defined in alignable_interface.py?
[ ] Does the trainer have proper logging?

Additional Information

Related to https://github.com/NVIDIA/NeMo-Aligner/issues/181

Hi @RadhaGulhane13, thanks a lot for the contribution! I've opened a new PR https://github.com/NVIDIA/NeMo-Aligner/pull/275 which adds some documentation and makes a minor bug fix on top of your changes. I'll close this PR.


fix(specs): usage api

🧭 What and Why
Update of the Usage API spec.
Unfortunately, I can't test the Usage API (can't make any requests) so I can't independently verify the information like I did for the other APIs, so I only did a few style updates.
Changes included:

Use an enum for the {statistics} parameter
Increased reuse of existing schemas.

nice my fix worked :D


Missing X button.

There is a missing X button on newsflow when viewing it on dashboard. I'm really confused.


feat: use JSON RPC for inbound tx observation (including blob tx in Decun upgrade)

Description

Some necessary code refactor on inbound observation and inbound tracker processing.
Uses JSON RPC for inbound tx observation and tracker processing.
Added unit tests for above changes.

Closes: 1755
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

[x] Tested CCTX in localnet
[ ] Tested in development environment
[x] Go unit tests
[ ] Go integration tests
[ ] Tested via GitHub Actions

Checklist:

[x] I have added unit tests that prove my fix feature works

It looks good to me. Wondering if we could consider testing it on local E2E test before moving to production.

It's a good idea. I created a ticket for this as the 1st step: https://github.com/zeta-chain/node/issues/1856


Misc Convenience Helpers

This is a handful of feature I found helpful in my own code using JRL. Figured I'd share if you think it's worthwhile having in the main codebase. These include:

addGroundTruth and addInitialization functions in DatasetBuilder. This allows for setting these independently since they're not saved in the Entry anyways.
Custom parsers/serializers support. There was a stub that needed filling out for this and it just took a couple lines of code. Also added tests for it.
filtering/removing certain measurement types from Entry. For my purposes, I added all my wheel factors to a single jrl file, then used the filter functionality to only run on the one I was interested in. Tests also included.

Let me know what you think! Happy to split this up however if you're interested in some features, but not others.

Using a predicate function is a great idea - I'll definitely rewrite it in that form, shouldn't be too hard. I'll tweak the tests as I do that as well.

K, just made those changes, give it another look when you get the chance,

Updated parse and serialize measurement/values functions to be public, updated test to use those instead of file
Made filtered function, along with KeepTypes and RemoveTypes static methods in Entry
Ran clang-format

Made that tweak and merged from main, I think it should be good now.