Monsoon Wang plots on the fly

@acordonez when you get a chance, could you please run demo 2a with the PR to see if it run smoothly?

@lee1043 I'm getting this error on the first run in Notebook 2a. I am using this branch and reran Demo 0 to regenerate the parameter files first.
>>>monsoon_wang_driver.py -p basic_monsoon_wang_param.py
/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/pcmdi_metrics/utils/string_constructor.py:43: UserWarning: Keyword 'model' not provided for filling the template.
  warnings.warn(f"Keyword '{k}' not provided for filling the template.")

modelFile =   demo_data_tmp/CMIP5_demo_clims/cmip5.historical.CanCM4.r1i1p1.mon.pr.198101-200512.AC.v20200426.nc
dom =   AllMW

Traceback (most recent call last):
  File "/home/ordonez4/miniconda3/envs/pmp_dev/bin/monsoon_wang_driver.py", line 245, in <module>
    monsoon_wang_runner(args)
  File "/home/ordonez4/miniconda3/envs/pmp_dev/bin/monsoon_wang_driver.py", line 174, in monsoon_wang_runner
    ds_out = xr.Dataset(
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/xarray/core/dataset.py", line 685, in __init__
    variables, coord_names, dims, indexes, _ = merge_data_and_coords(
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/xarray/core/dataset.py", line 416, in merge_data_and_coords
    return merge_core(
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/xarray/core/merge.py", line 719, in merge_core
    variables, out_indexes = merge_collected(
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/xarray/core/merge.py", line 290, in merge_collected
    merged_vars[name] = unique_variable(
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/xarray/core/merge.py", line 144, in unique_variable
    raise MergeError(
xarray.core.merge.MergeError: conflicting values for variable 'time' on objects to be combined. You can skip this check by specifying compat='override'.
[WARNING] yaksa: 10 leaked handle pool objects

@lee1043 Realized I was using an old environment and needed to update xcdat. But now I am seeing this issue. I am using numpy version 2.0.2 - what version of numpy should I be testing this with?
Traceback (most recent call last):
  File "/home/ordonez4/miniconda3/envs/pmp_dev/bin/monsoon_wang_driver.py", line 10, in <module>
    import pcmdi_metrics
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/pcmdi_metrics/__init__.py", line 17, in <module>
    from . import io
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/pcmdi_metrics/io/__init__.py", line 28, in <module>
    from .region_from_file import region_from_file
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/pcmdi_metrics/io/region_from_file.py", line 4, in <module>
    import regionmask
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/regionmask/__init__.py", line 3, in <module>
    from . import core, defined_regions
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/regionmask/defined_regions/__init__.py", line 3, in <module>
    from . import _natural_earth, _ressources
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/regionmask/defined_regions/_natural_earth.py", line 14, in <module>
    from ..core.regions import Regions
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/regionmask/core/regions.py", line 15, in <module>
    from .mask import _inject_mask_docstring, _mask_2D, _mask_3D
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/regionmask/core/mask.py", line 534, in <module>
    lon, lat, polygons, numbers, fill=np.NaN, is_unstructured=False, as_3D=False
  File "/home/ordonez4/miniconda3/envs/pmp_dev/lib/python3.10/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: `np.NaN` was removed in the NumPy 2.0 release. Use `np.nan` instead.. Did you mean: 'nan'?
[WARNING] yaksa: 10 leaked handle pool objects

@acordonez thank you for testing. Can you tell what the version of regionmask is in your env?

It looks like we have to use regionmask >= v0.11.0 according to https://github.com/regionmask/regionmask/issues/440. Could you check if this issue continues when you update regionmask version?

@acordonez In dev.yml and ci.yml, I see the dependency list that includes regionmask=0.12.1

@lee1043 Thanks, the notebook ran for me with this fix. Is there anything in particular I should look at?


AppArmor: sandbox the content rendering processes (e10s) more strictly

Once we have https://github.com/micahflee/torbrowser-launcher/pull/277, we confine these processes in exactly the same way as the parent Firefox process. They can be confined much more strictly, without impacting UX whatsoever. And while we're at it, maybe some permissions we currently grant to the parent Firefox process are not needed anymore, as it does less work.
Preliminary work lives in https://github.com/intrigeri/torbrowser-launcher/tree/apparmor-e10s. I'm using on my own system, I'll run it through the Tails automated test suite, and once I'm happy I'll submit a merge request. Testing & all kinds of help are welcome :)

Thank you! This is great. I'll review and merge #277 now.

https://github.com/micahflee/torbrowser-launcher/pull/280

The associated PRs are both merged. Closing.


build-script-build` (exit status: 1) - feature(alloc_error_handler)) - feature has been removed

Failed to build due to error:
22 | #![cfg_attr(not(feature = "std"), feature(alloc_error_handler))]
|                                           ^^^^^^^^^^^^^^^^^^^ feature has been removed
DETAILS

% cargo build --release
Compiling contracts-node-runtime v0.24.0 (~/substrate-contracts-node/runtime)
error: failed to run custom build command for contracts-node-runtime v0.24.0 (~/substrate-contracts-node/runtime)
Caused by:
process didn't exit successfully: ~/substrate-contracts-node/target/release/build/contracts-node-runtime-0ffae6dbb3dab4c3/build-script-build (exit status: 1)
--- stdout
Information that should be included in a bug report.
Executing build command: RUSTFLAGS="-C link-arg=--export-table -Clink-arg=--export=__heap_base -C link-arg=--import-memory  " SKIP_WASM_BUILD="" "~/.rustup/toolchains/nightly-x86_64-apple-darwin/bin/cargo" "rustc" "--target=wasm32-unknown-unknown" "--manifest-path=~/substrate-contracts-node/target/release/wbuild/contracts-node-runtime/Cargo.toml" "--color=always" "--profile" "release"
Using rustc version: rustc 1.71.0-nightly (7f94b314c 2023-04-23)
--- stderr
Compiling sp-io v7.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.37#946507ba)
error[E0557]: feature has been removed
--> ~/.cargo/git/checkouts/substrate-7e08433d4c370a21/946507b/primitives/io/src/lib.rs:22:43
|
22 | #![cfg_attr(not(feature = "std"), feature(alloc_error_handler))]
|                                           ^^^^^^^^^^^^^^^^^^^ feature has been removed
|
= note: now handled by panic handler
error: cannot find attribute alloc_error_handler in this scope
--> ~.cargo/git/checkouts/substrate-7e08433d4c370a21/946507b/primitives/io/src/lib.rs:1657:3
|
1657 | #[alloc_error_handler]
|   ^^^^^^^^^^^^^^^^^^^
For more information about this error, try rustc --explain E0557.
error: could not compile sp-io (lib) due to 2 previous errors

Work around to get successful build:
edited - .cargo/git/checkouts/substrate-7e08433d4c370a21/6fa7fe1/primitives/io/src/lib.rs
// commented lines (22, 1657:
22 | #![cfg_attr(not(feature = "std"), feature(alloc_error_handler))]
|                                           ^^^^^^^^^^^^^^^^^^^ feature has been removed
1657 | #[alloc_error_handler]
|   ^^^^^^^^^^^^^^^^^^^

Excellent! Thank you.


Linting

I ran the project through airbnb's eslint as I assumed that's kinda what people who don't use standard like I do use. There are about 20,000 fixable errors, and 650 warnings
Do you have a code-style preference? Happy to set up some linting if you have a style in mind.

I'm fine with Airbnb assuming there's good editor support.  Happy to take a look at this setup if you could submit a PR, perhaps we do this after merging the svelte 3 update.

I have added eslint with the Airbnb configuration.  I've included this in the test script so that it is run as part of the release process.


Binary Search returns option, however it may be useful to return nearest non-overlapping index

I need a way to determine the closest non-overlapping region in case there is no overlapping region.

Do you need the closest index, or is the closest record OK?

Either way it should probably be a separate method

I will create a pull request for my fix to this. We need the closest record, but I don't think we should change the way the current implementation works.

Sounds good. I agree with @heuermh, BTW.


Remove FactoryInterface

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
✔

Fixed issues
#101

Adopt PR: https://github.com/yiisoft/widget/pull/35
Tests pass in demo and DI.

👍


Add template entity helper

Description

Adds a new helper for creating simple template entities.
Motivation and Context

While this will not support the full blown set of features template entities can provide in YAML, it will bring basic support for template available as a helper.
Creating a small binary sensor or sensor entity from a template has never been easier.
How has this been tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Natively implemented this in Home Assistant core itself (Erik ported it during my holiday 🙏)
../Frenck


OKR Generation

This ticket follows #121, Plan for Defining CIF OKRs.
Acceptance Criteria

[ ] Design OKR session/workshop (Miro/powerpoint/both?)
[ ] Hold session to explore OKRs with CIF champions

@Peirist
Hi Taylor , Was wondering whether you got any chance to gather some OKR hypotheses from the CIF team?


Added french translation

Would you like to add your name to the CREDITS.txt file before I merge?

I did, you can now merge

I did, you can now merge

Brilliant, thank you


Updated readme

I updated the readme to give some more information. We need to decide and add a LICENSE (probably compatible with QuTiP's LICENSE).

Let's practice a simple review. It is good policy to not merge your own code changes on a project and always open Pull requests so that others can give comments.
The best practice is always to open a new PR using a fresh branch to avoid conflicts and "NEVER" working on the master. But in this case, since it is just the README, I will let myself off the hook.
Feel free to give any comments and then approve merging the changes.

Thanks @quantshah. Let's use Reviewers for review of someone else's PR, while Assignees are in charge of getting the task done (also with Issues). When one is pinged for a review, he/she can use the review tool, and add a series of comments to the PR, which then need to be addressed by the PR owner; these comments can include suggesting commits from the web interface.

@quantshah or @araza6 please update my access to the repository, so that I can also add / self assign PRs and issues, as well as adding labels.

@quantshah or @araza6 please update my access to the repository, so that I can also add / self assign PRs and issues, as well as adding labels.

Hi Nathan, you are the owner now

Thanks for the comments @nathanshammah. How do we convert a PR to draft? I would say this PR is merge-ready now.

@quantshah you have the option when opening it. Now you can also convert it, see under Reviewers on the top right. I am also fine with keeping them with "WIP: " in the title if it is simpler, and change the title then; we could do both ways.


GH-44214: [C++] JsonExtensionType equality check ignores storage type

Rationale for this change
As noted in https://github.com/apache/arrow/pull/13901#pullrequestreview-2324294761:
bool JsonExtensionType::ExtensionEquals(const ExtensionType& other) const {
  return other.extension_name() == this->extension_name();
}

This equality check does not take into account the storage type, but only the name.
As a consequence, a JsonExtensionType type will be seen as equal to JsonExtensionType<large_string>.

What changes are included in this PR?
This change introduces storage equality check into JsonExtensionType equality check.
This also fixes a storage type check in JsonExtensionType::Make.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #44214

Remaining nits

@pitrou added your changes.

@pitrou do you think you'd have time to review this for the 18.0.0 (~mid next week)?

Thanks for the review @pitrou. I addressed the comments.

Sorry for the slow turnaround @pitrou. I've pushed a change.


Make the image name unique per build

This will prevent jobs being run in parallel overriding the rancher-validation-tests image, leading to unwanted consequences (missing PEM keys, wrong branches being checked out, etc...)
To fix, we prepend the created image name with the job's name and build number, and delete after job execution.
Tested with manual cluster matrix jobs pointed to this PR.
Verified created images are cleaned up after each job is run.

LGTM


Running multiple single websites using docker (compose)

Please do not confuse this with running "WordPress Multisite". It is covered in #4
Test case

[x] Create 3 websites with EasyEngine style file layout such as /var/www/example.com, /var/www/foo.com, /var/www/bar.com, etc
[x] All websites must be publicly accessible in their own domain/subdomain. Always on port 80.

Requirements

This will need some kind of host/guest port mapping. Docker networking 💪
It might need some kind of nginx proxying from host

Issue to be closed after testing.
Multiple Sites is ready for testing. The test cases are in the description. After testing comment on this issue.

Outdated version of ee4


Ignore Error: Not Found?

Is there a way to quite this error so my build does not break?  If it doesn't find any builds for the specified time frame, it breaks my GitHub Build:

BTW I really appreciate you making this GitHub Action.

Hey, thanks for reporting. If I got it right this doesn't actually break the purpose of the action but when there's nothing to remove it fails (that is of course annoying). Could you confirm?

Yea it actually doesn't break the build I realized, so just an annoyance.

this is driving me insane, can you ignore errors so my build doesn't show failed

Same issue over here... but in my case doesn't let me to upload the artifact that I just created. (I run this step with age: 1 week and skip-recent: 10)


chore(main): release 5.0.1

:robot: I have created a release beep boop
5.0.1 (2024-11-01)
Bug Fixes

correct failed validation logic for network profile (#303) (4ecef4f)

This PR was generated with Release Please. See documentation.

🤖 Created releases:

v5.0.1

:sunflower:


Color demo with ember collection and virtual each

This PR introduces the virtual-each (React-style-each) into ember-impagination. Therefore, the impagination-collection component interface has all functionality for ember-collection and virtual-each.
The length getter was tricky and for some unknown reason has to be explicitly defined outside the create of the collection Object

IMHO, impagination-collection is better named imagination-dataset. The reason is because list and collection, for better or for worse, already have visual connotations in the Ember world. There's ember-collection, and smoke-and-mirrors has vertical-collection, horizontal-collection, and grid-collection. A name like -dataset re-enforces the idea that this is only a data provider and is not visual in any way.

Looks like the build is failing on this branch.


TM - Session - Cookies

Spartacus Threat Modelling Workshop.
Date: June 14, 2019.
Participants: Bill, Gil, Tobias, Stan, Hernando, Felix, GC
SAP Product Standard Required Compliance:
https://wiki.wdf.sap.corp/wiki/display/PSSEC/SEC-220
Threat Pattern:
Threat: These cookies should be used for authentication by this Agent. Attackers could view/steal, tamper or delete these cookies and therefore impersonate the legitimate users or view, modify or delete their confidential data.
(As informed/discussed/reported by security team during workshop)
TM Comments:

No cookies, only local storage, locked to same origin by default.

TM Required Actions:

TODO: ensure that no paths to local storage are open (messaging api).
TODO: Jesters look into setting httpOnly cookie via JS / other domain

Will be addressed in the refactoring work described here: GH-1018


Failing edge case for 3D triangle intersection.

To recreate the issue, add the following to the 3D_triangle_triangle_intersection test inside primal_intersect.cpp :
  tri3A = Triangle3( Point3::make_point(76.648, 54.6752, 15.0012),
                     Point3::make_point(76.648, 54.6752, 14.5542),
                     Point3::make_point(76.582, 54.6752, 14.7879) );

  tri3B = Triangle3( Point3::make_point(76.6252, 54.6752, 14.892),
                     Point3::make_point(76.582, 54.6752, 14.7879),
                     Point3::make_point(76.5617,54.6752,14.7929) );

  permuteCornersTest(tri3A, tri3B, "3D tris with diff permutation results",
                     false, true);

The test case fails with the following message:
Failed
Triangles should intersect but did not
	 -- 6 of 36 permutations failed when testing intersection of triangles
	 a: {(76.647999999999996,54.675199999999997,15.001200000000001) (76.647999999999996,54.675199999999997,14.5542) (76.581999999999994,54.675199999999997,14.7879)}
	 b: {(76.625200000000007,54.675199999999997,14.891999999999999) (76.581999999999994,54.675199999999997,14.7879) (76.561700000000002,54.675199999999997,14.792899999999999)}

6 of the 36 permutations of the triangle intersection return false indicating there was no intersection, 30 of the 36 permutations of the triangle intersection return true indicating there was intersection.
Expected result is all permutations of the triangles should return the same value.

I looked into this issue today.

The triangles lie in the same plane (with normal (0, 1, 0)), share a vertex (tri1[2] == tri2[1]) and one of the points of the second triangle lies inside the other triangle (up to floating point rounding):
[INFO] Triangle 1: {(76.648,54.6752,15.0012) (76.648,54.6752,14.5542) (76.582,54.6752,14.7879)}
[INFO] Triangle 2: {(76.6252,54.6752,14.892) (76.582,54.6752,14.7879) (76.5617,54.6752,14.7929)}

[INFO] t1 0 -- distance (76.648,54.6752,15.0012) to tri2: 0.11155482956824328
            -- closest point: (76.625200000000007,54.675199999999997,14.891999999999999)

[INFO] t1 1 -- distance (76.648,54.6752,14.5542) to tri2: 0.24284087382481692
            -- closest point: (76.581999999999994,54.675199999999997,14.7879)

[INFO] t1 2 -- distance (76.582,54.6752,14.7879) to tri2: 0
            -- closest point: (76.581999999999994,54.675199999999997,14.7879)

[INFO] t2 0 -- distance (76.6252,54.6752,14.892) to tri1: 0
            -- closest point: (76.625200000000007,54.675199999999997,14.891999999999999)

[INFO] t2 1 -- distance (76.582,54.6752,14.7879) to tri1: 0                            # <----- HERE
            -- closest point: (76.581999999999994,54.675199999999997,14.7879)

[INFO] t2 2 -- distance (76.5617,54.6752,14.7929) to tri1: 0.020906697491465644
            -- closest point: (76.581999999999994,54.675199999999997,14.7879)

Notes:

Meshlab doesn't flag these triangles as self-intersecting
It seems to me that this case should be marked as self-intersecting and 30 out of 36 of our permutations agree.
Modifying the EPS threshold for the intersection test didn't seem to help here.

I found it!
There was a bug in one of the 2D triangle-triangle intersection cases in the paper that defined the algorithm.

@kennyweiss awesome! great detective work!

That's awesome! Great find @kennyweiss


[BUG] all_objects returns variable name and not class name if these are different

From this refactor PR in sktime: https://github.com/sktime/sktime/pull/3777
It would appear that all_objects returns the variable name, not the class name, as the string (first tuple element) when the two are unequal.
I'm not entirely sure about the "should" here and whether that's indeed the root cause of the test failure, but it seems to be discrepant with behaviour in sktime.

@fkiraly can you confirm this was fixed by #115.

It's not released yet, is it?
Since 0.3.0 predates #115.
I've opened a version of the refactor branch with install from current skbase main branch, if the tests pass here, it should tell us whether it's fixed: https://github.com/sktime/sktime/pull/4208

@fkiraly looks like sktime/sktime#4208 is failing, but not for the same reasons as the prior test. I think they might be un-related to BaseObject, but I haven't looked to closely (seems like errors had to do with missing parameters in construction in a few estimators and a test case).

yes, indeed. I'm not sure what causes these, seems like default parameter generation.


Keep up the good work

I see I'm the first to star this repo, I just want to thank you, my raspberry is now capable to run focalboard only thanks to you and this repo. Keep up the good work!

I moved my focalboard to an amd64 instance so I can't really test whether it's working or broken now. Feel free to create a ticket in the future if there's any issues with the build.


Styling

Embed docs page via iframe
Beautify versions overview

@randombenj adding screenshots to PRs like this would be really cool :wink:


Upgrade gradle

Travis is exiting with code 137, my guess is that the build is using too much ram. Going to fiddle around more.
Update: Emailed travis, they told me to fiddle with some settings that would give us 7.5gb of memory instead of the 3gb the container base infrastructure gives.

👍

3 files (not in diff) in ...le/view/view_holders were modified. more

Misses +12

10 files (not in diff) in ...x/mobile/view/dialog were modified. more

Misses +9
Hits +2

6 files (not in diff) in ...x/mobile/view/custom were modified. more

Misses +5
Hits +15

19 files (not in diff) in ...mobile/view/adapters were modified. more

Misses +146
Hits +1

49 files (not in diff) in .../org/edx/mobile/view were modified. more

Misses +191
Hits +48

4 files (not in diff) in ...x/mobile/util/images were modified. more

Misses +11
Hits +5

12 files (not in diff) in .../org/edx/mobile/util were modified. more

Misses +15
Hits +5

2 files (not in diff) in .../org/edx/mobile/user were modified. more

Misses +2

2 files (not in diff) in ...x/mobile/third_party were modified. more

Misses +12
Hits +2

3 files (not in diff) in .../org/edx/mobile/task were modified. more

Misses +6

@@             master       #689   diff @@
==========================================
  Files           464        464
  Lines         19843      20659   +816
  Methods           0          0
  Messages          0          0
  Branches       2870       2916    +46
==========================================
+ Hits           5945       6120   +175
- Misses        13898      14539   +641
  Partials          0          0

Review [#689][cc-pull] on Codecov

Powered by Codecov. Last updated by [0bcd8c5...0913b23][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-android/compare/0bcd8c5e9cf2468aaf792679cbfadc1087dec5df...0913b23f4d2bb3c31a5cb3a7a495d190596e99b9
[cc-pull]: https://codecov.io/gh/edx/edx-app-android/pull/689?src=pr

3 files (not in diff) in ...le/view/view_holders were modified. more

Misses +12

10 files (not in diff) in ...x/mobile/view/dialog were modified. more

Misses +9
Hits +2

6 files (not in diff) in ...x/mobile/view/custom were modified. more

Misses +5
Hits +15

19 files (not in diff) in ...mobile/view/adapters were modified. more

Misses +146
Hits +1

49 files (not in diff) in .../org/edx/mobile/view were modified. more

Misses +191
Hits +48

4 files (not in diff) in ...x/mobile/util/images were modified. more

Misses +11
Hits +5

12 files (not in diff) in .../org/edx/mobile/util were modified. more

Misses +15
Hits +5

2 files (not in diff) in .../org/edx/mobile/user were modified. more

Misses +2

2 files (not in diff) in ...x/mobile/third_party were modified. more

Misses +12
Hits +2

3 files (not in diff) in .../org/edx/mobile/task were modified. more

Misses +6

@@             master       #689   diff @@
==========================================
  Files           464        464
  Lines         19843      20659   +816
  Methods           0          0
  Messages          0          0
  Branches       2870       2916    +46
==========================================
+ Hits           5945       6120   +175
- Misses        13898      14539   +641
  Partials          0          0

Review [#689][cc-pull] on Codecov

Powered by Codecov. Last updated by [0bcd8c5...0913b23][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-android/compare/0bcd8c5e9cf2468aaf792679cbfadc1087dec5df...0913b23f4d2bb3c31a5cb3a7a495d190596e99b9
[cc-pull]: https://codecov.io/gh/edx/edx-app-android/pull/689?src=pr

@bguertin Review?

:+1:

@akiva here, just wanted to let you know that you have been including me in several project tickets for EDX when I suspect you are meaning to @mention @aleffert. Have a good weekend!


Add optional -run flag to dlv test

Please add a -run flag to dlv test to mimic the behavior of the go test command. This can be achieved through a command pass through but requires memorizing the test runner flags instead of the more common go test interface.
For reference, pass through looks like this (borrowed from #422):
    dlv test --build-flags='github.com/dlsniper/u/tmp/mypack' -- -test.run ^TestHello$

Using the arg pass through trick also makes the pwd of the runner the shell's pwd, instead of go test's behavior where the pwd is the folder of the module being tested which can make flipping between dlv and go test frustrating.

I tried the above, but I keep getting the error cannot use -c flag with multiple packages.  The package I have looks like:
github.com/cyli/foo/bar - which contains tests (including the one I'm trying to run), but also another subpackage github.com/cyli/foo/bar/baz, which I'm not trying to test.
Is there some other argument I need to pass?

Closing, we will not be adding this. As mentioned above, the -test.run flag can be used when passed to the test binary.


code: use go-errors

Context
Similar to https://github.com/edgelaboratories/picsou/pull/330
Go-errors now deserves to be used in our repositories. There is not much to do in this repo but why not !
Content
Use go-error when possible.

Closing as duplicate of #64


Prevent publishing same version twice

Not sure how to implement this properly. A simple tag check maybe?

related: #1


Removing unused metrics for loadtests counting

This PR removes unused metric to count started and finished load tests. These metrics were replaced in #233 by MRunningLoadtestCountStat used to count currently running load tests.

@lucasmdrs That's exactly what I want to do in a different PR by separate task.


TypeError: argument of type 'ModelWrapper' is not iterable

Hello, when I am running backend API I receive the following exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/label_studio_ml/exceptions.py", line 39, in exception_f
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/label_studio_ml/api.py", line 66, in _train
    job = _manager.train(annotations, project, label_config, **params)
  File "/usr/local/lib/python3.7/site-packages/label_studio_ml/model.py", line 646, in train
    cls.get_or_create(project, label_config, force_reload=True, train_output=train_output)
  File "/usr/local/lib/python3.7/site-packages/label_studio_ml/model.py", line 450, in get_or_create
    if not cls.has_active_model(project) or force_reload or (cls.get(project).model_version != version and version is not None):  # noqa
  File "/usr/local/lib/python3.7/site-packages/label_studio_ml/model.py", line 426, in has_active_model
    return cls._key(project) in cls._current_model
TypeError: argument of type 'ModelWrapper' is not iterable

I have checked the code and it looks like field _current_model sometimes is set as instance of ModelWrapper rather than dictionary:
https://github.com/heartexlabs/label-studio-ml-backend/blob/054854e0bae5b5d4c1d99c68fcf1830db13bb747/label_studio_ml/model.py#L479-L486
Environment
Project version: https://github.com/heartexlabs/label-studio-ml-backend/tree/054854e0bae5b5d4c1d99c68fcf1830db13bb747

Hi, @kemics ! Could you please tell me what's the API endpoint you call in this case? and did you specify LABEL_STUDIO_ML_BACKEND_V2=true variable in the env?

Hi, @niklub
I set LABEL_STUDIO_ML_BACKEND_V2=1

what's the API endpoint you call in this case?

I just put API URL in Machine Learning settings of the project. I don't invoke backend API by my own

The problem was with Start model training after any annotations are submitted or update (more details here https://github.com/heartexlabs/label-studio-ml-backend/issues/78)
I after unchecking the settings the exception has stopped. So, I'm closing the issue

You need to compare that the two are equal, not that one is in the other.
in this file :  /home/<YOUR_USER_NAME>/anaconda3/lib/python3.8/site-packages/label_studio_ml/model.py
replace this line : return cls._key(project) in cls._current_model
to this line :
are_they_equal = cls._key(project) == cls._current_model
return are_they_equal

https://hjlabs.in


ComputeAllPlanViews() Set maximum size exceeded

Hi folks,
this is the error I get when generating the planViews(): set maxim size exceeded

I'm using the block of code used in the course for floorplan generation and it was working well in any other file except the IFC file attached with this issue:
await viewer.plans.computeAllPlanViews(model.modelID); ... viewer.edges.create("example", model.modelID, lineMaterial, baseMaterial); ...

here is the link to test the IFC file: (name: ARQ Aramburu.ifc)
https://drive.google.com/drive/folders/1nQQJVLWHGw0kLYgXPhd6MnKzCfJonYCb?usp=sharing
dependencies:
"dependencies": {
"three": "^0.135.0",
"web-ifc-viewer": "^1.0.218"
},

Hi! We'll take a look when we can, but right now we are focusing all our efforts into the components library, which is quite similar but it's much more powerful, more robust and probably the substitution of both web-ifc-viewer and web-ifc-three in the near future. Maybe you should check it out!

That's awesome @agviegas ! I thought this would be released on September. I will take a look at OBC library then.
Thanks much for pointing me to this resource!


fix: change globla registro on package lock

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add hintOverflow option for hint in inputDecoration

I'm using textfiled with Input decoration in appbar of my application. By default, if I add suffix icon in input decoration, ellipsis not very suitable for long words:

even suffix icon will be in Visibility with visible option = false.
Hot fix: I manually changed overflow option for hint in input_decorator.dart:2066 to fade and got nice result:

I'm not clear what your proposal is, because you could achieve the look that you want by using the InputDecoration

@escamoteur I already use InputDecoration and ask to add new option hintOverflow in it.

You mean cou can set it for the input text but not for the hint?

Here code from input_decorator.dart how hint creates:
`final Widget hint = decoration.hintText == null ? null : AnimatedOpacity(
  opacity: (isEmpty && !_hasInlineLabel) ? 1.0 : 0.0,
  duration: _kTransitionDuration,
  curve: _kTransitionCurve,
  child: Text(
    decoration.hintText,
    style: hintStyle,
    overflow: TextOverflow.ellipsis,
    textAlign: textAlign,
    maxLines: decoration.hintMaxLines,
  ),
);`

I want to swap overflow: TextOverflow.ellipsis on something like overflow: decoration.hintOverflow
If needed I can do pull request.

Sorry, reached the desired behavior by adding isVisible condition in project code:
suffixIcon: isVisible ? null : IconButton(


Creating a Czech translation

Heym Ploi team 👋🏻,
I've been using Ploi.io for a while now and it's awesome! 🤘🏻 I would like to contribute and so I am sending my translation into Czech. 🇨🇿
Thanks for your work.

Excellent! Will be released today 👌

Awesome!🤟
I would like to ask - while translating I noticed that some strings are not included in the *.json file. Is it possible to translate other strings?

That's indeed correct, we're running a bit behind. You could basically just append those strings indeed and translate them, the chances are big we're going to update soon and have the exact same texts.


PT-1605 | chore: fix typescript errors, add clean/typecheck scripts, use cross-env

Description :sparkles:
chore: fix typescript errors, add clean/typecheck scripts, use cross-env

remove all @ts-ignore's
set EventsPage.test.tsx timeout to 95s (was 70s) to make it
pass when testing all tests locally, if testing only
EventsPage.test.tsx and no other tests the running time was ~30s–40s
but if running all tests then running time of EventsPage.test.tsx was
~80s–120s, mostly <95s

package.json:

use cross-env in scripts for cross-platform support
add clean and typecheck scripts
dependencies:

add cross-env v7.0.3
switch from @datapunt/matomo-tracker-react v0.5.1 to
@jonkoops/matomo-tracker-react v0.7.0 to remove need for @ts-ignore
related to MatomoProvider

refs PT-1605
Issues :bug:
PT-1605
Closes :no_good_woman:
-
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #271 (2950fe2) into PT-1605-improve-tests (b395d76) will not change coverage.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           PT-1605-improve-tests     #271   +/-   ##
======================================================
  Coverage                  85.90%   85.90%
======================================================
  Files                        116      116
  Lines                       2979     2979
  Branches                     766      766
======================================================
  Hits                        2559     2559
  Misses                       414      414
  Partials                       6        6

Impacted Files
Coverage Δ

...onents/multiSelectDropdown/MultiSelectDropdown.tsx
89.13% <ø> (ø)

src/domain/matomo/Matomo.tsx
85.71% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat(clipboard): add the ability to specify number of attempts in clipboard directive

Adds a new input to the cdkCopyToClipboard directive which allows consumers to set the number of attempts to try and copy their text. We currently have an example of how to implement attempts in the readme, but this feature makes it more convenient so that consumers don't have to do it on a case-by-case basis.

Added an injection token that can be used to configure the number of attempts.

good to merge after rebasing and fixing the lint error

Done @mmalerba.

It looks like there is an issue with the tests now

Looks like I messed up the rebase. It should be good to go now.


[Wait for 2736 & 2744 ][update/gpu] Update FC layer on GPU with latest pipeline changes

Removed cl_context dependencies.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Debadri Samaddar<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2748. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Configure port names via values.yaml to support Istio Port Selection

Hi
I recently deployed Zeebe to a kubernetes cluster that uses the Istio Service Mesh.
To configure Port Selection (https://istio.io/docs/ops/configuration/traffic-management/protocol-selection/) the port names should be prefixed with the protocol e.g. grpc-gateway.
At the moment I am pulling down the helm chart, expanding the charts and modifying the port names.
Could the port names be configurable via the values.yaml file?
Example:
Service.yaml
    - port: {{ .Values.service.http.port }}
      protocol: TCP
      name: http   # change to {{ .Values.service.http.name }}
    - port: {{ .Values.service.gateway.port }}
      protocol: TCP
      name: gateway  # change to {{ .Values.service.gateway.name }}

Statefulset.yaml
ports:
        - containerPort: 9600
          name: http    # change to {{ .Values.service.http.name }}
        - containerPort: 26500
          name: gateway  # change to {{ .Values.service.gateway.name }}
        - containerPort: 26501
          name: command  # change to {{ .Values.service.command.name }}
        - containerPort: 26502
          name: internal  # change to {{ .Values.service.internal.name }}

values.yaml
service:
  type: ClusterIP
  http:
    port: 9600
    name: http-web
  gateway:
    port: 26500
    name: grpc-gateway
  command:
    port: 26501
    name: tcp-command
  internal:
    port: 26502
    name: tcp-internal

Thanks
Andy

Hey @andylholloway,
thanks for opening this issue, sounds reasonable for me.
Probably it would make sense to have this as default names, or?
Are you willing in providing a PR for that?
Greets
Chris

Hi @Zelldon
I'd be happy to provide a PR for this.
I was thinking of keeping the existing port names as defaults and only overriding a port name if a port name is provided in the values.yaml. Is that how you see it?

@npepinpe any opinion on this?

Is the automatic protocol detection only detecting HTTP and HTTP/2? I was under the impression they could detect most protocols, but maybe not. :disappointed_relieved:
@andylholloway's proposal sounds good - keep default port names and overwrite only if provided. :+1:

AFAIK Istio can auto-detect HTTP and HTTP/2, but will default to TCP when it cannot determine the protocol.

@Zelldon , @npepinpe
I have made the changes in a local branch, but I'm not sure how to push my changes and create a PR.
Could you tell me what steps I need to take to create a PR?
Thanks
Andy

For contributors, you would fork the repository, then push the branch to your fork. You can then go to Pull Requests and open a PR against our repository's master branch.
See here on how to create and maintain forks: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/working-with-forks
And here on how to open a PR from your own fork: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
Let us know if you need anything else!

Closed by #39


Request: New lint to catch potential memory leaks

Recently I found a bug in a cython code base which caused a memory leak. The issue was the author had written a __cdel__ instead of __del__ or __dealloc__. I think it would be valuable to have a rule that we could potentially opt into, which would allow us to find __cinit__ methods without a matching __dealloc__ implementation. I took a pass and didn't see anything like this documented in the current rule set.

Thanks for idea!
Could you spell out more explicitly what the rule should be please? As in, could you please show

a minimal code example which cython-lint should flag
a minimal code example which is similar in nature but which this tool should not flag

Then I can add it
Thanks!

Sure, essentially I'm asking for the cython special function rules to be encoded in some lint functions. https://cython.readthedocs.io/en/latest/src/userguide/special_methods.html#finalization-methods-dealloc-and-del
Here is some some code that correctly allocates and deallocates that memory when Example is garbage collected and destructed.
cdef cppclass DummyAllocation:
    DummyAllocation() except +

cdef class Example:
    ''' Python class abstraction for DataPacket-based communication.
    Provides methods for packet field manipulation and serial framing.
    '''
    cdef DummyAllocation* _allocation

    def __cinit__(self, *args, **kwargs):
        self._allocation = new DummyAllocation()

    def __dealloc__(self):
        del self._allocation

Here is the code where we would leak memory, where __dealloc__ is just missing, or as I mentioned originally maybe it's just named the wrong thing :smile::
cdef cppclass DummyAllocation:
    DummyAllocation() except +

cdef class Example:
    ''' Python class abstraction for DataPacket-based communication.
    Provides methods for packet field manipulation and serial framing.
    '''
    cdef DummyAllocation* _allocation

    def __cinit__(self, *args, **kwargs):
        self._allocation = new DummyAllocation()

Note that it is perfectly ok to have a __cinit__ method and not allocate anything, so this is a kind of awkward rule to enable by default, since unless you can actually detect an allocation happening (new / malloc / opening of a file descriptor...) there is no way to know if you actually NEED a __dealloc__, etc...

happy to review a PR if you put one up


Convert the code that does the bagging to a service

So we can use it also in a REST interface as described at https://github.com/Islandora-CLAW/CLAW/issues/1096.

Closed with 80ebbcef950b9645763f76f7e778c41084dd4b14.


Update the version to 2.3.0-SNAPSHOT version and improve to get clean builds with out -D args in mvn

Just committed the changes:
commit 4ea0d790ae3dca9f250d99e7df8cdff55868c14c
Author: Uma Maheswara Rao G<EMAIL_ADDRESS>Date:   Fri Aug 30 15:09:03 2019 -0700
Changed the version to 2.3.0-SNAPSHOT and few improvements: https://github.com/Intel-bigdata/IntelQATCodec/issues/6


Please consider supporting vue

In the vue file, both the code in the script tag and the  style tag are commented, using html comment.

I don't recall where I got this, so I cannot give credit where it is due. But adding this hook will do the trick.
function! NERDCommenter_before()
  if &ft == 'vue'
    let g:ft = 'vue'
    let stack = synstack(line('.'), col('.'))
    if len(stack) > 0
      let syn = synIDattr((stack)[0], 'name')
      if len(syn) > 0
        exe 'setf ' . substitute(tolower(syn), '^vue_', '', '')
      endif
    endif
  endif
endfunction

See recording https://asciinema.org/a/xbEFLoNTRoRr6DTWt3GzC9aua

It changes the file type based on the syntax at the current location so that NERDCommenter can toggle the right comment style and then swaps it back afterwards.
There are some limitations to this which is why there is no generic solution (AFAIK). See #17 for an explanation.

@mblarsen Thank you very much, I will try it. Already a similar and better issue #17, then I closed the issue.

@mblarsen The script works for the js block perfectly but it glitches on the html block. In my case it sometimes wraps the current html line in /* <my html code> */ when I want it to do <!-- <my html code> -->. I think it would be excellent if this feature is implemented natively.
And by the way, here's the credit for you code:doc :)

It has worked for me quite a while and stopped working recently. I'm a noob when it comes to debugging vim scripts but as far as i can tell the hooks are still working properly. In my Vue SFC the blocks are still identified as htmltags or javascript but somehow the comment-type is always html-style (). I somehow think that it's due do my vim version (8.2.2311).
Anybody got an idea how to get this working again? I don't want to switch to another plugin or anything like that


SOLR 8 entrypoints

As I understand it there is a race condition between mounting a volume over SOLR and lagoon/lando/pygmy which can be addressed by recreating the core ( https://github.com/uselagoon/lagoon-images/pull/97 )
The recommended way for getting a SOLR-8 running via @tobybellwood was something similar to:
FROM uselagoon/solr-8-drupal
CMD solr-recreate drupal /solr-conf && solr-foreground

This works great on lagoon
But when working locally in a tool like lando, the command gets overridden to
/sbin/tini -- /lagoon/entrypoints.sh solr-foreground

This can be worked around by setting up the cmd again in the .lando.yml file as an override for the service, but it feels dirty writing this multiple times in a project.
Which got me thinking, what if its moved into an entrypoint?
FROM uselagoon/solr-8-drupal

USER root
RUN echo -e "#!/bin/bash\nsolr-recreate drupal /solr-conf" > /lagoon/entrypoints/90-solr.sh

USER solr
CMD ["solr-foreground"]

So the issue request is...

Would it be possible to bake in an entrypoint for solr-8 and solr-8-drupal that runs the recreate logic.
Is there any negatives to it?
Could it use an ENV inside the entrypoint for the core name?

As a followup to this @tobybellwood we're using this approach for Solr 8 on our site (worked fine in testing for a few weeks, just deployed to production and seems to be going fine).
We have three Solr cores (one with 2 indexes), and I used the same approach as above, echo -ing the solr-recreate command for each core into /lagoon/entrypoints/90-solr-recreate.sh.


How change colors inside this dialog?

How change colors inside this dialog?

Hi Alex, based on your MaterialTheme setup, you define colors, typography, and more for this Views, Dialogs, PopUps and more.


Add the ability to query logs from a flux only source

as a platform user
with the permissions to view logs in the ui
when i go to the logviewer page
i would like to query for my logs using flux (instead of InfluxQL)

rethinking event viewer


⚠ Mobitopup has degraded performance

In 9701a58, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6660 ms

Resolved: Mobitopup performance has improved in 8dc423a.


Simple tests for Chez render

@turlando some links from Spago useful to setup tests here:

the package.yaml will need some build configuration like this
then you need some boilerplate to start off the tests with autodiscovery, this and this
example of unit tests
here you can see how every test can run independenctly in their own directory (key points are the setup definition and the around_ setup in line 26)
example of how to run shell, reading fixtures, and other stuff, that Util file contains common testing stuff that might be useful here


Improve UI and styling for the "/poll" widget to be shippable

The Zulip webapp has an experimental /poll slash command feature, currently disabled in most Zulip organizations because it's very unpolished.  We've been hearing from a lot of folks that they'd like it on Zulip Cloud, so it's worth making an initial TODO list of what needs to happen before it can be shipped.  Here's my list:

[ ] Change the "Edit question" UI to just be an edit-pencil button rather than a large "Edit question" button.
[ ] Move the "Add option" text box below the results section.
[ ] Style the results section to look nicer; ideally, including some sort of more visual display where large numbers of votes jump out.
[ ] Use nicer button styles.

These might not be blockers but would also be really high value.

[ ] Add slash command typeahead: https://github.com/zulip/zulip/pull/10267
[ ] Make the default UI for setting the initial question text be to include it as an argument in the slash command.
[ ] Probably a bunch more little styling/UI things, but we can worry about those once the strong blockers are done.

The JS code for this widget is in static/js/voting_widget.js, static/templates/widgets/poll-widget.handlebars, and various CSS files.

This is mostly CSS/HTML work.  The main todos possibly require zero JS changes, although you'll probably need to understand the JS code.

On another note, what about adding a settings group called "Experimental features"? This way, testing can be outsourced to zulipchat.com, not just on czo.

Generally we just add things in the place they should go, and tag them as "experimental".  It's not super hard to do that here, but I also don't think it's any less work than just fixing the widget.

but I also don't think it's any less work than just fixing the widget.

I'm not referring just to the "/poll" widget but to all the experimental "lab" features. Isolating them in a group helps to reinforce that they are experimental.

I would like to take this up if no one is working on it already. @zulipbot claim

@Varunvaruns9  I am almost done with the edit pencil thing... so i would request you do the other parts of this issue

I thought this was abandoned. Please continue @ishanrai05 👍

@zulipbot abandon

@ishanrai05 you can reclaim the issue if you are working on it.

@Varunvaruns9 seems like a reasonable addition.


Fix mapping for internal TF for CentOS-Stream

In Convert2RHEL we want to start testing on CentOS-Stream-8. The current mapping returns RHEL-8.5 Nightly images. This PR fixes that.

@kokesak Thanks for sending the PR!
@thrix Can you please look at this to see if this makes sense from your point of view? (For me, it makes sense to be explicit and users can still use RHEL if set explicitly.)

Some context for this change - in convert2rhel we've revived our efforts to allow conversion from CentOS Stream 8 to RHEL 8 (https://github.com/oamg/convert2rhel/pull/267). For conversions in general we need the internal Red Hat network available, so with the use_internal_tf set to True we need to have a way to run the tests on a CentOS Stream 8 machine. However with the current mapping, we'd get the RHEL-8.5.0-Nightly instead.

Small update:
We discussed this with Miro last week and the stream is currently not present in the internal range -- @bocekm, can you please ask for the Stream to be included? (I hope you've already made the request for something else so you might know better than me what needs to be done...)

Another update:
I get that wrongly. CentOS-Stream-8 is [available in the internal composes(https://api.dev.testing-farm.io/v0.1/composes/redhat), CentOS-Stream-9 is not there yet.

@lachmanfrantisek, thanks for the update. We need just the CentOS-Stream-8 for now and won't need 9 for many months ahead.


Fix completed orders

This PR fixes a few issues with reqCompletedOrders:

The typing on the completed order listener is adjusted to reflect the fact that the decoder does in fact provide a Contract, Order and OrderState object
The completed order decoder has been adjusted to accommodate the presence of a dontUseAutoPriceForHedge field present for specific client / server pairings
A typo is fixed to allow for the COMPLETED_ORDERS_END event to be handled correctly

NP - and yeah, that would totally make sense. Anything that would move the method discovery into something statically known would be nice, to at least catch it at tsc time.


Add jenkins files for ppc64le and s390x docker platforms

Resolves: https://github.com/AdoptOpenJDK/openjdk-tests/issues/715
Signed-off-by: Mesbah Alam<EMAIL_ADDRESS>

@sophia-guo , please note that this PR has an additional change to https://github.com/Mesbah-Alam/openjdk-tests/blob/addToExternalTest_s390x_and_ppc64le_arch/buildenv/jenkins/openjdk_x86-64_linux_docker - in that I've added the the node ("master") here that was not added to it before.

Test for ppc64le : https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/62/console suggests :
There are no nodes with the label ‘ci.role.test&&hw.arch.ppc64le&&sw.os.linux&&sw.tool.docker’
@sxa555 , It looks like we need to add sw.tool.docker label to the docker enabled ppc64le Linux machines at Adopt .

Test with x64 linux: https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/63/console

I will add the labels you mention @Mesbah-Alam .  For grinders, remember that you can put hostname for a label to override what the jenkins scripts default to looking for, so please do that for now.

Running directly on the ppc64le test machine test-osuosl-ppc64le-ubuntu-16-04-1 reveals that docker has not yet been installed there: https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/66/console

@AdamBrousseau , good point. We can use an existing flag BUILD_LIST and do something like this:
if (env.BUILD_LIST == 'thirdparty_containers'){
	LABEL='ci.role.test&&hw.arch.x86&&sw.os.linux&&sw.tool.docker'
} else {
	LABEL='ci.role.test&&hw.arch.x86&&sw.os.linux'
}

node ("master") {
    checkout scm
    def jenkinsfile = load "${WORKSPACE}/openjdk-tests/buildenv/jenkins/JenkinsfileBase"
    jenkinsfile.setLabelParam()
    cleanWs()
}

stage('Queue') {
    node("$LABEL") {
        PLATFORM = 'x64_linux'
        SDK_RESOURCE = 'upstream'
        SPEC='linux_x86-64_cmprssptrs'
        checkout scm
        def jenkinsfile = load "${WORKSPACE}/openjdk-tests/buildenv/jenkins/JenkinsfileBase"
        jenkinsfile.testBuild()
    }
}

https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_Sandbox/67/console

LABEL='ci.role.test&&hw.arch.x86&&sw.os.linux'
if (env.BUILD_LIST == 'thirdparty_containers'){
	LABEL+='&&sw.tool.docker'
}

As long as thirdparty_containers will always mean docker and nothing else will ever need docker.

Actually, introduced a new Boolean flag called DOCKER_REQUIRED. The jenkins files will check for it. I will set it in each of the Grinders and the external test jobs at Adopt.

Suggest to use a separate parameter.
BUILD_LIST can be blank, in which case all test material compiled.  Then, if test target is scala_test or some other target in thirdparty_containers, the test would try to run on SPEC not on SPEC with docker installed.


copy and link to typescript types

copies and links to typescript types from #76
Signed-off-by: Logan McAnsh<EMAIL_ADDRESS>

@mcansh please help test 2.3.5-beta.1

autocomplete works in vscode 👍, I'll check what definitelytyped does for theirs


Add patch to drop ordereddict

Seems an unneeded dependency on ordereddict is causing issues with using nose-timer. This adds a patch to remove that dependency and a CLI test to verify the correct behavior has been restored.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks for the speedy patch on this!

No problem.


examples/widgets/container.dart does not display the buttons

Add a missing Material.
Fixes #1402

@Hixie

LGTM but I question the value of this example in general.


SAS 9.4 (local - COM) session startup error

Describe the bug
When submitting code to a new SAS session to a SAS 9.4 (local - COM)  profile, a notification "There was an error executing the SAS Program." appears, either:

When code is run by clicking on the running man icon, pressing "F3" or "F8" (default keyboard shortcuts): the message shows up as:

but it doesn't seem to have any consequence, other than not displaying the html output generated; the 'Output' pane shows the expected SAS log without any error or warning; after that, if some code is submitted again by clicking on the running man icon, pressing "F3" or "F8" or selecting the 'Terminal' menu item 'Run Task ...'  -> 'sas: Run sas file', the code executes normally, the html output is displayed (if any) and no other error notification occurs.
When code is run from the 'Terminal' menu item 'Run Task ...'  -> 'sas: Run sas file', the message  appears in the 'TERMINAL' pane as:

The expected SAS Log appears in the 'OUTPUT' pane without any error or warning; the html output generated is not displayed, and the running man icon remains disabled (it cannot be re-enabled by clicking the 'Close Current Session' button, nor by switching to another local SAS profile, only by closing and restarting VScode); when this occurs, clicking on the running man icon, pressing "F3" or "F8" has no effect (no additional code can be submitted).

 *  Executing task: sas: Run sas file

Connecting to SAS session...
SAS code running...
There was an error executing the SAS Program.
                                             See console log for more details.

Task is cancelled.

 *  The terminal process terminated with exit code: 1.
 *  Terminal will be reused by tasks, press any key to close it.

Trying to submit code again from the 'Terminal' menu item 'Run Task ...'  -> 'sas: Run sas file' results in the following message in the 'TERMINAL' pane:

*  Executing task: sas: Run sas file

There is running task, please try again after that is complete.

 *  The terminal process failed to launch (exit code: 1).
 *  Terminal will be reused by tasks, press any key to close it.

Steps to reproduce
Steps to reproduce the behavior: see above.
Expected behavior
The code is submitted without any error notification; the html output (if any) is displayed; the running man icon that was disabled during the code execution gets re-enabled.
Screenshots
see above
Environment (please complete the following information):
Client OS: Windows 10 (X64_10PRO  platform)
Extension version: [v1.5.0] - 2023-10-27
SAS version: SAS 9.4 (local - COM)  (TS1M7)
Additional context
This occurs even without any customization of the vscode-sas-extension.

What's you SAS system? I just meet the same issue.
My SAS is installed in a windows server and has no metadata server and no workspace server and no SAS Integration Technologies, but has  SAS Integration Technologies Clients. When I login in via windows remote desktop, I can run sas code via COM in vscode. But if I sign in by SSH (vscode remote-ssh), I have the same error report as you reported.

Would you click Help > Toggle Developer Tools and see the error details in the console?

This is my console message:
console.ts:137 [Extension Host] ERROR: The process "22244" not found.
w @ console.ts:137

console.ts:137 [Extension Host] shellProcess stderr: at Run, <No file>: line 65

w @ console.ts:137

console.ts:137 [Extension Host] [Error: There was an error executing the SAS Program.
See console log for more details.
	at Socket.onShellStdErr (E:\Users\xxxx\UserConfig\Code\.vscode-server\extensions\sas.sas-lsp-1.5.0\client\dist\node\extension.js:247:147)
	at Socket.emit (node:events:513:28)
	at addChunk (node:internal/streams/readable:324:12)
	at readableAddChunk (node:internal/streams/readable:297:9)
	at Readable.push (node:internal/streams/readable:234:10)
	at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)]
notificationsAlerts.ts:42 There was an error executing the SAS Program. See console log for more details.
c @ notificationsAlerts.ts:42

console.ts:137 [Extension Host] shellProcess stderr: at ResolveSystemVars, <No file>: line 11
at <ScriptBlock>, <No file>: line 1
At line:1 char:1
+ $runner.ResolveSystemVars()
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException

w @ console.ts:137

console.ts:137 [Extension Host] shellProcess stderr: Run error
At line:70 char:7
+       throw "Run error"
+       ~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Run error:String) [], RuntimeException
    + FullyQualifiedErrorId : Run error

w @ console.ts:137

What's you SAS system? I just meet the same issue.
My SAS is installed in a windows server and has no metadata server and no workspace server and no SAS Integration Technologies, but has SAS Integration Technologies Clients. When I login in via windows remote desktop, I can run sas code via COM in vscode. But if I sign in by SSH (vscode remote-ssh), I have the same error report as you reported.

I have PC SAS on a windows local laptop: no Remote Desktop, no ssh involved.

@ShuguangSun, "process not found" sounds like the powsershell process was accidentally exited.

Would you click Help > Toggle Developer Tools and see the error details in the console?

Thanks @scnwwu for the tip!
Running with"F3" resulted in the following messages in the Developer Tools console:

Running from the 'Terminal' menu item 'Run Task ...' -> 'sas: Run sas file' resulted  in the following messages in the Developer Tools console:

This showed the problem was linked to inserting option "ECHOAUTO" in my profile definition in settings.json:
    "SAS.connectionProfiles": {
        "activeProfile": "Local SAS 9.4",
        "profiles": {
            "Local SAS 9.4": {
                "connectionType": "com",
                "sasOptions":
                    [
                        "ECHOAUTO",
                        "MPRINT",
                        "LS=120"
                    ],
                "host": "localhost"
            }
        }
    },

Removing that option fixed all the issues for submitting code by clicking on the running man icon, pressing "F3" or "F8" or selecting the 'Terminal' menu item 'Run Task ...' -> 'sas: Run sas file'
Suggestions to help prevent reoccurrences of the issue:

indicate in https://github.com/sassoftware/vscode-sas-extension/blob/main/connect-and-run.md#additional-settings-in-a-profile that the Options only allowed at startup are (currently?) not supported for SAS 9.4 (local - COM)
(not sure if this is feasible): replace the message See console log for more details. with the more explicit See console log (click Help > Toggle Developer Tools) for more details.

@ShuguangSun, "process not found" sounds like the powsershell process was accidentally exited.

It doesn't work. As my issue is different to jbodart-argenx's, I will open a new issue.

    "SAS.connectionProfiles": {
        "activeProfile": "Local SAS 9.4",
        "profiles": {
            "Local SAS 9.4": {
                "connectionType": "com",
                "sasOptions":
                    [
                        "ECHOAUTO",
                        "MPRINT",
                        "LS=120"
                    ],
                "host": "localhost"
            }
        }
    },

How about remove mprint from the options?

Having MPRINT as an option (or not) seems to me a user preference, and as far as I can tell it is not causing any error or warning.

remove ECHOAUTO from the option as the log said: ECHOAUTO is valid only at startup...

Thank you @jbodart-argenx for the suggestions.
I added an item to the FAQ page as a first quick step.
https://github.com/sassoftware/vscode-sas-extension/wiki/FAQ#i-got-see-console-log-for-more-details-error-where-to-see-the-console-log

sasOptions doc updated via #696
See console log message updated via #782

Will Startup options for SAS 9.4 (local) and (remote-IOM) be supported in the future releases?


Showing as not connected to UI even though I am.

https://i.imgur.com/J66qCBH.png
This one isn't a big deal just thought I would let you guys know its doing this no matter how many times I refresh the page.

Yeah, this is happening because the WebSocket can't connect -- for some reason Caddy isn't properly proxying the WebSocket requests through to Phoenix.
Alternatively, if you were just using Caddy for its ACME support, in 0.5.0 we now have ACME support in Firezone. It's disabled by default, but if you want to enable it (and ditch Caddy) you can do so with something like the following config:
default['firezone']['nginx']['enabled'] = true
default['firezone']['ssl']['acme']['enabled'] = true
default['firezone']['nginx']['non_ssl_port'] = 80
default['firezone']['nginx']['ssl_port'] = 443
default['firezone']['ssl']['certificate'] = nil

Assuming your server has a valid

Okay! Ill go ahead and close this issue because I didn't know it was an issue with my particular setup!

The issue is that I'm also hosting a docker vaultwarden server on the same machine so it would be difficult to get rid of using caddy because it provides a connection to both firezone and bitwarden

Ah I see. Feel free to leave this issue open for a while -- maybe someone else has a similar configuration and figured out a solution.
It may help to post a screenshot of your browser's JS console showing the details of the WebSocket connect failure.

Can I see your caddy config? Also are you on caddy 1 or caddy 2

http://vpn.dillfrescott.com {
reverse_proxy http://localhost:7000

}
https://bitwarden.dillfrescott.com {
reverse_proxy http://localhost:3000

}
Caddy 2

@princemaple I know right? I would expect Caddy to handle proxying stuff like that just automatically

Can you try this instead?
vpn.dillfrescott.com {
reverse_proxy localhost:7000
}

Ok tried it. Caddy doesnt even recognize removing the http as a config change. Its the exact same according to it.
2022/07/29 21:50:59.235 INFO     config is unchanged
Also I checked firezone and its still saying not connected btw.

To be clear, before 0.5 it was proxying the websocket correctly with nginx between phoenix and caddy

I have yet to update to 0.5.1 yet and am still on 0.5.0, does the update handle anything with that?

Any server logs / browser console logs?

https://i.imgur.com/K02iZJW.png Yes lol I probably should have checked this

@DillFrescott Any corresponding log in firezone-ctl tail phoenix? What's your default['firezone']['external_url'] set to?

https://bin.idrix.fr/?560fd3a725c353e4#429ofkfwoGw5vv6jK6AguMmhu2ycg9AzQqpzg424T93v
Thats a paste of my entire firezone.rb file.
The logs say:
root@instance-20220719-0115:/# firezone-ctl tail phoenix
2022-07-29_22:28:33.14749   Serializer: Phoenix.Socket.V2.JSONSerializer
2022-07-29_22:28:33.14920   Parameters: %{"token" => "SFMyNTY.g2gDYQFuBgCDTBNMggFiAAFRgA.edTgZz-CE7v9DbX0HkPNWhF0Ain16JbMd4aLnKT-Ggs", "vsn" => "2.0.0"}
2022-07-29_22:28:35.30510 22:28:35.304 [info] REFUSED CONNECTION TO FzHttpWeb.UserSocket in 181µs
2022-07-29_22:28:35.30512   Transport: :websocket
2022-07-29_22:28:35.30512   Serializer: Phoenix.Socket.V2.JSONSerializer
2022-07-29_22:28:35.30512   Parameters: %{"token" => "SFMyNTY.g2gDYQFuBgCDTBNMggFiAAFRgA.edTgZz-CE7v9DbX0HkPNWhF0Ain16JbMd4aLnKT-Ggs", "vsn" => "2.0.0"}
2022-07-29_22:28:41.30015 22:28:41.299 [info] REFUSED CONNECTION TO FzHttpWeb.UserSocket in 142µs
2022-07-29_22:28:41.30017   Transport: :websocket
2022-07-29_22:28:41.30017   Serializer: Phoenix.Socket.V2.JSONSerializer
2022-07-29_22:28:41.30018   Parameters: %{"token" => "SFMyNTY.g2gDYQFuBgCDTBNMggFiAAFRgA.edTgZz-CE7v9DbX0HkPNWhF0Ain16JbMd4aLnKT-Ggs", "vsn" => "2.0.0"}
2022-07-29_22:28:47.30336 22:28:47.303 [info] REFUSED CONNECTION TO FzHttpWeb.UserSocket in 146µs
2022-07-29_22:28:47.30352   Transport: :websocket
2022-07-29_22:28:47.30508   Serializer: Phoenix.Socket.V2.JSONSerializer
2022-07-29_22:28:47.30509   Parameters: %{"token" => "SFMyNTY.g2gDYQFuBgCDTBNMggFiAAFRgA.edTgZz-CE7v9DbX0HkPNWhF0Ain16JbMd4aLnKT-Ggs", "vsn" => "2.0.0"}

@princemaple Error is likely here: https://github.com/firezone/firezone/blob/master/apps/fz_http/lib/fz_http_web/channels/user_socket.ex#L31
I'll do some local testing and see if I can get it fixed. Enjoy your weekend!

@DillFrescott Thanks a lot for the prompt responses!
@jamilbk 🙏

Awesome! Sounds good!

#877 should resolve this and also print some helpful information to your phoenix log showing the x-forwarded-for header as seen by Phoenix. It's likely that's not coming through properly.


upstreams.map is not a function error when passing jwt header

Hi,
I am trying to secure my admin apis with jwt token. When I post to the kongfig i receive error. I wonder if it can't parse the "Bearer jwt" correctly since it has a space between "Bearer" and the token?
Here is an example of my command: kongfig apply --path file-name --https --host admin-url --header 'Authorization: Bearer jwt'
Here is the error i get: Kong version: 0.12.1
TypeError: upstreams.map is not a function
TypeError: upstreams.map is not a function
at _callee2$ (/usr/local/lib/node_modules/kongfig/lib/kongState.js:47:54)
at tryCatch (/usr/local/lib/node_modules/kongfig/node_modules/regenerator-runtime/runtime.js:65:40)
at Generator.invoke [as _invoke] (/usr/local/lib/node_modules/kongfig/node_modules/regenerator-runtime/runtime.js:303:22)
at Generator.prototype.(anonymous function) [as next] (/usr/local/lib/node_modules/kongfig/node_modules/regenerator-runtime/runtime.js:117:21)
at step (/usr/local/lib/node_modules/kongfig/lib/kongState.js:21:191)
at /usr/local/lib/node_modules/kongfig/lib/kongState.js:21:361
at
at process._tickCallback (internal/process/next_tick.js:169:7)
Thanks.

Just released a new<EMAIL_ADDRESS>you please try upgrading

hi, thanks for the quick turnaround. I installed the latest but still facing the same issue.
TypeError: upstreams.map is not a function
TypeError: upstreams.map is not a function
at /usr/local/lib/node_modules/kongfig/lib/kongState.js:27:44
at Generator.next ()
at step (/usr/local/lib/node_modules/kongfig/lib/kongState.js:17:191)
at /usr/local/lib/node_modules/kongfig/lib/kongState.js:17:361
at
at process._tickCallback (internal/process/next_tick.js:169:7)
Here is my latest installed of kongfig
npm install kongfig -g
/usr/local/bin/kongfig -> /usr/local/lib/node_modules/kongfig/bin/kongfig

<EMAIL_ADDRESS>removed 1 package and updated 2 packages in 3.22s

Thanks.

It would be great to know what you get back from /upstreams with curl for example; is it actually the expected response, or a JSON error with 200 OK.
If it is correct do you have a next url in the response and does it look correct?
curl -k -i -X GET \
  -H "Accept: application/json" \
  -H "Authorization: Bearer jwt" \
  --url https://[admin-url]/upstreams

hi,
I executed the curl command as you suggested. I set up my admin apis as suggested by Kong: https://getkong.org/docs/0.12.x/secure-admin-api/#kong-api-loopback
Thanks.
Here was my response:
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Cache-control: no-cache="set-cookie"
Content-Type: application/json; charset=utf-8
Date: Wed, 28 Feb 2018 22:43:26 GMT
Server: kong/0.12.1
Via: kong/0.12.1
X-Kong-Proxy-Latency: 42
X-Kong-Upstream-Latency: 27
Content-Length: 21
Connection: keep-alive
{"data":{},"total":0}

Thanks I now see what the problem is, will fix it tomorrow (GMT)

So what I would expect to see is the following (notice the "data":[])
HTTP/1.1 200 OK
Date: Thu, 01 Mar 2018 10:17:28 GMT
Content-Type: application/json; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Access-Control-Allow-Origin: *
Server: kong/0.12.1

{"total":0,"data":[]}

<EMAIL_ADDRESS>should fix it for you. Please let me know if this fixes it for you if not please re-open the issue.

It works after the fix.  Thank you so much!

No worries, let me know if you have any other issues.


Project licence?

Hi, I was wondering what the license for this project is. It gets pulled in by fastapi[standard], and I'd like to check if it can be used in commercial software.

@ns-vmaisonneuve yup, I'll make MIT now, I forgot to add it 😊

@ns-vmaisonneuve just updated, and made a new release too (just in case it is needed)
Thanks for opening the issue!

@patrick91 Thanks a lot!


Playing sounds does not work while hooking PlayerObject::playerDestroyed() and PlayerObject::playDeathEffect()

Geode Issue

[X] I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform
Windows
SDK commit
No response
Geode Version
v2.0.0-beta.9
Mods Installed
No response
Expected Behavior
Expected to play a sound effect when the player dies
Actual Behavior
That sound effect did not play
Steps to Reproduce
Modify PlayerObject::playDeathEffect() or PlayerObject::playerDestroyed(bool p0):
#include <Geode/Geode.hpp>
#include <Geode/modify/PlayerObject.hpp>

using namespace geode::prelude;

class $modify(PlayerObject) {
    TodoReturn playerDestroyed(bool p0) {
        log::info("hello 1");
        PlayerObject::playerDestroyed(p0);

        FMODAudioEngine::sharedEngine()->playEffect("endStart_02.ogg");  // does not work

        log::info("hello 2");
    }

    TodoReturn playDeathEffect() {
        PlayerObject::playDeathEffect();

        FMODAudioEngine::sharedEngine()->playEffect("endStart_02.ogg"); // same issue
    }

    TodoReturn pushButton(PlayerButton p0) {
        PlayerObject::pushButton(p0);

        FMODAudioEngine::sharedEngine()->playEffect("endStart_02.ogg"); // but this works???
    }

};

Additional Information
No response

nevermind its my skill issue


METRON-1237 address javadoc warnings in metron-maas-common

Contributor Comments
address javadoc warnings in metron-maas-common
[WARNING] Javadoc Warnings
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/Endpoint.java:57: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/MaaSConfig.java:41: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/MaaSConfig.java:55: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:36: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:48: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:60: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:72: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:84: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/ModelRequest.java:96: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java:121: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java:224: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java:286: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java:295: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java:334: warning - @return tag has no arguments.
[WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/queue/QueueHandler.java:47: warning - @return tag has no arguments.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Might it be better to leave off the @return altogether where the methods are self-describing?

@mmiklavc my understanding is that if we leave off @return tag, javadoc will still throw a warning about a missing return tag, please advise, I'm impartial.

Ah, you are correct, e.g.
[WARNING] /Users/mmiklavcic/devprojects/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/queue/QueueHandler.java:46: warning: no @return
[WARNING] public Queue<ModelRequest> create(Map<String, Object> config) {
[WARNING] ^

+1


Video loses aspect ratio

Describe the bug
I have a video which has the original height and width of 956x354 which means aspect ration of 956/354 = 2.7
When I use the autoGenerateRepresentations function I get these sizes in my m3u8 file:
144x60 = 2,4
240x100 = 2,4
360x150 = 2,4
480x200 = 2,4
720x302 = 2,38
956x354 = 2,7
Which will cause a jump in the aspect ratio of the file, which is unwanted. Is there any way to solve this issue so that the streams all have the original aspect ratio of 2,7?
To Reproduce
Steps to reproduce the behavior:
Use this Video: https://fuego-files.s3.eu-central-1.amazonaws.com/public/8431057685e3d64d85ecac/c2a0759deb767c63c2982a7c45cfef6/video/video.mp4
With this code:
$format = new Streaming\Format\X264();
$hls = $video->hls()
->setFormat($format)
->autoGenerateRepresentations()
->setHlsTime(2)
->fragmentedMP4()
->save(null, $to_s3);
Expected behavior
All other reps have the same aspect ration of 2.7 (like the original)
Desktop/Server (please complete the following information):

OS: Ubuntu 18.04
FFmpeg vesion : ffmpeg version 4.3.1-0york0~18.04

I will check this issue later but the code uses this function to calculate width and height.


ipv6 support ?

Hello,
Thanks for openvpn-install.sh :+1:
Everything seems to work out of the box, except for ipv6. I am a Debian user.
debian stretch
openvpn 2.4.0
network-manager-openvpn-gnome 1.2.8-2
openvpn-install.sh github-3345224

No matter how I use the the .ovpn file generated (right from the CLI or via Network Manager), only the ipv4 traffic seems to be routed through my vpn. When checking https://wtfismyip.com , for instance, the ipv4 is the VPN's one, the ipv6 is my real ipv6 address.
Is there anything that needs to be done in order to support dual stack?
(my server does have an ipv6)

The script does not support IPv6.
See #242 if you want to enable IPv6 manually or just more information on the matter.


How to generate Ndt map for apollo ndt localization?

Thanks author, I can use the code generate a whole  pointcloud map (PCD), but how can I transform the pcd into the format  which canbe used in apollo ndt localization as a ndt local map?

There is a tool to generate map in apollo, I will give the reference documentation soon!

You can refer to the following tools in apollo to generate the NDT map.
modules/localization/ndt/map_creation

When drawing map using RoadRunner to export Apollo format, how to eliminate the Z coordinates in .txt file.

You can write a script to remove the z.


When will the code be released?

Thanks for your work! It's a very interesting paper aimed at an important problem.
I'm quite interested in trying out this approach in my research. Can you please share your plans on when you intend to release the full code?
Thanks

Thanks for your work! It's a very interesting paper aimed at an important problem.
I'm quite interested in trying out this approach in my research. Can you please share your plans on when you intend to release the full code?
Thanks

Thanks for your interest. We will release the code after the acceptance of the related article.


AgateTestCase should be exported so extensions can use it

This needs to be moved out of tests and into the agate codebase


Feature request: Calibre with plugins

Calibre supports plugins, and it is designed to be modified with a large collection of plugins. Currently, I can install plugins normally with calibre-customize -a someplugin.zip and it installs it under my home directory. However, I would like to manage the installation and updating of these plugins with nix.
I'm not entirely sure how to achieve this, if even possible. Perhaps, Calibre derivation could have an option plugins which is a list of nix packages that are Calibre plugins. Those zip files would then be added under lib/calibre/calibre/plugins/ in Calibre nix store (not sure though if the plugins work if added there, or is it builtin plugins only). Or calibreWithPlugins which would combine calibre package and the plugins and wraps them as a one Calibre package.
I'll just put here a few plugins I'm interested in:

https://github.com/aroig/metadata-sources
https://github.com/aroig/metadata-readers
https://www.mobileread.com/forums/showpost.php?p=3339191&postcount=1

I could work on this but it's a bit unclear to me what would be the best way to implement this.

Calibre plugins are installed into user's directory, and some of the most useful plugins like DRM stripper we might not be able to ship.
Similar to #35249.

Still important to me. Would be nice to manage calibre plugins with Nix.


feat Speed clone tablet via batch small file downloading

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Downloading small files is too slow and might cause the clone tablet task to time out. This PR supports a batch downloading API to speed up the downloading of small files.
Before
succeed to copy tablet 10088, total file size: 19256126 B, cost: 78674 ms, rate: 0.244758 MB/s

After
succeed to copy tablet 30157, total files: 20006, total file size: 19311624 B, cost: 4016 ms, rate: 4.80867 MB/s

Release note
None
Check List (For Author)

Test

[ ] Regression test
[x] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[x] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Please implement jpg quality parameter, current jpgs are very large

Would be great to implement jpg quality parameter and more efficient jpg processing. A 256x256 50kb file resulted in 700kb output. Run through tinyjpg brought it down to 115kb with little discernable quality loss. Part of the issue is probably that they're saving at 100% quality, but that may be only part of the issue.
The issue also exists with pngs. The same 1024x1024 as png is 1.5MB, run through tinyjpg brings it to 425kb with NO discernable quality loss (even when viewing at 200%+) after running it through tinypng.

Another (different example):
Original image:

Output (3MB):

After tinypng (1MB!! No difference can be seen even when viewing at much larger sizes):

Just makes no sense to me, incredible software tons of unnecessary bloat in the results. Don't get me wrong, it's amazing what's been done so far, just would like to see improvement in efficiency of output.

There is a very clear difference between the 3MB and the 1MB image. Tinypng is doing a horrible job as it's using lossy compression. Which is not something you should do with PNGs, that's what JPG is for.
The most noticeable difference being banding. Which is very easy to spot top left in the 1MB PNG.
If you want to reduce the filesize, compress using ECT (Efficient Compression Tool), which will bring it down to 2.4MB with literally 0 quality degradation. Or use Mozjpeg to turn it into a JPG in which case you can bring it down a lot before you start to notice a difference in quality.
With your 3MB PNG image, at quality 90, it would be around 331KB as a JPG, which would look pretty much identical to the PNG.
People really need to stop relying on shitty online compressers.
Implementing a feature where ESRGAN outputs horrible quality images would go against the very reason ESRGAN was made.
If you want even better filesizes, I recommend giving AVIF a try. Though keep in mind, it's not as compatible with software as JPG and PNG.
Here's a comparison: https://imgsli.com/MTMzMzgw (2560x1440 image)
Images might take a while to load since I had to losslessly turn the AVIF back to PNG for compatability in imgsli.
But as you see, 168KB JPG in this case gets beaten by 50.6KB AVIF.
13KB JPG was straight up hilarious when compared to 11.4KB AVIF.
Hope all this info helps you out.


Support for multiple return to answer ids

What is the context of this PR?
In this PR we modify return_to_answer_id to be a list of calculated summary ids and answer ids. The continue button forces new behaviour (returns to the calculated summary anchored at answer_id and pop it off the list so it becomes return_to_answer_id=calculated_summary_id). This change is similar to what we did to return_to_block_id and makes the page focus on the right elements on calculated summaries and grand calculated summaries.
How to review
Existing tests were modified and some new assertions were added where applicable (description of the test changed as well).
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Support for multiple return to answer ids

Have only functionally reviewed so far as found a couple of issues in test_grand_calculated_summary_overlapping_answers
From calculated-summary-1 if I click a change link, and then press continue, the url has return_to_answer_id=q1-a1 but it should be None, because this goes back to the cs page anchored at q1-a1 so its not an answer to return to anymore
From the grand calculated summary, I was expecting return_to_answer_id=q1-a1,calculated-summary-1 on the answer page after clicking two change links, similar to how the other params have a list, but instead I only have q1-a1 on the answer, its not following the same pattern as return_to and return_to_block_id (which I think might be what causes the above)

First issue from your comment addressed, need to spend more time on the second.

Have only functionally reviewed so far as found a couple of issues in test_grand_calculated_summary_overlapping_answers
From calculated-summary-1 if I click a change link, and then press continue, the url has return_to_answer_id=q1-a1 but it should be None, because this goes back to the cs page anchored at q1-a1 so its not an answer to return to anymore
From the grand calculated summary, I was expecting return_to_answer_id=q1-a1,calculated-summary-1 on the answer page after clicking two change links, similar to how the other params have a list, but instead I only have q1-a1 on the answer, its not following the same pattern as return_to and return_to_block_id (which I think might be what causes the above)

The second issue fixed now (hopefully).

Functionally all working nicely now 👍 Just a couple minor comments And I think there should be a test in test_router similar to the existing ones around multiple block ids for the multiple answer ids (might be able to just edit an existing one)

Added two tests in test_router that hopefully covers it all now.

Changes and coverage all good 👍 The test_router tests test_return_to_calculated_summary_from_incomplete_section, test_return_to_grand_calculated_summary_from_answer and test_return_to_grand_calculated_summary_from_answer_incomplete_section and test_return_to_grand_calculated_summary_from_repeating_answer are all using multiple return tos and return to blocks, but not with your new answer change, and I think it would be good to fix so the tests are more similar to actual usage

This one fixed now, thanks.


Pre-fault pages when allocating memory with mmap().

Otherwise, each page is faulted in on the first write acess, which
negatively affects performance by repeatedly interrupting hot loops.
Category (leave one):

Performance Improvement

Let's see if it influences the performance tests at all. From what I've seen in perf reports, the aggregation should be affected by a couple percent.

Please merge with master for performance test to run.

The regressions are bigger than improvements. The biggest are in queries that materialize constant columns. Since we can overallocate memory for columns by a large margin, populating it does more harm than good. Maybe we should populate only for arenas, which use smaller chunks.

You can populate only for hash tables (adding a flag similar to clear_memory_).

(at least it should fix performance regression for AMD)

Not sure how the POPULATE flag works. But via memory page touching, pre fault can be parallelized

Looking at the performance test results, many DISTINCT queries show an improvement of 5-10%, while some GROUP BY queries regress. The most regressing one is SELECT URL, count() AS PageViews FROM hits_100m_single WHERE CounterID = 34 AND EventDate >= '2013-07-01' AND EventDate <= '2013-07-31' AND NOT Refresh AND IsLink AND NOT IsDownload GROUP BY URL ORDER BY PageViews DESC LIMIT 1000 shows the most regression (x1.15). I compared it to master with clickhouse-benchmark. The pre-fault version is marginally faster, but this difference is deep below the noise:

Version
Queries/second
Spread = q(0.95)-q(0.05)

MAP_POPULATE
20.63
2.64

Normal
20.37
3.64

I rebased to ce73e17ff660aa8ee62aff5bbd4e7e859cfdec12 which is used as performance test reference now, so that we can compare better.

select count(*), count(distinct URL) FROM hits_100m_single WHERE CounterID = 34 AND EventDate >= '2013-07-01' AND EventDate <= '2013-07-31' AND NOT Refresh AND IsLink AND NOT IsDownload;

┌─count()─┬─uniqExact(URL)─┐
│   47740 │          15628 │
└─────────┴────────────────┘

Just in case, checked that this query has a non-empty aggregation set.

I was able to reproduce the improvement for DISTINCT that we see in CI performance test (median QPS for 7 runs of 137 seconds, the runs with different server versions are interleaved):
SELECT DISTINCT URL, ngramDistanceUTF8(URL, 'как дела') AS distance FROM hits_100m_single ORDER BY distance ASC LIMIT 50

┏━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━┓
┃ version       ┃ count() ┃ median qps ┃ spread ┃
┡━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━┩
│ ./ch-prefault │       7 │      0.199 │  0.001 │
├───────────────┼─────────┼────────────┼────────┤
│ ./ch-master   │       7 │      0.185 │  0.001 │
└───────────────┴─────────┴────────────┴────────┘

No meaningful changes for hll12:
SELECT 1 AS k, uniqHLL12(UserID) FROM hits_100m_single GROUP BY k

┏━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━┓
┃ version       ┃ count() ┃ median qps ┃ spread ┃
┡━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━┩
│ ./ch-prefault │       7 │     12.652 │   1.11 │
├───────────────┼─────────┼────────────┼────────┤
│ ./ch-master   │       7 │     12.713 │  0.931 │
└───────────────┴─────────┴────────────┴────────┘

Also seeing a marginal improvement for SELECT SearchEngineID AS k, uniqExact(UserID) FROM hits_100m_single GROUP BY k  (0.58 vs 0.56 qps).
Will merge this now as discussed offline, because we are seeing slight improvements, no regressions and the rationale sounds correct.


HTTP/2 performance optimization

I feel there's some space for optimizations here. I can see some overhead on processing H2 connections.

I can't reproduce slowdown with tiles.

Relevant:
https://github.com/AdguardTeam/CoreLibs/issues/817

Testing instructions: Make sure that sites from #817 are not noticeable slower with AdGuard than without it.


feat: v1.0.0

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove URP component from DynamicCamera prefab

Fixes #322.
In projects using the URP, Unity automatically adds a "Universal Additional Camera Data" component to cameras. This resulted in one ending up on the DynamicCamera prefab, which shows up as a Missing (Mono Script) in other render pipelines. This change removes the component entirely, as Unity will automatically add the appropriate Additional Camera Data component for the current render pipeline.

Thanks @azrogers !


Allow running the test suite with different database configurations.

Right now, all of the unit tests use sqlite:///:memory:, which means it's impossible to run them against a different database without patching the code. We should have a clean way of parameterizing this.

This was fixed by this commit


Integration testing and code fixing

This contains the fixes of some bugs I spotted while testing the endpoints.

Nice


Milestone 1: Project setup

Milestone 1: Project setup
In this PR, I have set up and installed all dependencies for the project
Type of change

[ ] Install react with create react app

Checklist:

[ ]  My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] There is no linter error in my code
[ ]  My changes generate no new warnings

Thank you very much for the time to review my project.


Datapacks do not work with luckperms FABRIC.

Datapacks do not work with luckperms.
Using default settings of luckperms on fabric and datapacks cause datapacks to not be able to load correctly.
When it should work. The commands for the datapacks still exist but they just don't work.
Fabric 1.17.1 most recent build (I think).

LuckPerms Latest for fabric
2021-08-07-5.log

Please open a new issue (and follow the issue template) with full detail if you're still experiencing this issue - it should, however, be fixed in the most recent versions of LP and Fabric


Max Length in Searchbar

I just happened to coincidently pasted a big text into the search bar of my shop and the SQL-Process did slow down the shop completely until I killed the process in PHPMyAdmin.
This especially happens when the search is set to "OR"-method.
Therefore it would be awesome if you can include a maximum length in the normal search functionality in the storefront so that users, as well as bots and hackers don't have the possibility to slow down shops via the search bar.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-34183.
[created from NEXT-34183, comment 485929]

[public] Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know. Thank you again for your valuable feedback.
[created from NEXT-34183, comment 501222]


http 500 in windows system

Cant login using the uasr name and password admin for http 500 in windows system.

Have you had a look through #3, #7, or any of the other issues that link to those two?

Closing due to lack of response.


Defining 'NVT' and 'NVE'

On page 12,  NVT and NVE ensembles are used without being defined.  I don't actually see definitions anywhere in the paper.

Since it's for beginners, these definitions should probably be given.

Great catch, I thought they were in a footnote somewhere, but i do not see any definitions either.

Was an undergrad I gave the paper to that caught it!  He didn't know what they were.  Debugging the code (for the brain).


libxfce4ui: add libICE and libSM as propagated build inputs

Motivation for this change
The packages xorg.libICE and  xorg.libSM are runtime dependencies for xfce.libxfce4ui that was missing in the nix expression. Probably they had somehow been propagated from somewhere else before and now they are not. Without them Xfce does not logout.
Closes #15474
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The Travis build failure seems to be unrelated to this PR. It works well locally for me.

If they are run-time dependencies for this package in particular, propagating them should be unnecessary.

Without propagating these dependencies other Xfce packages (like garcon and xfwm4) fail to compile.

Alright. As long as they are not blindly propagated.

I am still redoing the patches...

... done.