Improve SystemTests execution time

🤔 What's changed?
This PR improves the execution time of Reqnroll.SystemTests.
This is mainly done by two changes.
1.  Use global nuget cache by default
Currently the execution of SystemTests uses a custom local nuget cache.
This results in ~600MB being copied on each SystemTests run (once for all tests).
This is necessary because we create a new nuget package with the same version after each build.
But the global nuget cache doesn't allow to remove a specific nuget package.
Based on https://www.nyckel.com/blog/nuget-packages a custom build target has been introduced to remove the Reqnroll nuget packages from the nuget cache. This allows us to still use the default nuget cache and avoid copying ~600MB.
This results in a speedup from ~1.4 minutes to ~1.2 minutes on my machine.
The old behavior can be enabled by a setting (PerRunNuGetPackages config switch).
2. Allow method-level parallelization
This change allows multiple tests in a class to run in parallel.
This results in a speedup from ~1.2 minutes to ~51 seconds on my machine.
⚡ What's your motivation?
When contributing
🏷 What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻ Anything particular you want feedback on?
I'm not sure if this change should be included in the CHANGELOG.md since it only affects Reqnroll contributors.
Also, during testing, I had some sporadic occurrence of #249,
📋 Checklist:

[ ] Users should know about my change

[ ] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

Oh... Thx for taking care of this...

Based on https://www.nyckel.com/blog/nuget-packages a custom build target has been introduced to remove the Reqnroll nuget packages from the nuget cache. This allows us to still use the default nuget cache and avoid copying ~600MB.

I have also tried that earlier, but dropped because if you have other Visual Studio instances open that use Reqnroll (e.g. exploratory test projects) then the folder deletion is sometimes not possible ("access denied"), because Visual Studio somehow puts a lock on the dll-s from the package. This is pretty random, but happens time to time. If we would simply swallow this error, it would cause some unpredictability but if we let it fail, it will cause build failures (even if you don't run the tests). So my decision was to undo this. 😢 (The speed difference is not that significant.)
(The method level parallelization is fine.)
Maybe what we could do is a mixed approach: we keep a persistent duplicated nuget cache only for the system tests and we only delete our packages from that one. That cache is obviously not used by other VS instances so there will be no lock. What do you think?

When does the lock happen on your machine?
I also sometimes have these locks when I open a project that is generated by the SystemTests (to debug something). But when I close these Visual Studio instances, the lock is gone. Are these the same locks you encountered?
I ask this way because the lock only happens when I use the SystemTests, so a separate NuGet cache folder for all SystemTests would probably not help.
If these are the same locks, I currently see three options

Tolerate the behavior (merge this PR) and advise a workflow such as open a testproject (.sln) and other finish with the debug sessions close the Visual Studio instance.
Support different Reqnroll NuGet packages with the same version. This would probably require a separate nuget cache folder for each SystemTests run. We could optimize this by copying everything we expect from Reqnroll from the global nuget cache folder or from an old SystemTests run. At least then we wouldn't need a stable network connection and could run the SystemTests offline (after the first run).
Try to create local NuGet packages with a timestamp or something like that (e.g. instead of -local we would have -local.20240921115131). This way we logically have different NuGet packages after each run and can use the global nuget cache folder. We would probably have to try to delete the local NuGet cache from the local ReqnRoll NuGet packages to free up disk space. But if that fails, we can ignore it.

@obligaron No. In my case I see the error if I have a normal Reqnroll sample project open in Visual Studio, not the System Tests one. In my case it particularly locks the Reqnroll.MsTest, Reqnroll.NUnit or the Reqnroll.xUnit packages (I mean the dll-s inside).
If it would only happen for debugging the projects generated by system tests, I think that would be acceptable (I usually open these projects in VSCode anyway), but it affects all others. This is why I thought that just having one duplicate for all system tests would be beneficial.

Interesting.
On my machine it also happens that Visual Studio locks the Reqnroll.MsTest folder.
For example I use a old Reqnroll 1.0.0 Version in Visual Studio.
I can't rename or delete \.nuget\packages\reqnroll.mstest\1.0.0.
But I can rename or delete \.nuget\packages\reqnroll.mstest\2.1.1-local.
Perhaps previous the deletion wasn't version specific and it tried to delete \.nuget\packages\reqnroll.mstest. This would fail. 🤔
Can reproduce it with this PR? If yes, I can look into using a persistent duplicated nuget package.

@obligaron I will try to reproduce it and give feedback.

I can reproduce it with your version... 😥
5>------ Rebuild All started: Project: Reqnroll.Tools.MsBuild.Generation, Configuration: Debug Any CPU ------
5>Reqnroll.Tools.MsBuild.Generation -> W:\Reqnroll\Reqnroll\Reqnroll.Tools.MsBuild.Generation\bin\Debug\net462\Reqnroll.Tools.MsBuild.Generation.dll
5>Reqnroll.Tools.MsBuild.Generation -> W:\Reqnroll\Reqnroll\Reqnroll.Tools.MsBuild.Generation\bin\Debug\netstandard2.0\Reqnroll.Tools.MsBuild.Generation.dll
5>Successfully created package 'W:\Reqnroll\Reqnroll\Reqnroll.Tools.MsBuild.Generation\bin\Debug\Reqnroll.Tools.MsBuild.Generation.2.1.1-local.nupkg'.
5>W:\Reqnroll\Reqnroll\Directory.Build.targets(38,5): error MSB3231: Unable to remove directory "C:\Users\gaspar\.nuget\packages\/reqnroll.tools.msbuild.generation/2.1.1-local". Access to the path 'Reqnroll.dll' is denied.
5>Done building project "Reqnroll.Tools.MsBuild.Generation.csproj" -- FAILED.
========== Rebuild All: 4 succeeded, 1 failed, 0 skipped ==========
========== Rebuild completed at 17:08 and took 08.523 seconds ==========

What I did:

Open the CleanReqnrollProject.sln from the repo https://github.com/reqnroll/Reqnroll.ExploratoryTestProjects
This repo uses the 2.1.1-local version of the packages (as it is used to exploratory test the current local version)
Opened feature files, run & debug tests a few times, close & reopen solution
Rebuild Reqnroll Reqnroll.Tools.MsBuild.Generation project
These steps will cause the access denied error approx 1/3 of the cases (I usually have to do it 2-3 times to get the error)

Of course this is a special situation, because normally no one is using the -local version of the packages, but it is painful still.
To be honest, the current status is also not ideal, because currently I have to manually delete the packages from the packages folder if I want to re-test the stuff with my exploratory tests (and sometimes close VS because of the locks). But in many cases I only modify the Reqnroll runtime, so I only need to delete the Reqnroll package, so I am not affected with the locked Reqnroll.Tools.MsBuild.Generation package...
Let me test the System Test execution as well -> I put it to another comment.

Thinking about this a bit more... Maybe all-in-all your optimization has more advantages than disadvantages.
Maybe we could make some optimizations:

One of the problem is that when it tries to delete the packages and fails, the package remains in a half-deleted state and it causes very strange errors if you don't realize what is wrong. Could we maybe do the deletion in a way, that we first just rename the folder (e.g. 2.1.1-local-remove-XYZ where XYZ is just some random text) and only delete if the rename succeeds. Rename is (hopefully) more "atomic". (Or if we want to skip the XYZ part, we would need to first delete 2.1.1-local-remove if exists, then rename the current to 2.1.1-local-remove and then delete the 2.1.1-local-remove.)
Could we maybe introduce another environment variable 😎 and if that is set, the target that suppose to rename/delete the folder would just cause a warning and not an error? Because then I (probably the only person who uses the exploratory test projects that extensively) could set that variable locally and I would not be affected.

What do you think?

Another note (independent of all the others): Two tests from the Reqnroll.TestProjectGenerator.Tests.ProjectTests currently fails (CreateEmptyCSharpCore3_1ProjectInNewFormat and CreateEmptyCSharpNet50ProjectInNewFormat) with '--no-update-check' is not a valid option. As we don't support these frameworks anyway, feel free to delete these two tests.

Of course this is a special situation, because normally no one is using the -local version of the packages, but it is painful still.

Sorry for the misunderstanding. I thought you meant that other versions of reqnroll can be accessed (not the newly build version).

To be honest, the current status is also not ideal, because currently I have to manually delete the packages from the packages folder if I want to re-test the stuff with my exploratory tests (and sometimes close VS because of the locks).

With the new behavior in the good case the manual deletion could be avoided. This would also ensure that the nuget cache and the nuget packages stay in sync.

One of the problem is that when it tries to delete the packages and fails, the package remains in a half-deleted state and it causes very strange errors if you don't realize what is wrong. Could we maybe do the deletion in a way, that we first just rename the folder (e.g. 2.1.1-local-remove-XYZ where XYZ is just some random text) and only delete if the rename succeeds. Rename is (hopefully) more "atomic". (Or if we want to skip the XYZ part, we would need to first delete 2.1.1-local-remove if exists, then rename the current to 2.1.1-local-remove and then delete the 2.1.1-local-remove.)

Sadly at least windows don't allow to rename the folder when a file is locked. 😢

Could we maybe introduce another environment variable 😎 and if that is set, the target that suppose to rename/delete the folder would just cause a warning and not an error? Because then I (probably the only person who uses the exploratory test projects that extensively) could set that variable locally and I would not be affected.

I introduced REQNROLL_ENSURE_NUGET_CACHE_CLEARED. If the variable is set to false MsBuild will only print a warning. 🙂

Another note (independent of all the others): Two tests from the Reqnroll.TestProjectGenerator.Tests.ProjectTests currently fails (CreateEmptyCSharpCore3_1ProjectInNewFormat and CreateEmptyCSharpNet50ProjectInNewFormat) with '--no-update-check' is not a valid option. As we don't support these frameworks anyway, feel free to delete these two tests.

Thanks. I removed them. 👍

Btw: If we revive #64 (which was reversed because of #152), we could avoid the locks in visual studio.
Maybe we could make #64 conditional for windows only?

Thx for the additions.
On reviving #64... this might be a good idea. Let's consider this separately.

Sadly at least windows don't allow to rename the folder when a file is locked. 😢

Yes, that is the point. Maybe I was not clear enough. When it is locked you cannot rename, so it is fully untouched. But with the current behavior, it is deleting half of the files and it stops at deleting the .dll, so what "remains" is a half-existing package in the cache - dotnet restore will not "re-download" it, but it fails because some files are missing.

If we want to ensure that the deletion works, we would probably need something like you suggested ((check old renamed folder exists and delete if present) -> rename -> delete).
But this would require a more complex solution (running custom c# code in msbuild), I'm not sure it's worth the investment because every time the nuget packages are deleted but the cache is not cleared we also have some incorrect/invalid state.
If we are going to go this route would I look at something like UsingTask with RoslynCodeTaskFactory or is there another approach?

@obligaron Why do you think it would need a more complex solution?
What if we would just do a

<RemoveDir Directories="<ourdir>-remove" Condition="Exists('<ourdir>-remove')"  />
<Move SourceFiles="<ourdir>" DestinationFiles="<ourdir>-remove" />  (no ContinueOnError, unless env variable is set!)
<RemoveDir Directories="<ourdir>-remove" ContinueOnError="true" />

Or do I miss something?

I missed that I could check that the rename directory exists in Condition. 😉
So I tried to implement this, but I failed because the Move Task doesn't support moving/renaming directories.
Also MsBuild Property functions doesn't support Directory.Move. 😢
So I tired to implement it with UsingTask and RoslynCodeTaskFactory. This looks to work (at least on my machine 😁). I added it as last commit.

@obligaron oh cool. i give it a try (probably only on Friday) and give feedback.

@obligaron I played with this and found funny things... It seems that in some situations Windows is able to rename the folder even with a lock on it, but then could not delete the renamed files... So I needed to add a bit more try/catch to the solution to somehow handle these. But altogether it works.
I also played with re-introducing the TaskFactory="TaskHostFactory" and it seems that that would indeed solve my exploratory testing issue, but I keep that as a separate PR as that could affect end users as well.


Where can I find flame_static_embedding.pkl?

Now I can run the code examples/load_template.py with SMPL-X and MANO pkl data. But When I try to run FLAME data, I can download male, female, netrual from FLAME website, but I just can't find the related pkl data on the web. Here is the error:
No such file or directory: './smplx_models\flame\flame_static_embedding.pkl'
So the question is where can I find the releated FLAME file?

You can find the static and dynamic embedding files here: https://github.com/soubhiksanyal/RingNet/tree/master/flame_model


Greenkeeper/default/puppeteer 1.12.0

closes https://github.com/sifrr/sifrr/issues/25
Merge when circleci upgrades to Chrome 73

Coverage decreased (-0.8%) to 57.606% when pulling 6411cb6d7960c80109ba80ca2538f755d2f5a1fc on greenkeeper/default/puppeteer-1.12.0 into 5603795a4601c7c6c7048335a9b2ae45016cd6dc on master.


Unit tests block qunit page UI

I discovered that displays that aren't disposed in unit tests can create invisible elements that block UI in scenery unit tests. In correlation with https://github.com/phetsims/scenery/issues/1192, all the test-related displays being created now remove their domElement upon disposal. Here are just a few more.

Spot check from @jonathanolson, and to note that this was a problem (in case we see it again, as it is liable to happen again).

Looks good, thanks!


hare: use epoch first applied block for hare active set

Motivation
follow up on #4997 doing the same for hare active set

bors merge


Add AMD definition

As discussed in https://github.com/mailcheck/mailcheck/issues/90, this PR adds AMD support to Mailcheck.

Thank you @ball-hayden


[Event Request] Table 5080 To do - OnBeforeValidateType

Hi Team,
In table 5080 we need possibility to replace and avoid using standard code with our own. Having event with handling in the beginning of procedure  DeleteAttendeeTask:

    [IntegrationEvent(false, false)]
    local procedure OnBeforeDeleteAttendeeTask(var Todo: Record "To-do"; var isHandled: boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Footer section is static

Describe the feature
I want to add hovering effects for icons and make the footer  section more attractive assign this issue to me @Suchitra-Sahoo
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

issue assigned already


foodsie-local code fails on validating app package with No specific error

Executing Foodsie-local code errors out at following point -
Teams Toolkit has checked manifest(s) with the corresponding schema:
Summary:
All passed.
[2024-09-25T11:44:38.174Z] [Info] - (√)Done: Teams Package c:\Users\rap\Downloads\graph_connector\graph-connectors-samples\samples\nodejs-typescript-food-catalog\appPackage\build\appPackage.local.zip built successfully!
[2024-09-25T11:44:39.183Z] [Info] -
Teams Toolkit has checked against all validation rules:
Summary:
1 failed, 51 passed.
You can check and update your Teams app package at ./appPackage/build/appPackage.local.zip.
(×) Error: undefined
File path: undefined, title: No Supported Products found for the package
A complete log of validations can be found in c:\Users\rap\AppData\Roaming\Code\logs\20240925T154415\window1\exthost\TeamsDevApp.ms-teams-vscode-extension\20240925T101422.log
[2024-09-25T11:44:39.187Z] [Error] - Failed to Execute lifecycle provision due to failed action: teamsApp/validateAppPackage. ManifestValidationFailed:Teams Toolkit has completed checking your app package against validation rules. 1 failed, 51 passed.. Env output: {}
[2024-09-25T11:44:39.191Z] [Info] - Execution summary:
Summary:
(×) Error: Lifecycle stage provision failed.
(√) Done: script(Ensure tables and data) was executed successfully.
(√) Done: Successfully executed command
(√) Done: script(Increment manifest version) was executed successfully.
(√) Done: Successfully executed command
(√) Done: aadApp/create was executed successfully.
(√) Done: aadApp/update was executed successfully.
(√) Done: Applied manifest ./aad.manifest.json to Microsoft Entra application with object id bdad8594-b6cc-496b-909e-ad848c63b3a7
(√) Done: teamsApp/validateManifest was executed successfully.
(√) Done: teamsApp/zipAppPackage was executed successfully.
(×) Error: teamsApp/validateAppPackage failed.
(×) Error: Teams Toolkit has completed checking your app package against validation rules. 1 failed, 51 passed.
(!) Warning: file/createOrUpdateJsonFile was not executed.
(!) Warning: teamsApp/publishAppPackage was not executed.
Attaching log file for reference.
20240925T101422.log

@rp2343 as a workaround you can comment out the teamsApp/validateAppPackage action in the teamsapp.local.yml file, this should unblock you. However, can you share the manifest file being validated? You can find the manifest being validated in appPackage/build folder.


Remove src/app/genesis_ledger_from_tsv

Explain your changes:

Remove an unused non-compiling app genesis_ledger_from_tsv

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[x] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

!ci-build-me


Consider renaming $action to $react for consistency with $intercept

Closed by https://github.com/makeflow/boring-router/commit/d0490b09fec541ee808ea8c928ad1f75ced3eed3


ANGULAR- Filtering by distance thresholds

Not sure if the pre-loaded dataset is molecular or epi data. The node list contains seqs, so I assumed it was molecular. Adjusting distance thresholds breaks the network.
Also, there is no way of seeing which files are loaded in the current session.
![Dist_Threshold.JPG]
(https://images.zenhubusercontent.com/60873227d0d25c1fe3daadb1/a94d8dce-8cb3-400b-b838-1a6c277ba0f6)

Please also note that the histogram for distance cut-off is missing in Angular

Histogram in MT Dev

This is still broken. dropping the distance from 0.015 to 0.014 gets rid of links except one. Also, we need to mention what kind of data the pre-loaded session is, so that people will know what it they have loaded


Reorganise common chapters into subdirectories

The guide is starting to get pretty big (which is awesome!), with loads of traits-*.md and mir-*.md chapters. This just moves the chapters into their own subdirectories.

I assume travis will fail at this point. The link checker says there are currently 67 broken links.

Ping @Michael-F-Bryan
Just want to make sure this doesn't bitrot

@Michael-F-Bryan Ping again :)


Add toCsv for fake collections

The PR adds toCsv method for fake collections to transform collections to csv

Codecov Report

Merging #79 (3a5ab17) into master (baa1bb3) will decrease coverage by 0.17%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
- Coverage     94.46%   94.28%   -0.18%
- Complexity     1518     1519       +1
============================================
  Files           153      153
  Lines          3195     3237      +42
  Branches        321      329       +8
============================================
+ Hits           3018     3052      +34
- Misses          100      104       +4
- Partials         77       81       +4

Impacted Files
Coverage Δ

src/main/java/net/datafaker/FakeCollection.java
86.76% <80.95%> (-9.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa1bb3...3a5ab17. Read the comment docs.


Merge pull request #187 from google/revert-169-gh-pages

Revert "Fix the cpplint.py build/endif_comment check."

Files merged

.patch

Is this branch still relevant? I don't know what it's all about, but it seems to have already been merged in.  Is there a reason we shouldn't just delete this branch?

I'm closing this since it seems like it's just syncing all the changes and hasn't been touched by the original author in 4.5 years.


Fix typos in the AbstractKafkaHeaderMapper

Travis
> Task :spring-kafka:compileTestJava
/home/travis/build/spring-projects/spring-kafka/spring-kafka/src/test/java/org/springframework/kafka/support/DefaultKafkaHeaderMapperTests.java:158: error: cannot find symbol
		mapper.setRawMappedHaeaders(rawMappedHeaders);
		      ^
  symbol:   method setRawMappedHaeaders(Map<String,Boolean>)
  location: variable mapper of type DefaultKafkaHeaderMapper
/home/travis/build/spring-projects/spring-kafka/spring-kafka/src/test/java/org/springframework/kafka/support/DefaultKafkaHeaderMapperTests.java:183: error: cannot find symbol
		mapper.setRawMappedHaeaders(rawMappedHeaders);
		      ^
  symbol:   method setRawMappedHaeaders(Map<String,Boolean>)
  location: variable mapper of type DefaultKafkaHeaderMapper
/home/travis/build/spring-projects/spring-kafka/spring-kafka/src/test/java/org/springframework/kafka/support/DefaultKafkaHeaderMapperTests.java:211: error: cannot find symbol
		mapper.setRawMappedHaeaders(rawMappedHeaders);
		      ^
  symbol:   method setRawMappedHaeaders(Map<String,Boolean>)
  location: variable mapper of type DefaultKafkaHeaderMapper
3 errors

Not sure why that has not been committed...
I see something similar for @Nullable in SI WebFluxRequestExecutingMessageHandler.
Will push shortly there.
But this one has been fixed anyway: see latest commit.


can't use the AndroidStudio plug for the new version

The new version can't use the AndroidStudio plug to  " Generate Butterknife Injections"??

That plugin is developed by someone else. Please file a bug on that project.


api/token/blacklist  not returning message

Hi everyone, It will be better if the mentioned route responses with a message like "Token blacklisted" instead of empty {}

It happens for me too

@Andrew-Chen-Wang @davesque I am newly joined this project and would like to support this project. Is this feature required and can I implement?
Thank you.

Yes @sadeq221 That would be better

Recommend adding a PR for this or tag me if I missed it, thanks. Busy, apologies folks.

hi everybody i fixed this issue on my local but i can't create a new branch and push it repository finally create pull request,
please help me
thanks


Have Identify Project filter use same search results as header search (restricted to projects, of course)

The recent updates to the header search project results have been an improvement, especially for turning up more active large projects that have similar names to past projects. Can we update the Project filter in Identify to return the same project results as the header search?

This is a little more complicated b/c the projects/autocomplete endpoint we're using there does more than just search. It can also exclude projects of certain types, exclude a single project like when you're choosing projects for an umbrella project and you don't want to choose the umbrella itself, etc. What I've done in a branch is to alter the projects/autocomplete endpoint to sort results a little more like the universal search endpoint we use in the header does.
However, it would help me if you can provide some examples of what search queries people are using, what projects they expect to turn up, and what turns up instead. For example, I would expect a search for "city nature challenge 2020" to show https://www.inaturalist.org/projects/city-nature-challenge-2020 as the top result, but instead I get this:

The changes I made fix that specific problem, but it would be good to have more examples to test.

@carrieseltzer provided a concrete example: at https://www.inaturalist.org/projects/home-projects-umbrella/edit, it's currently impossible to add https://www.inaturalist.org/projects/urban-garden when searching for "urban garden" even though it's the second result when using that query in the header search. The changes in https://github.com/inaturalist/iNaturalistAPI/pull/259 make it possible to add that projbect.
Also, I realized my "city nature challenge 2020" example above was kind of idiotic: it doesn't work b/c you can't add an umbrella as a requirement for another umbrella.


Not sure if it's because of this loop...

I'm not sure it's here but ... close to the end it skips some content. Maybe you don't want to show it on the end result (or maybe you do) it skips a lot. If there is a asteroid that zooms by maybe show the line either way just to show it's there?
I'm super interested on the how and where those were.
https://github.com/IIYAMA12/wafs/blob/19e9b719550ddbb2dcc13692731d19e695e6408e/app/static/scripts/index.js#L202

fixed


Allow detectOpenHandles in jest.config.js

Summary

Current if config detectOpenHandles in jest.config.js, validation warning will be thrown:

● Validation Warning:
Unknown option "detectOpenHandles" with value true was found.
This is probably a typing mistake. Fixing it will remove this message.

Resolve warning in https://github.com/nuxt/nuxt.js/pull/3581

LGTM! @clarkdo could you add an entry to the changelog?

As mentioned in another issue (on mobile, so hard to dig up), detectOpenHandles was intentionally not added to config - the performance overhead is pretty bad (30+%). Once the performance overhead is gone (or reduced enough) we'll remove the flag as well and make the behavior the default

@mattphillips Done

Codecov Report

Merging #6747 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6747   +/-   ##
=======================================
  Coverage   63.44%   63.44%
=======================================
  Files         235      235
  Lines        9112     9112
  Branches        4        4
=======================================
  Hits         5781     5781
  Misses       3330     3330
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/valid_config.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7eead1...ebcc568. Read the comment docs.

The related comment that @SimenB mentioned: https://github.com/facebook/jest/pull/6130#issuecomment-386676404

Would love to see this goes in @clarkdo

@SimenB if we document the performance hit, would you be ok to add this to the config?


map keeps blinking

Hi all,
I was happy to find this package. But when I used it, I noticed that google maps keeps blinking. I thought it's because 'exampleMapOptions' is in the 'helpers' section. So there is a Tracker.autorun session related to it. It keeps the map blinking.
Any idea?

Hey can you possibly provide an example project that demonstrates this bug for me to test?

Your map is great, but I'm having the same problem when running it on a device (run ios-device). It constantly "blinks" which I assume is a refresh. The code below replicates the problem. Note, I'm also using the mdg:geolocation package. Any help in figuring this out would be appreciated:
if (Meteor.isClient) {
Meteor.startup(function() {
GoogleMaps.load();
});
Template.map.helpers({
mapOptions: function() {
if (GoogleMaps.loaded()) {
return {
center: new Geolocation.latLng(),
zoom: 15
};
}
}
});
}
if (Meteor.isServer) {
Meteor.startup(function () {
// code to run on server at startup
});
}

No Flashing Map

    {{> map}}

/* CSS declarations go here */
.map-container {
width: 100%;
max-width: 100%;
height: 500px;
}

@lk1234 I believe you're looking for:
    exampleMapOptions: function() {
      if (GoogleMaps.loaded()) {
        var latLng = new Geolocation.latLng();
        return {
          center: new google.maps.LatLng(latLng.lat, latLng.lng),
          zoom: 8
        };
      }
    },

You need to be wary of any reactive values passed into your map options as they will of course cause the map to reinitialize.

Thanks for getting back so quickly. Unfortunately that solution doesn't solve the issue. Still trying to figure it out. I'm working on it, but if you have any ideas...

I would recommend placing Geolocation.latLng(); outside of the helper. Put it in the GoogleMaps.ready callback instead and use map.instance.setCenter()

I think I've encountered this same issue.  Been trying to figure it out, with no success, so I made a tiny sample app to reproduce the problem:
https://github.com/mhurwi/meteor-maps-troubleshooting
Running the app, one map works fine, another reproduces this 'blinking' issue

FYI, figured out, this is an issue with iron-router 'data' being reactive.
Router.route('/shipments/:_id', function () {
  this.subscribe('shipment', this.params._id);
  this.render('shipment', this.params._id);
}, {
  name: 'shipment',
  data: function () {
    return ShipmentsCollection.findOne(this.params._id);
  }
});

https://github.com/mhurwi/meteor-maps-troubleshooting/blob/master/map-troubleshooting.js#L75
Removing 'data' from the route eliminates the blinking.

hey @mhurwi thanks for the recreation, I've noticed this is catching a few people out and I'm questioning now whether the options should really be passed via a helper (since they're reactive). I'll have a look into it and get back to you.

Thanks for the bug report, the issue should be fixed with 1.0.9. Please let me know if the issue is fixed at your end.

@dburles, thanks for rethinking this. (maybe it's nothing more than further explanation in the documentation). I'm still trying to get my map to work...

@lk1234 place reactive functions outside of the map initialization options.  Something like:
Template.map.onCreated(function() {
  if (GoogleMaps.ready('map', function(map) {
    var geo = new Geolocation.latLng();
    var latLng = new googlemaps.latLng(geo.lat, geo.lng);
    map.instance.setCenter(latLng);
  }
});

@dburles, Map fixed. Thank you so much...Used your suggestion above with a Tracker.autorun and it works great. Really appreciate your help and excellent documentation.

This workd all fine but the autorun makes the map to behave blinking in the firefox environment . working great in other browser


Duplicate launcher entries

On the staging hubs, where the pangeo/pangeo-notebook is used as the base image as per https://github.com/2i2c-org/pangeo-hubs/pull/15, some of the launcher entries show up two times, but the environment is the same:

We should probably find a way to get rid of one of these.

@GeorgianaElena ooh, good catch. Let's explicitly uninstall nb-conda-kernels for now, and open an issue about it? I think that's where they're coming from.


DatabInputModal.jsx - Toggle switch state not updating after initial toggle

The state will update on initial click on toggle switch but if you try to untoggle it, the state does not update again and remains the same.
(Inside component DatabInputModal.jsx)
Initial State:

Initial Toggle (see Primary Key in Reactide update):

Retoggled Primary Key back to false but state doesn't update, stays "true":

Resolved.

Resolved.


Implement connection establishment and server startup and shutdown.

RFC=0002

@wally-the-cartographer merge


This library should have way more stars! 🥇

Hey @betula , just wanted to say thank you for this awesome library! ✋
Switching from React Context + useReducer to this library reduced soooo much boilerplate code.
It's much more nice, clean and simple now, plus the bonus of using "useEffect" incapsulated within the state hook is just awesome.
I don't get why this library doesn't have more stars and more popularity. People using useContext+useReducer are really missing out 😃
Thanks!
/ Jesper

Hi Jesper!
Thank you heartily for the warmth of your words. I am very glad that the library finds its application and brings ease to development, abstraction, and code! 🥰
Happy coding 🤗

Have you encountered any difficulties from then @jln-dk ? I've tried and it works pretty well in simple cases. However when working with react-router, when the page is unmounted, the state seems to be lost as well.
For example:
Page A has aBooleanState = true by default. If I'm in page A, toggle aBooleanState to false, then go to page B. When come back to page A I expect aBooleanState to persist the false value. But it's true which is the default.

Here is the codesandbox to reproduce the problem I stated above. @betula

Hi @loia5tqd001,
Nice catch! Thanks!:+1:
I will take it.
And it will be great if you can move it into a new issue. The description of the problem and a link to reproduce on the codesandbox (special thanks for that!).

I could not agree more.  This library makes working with React a joy rather than a pain and it rids my need for Redux.

I was about to install Redux until I found this library and it is a live saver. Really awesome job @betula. I don't know if I ever need to use Redux again haha


Login window will not dismiss in iOS13

I am trying to implement a Twitter login in a new app I am working on using TwitterKit. Everything is working on iOS 11 and iOS 12, but there seems to be problem with iOS 13. After logging in, the webview that logs in is supposed to dismiss, but it just spins at this current screen and does not dismiss. In fact, the loginCompletion it's self never fires, because neither of the print statements never fire. I think it has something to do with the modal presentation.
Expected behavior
Just as it reacts in iOS versions before 13. The login button is created. The user clicks it, the login window should appear, the user will login and the window will dismiss and completion code will run.
Actual behavior
Login button is clicked, the window appears and user logs in. However, the window does not dismiss. The login to Twitter appears to be successful. However the window doesn't automatically dismiss and the completion code does not run.
Steps to reproduce the behavior
This is right out of the box. I used pods to install the kit. Again. Everything works fine in versions of iOS earlier than 13. I posted an issue about this here: https://stackoverflow.com/questions/59653607/twitterkit-login-webview-not-dismissing-in-ios-13

I have the same issue on Xcode 11.
I've noticed that in Twitter Developer account, the twitter app's callback URL should be set twitterkit-<my_key>, but still doesn't work...
Basically, the logInCompletion never got called... I've spend almost a day on this...

I have the callback url set to the same scheme. Won't dismiss.

I have the callback url set to the same scheme. Won't dismiss.

I found iOS 13 sometimes have strange bugs. I'm wondering will this be iOS 13 related.

I'm 99% sure its iOS13. I fired up the code in an iOS 12 and iOS 11 simulator and everything worked fine. I am betting it has to do with the modal presentation.

@bobbydank @weitieda Could you please try the DemoApp in this project to see if having the same issue and are you guys using pod 'TwitterKit5'

Yes. I used pod to install and it installed v5.0.3. The demo app worked, but on a new app created in xcode 11.3.1, the viewcontroller will not dismiss.

Here is a quick project I created for testing this. Webview still did not dismiss.
https://github.com/bobbydank/TwitterKit5Test/
You'll need to input your own key/secret into the info.plist and the appdelegate.swift

@bobbydank
Remove SceneDelegate (or create project with Xcode 10) is a workaround to fix the issue.
The thread here seems to be related.
https://forums.developer.apple.com/thread/121990

Thanks @HackingGate I had that thought, I haven't tried it yet, and I bet that would fix the problem. The kit should still be updated to Xcode 11 because I doubt SceneDelegate is going away.

@bobbydank It turns out that https://github.com/bobbydank/TwitterKit5Test/ use SceneDelegate included in iOS13 and it blocks     func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool.
A quick workaround is adding below function to SceneDelegate
    func scene(_ scene: UIScene,
               openURLContexts URLContexts: Set<UIOpenURLContext>) {
        if let context = URLContexts.first {
            TWTRTwitter.sharedInstance().application(UIApplication.shared, open: context.url, options: [UIApplication.OpenURLOptionsKey.sourceApplication: context.options.sourceApplication as Any])
        }
    }

More detail on SceneDelegate in iOS13
Will fix the TwitterKit later for the SceneDelegate issue.

That fixed it!! Thanks so much Touren!

After upgrade to TwitterKit5 v5.1.0, you can add one line to scene:openURLContexts inside the scene delegate.
    func scene(_ scene: UIScene,
               openURLContexts URLContexts: Set<UIOpenURLContext>) {
        TWTRTwitter.sharedInstance().scene(scene, openURLContexts: URLContexts)
    }

How this would work on react native?

when I tried to login in simulator(iOS 13.5) it works fine but testing device(iOS 13.5) after dismissing app is getting crashed. can anyone tell me quick fix for this or how can we perform twitter login in browser/webview even twitter app is installed in iPhone ?
Fatal Exception: NSInvalidArgumentException
-[NSNull hasPrefix:]: unrecognized selector sent to instance 0x1f76d7c00
hidden#5086

when I tried to login in simulator(iOS 13.5) it works fine but testing device(iOS 13.5) after dismissing app is getting crashed. can anyone tell me quick fix for this or how can we perform twitter login in browser/webview even twitter app is installed in iPhone ?
Fatal Exception: NSInvalidArgumentException
-[NSNull hasPrefix:]: unrecognized selector sent to instance 0x1f76d7c00
hidden#5086

Did you solve this crash? Or did you find a solution for this issue?

when I tried to login in simulator(iOS 13.5) it works fine but testing device(iOS 13.5) after dismissing app is getting crashed. can anyone tell me quick fix for this or how can we perform twitter login in browser/webview even twitter app is installed in iPhone ?
Fatal Exception: NSInvalidArgumentException
-[NSNull hasPrefix:]: unrecognized selector sent to instance 0x1f76d7c00
hidden#5086

Did you solve this crash? Or did you find a solution for this issue?

No I didn't find any solution for that. Do you have any solution for this?

@KiranYechuri @AAlboghdady @Mani-gloify
if twitter kit version below 5 version , we are facing that issue, try to update pod with TwitterKit5
After install TwitterKit5 pod , if version is above 13 or above use sceneDelegate method like
func scene(_ scene: UIScene, openURLContexts URLContexts: Set) {
guard let url = URLContexts.first?.url else {
return
}
ApplicationDelegate.shared.application(
UIApplication.shared,
open: url,
sourceApplication: nil,
annotation: [UIApplication.OpenURLOptionsKey.annotation]
)
    if let openURLContext = URLContexts.first {
        if let context = URLContexts.first {
                TWTRTwitter.sharedInstance().scene(scene, openURLContexts: URLContexts)
            }

    }

}


bug 2233010: replace osd to use new backend store

If osd store is updated in the ceph cluster, then
delete OSDs one by one, cleanup disks and provision a new OSD on the same disk
Signed-off-by: sp98<EMAIL_ADDRESS>(cherry picked from commit 886bb357eff2664dd4368250c7eee9800ba0881e)

Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
[ ] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/approve
/lgtm


Updated CustomerOrder Page ETA

Updated CustomerOrder Page to fix the mistake with the ETA. Fixes #9.

Thank you for submitting this pull request! The changes you've made look good.
If we further work on this project, we could use API to calculate the ETA.


Allow multiple locks on resources based on attribute

What feature do you want to see added?
Adding dynamic attributes to lockable resources would be very beneficial parallelising and speeding up exection by allowing every job who needs resource with same setup to run in parallel.
Use case:

we have 1 lockable resource with label : autotest_server
jenkins job (nr1) want to lock(label: autotest_server), perform long taking setup process: installing and boot backend (8 mins) v1.2.3 and then run test suite A eg: 2 mins
jenkins job (nr2) want to lock(label: autotest_server), perform taking setup process: installing and boot backend (8 mins) v1.2.3 and then run test suite B eg: 2 mins
jenkins job (nr3) want to lock(label: autotest_server), perform long taking setup process: installing and boot backend (8 mins) v1.2.3 and run test suite C eg: 2 mins

As of now they would run sequentially even though all jobs basically require the same machine/installation.

lock() -> job nr1 (10 mins) -> unlock()
lock() -> job nr2 (10 mins) -> unlock()
lock() -> job nr3 (10mins) -> unlock()

If attribute during lock(label: autotest_server, attribute: v1.2.3) was added to the resource, and this attribute would allow lock even if resource is busy. Each job who wants to lock this label and attribute lock(label: autotest_server, attribute: v1.2.3) could reuse the same resource and run in parallel. As per the example above it would be 10 mins of total time execution. Attribute would be removed from the resource when all locks are released.
Upstream changes
No response

I think this would be useful to us as well - I was initially confused by the name attribute, may I suggest assigning an id to a lock? This would become:
So if I understand this feature correctly, when specifying an id when locking:

if there is a candidate satisfying with a matching id, share the lock
if there is no candidate, acquire a new resource and set the id

Yes, Exactly. This feature is very useful if you lock the resource and execute something which takes long time.
At our company we setup lockable resources to mirror prod like "test" machines. And this way we can execute API tests , regression tests and UI tests together in parallel.
I needed to add a little bit of extra logic to the pipelines (kind of semaphore) to perform initialisation only once across different jobs. We are calling a child "setup" job with identical parameters ($param.version) with await = true.
There is no additional steps needed for teardown. Lock will be released and attribute (=key) will be cleaned when last job locking the resource finished.

Sure I can change the naming!
I will fix it in PR https://github.com/jenkinsci/lockable-resources-plugin/pull/303


Decide between ManyToManyField vs MultipleChoiceField

See this CR comment
We currently implement fields with multiple choices in two ways:

MultipleChoiceField (embraced in #197, seen in wanted_assignments) to select between multiple options of a predefined tuple list
ManyToManyField (seen in areas, cities) to connect multiple options of other models which are basically just strings

With cities I think we'd want ManyToManyField so this can be dynamic if we wanted to get that data from an external cities API dynamically every once in a while, but we need to think over this double behaviour (especially in areas & wanted_assignments).
ManyToManyField allows configurability within the admin panel, but MultipleChoiceField doesn't require the initialization to happen in "setup.py" that is obsolete (even though there might be better options to setup.py's functionality)

On hold until new system is stabilized


add keyboard hero

Keyboard Hero

Close #2292

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@pranjay-poddar  Kindly merge it.


Test Automation Script for Map report and Tooltip

Develop the automation script for the map report and validate the tooltip information
The Development is required for visualization app.
QA team will develop the requirement

Completed

Move all the test automation test scripts to the Test Repo -

Scripts are moved to Repo

Completed


brew search --verbose to show short description

Provide a detailed description of the proposed feature
Make brew search -v nvm return results similar to brew search --desc nvm with short description.
Currently --verbose does nothing for brew search.
$ brew search nvm --verbose
==> Formulae
convmv      mvnvm       nvm         nvi         nvc         nim         dvm

It would be awesome if --verbose resulted in the info like this.
$ brew search --desc nvm
==> Formulae
tox: Generic Python virtualenv management and test command-line tool
vfuse: Convert bootable DMG images for use in VMware Fusion

I thought it could be a trivial printing of additional object field returned from https://github.com/Homebrew/brew/blob/6da8630f4e077b38883f6ea57d96e4002f7b8599/Library/Homebrew/search.rb#L77 but it seems to return names as strings, and I don't know how to lookup package data by its name.
What is the motivation for the feature?
Understand if found brew packages are really what I look for.
How will the feature be relevant to at least 90% of Homebrew users?
Yep.
What alternatives to the feature have been considered?
The alternative is to invoke brew info for each found package manually.

The alternative is to invoke brew info for each found package manually.

Or brew search --desc, no?

@MikeMcQuaid  brew search --desc outputs a different set of packages, because it instructs to search in descriptions, and standard brew search matches names.

brew desc --name nvm shows descriptions of packages with names containing "nvm":
convmv: Filename encoding conversion tool
mvnvm: Maven version manager
nvm: Manage multiple Node.js versions

So many commands. I would deprecate brew desc if brew search -v was working. Although brew desc interface looks cleaner, I'd expect it to show output similar to https://formulae.brew.sh/formula/multi-git-status#default (which is shown by brew info).
The --verbose flag is underused in brew. brew commands -v doesn't make the output any different too.

No. --verbose duplicates --name here so I'd review a PR to improve the discoverability of --name.

Just to make sure we are on the same wavelength. You mean that search --verbose duplicates the desc --name, so its not the discoverability of search --name that should be addressed, but the discoverability of desc --name in search --help, right?

Yup!


importing azurerm sql database

hi there,
I ran ".\terraformer-azure.exe import azure -R resourcegroup -r *", terraformer logs it has imported several resources but then hangs on database, the exact log is
021/11/23 11:47:12 Testing if Service Principal / Client Certificate is applicable for Authentication..
2021/11/23 11:47:12 Testing if Multi Tenant Service Principal / Client Secret is applicable for Authentication..
2021/11/23 11:47:12 Testing if Service Principal / Client Secret is applicable for Authentication..
2021/11/23 11:47:12 Testing if Managed Service Identity is applicable for Authentication..
2021/11/23 11:47:12 Testing if Obtaining a token from the Azure CLI is applicable for Authentication..
2021/11/23 11:47:12 Using Obtaining a token from the Azure CLI for Authentication
2021/11/23 11:47:12 Getting OAuth config for endpoint https://login.microsoftonline.com/ with  tenant xxxxxxxxxxxxxxxxxxxxxxx
2021/11/23 11:47:13 azurerm importing... database

Not only that ,CPU and memory usage goes through the roof whilst it has hung.
Any ideas why?

I'm hitting this issue too

This issue still persists, can it opened again please?


Roles attribute not being populated

For the onmessage event, it appears
$message->author->roles where $message is of type  Discord\Parts\Channel\Message
isn't being populated and instead returns null

Could you explain more? Seems to work fine for me:
$discord->on('message', function (Message $message) {
  dump($message->author->roles);
});

Also running into this issue. $message->author->roles turns up as null.

I figured it out @slushpuppy @davidcole1340
For some reason getting a user's roles from a message requires enabling a certain privileged intent.

Presence Intent
If your bot tracks presence data, you may need the presence intent to receive presence event data.
NOTE: Once your bot reaches 100 or more servers, this will require Verification and whitelisting. Read more here

You need to enable the Presence Intent under Developer Settings > (select your bot) > Bot > Privileged Gateway Intents


invalidate provider on widget dispose()

Describe the bug
Error: Bad state: Cannot use "ref" after the widget was disposed.
Any suggestions on how I could invalidate provider on widget disposal ? My real world scenario a bit more complex as my provider depends on another provider and I need to invalidate first one in order to build() method to be called in next initialization, but I've added minimal code to reproduce the issue.
P.S. When I wrap .invalidate(...) with if (context.mounted) provider is not disposed.
Thanks in advance.
To Reproduce
class _TestState extends ConsumerState<Test> {
  @override
  void dispose() {
    ref.invalidate(testSliceProvider);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    ref.watch(testSliceProvider);
    return Container();
  }
}

**Provider:**

@riverpod
class TestSlice extends _$TestSlice {
  @override
  String build() {
    ref.onDispose(() => print('Destroyed TEST SLICE'));
    return '';
  }
}

You shouldn't call invalidate inside State.dispose, as this is a side-effect in a life-cycle called while the UI is building.
Instead call it in the place that causes your widget to be unmounted.


test-branch/execute-job/quoted-authorization/cb6c8553-be3d-47b0-9bce-b1e50b6410ab

PR for testing 3a27500ed228f0a5d25c2a11c36685fbcb933f76

/canonical/self-hosted-runners/run-workflows 3a27500ed228f0a5d25c2a11c36685fbcb933f76


add 2 functions after login

Trying to fix #14
Adding syncFeatures and autoCompleteUserList inspired by Instagram-api.
Currently gives me an error I can't figure out:
panic: Invalid status code {"message": "invalid request", "status": "fail"}
We can take a good look at it here in this PR

functions in implemented in PHP port
public function syncFeatures($prelogin = false)
    {
        if ($prelogin) {
            return $this->request('qe/sync/')
            ->requireLogin(true)
            ->addPost('id', SignatureUtils::generateUUID(true))
            ->addPost('experiments', Constants::LOGIN_EXPERIMENTS)
            ->getResponse(new SyncResponse());
        } else {
            return $this->request('qe/sync/')
            ->addPost('_uuid', $this->uuid)
            ->addPost('_uid', $this->username_id)
            ->addPost('_csrftoken', $this->token)
            ->addPost('id', $this->username_id)
            ->addPost('experiments', Constants::EXPERIMENTS)
            ->getResponse(new SyncResponse());
        }
    }

    public function autoCompleteUserList()
    {
        $this->request('friendships/autocomplete_user_list/')
        ->setCheckStatus(false)
        ->addParams('version', '2')
        ->getResponse(new autoCompleteUserListResponse());
    }

Thank you bro...
After adding to methods , did you have any problem in fetching new feeds ?

Gives me this while Login:
panic: Invalid status code {"message": "invalid request", "status": "fail"}

happens here

@sourcesoft
    public function syncFeatures($prelogin = false)
    {
        if ($prelogin) {
            return $this->request('qe/sync/')
            ->requireLogin(true)
            ->addPost('id', SignatureUtils::generateUUID(true))
            ->addPost('experiments', Constants::LOGIN_EXPERIMENTS)
            ->getResponse(new SyncResponse());
        } else {
            return $this->request('qe/sync/')
            ->addPost('_uuid', $this->uuid)
            ->addPost('_uid', $this->username_id)
            ->addPost('_csrftoken', $this->token)
            ->addPost('id', $this->username_id)
            ->addPost('experiments', Constants::EXPERIMENTS)
            ->getResponse(new SyncResponse());
        }
    }

is not the same as
   _, err = insta.sendRequest("qe/sync/", generateExperiments(), false)
   if err != nil {
     panic(err)
   }

You did not pass csrftoken and etc...

added _uuid, _uid, _csrftoken still getting the exact same error.
experiments=ig_android_ad_holdout_16m5_universe,ig_android_progressive_jpeg,ig_creation_growth_holdout,ig_android_oppo_app_badging,ig_android_ad_remove_username_from_caption_universe,ig_android_enable_share_to_whatsapp,ig_android_direct_drawing_in_quick_cam_universe,ig_android_ad_always_send_ad_attribution_id_universe,ig_android_universe_video_production,ig_android_direct_plus_button,ig_android_ads_heatmap_overlay_universe,ig_android_http_stack_experiment_2016,ig_android_infinite_scrolling,ig_fbns_blocked,ig_android_post_auto_retry_v7_21,ig_fbns_push,ig_android_video_playback_bandwidth_threshold,ig_android_direct_link_preview,ig_android_direct_typing_indicator,ig_android_preview_capture,ig_android_feed_pill,ig_android_profile_link_iab,ig_android_story_caption,ig_android_network_cancellation,ig_android_histogram_reporter,ig_android_anrwatchdog,ig_android_search_client_matching,ig_android_follow_request_text_buttons,ig_android_feed_zoom,ig_android_drafts_universe,ig_android_disable_comment,ig_android_user_detail_endpoint,ig_android_os_version_blocking,ig_android_blocked_list,ig_android_event_creation,ig_android_high_res_upload_2,ig_android_2fac,ig_android_mark_reel_seen_on_Swipe_forward,ig_android_comment_redesign,ig_android_ad_sponsored_label_universe,ig_android_mentions_dismiss_rule,ig_android_disable_chroma_subsampling,ig_android_share_spinner,ig_android_video_reuse_surface,ig_explore_v3_android_universe,ig_android_media_favorites,ig_android_nux_holdout,ig_android_insta_video_universe,ig_android_search_null_state,ig_android_universe_reel_video_production,liger_instagram_android_univ,ig_android_direct_emoji_picker,ig_feed_holdout_universe,ig_android_direct_send_auto_retry_universe,ig_android_samsung_app_badging,ig_android_disk_usage,ig_android_business_promotion,ig_android_direct_swipe_to_inbox,ig_android_feed_reshare_button_nux,ig_android_react_native_boost_post,ig_android_boomerang_feed_attribution,ig_fbns_shared,ig_fbns_dump_ids,ig_android_react_native_universe,ig_show_promote_button_in_feed,ig_android_ad_metadata_behavior_universe,ig_android_video_loopcount_int,ig_android_inline_gallery_backoff_hours_universe,ig_android_rendering_controls,ig_android_profile_photo_as_media,ig_android_async_stack_image_cache,ig_video_max_duration_qe_preuniverse,ig_video_copyright_whitelist,ig_android_render_stories_with_content_override,ig_android_ad_intent_to_highlight_universe,ig_android_swipe_navigation_x_angle_universe,ig_android_disable_comment_public_test,ig_android_profile,ig_android_direct_blue_tab,ig_android_enable_share_to_messenger,ig_android_fetch_reel_tray_on_resume_universe,ig_android_promote_again,ig_feed_event_landing_page_channel,ig_ranking_following,ig_android_pending_request_search_bar,ig_android_feed_ufi_redesign,ig_android_pending_edits_dialog_universe,ig_android_business_conversion_flow_universe,ig_android_show_your_story_when_empty_universe,ig_android_ad_drop_cookie_early,ig_android_app_start_config,ig_android_fix_ise_two_phase,ig_android_ppage_toggle_universe,ig_android_pbia_normal_weight_universe,ig_android_profanity_filter,ig_ios_su_activity_feed,ig_android_search,ig_android_boomerang_entry,ig_android_mute_story,ig_android_inline_gallery_universe,ig_android_ad_remove_one_tap_indicator_universe,ig_android_view_count_decouple_likes_universe,ig_android_contact_button_redesign_v2,ig_android_periodic_analytics_upload_v2,ig_android_send_direct_typing_indicator,ig_android_ad_holdout_16h2m1_universe,ig_android_react_native_comment_moderation_settings,ig_video_use_sve_universe,ig_android_inline_gallery_no_backoff_on_launch_universe,ig_android_immersive_viewer,ig_android_discover_people_icon,ig_android_profile_follow_back_button,is_android_feed_seen_state,ig_android_dense_feed_unit_cards,ig_android_drafts_video_universe,ig_android_exoplayer,ig_android_add_to_last_post,ig_android_ad_remove_cta_chevron_universe,ig_android_ad_comment_cta_universe,ig_android_search_event_icon,ig_android_channels_home,ig_android_feed,ig_android_dv2_realtime_private_share,ig_android_non_square_first,ig_android_video_interleaved_v2,ig_android_video_cache_policy,ig_android_react_native_universe_kill_switch,ig_android_video_captions_universe,ig_android_follow_search_bar,ig_android_last_edits,ig_android_two_step_capture_flow,ig_android_video_download_logging,ig_android_share_link_to_whatsapp,ig_android_facebook_twitter_profile_photos,ig_android_swipeable_filters_blacklist,ig_android_ad_pbia_profile_tap_universe,ig_android_use_software_layer_for_kc_drawing_universe,ig_android_react_native_ota,ig_android_direct_mutually_exclusive_experiment_universe,ig_android_following_follower_social_context&id=8be8aceb5c544c8c8191e86cf6bb30ce&%7B%22_csrftoken%22%3A%22Gi24BfB4TFzf3AiSB1srk74vAheVqmvy%22%2C%22_uid%22%3A%224630791068%22%2C%22_uuid%22%3A%22ac120e12056e44ad9a91bfa3064d5dc0%22%7D

Can you find my mistake?

Salam pooya jan...
            return $this->request('qe/sync/')
            ->addPost('_uuid', $this->uuid)
            ->addPost('_uid', $this->username_id)
            ->addPost('_csrftoken', $this->token)
            ->addPost('id', $this->username_id)
            ->addPost('experiments', Constants::EXPERIMENTS)
            ->getResponse(new SyncResponse());

still is not the same as
   bytes, err := json.Marshal(map[string]interface{}{
    "_uuid":      insta.Informations.UUID,
    "_uid":       insta.Informations.UsernameId,
    "_csrftoken": insta.Informations.Token,
  })

  // Because Instagram app does the same
  _, err = insta.sendRequest("qe/sync/", generateExperiments(string(bytes)), false)
  if err != nil {
    panic(err)
  }

you have to change marshalled json , see
   bytes, err := json.Marshal(map[string]interface{}{
    "_uuid":      insta.Informations.UUID,
    "_uid":       insta.Informations.UsernameId,
    "_csrftoken": insta.Informations.Token,
    "id":         insta.Informations.UsernameId,
    "experiments":GOINSTA_EXPERIMENTS,
  })

   _, err = insta.sendRequest("qe/sync/", generateSignature(string(bytes)), false)
  if err != nil {
    panic(err)
  }

I hope it will work.
And please do not forget to use gofmt for your pulled request codes.
Thank you Mr Pooya

Hello Ahmad jan

still is not the same as

I created a custom method having id and experiments so I didn't add it there. However I now removed the extra-no-used method and did it your way.
It's now giving no error 👍  and fetches but still have the same problem of fetching the old one just like we discussed in the issue.

And please do not forget to use gofmt for your pulled request codes.

Sorry this was my first time contributing to a Go repo 😄  I'm using it now, thank you.

After a few tests it's now giving me a new error
panic: Invalid status code {"message": "Sorry, too many requests. Please try again later.", "status": "fail"}

panic here:
_, err = insta.sendRequest("friendships/autocomplete_user_list/?version=2", "", false)
if err != nil {
	panic(err)
}

This is weird

After a few tests it's now giving me a new error

Few month ago I was a contributor of python version of unofficial instagram api.
A lot of users tell us that have the same problem in syncFeatures and autoCompleteUserList.
You can search over issues with query "429 error code".
https://github.com/LevPasha/Instagram-API-python/issues/64
So after I saw that , I decided to make goinsta without those methods.
Now we have same problem as Instagram-API-python.
Github user , mgp25 is a advanced user in instagram api with a lot of knowledges about it.
I think if we implement setCheckStatus in goinsta we can fix this error.
Really I don't know what the hell is going on in the Instagram :smile:

_, err = insta.sendRequest("friendships/autocomplete_user_list/?version=2", "", false)
if err != nil {
	panic(err)
}

I think if you check err value and do the same as PHP version , the bomb will be defuse :dancer:

@ahmdrz Just did some coding and added an optional extra bool at the end of args, looks cool and works without any errors now reacting to checkStatus like PHP.
This looks good and doesn't hurt if we merge but we still have the original problem of not fetching the old feed. I think problem goes beyond these 2 methods.

This looks good and doesn't hurt if we merge but we still have the original problem of not fetching the old feed. I think problem goes beyond these 2 methods.

Maybe ...
Thank you Mr Pooya... :heart:
If you detect source of problem , tell me ...
Regards

@ahmdrz following the issue here: https://github.com/mgp25/Instagram-API/issues/955 asking PHP maintainers.


Added selection sort

What does this PR do?
Selection sort in java
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines?
Yes

@shibin340 Thank you for your contribution. Keep Contributing!

Give a star if you liked our repo.


Adding ngCacheBuster causes errors with videogular templates

I see those errors:
http://localhost:8080/app/vg-templates/vg-media-video?cacheBuster=1526950831109 404 (Not Found)

angular.js:13708 Error: [$compile:tpload] http://errors.angularjs.org/1.5.7/$compile/tpload?p0=vg-templates%2Fvg-media-video&p1=404&p2=Not%20Found

Closing the issue as this library is clearly no longer maintained.


Deprecated syntax in gifti/subsref.m?

This line creates warnings in newer Matlab versions:
https://github.com/gllmflndn/gifti/blob/master/%40gifti/subsref.m#L45
Warning example, form the Brainstorm user forum:

Do you need these () for anything here?

Hello @ftadel,
Thanks for reaching out. Yes, the () are there for a reason: when cdata contains a memory-mapped object (@file_array). I'm already aware of this compatibility issue and the code has been fixed upstream in SPM where @gifti is taken from. I'll try to make a new release of this class soon. The change is:
-            varargout{1} = varargout{1}() + 1; % indices start at 1
+            varargout{1} = full(varargout{1}) + 1; % indices start at 1

I pushed a number of of rather substantial changes that should fix your issue among other things. It would be great if you could test this new version and let me know if you observe any bug or unexpected side effect.


Detected file that's the same in both x64 and arm64 builds

Running universal via electron-forge package --arch=universal results in the following error message:
An unhandled rejection has occurred inside Forge:
Error: Detected file "Contents/Resources/app/node_modules/lzma-native/prebuilds/darwin-arm64/electron.napi.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "undefined"
Any thoughts on how to handle this?  Appreciate the help.

I have the same problem with 7zip-bin, which is pulled in by electron-updater. The simple fix in @electron/universal would be to detect if the two files are identical (e.g., sha check) prior to calling lipo, and if they are, just copy the first file. I don't think there is any work around for this just now.

Any resolution for this issue? I am using electron forge.

Same issue appears to happen when building a universal app that uses fsevents native module.
Detected file "Contents/Resources/app/node_modules/fsevents/fsevents.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "undefined"

I'm also getting the fsevents file detected as duplicate when including chokidar.  Any direction on how to resolve this?

Same issue appears to happen when building a universal app that uses fsevents native module.
Detected file "Contents/Resources/app/node_modules/fsevents/fsevents.node" that's the same in both x64 and arm64 builds and not covered by the x64ArchFiles rule: "undefined"

Try this inside your forge config if you are using electron forge -
module.exports = {
...previsousConfigs,
osxUniversal: {
mergeASARs: true,
x64ArchFiles: "*",
},
}

@navdeepm20 I hid your comment as it is incorrect and will result in folks having broken apps.
The issue here folks is that you are packaged a "universal" app but the fsevents.node native module is only being built for one architecture.  This warning means that you aren't rebuilding native modules for the correct architecture.
In some cases (like in the original issue's case) this is expected behavior and requires you to allowlist the file as the path Contents/Resources/app/node_modules/lzma-native/prebuilds/darwin-arm64/electron.napi.node is clearly architecture specific and is supposed to be the same in both files, I would assume there is an equivalent darwin-x64 path as well.
In the fsevents case it's simply that the module isn't being rebuilt for some reason, you may need to appropriately integrate @electron/rebuild into your build process or use a tool like Electron Forge which does this for you

I think moving chokidar/fsevents (depending what you use) to dependencies from devDependencies solved it for me and made @electron/rebuild rebuild it correctly for every arch.

@navdeepm20 I hid your comment as it is incorrect and will result in folks having broken apps.
The issue here folks is that you are packaged a "universal" app but the fsevents.node native module is only being built for one architecture. This warning means that you aren't rebuilding native modules for the correct architecture.
In some cases (like in the original issue's case) this is expected behavior and requires you to allowlist the file as the path Contents/Resources/app/node_modules/lzma-native/prebuilds/darwin-arm64/electron.napi.node is clearly architecture specific and is supposed to be the same in both files, I would assume there is an equivalent darwin-x64 path as well.
In the fsevents case it's simply that the module isn't being rebuilt for some reason, you may need to appropriately integrate @electron/rebuild into your build process or use a tool like Electron Forge which does this for you

Hello @MarshallOfSound how do we tell to build for each architecture? I created yesterday the issue https://github.com/electron/universal/issues/76 and I believe it is more or less the same problem. In my case drivelist seems to be built for x86 and I have arm64. So how should I tell electron/universal to build for x86 and arm64? Thank you in advance and regards

The issue here folks is that you are packaged a "universal" app but the fsevents.node native module is only being built for one architecture. This warning means that you aren't rebuilding native modules for the correct architecture.

@MarshallOfSound I don't think that's what the problem is; fsevents.node is a universal binary so it's same for both x86 and arm64. lipo -create can't be called on universal binaries (no point), and if you do, it errors with 'the same architectures' error. It unhelfully only reports the first architecture in the universal binary, so it's not immediately obvious it is actually two identical universal binaries you are trying to combine. The fix for this would be to check if the file is a univeral binary (lipo -archs) before trying to combine it.

After adding  { from: './lib', to: 'extraResources'  },  error
Any thoughts on how to handle this? Appreciate the help.


Do not override communicate

Hi :wave:!
Generally, overriding communicate is discouraged. However, the current implementation is also broken.

'__RELATIVE_TO_FOLDER__' is not used directly, and since SL4 is coming really, really not necessary.

elif not code: matches the empty string. Generally, bc you use STDIN you MUST assume code is never None here. So, this whole branch should actually never match.

os.path.splitext(filename) actually returns a tuple (name, ext). So the following code throws. The author assumes here it returns just the 'ext'. (So, the correct code would be _, fileext = os.path.splitext(filename), but as I said the whole if branch should be unreachable.

Bug report https://github.com/SublimeLinter/SublimeLinter/issues/1030

@kungfusheep do you perhaps want to transfer this repo to the SublimeLinter org so we have more people maintain it? To do so, please transfer this repo to me and I’ll complete the move.

@kungfusheep I'm replicating this repo into the SublimeLinter org because I kinda need it personally and we would like to improve it. If you want more information about that, please let me know.


implemented GET '/products/:product_id'  request

implement GET '/products/:product_id'  request

added getFeatures method
added  getProductInfo method

Looks good!


Physical Mapping

This creates a physical memory mapping system that can be used similar to that of the ACPI crate. It allows us to treat a physical address as a struct and allocate it on the heap.

Will test this out

All constructors of PhysicalMapping should be unsafe I believe.


Add max / min validation rules

Description
This pr adds min - max laravel rules to filament field rules
you can now validate the max/min values of a field like
TextInput::make('name')->max(10) //check for max chars allowed
TextInput::make('name')->min(3) // check for min chars allowed
TextInput::make('name')->min(function () use ($calculatedValue) {
                    return $calculatedValue;
                })

FileUpload::make('avatar')->max(3072) // checks for max size allowed in kb
FileUpload::make('avatar')->min(1024) // checks for max size allowed in kb

Code style

[ ] composer cs command has been run.

Testing

[x] Changes have been tested.

Documentation

[x] Documentation is up-to-date.

We have maxLength() / minLength() / maxSize() / minSize() already, alongside frontend validation.


support rails 5

summary

support rails 5

Coverage remained the same at 100.0% when pulling 4aa138f01a7b0dc5f66e8ad5b5dc64385b97cc6f on features/rails5 into da65df61e6a0f1aede65e0249b6d4271e967853c on master.


⚠ ClamAV has degraded performance

In 31b3932, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in f8dad9b.


Android application keeps stopping

I recently had this issue:

I followed this tutorial https://auth0.com/docs/quickstart/native/react-native-android and it looks like react-native-lock uses an older version of react-native.  We are currently on version 38 the latest; around version 29 MainActivity and MainApplication were separated so this section does not really work for the current state of react-native.

I changed the Main Activity Code to what is shown below:
public class MainApplication extends Application implements ReactApplication {
  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
    @Override
    protected boolean getUseDeveloperSupport() {
      return BuildConfig.DEBUG;
    }
    @Override
    protected List<ReactPackage> getPackages() {
      LockReactPackage lockReactPackage = new LockReactPackage();
      lockReactPackage.addIdentityProvider(Strategies.GooglePlus, new GooglePlusIdentityProvider(MainApplication.this));
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
            new VectorIconsPackage(),
            new MapsPackage(),
            new ReactNativeI18n(),
            new RNDeviceInfo(),
            new RNSvgPackage(),
            new OrientationPackage(),
            lockReactPackage,
            new ReactNativeConfigPackage()
      );
    }
  };

  @Override
  public ReactNativeHost getReactNativeHost() {
      return mReactNativeHost;
  }
}

Currently the Application works on iOS but on Android after doing the updates to get it to work with the google play services and installing the SHA-1 keys that are stored in the google-services.json it will build but it fails immediately in the emulator as shown below:

Has any one else had this issue? I am going to do more debugging but any suggestions would be greatly appreciated thanks.

@seacloud9 we are going to need the exception trace from android to see why it crashed. It could even be an error unrelated to lock

@hzalaz thanks found the issue I had everything todo with the way google services were being initialized I changed my gradle.build (app) dependencies to the following and it worked.
dependencies {
    compile project(':react-native-lock')
    compile project(':react-native-orientation')
    compile project(':react-native-svg')
    compile project(':react-native-vector-icons')
    compile project(':react-native-maps')
    compile project(':react-native-i18n')
    compile project(':react-native-device-info')
    compile project(':react-native-config')
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile 'com.auth0.android:lock-googleplus:2.3.+'
    compile 'com.google.android.gms:play-services:9.0.0'
    compile 'com.google.android.gms:play-services-auth:9.8.0'
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
}

Thanks

Just clean your build in Android Studio and then rebuild your project then run.
You will get some file path or some package that you called is missing. You will see that on terminal and emulator.

@hzalaz thanks found the issue I had everything todo with the way google services were being initialized I changed my gradle.build (app) dependencies to the following and it worked.
dependencies {
    compile project(':react-native-lock')
    compile project(':react-native-orientation')
    compile project(':react-native-svg')
    compile project(':react-native-vector-icons')
    compile project(':react-native-maps')
    compile project(':react-native-i18n')
    compile project(':react-native-device-info')
    compile project(':react-native-config')
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile 'com.auth0.android:lock-googleplus:2.3.+'
    compile 'com.google.android.gms:play-services:9.0.0'
    compile 'com.google.android.gms:play-services-auth:9.8.0'
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
}

Thanks

@seacloud9 I am facing this same issue and I do not understand how to resolve it. The above code you added to your build.gradle (app), does it manually compile some of these dependencies? If so, why should you manually compile them when running the app automatically installs and extracts the packages in your code when you import these packages?
Could you further elaborate on how having those compilation statements prevents the app to suddenly stop (the way it is shown in the screenshot)?
Thanks.

@farhankassam2 it has been a while since I had this issue.  I believe it happens when there is a dependency mismatch.  I would spend some time looking at your packages also make sure the private keys its need is set up properly.


Add GitHub Actions V2 workflow example

The second version of GitHub Actions, "now with world-class CI/CD", was announced on 2019-08-08. It is now in public beta and is slated for general availability to all users very soon on 2019-11-13.
As part of this upgrade, the original version of GitHub Actions workflows and its HCL-like syntax are also considered deprecated and support for them will be removed in the near future.
As such, it would be best to feature the new YAML workflow syntax in your Action's README example! 🎉

If you don't like how any part of this reads, feel free to edit it directly. 👌

Thanks James! Did you get a chance to test that suggested config, to ensure it works? I was just wondering, as I expected a few changes might have been required? I’d also be happy just to drop the Actions v1 support altogether.

@toolmantim Yes, I am actively using that configuration in an Actions V2 Workflow. Although there are new changes available in Actions V2, it is also a guarantee that every V1 Action will remain compatible with V2. The main changes are all to the workflow definitions, not to the Action capabilities. 👌
Workflow configuration:
https://github.com/github/learning-lab-components/blob/1b0453f9f0a2b2275fd39a8996594e798518d922/.github/workflows/release_management.yml#L13-L16
Example output:
https://github.com/github/learning-lab-components/commit/1b0453f9f0a2b2275fd39a8996594e798518d922/checks
I'll go ahead and remove the Actions V1 section from this PR. :+1:

Amazing! Thanks so much @JamesMGreene 👍🏼 This is ready to rumble then.


Watch tasks (admin/storefront) and HTTPS only domains/servers

Hi,
in the company I work for, we switched to using local development with domains/servers with HTTPS and a valid certificate as that is also what the customers will use. In our case it is a *.dev domain which means it is ONLY reachable using HTTPS as the whole TLD is HTST configured to forward to HTTPS.
The watch tasks, however, assume that the domain/server is using HTTP. The only solution for now was to create a local alias that is only HTTP but that also means I have to configure all sales channels with multiple domains which is kind of annoying. It is also not possible to somehow fake the domain in this case due to the HTST forward which means all assets are requested using HTTPS from the asset port (e.g. storefront).

No, i don't use a proxy! Nor do i forward anything! Why?

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37871.
[created from NEXT-37871, comment 488525]

Reference

NEXT-37871 - Update hot reload server logic to make it work for http and https
NEXT-38982 - Fix watch storefront multi saleschannel with multi theme


Wi-Fi password

I can't tell if this was an accident or not. If not, there is no way for someone to solve your issue without knowing anything about it. This is just clogging up the issue list.


Since 0.12.0, Mix generates a strange "mix.js" file - and sourcemaps no longer save at all

Laravel Mix Version: 0.12.0
Node Version:
NPM Version:
OS: macOS 10.12.5

Description:
Since updating to Mix 0.12.0 (from 0.8.1 - so a bit of a jump), I'm having two issues:

Mix now saves a mysterious mix.js file in my public directory. I didn't ask it to save this, and it doesn't seem to be documented anywhere what this might be. Can anyone shed some light?

Sourcemaps refuse to generate when I run npm run development.

Steps To Reproduce:
Here's a copy of my webpack.mix.js file. Note that I've removed calls to .sourceMaps() as it should be doing it automatically within 0.12.0 - but even adding the calls in again makes no difference.
const { mix } = require('laravel-mix');

// Copy public assets to their required directories
mix.copy('resources/assets/theme/src/fonts/', 'public/fonts/theme/')
   .copy('resources/assets/theme/src/img/', 'public/images/theme/');

// Compile Bootstrap to CSS
mix.sass('resources/assets/scss/bootstrap.scss', 'public/css');

// Compile LESS files to CSS
mix.less('resources/assets/less/app.less', 'public/css')
   .less('resources/assets/less/error.less', 'public/css');

// Compile JS files
mix.js('resources/assets/js/app.js', 'public/js')
   .js('resources/assets/js/calendar.js', 'public/js');

// Version the files
mix.version();

When I run npm run development, I get the following output:
$ npm run development

> @ development /Users/Jack/Sites/test
> cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

Copying resources/assets/theme/src/fonts/ to /Users/Jack/Sites/test/public/fonts/theme
Copying resources/assets/theme/src/img/ to /Users/Jack/Sites/test/public/images/theme
 95% emitting

 DONE  Compiled successfully in 8162ms                                                                                4:01:45 PM
                                                                                Asset       Size  Chunks                    Chunk Names
                                                /js/calendar.3c5e380f28bc99bd45fa.js     1.2 MB       1  [emitted]  [big]  /js/calendar
  fonts/vendor/font-awesome/fontawesome-webfont.eot?674f50d287a8c48dc19ba404d20fe713     166 kB          [emitted]
  fonts/vendor/font-awesome/fontawesome-webfont.ttf?b06871f281fee6b241d60582ae9369b9     166 kB          [emitted]
fonts/vendor/font-awesome/fontawesome-webfont.woff2?af7ae505a9eed503f8b8e6982036873e    77.2 kB          [emitted]
 fonts/vendor/font-awesome/fontawesome-webfont.woff?fee66e712a8a08eef5805a46892932ad      98 kB          [emitted]
                                                     /js/app.1fce339324094af80ab0.js    2.33 MB       0  [emitted]  [big]  /js/app
  fonts/vendor/font-awesome/fontawesome-webfont.svg?912ec66d7572ff821749319396470bde     444 kB          [emitted]  [big]
                                                         mix.77b0eb5aeec9949d352e.js    3.42 kB       2  [emitted]         mix
                                 /css/bootstrap.16c01c655b211fc41291e58b2649fc28.css     646 kB       2  [emitted]  [big]  mix
                                       /css/app.a3618561e8c7a35e16e8605c956456b2.css     580 kB       2  [emitted]  [big]  mix
                                     /css/error.bdeb09837bd96d9389c0ad9a3a7d6883.css     358 kB       2  [emitted]  [big]  mix
                                                                   mix-manifest.json  376 bytes          [emitted]

So what is this mix.77b0eb5aeec9949d352e.js file getting saved in the public directory? That's only started appearing since the upgrade. Then, why aren't sourcemaps being generated? If I run npm run production, they're saved just fine.
Thanks in advance.

Try reorder mix.js first, then mix.sass/less/stylus after that. See #719

@imsus Thanks - reordering my webpack.mix.js file like so fixes the mix.js file being created:
mix.js('resources/assets/js/app.js', 'public/js')
   .sass('resources/assets/scss/bootstrap.scss', 'public/css')
   .less('resources/assets/less/app.less', 'public/css')
   .less('resources/assets/less/error.less', 'public/css')
   .copy('resources/assets/theme/src/fonts/', 'public/fonts/theme/')
   .copy('resources/assets/theme/src/img/', 'public/images/theme/');

However, sourcemaps still aren't being generated 😢

The next version of Mix fixes the ordering bug.
You're not getting sourcemaps because you didn't do mix.sourceMaps();

@laracasts (@JeffreyWay ?) That's not quite the case - I'm pretty sure this is a bug. This is on both v0.12.0 and v0.12.1.
Can this issue be re-opened? I've included as much info below as I can...

Regarding the lack of mix.sourceMaps() - I didn't think we had to use that any more? v0.12.0's release notes imply source maps are generated by default, but I might be misunderstanding. Nonetheless for the examples below I've included it.

I've tried cutting down my webpack.mix.js file to the bare minimum, just to see if it works:
mix.sourceMaps();

mix.js('resources/assets/js/app.js', 'public/js/app.js');

When I run npm run development, here's what I get back:
$ cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

DONE  Compiled successfully in 2415ms

            Asset       Size  Chunks                    Chunk Names
       /js/app.js    7.41 MB       0  [emitted]  [big]  /js/app
mix-manifest.json  528 bytes          [emitted]
✨  Done in 3.99s.

As you can see no source map files are ever created. I've also tried chaining the .sourceMaps() call to the end of .js(...), but still no luck.
However - when I do npm run production - with the Mix file as above - I get sourcemaps! This is for both the full original copy of webpack.mix.js I posted in my first comment, and for my simplified version for testing:
$ cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js

DONE  Compiled successfully in 45771ms

            Asset       Size  Chunks                    Chunk Names
       /js/app.js    1.26 MB       0  [emitted]  [big]  /js/app
   /js/app.js.map    1.31 MB       0  [emitted]         /js/app
mix-manifest.json  528 bytes          [emitted]
✨  Done in 47.26s.

Any further ideas...? I've tried deleting node_modules and reinstalling all packages too, but still no luck...

It's the 'cheap-module-eval-source-map' in src/Api.js.
In Production it uses 'cheap-source-map'.  (https://github.com/webpack/webpack/issues/3165 and https://github.com/webpack/webpack/issues/2145 seem related)
But I haven't found a solution...


LICENSE

Hi!
On the http://colorsublime.com/ site you state that all the themes are under the MIT license, which is great!
"This project is build by developers for developers and all the available themes are under the MIT license"
The package.json also refers to the MIT license on line 19.
  "license": "MIT",

The LICENSE file that is checked in is not the MIT license however.  Could you please update this file to be the MIT license?
Thanks,
Chris

@GianlucaGuarini, do you approve?

:+1: @blopker  thanks


Problem (bug) with youtube-dl with videos on 1080p

Hello everyone.
My message will be "small", I think. ^^
First, sorry for mistakes, I'm french.
I've a problem (or a bug) on youtube-dl executable, on windows.
All videos are successfully downloaded... excepted in 1080p.
The video, in 1080p, is successfully downloaded, but without sound.
I use command prompt, with this line :

youtube-dl.exe -f 137 https://www.youtube.com/watch?v=YIwuCs1Yovw

(code format 137 for 1080p)
The video is successfully downloaded.... but without sound.
I use command prompt again, but with this line :

youtube-dl.exe -f 22 https://www.youtube.com/watch?v=YIwuCs1Yovw

(code format 22 for 720p)
The video is successfully downloaded.... and with sound.
If the bug has been already posted, sorry.
Or maybe my command line is wrong.
Can you help me, please. ;)
Thanks by advance.
Best regards, thomas.

Hi, based on the output of -F in your url, 137 is 'video only' format
137          mp4        1920x1080  DASH video 4133k , avc1.640028, 24fps, video only, 45.75MiB
As you can see above, there is video only, that means it does not have audio.  You need to combine it with one of the audio formats:
249          webm       audio only DASH audio   58k , opus @ 50k, 896.00KiB
250          webm       audio only DASH audio   80k , opus @ 70k, 1.14MiB
171          webm       audio only DASH audio  110k , vorbis@128k (44100Hz), 1.75MiB
140          m4a        audio only DASH audio  127k , m4a_dash container, aac  @128k (44100Hz), 2.32MiB
251          webm       audio only DASH audio  143k , opus @160k, 2.21MiB
141          m4a        audio only DASH audio  255k , m4a_dash container, aac  @256k (44100Hz), 4.66MiB

So for example, you want the format with code 141, your command goes like this:
youtube-dl -f 137+141 https://www.youtube.com/watch\?v\=YIwuCs1Yovw
For windows:
youtube-dl.exe -f 137+141 https://www.youtube.com/watch?v=YIwuCs1Yovw
Let us know if it works.

Hi.
Thanks, really ! :+1:
It works great.
I've  downloaded ffmpeg too.
Topic solved.
Best regards


Remove PageScrollBar @ Editor Page

I want to work on this

Hey! Is there any problem? I made changes accordingly in #806
Do you want to revert this ?


Output from SSH command that fails should be printed

$ docker-machine create ...
Creating SSH key...
Creating Digital Ocean droplet...
Error creating machine: exit status 255
You will want to check the provider to make sure the machine and associated resources were properly removed.

This isn't particularly helpful. It should probably be something like this:
$ docker-machine create ...
Creating SSH key...
Creating Digital Ocean droplet...
Error running command "sudo -E apt-get update" on the Machine. Here is the output:

---------------------------------
... error ...
---------------------------------

You will want to check the provider to make sure the machine and associated resources were properly removed.

+1

I'm all for storing / showing more information in the case of an error, although I think we need to think about the approach a bit.  Generally where I'm headed is towards having a docker-machine logs command which stores anything which gets logged by Machine in flight (including all debug output) to a log file on disk (just like docker logs), and that is something which can be queried later by the user, or by us if we want to selectively show things like above.
Bear in mind that there are many cases in Machine where things like SSH commands could fail and it is perfectly fine and normal (e.g. the SSH command timed out so we want to re-try it), so implementing this kind of thing without also spewing "undesirable"/scary error messages at the user is a little trickier than it may look at first glance.

Update:  I may have been a bit hasty.  I think that the "good" SSH failures (testing if SSH is up / working) are largely exit code 255, so perhaps the proposed solution in my PR might work OK for now.


Training code or references for training the latent diffusion model on a custom dataset

Hello! Thank you for your fantastic work!
I'm currently working on training the latent diffusion model using a custom dataset. I noticed that the repository doesn't include the training code for this specific model. Could you kindly share the training code or provide any references that would be suitable for training the latent diffusion model within the context of this repository?
Your guidance would be greatly appreciated!

Have find the suitable training code?We can have a communication. Thanks a lot!

I wonder if there's any code that already works with the custom dataset, and if so, let me know and I'd appreciate it


Updated changelog.md

Updated changelog as per the right order of release

Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/752


Make SimulationEngine.log_simulation_state() useful

save it in a debug log, or some other useful format.

log_simulation_state was removed


Clarify that Grafana's /metrics endpoint is in 4.6, not 4.5

Clarify that Grafana's /metrics endpoint is in 4.6, not 4.5 - it's unfortunately still in beta... ¯_(ツ)_/¯

The prometheus endpoint landed in 4.5.1, although the changelog states that it's part of 4.6.0-beta1.
The problem here is that 4.5.1 introduced a breaking change and the metric structure changed completely, so this exporter will not work when using grafana >= 4.5.1.

Ah, interesting... Thanks @frodenas - that explains why the exporter isn't working with our 4.5.1 deployment. I had some trouble getting the new endpoint to work with 4.5.1 and made an assumption ;)


Can't disable external command line

After upgrading to 0.3.0 I noticed the external command line was too disruptive for my workflow.
I tried using the instructions at the wiki but no success so far.
How can I disable it?
Btw, I think it's a great idea, but the position and current look distract from the content of the editor.

Looks like the Wiki hasn't been updated for the new values....
They moved out of experimental so you should just use the following:
    "commandline.mode": false,
    "commandline.icons": false,
    "wildmenu.mode": false,

Thanks @CrossR, I was going to update the wiki but noticed you got ahead of me :-).

Sweet, thanks for updating the wiki @CrossR  👍


Feature suggestion: Provide a comma-separated list of assemblies to be internalized

See https://github.com/peters/ILRepack.MSBuild.Task/issues/2

I think you implemented this by letting the user specify a filename after the /internalise command-line parameter, of a file which contains lines of text, which are regexps which specify the names of types which shouldn't be internalised.
BUT I think you didn't update the README.md which documents the command-line parameters ... the README currently only says,
- /internalize         sets all types but the ones from the first assembly 'internal'


Import error in 4.4.0

I am getting an error in this package on the following line in jsonschema/_format.py:
from __future__ import annotations
The error I get is:
SyntaxError: future feature annotations is not defined

What version of Python are you on?

This is in a Docker container using ubuntu:18.04 base image; the apt version of python is 3.6.9. There was a similar issue I found here: https://github.com/altdesktop/python-dbus-next/issues/10


The Naive W8A8 Quantized model accuracy of medium size model (e.g opt-2.7b)

I tried to use Naive W8A8 method (quantize_model method only, dynamic scale) to quantize a 2.9 b gpt model，and found that the ppl is 15.1 which is closed to fp16 ppl (14.6).  In your smoothquant_opt_demo.ipynb, the Naive W8A8 accuracy is very slow. Is this because of dynamics quantization?
Thank you very much.

I have found relative results from your paper

I have found relative results of your paper

Have you tried using static quantization for W8A8

In our paper, the W8A8 setting uses dynamic activation quantization (Table 3). Generally speaking, static quantization should be lossier than dynamic quantization.

In your smoothquant_opt_demo.ipynb, the Naive W8A8 accuracy is very slow. Is this because of dynamics quantization?

I am not sure what you mean by the quantizer slow here. I assume you mean the large accuracy degradation? In the smoothquant_opt_demo.ipynb notebook, we use OPT-13B model to show the accuracy degradation of the W8A8 method. You can replace the model_name with facebook/opt-2.7b to check the performance of the naive baseline on the 2.7B model. From my side, the naive W8A8 method does work pretty well on the opt-2.7B model.


Feature request: open graph on new window/export graph as image

Seeing large graphs inside joplin is a little messy...

Not sure this is the good place to say it but this would be really interesting for my research if I could export my graph

Concur, this would be a super helpful function. Exporting the Link Graph at will is probably preferable to watching/waiting on it to update in real-time.


Use Scala Map, Set, Bag for Identity and Equality

It's probably not a good policy to merge ones on PRs, but I'll do it shortly.  I've decided to run a regression test first.

The extra regression and round-trip tests passed.


Feat all uppercase plugin

[New Plugin] all uppercase plugin

Plugin that gives a true verdict if all characters in a sentence/text is uppercase.

Related Issues: (optional)

#515

Hey @VisargD , any update on this?
I am waiting for this to get merged, I am looking to work on all other plugins once this is merged (and if any changes are required, I will know it from this PR and will not repeat it for other plugins)

Hey @shaun-ak. Sorry for the delay. I had one last suggestion. Can we add this to the default plugin directory instead of creating a new plugin? This is a deterministic checks so it fits well with other default plugins.

Sure, will do that. Thanks.

Hey @VisargD , I moved the plugin to default, please re-review.

Hey @VisargD , fixed it, please re-review.


Get/Set Volume properly

As of now, volume can be set to unknown arbitrarily high values and the user will never know.
See the get volume function that has to be fixed.
If I get it to work, I can

show the current volume
restrict the volume with lower and upper bounds

I worked around this by managing volume via file now.


changed websocket-samplers download URL from bitbucket to github, bec…

…ause the bitbucket download returns filename in quotes, which leads to failing install

Great. Works fine now. Thanks.


SW-5089 Global roles allow searching accelerator orgs

Allow users with appropriate global roles to read organization and project
data for organizations with the Accelerator internal tag via the search API.
This changes the behavior of the search API for privileged users! Previously,
it would only return results from the user's organizations, but now it can
also return results for other accelerator organizations. This won't affect
any searches that explicitly filter on project or organization ID, but will
affect unconstrained searches.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1797  👈
#1790 : 1 other dependent PR (#1791 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Mar 25, 2:11 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.