Inference: own data

Hi,
I just had a few questions regarding using our own data and running inference using PENet pretrained weights.

How sparse can the depth map be?
Currently, my inference image is from the Kitti360 dataset which is quite similar to the previous kitti that the network was trained on. But there is no GT depth to sample the depth from. So my sparse depth map is quite sparse.
When I run inference on this image, the prediction is also sparse i.e I have prediction only in the regions covered by the sparse depth map. Is this an expected behaviour?

What should my input be for 'positions' (i.e the cropped image), I don't want to crop the images for running inference, so should I just set input['positions'] = input['rgb']?

It would be great if you can answer these questions when time permits :)
Regards,
Shrisha

Thanks for your interest!

The one-frame sparse depth maps as inputs are of about 5% density of all pixels while the groundtruth depth maps are of 15%. The groundtruth data are generated by accumulating 11 sequential frames. For details of the KITTI Depth dataset, you could refer to [Sparsity Invariant CNNs] by Dr. Uhrig. If you do not want to manually generate groundtruth depth maps for KITTI 360, you could refer to [Self-supervised Sparse-to-Dense: Self-Supervised Depth Completion from LiDAR and Monocular Camera] by Dr. Fangchang Ma for self/un-supervised learning in depth completion.

You do not need to change the 'positions' since they represent positional encodings as prior for computer vision tasks.

Feel free to let me know if you have further questions.

Thank you for your quick reply.

So the ground truth depth maps with 15% sparsity are used as supervision? I see, so if the supervision is with sparse depth of 5% density then this is not expected to work, right? Thanks for the references, I will check them immediately.
Ah, but when I run PENet_C2 to evaluate, what should the input['positions'] be?

Thank you for your quick reply.

So the ground truth depth maps with 15% sparsity are used as supervision? Thanks for the references, I will check them immediately.

Current setting: sparse depth map has 5% density of all pixels, but I use the same for supervising the network. So if I understood it correctly, the supervision of the groundtruth depth maps need to be at least 15% correct?
Details of inference: model - PENet_C2 ; penet_accelerated = True ; dilation rate is 2; convolutional-layer-encoding = 'xyz' ; H = 192, W = 704 (I also changed the respective lines here
Here is an example result --> do you think this is the expected result?

Ah, but when I run PENet_C2 to evaluate, what should the input['positions'] be?

One important feature of GT depth maps is that in some local regions the annotation could be much denser than the average density of 15%. This indicates that the denser the GT depth maps are, the better results the trained model will predict. So there is actually no accurate limitation of GT density.

Using the same maps for supervision is not sufficient. To alleviate this problem, you need to generate denser GT
depth maps or deploy un/self-supervised methods.

The positional encodings do not need to be changed. If you don't like them, you could set --co to std when executing training commands. But in our pretrained models, the default settings are used.

Okay I understand regarding the sparsity for training.
But I am still unsure about what the positional encodings are because I am preparing my own data, so is there a flag for evaluation? I understand --co to --std is for training right?

Okay I understand regarding the sparsity for training.
But I am still unsure about what the positional encodings are because I am preparing my own data, so is there a flag for evaluation? I understand --co to std is for training right?
I can see in model.py that u & v coordinates of input['position'] are used, but I am still not sure what the positional encodings are or how they can be created for my own data.

You could refer to [An intriguing failing of convolutional neural networks and the CoordConv solution] by Liu for more details about positional encoding. In our default settings, we use the geometric encoding (ie. 3d coordianates) described in our paper. And the evaluation and training process should share consistent settings.

 I still get a patchy result like [this]{https://drive.google.com/drive/folders/1d-maw_Yrix_JoHldWCof8v1Mwx2rLvs6?usp=sharing} when I evaluate, are you able to analyze what else may possibly go wrong or maybe sensitive?
(I am just using the pretrained weights to evaluate on this data)

I get it now, I was able to create the positional encoding (u, v coordinates using the camera intrinsic). I still get a patchy result like this when I evaluate, are you able to analyze what else may possibly go wrong or maybe sensitive?
(I am just using the pretrained weights to evaluate on this data)

Intuitively I guess the GT maps are not dense enough for supervised depth completion. GT maps are reuqired to be much denser than the sparse inputs.

But we dont need GT maps in this case where we just evaluate.
The result that I've shared here is not based on fine-tuning but merely test_completion

But we dont need GT maps in this case where we just evaluate. The result that I've shared here is not based on fine-tuning but merely test_completion

I think two points could be taken into consideration:

The sparse depth maps in KITTI360 seem denser than the ones we use in KITTI depth. This means that there exists domain gaps between those two datasets, leading to the failure of predicted results. We suggest that you could
(i) Construct denser GT maps in KITTI360 for further training or finetuning. This step is necessary for transfer learning. Or
(ii) Consider depth completion methods with "Sparsity Invariance", which aims at countering the instability brought by unknown and varying density. You could refer to [Sparsity Invariant CNNs] by Uhrig or [A Normalized Convolutional Neural Network for Guided Sparse Depth Upsampling] from our group. Recently, this topic has been discussed in [Boosting Monocular Depth Estimation with Lightweight 3D Point Fusion] as well.

A secondary reason is that: Not all pixels in the predicted depth map are reliable. You could refer to a previous issue for this.


Question: Information about project plan for hygon csv?

I saw Hygon CSV in the support list of CoCo-AS, but I couldn't find it in the support lists of CoCo-KBS or CC-KBC.
Of course, eventually KBC/KBS/AS will be unified into the same framework.
Do CoCo-KBS and CC-KBC have any release plans for Hygon CSV?

Overall CCKBC and KBS is in platform independent design. It will call relative TEE attester/verifier plugins to do TEE specific things, s.t. get evidence (AA/cckbc side) and verify evidence(KBS/CoCoAS side).
Current releases of CoCoAS/KBS already supports to verify hygon evidences. However we still do not have a release at cckbc/AA side, as on other platforms they will be built in a guest image which is released.
More details probably @jialez0 @baoshunfang could help

Overall CCKBC and KBS is in platform independent design. It will call relative TEE attester/verifier plugins to do TEE specific things, s.t. get evidence (AA/cckbc side) and verify evidence(KBS/CoCoAS side).总体来说CCKBC和KBS是平台无关的设计。它将调用相关的 TEE 证明者/验证者插件来执行 TEE 特定的事情，s.t.获取证据（AA/cckbc 方）并验证证据（KBS/CoCoAS 方）。
Current releases of CoCoAS/KBS already supports to verify hygon evidences. However we still do not have a release at cckbc/AA side, as on other platforms they will be built in a guest image which is released.当前版本的 CoCoAS/KBS 已经支持验证 hygon 证据。然而，我们仍然没有在 cckbc/AA 方面发布，因为在其他平台上，它们将构建在已发布的来宾映像中。
More details probably @jialez0 @BaoshunFang could help更多细节可能会有所帮助

Thank you, and best wishes.


Makefile,drivers: Switch to using gofmt -s and correct areas where it does not pass

same @abhinandanpb

nvm, more gofmt issues. I'll fix now.

There's a few remaining in utils/driverfactory.go

this should probably be merged before anything else; reason being is that if someone merges in code this gofmt command will break on, it will break master.
(the rest of my patches are not critical)

LGTM.


Use radiometry image to mask rays

If a black pixel is inside the aperture region, then it is assumed to have accumulated zero retardance from the voxels it transversed. However, sometimes the pixel is black simply because no light could even reach that pixel in the experimental configuration.

Mostly addressed with commit https://github.com/PolarizedLightFieldMicroscopy/GeoBirT/commit/0eb713f664f8a4fb27aa4c7c531c0f0cfd936637, except there is an issue with supersample != 1 for experimental images when a radiometry path is not provided.


Shared stack between calls

This is an experiment for a shared stack between calls. Let me know what you think about it and if it is feasible to bring it in!
The model is very similar to last one developed in #445 (with checkpoints), although there are some differences for the allocation strategy.
Allocations
There are three different strategies here:

do one single 32MB allocation -> we've seen with the shared memory that this approach is not good and overkill most of the times
check for capacity at every push operation in the stack -> does the minimum amount of memory allocations, however it adds a small but non-negligible overhead for push operations, which results in a performance regression in a very stress test like the snailtracer bench
ensure a capacity of STACK_LIMIT every time you enter new context -> Although this is very similar to what happens normally (i.e., on new context we allocate space for the stack), it still keeps peak memory usage allocated for next contexts and allows for faster unsafe operations, reducing push operations overhead. This is the approach I kept after all the experiments

Performance
I managed to keep regression to the minimum, however benches don't really the shared stack at all. Even bench_eval on the snailtracer remains always on the same context, therefore the shared mechanism doesn't apply well.
There is of course a minimum of overhead because this abstraction ain't free, but it seems feasible.
analysis/transact/raw   time:   [8.2504 µs 8.3154 µs 8.4299 µs]
                        change: [+2.8469% +3.7488% +4.8213%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
analysis/transact/checked
                        time:   [8.2338 µs 8.3507 µs 8.4382 µs]
                        change: [+1.0517% +1.9726% +2.9546%] (p = 0.00 < 0.05)
                        Change within noise threshold.
analysis/transact/analysed
                        time:   [5.6613 µs 5.6720 µs 5.6838 µs]
                        change: [+0.6835% +2.5449% +4.1668%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

snailtracer/transact/analysed
                        time:   [67.868 ms 68.022 ms 68.191 ms]
                        change: [+12.395% +13.393% +14.409%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
snailtracer/eval        time:   [61.284 ms 61.386 ms 61.590 ms]
                        change: [+0.6965% +5.5300% +9.5800%] (p = 0.03 < 0.05)
                        Change within noise threshold.

transfer/transact/analysed
                        time:   [1.2470 µs 1.2484 µs 1.2505 µs]
                        change: [+6.3084% +6.6428% +6.9314%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) high mild
  6 (6.00%) high severe

You can check performance with cachegrind and docker like this: https://github.com/bluealloy/revm/issues/797
and additionally, we should write the proper perf test for this. There is maybe bytecode that we can reuse from eth/tests: https://github.com/ethereum/tests/tree/develop/GeneralStateTests
There are fillers that are more readable: https://github.com/ethereum/tests/tree/develop/src/GeneralStateTestsFiller/stCallCodes

You can check performance with cachegrind and docker like this: #797
and additionally, we should write the proper perf test for this. There is maybe bytecode that we can reuse from eth/tests: https://github.com/ethereum/tests/tree/develop/GeneralStateTests There are fillers that are more readable: https://github.com/ethereum/tests/tree/develop/src/GeneralStateTestsFiller/stCallCodes

I agree regarding a proper performance test for this. We need to choose something that goes up and down in call depths to have a proper picture of the gains of this setup.
In the meanwhile, I tried with cachegrind as you said (thanks, I'll keep that mind for the future). Here are the results on my machine:

main https://github.com/bluealloy/revm/commit/1dcebc43f09893cd1520bf097b1e91ef9daf990b -- 482,459,263
shared_stack https://github.com/bluealloy/revm/pull/816/commits/6c4acdf5fe780a5206980fe1310af4aade1797c1 -- 529,105,196

Therefore yes there is still some work to do to bring down regression when this is not used

Hey @rakita, I tried to task on the ethereum/tests repository about a stress test but the suggestion was to write a custom one.
In the meanwhile I tried to implement this approval transfer bench: even if it does not reach a huge depth it loops over context changes, therefore I thought it could be good to see how it performs over those.
Here are the result (cargo bench --all against main 0d78d1eb304a2ce41ddac8f03206f5a316af247b):
approval_transfer/transact/analysed
                        time:   [4.7078 µs 4.7261 µs 4.7508 µs]
                        change: [+10.900% +12.297% +13.797%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
approval_transfer/eval  time:   [55.583 ns 55.690 ns 55.817 ns]
                        change: [-84.656% -84.591% -84.545%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

Regarding the custom test is there something in particular you had in mind?

left a few ideas that could improve the PR, I like the page system and new context, but I wanted to check how loop call will look so we can integrate this inside it so I apologize for the long overdue review.

Thanks for the feedback and no problem for the overdue!

Hey there, I pushed some changes regarding the free and taken pages model. Also, now both stack and memory are under a SharedContext struct.
I still need to address some of the comments regarding UB and upstream sync, will do it shortly!

Hey guys, I resolved some comments to clean this up: is there something left to do? More perf tests? Right now perf isn't ideal if you remain always in the same context. Maybe I can try to use the pointer to the top of the stack as @rakita said

Hey @rakita, I've seen that EvmBuilder PR is merged. Great work!
I tried to take a look at the changes and I was wondering if it makes sense to take a look at this from scratch, if you feel a shared stack would be beneficial for this evm.
Both the pages model can be revisited (imo, it seems that a more complex strategy that allocates less is worse than a simpler one with more allocations) and also the SharedContext doesn't seem to play too nicely with the current setup. An example is passing manually SharedContext taken from the interpreter to sub_create and down to other functions such as insert_create_output which is currently used by inspector logic too.

Hey @rakita, I've seen that EVM Context-Builder PR is merged. Great work!
I tried to take a look at the changes and I was wondering if it makes sense to take a look at this from scratch, if you feel a shared stack would be beneficial for this evm.
Both the pages model can be revisited (imo, it seems that a more complex strategy that allocates less is worse than a simpler one with more allocations) and also the SharedContext doesn't seem to play too nicely with the current setup. An example is passing manually SharedContext taken from the interpreter to sub_create and down to other functions such as insert_create_output which is currently used by inspector logic too.

Thanks @lorenzofero!
My view of shared context is we want it is some way, I am open to new ideas, but just to say this is very low priority, as there is no impact by doing this.

Closing this as I think it should be re-visited from scratch. Might do that in the future but I'd prefer to focus on other contributions on revm, time permitting :)

Closing this as I think it should be re-visited from scratch. Might do that in the future but I'd prefer to focus on other contributions on revm, time permitting :)


Encode effort 10 missing from encoder

I just compiled a recent version of cjxl (JPEG XL encoder v0.9.0 ed027ed5 [AVX3], this commit 5e222241cb6a2630fc2f4356b21b448088125bde), and the recently added encode effort level 10 isn't available. Has it been removed? It's still referenced in the docs as a setting in the encoder.

You need to use cjxl --allow_expert_options -d 0 -e 10. Be warned: it is very slow.


Removed check for ensemble when training best pipeline

Fixes #1931

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Perf tests: https://alteryx.quip.com/ZXV4AcYh5eVc/Best-Pipeline-Ensemble-training-on-whole-dataset-Performance-Tests

I'm turning this back into a draft PR because I can't confirm that Ensembling is running for these performance tests. I need at least 50 iterations and unfortunately every job I've tried to run with it hasn't finished. I'll be looking for another way around this.

I've decided to run with limited model families to reduce the iterations, this should result in a run while still allowing ensembling to take place


Add experimental Interactive Element example scene + example scripts

Overview

Added an example scene + example scripts to Interactive Element
Added a null check to State Visualizer
Added checks to catch a null ref in Interactive Element

Script Placement Location
The example scene + example scripts are placed in this directory to make sure the example scripts are not included in a Unity 2018 build since these features are only supported in Unity 2019.

Changes

Fixes: #8883

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run

/azp run


Release automanage 673

https://github.com/Azure/sdk-release-request/issues/673

Closing as per https://github.com/Azure/sdk-release-request/issues/673#issuecomment-689632589


Don't call location service when cookie consent status is dismiss

Once Cookie Consent message has been display and agreed by a user, location service should not be called again and again.
Can we skip calling location service once cookieconsent_status == dismiss ?
PS: In addition, can't we also store the location in cookie as a location service cache?

Fully agree. Most of these geo ip services have limits and contigents in their free plans. So let's not waste these resources needlessly.

Wow, this is pretty bad. A fix has been made and will be available in the next release


Fingerprint DB schema against stored hash

It would be great if the verify command could detect schema drifts caused by manually executed DML on the given DB. This could be archived by extracting meta data after baselining or after each applied patch, hashing this information and store this hash in the schema_version table.
In an advanced version configurable table data could be added for hashing as well to detect changes in configuration data.

Thank you for your suggestion. However this is both complex to implement and opposite to the ideas of disciplined database changes Flyway encourages.
This is not something I see as part of the core product anytime soon. However I can see how this could be useful in certain organizations.
Feel free to reopen and provide a PR if you want to tackle this (it's a huge task for all DBs).
Cheers
Axel

Maybe you could provide an interface or callback to hook in a sql to produce this hash.


Socket error when using with Azure SQL

I'm using sequelizejs which uses tedious to handle the sql server interactions. After going through the sequelize source code, i've enabled debug on tedious and here's the following output.
connected to my-azure-sql-db.database.windows.net:1433
State change: Connecting -> SentPrelogin
State change: SentPrelogin -> SentTLSSSLNegotiation
TLS negotiated (ECDHE-RSA-AES256-SHA384, TLSv1/SSLv3)
State change: SentTLSSSLNegotiation -> SentLogin7WithStandardLogin
State change: SentLogin7WithStandardLogin -> ReRouting
Packet size changed from 4096 to 4096
connection to my-azure-sql-db.database.windows.net:1433 closed
Rerouting to subdomain.tr2.southeastasia1-a.worker.database.windows.net:11197
State change: ReRouting -> Connecting
connected to my-azure-sql-db.database.windows.net:1433
State change: Connecting -> SentPrelogin
connected to my-azure-sql-db.database.windows.net:1433
State change: Connecting -> SentPrelogin
State change: SentPrelogin -> SentTLSSSLNegotiation
State change: SentPrelogin -> SentTLSSSLNegotiation
socket ended
State change: SentTLSSSLNegotiation -> Final
socket ended
State change: SentTLSSSLNegotiation -> Final
connection to my-azure-sql-db.database.windows.net:1433 closed
State is already Final
connection to my-azure-sql-db.database.windows.net:1433 closed
State is already Final

The above log is from a CentOS 7.2 VM on Azure. The connect event is also never fired. I've enabled all outbound traffic & have also allowed the VM's IP in SQL server firewall.
NodeJS - 4.4.3
Tedious - 1.14.0
The connectionConfig passed into tedious from sequelize
{ userName: 'username',
  password: 'password',
  server: ' my-azure-sql-db.database.windows.net',
  options:
   { port: 1433,
     database: ' my-azure-sql-db',
     encrypt: true } }

Just verified that this error is happening only on the latest V12 server. Is this a bug or something specific to my instance? I see there are similar issues to this but already closed & patched.


Clunky formatting when reading picks.csv with pandas or csv

The picks.csv output from PhaseNet contains some clunky formatting that requires the user to perform several string manipulations to properly format the itp, tp_prob, its, ts_prob columns.
I will show an example of reading the csv with pandas although reading the csv with the csv package runs into the same formatting issues . I will also share the function I had to make to correctly format the entries.
Pandas
import pandas as pd
df = pd.read_csv('output/picks.csv')

The result is a dataframe containing strings in the itp, tp_prob, its, ts_prob columns.
print(df['itp'][0])
>>>  '[   1 6620 8114]'

print(df['ts_prob'][0])
>>>  '[ 0.11291095  0.31720835  0.06021817]'

The values are not uniformly separated either which means the str.split() method can't be applied to convert the string into a list. Ideally, the csv would contain a uniform, comma-separated list of values. Another solution would be to also save a pickle file to the output directory that contains the lists in object form.
To fix the formatting with the current picks.csv, I made the following function:
import shlex
import pandas as pd

df = pd.read_csv('output/picks.csv')

def pickConverter(df):
    for col in ['itp', 'its']:
        pick_entry_list = []
        for x in range(len(df)):
            try:
                pick_entry_list.append(list(map(int, shlex.split(df[col][x].strip('[]')))))
            except AttributeError:
                pick_entry_list.append([])
                pass
        df[col] = pick_entry_list

    for col in ['tp_prob', 'ts_prob']:
        prob_entry_list = []
        for x in range(len(df)):
            try:
                prob_entry_list.append(list(map(float, shlex.split(df[col][x].strip('[]')))))
            except AttributeError:
                prob_entry_list.append([])
                pass
        df[col] = prob_entry_list
    return df

Thanks for the suggestion! I have updated the csv format without extra spaces. I have also added a pickle format which could be directly loaded for post processing. #11


Replace browser-request with superagent

Coverage increased (+0.7%) to 94.313% when pulling adf977817b8ea758c5cb40d3ab273311366c222b on isocolsky:ref/superagent into c985d550110b216e04cb20fe82d5252a29875385 on bitpay:master.

Great work! Once we merge it we need to check that handlers the errors in the right way with the new system.


winget should list and prefer MS Store variants of apps

Description of the new feature/enhancement
I just installed Spotify using winget.
Opening MS Store a bit later, Spotify showed up in recommendations.
Not paying too much attention I clicked install, which apparently got rid of the earlier installed winget package (not a bad thing) and installed the MS Store variant of spotify instead(different package name).
I got kinda confused and I am under the impression that winget should prioritize MS Store variants and/or prompt the user.

for windows terminal and powershell, I am deliberately wanting for winget version as the store version, as the msstore version are installed for users only. Some package like notepad++, I cant find which folder it belongs to. avoid msstore is exactly the reason i find winget.

I was just honestly looking for an option to permanently exclude all msstore apps and to always pick winget as a source. I don't ever plan to open up the Microsoft Store (for my own reasons, which aren't important or relevant to this issue), and I find it tedious to try to winget install _____ and have 2 options, and have to either spell out the full Id or append -s winget at the end. It would be nice to just be able to save a list of excluded sources into my $PROFILE file, and then have less tedium while installing apps.

I was just honestly looking for an option to permanently exclude all msstore apps and to always pick winget as a source. I don't ever plan to open up the Microsoft Store (for my own reasons, which aren't important or relevant to this issue), and I find it tedious to try to winget install _____ and have 2 options, and have to either spell out the full Id or append -s winget at the end. It would be nice to just be able to save a list of excluded sources into my $PROFILE file, and then have less tedium while installing apps.

 Thank you for pointing that out to me. I didn't know that was an option. Thanks!

I was just honestly looking for an option to permanently exclude all msstore apps and to always pick winget as a source. I don't ever plan to open up the Microsoft Store (for my own reasons, which aren't important or relevant to this issue), and I find it tedious to try to winget install _____ and have 2 options, and have to either spell out the full Id or append -s winget at the end. It would be nice to just be able to save a list of excluded sources into my $PROFILE file, and then have less tedium while installing apps.

Have you tried removing the msstore source?
winget source remove msstore

Thanks bro 🙏🏻


DisplayServer.window_set_mode has several issues [MacOS]

Godot version
4.1.1.stable, 4.1.2.stable
System information
MacOS Ventura - Apple M2 Max - Metal 3 - Compatibility Renderer
Issue description
There are serious problems with changing window mode through DisplayServer's window_set_mode function.

https://github.com/godotengine/godot/assets/13417391/da8a0aaf-4970-477c-b304-484a52f28431
https://github.com/godotengine/godot/assets/13417391/9d0824f8-0a66-4317-9832-e2f6f4b8a19c
There are several cases of unexpected behavior. More in steps to reproduce.
Steps to reproduce
Test 1:
Window -> Maximized -> Window
CORRECT
Test 2:
Window -> Maximized -> Fullscreen
The window behaves oddly between Maxmized -> Fullscreen mode change. It looks like it's going to window mode between maximized and fullscreen.
INCORRECT
Test 3:
Window -> Maximized -> Exclusive Fullscreen
Same as Test 2.
INCORRECT
Test 3:
Window -> Maximized -> Fullscreen -> Window
Window has correct size.
CORRECT
Test 4:
Window -> Fullscreen -> Exclusive Fullscreen
Instead of going from Fullscreen to Exclusive Fullscreen it goes back to Window.
INCORRECT
Test 5:
Window -> Fullscreen -> Exclusive Fullscreen -> Window
Then after changing to Window, it goes to fullscreen
INCORRECT
Test 6:
Window -> Fullscreen -> Exclusive Fullscreen -> Window -> Exclusive Fullscreen
Then after changing to Fullscreen it goes back to window.
INCORRECT
Minimal reproduction project
window_mode_issue.zip

The window behaves oddly between Maxmized -> Fullscreen mode change. It looks like it's going to window mode between maximized and fullscreen.

That's expected, otherwise it won't be able to restore window size when exiting full-screen.

The window behaves oddly between Maxmized -> Fullscreen mode change. It looks like it's going to window mode between maximized and fullscreen.

That's expected, otherwise it won't be able to restore window size when exiting full-screen.

Yes, but it should go to small window size and then to maximized. There shouldn't be an in between size, as I imagine it.

The window behaves oddly between Maxmized -> Fullscreen mode change. It looks like it's going to window mode between maximized and fullscreen.

That's expected, otherwise it won't be able to restore window size when exiting full-screen.

It's also not restoring window size on WINDOWS when you selected maximized before.
I mean Window logically should be a small window.
Window_Maximized should be the maximized window.

I've fixed the maximized->fullscreen->windowed mode bug specifically for Windows here: https://github.com/godotengine/godot/pull/84504/files
Pretty trivial fix.  I'm assuming the same logic error exists for Mac as well (else if (p_mode == WINDOW_MODE_WINDOWED) just needs the else removed), but I don't have a mac to build and test on.  If any mac devs want to make a contribution, this should be an easy one! :)

I'm assuming the same logic error exists for Mac as well (else if (p_mode == WINDOW_MODE_WINDOWED) just needs the else removed)

This will break switching maximize → fullscreen → window switch (macOS do not have real maximized state, so exiting full-screen will return it to previous window size).


Change in chairs

Signed-off-by: Matt Raffel<EMAIL_ADDRESS>Due to some changes out of my control, I will step away from co-chair of this group.  Looking forward to continuing to work with the group; hopefully start of y2023

Hey @matt-raffel-kiva -- could you also make the change here https://github.com/AnonCreds-WG/anoncreds-spec/blob/main/spec/header.md?  You may want to add your name to the Acknowledgements list -- https://github.com/AnonCreds-WG/anoncreds-spec/blob/main/spec/acknowledgements_authors.md.
Thanks!

sure thing
On Mon, Jun 27, 2022 at 1:52 PM Stephen Curran @.***>
wrote:

Hey @matt-raffel-kiva https://github.com/matt-raffel-kiva -- could you
also make the change here
https://github.com/AnonCreds-WG/anoncreds-spec/blob/main/spec/header.md?
You may want to add your name to the Acknowledgements list --
https://github.com/AnonCreds-WG/anoncreds-spec/blob/main/spec/acknowledgements_authors.md
.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/AnonCreds-WG/anoncreds-spec/pull/53#issuecomment-1167814820,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMQKHPCXL2T4T4ASZK747LLVRIBAHANCNFSM5Z7JYE5Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Transient Data.fetch network failure leads to false positive test failures

[FAILED] URI: [21/22, 1697ms]
 INFO ide_ci::program::command: bash ℹ
 INFO ide_ci::program::command: bash ℹ     - [FAILED] should correctly handle various characters within the key and value of arguments [244ms]
 INFO ide_ci::program::command: bash ℹ         Reason: An unexpected dataflow error ((IO_Error http://localhost:19653/get?q4=%C5%9Bnie%C5%BCnobia%C5%82y&q5=%22f%22%27%27+%3B+%F0%9F%9A%80%F0%9F%9A%A7a&q6=%5Ba%3Db%5D%3A%5Bb%3Dc%5D%5Bd%3De%5D%2B%2B%2B%2B%21%3F%26-%3E%23...__%28%29%7B%7D%40%2F%2F%2F%5C%5C%5C%7C%25%25%25100*%5E%2C+%5D%5D%5D+%3D%3D%3E+%3Cbr%3Ea&q7=&q8=+&q9=%25%25%25&q10=%0A%0A%09 'An IO error has occurred: java.io.IOException: closed')) has been matched (at /Users/runner/work/enso/enso/test/Base_Tests/src/Network/URI_Spec.enso:158:13-157).
 INFO ide_ci::program::command: bash ℹ         at <enso> HTTP_Error.type.handle_java_exceptions.HTTP_Error.type.handle_java_exceptions(/Users/runner/work/enso/enso/built-distribution/enso-engine-2024.4.1-dev-macos-amd64/enso-2024.4.1-dev/lib/Standard/Base/2024.4.1-dev/src/Network/HTTP/HTTP_Error.enso:44:13-111)

We should make the test more resilient to failures. It's not the first time this test has failed.
https://github.com/enso-org/enso/actions/runs/10195472542/job/28204251194?pr=10718#step:7:2122

Okay, I guess we should probably prepend Test.with_retries <| to these cases.


https support

When trying to toggle forging we should check if the node supports API over https (or as a configuration option).

Should be fixed on current master (https://github.com/prolina-foundation/lisk-nomo/commit/05f6e96d503427bee4561eb77ccb0d4bab4c4250)

Fixed on current master and tested by @5an1ty. Thanks! Closing.


how to resolve: requests.exceptions.HTTPError: 401 Client Error: UNAUTHORIZED for url: https://botometer.osome.iu.edu/api-test/4/check_account

I am on free account and getting this error while running the starter code from git repo:
requests.exceptions.HTTPError: 401 Client Error: UNAUTHORIZED for url: https://botometer.osome.iu.edu/api-test/4/check_account

Please resubscribe to one of the new plans on RapidAPI.
Also, there is a bug associated with the Basic plan on the RapidAPI end right now. Your case seems to be related. We are in communication with them to try to fix the bug. Although I'm not sure when we can get it done.

unsubscribe and subscribe does not seem to help? Is there some other way that I can try out your API for free?

We're aware of a problem with the Basic plan. We're trying to work with
RapidAPI to fix it. Sorry for the inconvenience.
-Botometer Team
On Tue, Sep 8, 2020 at 1:24 AM Abu Bakar Siddique<EMAIL_ADDRESS>wrote:

unsubscribe and subscribe does not seem to help? Is there some other way
that I can try out your API for free?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/IUNetSci/botometer-python/issues/57#issuecomment-688625176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRILUVFPYT55BLPQLDGVBTSEW5XPANCNFSM4Q2NWDOA
.

Could you try again?

Thanks @yangkcatiu, it is working now. I will close the issue.

I was also experimenting the UNAUTHORIZED error, but today it works! Thanks for the correction
However, I have noticed that the quota of the basic plan is reached too early, without overpassing the number of 500 requests.  For example, with the total of 6 requests (seen on RapidAPI), the limit error is raised (on code and also in the notification of RapidAPI interface). I have also employed delay on requests, so it seems not to be a problem of Twitter rate limit...


(better?) Support for adding custom type definitions globally.

I've created a bunch of type definitions for a project I'm working on in hopes of having my custom ones work with IntelliSense. Initially, I tried dragging and dropping the file into server/def/3rd inside of the extension folder but that didn't seem to work. Then I tried snooping around the code but I wasn't able to find anything.
If I am missing some kind of something, please let me know. But if not then I feel like making this easier / adding it would be a great idea.

You can use robloxLsp.workspace.library setting, add the path of a .lua file containing your types to that setting. Exported types will be global across your workspace.

Alright, thank you


Walkers apparently clustering in points of low likelihood

General information:
Islands forming when sampling

emcee version:  3.1.1
platform:
installation method (pip/conda/source/other?): pip

Problem description:
I'm getting these islands appearing after running emcee on my likelihood function, far from the maximum likelihood. I'm confident these are not features of the likelihood space due to the fact that when running the exact same config multiple times, they appear in different places, and when forcing the chains to run for significantly longer than autocorrelation time convergence, most of the time they disappear. Sometimes they don't though. Also when plotting likelihood scans, the likelihood function always looks smooth. Example below, running the exact same config multiple times:

I have tried restricting the prior volume to reduce this, but we are currently at the tightest priors that our analysis permits and still see them. Any thoughts on what's going on would be much appreciated!

Hi Chris - This isn't that uncommon and it's generally the result of poor initialization. Emcee often isn't great at finding the mode, so it can be useful to use an optimizer to find a sensible initialization (like in this tutorial). Sometimes that isn't sufficient and you can define a burn-in procedure where (during burn-in) you occasionally resample the walkers near the maximum probability sample seen so far.


How to use schema extensions in provisioning?

How would we map schema extensions (https://docs.microsoft.com/en-us/powershell/azure/active-directory/using-extension-attributes-sample?view=azureadps-2.0) as attributes? We're including these schema extensions in our SAML claims but I'm not seeing how to map it during provisioning.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83b07a9e-5e16-32ed-265e-32a32998ce37
Version Independent ID: 09008259-4b53-2925-9679-ecad59cefe41
Content: Customizing Azure AD attribute mappings
Content Source: articles/active-directory/app-provisioning/customize-application-attributes.md
Service: active-directory
Sub-service: app-provisioning
GitHub Login: @msmimart
Microsoft Alias: mimart

@trevonmckay
Thanks for the question! We are investigating and will update you shortly.

Hi @trevonmckay
There are some guidelines for this here. https://docs.microsoft.com/en-us/azure/active-directory/app-provisioning/use-scim-to-provision-users-and-groups
Let me know if this helps!
Since this is more of a product question than a doc issue we can continue the discussion on Q&A if needed.  Here's the link to that: https://docs.microsoft.com/answers/topics/azure-active-directory.html
Thanks,
Marilee


Prepare release ResourceManager, Resources 1.1

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Libraries and Markdown updates for Webhooks-Rest sample

The following have been updated in this sample for this PR:

Microsoft.Identity.Client and Microsoft.Graph libraries to the latest stable versions.
Use of IAccount instead of IUser in line with MSAL 2.X requirements in Graph client authentication.
Markdown file on App registration instructions.

Abandoning Pull Request, as the code changes made created a bug on the notification view.  Will create a new one.


d3__WEBPACK_IMPORTED_MODULE_0__.hierarchy is not a function

const root = d3
.hierarchy(data)
.sum(d => d.value)
.sort((a, b) => b.value - a.value)
.eachAfter(
d =>
(d.index = d.parent ? (d.parent.index = d.parent.index + 1 || 0) : 0)
);
versions :
"react": "^18.2.0",
"d3": "^3.5.17"
how to solve this?
repository : https://github.com/mbasakCinedigmInd/d3-hierarchical-bar-chart.git
I created this repository.. please tell me you need anything else. I am desperately searching for a solution

how to solve this?
Use the latest version of D3, not version 3.


Reset order to initial state or a known state?

I have implemented Sortable as a way for the user to re-order the columns in a grid of data. It's all working just fine. The order is stored in a Cookie that can be read back later just fine.
I'd like there to be a button the user can click to reset the column order easily. However I can't figure out how to reset the order to an initial or known state easily, and have that state shown immediately in the <ul> that I'm using.
Any hints?

sortableInstance.sort(order), where order is a list of the IDs in order


Ingest HL7 File from HCA

Determine what changes need to be made to an example HL7 file from HCA and ingest one using the existing ReportStream HL7 process flow. Document what, if any, changes need to be made pre-ingestion to get it to parse properly.
Ensure that once ingested, the in-memory representation of the files contains all of the data expected based on the file.
Objective: verify that HAPI can parse the provided files from HCA, and make notes of any transforming that needs to happen to make this succeed.

We can ingest the 'post' files (that have had their MSH updated to remove '#' and have superficial OBX records that are actually notes removed) and generate an output following our current process IF there is a device name added to OBX 17.2.  The files provided by HCA do not appear to have this field populated, so we will need to either make that field non-required or work with HCA to get the value input.

This task is being put on hold for the time being to focus on Ellume and Abbot ingestion.  Current status:
HCA files do not have 17.2 (equipment model name) and our process requires it. The files do have 17.1 (equipment device id) and our livd table lookups have ids and name - the code currently is just not using the lookup in the manner required to make this work.
We could take in HCA files in the form they currently are, but there will be some code changes required on our side to look up equipment name by id.

https://app.zenhub.com/files/304423150/cf9c3f21-2609-4f22-b210-4c2db2641936/download
(It wouldn't let me upload a plain .md file)    This attached file an an analysis Jim did on Nov 1, looking at the distance between our current HL7 parsing and what we need to support full ELR.


Transparent mode failure: RuntimeError on sierra

When I try to run mitmproxy --host -T it gives:

Warn:  <IP_ADDRESS>:50510: Transparent mode failure: RuntimeError("Error getting pfctl state: CalledProcessError(1, ('sudo', '-n', '/sbin/pfctl', '-s','state')))

How can I solve it?

Did you follow step six in http://docs.mitmproxy.org/en/stable/transparent/osx.html?

Yes

What's the output of /sbin/pfctl -s state for you?

pfctl: /dev/pf: Permission denied

I modified my sudoer file temorary to give all user to all command. after doing that it stared giving me

Transparent mode failure:( could not resolve original destination.)

http://docs.mitmproxy.org/en/stable/transparent.html
http://docs.mitmproxy.org/en/stable/howmitmproxy.html

Running on OS X 10.13.3 and having added ALL ALL=NOPASSWD: /sbin/pfctl -s state to the end of /etc/sudoers. When i run /sbin/pfctl -s state i still get pfctl: /dev/pf: Permission denied. I have done the transparent mode instructions through a couple of times, but still get "Could not resolve original destination" error. Any guides to get it running on latest osx?

Any luck on this? I'm still having the same issues.


mass questions

ethylbenzene has field "reference". Is this used and what does it mean?
is report an object?
what type is range?
what type is precursor?

@lpatiny, I think we also forgot this one

reference is the analytical reference. It could be one of the general field used in all the analysis

Hi @lpatiny, I'd like to close some more issues here before moving to other things.

I couldn't find a sample with range, what format is it? From the Google Docs it seems like a string "300-3000"
Precursor is a string?


what is this error after query?

after query using
query searchEvent($searchString : String, $startDate : DateTime, $endDate : DateTime
  ,$province : String, $raceType: String, $fromDistance: Float, $toDistance : Float)
{
  events(where: {
    AND: [
      {OR: [{
        eventNameTHLowerCase: {
      contains: $searchString
    }},
      {
        eventNameENLowerCase: {
          contains: $searchString
        }
      }]
      },
      {
      location: {
        contains: $province
      }
      }
        ,
        {
          raceType: {
          equals : $raceType
        }
        },
    {
      eventDateStart: {
        gte : $startDate
      }
    },
      {
        eventDateStart : {
          lte : $endDate
        }
      }
      ,{
        distance: {
          some: {
            AND: [
              {distance: {
                gte: $fromDistance
              }},
              {
                distance: {
                  lte : $toDistance
                }
              }
            ]
          }
        }
      }
    ]
  }){
    eventNameTH
    eventNameEN
    createDate
    eventDateStart
    eventDateEnd
    coverPhotoUrl
    distance{
      distance
    }
    location
    raceType
  }
}

but it happen sometime, not all the time
when close and start the npm again this error disappear

@justicejoe Since #357 is fixed, can you please try this again and see what the actual error is? Thanks.

Ping @justicejoe

Closing this due to inactivity. @justicejoe Please ping here if this problem still exists for you.


mount ReactNative with nested Components

I have a simple container, which is nested in a provider incl. store. In this container there is just a View and a Text inside. When I mount() the container everything, which is nested in the View, will not get mounted.
When I change all the components to a, ReactNative invalid, div it works (so it looks like the expected output below, but with divs instead of View and Text).
// container.js
import React from 'react';
import { connect } from 'react-redux';
import { Text, View } from 'react-native';

const MyContainer = () => (
  <View>
    <Text>is</Text>
  </View>
);

const mapStateToProps = () => ({
  ...
});

export default connect(mapStateToProps)(MyContainer);

// container.spec.js
import test from 'ava';
import React from 'react';
import { mount } from 'enzyme';

import MyContainer from './MyContainer';
import createStore from './redux';

const store = createStore();

test(() => {
  const wrapper = mount((
    <MyContainer store={store} />
  ));

  console.log(wrapper.debug());
});

Expected output of wrapper.debug():
<Connect(MyContainer) store={{...}}>
  <MyContainer store={{...}} dispatch={[Function]} storeSubscription={{...}}>
    <View>
      <Text>is<Text />
    </View>
  </Any>
</Connect(MyContainer)>

Current output of wrapper.debug():
<Connect(MyContainer) store={{...}}>
  <MyContainer store={{...}} dispatch={[Function]} storeSubscription={{...}}>
    <View /> // <-- this won't get mounted
  </MyContainer>
</Connect(MyContainer)>

Duplicate #190


Bintray debian repository has no release file

Maybe related to #835
Whenever using
deb https://dl.bintray.com/gopasspw/gopass stretch main

I get on apt-get update:
W: The repository 'https://dl.bintray.com/gopasspw/gopass stretch Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: Failed to fetch https://dl.bintray.com/gopasspw/gopass/dists/stretch/main/binary-amd64/Packages  404  Not Found

You may need to delete your apt cached indexes to correct this. It is also possible they don't have a definition for stretch in their release script to create the correct dist folder and Release file.


added perl control file

needed to added perl in order to added texlive-full, cweb, and mmix.

needed to added perl in order to add texlive-full, cweb, and mmix.

Closing the PR for now, please reopen it again when there is more content.
I'm not sure what direction you plan on going with the perl port, but if you just need perl installed on the machines so the other ports can use it in their build then you should consider adding it similar to python.  See scripts/cmake/vcpkg_find_acquire_program.cmake for more information.


test: fix for tabs2 spec

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ok-to-test


Scoring state machine

Read: #31

sorry, should have waited to request review. Should be fixed now

Also is that the correct branch to merge into?

Also is that the correct branch to merge into?

Yes, this PR depended on that PR.


fixes https://github.com/360EntSecGroup-Skylar/excelize/issues/858

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #859 (040a9ff) into master (2c90b3f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   97.43%   97.43%   -0.01%
==========================================
  Files          31       31
  Lines       10843    10842       -1
==========================================
- Hits        10565    10564       -1
  Misses        155      155
  Partials      123      123

Impacted Files
Coverage Δ

calc.go
97.89% <100.00%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c90b3f...040a9ff. Read the comment docs.


hot fixes

make qm_input #p compatible
auto-recognition of metals in smiles for metal_atoms. Change the dependency of metal_atoms with metal_oxi, if the user uses the charge option then ignore metal_oxi

Fixed, thanks!


[Hub Generated] Review request for Microsoft.DelegatedNetwork to add version preview/2023-05-18-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
[x] I commit to follow the Breaking Change Policy.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

Hi @rkmanda,
I need to do a small change to my original PR because I noticed that originally we had a readonly flag that is actually applied at the top level "properties" object and to all leaves as well. But this now is flagging as readonly the new prop that I added named "purpose" that instead should be writable. We discovered this by updating the AZ CLI that is not recognizing the new param.
We gave this a shot using a local updated copy of the spec in the az cli generation tool and the cli is happy.


[Feature] Make Shareable UI Components for all Pages

Make a library of UI components that are needed for each page in:
https://docs.google.com/presentation/d/1MqW43qfqen84okTyYecqLdTQTu5moLLtz1W0pJtYDYM/edit#slide=id.g54364082c6_0_332
It would be nice if other engineers can just call "createSearchBar" or "createShortUserDescription" and have nice UI components just show up.

Closing this because we might not have enough time to implement.


Ask a native english speaker to review the app wordings

As i wondered what the difference is between training and practice (we use "training" but a canadian coach in paris uses "practice")
I think we should have a review from a native speaker just to make sure we are not introducing confusion

I'm seeing Scott this week to do this


Support C++11 in benchmark codes of parallel::partition and parallel::partition_copy.

Avoid generic lambda of C++14.
Reverted from https://github.com/STEllAR-GROUP/hpx/commit/fadd999212a12107e577f32e9650bdfd90f11541

Fine by me :-)


issues with grafting to ios8 Failed to connect to device #22: Error Domain=PTUSBHubError Code=3

Peertalk is a very fantastic project! As there's still many old devices such as ipad2 and iphone4s. To make extremely good use of these old devices I decide to graft this project on ios8, which is completely jailbroken.
The building device I use is macos12.2 with xcode10.0, and the target device includes an iphone4s with iOS9.3.6 and an ipad2.1 with ios8.4.1. The building process is extremely smooth without removing or changing any codes in the project, and I get success in building and transferring the project on both iphone4s and ipad2. Unfortunately,  the app can't work correctly on my devices.
When I turn on the debug modes, it shows like below:

iOS log informations(Peertalk iOS example):
objc[326]: Class PTUSBHub is implemented in both /private/var/containers/Bundle/Application/1F11F48D-B6F7-40D2-A102-5CD5D8EA3184/Peertalk iOS Example.app/Frameworks/Peertalk.framework/Peertalk and /var/containers/Bundle/Application/1F11F48D-B6F7-40D2-A102-5CD5D8EA3184/Peertalk iOS Example.app/Peertalk iOS Example. One of the two will be used. Which one is undefined.
objc[326]: Class PTUSBChannel is implemented in both /private/var/containers/Bundle/Application/1F11F48D-B6F7-40D2-A102-5CD5D8EA3184/Peertalk iOS Example.app/Frameworks/Peertalk.framework/Peertalk and /var/containers/Bundle/Application/1F11F48D-B6F7-40D2-A102-5CD5D8EA3184/Peertalk iOS Example.app/Peertalk iOS Example. One of the two will be used. Which one is undefined.
error in __connection_block_invoke_2: Connection interrupted

macOS log informations:
objc[92468]: Class PTUSBHub is implemented in both /Users/rainy/Library/Developer/Xcode/DerivedData/peertalk-drmhcxzanttrepgdctirorvfsnce/Build/Products/Debug/Peertalk.framework/Versions/A/Peertalk (0x100475138) and /Users/rainy/Library/Developer/Xcode/DerivedData/peertalk-drmhcxzanttrepgdctirorvfsnce/Build/Products/Debug/Peertalk macOS Example.app/Contents/MacOS/Peertalk macOS Example (0x10000d520). One of the two will be used. Which one is undefined.
objc[92468]: Class PTUSBChannel is implemented in both /Users/rainy/Library/Developer/Xcode/DerivedData/peertalk-drmhcxzanttrepgdctirorvfsnce/Build/Products/Debug/Peertalk.framework/Versions/A/Peertalk (0x100475160) and /Users/rainy/Library/Developer/Xcode/DerivedData/peertalk-drmhcxzanttrepgdctirorvfsnce/Build/Products/Debug/Peertalk macOS Example.app/Contents/MacOS/Peertalk macOS Example (0x10000d548). One of the two will be used. Which one is undefined.
(lldb)

it seems that iOS and macOS can't communicate well, but I can't find the problem where it locates in.
can anybody help me?

So far, with changing some configures, I have transplanted this project on ios9. Some important settings are: set the storyboards' setting targets above iOS10.0(to avoid errors while building the uikit), by this way, the project can work smoothly on ios9. Also, as UIStackView doesn't support iOS8, I've changed all UIStackView to UIView, and this can also run smoothly on iOS9, however, when I install the app on my iOS8 iPad, it crashes. When I check the system logs on iOS8 iPad, it shows: EXC_CRASH (SIGABRT). I haven't determined wether it is caused by abort functions or it's parent process. Also, when I install the app on iOS8, it hints me that, xcode can't locate Peertalk.app, however, when I run it on iOS9, all things are looking correct! Can anyone help me to locate the reason why it can't run on iOS8? Later I would upload my ipa for testing

Using FDStackView instead of UIStackView can solve!


Xcode 17 build issue

I also facing the same issue.

Same issue

There's a work around that works for me:
https://github.com/pichillilorenzo/flutter_inappwebview/issues/1735#issuecomment-1699023475
If you have a pipeline for building your app this link would help you:
https://github.com/pichillilorenzo/flutter_inappwebview/issues/1783#issuecomment-1725173736

Released new version 5.8.0 and 6.0.0-beta.25 with the fix!


Fix #358 case-insensitive filter

Please extend this pull request also with a unit test. A new test "case-insensitive" added to:
'tests/lib/pg/odata-string-functions.test.js'
would be perfect.

@gregorwolf, Is anything extra needed.
Thanks.

@vobu do you think additional tests are needed?

urp, sorry for not getting to this earlier :(
but +1 on the merge :)


v2.0.0 breaking changes

I have just created the branch v2_0. It contains fixes for #40 which break compatibility with stampit 1.x.
But I am not creating a PR yet because I believe there are few more breaking changes necessary.
Immutable stamps
Let's make all chain methods to return new stamp. Let's make stamps immutable after it's created.
A long story.
When I first started using stampit I thought that stamp.state, stamp.methods, and stamp.enclose create new stamps from existing. I was wrong eventually.
Today @raabbajam showed me his code snippets. He assumed the same!
Why it is good.

This is what people expect by default.
This will make all chaining methods consistent (with stamp.compose).
Is some cases the code would be much shorter: bigDog = dog.state({ size: 'big' }) instead of bigDog = dog.compose(stampit(null, { size: 'big' })).
(IMO) Changing existing stamp is useless feature. Nobody need changes to the this of his stamps.
And a mini bonus. All stamps are currently referencing entire stampit closure (methods like extractFunction, slice, forEach, forOwn. 10 in total). We could avoid that!

combine instead of compose
I browsed few English dictionaries. I believe the better wording for the compose function would be combine.
@ericelliott I would really love to hear your opinion on these two.

Immutable stamps

Yeah! I've been thinking I should have done this from the start for about two years. I secretly had this in mind for a 2.0 release. It's like you're reading my mind!

Today @raabbajam showed me his code snippets. He assumed the same!

This is a common question I hear, which is what got me thinking immutability should have been the plan in the first place.
The only reason I didn't do this was because I had an edge case that required a mutable stamp to work, but looking back, I think that the decision to bend my ideal API to fit one use case that I've never had again was an error.
combine vs / compose
The reason I chose compose is rooted in the famous GoF book, "Design Patterns", where they state two foundational principles on which the book was built. One of them being, "Favor object composition over class inheritance."
In other words, I specifically chose the word to:

Emphasize that .compose() does not suffer the same problems as class inheritance.
Use a word that should be well-known to the OOP community.

Re combine/compose.
"Favor object composition over class inheritance." The GoF reference objects, not classes/stamp/factories. IMO you we should compose objects, but combine stamps.
I insist on voting among stampit community. :)

Re the immutability. Let me create a PR for the v2_0 branch.

OK. If you can get ten other people to vote for combine, we'll add it as an alias. Get 20 and we'll deprecate .compose (unless we hear lots of objections).

@ericelliott : You asked for it :). +1 for combine stamps

Guys, there is the poll for combine/compose.
I encourage you (and other stampit users you know) to vote.
http://goo.gl/forms/O3yL2OYQsy

:)

👍🎉🎊

If you start hunting around Wikipedia regarding the terms "compose" and "combine", you quickly come to the realization that "compose" makes more sense against the past.  The term "aggregate" also come up, but "combine" seems to be nowhere.  Is the objection to "compose" that it might get confused with matrix composition?  When does the voting stop, or has it already?

Let's wait for resolution on which name will replace .compose() before we merge this work. =)
See https://github.com/ericelliott/stampit/issues/46

I didn't add combine alias with any of the existing PR's as I was waiting for the poll results. The alias(-es) should be added with a separate PR I reckon.

I can see using a separate commit, but I don't think a separate PR is warranted. The 2.0 API should be fleshed out when we merge it. There will be no more breaking changes in the 2.0 branch after it is merged. Otherwise, we'd have to increment to 3.0 right away in order to comply with semver.

See #48. I am waiting you to review the mixInChain to v2_0 merge. master branch will stay untouched if you accept the #48.

For future references.
Re the Compose/Combine dilemma. It was decided to leave the naming as is. No new aliases, no changes.

=)

Immutability is done in branch v2_0.


Add fabric support

Give me a few days and I'll have a possible prototype.

Alright I have a mostly functional draft in progress but a few things still need to be done:
Fix command completions.
Possibly make brigadier completions work (I wouldn't very much prefer that).
Fix the build (shadowed and relocated libraries aren't on the output jar)
Verify the code works on 1.15.2 and possibly the latest snapshot (20w08a as of now, should be possible due to the lack of technical changes in mostly recent versions)
Ask the config format question. Fabric doesn't have a config api nor an official standard, so YAML, hocon, json, some other subset of json is on the table. (the current branch uses hocon just for testing and since I am comfortable with it)
Obviously every style violation in the books is in the repo so I'll have to go back to that.
Fix server shutdown issue where one thread doesn't stop, basically stalking the jvm.
Do we want to include the 4 fabric api modules we use in the built jar (the community reccomendation is no but nothing bad will happen if we do it (minus the jar being a few hundred kb larger and standalone).
Some fabric specific additions:
A new processor to handle giving console like permissions to the owner of a singleplayer world (yes LP works in singleplayer), this can be configured of course.
Runs on both client and server.
Here you go (it won't run properly in any prod environment, so good luck). I would not reccomend use in any production server, this is for testing only so far.
https://github.com/i509VCB/LuckPerms/tree/fabric?files=1

Awesome work!

Agree, this is quite awesome. Fabric seems to become more popular.

One of the things I want to integrate is the richer brigadier tab completions which fabric does support (since it's almost 100% vanilla internally). Of course you already have the tree built already for the bukkit module so I just need the parser for commodore files which I have mentioned in this issue:
https://github.com/lucko/commodore/issues/8
I'll try to parse this a bit more smartly so I can actually use Player selector argument.

Lazily copying the parser is what I'd do. ;)
If down the road I (or someone else) has time to properly modularize commodore and split the parser off, we can always refactor.

I would love to try my hands on that.... But issue is, that I don't quite get how to make a gradle project with multiple modules in IntelliJ (Without the default src/main path)

Have any progress updates been made on this?

Yes - see here: https://github.com/lucko/LuckPerms/pull/2029

Closing this issue in favour of the current PR.


Enable MKL in configure and various bug fixes

This pull request enables MKL in configure. Building with bazel using --config=mkl will utilize all our ops for existing frameworks, replaced via the graph pass.
Various bug fixes include:

Performance fix for relu/maxpool (grad)
Graph layout pass changes
LRN defaults to eigen when depth radius is not 2
Various style fixes
Unit test build failure fixes
Fixed missing _ in name that was missed during previous search & replace by Google

... and other minor changes.

Can one of the admins verify this patch?

Should we start the unit tests?

@tensorflow-jenkins test this please

Fixed sanity check issue - please restart the test.

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

I'm not entirely sure but something doesn't seem to be building ... have you tested locally?

Ah this might be because configure has new questions - enable mkl support and whether or not to download mkl from the web. You will have to modify your automation script to cater to those questions (both yes for mkl). Sorry, I should've mentioned  that.

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/builds/configured I suspect this needs to be edited -- can you do that in this PR?

I've added a new commit to address this based on the assumption that setting the variable value in configured will set it in the configure script. Please can you take a quick look at my latest check-in and if that looks right, start a new CI run?

@tensorflow-jenkins test this please
I think this looks reasonable, let's give it a try!  (if it doesn't work, I'll rope in some other CI gurus)

Looks like the "locate" binary is missing in your PATH. We also use "sed". Would it be possible to add those to the environment or do we need to use something different?

Pinging @caisq; do you or someone else know who can help with this?

Could you add 'mlocate' to this file https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/install/install_deb_packages.sh#L49

Done. Please restart the tests.

Thanks @vivek-rane! @tensorflow-jenkins test this please

locate: can not stat () /var/lib/mlocate/mlocate.db': No such file or directory
Build step 'Execute shell' marked build as failure
Unable to get pull request builder trigger!!
Setting status of 35b62f397a39bf19320073039e5ae0fb253abee5 to FAILURE with url https://ci.tensorflow.org/job/tensorflow-pull-requests-sanity/4114/ and message: 'FAILURE
'
Using context: Sanity Checks
Finished: FAILURE`

Hmm, I wonder if it's okay to use mlocate in docker. Looking it up.

@vrv @yifeif We primarily have the locate in place for UBuntu support. If it helps expedite things, we can remove that from this PR for now and revisit it in a later PR. Let me know which path you would like to recommend.

Tried in a docker container,
If we install 'locate' instead of 'mlocate', locate can run but it wasn't able to find "libdl.so.2".
What worked was:
Keep "apt-get install mlocate", then run "updatedb" after the installation to populate the database.
@vivek-rane could you add "updatedb" to the same file as well? Thanks!

Done - can you check now?

@tensorflow-jenkins test this please.

Fixed the buildifier issue - sorry! Please restart tests.

Great, and no worries! @tensorflow-jenkins test this please

Looks like we have to configure the mac os builds to not use MKL, since it doesn't look to be supported yet?

Yeah, I think you can do that here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/osx/libtensorflow_cpu.sh#L30
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/osx/libtensorflow_gpu.sh#L31
by setting TF_NEED_MKL=0 and then we can probably merge this :)

have set TF_NEED_MKL=0 in that two files you mentioned. @vrv please let us know if it is ready for merge!

@tensorflow-jenkins test this please

apparently that's not the only place, let me look to see where else (sigh!)

@caisq it looks like the Mac OS X build is still calling the 'configured' program; I'm not entirely sure where we should be disabling via environment variable for the MacOS CPU tests -- can you help us figure it out?

While we're fixing the MacOS tests, lets also look at the Linux CPU python3 test that failed for the following:
//tensorflow/contrib/factorization:wals_test                             FAILED in 1 out of 2 in 54.5s
Is this a known issue? Is there a way to access the log to figure out the error?
/var/lib/jenkins/workspace/tensorflow-pull-requests-cpu-python3/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/workspace/bazel-out/local-py3-opt/testlogs/tensorflow/contrib/factorization/wals_test/test.log

Contrib code is pretty flaky in general, so in this case I wouldn't worry about it :)

Awesome - we just have the MacOS issue to resolve then.

@vrv that's a little weird. The code looks like it should work. I just pulled the branch and tested ./configure on a mac and it seems to correctly set TF_NEED_MKL to 0.

@vivek-rane I made changes in your configured script, so that the MKL options are enabled only on Linux. The build is running again.

@tensorflow-jenkins test this please

@vivek-rane , thanks!
@tensorflow-jenkins test this please

Sweet! Thanks for the help, @caisq @vrv @yifeif and @andydavis1 👍


Allow user select wallet at start

Closes
https://github.com/ArdanaLabs/Ardana-dApps/issues/53
https://github.com/ArdanaLabs/Ardana-dApps/issues/80
other changes

[ ] Every newly introduced function needs to have a documentation
[ ] The impure tests via nix run .#offchain:test were run and all are passing.
[ ] Where applicable, grammar, punctuation, and spelling within code and comments should be plausibly correct.
[ ] The issue(s) that the work is addressing should be linked in the PR description.
[ ] Any significant changes beyond what's clear from the linked issue(s) are documented in the PR description

https://6376d2a792b0af3abb811a1d--dusd-browser.netlify.app/


Jittering png sequence animation

I'm dealing with minor jittering issue in png sequence animation in mobile, specifically older android and IOS versions.
The asset is exported as sprite-sheet from TexturePacker with size of 2048x2048, no trimming and no extrusion and gets imported into Phaser as atlas. I have tried importing it as sprite-sheet as well with no luck.
I will mention that the sprite-sheet gets scaled down in TexturePacker to 0.75 for mobile, but the issue also happens when the sprite-sheet is scale 1.
video was recorded in phaser 3.60 but it also happens in phaser 3.80.1.
I'm sharing an exaggerated video of the issue.
https://github.com/phaserjs/phaser/assets/97833654/5bd5ede0-1c7f-4b00-be1b-045f771f3396

Sorry for not spotting this earlier - but first of all, please test against the current master branch, and I believe the latest release will address this (as it looks like you've for the Shine FX running on that sprite). If you're not using any FX, then please upload the code and sample assets so we can look at it, as we can't really debug videos. We will re-open this issue after that is done.


JSON log with tries object or array

All the log plugins use kong.log.serialize method to generate log message and then use cjson to encode the message.
The problem is the tries object in log message can be an json array or empty object:
    "tries": [
        {
            "state": "next",
            "code": 502,
            "ip": "<IP_ADDRESS>",
            "port": 8000
        },
        {
            "ip": "<IP_ADDRESS>",
            "port": 8000
        }
    ]

    "tries": {}

which make other languages very difficult to decode the log.
Use setmetatable(tries, cjson.array_mt) method can fixed this issue, but I don't know where this code should go.
I create a PR #6386  that add this lines into kong/pdk/log.lua,  but a better idea is move it to balancer phase. Maybe someone could do this.

@tianzhipeng-git this is the location where to fix: https://github.com/Kong/kong/blob/dc8c1258aeed2a9649e9a4533ec575b1da16e488/kong/runloop/handler.lua#L802

@tianzhipeng-git this is the location where to fix:
https://github.com/Kong/kong/blob/dc8c1258aeed2a9649e9a4533ec575b1da16e488/kong/runloop/handler.lua#L802

Just change this line to tries = nil may cause other problems, because the succeeded operations assumed that tries is not nil.

@tianzhipeng-git this is the location where to fix:
https://github.com/Kong/kong/blob/dc8c1258aeed2a9649e9a4533ec575b1da16e488/kong/runloop/handler.lua#L802

Just change this line to tries = nil may cause other problems, because the succeeded operations assumed that tries is not nil.

Include cjson to this handler.lua and use setmetatable(tries, cjson.array_mt) looks like a bad idea too

The origin code: tries = (ctx.balancer_data or {}).tries return tries = {} means that

ctx.balancer_data is not nil
ctx.balancer_data.tries is empty table
is it right?

The origin code: tries = (ctx.balancer_data or {}).tries mean

It is same as:
local tries
if ctx.balancer_data then
 tries = ctx.balancer_data.tries
end

Include cjson to this handler.lua and use setmetatable(tries, cjson.array_mt) looks like a bad idea too

That would be the proper solution imo; tries = setmetatable({}, cjson.array_mt)

the logger check tries to be nil, because in case of errors, or early exits, tries never gets set (it doesn't reach this code here)


Removing relative permalinks

GitHub Pages and Jekyll no longer support relative permalinks. You must remove the relative_permalinks configuration option from your GitHub Pages site's _config.yml file and reformat any relative permalinks in your site to absolute permalinks.

Fixed in #238.


Potential misuse of multi-byte character in regex.split

https://github.com/ccxvii/mujs/blob/6f93cab7ffcb73d64d45ecc746f121c37c73586d/jsstring.c#L605
The ++a there is incrementing what could be, unless i'm sorely misunderstanding the code (which i might be), a multi-byte character, which would leave the next call to js_doregexec() the start of a string which is currently part of the way through a multi-byte character.

Keep in mind that currently mujs strings are CESU-8 which is different than UTF-8 for codepoints higher than U+FFFF, and mujs itself currently has a known issue when such codepoints appear in a source file (hopefully fixed soon).
This may or may not be related to your issue, but it is related to multibyte codepoint (specifically, 4 bytes codepoints).

i haven't had an issue with it, i just came across it while looking into #130 and it looked suspicious.


deny.toml: remove aho-corasick from skip list

When running cargo deny check I get an "warning[unmatched-skip]: skipped crate 'aho-corasick = ^0.7.19' was not encountered" warning, so it seems like this entry is no longer necessary.

It seems like I was wrong, so closing this PR.

I figured it out: I should have used cargo deny --all-features check.


[FEAT/REQ] Adding support to linux

Is your feature request related to a problem? Please describe.
Hello everyone
As many of you know there are large community of cs2 that play on linux.
I believe it would be great for you to add support to linux
Describe the solution you'd like
I havent thought of a solution - since i didnt check where and how you use winAPI in your project (or other technologies that will need to be replaced for linux)
Describe alternatives you've considered
Again i cannot think of an alternative solution
Additional context
No response

Irrelevant as of right-now


Add Essential Features for Researchers Phase 1 (excluding some Place issues)

NB Does not include issues which need PLACE issues resolved first.

[ ] search by occupation
[ ] search without inputting county
[ ] free text place name search (ie.  street, ecclesiastical parish, civil parish, district)
[ ] ability to search results by column
[ ] move to next and previous record (in addition to next and previous dwelling
[ ] Allow selection of multiple census years

Possibly in this epic:

[ ] search by age (in addition to birth year
[ ] searches by census locations (street, ecclesiastical district, and civil parish) (does not need place epic)

Before doing one line of code we need to have a clear understanding of the current nature of the search engine for FreeCEN2.
It is currently designed to search for individuals specified by forename or surname or both born within a range of years who was either enumerated in a location or born in a location.
It is NOT designed to search for a) all males or females b) all disabled people c) all widowed people or many of the criteria that have been included in a census.
It is likely that CEN1 WOULD attempt such searches but time out or max record out. However we never told researchers what they could or could not do.
Currently all our second generation applications are individual searches as were REG1 and BMD1.
Hence I propose that these criteria are applied as filters on a basic individual search using and extending the current search engine.
Fundamentally what that means is that the search will use the name/location/date/census year to locate individuals from the search_record collection. Those results would then be filtered by the additional criteria based on the content of the individual collection.  To assist in performance we would build indices on the individual collection as none currently exist.

@richpomfret to clarify the requirements with @PatReynolds and @FreecenBren.

We will otherwise go on the assumption that we search by people and then by x, y or z (e.g. occupation).

System of filters was developed as part of "the Christmas Present'. However it seems that is is likely to confuse people unless well explained.
It is important to note that REG also uses filters for family members and witnesses

@PatReynolds wrote
I think we have two options, keep the Christmas Presents on the search page, or put them on the search results page.  Suggested placement/text:
Option 1, I suggest the following layout:
Move soundex and the search button up - maybe even into the main box.  Nearby places will go here, in due course.
Delete "Please read the help carefully (etc)"
Below the search button, and below a line (or in a separate box) new text:
The following features will help you narrow down your search.  If you have run a search, use the 'amend search' button to return here.  Please read the help carefully (etc).

Option 2: amend this text, to include "Too many results? refine your search using one of the options [click here] or use the return button to narrow by year of birth, place of birth, or place of census."

At bottom of page (below table, above revise search, new search, etc. buttons, place "Christmas Present" options in a box with a button that says "filter current search" (or something).
The label of the 'revise search' button in this context will probably be confusing, so needs to be something like 'amend current search'..
What do you-all think?

@PatReynolds @richpomfret @DeniseColbert @AlOneill @Vino-S
I moved Pat's emailed comment into this story so that we can retain the discussion for the future.
As an aside note that REG also uses filters for family members and witnesses not direct search fields.
Moving these filters to the Results page would be a massive undertaking. Thay are designed to be applied to the base results at the time of the search. Reprogramming will possible would be a size 20 and likely take 2 months to deliver. So I do not like option 2
If it is desired that we treat these as truly search fields then we should re-engineer the search to use the individuals collection rather than the search records collection. All fields are there. I have no idea why CEN uses a search record collection other than that is what REG uses.
If we are to retain on the search page then it would make sense to move the soundex option up near the name fields just as done in BMD1 and proposed for 2. Also the nearby when it comes back goes near the place selection as there must be an initial place anyway. These two changes should likely be done ANYWAY regardless of anything else.
I dislike the idea of moving the search button below the set of filters. That button should always be the last item on any Search page
As to the text I have a preference for my own which refers to the help document; the warning about the system responding differently by census year is essential
The KEY in my mind is what we write into the Help material
I really would like to hear other opinions.
It seems clear we are not ready to release 'the Christmas Present' as part of this sprint release.

Thanks, Kirk.  Agreed, not on the detailed results page - far too much work for too little gain.
Agred, moving the soundex up is a great idea.
I am obviously missing something, as I don't understand how witnesses and family members on FreeREG can be fiilters (e.g. if I search for with an Alcock, are you saying that the search actually finds all the Alcocks, but filters out everyone but the baptised, married or buried person (a sort of negative filter?).
Absolutely warnings about help, etc. must remain.

@PatReynolds  wrt
I am obviously missing something, as I don't understand how witnesses and family members on FreeREG can be filters (e.g. if I search for with an Alcock, are you saying that the search actually finds all the Alcocks, but filters out everyone but the baptised, married or buried person (a sort of negative filter?).
No we do not search fo all the Alcocks and then fileter out on the basis of "baptised, married or buried".
We do search for Alcocks who are baptised (or buried) in the specified location and date range. We then apply a filter that uses the family member option setting. If the option is set we do nothing ie family members are there. If it is NOT set we filter out those results that are family members.
Similarly for marriages. We do a search for Alcocks who are married in the specified location and date range. We do nothing if family members and witnesses are selected. If they are not we filter out those not required eg if you do not want witnesses who are Alcocks we remove them.
This is how the embargo works. All records are retrieved and filter out those embargoed.
When do we use filters and when do we search? We search when we can use fields that are indexed. We filter when we need to use fields that are not indexed or are not in the search record collection at all

Tahnks, Kirk, " If it is NOT set we filter out those results that are family members." is what I was trying to say.

That is correct. If it is NOT set we filter out those results that are family members.
However the original comment introduced but filters out everyone but the baptised, married or buried person and that is not the case baptised, married or buried are search fields not filters.
Filters ALWAYS work as removals never additions. The search gives us the full set we wish to examine. Works just like EXCEL filters


[bug] TypeScript typings not published to npm

Steps to reproduce:

Install in TS project with strict conf.
Import
Error :disappointed:

Could not find a declaration file for module 'fast-memoize'. '[path-to-TS-project]/node_modules/fast-memoize/src/index.js' implicitly has an 'any' type.
  Try `npm install @types/fast-memoize` if it exists or add a new declaration (.d.ts) file containing `declare module 'fast-memoize';`

Fixed in https://github.com/caiogondim/fast-memoize.js/pull/69

Released in https://www.npmjs.com/package/fast-memoize/v/2.5.1
@caiogondim this release doesn't appear in GitHub's releases for some reason: https://github.com/caiogondim/fast-memoize.js/releases. I have no idea how to fix that :thinking:


Dependency checks fail for new 2020 NVD CVEs

I've come back after the new years break and one of our daily Jenkins builds that checks for dependency issues is now failing.
The Jenkins builds have been working okay until the 1st of January 2020. Nobody was in over the holiday period, and we haven't updated anything on our side. Now suddenly the plugin can't seem to process the NVD JSON data. I suspect this is some date/format related issue? I saw a fix on the other repository for the maven plugin.
Aware we're using an older version, 5.0.0. I tried a version bump but it seems to require some sort of mirrored meta file (any help in this direction would be appreciated).
Here's the error log from Jenkins:
Download https://repo.maven.apache.org/maven2/org/owasp/dependency-check-utils/5.0.0-M2/dependency-check-utils-5.0.0-M2.jar
> Task :dependencyCheckUpdate
> Task :dependencyCheckUpdate

Error reading NVD JSON data: /tmp/dctemp65d76834-0a7c-41a6-83ca-fb75501c22b9/cve2020_5615620050192381690.json.gz

> Task :dependencyCheckUpdate FAILED

FAILURE:
Build failed with an exception.
* What went wrong:
Execution failed for task ':dependencyCheckUpdate'.
Unable to connect to the dependency-check database
Run with -stacktrace option to get the stack trace. Run with --info or --debugoption to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 5m 55s
actionable task: 1 executed
The command '/bin/sh -c ./gradlew --no-daemon :dependencyCheckUpdate' returned a non-zero code: 1

and here's a redacted build.gradle. We're using mirrored NIST NVD files as we've had a lot of issues with connectivity to their servers.
buildscript {
    repositories {
        mavenCentral()
    }
    dependencies {
        classpath 'org.owasp:dependency-check-gradle:5.2.1'
    }
}

apply plugin: 'org.owasp.dependencycheck'

dependencyCheck {
    data {
        directory='/src/nvd'
    }
    cve {
        urlBase='http://example.com/repository/nist-nvd-mirror/json/nvdcve-1.0-%d.json.gz'
        urlModified='http://example.com/repository/nist-nvd-mirror/json/nvdcve-1.0-modified.json.gz'
    }
}

Any further info, just let me know.

You are using a milestone release. Please upgrade to the latest - 5.2.4. Regarding the meta data file - those will need to be mirrored also. See https://nvd.nist.gov/vuln/data-feeds#JSON_FEED.

It appears to have now randomly fixed itself - curious. One assumes that this is an issue that will only happen around the new years?
Regardless, we need to update this version, so I will look into doing that. From a cursory look we need to upgrade gradle and some other things first.


Document "File not found" should be less cryptic

Document.read gives a rather opaque BAD_ACCESS error when the file is not found.  It should report something more user-friendly and intelligible.

Fixed with e104e54


Helper block for collision with group

This is a 3-in-1 helper block for the common pattern found in the demos. It replaces adding:

A "when this node collides with ..." block
An "if" block
An "is node in group" block

Draft for now because our signal handlers have the same "on_SIGNAL" name.

Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem?
If so, doesn't this problem already exist in the "when this node collides with .." block?
This will be a hard fix because you need a way to make the signal callback unique but the user codes the function name with code_template so in order for it to be unique it needs to be dynamically generated.

Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem you're talking about with the "on_SIGNAL" name?

Yes, we need a better way. For example the Visual Shaders in Godot use suffixes (try creating a visual shader and then click "Show generated shader code". We'll need a solution like that.


Signup refactor part 3 and fix for issue 961

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#961
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer

Duplicated find invite call removed.
Logic to handle back navigation to return to login on return from deep link flow.
More clean up.

NOTE: To test fail and success cases I comment the real use cases and mock ValueResults and ErrorResults, I also use a Timer to fire and simulate the OnInviteLinkRecived event.
👯♀ Paired with
"nobody"

@buildc0de could you help me testing the whole signup flow?
Test cases:

Recibe link:

Got through the flow until create an account

Go to until create name and return back until reach login screen.

Simulate an invalid link and verify return to login screen on closing error dialog.

Simulate a creation account error verify ability to return to back until login screen.

Scan invite

Verify the this flow work as always.

@RaulUrtecho Thank you for providing the test cases 🙏 And yes, will test. Please merge and move to Reviewer approved in https://github.com/JoinSEEDS/seeds_light_wallet/projects/15 🙏


how to see log of any app (milestone, planner)

[Enter feedback here],
on Microsoft team, how can I view the log, as in on milestone app who deleted project, who modified, etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9a252be-5703-4e53-a125-718da3c31c6a
Version Independent ID: a7c5537e-9bb2-ea86-6551-20852ee91543
Content: Use Milestones apps from teams store - Power Apps
Content Source: powerapps-docs/teams/milestones.md
Service: powerapps
Sub-service: teams
GitHub Login: @navjotm
Microsoft Alias: namarwah

Thank you for reaching out. For feature and behavior asks, please feel free to reach out to the Power Apps Ideas Community Forum and submit an idea, or vote for existing ideas.


Architecture for registry api using MVC design pattern

Done

Done central error handling, desing patterns, made secure


Change "view file" icon in floating player

The current "view file" icon appears to be the log-in icon from feather, which is rather misleading and has lead me to accidentally click it instead of the X to close the player (which is sort of impressive since the very obvious close button is right next to it).
I think the "view file" button should be changed to the maximize-2 icon since that's actually what the button does. Perhaps the name of the button should also be changed to "Maximize", but that could be a separate issue.
I have tried having a look at the code myself, but quickly got confused by how the icons are defined..

Thanks for the suggestion! If you want to give it another shot, feel free to poke around a bit more.

https://github.com/lbryio/lbry-desktop/wiki/Icons this is the wiki for icons. I agree all icons could use a pass.
We don't use that icon any more - you click on the title text to go back. this is unclear too, though. closing this one.


weave detaching an allocated IP does not free it

This has been fixed on the #827 branch - bboreham@ae5b278#diff-ed6579eaedd0e67b3ed51c7ee7071044R1064


Add unit tests four

Added Unit Tests to improve code coverage.

Can one of the admins verify this patch?

Codecov Report

Merging #640 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #640      +/-   ##
============================================
+ Coverage     25.48%   25.53%   +0.05%
- Complexity     5892     5919      +27
============================================
  Files          1379     1379
  Lines         81871    81871
  Branches      11479    11479
============================================
+ Hits          20866    20908      +42
+ Misses        58984    58932      -52
- Partials       2021     2031      +10

Impacted Files
Coverage Δ
Complexity Δ

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...ream/core/storage/columnar/ColumnarStoreCache.java
48.83% <0%> (-3.49%)
7% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
76.74% <0%> (+2.32%)
12% <0%> (ø)
:arrow_down:

...pache/kylin/engine/mr/common/JobInfoConverter.java
29.13% <0%> (+13.38%)
21% <0%> (+14%)
:arrow_up:

...apache/kylin/engine/mr/common/HadoopCmdOutput.java
14.7% <0%> (+14.7%)
4% <0%> (+4%)
:arrow_up:

...n/engine/mr/steps/lookup/LookupExecutableUtil.java
24.44% <0%> (+24.44%)
5% <0%> (+5%)
:arrow_up:

...ylin/engine/mr/common/DefaultX509TrustManager.java
35.71% <0%> (+35.71%)
5% <0%> (+5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fa8b1...2fb6db4. Read the comment docs.

Hi @TheRealHaui
It seems that you do not set "import order" in your IDE with file "core-common/.settings/org.eclipse.jdt.core.prefs", with this setting, java.* should be above of org.*

@nichunen,
I reordered the import statements like Eclipse does.

Obviously Travis has crashed or at least hangs.

Pull Request Test Coverage Report for Build 4497

0 of 0   changed or added relevant lines in 0 files are covered.
557 unchanged lines in 14 files lost coverage.
Overall coverage increased (+0.2%) to 28.195%

Files with Coverage Reduction
New Missed Lines
%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java
3
7.91%

core-common/src/main/java/org/apache/kylin/common/persistence/FileResourceStore.java
4
77.55%

engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
7
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/PushdownResourceStore.java
8
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceSQL.java
13
0.0%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/SnapshotManager.java
17
75.0%

core-common/src/main/java/org/apache/kylin/common/persistence/HDFSResourceStore.java
18
21.64%

server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
38
71.53%

core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceStore.java
48
0.0%

core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
56
76.9%

Totals

Change from base Build 4495:
0.2%

Covered Lines:
23149

Relevant Lines:
82103

💛  - Coveralls

@nichunen,
do you want to see further changes?

@TheRealHaui  Hi, absolutely! Kylin's code coverage is growing with your contribution.

@nichunen,
ah, yes - thanks for your answer, looking forward to contribute more tests!
However, meant in my comment if you want to see further changes in this pull request prior to merging?

@TheRealHaui I've reviewed and merged. Thanks

@nichunen,
you are welcome!