Bootstrap Windows (2012 R2 and above platform) instance without user-data Not working for Windows AWS EC@2

Hi,
This the command I am using to spin windows2012 R2 without user data as per the doc, after launched the instance, it is waiting to bootstrap via winrm using port 5986.
knife ec2 server create -N windowstest -I ami-e659c7f0 -f t2.micro --bootstrap-protocol winrm --winrm-user .\windowsuser --winrm-password admin@123 --winrm-transport ssl --winrm-ssl-verify-mode verify_none --winrm-transport plaintext --bootstrap-protocol winrm --security-group-ids sg-3f80ba40 --ssh-key Office-windows -VVV
But it keeps on waiting but no response and I check the Security group also all ports are opened.

what is the possibility of failure and what is the solution?

@oliyavan , please try without passing --winrm-transport plaintext --bootstrap-protocol winrm options. For SSL transport, we can't give plaintext. --bootstrap-protocol will be set by default I guess.
Please check and let me know your findings.

@NimishaS i also tried without --winrm-transport plaintext --bootstrap-protocol winrm but still same the same, please check the below message.
`
Waiting for EC2 to create the instance.....
Public DNS Name: ec2-34-205-50-40.compute-1.amazonaws.com
Public IP Address: <IP_ADDRESS>
Private DNS Name: ip-172-31-73-66.ec2.internal
Private IP Address: <IP_ADDRESS>
Waiting for winrm access to become available
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com(dns_name)
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
SSH Target Address: ec2-34-205-50-40.compute-1.amazonaws.com()
.
`
After this keep on waiting

Hi @oliyavan ,

Hi @oliyavan ,
I tried with this command & for me it is working successfully "knife ec2 server create --node-name AshWin4 -I ami-11e84107 -f t2.micro -x '.\Ashwini' -P "ec2user@123" --winrm-transport ssl --winrm-ssl-verify-mode verify_none --node-ssl-verify-mode none -VV"

@oliyavan , any updates on this?

@oliyavan , closing this issue as @NAshwini could run the command successfully.
Please feel free to reopen is you still face difficulty.


fix: add chip component

Adding chip component and stories
resolves: #104

@SimeonC I ended up doing this again as it's been a while from touching code and rebasing my old branch had me confused on a few things.
I think I mentioned a while ago but I am have an issue with showing the focus state in the story (works when you tab into it).
Let me know anything else I missed 🙇


Can we have conversion tide::error into std::error?

https://doc.rust-lang.org/std/error/trait.Error.html

https://github.com/http-rs/tide/pull/414 will fix this!


Is there any extra demo for in-flight batch strategy？

Hi I am a graduate students who majored in the bubble optimazation for Pipeline parallelism in LLM Inference. I see this repo decribe a inference requests schedule strategy, named 'in-flight batching'. I have great interests in studying purpose. So I follow the tutorial mentioned in tensorrt-backend repo. But there are no article teach me the implemention for this strategy. It's hard to comprehend this technology without better tutorial.
So, is there any addition implemention or evaluation for this strategy? Or just tell me which part of source code correspond to this function? In my opinion, it's maybe a C++ source code integrated in TensorRT dependency library.
Thank u！

Hi @Noblezhong, unfortunately, the inflight batching strategy is closed source at the moment. Please consult the documentation for batch manager for further details.

I see that


Runtime support appears incorrect

Support for .NET 5.0+, .NET Framework 4.5+, .NET Core 3.1, and .NET Standard 2.1.

I don't think this is correct, the library is net standard 2.1 which means it can't be used on .net framework (any version) as far as I am aware and nuget only has a version that is standard 2.1

Hello @danpetitt,
The NuGet packages contain multiple builds for different frameworks and runtimes. For example, if you open the lib folder here, you'll see subfolders holding ClearScript.Core.dll builds for the following TFMs: net45, net471, net5.0, netcoreapp3.1, netstandard2.1, and uap10.0. Those should cover the targets and runtimes listed on the home page.
Cheers!

Thanks for that; any chance they can get published to nuget as part of the normal release cycle?

Please reopen this issue if you have additional questions or comments on this topic.


chore: clean http server module

Stack:

#1513
#1512
#1502
#1501
#1499 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #1502


⚠ Bofrost.at has degraded performance

In 66f89e3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1764 ms

Resolved: Bofrost.at performance has improved in 49b4c39 after 11 minutes.


✨TinaCMS - update branch selector

Reimplement the branch selector for TinaCMS - we should be able to reuse code from the Editorial Workflow picker

Available for all plans + open source (if feasible)
Allows user to change current branch + create new branch

Figure: current editorial workflow branch picker

[ ] Allow everyone to use new branch selector
[ ] Update https://tina.io/docs/tina-cloud/branching/ or mark as deprecated

I have been evaluating Tina CMS for a small project, when I noticed branch support was not present without editorial workflows that require a "Business" plan. No branch support is a deal breaker for how I planned to use a git based CMS. I wonder if Self hosted Tina has this same limitation, or maybe we would have to self host an older version of Tina to get around this until this issue is complete?
Seeing that this issue is coming from @wicksipedia (Tina PM), gives me hope, but if this is a low priority feature that is still up for consideration, it would be good to know, before I get too invested.

Hey @nicko-winner
We've done the initial investigation and I'm not sure if branch support will come to self-hosted any time soon.
Branch support is possible on the TinaCloud free plan following the docs above.
Editorial Workflow takes it a step further by handling the pull request experience (plus more on the way).
We recently updated our pricing making Editorial Workflow cheaper for all users - there's now a Teams+ plan for $49 per month which includes Editorial Workflow.
See tina.io/pricing
Hope this helps


Added submodule clone to git clone over https (no ssh keys required)

This fixes #69 and allows to pull submodules when repo is pulled, it uses github's access tokens, so ssh keys configuration is not required.
I've checked it on my project, and it works just fine
@itsdalmo it is PR created instead of closed one.

Can we get some movement on this?

Can we get some movement on this?
I'm not so good at Go, so I have no idea how to add new flag, for now you can use https://hub.docker.com/r/djirik/github-pr-resource

Thanks for the PR, but I don't feel comfortable merging this since the solution involves writing the access token to disk, and I think the con in terms of security outweigh the benefit of solving this particular use case. I.e. I think it's better for this feature to live in your branch :) Thank you for the PR though, and your patience!


[ Feature Suggestion ] Adding tqdm progress bar for more accurate completion time

Adding a progress bar that is more accurate and informative than the gradio one.
from tqdm import tqdm  # Import tqdm

# Process each frame with tqdm
total_frames = int(cap.get(cv2.CAP_PROP_FRAME_COUNT))
for _ in tqdm(range(total_frames), desc="Processing Frames", unit="frames"):
    ret, frame = cap.read()
    if not ret:
        break

    with torch.no_grad():
        outputs = predictor(frame)['instances']

    results = DensePoseResultExtractor()(outputs)
    cmap = cv2.COLORMAP_VIRIDIS
    arr = cv2.applyColorMap(np.zeros((height, width), dtype=np.uint8), cmap)
    out_frame = Visualizer(alpha=1, cmap=cmap).visualize(arr, results)
    out.write(out_frame)

``

Hi @JD-2006,
Thanks for the suggestion. Please feel free to open a Pull Request with this feature and we will be happy to evaluate and merge it!

Cheers! Will do.


wget command to fetch files returns 503 from the web server

The wget command in the documentation (wget --recursive --no-parent --accept zip "http://www2.census.gov/acs2010_5yr/summaryfile/2006-2010_ACSSF_By_State_All_Tables/") is no longer functional. The URL will direct you to a page with a directory listing of the files if you navigate there with a web browser, and can be modified to accommodate other years of census data, but when actually running the wget command you will receive a 503 from the web server as-is, and a 302 followed by a 503 if you remove the quotes around the URL.

Looks like the issue is something badly misconfigured on the census data web server, so I'm going to close this issue. Even trying to wget a specific file from the server returns the same error, and viewing the output from the server with curl shows "Service Unavailable - DNS failure". Nothing to do on your end, unless you happen to have some way to contact the census folks, and mention that their server is behaving badly...

Yep, they have a rather annoying firewall/bot detection system that will block too many wget's. It sounds like you've gotten yourself blocked for a while, but if you forge wget's User Agent header it should help a little bit

Thanks for the info. Seems even with a forged user agent it 302's, then 404's on the redirect when done via wget from a host I have on a different external IP. I'll just download the files I need via browser, and scp them to the server, I guess...


Schema DDL: support REVISION migration into string/number union type

Migrated from https://github.com/snowplow/schema-guru/issues/137

Migrated to https://github.com/snowplow-incubator/schema-ddl/issues/30


AnimationPlayer keyframes not displaying true time value.

This may be an enhancement/suggestion, but my partner had ran into what she thought was a bug.  She couldn't overwrite a keyframe.
I looked at it in the editor, and it was showing:

But in the .tscn file it was actually:

The best I can deduce is that this can happen when you have the time step set to 0.
Some hours were lost to it, so I thought to report it since it might be something that could trip others up.
Maybe the time information can round off only zeroes, so it can be seen in the editor, or maybe there might be some reasonable minimum on the keyframe step sizes so they'll clamp to a smaller decimal precision.
Above and beyond that may be a special indicator when multiple keyframes are very tightly grouped, and for the current information popup when hovering, it might be helpful if it were to show a list of these super close keyframes.

Closing.  Haven't encountered this one in the last year or so.  May of been addressed incidentally in one of the many updates to the AnimationPlayer over the years.


suport watch mode for exec

call exec repeatedly until user defined condition e.g. number of times, get specific output pattern, etc.

watch() is introduced from v1.4.0


Stress Level detection

🔍 Problem Description:
This project will help to know about mental health of any body becoz in todays era many of person have lots of stress  for while working in job  , or etc
🧠 Model Description:
sklearn , eda , data cleaning , data processsing
⏲ Estimated Time for Completion:
today
To be Mentioned while taking the issue:

What is your participant role? GSSOC 24 Extd

@yashasvini121 pls assign me this issue as this is important topic based on today's  era !

@yashasvini121 !

@yashasvini121 pls assign me this issue I want to work on it!


C-style line comment in scaffolding manifest.json?

In:
https://github.com/cleidigh/ThunderStorm/blob/master/examples/scaffolds/tb-mail-ext-bare/manifest.json
there's a line beginning with //. Is that intentional? Is that valid? Even if it is - it merits some explanation.

@eyalroz
Good observation, and does to serve for comment (pun intended)
The Web/Mail Extensions manifest.json is allowed to be in either straight json or json(c) which allows for comments in JavaScript format.  I will add a comment and have Ryan do the same in the tutorial.

Addressed with file comment.
Need to add to tutorial


Authentication Key Chains - Serialization / Deserialization

This does not support BLS Key Chains.
This does not keep track of how many keys have been issued.  At first we only need one.  If the user wants to "reset" the blockchain user key, then this will not keep track of that.
Additionally, we don't have a standard scheme for that.  Would we use '1'th key instead of '0'?

This needs more work based on what we are doing in #49

This may be replaced by #41 as much was learned.


[Bug]: flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:103: attempt to index field 'priorities' (a nil value)

Describe the bug
Getting an error when opening a file that has LSP Colors (did not make any changes to my config), but the issue started today
Error executing vim.schedule lua callback: ...flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:103: attempt to index field 'priorities' (a nil value)
stack traceback:
        ...flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:103: in function 'hl_range'
        ...flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:128: in function 'color_background'
        ...flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:224: in function 'buf_color'
        ...flutter-tools.nvim/lua/flutter-tools/lsp/color/utils.lua:183: in function 'handler'
        ...w/Cellar/neovim/0.6.0/share/nvim/runtime/lua/vim/lsp.lua:957: in function 'cb'
        vim.lua:285: in function <vim.lua:285>

To Reproduce
Steps to reproduce the behavior:

Open any .dart file that has one of the LSP Colors, such as Colors.deepOrange, Colors.purple.2.
After opening, highlighting starts working on other options but when it gets to color, the error occurs
Colors are not highlighted

Expected behavior
Colors should be highlighted and no error should show
Screenshots

System information

OS: MacOS 12.2.1
Flutter version: 2.10.2
Is flutter in $PATH: yes
neovim version: 0.6.0

Thanks for reporting this @sollymay pushed a fixed which should have resolved this


Adding upperSearchResultLimit to search layer avoid pagination.

Merging straight to master since this is a hot fix.

[Current coverage][cc-pull] is 98.63%

Merging [#55][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master        #55   diff @@
==========================================
  Files            59         59
  Lines          1673       1679     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1650       1656     +6
  Misses           23         23
  Partials          0          0

Powered by Codecov. Last updated by [45ae241...44b69c9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/kyle-long/pyshelf/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/kyle-long/pyshelf/compare/45ae24185d7b83973123ed0a5c970fd7520da619...44b69c9f4078ba00871149ab1ec5ffc174e9c9c3
[cc-pull]: https://codecov.io/gh/kyle-long/pyshelf/pull/55?src=pr


ESXi ISO files?

Are the following ESXI ISO URLs intended to be here? Does the license allow for them be used like this?
https://github.com/tinkerbell/crocodile/blob/1bce37092cb2c438a7c6dd4dcd639ee6555ea3ee/crocodile.sh#L15-L17

Not sure, I'll remove them for now and leave people to host their own images or point to their own URLs.


Distinguish servers by server-name, port and user in output

Is your feature request related to a problem? Please describe
When you access multiple hosts with the same hostname but different ports (e.g. running multiple virtualized servers on one host) you can't distinguish one from each other in the output.
config-example:
servers:
  VM1:
    host: root@server:22001
  VM2:
    host: user@server:22002
  VM3:
    host: root@server:22003

Running a task like an os-prober will create:
 host               | OS
--------------------+----------------------------------------------
 server             | Debian 11
 server             | Debian 10
 server             | Debian 11

The information about the different servernames, ports etc. is missing
Describe the solution you'd like
The output should (optionally) contain information about the server-name (VM1, VM2, VM3 in the example above) and / or port and username.
Additional context
./.

Yes, I have that feature on the roadmap, pretty much similar solution to the header prefix you can customize in themes (uses go templates so you can use conditionals):
themes:
    default:
        text:
            prefix: true
            header: '{{ .Style "TASK" "bold" }}{{ if ne .NumTasks 1 }} ({{ .Index }}/{{ .NumTasks }}){{end}}{{ if and .Name .Desc }} [{{.Style .Name "bold"}}: {{ .Desc }}] {{ else if .Name }} [{{ .Name }}] {{ else if .Desc }} [{{ .Desc }}] {{end}}'
        table:

I'll try to implement it this week.

A bit late, but v0.14.0 now supports updating the prefix for text and table output:
themes:
  default:
    text:
      # Available variables: `.Name`, `.Index`, `.Host`, `.Port`, `.User`
      prefix: '{{ .Host }}'

    table:
      # Available variables: `.Name`, `.Index`, `.Host`, `.Port`, `.User`
      prefix: '{{ .Host }}'

Let me know if works!

This solves the problem perfectly! Thank you :)


Drop torch dependency

Currently including a torch dependency, because otherwise I run into:
/Users/joel/mambaforge/envs/fractal-faim-hcs-test/lib/python3.9/site-packages/anndata/experimental/pytorch/_annloader.py:15: in <module>
    import torch
E   ModuleNotFoundError: No module named 'torch'

During handling of the above exception, another exception occurred:
tests/test_fractal_tasks.py:10: in <module>
    from fractal_faim_hcs.fractal_create_ome_zarr_md import create_ome_zarr_md
src/fractal_faim_hcs/fractal_create_ome_zarr_md.py:10: in <module>
    from faim_hcs.Zarr import build_zarr_scaffold
/Users/joel/mambaforge/envs/fractal-faim-hcs-test/lib/python3.9/site-packages/faim_hcs/Zarr.py:11: in <module>
    from anndata.experimental import write_elem
/Users/joel/mambaforge/envs/fractal-faim-hcs-test/lib/python3.9/site-packages/anndata/experimental/__init__.py:2: in <module>
    from .pytorch import AnnLoader
/Users/joel/mambaforge/envs/fractal-faim-hcs-test/lib/python3.9/site-packages/anndata/experimental/pytorch/__init__.py:1: in <module>
    from ._annloader import AnnLoader
/Users/joel/mambaforge/envs/fractal-faim-hcs-test/lib/python3.9/site-packages/anndata/experimental/pytorch/_annloader.py:18: in <module>
    warnings.warn("Сould not load pytorch.")
E   UserWarning: Сould not load pytorch.

Not sure why this happens, the anndata code is supposed to handle that issue with a try except here: https://github.com/scverse/anndata/blob/e067515887e0badfa5e02b7a75ac66679215ec2c/anndata/experimental/pytorch/_annloader.py#L15
Test it further, see if I can drop the dependency

Actually, even with anndata 0.8.0, we can import write_elem from the _io.specs subpackage already and it works. But importing from experimental leads to torch issues.

Closed with 0c2103b03f661c80fee9ccbd27a2f3f26ded4ae4  in faim-hcs branch.


Fix #363

Files are removed but there is no way to know if a directory already existed before so they are kept.

Thanks!


[Android] support onMomentumScrollEnd event after programmatic scroll to match iOS behavior

Summary
This commit addresses two issues:

The recent changes to handlePostTouchScrolling introduced two extra onMomentumScrollEnd events.  Only one should be fired when the scroll is complete, not three
on iOS, an onMomentScrollEnd event is fired even when the scroll is caused programmatically.  These changes make Android behave in the same manner, ensuring that you get an end event, regardless of how the scroll was initiated.

This addresses this issue that was raised over a year ago:
https://github.com/facebook/react-native/issues/26661
and this issue from 2018
https://github.com/facebook/react-native/issues/21718
Changelog

[Android] [Fixed] - Support onMomentumScrollEnd event after programmatic scroll to match iOS behavior
Test Plan

I have made updates to the RNTester app to demonstrate the changes, specifically in FlatListExample and ScrollViewSimpleExample.
With the FlatListExample, type into either the scrollToIndex... or the (new) scrollToOffset... text boxes and watch the onMomentumScrollEnd log message appear.  Similarly, you can manually scroll the scroll view and see both begin and end scroll events (and only one end scroll event)
With the ScrollViewSimpleExample, tap the new buttons on the top and watch the logs.
You can now run the app on both Android and iOS and see the same behavior.

The last two failures are unrelated to my changes.  This PR should be good to merge...

so sad :(


File type should be recognized even without extension in file name

it forces me to download the file, because lbry cant display it, since there is no extension to recognize file type.

Can you give us an example of the file/claim? I don't think you can upload something now without a file extension....
There is a known issue on Firefox with a file name that has spaces in it - maybe that's what you ran into?

I dont have an example now, I created this issue when @CryptoHustler101 published a video vithout extension, so he needed to reupload because it couldn't be played.

Closing for now, it should not be possible to upload a file without an extension.


feat(enhanced-readabilities): option to disable animation

feat(enhanced-readabilities): option to disable animation

Rest of the code LGTM, thanks for contributing!


Draft: Use sls_sdk internally

Description
Related issue https://linear.app/serverless/issue/SC-708/urgent-python-sdk-breaking-customers-functions

Use the internal module name sls_sdk to access the base SDK from Lambda SDK.
Import serverless_aws_lambda_sdk from the wrapper script.

Testing done

Unit/Integration tested

@medikoo I'm trying to add an integration test for the dashboard instrumented case. Do we have an example of a lambda test fixture where the lambda package contains more than one file? In this new test we'll need to ship multiple files:

We can simplify this by mimicking the dashboard's serverless_sdk import, but still we'll need to have at least two files: one for the handler and another for serverless_sdk.py that represents the dashboard sdk.

I'm exploring fixturesDirname I think this is intended for this purpose.

Got it, the integration test bundles the whole fixtures directory 👍

@medikoo ready for review please 🙏


[BUG]: CrashLoopBackOff and OOMKilled issue in pod : Dell CSM Operator Manager POD

Bug Description
Hi Team, customer is experiencing CSM Operator Controller POD restarts due to OOMKilled error, they applied the increase in the memory limit from 256mi to 512mi but still experiencing restarts.
Logs
CSM logs.txt
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Customer tried redeploying and still issue arises. Also experiencing same error in different site.
Expected Behavior
CSM Pods should not be restarting
CSM Driver(s)
Dell CSM Operator 1.3.0
Installation Type
CSM Operator
Container Storage Modules Enabled
No response
Container Orchestrator
Openshift 4.12
Operating System
Redhat Core OS

/sync

/sync

Hi Team, is there workaround to increase memory limit to higher than 512mi?

@jpand15 -- sorry for the late response. Looked into this yesterday with @daniyaliqbal2024, and we have not been able to replicate the issue on an internal 4.12 setup. There were no details provided on what the operator is managing, but based on the logs, it looks to me like it is csi-powerstore with resiliency enabled -- is that correct? If you could provide the following, that would be helpful:
Output of oc get csm -A
Output of oc get csm <name> -n <namespace> -o yaml for each CSM object on the cluster
A resource utilization graph from OpenShift for the operator similar to this one that a customer provided in a previous escalation.
Also, is the customer's openshift setup setting memory limits for k8s nodes that are causing the OOM killer to run because the node is running past its memory limit? One thing I noticed is that the resource request for the operator is set to192 Mib, and, based on K8s documentation, this is the value that K8s uses to help select what node to schedule the operator on. Is it possible that the operator is getting scheduled on a node that has 192Mib of memory available, but not 512Mib? This could cause the OOM killer to kill the operator not because it is exceeding 512Mib, but because it is exceeding memory on a node that had 192 Mib but not 256 or 512 Mib available? You could experiment with this by increasing the request from 192 to 512 as a starting point.
We would be happy to jump on a call with the customer if that helps -- we have not been able to replicate this locally, so it would be interesting to see the setup where the issue is occurring.

Also, to answer your question -- you can modify the resource request and limit values by editing the operator pod and increasing the limits both to 512. You can also update the operator.yaml file and reinstall with the new values.

Hi Team, thank you for your reply, have requested the customer to try out increasing the request memory limit from 192M to 512Mi will update of the findings. Also attached are the requested logs.
CitadelProd1.zip
DavaoProd1.zip
Citadel Site

Davao Site

@jpand15 thanks for the update -- unfortunately, I'm having a little trouble understanding the graphs. Can you give me an example timestamp for one of them where an OOM kill happens? To me everything looks pretty steady.

@jpand15 thanks for the update. As we are unable to reproduce this error locally, I'm not sure how much more I can offer in terms of suggestions. If you'd like, I'm happy to jump on a call with the customer and take a closer look at the problem and get a better understanding of their setup.

Sure I'll try to setup a call with them what is your available time in your timezone, we are in the APJ region btw.

@jpand15 I can be free as early as 5:30 AM Eastern Daylight Time (I'm happy to get up early). Feel free to ping me on slack or email me at<EMAIL_ADDRESS>and we can find a time!

Copy @jooseppi-luna will check with customer for their availability and advise you of the schedule.

@jpand15  : Please reopen the issue if it still persists


Something in 1.13 broke centering child windows

Describe the bug
On 1.12.1, a child window added to another window at run-time, with X and Y set to Dim.Center() is displayed in the center of the parent Window that it is added to.
In 1.13.x, the child window is placed at 0,0 when shown. This occurs on Ubuntu 23.04 and on Windows 11 in PowerShell.
If the terminal is resized down and then to a size larger than the child window, it then centers itself.
I set a breakpoint to see what was going on.
In 1.13.x, the superview of the child has 0 width and height, even though the parent Window itself has the expected dimensions.
In 1.12.x, the superview of the child has the expected dimensions of the parent window.
Note that both of these Windows were created using the TerminalGuiDesigner tool.
The code used to add the child to the parent is just three lines (edited for verbosity):
//Elsewhere in the parent window class:
ChildWindowClass _childWindowAsAFieldBelongingToParentWindow = null;

//Function called by any means to create and show the child for the first time:
public void FunctionThatAddsTheChildWindow()
{
        _childWindowAsAFieldBelongingToParentWindow ??= new( );
        Add( _childWindowAsAFieldBelongingToParentWindow );
        ShowChild( _childWindowAsAFieldBelongingToParentWindow );
}

To Reproduce
Steps to reproduce the behavior:
Using 1.13.X (seems broken for any version of 1.13):

Create a Window with width and height = Dim.Fill(0)
Create a Window with explicit dimensions (any will do, so long as they're smaller than the terminal), and with X and Y = Dim.Center().
Add that second Window to the first Window, and show it.
The child window will be at 0,0,

Expected behavior
The child window should be shown positioned at the center of the parent window it was added to, as in 1.12.
Desktop (please complete the following information):

OS: Windows 11 and Ubuntu 23.04
Terminal: Happens on any terminal emulator or shell I've tried, including just at a bash prompt, tmux, screen, and zsh.

Started happening after updating to the 1.13 release series.
No code changes were made.

I've also tried explicitly calling SetNeedsDisplay on both the parent and child windows, as well as manually changing the X and Y of the child window after it is shown. These have no effect, and the direct superview of the child window still shows dimensions of 0x0, while the parent window itself shows dimensions of 153x57.

This is the commit that broke it: 58ad65f34800a87a9223cf24711d50db6eefcbe7

After further experimentation, a call to LayoutSubviews() on the parent window does seem to force the child to center, but this doesn't seem like it should be necessary.

This is the commit that broke it: 58ad65f

@BDisp I think we should revert https://github.com/gui-cs/Terminal.Gui/issues/2686. I accepted that PR against my better judgement ... we should not be taking fixes like that into v1, if there's a workaround. Agree?

Using 1.13.X (seems broken for any version of 1.13):
1. Create a Window with width and height = Dim.Fill(0)

It's enough Dim.Fill().

2. Create a Window with explicit dimensions (any will do, so long as they're smaller than the terminal), and with X and Y = Dim.Center().

Must be X and Y = Pos.Center().

3. Add that second Window to the first Window, and show it.

4. The child window will be at 0,0,

And it's right because the second Window is only specifying the X and Y and not the Width and Height, where the base class (Toplevel) set them to Dim.Fill(). The X and Y = Pos.Center depends on Width and Height and as they have all the first Window size, the X an Y are both equal to 0.

Expected behavior The child window should be shown positioned at the center of the parent window it was added to, as in 1.12.

To positioned at the center of the parent window you must speechifying a size smaller than the parent window. e.g. Width = 10, Height = 10.

This is the commit that broke it: 58ad65f

@BDisp I think we should revert #2686. I accepted that PR against my better judgement ... we should not be taking fixes like that into v1, if there's a workaround. Agree?

No, because it isn't a bug but by design. If Width is Dim.Fill() X will be 0 and if Height is also Dim.Fill() the Y will be also 0. Using Width = Dim.Fill (10), Height = Dim.Fill (10) will achieve the desired behavior.

Did this behavior change beteween 1.12 and 1.13 or not?

I think there is no problem with the commit https://github.com/gui-cs/Terminal.Gui/commit/58ad65f34800a87a9223cf24711d50db6eefcbe7. It only handles with color and not with layout. Any view that is centered on a parent is always based on the child size. If the child has the same size of the parent, then the location will always be 0,0. I think I've very clear about the issue that @dodexahedron exposed.

So, @dodexahedron is incorrect that something changed between v1.12 and 1.13?

So, @dodexahedron is incorrect that something changed between v1.12 and 1.13?

He may have some reason if it's another behavior than what he described in this issue. But only him can confirm that or providing a valid code that reproduce it. The one he provided with two Window that is derived from Toplevel, omitting the Width and Height they default to Dim.Fill().

I also compared the  current version of the View.cs file with an older version and there isn't any change that may have cause some layout issue.

There absolutely is a change, but it is not to View.cs.
It is in Border.cs
That commit breaks it. Immediately prior, it works as expected. With it, it does not work as expected.

To positioned at the center of the parent window you must speechifying a size smaller than the parent window. e.g. Width = 10, Height = 10 or Width = Dim.Fill (10), Height = Dim.Fill (10).

It is.
Perhaps I wasn't clear enough...
Parent window is Dim.Fill(0), and has dimensions that can be inspected as the values I stated.
Child has explicit width and height, smaller than parent, and is added to parent as shown.
It is displayed at 0,0, initially, and only correctly places itself if the window is resized.
The Superview, as Visual Studio shows it on inspection, is not the parent Window itself, but some other object or interface. It isn't something that I made explicitly. And it has width and height of 0. The parent window does not have width and height 0.

This is the parent:

This is the child:

Using 1.13.X (seems broken for any version of 1.13):
1. Create a Window with width and height = Dim.Fill(0)

It's enough Dim.Fill().

2. Create a Window with explicit dimensions (any will do, so long as they're smaller than the terminal), and with X and Y = Dim.Center().

Must be X and Y = Pos.Center().

3. Add that second Window to the first Window, and show it.

4. The child window will be at 0,0,

And it's right because the second Window is only specifying the X and Y and not the Width and Height, where the base class (Toplevel) set them to Dim.Fill(). The X and Y = Pos.Center depends on Width and Height and as they have all the first Window size, the X an Y are both equal to 0.

Expected behavior The child window should be shown positioned at the center of the parent window it was added to, as in 1.12.

To positioned at the center of the parent window you must speechifying a size smaller than the parent window. e.g. Width = 10, Height = 10 or Width = Dim.Fill (10), Height = Dim.Fill (10).

Yes, The Dim/Pos mixup was just my mistake typing up the issue.
The windows were created with TerminalGuiDesigner and the dimensions and positions are set properly. That would be a compile error anyway since that's not a method that exists.
See the screenshots I've provided and the code linked in my latest update if there's doubt it's being used correctly...
This behavior did change, and it changed in the commit I referenced, which I confirmed by building myself, including the commit immediately before it on the develop branch.

Please run this code and tell me if have some issue:
			Application.Init ();

			var childWin = new Window {
				X = Pos.Center (),
				Y = Pos.Center (),
				Width = Dim.Fill (10),
				Height = Dim.Fill (10)
			};
			var win = new Window () {
				Width = Dim.Fill (0),
				Height = Dim.Fill (0),
			};
			win.Add (childWin);
			Application.Top.Add (win);

			Application.Run ();
			Application.Shutdown ();

In 1.13.x, the child window is placed at 0,0 when shown. This occurs on Ubuntu 23.04 and on Windows 11 in PowerShell.
If the terminal is resized down and then to a size larger than the child window, it then centers itself.

I didn't have time to test your repo but maybe there is needed some call to SetNeedsDisplay() because was removed much code which was causing repetitive print, affecting performance. If SetNeedsDisplay() isn't called or is called, mainly on a change during a redraw process or in a thread, the NeedsDisplay will be empty. To ensure that the NeedsDisplay will be set is calling this way Application.MainLoop.Invoke(() => myView.SetNeedsDisplay()). Thus, in the next iteration will check for idle handlers to be run. Otherwise, only by resizing the UI is updated.

(Links in this comment are directly to specific lines of interest)
SetNeedsDisplay() was one of the first things I tried, both on the parent and the child, but it does not fix the problem.
This application is started by Application.Run( ErrorHandler );
The UI is not particularly complex, either.
It is a class inheriting from Window (see here) that contains a menu bar and has IsMdiParent=true. Menu items have actions which create and show the window as described (or as seen here).
It happens with all three of the other Window classes in that application, which, as mentioned, were created with TerminalGuiDesigner.
The child windows all have dimensions and positions like this (excerpt from here):
            this.Width = 148;
            this.Height = 26;
            this.X = Pos.Center();
            this.Y = Pos.Center();

The parent has this:
            this.Width = Dim.Fill(0);
            this.Height = Dim.Fill(0);
            this.X = 0;
            this.Y = 0;

What is odd to me is that the Superview of the child window is not the parent Window:

Why is that? Is it because of how borders are drawn?
This all sticks out to me as possibly unintended consequences of the performance optimizations coupled with the changes to Border.cs. I have not dived into the various optimizations made, but instinct is telling me that, based on this behavior, it's likely that something was overlooked in the way things are arranged and an additional call to LayoutSubviews() or something similar may be needed, if those optimizations are left in place.

I'm putting together a simpler example, at the moment, both to validate or disprove what I see happening and, if validated, to try to narrow down exactly what is causing it, at least in the application code.

Example complete.
This is about as basic as it gets.
Two window classes, both made using TerminalGuiDesigner.
Application starts by running the parent window.
Use the menu to add the child window. It will not be centered.
TerminalGuiCenterBugExample.zip

Here's a screen recording of running that application.
https://github.com/gui-cs/Terminal.Gui/assets/8242181/9b5041b5-8971-447c-8aa6-d3490527de08

Nothing I have tried other than calling LayoutSubviews() seems to fix it.
I've tried commenting out everything unnecessary for successfully running the application (aside from the position and dimensions), including not having the menu (in case that was somehow interfering) and just showing the child on a keypress, with the same result.
If I set IsMdiContainer = true on the parent window, it also throws an exception that "End must be balanced with calls to Begin" immediately upon showing the child.

@dodexahedron you don't need to call ShowChild( _childWindow ); because this method is used when IsMdiContainer = true. If you want to see a MdiContainer sample check the BackgroundWorkerCollection scenario on the UICatalog project.
I already fixes this issue where a Window dynamically added was not calling the LayoutSubviews itself.

@BDisp I am still confused.
@dodexahedron's code was working fine in v1.12. It does not work fine in v1.13.
Do we understand what set of changes caused his code to stop working?

@BDisp I am still confused.
@dodexahedron's code was working fine in v1.12. It does not work fine in v1.13.

I already reverted the https://github.com/gui-cs/Terminal.Gui/commit/58ad65f34800a87a9223cf24711d50db6eefcbe7 and with the https://github.com/gui-cs/Terminal.Gui/files/12190256/TerminalGuiCenterBugExample.zip sample that he provided, I still have the same issue that he stated. Perhaps maybe be any other commit.

Do we understand what set of changes caused his code to stop working?

No, because as I told the issue isn't fixed by reverting the commit. But @tig, please test it by reverting the commit and see if you have more luck.

Check out the commit immediately prior to it - don't just revert it. You wont get the behavior. Then check out that commit. You'll get the behavior. I did it by rolling forward, commit by commit, til it broke, and that was the commit that broke it. 🤷♂

I already did a hard reset until the commit prior to it and I still can't get your sample to work with center the child on opening, sorry about that. @tig please help me to check if I'm doing something wrong. Thanks.

Hmm. I will do it again next time I'm at a computer.
I don't want that to be a red herring, though. Running the example application with 1.12 vs 1.13 shows the difference, so it's some commit (or blcomb8nations thereof) between them.

@dodexahedron you don't need to call ShowChild( _childWindow ); because this method is used when IsMdiContainer = true. If you want to see a MdiContainer sample check the BackgroundWorkerCollection scenario on the UICatalog project. I already fixes this issue where a Window dynamically added was not calling the LayoutSubviews itself.

Thanks for the tip. 😊

I already run your sample with 1.12 version and still doesn't center the child.
How can I get your repo to run? I get this error:
'./Documentation/SnapsInAZfs.8' -> '/usr/local/man/man8/SnapsInAZfs.8'
install: cannot create regular file '/usr/local/man/man8/SnapsInAZfs.8': No such file or directory
make: *** [Makefile:116: install-doc] Error 1

That's actually a helpful thing that should be an issue filed for that project, since the Makefile has only been tested on a small number of environments and probably does have shortcomings on others that haven't been tested explicitly. Thanks for mentioning.
What distro and version are you using, and what .net SDK version?
I've tested that Makefile on Ubuntu 22.04, 22.10, and 23.04, as well as CentOS Stream 8, but that's it, so other environments certainly could have trouble, which I'd like to address so it's easy for anyone.
That error looks like your distro's manpages are probably stored in other directories, and the make install recipe calls the documentation install recipe implicitly, which is what looks like is erroring out.
You can run the individual make recipes that make install runs, without the documentation recipe, or you can run make publish and then just run the application from the publish directory that will be created in the solution folder, without having to install it. Alternatively, you can override the manage directories by passing the appropriate variables into the call to make, but I'm not at a PC right now, so I couldn't tell you off the top of my head which ones you'd have to set.
You can also run it on Windows from visual studio if you set the configuration to Debug-Windows and add the --config-console argument to the debug launch configuration. That configuration doesn't call anything in ZFS and just uses dummy input data files to simulate it, for debug purposes, and gives enough to provide a useful sample for debugging the configuration console.
However, I don't imagine you should really need to bother with all that for this, since the little sample I put together also demonstrates the problem, though I totally appreciate you trying to run it where I initially found the problem. 😊

@BDisp I am still confused.
@dodexahedron's code was working fine in v1.12. It does not work fine in v1.13.
Do we understand what set of changes caused his code to stop working?

To be fair, I can't guarantee that the commit I referenced is solely responsible for the problem (I only tried commits in order until it broke), but I can guarantee the behavior changed between the last 1.12 release and the first 1.13 release, and still exhibits the same behavior in the most recent 1.13 release as of Friday.
The sample application I provided in this thread uses the same method for starting the TUI, creating the child windows, and showing them as the application I discovered the issue in. That sample also, when I ran it, properly centered the child window with 1.12 selected in nuget and does not center it with 1.13.x selected in nuget.
I can provide another screen recording showing it, later, if needed.

@Bdisp, just to keep things clean and separated, if you could mention your environment in the issue I just linked (also provided below), it would be greatly appreciated. 😊
https://github.com/snapsinazfs/snapsinazfs/issues/23

On Windows I already tried using the --config-console argument but always getting error on IConfigurationRoot nlogJsonConfigRoot = new ConfigurationManager( )
Running from the publish I get the error You must install or update .NET to run this application., but I have 7.0.* installed.
$ dotnet --info
.NET SDK:
 Version:   7.0.306
 Commit:    f500069cb7

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  22.04
 OS Platform: Linux
 RID:         ubuntu.22.04-x64
 Base Path:   /usr/share/dotnet/sdk/7.0.306/

Host:
  Version:      7.0.9
  Architecture: x64
  Commit:       8e9a17b221

.NET SDKs installed:
  6.0.412 [/usr/share/dotnet/sdk]
  7.0.306 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.20 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.9 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 7.0.9 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/lib/dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Interesting.
Looks like a dotnet or system issue in resolving the proper version of .net to invoke, which is odd, since it's being compiled as a R2R assembly (when using make publish), and even more odd since the project file explicitly specifies the runtime to use.
I'll have to set up a test VM with both 6.0 and 7.0 to see if I can reproduce that behavior. I imagine I'll need to pass another flag or two to the compiler to avoid that issue on similar systems.
On windows, it's likely the configuration json files specify a bad path for the nlog output, as I have a dev copy of those files on my local machine I've never committed to git.
Just to verify, are you cloning from/checking out the RC1 tag?

That version of .net 7 was either manually installed or installed from the microsoft-prod apt repository, yes? The one in the canonical repository for ubuntu is 7.0.109.
Here are the results of attempting to reproduce the issue you're encountering:

I can duplicate similar failure to launch behavior with the SDK installed from the microsoft-prod repository, even without also having version 6 installed.
a. In the past, I've noticed other problems with dotnet on Ubuntu, installed from the Microsoft repository, in various other applications. It seems Canonical must add some customizations of their own to make it work smoothly in Ubuntu. There are many threads around the internet with this same problem, and they are resolved by using the packages provided by canonical.
I ran apt purge dotnet* --autoremove to remove all dotnet components from that test VM, removed the microsoft-prod repository from my apt configuration, and then installed the dotnet7 package from ubuntu's repository, and the application worked without problem.
I then also installed the dotnet6 package and ran the application again, to see if 6 was interfering, and it worked without issue and without needing to recompile.
I recompiled anyway, with both SDKs present, to see if that made any difference, but the application still launched correctly.

This was on a freshly-installed and otherwise empty Ubuntu server VM.
Again, though, I didn't intend for you to spin your wheels trying to get that to work, especially since your PR #2778 does appear to fix the behavior, in the test I just ran on my dev machine.

Also, there is difference in the dotnet --info output using the canonical-provided dotnet packages vs the microsoft-provided packages.
See this, for example, from that 23.04 test VM, with the canonical packages installed:
dotnet --info
.NET SDK:
 Version:   7.0.109
 Commit:    3e9283a8e9

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  23.04
 OS Platform: Linux
 RID:         ubuntu.23.04-x64
 Base Path:   /usr/lib/dotnet/sdk/7.0.109/

Host:
  Version:      7.0.9
  Architecture: x64
  Commit:       8e9a17b221

.NET SDKs installed:
  6.0.120 [/usr/lib/dotnet/sdk]
  7.0.109 [/usr/lib/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.20 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.9 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.20 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.9 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/lib/dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

So I imagine there are probably plenty of other customizations canonical has made that microsoft has not, in their packages, which otherwise require manual configuration if installed from the microsoft repo.
In your specific case, note that in dotnet --info, it's saying everything is in /usr/share, but the runtime itself is looking in /usr/lib, and your $DOTNET_ROOT also points to /usr/lib. Changing that to point to where it's actually installed might fix things.
Also, what is the output of cat /etc/dotnet/install_location_x64 and which dotnet?

Further investigation, with the microsoft dotnet-sdk-7.0 package installed, which yields similar configuration as yours, revealed that this is enough to get it running without modifying other configuration:
ln -s /usr/share/dotnet/sdk /usr/lib/dotnet/sdk
The reason is the microsoft package puts the SDK in the /usr/share folder, but everything else is in /usr/lib, and it looks in $DOTNET_ROOT to find SDKs. Making the symbolic link to the actual installation path allowed it to find it on that test system, and should be a durable solution across apt upgrade runs.

I've published RC2, which incorporates the manpath changes, so, if you want to keep trying it out, that release should make it easier on you.

Works in Edge and Chrome on my windows 11 machines. 🤷♂
I'll use VP9 or something if I have to post another.

Works in Edge and Chrome on my windows 11 machines. 🤷♂

I use Firefox and it not work, but I tried on the others browsers and it's only work on Chrome and not Edge. Perhaps you installed some extensions for that. What's app you use to record videos?

I'll use VP9 or something if I have to post another.

No bother because I can see it on Chrome.

Nah, that's a known thing about Firefox. HEVC is theoretically patent-encumbered, so Firefox doesn't include support for it by default at this time.

But do you know why it's not working on Edge for me?
I use ScreenToGif to create gif but I would like something where I can create a video. What do you recommend?

Couldn't tell ya for sure. I haven't really had to think about codecs since Windows 8 or 10. But, just guessing, perhaps different editions of Windows may not include HEVC by default. The N editions of Windows, for example, tend to be missing some multimedia features as a result of old anti-competition lawsuits.

Thanks for the clarification, but I have Windows 11 Pro, which I think it should have. Perhaps it's only for insiders for now 😃

Hm. I'm not on an insider build on this machine. There is an N version of Pro, as well. Could also be a regional thing, I guess, depending on laws and distribution rights and whatnot wherever you live. Or could be something to do with the installation image, or perhaps another piece of software that broke it. There are too many possibilities, so any of those would just be a guess. It's also possible, I suppose, that the specific set of encoding options I used may simply not be supported by your system, as I did use a few less-common features to minimize the file size. But that's also just a guess.
Wish I could provide more definitive help on that.

I already get it running on Windows 11 using Visual Studio 2022:
All the output are create at \snapsinazfs\SnapsInAZfs\bin\x64 and \snapsinazfs\SnapsInAZfs\obj\x64
https://github.com/gui-cs/Terminal.Gui/assets/13117724/174f3f41-e1bf-4d48-8701-5094357dae7b
But if I try running it on Windows 11 using VSCode I get an error. I'm curious if it's a lacuna on VSCode by not respecting the <Platforms>x64</Platforms> or if it's needs do add some some configuration for the VSCode.
I think the problem is the VSCode is building on \snapsinazfs\SnapsInAZfs\bin\Debug and \snapsinazfs\SnapsInAZfs\obj\Debug which isn't compatible with x64.

Thanks for your assistance with this.
Since it isn't Terminal.Gui related, though, perhaps we should move this discussion to that project.
As a general note, it wasn't designed with the original intention of working in VSCode on Windows, but that's perhaps something I should consider for future revisions.
My initial thought, from what you showed, is that you're probably using the Debug configuration, yes? If so, and if on Windows, that's expected not to work. The only configuration that has any real chance of working on Windows is the Debug-Windows configuration.

Just a thought:
When taking a look at the open issues, my spidey sense perked up when I saw #2672, as it seems this case might be relevant to verify against anything done for that issue, to avoid a possible regression on this one.
If it's not relevant, then don't listen to me and carry on. 😅

Just a thought:
When taking a look at the open issues, my spidey sense perked up when I saw #2672, as it seems this case might be relevant to verify against anything done for that issue, to avoid a possible regression on this one.
If it's not relevant, then don't listen to me and carry on. 😅

That was an issue for v2 and this one is related to v1. I almost finishing with this. It's taking more time than I expected because I'm creating unit tests for all possible scenarios and in some conditions it gave different results when they shouldn't. So, some more time and it will ready to go.

@dodexahedron I already finished my PR. Can you please test it and verifying if all it's work well. I added two new scenarios from your example, with modifications. On one scenario the child windows is added to the parent as sub-view and on the other scenario the child window run alone as non modal on a Mdi Container parent. Thus, the child window is a parent's MdiChild. Both have methods for create, center, hide/unhide, child border/borderless, parent border/borderless and menu/status bar hide/show. This allow test all possible scenarios beside the unit tests.

Just saw your update.
I had tested the original commit you made a while back, and it fixed the issue for my usage.
Did you make further changes?
If so, I'll gladly check again when I finish what I'm currently working on.

Just saw your update.
I had tested the original commit you made a while back, and it fixed the issue for my usage.
Did you make further changes?

Yes, mostly fixes some bugs with Mdi Container where the child was clear the old position when it's drawing in the new position, leaving a trace behind. I added a lot of tests that proves that all the changes works. Test the CenteredWindowInsideWindow and the CenteredWindowInsideMdiContainerWindow that despite of the similarity behavior they are coded differently.

If so, I'll gladly check again when I finish what I'm currently working on.

Thanks.

Cool. I don't know for sure if I had ever hit that issue, though I may have one time that I just thought it was caused by Windows, when the system was under high CPU load from something else.
I'll check this out later this evening (UTC-7) if I don't forget. 😅

Ah yes. Looking at the PR, it looks like you implemented a much more thorough and likely more efficient fix than the initial fix, which was just adding the call to LayoutSubviews(), which is what I'm currently using as a workaround.
I'll test this in a few minutes and let you know how it went when I'm done.

I checked out BDisp/v1_centering-child-window-fix_2775, compiled in Release configuration, and used that with my code.
I removed the call to LayoutSubviews() I had added to my code and otherwise left it exactly as it currently exists in the siaz-1.1 branch.
The windows center correcly.
However, upon exiting, there is now a pause and then I get a very large stack trace that is being truncated at the top, so I do not know what the exception is. It's not being handed to my exception handler, so it also doesn't get logged by nlog.
All I'm able to see of the stack trace is:
at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Application.ProcessKeyEvent(Terminal.Gui.KeyEvent)
   at Terminal.Gui.WindowsDriver.ProcessInput(InputRecord)
   at Terminal.Gui.WindowsDriver.<PrepareToRun>b__38_0(InputRecord)
   at Terminal.Gui.WindowsMainLoop.Terminal.Gui.IMainLoopDriver.MainIteration()
   at Terminal.Gui.MainLoop.MainIteration()
   at Terminal.Gui.Application.RunMainLoopIteration(RunState ByRef, Boolean, Boolean ByRef)
   at Terminal.Gui.Application.RunLoop(RunState, Boolean)
   at Terminal.Gui.Application.Run(Terminal.Gui.Toplevel, System.Func`2<System.Exception,Boolean>)
   at Terminal.Gui.Application.Run[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Func`2<System.Exception,Boolean>, Terminal.Gui.ConsoleDriver, Terminal.Gui.IMainLoopDriver)
   at SnapsInAZfs.ConfigConsole.ConfigConsole.RunConsoleInterface(SnapsInAZfs.Interop.Zfs.ZfsCommandRunner.IZfsCommandRunner)
   at SnapsInAZfs.Program+<Main>d__5.MoveNext()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext(System.Threading.Thread)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()

I think it is an ArgumentException, because Visual Studio's debug pane does show this:
Exception thrown: 'System.ArgumentException' in Terminal.Gui.dll

I know you mentioned I may be doing something wrong with how the windows are being shown, though.
One of the methods that shows a window is here:
https://github.com/snapsinazfs/snapsinazfs/blob/master/SnapsInAZfs/ConfigConsole/SnapsInAZfsConfigConsole.cs#L133
Note I do have IsMdiContainer=true on the parent window.

There may be an infinite loop situation.
I made the font tiny so I'd get more lines in the console and this is the resulting stack trace (still truncated):
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.View.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Toplevel.ProcessHotKey(Terminal.Gui.KeyEvent)
   at Terminal.Gui.Application.ProcessKeyEvent(Terminal.Gui.KeyEvent)
   at Terminal.Gui.WindowsDriver.ProcessInput(InputRecord)
   at Terminal.Gui.WindowsMainLoop.Terminal.Gui.IMainLoopDriver.MainIteration()
   at Terminal.Gui.MainLoop.MainIteration()
   at Terminal.Gui.Application.RunMainLoopIteration(RunState ByRef, Boolean, Boolean ByRef)
   at Terminal.Gui.Application.RunLoop(RunState, Boolean)
   at Terminal.Gui.Application.Run(Terminal.Gui.Toplevel, System.Func`2<System.Exception,Boolean>)
   at Terminal.Gui.Application.Run[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Func`2<System.Exception,Boolean>, Terminal.Gui.ConsoleDriver, Terminal.Gui.IMainLoopDriver)
   at SnapsInAZfs.ConfigConsole.ConfigConsole.RunConsoleInterface(SnapsInAZfs.Interop.Zfs.ZfsCommandRunner.IZfsCommandRunner)
   at SnapsInAZfs.Program+<Main>d__5.MoveNext()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Int32, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext(System.Threading.Thread)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(System.Runtime.CompilerServices.IAsyncStateMachineBox, Boolean)
   at System.Threading.Tasks.Task.RunContinuations(System.Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()

It is related to having a hotkey handler subscribed.
In the parent window, I have:
        Application.RootKeyEvent += ApplicationRootKeyEvent;

And that function is:
    private bool ApplicationRootKeyEvent( KeyEvent e )
    {
        if ( !e.IsCtrl )
        {
            return false;
        }

        // ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
        switch ( e.Key & Key.CharMask )
        {
            case Key.g:
            case Key.G:
                globalConfigMenuItem.Action( );
                return true;
            case Key.t:
            case Key.T:
                templateConfigMenuItem.Action( );
                return true;
            case Key.z:
            case Key.Z:
                zfsConfigMenuItem.Action( );
                return true;
        }

        return false;
    }

This is to enable ctrl+g, etc to show/hide the child windows.
If I do not subscribe to the event, I do not encounter the exception on exit. But of course that means my hotkeys don't work.
So there might be something wrong with Terminal.Gui.Toplevel.ProcessHotKey(KeyEvent keyEvent), Terminal.Gui.View.ProcessHotKey(KeyEvent keyEvent) or the way I'm using the event.
It only happens when I use ctrl+q to exit ONLY while a child window is still visible. If I hide the child window first, it doesn't happen, and if I don't show the child window in the first place, it doesn't happen, even if I use ctrl+q to quit.

Update to that:
I added a case for ctrl+q to my handler that unsubscribes the Application.RootKeyEvent handler and returns false, but the loop still occurs in the same situations as before, so I don't think it's my handler, specifically, that's breaking it. At least not by itself.

@dodexahedron  why don't you use the Application.Init and using the ErrorHandler to bypass that?


acen needs to pass superadmin of the cloud account

@Acen pass the super admin role in cloudflare to me

Have emailed CF about switching super admin.
Benefits of super admin are two things specifically: Managing billing, adding new users.
Have enabled the load balancing feature on my personal CC until we can switch it over.


ApplicantProgramsService update method

Description
Please explain the changes you made here.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
[Fixes] #<issue_number>

These changes were incorporated into https://github.com/seattle-uat/universal-application-tool/pull/372 in a not so visible way because I used -f pushes and just checked out files from this branch.

These changes were incorporated into #372 in a not so visible way because I used -f pushes and just checked out files from this branch.
Closing!


EurekaAutoServiceRegistration isAutoStartup() support configuration

For now, EurekaAutoServiceRegistration.SmartLifecycle isAutoStartup() is alwasy return true.
So when spring context is start,eureka will register self instance info into eureka server.
But when using embeded webserver,at this time ,web port may be not prepared to accept request.
We found some request error for connection refused,and confirm the cause is eureka register before tomcat start up.
We also notice that in EurekaAutoServiceRegistration,there is a WebServerInitializedEvent listener,but when registration is already start,it will not re-register.
We try to set non-secrue-port to 0 for not start register when context is start.
`
// only set the port if the nonSecurePort or securePort is 0 and this.port != 0
if (this.port.get() != 0) {
if (this.registration.getNonSecurePort() == 0) {
this.registration.setNonSecurePort(this.port.get());
}
if (this.registration.getSecurePort() == 0 && this.registration.isSecure()) {
	this.registration.setSecurePort(this.port.get());
}

}
// only initialize if nonSecurePort is greater than 0 and it isn't already running
// because of containerPortInitializer below
if (!this.running.get() && this.registration.getNonSecurePort() > 0) {
    this.serviceRegistry.register(this.registration);

this.context.publishEvent(new InstanceRegisteredEvent<>(this,
this.registration.getInstanceConfig()));
this.running.set(true);

}`
but it seems not working.We found this.registration.setNonSecurePort(this.port.get()); wont change the InstanceInfo in EurekaClient,there is diferrent InstanceInfo between EurekaClient & EurekaRegistration.
Now we using aop to change this behavior,like this. But we think the best practice is make this auto startup property configurable
    @Around("bean(eurekaAutoServiceRegistration) && execution(boolean org.springframework.context.SmartLifecycle.isAutoStartup())")     public Object around(ProceedingJoinPoint pjp){         return false;     }

Duplicates #3833


fix: trx from raw transaction type

Summary by CodeRabbit

New Features

Enhanced transaction processing for multiple contract types in TRX implementation, improving flexibility and robustness.

Bug Fixes

Improved error handling for missing transaction contracts.

Tests

Expanded test cases to include validation for TriggerSmartContract transactions, ensuring accurate parsing and expected value returns.

@coderabbitai resume

@coderabbitai full review


Adds a module that supports scheduling codebuild CI jobs

@plus3it/terraform this is ready for review.


Mutantion details popunder does not consider StatusReason for height

Seems like something in the height calculations has changed which causes the StatusReason on the dashboard to be unreadable

It's not only in the dashboard, I have reproduced this locally too.
It seems like it only happens when there isn't a "more" button.


fix: in app feedback snags

Description
fixes:
https://www.notion.so/oaknationalacademy/In-app-feedback-snags-41fb8cca4d454b16851537dba899fc6f

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Ability to pass indices to find_record_by_related_id

Coverage decreased (-57.06%) to 3.529% when pulling be1ba7da5652cfa1a5ebe25a684f4401d7b81d2a on benknowles:master into 7da02f69e659bc87b84e21ed3ecef45d3b5e769b on amalc:master.


Belinda_Next_JS_Sprint_7_386_Fix_Product_Tile_Sizing

Adjust Tile sizing for product page to all be consistent

The screenshot shared clearly shows the discrepancy in the product tiles, particularly with the size and layout of the "Shoes" tiles. The updated code solves the tiles to have uniform sizing, which enhances the overall visual coherence of the product page. This adjustment can be seen in the commit where the tile sizes are modified to align better with the design guidelines.
I observed that there are conflicts in the package-lock.json and package.json files. These need to be resolved before merging the changes. The consistency in the tile sizes not only enhances the user exp. but also maintains the integrity of the design, which is crucial for user satisfaction. Once the conflicts are resolved and the draft is finalized, this update will significantly improve the UI of the product page.
Also, I found this great link for solving conflicts on github: (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts).

The Product Card looks good now.
I'm considering whether we should use columns and rows, so users don't have to scroll through each one.

Is this still a draft request @MuhammadNSC? Looks like some of this work could be ready to merge after resolving some conflicts in the package-lock.json (should be easy to resolve, just use whatever is from main).

@brinkbrink I've the issues I was having whit this PR. It can now be merged.
@tinpham5614 having columns will be a good idea especially when there is alot more products on display

@Alzavio The height difference is due the the length of the items description


bug: error related to invalid key 'force' in nvim_set_hl function

Did you check docs and existing issues?

[X] I have read all the docs
[X] I have searched the open and closed issues
[X] I have added screenshots if relevant

Whats your neovim version?
v0.9.1
Operating System
linux
Describe the bug
I set up the theme in my neovim colorscheme.lua and I got this error when I restarted neovim:
i was setting up a new theme in my neovim and I get this error:
Failed to run init for lackluster.nvim
...yanabid/.config/nvim/lua/aliqyan/plugins/colorscheme.lua:80: Vim:E5113: Error while calling lua chunk: .../share/n
vim/lazy/lackluster.nvim/lua/lackluster/init.lua:199: invalid key: force
stack traceback:
^I[C]: in function 'nvim_set_hl'
^I.../share/nvim/lazy/lackluster.nvim/lua/lackluster/init.lua:199: in function 'load'
^I...al/share/nvim/lazy/lackluster.nvim/colors/lackluster.lua:1: in main chunk
^I[C]: in function 'colorscheme'
^I...yanabid/.config/nvim/lua/aliqyan/plugins/colorscheme.lua:80: in function 'init'
^I...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:115: in function <...local/share/nvim/lazy/lazy.nvim/lu
a/lazy/core/loader.lua:114>
^I[C]: in function 'xpcall'
^I.../.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/util.lua:131: in function 'try'
^I...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:114: in function 'startup'
^I...nabid/.local/share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:112: in function 'setup'
^I/home/aliqyanabid/.config/nvim/lua/aliqyan/lazy.lua:14: in main chunk
^I[C]: in function 'require'
^I/home/aliqyanabid/.config/nvim/init.lua:2: in main chunk
stacktrace:

colorscheme.lua:80 in init
~/.config/nvim/lua/aliqyan/lazy.lua:14
~/.config/nvim/init.lua:2

Expected Behavior
I expected the new theme to be applied.
Additional context
I have fixed the bug and the theme is working fine now in my machine. I'll push the commit.

Hey @Aliqyan-21 Thanks so much for the bug report and the PR! Im sorry the colorscheme was giving you trouble!
I just looked over your PR and cannot seem to tell what you changed, I left a code review on the PR #44 to explain why I don't under stand what you changed, could you take a look at it and get back to me?

Sir,
I have took a look, I think I pushed the wrong commit before but now I have
fixed it and committed on the branch the correct code, I have also provided
the link of the commit in comments of the pull request.
On Fri, 28 Jun 2024, 3:53 pm Duncan Marsh, @.***> wrote:

Hey @Aliqyan-21 https://github.com/Aliqyan-21 Thanks so much for the
bug report and the PR! Im sorry the colorscheme was giving you trouble!
I just looked over your PR and cannot seem to tell what you changed, I
left a code review on the PR #44
https://github.com/slugbyte/lackluster.nvim/pull/44 to explain why I
don't under stand what you changed, could you take a look at it and get
back to me?
—
Reply to this email directly, view it on GitHub
https://github.com/slugbyte/lackluster.nvim/issues/43#issuecomment-2196585987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4BS4CURSYRFDWRB5U5ALWTZJU2T5AVCNFSM6AAAAABJ7G7M3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGU4DKOJYG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

thanks for your help, your PR was merged, and then I figured out that the  issue was that force is only allowed in 0.10.0 and above, so I removed the only use of force in highlights
let me know if you still have any issues :)