Fix AutoCorrect bug for displaying Invalid command, and update User Guide

Codecov Report

Merging #176 into master will increase coverage by 0.13%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
+ Coverage     58.85%   58.99%   +0.13%
- Complexity      410      412       +2
============================================
  Files            63       63
  Lines          1823     1829       +6
  Branches        188      190       +2
============================================
+ Hits           1073     1079       +6
+ Misses          692      691       -1
- Partials         58       59       +1

Impacted Files
Coverage Δ
Complexity Δ

src/seedu/addressbook/ui/MainWindow.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

src/seedu/addressbook/autocorrect/AutoCorrect.java
36.53% <0%> (+3.84%)
6% <0%> (+1%)
:arrow_up:

src/seedu/addressbook/data/AddressBook.java
65% <0%> (+6.66%)
13% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4f583...5e0b0a3. Read the comment docs.


Custom montage object not loading to NIRS info

Hello,
I am trying to classify EEG and NIRS data using MNE. The datasets I am using were converted into MATLAB format; therefore, I created my data structures from scratch (raw data, montage files, epochs). I did not have any problems loading and classifying the EEG data, but I realised that raw.set_montage() does not support NIRS channels. When I tried to set the montage file to the info object, the coordinates of the sources and detectors are converted into NaNs.
Do you know if there is an alternative for me to set a montage using NIRS? Thank you!

ping @rob-luke

Hi @Isamaoz,
Can you provide a minimum working example of how you are setting the montage?
I haven't added added NIRS support to set_montage(), so it doesn't surprise me it doesn't work. Taking a quick look at the code I think the following line is just skipping the nirs channels. But the whole code seems quite EEG specific.
https://github.com/mne-tools/mne-python/blob/master/mne/channels/montage.py#L700
I won't be able to add support for this before 0.21. @Isamaoz are you able to take make an attempt at a PR to fix this issue?

Hi @larsoner, this issue also is closed by #9141 🙂

Indeed, thanks!


Feature/implementing save data

Included implementation of:

The saveData method
Related JUnit tests
Changes to Mock Data, etc.

All is well!


Roll Engine from 6f4143e80069 to 54d61cc77e1e (7 revisions)

https://github.com/flutter/engine/compare/6f4143e80069...54d61cc77e1e
2021-10-03<EMAIL_ADDRESS>Roll Skia from 23a66f7fb915 to f843d5cf7212 (1 revision) (flutter/engine#29000)
2021-10-03<EMAIL_ADDRESS>Roll Skia from ce22e059ffeb to 23a66f7fb915 (1 revision) (flutter/engine#28999)
2021-10-02<EMAIL_ADDRESS>Roll Wuffs to 600cd96cf47788ee3a74b40a6028b035c9fd6a61 (flutter/engine#28917)
2021-10-02<EMAIL_ADDRESS>Roll Skia from 906e9eb53841 to ce22e059ffeb (1 revision) (flutter/engine#28996)
2021-10-02<EMAIL_ADDRESS>Roll Dart SDK from 8c385be2c663 to f440a20ff15f (2 revisions) (flutter/engine#28995)
2021-10-02<EMAIL_ADDRESS>Roll Dart SDK from d50eacfa4fcd to 8c385be2c663 (2 revisions) (flutter/engine#28994)
2021-10-01<EMAIL_ADDRESS>Roll Skia from 8e29caf4c130 to 906e9eb53841 (6 revisions) (flutter/engine#28989)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Drop OpenAPI from the onboarding flow

Fixes #776

The issue where the Next step button appears despite a full completion state seems to have crept back in. Can you take a look at this? Otherwise as far as I can see this is good to go after a rebase.

This was how the instructions were working previously. If I run the extension on master I see this on the penultimate instruction page:

It's only on the last instruction page that the button is disabled:

I could change how this works, but it would require another PR in appmap-js, a release of @appland/components and then an update to this PR (or a follow-on PR). I don't really think that's worth doing, but what do you think?

Why does the pie have five slices?
On Thu, Aug 31, 2023 at 1:38 PM Adam Trotta @.***>
wrote:

[image: image]
https://user-images.githubusercontent.com/8737782/264726677-5fb63c33-c67f-46ad-89a5-0a07924c1b0c.png
The issue where the Next step button appears despite a full completion
state seems to have crept back in. Can you take a look at this? Otherwise
as far as I can see this is good to go after a rebase.
This was how the instructions were working previously. If I run the
extension on master I see this on the penultimate instruction page:
[image: image]
https://user-images.githubusercontent.com/45714532/264731068-85cb7628-b28b-4471-a830-a1212e3c38ee.png
It's only on the last instruction page that the button is disabled:
[image: image]
https://user-images.githubusercontent.com/45714532/264730979-04d1e41e-530a-4c10-9f45-375ec93fb657.png
I could change how this works, but it would require another PR in
appmap-js, a release of @appland/components and then an update to this PR
(or a follow-on PR). I don't really think that's worth doing, but what do
you think?
—
Reply to this email directly, view it on GitHub
https://github.com/getappmap/vscode-appland/pull/779#issuecomment-1701480079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVC6YRYOPMDJ23QNO6JXDXYDDXZANCNFSM6AAAAAA32MHXLM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Why does the pie have five slices?
…
On Thu, Aug 31, 2023 at 1:38 PM Adam Trotta @.> wrote: [image: image] https://user-images.githubusercontent.com/8737782/264726677-5fb63c33-c67f-46ad-89a5-0a07924c1b0c.png The issue where the Next step button appears despite a full completion state seems to have crept back in. Can you take a look at this? Otherwise as far as I can see this is good to go after a rebase. This was how the instructions were working previously. If I run the extension on master I see this on the penultimate instruction page: [image: image] https://user-images.githubusercontent.com/45714532/264731068-85cb7628-b28b-4471-a830-a1212e3c38ee.png It's only on the last instruction page that the button is disabled: [image: image] https://user-images.githubusercontent.com/45714532/264730979-04d1e41e-530a-4c10-9f45-375ec93fb657.png I could change how this works, but it would require another PR in appmap-js, a release of @appland/components and then an update to this PR (or a follow-on PR). I don't really think that's worth doing, but what do you think? — Reply to this email directly, view it on GitHub <#779 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC6YRYOPMDJ23QNO6JXDXYDDXZANCNFSM6AAAAAA32MHXLM . You are receiving this because you are subscribed to this thread.Message ID: @.>

That was from master, not this branch

:tada: This PR is included in version 0.100.0 :tada:
The release is available on:

v0.100.0
GitHub release

Your semantic-release bot :package::rocket:


.git suffix should be ignored on GH links

Links like https://github.com/Microsoft/python-language-server.git   reported as (404 Not Found: Not Found)  while https://github.com/Microsoft/python-language-server is totally fine and GH actually redirects .git links there.
It meters for the cases when  lychee detects links in config files and code samples that use such links to install dependencies (for example ruby gems, python stuff).

lychee follows redirects (up to a configurable number), so that's strange.

@mre  her's log
The  line says:
2021-11-05T06:12:24.9985312Z Errors in layers/+lang/python/README.html
2021-11-05T06:12:24.9986519Z ✗ https://github.com/Microsoft/python-language-server.git (404 Not Found: Not Found)

Looks like it detects this link
git clone https://github.com/Microsoft/python-language-server.git
cd python-language-server/src/LanguageServer/Impl
dotnet build -c Release
dotnet publish -c Release -r <RUNTIME>

Yeah that's a bug. It should have detected that as a 200. I wonder what's up...

@mre
I requested the link from chrome:
Request URL: https://github.com/Microsoft/python-language-server.git
Request Method: GET
Status Code: 301  (301 Moved Permanently)

Yeah nothing special about it :thinking:

Seems to work on my machine with lychee. 🤔
❯❯❯ echo https://github.com/Microsoft/python-language-server | lychee --verbose -
✔ https://github.com/Microsoft/python-language-server [200 OK]

🔍 1 Total ✅ 1 OK 🚫 0 Errors

❯❯❯ echo https://github.com/Microsoft/python-language-server.git | lychee --verbose -
✔ https://github.com/Microsoft/python-language-server.git [200 OK]

🔍 1 Total ✅ 1 OK 🚫 0 Errors

@JAremko can you test again?

@mre
https://github.com/Microsoft/python-language-server.git: Failed: 404 Not Found: Not Found
https://github.com/syl20bnr/develop.spacemacs.org/issues/162

It gets weirder then. That would mean that the action is doing something else than lychee. Checked the action params, but don't see anything special. Still don't know how this can be. Maybe it has something to do with the fact that it runs on Github's servers, but I doubt it.

@mre  Well, us I understand it uses GH token to access URLs like https://github.com/Microsoft/python-language-server.git  Maybe the process getting messed up by the redirect or GH doesn't support this type of access on .git URLs :thinking:

Hum. I tested with a Github token to no avail. 😕

i'm experiencing the same issue - for the moment i added all .git links to my exclude list

I'm also seeing the same. One additional note that in my case it is a .git link to a private repo.

Taking a look at https://github.com/syl20bnr/develop.spacemacs.org/issues/162 linked by @JAremko again I can see that lychee ran into Github's rate limiting, returning a lot of 429s. When this happens, we use the Github API as a fallback, but the API doesn't handle .git links, so it returns a 404. @jazanne, @lukehsiao, please check if you also check a lot of Github links and hence you're also affected by the rate limiting.

In my case, lychee is only checking about 10 URLs total, all of which return 200 OK except for the .git URL, which returns a 404.
I'll also note that I'm getting 200 OKs from other links in the private repo (e.g., to issues, to the README, to the changelog, etc.) It's just the .git in the documentation for how to clone the repo that it is 404-ing.

If you have some time, can you try with the version from https://github.com/lycheeverse/lychee/pull/453?
Locally, you can install the version from this PR with
cargo install --git https://github.com/lycheeverse/lychee --branch strip-git

In your case the bug is a different one: you don't run into Github's rate-limiting, but instead a private repo can't be checked without the API token (returns a 404 to not leak any information to the caller) and the API cannot handle .git URLs. So what I did was strip .git if it's the final part of the URL.

Got it. Looking at that patch, I highly suspect it would work.
Unfortunately, I'm actually seeing lychee crash with
thread 'tokio-runtime-worker' panicked at 'not currently running on a Tokio 0.2.x runtime.', /home/lukehsiao/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.25/src/runtime/handle.rs:118:28
when I provide a github token locally. This is likely a separate issue, though...

When running on your strip-git branch, rather than a tokio panic, I'm seeing "Network error while trying to connect to an endpoint via (reqwest or hubcaps)"

panicked at 'not currently running on a Tokio 0.2.x runtime.'

Ouch. That's bad. One of the dependencies needs still needs a 0.2 runtime and is not compatible with newer versions. Checked with cargo tree, but couldn't see anything suspicious. I'll update all dependencies in #454. Let's see if it helps. That's a separate issue, though as you rightly assessed. The other error "Network error while trying to connect to an endpoint via (reqwest or hubcaps)" is more in line with what you can expect without setting a Github token. That's a normal 404 and we have no way to know if the private repo exists without a valid access token.

Merged the dependency update to master and the strip-git branch on top of it.
If you wanna test again with that version, use
cargo install --git https://github.com/lycheeverse/lychee --branch strip-git
Hope that fixes the panic. 🤞  If not... 😕

Amazing! Two updates for you, then.

#454 fixes the panic for me (leaving just the single .git URL failing)

✔ https://github.com/private/repo/actions/workflows/ci.yml/badge.svg [200 OK]
✔ https://github.com/private/repo/actions [200 OK]
✔ https://github.com/private/repo/issues/ [200 OK]
✔ https://github.com/private/repo/compare/v0.0.1-alpha.0...v0.0.1 [200 OK]
✔ https://github.com/private/repo/releases/tag/v0.0.1-alpha.0 [200 OK]
✔ https://github.com/private/repo/compare/v0.0.1...v0.1.0 [200 OK]
✔ https://github.com/private/repo/issues [200 OK]
✗ https://github.com/private/repo.git: Network error when trying to connect to an endpoint via hubcaps

The strip-git branch fixes the .git, but appears introduce some different errors:

✗ https://github.com/private/repo/issues: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/actions: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/actions/workflows/ci.yml/badge.svg: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/compare/v0.0.1-alpha.0...v0.0.1: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/issues/: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/releases/tag/v0.0.1-alpha.0: Network error while trying to connect to an endpoint via reqwest
✗ https://github.com/private/repo/compare/v0.0.1...v0.1.0: Network error while trying to connect to an endpoint via reqwest
✔ https://github.com/private/repo.git [200 OK]

Thanks for the quick turnaround! 🙏
The issue with the failing links is a tricky one: AFAIK the Github API doesn't allow checking for repo endpoints like issues, releases, or actions. For public repos that's not an issue, because a simple request will check if it exists. In your case however it's a private repo, so a normal check returns a 404 and a check with the Github token won't work either because of the API limitations. What we did before was to assume these things would work if the private repo existed, but a user could disable issues or pull requests on a per-repo basis. Even then, I'd say the best way forward is to revert this stricter check and stay in line with the user expectation of returning a 200 -- even though we can't be 100% sure that's correct. But the alternative of returning a ton of errors for private repos is worse and most people won't change the repo settings.
Sounds good?

Ah, that's quite nuanced!

What we did before was to assume these things would work if the private repo existed, but a user could disable issues or pull requests on a per-repo basis. Even then, I'd say the best way forward is to revert this stricter check and stay in line with the user expectation of returning a 200 -- even though we can't be 100% sure that's correct. But the alternative of returning a ton of errors for private repos is worse and most people won't change the repo settings.

Frankly, I think you're the boss here and either option sounds reasonable to me :). If I'm weighing in, I'd probably think that the revert you suggest is a more friendly default, even if it might be inaccurate. But I think as long as there is some docs, users could adjust either way.

Pushed an update to the strip-git branch. It should work as discussed now. Can you try again?

Absolutely. There were two warning when compiling:
warning: associated function is never used: `new`
  --> lychee-lib/src/types/uri.rs:41:8
   |
41 |     fn new<T: Into<String>>(owner: T, repo: T) -> Self {
   |        ^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: associated function is never used: `with_endpoint`
  --> lychee-lib/src/types/uri.rs:49:8
   |
49 |     fn with_endpoint<T: Into<String>>(owner: T, repo: T, endpoint: T) -> Self {
   |        ^^^^^^^^^^^^^

warning: `lychee-lib` (lib) generated 2 warnings

But, it does behave as you described and seems great to me!
✔ https://github.com/private/repo/actions/workflows/ci.yml/badge.svg [200 OK]
✔ https://github.com/private/repo/issues [200 OK]
✔ https://github.com/private/repo/actions [200 OK]
✔ https://github.com/private/repo/issues/ [200 OK]
✔ https://github.com/private/repo/releases/tag/v0.0.1-alpha.0 [200 OK]
✔ https://github.com/private/repo/compare/v0.1.0...v0.1.1 [200 OK]
✔ https://github.com/private/repo/compare/v0.0.1-alpha.0...v0.0.1 [200 OK]
✔ https://github.com/private/repo/compare/v0.0.1...v0.1.0 [200 OK]
✔ https://github.com/private/repo.git [200 OK]

@mre
Another approach is to actively look up for README file according to https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
This helps to avoid quite a few unnecessary links on GitHub itself. (E.g. links to homepage, various tabs of repo, etc.)
The downside may include:

We need to handle relative path. (Not really an issue)
We may miss URLs in repo's description since it's not in README but appear on the repo page

Not sure I understand. Not every repo has a README and the file name could vary (README.md, README.txt, README, lowercase?). How would we determine if it's an actual 404 if we don't find the right file? Would we try them all or do another API call to find the right one?

why does lychee not attempt to initiate a clone over https (and abort it)? I'm sure just for determining 404s you can emulate a part of the protocol with a regular http client, and afaik github-token can be used for private repo cloning (just different kind of header probably)

All great ideas! But let's not forget that lychee is a link checker and that Github already has a more prominent spot than   other sites. As always, we have to find a trade-off between performance, maintainability and correctness. At the end of the day we also need to divide our limited free time among all issues. 😉
So I propose to merge #453 with what we discussed so far, which should fix this issue and https://github.com/lycheeverse/lychee/issues/449. Always open for PRs though.

I agree that lychee should not initiate a clone, and prioritize simplicity and performance. Thanks for this fix!

Not sure I understand. Not every repo has a README and the file name could vary (README.md, README.txt, README, lowercase?). How would we determine if it's an actual 404 if we don't find the right file? Would we try them all or do another API call to find the right one?

Let's try to find README file by emulating the way how GitHub finds it if it exists.

If it does exist, the readme file contains the links users actually want to check with lychee. Note that when you open a GitHub repository page, it contains the README and other GitHub UI elements, where the UI elements are not really relevant.
If it doesn't, then the GitHub repo page contains only GitHub UI elements and there's not need to check.

@lebensterben I don't think this issue has anything to do with READMEs, as lychee is just a generic link checker, not a README link checker.

@lukehsiao I understand what you mean. But consider this:
Users may want to ask lychee to (recursively) check all links in a repo by providing a git repo's URL. In many cases README is where most links are, since it acts as a summary or index page for a repo. Depending on the type of repo, you may even not having any URLs elsewhere. (which is what I experienced most)

This should be fixed in master now. 🎉 Recursion isn't supported yet, so I'd postpone the discussion about fetching the README. Quite honestly, I think it goes a bit too far for a general link checker, but we can revisit this in the future. Thanks everyone for your input. Feel free to open a new issue in case you see any odd behavior.


Options to pass in?

Are there any options to remove the audit reports for things like PWA and SEO if we would like to not include those in the report?
Also how do you tell it what device to use (desktop or mobile)?
Thanks for your help and super helpful plugin!

Hi @brentrobbins by default it runs everything by default. But everything you pass on --lighthouse.* will be passed on to lighthouse as options, so it should be possible to configure it how you want it. But let me know how it works, I haven't tried it myself :)

Are there any options to remove the audit reports for things like PWA and SEO if we would like to not include those in the report?

You mean in the HTML, or data sent to Graphite/InfluxDB? No way in the HTML, the others are configurable.
Best
Peter

Hi @soulgalore
I've passed desktop parameter with following flag --lighthouse.emulated-form-factor desktop \ into sitespeed but in lighthouse log I still see that lighthouse emulates mobile device.
More details you can find in attached log.
sitespeed.log
Looking forward to you answer,
Best Regards,
Maksim

I’m on vacation this week and can have a look later this week, if you have time check if you can debug it yourself. Is there something wrong with how we pass on the config?
Best
Peter

Yeah this seems broken, we don't even pass them on the right way. If someone could help out with this it would be great.

I've made a PR that should fix the issue. We were passing the Lighthouse config into the wrong parameter of the API. See https://github.com/sitespeedio/plugin-lighthouse/pull/10 for details.
It should be possiblee to set the device type using the following if/once merged:
--lighthouse.extends lighthouse:default --lighthouse.settings.emulatedFormFactor desktop

Fixed by @gidztech , I'll release the container tonight.


Terminal scroll lag

Type: Bug
When scrolling the integrated terminal with the mouse wheel, the view changes only after a considerable time lag or delay. This doesn't happen all the time, but sometimes when the terminal panel contains some 200 lines. It takes longer as the terminal panel height increases. Must be around 0.3 s with the default small height and up to 0.6 s at full screen height (1200 px). The terminal cannot be scrolled interactively, it's always a wait after each wheel turn.
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.71GB (4.99GB free)

Process Argv
C:\Source\Komprenu\Kappa-Indect\core-daemon-cs --crash-reporter-id 1b00a758-578c-4b77-a258-fe145c18e004

Screen Reader
no

VM
33%

Extensions (24)

Extension
Author (truncated)
Version

vscode-solution-explorer
fer
0.7.5

vscode-todo-highlight
jgc
2.0.4

ecdc
mit
1.8.0

vscode-language-pack-de
MS-
1.74.12140926

csharp
ms-
1.25.2

vscode-dotnet-runtime
ms-
1.6.0

isort
ms-
2022.8.0

python
ms-
2022.20.1

vscode-pylance
ms-
2023.1.10

jupyter
ms-
2022.11.1003412109

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.12

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

remote-ssh
ms-
0.94.0

remote-ssh-edit
ms-
0.84.0

cpptools
ms-
1.13.9

remote-explorer
ms-
0.0.3

vscode-nuget-gallery
pat
0.0.24

platformio-ide
pla
2.5.5

better-pageup-pagedown
rus
0.0.1

jinjahtml
sam
0.19.0

trailing-spaces
sha
0.4.1

cursorCharCode
zei
0.2.2

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1cf:30587006
2e4cg342:30602488
3d0df643:30613357
89544117:30613380
fim-prod:30623723

I've just seen my settings and would like to add these in case they're relevant:
    "terminal.integrated.cursorBlinking": true,
    "terminal.integrated.gpuAcceleration": "off",

I don't know anymore why I've set the second one. There was probably some other bug that could be resolved with it in the past.

"terminal.integrated.gpuAcceleration": "off",

GpuAcceleration helps with rendering performance, so it's possible that removing that line could fix this for you

Also chiming in here to say that I'm seeing this when I open the terminal in a RDP session and then move back to the console session.
If I turn off GPU acceleration (including if I toggle it off and on) then this stops happening.
I also noticed that the scrollbar itself updates with no delay, but it takes 200-300ms for the text in the terminal to update.

Rendering improved greatly a few months ago when GPU acceleration if off. If you still see a problem you can capture a devtools performance trace (Help > Toggle Developer Tools) which will give us some info about it


Test workflow

Trigger builds on PR opening and when merged to master.
Handled by two separate jobs

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

rerun

Can one of the admins verify this patch?

add to whitelist

rerun

rerun

ok to test

rerun


HIP support with CMake

We can probably "steal" the FindHIP.cmake from OCCA: https://github.com/libocca/occa/blob/master/cmake/FindHIP.cmake contributed by @noelchalmers.

@dmed256, @camierjs, @YohannDudouit or @adrienbernede -- do you want to take on this?

Or use BLT: https://github.com/LLNL/blt/blob/develop/cmake/thirdparty/FindHIP.cmake

The BLT one is just taken from https://github.com/ROCm-Developer-Tools/HIP/blob/develop/cmake/FindHIP.cmake . Although, the BLT one isn't quite up to date with the one in the HIP repository now as of ROCM v3.8.0.

Should we just borrow the ones from the official HIP repo then?

Addressed by https://github.com/mfem/mfem/pull/1906


Clarify behavior of InputEvent.is_match and Shortcut.matches_event

Shortcut: Clarifies how matches_event() method compares events
InputEvent: Clarifies is_match() method does not consider event states

Fixes #97048

You need to push using git push --force or it will make a merge commit
Also please update the commit title by git commit --amend to match the PR title, and remove the unnecessary content in the commit, it should look like:
Clarify behavior of InputEvent.is_match and Shortcut.matches_event
- Shortcut: Clarifies how matches_event() method compares events
- InputEvent: Clarifies is_match() method does not consider event states

Thank you

Thanks! And congrats for your first merged Godot contribution :tada:

Thank you!


support word sets

Is this change related to a problem? Please describe.
There is currently no way in DaFoDiL to represent a set of words that are related across languages. Specifically, there is no way to capture the notion of cognate sets or borrowings.
Describe the solution you'd like
DaFoDiL should include a Word Set schema, with a property something like wordsetType with the possible values of cognate and borrowing, among possible others. It should also have an items property (other names might work too) which is an array of database reference objects (which allows them to be entire lexemes).

Do we want this to have wordsetType options for families of languages? For example: nouns across germanic languages that appear to have similar phonetic components. If so, what should this Type be called? @dwhieb

@vadekh Possibly! I'm not totally sure what you mean though. Can you elaborate a little more? How would this type be different from cognate sets? Is the idea that users should be able to more-or-less randomly select items from different languages into a set?
If so, I can definitely see lots of potential research use cases for this. For example, someone might be looking at all the words in a Swadesh list across various unrelated languages.
I don't have any good ideas on what to name this type of word set though! @monicamacauly, @hunterlockwood, @Calvin1119, any ideas?

otherwordset?

otherwordset would work, paired with a note or description.

@vadekh Ok so that sounds like a potential cognate set, which is definitely a useful thing to have.
I don't think we should add a value for potentialCognates or anything like that though. That seems too specific. I think that unless there's a really common and well-established use case (like cognate and borrowing), we shouldn't add any more values to this list.
That said, I think a catch-all category just called other would be useful.
So the possible values for this field, for now, until another clear possible use case comes up, are:

borrowing
cognate
other

You may want to look at how CLDF handles
cognates
in
Wordlists.

Or you may want to look at how FLEx creates word relationships and the taxonomies they use. https://software.sil.org/fieldworks/

 [format] add Word Set schema

 [spec] WordSet release


console.exe cannot handle non-ascii characters in command line argument

console.exe aborts due to assertion failure when I put non-ASCII characters in command line argument.
As far as I can see, it is because mbstowcs() returns -1 since mbstowcs() is locale dependent by spec and requires proper setting of LC_CTYPE via a call to setlocale() for conversion of non-ASCII characters.
In my environment (Cygwin64), the following addition to main() is enough:
setlocale(LC_CTYPE, "");

As far as I can recall, locale related implementation was poor on Cygwin 1.5 era, so I don't know if it also works for old Cygwin or msys1 as expected.

Fixed by https://github.com/rprichard/winpty/commit/ec385e8d1b25d1e3a20e04947b5d0d1d4c587170.


micro ros comunication problem

hello,
i am having a comunication problem .
i am running a launch file of 3 micro_ros_agents for 3 usb ports that i have : 2 micro_controllers publishing and 1 subscribing.

when running the launch file than connecting all the devices at once(via a usb-splitting device) i get the following error for 2 out of the 3 ports :
open device error      | device: /dev/ttyACM0, errno: 13. Please re-run with superuser

even though my user has permission to the usb ports

when running the launch file than connecting each device once at a time to my ports i have no problem.

for my project i need to connect all my devices at one time and i have no idea why this is happening.
would appreciate any help , thanks in advance

Does your setup works if you run ros2 micro_ros_agent micro_ros_agent serial [your serial device] -v6?

Which is the error running the command directly?

Which is the ouput when you run this command ros2 micro_ros_agent micro_ros_agent serial [your serial device] -v6 ?

What about sudo ros2 micro_ros_agent micro_ros_agent serial [your serial device] -v6?

i am getting the following error
sudo ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyAMC0
sudo: ros2: command not found

I guess that you have permission issues with your serial ports. Maybe you can find how to ensure that your user has permission to read and write the serial port.

the thing is is i plug the devices one by one i have no user permission issues

hey I tried it and it worked , what is the reason it works this way and the other way not?

Issue with your device's permissions? I really don't know.
Closing as solved.


Es ar translation typos

Just a few minor grammar typos in the es_AR translation

Great! Thanks a ton. I’ll try to push the site with these changes soon


logging for non-python based submissions

For non-python based submissions, I suggest we allow logging in the language of the framework and let the submitter provide a log conversion script to post-process the logs into the MLPerf formatting.

SWG:
The final log text is what's important. You can use your language of choice to produce the log. The primary expectation is that the output is the same format and there are some print or logging in the code itself (for the purposes of navigation).


fix(IE): getRandomBytes fails when size=0 on IE.

Fun IE stuff.
On IE11 if you run: msCrypto.getRandomValues(new Uint8Array(0)) , it launches an exception:
InvalidStateError
If you do the same on chrome it returns an empty list as it should be.
So, I think not calling getRandomValues when the size is zero solves the problem.

Please put a whitespace after the if (in accordance with standard - you can run npm test to verify).

LGTM

ping @calvinmetcalf for review + release

looks general good, I can review, browser test, and release latter this weekend/monday

are you planning to do a release with that fix? Thanks!

I pushed up a test and if that looks good I'll publish it

and it does publishing as 2.0.3


Statusbar should be white when viewing images

I have a black text statusbar, which doesn't look good when an image is viewed with Agrume. Disabling or setting the color would solve this problem.

There's the public var statusBarStyle: UIStatusBarStyle? property on an Agrume instance which was added recently. It's not document yet though but should cover what you need?

Puurrrfect.


Fixed bug for ql:contains-word queries and extended e2e tests

Great, thanks! This query works now with this PR: https://qlever.cs.uni-freiburg.de/dblp/eYUyfn


Use Gulp to deploy to GitHub Pages

gulp-gh-pages is a handy plugin for using Gulp to deploy your site to GitHub Pages.

Oh that's awesome, will take a look!


Using wildcards in regex

I'm trying to use wildcards to match certain patterns.
How do you specify for example 3 consecutive digits?
e.g. I want to group a123bbbb, a548pdks and a487jshdkd
With normal regex would give something like user.displayName -Match "\Aa\d{3}.*" however this does not seem to work

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f7a4070-1be8-5f1f-0092-68fb6b9e2305
Version Independent ID: cd34312f-b507-affe-555e-1e0c63e7d494
Content: Rules for dynamic group membership - Azure AD
Content Source: articles/active-directory/users-groups-roles/groups-dynamic-membership.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

correction. must have made a type somewhere because it just started working

@yvesjac Thanks for the question. We are investigating the issue and will update you shortly.

@yvesjac Glad to know that it is working for you now. We will be closing this thread. Let us know if you need further help.


Revert "Merge from upstream"

Reverts populationgenomics/gnomad-browser#3
Undoing an accidental squash merge.

Nevermind, the previous merge was fine.


used Java 1.8 constants for better readability

Coverage remained the same at 98.654% when pulling 028ea114ddcf14b1fb0f04481f566463444a17e6 on constants into a8ae1bdd402b6c25d4417512b1d024fa28fbe025 on master.


Compatibility with surface v0.5.x

On this PR I updated deps on mix.exs to point to:
  {:surface_catalogue, "~> 0.1.0", only: :dev},
  {:surface_formatter, "~> 0.5.0", only: :dev},
  {:surface, ">= 0.5.0"}

and followed the migration guide
All tests pass and the catalogue is working.

Hey @olivermt, lemme know if anything else is needed here.

I need to understand why I don't get notuifications when people open PRs, this looks great and I appreciate the work!
Merging and looking at a release now.


AOO cells not reset after point moved

Minor, but when a point is moved, cells are recalculated and added, but it seems the old cells remain. Clicking analysis on an off sorts this.

solved in #74


Add GrabPay support

Summary & motivation
Add typing support for GrabPay flows.
Testing & documentation
Added automated tests for the new types.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@christopher-stripe: I've addressed the issues that you've pointed out.
I've also rearranged my changes to keep them sorted alphabetically between other payment methods.
Appreciate another review!

@christopher-stripe: I've addressed the issues that you've pointed out.
I've also rearranged my changes to keep them sorted alphabetically between other payment methods.
Appreciate another review!

@christopher-stripe: I've addressed your comments.

@christopher-stripe: I've addressed your comments.


Support component instance types

Clear and concise description of the problem
The method exposed by the component, refer to the component in the template, you need to manually import the component in the script, add a type.
const myFormRef = ref<InstanceType<typeof MyForm>>()

<template>
  <MyForm ref="myFormRef"/>
</template>

Suggested solution
Add a switch to option, automatically declare the instance type of a component in components.d.ts

// components.d.ts
export interface GlobalComponents {
  MyForm: typeof import('./components/MyForm.vue')['default']
  MyFormInstance: InstanceType<GlobalComponents['MyForm']>
}

Maybe there's a more elegant way.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[x] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

this solution cannot support with component with setup genric


'RpmBuilder' object has no attribute 'license'

Hi.
While playing around with version 0.2.0 I got the following exception:
Traceback (most recent call last):
  File "/opt/app-root/bin/distro2sbom", line 8, in <module>
    sys.exit(main())
  File "/opt/app-root/lib64/python3.8/site-packages/distro2sbom/cli.py", line 209, in main
    sbom_build.process_distro_package(args["package"])
  File "/opt/app-root/lib64/python3.8/site-packages/distro2sbom/distrobuilder/rpmbuilder.py", line 206, in process_distro_package
    if self.process_package(module_name):
  File "/opt/app-root/lib64/python3.8/site-packages/distro2sbom/distrobuilder/rpmbuilder.py", line 149, in process_package
    license = self.license.find_license(self.get("License"))
AttributeError: 'RpmBuilder' object has no attribute 'license'

The command used to generate this exception:
distro2sbom --distro rpm --name centos --release 7 --sbom cyclonedx -o sbom.json --format json -p bash
The enviroment is a Docker container (quay.io/centos7/python-38-centos7)
I don't get the exception if I instead use -i packages.txt. However in this case there is no license information in the resulting file (even when switching the SBOM format to spdx). Which I think might be another issue.
My assumption is, that distrobuilder.py contains changes (the license attribute, along with the associated methods to find licenses), which weren't included in the commits related to version 0.2.0.

@danielperna84 Can you try version 0.2.1 (pip install distro2sbom --upgrade)?

Yes, now it's working with -p bash. Thanks. 👍


Does not work with python 3.6

Hi,
When I try to install the package (using conda install -c pyomeca pyosim) in a conda environment with python 3.6 I get the following error:
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: -
Found conflicts! Looking for incompatible packages.                                                                                failed

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - pyosim -> python[version='>=3.7,<3.8.0a0']

Your python: python=3.6

If python is on the left-most side of the chain, that's the version you've asked for.
When python appears to the right, that indicates that the thing on the left is somehow
not available for the python version you are constrained to. Note that conda will not
change your python version to a different minor version unless you explicitly specify
that.

The following specifications were found to be incompatible with each other:

Package libgcc-ng conflicts for:
python=3.6 -> libgcc-ng[version='>=7.2.0|>=7.3.0']
Package readline conflicts for:
python=3.6 -> readline[version='7.*|>=7.0,<8.0a0']
Package pyomeca conflicts for:
pyosim -> pyomeca
Package libffi conflicts for:
python=3.6 -> libffi[version='3.2.*|>=3.2.1,<4.0a0']
Package tk conflicts for:
python=3.6 -> tk[version='8.6.*|>=8.6.7,<8.7.0a0|>=8.6.8,<8.7.0a0']
Package xz conflicts for:
python=3.6 -> xz[version='>=5.2.3,<6.0a0|>=5.2.4,<6.0a0']
Package pip conflicts for:
python=3.6 -> pip
Package matplotlib conflicts for:
pyosim -> matplotlib
Package opensim conflicts for:
pyosim -> opensim
Package ncurses conflicts for:
python=3.6 -> ncurses[version='6.0.*|>=6.0,<7.0a0|>=6.1,<7.0a0']
Package zlib conflicts for:
python=3.6 -> zlib[version='>=1.2.11,<1.3.0a0']
Package pandas conflicts for:
pyosim -> pandas
Package openssl conflicts for:
python=3.6 -> openssl[version='1.0.*|1.0.*,>=1.0.2l,<1.0.3a|>=1.0.2m,<1.0.3a|>=1.0.2n,<1.0.3a|>=1.0.2o,<1.0.3a|>=1.0.2p,<1.0.3a|>=1.1.1a,<1.1.2a|>=1.1.1c,<1.1.2a']
Package sqlite conflicts for:
python=3.6 -> sqlite[version='>=3.20.1,<4.0a0|>=3.22.0,<4.0a0|>=3.23.1,<4.0a0|>=3.24.0,<4.0a0|>=3.25.2,<4.0a0|>=3.26.0,<4.0a0|>=3.29.0,<4.0a0']
Package libstdcxx-ng conflicts for:
python=3.6 -> libstdcxx-ng[version='>=7.2.0|>=7.3.0']
Package numpy conflicts for:
pyosim -> numpy

Hi,
Unfortunately, OpenSim is still not available on conda-forge and I have to build it myself for pyosim to work.
It's been a while since I've built opensim on my channel and the version should no longer be up to date.
I will fix the problem in the next few weeks and keep you informed when Pyosim works again.

Thank you.
On Tue, Nov 19, 2019, 1:35 PM Romain Martinez<EMAIL_ADDRESS>wrote:

Hi,
Unfortunately, OpenSim is still not available on conda-forge
https://github.com/conda-forge/staged-recipes/pull/4693 and I have to
build it myself for pyosim to work.
It's been a while since I've built opensim on my channel
https://anaconda.org/pyomeca/opensim and the version should no longer
be up to date.
I will fix the problem in the next few weeks and keep you informed when
Pyosim works again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pyomeca/pyosim/issues/29?email_source=notifications&email_token=AGNSHUMSBGD45U3EJG242VDQURLR3A5CNFSM4JPJOMX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEP3FMI#issuecomment-555725489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGNSHUNDNVSGIF4VWAD7HR3QURLR3ANCNFSM4JPJOMXQ
.

Hi guys,
I do have the same error message than BehnooshParsa, from 3.4 to 3.7 version.
Did you manage to fix the problem to make Pyosim working ? :)
Thanks for letting me (us) know !
Regards

Hi,
Would you please tell me what the latest supported python version is? Does it support py 3.8?
Your help is much appreciated.
Cheers

Unfortunately, OpenSim is still not available on conda-forge (see here) and I have to build it myself for pyosim to work.
I don't have time to build OpenSim for all platforms (windows, linux and mac) and all versions of Python (3.6, 3.7, 3.8, 3.9).
So as long as OpenSim is not available on conda-forge, I won't update pyosim.
Depending what you want to do, the easiest way to make things work could be to just use conda and my builds available with python 3.6 here.


[OpenSSH] X-tunnel failure

Hi folks,
When trying to tunnel an X session with ssh -X, I'm getting the following error:
quintus@local $ /usr/local/Cellar/openssh/6.6p1_1/bin/ssh -X csci
Warning: No xauth data; using fake authentication data for X11 forwarding.
quintus@remote $ firefox
...
(omitted X's common SNAFU errors which aren't related to the problem)
...
/private/tmp/com.apple.launchd.jzXodjXq2O/org.macosforge.xquartz: unknown host. (nodename nor servname provided, or not known)
/private/tmp/com.apple.launchd.jzXodjXq2O/org.macosforge.xquartz: unknown host. (nodename nor servname provided, or not known)
/private/tmp/com.apple.launchd.jzXodjXq2O/org.macosforge.xquartz: unknown host. (nodename nor servname provided, or not known)
Error: cannot open display: localhost:10.0

This looks suspiciously similar (if not identical to) an old bug report filed in XQuartz a few months back, when the Yosemite preview first rolled out.
When I brew unlink openssh, it works just fine! Maybe that's the "fix" that the linked bug-report commenter refers to.

I fixed it in MacPorts' openssh port in [https://trac.macports.org/browser/trunk/dports/net/openssh/files/launchd.patch?rev=121205] and the fix for OS X's OpenSSH should be in the latest beta.

I'm running stable Yosemite, and these errors never appeared before I made the switch.
Cheers

@qguv Very appreciate your comments and work !!!
I am new to MacOS.   I have encounter a problem which I think you might be able to help.
Basically I want to ssh to Mac OS Yosemite from Linux box and run applications in the ssh window.
However I encounter a very weird problem,

I could ssh to Mac OS from linux box and run xeyes, then xeyes pop up on my linux screen, which is great.
but when I run a few other serious applications, the windows always pop up at Mac OS screen instead of linux box.
I have made sure in /etc/sshd_config
X11Forwarding yes
X11DisplayOffset 10
X11UseLocalhost yes
and
XXXXX@MacbookPro:~$ echo $DISPLAY
localhost:10.0
Actually xeyes shows up at ssh client screen as expected.   But not for any other serious applications I tried.

First I want to figure out which laptop has issues.  Linux box could ssh to other Linux box or receive ssh request from other linux box (even the mac laptop) without any issue (I mean the application window pops up in the ssh client side instead of ssh server side).  So the problem is not with my linux box.
I did some googling and found your page is probably the most likely anwer to my issue.  So I follow your suggestions to install brew, upgrade openssh.   However I still have issues.
Here is my questions

is your suggested update supposed to fix my problem?
I try to replace /usr/bin/ssh-agent with /usr/local/bin/ssh-agent (the updated version) then go to mac os preferences->sharing to uncheck/check "Remote Login", but I don't find any evidence that the updated sshd is picked up or not.   did I do it in the right way?

Very appreciate if you could give any suggestions, thank you very much in advance !!!

Hi there @strangeice!

Is your suggested update supposed to fix my problem?

The short answer is no. To answer this better, I need to explain the background of GUI rendering on OS X and Linux.
(Most) Linux systems today use Xorg a.k.a. X as their display server and window manager. Because X tunneling is built into OpenSSH, servers running X can display windows over SSH to a client also running X. This is great if you and some other computer are both running some flavor or derivative of Linux.
While OS X is like Linux in some respects, it's very different in others. It uses its own BSD-derived toolchain rather than GNU's coreutils that most Linux systems (you'll hear GNU/Linux) use.

The big issue is that OS X doesn't use Xorg. It uses Apple's own Quartz. Sometimes Mac users or even Apple themselves (in the case of OpenSSH) decide they want to use some Linux software. This isn't nearly as difficult to deal with as on a Windows machine, as there's some common history between the platforms. So there's XQuartz, which you'll hear some people also call X11, which allows Mac users to run some Linux software (Inkscape, Gimp, etc.) that uses X to display windows. This means OS X can be a client to an X tunnel but not a server for native OS X applications. Since OS X uses Quartz and not Xorg, you're not going to get native OS X software to display over an X tunnel. Xeyes works over the X tunnel because it's a port of Xeyes for Linux and runs within XQuartz on OS X. If you run it on OS X, you'll see that the top menu for the application displays "X11" or "XQuartz".

I try to replace /usr/bin/ssh-agent with /usr/local/bin/ssh-agent (the updated version) then go to mac os preferences->sharing to uncheck/check "Remote Login", but I don't find any evidence that the updated sshd is picked up or not. did I do it in the right way?

I would recommend against moving the binaries around like that. OS X doesn't like when you move its guts around. Unlike, say, a Linux system, you're probably going to break the things that depend on the out-of-the-box functionality of the original binaries. Since OS X doesn't use the GNU toolchain (if you run man tar, for example, you'll see that this is the BSD version of tar, not the GNU version you'd find on your Linux system), you're better off using Homebrew to take care of linking everything together for you so that you can still use your familiar GNU toolchain (and coreutils if you want) in the command line without breaking critical functionality for your regular machine.
VNC for Remote GUI Control
You can set up a VNC server in OS X to let you control your computer as if you were physically there. Rather than displaying individual windows over a network connection, you'd be displaying your whole screen. You can think of VNC as "screen mirroring" when you plug in a second display. This comes with OS X and can be set up through System Preferences under Sharing as the "Screen Sharing" service.
Cheers!

Sorry to comment on an old post, but it seems like I'm running into the same problem again. When I do
brew update
brew upgrade

And upgrade openssh to the latest version (built in March 2015 I believe), ssh -X once again does not allow me to do X11 forwarding (error is "unknown host"). One the other hand, the OS X built-in openssh does not have such issues (it works once I unlink the brew version of openssh). Any fixes for that?
Thanks!


Update targetable cards in 4th edition

From Chris:

Any effect that says self-execute/fully-execute can target any card, face up or face down, doesn't matter from what set. If you target a city or a figure, nothing happens. With a Dogma Action or an Endorse Action, you cannot target a City or a Figure. Yamato counts as part of this "untargetable / no effect" group, as it has no icons

I believe this is likely fully implemented at this point.


chore: Improve performance of Parquet statistics conversion

Which issue does this PR close?

Closes #.
Rationale for this change

Refactor the code get_statistics! in statistics.rs to improve the performance of converting Parquet statistics to Arrow arrays. Instead of using conditional checks and try_from conversions, use the ok() method to handle the conversion and filtering of values. This change simplifies the code and improves readability.
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

cc @xinlifoobar and @marvinlanhenke

I think this is a nice code impeovement ❤

It is indeed. Thanks @Weijun-H really nice refactor.

I am not sure this will improve the performance

I'll guess in terms of performance it won't make any difference.
However, it is more readable and thats always great, so thanks again.

Thanks again everyone


Overlap of animation and photo in "Meet the Pod" section

In the "Meet the Pod" section, when the mouse hovers on one card, his/her name goes up too much that it overlaps with the photo.

And also, Priya's photo is rotated.

I will fix this

It's alright, I will fix this. Might be quicker. Also, where is photo rotated?

Oh, I already fixed it and is writing the pr. Thanks a lot!


Can't verify the access to the 'external AKS-hosted service' in 'Lab 09: Configuring and Securing ACR and AKS' #117

Hi,
Please DO NOT close this issue without a proper reply. It is linked to:
https://github.com/MicrosoftLearning/AZ500-AzureSecurityTechnologies/issues/117#issuecomment-814779214
All i got a reply was this:
polichtm commented 3 days ago
This has been addressed
rgds
Marcin
I don't have a clue where this was addressed and what is the solution to it. Please at least give a link so that i can check.

Pls refer to the commit #117 included in the response to the issue you raised - as per the screenshot below:

Let me know if any clarification is needed
rgds
Marcin

Hi Marcin,
Thanks.
I'll update here again if any issues,
Will test the lab again.
Regards,
Saim


Fix notification swap problem

I don't see any swapping with this change applied, but it may behave differently against different sets of events. Might be good to pull the change down and test it against your event list @peaton

ahem @eatonphil

Coverage increased (+0.01%) to 87.233% when pulling 55fa914d71615492b99f2768f70cf288cd21c80d on briansteffens:fix-notification-swap into 2ae9f949faa6111880104552271487824bdc4c60 on linode:master.

Looks good.


Fix HTTP breadcrumb instrumentation tests for Node 8

As part of CI, on top of raven-node's regular test suite, we also run the full Node.js core http test suite w/ our HTTP breadcrumb instrumentation to verify that we don't break anything (code here, thanks @LewisJEllis).
Welp, seems that with Node 8 we do fail 3 tests:
X test-http-outgoing-internal-headers.js - error!
X test-http-outgoing-renderHeaders.js - error!
X test-http-pipeline-flood.js - error!

I haven't investigated very deeply yet; opening this issue for now.

Note that we have some "known failures" that we've decided not to worry about here, pipeline-flood being one of them, so the concern here is moreso just with the first two you listed. I wouldn't be surprised if the two new ones here are similar cases, but you'd have to dig into what those tests actually do to be sure.
Also, these failures were only introduced in Node 8.2; they were passing on 8.1.

Fixed


5 add ability to create account

Added a ton of stuff.
Start to cookbook management.
Authentication/Authorization with JWTs.
Email verification backend.

Nice!


app: Avatar disappears on low avatar quality settings

right now, avatar disappears on low avatar quality settings and throws this error.

https://user-images.githubusercontent.com/35926530/164530962-8431b67a-def6-4e5f-9bdc-c1c809612df1.mp4

localRig.emotes was renamed.


Next and Prev buttons

not working , when remove current playing video from playlist.
Now  play first video.

👍


Question about documentation for Container.ReplaceItemAsync

Hi, can I ask for clarification about the Container.ReplaceItemAsync Method? The provided example shows:
await this.container.ReplaceItemAsync(test, test.id, new PartitionKey(test.status));
But I'm not sure if the test object is an existing item in cosmosdb or not? If it's an existing item, which makes more sense because the doc also mentioned the id should be a Cosmos item id of the existing item, could you please provide a better example? Currently the example shows the test object is a new object with a random Guid id.
I want to utilize this method in this way:
Let's say the test object is already existing. Now I want to replace it with a new object:
ToDoActivity test2 = new ToDoActivity()
{
id = Guid.NewGuid().ToString(),
status = "InProgress"
};
await this.container.ReplaceItemAsync(test2, test.id, new PartitionKey(test.status));
Can I use the existing test.id and the existing partitionKey to locate the original test object, and replace it with the new test2 object, even if test2 has a new id?
I tested the above way in cosmosdb and succeeded. But wanted to confirm is it allowed to replace the id? Apparently id is not immutable here.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0286f791-878d-c285-c0d2-ebdfc02470be
Version Independent ID: c8f1d594-e500-eb4b-50b5-8ec04724c482
Content: Container.ReplaceItemAsync<T> Method (Microsoft.Azure.Cosmos) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Cosmos/Container.xml
Service: cosmos-db
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@yuxzha Yes. That is valid.
The main difference between upsert (update or insert) vs replace is that for replace to work, the item should already exist, hence requires the id property to be passed to the method.

Thanks @PramodValavala-MSFT! I would recommend making the provided example a little clearer:
Currently it's confusing because in
ToDoActivity test = new ToDoActivity()
{
id = Guid.NewGuid().ToString(),
status = "InProgress"
};
ItemResponse item = await this.container.ReplaceItemAsync(test, test.id, new PartitionKey(test.status));
The test.id is a NewGuid. But we are replacing item with that. Can we clarify the test.id is already existing? And maybe replace with another item?
ToDoActivity test2 = new ToDoActivity()
{
id = Guid.NewGuid().ToString(),
status = "InProgress"
};
await this.container.ReplaceItemAsync(test2, test.id, new PartitionKey(test.status));


Exception when trying to containerize and publish StatelessService in Service Fabric

I have a .NET Core Reliable Service that is pretty much a template service, obtained from the Add > New Service Fabric Service > .NET Core Stateless Service. This means that it contains the ServiceEventSource, a Stateless1 class that inherits from the StatelessService class, and a Program.cs. The contents of the Program.cs are the default ones:
private static void Main()
        {
            try
            {
                ServiceRuntime.RegisterServiceAsync("Stateless1Type",
                    context => new Stateless1(context)).GetAwaiter().GetResult();                ServiceEventSource.Current.ServiceTypeRegistered(Process.GetCurrentProcess().Id, typeof(Stateless1).Name);
                Thread.Sleep(Timeout.Infinite);
            }
            catch (Exception e)
            {                ServiceEventSource.Current.ServiceHostInitializationFailed(e.ToString());
                throw;
            }
        }

Now, this is working fine, I am able to start the Service Fabric application correctly and see logs, etc.
What I am trying to accomplish is to containerize this service, as per the following article: https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-services-inside-containers . This means that I added the SFBinaryLoader.cs and added the following file to my Program.cs:
static Program()
        {
            SFBinaryLoader.Initialize();
        }

However, by trying this a lot of questions and problems arise which aren't addressed by the documentation.
I am using the microsoft/service-fabric-reliableservices-windowsservercore:1803 as a base image to build my container. This, since the windows server host is version 1803. After running the CreateDockerPackage.ps1 I notice that the Microsoft.ServiceFabric.Data.Interfaces.dll and the System.Fabric.*.dll are being removed.
I think this is why we must be supplied again on runtime. This is performed by the SFBinaryLoader.cs by adding an event listener on the AppDomain.CurrentDomain.AssemblyResolve. This class should look at the FabricCodePath environment variable (which on runtime looks to be binding to the C:\SFFabricBin\ directory) and manually add those binaries.
I would say that in order for the program to run, I had to also remove the *.deps.json file from the container, because I was getting an exception before even running the dotnet Stateless1.dll stating that some missing binaries declared on the *.deps.json file were not found.
Now, it looks like my container is starting up fine by the fabric, and that assemblies are being correctly loaded. However, whenever trying to register the service to the fabric by the following line:
ServiceRuntime.RegisterServiceAsync("Stateless1Type",
                    context => new Stateless1(context)).GetAwaiter().GetResult();

This throws the following exception:

An exception occurred registering the service System.Fabric.FabricException: Service Type is already registered. ---> System.Runtime.InteropServices.COMException: Exception from HRESULT: 0x80071BD1
at System.Fabric.Interop.NativeRuntime.IFabricRuntime.EndRegisterStatelessServiceFactory(IFabricAsyncOperationContext context)
at System.Fabric.Interop.Utility.<>c__DisplayClass22_0.b__0(IFabricAsyncOperationContext context)
at System.Fabric.Interop.AsyncCallOutAdapter21.Finish(IFabricAsyncOperationContext context, Boolean expectedCompletedSynchronously)   --- End of inner exception stack trace ---   at Microsoft.ServiceFabric.Services.Runtime.ServiceRuntime.RegisterServiceAsync(String serviceTypeName, Func2 serviceFactory, TimeSpan timeout, CancellationToken cancellationToken)
at Eventellect.Fabric.TestDocker.Program.Main() in C:\MyLocalPath\StatelessService\Program.cs:line 33

Do you know why is this happening? I also find it very weird that somehow my published service fabric knows anything at all about my local path.
I have already surrounded the RegisterServiceAsync call inside a try...catch block, but then, even though the thread goes to sleep succesfully and my docker container does not stop, actions inside my Stateless1.cs class are never performed. This means that not even the constructor is invoked.
Is there something I might be missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7acd6be9-dfb2-9569-ff34-cad061c47cb4
Version Independent ID: 6e0fcc47-fd74-45b2-f8be-d61fb270f186
Content: Containerize your Azure Service Fabric services on Windows - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-services-inside-containers.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: anmola

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks, awaiting then for your response.

Hello @Karishma-Tiwari-MSFT any news on this?

@masnider Would you be able to share your insights into the customer's issue? Thanks :)

I had the same issue but I achieved to containerize a stateless service in this way:

microsoft/service-fabric-reliableservices-windowsservercore:1803 docker image has .Net Core runtime 2.0 installed. If your stateless service is running on later versions it won't work. For this reason, I built my docker image in this way docker image servicefabric-runtime.
I realized SFBinaryLoader.cs class is not necessary for running Service Fabric Reliable Services or Reliable Actors inside containers. I didn't add it to my code.
I didn't execute CreateDockerPackage.ps1 for build the container, I only modified ServiceManifest.xml for changing EntryPoint section as follow:

  <EntryPoint>
      <ContainerHost>
         <ImageName>statelesscontainer:0.1</ImageName>
      </ContainerHost>
  </EntryPoint>

I changed my build project output path to pub/ and manually I added in the root of stateless service the Dockerfile based on step 1 as follow:

    FROM edalx/servicefabric-runtime:dotnetcore-3.1.2
    WORKDIR /app
    ADD pub .
    CMD ["ApiService.exe"]

Besides in ApplicationManifest.xml you need to add PortBinding tag.

  <ContainerHostPolicies CodePackageRef="Code" Isolation="process" ContainersRetentionCount="2">
      <HealthConfig />
      <PortBinding ContainerPort="0" EndpointRef="ServiceEndpoint" />
      <ImageOverrides>
         <Image Name="edalx.azurecr.io/statelesscontainer:0.1" />
      </ImageOverrides>
  </ContainerHostPolicies>

I'm using Visual Studio Community 2019 and for deploying, it detects automatically it is a container and show the wizard like a non-containerized service and it will do all the work.

I tried using hyperv isolation but for me it didn't work.
You can find this complete example in my repo  https://github.com/edalx/servicefabric-examples/tree/master/servicefabric-container

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


Fix NPE described in #484

Fix #484
Signed-off-by: Ljupcho Palashevski<EMAIL_ADDRESS>

If the entity itself is null, I'm worried that some of the rest of the instance passed in to this method could also be null -- probably risky to make so many embedded retrievals (no null checking) as part of throwing the new exception... would suggest first ensuring any objects are non-null before throwing?

Valid point. I just added extra checks but I also checked upstream calls and there are few guid validations already happening before so these most probabbly will be present in the entityMap. Also I think entityMap.getRepositoryConnector().getRepositoryName() is quite safe since since it is also inistantiated and verified in the early startup sequences.


dbs-legacy-devices: support vm devices

Signed-off-by: wllenyj<EMAIL_ADDRESS>

Commit dbs-devices: add more test for serila device.'s commit title have a typo serila

Please remember to add Google's license (e.g. THIRD-PARTY file in db-arch) in this PR.

Commit dbs-devices: add more test for serila device.'s commit title have a typo serila

@ZizhengBian  Thanks, fixed

Please remember to add Google's license (e.g. THIRD-PARTY file in db-arch) in this PR.

@studychao Thanks, added

Need to add more detailed readme for dbs-legacy-devices


Add Dashboard Support

👋 Hey friends!
I have something I'm working on over at DigitalOcean. We use StackStorm for a lot of our automation. The project I'm working on currently is to create a dynamically updated dashboard as a sort of prioritization system for folks doing operational work on our infra. I've submitted a PR to pycontribs/jira to that end.
https://github.com/pycontribs/jira/pull/1837
I've been chatting with some of the maintainers over there and someone should be getting around to reviewing it soon. Anyway, I'm going to be working on a branch on my fork of this repo to implement these dashboard-related actions. I'll submit a PR once I'm finished, but realize, it probably shouldn't make it into main until the jira lib has also merged my changes into main over there.
 Thanks for building this pack! And I'm looking forward to contributing 😄.

Thanks, I added a similar comment in #73  just now prior to seeing this. Once we have changes upstreamed into jira I think this is fine to add and have no problems merging given these are new actions not affecting any existing actions in the pack. Thanks for the contribution.

Just made a comment on the PR to the same effect but, https://github.com/pycontribs/jira/pull/1837 has been merged and was included in https://github.com/pycontribs/jira/releases/tag/3.7.0 (which has since been bumped once more to 3.8.0 and published to pypi).


Rnn prediction dev

add rnn model file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: kechxu:white_check_mark: jinghaomiao:x: ZhongpuXiaYou have signed the CLA already but the status is still pending? Let us recheck it.


changed doc to say it returns current PWM dutycycle instead of 0

Chnaged docs in pigpiod_if.h and pigpiod_if2.3

Merged in v79


Code modification to display comids for huc01 with the new crosswalk-mapping.json format

Code modification for huc01 comids display
Additions

Removals

Changes
python/gui/MaaS/cbv/crosswalk.py
python/gui/MaaS/static/common/js/map.js
Testing
Display comids in the web browser as expected.
Screenshots
Notes

Todos

Checklist

[x] PR has an informative and human-readable title
[x ] Changes are limited to a single goal (no scope creep)
[x ] Code can be automatically merged (no conflicts)
[x ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[x ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ x] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] No linting errors or warnings

@stcui007, while the changes look fine, it looks like there is a merge conflict and they cannot be rebased automatically.  Please manually rebase things and fix the conflict, and then I'll review again.

Will do.
On Fri, Jan 14, 2022 at 9:20 AM Robert Bartel @.***>
wrote:

@stcui007 https://github.com/stcui007, while the changes look fine, it
looks like there is a merge conflict and they cannot be rebased
automatically. Please manually rebase things and fix the conflict, and then
I'll review again.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/DMOD/pull/111#issuecomment-1013217955, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA4SRNSW7Y7UTDIBAJ3JFTUWA5M3ANCNFSM5LZHK46Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you check if you can merge now?

Close this as stale.


Update Israel holidays

Proposed change

Update Israel holidays (Memorial Day and Independence Day observance).
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.923%. Remained the same when pulling a263f601854a72e88dc84ab614da3832c68e1868 on KJhellico:upd-israel into 5d1a3a7386e22fc0e142f59dd7d9ef784ee5e88a on dr-prodigy:beta.


chore(main): release 1.3.7

:robot: I have created a release beep boop
1.3.7 (2024-12-28)
Bug Fixes

docs (321a838)
rbac (bac53b7)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.3.7
:sunflower:


Add typescript definition file to the package.

It makes me sad that a project presumably designed to work with TypeScript doesn't include definition files for itself.  😢
// Could not find a declaration file for module 'rollup-plugin-sourcemaps'.
import sourcemaps from 'rollup-plugin-sourcemaps'
sourcemaps()

Please add a .d.ts file next to index.js in the distributed package!

I believe this is all that is needed for the definition files:
dist/rollup-plugin-sourcemaps.d.ts
import {Plugin} from 'rollup';
declare function sourcemaps(): Plugin;
export = sourcemaps

dist/rollup-plugin-sourcemaps.es.d.ts
import {Plugin} from 'rollup';
export function sourcemaps(): Plugin;

I don't know how to get those into the build process, otherwise I would submit a PR.

Sorry for late response, but we now ship our own type definitions since v0.5.0 is written in TypeScript


Scenes unable to be opened upon cylic preload() in script

Godot version
4.1 beta1
System information
Godot v4.1.beta1 - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 750 Ti (NVIDIA; <IP_ADDRESS>4) - 12th Gen Intel(R) Core(TM) i5-12400F (12 Threads)
Issue description
Update: I had a cylic preload in my script that prevented the file from being opened.
preload("res://Client/Scenes/GUI/Interface/Interface.tscn").instantiate()
Seemingly randomly, several of my scene files have failed to open with the following message in the console:

Oddly enough, after giving up on one of my old scenes that had corrupted, I tried to reopen it a few days later and it was working fine again despite displaying the "scene is invalid/corrupt" message.
Despite displaying as corrupted, the scene is still loaded into my game through and instance and works just fine, I just can't access it in editor.
Steps to reproduce
According to my version control, I haven't updated the scene at all even though it worked earlier.
Today I edited the script that scene contained, saved it, and later came back and the scene couldn't be opened any more.
Minimal reproduction project
n/a

seems like something is going on in cache..

nc == 0 error means there are no nodes. Can you send an example corrupted scene?

According to my version control, I haven't updated the scene at all even though it worked earlier.
Today I edited the script that scene contained, saved it, and later came back and the scene couldn't be opened any more.

Can you attach the corrupted scene? If it hasn't changed, perhaps this is due to cyclic preload(). See https://github.com/godotengine/godot/issues/74253#issuecomment-1564227775.

nc == 0 error means there are no nodes. Can you send an example corrupted scene?

Here!
Scene.zip

seems like something is going on in cache..

I deleted my .godot folder, but the scene remains corrupted

The file is not corrupted. Probably the problem is the one I wrote above or similar. Try replacing preload() in your scripts with load(), restart the editor and try opening the scene again.

The file is not corrupted. Probably the problem is the one I wrote above or similar. Try replacing preload() in your scripts with load(), restart the editor and try opening the scene again.

This was it. I changed the post title, but if this is a duplicate you can close it.

CC @adamscott

I would close this issue as duplicate of #70985.

Here's what working for me to fix this error: close editor, search in the .editor folder for all files containing the corrupted scene's name (they are going to be name something like your_scene_name.tscn-editstate-2e5312b3e75d2338868814f479b1feeb.cfg), delete them, restart editor.


Support UTF-8 Characters in File Names

I do know if this is an issue with middleman or middleman-blog, but it fails to find blog articles that have non-ASCII characters in the file name. This means that the blog title and the file name have to be different. In the case of Latin-based languages, the file name has to be stripped of accents.

Will investigate.


Bluetooth: controller: llcp: clean up of interface between HCI and ULL

Is your enhancement proposal related to a problem? Please describe.
Clean up the interface between HCI and ULL for procedures that are event-masked out by the host
The information is already available on the controller side, so we do not need to send a notification to the HCI and wait for the (negative) reply, as we do today
From the spec:
If the request is being indicated to the Host and the event to the Host is
masked, then the Link Layer shall issue an LL_REJECT_EXT_IND PDU with
the ErrorCode set to Unsupported Remote Feature (0x1A).
Describe the solution you'd like
Create a new API at the HCI level (in the controller side), which checks for which features are masked out, and send a REJECT_IND if the procedure is masked out. Note this check needs to be atomic

Not planned in the near future.


disable anonymous read when jenkins_authorization_strategy { 'hudson.security.FullControlOnceLoggedInAuthorizationStrategy':

I've been trying to scour the documentation, but I'm not seeing where I could set anonymous read to off in Jenkins after setting the auth strategy to fullcontrolonceloggedin.
Any help would be appreciated.
Thanks

Yeah, I've reread that file several times, but I still think I'm missing something.
My code looks like:
  jenkins_authorization_strategy { 'hudson.security.FullControlOnceLoggedInAuthorizationStrategy':
    ensure => 'present',
  }

  jenkins_security_realm { 'hudson.security.HudsonPrivateSecurityRealm':
    ensure    => 'present',
    arguments => [false, false, undef], # AllowSignup, enableCaptcha, {blank}
  }

and after running puppet, my auth strategy still has the "allow anonymous read access" flag enabled like this:

From your documentation, and what little I could read from your code (I'm a puppet and groovy newbie), the only thing that I can see where you actually disable anonymous read is via the github auth strategy.

but I'm not using that strategy, so I don't think it's applicable.
Am I missing something? or is there maybe a cli command that I should be running after that fact?
Thanks

OK - I thought you were reporting an error message from the CLI.  The value of arguments has to match the parameters of [one of the] constructor(s) of the class that provides the strategy.
In this case, you are configuring http://javadoc.jenkins-ci.org/hudson/security/FullControlOnceLoggedInAuthorizationStrategy.html#FullControlOnceLoggedInAuthorizationStrategy
Which appears to not accept any arguments via its constructor. So either the puppet provider and the puppet_helper.groovy script need special handling for this class to call methods on it or new constructor needs to be added to https://github.com/kohsuke/jenkins/blob/master/core/src/main/java/hudson/security/FullControlOnceLoggedInAuthorizationStrategy.java

I did this to make it work:
augeas { 'jenkins_config.xml - deny anonymous read access' :
incl    => '/var/lib/jenkins/config.xml',
lens    => 'Xml.lns',
context => '/files/var/lib/jenkins/config.xml/hudson',
changes => "set authorizationStrategy/denyAnonymousReadAccess/#text true",
onlyif  => "get authorizationStrategy/denyAnonymousReadAccess/#text != true",
subscribe => Jenkins_user[$jenkins_admin_username],
notify  => Service['jenkins.service'],
}


Failure aggregation fixes

These are some fixes necessary for rspec/rspec-support#210 in order to support rspec/rspec-mocks#956.
I also heavily refactored the exception presenter creation; it was very messy before.  Still a bit messy but much improved.

Kicked the travis build now that rspec/rspec-expectations#796 is merged.  Hopefully it'll pass this time.

This is green.  Anyone from @rspec/rspec care to review?

few comments, specs seem fine. Quite a few new large methods, might be good to break them apart if it's appropriate, but the implementation is :sparkles: :+1:

I addressed the typo pointed out by @samphippen.  The naming concerns brought up by @JonRowe are valid but they aren't new names in this PR (they just show up in the diff due to code moving to a new file) and I've got other aspects of rspec/rspec-mocks#956 that's a better use of my time, IMO, so I'm hoping @JonRowe will be cool with this being merged as-is and a follow up PR with renamings can happen if that's deemed important enough.

Yep, cool with that.


No default settings for output file

Hi first of all this is a great plugin. I think the following functionality would make this the best:

Default options for output CSS file - maybe the same file name and directory as the source file?
Right now when there is no output file specified, nothing happens. Instead, maybe it could work on the default option mentioned above?
If the output file is specified in the SCSS file, then it works as usual

This way one does not need to add the output file in the code of the file. This is specific to the editor and plugin, rather than the CSS, so it shouldn't ideally be part of the code.

Hm, interessting idea! +1
I think I will add this feature with next version. I think in next two weeks I will publish it!

yea i agree i don't know how to code that much and i just installed atom and this plugin and i'm having problems because it doesn't compile straight to the root as a default so i'm trying to figure out how to do that

+1 for default name and output this same as main scss file which is compiled

Please check the new version 0.10.0. I changed a lot of things there.

This is brilliant! Works very well :)

Great to hear ;)


[difference of squares] Lined up tests and examples with x-common/difference_of_squares.json

This includes the following:

Create 3 dedicated tests for square_of_sums/1 with arguments 5, 10,
and 100.
Create 3 dedicated tests for sum_of_squares/1 with arguments 5, 10,
and 100.
Create 4 dedicated tests for difference_of_squares/1 with arguments
0, 5, 10, and 100.
Implement the function difference_of_squares/1 in example.erl.
delete the former single test ten_test since it is now obselete.

Awesome, thanks.


[WIP] Collect version metadata

What does this PR do?

Collect version metadata for istio.
Motivation

Ongoing effort to collect version metadata about integrations.
Additional Notes

Relevant documentation: istioctl version.
Still need to figure out whether we can expect istioctl to be available in our users' environments. Eg. this page seems to indicate that istioctl must be installed separately.
QUESTION: e2e tests do not seem to have run — is there any extra step to get Terraform-based e2e tests to run? => See #5176
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Closing due to shift in priorities - left notes for takeover on AI-188.


Make fetch_links documentdb compatible

Both $set and $unset aren't supported by DocumentDB in aggregation pipelines, but the same functionalily can be done with $addFields and $project which are supported in both MongoDB and DocumentDB

Is there a reason not to merge this in?  We would love to have fetch_links work on DocumentDB instead of writing workaround code around it.


0.3.2 broke reverse proxy with Apache

A while ago I've figured how to make Uchiwa work via an Apache reverse proxy. This configuration has been running just fine since quite a few versions before:
ProxyRequests off
ProxyPreserveHost On
ProxyHTMLEnable On
ProxyPass /uchiwa/ http://localhost:3000/
ProxyPassReverse /uchiwa/ http://localhost:3000/
ProxyHTMLURLMap http://localhost:3000/ /uchiwa/
#ProxyHTMLURLMap http://localhost:3000/ /socket.io/

ProxyPass /socket.io/1/websocket ws://localhost:3000/socket.io/1/websocket
ProxyPassReverse /socket.io/1/websocket ws://localhost:3000/socket.io/1/websocket
ProxyPass /socket.io/ http://localhost:3000/socket.io/

Today I've updated to 0.3.2 and suddenly the reverse proxy has stopped working. I do get the Uchiwa GUI, but there's no data, and there are several red error popups saying: "Oops! Something went wrong. Could not fetch Sensu data. Is Uchiwa running?"
In the sensu-api.log I do see the requests from Uchiwa:
{"timestamp":"2014-11-10T12:03:02.656892-0800","level":"info","message":"GET /stashes","remote_address":"<IP_ADDRESS>","user_agent":"Go 1.1 package http","request_method":"GET","request_uri":"/stashes","request_body":""}
{"timestamp":"2014-11-10T12:03:02.658327-0800","level":"info","message":"GET /checks","remote_address":"<IP_ADDRESS>","user_agent":"Go 1.1 package http","request_method":"GET","request_uri":"/checks","request_body":""}
{"timestamp":"2014-11-10T12:03:02.659909-0800","level":"info","message":"GET /clients","remote_address":"<IP_ADDRESS>","user_agent":"Go 1.1 package http","request_method":"GET","request_uri":"/clients","request_body":""}
{"timestamp":"2014-11-10T12:03:02.663593-0800","level":"info","message":"GET /events","remote_address":"<IP_ADDRESS>","user_agent":"Go 1.1 package http","request_method":"GET","request_uri":"/events","request_body":""}
{"timestamp":"2014-11-10T12:03:02.665804-0800","level":"info","message":"GET /info","remote_address":"<IP_ADDRESS>","user_agent":"Go 1.1 package http","request_method":"GET","request_uri":"/info","request_body":""}

The Uchiwa logs are not very helpful. uchiwa.err is empty, and uchiwa.log only has the regular startup messages:
{"Date":"2014-11-10T11:48:22.644696945-08:00","Level":"info","Src":{"Func":"github.com/sensu/uchiwa/uchiwa.LoadConfig","Line":96},"Output":"Loading configuration file /etc/sensu/uchiwa.json"}
{"Date":"2014-11-10T11:48:22.645086744-08:00","Level":"info","Src":{"Func":"github.com/sensu/uchiwa/uchiwa.WebServer","Line":146},"Output":"Uchiwa is now listening on <IP_ADDRESS>:3000"}

I've made sure uchiwa.json is pointing at the right stuff.
Any ideas what to try first?

Why is the trailing slash required here? Typically when reverse proxying applications (such as Atlassian's JIRA, Confluence, etc.) you don't need one. Is there some (trivial) change that could be made to the AngularJS routing to avoid this? Would prefer to just link users to http://public/uchiwa.

:+1:


How i can know coordinates midpoint created line?

Hi!
Please tell me, can i know coordinates midpoint created line?
I need to "bind" another HTML element to this coordinates.
Thanks!

Hi @v1nt1248, thank you for the comment.
Does the "coordinates midpoint created line" mean coordinates on the line?

H!
Yes exactly :)

You can get <path> element by this:
document.querySelector('.leader-line .leader-line-line-path')

Then, you can get the path data via d attribute or pathSegList property.
Note that these are not supported.

No reply came, then this abandoned issue is closed.


Type Error: Argument 1 passed to ....BaseOptionsField::optionLabel()...buttonbox/src/fields/Width.php line 100

Just updated to the lasted build of buttonbox (2.0.2) and getting this error on save of entities with the "Width" plugin used.
Argument 1 passed to craft\fields\BaseOptionsField::optionLabel() must be of the type string or null, array given, called in /srv/www/website.ca/vendor/supercool/buttonbox/src/fields/Width.php on line 100
Detail: Using Width inside a Matrix, inside a Super Table.
Using PHP 7.1

I am also getting a similar error, with ButtonBox version 2.0.2, Craft version <IP_ADDRESS> when saving an entry, as follows:
 TypeError: Argument 1 passed to craft\fields\BaseOptionsField::optionLabel() must be of the type string, array given, called in /[*removed*]/vendor/supercool/buttonbox/src/fields/Buttons.php on line 102 and defined in /[*removed*]/vendor/craftcms/cms/src/fields/BaseOptionsField.php:314
PHP version: 7.0.30

Getting the same error:
Argument 1 passed to craft\fields\BaseOptionsField::optionLabel() must be of the type string or null, array given, called in /vagrant/vendor/supercool/buttonbox/src/fields/Buttons.php on line 102

PHP 7.2.8
Craft CMS 3.0.20

Getting the same error:
Argument 1 passed to craft\fields\BaseOptionsField::optionLabel() must be of the type string or null, array given, called in /home/removed/vendor/supercool/buttonbox/src/fields/Buttons.php on line 102
Using Button Box - Buttons field.
Craft CMS PRO 3.0.29
PHP version: 7.2.10

So I got around the issue by downgrading to 2.0.1, then in the using SequelPro, to modify the MySQL Database: plugin table, and upped the version number of the buttonbox plugin to 2.0.2 so that I wouldn't accidentally upgrade it — I know this is not a fix, but a dirty work around.
Incidentally, the problem is in the following file: /src/fields/Width.php, starting at line 96 through 112
But I don't (yet) know enough about Craft Plugin dev to help with actual code reco's


Average salary?

Looks very promising and should get huge traction!
Wondering how fast it will get at top here

One can write no code in any language. Therefore, the expected average salary would be the sum of all those.


Add testimonials

We can add testimonials
kindly assign me,i really want to work on this

@atihsir We have not planned for testimonials yet.


introduce ParquetCacheableFileReader support cache BinaryDataFiber

What changes were proposed in this pull request?
Introduce ParquetCacheableFileReader which supports cache BinaryDataFiber. This is a subtask of binary cache support as discusse in  #1047 .
How was this patch tested?
add new ut.

cc @LuciferYang

related to #1124

@LuciferYang thanks for the review, the last commit address the comments you left

@ivoson @LuciferYang
Sorry for delay reponse for #1118
https://github.com/Intel-bigdata/OAP/pull/1118/files#r364077887
Thanks.


Create does not load properly with VS-Addition installed

Mod Name
Create
This issue occurs when only Valkyrien Skies, addons, and the mod I have specified are installed and no other mods

[x] I have tested this issue and it occurs with only Valkyrien Skies, addons, and the mod I have specified

Minecraft Version
1.20.1
Mod Loader
Forge
Issue description
Issue occurs on both Fabric and Forge
The game crashes during mod loading with Create installed, on Forge loader that is not 47.2.0
Forge error screen reads as follows:
Create (create) has failed to load correctly
org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered

Issue reproduction

Install VS-Addition and dependencies in the latest Forge and Fabric loaders
Install Create or Create Fabric respectively

Logs
Forge log: https://mclo.gs/oQINcKJ
Forge crash report: https://mclo.gs/tEfZ1oP
Fabric log: https://mclo.gs/DEceT6d

Try the latest version and see if it solves the issue


feat: Add Pagination to Members Page

Description
Add Pagination to load the members list on members page
Fixes #85
Flutter Channel:

[x] I have used the Flutter Beta channel on my local machine

Type of Change:
Delete irrelevant options.

Code

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Physical Device.

Checklist:
Delete irrelevant options.

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

[x] My changes generate no new warnings

Wow, great!

i did not expect a straight away approve lol, no need to change variable names or something? xd Thanks @bartekpacia :+1:

XD
variable names are really important;)

XD
variable names are really important;)
also, you are PRO

shhh, ghosts lurking

@Techno-Disaster delet 👀
XD

@anitab-org/qa-team can anyone test this?
Steps :
Go to members page and scroll down too see if pagination works as required.

@anitab-org/qa-team can anyone test this?
Steps :
Go to members page and scroll down too see if pagination works as required.

The steps you mention here can be mentioned on the how has this been tested section in your PR description.

@anitab-org/qa-team can anyone test this?
Steps :
Go to members page and scroll down too see if pagination works as required.

The steps you mention here can be mentioned on the how has this been tested section in your PR description.

ok. thanks

Not from QA team just tested this out of curiosity. Works perfectly fine on my phone. Great Work! @Techno-Disaster

@Techno-Disaster What about increasing the number of paged records? Currently it seems to have to be reloaded a bit too often.

@Techno-Disaster What about increasing the number of paged records? Currently it seems to have to be reloaded a bit too often.

you mean increasing the number of members we get on screen each load?

Exactly.

Exactly.

Thats just hardcoded to 10, are you saying we should decrease it? 🤔

@isabelcosta what do you think about this? how many members should be loaded at once?

@Techno-Disaster I have no idea what the criteria should be for deciding this number. @bartekpacia any idea? If in doubt, we can ask for help. @annabauza mind to give your opinion here?

We could give the user the option, but considering what kind of app this is and what its purpose is, it feels a bit irrelevant also giving users technical options would confuse them i think

Loading more number of users would obviously need more time to load. and the app kinda already feels slow, IMHO 10 is a good number. 15 looks good too

I'd load 20-25. The app will get faster in the future as we'll improve it. Fetching just 10 users doesn't solve the problem of slowness.

Here's how 30 looks. IMO 30 looks a bit slow cc: @isabelcosta @bartekpacia @annabauza

@isabelcosta @bartekpacia @annabauza any updates? I attached a load 30 members per page video above for refrence

Here's how 30 looks. IMO 30 looks a bit slow cc: @isabelcosta @bartekpacia @annabauza

@bartekpacia @Techno-Disaster My vote goes to 20, its a middle between 10 (too fast) and 30 (too slow).
I don't know exactly what would be the best criteria here, but based on your points I believe that is a good choice.

@bartekpacia @Techno-Disaster My vote goes to 20, its a middle between 10 (too fast) and 30 (too slow).
I don't know exactly what would be the best criteria here, but based on your points I believe that is a good choice.

I am good with 20 too :)

Small update, I was running this on the debug app version which is slower than the actual release apk. @bartekpacia what do you think we should go with?

Let's stick with 20 :)

Hey I'd love to gove you guys some input on this, this is kinda wrong way to do it!
Why dont you guys do something like:
fetchUsers(query, limit, skip) {
    // Returns limit no of users, searched over the db with query and for next one call to fetchUsers, it skips the limit you provided cause the objects or whatever returned from db doesn't change that fast!

I've been using this, its a gud pattern i guess!
It lets me define different limits for different things, like when i want to search for people i put limit to null and Put data returned in an infinite scroll.
For when a user search in like a emailing box, it shows like 10-20 or so.
What you guys say?

Hey I'd love to gove you guys some input on this, this is kinda wrong way to do it!
Why dont you guys do something like:
fetchUsers(query, limit, skip) {
    // Returns limit no of users, searched over the db with query and for next one call to fetchUsers, it skips the limit you provided cause the objects or whatever returned from db doesn't change that fast!

I've been using this, its a gud pattern i guess!
It lets me define different limits for different things, like when i want to search for people i put limit to null and Put data returned in an infinite scroll.
For when a user search in like a emailing box, it shows like 10-20 or so.
What you guys say?

Currently we only have a /users/verified endpoint from which we get the list and don't need it anywhere else apart from  the members page. Also the backend team plans to change this soon, they are planning to change how users are sent, I'm not sure though and this might change how we fetch user list on the app, so I think we can write this part after thats done. .Maybe @isabelcosta could help you with this. Thanks for your update thought 👍😀

Here's a test apk which loads 20 members per page, its a release build so this would be performance you would get if the app was released on the store.
https://webapp.diawi.com/install/NHFk1S

@isabelcosta looks like its ready to be merged 👀

Awesome @Techno-Disaster and @foongminwong  👏


DevFest Jammu

Date : 19th Dec 2022
Event (DevFest or Cloud Community Days or Cloud NEXT) DevFest
City : Jammu
Your Name : Shikha Saxena
Your talk topic : Life in Google (Keynote session)
Brief Description (if you'd like) : The session was about life in Google, opportunities in Google for early career / startups, How Google Developer group can add value
Provide 3 links if you have:
Presentation link (This is mandatory) https://docs.google.com/presentation/d/1dWXSMrIl4PHZUeJmEz4vReZvF5B91e95qwn4ps-2irM/edit#slide=id.g1bbdaaebf67_0_6948

Thank you.


Add missing tutorial extra dependency

Tutorial 15 is currently missing the metrics extra, that makes the evaluation part of the tutorial to fail.
See attached screenshot of the error. This PR will fix the failure.

Let's merge this after #176 so we can verify that the workflow actually upload correctly to deepset Cloud.