How to deploy portainer as a service with Docker's new 'Docker Cloud Swarm mode.

I followed https://docs.docker.com/docker-cloud/cloud-swarm/ to setup a new swarm with 3 managers and 3 workers.
I created a /data on the primary manager node. But when I then run the command from the docs to deploy portainer it complains about an incorrect mount option.
Command:
docker service create --name portainer --publish 9000:9000 \
--constraint 'node.role == manager' \
 --mount type=bind,src=/data,dst=/data \
--mount type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock \
portainer/portainer -H unix:///var/run/docker.sock

Chickens out with:
1/1: invalid mount config for type "bind": bind source path does not exist
Both: /data and /var/run/docker.sock exist and are writable by the docker group. Am I doing something wrong?
When I create a local volume:
docker volume create data
I'm able to start the service with:
--constraint 'node.role == manager' --mount type=volume,src=data,dst=/data \
--mount type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock portainer/portainer \
-H unix:///var/run/docker.sock```

Hi @acidjunk
It might be related to the fact that theree are 3 manager nodes in your cluster. You'd need to ensure the /data folder exists on each before deploying Portainer.
Also, the recommended way to deploy Portainer as a Swarm service is to deploy it as a single instance replica service:
docker service create \
    --name portainer \
    --publish 9000:9000 \
    --replicas=1 \
    --constraint 'node.role == manager' \
    --mount type=bind,src=//var/run/docker.sock,dst=/var/run/docker.sock \
    --mount type=bind,src=/data,dst=/data \
    portainer/portainer -H unix:///var/run/docker.sock

Note that you still need to ensure that the /data folder exists on each manager as Swarm can schedule the Portainer container on any of these.

Thanks for the quick reply. Tried creating a /data on all nodes (even workers), but the same problem persists. I'm not sure how to further debug this.

@acidjunk did you deploy a service with a single replica?
Copy and paste the service logs or any Portainer container logs in here, we'll try to help you debug this.

I am having the same issue with just 1 manager. The following command fails with
1/1: invalid mount config for type "bind": bind source path does not exist
docker service create --name portainer --publish 9000:9000 \
--constraint 'node.role == manager'
--mount type=bind,src=/data,dst=/data
--mount type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock
portainer/portainer -H unix:///var/run/docker.sock

For me it works fine with the docker volume (and replicas == 1). But the command with bind doesn't work. The funny thing is that: --mount type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock doesn't yield an error.
How can I preserve the install log? I've some time tomorrow to do a fresh reinstall.

To you both @acidjunk and @devkws
If the socket bind mount is correct, that means that the data folder bind mount is incorrect, are you sure that the /data folder is available the hosts where Portainer should be deployed and that Docker can actually writes to these folders?

All stuff executed from manager1
permissions of /data:
~ $ ls -al /
total 72
drwxr-xr-x    1 root     root          4096 Feb 28 10:05 .
drwxr-xr-x    1 root     root          4096 Feb 28 10:05 ..
-rwxr-xr-x    1 root     root             0 Feb 24 11:09 .dockerenv
drwxr-xr-x    1 root     root          4096 Jan  8 21:12 bin
drwxrwxr-x    2 docker   docker        4096 Feb 28 10:05 data
drwxr-xr-x    5 root     root           340 Feb 24 11:10 dev
-rwxr-xr-x    1 root     root           743 Jan  8 21:07 entry.sh
drwxr-xr-x    1 root     root          4096 Feb 24 11:09 etc
drwxr-xr-x    1 root     root          4096 Feb 24 11:09 home
drwxr-xr-x    1 root     root          4096 Jan  8 21:12 lib
drwxr-xr-x    2 root     root          4096 Jan  8 21:12 lib64
drwxr-xr-x    5 root     root          4096 Dec  1 16:31 media
drwxr-xr-x    2 root     root          4096 Dec  1 16:31 mnt
dr-xr-xr-x  124 root     root             0 Feb 24 11:10 proc
drwx------    2 root     root          4096 Dec  1 16:31 root
drwxr-xr-x    1 root     root          4096 Feb 24 11:10 run
drwxr-xr-x    2 root     root          4096 Dec  1 16:31 sbin
drwxr-xr-x    2 root     root          4096 Dec  1 16:31 srv
dr-xr-xr-x   13 root     root             0 Feb 24 11:10 sys
drwxrwxrwt    2 root     root          4096 Dec  1 16:31 tmp
drwxr-xr-x    1 root     root          4096 Jan  8 21:12 usr
drwxr-xr-x    1 root     root          4096 Feb 24 11:09 var
~ $

Previously /data was owned by root and only group was docker. I use ansible for maintenance on the manager nodes and also tried 777 on /data
The sock file is:
~ $ ls -al /var/run/docker.sock
srw-rw----    1 root     docker           0 Feb 24 11:10 /var/run/docker.sock

Cmd to install portainer
~ $ docker service create --name portainer --publish 9000:9000 --replicas=1 --constraint 'node.role == manager' --mount type=bind,src=//data,dst=/data \
--mount type=bind,src=//var/run/docker.sock,dst=/var/run/docker.sock portainer/portainer \
-H unix:///var/run/docker.sock
overall progress: 0 out of 1 tasks
1/1: invalid mount config for type "bind": bind source path does not exist

Maybe we are running into some docker cloud swarm mode beta problem?

Found some info here but still not sure if this is a bug or not
https://github.com/moby/moby/issues/24089

Looks like this could be related to Docker cloud, yes. Are you able to run other services using bind mounts? Such as a nginx service for example ?

I just ran into the same issue with a 1 manager deployment via docker for azure.

@acidjunk @devkws what Docker version are you using ?

I need to check tomorrow but definitely latest stable as of yesterday

I deployed the swarm on 24 feb: Docker version 17.12.0-ce, build c97c6d6
Tried:
docker service create --name load-balancer --replicas=3 \
--mount type=bind,src=//data,dst=/usr/share/nginx/html nginx

Same error.
In the mentioned ticket of moby/moby:
"Docker doesn't do data migration itself, so swarm can't be responsible for having the data on the machine. For stateful apps you need use something like ceph plugin to mount the storage on the node."
I just wanted to try portainer by pinning it to manager1: but it seems that you are now forced into setting up a distributed filesystem (or use the volume mount)

Yeap, looks like it's related to Docker cloud then... not sure how can we help here.

For now I think the only thing is to add a note to the docs :)
I going to write a short tutorial about setting up Amazon EFS and use that as a distributed filesystem.
Thanks for all the help!

All right, thanks for the report ! I'll keep this issue open in the meantime. Someone might be able to help us figure out the solution.

FYI the Docker Cloud service is shutting down next month: https://docs.docker.com/docker-cloud/migration/

sudo mkdir -p /opt/portainer
sudo chown $USER:docker /opt/portainer/

With Docker Cloud shutdown, I believe we can close this issue.


qiime not installed (env created from .yml file)

The issue is described in detail here here
I have tried an older yml file (https://raw.githubusercontent.com/qiime2/environment-files/master/2022.2/release/qiime2-2022.2-py38-linux-conda.yml) and from the environment created with this yml file I can invoke qiime.
Conda version is 23.1.0

Hello @BCArg, please create a thread for this issue under the technical support category on the QIIME 2 user forum here. You will receive support from QIIME 2 maintainers there. Thank you.


Description of journey import clarification...

Describe the bug
The help mentions  -f, --file   Name of the file to write the exported journey(s) to. Ignored with -A.
I believe it is required for read during import as well - minor nit.
Likewise to import what is required? a -f and -t? for a single tree in a single JSON?  An example please!

Completed. Help output for journey import in 2.x:

Completed. Help output for journey import in 2.x:
% frodo journey import
Unrecognized combination of options or no options...
Usage: frodo journey import [options] [host] [realm] [username] [password]

Import journey/tree.

Arguments:
  host                         Access Management base URL, e.g.: https://cdk.iam.example.com/am. To use a connection profile, just specify a unique substring.
  realm                        Realm. Specify realm as '/' for the root realm or 'realm' or '/parent/child' otherwise. (default: "alpha" for Identity Cloud tenants, "/" otherwise.)
  username                     Username to login with. Must be an admin user with appropriate rights to manage authentication journeys/trees.
  password                     Password.

Options:
  -a, --all                    Import all the journeys/trees from single file. Ignored with -i.
  -A, --all-separate           Import all the journeys/trees from separate files (*.json) in the current directory. Ignored with -i or -a.
  --curlirize                  Output all network calls in curl format.
  -D, --directory <directory>  Set the working directory.
  --debug                      Debug output during command execution. If specified, may or may not produce additional output helpful for troubleshooting.
  -f, --file <file>            Name of the file to import the journey(s) from. Ignored with -A.
  --flush-cache                Flush token cache.
  -h, --help                   Help
  -i, --journey-id <journey>   Name of a journey/tree. If specified, -a and -A are ignored.
  -k, --insecure               Allow insecure connections when using SSL/TLS. Has no effect when using a network proxy for https (HTTPS_PROXY=http://<host>:<port>), in that case the proxy must provide this
                               capability. (default: Don't allow insecure connections)
  -m, --type <type>            Override auto-detected deployment type. Valid values for type:
                               classic:  A classic Access Management-only deployment with custom layout and configuration.
                               cloud:    A ForgeRock Identity Cloud environment.
                               forgeops: A ForgeOps CDK or CDM deployment.
                               The detected or provided deployment type controls certain behavior like obtaining an Identity Management admin token or not and whether to export/import referenced email templates
                               or how to walk through the tenant admin login flow of Identity Cloud and handle MFA (choices: "classic", "cloud", "forgeops")
  --no-cache                   Disable token cache for this operation.
  --no-deps                    Do not include any dependencies (scripts, email templates, SAML entity providers and circles of trust, social identity providers, themes).
  --re-uuid                    Generate new UUIDs for all nodes during import. (default: off)
  --sa-id <sa-id>              Service account id.
  --sa-jwk-file <file>         File containing the JSON Web Key (JWK) associated with the the service account.
  --verbose                    Verbose output during command execution. If specified, may or may not produce additional output.

Evironment Variables:
  FRODO_HOST: Access Management base URL. Overrides 'host' argument.
  FRODO_REALM: Realm. Overrides 'realm' argument.
  FRODO_USERNAME: Username. Overrides 'username' argument.
  FRODO_PASSWORD: Password. Overrides 'password' argument.
  FRODO_SA_ID: Service account uuid. Overrides '--sa-id' option.
  FRODO_SA_JWK: Service account JWK. Overrides '--sa-jwk-file' option but takes the actual JWK as a value, not a file name.
  FRODO_NO_CACHE: Disable token cache. Same as '--no-cache' option.
  FRODO_TOKEN_CACHE_PATH: Use this token cache file instead of '~/.frodo/TokenCache.json'.
  FRODO_CONNECTION_PROFILES_PATH: Use this connection profiles file instead of '~/.frodo/Connections.json'.
  FRODO_AUTHENTICATION_SERVICE: Name of a login journey to use.
  FRODO_DEBUG: Set to any value to enable debug output. Same as '--debug'.
  FRODO_MASTER_KEY_PATH: Use this master key file instead of '~/.frodo/masterkey.key' file.
  FRODO_MASTER_KEY: Use this master key instead of what's in '~/.frodo/masterkey.key'. Takes precedence over FRODO_MASTER_KEY_PATH.
%


MVP

[x] Move navbar items into a footer
[x] Add links to coreqs/prereqs
[x] Responsive design for all pages
[x] Add clear button to explore page controls
[ ] Add instructors to search index
[ ] Instructor page
[ ] Seed database with ratemyprof reviews (or reviews from some other source) => write some one-off scraper for this
[ ] Add back other rating criterias

Usefulness
Birdiness
... etc

[ ] Generate user avatars
[ ] Display schedule information on client
[ ] Animations (framer motion (maybe) => eat ram)
[ ] Other field for instructors (?)
[ ] Add instructors to explore page (?)
[ ] Add privacy policy page
[ ] Select multiple instructors in review form

deployment after we check all these 👀

Other field for instructors (?)

reviews :  Review[]

seems like a good idea since we are showing them on the instructor page

How do you feel about a
courses: Course[]

under Instructor?
Then on the instructor page we can display reviews given to that instructor + the courses that they are currently teaching

How do you feel about a
courses: Course[]

under Instructor?
Then on the instructor page we can display reviews given to that instructor + the courses that they are currently teaching

We can get all of this information by extending some of the routes we have, i.e. for review we'd do /reviews?instructor_name=... and for courses we'd do /courses?instructor_name=... or for this one we'd add it to the body and also add an instructor filter to the explore page

Alpha is done, going to move incomplete items over to the Beta launch tracking issue 🚀


Can't send notifications to multiple recipients in Pipeline Configuration

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
I'm trying to add multiple recipients in the Pipeline Configuration.

However, by setting up the configuration as shown above, only the address<EMAIL_ADDRESS>can get the notification email, it received the same notification THREE TIMES.
It seems that only the bottom one can get the notification.
Result:
Only the last recipient can get the notification.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.2.7
Installation option (single install/HA):
single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):

Machine type (cloud/VM/metal) and specifications (CPU/memory): AWS t2-large

Kubernetes version (use kubectl version):

Docker version (use docker version):
19.3.1

Version - master
I was able to reproduce this.  Pipeline notification, will send the last recipient multiple emails dependent on the amount of recipients I added.  We should really fix this.  I checked the console and it's sending and posting properly.  It also looks like it's stored in the API properly.

rancher/rancher:master-head 41ce3ac49

Deployed Rancher master-head
Created cluster
Created an email notifier
Created a pipeline with multiple notification recipients on success/failure
Executed pipeline
Email notifications were sent properly to each individual recipient


Fix cli distributed command hang issue

What changes are proposed in this pull request?
Whenever the job command status is being asked for the job command id, it is mostly being asked by alluxio cli client in synchronous mode, it should return the status immediately in case of plan info has one of the finished status like failed, completed or cancelled instead of checking its children tasks' status and deriving the final status.
Why are the changes needed?
As per #16708, the distributed cli commands like distcp and distload hang; same behaviour observed consistently whenever any job worker is declared disconnected by job master.
Currently, the job master derives the status for job command id by calling its children job control id which internally, derives its status from its children's status. In normal circumstances, all the children of job control id have expected status but in circumstance like any job worker disconnected from job master, children have different odd status combination like one has RUNNING while other has FAILED or COMPLETED even though its job control id has FAILED final status (plan info). This situation makes the job command id always in RUNNING state and apparently, alluxio cli client waits forever.
The job control id (plan info) should return the status whenever it has one of the finished status like failed, completed or cancelled instead of deriving from its children.
Does this PR introduce any user facing changes?
NA

Tested locally, this PR should solve the job hang problem when a job worker is lost. Thanks for fixing this!

alluxio-bot, merge this please


Set up repository

Use the node.js/TypeScript example server code.
cc @t-sauer

ea30987e :tada:

It seems like you included both the server and the client from the example language server.
Since the client is pretty much only the plugin for vscode to talk to the language server and the language server itself should be independant of any editors I think the client part should be removed. So basically I think we only need the server folder in here.

@t-sauer happy to have it split it out; I initially left it in to make the feedback-and-testing loop short as we initially spin things up.


upgrade mockito to run tests with jdk 12

Hi @fabriziofortino many thanks for entering this! Let me have a look


Functionality Issue

Issue
Toggle left-to-right button functionality not working properly
Current Behavior 😯
On click of Left-to-right some text not displaying properly when trying to change it in the original state.
Expected Behavior 🤔
All content to be shown properly when clicked on Left-to-right
Page Link :
https://material-ui.com/components/click-away-listener/
Try to click ok left-to-right/right-to-left button.
See the text in the image.

Tech
Version

Browser
Opera

We don't actively support the Opera browser. See https://material-ui.com/getting-started/supported-platforms/#supported-platforms for a list of browsers we do support.

Same Issue also in chrome version  80.0.3987.122(latest).
But it Works fine In Firefox

Can't reproduce with chrome version 80.0.3987.122 on Ubuntu.

I believe we have already seen such comment in the past. You need to use a font that supports right to let.

same issue on window chrome version 80.0.3987.122(latest).

Can't reproduce with chrome version 80.0.3987.122 on Ubuntu.

i am on windows not ubuntu


BUG: Add sys.path changes to inference script

Closes #770

It would be great to rely on [local] pip installations at some point, instead of relying on manually adding stuff to sys.path.


feat: config file commands

This branch adds commands to edit and create a config file this will store the strawpoll API key and currently also stores a formID that can be saved using the form [form_ID] --save command or using the config formID [form_ID] command. This PR will help with calling the program easier in future on the same form.
Resolves #13

Need to create a remove command then it'll be good to review


Day 468

Good morning! Here's your coding interview problem for today.
This problem was asked by Facebook.
Given an N by N matrix, rotate it by 90 degrees clockwise.
For example, given the following matrix:
[[1, 2, 3],
 [4, 5, 6],
 [7, 8, 9]]

you should return:
[[7, 4, 1],
 [8, 5, 2],
 [9, 6, 3]]

Follow-up: What if you couldn't use any extra space?

Identical to Day 168: https://github.com/vaskoz/dailycodingproblem-go/issues/348


Unregister jack ports before creating new ones

In the jack receiver, before creating jack ports because of a configuration change, the old ports should be unregistered.
If this is not done, creating new ports will fail, because the old ports still exist and have the same names.
I've also added a -c command line switch to disable automatically connecting jack ports, for people who use their own jack connection manager.

Thanks :)


Fix up unparsing when generating specifications

This PR enables re-building the unparser after adding the productions with the K helpers defined for a contract.
That way, we are not manually patching the symbol table to unparse these generated productions.

contract_to_k and gen_claims_for_contract are lowered to take an empty_config as input, instead of a entire KEVM, which makes it easier to use them in more places (for a later PR).
The typing around some of the generator functions is tightened up, to help catch errors earlier: _extract_function_sentences, generate_function_sentences.
_parseByteStack is moved to a static method KEVM.parse_bytestack.
Factors out functions which should be upstreamed in utils.py: KPrint_make_unparsing and KDefinition_module_names and KDefinition_empty_config.
Adds klabels to some of the generated functions in the specification, for proper unparsing.
Removes the symbol table updates that were used for unparsing, in favor of rebuilding an unparser after adding the generated productions.

Going to break this into several PRs instead.


Unexpected character met when parsing the API

Hello,
I've noticed that times to times the json serializer fails when trying to read received payloads. I get the following exception:
Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
   at Newtonsoft.Json.JsonTextReader.ParseValue()
   at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at Miki.Net.Http.HttpClient.SendAsync[T](RequestMethod method, String url, String value)
   at Miki.Net.Http.HttpClient.GetAsync[T](String url)
   at DiscordBotsList.Api.DiscordBotListApi.GetAsync[T](String url)
   at DiscordBotsList.Api.DiscordBotListApi.GetBotAsync[T](UInt64 id)
   at DiscordBotsList.Api.AuthDiscordBotListApi.GetMeAsync()
   at Energize.EnergizeClient.UpdateDBLServerCount() in /home/earu/Energize/Energize/EnergizeClient.cs:line 110
   at Energize.EnergizeClient.<InitializeAsync>b__31_0(Object arg) in /home/earu/Energize/Energize/EnergizeClient.cs:line 136
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---

Here are the calls that caused the above exception:
            int servercount = this.DiscordClient.Guilds.Count;
            if (!this.IsDevEnv)
            {
                IDblSelfBot me = await this._DiscordBotList.GetMeAsync();
                await me.UpdateStatsAsync(servercount);
            }

You can find the up-to-date code at https://github.com/Earu/Energize/blob/master/Energize/EnergizeClient.cs#L105
This most likely happen when the API is down or unreachable.

Yeah, this means the API does not return valid JSON. and should handled gracefully in the request. 😄


wasi-common: add preopened_handle, to be able to open any handle

This is a follow-up to https://github.com/bytecodealliance/wasmtime/pull/1600 ; that also makes it possible to write custom Handles for directories. For my specific case, it is so as to be able to have a wasmtime-async-compatible WASI.
I've raised the question on zulip #wasmtime without answer yet (not sure whether #general should be preferred?), so I've just decided to go on with this PR, and will start using my fork and checking whether I can make things work properly with it starting now :)

Side-note: preopened_dir and preopened_virt could both be refactored to lower to preopened_handle if making it take a function instead of directly a handle. I'm not yet sure whether that's something you'd want so restrained myself for now but it would be possible too, though I'm not really sure what PendingPreopen actually brings in practice compared to just opening ahead-of-time (and thus seeing potential errors happen as soon as possible)

Side-note: preopened_dir and preopened_virt could both be refactored to lower to preopened_handle if making it take a function instead of directly a handle. I'm not yet sure whether that's something you'd want so restrained myself for now but it would be possible too, though I'm not really sure what PendingPreopen actually brings in practice compared to just opening ahead-of-time (and thus seeing potential errors happen as soon as possible)

Hi. Sorry I missed your message on the bytecode alliance discord.
Your use case is important to me. I'm nearing completion of a complete rewrite of wasi-common that, among other things, redesigns the traits so that files and directories have distinct sets of methods. https://github.com/bytecodealliance/wasmtime/pull/2487 I expect this PR will land within a week or so. (When it is ready to land, i'll rename the wasi-c2 crate back to wasi-common, thats just a name under development.)
The new design of the ctx builder should support your use case possible - https://github.com/bytecodealliance/wasmtime/blob/pch/wasi_common_cap_std/crates/wasi-c2/src/ctx.rs#L104
Is it OK to close this PR and you can re-target your work at the rewritten wasi-common?

Hi. Sorry I missed your message on the bytecode alliance discord.
Your use case is important to me. I'm nearing completion of a complete rewrite of wasi-common that, among other things, redesigns the traits so that files and directories have distinct sets of methods. https://github.com/bytecodealliance/wasmtime/pull/2487 I expect this PR will land within a week or so. (When it is ready to land, i'll rename the wasi-c2 crate back to wasi-common, thats just a name under development.)
The new design of the ctx builder should support your use case possible - https://github.com/bytecodealliance/wasmtime/blob/pch/wasi_common_cap_std/crates/wasi-c2/src/ctx.rs#L104
Is it OK to close this PR and you can re-target your work at the rewritten wasi-common?

That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime depends on this version of wasi-common so I could take a git-dependency and start developing against that version?

That sounds really reasonable, thank you! Is there a branch somewhere where wasmtime depends on this version of wasi-common so I could take a git-dependency and start developing against that version?

If you're on that branch and depend on wasi-c2-wasmtime it should work in the place of wasmtime-wasi

If you're on that branch and depend on wasi-c2-wasmtime it should work in the place of wasmtime-wasi

Great, I'll try doing that. Thank you!

Great, I'll try doing that. Thank you!


CIF-743/CIF-804 - Add option to enable and disable client-side price fetching

Description

Added options in design dialog of product and productlist components to disable client-side price fetching.
Minimize GraphQL queries for smaller footprint of GraphQL requests
Improved error handling in GraphQL client

Also contains feedback from https://github.com/adobe/aem-core-cif-components/pull/64 and https://github.com/adobe/aem-core-cif-components/pull/62.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #71 into master will decrease coverage by 0.31%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     63.15%   62.83%   -0.32%
  Complexity      168      168
============================================
  Files            28       28
  Lines           996     1001       +5
  Branches         64       64
============================================
  Hits            629      629
- Misses          338      343       +5
  Partials         29       29

Flag
Coverage Δ
Complexity Δ

#karma
94.39% <100%> (ø)
0 <0> (ø)
:arrow_down:

#unittests
53.31% <0%> (-0.35%)
168 <0> (ø)

Impacted Files
Coverage Δ
Complexity Δ

...onents/internal/models/v1/product/ProductImpl.java
37.33% <0%> (-0.51%)
20 <0> (ø)

...nternal/models/v1/productlist/ProductListImpl.java
30.18% <0%> (-0.59%)
16 <0> (ø)

...ore/components/models/productlist/ProductList.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...t/v1/productlist/clientlibs/dist/js/productlist.js
91.66% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ommerce/product/v1/product/clientlib/js/product.js
93.54% <100%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cf3a9...b3b1e75. Read the comment docs.


Reducer action

Use Redux in React components
Heyo :wave:

In this PR I:

Refactor the code to make sure  that the state immutable in reducers.
Pass an array of books as an initial state for the books reducer
Import Redux Provider and the store in the main component then connect the app to the Redux store.
Display books
Use Redux useDispatch to Add, Remove books and Check status
Fix linters errors
Follow GitFlow

Cheers

Hi @Salwa99, kindly add the key features section to your readme

@prolajumokeoni  what should I add exactly

Hi @Salwa99, you are missing the key features section in your readme, please add it

@prolajumokeoni   you for mentioning the issue in the Readme file😊


Crash with Simple Fuel Generator in NeoForge 1.20.6

Hi again Dire,
Found that the fuel generator JustDireThings has is crashing the game the second you try putting any burnable in the furnace. Not really sure why it is doing this, but just wanted to let you know. I've got the log below
Log:
latest.log

Hey thanks for the report! I just fixed this the other day actually. I’ll get it released shortly :)
this commit should have fixed it:
https://github.com/Direwolf20-MC/JustDireThings/commit/970cd0bdd43168a8e647f041ae07646bd276b67b


Addition of concept of Disjoint Set Union.

Addition of DSU concept.
Often it is also called Union Find because of its two main operations.
I want to add a text file for the implementation details as well as,
I will add a question that involves this concept,
Please accept my improvement. @avinash201199 , and assign me this issue.

I have posted the corresponding PR for this.

Addition of DSU concept.
Often it is also called Union Find because of its two main operations.
I want to add a text file for the implementation details as well as, I will add a question that involves this concept,
Please accept my improvement. @avinash201199 , and assign me this issue.

@khushbooSingh99
Great :)


The regular expression for files in .pre-commit-config.yaml must be improved

It is not quite clear why the ^src/.+cpp regular expression is used. Why explicitly allowing for multiple extensions ? In any case, you should add a comment in the yaml file for making your intention explicit.

not an issue
closed


Technical Interview - Stack & Queues

Description
This issue should contain an approach to the top 10-12 questions of Stack & Queues. In cpp/java language. Video Solution will be good if made !! Search for the quality questions on the web and explain the approach in your words for each problem you solve (either you can add comments in the code or subtitles in your video).
Domain
Interview Prep
Type of Contribution
Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

I want to on the documentation part of this issue.
/assign

/assign


JedisConnection - Socket not closed properly when redis.quit command fails

Hi,
When a host is unreachable or read timeouts are encountered, the JedisConnection.close() method doesn't ensure that the socket is properly closed :
    @Override
    public void close() {
        jedisClient.quit();
        jedisClient.disconnect();
    }

I.e, the jedisClient.disconnect() is never called if the jedisClient.quit() fails.
Under heavy load, the number of TCP connections in ESTABLISHED state can go beyond the configured connection pool size (MaxConnsPerHost).

@rprevot we are experiencing similar issues especially when we have abrupt issues on one or more Dynomite nodes in the cluster. Restarting the clients once the Dynomite becomes healthy brings the connections to a normal state (within the configured #max pool size). The fix you have suggested is still in the open state. Do the changes you suggested solve the problem in your environment?


No segmentation and KNN notebook

Hi!
In README you mentioned three notebooks:

Object segmentation notebook
Embedding baseline notebook
KNN shallow-dimension reasoning notebook

But I can see only second one. Can you clear it up?

We are updating repositories daily these days - today, for example, we update our second dataset repo with additional data.
Stay tuned for updates!

Got it, thanks.


Alt+D / Ctrl+L hotkeys don't focus the address bar when the active tab is on Home

Description
See GIF

Tags:
Alt + D, Ctrl + L
Steps To Reproduce
1- Go to Home
2- Press Ctrl+L or Alt+D
Expected behavior
Alt+D or Ctrl+L should shift focus to the address bar when the active tab is on Home
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 21H2 22000.318
Relevant Assets
No response

Merging with #6800


Document missing options

Some of the following options are not in the docs:
https://github.com/luraproject/lura/blob/4d35e4812fc689fbac8009fa3fe85371d6f56c52/config/parser.go#L140-L154

here you have the list with comments: https://github.com/luraproject/lura/blob/4d35e4812fc689fbac8009fa3fe85371d6f56c52/config/config.go#L57-L139

Pushed to v2.0 branch


Smaller MAX_PACKET_SIZE and better batch cache locality

This is a very arguable change, feel free to reject.  I'm seeing a consistent ~ 0.7 % send rate improvement with lower-end hardware at 10 GbE close to but not quite at max send rate.

Change how batch is laid out in memory:  Since all access is one packet at a time and never all IPs or all lengths, lay out all fields pertaining to the same packet adjacent in memory, for sequential access (single array of packets with metadata instead of separate arrays for packet data, lengths and ips)
Reduce MAX_PACKET_SIZE from 4k to 2k minus metadata, which is still way above the standard MTU of 1500 that we probably don't want to exceed in order to avoid IP fragmentation

Extra benefits:

Arguably cleaner code for accessing the packets in batches (no manual offset calculations)
Single definition of MAX_PACKET_SIZE instead of the previous two definitions of MAX_PACKET_SIZE

Tested on the usual macOS Sonoma, FreeBSD 14 and Ubuntu 23.10 with and without netmap.

Thanks. Performance increase is slim, but it's a cleaner design for sure, so happy to merge.


Support more _config file formats

There's no reason we can't support _config files written in TOML, JSON, or as a JavaScript module.
So long as it can get parsed into a JS object and validated against the schema it's fair game.
So we should add support for:

TOML
JSON
JavaScript Module

a non issue w/ v3


Running TSJS models

Hey mbeissinger, this is probably not the right place to post this but I wasn't sure how else to reach out. I have been using your converter for about a week now to train a model in lobe and run it in a JS environment. Between some warnings on conversion and some errors at runtime, I haven't been able to successfully do this.
I am new to TSJS so I am positive this is may fault but now that you have integrated TSJS exports into lobe and I still can't get this to work I figured I would reach out.
Do you have an example of how to load and run a model from lobe in TSJS?
I have been running the below code with the following error:

The dict provided in model.execute(dict) has keys: [0,1,2,3,4,5,6,7,8,9,10,11,12] that are not part of graph at GraphExecutor.checkInputs

I am using node version 14.14.10, Tensorflow JS version 2.7.0, Tsjs-node  version 2.7.0
const tf = require("@tensorflow/tfjs");
require("@tensorflow/tfjs-node");

let image = "testImage.jpg";

let model;
predict(image)
  .then((prediction) => {
    console.log(prediction);
    console.log("Finsihed");
  })
  .catch((err) => {
    console.log(err);
  });

async function predict(data) {
  console.log("loading model...");
  model = await tf.loadLayersModel("file://newModel/model.json");
  console.log("loaded model, now executing model...");
  return model.execute(data);
}

Again, I am sorry if this is not the right place to ask this. I really appreciate the work you guys are doing on Lobe. It is truly a fantastic app and I wish you the best of luck!

I did not realize there was an example folder in the output. You guys really did think of everything.


Better types, return hexIndex and maxDepth in state getter, fix import

The package can't be imported in typescript because mod.js is missing a type definition file. This PR creates a mod.d.ts file which fixes this issue. It also fixes some type definitions, add missing type definitions, and makes the state() method return hexIndex and maxDepth so that the state can be properly restored; without this, hexIndex has to be tracked separately and maxDepth has to be saved from the initialState, which is a pain

Awesome work, thanks again!
Sorry for not merging earlier, I started overthinking it and here we are.
Anyway have a good one!


Inconsistency within water

Description of the issue
I spotted a small inconsistency:

water is defined as: Water is a portion of matter with the chemical formula H2O. It has a liquid normal state of matter.
ocean is defined as: The ocean is a water body that consists of salt water and is covering approximately 71% of Earth's surface.

The class ocean is via liquid water and water body a subclass of water. The definition of water basically says it is pure H2O, but ocean water is not pure as it also contains salt (and :fish: ... :smile:).
Ideas of solution
I see two options to solve this:
Option 1
Neglect this slight inconsistency, but then we should at least add an editor note, that we are aware of this inconsistency.
Option 2
Distinguish between:

pure water: Pure water is a portion of matter with the chemical formula H2O. It has a liquid normal state of matter.
water: Water is a portion of matter that consists mainly of pure water, but has impurities of other portion of matters.

The class liquid water can stay then a subclass of water, but steam would then probably become a subclass of pure water (or however we would label this class), as when water evaporates it separates from salt.
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

I'm in favor of option 1 by adding an editor note: We are aware that water is defined as pure H2O in the OEO and that naturally occuring water usually also also contains impurities of other portions of matter (e.g. minerals). We purposely neglect this inconsistency for usability reasons.

Okay, so I will implement this editor note.


Preparing for 1.0.0

Creating version 1.0.0. The intent here is to add version support to tiopatinhas so further improvements could be organized in different version tags.

@barata @raittes @mwconceicao


Would like an example of playing music with background execution in Flutter

e.g. https://codelabs.developers.google.com/codelabs/android-music-player/index.html except in Flutter.
This came up from discussions with a customer.   FYI @bkonyi @RedBrogdon

Would we want this example for both Android and iOS?

I wouldn't necessarily start with the goal of publishing. Nice to do if others think it's worthwhile, but I think the most useful part of this exercise is to validate that the background execution code we have is able to support (common?) use cases like this.
If I were doing this I'd try on Android and see if that works.  If you/matt/android/others decide its worth publishing, then I'd try to do on both.

I think MP3 players and the like are a very common type of project, so this will be extremely useful.
I have just published a new package that does background execution of audio called audio_service:
https://pub.dartlang.org/packages/audio_service
I have only implemented the Android side of things but am hoping someone with the relevant iOS knowledge is out there and willing to contribute.
What this plugin does is set up all the platform-level stuff typical for playing audio (in Android, starting a media browser service in the foreground, acquiring a wake lock and audio focus, etc.) but let's you write your audio playing code itself in dart making use of other dart plugins to do the actual audio playing. This is (for starters) because some users of this plugin may want to play MP3s in the background while other users may want to play text-to-speech or some other custom audio (think of an RSS reader that reads out articles with text to speech).
One thing I've noticed is that a lot of plugins out there won't actually work when registered with the registry for the FlutterNativeView because they do something like registrar.activity().getApplicationContext() and here activity() will be null and produce a NullPointerException. The best I can do is to contact the authors of those plugins as I encounter them to suggest a fix.
Anyway, please feel free to try out audio_service and contributors are welcome (especially on the iOS side!)

I have a question about how to manage spawning and destroying the background isolate, whether we should leave one running forever or repeatedly start and stop one as needed.
There is overhead in spawning a new isolate and initialising it, so on pausing the media player, I think it makes sense to keep the background isolate alive so that playback can be resumed quickly. This is as opposed to when the user stops the media player where I guess it's OK to completely shut down the background isolate. (Or is it?)
All of the Google-provided examples so far keep the background isolate running forever (or until it is forcibly destroyed by the system to reclaim memory). So if you wanted to do it, what would be the recommended way to manually shut down the isolate, either from within the isolate or externally? Or is it just recommended to follow the provided examples and just leave the isolate running forever?

@ryanheise the isolate ends itself like main() does if it has no more work to do.
This usually means when the event queue is empty.
So if there are no more futures awaited or streams subscribed to.
You could also use https://api.dartlang.org/stable/2.1.0/dart-isolate/Isolate/kill.html but that would not be a good fit for your situation.
I think you need to do some profiling (memory usage when kept open vs startup time) to figure out if it is better for your use case to keep it open or close-and-reopen.

@zoechi Thanks very much for the explanation. I'm guessing that platform channels also fall into this category, so I would need to call channel.setMethodCallHandler(null) within the isolate before the isolate will shut down gracefully?
I've updated the audio_service plugin to retain the isolate on pause and (hopefully) terminate the isolate on stop.

As far as I remember channel.setMethodCallHandler(null) is not necessary.

@zoechi Hmm, then how does the background isolate normally stay alive long enough to receive messages on the method channel? For example, here's the isolate entrypoint for the Geofencing plugin by @bkonyi
void callbackDispatcher() {
	const MethodChannel _backgroundChannel =
			MethodChannel('plugins.flutter.io/geofencing_plugin_background');
	WidgetsFlutterBinding.ensureInitialized();

	_backgroundChannel.setMethodCallHandler((MethodCall call) async {
		print("Callback Dispatcher Invoked: ${call.arguments}");
		final List<dynamic> args = call.arguments;
		final Function callback = PluginUtilities.getCallbackFromHandle(
				CallbackHandle.fromRawHandle(args[0]));
		assert(callback != null);
		final List<String> triggeringGeofences = args[1].cast<String>();
		final List<double> locationList = <double>[];
		// 0.0 becomes 0 somewhere during the method call, resulting in wrong
		// runtime type (int instead of double). This is a simple way to get
		// around casting in another complicated manner.
		args[2]
				.forEach((dynamic e) => locationList.add(double.parse(e.toString())));
		final Location triggeringLocation = locationFromList(locationList);
		final GeofenceEvent event = intToGeofenceEvent(args[3]);
		callback(triggeringGeofences, triggeringLocation, event);
	});
	print('GeofencingPlugin dispatcher started');
	_backgroundChannel.invokeMethod('GeofencingService.initialized');
}

It seems to me that the only thing keeping the isolate alive is the method channel. But if you're right, it raises the question of what we would need to do to let the isolate die.

Not sure. Perhaps someone else with more insight can shed some light.

Any Audio player that supports background music play in both platform

I'm using the fluttery_audio plugin to play any song from remote
you can use it
https://pub.dev/packages/fluttery_audio
----- I migrated my project to android and I met this error with this plugin, can someone help me please
this is my error
Android -> Flutter: onBufferingUpdate()
E/AndroidRuntime(29083): FATAL EXCEPTION: AudioPlayer
E/AndroidRuntime(29083): java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: AudioPlayer
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:605)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:515)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:76)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:166)
E/AndroidRuntime(29083):     at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:155)
E/AndroidRuntime(29083):     at io.flutter.plugin.common.MethodChannel.invokeMethod(MethodChannel.java:98)
E/AndroidRuntime(29083):     at io.flutter.plugin.common.MethodChannel.invokeMethod(MethodChannel.java:84)
E/AndroidRuntime(29083):     at io.fluttery.flutteryaudio.FlutteryAudioPlugin$1.onPlayerPlaybackUpdate(FlutteryAudioPlugin.java:83)
E/AndroidRuntime(29083):     at io.fluttery.flutteryaudio.AudioPlayer$1.run(AudioPlayer.java:218)
E/AndroidRuntime(29083):     at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime(29083):     at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(29083):     at android.os.Looper.loop(Looper.java:193)
E/AndroidRuntime(29083):     at android.os.HandlerThread.run(HandlerThread.java:65)

I'm using the fluttery_audio plugin to play any song from remote
you can use it
https://pub.dev/packages/fluttery_audio
----- I migrated my project to android and I met this error with this plugin, can someone help me please
this is my error
Android -> Flutter: onBufferingUpdate()
E/AndroidRuntime(29083): FATAL EXCEPTION: AudioPlayer
E/AndroidRuntime(29083): java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: AudioPlayer
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:605)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:515)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:76)
E/AndroidRuntime(29083):     at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:166)
E/AndroidRuntime(29083):     at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:155)
E/AndroidRuntime(29083):     at io.flutter.plugin.common.MethodChannel.invokeMethod(MethodChannel.java:98)
E/AndroidRuntime(29083):     at io.flutter.plugin.common.MethodChannel.invokeMethod(MethodChannel.java:84)
E/AndroidRuntime(29083):     at io.fluttery.flutteryaudio.FlutteryAudioPlugin$1.onPlayerPlaybackUpdate(FlutteryAudioPlugin.java:83)
E/AndroidRuntime(29083):     at io.fluttery.flutteryaudio.AudioPlayer$1.run(AudioPlayer.java:218)
E/AndroidRuntime(29083):     at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime(29083):     at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(29083):     at android.os.Looper.loop(Looper.java:193)
E/AndroidRuntime(29083):     at android.os.HandlerThread.run(HandlerThread.java:65)

I am having the exact same issue and am getting the same stack trace when using fluttery_audio.
Have you by any chance found a solution to your problem?

You can try audioplayer which doesn't have this error:
https://pub.dev/packages/audioplayer
You can use audioplayer in combination with audio_service to play audio in the background:
https://pub.dev/packages/audio_service
Background audio is Android-only so far, but help is wanted for the iOS side:
https://github.com/ryanheise/audio_service/issues/10

Any updates on a Flutter plugin that plays audio from a local flutter asset folder (or web) and playing audio in the background while showing media controls on the lock screen. Written in Kotlin might be a good way to go since its the default Android language when creating a  new Flutter project.
I have looked at every audio plugin and none of them really do the above feature, most plugins come close but also they look not updated.
Thank you and do believe a good audio player plugin is really needed for flutter like the video_player plugin from the Flutter team.

Hi @Sun3
If you were to write this in native Android, you would use MediaPlayer to play audio, and you would use MediaBrowserService to support background play with controls on the lock screen.
In Flutter, my audio_service plugin creates for you the MediaBrowserService, and the audioplayer plugin (among many others) creates you a MediaPlayer. audio_service simply wraps a service around any other audio code you want to write in order to keep it running in the backround and present the lock screen controls.
So, you can do what you describe with audio_service, and the example project already demonstrates playing audio from the web in the background and showing media controls on the lock screen. I'd be interested to know what you believe can't be done with this plugin and I'd be happy to help.
Once you create an audio service, you can write whatever audio playing code you like inside of it. My example demonstrates playing audio from the web, and also playing text to speech, but you could also play audio from assets by using Flutter's AssetBundle to copy the asset data into a regular file and then use the audioplayer plugin as before to play it, or if it's a short audio file you could use the soundpool plugin.
The video_player plugin does not support background execution, although I am creating a fork of this project to support it. Once that is done, you should also be able to add background and lock screen controls with audio_service.

They are all great plugins.
The audiplayer plugin doesn't handle showing the media controls on the lock screen and doesn't handle loading local audio files located in the Flutter app project structure. It was updated 10 months ago.
The audio_service plugin doesn't support loading local audio files located in the Flutter app project structure.
The assets_audio_player plugin does load audio assets from the flutter assets folder but does not support playing media controls from the lock screen. It was updated about 6 months ago.

The audio_service plugin doesn't support loading local audio files located in the Flutter app project structure.

But I actually do exactly what you describe in my own app using those plugins, and I explained in my previous comment how I did it.

audio_service allows you to run any audio code in the background with lock screen controls
AssetBundle lets you read data from an asset
audioplayer lets you play that audio

I think the AssetBundle API is the ingredient you're missing. It might be convenient if the audioplayer plugin added support for playing directly from assets, but it is literally only one extra line of code for you to do that extra step yourself with AssetBundle.
Perhaps you're after an all-in-one plugin, but since Flutter is designed to be composable in order to allow mixing and matching of components, I think this is more in the spirit of Flutter. Consider that there are many different use cases for types of audio you might want to play in the background, such as:

Streaming audio from a URL/URI
Text To Speech
Local assets
Synthesised audio
Custom audio sequences involving combinations of the above within the same media session
etc.

That last point means there is actually an infinite number of different use cases, and audio_service tries to stay agnostic of all of that allowing you to write your "own" code to play whatever audio you want, so it does not limit you. audio_service does this by asking you to implement a callback like this:
onStart: () async {
   ... write here STANDARD dart code to play your audio ...
}

This way, I can support all of the above infinite use cases easily.
Do you want to play audio from an asset? Then insert code in that callback to do just that:
onStart: () async {
    await File(filePath).writeAsBytes(
        (await rootBundle.load('assets/$name')).buffer.asUint8List());
    AudioPlayer audioPlayer = new AudioPlayer();
    audioPlayer.play(filePath);
}

I understand what you are saying, and yes :) I would love to see one plugin to handle audio for different secnarios. I still would like to suggest a Google handling an audio plugin (like the video_plugin they support) by using Swift and Kotlin since it's the new default languages selected for new projects. Any plugins written in Java/Objective C in future OS releases will they be compatible/updated respectively for each OS platform, API depreciation, or..? I know Java in not going away anytime soon but Objective C has been deprecated for a while and apps are written in Swift (and now SwiftUI).
My personal experience in past apps is when you introduce too many plugins or outside libraries you might run into issues in the future when updates are needed. One plugin updates and the other doesn't. I still remember in my Windows programming the DLL hell.
@ryanheise I really do thank you for your feedback and suggestions and you have great plugins.
Your suggestion to load audio assets from the Flutter asset bundle does work by loading the asset then copying it to the appropriate iOS and Android local folders.
In the plugin itself, for example loading the Flutter asset directly from the Android code would be:
val assetManager = registrar.context().assets
val key = registrar.lookupKeyForAsset("assets/audios/my_audio_file.mp3")
val fd = assetManager.openFd(key)

Thanks

@Sun3 Putting aside the suggestions directed at Google, I'll just comment on the idea of building a monolithic plugin that does everything conceivable. The key point you have to understand here is that the only way to handle all scenarios is to use a callback. What you need, for good reasons, is a separate API to begin and end a background audio session, and a separate API to play text to speech, and a separate API to play an audio file, and a separate API to do synthesised speech, and so on and so on, and you want all of these to work together.

Developers should be able to link in only the APIs they use. Not all apps want to use the text-to-speech API in the background, so they should be able to use the text-to-speech API without the background audio API, for example. They should also be able to use audio player API without having to link in the library for text-to-speech.
Developers should be able to explicitly begin and end a background audio session, and then be able to execute a programmable "sequence" of audio output code within that background session. For example, imagine something like an MP3 player with a play list that plays a sequence of audio files within the same background audio session, and then imagine a similar app that uses text-to-speech to play a sequence of news items in your feed, all within the same audio session, and then imagine another app that is actually able to do something similar with a mixed feed where some items in the feed have MP3 enclosures, and other items in the feed have just plain text, and you'd like your app to BEGIN a background audio session, then loop over each item in the feed, and depending on the item play it as an audio file or read it out in text to speech, and then END the audio session. If you think the best way for Google to handle this use case is to build exactly that scenario into their plugin, then keep in mind that that was just one very specific case. There are many apps that do all sorts of custom sequences of audio all within the same background audio session, and the only way to handle this is to treat the management of the background audio session as a separate API.

So sure, you can encourage Google to come up with their own officially maintained plugin for the various motivating reasons you have stated (and I am open to that), but even if they do, they will likely come up with a very similar design to the one I arrived at if they want to support all use cases. That is, separate APIs that can be mixed and matched rather than a single plugin that links in text-to-speech and playing audio files and synthesised audio, and custom sequences involving program logic.
(It should also be worth noting that Google actively encourages the community to contribute to Flutter in an open source fashion rather than them building official plugins for everything. I'd also like to point out that my plugin is designed to do a single job and do that job well, but it's also a library which means other projects can link it in. If you would like to contribute in some way to solving your specific problem for other people, one thing you could do is create your own audio plugin that links in audio_service and audioplayer, and provides the exact API that you want, and share it on pub.dev)

@ryanheise I wasn't suggesting to build a monolithic plugin that does everything conceivable. Like I previously stated I think you have great plugins. I am only asking Google to consider to create like an audio_plugin like their video_plugin. Maintainability is a strong concern when building enterprise level apps and the language that they are written and ability to keep up with future OS updates is something that I learned early on that it could kill your app.
I appreciate all of your suggestions.

I wasn't suggesting to build a monolithic plugin that does everything conceivable [...] I am only asking Google to consider [...]

Your suggestions to Google are separate, so just to be clear, I have nothing more really to say on that personally. I was more concerned about your feedback on the plugins developed by the open source community that Plugin A didn't offer the services of Plugin B or C, and Plugin B didn't offer the services of Plugin C, and Plugin C didn't offer the services of Plugin B. (A = Audio, B = Background, C = Assets). For example, you commented about my plugin (B):

The audio_service plugin doesn't support loading local audio files located in the Flutter app project structure.

when in fact you are free to mix and match A + B + C to meet your requirements. And then you clarified:

I would love to see one plugin to handle audio for different secnarios.

So this is really what I understood your request to be in terms of features.
You may not want all other conceivable combinations for yourself, but I'm asking you to consider that other users want A + B + "D", and others want A + C + E, and yet others just want "D", and so on ("D" could be something like text-to-speech, "E" could be generated/synthesised audio). So designing a set of APIs needs to consider this, and from a birds eye view, it begins to make sense to make each of these separate APIs which you can mix together in any combination that fits your specific use case. Again, this point is independent of whether you would rather Google build these plugins.

All of your points in terms of features are great, I do not disagree with them :)

Hi! I use audioplayers to listen to a radio channel (streaming). It works well in the background except when the user receives a call. I this case the playing stops but doesn't restart automatically at the end of the call. Any solution for that? Thank you!!!

It's been a year... has anyone contributed the iOS part yet?

Hi @remoteportal
Not yet. A number of community members have contributed pointers to the iOS code that will need to be integrated, but unfortunately (and understandably) the issue is that we are all open source volunteers who have various other priorities that get in the way. However, very recently, two contributors have offered to try to work on the iOS side: https://github.com/ryanheise/audio_service/issues/10#issuecomment-542005602

@consuelogranata , audio_service provides the necessary callbacks to detect when you receive a call so that you can pause, and when audio focus returns to your app so that you can resume audio playback.

@remoteportal I was recently able to get my hands on a Mac, watched a Lynda.com tutorial on Objective C, and was able to hack together a partial iOS implementation. We also have others contributing iOS pull requests on this base, so it appears the ball is rolling.
Most features are actually implemented on iOS, except for displaying certain information in "Now Playing" such as album art and the current playback position, which we hopefully hope to have down the track.
You can try out audio_service here.

In addition to a solution for Android and iOS, I also need to play audio on the web. An official package would be nice.

i was working on Audio_service plugin for my app, i am having a problem playing the MediaItems which I load dynamically from JSON,
i defined the AudioPlayerTask constructor this way in the AudioPlayerTask class
AudioPlayerTask(List queue, int queueIndex){
this._queue = queue;
this._queueIndex = queueIndex;
}
i instantiate the values  this way from a different page,
void _audioPlayerTaskEntrypoint() async {
AudioServiceBackground.run(() => AudioPlayerTask(queue,-1));
}
the parameter queue is a type of List which is populated from the JSON file this way
data = ModalRoute.of(context).settings.arguments;
for (var mp3 in data['data']){
 if(queue.isEmpty || queue.length < 45){
      MediaItem songs = MediaItem(id:mp3.xsources_mp3,
                  album: mp3.xtitle,
                  title: mp3.xtitle,
                  artist: mp3.xauthor,
                  duration: int.parse(mp3.id)*4000,
                  artUri: mp3.ximage);
     queue.add(songs);
  }if(queue.length > 46){
    queue.clear();
  }
}

But I am unable to add this to the audio service background and run it.
Please help me to solve this and make my Audio_service play the musics.
Thank you in advance.

https://github.com/rohansohonee/ufmp
UFMP is the sample app that I have put together using @ryanheise plugins. This sample can be the starting resource for how one can build an audio app. Feedback and improvements are welcome.

Clearing my assignment as I won't have time to look at this in the foreseeable future. @RedBrogdon, maybe this is something DevRel could pull together at some point?

Adding will need additional triage based on the issue reported which is quite old and to properly track it going ahead.


Link/button to clear successfully uploaded files

When uploading many files at the same time, it could be useful the clear all the rows, where files are successfully uploaded instead of removing one by one and then make it make clear which files are in progress. E.g. like this: http://www.infragistics.com/samples/aspnet/web-upload/multiple-upload
Another idea could be the sort successfully uploaded files together (maybe at the bottom).

Hi, regarding the sorting thing. What about automatically remove successfully uploaded items after for example 1 or 2 seconds?

Yes, it could be an idea. Not sure how it works with many files and if you notice the files that have been successfully uploaded?

That's true could be kind of tricky to check whether a file is uploaded or not. So lets stick with the Clear Button :)

Ok! The new version is available!


Adding INTR and iBTC

This PR adds:
New tokens:

INTR token
iBTC token

Destinations:

Moonbeam < INTR > Interlay
Moonbeam < INTR > Acala
Moonbeam < iBTC > Interlay
Moonbeam < iBTC > Acala
Acala < INTR > Interlay
Acala < iBTC > Interlay

Proofs:
Acala uses baseFee for INTR and iBTC, as dex has not supported it yet:
https://github.com/AcalaNetwork/Acala/blob/master/runtime/acala/src/xcm_config.rs#L147

Moonbeam fee was taken from runtime
Interlay fee was taken from Canonicalized part
All fee was calculated by functions:
https://github.com/nova-wallet/support-utils/pull/4

Fix for acala iBTC:
BaseRate =<PHONE_NUMBER>000000
iBTC minimal balance = 100
ACA minimal balance = 100_000_000_000
iBTC_coefficient =<PHONE_NUMBER>000000 * (100 / 100_000_000_000) = 1 158 700


Dual marker shows wrong values

Joulescope model
JS110
UI version
other
What OS are you seeing the problem on?
Windows 10
What happened?
UI v1.0.25
I observed a discrepancy between dual marker values and window value. They should be almost the same because signal is 0 outside markers.

I exported both "visible data" and "all data" and when I opened the files, the value for markers has changed. For me this means there is a bug in dual marker integral.
exportedJLSfiles.zip
What was expected?
Correct computed values in dual marker
How to reproduce?
capture some data and put dual marker. I did not do anything special and I'm not sure this is reproductible. I will update the issue if I find something.
Extra information
No response

Hi @atsju - I don't know about this particular waveform.  It looks like there could be a small negative current event at about 925, but you can double-check.  On the marker with text, right-click, then select Show statistics → Left.  Drag the right dual marker all the way to the right side and the left dual marker all the way to the left side.  Do the values now match?  If so, then this is not an issue with the UI.  Instead, it is a feature of the waveform.
If you do not want to adjust your measurement dual markers, you can place additional dual markers to the left and right that go to the display edge.  You can sum up the integrals.
What do you find?

Please open the zip file. I shared the exact same file. And you should see that value is different from the print screen.
In the mean time I will do what you request. Lucky you, I didn't close the capture

UI bug confirmed :

Please note that right click on a thin maker line is not easy and not natural. I did not expect this feature there.

Did you recreate this on the buffered data or the one of the JLS files that you provided?

this capture is from the same instance as first capture with same data and window not moved. Opening an export of same data does not show the bug (as you can see in the zip)

So far, I have not been able to recreate what you are seeing.  However, I am also using a JS220, not a JS110.  I do expect small differences between the dual markers and the right-hand side statistics, like this:

This does not explain the 10% difference in the second image above.
It sounds like this is easy data to capture.  Since I only have access to the JLS file (which does not show this issue), can you check if this is a consistent issue?  Capture data, then place dual markers over one event, as you did above.  Repeat for a couple other events.  Is the value dual marker value and the right-hand side statitics values always the same as you captured above (dual marker integral approximately +10% greater than right-hand side statistics)?
Note the these statistics values are computed differently.  The dual markers are computed over the exact marker positions, which is the pixel center when repositioning the markers.  In contrast, the right-hand side statistics are computed over the visible plot data, which is left-most sample in the first pixel to the right-most sample in the last pixel.  To make things more complicated, the buffered sample data and JLS data compute their statistics using completely different code.
For performance reasons, this code is highly optimized which makes it complicated.  For example, here is the code for the buffered sample data.  The code for the JS110 and JS220 is the same, but how it is used could be slightly different.
I am traveling now, and I will try some more testing with a JS110 when I return to the office next week.

For information, I did some more tests right now with same device and it's definitely reproductible.

I successfully duplicated this issue:

I was able to track it down to the summary computation in joulescope_driver.  These summaries are used to greatly speed the computation of statistics and waveforms.  Unfortunately, when more than one summary value was computed over a single input block, the statistics accumulator was not reset correctly.  See joulescope_driver 8c6714d.  This error also was likely slightly distorting zoomed out waveforms for live streaming and buffered samples.  It would not have affected JLS files.
This will be fixed in joulescope_driver 1.3.18 and Joulescope UI 1.0.26.

You should be able to download and install 1.0.26, which fixes this issue and more.  The new relative x-axis markers do not quite work correctly, so we will make a new release 1.0.27 that will hopefully make it to our next stable release.


androidx support？

projects with Android X support will not built with it. seems imagepickersave has Android X
support issue.

@jinfagang  image picker save  is other plugin。 it's just in demo, you can update the lastest version of image picker save to slove Android X

Ok, unfortunately, for anyone else got same issue, image_picker_saver newest does not support android x yet


DOC: Remove claims of unbiasedness from doc string for std

xref #12230

@TomAugspurger ?

+1, For reference the np.std docstring also clarifies that a `ddof=1 still won't be an unbiased.

is it worthwhile putting in a link to the wiki on the doc-string?

Do you mean our wiki or wikipedia? I'd say no either way probably.
Are you OK with merging even though that py35 build failed? I saw you open that other issue.

Actually should I just say 'sample standard deviation' in basics.rst and computation.rst, since the correction can be specified by passing ddof?

Well actually the same can be said of variance, so never mind.


Upgrade MongoDB.app to v3.0.3-build.2

Thank you for the contribution. It was merged directly as e00eabaf60d3adaae6be5df21d88cf907ca18755 to keep commit history cleaner. Your contribution is still credited to you.


[BUG]: Having Witness Name or Designation only one be needed mandatorily

Describe the bug
The witness name or designation alone are adequate to have a witness added into the case
To Reproduce
Steps to reproduce the behavior:

Go to 'File a Case'
Click on 'Witness Details'
Add a witness
Scroll down to witness name and witness designation fields
See error

Expected behavior
Either only name or designation of the witness should have been mandatory

hi @deeshita, I have a few doubts which needs clarification:

Currently we don't have any field named as witness designation, so do we need to add that and if yes then where should we put this field, below age?
If that field is added, do now only 2 fields should be mandatory, i.e. first name and witness designation and all the address fields should be optional?
the above 2 points are for 1st witness or all the witness which are being added?
cc: @Ramu-kandimalla

Overall, this item is falling under e-filing form and validations. Hence, addressing it also by referencing the same:

Yes, it will have to be added as in https://docs.google.com/document/d/1fAsmhWX8JqyRWF0cDfHdWbB0m0mINEWbxHq8Qfsxf5A/edit?tab=t.0 item #36 in the linked sheet. Ideally, it should come after the name fields unless some other logic is being used while adding designation for parties.

Either witness name or designation will have to be mandatory. The user will need to have the option to input one. For example, they can either add "Ram" as a witness or "Bank Manager, Canara Bank" as a witness. Without needing to provide, the alternate field. Address can be treated like it currently is - no change to that.

The above shall apply to all witnesses

hi @rajeshcherukumalli changes corresponding to this feature are completed and merged in develop branch. please test it in QA when it's deployed there. cc: @Ramu-kandimalla

Hi @ashishbeehyv, the changes are not deployed in QA env:
complaint.webm
Moving the ticket to dev testing.
cc: @Ramu-kandimalla @rajeshcherukumalli

Hi @ashishbeehyv, @Ramu-kandimalla
This Issue is working fine in DEV

TEST SCENARIOS

Advocate
Litigant

Refer Screen Recording
Witness name and designation.webm

Hi @ashishbeehyv, @Ramu-kandimalla
This Issue is working fine in DPG-DEV

TEST SCENARIOS

Advocate
Litigant

Refer Screen Recording
https://github.com/user-attachments/assets/44e2bb66-05aa-4222-addb-b039fd1f5d84

Hi @deeshita, @Ramu-kandimalla , @Susmitabe , @rajeshcherukumalli
This is Resolved in UAT

TEST SCENARIOS

Advocate
Litigant

Refer Screen Recording
https://github.com/user-attachments/assets/22f9813f-988e-4caf-89ac-aa4825254228


de-aggregation interoperability with official KPL

De-aggregation of KPL UserRecord ( https://github.com/awslabs/amazon-kinesis-producer/blob/master/aggregation-format.md ) is not supported, right?

Hi @ihorkhavkin thanks for the link. I haven't see that before. Is there a reason to use that over the PutRecords batch that Kinesis supports via API?
http://docs.aws.amazon.com/kinesis/latest/APIReference/API_PutRecords.html

I believe AWS still charges you based on 25KB PUT payload units and also there are limits on TPS ( http://docs.aws.amazon.com/kinesis/latest/dev/service-sizes-and-limits.html 1K TPS for PUT regardless of PutRecords batching)
So aggregation on KPL side helps when you have smaller records. And with some latency impact it can make Kinesis bound only by bandwidth (1 Mb/s per shard on write). So if you are not using aggregation, you may end up paying much more due to higher number of shards and number of PUTs.

http://brianoneill.blogspot.com/2015/09/kinesis-20x-cheaper-when-used-with.html more detailed write up about aggregation impact on Kinesis pricing when you have records significantly smaller than 25Kb

Thanks for the note about reduced pricing. For the time being I'd like to keep things simple and use string to string on and off the wire.


Added OSX SDL2_mixer dependency to README

Found that I needed to install SDL2_mixer to build with the latest code.
Updated README.md for OSX, but I presume will also need updating for Linux.  Can you do this? (I assume you know what package is needed).

@johnbatty yep !


chef-client::cron overwrites log each run

See cron.rb:96. Would be nice if cron appended to the log, to mimic the behavior of daemon mode.

Fixing in #261


Fix link to documentation in readme

I think the link is currently pointing to the wrong project :-)

Thank you @tuxpeople 👍🏼


Add in functionality to limit the number of ips being pinged when scanning.

When using network.scan() to scan a subnet, it is noticed that without modifying the code, ping_and_get_miner will eventually result in a [Errno 24] Too many open files on linux and result in some miner IPs being missed by the scan. I know I can change the ulimit, but it would also be nice to have the control of setting a cap for the number of ping_and_get_miner calls to be executed concurrently.
I thought this may be the reason for the network_scan_threads setting but I don't see that used anywhere while examining the code.
Additional context
This was a problem I encountered when scanning on Ubuntu.

Yeah, that setting was sort of removed when I refactored the way the network works.  Shouldn't be too hard to add back.

Added back in with 0.55.3.  By default the value is None, which will not bound the scan, but now you can set a value with pyasic.settings.update("network_scan_semaphore", 1000)

Thanks!


Feature to rename image files in the web interface

I've found myself frequently wanting to rename image files, and it would be convenient to have this feature in the web interface.

Code in https://github.com/akuker/RASCSI/pull/521


Added preliminary crater code by Melosh 2016

This code calculates the diameter of a crater as a result of an impact between two bodies of a certain size and density.

works (compiles + tests) here..think it can be merged whenever you are ok with the interface..I am not sure what kind of high level interface is appropriate here (maybe something with "crater" particles)

@spzwart you probably want to commit the galaxia fix directly to amuse master...I have cherry picked the commit on master...

What's the status of this? Does it need more work or is it ok to merge @spzwart?

can merge?

@spzwart we would like to have confirmation that this code is ready and worthy to merge..

reopen if necessary


Where and how to configure and launch ceph-ansible

Now ceph-ansible is configured on qe_server, which expects to have qe_server in inventory file this way:
[qe_server]
localhost ansible_connection=local ansible_user=jenkins

This needs to be changed, and qe_server should not be listed in inventory file for particular cluster.

@mbukatov, @mkudlej

One possibility might be, to add qe_server dynamically to the inventory (http://docs.ansible.com/ansible/add_host_module.html)

As long as we are using ceph-ansible.yml playbook in a local way, I would rather add hosts: localhost and connection: local into the play directly, instead of referring to usmqe host which will be always localhost in this case anyway.

I think that solution mentioned by @mbukatov is OK.


EnderIO-1.10.2-3.1.188 breaks capacitors sides display options

Issue Description:
EnderIO-1.10.2-3.1.188 breaks capacitors sides display options
What happens:
Display options for capacitor sides are broken in 188
What you expected to happen:
Not broken display options
Steps to reproduce:
Place a capacitor. Shift right click to cycle display options.

Affected Versions (Do not use "latest"):

EnderIO: 1.10.2-3.1.188
EnderCore:EnderCore-1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge:<IP_ADDRESS>1

Your most recent log file where the issue was present:
https://paste.ee/p/uiclW
Pics:

Notice the charge bar indicator not working.

And before fixing this, you may want to check out https://github.com/SleepyTrousers/EnderIO/issues/4167
But not just glance over it. You have to actually read it to understand that the feature does not "already exist", and its actually a cool feature request.


Update review builds

See this https://github.com/NVIDIA/k8s-device-plugin/blob/main/.github/workflows/image.yaml#L44 , you need to use nvidia instead of NVIDIA for the image name

Agreed.  I snooped the DRA repo.


Add button to show auto-tags in alphabetical order

Seems useful 🤔 - thanks to @okumam for the suggestion

Hi @whyboris. May I work on this issue?

Hi @whyboris! Can I work on this issue?

Thank you for the offer! Please let me know if you need a hand with anything.
There should be a button in the settings that, when toggled, would sort the auto-tags (the blue ones, generated automatically from file name) in alphabetical order. But if not toggled, should continue displaying the tags the way they are.
So, for example Best_amazing_cool.mp4 would show up as

best amazing cool by default
amazing best cool when the button is toggled

The button doesn't need any icon - it doesn't have to appear in the ribbon 👌
I'll be happy to help out with any step of the way 🤝  (just let me know whether you'd like more-generic or more-specific suggestions) 😁

I will be happy to help test this when you guys have a version that implements it.  I suppose it is simple enough not to require much testing, but I am happy to make the offer anyway.

Hello @whyboris! I see that this issue is still open. Can i work on it?

Hello @gabriel-kazimir - thank you for offering to help with this issue. Please reach out with any questions as you work on it 🤝
I'm sometimes picky about the UI (user interface) and might end up nudging around the button that you'll add in your code: take no offense and also don't worry about spending a lot of time making it look pretty, I can handle that piece from whatever state you leave it in 😊


Icon is applied to folders

This happens when the folder ends with a supported extension.
For example jquery.rut.js

That's not the JS icon being used by the package. Are you applying a custom icon in your user stylesheet?
If so, you'll need to include .icon-file-text in your CSS selector. So it'd be something like this:
.icon-file-text[data-name$=".js"] {
	code-goes: here;
}

In either case, I can't reproduce this error on my end: naming a folder jquery.rut.js is showing the standard directory icon.

i am sorry, I got confused of repository

Está bien! =)


vkcube: Reorder setting of pipeline stage flags

Pipeline stage flags should be set before assigned to pWaitDstStageMask
in VkSubmitInfo, otherwise the assigned pointer is invalid.

Author hikiko not on autobuild list. Waiting for curator authorization before starting CI build.

Author hikiko not on autobuild list. Waiting for curator authorization before starting CI build.

CI Vulkan-Tools build queued with queue ID 46427.

CI Vulkan-Tools build # 534 running.

CI Vulkan-Tools build # 534 passed.


Crash during server shutdown

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
With the following libs. installed, any PyDPF script after being executed, throws the following error:

/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/server_types.py:1141: UserWarning: Traceback (most recent call last):
  File "/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/server_types.py", line 1129, in shutdown
    self._shutdown_func[0](self._shutdown_func[1])
TypeError: 'NoneType' object is not callable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/server_types.py", line 1132, in shutdown
    if self.meet_version("4.0"):
  File "/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/server_types.py", line 537, in meet_version
    return server_meet_version(required_version, self)
  File "/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/check_version.py", line 29, in server_meet_version
    return meets_version(version, required_version)
  File "/usr/local/opensoftware/python/3.10.9/lib/python3.10/site-packages/ansys/dpf/core/check_version.py", line 82, in meets_version
    from packaging.version import parse
ImportError: sys.meta_path is None, Python is likely shutting down

Steps To Reproduce
..
Which Operating System are you using?
Linux
Which Ansys version are you using?
Ansys 2022 R1
Which Python version are you using?
3.10
Installed packages
...

Hi @ayush-kumar-423, would it be possible to have to whole list of installed packages? With pip list.
This is most likely an incompatibility issue.

Hi @PProfizi, I have updated the packages list in the description. I have asked customer if it is possible to test with 23R1.


[ MB-16421 ] Adding DOSFSC pricer

Jira ticket
Summary

[x] Adding interface and mocks for DOSFSC
[x] Adding in the service for DOSFSC;
[x] Adding DOSFSC to MTO service item updater

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the Office app
Create a testharness HHGMoveInSITEndsYesterday move
Login as the prime
Create a payment request for Domestic Destination SIT FSC

Messages

:book:
:link: MB-16421

  Generated by :no_entry_sign: dangerJS against d961ee755974d738a4ea48657b5b11fd9b60b235

Test coverage on server failed.
Last run: Tue 25 Jul 2023 08:23:16 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Test coverage on client failed.
Last run: Thu 27 Jul 2023 02:20:53 AM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Alrighty, this should now be working. It was verified by @mlm55 that it worked and then I went ahead and fixed the tests to get it the CI passing and addressed any merge conflicts from the default branch.


Improved secret management

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/21
Originally created by @joshlambert on 2018-06-05 22:01:41

We have locked down access to the protected secrets, which prevents users from having direct access to them. However we still make them available for review apps, which means any developer can alter the .gitlab-ci.yml, print the secrets, and then view the build log to retrieve them. This means that any user with developer rights has access to all of the secrets for all of the data sources, which is a concern especially as we move into more sensitive data sources.
Some possible solutions:

Test harness (https://gitlab.com/meltano/meltano/issues/86): Utilize something like vcr to provide an automated API mock for review branches. This way the real secrets could only be available on protected branches, and we'd also not consume API quotas on review branches.
Some type of forward proxy, which held the secrets and performs the authentication. This seems unrealistic, I'm not sure if something like this even exists.

Something like a KMS won't really help address these isues, because of the review app problem noted above, but could help to further secure the secrets themselves.

View 5 previous comments from the original issue on GitLab


Coffeescript integration

Ola!
Are there any plans on integrating --coffee option into this generator, similar to generator-angular ?
Lewis

Hi @LunarDevelopment, unfortunately no. Sorry. There might be in the future, but for now, not at all. But even then, in the farther away future, the next big changes will be ES6 Syntax and possibly Angular 2.0.

Cool, Thanks for the info!


Support for Python 3.12

Description
Python 3.12 was release last year in Oct 2023. We need to add support to Python 3.12

Hey @jamie256, can you reopen this issue? Thanks

This is related to whylogs-sketching library, assigning to Richard to help test out the python 3.12

This is related to whylogs-sketching library, assigning to Richard to help test out the python 3.12

Successfully tested sketching with whylogs on Linux and OSX, AMD64 and ARM64. whylogs itself may need some fiddling with dependency versions to work with Python 3.12.


Allow Ruby failure on CI

Ruby has still the old configuration options into the SwaggerToSdk conf file here:
https://github.com/Azure/azure-sdk-for-ruby/blob/master/swagger_to_sdk_config.json
This is highly deprecated, and this is not how @sarangan12 generates the Ruby packages right now. This makes the CI testing of Ruby generation highly unstable, and misleading. Example:
https://github.com/Azure/azure-rest-api-specs/pull/2617
I recommend allowing failure of Ruby CI, until @sarangan12 has the time to catch-up the new Readme syntax and we can trust this build again.
FYI @mcardosos

Automation for azure-sdk-for-go

Automation for azure-libraries-for-java

Automation for azure-sdk-for-python

:D Thanks @lmazuel  :D


There is no warning message when file is over 5MB for Profile Photo

When choosing a supported profile photo type but size is over 5MB, there is no warning message or anything alike.
Steps:

Sign in and click Profile - My Profile on the right top corner
Hover over the camera icon and click when it turns to a hand pointer
Choose a file of supported type (e.g., .jpeg) but size over 5MB and click Open/Choose(depends on the OS)

Expected Result: A warning message telling User that file cannot be over 5MB (or something alike)
Actual Result: The window just get dismissed without anything
Reproducible environment - MacOS - Chrome, Windows 10 - Chrome
Not reproducible environment - MacOS + Safari

In addition to this issue, the user is not able to remove profile picture/photo
Steps to reproduce:
    1.Sign in and Select Profile - My Profile
    2.click on camera icon and choose a supported file  which you wanted to upload and click on open
    3.Click on submit

Once the profile picture is uploaded the user is able to change the picture but not remove the picture.
As a user if I wish to remove my picture I should be able to remove it , not only change the picture.

I'm pretty this is resolved as part of #1548 PR - now in staging soon in prod. If mistaken please reopen (screenshot & file size would help).


add reddit logo

Be a participant and active contributor in the community, this can be contributing code, issues or sponsoring EnvoyCon
-- https://github.com/envoyproxy/envoy/pulls?q=is%3Apr+is%3Aclosed+author%3Adavinci26

Publicly disclose your usage of Envoy
-- https://www.redditinc.com/blog/envoy-proxy-at-reddit

I resized and adjusted the color of the SVG. Let me know if it would be better to just provide the original

cc @phlax

@marcoferrer the submitted image works fine for current purposes i think - altho im wondering if we should keep originals somewhere in case we ever change the theme/design


salt: 3002.5 -> 3002.6

Motivation for this change
Salt 3002.6 was published: https://docs.saltproject.io/en/latest/topics/releases/3002.6.html
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117392 at 2ce3eff4 run on x86_64-linux 1

1 package marked as broken and skipped:

pepper

1 package built successfully:

salt

1 suggestion:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/admin/salt/default.nix:29:15:
   |
29 |   patches = [ ./fix-libcrypto-loading.patch ];
   |               ^


Custom templating in index.html

Feature Suggestion
Allow for custom templating in the index.html that is served by the app plugin.

Possible Implementation
We could pass the rest of app config because extraneous fields are not removed.

Context
I would like to be able to modify the index.html by conditionally adding certain script tags. Unfortunately, because of the limited variables passed to the HtmlWebpackPlugin, I am unable to do so.

Hi! Is this because you want the file to be different between environments? For example having some features in staging but not in production.

In my case it's different in dev than deployed which is why I proposed the solution I did. It would be better, in my opinion, to make the templating more robust so it's not done at build time but realize that's a bigger ask.

After further consideration, I think the more robust solution is better to allow different scripts to be included per environment. To accommodate this I would like to avoid setting these value at build time. If I opened a PR to allow for a templating engine (e.g. ejs) in the app-backend to generate the index.html file rather than using HtmlWebpackPlugin, would that be considered?

A possible way forward here is to power up the app-backend plugin a bit and let it template the index file. That's be the most straightforward place and perhaps least hacky as well. It really wouldn't need any file rewrites or anything either, just a custom handler.
Other options if you want to do this in the deployment end are scripts similar to https://github.com/backstage/backstage/blob/557faeb7e1d1480ae6618ee4068079fec98fb85f/contrib/docker/frontend-with-nginx/docker/inject-config.sh#L5 or perhaps some other flavors of dynamic web servers.

You could likely use something like https://www.npmjs.com/package/express-mung in the app-backend to help do this.


Files with special characters do not hash

Nat.asmi.666
I didn't have the chance to change the database but i was able to find out what was causing the error.  it was the special non english characters like "ū" that was causing the issue. once i renamed without them it detected the files.

Fixed inanother issue


MSTestV2 VB Templates

@jayaranigarg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Just putting this on the radar too: We should make the change of hiding the old templates along with this change when we push in so we don't have two.

#132


Missing audio data for some videos

Hi, It appears that two video files in the Ego4D are missing audio data. These video files are named "0d271871-c8ba-4249-9434-d39ce0060e58" and "7d8b9b9f-7781-4357-a695-c88f7c7f7591".
My commands for downloading videos are as follows:
ego4d --output_directory="Ego4D/" --datasets full_scale --video_uids 0d271871-c8ba-4249-9434-d39ce0060e58 -y
ego4d --output_directory="Ego4D/" --datasets full_scale --video_uids 7d8b9b9f-7781-4357-a695-c88f7c7f7591 -y

I have tried downloading the corresponding videos for both v1 and v2, but they are indeed missing audio data.
If possible, could you please supply the correct versions of the video files with the audio, or inform us how we can obtain the accurate video data? This is crucial for our research and project.
Thank you very much for your assistance and understanding!

Some univeristies redacted their audio, and unfortunately this is one of the cases. Please read the ego4d.json file to determine which files have audio and which do not. See the fields here: https://ego4d-data.org/docs/data/metadata/
You should be able to reliably tell which videos have audio via the field audio_base_denominator, e.g. video["audio_base_denominator"] is not None


Fix false negatives for Style/ArgumentsForwarding

This PR fixes false negatives for Style/ArgumentsForwarding when using forwardable block arguments with Ruby 3.2+.
The anonymous block forwarding that worked up to Ruby 3.1 stopped functioning from Ruby 3.2+. This PR ensures consistent behavior even in Ruby 3.2+.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice!