Main Thread Checker Issue in XCode 9

The Xcode 9 main thread checker shows that Segment-Localytics is making a call to [UIApplication applicationState] on a background thread, which is not correct:
=================================================================
Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 385, TID: 23764, Thread name: (none), Queue name: io.segment.analytics, QoS: 0
Backtrace:
4   Localytics                          0x0000000102ff52c8 -[LLBaseLocalyticsManager integrate:] + 88
5   Localytics                          0x0000000103052c5c -[LLLocalyticsManager integrate:] + 56
6   Segment_Localytics                  0x0000000105231084 -[SEGLocalyticsIntegration initWithSettings:] + 316
7   Segment_Localytics                  0x0000000105232d00 -[SEGLocalyticsIntegrationFactory createWithSettings:forAnalytics:] + 140
8   Analytics                           0x0000000102b09dec __57-[SEGIntegrationsManager updateIntegrationsWithSettings:]_block_invoke + 584
9   Analytics                           0x0000000102b00cec __seg_dispatch_specific_block_invoke + 80
10  Analytics                           0x0000000102b00c00 seg_dispatch_specific + 256
11  Analytics                           0x0000000102b00e90 seg_dispatch_specific_sync + 116
12  Analytics                           0x0000000102b09b5c -[SEGIntegrationsManager updateIntegrationsWithSettings:] + 208
13  Analytics                           0x0000000102b09a54 -[SEGIntegrationsManager setCachedSettings:] + 380
14  Analytics                           0x0000000102b0a5c8 __41-[SEGIntegrationsManager refreshSettings]_block_invoke_3 + 140
15  Analytics                           0x0000000102b00cec __seg_dispatch_specific_block_invoke + 80
16  libdispatch.dylib                   0x0000000105e0d69c _dispatch_call_block_and_release + 24
17  libdispatch.dylib                   0x0000000105e0d65c _dispatch_client_callout + 16
18  libdispatch.dylib                   0x0000000105e1c2dc _dispatch_queue_serial_drain + 692
19  libdispatch.dylib                   0x0000000105e10bf0 _dispatch_queue_invoke + 332
20  libdispatch.dylib                   0x0000000105e1d2b8 _dispatch_root_queue_drain_deferred_wlh + 424
21  libdispatch.dylib                   0x0000000105e24268 _dispatch_workloop_worker_thread + 652
22  libsystem_pthread.dylib             0x0000000186993fcc _pthread_wqthread + 932
23  libsystem_pthread.dylib             0x0000000186993c1c start_wqthread + 4
2017-08-11 09:24:38.986358-0400 SPApp_IOS[385:23764] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 385, TID: 23764, Thread name: (none), Queue name: io.segment.analytics, QoS: 0
Backtrace:
4   Localytics                          0x0000000102ff52c8 -[LLBaseLocalyticsManager integrate:] + 88
5   Localytics                          0x0000000103052c5c -[LLLocalyticsManager integrate:] + 56
6   Segment_Localytics                  0x0000000105231084 -[SEGLocalyticsIntegration initWithSettings:] + 316
7   Segment_Localytics                  0x0000000105232d00 -[SEGLocalyticsIntegrationFactory createWithSettings:forAnalytics:] + 140
8   Analytics                           0x0000000102b09dec __57-[SEGIntegrationsManager updateIntegrationsWithSettings:]_block_invoke + 584
9   Analytics                           0x0000000102b00cec __seg_dispatch_specific_block_invoke + 80
10  Analytics                           0x0000000102b00c00 seg_dispatch_specific + 256
11  Analytics                           0x0000000102b00e90 seg_dispatch_specific_sync + 116
12  Analytics                           0x0000000102b09b5c -[SEGIntegrationsManager updateIntegrationsWithSettings:] + 208
13  Analytics                           0x0000000102b09a54 -[SEGIntegrationsManager setCachedSettings:] + 380
14  Analytics                           0x0000000102b0a5c8 __41-[SEGIntegrationsManager refreshSettings]_block_invoke_3 + 140
15  Analytics                           0x0000000102b00cec __seg_dispatch_specific_block_invoke + 80
16  libdispatch.dylib                   0x0000000105e0d69c _dispatch_call_block_and_release + 24
17  libdispatch.dylib                   0x0000000105e0d65c _dispatch_client_callout + 16
18  libdispatch.dylib                   0x0000000105e1c2dc _dispatch_queue_serial_drain + 692
19  libdispatch.dylib                   0x0000000105e10bf0 _dispatch_queue_invoke + 332
20  libdispatch.dylib                   0x0000000105e1d2b8 _dispatch_root_queue_drain_deferred_wlh + 424
21  libdispatch.dylib                   0x0000000105e24268 _dispatch_workloop_worker_thread + 652
22  libsystem_pthread.dylib             0x0000000186993fcc _pthread_wqthread + 932
23  libsystem_pthread.dylib             0x0000000186993c1c start_wqthread + 4

Having the same problem, any updates about this ?

Hi @TihomirBorcic and @moshi-kibu
Sorry for the delay on this. I'm opening a ticket to track this internally. I don't have an ETA at the moment, but will keep you updated here as soon as I have more.
Thanks for your patience here

@ladanazita My pull request #25 fixes this issue with warnings.
Could you review it, please?

@divbyzero  Sorry for the delay, I am looking at this now

Hey @divbyzero @TihomirBorcic this update is live on 1.4.0

🎉  Congrats
🚀  Segment-Localytics (1.4.0) successfully published
📅  March 15th, 16:14
🌎  https://cocoapods.org/pods/Segment-Localytics
👍  Tell your friends!
Thank you for your patience!

@ladanazita
Yep, it works fine for integration. But the same problem with thread for tracking:
Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState] PID: 4310, TID: 3029280, Thread name: (none), Queue name: io.segment.analytics, QoS: 0 Backtrace: 4   Segment_Localytics                  0x00000001069a0c60 -[SEGLocalyticsIntegration track:] + 88 5   CoreFoundation                      0x0000000183291670 <redacted> + 144
I think need to add a wrapper for track method too.

@divbyzero can you provide the full stack trace? And actions took so I can try to reproduce locally? Thanks!

@ladanazita I've used code like this:
SEGAnalytics.shared().track("blabla", properties: ["date": "2018-03-16"], options: nil)
Backtrace:
2018-03-16 20:21:52.769829+0200 DEMO[4369:3126029] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 4369, TID: 3126029, Thread name: (none), Queue name: io.segment.analytics, QoS: 0
Backtrace:
4   Segment_Localytics                  0x00000001041f8c60 -[SEGLocalyticsIntegration track:] + 88
5   CoreFoundation                      0x0000000183291670 <redacted> + 144
6   CoreFoundation                      0x00000001831706cc <redacted> + 292
7   CoreFoundation                      0x000000018317516c <redacted> + 60
8   Analytics                           0x0000000103726394 -[SEGIntegrationsManager invokeIntegration:key:selector:arguments:options:] + 564
9   Analytics                           0x00000001037260ec __60-[SEGIntegrationsManager forwardSelector:arguments:options:]_block_invoke + 64
10  CoreFoundation                      0x0000000183158520 <redacted> + 232
11  Analytics                           0x0000000103726064 -[SEGIntegrationsManager forwardSelector:arguments:options:] + 204
12  Analytics                           0x000000010372080c __seg_dispatch_specific_block_invoke + 36
13  libdispatch.dylib                   0x0000000104e7d49c _dispatch_call_block_and_release + 24
14  libdispatch.dylib                   0x0000000104e7d45c _dispatch_client_callout + 16
15  libdispatch.dylib                   0x0000000104e8c110 _dispatch_queue_serial_drain + 692
16  libdispatch.dylib                   0x0000000104e809a4 _dispatch_queue_invoke + 332
17  libdispatch.dylib                   0x0000000104e8d104 _dispatch_root_queue_drain_deferred_wlh + 424
18  libdispatch.dylib                   0x0000000104e94100 _dispatch_workloop_worker_thread + 652
19  libsystem_pthread.dylib             0x0000000182eb2fd0 _pthread_wqthread + 932
20  libsystem_pthread.dylib             0x0000000182eb2c20 start_wqthread + 4

@divbyzero  great! Thanks for this — I'm going to evaluate and see if all Localytics methods need to be dispatched to the main thread and will push up another fix for this.


Integration Test - Release - 2019/02/26 21:56:39

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

#Backlog

@PRMergerTest3 - This issue has been in the backlog for 80 days. In 10 days, it will be automatically closed.
For more information about the process by which we handle documentation feedback, see "How we respond to Azure technical documentation feedback" in our public contributor guide.

The feedback you logged for Integration Test - Release - 2019/02/26 21:56:39 has been in our backlog for 90 days. While we try to respond individually to as many feedback items as possible, we are not able to respond to all of them. Since this item has been in the backlog for 90 days, we’re closing it.
For more information about the process by which we handle documentation feedback, see "How we respond to Azure technical documentation feedback" in our public contributor guide.


Distributed Caching for Laravel portal

A way to keep cache synced across all instances of the portal which are up and running.
Probably implementing this with Memcache

Php 5 memcached required to be installed. And then 'app/config/cache.php' needs to be updated with this config.

To address the problem of distributed caching with at least two app servers running - containerized version of laravel on apache2 is tried using modification over external docker resource (from user eboraas). This currently running at ec2-52-14-33-15.
Challenge: Caching configuration is not picked up when running laravel inside docker.
TODO: Continue on investigating the blocker. Give 3 more days on building docker image file to run memcache on laravel inside the docker container.


Attach an EventListener for when a GPT slot is defined (created) or destroyed

Is your feature request related to a problem? Please describe.
As a developer at Massarius, we monetize invenotry from publishers. Some publishers have desires to manage and maintain their own GPT slots. The result is that we create a fallback mechanism to fill in unsold inventory. Some publishers have peculiar procedures of defining GPT slots. Some are created lazy-loaded. Others are created with a single Google Ad Manager AdUnit and use key value targeting in order to specify which ad inventory is meant to serve. A key feature i am missing from googletag is an EventListener for when the publisher defines their GPT slots and when they destroy them. As we are monetizing their unsold GPT slos we are creating variables and store all kinds of information. Some publishers have infinite scroll article pages, some publishers have single page applications. An EventListsner to attach when the publisher had destoryed their GPT slot comes in very handly in order to clean up our own stored data. I'd like to prevent memory leaks as much as possible and clean up data.
Describe the solution you'd like
Can you please create a feature in googletag to attach an EventListener to the pubads service that triggers when a slot is defined and destroyed. Something like the following (adjusted to your standards naming conventions):

googletag.pubads().addEventListener("slotDefined", (event) =>console.log("A GPT slot has been defined",event.slot.getAdUnitPath()));
googletag.pubads().addEventListener("slotDestroyed", (event) =>console.log("A GPT slot has been destroyed",event.slot.getAdUnitPath()));

Describe alternatives you've considered
The alternative is to override googletag.defineSlot and make it act like an EventListener. Although i did try this out already and it caused major lagging issues, so it's not an alternative.
Additional context

Hi @BerendKemper, thanks for the feedback! Unfortunately this isn't the right support channel for product feature requests. While I will pass your request along to the team, I won't be able to provide any updates here.
If you have an Ad Manager support contact, I recommend reaching out to them about this as well. They will be best equipped to handle this sort of request and keep you updated as things progress.


MTDSA-14844: deleted raml related docs and references

Can you remove the example.html from api/conf/1.0 folder.


[BUG]  Distributed cache not being checked for key for unknown reason

Describe the bug
I have FusionCache setup with Redis and backplane, all seems to be working ok on the surface, can see the keys being added to Redis and used (on occasion) however on closer inspection (while investigating cold start behaviour I noticed unexpected behaviour.
After cold start some keys are looked up in the distributed cache and collected while others are not.
To Reproduce
var cacheEntry = await _cache.GetOrSetAsync("User:UserViewModel:1_40181", async _ => await BuildUserModelFromContext(), options => options.SetDuration(TimeSpan.FromMinutes(5)));

var search = await _cache.GetOrSetAsync("User:Search:MainSearchResult:1_40181", async _ => {... code... return data;}, options => options.SetDuration(TimeSpan.FromMinutes(5)));

There are 2 uses of the cache using same options called shortly after one another but they behave differently
2022-08-17 15:57:38.8322|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): calling GetOrSetAsync<T> FEO[LKTO=/ DUR=5m DDUR=/ JIT=2s PR=L FS=Y FSMAX=02:00:00 FSTHR=30s FSTO=100ms FHTO=2s TOFC=Y DSTO=1s D
HTO=2s ABDO=Y BN=Y BBO=Y]
2022-08-17 15:57:38.8322|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): memory entry not found
2022-08-17 15:57:38.8322|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): memory entry not found
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): distributed entry found FE[FFS=N LEXP=33s]
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): saving entry in memory MEO[CEXP=2022-08-17T16:57:39.7442166+00:00 PR=L S=1] FE[FFS=N LEXP=34s]
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=aca34cf0429f4dd4a9bedfbbf5755552 K=User:UserViewModel:1_40181): return FE[FFS=N LEXP=34s]
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=0d112accd53c4b0ea88eb15c08e59dc2 K=User:Search:MainSearchResult:1_40181): calling GetOrSetAsync<T> FEO[LKTO=/ DUR=5m DDUR=/ JIT=2s PR=L FS=Y FSMAX=02:00:00 FSTHR=30s FSTO=100ms FHTO=2s TOFC=
Y DSTO=1s DHTO=2s ABDO=Y BN=Y BBO=Y]
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=0d112accd53c4b0ea88eb15c08e59dc2 K=User:Search:MainSearchResult:1_40181): memory entry not found
2022-08-17 15:57:38.8667|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=0d112accd53c4b0ea88eb15c08e59dc2 K=User:Search:MainSearchResult:1_40181): memory entry not found
2022-08-17 15:57:38.9551|DEBUG|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=0d112accd53c4b0ea88eb15c08e59dc2 K=User:Search:MainSearchResult:1_40181): calling the factory (timeout=2s)
2022-08-17 15:57:38.9551|DEBUG|Microsoft.EntityFrameworkCore.Query|Compiling query expression:
'DbSet<usp_GetCatalogueSummaryListResult>().FromSql(EXEC [Products].[usp_GetCatalogueSummaryList] @FormatId, __p_0)
...

Why does User:UserViewModel:1_40181 look in distributed cache (and find it and use it) but User:Search:MainSearchResult:1_40181 does not, I can see it is in the Redis database and has not expired.
Expected behavior
For User:Search:MainSearchResult:1_40181 to be checked in distributed cache, found and used.
Versions
I've encountered this issue on:

FusionCache version 0.13
.NET version 6
OS version Windows 11

Add any other context about the problem here.

Ok think im onto the problem
2022-08-17 16:22:41.9795|TRACE|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=b4d32acbfc57431787cde55cdfff4aa0 K=User:Search:MainSearchResult:1_40181): trying to get entry from distributed
2022-08-17 16:22:42.0515|TRACE|ZiggyCreatures.Caching.Fusion.FusionCache|FUSION (O=b4d32acbfc57431787cde55cdfff4aa0 K=User:Search:MainSearchResult:1_40181): an error occurred while deserializing an entry System.InvalidOperationException: Each parameter in the deserializatio
n constructor on type 'Api.Services.FuzzyTrieSearch`1[System.Collections.Generic.KeyValuePair`2[System.String,System.Int32[]]]' must bind to an object property or field on deserialization. Each parameter name must match with a property or field on the object. The match can
be case-insensitive.

If I enable trace then the problem is revealed. Maybe make errors like this more visible, seems it should be logged as an error not a Trace?

Hi @UtopiaAbsoluteDeveloper and thanks for using FusionCache!
The type of logging statement to use for serialization is already Error by default as you expected (see here) and it is correctly used it the related code: see here for the sync version and here for the async version.
You can change it though via the SerializationErrorsLogLevel option in the FusionCacheOptions object (see here): maybe you (or a member of your team) have set it to something else?
If that's not the case let me know and I will gladly look more closely into it.

Ahh! Sorry I misunderstood the meaning of
 options.SerializationErrorsLogLevel = LogLevel.Trace;
which I have set, I thought it set a min level to output not actually setting the level of the event.
All clear now thanks for clearing it up!

Btw: I think I'll add a doc page specific to logging, with the intended approach, the options available, etc so it may be of help.
When it'll be ready I'll ask you to check it out, if youd' like.

Yea thanks for that discussion, I will put the Error Levels back to their defaults and use the Ilogger config to filter the various outputs as described. Yes would be more than happy to take a look when its done!
Really liking the library thanks for building it!

Hi @UtopiaAbsoluteDeveloper , I've created the Logging docs here: if you have time let me know what you think.
Thanks!


Markdown versions 3.4.0 and 3.4.1 break documentation build

Describe the issue
Markdown released a new version that caused our doc builds to fail both locally and in the CI with:
Extension error (sphinx_markdown_tables):
Handler <function process_tables at 0x7fdd2d294790> for event 'source-read' threw an exception (exception: __init__() missing 1 required positional argument: 'config')

See here for more: https://github.com/elyra-ai/elyra/runs/7362961491?check_suite_focus=true.
Note that Markdown==3.4.1 does not solve this issue. #2836 caps Markdown to v<3.4, but this is a temporary solution.
One potential solution is to remove the doc dependency on sphinx-markdown-tables. When testing locally with sphinx-markdown-tables uninstalled, tables appear to still be rendered correctly for some whereas others see something like the below. Further investigation needs to be done to determine the reason for this and whether this could provide an eventual solution.

Much to my surprise, version 0.0.16 of sphinx-markdown-tables was released yesterday and works with Markdown >= 3.4.1.  PR forthcoming to adjust min versions.  We can talk about moving to myst-parser another time.


Referral Schedule - Staleness Chips Logic

#1932 - Fixed the issue where any out of date (Red) chip says needs status instead of the last status date.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@fa0911d). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1946   +/-   ##
==========================================
  Coverage           ?   76.04%
==========================================
  Files              ?      283
  Lines              ?     9197
  Branches           ?        0
==========================================
  Hits               ?     6994
  Misses             ?     2203
  Partials           ?        0

Flag
Coverage Δ

epictrack-api
76.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hide No Thanks Button

I want to know if it is possible to hide the "No Thanks" button in the dialog since tapping this button will hide the review dialog forever.

Why don't you check it by yourself ?

Why don't you check it by yourself ?

Sorry, correct me if I misunderstand your response. Do you mean there is already a method to do that?

Yes. Just use the actionsBuilder parameter (and return for example [RateMyAppRateButton(rateMyApp), RateMyAppLaterButton(rateMyApp)] with rateMyApp being your RateMyApp instance).

Yes. Just use the actionsBuilder parameter (and return for example [RateMyAppRateButton(rateMyApp), RateMyAppLaterButton(rateMyApp)] with rateMyApp being your RateMyApp instance).

 Thank you, I will try that :)

Thank you so much for your response, and sorry for asking such a stupid question.

 Tell me back if it has worked :wink:


Add webp to Nginx configuration

Currently, in EasyEngine site-specific Nginx configs, we cache static files but we do not provision webp files.
location ~* \.(ogg|ogv|svg|svgz|eot|otf|woff|woff2|mp4|ttf|rss|atom|jpg|jpeg|gif|png|ico|zip|tgz|gz|rar|bz2|doc|xls|exe|ppt|tar|mid|midi|wav|bmp|rtf|swf)$ {...

Since, webp is increasingly becoming the de facto standard of next gen image formats, it might be a good idea to add support for it.

Agreed. Please add webp support to EE/Nginx

https://github.com/EasyEngine/dockerfiles/pull/149
https://github.com/EasyEngine/site-type-wp/pull/219
https://github.com/EasyEngine/site-command/pull/425

this will be a nice to have feature, although if you are using cdn like cloudflare it should be handled by default.


[Tutorial 2] Delete Address

Delete the address field and its related uses and test cases, as instructed in the tutorial Step 2.

Closing this, since it is part of the tutorial. Will not be merging unless we decide to drop address.


Recaptcha audio not working in IE11

Not able to play audio in IE11 getting SCRIPT5022: InvalidStateError
Filename: recapcha_en.js Line 285 column 165

Does not seem to be relted to this package.

Is it working for you


[cli] fix error message and remove hard-coded services for outputs

to: @jacknagz
cc: @airbnb/streamalert-maintainers
size: small
Background
Someone in Slack sent a screenshot of a poorly formatted exception message. This should be the last Exception in our current code that handles formatting incorrectly. Reviewers should look out for improper formatting in the future.
Changes

Using str.format() for custom exception message during instantiation instead of the invalid ('%s', arg) syntax that should only be used for logging (not exceptions).
Removing hard-coded alerting outputs from the CLI and loading them straight for the StreamAlertOutput class. Now when new outputs are implemented, they do not need to be updated here.

Coverage remained the same at 96.445% when pulling 604a21cd6d3aefc7d4368f29e08b118c1990d5a4 on ryandeivert-fix-error-message into 344f158e4eb58f3c01e9b66997174e5c4ac1b677 on master.


Apply dark theme to stream color selector

[ ] The stream color selector widget in Stream settings > Personal tab does not have dark theme applied to it. We should fix this.

[ ] Also, while we're here we should rename and restyle the buttons to "Cancel" and "Confirm", as elsewhere in the UI. https://zulip.com/help/change-the-color-of-a-stream should be updated accordingly when we do this.

[ ] The stream color picker accessed from the left sidebar looks fine in dark mode, and can be used as a reference. However, the "Confirm" button should be restyled as above.

@zulipbot claim

https://zulip.com/help/change-the-color-of-a-stream should be updated accordingly when we do this
@alya I didn't find anything to update in this docs, can you point out the changes?

And PR #21484 is ready for a review.

This will be incorrect:

Click Choose to save and apply the color change.

Closing in favor of #26637 / #14961.


Last argument expansion works for arrow functions that return JSX

Fixes #195
Fixes #130

I added a second commit on-top that fixes #130. It makes sure that not only JSXElement but also objects and arrays do not add another level of indentation.

Awesome! There might be a way to make this code simpler. Until then, this works.


rpcserver: incorrect payment error message when user does not have enough funds

fixes #1680
This PR addresses an incorrect payment error message as described in #1680.
This should return "not enough funds" as an error message when a user attempts to complete a payment request without sufficient funds in their balance.

@ccdle12 Thanks for the PR, I have a question about it.
The user has 3 open channels, each channel with 100 SATs on the user side, AND the user wants to send a payment of 150 SATs, what should do LND?
I don't know much go at the moment, but think I see that the function checks the whole wallet balance, in this case is 300 (>150) and try to send the payment, Is that correct? LND takes from each channel all SATs that needs to send or fail?

@grunch atm, it can't do anything in that scenario, it must fail the payment. In the future, it can leverage AMP to use all three channels to send a partial payment that can only be atomically pulled by the receiver once all partial payments arrive.

@grunch
Thanks for the comment, I'm still getting familiar with the codebase and I actually I think I may have slightly misunderstood the original issue.
I'm checking the totalBalance and comparing it to the payment intent amount. It's failing the itest's which rightfully catches errors in payment behaviour.
If I'm understanding the issue correctly I should be looking at the users Channel Balance() and comparing it the payment intent or the local balance of the specific channel the user is trying to send a payment over and compare it to the payment intent
Any suggestions would be greatly appreciated

Hi @ccdle12 the main idea for me was to check the max local amount by channel to know exacly if you can send the money, but as @roasbeef commented here, your idea of checking with the whole user channel balance is going to work perfect when AMP is ready, and that's right, I support that idea, so LGTM :smile:

Appreciate the message @grunch, read a bit about AMP and sounds really cool.
I guess I'll leave this PR up but more than happy to close it off if needs be


Style: Align Essentials

Description of PR

fixed essential page in desktop and mobile view.

fixed alignment of pages (HOME, STATE, ESSENTIALS) in Desktop view. already fixed in new release. so, i remove my styling from code.

Type of PR

[x] Bugfix

Relevant Issues
Fixes #1340
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Light mode

fixed essential page in mobile view

Dark mode

mobile view

@jeremyphilemon done.

@jeremyphilemon i think new changes which i did wasn't get merged correctly. what to do?


[BUG] Applio doesn't create .pth file

Bug Description
After training my model, having successfully uploaded all audios for the dataset - I don't see any .pth file in the folder for my model under the logs folder like it's supposed to be.
Steps to Reproduce
Outline the steps to replicate the issue:

Go to 'Train'
Click on 'Start Training'
Wait until training is complete.
Observe the error.

Expected Behavior
For Applio to produce a proper .pth file of my voice model and the corresponding index for it.
Assets
Include screenshots or videos if they can illustrate the issue:

Desktop Details:
Windows 11 Home Single Language
Google Chrome
Additional Context
I have to use Fake GPU as my laptop apparently doesnt have one already.

whats your gpu

whats your gpu
My computer says it doesnt have one/doesn't detect one so I had to use the Fake GPU option.

whats your gpu

My computer says it doesnt have one/doesn't detect one so I had to use the Fake GPU option.

oh yeah, you can't train without a gpu, you should try a cloud service for training like google colab

Is it possible to add GPU support for Intel HD 730, 770, etc.? Many laptops, it would help to train on their device. Let it be slow, but the training can be stopped and then resumed.

whats your gpu

My computer says it doesnt have one/doesn't detect one so I had to use the Fake GPU option.

oh yeah, you can't train without a gpu, you should try a cloud service for training like google colab

The Google Colabs constantly disconnect then I have to reconnect, this is why I wanted to try Applio to train. It would be nice if there was a clear indication we can't train without GPUs, otherwise why does the "Fake GPU" option exist to unlock the training tab?

here you have info https://docs.applio.org/get-started/training/ - this option exists because you can train the index file, or do the preprocess/extraction, but not the training


feat(oauth impersonation): add create and delete endpoints

closes #1314

@gmlewis  - Just pushed the requested feedback. Thanks!

Thank you, @wesleimp!
Merging.


Extend application of defaults beyond FI_T tables

@siddharth-krishna any chance you could try this locally, e.g. on Ireland? I am surprised there is no difference.

Oh good catch! Looks like there's something wrong with the CI... I'll investigate!
       Benchmark    Time (s)       GDX Diff     Accuracy       Correct    Additional
----------------  ----------  -------------  -----------  ------------  ------------
   DemoS_001-all   4.5   4.8  --         --  100.0 100.0    121    121      3      3
   DemoS_002-all   5.1   5.0  --         --  100.0 100.0    347    347      3      3
   DemoS_003-all   5.4   5.5  --         --  100.0 100.0    639    639      3      3
       DemoS_004   5.5   5.9  --         --  100.0 100.0    674    674      3      3
      DemoS_004a   5.8   5.9  --         --  100.0 100.0    677    677      3      3
      DemoS_004b   5.6   5.7  --         --  100.0 100.0    677    677      3      3
   DemoS_004-all   5.7   5.4  --         --  100.0 100.0    679    679      3      3
   DemoS_005-all   6.5   5.7  --         --   99.7  99.7   1175   1175      6      6
   DemoS_006-all   7.1   7.3  --         --   99.7  99.7   1273   1273      6      6
   DemoS_007-all   7.6   7.8  --         --   99.8  99.8   2171   2171      6      6
DemoS_007-all-1r   6.8   7.0  --         --   99.8  99.8   1195   1195      3      3
   DemoS_008-all   9.6   9.3  --         --   99.9  99.9   5364   5364      6      6
   DemoS_009-all  10.2  10.1  --         --   99.9  99.9   5838   5838     32     32
   DemoS_010-all  10.4  10.6  --         --   88.4  88.4   6170   6170     32     32
   DemoS_011-all  10.3  10.0  --         --   88.1  88.1   6181   6181     32     32
   DemoS_012-all  10.5  10.5  --         --   88.2  88.2   6349   6349     32     32
         Ireland  23.7  20.5  --         --   92.3  92.9  37789  38013   3216   4935
Total runtime: 136.91s (main: 140.23s)
Change in runtime (negative == faster): -3.31s (-2.4%)
Change in correct rows (higher == better): +224 (+0.3%)
Change in additional rows: +1719 (+50.7%)
additional rows regressed on: Ireland

#250 should make it easy to reduce number of additional rows on Ireland.

Using DataModule functionality a lot of additional rows are now eliminated here @siddharth-krishna. :-)
The number of correct rows is reduced as well, which may be due to the order in which the records appear. I'll look into it to see whether to address it as a separate PR or directly here.
Btw, I suspect resolving #246 would have a profound impact on ACT_EFF for Ireland. ;-)

Great news, Olex, regarding DataModule 🚀
I pushed my quick fix for #246, which is to fix a precision of .8g when converting data & ground truth tables to string, prior to conversion. This removes all the additional rows in this PR!
(There are 2 missing rows from COM_PROJ in Demos 9-12 but perhaps that's what you were talking about w.r.t. order of rows?)
Do you have an idea of what a good precision is for outputting / comparing to ground truth?

Yei!! 🚀

Do you have an idea of what a good precision is for outputting / comparing to ground truth?

Not really... Maybe we could use a trial and error approach to set it as high as possible?

(There are 2 missing rows from COM_PROJ in Demos 9-12 but perhaps that's what you were talking about w.r.t. order of rows?)

Could be! I'll check it out.

@siddharth-krishna, somehow there seems to be a issue in the gdx comparison. Could you check?

Looks like #251 would push this over the line!

Looks like at least 4 additional records need #255 to be counted as correct. :-)

@siddharth-krishna, this is now ready for a review!


Publish new version

We are currently vendoring in e6c0cb441e2717d217a55380b1f8b514c43c7c77, which I don't think is the version published on NPM, but it's difficult to tell.
Would you mind tagging releases in the future, and also releasing a new version at e6c0cb441e2717d217a55380b1f8b514c43c7c77 if that's not what's already in v0.0.1?

I published a new 0.0.2 release on NPM and added a tag for it in the repo.

Thanks!


Write debug steps for docker failing to compile.

Did you restart the godot editor once
Is dlls unblocked on windows
??? Investigate docker images being out of date
Check the sandbox scripts manually and change a space to force recompile
The godot-sandbox dlls is behind the docker version

It used to be that when you changed Godot project, the already-started container wouldn't be pointed towards the new project, and it would just fail to compile .cpp files in the new project. But I fixed that by inspecting the path of the mounted volume on startup. So, unless something is wrong, the compilation step should Just Work now, even if the project changes.
It's also possible to build the project with verbose docker enabled, using the CMake project in the root. So, just build it locally on your machine and enable more verbose (or add verbose-ness as needed), and let me know where the issue was?

The Docker image can indeed be out of date. The running container needs to be shut down, removed (deleted), and only then can you let the pull and start a new one. I'm not sure what the right thing to do here is, since messing with peoples systems is not good engineering. It's just better if people can figure out basic container management on their own.

For me, the implementation of native compilation makes this not a problem.


Canary pipelines and entrypoints

There is something to think about here in that HD_BET has significant setup overhead, so we want to run all HD_BET tasks in one batch, and since each task is resource intensive we don't want (much) parallelism in those tasks.
The b0 tasks would parallelize very well with multiprocessing.Pool.
The b0 results are not used by anything other than the hd_bet task.

So with all that in mind, I decided to set the API as "create masks", generating b0 results as an implementation detail. Opt-in parallelism via multiprocessing.Pool is then an easy win, and HD_BET has its own runner.
I don't like that there's explicit control over b0 task parellism/overwrite, but HD_BET has its own controls for this. I don't think there's a great solution here since the HD_BET runner is slow to start and not very modular.
Translating these to Pydra is the next step, but I think we'll have the same issues there.

Another note: I'm considering each *_dwi.nii.gz to be a "case", and using the basename of this file as the name for the case. I preserve the structure of the input root in the output root, to address https://github.com/brain-microstructure-exploration-tools/abcd-noddi-tbss-experiments/blob/main/generate_b0_averages.py#L18-L19

(Note that getting a unique file like this wouldn't work in general on an ABCD download if someone extracted everything to the same target folder instead of creating one folder for each archive as I did.)

In theory one could set -i and -o to the same directory to work in-place, preserving directory structure.

Fighting CI on this has been... illuminating. So many linters and formatters and testing tools enabled by default!
I'm trying to focus the config on ruff; removing pylint and mypy since they are incompatible in some ways and just noisy in others (lots of complaints about click).

After discussion with JC it looks like I may have had some environment misconfigured on my end. I'll try reverting some of these changes and run with nox locally to figure out exactly what the issue with pylint was.

I too am overwhelmed by the amount of tools ... I was planning to chat with JC about it. I want this to be a "proper" python package so I used the scientific-python.org template... but IDK if all these things we need.
mypy is static typechecking right? I think we do want that. It's possible to disable it from certain packages I think, like click

The critical elements that were missing:

--ignore-missing-imports and additional_dependencies: click in mypy pre-commit config.
lint session.install('.') in noxfile.

Since mypy runs in pre-commit, it does not have access to the package dependencies. click is really the only one that needs to be type-checked, so I add it and ignore the rest (hd-bet)
Similarly, the noxfile did not install dependencies for pylint. Adding . does this so its checks are accurate.
You can run pylint locally via nox -r -s pylint, and run pre-commit locally via nox -r -s lint, or install pre-commit and use pre-commit install to register it with git pre-commit hooks.

I will remove pypy from the version compatibility check matrix; it looks like scipy is not compatible with pypy.

I plan to open an issue in the template repo for discussion about these configuration decisions (mypy and pylint). I'm unsure the purpose of pylint when ruff is available, and I'm confused why mypy is not run from an environment where it can easily check dependencies.

Rebased onto main after #9 and #10, and reverted changes to .copier-answers.yml from STYLE: Quiet pre-commit hooks

Closes #16

@ebrahimebrahim I'm not super pleased with the python function interface here - but I spent a bit too much time thinking about alternatives and think it's better to just keep the interface the same for now and change things in the future rather than abstracting early.
So I renamed the python-function interface to .masks.recursive_generate to be more descriptive of what it's doing. Ideally there would be some function that takes a list of files directly - but doing this requires creating some kind of "Case" abstraction, which quickly turns into a "Task" abstraction, which seems... premature.
I left the CLI entrypoint name unchanged, but moved it to .run.

@ebrahimebrahim I'm not super pleased with the python function interface here - but I spent a bit too much time thinking about alternatives and think it's better to just keep the interface the same for now and change things in the future rather than abstracting early.
So I renamed the python-function interface to .masks.recursive_generate to be more descriptive of what it's doing. Ideally there would be some function that takes a list of files directly - but doing this requires creating some kind of "Case" abstraction, which quickly turns into a "Task" abstraction, which seems... premature.
I left the CLI entrypoint name unchanged, but moved it to .run.

As discussed just now in our sync meeting, I agree that it makes more sense for the python API to just accept a list of tuples of files to process, rather than forcing the _dwi file naming scheme or recursively going over a directory. No abstractions need to be created yet -- just a list of tuples and a really good docstring explaining what the expected input is. Then the recursive search for files with a particular naming scheme can be moved to the command line interface side only.

At this point I think the interface to things is fine enough to move forward.
I spent some time trying to integrate click.progressbar - https://click.palletsprojects.com/en/8.1.x/api/#click.progressbar - it is trivial to add to the b0 step, but it seems near impossible to add to HD_BET without forking and editing the API there.
Since HD_BET is not on pypi, and is installed via git here, we could fork and install from our own repo, and/or open a PR to upstream.
The least effort to support a progress bar in HD_BET is to switch mri_fnames and output_fnames to be an iterable-of-tuples instead of a tuple-of-lists. This changes is trivial, but does break the API. See:
https://github.com/MIC-DKFZ/HD-BET/blob/master/HD_BET/run.py#L65-L77
And, to remove all the print() logging scattered throughout the package. Replace this with logging.* so the output may be filtered and, so long as there are no errors, wrapping the input iterable in a click.progressbar would be fine.

Thanks for all your effort on this! I will try to test and review quickly.
It's okay if there is no progress bar for the HD-BET step for now :smile:
TY for looking into that


Alternative to tooltip customClass deprecated

Hi, just updated my ng2bootstrap module and I am surprised that customClass is deprecated on tooltip...
Looking at the example provided, you have recently commented the part where customClass was applied. This is really important for me because we are showing a dt/dd inside the tooltip so we need it wider than 200px
There is some alternative?
Will it come back?
Thanks!

most probably as tooltip view config

I am updating and structuring docs, so I will get to this very soon

@sbengo please check Alert examples http://valor-software.com/ng2-bootstrap/#/alerts
global and component level styling
you need to overrid .tooltip-inner max-width param

should be something like
 styles: [`
  :host >>> ..tooltip-inner {
    max-width: 400px;
  }
 `]

It's not going to work with container="body" though, right ?

Not, sure yet. I will try

I have the same problem with deprecated tooltipClass. I use it with tooltipAppendToBody (now container="body") and I was able to overwrite .tooltip-inner class. Consider the following example:
.customClass {
    .tooltip-inner {
        text-align: left;
        white-space: pre-line;
        max-width: 500px;
    }
}

Now, after it's deprecated (along with tooltipHtml), I'm trying with TemplateRef:

<template #ref>

...some HTML...

</template>

but unfortunately this only results with:

  ...

Please note that I'm also using container="body" which is also mandatory for me.
Without parent selectors in CSS, not even in CSS3, it's not possible to get the same behaviour without tooltipClass. I can't find any workaround :/  Please add it back, for me it's very crucial to have it in ng2-bootstrap. Best regards!

Guys, does this post makes any sense for current situation?
https://perishablepress.com/awesome-new-css3-selectors/

@valorkin As the article stated only some limited, new browsers might support that. I could not even find info about it at caniuse.com. The sad reality is that some projects (like the one I'm working on currently) still need to support old browsers like IE11 (and so far ng2-bootstrap was working great)...  Waiting for CSS4 is not an option today :(

@valorkin @wojciechpolak The article is April fools joke.

Hi guys
Sorry  @valorkin , I was out of the office the last week so couldn't test it!
Overriding with an embed style clause is actually working but as @Agamnentzar said, it is not working in container=body case. Also there is no chance to play with different tooltip classes on the same component.
Sorry for the following question, I am so novice on angular2 but, there is no way to set it as an input and use again the ngClass statement, as it is commented on the code?
Thanks for all,
Regards!

I will be at work tomorrow, I will try to play with container=body, if no luck I will add custom class back

Thing is, there are a lot of popup components here , so if there are no other solution, all of them will be affected

Ok, I have tried global styling with popovers
I see an issue, so it will be added this week back
but in a bit different format
it will be added to popover\tooltip container component
so you will be able to style things properly via configuration or html prop

Hi @valorkin ... when you say: "it will be added this week back...but in a bit different format " ... will the NEW format still support tooltipClass and tooltipHtml?  Thanks

Can U please tell me what /* tslint:disable no-unused-css*/ means and what should I do (change tslint settings or...) I managed to change popover width only in css file which is imported in index.html. Even then when I change height or max-height popover can't be closed..

Any updates on this? Really need something like this so I can create global classes for different sizes (sm, md and large tooltips). Now these styles need to reside within each component which seems tedious.

+1

Hi @valorkin Any update on this issue?

Hi @valorkin, any update to this? I can bring this feature back and create pull request if you want.

I was reading this like yesterday, and half of year just gone away ...
I should stop blinking

Is this fixed?

@valorkin I am trying to set width of tooltip but I can't do it. I use option containerClass

http://valor-software.com/ngx-bootstrap/#/tooltip#custom-class
so you need to create proper class and apply it to tooltip
take in account that your class selector weight should be higher than default one

I tried customClass property with ngx-bootstrap tooltip and it works fine. However, I see that the tooltip is transparent now. I can see all the elements on the main page body through the tooltip. How do I fix this?
I tried the following without any luck:
.tooltip.customClass .tooltip.in{
filter: alpha(opacity=100);
opacity: 1;
}
How do I resolve this issue?

check the docs linked above, and use containerClass input prop


Update documentation around the new CLA status check

Since the CLA bot behavior has change the documentation should reflect that.
Fixes #323

This change is

Merging this, if there is any problem with the image, I make sure to fix it.

Reviewed 3 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed, 1 unresolved discussion (waiting on @kwirkykat)

CONTRIBUTING.md, line 266 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
I fixed the alt text - but it rendered okay for me in both Safari and Chrome before that. Can you screen shot how it looks like for you? Maybe it's the picture that is wrong.

Done.

Comments from Reviewable


Yarn Support On HDP <IP_ADDRESS>-8 with Spark 2.xx

It seems that using spark-notebook on a newer versions of hortonworks hadoop and spark will cause an error to be thrown when attempting to use with the yarn-manager in cluster mode.  I was getting a "bad substitution" error (viewed from the yarn scheduler portal).

I was able to solve the problem by adding the hdp.version property through Ambari.
-1. Go to 'Ambari -> YARN -> configs' and go to 'Advanced' tab.
-2. scroll down the page to till end, there will find an option to add custom property for yarn-site
-3. click on 'add property' and enter 'hdp.version' and the version value. (<IP_ADDRESS>-8 for me)
-4. save the changes and restart the required services. Now it will deploy the hdp.version property in yarn-site.xml (which you could also add in manually)
These steps solved the problem for me, hope they help you as well!

Oh and a side note, if you are having problems deploying on yarn you should check your environment variables with
env
I manually add the environment variables before starting spark-notebook (at the moment) with a bash script that I name env.sh and run using
sources env.sh
You can find these environment variables by looking in your configs via Ambari or you can go into the

/usr/hdp/current

directory (this is an example, yours may be different) and search through the various directories for your specific paths.
Here is the env.sh script I created (I added a few non-essential environment variables just to be safe)

export HADOOP_CONF_DIR=${HADOOP_CONF_DIR:-"/usr/hdp/current/hadoop-client/conf"}
export JAVA_HOME=${JAVA_HOME:-"/usr/jdk64/jdk1.8.0_112"}
export HADOOP_YARN_HOME=${HADOOP_YARN_HOME:-"/usr/hdp/current/hadoop-yarn-nodemanager"}
export SPARK_CONF_DIR=${SPARK_CONF_DIR:-/usr/hdp/current/spark2-thriftserver/conf}
export SPARK_HOME=${SPARK_HOME:-/usr/hdp/current/spark2-thriftserver}
export SPARK_LOG_DIR=/var/log/spark2
export SPARK_PID_DIR=/var/run/spark2`

To recap, you must have these environment variables loaded before running spark-notebooks or you must add them into the initialize script in spark-notebooks so that they auto-load upon deployment. If you are running spark on yarn in a hadoop cluster you should be familiar with everything I am saying and if not I suggest doing research on your configs, their locations, and spark on yarn deployment.

feel free to improve the docs, e.g. https://github.com/spark-notebook/spark-notebook/blob/master/docs/clusters_clouds.md
P.S. to run apps on YARN cluster you also need spark.yarn.archive set.
e.g. https://github.com/spark-notebook/spark-notebook/blob/master/docs/clusters_clouds.md#secured-yarn-cluster
if you wanna force this for ALL notebooks you may set it like this: bin/spark-notebook  -Dmanager.notebooks.override.spark.yarn.archive=some_hdfs_file_path.zip ...


update README.md

Changes:

Fix some typos in README.md

Hi Dilip,  (@dilipbiswal)  please review.   Thanks.

LGTM

@stevemart Can you please help push.

Thanks Steve and Dilip.


Security based on SCRAM for kafka backend should also consider plain listener

Currently, the operator needs trustStoreSecretName to connect using tls.
However, kafka can be configured also with plain connection, but using SCRAM for authentication/authorization. The operator should consider ssl in scram security as optional.

Can I mount the secrets from strimzi user secret? Also is there only support for trustore, do I not need a keystore?

As latest version is jumped to 2.x, it makes no sense this issue anymore.

Would it be possible to use scram with plain listeners now, could you please provide some kind of documentation for it? I am currently running a strimzi kafka with scram-sha-512 authentication on plain listeners and was thinking of using it for apicurio also.


What is the needed ifconfig.txt?

I have builed rundb and rundl using makefile. When I try to run rundb, an assert cnt == g_total_node_cnt failed because cnt is the number of lines of ifconfig.txt file, but I don't know what is the content of the needed ifconfig.txt. I assume it isn't the output of ifconfig command.

The host address you own for each action in ifconfig.txt
Suppose you enter three lines representing three hosts,
You can set the first two as servers (databases) and the last as clients (load query generation).
First you have to set NODE_CNT to 2 and CLIENT_NODE_CNT to 1 in config.h
Then at runtime, the first host needs to run the command:    ./rundb-nid0
The second host is    ./rundb-nid1
The third host is   ./runcl-nid2 (The client must be opened last).

I have builed rundb and rundl using makefile. When I try to run rundb, an assert cnt == g_total_node_cnt failed because cnt is the number of lines of ifconfig.txt file, but I don't know what is the content of the needed ifconfig.txt. I assume it isn't the output of ifconfig command.

The host address you own for each action in ifconfig.txt
Suppose you enter three lines representing three hosts,
You can set the first two as servers (databases) and the last as clients (load query generation).
First you have to set NODE_CNT to 2 and CLIENT_NODE_CNT to 1 in config.h
Then at runtime, the first host needs to run the command: ./rundb-nid0
The second host is ./rundb-nid1
The third host is ./runcl-nid2 (The client must be opened last).


expose document level term positions

Currently, get_document_vector only return terms and corresponding frequencies. This pull request implements a new function called getPositionList in which returns terms and, for each term,  every position this term occurs in the document.

Another comment for you...


[R] Implement as_nanoarrow_array_stream.list() ?

I wonder if there's value in providing an easy way to convert lists of data frames to an array stream. I could use that in the default implementation of DBI::dbFetchArrow() .
CC @nbenn.

Thanks, missed that function. Seems so:
nanoarrow::basic_array_stream(list(data.frame(a = 1), data.frame(a = 2))) |>
  as.data.frame()
#>   a
#> 1 1
#> 2 2

Created on 2023-11-15 with reprex v2.0.2


ci: update action runners

latest runner info in here, https://github.com/actions/runner-images

Adding macos-11 and macos-12 is ok, but please keep ubuntu-18.04 as it as for best backwards compatibility, until it been removed from github actions.
Thanks!

sounds good, thanks @sighingnow!


Fix typo in migration v6 to 7 page

There was no space between plain text and code in migration guide
https://react-hook-form.com/migrate-v6-to-v7/

thanks


Cmd+P fails to function because VS Code Live Share does not have directory loop detection

Describe what happened:
Cmd+P to search for files by filename only will find files that have already been opened in a local editor.
What was your system configuration?
Product and Version: VSCode 1.45.0
OS Version: MacOS 10.14.4
Live Share Extension Version: 1.0.2106
Target Platform or Language [e.g. Node.js]: Ruby
Steps to Reproduce / Scenario:
[Host] - Create a project that has a symlink that creates a directory loop. e.g. mkdir -p one/two; cd one/two; ln -s three ../../
[Host] - Start a Live Share session
[Guest] - Attach to that Live Share session
[Guest] - Press Cmd+P to search by filename. Notice that it fails to find files that you haven't already opened in an editor.
Probable root cause:
An intentional directory loop caused by a symlink in the vendor directory of a gem in the project causes a failure in the Agent. We see evidence of this in ..._Agent.log exported from the Export Logs feature. The following snippet is repeated many, many times in the ..._Agent.log in the Export Logs bundle:
[2020-05-14 17:59:30.195 Agent.Rpc.Workspace V] > #4 {Id=196 Name=syncService.checkSync}
[2020-05-14 17:59:30.195 Agent.Rpc.Workspace V] < #5 {Id=186 Name=syncService.checkSync}
[2020-05-14 17:59:30.687 Agent.Rpc.Workspace V] > #5 {Id=186}
[2020-05-14 17:59:30.687 Agent.Rpc.Workspace V] < #4 {Id=196}
[2020-05-14 17:59:32.710 Agent.Rpc.Workspace V] > #1 {Id=1220 Name=syncService.checkSync}
[2020-05-14 17:59:32.710 Agent.Rpc.Workspace V] < #3 {Id=1210 Name=syncService.checkSync}
[2020-05-14 17:59:33.203 Agent.Rpc.Workspace V] > #3 {Id=1210}
[2020-05-14 17:59:33.203 Agent.Rpc.Workspace V] < #1 {Id=1220}
[2020-05-14 17:59:35.691 Agent.Rpc.Workspace V] > #4 {Id=197 Name=syncService.checkSync}
[2020-05-14 17:59:35.691 Agent.Rpc.Workspace V] < #5 {Id=187 Name=syncService.checkSync}
[2020-05-14 17:59:35.900 Agent.Rpc.Workspace V] > #4 {Id=198 Name=file.getFiles}
[2020-05-14 17:59:35.900 Agent.Rpc.Workspace V] < #5 {Id=188 Name=file.getFiles}
[2020-05-14 17:59:36.185 Agent.Rpc.Workspace V] > #5 {Id=187}
[2020-05-14 17:59:36.185 Agent.Rpc.Workspace V] < #4 {Id=197}
[2020-05-14 17:59:36.366 Agent.Rpc.Workspace V] > #5 {Id=188 Error={Code=-32098 Message=The path '/Users/$USER/workspace/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/web/node_modules/puppeteer/.local-chromium/mac-686378/chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/78.0.3882.0/XPCServices/AlertNotificationService.xpc/Contents/MacOS/AlertNotificationService' is too long, or a component of the specified path is too long. Data=(StackTrace=System.IO.PathTooLongException: The path '/Users/$USER/workspace/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/gems/$GEM_NAME/vendor/installation/web/node_modules/puppeteer/.local-chromium/mac-686378/chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/78.0.3882.0/XPCServices/AlertNotificationService.xpc/Contents/MacOS/AlertNotificationService' is too long, or a component of the specified path is too long.
   at System.IO.FileStatus.EnsureStatInitialized(ReadOnlySpan`1 path, Boolean continueOnError)
   at System.IO.FileSystemInfo.Init(FileStatus& fileStatus)
   at System.IO.FileSystemInfo.Create(String fullPath, String fileName, FileStatus& fileStatus)
   at System.IO.Enumeration.FileSystemEnumerator`1.MoveNext()
   at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items)
   at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source)
   at Microsoft.VisualStudio.Workspace.Indexing.IndexWorkspaceService.<>c__DisplayClass101_0.<<FindIndexedFilesAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, PauseToken pauseToken)
   at Microsoft.VisualStudio.Workspace.WorkspaceFolderHelper.FindFilesAsync(String rootPath, Boolean recursive, Func`2 handleDirectory, CancellationToken cancellationToken, Paus...

The installation symlink looks like
~/workspace/installation/gems/$GEM_NAME/vendor $ ls -l
total 0
lrwxr-xr-x  1 pivotal  staff  9 Apr  9 12:16 installation -> ../../../

When we remove that symlink and restart all VS Code instances (and the Live Share session), Cmd+P works correctly.
The exported logs contain sensitive information that we're uncomfortable sharing, but this should be easy enough to reproduce. (Yes, I know, this is never the case. :() Do let us know if you require additional information.

cc: @mingxiao

Hi Kenneth! thank you for reporting this issue.  It sounds to me more like a feature request, we will review it and prioritize it appropriately.
c.c. @fubaduba

I notice that this bug has been closed.
Has the problem been fixed?

Hey, can you please prevent your stalebot from closing this issue?
I ran into this bug again on Wednesday while working with a colleague while using the latest version of the extension and latest version of VS Code. This is still not fixed.

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it’s for you.

...clarify your use case and contact us to let us know how severe it’s for you.

I thought that the description and detailed reproduction steps that I put here were clear? https://github.com/MicrosoftDocs/live-share/issues/3535#issue-618445993. Let's try again, then.
This breaks Cmd+P. This means that remote participants in a Live Share session cannot search for files by filename, unless that file is already open in an editor. For trivial projects containing only a few hundred files, this might be acceptable, but for projects that have thousands-to-hundreds-of-thousands of files, this is a significant loss of functionality.
It has been two-and-a-half years(!) since I first made this report, but I do remember that this bug causes the project-file-selection-tree to fail to behave correctly:

I know that the title of the tree up at the top was stuck at something like Loading Contents..., rather than the name of the top-level directory.

This breaks the "copy path to file" feature in the editor tab, as it put that as the first component of the path, rather than the actual path component.

There was also something wrong with expanding parts of the tree. I think there were massive delays in loading parts of the project's file tree, but -again- it has been years since I reported the issue.

Symlink loop detection is table stakes for anything that runs on Linux or OSX, so I figured that the problem would be clear, and that listing the easiest to describe symptom would be fine. I suppose that neither was the case.
Here's hoping that you folks see your way clear to dragging in a Subject Matter Expert from elsewhere in Microsoft and spending the one-to-three days it would take to resolve this in your core filesystem traversal library.

As far as "customer impact" goes, we waited a few months for you folks to fix this issue (see the "table stakes" comment above for why we thought this would be recognized as a low-effort, high-impact fix), and then stopped using Live Share.
We fell back to using Zoom Screen Sharing which sucks in a lot of ways, but is better tolerated by the team than smashing into the brick wall of this issue.


Added some text to the README file

@pecca86 yes, first! Nice work. Simple enough!

Now, as others add to this, your fork will fall behind. Be sure to Fetch Upstream before you contribute again so you're working off the same sheet of music 👍


IP Pools

Is there any way setup ip pools to utilize IP's of other servers IP in same datacenter.
I have a setup  of 20 servers in same data center. One is POSTAL and others are db, app, etc etc

Not at this time as far as I know.

I believe that Postal would need to see all the addresses so you would have to create some kind of clustered set up. If you are already using the servers for other purposes, this would likely have a negative affect on your systems overall performance.


Kunta

Add initial version of Kunta command.
Idea is that it generates borders of random municipality of Finland for your interest.
This first version would just use these pre-generated images though

Closed, replaced by https://github.com/M4R774/bobweb2/pull/191


No Audio in chroot

sudo edit-chroot -all
name: stretch
encrypted: no
Entering /media/removable/USB Drive/stretch...
crouton: version 1-20161129162558~master:5f2f11f9
release: stretch
architecture: amd64
xmethod: xorg
targets: keyboard,core,chromium,audio
host: version 8743.85.0 (Official Build) stable-channel candy
kernel: Linux localhost 3.10.18 #1 SMP Tue Nov 15 18:26:30 PST 2016 x86_64 GNU/Linux
freon: yes

Please describe your issue:
When in my chroot, audio from browsers and from speaker-test will not play. Audio from mpd or aplay /usr/share/sounds/alsa/Front_Center.wav will play. aplay -l gives aplay: device_list:268: No sound card found....
If known, describe the steps to reproduce the issue:
sudo enter-chroot
xinit
Try to play sound from Firefox; it doesn't play.
I'm using i3wm via xinit, so no DE.

try using alsamixier in a terminal

alsamixer works properly, or at least I think it does. It shows Card and Chip as CRAS, and displays the current audio level properly. My chroot is updated as of 12/4.

@Nerfan Were you able to solve this?
I think I'm seeing the same problem on Debian Sid (before and after updating my chroot today).
(Audio from browser or mpv doesn't work, but both alsamixer and aplay /usr/share/sounds/alsa/Front_Center.wav work, while aplay -l fails with your same error message.)
The error message ("No sound card found") is weird because there are two cards shown when using cat /proc/asound/cards:
 0 [PCH            ]: HDA-Intel - HDA Intel PCH
                      HDA Intel PCH at 0xd1314000 irq 314
 1 [chtrt5650      ]: chtrt5650 - chtrt5650
                      chtrt5650

Maybe this issue is similar to #45? Running sudo aplay -l gives me these devices:
**** List of PLAYBACK Hardware Devices ****
card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: PCH [HDA Intel PCH], device 7: HDMI 1 [HDMI 1]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: PCH [HDA Intel PCH], device 8: HDMI 2 [HDMI 2]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 1: chtrt5650 [chtrt5650], device 0: 1 []
  Subdevices: 1/1
  Subdevice #0: subdevice #0

@dcecile I haven't been able to solve this problem. I get very similar output to you when running those two commands (basically identical but different hardware).

I wanted to see if there's something that I messed up in my chroot after creating it, so I created two new chroots from scratch...

Debian Sid: no setup changes, same release as my primary chroot, same sound playback problems
Ubuntu Trusty: no setup changes, no sound playback problems

Why would Trusty be fine? Is there something in Sid that's incompatible with the CRAS that gets put into the chroot?

@dcecile Ubuntu Trusty runs on an older Linux kernel. Audio will work on kernels 3.x but not on kernels 4.x
There is an issue about this in either the GalliumOS or chrx repo (can't remember which) with no solution yet.

OK, so I think I've got it working now by installing an older version of libasound2 (and libasound2-data).

Debian Jessie works fine, so I copied the sid lines in /etc/apt/sources.list file and modified them to say jessie
Uninstalled new ALSA with sudo apt remove libasound2{,-data}
Installed old ALSA with sudo apt install -t jessie libasound2{,-data}
Put holds on these packages to avoid upgrading sudo apt-mark hold libasound2{,-data}

(You'll also need to use alsa-utils from Jessie.)
P.S. I couldn't find any similar GalliumOS or chrx issues. Also, I think this might not be kernel related, because dpkg -l | grep linux-image seems to indicate that no kernel is installed in the chroot.

I had to update Crouton today, and after updating back to the latest version of libasound2, the problem is still here. I can't figure out how to work around this beside downgrading libasound2.

New crouton. Debian buster armhf. No sound. Sound in CrOS ok.

@dcecile ,I tried this and failed half way through. Uninstalling ALSA went ok, but it uninstalled 500Mb of files, which seemed quite a lot.
Installing the old ALSA using sudo apt install -t jessie libasound2{,-data} failed with:
E: The value 'jessie' is invalid for APT::Default-Release as such a release is not available in the sources
So I put the sources.list file back as it was and reinstalled ALSA. Trying to start pulseaudio returns
bash: /usr/bin/pulseaudio: No such file or directory
So I still have no sound, but seem to have done more damage during the uninstall/reinstall loop.
Ah well, it was worth a try...

But I couldn't just leave it broken, so I reinstalled the crouton using jessie as the release and I have sound. So something is broken in later debian releases.
I'll leave it at that for now, but if anyone can suggest how to get sound in a later release, I'd be happy(ish) to try it out.

Just FYI: This seems to be fixed. I was having the same issue earlier today, updated my Stretch chroot, and it's working now.

No audio in Debian Buster, I'm going to try Stretch

I have no audio in sid, but it looks like the root user does.  Adding myself to the hwaudio group fixed this:
[...]
ioctl(0, TCGETS, {B9600 opost isig icanon echo ...}) = 0
openat(AT_FDCWD, "/dev/snd/controlC0", O_RDONLY|O_CLOEXEC) = -1 EACCES (Permission denied)
openat(AT_FDCWD, "/dev/aloadC0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)

phil@localhost:~$ sudo strace aplay -l
[...]
ioctl(0, TCGETS, {B9600 opost isig icanon echo ...}) = 0
openat(AT_FDCWD, "/dev/snd/controlC0", O_RDONLY|O_CLOEXEC) = 3
ioctl(3, SNDRV_CTL_IOCTL_CARD_INFO, 0x7ffdbf5a9c50) = 0
close(3)                                = 0
newfstatat(1, "", {st_mode=S_IFCHR|0620, st_rdev=makedev(0x88, 0x6), ...}, AT_EMPTY_PATH) = 0
write(1, "**** List of PLAYBACK Hardware D"..., 44**** List of PLAYBACK Hardware Devices ****

phil@localhost:~$ ls -al /dev/snd/controlC0
crw-rw----. 1 root hwaudio 116, 13 Jan 10 08:52 /dev/snd/controlC0

phil@localhost:~$ sudo gpasswd -a phil hwaudio
Adding user phil to group hwaudio

phil@localhost:~$ logout

localhost ~ # enter-chroot -n sid-test-from-zipfile2
Entering /media/removable/extssd/crouton/chroots/sid-test-from-zipfile2...

(sid-test-from-zipfile2)phil@localhost:~$ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: sofrt5682 [sof-rt5682], device 0: smart373-spk (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0

Ah, no, that's not the problem.  It looks like the cras module isn't loading, and adding myself to hwaudio just let ALSA bypass it and talk to the hardware directly -- as in https://github.com/dnschneid/crouton/wiki/Access-audio-hardware-directly-(ALSA,-JACK)
Confirmation that ALSA doesn't know about cras:
(sid-test-from-zipfile2)phil@localhost:~$ cat /dev/urandom | aplay -Dcras -
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM cras
aplay: main:831: audio open error: No such file or directory

Trying to start pulseaudio:
(sid-test-from-zipfile2)phil@localhost:~$ DISPLAY=:1.0 pulseaudio
E: [pulseaudio] module.c: Failed to load module "module-alsa-sink" (argument: "device=cras sink_name=cras-sink"): initialization failed.
E: [pulseaudio] module.c: Failed to load module "module-alsa-source" (argument: "device=cras source_name=cras-source"): initialization failed.
E: [pulseaudio] main.c: Sink cras-sink does not exist.
E: [pulseaudio] main.c: Source cras-source does not exist.

(I'm specifying DISPLAY here because I'm doing this over ssh, but I have a running xfce session).
It does look like we have access to CRAS:
(sid-test-from-zipfile2)phil@localhost:~$ cras_test_client --dump_server_info
System Volume (0-100): 100
Capture Muted : Not muted
User muted: Not muted
Output Devices:
	ID	MaxCha	Name
	15	0	sof-rt5682: :0,5
	14	0	sof-rt5682: :0,4
	13	0	sof-rt5682: :0,3
	12	0	sof-rt5682: :0,2
	8	2	sof-rt5682: :0,1
	7	2	sof-rt5682: :0,0
Output Nodes:
	Stable Id	ID	Vol  UI       Plugged	L/R swapped	     Time Hotword	Type		MaxCha Name
	(76f39a73)	15:0	 100 0.000000      no	           no	        0        	HDMI                 0 sof-rt5682 HDMI/DP,pcm=5
	(b5fe4622)	14:0	 100 0.000000      no	           no	        0        	HDMI                 0 sof-rt5682 HDMI/DP,pcm=4
	(dfa08336)	13:0	 100 0.000000      no	           no	        0        	HDMI                 0 sof-rt5682 HDMI/DP,pcm=3
	(8a033e9d)	12:0	 100 0.000000      no	           no	        0        	HDMI                 0 sof-rt5682 HDMI/DP,pcm=2
	(62f96cde)	8:0	 100 0.000000      no	           no	        0        	HEADPHONE            2 Headphone
	(72a57953)	7:0	   8 0.000000     yes	           no<PHONE_NUMBER>        	INTERNAL_SPEAKER     2*Speaker
Input Devices:
	ID	MaxCha	Name
	16	2	sof-rt5682: :0,100
	11	2	sof-rt5682: :0,1
	10	4	sof-rt5682: :0,99
	9	2	sof-rt5682: :0,0
	6	2	Post DSP Delayed Loopback
	5	2	Post DSP Loopback
	4	2	Post Mix Pre DSP Loopback
Input Nodes:
	Stable Id	ID	Gain  UI       Plugged	L/R swapped	     Time Hotword	Type		MaxCha Name
	(01cdda27)	16:0	  20 1.000000     yes	           no<PHONE_NUMBER> en_all 	HOTWORD              X Wake on Voice
	(61aab6ba)	11:0	  20 1.000000      no	           no	        0        	MIC                  X Mic
	(0039c920)	10:0	  17 1.000000     yes	           no<PHONE_NUMBER>        	INTERNAL_MIC         X*Internal Mic
	(b90e0a61)	9:0	  20 1.000000     yes	           no<PHONE_NUMBER>        	ECHO_REFERENCE       X Echo Reference
	(ec289a19)	6:0	   0 1.000000     yes	           no	        0        	POST_DSP_DELAYED_LOOPBACK     X Post DSP Delayed Loopback
	(8c74f766)	5:0	   0 1.000000     yes	           no	        0        	POST_DSP_LOOPBACK     X Post DSP Loopback
	(8a04af91)	4:0	   0 1.000000     yes	           no	        0        	POST_MIX_LOOPBACK     X Post Mix Pre DSP Loopback
Attached clients:
	ID	pid	uid
	33	635	1000
Num active streams: 0
Last audio active time: 19507, 528748970

CRAS does indeed work; I hear static when running this (after bumping up the volume a little) inside the chroot:
cras_test_client --playback_f /dev/urandom

Adding an .asoundrc file setting the default pcm and ctl devices to type cras makes aplay work!
$ cat > .asoundrc <<EOF
pcm.!default {
    type cras
}

ctl.!default {
    type cras
}
EOF

$ cat /dev/urandom | aplay -
[static]

No luck with speaker-test; it outputs "Stream error -22" and does nothing.

Aha!  The trick was to specify pcm.cras and ctl.cras in /etc/asound.conf, as that results in the 'cras' device being created, and PulseAudio can now find it.
$ cat | sudo dd of=/etc/asound.conf <<EOF
pcm.cras {
    type cras
}

ctl.cras {
    type cras
}
EOF

$ cat /dev/urandom | aplay -
[static]

$ pulseaudio

I need to manually run 'pulseaudio', but after that the Xfce audio mixer works, and I can play music through SoundCloud on Firefox!

Test progress:

sid, focal, impish: Sound works in Firefox, requires pulseaudio to be started manually.


$attrs is nested

Version
3.1.4
Reproduction link
https://codesandbox.io/s/elegant-merkle-2t2rb?file=/src/App.vue
Steps to reproduce

Open the code sandbox link

What is expected?
test: { "hello": "world" } was supposed to be rendered.
What is actually happening?
test: { "attrs": { "hello": "world" } } is rendered. $attrs include a key attrs.

render(h) {
    return h(Test, {
      attrs: {
        hello: "world",
      },
    });
  },

With the code above, I'm expecting the child component Test would have correct $attrs, but Vue 2 and Vue 3 behave differently.
In Vue 3, the actual data is wrapped with a key attrs.

Vue 2 sandbox: https://codesandbox.io/s/exciting-platform-zomcf?file=/src/App.vue
Vue 3 sandbox: https://codesandbox.io/s/elegant-merkle-2t2rb?file=/src/App.vue

Is it an intentional breaking change that isn't documented (or I couldn't find)? Or is it a bug?

https://v3.vuejs.org/guide/migration/render-function-api.html#vnode-props-format

It's
import { h } from "vue";
import Test from "./Test.vue";

export default {
  name: "App",
  render() {
    return h(Test, {
        hello: "world",
    });
  },
};


Make the tests pass with larger tokenizers

This removes the assumption that tokenizer has only 0-9, and also allows for 0-999 (as in llama 3)
I also limit the length of test_azure_guidance_suffix as it doesn't seem to ever get to '\n' with llama3 8b

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.46%. Comparing base (6eb08f4) to head (bc1e56b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (6eb08f4) and HEAD (bc1e56b). Click for more details.
HEAD has 123 uploads less than BASE

Flag
BASE (6eb08f4)
HEAD (bc1e56b)

124
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   70.25%   60.46%   -9.80%
==========================================
  Files          62       62
  Lines        4472     4472
==========================================
- Hits         3142     2704     -438
- Misses       1330     1768     +438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mmoskal, can you explain what the change to the first (eos) test is doing? Is it just for the sake of parallelism with the max_tokens test, or is there something deeper going on?

the first test is just so that it matches the second one; the second one is for tokenizer
the third is just to avoid it running for a long time


[FEAT] added string signing function, necessary for signed URL genera…

…tion

I signed it - corporation name: Hexadite

I signed it!

Closing, as this is a few years old now.


Test: q15_from_int()

Need test for validation and accuracy.  Note that the accuracy will probably change somewhat between platforms, so the environment needs to be specified.

Tested and working


can I use this program in vscode via cmake ?

I want to modify the program in vscode ,and I can only use the cmake to compile C++ project in vscode, how can I write a project link the lib of this program linking ,like the fade2d, pcl

If you want to use cmake then you have to specify those libraries in your cmake file.


Make sure to return an correct type from argmin/max when input is empty

Oh, geez, that's right. Thanks.


Color picker does not display on tablets in landscape.

Let me know if you need any more information.

should be fixed


E716: Key not present in Dictionary: "special_tabs && s:is_special(s:tab_buffer(a:tnr))"

The following error happens on startup when loading this plugin via lazy.nvim (with lazy = false); it was working OK if loaded using vim-plug.
Error detected while processing function xtabline#render#tabline[15]..<SNR>139_render_tabs[6]..<SNR>139_format_tab_label[7]..<SNR>139_tab_hi:
line    2:
E716: Key not present in Dictionary: "special_tabs && s:is_special(s:tab_buffer(a:tnr))"

As a workaround one can lazy-load the plugin AFTER all other RC files are loaded, e.g.
{
  'mg979/vim-xtabline',
  event = 'VimEnter'
}


move test artifacts to a single dir

Signed-off-by: Tianle Huang<EMAIL_ADDRESS>Description
This will make it easy to copy all artifacts since they are in a single dir.
Issues Resolved
Resolves https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/49
Test
local test to verify the new folder structure
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t<EMAIL_ADDRESS>npm ERR!
npm ERR! Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
npm ERR<EMAIL_ADDRESS>Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!
npm ERR! exited with error code: 128

github action is failed

The failed error is not related to my change. It looks like Github issue to check out the dependent repo.
Since this is blocking https://github.com/opensearch-project/opensearch-build/issues/1190, I will take some risks to merge this PR and then run a quick experiment from infra's repo to see if the integ test can run successfully against this commit. If things are failing, I will revert this PR later.


use new test suite, bump spark-util

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   94.87%   94.87%
=======================================
  Files          12       12
  Lines         117      117
  Branches       13       13
=======================================
  Hits          111      111
  Misses          6        6

Impacted Files
Coverage Δ

...la/org/hammerlab/spark/test/suite/SparkSuite.scala
100% <ø> (ø)
:arrow_up:

...ala/org/hammerlab/spark/test/suite/MainSuite.scala
91.66% <ø> (ø)
:arrow_up:

...rg/hammerlab/spark/test/suite/SparkSuiteBase.scala
93.75% <ø> (ø)
:arrow_up:

.../org/hammerlab/spark/test/suite/PerCaseSuite.scala
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f95f4...55423ca. Read the comment docs.


Update tabs and accordion components to use simpler focus state

What
In the recent accessibility audit we found that the focus styles for the tabs component and accordion component were confusing.
Dave has prototyped how this should look and it has been agreed as a team: https://github.com/alphagov/govuk-frontend/pull/1394
Why

Make these components focus state clearer

Done when

[x] Tabs component matches Dave's prototype
[x] Accordion component matches Dave's prototype
[x] Close associated issue https://github.com/alphagov/govuk-frontend/issues/1405

fixed in #1445


Can pass-through agent be installed on a DC at different site in a different subnet?

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

Edited: Added Azure doc metadata

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c5b27433-167f-6e8e-75a9-2a30e08c94e5
Version Independent ID: 11a6383e-344c-07dd-307e-1c6c54ac8c03
Content: Azure AD Pass-through Authentication - Quickstart
Content Source: articles/active-directory/hybrid/how-to-connect-pta-quick-start.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@UserPower7 Apologies for the delay.  Here is the response from PG :
PTA agent can be installed on any machine(can be DC) on network as long as it has line of sight/connectivity to all DCs against which it needs to authenticate, so if you have two subnets but there is network connectivity between those two subnets then you can install agent on either of network. Also we recommend installing additional agent for high availability.

@UserPower7 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


ReferenceError: document is not defined, when used with Next.JS

Bug description
The problem comes from the package react-phone-hooks
exactly is this file node_modules/react-phone-hooks/styles.js
Reproduction URL
No response
Reproduction steps

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots

Logs

error node_modules/react-phone-hooks/styles.js (12:0) @ injectStyles
error ReferenceError: document is not defined
No response

Browsers
No response
OS
No response

@MuhammadSabah, I want to thank you for reporting the issue and providing a sample application so I could reproduce the cause of the issue and fix it. You can now reinstall the packages so the version of the react-phone-hooks gets upgraded, and the issue doesn't appear anymore.


Add a mechanism to configure the source clock for UART

In espflash, we use UART for estimating the crystal frequency, in esp-hal, we use APB clock (hardcoded) as source for UART.
To generate the stubs, I had to update esp-hal, to use xtal_clock as source of UART, see changes in: https://github.com/esp-rs/esp-hal/compare/main...SergioGasquez:esp-hal:feat/clk-src. In order to avoid doing this every time we update the stubs (although it would only affect C2) , we want to add a way to configure the UART src clock.

Here is a list of the registers used to configure the clock source in UART for the different targets:

ESP32 (UART_TICK_REF_ALWAYS_ON):

0: REF_TICK
1: APB clock

ESP32-C2 (UART_SCLK_SEL):

1: PLL_F40M_CLK
2: RC_FAST_CLK
3: XTAL_CLK

ESP32-C3 (UART_SCLK_SEL):

1: APB_CLK
2: RC_FAST_CLK
3: XTAL_CLK

ESP32-C6

HP(PCR_UART0_SCLK_SEL/PCR_UART1_SCLK_SEL)

0: Not select any clock
1: Select PLL_F80M_CLK
2: Select RC_FAST_CLK
3: Select XTAL_CLK

LP:

ESP32-H2 (PCR_UART0_SCLK_SEL/PCR_UART1_SCLK_SEL)

0: No clock source
1: PLL_F48M_CLK
2: RC_FAST_CLK
3 (default): XTAL_CLK

ESP32-S2 (UART_TICK_REF_ALWAYS_ON)

0: REF_TICK
1: APB_CLK

ESP32-S3 (UART_SCLK_SEL)

1: APB_CLK
2: RC_FAST_CLK
3: XTAL_CLK


Form is not dirty when multicheckbox field is modified

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
Modifying a multicheckbox field doesn't cause the form to be marked as dirty.
Expected behavior
Modifying a multicheckbox field should cause the form to be dirty.
Minimal reproduction of the problem with instructions
See https://ngx-formly-multicheckbox-dirty.stackblitz.io
Checking any of the multicheckbox options doesn't change the form to dirty, whereas if you enter anything into the text input the form is marked dirty.
Note that the Submit button has [disabled]="!form.dirty", i.e. it should become enabled if multicheckbox worked as expected.

Angular version: 8.2.0 (current latest)
ngx-formly version: 5.3.0

Many thanks for the quick turnaround!

released in 5.4 version.

This problem still seems to exist.
using ngx-formly/core 5.8.0

@geert-put try with the latest version of Formly which is v5.9.3.

This does seem to work correctly with the latest version. Many thanks.

Then could you please fill a new issue with a reproduction example :pray:!

Hi, I was noticing that the problem seems to be back (I am using 5.12.0). I was thinking if maybe adding a markAsDirty() inside the bootstrap multicheckbox onChange function could solve the issue since patchValue apparently doesn't mark the control as dirty
onChange(value: any, checked: boolean) {
    if (this.props.type === 'array') {
      this.formControl.patchValue(
        checked
          ? [...(this.formControl.value || []), value]
          : [...(this.formControl.value || [])].filter((o) => o !== value),
      );
    } else {
      this.formControl.patchValue({ ...this.formControl.value, [value]: checked });
    }
    this.formControl.markAsTouched();
    //  this.formControl.markAsDirty(); // would add this
  }

@snekku-dev please open a new issue with a reproduction example.
Thanks!


Improve load balancer name

What this PR does / why we need it:

Using a more meaningful name for load balancer created by Service.
Support backward compatibility.
Adding doc for LoadBalancer type Service guide.

Which issue this PR fixes:
Special notes for your reviewer:
Release note:

The load balancer name created by Service has been changed, now the name includes cluster name, Service namespace and Service name. The services created before this change are not affected.

/test cloud-provider-openstack-acceptance-test-flexvolume-cinder

/test cloud-provider-openstack-acceptance-test-flexvolume-cinder

@lingxiankong  is there any implication during upgrades? (move from older to newer version of the external cloud provider)

/retest

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/lgtm

/approve


dataset collections and close_matches

The last truly breaking page load is for ds_collection_browse.html, the publication page. Loading any of them causes a timeout between nginx and gunicorn, as nginx waits 60 seconds then throws a 504 error. Output in the web container log varies.
Dataset Collections have undergone significant change between v2 and v3, as you know, and I’m not clear how the close_matches table is or isn't being used or whether that is a factor.
id title place count
2 Historical Gazetteer of the Middle East 6446
10 Historical Gazetteer of Central Asia 6704
130 alitest 2363
25 An Historical Gazetteer of Ukraine 3224
116 Historical Atlas of Poland in the 16th century 24626
129 foo 368
179 New African data 114864
123 Taiwan Communities, 1662-1894 974
172 Indigenous Place Names in North America 1126
127 Historical Gazetteer of Central Asia 2338
125 The Historical Middle East 4221

For the smallest, 'foo', the web container log reports this after the long wait, but the timeout 504 has already returned to the browser; the output varies by collection. for indigenous places 172, it did report some families:
DatasetCollectionBrowseView get_context_data() request.user whgadmin
join ['could', 'it', 'be'] ,
fetch_geojson_coll kwargs {'id': 129}
Collection 129: 368 places sorted into 0 families and 368 unmatched.

followup...it occurs that in v3 a dataset in a collection must have been indexed, and previously not. so for existing dataset collections, some datasets' places have no records in the 'whg' index. the upshot is that for collections containing unindexed datasets, there are no references to their pace ids in close_matches. For new dataset collections this would not be an issue.

Several causes of delays have now been addressed with the refactoring and caching of mapdata. Removing my assignment to this Issue because (unless I'm mistaken) any remaining issues would relate to the transfer of data from v2 to v3 and therefore beyond my competence.


Added -t, --title=TITLE switch

Especially useful when rendering from stdin.
I'm using it in simple shell script:
#!/bin/bash
daemonize npm show "$1" readme | vmd --title="$1" &> /dev/null &

which shows me npm package README. It's more descriptive than plain vmd title :-)

Very cool! That's indeed very nice for cases like this.
I just tried it out and saw that the window title loses the " - vmd" suffix when passing the
--title=something option. Was this intentional?
Like, when I run npm show browserify readme | vmd --title=browserify the is just "browserify" instaed of "browserify - vmd".
I just made myself a script like yours and put it in ~/bin/npmv. Very handy, thanks!

@maxkueng Suffix  - vmd survive now :-)

Awesome! Thanks for this cool feature! I've released your changes in<EMAIL_ADDRESS>on npm :sparkles:

Thanks! :-)


ALDocument title front end a bit cluttered

Hard to see beginning and endings of titles. Other than the capital letter and looking to the buttons it’s really not distinguishable between one doc title to the next.
Full screen screenshots

Non-full screen screenshots

Can you try updating to the latest Assembly Line from GitHub on main? We haven't made a release since https://github.com/SuffolkLITLab/docassemble-AssemblyLine/pull/594, which made a lot of improvements here, and there are a few things in other parts of the code we need to address before making another release.

Can you try updating to the latest Assembly Line from GitHub on main? We haven't made a release since #594, which made a lot of improvements here, and there are a few things in other parts of the code we need to address before making another release.

Says I am running 2.21.0 which I think is current main?

We haven't bumped the version string, but we've made a few commits since 2.21.0 was released in early February. You can't know which exact commit it's on unless you just reinstall it from main.

I tried again and it still looks similar. Just noting it

A likely first fix is just adding a little top margin for each row

I think this must still be an old version somehow or you have some custom styles, as when I pull main in, My titles are bold and right aligned. You might have to avoid using the button to update and, instead, use the field at the top of the package management page to manually pull in the main branch. That said, even in our current version they don't have spacing between them. Made a PR in #678 for that.


[plugin-code-exporter/plugin-explorer]: exclude peer dependencies and dependencies from bundle

@graphiql/plugin-explorer

before
after

@graphiql/plugin-code-exporter

before
after

@B2o5T one issue here is - how do users use this plugin if they are using the CDN version of react?

@acao how this was changed with the previous implementation?

@B2o5T there are a few examples where users were able to use the bundled CDN build of this plugin with the CDN graphiql. Each plugin should provide an unbundled module version and a bundled cdn version, as with GraphiQL, @graphiql/toolkit and @graphiql/react. We don't have to solve this problem now, but it will lead to a regression until we fix it

@acao Since a new major is coming, we can go back to this problem in case of reporting it

@B2o5T Too late with my review, sorry 🙇  @acao has a good point, and I don't think the new major will solve this. Removing the bundling of dependencies breaks the CDN examples, in particular this one: https://github.com/graphql/graphiql/blob/main/packages/graphiql-plugin-explorer/examples/index.html
At least the UMD build has to bundle up all dependencies, with the exception of the ones where we define globals: https://github.com/graphql/graphiql/blob/main/packages/graphiql-plugin-explorer/vite.config.ts#L23-L28

@thomasheyenbrock ok! I'll fix it


[Q] Changing Team Type from Work to Academic

Hello Wandb team,
Is it possible to change the team type from "Work" to "Academic" since I missed that option when creating the team?

Hi @yuhsienchiang
Thank you for reaching out. I'll be glad to assist you with this. I'll be checking this and get back to you for updates.
Regards,
Carlo Argel

Hi @yuhsienchiang
Can you provide the following for me please:

Link to your account
Link to your current team

Thank you,
Carlo Argel

Hello @Carlo-Argel,
Thank you for the quick response and your help.
The information you required are listed below.
Link to my account: https://wandb.ai/yuhsien-chiang
Link to my currentteam: https://wandb.ai/supercat
Thank you

WandB Internal User commented:
Carlo-Argel commented:
Hi @yuhsienchiang
Thank you for reaching out. I'll be glad to assist you with this. I'll be checking this and get back to you for updates.
Regards,
Carlo Argel

WandB Internal User commented:
yuhsienchiang commented:
Hello @Carlo-Argel,
Thank you for the quick response and your help.
The information you required are listed below.
Link to my account: https://wandb.ai/yuhsien-chiang
Link to my currentteam: https://wandb.ai/supercat
Thank you

Hi @yuhsienchiang
Thank you for providing this informations. We'll get back to you for the updates.
Regards,
Carlo Argel

Hi @yuhsienchiang , we've update you to an academic org. Marking resolved but please feel free to reopen if you need to.


Release 2.2.0

See changelog file on the diff for description of changes.

Do we perform a bunch of tests agains this before or after this is merged?

Afterwards is easier. If we have reason to believe its a more QA heavy release, we could test a SNAPSHOT build prior.