Route to multiple microservices

Hello Spencer, hello community,
I am having a use case I have to complete, and would like your help on the gateway.
Requirement: Let's say I am having a micro service called myService, which exposed /getData and /saveData.
Now, I am deploying this myService to multiple locations, like: myServiceAWS, myServicePCF, myServiceAzure, etc...
Is it possible with Zuul, or Spring Cloud Gateway, to route to ALL of them based on the route?
If I do something like
zuul.ignoredServices=*
zuul.routes.myService.path=//getData/
zuul.routes.myService.url=http://myServiceAWS:8080,http://myServicePCF:8081,http://myServiceAzure:8082
That results in an error.
If I do something like
zuul.routes.myService.path=//getData/
zuul.routes.myService.url=http://myServiceAWS:8080/
zuul.routes.myService.path=//getData/
zuul.routes.myService.url=http://myServicePCF:8081/
Always only the first one is taken into account.
Could you please advice if it is possible to route to ALL with Zuul (Or Spring Cloud Gateway)?
Or maybe, a way to do it with filters please?
Thank you very much

Maybe you can try this:
zuul:
  ignoredServices: '*'
  routes:
    aws:
      path: /getData
      serviceId: xxxService

xxxService:
  ribbon:
    listOfServers: http://myServiceAWS:8080,http://myServicePCF:8081,http://myServiceAzure:8082


refactor: refactor ParsePlaceholders for conciseness and adaptability

avoid panic with corrupted placeholder
support any run spans between delimeters
update template.docx to include corrupted and nested cases
lay foundation for a template engine to be introduced

closes #29

WIP, do not merge now.
hi @lukasjarosch, seems the lint ci failed, is it related to the go version / runner itself?


Mismatch in rev id's produced on iOS and Java due to missing canonicaljson

As mentioned here:
https://github.com/couchbase/couchbase-lite-java-core/pull/175#issuecomment-41364037

Merging PR, but it looks like revision ID's may not be identical across iOS and Android for the same content?

Android has no equivalent of CBLCanonicalJSON, which is called at the end of Database.encodeDocumentJSON.

// Create canonical JSON -- this is important, because the JSON data returned here will be used
// to create the new revision ID, and we need to guarantee that equivalent revision bodies
// result in equal revision IDs.
NSData* json = [CBLCanonicalJSON canonicalData: properties];
return json;

couchbase-lite-java needs to port CBLCanonicalJSON in order to have identical rev id's with iOS.
This should not cause any issues, but rather is an optimization.  See https://github.com/couchbase/couchbase-lite-java-core/issues/164#issuecomment-40771079

Note to self:
Because CBL Android/Java does not canonicalize json, Revision ID which is generated from json is different from iOS one. Also, different Revision ID causes different winning revision picking.

Duplicated #878


Standalone bindle tarball support

Currently the standalone module does not support the optional tarball mechanism. We should implement both pushing and writing to tarballs for easier portability

Closed in #283


How sftp-tab supports multiple jump hosts

No additional support is provided. The goal of this plugin is to supplement the functionality that Tabby lacks in opening the sftp tab compared to Securecrt, which meets my own needs. You can download this plugin, make modifications, submit a PR, and we will discuss whether to merge it into this plugin together.

@0smboy
1.0.4:
support multiple jump hosts: support ProxyJump, not support ProxyCommand


Icon Request: Energy sources

Icon Request

Icon name: solar, windturbine, water, geothermal, nuclear
Tags of this icon: solar, windturbine, water, geothermal, nuclear
Use case: For UIs/Websites that would like to highlight energy sources
Screenshots of similar icons:

Would love this as well!


Improve the type inference in denoLoadLibrary

This pr use Deno.ForeignLibraryInterface to improve type inference in denoLoadLibrary, fix missing Quit function in IMG and TTF, and adjust _data property of Color class to avoid typescript error.

Hi sorry I've been on vacation for the last 3 weeks. I'll try and take a look at this in the next few days.

I'll be willing to take the toPlatformStruct changes but please run deno fmt on the code. The changes from DynamicLibrary to Deno.DynamicLibrary are a no go for me.

So can we make DynamicLibrary infer return type from FFI symbol type? Some copy from deno is needed, with a MIT license

Honestly it's not needed. There is never any interaction directly with the FFI layer. Only generated code directly interacts with the FFI stuff. If you can figure out how to keep the names of the functions available via FFI I would gladly accept that but we don't need to copy the entire interface from deno.


Add docker support for building GamerOS images

This PR adds support for building GamerOS images in Docker, which addresses some points in #63.
To get this to work, I needed to make a few modifications to build.sh to support running pikaur as a normal user. By default, pikaur will run as it did before, so these changes shouldn't have any effect building outside Docker.
Also added are optional image output directory environment variables which the Docker image uses to move the image file outside the container.

Oh wow, this seems to actually work. That's awesome!
I was not expecint this to be possible, because we used to run mkinitcpio in the build script. When did that change?

Thanks for the explanations! I see no issues with it then


Fix a few typos

I apologize for the nitpicking, but the supporess and endpoing, while perfectly understandable, were annoying

LGTM 😂

Thanks @k3KAW8Pnf7mkmdSMPHz27 !


Add report option for unique flattened json output

What would you like to be added
A new --report ndjson feature that flattens and outputs node, service, vulnerability combinations as unique JSON results.

Why is this needed
The current --report json option outputs json in one large chunk and does not map the relationship between nodes, services, and vulnerabilities. This makes it hard to ingest large amounts of output into a single entry for many logging tools and also makes it hard to correlate nodes and services to respective vulnerabilities.

This would be very helpful when exporting logs to bigquery. It is difficult to query fields that are lists, and sometimes log lines exceed size limits in stackdriver (256kb) with the current JSON output.

+1


Forecast not shown for National Weather Service (NWS)

Describe the bug
Forecast data from NWS is not being drawn
To Reproduce

Install and configure NWS
Create new card using NWS
Observe too much room for activities

Screenshots

Desktop (please complete the following information):

Card v2.2.6
2024.2.0

Well that bites. NWS is the only one I've found that's accurate for my area.


Don't export chars.ts

Coverage remained the same at 90.734% when pulling 82218852d7114aa84d7bc485012c6b0d16222164 on tweaking into eb605997d7c3aba506449279d89d69f6b2809938 on master.


Peer to Peer Code Review

Hi @tumainimaganiko, good job so far.
Highlights Suggestions:

[ ] When the page reloads the task checked should be checked;

I'm happy you detected that. I have already worked on it and you can try to look for another issue 😀😀


git push --set-upstream origin Elaad-curveAdd Elaad curves fast charging and regular charging

Related to

https://github.com/quintel/etsource/pull/2067
https://github.com/quintel/atlas/pull/133
https://github.com/quintel/etmodel/pull/3066


Create opam package for piqilib 0.6.11

Hello,
Thanks for your great software! I don't know if this is the correct place to file this -- but I was wondering if you could create a 0.6.11 piqilib for opam? Due to the base64 upgrade there are now annoying conflicts with other packages that one would want to use piqilib with (for example ocaml-cohttp). I am happy to make a pull request as well if that is helpful.
Apologies if this is not the right place for this ticket.
Thanks.
Trevor

Hey Trevor, thanks for letting me know! I'll submit the package some time later today. Perhaps should have pushed it earlier... It didn't occur to me that somebody may run into compatibility problems.
In the meantime you can use this repo for the latest piqi version: https://github.com/piqi/piqi-opam-repo -- I keep the up-to-date opam packaging scripts there. Or you can just pin the version directly from git.

Anton,
Thanks so much! I am currently using the repo for the latest. Just thought I'd pass it along as it will help with usability. Thanks again.
Trevor

This is done now: https://github.com/ocaml/opam-repository/pull/3716


added all yml file details

looks like the package "kknn" is missing from this yml file, i suggest adding that.


Target blank vulnerability issue

Current Behaviour
Links with target="_blank" on them are vulnerable to having the referrer page being swapped out in the background while the user's attention is diverted by the newly-opened tab. This is known as reverse tabnapping.
Expected Behaviour
Adding rel="noopener noreferrer" to links protects your site's users against having the site you've linked to potentially hijacking the browser (via rogue JS).
More Info:- https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

@hsluoyz if possible , I would love to work on this:)


lens-metrics should recover from permanent node failure

What would you like to be added:
Improved recovery strategy for lens-metrics after a permanent node failure.
Why is this needed:
Metrics should be available during a permanent node failure in the event that lens-metrics was running on an affected node.
lens-metrics cannot currently recover if the running node has a permanent failure. The prometheus pod will be stuck in a permanent Terminating state after pod termination grade period. Pod has to be force deleted for lens-metrics to recover.
Environment you are Lens application on:

Kubernetes distribution: 1.18 release on on-premises servers running Ubuntu 18.04 LRS
Desktop OS: Windows 10

Some additional information concerning why the pod get stuck in a Terminating state.
Prometheus is a stateful pod tied to a StatefulSet and in the case of an Node outage will not be deleted automatically. This behaviour per design and described in https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/pod-safety.md. Currently this must be manually corrected with node deletion using options --grace-period=0 --force.
A workaround described in https://github.com/kubernetes/kubernetes/issues/74947 suggest monitoring the stateful pod:

This issue has been raised many times in community like #55934 and #54368 , the current workaround solution is for such case, we may need to an alert system to trigger the deletion of pods on failure nodes so as to trigger statefulset pods can be rescheduled. Like we can define some alerts and rules in alert manger to see if there are nodes goes down, then try to delete all of the pods for statefulset, and then those pods for statefulset will be rescheduled.


Smart sign implementation.

Smart signs go brrr.

Should probably get into the habit of making good comments...


#GUI Redeployment of all apps make services in group 'stateful applications' that cannot be changed.

This is an effort to rebuild every app in case the mesos masters lose any configurations and we need to redeploy from scratch.
This script runs every five minutes and backs up the marathon json file to github.
#!/bin/bash
ts=$(date "+%T %D")
ENV="infra"
cd ./marathon-backup

while true; do
    #git init - Occurs in Dockerfile
    git config --global user.email<EMAIL_ADDRESS>    git config --global user.name "Mesos Docker Bot"
    git config --global push.default simple
    git remote add origin git@github.enterterprise.com:ems/docker-marathon-backup.git
    git branch $ENV
    git checkout $ENV
    git pull origin $ENV
    curl -uadmin:password -k http://marathon-$ENV.mesos.enterprise.com:8080/v2/apps | jq . > marathon-backup.json
    git add --all
    git commit -m "$ts"
    git push origin $ENV
    echo "sleeping"
    sleep 300
done

Then when we restore the configurations we use this script.
#!/usr/bin/env bash

# script/deploy: deploys artifacts

set -e
set -o errexit
set -o errtrace
cd $(dirname $0)/..

source script/bootstrap

function marathon() {
    # Deploy to Marathon
    taskProgress "Deploying to Marathon"
    taskDebug "marathon ${MARATHON_URL}"

    MARATHON_ID="${MARATHON_APP}/${IMAGE_NAME}"

    taskDebug "deployment url ${MARATHON_ID}"

    #replace variables from Marathon template
    taskDebug "deploying ${REMOTE_IMAGE_NAME}..."

    JSON=$(ejson decrypt credentials.ejson)
    USER=$(echo $JSON | jq '.username' |  sed 's/"//g')
    PASS=$(echo $JSON | jq '.password' |  sed 's/"//g')
    CREDS=$USER:$PASS

    echo ""

    cat marathon-backup.json | \
    curl -s -u "${CREDS}" -XPUT -H"Content-Type: application/json" -d @- --url "http://marathon-infra.mesos.enterprise.com:8080/v2/groups"

    echo ""
}

case "$1" in
    *)
        marathon
        ;;
esac

After marathon gets the configurations back, everything is back up and running, but when we need to scale the application down, we get this message -->

Scaling down $/maps/stores-data will cause any existing local volumes to be detached from destroyed instances. Read more about persistent local volumes.
Are you sure you want to continue?

After we click the 'continue scaling' button, nothing happens.
If we wanted to scale the application to more instances, nothing happens.
Any ideas on how we can better this process or fix this bug?

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4100. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


kernel-resin.bbclass: Add missing dependency for leds-gpio

Change-type: patch
Changelog-entry: Add missing kernel config dependency for leds-gpio
Signed-off-by: Andrei Gherzan<EMAIL_ADDRESS>
Contributor checklist

[x] Changes have been tested
[x] Change-type present on at least one commit
[x] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@resin-jenkins retest this please


[macOS/iOS] Set MoltenVK logging level based on --verbose flag.

Prevent [mvk-info] spam in non-verbose mode.

Thanks!


Improve profile page

Is your feature request related to a problem? Please describe.
Since the platform if for different category of users. There is not any information about the type of the user whether he/she is a student or teacher. Their is not much information about the users educational details. As if a user is a school student in which class he is, if he is a UG student his branch details and if he is a teacher his highest qualifications.
Describe the solution you'd like

Add user type to the sign up page as (Student/Teacher).
Ask the users too fill up more information about their educational details as
a) If a user is a school student ask him to fill out his class and school name.
b) If a user is a college student ask them to fill out his year of study and branch details.
c) If a user is a teacher ask him to add his highest qualification.

Are you working on this? (Yes/No)
No, this task for GCI students under difficult.

@deepak2431 I got the form setup. How would you like the student and teacher data represented in the database?


Revert duration hint to MAY_DUCK

Revert the duration hint passed to requestAudioFocus to AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK and pass audioFocusChangeListener to abandonAudioFocus.
Starting the following commit: https://github.com/dennisguse/OpenTracks/commit/d1a459efc2417d6c0bf3490459228ec4b19fff1b the duration hint was changed from AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK to AUDIOFOCUS_GAIN_TRANSIENT.
This introduced the behavior that OpenTracks stops audio players when doing the voice announcement, after the announcement was finished the audio player however didn't resume playing and required manual intervention.
IMO the voice announcement shouldn't stop your music since it is annoying and definitely against what the user expects. Ducking the volume, as it was < v3.2.9, is the better option.
(In my case - using Amazon Music - I had to press pause and play again to resume the audio. The play/pause button on the BT headset I use didn't work so I had to pull out the device and do it on screen.)
I assume this behavior is due to the null that was passed to abandonAudioFocus. That's why we should pass the audioFocusChangeListener as described in the AudioManager reference: https://developer.android.com/reference/android/media/AudioManager.html#abandonAudioFocus(android.media.AudioManager.OnAudioFocusChangeListener)
Can't test this change before I get home. Feel free give it no priority.

Looks good.
If you could test this with your device it would be great.
PS: Ignore TravisCI as it sadly broke some days ago - so ignore the failing CI.

Excuse the late reply.
I've tested it and it behaves as intended. Thank you or merging.

Don't worry. Thanks for fixing an issue I introduced. ;)


Used By: researchanalysis.com

researchanalysis.com
We catalogue and analyse medical research claims regarding atherosclerosis.

Thanks!


Short Account Names and Symbol Name Spaces

Asset symbols need to support  PARENT.CHILD enforcement
Account names of less than 3 characters need to be supported by BTS
Fees on Asset Registration have been raised to prohibitively high levels until this hardfork can be implemented.

Implemented.


⚠ Processors has degraded performance

In f1a8eff, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 219 ms

Resolved: Processors performance has improved in ffd7e79.


Failed to build OpenSSL 3.0.5

I tried to build openssl 3.0.5, but it failed with the error below.
It seems 3.0.x has not been supported yet.
Could you consider to support version 3.0.x?
❯ ./build-libssl.sh --version=3.0.5

Build options
  OpenSSL version: 3.0.5
  Targets: ios-sim-cross-x86_64 ios-sim-cross-arm64 ios-cross-arm64 mac-catalyst-x86_64 mac-catalyst-arm64 tvos-sim-cross-x86_64 tvos-sim-cross-arm64 tvos-cross-arm64 watchos-sim-cross-x86_64 watchos-sim-cross-arm64 watchos-cross-armv7k watchos-cross-arm64_32
  iOS SDK: 15.5
  tvOS SDK: 15.4
  watchOS SDK: 8.5
  MacOSX SDK: 12.3
  Number of make threads: 10
  Configure options:  no-deprecated
  Build location: /Users/kmasumitsu/Downloads/OpenSSL-for-iPhone

Downloading openssl-3.0.5.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14.3M  100 14.3M    0     0  8145k      0  0:00:01  0:00:01 --:--:-- 8173k
Building openssl-3.0.5 for iPhoneSimulator 15.5 x86_64...
  Logfile: /Users/kmasumitsu/Downloads/OpenSSL-for-iPhone/bin/iPhoneSimulator15.5-x86_64.sdk/build-openssl-3.0.5.log
  Configure...
Problem during Configure - Please check /Users/kmasumitsu/Downloads/OpenSSL-for-iPhone/bin/iPhoneSimulator15.5-x86_64.sdk/build-openssl-3.0.5.log

build-openssl-3.0.5.log

Version 3 is currently not supported

Any plans to support OpenSSL 3?
I have attempted to add support for it, but I do not have experience with the build system. The best I could do is make it build for iPhone ARM64 and macOS x64, but it fails to compile the universal library, so I currently have it disabled in my fork
https://github.com/httpstorm/OpenSSL-for-iPhone/tree/gvalkov

No plans here.


Get the latest GitHub Actions runners version and update the self-hosted runners

Get the latest GitHub Actions self-hosted runners versions for each OS, replace the version and deploy the corresponding runner using GCP services.
Self-hosted runners

Ubuntu: Update the Dockerfile, uplpoad the new image to the registry and re-deploy the k8s cluster.
Windows

Imported from Jira BEAM-13762. Original Jira may contain additional context.
Reported by: danimartin.
Subtask of issue #21106

2 cents on self-hosting runners:
I built a service for running self-hosted GitHub Action runners on cloud with 0 maintenance and free for open source: https://cirun.io/

It's on-demand, which means you only pay to your cloud provider for the time you're using it. It also supports arm based runners.
All you need is a simple configuration .cirun.yml file, here is a demo.
Also available on GitHub Marketplace as well: https://github.com/marketplace/cirun-io


[TW#15299] Any time-based job schedulers available in ESP-IDF?

Hi all,
I would like to ask that is there any time-based job timer libraries available (similar to cron in Linux) in ESP-IDF and/or FreeRTOS? Or is there any good idea for implementing these functions?
By the way, sorry if I asked dumb question...
Thanks and regards,
Jackson

Also curious.

It depends on what you want exactly... you could say the FreeRTOS timer API can be abused as a barebones cron replacement, for example. If you want anything more complex, you may have to build it yourself (or see if someone else already did).

@Spritetm Thanks for your reply. Now I will plan making a wrapper library for the cron stuff.

Any update?


Gateway: don't generates a new address every time the page is loaded

This will cause an excessive number of state machines to be spawned

What's the alternative? We could cache an address in localStorage or something, but then you run into the problem of the implicit expiration of addresses in fedimint. IMO the endpoint should return the same address until it's been used. Maybe add an optional parameter to force a new address if necessary.
I think this is more of a fedimint/fedimint issue than fedimint/ui.


Alpha is broken in hex2color!

gui(window, { .bgColor = ...:
    .bgColor = sfw::hex2color("#ff8888") -> OK
    .bgColor = sfw::hex2color("#ff888800") -> black (could be OK...)
    .bgColor = sfw::hex2color("#ff8888ff") -> BUT, ALSO BLACK! :-o

The same with sf::Color(0x...) seems to be fine!

Well, not "broken", it has just never been implemented yet...


Difficulty curve

Would be nice if cards were selected (or are they already?) inversely proportionally to the distance from any card that was already present. This would give a nicer difficulty curve.
(I'm a bit frustrated after a game where the leftmost 3 were my first 3 cards:)

Yeah it's an interesting though. I'm not sure exactly what the best way of that working would be but something like that may make the card picking algorithm nicer.

@Synthetica9 @tom-james-watson I wrote a PR that requires the first two cards be at least 100 years apart, the next card 90 years apart from the first two, etc., down to a minimum distance of 5 years.
I think that achieves what is requested here, although it might merit some tuning, especially if there were ever user-based options.

This is implemented in https://github.com/tom-james-watson/wikitrivia/pull/57 :+1:


Would like a Graphics Bandwidth benchmark

@abarth mentioned to me that we should be tracking our graphics bandwidth.  Which can be approximated by the sum of the total size (bytes) of layers drawn to the GPU every frame / # of frames drawn.
My understanding is that this number is a trade-off with high-end performance and that using more bandwidth (caching more in textures) will improve performance on high-end devices, but that eventually we saturate the GPU bandwidth on low end devices.
I'm not aware of any benchmarks we currently have to track this number.
Did I get that right? @abarth @yjbanov @chinmaygarde

CC @brianosman : does Skia have an API to count the size of layers used? For example, if saveLayer is called many times, such metric should go up.

We don't have anything in Skia that counts layer sizes, surface sizes etc. Those would be pretty easy to layer on top of Skia. Texture bandwidth also occurs every time you draw an image, or we internally draw something like an image (e.g. an alpha mask representation of a glyph, blur etc). Then there's bandwidth to the framebuffer every time we draw anything on the GPU. Counting this inside Skia would be quite complicated. If I were to attempt to measure this I'd investigate whether there are GL/Vulkan/... perf analysis tools that could do it for me.

CC @dreveman as we were just discussing this hours ago. We think that we could utilize some platform-specific APIs to do this. Fuchsia currently does have some bandwidth benchmarks running.

We track GPU frame times and memory usage with Impeller now. Bandwith itself is a trickier concept but I think what we have is good enough


Robot model fails to load properly on Humble

On Humble, when I build the main branch and launch the provided KR moveit launch file with fake controllers, I notice that the robot model is not properly loaded with the following message in the terminal:
WARNING:root:Cannot infer URDF from `/home/<user>/workspaces/kuka_ws/install/kuka_kr_moveit_config/share/kuka_kr_moveit_config`. -- using config/kuka_kr.urdf
WARNING:root:Cannot infer SRDF from `/home/<user>/workspaces/kuka_ws/install/kuka_kr_moveit_config/share/kuka_kr_moveit_config`. -- using config/kuka_kr.srdf

In rviz I can see that TF for links1-6, tool and flange are also not available.

These warnings are issued by the moveit setup assistant, which expects a different folder structure from the convention in ROS-Industrial also used by us. This does not influence the loading of the robot model.
The reason for the not appearing robot meshes is that currently you have to activate the robot manager node even for fake hardware, as described in the readme). This behaviour will change soon, I would suggest to use this branch, as the scheduling is also optimized there.

you have to activate the robot manager node even for fake hardware, as described in the readme

That was indeed the case, as I unfortunately skipped the very last paragraph of the readme in my haste :)
Thank you for both the tips!


I2C Library for boilerplate projects?

So I was trying the boilerplate project with the plasma2040 rotary encoder example and it looked like it was trying to link with a library called pimoroni-i2c
There wasn't one, so I made this cmake file to create one, and then could compile the example boilerplate.
You can check out my boilerplate project here - maybe I was setting it up wrong?
I think the linker is trying to link that library because of this line in ioexpander.cmake ?

@Gadgetoid so something more like what i've pushed now?

@lordmortis oh wow, you're quick on the update. Exactly that, yes. Thank you!

You got me right as work finished and it was a pretty trivial change. Yay timezones!

On 7 Feb 2022, at 20:10, Philip Howard @.***> wrote:

@lordmortis oh wow, you're quick on the update. Exactly that, yes. Thank you!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
!DSPAM:62010c4c195801605913505!


TypeError: Cannot destructure property 'scale' of 'Object(...)(...)' as it is null.

🐛 Bug Report

I just installed the package using NPM. I copied the code from the docs and run the project. It says TypeError: Cannot destructure property 'scale' of 'Object(...)(...)' as it is null.
🤔 Expected Behavior
The example should work fine with no error.

😯 Current Behavior
getting this error on the screen

💁 Possible Solution

🔦 Context

💻 Code Sample

🌍 Your Environment
Windows 10

Software
Version(s)

react-spectrum

Browser

Operating System

🧢 Your Company/Team

🕷 Tracking Issue (optional)

Ah, you're missing a Provider wrapping that https://react-spectrum.adobe.com/react-spectrum/Provider.html
you can import it in the same line as the others

Ah, you're missing a Provider wrapping that https://react-spectrum.adobe.com/react-spectrum/Provider.html
you can import it in the same line as the others
I can see that might be confusing as we didn't reference it in that doc, nor do we in other pages

Thank you for your quick reply. As you said it is not mentioned in the docs, I think this Provider page should be referred in every component like Combobox so that beginners always know what's the very first step to use these awesome components.


make the blogID argument of blogsync pull optional

resolve #98

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 34 (17.65%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 29.808%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config.go
6
13
46.15%

main.go
0
21
0.0%

Files with Coverage Reduction
New Missed Lines
%

main.go
1
15.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
248

Relevant Lines:
832

💛  - Coveralls


Enhancement: Blocks catalog polish

This PR cleans up some of the blocks catalog components, aiming for consistency, ease of use, and concision.

Before
After

Block catalog

Block type

Note: I'm working on a PR to the core repo to update descriptions, those could use some work

Also I have a follow up PR for the blocks table in the works


Wrong url when the subscription is expired

When subscription is expired, the link leads to https://dapp.robonomics.network/#/rws-active, but the correct path is https://dapp.robonomics.network/#/rws-buy

#49


Initial commit for Bigtable Sink

Adds skeleton for Bigtable Sink

do you want to take this PR out of draft mode? if so, i'll LGTM

Comments resolved, I have also modified the pom to update the plugins (this will help in the future)


Triggering a rebuild in docker-hub to update rust nightly compiler

A few weeks ago, rust 2021 edition has been stabilized, and the cargo feature is no longer required.
Since then, the coverage builds are failing in CI for tarpaulin, because it is still using an older nightly compiler:
https://github.com/Luro02/array-map/runs/3654333894
Maybe it would be smarter to automatically build a docker image for every release on GitHub.

I only know of this project, which does build docker images on release: https://github.com/faldez/tanoshi/blob/master/.github/workflows/release.yml#L43

Oh it seems since docker changed the payment plan all my docker hub webhooks are gone... Before I did docker builds on release and if there was a change like 2021 edition released when an issue occurred like this I'd just manually trigger them all. But now I can't do that :facepalm:
I'll look at updating the github actions to handle building docker images and pushing them

Okay I've spent this afternoon working on the CI and now it will build all the docker images for:

master
develop
last tagged commit (so last release to crates.io).

And it will do this on ever push to develop, but also every Sunday so if there's periods where I'm merging less frequently the nightly version used should stay relatively recent. Also, unlike docker hub I can be confident these jobs won't disappear one day or fail without explanation.
Once the latest CI job completes I'll merge the PR which should close this issue :+1:


wrong meaning of thread_cache_free_bytes property

It seems that tcmalloc.thread_cache_free_bytes property in fact shows the used bytes and not free bytes.
Is it correct?

Those are number of bytes in thread caches. So those are free bytes.


OPENAI_AI_KEY

May I ask how to solve this problem？

Is it possible to find out how you solved the problem?

 May I ask how to solve this problem？


Cisco platform changes + prepend command functionality

This proposed change adds the following
(#1) Support for cisco platforms in  lib/beaker/platform.rb
(#2) Capability to prepend commands to the various package methods in lib/beaker/host/unix/pkg.rb
Background for (#2): On cisco platforms we need the ability to prepend the following information to the various yum commands when installing, updating or removing RPM packages.

Linux network namespace information
Proxy information
Path information
Target host or guest information

This update changes all commands in the following method to support prepending commands via addition of the opts argument to methods (check_for_package, install_package, uninstall_package, upgrade_package) while maintaining the current default behavior.

Can one of the admins verify this patch?

To meet our contributor doc commits need to be associated with a jira ticket like (BKR-xxx).

I believe that that code could be normalized to be consistent without harming anything.

okay to test

test this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/851/
Test FAILed.

Breaks unit testing:
Failures:

  1) Unix::Pkg check_for_package checks correctly on sles
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("zypper se -i --match-exact sles_package")
              got: ("zypper se -i --match-exact sles_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["zypper se -i --match-exact sles_package"]
       +["zypper se -i --match-exact sles_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:27:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:33:in `block (3 levels) in <module:Beaker>'

  2) Unix::Pkg check_for_package checks correctly on fedora
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("rpm -q fedora_package")
              got: ("rpm -q fedora_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["rpm -q fedora_package"]
       +["rpm -q fedora_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:32:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:41:in `block (3 levels) in <module:Beaker>'

  3) Unix::Pkg check_for_package checks correctly on centos
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("rpm -q centos_package")
              got: ("rpm -q centos_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["rpm -q centos_package"]
       +["rpm -q centos_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:32:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:49:in `block (3 levels) in <module:Beaker>'

  4) Unix::Pkg check_for_package checks correctly on EOS
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("rpm -q eos-package")
              got: ("rpm -q eos-package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["rpm -q eos-package"]
       +["rpm -q eos-package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:32:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:57:in `block (3 levels) in <module:Beaker>'

  5) Unix::Pkg check_for_package checks correctly on el-
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("rpm -q el_package")
              got: ("rpm -q el_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["rpm -q el_package"]
       +["rpm -q el_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:32:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:65:in `block (3 levels) in <module:Beaker>'

  6) Unix::Pkg check_for_package checks correctly on debian
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("dpkg -s debian_package")
              got: ("dpkg -s debian_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["dpkg -s debian_package"]
       +["dpkg -s debian_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:34:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:73:in `block (3 levels) in <module:Beaker>'

  7) Unix::Pkg check_for_package checks correctly on ubuntu
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("dpkg -s ubuntu_package")
rake aborted!
Failed to 'bundle exec rspec' (exit status: pid 11183 exit 1)
/var/lib/jenkins/workspace/qe_beaker_unit-rb_rspec/ruby/1.9.3-p484/Rakefile:39:in `block (3 levels) in <top (required)>'
/var/lib/jenkins/workspace/qe_beaker_unit-rb_rspec/ruby/1.9.3-p484/Rakefile:33:in `block (2 levels) in <top (required)>'
/var/lib/jenkins/workspace/qe_beaker_unit-rb_rspec/ruby/1.9.3-p484/Rakefile:10:in `block in <top (required)>'
/var/lib/jenkins/workspace/qe_beaker_unit-rb_rspec/ruby/1.9.3-p484/Rakefile:23:in `block in <top (required)>'
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => test:spec
(See full trace by running task with --trace)
              got: ("dpkg -s ubuntu_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["dpkg -s ubuntu_package"]
       +["dpkg -s ubuntu_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:34:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:81:in `block (3 levels) in <module:Beaker>'

  8) Unix::Pkg check_for_package checks correctly on cumulus
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("dpkg -s cumulus_package")
              got: ("dpkg -s cumulus_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["dpkg -s cumulus_package"]
       +["dpkg -s cumulus_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:34:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:89:in `block (3 levels) in <module:Beaker>'

  9) Unix::Pkg check_for_package checks correctly on solaris-11
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("pkg info solaris-11_package")
              got: ("pkg info solaris-11_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["pkg info solaris-11_package"]
       +["pkg info solaris-11_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:36:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:97:in `block (3 levels) in <module:Beaker>'

  10) Unix::Pkg check_for_package checks correctly on solaris-10
     Failure/Error: expect( instance.check_for_package(pkg) ).to be === true
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("pkginfo solaris-10_package")
              got: ("pkginfo solaris-10_package", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,2 @@
       -["pkginfo solaris-10_package"]
       +["pkginfo solaris-10_package", [], {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:38:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:105:in `block (3 levels) in <module:Beaker>'

  11) Beaker get_ip can exec the get_ip command
     Failure/Error: expect( subject.get_ip( host ) ).to be === "<IP_ADDRESS>"
       <Beaker::Command (class)> received :new with unexpected arguments
         expected: ("ip a|awk '/global/{print$2}' | cut -d/ -f1 | head -1")
              got: ("ip a|awk '/global/{print$2}' | cut -d/ -f1 | head -1", [], {:prepend_cmds=>""})
       Diff:
       @@ -1,2 +1,4 @@
       -["ip a|awk '/global/{print$2}' | cut -d/ -f1 | head -1"]
       +["ip a|awk '/global/{print$2}' | cut -d/ -f1 | head -1",
       + [],
       + {:prepend_cmds=>""}]

     # ./lib/beaker/command_factory.rb:22:in `execute'
     # ./lib/beaker/host/unix/exec.rb:28:in `get_ip'
     # ./lib/beaker/host_prebuilt_steps.rb:291:in `get_ip'
     # ./spec/beaker/host_prebuilt_steps_spec.rb:435:in `block (3 levels) in <top (required)>'

Finished in 14.71 seconds (files took 2.03 seconds to load)
898 examples, 11 failures

This PR has been aged out by https://github.com/puppetlabs/beaker/pull/826


MemoryError

I am trying to run you codes, but got a memory error in Word2Vec conversion:
X = np.zeros(shape=(number_of_documents, document_max_num_words, num_features)).astype('float32')
MemoryError
I also note there are probably some typos, for example:
vector = zeros(len(target_categories)).astype(float32)
I change it into:
vector = np.zeros(len(target_categories)).astype('float32')
Can you show your implementation environment, such as keras version, operation system and RAM?

import nltk
nltk.download()

It seems that your problem has nothing to do with word2vec (which is created by gensim), but with the allocation of an array by Numpy. Can you post the complete stacktrace?
The dtype can be specified using a string or through the variable np.float32. The namespace "np" is automatically injected by "%pylab inline". Therefore you can leave everything like it is or change it.
My env has 32 GB RAM, but many people worked it out with also with 8 GB.

You are right. My pc only has 4G RAM. No such error happen to a 8G RAM computer.
I note the modeling part only deal with the selected categories, which is 'pl-usa', 1 category? Have you tested on more categories.  Keras provides an example on using MLP for 46-class Reuters Topics, which seems slightly different from Reuters-21578, with test accuracies of about 80%. But I use LSTM to classify the 48-class Reuters only to get about 40% test accuracy.  Have you tried that?

Yes, 'pl-usa' is a category assigned to 12542 newslines; in other words, you can perform a binary classification to select if a post belongs to this category and then classify the others. (If you check here  you can find the distribution of top categories).
You can try with a Multinomial Naive Bayes, to check for the probabilities underlying the category 'pl-usa', but I'am afraid it'll be always a problem if you try to classify with such an unbalanced dataset. Another possibility is to reduce the number of samples with 'pl-usa' so to normalize the distribution of the training set. I've tried adding more categories (up to 100 out of 672, which is the total number in the original dataset) and the accuracy is always high (>80%) when the training set is correctly balanced.
I did't check the Keras dataset, but I think it's already normalized (only 46 categories). If you look at the original distribution, you can see that it's hard to work with the raw dataset without any preprocessing or limitation, however you have a good point to work on!


Docker Build AWS Lambda function error

I am encountering below error on CentOS 7.
docker: Error response from daemon: Failed to initialize logging driver: InvalidParameterException: 1 validation error detected: Value 'eawsy/aws-lambda-go-shim:latest/goofy_jang/86708dc91ade4f34f6a378059f811b228879a35c5809e23cba84a1f72935bd14' at 'logStreamName' failed to satisfy constraint: Member must satisfy regular expression pattern: [^:*]*
	status code: 400, request id: f89491bd-41e2-11e7-a7a4-93e07a8be471.
make: *** [docker] Error 125

Here is the detailed log
# wget -qO- https://github.com/eawsy/aws-lambda-go-shim/raw/master/src/preview.bash | bash
> Pull AWS Lambda build environment from Docker Hub
latest: Pulling from eawsy/aws-lambda-go-shim
Digest: sha256:e7d0182f0703226449446dfbf726dbab4ad35e1960b9a0e1870d80edef34f7ca
Status: Image is up to date for eawsy/aws-lambda-go-shim:latest

> Download AWS Lambda Go dependencies from Github
github.com/eawsy/aws-lambda-go-core (download)

> Download handy Makefile from Github
--2017-05-26 17:14:30--  https://github.com/eawsy/aws-lambda-go-shim/raw/master/src/Makefile.example
Resolving github.com (github.com)... <IP_ADDRESS>, <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://raw.githubusercontent.com/eawsy/aws-lambda-go-shim/master/src/Makefile.example [following]
--2017-05-26 17:14:31--  https://raw.githubusercontent.com/eawsy/aws-lambda-go-shim/master/src/Makefile.example
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2296 (2.2K) [text/plain]
Saving to: ‘Makefile’

100%[====================================================================================================================================================================================================>] 2,296       --.-K/s   in 0s

2017-05-26 17:14:31 (41.4 MB/s) - ‘Makefile’ saved [2296/2296]

> Check AWS Lambda basic execution role

An error occurred (NoSuchEntity) when calling the GetRole operation: Role not found for lambda_basic_execution

> Create AWS Lambda basic execution role
{
    "Role": {
        "AssumeRolePolicyDocument": {
            "Statement": [
                {
                    "Action": "sts:AssumeRole",
                    "Effect": "Allow",
                    "Principal": {
                        "Service": "lambda.amazonaws.com"
                    }
                }
            ]
        },
        "RoleId": "AROAITSGKDWXY7EHC6EFI",
        "CreateDate": "2017-05-26T07:14:31.707Z",
        "RoleName": "lambda_basic_execution",
        "Path": "/",
        "Arn": "arn:aws:iam::XXXXXXXX:role/lambda_basic_execution"
    }
}

> Build AWS Lambda function
docker: Error response from daemon: Failed to initialize logging driver: InvalidParameterException: 1 validation error detected: Value 'eawsy/aws-lambda-go-shim:latest/goofy_jang/86708dc91ade4f34f6a378059f811b228879a35c5809e23cba84a1f72935bd14' at 'logStreamName' failed to satisfy constraint: Member must satisfy regular expression pattern: [^:*]*
	status code: 400, request id: f89491bd-41e2-11e7-a7a4-93e07a8be471.
make: *** [docker] Error 125

This is my go environment.
# go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/root/golang"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build243335846=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

Hi @vikas027,
The problem seems to come from your Docker daemon which is in trouble when trying to run the image.
Can you please double check that you can run other docker images, etc and that your docker daemon works correctly.  Run for example docker run hello-world

Thanks for the quick reply @fsenart.  I ran the same script on OS X 10.11.2 and everything ran fine.
Not sure what, but there is something not right somewhere.
I cannot doubt my Docker installation/configuration as I am running docker on an AMI which is running lots of Docker production workloads. Here is the output of the command anyways.
# docker run hello-world

Hello from Docker!
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker ID:
 https://cloud.docker.com/

For more examples and ideas, visit:
 https://docs.docker.com/engine/userguide/

Also, I believe -d switch (after base64) is not required in this command. You might wanna update Makefile
> Invoke AWS Lambda function
+ aws lambda invoke --function-name golang-preview --invocation-type RequestResponse --log-type Tail /dev/stderr --query LogResult --output text
+ base64 -d
+ grep -o '[0-9\.]\+ ms'
+ head -1
+ xargs -0 echo -n ' executed in'
base64: invalid option -- d
Usage:	base64 [-dhvD] [-b num] [-i in_file] [-o out_file]
  -h, --help     display this message
  -D, --decode   decodes input
  -b, --break    break encoded string into num character lines
  -i, --input    input file (default: "-" for stdin)
  -o, --output   output file (default: "-" for stdout)

The docker daemon cannot initialize the logging driver due to the name of the log stream. The error says that the log stream name must not have ":" in it but eawsy/aws-lambda-go-shim:latest violate this rule.
It is very weird because I can't imagine that we cannot run an image by precising the tag we need.
What is clear is that the problem is not related to the preview.bash script but to the way the Makefile run the docker image.
Let test something more simple, docker run -it --rm -it eawsy/aws-lambda-go-shim:latest version. To see if the docker daemon is able to configure the right log stream.

Hmm, yeah Docker is unable to run this container
# docker run -it --rm -it eawsy/aws-lambda-go-shim:latest version
docker: Error response from daemon: Failed to initialize logging driver: InvalidParameterException: 1 validation error detected: Value 'eawsy/aws-lambda-go-shim:latest/dazzling_hamilton/6c9e7bf6c9c39037ee485937aca7c67c76f259b7db36ac3b4b5015d9c32e0d72' at 'logStreamName' failed to satisfy constraint: Member must satisfy regular expression pattern: [^:*]*
	status code: 400, request id: c55a29d0-41f6-11e7-ad58-a10df8a6004e

I have found the issue. We are using awslogs as Docker logging driver.  Looks like this image doesn't like this driver (not sure the reason though). I can run the docker command if I specify the log driver
# docker run -it --log-driver=json-file --rm -it eawsy/aws-lambda-go-shim:latest version
2017-05-24

Now to fix the issue in the preview.bash script, I have inserted below line at line 52
sed -i 's/docker run/docker run --log-driver=json-file/' Makefile

Overall, I am all set now.
Cheers.

@vikas027 the preview.bash is here only to jump in the project easily. And the Makefile is provided for being fully customized for your needs. So if you need to run the Docker image in your AMI, abandon the preview.bash, download the Makefile and just change anything you want in it. It is only here as an example so moreover than using a sed command, I advocate on creating a custom makefile for your uses case.
Anyway, if you have any other problem in the future, do not hesitate ;) Happy Go on Lambda!

Yeah, I will tweak the Makefile according to my needs. Thanks.


Avoid __nodeRequire()

We still have a few places of a __nodeRequire that we should convert into async import().
For example, code such as:
this._keytar = <IKeytarModule>require.__$__nodeRequire('keytar');
becomes:
this._keytar = await import('keytar');
Places:

[ ] MainThreadKeytar @chrmarti
[ ] readWindowsCaCertificates @chrmarti
[ ] TerminalInstanceService @Tyriar
[x] RawDebugSession @isidorn
[ ] Win32UpdateService @joaomoreno
[x] RemoteAgentConnection @alexandrudima

@weinand actually added the dependency to vsda. However when I change the code to await import('vsda'); I get an error that vsda can not be found. @weinand should we specify that we use vsda somewhere?
Code pointer https://github.com/Microsoft/vscode/blob/a00a9a29452546c6f5018f89d5c9f051f841dd38/src/vs/workbench/contrib/debug/electron-browser/rawDebugSession.ts#L531

Isn't this still going async, deep down?

@isidorn __$__nodeRequire comes from the vscode.loader. The owner of that package (@alexandrudima or @jrieken) should advise how to replace this with an async import.
BTW, 'vsda' is used in two places: RawDebugSession and RemoteAgentConnection. Please fix both of them since Alex is out.

@isidorn yeah that sucks, we probably need to throw in a vsda.d.ts into src/typings to make TS happy :-|

Updated the title, there is no difference in loading behaviour but I feel __nodeRequire() is really a hack from the times where we could not write async import(...). It also gives us proper typing.

Isn't this still going sync, deep down?

Yeah, it's still equally sync. Writing async import 'foo' is the same as writing new Promise(resolve => load_module('foo')). It still helps because it auto-generates load_module for you.

I get an error that vsda can not be found. @weinand should we specify that we use vsda somewhere?

Putting declare module 'vsda' {} anywhere in your code should help

Thanks for advice.
Added vsda.d.ts and fixed the issue in rawDebugSession
Now strangly the RemoteAgentConnection can not await import('keytar'); since that import violates the ts lint import rule. @bpasero should I put the vsda.d.ts in some other typings folder, since the RemoteAgentConnection can not depend on it from src/typings?

It should be able to depend, then we need to tweak some tslint rule maybe.

Ok. I have tweaked the tslint rule to allow vsda to be imported. Did not use a * to not allow random node modules to be imported there.
Seems to work fine now

@isidorn looks like this is causing build failures and they can be explained by the fact that remoteAgentConnection is living in common when it should live in node. I am not sure why that is, maybe we should leave that one up for next milestone and move it properly.

@bpasero yup, just saw the build failure. Reverting my commit.

I'll be replacing these with importing standalone modules soon:
https://github.com/microsoft/vscode/blob/652650732653c4c4ac1f0f54788486e76aea516e/src/vs/workbench/contrib/terminal/electron-browser/terminalInstanceService.ts#L37-L38

Terminal ones removed in https://github.com/microsoft/vscode/pull/74858

@bpasero I can look into moving remoteAgentConnection to node.
@aeschli does this make sense to you? I see some modules from common depend on it, so I wold probalby split the remoteAgentConnection to have the implementation in node and interfaces in common

@bpasero Do you know why mainThreadKeytar.ts was placed in the 'browser' and not the 'node' folder? Maybe that was an oversight.

@bpasero I looked into the remoteAgentConnection and it is a bit more complex. The issue is that it can not be nicely split up between common and node since the actual function that uses require.__$__nodeRequire syntax is used by other modules not living in node.
We seem to use the vsda module for signing when in the native environment. And due to that I believe we need two implementations of connectToRemoteExtensionHostAgent one for the native and one for the rest. So we basically get rid of this check.
I could also pass in the signer as part of the options, so the remoteAgentConnection stays in common and different clients would pass a signer.

@chrmarti I noticed this and it is a bad hack, but I am not sure why that was done. The right solution would be to introduce a service for this and implement it in browser and node environments.
@isidorn I do not understand

fyi
There is a difference in the behaivor of the __nodeRequiere() and await import('')
When the module is missing, the second patter will only throw the error the first time you import the moduel.
Due to that I had to cache the promise to always have the expected behavior for the missing module
https://github.com/Microsoft/vscode/blob/18f4630bc51a3d87c7b31d96ca9c8ea95aa649b0/src/vs/platform/sign/node/signService.ts#L15

Created https://github.com/microsoft/vscode/issues/75257 as a follow up


Feat/use gitlab actions

Description
Use Github Actions to build the project for Releases

Relevant Issues :

Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[X] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

wow this is helpful and I really want to take time to understand. can you give me a sentence or two on why asciidoc, I guess having embedded version numbers is easier, and how does it work, i also hope the existing site rendering continues to work: https://github.com/intuit/karate/deployments/activity_log?environment=github-pages

You are right about the asciidoc file. I tried it since there are no such things as variables in Markdown files. And it would be easier to change just one value in one place rather than multiple.
But the dynamic rendering of the page by Github doesn’t support it. So it is not the right solution in this case.

@sixdouglas I would be ok with a find-replace of some text like @@version@@ - we can keep it simple, even for the XML - ideally the changes should not change the existing formatting / white-space etc - I was actually considering a low-tech approach of writing some src/test/java .. ReleaseUtils (even main is ok) which could do this string replace and move files around - and then call that via mvn exec

With the help of this post:
https://blog.frankel.ch/github-actions-maven-releases/
And this article:
https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets
you'll be able to setup the Github Actions and fill the secrets needed to automatically upload the artefacts to the right places.

As you can see, on line 23, I've set two variables in the setting.xml files secrets.serverUsername and secrets.serverPassword. These variables are needed to be able to upload the binaries to the bintray repository.
You'll have to set the in the project settings.
Normally this will version will create the Release and add the Robot and Netty fat jars in the release.
I haven't tested it yet though.

@sixdouglas I would be ok with a find-replace of some text like @@version@@ - we can keep it simple, even for the XML - ideally the changes should not change the existing formatting / white-space etc - I was actually considering a low-tech approach of writing some src/test/java .. ReleaseUtils (even main is ok) which could do this string replace and move files around - and then call that via mvn exec

In deed, we can imagine a README_TEMPLATE.md in the .github directory. This file would contains the versions as @@version@@. And during the release workflow, we can imagine replacing the /README.md file by this template, with the version TAG substituted by the current release value.
This would imply not touching the README.md file manually anymore.
And at some point, we will need to commit the files in the repository too.

The workflow is set to be launched manually by calling an API endpoint. I'm looking for it. Stay tuned 😉

Here is a good start :
https://levelup.gitconnected.com/how-to-manually-trigger-a-github-actions-workflow-4712542f1960

What works:

the new version number is set in every file
the changed files are committed in the repository
the build runs

Current status (for today):

I have no bintray account so the publish step fails, I'm testing with just maven package
I have no PGP key, I run maven with the  -Dgpg.skip flag

@sixdouglas thank you so much. please give me some time to digest this and try to run this !

@ptrthomas Hi, of course, take your time. You need to see if this fits your needs and how to work with it.
If you want to see the result of the pipeline, here is my fork https://github.com/sixdouglas/karate/actions, you'll the results.

What works:

the new version number is set in every file
the build runs
the changed files are committed in the repository
the Release creation
the artifacts (Netty and Robot) are added to the Release

Current status:

I have no bintray account so the publish step fails, I'm testing with just maven package
I have no PGP key, I run maven with the -Dgpg.skip flag
I set the Release as Draft, this way you will be able to fill the Release Note before making it official

Missing:

Docker image build

This PR is related to the #1313

Docker Build is now part of this PR.

What works:

the new version number is set in every file
the build runs
the changed files are committed in the repository
the Release creation
the artifacts (Netty and Robot) are added to the Release
Docker image build

Current status:

I have no bintray account so the publish step fails, I'm testing with just mvn install
I have no PGP key, I run maven with the -Dgpg.skip flag
I set the Release as Draft, this way you will be able to fill the Release Note before making it official

Configuration needed:

add secrets to git repository
** sonatype bintray : SERVERUSERNAME & SERVERPASSWORD
** dockerhub : DOCKERHUB_USERNAME & DOCKERHUB_TOKEN
change mvn install to mvn deploy (on line 57)
setup gpg & remove the  -Dgpg.skip on line 57

@sixdouglas really sorry for the delay, kept putting it off. I will merge this before the month ends. one question - is there any way we can avoid having to create a duplicate of the readme, can we use it "in place" - don't feel good about checking in a whole copy

@ptrthomas I totally agree with you. This solution is not a good one.
In order to use the in place replacement, you would need to give the actual version (say the 1.2.3), in order to find it in the README.md and replace it with the new version (for example the 1.3.0).
It is doable. Let me know if this is a solution you would consider.

@sixdouglas yes please. and once we have that working I can think of some creative way to use a regex pattern within the document to find the place to replace (if possible) - I wonder if when we run a mvn versions:set that the old version is available, maybe we can do some XPath to scrape it out, oh wait (refers my docker batch scripts) there is a command: KARATE_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout) but all that can be later
thanks !!

@ptrthomas Here is a new version.
This time there are no README.md template file.
Remember:

this will only works on master branch
you have to launch it manually giving the new version number you want to build
the Release is created as Draft, so you can fill the Release note before publishing it
the Draft is only for the Github Release, the jars will be publish on Bintray during the build and the Docker image will be pushed to Docker Hub, and the code changes (pom with the new version and the README.md) are commited on master

Remember II:

you still have changes to do on this PR to make it works as you wish (mvn deploy, pgp configuration and secrets to add on the repository)

Enjoy

@sixdouglas this is very helpful thanks ! hope you continue to contribute :) really appreciate all the references and thorough instructions 👍


Dont copy web.config in sync

Hi Kudu team
This is more a question than an issue.
We are using Kudu on our installation of Azure Pack, meaning that all sites that are created gets kudu attached. We would love to do stuff to the default deploy script for the sites that are created.
From the documentation, i see that this can be done pr. site, my modifying the deploy.cmd file, and we have this working. The issue is that we now have to change the deploy.cmd file for each site(currently ~600) in the installation, and do it everytime we create a new site.
We customize something globally for each site, these are the app settings like POST_DEPLOYMENT_ACTIONS_DIR, SCM_USE_LIBGIT2SHARP_REPOSITORY and SCM_TOUCH_WEBCONFIG_AFTER_DEPLOYMENT but i havn't had luck changing or setting which deployment script should be used globally.
The two solutions i see is possible right now is

modify deploy.cmd for each site

modify the .deployment file to have command = global position on each site

Both solutions include changing something that is site specific rather than global.
The solution we are trying to do is:
When a user changes some files in their repositories, KuduSync copies all changed files to the webroot. In our post deployment actions dir, we have a tool that does a web.config transform, to ensure that certain configurations gets added to the web.config. The "problem" with this approach is that the web.config now looks different for KuduSync, and therefore copies web.config next time it syncs. This means that no matter what files get changed in the repository, web.config gets transferred to the webroot, thous restarting the app.
The solution that we have come up with is changing the deploy.cmd file, and tell KuduSync to ignore the web.config. In our post deployment tool, we then to the web.config transform to a temp dir, and overwrites the web.config in the webroot, if they are different. It is working, but includes changing the deploy.cmd for every site.
Any advice on this, or are we having a wrong approach for the issues?

Sounds like the same as https://github.com/projectkudu/kudu/issues/1167, which was fixed recently. Maybe your Azure Pack has an older Kudu build?

No not exactly we implemented the newest Kudu, exatly to get that functionality, as we thought that was the trouble maker, it was ALSO causing the app restart, but our own transform in the end is the real culpit.
The issue is that we actualy need to inject some things in the web.config that is in the webroot, and currently it is done with web.config transforms. This results in the fine in the webroot beeing different than the one in the repository, thus KuduSync will copy again next time

But that is supposed to be covered by the fix. In fact, this is not a unique situation, and even a vanilla MVC app has a transform which makes the resulting file different from the one in the repo (removes the debug attribute). Read my entry that starts with "Digging into things a bit more" in that thread.
Now the question is why it doesn't work for you, which would require investigation. But on the surface, it is not a different scenario as far as I understand.

Thanks, ill take a deeper look into the conversation in 1167, we are running the S48 release of kudu though, but something along the way might need an update aswell.

One suggestion is to check whether you get the same behavior happens on Azure. This would help isolate whether the recent fix is generally not working for you, or whether it's specific to how it's running in Azure Pack.

Good idea to check the functionality on Azure.
I do think the issue is because we are doing our transforms as part of the Post deployment actions, and not part of the build process. Though i cant see where in the KuduSync update it would compare a transformed config, and not just the one on source vs destination, but some magic must happen in there.
Ill dig :-)

In theory, with the new KuduSync (this code), it should never overwrite web.config if the source and destination have the same content. And here, the 'source' normally is not what's in the repo, but already has the transforms.
 Are you starting with the repo file, changing it and saving it to wwwroot? Or doing it in place in wwwroot?

We used to apply it to web.config directly in the wwwroot. But with the recent updates to KuduSync it sounds like we should maybe use the temporary folder where the git checkout is done. It sounds like the compare is between the "temp" location and wwwroot. Is that correct or?
(And just to clarify we have both a repository and a wwwroot - we don't use the in-place the repository option).

First to clarify one thing: the recent KuduSync changes should not have made anything worse, as before that it would have always copied the file anyway.
@sitereactor Yes, I believe that's the correct thing to do. We you're doing is really a deployment step, so it should be done as part of deployment and not post deployment. It should be part of the main deployment script, and make changes to %DEPLOYMENT_TEMP%. I'm pretty sure this will make things work the way you want.

We agree that the changes to KuduSync hasn't changed the behaviour of copying the file, and i agree it has been changed for the better.
Looking at what the deploy.cmd is created, and used, it makes sense that it would work for the MVC projects, as when a project is deployed by using msbuild, og builds+transforms it into a DEPLOYMENT_TEMP directory, and from there it does kudusync to the webroot. This ensures that the web.config files that are compared are the ones that have already been transformed.
In our case we are using the SCM_SCRIPT_GENERATOR_ARGS = --basic params, which turns on the basic deploy script, which only does the KuduSync from repository to webroot.
Our transform is done by having a .cmd in the a post deployment hook, which runs
%TRANSFORM_PATH%\ctt.exe source:%DEPLOYMENT_TARGET%\Web.config transform:%TRANSFORM_PATH%\Web.Transform.config destination:%DEPLOYMENT_TARGET%\Web.config
This transforms the web.config, but also makes it different than the one in the repository that is compared in KuduSync

I think your best option here is a switch from using SCM_SCRIPT_GENERATOR_ARGS to using a full custom deployment script. Then you just need to apply your transform from within the deploy script, modifying the file in the repo (not wwwroot) just before the kudusync call.

Is it possible to set this globally(which was one of my initial questions), so we don't have to speciy in each sites .deployment file? i.e. can SCM_SCRIPT_GENERATOR_ARGS have an arg that points to a specific script? I'm having a little trouble finding the proper way to implement it

If you don't want a .deployment file in your repo, you can instead set a COMMAND Azure App Setting pointing to your custom script (e.g. set it to deploy.cmd if your script is at the repo root). So all you have to do is add your deploy script to your repo.

That might be the solution, thank you so much for you effort @davidebbo it is greatly appreciated, will test this out first thing on monday

Though I must say I don't quite follow something: if you're going to add a deploy.cmd at the root of your repo, why is it much harder to also commit a .deployment file next to it?

Oh i think i misread then, i thought of adding a global deploy.cmd and point the app setting to that one, making us having only one script.
It is true, if we need to add a deploy.cmd to each repo, its the same issue/problem as with the .deployment file. and I actually think the .deployment file would be the better approach.
We would like for it to be an app setting setting the script some where globally. That way we could ensure that it isn't too easy to change which script to use, and we control the script one place only

So stepping back, today you use a post deployment script. How are you making it global? Doesn't it need to exist in each site?

Nope, it is simply set in an app setting to
POST_DEPLOYMENT_ACTIONS_DIR = C:\kudu\artifacts\ which then contains the scripts that are run. We are having multiple web workers, so we ensure that each worker has the folder with the scripts located in them.

Oh, I forgot that you were using Azure Pack. On Azure, there is no way to have such shared file on the local drive. But if you can do that, I think you can simply set COMMAND to some global script, e.g. c:\kudu\shareddeploy,cmd. Give it a shot.

cool, I will test it out.. as said.. first thing monday :-) thanks again


GH-39672: [Go] Time to Date32/Date64 conversion issues for non-UTC timezones

A failing unit test in release verification led to discovering an issue with timestamp to date conversions for non-utc timezones.
Upon some investigation I was able to determine that it was the conflation of casting conversion behavior (normalize to cast a Timestamp to a Date) vs flat conversion. I've fixed this conflation of concerns and the version of the methods which are exported properly converts non-UTC timezones to dates without affecting Casting behavior.
Are these changes tested?
yes

Are there any user-facing changes?
The methods Date32FromTime and Date64FromTime will properly handle timezones now.

Closes: #39672

@raulcd this should get cherry-picked into a new RC to fix the failing test


Updated whatsNew.json

Updated Whats New for 1.2.2 release
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[ X] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[X ] Does the code abide by the Coding Guidelines?
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

I already resolved it manually during 1.2.2 fixes.


Animation Library Editor enable multiselect and tree fold arrow

Resolves godotengine/godot-proposals#8226

Partially Superseded by godotengine/godot#83503


ADHOC: add read needle meta grpc

What problem are we solving?
Add a grpc call/ resp to volume server to extract needle metadata (crc, ttl, last modified..) at specific offset with given size.
How are we solving the problem?
added function to read needle at specific offset with provided size on volume servers.  ec shards not supported.
How is the PR tested?
unit test added
Checks

[ ] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

@lyang24 Thank you very much, I would also like to know more specifically, could this PR be useful?

Hi we will use this on volume.fsck command to fiter out files that modifed under the threshold  to avoid inconsistecies such as file chuck created on volume server but no information on filer yet
this is the related issue https://github.com/seaweedfs/seaweedfs/issues/2578

Hi we will use this on volume.fsck command to fiter out files that modifed under the threshold to avoid inconsistecies such as file chuck created on volume server but no information on filer yet this is the related issue #2578

Thanks, it seems this PR will also be useful for https://github.com/seaweedfs/seaweedfs/issues/3614


feat: Use CommandRunner to struture commands in serverpod_cli

DRAFT
CURRENTLY ALMOST COMPLETELY UNTESTED
This PR use CommandRunner to structure commands in serverpod_cli. This makes commands easier to manage and read. Additionally the help is generated automatically.
Closes #783
Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[ ] I added new tests to check the change I am making.
[ ] All existing and new tests are passing.
[x] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.
Breaking changes
None. Output might be slightly different and never colorized. I'm not sure if analytics still collects exactly (for example help) the same events.

I added an issue for this. We will revisit at some point, but closing for now as the PR is not complete and/or compatible with current code.


Improve performance of logging

The way that logging is currently done means that even though debug logging isn't turned on the log message is still evaluated and thus the inspect function is called. This has a big impact on how long it takes to sync since inspect is very slow.
This PR changes how logging is done to ensure log messages are only evaluated if they are actually needed.
Below I include two screenshots of the impact of the changes introduced in this PR on avg and max time spent syncing, overall it's around a factor of 20:
Before changes:

After change:

Interesting, master is already failing and the tests failing in this pass don't appear to be related to the PR. I'd be iok for merging it personally, baring pushback from @bitwalker.

Added the other two to at least get another set of eyes on it

Thanks I'll look at this beginning of next week.


typo in jsdoc

while fetching the quote for the array of instruments, instruments should be in format exchange:tradingsymbol

@sunilgautam. Maybe I can update my PR, but it seems that the team behind kiteconnectjs is not interested in updating their documentation. :)

Hey @pavanvora
Thanks for highlighting this. We have fixed the above issue in this PR.


deps: update lru to v0.12.5

fix #117
Description

Fixes #117 by update lru to v0.12.5 with cargo update -p lru which modify the cargo.lock only.
How Has This Been Tested?
Run cargo test, output:
running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/chess_tui-ea589f1ba1887773)

running 1 test
test tests::test_config_create ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/checkmates.rs (target/debug/deps/checkmates-f303a0df9e70e4b6)

running 7 tests
test tests::is_checkmate_false ... ok
test tests::is_checkmate_true ... ok
test tests::is_getting_checked_false ... ok
test tests::is_getting_checked_piece_in_front_false ... ok
test tests::is_getting_checked_piece_in_with_gap_false ... ok
test tests::is_getting_checked_true ... ok
test tests::is_checkmate_false_2 ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/draws.rs (target/debug/deps/draws-baa0ea82166b69c8)

running 4 tests
test tests::fifty_moves_draw ... ok
test tests::is_draw_false ... ok
test tests::is_draw_true ... ok
test tests::consecutive_position_draw ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/fen.rs (target/debug/deps/fen-36bd3ddb6f3bff71)

running 3 tests
test tests::fen_converter_1 ... ok
test tests::fen_converter_castling ... ok
test tests::fen_converter_en_passant ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/lib.rs (target/debug/deps/lib-217d4e42beaedcf4)

running 45 tests
test pieces::bishop::tests::king_checked_cant_resolve ... ok
test pieces::bishop::tests::king_checked_can_resolve ... ok
test pieces::bishop::tests::piece_move_multiple_enemies_and_ally_front ... ok
test pieces::bishop::tests::nailing ... ok
test pieces::king::tests::big_castle_black ... ok
test pieces::bishop::tests::piece_move_no_enemies ... ok
test pieces::king::tests::big_castle_black_check_blocking ... ok
test pieces::bishop::tests::piece_move_one_enemies_top_right ... ok
test pieces::king::tests::big_castle_black_king_checked ... ok
test pieces::king::tests::big_castle_black_rook_already_moved ... ok
test pieces::king::tests::big_castle_white ... ok
test pieces::king::tests::castle_both_sides ... ok
test pieces::king::tests::multiple_enemies_1 ... ok
test pieces::king::tests::multiple_enemies_2 ... ok
test pieces::king::tests::small_castle_black ... ok
test pieces::king::tests::multiple_enemies_3 ... ok
test pieces::king::tests::small_castle_white ... ok
test pieces::knight::tests::enemy_and_ally ... ok
test pieces::knight::tests::king_checked_can_resolve ... ok
test pieces::knight::tests::king_checked_cant_resolve ... ok
test pieces::knight::tests::no_enemies ... ok
test pieces::knight::tests::nailing ... ok
test pieces::pawn::tests::king_checked_can_resolve ... ok
test pieces::pawn::tests::king_checked_cant_resolve ... ok
test pieces::pawn::tests::nailing ... ok
test pieces::pawn::tests::pawn_en_passant_black ... ok
test pieces::pawn::tests::pawn_en_passant_white ... ok
test pieces::pawn::tests::pawn_not_en_passant ... ok
test pieces::pawn::tests::piece_move_3_enemies_one_pawn ... ok
test pieces::pawn::tests::piece_move_one_cell_enemy_left_right ... ok
test pieces::pawn::tests::piece_move_one_cell_forward ... ok
test pieces::pawn::tests::piece_move_one_cell_forward_two ... ok
test pieces::pawn::tests::piece_move_one_pawn_3_enemies ... ok
test pieces::queen::tests::king_checked_can_resolve ... ok
test pieces::queen::tests::king_checked_cant_resolve ... ok
test pieces::queen::tests::piece_move_enemies_and_allies ... ok
test pieces::queen::tests::nailing ... ok
test pieces::rook::tests::king_checked_can_resolve ... ok
test pieces::rook::tests::piece_move_multiple_enemies_and_ally_front ... ok
test pieces::queen::tests::piece_move_no_enemies ... ok
test pieces::rook::tests::king_checked_cant_resolve ... ok
test pieces::rook::tests::nailing ... ok
test pieces::rook::tests::piece_move_no_enemies ... ok
test pieces::queen::tests::piece_move_one_enemies_top_right ... ok
test pieces::rook::tests::piece_move_one_enemies_front ... ok

test result: ok. 45 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/promotions.rs (target/debug/deps/promotions-2576e32ba0f13525)

running 5 tests
test tests::is_promote_false ... ok
test tests::is_promote_true ... ok
test tests::is_promote_true_black ... ok
test tests::promote_and_draw ... ok
test tests::promote_and_checkmate ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/utils.rs (target/debug/deps/utils-b85fee676064e25d)

running 5 tests
test tests::convert_notation_into_position_1 ... ok
test tests::convert_notation_into_position_2 ... ok
test tests::convert_notation_into_position_3 ... ok
test tests::convert_position_into_notation_1 ... ok
test tests::convert_position_into_notation_2 ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chess_tui

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Checklist:
(no code changed so seems all unrelevant)

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules (not sure what's this)

Not sure if I should modify the comment myself. I will leave it to maintainer.
Checking chess-tui v1.5.0 (/home/runner/work/chess-tui/chess-tui)
error: empty line after doc comment
   --> src/game_logic/ui.rs:110:5
    |
110 | /     /// CURSOR MOVEMENT
111 | |
    | |_
112 |       /// Move the cursor up
113 |       pub fn cursor_up(&mut self, authorized_positions: Vec<Coord>) {
    |       ------------------------------------------------------------- the comment documents this method
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
    = help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
    |
111 |     ///
    |

error: could not compile `chess-tui` (lib) due to 1 previous error

Thank you for the contribution :tada:  !

Not sure if I should modify the comment myself. I will leave it to maintainer.

Yeah seems like the CI is not happy with a comment I fixed it


Issue 1943: remove serializable from builders and add loadData to load configuration from a config map

Motivation
Make pulsar users be able to use java Serialization framework for distributing client settings. This is required for using pulsar in frameworks like Spark.
Changes

Remove serializable from builders
Add a tool to load client/producer/consumer/reader configuration data from a Map config (which is serializable)

Fixes #1943

@merlimat I address all your comments. please take a look to see if that works for you.

@sijie one option to detect spelling mistakes (or variable name changes) would be to throw exception if there is any unknown key in the configuration map.
This way if there's a typo, I would get an exception instead of my setting being ignored which will be much harder to detect and debug.

one option to detect spelling mistakes (or variable name changes) would be to throw exception if there is any unknown key in the configuration map

I believe the json converting logic covers the name mismatch. am I missing anything there?

Another consideration is that, with this change, the variable names become effective part of the API so we should have a test to make sure all the current keys are supported, to avoid having some of them onadvertently removed later on.

the unit test I wrote covers this purpose.  the stuffs you are worrying is more about backward compatibility between versions, which I think it should be covered by the json coverter. if a field is removed or renamed, the map config would contain wrong variables names, which when it's loaded as POJO, exception would be thrown, no?

@merlimat I set FAIL_ON_UNKNOWN_PROPERTIES to true and add a test case to cover the case loading config with unknown fields.

retest this please


Terminal Auto Reply: Terminal will be reused by tasks, press any key to close it.

Feature:
Can Terminal Auto Reply handle the the exit message from VS-Code Task spawned terminal?

Ultimately I just want to auto reply to message on the task end (preferably without having to edit task setting of the project for whole team).
Expected this would work, but it does not (first one is triggered properly, but the task exit message doesn't seem to work):
  "terminal.integrated.autoReplies": {
    "Terminate batch job (Y/N)?": "Y\r",
    "Terminal will be reused by tasks, press any key to close it.": "\r"
  }

Unclear if this is:

Auto Reply only being triggered on first found instance (this scenario has two required responses)
Task terminal exit message not actually being in the terminal, thus no reply
Not specific enough message - does the message need wildcard e.g *press any key to close it*

No idea if wildcards are supported, only documentation I found on this (https://code.visualstudio.com/updates/v1_64#_automatic-replies) doesn't seem to indicate wildcard support

Workaround:
https://stackoverflow.com/a/67872135/7650275
Configure Task -> Presentation -> Close setting to true:       "presentation": {"reveal": "always", "close": true}
Downside: Outputs error message to VS Code alert:

CC: @Tyriar @meganrogge possible triage/quick close

Auto replies work at the level of data coming from the process running (on the "pty host" process), but this is written by VS Code directly (on the renderer/client process) and therefore ignored. You'd be better off configuring tasks as you do in your workaround for this particular case.


chore: fix flaky test (node-app-pages)

We have a test that fails very often, and makes it annoying to land code. It's not been disabled, we should figure out a proper fix for it.

Disabled in https://github.com/cloudflare/wrangler2/pull/1572

This test is no longer skipped


Add dockerize support

Dear Developers,
I've made a few file additions to enable the GUI to operate in a Docker environment. After searching for existing issues, I noticed that some similar ones are tagged with "wontfix". Still, I hope my commit is useful for this outstanding repository.
The commit has already been tested with the model of Qwen:1.8B and the dataset of alpaca_data_zh. Some python libraries are added to the Dockerfile as a result of the exception messages displayed throughout test procedure.
What does this PR do?
Add dockerize support
Before submitting

[x] Did you read the contributor guideline?

BTW, can we support command line usage in Docker? I thought supporting distributed training was also necessary.

BTW, can we support command line usage in Docker? I thought supporting distributed training was also necessary.

I don't have multiple GPUs available in my environment, and there are opinions as a Docker user.
The simple answer is: YES. Docker commands can be integrated with existing pipeline or workflow, simply by putting accelerate commands following docker commands, like this:
docker run --gpus=all \
    -v ./hf_cache:/root/.cache/huggingface/ -v ./data:/app/data -v ./output:/app/output \
    -p 7860:7860 --name llama_factory -d llama-factory:latest \
    accelerate launch --config_file config.yaml src/train_bash.py # arguments

We could document the guild as part of Readme and remind users to take care of the differences of the path between inside and outside Docker containers.
On the other hand, it is preferable for novices if there exist stable commands that the container runs on. Assuming, if not correct please let me know, that the train_web.py can also be run under distributed way, users can also opt for a default distributed-training Docker compose file that provides them with both single-GPU and multiple-GPUs options, which enables them to select either option and obtain an effortless web GUI according to their hardware setup.

Thank you for your detailed explanation. I think this PR is ready to be merged. Feel free to open a new PR for future updates. Currently, there are still many problems in the distributed training for the LLaMA Board. We will make it available in the future.


⚠ AGEG website (redirect) has degraded performance

In 32406a2, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 5425 ms

Resolved: AGEG website (redirect) performance has improved in 259fe77.


feat: Add the FormOntologyLearner

/azp run

Codecov Report

Merging #1220 (23dbbf9) into master (2d81b50) will decrease coverage by 82.76%.
The diff coverage is 0.00%.

:exclamation: Current head 23dbbf9 differs from pull request most recent head 4b870e1. Consider uploading reports for the commit 4b870e1 to get more accurate results

@@            Coverage Diff             @@
##           master   #1220       +/-   ##
==========================================
- Coverage   83.43%   0.66%   -82.77%
==========================================
  Files         259     244       -15
  Lines       12554   11697      -857
  Branches      650     652        +2
==========================================
- Hits        10474      78    -10396
- Misses       2080   11619     +9539

Impacted Files
Coverage Δ

...ure/synapse/ml/cognitive/FormOntologyLearner.scala
0.00% <0.00%> (ø)

...e/synapse/ml/cognitive/FormRecognizerSchemas.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/spark/ml/param/UDPyFParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/NamespaceInjections.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/param/DataTypeParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/ByteArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/EvaluatorParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/spark/ml/param/ParamSpaceParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/com/microsoft/azure/synapse/ml/stages/udfs.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d81b50...4b870e1. Read the comment docs.

/azp run

/azp run


docs(nav-set-root): fix typos

Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

Thank you!


Fix: Readme links

Description
FIXED README.MD LINKS NOW WORK PROPRERLY
Checklist for all submissions

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you tested and reviewed your changes with confidence that everything works?
[X] Did you branch your changes and PR from that branch and not from your master branch?

If not, why?:

my bad there are 2 commits by mistake only seccond works

LGTM! and thank you.


No -webkit- prefix for transform

I'm using https://github.com/callemall/material-ui which is currently using<EMAIL_ADDRESS>I noticed that support for transform is missing on Android native browser 4.*,
It needs to be prefixed with -webkit- according to caniuse:
http://caniuse.com/#feat=transforms3d
I thought it might be an user agent problem so I also tried forcing prefixAll option which adds the -webkit- (as well as all other prefixes) to transition and transform-origin, but not to transform so the problem is not with detection.

@vedraan Thanks for reporting. Seems strange because if I check the data (lib/caniuseData.js) it lists transform: 4.4 which means transform needs -webkit- prefix for android up to version 4.4.
But let me check that as soon as possible.

I figured out that the browser detection gets something like:
{
   // Chrome version
   version: 30,
   osversion: 4.4
}

The prefixer uses the version to validate props so of course, as 30 > 4.4 it does not add those.
This is an issue unique to Android, because caniuse.com use the osversion instead of the built-in Chrome version (which makes sense). Starting with Android > 5 caniuse.com start to reference the Chrome version (44 right now).
I fixed this by swapping the osversion and version for Android < 4.4 if the native one got detected.

Great, thanks for the quick response. Once it's released I'll do a PR on material-ui to use the latest version.

@vedraan I will release new versions for all my packages on Wednesday, so also 0.5.2 for this package will be released :)


Invalid value for Address Type in Gateway resource

What happened: I have the following error:

failed to translate Gateway "gateway/test": Error GWCER106: Gateway "gateway/test" is invalid, err: unsupported address type "IPAddress", only "NamedAddress" is supported..

What you expected to happen: IPAddress type should be supported in apiVersion gateway.networking.k8s.io/v1beta1
How to reproduce it (as minimally and precisely as possible): Apply this YAML:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: test
  namespace: gateway
spec:
  gatewayClassName: gke-l7-rilb
  addresses:
  - type: IPAddress
    value: "<IP_ADDRESS>"
  listeners:
  - name: https
    protocol: HTTPS
    port: 443
    allowedRoutes:
      namespaces:
        from: All
      kinds:
      - kind: HTTPRoute
    tls:
      mode: Terminate
      certificateRefs:
      - name: default-cert-secret

Anything else we need to know?:

Closed because it's a GKE controller issue.