Fix ruin abilities

They were previously in Field but were never initialized. I did not fix them by initializing them because they're not really Field properties because unlike terrains it doesn't effect every Pokemon on the field.
The aura abilities are also in Field (though those are actually field properties) and they're never initialized but they work because the abilities are checked in the relevant mechanics files. I could have removed them but maybe they serve a purpose I'm not aware or should serve a purpose later on down the road if there's a Dark/Fairy Aura button in the field control area.

Thanks @TheJetOU.  You're right, I added these to field but didn't add an option to the UI to set the values.
Just to explore the options a little: With this approach, can I still run a calc for something like Protosynthesis Flutter Mane with a Chi-Yu ally?  That's what I was worried about when I decided to propose them as field properties instead of just checking the user's ability.

Yeah, I understand the UI doesn't support specifying allies.  My point is that making Ruin abilities toggle-able field effects (like dark aura and fairy aura) allows you to calculate the above scenario, while inferring the effect from the ability would not.
I do concede that it could be a little less intuitive not having the ability automatically take effect, but this would be consistent with how the calculator treats dark aura and fairy aura today.

I'm a bit confused on what you mean. Why are you not able to calculate a Ruin ability Pokemon using a spread move vs an ally? Ruin abilities affect all Pokemon on the field including allies so I don't see the issue.

My point is that making Ruin abilities toggle-able field effects (like dark aura and fairy aura)

Dark Aura do not have a toggle-able field effect. They currently work just like the Ruin abilities in my PR - the field effect properties do no seem to do anything.

Oh, you're right.  Nobody ever added the field toggle buttons for Dark Aura/Fairy Aura either.  That's probably an oversight?  :shrug:
Sorry, I guess my example wasn't very clear.  The scenario I'm imagining is:
You are trying to calc the damage of Flutter Mane using Moonblast on a target, and you want to account for the fact that Flutter mane both has its own ability (Protosynthesis) and that there is another Pokemon on the field applying the Beads of Ruin effect, reducing the target's special defense.  That's what I couldn't figure out how to calc without a field property.
Maybe the ideal solution is actually to both read abilities and support a field effect?

Thanks for the elaboration; I understand the issue now.
My only concern is that adding the two (three?) Aura abilities, four Ruin abilities toggle buttons and others similar abilities (like Steely Spirit and Power Spot) would cause even more bloat to the already cockpit controls looking fields toggles.
I'm less interested in working on that though because I don't play Doubles.
Tagging @AustinXII and @KrisXV for their thoughts on this.

I definitely think button toggles for these would be beneficial, there are some buttons that shouldn't exist in gen 9 so I'll push a fix for that separately

@KrisXV


Googling Documentation leads to old documentation instead of new

Which page is the problem on?
When googling the first option that comes up is old docs and its actually pretty hard to find the new docs. In fact the new documentation doesn't even appear on the first page of my google search, although the source code is the second option for me.
What is the problem?
It's hard to find the current documentation. I thought maybe this was due to me previously visiting old docs, but using incognito also led to old docs. Based on the rtd docs the url redirect should automatically go to /latest unless it has been set to go to stable instead. When I do the test of typing https://neo.readthedocs.io it auto-redirects to /stable.
Suggestions for fixing the problem
I was trying to find where the default branch is set for readthedocs in neo, but couldn't find it. But the default url should be changed to /latest so that it points there instead of to /stable unless the new documentation is not ready yet?

We haven't made a release since updating the docs. Once we do (soon!), then "stable" should point to the new docs.

Thanks @apdavison. I thought they looked super nice, so just wanted to make sure that people weren't going to the wrong section. I'll close this.

Thanks @zm711 we really appreciate the feedback!


Correct the json object definition of an olm encrypted event

The e2ee guide currently states that the content of an event encrypted with olm should have the following structure (https://matrix.org/docs/guides/e2e_implementation.html#encrypting-an-event-with-olm)
{
  "algorithm": "m.olm.v1.curve25519-aes-sha2",
  "sender_key": "<our curve25519 identity key>",
  "ciphertext": "<encrypted payload>"
}

which is inconsistent with the previous paragraphs.
The ciphertext should be an object mapping from the Curve25519 identity key for the recipient device,
as it is already explained in https://matrix.org/docs/guides/e2e_implementation.html#m-olm-v1-curve25519-aes-sha2.
{
  "content": {
    "algorithm": "m.olm.v1.curve25519-aes-sha2",
    "ciphertext": {
      "ljb1QTjaFixBF9Z0v+vkqDFUeez8Y9AqV9QQ4HPc6G8": {
        "body": "Awog2xyRyO+VNbg2BfF7SFgzqWmQG ... K3Ps",
        "type": 0
      }
    },
    "sender_key": "a3tA5yqMRFHnqJ92AgStNgmJIQSgdcGzPPyb2Ec/snM"
  },
  "sender": "@bob:localhost",
  "type": "m.room.encrypted"
}

the e2ee guide is in https://github.com/matrix-org/matrix.org. Would you mind raising this there instead?


Methods for submitting solutions

Is there any chance for a piece of API that would allow submitting kata solutions?

Closing as a duplicate of #2220.


Don't connect ShaderMaterial's changed signal when not in the editor

@Zylann Please test this in your project :slightly_smiling_face:
This closes #34741.

I tested without the connection, that fixes it for sure :)
I've been wondering if there was a way for such signal to only be connected when the material is being edited in the inspector, or even just be a connection to the material editor plugin instead, because it has no reason to be outside of this case. In practice, if I make my terrain editable in the editor without using a workaround, that stutter would still happen because of many materials that can never be seen in the inspector anyways. I don't know if it's worth doing it now, though.
So for now I pool materials, and I may also make sure to disconnect all signals when I instance them.

Thanks!


Allow for keyboard activation of dropdown

For keyboard navigation of the datepicker, it is a bit confusing then when you focus on the input and the datepicker immediately opens.
Here is a proposal for new behavior:

Open on Click
Focus itself does not open the daypicker. Instead you have to press down (or some other action key) to open the datepicker and then you can close it using escape.

fyi @backwardok @wyattdanger

I just started work on this feature. So if anybody want to help, you can check out my branch
There is no tests, but logic seems to be OK


edited .plates/common/*.svg to make them working with inkscape

The outlines in the .svg files weren't visible in inkscape and other 2D CAD sofware before. I increased the line thickness so they are visible.

Thank you so much!


RangeError: Maximum call stack size exceeded when using overlays

Description
The issue is related to a "RangeError: Maximum call stack size exceeded" message shown on console when using tvjs-overlays. The chart seems works fine however the error is displayed for some overlays.
Screenshot

Code (MVP)
<template>
    <trading-vue
      :width="800"
      :height="600"
      titleTxt="Issue"
      :overlays="overlays"
      :data="chart"
      :index-based="true">
    </trading-vue>
</template>

<script>
import {TradingVue, DataCube} from 'trading-vue-js'
import Overlays from 'tvjs-overlays'

export default {
  name: 'App',
  components: { TradingVue },
  data() {
    return {
      chart: {},
      mock: [[1601287200000,45.91,45.97,45.75,45.88,78968.44669],[1601288100000,45.82,46.16,45.82,46.05,236920],[1601289000000,46.04,46.17,45.74,45.8,916660],[1601289900000,45.82,45.87,45.45,45.45,1406610],[1601290800000,45.46,45.54,45.27,45.53,1560240],[1601291700000,45.54,45.59,45.31,45.32,1300830],[1601292600000,45.31,45.45,44.96,45.01,1941410],[1601293500000,45.01,45.2,44.92,45.19,2551620],[1601294400000,45.21,45.35,45.18,45.24,2862530],[1601295300000,45.24,45.44,45.2,45.42,3283410],[1601296200000,45.42,45.59,45.42,45.57,4114910],[1601297100000,45.58,45.59,45.51,45.57,4863210],[1601298000000,45.56,45.81,45.5,45.52,3932140],[1601298900000,45.53,45.55,45.19,45.26,5851190],[1601299800000,45.26,45.32,45.03,45.25,5433800],[1601300700000,45.26,45.44,45.24,45.37,5421940],[1601301600000,45.37,45.37,44.91,44.96,11471390],[1601302500000,44.96,45,44.67,44.7,12080210],[1601303400000,44.7,44.84,44.61,44.76,14457810],[1601304300000,44.78,45.02,44.78,44.94,13551180],[1601305200000,44.93,44.99,44.87,44.98,12714810],[1601306100000,44.99,45.05,44.87,44.9,15204170],[1601307000000,44.89,45.12,44.88,45.05,18026960],[1601307900000,45.04,45.09,44.91,44.92,12786780],[1601308800000,44.92,44.96,44.82,44.93,11204630],[1601309700000,44.93,44.97,44.89,44.95,13959970],[1601310600000,44.98,44.98,44.7,44.74,17028270],[1601311500000,44.73,44.87,44.6,44.6,17846400],[1601312400000,44.65,44.65,44.65,44.65,85670],[1601314200000,44.65,44.65,44.65,44.65,599690],[1601315100000,44.65,44.65,44.65,44.65,342680],[1601373600000,44.63,44.68,44.32,44.63,24.77187],[1601374500000,44.62,44.84,44.56,44.71,162081.90988],[1601375400000,44.66,44.85,44.57,44.61,476990],[1601376300000,44.64,44.69,44.55,44.66,1035570],[1601377200000,44.66,44.99,44.66,44.97,1158130],[1601378100000,44.99,45.21,44.94,45.1,1709700],[1601379000000,45.1,45.15,44.99,44.99,2045350],[1601379900000,44.98,45.19,44.91,45.12,2322290],[1601380800000,45.12,45.17,44.75,44.77,3271480],[1601381700000,44.78,44.99,44.77,44.99,2426750],[1601382600000,45,45.14,44.82,44.82,3022190],[1601383500000,44.82,44.88,44.67,44.87,5392920],[1601384400000,44.87,44.9,44.67,44.68,6192020],[1601385300000,44.67,44.83,44.6,44.81,5007270],[1601386200000,44.82,44.87,44.64,44.64,5791410],[1601387100000,44.63,44.68,44.48,44.67,6624430],[1601388000000,44.67,44.71,44.47,44.47,7847600],[1601388900000,44.46,44.52,44.39,44.44,7975480],[1601389800000,44.44,44.57,44.39,44.5,8169370]],
      overlays: [
        Overlays['BB'],
      ]
    }
  },
  mounted: function(){
    this.chart = new DataCube({
      ohlcv: this.mock,
      onchart: [
        {
          type: 'BB',
          name: 'BBL',
          data: []
        }
      ]
    })
  }
}
</script>

Data Sample
The data sample os on code above.
Console errors (if any)
Shown on image below.
Additional Info
Using:
"trading-vue-js": "^0.7.0",
"tvjs-overlays": "^0.2.1",
"vue": "^2.6.12"

@adsonvinicius I had the same issue. What I did was remove this part  conf: { renderer: 'Spline' }, and copied the Spline code from Spline.vue file and paste it to draw() method on particular overlay file (2nd image). (Here I'm taking SMA.vue as an example) FYI @C451
I've no idea why it's happening :D but just sharing here in case you want make it work until bug fix.
1st image -

2st image -

@akjcodes yep, this bug is a consequence of hacking vue.js. I use a dynamic mixin which isn't actually allowed by the frameworks. Interesting, how well it will translate to Vue 3.

Great.  About the fix I tried to clone and rebuild from GitHub but throws this error:
    ERROR in ./src/helpers/script_ww_api.js
    Module not found: Error: Can't resolve './tmp/ww$$$.json' in '/trading-vue-js/src/helpers'
     @ ./src/helpers/script_ww_api.js 7:0-43 32:41-52
     @ ./src/helpers/dc_events.js
     @ ./src/helpers/dc_core.js
     @ ./src/helpers/datacube.js
     @ ./src/index.js

Do I need anything different from npm install to rebuild?

@adsonvinicius is it working (even with this error)?

@C451  I replaced the dist files on node_modules folder and is working fine, just on the rebuilding I'm getting this error.

@adsonvinicius it should appear once (ww$$$.json is compiled version of the web worker code, I excluded it from the repo)

I see, so there's no problem about creating this json file with [] content for rebuild purposes?

@adsonvinicius well, it should be auto-generated on the first npm run dev or npm run test
https://github.com/tvjsx/trading-vue-js/blob/master/webpack/ww_plugin.js#L32
without it no ww

I see, I will clone the repo and redo step-by-step and check what's going on. Thanks!

Redoing step-by-step I figured out when I run npm install and npm run build, and replace the dist files on node_modules/trading-vue-js directory the overlays are not working, however when I replace the dist files (from 0.8.0-alpha) on my node_modules/trading-vue-js directory, it works.

@adsonvinicius I added a check https://github.com/tvjsx/trading-vue-js/blob/master/webpack/build.config.js#L17

@adsonvinicius  Did you added the data format similar to this? https://github.com/tvjsx/tvjs-overlays/blob/master/src/overlays/SMA/data.json

@akjcodes, yes, you can check my data format on my post (the first one), it works fine when I just add the library from npm/yarn.
My problem is that I need to rebuild the library (due to another issue which is being done for v 1.0) when I do this.

No worries bros, npm run dev should also work now.


Fogcell not executable

Hello,
as part of my project seminar at the university we try to use your FogFrame System. Currently we cannot run the Fogcell module because we always get the error message that the Bean propertyService cannot autowire because of missing dependencies.
The error log is attached.
Thank you.
Paul
fogcell.error.log

Dear Paul,
it is hard to say what the problem is by such a description. Please read about the dependencies and overall installation approach in the http://www.infosys.tuwien.ac.at/staff/sschulte/paper/Bachmann_Master.pdf that pdf describes in details the previous version of the framework https://github.com/keyban/fogframe (the difference is that this one establishes one fog colony). Maybe you can use this previous version, because it is described in details.
In general, the whole folder has to be built first on your computer. The dependencies (i.e., fogdata) have to be installed in local maven repository.
Then files that indicated in Dockerfile have to be copied to according raspberies together with the Dockerfile itself, and started inside Raspberry with run.sh or remote, like in https://github.com/softls/FogFrame-2.0/blob/master/run_scripts/start-all-raspberries.sh. Databases with startdb.sh have to started before fog cells and fog node. Fog controller has to be started first (you can do that locally). Fog node has to be started second, then fog cell.
Small hint. To start a fog cell/fog node/fog controller locally not in docker, try set in  fogcell/src/main/resources/application.properties  fog.docker = false, and change the according ip addresses.

Thank you for your answer.
Currently I want to test everything on 1 RPI. But I can tell you how I modify and execute the project. I do everything on the RPI directly.

edit all application.properties and main.properties and change the IP-addresses
edit POM file in fognode and added repos for net.sf.javailp and cplex.cplex
download openjdk-8-jre-headless_8u40~b04-2_armhf.deb and save it in all run_scripts/fog* folders
build project with mvn clean install
copy every jar in run_scripts/fog*
start startDbs.sh
start fogcontrolnode
start fogcell (error)

Thank you.
Paul

Thank you for your answer.
Currently I want to test everything on 1 RPI. But I can tell you how I modify and execute the project. I do everything on the RPI directly.

edit all application.properties and main.properties and change the IP-addresses
edit POM file in fognode and added repos for net.sf.javailp and cplex.cplex
download openjdk-8-jre-headless_8u40~b04-2_armhf.deb and save it in all run_scripts/fog* folders
build project with mvn clean install
copy every jar in run_scripts/fog*
start startDbs.sh
start fogcontrolnode
start fogcell (error)

Thank you.
Paul

In your step 2, how did you edit the POM file in fognode and added repos for net.sf.javailp and cplex.cplex?
I am having difficulty building the fognode module.

Dear colleagues,
The project has to be built in the root directory. So you have to run
mvn install
command inside the FogFrame folder. Then it builds all the components and a cording jars are located in target folders in each component. It is necessary because the component FogData is included in each component, so it has to be installed in the local mvn repository.
If you compile only single component, make sure you run mvn install fogdata beforehand.
Neither cplex nor net.sf.ilp will run on the rpi processor architecture, unfortunately. I abandoned that idea. When I tried that in my time, it appeared that those libraries are not comped for the ARM processor architecture, the was a  post about that https://www.ibm.com/developerworks/community/forums/html/topic?id=6e43017f-39c4-40b6-9b69-695f89a13624  libraries are built for Intel x86-64.
You might consider to develop resource provisioning functionality as a service, maybe, inside a fog controller. So that when a fog node needs to run an algorithm using cplex, it sends inputs to the fog controller by REST request, and fog controller calculates service placement plan and sends back the assignments. That would require reworking the architecture in general.

Dear colleagues,
The project has to be built in the root directory. So you have to run
mvn install
command inside the FogFrame folder. Then it builds all the components and according jars are located in target folders in each component. It is necessary because the component fogdata is included in each component, so it has to be installed in the local mvn repository.
If you compile only single component, make sure you run mvn install fogdata beforehand.
Neither cplex nor net.sf.ilp will run on the rpi processor architecture, unfortunately. I abandoned that idea. When I tried that in my time, it appeared that those libraries are not compiled for the ARM processor architecture, the was a post about that https://www.ibm.com/developerworks/community/forums/html/topic?id=6e43017f-39c4-40b6-9b69-695f89a13624 libraries are built for Intel x86-64.
You might consider to develop resource provisioning functionality as a service, maybe, inside a fog controller. So that when a fog node needs to run an algorithm using cplex, it sends inputs to the fog controller by REST request, and fog controller calculates service placement plan and sends back the assignments. That would require reworking the architecture in general.

I am building the project from the root itself. Just when the fognode module is building, I get an error saying ilog:cplex:jar:1270 is missing. What am I doing wrong?

You have to add your cplex jar in local maven repository, and add in pom file in fog controller and the project. Then you can try building.
Assuming that all above works, you also will have at some point to edit the Dockerfile of fog controller itself to add cplex jar file. And that jar has to be copied to the same folder from where you plan to start docker container.
Note: if you want to start fog controller it on Raspberry Pi, cplex functionality will not work any way.


Remove sign up being blocked between cycles

Context
At the moment, if a candidate arrives on Apply and tries to sign up after the apply1 deadline they are told to come back and sign up  when the new cycle launches.
This is no longer needed as we carry over applications earlier on. They should be able to sign in and amend their application, but not be able to add courses or submit their application
Changes proposed in this pull request

Remove the redirection to the applications closed page
Remove the applications closed page

Guidance to review
Probs worth setting the schedule to the after the apply1 deadline and checking sign up works as intended
Link to Trello card
https://trello.com/c/w7djfHdv/3756-remove-blocking-signup-between-cycles
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

Yea that's all affected by the cycle switcher. The dates in prod use the CycleTimetable and will line up with the dates in the calendar 👍


Consider Switching to Py.test

Pytest is a Python test runner/library that lets you write powerful, concise tests with no boilerplate. It can run unittest, nose and doctest style tests and has over 100 plugins for easy integration with
many frameworks, editors and CI servers.
Boilerplate code like below can be eliminated from test case files from jinja2
# snippet from jinja2/testsuite/bytecode_cache.py
def suite():
suite = unittest.TestSuite()
suite.addTest(unittest.makeSuite(ByteCodeCacheTestCase))
return suite

Also the loaders like BetterLoader can be eliminated because py.test discovers test cases. Tests can be filtered by using options like py.test -k expr  to run tests matching expression.
py.test test_mod.py   # run tests in module
py.test somepath      # run all tests below somepath
py.test -k stringexpr # only run tests with names that match the
                      # the "string expression", e.g. "MyClass and not method"
                      # will select TestMyClass.test_something
                      # but not TestMyClass.test_method_simple
py.test test_mod.py::test_func  # only run tests that match the "node ID",
                                # e.g "test_mod.py::test_func" will select
                                # only test_func in test_mod.py

http://pytest.org/latest/usage.html
Tests can be run parallely using xdist plugin.
List of 3rd party plugins can be found at http://pytest.org/latest/plugins_index/index.html
Note: This issue is raised as part of 'adopt pytest month' initiative. http://pytest.org/latest/adopt.html

+1

Yeah, this is definetly planned. Pull requests welcome!

for pr and migrating to pytest, prs should be send with converted tests written in pytest? what are the plans?

Well, to be honest, there is no real plan. But I'd definetly merge a PR in the style of https://github.com/mitsuhiko/flask/pull/1165

thats a very good reference to follow! would be very helpful! will try to send a PR in WIP mode then!

Thanks!
Note that the checklist there is just a milestone-ish thing I was following... on the way I also converted multiple helper methods/functions to fixtures, whatever looked better.

okey. jinja2 have less  tests then flask? I think so

Not sure. Just start somewhere... if you get tired of it, I'm sure me or somebody else could continue.

It seems that this has been suddenly tackled by @lkarthee: https://github.com/mitsuhiko/jinja2/pull/426
@lkarthee In the future, please leave a quick note if you're going to start on this, otherwise effort is duplicated.

@untitaker Sorry my mistake.

Fixed by #426.


path/filepath: TestBug3486 fails if GOROOT/test is removed

What version of Go are you using (go version)?

$ go version
go version go1.11.4 linux/amd64

Does this issue reproduce with the latest release?
Yes, 1.11.4 is the latest (not counting betas?).
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ionasal/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ionasal/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build457575040=/tmp/go-build -gno-record-gcc-switches"

What did you do?
mkdir -p /tmp/tmp3
cd /tmp/tmp3
go mod init example.com/test
cat >main.go <<EOF
package foo

import (
	_ "path/filepath"
)
EOF
go test all

What did you expect to see?
All tests pass
What did you see instead?
Test failures:
--- FAIL: TestBug3486 (0.00s)
    path_test.go:1268: lstat /usr/lib/go/test: no such file or directory
FAIL
FAIL	path/filepath	0.013s

(I found a bug for the same test, but the failure mode is different: https://github.com/golang/go/issues/5863)

I took a little bit of time to see if I could fix this, and ironically, the reason this test is using the GOROOT/test subdir is to work around another stdlib test bug https://github.com/golang/go/issues/28387 that is also causing go test all to fail.
This test was originally written for https://github.com/golang/go/issues/3486 and only check GOROOT/lib and GOROOT/src.  It was changed to use GOROOT/test in https://github.com/golang/go/commit/5dc8c4dbfb6a04d9eb7a11c9c3fe698d33d0c0ee because the os tests write files into GOROOT/src causing a race.  But it is exactly this behavior also causing os tests to fail in https://github.com/golang/go/issues/28387.
So I will postpone fixing this bug until https://github.com/golang/go/issues/28387 is resolved.

Looks like there's now another std lib test that depends on GOROOT/test existing. Failure if it's deleted:
--- FAIL: TestImportTypeparamTests (0.00s)
    gcimporter_test.go:168: open /workdir/go/test/typeparam: no such file or directory
FAIL
FAIL	go/internal/gcimporter	0.482s
FAIL


Fix code scanning alert - Uncontrolled data used in path expression

Tracking issue for:

[x] https://github.com/tugcantopaloglu/juice-shop/security/code-scanning/59

This doesn't lead to any issue.


The build is failing here, and it's probably failing our linting check (checks to make sure code is formatted correctly)


proposal: all: reaffirm "not obviously wrong" for +1 or otherwise clarify its meaning

Issue
There are at least two published definitions in the Go project for the meaning of +1 on a Gerrit review, with the more recent definition on the GerritAccess wiki page seeming to set a higher bar than the earlier and still published definition on the Gardening wiki page.
Details
Gardening page
The Gardening wiki page currently includes this (added by Brad in early 2017):

Pending CLs
Review the format of commit messages and presence of tests and formatting of code and typos/grammar in incoming pending CLs. All of that can be done without determining the correctness of the change itself. [...]
Once it has a +1, the owner of that area can give it a +2.
Read a +1 as meaning "triaged", or "not obviously wrong". If it has tests, is formatted properly (references a bug number, probably), and is ready for more review, give it a +1.

GerritAccess page
The GerritAccess wiki page currently includes this (introduced by Russ in 2022 (as part of the compliance and supply chain security code review requirement changes):

A Code-Review+1 vote means that you have read the change and believe it seems reasonable but aren’t making the definitive judgement that Code-Review+2 indicates. It also means you are confident the change does not introduce any sort of security vulnerability or other clearly inappropriate code change.

The second sentence in that quote (especially the use of "confident" and "any sort of") reads to me as a substantially higher bar than "not obviously wrong". (One example is a non-obvious performance problem that could turn into a denial-of-service security issue, which can be tough for a casual contributor to feel confident is not present).
Most of the second sentence was taken directly from the older and now replaced language describing Trust+1:

A Trust+1 vote means that you have read the change and are confident that the change does not introduce any sort of security vulnerability or other clearly inappropriate code change. As long as you are sure about that, it's OK to Trust+1 a change even if you don't fully understand all the details of the change.

Contribution Guide
There is another mention of +1 in the Contributing Guide (which looks to be purposefully making a higher-level statement):

As they near a decision, reviewers will apply a Code-Review “vote” to your change. There are two possible votes:
[...]

+1 The change looks good, but either the reviewer is requesting minor changes before approving it, or they are not a maintainer and cannot approve it, but would like to encourage an approval.
[...]
Finally, to be submitted, a change must have the involvement of two Google employees, either as the uploader of the change or as a reviewer voting at least Code-Review +1. This requirement is for compliance and supply chain security reasons.

Suggestion
Ideally, the "not obviously wrong" meaning would be reaffirmed. It could be strengthen with "and does not contain a clearly inappropriate code change", or something similar.
If that sets the bar too too low for compliance and security reasons, then perhaps the definition could be split between what a +1 means for a Googler on the core Go team vs. the meaning for an external contributor giving a +1.
Alternatively, perhaps a new "triaged" vote or similar could be introduced with a meaning closer to "not obviously wrong", or some other solution.
Rationale
It is already somewhat intimidating to think about contributing to a project as large and successful as Go.
Beginning some form of interaction with Gerrit is a great on-ramp to becoming a more active contributor, whether it starts by lurking, or just subscribing to some interesting CLs via the star icon, or making a drive by comment to another new contributor, or actually reviewing a CL.
The prospect of being able to do something as useful as give a +1 is a draw for someone to register for Gerrit, even if they then only use their Gerrit registration for a while for more passive things like starring CLs. (For me personally, I lurked on Gerrit for a long-ish time before I ever registered there, but a "gardening" pitch I heard from Brad in a talk or podcast is a large part of what got me over the hurdle of registering).
Once someone has interacted with some CLs (comments, or just starring), the ensuing notifications spread out over time then offer multiple chances for something interesting to arrive in the potential contributor's inbox when they are not otherwise busy.
There are material benefits for the potential contributor as well when they engage in Gerrit, including improving their own development skills by seeing the rigorous processes of the Go project for code reviews and testing and its approach to software engineering. A deeper understanding of the internals of things like the runtime, compiler, and tools helps in their day-to-day use of Go. If they do later choose to more actively contribute, that can help career development.
I'm hoping the Go project continues to encourage triage-level reviews from outside contributors. It is a true virtuous circle, where the benefits integrated over time are substantial even if point-in-time benefits are sometimes hard to observe (e.g., the confusing bug report that was never written because someone had deepen their understanding of Go after starring & following a handful of CLs).

I'm not sure this needs to be a proposal.
I tend to think that a +1 vote should mean "not obviously wrong" and also "does not introduce a security vulnerability."  I agree that that is a higher bar, but it seems to me that it's not a much higher bar.  Most changes obviously do not introduce a vulnerability.  And if you aren't sure whether it does or not, that seems like a reasonable indication that it's not a good change for you to review.
As a separate comment, we should explicitly discourage a +1 vote after the change has been submitted.  Those do happen from time to time, and serve no useful purpose.  I'm happy to encourage people to read old changes, and comment on them if they see something, but not to vote on them.

As a separate comment, we should explicitly discourage a +1 vote after the change has been submitted. Those do happen from time to time, and serve no useful purpose.

I agree that drive-by +1 reviews from unexpected reviewers are generally not helpful, but I do occasionally leave those votes to record that I have actually reviewed a CL submitted while I was not available to review it, when I am already listed as a reviewer or might otherwise be expected to have particular context for the change.

I'm taking this out of the proposal process, I don't think it needs that kind of review.  Thanks.


DraggableFromAnywhere improvement

added setDraggableFromAnywhere to both scrollbars
don't consume the touch if setDraggableFromAnywhere is false + the wrong region is touched in ondown touch event

Anything speaking against this change?
For solving this issue https://github.com/turing-tech/MaterialScrollBar/issues/57 maybe a small adjustments to care about the respondToTouch should be added as well (just the same way as the valid flag is checked now), but I'm not using this flag and not sure if it's ment for what I think it's ment for, so it's up to you to additionally add this
With this change I can make some first useable implementation in a CoordinatorLayout as well...

Looks good.

you don't need to care about the first commits, I've reverted them all because making MaterialScrollBar public destroys the need for the interface...


[Question]: Non-AVX CPU

Description
Similar to #539, I have a non-AVX AMD A6-3650 APU that doesn't support AVX.  The machine it is in is fantastic, even though it is at least 11 years old and performs exceedingly well, with presently 8GB RAM (soon to be 16GB and getting a processor upgrade soon to AMD Athlon II X4 651K 3 GHz Quad-Core).  I have a RTX 3070 in this machine to use the GPU for TensorFlow I was going to use this as my development computer.
However, I keep getting errors when trying to run my net using TensorFlow.NET.  I'm new at TF, so maybe I've got something wrong, but a basic console program works.

using System;
using Tensorflow;
using static Tensorflow.Binding;
namespace TensorFlowTest
{
class Program
{
static void Main(string[] args)
{
// The following code will use GPU if it's available,
// because TensorFlow.NET automatically uses GPU if it's available.
        // Initialize TensorFlow
        tf.compat.v1.disable_eager_execution();

        // Create a new graph
        var graph = tf.Graph().as_default();
        var sess = tf.Session(graph);

        try
        {
            // Create a constant tensor
            var tensor = tf.constant(10.0f);

            // Execute the tensor and print the result
            var result = sess.run(tensor);
            Console.WriteLine($"The result is: {result}");
        }
        finally
        {
            //sess.Dispose;
        }

        Console.ReadKey();
    }
}

}

2023-05-19 10:20:08.015490: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1616] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 5511 MB memory:  -> device: 0, name: NVIDIA GeForce RTX 3070, pci bus id: 0000:01:00.0, compute capability: 8.6
I was wondering if the TF.NET is requiring AVX or if you know of anything reason why I get errors on the machine but not my Surface Pro 7.  My main program is in VB.NET btw.
Alternatives
No response

I just discovered if I enable
tf.compat.v1.disable_eager_execution()
in my constructor that it now runs on my ancient APU.

Hi, since I don't have a non-avx cpu, could you please give a more detailed description? If I was not mistaken, when you run the console app, it will use cpu instead of gpu?

Sorry, here's the story.
I have a program I'm writing in VB.NET.  Works fine on a Surface Pro 7.  I tried to run it on this AMD A6 machine and it get crashing when initializing the model.  I think it used to work before installed the RTX 3070, but just crashes now.  I tried a simple code (as above) to just see if it would initialize and use the GPU which it did.  Then I noticed that the sample code (GPT generated) uses the line tf.compat.v1.disable_eager_execution which my VB.NET code did not have.  So I tried adding that same line to my VB.NET app and now my app is working on the AMD A6 machine, apparently with the GPU.
So now I guess it's a new question:  Why will eager mode not work on my old AMD A6 machine?  Is it because of it not have AVX or is it something else?  Will disabling eager execution impair performance in any way?

Thanks for your feedback. Is the system x86_64?

Yes, both systems are 64 bit.  The Surface Pro 7 is Windows 11 Pro 64 bit and the AMD A6 is running Windows 10 Pro 64 bit.

Will disabling eager execution impair performance in any way?

It could impair it in some conditions but just take it easy. According to some tensorflow documents I read before, the eager mode and graph mode has closed performance. Besides, sometimes eager mode is better than graph mode but sometimes it's exactly the opposite.

Why will eager mode not work on my old AMD A6 machine? Is it because of it not have AVX or is it something else?

Since the program crashed, I'm not sure about it. However I could try to help you to find the problem. Could you please clone the repo and change the reference of tensorflow.net from nuget package to TensorFlow.Core/Tensorflow.Binding.csproj? Maybe it will give you some information when you debug it.

Ok.  I've had some interesting things happen.

Sometimes it works.  However, the last time I tried it, my app didn't work with the GPU the first time after I rebooted the computer.  I actually had to start the C# test app first, which I guess activated the GPU connection somehow and then my app was able to use it.
After rebooting, the app didn't crash.  I tried various versions of the TensorFlow.NET package (including the csprog) and it worked fine.
This morning I came back and started trying it out again.  It is crashing again.  Here is where it is crashing at:
tensorflow.cs Line 107
=> new ResourceVariable(data,
trainable: trainable,
validate_shape: validate_shape,
name: name,
dtype: dtype,
aggregation: aggregation,
shape: shape);

Sorry for the late reply. I've searched the issues of tensorflow but found few related thing. However, here's some tips that may help, I guess.
At first, please check the cuda version by nvcc -V and ensure it's cuda11.x ( >=11.2 for best). Then please ensure you have installed cudnn 8 (by checking C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.7\include\cuda_version.h).
After that, please ensure only one redist package is installed for the project.
Then have a try with eager mode, for example using the code below:
var a = tf.ones((2, 3));
var b = tf.ones((3, 4));
Console.WriteLine(a * b);

If it still keep crashing, please try with Tensorflow.Redist to run on CPU only to see if the problem is related to gpu settings (I sus it may not be AMD's problem).
Finally, please install Tensorflow.NET <= 0.100.2 and Tensorflow.Redist.Windows-Gpu == 2.10.0 and have a try. The redist package of windows after v2.10.1 are built from source by ourselves and it may cause the reason (though I don't know how it could cause the problem).

hi, is this error still triggered?


Update index.js

What problem does this PR solve?
Reorganize the text shown on the documentation website
What is changed and how does it work?
Change a paragraph into the unordered list

@cwen0 @dcalvin

Codecov Report

Merging #621 into master will decrease coverage by 0.12%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   55.78%   55.65%   -0.13%
==========================================
  Files          68       68
  Lines        4383     4393      +10
==========================================
  Hits         2445     2445
- Misses       1768     1778      +10
  Partials      170      170

Impacted Files
Coverage Δ

controllers/networkchaos/ipset/ipset.go
37.14% <0.00%> (ø)

pkg/store/experiment/experiment.go
32.20% <0.00%> (-6.58%)
:arrow_down:

pkg/utils/chaosdaemon.go
51.21% <0.00%> (ø)

pkg/utils/grpc.go
0.00% <0.00%> (ø)

controllers/networkchaos/netem/types.go
47.27% <50.00%> (ø)

controllers/podchaos/containerkill/types.go
64.38% <100.00%> (ø)

controllers/timechaos/types.go
61.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83d814...e86f7ad. Read the comment docs.

/merge


HOTFIX: Changes necessary to deploy React build

No issue as these are necessary fixes that needed to be completed on the spot for the build to deploy to S3.

LGTM!

Type error causing CI tests to fail.
Error messages pop up:
Error: Uncaught [TypeError: Cannot read property 'dataSample' of undefined]
TypeError: Cannot read property 'dataSample' of undefined
>  8 | const dataSample = useSelector(state => state.root.dataSample);

We can leave this open until it's resolved, but I think this is an error with our current package management. Even a fresh install of master fails these tests now.
I think we should be more diligent about ensuring everyone is using yarn, and that every PR is rebased off the most current master. Babel 7.8.7 has been sneaking back in constantly, and will break tests/builds as it was a broken release

Great points @SomeMoosery. Working on the CONTRIBUTING.md and adding the language around rebasing off the current master.
I will add the information to alert the devs only to use Yarn.

Actually, while it's good we stay up to date in our package.json of course, this also looks to be a more systemic problem. It's create-react-app's pinned issue right now


GH10: Implementing Support for .NET Core

The code have thus far not been tested on Linux and OSX (or travis to be exact).
Currently it's expected to fail on Linux/OSX during either build, or unit testing.

@AdmiringWorm is this marked as WIP due to the lack of testing on LInux and OSX?  If so, then I would be happy to YOLO this just now, and carry out some further testing with re-work if required.  I know for a fact that Cake.Recipe isn't working on Travis just now due to another issue, so the changes that you have here won't work until that is corrected.  Happy to have .NET core support on work on AppVeyor just now, and then extent out from there.
Thoughts?

Yes, it's mainly because of lack of travis testing.
But also because I have a feeling I'm missing something, but can't for the life of me think of what.
I do now it currently works on appveyor though, as can be seen here: https://ci.appveyor.com/project/cakecontrib/cake-codecov/build/0.2.1-using-cake-recipe.1+19.build.26
So I don't mind it being merged, I'll remove the WIP for now though.

@AdmiringWorm ok, cool.  I will take this for a proper spin tomorrow lunch time on the Cake.HockeyApp repo, which is where I started doing the conversion to support .NET core.

Sounds good, but before you do. I'll be renaming one of the added arguments to a more generically named one so it can be reused.
I added a argument to compile source nupkg packages using dotnet pack, I'm thinking to perhaps rename that variable and use it to decide whether to generate source nupkg packages through the non-dotnet task as well.

@AdmiringWorm how does that work with GitLink which is currently being used in Cake.Recipe.  This allows for linking the source files directly to the GitHub repository where it is hosted, therefore you don't need to include the source files within the package.

Honestly, I don't know. I've never used GitLink.
But I'm thinking of it as an alternative for those that don't use GitLink, but are using the SymbolSource server instead.

@AdmiringWorm yip, I would have no objection to that 👍

Also, it won't include the source inside the normal package, but rather a separate package that will be uploaded to symbolsource.

Of course, would need to add some code to the task that publishes nupkg packages to nuget.org so it ignores packages ending with symbols.nupkg (I think that was the name), as they will automatically be pushed to the correct destination anyhow.
Not sure how to handle MyGet though.

So, only thing I would add is that "I think" GitLink always runs currently, so we should probably switch to make that fully configurable, allowing the user to control what is run.

@AdmiringWorm said...
Not sure how to handle MyGet though.

I "think" this just works, but I would have to check, been a long time since I have done anything with that.

So, only thing I would add is that "I think" GitLink always runs currently

You do have the option to turn of GitLink though, by setting shouldExecuteGitLink to false
Anyways, these are changes that should be done in a separate PR IMO, so for now I'm just renaming the parameter.

@AdmiringWorm said...
Anyways, these are changes that should be done in a separate PR IMO, so for now I'm just renaming the parameter.

Agreed.

@gep13 I opened #112 in preparation to adding the logic necessary for creating symbol/source packages.

@gep13 any reason why the wyam task would fail after this PR was merged?

This is a known issue that @pascalberger noticed, and which I thought I had fixed.  Was actually just speaking to @devlead about it, as it is linked to his Cake.Git addin.
Nothing for you to worry about in this PR, but something that may need to be re-investigated.

This was the issue in question...
https://github.com/cake-contrib/Cake.Recipe/issues/104


vpn not working on reboot

hi, cpriest,
sorry if i open a new post.
I know what mean "Inactivity timeout (--ping-restart), restarting", the strange thing is that when the script is working fine i never recive ping restart.. the ping restart is recevied when UDM restart and openvpn script is not working correclty.
I need to turn off vpn server on UDM gui (as you suggested), restart the UDM with VPN down and then turn on VPN on UDM gui,..
Whit this procedure i will not recive any ping restart, all is working fine. The error is connected with UDM reboot.
Tnx for your help and sorry

So this only happens
  upon reboot.  If you go disable the VPN and re-enable it comes
  back up fine and stays up?

On 2/9/2021 12:46 PM, franke2 wrote:

  hi, cpriest,
    sorry if i open a new post.
    I know what mean "Inactivity timeout (--ping-restart),
    restarting", the strange thing is that when the script is
    working fine i never recive ping restart.. the ping restart is
    recevied when UDM restart and openvpn script is not working
    correclty.
    I need to turn off vpn server on UDM gui (as you suggested),
    restart the UDM with VPN down and then turn on VPN on UDM gui,..
    Whit this procedure i will not recive any ping restart, all is
    working fine. The error is connected with UDM reboot.
    Tnx for your help and sorry
  —
    You are receiving this because you are subscribed to this
    thread.
    Reply to this email directly, view it on GitHub, or unsubscribe.
  [

{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/cpriest/udm-patches/issues/6",
"url": "https://github.com/cpriest/udm-patches/issues/6",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

tnx for your answer,
openvpn was running from some days without any problem or disconnection; I tried as suggested to stop and re-enable the vpn. same error like on reboot :( the vpn start but it not work also if sequence is completed and seams connected (I can't ping any remote address and after 2 min i recive ping restart).
To get it work back i need to turn off vpn, restart the router and then re-enable the vpn on udm web-gui.
Whit this procedure it work without any problem until a reboot or a vpn restart.
tnx for support  cpriest, hope you have a solution :)

yeah, I'm sorry I have no idea where the problem is at.


ViewBuilders and EventExtenders support Promises next to callbacks

Thanks for your valueable PRs...
But for these cqrs modules I don't want to support Promises... at least not in this major version 😉
I would design the whole thing a bit differently...
But thanks anyway...

Alright. To stick with your repos I'll have to find another way then, I guess :)


Update rust.yml

I'm stupid, GitHub Actions only read the main branch workflow files.

I actually don't do that dqsl?FNpo^qJNFop^qsndof^pnqsdOP FJeôpqsGHJpêsqo.
It's late.


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests:

https://github.com/Senzing/stream-producer/pull/151


Import Cocoa private hybrid SDK headers directly

Hybrids SDKs, when using PrivateSentrySDKOnly class, will need to explicitly import <Sentry/PrivateSentrySDKOnly.h> alongside <Sentry/Sentry.h> starting with the next major release. The explicit import can already be added.
see https://github.com/getsentry/team-mobile/issues/66

Hybrids SDKs, when using PrivateSentrySDKOnly class, will need to explicitly import <Sentry/PrivateSentrySDKOnly.h> alongside <Sentry/Sentry.h> starting with the next major release. The explicit import can already be added.
see getsentry/team-mobile#66

Since both Flutter and Capacitor uses Swift to interact with the Native SDK, it might be a good idea to wait for the Flutter SDK to implement this change and then "port" it to Sentry/Capacitor, this will avoid different teams spending time on the same problem.
See https://github.com/getsentry/team-mobile/issues/66#issuecomment-1300304401

Closed by https://github.com/getsentry/sentry-capacitor/pull/259


Port to vite

Status
Bootswatch needed to be removed due to SASS issues. The UI still looks pretty much the same, but colors are wrong.
This PR might also be used to solve #116 as a result.
Items to test:

[ ] Production build
[ ] CI
[ ] Check that all UI still works correctly
[ ] Fix unit tests

I revamped a large portion of the UI, though a lot of things are broken (since i'm making a lot less stuff use bootstrap and instead use Tailwind). Note that the dark theme was just a thing i copypasted from another project and a light theme can be added super easily when its needed.

for me, getting rid of erb is a positive - very curious to see how it all hangs together in the end

the size of the diff doesn't worry me, I'm more interested in why choices were made - like replacing higherlevel components with plain div with classes - that always feels like a backward step to me.
very much needs docs to tell us what changed, and how new devs build, run and ship things.
(and presumably we're still waiting on your todo's in this pr)

Much of the layouting pains in the bootstrap version of the app was due to use of Rows incorrectly. Due to Rows containing gutters, it would misalign things because of the negative margin. Tailwind goes for a more simplistic approach by providing atomic classes for your styles. This is more nice than higher level components because:
a) its closer to bare HTML and CSS which may seem like a downside but makes it easier to reason about when it comes to layouting issues
b) more compatible with tailwind's spacing styling. Bootstrap's layouting is very similar to Tailwind's, Tailwind's is just much larger and closer to the original CSS styles.
While bootstrap's Rows and Cols and such appear to be helpful, they also make customizeability much more of a challenge and introduce more room for issues. I've learned its easier honestly to just do the layouting with raw divs, at least as long as Tailwind is there to provide easy atomic classes for it.


Bug: Chain Mismatch In Template App

Describe the bug and the steps to reproduce it

Go to the onchain provider of the template app and notice how it is using the base mainnet chain
Go to the wagmi provider of the template app and notice how it is using the base sepolia chain

What's the expected behavior?
The chain that is used in the template should be consistent or at least supported in the wagmi config depending on the intent of the template.
What version of the libraries are you using?

OnchainKit 0.28.7

Solved :)
Thank you @mykcryptodev


[Proposal] Add factories for filled, tonal, outlined icon buttons as per material 3 guidelines

Proposal
Add factories for FilledIconButton, FilledTonalIconButton, OutlinedIconButton to respect m3 guidelines.
Relevant: #103528, #104357

Hi @akshdeep-singh, are these the factories that you are referring to?
https://master-api.flutter.dev/flutter/material/FilledButton/FilledButton.icon.html
https://master-api.flutter.dev/flutter/material/FilledButton/FilledButton.tonal.html
https://master-api.flutter.dev/flutter/material/OutlinedButton/OutlinedButton.icon.html

Hi @danagbemava-nc, no I am not referring to them.
If you check, below 3 are different:

ElevatedButton
ElevatedButton.icon()
IconButton()

I am talking about IconButton here.

@QuncCccccc, @darrenaustin - perhaps the solution here is the "variants", as we've discussed for the button classes.

Rather than creating a bunch of classes for this we could instead opt for IconButton.filled, IconButton.outlined, etc factory constructors that just configure the icon button as needed for the variant. For theming we could do something similar to what is described here https://github.com/flutter/flutter/issues/107946#issuecomment-1193422262.

#107946 (comment)

Yes, that would be great. Is there an ETA for that? I saw that first issues regarding the "missing" buttons started since April

FYI I've updated this proposal to reflect the desired solution

Having ready made factories to easily create the different M3 IconButton styles depicted in the Material 3 guide and specification, would be very useful and save a lot of time in many projects.
https://m3.material.io/components/icon-buttons/overview

Same applies to Cards:
https://m3.material.io/components/cards/overview

For the common Material buttons we got them in Flutter 3.7. Apparently there was a change of views on it after this discussion and rationale https://github.com/flutter/flutter/issues/104357#issuecomment-1151725647
Same applies here to IconButton and Card.

I find it strange that the "support" for these types of buttons and cards are literally just making them yourself. Definitely need constructors.


Create additional labels

Magnum
Monitoring

Terraform Format and Style 🖌success
Terraform Initialization ⚙success
Terraform Validation 🤖success
Validation Output

Success! The configuration is valid.

Terraform Plan 📖success
Show Plan

undefined

Pusher: @cityofships, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub


Layout break

When the name is large breaking the layout.

Thanks for reporting!
It was fixed on #12, just hasn't been released yet...


building the tdlib project in java

hello when i try to build a java project i get the following error:
when i try to build a java project i get the following error:
`MSBuild version 17.5.1+f6fdcf537 for .NET Framework
Generating Java TDLib API source files
  Building Java code
  C:\Users\T\Desktop\t\td\example\java\org\drinkless\tdlib\Client.java:229: warning: [removal] finalize() in Obje
  ct has been deprecated and marked for removal
      protected void finalize() throws Throwable {
                     ^
  1 warning
  Generating Javadoc documentation
  Loading source files for package org.drinkless.tdlib...

CUSTOMBUILD : error : No source files for package org.drinkless.tdlib [C:\Users\T\Desktop\t\td\example\java\build
\generate_javadoc.vcxproj] D:\N\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(247,5): error MSB8066: custom assembly for "C:\Users\T\Desktop\t\td\example\java\build\CMakeFiles\38a1aee34003018bfa3f2a5c470b9fa0\generate_javadoc.rul
e;C:\Users\T\Desktop\t\td\example\java\CMakeLists.txt" exited with code 2.
 [C:\Users\T\Desktop\t\td
\example\java\build\generate_javadoc.vcxproj]`

this happens after trying to enter:
etc\td\example\java\build> cmake --build . --target install
*I have windows x64

  C:\Users\T\Desktop\t\td\example\java\org\drinkless\tdlib\Client.java:229: warning: [removal] finalize() in Obje
  ct has been deprecated and marked for removal
      protected void finalize() throws Throwable {
                     ^
  1 warning

This is a warning and not an error. Also, finalize usage is absolutely correct in the class and it is sad that Java forces us to remove it, because someone used it incorrectly.
Did you follow https://tdlib.github.io/td/build.html?language=Java?

CUSTOMBUILD : error : No source files for package org.drinkless.tdlib [C:\Users\T\Desktop\t\td\example\java\build
\generate_javadoc.vcxproj] D:\N\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(247,5): error MSB8066: custom assembly for "C:\Users\T\Desktop\t\td\example\java\build\CMakeFiles\38a1aee34003018bfa3f2a5c470b9fa0\generate_javadoc.rul
e;C:\Users\T\Desktop\t\td\example\java\CMakeLists.txt" exited with code 2.
[C:\Users\T\Desktop\t\td
\example\java\build\generate_javadoc.vcxproj]`

that's the problem, not the finalizer
CUSTOMBUILD : error : No source files for package org.drinkless.tdlib [C:\Users\T\Desktop\t\td\example\java\build
\generate_javadoc.vcxproj] D:\N\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(247,5): error MSB8066: custom assembly for "C:\Users\T\Desktop\t\td\example\java\build\CMakeFiles\38a1aee34003018bfa3f2a5c470b9fa0\generate_javadoc.rul
e;C:\Users\T\Desktop\t\td\example\java\CMakeLists.txt" exited with code 2.
[C:\Users\T\Desktop\t\td
\example\java\build\generate_javadoc.vcxproj]`

This is not the problem. It is consequences of failures on previous steps, or the files at C:\Users\T\Desktop\t\td \example\java\org\drinkless\tdlib were deleted somehow. The full log for all commands from https://tdlib.github.io/td/build.html?language=Java should contain the cause.


Upgrade @actions/cache dependency and remove workaround

The linked issue has been fixed upstream. Updating to the version containing the fix and removing the workaround.

Please run yarn install for flat-manager before running ncc build ./flat-manager/index.js -o ./flat-manager/dist/, it deleted most of the contents.

@bbhtt Oops, I restored the original file.

@barthalion @bbhtt could you please take a look? Thanks!

Seems fine. Workaround was added in https://github.com/flatpak/flatpak-github-actions/pull/149/


compile for target armv7-apple-ios failed

when I compile for target armv7-apple-ios , it failed.

my mac os version is macos Catalina 10.15.4.
my Xcode version is 11.5.

command is:
**quiche cargo lipo --targets armv7-apple-ios**  // command

error message:
[INFO  cargo_lipo::meta] Will build universal library for ["quiche"]
[INFO  cargo_lipo::lipo] Building "quiche" for "armv7-apple-ios"
   Compiling idna v0.1.5
   Compiling quiche v0.4.0 (/Users/aeris/hswork/new3/quiche)
   Compiling mio v0.6.22
error: failed to run custom build command for `quiche v0.4.0 (/Users/aeris/hswork/new3/quiche)`

Caused by:
  process didn't exit successfully: `/Users/aeris/hswork/new3/quiche/target/debug/build/quiche-3284b9d17f385f2e/build-script-build` (exit code: 101)
--- stdout
running: "cmake" "/Users/aeris/hswork/new3/quiche/deps/boringssl" "-DCMAKE_ASM_FLAGS=-fembed-bitcode " "-DCMAKE_INSTALL_PREFIX=/Users/aeris/hswork/new3/quiche/target/armv7-apple-ios/debug/build/quiche-861563fbfc692cff/out" "-DCMAKE_C_FLAGS= -fembed-bitcode  -fPIC -arch armv7 -miphoneos-version-min=7.0 -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk -fembed-bitcode" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -fPIC -arch armv7 -miphoneos-version-min=7.0 -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk -fembed-bitcode" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug"
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - broken
-- Configuring incomplete, errors occurred!
See also "/Users/aeris/hswork/new3/quiche/target/armv7-apple-ios/debug/build/quiche-861563fbfc692cff/out/build/CMakeFiles/CMakeOutput.log".
See also "/Users/aeris/hswork/new3/quiche/target/armv7-apple-ios/debug/build/quiche-861563fbfc692cff/out/build/CMakeFiles/CMakeError.log".

--- stderr
CMake Error at /usr/local/Cellar/cmake/3.17.2/share/cmake/Modules/CMakeTestCCompiler.cmake:60 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /Users/aeris/hswork/new3/quiche/target/armv7-apple-ios/debug/build/quiche-861563fbfc692cff/out/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/usr/bin/make cmTC_55b88/fast && /Users/aeris/Downloads/Xcode.app/Contents/Developer/usr/bin/make  -f CMakeFiles/cmTC_55b88.dir/build.make CMakeFiles/cmTC_55b88.dir/build
    Building C object CMakeFiles/cmTC_55b88.dir/testCCompiler.c.o
    /usr/bin/cc   -fembed-bitcode  -fPIC -arch armv7 -miphoneos-version-min=7.0 -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk -fembed-bitcode  -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk   -o CMakeFiles/cmTC_55b88.dir/testCCompiler.c.o   -c /Users/aeris/hswork/new3/quiche/target/armv7-apple-ios/debug/build/quiche-861563fbfc692cff/out/build/CMakeFiles/CMakeTmp/testCCompiler.c
    clang: warning: using sysroot for 'MacOSX' but targeting 'iPhone' [-Wincompatible-sysroot]
    Linking C executable cmTC_55b88
    /usr/local/Cellar/cmake/3.17.2/bin/cmake -E cmake_link_script CMakeFiles/cmTC_55b88.dir/link.txt --verbose=1
    /usr/bin/cc  -fembed-bitcode  -fPIC -arch armv7 -miphoneos-version-min=7.0 -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk -fembed-bitcode  -isysroot /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names   CMakeFiles/cmTC_55b88.dir/testCCompiler.c.o  -o cmTC_55b88
    clang: warning: using sysroot for 'MacOSX' but targeting 'iPhone' [-Wincompatible-sysroot]
    ld: warning: -headerpad_max_install_names is ignored when used with -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES)
    ld: warning: ignoring file /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/lib/libSystem.tbd, missing required architecture armv7 in file /Users/aeris/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/lib/libSystem.tbd
    ld: dynamic main executables must link with libSystem.dylib for architecture armv7
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[1]: *** [cmTC_55b88] Error 1
    make: *** [cmTC_55b88/fast] Error 2

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:14 (enable_language)

thread 'main' panicked at '
command did not execute successfully, got: exit code: 1

build script failed, must exit now', /Users/aeris/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed
[ERROR cargo_lipo] Failed to build "quiche" for "armv7-apple-ios": Executing "/Users/aeris/.rustup/toolchains/1.41.0-x86_64-apple-darwin/bin/cargo" "--color" "auto" "build" "-p" "quiche" "--target" "armv7-apple-ios" "--lib" finished with error status: exit code: 101

I believe this is because Apple removed 32bit support. quiche is only tested with 64bit platforms.
See https://github.com/cloudflare/quiche#building-for-ios
https://developer.apple.com/documentation/uikit/app_and_environment/updating_your_app_from_32-bit_to_64-bit_architecture

rust-toolchain should be 1.41.0 or lower

I am closing this ticket -- currrently quiche is not tested in apple 32bit tagets since Apple dropped it. You may try to build with older version of toolchain.


Custodian doesn't aws cli default region in config

My cli is configured as follows:
[default]
output = json
region = us-east-2
When I try to run the policy below, it custodian created the lambda in us-east-1 instead of us-east-2.  I would have expected the framework would create a policy in the right region.
policies:

name: ec2-auto-tag-owner
resource: ec2
mode:
type: cloudtrail
role: arn:aws:iam:::role/TagMyEc2
events:
- RunInstances
filters:

tag:Owner: absent
actions:
type: auto-tag-creator
tag: OwnerContact

custodian defaults to us-east-1 unless another region is specified via cli or environment variable or passing explicit profile.

Sounds good, I can set the AWS_DEFAULT_REGION variable, but I expect most people will expect it to follow the behavior of other aws tools that honor the settings in ~/.aws/config
Thanks for the clarification

no other language sdk parses ~/.aws/config only aws cli and some of the tools that use boto/py sdk.

I can't say that I've tested this in every language, but that seems to contradict the aws documentation (link below) and my experience.  It appears to work for the AWS sdk in Python, Java, and C++ based on my testing.  Perhaps the feature was broken at the time your team looked at it?
Link: https://aws.amazon.com/blogs/security/a-new-and-standardized-way-to-manage-credentials-in-the-aws-sdks/
Relevant section of the documentation:
Specifying Credentials Using a Profile Name
If you don’t pass any credential information during initialization, and if the credentials are not found in the known environment variables, the SDKs look for credentials in the central credentials file. In that file, the SDKs look for a profile named [default] and use those credentials. This profile must exist in the file. As an alternative to having a [default] profile, you can point to a specific profile in these ways: ...

yes ~/.aws/credential is common, ~/.aws/config is not.

Fair point.  The SDK's usually require setting the region and the command line tool looks at ~/.aws/config
For custodian, do you think it best for the region to be specified in the shell environment, ~/.aws/config, or the Yaml file?
I'm still a custodian newbie, so I don't have a strong opinion myself.

@kapilt Under the covers, boto3 will honor the default region defined in your ~/.aws/config file (relevant docs) - should custodian intervene here and impose its own defaults (us-east-1)?

i'm aware, the issue is thats an implementation detail of a particular sdk not a standard across.

so i think the right thing, given we have compatibilty concerns on that default us-east-1, is to read the config ini file, and use that as a default if present.

@kapilt - When reading the config file, if a user specifies --profile on the command line should I read that section of the config file?  I wasn't sure if that was referring to the same profile.

@scotwk That cli option is passed to a boto3 session, so ... yes. :-)

okay, after some experimentation its become clear, that doing anything outside of letting the sdk handle this just increases complexity significantly, going to punt on having a default in c7n.

removed default region in custodian, everything defers to sdk now, there's too much logic in there for us to intercept and set an additional default without more complexity then is warranted.


Fix #2682: Cancel all requests on session invalidation or deinit.

Issue Link :link:
#2682
Goals :soccer:
This PR ensures that all Requests finish with a specific error when the owning Session is deinitd or the underlying URLSession is invalidated.
Implementation Details :construction:
Previously, after the Alamofire 5 refactor, Requests were no longer properly being finished, due to the separation of the URLSessionDelegate implementation from the Session itself, which meant the Session would be deinitd by the time the SessionStateProvider could act on the invalidation.
This PR adds an additional SessionStateProvider method, cancelRequestsForSessionInvalidation(with error: Error?) and a new AFError case, invalidatedSession(error: Error?) to properly support the new failure.
Testing Details :mag:
A test was added for the invalidation after deinit case. I'm not sure the actual session invalidation case can be tested.

Two unanswered questions remain:

Should we finish or cancel ongoing Requests? Since the Session is going away, there's no way to call back from the URLSession delegates to do anything, so whatever we do has to happen immediately. However, just finishing the Requests seems potentially problematic.
Do we want additional tests for active vs. inactive Requests, many simultaneous Requests?

@cnoon Thinking about this more, this seems like only a partial solution, as it only works for Requests mapped to *Tasks. It's also racy, given that the *Task isn't created until after the async URLRequest creation. I think a full solution will require us to keep track of all in-flight Requests, but before we do that we need to properly define the Request lifetime and what in-flight means. I'm thinking some sort of weak storage, but I'm not sure if that guarantees the lifetimes we'd want. Any ideas?
In the mean time I think I'm going to refactor this PR to separate the invalidation error from the deinit error, given they're really separate causes. I'll ping you again when that's done. If this brief version works out, we should merge it soon.

I've updated this PR to fully fix the validator leaks as well as separate the error case for deinitialization from invalidation.
This isn't a full solution but fixes the biggest issues.


UATv.0.3.3 | Pending Tasks for Litigant

For cases where the Litigant has an advocate, pending tasks should behave in the following way:

Litigant can see the Pending Tasks
Action Buttons for pending tasks are disabled for litigant
Only Advocate can perform the pending task

Currently,
Litigant can both see and perform the Pending Task
Steps to Replicate:

Create case as Litigant
Continue flow till registration by Judge
Join a case as an advocate on behalf of the complainant
Issue order for notice on case
Login as litigant to see payment pending task. Litigant can perform the task.

@Ramu-kandimalla I will need to make a list where litigant is able to see the pending task and perform it even when advocate is representing the case.
@Taherabharmal  Can you please provide where this sort of behaviour is visible in the application?
c.c. @anirudh-0

When complainant and advocate both are present the payment option will be visible only to advocate, litigants will not see the payment column in the first place.
Although, there is some issue, when Litigant registers the case and advocate joins the case later and then the order for notice is issues. In this case, @bhuvanyuguru observed that the litigant is able to perform the payment and pending task is not getting created for the advocate. I will check this certain scenario and post the same on the ticket.
c.c. @Ramu-kandimalla

There is this one edge scenario which we won't be able to incorporate
1 - litigant is party in person
2 - judge issues notice order
3 - advocate joins the case.
In this case, litigant will able to see the pendign task but won't be able to perform payment and since advocate has joined the case later, the pending task won't be created on his name, so payment option will not be available.
c.c @anirudh-0

HI @vaibhavct
This BUG is not resolved in DPG-DEV, Litigant is able to click on the Pay-Online Button.
Refer Screenshot

Hi @Taherabharmal, @Ramu-kandimalla, @rajeshcherukumalli
This Issue is resolved in UAT
Refer Screenshots
Litigant

Advocate


dead link

Core Library
No response
Wrapper Library
MSAL Angular (@azure/msal-angular)
Public or Confidential Client?
Public
Documentation Location
dead link
Description
there is a dead link here
clicking on the link lead to a 404 - page not found

Thanks for reporting this, it has been addressed in #6479


[feature request] add load_from_ckpt config field to enable SCL's second training step

SCL training schema:

trainable parameters: encoder and classifier; loss: SCL+CE
trainable parameters: classifier; loss: CE

added in development@be70c9896598331ec2851ef7e851fc5df6285a00


improve ui of navebar

i want to improve ui of  navebar . please assign this task to me.

https://github.com/khushi-joshi-05/Food-ordering-website/assets/117531823/27d6cb9b-f1a5-4f56-b70e-a90acb3ad6bc
I would like to help u with this.I have addressed this issue in my website too.SO can u please assign me this task

@sunny0625
I would love to add a nice hover effect to the navbar to make it more apperable.
I know Tailwind CSS very well as i have alredy worked over it kindly assign it to me.


Problem adding sample annotation by pd.dataframe

Hi Alex, thank you for this amazing package. I would like to use it for my analysis, but I cannot figure it out why I'm getting this error when I try to include more annotation on my samples.
Basically, I was following your example here:
import pandas as pd
anno = pd.read_csv(filename_sample_annotation)
adata.obs['cell_groups'] = anno['cell_groups']
However, when I tried with my cvs file, I got Nan for each row and I don't understand.
The pd data frame is fine, but then the data.var['key'] = NaN NaN NaN ... everywhere..
I post here my code:
**import pandas as pd
anno = pd.read_csv(path+'sample_anno.csv',header=0)
anno.head()
adata.var['pools']= anno['pools']
adata.var**

Thank you in advance,
Elisabetta

Sorry, this is related to automatic matching of indices in dataframes. If the indices don't match, you'll not assign anything. This is the generic behavior of pandas.
If your anno dataframe has a different index as compared to the adata.obs dataframe, then you cannot meaningfully assign values.
An easy work around is to call
adata.obs['cell_groups'] = anno['cell_groups'].values

as then, the index is ignored.
Or you do the following directly:
adata.obs = anno
Or you init the index of adata.obs with the cell names in anno: either via adata.obs.index or adata.obs_names. It's the same thing...
Hope this helps.
Let me know, if our convention for building the indexing of AnnData is not a good one...

Thanks! It works! I used your first suggestion. I'm mostly an R user, but in the past I worked on python. I haven't used it for ages and the first thing of R I'm really missing is the help. Here, I can google commands and errors for standard libraries but for example, in the case of new tools, I can just rely on few examples or tutorials.. Or it would be nice for example, also have a list of all the functions in scanpy, with explanation of inputs, outputs and explanation of them. Your documentation is really helpful and well-structured, but I feel a bit limited by that aspect.
Cheers,
Elisabetta

You can google everything in Python as well, you should end up on the following pages... at least if you add "pandas" or "numpy" to your search term...
http://pandas.pydata.org/pandas-docs/stable/
https://docs.scipy.org/doc/numpy-1.13.0/reference/
Don't you get there? The docs there should be at least as good as the Scanpy docs...
PS: In Jupyter notebooks, you can also get help by pressing "Shift + Tab" twice.

Yes, I know that.. but I was referring to new libraries such as your scanpy.

On 07 Feb 2018, at 16:48, Alex Wolf<EMAIL_ADDRESS>wrote:
You can google everything in Python as well, you should end up on the following pages... at least if you add "pandas" or "numpy" to your search term...
http://pandas.pydata.org/pandas-docs/stable/ http://pandas.pydata.org/pandas-docs/stable/
https://docs.scipy.org/doc/numpy-1.13.0/reference/ https://docs.scipy.org/doc/numpy-1.13.0/reference/
Don't you get there? The docs there should be at least as good as the Scanpy docs...
PS: In Jupyter notebooks, you can also get help by pressing "Shift + Tab" twice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/theislab/scanpy/issues/74#issuecomment-363811584, or mute the thread https://github.com/notifications/unsubscribe-auth/ATrry-J6GapAinea12bqhcDfiqghcKuOks5tScXRgaJpZM4R6xBm.

I suspect Elisabetta's concern was more about the general differences in documentation standards between Python packages and R packages (at least within genomics). It can definitely make the transition from R to Python more difficult (I can attest, as I'm going through it right now :P). R packages just tend to come with very thorough vignettes, documenting how the package is supposed to be used end-to-end, highlighting special use-cases, etc. I think Seurat, Monocle, or really any Bioconductor package (eg. Scater) are great examples.
Jupyter notebooks are fantastic for helping get an idea of how to use a package, but sometimes the documentation within them is lacking, making it hard to understand what's going on at each step without having to dive into source code. I find Scanpy's straight forward to follow though.
I really appreciate the modular design of Scanpy. At least if you're familiar with single-cell analysis, you can recognize the steps quite easily and just string together the appropriate functions for your analysis pipeline. Some other packages are bit trickier. For example, I found Velocyto (which I love btw) incredibly hard to navigate. There are functions that are used in some analysis notebooks but not all of them, so it becomes unclear what the standard analysis pipeline with it should be. Obviously you can dive into the paper, understand the statistical guts of the method, go through all the source code and see what's there, but then it starts becoming a barrier to newer users adapting it.
Anyway, this is just a general thing I also noticed moving from R to Python. Not saying that it's something that necessarily needs changing, but it does create a little bit of friction to newer users, so it may be worth thinking about as a community. I suspect this will improve as the genomics user-base of Python increases, and as all these packages have more time to develop. Also, I understand that this is more of a "community" chat and may not belong in the scanpy/issues page anymore, so feel free to close it ;)

Agree! My feeling is also that one to be bound by these tutorials. Pity!

Jupyter notebooks are fantastic for helping get an idea of how to use a package, but sometimes the documentation within them is lacking, making it hard to understand what's going on at each step without having to dive into source code.

that’s a cultural observation, not a technical one. nothing prevents people from writing great notebook-based vignettes (as alex proves)!

Thank you for these thoughts!
I guess the high documentation quality in R stems from the Bioconductor project, which really set some standards. Nothing like this exists in Python - everyone just does what he or she wants. There are few people thinking about setting up something similar to Bioconductor for Python - but this will likely take some time...
With Scanpy, we try to provide documentation at the Standards of the big packages: numpy, scipy, statsmodels, seaborn, scikit-learn, h5py, pytables, etc. There are many more and all of them have great docs.
I think, with Scanpy, one can still do a lot better. Tuturials tend to be too short. Also, there should be a properly rendered html output of the notebooks - with a button where you can simply download it and then run it yourself to start playing around with it. Hope we will have this in a couple of weeks.
And yes, other packages maybe just need to take time. But I'd guess that this will get much better soon...

OK, so we want to build and upload the notebooks. With a bit of convincing, we can get readthedocs to do that for us. But (for a good reason) scanpy_usage is a different repo. This means:

Changing something there should trigger a rebuild, not changing the scanpy repo
We probably need to put them on https://scanpy_usage.readthedocs.io
We can convince sphinx to create an index entry for the docs in the navigation sidebar that leads to the scanpy_usage site.

Then it would look like this:
https://scanpy.readthedocs.io:

Examples → Converted to a fake index entry that is a link to https://scanpy_usage.readthedocs.io
Basic Usage → …/basic_usage.html
Installation → …/installation.html
API → …/api/index.html
References → …/references.html

https://scanpy_usage.readthedocs.io:

Examples → /index.html
Basic Usage → Fake index extry to https://scanpy.readthedocs.io/…/basic_usage.html
Installation → Fake index extry to https://scanpy.readthedocs.io/…/installation.html
API → Fake index extry to https://scanpy.readthedocs.io/…/api/index.html
References → Fake index extry to https://scanpy.readthedocs.io/…/references.html

Yes, one could think about doing it that way.
I had in mind slowly transitioning to notebooks that download data and run through automatically. One can build docs with them https://nbsphinx.readthedocs.io and possibly use them for testing. In these notebooks, there won't be any images... so it would be fine to add them to the scanpy repo.
It's essentially the same thing as in the numpy etc. tutorials... only that not writing this in .rst but in notebook form gives the user the neat feature of being able to download an executable notebook.
For now, everything is built via https://nbviewer.jupyter.org/. Maybe you haven't yet realized the new layout of https://scanpy.readthedocs.io/en/latest/examples.html... But this is still too manual...
No hurry with these things, though...

Fantastic that this is all getting thought about! :)
Obviously this isn't an overnight thing, it's just something worth thinking about if the hope is to draw in new users (ie. those with minimal computational skills and limited knowledge of scRNA-Seq analysis). I think much of Monocle and Seurat's popularity owes to their comprehensive documentation. I've seen many people with little-to-no programming experience pick these packages up and give them a shot. No reason why Scanpy can't be a new "gold standard" for the field :)

Maybe you haven't yet realized the new layout of https://scanpy.readthedocs.io/en/latest/examples.html... But this is still too manual...

i’ve seen it, it looks really nice! but yes, automation would be cool!
Then we’d never forget to add a new notebook to the list, or get outdated info somewhere and so on.

Hi Elisabetta,
this is related to automatic matching of indices in dataframes. If the indices don't match, you'll not assign anything. This is the generic behavior of pandas.
If your anno dataframe has a different index as compared to the adata.obs dataframe, then you cannot meaningfully assign values.
An easy work around is to call
adata.obs['cell_groups'] = anno['cell_groups'].values

as then, the index is ignored.
Or you do the following directly:
adata.obs = anno

Or you init the index of adata.obs with the cell names in anno: either via adata.obs.index or adata.obs_names. It's the same thing...
Hope this helps.
Let me know if our convention for building the indices of AnnData is not a good one...
Cheers, Alex

Hi! I am not sure if this forum is still open or not, but I had a similar question about my code.
Basically, my indices (rows) do not have a "name" and I am trying to subset off it. Is there anyway to do this? Thanks!

Hi! I am not sure if this forum is still open or not, but I had a similar question about my code.


Add support for passive event listeners

Echoing @RByers on pushing for support of passive event listeners which could see fairly significant scrolling performance improvements across the board.
Request on jquery: https://github.com/jquery/jquery/issues/2871
Explainer: https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md
Chrome status page: https://www.chromestatus.com/features/5745543795965952
This hits Chrome Stable (51) in about a month.

Hi! Is there any info of if/when passive listeners will land on Polymer?

👍

Related: https://github.com/Polymer/polymer/issues/3787

how to do it for polymer elements
does the defer attribute help

@azakus any progress?

I believe this was incorrectly closed by #4829 which toggles passive gestures app-wide, whereas there needs to be a Polymer way to add passive event listeners on an ad-hoc basis, which is what this issue is about.

[Ping] This issue should not be closed. The app-wide gesture toggle for passive gestures has nothing to do with this.

@azakus: can you comment on this?

@matthew-dean Ah, that is not how I interpreted this issue, but we have no plans to support using passive gestures via syntax.
If you need that, I would suggest removing on- listeners and using node.addEventListener(gesture, fn, {passive: true})

On second thought, you were asking about adding passive gesture events I see.
Yeah, I think we could make that work.

Would be really great to have this on component level in Polymer 1.x.

@azakus Yeah, I'm working with Polymer 2 now, and you definitely can handle passive events that way. It's just not in the declarative portion of Polymer. Could be something like on-tap.passive="_handler".

Any progress here?


add <<, the unindenting function

The function should match everything mentioned in #24, and there's a test for each arity :heavy_check_mark:
Should anything special be added for the docs?

Everything is fine, would be awesome have a little section on docs for this function but is not stoper for merge this PR.
Please, fix the commented issue and I'll merge it ASAP.
Thanks!

whoops, just forgot to push it.

Thanks!

and 1.0.0-SNAPSHOT released on clojars


Add Schema::hasTable('users') as default in migration create.stub

Simple logic check (using the pre-existing feature of the framework) to only create a DB schema if a table of the same name doesn't already exist.
It seems to me that those of us who use the Artisan command to generate a migration would appreciate this by default and it should help mitigate "already exists" errors.
It nicely mirrors the if logic in the down method.
This may also apply to update.stub.
I'd also encourage its use in package migrations, particularly as packages may offer migrations with the same name as the local project.

This is more error prone IMO. If you're generating a migration, you expect the fields in that migration, not to silently fail if things go wrong.


Individual member timeline graph #202

Adds membership data to member detail view and a d3.js visualization to the member detail template to display member activity dates.
Updates in support of that include:

method on Account to aggregate date ranges from all associated events
event queryset methods to get book activities and filter on known years

currently testing this by turning on the "has card" filter and picking people at random to look at their timelines. I'm seeing quite a lot of folks who have no graph displayed, although I am seeing output in console. in these cases they tend to have both activity ranges and book activities, but no membership activities. here are two examples (links go to localhost; assumes you have server running). presumably we still want to draw the graph if this is the case?

Codecov Report

Merging #398 into develop will decrease coverage by 0.03%.
The diff coverage is 95.65%.

@@             Coverage Diff             @@
##           develop     #398      +/-   ##
===========================================
- Coverage    98.56%   98.52%   -0.04%
===========================================
  Files          167      167
  Lines         7517     7597      +80
  Branches        22       22
===========================================
+ Hits          7409     7485      +76
- Misses         108      112       +4


Attaching to a running container lingers

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48) (x64)
OS Version: Pop!_OS 20.04 LTS

Steps to Reproduce:

Start Container in detached mode
open VSCode
Run Remote-Container: Attach To Running Container
terminal reports: [730395 ms] Extensions cache, remote removals: None

Note:
I believe this is due to VS Code not displaying the popup as described in the documentation HERE and HERE
VSCode terminal log:
output.txt

I could not replicate this issue on a new container

Renaming my container fixed the lingering.
Note:
Does vscode store metadata carry over from older versions of vscode?


⚠ Cioos Pacific CKAN Sitemap has degraded performance

In 8ff06b2, Cioos Pacific CKAN Sitemap (https://catalogue.cioospacific.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 13788 ms

Resolved: Cioos Pacific CKAN Sitemap performance has improved in e4a6b7e after 23 minutes.


Compile error at resize_op.cu

Win10 + VS2015 sp3 + CUDA 8.0 + Anaconda
Could someone give me a workaround first to let me continue? And please let me know if more info is needed.
"C:\Users\davin\Documents\Repos\caffe2\build\ALL_BUILD.vcxproj" (default target) (1) -> "C:\Users\davin\Documents\Repos\caffe2\build\caffe2\Caffe2_GPU.vcxproj" (default target) (6) -> (CustomBuild target) ->   C:/Users/davin/Documents/Repos/caffe2/caffe2/operators/resize_op.cu(63): error : identifier "__ldg" is undefined [C:\ Users\davin\Documents\Repos\caffe2\build\caffe2\Caffe2_GPU.vcxproj]

I searched some answers saying that __ldg requires compute_35 which is supported by Kepler GK110 or newer. My video card is Maxwell, how to config the compiler to generate the correct code? Thanks.
By the way, can we add some hints in the installation guide saying Kepler or newer GPU is required?

I solved this issue by modifying cmake/cuda.cmake file as following, removed unsupported archs.
set(Caffe2_known_gpu_archs "35 50 52 60 61")
set(Caffe2_known_gpu_archs7 "35 50 52")


JS serializeValue looping in another nodes

Hi, in other (not just mine) custom node front-end js of other developers if using serializeValue for example:
this.[variable].serializeValue = async (node, index) => {
     here looping the code of other nodepacks if your nodepack installed
}

the code within this function start looping if your nodepack installed, what is very inconvenient and unmanageable because the value of the variables defined inside the function is not stable, in many cases this affects seed integer generators where the variable takes a random value, but this does not have to be done every second. Would be good if the development not modify how other nodepacks working. :(

A possible fix for this is in development. It requires a significant change to the UE nodes, so testing may take a while.

Could you update and see if this now works as expected?


Darken statusline text color for inactive splits

I'm really liking the color scheme, but I found the statusbar text color to be the same for active and inactive splits:

I rely a lot on them being different to tell which split I'm in, so I changed the inactive split's statusbar text color to "background":

I'm finding it very helpful, and others might as well.

I think background is too dark to read the text.
Maybe inconspicuous  is better.

I'm having a hard time distinguishing "inconspicuous" from "foreground". What about one of the defined colors?

I'll try experimenting and posting some screenshots for comparison.

I have double checked my color, I found StatusLine and StatusLineNC has a attribute bold and reverse. I think it would looks same as you screenshot. Am I right ?

For some reason mine isn't showing up as such, possibly due to not having a bold font available—I'll have to check this out a bit more thoroughly tomorrow.
I'm also testing this option out and so far it looks OK to me:

It's "orange" for active and "foreground" for inactive.

statusline now has a color(lime) for active. check again.

Most excellent—thanks so much for the responsiveness!


APIM 3.2 - Store RESTful API - API listing call returns "ORA-01795" ERROR when the limit is more than 1000

Description:
When a user list down APIs using the below REST call, it returns 500 internal server ERROR.
REQUEST
https://localhost:9443/api/am/store/v1/apis?limit=5000
ERROR
{     "code": 500,     "message": "Internal server error",     "description": "Error while retrieving APIs",     "moreInfo": "",     "error": [] }

In the wso2carbon log, we can see the below ERROR.
TID: [-1234] [api/am/store] [2021-08-27 10:23:29,732] ERROR {org.wso2.carbon.apimgt.rest.api.store.v1.impl.ApisApiServiceImpl} - Error while retrieving APIs org.wso2.carbon.apimgt.api.APIManagementException: Failed to Search APIs
	at org.wso2.carbon.apimgt.impl.AbstractAPIManager.searchPaginatedAPIs_aroundBody178(AbstractAPIManager.java:2305)
	at org.wso2.carbon.apimgt.impl.AbstractAPIManager.searchPaginatedAPIs(AbstractAPIManager.java:2195)
--------
Caused by: org.wso2.carbon.apimgt.api.APIManagementException: Failed to retrieve api scopes
	at org.wso2.carbon.apimgt.impl.dao.ApiMgtDAO.handleException_aroundBody320(ApiMgtDAO.java:7360)
	at org.wso2.carbon.apimgt.impl.dao.ApiMgtDAO.handleException(ApiMgtDAO.java:7358)
--------
Caused by: java.sql.SQLSyntaxErrorException: ORA-01795: maximum number of expressions in a list is 1000

When we set the limit to 1000 or a number below 1000 we could not see this ERROR. (This ERROR only can be reproduced when there are more than 1000 APIs in the environment)
As per the background analysis, we have done this seems like a limitation in the Oracle. In Oracle number of parameterized values for the IN/NOT IN clause must be 1000 or below. If the number of parameterized values for the IN/NOT IN clause exceeds 1000, the subquery should be divided into sets according to the maximum limit of 1000, joined by the OR/AND operator.
Affected Product Version:
APIM-3.2.0

This issue has been fixed by the following PR.

https://github.com/wso2/carbon-apimgt/pull/10794


Inferred return type of a decorated function is incorrect

Inferred return type of a decorated function is incorrect.
(That is the one for the function without the decoration.)
Environment data

Language Server version: <IP_ADDRESS>
OS and version: macOS 10.15
Python version (& distribution if applicable, e.g. Anaconda): Anaconda3 Python 3.7.3

Expected behaviour

The LS infers a correct return type of a decorated function.

Actual behaviour

The LS infers a return type of a decorated function as if the function is not decorated.

Logs
N/A
Code Snippet / Additional lnformation
from typing import Any, Callable

def stringify(f: Callable[..., Any]) -> Callable[..., str]:
    def wrapper(*args) -> str:
        return str(f(*args))
    return wrapper

@stringify
def one() -> int:
    return 1

value = one() # inferred type of `value` by the LS is `int`,
              # but it should be `str`

print(type(value))
# <class 'str'>

True, currently analysis does not look into decorators in order to find out possible return type. Also, Callable is not currently handled. #1115 and #535


feat(action-button): loader replaced with spinner

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 80.419%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
7956

Relevant Lines:
8979

💛  - Coveralls


Adding maintainers

Hi @ocefpaf,
I just uploaded a new release of UrbanAccess to PyPI, so the bot should be opening a PR here soon. Could you add me and @sablanchard as additional maintainers before merging it? (Or if it's easier, you could ignore the bot's PR and I can open a separate one with those changes.)
The new release is a compatibility update to add support for GeoPy 2.0+ and Pandas 1.0+. None of the dependencies or licensing should have changed.
https://github.com/UDST/urbanaccess/pull/66
https://pypi.org/project/urbanaccess/0.2.1/#files
Thanks!

Done in #3
Thanks!

Thanks so much!

My pleasure!


Add Tests for GitHub Service (Jest)

Description
We have a GitHub service, responsible for fetching all good first issues from GitHub, We want to have clean test suits. The testing environment is already configured in the project along with the test file (/__test__/services/github.test.ts).
Usage
to run all the tests run the following command
npm run test

Acceptance Criteria

Mock third-party request calls and return static responses for testing
Add appropriate test name to maintain code readability
Test all functions in the service and refactor the tests frequently whenever required
Consider Edge Cases to cover in the tests
Don't add too many except in single test, rather breakdown those into multiple tests

Engineering Notes
We're using jest for testing and jest-mock-extended for mocking and other pre-made functions.
Feel free to pick this issue and comment down below in case of any questions/feedback!

@omjogani Should we break this in multiple tests per filter?

@omjogani Should we break this in multiple tests per filter?

Breaking testes into multiple files: Bad Idea while everything resides in github.ts, If we breakdown github.ts file then yes we should breakdown tests too in multiple files.
Breaking functionality into multiple test (filter wise or what so ever): Yes we should do that

@omjogani I think we should break it and then break the tests too, let me know your thoughts?

@omjogani I think we should break it and then break the tests too, let me know your thoughts?

Well, that's better, I will work on refactoring that by end of this week!

@omjogani Sure, take your time


Stacks as YAML?

Is it possible to define stacks using YAML files? Main idea being a sort of infrastructure as code.

Hi @Blunderchips ,
For now, only HCL is supported as IaC like Terraform or OpenTofu, but soon we will support workflows in YAML to link different stacks