Create Fundamentals section.

Move and edit articles to create the basis for a new "Fundamentals" section.
The edit pass in this PR is rather light. As I add more of the content framed out in the TOC file, I'll do more rework for each file.
However, for any filed I moved I addressed any of the open issues;
Pattern Matching:
Fixes #24041

Replace first sample with one using IEnumerable and IList to find the midpoint of a sequence.
Use the temperature sample with the interactive window to demonstrate how you can refactor and rearrange switch expressions, trusting the compiler to warn you if you make mistakes.
Standardize on decimal for the discount example.
Review link to updated content - Pattern matching

Polymorphism:
Fixes #19013

The fix is to change the code as described in the issue.
Review link to updated content - Polymorphism

intro to C# tutorial / introduction to classes:
Fixes #18803

Updated the code to match the suggestion by svick. The text doesn't change, because that's not part of the article's focus. However, the new sample code makes it easier for readers to explore.
Review link to updated content - Introduction to classes tutorial
intro to C# tutorial / object oriented programming:

Fixes #22422

update text to use "greater than 0" instead of "non-negative".

Same content as above - intro to classes tutorial.

Internal preview link - landing page

Note on Snippets 5000 build errors:
There are four files from the migrated samples where code was removed. I didn't add projects there, but the code moved into this section does have new projects.

Notes for reviewers
This looks much larger than we'd like for a typical PR. However, the changes can be mostly validated by the build system. The bulk of the work as to move articles and their associated samples to create a new Fundamentals section. (Future PRs will update and extend this content per notes in the TOC).

To see what files moved, the best checks are the changes to the TOC, and the redirection file.
Three files were edited to fix open issues associated with files that moved. Notes for those are in the PR description above, as is links to the updated content on the review site.
Other samples and articles had a light edit (primarily checking Acrolinx)
Other changes updated links, but didn't change any content.
Many files with updated links had "Duplicate H2" warnings for "Example". Those warnings were fixed, with no other edits.

Four errors remain for the snippets 5000. Those were old folders where some samples were removed and put in new folders.


Best practice for switching to a different Flutter version?

We want to use FVM in our team to ensure a consistent Flutter version across our team. From reading the docs, I can't find a good solution for switching to a new Flutter version.
We have committed the fvm_config.json, but the flutter_sdk is ignored by git (as described in the docs). What is now the process to switch to a new Flutter version? I would assume the following steps:

Change the version in fvm_config.json
Run fvm install

But now the problem: Every other developer needs to be notified, that their need to run fvm install, otherwise they will use a different version, right?
I would love to hear of a better solution and add this to the FAQ section of the docs.

@nilsreichardt if a commit changes version there, I believe either they would need to be notified or could be part of an internal tool or process to do that. But again I am not sure how often this happens.
Maybe an implementation using git hooks might be what you need, here is a great article on it.
https://dev.to/arthurdenner/git-hooks-in-flutter-projects-with-lefthook-52n

FVM automatically asks you to install the new version if it was changes in the fvm_config.json file.
There is no need to run fvm install, any other command will ask you to install.
I found this to be working quiet well in a team, no need for any notification to update flutter.
For apps we additionally update the minimum flutter constraint in pubspec.yaml but if every developer uses FVM, there is nothing to worry about.
You can also use the fvm_config.json file to read and install the version in CI.

@kuhnroyal does this would apply if running the CLI but I believe if not running from the IDE tooling…

hmm yeah, if one only uses IDE, this is a problem.

I think a solution is to set also the flutter version in the pubspec.yaml:
environment:
  sdk: '>=2.18.0 <3.0.0'
  flutter: ">=1.17.0"

Therefore, other people can't use unintentionally the old flutter version 👍


didn't find any theme for full path + display git changes

Hi, I'm looking for theme to display a full path + git (branch name + uncommitted changes + added files).
Didn't find any.
would love a recommendation of one / a tip of how to edit an existing one (I am currently using Godzilla).

In gozilla.zsh-theme, change the %c (trailing component of pwd) to %d (full path of pwd). The customized version should go in your $ZSH_CUSTOM/themes directory.
See Prompt Expansion in the Zsh Reference Manual for details on how it works and other prompt stuff you can do.

BTW, @Gozala, what's the %p expansion in gozilla's $PROMPT for? That's the time in tcsh prompt configuration, but AFAIK, %p isn't supported by ZSH. %* might be the zsh equivalent.

thanks, solved it by editing the
~/.oh-my-zsh/themes/gozilla.zsh-theme
changed the PROMPT to
PROMPT='$(rvm-prompt) %{$fg_bold[red]%}➜ %{$fg_bold[green]%}%p %{$fg[cyan]%}%d %{$fg_bold[blue]%}$(git_prompt_info)%{$fg_    bold[blue]%} % %{$reset_color%}'


fix(5e-SRD-Monsters.json): small inconsistencies

Fixes various small inconsistencies (some probably introduced by character recognition).
What does this do?
Fixes various small inconsistencies.
How was it tested?
Manually.
Is there a Github issue this is resolving?
No.
Did you update the docs in the API? Please link an associated PR if applicable.
No.
Here's a fun image for your troubles

The patch contains a single comma in the Lamia's entry for Intoxicating Touch. I've verified it can be parsed.


Can't import gg-struggle-cert.pem

I am unable to import the gg-struggle-cert.pem into my Trusted Root Certification Authorities folder as it says that the file is password-protected.
I might just be an idiot, but I am unable to find any password that would fit here. The automatic installer seems to be unable to install the certification as well as I am experiencing similar issues there, even after using the installer there is no gg-struggle permit in the folder. Possible solutions mentioned in other threads yielded no results.

pass is totsugeki 🐬


How to cite your work?

Hi,
Great work. I have tried deepbrain on multiple datasets and it works really well.
Kindly let us know if you have any published paper or citation source for this work.
Thanks

I have the same question!

Hi,
I am using Dee-brain for my thesis work. Kindly update with any published paper or citation source.

Hello, Did you find the paper or a source associated with this project yet?

Hi, I am still looking for a way to cite this work.
@iitzco can you please inform us?
Thanks.

Hi guys,
so I recently messaged the author of this repo via LinkedIn. He informed me there was not a formal process he followed to build this tool.
However, I think you can cite the databases he used to build the model, this github repo, as well as take a look at the U-Net architecture and write it down on your paper. That way, it will be clear to readers the steps taken to build DeepBrain. That is actually what I am doing in my dissertation project, since I want to use DeepBrain to skull strip my MRIs.
The reply to this issue goes into implementation details a bit more: #5
Hope I could help.


It does not support Network picture？

Does it support Network picture？

Duplicate of #95, #228. Image loader help is available in the wiki, various closed issues, and StackOverflow.


eth_estimateGas transition.apply vs eth_call transition.apply result differs for the same param data

eth_estimateGas transition.apply vs eth_call transition.apply result differs for the same param data
Description
Prior to the changes introduced in https://github.com/0xPolygon/polygon-edge/pull/422 , certain transition.apply calls within eth_estimateGas would fail, however in these scenarios eth_estimateGas still returned what looked to be a successful response, returning a value of GasCap + 1 or 5000001. A subsequent eth_call using this value would result in a successful transaction.
After pulling in https://github.com/0xPolygon/polygon-edge/pull/422, we were made aware than an error exists in eth_estimateGas, as we now see the following error message:
unable to apply transaction even for the highest gas limit 60000000: execution was reverted

For context, we have some frontend logic that chains the result of an estimateGas call to the actual call. Below you can see that the data value is identical for both calls, however each transition.apply in eth_estimateGas fails until we observe an error response with the message above, when we believe this function should in fact response with an estimateGas value.
eth_estimateGas:
{"id":1085389008,"jsonrpc":"2.0","method":"eth_estimateGas","params":[{"from":"0x78b7bc9fdc7dc431d385d1e18cac6b53ddcf4ba9","to":"0x22b3069a51aa8bddca7cee0e3db460b9da23f379","data":"0x5c11d795000000000000000000000000000000000000000000000001a055690d9db80000000000000000000000000000000000000000000000000004038f617f17b5724200000000000000000000000000000000000000000000000000000000000000a000000000000000000000000078b7bc9fdc7dc431d385d1e18cac6b53ddcf4ba9000000000000000000000000000000000000000000000000000000006227c0ef000000000000000000000000000000000000000000000000000000000000000200000000000000000000000028fe1f46c9c0eef1cdf44c9c504c43e7914320890000000000000000000000003a1c652a4966a68a0ac520d9a8f00463efd5219a"}]}

eth_call:
{"id":1085389010,"jsonrpc":"2.0","method":"eth_call","params":[{"from":"0x78b7bc9fdc7dc431d385d1e18cac6b53ddcf4ba9","to":"0x22b3069a51aa8bddca7cee0e3db460b9da23f379","data":"0x5c11d795000000000000000000000000000000000000000000000001a055690d9db80000000000000000000000000000000000000000000000000004038f617f17b5724200000000000000000000000000000000000000000000000000000000000000a000000000000000000000000078b7bc9fdc7dc431d385d1e18cac6b53ddcf4ba9000000000000000000000000000000000000000000000000000000006227c0ef000000000000000000000000000000000000000000000000000000000000000200000000000000000000000028fe1f46c9c0eef1cdf44c9c504c43e7914320890000000000000000000000003a1c652a4966a68a0ac520d9a8f00463efd5219a"},"0x1399fa"]}

We've managed to avoid calling eth_estimateGas altogether and we are currently hardcoding a gasEstimate value of 5000000 for all eth_call requests for this type of transaction -- these transactions then work as expected.
Your environment

OS and version Ubuntu 20
version of the Polygon Edge Release v0.3.0
branch that causes this issue develop

Steps to reproduce
Before https://github.com/0xPolygon/polygon-edge/pull/422 :

Fork SushiSwap and point to your testnet
Attempt to perform a swap, this will use chained estimateGas + ethCall logic:

         return library
              .estimateGas(tx)
              .then((gasEstimate) => {
                return {
                  call,
                  gasEstimate,
                }
              })

Observe that eth_estimateGas reaches GasCap + 1 limit and responds with a gasEstimate of 5000001
The subsequent eth_call will use the above value and the transaction will be successful

After https://github.com/0xPolygon/polygon-edge/pull/422 :

Attempt to perform a swap using forked SushiSwap
Observe that eth_estimateGas returns an error response:

unable to apply transaction even for the highest gas limit

No subsequent eth_call can be made unless we hardcode the gas value to something like before (5000001)

Expected behaviour
The transition.apply result in eth_estimateGas should not differ from the transition.apply result in a eth_call.
At the very least, eth_estimateGas should respond with the block gasLimit if all else fails (as it did before).
Actual behaviour
eth_estimateGas fails as a result of e.store.ApplyTxn(header, txn) returning a result object with Err.data = "execution was reverted" and nil error.

Hey @dankostiuk,
Thank you for opening up this issue 🙏
When you say fork Sushiswap, do you mean this repo?
https://github.com/sushiswap/sushiswap
Which script are you executing?

Hey @dankostiuk,
Thank you for opening up this issue 🙏
When you say fork Sushiswap, do you mean this repo? https://github.com/sushiswap/sushiswap
Which script are you executing?

@zivkovicmilos
We are using a fork of https://github.com/sushiswap/sushiswap-interface and the part of the script that makes a call to estimateGas is right here:
https://github.com/sushiswap/sushiswap-interface/blob/e5c09dea3cb46d89099282757095f29e9cf8b87c/src/hooks/useSwapCallback.ts#L596

Can you please share the data dirs for the chain, along with the genesis file?
I want to have them present if I'm unable to reproduce the problem with the Sushiswap repo.
Please also provide additional steps for reproducing the problem (step 1) 🙏

I've shared both data-dir backup and genesis file with you on telegram and will add more info to step 1, thanks 🙏

Closing this issue as it seems to be an unrelated problem.
We've discussed this internally and will start drafting a PR for the concurrency problem that seems to be popping up 🙏


Refactor selectTxHistory

This pull request refactors selectTxHistory — it moves the filtering by withdrawal and sorting by slot out of the DBTxHistory database layer type.
This task consolidates our transaction storage with the purpose of eventually moving it from memory back to disk.
Issue number
ADP-2346

Closed in favor of https://github.com/input-output-hk/cardano-wallet/pull/3556


Text in "Returns" section is larger if only one variable is returned

See the image below. In the method which returns two variables, they are bulleted and the text is smaller. In the method which returns only one variable, it is not bulleted and the text is larger. Is this intended? Could the text be made the same size?

As you can see, this goes for the "Raises" section too. I suspect that the bulleted lists are styled with smaller font size, and since bulleted lists are not used for single return/raises, the text is larger.

There are a couple styling issues around the returns listing that I'm noticing now, this is one of them. Looking to target this for next release.


Docs: Collapsible admonitions that start collapsed should be more accessible

For longer file examples or command outputs, we currently use several collapsible admonition blocks on our docs site. It's not immediately obvious that these are expandable without some textual indication.
To improve accessibility and the general UX of the docs, we should add some indication that these are expandable to the admonition titles, or perhaps consider having all collapsible blocks start expanded.

I'm not an accessibility expert at all, but I checked with VoiceOver and it announces when you reach an expandable block and suggests how to expand or collapse it. I'm not sure if overall screen reader accessibility of the docs website is good enough. To improve accesibility we will likely have to contribute to mkdocs-material.
But I agree - even visually these blocks are not very intuitive. I do not have objections to either make them expanded by default or convert them non-collapsible admonitions.

https://squidfunk.github.io/mkdocs-material/reference/admonitions/?h=expand#collapsible-blocks
All it would take is adding a + symbol to the ??? markup for the blocks you want expanded by default.


Update WOF table schema

Updates the WOF neighbourhood table schema to add the new required columns.
Connects with #147
@zerebubuth could you review please?

:+1: looks good to me.


too many callbacks

Delete one of your callbacks so ioBroker can use one of the three slots.

The current callbacks can be found (and also deleted) via nuki-extended.0.bridges.<bridgeName>.callbacks.
There is a maximum of 3 callbacks per bridge. The adapter can't attach a callback, because no free slot is given, which is why a warning is shown in the log.
Delete one of the existing callbacks and restart the adapter.
If the warning persists, please let me know the URLs that are attached already as well as the log in debug mode.


New Cask firestr 0.10

Done in https://github.com/caskroom/homebrew-cask/commit/cfeb533939302dcc082e0c0fb94d14349e069f9a. Why do you never make the requested fixes, @hanxue? Submitting so many casks and never following through doesn’t really help.


[BUG] ImageInput::open with JPEG images is not thread-safe

Describe the bug
I tried to read the format name of 4 JPEG images using 2 or more threads, but a segmentation fault occurred when calling ImageInput::open.
This never happened when using a single thread.
To Reproduce
Short example program to reproduce the behavior:
#pragma omp parallel for num_threads(nbThreads)
for (auto path : imagePaths) {
    auto tid = std::this_thread::get_id();
    LOG(tid << " opening image " << path);
    auto input = OIIO::ImageInput::open(path);
    if (!input) {
        LOG(tid << " failed with error: " << OIIO::geterror());
    }
    auto name = input->format_name();
    LOG(tid << " format name: " << name);
}

Expected behavior
No segmentation fault.
If ImageInput::open failed, I expect it to return a null pointer and retrieve an error message from OIIO::geterror() as it is documented.
Evidence
When running the above example program with nbThreads = 2 and getting a segmentation fault I have the following backtrace:
#0  0x00007ffff7925cf3 in OpenImageIO_v2_4::decode_icc_profile(OpenImageIO_v2_4::span<unsigned char const, -1l>, OpenImageIO_v2_4::ImageSpec&, std
::string&) () from /s/apps/users/multiview/oiio/<IP_ADDRESS>/platform-linux/build-release/lib/libOpenImageIO.so.2.4
#1  0x00007ffff7a8165a in OpenImageIO_v2_4::JpgInput::read_icc_profile(jpeg_decompress_struct*, OpenImageIO_v2_4::ImageSpec&) () from /s/apps/user
s/multiview/oiio/<IP_ADDRESS>/platform-linux/build-release/lib/libOpenImageIO.so.2.4
#2  0x00007ffff7a82902 in OpenImageIO_v2_4::JpgInput::open(std::string const&, OpenImageIO_v2_4::ImageSpec&) () from /s/apps/users/multiview/oiio/
<IP_ADDRESS>/platform-linux/build-release/lib/libOpenImageIO.so.2.4
#3  0x00007ffff79a4736 in OpenImageIO_v2_4::ImageInput::create(OpenImageIO_v2_4::basic_string_view<char, std::char_traits<char> >, bool, OpenImage
IO_v2_4::ImageSpec const*, OpenImageIO_v2_4::Filesystem::IOProxy*, OpenImageIO_v2_4::basic_string_view<char, std::char_traits<char> >) () from /s/
apps/users/multiview/oiio/<IP_ADDRESS>/platform-linux/build-release/lib/libOpenImageIO.so.2.4
#4  0x00007ffff798c8b5 in OpenImageIO_v2_4::ImageInput::open(std::string const&, OpenImageIO_v2_4::ImageSpec const*, OpenImageIO_v2_4::Filesystem:
:IOProxy*) () from /s/apps/users/multiview/oiio/<IP_ADDRESS>/platform-linux/build-release/lib/libOpenImageIO.so.2.4

One set of images with which the bug seems to occur often is Monstree (approximately 50% of the trials end up in a segmentation fault when using the mini datasets).
Platform information:

OIIO branch/version: <IP_ADDRESS>
OS: CentOS Linux 7 (Core)
C++ compiler: GCC 9.3.1
Any non-default build flags when you build OIIO:

Hello @lgritz,
It would be great if you could check this problematic issue!


ci: add stylua, luacheck, luarc, editorconfig, pre-commit hooks

Mostly sourced from https://github.com/nvim-tree/nvim-tree.lua

Can't we just avoid git hooks and have a shell script that runs luacheck/stylua/make? You'll have to do make anyway, you can't automate everything.

Can't we just avoid git hooks and have a shell script that runs luacheck/stylua/make? You'll have to do make anyway, you can't automate everything.

That is sensible. It sidesteps the git hooks issue.
Added to makefile and updated doc.

Much better thanks :)


Problems with interface names longer than 4 characters

In several places there is code similar to this:
ifreq = struct.pack('4s12xH', ifname, flags)
The '4s' assumes that ifname will be 4 characters long (for example "eth0"), but if ifname is 5 characters long (for example "eth11"), then the interface name gets truncated to 4 characters and the operation gets applied the incorrect interface. (ie: "eth1" instead of "eth11").
Could this code be generalized to handle interface names of any (reasonable) length?

Ok, This is merged into master, and tagged as 1.0.0


refresh_all_user_stats Argument Error

Fix this error, which I seem to see daily

Cron Daemon<EMAIL_ADDRESS>Tue, Mar 19, 2024 at 10:14 PM
To<EMAIL_ADDRESS>/var/web/mo/app/models/user_stats.rb:186:in refresh_all_user_stats: wrong number of arguments (given 1, expected 0) (ArgumentError)
from script/refresh_caches:55:in progress
from script/refresh_caches:78:in <main>

This is really easy.  Nimmo: I have structured all of the other nightly
refresh methods to accept a dry_run argument to allow easy testing from
the command line.  Just add that to your new method.
On Wed, Mar 20, 2024 at 9:10 AM Joseph D. Cohen @.***>
wrote:

Fix this error, which I seem to see daily
Cron Daemon @.*** Tue, Mar 19, 2024 at 10:14 PM
To: @.***
/var/web/mo/app/models/user_stats.rb:186:in refresh_all_user_stats: wrong
number of arguments (given 1, expected 0) (ArgumentError)
from script/refresh_caches:55:in progress
from script/refresh_caches:78:in
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/issues/2046, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNNGS4K52GUGX2CFB2TYZGDENAVCNFSM6AAAAABE7OKXI2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TONJQGEYDOOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Hololens 2

Respected People,
Does this Project also support Hololens 2?
Please do help me with the question.
Thank you.

Did you try it? Does it work?:)


Background image for for the footer renders too high on the page on mobile browsers

I've tested on Android (Samsung Galaxy S4) with both Firefox Beta and Google Chrome.
I would include a screenshot, but I'm having issues with my phone's USB debugger...

Thanks for filing - I also noticed this and filed the day of the release, #62.
Since this is a duplicate of #62, closing this one and keeping it open. Feel free to add notes or a screenshot there (I added one from my model, Samsung Galaxy s7 edge).


git history adjustments

I managed to run a simple benchmark with pyzmq (yay!), and my plots were looking weird, and it just so happens that a refactor of pyzmq introduced a short-lived 20x regression in performance of my simple benchmark, so oddities in git history ordering are quite apparent. My first plot looked like this:

Which seems erratic, and doesn't actually reflect the life of the code.  The early peaks are because the refactor branch lived a while before being merged, while pyzmq was still being developed.  The late peak is actually due to a cherry-pick, which means author-time (%ad) doesn't always correspond to the order in which things are actually added to the tree, unlike committer-time (%cd).
With a regular git log, you can use a topological sort with git log --topo-order, so that parallel commits will not be interleaved.  But this doesn't actually help if you are still doing simple time plots, and not using the git graph data.  What I found made the most sense was for the benchmark to only follow the master branch, and not track commits made in feature branches until they were merged.  In this way, the performance timeline actually reflects the performance of the real project, rather than including incomplete feature branches.
I don't know how to get git-log to exclude branches, so I did the only thing I could think of (which may be horrible, but it works): parse the output of git log --graph to identify when commits are in master.
Here's the exact same benchmark with the changes to git-log parsing described above:

Thanks for sorting this out-- I had a couple of long-ish lived branches in pandas where this was also a problem.


Issue 1 - Fixed the redirecting issue

🐛 Bug Fix: Redirect Issue (#1)

Removed a problematic meta tag to address issue #1, which was causing automatic redirection to Maddox's GitHub profile.

This PR is related to issue #1. The issue was fixed.

like that for a reason rn.


feat: support hot reload of Java plugins

Why submit this pull request?
[ ] Bugfix
[x] New feature provided
[ ] Improve performance

New feature or improvement

Describe the details and related test reports.
Ran end-to-end tests by running apisix and java-plugin-runner together. Changed (creating, modifying, and deleting) sample java filters during runtime to verify functionality of hot reloading.

Source branch
supportHotLoad branch on https://github.com/ericluoliu/apisix-java-plugin-runner

Related commits and pull requests
N/A

Target branch
main branch on https://github.com/apache/apisix-java-plugin-runner

Hi @ericluoliu ,pls take a look at CI failed.

We need to add documentation to explain how this feature should be used. And add test cases to verify it (test cases can be done later).

@tzssangglass
How should I begin writing documentation for this? Is there a guideline I should follow.
How do I write tests?

How should I begin writing documentation for this? Is there a guideline I should follow.

we can refer to: https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/en/latest/development.md
The documentation needs to tell the user how the feature should be used, and give some examples and validation.
Documents can be submitted with a new PR.

How do I write tests?

I'm thinking about how to test this feature, so if you have ideas, you can share them. Until then we can ignore it for now.

LGTM


check for presence of womtool on path

Use either shutil.which (3.3) or distutils.spawn.find_executable (2.7).
Depends on #26

Close since we have removed the support of womtool


Support CSV files with UTF16 encoding

Is there any way to import a utf16 file? Somehow doesnt seem to work with this iteration of the framework.

Would you mind forking CSVImporter, adding an example CSV file to the tests and write a test that is failing so I can have a look and implement the feature properly?
I'm guessing we just have to change the calls to .characters to .utf16 to fix this (you can try it out yourself after writing the test if you want), but we'll need a test to ensure this keeps working in future changes anyway. Thanks in advance!

Sure no problem I will do it in the next hour or so.

On 15 Dec 2016, at 11:11, Cihat Gündüz<EMAIL_ADDRESS>wrote:
Would you mind forking CSVImporter, adding an example CSV file to the tests and write a test that is failing so I can have a look and implement the feature properly?
I'm guessing we just have to change the calls to .characters to .utf16 to fix this (you can try it out yourself after writing the test if you want), but we'll need a test to ensure this keeps working in future changes anyway. Thanks in advance!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Flinesoft/CSVImporter/issues/12#issuecomment-267275757, or mute the thread https://github.com/notifications/unsubscribe-auth/AMM4YgAc5bkfJkrvE6YYSEP_N_o1uQXTks5rIQRMgaJpZM4LNQ2V.

I will admit I am very bad at unit testing. I haven't covered that bit of the development world just yet. I have forked a version of the repo and added a .csv file there.
Where it fails is when i try to do this:
`let importer = CSVImporter<[String: String]>(path: utf16FileUrl.path)
importer.startImportingRecords(structure: { (headerValues) -> Void in
// Headers
print(headerValues) // Actually prints the whole utf file as single string
}) { $0 }.onFinish { importedRecords in
print(importedRecords) // Actually is an empty array
}`
So jut to reiterate i used your great framework with utf8 files and no issues, meaning I understand how it works but with UTF16 doesnt work simply. the init method where you have TextFile(path... in FileKit you can have path + encoding, i think that needs to be done too. But then the utf8 stuff fails.
Please tell me you can work with this little information...

Sure, I'll have a look, thank you for the CSV file and for trying. It's no problem you don't know how to write unit tests yet, everybody has to pass through that stage at some point and most people are not actively taking part in the open source community as you do at that time, so great you did what you can! ;)
I'll keep you updated once I have some results, stay tuned!

By the way, here are two link tips to help you getting into the world of unit testing:
Video on RayWenderlich.com
Introduction with Links from Apple

I have just done some work to get away from the FileKit dependency for several reasons. We were only using a single class really, so I included it into this project with some changes. This will also help when we need to change anything like the encoding. See the updated stable branch.

@dkalinai You forgot to copy or commit your utf16 example file in your fork. It is only referenced in the Xcode project navigator, but not actually included in git. Could you fix that so I can test if my UTF 16 solution works for you, too? Thanks!

I know why this happened. Apparently there was a problem between the chair and my mac. I have now recommitted the file. And great to hear about the removed dependancy. If you want to go the extra mile you can add either automatic detection of utf16 or allow to specify that somehow in the let importer bit, with utf8 being the default value of course.
And thank you again, you have no idea how much time your work has saved me already.
As for the tests I will have a read and look, i was slightly confused with Nimble and Quick, as I am unfamiliar with them, maybe it makes life easier but not for the beginner in the unit testing world.
Thanks again for everything!

@dkalinai I just released version 1.4.0 of CSVImporter with support for specifying the files string encoding. Note that your file was .utf16LittleEndian encoded (see also the spec I added here).
At first even after allowing to specify the encoding the spec was failing – the reason was, that CSVImporter relies on the structure defined by RFC 4180. In 2.4 the standard specifies the following:

Within the header and each record, there may be one or more
fields, separated by commas.  Each line should contain the same
number of fields throughout the file.  Spaces are considered part
of a field and should not be ignored.  The last field in the
record must not be followed by a comma.

After having a look at your file I found that it didn't comply to the standard, so I removed the commas at the end of each line, then the specs were passing. I hope you can get around this restriction somehow, I don't know where your file came from, but it was not a valid CSV file as it seems.
As for Quick and Nimble: True, my fault, I forgot that I used those in this project. I'm a fan of the DRY principle which Quick helps a lot with and Nimble is so much more readable then XCTAsserts – so I hope those will be the future best practices. The testing stuff is already done for this feature but if you're interested in a better testing framework you might find this post helpful.

Works perfectly, much obliged! I may have inadvertently sent you some copy of the file which i manually edited which resulted in this. In any case you will be happy to know that it works with my utf-16 file out of the box when imported with no workarounds needed. I did use the utf-16le which i was sure my file was not, and everything is super peachy now! thank you man, you saved a lot of nerves today, be proud!

Oh and thanks for all of the helpful advice given, it is very useful.

Glad I could help. 😃


feature request: max. number of frames of an animation

the max. number of frames of an animation shoulf be configurable oder higher then 10

The maximum number of frames of an animation is currently limited by the memory.
It also varies how many frames fit in memory, depending on what was previously displayed, as well as what colors were used.


Improve compile-time target detection for NEON

This PR moves most of the feature management for neon to the build.rs script. If a dependent crate enables the neon feature, that should gracefully compile also on all platforms even though they don't support NEON.
Additionally, I assume all aarch64 targets to support NEON, and the optimization will turn on even if the feature isn't explicitly enabled.
I have a number of questions before this PR is ready for merge:

Is enabling aarch64/NEON by default acceptable?
Should we introduce a no_neon feature similar to how SSE/AVX is handled if the aarch64 defaults to on?
What's the best way to migrate C bindings and CI to cause the least amount of surprises?

This looks great. Thanks for making it so consistent with the x86 code. I'll want to play with it a little bit myself, but then I'll probably land it as-is.

Is enabling aarch64/NEON by default acceptable?

I think we should. It's more in line with what we're already doing on x86, and it'll be a substantial speedup by default for a lot of users. (There was another PR about this at some point, but I think it got stalled in the review/feedback cycle.)

Should we introduce a no_neon feature similar to how SSE/AVX is handled if the aarch64 defaults to on?

That sounds like a good idea, and we could add it to .github/workflows/ci.yml somewhere. Feel free to add that if you like, or we could also land this first and do that as a follow-up.

What's the best way to migrate C bindings and CI to cause the least amount of surprises?

Do you mean the separate C implementation? I think it might be a good idea to make a similar change there. Maybe we could introduce a -DBLAKE3_NO_NEON flag, in line with -DDBLAKE3_NO_SSE2 and others on x86.
I'm not too worried about build compatibility here, since C callers probably vendor their own copy of our code, update that copy rarely (alas), and are more likely to read the patch notes when they do update. I think the impact here will be less than when we added SSE2 support. Also for what it's worth, we do say "Note that these steps may change in future versions" in the build docs, not that anybody reads the docs :)

The downside is the inconsistency with the x86 parts. But the inconsistency goes deeper than the macros, since there is no dynamic dispatch in place..

Yeah this is a good point. Might be worth calling this out explicitly in the build docs. I can add something.
@rsdy thanks for the revisions. I'm going to play with it on my RPi again, make sure CI is green, and then land it. Do you need the Rust code to be in a published release sooner rather than later? Or no rush?

Landed! I'll make a note to cut a release in a week, on the off chance that anyone's actually testing master in the meantime :)

Released as 1.1.0.


[Missing feature]: Warp dust no recipe

General Info

[X] I didn't added any mods
[X] I get this issue consistently in single-player
[X] I get this issue consistently in multi-player
[ ] I am crashing and can provide my crash report(s)
[X] I am using the latest version of the modpack

Your launcher
Curseforge
Modpack version
1.1.1
Describe your issue
Warp dust from Waystones is currently uncraftable. This is a necessary item in order to complete multiple quests.
Ender pearl in the recipe is replaced with a barrier block named "Empty Tag: forge:ender_pearl"
Steps to reproduce the issue

Open JEI to Warp Dust
Left click or press R to view recipe
see unobtainable item as part of recipe

Additional Information

The issue is fixed in v1.1.2


Tiny typo fix

Also trying to see if I can commit after the renaming of the main branch.

Looks good to me. You need to also update https://github.com/buildkite/docs/blob/main/spec/features/reading_pages_spec.rb#L18 I think to make the test aware of the change.


[FR] Include the a rerun command as part of CLI output when running assume

If someone were to run assume or assume -c, then select role Account/MyRole, it would be nice if the CLI showed assume -c Account/MyRole as output.
Users could easily copy that line to rerun if another session were needed. This change would lend to people having easier access (through copy-paste and then command history) to their prior commands.

Good idea, we also have assume --ar which will read the AWS_PROFILE environment variable and assume the same profile again.
Should be simple to add a command output and a hint to use the --ar flag


Populate v18.0.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@ofek This PR seems to be the correct one, it downloads and builds v18.0.0 - Hopefully, the windows build will work (it worked in the DBG PR)

@ofek This is the v18.0.0 PR track, the others were just to debug and test, sorry for the spam - We're getting close, all the dbg  passed, I added the tests to make sure the package builds correctly, since the secp256k1 library is built prior to building coincurve for windows (somehow the setup.py on windows failed in my tryouts)

@carterbox Many packages depend upon v18.0.0, in particular bip-utils for which I have proposed a recipe. So, even though we agreed that the way v18.0.0 is packaged is not conda-forge abiding, I have proposed to add it as a one-off.
For that purpose, and if I understand enough of how the feedstock works, I am proposing to add a branch to the feedstock that will just have v18.0.0
ref: https://conda-forge.org/docs/maintainer/updating_pkgs.html#maintaining-several-versions
Do I understand this correctly?

@carterbox difficilis concessus, venia facilis

@ofek Well, it has to be premised with the fact that I likely do not know enough.
In any case, one of the issue is that for unknown reasons, the SOURCES.txt gets populated with fullpaths, which is not allowed. The only way I found to solve it was to add a prune /* command in the MANIFEST.in
Another is that coincurve installation process on windows, fails trying to access an admin path. But, later it seems that using --single and --record solved it (Note that, the final solution, is a built-up on things I thought were needed as I debugged, but that have not been removed once it worked)
So, building the secp256k1 lib separately was mainly introduced because i had a hard time telling setup.py how to find the unix commands on the conda build environment. I spent several months working on it and I don't remember the details, I simply looked at old commits and pulled them into this one, with faith rather than knowledge
So this PR is likely a convoluted one.
For coincurve, I think one update should be to move to the CMkae-based secp256k1 build, I worked on such PR, but somehow had difficulties, but since then I suggested some changes to SECP256K1 and it may work better now
The advantage of the conda packaging as compared to the PYPI is that secp256k1 can be a standalone conda package that tracks the official repo with very minimal patching, so the libsecp256k1-py-bindings becomes itself a simple as just the CFFI wrap-around, then coincurve could actually become a noarch off ofthe bindings.
But then, you would not have a PYPI packaging solution
All in all, I think the current set is optimal. coincurve remains a standalone package for PYPI, while providing the required building-block approach for conda.

@ofek @carterbox v18.0.0 is live \o/:

Yes, you can maintain multiple versions of a package on a feedstock by having a separate channel for each version. For example, the qt-main-feedstock has a 5.x branch and a 6.x branch.
However, this v18.0.0 branch/build does not comply with our channel policies regarding static linking and licensing. This was the entire reason for working with @ofek to create a new release of coincurve. If you needed the v18.x API for your other packages, you should have submitted a PR to coincurve that wasn't API breaking (one that only updated the build system and used the same version of libsecp256k1) instead of one that caused the creation of a new v19.x API that now won't be used because as you have mentioned, most of your packages require v18.x.
If you don't want to comply with our policies regarding licensing and linking. You are free to create your own conda channel.

@carterbox My apologies. I saw in the manual that there is a mean of retiring build, I will look into it and try to correct this mistake. I do intend to abide by the policy, I do appreciate all the help that you provided, as well as the existence of conda-forge. I also have a channel where I had published a few of these recipes
My faulty understanding of our discussion was that the policy would not allow a live recipe, I thought that a back-porting of a one-time build part of the recipe would be acceptable.
I hope you will allow the benefit of the doubt, as well as understand my eagerness to finally have things "working" for all those recipes that I created a few months ago and forgive this lapse of judgement
Sincerely

@carterbox You hint at a solution, but I do not understand it: you should have submitted a PR to coincurve that wasn't API breaking Do you mean a PR to the cincurve-feedstockthat would download thecommit`-based reference to SECP256K1 un-released version and build v18.0.0 the same way as v19.x API? That is:

Update libsecp256k1-feedstock with a vpre-0.1.0 version

This may entail creating a new build system for that version that did not use CMake

Use that version in coincurve-feedstock v18.0.0

Did I understand your suggestion correctly?
If you meant ofek's coincurve, this would still not be useful since ofek would need to up-version his release to incorporate my PR
Thank you

that the policy would not allow a live recipe

What is a "live recipe"?

@carterbox You hint at a solution, but I do not understand it: you should have submitted a PR to coincurve that wasn't API breaking

Are coincurve v18 and v19 API compatible? If so, this discussion is moot, and you didn't need to build coincurve v18 in this feedstock. pip check will report an error for downstream packages, but that's fine.

Update libsecp256k1-feedstock with a vpre-0.1.0 version

Are you sure that a pre-release version is necessary?
Is there not a stable release of libsecp256k1 that is API compatible with the commit referenced in coincurve 18.0.0?
https://github.com/ofek/coincurve/blob/v18.0.0/setup.py -> https://github.com/bitcoin-core/secp256k1/commits/ddf2b2910eb19032f8dd657c66735115ae24bfba -> November 16, 2022 -> https://github.com/bitcoin-core/secp256k1/commits/v0.2.0
Could you please try compiling coincurve v18.0.0 using libsecp256k1 v0.2.0? It looks like the changes between ddf2b2910eb19032f8dd657c66735115ae24bfba and v0.2.0 are minimal as far as the API is concerned (the headers in /include). As far as I can tell, the only changes to the headers are backwards compatible.
If that works, you can build coincurve v18.0.0 against libsecp256k1 v0.2.0. If you need to carry patches in this feedstock which modify coincurve's setup.py so that it dynamically links to libsecp256k1 v0.2.0, that's fine.


Update VSCode demo

add comment
add version
add action, giving it a name
add invalid uses property, show diagnostics, then fix it
add workflow
resolve on, showing completion list
add resolve an action, showing completion list
rename the action
modify secrets, indented wrong, then format it
fold the secrets, then unfold, then action, then unfold
find reference on the action,

:tada: This issue has been resolved in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Show a message when no links are available

Is your feature request related to a problem? Please describe.
Right now when there are no links present on first login of the user, the page remains blank without any message being shown
Describe the solution you'd like
Add a message saying no links present with a good matching illustration indicating it and a swirly arrow pointing towards the add button on the bottom right
Additional context

HI, I'd like to contribute to this issue. Do I need some credentials (like firebase and stuff)?

HI, I'd like to contribute to this issue. Do I need some credentials (like firebase and stuff)?

Hey, yes you will need a free Firebase account, just follow the README

@monizb hey, just to be clear, we want to show this sign just the first time user signs in the app or we would like to display this everytime the user signs in to the platform?

I'd like to propose an approach which in my opinion is better. I think showing a tooltip would be a lot better than using the arrows because I think it's difficult to point to the exact spot.

@prashantacharya the message and the images should appear always when the user has no links associated with his account like when:

The user has just signed up
The user has not created any links
The user deleted all his links

Basically everytime there are no links. Also the tooltip part wouldn't be ideal, what you could do instead is in the message also add "Press the + icon below to get started

@monizb I'll have a look at it.

Hi @monizb, is this issue still open (@prashantacharya can I help you perhaps)?

@TaarnStar sure. I've been occupied with some work lately.

@prashantacharya I have already made the showing of the message when no links are present (after loader is finished loading), I still have to put a bit of style in it. Maybe tomorrow will be finished and will send the PR

@monizb I made two versions, can you tell me which would you prefer or if I must change something before i create a PR?

hey @TaarnStar the message looks great, jus tplease change the background image to this: https://icons8.com/illustrations/illustration/pixeltrue-search
Thanks!

Hi @monizb, i see you merged the PR but the issues is still open. Is anything wrong with the PR and need to change anything?

@TaarnStar sorry I had not linked the PR to the issue so it didnt close automatically, thanks again!


work around to support TinyXML2 5.0.0

This is the most minimal patch I could make that fixes https://github.com/eProsima/Fast-RTPS/issues/113.
A more complete fix might be to convert that custom FindTinyXML2 file to always produce an imported target and update the rest of the project's CMake code to not depend on things like TINYXML2_INCLUDE_DIR and TINYXML2_SOURCE_DIR.

Thanks @wjwwood


Solve dangling pointer in Collider map.

There may be dangling pointers inside the collider maps.

Solved in last commit, deleted transform component twice.


SCMOD-13716 Changes to patch file for disabling weak algorithms as a side effect of rpm version change.

Updated the patch to be able to update java.security file installed as part of java-11-openjdk-<IP_ADDRESS>-lp<IP_ADDRESS>.x86_64.rpm
The patch has been generated by adding the desired change to java.security file and then generating the patch file with diff command.

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/CAFapi/job/CAFapi~opensuse-java11-images~SCMOD-13716~CI

The build is pending and will be once the desired host is provisioned. https://teams.microsoft.com/l/message/19:f184abf299c9438896ad41ee63ee7136@thread.skype/1621847701120?tenantId=856b813c-16e5-49a5-85ec-6f081e13b527&groupId=e3a424d9-7343-4833-a146-3862351bd4da&parentMessageId=1621847526602&teamName=%23rel-eng&channelName=ask_release_eng&createdTime=1621847701120


storybook(react): color styling bug in code preview

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/ocBruno/components/tree/feat/support-search-position
Fork repo
yarn && yarn run dev && yarn run storybook
Open storybook and see Navbar -> Navbar w/ linked list code preview

Expected behavior
Correct color styling as is working in the default example.
Screenshots
Wrong Behaviour Preview:

Edit: Recently noticed this paragraph text is also rendering with the wrong color styling.

Expected Behaviour preview:

Code snippets
After debugging I realized the problem might be related to nesting as it only happens when we add children to the link-list object's children property,
.add('Dark navbar w/ linked list', () => (
<Navbar
bg="dark"
variant="dark"
navItems={[
{
type: 'icon',
src:
'https://raw.githubusercontent.com/HospitalRun/hospitalrun.github.io/master/favicon.png',
onClick: () => {
Toast('success', 'Icon clicked!!', 'Success')
},
},
{
type: 'header',
label: 'HospitalRun',
onClick: () => {
Toast('success', 'Header clicked!!', 'Success')
},
},
{
type: 'link',
label: 'Link',
onClick: () => {
Toast('success', 'NavLink clicked!!', 'Success')
},
},
{
type: 'link-list',
label: 'Link',
onClick: () => {
Toast('success', 'NavLink clicked!!', 'Success')
},
children: [
{
type: 'link',
label: 'Sublink1',
onClick: () => {
Toast('success', 'Sublink1 clicked!!', 'Success')
},
},
{
type: 'link',
label: 'Sublink2',
onClick: () => {
Toast('success', 'Sublink2 clicked!!', 'Success')
},
},
],
},
{
type: 'search',
placeholderText: 'Custom',
buttonText: 'Text',
buttonColor: 'secondary',
onClickButton: () => {
Toast('success', 'Search button clicked!!', 'Success')
},
onChangeInput: () => {
Toast('success', 'Search box changed!!', 'Success')
},
},
]}
/>
))
System:
Environment Info:
System:
OS: Windows 10 10.0.18362
CPU: (12) x64 AMD Ryzen 5 3600X 6-Core Processor
Binaries:
Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.21.1 - C:\Program Files\nodejs\yarn.CMD
npm: 6.12.0 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 44.18362.449.0
Additional context
Pardon the linked list typo it's meant to be link list.
If any questions appear or any info is missing from the issue leave a comment!

I'm having this bug with csf and addon-docs also, i'm not sure which addon in this issue is depreceated

@ocBruno This issue is for addon-info. Let's discuss the addon-docs bug in https://github.com/storybookjs/storybook/issues/9718
Even if they end up being the same underlying issue, I am prioritizing addon-docs fixes and de-prioritizing addon-info fixes since we're deprecating it and there are already an impossibly large number of issues to deal with.


genetics-app travis fails

See
https://travis-ci.org/opentargets/genetics-app
It says

Browserstack access_key is invalid.

@peatroot @mirandaio Hi guys! The access key must be empty now?

Ticket closed as Travis work will be captured in new deployment work #449


Attributes - how to specify/require/query them?

I can't find how to specify in metadata.xml what attributes my SP requires from IdP.
When I add my SP metadata xml to my https://samlidp.io/ IdP, I get this message

How to make AttributeQuery? As I understand this is not implemented?
On user login (on AuthnRequest Response) I want to make an AttributeQuery and abort login process if IdP doesn't provide the required attributes (for example email, First Name, Last Name).

P.S. This bundle is a big machinery for me, so sorry if this question is too obvious for you. I have spent almost a week inspecting it and still no clear vision about its internals.

It works only when email switch is ON, otherwise I get null in
// UserCreatorInterface
$this->usernameMapper->getUsername($response)


Add in the ability to switch off certificate validation

I think it would be good to add this -- most tools seem to support it. However of course, it is not an alternative to us getting the certs working


Not working

Tried to view the demo but I'm not seeing any visualization rendered. Others are having similar issues, see: https://www.reddit.com/r/javascript/comments/3lp1a7/javascript_promises_visualization_stepbystep/

I'll need more info. What browser? Any errors in the console?

I linked to the reddit since there were various browsers/platforms affected. Safari Mobile and Chrome 44 on Windows/OSX. Others will probably chime in on there too.
VM157:2 Uncaught SyntaxError: missing ) after argument list is on the console.

Same here, Version 44.0.2403.89 Ubuntu 15.04 (64-bit).

I don't have any issues with Chrome 45. Can you confirm that the issue is some feature of the user code by trying out this url?
http://bevacqua.github.io/promisees/#code=new+Promise(function+(resolve)+{
++setTimeout(resolve%2C+2000)
})

This gives me Uncaught TypeError: z.matrix.findIndex is not a function – demo.min.js:20.

Perfect. Needs more polyfills! :)

Try now. I added a polyfill for findIndex. Also please try any ES6 code input after clicking on the Babelify checkbox that I added which compiles code to ES5

Works now for me with active Babelify checkbox. Thank you :smile_cat:


🚀 supercharge tags performance

closes https://github.com/TryGhost/Ghost/issues/8540

use {{vertical-collection}} in the tags dropdown filter list, opening the dropdown is now virtually instant as it's not attempting to immediately render components for every tag in the list
remove pagination/infinite scroll from tags screen
load all tags when accessing the tags screen

will pause to show spinner if no tags have previously been loaded
if tags exist in the ember data store, show the list immediately and load/update list in the background

use {{vertical-collection}} to render enough tags to fill the scrollable area with a small buffer and use occlusion and element re-use to swap tags in whilst scrolling (suuuuper fast no matter number of tags loaded)
scroll tags into view when they are selected (keyboard nav now makes a lot more sense)
tested with 875 tags and 2x/5x CPU throttling with no major slowdowns 🎉

TODO:

[x] implement {{vertical-collection}} for the tags dropdown to speed up rendering
[ ] see if there's a way to scroll to tags that are in the occluded area

edge-case, only relevant when accessing the individual tag route directly - everything works at the moment but the active tag isn't scrolled into view
may be possible by using tag index and scrolling to calculated height rather than using browser's element.scrollIntoView())

NB: I'm leaving the scroll-to-tag TODO for now, it's a nice-to-have for an edge case and we can re-visit if needed later once the tags screen has been redesigned

Coverage decreased (-0.2%) to 72.893% when pulling e11669757aae0e11a242ec63356e18f87c368e21 on kevinansfield:soo-many-tags into a0574125fff37df7d79d3c0d9b7fb7d0fdc7c0cd on TryGhost:master.

Coverage increased (+0.1%) to 73.224% when pulling e7b378ea053e376ccc303e1a2791a9bf5fb8e864 on kevinansfield:soo-many-tags into a0574125fff37df7d79d3c0d9b7fb7d0fdc7c0cd on TryGhost:master.

When i run grunt dev i see now:
===================================================================
	Vertical Collection
	:: Including CSS for Visual Debugger
	:: (included in non production builds only)
	:: To use, set {{#vertical-collection debug=true}}
	:: To debug your applied CSS rules, set {{#vertical-collection debugCSS=true}}
===================================================================


Add e -> !!e transformation

We have seen cases where driver bugs are worked around by replacing a boolean expression e with !!e.  We should add this as a transformation.

Fixed by #260


Undesirable messages when synchronizing

This is more a cosmetic issue than a real bug.
With Android 4.4.2 and K9 5.006, with two IMAP accounts configured, I'm in the Unified inbox view.
I scroll down in order to trigger a synchronization.
Synchronization is launched as expected.
In my case, no new mail is to be fetched, you may acheive this by sequentially synchronzing several times, as I've done.
Even though no new mail is to be fetched, several synchronization messages (I count 4 messages) are written in the "top" bar of the application (where all icons are shown : battery level, wifi level, GSM level, time, ...).
The same message is written each time (in my french version) : "Vérification des courriels:" with no information.
Even though I may understand the genericity of such a solution, I find it bothering.
As there is already an icon, at the bottom of the screen, that indicates an in progress synchronization, there is no need to display these messages.
My expected behaviour would be :
1- do not display the messages if the application is open and is already displaying the information
2- in the other cases do not display 4 times the same message

Obsolete in current 6.* version.


Add moment-hooks to the list

Not sure how to contribute with a new library but I have created this pull request with a link to my new library.

Thanks :)


PYIC-2936: Clean up process-journey-step state machine removing unused stub events

Proposed changes
What changed

Removed unused events in process-journey-step and select-cri
Renamed ukPassportAndDrivingLicence and ukPassportAndDrivingLicenceF2F to multipleDocCheckPage and multipleDocCheckPageF2F respectively

Why did it change
Remove redundant code and make existing code cleaner.
Issue tracking

PYIC-2936

Checklists
Environment variables or secrets

[x] No environment variables or secrets were added or changed

Other considerations
None

This might need to be done in multiple steps so that we have zero downtime during the deploy. We have to account for one change happening before the other. e.g. add in extra events to the states and deploy. Change the code to use the new events, deploy. Clean up the old states. 🤔

I'll update it now.

Replaced with https://github.com/alphagov/di-ipv-core-back/pull/901


smooth_landmrks works on pose_world_landmarks as well?

Please make sure that this is a solution issue.
System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in Mediapipe):No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4):IOS
MediaPipe version:0.8.9
Bazel version:5.2.0
Solution (e.g. FaceMesh, Pose, Holistic):Pose
Programming Language and version ( e.g. C++, Python, Java): obj-C

Describe the expected behavior:
In my thoughts, smooth_landmrks works on pose_world_landmarks as well. However, it looks not
Standalone code you may have used to try to get what you need :
If there is a problem, provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab/repo link /any notebook:
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:
Hello, google team
MediaPipe is a powerful tool for 3D animation; however, the pose demonstration APP cannot satisfy the requirement of smooth motion even if the smooth_lanmarks is set to true. This must be resolved for more applications with Mediapipe. From my observation, the normalized landmarks on the screen look stable, but the pose_world_landmarks are not as stable as normalized landmarks. It makes me doubt whether smooth_landmarks works on pose_world_landmarks as well. I believe it does not, based on my experience. Please confirm whether my conjecture is true or not. Thank you!

OK, I got the solution, the one_euro_filter's parameters are too weak to suppress jitters on pose_world_landmarks. We need enhance these parameters. Hope you guys check those parameters. Thanks.

Hi @fchen09, Could we move this to close status as the issue has been resolved as per the above comment. Thank you!

Hi @fchen09, Could we move this to close status as the issue has been resolved as per the above comment. Thank you!

Sure, thanks!


reclassify children of Disorders of amino acid metabolism

and Organic aciduria
address #4985

close- need to redo this


[FAB-17992] Remove ledger blockstore data for a channel

Signed-off-by: Wenjian Qiao<EMAIL_ADDRESS>Type of change

New feature

Description
Add a Remove function to block store provider to remove block index
and blocks directory for a channel. It will be called by the orderer
and peer as part of channel deletion.
Additional details
This PR adds the remove function to remove the block indexes and blocks dir for the channel. It is expected that the higher level above block store to handle failure recovery.
The PR is based on  the current BlockStoreProvider design.

no concurrent calls to BlockStoreProvider
BlockStoreProvider is not thread-safe, the caller manages thread-safe
only one ledger instance is created/opened for a particular ledger, all the time.

The opened BlockStore for the removed channel should not be used any more because it will return invalid data. If needed, we will close the blockstore and make it unusable in a separate PR.
Related issues
Story: https://jira.hyperledger.org/browse/FAB-17992
Epic: https://jira.hyperledger.org/browse/FAB-17712

@cendhu Thank you. I have addressed

@cendhu Thank you. I have addressed your comments.

/ci-run

Got intermittent failure and opened FAB-18030.
2020-06-26T12:40:02.0392904Z Waiting for: 2020-06-26T12:40:02.0393318Z Removing member: Endpoint: <IP_ADDRESS>:21514 2020-06-26T12:40:02.0393516Z 2020-06-26T12:40:02.0393800Z /home/vsts/work/1/go/src/github.com/hyperledger/fabric/integration/gossip/gossip_test.go:343


Filter link

This crate doesn't give any solution to link two filters (thanks to avfilter_link)

Depends on #193


drush ssh trips up when branch has slash in it

Calling proc_open(ssh -o PasswordAuthentication=no -t feature 'cd /algm-311--lagoon && bash -l');
ssh: Could not resolve hostname feature: Name does not resolve

Thanks for opening this up @rtprio
For anyone that picks this up, @carloshmiranda and I are happy to help with testing or reproducing

Tested drush 8.1.16 - same story as lastest stable


Langteam sync 10 17

I started with #12 as the basis, so this is actually a much smaller PR than it appears


DatePicker's calendar is not scrolling(Remaining static)

Title line template: DatePicker's calendar is not scrolling in sidebar
Detailed description
I'm using DatePicker component and this component is taking window object as a reference to move on scrolling
But in my case i have kept DatePicker in sidebar which has it's own scroll.
When scrolling the side bar the input of DatePicker only is moving and the calendar popup is remaining static
When the outer part (outside the sidebar) is scrolled,then only the calendar is moving.
I want the calendar to work even in sub scrolls(scroll inside scroll).
i.e. How to make this work in side bar which has it's own scroll
Steps to reproduce the issue(I'm using ReactJS here)

Step one: Place the component inside this div

---place the datepicker comp here---

Step two:Click on the DatePicker Input area

Step three: Scroll(The calendar popup will remain static,where as inputarea will move)

Initially

After Scrolling(Calendar remain static)

@marijohannessen probably has the most knowledge in this area


fix(dashboard): fix a few styles

Summary

fix an alignment in the dashboard header
fix editpage so I can set buttons relative to it

:tada: This PR is included in version 1.91.1 :tada:
The release is available on:

npm package (@release-1.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


brave new coin and refactored config

Added first method of BNC (its a feed) and refactored config (it is in libs).
I also move the config logic within the actual classes as opposed to passing an attribute to the class. It seems neater this way, but is debatable. Let's chat about this...

Merged so that I can base my other branches off of it.


PHP Refactoring to facilitate testing and 3P plugin integrations

Feature Description
When working on #113 and #1117 it has become apparent that the PHP refactoring originally tentatively planned for post-stable  is becoming more urgent.
We currently use a colorful mix of static class methods, and classes instantiated at various stages without the possibility to easily modify their behavior.
Example:
For #113, we'd need to be able to remove all the filters added by the Discovery class. However, this is currently not easily possible.
This is a good opportunity to reduce technical debt on the PHP side of things.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

More robust but not overly complex plugin architecture
Ideally first drafted in a design doc or proof-of-concept PR
3P plugin integrations are more easily possible

Implementation Brief

The current PHP code, relays to much on static methods and class consts. It makes for extremely messy code and hard to understand dependency tree. There is also poor use of Object-oriented programming principles.
I have already had some thoughts on the refactor. I think we have 2 options.

Refactor the code to namespaces + functions.
Simple don't use objects at all and use namespaces functions.

This gives some benefits.

Simple to understand and maintain code.
Functions are very re-usable
Simple to understand for javascript developers.
Pitfalls.
Old fashioned code style.
Requires use of globals to track state.
Not how PHP is normally used.

Refactor the code to use objects, dependency injection ( with name spaces ).

I have had some great success with this pattern. Take the following example.
class Plugin{
     public $example;
     public $settings;

     public function init() {
          $this->example = new Example($this);
          $this->example->init();

          $this->settings = new Settings( $this );
	  $this->settings->init();
    }
}

class Example{
      protected $plugin;

     public function __construct( $plugin ) {
         	$this->plugin = $plugin;
    }

    public function init(){
        add_action('init', [$this, 'test]);
    }

    public function test(){
       echo $this->settings->get_option();
    }
}

This model is very clean, as each object has it's purpose. But we are using dependency injection, in test, it is easy to make the plugin object passed to example pass.
This should stop requiring the need for static methods and consts. As class varibles should be passed via the plugin object.
I also think that trait and parent classes could be used to reuse code.
These are just some thoughts, it might be worth making a design doc.

Might be worth using a tool like this to see how the code is laid out - https://github.com/mamuz/PhpDependencyAnalysis

@spacedmonkey Thanks for writing this up!
When we first started with this plugin I was leaning more towards something like the former option, to keep everything simpler. However, the code base is inevitably growing, and more PHP functionality is being added more quickly than I originally anticipated.
The current code is indeed not great, but in the spirit of fast iterations it was an acceptable tradeoff. Now, I think proper OOP with DI makes sense.
Have you seen the https://github.com/google/site-kit-wp/ source code? It's proven to be working well, and I feel like we could quickly adapt that for us. No need to reinvent the wheel. WDYT?

Looking at the sitekit source code, is does similarly weird things that this code base does like this.
This has nested functions. It is hard to read and even harder to write unit tests. I am not sure this is the best model to follow. I also think that having anonymous functions hooked into filters and actions is bad practice for plugins. It makes it impossible to remove that filter.
What was documented above is how the XWP template plugin ( called wp-foo-bar ) works. Many of XWP plugins are been build using the template with great success.
Setup of the plugin class looks like this.
Here is a sample sub class looks like this.
I honestly don't think it would take that long to refactor, we already have a central plugin file. I think we just need to the following.

Add class variables for all the classes.
Add plugin instants to contractor of all other classes.
Move code from anonymous to class methods.
Make some methods public to make the testable or use reflectionmethod in tests.
Add gettings for Class constants ( to support older PHP versions ).
Convert all places in code where classes are cross referenced.

This sounds like a lot, but I think I could turn this around very quickly.

Looking at the sitekit source code, is does similarly weird things that this code base does like this.
It makes it impossible to remove that filter.

Yeah I think this exact pattern we'd want to avoid 🙂
We do want to make it possible to remove filters. That's the key point for this and #113.

I think we just need to the following. [...]

Seems like a good direction.
@spacedmonkey As a proof-of-concept could you perhaps create a PR that rewrites the Discovery class as per your vision?
I want to validate that:

this approach works
this allows other plugins like Yoast to remove filters

Also, WDYT of using a Context instance like Site Kit does and passing that around (instead of Plugin)?

@spacedmonkey As a proof-of-concept could you perhaps create a PR that rewrites the Discovery class as per your vision?

Discovery is a bad example. It it already pretty OOP. The only thing I would change is remove some of static methods. See this. I think media is a good example, as this has lots of static methods.

Also, WDYT of using a Context instance like Site Kit does and passing that around (instead of Plugin)?

It seems to be the same thing, but with a different name :P

As talking point, I have done a little POC, https://github.com/google/web-stories-wp/pull/2588
I have added comments to understand what I have done here.

I did a little research into good pattern of plugins design in the WordPress space.I still think that wp-foo-bar is the better pattern. It avoid some bad practice in PHP development.

Single responsibility classes.
No singletons
Avoids static methods.
Avoid anonymous functions.
Uses namespaces.

@spacedmonkey Is there anything left here that you think we should tackle?

I think we could improve testing, but I think that should be it's own ticket. I think we should reuse https://github.com/google/web-stories-wp/issues/328 for this and expane it's scope.
I am going to move this to done now.


Add TaskBookParser

Fixes #87.

Codecov Report

Merging #92 (1120f38) into master (71a43e8) will decrease coverage by 0.35%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     72.15%   71.80%   -0.36%
- Complexity      399      408       +9
============================================
  Files            70       78       +8
  Lines          1232     1259      +27
  Branches        125      127       +2
============================================
+ Hits            889      904      +15
- Misses          311      320       +9
- Partials         32       35       +3

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...dress/logic/commands/categoryless/ExitCommand.java
100.00% <ø> (ø)

...u/address/logic/commands/tasks/TaskAddCommand.java
50.00% <50.00%> (ø)

...ddress/logic/commands/tasks/TaskDeleteCommand.java
50.00% <50.00%> (ø)

.../address/logic/commands/tasks/TaskListCommand.java
50.00% <50.00%> (ø)

...s/logic/parser/contacts/ContactCategoryParser.java
50.00% <50.00%> (ø)

...address/logic/parser/tasks/TaskCategoryParser.java
50.00% <50.00%> (ø)

.../logic/parser/categoryless/CategorylessParser.java
75.00% <75.00%> (ø)

...ava/seedu/address/logic/parser/TaskBookParser.java
88.88% <88.88%> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
75.00% <100.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


dsl api documentation

This PR adds the initial implementation of the auto-generating documentation.
demo: http://sheehan.github.io/job-dsl-plugin/
Steps for publishing the docs:

Run ./gradlew generateApiDoc

This will create a JSON file in /job-dsl-plugin-viewer/data/dsl-<version>.json

Add the version to the select at /job-dsl-api-viewer/index.html if not already there
Run ./gradlew :job-dsl-api-viewer:publishGhPages

The generator will use JavaDoc for the method documentation. For longer docs, you can create a markdown file in job-dsl-core/api-docs/ instead. I've moved a few docs there from the wiki so far.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

any thoughts on this @daspilker ?

Sorry, my Job DSL time went into the preparation of my JUC talks.
Why is this 56K LOC? Why is the framework larger than the content?

Most of that is from update-center.json, which i copied from http://updates.jenkins-ci.org/update-center.json. That's used to get plugin metadata. We can link to it directly, but I noticed that it hangs sometimes.

The update-center.json should be fetched at runtime. The infrastructure is unstable, but in that case I can't cut a release because other parts of the infrastructure may also be unavailable. And I would probably need to update the file before each release to get the latest plugin infos.

So you're saying you want to link directly to jenkins-ci.org?

Not necessarily, but it could be a build artifact which could be downloaded a build time. And what about job-dsl-api-viewer/dist and job-dsl-api-viewer/src/vendor? Aren't those build artifacts as well?

Which build do you mean? "Fetch the latest update-center.json" could be an item in the steps above. job-dsl-api-viewer/dist is an artifact of the grunt build. But you only need to run the grunt build if you make changes to the website code.

I would like to avoid checking in any non-source artifacts to avoid a mismatch between the source artifacts and generated artifacts. That includes data/update-center.jsonp, dist and src/vendor. How about adding a Grunt/Gulp plugin to the Gradle build to run the Grunt/Gulp build when running the generateApiDoc and/or publishGhPages tasks (or a separate new task)?
Apart from the details, what would be the general plan to migrate to the API viewer? Do we still need the wiki? Do we need to maintain the docs for the wiki and the viewer in parallel? And for how long? When and how do we fill in the necessary Groovy docs?

I see the benefit in having a gradle call that pulls down the latest update-center.jsonp.
I checked in the generated artifacts into dist so that anyone can run the doc page locally without having to install npm/gulp and build it. The way it is now, the only time anyone has to do a gulp build is if they change something with the web src, which would probably be rare.
I'm not sure what you mean with artifacts in src/vendor because that's just third party libs included in the index.html.
For migration I think it might be best to start after the next release is cut. I can move the existing wiki info over and I don't think it'll take that long. Its just a matter of moving the larger items to job-dsl-core/api-docs/ and everything else inline. It should easily be done by the time we want to finalize that release.

I sent you a PR with a proposal for the Gradle/Gulp changes that I had in mind, see https://github.com/sheehan/job-dsl-plugin/pull/1.
I'm not a huge fan of a big bang change. I would like to concentrate in the job/view/folder reference pages first, get that right and then think about the rest. IMHO the reference page are currently the biggest pain point because the job reference page is huge and the code examples get scrollbars if they exceed a width of 78 chars.
But let's get the build stuff done at first.

sounds good

is this ready to merge then?

I want to review the JSON generator and fiddle with moving the docs to the class level GroovyDoc instead of using markdown files. So the docs will be available in an IDE and the API viewer. But I need to check if I can reuse the GroovyDoc generator classes for that. It may take some time.

Yeah i wasn't thrilled with having external files, but having detailed docs with html and multiple examples in the method javadoc also seems like a pain. How would you do it at the class level?

OK, code blocks in javadoc is a pain. But I still want the text to be there on method level for IDE support. How about moving the examples to external files and the text to javadoc? The examples would be plain DSL scripts with one or more job definition (or whatever). As a bonus we can add a test suite which runs the examples to verify them.

Good idea. How do you want to reference them from a method? Using a naming convention (like it is now) or maybe having an annotation the takes the path(s) as a value?

I like the naming convention, an annotation on many DSL methods would cause clutter.

I've updated http://sheehan.github.io/job-dsl-plugin/ with the latest. I added your changes and made the updates we discussed in the other PR. I removed the markdown reader dependency since we only had the one markdown file left, and moved it to a .hbs file. I also updated the context methods so that they appear within the method signature if you click on the expand button. I have a few more tweaks and some cleanup to do, but I should get to that in the next few days.

Nice!
I noticed that the syntax highlighting is not working correctly. E.g. on http://sheehan.github.io/job-dsl-plugin/#path/queue the language auto-detection seems to choose Ruby rules, it adds a ruby class to the pre element highlight groovy hljs ruby. I tried updating highlightjs to 8.7 and configure the auto detection (http://highlightjs.readthedocs.org/en/latest/api.html#configure-options) but neither helps. Maybe the code snippets have to wrapped with a code element as in the examples (https://highlightjs.org/usage/)?!? But that's only a minor issue an can be solved later.

I started to add GroovyDoc and examples for the view reference. I'm really looking forwards to launch the API viewer!
But I found some more issues:

Inner enums are shown with a dollar sign, e.g. statusFilter(javaposse.jobdsl.dsl.views.ListView$StatusFilter filter). Can you change the dollar sign to a dot since that's for syntax to be used by users for importing etc?
Tags are visible in Inline comments with markup, e.g. // Upload the stream as user content. Can you remove the tags for inline comments?

Ok I've fixed those two issues. Also I'm not sure why that ruby class pops up, but I added a line to remove it for now.
Did you want me to rebase this branch?

Great! Yes, please rebase and force push the branch.
I noticed another issue. Example from methods in ViewFactory are not picked up. I tried to place them in a ViewFactory and in the DslFactory folder, but neither works.
I hope that my issue reporting does not sound like complaining. I :heart: the API viewer.

Ah, scratch the last issue. Don't know what went wrong, but it's working now.

No worries :) It's good you're catching these issues now. Latest PR is merged and the branch is now rebased.

Very nice!
I tested the search feature. To go back to the tree navigation, a user must delete the search text. Can you add a button or something like that to go back to the navigation? Or is there another way to go back? And what's the purpose of showing the plugins in the search results? Clicking on a plugin has no effect and then I thought the results are grouped by plugin, but that does not seem to be the case.
There are 3 TODOs left in the API generator. Can you add the minimumVersion to the JSON and display the value in the viewer? The plugin ID is stored on method level in the JSON, but I think the version should be on signature level. There can be a signatures foo(String a) and foo(String a, String b) with different minimumVersion versions because option b has been added in a later version. I don't mind if you remove the other 2 TODOs, we can deal with that later when necessary.
When adding the examples, I did a lot of copy&paste of examples for inherited methods. See the configure.groovy files for each view type. On one hand I wanted the example to show the selected view type, but on the other hand doing lots of copy&paste seems to be wrong. And the job types have a lot more inherited options... It's OK for now, but do you have an idea for solving this?

I implemented one of the remaining TODOs in the API generator. Examples will now be resolved from super classes as well. See https://github.com/sheehan/job-dsl-plugin/pull/6.
I'm working on migration the job reference, there is still plenty of time left until my planned release date. I will not copy&paste the examples for common job options, so the example from the Job class will be used. The current reference also shows the examples for free style jobs, so it's OK for the API viewer.
There are a lot of enums in the DSL and I started to describe the enum values in the GroovyDoc, but that seems to be wrong. Can you make the enums clickable so that they show their options, e.g. with a new detail page for enums?

I tested the search feature. To go back to the tree navigation, a user must delete the search text. Can you add a button or something like that to go back to the navigation?

I'll add an X button to clear the search.

Clicking on a plugin has no effect

There was a bug. Should be fixed now. It's supposed to show the plugin name, description, and list of DSL methods.

Can you add the minimumVersion to the JSON and display the value in the viewer?

:+1:

Can you make the enums clickable so that they show their options

:+1:
So three things on my todo list. I should get to them in the next couple of days.

Cool.
I made some progress with migrating the job reference. Now I "only" need to migrate the wrappers, steps, publishers and build parameters until it's done. I published a snapshot to http://daspilker.github.io/job-dsl-plugin/.
I noticed that the plugin links are missing for the top-level methods. That's because of my idea to use DslFactory as a starting point for the generator. I will try to move the @RequiresPlugin annotations to the interface and change the AST to look at the interface as well.
I used some internal links (@link tag), see http://daspilker.github.io/job-dsl-plugin/#path/userContent. They are currently broken. Is there a chance to fix that?!?

I have to add two more items to your todo list.
Have a look at https://sheehan.github.io/job-dsl-plugin/#path/job-steps-copyArtifacts. The methods with more than two parameters use a different closure type than the method with two parameters. But when expanding the closures, the same contexts are shown. The JSON is correct, so it seems to be a display problem.
When using a link that points to a deeply nested context, the contexts are correctly expanded in the navigation tree, but the relevant context may not be visible and the user has to scroll to find it. Can the navigation be scrolled so that the context is visible? And can you highlight the selected context in the navigation? Sometimes is hard to find the selected context.

The methods with more than two parameters use a different closure type

Ugh :( I didn't know about that. Currently the tree and the url format assume one context per method name. I'll take a look at changing that.

I'm thinking of adding method signature info to the url path like:
http://localhost:8080/#path/job(String,Closure)-steps(Closure)-copyArtifacts(String,Closure)-flatten
so we can follow contexts by signature. But I'm not sure what to do about the tree. I would have to list out each signature, I think.

Hm, right, I haven't thought about the tree and the URL format. That sounds like fundamental changes. I like the URL path with the signatures, but the tree will be crowded if each signature is shown. I could probably live with a temporary solution since the problem will go away when the deprecated copyArtifacts methods are removed.
I migrated everything except for most of the publishers. I hope that there are no more corner cases.

I like the diff stats: +4,227 −7,946. Better documentation with fewer lines!
I have two items left on my todo list. ViolationsContext uses methodMissing to implement a lot of methods and those do not show up in the docs. I will change the context to use explicit methods. And I will remove the instructions for the old docs from CONTRIBUTING.md since the migration is complete.

Awesome!
I'll push out fixes for my remaining issues tonight or tomorrow.

I've added a clear search button, fix for copyArtifacts, and the highlight/scroll of the selected tree node.
I spent a long time working on adding the method signatures to the url path, but ended up shelving that for now as I couldn't figure out how to make it work properly with the (non-signatured) tree.
I still need to add the min plugin version and the enum page. I should be able to get to that tomorrow.

Nice work!
The buildSelector closure within copyArtifacts is not expandable. Can you have a look at that?
copyArtifacts(String jobName) {

    // Selects the build to copy artifacts from.
    buildSelector(Closure selectorClosure)

For some reason the closure param in CopyArtifactContext#buildSelector isn't getting a DelegatesTo annotation. If I explicitly add one it works.

OK, thanks for your analysis, I will have a look.

I've added the minimum version above the signature. I also listed the enum options below the signature doc. It would probably be best to have the enum as a separate page as you mentioned, with documentation for each value, but this should help for now.

Awesome. I updated the GroovyDoc to not list the enum options. I think we are ready to go for the next release, so I merged the branch. If you want to do some tweaks, just open a new pull request.
This was probably the biggest PR ever for the job-dsl-plugin with 50 commits! And probably also the one that took the longest to get merged. Sorry about that, but I did not have any time until my parental leave in July/August to work on this.

:+1:
Thanks for all the feedback and for migrating those docs.

I pushed the first changes for 1.39 (BuildParametersContext.listTagsParam). When I toggle the version selector, the detail view does not change. Can you have a look at that?