[BUG] Making action red accessible against #FAFAFA background

• our previous red for outline buttons did not have sufficient contrast against the content background (#FAFAFA)
• I adjusted the color down and it now has 4.59:1 contrast
• after merge, I will backport to 0.13, 0.12, and 0.11
Tested in:
✔ Chrome
✔ Firefox
Closes: #2701
Signed-off-by: Scott Mathis<EMAIL_ADDRESS>

I'm pretty sure that the changes in src/dev/src/app/color/color-palette.ts update the website?
Is there another page outside of the color palette docs that lists the red?


[MI-2209] Added slash command for repos

Added a command to open the subscription modal.
Added a command to list all the repo subscriptions.
Added a command to delete a repo subscription.

@ayusht2810 I took a pull from MI-2193 because of some changes in the slash command by Abhishek. I think that's why it shows Abhishek's commits on that branch here.

@raghavaggarwal2308 also fix the behaviour that we discussed on call

@raghavaggarwal2308


Script in Powershell to start the App Locally

Purpose
On Mac you cannot run .cmd files
Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type
What kind of change does this Pull Request introduce?
A new script in PowerShell to start the application locally

[ ] Bugfix
[ X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Change the App folder and run the new file.
What to Check
That the application starts locally
Other Information

@microsoft-github-policy-service agree [company="My self, Miguel as an Individual"]

@microsoft-github-policy-service agree


Add prototype for API extractor in CI

Allows for verifying API surface changes as part of continuous integration changes. Some notes:

All JSDoc linting needs to be disabled, otherwise the exit code becomes non-zero
Ideally, users build and it updates the file automatically and then the tests will discover that it's not updated

The key insight into making this work is that --local will automatically updated the report file while omitting --local will make api-extractor return a non-zero status code if the report file in version control is not equal to what it would generate with the current code.
This prevents anyone from accidentally forgetting to add the file to their version control so it skips review by accident.

Demonstration
853a862 => I attempted to add a new class to the API surface, but forgot to commit the report file to version control. This fails CI because I'd change the API surface without formal approval.
3d6c1cf => I re-run npm run build which regenerates the report file. CI passes because the file will be included in code review.

This was implemented and integrated to the current repo in #1081


[Master] Improve table view animations

Note for myself:
Make sure that c952104c6901fec7ff89a9ab4ab68bd227545fb9 gets picked back into master

done


Android: PlatformClipboard not found in scope.

This is hanging up Bevy_egui(and presumable Egui itself) on Android.
This actually looks like it doesn't line up with the github repo, so this might be fixed already?

Hey there, thanks for asking. Do you mean that there's no clipboard exported by this crate when compiling for an Android OS target? If so, that's intentional for now. None of the backends support it. We'd need some JNI glue code to get that working.

This actually looks like it doesn't line up with the github repo, so this might be fixed already?

Unfortunately, that is not the case. We recently restructured the code but it wouldn't fix your issue.

I do not have any concrete plans or timelines for adding Android support, but I would review and help test a pull request doing so. If nothing comes from an external contribution, I will eventually port our internal Android clipboard code into arboard instead but it is not something thats on my active priority list.


Pull requests

Are you willing to look at pull requests?  If not, no problem, I'll simply start my own project.  Thanks!

I see both this issue and your PR haven't got any response. Have your started your own project?

I applied the getReportEmbedToken commit and its working as expected - wondering if this project has come to an end. Shame

I'm also working on my own fork.
I'll try to contact the company behind this repo (TangentSolutions). Otherwise, we should consider starting a new repo.

Great idea and thank you!  I forked it and made it work for what I needed but haven't touched it beyond that.

Sorry for the inconvenience. We will resolve as a matter of urgency and continue to maintain it. Will get onto it today.

Any update?

PRs have been merged and I will actively be monitoring these again. Thanks for your patience.

Thanks very much
On Sun, Nov 17, 2019 at 6:50 PM Zander Janse van Rensburg <
<EMAIL_ADDRESS>wrote:

PRs have been merged and I will actively be monitoring these again. Thanks
for your patience.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TangentSolutions/PowerBI-SDK-PHP/issues/4?email_source=notifications&email_token=AAOFVXOUQF5V2FLJR7Q74B3QUFY3TA5CNFSM4EKMUIOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIQRHY#issuecomment-554764447,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOFVXM2CLIBUTKUBUNSQQDQUFY3TANCNFSM4EKMUIOA
.

--
JM Designs
https://jmdesigns.co.nz http://www.jmdesigns.co.nz
Skype/Chat<EMAIL_ADDRESS>


feat: add millet lsp

Closes williamboman/mason.nvim#1097.

I think this abbreviation could be expanded to aid discovery, wdyt?

Sure!


Correct documentation problems in view.common

Please check the online version of doc. Those changes should improve problems such as optional values errors and parameter types errors.

Current coverage is 100.00%

Merging #184 into master will not affect coverage as of 9602cbf

@@            master    #184   diff @@
======================================
  Files           33      33
  Stmts         1337    1337
  Branches         0       0
  Methods
======================================
  Hit           1337    1337
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 9602cbf

Powered by Codecov. Updated on successful CI builds.


Pattern matching error when I enter Monday AM value

Hi,
I bought turnips at 90 on Sunday, last week was using the fluctuating pattern.
Thus the app predicts 35% for Small Spike if Monday is between 36 and 82 : https://turnipprophet.io?prices=90&pattern=0
It also predicts 30% for Large Spike if Monday is between 77 and 82.
But when I enter the real Monday AM value : 73, it predicts Large Spike, which seems false as it's not in the valid range https://turnipprophet.io?prices=90.73...........&pattern=0
If I enter a value for Monday PM that is expected to be in the Small Spike range, it shows the right expectations, but still displays the Large Spike graph, but it should not as Large Spike can't happen.
The other turnip app (Turnip Calculator) seems to handle that the right way for this week.
Or maybe Large Spike is possible and the other app is wrong ?

This is because of the FUDGE_FACTOR added in code, trying to make that even there's small error in floating point operations / user input, there would still be some prediction given.

Yup, this is one of the unfortunate side effects of the fudge factor we added... Without it, we were seeing a lot of reports of no pattern matches found; with it there will be cases along the edges of ranges where incorrect pattern matches are made.
Not really sure how to improve this...

Now with the added real value of Monday PM (69) it says 100% for Small Spike. Which seems logical.
https://turnipprophet.io?prices=90.73.69..........&pattern=0
But it now shows very tiny percentages (under 0.01%) for Large Spike and Variable, which are unlikely to happen.
Maybe adding a setting to disable the fudge factor would help if possible?

Adding a toggle could help for people who understand what it means, which I would argue is probably an extremely small percentage of people who use the app daily.
We have to prioritize ease-of-use over complex customization.

Personally I think the fudge factor is too high. 100 on Sunday and 85 on Monday AM should never produce a fluctuating pattern, the closest values in the table for fluctuating on Monday AM are 81 and 90. If the user makes a mistake by more than 1 bell difference they should expect to get an incorrect prediction.

I'm also running into this issue. My buy price was 91, and Monday AM price is an 87 (96% of buy price), which is quite far out of the 85..90% range of 78..82 bells, yet it's still offering up a ~60% probability of a large spike. I haven't looked into the fudge factor code at all, but I would expect it only needs to account for +/- 1 bell in either direction for rounding errors. I entered my value 5 bells completely out of possibility for decreasing / large spike; it should not be presenting me with those as valid predictions anymore.

If the user makes a mistake by more than 1 bell difference they should expect to get an incorrect prediction.

I haven't looked into the fudge factor code at all, but I would expect it only needs to account for +/- 1 bell in either direction for rounding errors.

The fudge factor isn't there to account for user input error - it's there to account for compound floating point rounding differences between JavaScript on x86 and C++ on ARM.
In theory, we should be able to fudge the numbers by +/- 1, however in practice that has proven to be untrue - if you look through the closed issues, you'll see a significant number of reported pattern match failures which resulted in the fudge factor being set to 5.
We tried 1, then 2, then 3, and so on. 5 was what was required to successfully provide a prediction for all the exaamples we were given of failed matches.

The fudge factor isn't there to account for user input error - it's there to account for compound floating point rounding differences between JavaScript on x86 and C++ on ARM.

Damn - it can seriously compound up to 5 bells difference?! Is there any correlation to the compounding over time? eg: could the Mon AM price be +/- 1 bell, but the Sat PM price could be +/- 5 bells?

Damn - it can seriously compound up to 5 bells difference?! Is there any correlation to the compounding over time? eg: could the Mon AM price be +/- 1 bell, but the Sat PM price could be +/- 5 bells?

Well, there's a few things to consider here... even though the game's algorithm has been extracted, it's still not possible to take someone's values and toss them into the game's math to reproduce the exact result that the game would produced. This is because the values are generated by a seed value that is passed into the algorithm, and that seed value is never exposed anywhere. Without that seed, we are left to only being able to estimate the numbers by doing the math backwards based on the values the Player does know.
At the end of the day, the last few words of my previous paragraph are key - "values the Player does know". Because all of the data we have is user provided, it's impossible to guarantee that the data is correct. Any number of human factors could cause the data to be tainted.
What we do know is, the original implementation has no fudge factor, but instead for a given price range it rounded the lower bounds down, and the higher bounds up. We initially thought this would give enough of a buffer, but that proved to be false.
A week ago we were getting multiple reports a day of people unable to find a matching pattern with the numbers they were getting in the game. Initially we assumed most of those were user-error, and fell back on the math to show that their numbers were seemingly impossible.
But, the number of reports grew as the site traffic grew. It became clear that something wasn't quite right. We know that the math we have matches the game's math as best it can for running the algorithm backgrouds from a price back to the rate that was used to calculate it. We account for floating point rounding in the same way that the game does, and we account for the fact that anywhere between N.00001 and N.99999 will produce N.
What we can't do is calculate the exact values as they came out on the Switch - not without having access to a Tegra X1 to run the code on and see how it handles floating point math.
All that is to say, it's a far more complicated problem to solve than I think any of us have the time, equipment or interest to investigate beyond what we already have... especially when a small amount of fudge factor addresses the concern almost completely.

Hmm. That's a much more interesting problem than I was expecting it to be! I can certainly understand some of the decisions that went into adding the fudge factor, but on the flip side, I feel like I can no longer trust this tool to give me accurate predictions or statistics because of it. Like I mentioned in my first comment on this thread:

My buy price was 91, and Monday AM price is an 87 (96% of buy price), which is quite far out of the 85..90% range of 78..82 bells, yet it's still offering up a ~60% probability of a large spike.

(permalink)
When the tooling reports a 60% probability of Large Spike and a 30% probability of Decreasing when there's actually a 0% probability of either of those, it really becomes hard to trust its predictions for anything.
That said, I completely respect the work going into the tool and I've loved following it mature from the first release :smile: I totally understand that this is entirely a free project running on volunteer time and you owe me nothing at all - just want to offer some authentic user feedback. I wish I had some free time to really crack into it and contribute an alternative implementation.

Can we please have a switch to turn off fudge factor?

... I feel like I can no longer trust this tool to give me accurate predictions

That's certainly a troubling thing to hear... after all, why build this if people aren't going to use it? Certainly an area that needs more discussion.

Can we please have a switch to turn off fudge factor?

N.00001 and N.99999 will produce N.

I believe it produces N+1 (roundup)

The fudge factor definitely does not produce N+1 roundup, it intentionally produces N+5. The rounding happens in intceil() which has nothing to do with fudge factor.
That being said, yes we can probably add a toggle for the fudge factor.

I'm doing some prep for this in #206 - I'm thinking to run the predictor without the fudge factor, and if we get no results run it again.
Starting by moving it to a class so I don't need to pass a fudge_factor variable through all the functions

@XcellMiguel This has been fixed by #219
Thanks everyone for your feedback here :)

@mikebryant Nice, it looks way better now with my values (no more 1e-7% prediction values too :D) and the graph shows the expected small spike instead of the large one (which was false).
Thanks !


Crash when no leaf is present

Yuca plant root.

Traceback (most recent call last):
  File "leaf-image-segmentation/segment.py", line 163, in <module>
    segment_leaf(os.path.join(base_folder, file), filling_mode, smooth, args.marker_intensity)
  File "leaf-image-segmentation/segment.py", line 66, in segment_leaf
    select_largest_obj(bin_image, fill_mode=filling_mode,
  File "leaf-image-segmentation/background_marker.py", line 213, in select_largest_obj
    largest_obj_lab = np.argmax(lab_stats[1:, 4]) + 1
  File "<__array_function__ internals>", line 5, in argmax
  File "leaf-image-segmentation/venv/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 1188, in argmax
    return _wrapfunc(a, 'argmax', axis=axis, out=out)
  File "leaf-image-segmentation/venv/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 58, in _wrapfunc
    return bound(*args, **kwds)
ValueError: attempt to get argmax of an empty sequence

Fixed by adding:
    if not lab_stats[1:, 4]:
        return np.ones(img_bin.shape, dtype=np.uint8)

to line 207 of background_marker.py.

Fixed by adding:
    if not lab_stats[1:, 4]:
        return np.ones(img_bin.shape, dtype=np.uint8)

to line 207 of background_marker.py.


Support Range, RangeFrom, RangeTo and RangeFull

This change is

r=me, though CI is red con nightly.

@bors-servo r+

:pushpin: Commit a57bda1 has been approved by emilio

:hourglass: Testing commit a57bda1688235e01013b56fd50c6034e755b2dd8 with merge 442120a050de7ef69faf5f173260b30b7648d4fa...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 442120a050de7ef69faf5f173260b30b7648d4fa to master...


Presets documentation

Issue: #5301
What I did
First draft of presets documentation. I think we either need to release some presets before releasing this documentation, or we need to scale things back until we're ready to start releasing some presets.
How to test
N/A

@shilman What's happening, are we merging this?

Are the packages in https://github.com/storybooks/presets just on the back-burner while more important things are worked on (like storybook-docs?) Are there things that need to occur before those few presets that exist get published to npm? I may be able to spend some time on the presets if that work would be appreciated (and if some guidance could be given for the vision there)

@joeycozza Yeah the presets are gathering dust. However, I just updated the Typescript preset and published it. 🎉
https://www.npmjs.com/package/@storybook/preset-typescript

Will .storybook/presets.js replace .storybook/addons.js in the long run?
If yes, it should be possible to convert
import '@storybook/addon-options/register';
import '@storybook/addon-knobs/register';
import '@storybook/addon-a11y/register';
import '@storybook/addon-storysource/register';

to
module.exports = [
  '@storybook/addon-options/preset',
  '@storybook/addon-knobs/preset',
  '@storybook/addon-a11y/preset,
  '@storybook/addon-storysource/preset',
];

in the future, correct?

@rwieruch In principle you're correct. In actuality, @ndelangen is working on #4169 which will simplify presets, collapse everything into a single file, and have various performance benefits as well.


Label class conflict with Bootstrap

Since some time, the XHGui project uses d3.flameGraph (https://github.com/perftools/xhgui/pull/177) but it seems the styles are clashing with Bootstrap's CSS.
For example, at https://performance.wikimedia.org/xhgui/run/flamegraph?id=59d4a64e3f3dfacf5dccbf27 you'll notice Bootstrap's styles for .label are adding an unwanted text-shadow that makes the text harder to read (https://github.com/perftools/xhgui/issues/211).

There isn't a clean way to overcome this, but I was hoping perhaps you'd be open to changing the label class name to something less generic. E.g. d3-flame-label, or some such.

@spiermar Would you accept a pull request renaming the class name from label to d3-flame-graph-label?

@Krinkle gladly!


Encapsulate the Message to Reader routine in a class

and bypass alignment related copy whenever possible.

LGTM, ready to merge?

Yes. :)


Overflow:hidden breaks find

I have
find('.document', text: text_content).click
where text_content is a string given to the method. This finds and clicks a .document element on the page just fine, that is until I add overflow: hidden on the element the text is in. All of my tests that pass the text_content string have short enough strings to not get hidden by the css.
Using the Selenium driver, the tests pass, the item is clicked. Using Webkit, the element is not found, thus it is not clicked. Any ideas or fixes?

Can you paste the kind of error you get in failing tests?

helper:
def click_on_document(text_content)
  find('.document', text: text_content).click
end

Error:
Failure/Error: click_on_document "Doc Title"
Unable to find css ".document"
I have ensured this document is on the page with save_and_open_page and by running Selenium.

The "Doc Title" is text in a .title div (with overflow: hidden set on it) inside the .document div. The overflow hidden shouldn't (and visually doesn't) cut any text off that is less than approximately 20 words. So, the test string is well within the "visible bounds".

I haven't run into this before, but I'll take a look whenever I can. If you can put together a failing test case for the driver, that would speed things up.

Fixed on master


Add Make_Root for K8_SUPPORTED_BRANCHES

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Allow clients supply a document where to process fragments in

Use-case: processing and extracting text fragments for a document downloaded in the background (and potentially not in the browser in the future).
I'm using this to enable the following extension: https://github.com/transclude-me/extension

thanks for taking a look @tfmar, updated the PR!

@tfmar can I bother you to do an NPM release? 🙂

Done, v5.3.0 just went out.

Thank you!


Add weight units to 4 line haul items: 163331822

Description
Add weight unit (lbs) to line items:
105A - Full Pack
105C - Full Unpack
135A - Origin service Charge
135B - Destination service Charge
Setup
make server_run
make tsp_client_run
look at move: /shipments/67a3cbe7-4ae3-4f6a-9f9a-4f312e7458b9 and validate units in the invoicing panel
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story

Screenshots

Codacy complained about InnaccurateNumericLiteral, but I'm unsure why. The number I used was  as the number I used was less than:<PHONE_NUMBER>99999 which is the limit where numbers can get into problems: https://www.w3schools.com/js/js_numbers.asp
So I used a static number, Number.MAX_SAFE_INTEGER: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER


Update the library to support the OAuth 2.0 authorization

I've added the "Authorization" header in order to support OAuth 2.0 authorization flow.

@Suhoij  - thanks for suggesting this change to support Hubspots OAuth 2 functionality.  Some suggestions on the fix.
Per their docs, you should only send it in the auth header (oauth) or on the string (hapikey): http://developers.hubspot.com/docs/methods/oauth2/using-access-tokens
It seems the old oAuth on the string is deprecated: http://developers.hubspot.com/docs/methods/auth/oauth-overview
Can you adjust to put this into the headers construction that gets passed in as a group?  Moving up the auth params and updating comments?  Plus removing the inclusion on the URL string itself as per the new docs?

@jzabel Sure. I could clean it up to correspond only the latest API.

@jzabel I've removed the authParams and moved the api_key to the finalParams. Also the comment was updated. Please, check.


[Flink AI Flow] Pyflink job should support to upload jar packages

Describe the feature
Pyflink job supports uploading a jar package

AIFlow has been moved to https://github.com/flink-extended/ai-flow.
Please reopen the issue there if necessary.


Android 7.0 CA problem

It seems like from Android 7.0, Google has been limiting usage of User CA usages on android devices.
Work around like this https://blog.jeroenhd.nl/article/android-7-nougat-and-certificate-authorities is required.
Is it possible for you to provide the current Certificate that this app use so I can try apply this workaround? Currently this app does not functional for most SSL/HTTPS network connection.

https://github.com/misakuo/Dream-Catcher/blob/master/app/src/main/resources/sslSupport maybe you want

hahaha I am actually going to HZ next week so I dont need this any more :full_moon_with_face:
But if you make this work for android 7.0 and above I can buy you milk tea in HZ campus :tea:


Handle spaces in directory names

Fixes issue brough up here: https://discuss.circleci.com/t/circleci-cli-doesnt-work-in-folders-names-with-spaces/14803/9
Patch was sent into Zendesk support by @rmccue

To be clear, this currently only affects the Snap and Homebrew installs.


Client sends 0 page size

When attempting to use the client against another GA4GH server it was found that it defaults to send a pageSize of 0. {u'pageToken': u'', u'pageSize': 0} are sent with the first request. This bug caused the client to continually request empty pages.

Surely this is a bug in the other GA4GH server? Sending a page size of 0 allows the server to decide what the size of the returned page is, making process slightly less inefficient.

Yeah, this sounds like a non-bug to me... we have self._defaultPageSize = 100 in backend.py which the page size is set to if the client sends a page size of 0.
Closing...


[9.0.0RC4] with Atomik Theme : Error when I added a transparent logo in top navigation bar block

After I added an image (.png) to transparent brand image to my top_navigation_bar block and I saved, I have this error :
"Object of class Concrete\Core\Entity\File\File could not be converted to string"
`

        <?php if ($includeNavigation) { ?>
            <button class="navbar-toggler collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#top-navigation-bar-<?=$bID?>" aria-controls="#top-navigation-bar-<?=$bID?>" aria-expanded="false" aria-label="<?=t('Toggle Navigation')?>">
                <?php /* Custom animated Toggler */ ?>

                <?php /* End animated toggler */?>

                <?php
                /* Standard bootstrap toggler. Uncomment to use */
                /*
                ?>

                <?php */ ?>
            </button>

Arguments
"Object of class Concrete\Core\Entity\File\File could not be converted to string"`

This is fixed in GitHub and will be in the next release candidate.


remove highlight js

Uses css get almost the same behaviour minus the colors in the request Docs tab.

I agree, it was just a quick and dirty first pass, to show what highlight.js gets us for 500kb extra in the bundle. We still get it imported two more times with swagger-ui-react so thats the bigger rock to move. I'd argue this PR provokes a compromise if we have bundle size concerns, alternatively it would also make a decent lazy loaded component.


configurable parameters for third-party charts - helm

Add configurability for third party subcharts i.e. registry, etc.

duplicate - #1982


File Picker Document in iOS cannot selected

val documentPickerResult = remember { mutableStateListOf<KmpFile>() }
    val pickerLauncherDocument = rememberFilePickerLauncher(
        type = FilePickerFileType.Document,
        selectionMode = FilePickerSelectionMode.Single,
        onResult = { listKmpFile ->
            documentPickerResult.addAll(listKmpFile)
        }
    )

Document cannot be selected.

Hi,
What are you trying to select exactly, what type of documents?
FilePickerFileType.Document is going to filter files with this mime type: "application/*"


Specify version for denoland/setup-deno

denoland/setup-deno@v1 was published recently and is used in the
README.md of the action:
https://github.com/denoland/setup-deno/blob/4a4e59637fa62bd6c086a216c7e4c5b457ea9e79/README.md
We should use it, too.

Note for team: we would have to update Deno versions in Flat Editor and demos if we merge this PR. And documentation.

Thanks for the response! I meant to make just a small improvement but I guess it's not that simple.
Currently the only difference between @main and @v1 seems to be the deno download URL. Do you mean that the team needs to update the setup-deno versions in Flat Editor and demos for consistency?


sweethome3d: 6.5.2 -> 6.6

Motivation for this change
Used this program for the first time today and it gave a notification that a new version is available.
@edwtjo , not sure if there are any subtleties other than the straightforward version updates?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132308 at ff862676 run on x86_64-linux 1

3 packages built successfully:

sweethome3d.application
sweethome3d.furniture-editor
sweethome3d.textures-editor

2 suggestions:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/sweethome3d/editors.nix:77:14:
   |
77 |       inherit license;
   |              ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/misc/sweethome3d/editors.nix:62:5:
   |
62 |     installPhase = ''
   |     ^

Result of nixpkgs-review pr 132308 run on x86_64-linux 1

3 packages built:

sweethome3d.application
sweethome3d.furniture-editor
sweethome3d.textures-editor


feat: Add strict option

This option allows to strictly select icon by filename or by extension, to prevent cases when filename happens to match some extension.
Closes #194

Changed overrides setup schema. I'm not very good at writing docs, will try my best


Move pathogen-embed into its own repository

To simplify development of the software independently from the scientific publication, we should move the embed code into its own repository.

[x] Create pathogen-embed repo in blab organization (John) -> https://github.com/blab/pathogen-embed
[x] Move code from cartography repo into new repo (Sravani)
[x] Setup and test docs, CI, etc. (Sravani)
[x] Update PyPI to use new repo (Sravani)

Finished and uploaded: https://pypi.org/project/pathogen-embed/0.1.1/


add button for uploading colorpalette

Resolves #102
Added the needed button for users to upload a second picture as a colorpalette.
Changed files:

index.html
style.css
script.js

Not quite sure if I understood it correctly, but I think it should now be fixed.


wildcarding clusters/indexes with cross cluster search

Whilst testing alerting against cross cluster search, I need to use something like:
index: *:winlogbeat-*
(i.e. to search all winlogbeat indexes in all clusters)
However,  I get an error when testing the rule:
    raise EAException('Could not parse file %s: %s' % (filename, e))
elastalert.util.EAException: Could not parse file test-alert.yaml: while scanning an alias
  in "test-alert.yaml", line 2, column 3
did not find expected alphabetic or numeric character
  in "test-alert.yaml", line 2, column 4

Note the cross cluster search does work if I define the cluster name in the rule file like:
index: cluster-name:winlogbeat-*
I've tried quoting the index name in the rule file like this:
index: "*:winlogbeat-*"
But this results in another error:
INFO:elastalert:Note: In debug mode, alerts will be logged to console but NOT actually sent.
            To send them but remain verbose, use --verbose instead.
WARNING:elasticsearch:GET https://x.x.x.x:9243/*%3Awinlogbeat-*/_search?ignore_unavailable=true&size=1 [status:403 request:0.037s]
Error running your filter:
AuthorizationException(403, 'security_exception', {'error': {'root_cause': [{'type': 'security_exception', 'reason': 'action [indices:data/read/search] is unauthorized for user [x]'}], 'type': 'security_exception', 'reason': 'action [indices:data/read/search] is unauthorized for user [x]'}, 'status': 403})
INFO:elastalert:Note: In debug mode, alerts will be logged to console but NOT actually sent.
                To send them but remain verbose, use --verbose instead.
1 rules loaded
INFO:apscheduler.scheduler:Adding job tentatively -- it will be properly scheduled when the scheduler starts
WARNING:elasticsearch:GET https://x.x.x.x:9243/*%3Awinlogbeat-*/_search?_source_includes=agent.hostname%2C%40timestamp%2C%2A&ignore_unavailable=true&scroll=30s&size=10000 [status:403 request:0.007s]
ERROR:root:Error running query: AuthorizationException(403, 'security_exception', 'action [indices:admin/shards/search_shards] is unauthorized for user [x]')

This happens even if the user role is granted all privileges.
Is there any way to wildcard the clusters in the rule file?

Found out I'd missed the required role from one of the clusters, after fixing that I was able to use:
index: "*:winlogbeat-*"


Resource tag and Managing Disks Using the Azure CLI

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: MSI
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here: azure-cli (2.0.2)
OS Version: What OS and version are you using?
Answer here: Windows
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: cmd.exe

Description
With the CLI 2.0, I can apply a Resource Tag to a Managed Disk and Managed Snapshot, but not a Managed Image.
C:\Users\riwasa>az resource tag --tags cli20=set -g rgname -n web2vm-image --resource-type "Microsoft.Compute/images"
Changing property 'osDisk.caching' is not allowed.
With PowerShell, I can apply a Resource Tag to Managed Disks, Images, and Snapshots.

+1 on this using two methods for applying the tag.
neillocal@MININT-4A5OFPD:~$ az resource tag --tags created=$date --id /subscriptions/11111111-2222-2222-2222-333333333333/resourceGroups/myResourceGroup/providers/Microsoft.Compute/images/myImage
Changing property 'osDisk.caching' is not allowed.

and then similar to @metazog
neillocal@MININT-4A5OFPD:~$ az resource tag --tags created=test -g myResourceGroup -n myImage --resource-type "Microsoft.Compute/images"
Changing property 'osDisk.caching' is not allowed.

It is confirmed the CRP service has a bug. The fix will roll out sometime in June. This is not a CLI bug

For now, the workaround is to tag using the create command

Verified it has been fixed


Parser: Cannot read property 'isInsertedInRecovery' of undefined

I've copied over the example from here, but when I run parser.selectStatement(), I get:
/srv/http/lang/node_modules/chevrotain/lib/src/scan/tokens.js:213
    if (lazyToken.isInsertedInRecovery) {
                 ^

TypeError: Cannot read property 'isInsertedInRecovery' of undefined
    at Object.getImageFromLazyToken (/srv/http/lang/node_modules/chevrotain/lib/src/scan/tokens.js:213:18)
    at Object.getImage (/srv/http/lang/node_modules/chevrotain/lib/src/scan/tokens_public.js:373:18)
    at ChiParser.Parser.ruleFinallyStateUpdate (/srv/http/lang/node_modules/chevrotain/lib/src/parse/parser_public.js:903:154)
    at ChiParser.invokeRuleWithTry (/srv/http/lang/node_modules/chevrotain/lib/src/parse/parser_public.js:1157:22)
    at ChiParser.wrappedGrammarRule [as selectStatement] (/srv/http/lang/node_modules/chevrotain/lib/src/parse/parser_public.js:1170:42)
    at Object.<anonymous> (/srv/http/lang/src/index.js:14:20)
    at Module._compile (module.js:571:32)
    at loader (/home/kdex/.npm-global/lib/node_modules/babel-cli/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/kdex/.npm-global/lib/node_modules/babel-cli/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:488:32)

Are the tutorials out-of-date? How can I make this work?

Sorry for the noise. Turns out I was reading off the lexer's result instead of result.tokens.
 One example would be:
function parseInput(text) {
   let lexingResult = SelectLexer.tokenize(inputText)
   let parser = new SelectParser(lexingResult.tokens);
   parser.selectStatement()

   if (parser.parseErrors.length > 0) {
      throw new Error("sad sad panda, Parsing errors detected")
   }
}

The formal parameter is never used, and inputText is not defined.
Would be great if the tutorial was in your unit tests. 😄

Thanks for noticing this @kdex.
I fixed this typo in https://github.com/SAP/chevrotain/commit/e8bab3eb318d5857a364fb8960e1fde69a504ae6

Would be great if the tutorial was in your unit tests.
Yes that is true, but I'm not sure how to accomplish this without investing too much time
in creating a system that generates the tutorial from a running example.

Note that all the examples are part of the unit tests.
https://github.com/SAP/chevrotain/tree/master/examples
And that the tutorial has online versions too.
Example: http://sap.github.io/chevrotain/playground/?example=tutorial grammar
I'll be happy to hear about any other typos in the tutorial and even happier to accept pull requests 😄 .

Just a little something about the online versions: I deliberately didn't use them, because:

They use a pretty old language standard. I'm working with babel, so the tutorial was just right for me.
They only show how to define a bunch of stuff, which is great, but not how to actually use it, i.e. how to invoke the parser. The tutorial covered that. 👍

They use a pretty old language standard.
Yeah because they have to run in a browser without per-compilation 😢
Although main browsers should support most ES6 nowadays so I have an open issue to add an ES6 example
in the online version.

They only show how to define a bunch of stuff, which is great, but not how to actually use it, i.e. how to invoke the parser. The tutorial covered that.

I see, You can also find such bootstraping code in the examples directory.
https://github.com/SAP/chevrotain/tree/master/examples


useCallFrame creates an iframe directly inside  ignoring the component structure

Please tell me if I'm doing something wrong. Here's my simplified code:
function Call({ roomUrl, meetingToken }: { roomUrl: string; meetingToken: string | undefined }) {
  const callRef = useRef<HTMLDivElement>(null);
  const callFrame = useCallFrame({
    parentEl: callRef.current,
    options: CALL_OPTIONS,
    shouldCreateInstance: useCallback(() => Boolean(callRef.current), []),
  });

  useEffect(() => {
    if (!callFrame) {
      return;
    }

    void callFrame.join({ url: roomUrl, token: meetingToken });

    callFrame.on("left-meeting", () => {
      void callFrame.destroy();
    });
  }, [callFrame, meetingToken, roomUrl]);

  return (
    <DailyProvider callObject={callFrame}>

    </DailyProvider>
  );
}

Deleting shouldCreateInstance or the
 which callRef is passed into doesn't make a difference; they're basically ignored.
Package versions:
"@daily-co/daily-js": "0.57.4",
"@daily-co/daily-react": "^0.17.1"

Hey @ahkhanjani,
thanks a lot for the report!
I think the issue is that callRef.current and the useCallback passed to shouldCreateInstance don't differ between render cycles from React's "what changed" perspective.
Testing your code I'm noticing that callRef.current initially is null (correct), but as soon as the first batch of side-effects runs (essentially the useEffect() checking for shouldCreateInstance()) the ref is already available, but not added to the DOM, yet (sorry, this is a bit of a hand-wavy explanation).
I can definitely see that you just followed the example from our docs, so those definitely need to be updated.
The iframe is correctly mounted when the code is dependent on a React state, rather than just a ref.
Here's your adjusted code example that at least works for me in React 18:
function Call({ roomUrl, meetingToken }: { roomUrl: string; meetingToken: string | undefined }) {
  const callRef = useRef<HTMLDivElement>(null);
  const [ready, setReady] = useState(false);
  const callFrame = useCallFrame({
    parentEl: callRef.current,
    options: CALL_OPTIONS,
    shouldCreateInstance: useCallback(() => ready, [ready]),
  });

  useEffect(() => {
    setReady(true);
  }, []);

  useEffect(() => {
    if (!callFrame) {
      return;
    }

    void callFrame.join({ url: roomUrl, token: meetingToken });

    callFrame.on("left-meeting", () => {
      void callFrame.destroy();
    });
  }, [callFrame, meetingToken, roomUrl]);

  return (
    <DailyProvider callObject={callFrame}>

    </DailyProvider>
  );
}

I'm pretty sure there's a better alternative to the ready state.

Thank you @Regaddi. This indeed fixed the issue.

I'm pretty sure there's a better alternative to the ready state.

Any chance this can be handled internally?

I have a few ideas that I want to try out! I'll let you know about any progress 👍

@ahkhanjani This should be improved in 0.17.2.


Do not report the "The bot only counts approvals from reviewers and higher roles in list" message

Bug Report

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Related link

Which project: https://github.com/pingcap/docs-cn

PR or Issue Link: https://github.com/pingcap/docs-cn/pull/7142

Steps to reproduce(Optional)
What is expected?
For anyone who has approved a PR,  ti-chi-bot does not report the following message.
"Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments."
What is actually happening?
If a person has approved a PR, as long as his or her role is not a reviewer or higher in list, the following message is prompted, which looks impolite.
"Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments."

/type bug

@Mini256 @qiancai what do you think we just remove the toast as if the approver a reviewer, tichi just add a label.
The bad case may be the an approver asks that why his approval won't work, but we can manually teach them or it will be a rare case. Before and after the change, the rule stands, but reduce the disturbing comment.

@Mini256 Will this issue be resolved in the near future?
It's really rude to tell anyone that your approval does not count. 🤣 See https://github.com/pingcap/docs-cn/pull/7862#issuecomment-990615143

😢 @ran-huang Maybe I can add an option to let the owner of the repository decide whether prompts this message. The premise is our REVIEWER should be clear why the robot does not respond to my approval.

@Mini256 😸 That'll be great! I can't speak for everyone, but our team (docs) could really use this option.

@ran-huang @qiancai, Now you can enable the ignore_invalid_review_prompt option to make @ti-chi-bot  do not prompt this message when the review is not be counted.
ti-community-lgtm:
  - repos:
      - ti-community-infra/test-dev
    pull_owners_endpoint: https://prow.tidb.io/ti-community-owners
    ignore_invalid_review_prompt: true

Refer: https://book.prow.tidb.io/#/plugins/lgtm


Fix typo in "positive" in LFD text

closing this as we don't merge straight into master but noted the error and will fix, many thanks.


refactor: update installation guide

Hello @hngngn,
I have taken the trouble to improve the installation guide by adding at the end an example of how to use the CLI and how to use the generated CLI component.
Thank you for reading.

Thank you for making the changes.  However, I noticed the manual was left untouched.  Was there a specific reason for this?

Oh, I thought it was not necessary to upload it to GitHub. I'm sorry, I will upload it.

There might be a bit of a mix-up! You edited Solid Start and Astro but leave the Manual section untouched.

I ran bun --cwd apps/www build:contents as the guide said after modifying the documentation files and it gave me the above result.

This should only run when new content is added

Sorry, I don't understand. Can you specify where the problem lies?

There might be a bit of a mix-up! You edited Solid Start and Astro but not the Manual section.

There are 3 section in Installation. you only added examples to 2 of theme but what about the 3rd, the Manual one? I hope you will understand now

Thank you for your patience and the user's guide.


Ensure history mode government select options appear in correct order

Because find_each loads results in batches, the governments were not respecting the newest first ordering, so we switch to using a simple each

@ryanb-gds is there a test that confirms this?

@ryanb-gds is there a test that confirms this? or is the batch size so large, it's not worth creating a massive setup for?

There is, batch size is too large though as you suspect


addSelectionToNextFindMatch doesn't work with multiple cursors

VSCode Version: 1.9.0
OS Version: Windows 10

Steps to Reproduce:

Have three rows with a string in them.
hold alt, click before the first character of every word.
activate addSelectionToNextFindMatch, I have sublime-keymap, so that's ctrl+d for me.
only the last word will be selected.

Since a few releases, this works as expected.


base16 with gtk theme

Hi,
I don't know if this has been done yet but I want to connect your base16 with my gtk theme. I see 'tinted-theming/base16-gtk-flatcolor' is a template, and I have tried using that, and either it needs to be done a special way, or it's not possible at this time. Below I will paste my theming.nix for reference. Any help or examples would be greatly appreciated.
Thanks!
theming.nix
{ config, pkgs, inputs, ...}:

{
  home-manager.users.steven = {

    # Theme 'alacritty'
    programs.alacritty.settings.colors =
      with config.scheme.withHashtag; let default = {
        black = base00; white = base05;
        inherit red green yellow blue cyan magenta;
      };
    in {
      primary = { background = base00; foreground = base05; };
      cursor = { text = base02; cursor = base07; };
      normal = default; bright = default; dim = default;
    };

    # Theme 'neovim'
    programs.neovim = {
      plugins = [ (pkgs.vimPlugins.base16-vim.overrideAttrs (old:
        let schemeFile = config.scheme inputs.base16-vim;
        in { patchPhase = "cp ${schemeFile} colors/base16-scheme.vim"; }
      ))];
      extraConfig = "
        set termguicolors background=dark
        let base16colorspace=256
        colorscheme base16-scheme
      ";
    };

    # Theme 'gtk'
    gtk = builtins.readFile (config.scheme {
      templateRepo = inputs.base16-gtk; target = "gtk-3";
    });
  };
}

Hi, sorry for replying late, I'm currently pretty busy. I haven't themed GTK myself. Have you checked out danth/stylix? It uses base16.nix under the hood and you can use your base16.nix scheme to theme GTK through it.

Closed tue to innactivity, please reopen if the issue is still there after upgrade


added test case for JSON Resource Marshalling

Added test cases for JSON Resources :
TrafficPath
Helps: #55

@googlebot I signed it!


403 Un-Authorised Issue while uploading file to Blob using uploadBrowserData Method

-Package Name: azure/storage-blob
Package Version: 1.0.0
Operating system: win32 x64
nodejs
version: v11.15.0
browser
name/version: chrome
typescript
version: 3.2.0
Describe the bug
We are using @azure/storage-blob package to upload file to blob via UI.
we are issuing a sas token with expiry time of 20mins to upload the file.
If we are uploading the large file  greater than 256MB it was taking more than 20 mins.After 20 mins it was throwing an 403 forbidden error. and we are unable to handel that exception. that exception was thrown at Package Level.
Can you please review the code and let me know weather issue is with my implementation or with the package.
snippet:
let BlobConnectionString =
BlobEndpoint=${res.data.storageUri}; + SharedAccessSignature=${res.data.storageAccessToken};
fileControlDetails.blobUrl = ${res.data.storageUri}/${fileControlDetails.fileName};
let blobServiceClient = BlobServiceClient.fromConnectionString(BlobConnectionString);
let containerClient = blobServiceClient.getContainerClient('');
let blockBlobClient = containerClient.getBlockBlobClient(fileControlDetails.fileName);
this.fileUploadCompleted = 0;
blockBlobClient
.uploadBrowserData(file, {
abortSignal: this.abortCtrl.signal,
onProgress: this.onProgress(file.size),
blobHTTPHeaders: {
blobContentType: file.type
}
})
.then(value => {
console.log(value);
      }, this.onUploadError());

when we getting 403 error ideally it shoudl trigger onUploadError();
Expected behavior
it should trigger the upload error method when we get 403 forbidden error.
Screenshots
If applicable, add screenshots to help explain your problem.

Hi, @shanmuksai
Thanks for reaching us!
For the error reporting, what's your definition for method this.onUploadError()?
As Promise.prototype.then()'s definition link:
p.then(onFulfilled[, onRejected]);
p.then(value => {
  // fulfillment
}, reason => {
  // rejection
});

onRejected Optional
A Function called if the Promise is rejected. This function has one argument, the rejection reason. If it is not a function, it is internally replaced with a "Thrower" function (it throws an error it received as argument).

onRejected should be a function with one argument.
For 403 itself, is it possible for you provider a SAS with longer live period? Or is it possible for you to get the size of the file by some approach before providing SAS to user, and sign a SAS to user according to the size of file?
Best Regards,
Jiachen

@jiacfan
We can increase the SAS token time but we can not predict the bandwidth of the user.So, we are trying to implement a retry mechanism to upload the same file by increasing the expiry time of token without user intervention. To achieve that process we need to receive an event when sas token got expired.
// we are expecting to get an event like this for sas token expiration.
Here i am attaching the upload error method :
private onUploadError() {
return (error: any) => {
if (error.name === 'AbortError') {
return;
}
};
}

@jiacfan  any update ?

Hi, @shanmuksai
Thanks for the latest reply, and sorry for the latency. Is the issue still happening in your side? Have you tried to register some testing onRejected functions, e.g:
reason => {
    console.log(reason);
}

And would that work and print error reason properly in your environment? BTW what's the detailed package version you're using?
Best Regards,
Jiachen

@jiacfan
Issue was resolved. Thanks for your support.


Angular export mapping key type

Pull Request
🤨 Rationale
In #2026, the enum-text column was removed from nimble. However, I hadn't realized that in Angular, NimbleTableColumnEnumTextModule was the only module that exported MappingKeyType, which was expected to be used by both the enum-text column and the icon column. Therefore, the icon column is now unusable in Angular because MappingKeyType isn't exported.
Therefore, this PR exports MappingKeyType from NimbleTableColumnIconModule.
👩💻 Implementation
Export MappingKeyType from NimbleTableColumnIconModule
🧪 Testing
N/A
✅ Checklist

[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.

Not sure why the UI status check didn't report from chromatic, overriding and merging


Path

sorry i shouldnt be posting here,but as my VPS is unmanaged,i m unable to access my PATH
i want to delete torrent files
i m trying rm -r -f /rtorrent/torrent/FILENAME
stil file is on sever,i think i m posting wrong PATH,can u help me delting my file,i need correct path :)

If you used my script to install rtorrent, then the torrent files are in:
~/rtorrent/.session
and the data is in:
~/rtorrent/download

thanks a lot for helping me,yes i have installed script and u have to know about it that its excellent :)
just one more thing that it should contain for newbies like me,i cant download files from rtorrent to my computer,how to do that,i find no options,previous versions i used to use it had download category path,which when i display in my browser,i could directly download them to my computer,can u help in this,and thanks for best script

There is info in detailed section, run rtinst again with -d option to
enable downloads directory
On 28 Jul 2017 6:01 am, "Quickboxfan"<EMAIL_ADDRESS>wrote:

thanks a lot for helping me,yes i have installed script and u have to know
about it that its excellent :)
just one more thing that it should contain for newbies like me,i cant
download files from rtorrent to my computer,how to do that,i find no
options,previous versions i used to use it had download category path,which
when i display in my browser,i could directly download them to my
computer,can u help in this,and thanks for best script
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/arakasi72/rtinst/issues/244#issuecomment-318552668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEhGyI2tsC0O-bZ5vKX14qVBxvue-wD4ks5sSV0mgaJpZM4OloUj
.

run the command:
sudo rtdload enable
Then you should be able to access and download from:
https:///download/

thanks and great great help truly appreciated


RFC: pilot: collapse to single inbound passthrough

There is no need for 2 clusters/filter chains now, envoy can handle this
directly
However, this is slgiht breaking change -- the cluster name changes,
which can be used for XDS matching in Envoyfilter and stats. Worse,
istio/proxy itself has hardcoded semantics around the cluster name. I
think we can just fix istio/proxy and release note the rest.
Currently a draft to fix tests and istio/proxy, pending feedback on if ^ is acceptable

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test unit-tests-arm64

unit-tests_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test unit-tests-arm64

unit-tests_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test unit-tests

integ-ds_istio
38fa716dcd1df9ffd72ce7a6be2cdd73a8dfd479
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

What is the config before and after, so we can clearly know what has been changed

afk so cannot give real diff but high level:
before: 10 filter chains (5 variations x 2 IP versions ) and 2 clusters (IP versions)
after: 5 filter chains and 1 cluster. No per-ip-version

My question is if we expect to treat ipv6 differently at some point. But I
guess we can revert this collapsing if needed.
Not against this change, but I'm not sure I fully understand it - would be
better to include some doc explaining the use in the architecture dir,
perhaps others are also not clear on how things work in this area. Some
yaml with comments would work.
On Mon, Jun 10, 2024, 19:25 John Howard @.***> wrote:

afk so cannot give real diff but high level:
before: 10 filter chains (5 variations x 2 IP versions ) and 2 clusters
(IP versions)
after: 5 filter chains and 1 cluster. No per-ip-version
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51503#issuecomment-2159651280, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2UEXJJHY75L4MBZTXTZGZN2HAVCNFSM6AAAAABJDFBNWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGY2TCMRYGA
.
You are receiving this because your review was requested.Message ID:
@.***>

Sure. How it works is we have need to set a local bind address. This needs to be the right IP version of course.
To hack that in the past, we had double filter chains per IP version, and match a dst ip of <IP_ADDRESS>/0 or ::/0, and send to a versioned passthrough cluster with the appropriate version source binding.
Now we just have a single set of filter chains regardless of the IP version. The inbound cluster, however, can dynamically pick the bind IP to use based on the destination IP (it will match the versions).
The benefits here are less duplicated config, simpler to understand, and I am adding more passthrough in https://github.com/istio/istio/issues/51336 -- I do not want to continue old hacks in new code ideally, but also best to keep things consistent so we don't have 3 inbound clusters (ipv4, ipv6, universal)

John - I meant to have this explanation in a doc or at least code comments,
so they are easier for future contributors or people with poor memory like
me :-)
On Tue, Jun 11, 2024, 07:08 John Howard @.***> wrote:

Sure. How it works is we have need to set a local bind address. This needs
to be the right IP version of course.
To hack that in the past, we had double filter chains per IP version, and
match a dst ip of <IP_ADDRESS>/0 or ::/0, and send to a versioned passthrough
cluster with the appropriate version source binding.
Now we just have a single set of filter chains regardless of the IP
version. The inbound cluster, however, can dynamically pick the bind IP to
use based on the destination IP (it will match the versions).
The benefits here are less duplicated config, simpler to understand, and I
am adding more passthrough in #51336
https://github.com/istio/istio/issues/51336 -- I do not want to
continue old hacks in new code ideally, but also best to keep things
consistent so we don't have 3 inbound clusters (ipv4, ipv6, universal)
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51503#issuecomment-2160861818, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2V5NCF4RFBJNW7M2ATZG4AEBAVCNFSM6AAAAABJDFBNWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQHA3DCOBRHA
.
You are receiving this because your review was requested.Message ID:
@.***>

The comment is mostly about the delta from today and this PR, so I wouldn't expect that in code comments or docs. I added a few more comments in the code in the last commit

Fully understand this patch, it does collapse InboundPassthroughClusterIpv4 and InboundPassthroughClusterIpv6 into one InboundPassthroughCluster cluster, with the capability of envoy's BindConfig.ExtraSourceAddresses.


Update Issue - 38927445

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 38.0

Operating System
Windows XP

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


using flaky outside unit tests

I would like to be able to use @flaky outside unittests, on normal Python code in order to implement a simple and clean retry mechanism.
Note: if this is already possible it should be documented.

Hi @ssbarnea ,
Flaky is only intended for use with unit tests, as a large part of its functionality is to interface with unit test systems (hook into unittest or pytest, re-do setup and teardown, report errors to the system, print the flaky report, etc.)


Move PHPStan configuration to its file

With this patch, we can make the usage of PHPStan both locally and in our CI easier. Instead of figure out what paths and level we're using in the project, one can just do the following now:
$ composer require --dev phpstan/phpstan
$ vendor/bin/phpstan analyze

@roblourens To be a benchmark for https://github.com/nikic/PHP-Parser :)


Add FakeElectronService for testing

Wouldn't it be a good thing to add the FakeElectronService, from the gist hinted at in #20, to the module for easier testing?

Hmm, 🤔 providing it in the library may work for that particular scenario buy I think the fake heavily depends on the requirement you've to meet... I see potentially ending up in providing fake impl. for every electron API 😀
Basically, that was exactly the reason why I added the abstract base class.
However, if you come up with something generic in PR, I would be really thankful 👍

Just implementing a small part of this for my own needs I couldn't really figure out something generic. And as you say it would be too much work implementing mock functionality for every Electron feature 🙄


Deep research tool

This is a basic foundation. The AI will recognize it needs to do research and will use the tool. The tool extracts up to 5 topics (so far its always been 5), and then is instructed to go use the Deep Research Summary Tool. The AI agent will use this tool, which returns markdown. If using a goal orientated agent, I noticed it fails to recognize that its done, so I added something about it using the finish tool.

In this most recent commit, a output.md file is written.


0.10.0 trows exception on connect

Version: 1.10.0
Python: 3.8.10
Output broker:
▶ amqtt
[2021-11-26 08:50:05,493] :: INFO - Finished processing state new exit callbacks.
[2021-11-26 08:50:05,493] :: INFO - Finished processing state starting enter callbacks.
[2021-11-26 08:50:05,493] :: INFO - ### 'on_broker_pre_start' EVENT FIRED ###
[2021-11-26 08:50:05,494] :: INFO - Listener 'default' bind to <IP_ADDRESS>:1883 (max_connections=-1)
[2021-11-26 08:50:05,494] :: INFO - Finished processing state starting exit callbacks.
[2021-11-26 08:50:05,494] :: INFO - Finished processing state started enter callbacks.
[2021-11-26 08:50:05,494] :: INFO - ### 'on_broker_post_start' EVENT FIRED ###
[2021-11-26 08:50:09,831] :: INFO - Listener 'default': 1 connections acquired
[2021-11-26 08:50:09,831] :: INFO - Connection from <IP_ADDRESS>:59932 on listener 'default'
[2021-11-26 08:50:09,832] :: INFO - ### 'on_mqtt_packet_received' EVENT FIRED ###
[2021-11-26 08:50:09,832] :: ERROR - Task exception was never retrieved
future: <Task finished name='Task-9' coro=<Broker.stream_connected() done, defined at /src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/broker.py:394> exception=TypeError("'NoneType' object is not callable")>
Traceback (most recent call last):
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/broker.py", line 395, in stream_connected
    await self.client_connected(
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/broker.py", line 461, in client_connected
    authenticated = await self.authenticate(
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/broker.py", line 688, in authenticate
    returns = await self.plugins_manager.map_plugin_coro(
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/plugins/manager.py", line 212, in map_plugin_coro
    return await self.map(self._call_coro, coro_name, *args, **kwargs)
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/plugins/manager.py", line 188, in map
    ret_list = await asyncio.gather(*tasks, loop=self._loop)
  File "/src/HBMQTT_Paho_MySQL_MongoDB/venv/lib/python3.8/site-packages/amqtt/plugins/manager.py", line 201, in _call_coro
    coro = getattr(plugin.object, coro_name)(*args, **kwargs)
TypeError: 'NoneType' object is not callable

Output Client:
▶ amqtt_sub --url mqtt://localhost -t /test/#

Environment:
▶ pip list
Package       Version
------------- -------
amqtt         0.10.0
docopt        0.6.2
paho-mqtt     1.6.1
passlib       1.7.4
pip           20.0.2
pkg-resources 0.0.0
PyYAML        5.4.1
setuptools    44.0.0
six           1.16.0
transitions   0.8.10
websockets    9.1

Thanks for opening the issue. I can reproduce the problem.


fixDependencies gives up on files containing platform() declarations

Build scan link
No build scan unfortunately, based on a private project.
Plugin version
1.17.0
Gradle version
7.5.1
(Optional) Android Gradle Plugin (AGP) version
7.3.1
reason output for bugs relating to incorrect advice

Task :externallibraries:performance:google:fixDependencies
line 14:27 extraneous input '(' expecting {'}', ID}
Can't fix dependencies for ':externallibraries:performance:google': 1: extraneous input '(' expecting {'}', ID}

Describe the bug
Dependencies fixes choke when encountering a platform() dependency declaration. Our build.gradle.kts contains the following line: implementation(platform(libs.firebase.bom)), which clearly isn't liked. It doesn't cause a crash and is a simple warning.
To Reproduce
Use a platform() declaration in your build file.
Expected behavior
Either detect usage of libraries contained within a BOM properly (although it feels weird. A BOM is here because you explicitly want a set of versions that you know works together.), or simply ignoring such lines and continuing on happily with trying to fix the dependencies (which would probably need to detect which libraries are coming from the BOM, not fix them, etc ?)

Thanks for the issue. I think I have a fix for this in another project and need to port it over.

Are there any updates on this issue? I'm having a similar problem too

implementation project(path: ':some_project')
also "path:"

Escape character in gradle files
as example
buildConfigField "String", "someField", ""someValue""


New Tractus-X project contributor Kama Gassner<EMAIL_ADDRESS>

Before requesting the project contributor role, please make sure, that you:

Make yourself familiar with the Eclipse Foundation project roles: https://eclipse-tractusx.github.io/docs/oss/contributor-committer
Make ourselves familiar with prerequisites, like a signed ECA: https://eclipse-tractusx.github.io/docs/oss/getting-started
Check the committer list of our project and highlight at least one of them on this issue, since every committer
can add project contributors: https://projects.eclipse.org/projects/automotive.tractusx/who

Necessary Information
Email address to add: kama.gassneratdoubleslah.de
Committers, that could take over: @ds-kgassner
Please make sure, that you accept the invitation you receive from GitHub, after you have been added as project contributor.

Hi @mkanal you could also add him as committer to the project should do a little session?
How this could me managed by yourself?
Thanks in advance.

FYI : "Contributors: found no valid user with that name."


Adding favicons

The webpages of 1st-4th years dont have favicons.
pls assign this task to me

Go ahead @lord-cyclone100  and add favicons in all pages properly


Update build image in prep of branching

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-notes_istio

release-test_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test release-test_istio

integ-security-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
7007084c12e898ce03916d9daa75b4ceac078493
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest


Not able to export journeys from sub realms for macos binary

Frodo CLI version
Provide output of frodo -v
Describe the issue
Linux binary works fine and the issue is with mac binary. I am using mac M1.
We are trying to export journeys from a sub-realm as below:
./frodo journey export http://am.example.com/openam /realm/subrealm 'amadmin' 'Password123' -m classic -A
and getting an exception as below:
`Connected to ForgeRock Access Management 7.1.2 Build 1b8a956b868a6794e652f23a878e694c07b8ecc9 (2022-March-11 20:06)
Exporting all journeys to separate files...
node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "AxiosError: Request failed with status code 404".] {
code: 'ERR_UNHANDLED_REJECTION'
}
Node.js v18.5.0`
The command works fine for root realms like /realm1 and /realm2 but fails to export trees for its sub-realms.
Amtree tool is able to extract the journeys from sub realms. The command is as below:
./amtree.sh -h http://am.example.com/openam -u amadmin -p Password123 -r /realm/subrealm -S -n -m Classic
For reference i am using frodo macOS binary
v0.10.4 [v18.5.0]
Regards

@debasisdwivedy I believe this to be a duplicate of rockcarver/frodo-lib#100 , which was fixed in 0.13.2. You seem to be running a fairly old version. Would you mind downloading a more recent binary for MacOS and giving it a try?

Thanks @vscheuber . Yes it was an old version


The mandatory parameter "Output Type" is not set.  (GazetteerAnnotator)

I got the following message in missing_configuration.txt
Component name: GazetteerAnnotator, Template Descriptor
The mandatory parameter "Output Type" is not set.

Component name: GazetteerAnnotator, Template Descriptor
The mandatory external resource dependency with key "DictionaryChunkerProvider"
is not bound to a resource.

How can I fix this?
Thank you!

Please see my answer in issue #15.


Subscribe-OTA_MQTT-example with Error

Hai ,I have flashed my ESP32 Wrover withthe example of subscribe_OTA_MQTT.  the consulelog says:
Firwmare Update Subscription...
After i perform Assign new firmware in my Thingsboard Server. The firmware is downloaded and flashed successfully on my ESP32.But the consule logout puts this
0 continouslyandno changes. On my thingsboard the status of the update is stuck on "Downloaded" nothing else. if i assign ne w frimware nothing happens.
This my output:
13:04:19.776 -> [TB] Receive chunk (74), with size (4096) bytes
13:04:19.851 -> Progress 98.68%
13:04:19.927 -> [TB] Callback onMQTTMessage from topic: (v2/fw/response/0/chunk/75)
13:04:19.927 -> [TB] Receive chunk (75), with size (1312) bytes
13:04:19.991 -> [TB] (SHA256) actual checksum: (3664602c97745a88a3da483fc7b0bc8c38ebe4f4d5a030a15ed95a0bdc642073)
13:04:19.991 -> [TB] (SHA256) expected checksum: (3664602c97745a88a3da483fc7b0bc8c38ebe4f4d5a030a15ed95a0bdc642073)
13:04:20.036 -> [TB] Checksum is the same as expected
13:04:20.158 -> [TB] Update success
13:04:20.158 -> Done, Reboot now
13:04:20.411 -> ets Jul 29 2019 12:21:46
13:04:20.411 ->
13:04:20.411 -> rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
13:04:20.411 -> configsip: 0, SPIWP:0xee
13:04:20.411 -> clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
13:04:20.453 -> mode:DIO, clock div:1
13:04:20.453 -> load:0x3fff0030,len:1344
13:04:20.453 -> load:0x40078000,len:13836
13:04:20.453 -> load:0x40080400,len:3608
13:04:20.453 -> entry 0x400805f0
13:04:33.425 -> 0
13:04:34.455 -> 0
13:04:35.467 -> 0
13:04:36.504 -> 0
13:04:37.531 -> 0
13:04:38.539 -> 0
13:04:39.559 -> 0
13:04:40.602 -> 0
13:04:41.602 -> 0
Can anybody help me here. Am i doing the flashing right on the Arduino uno?

Can you include the firmware code you are flashing on the actual device, because the flashing itself is successful, meaning that the ThingsBoard Arduino SDK works like expected.
I am currently assuming that the only thing your new firmware does is print 0 to the console with a slight delay perhaps, but that is hard to diagnose further without the actual code that is flashed onto the device.

@imbeacon I think this issue can be closed, the OTA update worked it seems the flashed firmware binary is invalid.