Proposing to use sacct to get slurm job information

Description
Changes from the slurm squeue command to the sacct command. The sacct command is a bit easier on the Slurm scheduler as it connects to the slurm database instead of the slurm controller. There's a larger discussion I found on it if you're curious. One other part of using sacct is you can get job information for jobs which has finished as well so there may not be a need for the jobs_missing checks that are currently in the code.
Changed Behaviour
Users shouldn't see a difference in running their jobs unless they are scraping the logs for the squeue keyword.
Type of change
Choose which options apply, and delete the ones which do not apply.

New feature

This is a smart idea. I can see many benefits of using sacct over squeue.

ok this looks interesting. give me some time to understand it.

@tylern4 so I think my understanding is that this pushes job status to come from a later, possibly time delayed information source - and I think that means that under not much load, this PR won't change behaviour, but under load, I guess that means that sacct data might be a bit delayed compared to squeue?
If so, then I guess there are two things I would consider:
i) shortly after job submission, does this mean that sacct might report a job does not exist at all, even though it has been submitted? if so, there's a still a "job missing" case but now around the start of a job, rather than around the end of a job. If so, how that might manifest in Parsl without more work is that: launch a job/block, see it is missing, launch another job/block to replace it, see it is missing, launch another job/block to replace it, ... now you have infinity jobs/blocks when you only wanted one.   If this race condition can exist, then I guess this PR should do something with jobs we know were submitted but haven't yet appeared in sacct? (including ... what happens I submit a job and it never appears in sacct, perhaps?)
ii) at the end of a job, when a job is finished, sacct might not report it as finished yet, and so if Parsl should then be starting up a new job to replace it, that won't happen until the info propagates to sacct. In this case, I'm less concerned about changing anything, but more about being aware (or documenting?) this behaviour: if the system is under load so much that we can't see jobs finished, it's probably better behaviour to be slowing down our new job submissions anyway.

There shouldn't be delay between the information since the slurm job id is the index in the database. This should just change "who" is querying the database, either the command asks the manager to query the database or we query the database directly.

Since jobs are submitted with the sbatch command and sbatch blocks until it gets a job id from the database there shouldn't be a time parsl wouldn't be able to query the job id. There may be a time when you could query sacct (without a job id) and not see a job that is currently being sbatched simultaneously in another process, but since parsl blocks on submitting a job and then once it gets a job id puts it in the pending state automatically this shouldn't be a problem.

I encountered a NERSC user using an older version of Parsl, where it looks like they encountered a situation where a job disappeared from squeue, and so then scaling broken, and their workflow didn't finish - I think this PR would have avoided that problem.
This PR is on my list of things to test, but I haven't got round to it yet - we don't have automated tests for most providers so I would like to test this manually.

Glad this might help! I'm staff at NERSC so let me know if there's anything you need for testing on Perlmutter.

@tylern4 sent you a private email on a different but related topic to do with slurm testing


WIP: open up the PR so everyone sees whats happening

is anyone ok with merging this one? It will use the latest Galaxy version, includes a bunch of new tools, including mqc which was contributed from extern.

Fine for me, happy merging


feat: native bridge deposits

this pr continues the work done in #388
all 32 routes have been completed, minus a couple from L1 -> arbitrum
screenshots available here
note - there is still a very strange bug wrt button enabled states. i believe the logic should be separated into more readable conditions

Closing since this is now deprecated.


Make some games!

We need space invaders! Pacman! A 1980s style productivity suite of dubious value...
Depends on #4 and probably #3 unless you want to write it off-target (which, you know, might be considered cheating).

Good old fashioned BASIC "guess the number" works surprisingly well with small children. You could also produce maths teasers, typing tutors, puzzle games, maze games....

Snake has been implemented in https://github.com/thejpster/monotron-apps.


Add Blast Processing [Piano Cover] by Waterflame

Song Name
Blast Processing [Piano Cover]
Artist Name
Waterflame
Source
Youtube
Youtube Link
LQcXnV2C3tQ
Direct File Link
No response
Song ID
16
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 77239595
Downloaded: Yes

This submission is stale because it has been open for 14 days with no activity. If it is still relevant, please leave a comment and we will reopen it.

k

accept


ParameterValidation: "size not a mul of 4" error reported if VK_WHOLE_SIZE is passed to vkCmdFillBuffer()

Current implementation does not recognize the VK_WHOLE_SIZE enum and treats it literally as a number of bytes to be filled with the user-specified int32 value.
It needs to be reworked, so that for cases, where the user passes the VK_WHOLE_SIZE enum, it actually verifies that ((size of the memory attached to the BO - start offset) % sizeof(int32_t) ) == 0.

Fixed in PR #635.


[Docs] Update README

Feature request

What is the expected behavior?
I want to add the dependency for Twitter

What is motivation or use case for adding/changing the behavior?
I think it is important to put forward the community.

Feel free to send a PR

Is this still open? If yes, then can I work on this?

PR welcome

Also the image beside the "downloads" badge is broken. Should I just delete that?

Ideally will be great to repair it

Which link did it reference? Because opening it is saying 404 error

its saying "First-time contributors need a maintainer to approve running workflows". Please approve it!

The pr is #15667


Analyze control flow effects of lambdas passed as arguments

This PR changes control flow analysis to assume that function expressions or arrow functions (in the following called lambda expressions) passed as arguments in a function call may be invoked synchronously during that call. For example:
let x: string | number = "OK";
x;  // string
mystery(() => {
  x = 10;
});
x;  // string | number
if (x === 10) {  // Was error, now is ok
}

Previously, we wouldn't account for the possibility that the lambda expression might have been invoked during the call to mystery and thus we'd assume that the control flow type of x was still string following the call. Effectively, our assumption was that lambda expression arguments are never invoked synchronously, which is less sound than assuming they may have executed.
In some scenarios it is known that a callback parameter is never invoked synchronously (typical of many UI related callbacks), and therefore that possible effects of lambda expression arguments aren't immediate. To support those scenarios, this PR introduces a new deferred modifier that can be used to mark deferred callback parameters:
function setTimeout(deferred callback: (args: void) => void, ms?: number): NodeJS.Timeout;

When a lambda expression is passed as the argument for a deferred parameter, control flow analysis assumes that the lambda isn't called synchronously. (Effectively, deferred reverts control flow analysis to it's previous behavior.)
It an error to apply the deferred modifier to anything but a parameter with a type that permits functions.
Async arrow functions, async function expressions, and generator function expressions are always assumed to be deferred, regardless of whether their corresponding parameter includes a deferred modifier.
Fixes #11498.
Fixes #15380.
Fixes #57880.

@typescript-bot test it

I feel like this is just going to flip the problem on its head in the end - instead of people complaining because their immediately-invoked callbacks didn't affect narrowing, an equal number of people will probably now complain instead that callbacks they know will be called out-of-band do affect narrowing.  The goalposts don't even move really - the other team just gets possession is all 😄

https://github.com/electron-react-boilerplate/electron-react-boilerplate/blob/83b826fa9d810e26da7b5f17b4ed543e5f52bb17/src/main/main.ts#L101 is a good example

I think it's clear that there's no one-size-fits-all answer to whether effects of executing lambda arguments should be reflected in CFA types. Our current assumption is that lambdas are never executed synchronously. This PR experiments with the assumption they're possibly executed, which, given no additional information about the function to which the lambda arguments are passed, is definitely a more sound assumption. Also, the PR validates an implementation strategy and gives us data on the performance cost of analyzing lambda effects.
I would nice to avoid modifiers (like sync, immediate, deferred) on callback parameters, but in the end it may be unavoidable. Modifiers come with the added complication that CFA will need to resolve the function's type, which may in turn lead to circularities.

@typescript-bot test it

@ahejlsberg If I'm understanding correctly, this would apply to arguments that are declared as arrow functions or function expressions, but not function declarations. Is that right? If so, why exclude function declarations?

@ethanresnick It only applies to arrow functions and function expressions passed directly as arguments. It does not apply to functions referenced through identifiers or other indirect expression constructs.

@typescript-bot test it

@typescript-bot test it

@Igorbek For now we're going to focus on:

Switching to a default assumption that lambda arguments may have been invoked synchronously (because that is the soundest and most conservative assumption).
Providing a Default<T> intrinsic type to mark callback parameters that are never invoked synchronously.
Introducing a new --strictCallbackAnalysis flag that enables this behavior (and is part of the --strict family of flags).

I don't think further modifiers are merited at this point. There cases where it is known that a callback is always invoked, but they're rare and more complicated to analyze because ordering now starts to matter when there are multiple callback arguments.

@typescript-bot test it

@typescript-bot test it

في سبت، 8 يونيو، 2024 في 5:51 م، كتب TypeScript Bot <
@.***>:

Starting jobs; this comment will be updated as builds start and complete.
Command Status Results
test top400 ✅ Started
https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162141
user test this ✅ Started
https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162142
run dt ✅ Started
https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162140
perf test this faster ✅ Started
https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162143
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TypeScript/pull/58729#issuecomment-2156044223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A55MQ3TIYJRLAIRVXNZF43TZGMD7FAVCNFSM6AAAAABITRUDD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGA2DIMRSGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@typescript-bot test it

@ethanresnick It only applies to arrow functions and function expressions passed directly as arguments. It does not apply to functions referenced through identifiers or other indirect expression constructs.

Thanks @ahejlsberg. Out of curiosity, what's the reason behind this restriction (i.e., only applying to functions written inline)? Obviously, TS needs the function's source code (not merely a type declaration) to apply this new aproach, but it could still apply to lots of standalone functions that modify some global state, and are passed as callbacks in various places, for which the source is available.
So, is this restriction motivated by performance (i.e., the current approach means there's a lot fewer functions to analyze)? Or, is it based on an observation that applying it to functions referenced by identifier etc. would lead to more false positives? Or, is there some implementation difficulty (e.g., the compiler internals make it inconvenient to know whether the source code is available for a given identifier)? Something else?

@ethanresnick Reasons this only applies to inline lambda arguments and not standalone functions (or, generally, expressions that have a function type):

It is easy to explain and understand: Inline lambdas are analyzed, other ways of referencing functions are not.
With inline lambdas it is 100% decidable where a call to the argument goes. With standalone functions it is really only decidable for function declarations and function expressions or arrow functions assigned to const variables. It isn't decidable for function type variable declared with let or var, method declarations in classes or object literals, or general expressions that have a function type. So functionality could surprisingly disappear because of seemingly unrelated changes to declarations.
The effects we're mostly interested in analyzing are mutations of captured outer local variables in callback functions. The predominant way that is expressed is through lambda arguments. It is less common to use nested declared functions.
Performance considerations. Inline lambdas are generally smaller than full function declarations, and there are fewer of them.

None of this is set in stone, but currently what's in the PR seems like the sweet spot.

It is easy to explain and understand: Inline lambdas are analyzed, other ways of referencing functions are not.

With inline lambdas it is 100% decidable where a call to the argument goes. With standalone functions it is really only decidable for function declarations and function expressions or arrow functions assigned to const variables. It isn't decidable for function type variable declared with let or var, method declarations in classes or object literals, or general expressions that have a function type. So functionality could surprisingly disappear because of seemingly unrelated changes to declarations.

Hmm, ok. Part of the reason I was asking is because I totally share the concerns you're outlining (about wanting the rules to be easy to explain and understand, and not be effected by seemingly arbitrary declaration-style changes). But my initial reaction was that the current rules actually are a little weird along those dimensions.
Specifically, if I author a function inline and then find that I need to use the same function a second time (e.g., to handle another event), so I pull it out into a const above both usage sites, it'd be pretty surprising to have the CFA results suddenly disappear. Similarly, if my codebase happens to use the style of nested function declarations, I would lose this analysis; I agree that that style is less common, but it still feels surprising that it's the sort of thing that would influence CFA.
In terms of explainability, an ideal rule might be something like: "This analysis applies whenever TS can unambiguously find the source code of the function being passed in", but I can see how that's probably impractical to implement. Like, recognizing that this function's source is fixed is probably too much:
const x: { readonly a: () => void } = { a() { y = true; } }
myFunction(x.a)

So, maybe a rule like: "This analysis applies to all standalone functions (i.e., not inside a class/object literal/other container) whose source code is fixed"? That rule would include const x = () => { /* ... */ }, and the other cases you mentioned as decidable. I agree it still has some cliffs that turn off CFA somewhat unexpectedly, like switching from const to let. But there's already plenty of precedent for TS reasoning about mutable and immutable things differently, and I do think it'd be nice (and less surprising) for the analysis not to suddenly turn off when users DRY up a repeated callback.
Whether that change is worth the performance hit though, idk.

@typescript-bot pack this

@typescript-bot perf test faster<EMAIL_ADDRESS>

@typescript-bot perf test faster<EMAIL_ADDRESS>(this time it'll work)

@typescript-bot pack this

Are there any reasons about using deferred keyword instead of Deferred<T>? Also, what about move the deferred before function type but after parameter name like this:
function setTimeout(callback: deferred (args: void) => void, ms?: number): NodeJS.Timeout;

class Foo {
    constructor(deferred public a: () => void) { }
}

class Bar {
    constructor(public deferred a: () => void) { }
}

It seems that both orders are acceptable, is this expected?

Are there any reasons about using deferred keyword instead of Deferred<T>?

One reason is that the "deferred" nature of a parameter is an attribute of the parameter itself, not the parameter's type. Another reason is that a Deferred<T> marker type could appear in a number of situations where it would have no effect (for example as the type of a local variable or property), which would be confusing.

Also, what about move the deferred before function type but after parameter

That would make deferred an attribute of the type, which we want to avoid for the same reasons as Deferred<T> above.

It seems that both orders are acceptable, is this expected?

No, we should verify that deferred appears as the first modifier.

Function parameters can also be declared using tuples, would the deferred modifier be allowed there?
function a(...args: [deferred () => void]): void {} // The tuple element can have no name, so this looks very differently
function b(...args: [deferred callback: () => void]): void {}
function c(...args: Parameters<typeof a>): void {} // Still deferred?

Would TypeScript check the function body to ensure a non-deferred callback parameter is actually (or at least might) synchronously called?
function a(callback: () => void) { } // Error: `callback` is marked as synchronous but not synchronously invoked

function b(callback: () => void) { // Error: `callback` is marked as synchronous but not synchronously invoked
    setTimeout(callback, 1000);
}

function c(callback: () => void) { // OK
    if (Math.random() > 0.5) {
        callback();
    }
}

I think the Deferred<T> approach supports the tuple case with minimal change.
It might also be beneficial to allow the call site to specify whether an argument will be invoked synchronously or not, especially when library authors has not adopted the change into their typings, so there will be many callbacks mistakenly considered synchronous.
// library.d.ts
declare function doThingsAsync(callback: () => void): void; // Not updated

// src/index.ts
let x: string | undefined;
doThingsAsync((() => { x = "foo" }) as Deferred<() => void>);
x; // Still `string | undefined`

Function parameters can also be declared using tuples, would the deferred modifier be allowed there?

No. The deferred modifier can only be applied to parameters (and not tuple elements), which reflects the reality of how control flow analysis analyzes deferred callback parameters: It just looks at the modifiers associated with the particular position of the parameter in the parameter list, avoiding the numerous circularities that full type resolution of the call signature would otherwise cause (another reason Deferred<T> isn't really an option).

Would TypeScript check the function body to ensure a non-deferred callback parameter is actually (or at least might) synchronously called?

We discussed doing this, but it's not clear how useful it would be, and there are several complex issues. We could potentially check that no calls are made directly through the deferred parameter in the body of the function, but that is quickly defeated by us not analyzing aliasing and calls made to other functions. And attempting to track it in types such as Deferred<T> is even more daunting. It's not enough to know that a function reference is deferred, you'd also need to know with respect to what and somehow track that.

It might also be beneficial to allow the call site to specify whether an argument will be invoked synchronously or not

The recommendation here is to use a simple wrapper function that just returns its argument:
function deferred<T extends (...args: any) => any>(deferred cb: T) { return cb }

declare function doThingsAsync(callback: () => void): void; // Not updated

let xx: string | undefined = undefined;
doThingsAsync(deferred(() => { xx = "foo" }));
xx; // Still undefined

@typescript-bot test this
@typescript-bot pack this

@typescript-bot test this

@typescript-bot test it

I'm having a hard time constructing a simple use case for where this might come up, but I have a slight concern around how the deferred modifier doesn't travel along in any sort of higher order - for example, when inferring the parameter list of a signature that uses deferred (playground link).
export declare function doStuff(deferred f: () => void): void;

declare function recreate<Args extends unknown[], Return>(f: (deferred ...args: Args) => Return): (...args: Args) => Return;

declare function recreateDeferred<Args extends unknown[], Return>(f: (deferred ...args: Args) => Return): (...args: Args) => Return;

{
    let x: string | number;
    x = 123;

    doStuff(() => {
        x = "hi";
    });

    x;
//  ^? let x: number
}

{
    let y: string | number;
    y = 123;

    recreate(doStuff)(() => {
        y = "hi";
    });

    y;
//  ^? let y: string | number
}

{
    let z: string | number;
    z = 123;

    recreateDeferred(doStuff)(() => {
        z = "hi";
    });

    z;
//  ^? let z: string | number
}

At the very least, this would be a good test case to add.

Not sure what your intent is, but did you mean to have recreateDeferred reintroduce the deferred modifier?
declare function recreateDeferred<Args extends unknown[], Return>(f: (...args: Args) => Return): (deferred ...args: Args) => Return;

Certainly that works as expected.

Thinking on the "standard library" functions, I can only think of the Promise constructor as the one that executes the callback synchronously exactly once.
Most callbacks execute either asynchronously (callback!) or zero or more times (like in the array methods).
So I think the default should be deferred.
Otherwise, deferred needs to be added everywhere.

@ilogico Note that the OP says "a function call may be invoked synchronously during that call" so this would apply to array methods which will be called zero or more times.

Is being permissive (treating unannotated callbacks as immediate invocations) vs being restrictive (treating unannotated callbacks as deferred invocations, e.g., the current behavior) going to cause us problems down the road?
If we were to choose the restrictive approach and use an immediate modifier for callbacks that are immediately invoked, we could theoretically infer immediate from the body of a function based on usage, e.g., if the parameter is immediately invoked or passed as an argument to an immediate callback parameter before an await or yield, then we could infer immediate for the parameter on behalf of the user.
By choosing the permissive approach, we will assume many callbacks are immediately invoked that may not be and would have a far harder time inferring deferred given the wealth of existing unannotated code, so we may never be able to offer that capability.

Not sure what your intent is, but did you mean to have recreateDeferred reintroduce the deferred modifier?

Probably, yes - but I see that you added test cases for all of them in recreate, recreateDeferred1, and recreateDeferred2. Thanks!

Async arrow functions, async function expressions, and generator function expressions are always assumed to be deferred, regardless of whether their corresponding parameter includes a deferred modifier.

Is that a sound assumption? It's entirely possible to call an async function synchronously right?
console.log('1');

[ 1, 2, 3 ].forEach(async () => {
    console.log('2')
});

console.log('3');

@typescript-bot test it

@typescript-bot perf test this faster

@typescript-bot perf test this faster predictable=true

@jakebailey Asking for predictable seems to have very unpredictable effects. 😮

@jakebailey Also, the issue with switching to actual immediate modifiers in the library files is that it requires a new LKG compiler.

@jakebailey The issue with switching to actual immediate modifiers is that we need an updated ESLint.

Even with the keyword, https://github.com/microsoft/TypeScript/pull/59580#issuecomment-2278672235 shows roughly the same perf regression in bind. Still not sure what it could be reading 5ae48a2 (#58729).

I'm just a passer-by (who writes a lot of TypeScript), who got excited by the prospect of a new keyword that would improve CFA or soundness, but I'm not sure I understand the motivation here, relative to the magnitude of the change (new syntax).
I guess it started as an effort to improve soundness by considering that called functions might have side effects, and now it basically helps correct for overzealous CFA.
Here is another case (not related to this feature) where CFA thinks it knows everything and narrows the type annotation of a local variable:
function foo(a: number[], i: number) {
    // I'm serious, Typescript, I'm saying this could be out-of-bounds!
    const n: number | undefined = a[i];
    const n2 = n; // : number
}

In both cases, you have to occasionally override CFA, e.g. one could write:
declare function mystery(cb: () => void): void;

let x: string | number = "OK" as string | number;
mystery(() => {
    x = 10;
});
if (x === 10) { // works
}

In terms of the larger issue of side effects, I think it should at least be acknowledged that passing any closure to any function could lead to functions having side effects that affect local variables; it doesn't really depend on whether a callback is invoked "immediately" or "deferred."
For example:
const foo = new Foo(() => { /* ... set a local variable */ });
foo.execute();

Here, the callback is not called immediately, but it is called during the course of the function.  The point is, the question of whether a callback might be called immediately or not by a function is only loosely connected to the question of whether a function call has side effects that might affect the analysis of local variables.
I think an annotation that says "this callback is called exactly once, synchronously" or "this callback is called at least once, synchronously" might even be more useful?  It would serve a slightly different purpose.  If this keyword opens the door to other keywords, I'm for it.  There are a lot of keywords I would want.

Is this going to make the 5.7 release? I see it is in the iteration plan and I'm curious what work is remaining here 👀

No, 5.7 is cut, and its release candidate is already out. https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-rc/
Something being in the iteration plan does not guarantee its completion / inclusion in a release.


Codegen 123: add parser-primitive function for emitBoolProp

Summary:
Part of https://github.com/facebook/react-native/issues/34872, Improving Codegen
Reduces code duplication by creating a helper function emitBoolProp(name: string, optional: boolean) in parser-primitives.js. Refactors the code from Flow and TypeScript to utilize the new function.
Changelog:

Test Plan:
Run yarn jest react-native-codegen

Hi @frankcalise, 👋
Congratulations 🎉 on your "First Pull Request" to React Native! 🥳
Thank you, 🙏 for taking the time to contribute to this project and share your ideas.
Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳

P.S.: In the meantime, you should go through below checklist: (click to expand)

Make sure you have signed the CLA 📃🙂,
There are no typos 😄,
All tests 🧪 are passing. i.e. The CI checks should be green 🟢, and
You have added necessary tests for your code, if it's a refactor or a new functionality. 🧪

Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

@Pranav-yadav this officially got assigned by @cipolleschi. Apologies for the pre-emptive PR, will wait for proper assignment next time

/rebase


Fix issue with slight nuance between io packages in PY2 and PY3.

While using AWS Lambda directly the change to BytesIO works fine for python2, but fails in python3. I am currently using this fork for using PY3 with Lambda. In python3 BytesIO is expecting a byte-like type and in python2 it can take a string. This fixes it for my use-case and leaves the current setup unchanged.

@m0ngr31 this is the fix to the issue I e-mailed you about.

:+1:


DevHome should capture logs when users create GitHub issues

Dev Home version
0.1401.501.0
Windows build number
10.0.26217.5000
Other software
OS Build Version: 10.0.26217.5000.amd64fre.ge_current_directadept.240509-1700
.NET Version: .NET 8.0.4
Steps to reproduce the bug
Run the report a bug feature.
Expected result
Expect to get yelled at by dev because I did not have the LOG attached.


Fix a minor bug in skademlia.prefixLen(b []byte)

The bug is only triggered if all the bytes are zero where it'll return wrong result if the bytes are all zero.

Tests appear to be broken - need them adjusted to work with the current prefixLen.


Refactor ddBotImageQueue

This class has been collecting a lot of code over the years and I'm thinking about splitting out some of the functions and cleaning up the design.  Just a heads up to anyone who might have ongoing branches that modify this class or ddPointCloudLCM class. @gtinchev

FYI @wxmerkt


[SPARK-23327] [SQL] Update the description of three external API or functions

What changes were proposed in this pull request?
Update the description of three external API or functions createFunction , length and repartitionByRange
How was this patch tested?
N/A

cc @srinathshankar @rxin @cloud-fan

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/560/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87026 has started for PR 20495 at commit 9ecc809.

Test build #87026 has finished for PR 20495 at commit 9ecc809.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87026/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/561/
Test PASSed.

Test build #87027 has started for PR 20495 at commit c33cc9a.

Test build #87027 has finished for PR 20495 at commit c33cc9a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87027/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/603/
Test PASSed.

Test build #87081 has started for PR 20495 at commit 9e97db9.

Test build #87081 has finished for PR 20495 at commit 9e97db9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87081/
Test FAILed.

retest this please

LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/606/
Test PASSed.

Test build #87085 has started for PR 20495 at commit 9e97db9.

Test build #87085 has finished for PR 20495 at commit 9e97db9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87085/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/612/
Test PASSed.

Test build #87091 has started for PR 20495 at commit 9e97db9.

Test build #87091 has finished for PR 20495 at commit 9e97db9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87091/
Test FAILed.

Test build #87124 has started for PR 20495 at commit b837053.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/638/
Test PASSed.

Test build #87124 has finished for PR 20495 at commit b837053.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87124/
Test PASSed.

Thanks! Merged to master/2.3


Validation error

This issue is intended to address or correct apparent 422 validation errors in the response body of ICEES API requests. For instance, I'm receiving the apparent error below, even when running a successful query. This may be nothing, but I haven't encountered the error previously.

OBE


Cadastre Redesign - Simple Claim View

View For: Any user that starts a claim (single-click on an unpopulated coordinate on the map) after the fair launch period
Current Reference: https://github.com/Geo-Web-Project/cadastre/blob/main/components/cards/ClaimInfo.js & https://github.com/Geo-Web-Project/cadastre/blob/main/components/cards/ClaimAction.js

Display the existing claim instructions, wireframe 1.1 in the left panel upon the first click (mimics existing functionality)
Upon a second click, display the left panel as shown in wireframe 1.2
Move all field labels above the entry box (instead of light text in the field as is the current design)
The left panel should be scrollable independent of the map
Parcel Name and URI should be written to the appropriate Ceramic streams fields (mimic existing functionality)
The For Sale Price is used to calculate the x% Network Fee field based on the current network fee rate pulled form the Geo Web core contracts

For Sale Price is a stored variable for each parcel

The % displayed in the Network Fee label should be a variable pulled from the applicable network fee rate
The Claim Payout field will always = 0.00 (shown for informational reinforcement)
The Stream field is equal to the Network Fee rate divided by 31,536,000 (seconds in a 365 day year). This value is added to the user's new/existing SuperFluid payment stream
The Stream Buffer field is equal to the deposit required to open/update the stream in the SuperFluid protocol
The Wrap to ETHx opens the Wrap ETH modal shown in wireframe 11.1
The Claim button submits the entered data to the appropriate Ceramic stream fields+pinning and smart contract transactions (which require wallet signing)
Display the "Streaming Info Box" defined in https://github.com/Geo-Web-Project/cadastre/issues/94 below the transaction submission buttons.
Conform styling to existing Cadastre styling (wireframes below show functionality and spacing).

Bounty Overview
Size = M
Payment = 500 DAI (for the two issues)
To Be Completed With: https://github.com/Geo-Web-Project/cadastre/issues/101
Assignee =
Bounty Submission
When work is complete, please create PR with your work and request review from both @codynhat & @gravenp. @gravenp will handle logistics of payment with you privately.

Hi @gravenp
How to understand the item 10 above:

the deposit required to open/update the stream in the SuperFluid protocol

is this formula correct?

Security Deposit = 4 * ( Monthly Stream Rate / (30 * 24) )

If so, what's the stream rate in our codebase?

@zhyd1997 our flows are sent to our Super App, so the deposits required are actually x2 the standard deposit. See the table here: https://docs.superfluid.finance/superfluid/protocol-developers/super-apps/super-app#super-app-deposits
On testnets, the required deposit will be two hours (2 * 60 * 60) multiplied by the flowRate (stored as a per-second value rather than monthly).
On this screen, we want to display the change in the required deposit based on the user's entry: (New flowRate - Old `flowRate) * 7200.
@codynhat did I get that all right?

Yes, that sounds right. This is the minimum deposit though, and the user really needs to wrap more ETHx if they do not have any incoming streams already.

the user really needs to wrap more ETHx if they do not have any incoming streams already.

Yes, after this transaction to initiate/update the stream is complete, the wallet should still always maintain a non-zero ETHx balance (which does not include the security deposit) to avoid having the stream closed.

@codynhat @gravenp
So here StreamBuffer = (flowRate - oldFlowRate if no exsiting streams, it should be 0) * 60 * 60 * 2?
flowRate is equal to the Stream field above.

Both the Stream and Stream Buffer fields on this page should display the respective changes in those values as a result of the transaction (we want to show the impact of what they're signing for).
So, you have the correct formula for the value to be displayed for Stream Buffer.
Stream should equal flowRate - oldFlowRate.

@gravenp

Stream should equal flowRate - oldFlowRate.

If so, the Stream value may be different from item 9 above?

The Stream field is equal to the Network Fee rate divided by 31,536,000 (seconds in a 365 day year).

You have this correct in the current PR. networkFeeRatePerSecond is the same as flowRate - oldFlowRate

@gravenp Does this issue include the actual claim functionality or just the view? Same question for the other bounties?

@codynhat Yes, these bounties should include the interaction with the smart contracts (claims in this case). Req number 12 on this ticket represents that interaction.

Closing this ticket. Bounty paid with #101.


Support userpass authorization for Vault

Closes #18

Codecov Report

Merging #41 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   99.47%   99.49%   +0.01%
==========================================
  Files          18       18
  Lines         767      795      +28
  Branches      110      113       +3
==========================================
+ Hits          763      791      +28
  Misses          3        3
  Partials        1        1

Impacted Files
Coverage Δ

src/konfetti/core.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/synchronous.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/core.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/asynchronous.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09bf57...1713eb9. Read the comment docs.

Codecov Report

Merging #41 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   99.47%   99.49%   +0.01%
==========================================
  Files          18       18
  Lines         767      795      +28
  Branches      110      113       +3
==========================================
+ Hits          763      791      +28
  Misses          3        3
  Partials        1        1

Impacted Files
Coverage Δ

src/konfetti/core.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/synchronous.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/core.py
100% <100%> (ø)
:arrow_up:

src/konfetti/vault/asynchronous.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09bf57...1713eb9. Read the comment docs.

Pls, add a changelog entry and some docs


updating readme and index

@gee4vee I did my edits before @mdarden submitted the PR. We were efficient this time!


Include aridity as predictor of change

See https://envirem.github.io/ for data sources

poc-aridity-workflow.R has some work on this.

Closing for now, given current directions.


[DOCS]

Issue Description
I want to update the Contributing.md by adding instructions on how to use Github Desktop and contribute through it. Please assign me this issue under GSSOC'24.
Screenshots or Examples (if applicable)
No response
Proposed Solution (optional)
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Hey @Priyanshu2631  I don't think we need this instruction I will add myself I don' think it is an valid contribution

Hey @Priyanshu2631  I don't think we need this instruction I will add myself i don' think it is an valid contribution


Remove Campaign Goals in Admin - Campaign Details Page

We now have a specific page for managing goals on the campaign details page - e.g. http://allready-d.azurewebsites.net/Admin/Campaign/Details/9
We therefore don't need to re-display these on the campaign edit page. e.g. http://allready-d.azurewebsites.net/Admin/Campaign/Edit/9
We might also be able to remove properties from the view model for the edit page as well.

I can pick up this one


Cannot download audio

First of all, in the last update/pull,  /chat/downloadvideo  is not showing in the API reference page.
Anyway, I tried downloading audio providing:
-Url
-MediaKey
-MimeType: "audio/ogg; codecs=opus"
-FileSHA256 WsyMzCzkID 8wvzRQCE0urXA/6BolFbQS6gM=
-FileEncSHA256 yU 3NZuuKsU0FF6/dtVnBjJETSpoWoZLEyc=
-AudioLength 4139
-DirectPath
in api.md (github) it says that I need to provide everything listed above except FileEndSHA256 and DirectPath, but in the example FileEncSHA256 is provided so I did too.
DirectPath isn't mentioned but I read somewhere in other issue reports that someone mentioned it was required.
Anyway,  Whenever I pull FileSHA256 and FileEncSHA256 from webhook, it has empty spaces in between, and even a forward slash (not sure if unusual)  but I think thats making it fail.
Whats going on? help me :c

I only censored some letters and numbers, just in case, but its clearly showing empty space and forward slash.

I have the same problem, I reported it in the issue https://github.com/asternic/wuzapi/issues/50 so far with no news. I use the file that comes with the http request to solve it but it would be much better to be able to use this feature. Greetings.

Download works if I don't provide FileSHA256, Fileencsha256, mediakey... I mean I only send Url, mimetype, directpath and filelength.
As response, I get a base64 encoded string... Which is audio/ogg codecs=opus type... Which I cannot forward through send audio... It sends as a "empty" audio...  (0 seconds audio which won't play)


forms problems chrome 73

forms don't work in Google Chrome 73.0... materializecss v0.100.2
date picker & tag select
try in http://archives.materializecss.com/0.100.2/forms.html

date picker closing automatically after opening.

This is a regression in Chrome.
See https://bugs.chromium.org/p/chromium/issues/detail?id=941910 and https://github.com/amsul/pickadate.js/issues/1138

Please keep in mind that v0.x is not developed anymore. We are on v1.x now.

Few things which are working in  v0.x is not working in v1.x so please guide me , i have only issue with drop down with v0.x , how i can resolve the issue

it would be really helpful to have some quick fix for materialize 0.100.2, because we can't upgrade to 1.000 immediately.

You can patch this using patch-package.

What is the way out for pickadate in chrome 73?

@crispdata see https://github.com/amsul/pickadate.js/commit/9282a8021c47e39d1aee72d69557d6e4ee68034d
But set the value to 100 or a bit higher.

@DanielRuf
$('.fromdatepicker').pickadate({
format: 'yyyy-mm-dd',
selectMonths: true, // Creates a dropdown to control month
selectYears: 15, // Creates a dropdown of 15 years to control year
onSet: function (ele) {
if (ele.select) {
var chosen_date = $('.fromdatepicker').val();
$('.todatepicker').pickadate('picker').set('min', chosen_date);
$(".todatepicker").removeAttr('disabled');
this.close();
}
},
onClose: function () {
//$('.datepicker').blur();
$(document.activeElement).blur()
}
});
This is the code I am using for pickadate
Can you please tell me what changes I can do in this code to making it works in Chrome 73?

Please see https://github.com/amsul/pickadate.js/pull/1140, you have to change the source of the pickadate component.

@crispdata
The solution is to filter the target with the parent:
if ( target != ELEMENT && target != document && target != P.$root.parent()[0] && event.which != 3 )

@DanielRuf is it being planned to push 1.0.0 of materialize to Atmosphere? the last update to materialize on Atmosphere was on Aug 26, 2017.

@amanagarwal2189 I do not know, I am not a maintainer of this project and was just one of a few longtime contributors.

@DanielRuf ah. Thank you for the response. Any way to communicate this to the Maintainers? I did log an issue. But I don't know the turnaround time for it.

One solution for select is delete this code in materialize.js:
$(this).trigger('open', ['focus']);

Not really a solution for a regression caused by Chrome tbh.

Not really a solution, but is an alternative while the solution is not available

No need to change any file just use below code after initialization.
$('.datepicker').on('mousedown',function(event){
event.preventDefault();
});


Fix example in CustomShaderGuide

Fixes the problems in the CustomShaderGuide, as reported on the forum.

Coincidentally, I had some TODO on my list for a few months now, and just wanted to do this, but ... noticed that custom-shader-docs branch: This might be a good place to sneak in an update for the links that say "documentation comment" at https://github.com/CesiumGS/cesium/blob/4a74622a0972f2694e3134715473e88d7b7a4cb9/Documentation/CustomShaderGuide/README.md#czm_modelvertexoutput-struct and the next section, which lead to a 404 right now due to the engines/widgets directory structure.
The first link should point to https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Shaders/Builtin/Structs/modelVertexOutput.glsl
The second link should point to https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Shaders/Builtin/Structs/modelMaterial.glsl
(And it would be nice if they could be a permalinks, but .... hmmm)
If this is merged before this change, I'll create a new PR a bit later.

This might be a good place to sneak in an update for the links

Thanks for catching that @javagl! I just pushed a fix for those 2 links

Thanks @jjhembd and @javagl!


When model.id is set in model.initialize, Collection.get('mymodelid') will return undefined

I have a model for a day that calculates its id like this:
    var Day = Backbone.Model.extend({
      initialize: function() {
        // set id to something like '20160402'
        var date = this.get('date');
        this.id = '' + (date.getFullYear() * 10000 +
                        (date.getMonth()+1) * 100 +
                        date.getDate());
      },
    });

When I add this to a Collection I cannot retrieve it via Collection.get:
    var day = new Day({'date': new Date(2016, 3, 2)});
    var days = new Backbone.Collection([day]);
    assert.equal(days.at(0).id, '20160402');  // this succeeds
    assert.notEqual(days.get('20160402'), void 0);  // this fails

This is somewhat unexpected. I can change that behaviour by changing Collection._addReference:
    // Internal method to create a model's ties to a collection.
    _addReference: function(model, options) {
      this._byId[model.cid] = model;
      // var id = this.modelId(model.attributes); // changed to:
      var id = model.id || this.modelId(model.attributes);
      if (id != null) this._byId[id] = model;
      model.on('all', this._onModelEvent, this);
    },

But this breaks a different test ('Collection with polymorphic models receives default id from modelId').
I'm not sure, what the intended behaviour is. If the behaviour is meant like it is, it should be stated in the docs.

You're issue is using model.id = value, instead of #set: model.set('id', value). model.id is a convenience to grab the id, but does not keep the model's attributes synced correctly.

Thank you for the explanation!


Error while running node

Getting the error below while running node app.js demo ....didn't do any changes in the code but still getting this error.
how to fix this?
D:\NodeJs\pass-converter-main\pass\index.js:208
_strings.translatedValues ||= [];
^^^
SyntaxError: Unexpected token '||='
at wrapSafe (internal/modules/cjs/loader.js:1001:16)
at Module._compile (internal/modules/cjs/loader.js:1049:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Module.require (internal/modules/cjs/loader.js:974:19)
at require (internal/modules/cjs/helpers.js:101:18)
at Object. (D:\NodeJs\pass-converter-main\app.js:20:14)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)

Which version of Node are you running? I believe at least version 15 is required, and earlier than that would cause the error you're seeing. If that's not the cause of the problem, please re-open the issue.


Analysis Share Dialog: Modify share modal for user study analyses

[ ] If analysis is based on user study you own, then include verbiage indicating that the user study must be shared, in addition to the analysis import link.
[x] If analysis is based on a user study you don't own, then disable the share button.

discussed in 4/10 EDA UX
In the current and planned (VDI) user dataset system, the share model is:

Only the owner (ie, Person A) can share study data. The owner can also revoke the share (ie, the owner retains control)

Recipients (ie, Person B) of the share cannot in turn share the study, BUT the share analysis button will be active for all users (ie, owners and all downstream recipients). Important use case: owner and recipient are collaborating on a study. Person B and Person A are collaborating on an analysis of Person A’s data. Person B needs to be able to share an analysis with Person A

If Person B shares an analysis with Person C (who has not directly received access to the study from Person A), they will see an error message. Person C may not know Person A and will need to ask Person B to ask Person A to share the data with Person C (ie, the site won’t show contact information or even user names). Person A and Person B are already in communication, so Person B can easily ask person A to also share the study

Share analysis modal for curated studies:

Share analysis model for OWNED user datasets:

Share analysis modal for NON-OWNED user datasets:

See slack conversation: https://epvb.slack.com/archives/C0132PM1MT5/p1681856819704849

Looks good!


Returning a multi-value from a wrapped function

Is there any way to return a multi-value from a wrapped function?

No. The purpose of wrapper interfaces defined in WasmFunctions is to provide a Java-native APIs to interact with wasm functions. Java has no support for multi return value, there's no straight mapping possible.
You can just use Func class directly to obtain array of results, and/or give it handler that stores multiple result values.
              Func func = new Func(store, fnType,
                     (caller, params, results) -> {
                         results[0] = ...;
                         results[1] = ...;
                         return Optional.empty();
                     });


[WIP] Improve 18.01 example to allow tools installation

With this changes the flavour less image should resolve conda packages for tools installed from the toolshed, making the flavour-less setup more interesting for people trying it.

Thanks for reviewing. Unfortunately this had an issue, but since I had it on WIP, I didn't rush to fix it, sorry!... I will revert the merge, fix and merge.


Update README.md

@all-contributors please add @m14r41 README.

https://github.com/all-contributors please add @m14r41 README.

@all-contributors please add @m14r41 README.

@all-contributors please add @m14r41 for code


[Fix #12649] Fix false positives for Style/InverseMethods

Fixes #12649.
This PR fixes false positives for Style/InverseMethods when using relational comparison operator with safe navigation.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Are comparisons the only methods that are affected negatively by safe navigation? (I'm wondering if something else won't misbehave on a nil receiver) I think it might be a good idea to list some examples with safe navigation explicitly and expand the tests to cover test navigation.

@koic ping :-)

Oops, I pressed the "Merge" button, instead of the "Comment" button. 🤦

Apologies for my delayed response 🙇 I think there are no major issues, but I'll look into whether it can be improved later.


operator: add osd scrubbing schedule options

Description of your changes:
This implements the OSD Scrubbing schedule design document from #97.
This adds OSD scrubbing schedule config options to the CephCluster CRD for easy configuration instead of having to go through the rook-config-override ConfigMap.
Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[x] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[x] Reviewed the developer guide on Submitting a Pull Request
[x] Pending release notes updated with breaking and/or notable changes for the next minor release.
[x] Documentation has been updated, if necessary.
[x] Unit tests have been added, if necessary.
[x] Integration tests have been added, if necessary.

CI failures don't seem related to the changes in this PR, and will probably be fixed by backporting the latest upstream changes.


Remove proto directory.

Related issue: https://github.com/google/instrumentation-java/issues/214

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #216   +/-   ##
=========================================
  Coverage     94.89%   94.89%
  Complexity      421      421
=========================================
  Files            57       57
  Lines          1294     1294
  Branches         91       91
=========================================
  Hits           1228     1228
  Misses           41       41
  Partials         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba004c...bff6a7e. Read the comment docs.


add s/y dim to dm

Can you make these properties that yield an error in the same way input_size does when accessed before the DM has been set up?


Why do you need to start a Run loop within makeSuccess/makeError?

Hello,
function makeSuccess(resolve) {
  return function(response, textStatus, jqXHR) {
    Ember.run(null, resolve, {
      response: response,
      textStatus: textStatus,
      jqXHR: jqXHR
    });
  }
}

Why is Ember.run needed?

it is best practice to wrap the roots of callstacks in Ember.run this allows us to fill in missing functionality from the native runtime.

Thanks @stefanpenner


Chop empty lines at the beginning and end of the quote?

Quote #8093 has an empty line at the end. This could be fixed manually if we implement #68, or even via simple SQL query, but wouldn't it be better if such trivial edits were automated?

I vote for:

trim the white space automatically at the end of every incoming quote
fix the existing quotes with an evolution

What about empty lines at the beginning and/or end of the quote? I think those should be removed automatically, too.

Empty lines at the beginning – yes. Empty lines at the end are already covered by my specification "trim the white space automatically from the end". \n is a whitespace characted, too.

I vote for Trump

I agree with @ForNeVeR


chore(travis): fix node version in the build using nvmrc

build was using node version 4 instead of 6, using nvmrc we don't need to specify node version and because node 6 comes with npm 3 by default remove it from before install in the build.
see:
https://github.com/travis-ci/travis-ci/issues/3644
https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Using-.nvmrc

Current coverage is 100% (diff: 100%)

Merging #28 into master will not change coverage

@@           master   #28   diff @@
===================================
  Files           1     1
  Lines          10    10
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           10    10
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 2e6bb71...ac1bc7c

Thanks!


Please Update API...

Please can you update you stance alone app to work with the new API.

Closing in favor of #87


Update caprine setup name to new naming scheme

Fixes a 404 download error.

Again? They change it from release to release...

2.35 - dots
2.36 - dashes with lower case name
2.37 - dots
2.38 - dashes with upper case

Maybe it would be easier just to grab the first .exe on the releases page.

New changes to this file was merged on the master branch, but it is still broken.


feat: user info upgrade

:tada: This PR is included in version 0.80.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update fr.yaml

fixed the functions that were translated by mistake. Hopefully all of them

Seems all good now


Updated: webcatalog <IP_ADDRESS>

Newer version of webcatalog (<IP_ADDRESS>) is now available in master.


Helps about how to boostrap build of justbuild

I used the following command to try to build it.
env PACKAGE=YES LOCALBASE=/usr \
    NON_LOCAL_DEPS='["google_apis","bazel_remote_apis"]' \
    python3 ./bin/bootstrap.py . build

see the error in build log: https://github.com/topazus/justbuild/actions/runs/7335489509/job/19973471274

The justbuild bootstrap and package building process is designed for read-only source directories. Based on this assumption, the initial copying of the source tree to the build directory simply uses a recursive tree copy; this, however, fails if the destination, i.e., the work directory (or "build directory" in other terminology) is in the source tree. Using an out-of-source build directory (e.g., ../build instead of build in the quoted command line) should fix it.
Do you have a use case where building in source is a strict requirement, or can we close this issue?

BTW, an example of a working github workflow building just was written by @oreiche in his fork.

Closing as resolved by 264ba60e221231109201da1c6d336c642959a0c2


AWS CodeBuild fails - need node installed

Describe the Problem
The github action for AWS CodeBuild failed for PR #92 which updates documentation from fossell fork. Build phase with error:
COMMAND_EXECUTION_ERROR: Error while executing command: npm install. Reason: exit status 254
Suggests the need to install node in the AMI.  Should also note this error when pushing the ug_update branch to fossell fork after merging develop branch: ! [remote rejected] update_ug -> update_ug (refusing to allow a Personal Access Token to create or update workflow .github/workflows/documentation.ymlwithoutworkflow scope) error: failed to push some refs to 'https://github.com/fossell/wrfcloud'
Recent PR #93 was successful in the CodeBuild tests, so might be issue related to PAT?
Expected Behavior
AWS CodeBuild github action should pass when activated for PR. It does for #93, but not for #92.
Environment
Describe your runtime environment:
1. Machine: AWS wrfcloud AMI
2. OS: wrfcloud AMI
3. Branch: from fossell fork, branch ug_update
To Reproduce
Describe the steps to reproduce the behavior:
Unsure how to reproduce.
Relevant Deadlines
December 5, 2022
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority

Projects and Milestone

[ ] Select first Project for support of the current release
[ ] Select second Project for development toward the next official release
[ ] Select Milestone as the next bugfix version

Bugfix Checklist

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of main_<Version>.
Branch name: bugfix_<Issue Number>/main_<Version>_<Description>
[ ] Fix the bug and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into main_<Version>.
Pull request: bugfix <Issue Number> main_<Version> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Project for support of the current release
Select: Milestone as the next bugfix version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Complete the steps above to fix the bug on the develop branch.
Branch name:  bugfix_<Issue Number>/develop_<Description>
Pull request: bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Project for the next official release
Select: Milestone as the next official version
[ ] Close this issue.

@JohnHalleyGotway - See the text of this issue. When I merged the develop branch into my local branch of my fork, and then pushed my local branch to my forked repo, there was a warning about access tokens. Maybe that's the issue?


Instructions outdated for App Service deployment credential configuration

Specifically the screenshots do not represent what I am seeing in the Azure portal, e.g. I don't have "Deployment credentials" but "FTP/Credentials".

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 754dcf9b-e64a-922b-6108-bd1152a758f0
Version Independent ID: 58247335-c4e9-705b-297d-97637b872c02
Content: Configure deployment credentials - Azure App Service
Content Source: articles/app-service/deploy-configure-credentials.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin;byvinyal

Hi @brettcannon Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.

@brettcannon Sorry for the delay. I've updated the doc to reflect the new UI and it should be published sometime today. Thank you.
#please-close


Fix uninitialized constant YAML when running ./bin/console

I'm getting this error when running ./bin/console on a generated extension:
Traceback (most recent call last):
        4: from ./bin/console:5:in `<main>'
        3: from ./bin/console:5:in `require'
        2: from /home/gustavoribeiro/Development/personal/rubocop-coupling/lib/rubocop/coupling.rb:7:in `<top (required)>'
        1: from /home/gustavoribeiro/Development/personal/rubocop-coupling/lib/rubocop/coupling.rb:8:in `<module:RuboCop>'
/home/gustavoribeiro/Development/personal/rubocop-coupling/lib/rubocop/coupling.rb:13:in `<module:Coupling>': uninitialized constant RuboCop::Coupling::YAML (NameError)

Looks like we need to require the YAML library:
https://github.com/rubocop/rubocop-extension-generator/assets/57065994/390cf43f-bf60-4c00-a2f2-37c1254ae4f4
To fix the error, I added a patch in lib/rubocop/extension/generator/generator.rb to import the YAML .

I just noticed that #22 already fixes this problem.


HealthCheck added + improve cni test

Coverage increased (+1.6%) to 51.098% when pulling 98b3ff957545e72df27976e07946846ccf5602d4 on lukasmacko:master into c7dcdb45c34c14af61d3ea19098de6da2cda540a on contiv:master.


fix: add special case for<EMAIL_ADDRESS>optional dependencies

Fixes https://github.com/vercel/nft/issues/371

Looks like sharp doesn't support yarn@1 anymore since it didn't install optionalDependencies 🤔
https://github.com/vercel/nft/actions/runs/7054667887/job/19203908329?pr=372#step:8:7545
So we might need to change the repo to use npm or at least this specific test needs npm.

Adding --ignore-engines on yarn install per https://github.com/lovell/sharp/issues/3871 might solve the installation issue.

yarn v1 has been in maintenance mode for almost 4 years and does not properly support optionalDependencies. I highly recommend people upgrade, but please avoid the plug'n'play feature.

@styfle Whatcha think about this PR? Merge it?

Great to see some progress on this, thank you.
The sharp-related change adds 10 lines whereas the majority of this PR appears to relate to replacing yarn v1 with the latest npm. If clean version control history is of interest then may I suggest a split into a PR for the package manager upgrade and a PR to support optionalDependencies.

Even if we split it into 2 PRs, it will still have the same problem because we can't run tests without installing sharp.
This should be wrapping up soon though, there was a bug in jest causing some confusion and I think we have it resolved.

Looks like we're running into this npm bug now 🤦

https://github.com/npm/cli/issues/4828


Update node-sass dependency

Keep getting the lib bindings error using gulp-sass. If i update gulp-sass's bower.json to use node-sass 3.3.3 everything works properly.

Try to clear the npm cache or install the 2.1.0-beta for node-sass 3.4

yeah i cleared cache, tried a rebase, etc. nothing worked. several team members were getting the error without an update to node or npm so not sure what happened. only thing that fixed was updating the node-sass dependency. will try 2.1.


Add error molecule pattern

I have left out the mixins that need the logical properties mixin but have put in a TODO for each one.


MATE updates 2023-12-26

https://github.com/mate-desktop/libmateweather/compare/v1.26.2...v1.26.3
https://github.com/mate-desktop/mate-media/compare/v1.26.1...v1.26.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg test mate


Added the "Write a function.py" file

Added the "Write a function" challenge from HackerRank.

I see you folk this repo, great !!! You can work on it, but 'cause is personal and created for auto-educational propose I can't accept ur pull request. Thanks for working on it anyway !!!

Hey there! My objective is to also work on improving my code and skills. Can I add alt solutions for the challenges you already solved, as some sort of personal project too? I'm getting used to the platform and I need someone to work with so I can gain experience. Thanks!

Sure, if that is ur objective, no problem !!! If you have a different solution to the existing one add a comment and I will accept the pull request, something like:
...
... (Existing code)
...
Alternative solution (by mpiele)
...
...
...
Not all the problems are trivial so can be a good way to learn and collaborate at the same time...


fix: Load complete event on detail view load

Filter incomplete events in detail view
Load from network if incomplete event found
Batch insert mode through transaction

@arp95 @mejariamol @Shailesh351 @rohanagarwal94 Please review

@niranjan94 Please merge


Support Intent.ACTION_MEDIA_BUTTON broadcasts.

Hello! Some apps use this approach to control play\pause of media players.
for example:
val downIntent = Intent(Intent.ACTION_MEDIA_BUTTON)
val downEvent = KeyEvent(eventTime, eventTime, KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_MEDIA_PLAY_PAUSE, 0)
downIntent.putExtra(Intent.EXTRA_KEY_EVENT, downEvent)
packageName?.let {
downIntent.setPackage(packageName)
}
context.sendBroadcast(downIntent)
    val upIntent = Intent(Intent.ACTION_MEDIA_BUTTON)
    val upEvent = KeyEvent(eventTime+50, eventTime+50, KeyEvent.ACTION_UP, KeyEvent.KEYCODE_MEDIA_PLAY_PAUSE, 0)
    upIntent.putExtra(Intent.EXTRA_KEY_EVENT, upEvent)
    packageName?.let {
        upIntent.setPackage(packageName)
    }
    context.sendBroadcast(upIntent)

or this question
https://stackoverflow.com/questions/40520094/android-unable-to-control-the-media-player-by-sending-the-broadcast-of-key-code
Can you please add support for this in your lib?

This is already handled in the DefaultMediaSessionControlsReceiver (see onReceive and handleKeyEvent)


Clarification on using snippets example code

I am going to use pahomqtt library but cannot figure out how to add it into the esp dev environment - I am using Eclipse c++ with ESPIDF and windows 10.
Thought it would be fairly straightforward, especially since examples exist in snippets but after hours of trying to figure it out I thought I'd finally ask for some help

Apparently it was January when I last looked at this code ... sorry ... I'm going to be sluggish.  It looks like one takes the directory from this repository called
networking/mqtt/paho_mqtt_embedded_c/
and places that in your ESP32 project components folder.
/components/paho_mqtt_embedded_c
By doing that, it will cause the code to be compiled and linked.
There appears to be a sample here.
https://github.com/nkolban/esp32-snippets/tree/master/networking/mqtt/paho_mqtt_embedded_c/ESP32_Sample
of a client caller.

thanks, that was certainly easy. I had tried something similar but copied the 'MQTTClient-C' folder instead.

No problems.  Feel free to join in any time as a collaborator on these projects.  If you think the README or other documentation could be improved ... have a bash.  And of course, if you choose not to, that's also not a problem.  I just want to make sure you feel welcome to come join the fun and games of being a repository contributor :-)

I'll be happy to join the fun. I realize that I asked this before but, what is the best method for adding to the code and/or documentation. I'm not always fully confident in my code so not sure you want me to add that directly.

I'll be happy to assist in any way I can.  Read about Git and Git Hub.  At a high level, you will create a git hub account, clone the esp32-snippets project into your own github account.  Clone/pull YOUR copy onto your PC ... make changes, commit the changes back to your Github clone and then issue a pull request.
Alternatively, if all of that is too much ... feel free to just write the changes you want made as text posts in an issue and I'll transcribe.

Had some trouble getting paho mqtt compiled so thought I'd start out with something I hoped was a bit more straightforward and imported this library instead (https://github.com/tuanpmt/esp32-mqtt). I've got most of it ready to use with c++ but ran into something I wasn't expecting... When I try to call the library functions (from c++) defined in the header and c files, I get undefined reference errors.
Is there a simple step I am missing to call c functions from a component library? The library is loaded under the components directory. I have access to the structure and variable definitions. I looked through your cpp_utils cpp code but didn't see that you were doing anything other than calling a function.

@rweller59 If i understand, you are trying to use this library https://github.com/tuanpmt/espmqtt/tree/2967332b95454d4b53068a0d5484ae60e312eb12
This is plain C library, so need to include header files inside extern guard:
extern "C" {
#include some_header.h
}

I could swear that I had tried that but what I had done instead was put the functions in the declaration
extern "c" {
c_func a();
c_func b();
}
Everything now compiles - thanks once again

went back to paho_mqtt library. copied library from snippets into project components directory. Tried to compile, got error (undefined reference to `mbedtls_debug_set_threshold'). Turned mbedTLS debug ON in menuconfig. Compiled, ran and works.
Looks like there are quite a few changes in embedded library since you pulled it so thought I'd update. Downloaded latest version and replaced previous version in components directory with this latest version. I am now getting a bunch of unknown type name errors like this:
components/paho.mqtt.embedded-c/MQTTClient-C/src/MQTTClient.h:127:5: error: unknown type name 'Network' Network* ipstack;
Are there steps that I did not take for configuring a components library. I made sure that component.mk exists but haven't done anything else

figured it out. most of configuration was inside MQTTLinux.h. Still having some other issues with the library but not related to this


tour: error when running /basics/3

Context: https://tour.golang.org/basics/3
prog.go:9:14: cannot refer to unexported name math.pi
prog.go:9:14: undefined: math.pi
Program exited.

This is expected, it's in the accompanying text:

Run the code. Notice the error message.
To fix the error, rename math.pi to math.Pi and try it again.

it's to show that lower-case idents are not exported.


Document Devnet support in Platform

https://docs.hiro.so/platform/guides/devnet
@sabbyanandan can we close this ticket? looks like devnet is documented

@sabbyanandan is this done? reference: https://docs.hiro.so/platform/guides/devnet

For sure!


Adding testing folder with Cypress for e2e testing.

@weskubo-cgi - added README.md to testing folder with instructions for install and run (GUI/headless).


WIP: Added support for Canary Flex

Description:
If device type is Canary Flex, we'll add wifi and battery sensors. If device type is Canary, we'll add temperature, humidity and air quality sensor
Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

@elbogi can you please help testing this for me as I don't have Canary Flex

The sensor types are now controlled by device type:
Canary => Temperature, Humidity and Air Quality
Flex => Wifi and Battery
I made the assumpation that Flex only has Wifi and Battery sensor. Please let me know if this is incorrect.
Also one thing I'm not sure is if device.device_type.name is "Canary Flex". Can you please confirm?

Name is correct, from log: device_type": {"id": 3, "name": "Canary Flex"},
You're also correct regarding sensor names.

Sensor types as correct and device name is also correct.

Made the change as per @elbogi (https://community.home-assistant.io/t/canary-flex-integration/45953/9):

I figured out how to test the PR and found only a small mistake. I not very familiar with git so I just post the change here. In homeassistant/components/sensor/canary.py, change line 23 to:
["wifi", "dBm", "mdi:wifi", ["Canary Flex"]],

Thanks @elbogi for testing this. This is now ready for review


Not getting a good acc

Hi @shicai ,
I tried your depoly prototxt, yet didn't get a good acc result.
I'd be appreciated if you could share your solver prototxt for me to check.
thanks!

what is your result?
solver prototxt file has no effect on the val accuracy of the pretrained model.

Hi @shicai
I only got 54 as top 1 acc and 79 as top 5 acc. Btw I didn't use the pretrained model, I'm trying to train the net from the imagenet dataset.
thanks!

training models on ImageNet is somehow very tricky.
you'd better train some simple models first.

@Shicai
First of all Thanks alot.
It would be very helpful if you could share the training/testing script as well for replicating the exact results.

@shicai
Hi shicai,
I've tuned the top 1 acc to 67%, still sort of a long way from the paper acc. I trained with batch size 256, 90 epochs and decay the lr rate by 0.1 every 30 epochs.
I'd be appreciated if there're any tricks that you could share with me to reach the 70 acc?
thanks a lot

please see: https://github.com/shicai/MobileNet-Caffe/issues/1


URL security

Authors and books has no security when an unauthorized user try to access this features direct by the URL

This should be fixed on ShiroEE


The language is updated only after the application is restarted

Thank you for your work. But please, help me!
When I change the language in the application, the buttons remain in the previous language

Yes, I save language in user default
Yes, I call synnchronize

@VOTONO When you say When I change the language in the application, do you mean you changed the language inside your app or in the System Settings?
If you did it in your app, can you show me some code? Thank you!

Inside my app.
langCultureCode is "en" , "fr", "ru" etc.
UserDefaults.standard.set(langCultureCode, forKey: "UserLanguage")
UserDefaults.standard.set([langCultureCode], forKey: "AppleLanguages")
UserDefaults.standard.synchronize()
It works well for GSMGeocoder, without restart

@VOTONO
Can you provide more details about how you use langCultureCode with Mantis?

This method automatically changes the language in other libraries. GMSGeocoder from Google, for example. I expected the same from Mantis.
Please tell me a way how to change the language without restarting the application.

@VOTONO
Finally I got a chance to address this issue by adding some new APIs.
Now you can use Manits.chooseLanguage() to set a new language without restarting app and use Mantis.resetLanguage() to reset to default behavior.
For example, if you want to change the language to German, you can use  Manits.chooseLanguage(Mantis.Language(code: "de"))
I haven't release a new version for it yet but you can test it in master branch.

I think the latest Mantis supports this feature. Since no response from last August, I close this ticket for now.


Clean up registry trait bounds.

This PR cleans up the Registry* traits, making them more readable in public documentation.
Fixes #130.

Codecov Report

Merging #131 (a3d3e55) into dev (3b62bd8) will decrease coverage by 0.00%.
The diff coverage is 98.42%.

@@            Coverage Diff             @@
##              dev     #131      +/-   ##
==========================================
- Coverage   95.04%   95.03%   -0.01%
==========================================
  Files          72       73       +1
  Lines        9891     9892       +1
==========================================
  Hits         9401     9401
- Misses        490      491       +1

Impacted Files
Coverage Δ

src/archetype/impl_debug.rs
0.00% <ø> (ø)

src/archetype/impl_eq.rs
100.00% <ø> (ø)

src/archetypes/impl_debug.rs
0.00% <ø> (ø)

src/archetypes/impl_eq.rs
93.33% <ø> (ø)

src/entity/allocator/impl_serde.rs
98.76% <ø> (ø)

src/hlist.rs
97.82% <0.00%> (-2.18%)
:arrow_down:

src/registry/debug/sealed.rs
0.00% <ø> (ø)

src/registry/eq/sealed.rs
100.00% <ø> (ø)

src/world/entry.rs
95.88% <ø> (ø)

src/world/impl_debug.rs
0.00% <ø> (ø)

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Kustomize deployment gives error while kubectl apply -k works.

What happened?
I tried to convert the command kubectl apply -k https://github.com/minio/operator (which works) into the following deployment:
version: v1beta11
deployments:
  - name: minio-operator
    kubectl:
      kustomize: true
      manifests:
        - https://github.com/minio/operator

Deploying it with devspace deploy --deployments=minio-operator gives the following error:
[fatal]  error deploying minio-operator: Error: unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization' in directory '/private/var/folders/ks/1ljb2tqn2dg4tt1ztjyt4nnw0000gn/T/kustomize-115242452/repo'

Please make sure `kubectl apply` does work locally with manifest `https://github.com/minio/operator`

What did you expect to happen instead?
I would have expected the deployment to work the same way kubectl apply -k https://github.com/minio/operator does.
How can we reproduce the bug? (as minimally and precisely as possible)
Local Environment:

DevSpace Version: devspace version 5.16.2
Operating System: mac
Deployment method: kubectl apply

Kubernetes Cluster:

Cloud Provider: other
Kubernetes Version:

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:23:52Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:15:20Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Anything else we need to know?

/kind bug

@fg91 thanks for reporting this! Does removing kustomize from your path work? DevSpace will prefer the kustomize binary over kubectl if it could be found in the path.

@fg91 thanks for reporting this! Does removing kustomize from your path work? DevSpace will prefer the kustomize binary over kubectl if it could be found in the path.

Yes, then it works. Is your recommendation to not use kustomize itself?

Usually our recommendation is to use kustomize over kubectl -k as that is usually several versions behind, but I was not aware of the extra features kubectl has over kustomize. We might want to add an option to force devspace to use kubectl instead of kustomize then.

Usually our recommendation is to use kustomize over kubectl -k as that is usually several versions behind, but I was not aware of the extra features kubectl has over kustomize. We might want to add an option to force devspace to use kubectl instead of kustomize then.

Makes sense 👍


Global activate doesn't support --git-ref

Global activate says it supports checking out Git source with a --git-ref. However, when trying to use this capability, the Git repo is checked out with a depth of 1, which only finds the main branch. Therefore, it currently seems to be impossible to activate a branch of a repo.

CC @slightfoot


Update deps to the latest suitable

What:
Use the latest versions of libraries that comply with our package.json

Why:
To address easily solvable vulnerabilities

How:
I've just run npm update

Checklist:

[x] Ready to be merged

Merged blocked until TS issues are solved (in a different PR)


⚠ Bofrost.at has degraded performance

In ce24235, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1450 ms

Resolved: Bofrost.at performance has improved in f49d7b3.


ROX-24833: Integrate Platform CVE Overview with BE queries

Description
Changes required to sync the UI with the production BE GraphQL queries.
Uses build 4.4.x-1011-gd887ad5d6a from https://github.com/stackrox/stackrox/pull/11604 for testing.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Remove all Chrome API stubs and visit the Platform CVE page:

View the Clusters tab:

View "Snoozed" CVEs:

Test other filters:

ocp-4-15-ui-e2e failure is a new one:
{expected '' to contain 'StackRox' AssertionError AssertionError: expected '' to contain 'StackRox'     at Context.eval (webpack://@stackrox/platform-app/./cypress/integration/productBranding.test.js:23:38)}
I'm confident that this is not related to the changes in this PR, but it is something we should keep an eye on. At first glance it looks like a timing issue, but I would expect it to occur more frequently if that is the case.


[gardening] Remove unused function swift_reflection_infoForChild(…)

What's in this pull request?
swift_reflection_infoForChild appears to be unused. @bitjammer - please review, I might be mistaken here :-)
Before this commit:
$ git grep infoForChild
stdlib/public/SwiftRemoteMirror/SwiftRemoteMirror.cpp:swift_reflection_infoForChild(SwiftReflectionContextRef ContextRef,
$

After this commit:
$ git grep infoForChild
$

Resolved bug number: –

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

It's not unused – this is API for external clients. It's also only a few days old. :-) Please don't remove it!

@bitjammer OK, closing :-)


Revise panel styles, implement close button and branch leaf icon

includes several design updates and implementations:

panel resizing as determined in co-working meeting today
new colors for header, footer, and panel, as well as box-shadow style per #125
implement close button with phosphor icon and placement/sizing per #84
implement leaf label icon for branch in leaf details #119

Also includes some updates to organize timetree scss a bit (new component for the panel), some name changes so styles/logic is more semantic and readable, and html change to make the close button more accessible. Revised the content positioning and flow for showing/hiding the panel and shrinking/expanding to fit content (using flexbox + columns); I have a placeholder for where the active label will be added.  I also added the Phosphor info icon image and style while I was adding the x button, so it will be ready to use when we get to #85
design review
@gissoo please check the styles - hopefully useful to review on percy as well as the render site

[x] updated colors for header, footer, panel
[x] close button icon, sizing, placement
[x] branch leaf label icon - sizing, placement, colors
[ ] panel sizing and content flow (adjusts size based on content; scrollable when appropriate; fixed to top of container on desktop and bottom on mobile)

@rlskoeser thank you!! Everything looks and works great!! Can we define a max height for the panel on desktop?
The only requirement I have in mind is about a 27px gap between the bottom of the panel and the top of the footer so the situation below wouldn't happen.

@rlskoeser thank you for the revisions!! Sure, we can talk about the problem on firefox in person.
The following have been fixed:

the close button and the leaf inside the panel aren't getting cut off anymore on Chrome
the height of the panel on desktop is great, there are no more overlaps with the footer

There are a few problems:

on chrome mobile simulator now the long panels are covering the whole screen and are not scrolling (like the #sand-hill leaf)
the project description panel appears a bit higher than the leaf panels (so when you choose your first leaf there is a shift, which is a bit annoying)

@rlskoeser I resolved the issue with the height of the page on firefox, something was messed up in my browser's emulator settings. Thank you for pointing it out! It looks fine on Firefox

@rlskoeser I resolved the issue with the height of the page on firefox, something was messed up in my browser's emulator settings. Thank you for pointing it out! It looks fine on Firefox

@gissoo whew, thanks for confirming!
@gissoo I made enough changes that I would prefer you test my latest revisions before we merge.  I had to rework the styles a bit to address the problem you found (I switched from flex to grid because I couldn't get the zero-height item to not take up any space in the flex column). There are some interesting constraints with the different sizing options; limiting the overflow vertically without hiding the box-shadow on desktop is kind of tricky!

@rlskoeser thanks for the changes. So it looks like now the panels that are too short have more space at their bottom than we originally intended, this is because you switched to grid? (They look ok)

the transition between devices looks good!
a link in #chief-mark-peters is not wrapped so the panel is scrolling horizontally –
the position of the project description/leaf panel is fixed now, so there is no more jumping between them
on safari there is a jump in the position of the tree, when some leaves are active the tree sits higher and with other it sits lower. (e.g. on #exodus it sits higher then on #midwest-resettlement it goes down a lot)

Fixed the overflow wrapping for chrome; not sure what's going on with safari (container size changing, maybe?), and it looks like the max length doesn't always work in safari either (but sometimes does?!). But we'll track that on a separate issue so we can get those changes merged.


Test-WebAdaptor false for two Servers with likely Context

If there are two WebAdaptors with a likely Context e.g.: server and gaserver
the Test-Webadaptor could be false.
Probably because of this if-clause:
https://github.com/Esri/arcgis-powershell-dsc/blob/1cd97d86ed7522e4e62bfcd3c5bc57491384a806/Modules/ArcGIS/DSCResources/ArcGIS_WebAdaptor/ArcGIS_WebAdaptor.psm1#L338

@spitzerr fixed.


Godot doesn't render objects correctly

Hello.
Godot doesn't render correctly all the objects created in here:
https://ghostbin.com/paste/quj9s
I found this issue to happen in version 2.2 of godot, haven't tested the other versions but I think the issue will happen in other versions except version 3 because it has new renderer too (maybe it will happen is version 3 too).
It uses this library: https://github.com/Zylann/godot_opensimplex but i don't think it is a problem of the library.
here is the problem that occurs:
https://gfycat.com/NegativeValuableBaleenwhale
Seems like it only occurs when the number goes more than a specific number, when testing, the number for me and someone else was different but at 100*100 we both had this problem.
Here is also a scene that you can download and shows this issue:
https://cdn.discordapp.com/attachments/212250894228652034/297829430015819776/tester.tscn
To see the problem, rotate the camera with your mouse.
Why is this happening?
Thank you.

I think there was something related to this in the project settings (max drawn objects)...

what is it?

it is rasterizer -> max_render_elements, but seems like it is limited and you can increase it or easily increase it(because i played it with a little and seemed like like if you put a number like<PHONE_NUMBER>99999999999 it won't change it to that number and maybe you have to play around with a little to increase more than a value) more than a value.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

As there was no answer to the above request, we're closing this issue as inactive.
If you can still reproduce it, please open a new issue against a currently supported release of Godot.


Fixes for CodeTour schema changes

Linked Issue
Relates to #1602
The CodeTour schema has changed since the CodeTour feature was released. This PR fixes .tour upgrade reports to work with CodeTour.

Coverage remained the same at 100.0% when pulling 2d942700e68dd87b0d1d98f84ebc25bbd9a925a9 on hugoabernier:hb-feature-1602 into 6619b8a952e2958b29afe450ffa573f232f1d29f on pnp:master.

Thanks! We'll review it shortly 👍

Merged manually. Thank you 👏


commands after az extension add -n xxx are not run in batch script on windows

Description of issue (in as much detail as possible)
I tried to run a batch script on windows with az extension add --name alias in. However I found the script stopped at this command and other commands didn't run. Like this:
script in try.bat:
python test.py
az extension add --name alias
python test.py
When I run try.bat, the output is like this:

And I have checked for sure that python test.py didn't run for the second time.
I also tried with another extension and had the same problem. And this problem doesn't exist on Linux.
Here is az version info:

Is there anything I can do to run batch script successfully? Thanks

Thanks for reporting the issue. We'll take a look.

CMD has some bizarre behavior. You need to add call to each of the command to avoid termination after running the commad. So you should have the follwoing in try.bat:

call python test.py
call az extension add --name alias
call python test.py

Close as this issue is not caused by CLI commands.


Don't skip tests named *Fourslash.ts

I noticed that I can't run the following tests:
tests/cases/fourslash/augmentedTypesClass3Fourslash.ts
tests/cases/fourslash/commentsEnumsFourslash.ts
tests/cases/fourslash/commentsExternalModulesFourslash.ts
tests/cases/fourslash/commentsInheritanceFourslash.ts
tests/cases/fourslash/commentsInterfaceFourslash.ts
tests/cases/fourslash/commentsModulesFourslash.ts
tests/cases/fourslash/commentsMultiModuleMultiFileFourslash.ts
tests/cases/fourslash/commentsMultiModuleSingleFileFourslash.ts
tests/cases/fourslash/commentsOverloadsFourslash.ts

fourslashRunner.ts skips tests/cases/fourslash/fourslash.ts (correctly), but the regex isn't anchored, so it also skips *Fourslash.ts. It's been like that since forever: https://github.com/microsoft/TypeScript/blob/214df64e287804577afa1fea0184c18c40f7d1ca/src/harness/fourslashRunner.ts#L30
Also, since there've never been any tests/cases/fourslash/*.d.ts files, and the .d.ts exemption is unique to this runner, I simplified the condition to just justName !== "fourslash.ts":
git log 'tests/cases/fourslash/*.d.ts'
# No output

FYI: There weren't any *Fourslash.ts tests before https://github.com/microsoft/TypeScript/pull/44652:
git log 0f216f36ec554da78793bd73a5294116000f6b57^ 'tests/cases/fourslash/*Fourslash.ts'
# No output

I applied https://github.com/microsoft/TypeScript/pull/46703, which landed in the meantime, to tests/cases/fourslash/commentsInterfaceFourslash.ts.


Feature request: Expand/Contract Selection

Hi, i'm using Pinta 2.1.1 on Ubuntu. I would really like an option to expand/contract your selection, like Photoshop does. Not to be confused with resizing your selection, which is already implemented. It would basically work like the attached screenshot. Thank you for this amazing program

Fixed by #746


nanoc --verbose has no effect

nanoc --verbose and nanoc compile --verbose don't have the same output.

I cannot reproduce this, nanoc --verbose works fine!