CORS Policy Error blocks API requests on Compare page

Description :
The Compare page is experiencing a critical issue where API requests are being blocked due to CORS (Cross-Origin Resource Sharing) policy restrictions. The error prevents data from being fetched through external APIs, resulting in a broken user experience on this page multiple times.
To reproduce, open the browser's developer tools to inspect the console and notice the error message. It automatically blocks due to increase in the number of requests sent.
Screenshots :
https://github.com/user-attachments/assets/19c2ecc1-6345-4f71-99bb-39f575077965
Participant role :
GSSoC
WoB
Hacktoberfest

@vanshchauhan21 Sir I am not able to understand the solution to this issue. Everywhere I read, it says the CORS policy error is best resolved by project admin or by the API provider. Some solutions suggested to build a seperate proxy server  to enable server-to-server communication, and I tried it, which removed the CORS error from the console. However, I now face a "404: API Route Not Found" error despite all the paths were correct.
How can I address this issue ? And can you fix it from your side ?


[WIP] Reimplement conditional compilation of isa targets using cargo features

This is a continuation of work started in #126
I've realised that this design doesn't allow conditional compilation of other project in the tree. For example, if user wants ability to compile cton_reader only for concrete target. To support it for all projects we need to define the same features (isa targets) that are defined in cretonne for cton-util, cton_reader and cton_frontend. Besides if we want to support native targets each project should have own build.rs file that checks enabled cargo features and sets native isa target if needed (as implemented in this PR in lib/cretonne/build.rs)
Maybe there is a better way and I'm missing something?

Your work here looks good to me, but I don't have a lot of experience working with cargo features.
I don't quite understand the problem you're describing, could you elaborate a bit with an example?

Sorry for the late response.
Here is an example: suppose we want to conditionally compile cton_reader crate for example for testing. To be able to do that we need to add the same cargo features as in cretonne crate:
[features]
default = ["riscv", "intel", "arm32", "arm64"]
riscv = ["cretonne/riscv"]
intel = ["cretonne/intel"]
arm32 = ["cretonne/arm32"]
arm64 = ["cretonne/arm64"]

I haven't tried it yet, but according to http://doc.crates.io/manifest.html#the-features-section it should work.
And as I mentioned in the previous comment each crate should have its own build.rs with the same logic of selecting a cargo feature to compile for a native target. For this part I think we can create a small crate that will only be used in build.rs scripts.
In overall I guess it's not a problem.  My main concern is that there will be a lot of duplication in Cargo.toml for each crate.
I hope I explained it better this time.

Thanks for spelling this out for me, I think I understand what you mean now.
I really would prefer if we can avoid the duplication of cargo features, so any features for controlling which targets get built are only on the main Cretonne crate.
I am thinking that a project that uses Cretonne through the front-end crates is going to have some direct interaction with the main Cretonne crate too. This means it will declare Cretonne itself as a dependency and it can specify the features then. I don't know how Cargo behaves when multiple crates depend on a crate with features. I am guessing it computes the union of features requested. That should be ok, right?
One thing to note is that these features don't change the public interface of the Cretonne crate at all. They are enabling code in isa sub-modules that is not exposed publicly. In particular, instruction opcodes like x86_udivmodx will still exist even when the intel target is disabled.

Ok, if I understand you correctly only cretonne crate will have these cargo features.
A couple of questions related to testing:

How should we proceed with testing regarding cargo features? Now I'm changing the list of default features in cretonne and ./test-all.sh. It's not good.
How should we handle isa dependent tests? For example this one in reader: https://github.com/stoklund/cretonne/blob/86215ca4125ce0801490a908f22d6011f39c5bb2/lib/reader/src/parser.rs#L2447
I'm thinking to wrap it in isa::lookup("riscv").

Hello, sorry for the delay in getting back to you here.

How should we proceed with testing regarding cargo features? Now I'm changing the list of default features in cretonne and ./test-all.sh. It's not good.
How should we handle isa dependent tests? For example this one in reader: https://github.com/stoklund/cretonne/blob/86215ca4125ce0801490a908f22d6011f39c5bb2/lib/reader/src/parser.rs#L2447
I'm thinking to wrap it in isa::lookup("riscv").

For these kinds of tests, does it work to just add #[cfg(feature = "riscv")] etc. to the test functions that need it?

Hello, sorry for the delay in getting back to you here.

No problem!
I need to refresh my memory on this. I will try on the weekend if I have time.

I'm working on filetest runner to skip tests that have unsupported isa target and I don't know a good way to handle this situation in parse_test since some methods of the parser require TargetIsa.
https://github.com/Cretonne/cretonne/blob/20de74f73bb935437cddbcda67d8bb89435265f8/lib/reader/src/parser.rs#L40-L61

I believe all the parts of the parser that use TargetIsa look like unique_isa: Option<&TargetIsa>. If a test has multiple isa directives, then None is used.
If a test has exactly one isa directive, and that isa is unsupported, the parser should stop and not parse the rest of the file. If the isa is supported, then we process the test as normal. Otherwise, unique_isa will be None, and we can just ignore the ISAs that are unsupported. Does that make sense?

I'm sorry, I stuck with other projects and don't have time to continue this. If there is anything left to do and someone willing to take away, I don't mind.

This is now implemented in #673!


browse selected method menu item would be useful in method browser, too

Everywhere that you have a method selected, it would be useful to have browse selected method option to open a method browser on that method in a separate method browser ...

in case a use case is needed for justification. Window on left is list of failing tests methods that need work. I just finished getting the first test to pass, and now want to move on to the other tests ... the window opened on right is in separate window for reference, but I had to navigate to the project browser and the method in order to open the window:

I think that the best course of action is to use a common method menu anywhere method lists & sources are displayed. Currently the respective menus for the browser, debugger, and the method list are different and maintained separately. Unifying them (and allowing for window-specific menu enablement - e.g. not running tests from the debugger possibly) would be easier to maintain.

For now, just fix the immediate request. Browse Selected Methods was added to the method menu list.
Also fixed that annoying pause when opening the method list context menu - was making an unnecessary round trip.


Virtual Paths/Directories in Azure

When using the package on a setup with multiple sites with Virtual Paths, only a single pair of webfarm servers are created. Instead a pair should be created for each site.
When only a single pair is created, the CMS suffers from JWT exceptions.

Exception:

@matiaspenelabm - I can confirm that the module doesn't provide a unique name for app instances hosted in virtual directories in Azure App Services. But, it does provide unique names for virtual directory hosted apps in IIS.
We could add a configuration for it to prefer IIS-based naming in Azure. Currently, naming based on Azure variables is preferred when in Azure, because the Web Farm names are much more readable.
With that said, it's hard to imagine how the custom name provider would affect this. Maybe somewhere in this call stack, IAppSettingsService is called, but it's not clear.
I'm more curious if your project already has a custom IAppSettingsService. If so, adding this module might cause your custom one to not be used.

Thanks @bluemodus-mwills,
From what I see, we do not have a custom IAppSettingsService. The webfarms and their names get created by the default/out-of-the-box Kentico code/solution. Because each virtual directory is an app on its own, the default kentico code executes and creates a webfarm set for each site as it would normally do.
However, when the custom name provider is in play my guess is that is goes off of Azure variables which are NOT unique per virtual directory/application and thus only creates one set of webfarms for ALL sites. (which in this project's case, causes issues)
I don't know enough about the setup, so I may be talking out of turn - but wondering if whatever we did to get IIS virtual directories to work - if something similar can be done for the Azure App Service equivalent.


Save files as UTF-8

A basic excel CSV export is not capable of saving files in UTF-8.  This causes issues if you are using any high ASCII characters like º for degrees symbol or anything similar.  Modify the code to save as a CSV in UTF-8 format instead of built-in excel method.

Resolved in commit 837ba286073b1c89973c0aa679d5316fbc1a8ba2


build: add guards against using secrets in forked PR builds

Closes #20505
Follows the instructions described in this blog post from the CircleCI team.

Hold off on review for now, we might be able to make the grace & litmus images public instead

Hold off on review for now, we might be able to make the grace & litmus images public instead


Strange issue - codegen?

Consider the following:
define parse_line(line: String) {
   var i = -1
   var ch = "X"
   var short = ""
   define get: String {
      i = i + 1
      ch = line[i]
      return ch
   }
   get()
   if ch == "-": {
      if get() == "-": {
      else:
         #var c = ch
         short = ch
      }
   }
   print(short)
}

parse_line("-o whatever")
=> -

Uncomment the apparently useless line 'var c = ch' and we get 'o' as expected! Not relying on the return value of get - i.e. calling it and then using ch - also eliminates the problem.

Strange indeed. I think that, in a roundabout way, this is being caused by functions assuming their output is valid, and always trying to transform it. dis shows that there are three upvalues being loaded at the top, but short is not an upvalue (i isn't either). I suspect that desync is what's causing the values to come out wrong.


Argo should provide a retry mechanism during errors

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST
What happened:
When Argo WF is executed and if there are any errors, currently there's no retry mechanism. It would help if argo retries the step/pod task and ensures its complete.
What you expected to happen:
When there is an error from the pod (not failed step), argo should retry that step/pod task
How to reproduce it (as minimally and precisely as possible):
Running Argo WF and sometimes we see pod deleted for one of the step and that fails the next steps.
Anything else we need to know?:
Environment:

Argo version:

2.3
$ argo version

Kubernetes version :

1.12
$ kubectl version -o yaml

Other debugging information (if applicable):

workflow result:

$ argo get <workflowname>

executor logs:

$ kubectl logs <failedpodname> -c init
$ kubectl logs <failedpodname> -c wait

workflow-controller logs:

$ kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name)

but that mechanism does exist - we use it extensively and there are 4 examples in the repo:
retry-container-to-completion.yaml
retry-container.yaml
retry-script.yaml
retry-with-steps.yaml


 No matter what I do, users always join as full members and not as guests. I did manage to finally get the channels-selection to show up as can be seen in the screenshot but invites still always turns people into full members.
We do have a paid account and manually converting users into guests works just fine

Reproduce

git clone https://github.com/rauchg/slackin
Add SLACK_CHANNELS to env-Array in package.json
now
When prompted for SLACK_CHANNELS, I entered general, (the trailing comma tip i have from this issue, seems there's a bug when just specifying one channel)
Visit now-URL
Select general-channel
Join Slack
❌  I am a full user

Happy about any pointers, spend a long time now going through the code but can't find the root cause of this. Did Slack change their API maybe? /cc @rauchg

Also seeing this issue /cc @rauchg

Does anyone know at which commit this feature works? I would like to rollback.

diff --git a/lib/index.js b/lib/index.js
index 864a699..3b986cd 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -190,7 +190,7 @@ export default function slackin ({

         if(resp.body.success){

-          let chanId = slack.channel ? slack.channel.id : null;
+          //let chanId = slack.channel ? slack.channel.id : null;

           invite({ token, org, email, channel: chanId }, err => {
             if (err) {

commenting out this line will make it work again,
this was introduced with the captcha apparently
not sure what the correct fix is though

@mmarchand does google captcha still work after this patch?

it seems so yes

Did this end up getting fixed? Thank you!

In the latest build the trailing comma is still required.


allow specifying the service as env var

This is required if running as a Github Action which doesn't allow passing parameters to docker create but allows environment variables

Codecov Report

Merging #3899 (7181b76) into master (e5b3f41) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3899   +/-   ##
=======================================
  Coverage   94.85%   94.86%
=======================================
  Files         448      448
  Lines       49007    49008    +1
=======================================
+ Hits        46488    46489    +1
  Misses       2519     2519

Flag
Coverage Δ

servertests
55.86% <100.00%> (+<0.01%)
:arrow_up:

unittests
94.73% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/server.py
67.50% <100.00%> (+0.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b3f41...7181b76. Read the comment docs.


Make sure compliance-trestle demos are running correctly - Simple SDK Examples

Describe the bug
Compliance trestle demos repo is outdated and needs refreshment and review.
It is needed to go through the Simple SDK Examples demo review it runs correctly as the documentation specifies concretely for this one.
Compliance-trestle version used for the generation of the demos is too outdated now vs the current one, so as part of the revision, it should be ideal to run the demo with the latest version and see if anything has changed or needs refreshment.
If there is anything needed to be done there by the demo, please submit a PR against the repo to be reviewed and tracked.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots / Logs.
If applicable, add screenshots to help explain your problem.
Environment

OS: [e.g. iOS]
Python version:
Installed packages:

This demo works with the current version of the trestle. But the demo README needs more instructions, which I made a PR for it.

Closing as moved to compliance trestle demos repo.


Angular 2 layout engine

I'm working with angular 2 and started using Material Design.  One major feature missing from the material design framework is how to generate a nice layout.  They suggest angular flex layout, however I disagree with the design in how all sizing must be specified in the html versus style sheets.  Does anyone know of a good layout engine for angular 2?
I really like how angular base apps makes it simple to generate layouts using the grid.  The interchange directives and visibility classes are also a great help in making it easy to generate responsive layouts.  If I can't find a layout engine I like I might consider creating an angular 2 version of this framework to help with responsive design on top of using angular's material design.

@soumak77 There is a layout API in Angular Material and I would expect them to have a similar feature for the second version.

I don't know much about angular 2 as I'm just starting to learn it but if I have to start from scratch following angular 2 way to build features I'd check bulma.io and picnicss.com as both are modern lightweight css-only frameworks with flex support. If anyone have ideas on how angular-base-apps should be best restructured to work on an optimized way with angular 2 please share.

@tolyo I believe they are pushing for angular/flex-layout to be the layout API for angular 2 (see bottom of material 2 feature list).  The problem I have is that every example has the styling being done via html attributes instead of css classes.  So when you have any responsive styling provided via CSS (i.e. the material 2 framework), your html must account for it.  This seems like a bad design approach and won't work well for large scale applications.
flex-layout does provide the functionality I want, I just don't like the interface they designed to use the framework.  The examples they provide are not realistic so it makes it difficult to figure out how to use the framework on a larger scale.

@soumak77 I see. Yes it looks like they are trying to solve a non-existent problem with those attributes. For version 2 of the framework, I would like to see a more BEMish approach to component styling use. It being used in MDLite and lends itself well to component design.


Choice selection issues

When deleting a choice selection from a feature that has a rank field, the rank field has validation complaints.
When adding choices to Novice Spell-scholar in prod, choices don't seem to persist even though the green "Choice applied" message appears. This does not seem to happen in local dev.

Repro:

Create a new character.
Add Mage level 2
Return to the character sheet, go to Novice Spell-scholar, and try to make choices
Choice appears to have saved but is not persisted, as can be seen by choosing another value.

✅Fix reproduced


.Net Hugging Face TGI Chat Completion Support

Motivation and Context
Closes #5403

Adding support to Chat Completion for TGI Deployment.
Adding Missing UnitTests for Streaming and Non Streaming scenarios (Text/Chat Completion)
Update Metadata + Usage Details for hugging face clients.

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Consider creating also generic SseData class

What's the plan for automatic function calling? Is that going to be in this PR or a follow-up?

What's the plan for automatic function calling? Is that going to be in this PR or a follow-up?

@RogerBarreto for reference, here is guidance from HF for tool calling support as part of the Messages API
https://huggingface.co/docs/text-generation-inference/conceptual/guidance#tools-and-functions-

What's the plan for automatic function calling? Is that going to be in this PR or a follow-up?

@RogerBarreto for reference, here is guidance from HF for tool calling support as part of the Messages API
https://huggingface.co/docs/text-generation-inference/conceptual/guidance#tools-and-functions-

@luisquintanilla, this PR already adds function calling support... but manual. It's the automated part I was asking about.


Closes #1298 Handle httpstatus errors in custom YAML Syntax Highlighter

This also fixes some linting errors and some format errors in the default config, so all of the files there work properly with the custom highlighter.

This change is

Will also add some Documentation to inspectit-ocelot-documentation before ready for review


How to resizeTo "real" size

I'm trying to set a precalculated crop bounding box. But using the bounding box values i've calculated using opencv (which are correct, or correct enough) they dont correspond with what i'm expecting.
When using startSize the resulting cropping mask is smaller than expected. Also the aspect ratio does not seem to match.

When using resizeTo the resulting corpping mask is a lot larger than expected.  It then extends beyond the croppr wrapper.

When I try to both resize the cropping mask using resizeTo and move it to the correct location using using moveTo neither the location nor the size are correct. It even seems like there are 2 masks drawn.

When i manually set the cropping mask and request the value using getValue the value returned is pretty much (ignoreing a few pixels difference) what i expect it to be and try to set programmatically...
Whats going on here? Am i missing something?
Context:
Image Real size: 1080 × 1080
cropper = new Croppr(document.querySelector(".cropper-wrapper img"), {
    startSize: [1050, 358, 'px'],
    aspectRatio: null,
    onInitialize: function(instance) {
      instance.resizeTo(1050, 358).moveTo(1, 366)
    }
});

Expected mask output according to opencv (ignore the strange colors):

Ended up implementing 2 new functions: resizeToReal and moveToReal. Will create a pull request for them a little later


[Bug]languages setting not valid in app.conf

I change languages in app.conf, but it has not effect on Casdoor UI.

Casdoor UI remains the full list of languages.


need to update warlock demonic pact calculation for 3.4.3 .  recommended code change in this issue

as per https://us.forums.blizzard.com/en/wow/t/wrath-classic-343-ptr-development-notes/1660806/4
recognize this isn't live yet, but I'm sure most people would prefer to be forward-looking and use the sim to plan ahead
I don't have write privs to this repo (and too lazy to fork) so I can't create a PR, but I think should be the diff:
@clarkg ➜ /workspaces/wotlk (icd1) $ git diff HEAD^
diff --git a/sim/warlock/talents.go b/sim/warlock/talents.go
index 536dfb4fb..6ba1369ab 100644
--- a/sim/warlock/talents.go
+++ b/sim/warlock/talents.go
@@ -548,7 +548,7 @@ func (warlock *Warlock) setupDemonicPact() {

        icd := core.Cooldown{
                Timer:    warlock.NewTimer(),
-               Duration: time.Second * 5,
+               Duration: time.Second * 1,
        }

        var demonicPactAuras [25]*core.Aura
@@ -578,12 +578,10 @@ func (warlock *Warlock) setupDemonicPact() {
                        newSPBonus := 0.0
                        if warlock.DemonicPactAura.IsActive() {
                                lastBonus = warlock.DemonicPactAura.ExclusiveEffects[0].Priority
-                               newSPBonus = math.Floor(lastBonus*dpMult*dpMult+
-                                       (1-dpMult)*dpMult*warlock.GetStat(stats.SpellPower)) + 1
-                       } else {
-                               newSPBonus = math.Floor(warlock.GetStat(stats.SpellPower)*(dpMult+dpMult*dpMult)) + 1
                        }

+                       newSPBonus = math.Floor(dpMult*warlock.GetStat(stats.SpellPower)) + 1
+

i.e. reducing ICD to 1 second and simplifying the calculation to always be 10%
https://github.com/wowsims/wotlk/blob/0e3107b41c11cc337b1da576d8b5954531f4b7bd/sim/warlock/talents.go#L549

I'll implement a option to switch to the new DP behavior, until the changes hit live.

@Tharre thank you SO much!  but commented on your PR namely about its correctness?


Add Elk2 Out of the box demo

https://github.com/salyh/elk2-out-of-the-box-demo

Hi @salyh,
Thanks for the submission. As you might have noticed, we already have a NYC traffic accidents example in the current repo.  Except for the vagrant / docker piece, how would this submission be different from that example?
Thanks!
Asawari

@salyh closing this out for now. Feel free to reopen.


Add possibility to trigger nightly tests manually in PRs

Feature request
Currently nightly tests as onnxruntime gpu tests can not be run in PRs. Would be nice to be able to.
Motivation
Check before merging that changes related to nightly tests are fine.

Does it exist on transformers? Not familiar with GitHub but there should be an easy way, I guess.

The super easy solution here is to just add workflow_dispatch to the list of triggering events in your workflow, such as here for generating the doc: https://github.com/huggingface/optimum/blob/df66bd3468e21044050f49b36056405bc40b08fb/.github/workflows/build_main_documentation.yml#L9
It will enable you to choose the branch you want to run the workflow on. For example, also for the doc, you can click on "Run workflow" and then select any branch you want: https://github.com/huggingface/optimum/actions/workflows/build_main_documentation.yml
But I'm not sure if that's exactly what you want.

Yes, it works in case the branch is under huggingface/optimum. I tend to work on my fork so could not launch the workflows.


Add taint checking to SQL connector

Purpose

SQL client connector provides the ability of using parameterized queries to avoid security vulnerabilities (SQL injections). However, the connector can be misused by appending untrusted data into the SQL query without using parameters.

Goals

It is required to prevent SQL client connector from being used insecurely. Any untrusted data should be added to queries as parameters or they should go through a validation process.

Approach

Use taint checking feature available with Ballerina compiler and make sure only "untainted" data is accepted as query of client connector. If tainted data must be added to the query, "untaint" unary expression can be used (after performing proper validation of untrusted data). Additionally, the return "table" produced by certain actions of the client connector is defined to return untrusted data.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

Unit tests

Yes

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

Closing the PR for now. This will be re-open after merging new function signature related changes.


Cannot set a budget on lazy loaded modules with ng cli 6.0.0

Defining budget for a lazy loaded module doesn't work with ng cli 6.0.0
Versions
Angular CLI: 6.0.0
Node: 9.5.0
OS: win32 x64
Angular: 6.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.0
@angular-devkit/build-angular      0.6.0
@angular-devkit/build-ng-packagr   0.6.0
@angular-devkit/build-optimizer    0.6.0
@angular-devkit/core               0.6.0
@angular-devkit/schematics         0.6.0
@angular/pwa                       0.6.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.0
@schematics/angular                0.6.0
@schematics/package-update         <error>
@schematics/update                 0.6.0
ng-packagr                         3.0.0-rc.2
rxjs                               6.1.0
typescript                         2.7.2
webpack                            4.6.0

Repro steps

Defines an application with lazyloaded modules
Declare in angular.json file a budget for one of the lazy loaded module (I tried several names, based on a lazy loaded module named st-account

"budgets": [
  {"type": "bundle", "name": "st-account", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "1.7d269d24f67b262c9dc9.js", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "StAccount", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "StAccount#Module", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "StAccountModule", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account-src-lib-st-account.module#StAccountModule", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account/src/lib/st-account.module#StAccountModule", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account/src/lib/st-account.module", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account-src-lib-st-account.module", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account-src-lib-st-account-module", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "st-account-src-lib-st-account-module-ngfactory", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" },
  {"type": "bundle", "name": "1", "baseline": "1kb", "maximumWarning": "1kb", "maximumError": "2kb" }
]

Run ng build --prod

Observed behavior
No error or warning is shown.
Desired behavior
An error or warning should be shown based on budget
Mention any other details that might be useful (optional)
If I run ng build --prod --named-chunks, a warning/error is shown based on the st-account-src-lib-st-account-module-ngfactory budget rule.

I have looked at this and for a temporary workaround you need to use namedChunks as at the moment, we using the name of the chunk to find the bundle that we want to compare with.
Example.
    {"type": "bundle", "name": "customers-customers-module-ngfactory", "maximumError": "1" }

In addition to the current need for --named-chunks, as I see it, one need to also add --no-common-chunk in order to practically be able to manage budgets for all of your lazy loaded feature modules.

Looks like the above no longer works since the introduction of Webpack 5 in version 12.


Add prefer-align-cpus-by-uncorecache feature gate

Description
Add documentation for new alpha feature gate: prefer-align-cpus-by-uncorecache
Issue
https://github.com/kubernetes/enhancements/issues/4800
https://github.com/kubernetes/kubernetes/pull/126750

This commit should be rebased onto dev-1.32 head, IIUC.

/remove-language fr
/remove-language hi
/remove-language ja
/remove-language ko
/remove-language pt
/remove-language ru
/remove-language uk
/remove-language zh

@wongchar Please rebase your PR to the dev-1.32 HEAD. Your current PR is difficult to review. It contains 44 commits to 37 files.

Hi @wongchar 👋
Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.
Thank you!

Hi @wongchar 👋,
A quick reminder to get your PR ready for review before the deadline, Thursday Oct 24 at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.
Thank you!

/remove-language ja uk zh

/remove-area web-development
/remove-area localization
/remove-area blog

Hi @sftim ! My understanding is we have time to the doc freeze and Nov 19 was the deadline to have documentation PRs submitted and ready for review (not merged!)
If my understanding is right I'm willing to help to kickoff the aforementioned concepts page.

@ffromani that's right. Help is welcome!

@ffromani that's right. Help is welcome!

ok! I'm willing to take a stab! (xref: https://github.com/kubernetes/website/issues/38121)

@ffromani that's right. Help is welcome!

ok! I'm willing to take a stab! (xref: #38121)

here: https://github.com/kubernetes/website/pull/48797

Technical lgtm provided above
/lgtm

@reylejano when you get the chance we just need your final review and approval for this one. Thanks!

Waiting for docs LGTM
Tech LGTMs noted
/lgtm cancel

Rebased to @ffromani 's PR (https://github.com/kubernetes/website/pull/48856). Thanks!
@sftim PTAL when you get a chance.

/lgtm
/assign @chanieljdan

tech and docs lgtm provided
/approve


Remove "Best Practices ListServ" from "Support" page

See here: http://prebid.org/support/support.html

Resolved by aa00f21


Temporary wrapper for TinyMCE not removed on saving

The "put" filter does not strip off the temporary <p> wrapper

Fixed by commit 0ebcd75d8dd409d9304bffe965504d07e4557724


[Tracking] SMask regressions from PR 4161

This issue is intended to help track various SMask related regressions from PR #4161.

[x] Issue 6165 - Bad render of sec-guide-to-proxy-brochures
[ ] Issue 6967 - Image in PDF doesn't load
[x] Issue 7143 - Some images are not rendered correctly/at all
[ ] Bug 852992 - [PDF Viewer] Image pattern not rendered
[x] Bug 1199237 - Wrong rendering by the FF built-in viewer of a PDF file correctly rendered with external PDF viewers

Note: This is a tracking bug, please do not post unrelated comments here!

The problem with all of the PDF files in the referenced issues/bugs is that they are fairly complex, thus making debugging much more difficult.
Hence I've tried to create a reduced test-case, see below, by manually removing/simplifying as much as possible in one of the PDF files (I hope that it still exhibits the same problem as original file).
bug852992_reduced.pdf

I hope that it still exhibits the same problem as the original file.
bug852992_reduced.pdf

It is not. But I have a fix for this particular case:
diff --git a/src/display/canvas.js b/src/display/canvas.js
index 5df5a73..4a04acc 100644
--- a/src/display/canvas.js
+++ b/src/display/canvas.js
@@ -869,6 +869,11 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
     },

     endDrawing: function CanvasGraphics_endDrawing() {
+      // Finishing all opened operations such as SMask group painting.
+      if (this.current.activeSMask !== null) {
+        this.endSMaskGroup();
+      }
+
       this.ctx.restore();

       if (this.transparentCanvas) {

#6967 is a weird one and looks like PDF.js is doing a right thing (?): mask is painted outside of page and when applied it hides the content painted on the page/

Bug 852992 contains two different issue, addressing the regression only

Let's keep Bug 852992 as unaddressed since http://martin.von-gagern.net/publications/2008-diploma/Diplomarbeit.pdf p.74 shows similar problem as Issue 6967

Closing since the mentioned problems are either fixed, won't-fix or have a dedicated issue, so there is no need for this tracking issue anymore.


Dude, no words

That's cool. Like, really cool.

what do you mean?

@yatli. I think it is nice to have omnisharp as a part of coc ecosystem, and not needing to install extra plugins.

I see. I thought this is a bug report, like "not showing some words" :D


Detect pipeline attribute during compile/run

Addresses #375

Nice change ! Makes it easier the import string was indeed a bit confusing.
Some notes:

did you check the documentation for cli examples that might need updating ?
In the original implementation when there was an error in you pipeline code the cli would just say that it could not find your pipeline but there was never any indication (traceback or special message) that there was something wrong is this easier in this implementation ?

Nice change ! Makes it easier the import string was indeed a bit confusing.
Some notes:

did you check the documentation for cli examples that might need updating ?
In the original implementation when there was an error in you pipeline code the cli would just say that it could not find your pipeline. There was never any indication (traceback or special message) that there was something wrong, is this easier in this implementation ?

Thanks Georges!

Just update the docs.
If there is no pipeline found it will return a valid error. I think the error that you're referring to was because of the default output path (which was wrongly set to None). This shouldn't occur anymore. It's either the default for kfp/docker-compose or a user custom one.


feature:topology: add user information for tap interfaces

As a end user, he may want to know the relations between the virtual machines and virtual ports(tap interface for example) from the topology.  This will provide a great convenience for the user.

@ji-xuepeng can you elaborate a bit on this, what kind of information ? currently if you have an agent on the hypervisor and another one within the VM you should have a link between the tap of the hypervisor and the interface within the VM ? is it not what you get or do you think about something else ?

@safchain I just want a VM's UUID will be displayed in the topoloyg shown in GUI. Thus, when I want to diagnose a VM, I will know which virtual interface belongs to the VM. I can do it through the following steps, but it's tedious.

Find virtual interfaces used by VM‘s UUID on the hypervisor.
root@ub1604-01:/# virsh domiflist 933c8f9a-09da-4955-aee7-04ad78a9de33
Interface  Type       Source     Model       MAC

tap58aa8eea-a5 bridge     qbr58aa8eea-a5 virtio      fa:16:3e:a4:82:f8
2. Do diagnostic tests on the virtual interface through the skydive GUI
If a VM's UUID is displayed in the topology shown in skydive GUI, I can easily find the virtual interface which is used by the VM before making a diagnosis test.

@ji-xuepeng if using openstack you already have the VM UUID reported on the tap thanks to the Neutron probe. It needs to be activated with the config file.

Yes,we can get the VM UUID from the metadata info of the port. But I think it is not convenient enough for users. the user must click ports one by one on topology diagram to  find which port belongs to the VM. Whether we can add the VM'image icon in the topology diagram, and associate the ports which belong to the VM with the VM'image icon?

Right I do understand now your point :) Yes we can change the icon another thing is we could add a select mechanism on the right panel

You can now put filters in the WebUI so that Skydive would highlight the tap for a specific VM UUID.


Port COM Lastprofil to BO4E-Python

[x] Port our own (Hochfrequenz) COMponent Lastprofil to Python.
[x] Add tests (to the python implementation) as usual
[x] Put focus on a well documented data model (docstrings) Ask for help if necessary.
[x] If the CI passes let someone from the Hochfrequenz team review it
[x] Do not merge it to bo4e/BO4E-Python yet! We want to use the COM Lastprofil to establish a git based workflow to enhance the official BO4E standard (meaning: someone from another company with functional knowledge should review it)

fyi @hf-krechan

https://github.com/bo4e/BO4E-python/pull/508


AI Nodes Updated

All AI-related node pages now have a new section "Description", with the descriptions that you see in the Halo Infinite node menus.
AI and AI Advanced categories have new Input and Output sections as well as their node images.

Move image files into \.gitbook\assets instead of the folder where the article goes. Update image paths afterwards.

Move image files into \.gitbook\assets instead of the folder where the article goes. Update image paths afterwards.

I'm confused. Do you want me to install Gitbook and then import my branch into Gitbook, and then redo the images and then push?

Move image files into \.gitbook\assets instead of the folder where the article goes. Update image paths afterwards.

I'm confused. Do you want me to install Gitbook and then import my branch into Gitbook, and then redo the images and then push?

Put the images in this folder https://github.com/The-Scripters-Guild/ForgeWiki/tree/main/.gitbook/assets that is in the repo.

Put the images in this folder https://github.com/The-Scripters-Guild/ForgeWiki/tree/main/.gitbook/assets that is in the repo.

I don't have permission to do that.

Well, ofc not to the main repo, but the equivalent folder in your fork that you're trying to merge https://github.com/HaloDiehards/ForgeWiki/tree/main/.gitbook/assets

Well, ofc not to the main repo, but the equivalent folder in your fork that you're trying to merge https://github.com/HaloDiehards/ForgeWiki/tree/main/.gitbook/assets

Do this within your VS Code environment, there should be a /.gitbook/assets folder. Move the images there and update the pull request.

Well, ofc not to the main repo, but the equivalent folder in your fork that you're trying to merge https://github.com/HaloDiehards/ForgeWiki/tree/main/.gitbook/assets

Do this within your VS Code environment, there should be a /.gitbook/assets folder. Move the images there and update the pull request.

Ok, thank you for directly pointing me to the assets folder. Images have been moved there, pages updated to use those images, and pushed the changes to my main branch. Do I need to cancel this pull request and do a new one, or does it update this pull request when I make changes?

Looks like it pulls the most recent, so it would include the fixes.

Looks good, approved.

Kewl. What has to happen for the wiki pages to be updated? (just curious on the process)

They'll get updated automatically after the merge. I had a delayed merge there accidentally.


Hi

Hi, I find some problem exist in bn from 0.4 to 1.0,so i can reach the mIoU like 0.4 and i can't find the problem in where.
can you implement a pytorch1.0 version? it will be very helpful~
thank~

Reduplicate issue.


Error out when using crc oc-env with a podman bundle

This is a different take on https://github.com/code-ready/crc/issues/2913
The set of commits is a bit random, and most of them are independant, so they can easily be reordered/dropped/...

/lgtm


Moving Thespian into mbraceprojects

Hi @palladin @anirothan
Thespian is a part of MBrace, and is also used for testing Vagabond.  Could we more the project to http://github.com/mbracepojects please?  That seems to be the logical home for it.
We need to make some updates to it - minor stuff related to updating FsPickler - and republish it.
Thanks
Don

The immediate problem is that Thespian depends on FsPickler 3.0 and we need to update to later versions of FsPickler https://github.com/nessos/Thespian/blob/master/paket.lock#L5

@anirothan @palladin You have access, so you can just transfer the repository across I believe.  Would be very grateful if you could, thanks

Done!

Thanks!


Changes, suggestions, new features, and fixes scheduled for 8.8.0

Put a comment below if you want to add/remove/modify something...
Fixes

gcc-12 workaround (#3) with (#25)
The test case for find_package was not robust enough, failing randomly in CI. It is now much better, explicitly guiding CMake to use the static library and to find the package config exactly where we install it. (#27)
Fix the ARMv7 build when ASM is enabled (#30).
Fix target architecture detection (#38)
Fix check_compile_link_option should use CRYPTOPP_COMPILE_DEFINITIONS (#37)
Fix detection of home-brewed libomp (#39 and #49)
Fix: typo in sources.cmake resulted in failed source deduplication (#41)
Fix: fix platform detection to properly work with cygwin and mingw (#54)
Fix: set compiler env for the tests for better control of the environment (#53)
Fix: use repos via CPM in tests consistently (#65)

Crypto++

Sync the compiler settings with crypto++ for the supported architecture and compilers. Note that some architectures/compilers could not be tested (IBM, SUN) and may fail. Help is needed from people who use/have such compilers.

Enhancements

More robust handling of compiler caching with ccache. Change the installation method to pull the latest version of ccache with much better hit rate and more stability with MSVC. This significantly reduces the rebuild times, locally, and on GitHub CI. (PR #28)
Upgrade GitHub actions (#36)
Prefix test names for easier filtering (#55)
Extract release workflow into a separate file (#56)
Split Mac actions in the CI workflow (#58)
Split Ubuntu actions in the Ci workflow (#59)
Set build type to Debug when building inside a git repo and Release otherwise and limit choices in CMake GUI to these two types (#57)
Add msbuild and nmake variants to Windows CI workflow (#63)
Simplify and enhance Mac tests (#66)

Special Thanks
@Vollstrecker

Following #41 ,  I wonder if we should do it the LLVM way. (Not sure the official name for it)

Introduce branch 8.7.0
On that branch, tag CRYPTOPP_8_7_0 or CRYPTOPP_8_7_0_1, etc

Maybe we should change from issues to projects with everything that is not really an issue. At least I could keep track of all the stuff I have in mind and maybe someone can pick up an idea or discuss a topic even before it started.

Maybe we should change from issues to projects with everything that is not really an issue. At least I could keep track of all the stuff I have in mind and maybe someone can pick up an idea or discuss a topic even before it started.

We could. I was using this issue only for the purpose of having an accurate changelog for when we do the upgrade to crypto++ next. People usually upgrade cryptopp-cmake mainly when they bump crypto++ and os this issue will tell them exactly what happened in-between.
Do you need any special permission to create a project @Vollstrecker ?

I guess I need some. I can link issues etc. as project and link some I create on my account. For the project (I guess it's called organisation here) is not even a menu-item visible. I've just seen this on other projects and thought it's really handy, the projects done are at least as good for a changelog as this issue, and it's much better viewable.
I never dug deep enough into the permissions-system (or the projects) to tell more about that.

I can't find anything in the repo settings to change permissions for projects.
Anyway, I created one, linked it to this repo and added you to it. Feel free to use it and let me know if I need to do something else to make it work for you.
https://github.com/users/abdes/projects/3

Already saw this. I played around a bit on my own. I've found the settings-page where you can set visibillity, where it states that setting such things is possible (was interrupted investigating by this answer).
It seems that this works using issues, but as long we'll see how this works out.
Have you thought about things like "no direct to master commits" and "no merge without review" policy? Just because I accidentally commited to master last week.

Have you thought about things like "no direct to master commits" and "no merge without review" policy? Just because I accidentally commited to master last week.

Crypto++ 8.8.0 is released.
This issue is now closed.


Freehand pencil

This is kind of a big one so bare with me!
Demo: https://deploy-preview-402--cornerstone-tools.netlify.com/examples/freehandroi/
========New features========
The ability to add or remove handles after completion:
-- Ctrl + clicking on a line will insert a handle there.
-- Ctrl + clicking on a handle will delete that handle, provided there are more than 3 handles.
Revamped Pencil mode:
-- Shift + click will once again enter pencil mode, however the resulting object will be the same data structure as the manual polygon mode: a set of handles by which statistical calculations can be calculated (more suitable for storage and e.g. export to, RT-STRUCT or AIM imageAnnotationCollections).
-- After one shift+click the user can move the mouse freely to draw the ROI.
-- If the user crosses lines, the ROI will light up as its invalidColor and no points will be placed until the mouse is moved to a valid position.
-- When the user moves the mouse back to the origin of the ROI, the handle will increase in size indicating that the user can click to complete the ROI (This has also been added to manual mode).
Enhanced Freehand Configuration:
-- spacing: The minimum spacing between points in pencil mode (default= 5).
-- activeHandleRadius:  The handle radius when the tool is being edited (default = 3),
-- completeHandleRadius: The size the handle appears when the ROI can be completed.(default = 6),
-- alwaysShowHandles: When not in use, the handles of the ROI are not shown by default, such that the user sees just the contours. However, if alwaysShowHandles is set to 'true', the handles are always displayed (default = false),
-- invalidColor: When drawing/editing an ROI if the mouse is placed in an incorrect position, such that the new line would intersect another, the ROI flashes up a warning color (default = 'crimson').
Other:
--manipulators/drawHandles.js can now draw a custom handle size if options argument contains the property 'handleRadius'. This is not a breaking change as if the property is not set the old default behavior is used.
--Unit tests added for pointInFreehand.js, freehandArea.js, freehandIntersect.js and calculateFreehandStatistics.js.
Bug fixes:
-- PR #404 didn't return anything in textBoxText, resulting in the textbox displaying undefined. This has been fixed.
======Changes/Refactoring=======
I've done some major refactoring of the tool, as it already significantly more complex than the other region of interest tools.
-- The freehand.js file contains mostly event handling, with the implementation of abstracted functionality found in in utils/freehand/. I thought a sub-directory is necessary as to not clog up the utils directory, but this could be changed should the team desire. Athough this isn't perfect yet I will refactor more as I expand the tool.
-- Renamed all instances of "node" to "handle" to stay consistent with the nomenclature across cornerstoneTools.
-- Renamed all variable/function instances of "freeHand" to "freehand".
I hope you'll all be excited about this one as much as I am!

Coverage decreased (-0.1%) to 4.309% when pulling 616927796d6334055ce12c14b5a2108b99b9264c on JamesAPetts:freehand_pencil into 9155ff256233fef86ca42b87207124446d3687f6 on cornerstonejs:master.

Note I'll get on Docs etc in a few weeks, but I am currently skimped for time whilst preparing for a conference.

P.S. Something we need in here soon is some way of cancelling the creation of an ROI, (e.g. right click whilst drawing). Especially with the pencil mode, one can get in a pickle with some ease. This shouldn't take that long to implement and again I'll work on this when I'm back from ITCR.

In OHIF we use the Esc key to cancel drawing something, maybe that could work? I don't know if I want to include it in the tool itself though.

In OHIF we use the Esc key to cancel drawing something, maybe that could work? I don't know if I want to include it in the tool itself though.

Ahh, right, I didn't know that functionality exists, I'll look into it.

Ctrl + Click to place a new point is maddeningly difficult.. Maybe we could make it easier somehow?

I'm guessing the issue is the handles blinking on and off? In e.g. OHIF I was planning to simply have a toggle for alwaysShowHandles for editing, but how about if when the ctrl key is held down all handles are shown anyway?
Or was it is a different issue? Feedback would be welcome.
Thanks,
James

Thanks @diego0020 and @swederik, nice catch. This is an easy fix, i'm going to turn my attention to this after the conference this week.
Thanks,
James

Note this branch is currently a little busted whilst I write some tests and resolve these issues.

Do you have the browser focus on the proper element?  I don't think you'll receive the events otherwise.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex

The browser focus must be on the proper element, as the mouse interface works fine. I tried explicitly forcing focus, but this didn't fix the issue. The test source can be found here

Hey @swederik, @diego0020,
I've fixed the issue diego found (thanks!) and made it such that holding ctrl pops up all the handles of ROIs, such that it is easier to modify them with the add/remove point ctrl+click functionality.
Also added a load of jsdocs and a few unit tests.
JamesAPetts

Updated with recent commits to master branch, and fixed an issue introduced in PR #404:
-- PR #404 didn't return anything in textBoxText, resulting in the textbox displaying undefined. This has been fixed.
I feel this PR is complete, so i'm going to make another branch for the next bit of functionality.
Welcome to more feedback/criticism.
Cheers,
JamesAPetts

@swederik V1.0 of the freehandSculpter tool is tested and ready for submission. I'll wait for this PR to be accepted before submitting another that builds upon it.
Cheers,
JamesAPetts

Thanks! Looks good!


API for retrieve components version

Theres no easy way to retrieve components version of a deploy

We've changed the way the services are tagged to maker easier to associate the dojot's version with the services' versions. At the moment we don't see necessity to have an API for this, so this issue will be closed.


help !

im very new to this stuff. i was wondering if anyone is willing to do a video tutorial on this because im more of a visual learner. thanks.

Hello,
No there won't be any video tutorial, this project is not meant to be used as-is, it is not a one-click install. Instead it provides the building blocks to write your own scripts. If you can't write javascript/coffeescript then I'm afraid you can't use this project.


Feature Request - Show more information on error of build

It would be nice if Travis Buddy showed more information in his comment when the Build evals to status: "errored"
Example PR for the current behaviour (will probably change soon so here to document what he says:
TravisCI finished with status errored, which
means the build failed because something unrelated
to the tests, like a problem a dependency or the build process itself.

Example Build where that happened to me
It should show at least the following important information:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version
">=4 <=9".
error Found incompatible module

related to #108  - definitely agree that we should post build log in every status


Fix crash with Quit menu item on Windows

Fixes #18
Making the Quit item actually quit the application will be added when libui-node 0.1.0 is released (WIP at https://github.com/mischnic/proton-native/tree/libui-node-010).

Thanks! I've just bumped the version so I can push the update.


Test documentation and failing slow running tests

First, a small paragraph on how users can run the tests with pytest and what the machine requirements are (cuda), with a mention of the --runslow option would be expected in the README.
I was able to run the "fast" tests with success, but I encountered errors with the slow running tests.

The test_field_divergence test fails due to missing cuda device (expected), but perhaps the test could be skipped in the absence of an available cuda device.
The test_nnparams_load_trained_TAUNET and test_nnparams_load_trained_CUSTOMMLP fail because the object OnePointSpectraDataGenerator is instantiated without the zref argument:

    @pytest.mark.slow
    def test_nnparams_load_trained_CUSTOMMLP():
        pb = CalibrationProblem(
            nn_params=NNParameters(
                nlayers=2, hidden_layer_sizes=[10, 10], activations=[nn.GELU(), nn.ReLU()]
            ),
            prob_params=ProblemParameters(
                nepochs=2, eddy_lifetime=EddyLifetimeType.CUSTOMMLP
            ),
            loss_params=LossParameters(alpha_pen2=1.0, alpha_pen1=1.0e-5, beta_reg=2e-4),
            phys_params=PhysicalParameters(L=L, Gamma=Gamma, sigma=sigma, domain=domain),
            device=device,
        )

        k1_data_pts = domain
        DataPoints = [(k1, 1) for k1 in k1_data_pts]

>       Data = OnePointSpectraDataGenerator(data_points=DataPoints).Data
E       TypeError: OnePointSpectraDataGenerator.__init__() missing 1 required positional argument: 'zref'

test/io/test_model_params.py:123: TypeError

Please clarify if this is the expected behaviour.

I saw that the slow running tests are not run on each commit, so maybe that's the issue...

Hi. These have been fixed in #103 and the slow tests are now run on all push/pull-request to main.

Could you just add that --runslow is a pytest option in the development installation instructions, so users who want to run the tests don't have to go read the test code to figure this out ?

Good !


Rename test workflow

This pull request renames the Test workflow to Tests (in plural).

coverage: 100.0%. remained the same
when pulling ae858a69ebcd4024062d31ec9da1147ad195856a on rename_test_workflow
into 49b3227ca5b8c2d939929e70a222b8b2efdacdbb on master.


Send HTML texts for email and plain text for others Activities on Social.activityView()

Guys, first, thanks for this module that every Titanium developer uses.
I was trying to send HTML messages by email and non-html for others, like Twitter, SMS or Facebook. The scenario was:
var message = "HTML message is awesome";
Social.activityView({
     subject : 'I would like to share this '+type+' with you',
     text: message,
     removeIcons : 'contact,camera',
     emailIsHTML : true
});

So when the "emailIsHTML" is set to "true" the issue appears: the others activities texts become empty "".
Diving in the module code I noticed this (NappItemProvider.m):
if ([activityType isEqualToString:UIActivityTypeMail]) {
        NSString *text = [NSString stringWithFormat:@"%@%@%@", @"", _customText, @""];
        NSLog(@"[INFO] Sharing the following as HTML %@",text);

        return text;
    }

    return @"";

I think that's the problem!
So I fixed, and created a brand new option for Ti developers: htmlText
So now, if emailIsHTML is true, the e-mail activity will read this property to compose the email dialog.
The code in module files now looks like this:
-- DKNappSocialModule.m -> for both activityPopover & activityView
NSString *htmlshareText = [TiUtils stringValue:@"htmlText" properties:arguments def:nil];
NSString *shareText = [TiUtils stringValue:@"text" properties:arguments def:@""];

if(shareText){
        if (emailIsHTML) {
            NappItemProvider *textItem = [[NappItemProvider alloc] initWithPlaceholderItem:@""];
            textItem.customText = shareText;
            if(htmlshareText){
                textItem.customHtmlText = htmlshareText;
            }else{
                textItem.customHtmlText = shareText;
            }
            [activityItems addObject:textItem];
        } else {
            [activityItems addObject:shareText];
        }

    }

-- NappItemProvider.m
if ([activityType isEqualToString:UIActivityTypeMail]) {
        NSString *text = [NSString stringWithFormat:@"%@%@%@", @"", _customHtmlText, @""];
        NSLog(@"[INFO] Sharing the following as HTML %@",text);

        return text;
    }else{
    	NSString *nonhtmltext = [NSString stringWithFormat:@"%@", _customText];
        return nonhtmltext;
    }

    return @"";

And of course, the
@synthesize customHtmlText = _customHtmlText;

Now, back to Titanium, the code will looks like this:
var noHtmlMessage = "Non html message";
var htmlMessage = "HTML message is awesome";
Social.activityView({
       subject : 'Cool message subject',
       text: noHtmlMessage,
       htmlText : htmlMessage,
       removeIcons : 'contact,camera',
       emailIsHTML : true
});

So, will looks like this on Mobile
Bold for text! Yay \o/

Another detail, if 'htmlText' is null, I'm using the same text for both activities.
That's it. If Napp guys (@viezel) like this improvement, I think it would be awesome if it becomes part of the root module.
I've uploaded my version of the module, so you guys can check if you like it:
https://www.dropbox.com/s/x2xmpcux8x78hhr/dk.napp.social-iphone-1.8.2.zip?dl=0
PS
About Facebook empty message: This is a problem with iOS 8.2+ and new Facebook rules, this thread make it a little bit clear:
http://stackoverflow.com/questions/29943202/setinitialtext-method-in-slcomposeviewcontroller-ios-8-3-does-not-show-text-in-f
Looking forward for your feedbacks!
Code Strong

Looking great. Can you please make a PR?

I've created a new branch, commited, but I'm not able to push it (to make the pull request).

=(

you have to fork it to your own github account.
then create a new branch on that account.

done =)
https://github.com/viezel/TiSocial.Framework/pull/144


Generate (test) coverage statistics

To identify parts of our code that are not covered by tests, or dead code in practice, generating coverage reports would be helpful. Another use case is to quickly identify which parts of PDF.js are relevant when analysing an issue in a specific PDF file (this can especially be useful to new contributors).
There are multiple tools, but I have had a good experience with https://github.com/gotwarlost/istanbul.
It can be integrated with Travis, and the results can be published to an external service such as coveralls, see e.g. https://coveralls.io/github/Rob--W/cors-anywhere?branch=master (integrated with https://github.com/Rob--W/cors-anywhere/commit/f9af03e76249b4dd38722b459293773ccddb6c7d).
PDF.js has different ways of execution that I know of (see gulpfile.js for more details):

unittestcli - Runs some unit tests of PDF.js in Node.js (with minimal source changes, only with transpilation with babel, configured in gulpfile.js).
unittest - Runs some unit tests of PDF.js in the browser (with minimal source changes, only with transpilation by babel, configured in systemjs.config.js)
browsertest - Runs tests in browsers (we test Chrome and Firefox). This relies on the binary created by the generic build target, which uses code transpiled with babel and then bundled with webpack (configured in gulpfile.js).
examples/node/pdf2svg.js - Can be used to trigger the SVG rendering backend on Node.js (depends on the generic build target, just like browsertest)
as a browser extension (Firefox / Chromium), using the firefox / chromium build targets (uses a similar build process as the generic target, just with different DEFINES)

Ideally we would obtain coverage statistics for the original sources, but to start with we could also settle for coverage statistics on the generated JS files that directly run in the browser / Node.js (if it is easier).

unittestcli - Runs some unit tests of PDF.js in Node.js (with minimal source changes, only with transpilation with babel).
browsertest - Runs tests in browsers (we test Chrome and Firefox). This relies on the binary created by the generic build target, which uses code transpiled with babel and then bundled with webpack.

Note that while browsertest will run the reference tests, there's also the unittest command which runs the complete set of unit tests in browsers (as opposed to unittestcli which only runs a subset of the existing unit-tests).
Furthermore, note that the "transpilation with Babel" step will be skipped, if the PDFJS_NEXT build flag is set (either like other build flags in gulpfile.js, or as a command-line argument). While the code is still bundled with Webpack, at least it's possible to avoid the transpilation step.

@Rob--W  I would like to work on this

It's yours! Let us know (preferably on IRC) if you have questions.

@timvandermeij  I am thinking to use Karma tool.It works with the istanbul code coverage engine.Statistics can be checked for the tests execution,  HTML reports can be made from it.Is it a good way to start?

Using Karma I got test reports https://drive.google.com/file/d/0ByddvU1PKkWaWEZTWHFYT0Y0aTg/view?usp=sharing
but Test coverage statistics are not being shown https://drive.google.com/file/d/0ByddvU1PKkWaS1ZiT1dobU1DQUk/view?usp=sharing

@Divya063 Could you share your code, e.g. by pushing your current code to a branch on your pdf.js fork on Github? I wonder whether webpack or babel is being run when necessary.
And which version of Node.js are you using?

Thank you for the response,Node version is 6.11.1. Here is the link to branch https://github.com/Divya063/pdf.js/tree/dev

The errors are:

Firefox 43.0.0
SyntaxError: import declarations may only appear at top level
Chrome 60.0.3112
Uncaught SyntaxError: Unexpected token import

This indicates that the code is not transpiled before use. Currently there is built-in support for ES modules is not enabled by default in any browser (more info), so code needs to be transpiled first.
I have edited my initial post to point out where the transpilation is configured in PDF.js's build system. Perhaps you can try to use an existing plugin to integrate istanbul and babel. A quick search shows  https://github.com/istanbuljs/babel-plugin-istanbul, but there may be other options too.
(and Firefox's current stable version is 55. You were testing with Firefox 43, which is ancient and not supported. I suggest that you upgrade to a recent version of Firefox before testing again)

@Rob--W Thank you for indicating the errors.I will update soon with the results.

@Rob--W I transpiled the code using karma-browserify  and upgraded the firefox version but still lots of errors are coming up.Here is the link of branch https://github.com/Divya063/pdf.js/tree/dev

Can you share the error messages?
And if possible, try to use webpack instead of browserify, because webpack is what we use already. Doing so allows us to instrument the code that is actually used in the browser.
And I also see that you are checking in .idea and other user-specific project/IDE files. When you contribute to an existing project, it's better to not add unrelated files to the project, because it clutters the repository and causes merge conflicts. In the final pull request, these files should not be included.

Is this issue still up? If yes, I would like to work on it.

Yes, feel free to work on this.

@timvandermeij
I was working on this. I've used istanbul to cover my tests and coveralls to display the reports. I've made the required necessary changes wherever needed. However, whenever I run coveralls using
npm run coveralls

I get the following error
npm run coveralls

><EMAIL_ADDRESS>coveralls /home/shikhar/Desktop/mozillaPdfJs/pdf.js
> npm run cover -- --report lcovonly && cat ./coverage/lcov.info | coveralls

><EMAIL_ADDRESS>cover /home/shikhar/Desktop/mozillaPdfJs/pdf.js
> istanbul cover test/**/*.js "--report" "lcovonly"

Running test 1/16: test_first_run
Running test 2/16: test_first_run_incognito
Running test 3/16: test_storage_managed_unavailable
Running test 4/16: test_managed_pref
Running test 5/16: test_local_pref
Running test 6/16: test_managed_pref_is_overridden
Running test 7/16: test_run_extension_again
Running test 8/16: test_running_for_a_while
Running test 9/16: test_browser_update
Running test 10/16: test_browser_update_between_pref_toggle
Running test 11/16: test_extension_update
Running test 12/16: test_unofficial_build
Running test 13/16: test_fetch_is_supported
Running test 14/16: test_fetch_not_supported
Running test 15/16: test_fetch_mode_not_supported
Running test 16/16: test_network_offline
All tests completed.
No coverage information was collected, exit without writing coverage information
[error] "2017-12-17T11:00:06.112Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2017-12-17T11:00:06.116Z"  'input: ' ''
[error] "2017-12-17T11:00:06.116Z"  'error from convertLcovToCoveralls'

/home/shikhar/Desktop/mozillaPdfJs/pdf.js/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Failed to parse string
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>coveralls: `npm run cover -- --report lcovonly && cat ./coverage/lcov.info | coveralls`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>coveralls script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>coveralls script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/shikhar/.npm/_logs/2017-12-17T10_42_28_314Z-debug.log

I tried looking this uphere and here but to no avail. Any help on what the problem might be ?

It's hard to tell without seeing the code. Could you push the code to a branch so contributors here can look along with you?

@timvandermeij  here it is. Please ignore the gem file. i've already removed it.

Any comments @timvandermeij

From a bit of Googling it looks like this error means that coveralls is not getting data in the lcov format. You could check if the individual commands in npm run cover -- --report lcovonly && cat ./coverage/lcov.info | coveralls in fact return the results you expect.

Ohk @timvandermeij Ill do that

@timvandermeij
The main problem currently is this statement
No coverage information was collected, exit without writing coverage information
Because of this the lcov file at all times remains blank and thus this happens
[error] "2017-12-17T11:00:06.116Z"  'input: ' ''
[error] "2017-12-17T11:00:06.116Z"  'error from convertLcovToCoveralls'```

On googling, it seems that these are very common errors. and the error basically lies with istanbul. I tried switching between different versions of the same but the error kept occurring. However, at all places the testing has been done by mocha and not by lint or unittest etc. and thus most(almost) of the resolutions too are for mocha only. These were some sources I looked up to [https://github.com/gotwarlost/istanbul/issues/262](https://github.com/gotwarlost/istanbul/issues/262)
[https://github.com/coryhouse/react-slingshot/issues/245](https://github.com/coryhouse/react-slingshot/issues/245)
[https://github.com/gotwarlost/istanbul/issues/496](https://github.com/gotwarlost/istanbul/issues/496)

I'm not really sure why that's happening, but I also find a lot of people that did it successfully with Jasmine, so it must be possible. Could you try if https://bryce.fisher-fleig.org/blog/setting-up-istanbul-with-jasmine/index.html works for you? First just try those exact steps to see if works stand-alone, and then try to integrate it in PDF.js.

@timvandermeij on it

@timvandermeij
Here they are the build passing and calling for coverage.
The coverage producing reports
However, as the import and export statements exist, even after reaching those files, they arent fully tested. As far as I know I need to babelify these files to ES6 before jasmine testing and that is proving to be a problem. How do I provide ES6 code to jasmine ?
Can I make changes in the gulp file as mentioned here http://jpsierens.com/use-es6-right-now/ ?

You're indeed getting closer to the solution. From the coverage reports it looks like you run the coverage on the lib files, which should already be transpiled to ES6 (see https://github.com/mozilla/pdf.js/blob/6ac9e1c5ed0d5f067872b8482724c171c79566b2/gulpfile.js#L965 and https://github.com/mozilla/pdf.js/blob/6ac9e1c5ed0d5f067872b8482724c171c79566b2/gulpfile.js#L985). Or is the problem that the unit tests themselves are not transpiled? I'm not really familiar with how that works exactly, but if that is the case than some changes to the Gulpfile for the unit tests may be necessary.

@timvandermeij

Or is the problem that the unit tests themselves are not transpiled? I'm not really familiar with how that works exactly, but if that is the case than some changes to the Gulpfile for the unit tests may be necessary.

The problem was I was running the tests in the wrong folder. build>lib folder already contains the entire project in ES6 format and I have now corrected the entire thing i.e. the path of jasmine and coveralls.
Another problem was the  --report lcovonly statement. Magically ( I really dont know why ) when I removed this part from the coveralls line, reports started getting generated.Maybe I should've paid more attention to

You could check if the individual commands in npm run cover -- --report lcovonly && cat ./coverage/lcov.info | coveralls in fact return the results you expect.

Thank you for pointing this out.
Finally, we are able to generate reports :tada:  and though they look a bit sad but reading the exact files will get you the reason why -

All unexecuted conditional statements are being counted as 'not covered'.
All unexecuted assignment statements too are being counted as 'not covered'.

I obviously havent uploaded the generated reports my self but have hosted them on a link here http://pdfjscoveragereport.bitballoon.com. Please visit these links and you will get the exact report expected.
However these results are not reflected on coveralls.io :cry: I dont know why. Also, I've noticed that even after committing multiple times coveralls is still building my project based on a very old commit and not on a recent one because of which coverage there, though gets generated, but always remains 0 (even though it isnt 0 now). Please help me on that
Though npm run coveralls will give the entire coverage reports in this format lying in the build/lib/coverage/lcov-report folder.
I hope this helps finally though our last problem is to show these reports somehow on coveralls
This is the link for my latest build.https://travis-ci.org/shikhar-scs/pdf.js
This is the link for my latest commit.
Apart from the reports not being generated on coveralls.io everything is fine I guess. So shall I generate a PR ?

Nice work! It's really good to have an idea of the coverage and the reports finally give us that. Indeed it clearly shows that we need a lot more unit testing, but all the methods we recently added unit tests for are indeed shown as covered in the report, so that looks perfectly fine.

So shall I generate a PR as it will attract attention from many more people and might solve this issue earlier instead?

Yes, that's a good idea. We can then start the review process and see which issues are left to address.

It's really good to have an idea of the coverage and the reports finally give us that. Indeed it clearly shows that we need a lot more unit testing, but all the methods we recently added unit tests for are indeed shown as covered in the report, so that looks perfectly fine.

While it's certainly true that we could do with a lot more unit-tests, there large portions of the code that probably won't ever get anywhere near "good" enough test-coverage just from unit-tests alone.
As mentioned in https://github.com/mozilla/pdf.js/issues/8632#issue-241690851 there's a few different test-suites, and unless I'm mistaken getting coverage results from gulp browsertest as well would be almost essential to really know what our actual test-coverage looks like.

@Snuffleupagus @timvandermeij
This morning I've extensively tried finding coverage reports in all of the folders individually using the statement cd build && cd lib && istanbul cover --include-all-sources jasmine-node test, changing different directories using cd <directory name> and testing using jasmine-node <directory names and js files> but in vain.
Though tests report are getting generated at times (not always), this is happening because of the one or two ES6 format js files lying in the specific directories (which is only bringing  <2~3% of coverage reports). Sadly, any js file which contains the import or export statements  is returning an error in this format.
Transformation error for /home/shikhar/Desktop/mozillaPdfJs/pdf.js/src/core/arithmetic_decoder.js ; return original code 'import' and 'export' may appear only with 'sourceType: "module"' (183:0) Unable to post-instrument: /home/shikhar/Desktop/mozillaPdfJs/pdf.js/src/core/arithmetic_decoder.js
And with this error, the file is not checked for coverage at all and thus returns a 0% report.

I do wonder if it would be possible to run the coverage over the source files instead of the built files.

Again, the source folder contains files which have import and export statements and therefore the above errors occur because of which the related files are not checked at all, leading to 0% coverage.
Thus, it is imperative that we test in the build folder itself.

getting coverage results from gulp browsertest as well would be almost essential to really know what our actual test-coverage looks like.

@Snuffleupagus Where do these specific tests lie ? We can try testing them directly using the jasmine-node statement mentioned above.

If it turns out to be hard, we can just do the current approach as a first version and do this in a follow-up issue.

Yep, we could rather do that.

Yes, that's a good idea. We can then start the review process and see which issues are left to address.

Sure, I'll start with that.

The PR at #9308 has shown an example of test coverage for the unit tests only. The generated reports provide little value because our set of unit tests is very small. For more details, see https://github.com/mozilla/pdf.js/pull/9308#issuecomment-353588039
So, to get browser tests, we need:

A way to generate coverage data.
A way to retrieve the coverage data (and upload it to coveralls).

To address 1), gulpfile.js should be edited to optionally add code instrumentation, which is exported to the window.__coverage__ object in a browser. gulp-istanbul might be useful. The documentation seems sparse, but I have found an example at https://stackoverflow.com/questions/38208735/no-window-coverage-object-is-created-by-istanbul-phantomjs. We do NOT use PhantomJS, but you can read the question, answer and linked blog post to deepen your understanding in how everything works.
After finishing step 1, the browser tests will have a window.__coverage__ variable (or whatever you had put in the coverageVariable configuration parameter). To get coverage reports:

Modify the test runner (https://github.com/mozilla/pdf.js/blob/e081a708c36cb2aacff7889048863723fcf23671/test/driver.js) to post the coverage result with XMLHttpRequest to the test server.
In the test server (https://github.com/mozilla/pdf.js/blob/e081a708c36cb2aacff7889048863723fcf23671/test/test.js), register a new hook to receive test results, and write that to a file using the fs Node.js API (maybe after some post-processing, such as converting it to the lcov format if needed).
Upload the report to coveralls (e.g. with the "coveralls" command as shown in #9308).

@Rob--W Thanks for such a detailed review. I'll follow up and revert back as soon as possible.

This comment offers tips for the implementation, and addresses the questions from https://github.com/mozilla/pdf.js/pull/9308#issuecomment-353710595
istanbul only adds instrumentation to code. This input is supposed to be executable code, because "instrumentation" means adding extra JavaScript code that detects when execution passes through that line, statement, etc. If the code is significantly altered again after adding the instrumentation, the resulting coverage report becomes meaningless.
This instrumentation can be done on the fly while the program is being run (e.g. when you run istanbul cover from the command-line, istanbul will intercept calls to Node.js's require and transform the code with instrumentation before the module is loaded), or separately from execution (e.g. as the blog post demonstrates: the instrumented code is generated at the command line, the execution is done in the browser).
In your current PR at #9308, you are invoking istanbul cover with jasmine as the program to run. As I mentioned before, the effect is similar to running gulp unittestcli - i.e. the tests are run against a pre-built library in the build/lib directory (this is configured in test/unit/clitests.json). This explains why your coverage report is showing 0 coverage for everything except for build/lib/ (because the only require-d (Node.js) modules are in build/lib and build/streams/ - see the end of the gulp unittestcli task definition).
To get useful coverage reports, the coverage reports are preferably at a module level. This is a step ahead: you need to integrate istanbul in the build pipeline, so that when the code is transpiled from ES6, instrumentation is added. After that, it becomes more difficult to generate per-module reports (but not impossible, in theory source maps provide enough information to map data to the original files).
This is a challenge, and requires a good understanding of how to use Babel, gulp, istanbul and source maps / modules (I already referred to the relevant places in the source code where PDF.js brings together all modules to generate the PDF.js library - see #8632). This knowledge is very useful, so if you are not afraid of challenges, you can explore this under my guidance.
But before diving in so deeply, let's start with something simpler: getting coverage reports from the browser. We have two ways of running tests in the browser, unittest and browsertest. Since we already have a rather easy way of running unit tests in Node.js, let's focus on browsertest. The browser tests do not use individual modules, but the PDF.js library created by the generic gulp target, in GENERIC_DIR, aka build/generic/. So it suffices to add code instrumentation to build/generic. I suggest to take build/generic/ as an input directory, and write the result to coverage/build/generic.
After doing that, you need to change test/test_slave.html to not unconditionally load ../build/generic/build/pdf.js in a <script> tag, but conditionally load either ../build/generic/build/pdf.js or ../coverage/build/generic/build/pdf.js depending on some configuration parameter (for testing you can just hard-code the latter URL, it is very easy to change this hard-coded parameter later after you have completed the more difficult task of sending the coverage report back to the test server).
Once you have replaced the normal pdf.js library with the instrumented pdf.js library, the coverage statistics will be generated as the test run. The result is stored in the global window.__coverage__ variable. When the in-browser test driver finishes (the _quit method in test/driver.js), you can serialize this report (e.g. using JSON.stringify(window.__coverage__) ) and send this to the server with XMLHttpRequest (see the other locations in the driver.js file for examples - make sure that you send the report to the server BEFORE sending the /tellMeToQuit message, or else the coverage report might not be transmitted correctly).
You can add a new handler for your new custom API call in https://github.com/mozilla/pdf.js/blob/ba5dbc96326518ad716158ef040f61794cc72202/test/test.js . For code examples, look at XMLHttpRequest calls in driver.js (such as the /tellMeToQuit message), and find the corresponding handler in test.js. Once you have received the serialized JSON at the server's side, use the fs.writeFileSync API to write the coverage report to a file (again there are other examples in test.js that shows how you can write files).

@Rob--W I'm currently not available till the new year ... I'll catch on for sure after that

@timvandermeij is it still active? I can give it a go as well

Yes, feel free to work on this! We should start simple; see https://github.com/mozilla/pdf.js/issues/8632#issuecomment-455868037 for a possible approach.

I would like to work on this. Is the issue still open? And where can I get a better understanding of the bug?

@jezhou was working on this and has made some progress in #11580. The PR hasn't recently been updatedt though.

Thank you so much for the update. I think I can start working on it? Where
can I get more information? About the issue and rest of it ??
On Sat, 16 May 2020, 5:56 pm Rob Wu<EMAIL_ADDRESS>wrote:

@jezhou https://github.com/jezhou was working on this and has made some
progress in #11580 https://github.com/mozilla/pdf.js/pull/11580. The PR
hasn't recently been updatedt though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/pdf.js/issues/8632#issuecomment-629637879,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUZ65CGSIZF6OMFZWENWF3RR2A77ANCNFSM4DSK7SGQ
.

I would like to work on this. Is the issue still open?


No completions for df.reset_index()

VSCode Version: 1.32.3
Extension Version: 2019.2.5558
OS: Windows 10
Python 3.7.2
LS Version: <IP_ADDRESS>
Using Conda virtual environment
Was working through this quick, easy tutorial here. Was expecting df.reset_ to at the very least yield df.reset_index(), a common operation when using Pandas. However, I got the following display:

Please provide complete code with imports.

import pandas as pd
import datetime
import pandas_datareader.data as web

start = datetime.datetime(2010, 1,1)
end = datetime.datetime.now()

df = web.DataReader("MSFT", "yahoo", start, end)

df.reset_index(inplace = True )
df.set_index("Date", inplace = True)

import matplotlib.pyplot as plt
from matplotlib import style

style.use('fivethirtyeight')

df['High'].plot()

plt.legend()
plt.show()

Did analysis actually finished? Duplication probably should be addressed by https://github.com/microsoft/python-language-server/issues/620

Yes. I reproduced the same process this morning and i only get:

Figured out my issue here as well. Was accidentally using an environment in which the pandas_datareader.data module wasn't detected.


Tests for EvaluateArgs

Completes PR#23871
Unit testing for retrieving Envoy Attributes from metadata batch and auth contex in Evaluate Args.

Thanks for the review, Mark! I made the changes.


Understanding active committer count

Somehow the last part doesn't make sense to me, shouldn't it be 30 = 40 - 10 or just 30 ?
Or are you saying with having a second repository you get charged 30 + 10 = 40 ?
But then this wouldn't align with your statement " ... 10 of those 30 developers also committed to Fabrikam and don't consume more licenses."

To simplify my question, do you get charged via unique users for all repositories in your project or do you get charged per active and unique committer per each repository? If the latter then it's going to be quite expensive.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cf1a4901-ad2d-e6d5-6d69-95d19c26e112
Version Independent ID: cf1a4901-ad2d-e6d5-6d69-95d19c26e112
Content: Billing for GitHub Advanced Security for Azure DevOps - Azure Repos
Content Source: docs/repos/security/github-advanced-security-billing.md
Service: azure-devops
Sub-service: azure-devops-integration
GitHub Login: @juliakm
Microsoft Alias: jukullam

Hi @segraef - thanks for the issue. For Advanced Security on Azure DevOps, you are charged per active committer per repository you enabled, deduplicated across your organization. Meaning, I believe this simplifies down to being charged for unique active committers across all enabled repositories.
In the above simplified example, Fabrikam has 20 active committers. In enabling AdventureWorks, a repo with 30 active committers, if we were not deduplicating you would be charged for 50 active committers. However, there is overlap between 10 of the committers in Fabrikam and AdventureWorks, so we still have the original 20 from Fabrikam and an additional 20 new, distinct active committers in AdventureWorks who have not committed at all to Fabrikam that will be billed for.
Let me know if you have other questions.


pushing hotel templates live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

templates/bing-hotel-ads-upload-template.zip
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Winloop's workflow did not Compile Sucessfully 0.1.4

I don't know how to install the vendor directory for libuv's workflow, might work on this tomorrow unless someone has already got a solution for how to do it

See: https://github.com/Vizonex/Winloop/actions/runs/9280037412

I didn't see this issue, but yesterday I managed to fix the publish workflow by adding the use of submodules, and v0.1.4 is now on PyPI.


improve trajectory reports

several things to do:

move the llm response stats up next to the ParsedModelEvent UUID
"Show More" and "Show Less" should only appear if the text is long enough to get cut off. And maybe there's something cleaner than "show more" "show less" ?
make "Model Action" events stand out more in the timeline, as these are the main things of interest

@MentatBot

@mentatbot


Sirepo-Silas app: simulate multi-crystal amplifier with BELLA Center parameters

Working with the same parameters as in Issue #22, create a simulation with the alpha version of the Sirepo-Silas app.
Document any problems for discussion with the Sirepo development team.

Depending on the width of your browser, you can see problems like this with the equation for the initial temperature:

Please verify that this equation is consistent with what is being done in the rslaser source code.
Also, please consider ways that the equation might be recast so that it doesn't have to be a rendered as a single object, regardless of page width.


Adding functionality to make test result and summary output optional

This addresses issue #16
This is an implementation of the display options in grunt-contrib-jasmine.
In short, this will allow us to define whether we want full, short, or no test reporting output. Please review at your earliest convenience, thank you.

@eduran Thanks! Other than a couple of really small things it looks good :)

Hi @parkji the fixes have been made. Can you review again at your earliest convenience? Thanks.

@eduran sorry for the delay in getting this merged. It's out in v0.8.0.


Progress indicator on remote desktop

I'm using Atom remotely using xpra. I've noticed that both network and (client) CPU usage are quite high when Julia is doing computations. My guess is that it's because of the progress animation -- when the computations are over the responsiveness of remote apps and CPU usage go back to normal. I don't think it's the server issue: it's 32-core node without other active users and only 1 Julia worker is used.
Is it possible to implement another progress indicator, e.g. RStudio-like semaphor? I don't have that kind of remote desktop responsiveness drops with RStudio.
It could also be that xpra is too eager in identifying the region to be updated, so maybe the alternative solution would be to keep the animation, but change the implementation to reduce the invalidated region.

Can you try pasting
progress.ink:indeterminate {
  animation-iteration-count: 0;
}

into your styles.less (search for Open Your Stylesheet in the command pane) and then evaling something like sleep(10)? If it is indeed that animation at fault then CPU usage should be normal with that change.

Hmm, with the frozen progress indicator I don't see CPU going back to the background levels. But there's still the pulsation of the console prompt. Is it possible to disable it through the stylesheet as well?

Sure:
ink-console .divider.loading {
  animation-iteration-count: 0;
}

ah, and there's also the spinning cogwheel for the running code block

.ink.result.julia.inline.loading .icon::before {
  animation-iteration-count: 0;
}

I've experimented with sleep(10) a bit. Enabling either console pulsing or progress indicator leads to some CPU (15% of each 4 cores) and bandwidth usage (~1Mb/s on FullHD fullscreen Atom, zlib compression).
The cog animation doesn't eat up that much of a bandwidth, but CPU is still used.

So if you disable the animations you see saner CPU/network usage? Workaround for now would be to keep the custom css, but I'll look into optimizing the animations when I find the time.


PBR issue with spotlight

https://www.babylonjs-playground.com/#11BH6Z#320

Not a bug: http://www.html5gamedevs.com/topic/34577-material-doesnt-show-when-spotlight-is-used/


This library is attempting to receive an incoming connection from Nmap!

I was testing this library and I got a notification that an incoming connection through Nmap... there is no a single case of use for an incoming connection coming from a library like this. Trojan is the best word to describe. Erasing my computer.

What? It’s a bash script. You can see all the lines? I’m confused. What are
you talking about?
On Fri, Nov 11, 2022 at 1:47 AM ndr3x @.***> wrote:

I was testing this library and I got a notification that an incoming
connection through Nmap... there is no a single case of use for an incoming
connection coming from a library like this. Trojan is the best word to
describe. Erasing my computer.
—
Reply to this email directly, view it on GitHub
https://github.com/21y4d/nmapAutomator/issues/69, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOFL3BY65RCF5KMFPKLULDWHXTWTANCNFSM6AAAAAAR5JVYSY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

As mentioned, this is an open source script so you can go through it and see what it's doing. If you think you've got a trojan, it's likely from something else.

Yeah I know is a bash script, still, the fact is that as soon as it requested to run with sudo permissions for UDP scan I got an alert of an attempt of incoming connection through Nmap. I do not mean to tell any lies, just telling what happened. Wish I took an screenshot.


Updating README with new install instructions / Error in setting up

At the time I'm viewing readme, here's the install instructions -

Given that now there are electron and react renders of the app (alongwith original java one) (idk what to call the seperate directories "imagelab_react" , "imagelab_java" and "imagelab_electron" other than seperate renders of the app) , a simple mvn clean install in project directory doesn't work. It gives the following error -

When I changed my directory to /ImageLab/imagelab_java, it gave the following error -

[Updated]

Can you also add instructions for electron and react in this same readme. Would work great as an overall installation instruction!


Search box for currency

Problem Statement

It is really hard to find country inside currency without search box
Evidence or User Insights

Proposal

When the user clicks on the drop-down menu in the top will be a seach box to fillter countries.
Goals

Non-Goals

Low-Fidelity Concept

Requested Assignment

I'm just suggesting this idea.  I don't want to implement it.

You can actually type in the country name and it will get highlighted.

You can actually type in the country name and it will get highlighted.

You are right but most regular people do not know about it.
This is why Google Translate added this same feature.


NoMethodError "super: no superclass method `log_deprecation' for ChefCompat::CopiedFromChef::Chef:Class"

Hello there,
Got the following error when trying to use the chef-docker version 2.0 cookbook (which depends on this cookbook to ensure compatibility with older chef 12 versions).
I am using chef 12.4.3 (x64), running on Ubuntu 14.04 virtual machine in test kitchen.
         NoMethodError
         -------------
       super: no superclass method `log_deprecation' for ChefCompat::CopiedFromChef::Chef:Class

         Cookbook Trace:
         ---------------
           /tmp/vagrant-cache/chef/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef.rb:20:in `log_deprecation'
         /tmp/vagrant-cache/chef/cookbooks/compat_resource/files/lib/chef_compat/copied_from_chef/chef/property.rb:258:in `call'
           /tmp/vagrant-cache/chef/cookbooks/compat_resource/files/lib/chef_compat/copied_from_chef/chef/property.rb:455:in `username'
           /tmp/vagrant-cache/chef/cookbooks/pm_docker_test/recipes/default.rb:5:in `block in from_file'
           /tmp/vagrant-cache/chef/cookbooks/pm_docker_test/recipes/default.rb:4:in `from_file'

Thank you very much

Running into this as well on vm with 12.3.0 on Ubuntu 14.04

hitting this as well... caused random build failures starting today.

im joining into the line - only under test-kitchen.

I, [2015-10-29T15:24:43.430218 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  10:            chef_compat_gem_path = File.expand_path("../../..", __FILE__)
I, [2015-10-29T15:24:43.430396 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  11:            chef_gem_path = File.expand_path("../..",::Chef::Resource.instance_method(:initialize).source_location[0])
I, [2015-10-29T15:24:43.430568 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  12:            caller(0..10).each do |c|
I, [2015-10-29T15:24:43.430687 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  13:              if !c.start_with?(chef_gem_path) && !c.start_with?(chef_compat_gem_path)
I, [2015-10-29T15:24:43.430719 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  14:                location = c
I, [2015-10-29T15:24:43.430836 #23718]  INFO -- thumbnailapi-ec2-ubuntu-1404:  15:                break

:+1:

Just ran into the exact same error @danielsand listed during a chef-client run on a CentOS 6.5 node, but was coming from ark. Oddly, I wasn't seeing this error about an hour ago.

Fixed by #13 (and released).

Thank you very much @jkeiser :)

closing this since we no longer have this bug but have #15 instead...


update pyca/cryptography submodule

Investigating a fix for #6527

Add "[extended tests]" in a line on its own in the commit message, and all travis tests will be run.

Thanks matt, I'll push an empty commit with that now

Three travis builds fail. Only the first one is interesting from a pyca perspective. The other two build failures are due to the problem fixed in #6529.

@mattcaswell, please make this part of master before pre8 release

Pushed. Thanks.