Not functional on Wayland

attempting to compile a project with this crate on wayland returns the error
Perhaps you should add the directory containing `x11.pc' to the PKG_CONFIG_PATH environment variable
Package 'x11', required by 'virtual:world', not found```

So this library does not support Wayland due to its security policy preventing us from querying global keyboard state. If you install the X11 libraries, you'll be able to get the global keyboard state from programs running under X11 only.


Class 'PHPExcel_Shared_Font' not found

Versions
"php": ">=7.1.0",
"laravel/framework": "5.6.*",
"maatwebsite/excel": "~3.0.5"
while doing composer install as well as while doing composer update
Error
In excel.php line 182:
Class 'PHPExcel_Shared_Font' not found
Script @php artisan package:discover handling the post-autoload-dump event returned with error code 1

@ds-manish did you upgrade from 2.1? You'll have to delete your config/excel.php and re-publish it. As the version 2.1 config uses PHPExcel classes instead of PhpSpreadsheet.

@patrickbrouwers Its working! Thank you!

Thank you. Now, I have this return:
There are no commands defined in the "iseed" namespace.

Thank you, solved my problem.

@famarojr
From installation:
php artisan vendor:publish --provider=Maatwebsite\Excel\ExcelServiceProvider

after using this command getting Class 'Arrilot\Widgets\ServiceProvider' not found this error.

after using this command getting Class 'Arrilot\Widgets\ServiceProvider' not found this error.

Doesn't sound related to Laravel-Excel in my opinion.

None of the options are working to me.
I have a clear laravel installation, and when I try to access I get the error Class 'PHPExcel_Shared_Font' not found

None of the options are working to me.
I have a clear laravel installation, and when I try to access I get the error Class 'PHPExcel_Shared_Font' not found

Could you please share your versions of PHP, Laravel and Laravel Excel? Thanks!

@famarojr
From installation:
php artisan vendor:publish --provider=Maatwebsite\Excel\ExcelServiceProvider

Thank you for this suggestion, everything working now.

If anyone is getting the error
Unable to locate publishable resources.
you need to put quotation marks in provider:
php artisan vendor:publish --provider="Maatwebsite\Excel\ExcelServiceProvider"


Command line script using this API

Hi,
You could be interested of this script, deepl.py, that I just wrote: it uses your API to translate a line of text given from the command line or a small text file. Examples:

Maybe you would like to include it (feel free to modify as you wish) or add something like this in your project.
It could be good if the pydeepl module was actually executable, so
python -m pydeepl

would behave like my script?

I'll check It this week asap.
El 11 dic. 2017 4:54 p. m., Lilian Besson<EMAIL_ADDRESS>escribió:
Hi,
You could be interested of this script, deepl.pyhttps://bitbucket.org/lbesson/bin/src/master/deepl.py, that I just wrote: it uses your API to translate a line of text given from the command line or a small text file. Examples:
[test deepl py]https://user-images.githubusercontent.com/11994719/33839978-eeb229fc-de93-11e7-9e98-45c65ac4c984.png
Maybe you would like to include it (feel free to modify as you wish) or add something like this in your project.
It could be good if the pydeepl module was actually executable, so
python -m pydeepl
would behave like my script?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/EmilioK97/pydeepl/issues/3, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMrOiO-bRNUa1zG9leDM3QfVZds1n__zks5s_VBHgaJpZM4Q9nMX.

@EmilioK97 interesting in merging my script into your project?
It could be easy to add a flag in the install process of your setup.py, to let any one who installs pydeepl benefit from a cli client?

I'll check it again. I was so busy I forgot about it at all. I added it to my todo list. Sorry for the no reply.

No problem, we're all so busy I understand!

Commit: e11c5a5f9f4da5ab387f70a2f12c2e731fbfbef8

Hi @EmilioK97, great!
I am curious about one detail: so far my script is hard-coded to do French-English by default, but it's a very specific choice for my usage.
Could we use at LANG or LANGUAGE (environment variable) or other indicators of the user's language, to automatically set the default translation target?

It can be done in case you no specify the target language. I have no time right now, maybe later this week. If you want to implement it feel free to make a pull request.

I'm running out of time too sorry!


ContinueNormal - replace fillbiome with normal generation

Instead of using just a single fillBiome, ContinueNormal now inserts normal generation into holes in a fromImage map.
The -1 value in the biomeMap is only assigned and only looked for in ContinueNormal mode. The -1 value is used because it doesn't interfere with the biome ID's. I originally tried using the ID of the fillBiome, but that made the fillBiome not spawn when painted in. It feels a bit like a bodge, but I couldn't think of a smarter way to do it, and I also haven't found any possible side effects from it.
I've been testing this with a modified Vanilla Vistas running in FromImage mode, and I haven't found any issues. It's a bit quirky to use because you can't predict what biomes will spawn, but it's definitely possible to get used to.

Hey @authvin , that sounds awesome! I don't use FromImageMode much myself atm, could you make a jar via /gradle build + /gradle createreleasejar, change the version number in the build.gradle, and throw it on the OTG dev discord for testing? @NLBlackEagle should test this, he's the author of Dregora, the biggest FromImage preset.

made a build:
OpenTerrainGenerator-1.12.2- v8.3_ContinueNormal_v1.zip

Tested the function and works perfectly! I see forward to this being merged with the base branch!!!

Sweet, thanks for submitting and thanks for testing guys, merging :)


Unexpected behaviour of reset method on Android

It seems that the reset method of the library doesn't really resets the state of ReceiveSharingIntent.getInitialMedia(). So each time I navigate to my loading screen I re-execute this action obtaining an old recycled value instead of getting a null value

I just tested this and its working for me.

I called the reset method in my loading screen in this way:
    final sharedFiles = await ReceiveSharingIntent.getInitialMedia();
    if (sharedFiles.isNotEmpty) {
      ReceiveSharingIntent.reset(); // prevent recycling of the same files
      debugPrint("Received ${sharedFiles.length} files");
      await FileShareUtils.handleSharedFiles(sharedFiles, router);
    }

It usually works fine but there is a case where it doesn't seem to be as expected. With the app closed I went to the image gallery and choosed one or more images and shared them to the app. This opened successfully the app with the desired images. Then I swiped from the left (I have a Pixel phone) to exit from the app putting it in background state. When I recovered the app from the opened tabs the app reloaded the loading screen that contains the provided lines of code and it resulted that the old images were recycled unexpectedly.
Can you check this case?
Thanks


Should numpy_array_api_compat installable?

For testing, I added a pyproject.toml to this repo so I can install it and import it. I can see libraries vendoring this library, but I think it would be nice to have the option to install it as well.
Should numpy_array_api_compat install-able?

Yes, I plan to make it installable. I was hoping for feedback first before I did a release, but I can see that making it at least basically installable will help with the release as well. I also think we might want to rename it before doing so. For one thing, we will likely support more than just NumPy (#3), and also the name is a little too long IMO. Maybe just array_api_compat?

There's also the question of how to do the versioning https://github.com/data-apis/numpy-array-api-compat/issues/2.

It's released on PyPI now. I still need to add it to conda-forge.


cross-platform: x86 support

ChakraCore compiles to x86 target

Add xplat x86 Support [not tested - linker problems - see below]
Improvements to existing amd64 implementation
This PR needs 'ICU/etc static linkage' support for linker pass
Additional work will be needed on posix (At the moment, the main focus for this x86 PR is iOS simulator / Android targets)

Important: Unless otherwise specified, x86 is not officially supported.

At the moment, this PR is capable of running javascript on x86 arch / unix. There are couple of missing parts (i.e. function call  stack failures)
Since this is not an official support and this work is beyond compiling step now; (also the improvements to 64 bit side)
@digitalinfinity @jianchun how about merging this work as is (apart from the review issues) and handling the rest in smaller iterations ?

:shipit:

@digitalinfinity @curtisman Thanks for the review


Using custom scalar adapters in Java code

Hello! I'm trying to use a OffsetDateTime scalar provider in my Java project. The scalar type name is DateTime.
Here's a snippet from my build.gradle:
plugins {
    // skipped
    id 'com.apollographql.apollo3' version '3.3.2'
}

dependencies {
    // skipped

    implementation("com.apollographql.apollo3:apollo-runtime:3.3.2")
    implementation("com.apollographql.apollo3:apollo-rx3-support:3.3.2")
    implementation("com.apollographql.apollo3:apollo-adapters:3.3.2")
}

apollo {
    packageName.set("my.app.graphql")
    mapScalar("DateTime", "java.time.OffsetDateTime", "com.apollographql.apollo3.adapter.JavaOffsetDateTimeAdapter")
}

I have a GraphQL type with date/time fields:
type MyType {
  fieldA: DateTime
  fieldb: DateTime
}

and a corresponging GetMyType query that returns an instance of this type.
The generated GetMyTypeQuery_ResponseAdapter.java file contains the following code:
      loop:
      while(true) {
        switch (reader.selectName(RESPONSE_NAMES)) {
          case 0: _fieldA = com.apollographql.apollo3.adapter.JavaOffsetDateTimeAdapter.fromJson(reader, customScalarAdapters); break;
          case 1: _fieldB = com.apollographql.apollo3.adapter.JavaOffsetDateTimeAdapter.fromJson(reader, customScalarAdapters); break;
          default: break loop;
        }
      }

This code produces the following compiler error:
 non-static method fromJson(JsonReader,CustomScalarAdapters) cannot be referenced from a static context

Hi 👋
Due to the way Kotlin interops with Java, you'll most probably need to use JavaOffsetDateTimeAdapter.INSTANCE:
mapScalar("DateTime", "java.time.OffsetDateTime", "com.apollographql.apollo3.adapter.JavaOffsetDateTimeAdapter.INSTANCE")

Let us know how that works

Thank you, this did the trick!


Dino Catalog - Iteration 1

On the whole, this is a good first draft.
My biggest overarching concern is flexibility. While this approach will get the immediate job done, it makes a lot of assumptions that will make it more difficult to expand or update in the future.
As you work on the next iteration, think about what you'd have to do to use multiple sources (4 or 5 CSVs) or to be able to parse lists of dinos stored in an alternative format (JSON or XML instead of CSV).  Think about what would be involved in adding support for additional fields or dealing with a source that's missing one or more fields.

@locker1776 Please take a look at Deja's comments and submit a second iteration. Nice work!


Add legacy Icon name deprecation warning

Should address #187.

Codecov Report

Merging #188 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #188   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          33     33
  Lines         400    405    +5
=====================================
+ Hits          400    405    +5

Impacted Files
Coverage Δ

src/Icon.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 559b648...7227322. Read the comment docs.

BTW, using the word fixes before the issue number (rather than addresses) will close the issue once this is merged in. See https://help.github.com/articles/closing-issues-using-keywords/


Making Windows compatible

Without this change, hitting the root drive (whatever letter) would case a RangeError: Maximum call stack size exceeded

@robertobasile84 Thanks for finding this! Left some minor style comments but can get this merged in once those are updated

The last solution shown in this stackoverflow post https://stackoverflow.com/a/68977855/816620 is a bit more elegant and would also handle Windows UNC paths (paths that start with \) or paths that don't contain a drive letter, but start with .  That might be better than the regex.


Removing Goatcounter from the list

I am using Goatcounter for my website because it is a privacy respecting and open source tracking application but I noticed that my own laptop blocked them because I use your list and the link is in it. The specific link is gc.zgo.at. I understand that Goatcounter is technically tracking software but it enables me as a website owner to know how many people visit my website while still completely respecting the users privacy. As such, I would not classify it under a "shady host".

As a side-note, I consider stats.kde.org and stats.nextcloud.com to also be acceptable, but that is pretty subjective


Updated broken links in fancyzones.md

Summary of the Pull Request
Fair warning, the links to these files are assumed to be the same files. It seems the directories were changed but the links were not updated. There were several broken links to files in here. There are still 6 links to files that I could not find.
PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[x] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
It seems the links hadn't been updated since the fancyzones/lib and fancyzones/editor directories were changed to fancyzones/FancyZonesLib and fancyzones/editor/FancyZonesEditor. I updated the path to include the new directories. I could not find updated links for ZoneSet.cpp, Properties\AssemblyInfo.cs, EditorOverlay.xaml.cs, RowColInfo.cs, Models\Settings.cs, WindowLayout.xaml.cs.
Validation Steps Performed
I checked the links to ensure they were working. I was not able to confirm that the files linked were the correct files to link.

@microsoft-github-policy-service agree

@crutkas @SeraphimaZykova what's the purpose of this file anyways? :)

@crutkas @SeraphimaZykova what's the purpose of this file anyways? :)

I guess that's some old attempt at documenting what the purpose of each file is? 😅


Clears tsm files when replace fails

Closes #14058
When compaction fails, instead of simply printing error message, clear tmp.tsm files so we can try again

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

alchemy please merge


Modal can't be closed

After a new install of the module you get an model with important information, this modal can't be closed with the button Done With the ESC key the modal will be closed.

Environment
PHP 7.3, Magento 2.4.0, Buckaroo 1.26 prelease.

@erwinromkes Thank you for the information. We cannot reproduce this at our own testing environment. Did you indeed do a complete new install or did you do a upgrade from a older version of our plugin?

It happen on a complete new Magento 2.4.0 installation with the 1.26 release.

Im facing the same issue.
I have upgraded magento version (2.2.9 > 2.4.0) and upgraded buckaroo payment (1.15.2 > 1.26.0) cant close the modal notification.
already asked buckaroo support, and the answer is to follow installation note :

IMPORTANT NOTE: if you update from v1.14.1 or lower to v1.15.2 then you need to take specific actions instead :
composer require buckaroo/magento2:1.15.2
composer remove tig/buckaroo
php bin/magento setup:upgrade
IMPORTANT NOTE: if you update from v1.14.1 or lower to v1.16.0 or higher then you need to take specific actions instead :
php bin/magento module:disable TIG_Buckaroo
composer remove tig/buckaroo
composer require buckaroo/magento2
php bin/magento module:enable Buckaroo_Magento2
php bin/magento setup:upgrade

but it still didn't solve my problem, even though i followed the advice.
and now I just got rid of it by hard coded the extension changing autoOpen option to false

vendor/buckaroo/magento2/view/adminhtml/ui_component/buckaroo_release_notification.xml
around line 69
false

*this is not the proper way to fix, I just want to remove notification modal

Thank you @erwinromkes and @eshaudigital for the extra information. We will research this in our next sprint.

Changes are made to our code, will be released soon.

Published in latest release 1.28.0.


stty standard input inappropriate ioctl for device

I simply try this example from the wiki
[module/vpn]
type = custom/script
exec = echo vpn
exec-if = pgrep -x openvpn
interval = 5
format-underline = #268bd2
format-prefix = "🖧 "
format-prefix-foreground = #5b

(openvpn is running) i can also try only echo without exec-if always the same error
but also any other custom script fails with the message:
stty standard input inappropriate ioctl for device

okay 2 hours later ...
i changed my login shell with chsh from zsh to bash and now it works ...

I'm using zsh myself and I have no issues with it.
Do you have any stty commands in .zshrc? Anyway, I wouldn't say this is an issue with polybar.

hmm but non-interactive shells (zsh running a single command) shouldnt load .zshrc as far as i know, otherwise a non-interactive shell would also load left and right prompts, auto completion ... and many more stuff that isnt needed.
Maybe you should check if polybar use a interactive shell for custom command execution.

Yeah but child processes inherit the environment. The commands are executed using $SHELL -c <command>

okay thx, maybe you could even force sh, so instead of $SHELL -c using /bin/sh -c. Every sensible environment has /bin/sh (even when its a symlink). I dont think that you have to support every shell on the planet : )

SHELL=/bin/sh polybar ... would give you the same behavior. Just use a wrapper to avoid having to type it out.

Jup, but no wrapper needed with conkys solution: https://github.com/brndnmtthws/conky/blob/master/src/exec.cc#L98
This also avoids other confusing default shell related errors in the future for other users.

Yeah but I said earlier, use it for now. A fix won't be available until I get some free time.

yes sir : ) however polybar is the best bar i used so far!


Add second location for testing DfcEvReturnTrip

Now the DfcEvReturnTrip will show if the BLE mode is E_CAR and the end location is inside either of these two boxes.
Also, since these surveys are read in order and the matched survey is the first one whose condition matches, we can treat this like an if / else if block. I reordered DfcEvReturnTrip before DfcEvRoamingTrip so we don't have to specifically say !pointIsWithinBounds(...) on DfcEvRoamingTrip, making these conditions slightly less verbose.

Merged, please remind existing users to refresh the config.


feat: use code-client-go to create and extend bundle [IDE-175]

Description
Starts using the code-client-go library for uploading and analyzing Snyk Code files with ignores. Updates to the latest code-client-go as a result and includes the bundle creation/extension of the files in the workspace.
Tested in IntelliJ by running make build-debug in snyk-ls and make build in the CLI , then changing the path to the CLI in IntelliJ. I enabled the snykCodeConsistentIgnores feature flag and the snyk.preview.snyk.code.ls.enabled registry flag, then opened IntelliJ on https://github.com/snyk/target-service
Also added smoke tests but even though I haven't added the new SNYK_TOKEN_CONSISTENT_IGNORES snyk token for testing, they pass. I'm not sure why, maybe the tests don't run on the branch after all?
Checklist

[x] Tests added and all succeed
[x] Linted
[ ] README.md updated, if user-facing
[ ] License file updated, if new 3rd-party dependency is introduced

🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm not sure why, maybe the tests don't run on the branch after all?

@teodora-sandu you can run manually the Instance Test workflow for your branch. Go to https://github.com/snyk/snyk-ls/actions/workflows/instance-tests.yaml and select your branch in the dropdown I hope it helps :)


Add alias method

Added in the alias method.

Closed because it's already a PR. Sorry!
https://github.com/smore-inc/react-native-segment-io-analytics/pull/24


ARROW:6162: [C++][Gandiva] Do not truncate string in castVARCHAR_utf8 if output length is zero

Do not truncate string if length parameter is 0 in castVARCHAR_utf8_int64 function.

Thanks @pprudhvi

Codecov Report

Merging #5040 into master will increase coverage by 1.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5040      +/-   ##
==========================================
+ Coverage   87.57%   89.19%   +1.61%
==========================================
  Files        1008      727     -281
  Lines      143765   102954   -40811
  Branches     1418        0    -1418
==========================================
- Hits       125909    91829   -34080
+ Misses      17494    11125    -6369
+ Partials      362        0     -362

Impacted Files
Coverage Δ

cpp/src/gandiva/precompiled/string_ops.cc
65.51% <100%> (+5.51%)
:arrow_up:

cpp/src/gandiva/precompiled/string_ops_test.cc
99.04% <100%> (+0.14%)
:arrow_up:

go/arrow/ipc/writer.go

js/src/util/fn.ts

go/arrow/memory/memory_avx2_amd64.go

rust/datafusion/src/execution/filter.rs

rust/arrow/src/csv/writer.rs

rust/datafusion/src/bin/main.rs

go/arrow/ipc/file_reader.go

js/src/builder/index.ts

... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f5e92...05b35c4. Read the comment docs.

@pprudhvi looks like some conflict, can you please rebase..will merge post that.


[Bug] pipeline.stream_infer无法支持openai format history（text+image),也无法支持sess用法

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[ ] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug
由于需要使用多模态模型对话，且流式输出，采用了pipeline.stream_infer接口，但是无法支持类似chat里面的sess history，pipeline.stream_infer的文档也没有，只有一个简单的demo，只能查找源码发现pipeline.stream_infer输入prompts支持string prompt, a list of string prompts,a chat history in OpenAI format or a list of chat history，采用a chat history in OpenAI format输入，text+image，会报错
Reproduction
prompts = [
{
'role': 'user',
'content': [
{'type': 'text', 'text': 'describe this image'},
{'type': 'image_url', 'image_url': {'url': 'https://raw.githubusercontent.com/open-mmlab/mmdeploy/main/tests/data/tiger.jpeg'}}
]
}
]
for response_part in generate_response([prompts]):
yield response_part
File "/root/miniconda3/envs/cup/lib/python3.8/threading.py", line 932, in _bootstrap_inner
self.run()
File "/root/miniconda3/envs/cup/lib/python3.8/threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/serve/async_engine.py", line 495, in
proc = Thread(target=lambda: loop.run_until_complete(gather()))
File "/root/miniconda3/envs/cup/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/serve/async_engine.py", line 490, in gather
await asyncio.gather(
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/serve/async_engine.py", line 483, in _inner_call
async for out in generator:
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/serve/async_engine.py", line 571, in generate
prompt_input = await self._get_prompt_input(prompt,
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/serve/vl_async_engine.py", line 55, in _get_prompt_input
decorated = self.vl_prompt_template.messages2prompt(
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/vl/templates.py", line 139, in messages2prompt
new_messages = self.convert_messages(messages, sequence_start)
File "/root/miniconda3/envs/cup/lib/python3.8/site-packages/lmdeploy/vl/templates.py", line 121, in convert_messages
if item['type'] == 'image_url':
Environment
sys.platform: linux
Python: 3.8.19 (default, Mar 20 2024, 19:58:24) [GCC 11.2.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0: NVIDIA A100-PCIE-40GB
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.1, V12.1.105
GCC: gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
PyTorch: 2.2.2+cu121
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 12.1
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.9.2
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=12.1, CUDNN_VERSION=8.9.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,

TorchVision: 0.17.2+cu121
LMDeploy: 0.5.1+
transformers: 4.37.2
gradio: 4.36.0
fastapi: 0.111.1
pydantic: 2.8.2
triton: 2.2.0
NVIDIA Topology:
        GPU0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      0-79    0-1             N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks
采用internvl2-2b模型

Error traceback
No response

设计的时候，没有考虑 stream_infer with session 的用法

设计的时候，没有考虑 stream_infer with session 的用法

但是如果想stream_infer能够多模态历史对话，采用openai-prompt也会出错


DateTimePickerModal causes issues with Backhandler

If I have a DateTimePickerModal in my component, then registering a BackHandler listener will no longer work. eg. if I have:
componentDidMount() {
    BackHandler.addEventListener('hardwareBackPress', this.handleBackButton);
}

as well as a DateTimePickerModal in the component – then handleBackButton never gets called.

👋 @DChiuch , please follow the issue template before submitting a new issue.
From a first glance I'm not sure what is happening btw, we're not overriding the BackHandler in this component.


Moved connect to start

This helps me to avoid the proxy = None issue

Are you sure this is working? By doing self.proxy = self.connect() you assign the return-value of self.connect() to self.proxy. The thing is: self.connect() does not return anything. So instead of False, the proxies of the devices should be None with your code.
You are correct in the assuption, that establishing the connection has to be done in ini. But to make it more easy I'd rather just put the whole initialization into ini.
I'll try that out to see if it works.


Bug in flag_ch_bridge ?

If I make a simulated eeg file (with a healthy amount of random noise) -
and make channels 19 and 20 duplicates of each other.
And confirm that they are perfectly correlated.
flag_ch_bridge will not flag these channels - but WILL flag some other channels.
.
I think this warrants diagram and code review to confirm that the code is behaving as our diagrams say it should.

Note to self: maybe I am making a false assumption that these channels (19 and 20) are adjacent.
Check montage.

yep... Looks like 19 and 20 aren't "nearest neighbors" after all - my mistake :sweat_smile:

I'll close this soon.


preamble_base.tex indented with both spaces and tabs

Causes the comments to not be aligned :-(
For instance, line 61 in preamble_base.tex uses spaces while line 62 uses tabs.

Oh yes 👍


raw_state.csv

The energy_py environments all used time series data loaded from csv - most commonly state.csv & observation.csv.
The idea is that these are supplied by the user for their own experiments - either by supplying state.csv & observation.csv themselves, or by providing a raw_state.csv which is then process into state.csv & observation.csv using a function.
Suggest removing raw_state.csv and if the user supplies nothing, generate a fixed electricity price profile for the env to use.

Removed ability to create state & observation from raw_state.csv.  User must now supply a state & observation.csv


Update bug report issue template to no longer reference "nightly" builds

Summary
The bug report issue template currently references the following:

[ ] 10.0.0 nightly build
[ ] 9.4.1 nightly build
[ ] 9.4.0 latest supported release

It needs to be updated to no longer use the phrase "nightly build".  This is confusing and misleading since builds are generated for every new pull request or manually triggered build.  I am proposing using the term "non-release build" instead.

Alpha maybe?

Wikipedia defines alpha as:
Alpha software is software that is not thoroughly tested by the developer before it is released to customers. Alpha software may contain serious errors, and any resulting instability could cause crashes or data loss.[2] Alpha software may not contain all of the features that are planned for the final version.

I would support the use of Alpha, as it is more absolute in naming rather than non-release

Thanks @valadas and @mitchelsellers - I agree and will update the PR accordingly.

@david-poindexter For ease of builds, and review, please do these as single PR's in the future

My apologies @mitchelsellers - due to computer issues at the time, I had to do these on a device that made this impossible for me.


A11y_SQLAzureDataStudio_ExportBacpac_ExportBacpacSettings_ScreenReader: The required combo-box is not announced as required

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11y_SQLAzureDataStudioBenchmark;#A11yMAS;#A11ySev2;#A11yTCS;#SQL Azure Data Studio;#Benchmark;#DesktopApp;#MacOs;#MAS1.3.1;#VoiceOver;#MAS3.3.2;
Environment Details:
Application Name: Azure Data Studio
Version: 1.15.0-insider
Commit: 3a8b74a
Date: 2020-02-11T05:49:41.181Z
VS Code: 1.42.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
Mac OS:10.15.3
Additional Details:
Screen reader: Voiceover
Mac OS:10.15.3
MAS References:MAS1.3.1, MAS3.3.2
Repro Steps:

Launch Azure Data Studio application.
Connect to server with windows credentials.
Navigate to Extensions from left menu.
Search & install Dacpac extension.
Navigate to Connections from left menu.
Expand the server connected in step 2.
Right click an on prem database and select Data-tier application wizard from Context menu.
Select forth radio button.
Navigate till next button & hit enter.
Launch Voiceover and tab to the first combo-box.

Actual:
On navigating to the first combo-box "source server" the screen reader does not announce it as required which is visually seen on screen.
Similarly for "source database"
Similar issue is the following page:
1.Import Bacpac Settings
Expected:
When navigated to the combo-box with tab key the name of the combo-box the item name, as well as the instruction as required, must be announced.
User Impact:
Screen readers users will not know that field is required.
Attachment link for Reference :
A11y_SQLAzureDataStudio_ExportBacpac_ExportBacpacSettings_ScreenReader9261.zip

Duplicate of #9183. Fixed by #9200

Verified the bug and does not repro.
GithubTags:#Closed;
PFA for reference
9261_Closed.zip

GitHubTags:#SQLADS-MAC-Feb2020;


Feature: Prompt Library

Summary
A library of prompts by the LibreChat team + the ability to add your own prompts to share with other users of your app.
This is different from presets as presets are on a per-user basis and can be edited. You could however save a library item as a preset.
How to use
I have written up a new docs page for this. See it here.
Screenshot

Changes

Adds a folder for prompt files in json format
Adds folder for users who want their own custom prompts
Adds button to EndpointMenu
Minor code cleanup for unused classes
Prep work for meilisearch
Confirmed styling in light & dark mode

Testing
I have performed various tests in my local & prod environment to ensure this works. I would love to create a unit test but I'm not sure I've done it with a component nested in a popup like this. I would rather change this to a whole page so unless anyone has any gripes with it, I'd rather hold off writing a test until we create page templates and have this as an actual page rather than popup.
Future Work (out of scope)
I added backend code to index all prompts to meilisearch. However I won't be finishing it in this PR is because I want to modify templates and even fix up the existing convo search to use instantsearch too. This seems a little time intensive + there is scope creep with it affecting more areas as we need to fix up the conversation search too so that it can have infinite scroll and a better search bar or filters.
The search I have made for this works pretty well as is, however we may notice performance issues if the number of prompts get to the thousands (I don't expect this to happen quickly)
Also we likely need to rethink the prompt window. Currently we can't change AI providers and we need to refactor things to get this working well.
Checklist

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[x] I have commented in any complex areas of my code
[x] I have made pertinent documentation changes
[x] My changes do not introduce new warnings
[ ] I have written tests demonstrating that my changes are effective or that my feature works
[x] Local unit tests pass with my changes

Note: failed unit tests look unrelated. Seems they pass occasionally, must be a problem elsewhere?

Note: failed unit tests look unrelated. Seems they pass occasionally, must be a problem elsewhere?

are you able to run them locally? npm run test:api and npm run test:client
I think one of the errors said package-lock is out of sync, but if they are intermittent (i see one passing now) could be an npm outage, I had issues with this in the past

Think that was the meilisearch being weird. Commented out and we can come back to it with a bigger search update. Tests passing now :)

Think that was the meilisearch being weird. Commented out and we can come back to it with a bigger search update. Tests passing now :)

for this i found out the root issue and was solved by mocking meilisearch module in a specific test file

Think that was the meilisearch being weird. Commented out and we can come back to it with a bigger search update. Tests passing now :)

for this i found out the root issue and was solved by mocking meilisearch module in a specific test file

@danny-avila awesome, should be an easy fix when I come back to the meilisearch and we end up using it. Definitely for the next PR on it tho.
Lmk if there is anything else to get this over the line, otherwise from my view it should definitely be enough for a quick first version

Trying it out now, I can resolve the package-lock conflict for you if you give me contributor access to your fork.
Otherwise, you can try running the rebuild:package-lock script after you try rebasing/merging.
I tried running this on a clean install, and it would crash on opening the EndpointMenu
Steps to reproduce:
fresh install by cloning down the repo, running installation, then:
# this would not work for me
# git clone git@github.com:ClaraLeigh/PromptLibrary.git prompts/General-Library

git clone https://github.com/ClaraLeigh/PromptLibrary.git prompts/General-Library

Run the app, hit endpoint menu to choose endpoint, then server crashes:
# server logs
There was an uncaught error:
TypeError: Cannot read properties of undefined (reading 'includes')
    at getTagsFromFilename (mydir\api\lib\utils\PromptLibrary.js:30:16)
    at mydir\api\lib\utils\PromptLibrary.js:54:13
    at Array.forEach (<anonymous>)
    at collatePromptLibrary (mydir\api\lib\utils\PromptLibrary.js:45:9)
    at mydir\api\server\routes\promptLibrary.js:8:31
    at Layer.handle [as handle_request] (mydir\node_modules\express\lib\router\layer.js:95:5)
    at next (mydir\node_modules\express\lib\router\route.js:144:13)
    at complete (mydir\node_modules\passport\lib\middleware\authenticate.js:271:13)
    at mydir\node_modules\passport\lib\middleware\authenticate.js:278:15
    at pass (mydir\node_modules\passport\lib\authenticator.js:428:14)
Clearing sync timeouts before exiting...

All prompts are under prompts\General-Library
# prompts/General-Library
    |___/Advanced
    |___/Awesome
    |___/Coding
    |___.gitignore
# ...etc

Also cleared cookies/localStorage and was able to reproduce

I can reproduce this issue, aswell

@danny-avila windows? Might be a backslash thing. I'll see if I can test it somewhere

yup I am on windows, that could be it. maybe use path.resolve for os-agnostic solution

Easy, I should have some time this weekend to finish it off then

@ClaraLeigh Any updates on this P.R?

@ClaraLeigh Any updates on this P.R?

I think I have a more upto date branch somewhere but it works expect on windows. I use it on my version.
Still haven't had time of late to update for windows. Currently focused on some paid work atm that's taking all of my free time

I think this is basically what I mean here: https://github.com/danny-avila/LibreChat/issues/1016 as well

This looks great and the Tree of Thoughts prompt output blew my mind :)
Question: when importing the prompt definitions, I kept needing to change the endpoint and model to work with my configuration (Azure and GPT-4), because most of the definitions are for openAI and gpt-3.5-turbo. Is the plan perhaps that these fields will be optional and if empty, when you select the prompt it will continue to use the currently selected endpoint?

Looks like something I was looking for but the code is not compatible with latest update. any plan on updating this feature?

Though I closed this PR, prompt features are on the roadmap. Possibly next month if stretch goals are met. Things may accelerate if I can work on this project full-time.

I will look forward to update on prompt features, although I don't see any other planned features looking as good as this :)

Glad to here this is still on the roadmap. This was one of my favorite features I was looking forward to

Agreed, this feature would be really helpful!


Extension stop " debug-auto-launch"

Extension Name: debug-auto-launch
Extension Version: 1.0.0
OS Version: Windows_NT x64 10.0.14393
VSCode version: 1.28.0-insider

We have written the needed data into your clipboard. Please paste:
{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 24,
		"activateCallTime": 1,
		"activateResolvedTime": 0,
		"activationEvent": "*"
	}
}

Does this happen every time you open VSCode, or only for certain projects? Can you describe in more detail the behavior you see?


[stable/cloudhealth-collector] Use correct secretKeyRef.key for API Token secret

Description

If a user installs this chart and sets the api_token value, the cloudhealth-colllector pod will fail to start due to the deployment config using the wrong secret key:
https://github.com/deliveryhero/helm-charts/blob/master/stable/cloudhealth-collector/templates/deployment.yaml#L50
https://github.com/deliveryhero/helm-charts/blob/master/stable/cloudhealth-collector/templates/secret.yaml#L10

Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[x] I have read the contribution instructions, bumped chart version and regenerated the docs
[ ] Github actions are passing

Hi @jacobboykin 👋
Since the real environment variable that is used by Cloudhealth is called CHT_API_TOKEN, how about we rename all references to api_token? I think this would be more logical and consistent, right?
Also, you need to bump the chart version and update the chart readme from the templates 🙂


Support Zeebe 1.0.0

Zeebe 1.0.0 is coming out, with a breaking API change. Work is in progress in the 1.0.0 branch.
See here for more details.

Hey Josh, I'd like to support you with 1.0.0 release. How can I help?

New version out to support the latest alpha of Zeebe: https://www.npmjs.com/package/zeebe-node/v/1.0.0-alpha.7


ts-jest throws TypeError: Cannot read property 'version' of undefined

Current Behavior

npm run test fails to run with the error: "TypeError: Cannot read property 'version' of undefined"
npm run build, npm run lint and tsc --noemit run without errors.

This issue started happening randomly while I was working on some changes. I can't think of anything special that my project is doing, except that I have a linked dependency. Besides this project, I have other TSDX projects that are working fine.
Expected behavior
npm run test should work.
Suggested solution(s)
I haven't been able to solve this myself. This ts-jest issue (https://github.com/kulshekhar/ts-jest/issues/1639) indicates a major version update is required.
Additional context
🤷♂
Your environment

  System:
    OS: Windows 10 10.0.19041
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
    Memory: 7.06 GB / 15.85 GB
  Binaries:
    Node: 10.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 86.0.4240.75
    Edge: Spartan (44.19041.423.0), Chromium (86.0.622.43)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    tsdx: ^0.14.1 => 0.14.1
    typescript: ^3.9.7 => 3.9.7

A workaround is suggested here: https://github.com/kulshekhar/ts-jest/issues/1645#issuecomment-712286584
I ended up doing this:

Turned on isolated modules.
Updated test script in the package.json file to tsdx test --no-cache.

Yea, unfortunately since it's a breaking change upstream, TSDX can't update until its own breaking change. Jest 26 is slated for v0.16.0 since it requires a similarly breaking TS upgrade which requires some new and similarly breaking ESLint and Prettier versions. Also because v0.15.0 is focused on Rollup changes that will introduce enough changes as is.
The upstream issue suggests it's a cache issue, so maybe just clearing the cache or re-creating node_modules might fix it (temporarily).

I ended up doing this:

Turned on isolated modules.
Updated test script in the package.json file to tsdx test --no-cache.

To clarify for any other readers, the comment linked says that this is an OR condition, not an AND. Per the link, isolatedModules means less powerful type-checking, etc so something to generally avoid.
Could also use a resolution to upgrade at your own risk.

Just to be clear, for meaningful usage tsdx test is broken currently, and won't be fixed until v0.16.0?

Just to be clear, for meaningful usage tsdx test is broken currently, and won't be fixed until v0.16.0?

@PurpleBooth that is a significant misrepresentation of the facts and is quite inaccurate. If that were the case then that would mean all of ts-jest 25.x is broken. But despite having millions of users, based on upstream and here, this is a super rare error that has only had 3 confirmed reproductions. Your issue #919 is also not the same issue as this. tsdx test has significant usage in the wild too and TSDX also dogfoods tsdx test and this issue does not occur in internal tests or in CI runs.
So it's inaccurate to say that "meaningful usage [...] is broken". It seems much more accurate to say there are some very rare cases where this error occurs.
I'll also mention that passive-aggressive comments are against the CoC. I'm not sure why you felt aggressive against and downvoted my factual comment. I did not state any opinions in my comment and I cannot control how upstream libraries make breaking changes... I have in fact made significant efforts to batch breaking changes so that TSDX users don't feel the impact as much -- I'm not exaggerating when I say there could be a breaking change every week otherwise. I've also spent probably a dozen hours or more reading upstream changelogs to make sure each dependency upgrade is done properly, since it's very easy to accidentally break one command by upgrading another or accidentally releasing something breaking in a non-breaking release.
This problem also has at least 3 different workarounds and likely more, as ts-jest itself can be turned off.

Sorry, I was totally in the wrong here. I hope you accept my apologies.


Inserting decimal datatypes using fastexecutemany=True causes memory issues

Environment

Python: 3.6.9
pyodbc: 4.0.32
OS: ibuntu linux
DB: Azure SQL DB
driver: DRIVER={ODBC Driver 17 for SQL Server}

I am attempting to load a very wide table that consists of 99 columns that include 44 decimal(28,9), 34 uniqueidentifiers, 12 ints, 4 bits, 5 dates, etc.  See schema below.
My python application is running on a VM with 8 gb of memory with no load other than my application.  My application reads from a very large parque file in a streaming fashion and sends batches to Azure SQL via pyodbc's executemany method.
I am using the fastexecutemany = True, Autocommit = false.
I am currently testing with loading in batches of 20,000 rows.
I expect to be able to call cursor.executemany, passing a list of 20,000 tuples in a loop and be able to successfully load nearly 10 million rows with my application memory not getting consumed in a linear fashion.  What I am observing is if I include decimals in my list that I send to executemany(), then it appears that memory is not getting released from executemany() such that with each iteration I can observe the memory usage consistently growing.
...
for record_batch in reader.iter_batches(batch_size=20,000)
        cursor.fast_executemany = True
        values = list(zip(*map(lambda col: col.to_pylist(), record_batch.columns)))
       cursor.executemany(insert_stmt, values)
       cursor.commit()
...

Immediately out of the gate, my server's memory went quickly (linearly) straight down until it consumed all of the memory (8GB).
So, I began investigating, including removing columns from the list until I could observe some pattern.  Here are some things that I notice with memory:

If I take all of the decimals out of the list, leaving the other 55 columns, then the entire batch runs successfully with memory staying below 1/2GB!

If I add 4 decimals to the list of 55, then by the 192th iteration of the loop, memory consumption is already hitting 3GB.  I stopped it there and didn't let it continue to the 500th loop because it didn't seem worth it.

If I JUST load Id (uniqueidentifier) and a single decimal column, then memory grows to the point that after the 10 million rows have been inserted, 1.7 GB of memory has been consumed in the 12 minutes.  Given that I am using a for-loop to load in batches, it should allow for the values to be released as they go out of scope so why does the memory usage grow consistently over the entire time?

As a final decimal test, I did a batch of Id and 9 decimals.  By the 223th loop I had to kill the process because it had already consumed 5.9GB!

I remove just the cursor.executemany from the loop and memory is not an issue so I am positive it is isolated to the cursor.

If I turn off fastexecutemany, then I don't have any memory issues but I have speed issues so I definitely need to make it work with fastexecutemany.

If I pass the zip generator object to cursor_executemany rather than the values list, then the memory issue goes away but it runs slow like its no longer in fastexecute mode, which is what I suspect is happening.

It seems that decimals are key to the memory issue that I am seeing.  Why does including a decimal consume so much memory without it getting released?
The simplest way to reproduce this is to do the third test above with a list of 20,000 tuples of (string, decimal) where the string is a GUID.  Observe how memory grows in a linear fashion.
I appreciate any assistance you can provide!  Thank you for all you do!

Correct. See #500

If I turn off fastexecutemany, then I don't have any memory issues but I have speed issues so I definitely need to make it work with fastexecutemany.

As a workaround you might want to experiment with the JSON trick described here.

If I pass the zip generator object to cursor_executemany rather than the values list, then the memory issue goes away but it runs slow like its no longer in fastexecute mode, which is what I suspect is happening.

Correct. See #500

If I turn off fastexecutemany, then I don't have any memory issues but I have speed issues so I definitely need to make it work with fastexecutemany.

As a workaround you might want to experiment with the JSON trick described here.

Thank you.  I will take a look at the workaround.
I would like to know if the fastexecutemany method is holding onto decimals in some way though.  If so, then I would think this would be an issue others are running into as well.  Also, maybe this is something that has been introduced in some recent version and I could drop back a few versions?
As you'll notice in my writeup, I can load a LOT of string data and int data and it is fabulous - no issues.  Only when I introduce decimals do I see an issue with memory not getting released.

@ddavis226: I see everything from my perspective which is SQL Server, so I thought you were talking about memory problems on the SQL Server.
Loading in Batches could also improve writing to the transaction log and with columnstore it is also important to load in batches (but more than 20k).

Repro code for this issue:
from decimal import Decimal

import psutil as psutil
import pyodbc

connection_string = (
    "DRIVER=ODBC Driver 17 for SQL Server;"
    "SERVER=<IP_ADDRESS>;"
    "UID=scott;PWD=tiger^5HHH;"
    "DATABASE=test;"
)
cnxn = pyodbc.connect(connection_string)
crsr = cnxn.cursor()
crsr.fast_executemany = True

table_name = "gh1026"
num_columns = 127

crsr.execute(f"DROP TABLE IF EXISTS {table_name}")
column_names = [f"col{i:03}" for i in range(num_columns)]
column_type = "decimal(18, 4)"
column_definitions = ", ".join(f"{x} {column_type}" for x in column_names)
sql = (
    f"CREATE TABLE {table_name} (id int identity primary key, "
    f"{column_definitions}"
    ")"
)
crsr.execute(sql)
sql = f"INSERT INTO {table_name} ({', '.join(column_names)}) VALUES ({', '.join('?' * num_columns)})"

value = Decimal("3.14")
batch_size = 2000
data = [tuple([value for c in range(num_columns)]) for r in range(batch_size)]

process = psutil.Process()

def printmem(msg):
    mb = process.memory_info().vms / 1048576
    print(f"{msg}: {mb:0.1f} MiB")

printmem("before loop")
for loop in range(3):
    crsr.executemany(sql, data)
    cnxn.commit()
    printmem(f"after {loop + 1} iteration{'s' if loop else ''}")

console output:
before loop: 12.5 MiB
after 1 iteration: 31.6 MiB
after 2 iterations: 50.6 MiB
after 3 iterations: 70.7 MiB

However, with value = 3.14 instead of value = Decimal("3.14") we see:
before loop: 12.5 MiB
after 1 iteration: 12.5 MiB
after 2 iterations: 12.5 MiB
after 3 iterations: 12.5 MiB

Additional information: The above code was run using pyodbc 4.0.32 (current release). It also reproduces the issue under the current master branch and also using the modifications from PR #703 from @Mizaro , so it looks like it really is a new issue.

https://github.com/mkleehammer/pyodbc/blob/master/src/params.cpp#L554
This might be the leaked object. There's no Py_XDECREF for it.

@v-chojas - Thanks for the pointer. I added a Py_XDECREF for it but the results remain unchanged
@@ -564,10 +564,11 @@ static int PyToCType(Cursor *cur, unsigned char **outbuf, PyObject *cell, ParamI
         PyObject *scaledDecimal = PyObject_CallObject((PyObject*)cell->ob_type, args);
         PyObject *digitLong = PyNumber_Long(scaledDecimal);

         Py_XDECREF(args);
         Py_XDECREF(scaledDecimal);
+        Py_XDECREF(newDigits);
         Py_XDECREF(cellParts);

         pNum->precision = (SQLCHAR)pi->ColumnSize;
         pNum->scale = (SQLCHAR)pi->DecimalDigits;

@v-chojas - My apologies. PyCharm didn't see the change until I did
pip install -e /home/gord/git/pyodbc/

Now (on Linux) I get
before loop: 39.8 MiB
after 1 iteration: 40.2 MiB
after 2 iterations: 46.8 MiB
after 3 iterations: 46.8 MiB
after 4 iterations: 46.8 MiB
after 5 iterations: 46.8 MiB
after 6 iterations: 46.8 MiB
after 7 iterations: 46.8 MiB
after 8 iterations: 46.8 MiB

In looking at the code it appeared that a Py_XDECREF was also missing for the digits object at
https://github.com/mkleehammer/pyodbc/blob/master/src/params.cpp#L554
I added Py_XDECREF(digits);, but the results didn't change. Perhaps that object is too small to be consequential, but would you recommend that I leave it in for completeness?

@ddavis226 - If you would like to try out the patch you can
pip install git+https://github.com/gordthompson/pyodbc@decimal_leak

I would be oh-so-grateful!!

This is working as expected now!  Thank you so much for the incredibly quick turnaround!

Hello,
I have the same issue, I assume this fix will be released in the next version?
Is there any way I can use this fix before then?
Thanks.

@jdudleyie - You can install pyodbc from the latest master branch
pip install git+https://github.com/mkleehammer/pyodbc

Thanks @gordthompson. I assume I could do this for testing that it resolves the issue, but I should not do this in production as there are other commits since the last release so it’s probably not safe?
If I wanted to use this fix in production is there a way for me to get or create a build of the latest current released version plus only this new fix? Thanks.

there are other commits since the last release so it’s probably not safe

I don't know why you would assume that. Those changes have been vetted and accepted so they will be included in the next official release anyway (whenever that is).

Thank you, I didn’t realise, that’s good to know. (If each of those commits is vetted then I am wondering why a new release is not automatically created for each merge to master so they are easily available to consumers.)
I suppose I am used to using a specific version of a library in production and consciously choose when to upgrade, so if I was to change my docker image/production deployment process temporarily to pip install pyodbc master so as to include this fix, then at any time a new commit could come in that may affect something in production and it may be harder to track it down, but if I had recently upgraded package versions, then at least I would know that’s something that I had changed.
Is there a way to pip install a specific commit on the pyodbc master branch?
Apologies for all the questions, just trying to assess the safest way to get this change into my production environment in order to resolve the memory leak and I’m not that familiar with these options that don’t involve bumping a package version.

You can check out specific commit ID, instead of only the latest of the master.

Running the below worked for me and appears to resolve the memory leak, both on Windows and also in Linux, thanks for the help.
pip install git+https://github.com/mkleehammer/pyodbc@e67ad89a5ed8066b7f1272b96688da0a5c24c1c5


Cleanup obelisk rendering even more

and make sure we have the right OpenGL bits set when rendering as item. This should also fix some older rendering issues with the floating item transparency.
re #3024

Thanks, I could never quite figure out what was causing the item rendering issue.


Apple M1 Silicon Not Supported

When I try to add support to my shared library for M1 silicon
kotlin {
    android()
    ios()
    // Note: iosSimulatorArm64 target requires that all dependencies have M1 support
    iosSimulatorArm64()
...

then I get the following error
Execution failed for task ':shared:cinteropReachabilityIosSimulatorArm64'.

Could not resolve all files for configuration ':shared:iosSimulatorArm64ReachabilityCInterop'.
Could not resolve com.github.ln-12:multiplatform-connectivity-status:1.3.0.
Required by:
project :shared
No matching variant of com.github.ln-12:multiplatform-connectivity-status:1.3.0 was found. The consumer was configured to find a usage of 'kotlin-cinterop' of a library, with the library elements 'cinterop-klib', preferably optimized for non-jvm, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native', attribute 'org.jetbrains.kotlin.native.target' with value 'ios_simulator_arm64' but:
- Variant 'debugApiElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares an API of a library:
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Variant 'debugRuntimeElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a runtime of a library:
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Variant 'iosArm64ApiElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a usage of 'kotlin-api' of a library, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native':
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_arm64' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_simulator_arm64'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Variant 'iosArm64MetadataElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a library, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native':
- Incompatible because this component declares a usage of 'kotlin-metadata' of a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_arm64' and the consumer needed a usage of 'kotlin-cinterop' of a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_simulator_arm64'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Variant 'iosX64ApiElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a usage of 'kotlin-api' of a library, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native':
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_x64' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_simulator_arm64'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Variant 'iosX64MetadataElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a library, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native':
- Incompatible because this component declares a usage of 'kotlin-metadata' of a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_x64' and the consumer needed a usage of 'kotlin-cinterop' of a component, as well as attribute 'org.jetbrains.kotlin.native.target' with value 'ios_simulator_arm64'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Variant 'metadataApiElements' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a library:
- Incompatible because this component declares a usage of 'kotlin-metadata' of a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'common' and the consumer needed a usage of 'kotlin-cinterop' of a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Variant 'releaseApiElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares an API of a library:
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Variant 'releaseRuntimeElements-published' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0 declares a runtime of a library:
- Incompatible because this component declares a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' and the consumer needed a component, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'native'
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Variant 'samplessources' capability com.github.ln-12:multiplatform-connectivity-status:1.3.0:
- Incompatible because this component declares documentation and the consumer needed a library
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for non-jvm)
- Doesn't say anything about its elements (required them with the library elements 'cinterop-klib')
- Doesn't say anything about its usage (required a usage of 'kotlin-cinterop')
- Doesn't say anything about org.jetbrains.kotlin.native.target (required 'ios_simulator_arm64')
- Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'native')

Same happens for me on Intel machine.
(I don't have this problem when I remove iosSimulatorArm64())


Performance Regression

After switching to v3.5.1 from v3.4.5, I noticed that CKKS rotations are noticeably slower. I'm using an AWS c5.12xlarge instance. I'm using a ring dimension of 65536 and modulus with 32 primes (first and last are 60 bits, others are 54 bits). In v3.4.5, a rotation took 1.58s, while in v3.5.1, rotations take 1.87 seconds (for a freshly encrypted ciphertext).
For reference, there was no performance change for additions or multiplications, and rescale is about 2x faster in v3.5.1 (great!)
This is performance degradation for rotations is significant enough to prevent me from upgrading to the new SEAL version.

I’ll look into this. I did improve its performance. Maybe some other changes add more latency. Were you performing the same rotation many times or random rotations? What’s the compiler in use? Or you can dump your CMakeCache.txt here. Thank you.
Regards,
Wei Dai

From: crockeea<EMAIL_ADDRESS>Sent: Friday, May 22, 2020 1:09:26 PM
To: microsoft/SEAL<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/SEAL] Performance Regression (#173)
After switching to v3.5.1 from v3.4.5, I noticed that CKKS rotations are noticeably slower. I'm using an AWS c5.12xlargehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Faws.amazon.com%2Fec2%2Finstance-types%2Fc5%2F%23Product_Details&data=02|01|wei.dai%40microsoft.com|c92ab17464b848becb6408d7fe8c0797|72f988bf86f141af91ab2d7cd011db47|1|0|637257749689570863&sdata=o0XfK%2Fuh84reAKF5V%2B%2Bwfp0Je8QF%2FH21kVY0svRxs58%3D&reserved=0 instance. I'm using a ring dimension of 65536 and modulus with 32 primes (first and last are 60 bits, others are 54 bits). In v3.4.5, a rotation took 1.58s, while in v3.5.1, rotations take 1,.87 seconds (for a freshly encrypted ciphertext).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSEAL%2Fissues%2F173&data=02|01|wei.dai%40microsoft.com|c92ab17464b848becb6408d7fe8c0797|72f988bf86f141af91ab2d7cd011db47|1|0|637257749689580861&sdata=Hs2su9dSetXZDlBeeW3jZ8KYA6y8E9k4Pk7g%2FN5pbaY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABK7SAJRTJJOFA6NXSE4WOLRS3LXNANCNFSM4NIDD66Q&data=02|01|wei.dai%40microsoft.com|c92ab17464b848becb6408d7fe8c0797|72f988bf86f141af91ab2d7cd011db47|1|0|637257749689580861&sdata=afIKvsFLNelAf9U8MeMFhFYglWCDHCM874UpwoonCdw%3D&reserved=0.

The timing was about the for any power-of-two rotation; I didn't try rotations of non-power-of-two steps sizes. Using gcc-9.3.0.
CMakeCache.txt

Is it an average of different power-of-two rotations?
Regards,
Wei Dai

From: crockeea<EMAIL_ADDRESS>Sent: Friday, May 22, 2020 2:06:35 PM
To: microsoft/SEAL<EMAIL_ADDRESS>Cc: Wei Dai<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/SEAL] Performance Regression (#173)
The timing was about the for any power-of-two rotation; I didn't try rotations of non-power-of-two steps sizes. Using gcc-9.3.0.
CMakeCache.txthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSEAL%2Ffiles%2F4670378%2FCMakeCache.txt&data=02|01|wei.dai%40microsoft.com|63d76c8b5a394320eca908d7fe9402ef|72f988bf86f141af91ab2d7cd011db47|1|0|637257783961753286&sdata=KF2LB5ZetAoufMC34TGl%2FZa0K5PlVtQrozHGzBU%2B78s%3D&reserved=0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSEAL%2Fissues%2F173%23issuecomment-632908819&data=02|01|wei.dai%40microsoft.com|63d76c8b5a394320eca908d7fe9402ef|72f988bf86f141af91ab2d7cd011db47|1|0|637257783961763283&sdata=Qgs727rbAUth7j4VlvOvExycAwP7ZEIC4RJ6kmNBAQE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABK7SAN2IVTWTKCP2OQGOM3RS3SNXANCNFSM4NIDD66Q&data=02|01|wei.dai%40microsoft.com|63d76c8b5a394320eca908d7fe9402ef|72f988bf86f141af91ab2d7cd011db47|1|0|637257783961763283&sdata=MBL%2BbA527Xo4wSdHQnu%2Fo6ohr%2BB2X8HpB9XI2mTrINA%3D&reserved=0.

No, I just performed several sequential rotations of different sizes; i.e. <<2, <<4, << 8, etc. They all had the same runtime (about 1.9 seconds for v3.5.1), and there was almost no variance over multiple runs of the benchmark.

Concretely, pseudocode is roughly:
Ciphertext x = encrypt(...)
for(int i =0; i < 512; i<<=1) {
  elapsed = time(evaluator.rotate_vector(x, i keys, y);
  cout << "Rotate left " << i << ": " << elapsed << endl;
  x = y
}

with output
Rotate left 1: 1.91 seconds
Rotate left 2: 1.87 seconds
Rotate left 4: 1.87 seconds
Rotate left 8: 1.87 seconds
Rotate left 16: 1.87 seconds
Rotate left 32: 1.88 seconds
Rotate left 64: 1.87 seconds
Rotate left 128: 1.88 seconds
Rotate left 256: 1.87 seconds

Well, I couldn't run 32 primes on my desktop. I tested with 8 primes and noticed the same issue. This only happens if GCC is used.
Here is the rank performance of CKKS rotation with 2 compilers and 2 versions of SEAL (fastest to slowest):

clang 9.0.0, SEAL 3.5.1 (15% faster than next)
clang 9.0.0, SEAL 3.4.5 (10% faster than next)
gcc 9.2.1, SEAL 3.4.5 (8% faster than next)
gcc 9.2.1, SEAL 3.5.1

I've no idea why clang is better than gcc or why SEAL 3.5.1 is slower than 3.4.5 with gcc. It worth some digging but I won't have a fast fix. Can you switch to clang?

Confirmed that v3.5.1 is faster with Clang.
For ring dimension of 65536 and modulus with 32 primes:
rotation time with SEAL v3.4.5:
gcc-9: 1.58s
clang-9: 1.26s
rotation time with SEAL v3.5.1:
gcc-9: 1.87s
clang-9: 1.15s
Thus gcc got slower, while Clang got faster. But clang is faster than GCC in both cases. It'd be nice if the README indicated that performance is (likely) better with Clang.

It was mentioned briefly in CHANGES.md. I've just added a note in README for the next release. Thanks for the suggestion.


[POSTGRES] Custom tags not associated to metrics

Output of the info page
==============
Agent (v6.4.2)
==============

  Status date: 2018-09-09 21:36:39.258395 UTC
  Pid: 339
  Python Version: 2.7.15
  Logs:
  Check Runners: 2
  Log Level: info

[...]

    postgres (2.1.3)
    ----------------
      Total Runs: 4
      Metric Samples: 267, Total: 1068
      Events: 0, Total: 0
      Service Checks: 1, Total: 4
      Average Execution Time : 5075ms

[...]

Additional environment details (Operating System, Cloud provider, etc):
Datadog Agent running as DaemonSet on K8S (MiniKube).
Steps to reproduce the issue:

Create pod with Datadog annotations (see snippet bellow).

Describe the results you received:
Not all metrics reported by Datadog Postgres integration have custom tags associated with them. For majority of Postgres metrics only host tags are passed (see table bellow).
Describe the results you expected:
All metrics have associated custom tags.
Additional information you deem important (e.g. issue happens only occasionally):
This are annotations I'm using on that pod:
apiVersion: v1
kind: Pod
metadata:
  annotations:
    ad.datadoghq.com/postgres.check_names: '["postgres"]'
    ad.datadoghq.com/postgres.init_configs: '[{}]'
    ad.datadoghq.com/postgres.instances: |-
      [{
        "host": "<SERVICE_IP>",
        "port": 5432,
        "username": "datadog",
        "password": "<POSTGRES_PASS>",
        "dbname": "template1",
        "ssl": "True",
        "tags": ["environment:dev","postgresql-instance:postgres-dev"]
      }]

This is a table of metrics I am collecting and whether these metrics have custom tags associated with them:

metric name
tags correct

postgresql.connections
NO

postgresql.commits
NO

postgresql.rollbacks
NO

postgresql.disk_read
NO

postgresql.buffer_hit
NO

postgresql.rows_returned
NO

postgresql.rows_fetched
NO

postgresql.rows_inserted
NO

postgresql.rows_updated
NO

postgresql.rows_deleted
NO

postgresql.database_size
NO

postgresql.deadlocks
NO

postgresql.temp_bytes
NO

postgresql.temp_files
NO

postgresql.bgwriter.checkpoints_timed
NO

postgresql.bgwriter.checkpoints_requested
NO

postgresql.bgwriter.buffers_checkpoint
NO

postgresql.bgwriter.buffers_clean
NO

postgresql.bgwriter.maxwritten_clean
NO

postgresql.bgwriter.buffers_backend
NO

postgresql.bgwriter.buffers_alloc
NO

postgresql.bgwriter.buffers_backend_fsync
NO

postgresql.bgwriter.write_time
NO

postgresql.bgwriter.sync_time
NO

postgresql.max_connections
YES

postgresql.percent_usage_connections
YES

List of metrics taken from here. I removed these that I don't collect.
Custom tags described in readme here.
Pod annotations functionality described here.

Hi @ksendor, thanks for reaching out with this issue! The instance level tags were re-enabled in Postgres integration version 2.2.0 bundled with Datadog Agent 6.6.0. You should be able to see the custom instance tags with the updated integration check.


Repo sync for protected CLA branch

The pull request is created from master637659397331189545 to master to fix git push error for protected CLA branch

@huypub : Thanks for your contribution! The author(s) have been notified to review your proposed change.


feat(web-ui): bump version (#710)

Closes #710

:+1:

Codecov Report

Merging #711 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #711   +/-   ##
========================================
  Coverage      83.8%   83.8%
  Complexity      883     883
========================================
  Files           159     159
  Lines          2389    2389
  Branches        339     339
========================================
  Hits           2002    2002
  Misses          234     234
  Partials        153     153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936f219...9c459b0. Read the comment docs.

:+1:


Add possibilities to follow symlinks when performing recursive directory search

This feature adds a CLI option -L that toggles whether symbolic links should be followed when in the recursive directory search.
I have multiple cloned repositories in different places in my filesystem hierarchy. For ease of access and delimiting of search among other reasons, I keep a _current_projects folder containing symbolic links to repositories I am actively working on. This patch allows me to execute git standup in my _current_projects directory.

Thanks 👍


WIP: Add ability to choose what instrumentations are enabled

This PR adds support for choosing what instrumentations should be enabled for traces, metrics, prometheus metrics. The users can define a subset from all available instrumentations for each export category. For example, all instrumentations can be enabled for traces, but only HTTP and SQL for metrics.
TODO:

[ ] Tests
[ ] Integration tests
[ ] Docs

Codecov Report
Attention: Patch coverage is 30.62645% with 299 lines in your changes missing coverage. Please review.

Project coverage is 36.03%. Comparing base (d7d75a1) to head (a3f1cd4).

Files
Patch %
Lines

pkg/internal/export/prom/prom.go
0.79%
251 Missing :warning:

pkg/internal/export/otel/metrics.go
69.11%
33 Missing and 9 partials :warning:

pkg/internal/export/otel/traces.go
80.00%
3 Missing and 1 partial :warning:

.../internal/export/instrumentations/instr_options.go
90.90%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #958       +/-   ##
===========================================
- Coverage   71.45%   36.03%   -35.42%
===========================================
  Files         130      131        +1
  Lines       10319    10461      +142
===========================================
- Hits         7373     3770     -3603
- Misses       2314     6286     +3972
+ Partials      632      405      -227

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
36.03% <30.62%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CPEM fails with Talos linux

CPEM installed in k8s cluster deployed on Talos linux, with instructions
Fails with error.

It's unclear what the error is. You linked a closed issue. Also did you remove the external cloud provider setting? CPEM needs that.


Mention wasm-features in Readme.md

When important features aren't mentioned, this can lead to some confusion
Therefore, I suggest quickly mentioning them. :)
This pull-request adds a mention about WebAssembly and the required features.

Eventually, it would be handy to have every existing feature described in the Readme.md. Nothing extensive, just a short mention that the feature exists and an overview of what it does.

I've implemented the requested changes! :)

If you have experience with compiling to WASM, I would be very very happy if you could add a check to the CI as well :)

I don't have much experience, unfortunately. Maybe @dariogoetz could share his sources with you though. He has set up the infrastructure of our keyboard-project.

I've implemented the requested changes! :)

If you have experience with compiling to WASM, I would be very very happy if you could add a check to the CI as well :)

I don't have much experience, unfortunately. Maybe @dariogoetz could share his sources with you though. He has set up the infrastructure of our keyboard-project.

Thanks for making the changes! I added the same text to src/lib.rs as I typically create the readme from there using cargo readme.

By the way, I'm just curious: When do you plan on releasing v0.5.0?

I plan to release it until the end of January, hopefully sooner. But unfortunately I can't guarantee it ;)

Understood  :)

v0.5.0 is released!

Amazing, thank you for notifying me! :)


OSM Validating Webhook blocks valid ConfigMap patches post upgrade

Upgraded OSM Controlle from v0.5 to v0.8.  Used kubectl apply to upgrade the container, not osm mesh upgrade.
Tried to patch the osm-system/osm-config ConfigMap with:
kubectl patch ConfigMap osm-config -n osm-system -p '{"data":{"service_cert_validity_duration":"5s"}}' --type=merge

Observed error:
Error from server (
enable_privileged_init_container: must be included as it is a default field): admission webhook "osm-config-webhook.k8s.io" denied the request:
enable_privileged_init_container: must be included as it is a default field

The state of the ConfigMap when this error is observed:
apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    app.kubernetes.io/managed-by: Helm
  name: osm-config
  namespace: osm-system
data:
  egress: "false"
  enable_debug_server: "false"
  envoy_log_level: error
  permissive_traffic_policy_mode: "false"
  prometheus_scraping: "true"
  service_cert_validity_duration: 24h
  tracing_address: jaeger.osm-system.svc.cluster.local
  tracing_enable: "true"
  tracing_endpoint: /api/v2/spans
  tracing_port: "9411"
  use_https_ingress: "false"

Workaround:
Patched the ConfigMap with:
kubectl patch ConfigMap osm-config -n osm-system -p '{"data":{"enable_privileged_init_container":"false"}}' --type=merge

and then was able to apply the original patch, which failed earlier:
kubectl patch ConfigMap osm-config -n osm-system -p '{"data":{"service_cert_validity_duration":"5s"}}' --type=merge

This issue is no longer valid as we have deleted the validating webhook code from osm


Trailing whitespace

I have a plugin that highlights trailing whitespace as red, and dashboard-nvim has a lot of it. Can it please be removed?

Same problem, how did you solve it?

I use Vim Better Whitespace Plugin for whitespace highlighting.

why you don't read this plugin. g:better_whitespace_filetypes_blacklist. i open it just now and find this in readme.

You are ahead of me) Thanks for help and great plugin.
For future seachers, disable it by
vim.g.better_whitespace_filetypes_blacklist = { 'dashboard' }


Session-cookie with samesite = strict breaks login-procedure

In the latest release of Silverstripe CMS (>4.12) the samesite-attribute for cookies is configurable. It is recommended to set this value to strict for the cookies and the session-cookie. (see https://docs.silverstripe.org/en/4/changelogs/4.12.0/#cookies-samesite)
I believe this introduces a problem for the SAML-authentication. From what I understand, the problem lies within the session-cookie. This session-cookie should not be loaded, after returning from the IdP (on /saml/asc) - since this is another domain (not samesite). This is roughly same scenario as IdP-initiated logins, where no prior session-cookie is available on the first request.
The problem seems to be specifically in the redirection at the very end of asc() method. Here the user is redirected via 301 to the  desired destinationpage. Because of this same-site cookie restriction, this next page doesn't get the proper session-cookie ans Silverstripe starts a new session.
Let me try explain with some screenshots:
Scenario lax:
Same-site set to lax (the session-cookie is held correctly)
/saml/acs

the request cookie is also set, because I was using SP-initiated request. This session is reset by the login process. The session-cookie starts with k3d... is send to the next page. The response code of this page is 302.
/home (destination page)

the same session-cookie is still there, starting with k3d...
Scenario strict:
Same-site set to strict (the session-cookie is NOT held correctly)
/saml/acs

_the request cookie is empty, since the same site attribute prevents this. No problem, a new session-cookie is set starting with nqb... _
/home (destination page)

the request cookie is empty, because the 302 redirect is treated with the same cookies as the original request. A new session-cookie is set uk9... and thus not allowing us the keep the logged in state for this page.
Reproduce

Use CMS 3.12
Set yml with same-site cookies to strict (see https://docs.silverstripe.org/en/4/changelogs/4.12.0/#cookies-samesite)
Temporary prevent the redirect in the saml/asc flow. For instance by putting a die('done asc') in the getRedirect()-method
Open the /home  page in a new tab, and see the Member is still logged in correctly

Solution
The solutions for us was to redirect the user via the browser (meta-refresh), so the destination-page is allowed to use the same session-cookie. Totally not ideal, but works for now. For inspiration see htmlRedirect in the framework

I've actually ran into the same thing just now - for HTTP POST binding across sites even Lax will drop the cookie [definitive citation needed]. I think this is a classic reason why RelayState is used. Unfortunately I think this module does not handle that part, but it is implemented in the underlying onelogin driver.
Would you care to share your solution more specifically? Where did you put the meta-refresh, was it on the SP side and did you have to hook it in?

Would you care to share your solution more specifically? Where did you put the meta-refresh, was it on the SP side and did you have to hook it in?

@mateusz Although a fix has seems to be implemented, I'll share our work-around. Since i'm not sure if the RelayState is always available and a redirect still might be in the way.
We planned to do this on the SP-side (in our application) by overwriting the asc(0)-method in the SAMLController-class. But ultimately we decided to go with the same-site=lax setting. But the code work-in-progess would looked something along the lines:
SilverStripe\Core\Injector\Injector:
  SilverStripe\SAML\Control\SAMLController:
    class: SAMLControllerExt

    class SAMLControllerExt extends SAMLController
    {

        public function acs() {

               // copy exitsing code here....

            $headersSent = headers_sent($file, $line);
            $location = '/';
            $url = Director::absoluteURL($location);
            $urlATT = Convert::raw2htmlatt($url);
            $urlJS = Convert::raw2js($url);
            $title = (Director::isDev() && $headersSent) ? "{$urlATT}... (output started on {$file}, line {$line})" : "{$urlATT}...";
            echo <<<EOT

Redirecting to {$title}

    <meta http-equiv="refresh" content="1; url={$urlATT}" />

    EOT
            ;
            exit;

        }
    }

I see that the method has an extention-hook updateLogin, so that would be probably be a better way to implement.

As far as I know, RelayState is part of SAML2 spec.
But I think I may have misunderstood your issue - I see what you mean now. This fix will not help, I think the cookie you describe will not be affected. Thanks for sharing the code - it's probably something that should be sent in as a pull request :-)
@satrun77 - can you please reopen this, as I think my fix fixes another problem altogether.

As far as I know, RelayState is part of SAML2 spec.

You are certainly right, but afaik this RelayState is not used by a default login situation. Come to think of it, the problem with losing sessions because of the redirect would probably still exist even if you would use it, since only the URL where to redirect to has changed.
But the support for RelayState is still very useful, so no code has been wasted 👍


JS.ORG CLEANUP

JS.ORG CLEANUP
Hello, it seems a js.org subdomain that was requested to target this repository no longer works.
The subdomain requested was bb26.js.org and had the target of ptrkcsk.github.io/BB26.
It produced the following failures when tested as part of the cleanup:

HTTP: Failed with status code '404 Not Found'
HTTPS: Failed with status code '404 Not Found'

To keep the js.org subdomain you should add a page with reasonable content within a month so the subdomain passes the validation.
Failure to rectify the issues will result in the requested subdomain being removed from JS.ORGs DNS and the list of active subdomains.
If you are wanting to keep the js.org subdomain and have added reasonable content, YOU MUST reply to the main cleanup issue with the response format detailed at the top to keep the requested subdomain.
:robot: Beep boop. I am a robot and performed this action automatically as part of the js.org cleanup process. If you have an issue, please contact the js.org maintainers.

No problem. I moved the docs from ptrkcsk.github.io/BB26 to this repo's readme.


Add required function to sink templates in Helm Chart

Required function in Helm Templates
The optional fields in the kubernetes resources that we expect to be filled through the helm template command should include this function to detect typos or similar errors in the CI.
More information on the function in here
Goal
Include this keyword in the templates of the kubearchive sink component.
Reference
Example of PR

I am closing this as we are trying to have a lighter use of Helm


No profile photo

Hello, there is no user button in my instance, I think the reason is that I have no username photo.

@albertopasqualetto can you repull  latest release


Feature Request: Templates.

dotnet new --install Electron.NET.Templates
dotnet new electron-blazor

@VictorioBerra
This looks like something I may want to try to implement just to learn.
How do you think this should look?
Would dotnet new electron-blazor create the default SPA app that is created with a new Blazor App + all the Electron.NET hookups? Or would a more tailored default app be better?
Do you have any specifics in mind?

You could do it like https://github.com/Dotnet-Boxed/Templates
Where you have tons of configurable options but if you specify nothing you get the default. In this case I think you should get a working electron app with blazor with sensible defaults that you would want for any new project with reduced boilerplate.

Cool, I'll take a look and see what I can come up with within my own fork.
If it's something worth sharing, I link the PR to this issue.


⚠ Bofrost.fr has degraded performance

In 28b9e5a, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1397 ms

Resolved: Bofrost.fr performance has improved in 55574e0.


MIgrate to Webpack

We use Grunt for building System Designer.
It works pretty well but we will give a try to Webpack for:

be part of a bigger ecosystem and
check if we gain time and size for the build.

Finally we will keep Grunt because we do not bundle systems, we only merge them in order to build System Designer. So there is no need to use WebPack for that.


Clean up code

This will do quite some things. Here's a list.

[x] Update Gems and organize dependencies. We were having a lot of testing gems thrown into the production environment. This fixes it.

@askl56 do we need zapata, regressor, minitest_to_rspec and shoulda-matchers. Also, we're using GitHub references in the Gemfile - are those gems available via RubyGems.org too?

Regressor can be removed as can zapata. As far as I know I didn't add minitest_to_rspec.
We should create a slack group for this project.

@askl56, sure. Just did that. Check out the email on your profile. Just sent an invite. Also, feel free to push to this branch.


trim both prev class and cur class before splitting #86

See https://github.com/ProseMirror/prosemirror-view/pull/86

trim only removes leading and trailing white space; boolean filter removes unnecessary white space inside the string as well
Example:
" a  b  c ".trim().split(" ") // ["a", "", "b", "", "c"]
" a  b  c ".split("").filter(Boolean) // ["a", "b", "c"]


chore: add project years badge

For #547

Below is a more generic badge. How do you think about it?
![GitHub Created At](https://img.shields.io/github/created-at/linuxsuren/api-testing)

done!, ptal


Failure to Build Go Interop Image

...
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go<EMAIL_ADDRESS>unknown revision v2.2.2
go: error loading module requirements

2021-01-21 16:27:17,157 FAILED: build_docker_go [ret=1, pid=8116, time=237.6sec]

https://source.cloud.google.com/results/invocations/ff970a31-a168-4b21-a2e8-0763fc03d77a/log

I want to work on this issue. Please assigned me this.

I want to work on this issue. Please assigned me this.

@Rashika101 Thanks for offering the help. But I don't think there anything to fix here.
The failure looks like connection problem to me.
<EMAIL_ADDRESS>unknown revision v2.2.2
While<EMAIL_ADDRESS>does exist.

@Rashika101 Thanks for offering the help. But I don't think there anything to fix here.
The failure looks like connection problem to me.
<EMAIL_ADDRESS>unknown revision v2.2.2
While<EMAIL_ADDRESS>does exist.

Another interop build failure this time with:
go: finding golang.org/x/net v0.0.0-20180724234803-3673e40ba225
go<EMAIL_ADDRESS>git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /go/pkg/mod/cache/vcs/7e5fa1eab4705eb80c9746632736cea906708d060702d529df6241d1c8c2c9f9: exit status 128:
	remote: Cannot obtain refs from GitHub: cannot talk to GitHub: Get https://github.com/go-check/check.git/info/refs?service=git-upload-pack: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
	fatal: unable to access 'https://gopkg.in/check.v1/': The requested URL returned error: 502
go: error loading module requirements

Closing since we decided to move CI test flakes to buganizer


Add VLAN Min and Max VID to VLAN Group

Fixes: #526

Added min_vid and max_vid to VLANGroup Model.
Add fields to VLANGroup View and Forms.
Added fields to VLANGroup html template.
Added fields to API views (VLANGroup and NestedVLANGroup).
Added validation when manually adding a new VLAN to the group.
Adjusted get_next to pick a free VLAN within the configured min and max vid.

Thank you for the submission, but after some internal deliberation we decided that, we want to solve this problem more abstractly.
We're closing this in exchange for https://github.com/nautobot/nautobot/issues/606


Document cropper background is white on IOS

Wonderful plugin!
I 've run into a small issue on IOS where the background above and below the cropping area on IOS is white instead of black.

Is it possible to tweak the colors?

Try changing your phone settings to use dark mode.


Icons

I was looking through to see what icons were included in the spectre.min.css file and it isn't clear, some of the code from the docs site do not work due to missing icons.  Are we expected to download Icomoons to use them?

Yes, I have the same question. It seems that currently Spectre.css offers a mix of Google Material icons and something from Icomoon.

@kaneschutzman @alexbagirov Icons Spectre uses is Google's Material Design icon set, and the icon font is created by Icomoon. I use it for Spectre Docs only. I will explain more in the future.

Hi @kaneschutzman @alexbagirov and others. I have added pure CSS responsive icons to the Spectre.css https://picturepan2.github.io/spectre/elements.html#icons


Add variable to insert additional supervisord options

Also generate uuid for default supervisord password through ansible

@andrewrothstein Could you review this PR? Thanks!

published to the galaxy as v1.0.18


[ansible] Support Security Best Practices

For a Kubernetes deployment to support production workloads, the cluster must be secure. The contrib/ansible project should support the ability to deploy and routinely verify the security measures applied to the cluster. Additionally, the security measures available and applied should be well documented for auditing purposes. It is recommended to use (DISA STIGs)[http://iase.disa.mil/stigs/Pages/index.aspx] as the reference model for security measures.

/cc: @stephenrlouie @adamschaub @rutsky


Implement secrets rotation

When secrets in external key vault is updated, sync controller should also fetch new data and update the Secret.
/kind feature
/assign

/remove-lifecycle stale
/lifecycle frozen


Add Filter by DfTxType in AccountRPCs

What kind of PR is this?:

/kind fix
What this PR does / why we need it:
Fixed issue with TxType filter in Account RPC
Which issue(s) does this PR fixes?:

Fixes #252
Additional comments?:

hmm.. some thoughts of me, the document (test) is not really completed.
so I wish you can add this to support to make your test more persuasive
use listaccounthistory as sources to compare your expected result
// set up
accHis = listaccounthistory()

// to assert the ''accountHistoryCount with no_rewards' count
accHisNoReward = accHis.map(acc => acc.type != 'blockreward')

// to assert the txtype count
accHisMintToken = accHis.map(acc => acc.type == 'MintToken')
accHisPoolSwap = accHis.map(acc => acc.type == 'PoolSwap')

// to assert the token
accHisNoReward = accHis.map(acc => acc.amounts... blah blah blah) .. this filter is more work because the data is like this '[ '33.33000000@DFI', <EMAIL_ADDRESS>]'

Perfect! @canonbrother. It will surely improve the testing.

hmm.. some thoughts of me, the document (test) is not really completed.
so I wish you can add this to support to make your test more persuasive
use listaccounthistory as sources to compare your expected result
// set up
accHis = listaccounthistory()

// to assert the ''accountHistoryCount with no_rewards' count
accHisNoReward = accHis.map(acc => acc.type != 'blockreward')

// to assert the txtype count
accHisMintToken = accHis.map(acc => acc.type == 'MintToken')
accHisPoolSwap = accHis.map(acc => acc.type == 'PoolSwap')

// to assert the token
accHisNoReward = accHis.map(acc => acc.amounts... blah blah blah) .. this filter is more work because the data is like this '[ '33.33000000@DFI', <EMAIL_ADDRESS>]'

Perfect! @canonbrother. It will surely improve the testing.

I will assign this to @aikchun #315 thanks everyone :)


Misprint in Commentaries within README File

I have noticed an inconsistency in the Code Evaluation section of the README, where the following command sequence is presented:
# For `Readability`
scripts/eval_c_maintainability.sh ${model} ${root}

# For `Efficiency`
scripts/eval_c_efficiency.sh ${model} ${root}

I think the first comment should be corrected to:
# For `Maintainability`

Thank you for your careful observation; we have corrected the erroneous comment.