[Frontend] Kill the server on engine death

Slight mitigation for #5901
This PR updates the open ai server to check for cases where the AsyncLLMEngine errors, and terminate itself when it does.
As I understand it, the goal of stopping the AsyncLLMEngine on unknown errors and not restarting is to prevent error loops where we try to restart the engine after an error that's really unrecoverable. However when we run into these issues in production, the server has to sit there responding with errors to all requests until a readiness probe fails, and then wait until the liveness probes fail enough times to trigger a container restart. This results longer downtime than necessary when we can instead terminate the server as soon as we know that the engine has failed.
This is implemented as a sigterm sent to the current PID which allows the uvicorn server to handle the signal and enter the usual graceful shutdown path.
There are two exception handlers added to the server. The first one checks for anything that extends RuntimeError, which I'm assuming will match most exceptions that kill the engine. This handler checks to see if the engine is dead, and kills the server if it is.
The second handler matches the AsyncEngineDeadError explicitly and immediately kills the server, to catch any cases that were not caught by the first handler. This could happen if the engine was shared with another module that accidentally killed it (not speaking from experience here or anything :wink:)

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@Yard1 I banged my head against a wall for a few hours trying to unit test this without massively refactoring the server or injecting a poison pill into the engine to trigger an error, and I'm ready to give up 😦. Do you mind merging as-is without tests?

@joerunde can you outline what you tried to do?

@joerunde @Yard1 Is this PR good to merge? We've been experiencing some issues lately where the engine dies but the server is still up and it hence doesn't restart the Kubernetes pod on its own. I'm hoping this fix will help us mitigate this issue!

@Yard1 @vrdn-23 Sorry for the delay, been focusing on #6883 instead.
I went ahead and just wrote a simple test that uses a bad lora adapter to crash the server. I tried both:

Subclassing RemoteOpenAIServer to use fork and then mock.patching out the real model loads and injecting an exception into the LLMEngine, but just ran into too many small issues to debug
Running the equivalent of vllm serve in a separate thread to be able to mock out the llm engine in-process, but that turned into 150+ lines of code to maintain for this one little test which I also did not want to foist upon the rest of the maintainers

@Yard1 It looks like the entrypoints tests pass, but other tests are failing with timeouts and it looks like I'd need to rebase main in order for the tracing tests to pass.
Do you want me to rebase and re-trigger the CI? I don't want to use up too many CI runs for this one little PR

@joerunde yeah let's fix the conflicts

Cool, yeah with the addition of the common launcher I went ahead and moved these exception handlers there so that they can have access to the server to interrupt it, and I also had to fill out the rest of the interface for the new AsyncEngineRPCClient

Added a little bugfix for an edge case I ran into after https://github.com/vllm-project/vllm/pull/7111/files#diff-4bd825485b5162cf8021da41a2ebd3d4026929e617d1137f69bbbe4bda0ee643R208

@Yard1 @njhill I think we're up to date with ci passing, mind merging?

Thanks again @joerunde!


Kubernetes installation tutorial

I want practical installation of kubernetes tutorial and video for me to test load balancer. Its  a load balancer at best . Instead of i hear all kinda nonsense terms. why humans make things complex? yes it may do other things but at its heart its a load balancer.

Kubernetes is an open-source platform that automates container operations for application deployment.
Some people use Kubernetes with load balancers, and that's quite common.
Perhaps https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/ was what you had in mind @alexk345 ?
/triage needs-information

/priority awaiting-more-evidence


sph_ifs_combine_data does not respect "nocenter" for SCIENCE frames

Whilst the "nocenter" option is correctly adhered to for FLUX and CENTER frames in sph_ifs_combine_data, it is ignored for SCIENCE frames, as the "if nocenter/else" check is missing for SCIENCE frames.

Actually it does respect the nocenter option, but I guess the documentation is not clear and the code is slightly confusing. The nocenter option disables the fine centering, but it still shifts the images by an integer number of pixels to make sure that the data is roughly centered. For ths IFS it doesn't really matter because the data is always more or less centered, but for IRDIS it is more important because the center of the data is not so close to the image center. I will clarify the documentation.


fix: prompt written answers in custom language

📑 Description
Changing language in the answer with default_prompt is not correct.
✅ Checks

[X] My pull request adheres to the code style of this project
[X] All the tests have passed

Thanks @winggundamth I am happy to change this, but I would say this is very dependent on the LLM being used. What was this tested with?

does current language prompt not works on that models?


nodejs and yarn are 4x slower on windows than ubuntu

npm and yarn are the bread and butter of package management for the nodejs ecosystem, of which react-native is a part of.
Yet, these tools are very slow and finnicky on Windows. There are many stackoverflow posts about people asking why yarn is so slow.
We feel this pain ourselves too (RNW team) and we hear it from people coming form mac OS or Android and wanting to add Windows versions of their RN apps.
I recently added a CI loop in github actions, that does the exact same thing for a popular 3rd party npm package I contributed to (envinfo): install yarn dependencies, build the typescript, run the package.
What I saw was that Windows took 4 times as long as ubuntu to do end-to-end install of the package and running it once.
I imagine part of it is that the yarn/nodejs implementation is suboptimal on windows, but it seems that even github actions is spending a lot more time doing things on Windows that aren’t “run the user’s code” than on Ubuntu.
What's worse is that the ubuntu virtual hardware seems a lot less powerful than Windows', so the actual measure is probably a lot worse than 4x.
Here are my measurements:
| ubuntu | Windows
-- | -- | --
Set   up job | 2s | 1s
Run   actions/checkout@v2 | 1s | 26s
Use   Node.js 10.x | 1s | 15s
Run   yarn | 43s | 2m 19s
Run   node --unhandled-rejections=strict src/cli.js | 18s | 1m 0s
Post   Run actions/checkout@v2 | 0s | 17s
Complete   job | 0s | 0s
Total | 65 | 258
  |   | 3.97x
  |   |
Machine class | Standard_DS2_v2 | Standard_D4_v2
vCPU | 2 | 8
Memory | 7 | 28
Temp storage | 14 | 400
Max temp storage throughput:   IOPS/Read MBps/Write MBps | 8000/64 (86) cached 6400/96 uncached | 24000/375/187
Max data disks | 8 | 32
Throughput: IOPS |   | 32x500
Max NICs/Expected network   bandwidth (Mbps) | 2/1500 | 8/1/6000

I'll be the first person to point out the deficiencies of the Windows platform to anyone who asks, but I really don't see how this is Microsoft's problem.
Further, before I fully respond, I'm a bit confused - your title states "nodejs and yarn" but your post states "npm and yarn". Are you referring solely to the package managers, or are you claming Node.js as a whole is 4x slower?
In either case, there's nothing stopping these applications from profiling and fixing bottlenecks on Windows. It is very clear that, at the foundational level, properly written software can perform just as well on Windows as other platforms. Having dealt with both the npm and yarn source code, both are in very large part bloated and unoptimized (npm especially).

Here's just some stats from both projects.
$ cd /src/npm/cli && cloc bin lib
     204 text files.
     204 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 1.82  T=0.55 s (372.5 files/s, 34479.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                     196           1984            886          15794
Bourne Shell                     4             14              8            117
DOS Batch                        3              8              0             36
Markdown                         1              9              0             28
-------------------------------------------------------------------------------
SUM:                           204           2015            894          15975
-------------------------------------------------------------------------------

$ cd /src/yarnpkg/yarn && cloc src bin
     167 text files.
     167 unique files.
       2 files ignored.

github.com/AlDanial/cloc v 1.82  T=0.50 s (330.3 files/s, 53159.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                     161           4270           2063          20177
Bourne Shell                     1              4              4             27
PowerShell                       1              1              0              5
DOS Batch                        2              0              0              4
-------------------------------------------------------------------------------
SUM:                           165           4275           2067          20213
-------------------------------------------------------------------------------

15-20 thousand lines of code without node modules being installed.
Further, in npm's case, the size with node modules is incredibly huge (yarn is about 1/6th the size in comparison):
$ ccd /tmp/npm && npm i npm && du -sh .
31M     .

What's more, you should also look at the platform abstract library that Node.js runs on top of - libuv. They have to emulate many parts of Unix on Windows for API compatibility,

While source code size isn't really a great indicator of what the program does, it's very clear there's a lot of surface area for things to be misused here. In my opinion, it's not Microsoft's job to profile third-party applications and provide speed improvements - especially when those applications are written with several layers of abstraction between them and the operating system in question.
You should, however, definitely bring these findings up with the npm, yarn and node.js teams respectively, as they should be the ones spearheading a profiling initiative if one is really needed.

thanks for your input @Qix- ! To answer your question as to why this is a problem for Microsoft: it negatively affects the developer experience of a Microsoft product (one that I work on 🙂), React Native for Windows. Folks coming from a JS background or from a react native on android/iOS background are often disappointed with how slow these tools are which they have to use when they want to port their app to Windows, so we want to make it better for people writing apps for Windows :)
Thanks!

Right, but just because something runs slow on windows, doesn't necessarily mean it's Microsoft's problem to solve. There are thousands of variables that could make it run slower. Unless you're arguing that Node.js as a platform, as a rule runs slower on Windows and not the individual applications built on top of Node (npm and yarn), then I don't see how this is a platform problem.
Npm is a fully-fledged company with funding and investors - if their commercial product is running slowly, they are fully capable of fixing it.

From my experience this appears to be related to disk performance: using npm to install new packages downloads and uncompresses lots of small files and Windows is not fast (to say the least) at creating lots of small files.
Disabling Windows Defender's real-time check mitigates the problem a little., but it remains very slow compared to other platforms (be it Mac or Linux).

I understand the arguments that everyone (that is, all the other package managers) could fix this themselves, but this is definitely in scope for what we want to be working on. We would rather fix as much as possible in the OS so that the benefits are "free", and then look at ways to help individual applications improve their own performance.
For example, we've been tracking Python and Git performance for a while now, and have already (quietly) released some updates that reduce overheads, which will naturally improve Yarn as well. We've also fed back some suggestions to the projects to help them improve things.
But we do believe that to a certain extent, POSIX code should be easy to port to Windows and maintain its performance. And since we're the only ones who can improve Windows itself, we're looking for ways to improve that "certain extent" before we turn back to giving advice directly to projects.

Great issue, thanks for filing @asklar, and as @zooba says, this is indeed a great example of the kind of issue we're looking for!
It's quite possible that there's something in the implementation or port of node/npm/yarn that is inherently slow on Windows.
As I've discussed at length in other issues (e.g. #15), POSIX-first apps do tend to suffer on Windows, for a number of reasons. We're very keen to learn all the reasons why, and to figure out what can be done to reduce/eliminate the root-causes of the perf issues for such apps.
We believe we have a pretty good understanding of the key root-causes, but want to be sure we're not missing anything unexpected.
So, we're measuring problem scenarios (on normalized hardware to minimize hardware-specific differences) and are working to figure out the root-causes of perf issues such as this. We then plan to work out where best to fix the issue - be it at the node/npm/yarn/libuv end, or in Defender/Windows/etc. ... or both!
If the issue lays entirely/partly in an open-source project, we're happy to do our part as members of the open-source community to work with project owners and other community participants to implement a solid fix for the issues we find.

Why does it take so long to delete node_modules in Windows? It seems like the OS could just delete the directory file system record, instead of scanning some 90k files to prepare for delete..

@nmoinvaz - are you trying to delete node_modules using File Explorer or from the command-line?
If the former, it's because File Explorer does a ton of work under the hood to enumerate & track all the files to be deleted, calculate and continually update estimated time to complete, etc.
Deleting these files from the command-line should be MUCH quicker:

PowerShell: rm node_modules -force -recurse
Cmd: del /s /f node_modules

Yes, in File Explorer. Part of the problem is if I accidently start deleting node_modules from the File Explorer dialog it takes a while to respond to even my cancel request.
Often times if a folder I am deleting is too big File Explorer, will ask me something like, "Folder is too big, deleting this will be permanent, do you want to continue?". Along the same lines, couldn't File Explorer ask me something like, "Folder has many files, do you want to quick delete it?"

@nmoinvaz I happen to have worked in file explorer for a number of years so I can tell you that often a "quick delete" is wrong in the context of the experience file explorer wants to give you. For example, file explorer needs to keep track of your often accessed locations/recently accessed files for showing them in Quick Access. Deleting a folder via file explorer means that now we have to go update the storage for this information, which takes additional time. The shell file operations engine is highly extensible, apps can register hooks to get notified when something changes, when files get deleted, etc. On top of that, as it was mentioned before, we have to do a first traversal to know how much stuff you have to know how to better estimate how long it will take. If you don't care about these features you can del or rd the folder as it was suggested.
Having said that, file explorer and features of the shell are outside the scope of this repo's issues :)

Having said that, file explorer and features of the shell are outside the scope of this repo's issues :)

Perhaps, but we've got file system folk handy (on internal threads) if there are ways we can change both sides at once. And I can't imagine any user being upset by delete (especially recycle) being quicker. We're not talking about milliseconds worth of improvements here, but minutes worth of "progress" which prevent the top-level folder name being reused until it's done (which is really what we want to do - the actual files can silently delete in the background over the next hour for all we care, provided we can put a different node_modules directory in its place).
@bitcrazed is the centre of the web, so he can pull together those responsible for a chat.

@bitcrazed should I file a new GH issue or no?

@nmoinvaz - I was about to reply with a polite ask to please file new issues in their own issue rather than piggybacking on existing unrelated issues 😜
Please do file another issue and I'll summarize the points above in reply to your issue description.

npm is owned by GitHub which is owned by Microsoft so there should be a case where it is in Microsoft's interest to make npm faster on Windows just to address the concerns at the start of the conversation. That case however must not be in Windows itself, which kinda makes this issue questionable in terms of scope.

I guess it's related so I put that here but I can create another issue if needed.
To show how slow Windows is at creating lots of small files, I downloaded the Firefox sources. Since it's a tar.bz2 file, I first uncompressed the .bz2 file to get the .tar file and all tests were done using this file as a source. It's 852mb file that flattens to a directory containing 119 954 files.
I know it's an extreme case, but it's not rare having to deal with thousand of small files when working with npm, git, development, etc..
I added macOS results (running on a slow MacBook with a core m3) as a comparison.

Operation
Windows 10
Windows 10 (RealTime protection disabled)
Ubuntu (WSL2)
macOS

flaten tar file
30m
1m45s
15s
50s

delete directory
1m
45s
5s
14s

The commands I used were:

Mac & Linux: time tar -xf firefox-40.0.source.tar and time rm -Rf mozilla-release
Windows: firefox-40.0.source.tar and rmdir /S mozilla-release (I measured it myself since I found no time equivalent)

I am sure that improving these file operations will benefit to a lot of different Windows use cases:

installing Windows apps
installing dev packages, like npm, ruby gems,...
git operations on large respositories
apps like VSCode that need to deal with lots of files
installing Windows updates
...

@Stanzilla - it's in everyone's best interest that Microsoft enables all applications to run as fast as they can on Windows, without having to suffer unexpected perf issues, hence this repo and the program of work backing it ;)

@warpdesign MANY Thanks for your detailed post, but PLEASE don't piggyback on what may appear as a vaguely related issue, and instead file new distinct issue for the specific issue at hand (e.g. "Windows file/IO perf is slow when handling many small files").

while it may not be Microsoft's responsibility to fix the performance issue with X its MS' problem as I've seen enough people being like "I moved to Y (often being Linux but sometimes also Mac) cause X was slow on Windows"
A gentle nudge from a big company can do miracles sometimes, and if that doesn't help there's always chance to contribute (like MS already does to many open source projects that may or may not be used in their products), it works pretty much the same way as leaving exceptional ways of handling broken software that called undocumented kernel functions to not hurt customers who rely on that piece of software.

while it may not be Microsoft's responsibility to fix the performance issue with X its MS' problem as I've seen enough people being like "I moved to Y (often being Linux but sometimes also Mac) cause X was slow on Windows"
A gentle nudge from a big company can do miracles sometimes, and if that doesn't help there's always chance to contribute (like MS already does to many open source projects that may or may not be used in their products), it works pretty much the same way as leaving exceptional ways of handling broken software that called undocumented kernel functions to not hurt customers who rely on that piece of software.

Yep - which is why we're particularly keen to identify reproducible perf issues - so that we can root-cause the issue and either fix whatever is the root cause if within Windows itself, and/or work with projects/partners to fix and improve things in their stuff too.

Yep - which is why we're particularly keen to identify reproducible perf issues - so that we can root-cause the issue and either fix whatever is the root cause if within Windows itself, and/or work with projects/partners to fix and improve things in their stuff too.

It's unusual for folks to argue against us fixing something 😂, usually it's the other way around

It's unusual for folks to argue against us fixing something 😂, usually it's the other way around

@asklar THIS! ;)

@asklar THIS! ;)

Yeah, in my experience windows is rubbish for node development. Either its slow, or the node-gyp issues which are just painful.

In apple m1 max it is even better it only takes 68 seconds. this project is react with 16000 ts/tsx files.

I stopped working directly on windows FS and moved all my code to WSL2 with dev containers. I know not all workflows will fit this, but this is much better than doing npm i natively, for example rm -rf . Whatever emulation overhead you get it's more than balance by the sheer speed of the Linux filesystem.
The biggest plus is that you still get to use Windows, and all the goodies that come with it (steam, office, ransomware).
This is even better for folks that work with python, because each container can have it's dependencies pre-installed, no need for switching environments.
Downside is that you'll need a bit more ram, but the WSL2 vm is VERY VERY lightweight.
https://github.com/microsoft/vscode-dev-containers

Really looking forward to see if the new Dev Drive feature improves performance for this scenario! 👀

For the uninitiated, such as myself: Dev Drive documentation 🙂

@asklar, I've seen some discussion in this issue about deleting node_modules, but I haven't seen much discussion about copying a folder with tons of small files. Any idea why running xcopy .git ..\.git  /s /e /h /v /i /k /r would be 50% faster than copying via File Explorer?
My setup:

Copying from a non-OS partition to the same non-OS parition (Due to @zooba's comment at https://github.com/microsoft/Windows-Dev-Performance/issues/87#issuecomment-1533839419)
Windows 10, build 19045
.git is ~8.5GB with ~18,000 files.
Copying with File Explorer takes ~45 seconds.
Copying with xcopy .git ..\.git  /s /e /h /v /i /k /r consistently takes 30 seconds

Actually, maybe that whole question should have been for @zooba, sorry 😆

@Bosch-Eli-Black same reasons I described above apply to copy, delete, etc. File Explorer does a lot more than the file system operations; whether that is desirable or not is a question about whether you want the additional features/UX that it enables :)

Thanks, @asklar 🙂  I can see how those reasons would apply to delete operations, but I'm having a hard time envisioning how they would apply to copy operations, since it seems like copying wouldn't need to update Quick Access, jump lists, etc.

@Bosch-Eli-Black same reasons I described above apply to copy, delete, etc. File Explorer does a lot more than the file system operations; whether that is desirable or not is a question about whether you want the additional features/UX that it enables :)

maybe we could add a toggle to disable these things during long operations? I don't really need estimates or speed or even items counter, if I have to perform an operation it needs to take as long as it needs and it won't change anything for me, and if that helps making things faster I'd gladly opt-out, this includes emitting events if possible
and personally I opted-out of all MRU I could globally so maybe that doesn't need to be touched either?
and yeah, it's not directly related, but do we have pre-existing issue to track possible improvements to explorer-issued operations?

I can see how those reasons would apply to delete operations, but I'm having a hard time envisioning how they would apply to copy operations

The ability to see progress and cancel the operation is typically what adds the most overhead. It shouldn't be terrible at a per-file level, but when you include the progress callbacks at all, a number of kernel-level optimisations have to be skipped/hampered (see CopyFile2 for some more context around what I mean).
After that, the difference is probably that Explorer resolves via the shell (which includes the file system, as well as a range of potential shell namespaces) while xcopy only supports the file system. Essential for many applications (e.g. copying from a camera over MTP) but does add overheads.
Also worth noting that in the general case, progress indicators make people feel like the operation is quicker, even if it's technically slower. So guess how to reduce the number of complaints about slow copies 😉

For the uninitiated, such as myself: Dev Drive documentation 🙂

Wish I could've mentioned this to you on the other thread, but we had to wait for the announcement! Dev Drive has a few additional benefits over just being a separate volume (and ReFS has some of its own perf wins over NTFS), so would recommend using it when you can.

pre-existing issue to track possible improvements to explorer-issued operations
@zakius can you please file a bug in feedback hub so the file explorer team can look at this feature request?

it seems like copying wouldn't need to update Quick Access, jump lists, etc.
@Bosch-Eli-Black unfortunately most - if not all - file operations need to touch the MRU/quick access lists. You copied a file, so it indicates that the source file is something you care about, so we "give it an extra point" in the relevance algorithm.

Agree with @zooba re: copy callbacks (a lot of work happens in each callback, actually) as well as the extra features the shell namespace exposes.

Wish I could've mentioned this to you on the other thread, but we had to wait for the announcement! Dev Drive has a few additional benefits over just being a separate volume (and ReFS has some of its own perf wins over NTFS), so would recommend using it when you can.

@zooba No worries! 🙂
In the meantime, I took your suggestion from the other thread, and well... wow, what a difference it makes! I'll reply to that in the other thread, though, so we don't spam too many people here, haha. (https://github.com/microsoft/Windows-Dev-Performance/issues/87#issuecomment-1533839419, for those who are interested. Definitely worth checking out 🙂)

At its core, the performance of the NodeJS package manager (npm, pnpm, yarn) come down to the performance difference in extracting a TAR to disk on Windows vs. Linux. You can experience the performance gap even with C:\Windows\System32\tar.exe vs. /usr/bin/tar.
The fundamental operation in this scenario is creating lots of directories and files and populating said files with data that is already present in contiguous blocks of RAM. On Linux, the only syscalls used are mkdir, open, write and close, with cost dominated by open.

Really looking forward to see if the new Dev Drive feature improves performance for this scenario! 👀

By any chance did someone try this ?

@gethari I've tried it, and it seems to help quite a bit! 🙂
Specs:

Windows 10
Laptop, plugged in, throttling (battery) set to "Best performance"
Both C: and D: are on the same SSD

C: has operating system and is NTFS
D: is ReFS

Results of running yarn install:
C: (NTFS): 22s
D: (ReFS): 9.8s
ReFS is 55% faster than NTFS in this case 🙂
This was done on a project where all of the .zip dependencies were in the yarn cache, so essentially yarn is spending all of its time creating and populating node_modules\.

Nice!
Would be interesting to see the difference with wsl2/native linux/other os.

Something I should mention:
I haven't seen any indications that these speed ups are from using ReFS. As far as I can tell, the speedups are from having my code on a non-OS partition. See https://github.com/microsoft/Windows-Dev-Performance/issues/87#issuecomment-1533839419 and https://github.com/microsoft/Windows-Dev-Performance/issues/87#issuecomment-1534958991 for more details.

I wonder what would be the reason behind this and if that can be somehow reduced


findInterval needs vec that is sorted non-decreasingly

Hey there,
In calc_timingAverage.R (https://github.com/USGS-R/EflowStats/blob/23a680d8a4c657674828bc5d32f2d6a887f14fbb/R/calc_timingAverage.R):
       #...using findInterval
        break_pts = c(.1, seq(0.25, 2.25, by=.25)) * log_meanFlow
        x$interv = findInterval(x$log_discharge, break_pts)
        colwellMatrix = table(x$day, x$interv)

If discharge values are low and then log-transformed, all values will be negative and thus ordered decreasingly, throwing the following error:
Error in findInterval(x$log_discharge, break_pts) :
  'vec' must be sorted non-decreasingly and not contain NAs"

Which stops the calc_allHIT computation.
It could be solved by simply adding:
x$interv = findInterval(x$log_discharge, sort(break_pts))

@messamat -- see linked PR -- that's what you were after, right?

Hi, I still encountered the same error and found the suggested code was not updated yet.
x$interv = findInterval(x$log_discharge, sort(break_pts))

Hi there ... I am getting the same error message in the calc_timingAverage function with some datafiles but not with others. I've attached a few test files that cause this error.  These all have discharge values < 1, so perhaps it is the same problem?
test1.txt
test2.txt
test3.txt
test1.txt


Heat-map based on a new field which is sum of multiple fields

I have read the issue guideline note but I am really having trouble reaching ArcGIS support in anyway. So I am posting a question here.
I have a service that gives a layer such as this one: https://services6.arcgis.com/Wwv1InPxRQv6NCzu/ArcGIS/rest/services/WIOA_Public__2_year/FeatureServer/0.
It has many fields. How do I use the JS API to dynamically display a heat-map with color based on the sum of two or more fields?
(E.g. say I want to add "Associate_s_degree" to "Bachelor_s_degree" resulting a sum field which will be used for determining color. It does not have to be strictly creating a new field on the fly if that's impossible. As long as I can display the color of polygon for each heat-map feature based on the sum of multiple fields for each feature.)
Thanks.

No longer relevant.

Hi @fnick851 - thank you for your interest in the ArcGIS API for JavaScript.
As mentioned in the issue guideline, if you have generic requests for assistance with the ArcGIS API for Javascript, it's better to use one the below avenues.

Esri Tech Support - https://support.esri.com/contact-tech-support
the Esri community on GeoNet - https://geonet.esri.com/community/developers/web-developers/arcgis-api-for-javascript

We welcome feedback and questions related to the TypeScript definitions and other files in this repository here.
Cheers,
Bjorn


Markers flicker when scrolling on the map, React 18

Markers displayed on the map is causing flickering on moving,
When we downgraded React to V17 is works fine, using rendering the App using ReactDOM but it will have some unexpected behavior in our components, so it's still not clear how can we remove this effect.

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.
@RamiShahazeh Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

@thepuzzlemaster We're committed to React support, more deeply than this wrapper. Stay tuned!

Hello @wangela
That's a great news, but is there a timeline we should be expecting?

Any updates on this?

Any updates on this?

Bumpity bump, also facing this issue

Sorry I didn't remember to follow up here! For better Markers support in React, try https://github.com/visgl/react-google-maps (context at https://mapsplatform.google.com/resources/blog/introducing-react-components-for-the-maps-javascript-api/)

As for this issue, I'm not convinced that this has something to do with the wrapper component provided by this library. Can someone create an example (codesandbox or similar) that demonstrates this issue so I can look into it?


Connected Server asks for credentials in Object Explorer

Steps to reproduce -

Open Connection Dialog to make a new connection. Intentionally connect to a non-existent server with a new server group.
The connection fails but the Server Group is made anyway. (This is another bug).
Open Connection Dialog again to create new SQL Login connection with no password saved.
Drag and drop the newly made connection to the group that was made in step 1.

Expected - The server is under the group and nothing else changes.
Actual - The server is under the group but gets in a disconnected state (with red dot) with nodes expanded, and opens Connection Dialog again to make a connection.

I could not repro this bug on current builds.  I was not able to add a server to the Servers list if it failed to connect in Connection Dialog as described in the repo steps.


Pr/teleport fix

Fix #141
Teleport back to original location after auto-login and teleport to safe location on /logout.

Thank you very much.


add script to generate bindings

@homunkulus r+

:pushpin: Commit c93dd61 has been approved by japaric

:hourglass: Testing commit c93dd61 with merge c93dd61...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing c93dd614fdab5ad69845ea7212a8a220ba2690b0 to master...


⚠ Bofrost.lu has degraded performance

In cc2312c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 816 ms

Resolved: Bofrost.lu performance has improved in db1dde0.


enable to choose "multipart_upload" as true or false

I enable to choose "multipart_upload" as true or false.
Users who use object storage which does not support multipart upload as blobstore will be helpful.
fix https://github.com/cloudfoundry/bosh-cli/issues/253

Hi @cappyzawa,
Could you let us know which blob stores you've encountered that do not support multipart upload?
In general, the PR looks good.
Please make sure to fill out the CLA so we can continue reviewing this PR.
Thank you!
Best,
@pivotal-mp && @dpb587-pivotal

@pivotal-mp Hi.

Could you let us know which blob stores you've encountered that do not support multipart upload?

Our company uses the original S3 compatible provider, but it does not support multipart upload😓
If there are other users with the same circumstances, this PR will help them.

Please make sure to fill out the CLA so we can continue reviewing this PR.

I sent email for accepting individual CLA, but it's not responding...

@pivotal-mp My Account has been added to a whitelist.
Thank you for your review.


SSL certificate domain

There are some weblinks out there pointing to neomutt.org, but the SSL certificate does not include this domain. Either that domain should somehow forward to the neomutt.github.io address (without an intermediate SSL error) or the canonical domain should be updated. Right now lots of users are just blocked from reaching the site due to the error.

Hi @alerque

pointing to neomutt.org

Did you mean www.neomutt.org ?
We dropped the 'www' over two months ago, when GitHub adopted Let's Encrypt.
The certificate covers 'neomutt.org', but not the 'www.' part.
GitHub only allows us one or the other (even though LE now supports wildcard certs)

domain should somehow forward

Unfortunately, we don't have any control over that: GitHub host the site.
You can't view the bare: neomutt.github.io address.

Right now lots of users are just blocked from reaching the site due to the error.

Sorry.  We did our best to notify everyone in advance.
We fixed all of our links and prompted everyone to do the same.

It appears I was following a link where the user facing text was neovim.org but the href was hard coded to www.neomutt.org. I added a security exception to load that domain to see what was going on but did not then notice that it forwarded me to neovim.org where the cert was correct. I understand there is not much you can do about that issue, please disregard.


OpenPecha Docs

[x] setup mkdocs
[x] add introduction of OpenPecha
[x] what is base and layers
[x] layer format
[x] types of annotaions and format

done


Be able to search by city

For now, we can search by อำเภอ เขต(District) except จังหวัด(City)

I can help!

@iboss-ptk Thanks! Let’s continue this on #69, this issue is duplicate.


Unit tests

In this project, my partner @ZahraArshia and I implemented the following;

Add unit tests to your classes:

[ ] Book

[ ] Person

[ ] Student

[ ] Teacher

[ ] Classroom

[ ] Rental

[ ] All classes that you created while implementing the Decorator design pattern

Hello, @GzimAsani thanks for the review. I believe we have, could you at least point out which ones we haven't please?

Thank you @Mihndim2020


theme: simplify stylesheet for color variants

Creating color variants currently requires copying a lot of boilerplate styles. Let's get rid of this.

Maybe also interesting, HSL colors are often better for creating variants. You can change the hue value or just the saturation or lighting to change one aspect of a color.
https://github.com/matcornic/hugo-theme-learn/issues/483

Sounds interesting. I lack knowledge regarding CSS colors. So if you want to work on it, it may be interesting to have a second accent color for coloring the links.


App Service Resource Detector

Description
Add resource detector for azure app service.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-monitor-opentelemetry-exporter

Moving to https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/resource

https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1901


An error occurs when creating a static web app on Mac

OS: M1
Build Version: 20230814.4
Regression: Not a regression
Repro Steps:

Open the ReactSite project in VS Code.
F1 -> Click "Azure Static Web Apps: Create HTTP Function..." -> Enter the default name.
Create a static web app.
Check whether no error occurs.

Expect:
No error occurs.
Actual:
An error occurs.

More Info:
This issue does not reproduce on Windows.

Verified this issue with the latest build 20231031.1, it also reproduces on the Remote Codespaces environment.


Infinity, Negative Infinity, and Not a Number output values

According to the SCPI specification, Infinity, Negative Infinity, and Not a Number each have special floating point values which should be returned to the user, however the parser will return strings of "INF" or "NAN" (minus the quotes) in these cases. Is this intentional, or would you agree that this is incorrect with respect to the standard? (See section <IP_ADDRESS> of the SCPI-99 standard specification)
@j123b567, if you agree, I can create a pull request to fix this issue, however this may be considered a breaking change since current users are likely parsing the output for INF or NAN to determine these special cases rather than the 9.9e+37, -9.9e+37, and 9.91e+37 special values defined by the standard. For my customers, we have determined that the special float values would be better, probably for the same reason the standard specifies them, which is that the return value can always be parsed as a double, making the programming easier for our customers.
Feedback would be much appreciated!

Handling of standard C NaN and Inf will be always better and easier for programmers, so this change is welcome.
Just some hints, floating point support is problematic for me, because every architecture and compiler impleents them differently. Yes, there is C standard and an IEEE 754 but not all parts are mandatory and not all compilers obey them. And there is IEEE 488 and SCPI defining something different or some subset.
So, please, take this into account.
I have created some macros to test nans and infs in the past (useing native support or fallback to naive implementation). Please, use them or extend/fix them as needed.
Please use native compilers definitions of NaN an Inf where possible and not some single precision constants defined in SCPI. I would like to support double precision numbers even if they are not defined in SCPI.
Please also take into account, that it should work on e.g. 8-bit AVR, where in AVRGCC only float exists (doube is mapped to float), it should be agnostic to Little and Big endian architectures and it should be possible to exted the support to some other compilers, like C compilers for PIC16/24, proprietary compilers for ARM, NI LabWindows/CVI, MS Visual C etc.

Wow, this sounds like a much bigger task than I had originally imagined. I was simply thinking I could change the SCPI_dtostre function (here) to return floats instead of "NAN" and "INF". You've alerted me to the fact that there are systems that don't use that function.
However, looking at it again, it seems that I could still simply insert a comparison into each of the SCPI_FloatToStr and SCPI_DoubleToStr functions to compare the float value against INF or NAN, and short circuit the function when these values are found by returning the appropriate string for each value (i.e. "9.9e+37", "-9.9e+37", and 9.91e+37").
So the implementation of SCPI_DoubleToStr would look like this:
size_t SCPI_DoubleToStr(double val, char * str, size_t len) {
if(SCPIDEFINE_isfinite(val))
SCPIDEFINE_doubleToStr(val, str, len);
}else{
if (SCPIDEFINE_isnan(val)) {
strcpy(str, "9.91E+37");
} else {
strcpy(str, "9.9E+37");
}
}
return strlen(str);

}
Would this do it, or am I missing something?

It seems that it is not so easy.

Please, don't use these constants in functions using Double in name an leave them as nonstandard extension to SCPI. Change only functions using Float in name.

SCPI_ResultFloat should be fixed to return these specific values instead of nan and inf. It should also return any number larger then these as inf. SCPI constants are completely nonstandard from IEEE 754 point of view and may be confusing nowadays. I must investigate, if it is legal to return mnemonic INF and NAN instead.
Modification of SCPI_FloatToStr may or may not bee good place to solve this.
Please use "safe" versions of
funcions like strcpy vs. strncpy.
I'm not sure if SCPIDEFINE_isfinite is false for NaN.

SCPI_ParamIsNumber should be fixed to handle inf and nan as number

SCPI_ParamToFloat should handle inf and nan properly. It should also limit the range of larger numbers. It should convert 9.9e37 to native IEEE 754 inf and so on.

SCPI_ParamToDouble should correctly handle inf and nan but should not obey the SCPI limits. It should be highlighted in the doc as nonstandard extension to SCPI.

SCPI_ParamNumber should be probably reworked, but it can't simply use Float versions of functions instead of Double ones because of limited range of float numbers. (or can? It needs some investigation)

SCPI_NumberToStr should be reworked to properly limit range, handle nans and infs, etc. Using just Float version instead of Double version is not a solution for this.


Reimplement fixed types like types in magma

Each named type would have a metatable of ops that Systolic values could be dispatched to. ie. do plus on a FIXED type, it would dispatch to the type's metatable, which would then return a systolic value.

One issue with this is that we want the module signatures to actually match the type. IE if fixed:add dispatches to uint:add, we do want the result of the add to be a fixed type, not a unit. How does that work?

It seems like this is just a code organization change w/o any savings of complexity. We could either write 1 typechecking fn with switch statement on type, or N types that are dispatched to. Closed b/c  this doesn't clearly provide a complexity improvement.


Default devtoolModuleFilenameTemplate is not a good default

The current default for devtoolModuleFilenameTemplate and devtool: "eval" is webpack:///[resource-path]?[loaders]. This renders a question mark at the end of the filename in stack traces (at least on Chrome). Clicking on these links doesn't reveal the file in the devtool.
Just use the given configuration, throw an exception and try to click on the filename in the console.

Is this relevant still?

Yes, it's still relevant, but it should be merged with #2395. Let's continue there.


Twisted Integration

Hi there!
I'm currently trying to get the Twisted integration example you provided to work, but I', running into a few issues.
First of all: when I'm trying to connect to kdb the line self.transport.write(self.credentials + '\3\0') throws an TypeError telling me the "Data must not be unicode". So I tried changing it to self.transport.write(str(self.credentials + '\0').encode("utf-8")) (not the most sexy solution, I know) and the error disappeared... But as it usually goes, another showed up.
This time a TypeError with cause "not all arguments converted during string formatting" popped up, and I do not seem to be able to find where It is coming from. Is this about data that's coming from kdb that is not being converted, or outgoing data?
The kdb database I'm currently working with has no users so I did not provide a username and password --> factory = IPCClientFactory('', '', onConnectSuccess, onConnectFail, onMessage, onError).
Could that be in the way of succes? I'm a bit clueless..
Thanks in advance!

Regular string injection like so: `"%s\0" % self.credentials' worked.. My bad...

 As a User I would like to share a video of my choice on social media so that I am able to recommend it to my followers or leave social commentary


General Settings

[x] View type
[ ] Expanded toolbar menu
[ ] Floating action button
[ ] Notifications
[ ] Sub post notifications
[x] Default sorting
[x] Default comment sorting
[ ] Force english?

Notifications need to be implemented, see #10 and #35

Should we do expanded toolbar menus? Looks a little cluttered on iOS vs the setting on Android

Because notifications in iOS don't work well as timed events like they do on Android, I will be nuking the sub post notifications setting and leave basic support for mail notifications


Remove spd_log.h from log.h header file

It's impossible to remove spdlog/spdlog.h from log.h due to messy templates reference problems from C++


Latest versions are confused

Hi, the web application cannot be started with the latest update.
The following versions are confused.

Microsoft.AspNetCore.Components.WebAssembly: 7.0.13
Microsoft.AspNetCore.Components.WebAssembly.DevServer: 7.0.13
SiemensIXBlazor: 0.4.2

Can you check please.

Hi @aydoganemsiz, could you share your dotnet version and Visual Studio version?

Ofcourse,
.NET 7 and VS 2022.

I mean version details. You can see the detailed version of dotnet with dotnet --version command. You can find detailed version info of Visual Studio from Help -> About Microsoft Visual Studio tab.

I mean version details. You can see the detailed version of dotnet with dotnet --version command. You can find detailed version info of Visual Studio from Help -> About Microsoft Visual Studio tab.

.NET Version: 7.0.400
VS 2022 Version: 17.7.3 (VisualStudio.17.Release/17.7.3+34024.191)

Please update your dotnet version to 7.0.403 and Visual Studio version to 17.7.6.
In the next release (0.4.3) we will update our dependencies to 7.0.13

Hi,
I tested it with the versions you suggested.
The project was started but AG Grid did not work and gave the attached error.

Looks like the error is coming from Tabs component. Could you open a new issue about it?


Adds Versioning App Setting

Description
Adds a new app setting value for the versioning policy. This PR follows the draft PR #2237.
Related issues
Addresses AB#81153.
Note: there is a story to remove support for the VersionId property when the versioning policy is set to no-version (AB#85363)
Testing
Manual testing. Automated tests are in the works: AB#85366.
FHIR Team Checklist

✅ Update the title of the PR to be succinct and less than 50 characters
✅ Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
✅ Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
✅ Tag the PR with Azure API for FHIR if this will release to the Azure API for FHIR managed service (CosmosDB or common code related to service)
✅ Tag the PR with Azure Healthcare APIs if this will release to the Azure Healthcare APIs managed service (Sql server or common code related to service)
Review squash-merge requirements

Semver Change (docs)
Feature (enabling new feature functionality)

/azp run


SwitchListTile and CheckboxListTile will need a selectedTileColor as well

Use case
For consistent look of all the tiles in a list, specifically in drawer, but valid for other cases.
I saw that there is a PR  #67135  closing #67063
Which adds a tileColor to the SwitchListTile and CheckboxListTile.
I would use it to represent the checked state with an additional background, currently the selected boolean controls if the 2 tiles are in a selected state which applies the primary color to the text and the icons in the tile.
and tileColor have to be manually changed according to the selected State.
Proposal
It would be nice if the selectedTileColor is exposed for SwitchListTile and CheckboxListTile,
so we don't have to change that mannually.

@talamaska I would like to work on this issue.

CC @darrenaustin


ctag support

https://trac.calendarserver.org/browser/CalendarServer/trunk/doc/Extensions/caldav-ctag.txt
We'd have to figure out server support first, and especially whether we can detect non-support in Radicale.

There is an unsolved question with this RFC, and it probably applies to #26 too:
It doesn't seem to be possible to "atomically" get a new ctag after modifying collections, leading to race conditions:

vdirsyncer makes its separate requests for uploading, deleting, etc.
Some other client chimes in, probably synchronizing too. Also modifying items.
vdirsyncer fetches its ctag

Vdirsyncer is now out of sync, however, it has the latest ctag. Any following synchronizations will be skipped because of the up-to-date ctag, and vdirsyncer will only start getting synchronized again after the ctag changes again.

The opening paragraph deprecates this RFC in favor of WebDAV sync, which is tracked in #26


Docker wishlist

remove requirements.txt
only copy required files
add suppercron

running as a different user
building for ARM?


Can't install --> "Failed setup: Modbus/TCP connect to <IP_ADDRESS>:1502 failed"

Describe the bug
I have static IP address of my SE 17k, on WiFi network. With Energy meter. Ping work all the time.
MODBUS is enabled on ID 1, port 1502. Of course, Solaredge cloud platform is accessible and works.
Have no idea how to test this issue, where to start etc. - maybe switch from Wifi to Ethernet port ?
Expected behavior
Maybe more in-deep error description.
Screenshots
No response
Diagnostic File

Debug logs
No response
Home Assistant Version
2024.7.3
solaredge-modbus-multi Version
2.4.18
Installation Type
HAOS
Read the Instructions

[X] My configuration follows https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Configuration
[X] I have read the Known Issues https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Known-Issues
[X] This issue is not about a template error (do not report template errors, read https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Template-Design-Notes)

Additional Context
Btw: in search of solution i tried another Solaredge solution from @binsetsu "SOLAREDGE MODBUS TCP" and it starts immediately with same IP, with WiFi network, same MODBUS configuration, etc... !
So now i'm really confused. Then i reinstall HAOS and give another try to Solaredge Multi- again same error: Failed to connect..

I don't know what the difference would be. Many people use this one successfully.
Remember only one connection to the inverter is allowed.


DO NOT MERGE Unpin microk8s

BTW, @carlcsaposs-canonical , does your test-results showed we can unpin microk8s everywhere but one failing case?
https://github.com/canonical/mysql-k8s-operator/actions/runs/3704034527


TCP echo server is good, but where is Unix Socket echo server?

I'd like to test it with named pipes, but can't to find any working example with named unix sockets server and client.

Hi!
We can use pipe-echo-server
But you are right, we need more examples. I will add them.

Done.
We can compile the examples for pipes/unix domain sockets like this:
gcc echo-server.c -o echo-server -luv -DUSE_PIPE_EXAMPLE
gcc example2.c -o example2 -luv -DUSE_PIPE_EXAMPLE

Thank you.


tasks/procedures: raw_context def

A tag/def to read the raw input context of a task or procedure.

didn't you add this already

Yup.


Deprecate TRAPI v0.9.2 support

Should have /query endpoint have the same implementation as /v1/query.
Probably should use regex when specifying routing. e.g. (v1)?/query
See expressjs routing mechanism: https://expressjs.com/en/guide/routing.html

Current implementation: '(/v1)?/query'
It works, now /query and /v1/query endpoint have the same behavior.
However, the problem is SwaggerValidation no longer works.
It seems the Swagger Validation middleware we currently use don't support regex as route path.
Need to explore other options to facilitate that.
https://www.npmjs.com/package/express-openapi-validator

closing since it's probably not relevant now.


Error trying to load module with #module directive

Getting this error when loading the loading using a #module directive instead of using packages.config
Error: Method 'get_Tasks' in type 'Cake.MyGet.Module.MyGetEngine' from assembly 'Cake.MyGet.Module, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.

Looks like this might be related to changes in Cake.Core 0.28


don't seem to have a "model directory" Feedback for “Models”

where or how do you install the additional models that don't populate when running app? where is the --model entered if you used the 1 step windows zip file and have a .bat file? I'm watching a video about adding models with --model but I have nowhere to enter it.

I found it. My bad. I didn't think it would be on my C: drive under user

How to install though? Doesn't look like a git clone install into folder scenario

Running win_config.bat will open the web config page in your browser.
You can enter the model name in the Current Model. Model will be automatically downloaded the first time it is used.

You can also set the directory for downloading models in the settings


The sound icon appears over the liked sounds icon

The sound icon appears on top of the liked sounds icon.
To reproduce the error, just play a song in the liked sounds list.

What in tarnation

Well @GastonKhouri it suppose to be a now playing liked songs playlist (when you click it song will pause) (its a functionality not a bug)but we will replace that volume icon with a pause icon in near future
And thank you for reaching out bloom-community

fixed by @SunsetTechuila


After clicking backup seed (with/without locked wallet)

If the wallet is locked, change the text for 5 seconds to something like this:
"Wallet is locked, unlock it to enable the backup"
Then, after the 5 seconds, change the text back to "Backup/Clicboard wallet seed"
Instead, if the wallet is already unlocked, change the text for 5 seconds to something like this:
"Now paste it in a safe place"
Then, after the 5 seconds, change the text back to "Backup/Clicboard wallet seed"

https://github.com/clemahieu/raiblocks/commit/5072a14dd6ad982bdb77c6a7ce4b911de04c438b


bug: under constrained segments

Bug Report
Kakarot version
We need to revise in the whole code base places where we allocate segments and then "fill" them with utils like RLP.decode or load_packed_bytes to make sure that the segments are actually constrained.
We also need to make sure that every arr is used with the proper arr_len to use the right segment arena

For more context: rephrasing explanation in TG messages to ensure I understood well the problem and what is asked of this issue.
In the codebase, when a segment assignation is needed, it can be of 2 forms:
let (arr: felt*) = alloc();
let arr_len = foo(arr, data_len, data);

or
let (arr_len, arr) = foo(data_len, data)

If there is no need to fill an already existing segment or no need to assert depending of the function call (like RPL.decode which will have different assert depending tx type). The first form can be refactored to the second one for better guaranties by checking arr_len.
For form 1, we need to check that the returned segment is properly constrained
For form 2, we need to check that arr_len is properly checked and correspond to what is expected.
For the form 2, it can be tricky, as a function can return it and the arr_len would be check in a completely different part of the codebase.
I think we should be several to do the check of the codebase as it can be easy to miss some.

Did not found an undercontrained example on my end on first pass
Will do an other one after a step back

example of un underconstrained function is
https://github.com/kkrt-labs/kakarot/blob/a7af5dec26cea8fd191c8a2e98548ca19de7ee43/src/utils/rlp.cairo#L21-L57
where the data_len is not used so that when data_len = 0, [data] can be filled arbitrarily

and following usages like
local len_bytes_count = prefix - 0xb7;
let string_len = Helpers.bytes_to_felt(len_bytes_count, data + 1);

we need to make sure that data_len > len_bytes_count
etc.


Equipping a second ring drops ignite dps

https://pastebin.com/pw2gMGTQ
I was making this build, and for some reason equipping a second ring has lost me a ton of ignite dps.


PowerRun Feature request - currency

PowerRun is fantastic, and I have missed it every time I switch from Mac to PC.
I can search programs on my computer, and I can do simple calculations such as 9*3 and 5+2 and similar.
Would is be possible to add web search and currency calculations?
Entering for instance "10DKK" should result in conversions to 5 top currencies and the one from you locale settings in Windows.
Web search should be either default Google, or for instance "g " to search Google, "b " to search Bing,  "w " to search WiKipedia, "d " to search DuckDuck and "y " to search Youtube

Seen both these requests often before. See #3376 part 3.
The last part of your suggestion is interesting though.

hi we're tracking both web search and currency conversion: #3248 and #3245. Please follow/comment ideas/etc on the respective threads!
closing as a duplicate


libf77blas.so.3: cannot open shared object file: No such file or directory.

Some customer have seen the error above when using DepthAI on Raspberry Pi.

It seems like this StackOverflow resolves the issue:
https://stackoverflow.com/questions/53784520/numpy-import-error-python3-on-raspberry-pi
sudo apt-get install python-dev libatlas-base-dev
We will make a script that checks for these dependencies and automatically installs them if they are not there.

Script is available here and one of the packages installed there is libatlas-base-dev


Fix CSS bugs

follow up to #61
also reverses order of bootstrap and alabaster CSS for now since it would change look of documents drastically
fix page crash due to // instead of /* */ CSS comments

Merging, this PR fixes several bugs and I want to include this before 0.4.0 release


[Support]: no newline included at end of failure output

What operating system are you using?

[ ] Linux
[X] macOS
[ ] Windows

What version of the tool are you using?
% gh actions-importer version
gh version 2.20.2 (2022-11-15)
gh actions-importer	github/gh-actions-importer	v1.0.1
actions-importer/cli	unknown

What happened?
There was no EOL at the end of the error message.
zsh inserts %+\n when the last line of output from a program doesn't include a newline.
The code appears to come from here:
https://github.com/search?q="image+prior+to+running+this+command"+org%3Agithub&type=code
I can't tell if this is a bug in https://github.com/cli/cli or in this repository.
Either way, programs should include a newline, otherwise shells that aren't as helpful as zsh will just start writing their new prompt right after the output.
Relevant log output
% gh actions-importer audit gitlab --output-dir ./output
Unable to locate GitHub Actions Importer image locally. Please run `gh actions-importer update` to fetch the latest image prior to running this command.%

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for opening this! This behavior will be corrected in the next release of this repo (likely Fri, Dec 2) 🎉


[AUTOPATCHER] Patches CVE-2021-38593 for qt5-qtbase

        Patches CVE-2021-38593 for qt5-qtbase.
        This patch and PR was automatically generated and needs human verification before merging.

This has picked up 3 identical patch files from different upstream branches. We only need 1.

None of the patches apply to our version of the code

Ok

Closing- does not apply for our configuration of qt5-qtbase.


Issue xxx gulpfile

PR to update build process

[ x ] I have read the Contributing Documents
[ x ] My commit(s) follow the commit message guidelines
[ x ] Project tests pass (npm test)
[ x ] Project tests coverage is 100%

Coverage decreased (-24.6%) to 71.519% when pulling b9c3729f582f07887cf00b1fa69f69181f346b62 on issue-xxx-gulpfile into 85637fe0fe7e94c0a92a9baa18b1259f474d4691 on development.


Improvements to generator of conversion methods.

generate conversion functions in alphabetical order
better handling of pointer arguments
some small refactoring

Part of #6800
cc @smarterclayton @lavalamp

@lavalamp you suggested adding a test to checking that functions registered via AddGeneratedConversionFunctions() weren't manually modified. I completely agree this is a good idea but I started thinking what's the best way to do it. This will be even harder as soon as we change those functions to be named and calling them one from another since they will need to be defined outside "AddGeneratedConversionFunctions()" method. Any suggestions on wht is the best way to do it? Do we want to explicitly compare the file as text with what would be generated? Thanks!

@wojtek-t Yeah, I think auto-generated stuff has to be clearly demarcated in files such that that test can just be a direct comparison. This is also important for humans editing things, so they know to edit the source and not the autogenerated stuff.

LGTM -- comments are optional and can be addressed in a followup


Support for importing migrations as a module

I wanted to run a series of migrations called from an existing python application so I've added support for configuration and things as a proper python object.
Also fixed a couple bugs

Hey not sure why the cov check failed maybe you can have a look

Thank you!


Update free-courses-pl.md

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[yes ] Read our contributing guidelines.
[ yes] Search for duplicates.
[ yes] Include author(s) and platform where appropriate.
[ yes] Put lists in alphabetical order, correct spacing.
[ yes] Add needed indications (PDF, access notes, under construction).
[ yes] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes
Be sure to check the free-programming-books-lint output for linter errors. Alphabetical order and spacing are the most common problems.
no shortened links


INFO:twisted:unknown security types: (30, 33, 36, 35) / OSX 10.14.3

INFO:root:connecting to mymac:5900
INFO:twisted:Starting factory <vncdotool.command.VNCDoCLIFactory instance at 0x7f6aa9856bd8>
INFO:twisted:Protocol version 3.889 not supported
INFO:twisted:Using protocol version 3.800
INFO:twisted:unknown security types: (30, 33, 36, 35)

vncdotool version-> From GIT

steps to reproduce

Install 10.14.3
Enable Screensharing

Works perfekt with realvnc viewer
vncdotool fails

This is solved.

go to the system preferences and add either for remote management or for screen sharing a password

always always use a single script - for some stupid reasons i tried to to multiple connections to the apple machine - this tries to relogin - not to continue.


Doc underwater

Add underwater use-case description

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a4b433c) 84.92% compared to head (8c2d7c6) 84.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   84.92%   84.92%
=======================================
  Files         200      200
  Lines       26385    26385
=======================================
  Hits        22408    22408
  Misses       3977     3977

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Your change is perfect! The sentence is actually more understandable!


collect NITS

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@76f9328). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage        ?   40.72%
=======================================
  Files           ?      183
  Lines           ?    10998
  Branches        ?        0
=======================================
  Hits            ?     4479
  Misses          ?     6168
  Partials        ?      351

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Component to create: progressindicator

Official link to component description & demo: http://dev.office.com/fabric/components/progressindicator
Screenshot of web analytics for the original http://officeuifabric.com site by @andrewconnell. Use this to see what are the most popular components: http://imgur.com/gallery/buUcyQv

SPEC
First thoughts...
main component directive: <uif-progressindicator />
optional string attribute uif-name: renders the name above the progress indicator
optional string attribute uif-description: renders the description below the progress indicator
optional string attribute uif-percentcomplete: a number between (inclusive) 0 and 100 that renders the progress bar
examples:
<uif-progressindicator uif-name="mydocument.docx" uif-description="This is a sample document" uif-percentcomplete="65" />

I take it you want to grab this after uif-overlay is done?
Also, should be uif-percent-complete... this should also raise an error if it's outside the 0-100 range.
Otherwise looks good.

Yes.  Just getting my feet wet. :)

Shouldn't it be uif-progress-indicator by the way?

IMHO makes more sense to use uif-percent-complete to indicate how full the bar is if we're using numbers.

Oh I meant naming the directive uif-progress-indicator rather than uif-progressindicator to consistently separate words. Progress should be indicated using the uif-percent-complete attribute on the directive as you mentioned.

oh yes... good call @waldekmastykarz

:+1:
--
Waldek Mastykarz
Office Servers and Services MVP
On 15 Jan 2016, at 21:59, Andrew Connell <notifications<EMAIL_ADDRESS>wrote:
oh yes... good call @waldekmastykarzhttps://github.com/waldekmastykarz

Reply to this email directly or view it on GitHubhttps://github.com/ngOfficeUIFabric/ng-officeuifabric/issues/34#issuecomment-172091049.

Submitted PR with incorporated feedback.
Would like to see if I can animate the progress bar when moving between states (e.g. 10% to 30%).
@andrewconnell please change label to work in progress

Ready for review - PR #104


function call with long input data length fails

Description
I would like to make a large number of calls(via multicall) in a single call, however there appears to be limitations to the length of data for a call as demonstrated here.
The first discrepancy is that the hedera local-node appears to work with a much higher input length compared to the hashio testnet relay. However even the local-node does not allow inputs as high as the hardhat local node.
Steps to reproduce
Checkout to the branch in the aforementioned mentioned PR
(I) Demo the issue on the hedera local node

cd into the hardhat-example project's root then start the local node: npm run hedera-start
Run the multicaller.test.ts script against the hedera local-node: npm run test:multicaller:local
Observe that the local relay returns valid responses for calls where iterations <= 1637 and fails for calls where iterations >= 1638

(II) Demo the issue on the hashio testnet relay

Run the multicaller.test.ts script against the hashio testnet relay: npm run test:multicaller:testnet
Observe that the testnet relay returns valid responses for calls where iterations <= 42 and fails for calls where iterations >= 43

(III) Demo the expected multicall capacity on the hardhat local node

start the hardhat local node: npm run hardhat-start
Run the multicaller.test.ts script against the hardhat local node: npm run test:multicaller
Observe that the hardhat relay returns valid responses for calls where iterations <= 2_936 and fails for calls where iterations >= 2_937

Additional context
No response
Hedera network
testnet, other
Version
<EMAIL_ADDRESS>&<EMAIL_ADDRESS>Operating system
None

Hi @Ivo-Yankov this issue seems like it could be related to #533 just inverted i.e. instead of there being an issue with the call result length the issue is with the input parameter length.

Hi @mshakeg , the issue is that you have reached a 1mb limit on the input size in the relay. These PRs add a way to increase it via the INPUT_SIZE_LIMIT env variable:
https://github.com/hashgraph/hedera-json-rpc-relay/pull/792
https://github.com/hashgraph/hedera-local-node/pull/250

Hi @Ivo-Yankov can the default be increased to about 10mb, AFAIK there's no size limit on typical json rpcs(infura) other than the gasLimit, and a 15m gasLimit can accommodate an input of at least 100mb as demonstrating in the example code.

Hey @mshakeg , we'll discuss this proposal and let you know.

Hi @georgi-l95 just wanted to ask if y'all plan on increasing the default input beyond 1mb? 100mb would obviously be ideal as that corresponds with the maximum allowable given the 15m gasLimit, however 10mb is fine too.

Hi @georgi-l95 , I'm guessing y'all settled on a default of 1mb?

Hi @mshakeg, there is still an ongoing discussion regarding this issue. We merged the PR to allow users to change the config on the local node for testing purposes, but all public networks will continue to have a limit ot 1mb for now.


NPM Script window not showing in Latest Version of VS Code

Just open any react project which has package.json. You will notice NO  NPM Script window will be there.

/duplicate of #120279


More advanced blackboard

Make blackboard use a Type class that encapsulates whatever we need and which can also be extended by anyone.

It will maybe cool to implement similiar solutions for BlackBoard from BehaviorTree.CPP as they are already more advanced in this question.
From their wiki: A Blackboard is a key/value storage shared by all the Nodes of a Tree.
It will be nice to share the blackboard on every node in the tree. Maybe simple pointer is enough?

There is already a shared blackboard for each behaviour tree, which can be passed to every leaf.
But yes, I was thinking of something similar for the blackboard when it comes to being able to store any value and not only predefined ones.

How the blackboard is actually passed to every leaf? I see the pointer to blackboard on the Leaf Class but how would you normally do it? Is the tree somehow traversed and automatically passes some global blackboard? Or should I just pass on every leaf some instance of blackboard? How this passing does then work with the tree builders?

When you create the leaf you pass the blackboard which exists within the behaviour tree. But you are correct that the current implementation of the tree builder does not support this in an easy way which should be improved.

How about the code below?
I have also corrected the behavior of stateful composites.
BrainTree.h.diff.txt


Update all tutorials to reflect new major versions of many packages and release of Julia 1.10

I have also noticed, in local testing, some issues with PyPlot.jl, likely due to the usual problem of python package management.
So am working to replace use of PyPlot with Plots.jl (with default GR backend) to lower maintenance. I think the original reason for avoiding Plots.jl (time-to-first-plot) is mostly moot.
Some possible breaking changes that come to mind:

measures got moved from MLJBase.jl to StatisticalMeasures.jl, with some changes in the way some measures behave. The StatisticalMeasures.jl. The migration guide is comprehensive, but most of it won't come up much. So mentioning a couple of them below.
all measures that previously returned multiple per-observation measurements (to be aggregated in a separate step) are now aggregated already.
in evaluations and tuning, the default measure for regression models used to be rms but is now l2 (instance of LPLoss). Generally encouraging use of l2 over rms.

To do:

[ ] A-composing-models
[x] A-ensembles @ablaom
[ ] A-ensembles-2
[ ] A-ensembles-3
[ ] A-fit-predict
[ ] A-learning-networks
[ ] A-learning-networks-2
[ ] A-model-choice
[ ] A-model-tuning
[ ] A-stacking
[ ] D0-categorical
[ ] D0-dataframe
[ ] D0-loading
[ ] D0-processing
[ ] D0-scitype
[ ] DRAFT_EX-cardfraud
[ ] EX-AMES
[ ] EX-GLM
[ ] EX-airfoil
[ ] EX-boston-flux
[ ] EX-boston-lgbm
[ ] EX-breastcancer
[ ] EX-crabs-xgb
[ ] EX-horse
[ ] EX-housekingcounty
[ ] EX-powergen
[ ] EX-telco
[ ] EX-wine
[ ] ISL-lab-10
[ ] ISL-lab-2
[ ] ISL-lab-3
[ ] ISL-lab-4
[ ] ISL-lab-5
[ ] ISL-lab-6b
[ ] ISL-lab-8
[ ] ISL-lab-9

cc @EssamWisam

cc @EssamWisam
When you start on a tutorial, can you please assign yourself by tagging the tutorial in the above "To do" list, and make a PR onto this mljbase-1-0-update branch for me to review?
Thanks.

To be safe, this probably needs a rebase.

Closed in favour of #191


Add Main Menu keybinding to Mate.hs

Use mod+d to open the Mate Main Menu.
Description
It is now possible to open Mate Main Menu using a keybinding (default mod+d).
This feature was missing from Mate.hs config.
Checklist

[x] I've read CONTRIBUTING.md

[ ] I tested my changes with xmonad-testing

[ ] I updated the CHANGES.md file

[ ] I updated the XMonad.Doc.Extending file (if appropriate)

I updated your branch to include my refactoring of the logout/shutdown dialogs.

Perhaps mention this in the CHANGES.md?

Rebased/squashed the amends (next time please don't merge master but rebase on top), added CHANGES entry, merged. Thanks!

Thank you!


Keep last used group expanded

Every time I get back to the project-viewer (I have it open all the time) the project groups are collapsed.
It would be really nice if the last opened group could stay expanded.

thanks for the input! will look at it


fio with kind: vm no longer works

the fio benchmark with kind: vm will not work anymore.  This is because the fio versions of the client and server must match EXACTLY, but the fio benchmark of the client is fio-3.19-3 whereas the fio benchmark of the server container image was frozen in time at quay.io/mulbc/fed-fio , so you'd see errors like this in the client log:
fio: client/server version mismatch (84 != 82)
fio: bad server cmd version 84

I fixed this by generating my own fio image using Chris Blum's handy script and modifying it slightly.   The version I'm using right now is at
#!/bin/sh

IMAGE_URL=https://cloud.centos.org/centos/8/x86_64/images/CentOS-8-GenericCloud-8.3.2011-20201204.2.x86_64.qcow2
IMAGE=centos8.qcow2
LOCAL_IMAGE=mycentos8.qcow2
QUAY_IMAGE=quay.io/bengland2/centos8-fio:latest

set -x
set -e

sudo dnf install podman podman-docker wget -y

wget --continue $IMAGE_URL -O $IMAGE
cp -f $IMAGE $LOCAL_IMAGE

if ! virt-customize --help >/dev/null; then
  sudo yum install -y virt-customize || sudo yum install -y libguestfs-tools
fi

virt-customize -a $LOCAL_IMAGE \
  --install wget,libaio,curl,python3,python3-pip \
  --run-command "wget https://raw.githubusercontent.com/cloud-bulldozer/bohica/master/stockpile-wrapper/stockpile-wrapper.py && pip3
 install elasticsearch-dsl openshift kubernetes redis" \
  --copy-in fio-3.19-centos8:/usr/local/bin \
  --selinux-relabel \
  --root-password password:yourPassword \
  --firstboot-command '/usr/local/bin/fio-3.19-centos8 --server'
virt-sysprep -a $LOCAL_IMAGE

cat <<END >Dockerfile
FROM kubevirt/container-disk-v1alpha:v0.13.7
ADD $LOCAL_IMAGE /disk/
END
docker rmi $QUAY_IMAGE || echo "image already removed"
docker build -t $QUAY_IMAGE .
docker push $QUAY_IMAGE

And I built the fio image by logging into one of the VMs :
[kni@f20-h25-000-r640 benchmark-operator]$ oc get vmis
NAME                    AGE     PHASE     IP             NODENAME
fio-server-1-e3abc763   2m14s   Running   <IP_ADDRESS>   f21-h02-000-r640.rdu2.scalelab.redhat.com
...
[kni@f20-h25-000-r640 benchmark-operator]$ virtctl console fio-server-3-e3abc763
Successfully connected to fio-server-3-e3abc763 console. The escape sequence is ^]

CentOS Linux 8
Kernel 4.18.0-240.1.1.el8_3.x86_64 on an x86_64
...
fio-server-3-e3abc763 login: root
Password:
[root@fio-server-3-e3abc763 ~]#

and doing this:
and then did the following to build fio and install it:

 dnf install -y git gcc make libaio-devel zlib-devel
 git clone https://github.com/axboe/fio
 git checkout fio-3.19
 cd fio
 git checkout fio-3.19
./configure --disable=librados --disable=librbd
make -j
 ./fio --version
fio-3.19

and saved the fio program here.
Eventually someone should make a PR and incorporate all this into the fio benchmark, but for now this is a usable workaround, I think.

@mulbc FYI
In our documents :
vm_image: Whether to use a pre-defined VM image with pre-installed requirements. Necessary for disconnected installs.
Note: You can use my fedora image here: quay.io/mulbc/fed-fio
Note: Only applies when kind is set to vm
```

However, you mention that the vm_image is different for the server/client (this seems like an issue)...

I wonder if you would of set `image` to `quay.io/mulbc/fed-fio` if that would of fixed  your issue... Effectively pinning the server and client to the same container image?

quay.io/mulbc/fed-fio was a VM image, client is a pod (container) image, so they can't be the same.  quay.io/mulbc/fed-fio is exactly what I set it to in the beginning when I got the error.   It used to work, now it doesn't, his image didn't change, so it must have been the version of fio used in quay.io/cloud-bulldozer/fio image.

quay.io/mulbc/fed-fio

quay.io/mulbc/fed-fio was a VM image, client is a pod (container) image, so they can't be the same. quay.io/mulbc/fed-fio is exactly what I set it to in the beginning when I got the error. It used to work, now it doesn't, his image didn't change, so it must have been the version of fio used in quay.io/cloud-bulldozer/fio image.

ack - now I see that, I didn't actually look at Chris's image. If we knew which FIO he was using, we might be able to pin that, but we need a longer term solution...

The fio VM image is just an example... Ben pinged me about the problem yesterday... he got my image creation script, if he is able to fix it by pinning to a specific fio version, I'm happy to update quay.io/mulbc/fed-fio to work again ;)

@mulbc  exactly, not Chris's fault, but I would suggest we include VM image creation somehow as part of producing the benchmark image, so that they continue to be synch'ed in the future.   And I did get it working, it was not hard, it's documented here, just needs some automation.   Sorry, can't do it right now but that's why I wrote the issue, so this wouldn't get lost.

ack!
I was under the impression this was being maintained, since it was set as our default for fio_vm CR
https://github.com/cloud-bulldozer/benchmark-operator/blob/master/resources/crds/ripsaw_v1alpha1_fio_distributed_vm_cr.yaml#L30

Checking in on this @bengland2

haven't gotten around to submitting a PR yet.   @mulbc if you get there first fine with me, I should be able to take a look at a fix within 2 weeks.

I discussed with Russ, I think we need some kind of CI that has both OCS and CNV in it so that we can test things like this that are going to be used in the field with benchmark-operator (example: Goldman, Morgan-Stanley).   It's non-trivial to implement from a dependency standpoint, but if we want to make benchmark-operator usable by a wider audience  then that's probably what we have to do.   Think of it as "productizing" benchmark-operator.

@bengland2 how do we proceed on this? Is this a task that you track in your team's backlog?

@mulbc latest discussion I heard with CNV P&S team (Jen's idea) was that we would attempt to make VMs run podman to invoke the fio benchmark-operator image that is used by openshift, so as to avoid maintaining multiple fio images, 1 for pods and 1 for VMs.   Not sure if this is feasible but I think in theory it is possible to do - instead of having /mnt/pvc be configured by OpenShift, the VM script would have to make /mnt/pvc be bound to an RBD device that the script created.   This could be done using podman -v /mnt/pvc:/mnt/rbd-container-X .
also Jen Abrams ( @jeniferh ) suggested --net host , the host networking would allow the image to connect to redis and elasticsearch outside the VM, assuming the VM's firewall lets it through.
So we would still need some benchmark-operator magic to start the VMs and invoke the image from within the VMs though, but it's not a different image at that point, it's just a different use of the same image, and we don't need a VM image taylored for fio, just a RHEL VM image with podman in it.     This approach might make it easier to get other benchmark-operator benchmarks working with CNV also, right?

also Jen Abrams ( @jeniferh ) suggested --net host , the host networking would allow the image to connect to redis and elasticsearch outside the VM, assuming the VM's firewall lets it through.

I don't understand this point - why do you think the VM could not connect to elasticsearch right now? Using the regular SDN does not prevent the VM from talking to anything in the cluster (last I checked)
If I understand your suggestion correctly, then you want to have a container, running a VM, running a container? :D
This might work, but is maintaining a VM image with fio so much work? In other words - wouldn't it be the same amount of work to have a VM image with podman?

@mulbc, thank you for creating the capability to run fio inside CNV VMs in the first place.    The question is how to make this more maintainable and easy to do going forward.  In response:

You are correct, the VM can connect to elasticsearch right now, but the run_snafu.py inside a container inside the VM might not be able to do that unless we set up networking for the container to allow it.  Hence the suggestion for podman --net host.

the VM image with podman could be set up to run any of the the benchmark-operator benchmarks, whereas the VM image with fio can only run that one benchmark.        And the VM image with podman will not need to be updated when a new version of a new benchmark comes out.

right, CNV VMs are just pods that run qemu-kvm, and inside the VM we're turning around and running a container, so it is a bit comical.   But it all comes down to maintainability and extending benchmark-operator to support CNV better.

@ebattat what do you think?  @jtaleric ?

Yes this idea of using the same workload binaries provided in the container image that a 'kind: pod' run would use is something I am starting to work on. Not sure yet if we can use a chroot-based solution or will actually need to run from w/in a carefully crafted container inside the VM, but the idea is that it will reduce maintenance work for VM images for each workload as @bengland2 mentioned and we are reusing the exact same bits as pod workloads which is beneficial for testing purposes and performance comparisons.

I think I understand this now - yes that might indeed cut down on the maintenance!
I still think that you wouldn't need the host networking for podman to connect to the elasticsearch, but we can check.
One thing we should make sure is that we forward the disk device to the inside podman container instead of mounting and forwarding that.


Use from_networkx instead of legacy construction in more notebooks

These were missed in #1018.
See: #717

Codecov Report

Merging #1026 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1026   +/-   ##
=======================================
  Coverage     85.1%   85.1%
=======================================
  Files           53      53
  Lines         5365    5365
=======================================
  Hits          4563    4563
  Misses         802     802

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b9369...efff707. Read the comment docs.


Support of openapi is missing in Azure PowerShell task

Question, Bug, or Feature?
Type: Bug
Enter Task Name:  Azure PowerShell
Environment

Server - Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number: https://dev.azure.com/esl-digest/digest-dev/_build/results?buildId=79

Agent - Hosted or Private: Hosted

If using Hosted agent, provide agent queue name: Hosted Windows 2019 with VS2019

Issue Description
I'm using Azure PowerShell task v 4.* to import API defined using openapi format.
I know this format is supported in most recent Az versions, see PsApiManagementApiFormat  enumeration.
Possible solution to this issue would be installation of most recent release of Az Powershell module at the beginning of this task. At least this is the workaround solution we had to go with using regular "Powershell Script" task.
 Az and AzureRM modules cannot be imported in the same session or used in the same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of your runbooks import both Az and AzureRM modules.  Cannot convert value "openapi" to type "Microsoft.Azure.Commands.ApiManagement.ServiceManagement.Models.PsApiManagementApiFormat". Error: "Unable to match the identifier name openapi to a valid enumerator name. Specify one of the following enumerator names and try again:
Wadl, Swagger, Wsdl"

The PR  updates the script for installing latest Az module (2.3.2). This will be made available as part of the next hosted image roll-out.

@20shivangi for further queries on this regard.

@20shivangi is there any information on when the update to the hosted images is going to be rolled out?

@ramosjacc Update to the hosted image will get rolled out within 3 weeks

This PR  updates the script for installing latest Az module (2.3.2) in hosted agents. This will be made available as part of the next hosted image roll-out.
@20shivangi for further queries on this regard.

Could you let me know when is the next hosted image roll-out planned?

@aleksey-korolev Update to the hosted image will get rolled out within 3 weeks. Please wait for three weeks.

Closing as the the issue is fixed and will roll out with next scheduled release.
Please reopen if the issue is not resolved in the expected time (2-3 weeks)


Update README.md

Looks like mozilla has moved to something else.
!!!!! STOP AND READ !!!!!
If the dropdown above says "base fork: lord/master", you are submitting your change to ALL USERS OF SLATE, not just your company. This is probably not what you want. Click "base fork" to change it to the right place.
If you're actually trying to submit a change to upstream Slate, please submit to our dev branch, PRs sent to the master branch are generally rejected.

Thanks for the tip!


[Bug][Windows] Context menu is showing Hyper but trows an error when clicked.

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 Pro, Version 1607, OS Build 14393.479
Hyper.app version: Hyper 1.0.0
The issue is reproducible in vanilla Hyper.app: Yes

Issue

Steps to reproduce :

Clean install Hyper 1.0.0.
Right click on desktop.
Click on Hyper.

Images off the issue :

I am also on Windows 10 Pro - Version 1607 - OS Build 14393.479 - and the issue is not present 🤔
Maybe try running the installer as administrator, if you have not already.
Also, the right click prompt to run Hyper, is kinda different for me;

Hope that helps!

Windows 10 Pro 1607 Build 14965.1001 here, and my "open here" option works correctly, but also matches klauscfhq's

Yeah, looks like something happened during the first install. I tried again as administrator but the issue was still there. Had to remove hyper from the context menu first and reinstall as administrator.
@CodeTheory you can close the issue.

same bug here, Win 7.
Wondering how to remove hyper from the context menu.... @stefanivic @CodeTheory

Same bug here, trying to remove it and rerun with administrator.

Also, tried to uninstall Hyper from Win 7. The uninstallation is not clean at all...

@CodeTheory I think this bug should be reopen, I tried to remove hyper, restart windows and reinstall with administrator but still doesn't work, I'm on windows 10.
I also have the exact same issue with GitKraken, but VScode works fine.
Also, all my 3 computers have the same problem, I think it's a problem with Electron itself or something, because I just recently reinstall windows on both 3 computers, and I didn't facing this error before the  reinstallation.

@bayesrule After removing Hyper, go can go here HKEY_CLASSES_ROOT\Directory\Background\shell (search for regedit in windows search) and delete the Hyper folder there.

@lednhatkhanh yeah that is exacly how i removed it, but after a fresh install as administrator it worked fine.

A fix for it is:  go to HKEY_CLASSES_ROOT\Directory\Background\shell\hyper\command (in regedit).
Change default value to C:\Path\To\Your\hyper.exe %V

A fix for it is: go to HKEY_CLASSES_ROOT\Directory\Background\shell\hyper\command (in regedit).
Change default value to C:\Path\To\Your\hyper.exe %V

There is a problem that everytime when hyper updates automatically, I have to redo the fix as above.
I think it could be better to ask for administrator permission when installation (like what vscode does)
We can see a difference on the icons (I don't have a vscode installer now, but you will know what I said from the picture)