Fix/oc

build/root/usr/local/bin/run: do not print git commit notes in the CI run info

roles/nv_gpu/tasks/install.yml: remove trailing spaces

roles/nv_gpu/tasks/install.yml: wait 5min for CRDs

build/root/usr/local/bin/run: download latest 'oc' client if missing from PATH

@ArangoGutierrez I force pushed these commits into release-4.* branches ... and things go better!

the oc CLI issue is worked around, so 4.7 and 4.8 (+ master/4.6) now run happily
however even with >13min delay, 4.4 and 4.5 failed, so the timing isn't the problem:

TASK [nv_gpu : Failed when creating the test clusterpolicy CR for the GPU Operator] ***
task path: /opt/ci-artifacts/src/playbooks/roles/nv_gpu/tasks/install.yml:34
Monday 25 January 2021  00:02:38 +0000 (0:14:05.971)       0:19:00.739 ********
fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": {
        "attempts": 40,
        "changed": true,
        "cmd": [
            "oc",
            "apply",
            "-f",
            "roles/nv_gpu/files/041_customresources.yaml"
        ],
        "delta": "0:00:00.922756",
        "end": "2021-01-25 00:02:38.876660",
        "failed": true,
        "msg": "non-zero return code",
        "rc": 1,
        "start": "2021-01-25 00:02:37.953904",
        "stderr": "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\"",
        "stderr_lines": [
            "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\""
        ],
        "stdout": "",
        "stdout_lines": []
    }
}

@ArangoGutierrez I force pushed these commits into release-4.* branches ... and things go better!

the oc CLI issue is worked around, so 4.7 and 4.8 (+ master/4.6) now run happily
however even with >13min delay, 4.4 and 4.5 failed, so the timing isn't the problem:

TASK [nv_gpu : Failed when creating the test clusterpolicy CR for the GPU Operator] ***
task path: /opt/ci-artifacts/src/playbooks/roles/nv_gpu/tasks/install.yml:34
Monday 25 January 2021  00:02:38 +0000 (0:14:05.971)       0:19:00.739 ********
fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": {
        "attempts": 40,
        "changed": true,
        "cmd": [
            "oc",
            "apply",
            "-f",
            "roles/nv_gpu/files/041_customresources.yaml"
        ],
        "delta": "0:00:00.922756",
        "end": "2021-01-25 00:02:38.876660",
        "failed": true,
        "msg": "non-zero return code",
        "rc": 1,
        "start": "2021-01-25 00:02:37.953904",
        "stderr": "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\"",
        "stderr_lines": [
            "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\""
        ],
        "stdout": "",
        "stdout_lines": []
    }
}

@ArangoGutierrez I force pushed these commits into release-4.* branches ... and things go better!
1. the `oc` CLI issue is worked around, so `4.7` and `4.8` (+ `master/4.6`) now run happily

2. however even with >13min delay, `4.4` and `4.5` failed, so the timing isn't the problem:

TASK [nv_gpu : Failed when creating the test clusterpolicy CR for the GPU Operator] ***
task path: /opt/ci-artifacts/src/playbooks/roles/nv_gpu/tasks/install.yml:34
Monday 25 January 2021  00:02:38 +0000 (0:14:05.971)       0:19:00.739 ********
fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": {
        "attempts": 40,
        "changed": true,
        "cmd": [
            "oc",
            "apply",
            "-f",
            "roles/nv_gpu/files/041_customresources.yaml"
        ],
        "delta": "0:00:00.922756",
        "end": "2021-01-25 00:02:38.876660",
        "failed": true,
        "msg": "non-zero return code",
        "rc": 1,
        "start": "2021-01-25 00:02:37.953904",
        "stderr": "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\"",
        "stderr_lines": [
            "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\""
        ],
        "stdout": "",
        "stdout_lines": []
    }
}

Interesting, maybe we need to change the CSV channel for release-4.5
and remember 4.4 is deprecated now, so wont fix.

@ArangoGutierrez I force pushed these commits into release-4.* branches ... and things go better!
1. the `oc` CLI issue is worked around, so `4.7` and `4.8` (+ `master/4.6`) now run happily

2. however even with >13min delay, `4.4` and `4.5` failed, so the timing isn't the problem:

TASK [nv_gpu : Failed when creating the test clusterpolicy CR for the GPU Operator] ***
task path: /opt/ci-artifacts/src/playbooks/roles/nv_gpu/tasks/install.yml:34
Monday 25 January 2021  00:02:38 +0000 (0:14:05.971)       0:19:00.739 ********
fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": {
        "attempts": 40,
        "changed": true,
        "cmd": [
            "oc",
            "apply",
            "-f",
            "roles/nv_gpu/files/041_customresources.yaml"
        ],
        "delta": "0:00:00.922756",
        "end": "2021-01-25 00:02:38.876660",
        "failed": true,
        "msg": "non-zero return code",
        "rc": 1,
        "start": "2021-01-25 00:02:37.953904",
        "stderr": "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\"",
        "stderr_lines": [
            "error: unable to recognize \"roles/nv_gpu/files/041_customresources.yaml\": no matches for kind \"NodeFeatureDiscovery\" in version \"nfd.openshift.io/v1alpha1\""
        ],
        "stdout": "",
        "stdout_lines": []
    }
}

Interesting, maybe we need to change the CSV channel for release-4.5
and remember 4.4 is deprecated now, so wont fix.

I removed the last commit https://github.com/openshift-psap/ci-artifacts/commit/313e7d00ae53557d2bf188966eec84d6f1cf1dda (wait 13min for CRDs) as the issue wasn't there

I removed the last commit https://github.com/openshift-psap/ci-artifacts/commit/313e7d00ae53557d2bf188966eec84d6f1cf1dda (wait 13min for CRDs) as the issue wasn't there

/test images

/test images

added a commit to capture Pod&Node info when all the test succeed

added a commit to capture Pod&Node info when all the test succeed

@ArangoGutierrez if you have time to review this PR today, I'd like to get it merged to run it overnight

@ArangoGutierrez if you have time to review this PR today, I'd like to get it merged to run it overnight


Can we skip the install step?

I have been working on a fork of react-scripts that I would like to hook up to our project automation tooling. I'd like the initial project creation to just write out the assets and dump it into a github repo, skipping the yarn or npm install step.
I refactored our init script to mix in dependencies and devDependencies before writing package.json so that I can conditionally run a single yarn or npm install, but it doesn't looks like the install work is currently skippable in createReactApp.js.
Would it be beneficial to anyone else to be able to just write the project assets but not run yarn or npm install? Maybe base it on process.env.CI?

Ugh, nm. It's EOD on Friday... This would fail to install the scripts required to create the project in the first place... I'm going home for the day xD


XML dump processor hangs intermittently.

I suspect it has something to do with a race condition in Processor.join() and queue.get()

Fixes in 0.4.12.


x/net/html: unexpected whitespace rendering of html

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/tcurdt/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tcurdt/.go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/pf/7vhqx5bn41qddypw08w9jc4w0000gn/T/go-build451640899=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I am parsing and then rendering html.
package main

import (
	"bytes"
	"fmt"
	"os"
	"strings"

	"golang.org/x/net/html"
)

func main() {
	var input = `<!DOCTYPE html>

  <title>Title of the document</title>

   body content
more content

`
	doc, err := html.Parse(strings.NewReader(input))
	if err != nil {
		fmt.Fprintf(os.Stderr, "error parsing: %s\n", err.Error())
		os.Exit(1)
	}

	buf := bytes.NewBufferString("")
	html.Render(buf, doc)

	fmt.Println("--")
	fmt.Print(input)
	fmt.Println("--")

	fmt.Println("--")
	fmt.Print(buf.String())
	fmt.Println("--")
}

What did you expect to see?
With the docs saying:

Rendering is done on a 'best effort' basis: calling Parse on the output of Render will always result in something similar to the original tree, but it is not necessarily an exact clone unless the original tree was 'well-formed'.

Given that the HTML is well-formed I'd expect the output be the same as the input.
What did you see instead?
Instead I am seeing changes in whitespace:
--
<!DOCTYPE html>

  <title>Title of the document</title>

   body content
more content

--
--
<!DOCTYPE html>
  <title>Title of the document</title>

   body content
more content

--

IMO there should be a test case verifying that the output matches in input for the documented case.

cc: @mikesamuel

Nit: I think this is related to x/net/html, not x/net/template.

A minimal example input:

Outputs in go:

Chrome gives identical output:

As does Firefox:

Things more interesting with comment blocks, where go, Chrome and Firefox all disagree...
Input:

Outputs in go, changes whitespace but keeps final comment in same relative place:

Chrome moves the final comment inside the body:

Firefox does same as Go with slightly different spacing:

According to Section <IP_ADDRESS>.22, I believe Chrome is at fault with regards to the final comment positioning. However, I think that is a separate issue to the original reported issue here.

There are a couple of facets to this IMO:

golang.org/x/net/html does not always allow for a parsing-serialization round trip. This is sad but documented
The documentation suggests that a round trip is possible as long as the document is well-formed. This poses an expectation that is not met (as shown in the code example). Hence I opened this issue.
The result of a browser parse-serialization round trip is inconsistent across implementations and possibly non-conformant to the standard. IMO this should not be really relevant to golang.org/x/net/html though. In the end those browsers are just markup consumers. While defined in the standard how they parse and build the DOM should not be relevant to the go package. Plus we would have to compare the actual DOMs not the serialization of it. In the end the difference could be the serialization code instead.

So what to do?
Given that browser implementations are out of scope to fix, it seems sane to just ignore them. The easiest "solution" would be to just change the docs to reflect 2).
Given that I am rather an advocate of a proper parsing-serialization round trip I'd love to see at least a test case based on the above example.
But in the end it comes down to what golang.org/x/net/html wants to be and whether it wants to fulfill the contract given in the current documentation.

I agree with you @tcurdt that the browser implementations shouldn't necessarily impact the approach used in golang.org/x/net/html, which should be based on the spec.
However, the spec is very complex and the browser implementations in Chrome & Firefox serve as two well-maintained implementations which can serve as a cross reference. In the original report above, the Chrome & Firefox (and also html5lib) all agree with golang.org/x/net/html.
The documentations mentions Parse on the output of Render will always result in something similar to the original tree which is Render -> Parse, but the report does Parse -> Render. If the resultant snippet above is fed back into Parse (and then Render again) the results don't change.
Are we confident there is a mistake in the implementation of the spec?

@TomAnthony but you left out the most relevant part for this issue when quoting

unless the original tree was 'well-formed'.

which gives this a completely different spin.
TBH I don't have enough knowledge of the spec to make any educated comments - but I do think it's surprising that there are whitespace changes happening on a Parse -> Render operation.
In my use case I wanted to parse a HTML file, change something and then write it back. Especially given that humans would not use whitespace as rendered this is a problem for that task at hand.
Ideally the round trip would not change a thing. As a second choice I would use my own renderer of the DOM tree and so be in control of the rendered output - but I didn't see an obvious way to do this yet.

@tcurdt - yeah, I definitely see your point and I agree it seems surprising. However, I am unsure exactly how to define 'well-formed'...
The spec states The DOM will not let Document nodes have Text node children, so they are dropped on the floor., which indicates that text nodes are not allowed between  and .
However, rather than being 'dropped on the floor' the white space between your  and  is being moved inside the  tag. The fact that 4 different implementations exhibit this same behaviour makes me think there is part of the spec we are still not understanding.
Either way, I think the white space between  and  is always going to be removed because the parsing phase will remove it according to the spec. For that reason I also think your own renderer wouldn't help (the parsing step will already have removed/moved that text node).
I think the behaviour that isn't interrupting your process is entirely prompted by whitespace outside of the ; whitespace inside the  shouldn't be moved. Depending on what specifically you are trying to do, you could perhaps snip the  our of your input file and parse it as a fragment. Then snip the resulting  out of the serialised output and use that to replace the  contents from your input file?

If there isn't really a good path in code to solve this I think the "well-formed" part should be removed from the documentation - especially if there is a uncertainty of the definition. That would create much less confusion given the start of the sentence.
As for the actual behaviour it kind of means there are two representations of the DOM. The input as usually given by humans and the rendered version that conforms to the spec. So unless a non-standard DOM is allowed to exist there is no way to make the roundtrip work without a hitch.
It is indeed mostly the white space outside the body element that is giving me grief. Working around this by dealing with fragments and then combining the strings feels like a hack and quite fragile.
I think there is a place for both the spec compliant and the non-spec compliant representation. But that's just not supported. I guess I either need to make my peace with the change of whitespace or write my own parser/dom. A bit of a shame.
Since I doubt the golang.org/x/net/html is willing to allow a change for a non-compliant DOM a change of documentation might be the right path forward.

I'm just a 'visitor' here - I recently had an issue in parse.go and thought I may be able to help with your issue 🙂. Someone else can may offer a more 'official' response to what is considered well-formed, and as to whether golang.org/x/net/html might be change to allow a non-compliant DOM (I highly doubt it, and am unsure how this should even work).
I disagree that the docs should be updated (or at least the segment you referenced) as that talks about the rendering step, but your issue occurs in the parsing step. The output of render produces an identical tree if fed back into parse.
I actually think if you want to maintain "ill-formed" whitespace outside of the body, and your changes are all in the body, that the fragment approach would be an ok approach. I think trying to create your own parser/renderer would be a recipe for pain!
Sorry I cannot be more help! 😞

Well, the "how this should even work" is probably the least of the problems. Without even looking at the implementation I am pretty sure that at some part of the way of building the DOM some nodes are left out are fixed for compliance reasons. A simple KISS parser would just build the "illegal" DOM as is.
You have a point on the rendering step though.

calling Parse on the output of Render will always result in something similar to the original tree

it does not make any claims on parsing the original input but just the rendering of the input.
But then again I have missed the part in the documentation where it talks about the input of a non-compliant tree getting transformed into a compliant tree.
At hindsight looking at the documentation of Parse

It implements the HTML5 parsing algorithm, which is very complicated. The resultant tree can contain implicitly created nodes that have no explicit  listed in r's data, and nodes' parents can differ from the nesting implied by a naive processing of start and end s. Conversely, explicit s in r's data can be silently dropped, with no corresponding node in the resulting tree.

From this it should be clear that a roundtrip cannot be ensured.
I just had the expectation it would.
Writing a parser that just builds the given html into a (non-compliant) DOM really is no rocket science. I assume one could even use the existing tokenizer. As hinted above it will be much simpler than what the current implementation does. I just hoped to avoid it.

The problem with creating a "non-compliant DOM" is the DOM is designed to be a tree structure. Some badly formed HTML cannot form a tree:
<form>
</form>

This cannot be turned into a tree and re-serialised as it is. The HTML 5 spec has algorithms designed to handle this sort of case and re-nest things correctly. There are many other such cases.
However assuming your input is guaranteed to be well-formed (in terms of tag nesting, rather than what tags/tokens are allowed where), then you may find an existing parser that works (maybe lxml/BeautifulSoup?).
Good luck! 🙂

Yes, one has to draw a line somewhere. It's gotta be a tree :)

@tcurdt lxml may work for you then; this maintains the whitespace between  and  (but ditches the whitespace after ):
import lxml.html

foo = """<!DOCTYPE html>

  <title>Title of the document</title>

   body content
more content

	"""

bar = lxml.html.fromstring(foo)

print(lxml.html.tostring(bar))

...but that's not in go :)

Maybe https://github.com/lestrrat-go/libxml2 or https://github.com/moovweb/gokogiri?


feat: add pre-commit hook

Add a .pre-commit.hooks.yaml file so we can easily setup stylus supremacy to use with pre-commit:
Usage:
.pre-commit-config.yaml
repos:
  - repo: https://github.com/ThisIsManta/stylus-supremacy
    rev: v2.16.0
    hooks:
      - id: stylus-supremacy
        args: ['--options', ".stylus-supremacy.yaml"]

Merged at https://github.com/ThisIsManta/stylus-supremacy/commit/eb8a0b69a57a4fd83a2c62eaf954d2b379e6d997
This is available since v2.17.0
Thanks for the contributions!

Nice, thanks for the merge.
There is a mistake in documentation: The github repository to pre-commit in vscode-stylus-supremacy instead of stylus-supremacy

Oh let me fix that


Describe project structure

Describe initial structure
https://github.com/skorphil/piggy-tracker-form/blob/main/docs/project-structure.md

Might be useful https://brockherion.dev/blog/posts/using-react-hook-form-with-nextjs-13-server-actions/
Has no idea, what are the conventions for Server Actions. Where is a better place for em.
For now think it is better to have em in component folder they belong to.
/myForm
    myForm.jsx
    serverActions.js

Added index files to components
Added chakra style files to components
https://github.com/skorphil/nextjs-form/blob/main/docs/project-structure.md


make sellIncrement smaller so that markets with less liquidity survive spread filter

Done w/ decreasing percentage to 2% in AugurProject/augur-node#890


Automatic School Rendering

Currently there's no system in our graphics that auto picks schools. To remedy this, we will create a json file containing all the universities with the appropriate data.

Creating a json file of all the universities is a lot, and it especially sucks when some of the schools we have on a list might not be a school we play against. Instead, we'll opt for a "If it exists, use it, if it doesn't add it". This will use both a database and local storage in the case that we lack an internet connection. We'll be able to save the school name along with its data, whether it'd be their primary colors, secondary colors, or team name. That way, we'd only have to look up for a new school's information once, and then permanently save their information into a) the database, and b) the local storage.
The other reason we are storing this in both local storage and a database is to sync across the two devices that we'll be using to broadcast sports.


Clone of your app is on google play market

FYI this app is on google play market is most likely not legit.
https://play.google.com/store/apps/details?id=com.walletc.opay
I reported it through mobile version of google play market but not sure if it is going to be taken down.

It's not legit app. Copay official app is not available on PlayStore any more. Checkout official BitPay App here: https://play.google.com/store/apps/details?id=com.bitpay.wallet
Thanks for reporting.

I think the reported clone has been taken down. Can we mark this issue as resolved now? @Undeadlol1

Thank you.


LCFS - Notional transfer input form

Description:
As a BCeID user this form allows me to input information about notional transfers of eligible renewable fuel as part of my compliance report. Business requirements include identifying information and amount of tracked fuel, eligible renewable fuel notionally transferred away by a person, eligible renewable fuel notionally transferred received by a person, and eligible renewable fuel notionally retained by a person.
Notional transfer input form page should have:

Title: Notional transfer of eligible renewable fuel
Explanation text (to be confirmed by the business area)
Validation component display
AG grid with columns; format is 'column name | type of data entry | validation requirements':

Legal name of trading partner | Free form text  (with predictive text) | n/a
Address for service | Free form text (with predictive text from legal name selected) for addresses input | n/a
Fuel Category | drop down fuel category | no input
Received OR Transferred | drop down 2 options (Received, Transferred) | no input
Quantity (L) | Number field, no decimals | cannot be negative

Add rows button in increments of 5 below the table
Button labelled 'Save & return to report'
Include AG grid validation for each column

Wireframe:
validation running: https://preview.uxpin.com/da68049c0af15edd7ce4e47e4bee431fed40c30d#/pages/173716080?mode=m
validated input: https://preview.uxpin.com/da68049c0af15edd7ce4e47e4bee431fed40c30d#/pages/173341058?mode=m
Purpose and benefit to user:
Under Section 30 of the Low Carbon Fuels Act, obligated parties are required to report notional transfers of renewable fuel volumes. This provides the input needed for that.
Acceptance Criteria:

[ ] Given I am a BCeID, When I am on the Notional Transfers page, then I should be presented with a form to fill out notional tranfers
[ ] Given I am a BCeID, When I am filling out the legal name of trading partner field, there should be predictive text that lists companies. This field is also free form.
[ ] Given I am a BCeID, When I am filling out the legal name of trading partner field and choosing a suggested company, the address field should automatically be filled out. This field is also free form.
[ ] Given I am a BCeID, When I am filling out the fields, validation should happen for each field that gets filled out
[ ] Given I am a BCeID, When clicking the + row button, you should be presented with a dropdown with options to choose single or multiple rows
[ ] Given I am a BCeID, When clicking the + row button option, rows should be added to the form

Development Checklist:

[ ] save to the notional transfer table. no relation to supplier when choosing predictive text
[ ] Validation and autosave in another ticket ( #609 )

Notes:

Will be similar to the structure and design of inputs in Schedule A of TFRS, except now using the AG grid function.

Receiving errors loading the page and trying to save


Enable Wiki on Github?

Would it be alright if we enabled the Wiki so that the community can add content?
MSDN is a great place for official tutorials and blogs -- but I'm thinking that the community surrounding Windows Azure NodeJS could add their tutorials/demos/examples to this wiki...
Just a thought!
Cheers,
Jaime

Thanks Jaime - we don't mind opening it up as soon as we have content to put there. Reopen this issue with any ideas...

Sounds good, thanks for the heads up @yavorg :o)
Cheers,
Jaime


Release the service manual v3.12.0

What
Release the service manual v3.12.0
To do

[x] Release
[ ] Clear cache for all pages with changes
[ ] Clear cache for CSS and JS

Clear cache on pages:
https://service-manual.nhs.uk/
https://service-manual.nhs.uk/sitemap

Hi @AdamChrimes
I thought i'd leave this note as a follow up regarding the old pages which have changed

// Add the code redirects for community-and-contribution pages
app.get('/community/contribution-survey', (req, res) => {
res.redirect('https://nhsdigital.eu.qualtrics.com/jfe/form/SV_5szVfoxZIW7Kr1b');
});
app.get('/community/backlog-of-components-and-patterns', (req, res) => {
res.redirect('/community-and-contribution/backlog-of-components-and-patterns');
});
app.get('/community/contribution-criteria', (req, res) => {
res.redirect('/community-and-contribution/contribution-criteria');
});
app.get('/community/develop-component-pattern', (req, res) => {
res.redirect('/community-and-contribution/develop-component-pattern');
});
app.get('/community/index', (req, res) => {
res.redirect('/community-and-contribution/index');
});
app.get('/community/propose-component-pattern', (req, res) => {
res.redirect('/community-and-contribution/propose-component-pattern');
});
/ REDIRECT STOPS HERE


remove "religious" and "political" from the list of offensive comments which can be harassment

As stated here : todogroup#75
the meme version : https://pbs.twimg.com/media/B7Wz261CIAAQLs4.jpg:large
While all other traits are intrinsically constitutive of the person, religion is only an opinion that anyone is free to change at anytime.
I do not welcome or advocate discrimination and harassment of people for their beliefs.
I really believe in respect of the person (and that it must be enforced), but do not think opinions are worthy of such respect. That would in fact be a dangerous idea for liberties.
However as stated in the policy now, it becomes harassment to merely offend religious people. That is extremely wrong. Religious people can chose to be offended by anything. According a "right not to be offended", is going counter to all advance by modern societies. Is is very wrong and very dangerous to put religions (just an other opinion) on the same level as intrinsic properties of what a person is : sex, genre, race, etc...
Historically (and still very much now!) religions have been the primary sources of obscurantism and persecutions. Societies fought back and began separating states and religions, according a right to blasphemy in many cases. The right to blasphemy has been primordial in freeing people from the control of churches.
Nowadays, we see a weakening of the Age of Enlightenment's philosophical advances : https://en.wikipedia.org/wiki/Age_of_Enlightenment
Religious groups everywhere try to weaken once again civil liberties by asking for this right to be offended and to forbid blasphemy.
Letting them having their way redefining what is socially acceptable would be a moral and philosophical regression. Accepting this would not be fighting against discrimination but calling for it.
Also, the word political was also removed because I honestly think that even if saying that "Nazi were dumb shit" may be offensive to Nazis, it is no harassment either.
Also, they are free to, and I hope would, change their mind as it is just opinions once again, not defining who they are as humans (I am an optimistic humanist).

Religious people can chose to be offended by anything.
All of the major religions have specific definitions of what is offensive or wrong, or how it can be justified in certain situations.  The most important of these rules are already in here anyway.

As you quoted, I said religious people not religions. Most are notoriously known to variously interpret their own sacred text according to the feeling of the day.

By who?

Some do take the 6000 years thing for hard evidence. But you do know that not all cretians are creationists
It is repetedly stated by scholars that nothing In the Coran make the veil necessary, many will have a progressive interpretation, but you still have those who would like to cover every women.
etc, etc ; it's not as if the texts where very precise anyway - That is why care to not offend their believers should not be attempted. This thinking would lead strait back to middle age.

This avoids my question to your response that you recently edited.  But then again I took this seriously when you said things such as:

strait back to the middle age

Religious groups everywhere try to weaken once again civil liberties by asking for this right to be offended and to forbid blasphemy.

Historically (and still very much now!) religions have been the primary sources of obscurantism and persecutions

This statement itself is already a contradiction.

I do not welcome or advocate discrimination and harassment of people for their beliefs... but do not think opinions are worthy of such respect. That would in fact be a dangerous idea for liberties.

You already assume that religions are dangerous and that ideas if I'm taking the meme link seriously, don't have rights when the freedom of speech grants every person and idea a voice.  Like what you think most religious people do, you are interpreting the text included in the OCoC to fit to your idea that religions are inherently dangerous and that this will allow them to be offended by "everything".  The fact that you made this pull request literally three hours after you tried to do this in #75 and copy-pasted every statement from there just proves you know that you are trying to twist it's words and want to remove it.
Religions are beliefs that should be considered with respect as any other opinion.
:-1:

That way leads to godwin law... You are not without knowing that as well as fascist religious extremists on one side, extreme right activists are also on the rise once again... But we should respect both?
Beliefs should not be considered with respect. Or nazi beliefs should also?

An other meme : https://i.imgur.com/2YqJfZ2.jpg
From someone who is persecuted and and whose life is endangered by religious extremists feeling offended.

This list must be interpreted using common sense, not finding "last straws". What is meant with "political or religious affiliation" is that community should not exclude, for example, a republican or Muslim just because someone or even majority of that community consists of democrats or Christians.
It is a basic human right to exercise religious and political beliefs, while not being ridiculed about them. This is a statement against discrimination, it is not a grant of privileges.
So instead of reading this like "I can't say anything about X religion because that might offend someone", instead you should read it like "I can't call religion X and followers insert Pulp Fiction levels of swearing here, just because I felt like doing so for no reason"*.
*Terms and conditions of common sense applies.

I understand and agree that - followers - of any religion are not to be sworn at. As any human being  they deserve respect.
However, if for example someone would like to say/draw/express ridicule things about an imaginary friend in order to satirize/criticize t said belief, some could (and many wrongfully do) take personal offense even if the attack is directed not at them but at said belief. Thus cutting debate and preventing speech.
That is the fundamental difference about respect of people versus opinions, and why the latter needs to be avoided.

ridicule things about an imaginary friend in order to satirize/criticize said belief, some could (and many wrongfully do) take personal offense even if the attack is directed not at them but at said belief.

You literally said there is something wrong with them for believing in their religion.

No, you do not understand grammar? I said It is wrong to personally take offense for criticism of your belief, not to be religious in the first place.
First because there is no right not to be offended in that case. Your party or religion being mocked is just that, it's not you being mocked.
As a believer whose religion (it is also true for any other kind of opinion or idea, political, etc...) got mocked or criticized, there are two options:

You can agree to disagree.
You can be convinced of changing belief. And that was is great with debating ideas. Try that with your race, you can't .  What you think is not.

As religion or political belief are just opinions, their are not intrinsically constitutive of your person.  And still free to change your mind anytime at the cost of reflection only. There are numerous examples of people changing political party, being converted to other religions or simply dropping them. That's is the power of debate and criticism.
For instance, as an optimist humanist, I do no hate xenophobic right wing extremists because I know (and hope) they can be convinced to change, I only despised their current ideology.
That is why ideas are way different than race, sex etc ...and should never be treated the same.

For an optimist you think "the right not to be offended" is going halt all advances of modern society and bring us straight back to the middle ages.
And for the Nazi part that you mentioned, come on; they are already not permitted under racism, homophobia and anti-antisemitism, the latter of which is something you want removed under this pull request of "religious-allficiation".  You have also edited your previous comments again, which just proves that you can't even keep your arguments and opinions straight.  At this point, you are trying to not understand what it means.
*tips fedora*

Yes, i do believe this new right not to be ofended is contrary to modern socities. Please Read about Salman Rushdie and philosophical advances made during the age of enlightenment.
As for editing my posts, I struggle with english wich is not my language. I realy want to carefully pick my words as I want to be clearly understood. I guess I do not do such a good job at it, even with edits, cause You still manage to put words in my mouth wich are contrary to what belive.

If you do struggle with English, which I find hard to believe, than who are you telling me that I don't understand grammar?  This conversation is over.

Who am I? Someone who puts lot of efforts to be precise clear and understable, and I expect as much effort from your part to understand me.
Your are the one who told that I "said there is something wrong with them for believing in their religion". This is not the case and is in fact co frary to what I stand for.
This is not the way of an honest debate, i expect more effort to at least corectly understand my point

I still don't see any relevance of what you say to what this list has defined. It says "Offensive comments related to [...] political or religious affiliation". Nowhere does it say "Offensive comments related to political or religious practice" - yet when I think of it, it probably should.
If you have valid criticism against religion in a context that actually has something to do with religion, you are welcome to execute your rights and criticize all you want.
 And you can not base your argument of essentially taking away a basic right to be free to believe whatever one wants to believe with a fear of being retaliated for mocking people.
Mocking or harassing an Idea or followers of given idea for no reason other than your personal views and beliefs is not acceptable, and it even has a few terms describing such actions - totalitarianism and plain old a-hole`ism - e.g. what you have been doing for this entire thread. And I am saying that as an person who is agnostic, so you wouldn't think that my opinion is somehow influenced by my religious beliefs or lack thereof.
Enough is enough.

Mockery of religion has not historically been used by those in power to discriminate minorities but on the contrary has been used by secularist minorities to undermine and free themselves from the prevalence of (state) religion.
For example, blasphemy and satirized mockery of the clergy was notoriously influential in separation of church and state in France and the fight to pass 1905's law.
As such, they are tools of freedom and anti-totalitarianism, and would still be plenty useful for those living in such countries today (and to prevent old ones to win back a so called right to be respected where such thing is luckily not recognized anymore).
Calling my discussion "totalitarianism and plain old a-hole`ism" is to be seen nice talk I guess?
That's very much uncalled for, and ironically, can not be more the exact opposite of what the evoked principles stand for.

For example, blasphemy and satirized mockery of the clergy was notoriously influential in separation of church and state in France and the fight to pass 1905's law.

Not that it matters much, because nothing you said bears any relevance to changes you made, but can you link to at least few authoritive sources to back this up?
Mockery of something is never tool of freedom and anti-anything, and never has been, it is a tool of either a) belittling b) entertainment and previous.
And you are still missing the point - the wording you removed is to prevent criticism against individual affiliation, not the subject individual is affiliated to. Hence, none of your arguments you made are relevant, nor valid.

Satiric press really started flourishing during the french revolution and is a direct emanation of the age of enlightenment's philosophers evoked before.It started mocking the king and was determinant making the people take arms against monarchy. Since then it has endlessly took on those in power, clergy included. Read up about it's influential role in social struggles:
https://fr.wikipedia.org/wiki/Presse_satirique
https://fr.wikipedia.org/wiki/La_Calotte
https://fr.wikipedia.org/wiki/L'Assiette_au_beurre
http://www.akadem.org/medias/documents/3_caricatures.pdf

I would add that contrary to what you said, mocking the ruling (political, moral, religious, etc) powers is very much an effective tool for those subject to these powers to undermine the sense of sacredness and thus fight on a more even plane. Again, see french kings.

Satire has been around for thousands of years, has many forms, and has served many purposes, including social causes. The fact that at some point in history something worked in favor of an idea and therefore should also be accepted in current time per se is sweeping generalization. Many things have happened during the history of human kind, some exceptional, some factors dependent.
In addition to that, I see two problems here - not all of us speak French, hence, linking a French wiki isn't really helpful to anyone except me and you maybe. Although your point point might be valid, assumption of which can be debated, I still don't see what has this to do with the argument at hand - it is a false attribution and serves no purpose other than avoiding the root problem of this PR.

Thanks for your feedback. See https://github.com/todogroup/opencodeofconduct/issues/84.


Current site infos in session / not possible to use shared cookie for multisite installations

Let's say I have foo.main-domain.com and bar.main-domain.com, both configured as django-cms sites. When I try to use
SESSION_COOKIE_DOMAIN = '.main-domain.com'

so my users would not need to login for each sub domain, the system behaves strange. It seems that the session keeps infos about current site, cached menu, etc, in the session, so it show for example the wrong menu (and the wrong site name in the toolbar)? I have the same problem (probably) when developing on my local machine (without SESSION_COOKIE_DOMAIN), it goes away when I work with foo.localhost and bar.localhost.

has already been discovered in #5609, I guess.

Closing as duplicate of https://github.com/divio/django-cms/issues/5310


feature request: behaviour when combining -i and -c

This is copy-pasted from downstream at https://github.com/cbm755/octsympy/issues/873.  The code I copied below might be from an older version and TBH I haven't even tried master.

We'd like to be able to combine -i and -c.

[ ] py.exe -i -c "import sys" should first run the -c stuff and then proceed interactively (-i).  This is how the CPython 2 and 3 interpreters behave, so I guess it can be called a compatibility fix.
[ ] in this case, it should not display the startup banner normally associated with -i.
[ ] it should work with a popen pipe (like py.exe -i currently does).

We want this for #864.

I took a look at the py.py code and I think we can probably change something here:
elif DirectCmd:
   sys.path[0:0] = [""]
   sys.argv = DirectCmd
   exec DirectCmd[0] in globenv
else:
   if Interactive=="check":
      Interactive = sys.stdin.isatty()
   sys.path[0:0] = [""]
   if Interactive:
      import code
      cons = code.InteractiveConsole(locals=globenv)
      if not sys.stdout.isatty():
         cons.raw_input = alternate_raw_input
         if not Unbuffered:
            sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0)
            sys.stderr = os.fdopen(sys.stderr.fileno(), 'w', 0)
      cons.interact()

Currently, if DirectCmd is true, we never get to the interactive bits.

Just noticed you have new releases here: maybe v13 already does what I need... :-)

@cbm755 Yes -- this works correctly now (and there is even a test for it).  I'll close this -- feel free to reopen if it doesn't do what you expect.


Feedback from DjangoCon

Leave your comments and feedback about the Django for Designers tutorial here!

There is no touch command for the windows command line but you can copy an empty file with some special flags: http://superuser.com/questions/10426/windows-equivalent-of-the-linux-command-touch


seqfault

I am running moOde os on raspberry pie zero, when I try follow the instruction i get a segmentation fault when  I run ./spotify-connect-web .

Sorry for the late reply.  I was out of town.
My instructions are mainly a compilation of how-tos from Moode and spotify-connect-web.  If spotify-connect-web is throwing segmentation errors, your best bet is to ask them directly, although I believe they have abandoned work on the project.
Just a few things to make sure:

Did you installed the avahi dependencies?
Are you running the spotify-connect-web with the correct parameters? Can you share the exact command you are using and the exact error that is thrown?

Sorry not being of more help, I only have an RPi3 so no idea what could be going on with the zero.
Best regards,
Rafa.


Show more detailed query errors from postgres_backend

Currently we only log (and send an ErrorResponse with) the outermost context of the error. With this, we log the full cause of the error, but still only send an ErrorResponse with the outermost context -- IMO it's not relevant to the client (typically walproposer).

@hlinnaka Sure -- here's a comparison:
Before:
Sep 22 12:52:10.575 WARN query handler for b"START_WAL_PUSH\0" failed: failed to start push replication to page server

After:
Sep 22 12:52:10.575 WARN query handler for b"START_WAL_PUSH\0" failed: failed to start push
replication to page server: Failed to connect to pageserver postgresql://no_user:eyJ0eXAiOi
JKV1QiLCJhbGciOiJSUzI1NiJ9.eyJzY29wZSI6InBhZ2VzZXJ2ZXJhcGkifQ.smwAayctubprJbzgM_D1_qD4mRTux
ihgPE6Dgnmc3IY-sFD4yKFaNZhHNDaBrM1SCunHf9S4R542tZUHwZVig5KPUQgr5BAUc11I1LC-Kc7fmyKwBiGXicmA
5UWZ_lF67xiZ8rt_JhpZwMprlPJh9-yKmqXNTRadmVkBsqINTMOc1mlliJCYtQ5rE1bcJbutq0VwmjP5dbEysSTBHl1
QS_GqNMh7WFNiRV-77en29aJ_tLCmMs-cXa0PMNo6OQ4ziSz1MQKLOCI7NIhE3Lgp3FYtqctAQqzNhCUX38a1Jj4c3t
ywckNxWSmd3jmJwAOZ9SCWCg7Ml4KPiwSRbvyJ1g@localhost:15000/no_db: error connecting to server:
 Connection refused (os error 111): Connection refused (os error 111)

(I inserted newlines into the second one for readability, but it's all just one big line)
In some ways it's a bit too much, but a lot of that is coming from that pageserver connection string and the other parts are useful


[Update] Handle undefined wallet address in WalletAddress component

#4523  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite


Fix bug in CFStream endpoint

We were failing to return an error when the transport tried to write to an endpoint that was in an errored state.

Thanks for the PR Prashant. It is awesome finding!

Failures: #18424, #14094, #18523

Thanks for the review!


World Boarder Resetting on Server Reload

I am using the World Border plugin on my server, and it was working just fine! And then out of the blue the border just starts to reset back to default config . I deleted the config to 'reload' the config because maybe the config changed? It did not.
I am now getting an internal error message when I even try to set the border with the 'reloaded' config.

The command under the chat box is the command I typed.
Config file:
cfg-version: 11
message: '&cYou have reached the edge of this world.'
round-border: true
debug-mode: false
whoosh-effect: true
portal-redirection: true
knock-back-dist: 1.0
timer-delay-ticks: 5
remount-delay-ticks: 0
dynmap-border-enabled: true
dynmap-border-message: The border of the world.
player-killed-bad-spawn: false
deny-enderpearl: true
fill-autosave-frequency: 30
bypass-list-uuids:
-- 939258e6-b7c8-40b2-8778-854ddbab986b
fill-memory-tolerance: 500
prevent-block-place: true
prevent-mob-spawn: true
dynmap-border-hideByDefault: false
dynmap-border-priority: 0
The ' -- ' next to the UUID is really only one ' - '

That's definitely not normal, and I haven't heard of this error before. What version of Spigot are you using, and what version of WorldBorder (are they listed as compatible)? Can you post the server log from when you got that "internal error"?

[15:30:37] [Server thread/INFO]: blazex224 issued server command: /wb set 17500 17500
[15:30:37] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'wb' in plugin WorldBorder v1.9.0
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[spigot121.jar:git-Spigot-edd0396-2a927e8]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot121.jar:git-Spigot-edd0396-2a927e8]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchCommand(CraftServer.java:641) ~[spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.PlayerConnection.handleCommand(PlayerConnection.java:1386) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1221) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.PlayerConnectionUtils$1.run(SourceFile:13) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_121]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_121]
at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:46) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:748) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [spigot121.jar:git-Spigot-edd0396-2a927e8]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
Caused by: java.lang.NoClassDefFoundError: Could not initialize class com.wimbli.WorldBorder.BorderData
at com.wimbli.WorldBorder.Config.setBorder(Config.java:95) ~[?:?]
at com.wimbli.WorldBorder.cmd.CmdSet.execute(CmdSet.java:142) ~[?:?]
at com.wimbli.WorldBorder.WBCommand.onCommand(WBCommand.java:141) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[spigot121.jar:git-Spigot-edd0396-2a927e8]
... 15 more

latest.log

You are running WorldBorder 1.9.0 on Spigot 1.12. WB 1.9.0 is only compatible with Spigot 1.13+.
For older versions:
https://dev.bukkit.org/projects/worldborder


UForm errors

Description
Sometimes is necessary to disable a component based in error validations, it would be useful to have the errors object in the default slot.
Thanks.
Additional context
No response

Did you try the API?: https://ui.nuxt.com/components/form#api
//...

<template>

    <UAlert v-if="formRef?.errors.length" color="red" title="Error!" />
    <UForm ref="formRef" ...>...</UForm>

</template>

Also FormGroup error:
https://ui.nuxt.com/components/form-group#error
https://ui.nuxt.com/components/form-group#error-1

Did you try the API?: https://ui.nuxt.com/components/form#api
//...

<template>

    <UAlert v-if="formRef?.errors.length" color="red" title="Error!" />
    <UForm ref="formRef" ...>...</UForm>

</template>

Also FormGroup error: https://ui.nuxt.com/components/form-group#error https://ui.nuxt.com/components/form-group#error-1

Yes, but it would be useful also have the variables in the default slot.


tech report or docs

hi,
thanks for your awesome work!
when will your release the tech report or docs for current work like MiniCPM-Llama3-V 2.5 and MiniCPM-V 2.0?
thanks

coming soon


system tests: reenable skipped tests

Issue #3829 (cp symlinks) has been fixed: enable tests for it
And, it looks like podman-remote is now handling exit status
of a force-rm'ed container. Enable that test too.
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

/approve

Test failure was a flake, restarted
LGTM

/lgtm
/hold
hold cancel when tests pass.

/hold cancel


fixing max parallelism

TL;DR
Removing the BarrierTick code from the TaskHandler resulted in scenarios where parallelism is not incremented when tasks are frequently evaluated with no change in phase / phase version. This can result in more task executing in parallel than configured.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/3883
Follow-up issue
NA

is there any way we can verify this behavior with a local test (or a relatively cheap automated test)?


add gcs hyperlinks based on tags in anki template

given a tag and target language, generate the links to the relevant stories in GCS, do this in back_template.html

done as part of previous merge


[Doc] Add more pipeline details

Still need to add a bit more detail on how the long division algorithm works but not yet sure if it's latency is fixed or if it has an early out (looking at the state machine looks like there is a data dependent way for it to finish early).
I'd suggest looking at the actual rendered docs.  You just need to checkout my pipeline_docs branch and do a 'make html' in the doc/ directory.  You may need a 'make clean' beforehand as I've seen it fail to correctly rebuild in some cases.

What I forgot to mention: please link the pipeline details page on the introduction page!

@vogelpi are you happy I've addressed everything?

Thank you for all of the useful feedback @imphil @vogelpi @tomroberts-lowrisc @asb


Updated for VC2014 build tools

I merely opened the XZ project in Visual Studio Community edition (2015) and hit "update"
This has resolved the build not breaking for VC2014/2015 which report the project as being "out of date"

Thanks!


com.datastax.oss.driver.api.core.connection.ConnectionInitException

when I use jdk17 compile and test, it will report this error.  I don't know how to solve this problem. do you have meet this issue.
I have see ChannelHadlerRequest's method names writeListener it will timeout.
private void writeListener(Future<? super Void> writeFuture) {
if (writeFuture.isSuccess()) {
timeoutFuture =
channel.eventLoop().schedule(this::onTimeout, timeoutMillis, TimeUnit.MILLISECONDS);
} else {
String message =
String.format("%s: failed to send request (%s)", describe(), writeFuture.cause());
fail(message, writeFuture.cause());
}
}

insufficient detail


Issue "Cannot read property 'findLis' of undefined"

When bootstrap-select was created dynamically on modal window and I close it then error occurred:
'Cannot read property 'findLis' of undefined'.
This code prevent for that.

Please provide an example of the issue.


Update issue template to make the debug log optional

Hallo
Concerning your build: https://travis-ci.org/xbmc/Kore/
It fails, becasue https://maven.google.com/ is no longer a valid repository.
Can you please change your repositories to
repositories {
    google()
    jcenter()
}

in buildscript and allprojects of [PROJECT_ROOT]/build.gradle
Regards
Erik

@erudisch Thanks for the heads up. Should be fixed now.


MSVC build libs have suffix

On Windows, the libraries have a suffix of the form: -vc140-mt-4.14.1.lib.
I am unsure if this is intentional?
I think it would be nice if it was shipped without the suffix.

This was the output from a CGAL build, so it seems ok (as long as CMake is able to find the coorect libs). But note that this is from the cgal-cpp package, and newer versions don't include libs anymore (cgal-cpp became a header-only package)


Updated README.md

Added normative language disclaimer (which itself uses a normative keyword - how meta!)
Removed other normative keywords

I would prefer to see something in the Overview instead.
The specs have this:

Use of Normative Language
The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

So how about, after the Scope section in the implementation guide Overview, something like:

Use of Normative Language
This document is a guide to the AMWA NMOS security specifications. It is not a specification itself, it provides informational guidance around the normative requirements of the relevant specifications. Any normative language key words found in this document are not to be interpreted as RFC 2119 key words.

It's hard to phrase!

I feel that it is worth mentioning in both places.
The Overview already has this caveat at the end:

Specification Precedence
This guide is not a substitute for the NMOS Specifications. If there are any inconsistencies between this guide and the specifications, please assume that it is the specification that is correct.

I suggest we replace that section with the following, and move it so it's after Scope. But keep the declaimer in the README.md.

Use of Normative Language
This document is a guide to the AMWA NMOS security specifications only and not a specification itself.
It provides informational guidance around the normative requirements of the relevant specifications but any normative language key words found in this document are not to be interpreted as RFC 2119 key words.
If there are any inconsistencies between this guide and the specifications, please assume that it is the specification that is correct.

WDYT?

This repository holds the source for this Specification

Can you please tweak the opening sentence for the README as well?


Converted the request to an async function

There we go!

Coverage remained the same at 100.0% when pulling 95ffeb4e0949a529490e02c1c0b89d54ec6c531b on egdavid:dev into 05829987c1a5063aca6b2528b00375a5786393a4 on react-boilerplate:dev.


Better image cache clearing options

- update on image updates

[ ] update on referenced updates
[ ] allow a ui cache clear

I think we are ok with this one


"Can't perform a React state update on an unmounted component." - Third party router listener not disposed in time?

🐛 Current behavior
When loading a page with the InstantSearch component that syncs with a third party router via start and dispose, then navigating away, the following error occurs: Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function..
🔍 Steps to reproduce

Load the initial page that renders the InstantSearch component, which is synced to a third party router (react-router-dom) via start and dispose.
Navigate away by pressing a Link, and the error should appear in the console.

Live reproduction
https://codesandbox.io/p/sandbox/hopeful-night-flhh3j?file=%2Fsrc%2FApp.tsx
💭 Expected behavior
I would expect the dispose function to be run in time so that there is no attempt to sync the URL, which results in the state update on an unmounted component.
Package version
instantsearch.js 4.60.0, react-instantsearch 7.3.0
Operating system
macOS 13.2.1
Browser
Chrome 119.0.6045.159
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@adambremler I have this exact problem, but with Next.js's router, and I can't fathom how to solve it. Did you sort it out in the end?

Dispose indeed happens after the widget and component is unmounted, to prevent it being called twice during strict mode. React Router should be synchronisable with the history router directly, similar to the next integration: https://github.com/algolia/instantsearch/blob/master/packages/react-instantsearch-router-nextjs/src/index.ts#L99-L175, have you tried that?

I am having a similar issue with InstantSearchNext:
"Can't perform a React state update on a component that hasn't mounted yet. This indicates that you have a side-effect in your render function that asynchronously later calls tries to update the component."
I am not 100% sure what is causing the error. Replacing InstantSearchNext with InstantSearch-Component seems to resolve the issue. @Haroenv Could this be related? Or should I create a new issue?

please provide a reproducible example indeed @Ra0R.


Misclassification of WM hypointensities in FS to 5TT pathological tissue?

Using 5ttgen to generate 5TT image from FS segmentation in
https://github.com/sotnir/NENAH-BIDS/blob/1a876927a97560a0e1922c6178cb0f3caca49e41/dMRI/5tt.sh#L84-L88
This is the result for NENAH002 which shows misclassification around ventricles with 5TT = pathological tissue.

When checking in FS segmentation, it corresponds to 77 (=WM-hypointensities) in FS aparc+aseg

In 5ttgen, the conversion of WM hypointensities is to pathological tissue

So this can be manually changed as a solution

However, when looking at the FOD (estimated with dhollander, i.e. not using ACT information) then this area describes coherent WM.
In this image with FODs and an overlaid 5TTvis-image

So, should be kept.

But when using ACT in tckgen, we have streamlines going through here...


cups-drivers: Brother HL-L3230CDW driver version 1.0.2-0

Description of changes
Add cups drivers for Brother HL-L3230CDW
Things done

Built on platform(s)

[ x ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The brother scripts and binaries use the location of the files in /opt/brother to figure out parameters like the name of the printer.  It isn't really possible to move them around.  I've tried to take approaches in other brother drivers to compensate for this as much as possible.  I'm still a little confused as to what's going on with the linker as the fixup doesn't seem to change the interpreter parameter in the ELFs.


Akavache and Newtonsoft.Json Conflict?

Hey,
I have an issue with Akavache and my fully working Xamarin Forms App.
It occurs when I use JsonConvert.DeserializeAnonymousType(responseText, definition);
This has been working perfectly before.
System.TypeLoadException: Could not load type Xamarin.Forms.Platform._LabelRenderer, Xamarin.Forms.Platform, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null while decoding custom attribute
Cross-Post:
http://forums.xamarin.com/discussion/46608/akavache-newtonsoft-and-ios-throwing-typeloadexceptions?new=1

That doesn't look like an Akavache issue, look at the exception message, it tells you that it can't load Xamarin.Forms.Platform._LabelRenderer

Full Exception Log:
System.TypeLoadException: Could not load type Xamarin.Forms.Platform._LabelRenderer, Xamarin.Forms.Platform, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null while decoding custom attribute
2015-07-24 12:38:25.671 KinsmenAppiOS[5643:1069728] Unhandled managed exception:
Could not load type Xamarin.Forms.Platform._LabelRenderer, Xamarin.Forms.Platform, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null while decoding custom attribute (System.TypeLoadException)
at (wrapper managed-to-native) System.MonoCustomAttrs:GetCustomAttributesInternal (System.Reflection.ICustomAttributeProvider,System.Type,bool)
at System.MonoCustomAttrs.GetCustomAttributesBase (ICustomAttributeProvider obj, System.Type attributeType, Boolean inheritedOnly) [0x00019] in /Users/builder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System/MonoCustomAttrs.cs:103
at System.MonoCustomAttrs.GetCustomAttributes (ICustomAttributeProvider obj, System.Type attributeType, Boolean inherit) [0x00344] in /Users/builder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System/MonoCustomAttrs.cs:263
at System.MonoCustomAttrs.GetCustomAttributes (ICustomAttributeProvider obj, Boolean inherit) [0x0002a] in /Users/bui
lder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System/MonoCustomAttrs.cs:286
at System.MonoType.GetCustomAttributes (Boolean inherit) [0x00000] in /Users/builder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System/MonoType.cs:609
at Newtonsoft.Json.Utilities.ReflectionUtils.GetAttributes (System.Object attributeProvider, System.Type attributeType, Boolean inherit) [0x0001f] in :0
at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAssociateMetadataTypeFromAttribute (System.Type type) [0x00000] in :0
at Newtonsoft.Json.Utilities.ThreadSafeStore2[System.Type,System.Type].AddValue (System.Type key) [0x00000] in <filename unknown>:0    at Newtonsoft.Json.Utilities.ThreadSafeStore2[System.Type,System.Type].Get (System.Type key) [0x00010] in :0
at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAssociatedMetadataType (System.Type type) [0x00000] in :0
at Newtonsoft.Json.Serialization.JsonTypeReflect
or.GetAttribute[JsonContainerAttribute] (System.Type type) [0x00000] in :0
at Newtonsoft.Json.Serialization.JsonTypeReflector.GetAttribute[JsonContainerAttribute] (System.Object provider) [0x0000a] in :0
at Newtonsoft.Json.Utilities.ThreadSafeStore2[System.Object,Newtonsoft.Json.JsonContainerAttribute].AddValue (System.Object key) [0x00000] in <filename unknown>:0    at Newtonsoft.Json.Utilities.ThreadSafeStore2[System.Object,Newtonsoft.Json.JsonContainerAttribute].Get (System.Object key) [0x00010] in :0
at Newtonsoft.Json.Serialization.CachedAttributeGetter1[Newtonsoft.Json.JsonContainerAttribute].GetAttribute (System.Object type) [0x00000] in <filename unknown>:0    at Newtonsoft.Json.Serialization.JsonTypeReflector.GetCachedAttribute[JsonContainerAttribute] (System.Object attributeProvider) [0x00000] in <filename unknown>:0    at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract (System.Type objectType) [0x00017] in <filen ame unknown>:0    at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract (System.Type type) [0x00038] in <filename unknown>:0    at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.CalculatePropertyValues (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContainerContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonProperty property, Newtonsoft.Json.Serialization.JsonContract& memberContract, System.Object& memberValue) [0x00053] in <filename unknown>:0    at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeObject (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonObjectContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0003c] in <filename unknown>:0  --- End of stack trace from p revious location where exception was thrown ---   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000b] in /Users/builder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System.Runtime.ExceptionServices/ExceptionDispatchInfo.cs:61    at System.Reactive.PlatformServices.ExceptionServicesImpl.Rethrow (System.Exception exception) [0x00006] in <filename unknown>:0    at System.Reactive.ExceptionHelpers.ThrowIfNotNull (System.Exception exception) [0x0000d] in <filename unknown>:0    at System.Reactive.Subjects.AsyncSubject1[System.Collections.Generic.List`1[KinsmenApp.Models.KinsmanStatusModel]].GetResult () [0x00039] in :0
at KinsmenApp.ViewModels.KinsmanPageViewModel+d__6.MoveNext () [0x000ee] in c:\Users\Arbeit\git\HnrKinsmen\KinsmenApp\ViewModels\KinsmanPageViewModel.cs:119
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000b] in /Us
ers/builder/data/lanes/1926/6916d0e3/source/mono/mcs/class/corlib/System.Runtime.ExceptionServices/ExceptionDispatchInfo.cs:61
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.m__0 (System.Object state) [0x00000] in /Users/builder/data/lanes/1926/6916d0e3/source/mono/external/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:1006
at UIKit.UIKitSynchronizationContext+c__AnonStorey0.<>m__0 () [0x00000] in /Users/builder/data/lanes/1926/6916d0e3/source/maccore/src/UIKit/UIKitSynchronizationContext.cs:24
at Foundation.NSAsyncActionDispatcher.Apply () [0x00000] in /Users/builder/data/lanes/1926/6916d0e3/source/maccore/src/Foundation/NSAction.cs:164
at (wrapper managed-to-native) UIKit.UIApplication:UIApplicationMain (int,string[],intptr,intptr)
at UIKit.UIApplication.Main (System.String[] args, IntPtr principal, IntPtr delegate) [0x00005] in /Users/builder/data/lanes/1926/6916d0e3/source/maccore/src/UIKit/UIApplication.cs:63
at UIKit.UIApplic
ation.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0001c] in /Users/builder/data/lanes/1926/6916d0e3/source/maccore/src/UIKit/UIApplication.cs:46
at KinsmenApp.iOS.Application.Main (System.String[] args) [0x00001] in c:\Users\Arbeit\git\HnrKinsmen\iOS\Main.cs:16

As you can see it is definitely Newtonsoft.Json. And as this did work like charm before my conclusion shouldn't be wrong that there might be a versioning conflict with akavache.

It seems like you're trying to serialize types that have XamForms attributes on them, Don't Do That

Thanks a lot for the quick response. I get why you would think that, but this is my actual model which i am passing as "definition":
public class KinsmanStatusModel
{
    /*
     * Properties and fields to store
     */

    [PrimaryKey, AutoIncrement, Column("_id")]
    private int Id { get; set; }

    public string Message { get; set; }
    public string Reason { get; set; }
    public string Measure { get; set; }
    public DateTime Date { get; set; }
    public KinsmanStatusType StatusType { get; set; }
}

What are the fully qualified names of PrimaryKey, AutoIncrement et al?

I updated all the references (nugets, plugins and so on) to the current and latest ones.
If I use akavache at any point the exception above gets thrown.
e.g.: This single line causes the mentioned error:
BlobCache.LocalMachine.InsertObject("StatusHistory", task.Result);
But your first intention might be right.
I am having a corresponding style theme for my model which I added to the model for XAML and Binding reasons (as an overall active app theme depending on a reallife emergency status).
With SQLite I am simply ignoring it with the annotation [Ignore], Akavache tries to cache that as well, as it seems.
    [Ignore]
    public StyleTheme CorrespondingStyleTheme
    {
        get { return _correspondingStyleTheme ?? (_correspondingStyleTheme = StatusType.StyleTheme()); }
        set { _correspondingStyleTheme = value; }
    }

At some point in this StyleTheme I am referencing a possible Property to a Icon which will be rendered platform specific to a font-icon using LabelRenderer, that's why it throws the label exception.
Is there a way to ignore certain properties when caching them?
Or will I need to refactor this part and move it to some external helper for example?
Thanks paul, your questions helped me a lot to figure out what the root cause actually is.

@ThomasKIT Use the Newtonsoft.Json.JsonIgnoreAttribute

Guys, thanks a lot for your support, this did the trick.

Is it still actual? why there is also Akavache.Sqlite3.Internal.IgnoreAttribute? when do we use Akavache.Sqlite3.Internal? I thought Akavache is using Sqlite3 so it should be just Ignore, no?


[BUG] - Build Error 1.19.0 on CentOS 7

External
Summary
cabal build all is failing on tags/1.19.0 on CentOS 7
Steps to reproduce
Steps to reproduce the behavior:

Checkout cardano-node tags/1.19.0
run cabal clean && cabal update
run cabal build all
Receive error during build related to cryptonite

Expected behavior
Expect node to build binaries for running 1.19.0
System info (please complete the following information):

OS: CentOS
Version: 7.8.2003
Node version: 1.19.0

Screenshots and attachments

See attached cryptonite error log dump.

Additional context
Double checked that yum update && yum upgrade were performed and that all requisite packages had been installed.
cardano-node.1.19.0.cryptonite.error.log

Does your CPU support AES-NI and SSSE3?
If not, we can indicate to cryptonite not to use AES-NI: after your step 2, create a cabal.project.local file in the root of your cardano-node checkout with the following contents:
package cryptonite
  flags: -support_aesni

Continue with cabal build all.

Okay, can confirm that following the recommendation from @mark-stopka above the following worked to successfully build on my environment:
cabal build all --constraint="cryptonite -support_aesni"

That should actually have the same effect as what I suggested :thinking:. Anyway, thanks @mark-stopka for suggesting this.
Closing as this is due to a known problem with CentOS 7 and we have found a workaround that works for @Crypto2099.

@mrBliss I also though that the mentioned use_target_attributes flag would do it, not the one you've mentioned, I suppose he must've apply your suggestion with cabal.project.local wrong...

Hi there,
I tried to fix with  cabal build all --constraint="cryptonite -support_aesni" and then run $CNODE_HOME/scripts/cabal-build-all.sh -o but it does not help me fix this issue.
Any clues?


Endpoint is on a different host than authority

Hi Guys,
I get an error when I am creating the console client from the samples: Endpoint is on a different host than authority: http://localhost:5000/.well-known/openid-configuration/jwks
Does anyone know what this means?

What's your authority?

Are you on the latest samples? What's your version of IdentityModel you are using?

Hi Dominick,
I corrected the issue by updating from version 2.2 to version 2.5. It was
an issue in the logic of the DiscoveryResponse Object ValidateEndpoint
function.
On Tue, Jan 31, 2017 at 2:47 AM, Dominick Baier<EMAIL_ADDRESS>wrote:

Are you on the latest samples? What's your version of IdentityModel you
are using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IdentityServer/IdentityServer4.Samples/issues/111#issuecomment-276296189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMvAW0kyQo_1ZYyfcvBU7GTo3pdNljhOks5rXuclgaJpZM4LyBVL
.


Expectation with method missing self.class.define_method name && send(name) fails

Subject of the issue
This https://github.com/drapergem/draper/blob/master/lib/draper/helper_proxy.rb
require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "rspec", github: "rspec/rspec"
  gem "rspec-core", github: "rspec/rspec-core"
  gem "rspec-expectations", github: "rspec/rspec-expectations"
  gem "rspec-mocks", github: "rspec/rspec-mocks"
  gem "rspec-support", github: "rspec/rspec-support"
end

require 'rspec'

class ViewContext
  def xxx
  end
end

class Proxy
  def initialize
    @view_context = ViewContext.new
  end

  def method_missing(name, *args, **kwargs, &block)
    self.class.define_method(name) { @view_context.send(name) }
    send(name)
  end
end

# If this is uncommented — everything works
# Proxy.new.xxx

RSpec.describe 'fail' do
  subject { Proxy.new }

  it do
    expect(subject).to receive(:xxx).and_call_original
    subject.xxx
  end
end

RSpec::Core::Runner.invoke

Your environment

Ruby version: 2.6.5
rspec-mocks version: git main

Steps to reproduce
Run testcase
Expected behavior
It works!
Actual behavior
Failures:

  1) fail is expected to receive xxx(*(any args)) 1 time
     Failure/Error: send(name)

     SystemStackError:
       stack level too deep
     # /tmp/tst.rb:29:in `method_missing'
     # /tmp/tst.rb:29:in `method_missing'

Wow, interesting find. Thanks for reporting.

This is because we "stash" the original method at the time of the expectation, to later invoke if needed, in this case it appears we stash the method missing implementation, which I don't think is the intent, so when later defined it doesn't (indeed can't) short circuit.
As an aside I would say this kind of expectation is not something we would recommend as a good idea; you're asserting that a method is called, then calling it, which in itself is pretty pointless. If you tested the side effects of calling this method you wouldn't see this bug.


DS-647 Academy Doc Pages Move

Jira
https://pegadigitalit.atlassian.net/browse/DS-647
Summary
Academy docs pages were moved
Details

Academy was moved from The Pages folder to the Tests folder.
Twig namespace paths in docs-site/.boltrc.js were updated
Import in the doc-site/src/index was updated

How to test
Pull the branch make sure docs were moved properly and there are no regressions.

@danielamorse approved this PR, can you take a quick peek since this involves a directory you work in mostly


Release azure-cli-feedback 0.1.2rc1

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Release of 'azure-cli-feedback' with version '0.1.2rc1' successful. View at https://pypi.python.org/pypi/azure-cli-feedback/0.1.2rc1.

GitHub release created. https://github.com/Azure/azure-cli/releases.


feature: multiple root paths

This feature allows to pass an array as path argument to create an
overlay. The first matched file will be used for size and modified date.
The response functions (html/json/plain) will be called with a different
set of parameters

next was moved on 3rd place to align with default middleware
functions
files array contains an object (name,path) instead of just the name
to allow accessing the files as they can be located in different dirs
removed path as it is contained in files and can be different for
each file

Most of the tests were changed to run with this feature by splitting up
the fixtures into two sub-folders. There are some duplicate files by
intent to test that only the first match will be used and no duplicates
are served as index.
fixes https://github.com/expressjs/serve-index/issues/24

I've added an 'caseSensitive' option.

Nice :) I haven't had a chance to check out what the test failure is yet.

Sorry I never got around to looking into the test failure for you; from the testing, you should be able to reproduce the error on your local machine just by running npm test, right? If so, please feel free to update the PR with passing tests, otherwise let me know if when you run npm test on your machine it doesn't fail.

The test actually worked on my local machine (OS X). I guess the problem might be due to the file-system, but I thought travis runs on some UNIX system as well.
Nevertheless I think it might be better to build a separate module which suits my concrete needs instead of making this simple one unnecessarily complex just to make my use case working.
Anyway thanks a lot for your help! :+1:

Gotcha. So, I haven't looked super-closely at your tests, but this could be explained if the tests are relying on file system case-sensitivity or not. You see, in Mac OS X (as in Windows), by default the file system is case-insensitive, while in Linux (Travis CI) by default the file system is case-sensitive.

Though I see now that the tests didn't pass on AppVeyor, either, which is Windows on a case-insensitive file system. I would almost say perhaps there is an issue with the commit itself. Perhaps you could reproduce it by re-cloning your branch from scratch and then running the tests to see if they work or not (which is starting from a clean slate like AppVeyor/TravisCI does).

You're right. I now also failed locally. Anyway, thanks!


get_now_playing does not contain album and coverart

Hi -- Great library!
Got a little request for the get_now_playing function.
Since only the artist and the title are stored, the album information gets lost.
If you want to display the cover for the currently playing track, most of the time it's wrong because you have to 'search' for the album based on the artist's name and the track's name.
Since the last.fm api already has this information inside the User.getRecentTracks call (album name and current coverart), it would be great if this would be returned by the get_now_playing function!

Good idea, this could be done similar to https://github.com/pylast/pylast/pull/307 for user.get_top_albums.


modern build includes core-js 3

Version
v2.11.0
Reproduction link
https://hokify-data.s3.eu-central-1.amazonaws.com/empty-app-shared-components.zip
Steps to reproduce

use a nuxt template starter e.g.: npx create-nuxt-app test
edit nuxt.config.js and add under build:

build: {
    babel: {
      presets({ envName }) {
        return [
          [
            '@nuxt/babel-preset-app',
            {
              corejs: { version: 3 }
            }
          ]
       ]
     }
}

comment: it's also happening with core-js2, but it seems with less modules included. e.g. there is no promise polyfill, which should not be there anyways but is with core-js3 (see what is actually happening).

run npm run analyze

What is expected ?
core-js should not be included, or at least only the minimum stuff that is somehow still needed in modern builds? are there any though?
What is actually happening?

Additional comments?
i'm not sure if this is maybe expected, but couldn't find any valid reason. according to esmodule babel documentation, promise is definitely supported in this case (https://www.ecma-international.org/ecma-262/6.0/#sec-promise-constructor) and therefore I see no reason why e.g. this one is included. I guess this is true also for the other includes.
In copmarison to the client build, there a are a lot less modules included already, but shouldn't it actually be gone at all?

This bug report is available on Nuxt community (#c10189)

Hi @simllll , thanks for the issue reporting.
For modern build, modern browsers is decided by targets.esmodules of @babel/preset-env, but even for some modern browsers, es.promise in core-js is still needed as they are not fully supporting promise specifications, like https://github.com/zloirock/core-js/issues/565#issuecomment-495987453 described.
If you're 100% sure that you don't need the polyfills, you can use exclude to exclude them:
NOTE(Dangerous): This may break some unfully supported functionalities in modern browsers
export default {
  modern: 'server',
  build: {
    babel: {
      presets({ envName }, [preset, options]) {
        options.corejs = { version: 3 }
        if (envName === 'modern') {
          options.exclude = ['es.promise']
        }
      }
    }
  }
}

Thank you for the great insights! Makes totally sense now, perfect summary of what's going on! Closing this now, should we link this issue from @nuxt/babel-preset-app as further explanation for polyfills and modern build?


Timing type with missing event field crashes application in ResourceIndexer with NPE.

Describe the bug
Timing (http://hl7.org/fhir/datatypes.html#Timing) type with missing event crashes application in ResourceIndexer with NPE.
2022-04-06 15:38:07.496 9331-9331/org.smartregister.fhircore.quest E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.smartregister.fhircore.quest, PID: 9331
    java.util.NoSuchElementException
        at com.google.android.fhir.index.ResourceIndexer.dateTimeIndex(ResourceIndexer.kt:190)
        at com.google.android.fhir.index.ResourceIndexer.extractIndexValues(ResourceIndexer.kt:84)
        at com.google.android.fhir.index.ResourceIndexer.index(ResourceIndexer.kt:68)
        at com.google.android.fhir.db.impl.dao.ResourceDao.insertResource(ResourceDao.kt:202)
        at com.google.android.fhir.db.impl.dao.ResourceDao.insertAll$suspendImpl(ResourceDao.kt:74)

Component
Core library
To Reproduce
Steps to reproduce the behavior:

Add a CarePlan with Timing field and no 'event' and save into DB

{
	"resourceType": "CarePlan",
	"status": "active",
	"intent": "plan",
	"title": "Child Routine visit CarePlan",
	"description": "This defines the schedule of care for patients under 5 years old",
	"subject": {
	    "reference": "Patient/36eb5dae-cdff-4049-9dce-470fe286cc9e"
	},
	"period": {
	    "start": "2022-04-06T00:00:00",
	    "end": "2026-12-01T00:00:00"
	},
	"created": "2022-04-06T13:55:50+00:00",
	"activity": [
	    {
		"detail": {
		    "kind": "Task",
		    "code": {
		        "coding": [
		            {
		                "system": "http://terminology.hl7.org/CodeSystem/v3-GTSAbbreviation",
		                "code": "MO",
		                "display": "MO"
		            }
		        ],
		        "text": "MO"
		    },
		    "status": "in-progress",
		    "scheduledTiming": {
		        "repeat": {
		            "count": 55,
		            "countMax": 60,
		            "duration": 2,
		            "durationMax": 4,
		            "durationUnit": "h",
		            "frequency": 1,
		            "frequencyMax": 1,
		            "period": 1,
		            "periodMax": 1,
		            "periodUnit": "mo"
		        }
		    },
		    "description": "Child Monthly Routine visit"
		}
	    }
	]
}

2- Right after save when indexing it would crash and would save if any value is added to timing.event.
ResourceIndexer L#185 should not use max and assumes a non null/empty event field
"Timing" -> {
        val timing = value as Timing
        DateTimeIndex(
          searchParam.name,
          searchParam.path,
          timing.event.minOf { it.value.time },
          timing.event.maxOf { it.precision.add(it.value, 1).time } - 1
        )
      }

Expected behavior
It should not crash as event is nullable by spec http://hl7.org/fhir/datatypes.html#Timing.

I think it would be quite a lot harder to handle the repeat cases in the timing object...
in this pr we probably should focus on the case without repeat.
and we should probably raise another issue to handle repeat (low priority).


[Run][New Plugin] Translation plugin

Request integrated translation function
for example：
/t one to CH
return:"一"
/t one to JP
return:"一つ"

It would be so nice to have a plugin for this, but no one seems to care about it :'(

It would be so nice to have a plugin for this, but no one seems to care about it :'(

removing in progress tag

I found a small script on Wiktionary that can be saved as a bookmark. If there is text selected - and you click the bookmark - it immediately searches for the word(s). If no text selected yet, it opens a small pop-up window to type in.
javascript:(function()
 {function se(d) {
    return d.selection ?%20d.selection.createRange().text%20:%20d.getSelection()}%20s%20=%20se(document);%20for%20(i=0;%20i%3Cframes.length%20&&%20!s;%20i++)%20s%20=%20se(frames[i].document);%20if%20(!s%20||%20s==%27%27)%20s%20=%20prompt(%27Enter%20search%20terms%20for%20Wiktionary%27,%27%27);%20open(%27https://en.wiktionary.org%27%20+%20(s%20?%20%27/w/index.php?title=Special:Search&search=%27%20+%20encodeURIComponent(s)%20:%20%27%27)).focus();
 })();

Maybe you can take a look at this plugin. Note that this plugin requires networking.

Maybe you can take a look at this plugin. Note that this plugin requires networking.

Awesome!

Maybe you can take a look at this plugin. Note that this plugin requires networking.

Why hasn't a plugin that is equal to or better than this plugin been implemented even though it has been more than 3 years since this request was posted?
I would like an explanation from Powertoys owners why they are unable to contact @N0I0C0K and incorporate or implement the feature in Powertoys.
Don't you think so too?

Maybe you can take a look at this plugin. Note that this plugin requires networking.

Why hasn't a plugin that is equal to or better than this plugin been implemented even though it has been more than 3 years since this request was posted? I would like an explanation from Powertoys owners why they are unable to contact @N0I0C0K and incorporate or implement the feature in Powertoys. Don't you think so too?

I'm so glad that you likes this plugin, but as the author of the plugin, I believe there are several issues that need to be addressed before integrating the plugin into the official plugins:

The plugin currently only implements translation interfaces provided by enterprises from specific countries, which cannot guarantee accessibility for people everywhere in the world.
The plugin does not implement i18n; it currently only provides an English version (which is also the most universal).
The implementation of the plugin still needs optimization.

At the same time, I also believe that a plugin that requires an internet connection to provide services is not very universal. I also attempted to train a small local translation model, but the results were not very accurate (haha 🤷♂).


unknown x86 target feature

Hi, I tried to install pgvecto.rs on my psqgl-16 server from source, following the instructions: https://docs.pgvecto.rs/developers/development.html and then issuing:
sed -e "s/<EMAIL_ADDRESS>./vectors.control  # 0.0.0 here is the version number that you need
sudo cp -a ./sql/upgrade/. $(pg_config --sharedir)/extension
cargo pgrx install --sudo --release

Unfortunately I received:
       Using PgConfig("pg16") and `pg_config` from /usr/bin/pg_config
    Building extension with features pg16
     Running command "/usr/bin/cargo" "build" "--release" "--features" "pg16" "--no-default-features" "--message-format=json-render-diagnostics"
   Compiling detect v0.0.0 (/root/pgvecto.rs/crates/detect)
   Compiling toml v0.8.12
   Compiling clang-sys v1.7.0
   Compiling toml_datetime v0.6.5
   Compiling rayon v1.10.0
   Compiling serde_spanned v0.6.5
   Compiling eyre v0.6.12
   Compiling socket2 v0.5.6
error: unknown x86 target feature: avx512fp16
  --> crates/detect/src/lib.rs:49:1
   |
49 | detect_macros::main!();
   | ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `std::arch::is_x86_feature_detected` which comes from the expansion of the macro `detect_macros::main` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `detect` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...```

How to fix that?

pgvecto.rs should be compiled with expected version of rust compiler.

Install Rust. Do not install rustc using a package manager.
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

Have you installed rustup and compiled pgvecto.rs with rustc provided by rustup?

Apparently not, thank you.


add packer template and updated workflow

Fixes #51
This PR adds/improves

a Packer template that enables building images with installed extensions using a parametric approach. By default, all supported extensions are installed. To install specific extensions, you can provide the extensions variable when running the command:

packer build -var extensions='pg_repack,hll' -only warpsql.docker.alpine war

GitHub workflow to test each extension individually as well as all of them within an image. By default, the test script test/smoke_test/smoke_test.sh will execute all the scripts in the extensions_test directory.  You can specify which tests to run by providing a comma-separated list of extensions as an argument to the script. Here's an example of how to run specific tests:

./test/smoke_test/smoke_test.sh "hll,pg_reapck"

updated README.md file with instructions on how to use the Packer template.

cc: @singhalkarun


fix(ts): only generate tsconfig.json if missing

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Fixes #5338
Closes #5356
Makes Nuxt not overriding tsconfig.json anymore, and only generates it with defaults if its missing.
Furthermore, TypeScript support is now only initialized if @nuxt/typescript is installed, so no more issues for projects which have a tsconfig.json in their root folder but doesn't want Nuxt to enable its TypeScript support.
The initializing state of TypeScript Support (includes tsconfig.json autogeneration step) is also more clear now :

Migration Guide
If you're using 2.4.x :

Remove nuxt-ts dependency
Install nuxt and @nuxt/typescript dependencies
Remove your tsconfig.json, let Nuxt generate it with defaults at first run, then you can edit it to fit your needs.

If you're using 2.5.x and have a working project, no changes are needed.
Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly. (PR: https://github.com/nuxt/docs/pull/1269)
[x] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

@kevinmarrec I think we would also need a proper migration guide alongside with this PR changes

@pi0 yes sure, will only make the PR out of DRAFT when everything will be good

Btw, I don't know what's that test unit error output, looks weird, gonna try to figure out why it's happening and why it's failing

Well I tried to find what's wrong with tests, but as my changes are not relevant to the error and that it works on dev branch, I'm really confused...

Codecov Report

Merging #5367 into dev will increase coverage by 0.23%.
The diff coverage is 77.77%.

@@           Coverage Diff            @@
##            dev    #5367      +/-   ##
========================================
+ Coverage    96%   96.24%   +0.23%
========================================
  Files        74       74
  Lines      2529     2528       -1
  Branches    640      641       +1
========================================
+ Hits       2428     2433       +5
+ Misses       85       79       -6
  Partials     16       16

Impacted Files
Coverage Δ

packages/typescript/src/index.js
100% <100%> (ø)
:arrow_up:

packages/cli/src/utils/index.js
93.65% <50%> (-1.44%)
:arrow_down:

packages/cli/src/utils/typescript.js
66.66% <75%> (+35.89%)
:arrow_up:

packages/vue-renderer/src/renderer.js
96.01% <0%> (+0.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c009a20...1e28dd0. Read the comment docs.

@pi0 IMPORTANT : I'd like to have a "Co-authored-by" #5356 owner in the merge commit message when it gets merged in dev

@kevinmarrec 9a3fc8a44e3cf3a8f551fa93ba60eb88a8c39663

Thanks @pi0