Provisioner falls over after etcd timeout

I start a helm chart on a kind installation using rancher. The chart provisions PVs for about 6 containers. This is running on pretty weak hardware, a circleci machine runner.
The chart doesn't come up. It's waiting for PV claims to be fulfilled (they're stuck in pending). The pods in question when start staying that the pod to create the volume already exists[1]. Which it does. And the path for the volume has been created. But pod creation hangs forever.
Turns out a request to etcd timed out [2] and this took down the provisioner. When it came back, it didn't recover the operations that were in progress.
[1] Pod describe:
 Normal     Provisioning          52s (x5 over 4m39s)    rancher.io/local-path_local-path-provisioner-69fc9568b9-vmmhj_2f07fa18-8215-11e9-87ef-420caaa87133  External provisioner is provisioning volume for claim "test-6505f1a5/datadir-test-6505f1a5-zookeeper-0"
  Warning    ProvisioningFailed    52s (x5 over 4m38s)    rancher.io/local-path_local-path-provisioner-69fc9568b9-vmmhj_2f07fa18-8215-11e9-87ef-420caaa87133  failed to provision volume with StorageClass "local-path": failed to create volume pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002: pods "create-pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002" already exists

[2]
circleci@default-306a0f9a-e068-4f47-bf37-c13d6eb031f2:~$ kubectl -n local-path-storage logs -p local-path-provisioner-69fc9568b9-vmmhj
time="2019-05-29T13:21:13Z" level=debug msg="Applied config: {\"nodePathMap\":[{\"node\":\"DEFAULT_PATH_FOR_NON_LISTED_NODES\",\"paths\":[\"/opt/local-path-provisioner\"]}]}"
time="2019-05-29T13:21:13Z" level=debug msg="Provisioner started"
time="2019-05-29T13:23:21Z" level=debug msg="config doesn't contain node kind-worker, use DEFAULT_PATH_FOR_NON_LISTED_NODES instead"
time="2019-05-29T13:23:21Z" level=info msg="Creating volume pvc-ee13ad7e-8214-11e9-9d5f-0242ac110002 at kind-worker:/opt/local-path-provisioner/pvc-ee13ad7e-8214-11e9-9d5f-0242ac110002"
time="2019-05-29T13:23:21Z" level=debug msg="config doesn't contain node kind-worker2, use DEFAULT_PATH_FOR_NON_LISTED_NODES instead"
time="2019-05-29T13:23:21Z" level=info msg="Creating volume pvc-ee186e49-8214-11e9-9d5f-0242ac110002 at kind-worker2:/opt/local-path-provisioner/pvc-ee186e49-8214-11e9-9d5f-0242ac110002"
time="2019-05-29T13:23:22Z" level=debug msg="config doesn't contain node kind-worker, use DEFAULT_PATH_FOR_NON_LISTED_NODES instead"
time="2019-05-29T13:23:22Z" level=info msg="Creating volume pvc-ee331af8-8214-11e9-9d5f-0242ac110002 at kind-worker:/opt/local-path-provisioner/pvc-ee331af8-8214-11e9-9d5f-0242ac110002"
time="2019-05-29T13:23:23Z" level=debug msg="config doesn't contain node kind-worker2, use DEFAULT_PATH_FOR_NON_LISTED_NODES instead"
time="2019-05-29T13:23:23Z" level=info msg="Creating volume pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002 at kind-worker2:/opt/local-path-provisioner/pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002"
E0529 13:23:46.181575       1 leaderelection.go:286] Failed to update lock: etcdserver: request timed out
E0529 13:23:46.809377       1 event.go:259] Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'LeaderElection' 'local-path-provisioner-69fc9568b9-vmmhj_a1902f4d-8214-11e9-a599-420caaa87133 stopped leading'
F0529 13:23:50.398931       1 controller.go:647] leaderelection lost
goroutine 1 [running]:
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.stacks(0xc0003ea500, 0xc000698000, 0x45, 0xb4)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:766 +0xb1
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.(*loggingT).output(0x2009ca0, 0xc000000003, 0xc000148930, 0x1f910d1, 0xd, 0x287, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:717 +0x303
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.(*loggingT).printf(0x2009ca0, 0x3, 0x12e0f79, 0x13, 0x0, 0x0, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:655 +0x14e
github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog.Fatalf(...)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/golang/glog/glog.go:1145
github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller.(*ProvisionController).Run.func2()
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:647 +0x5c
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run.func1(0xc000362540)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:148 +0x40
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run(0xc000362540, 0x14c7de0, 0xc000079c00)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:157 +0x10f
github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection.RunOrDie(0x14c7e20, 0xc000044040, 0x14d4160, 0xc000317200, 0x37e11d600, 0x2540be400, 0x77359400, 0xc000370900, 0x1358910, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go:166 +0x87
github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller.(*ProvisionController).Run(0xc0002fc4e0, 0xc0000bc7e0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:639 +0x36f
main.startDaemon(0xc000314640, 0x5, 0x4)
	/go/src/github.com/rancher/local-path-provisioner/main.go:134 +0x793
main.StartCmd.func1(0xc000314640)
	/go/src/github.com/rancher/local-path-provisioner/main.go:80 +0x2f
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.HandleAction(0x10fb200, 0x1359218, 0xc000314640, 0xc000300d00, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/app.go:487 +0x7c
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.Command.Run(0x12d6eca, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/command.go:193 +0x925
github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli.(*App).Run(0xc0002fc340, 0xc00003a050, 0x5, 0x5, 0x0, 0x0)
	/go/src/github.com/rancher/local-path-provisioner/vendor/github.com/urfave/cli/app.go:250 +0x785
main.main()
	/go/src/github.com/rancher/local-path-provisioner/main.go:166 +0x2ba

@ivankelly
ETCD down is an unexpected event we didn't design for. We don't expect it to happen.
So far what we can do is to deal with pods "create-pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002" already exists error, which we can remove the pod and recreate it if it already exists. But we can't guarantee that if ETCD is down, there won't be any other issues.
Can you confirm if you manually delete the pod create-pvc-ee4d2be8-8214-11e9-9d5f-0242ac110002 the provisioner would work again?

@yasker Yes, if I delete the pods after the restart, everything seems to work again. Crashing on etcd down is perfectly fine. The bug is not returning to a working state once etcd is available again. Deleting the pod should give this.

I have same problem, there is a PR to fix it. Please check.
https://github.com/rancher/local-path-provisioner/pull/40

The fix will be included in the next release, after I addressed https://github.com/rancher/local-path-provisioner/pull/24 .


fix typo on lemma type

Hi I saw a very minor typo in Sec 12.1, I wondered if it might be worth fixing as its so tiny.

Oh thank you! Sorry, I have been doing a lot of travelling this term and am only now getting up to date with github notifications.


ES6-ification

Please merge #20 and #18 before this PR
Rewriting a couple of things to take advantage of new es6 language features.

@hhff Squashed this as well. This should be one additional commit after #20 and #18 are merged

thanks so much @truenorth !  gonna release a new version now.


No data received with SecResponseBodyAccess On - Apache 2.2.31

Custom compiled Apache 2.2.31 using included latest apr and apr-util. All is fine. Compiled mod_security 2.9.1 with latest apr and apr-util, same as Apache.
Once the option "SecResponseBodyAccess On" is enabled with these actions:
SecResponseBodyAccess On
SecResponseBodyMimeType text/html text/plain text/xml
SecResponseBodyLimit 2621440
SecResponseBodyLimitAction ProcessPartial
and Apache is restarted, hitting any page results in:
wget http://<IP_ADDRESS>/
--2016-09-29 19:12:30--  http://<IP_ADDRESS>/
Connecting to <IP_ADDRESS>:80... connected.
HTTP request sent, awaiting response... No data received.
Retrying.
and no page data is returned. Apache access log shows the hit and a 200 response.
Compiled Apache 2.4.23 with same parameters, mod_security with this setting works fine. If I comment out "SecResponseBodyLimitAction ProcessPartial" it seems to work fine as well.
Is this a known issue? Anything else you want me to try / change?

are you using rewrite rules to index.php or something?

The URL I gave was just an example. It happens for static html pages, 404 pages, etc... All URLs return the "No data received".  Apache config using:
SecRuleEngine On
SecRequestBodyAccess On
SecResponseBodyAccess On
SecResponseBodyLimitAction ProcessPartial

Hi @robfico,
Can you paste here the very first lines of your error_log, just after restart your web server?

Sure. centOS 6, 64bit OS. From error_log:
[Fri Sep 30 13:40:20 2016] [notice] FastCGI: process manager initialized (pid 10174)
[Fri Sep 30 13:40:20 2016] [notice] Apache/2.2.31 (Unix) mod_ssl/2.2.31 OpenSSL/1.0.1e-fips DAV/2 mod_fastcgi/mod_fastcgi-SNAP-0811090952 configured -- resuming normal operations
Apache compiled with:
"./configure"
"--prefix=/usr/local/apache"
"--with-mpm=worker"
"--with-included-apr"
"--with-z"
"--with-ssl"
"--enable-ssl"
"--enable-deflate"
"--enable-unique-id"
"--enable-mods-shared=most"
"--disable-info"
"$@"

there should be a message from ModSecurity within your error log. Something limilar to:
[...] ModSecurity for Apache/2.7.7 (http://www.modsecurity.org/) configured.
[...] ModSecurity: APR compiled version="1.4.8"; loaded version="1.4.8"
[...] ModSecurity: PCRE compiled version="8.31 "; loaded version="8.31 2012-07-06"
[...] ModSecurity: LUA compiled version="Lua 5.1"
[...] ModSecurity: LIBXML compiled version="2.9.1"

I moved around the loading of modules, and it now outputs the full mod_security lines...Seems the APR libraries were mismtached due to Apache not picking up apr as I loaded them. Corrected APR mis-match, all better now. Sorry for the false alarm... closing.


Preparing to use futures in storage.

Wraps setting/getting of object _properties in custom methods. This will allow centralized detection of a future in a response and will also allow replacing with the value on access if it is ready.
Towards #775

@tseaver LMK what you think of this. The next step (I have yet to write it) is to make Batch._do_request return a future object. These objects will be owned and kept in order by the Batch and eventually populated. (This may be an issue because JSONConnection.api_request will try to parse the response if we use expect_json=True. We simultaneously want to parse the non-batched JSON responses and just ignore the futures)

Coverage remained the same at 100.0% when pulling 35ac718ad91cb22406b95586d1a9bee7cf163e92 on dhermes:prepare-for-storage-futures into 41b5b722305e8aaba09442bd70c16c595c55a63b on GoogleCloudPlatform:master.

Changes Unknown when pulling b0af13c38496d361c9c7eac1cb1b00e19adfbfa3 on dhermes:prepare-for-storage-futures into ** on GoogleCloudPlatform:master**.

The whole self._properties -> self._get_properties() dance seems to me to call for having the "future" bits hold a _properties which is a special object, whose __getitem__/__setitem__/get would raise the appropriate error.  Converting the future would then be done by replacing the _properties attribute with a real dict.

I figured you'd have good ideas on this, so I pushed it out without thinking too hard about it.
I don't particularly like _(get|set)_properties
I think your suggestion is a bit too high-powered for what is happening. I prefer simplicity if possible.
Writing this and #812 I very much feel like this stuff is too intertwined (i.e. modules / classes know / assume too much about each other)

Coverage remained the same at 100.0% when pulling fafb25c19e39aca26f87e78af82ae377da6e2e7d on dhermes:prepare-for-storage-futures into f08e71b5fdcf0bbdaf1257bab5e64a3c8621f414 on GoogleCloudPlatform:master.

I imagined the following:
class UnrealizedFuture(ValueError):
    pass

class _UnrealizedFutureDict(object):

    def get(self, key, default=None):
        raise UnrealizedFuture()

    def __getitem__(self, key):
        raise UnrealizedFuture()

    def __setitem__(self, key, value):
        raise UnrealizedFuture()

unrealized = _UnrealizedFutureDict()

Where every "future" Blob / Bucket would have the unrealized singleton as its _properties.  That doesn't seem "high-powered" to me, compared to the ugliness of the _get_properties() bit scattered everywhere.

That's much simpler than I imagined! Let me give it a spin.

Coverage remained the same at 100.0% when pulling 50da3a3cd288c9ce98568e8204b6bbcf4a994035 on dhermes:prepare-for-storage-futures into 028a15d4dddba854790f5c547d811d5796ea5a69 on GoogleCloudPlatform:master.

@tseaver I got rid of _get_properties in light of your suggestion but kept around _set_properties since it also resets _changes for us. Kept the old version of this PR around in https://github.com/dhermes/gcloud-python/tree/prepare-for-storage-futures-OLD for now, but will delete soon-ish.
I will give this a spin in #812 with your suggestion. It totally assuages my concerns about modules knowing too much about each other.

LGTM


Erroneous mixin_inference_no_matching_class error in Flutter

I encountered an mixin_inference_no_matching_class error in Flutter:

ERROR: flutter/lib/src/rendering/proxy_box.dart:37
Type parameters could not be inferred for the mixin 'RenderProxyBoxMixin' because the base class does not implement the mixin's supertype constraint 'RenderObjectWithChildMixin' #mixin_inference_no_matching_class

Here are those two classes, RenderProxyBox and RenderProxyBoxMixin:
class RenderProxyBox extends RenderBox
    with RenderObjectWithChildMixin<RenderBox>, RenderProxyBoxMixin<RenderBox> { ... }

@optionalTypeArgs
abstract class RenderProxyBoxMixin<T extends RenderBox> extends RenderBox
    with RenderObjectWithChildMixin<T> { ... }

So if a RenderProxyBoxMixin's T is RenderBox, then RenderProxyBox must mixin RenderObjectWithChildMixin<RenderBox>, which is exactly what it does... bug?

So is this an analyzer bug?

I think @stereotype441 and I decided this is not a bug. Is it OK to close this, Paul?

I'm a little confused.  The code in the first comment seems to match the code in siva's workaround.  Was the error from the code before or after?  The code after doesn't involve any inference does it?

It's not clear to me why siva's fix was needed, but maybe I'm missing something - reinterpreting the class syntax into sane mixin syntax gives me a headache.

Sorry, yeah. I hit this bug when synced to a flutter commit before the code I found on GitHub at master (i.e. before Siva's fix). So what I copy/pasted was not the code that triggered the bug.
I'm not clear either, but I think Paul also expressed unhappiness that Siva's fix was needed. I think he called it a "work around." So I'll let Paul comment on whether this is a bug or not. I think the code when I hit the bug was:
class RenderProxyBox extends RenderBox
    with RenderObjectWithChildMixin<RenderBox>, RenderProxyBoxMixin { ... }

@optionalTypeArgs
abstract class RenderProxyBoxMixin<T extends RenderBox> extends RenderBox
    with RenderObjectWithChildMixin<T> { ... }

which Siva fixed to:
class RenderProxyBox extends RenderBox
    with RenderObjectWithChildMixin<RenderBox>, RenderProxyBoxMixin<RenderBox> { ... }

@optionalTypeArgs
abstract class RenderProxyBoxMixin<T extends RenderBox> extends RenderBox
    with RenderObjectWithChildMixin<T> { ... }

Ok, so maybe this is just a bug with inferring from multiple superclass constraints?

Yes, I believe this is a bug with inferring from multiple superclass constraints.  It's complicated because there are many versions of the analyzer around with different degrees of fixedness, and there are two code paths through the analyzer with different degrees of fixedness.  And then of course there's Siva's workaround.
Let's start with the two code paths: they are the (new) analysis driver and the (old) task/context model.  AFAIK, everything uses the new analysis driver except DDC and a few use cases of flutter analyze (see https://github.com/dart-lang/sdk/issues/32421#issuecomment-370597792).  So if you're running the analyzer on the command line, via the analysis server, or through the Google internal build process, you're getting the new analysis driver.  But if you're running flutter analyze you might be getting the old task/context model.
Now let's talk about how that interplays with analyzer versions.  The new analysis driver handles this case properly on bleeding edge master (I just tested it).  I believe it has worked properly since 11cbdbe26e2ebc0367f3422a7ad71bb9ab03dd96, though I haven't tested that directly.  11cbdbe26e2ebc0367f3422a7ad71bb9ab03dd96 was released in 2.0.0-dev.33.0.  So if you're running an older version than that, you're expected to see problems.  Note that the internal codebase is running earlier code than that, so if you're using the internal version of the analyzer you're expected to see problems.
The old task/context model does not handle this case properly because it doesn't do mixin inference at all.  In b5b8080b2cfb1e4943a19787ee96548a4a604f7b I disabled some of the old task/context model's error checking to try to prevent the most obvious errors this causes.  In https://dart-review.googlesource.com/c/sdk/+/45524 I tried to disable even more of the error checking.  If you are seeing this error and you are using the old task/context model, https://dart-review.googlesource.com/c/sdk/+/45524 ought to make it go away.  But it's possible that there will be other follow-on errors that https://dart-review.googlesource.com/c/sdk/+/45524 isn't able to suppress.
Finally, Siva's workaround is expected to make the error go away in all circumstances, because it supplies the mixin type parameter directly, avoiding the need for inference.
I hope that helps somewhat.  Sam, it wasn't clear to me whether you saw the problem while trying to roll the SDK internally, while trying to roll analyzer code to Flutter, or under some other circumstance.  Can you clarify?  I'm happy to look in more detail if you send me repro instructions, but this is my last day in Aarhus and I'm leaving at 3pm (6am Pacific time), so unless you happen to still be awake it's unlikely that I'll be able to help today.  Next week I'm in London, so if necessary I can dig into this Monday before the workday starts for anyone in the US.

So if you're running the analyzer on the command line, via the analysis server, or through the Google internal build process

Yes, internal build process

11cbdbe was released in 2.0.0-dev.33.0. So if you're running an older version than that, you're expected to see problems.

Yes, this was testing -dev.32.0.
So I think in my case, it sounds like this has been fixed (in -dev.33.0). I did not encounter the bug in the old task/context model, so I don't think it needs to remain open just for that case. Probably close then as fixed in -dev.33.0?

Ok, that clarifies somewhat.  I'm not entirely sure why Sam was seeing this, but Siva's fix would have been because flutter analyze is still using the task model.
https://github.com/dart-lang/sdk/issues/32478
I'll go ahead and close this now unless there's anything else to track.


MAIN-B-20941-ssw-duplicate-state-zip

B-20941
INT PR
Summary
MAIN
This PR fixes a small issue in the SSW PDF for AOA/Payment download where Authorized Origin field was displaying duplicate state and zip.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Login as customer to create and submit move with PPM. Make sure to click YES for "Would you like to request an advance on your incentive?"
Login as a SC and fill in all required fields and click submit move details. Page will refresh containing AOA download link. Download and verify Authorized Origin field does not contain duplicate state/zip.
Login as customer and click upload PPM Documents and complete/submit process of providing documents for review.
Login as SC and review documents. Approve/Reject and confirm/submit. Page will refresh containing Payment Download link. Download and verify Authorized Origin field does not contain duplicate state/zip.
Login as customer and click Payment Download  and verify Authorized Origin field does not contain duplicate state/zip.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Fails

:no_entry_sign:

Danger failed to run dangerfile.ts.

Error SyntaxError
Unexpected token u in JSON at position 0
SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at checkYarnAudit (dangerfile.ts:58:24)
    at Object.<anonymous> (dangerfile.ts:94:5)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at requireFromString (/home/circleci/transcom/mymove/node_modules/require-from-string/index.js:28:4)
    at /home/circleci/transcom/mymove/node_modules/danger/distribution/runner/runners/inline.js:161:68
    at step (/home/circleci/transcom/mymove/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/circleci/transcom/mymove/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/circleci/transcom/mymove/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)

Dangerfile
53|   // Require new src/components files to include changes to storybook
54|   const hasComponentChanges = danger.git.created_files.some((path) => path.includes('src/components'));
55|   const hasStorybookChanges = allFiles.some(
56|     (path) => path.includes('src/stories') || !!path.match(/src\/.*\.stories.jsx?/),
57|   );
--------------------------^
58|
59|   if (hasComponentChanges && !hasStorybookChanges) {
60|     warn('This PR does not include changes to storybook, even though it affects component code.');
61|   }

  Generated by :no_entry_sign: dangerJS against b4c94e6e19cffa5002ab75b190b1218da7cad27d


⚠ Processors has degraded performance

In 668085b, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: Processors performance has improved in fdeeb03.


Fix npm audit vulnerabilities

result of npm audit fix and manually removing stratos-merge-dirs

We should park this until we upgrade to Angular 8. The issue might come out in the wash.

Angular upgrade #3920

@KlapTrap This was raised as a concern by the community. Is there any reason why this shouldn't be merged other than waiting for Angular 8?

@richard-cox @KlapTrap I think we should get this in - but I don't understand the changes to the package lock file.
Many dependencies have changed from being explicitly pinned, e.g. "1.9.3" to "^1.9.3" - it would be good to understand why, so we don't have this flip-flopping with PRs.

I agree that we should fix this, I was just going to wait for the angular 8 upgrade. ng updatge will get all of the relevant dependancies to the correct & compatible versions.
Having said that, I've done some of the angular 8 migration here; https://github.com/cloudfoundry-incubator/stratos/pull/3950 and It's going to take a while to manually migrate some of the code. So, with that in mind, I don't mind this being merged once everyone is happy.


Update app config template

Adds config ini parameters from the latest sample config.
This only adds parameters with their default values or sets them to keep their old behaviour, so they should not change the running deployment. I've tested this with my own server.

Brilliant, I have been neglecting keeping this up to date lately, I'll pay more attention, thank you so much for taking the time to update that ! I'll merge as soon as you're rebased on master :)

@thomas-maurice Done :slightly_smiling_face: Thanks for the initial work on the role! I've been using it for some time with tweaks so it only seems fair to implement them properly and upstream them.

Thank you for taking the time to upstream it :)


Crash Xiomi in release mode.

Hi, in my Xamarin android app I use Xamarin.Shell.Badge in Tab control; it work fine when I test app on my Xiomi physical device (debug mode); when I test my app in release mode or thought Google Play Store beta test, the app crash. The error is:
LOG: MonoDroid] UNHANDLED EXCEPTION:
[MonoDroid] Android.Runtime.JavaProxyThrowable: Exception of type 'Android.Runtime.JavaProxyThrowable' was thrown.
[MonoDroid] --- End of managed Android.Runtime.JavaProxyThrowable stack trace ---
[MonoDroid] android.runtime.JavaProxyThrowable: System.MissingMethodException: Default constructor not found for type Xam.Shell.Badge.Droid.Renderers.BadgeShellRenderer
Thank you.

Hello, @nellogaudino, when you set your Linker behaviour to None, do you have the same problem appearing? Can you re-create the release and try with this setting?

Hello, when I set linker behavior to "None" or to "Link SDK assemblies only" all work fine. My previous setting was "Link all assemblies"
Thank you!

Yes, please, use "Link SDK assemblies only" or configure your Linker settings file deeply. It is really rare to use "Link all assemblies" option, cause it may lead to unpredictable errors and you don't save much APK size in comparison with "Link SDK assemblies only" (recommended option).


SVG-based ImageView can't be displayed on Samsung GT-N7100

I run the sample code and find out that all svg-based ImageView can't be displayed on Samsung GT-N7100 and GT-I9100G. I don't have many handsets to test but those are the only handsets with the issue.
I am integrating this library into a commercial project and I am trying to figure out the cause. It's important for me to resolve the issue.

Got the same issue on GT-I8190 stock 4.1.2.
Any solution to detect if rendering fail or nothing display ?

@kingstone59 In SvgShader.calculate, use hapePath.addPath(path, pathMatrix); instead of shapePath.addPath(path, pathMatrix);. That'll help!

@dannysuen hapePath instead of shapePath ?
Can't find your line in SvgShader.java
Do you import library file directly in your project ?

@kingstone59 Yes, I fixed the bug and put it as a library locally instead of remote dependency. Locate the calculate method of class SvgShader, and call shapePath.addPath(borderPath, pathMatrix); instead of shapePath.transform(pathMatrix, borderPath);. It resolves the issue.

@dannysuen Ok, so I have import lib localy but I got this :
No resource identifier found for attribute 'siBorderWidth' in package 'com.myapp'
cause by "app:siBorderWidth="2dp" in my xml
witch namespace I need to use for locale lib ?

shapePath in SvgShader.java is type of PathInfo so to have add addPath to  PathInfo
        path.addPath(dst, matrix);
    }```
But know nothing render (also with device that work with ```transform```)

@Override
public void calculate(int bitmapWidth, int bitmapHeight, float width, float height, float scale, float translateX, float translateY) {
        path.reset();
        borderPath.reset();

        pathDimensions[0] = shapePath.getWidth();
        pathDimensions[1] = shapePath.getHeight();

        pathMatrix.reset();

        scale = Math.min(width / pathDimensions[0], height / pathDimensions[1]);
        translateX = Math.round((width - pathDimensions[0] * scale) * 0.5f);
        translateY = Math.round((height - pathDimensions[1] * scale) * 0.5f);
        pathMatrix.setScale(scale, scale);
        pathMatrix.postTranslate(translateX, translateY);
//        shapePath.transform(pathMatrix, path);
        shapePath.addPath(path, pathMatrix);
        path.offset(borderWidth, borderWidth);

        if (borderWidth > 0) {
            pathMatrix.reset();
            float newWidth;
            float newHeight;
            float d;
            if (borderType == BORDER_TYPE_DEFAULT) {
                newWidth = viewWidth - borderWidth;
                newHeight = viewHeight - borderWidth;
                d = borderWidth / 2f;
            } else {
                newWidth = viewWidth;
                newHeight = viewHeight;
                d = 0;
            }
            scale = Math.min(newWidth / pathDimensions[0], newHeight / pathDimensions[1]);
            translateX = Math.round((newWidth - pathDimensions[0] * scale) * 0.5f + d);
            translateY = Math.round((newHeight - pathDimensions[1] * scale) * 0.5f + d);
            pathMatrix.setScale(scale, scale);
            pathMatrix.postTranslate(translateX, translateY);
//            shapePath.transform(pathMatrix, borderPath);
            shapePath.addPath(borderPath, pathMatrix);
//            borderPath.op(path, Path.Op.DIFFERENCE);
        }

        pathMatrix.reset();
        matrix.invert(pathMatrix);
        path.transform(pathMatrix);
}


SNN simulation length parameter seems unused during calibration

Dear @yhhhli
This is an awesome repository and thank you so much for publishing it.
My question/ issue is regarding the parameter --T for the SNN calibration:
In the code of the CIFAR SNN calibration it seems that the SNN simulation length is hardcoded to sim_length = 32 (line 71) and the args.T parameter is unused.
Can you comment on this? Because in your table of results you mention T=16. How do you achieve this to be used during testing (not necessarily calibration itself)?

Hi @annahambi ,
Thank you for your interest. Sorry for the hardcoding of time steps, we will correct this next time we update the code repo.


Update broken readme links

Caught some broken links in the readme and tried to correct them to what seemed like suitable replacement pages

Thanks!


making log scales for both X and Y in the Scatter plot

This makes log scale controls for both X and Y axes in the Scatter plot and its corresponding Viz. VEuPathDB/web-eda#1153
Since Scatter plot (and Viz) allow date variable at X and Y axes, it is configured to disable the log scale control when the selected variable is date type.
Here are example screenshots with explanation in the title: the same study and variables with the screenshot in the ticket were used for a comparison purpose.

log scale is on for X-axis

controlling legend to show/hide data: this may be useful for scattered data that show large range of confidence intervals in Y-axis.

A demo to show that log scale control at the Y-axis is disabled because its variable type is date

@dmfalke Actually, that's quite a confusing part when using plotly.js for a log scale. Plotly treats log scale case as log data, even if the axis tick labels are shown as actual numbers. Strange enough but perhaps it is because such a treatment may be easier to figure out the numbers visually, when looking at the plot. I am always confused about that concept 😄


Allow sorting by multiple columns (by holding shift)

Related to issue #98
Let me know if there are any requested changes (any functions that you want split, if shiftKey (as in, e.shiftKey) should be a constant/configurable, etc.)

just reviewed your code, all looks fine. thanks for this. i didn't realise multi-column sorting would be that easy!!

No problem. The code base is wonderfully clean, so it was easy to figure out and add. Thanks for the excellent grid library!

wonderfully clean!!! indeed!!! something that's pretty rare these days... a forgotten art in today's world... :)


[Backport] [1.3] OpenJDK Update (July 2022 Patch releases)

Description
Backporting https://github.com/opensearch-project/OpenSearch/pull/3323 and https://github.com/opensearch-project/OpenSearch/pull/4091 to 1.3
Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/4011
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross may I ask you please to take a look? (no brainer) thank you!


Env selection by URL path

For a more clear structure and an easier way to refresh the visualisations in an environment I suggest to make an environment selection based on the URL possible. Selecting an environment called my_favorite_env should change to URL to for example http://localhost:8098/my_favorite_env and entering or refreshing this URL should directly open this environment.
I have a use case where I create and destroy many windows and sometimes those keep hanging around until I refresh the page. But then I always have to reselect the environment.

This feature used to be supported but is currently broken. Fixing this is on our to-do list.

The infrastructure for this currently does exist - the domain was http://localhost:8098/envs/my_favorite_env but something broke along the way (unsure when). The existing 'support' is somewhere in the EnvHandler in the server but I haven't had a chance to find the bug yet:
https://github.com/facebookresearch/visdom/blob/2a390d66326a0d62b803d4b883c745c7c52e52f9/py/server.py#L690


Pointer deref inside mesh shader results in compiler error on spirv

I have the following mesh shader:
struct MeshOutput {
    float4 position: SV_Position;
    float3 color: COLOR0;
};

[[vk::push_constant]] struct PushConstants {
    float4x4 view_projection_matrix;
    uint *my_ptr;
} push_constants;

[shader("mesh")]
[outputtopology("triangle")]
[numthreads(1, 1, 1)]
void mesh_main(out indices uint3 triangles[1], out vertices MeshOutput vertices[3]) {
    SetMeshOutputCounts(*push_constants.my_ptr, 1);
    triangles[0] = uint3(0, 1, 2);

    vertices[0].position = mul(push_constants.view_projection_matrix, float4(-0.5, 0.5, 0.0, 1.0));
    vertices[0].color = float3(1.0, 0.0, 0.0);

    vertices[1].position = mul(push_constants.view_projection_matrix, float4(0.5, 0.5, 0.0, 1.0));
    vertices[1].color = float3(0.0, 1.0, 0.0);

    vertices[2].position = mul(push_constants.view_projection_matrix, float4(0.0, -0.5, 0.0, 1.0));
    vertices[2].color = float3(0.0, 0.0, 1.0);
}

when I compile the code with slangc.exe .\test.slang -profile glsl_450 -target spirv -o hello_world.spv -entry mesh_main | spirv-cross.exe -V .\hello_world.spirv, I get the following error:
(0): internal error 99999: unexpected condition encountered in Slang compiler: unhandled type
From what I read I thought buffer pointers are supported on spirv, so I wonder what I'm doing wrong here. When I just have the pointer inside push_constants and I do not deref it, its working fine.
The version I'm using is slang-2024.1.7-win64

You need to add -emit-spirv-directly.
The glsl backend does not support pointers, only spirv direct backend allows it, which is enabled with this option.

thanks, that worked for me. Maybe the compiler error message could me more clear like `Pointers are only allowed when using the following backends: spirv ....

Thanks for confirming! We are in the process of deprecating the glsl path and move to direct to spirv backend by default so it will no longer be required to pass -emit-spirv-directly in the future. Closing this issue now.


Only compile project features logic in editor builds

I previously had these changes in #63132, but these changes stand on their own, so I'm opening a separate PR.
The logic for project features is only needed in the editor and project manager, it's not needed for export templates.

Thanks!


Documentation Improvements

Despite the branch name, this fixes the scroll issue.

Thanks @levithomason!
By the way, I totally forgot about docs/redesign. It actually has a handful of fixes that I forgot about, such as improving the jsdoc parser to the point where it should now be runnable before each doc server run.
Any future work we do to the docs should probably work off of that branch, but this looks good for now.

Merged, thanks!


fix: Remove start-zeppelin.sh

Removed start-zeppelin related docs, files

@mfelgamal Could u check this PR?

@1ambda Thank you very much.


Refactor op testing | feat(torchlib)

Cleanup is needed because of test file is split into three.

Import module instead of function
Expose functions

@justinchuby How to get around with:
"message": "Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization."

When uses ghstack on this repo

Thanks a lot!

@justinchuby How to get around with:
"message": "Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization."

When uses ghstack on this repo

I was able to use it when pushing directly to the microsoft repo (not fork).


style(markdown): lighten copy button hover background color

What this PR does:
style(markdown): lighten copy button hover background color

before
after

Which issue(s) this PR fixes:

Fixes #
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:
Checklist:

[ ] I have added unit/e2e tests that prove your fix is effective or that this feature works.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:

MR Summary:
The summary is added by @codegpt.
This Merge Request updates the style of the copy button in the MarkdownViewer component by lightening its hover background color. The change aims to improve the user interface by making the hover effect more subtle and visually appealing.
Key updates:

Modified the hover background color of the copy button from a darker shade (bg-gray-500) to a lighter shade (bg-gray-100).

@zhendi @hiveer please review & approve


2.0.4 - Update by ImReallyShiny

Main Change is the name, I renamed it to "IETVNOW" as its kinda like the other plugins "USTVNOW" and "UKTVNOW/Again"
I re-done the Icon and every single logo so they look HD and not stretched lol
and moved them to resources/logos/
Changed the flow of main.py a good bit;
Had stuff like: def news { return('{streamlink}') }
and such but its unnecessary you should of just added it directly in the get_videos bit which is now called "streams"
Removed the tv3, 3e stream grabbers as its unnecessary since theres now a perma link for them. I kept UTV as its IMPOSSIBLE to get a perm stream for it due to it requiring a Token. (Kinda like AerTV's Dealio)
Some other various variable name changes and such to make the code more robust.
--
I already changed the Addon.xml appropriately and added some minor details and also added me to the "Providers" if you dont like that just remove me from it :+1:
--
I already tested everything and it all works perfectly fine :D

FYI: TG4 not a perma link, so I put a scraper back in.
Stephen Easley-Walsh
https://www.mathsgrinds.ie/ https://www.MathsGrinds.ie
0851263404
***** Email confidentiality notice *****
This message is private and confidential. If you have received this message in error, please notify me and remove it from your system.
From: Shiny<EMAIL_ADDRESS>Sent: Thursday 8 September 2016 19:06
To: mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV
Subject: [mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV] 2.0.4 - Update by ImReallyShiny (#5)
Main Change is the name, I renamed it to "IETVNOW" as its kinda like the other plugins "USTVNOW" and "UKTVNOW/Again"
I re-done the Icon and every single logo so they look HD and not stretched lol
and moved them to resources/logos/
Changed the flow of main.py a good bit;
Had stuff like: def news { return('{streamlink}') }
and such but its unnecessary you should of just added it directly in the get_videos bit which is now called "streams"
Removed the tv3, 3e stream grabbers as its unnecessary since theres now a perma link for them. I kept UTV as its IMPOSSIBLE to get a perm stream for it due to it requiring a Token. (Kinda like AerTV's Dealio)
Some other various variable name changes and such to make the code more robust.
I already changed the Addon.xml appropriately and added some minor details and also added me to the "Providers" if you dont like that just remove me from it 👍
I already tested everything and it all works perfectly fine :D

You can view, comment on, or merge this pull request online at:
https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5
Commit Summary

2.0.4 - Update by ImReallyShiny

File Changes

D 3e_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-0  (0)
M addon.xml https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-1  (7)
M icon.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-2  (0)
D irish_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-3  (0)
M main.py https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-4  (93)
D news_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-5  (0)
D oireachtas_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-6  (0)
A resources/logos/3e.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-7  (0)
A resources/logos/IrishTV.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-8  (0)
A resources/logos/Oireachtas.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-9  (0)
A resources/logos/RTE1.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-10  (0)
A resources/logos/RTE2.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-11  (0)
A resources/logos/RTE_News_Now.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-12  (0)
A resources/logos/RTEjr.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-13  (0)
A resources/logos/TG4.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-14  (0)
A resources/logos/TV3.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-15  (0)
A resources/logos/UTV.png https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-16  (0)
D rte1_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-17  (0)
D rte2_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-18  (0)
D rtejr_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-19  (0)
D tg4_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-20  (0)
D tv3_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-21  (0)
D utv_logo.jpg https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5/files#diff-22  (0)

Patch Links:

https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5.patch
https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/5 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJt0DEC9S-WtTAQ8H5ohy-KoDHkV1aRkks5qoE5wgaJpZM4J4R8F .  https://github.com/notifications/beacon/AJt0DJmOrJ3AnBDXD6p5HDNJDmaQAGn9ks5qoE5wgaJpZM4J4R8F.gif


[Perception] add paddle3d introduction

add paddle3d introduction

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wangxitong01 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Makefile] Add jupyter-lab target

Out of scope of current iteration, but might be still useful.

Fixed all comments, thank you @mariyadavydova !


fix dequal

https://codesandbox.io/s/infallible-meadow-r5v8x?file=/src/App.js

Thank you @promer94, I was trying to get rid of lint error but introduced this bug.


Add support of default ssl certificate.

Why do you need it?
When one cluster have multiple ingresses under different namespaces but shares one subdomain, the wildcard certificate need to be copied into every namespace.
This will consume more resource and may increase cert leak risk.
eg:

namespace a have one ingress a.example.com
namespace b have one ingress b.example.com
...
and cluster have *.exmaple.com cert

How could it be?
Define one global ConfigMap field to support default ssl certificate.
When one namespace's ingress is set to use one tls secret, but fails to resolve(either not found or wrong secret), higress then search for this global config to see if hosts match cert's domains(especially for wildcard cert)
But be careful: when using cert-manager with this function, when trigger reconcile first time, the tls.secretName will be missing under same namespace (when issuing cert),we should update right cert when cert is ready in-time.
Other related information
Witch ingress-nginx support: https://kubernetes.github.io/ingress-nginx/user-guide/tls/#default-ssl-certificate

Hi @johnlanni,  I would like to work on this issue. Can you please assign this issue to me? Thank you.


feat: add vs-code launch json and env example files for debugging

Description
What - Add launch json and .env.example file
Why - Every vs-code user could debug with ready-to-use debug config
How - copy the .env.example to .env and use your own custom env for debugging
Type of change
Please leave one option from the following and delete the rest:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] New Integration (non-breaking change which adds a new integration)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Non-breaking change (fix of existing functionality that will not change current behavior)
[ ] Documentation (added/updated documentation)

Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.

Hey @yairsimantov20 are you referring to the fact there are .env.example and the launch.json is trying to load .env files?


When a Breakpoint is reached and we are typing game input the class gets the text.

While debugging and a breakpoint is reached, Visual Studio window is focused
and for example in the most common scenario when the WASD keys are being used
the class will end up with this new "dddddddddddddddd" or "sssssssssssssssssss".
Is there a way to block keyboard input when a breakpoint is reached or this needs fixing?
Thanks in advance.
Jay

@JayFiraja -- John, thank you for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please let us know which topic you’re referencing, or provide more context around your general task.

Never mind I found the options in Tools/Options/Debugging, [ ] Enable Edit and Continue
apparently, the feature is called Edit and Continue, but for us Unity Game devs we can't use that. yet.
It was an issue because in games there is constant input from the keyboard while testing an app/game so the breakpoint ended up making changes in the class.

@JayFiraja -- John, thank you for locating that information.  Best wishes for a successful game.


New-AzureADApplicationPasswordCredential 'Client-Secret-key provided is not working. But doing same with portal is working'

Client Secret created by this command
$appSecret = New-AzureADApplicationPasswordCredential -CustomKeyIdentifier PrimarySecret -ObjectId $app.ObjectId
gives error.
Authentication failed: AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app 'xxxx'
I have provided client secret for sure
Pls do update me asap
Thanks
G N Sharan Sai

Thanks @gnsharans for highlighting this issue.
@madansr7 , is this something you can help with?

@gnsharans can you share more information. What PowerShell module are you using? Have you tried the same in Azure CLI.
I tried to repro the steps at my end and I get no errors.

Hi Team,
From 3 days, the output generated for the secret key is working fine.
Differences observed in output:

Clien secret key in earlier days(when I posted this query) ends with
'=', now when I tried to generate multiple secret key this '=' at end is
not observed.

But when the client secret key generated with '=', i had this issue.
After configuring azure cli. As I moved my script from Az powershell module
to azure cli.
Currently I am not facing the issue any more and I am using azure cli
module.( Azure cli is working fine ).
Probably after configuring, azure cli. I think the above powershell issue
resolved automatically.( assumption)
Thanks
G N SHARAN SAI
On Wed, Aug 31, 2022, 03:03 Saurabh Madan @.***> wrote:

@gnsharans https://github.com/gnsharans can you share more information.
What PowerShell module are you using? Have you tried the same in Azure CLI.
I tried to repro the steps at my end and I get no errors.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-docs-powershell-azuread/issues/851#issuecomment-1232192525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJRBJRAYAM5MVWXCR476O3DV3Z44NANCNFSM57BKZFTQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Jar creation failed

when executing the maven command
mvn -f kafka-ui-api/pom.xml clean install -Pprod -DskipTests
im getting the below error
[INFO] ✓ 3 modules transformed.
[INFO] [vite]: Rollup failed to resolve import "components/App" from "C:/Users/hlibd/IdeaProjects/kafka-ui/kafka-ui-react-app/src/index.tsx".
[INFO] This is most likely unintended because it can break your application at runtime.
[INFO] If you do want to externalize this module explicitly add it to
[INFO] build.rollupOptions.external
[INFO] error during build:
[INFO] Error: [vite]: Rollup failed to resolve import "components/App" from "C:/Users/hlibd/IdeaProjects/kafka-ui/kafka-ui-react-app/src/index.tsx".
[INFO] This is most likely unintended because it can break your application at runtime.
[INFO] If you do want to externalize this module explicitly add it to

but if if I changed the command to
mvn -f kafka-ui-api/pom.xml clean install -Pprod -DskipUIBuild=false -DskipTests
it working but the docker container (kafka-ui) is not running successfully due to missing UI artifacts (index.*)
Appreciate your support on this

Hello @hussam770 ,

what is the working directory from where you running build command?
please try to cd to the root kafka-ui directory and run build command from there? (no need to specify pom location in this case)

Hi, we had some issues with building on windows besides this one(#1582).
The thing is, right as @iliax suggested, you're running the build in the wrong directory (with the wrong pom file in your case). Try running clean install within the root directory and with the root pom.

Hi, im getting the same error trying to run ./mvnw clean install -Pprod as described in the docs. Im trying to build on Windows 10. Im running the command in the root directory. See below my error messages.
[INFO]
[INFO] ---------------------< com.provectus:kafka-ui-api >---------------------
[INFO] Building kafka-ui-api 0.0.1-SNAPSHOT                               [4/5]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ kafka-ui-api ---
[INFO] Deleting C:\Users\Franz\Programming\kafka-ui-api\target
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (checkstyle) @ kafka-ui-api ---
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (prepare-agent) @ kafka-ui-api ---
[INFO] argLine set to -javaagent:C:\Users\Franz\.m2\repository\org\jacoco\org.jacoco.agent\0.8.8\org.jacoco.agent-0.8.8-runtime.jar=destfile=C:\Users\Franz\Programming\kafka-ui-api\target\jacoco.exec
[INFO]
[INFO] --- git-commit-id-plugin:4.0.0:revision (get-the-git-infos) @ kafka-ui-api ---
[INFO]
[INFO] --- antlr4-maven-plugin:4.12.0:antlr4 (default) @ kafka-ui-api ---
[INFO] ANTLR 4: Processing source directory C:\Users\Franz\Programming\kafka-ui-api\src\main\antlr4
[INFO] Processing grammar: ksql\KsqlGrammar.g4
[INFO]
[INFO] --- spring-boot-maven-plugin:3.0.5:build-info (default) @ kafka-ui-api ---
[INFO]
[INFO] --- frontend-maven-plugin:1.12.1:install-node-and-pnpm (install node and pnpm) @ kafka-ui-api ---
[INFO] Node v16.15.0 is already installed.
[INFO] PNPM 7.4.0 was installed, but we need version v7.4.0
[INFO] Installing pnpm version v7.4.0
[INFO] Unpacking C:\Users\Franz.m2\repository\com\github\eirslett\pnpm\7.4.0\pnpm-7.4.0.tar.gz into C:\Users\Franz\Programming\kafka-ui-react-app\node\node_modules
[INFO] Installed pnpm locally.
[INFO]
[INFO] --- frontend-maven-plugin:1.12.1:pnpm (pnpm install) @ kafka-ui-api ---
[INFO] Running 'pnpm install' in C:\Users\Franz\Programming\kafka-ui-react-app
[INFO] Lockfile is up-to-date, resolution step is skipped
[INFO] Already up-to-date
[INFO]
[INFO]
[INFO] --- frontend-maven-plugin:1.12.1:pnpm (pnpm build) @ kafka-ui-api ---
[INFO] Running 'pnpm build' in C:\Users\Franz\Programming\kafka-ui-react-app
[INFO]
[INFO] ><EMAIL_ADDRESS>build C:\Users\Franz\Programming\kafka-ui-react-app
[INFO] > vite build
[INFO]
[INFO] vite v4.0.0 building for production...
[INFO] transforming...
[INFO] ? 3 modules transformed.
[INFO] [vite]: Rollup failed to resolve import "components/App" from "C:/Users/Franz/Programming/kafka-ui-react-app/src/index.tsx".
[INFO] This is most likely unintended because it can break your application at runtime.
[INFO] If you do want to externalize this module explicitly add it to
[INFO] build.rollupOptions.external
[INFO] error during build:
[INFO] Error: [vite]: Rollup failed to resolve import "components/App" from "C:/Users/Franz/Programming/kafka-ui-react-app/src/index.tsx".
[INFO] This is most likely unintended because it can break your application at runtime.
[INFO] If you do want to externalize this module explicitly add it to
[INFO] build.rollupOptions.external
[INFO]     at onRollupWarning (file:///C:/Users/Franz/Programming/kafka-ui-react-app/node_modules/.pnpm/vite@4.0.0_binvsr2w2vzqveeue6ibz2djda/node_modules/vite/dist/node/chunks/dep-ed9cb113.js:45707:19)
[INFO]     at onwarn (file:///C:/Users/Franz/Programming/kafka-ui-react-app/node_modules/.pnpm/vite@4.0.0_binvsr2w2vzqveeue6ibz2djda/node_modules/vite/dist/node/chunks/dep-ed9cb113.js:45477:13)
[INFO]     at Object.onwarn (file:///C:/Users/Franz/Programming/kafka-ui-react-app/node_modules/.pnpm/rollup@3.7.3/node_modules/rollup/dist/es/shared/rollup.js:24199:13)
[INFO]     at ModuleLoader.handleInvalidResolvedId (file:///C:/Users/Franz/Programming/kafka-ui-react-app/node_modules/.pnpm/rollup@3.7.3/node_modules/rollup/dist/es/shared/rollup.js:22857:26)
[INFO]     at file:///C:/Users/Franz/Programming/kafka-ui-react-app/node_modules/.pnpm/rollup@3.7.3/node_modules/rollup/dist/es/shared/rollup.js:22818:26
[INFO]     at processTicksAndRejections (node:internal/process/task_queues:96:5)
[INFO] ?ELIFECYCLE? Command failed with exit code 1.
I have tried adding ./ in front of components/App in the index.tsx file. This seems to be solving the issue with components/App but then other errors with the same error message but different import appear not solvable by adding ./. I have also tried implementing this Stackoverflow answer but without success.
If anybody has any suggestions how to fix it any help is greatly appreciated.

@kunzef https://github.com/provectus/kafka-ui/issues/1582

@Haarolean I don't think this should have been closed, there's a few problems building on Windows. And I don't actually see why https://github.com/provectus/kafka-ui/issues/1582 is related, or linked to.
We are not (apart from the OP) running the build from the wrong directory.

@Haarolean I don't think this should have been closed, there's a few problems building on Windows. And I don't actually see why https://github.com/provectus/kafka-ui/issues/1582 is related, or linked to.
We are not (apart from the OP) running the build from the wrong directory.

@credmond feel free to raise a new issue


ReflectionException gets rendered twice

Laravel Version: 5.3.16
PHP Version: 5.6.15
Database Driver & Version: None / Not Relevant

Description:
When a controller does not exist, a ReflectionException is fired.
Somewhere in the rendering process for this exception the corresponding HTTP response gets output twice.
This is especially bad if the error response contains JSON as this results as the JSON string "doubled", which results in invalid syntax.
Steps To Reproduce:

Create a fresh Laravel project, no database required.
Go to your web.php routes file and add the following line:
Route::get('/test', 'TestController@index');
This controller obviously doesn't exist and therefore will trigger the expected ReflectionExpection.
Serve up the project using php artisan serve.
Navigate in your browser to localhost:8000/test and take a look at the rendered exceptions (should be only one, it gets rendered twice).

My Observations:

Take a look at the current/total count on the rendered exception. The total count is 1, but still 2 are displayed. Screenshot
If you comment out either
$response->send(); or $kernel->terminate($request, $response);
in your public/index.php the duplication stops and the exception is rendered once only.
My guess would be that both of them are somehow handling the exception instead of just one.

Probably because the exception occurred again when the view was rendered.

I got the same thing here. Also found an open thread with the same behavior in https://laracasts.com/discuss/channels/laravel/exception-handler-fired-multiple-times .
Does anyone know the solution?

Probably because the exception occurred again when the view was rendered.

Why the downvotes? That's basically exactly the problem in most cases, and the most common case affecting controller middlewares has been fixed in laravel 5.4.


References to listed services

Is the content on this page up-to-date?
On the documentation page there is a list of services that are included in the built-in rule collection:

Compute access to storage Platform Image Repository (PIR)
Managed disks status storage access

Do you have any references / links on details about those services? What service endpoints / URLs / IP addresses they are using?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9880489-5c36-81e9-a8d6-4437afdc8dfa
Version Independent ID: 1f368321-3d3b-4ffa-495b-61a4014fe079
Content: Infrastructure FQDN for Azure Firewall
Content Source: articles/firewall/infrastructure-fqdns.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thanks for the feedback! We are currently investigating and will update you shortly.

@vhorne Could you please look into this? Thank you!

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


better control over subcommand output

In #68 @dae mentioned:

It would be great to have some sort of option like a build variable that could suppress the aggregated output in the success case, as while I love the extra insight during build, I'd miss the clean output if I had to decide on only one of the two.

The current n2 behavior is

the last line of task output is shown while it's running
all task output is displayed once a task completes

The use case here is there are commands that display a lot of progress output (e.g. a test runner), but that progress output is ultimately not useful to show specifically in the case where the task succeeds.  Another example of such a command is if a task is itself executing another build system (e.g. Cargo) that only displays build progress -- if the task's build succeeds we don't need to display anything.
We could do something like "only print a full log if the task fails", but also it seems plausible there are cases where you do want to see the full output.  For example the tail of the output of LLVM's check-lld task looks like
-- Testing: 2732 tests, 8 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 9.99s
  Unsupported: 2352
  Passed     :  380

Where I imagine it's good to display the "testing time" line.
So perhaps this is something to make configurable on a per-task basis?

Digging into the LLVM build, it appears check-lld is tagged into the console pool.

I presume their primary motivation for using the console pool in this case is so they can see the 10..20.. part update in real time. The testing time seems a bit less useful, since n2 is already displaying a counter as the command runs.
That said, I do think it would make sense to make a "hide output on success" setting configurable on a per-command basis, as there are other times where it would be useful (e.g. one might want a build step that outputs things like warnings, or generated auth info, or instructions for the user)


Exception: System.IO.FileNotFoundException on program startup

Log: https://gist.github.com/enzy/53286c7ec2ef7ce8f191

Duplicate with #226


Make delayed and remove property optional

fixes #295

This is small and has no downsides and fixes something important, so I'll just merge it and release a new version asap.

v0.6.9


chore: remove Chi from DynamoDB Namespace app

#187470327
Checklist:

[ ] Have you added Release Notes in the docs repositories?
[ ] Have you ran make run-integration-tests and make run-terraform-tests?
[x] Have you ran acceptance tests for the service under change?
[ ] Have you followed the Conventional Commits specification?

Removal of github.com/go-chi/render:
Thank you very much for taking the time to review these changes, @blgm .
The rationale behind this removal includes the following points that motivated me to refactor:

Objective of the Main Task: Remove Chi from test apps. The reasons for this task are:

The Go standard library has built-in functionality for this.
It reduces our dependency update burden.
It provides an opportunity to learn new Go functionality.

Note on Chi Router: It is no longer needed, but:

Keeping the render functionality contradicts one of our goals, which is to reduce dependency update burden.

Definition of render in Chi:

Every well-designed, robust and maintainable Web Service / REST API also needs well-defined request and response payloads. Together with the endpoint handlers, the request and response payloads make up the contract between your server and the clients calling on it.
Typically in a REST API application, you will have your data models (objects/structs) that hold lower-level runtime application state, and at times you need to assemble, decorate, hide or transform the representation before responding to a client. That server output (response payload) structure, is also likely the input structure to another handler on the server.
This is where render comes in - offering a few simple helpers and interfaces to provide a simple pattern for managing payload encoding and decoding.

We don't need this functionality at all. In fact, the implementation was redundant, and the payloads were not used anywhere.
If we need this functionality, the same implementation is available through simple marshalling and unmarshalling operations using the standard library. We don't modify the payloads in the outputs or requests.
There's no strong justification to implement the render interface and import the library that we want to avoid.
The payloads were left as errors because that's what the original implementation did. I'd be willing to remove the custom errors if that's the desired direction, but I wanted to avoid making too many changes at once.

Application Use Case: It's an app used to test the service, and doesn't significantly affect our design patterns, code readability, or project performance. I believe we're cleaning up the code, making it easier to read without the need for external libraries, and following the Boy Scout principle of leaving things better than we found them.

I'm open to simplifying the payloads and using text instead of custom errors if you think it's the right time, either in this PR or another.
What do you think?


Getting this error when asking any question to github copilot. Oops, your response got filtered. Vote down if you think this shouldn't have happened.

Same here. Every single thing immediately produces this response. I haven't had a single response work, for any code.

Ah, upgrading VS Code to 1.87 fixed it easy peasy


fix: issue with not reading spec file in working directory when no global context is created

…obal context is set.

Description

Fixed issue with not reading spec file in the working directory when global context file is not created.

Related issue(s)

Fixes #35

@Souvikns please have a look at my comments again, I suggested that part of the message must be reusable and things like asyncapi validate cannot be hardcoded

@derberg I took an approach to make the message reusable, let me know if this works or if we should take a different approach.

Looking at the message I would see only the name of the command in the example is dynamic. Suppose I am using the validate command and this error is thrown then the message will have asyncapi validate --file path/to/file/asyncapi.yml, on the contrary if I am using the optimize command then asyncapi optimize --file path/to/file/asyncapi.yml will be printed.
So basically we could pass a command parameter to the NoSpecPathFoundError to be used in the NO_SPEC_FOUND message. But then we needed to somehow access the command in run time. For that, I created a class to access the command name being used.
import meow from 'meow';
import { injectable } from 'tsyringe';

injectable();
export class CLIService {
  private _cli = meow('', { argv: process.argv.slice(2), autoHelp: false })

  command(): string {
    return this._cli.input[0] || '';
  }

  args(): any {
    return this._cli.flags;
  }
}

NO_SPEC_FOUND has this part "hardcoded" to validation -> Unable to perform validation. Specify what AsyncAPI file should be validated
I won't be able to reuse it with optimize or other new commands, or? I think this part should be separated

maybe we can make an object which stores all these fallback messages and after we determine which command was used print them accordingly.

Can't we just split NO_SPEC_FOUND into NO_SPEC_FOUND and VALIDATION_NO_SPEC_FOUND and in context of validation, concat both and in case of optimization have OPTIMIZE_NO_SPEC_FOUND? later once more come and it gets cumbersome we refactor

If we divide the complete message then Unable to perform validation. Specify what AsyncAPI file should be validated. part will be different for every command.
- You can use --file flag to provide a path to the AsyncAPI file: asyncapi validate --file path/to/file/asyncapi.yml
- You can use --context flag to provide a name of the context that points to your AsyncAPI file: asyncapi validate --context mycontext
- In case you did not specify a context that you want to use, the CLI checks if there is a default context and uses it. To set default context run: asyncapi context
use mycontext
- In case you did not provide any reference to AsyncAPI file and there is no default context, the CLI detects if in your current working directory you have files
like asyncapi.json, asyncapi.yaml, asyncapi.yml. Just rename your file accordingly.

We can split them and then connect them in the error to use accordingly.

exactly, split and then reuse together or in different configurations


dar: 2.7.5 -> 2.7.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dar/versions.
meta.description for dar is: "Disk ARchiver, allows backing up files into indexed archives"
meta.homepage for dar is: "http://dar.linux.free.fr"
meta.changelog for dar is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.7.6 with grep in /nix/store/acxpf86dbk1fws9j9sk9r3318anpffj5-dar-2.7.6
found 2.7.6 in filename of file in /nix/store/acxpf86dbk1fws9j9sk9r3318anpffj5-dar-2.7.6

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
dar

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/acxpf86dbk1fws9j9sk9r3318anpffj5-dar-2.7.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dar https://github.com/r-ryantm/nixpkgs/archive/2fc3f8df4958ac87b0959b26fc9bb655b88a7d14.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/acxpf86dbk1fws9j9sk9r3318anpffj5-dar-2.7.6
ls -la /nix/store/acxpf86dbk1fws9j9sk9r3318anpffj5-dar-2.7.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dar

Maintainer pings
cc @izorkin for testing.

Result of nixpkgs-review pr 179025 run on x86_64-linux 1

1 package built:

dar


fix: prevent widget config errors

:tada: This PR is included in version 4.17.0-rc.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Forge 1.20.1] Apparent issues displaying Solar Craft recipes

Using Solar Craft 3.2.2, and EMI 1.0.19 with JEI <IP_ADDRESS>, attempts to view unlocked recipes (tested so far with only the recipe for the Speed Tile, as that's the only one I have thus far) in my actual world appear to display with no items visible.
This does not happen in a creative world (wherein I cheated myself all the progression required for that mod's recipes to be viewable), where they appear normally.
Removal of EMI causes recipes to display properly again.
Textfile of my full modlist, using forge 47.1.3.

This is, as far as I can tell, resolved in 1.0.20


Translation string keys incorrect (facet-flag/facet-error/facet-star)

To Reproduce
Steps to reproduce the behavior:

Switch the language to another language than the default language of OpenRefine (English), e.g. German.
Note that the captions for facet selection (most-left column drop-down menu) are swapped/incorrect:
Translation string key core-views/facet-error is swapped with core-views/facet-flag.
Additionally core-views/facet-flag is used instead of core-views/facet-star, though that flag is symbolized as a star.

Current Results
Incorrect/swapped translation strings as wrong keys are used.
Expected Behavior
Correct translation strings, correct usage of translation keys.
Versions

Operating System: Windows 10 x64
Browser Version: Latest Chrome
JRE or JDK Version: Windows Runtime Bundle
OpenRefine: Version 3.4.1 [437dc4d]

Datasets
(applicable to any dataset)

@wetneb Our study group would like to solve this issue and would like to get some advice. Thank you!
SE_SUSTech

Hi @Warpeas, welcome on board!
We have a broad overview of the contribution process here: https://github.com/OpenRefine/OpenRefine/wiki/Your-first-pull-request
If you have any specific questions please do ask!

Hi, I think this problem is caused by some mistakes in translation. And it's fixed by commit 3465. I tried to switch to another language that I can understand (Chinese) and there's no such problem. I think the language load process is correct now in the new version and this issue could be closed. If there are other problems please let us know.

I agree, this was specific to German and seems to have been fixed by updates to the translations. Thanks for your investigation!


feat: add fallback bare repo (yadm support)

Title: should solve #149.
First, ty for this wonderful plugin, love the meticiousness of your code :-)
That said, before I continue further with this PR (doc, testing, etc) I want to make sure this is how you'd approach it (settings inside cli/Git.lua and my fallback_args approach).
This PR adds a test for each new GitObject coming from a buffer (i.e. has GitObject) if the current file is inside a git a dir, if not it will use a new cwd as well as supply --git-dir and --work-tree to the git command so that vgit can find the hunks, etc, basically replacing the git command with git --git-dir <path> --work-tree <path>.
In order to use the new setting you need to add the below to your setup:
require("vgit").setup {
  settings = {
    git = {
      cmd = 'git', -- optional setting, not really required
      fallback_cwd = vim.fn.expand("$HOME"),
      fallback_args = {
        "--git-dir",
        vim.fn.expand("$HOME/dots/yadm-repo"),
        "--work-tree",
        vim.fn.expand("$HOME"),
      },
    },
  }
}

Now if I my current working directory isn't a git repo or the file opened is outside the current working directory vgit is still able to show gutter signs as well as stage, reset hunks.
IMO this is better than gitsigns support for yadm where it basically falls back to running all git commands with the yadm wrapper script as this can support any git bare repo whether you have yadm installed or not.
This is WIP, wasn't tested fully and I'm pretty sure there are a few issues hiding, just wanted to gauge your interest/input before I continue.

https://github.com/tanvirtin/vgit.nvim/pull/218/commits/14097888c7d4a9398db43e39d2f40c1ea5da97c7 - this commit also adds git diff stats in the same buffer variable as gitsigns, vim.b.gitsigns_status_dict requested in #157, #212.
Let me know if you prefer I can create a separate PR just for that or since it's two different commits we can leave it at that?

@ibhagwan Thanks for this pull request, sorry for being late in getting to this, but I really appreciate this PR and your interest in this plugin :)
I recently pushed a huge update to VGit. Hopefully it's the last time I am making such a huge change. Going forward it's going to be small incremental changes only, as most of the dust around architecture has settled.
Can you pull the latest changes, some of the stuff you are working on has changed slightly.

@ibhagwan Thanks for this pull request, sorry for being late in getting to this, but I really appreciate this PR and your interest in this plugin :)
I recently pushed a huge update to VGit. Hopefully it's the last time I am making such a huge change. Going forward it's going to be small incremental changes only, as most of the dust around architecture has settled.
Can you pull the latest changes, some of the stuff you are working on has changed slightly.

1409788 - this commit also adds git diff stats in the same buffer variable as gitsigns, vim.b.gitsigns_status_dict requested in #157, #212.
Let me know if you prefer I can create a separate PR just for that or since it's two different commits we can leave it at that?

1409788 - this commit also adds git diff stats in the same buffer variable as gitsigns, vim.b.gitsigns_status_dict requested in #157, #212.
Let me know if you prefer I can create a separate PR just for that or since it's two different commits we can leave it at that?

Having the implementation of this feature in a separate PR would be awesome!

1409788 - this commit also adds git diff stats in the same buffer variable as gitsigns, vim.b.gitsigns_status_dict requested in #157, #212.
Let me know if you prefer I can create a separate PR just for that or since it's two different commits we can leave it at that?

1409788 - this commit also adds git diff stats in the same buffer variable as gitsigns, vim.b.gitsigns_status_dict requested in #157, #212.
Let me know if you prefer I can create a separate PR just for that or since it's two different commits we can leave it at that?

Having the implementation of this feature in a separate PR would be awesome!


update: added examples/stream.js

as requested in #58
I recommend all those who can, to contribute more examples to help beginners.

Thanks @KLVTZ!


Eliminate unnecessary API calls

Some endpoints from renku notebooks are slow. They can be improved by removing some unneeded frequent calls to gitlab or other APIs.

Check if we can get this in grafana/by quering prometheus directly

What can be cut down:

eliminate call to gitlab API when deleting a session (DELETE notebooks_blueprint.stop_server)

eliminate calls to gitlab API when listing sessions (GET notebooks_blueprint.user_servers)

reduce calls to gitlab API when listing autosaves (GET notebooks_blueprint.autosave_info)

reduce calls to gitlab API when starting a session, remove session creation retries (POST notebooks_blueprint.launch_notebook)

remove calls to gitlab api when getting server logs (GET server_logs)

reduce calls to gitlab api when deleting autosaves


FAKE support

first of all:

At the moment we analyze and run the build.cmd. This is unfortunate on Mac and Linux.
I think you should only analyze the build.fsx and run it directly via Fake.exe

But who would run Paket to download FAKE package from NuGet? It could be another .fsx script, in this case it could be cross-platform.

Actually, we analyze (and run) 1st found file with .cmd extension, not necessary called build.cmd. We could try to do the same for .sh file if we run on mono.
I still think running through .cmd / .sh is better solution since there are some steps which are usually put in there (downloading Paket for example)

Also another question is organization - should it be part of F# plugin or should we put it in it's own plugin? It can be used not only with F# projects so maybe good idea would be putting it aside?

I think it should be separate project and also work for C# solutions
On May 14, 2015 10:53 AM, "Krzysztof Cieślak"<EMAIL_ADDRESS>wrote:

Also another question is organization - should it be part of F# plugin or
should we put it in it's own plugin? It can be used not only with F#
projects so maybe good idea would be putting it aside?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/FSharp.Atom/issues/41#issuecomment-101975958
.

Yep, I can agree that separate project is best way of doing it. However, it would be cool to make some structure to make sharing common code between Paket.Atom, FSharp.Atom and FAKE.Atom easy. Any ideas?

Use paket's github file sharing feature. It's perfectly suited for this.

Well, but those shared files are not just dependencies - I can edit some shared files from point of view of each plugin. It should be rather some kind of link ( I can change file from all projects and change is reflected everywhere)(no idea if we can do sth like that with GitHub / Paket)

No that's not possible and while I can understand the benefits I didn't
find a good solution for this yet. Git submodule never worked for us.
On May 14, 2015 2:52 PM, "Krzysztof Cieślak"<EMAIL_ADDRESS>wrote:

Well, but those shared files are not just dependencies - I can edit some
shared files from point of view of each plugin. It should be rather some
kind of link ( I can change file from all projects and change is reflected
everywhere)(no idea if we can do sth like that with GitHub / Paket)
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/FSharp.Atom/issues/41#issuecomment-102027895
.

Some additional chat we had on the FAKE support:
cumpsd [20:36]
just tried to run it on a ProjectScaffold created project, but it errors out, mentioning init.fsx is not found. Was wondering how it is supposed to work
I picked FAKE build from command pallette
and did enter
I'm guessing it somehow finds this: https://github.com/exira/iis-ops/blob/master/build.cmd#L16
and tries to execute it (when it shouldnt)
just trying to understand the intended use case :simple_smile:

k_cieslak [20:57]
why do you have `init.fsx` in `build.cmd` file while FAKE script is named `build.fsx` ?

cumpsd [20:58]
that's the way https://github.com/fsprojects/ProjectScaffold/blob/master/build.cmd is :smile:

GitHub
fsprojects/ProjectScaffold
ProjectScaffold - A prototypical .NET solution (file system layout and tooling), recommended by the F# Foundation.

cumpsd [20:58]
it has an IF arround it
they check if build.fsx exist
if it doesnt, they call init

k_cieslak [20:58]
Damn

cumpsd [20:58]
init.fsx sets up the project and removes itself afterwards

k_cieslak [20:59]
can You just remove this whole `IF` from it :stuck_out_tongue_winking_eye:

cumpsd [20:59]
same for the https://github.com/fsprojects/ProjectScaffold/blob/master/build.sh#L19

cumpsd [20:59]
yeah :smile: but but... user experience! :stuck_out_tongue_winking_eye:

k_cieslak [21:01]
Well, I'm just RegEx'ing `build.cmd` and find file name, didn't think that there can be more than one, will try to handle it

cumpsd [21:02]
hmmm
perhaps regexing for all matches, checking which ones exist on disk, and then finding all targets from all the existing ones
aka: lots of work to change :S

Yep, I'll need to work on it (probably solution You've suggested in chat). It's on TODO list ;)

Also, after watching @tpetricek talk (https://vimeo.com/130350091) - it would be cool to have some way of using long-running FAKE tasks, and cancelling them.

Oooh, if I could trigger some command in Atom to start build Whatever in the background, that would be pretty neat :-)

@tpetricek Actually, You are able to do it right now, there is only a problem with cancellation of long running task (Usually it's something like press any key in command line and there is no smart way to do it yet). Just only way to cancel it cancel it is closing Atom or using Windows Task Manager (or something similar on other OS).

Hmm, then I can probably hack this together in my build script :-)
Certainly not perfect, but say build start creates a file build.running and waits until it is deleted - and then I can have build stop which deletes it... Can I see the output of the build script somewhere too? (I sometimes printed various things into the output for debugging in the talk... but I guess I can use F# Interactive now!)

FAKE support released and moved to own plugin


README says wait until version 1.1, you are already at version 1.2

Time to update the README on adaption advice. Thanks.

Opsie. You are right, I need to update the README


Change output directory to be delivered by simona to be in same folder as simona outputs

the simulation start date and time needs also given only once


fix: min_coverage parsing with default to 100

Description
Following the conversation on #287, this PR:

Solves #255
Makes min_coverage defaults to 100, which is a requirement but the behavior is missing

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

This may be a breaking change. The current behavior is min_coverage with defaults to 0, and fixing it to 100 would "cause existing functionality to change".

@alestiago with the addition of min_coverage between 0 and 100, now I think  his is definetly a breaking change. What do you think?

@alestiago with the addition of min_coverage between 0 and 100, now I think this is definetly a breaking change. What do you think?

I personally don't think this is a breaking change since specifying min_coverage smaller than 0 or greater than 100 was incorrect usage.

@alestiago can you add the hacktoberfest tag?

@kelvinwieth I'm not sure how do you want me to do so. Unfortunately this year we didn't prepare to participate in Hacktoberfest (hopefully next year we do!).


Fixed the layout for the toolbar when adding custom buttons

Just a small tweak to allow the toolbar to utilise the whitespace to the right of the title.  It will still wrap once all the whitespace has been used without affecting the title.

Coverage remained the same at 72.397% when pulling 18757e7a929558e93a80618cbd1ee7c987f5ce45 on rossknudsen:bugfix/fix-custom-toolbar-layout into b2c74f3eabd4b5c3bcc73b508f9fac8e6be2aa0e on gregnb:master.


Support to render ´´´leaflet Blocks

I would like hugo to transform the ´´´leaflet Blocks of the Obsidian Leaflet Plugin
so they display the linked .geoJson Files, similar as the Plugin does it.
As an example look at the Markdown Files in my Repository:
https://github.com/SpocWiki/quartz-fork/blob/hugo/content/geo/Continent/North-America/Canada.md
It contains this Leaflet Block:
``leaflet
id: Canada
zoomFeatures: true
minZoom: 2
maxZoom: 18
geojsonFolder: ./Canada//
markerFolder: ./Canada/
``

Which, in Obsidian, is rendered by the Obsidian Leaflet Plugin
This Plugin presumably parses the yaml section in the markdown block annotated with leaflet and interprets the instructions.
Unfortunately I am not familiar with JavaScript Development, so I cannot do it myself.
But I understand that leaflet is a very modular JavaScript client-library,
which should not interfere with hugos rendering mechanism.
Currently I have installed the leaflet node module into this project
using npm (also checked into this repository),
added a leaflet.html Template to the hugo layouts directory
and marked the File using layout: leaflet,
but the block still appears as Code and not rendered as a map.
My repository is open source and allows many Obsidian Users to use the maps and its metadata in their own repositories
by including it as a git submodule.
If someone implemented support for leaflet in this project, they could also publish these maps.
I could possibly take over the task of maintaining such a module by merging future changes from the Plugin Project,
given that its files and structure can be retained largely unchanged in this application scenario.

Going to mark this as out of scope for Quartz. With Quartz v4, this should be easy to write a plugin for. See: https://quartz.jzhao.xyz/advanced/making-plugins


Add plf_hive package

Split this failing package out of https://github.com/xmake-io/xmake-repo/pull/3742

It appears to pass the tests on recent compilers and fail the ones which do not fully support C++20.


fixed NewFromFloat to calculate accurate values

Multiplying floats by primitive types is not precise enough, and there is a serious bug that the amount generated by NewFromFloat is different from the original value.
issue : https://github.com/Rhymond/go-money/issues/121, #124
Fixed to use "github.com/shopspring/decimal" for float multiplication.
This fix requires a dependency on an external module,, but I could find no other idea.

Hello there!
There is an approximate date when this change would be integrated into main?
Or some other approach where this bug would be fixed?

Hello @kotaroyamazaki, is there any update on this PR? Thank you


[v0.18] Use #[repr(C)] for vertex & constant structs.

Fixes issues exposed by rust 1.67 field ordering changes (https://github.com/rust-lang/rust/pull/102750/)
This PR adds #[repr(C)] to vertex & constant structs preventing field ordering issues.
Note: This actually still works fine even if users have manually specified  #[repr(C)] themselves since declaring it multiple times works fine, e.g. this works:
#[repr(C)]
#[repr(C)]
#[repr(C)]
pub struct Vertex { ...

Resolves #3790
Could we get a new gfx crate release with this in it please? I think this will help out any old-school users of this crate.

Hey @kvark i know v0.18 is ancient these days, but this fix is quite valuable for anyone still using it with rust 1.67 (like me). I think it's worth making a 0.18.3 release with this. Wdyt?

@alexheretic sure, sounds good!

Would you mind bumping the version to 0.18.3 in the PR?

Would you mind bumping the version to 0.18.3 in the PR?

:heavy_check_mark:


Make glance and cinder policy files 644

Makes the glance and cinder policy files 644 so that Horizon can check them

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test

Are these the only files that aren't winding up 644? Probably would be better to explicitly set them this way in every project, just in case something else changes in the way we package them up or get them from upstream. Those can be a follow up PR too, doesn't have to be in this one.

retest


[question] Retain params in src url instead of parsing and treating as props?

Hi, thanks for the great work.
I notice that query parameters in the src URL are parsed and passed as props to the underlying API.
Example:
<Picture src="https://images.unsplash.com/photo-1520520731457-9283dd14aa66?ixlib=rb-1.2.1&q=85&fm=jpg&crop=entropy&cs=srgb" alt="something" />

Strips off the image parameters and produces these warning:
[astro-imagetools]  ixlib  is not a valid Picture Config Option
[astro-imagetools]  q  is not a valid Picture Config Option
[astro-imagetools]  fm  is not a valid Picture Config Option
[astro-imagetools]  crop  is not a valid Picture Config Option
[astro-imagetools]  cs  is not a valid Picture Config Option

Is it possible to make the Picture component process the full URL without parsing the query parameters that way?
Thank you!

It's really a major issue and I too have faced this many times. Thanks for opening an issue on GitHub.

I encountered the same issue with images from Notion SDK : image urls contain security params to be displayed but these params are removed by the plugin. Would it be possible to have a config option for that?
Thank you!


massCode: Add detail of the snippet to the view

Description
Added a detail view to the massCode extension
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hello @mkitane,
Based on the <List.Item.Detail />'s documentation you should avoid to make use of the accessories in the <List.Item /> and bring those informations to the markdown content.

When shown, it is recommended not to show any accessories on the List.Item and instead bring those additional information in the List.Item.Detail view.
https://developers.raycast.com/api-reference/user-interface/list#list.item.detail

In the way you presented in the screenshot, you have no space to show the subtitle nor the "Kubernetes" word.

Hello @mkitane,
Based on the <List.Item.Detail />'s documentation you should avoid to make use of the accessories in the <List.Item /> and bring those informations to the markdown content.

When shown, it is recommended not to show any accessories on the List.Item and instead bring those additional information in the List.Item.Detail view.
https://developers.raycast.com/api-reference/user-interface/list#list.item.detail

In the way you presented in the screenshot, you have no space to show the subtitle nor the "Kubernetes" word.

Good point, I moved that piece of info to the Detail view.

@mkitane It looks cool. We also need to update the changelog.

@mkitane I don't know if it's an implementation bug, but I faced a random bug. Sometimes the code is cut off in the preview.

It beginning to look quite nice! It seems like breaks disappear when using plaintext, is that something that you can do something about?

Unfortunately, Raycast only allows markdown for List.Item.Detail, which means that the plaintext is treated as markdown (and hence why you see the line break disappear).
A workaround would be:

to wrap it around a code block, just like it is done for the other languages.
Use a txt to markdown converter, but I couldn't find a good one.

An ideal solution would be to have Raycast support a text field additionally to the markdown one.
How do you think we should approach it?

Hi @mkitane 👋
I think I would just wrap it inside a block actually 😄 And after this is merged we can look into if we can find a better solution, but this is a nice enhancement that could be awesome to have out public 💯
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@mkitane I don't know if it's an implementation bug, but I faced a random bug. Sometimes the code is cut off in the preview.

@antonreshetov I updated the changelog.
Also, I can't reproduce this issue, the view is never cutoff for me.

I updated the changelog.

Adding a new feature increases the minor version, not the patch.
https://semver.org/

@pernielsentikaer Can this be fixed?


Refactored styles

Refactor style on Mentor's stepper:

Change space after buttons on 1,2,4 steps [General, Subjects, Photo] on mobile version (Do as on [Language] step).
Change space after buttons on 4 step [Photo] on tablet version.
Change size of button 'finish' (as buttons 'next->').

Original
Updated

@Tolik170 updated styles