Rename Components of The Routable Protocol

Remove use of segment as it actually refers to route element
Shorten names in order to increase readability without loosing unambiguity

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 38.88%.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   74.31%   74.31%
=======================================
  Files           5        5
  Lines         109      109
=======================================
  Hits           81       81
  Misses         28       28

Impacted Files
Coverage Δ

ReSwiftRouter/NavigationState.swift
100% <ø> (ø)
:arrow_up:

ReSwiftRouter/Routable.swift
0% <0%> (ø)
:arrow_up:

ReSwiftRouter/Router.swift
71.42% <58.33%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa754c...bcc469e. Read the comment docs.

Should be squashed...

@hlineholm When making breaking changes like this (renaming, changing, or removing public members), we should try to build a habit of adding the new stuff, and then marking the old ones as deprecated (& pointing to the new items)
One can deprecate the old items here like this:
@available(*, deprecated, message: "Deprecated in favor of `RouteElement`") public typealias RouteElementIdentifier = RouteElement

This way we can push out a minor update and allow users to migrate before a major release with breaking changes.

I'll add it!

@hlineholm-flir Do you want to update this to the current master so we can merge this in?

@hlineholm We've merged #116 with a similar intent, so this would be a great addition in the same vein. You could even skip the deprecation notices since there's breaking changes scheduled for v0.7 anyway. Could you rebase your branch or merge master into it?

@hlineholm / @hlineholm-flir Are you still interested in updating the PR?

Yes @DivineDominion I'm interested in this PR getting merged to master. Are there any changes still required?

Yes @DivineDominion I am. Haven't had time to work on this so might be good if someone takes a look at the changes to see that I'm not missing anything. I've rebased it on latest master and in that process I discovered I'd missed some renaming in a test and in the README.md.

Thanks! Looks good to me. I'll request another pair of eyes :)

Looks good!


just added a release drafter to repository

Signed-off-by: jomefavourite<EMAIL_ADDRESS>

Glad I did it correctly this time, thanks to Anita


chore: display total rows count in pagination footer

closes: #19
This PR allows displaying the total count of rows in the footer of the grid.

It look too crowded on pagination footer. What do you think @harshithpabbati ?

Could maybe do with some comma style formatting 5,000,022

lgtm! thanks @harshithpabbati


Connect-ExchangeOnline, Connect-AzAccount PS7 SHA256Cng error

Applies to both: Connect-ExchangeOnline and Connect-AzAccount (exactly the same error)
In PS7 I cannot connect, only if I import the module with -UseWindowsPowerShell parameter.
LOG:
Version,Organization,ScriptName,ScriptExecutionGuid,CommandName,CommandParams,RecordCount,SentBytesCount,TotalLatencyMs,ErrorLog
v2,,,,Connect-ExchangeOnline,EnableErrorReporting;LogDirectoryPath;LogLevel,0,0,0,FullyQualifiedErrorId=System.ExceptionMicrosoft.Exchange.Management.ExoPowershellSnapin.NewExoPSSession;CategoryInfo=NotSpecified: (:) [New-ExoPSSession] Exception;ExceptionType=System.Exception;;ExceptionMessage=System.Exception: Could not load type 'System.Security.Cryptography.SHA256Cng' from assembly 'System.Core Version=<IP_ADDRESS> Culture=neutral PublicKeyToken=b77a5c561934e089'.. \r\n ---> System.AggregateException: One or more errors occurred. (Could not load type 'System.Security.Cryptography.SHA256Cng' from assembly 'System.Core Version=<IP_ADDRESS> Culture=neutral PublicKeyToken=b77a5c561934e089'.)\r\n ---> System.TypeLoadException: Could not load type 'System.Security.Cryptography.SHA256Cng' from assembly 'System.Core Version=<IP_ADDRESS> Culture=neutral PublicKeyToken=b77a5c561934e089'.\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.Internal.Platform.CryptographyHelper.CreateSha256Hash(String input)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.Internal.Flows.AcquireTokenHandlerBase.LogReturnedToken(AuthenticationResult result)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.Internal.Flows.AcquireTokenHandlerBase.PostRunAsync(AuthenticationResult result)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.Internal.Flows.AcquireTokenHandlerBase.RunAsync()\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext.AcquireTokenCommonAsync(String resource String clientId Uri redirectUri IPlatformParameters parameters UserIdentifier userId String extraQueryParameters String claims)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext.AcquireTokenAsync(String resource String clientId Uri redirectUri IPlatformParameters parameters)\r\n   --- End of inner exception stack trace ---\r\n   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)\r\n   at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)\r\n   at System.Threading.Tasks.Task1.get_Result()\r\n   at Microsoft.Exchange.Management.AdminApiProvider.Authentication.UserTokenProvider.GetAccessToken()\r\n   --- End of inner exception stack trace ---\r\n   at Microsoft.Exchange.Management.AdminApiProvider.Authentication.UserTokenProvider.GetAccessToken()\r\n   at Microsoft.Exchange.Management.ExoPowershellSnapin.NewExoPSSession.ProcessRecord()\r\n   at System.Management.Automation.CommandProcessor.ProcessRecord()|

@peterruzicska
"Exchange Online PowerShell" and "Exchange Online PowerShell V2" modules support only Windows PowerShell.
Refer to the following support statement:
https://docs.microsoft.com/en-us/powershell/exchange/exchange-online-powershell-v2?view=exchange-ps#install-and-maintain-the-exchange-online-powershell-v2-module

Currently, the latest version of PowerShell that's supported for the EXO V2 module is PowerShell 5.1. Support for later versions of PowerShell (and by definition, support for Linux or Mac) is a work in progress and will be announced soon.

@officedocsbot assign @yogkumgit

@shivtorov Thank you very much for the contribution and sharing this explanation. @peterruzicska Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Implement the populate methods from Mongoose.

Reason
Since this is heavily inspired at Mongoose I think we should also implement the populate methods inspired by them.
This is their ref: Official docs
Also that feature makes coding way faster without the need of implementing consecutive queries to get the full result.
Proposal
Since I'm a new contributor I don't understand every aspect of this library yet, so I'll purpose small and incremental changes until we have a very similar structure of mongoose's populate method.
By that I'll list goals here so we can keep track and if anyone else wants to get involved follow up the development.

[x] Implement the populate method
[x] Attach the method to the Model definition
[x] Create tests to test this initial feature
[ ] Implement the ObjectId + ref options in an attribute
[ ] Implement a better API, such as Dog.get(1).populate('father')
[ ] Implement a better API, such as Dog.get(1).populate('father.father')
[ ] Improve the documentation

Sounds great!
Thanks for breaking the change up into smaller parts.  It makes it much easier to review and merge.

This will be a great addition to dynamoose. What's the status on populate, if you'd like help, I'd love to try and implement. Thanks for the work!

Yay, glad you like the proposal @chops318 ! 😁
Go for it buddy, I'm kindda stuck with a lot of work to be done and I might take longer than expected to finish this feature, so, help is always welcome!! =D

Would this eliminate the need for nested queries, e.g.:
Product.get(id, (err, product) => {
  if (!product) { /* no product found */ }
  else {
    Category.get(id, (err, category) => {
      if (!category) { /* no category found */ }
      else {
        product.category = category
      }
    })
  }
})

/ref https://github.com/automategreen/dynamoose/issues/120#issuecomment-293621445

@troyswanson Yeah yeah, definitely!!
My goal is to make:
Product.get('id').populate('category')

AHH! I love it! Thank you!

That's my intention aswell. I'm pretty much going to model the API as close to mongoose as possible

@chops318 Thanks for offering to help.  I'm looking forward to your PR.

@chops318  Do you know when you plan to have this PR ready.  I'm planning to release 0.8 sometime over the next week.  I would like to include this in that release if you think it will be ready.

@brandongoode I will be done sometime this weekend. What do ya'll think about using the bson module  to generate the ObjectIds? Seeing as that is what mongoose uses, I figure we would follow suit.

I would prefer not to populate ObjectIds.  With dynamoDB it really a hash/range key pair with the range optional.  There may not even be an ID attribute.  If someone wants to have keys auto-generated, they should use the default for the key attributes.

I agree with you @brandongoode, but we'll still need the ref to make possible the simpler version of the populate, don't you think?
Such as Product.get('id').populate('category'), cuz the model as defined that the category attribute has a model ref to it called Category

@lucianopf Yes.  ref is needed to know which model to use.

@chops318 If there is anything I can do to help let me know.

Is it possible to contribute to this feature? How can I do it?

Hello guys, I'm back! hehehe
After this AWS Reinvent, let's keep this rocking and release that!!
@dimitribocquet and @brandongoode!!

@lucianopf - great to hear from you.  This is one of a few items i want to make sure is fully supported in the 0.9 release.

Leave stuff to be done later screws the mind flow! hahaha
I'm taking soo much time to get used to the general idea again! 😂
It will be done! 💪

@lucianopf @brandongoode If I have some extra time over the next few weeks I plan on working on the documentation. Anyone maybe up for creating some issues about what should be added/improved (especially @lucianopf maybe since you said you kept having to check the demos and tests)? What specifically should I focus on if I get time?

Nice @fishcharlie !!
I'll take some time to dig a bit again at the codebase, find out stuff to be documented and create issues so contributors can help at that!! ^^
❤ open-source!

@lucianopf Tag me in any issues you create so I get alerted to them. Thanks for your contributions as well!! Really looking forward to this feature. Will need some good documentation tho before I know how to use it haha.

Hey buddy I haven't forgotten to do that, I'm just in a rush at my other projects and I wasn't able to point stuff for you to document yet =/
I'll try to do that during this weekend! ^^ @fishcharlie

This can be closed via #250 correct?

Closing this due to no recent activity. If this is still a problem or you have questions please feel free to comment again and we can try to help further.

Is it possible to populate a list?
For example you have a schema with
pets:[ { petid : String }]

Thanks buddy, and I'm sorry for not replying! 😬
The documentation is way better than I actually thought hehehe


Please tell me the way to solve it.

I got the following error message.
System.NullReferenceException
Message=Please call HealthService.Init() method in the platform specific project to use Health Plugin

HI @soil21,
On the Android project you have a file called MainAtivity, there in the method OnCreate you have to add the requested line
HealthServive.Init()

Thanks @Rabosa616

HI @soil21,
On the Android project you have a file called MainAtivity, there in the method OnCreate you have to add the requested line
HealthServive.Init()

When call Init(Application application), an error occurs in ContentPage.
I solved it by adding the member to Platforms\Android\HealthService.cs.
public static void Init(Activity activity, Android.OS.Bundle bundle)
{
CrossCurrentActivity.Current.Init(activity, bundle);
}

I did the same, may be you can create a PR for it

Do you have any sample project using Plugin.Health package? Please let me know if it is.


'Answer Length' metric

aka 'Brevity' metric.  Simple character count of answer (this metric might be somewhere else in the code but I'm not seeing it?)  Some models could score higher on relevancy but with more words (in theory) - an 'answer length' metric would control for that.

This is a great point. I like this metric - i added it as a custom metric with a very simple implementation here but never thought about having it as an official metric but I can see the use case for it. Feel free to submit a PR - would love to take a look!
https://docs.confident-ai.com/docs/quickstart/custom-metrics

PR here - looks like it failed a lint formatting curious what you're using and what I could run it by locally - wasn't sure how to incorporate other than just what it is - used same as your custom metric but checks for > 1 character and returns 'AnswerLength'
https://github.com/confident-ai/deepeval/pull/118

This was merged and closed :)


How to use the swaggerUI?

I would like to learn the knowledge of the swaggerUI. Whoever can talk this topic. thx.

Ok, I will do that by myself.


Change INF for echo sample to comply with new InfVerif requirements.

Using preview versions of the EWDK results in the build failing due to the sample using a reserved MSFT class in its INF:
[cargo-make][1] INFO - Execute Command: "infverif" "/v" "/w" "/msft" "C:\\Users\\natede\\source\\repos\\Windows-rust-driver-samples\\target/debug/echo_2.inf"
Running in Verbose
Running Windows Driver INF check
Running in MSFT driver mode

Validating echo_2.inf
ERROR(1284) in C:\Users\natede\source\repos\Windows-rust-driver-samples\target\debug\echo_2.inf, line 10: Class "Sample" is reserved for use by Microsoft.
ERROR(1285) in C:\Users\natede\source\repos\Windows-rust-driver-samples\target\debug\echo_2.inf, line 28: Cannot specify [ClassInstall32] section for Microsoft-defined class.
INF is NOT VALID

This PR updates the echo sample to use a custom "Rust_Sample" class.

Ah, I just noticed that the README section discussing changes required before making a production driver calls out that the "Sample" class would need to be changed.  @wmmc88 do you prefer that the sample works "out of the box" when calling cargo make, or that we require people using the sample to manually update the INF?

Hey @NateD-MSFT! The section of the readme that I believe you're referencing is actually straight from the upstream C/C++ samples repo. I would like to continue using the Microsoft Reserved Samples Class GUID, since these are also still Microsoft sample drivers.
To get around the infverif flagging, we used /msft infverif flag, similar to what the upstream C/C++ repo used. This worked without issue in NI. It looks like in the preview infverif, they've switched to using /sample with an assortment of other flags, but only for post-NI WDKs. Similar logic will need to be added into the Makefile to set WDK_BUILD_ADDITIONAL_INFVERIF_FLAGS. Same as the upstream C/C++ samples, it needs to support whatever WDK mechanisms the user is using (eWDK, installed WDK, winget WDK, etc)

@wmmc88 Thanks for looking into it in more detail - I noticed the /msft flag was no longer working but wasn't aware of the /sample flag change.  As for checking WDK compatibility, that's actually why I'm doing this exercise; I'll be checking the process for WDK/eWDK/package manager WDK and see what snags we hit.
I agree it makes sense to keep the sample class.  I'll close this PR.


Domain verification setting is not respected

Describe the bug
A newly added domain requires verification with the domain verification checkbox turned off on instance and org levels.
To Reproduce
Steps to reproduce the behavior:

Go to 'Instance -> Settings -> Domain Settings'
Uncheck 'Validate Org domains' and Save
Go to any Organization
Go  to 'Settings -> Domain Settings'
Uncheck 'Validate Org domains' and Save
Go to the organization "Domains"
Add a new Domain
The new domain is unverified

Expected behavior
A new domain is to be marked as verified if domain verification is turned off.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu
Browser Chrome
Version v2.0.0-v2-alpha.43

Additional context
Add any other context about the problem here.

Hi @shedar
Thanks for your report. I could reproduce your bug an we will have a look at it.

This bug was also reported in our discord channel https://discord.com/channels/927474939156643850/927866047757959189/1000749796019146772


FancyZones

Microsoft PowerToys version
0.51.1
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
I am not certain as i can't reproduce it systematically.
I have 3 setups:
1 - using laptop alone (lenovo c940)
2 - using laptop with attached displaylink portable monitor
3 - using laptop attached to a tb3 dock (anker) and then a usb-c connection to a ultrawide screen
I often have to reboot for unknown reasons and the laptop often crashes during sleep.
My current hypothesis is that if the powertoys fancyzones process is not shut down correctly, the config is lost (as if i had just installed).
I then have to redo everything in the layout screen (settings on the fancyzone settings screen itself seem to be saved).
✔ Expected Behavior
Once the layouts are set, i NEVER have to redo them.
❌ Actual Behavior
Layouts are lost and i have to recreate them or assign "non" to my laptop screen instead of the 3 pane default.
Other Software
No response

By "config is lost" do you mean that the layout was reset to a default one or that you have to recreate them in the editor?

Actually both.
The layout associated to screens currently attached (i.e. internal laptop screen) is reset to the 3 pane layout and i have to recreate the canvas layout i like for my ultrawide screen.
I don't know if this helps, but when i installed the first time, i had 0.51.0, i then upgraded to 0.51.1 when i read that it fixed a bug i had.

Looks like https://github.com/microsoft/PowerToys/issues/14782 to me then, since the setting files are lost after the crash. Let's centralize the discussion thread there.


The .sidebar-message-wrap is overlapping .menu-wrapper.last

Hello :wave:
I'm running the kuma-gui on the last Firefox version on MacOS.
I can't see the 3 last elements of the menu, I have to delete or hidden the .sidebar-message-wrap to access them.
Here's a screenshot:

Thanks,

Hello!
Thanks for catching this. With the growing sidebar menu, this has become more of an issue lately. I've actually revised this in the latest version and have moved those resource links out of the sidebar as to avoid this altogether. My apologies for the inconvenience!

Thanks ! I can close that issue so. :)


Font problem with the value of temperature

Hi
I am a Chinese user, so you can see that the font displayed by my temperature value is not clear, it should be a default font obtained from the system.
Is it possible to add a global font definition, or default to a font with better display effect？
thx

Hi,
technically, the text that is displayed in the button is, like the icons, part of an SVG image. Because I do not know exactly, which fonts are available on the users system, i am only defining a font family ("font-family": "sans-serif").
From what i can see on your screenshot, the text is not rendered in a "sans-serif" font at all - i don't know, why.
Maybe you have not a single sans-serif font installed on your system? (hard to imagine, but well, things happen). You could try to install Roboto (https://fonts.google.com/specimen/Roboto) for testing, if the renderer will choose this font.
If this does not help, a solution could be a front picker in the settings view of the plugin, but that may take some time.

:(
Install Roboto doesn't show any changes.
Maybe you can  change ("font-family": "sans-serif") to  ("font-family": “Helvetica Neue”,Helvetica,Arial,”Microsoft Yahei”,sans-serif) ，packeg it and mail me,I will test and report the results.

Hi,
i have attached a version with font-family "Roboto, Arial, Helvetica, sans-serif". I did not manage to add fonts with a space (escaping/quotes in any known combination did not work).
You will need to manually install the plugin by removing anything from Folder
C:\Users\[XYZ]\AppData\Roaming\Elgato\StreamDeck\Plugins\de.perdoctus.streamdeck.ha.sdPlugin
and add all files from the zip file.
Hope this will work :)
experimental.zip

Hi
I think I solved this problem
I modified the code in plugin.1b072062.js,
"font-family":"Roboto, Arial, Helvetica, sans-serif" -->"font-family":"arial"

the possible problem maybe
1.my system can not find sans-serif
2. snapsvg does not support multiple font settings
:)


content(cms): create Tag "controlled-vocabulary"

Automatically generated by Netlify CMS

going to close this as it seems to have gone stale. feel free to reopen, or create a new one, if this is still needed.


YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.

Description of PR
JIRA: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 30s

trunk passed

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 49s

trunk passed

+1 :green_heart:
shadedclient
33m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 43s

the patch passed

+1 :green_heart:
shadedclient
33m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 42s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

124m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5901

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6070db9fdfe9 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 25facff80fbfd6006cab3d487fad03eae59dbe0c

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/3/testReport/

Max. process+thread count
665 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 37s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 26s

trunk passed

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 43s

trunk passed

+1 :green_heart:
shadedclient
38m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
compile
0m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 17s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 41s

the patch passed

+1 :green_heart:
shadedclient
38m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 36s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

136m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5901

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 19be9cefd5c0 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 25facff80fbfd6006cab3d487fad03eae59dbe0c

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/2/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 49s

trunk passed

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 24s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 36s

trunk passed

+1 :green_heart:
shadedclient
20m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 15s

the patch passed

+1 :green_heart:
compile
0m 15s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 15s

the patch passed

+1 :green_heart:
compile
0m 14s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 16s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
0m 30s

the patch passed

+1 :green_heart:
shadedclient
20m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

88m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5901

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cfb8957a60fc 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk /<PHONE_NUMBER>954f868b7a08adc83ad7b4bbb6acda

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/4/testReport/

Max. process+thread count
641 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m  2s

trunk passed

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 23s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 44s

trunk passed

+1 :green_heart:
shadedclient
38m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
compile
0m 16s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 40s

the patch passed

+1 :green_heart:
shadedclient
38m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 38s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

153m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5901

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b5d86b8797fa 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 110d27f747a610535ebeb63f93e14cbe0cb8c830

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/5/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5901/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for reviewing the code! I will proceed with the backporting of GPG and merge this pr into the trunk branch.


Add Chocolatey instructions

Implements #175

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm not familiar with the markup in the .rst files, so tried to copy the style. I may have made mistakes though.

http://dnephin.github.io/dobi/install.html


Investigate stopping anyone from posting to the DHT

We should find a way to stop the validators from posting random data to the DHT.

Closing as this is given by the default implementation of the validators.


[JDK20] Enable StructuredTaskScopeTest

Related: eclipse-openj9/openj9#15627
Related: eclipse-openj9/openj9#15629

@llxia @Mesbah-Alam Can you please help merge this PR?
I successfully ran a 50x grinder for StructuredTaskScopeTest with JDK20: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/32571/.


feat(dex): Sort Pokemon by Generation

Adds a button to sort the Pokemon in a dex by Generation as well as Dex Number.
Fixes: #420

I've been trying to start my living dex from the beginning and I want each generation of Pokemon to be caught in the generation they were introduced, however this is a bit of a problem since the earliest games supported are Gen 6. I was using the ORAS National Dex for Emerald but it made figuring out where to put which Pokemon in my boxes a bit more difficult since I had to skip over the older Gens and the newer Gens (such as Gen 4 evolutions/babies of Gen 3 Pokemon). This functionality makes it a lot easier to use the newer dex definitions to track for older games.
I think with this all you need is a dex type that returns all Pokemon for all games and you'd have a nice way to track your entire living dex in one place, rather than splitting them up into multiple dexes

hey @Garethp!
our preferred way to solve this problem is to actually add support for the older games (including capture info), as opposed to adding sorting. we're not trying to optimize for using the current gen dexes to track older games.
thanks anyway for the contribution! we'll be cleaning up our submitted issues so it can be more clear which things are actionable or not.

I still believe that sorting by generation has it's own use-case, especially if you want to have each generation in it's own box (for example, in Home I'd rather have my Gen 2 Pokemon in a separate box from my Gen 3 Pokemon. Being able to see that Treeko is the first Pokemon in it's own box rather than at the end of row 2 of a box that starts with Miltank is useful to me. I personally end up running my forked webapp locally and have it talk to your API for this exact reason.
That being said, I'm aware this is an open source project and for the issue of supporting older games you'd rather add support directly such as adding capture info. How can I contribute that data? It doesn't look as if the full data set is in any of the Github  repos. If possible, I'd like to help contribute to extending this project's support for games and features in ways that you prefer.


Correct typos, improve grammar

Hi @WebReflection , thanks for this package, looks interesting!
Quick PR to fix some typos and improve some grammar.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
487

Relevant Lines:
487

💛  - Coveralls

Love these kind of MRs, thank you 🍻

Glad to help, thanks for the merge!


Ehcache 3 and Ehcache 2 builds are broken

Hi
I thought I would dust off ehcache on its 20 year anniversary as part of an article I am writing. I was looking to build the software and have a play with it. But neither the 2 or 3 build is working. Details follow.
Ehcache 3 Build
Java 17
Command line: ./gradlew build
The build fails. Following are some of the failures.
If there are switches that need to be added or other settings to make this build, what are they? The documentation is horribly out of date.
`

Task :clustered:server:ehcache-service:compileJava FAILED
/Users/gluck/work/ehcache3/clustered/server/ehcache-service/src/main/java/org/ehcache/clustered/server/offheap/OffHeapChainStorageEngine.java:217: warning: [cast] redundant cast to ByteBuffer
return (ByteBuffer)detachedContiguousBuffer.flip();
^
/Users/gluck/work/ehcache3/clustered/server/ehcache-service/src/main/java/org/ehcache/clustered/server/offheap/OffHeapChainStorageEngine.java:702: warning: [cast] redundant cast to ByteBuffer
final ByteBuffer detachedBuffer = (ByteBuffer) ByteBuffer.allocate(attachedBuffer.remaining()).put(attachedBuffer).flip();
^
error: warnings found and -Werror specified
1 error
2 warnings

Task :ehcache-impl:compileUnsafeJava FAILED
/Users/gluck/work/ehcache3/ehcache-impl/src/unsafe/java/org/ehcache/impl/internal/concurrent/ConcurrentHashMap.java:2583: error: cannot find symbol
@sun.misc.Contended
^
symbol:   class Contended
location: package sun.misc
/Users/gluck/work/ehcache3/ehcache-impl/src/unsafe/java/org/ehcache/impl/internal/concurrent/ThreadLocalRandomUtil.java:57: warning: [removal] AccessController in java.security has been deprecated and marked for removal
return java.security.AccessController.doPrivileged
`

Ehcache 2 Build
I cannot create an issue on that repo, so adding it here.
Java 17, Maven 3.9.0
Command: mvn clean install
Here the error is that a Terracotta maven repo is offline.
Is there some way this can be built without being a Software AG employee? What do you need to change?
[ERROR] Failed to execute goal org.terracotta:maven-forge-plugin:1.2.5:buildinfo (generateBuildInfoFile) on project ehcache-root: Execution generateBuildInfoFile of goal org.terracotta:maven-forge-plugin:1.2.5:buildinfo failed: Plugin org.terracotta:maven-forge-plugin:1.2.5 or one of its dependencies could not be resolved: Failed to collect dependencies at org.terracotta:maven-forge-plugin:jar:1.2.5 -> com.softwareag.ibit.tools:finder:jar:2.05a: Failed to read artifact descriptor for com.softwareag.ibit.tools:finder:jar:2.05a: Could not transfer artifact com.softwareag.ibit.tools:finder:pom:2.05a from/to maven-default-http-blocker (http://<IP_ADDRESS>/): Blocked mirror for repositories: [terracotta-snapshots (http://www.terracotta.org/download/reflector/snapshots, default, releases+snapshots), terracotta-releases (http://www.terracotta.org/download/reflector/releases, default, releases+snapshots)] -> [Help 1]

Ehcache 3 still supports Java 8. It can be built with Java 11, but will not build with Java 17. Mostly this is due to not wanting to scatter @SuppressWarnings throughout the source to suppress warnings that are Java 17 specific (deprecations/unneeded casts). If you want to build with 11/8 and test with 17 that can be done with:
./gradlew -PtestVM=<path-to-test-jvm> ...

Ehcache 2 should build fine outside of Software AG, but I doubt very many people do at this point. The errors you're seeing are due to later releases of Maven blocking usage of http URLs in repositories. It's relatively simple to fix this in your settings.xml by mirroring the repository at its own https url:
<mirror>
    <id>https-terracotta-releases</id>
    <name>HTTP unblock for terracotta-releases</name>
    <url>https://repo.terracotta.org/maven2</url>
    <mirrorOf>terracotta-releases</mirrorOf>
</mirror>

It's possible other things have bit-rotted and not been noticed due internal caching but at this point Ehcache 2 is 8 months from being completely EOLed (repository will go read-only). These kind of things could be fixed but they cause minimal hassle for the very minimal amounts of development that happens there at this point.


Optimization flag breaks component css

🐞 Bug report

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

In development there is no problem, but  in production the css of a particular class is not working entirely.
This component has to cover all the pages only on printing with a string passed as input, this string is rotated by 45°, grey, repeated.
There is no exception nor error signaled.
Sometime i think that part of the css is applied, something like the on @screen { display: none; }, but absolutely not the @media print part.
print-with-watermark.component.less:
@media screen {
   .footer {
       display: none;
   }

   .watermark {
      display: none;
   }
}

@media print {

   @page {
      margin: 10mm 5mm 15mm;
   }

   .watermark {
      display: block;
      position: fixed;
      left: 0;
      top: 0;
      overflow: hidden;
      z-index: 99;
      width: 100vw;
      height: 100vh;
      opacity: 75%;
   }

   .watermark img {
      max-width: 100%;
   }

   .aLotOfMargin {
      margin: 70px 50px;
      color: rgb(233, 233, 233);
      font-size: 15px;
      pointer-events: none;
      -webkit-transform: rotate(-45deg);
      -moz-transform: rotate(-45deg);
   }

   .footer {
      position: fixed;
      bottom: 0;
      height: 2cm;
      width: 100%;
   }

   .footer img{
      position: fixed;
      bottom: 0;
      height: 30px;
      width: auto;
   }

}

print-with-watermark.component.html:

      <button  icon=""
               printSectionId="print-section"
               printTitle="Print"
               [useExistingCss]="true"
               ngxPrint
      > Stampa </button>

         <ng-content></ng-content>

{{ inputText }}

   <button *ngIf="showBottomButton"
      icon="" printSectionId="print-section"
      printTitle="Print"
      [useExistingCss]="true" ngxPrint
   > Stampa </button>

print-with-watermark.component.ts:
import { Component, ElementRef, Input, ViewChild } from '@angular/core';

@Component({
  selector: 'app-print-with-watermark',
  templateUrl: './print-with-watermark.component.html',
  styleUrls: ['./print-with-watermark.component.less']
})
export class PrintWithWatermarkComponent {
  @ViewChild('watermark') el?: ElementRef;
  @Input() inputText?: string;
  rows?: Array<unknown>;
  columns = new Array(3);
  showBottomButton = true;

  constructor() {
    const h = Math.floor(window.innerHeight/140);
    this.showBottomButton = (Math.floor(window.innerHeight/160) > 4);
    this.rows = new Array(h);
  }

}

🔬 Minimal Reproduction

i use primeng as UI library and there are some elements in this component, so it needs to be installed.
you can just copy the 3 files, add some content calling the component like:
<app-print-with-watermark [inputText]="random string">
   random content
</app-print-with-watermark>

And go with ng build --prod with
"...
configurations": {
        ....
         "production": {
                   "optimization": true
          }
        .....
}...

in your angular.json
I'm sorry i don't know how to offer a ready to use example
🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 11.2.4
Node: 12.21.0
OS: linux x64

Angular: 11.2.5
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.7
@angular-devkit/build-angular   0.1102.4
@angular-devkit/core            11.2.4
@angular-devkit/schematics      11.2.4
@angular/cdk                    11.2.4
@angular/cli                    11.2.4
@schematics/angular             11.2.4
@schematics/update              0.1102.4
rxjs                            6.6.6
typescript                      4.1.5

Anything else relevant?

it happens in chrome and firefox, didn't try anything else

turning false the optimization flag on production resolves the problem,
it does the same in development configuration as well
(aot doesn't matter, i keep it true)

Hi @ubaldiniTerre,
Thanks for opening this issue, however this is caused by https://github.com/cssnano/cssnano/issues/957, however the fix hasn't been released yet.
As a workaround you 0.75 instead of 75% as opacity.

Hi @ubaldiniTerre,
Thanks for opening this issue, however this is caused by cssnano/cssnano#957, however the fix hasn't been released yet.
As a workaround you 0.75 instead of 75% as opacity.

thank you


Make semistandard a non-dev dependency

Since semistandard is required to use this tool (e.g. repo-tools lint), it's not exactly a dev-only dependency.
(More importantly, marking it as a dev dependency means NPM won't install it when @google-cloud/nodejs-repo-tools is installed.)

Do we still have any projects using repo-tools lint? That seems like an easy-ish thing to slice out of this project, and just bring in prettier where we need it. @fhinkel

We have lot's of projects that do that. But I didn't see this PR in time to object :( .
Every project should define its own linter job so we don't rely on repo-tools. Not cool if somebody clones our GAE Hello world sample and then ends up downloading two different linters.
Let's please not use semistandard, and if we do, let's make it explicit. Everything should use prettier and eslint.
@ace-n For which projects did you run into problems with this?


Update url in readme

The previous url is pointing to a different section in the documentation.

Thanks for catching that @alexjv89


Add URLRegExp.replace() method

Added a URLRegExp.replace() method, added tests for it, readme documentation.

Rember to do a npm publish


Roll engine 472197a8e932..ea1d330d83b3 (19 commits)

https://github.com/flutter/engine/compare/472197a8e932...ea1d330d83b3
git log 472197a8e932..ea1d330d83b3 --first-parent --oneline
2019-12-20<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)
2019-12-20<EMAIL_ADDRESS>Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)
2019-12-20<EMAIL_ADDRESS>Engine support for ImageFiltered widget (flutter/engine#14491)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)
2019-12-19<EMAIL_ADDRESS>Wire up OpacityLayer to Scenic (flutter/engine#14577)
2019-12-19<EMAIL_ADDRESS>Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)
2019-12-19<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)
2019-12-19<EMAIL_ADDRESS>Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)
2019-12-19<EMAIL_ADDRESS>Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)
2019-12-19<EMAIL_ADDRESS>[web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)
2019-12-19<EMAIL_ADDRESS>instructions for running firefox/safari tests (flutter/engine#14562)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)
2019-12-19<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)
2019-12-19<EMAIL_ADDRESS>Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)
2019-12-19<EMAIL_ADDRESS>Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/357555655 , https://github.com/flutter/flutter/runs/357555639

Commit queue failed; closing this roll.


Consider submission to Sci-K 2022

https://sci-k.github.io/2022/ :

2nd International Workshop on Scientific Knowledge: Representation, Discovery, and Assessment
April 25th or 26th, 2022 — Hybrid
co-located with The Web Conf 2022

Here are the specs — not much time left:

The deadline has been extended to Feb 7. That's probably not enough for our timelines.

The (extended) deadline is tomorrow, and we're not going to have anything submittable by that. Closing.


VersionInfo.isvalid() is missing (referenced in docs)

As the subject says. Documentation says semver provides a test for a valid semver string using VersionInfo.isvalid(string), but the method doesn't actually exist in VersionInfo. Version downloaded from pypi is 2.9.0, which is the same version as in the repo here. Forgotten version bump = no update on package repo?

@kenneaal I've created a virtual Python environment and install semver from PyPI. I can confirm that there is no isvalid() function, although it advertise itself as 2.9.0.
@scls19fr Chould we create a new 2.9.1 release to update the PyPI sources, please?

+1 about creating a new release that fix that
@tomschr I grant you maintainer role on https://pypi.org/manage/project/semver/collaboration/
so you are free to publish such a release and go beyond.
But please still continue to communicate about your plans about this project.

@scls19fr Thanks Sébastien! Much appreciated! :+1:
If I have some time left, I will try to make a release according to your helpful release-procedure.md file. The file misses the TestPyPI, so I think I will upload it there first. Would you have a look if I ping you? :wink:
I'll let you know for sure.

of course @tomschr, I will have a look at it.
Probably not tomorow because I will be very busy.
But I will try to find some time to see this next week.

I've opened a new issue #218 which collects all the needed information for creating a new release.

The new doc is out, so it was fixed in #219, so closing this issue.


HtmlDocument shows <link>foo</link> tag as just <link>foo

Description
If I pass a raw string that contains <link>foo</link> to htmlDocument.LoadHtml(raw),
then output htmlDocument.DocumentNode.OuterHtml, it will show up as <link>foo (without the closing tag).
And similarly, if I configure htmlDocument.OptionWriteEmptyNodes = true; , the output will be <link />foo, perhaps indicating that it think it's an empty node?
Note: my input is not strictly expected to be a web page, I know <link> might have special meaning. But I'd still like to be able to load it as a regular node.
Fiddle
https://dotnetfiddle.net/QASHg5

<link>foo</link> is not valid. The <link> element in HTML does not support any content and therefore also does not feature an end tag. (specification). And HAP - being a HTML parser - tries to parse it as a regular HTML <link> element. So, that's why you get what you see...

Looking a bit around in HAP's source code, there seems to be a way to achieve what you want. The HtmlAgilityPack.HtmlNode class maintains a static dictionary HtmlNode.ElementsFlags that assigns certain element characteristics to certain element names. For the link element name, the dictionary characterizes it to be an empty element.
HtmlNode.ElementsFlags.Remove("link");

var html = @"<root><link>foo</link><url>bar</url></root>";
var doc = new HtmlDocument();
doc.LoadHtml(html);
...

Note that due to HtmlNode.ElementsFlags being a static field, modifying or replacing its assigned dictionary will affect all parsing done by HAP in your application.

Thank you @elgonzo for your help again. Your answer is 100% correct.
Let us know if you have additional question about this @Davidsv
Best Regards,
Jon


Spelling and documentation fixes

First of all, thanks for the integration, working quite nicely :)
I've done some spelling fixes (disclaimer: I'm not a native speaker) and added the missing documentation for the third character in the formatting options.

Thank you a lot for your contribution


Transforms StorageProfile array into a set of CRs

Transforms StorageProfile array from StorageCluster's spec into a set of immutable CRs
Reconciliation of StorageProfiles is integrated in the StorageCluster's controller
Skipping StorageProfiles with an empty DeviceClass

/ok-to-test

/lgtm

I apologize for joining the conversation later; I was occupied with other matters. I kindly request that the approvers also consider the commit messages when reviewing PRs. It's essential that we refrain from approving PRs when the commit messages are not tidy and well-organized.

Hey, I did check the PR description, seems I missed commit message along the way.
@raaizik could you pls clarify the situation if possible?

@leelavg Changing a merged commit is not advisable. Let's not go there.
We will align with what ever is required in the commit message starting with the next commit

No, I'm not suggesting to change merged commit, I'm asking about what happened to the said fix in the commit msg.


Ignore webpack warning for express/lib/view.js

Why: https://github.com/webpack/webpack/issues/1576#issuecomment-418731351
Fix: https://github.com/webpack/webpack/issues/1576#issuecomment-766796672

Coverage remained the same at 99.383% when pulling 40383692f98443f327438fa09bf9193fd3c1e42f on ignore-webpack-warning into e4cec82e1e03fde21169cd28c394440237f7a96b on master.

Coverage remained the same at 99.383% when pulling 40383692f98443f327438fa09bf9193fd3c1e42f on ignore-webpack-warning into e4cec82e1e03fde21169cd28c394440237f7a96b on master.


Caused by:     missing field api_key config.toml

i create
api_key = "62------3:AAFNQuc3TA-----j8--LZTb8D--s"
allowed_users = [ list, of, telegram, ids ]
db_path = "./db.sqlite"
sd_api_url = "http://localhost:7860"

------  I edited for safety

Ensure that your config.toml is in the same directory that you're running the bot from. In your case, the path should be C:\Users\Timmek\config.toml.

Убедитесь, что вы config.tomlнаходитесь в том же каталоге, из которого вы запускаете бота. В вашем случае путь должен быть C:\Users\Timmek\config.toml.

Convinced. he is there

How did you create the file? Is it listed when you type ls config.toml?

config.toml

I don't have any more ideas; your configuration should work (actually, it should give you an error about allowed_users being invalid, but it doesn't even get that far).
In the future I may expand the CLI arguments to allow for a config file path to be provided, which may help with your issue.
If you want a potential alternative, you can try setting the arguments as env variables in powershell:
$Env:SD_TELEGRAM_API_KEY = "62------3:AAFNQuc3TA-----j8--LZTb8D--s"
$Env:SD_TELEGRAM_SD_API_URL = "http://localhost:7860/"
$Env:SD_TELEGRAM_ALLOWED_USERS = "[ list, of, telegram, ids ]"
$Env:SD_TELEGRAM_DB_PATH = "./db.sqlite"
stable-diffusion-bot


policy api PUT api does not change bpns

Description

Current behaviour

policy api PUT method does not update the field businessPartnerNumber

Expected behavior

policy api PUT method does apply businessPartnerNumber changes from request

Steps to reproduce the Bug

exampl request to PUT:
{
"validUntil": "2029-05-15T09:19:57.074412585Z",
"businessPartnerNumber": [
"BPNL1234567890CD",
// add BPN here and see if change affects data
],
"policyIds": [
"abc"
]
}
policy is not added to the added bpn when requesting getPolicies

Cannot reproduce:
{ 	"validUntil": "2025-12-12T23:59:59.999Z", 	"businessPartnerNumber": "BPNL1234567890AB", 	"payload": 		{ 			"@context": { 				"odrl": "http://www.w3.org/ns/odrl/2/" 			}, 			"@id": "test-policy", 			"policy": { 				"odrl:permission": [ 					{ 						"odrl:action": "use", 						"odrl:constraint": { 							"odrl:and": [ 								{ 									"odrl:leftOperand": "Membership", 									"odrl:operator": { 										"@id": "odrl:eq" 									}, 									"odrl:rightOperand": "active" 								}, 								{ 									"odrl:leftOperand": "PURPOSE", 									"odrl:operator": { 										"@id": "odrl:eq" 									}, 									"odrl:rightOperand": "ID 3.1 Trace" 								} 							] 						} 					} 				] 			} 		} }
Update:
{   "validUntil": "2025-12-12T23:59:59.999Z", 	"businessPartnerNumbers": [ 		"BPNL00000001CRHK", "BPNL00000001ABCD" 	], 	"policyIds": [ 		"test-policy" 	] }
get all policies:
{ 	"BPNL00000001CRHK": [ 		{ 			"validUntil": "2025-12-12T23:59:59.999Z", 			"payload": { 				"@context": { 					"odrl": "http://www.w3.org/ns/odrl/2/" 				}, 				"@id": "test-policy", 				"policy": { 					"policyId": "test-policy", 					"createdOn": "2024-06-13T10:11:35.206518778Z", 					"validUntil": "2025-12-12T23:59:59.999Z", 					"permissions": [ 						{ 							"action": "use", 							"constraint": { 								"and": [ 									{ 										"leftOperand": "Membership", 										"operator": { 											"@id": "eq" 										}, 										"odrl:rightOperand": "active" 									}, 									{ 										"leftOperand": "PURPOSE", 										"operator": { 											"@id": "eq" 										}, 										"odrl:rightOperand": "ID 3.1 Trace" 									} 								], 								"or": null 							} 						} 					] 				} 			} 		} 	], 	"BPNL00000001ABCD": [ 		{ 			"validUntil": "2025-12-12T23:59:59.999Z", 			"payload": { 				"@context": { 					"odrl": "http://www.w3.org/ns/odrl/2/" 				}, 				"@id": "test-policy", 				"policy": { 					"policyId": "test-policy", 					"createdOn": "2024-06-13T10:11:35.206518778Z", 					"validUntil": "2025-12-12T23:59:59.999Z", 					"permissions": [ 						{ 							"action": "use", 							"constraint": { 								"and": [ 									{ 										"leftOperand": "Membership", 										"operator": { 											"@id": "eq" 										}, 										"odrl:rightOperand": "active" 									}, 									{ 										"leftOperand": "PURPOSE", 										"operator": { 											"@id": "eq" 										}, 										"odrl:rightOperand": "ID 3.1 Trace" 									} 								], 								"or": null 							} 						} 					] 				} 			} 		} 	],        .... }
GET https://irs.dev.demo.catena-x.net/irs/policies?businessPartnerNumbers=BPNL00000001CRHK&businessPartnerNumbers=BPNL00000001ABCD
same result here

Hi @dsmf ,
thanks for having a look on this issue.
I have retried it on the irs dev environment and the behaviour seems to be, that when a BPN should get updated, no matter how many or which BPNs, the policy will always be assigned to the "default" BPN array. Any update to the bpn field of a policy results it to be changed to "default"

@ds-mmaul: still cannot reproduce. There is also a test https://jira.catena-x.net/browse/TRI-1953 that covers updating.
I assume that you CREATE the policy initially without a businessPartnerNumber. In this case the policy becomes the default policy.  When you create the policy you need to create it with one initial businessPartnerNumber. Otherwise it becomes the default policy. Unfortunately that is how the API was defined. I know this is inconvenient which is why we have an improvement story here: https://github.com/eclipse-tractusx/item-relationship-service/issues/561
Example:
POST /irs/policies

{
	"validUntil": "2025-12-12T23:59:59.999Z",
	"businessPartnerNumber": "BPNL1234567890CD",
	"payload":
		{
			"@context": {
				"odrl": "http://www.w3.org/ns/odrl/2/"
			},
			"@id": "the-policy-id",
			"policy": {
				...
		}
}

Afterwards you can update.

relates to #562, #577, #199

wontdo

For the sake of documentation: The error was that in the update request the attribute should be plural "businessPartnerNumbers"  and not singluar "businessPartnerNumber".


Support clearing scroll queries

This is helpful if you issue many scroll queries and the automatic
timeout does not suffice.

Hey! Thanks for being a contributor. I've been busy this week, but I hope to find some time on the weekend to get this (and other things) merged.
wrt clearing scroll requests: There is a separate service for that. But it makes sense to allow this in the Scroll service as well. So thanks for the PR.

You're welcome 😊

Am 19.09.2016 um 20:01 schrieb Andrew Gaul<EMAIL_ADDRESS>@andrewgaul commented on this pull request.
In scroll.go:

@@ -222,6 +222,30 @@ func (s *ScrollService) DoC(ctx context.Context) (*SearchResult, error) {
return s.next(ctx)
}

+func (s *ScrollService) Clear(ctx context.Context) error {

s.mu.RLock()
nextScrollId := s.scrollId
s.mu.RUnlock()
if len(nextScrollId) == 0 {

return nil

}

path := "/_search/scroll"
params := url.Values{}
body := struct {

ScrollId []string `json:"scroll_id,omitempty"`

}{

ScrollId: []string{s.scrollId},

Thanks for finding this misuse!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Some query

let's assume that there are existing files and via an update, newer files are being downloaded and overwritten. how can we ensure that the new files have the same write permissions as on the server? 2. Incase of the download fails, how can we manage this situation?

I'm check your issue, I will reply you ASAP. Thanks :)


Fix interceptor batch method FailHijackedRecvMessage for async APIs

Fix interceptor batch method FailHijackedRecvMessage for async CQ APIs. Also, added a test that fails before this PR and succeeds after.
Note - This PR also starts adding additional testing for Async CQ APIs, but that should not block  this PR itself.

C++ tests pass


Added SplunkLog Controller

Project Jira : Ref
Project Doc : NA
Feature : Added new controller to get splunk logs for Cisco
How changes are verified

Tested locally with sample app & gate service, redirection is happening.
Tested on ns=testframe, redirection is happening, correct values are picked from orca-local.yml and gate-local.yml

Highlights

baseURL, clusterName should come from .hal/default/profiles/gate-local.yml
podName will be supplied by gateURL (present in .hal/default/profiles/orca-local.yml)

Documentation Updates
Do we need to update dashboards? No
Do we need to update SOP, new hire wiki or other documents? No
Rollback, Deployment Details
Can this change be rolled back automatically without any issue? Yes
Is this a backwards-compatible change in your opinion ? Yes
Pre deployment steps : NA
Post deployment steps : Yeshawini will test this feature with different authN mechanism to be 100% sure in cisco env

PR : https://github.com/OpsMx/gate-oes/pull/43
Above PR already approved by @kirangodishala , so I am merging this PR


Added support for writing to UniformBufferDynamic descriptors. (#issue 1949)

Implements for the vulkan backend #issue 1949
PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends: vulkan
[x] rustfmt run on changed code

bors retry


Create Assignment Views

The Create Assignment view on the backend is responsible for handling the API endpoints and database operations related to the Assignment model in the EduSchola project. It provides the necessary functionality to create, retrieve, update, and delete assignment records through API requests.
Tasks:
Implement Create Assignment API:
Design and implement an API endpoint that accepts HTTP POST requests to create a new assignment.
Handle the request payload, validate the input data, and create a new Assignment object.
Save the new assignment record to the database.
Implement Retrieve Assignment API:
Design and implement an API endpoint that accepts HTTP GET requests to retrieve assignment data.
Fetch and return a list of existing assignments from the database.
Include any necessary filtering, sorting, or pagination options based on project requirements.
Implement Update Assignment API:
Design and implement an API endpoint that accepts HTTP PUT or PATCH requests to update an assignment.
Handle the request payload, validate the input data, and update the corresponding assignment record in the database.
Implement Delete Assignment API:
Design and implement an API endpoint that accepts HTTP DELETE requests to delete an assignment.
Retrieve the assignment record based on the provided ID and delete it from the database.
Write Backend Tests for Assignment APIs:
Write test cases to cover the functionality of the Create, Retrieve, Update, and Delete APIs for the Assignment model.
Test various scenarios, including success cases, error handling, and edge cases.
Ensure proper test coverage for different API endpoints and scenarios.
Remember to follow your project's coding style, guidelines, and naming conventions throughout the implementation.

issue has been resolved


When using the mod, Blocks fail to update

Here, I am attempting to use the chisel on a Grass Block, as such it does not render properly.

Please get back to me as soon as possible.

please read the FAQ on sodium
you need to remove sodium or add indium


git fsck fails

Dropwizard has a broken commit:
$ git clone https://github.com/dropwizard/dropwizard.git
Cloning into 'dropwizard'...
remote: Counting objects: 123311, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 123311 (delta 1), reused 0 (delta 0), pack-reused 123280
Receiving objects: 100% (123311/123311), 46.11 MiB | 1.71 MiB/s, done.
Resolving deltas: 100% (78597/78597), done.
$ cd dropwizard
$ git fsck
Checking object directories: 100% (256/256), done.
error in commit 6fbf9def0293986beb2547a671f46148a5d2faf7: badDate: invalid author/committer line - bad date
Checking objects: 100% (123311/123311), done.

The problem is that the commit has an uncorrect author field:
$ git show --format=raw 6fbf9def0293986beb2547a671f46148a5d2faf7
commit 6fbf9def0293986beb2547a671f46148a5d2faf7
tree a452806b01d6ebd7d28cc3c85451ae1485f07257
parent 662010f5206fbe3d5390760501a8f48ffa9602ac
parent 2b2c23d52f348a16d9644acd08339992dfeca011
author Coda Hale<EMAIL_ADDRESS><EMAIL_ADDRESS>1305038239 -0700
committer Coda Hale<EMAIL_ADDRESS><EMAIL_ADDRESS>1305038239 -0700

    Merge pull request #3 from tommorris/patch-1

    added link to example application repository from README

Expected is:
...
author Coda Hale<EMAIL_ADDRESS>1305038239 -0700
committer Coda Hale<EMAIL_ADDRESS>1305038239 -0700
...

I discovered this because I have the following sections in my .gitconfig to make sure that my checkouts are correct:
[transfer]
        fsckobjects = true
[fetch]
        fsckobjects = true
[receive]
        fsckObjects = true

See #1995.
I'm not sure how to fix that without basically changing every following commit SHA-1 and thus tags and all.
@dropwizard/committers Any suggestions?

Let me ping<EMAIL_ADDRESS>to see if they have any suggestions/remediations short of disabling fsckobjects.

Sent the following:

We're not sure if this is related to the deletion but users with fsckobjects turned on are noticing problems cloning the repo (https://github.com/dropwizard/dropwizard/issues/1996). The problem is occurring with an old commit (from 2011). It's unclear if this is a new problem or if it's simply that news of the accidental deletion is causing more people to re-engage with the project and are now cloning the repo with fsckobjects enabled when it may have previously been disabled for them.

@JensRantil, had you successfully cloned the repo in the past with fsckobjects enabled? Is it possible this is the first time you've cloned with it turned on?

had you successfully cloned the repo in the past with fsckobjects enabled?

No.

Is it possible this is the first time you've cloned with it turned on?

This is the first time I clone it, I think.

Okay, that makes me feel slightly better, then. I'm guessing it's unrelated to the repo deletion and has probably been around for a while. I guess we know what most contributors have fsckobjects set to. 😐
Having no real experience repairing git repos, I have no immediate suggestions for fixing. I'll wait a little longer to see it GH support responds with any recommendations.

GitHub support confirmed that this has been around a while:

As you suspected, this issue is popping up because some new cloners who have fsckobjects enabled are noticing it. There is a malformed commit in the history, and unless you want to rewrite the history (unlikely), the only solution is for the cloners to disable fsckObjects.
To be clear, that malformed commit was already there, it wasn't introduced when the repo was restored.
In case you're curious, there's an extra email address in the author and committer info:
$ git cat-file commit 6fbf9def0293986beb2547a671f46148a5d2faf7 | egrep '^(author|committer)'
author Coda Hale<EMAIL_ADDRESS><EMAIL_ADDRESS>1305038239 -0700
committer Coda Hale<EMAIL_ADDRESS><EMAIL_ADDRESS>1305038239 -0700
Let us know if you have any other questions.

I think rewriting history is going to be dicey at best, so I'm going to close this and we'll just have to remember to let folks know.


Mechanical Engineering: Robot Turning Specifications Unknown

[ ] Determine turning radius of robot.
[ ] Determine turning room width of robot.
[ ] Submit specifications to Structural Engineering because Issue #5 is pending.

Test Lab 1 was completed to reflect this issue. See the results in the Mechanical Engineering folder.


Errors after updating to V3 and missed detections

Hi,
After updating to v3, I see the following in the HA logs:
Unexpected error fetching swatch data:
Traceback (most recent call last):
  File "/config/custom_components/swatch/api.py", line 98, in api_wrapper
    response = await self._session.get(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 535, in _request
    conn = await self._connector.connect(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 542, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 907, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 986, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)  # type: ignore[return-value]  # noqa
  File "/usr/local/lib/python3.9/asyncio/base_events.py", line 1050, in create_connection
    sock = await self._connect_sock(
  File "/usr/local/lib/python3.9/asyncio/base_events.py", line 961, in _connect_sock
    await self.sock_connect(sock, address)
  File "/usr/local/lib/python3.9/asyncio/selector_events.py", line 499, in sock_connect
    return await fut
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/config/custom_components/swatch/api.py", line 115, in api_wrapper
    return await response.json()
  File "/usr/local/lib/python3.9/site-packages/async_timeout/__init__.py", line 129, in __aexit__
    self._do_exit(exc_type)
  File "/usr/local/lib/python3.9/site-packages/async_timeout/__init__.py", line 212, in _do_exit
    raise asyncio.TimeoutError
asyncio.exceptions.TimeoutError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 191, in _async_refresh
    self.data = await self._async_update_data()
  File "/config/custom_components/swatch/__init__.py", line 170, in _async_update_data
    raise exc
  File "/config/custom_components/swatch/__init__.py", line 168, in _async_update_data
    return await self._api.async_get_object_state("all")
  File "/config/custom_components/swatch/api.py", line 76, in async_get_object_state
    await self.api_wrapper(
  File "/config/custom_components/swatch/api.py", line 123, in api_wrapper
    raise SwatchApiClientError from exc
custom_components.swatch.api.SwatchApiClientError

Some error occurred

Also, detections are now returning result: false even though the area is within the values defined in the config. These are the same images that were being detected prior to v3 update.
Addon version: 3.0.2
Integration version: 1.1.1

Thanks I'll look into that, haven't seen any integration errors myself so may need to get the config.

Also, detections are now returning result: false even though the area is within the values defined in the config. These are the same images that were being detected prior to v3 update.

I would recommend trying to reduce the min and increase the max area size just to see. Instead of counting "all matching pixels" I now find clusters of matching pixels and calcualte a bounding box, it uses the area of this box so that area may have changed some. If that still doesn't help then I'd likely need the image and color value so I can manually test

Thanks. Lowering those values worked.

Sorry for the lack of communication on that, but I am hoping this new system will make it a lot easier to get consistent readings since stray pixels in the image that match won't add to the possibility of a false positive


Installation to Libvirt fails due to no space left in /run

Describe the bug
During the cluster bootstrap, the command release-image-download.sh running on the bootstrap node fails due to no space left on device. The tmpfs mounted on /run is full:
$ df -kh /run
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           786M  786M     0 100% /run

For some reason, the size of /run volume is only 786M. That is not enough for storing /run/mco-machine-os-content/os-content-232915737 image which has around 1.1 GiB.
Older OKD versions don't have this problem. They mount 2.0 GiB volume on /run.
$ df -kh /run
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           2.0G  948K  2.0G   1% /run

Version
Versions affected by this issue:
4.7.0-0.okd-2021-05-22-050008
4.7.0-0.okd-2021-03-28-152009
4.7.0-0.okd-2021-03-21-094146
Working versions (not affected by this issue):
4.7.0-0.okd-2021-03-07-090821
4.7.0-0.okd-2021-02-25-144700
How reproducible
Use CodeReady Containers https://github.com/code-ready/snc to deploy a cluster.
Log bundle
Related logs obtained using journalctl -b -f -u release-image.service -u bootkube.service:
...

May 14 23:57:10 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:10.077014    1845 run.go:18] Running: nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215
May 14 23:57:10 crc-hphs7-bootstrap release-image-download.sh[1845]: ionice: failed to execute oc: No such file or directory
May 14 23:57:10 crc-hphs7-bootstrap release-image-download.sh[1845]: W0514 23:57:10.080897    1845 run.go:44] nice failed: running nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35f
bbc9215 failed: ionice: failed to execute oc: No such file or directory
May 14 23:57:10 crc-hphs7-bootstrap release-image-download.sh[1845]: : exit status 127; retrying...
May 14 23:57:15 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:15.081266    1845 run.go:18] Running: nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215
May 14 23:57:15 crc-hphs7-bootstrap release-image-download.sh[1845]: ionice: failed to execute oc: No such file or directory
May 14 23:57:15 crc-hphs7-bootstrap release-image-download.sh[1845]: W0514 23:57:15.091356    1845 run.go:44] nice failed: running nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35f
bbc9215 failed: ionice: failed to execute oc: No such file or directory
May 14 23:57:15 crc-hphs7-bootstrap release-image-download.sh[1845]: : exit status 127; retrying...
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:25.091785    1845 run.go:18] Running: nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: ionice: failed to execute oc: No such file or directory
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: W0514 23:57:25.097418    1845 run.go:44] nice failed: running nice -- ionice -c 3 oc image extract --path /:/run/mco-machine-os-content/os-content-805812742 quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35f
bbc9215 failed: ionice: failed to execute oc: No such file or directory
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: : exit status 127; retrying...
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:25.097452    1845 update.go:371] Falling back to using podman cp to fetch OS image content
May 14 23:57:25 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:25.097480    1845 run.go:18] Running: nice -- ionice -c 3 podman pull -q quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215
May 14 23:57:26 crc-hphs7-bootstrap podman[1854]: 2021-05-14 23:57:26.915382754 +0000 UTC m=+1.798203633 image pull
May 14 23:57:26 crc-hphs7-bootstrap release-image-download.sh[1845]: cb79cfe99ac5709fdb0ea42fc6fb95a558b0f7969603fafd9a1a35ec7c9bca08
May 14 23:57:26 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:26.922930    1845 rpm-ostree.go:261] Running captured: podman create --net=none --annotation=org.openshift.machineconfigoperator.pivot=true --name ostree-container-pivot-383585c8-8705-41ee-845c-0e4a3d0848b1 quay.io/openshift/okd-content@sh
a256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215
May 14 23:57:27 crc-hphs7-bootstrap podman[1883]: 2021-05-14 23:57:27.018023819 +0000 UTC m=+0.082075206 container create 2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7 (image=quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215, name=ostree-container-p
ivot-383585c8-8705-41ee-845c-0e4a3d0848b1, architecture=x86_64, vcs-ref=b632cfe7be5dc185b8259395daacc82922178fb8, io.openshift.build.commit.id=b632cfe7be5dc185b8259395daacc82922178fb8, io.openshift.build.name=, com.redhat.license_terms=https://www.redhat.com/agreements, com.redhat.component=openshift-enterprise-base-co
ntainer, io.openshift.expose-services=, summary=Provides the latest release of Red Hat Universal Base Image 8., io.openshift.build.source-location=https://github.com/openshift/okd-machine-os, vcs-url=https://github.com/openshift/okd-machine-os, io.openshift.build.commit.ref=release-4.7, description=The Universal Base I
mage is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly., mai
ntainer=Red Hat, Inc., com.redhat.build-host=cpt-1004.osbs.prod.upshift.rdu2.redhat.com, io.openshift.build.commit.message=, vcs-type=git, release=202101090039.11723, io.buildah.version=1.16.4, distribution-scope=public, io.k8s.description=This is the base image from which all OpenShift images inherit., io.openshift.bu
ild.commit.author=, io.openshift.build.commit.date=, io.openshift.build.source-context-dir=, build-date=2021-01-09T00:40:49.580557, vendor=Red Hat, Inc., io.openshift.build.namespace=, io.openshift.release.operator=true, name=openshift/ose-base, io.k8s.display-name=OpenShift Base, io.openshift.tags=base rhel8, version=
v4.0, url=https://access.redhat.com/containers/#/registry.access.redhat.com/openshift/ose-base/images/v4.0-202101090039.11723)
May 14 23:57:27 crc-hphs7-bootstrap release-image-download.sh[1845]: I0514 23:57:27.023830    1845 run.go:18] Running: nice -- ionice -c 3 podman cp 2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7:/ /run/mco-machine-os-content/os-content-805812742
May 14 23:57:27 crc-hphs7-bootstrap podman[1914]: 2021-05-14 23:57:27.102788538 +0000 UTC m=+0.064707250 container mount 2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7 (image=quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215, name=ostree-container-pi
vot-383585c8-8705-41ee-845c-0e4a3d0848b1, maintainer=Red Hat, Inc., architecture=x86_64, distribution-scope=public, vcs-ref=b632cfe7be5dc185b8259395daacc82922178fb8, io.openshift.expose-services=, url=https://access.redhat.com/containers/#/registry.access.redhat.com/openshift/ose-base/images/v4.0-202101090039.11723, io
.openshift.build.source-context-dir=, io.k8s.description=This is the base image from which all OpenShift images inherit., io.openshift.release.operator=true, io.openshift.build.commit.author=, com.redhat.license_terms=https://www.redhat.com/agreements, summary=Provides the latest release of Red Hat Universal Base Image
 8., io.openshift.build.source-location=https://github.com/openshift/okd-machine-os, io.openshift.build.name=, io.openshift.tags=base rhel8, version=v4.0, name=openshift/ose-base, vcs-type=git, io.openshift.build.namespace=, io.openshift.build.commit.message=, vendor=Red Hat, Inc., io.openshift.build.commit.date=, vcs-
url=https://github.com/openshift/okd-machine-os, build-date=2021-01-09T00:40:49.580557, io.openshift.build.commit.id=b632cfe7be5dc185b8259395daacc82922178fb8, release=202101090039.11723, com.redhat.component=openshift-enterprise-base-container, com.redhat.build-host=cpt-1004.osbs.prod.upshift.rdu2.redhat.com, io.opensh
ift.build.commit.ref=release-4.7, io.buildah.version=1.16.4, io.k8s.display-name=OpenShift Base, description=The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports
 Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.)
May 14 23:57:33 crc-hphs7-bootstrap podman[1914]: 2021-05-14 23:57:33.462166326 +0000 UTC m=+6.424085055 container unmount 2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7 (image=quay.io/openshift/okd-content@sha256:1fc150fd7b47122e3ff344839cd9b2f1085024beb279f6c5eb5c3c35fbbc9215, name=ostree-container-
pivot-383585c8-8705-41ee-845c-0e4a3d0848b1, vcs-ref=b632cfe7be5dc185b8259395daacc82922178fb8, distribution-scope=public, build-date=2021-01-09T00:40:49.580557, io.openshift.build.source-context-dir=, release=202101090039.11723, vendor=Red Hat, Inc., io.k8s.display-name=OpenShift Base, io.k8s.description=This is the bas
e image from which all OpenShift images inherit., io.openshift.build.commit.date=, io.openshift.release.operator=true, io.buildah.version=1.16.4, url=https://access.redhat.com/containers/#/registry.access.redhat.com/openshift/ose-base/images/v4.0-202101090039.11723, name=openshift/ose-base, com.redhat.license_terms=htt
ps://www.redhat.com/agreements, vcs-url=https://github.com/openshift/okd-machine-os, io.openshift.build.commit.author=, io.openshift.build.source-location=https://github.com/openshift/okd-machine-os, io.openshift.tags=base rhel8, io.openshift.build.commit.message=, summary=Provides the latest release of Red Hat Univers
al Base Image 8., com.redhat.build-host=cpt-1004.osbs.prod.upshift.rdu2.redhat.com, architecture=x86_64, maintainer=Red Hat, Inc., io.openshift.build.name=, io.openshift.build.namespace=, io.openshift.expose-services=, com.redhat.component=openshift-enterprise-base-container, description=The Universal Base Image is des
igned and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly., io.openshift.b
uild.commit.id=b632cfe7be5dc185b8259395daacc82922178fb8, version=v4.0, vcs-type=git, io.openshift.build.commit.ref=release-4.7)
May 14 23:57:33 crc-hphs7-bootstrap release-image-download.sh[1845]: time="2021-05-14T23:57:33Z" level=error msg="unable to umount container '2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7': \"error unmounting container 2f4b265b94e0681657b6888afb662b292c23c2f485c3cead0a8aeb32d20bf4b7 root filesystem:
write /var/run/containers/storage/overlay-layers/.tmp-mountpoints.json052892132: no space left on device\""
May 14 23:57:33 crc-hphs7-bootstrap release-image-download.sh[1845]: Error: error copying "/var/lib/containers/storage/overlay/d7e6049e5639fe58ae646ce1a51886b1f94ff53d4a6140f14b3f46d9cb3f5c54/merged" to "/run/mco-machine-os-content/os-content-805812742": Error processing tar file(exit status 1): time="2021-05-14T23:57:
27Z" level=warning msg="ignored xattrs in archive: underlying filesystem doesn't support them" errors="[lsetxattr /extensions/okd/NetworkManager-ovs-1.26.6-1.fc33.x86_64.rpm: operation not supported]"

...

Found a simple workaround. When see the "no space left on device" log messages, execute this on the bootstrap node:
$ rm -rf mco-machine-os-content
$ ln -s /tmp /run/mco-machine-os-content

The image will be saved in /tmp where there is enough space (2 GiB).

Same issue for me on 4.7.0-0.okd-2021-04-24-103438.
I solved by execute:
$ env TF_VAR_libvirt_bootstrap_memory=8192 openshift-install create cluster
or when see the "no space left on device" log messages, execute this on the bootstrap node:
sudo mount -o remount,size=50% tmpfs /run.
It seems the bootstrap node need more memory after some new version,but the default config not modified at the same time.

Sure, we can bump default bootstrap memory in OKD installer

This is exactly what I am running into with CRC builds for OKD 4.7.
I just haven't had time to fix it yet.  Thanks for the TF_VAR_libvirt_bootstrap_memory tip @Littlemoon917.

Shall we take openshift/installer#4964 to master to consider this done?

Right, this one needs a PR to master (and a bugzilla so that it can be backported)

Fixed in 4.9 nightlies, cherry-picked the fix to 4.8/4.7. Thanks!


ioredis not accepting request when sentinel do the failover but doesn't make the last master as new slave

Hello,
I have the following config of my redis stack. One master redis and one slave connected to this master. I also create a sentinel instance to monitor the redis master.
I can connect to sentinel with ioredis and everything works fine.
My problem is when i execute the command DEBUG SLEEP  80 to cause the failover, sentinel detect that the master is down and promote the slave as master. But after that, sentinel will try to make the previous master as slave but it doesn't succeed because the master still down and we have +SDOWN log in sentinel part. During this period, ioredis will not redirect the request coming to the new master until sentinel make the master as slave. so ioredis will connect again to the new master and the requests will be treated.
What i want is if we can make the requests redirected to the new master even if the last one is not yet promoted as slave. this is the high availability that we want to have from using sentinel.
Any idea ?
Thanks in advance.

If some one can help please. I'm still stuck in this step. Thanks in advance.

Nicely described. I am also facing same.  On Power off of myster server(node), failover not happening. We can see new nominated master in sentinels.

net package doesn't trigger any event of error on that situation, that's the reason failover doesnot work. That means, current implementation of failover only works if we gracefully shutdown of redis server.

Has anyone found a manual way to failover manually?
I have noticed, the same issue.

I found the same problem.

I have the same problem. With current implementation sentinel is useless.


Variables with Margins

@bqpd I have a proposal.  Can we have Variable have a margin attribute? The idea is to have each variable have a margin built in so anywhere it is used the margin is automatically applied.

What is a margin?

It is a percentage increase on the value of a variable that accounts for uncertainty.  For example, if I  know that currently my avionics weighs 6 lbs, but I might have underestimated estimated the weight on a few things so I will add a 20% margin which would add 1.2 lbs.

I am currently doing it like this:
For a margin on BSFC
I have two variable
m_fac = Variable(...)
BSFC = Variable(...)
I have to put m_fac everywhere BSFC exists in order to capture it's sensitivity to the objective right?

Here's an idea. What if GpKit automatically created a new variable called m_factor_[variablename], and automatically divided all instances of that variable in constraints with that factor. That way you can get sensitivities to both the variable and its margin.

i just had a revelation as i was biking to class. the sensitivity to the margin would be exactly the same as the sensitivity to the margin. mike, am i wrong?

Yes, except that we want this for non-fixed variables.

That is exactly the point. By getting the sensitivity to the margin, you get the sensitivity to the variable.

Yes, that is correct.

K, glad we are on the same page :P

Ok, Woody just dropped by and explained that adding margin to every variable actually doesn't make sense.  Because by definition free variables have sensitivities of zero.  In fact we tried this we BSFC.  We added margin everywhere BSFC showed up and it actually turned out to be 0.  So for now, we will assume that adding margin in places where the free variable is pressuring down is the best way to go.

yeah, I think the type of margin being discussed in this ticket is best thought of as a margin on a model or on a constraint (as opposed to on a variable). For example, if we have uncertainty in the model for BSFC, which might have the form
BSFC >= posynomial,
then it would make sense to add a margin factor to that constraint only, causing the model to predict a higher BSFC. It does not make sense to change the constraint
m_dot_fuel*g = BSFC*P_shaft, because that's just a definition and shouldn't get margin.
This works for models for drag, weight, efficiency, etc. The key thing is that the margin gets applied to a model we are uncertain about.
One way to think about the margin factor is like the slack for a RelaxAllConstraintsEqually, just applied in reverse:
BSFC >= mfac*(posynomial)
is equivalent to
BSFC*s >= (posynomial)
where mfac = 1/s.

@bqpd, the last bit of my post above is why I've been harping on dropping the constraint s >= 1 in that relaxation formulation.

Hmm, but don't you only care about margins that make things harder? (s >= 1)

My only objection to removing that constraint for RelaxAllConstraintsEqually is that it makes it dissimilar to RelaxAllConstraints


Fix buffer handling for large WebSocket messages

The original code seems to have issues when proxying large messages. Increasing the buffer size using WithBufferSize() helps, but it also significantly increases memory usage. This PR uses a dynamic-sized buffer using a MemoyStream.
AspNetCore.Proxy.Tests running fine and also tested with large JSON messages manually.

LGTM, but would you mind adding a test with a large message?

Codecov Report

Merging #88 (6e9cf28) into master (572fc3e) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 6e9cf28 differs from pull request most recent head 5d1ef86. Consider uploading reports for the commit 5d1ef86 to get more accurate results

@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          660       669    +9
=========================================
+ Hits           660       669    +9

Impacted Files
Coverage Δ

src/Core/Extensions/Ws.cs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572fc3e...5d1ef86. Read the comment docs.

Added a test, please check and create a new release when you have some time :)