Fix pydocstyle and flake8 errors

Describe the bug
pydocstyle and flake8 raise a bunch of errors:
To Reproduce

pip install pre-commit flake8 pydocstyle
pre-commit  install
pre-commit run --al-files

Here's the error in full
(satip) jack@jack-NUC:~/dev/ocf/Satip$ pre-commit run --all-files
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
Debug Statements (Python)................................................Passed
Detect Private Key.......................................................Passed
pydocstyle...............................................................Failed
- hook id: pydocstyle
- exit code: 1

satip/utils.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:199 in public function `convert_scene_to_dataarray`:
        D103: Missing docstring in public function
satip/utils.py:256 in public function `save_dataset_to_zarr`:
        D417: Missing argument descriptions in the docstring (argument(s) channel_chunk_size, dtype are missing descriptions in 'save_dataset_to_zarr' docstring)
satip/utils.py:342 in public function `create_markdown_table`:
        D205: 1 blank line required between summary line and description (found 0)
satip/utils.py:383 in public function `set_up_logging`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:1 at module level:
        D100: Missing docstring in public module
satip/download.py:65 in public function `download_eumetsat_data`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:138 in public function `download_time_range`:
        D103: Missing docstring in public function
satip/download.py:185 in public function `sanity_check_files_and_move_to_directory`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:237 in public function `process_rss_images`:
        D103: Missing docstring in public function
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/download.py:335 in public function `eumetsat_cloud_name_to_datetime`:
        D103: Missing docstring in public function
satip/download.py:339 in public function `get_basename`:
        D103: Missing docstring in public function
satip/download.py:346 in public function `get_missing_datetimes_from_list_of_files`:
        D205: 1 blank line required between summary line and description (found 0)
satip/compression.py:1 at module level:
        D100: Missing docstring in public module
satip/compression.py:7 in public class `Compressor`:
        D101: Missing docstring in public class
satip/compression.py:8 in public method `__init__`:
        D107: Missing docstring in __init__
satip/geospatial.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:28 in public function `split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'split_per_month' docstring)
satip/intermediate.py:111 in public function `wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:126 in public function `cloudmask_split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'cloudmask_split_per_month' docstring)
satip/intermediate.py:191 in public function `cloudmask_wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:206 in public function `create_or_update_zarr_with_cloud_mask_files`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'create_or_update_zarr_with_cloud_mask_files' docstring)
satip/intermediate.py:262 in public function `create_or_update_zarr_with_native_files`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'create_or_update_zarr_with_native_files' docstring)
satip/intermediate.py:321 in public function `pool_init`:
        D103: Missing docstring in public function
satip/intermediate.py:326 in public function `native_wrapper`:
        D103: Missing docstring in public function
satip/eumetsat.py:1 at module level:
        D100: Missing docstring in public module
satip/eumetsat.py:55 in public function `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:90 in public function `query_data_products`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:90 in public function `query_data_products`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, num_features, product_id, start_date, start_index are missing descriptions in 'query_data_products' docstring)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, log, product_id, start_date are missing descriptions in 'identify_available_datasets' docstring)
satip/eumetsat.py:184 in public function `dataset_id_to_link`:
        D103: Missing docstring in public function
satip/eumetsat.py:192 in public function `json_extract`:
        D103: Missing docstring in public function
satip/eumetsat.py:202 in public function `check_valid_request`:
        D417: Missing argument descriptions in the docstring (argument(s) r are missing descriptions in 'check_valid_request' docstring)
satip/eumetsat.py:223 in public class `DownloadManager`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D417: Missing argument descriptions in the docstring (argument(s) data_dir, log_fp, logger_name, user_key, user_secret are missing descriptions in '__init__' docstring)
satip/eumetsat.py:279 in public method `request_access_token`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:279 in public method `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:303 in public method `download_single_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) data_link are missing descriptions in 'download_single_dataset' docstring)
satip/eumetsat.py:324 in public method `download_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:324 in public method `download_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, product_id, start_date are missing descriptions in 'download_date_range' docstring)
satip/eumetsat.py:339 in public method `download_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:339 in public method `download_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) datasets, product_id are missing descriptions in 'download_datasets' docstring)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, file_format, product_id, projection, roi, start_date are missing descriptions in 'download_tailored_date_range' docstring)
satip/eumetsat.py:454 in private method `_download_single_tailored_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) product_id are missing descriptions in '_download_single_tailored_dataset' docstring)
satip/eumetsat.py:543 in public function `get_dir_size`:
        D103: Missing docstring in public function
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/__init__.py:1 at module level:
        D104: Missing docstring in public package
satip/download.py:1 at module level:
        D100: Missing docstring in public module
satip/download.py:65 in public function `download_eumetsat_data`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:138 in public function `download_time_range`:
        D103: Missing docstring in public function
satip/download.py:185 in public function `sanity_check_files_and_move_to_directory`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:237 in public function `process_rss_images`:
        D103: Missing docstring in public function
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/download.py:335 in public function `eumetsat_cloud_name_to_datetime`:
        D103: Missing docstring in public function
satip/download.py:339 in public function `get_basename`:
        D103: Missing docstring in public function
satip/download.py:346 in public function `get_missing_datetimes_from_list_of_files`:
        D205: 1 blank line required between summary line and description (found 0)
scripts/move_files.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:199 in public function `convert_scene_to_dataarray`:
        D103: Missing docstring in public function
satip/utils.py:256 in public function `save_dataset_to_zarr`:
        D417: Missing argument descriptions in the docstring (argument(s) channel_chunk_size, dtype are missing descriptions in 'save_dataset_to_zarr' docstring)
satip/utils.py:342 in public function `create_markdown_table`:
        D205: 1 blank line required between summary line and description (found 0)
satip/utils.py:383 in public function `set_up_logging`:
        D205: 1 blank line required between summary line and description (found 0)
satip/__init__.py:1 at module level:
        D104: Missing docstring in public package
satip/utils.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:199 in public function `convert_scene_to_dataarray`:
        D103: Missing docstring in public function
satip/utils.py:256 in public function `save_dataset_to_zarr`:
        D417: Missing argument descriptions in the docstring (argument(s) channel_chunk_size, dtype are missing descriptions in 'save_dataset_to_zarr' docstring)
satip/utils.py:342 in public function `create_markdown_table`:
        D205: 1 blank line required between summary line and description (found 0)
satip/utils.py:383 in public function `set_up_logging`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:1 at module level:
        D100: Missing docstring in public module
satip/download.py:65 in public function `download_eumetsat_data`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:138 in public function `download_time_range`:
        D103: Missing docstring in public function
satip/download.py:185 in public function `sanity_check_files_and_move_to_directory`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:237 in public function `process_rss_images`:
        D103: Missing docstring in public function
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/download.py:335 in public function `eumetsat_cloud_name_to_datetime`:
        D103: Missing docstring in public function
satip/download.py:339 in public function `get_basename`:
        D103: Missing docstring in public function
satip/download.py:346 in public function `get_missing_datetimes_from_list_of_files`:
        D205: 1 blank line required between summary line and description (found 0)
satip/compression.py:1 at module level:
        D100: Missing docstring in public module
satip/compression.py:7 in public class `Compressor`:
        D101: Missing docstring in public class
satip/compression.py:8 in public method `__init__`:
        D107: Missing docstring in __init__
satip/geospatial.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:28 in public function `split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'split_per_month' docstring)
satip/intermediate.py:111 in public function `wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:126 in public function `cloudmask_split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'cloudmask_split_per_month' docstring)
satip/intermediate.py:191 in public function `cloudmask_wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:206 in public function `create_or_update_zarr_with_cloud_mask_files`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'create_or_update_zarr_with_cloud_mask_files' docstring)
satip/intermediate.py:262 in public function `create_or_update_zarr_with_native_files`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'create_or_update_zarr_with_native_files' docstring)
satip/intermediate.py:321 in public function `pool_init`:
        D103: Missing docstring in public function
satip/intermediate.py:326 in public function `native_wrapper`:
        D103: Missing docstring in public function
satip/eumetsat.py:1 at module level:
        D100: Missing docstring in public module
satip/eumetsat.py:55 in public function `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:90 in public function `query_data_products`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:90 in public function `query_data_products`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, num_features, product_id, start_date, start_index are missing descriptions in 'query_data_products' docstring)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, log, product_id, start_date are missing descriptions in 'identify_available_datasets' docstring)
satip/eumetsat.py:184 in public function `dataset_id_to_link`:
        D103: Missing docstring in public function
satip/eumetsat.py:192 in public function `json_extract`:
        D103: Missing docstring in public function
satip/eumetsat.py:202 in public function `check_valid_request`:
        D417: Missing argument descriptions in the docstring (argument(s) r are missing descriptions in 'check_valid_request' docstring)
satip/eumetsat.py:223 in public class `DownloadManager`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D417: Missing argument descriptions in the docstring (argument(s) data_dir, log_fp, logger_name, user_key, user_secret are missing descriptions in '__init__' docstring)
satip/eumetsat.py:279 in public method `request_access_token`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:279 in public method `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:303 in public method `download_single_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) data_link are missing descriptions in 'download_single_dataset' docstring)
satip/eumetsat.py:324 in public method `download_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:324 in public method `download_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, product_id, start_date are missing descriptions in 'download_date_range' docstring)
satip/eumetsat.py:339 in public method `download_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:339 in public method `download_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) datasets, product_id are missing descriptions in 'download_datasets' docstring)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, file_format, product_id, projection, roi, start_date are missing descriptions in 'download_tailored_date_range' docstring)
satip/eumetsat.py:454 in private method `_download_single_tailored_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) product_id are missing descriptions in '_download_single_tailored_dataset' docstring)
satip/eumetsat.py:543 in public function `get_dir_size`:
        D103: Missing docstring in public function
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/__init__.py:1 at module level:
        D104: Missing docstring in public package
scripts/convert_cloudmask_to_zarr.py:1 at module level:
        D100: Missing docstring in public module
scripts/convert_cloudmask_to_zarr.py:30 in public function `create_eumetsat_zarr`:
        D103: Missing docstring in public function
satip/compression.py:1 at module level:
        D100: Missing docstring in public module
satip/compression.py:7 in public class `Compressor`:
        D101: Missing docstring in public class
satip/compression.py:8 in public method `__init__`:
        D107: Missing docstring in __init__
satip/geospatial.py:1 at module level:
        D100: Missing docstring in public module
scripts/get_raw_eumetsat_data.py:1 at module level:
        D100: Missing docstring in public module
scripts/get_raw_eumetsat_data.py:23 in public function `validate_date`:
        D103: Missing docstring in public function
scripts/get_raw_eumetsat_data.py:96 in public function `download_sat_files`:
        D103: Missing docstring in public function
satip/utils.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:199 in public function `convert_scene_to_dataarray`:
        D103: Missing docstring in public function
satip/utils.py:256 in public function `save_dataset_to_zarr`:
        D417: Missing argument descriptions in the docstring (argument(s) channel_chunk_size, dtype are missing descriptions in 'save_dataset_to_zarr' docstring)
satip/utils.py:342 in public function `create_markdown_table`:
        D205: 1 blank line required between summary line and description (found 0)
satip/utils.py:383 in public function `set_up_logging`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:1 at module level:
        D100: Missing docstring in public module
satip/download.py:65 in public function `download_eumetsat_data`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:138 in public function `download_time_range`:
        D103: Missing docstring in public function
satip/download.py:185 in public function `sanity_check_files_and_move_to_directory`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:237 in public function `process_rss_images`:
        D103: Missing docstring in public function
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/download.py:335 in public function `eumetsat_cloud_name_to_datetime`:
        D103: Missing docstring in public function
satip/download.py:339 in public function `get_basename`:
        D103: Missing docstring in public function
satip/download.py:346 in public function `get_missing_datetimes_from_list_of_files`:
        D205: 1 blank line required between summary line and description (found 0)
satip/compression.py:1 at module level:
        D100: Missing docstring in public module
satip/compression.py:7 in public class `Compressor`:
        D101: Missing docstring in public class
satip/compression.py:8 in public method `__init__`:
        D107: Missing docstring in __init__
satip/geospatial.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:28 in public function `split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'split_per_month' docstring)
satip/intermediate.py:111 in public function `wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:126 in public function `cloudmask_split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'cloudmask_split_per_month' docstring)
satip/intermediate.py:191 in public function `cloudmask_wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:206 in public function `create_or_update_zarr_with_cloud_mask_files`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'create_or_update_zarr_with_cloud_mask_files' docstring)
satip/intermediate.py:262 in public function `create_or_update_zarr_with_native_files`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'create_or_update_zarr_with_native_files' docstring)
satip/intermediate.py:321 in public function `pool_init`:
        D103: Missing docstring in public function
satip/intermediate.py:326 in public function `native_wrapper`:
        D103: Missing docstring in public function
satip/eumetsat.py:1 at module level:
        D100: Missing docstring in public module
satip/eumetsat.py:55 in public function `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:90 in public function `query_data_products`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:90 in public function `query_data_products`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, num_features, product_id, start_date, start_index are missing descriptions in 'query_data_products' docstring)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, log, product_id, start_date are missing descriptions in 'identify_available_datasets' docstring)
satip/eumetsat.py:184 in public function `dataset_id_to_link`:
        D103: Missing docstring in public function
satip/eumetsat.py:192 in public function `json_extract`:
        D103: Missing docstring in public function
satip/eumetsat.py:202 in public function `check_valid_request`:
        D417: Missing argument descriptions in the docstring (argument(s) r are missing descriptions in 'check_valid_request' docstring)
satip/eumetsat.py:223 in public class `DownloadManager`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D417: Missing argument descriptions in the docstring (argument(s) data_dir, log_fp, logger_name, user_key, user_secret are missing descriptions in '__init__' docstring)
satip/eumetsat.py:279 in public method `request_access_token`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:279 in public method `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:303 in public method `download_single_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) data_link are missing descriptions in 'download_single_dataset' docstring)
satip/eumetsat.py:324 in public method `download_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:324 in public method `download_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, product_id, start_date are missing descriptions in 'download_date_range' docstring)
satip/eumetsat.py:339 in public method `download_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:339 in public method `download_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) datasets, product_id are missing descriptions in 'download_datasets' docstring)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, file_format, product_id, projection, roi, start_date are missing descriptions in 'download_tailored_date_range' docstring)
satip/eumetsat.py:454 in private method `_download_single_tailored_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) product_id are missing descriptions in '_download_single_tailored_dataset' docstring)
satip/eumetsat.py:543 in public function `get_dir_size`:
        D103: Missing docstring in public function
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/__init__.py:1 at module level:
        D104: Missing docstring in public package
setup.py:1 at module level:
        D100: Missing docstring in public module
scripts/generate_test_plots.py:1 at module level:
        D205: 1 blank line required between summary line and description (found 0)
scripts/generate_test_plots.py:32 in public function `plot_tailored`:
        D103: Missing docstring in public function
scripts/generate_test_plots.py:73 in public function `plot_dataset`:
        D103: Missing docstring in public function
satip/intermediate.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:28 in public function `split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'split_per_month' docstring)
satip/intermediate.py:111 in public function `wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:126 in public function `cloudmask_split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'cloudmask_split_per_month' docstring)
satip/intermediate.py:191 in public function `cloudmask_wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:206 in public function `create_or_update_zarr_with_cloud_mask_files`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'create_or_update_zarr_with_cloud_mask_files' docstring)
satip/intermediate.py:262 in public function `create_or_update_zarr_with_native_files`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'create_or_update_zarr_with_native_files' docstring)
satip/intermediate.py:321 in public function `pool_init`:
        D103: Missing docstring in public function
satip/intermediate.py:326 in public function `native_wrapper`:
        D103: Missing docstring in public function
satip/eumetsat.py:1 at module level:
        D100: Missing docstring in public module
satip/eumetsat.py:55 in public function `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:90 in public function `query_data_products`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:90 in public function `query_data_products`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, num_features, product_id, start_date, start_index are missing descriptions in 'query_data_products' docstring)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, log, product_id, start_date are missing descriptions in 'identify_available_datasets' docstring)
satip/eumetsat.py:184 in public function `dataset_id_to_link`:
        D103: Missing docstring in public function
satip/eumetsat.py:192 in public function `json_extract`:
        D103: Missing docstring in public function
satip/eumetsat.py:202 in public function `check_valid_request`:
        D417: Missing argument descriptions in the docstring (argument(s) r are missing descriptions in 'check_valid_request' docstring)
satip/eumetsat.py:223 in public class `DownloadManager`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D417: Missing argument descriptions in the docstring (argument(s) data_dir, log_fp, logger_name, user_key, user_secret are missing descriptions in '__init__' docstring)
satip/eumetsat.py:279 in public method `request_access_token`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:279 in public method `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:303 in public method `download_single_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) data_link are missing descriptions in 'download_single_dataset' docstring)
satip/eumetsat.py:324 in public method `download_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:324 in public method `download_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, product_id, start_date are missing descriptions in 'download_date_range' docstring)
satip/eumetsat.py:339 in public method `download_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:339 in public method `download_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) datasets, product_id are missing descriptions in 'download_datasets' docstring)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, file_format, product_id, projection, roi, start_date are missing descriptions in 'download_tailored_date_range' docstring)
satip/eumetsat.py:454 in private method `_download_single_tailored_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) product_id are missing descriptions in '_download_single_tailored_dataset' docstring)
satip/eumetsat.py:543 in public function `get_dir_size`:
        D103: Missing docstring in public function
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/utils.py:1 at module level:
        D100: Missing docstring in public module
satip/utils.py:199 in public function `convert_scene_to_dataarray`:
        D103: Missing docstring in public function
satip/utils.py:256 in public function `save_dataset_to_zarr`:
        D417: Missing argument descriptions in the docstring (argument(s) channel_chunk_size, dtype are missing descriptions in 'save_dataset_to_zarr' docstring)
satip/utils.py:342 in public function `create_markdown_table`:
        D205: 1 blank line required between summary line and description (found 0)
satip/utils.py:383 in public function `set_up_logging`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:1 at module level:
        D100: Missing docstring in public module
satip/download.py:65 in public function `download_eumetsat_data`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:138 in public function `download_time_range`:
        D103: Missing docstring in public function
satip/download.py:185 in public function `sanity_check_files_and_move_to_directory`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:237 in public function `process_rss_images`:
        D103: Missing docstring in public function
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/download.py:330 in public function `eumetsat_native_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/download.py:335 in public function `eumetsat_cloud_name_to_datetime`:
        D103: Missing docstring in public function
satip/download.py:339 in public function `get_basename`:
        D103: Missing docstring in public function
satip/download.py:346 in public function `get_missing_datetimes_from_list_of_files`:
        D205: 1 blank line required between summary line and description (found 0)
satip/compression.py:1 at module level:
        D100: Missing docstring in public module
satip/compression.py:7 in public class `Compressor`:
        D101: Missing docstring in public class
satip/compression.py:8 in public method `__init__`:
        D107: Missing docstring in __init__
satip/geospatial.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:1 at module level:
        D100: Missing docstring in public module
satip/intermediate.py:28 in public function `split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'split_per_month' docstring)
satip/intermediate.py:111 in public function `wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:126 in public function `cloudmask_split_per_month`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'cloudmask_split_per_month' docstring)
satip/intermediate.py:191 in public function `cloudmask_wrapper`:
        D103: Missing docstring in public function
satip/intermediate.py:206 in public function `create_or_update_zarr_with_cloud_mask_files`:
        D417: Missing argument descriptions in the docstring (argument(s) temp_directory are missing descriptions in 'create_or_update_zarr_with_cloud_mask_files' docstring)
satip/intermediate.py:262 in public function `create_or_update_zarr_with_native_files`:
        D417: Missing argument descriptions in the docstring (argument(s) hrv_zarr_path, temp_directory are missing descriptions in 'create_or_update_zarr_with_native_files' docstring)
satip/intermediate.py:321 in public function `pool_init`:
        D103: Missing docstring in public function
satip/intermediate.py:326 in public function `native_wrapper`:
        D103: Missing docstring in public function
satip/eumetsat.py:1 at module level:
        D100: Missing docstring in public module
satip/eumetsat.py:55 in public function `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:90 in public function `query_data_products`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:90 in public function `query_data_products`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, num_features, product_id, start_date, start_index are missing descriptions in 'query_data_products' docstring)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:131 in public function `identify_available_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, log, product_id, start_date are missing descriptions in 'identify_available_datasets' docstring)
satip/eumetsat.py:184 in public function `dataset_id_to_link`:
        D103: Missing docstring in public function
satip/eumetsat.py:192 in public function `json_extract`:
        D103: Missing docstring in public function
satip/eumetsat.py:202 in public function `check_valid_request`:
        D417: Missing argument descriptions in the docstring (argument(s) r are missing descriptions in 'check_valid_request' docstring)
satip/eumetsat.py:223 in public class `DownloadManager`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:237 in public method `__init__`:
        D417: Missing argument descriptions in the docstring (argument(s) data_dir, log_fp, logger_name, user_key, user_secret are missing descriptions in '__init__' docstring)
satip/eumetsat.py:279 in public method `request_access_token`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:279 in public method `request_access_token`:
        D417: Missing argument descriptions in the docstring (argument(s) user_key, user_secret are missing descriptions in 'request_access_token' docstring)
satip/eumetsat.py:303 in public method `download_single_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) data_link are missing descriptions in 'download_single_dataset' docstring)
satip/eumetsat.py:324 in public method `download_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:324 in public method `download_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, product_id, start_date are missing descriptions in 'download_date_range' docstring)
satip/eumetsat.py:339 in public method `download_datasets`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:339 in public method `download_datasets`:
        D417: Missing argument descriptions in the docstring (argument(s) datasets, product_id are missing descriptions in 'download_datasets' docstring)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:380 in public method `download_tailored_date_range`:
        D417: Missing argument descriptions in the docstring (argument(s) end_date, file_format, product_id, projection, roi, start_date are missing descriptions in 'download_tailored_date_range' docstring)
satip/eumetsat.py:454 in private method `_download_single_tailored_dataset`:
        D417: Missing argument descriptions in the docstring (argument(s) product_id are missing descriptions in '_download_single_tailored_dataset' docstring)
satip/eumetsat.py:543 in public function `get_dir_size`:
        D103: Missing docstring in public function
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D205: 1 blank line required between summary line and description (found 0)
satip/eumetsat.py:563 in public function `eumetsat_filename_to_datetime`:
        D209: Multi-line docstring closing quotes should be on a separate line
satip/__init__.py:1 at module level:
        D104: Missing docstring in public package
tests/test_eumetsat.py:1 at module level:
        D100: Missing docstring in public module
tests/test_eumetsat.py:4 in public function `test_filename_to_datetime`:
        D103: Missing docstring in public function
tests/test_eumetsat.py:8 in public function `test_data_tailor`:
        D103: Missing docstring in public function
scripts/cloudmask.py:1 at module level:
        D100: Missing docstring in public module
scripts/convert_native_to_zarr.py:1 at module level:
        D100: Missing docstring in public module
scripts/convert_native_to_zarr.py:36 in public function `create_eumetsat_zarr`:
        D103: Missing docstring in public function

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

satip/utils.py:7:1: F401 'typing.Union' imported but unused
satip/utils.py:13:1: F401 'zarr' imported but unused
satip/utils.py:26:101: E501 line too long (221 > 100 characters)
satip/utils.py:153:101: E501 line too long (104 > 100 characters)
satip/utils.py:186:101: E501 line too long (104 > 100 characters)
satip/utils.py:419:101: E501 line too long (115 > 100 characters)
satip/utils.py:420:101: E501 line too long (118 > 100 characters)
satip/download.py:50:1: E731 do not assign a lambda expression, use a def
satip/download.py:73:101: E501 line too long (114 > 100 characters)
satip/download.py:225:101: E501 line too long (125 > 100 characters)
satip/download.py:245:101: E501 line too long (108 > 100 characters)
satip/download.py:249:9: E722 do not use bare 'except'
satip/download.py:267:9: E722 do not use bare 'except'
satip/download.py:271:101: E501 line too long (121 > 100 characters)
satip/download.py:276:9: E722 do not use bare 'except'
satip/download.py:319:101: E501 line too long (104 > 100 characters)
satip/download.py:361:101: E501 line too long (103 > 100 characters)
satip/download.py:374:101: E501 line too long (113 > 100 characters)
satip/geospatial.py:1:1: F401 'datetime' imported but unused
satip/eumetsat.py:10:1: F401 'typing.List' imported but unused
satip/eumetsat.py:14:1: F401 'requests.auth.HTTPBasicAuth' imported but unused
satip/eumetsat.py:80:1: E731 do not assign a lambda expression, use a def
satip/eumetsat.py:186:101: E501 line too long (136 > 100 characters)
satip/eumetsat.py:213:13: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
satip/eumetsat.py:258:26: F541 f-string is missing placeholders
satip/eumetsat.py:363:13: E722 do not use bare 'except'
satip/eumetsat.py:435:13: E722 do not use bare 'except'
satip/eumetsat.py:566:51: W605 invalid escape sequence '\d'
satip/eumetsat.py:566:55: W605 invalid escape sequence '\.'
satip/eumetsat.py:573:101: E501 line too long (112 > 100 characters)
satip/download.py:50:1: E731 do not assign a lambda expression, use a def
satip/download.py:73:101: E501 line too long (114 > 100 characters)
satip/download.py:225:101: E501 line too long (125 > 100 characters)
satip/download.py:245:101: E501 line too long (108 > 100 characters)
satip/download.py:249:9: E722 do not use bare 'except'
satip/download.py:267:9: E722 do not use bare 'except'
satip/download.py:271:101: E501 line too long (121 > 100 characters)
satip/download.py:276:9: E722 do not use bare 'except'
satip/download.py:319:101: E501 line too long (104 > 100 characters)
satip/download.py:361:101: E501 line too long (103 > 100 characters)
satip/download.py:374:101: E501 line too long (113 > 100 characters)
scripts/move_files.py:2:1: F401 'shutil' imported but unused
scripts/move_files.py:6:101: E501 line too long (137 > 100 characters)
scripts/move_files.py:10:14: F821 undefined name 'xr'
scripts/move_files.py:10:27: F821 undefined name 'xr'
scripts/move_files.py:12:31: F821 undefined name 'osgb_x'
scripts/move_files.py:14:39: F821 undefined name 'osgb_x'
scripts/move_files.py:14:49: F821 undefined name 'osgb_y'
scripts/move_files.py:18:9: F821 undefined name 'Scene'
scripts/move_files.py:18:48: F821 undefined name 'filename'
scripts/move_files.py:25:28: F821 undefined name 'GEOGRAPHIC_BOUNDS'
scripts/move_files.py:28:18: F821 undefined name 'lat_lon_to_osgb'
scripts/move_files.py:33:101: E501 line too long (141 > 100 characters)
scripts/move_files.py:37:14: F821 undefined name 'xr'
scripts/move_files.py:37:27: F821 undefined name 'xr'
satip/utils.py:7:1: F401 'typing.Union' imported but unused
satip/utils.py:13:1: F401 'zarr' imported but unused
satip/utils.py:26:101: E501 line too long (221 > 100 characters)
satip/utils.py:153:101: E501 line too long (104 > 100 characters)
satip/utils.py:186:101: E501 line too long (104 > 100 characters)
satip/utils.py:419:101: E501 line too long (115 > 100 characters)
satip/utils.py:420:101: E501 line too long (118 > 100 characters)
satip/geospatial.py:1:1: F401 'datetime' imported but unused
scripts/get_raw_eumetsat_data.py:20:1: E731 do not assign a lambda expression, use a def
scripts/get_raw_eumetsat_data.py:35:101: E501 line too long (105 > 100 characters)
scripts/get_raw_eumetsat_data.py:55:101: E501 line too long (106 > 100 characters)
scripts/get_raw_eumetsat_data.py:62:101: E501 line too long (104 > 100 characters)
scripts/get_raw_eumetsat_data.py:68:101: E501 line too long (110 > 100 characters)
setup.py:14:101: E501 line too long (103 > 100 characters)
satip/eumetsat.py:10:1: F401 'typing.List' imported but unused
satip/eumetsat.py:14:1: F401 'requests.auth.HTTPBasicAuth' imported but unused
satip/eumetsat.py:80:1: E731 do not assign a lambda expression, use a def
satip/eumetsat.py:186:101: E501 line too long (136 > 100 characters)
satip/eumetsat.py:213:13: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
satip/eumetsat.py:258:26: F541 f-string is missing placeholders
satip/eumetsat.py:363:13: E722 do not use bare 'except'
satip/eumetsat.py:435:13: E722 do not use bare 'except'
satip/eumetsat.py:566:51: W605 invalid escape sequence '\d'
satip/eumetsat.py:566:55: W605 invalid escape sequence '\.'
satip/eumetsat.py:573:101: E501 line too long (112 > 100 characters)
tests/test_eumetsat.py:1:1: F401 'satip.eumetsat' imported but unused
scripts/cloudmask.py:1:1: F401 'satpy' imported but unused
scripts/convert_native_to_zarr.py:3:1: F401 'satip.intermediate.create_or_update_zarr_with_native_files' imported but unused

isort....................................................................Passed
black....................................................................Passed
prettier.................................................................Passed

If you run blacks on it, maybe half of these will be sort fix

Hi all! As this seems a good starting point to get familiar with the code and what it does, I would take a look at that.
Seems rather straightforward in most cases, as decent documentation already exists in the function docstrings.
(I will sure miss a lot of the finer points, but that is what the MR is for. ;) )

Yeah, sounds good! I can explain anything if you need help, thanks for taking it on!

Happy to, and thanks for the offer.
One question pops up: Who do I bug to get push rights for a branch I opened up (locally) for this issue?

That would be me! I'll try fixing that shortly

I'm not actually sure how to get that going, possibly you could fork Satip and push to that, then open a PR with the fork?

Sounds a bit hacky/cumbersome. From my past experience (and please excuse me if that I repeat things you are super-familiar with) someone with admin-rights/owner-rights can invite someone (me ;) ) to contribute to the repo and by this invitation give limited write rights.

There we go! You should have an invite now and be able to push

Awesome, works, thanks!

Yeah, feel free to remove cloudmask.py, as well as the move_files.py, the move_files was used in a one off and I forgot to remove it. Great job being nearly done with it!

Awesome, thanks for the answer, will do!
It indeed was a good entry-ticket.

@notger finished this in #68


Include license file in the generated wheel package

The wheel package format supports including the license file. This is done using the [metadata] section in the setup.cfg file. For additional information on this feature, see:
https://wheel.readthedocs.io/en/stable/index.html#including-the-license-in-the-generated-wheel-file
Helps project comply with its own license:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Pull Request Test Coverage Report for Build 690

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 96.074%

Files with Coverage Reduction
New Missed Lines
%

tests/test_black.py
1
97.77%

Totals

Change from base Build 689:
-0.04%

Covered Lines:
2716

Relevant Lines:
2827

💛  - Coveralls


style(Input): make end adornment always on end of the input

FX-3118
Description
The end adornment had only 1px height, so when it didn't fit on a single line and moved to the next line, it didn't look good. Also, adornment had flex-grow set to 1, so when there was no input, adornment took half of the space of input, so the placeholder was not seen. But without the flex-grow set to 1, the adornment was not positioned correctly on the next line to the right edge, so I needed to use a classic margin: 'auto' fix.
How to test

Even though the bug was only in TagSelector, the change was done in general InputAdornment, so it might affect all inputs, but hopefully visual tests should catch any regression

Screenshots

Before.
After.

Development checks

[ ] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[ ] Self reviewed
[x] Covered with tests

Breaking change

n/a codemod is created and showcased in the changeset
n/a test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

it seems to me that ✔ and options should be on the same line 🤔
@LashaJini yeah, it looks like that, but it is not.  Few months back there was a bug that minWidth of the input needs to be 3rem. In tag selector the input is only the available space between tags and end of input. So in this case there is just not enough space for the end adornment.

@toptal-anvil ping reviewers


Worlds Not Deleting

So I am having an issue with worlds not deleteing they are PlotSquared worlds I delete them out of the worlds.yml, and then save that and go back and delete them from the FTP directory (Whole world file) then restart my server. They keep regenerating back, not sure what to dod as this has been an issue for awhile
Thanks,
CosmicPyrex,
PrisonBreach CEO

Have you tried doing /mv delete [world]

Yes

Yes

Oops I didn't mean to close this

You need to use /mv remove  to remove it from the worlds.yml file.

Says 'error trying to remove world from config!'

What's the error in console when you do that?

02.04 14:58:51 [Server] WARN Hmm Multiverse does not know about this world but it's loaded in memory.
02.04 14:58:51 [Server] WARN To let Multiverse know about it, use:
02.04 14:58:51 [Server] WARN /mv import prison_spawn NORMAL

The /mv import prison_spawn NORMAL and then do /mv delete prison_spawn.

http://imgur.com/a/ezbhX
Nope.

Anyone? Still a huge problem for me..

If you back up your worlds.yml file and start again; trying to do this again what happens? What version of Multiverse-Core are you using?

The general strategy is this:
mv delete <worldname>
If that doesn't work, shut down the server and remove the world directory manually.
The reason why the command fails to work is because some other plugin is causing the server to keep an open file handle on the world. The only real solution is to stop the server and manually delete.


RHIROS-701 | Add latest RHEL releases for filtering

Changes:

Updated OS_VERSIONS with RHEL 8.6, 9.0

Additional:

NA

/retest

We need to add the versions in openapi file as well - openapi.json#L828

Thanks @r14chandra!

Hello,
As we have tested on RHEL8.6 and RHEL 9.0, we can move forward with that

@saltgen  - I would like to know what else is pending for this pull-request or can we go ahead with merge?
Only thing I noticed that 9.1 is available link so do you think we can include this option as well?

@saltgen - I would like to know what else is pending for this pull-request or can we go ahead with merge? Only thing I noticed that 9.1 is available link so do you think we can include this option as well?

@kgaikwad I have left a question for @ShivamPandya regarding the same on Slack, I will share the link for the same with you.

/retest

/retest


The performance and limitation of distrinet

Test the performance of distrinet on a server, focusing on how many vHosts and vSwitches can be created on  a single server.
Exploring what the main performance bottlenecks are.

On a single server Mininet, up to 324 vHosts and 5832 vSwitches can be created on the basis of the established Tree topology.
When starting a topological network of 8000 hosts, the detection found that the physical memory of the server reached the upper limit.

@jiawei96-liu or @SevenWang009 Please add any performance or limitation you have test for Distrinet in your physical environment (or VMs) here if you have any. For instance, how many hosts or switches containers can be created in distrinet, how many host containers can be connected to a switch containers, and how many switch containers can be controlled by a controller, etc.

The following problem was encountered when starting the deployment success test:

After several rounds of troubleshooting, no problem has been found in the previous deployment process

After preliminary analysis of the code,I located the problem here(in /Distrinet/mininet/mininet/distrinet.py  init in class Distrinet):

The attempts to establish SSH connection or other remote connection (such as telnet) for <IP_ADDRESS> failed,

@SevenWang009 There are two possibilities:

the containers are not correctly created and cannot ping to management network.
the RYU controller is not running.
You can check if two containers in the same host are connected and ping-able.
-> If they cannot ping each other, that's mean the LXC containers are not created correctly.
-> If they can ping each other, then check if RYU controller is correctly running and control the switch container correctly.

In the current tests, the maximum number of nodes running successfully and pingall without packet loss is 82（41vhost+41vswitch）, which is close to the order of 100,

We speculate these performances are related to the limit of LXD containers that the system can run at the same time

@cj-chung
i'm sorry that the latest progress wasn't updated on time. there's sth wrong when making pr ,i missed the "create pull request" button.

@SevenWang009 Does your test with 82 containers（41vhost+41vswitch）within one physical node or multiple nodes?
If possible, please also use iperf/iperf3 to get the throughput between two vhosts.

We have tested the bandwidth of iperf in the custom topology test. The detailed test results can be seen in the latest Pr.

we could started 82 containers in one physical node.

1


Introduce basic authentification for backend providers

For the moment we work with a single authentification key for the storages. This is not really nice if we would like to allow several backend providers to work with the same storage provider.

The work on #200 might allow us to introduce a first solution to this. While the private key will not provide for good ways to introduce authorization on the backend it already allows us for authentification. So a possible approach might be:

I have private key. I use it to sign whatever I upload to the StorageProvider.
If I try to update it the StorageProvider tasks me with a challenge to see if I actually hold the private key.

We should extend on the work of #220 and systematically enforce updates etc with private keys...


Add example of graceful shutdown.

@lukaspour - I have added an example of how you can use the graceful shutdown module without baking it in to the ECS module itself. Could you give it a whirl and see if it fits your needs?

Changed it to use the aws_ami data source instead, makes sure we are always using the latest AMI and also makes it easier to see what AMI is being used.


Android - redesigning presets activity to dialog

Tracked by: DSO-15649 and DSO-15651
before:

after:

Is preset available for LIDAR: L515.
I can't see any preset options on the setting screen.


Updates Objective-C Generation to allow for ommission of the generated @interface and @implementation

Purpose: Allow user to define a preprocessor symbol to limit compilation of the @protocol only.
Used in testing scenarios with fakes and where transitive transport dependencies are unacceptable (including stemming from the @interface/@implementation).

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @nallohki isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot


Add autogenerated dos JSON schemas

Adds JSON schemas for Digital Outcomes and Specialists lots generated by the frameworks script from frameworks content files.
This is the initial import: schemas don't contain pricing and multiquestion validations and some enums are going to change in the future.

Tested locally and looks good :+1:


Element with style "display:none" should have IsHidden as true

Hi,
I am not sure it is a bug or I missed some thing but when an html element has style value of "display:none" the IsHidden property should be true which is not in the current version.

There is no relation between these two.
<!DOCTYPE html>
<body style="display:none">
</body>
<script>
console.log(document.querySelector('body').hidden);
</script>

This one will log false.

Thanks for the explanation.


Add git tags for crates.io releases

Hello, the latest git tag in the repo is for 0.1.26. It would be nice to have tags that correspond to the crates.io releases to make it easier to compare the changes in each version. Thanks!

While it's nice to tag each release, there is no guarantee that git tags on GitHub and released tarballs on crates.ui have the same source. To me I usually use http://diff.rs to compare diff between versions.

there is no guarantee that git tags on GitHub and released tarballs on crates.ui have the same source.

Good point, although I'm not really arguing from a point of trust here. For me specifically, it's more about convenience (using the github web UI to diff the release tags). That said, thanks for the recommendation! That site looks really useful

Did my best recovering git tags. Those commit shas don't really match what were recorded in .cargo_vcs_info.json on crates.io, but sources should be identical I believe.

Going to close this as resolved. Let me know if you have any further question :)


WorldUtils - Best Practices Switch Statements

Code Location:
https://github.com/CivMC/CivModCore/blob/00243ad09361361b46e808e3379eb739251a4365/paper/src/main/java/vg/civcraft/mc/civmodcore/world/WorldUtils.java#L33

Issue:
Switch statements have no fall through prevention. This may lead to hard to debug bugs.

Solution:
Add default case with throws.

While I do agree that those switches would be better off as switch-expressions and moving the precondition check to the default branch, there's no fallthrough bugs here. Having the default case there is merely to satisfy the compiler since it cannot see the connection between the switch and the Preconditions.checkArgument(PLANAR_SIDES.contains(face)); The only way I can see bugs being introduced is if someone used unsafe, JDK internals-tier reflection to change PLANAR_SIDES somehow.


When displaying English version, the file upload button is still in Japanese.

Normally, it depends on the browser's locale setting. But i18next might be able to fix it.

English OS with display English. Therefore, no rush to modify this before demo.


Closing setting-tabs

Hi,
For the microbit block editor there are multiple "cog-wheel" settings that open a new window.
Intuitively I always want to close these windows by clicking outside of the settings window, but this doesn't work and keeps causing some level of frustration.
It is probably a minor thing to fix =)
Thank you!

I can't repro this. Can you please share a screenshot?

What I mean is that I would like to be able to close this window by pressing anywhere outside of the window, rather than having to exactly press the small cogwheel again.

@Carlborg Thanks! Got it.
Though this is blockly feature (or bug, depends on how one sees it). Blockly is the open source framework we use from our end. Can't fix from our end.

We should fix it. This is really annoying.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhijith Chatra<EMAIL_ADDRESS>Sent: Friday, March 3, 2017 10:42:30 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Comment
Subject: Re: [Microsoft/pxt] Closing setting-tabs (#1498)
@Carlborghttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCarlborg&data=02|01|jhalleux%40microsoft.com|e0d83faa2a1a4faf6fd908d462650d93|72f988bf86f141af91ab2d7cd011db47|1|0|636241633534773210&sdata=4EOIyjT1dA6uL86YhNiFbN90gUB4uyVmhAq3WCytn64%3D&reserved=0 Thanks! Got it.
Though this is blockly feature (or bug, depends on how one sees it). Blockly is the open source framework we use from our end. Can't fix from our end.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F1498%23issuecomment-284035704&data=02|01|jhalleux%40microsoft.com|e0d83faa2a1a4faf6fd908d462650d93|72f988bf86f141af91ab2d7cd011db47|1|0|636241633534773210&sdata=fd970%2BQrom56AmFYAsJsLaq2TGnCfUcFDHUawpGMlGE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KSrUdB6cNcKG3T08RLWhBb1FBOs1ks5riF8WgaJpZM4MRCoK&data=02|01|jhalleux%40microsoft.com|e0d83faa2a1a4faf6fd908d462650d93|72f988bf86f141af91ab2d7cd011db47|1|0|636241633534773210&sdata=HAASzXjXC028hHPyQDd2vp2viPxzhtMws0Oxr%2BYtVJ4%3D&reserved=0.

Assigned to you @pelikhan

Yup I've been bugged by that one too.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhijith Chatra<EMAIL_ADDRESS>Sent: Friday, March 3, 2017 10:56:11 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Mention
Subject: Re: [Microsoft/pxt] Closing setting-tabs (#1498)
Assigned to you @pelikhanhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpelikhan&data=02|01|jhalleux%40microsoft.com|5804c2fb36a4469767e208d46266f61f|72f988bf86f141af91ab2d7cd011db47|1|0|636241641771958566&sdata=%2FEg7HwINXrZ%2FRh6I1DWHgzKVps66AQnfxrGCkMlJ6S4%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F1498%23issuecomment-284039439&data=02|01|jhalleux%40microsoft.com|5804c2fb36a4469767e208d46266f61f|72f988bf86f141af91ab2d7cd011db47|1|0|636241641771958566&sdata=mq2jxKFVXwDMNlv9CPDviU%2BflhrpsvPAkNOM4hUc44c%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KUojTp-BlBTPmPrZM5reUp1MAJgjks5riGJLgaJpZM4MRCoK&data=02|01|jhalleux%40microsoft.com|5804c2fb36a4469767e208d46266f61f|72f988bf86f141af91ab2d7cd011db47|1|0|636241641771958566&sdata=mV4mijWa84PJkucnaRCKOF1jbsx5a%2FtxKPWn9cOZQSU%3D&reserved=0.

Won't fix for now as we at rethinking if\else blog in a different way.


Add additional details to README.md.

An outsider may not be aware that PostgreSQL COPY is limited by its single-threaded nature. In addition, it is useful for users and developers looking at the codebase to immediately grasp the key functions of this tool (parallization & doing it in an efficient manner with round robin).
The explanation for this comes from @mfreed, I've only edited it to make it fit better with the README.md. See his original comment here.

Thanks for your contribution


Make middleware and exported actions FSA compliant

The way things are passed on meteor and data keys currently works fine, and may even be the standard shape in the project that spawned this library, but there is pretty solid community acceptance for the FSA standard which dictates any can carry only keys named payload meta or error.
That adoption enables lots of clever and useful abstractions that end up not being very compatible with non-FSA compliant libraries (like this one currently is)
I will put up a PR for this today if i can, will be pretty simple as most of the current data will just be nested under payload.

This will be taken care of pending the changes in the stop-subscriptions branch in #4

All good as of merged #8


moved ms5611 and bst from common rc.sensors

This suppose to make start-up cleaner for some boards that don't uses some sensors but try do start them because they are on the common rc.sensors.
some disscution is here #12409
Few issues before you might merge that:

aerotenna, emlid, parrot,  uses the ms5611, or the ms5607 but has no 'rc.board_sensors' file.
How they uses (or not) the rc scripts?
for aerofc-v1, there is already 'ms5611 -T 0 start' on 'rc.board_sensors' so I don't copy that.
is that ok?
does you consider the bst telemetry as sensor? Curretlly I moved it to all borads that compile the bst. but should it have a EN parameter? if yes, SENS_EN_BST?

Looking good.

the ms5607 can be found on some pixhawk variants in place of the ms5611 (slightly more expensive). Unfortunately there's no WHO_AM_I so it has to be dedicated based on output.
the only "external" ms5611 I'm aware of is the pixhawk 2 cube which took the pixhawk's external SPI and used it internally for the isolated sensors
Yes let's create a parameter for BST (Blacksheep telemetry) and get it out of each board. It's not a sensor though and could probably be either it's own group or maybe something new for telemetry.

There's already a telemetry (TEL_*) param group that Frsky telemetry is using. https://github.com/PX4/Firmware/blob/master/src/drivers/telemetry/frsky_telemetry/module.yaml
How about a simple TEL_BST_EN boolean parameter that's checked in the main init?

@dagar Is this PR still relevant? with the work that is done on other PRs like https://github.com/PX4/Firmware/pull/12783


Domain events scaffolding

This PR adds the groundwork for Domain Events.
A DomainEventService provides a mechanism for saving and retrieving the events.  They are stored in a single database table with the bulk of the event being kept in a JSON column to avoid having to create and maintain a table structure for each type of event.
Perhaps controversially: the data stored in the table is serialized from/deserializes to the same model as is returned by the endpoints to avoid the maintenance overhead of keeping an identical "domain" version of each event and transforming between them.

 Get the 'application submitted' domain event created, stored & exposed


Set roll option for Swashbuckler's Panache-granting actions

Makes things a bit cleaner, and hopefully easier for 3PP to add their own swashbuckler styles. I left feats out of this due to the way Panache and Derring-Do are worded:
Panache says

gain a +1 circumstance bonus to checks to Tumble Through or to take any actions that give you panache due to your style

Derring-Do says

you can roll twice and use the higher result on checks to which the circumstance bonus for having panache applies (Tumble Through and any skill actions listed in your swashbuckler's style).

Which implies that different ways to gain Panache (such as Leading Dance, One For All, and Disarming Flair) do not qualify for these benefits. For the sake of convenience, I think they're better off with their own Note for gaining Panache, if we add any. Thoughts?

I won't have time to review this until tomorrow, but it should supersede #13059


Update sensor.py with device class datetime

Update next visiting sensor with datetime device class so the entity in dashboard show time until next visit.

Nice! thank you


refactor firstTree and lastTree

firstTree and lastTree contain duplicate code.

Also, nextTree, prevTree, and goToTree have similar lines of code.


feat: add support for sequential groups of webpack builds

Webpack build used to be Main -> Renderers (parallel)
Now you can optionally do Main -> Renderer Group 1 (parallel) -> Renderer Group N (parallel)
This allows folks injecting JS via executeJavaScript to use the raw-loader on the output of of a previous group, ensuring that the initial bundle of group 1 is generated before webpack starts tracing the import tree of group 2.
Most folks won't need to do this

Ok I fixed it 😅

Very cool changes


The validator goes OOM while reading just 100 validators from the disk keystores

A discord user reported that validator goes OOM on startup while using the mev boost PR on ropsten network

(https://discord.com/channels/593655374469660673/593655641445367808/986732729968246864)
However on debugging it was figured out that it was NOT related to mev boost PR and repro-able on the unstable branch.
The validaor started without any issue on using mnemonic arguments.
Describe the bug
Memory hog and OOM while reading keystores

The validator goes OOM while reading just 100 validators from  the disk keystores
Expected behavior
No unusual memory spikes and

Steps to Reproduce

Import the keystore
Start the validaor

ubuntu docker,  lodestar Version: v0.39.0-dev.e5b74d5ae2

If this issue is affecting all networks it's very critical, marked as prio0-critical

Our beta testing process never runs a node with Keystores, so an issue like this won't be caught. We must run at least one node with mnemonics. Fox example, all the beta group nodes, run them with keystores since their key allocation is very stable

If this issue is affecting all networks it's very critical, marked as prio0-critical

yes i confirm it affects other networks as well: for keystores imported via deposit cli 100 vals, same behavior across various networks.

(the first process res memory climbed up till 7GB when screenshot, keeps going all the way up)

UPDATE:
have localized the problem over here: https://github.com/ChainSafe/lodestar/blob/unstable/packages/cli/src/validatorDir/ValidatorDir.ts#L114
this is being called in parallel for lets say 100 vals, and all get stuck here and memory starts increasing
if i restrict this to 10 vals, memory increase for lets say 2.5 GB and this resolves and we move forward, but the memory does NOT go down!
It seems that "@chainsafe/bls-keystore"; is getting loaded into mem for each instance of const privKey = await keystore.decrypt(password); call
If i serialize this call by removing promise.all from https://github.com/ChainSafe/lodestar/blob/unstable/packages/cli/src/validatorDir/ValidatorDirManager.ts#L75) then  issue resolves
but then its too slow to load 100 vals

Opening it again for a proper fix the parallel keystore decrypt solution, the current one is too slow as also commented in the #4174 PR commit.
cc @dapplion @wemeetagain

Confirming the hotfix allows me to run 100 validators from keystore on Sepolia for now.

JUST some more update regarding some investigation done regarding this:

Repro-able in stable
Repro-able in v0.33.0 (docker)
Memory doesn't come down (ran 20 vals  for 15 minutes which hogged 5gb), memory didn't drop

cc: @dapplion @wemeetagain


[#78] Autocorrect EnumHash Cop

Resolves #78.
Adds autocorrect feature for #78.
Depends on #94.

#94 has been merged. Can you rebase this PR with latest master branch? After rebasing I will review this PR.

#94 has been merged. Can you rebase this PR with latest master branch? After rebasing I will review this PR.

Thanks! I just pushed the branch after rebasing.

@santib The master branch has been updated by #96. Please update this PR with latest master again.

@koic Perfect, will fix it later today

@koic @pocke Just rebased and built a new version of the autocorrect. I did a separate commit just for now but I'll squash once everything looks good.
I'm not sure if it's acceptable to do it this way because in other cops I saw mostly changes to strings rather than stringifying objects such as I just did. If it's not acceptable, just let me know and I'll work on another version.
I assumed that other cops (such as prefer new hash syntax) will autocorrect the hash built in this solution, is that correct?

I assumed that other cops (such as prefer new hash syntax) will autocorrect the hash built in this solution, is that correct?

I think it is good as a minimal implementation because this approach has achieved its purpose to prevent unintended reordering of database values.
@pocke Do you have any thoughts?

If there is no problem, it will merge soon.

I agree with @koic . The implementation looks good.

Thanks!

There seems to be an issue with autocorrection of nested constants: https://github.com/rubocop-hq/rubocop-rails/pull/114
Any ideas on the right way to approach fixing this?


some sections of our website are colliding_BUG:

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
some sections are colliding in our website needs to be improved , @arghadipmanna101 assign this issue to me I will fix it. Thankyou
Attaching screenshot for your reference

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign me this issue.


WIP: ConvertTubesToImage issue

The ConvertTubesToImage program seems to fail to properly handle template images with non-zero offset, nor is there any mention made of the direction information in the code. While the pixel data in the output image appears correct, its origin and direction are fixed at zero and identity, respectively.
I'm running into problems trying to fix this The Right Way™, however. Simply passing the origin and direction through breaks things.  Instead chaining TubeSpatialObject::GetIndexToWorldTransform().TransformPoint and Image::TransformPhysicalPointToContinuousIndex for the coordinate transformation doesn't help. Interestingly, stopping with passing the origin and direction through restores functionality with the changed coordinate transformation in place.
The TRE files are probably fine, since VesselView renders them aligned with the input / template images.
@aylward The context here is the stroke data.

An additional note: I tried to hack it by doing it the old way, but neglecting the origin in the custom coordinate transformation code and just setting the origin and direction on the output image, but that doesn't quite do it -- the tubes end up in the corner of the output image in a position that appears to be a translation from the correct one.

This code was written before ITK has oriented images and before
significant changes were made to spatial objects.
In the constructor and code of itktubeTubeSpatialObjectToImageFilter
it is clear that it is computing the point transforms on its own,
instead of calling the helper functions for index to world and world
to index transforms.
The good news is that we do now have those helper functions in the ITK
spatial object classes, so converting this code to using them should
be straightforward and lead to a result that is correct and easier to
maintain.
Thanks!
s
On Tue, May 23, 2017 at 6:38 PM, Neal Siekierski
<EMAIL_ADDRESS>wrote:

An additional note: I tried to hack it by doing it the old way, but
neglecting the origin in the custom coordinate transformation code and just
setting the origin and direction on the output image, but that doesn't quite
do it -- the tubes end up in the corner of the output image in a position
that appears to be a translation from the correct one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

--
= Stephen R. Aylward, Ph.D.
= Senior Director of Operations, North Carolina, Kitware, Inc.
= http://www.kitware.com, http://www.aylward.org
= https://www.linkedin.com/in/stephenaylward
=<PHONE_NUMBER> x300

That would explain why it doesn't use the helper functions. Please note my first comment, however -- the "hack" was an attempt at fixing it with minimal changes, but I did try to do so with the helper functions I mentioned there, without success.

ComputeObjectToWorldTransform must be manually called; that was the issue. Anisotropic images are still handled improperly, but I know why that's happening.

Okay, that should do the trick -- I get good output from ConvertTubesToImage now. The optional radius output image is still broken for anisotropic images, but since fixing that would require making it a vector instead of a scalar image, thus changing the API, I've not done so here.

yes
On Thu, Jun 1, 2017 at 9:24 AM, Deepak Roy Chittajallu <
<EMAIL_ADDRESS>wrote:

@cdeepakroy commented on this pull request.
In Base/Filtering/itktubeTubeSpatialObjectToImageFilter.hxx
https://github.com/KitwareMedical/ITKTubeTK/pull/923#discussion_r119612063
:

@@ -259,9 +249,24 @@ TubeSpatialObjectToImageFilter< ObjectDimension, TOutputImage, TRadiusImage,
// Radius Image and Density image with radius
if( m_UseRadius )
{

     typename TubePointType::PointType radius, zero;

     radius.Fill( tubePoint->GetRadius() );

     zero.Fill( 0 );

     // Convert to an index vector, working around the lack of an

     // appropriate transformation function

     ContinuousIndexType cix_radius, cix_zero;

     OutputImage->TransformPhysicalPointToContinuousIndex(

       tubeIndexPhysTransform->TransformPoint( radius ),

Does tubePoint->GetRadius() return radius in continuous index space? Need
to make sure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KitwareMedical/ITKTubeTK/pull/923#pullrequestreview-41507023,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAREr7o_3FeML_X5BFBwi6EFXt_gOmxoks5r_ruFgaJpZM4NkWqq
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, North Carolina, Kitware, Inc.
http://www.kitware.com and http://www.aylward.org
(919) 969-6990 x300


PushSecret to AWS Secrets Manager: Define KMS key to use to encrypt secret

Describe the solution you'd like
At the moment it does not seem possible to define a customer managed  KMS key which should be used to encrypt a secret at rest. Is it possible to add this?

I reckon this is something that would need to go to the SecretStore spec. @moolen thoughts?

From the initial design we envisioned it roughly like this:
apiVersion: external-secrets.io/v1alpha1
kind: SecretStore
metadata:
  name: example
  namespace: example-ns
spec:
  provider:
    aws:
      service: SecretsManager
      role: iam-role
      region: eu-central-1
      encryptionConfig: {} # Specific config for Creating Secrets on AWS
      auth: {} # ...

I guess it makes sense to add that there so a user is able to point to a customer managed key.
Then we just need to pass it to the CreateSecret() call (docs).
    // The ARN, key ID, or alias of the KMS key that Secrets Manager uses to encrypt
    // the secret value in the secret. An alias is always prefixed by alias/, for
    // example alias/aws/secretsmanager. For more information, see About aliases
    // (https://docs.aws.amazon.com/kms/latest/developerguide/alias-about.html).
    //
    // To use a KMS key in a different account, use the key ARN or the alias ARN.
    //
    // If you don't specify this value, then Secrets Manager uses the key aws/secretsmanager.
    // If that key doesn't yet exist, then Secrets Manager creates it for you automatically
    // the first time it encrypts the secret value.
    //
    // If the secret is in a different Amazon Web Services account from the credentials
    // calling the API, then you can't use aws/secretsmanager to encrypt the secret,
    // and you must create and use a customer managed KMS key.
    KmsKeyId *string `type:"string"`

I am trying to solve this issue, quick question: looks like the pushsecret method does not have info on secretStore, it just has info from pushsecretData, how do you think this should be architected ? should the secretstore config come through SecretsClient interface ? @moolen


Add information about configuring actions with hub

There's a lot of scattered information about how to properly configure hub to be used on GitHub actions.
This attempts to condense this to a simplified bit of information captured in the README.
See:

#1644
#225

Thank you, but I'm going to close this since I think our current instructions for GitHub Actions already cover most usages. GITHUB_TOKEN is enough to configure hub authentication (no need to write ~/.config/hub), and cloning and pushing to other repositories within Action is git-specific, not hub-specific, and in my view should be left as an exercise to the user.


Add possibility to define custom ca.pem file per kontena master

So that it's easier & safer to use self-signed certificates with master.

Looks good!


Bug: Nuxters Card for GitHub is not displayed

🐞 Description
The Nuxters Card that was displayed in the GitHub README is suddenly not showing up.
The URL of the OG image has been changed and we believe this may be the cause.

before: https://nuxters.nuxt.com/{GitHub name}/__og_image__/og.png
after: https://nuxters.nuxt.com/card/{GitHub name}/og.png

However, it is possible that the loading of Add your Nuxter card on Github is not completed and another problem is compounding.
(This one will creating in another bug issue: #66 ).
🔗 Linked Issue
related #66 .

Yes, we changed the url, before it was the default URL of the image generated by the og-image module, which changed its path, so we set up a proxy to avoid further disruption if the path changes in the future.

Thanks for the comment.
I tried the this URL (nuxters.nuxt.com/card/{GitHub name}/og.png) as a test, but it didn't improve the situation. The image is still not displayed.

https://github.com/nuxt-modules/og-image/issues/194
Your github avatar is a PNG image, and there is an error with the new version of og-image.
nuxters.nuxt.com/card/maximepvrt/og.png => OK (jpeg avatar)
nuxters.nuxt.com/card/shinGangan/og.png => KO (png avatar)

@shinGangan

@maximepvrt Thank you ❤