Tables & overflow

Hello,
I don't know how far it is possible for you but, sometimes text in tables overflow the pdf, like in this tutorial https://zestedesavoir.com/tutoriels/pdf/2508/matomo-analytics.pdf on part <IP_ADDRESS>. This is not adapted to reading.
If this is not possible il bare latex, how rebber can adapt it?

It seems possible: rebber currently uses tabu, which seems to provide options to do that (I completely forgot about that). I can check for that within a few days and communicate the eventual possible change to rebber.
Side note: the titles seems wrong, like it has skipped a level: numbering of subsections (so # in a content section) is always of the form x.y.0.z, the 0 being weird, and there is some #### in the generated pdf. I don't know wheter it is a rebber or a zds-site bug (I completely lost track of this part of the code :'( )

That's fixed ;)


Multiple toolboxes (Ardublockly fork)

Dear Carlos,
I am not sure if this is the correct place to put this question
I need your help once more.
I would like to show different toolboxes to the user depending on his choices. I would have a menu item with three options
1 - Actuators and Sensors
2 - Robotic Car
3 - Robotic Arm
Depending of the user's choice I would decide which toolbox  (with it's specific blocks) would be shown to the user.
Another possibility  would be to have just one toolbox and enable or disable some blocks depending on the  menu item selected.
Is it possible?
Best Regards
Rubens.

You can feed new toolbox xml trees into blockly at any time, the only constrain is that you cannot switch between having and not having categories.
Currently I keep a copy of the tree in "global" scope, and edit it as required in ardublockly/ardublockly_blockly.js. In this case there is manual addition and removal of nodes into/from the tree, but if you have predefined toolboxes, you could just pick and chose which one to load at any given moment.

Thank you so much.

No problem.


Generalize POIs module

Generalizes the POIs module to query using a tags dict instead of an amenities list. Removes the amenities parameter from all POI functions. The tags dict accepts key:value pairs of the form:

'tag' : True (to retrieve all items with tag)
'tag' : 'value' (to retrieve all items with tag = value)
'tag' : ['value1', 'value2', etc] (to retrieve all items with tag equal to either value1 or value2 etc.

Resolves #190. Adapts contributions from stale PRs #240 #342 with enhancements from #446.
Usage examples of the new POI querying functionality:
import osmnx as ox
ox.config(use_cache=True, log_console=True)

poly = ox.gdf_from_place('Boston, MA, USA', buffer_dist=2000)
gdf = ox.pois_from_polygon(poly['geometry'].iloc[0], tags={'amenity':'university'})

gdf = ox.pois_from_address(address='Piedmont, California, USA',
                           tags={'amenity' : 'school'},
                           custom_settings='[out:json][timeout:180][date:"2019-10-28T19:20:00Z"]')

gdf = ox.pois_from_point(point=(42.344490, -71.070570),
                         distance=500,
                         tags={'amenity' : 'restaurant'},
                         timeout=200,
                         memory=100000)

tags = {'amenity' : True,
        'landuse' : ['retail', 'commercial'],
        'highway' : 'bus_stop'}
gdf = ox.pois_from_place(place='Piedmont, California, USA', tags=tags)

Coverage decreased (-0.009%) to 92.656% when pulling 85f483f2651fa429180a41dc0cce84765378735f on feature into 47f193a36ef2279fb644fc675e86a29fbc8b7a0f on master.

@carlhiggs @shiqin-liu I'd be curious to hear your thoughts on this PR (and to make you aware of it). It enhances and generalizes the OSMnx pois module to handle all points of interest. It was previously limited to amenities only. This may be useful for querying OSM in the global indicators project?

Excited to see this PR! I think it certainly makes OSM POIs query more flexible. I recalled that what I used before is node_query from Pandana as it allows search POIs based on tags within a bbox. These functions are what I am looking for, so thanks for making me aware of this, I think it will certainly be very useful for the project moving forward.

This is exciting, thanks for letting me know!  I had previously looked into the use of OSMnx for identifying destinations when I first started working with OSM a few years ago, but ended up using osm2pgsql (having a postgis workflow, this made sense for our national project).  It'll be great to have this as an option when working with OSMnx in the future.  It could be possible to refactor code to make use of it for global indicators; its worth considering as we look to simplify code into a unified package.  Nice one!


feat(parsr): parse let.a = 1 with error recovery

Current dependencies on/for this PR:

main

PR #1587   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 29, 10:21 AM: @Boshen merged this pull request with Graphite.


feat(sqla-core): Add support for rendering Database Specific queries

Issue: #290
Description of changes:
This makes the sqla-core plugin aware of how to compile a database specific query.
Sorry for the restructure of the tests. I've split them up into separate PRs with justifications on the messages. It amounts to defining common tests between multiple engine versions, so now this plugin is tested with both SQLite, and Postgres.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
fixes: #290

Codecov Report

Merging #291 (a38cd3f) into master (e7711fe) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   79.53%   79.15%   -0.39%
==========================================
  Files          83       83
  Lines        3279     3200      -79
==========================================
- Hits         2608     2533      -75
+ Misses        671      667       -4

Impacted Files
Coverage Δ

aws_xray_sdk/ext/sqlalchemy_core/patch.py
76.92% <100.00%> (+4.34%)
:arrow_up:

aws_xray_sdk/core/sampling/connector.py
47.94% <0.00%> (-2.71%)
:arrow_down:

aws_xray_sdk/core/emitters/udp_emitter.py
61.11% <0.00%> (-2.05%)
:arrow_down:

aws_xray_sdk/core/sampling/reservoir.py
57.69% <0.00%> (-1.57%)
:arrow_down:

aws_xray_sdk/ext/dbapi2.py
79.54% <0.00%> (-1.31%)
:arrow_down:

aws_xray_sdk/core/sampling/sampling_rule.py
90.90% <0.00%> (-1.05%)
:arrow_down:

aws_xray_sdk/core/recorder.py
86.08% <0.00%> (-1.04%)
:arrow_down:

aws_xray_sdk/core/sampling/sampler.py
63.01% <0.00%> (-0.99%)
:arrow_down:

aws_xray_sdk/core/sampling/local/sampling_rule.py
93.61% <0.00%> (-0.83%)
:arrow_down:

aws_xray_sdk/sdk_config.py
92.30% <0.00%> (-0.80%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7711fe...a38cd3f. Read the comment docs.

I'll restructure this PR after the sqla 1.4 PR is merged

@cybojenix Thanks. I'll take a look once it is ready. :)

Over to you, @srprash

And could you also update the branch? Thanks!

Both addressed

Awesome! thanks


[FEATURE]  render-markdown plugin support

Is your feature request related to a problem? Please describe.
Hello, this is my first issue ever on github so please redirect me if i posted this in the wrong place.
I wanted to use this plugin for rendering markdown in my neovim. I came across an issue pretty quickly though, which was that the gruvbox colorscheme did not apply to the markdown headings. As you can see in the image below

Describe the solution you'd like
I ended up finding a fix for it though so now it looks like this. You can add background colours yourself but i prefer a transparent background.

I simply added the code snippet under to my overrides inside of the opts of the gruvbox.lua colorscheme file.
I based the colours of how the obsidian gruvbox theme colours different headings, and i took the hex values from the colour pallete on the gruvbox github page.
-- add colour code inside of bg=' ' if you want background colours
   overrides = {
      RenderMarkdownH1Bg = { fg = '#cc241d', bg = '', bold = true },
      RenderMarkdownH2Bg = { fg = '#d79921', bg = '', bold = true },
      RenderMarkdownH3Bg = { fg = '#98971a', bg = '', bold = true },
      RenderMarkdownH4Bg = { fg = '#689d6a', bg = '', bold = true },
      RenderMarkdownH5Bg = { fg = '#458588', bg = '', bold = true },
      RenderMarkdownH6Bg = { fg = '#b16286', bg = '', bold = true },
    },

I would like to either get better gruvbox integration with the render-markdown plugin.
If that is not feasible it would be great if this could solution be added to a wiki somewhere, such that the others who stumble upon this problem can find a quick fix.

i got help from the owner of the render-markdown repository
Now this should interact with treesitter directly making it a much better general improvement to the colorscheme.
This is how i use it currently for the gruvbox theme.
    overrides = {
      -- Markdown Header Background Overrides with Foreground Colors
<EMAIL_ADDRESS>= { fg = '#fb4934', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#fabd2f', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#b8bb26', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#8ec07c', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#83a598', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#d3869b', bg = '', bold = true },
    },

with this change though if you want transparent background on the different headers, you need to add the code snippet below inside of the opts of your render-markdown.lua file
      backgrounds = {
        '',
        '',
        '',
        '',
        '',
        '',
      },

i got help yet again
This now properly interacts with render-markdown.nvim without having to alter the render-markdown.lua file at all.
    overrides = {
      -- Markdown Header Background Overrides with Foreground Colors
<EMAIL_ADDRESS>= { fg = '#fb4934', bg = '', bold = true }, -- sets 1. header to gruvbox red no background
<EMAIL_ADDRESS>= { fg = '#fabd2f', bg = '', bold = true }, -- sets 2. header to gruvbox yellow no background
<EMAIL_ADDRESS>= { fg = '#b8bb26', bg = '', bold = true }, -- sets 3. header to gruvbox green no background
<EMAIL_ADDRESS>= { fg = '#8ec07c', bg = '', bold = true }, -- sets 4. header to
<EMAIL_ADDRESS>= { fg = '#83a598', bg = '', bold = true },
<EMAIL_ADDRESS>= { fg = '#d3869b', bg = '', bold = true },
      ['DiffAdd'] = { fg = '', bg = '' },  -- removes greenish glow over first header
      ['DiffChange'] = { fg = '', bg = '' }, -- removes greenish glow over second header
      ['DiffDelete'] = { fg = '', bg = '' }, -- removes redish glow over all other headers
    },


fix: typo - Tak

hi @fred3105, I reverted your PR because it broke the builds. Could you redo the PR and run pnpm build to make sure it builds successfully? Thank you!


refactor: simplify code, remove foreach loop

:tada: This PR is included in version 0.16.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Double and triple touch validation moved to the delete_clock function of the on_touch_down event

Double and triple click checks must occur when the on_touch_down method is triggered, otherwise the functions : on_double_tap, on_triple_tap - will trigger twice.
Code example
https://user-images.githubusercontent.com/40869738/120072151-f900ae00-c09a-11eb-8ba5-ae66827a6bda.mp4

@Neizvestnyj Have you tested this on touch devices?

@Neizvestnyj Have you tested this on touch devices?

Now I will build a test package

@Neizvestnyj The on_double_tap event is not a double click. This is a two-finger touch. Also the on_triple_tap event. It's not three clicks on a button. This is one touch with three fingers.

@Neizvestnyj The on_double_tap event is not a double click. This is a two-finger touch. Also the on_triple_tap event. It's not three clicks on a button. This is one touch with three fingers.

Well, it can't be tested on a PC. I checked on the phone and it doesn't work at all as you say. My example works just like yours but the method is called once

@Neizvestnyj Perhaps the on_double_tap and on_riplе _tap events do not work. But you have confused the meaning of the events. And broke the on_long_touch event. Therefore, I closed your PR.

@Neizvestnyj Double and triple clicks don't make sense.

Perhaps the on_double_tap and on_triplе_tap events do not work. But you have confused the meaning of the events. And broke the on_long_touch event. Therefore, I closed your PR.

on_long_touch works as before, you have written in the docks that this is the name of the click. Then you just need to create another on_touch_down call that will handle clicks

@Neizvestnyj Double and triple clicks don't make sense.

What do you mean

@Neizvestnyj The kivymd/uix/behaviors/touch_behavior.py module is detect to de-initiate double and triple TOUCH events on an object. Not PRESSING two and three times, but TOUCHING with two and three fingers.

@Neizvestnyj The kivymd/uix/behaviors/touch_behavior.py module is detect to de-initiate double and triple TOUCH events on an object. Not PRESSING two and three times, but TOUCHING with two and three fingers.

It doesn't work as you say.

@Neizvestnyj Yes, this is outdated documentation. Therefore, I cannot accept your changes. They don't match what was intended.

@Neizvestnyj Double-clicking and even more so triple-clicking does not make sense and is practically not used anywhere, except for launching the application and opening files. Unlike senosor events.

Double-clicking and even more so triple-clicking does not make sense and is practically not used anywhere, except for launching the application and opening files. Unlike senosor events.

Okay


ERROR  Cannot start nuxt:  Nuxt module should be a function: @nuxtjs/color-mode

When starting the dev server with nuxt 3.14.0 I get
ERROR  Cannot start nuxt:  Nuxt module should be a function: @nuxtjs/color-mode
------------------------------
- Operating System: Windows_NT
- Node Version:     v22.11.0
- Nuxt Version:     3.14.0
- CLI Version:      3.15.0
- Nitro Version:    2.10.2
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      default
- Runtime Modules:  normalizedModule(), normalizedModule<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    -
------------------------------

I get the same thing

I get the same thing.
But then when you explicitly add @nuxtjs/color-mode. It becomes:
 ERROR  Cannot start nuxt:  Nuxt module should be a function: [object Object]                              11:08:26 PM

  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2459:11)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_i2sa3goc3rkwa3dnmwfqcnr7qi/node_modules/nuxt/dist/index.mjs:4669:5)
  at async NuxtDevServer._load (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1894:5)
  at async NuxtDevServer.load (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1828:7)
  at async NuxtDevServer.init (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1823:5)
  at async Object.run (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev-child.mjs:104:5)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Not sure if it has anything to do with shadcn-nuxt? As they did add auto install for the @nuxtjs/color-mode module.

I get the same thing.
But then when you explicitly add @nuxtjs/color-mode. It becomes:
 ERROR  Cannot start nuxt:  Nuxt module should be a function: [object Object]                              11:08:26 PM

  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2459:11)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_i2sa3goc3rkwa3dnmwfqcnr7qi/node_modules/nuxt/dist/index.mjs:4669:5)
  at async NuxtDevServer._load (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1894:5)
  at async NuxtDevServer.load (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1828:7)
  at async NuxtDevServer.init (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev2.mjs:1823:5)
  at async Object.run (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/dev-child.mjs:104:5)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Not sure if it has anything to do with shadcn-nuxt? As they did add auto install for the @nuxtjs/color-mode module.
https://github.com/unovue/shadcn-vue/pull/737

I get the same thing.
Weirdly enough updating to version 3.14.0 is fine for me. But when I either update my shadcn-nuxt version from 0.10.4 to the newest 0.11.2 I get this error:
 ERROR  Nuxt module should be a function: @nuxtjs/color-mode                                                                                12:08:44 AM

  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2459:11)
  at installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2389:53)
  at setup (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/shadcn-nuxt@0.11.2_magicast@0.3.5_rollup@4.24.4/node_modules/shadcn-nuxt/dist/module.mjs:46:11)
  at async normalizedModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2140:17)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2397:95)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_5j6blunq47cjlgzrfcttbmiv4i/node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_5j6blunq47cjlgzrfcttbmiv4i/node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2626:19)
  at async Object.run (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Maybe something to do with this?
https://github.com/unovue/shadcn-vue/pull/737
And when I try and install @nuxt/rspack-builder I get this:
 ERROR  Nuxt module should be a function: [object Object]                                                                                12:07:04 AM

  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2459:11)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_i2sa3goc3rkwa3dnmwfqcnr7qi/node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.0_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4.24_i2sa3goc3rkwa3dnmwfqcnr7qi/node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.0_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2626:19)
  at async Object.run (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:2019:10)
  at async Object.setup (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/chunks/add2.mjs:197:5)
  at async runCommand$1 (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1620:5)
  at async runCommand$1 (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runCommand$1 (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/C:/Users/leviv/AppData/Local/npm-cache/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Maybe it is also the new shadcn-nuxt version who's causing issues in your codebase @Rednas83?

Thanks. Downgrading shadcn indeed fixed the issue for me
"shadcn-nuxt": "^0.10.4",

Seems to be connected with https://github.com/unovue/shadcn-vue/issues/864

I've installed the new Nuxt version 3.14.159. But this is still an issue when updating my shadcn-nuxt from 0.10.4 to 0.11.2:
ERROR  Nuxt module should be a function: @nuxtjs/color-mode
  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2460:11)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async setup (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/shadcn-nuxt@0.11.2_magicast@0.3.5_rollup@4.24.4/node_modules/shadcn-nuxt/dist/module.mjs:46:5)
  at async normalizedModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2140:17)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2397:95)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.159_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4._dtd72bcuvnkmstgdtddzxizlvy/node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.159_@parcel+watcher@2.5.0_@types+node@22.8.7_ioredis@5.4.1_magicast@0.3.5_rollup@4._dtd72bcuvnkmstgdtddzxizlvy/node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4/node_modules/@nuxt/kit/dist/index.mjs:2627:19)
  at async Object.run (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)

It's true, I get the same error when upgrading to 3.14.159, however it's an easy fix
Make sure you install @nuxtjs/color-mode, this could be an issue with the shadcn packages, not nuxt

It's true, I get the same error when upgrading to 3.14.159, however it's an easy fix Make sure you install @nuxtjs/color-mode, this could be an issue with the shadcn packages, not nuxt

Yea I just found that out as well. Indeed sounds like a shadcn issue.

Weird thing is, when I install "@nuxt/rspack-builder" I get this:
 ERROR  Nuxt module should be a function: [object Object]

  at loadNuxtModuleInstance (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2460:11)
  at async installModule (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async initNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.159_@parcel+watcher@2.5.0_@types+node@22.9.0_ioredis@5.4.1_magicast@0.3.5_rollup@4._yvk4y57n46krfngabiv4qthxtq/node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxt@3.14.159_@parcel+watcher@2.5.0_@types+node@22.9.0_ioredis@5.4.1_magicast@0.3.5_rollup@4._yvk4y57n46krfngabiv4qthxtq/node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/@nuxt+kit@3.14.159_magicast@0.3.5_rollup@4.24.4_webpack-sources@3.2.3/node_modules/@nuxt/kit/dist/index.mjs:2627:19)
  at async Object.run (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:2019:10)
  at async Object.setup (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/chunks/add2.mjs:197:5)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1620:5)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runCommand$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/D:/Documents/Invix%20Digital/Companies/Praetium/Development/app/node_modules/.pnpm/nuxi@3.15.0/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Strange indeed, but should be another issue if you ask me.

Strange indeed, but should be another issue if you ask me.

Yea I think so too, will be doing that.

check the latest version because i think that issue is resolved

IDK why this is closed. It's still an issue.
ERROR  Cannot start nuxt:  Nuxt module should be a function: @nuxtjs/color-mode                                               11:54:43 a.m.
Reverting to old version fixes it.

@rogadev then please provide a reproduction 🙏

@danielroe
I've tried to run the command: bunx nuxi@latest module add shadcn-nuxt, then the resulting fallout into an error:
 ERROR  Nuxt module should be a function: @nuxtjs/color-mode

  at loadNuxtModuleInstance (node_modules/@nuxt/kit/dist/index.mjs:2460:11)
  at async installModule (node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async setup (node_modules/shadcn-nuxt/dist/module.mjs:46:5)
  at async normalizedModule (node_modules/@nuxt/kit/dist/index.mjs:2140:17)
  at async installModule (node_modules/@nuxt/kit/dist/index.mjs:2397:95)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (node_modules/@nuxt/kit/dist/index.mjs:2627:19)
  at async Object.run (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
  at async runCommand (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:2019:10)
  at async Object.setup (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/chunks/add2.mjs:197:5)
  at async runCommand$1 (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1620:5)
  at async runCommand$1 (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runCommand$1 (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
  at async runMain$1 (/private/tmp/bunx-501-nuxi@latest/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)

Even when I omit the module addition, when I complete the initialize of the CLI the error appears with the command: bunx shadcn-vue@latest init:
bunx shadcn-vue@latest init
✔ Would you like to use TypeScript? (recommended)? … no / yes
✔ Which framework are you using? › Nuxt
✔ Which style would you like to use? › New York
✔ Which color would you like to use as base color? › Zinc
✔ Where is your tsconfig.json file? … .nuxt/tsconfig.json
✔ Where is your global CSS file? (this file will be overwritten) … src/assets/main.css
✔ Would you like to use CSS variables for colors? … no / yes
✔ Are you using a custom tailwind prefix eg. tw-? (Leave blank if not) …
✔ Where is your tailwind.config located? (this file will be overwritten) … tailwind.config.ts
✔ Configure the import alias for components: … @/components
✔ Configure the import alias for utils: … @/utils
✔ Write configuration to components.json. Proceed? … yes

✔ Writing components.json...
⠋ Initializing project...
ℹ Detected a Nuxt project with 'shadcn-nuxt' v0.11.2...
✔ Initializing project...
⠦ Installing dependencies...
 ERROR  Command failed with exit code 1: bun add tailwindcss-animate class-variance-authority clsx tailwind-merge radix-vue @radix-icons/vue  2:31:58 PM
Resolving dependencies
Resolved, downloaded and extracted [23]
Saved lockfile

$ nuxt prepare

 ERROR  Nuxt module should be a function: @nuxtjs/color-mode

  at loadNuxtModuleInstance (node_modules/@nuxt/kit/dist/index.mjs:2460:11)
  at async installModule (node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async setup (node_modules/shadcn-nuxt/dist/module.mjs:46:5)
  at async normalizedModule (node_modules/@nuxt/kit/dist/index.mjs:2140:17)
  at async installModule (node_modules/@nuxt/kit/dist/index.mjs:2397:95)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:4669:5)
  at async loadNuxt (node_modules/nuxt/dist/index.mjs:4839:5)
  at async loadNuxt (node_modules/@nuxt/kit/dist/index.mjs:2627:19)
  at async Object.run (node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
  at async runCommand$1 (node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)

 ERROR  Nuxt module should be a function: @nuxtjs/color-mode

error: postinstall script from "" exited with 1
bun add v1.1.34 (5e5e7c60)
[nuxt:tailwindcss] ℹ Using default Tailwind CSS file

[!NOTE]
The dependency detected is<EMAIL_ADDRESS>

This is probably caused by bun hoisting an older version of nuxt/kit, though I can't say for sure without a repro.

This is similar but with a local module: https://github.com/nuxt/nuxt/issues/29848

This is probably caused by bun hoisting an older version of nuxt/kit, though I can't say for sure without a repro.

Hey @danielroe , I know the issue is closed, but I'm still experiencing the problem. Will this repo help reproduce the error? It's literally a newly created Nuxt project

Locally everything works, but in ci npm error
nuxt-module-playground
Run npm ci
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>Use @eslint/config-array instead
npm warn deprecated<EMAIL_ADDRESS>Use @eslint/object-schema instead
npm warn deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>This version is no longer supported. Please see https://eslint.org/version-support for other options.
npm error code 1
npm error path /home/runner/work/nuxt-module-playground/nuxt-module-playground/packages/todo-landing
npm error command failed
npm error command sh -c nuxt prepare
Error: npm error [error] Nuxt module should be a function: @todo/todo-module
npm error   at loadNuxtModuleInstance (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/@nuxt/kit/dist/index.mjs:2460:11)
npm error   at async installModule (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
npm error   at async initNuxt (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxt/dist/index.mjs:4669:5)
npm error   at async loadNuxt (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxt/dist/index.mjs:4839:5)
npm error   at async loadNuxt (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/@nuxt/kit/dist/index.mjs:2627:19)
npm error   at async Object.run (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxi/dist/chunks/prepare.mjs:61:18)
npm error   at async runCommand$1 (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1648:16)
npm error   at async runCommand$1 (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1639:11)
npm error   at async runMain$1 (/home/runner/work/nuxt-module-playground/nuxt-module-playground/node_modules/nuxi/dist/shared/nuxi.bd0a2fa0.mjs:1777:7)
npm error
Error: npm error [error] Nuxt module should be a function: @todo/todo-module
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-11-10T12_38_14_131Z-debug-0.log
Error: Process completed with exit code 1.

npm install @nuxtjs/color-mode

I simulated running locally and got the same error when I deleted all the output and nuxt generated directories.
so that everything works first npm i in the module folder, then dev:prepare in the module folder, then build in the module folder, then npm i in the root folder of the monorepository and everything works.

@nuxtjs/color-mode needs to be installed manually with the  shadcn-nuxt package like this: npx nuxi@latest module add @nuxtjs/color-mode shadcn-nuxt

I ran out into the same problem and I fixed it by removing the / at the end of the dir.public in nuxt.config.
// nuxt.config.ts
// before
dir: {
  public: '../resources/'
}

// after
dir: {
  public: '../resources'
}

I'm not sure if this will help, but it helped me so I'll just leave this here. Good luck

npm install @nuxtjs/color-mode

this solved it for me.

npm install @nuxtjs/color-mode

finally, thanks for the suggestion

This error is often misleading, I also get Nuxt module should be a function: @nuxt/devtools  and for other modules as well. Sometime update --force fixes it, sometimes not. Often this error hides another one. @danielroe is it also possible to display root cause?

Yes, this error message needs to be improved.

This hasn't been fixed...
 ERROR  Cannot start nuxt:  Nuxt module should be a function: @nuxtjs/color-mode                                                       6:26:04 p.m.

  at loadNuxtModuleInstance (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/@nuxt/kit/dist/index.mjs:2466:11)
  at async installModule (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/@nuxt/kit/dist/index.mjs:2389:47)
  at async setup (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/shadcn-nuxt/dist/module.mjs:46:5)
  at async normalizedModule (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/@nuxt/kit/dist/index.mjs:2140:17)
  at async installModule (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/@nuxt/kit/dist/index.mjs:2397:95)
  at async initNuxt (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/nuxt/dist/index.mjs:4684:5)
  at async NuxtDevServer._load (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/nuxi/dist/chunks/dev2.mjs:1894:5)
  at async NuxtDevServer.load (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/nuxi/dist/chunks/dev2.mjs:1828:7)
  at async NuxtDevServer.init (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/nuxi/dist/chunks/dev2.mjs:1823:5)
  at async Object.run (/C:/Users/ryanr/Documents/dev/ezeval.app/node_modules/nuxi/dist/chunks/dev-child.mjs:104:5)

If I revert to 0.10.4 it's fine.
    "shadcn-nuxt": "^0.10.4",

Reproduction.
https://stackblitz.com/edit/github-bbdmxt?file=nuxt.config.ts

See https://github.com/unovue/shadcn-vue/issues/945#issuecomment-2523235188.


pass caller info to babel

https://babeljs.io/docs/en/options#caller

Utilities may pass a caller object to identify themselves to Babel and pass capability-related flags for use by configs, presets and plugins.

Tell babel that esbuild prefers ESModules rather than commonjs. This enables tree-shaking, etc. The alternative is to add something like this to your babel config:
  presets: [
    ['@babel/preset-env', {
        modules: false
    }]
  ]

https://babeljs.io/docs/en/babel-preset-env#modules

Setting this to false will preserve ES modules. Use this only if you intend to ship native ES Modules to browsers. If you are using a bundler with Babel, the default modules: "auto" is always preferred.

Neat. Thanks.


Problems with special characters in file path

Hello,
I'm using Linux (Manjaro) and noticed that the subtitle syncing process fails when there are special characters inside the subtitle file name / path.
It happened both with a space and apostrophe.
They seem to get replaced with a Percent-encoded variant, and then the script fails to find / open the file path that got percent-encoded.
A file with a space:

A file with an apostrophe:

I'm sorry, i personally don't know Lua and don't really have the knowledge to debug it myself, but it definetly fails inside the file_exists(filepath) function, which then presumable gets called somewhere.
I would assume either the filepath somewhere gets a weird encoding, which isn't wanted, or if that is wanted, that the relevant Lua functions to open a file / check if a file exists are not able to work with such an encoded filepath?
I also don't know if this also occurs on Windows, as i don't use that and can't test on that.
It is not the biggest problem, as i can just remove such characters from the filenames,
but it would be cool if this could get fixed!
Thank you

I'll try testing it with different subtitle files.

I cannot reproduce. What's the name of the subtitle file?

So i decided to debug it a little bit.
I took a subtitle file with the exact name One Week Friends.JA.srt.
And the exact steps i took are:

Load the Video file with mpv Isshuukan\ Friends.\ \[01\].mkv.
Drag and drop the subtitle file from the explorer (Dolphin) into the mpv window.
Press 'n', select sync (doesn't matter which one)

Then i get the error
[autosubsync] Subtitle synchronization failed:
[autosubsync] Couldn't find /home/alemax/test/One%20Week%20Friends.JA.srt
I played a bit around to find out, that inside the script, inside the function get_active_track where the tracks are requested from mpv with mp.get_property_native('track-list') the file path already is percent encoded, which means this is coming from mpv.
I also found a function mp_url_escape inside the source of mpv (stream/stream.c), so this is apparently in fact something mpv does. I did not actually debug it properly and can't verify if that function actually gets called before the filepath is sent to the lua script, but i would assume so.
Now i also tested it out with a different set of steps:

Load the video and subtitle with mpv Isshuukan\ Friends.\ \[01\].mkv --sub-file="One Week Friends.JA.srt"
Press 'n', select sync (doesn't matter which one)

Now the subtitle syncing process works, and the string the lua script gets inside get_active_track is, as expected One Week Friends.JA.srt, and not unlike above One%20Week%20Friends.JA.srt.
So the difference here lies in whether i drag and drop the subtitle file into the mpv window or starting mpv with the subtitle file directly.
I'm not entirely sure why this is the case, or if it is wanted from mpv's end.
Now this is for you to decide if you want to try to catch this and de-encode an URL-Encoded file path, if such occurs, or if this is something mpv itself should handle different. (Or if the matter is quite specific anyway and therefore not important enough to warrant a change)

Okay so when you drag-and-drop a subtitle file, the path is mingled. I'll look into it.


No way to have optional data in GraphQL queries.

Description
I'm not sure this is a bug or a feature-request. It seems that while a specific  can have nullable GraphQL fields, if you want to query a source that you've personally defined it does not allow nullable entries.
Steps to reproduce
Using the gridsome/gridsome-starter-blog try and create a post without a cover image. The only way to do so is by rewriting the Page component (and Index etc) to not rely on the cover_image.
Expected result
It should be possible to mark fields as optional or nullable, or just natively support it.
Actual result
Module build failed (from ./node_modules/gridsome/lib/plugins/vue-components/lib/loaders/page-query.js):
Error: Cannot query field "cover_image" on type "Post".

GraphQL request (124:5)
123:     content
124:     cover_image (width: 860, blur: 10)
         ^
125:     meta_image (width: 860, blur: 10)

Environment

Libs:
- gridsome version: 0.6.2
- @gridsome/cli version: 0.1.1

Browser:
- [X] Chrome (desktop) version 74.0.3729.169

For Tooling issues:
- Node version: 12.0
- Platform:  Mac

Gridsome can only generate the schema based on the data you have. We are working on APIs for letting you defined the schema yourself to make sure the cover_image always exists. It will be available in v0.7 :)

Is there any alternative solution we can use in the meantime?

@Acidic9 you can create a Post that contains all the fields, just give it some random name and exclude it from showing up in your site. Better yet is if you have a Post that is actually used that contains all the fields, you just need 1.
Closing this though since it will be fixed in v0.7

For anyone using Netlify CMS, you can just add a default value of '' and the field will be there regardless of whether the field has a value.
You should add a default to all non-required fields to be safe.

Here is a plugin that might solve this

@Acidic9 you can create a Post that contains all the fields, just give it some random name and exclude it from showing up in your site. Better yet is if you have a Post that is actually used that contains all the fields, you just need 1.
Closing this though since it will be fixed in v0.7

Not sure if it's fixed in v0.7? I am still experiencing the same issue?

@u12206050 would you mind writing out instructions for the method you mentioned? I'm having this issue in the latest release (0.7.13) and it looks like your idea could solve it, but I'm not sure where to begin.

@platform-kit  It is best to just define the schema if you have this issue, here is how you would do that:
schema-api


Add typing to init and _collections

So, here is a first iteration of adding types checking, as discuted in #867.
Having stubs files was harder to make it works, and in general, it would be best to keep related code and typing. So we will use magic comment as proposed by @sigmavirus24.
There is a bunch of TODO in code, with the corresponding bug report (or general issue).
I'll add some commit comments to explain choices made.
With the current state of mypy, there is a bunch of error, like
urllib3/_collections.py:22: error: Name 'OrderedDict' already defined
urllib3/_collections.py:27: error: Name 'RLock' already defined
urllib3/_collections.py:25: error: Name 'RLock' already defined

which are caused by mypy not handling conditionals, but, by avoiding theses paths while coding, we can have some type error remarks.
Overview

add types to urllib3/__init__.py and urllib3/_collections.py
adding urllib3.util.typing module to allow handling both python2 and python3 with an easier interface. We will add some classes during next iterations
changing some import check based on ImportError to one using sys.version_info, as it is the recommanded way to do it in PEP 484

So right now I have some extremely mixed feelings about this. It seems like it's hurting us quite a lot to do this. =(

Why is it hurting? It doesn't break anything and IMO it is a nice feature for users to have. Also, it keeps compatibilty with python2, only enable checking if the typing module indeed exists (so no need for user to install), help devs finding some issues (#874 was found this way but that was more by reading code that mypy), ...

Now that we moved the type-specific imports into its own module, it's not too bad but I'd love to see some return on these annotations. At the very least, this process is helping us audit the code and find some subtle cleanup/improvements, right?


Feature Request: Expand simplify options in downloading functions

The download functions currently have a Boolean simplify flag, allowing the downloaded network to be simplified or not. Would be great if this could be altered to include an 'intersections' option to download a network with simplified intersections instead of fully simplified.
This particularly (in my case) for the graph_from_point function (https://osmnx.readthedocs.io/en/stable/osmnx.html#osmnx.core.graph_from_point), but looking at the code it would seem to apply to the graph_from_bbox function as well, and maybe others.
Small tweak so not a high priority, but given the other options in these functions it would be nice if the simplification options were a bit more nuanced.
Thanks for a great library!

Ahh, apparently I misunderstood that simplification actually doesn't delete spatial geometry of street segments between nodes; this would seem to make the above unnecessary. Sorry for having posted before fully understanding; closing.


feat(plugin-charts-ixora): custom series chart

🏆 Enhancements
Add Custom Seriest Chart to Ixora Plugin Packages.  this plugin adds the following features:

chart by custom series without timeline, you can use any data type for series

@melnikovmaksimv thanks for the PR - can you add some context to the PR, e.g. a description, screenshots etc? Thank you!

Any update here, relly intrested in the none timestamp based graph

@melnikovmaksimv, I am so eagerly awaiting this chart type. Please feel encouraged and motivated to tackle the remaining issues.
Thank you very much for taking these efforts on!

@melnikovmaksimv We would love to move this forward, can you provide details about this PR? Thank you for your contribution!
e.g. https://github.com/apache-superset/superset-ui/pull/801

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.


Added an option to disable building of apps.

Making building of apps optional.
This makes it easier to build ospray for packaging in ParaView binaries.

Sorry for the late reply - this change is now present in our 'release-0.9' branch. OSPRay will now only pull required dependencies for the library itself (by default just TBB and ISPC). We previously forced people to have GLUT installed even if we didn't use it, so this should also be helpful to folks too.
Each app has its own option to enable/disable. I'll go ahead and close the issue as the feature to be merged is implemented.
Thanks for the feedback,
Jeff


feat: optimize connect wallet layout

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Include description in repository search.

When doing a keyword search for repositories (for example explore page), include repository description in search. The repository name can be something imaginary / made-up or a product number, while the description actually explains what it does. Therefore you want to include the repository description in the search. This PR should solve #7264.
Do you see any case you don't want repository description included in search, for performance issues or other reasons? It could be made a setting in app.ini, but I didn't see any reason for it.

Codecov Report

Merging #7942 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7942      +/-   ##
==========================================
+ Coverage   41.46%   41.46%   +<.01%
==========================================
  Files         478      478
  Lines       63966    63967       +1
==========================================
+ Hits        26521    26523       +2
+ Misses      33991    33988       -3
- Partials     3454     3456       +2

Impacted Files
Coverage Δ

models/repo_list.go
72.22% <100%> (+0.14%)
:arrow_up:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

routers/repo/view.go
43.54% <0%> (+1.01%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f58187...32966a0. Read the comment docs.

I think it will be a performance problem on a big Gitea instance. For a smaller instance, search maybe an unnecessary things.

I imagine a big single-server system to have... 10,000 repositories? That would be about ~6MB repository table, most likely completely cached.

@lunny Can it be made an app.ini setting (default off)? That way today behavior remains when upgrading, for those that don't want it (due to performance or search including too much).

Based on comments, I have done the following:

Added app.ini setting (SEARCH_REPO_DESCRIPTION = false)
Added option to API whether to include description not not (default false, not affected by app.ini)
If enabled, description will be searched on all pages where description is seen on result page: Explore page, Organization and User profile page. Also on admin repo search page (for consistency with the other search pages).
Description not searched on "incremental" search on dashboard as you only see the repo name, also ajax makes it performance critical (it uses the API).

I also added a small test.

@lunny Can it be made an app.ini setting (default off)? That way today behavior remains when upgrading, for those that don't want it (due to performance or search including too much).

I think this is a good idea.

@lunny need you approval ;)


Async reduce

Would be neat if the reduce option had an async cousin, reduceAsync(a, b, cb). Then a program could prompt a user on reduce

That would be awesome.

I can't seem to get a reduce function I pass into the hyperdb constructor to invoke.
https://github.com/mafintosh/hyperdb/blob/8e9d99b46bd01d5616bfc2778392c3c0bb6fecab/lib/get.js#L96
Shouldn't like 96 pass an initial empty array to the list reducer?, eg:
if (reduce) return results.length ? results.reduce(reduce, []) : null

I can put together a PR for this, but wanted to sanity check that I wasn't missing something simple/stupid.


Fix AWS Regions with SCP for FinOps Policies

Description

Update the AWS Unused Volumes, AWS Old Snapshots, and AWS Unused IP
Addresses policy templates to use the actual calls to determine if
each region is available via SCP since we have discovered that using
DescribeRegions in each particular region does not work reliably
(the DescribeRegions call could be enabled for all regions while
other calls are not).
Add the Code Spell Checker extension to the suggested VS Code
extensions and fix up some misspellings it found.
Removed confusing ignored host "ec2.amazonaws.com" lines from all of
the ds_regions datasources.

Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


Please add documentation for the 3 types of data (Global, Private, and Direct)

I just spent 30 minutes figuring out why sending data to myself wasn't being registered, until I realised I should be using the Private type of data instead of direct in the "When I recieve new [data type] data" block.

Hi there,
I apologize for the inconvenience. The wiki page is still under development, but there is documentation for the various message types you can use. It's a bit old but the fundamental concepts still apply: https://hackmd.io/@MikeDEV/SywNTBqRD


Provide flexible way of resolving S3 objects content type.

Fixes #131

Javadocs, polishing and reference docs pending.


add sqlaxe

Hi @djberube Thank you for your time and contribution here! ✨ Approved, merged 🎉 Best wishes,


Optionally display schema in explain plan

Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/11176
Rationale for this change
In the context of:

https://github.com/apache/datafusion/issues/9403
https://github.com/apache/datafusion/issues/10918

I have been contemplating adding optimizations that DataTypes between certain operators (e.g. to DictionaryArray or StringArray)
Thus I would like to be able to see the schema in the query plans as part of that project
What changes are included in this PR?

Add set datafusion.explain.show_schema = true; option
Add tests

Are these changes tested?
Yes

Are there any user-facing changes?
A new config option and more information in verbose explain plans

Thank you for the review @jayzhan211


yt-dlp.conf in current folder is ignored when -P is used as command line argument

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.01.21. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
I run yt-dlp from folder ~/tmp/test1, which has a yt-dlp.conf. If I manually use -P ../test2/ to save the files in test2 instead of test1, test1's yt-dlp.conf is not used. If there is one in test2, then that one is applied.
Is this intended behavior? It's illogical to me, so it feels like a bug.
I'm not sure if this have always been the case, I've been using yt-dlp.conf to apply different options depending on the folder I'm in for awhile, but only now had the need to combine it with using -P on the command line.
Verbose log
weird@one:~/tmp % ls -l test1/ test2/
test1/:
total 1
-rw-r--r--  1 weird  weird  20 Jan 23 19:27 yt-dlp.conf

test2/:
total 0
weird@one:~/tmp % cd test1
weird@one:~/tmp/test1 % cat yt-dlp.conf
-o "%(id)s.%(ext)s"
weird@one:~/tmp/test1 % yt-dlp --verbose -P ../test2/ "https://twitter.com/The_Hedonist_6/status/1485224010023591941"
[debug] Command-line config: ['--verbose', '-P', '../test2/', 'https://twitter.com/The_Hedonist_6/status/1485224010023591941']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.01.21 [f20d607b0] (zip)
[debug] Python version 3.8.12 (CPython 64bit) - FreeBSD-13.0-RELEASE-p3-amd64-64bit-ELF
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome, mutagen, websockets
[debug] Proxy map: {}
[debug] [twitter] Extracting URL: https://twitter.com/The_Hedonist_6/status/1485224010023591941
[twitter]<PHONE_NUMBER>023591941: Downloading guest token
[twitter]<PHONE_NUMBER>023591941: Downloading JSON metadata
[twitter]<PHONE_NUMBER>023591941: Downloading m3u8 information
[debug] Sort order given by extractor: res, br, size, proto
[debug] Formats sorted by: hasvid, ie_pref, res, tbr, vbr, abr, filesize, fs_approx, proto, lang, quality, fps, hdr:12(7), vcodec:vp9.2(10), acodec, asr, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info]<PHONE_NUMBER>023591941: Downloading 1 format(s): http-832
[debug] Invoking downloader on "https://video.twimg.com/ext_tw_video/1485223907145695235/pu/vid/678x378/rNeCxeVytLflunU-.mp4?tag=12"
[download] Destination: ../test2/Hedonist - Graham hattrick, Marta assist (this is brutal now) [1485224010023591941].mp4
[download] 100% of 969.86KiB in 00:00
weird@one:~/tmp/test1 % mv yt-dlp.conf ../test2/
weird@one:~/tmp/test1 % rm ../test2/Hedonist\ -\ Graham\ hattrick,\ Marta\ assist\ \(this\ is\ brutal\ now\)\ \[1485224010023591941].mp4
weird@one:~/tmp/test1 % yt-dlp --verbose -P ../test2/ "https://twitter.com/The_Hedonist_6/status/1485224010023591941"
[debug] Command-line config: ['--verbose', '-P', '../test2/', 'https://twitter.com/The_Hedonist_6/status/1485224010023591941']
[debug] Home config "../test2/yt-dlp.conf": ['-o', '%(id)s.%(ext)s']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.01.21 [f20d607b0] (zip)
[debug] Python version 3.8.12 (CPython 64bit) - FreeBSD-13.0-RELEASE-p3-amd64-64bit-ELF
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome, mutagen, websockets
[debug] Proxy map: {}
[debug] [twitter] Extracting URL: https://twitter.com/The_Hedonist_6/status/1485224010023591941
[twitter]<PHONE_NUMBER>023591941: Downloading guest token
[twitter]<PHONE_NUMBER>023591941: Downloading JSON metadata
[twitter]<PHONE_NUMBER>023591941: Downloading m3u8 information
[debug] Sort order given by extractor: res, br, size, proto
[debug] Formats sorted by: hasvid, ie_pref, res, tbr, vbr, abr, filesize, fs_approx, proto, lang, quality, fps, hdr:12(7), vcodec:vp9.2(10), acodec, asr, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info]<PHONE_NUMBER>023591941: Downloading 1 format(s): http-832
[debug] Invoking downloader on "https://video.twimg.com/ext_tw_video/1485223907145695235/pu/vid/678x378/rNeCxeVytLflunU-.mp4?tag=12"
[download] Destination: ../test2/1485224010023591941.mp4
[download] 100% of 969.86KiB in 00:00

Yes, this is correct behavior

Home Configuration: yt-dlp.conf in the home path given by -P "home:<path>", or in the current directory if no such path is given

https://github.com/yt-dlp/yt-dlp#configuration

You can use --config-location yt-dlp.conf to load the file in current dir

Ah, -P without options expands to home:, that explains it.
Right, no short option for the config location, but looks like I can shorten it to --conf . to get the desired behavior, that's not too much to type. Thanks for the tip


Move API outside of the Controller

What does this PR do?
This PR moves the API outside of the Controller and exposes the Topology in the API on the /api/topology/current.
Other changes:

Graceful shutdown of the API
Removed the signals package in favor of Traefik's cmd.ContextWithSignal function.
Changed the output of the API in case of an InternalError. If there's an internal error, the operator should be the only one to see what's the problem by looking at the logs. Users should just be notified that something went wrong.
Removed the handler field of the Controller as it's not needed

How to test it

make test
make test-integration

This PR will fix #494, right?


Add support for basic date functions

Added support for some basic date functionality that is supported by the major DBMSs.

Nice! sorry for the delay on reviewing this - merging & pushing a new version shortly!


Move Java8 tests to basic testsuite instead of separate one

Windows Build 2245 is now running using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a

Linux with security manager Build 2061 is now running using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a

Linux Build 7189 is now running using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a

Linux with security manager Build 2061 outcome was SUCCESS using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a
Summary: Tests passed: 878, ignored: 281 Build time: 0:06:19

Linux Build 7189 outcome was SUCCESS using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a
Summary: Tests passed: 2950, ignored: 353 Build time: 0:45:47

Windows Build 2245 outcome was SUCCESS using a merge of 13ae7c8ae2c6a17882e31dab9b659fbbc860ec1a
Summary: Tests passed: 2948, ignored: 354, muted: 1 Build time: 0:46:34


Create final wireframe/design from this image

Header menu

Index - a button that brings the user to a page that has a list of all the data sets collected, truly an index page, @crdunwel had this idea.
About - this page will create context for the project, tell the story of what we're doing here at Sunlight and most importantly house all Policy Briefs and Blog posts associated with the grant. We do not want to send users back to sf.com to read these briefs and it is grant required that they live with the tool. They should be downloadable by PDF to stay concise and easy to read without taking up a ton of space

Section 1

The marquee section of the homepage page exists here. This should be one line that is both actionable and explanatory in one sentence (work with Jenn T. on this copy). Essentially the text should say something about criminal justice data sets live here and you can search for ________ anything. This line is similar to what slack has done on their homepage, where it encourages the user to fill in the blank. Kind of like Mad Libs. With type treatment, it should be clear they can type in this area and they'll see key words or states rotate, simultaneously showing them what they can search for. This should not be a search both, rather a blank line to fill in.

Section 2

This section has 4 areas that are illustrated offering other types of data sets the user can search for and simultaneously telling the entire story of the CJ system.
The four areas featured are: Arrest, Courts, Corrections and Re-entry.
Below these will be 2-3 links offering the most popular topics within those areas.
This section operates as quick links to learn the type of data they can search for and help appeal to all audiences

Section 3

One or two sentences describing the importance of transparency in CJ data
We also talked about a quote from a reputable source

Section 4

This is an interactive map of the United States of America
the user should be able to scroll and click points on the map to bring them to a search results page of the state they click on
this area also simultaneously serves as a description of the data sets and that you can search by state and engages the user

Section 5

This is where you can learn more about the policy briefs and blog posts
a designer needs to solve how this section should work, should there be a list of posts that bring you to the About page where you can read more? Should you be able to download a few briefs from this area? What is the most effective use of this area?

Nikki,
Just saw this! This is what I was thinking about regarding adding more explanatory documentation. My bad.
-Becca

On Sep 17, 2015, at 1:24 PM, Nikki Grad<EMAIL_ADDRESS>wrote:
https://cloud.githubusercontent.com/assets/10213169/9940328/22f4374e-5d3d-11e5-9eb6-6f306c22b349.jpg
Header menu
Index - a button that brings the user to a page that has a list of all the data sets collected, truly an index page, @crdunwel https://github.com/crdunwel had this idea.
About - this page will create context for the project, tell the story of what we're doing here at Sunlight and most importantly house all Policy Briefs and Blog posts associated with the grant. We do not want to send users back to sf.com to read these briefs and it is grant required that they live with the tool. They should be downloadable by PDF to stay concise and easy to read without taking up a ton of space
Section 1
The marquee section of the homepage page exists here. This should be one line that is both actionable and explanatory in one sentence (work with Jenn T. on this copy). Essentially the text should say something about criminal justice data sets live here and you can search for ________ anything. This line is similar to what slack has done on their homepage, where it encourages the user to fill in the blank. Kind of like Mad Libs. With type treatment, it should be clear they can type in this area and they'll see key words or states rotate, simultaneously showing them what they can search for. This should not be a search both, rather a blank line to fill in.
Section 2
This section has 4 areas that are illustrated offering other types of data sets the user can search for and simultaneously telling the entire story of the CJ system.
The four areas featured are: Arrest, Courts, Corrections and Re-entry.
Below these will be 2-3 links offering the most popular topics within those areas.
This section operates as quick links to learn the type of data they can search for and help appeal to all audiences
Section 3
One or two sentences describing the importance of transparency in CJ data
We also talked about a quote from a reputable source
Section 4
This is an interactive map of the United States of America
the user should be able to scroll and click points on the map to bring them to a search results page of the state they click on
this area also simultaneously serves as a description of the data sets and that you can search by state and engages the user
Section 5
This is where you can learn more about the policy briefs and blog posts
a designer needs to solve how this section should work, should there be a list of posts that bring you to the About page where you can read more? Should you be able to download a few briefs from this area? What is the most effective use of this area?
—
Reply to this email directly or view it on GitHub https://github.com/sunlightlabs/hall-of-justice/issues/38.

@beccasjames no worries :) It was good you said something, I have more notes to share than this. Getting them in issues right now.


Error page view formatting and view model.

Ended up making this into a view model as the logic for the error message isn't trivial.
This isn't complete yet, but I could use a hand 👋

Should be ready for review now. Thanks Sven!

All fixed up, I think.


No response when trying to use as a module

Hi there, I am trying to use json-server as a module with a server.js with the following content
var jsonServer = require('json-server')
var data = require("./generate.js");

var server = jsonServer.create();
var router = jsonServer.router(data());

server.use(jsonServer.defaults);
server.use(router);

router.render = function (req, res) {
  res.jsonp({
    data: res.locals.data
  })
};

server.listen(3000);

with the command line node server.js (json-server is installed globally)
It seems json-server is running, but when I try to access localhost:3000 it seems to be "waiting" indefinitely. Do you have any recommendations on how to troubleshoot?
it works when calling json-server directly from command line
Thanks,
Eric

Hi Eric,
SImply change jsonServer.defaults to jsonServer.defaults() and you should be good :)

Oh dear, thanks for catching that :D


Allow sending directly to a channel (or content?) address

Modify the <WalletSend> component to allow the user to enter a channel handle and/or LBRY URL to allow sending to, instead of just an address.

Do you want the SDK to support this or the desktop app to resolve.
My only concern is for channels that are not yet claimed on YT sync, we don't have a process to transfer extra Lbc outside of tips.

@tzarebczan should close this?

Yep, thanks for the poke!


Incorrect frozen value for interpolated string

# frozen_string_literal: true

p "#{'foo'}".frozen?

should not be frozen

Fixed by https://github.com/ruby/ruby/pull/10454


"Test" mode for telemetry (i.e. write telemetry to console)?

Is there a "test" mode for the gathering of telemetry that doesn't require setting a AI key for an existing Azure resource?  That is, is there a way to see what AI would log (perhaps in the [debugging] console) without having to deploy anything to Azure?
The .NET SDK for Application Insights operates that way, where if a AI key is omitted then telemetry is logged to the console instead.  This is useful for "inner loop" testing of applications as features and telemetry are added.

@philliphoff there is a plan for this SDK to fully support Open Telemetry next semester, as part of that console OpenTelemetry exporter would be available more info here

Is this something that is still on the roadmap?  I ask as this issue has been open for a while and I was looking for this functionality.

@philliphoff  Following code could achieve what you are looking for with current version of the SDK
`
appInsights.setup("123").start();
appInsights.defaultClient.addTelemetryProcessor((envelope) => {
console.log(envelope);
return false; // Data will not be sent
});
`

"123" as AI key Is valid  ? @hectorhdzg or perhaps applications insights will be disabled as is an invalid key ?

@jpolvora regex validating the iKey is available [here](https://github.com/microsoft/ApplicationInsights-node.js/blob/develop/Library/Config.ts#L198, "123" is not valid but you can use dummy ones like "00000000-0000-0000-0000-000000000000", the important part here would be the telemetry processors preventing all telemetry to be sent.


[Match] Platform Provisioning Profile Support

This is the Match portion of the following issues and pull requests.
Match portion of #3600.
Also fixes:
fastlane/match#104
fastlane/match#108
#1992
This depends on #3826.
I also had to nuke my match repo before running the new version since the files are now stored with the platform in the name.

Closing this with the same idea as https://github.com/fastlane/fastlane/pull/3825.


[CI] Adopt GitHub actions

Motivation
We want to migrate all of repositories to use GitHub Actions.
Modification
This PR adopts GH actions in this repo.
Result
New and shiny CI.

@Lukasa @simonjbeaumont this PR is ready. I have split this into multiple commits to make it easier to review


Remove pagination from docsearch endpoints to test performance

@ericholscher I dont think the pagination was the root cause of the timeout. what do you think?

I think we must need to use it in future. becasue when people scroll down, they should see more results. So better to keep it in the API end and change it in frontend at future.


scopesArray.map is not a function

Hello, started a fresh project using shopify-cli 3.45.0, I got this error: scopesArray.map is not a function.
https://github.com/Shopify/shopify-api-js/blob/4065ecc71ce7675ebad9c968824a0c61dca0f0cd/lib/auth/scopes/index.ts#L7
https://github.com/Shopify/shopify-api-js/blob/4065ecc71ce7675ebad9c968824a0c61dca0f0cd/lib/auth/scopes/index.ts#L18
There is a check for if scopes arguments is a string and else it sets the arguments to scopesArray however scopes argument is not an an array nor a string in this case.
If you check the types of the argument, it is actually string | string[] | undefined.
Caller of this function is session.isActive method and variable it is passing to call has type AuthScopes | string | string[].
https://github.com/Shopify/shopify-api-js/blob/4065ecc71ce7675ebad9c968824a0c61dca0f0cd/lib/session/session.ts#L93
I am not sure how typescript is able to compile this. So there is an issue here.
I can provide any additional information.

I found what the issue is, in the instance of check at the
https://github.com/Shopify/shopify-api-js/blob/4065ecc71ce7675ebad9c968824a0c61dca0f0cd/lib/session/session.ts#L92
check return false because 2 instances are not the same.
I checked the functions locations of them and here is the difference.
./web/node_modules/@shopify/shopify-api/lib/auth/scopes/index.js:5
./node_modules/@shopify/shopify-api/lib/auth/scopes/index.js:5
I did not cd into web and install or anything.
What should be the resolution do you think?

Guys this was my mistake,
I just ran yarn add @shopify/shopify-app-session-storage-postgresql in the parent folder. Which installed this package to root folder instead of web folder. That was the reason instance of session and constructor inside the session.isActive were not the same.
Session object is coming from config.sessionStorage.loadSession which I am providing a root level dependency wrongly. Maybe we can put an advanced message to there because we can detect it at the point I was confused.


Demo page now shows code

😊

@cowboyd I added code that should update the demo app on merge to master


[TextField] Add password example to docs

Adds an example of how to create a Password textfield to the docs.

Thanks!

😃


Update datapoints

circulation pump (best guess and tested)
energy input/output statistics (best guess and tested)

Thanks for your effort - I was just working on these datapoints as we speak ...
I've created an O3EArray datatype - so I could describe the energy consumption datapoints better:
1294 : O3EComplexType(124, "EnergyConsumptionCentralHeatingMonthMatrix",[O3EArray(62, "CurrentMonth",[O3EInt16(2,"DailyUse")], arraylength = 31), O3EArray(62, "LastMonth", [O3EInt16(2,"DailyUse")], arraylength = 31)]),
I made also an update for datapoint 497
497 : O3EComplexType(5, "DomesticHotWaterCirculationPumpMode",[O3EByteVal(1, "Mode"), O3EByteVal(1, "HygenieActive"), O3EByteVal(1, "HeatingActive"), O3EByteVal(1, "Unknown"), O3EByteVal(1, "Cycles")]),
Result:
python3 Open3Eclient.py -c can0 -dev vcal -r 497
{'Mode': 4, 'HygenieActive': 0, 'HeatingActive': 0, 'Unknown': 0, 'Cycles': 3}

I was looking over your PR  - one comment first: you made a lot of changes and that required a lot of typing :-D.
Some of the models are incomplete - all monthly datapoints contain data for the current and the previous month (2 bytes per day)
same for the yearly datapoints - the current year and previous year (4 bytes per month)
... small effort to update the datapoints (mainly copy and paste)
but I'm not sure which way would be better - complex type as you did or my array approach - so I would wait for more input from other developers or users.

Thanks for your effort - I was just working on these datapoints as we speak ... I've created an O3EArray datatype - so I could describe the energy consumption datapoints better:
1294 : O3EComplexType(124, "EnergyConsumptionCentralHeatingMonthMatrix",[O3EArray(62, "CurrentMonth",[O3EInt16(2,"DailyUse")], arraylength = 31), O3EArray(62, "LastMonth", [O3EInt16(2,"DailyUse")], arraylength = 31)]),

Ah, I didnt realize that it is also data from the previous month. Your solution is much better then.

I made also an update for datapoint 497 497 : O3EComplexType(5, "DomesticHotWaterCirculationPumpMode",[O3EByteVal(1, "Mode"), O3EByteVal(1, "HygenieActive"), O3EByteVal(1, "HeatingActive"), O3EByteVal(1, "Unknown"), O3EByteVal(1, "Cycles")]),
Result: python3 Open3Eclient.py -c can0 -dev vcal -r 497 {'Mode': 4, 'HygenieActive': 0, 'HeatingActive': 0, 'Unknown': 0, 'Cycles': 3}

I tried it by reverse enginieering. Where did you get that info?
Seems my attempt is rather incomplete. So lets wait for some more comments.

A good source:

You may find a link in the Viessmann customer forum ...


Create Issue Templates

Hey John, I have created the issue templates for 'Bug Report', 'Feature Request' and 'Support Request'. The one thing I could not set up on them was adding the 'auto assign' function to auto assign each issue to yourself on creation; if this is something you want then you will have to add it yourself later in your master version (I can show you how). I have also done a bunch of broken link fixing for you too :)

Wahoo!  I'll take a look shortly.  Need some quick meds to take affect.
I'm surprised the License is broken.  There are link template references at
the bottom. I do know testing links in markdown files are one of my most
hated things.  Not until they are rendered on GitHub do you actually know
if they work.
ttfn,
John
On Wed, Feb 3, 2021 at 9:18 AM Mitch Williams<EMAIL_ADDRESS>wrote:

Hey John, I have created the issue templates for 'Bug Report', 'Feature
Request' and 'Support Request'. The one thing I could not set up on them
was adding the 'auto assign' function to auto assign each issue to yourself
on creation; if this is something you want then you will have to add it
yourself later in your master version (I can show you how). I have also
done a bunch of broken link fixing for you too :)
You can view, comment on, or merge this pull request online at:
https://github.com/ztalbot2000/homebridge-cmd4/pull/87
Commit Summary

Create issue templates.
Fixed broken link to Developers Guide
Fix broken link to LICENSE.
Fix links to 'raw' text versions of links.
Fix broken link to LICENSE.
Fixed broken link to Developers Guide.

File Changes

A .github/ISSUE_TEMPLATE/bug-report.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-5870a741e2fa8d0b03a88d7b036d408ee7e6954051fcc5d7978269bf6d1ff242
(53)
A .github/ISSUE_TEMPLATE/feature-request.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-e9349fad824a042e877a9a2f15d475a1fb691346b70711c916e495542e2e6e5e
(24)
A .github/ISSUE_TEMPLATE/support-request.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-0295edee17f249f822f63fbcc40bc27915b1f4bc8126da1008910da5ec89b6ef
(49)
M ChangeLog.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-874f33563125619a7a5cb567ebe523c59258662d69858d78d24d947b275f9c6c
(2)
M README.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(2)
M docs/AdvancedTroubleShooting.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-9bf34ec99aded08f9d4d14cbea07c1c764529b60a80c4236a9e0b3160bcc1a3f
(2)
M docs/Developers.md
https://github.com/ztalbot2000/homebridge-cmd4/pull/87/files#diff-13b6f3ddda58b9c3a0e3a5cba743494204511e365bec2343809adea58ef8c750
(12)

Patch Links:

https://github.com/ztalbot2000/homebridge-cmd4/pull/87.patch
https://github.com/ztalbot2000/homebridge-cmd4/pull/87.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ztalbot2000/homebridge-cmd4/pull/87, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSBCX777MI7LRP5IS73AFLS5FLNBANCNFSM4XA52L4A
.

The license links were referring to the 'docs' directory when I looked at the url; but it is actually in the 'master' directory. And for any links that were 'raw', they just needed to be substituted for 'blob'. I know it is minor, but really happy to help contribute something small to this repo as it and yourself have contributed so much to my work and learnings.

I was not up to looking at what you did.  I just merged it all as I trust you.  I'll look later.  thanks ever so much


Check PHP 8 compatibility

curl_close not supported anymore. Should be changed to unset.

See commit https://github.com/db-EV/ZoePHP/commit/430823b8d69b5709811844ef646f1be5c28a59ca.

Fixed in https://github.com/db-EV/ZoePHP/releases/tag/20220316


is there any file to introduce parse-server's architecture?

I want to learn and extend parse-server for some reason, but a little confused to how to begin. if there is some wiki about parse-server's architecture, it will help me so much.
thx.

Yes @oblank - in the wiki you can find more information.
For general instructions on how to deploy Parse Server, you can take a look here. If you want to know more on how the architecture works, read the Development Guide.

thx @natanrolnik


gardenlet: Prevent transient errors of type duplicate filename in registry

How to categorize this PR?

/area ops-productivity
/kind bug
What this PR does / why we need it:
Explanations for the errors from: https://github.com/gardener/gardener/issues/8461
Currently components like VPA, kube-state-metrics, cluster-identity have the managedresources.Registry as a struct field:
https://github.com/gardener/gardener/blob/3de1a044951e695cc8066f94da0c57dddd2ce44a/pkg/component/vpa/vpa.go#L90
It means that the managedresources.Registry is shared across multiple invocations of the Deploy func.
The Deploy func can be invoked many times as we run the corresponding task with a RetryUntilTimeout:
https://github.com/gardener/gardener/blob/6f8ce7692f793e583734f533cfdee7b9d93fb815/pkg/gardenlet/controller/shoot/shoot/reconciler_reconcile.go#L419
The flow is:

Deploy of the component gets called
In the component registry.Add(...) is called and resources are added in the registry's map
After the registry.Add(...) the component fails with another (transient maybe) error
Deploy of the component gets called again due to the RetryUntilTimeout of the flow task
registry.Add(...) is invoked again for the same resources and for the same registry (registry is shared as outlined above). This fail with duplicate filename in registry until the task times out. Then the whole flow is retried.

Which issue(s) this PR fixes:
Fixes https://github.com/gardener/gardener/issues/8461
Special notes for your reviewer:
N/A
Release note:

An issue causing several tasks from the Shoot reconciliation flow to fail with transient errors of type `duplicate filename in registry` is now fixed.

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

Shouldn't we cherry-pick this to older versions?

/cherry-pick release-v1.79

/cherry-pick release-v1.78

/cherry-pick release-v1.77


Full stack server fuzzer

With initial corpus ready to go - generated from the bad_client suite.
Built on #6066
Built on #6080

Should be ready for review.

I don't have anything bad to say about that PR, except it now requires an upstream merge.

Trivially merged.
On Wed, Apr 6, 2016 at 10:24 AM Nicolas Noble<EMAIL_ADDRESS>wrote:

I don't have anything bad to say about that PR, except it now requires an
upstream merge.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/6071#issuecomment-206474761


Missing config for volumes and volumeMounts on policy-controller webhook deployment

Description
Being able to specify custom volumes and volumeMounts in the policy-controller webhook deployment will allow for adding custom CA certificates. This is required for situations where a tuf-mirror is only available through a repo mirror such as Artifactory with a custom CA certificate.

@xanderjjj Just to confirm the requested functionality: do you want to add additional volumes or replace the existing ones https://github.com/sigstore/helm-charts/blob/main/charts/policy-controller/templates/webhook/deployment_webhook.yaml#L113 ?

@hectorj2f I was thinking just additional volumes like in PR #399

Sure, we can add that option.


Add filter method

Scala's Option has a filter method that is useful. I've found myself shimming this method for this library, so thought it might be worth including directly.

Sorry if I'm missing something in the review process. I noticed that the "Changes requested" label is still up. Let me know if I need to do something on my end besides pushing the changes!


[Question] Choice of training epochs

Hi authors, thanks for this amazing project!
I'm wondering how the choice for 300 training epochs was made? In the previous DP3 paper tasks were trained for more than 300 in some cases even for 3000 epochs. Also wondering why there is such a difference
Thank you!

Hi, thank you for your interest. The 300 epochs are the same as Bunny-VisionPro paper. This is just mainly because 300 epochs are sufficient, so to save time we do not train more.


Consider typecasting

There are a limited number of cases where it would be helpful to implicitly cast, e.g. Group -> Round, Round -> Event.
Be careful with extending this too far, e.g. Number -> String could break Add().

I'm pretty nervous about this, I would prefer sticking to explicit conversions.


About the algorithm 1 in the paper.

You had written about the reason why using the stopping criteria.
But I am confused about the "if " in the repeat loop.
Why stop when finding the current path has a higher gain than the last?

This algorithm estimates the order of the largest path.
If an estimated path gain is higher than the previous estimated path gain, it means that the previous estimation is not perfect and makes an estimation error or the remaining paths that has not estimated is small enough.  If you don't stop the estimation here, the algorithm never stop.

When the condition occurred, the previous estimation probably had an error. Which may cause the following doppler will be wrong, so we need to jump to the next delay.

You are right.


[Possibly system specific] Wild (12% vs 20%) run-to-run swings in multiple-cpp reported scores

This issue is currently blocking for me, so I am looking into it myself. I would really appreciate any potential help with investigating/isolating this issue. I'm happy to do everything I can to help reproduce.
Full logs for two consecutive runs here. The first run got pass@1 of 12%, the second run got pass@1 of 20%. They were ran on the same system with the same invocation.
System Information
Ubuntu Linux
Lambda Labs Instance: 1x A10 (24 GB PCIe) (30 CPU cores, 205.4 GB RAM, 1.5 TB SSD)

On a fresh instance, I'm consistently getting 38.5%. I suspect the problem was specific to my system.


Ambiguous message presented when test name contain /

The message presented by Maven Client that runned suite with Test containing / in the name doesn't say the reason correctly:

[ERROR] ... Failed to process test suite: Not Found -> [Help 1]

Message should be:

[ERROR] At least one of the Tests in the suite contain unsupported character. Please check and rename tests containing special characters.<

Currently, after the changes in #183 the message looks like:
[ERROR] Failed to schedule test suite: '[Status: 400] Something is wrong with your suite definition! Value 'first/test' of attribute name in test does not match pattern [a-zA-Z-_0-9]+!'
I believe this is self-exploratory now so closing this issue.


System._loader.moduleRecords doesn't contain .jst/.json files.

I'm trying to do a reload when my templates (.jst) change. They don't seem to be in moduleRecords, they are however in System._loader.modules. But System.delete only deletes from moduleRecords.
Does anybody know why the .jst files are in .modules, but not in .moduleRecords?
The modulename from one template is resolved to:
<EMAIL_ADDRESS>

@happylinks that is how the loader plugins work. SystemJS being a shim of system-loader spec, it stores ES6 modules in moduleRecords and the rest in System._loader.modules.
I haven't really tested HotReloader with plugins yet. I will try that.
Which loader plugin for .jst are you using?

Hi, I'm using this one: https://github.com/podio/plugin-jst
Ok, do you know if there is another way to "System.delete" a source that is not in moduleRecords?

@guybedford would definitely know.
I have been looking at plugins before, like 3/4 months ago. I don't remember exactly how it ended. I was trying to make commonJS modules work with hot reloader. They are stored in System._loader.modules as well.

For plugins that are configured via meta configuration, these should work completely fine in the hot reloader today.
For example, the CSS plugin can provide an __unload export method for every CSS file, which would remove the CSS, before the new CSS is injected allowing CSS hot reloading.
So I believe it's just plugins via syntax that would need special support here.
In order to handle that, given the normalized module name being hot reloaded (http://path/to/module.js), we just then include iteration of the entire registry to find any modules of the form http://path/to/module.js!*. Those modules should then all be hot reloaded as well.
I think that should cover the use cases, but let me know if I have missed anything here.

Note that plugins via syntax is something that is being deprecated though, so I'd almost be happier if this wasn't supported to encourage the configuration style.

(It's not being explicitly deprecated, it's just being discouraged)

@guybedford thanks! Gonna try CSS modules first. Is there any example with css loader being configured via meta configuration? Would love to try it out.

@capaj sure, it would just be via the standard workflow like in https://github.com/systemjs/systemjs/blob/master/docs/overview.md#basic-use. Happy to integrate an __unload method into https://github.com/systemjs/plugin-css/blob/master/css.js too if you want to try a simple use case.

@guybedford yeah, I always keep forgetting about systemjs docs. Sorry!
I will try to integrate __unload into css plugin and open a PR if you don't get to it before me.

I'll look into this for jst templates. Or is that what you mean with "plugins via syntax". Or just plugins that aren't loaded via meta configuration?
Thanks for the quick reactions!

@happylinks yes exactly, it should work for jst templates as well (in theory!), so do post back if you see any issues.

Hey, I've been trying to fix this today but I don't seem to be making progress.
Couple of questions:
I've followed https://github.com/systemjs/systemjs/blob/master/docs/overview.md#basic-use to set up the plugin using the meta-config. In this example it seems as if I don't need to use the ! at the end of the import path to be able to import the file. I can't get this working at all, it always adds the .js at the end when trying to import.
Is this a documentation error or should it really be possible to not use the "!" ?
When I do add the ! the file is loaded correctly, but then I don't need the meta configuration so I think the hot reloading won't work then, because the file gets loaded in System._loader.modules instead of Sytem._loader.moduleRecords.
I also tried this with the json plugin but got the same results.
Can you give me some pointers? I would love to fix this!

Ok, got a little farther.
true
<EMAIL_ADDRESS>lib$es6$promise$promise$$Promise {_id: 294, _state: undefined, _result: undefined, _subscribers: Array[0]}

I'll see where this gets me!

I'm close!
When I run
<EMAIL_ADDRESS>
and then
System.import("http://localhost:8080/src/modules/activities/templates/layout.jst!http://localhost:8080/jspm_packages/github/podio/plugin-jst@0.1.2.js").then(source => {console.log(source)});

It loads the new template.

Mm nope, didn't work.
I got as far as reloading the template.
System.delete works fine for the templates with "!".
I disabled the check at https://github.com/capaj/systemjs-hot-reloader/blob/master/hot-reloader.js#L170 so it would add the templates to the reload-list and call System.import again. But this caused the following problem: there is no importers list for these templates. So the modules that reference the template don't get reloaded as wel, so they won't have the new template.
I'm not sure if I did the loading of the templates ok with the meta configuration and stuff, but they don't go in the moduleRecords, and because of that I think that they don't contain the information to make a successful hotreload.

@happylinks perhaps try using a config along the lines of the following to avoid extensions:
System.config({
  packages: {
    'src/modules/activities': {
      meta {
        '*.jst': { loader: 'path/to/jst-loader-name' }
      }
    }
  }
});

Yeah! that works, thanks! I'll try to see if I can get any further with the hot reloading now :+1:

IT WORKS! Thank you so much, my templates are hot reloading perfectly now.
I used this config to be able to remove the "!" from the imports:
packages: {
    "src": {
      "meta": {
        "*.jst": {
          "loader": "jst"
        },
        "*.json": {
          "loader": "json"
        }
      }
    }
  },

And in my main javascript file i have the __reload which reload the current route (with the fresh templates).
export function __reload(deletedModule) {
  setTimeout(function() {
    NavigationService.reload();
  }, 100);
}

It has a small timeout because it seems sometimes not all templates/files are loaded yet before the __reload is called.
Thanks for your feedback!

@guybedford in comment https://github.com/capaj/systemjs-hot-reloader/issues/31#issuecomment-167436950 you're missing a : behind meta.

@peteruithoven fixed so that people don't get syntax errors when copy pasting


Consistently use Line Feed  without Carriage Return  in generating SSE

fixes # 219

Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

Makes sense, thanks.


inset lists different compat data than MDN, despite claiming to fetch from MDN

Safari 14.1 supports inset, MDN is correct: https://developer.mozilla.org/en-US/docs/Web/CSS/inset#browser_compatibility
However, caniuse does not include that: https://caniuse.com/mdn-css_properties_inset
Testcase: https://codepen.io/leaverou/pen/PopQWWp
I thought it may be a cache issue, but the MDN compat data has not been updated in over a month: https://github.com/mdn/browser-compat-data/blob/main/css/properties/inset.json

Hi @LeaVerou 🤩
This is what I'm seeing:

Is that the correct state?

Yes, it is. And now it looks correct to me too.  Either way, I'm closing this, thanks!


Safari 12 support

Version 1.13 is no longer supported in Safari 12.0 and later.

Version

[ ] Version 1
[ ] Version 2

My Problem

v2.0.0 supports Safari 12, you just need to build it yourself.


Fix to cta button so it's not appearing outside it's container.

[EN] Feedback for: /fundamentals/input/form/choose-the-best-input-type.html #1245
https://developers.google.com/web/fundamentals/input/form/choose-the-best-input-type
Fixes cta button appearing outside container.

I signed it!