[BUG] Unable to add nodepool with windows image to GKE via UI / Rancher UI is missing windows with containerd image options for GKE

Rancher Server Setup

Rancher version: v2.8.0-alpha2
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): k3s 1.26.9+k3s1

Proxy/Cert Details: Rancher's generated CA

Information about the Cluster

Kubernetes version:  v1.27.3-gke.100
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Rancher provisioned GKE

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

Admin

Describe the bug

Rancher does not allow to add a nodepool with windows image via UI.
To Reproduce

Create a GKE cluster from Rancher with a nodepool using Container-Optimized OS with containerd.

Wait for the cluster to become active.

Add a nodepool using imageType Windows Long Term Service Channel.

Result
Rancher returns error:
Googleapi: Error 400: Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24. Details: [ { "@type": "type.googleapis.com/google.rpc.RequestInfo", "requestId": "0xe4c56599502f507c" } ] , badRequest
Expected Result

Rancher should be able to add the new nodepool of windows type.
Screenshots

Additional context

Adding a nodepool with the same image type from GCloud, works as expected, and Rancher is able to update the config, but it does not show the image type in UI (see the second screenshot).
The underlying problem might be that UI Images do not point to appropriate images.
For e.g. Nodepool added via cloud console, uses Windows Long Term Servicing Channel with containerd (windows_ltsc_containerd), while the one added via Rancher uses Windows Long Term Servicing Channel without containerd (windows_ltsc), and there are no other windows with containerd options available on rancher.
Nodepools yaml

    nodePools:
      - autoscaling:
          enabled: true
          maxNodeCount: 3
          minNodeCount: 1
        config:
          diskSizeGb: 100
          diskType: pd-standard
          imageType: COS_CONTAINERD
          machineType: n1-standard-2
          oauthScopes:
            - https://www.googleapis.com/auth/devstorage.read_only
            - https://www.googleapis.com/auth/logging.write
            - https://www.googleapis.com/auth/monitoring
            - https://www.googleapis.com/auth/servicecontrol
            - https://www.googleapis.com/auth/service.management.readonly
            - https://www.googleapis.com/auth/trace.append
        initialNodeCount: 2
        management:
          autoRepair: true
          autoUpgrade: true
        maxPodsConstraint: 110
        name: default-pool
        version: 1.24.17-gke.2113000
      - autoscaling: {}
        config:
          diskSizeGb: 100
          diskType: pd-balanced
          imageType: WINDOWS_LTSC_CONTAINERD
          machineType: n1-standard-2
          oauthScopes:
            - https://www.googleapis.com/auth/devstorage.read_only
            - https://www.googleapis.com/auth/logging.write
            - https://www.googleapis.com/auth/monitoring
            - https://www.googleapis.com/auth/servicecontrol
            - https://www.googleapis.com/auth/service.management.readonly
            - https://www.googleapis.com/auth/trace.append
          taints:
            - effect: NO_SCHEDULE
              key: node.kubernetes.io/os
              value: windows
        initialNodeCount: 3
        management:
          autoRepair: true
          autoUpgrade: true
        maxPodsConstraint: 110
        name: pool-1
        version: 1.24.17-gke.2113000
      - autoscaling: {}
        config:
          diskSizeGb: 100
          diskType: pd-standard
          imageType: COS_CONTAINERD
          machineType: n1-standard-2
          oauthScopes:
            - https://www.googleapis.com/auth/devstorage.read_only
            - https://www.googleapis.com/auth/logging.write
            - https://www.googleapis.com/auth/monitoring
            - https://www.googleapis.com/auth/servicecontrol
            - https://www.googleapis.com/auth/service.management.readonly
            - https://www.googleapis.com/auth/trace.append
        initialNodeCount: 1
        management:
          autoRepair: true
          autoUpgrade: true
        maxPodsConstraint: 110
        name: pool2
        version: 1.24.17-gke.2113000
      - autoscaling: {}
        config:
          diskSizeGb: 100
          diskType: pd-standard
          imageType: WINDOWS_LTSC
          machineType: n1-standard-2
          oauthScopes:
            - https://www.googleapis.com/auth/devstorage.read_only
            - https://www.googleapis.com/auth/logging.write
            - https://www.googleapis.com/auth/monitoring
            - https://www.googleapis.com/auth/servicecontrol
            - https://www.googleapis.com/auth/service.management.readonly
            - https://www.googleapis.com/auth/trace.append
        initialNodeCount: 1
        management:
          autoRepair: true
          autoUpgrade: true
        maxPodsConstraint: 110
        name: windowspool
        version: 1.24.17-gke.2113000

Seems duplicate of https://github.com/rancher/gke-operator/issues/120


[a11y] Ensure buffer is initialized before interacting with it

Summary of the Pull Request
Adds a check before every UIA function call to ensure the terminal (specifically the buffer) is initialized before doing work. Both the ScreenInfoUiaProvider and the UiaTextRange are now covered.
References
Closes #11135
#10971 & #11042
Detailed Description of the Pull Request / Additional comments
Originally, I tried applying this heuristic to all the RuntimeClassInitialize on UiaTextRangeBase with the philosophy of "a range pointing to an invalid buffer is invalid itself", but that caused a regression on MSFT 33353327.
IUiaData also has GetTextBuffer() return a TextBuffer&, which cannot be checked for nullness. Instead, I decided to add a function to IUiaData that checks if we have a valid state. Since this is shared with Conhost and Conhost doesn't have this issue, I simply make that function say that it's always in a valid state.
Validation Steps Performed

[X] Narrator can detect newly created terminals
[ ] (On Windows Server 2022) Windows Terminal does not hang on launch

@miniksa made an update to the branch (added comments and initialization checks in ScreenInfoUiaProviderBase). You said ScreenInfoUiaProviderBase::GetSelection was the culprit, so you'll need to test this build on the VM.
Once we verify that this works on Windows Server, this'll be out of draft.

I've done a manual test on https://microsoft.visualstudio.com/c93e867a-8815-43c1-92c4-e7dd5404f1e1/_build/results?buildId=39411475 on the Windows Server 2022 machine by launching the Terminal built with these changes using the tablet input keyboard and it loads up normally.

@miniksa we should be able to just cherry-pick this into 1.10 too

https://microsoft.visualstudio.com/c93e867a-8815-43c1-92c4-e7dd5404f1e1/_build/results?buildId=39422176 works on the Windows Server 2022 machine by launching the Terminal built with these changes using the tablet input keyboard and it loads up normally. (Verified)


chore: bdd-spring-1584723829 to 0.0.1

chore: Promote bdd-spring-1584723829 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


mkdocs autorefs

mkdocs in strict mode failsn because a new warning has popped up about multiple autorefs.
The same issue is seen in oteapi-core.
In order to maintain a homogeneous way of documenting the oteapi ackages provided by SINTEF this should be solved in oteapi-dlite after a solution hasbeen chosen by oteapi-core.

This also is connected to another issue with mkdocs_autorefs==1.2.0.
Here it tries to automatically resolve the reference and find the closest,
but I get the followin error:
ERROR   -  Error building page 'all_strategies.md': 'dict' object has no attribute 'resolve_closest'
This behaviour is currently turned off by the following lines in the mkdocs.yaml:
plugins
...
...

autorefs:
resolve_closest: false


[Feature Request] Parse HTML/Links from Notes

Really liking the Supplies section where I can keep a list of part numbers for supplies like oil filters, wiper blades, etc for each vehicle. I'm dropping in html (primarily amazon links) to where I typically purchase the parts so it's easier to re-order in the future. Would be great if there was a way to just click either in the Supplies listing page a 're-purchase now' button, or click into the supply and have the HTML be parsed and clickable to take me the product on Amazon or anywhere else.

I've added markdown parsing for the notes section in records. It's not perfect but it does allow URLs to be parsed. You just have to format them like so, and then click the "Markdown" button next to the Notes label

Nice! I’ll test that out. Thanks for adding that so fast!

@rtrickett337 no problem! I just tweaked it even further so that it now shows it as an overlay over the original note window instead of a popup.

Yeah so that seems to work ok. I was thinking it would save the markdown version, but instead each time the record is opened, the markdown button has to be clicked to re-format the notes and get the URL.

@rtrickett337 I've added a user setting to load the notes in markdown if enabled and the notes field isn't blank.

With this enabled, every time you pull up an existing record, the notes will be displayed in markdown format.

That's perfect! And it can easily be turned off with the markdown button on each note if you need to add more to the notes field. I like it!


What to do about 64x128 Resolution?

Currently I have no way to test 64x128 Resolution.  I removed the 64x128 logic from the code source files I used.
It might be a better approach to restore deleted 64x128 logic to original graphics assembly source files so they match the originals.  And then add commented out conditional assembly logic for 64x128 resolution with comments noting that the code has not been tested.
The logic for 64x128 should follow the 64x64 and 64x32 logic, except the  y values are twice those for 64x64 and four times those for 64x32.  But I'm uncomfortable to release code that I cannot test.

Well I coded it, but I wasn't very happy with not being able to test the results.  I can't really tell if what I coded worked or not.
Maybe the underlying graphics code isn't quite what I expected at 64x128 or maybe there is an issue with the code I wrote.  I can't really debug anything having only 64x64 resolution available.   So I am going to close this issue.

I figured out a way to debug 64x128.  The Pixie Video simulator will sample every other pixel row at 64x64, so 64x128 will show up mangled, but at least one can count rows.  I created the code update and tested it as best I can at 64x128 resolution.
I did find and fix one issue with the underlying DrawSprite routine in Graphics1861.asm.  The routine wasn't calculating the y offset correctly for 64x128 resolution.  I updated the routine with the same logic approach used to calculate the y offset value for 64x128 resolution.

The code updates are now pushed to the b_add_64x128_res branch and are ready to merge.


make: makefile: line 15:  Error -- Badly specified macro for windows

Hi,
I tried to build this project via windows and when i ran the make build command. I got this error. Please help:
make: makefile: line 15:  Error -- Badly specified macro
I think, i tried to replace $ with % and some how it skipped this line error but followed by line 21. Is there any window compatible Makefile which can solve this problem or i need to do this in some other way.
Thanks,
Atul

Which version and variant of make are you using?

Closing due to lack of response.


table edit default behavior

resolves #557
resolves #1488
import pandas as pd

from taipy.gui import Gui

def get_table():
    dic = {"key": [1,2,3], "Value":[3,4,5]}
    return pd.DataFrame(dic)

table = get_table()
page_content = """
<|{table}|table|show_all|editable|not on_add|>
"""

pages = {"content": page_content}

gui = Gui(pages=pages)
gui.run(title="557 Table default edit")

Thank you for implementing this. That's great.
A few questions, based on the example you gave:
<|{table}|table|show_all|editable|not on_add|>

By default, the table is not editable, right?
What is the not on_add property? What is its default behavior and the default values for each column?

Thanx

Replies in the issue #557


Adapt to new ses_config structure

The ses_config was changed in this tooling to match the latest
ardana changes. Therefore the set_fact would fail to get the proper mon
hosts.
This should fix the set_fact (when the user is not overriding its
value with extravars), for the new structure.

If you don't provide your own suse_osh_deploy_ceph_mons list, this should fix it.


Upgrade govuk-lint to 4.0.0 and fix all offenses

https://trello.com/c/5gGKhhEy/1337-fix-linting-issues-in-apps-that-arent-100-clean-yet

Of course this has way more things that make RuboCop sad inside the individual app directories. :-(

There's still more Rubocop sadness. I'll close this PR and re-open it when it's really ready.


Fix #15 - Change order of the entities

Move the CloseCurlyQuote and CloseCurlyDoubleQuote to be after rsquo and rdquo, so for encoding will be used right pair of the entities rsquo - lsquo and rdquo - ldquo, and it will keep possibility to decode entities CloseCurlyQuote and CloseCurlyDoubleQuote

adding checks does the passed string exists - to prevent error form trying to obtain property length of undefined

Coverage remained the same at 94.611% when pulling 275b6d084c4152f5adb5024af82fe555db26a0fc on Kiwka:master into 3a2cd397697c872325f526bb422bdee74f089cda on mdevils:master.

Coverage remained the same at 94.611% when pulling df11b5acbaa1fcc3ccd9032583b21143449a216f on Kiwka:master into 3a2cd397697c872325f526bb422bdee74f089cda on mdevils:master.

Hello @Kiwka,
Thank you very much for contributing.
Can you please provide some examples before/after. It's hard to understand the change otherwise.

Hi @mdevils
This is the fix for the opened issue https://github.com/mdevils/node-html-entities/issues/15 in this project. The description includes use case of the wrong behavior.
Example: entities.encode('‘Single opening curly quotes’ seem just fine');
Before fix: "‘Single opening curly quotes’ seem just fine"
After fix: "‘Single opening curly quotes’ seem just fine"

Thank you for your contribution.

Published in version 1.2.1.


Example borken

On the https://deno.land/std/manual.md page is the example
deno install --allow-net --allow-read file_server https://deno.land/std/http/file_server.ts

With latest Deno installed you get
Found argument '--allow-net' which wasn't expected, or isn't valid in this context

USAGE:
    deno install <exe_name> <cmd>...

When you figure out to swap the location of the flags and it builds it starts getting errors. First one:
error TS2339: Property 'readdir' does not exist on type 'typeof Deno'.

► https://deno.land/std/http/file_server.ts:9:21

9 const { args, stat, readdir, open, exit } = Deno;

Using
deno 0.31.0
v8 8.1.108
typescript 3.7.2

You seem to be using an old Deno version (0.31.0). The latest is 0.37.1.
You can also use the file server locked at version 0.31.0:
deno install --allow-net --allow-read file_server<EMAIL_ADDRESS>

@lucacasonato Thank you for looking into this.
Hmm. This is strange. I upddates with curl -fsSL https://deno.land/x/install/install.sh | sh but still have 0.31.0
Am I meant to install in a different way?

What is the output of which deno?  Also, you can try /Users/mrw/.local/bin/deno --version

Ohhh - look. It did get installed! Have we changed where its installed? LIke, is this because installation location have changed since I installed it the first time?

@mathiasrw probably a homebrew install

Thanks. Ill find a way.


Treat KDoc @propertys as special types of @params, fixes #431

Treat @property the same as @param (which matches the description in the KDoc documentation). This fixes an incompatibility between ktfmt and detekt's formatting rules.

We apologize for the delay. Thanks a ton for the contribution!


exports not found in library for angular-cli AOT

Hi there! Looking for some help.
When combining a library with<EMAIL_ADDRESS>and AOT, I get an error saying that exports from my Library are not being found.
I run the command:
ng serve -aot

And get a response to:
** NG Live Development Server is running on http://localhost:4200 **
Hash: 1d6060529867a24e1764
Time: 33825ms
chunk    {0} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 233 kB {4} [initial] [rendered]
chunk    {1} main.bundle.js, main.bundle.js.map (main) 833 kB {3} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 11.7 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 4.86 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

WARNING in ./src/$$_gendir/app/app.module.ngfactory.ts
84:22-28 "export 'ɵb' (imported as 'i23') was not found in '@svrf/web'

[... additional similar WARNINGs...]

webpack: Compiled with warnings.

PS great generator! Thanks a ton for this!

To give us a better view of your problem, please provide a demo or repo url 👍

@brentchow — Is it possible to share your code?
@xxxtonixxx — Thank you for your help, much appreciated! 👍

Hi,
I have the same problem, if I export all, the build it's ok, but I in my module I don't want export my services. It is possible?

I am experiencing a similar problem, with a somewhat arbitrary feel to it:
In my library several interfaces/types are defined in separate files in a \shared folder. They are all re-exported through a barrel index.ts for consumption in various components across the Angular modules in the library. Re-exports in the barrel use `export * from './xyz.interface`` notation.
Only one of the interfaces (margin.interface.ts):
/**
 * Interface to describe a conventional margin e.g. to place
 * axes around a rendered object.
 */
export interface Margin {
  top: number;
  right: number;
  bottom: number;
  left: number;
}

is causing the warning stated above in an angular-cli-based application, which uses the library through npm link during development.
All other interfaces/types do not throw the warning, although I do not see any structural difference in how they are included/re-exported.

@brentchow — Can you please try @sebastianteres' suggestions at https://github.com/jvandemo/generator-angular2-library/issues/127#issuecomment-315380579 to see if they fix your errors? Thanks!

Hi, sorry this took a while to get back to.
Exporting ALL services worked as @xxxtonixxx said and as mentioned in the comment @jvandemo referenced (https://github.com/jvandemo/generator-angular2-library/issues/127#issuecomment-315380579).
I'll close this issue. Thanks all!

@brentchow — Thank you for the update!


Secure channels with Cognito identity pool

Hi
I'm building video chat using Cognito + webRTC and I'm trying to figure out how to secure access to dynamically created channels so every user will be only able to access particular rooms.
Thanks a lot!

https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js#managing-credentials
Resolving


role: mongodb: change mongodb__conf_net_bind_ip

Fix connection issue when multiple address in mongodb__conf_net_bind_ip where specified.
As example mongodb__conf_net_bind_ip: 'localhost,<IP_ADDRESS>
TASK [linuxfabrik.lfops.mongodb : Create DBA "ansible" (if first user, using localhost exception)] ***
fatal: [p-vm-facts-001.stadtluzern.ch]: FAILED! => {"changed": false, "msg": "Unable to connect to database: Cannot specify multiple hosts with directConnection=true"}

nice catch, thanks a lot for the PR :)


typelib not found

Hi i installed i3ipc from pip, but he cant found it (ubuntu 18.04 py3)
Traceback (most recent call last):
File "", line 888, in _find_spec
AttributeError: 'DynamicImporter' object has no attribute 'find_spec'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3/dist-packages/gi/importer.py", line 127, in find_module
'introspection typelib not found' % namespace)
ImportError: cannot import name i3ipc, introspection typelib not found

nevermind i realised what i did wrong


"Spătac" is listed in the drop-down menu

Description:
"Spătac" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Spătac" in the search bar.

Expected results
The location is listed in the drop-down menu as "Spătac, Alba (Blaj)".


adapt step size to CoC

Turns out render passes are re-instantiated when the options have changed so we don't need to cache/invalidate the shader internally and we only need to compute the correct step size before compiling it.
@Meakk can you confirm? I feel like I'm just winging it here
would fix #1213

Please add a test :)

Please add a test :)

Coverage looks fine to me, do you mean "fix the existing test that wasn't catching the issue before" ? ;p
I believe we need an hdri that shows more obvious bokeh that the one currently in the testing data, should we add one or swap the existing one? an if we swap should it be a separate PR?

I believe we need an hdri that shows more obvious bokeh that the one currently in the testing data, should we add one or swap the existing one? an if we swap should it be a separate PR?

Perfectly ok to add one, as long as is a low res one.

Ok then it's OK. Rebuilding the whole rendering pipeline when an option changes sounds inefficient to me tho. We'll have to think about it later.

Yes, that sounds good to me but we are looping from 0 to 1 so a step value of 2 does not make sense. I'd say we need at least 4 iterations, so what about 2.0 / max(CoC, 8.0)?

what about 2.0 / max(CoC, 8.0)?

I was going to do something clunky like max(2.0 / max(CoC, minCoC), maxStep) but yours is better :+1: I'll do that


A lot of tscancellation files in temp dir

VSCode Version: 73015a5
OS Version: Windows 10 x64

Steps to Reproduce:

Use vscode

I was noticing vscode disk usage way high, and found that it's creating vscode-tscancellation files in TEMP non-stop. Have over 500 files in my temp dir in after 2 days working on TS projects

Those cancellations files are expected and almost certainly not themselves responsible for the high disk usage
When does the high disk usage happen? Does it reproduce if you disable all extensions?

indeed, it seems to be the gitlens extension when having many TS files opened


can't interpolate strings

Serializations like this
let json = JSON.from([
   "name": "\(name)"
])

Result in this:
{
    "name": "String(_core: Swift._StringCore(_baseAddress: Swift.OpaquePointer(_rawValue: (Opaque Value)), _countAndFlags: Swift.UInt(_value: (Opaque Value)), _owner: Swift.Optional<Swift.AnyObject>.none))String(_core: Swift._StringCore(_baseAddress: Swift.OpaquePointer(_rawValue: (Opaque Value)), _countAndFlags: Swift.UInt(_value: (Opaque Value)), _owner: Swift.Optional<Swift.AnyObject>.some(Swift._HeapBufferStorage<Swift._StringBufferIVars, Swift.UInt16>)))String(_core: Swift._StringCore(_baseAddress: Swift.OpaquePointer(_rawValue: (Opaque Value)), _countAndFlags: Swift.UInt(_value: (Opaque Value)), _owner: Swift.Optional<Swift.AnyObject>.none))"
}

And if you try to do
let name: String = "test"
let json = JSON.from([
   "name": name
])

You'll get an error like Cannot create JSON from type [String: String]

The first example works fine for me... perhaps you did something silly like String(String) (hence giving you that strange signature)? Either way, I added a test so that you can run it locally if you'd like.
The second example should be
let name: String = "test"
let json: JSON = [
    "name": JSON.from(name)
]

Maybe it's a weird cross module issue. I'll look into it some more.

Doing this worked.
let json: JSON = [
    "name": JSON.from(name)
]```

Does the interpolated version not work? Are you sure that your variable was of the correct type?

Yeah. I think it's a cross module bug. I just added an extension to String in my module that wraps return JSON.from(string) and it's working now.


Remove Organisation types, assign roles directly onto Applications

remove Organisation#organisation_types
assign roles an application understands directly onto the Doorkeeper::Application object
webops users can give Organisations access to Applications
Organisation Admins can then delegate access to users
Webops and Organisation Admin users denoted by flags on User and Membership objects
Cleared out seeds - only has 1 webops user by default now

@chriscarter90 can you have another look at this please?
Once ok ill rebase into a single commit


feat: only show repositories that are ready-to-use

We don't want to have to make repositories private. Instead, we will add the "ready-to-use" topic to any that we want to show here.
Extra credit 1: URL-based filtering. Add ?q=assembly to the URL, and you will only see projects with names or topics matching "assembly". While there's no UI for searching yet, this lays the groundwork to add it more easily in the future. This change is what necessitated the CSS change, to fix showing a single search result on wide screens.
Extra credit 2: a cleaner RepositoryType, with some sharp edges of the raw graphql result sanded off
Extra credit 3: some gatsby config is now in TypeScript, using this approach: https://gist.github.com/JohnAlbin/2fc05966624dffb20f4b06b4305280f9
Extra credit 4: remove unused isPrivate attribute from graphql queries

If we can remove the tag from the view that'd be ideal

@mikedotexe please double-check; I think this change already hides that tag. See https://github.com/near/awesome-near/pull/14/files#diff-7a8ac4eec62fd55d78df3b6af8a7b7f9R93

@mikedotexe please double-check; I think this change already hides that tag. See https://github.com/near/awesome-near/pull/14/files#diff-7a8ac4eec62fd55d78df3b6af8a7b7f9R93

completely my mistake, wrong branch.


Developer Friendly Privacy Preferences

Closes https://github.com/ethyca/fidesplus/issues/1115
Description Of Changes
Adds the ability to take in a TC string and save privacy preferences
Code Changes

[x] Adds the ability to take in a TC string and save privacy preferences
[ ] Returns the decoded string in the response

Steps to Confirm

[ ] list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

@eastandwestwind @allisonking just tagging you for an early look so we're on the same page about saving privacy preferences to the backend.  Want to get your thoughts on the strategy.
So a tricky part, I'm also comparing the experience itself to the TC string to settle this point:
Just because a value is a 0 in the TC string, doesn't mean the user explicitly opted out, it might not have been presented as an option for them to opt in or out of in the first place, because that purpose is not in the data map at all.  So I loop through the elements from the datamap first and then see if it's True in the string, otherwise it's saved as False.


Optional deletion confirmation dialogue

Hi,
I am aware that the deletion confirmation dialogue was removed due to #4, but for me personally, it would be very useful if I could re-enable it. I'm not very dexterous with my phone sometimes and from time to time hit the Delete button by accident when I wanted to press Edit or just swipe over the notification. With no confirmation dialogue, this means that I just loose the entire note by accident.
If introducing a whole options menu for this would be too much effort, perhaps a "Always delete without asking" checkbox could be added to the confirmation dialogue for anyone who does not wish for it to come up.

I was actually thinking the same thing not so long ago, because I noticed that deleting a screenshot also has a confirmation dialog. And another checkbox also came to mind, but adding more and more checkboxes isn't really the solution in my opinion. So I actually have some ideas.

Add a settings icon to the dialog where you have all the preferences (to keep the main dialog clean)
After deleting a note, show a toast/snackbar with an undo button
(Add a settings activity. Not ideal for note specific settings)

The first one is kind of my favorite, since this will allow me to add more preferences in the future.
What do you think?

I think having a preference menu would be good, also in general for other customization.
But I also like the undo toast idea. Maybe that could be what happens if you disable the confirmation dialogue? So if someone just wants to delete a lot of notes at once (like in #4), they can do it, but they still get some safety against accidental deletes.
Also, maybe some ideas for other possible options that could be added to the preference menu:

What the default should be for note color/"Hide on lockscreen"/"Lock in notifications" for new notes
Whether to show the Edit/Delete buttons in the notification
What should happen when one taps on the note itself (Current popup/Do Edit directly/Do Delete directly)


Can't get all pages from plugin's CLI

I have a simple CLI script for my Grav plugin like this
<?php
namespace Grav\Plugin\Console;

use Grav\Console\ConsoleCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;
use Grav\Common\Grav;
use Grav\Common\Page\Page;
use Grav\Common\Page\Pages;

class ImportCommand extends ConsoleCommand {
  protected function configure() {
    $this->setName('import');
  }

  protected function serve() {
    $pages = Grav::instance()['pages']->all();
  }
}

However when I execute bin/plugin import import from terminal, I get this error:
$ bin/plugin import import
PHP Fatal error:  Uncaught Error: Call to a member function root() on null in /var/www/html/my-site/system/src/Grav/Common/Page/Pages.php:570
Stack trace:
#0 /var/www/html/my-site/user/plugins/place-import/cli/ImportCommand.php(17): Grav\Common\Page\Pages->all()
#1 /var/www/html/my-site/system/src/Grav/Console/ConsoleCommand.php(29): Grav\Plugin\Console\ImportCommand->serve()
#2 /var/www/html/my-site/vendor/symfony/console/Command/Command.php(266): Grav\Console\ConsoleCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /var/www/html/my-site/vendor/symfony/console/Application.php(875): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /var/www/html/my-site/vendor/symfony/console/Application.php(204): Symfony\Component\Console\Application->doRunCommand(Object(Grav\Plugin\Console\ImportCommand), Object(Symfony\Component\Console in /var/www/html/my-site/system/src/Grav/Common/Page/Pages.php on line 570

With the above code I can get the pages from the plugin's main file but if put that code in CLI script, it doesn't work. I have Grav 1.3.10.
I have also tried to create a new Collection but I get a similar error, root page can't be found.
If I want to get all the pages from CLI script, what is the best way to do? Thanks in advance!

I believe the problem is that you are trying to access Pages before they are initialized.   In the CLI you have to do this manually. See this plugin for an example: https://github.com/trilbymedia/grav-plugin-tntsearch/blob/develop/cli/IndexerCommand.php


fix: 🐛 syn-alert left colored-border does not reach to the edge

Checklist (for the issue creator)

[x] I have verified the bug exists in the latest version of @synergy-design-system/components (e.g. via pnpm install @synergy-design-system/components).
[x] I can provide a simple, reproducible example of the issue (e.g. via code-sandbox or sample code, ...).
[ ] I would be willing to provide a PR for this issue.

Version
The bug occurred with the following version of the component library: all (2.11.7)
Component
The issue arises when using the following component(s): syn-alert
Environment
The issue occurred with the following operating system(s):
The issue occurred in the following browser(s):
Description

The colored left border does not reach the lower and upper edge, see screenshot
Storybook:
https://synergy-design-system.github.io/?path=/docs/components-syn-alert--docs

Figma:
https://www.figma.com/design/bZFqk9urD3NlghGUKrkKCR/Synergy-Digital-Design-System?node-id=16231-21178&node-type=frame&t=JFhOIyQ1KCNtD6NL-11

Acceptance criteria

[ ] All DoD items successfully completed
[ ] the border is seamless from top to bottom

Maybe you could use the border attribute instead of a div.

Maybe you could use the border attribute instead of a div.

Hi @MCsnuffBobbyK, thank you for your input. Unfortunately, this will not work out as easy as it seams. The reason for this is that borders in CSS are geometrical aligned to a triangle. When you use a border of 5px at the top and 10px on the left for example, you will get artifacts when using different colors. This was the reason we did not do this in the first place.
For reference, see https://css-tricks.com/the-shapes-of-css/ for examples how to exploit this "feature" :). This would not be visible when using the same color, but as we use a different highlight color, it would create layout problems.

This bug came with the update to shoelace 2.17.1, which added an overflow: hidden on the container around.
As we do not use the new alert feature, which came with this update, we will just remove the overflow: hidden for now


Streaming Transformer Transducer

Hi!
I am currently working on a streaming Transformer Transducer (T-T) myself (using Tensorflow) but I'm struggling to get started with the actual inference part. I've been referred to your repository from ESPnet (see https://github.com/espnet/espnet/pull/2533#issuecomment-757798727), as you noticed or going to notice.
I was wondering if you could share some knowledge on how you are tackling this problem. As for me, I started to look at  "Developing Real-Time Streaming Transformer Transducer for Speech Recognition on Large-Scale Dataset" and noticed that they are proposing something called Trigger Attention ([1], [2]). In contrast, what I've been told is that, you are using Monotonic Chunkwise Attention (MoChA).
I'm not quite sure how either work in detail but if you could point to somewhere or help me to get started it would be much appreciated!

@stefan-falk Hello. The difference between triggered attention and MoChA is the computational complexity in each generation step. Triggered attention requires O(T^2) but MoChA does O(T) because the context size is very limited.

@stefan-falk Hello. The difference between triggered attention and MoChA is the computational complexity in each generation step. Triggered attention requires O(T^2) but MoChA does O(T) because the context size is very limited.

@hirofumi0810 Ah, I see. Then MoChA it is! Thank you. Do you have working code for MoChA training and decoding already? I'd love to take a look at it to get started, in case you do.

@hirofumi0810 Ah, I see. Then MoChA it is! Thank you. Do you have working code for MoChA training and decoding already? I'd love to take a look at it to get started, in case you do.

@stefan-falk You can start from here.
I'll send a big PR for streaming inference with Transformer/Conformer encoder (+caching) this week. Stay tune!

@stefan-falk You can start from here.
I'll send a big PR for streaming inference with Transformer/Conformer encoder (+caching) this week. Stay tune!

@hirofumi0810 Thanks a lot! I'll be looking at the code :) And thanks for your great work!

@hirofumi0810 Thanks a lot! I'll be looking at the code :) And thanks for your great work!

@hirofumi0810 Can we even use MoChA inside a Transducer model?

@hirofumi0810 Can we even use MoChA inside a Transducer model?

@stefan-falk MoChA is different from Transducer, so it is not common to combine them.
But there is a combination of attention and RNN-T (https://arxiv.org/abs/2005.08497).
I have implemented RNN-T as well (see readme). I'll support streaming inference with RNN-T soon.

@stefan-falk MoChA is different from Transducer, so it is not common to combine them.
But there is a combination of attention and RNN-T (https://arxiv.org/abs/2005.08497).
I have implemented RNN-T as well (see readme). I'll support streaming inference with RNN-T soon.

Thank you for the link!
However, I kind of move away from RNN-based Transducer models. The reason for that was after I saw how much smaller the Transformer-Transducer (T-T) and Conformer-Transducer (C-T) models are. A 30M parameter C-T model outperforms a 130M parameter RNN-T model. On my hardware, I am not even able to train such an RNN-T model 😆
Here is a quick (not very scientific) comparison from my own experiments.

Please note that these results are not coming from a streaming scenario as I am not able to stream Transformer-based models yet.

Name
WER
Encoder
Decoder

C-T
12.74%
Conformer
RNN

TRNN-T
18.38%
Transformer
RNN

RNN-T
24.60%
RNN
RNN

Thank you for the link!
However, I kind of move away from RNN-based Transducer models. The reason for that was after I saw how much smaller the Transformer-Transducer (T-T) and Conformer-Transducer (C-T) models are. A 30M parameter C-T model outperforms a 130M parameter RNN-T model. On my hardware, I am not even able to train such an RNN-T model 😆
Here is a quick (not very scientific) comparison from my own experiments.

Please note that these results are not coming from a streaming scenario as I am not able to stream Transformer-based models yet.

Name
WER
Encoder
Decoder

C-T
12.74%
Conformer
RNN

TRNN-T
18.38%
Transformer
RNN

RNN-T
24.60%
RNN
RNN

@stefan-falk hi, stefan, Is your experiments on the German dataset on espnet? espnet or espnet2?

@jinggaizi This is just a mix of different (public) datasets e.g. Common Voice and Spoken Wikipedia.


⚠ Bofrost.at has degraded performance

In d0c01fd, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1169 ms

Resolved: Bofrost.at performance has improved in 38f381d after 6 minutes.


Allow exposing custom ports for kafka brokers

Is your feature request related to a problem? Please describe.
I have a custom kafka distribution that has an integrated metrics exporter service exposed as a HTTP service. I would like to have this port added to the container and the service specs.
Describe the solution you'd like to see
I would like to have a new field added to the CRD (probably with the corev1.ContainerPort type) that will be used to create the kafka containers and services
Describe alternatives you've considered
I tried adding an additional container that would proxy requests to the metrics api but then I have to also create a new service for each broker that exposes this port. This is not ideal since then I have to monitor the number of kafka brokers and adjust the services accordingly.

Hi @david-simon thanks for using koperator!
This seems like a good first issue so maybe you could contribute this to the project?
Also, could you think of some other scenarios where you think this could be useful for others as well?
The only thing that comes to my mind is some kind of remote debug port that can be used by this.

Hi @hi-im-aren
Sorry, forgot to mention in the description that I'm already working on this :)
I'll get back to you with some more use cases if I can

Resolved in #898


fix issue #152: Avoid picking early-docker by selecting newest docker daemon process

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:dhawal55/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:dhawal55/docker-bench-security.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.


PIP 81: Split the individual acknowledgments into multiple entries

Motivation
Pulsar persists the individual acknowledgments into Ledger for each subscription.
acknowledgment hole uses guava range to record.
Now a single entry is used to record these holes, but a single entry can not stores more than 5MB data.
Therefore, this PIP stores these holes in different entries separately. And use LRU to ensure low memory usage.
In this way, we can support almost unlimited acknowledgment hole.
Doc: https://docs.google.com/document/d/1uQtyb8t6X04v2vrSrdGWLFkuCkBcGYZbqK8XsVJ4qkU/edit
Modifications
recover:

Added API recoverFromMultiEntry
The old logic is abstract as recoverFromSingleEntry

persist position to ledger：

Add API persistPositionToMultiEntry and saveMarker
The old logic is abstract as persistPositionToSingleEntry

when creating new ledger:

Add API copyLruEntriesToNewLedger
The old logic remains the same

LRU:

Add class RangeSetWrapper. Responsible for loading and eliminating of LRU data .
The loading of LRU data is synchronous, and elimination of LRU data is asynchronous, with RangeSetWrapper#LruTask

Verifying this change
persist position to ledger has 3 chain:
internalAsyncMarkDelete + NoLedger -> startCreatingNewMetadataLedger -> createNewMetadataLedgerAndSwitch -> doCreateNewMetadataLedger -> persistPositionToLedger -> switchToNewLedger -> flushPendingMarkDeletes -> internalMarkDelete -> persistPositionToLedger -> remove individualDeletedMessages

internalAsyncMarkDelete + Ledger is Open -> internalMarkDelete -> persistPositionToLedger -> remove individualDeletedMessages

persistPositionWhenClosing -> persistPositionToLedger -> close ledger

create new ledger has 1 chain:
initialize -> createNewMetadataLedgerAndSwitch -> doCreateNewMetadataLedger -> switchToNewLedger -> flushPendingMarkDeletes -> internalMarkDelete -> persistPositionToLedger -> remove individualDeletedMessages

recover has 1 chain:
initializeCursors -> recover -> recoverFromLedger -> recoverFromMultiEntry

@315157973 thanks for your contribution. For this PR, do we need to update docs?

The pr had no activity for 30 days, mark with Stale label.

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


Update create-cloud-swarm.md

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Yep, thanks @scjane !


Fails on Django 2.0.1

No module named 'django.core.urlresolvers
This module was removed in Django 2

Addressed in #13.


Date prompt changes

Added new functionality for choosing a different date other than the default date.
Made edits in util.py, send.py

Resolves delivery date aspect of #5


Is HDR Image Encoding Supported?

I tried encoding a HDR image with the Rec. ITU-R BT.2100 PQ color profile, but after encoding, the image is no longer HDR. The README mentions HDR support but doesn’t explicitly say it’s for encoding or decoding. Does this library fully support HDR encoding?
print("before: \(image.isHighDynamicRange)") // true
let data = try JXLCoder.encode(image: image)
let newImage = try JXLCoder.decode(data: data)
print("after: \(newImage.isHighDynamicRange)") // false

Only decoding is supported.  ICC profiles and HDR images not supported in encoding

Any plans to support it in the future?

To retrieve pixel data in iOS/macos we have to redraw image on the other surface, at this stage image are being drawing ‘as is’ and metadata is lost. I don’t know how to avoid this. If you know something PR are welcome.


Return an error on nil response

Properly handle the case where the HTTP client returns a nil response
and error.
Refactored poller.Poll() to simplify error propagation.

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

Fixes https://github.com/Azure/azure-sdk-for-go/issues/14729

There was a fix in azcore to return an error if the response and error were both nil.  It could be the case that the repro was using an older version of azcore without the fix.


Storage.

Lots of time at storage chrome gets 26.(total 505)
and sometimes, it get 28 (total 507).
the different it here:
Objectstore ArrayBuffer support - 2 pt.
please check this test. it not constant for every load of the page.

Microsoft Edge does not seem to suffer from this problem anymore.


Twitter handle for plugin submission

To submit a community plugin this is the json content to create pull request with:
{
	"npm": "the npm package name of your plugin",
	"author": "Your Twitter username",
	"description": "A description of the plugin"
}

Does it need to be a Twitter/X handle? What effect does it have besides

Already a supporter but it’s not showing here? Make sure your Twitter account is listed on your Open Collective Profile.
— example of a profile on 11ty.dev/authors/

I’m not active on Twitter/X anymore and I asume lots of 11ty folks are neither.

@zachleat what is your opinion here?


Game list pagination fix & cleanup

Codecov Report

Merging #47 into master will decrease coverage by 51.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #47       +/-   ##
==========================================
- Coverage   73.04%   21.6%   -51.45%
==========================================
  Files          73      73
  Lines         846     847        +1
  Branches       50      50
==========================================
- Hits          618     183      -435
- Misses        206     664      +458
+ Partials       22       0       -22

Impacted Files
Coverage Δ

src/app/games/game-list/game-list.component.ts
100% <100%> (ø)
:arrow_up:

...players/player-details/player-details.component.ts
4.16% <0%> (-95.84%)
:arrow_down:

src/app/shared/connect-string-to-link.pipe.ts
5.26% <0%> (-94.74%)
:arrow_down:

src/app/queue/queue-events.service.ts
6.66% <0%> (-93.34%)
:arrow_down:

...queue/queue-container/queue-container.component.ts
7.69% <0%> (-92.31%)
:arrow_down:

...-server-dialog/add-game-server-dialog.component.ts
11.11% <0%> (-88.89%)
:arrow_down:

src/app/games/games.service.ts
11.11% <0%> (-88.89%)
:arrow_down:

src/app/players/players.service.ts
6.25% <0%> (-87.5%)
:arrow_down:

...ready-up-dialog/queue-ready-up-dialog.component.ts
14.28% <0%> (-85.72%)
:arrow_down:

src/app/game-servers/game-servers.service.ts
16.66% <0%> (-83.34%)
:arrow_down:

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bb594...3e48a86. Read the comment docs.


Popular Community Bounty: Toyota no-DSU cars need OP Long

It bugs us that OP long doesn't work on the Toyota Camry or CH-R, so we are banding together to create a community bounty for the betterment of all no-DSU car owners.
Our pledgers have promised a bounty of $1,600 and the number is growing by the day (just like the number of Toyota Camrys/CH-Rs on the road).
We would like this bounty to be featured on the comma.ai bounty page, and to perhaps get a shout out of some sort to promote hackers to get involved. After all, we're talking about some very popular vehicles.
Expected behavior (OP Long)
-A chill driving experience
Actual Behavior (stock TSS-P ACC)
-PANIC BREAKING!
Our community bounty pays the creator of a practical hardware or software solution that enables OP Longitudinal control on no-DSU Camry and CH-R vehicles (model year 2018+). The solution would need to work with EON or Comma 2 users.
Comma already has a $2000 bounty for this issue but our bounty differs in that it allows hardware and software solutions, while Comma only allows software solutions.
DM @rageser to be added to the registry of pledgers, or interested hackers please feel free to inquire. Thanks, and we hope to see our bounty up on Comma.ai.
@rageser discord

We are consolidating all community bounties to our community bounty page found here, https://community.comma.ai/wiki/index.php/Bounties.

We are consolidating all community bounties to our community bounty page found here, https://community.comma.ai/wiki/index.php/Bounties.

Please post the above information and the bounty amounts below to the Wiki. I can't seem to gain access to post......
Rageser $500
Andybfield $200
Venu $150
Erich $100
apm $100
aLp $100
Hermosa $100
Djt1283 $100
02trackroad $75
Cferra $50
Jadtec $50
Mubimmer $50
Fchen53 $25
Subtotal: $1600
Community Total = $1600 (hardware or software hack)
Comma bounty = $2000 (software only)


ng2 ui-view: component sometimes created after parent ui-view destroyed.

In the latest released version, ng2's uiView creates it's components asynchronously. Sometimes, the handler for the component creation can be invoked after the uiViews ngOnDestroy() method has been called, leaving an unused, dangling component in place. This can lead to all kinds of problems (in my case the dangling component was subscribed to a stream and was causing continuous and pointless ajax requests to be sent in response to it).
This problem can be reproduced quite easily when using ng1-to-ng2 module. That module causes a new ng2 ui-view to be created and then torn down on every transition to an ng2 component. When routing between two such ng2 components, the ui-view that is about to be removed to be replaced by the new one first processes the state config change request which causes it to invoke the asynchronous procedure for creating the new component. Before that promise returns, the ui-view is removed, then the promise resolves and the dangling component is created.
I have a simple fix for this in my fork, which I will reference below. However, I see the present top of master has now moved to using angular 2 rc5 and the new synchronous way of creating components. Therefore, as long as that synchronous approach stays in place it does not make sense to issue a pull request for this and this particular bug should not be found in the next release.

For reference, for anyone else hitting this, here is the fix:
https://github.com/vigie/ui-router/commit/97d13fc5becd063fb41236e24fb1450ced5d5f3f
Btw the build instructions for this project seem to be old. The way I built this was with 'node scripts/release.js'

Thanks for the detailed analysis @vigie !

Master is now up to date with synchronous views


How to close db?

Hey! Nice plugin. Could you tell how can I close the db? Thanks!

Update version to v0.1.1. Now you use close().


feat(compaction): Limit the size of the new overlapping level

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Test q20 with ckpt = 10s
Branch:
https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1730886960000&orgId=1&to=1730888805000&var-datasource=VictoriaMetrics&var-namespace=nexmark-q20-li0k-divide-overlapping-10s-ckpt
Main:
https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=VictoriaMetrics&from=1730887433000&to=1730889274000&var-namespace=nexmark-q20-li0k-main-10s-ckpt

Test with huge ckpt size (append only)
branch

main
https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?from=1732010670735&orgId=1&to=1732018765104&var-component=All&var-datasource=cdtasocg64074c&var-instance=risingwave&var-namespace=rwc-g1id190bqafhfasa3koc48a87d-li0k-test&var-pod=All&var-table=All

PTAL @hzxa21 @zwang28
With the above Test, we can see that pr is optimised for large ckpt size commits. However, I also found a few problems with this test.

after the tier compact is finished, a lot of trivial-move tasks will exhaust the cpu of the meta, and the efficiency of single-file trivial-move is extremely low. 2. when l0 is stacked up, we didn't make a timely decision.

when l0 is piled up, we didn't change the compaction parameter in time, such as output sst size, max_compaction_size, which will reduce the efficiency of compaciton (refer to 1). Is it possible to introduce some deterministic rules to optimize the compaction task?

I don't think it's correct to use 128M as the limit for overlapping level, since CN submitted max_sst_size = 256M, maybe we should adjust max_overlapping_level_size upwards.

Do we need to create a separate issue for optimization 1 / 2 ?

Do we need to create a separate issue for optimization 1 / 2 ?

+1. You can also give ideas on how to optimize 1 & 2 in the issue.

I don't think it's correct to use 128M as the limit for overlapping level, since CN submitted max_sst_size = 256M, maybe we should adjust max_overlapping_level_size upwards.

That is true. I think we should adjust max_overlapping_level_size because its effective lower bound seems to be max_sst_size = 256M

Do we need to create a separate issue for optimization 1 / 2 ?

+1. You can also give ideas on how to optimize 1 & 2 in the issue.

I don't think it's correct to use 128M as the limit for overlapping level, since CN submitted max_sst_size = 256M, maybe we should adjust max_overlapping_level_size upwards.

That is true. I think we should adjust max_overlapping_level_size because its effective lower bound seems to be max_sst_size = 256M

256M sounds good to me, I think it also roughly limits the size of l0, e.g. 256M * 300 (level-0-write-limit)


Separate command and text field for slack-compatible outgoing webhook

Discussed here: https://chat.zulip.org/#narrow/stream/127-integrations/topic/gitlab.20slash.20commands/near/1247658
Current behavior puts entire message, including bot mention, in the text field of the outgoing POST.
POST coming from Slack itself puts the "slash command" in a separate command field while their text field only contains the message body after the command.
For better compatibility, if message starts with a bot mention then we should separate that out into a command field and put the rest of the message in the text field.
Perhaps we can also transform the mention (**@mybot**) to a slash command (/mybot) so it looks like it would coming from Slack.

@esamson can you provide an example Slack payload or a pointer to the right part of their documentation?
https://api.slack.com/legacy/custom-integrations/outgoing-webhooks#legacy-info__post-data does not suggest the presence of a command field, but that is a legacy API.

Yeah, I haven't been able to find docs but just observed this by testing against Slack itself.

@timabbott @eeshangarg can i work on this issue ??

@madrix01 There's a command on this page you can use to pick up the issue.

@eeshangarg Yes, that's what I did. I took the instruction from https://docs.gitlab.com/ee/user/project/integrations/slack_slash_commands.html and pointed to requestbin instead of gitlab.

@zulipbot claim
Would love to work on this as my first open source contribution!

@zulipbot claim

@zulipbot claim

@zulipbot claim

I have worked on this issue and I have made a PR. Review is pending

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

claim

@zulipbot claim

@esamson Hi, would you like to look at my open PR is review it?
Thanks.


Improve the Functionality of the Discussion Section

The Discussion section at https://electivehub.onrender.com/discussion currently lacks both in terms of styling and functionality. This issue is created to address the visual and user experience aspects of the Discussion section.

Usability: Users may find it challenging to engage in discussions due to the suboptimal layout and design.
Functionality: The Discussion section may lack essential features like sorting options, user avatars, proper alignment, and visual cues for better user engagement.

hi, could you please assign me to this issue?

Yes sure @lapso222

Sir, the Discussion section is now missing on the site. So can you assign me this issue under GSSoC24? I will add the discussion section.

I am Agamjot singh. Under GSSOC'24, I would like to work on this issue. Pls assign me this!!

Hello, I am Karthik, I have experience working on a similar feature. Could you please assign this to me under GSSOC'24 ? I will be able to add an interactive discussion page with filters and sorting ( latest message first, relevance etc ).

Sir, I am full stack developer, and wants to fix this issue by not just creating Discussion Page but also by adding various feature-
1.Better UI
2.Audio functionality
3.Better visual aspects.
and many more....Please assign me this issue under GSSOC24.(on first come first basis)

I’ve noticed the Discussion section and I’m eager to help enhance it. Could you assign me the task of improving the layout, design, and functionality? I’m ready to contribute to a better user experience.

Hey @samruddhikurhe , I'm assigning this to you.
Happy Hacking.


Handling of external data files (inputs and outputs) for testing

Currently the 2019 inputs and 2019 Matlab EchoPro outputs are stored in Google Drive folders with access limited to team members (UW and FEAT). The inputs are required for all tests (and the notebooks), while the outputs are used in some of the tests. At this time we're unable to set up the tests as GH Actions if the outputs and specially the inputs are not directly accessible.

Using mock data files will also make it possible to resolve #13 -- I think it should be part of the goals.

I am going to close this issue now since there's no details on which files are used for which purpose, and as such #151 supersedes this issue.


Slack notification don't go to multiple rooms

i'm trying to have slack notifications go to multiple channels, it looks like it was fixed here https://github.com/jenkinsci/slack-plugin/commit/87b7bd1b69f118538d425405ecb5889ee5a709a8
However, I have tried supplying to rooms using "#room1, #room2", "#room1 #room2", and "#room1; #room2" but it still only goes to #room1 and no messages go into #room2.  I looked through the logs and it doesn't even make an attempt to post to #room2.
I'm using v1.8

Duplicates #98.


Android Crashes Caused by android.database.sqlite.SQLiteException

Current behavior
I recently upgraded RN from 0.57 to 0.59 and moved to using this package for AsyncStorage and have seen about 2% of our users experience this crash so far.
Stack Trace
AsyncStorageModule.java line 208
com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded

Fatal Exception: java.lang.RuntimeException
An error occurred while executing doInBackground()
android.os.AsyncTask$3.done
Fatal Exception: java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$3.done + 309(AsyncTask.java:309)
at java.util.concurrent.FutureTask.finishCompletion + 354(FutureTask.java:354)
at java.util.concurrent.FutureTask.setException + 223(FutureTask.java:223)
at java.util.concurrent.FutureTask.run + 242(FutureTask.java:242)
at com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1.run + 61(AsyncStorageModule.java:61)
at java.util.concurrent.ThreadPoolExecutor.runWorker + 1113(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run + 588(ThreadPoolExecutor.java:588)
at java.lang.Thread.run + 818(Thread.java:818)

Caused by android.database.sqlite.SQLiteException
no such table: catalystLocalStorage (code 1): , while compiling: INSERT OR REPLACE INTO catalystLocalStorage VALUES (?, ?);
com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded
Caused by android.database.sqlite.SQLiteException: no such table: catalystLocalStorage (code 1): , while compiling: INSERT OR REPLACE INTO catalystLocalStorage VALUES (?, ?);
at android.database.sqlite.SQLiteConnection.nativePrepareStatement(SQLiteConnection.java)
at android.database.sqlite.SQLiteConnection.acquirePreparedStatement + 896(SQLiteConnection.java:896)
at android.database.sqlite.SQLiteConnection.prepare + 507(SQLiteConnection.java:507)
at android.database.sqlite.SQLiteSession.prepare + 588(SQLiteSession.java:588)
at android.database.sqlite.SQLiteProgram. + 58(SQLiteProgram.java:58)
at android.database.sqlite.SQLiteStatement. + 31(SQLiteStatement.java:31)
at android.database.sqlite.SQLiteDatabase.compileStatement + 1024(SQLiteDatabase.java:1024)
at com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded + 208(AsyncStorageModule.java:208)
at com.reactnativecommunity.asyncstorage.AsyncStorageModule$2.doInBackgroundGuarded + 199(AsyncStorageModule.java:199)
at com.facebook.react.bridge.GuardedAsyncTask.doInBackground + 32(GuardedAsyncTask.java:32)
at com.facebook.react.bridge.GuardedAsyncTask.doInBackground + 20(GuardedAsyncTask.java:20)
at android.os.AsyncTask$2.call + 295(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run + 237(FutureTask.java:237)
at com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1.run + 61(AsyncStorageModule.java:61)
at java.util.concurrent.ThreadPoolExecutor.runWorker + 1113(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run + 588(ThreadPoolExecutor.java:588)
at java.lang.Thread.run + 818(Thread.java:818)
Expected behavior
To not crash.
Repro steps
Unable to reproduce, only seen occurring in Production across a variety of devices and Android versions.
Environment

Async Storage version: 1.5.1
React-Native version: 0.59.10
Platform tested: Android
Logs/Error that are relevant: See above

@danielvportlandia Can you share what kind of android version/phones have this issue?

Here is the spread according to Firebase, happening on all versions though only 1% occurring on Android 9.0.

I am also running into this issue with the below call stack. It is happening on multiple devices in production app. I am not able reproduce it in dev environment though.
java.lang.RuntimeException:
  at android.os.AsyncTask$3.done (AsyncTask.java:309)
  at java.util.concurrent.FutureTask.finishCompletion (FutureTask.java:354)
  at java.util.concurrent.FutureTask.setException (FutureTask.java:223)
  at java.util.concurrent.FutureTask.run (FutureTask.java:242)
  at com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1.run (AsyncStorageModule.java:62)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1113)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:588)
  at java.lang.Thread.run (Thread.java:818)
Caused by: android.database.sqlite.SQLiteException:
  at android.database.sqlite.SQLiteConnection.setLocaleFromConfiguration (SQLiteConnection.java:400)
  at android.database.sqlite.SQLiteConnection.open (SQLiteConnection.java:221)
  at android.database.sqlite.SQLiteConnection.open (SQLiteConnection.java:196)
  at android.database.sqlite.SQLiteConnectionPool.openConnectionLocked (SQLiteConnectionPool.java:463)
  at android.database.sqlite.SQLiteConnectionPool.open (SQLiteConnectionPool.java:185)
  at android.database.sqlite.SQLiteConnectionPool.open (SQLiteConnectionPool.java:177)
  at android.database.sqlite.SQLiteDatabase.openInner (SQLiteDatabase.java:836)
  at android.database.sqlite.SQLiteDatabase.open (SQLiteDatabase.java:821)
  at android.database.sqlite.SQLiteDatabase.openDatabase (SQLiteDatabase.java:714)
  at android.app.ContextImpl.openOrCreateDatabase (ContextImpl.java:576)
  at android.content.ContextWrapper.openOrCreateDatabase (ContextWrapper.java:269)
  at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked (SQLiteOpenHelper.java:223)
  at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase (SQLiteOpenHelper.java:163)
  at com.reactnativecommunity.asyncstorage.ReactDatabaseSupplier.ensureDatabase (ReactDatabaseSupplier.java:88)
  at com.reactnativecommunity.asyncstorage.AsyncStorageModule.ensureDatabase (AsyncStorageModule.java:435)
  at com.reactnativecommunity.asyncstorage.AsyncStorageModule.access$000 (AsyncStorageModule.java:35)
  at com.reactnativecommunity.asyncstorage.AsyncStorageModule$1.doInBackgroundGuarded (AsyncStorageModule.java:135)
  at com.reactnativecommunity.asyncstorage.AsyncStorageModule$1.doInBackgroundGuarded (AsyncStorageModule.java:132)
  at com.facebook.react.bridge.GuardedAsyncTask.doInBackground (GuardedAsyncTask.java:32)
  at com.facebook.react.bridge.GuardedAsyncTask.doInBackground (GuardedAsyncTask.java:20)
  at android.os.AsyncTask$2.call (AsyncTask.java:295)
  at java.util.concurrent.FutureTask.run (FutureTask.java:237)
Caused by: android.database.sqlite.SQLiteReadOnlyDatabaseException:
  at android.database.sqlite.SQLiteConnection.nativeExecute (Native Method)
  at android.database.sqlite.SQLiteConnection.execute (SQLiteConnection.java:562)
  at android.database.sqlite.SQLiteConnection.setLocaleFromConfiguration (SQLiteConnection.java:387)

We have the same crashes in firebase. I guess it crashes an app when use Async Storage in background.
In my case it was a bug to run Permissions on background which invoke Async Storage
    if (nextAppState === 'background') {
        Permissions.check('camera').then(()= > { //Permissions uses Async Storage
                ...
        });
    }

Environment

Async Storage version: 1.6.1
React-Native version: 0.59.10
react-native-permissions: 1.2.1

It's still reproduced in my app. So background fix didn't help us.

The exception like this is happening on my app too.
Crash log as follows :
# AsyncTask #2(8484)
android.database.sqlite.SQLiteReadOnlyDatabaseException
attempt to write a readonly database (code 1032)

1 java.lang.RuntimeException:An error occurred while executing doInBackground()
2 android.os.AsyncTask$3.done(AsyncTask.java:325)
3 ......
4 Caused by:
5 android.database.sqlite.SQLiteReadOnlyDatabaseException:attempt to write a readonly database (code 1032)
6 android.database.sqlite.SQLiteConnection.nativeExecute(Native Method)
7 android.database.sqlite.SQLiteConnection.execute(SQLiteConnection.java:631)
8 android.database.sqlite.SQLiteConnection.setLocaleFromConfiguration(SQLiteConnection.java:456)
9 android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:245)
10 android.database.sqlite.SQLiteConnection.open(SQLiteConnection.java:220)
11 android.database.sqlite.SQLiteConnectionPool.openConnectionLocked(SQLiteConnectionPool.java:463)
12 android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:185)
13 android.database.sqlite.SQLiteConnectionPool.open(SQLiteConnectionPool.java:177)
14 android.database.sqlite.SQLiteDatabase.openInner(SQLiteDatabase.java:843)
15 android.database.sqlite.SQLiteDatabase.open(SQLiteDatabase.java:828)
16 android.database.sqlite.SQLiteDatabase.openDatabase(SQLiteDatabase.java:721)
17 android.app.ContextImpl.openOrCreateDatabase(ContextImpl.java:769)
18 android.content.ContextWrapper.openOrCreateDatabase(ContextWrapper.java:300)
19 android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:223)
20 android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:163)
21 com.reactnativecommunity.asyncstorage.ReactDatabaseSupplier.ensureDatabase(ReactDatabaseSupplier.java:88)
22 com.reactnativecommunity.asyncstorage.AsyncStorageModule.ensureDatabase(AsyncStorageModule.java:429)
23 com.reactnativecommunity.asyncstorage.AsyncStorageModule.access$000(AsyncStorageModule.java:34)
24 com.reactnativecommunity.asyncstorage.AsyncStorageModule$6.doInBackgroundGuarded(AsyncStorageModule.java:399)
25 com.reactnativecommunity.asyncstorage.AsyncStorageModule$6.doInBackgroundGuarded(AsyncStorageModule.java:396)
26 com.facebook.react.bridge.GuardedAsyncTask.doInBackground(GuardedAsyncTask.java:32)
27 com.facebook.react.bridge.GuardedAsyncTask.doInBackground(GuardedAsyncTask.java:20)
28 android.os.AsyncTask$2.call(AsyncTask.java:305)
29 java.util.concurrent.FutureTask.run(FutureTask.java:237)
30 com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1.run(AsyncStorageModule.java:61)
31 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
32 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
33 java.lang.Thread.run(Thread.java:761)

Else Info :
System: Android 7.1.1,level 25
CPU: arm64-v8a
Front and Background State: Background

The source code at ReactDatabaseSupplier.java:88 :
  /**
   * Verify the database exists and is open.
   */
  /* package */ synchronized boolean ensureDatabase() {
    if (mDb != null && mDb.isOpen()) {
      return true;
    }
    // Sometimes retrieving the database fails. We do 2 retries: first without database deletion
    // and then with deletion.
    SQLiteException lastSQLiteException = null;
    for (int tries = 0; tries < 2; tries++) {
      try {
        if (tries > 0) {
          deleteDatabase();
        }
        mDb = getWritableDatabase();                     // line 88
        break;
      } catch (SQLiteException e) {
        lastSQLiteException = e;
      }
      // Wait before retrying.
      try {
        Thread.sleep(SLEEP_TIME_MS);
      } catch (InterruptedException ie) {
        Thread.currentThread().interrupt();
      }
    }
    if (mDb == null) {
      throw lastSQLiteException;
    }
    // This is a sane limit to protect the user from the app storing too much data in the database.
    // This also protects the database from filling up the disk cache and becoming malformed
    // (endTransaction() calls will throw an exception, not rollback, and leave the db malformed).
    mDb.setMaximumSize(mMaximumDatabaseSize);
    return true;
  }

It seems we already have do something to avoid the SQLiteException, but actually it still happening when the app is in background.
As an Android native developer, it is hard to find a way to fix.

@zhuanghongji Do you have any reproduction steps or a project I could jump in and debug?

I think we have finally found a solution. The crash hasn't been reproduced for 24 hours in our new release.
One of libs uses AsyncStorage from react-native and the rest part of app use AsyncStorage from @react-native-community/async-storage.
The package was react-navigation 2.18.3. We created patch using npm patch-package-package

@Krizzu Actually,  i had tried my best  to find any reproduction steps but i can't find it now. The crash log is just copy from the Bugly (an exception reporting tool from Tencent).

@StanislavMayorov Here is my dependencies before:
"dependencies": {
    "@ant-design/react-native": "3.1.9",
    "@react-native-community/async-storage": "1.5.0",
    "@react-native-community/cameraroll": "^1.2.1",
    "@types/react-native-snap-carousel": "^3.7.4",
    "react": "16.8.3",
    "react-native": "0.59.9",
    "react-native-autotrack-growingio": "0.0.6",
    "react-native-gesture-handler": "1.3.0",
    "react-native-htmlview": "^0.15.0",
    "react-native-keyboard-aware-scroll-view": "^0.9.1",
    "react-native-linear-gradient": "2.5.4",
    "react-native-qrcode-svg": "5.3.2",
    "react-native-snap-carousel": "^3.8.4",
    "react-native-svg": "9.13.3",
    "react-native-swiper": "1.5.14",
    "react-native-view-shot": "^3.0.2",
    "react-navigation": "3.11.0",
  },

When i "Find in folder" in node_modules, i see there is import { AsyncStorage, ... } from 'react-native'  in @bang88/react-native-utilmate-listview/src/refreshableScrollView.android.js
In the next version app, i will try to upgrade the @react-native-community/async-storage to the latest release to see if any more Crash.

https://github.com/react-native-community/async-storage/issues/118#issuecomment-500138053 explains why the AsyncStorage version/package matters. I don't know if it could cause the 1032 or 1 error codes mentioned in this issue.

Closing due to inactivity.


additional config flags

#953
need to verify that values are passed on during generating msgs!

still does not provide values yet


License

Hello @AmirHosseinCH . I was wondering if you might consider assigning a specific license to your EmojiPicker project? Would you consider a permissive license such as MIT or BSD?
Please advise.

Hi, @kwallis . I added the MIT license to the repository.
However, keep in mind that this project has slight performance issues and is no longer being maintained.

Thanks very much @AmirHosseinCH


repo contains binaries that are had to verify

This repo contains some binaries used in benchmarks and tests:
$ find -type f -exec file {} \; > file-types
$ grep -Ev ': (empty|ASCII text|Unicode text|XML 1.0|JSON text|HTML document|exported SGML document|CSV text|troff or preprocessor|unified diff|PNG image|SVG Scalable Vector Graphics|SVG XML|PC bitmap|MS Windows icon resource|OpenType|TrueType|Web Open Font|Embedded OpenType|POSIX shell|Bourne-Again shell|DOS batch|C source|C\+\+ source|Algol 68 source)' file-types
./src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks/Resources/project.razor.bin: PGP Secret Sub-key -
./src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/TestFiles/BlazorProject.zip: Zip archive data, at least v2.0 to extract, compression method=deflate

Given the recent supply chain attack against xz, would it be possible to remove these binaries from the repo? Or, perhaps to generate them at build time? Or perhaps to have a way to reproduce/re-generate the binaries via some script/code to make the generation more auditable and reproducible?
cc @richlander

Just to be very clear to anyone reading, it's worth noting that the "binaries" identified under this issue are not executables or libraries, and do not contain any code. Additionally they do not ship with any product.
I would be very interested to know about any vulnerabilities or attack vectors these files create, but I personally can't think of one. Additionally I think generating these files at build time would obfuscate their contents and make it much harder to reason about when or how they might change.
For example, let's assume a malicious contributor wanted to replace the zip file with a zip bomb, as an attack of the build machines we use. If that file were generated by a script then we would have to validate all changes to the script, and any dependencies, to determine if it had changed in any malicious way. That would expose us to exactly the sort of supply chain attacks mentioned in the issue. As it stands now however, if a contributor opened a PR that modified the zip file in any way, it would be immediately suspicious and something we would definitely notice.

Read this post: https://gynvael.coldwind.pl/?lang=en&id=782


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit 586ef81:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch b58e8f8a-ef2f-4b24-bc16-2bd021fa5ffc has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


chore(examples): add examples

This commit adds examples to the jco, some of which are/will be referenced from the component-model book (https://component-model.bytecodealliance.org/).

I'm going to assume that the failing test is unrelated, considering none of the actually important code changed. Possibly a problem with ubuntu latest?

Yes, just a flake.

Hey @guybedford this is finally ready for review -- example CI is working properly

Sorry for the delay, thanks for the detailed review -- I was able to hit everything!


Incorrect data type used in MCP2515Class::setFilterRegisters() ?

Originally reported by @RudolfAtHome on https://github.com/sandeepmistry/arduino-CAN/issues/42#issuecomment-892905787
Here we're implicitly casting a bunch of uint16_t variables to uint8_t when we put them into an array:
https://github.com/timurrrr/arduino-CAN/blob/9823a1143c2bfc55ce97326b7e31e0e425ffdaf6/src/MCP2515.cpp#L420-L421
This was not intended, and probably causes bugs on certain compilers when using filters with any bits set in the more significant byte.

Can someone try replacing uint8_t on line 420 with uint16_t and test with some non-trivial filter?
It will probably take me a few weeks before I can find time to try to test it myself.

Hi,
first of all thank you for your amazing effort on this library! I wonder, why the "original" CAN library by @sandeepmistry is so popular although it still has not merged these many fundamental improvements and bugfixes you applied here!
In addition to the variable mentioned above I think that also the variable for the filter mask should be 16 bit. Like this:
for (int n = 0; n < 2; n++) {
    uint16_t mask = (n == 0) ? mask0 : mask1;
    writeRegister(REG_RXMnSIDH(n), mask >> 3);
    writeRegister(REG_RXMnSIDL(n), mask << 5);
    writeRegister(REG_RXMnEID8(n), 0);
    writeRegister(REG_RXMnEID0(n), 0);
  }

  uint16_t filter_array[6] =
      {filter0, filter1, filter2, filter3, filter4, filter5};
  for (int n = 0; n < 6; n++) {
    uint16_t id = filter_array[n];
    writeRegister(REG_RXFnSIDH(n), id >> 3);
    writeRegister(REG_RXFnSIDL(n), id << 5);
    writeRegister(REG_RXFnEID8(n), 0);
    writeRegister(REG_RXFnEID0(n), 0);
  }

I have not tested it, yet. But I think it makes sense

Thanks for the positive feedback, and for reporting this bug!
I agree that the bit math for SIDH is wrong:
boolean MCP2515Class::setFilterRegisters(
    uint16_t mask0, uint16_t filter0, uint16_t filter1,
    uint16_t mask1, uint16_t filter2, uint16_t filter3, uint16_t filter4, uint16_t filter5,
...
    uint8_t mask = (n == 0) ? mask0 : mask1;
    writeRegister(REG_RXMnSIDH(n), mask >> 3);
...
  uint8_t filter_array[6] =
      {filter0, filter1, filter2, filter3, filter4, filter5};
  ...
    uint8_t id = filter_array[n];
    writeRegister(REG_RXFnSIDH(n), id >> 3);
...

I wonder how this ever worked in my project, given that half of the CAN IDs my project is listening to are >255....
I'll try to find time to fix this and verify the fix.
(I think the SIDL values are correct though)

I wonder, why the "original" CAN library by @sandeepmistry is so popular although it still has not merged these many fundamental improvements and bugfixes you applied here!

I wonder the same haha

I wonder how this ever worked in my project, given that half of the CAN IDs my project is listening to are >255....

Oh, I guess it's the classic case of "even number of mistakes in bit math gives a correct(ish) result"! 😂
Since the first conversion turns the higher bits of RXMnSIDH to 0,
the incorrect higher bits of RXFnSIDH get ignored.


401 Unauthorized metadata-export-search request on search page requests

Describe the bug
As an anonymous user, when navigating DSpace, on search pages (I've also found this in Apache Logs), I encounter some metadata-export-search requests that always return 401 Unauthorized codes. This isn't the problem, is expected to return that result. The problem is why the requests are made in the first place. Shouldn't we use some kind of feature request to validate the access?

To Reproduce
Steps to reproduce the behavior:

I used demo.dspace.org to reproduce the issue (DSpace 8, but also affects DSpace 7.6.1)
I first access to the first page
Then, did a search (without any search keyword)
List every request using Browser's DevTools and there was the 401 Unauthorized

Expected behavior
I was expecting that features requests could be used instead. Something like:
https://demo.dspace.org/server/api/authz/authorizations/search/object?uri=https://demo.dspace.org/server/api/...&feature=...&embed=feature

This is also the cause of the following message in the backend dspace.log:
2024-10-25 14:47:37,679 WARN  fd564310-3d47-4a8e-9b4a-4af6105b9175 f3c1cdd4-00db-4bb8-bac2-9cbb86602209 org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice @ Authentication is required (status:401 exception: Access is denied at: org.springframework.security.access.vote.AffirmativeBased.decide(AffirmativeBased.java:73))

Considering that we log this message for every single request to the search page by a non-admin user, it seems that this actually belongs at INFO or DEBUG log level.


Request: camera optical zoom support

[x] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
This is a feature request! I'd love to be able to use the optical zoom on my cameras when doing --video-source=camera!
Describe the solution you'd like
--camera-zoom 1.5 would ideally zoom to 1.5x, in my view.
Describe alternatives you've considered
I don't know? It'd be neat to be able to change the zoom live. I don't know if scrcpy has any other properties that are potentially dynamic like this?
One wild alternative would be to build a camera app that exposes a way to zoom and to stream the phone output, rather than a video camera. This feels like it would have more latency & overhead, & would require some app dev.
Additional context
Now that we can stream cameras, there's a host of various video settings that would be nice to be able to tune. Maybe there's some android app that can help us do this? Things like contrast, exposure compensation, color balance, even ideally things like having LUTs or log-output control would be incredible to add, especially if we can dynamically adjust some of these settings.

--camera-zoom 1.5 would ideally zoom to 1.5x, in my view.

Yes, technically it's possible.

It'd be neat to be able to change the zoom live.

Yes. It will require some changes in the control code, because currently controls are disabled when video source is camera (as if --no-control was passed)..

Other camera "PRO" features would be great as well, like focus, exposure and such. I don't know how many camera features are exposed though.

Most phones accomplish optical zoom with separate cameras. The Pixel 8 Pro has three rear cameras, each with its own lens and and sensor. I wonder if its possible to have them return separate camera-id's.
I would want to select the lens being used instead of relying on a continuous camera-zoom parameter and allowing the phone to determine the camera.

@whatupjeff You might be interested in the whole discussion about physical/logical cameras here: https://github.com/Genymobile/scrcpy/issues/4392#issuecomment-1792867089 (and further comments).

speaking of zoom, i was wondering if it was possible to switch witch lens was being used to the wide angle lens in my case or the telephoto lens ( not necessarily on the fly )

Other camera "PRO" features would be great as well, like focus, exposure and such. I don't know how many camera features are exposed though.

Has anyone else looked into it? Iirc the other day when I was going through the api documentation, there was a mention of an endpoint that allowed you to choose an auto-exposure & antibanding mode from the profiles available...

Has anyone else looked into it? Iirc the other day when I was going through the api documentation, there was a mention of an endpoint that allowed you to choose an auto-exposure & antibanding mode from the profiles available...
@sortedcord Please let me know if you found a solution

@rom1v Sorry for the ping, but what are the chances of manual exposure and autofocus control coming soon ?

what are the chances of manual exposure and autofocus control coming soon ?

I don't plan to implement them soon. There are other things to work on.

@rom1v Sorry for the ping, but what are the chances of manual exposure and autofocus control coming soon ?

 I want that. Right now I'm recording my desktop table from above with smartphone with scrcpy, and some times happens this.
Of course I would like a full manual control like Pro Mode in smartphone cameras but maybe it's a niche use. Photography enthusiast here.
Talking about zoom ... I did try crop command with --video-source=camera and didn't work, there is a way to do that? or zoom in?

I needed to be able to lock exposure and such manually for my usecase. I don't know if ill make this actually usable via cli options and such since I basically never need them changed but if anyone is in a similar boat and doesnt mind changing source code here is the change I made (in server/src/main/java/com/genymobile/scrcpy/video/CameraCapture.java:
    private CaptureRequest createCaptureRequest(Surface surface) throws CameraAccessException {
        CaptureRequest.Builder requestBuilder = cameraDevice.createCaptureRequest(CameraDevice.TEMPLATE_RECORD);
        requestBuilder.addTarget(surface);

        // Have to turn this off to be able to control ae, awb, and af separately from what I can tell.
        requestBuilder.set(CaptureRequest.CONTROL_MODE, CaptureRequest.CONTROL_MODE_OFF);
        // Turn off auto exposure
        requestBuilder.set(CaptureRequest.CONTROL_AE_MODE, CaptureRequest.CONTROL_AE_MODE_OFF);
        // Handle white balance automatically
        requestBuilder.set(CaptureRequest.CONTROL_AWB_MODE,
                CaptureRequest.CONTROL_AWB_MODE_AUTO);
        // Auto focus on auto
        requestBuilder.set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_AUTO);
        // Setting sensor sensitivity this is basically iso
        requestBuilder.set(CaptureRequest.SENSOR_SENSITIVITY, 150);

        // Setting sensor exposure time this and frame duration are in nano seconds. So this would be roughly 1/60th of a second
        requestBuilder.set(CaptureRequest.SENSOR_EXPOSURE_TIME, 16000000L);

        // Frame rate im pretty sure so this is roughly 1/30th of a second or 30fps :P
        requestBuilder.set(CaptureRequest.SENSOR_FRAME_DURATION, 33000000L);

        if (fps > 0) {
            requestBuilder.set(CaptureRequest.CONTROL_AE_TARGET_FPS_RANGE, new Range<>(fps, fps));
        }

        return requestBuilder.build();
    }


Terminal not working

Issue Type: Feature Request
The terminal shell path "C:\msys64\usr\bin\bash.exe" does not exist
Please how can i fix this?
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:45:59.656Z)
OS version: Windows_NT x64 10.0.18363

Does the path exist?


Create quay.io image (public)

Create a quay.io image to be used in the GitAction/Runner for the testing of changes against a pull request. Task 3 from https://github.com/opendatahub-io/model-registry/issues/187
Definition of Done
When the pushed image can be pulled and used locally to run all GoLang or Robot Framework tests.

Completed

Completed


Cata Classic support

Hello.
First of all, thank you for a nice mod which helps a lot on loot priority!
Do you have any plans to update it to Cata Classic? BiS list are already there both on wowtbc.gg and wowhead.com.
Thank you in adnvance!

I'm planning to start working on a Cata version after all the bis lists are published. As I can see, they only released pre-patch bis lists on wowhead atm.

Fair enough. Looking forward for updated version.


[libSyntax] Don't store SynKind and TokKind as uint16_t

There is no point storing SynKind and TokKind as uint16_ts inside ParsedRawSyntaxNode. Instead, we can just use the enum class types that define them.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - dfcf2e4cf9c99a63060af35bbd023656ba2252c7

Build failed
Swift Test OS X Platform
Git Sha - dfcf2e4cf9c99a63060af35bbd023656ba2252c7

@swift-ci Please test


Added Support for  links

Description
This update adds support for <seealso cref=""/> and <seealso href=""/> links for types and members.  A new SeeAlsoTag type contains the Cref, Href, and Text for any seealso link encountered.
How Has This Been Tested?
This was tested by adding <seealso /> links to the XML docs for the MyClass test class, and adding a unit test which ensures the links are parsed properly.
Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[X] I've added relevant tests.

Thanks for the wonderful library, @loxsmoke !  Let me know if you want me to roll back the other whitespace changes; I habitually do a Format Document before saving lol.

Great pull request!
Whitespace changes are OK.  Let's keep them.


Add gitpod config

Adds gitpod config so that we can run the Spawn Demo repository in GitPod in its entirety with Spawn provisioned databases.

Did you have to authorize the gitpod app against the Redgate GH org in order to get this to work?

Did you have to authorize the gitpod app against the Redgate GH org in order to get this to work?

Not to my knowledge. I logged in with GitPod and it checked out the repo (presumably using my GitHub credentials as thats the auth provider I chose).
Hitting F5 then just spins things up as you'd expect (though you must first authenticate which the terminal guides you through).
Unfortunately, there's issues with the VS Code marketplace at the moment as described at https://www.gitpodstatus.com/ so the C# extension isn't installing which means the .NET Core API won't start just yet. But I'm hoping that resolves once the incident is resolved.


Add ability to update rate limiter

Signed-off-by: Won Jun Jang<EMAIL_ADDRESS>Which problem is this PR solving?

The current way the rate limiting sampler is updated involves the sampler being reconstructed; this has the unfortunate side effect of the balance being reinitialized to full which will generate a new sample. If you are updating thousands of instances with a new rate limiting rate, this will generate thousands of new traces. This PR adds the ability to update the rate limiter so that the proportional balance is retained on update.

Short description of the changes

Rename rateLimiter to RateLimiterImpl (LeakyBucketRateLimiter?)
Add Update function to RateLimiterImpl
Update all samplers to allow updating of RateLimiter

closing as stale


Add O365 group example and update dynamic groups

This was missing an example for creating an Office 365 group. This also did not reference AzureADPreview was needed as a pre-req to create dynamic groups, which is now added.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bspender sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Docs Build status updates of commit 2488599:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

.openpublishing.publish.config.json
:x:Error

Details

Line 117: [Error] Restore nuget package W:\5aks-s\.optemp\dependentPackages\opbuild.templates.azurecli\packages.config in folder:W:\5aks-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp and include the build report and the following error message for our team to troubleshoot:  Errors in packages.config projects     Unable to find version '1.67.3' of package 'opbuild.templates.azurecli'.       D:\Windows\system32\config\systemprofile\.nuget\packages\: Package 'opbuild.templates.azurecli.1.67.3' is not found on source 'D:\Windows\system32\config\systemprofile\.nuget\packages\'.       https://www.myget.org/F/op/api/v2: Package 'opbuild.templates.azurecli.1.67.3' is not found on source 'https://www.myget.org/F/op/api/v2'.

.openpublishing.publish.config.json

Line 290: [Error] Restore of dependent packages failed. Please check your .openpublishing.publish.config.json?on the configuration of the dependent packages or ask for help?in Docs Support teams channel. Please also include the following error code for our team to troubleshoot: 1

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hi @bspender
Per the read me file:
Please be aware that if you have any updates to automatically generated reference content, you should create an issue and not a PR.  The issue will then be created into a bug and triaged accordingly.  We do this because the reference content must mirror the *dll-help.xml file and subsequent updates to the reference content may overwrite any changes made through the repo.  Capturing it in the source code ensures that this does not occur.  Any PR with changes to automatically generated reference content will be closed.
Automatically generated reference content is any of the content under this Reference node, such as Get-AzureADUser
This only applies to reference content and not conceptual content.  Pull requests for changes to conceptual content are accepted and encouraged.  An example of the conceptual content is the Overview or a scenario such as importing data.
Thank you!
Bill